GitHub PullRequestReviewCommentEvent at 2014-09-23 08:57:29
Repository: invenio
Actor: jmartinm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/17897626","id":17897626,"diff_hunk":"@@ -349,7 +349,7 @@ def status(deposition_type=None, uuid=None, draft_id=None):\n \n \n #@blueprint.route('/%s/<int:uuid>/file/url/' % deptypes, methods=['POST'])\n-@blueprint.route('/<int:uuid>/file/url/', methods=['POST'])\n+@blueprint.route('/<depositions:deposition_type>/<int:uuid>/file/url/', methods=['POST'])","path":"invenio/modules/deposit/views/deposit.py","position":5,"original_position":5,"commit_id":"e1da3e6bf2e8da1d9cafe8b1ad1c56094601d670","original_commit_id":"e1da3e6bf2e8da1d9cafe8b1ad1c56094601d670","user":{"login":"jmartinm","id":580727,"avatar_url":"https://avatars.githubusercontent.com/u/580727?v=2","gravatar_id":"","url":"https://api.github.com/users/jmartinm","html_url":"https://github.com/jmartinm","followers_url":"https://api.github.com/users/jmartinm/followers","following_url":"https://api.github.com/users/jmartinm/following{/other_user}","gists_url":"https://api.github.com/users/jmartinm/gists{/gist_id}","starred_url":"https://api.github.com/users/jmartinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmartinm/subscriptions","organizations_url":"https://api.github.com/users/jmartinm/orgs","repos_url":"https://api.github.com/users/jmartinm/repos","events_url":"https://api.github.com/users/jmartinm/events{/privacy}","received_events_url":"https://api.github.com/users/jmartinm/received_events","type":"User","site_admin":false},"body":"I was not removing ```'/<int:uuid>/file/url/'```, just setting it back to how it used to be (see line commented on top:\r\n\r\n```#@blueprint.route('/%s/<int:uuid>/file/url/' % deptypes, methods=['POST'])```\r\n\r\nWithout ```<depositions:deposition_type>``` the url_for:\r\n\r\n```python\r\nurl_for('.delete_file', deposition_type=deposition_type, uuid=uuid) }}'\r\n```\r\nDoes not work properly as it appears like:\r\n\r\n```\r\nhttp://localhost/deposit/53/?deposition_type=literature\r\n```\r\nAnd that breaks the server side when it tries to get the file id that should be POSTed by plupload.","created_at":"2014-09-23T08:57:29Z","updated_at":"2014-09-23T08:57:29Z","html_url":"https://github.com/inveniosoftware/invenio/pull/2318#discussion_r17897626","pull_request_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2318","_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/17897626"},"html":{"href":"https://github.com/inveniosoftware/invenio/pull/2318#discussion_r17897626"},"pull_request":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2318"}}},"pull_request":{"url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2318","id":21582310,"html_url":"https://github.com/inveniosoftware/invenio/pull/2318","diff_url":"https://github.com/inveniosoftware/invenio/pull/2318.diff","patch_url":"https://github.com/inveniosoftware/invenio/pull/2318.patch","issue_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2318","number":2318,"state":"open","locked":false,"title":"WIP deposit: plupload improvements","user":{"login":"jmartinm","id":580727,"avatar_url":"https://avatars.githubusercontent.com/u/580727?v=2","gravatar_id":"","url":"https://api.github.com/users/jmartinm","html_url":"https://github.com/jmartinm","followers_url":"https://api.github.com/users/jmartinm/followers","following_url":"https://api.github.com/users/jmartinm/following{/other_user}","gists_url":"https://api.github.com/users/jmartinm/gists{/gist_id}","starred_url":"https://api.github.com/users/jmartinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmartinm/subscriptions","organizations_url":"https://api.github.com/users/jmartinm/orgs","repos_url":"https://api.github.com/users/jmartinm/repos","events_url":"https://api.github.com/users/jmartinm/events{/privacy}","received_events_url":"https://api.github.com/users/jmartinm/received_events","type":"User","site_admin":false},"body":"* Allows autoupload on file selected.\r\n\r\n* Fixes a bug when deleting a file right after uploading it.\r\n\r\n* Fix in Blueprint url endpoints for upload urls.\r\n\r\n* NOTE Removes check for duplicated file. To enable it, add\r\n  filters: { prevent_duplicates: true } to plupload configuration.\r\n\r\nSigned-off-by: Javier Martin Montull <javier.martin.montull@cern.ch>","created_at":"2014-09-22T14:20:26Z","updated_at":"2014-09-23T08:57:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8b19530f911cc69eacd1f6bdf87fe33048bdc0e","assignee":{"login":"lnielsen-cern","id":1698163,"avatar_url":"https://avatars.githubusercontent.com/u/1698163?v=2","gravatar_id":"","url":"https://api.github.com/users/lnielsen-cern","html_url":"https://github.com/lnielsen-cern","followers_url":"https://api.github.com/users/lnielsen-cern/followers","following_url":"https://api.github.com/users/lnielsen-cern/following{/other_user}","gists_url":"https://api.github.com/users/lnielsen-cern/gists{/gist_id}","starred_url":"https://api.github.com/users/lnielsen-cern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnielsen-cern/subscriptions","organizations_url":"https://api.github.com/users/lnielsen-cern/orgs","repos_url":"https://api.github.com/users/lnielsen-cern/repos","events_url":"https://api.github.com/users/lnielsen-cern/events{/privacy}","received_events_url":"https://api.github.com/users/lnielsen-cern/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/inveniosoftware/invenio/milestones/11","labels_url":"https://api.github.com/repos/inveniosoftware/invenio/milestones/11/labels","id":769792,"number":11,"title":"v2.0.x","description":null,"creator":{"login":"tiborsimko","id":517546,"avatar_url":"https://avatars.githubusercontent.com/u/517546?v=2","gravatar_id":"","url":"https://api.github.com/users/tiborsimko","html_url":"https://github.com/tiborsimko","followers_url":"https://api.github.com/users/tiborsimko/followers","following_url":"https://api.github.com/users/tiborsimko/following{/other_user}","gists_url":"https://api.github.com/users/tiborsimko/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborsimko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborsimko/subscriptions","organizations_url":"https://api.github.com/users/tiborsimko/orgs","repos_url":"https://api.github.com/users/tiborsimko/repos","events_url":"https://api.github.com/users/tiborsimko/events{/privacy}","received_events_url":"https://api.github.com/users/tiborsimko/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":26,"state":"open","created_at":"2014-08-28T16:18:55Z","updated_at":"2014-09-22T18:03:30Z","due_on":null},"commits_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2318/commits","review_comments_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2318/comments","review_comment_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2318/comments","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio/statuses/e1da3e6bf2e8da1d9cafe8b1ad1c56094601d670","head":{"label":"jmartinm:plupload-improvements-pu","ref":"plupload-improvements-pu","sha":"e1da3e6bf2e8da1d9cafe8b1ad1c56094601d670","user":{"login":"jmartinm","id":580727,"avatar_url":"https://avatars.githubusercontent.com/u/580727?v=2","gravatar_id":"","url":"https://api.github.com/users/jmartinm","html_url":"https://github.com/jmartinm","followers_url":"https://api.github.com/users/jmartinm/followers","following_url":"https://api.github.com/users/jmartinm/following{/other_user}","gists_url":"https://api.github.com/users/jmartinm/gists{/gist_id}","starred_url":"https://api.github.com/users/jmartinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmartinm/subscriptions","organizations_url":"https://api.github.com/users/jmartinm/orgs","repos_url":"https://api.github.com/users/jmartinm/repos","events_url":"https://api.github.com/users/jmartinm/events{/privacy}","received_events_url":"https://api.github.com/users/jmartinm/received_events","type":"User","site_admin":false},"repo":{"id":20687062,"name":"invenio","full_name":"jmartinm/invenio","owner":{"login":"jmartinm","id":580727,"avatar_url":"https://avatars.githubusercontent.com/u/580727?v=2","gravatar_id":"","url":"https://api.github.com/users/jmartinm","html_url":"https://github.com/jmartinm","followers_url":"https://api.github.com/users/jmartinm/followers","following_url":"https://api.github.com/users/jmartinm/following{/other_user}","gists_url":"https://api.github.com/users/jmartinm/gists{/gist_id}","starred_url":"https://api.github.com/users/jmartinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmartinm/subscriptions","organizations_url":"https://api.github.com/users/jmartinm/orgs","repos_url":"https://api.github.com/users/jmartinm/repos","events_url":"https://api.github.com/users/jmartinm/events{/privacy}","received_events_url":"https://api.github.com/users/jmartinm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmartinm/invenio","description":"Invenio digital library software","fork":true,"url":"https://api.github.com/repos/jmartinm/invenio","forks_url":"https://api.github.com/repos/jmartinm/invenio/forks","keys_url":"https://api.github.com/repos/jmartinm/invenio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmartinm/invenio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmartinm/invenio/teams","hooks_url":"https://api.github.com/repos/jmartinm/invenio/hooks","issue_events_url":"https://api.github.com/repos/jmartinm/invenio/issues/events{/number}","events_url":"https://api.github.com/repos/jmartinm/invenio/events","assignees_url":"https://api.github.com/repos/jmartinm/invenio/assignees{/user}","branches_url":"https://api.github.com/repos/jmartinm/invenio/branches{/branch}","tags_url":"https://api.github.com/repos/jmartinm/invenio/tags","blobs_url":"https://api.github.com/repos/jmartinm/invenio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmartinm/invenio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmartinm/invenio/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmartinm/invenio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmartinm/invenio/statuses/{sha}","languages_url":"https://api.github.com/repos/jmartinm/invenio/languages","stargazers_url":"https://api.github.com/repos/jmartinm/invenio/stargazers","contributors_url":"https://api.github.com/repos/jmartinm/invenio/contributors","subscribers_url":"https://api.github.com/repos/jmartinm/invenio/subscribers","subscription_url":"https://api.github.com/repos/jmartinm/invenio/subscription","commits_url":"https://api.github.com/repos/jmartinm/invenio/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmartinm/invenio/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmartinm/invenio/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmartinm/invenio/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmartinm/invenio/contents/{+path}","compare_url":"https://api.github.com/repos/jmartinm/invenio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmartinm/invenio/merges","archive_url":"https://api.github.com/repos/jmartinm/invenio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmartinm/invenio/downloads","issues_url":"https://api.github.com/repos/jmartinm/invenio/issues{/number}","pulls_url":"https://api.github.com/repos/jmartinm/invenio/pulls{/number}","milestones_url":"https://api.github.com/repos/jmartinm/invenio/milestones{/number}","notifications_url":"https://api.github.com/repos/jmartinm/invenio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmartinm/invenio/labels{/name}","releases_url":"https://api.github.com/repos/jmartinm/invenio/releases{/id}","created_at":"2014-06-10T13:52:50Z","updated_at":"2014-06-24T09:39:13Z","pushed_at":"2014-09-22T14:18:22Z","git_url":"git://github.com/jmartinm/invenio.git","ssh_url":"git@github.com:jmartinm/invenio.git","clone_url":"https://github.com/jmartinm/invenio.git","svn_url":"https://github.com/jmartinm/invenio","homepage":"http://invenio-software.org/","size":72438,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inveniosoftware:pu","ref":"pu","sha":"4bb5a8a0980ab58c7ba10a12d751aa6801afb873","user":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars.githubusercontent.com/u/1157480?v=2","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":2665618,"name":"invenio","full_name":"inveniosoftware/invenio","owner":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars.githubusercontent.com/u/1157480?v=2","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inveniosoftware/invenio","description":"Invenio digital library software","fork":false,"url":"https://api.github.com/repos/inveniosoftware/invenio","forks_url":"https://api.github.com/repos/inveniosoftware/invenio/forks","keys_url":"https://api.github.com/repos/inveniosoftware/invenio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inveniosoftware/invenio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inveniosoftware/invenio/teams","hooks_url":"https://api.github.com/repos/inveniosoftware/invenio/hooks","issue_events_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/events{/number}","events_url":"https://api.github.com/repos/inveniosoftware/invenio/events","assignees_url":"https://api.github.com/repos/inveniosoftware/invenio/assignees{/user}","branches_url":"https://api.github.com/repos/inveniosoftware/invenio/branches{/branch}","tags_url":"https://api.github.com/repos/inveniosoftware/invenio/tags","blobs_url":"https://api.github.com/repos/inveniosoftware/invenio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inveniosoftware/invenio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inveniosoftware/invenio/git/refs{/sha}","trees_url":"https://api.github.com/repos/inveniosoftware/invenio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio/statuses/{sha}","languages_url":"https://api.github.com/repos/inveniosoftware/invenio/languages","stargazers_url":"https://api.github.com/repos/inveniosoftware/invenio/stargazers","contributors_url":"https://api.github.com/repos/inveniosoftware/invenio/contributors","subscribers_url":"https://api.github.com/repos/inveniosoftware/invenio/subscribers","subscription_url":"https://api.github.com/repos/inveniosoftware/invenio/subscription","commits_url":"https://api.github.com/repos/inveniosoftware/invenio/commits{/sha}","git_commits_url":"https://api.github.com/repos/inveniosoftware/invenio/git/commits{/sha}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/comments{/number}","issue_comment_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/comments/{number}","contents_url":"https://api.github.com/repos/inveniosoftware/invenio/contents/{+path}","compare_url":"https://api.github.com/repos/inveniosoftware/invenio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inveniosoftware/invenio/merges","archive_url":"https://api.github.com/repos/inveniosoftware/invenio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inveniosoftware/invenio/downloads","issues_url":"https://api.github.com/repos/inveniosoftware/invenio/issues{/number}","pulls_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls{/number}","milestones_url":"https://api.github.com/repos/inveniosoftware/invenio/milestones{/number}","notifications_url":"https://api.github.com/repos/inveniosoftware/invenio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inveniosoftware/invenio/labels{/name}","releases_url":"https://api.github.com/repos/inveniosoftware/invenio/releases{/id}","created_at":"2011-10-28T14:33:51Z","updated_at":"2014-09-22T19:11:25Z","pushed_at":"2014-09-23T07:48:10Z","git_url":"git://github.com/inveniosoftware/invenio.git","ssh_url":"git@github.com:inveniosoftware/invenio.git","clone_url":"https://github.com/inveniosoftware/invenio.git","svn_url":"https://github.com/inveniosoftware/invenio","homepage":"http://invenio-software.org/","size":85879,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":845,"forks":92,"open_issues":845,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2318"},"html":{"href":"https://github.com/inveniosoftware/invenio/pull/2318"},"issue":{"href":"https://api.github.com/repos/inveniosoftware/invenio/issues/2318"},"comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio/issues/2318/comments"},"review_comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2318/comments"},"review_comment":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2318/commits"},"statuses":{"href":"https://api.github.com/repos/inveniosoftware/invenio/statuses/e1da3e6bf2e8da1d9cafe8b1ad1c56094601d670"}}}}