GitHub PullRequestReviewCommentEvent at 2014-10-09 18:12:56
Repository: FiberCompression
Actor: jchoude
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/scilus/FiberCompression/pulls/comments/18663224","id":18663224,"diff_hunk":"@@ -1552,12 +1552,12 @@ bool Fibers::loadDmri(const QString& filename)\n         addFiberToPointArray(fiberArray);\n     }\n     saveResults(\"Original total number of points : \" + QString::number(countPoints) + \"\\n\");\n-    \n+\n     fclose( pFile );\n     return true;\n }\n \n-#include <arpa/inet.h>\n+//#include <arpa/inet.h>","path":"src/Fibers.cpp","position":799,"original_position":799,"commit_id":"25a1a0a511b6d9323e5dd91aabdab0139bd79221","original_commit_id":"25a1a0a511b6d9323e5dd91aabdab0139bd79221","user":{"login":"jchoude","id":2151032,"avatar_url":"https://avatars.githubusercontent.com/u/2151032?v=2","gravatar_id":"","url":"https://api.github.com/users/jchoude","html_url":"https://github.com/jchoude","followers_url":"https://api.github.com/users/jchoude/followers","following_url":"https://api.github.com/users/jchoude/following{/other_user}","gists_url":"https://api.github.com/users/jchoude/gists{/gist_id}","starred_url":"https://api.github.com/users/jchoude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchoude/subscriptions","organizations_url":"https://api.github.com/users/jchoude/orgs","repos_url":"https://api.github.com/users/jchoude/repos","events_url":"https://api.github.com/users/jchoude/events{/privacy}","received_events_url":"https://api.github.com/users/jchoude/received_events","type":"User","site_admin":false},"body":"Why did you comment this?","created_at":"2014-10-09T18:12:56Z","updated_at":"2014-10-09T18:12:56Z","html_url":"https://github.com/scilus/FiberCompression/pull/5#discussion_r18663224","pull_request_url":"https://api.github.com/repos/scilus/FiberCompression/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/scilus/FiberCompression/pulls/comments/18663224"},"html":{"href":"https://github.com/scilus/FiberCompression/pull/5#discussion_r18663224"},"pull_request":{"href":"https://api.github.com/repos/scilus/FiberCompression/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/scilus/FiberCompression/pulls/5","id":22418509,"html_url":"https://github.com/scilus/FiberCompression/pull/5","diff_url":"https://github.com/scilus/FiberCompression/pull/5.diff","patch_url":"https://github.com/scilus/FiberCompression/pull/5.patch","issue_url":"https://api.github.com/repos/scilus/FiberCompression/issues/5","number":5,"state":"open","locked":false,"title":"Update string handling for file names","user":{"login":"matthieudumont","id":1280738,"avatar_url":"https://avatars.githubusercontent.com/u/1280738?v=2","gravatar_id":"","url":"https://api.github.com/users/matthieudumont","html_url":"https://github.com/matthieudumont","followers_url":"https://api.github.com/users/matthieudumont/followers","following_url":"https://api.github.com/users/matthieudumont/following{/other_user}","gists_url":"https://api.github.com/users/matthieudumont/gists{/gist_id}","starred_url":"https://api.github.com/users/matthieudumont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthieudumont/subscriptions","organizations_url":"https://api.github.com/users/matthieudumont/orgs","repos_url":"https://api.github.com/users/matthieudumont/repos","events_url":"https://api.github.com/users/matthieudumont/events{/privacy}","received_events_url":"https://api.github.com/users/matthieudumont/received_events","type":"User","site_admin":false},"body":"I had a crash with the x64 windows build I made on pretty much each fopen. x86 works just fine.\r\nI found out that it actually crashed on filename.toStdString().c_str().\r\nI replaced each of them by filename.toUtf8().constData(). Why? Because there was this one place in the code that didnt crash and used this. I didnt do more research honestly, but this definitly fixes it for me. \r\n\r\nSorry for all the diffs, my VS removes extra spacing when I save. Just search for fopen to go to actual changes. ","created_at":"2014-10-08T12:15:16Z","updated_at":"2014-10-09T18:12:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46a06ce40b87105abc29f89c27ec4e1208cb2f98","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scilus/FiberCompression/pulls/5/commits","review_comments_url":"https://api.github.com/repos/scilus/FiberCompression/pulls/5/comments","review_comment_url":"https://api.github.com/repos/scilus/FiberCompression/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scilus/FiberCompression/issues/5/comments","statuses_url":"https://api.github.com/repos/scilus/FiberCompression/statuses/25a1a0a511b6d9323e5dd91aabdab0139bd79221","head":{"label":"matthieudumont:fopen_win_64","ref":"fopen_win_64","sha":"25a1a0a511b6d9323e5dd91aabdab0139bd79221","user":{"login":"matthieudumont","id":1280738,"avatar_url":"https://avatars.githubusercontent.com/u/1280738?v=2","gravatar_id":"","url":"https://api.github.com/users/matthieudumont","html_url":"https://github.com/matthieudumont","followers_url":"https://api.github.com/users/matthieudumont/followers","following_url":"https://api.github.com/users/matthieudumont/following{/other_user}","gists_url":"https://api.github.com/users/matthieudumont/gists{/gist_id}","starred_url":"https://api.github.com/users/matthieudumont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthieudumont/subscriptions","organizations_url":"https://api.github.com/users/matthieudumont/orgs","repos_url":"https://api.github.com/users/matthieudumont/repos","events_url":"https://api.github.com/users/matthieudumont/events{/privacy}","received_events_url":"https://api.github.com/users/matthieudumont/received_events","type":"User","site_admin":false},"repo":{"id":24906751,"name":"FiberCompression","full_name":"matthieudumont/FiberCompression","owner":{"login":"matthieudumont","id":1280738,"avatar_url":"https://avatars.githubusercontent.com/u/1280738?v=2","gravatar_id":"","url":"https://api.github.com/users/matthieudumont","html_url":"https://github.com/matthieudumont","followers_url":"https://api.github.com/users/matthieudumont/followers","following_url":"https://api.github.com/users/matthieudumont/following{/other_user}","gists_url":"https://api.github.com/users/matthieudumont/gists{/gist_id}","starred_url":"https://api.github.com/users/matthieudumont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthieudumont/subscriptions","organizations_url":"https://api.github.com/users/matthieudumont/orgs","repos_url":"https://api.github.com/users/matthieudumont/repos","events_url":"https://api.github.com/users/matthieudumont/events{/privacy}","received_events_url":"https://api.github.com/users/matthieudumont/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthieudumont/FiberCompression","description":"A tool for tractography streamlines compression","fork":true,"url":"https://api.github.com/repos/matthieudumont/FiberCompression","forks_url":"https://api.github.com/repos/matthieudumont/FiberCompression/forks","keys_url":"https://api.github.com/repos/matthieudumont/FiberCompression/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthieudumont/FiberCompression/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthieudumont/FiberCompression/teams","hooks_url":"https://api.github.com/repos/matthieudumont/FiberCompression/hooks","issue_events_url":"https://api.github.com/repos/matthieudumont/FiberCompression/issues/events{/number}","events_url":"https://api.github.com/repos/matthieudumont/FiberCompression/events","assignees_url":"https://api.github.com/repos/matthieudumont/FiberCompression/assignees{/user}","branches_url":"https://api.github.com/repos/matthieudumont/FiberCompression/branches{/branch}","tags_url":"https://api.github.com/repos/matthieudumont/FiberCompression/tags","blobs_url":"https://api.github.com/repos/matthieudumont/FiberCompression/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthieudumont/FiberCompression/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthieudumont/FiberCompression/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthieudumont/FiberCompression/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthieudumont/FiberCompression/statuses/{sha}","languages_url":"https://api.github.com/repos/matthieudumont/FiberCompression/languages","stargazers_url":"https://api.github.com/repos/matthieudumont/FiberCompression/stargazers","contributors_url":"https://api.github.com/repos/matthieudumont/FiberCompression/contributors","subscribers_url":"https://api.github.com/repos/matthieudumont/FiberCompression/subscribers","subscription_url":"https://api.github.com/repos/matthieudumont/FiberCompression/subscription","commits_url":"https://api.github.com/repos/matthieudumont/FiberCompression/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthieudumont/FiberCompression/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthieudumont/FiberCompression/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthieudumont/FiberCompression/issues/comments/{number}","contents_url":"https://api.github.com/repos/matthieudumont/FiberCompression/contents/{+path}","compare_url":"https://api.github.com/repos/matthieudumont/FiberCompression/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthieudumont/FiberCompression/merges","archive_url":"https://api.github.com/repos/matthieudumont/FiberCompression/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthieudumont/FiberCompression/downloads","issues_url":"https://api.github.com/repos/matthieudumont/FiberCompression/issues{/number}","pulls_url":"https://api.github.com/repos/matthieudumont/FiberCompression/pulls{/number}","milestones_url":"https://api.github.com/repos/matthieudumont/FiberCompression/milestones{/number}","notifications_url":"https://api.github.com/repos/matthieudumont/FiberCompression/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthieudumont/FiberCompression/labels{/name}","releases_url":"https://api.github.com/repos/matthieudumont/FiberCompression/releases{/id}","created_at":"2014-10-07T19:03:14Z","updated_at":"2014-10-06T13:29:42Z","pushed_at":"2014-10-07T19:42:02Z","git_url":"git://github.com/matthieudumont/FiberCompression.git","ssh_url":"git@github.com:matthieudumont/FiberCompression.git","clone_url":"https://github.com/matthieudumont/FiberCompression.git","svn_url":"https://github.com/matthieudumont/FiberCompression","homepage":"","size":1167,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scilus:master","ref":"master","sha":"bdd787a0553fd5dd2f58fe7dd6ade9701f8c49bb","user":{"login":"scilus","id":3777753,"avatar_url":"https://avatars.githubusercontent.com/u/3777753?v=2","gravatar_id":"","url":"https://api.github.com/users/scilus","html_url":"https://github.com/scilus","followers_url":"https://api.github.com/users/scilus/followers","following_url":"https://api.github.com/users/scilus/following{/other_user}","gists_url":"https://api.github.com/users/scilus/gists{/gist_id}","starred_url":"https://api.github.com/users/scilus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scilus/subscriptions","organizations_url":"https://api.github.com/users/scilus/orgs","repos_url":"https://api.github.com/users/scilus/repos","events_url":"https://api.github.com/users/scilus/events{/privacy}","received_events_url":"https://api.github.com/users/scilus/received_events","type":"Organization","site_admin":false},"repo":{"id":19286544,"name":"FiberCompression","full_name":"scilus/FiberCompression","owner":{"login":"scilus","id":3777753,"avatar_url":"https://avatars.githubusercontent.com/u/3777753?v=2","gravatar_id":"","url":"https://api.github.com/users/scilus","html_url":"https://github.com/scilus","followers_url":"https://api.github.com/users/scilus/followers","following_url":"https://api.github.com/users/scilus/following{/other_user}","gists_url":"https://api.github.com/users/scilus/gists{/gist_id}","starred_url":"https://api.github.com/users/scilus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scilus/subscriptions","organizations_url":"https://api.github.com/users/scilus/orgs","repos_url":"https://api.github.com/users/scilus/repos","events_url":"https://api.github.com/users/scilus/events{/privacy}","received_events_url":"https://api.github.com/users/scilus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scilus/FiberCompression","description":"A tool for tractography streamlines compression","fork":false,"url":"https://api.github.com/repos/scilus/FiberCompression","forks_url":"https://api.github.com/repos/scilus/FiberCompression/forks","keys_url":"https://api.github.com/repos/scilus/FiberCompression/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scilus/FiberCompression/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scilus/FiberCompression/teams","hooks_url":"https://api.github.com/repos/scilus/FiberCompression/hooks","issue_events_url":"https://api.github.com/repos/scilus/FiberCompression/issues/events{/number}","events_url":"https://api.github.com/repos/scilus/FiberCompression/events","assignees_url":"https://api.github.com/repos/scilus/FiberCompression/assignees{/user}","branches_url":"https://api.github.com/repos/scilus/FiberCompression/branches{/branch}","tags_url":"https://api.github.com/repos/scilus/FiberCompression/tags","blobs_url":"https://api.github.com/repos/scilus/FiberCompression/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scilus/FiberCompression/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scilus/FiberCompression/git/refs{/sha}","trees_url":"https://api.github.com/repos/scilus/FiberCompression/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scilus/FiberCompression/statuses/{sha}","languages_url":"https://api.github.com/repos/scilus/FiberCompression/languages","stargazers_url":"https://api.github.com/repos/scilus/FiberCompression/stargazers","contributors_url":"https://api.github.com/repos/scilus/FiberCompression/contributors","subscribers_url":"https://api.github.com/repos/scilus/FiberCompression/subscribers","subscription_url":"https://api.github.com/repos/scilus/FiberCompression/subscription","commits_url":"https://api.github.com/repos/scilus/FiberCompression/commits{/sha}","git_commits_url":"https://api.github.com/repos/scilus/FiberCompression/git/commits{/sha}","comments_url":"https://api.github.com/repos/scilus/FiberCompression/comments{/number}","issue_comment_url":"https://api.github.com/repos/scilus/FiberCompression/issues/comments/{number}","contents_url":"https://api.github.com/repos/scilus/FiberCompression/contents/{+path}","compare_url":"https://api.github.com/repos/scilus/FiberCompression/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scilus/FiberCompression/merges","archive_url":"https://api.github.com/repos/scilus/FiberCompression/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scilus/FiberCompression/downloads","issues_url":"https://api.github.com/repos/scilus/FiberCompression/issues{/number}","pulls_url":"https://api.github.com/repos/scilus/FiberCompression/pulls{/number}","milestones_url":"https://api.github.com/repos/scilus/FiberCompression/milestones{/number}","notifications_url":"https://api.github.com/repos/scilus/FiberCompression/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scilus/FiberCompression/labels{/name}","releases_url":"https://api.github.com/repos/scilus/FiberCompression/releases{/id}","created_at":"2014-04-29T18:09:30Z","updated_at":"2014-10-06T13:29:42Z","pushed_at":"2014-05-21T01:40:12Z","git_url":"git://github.com/scilus/FiberCompression.git","ssh_url":"git@github.com:scilus/FiberCompression.git","clone_url":"https://github.com/scilus/FiberCompression.git","svn_url":"https://github.com/scilus/FiberCompression","homepage":"","size":1232,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scilus/FiberCompression/pulls/5"},"html":{"href":"https://github.com/scilus/FiberCompression/pull/5"},"issue":{"href":"https://api.github.com/repos/scilus/FiberCompression/issues/5"},"comments":{"href":"https://api.github.com/repos/scilus/FiberCompression/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/scilus/FiberCompression/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/scilus/FiberCompression/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scilus/FiberCompression/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/scilus/FiberCompression/statuses/25a1a0a511b6d9323e5dd91aabdab0139bd79221"}}}}