GitHub PullRequestEvent at 2014-01-03 18:08:45
Repository: puppet-nginx
Actor: 3flex
Payload: {"action":"opened","number":223,"pull_request":{"url":"https://api.github.com/repos/jfryman/puppet-nginx/pulls/223","id":11213950,"html_url":"https://github.com/jfryman/puppet-nginx/pull/223","diff_url":"https://github.com/jfryman/puppet-nginx/pull/223.diff","patch_url":"https://github.com/jfryman/puppet-nginx/pull/223.patch","issue_url":"https://github.com/jfryman/puppet-nginx/pull/223","number":223,"state":"open","title":"Add validation for $priority","user":{"login":"3flex","id":170028,"avatar_url":"https://identicons.github.com/532c280ce34f0bd7642a5bccfb53112a.png","gravatar_id":null,"url":"https://api.github.com/users/3flex","html_url":"https://github.com/3flex","followers_url":"https://api.github.com/users/3flex/followers","following_url":"https://api.github.com/users/3flex/following{/other_user}","gists_url":"https://api.github.com/users/3flex/gists{/gist_id}","starred_url":"https://api.github.com/users/3flex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3flex/subscriptions","organizations_url":"https://api.github.com/users/3flex/orgs","repos_url":"https://api.github.com/users/3flex/repos","events_url":"https://api.github.com/users/3flex/events{/privacy}","received_events_url":"https://api.github.com/users/3flex/received_events","type":"User","site_admin":false},"body":"Valid range changed to 401-599:\r\n\r\nvhost SSL header has priority 700. If $priority is set to 400 (which resolves to 400+300=700 for SSL locations), then it would conflict with the priority of the header. It must be 401 or higher to avoid this.\r\n\r\nTop end of range is limited to 599 to reflect documentation however it could be increased to 698 and still provide expected behavior.\r\n\r\nCurrent default priorities:\r\n* 001 HTTP header\r\n* 500 nginx::resource::location default (included when `$ssl_only != true`, which is default)\r\n* 699 HTTP footer\r\n* 700 SSL header\r\n* 800 nginx::resource::location default (included when `$ssl == true`). Is `$priority + 300`.\r\n* 999 SSL footer\r\n\r\nNon-conflicting HTTP location fragment priorities: 002-698. `$priority` valid range is the same.\r\nNon-conflicting SSL location fragment priorities:  701-998. Means `$priority` valid range is 401-698.\r\n\r\nDocumentation says valid range is 400-499 and 501-599. This is correct for HTTP is almost correct for SSL range (should be 401-499).","created_at":"2014-01-03T18:08:44Z","updated_at":"2014-01-03T18:08:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://github.com/jfryman/puppet-nginx/pull/223/commits","review_comments_url":"https://github.com/jfryman/puppet-nginx/pull/223/comments","review_comment_url":"/repos/jfryman/puppet-nginx/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jfryman/puppet-nginx/issues/223/comments","statuses_url":"https://api.github.com/repos/jfryman/puppet-nginx/statuses/d22402c4048a6b5b67995fe5610e945dc2afc282","head":{"label":"3flex:validate-location-priority","ref":"validate-location-priority","sha":"d22402c4048a6b5b67995fe5610e945dc2afc282","user":{"login":"3flex","id":170028,"avatar_url":"https://identicons.github.com/532c280ce34f0bd7642a5bccfb53112a.png","gravatar_id":null,"url":"https://api.github.com/users/3flex","html_url":"https://github.com/3flex","followers_url":"https://api.github.com/users/3flex/followers","following_url":"https://api.github.com/users/3flex/following{/other_user}","gists_url":"https://api.github.com/users/3flex/gists{/gist_id}","starred_url":"https://api.github.com/users/3flex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3flex/subscriptions","organizations_url":"https://api.github.com/users/3flex/orgs","repos_url":"https://api.github.com/users/3flex/repos","events_url":"https://api.github.com/users/3flex/events{/privacy}","received_events_url":"https://api.github.com/users/3flex/received_events","type":"User","site_admin":false},"repo":{"id":15587430,"name":"puppet-nginx","full_name":"3flex/puppet-nginx","owner":{"login":"3flex","id":170028,"avatar_url":"https://identicons.github.com/532c280ce34f0bd7642a5bccfb53112a.png","gravatar_id":null,"url":"https://api.github.com/users/3flex","html_url":"https://github.com/3flex","followers_url":"https://api.github.com/users/3flex/followers","following_url":"https://api.github.com/users/3flex/following{/other_user}","gists_url":"https://api.github.com/users/3flex/gists{/gist_id}","starred_url":"https://api.github.com/users/3flex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3flex/subscriptions","organizations_url":"https://api.github.com/users/3flex/orgs","repos_url":"https://api.github.com/users/3flex/repos","events_url":"https://api.github.com/users/3flex/events{/privacy}","received_events_url":"https://api.github.com/users/3flex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/3flex/puppet-nginx","description":"Puppet Module to manage NGINX on various UNIXes","fork":true,"url":"https://api.github.com/repos/3flex/puppet-nginx","forks_url":"https://api.github.com/repos/3flex/puppet-nginx/forks","keys_url":"https://api.github.com/repos/3flex/puppet-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3flex/puppet-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3flex/puppet-nginx/teams","hooks_url":"https://api.github.com/repos/3flex/puppet-nginx/hooks","issue_events_url":"https://api.github.com/repos/3flex/puppet-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/3flex/puppet-nginx/events","assignees_url":"https://api.github.com/repos/3flex/puppet-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/3flex/puppet-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/3flex/puppet-nginx/tags","blobs_url":"https://api.github.com/repos/3flex/puppet-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3flex/puppet-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3flex/puppet-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/3flex/puppet-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3flex/puppet-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/3flex/puppet-nginx/languages","stargazers_url":"https://api.github.com/repos/3flex/puppet-nginx/stargazers","contributors_url":"https://api.github.com/repos/3flex/puppet-nginx/contributors","subscribers_url":"https://api.github.com/repos/3flex/puppet-nginx/subscribers","subscription_url":"https://api.github.com/repos/3flex/puppet-nginx/subscription","commits_url":"https://api.github.com/repos/3flex/puppet-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/3flex/puppet-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/3flex/puppet-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/3flex/puppet-nginx/issues/comments/{number}","contents_url":"https://api.github.com/repos/3flex/puppet-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/3flex/puppet-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3flex/puppet-nginx/merges","archive_url":"https://api.github.com/repos/3flex/puppet-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3flex/puppet-nginx/downloads","issues_url":"https://api.github.com/repos/3flex/puppet-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/3flex/puppet-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/3flex/puppet-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/3flex/puppet-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3flex/puppet-nginx/labels{/name}","releases_url":"https://api.github.com/repos/3flex/puppet-nginx/releases{/id}","created_at":"2014-01-02T15:52:41Z","updated_at":"2014-01-03T18:08:44Z","pushed_at":"2014-01-03T18:04:23Z","git_url":"git://github.com/3flex/puppet-nginx.git","ssh_url":"git@github.com:3flex/puppet-nginx.git","clone_url":"https://github.com/3flex/puppet-nginx.git","svn_url":"https://github.com/3flex/puppet-nginx","homepage":"","size":1631,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"jfryman:master","ref":"master","sha":"7d5cb888afc1290ce71b7e631fa464ba0f66e9cc","user":{"login":"jfryman","id":20028,"avatar_url":"https://gravatar.com/avatar/d4be9b0fd15ec79f4448ae4efe024086?d=https%3A%2F%2Fidenticons.github.com%2Fc4d2cec38fa1da8b5d37758873c3678d.png&r=x","gravatar_id":"d4be9b0fd15ec79f4448ae4efe024086","url":"https://api.github.com/users/jfryman","html_url":"https://github.com/jfryman","followers_url":"https://api.github.com/users/jfryman/followers","following_url":"https://api.github.com/users/jfryman/following{/other_user}","gists_url":"https://api.github.com/users/jfryman/gists{/gist_id}","starred_url":"https://api.github.com/users/jfryman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfryman/subscriptions","organizations_url":"https://api.github.com/users/jfryman/orgs","repos_url":"https://api.github.com/users/jfryman/repos","events_url":"https://api.github.com/users/jfryman/events{/privacy}","received_events_url":"https://api.github.com/users/jfryman/received_events","type":"User","site_admin":true},"repo":{"id":1791219,"name":"puppet-nginx","full_name":"jfryman/puppet-nginx","owner":{"login":"jfryman","id":20028,"avatar_url":"https://gravatar.com/avatar/d4be9b0fd15ec79f4448ae4efe024086?d=https%3A%2F%2Fidenticons.github.com%2Fc4d2cec38fa1da8b5d37758873c3678d.png&r=x","gravatar_id":"d4be9b0fd15ec79f4448ae4efe024086","url":"https://api.github.com/users/jfryman","html_url":"https://github.com/jfryman","followers_url":"https://api.github.com/users/jfryman/followers","following_url":"https://api.github.com/users/jfryman/following{/other_user}","gists_url":"https://api.github.com/users/jfryman/gists{/gist_id}","starred_url":"https://api.github.com/users/jfryman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfryman/subscriptions","organizations_url":"https://api.github.com/users/jfryman/orgs","repos_url":"https://api.github.com/users/jfryman/repos","events_url":"https://api.github.com/users/jfryman/events{/privacy}","received_events_url":"https://api.github.com/users/jfryman/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/jfryman/puppet-nginx","description":"Puppet Module to manage NGINX on various UNIXes","fork":false,"url":"https://api.github.com/repos/jfryman/puppet-nginx","forks_url":"https://api.github.com/repos/jfryman/puppet-nginx/forks","keys_url":"https://api.github.com/repos/jfryman/puppet-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jfryman/puppet-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jfryman/puppet-nginx/teams","hooks_url":"https://api.github.com/repos/jfryman/puppet-nginx/hooks","issue_events_url":"https://api.github.com/repos/jfryman/puppet-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/jfryman/puppet-nginx/events","assignees_url":"https://api.github.com/repos/jfryman/puppet-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/jfryman/puppet-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/jfryman/puppet-nginx/tags","blobs_url":"https://api.github.com/repos/jfryman/puppet-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jfryman/puppet-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jfryman/puppet-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jfryman/puppet-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jfryman/puppet-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/jfryman/puppet-nginx/languages","stargazers_url":"https://api.github.com/repos/jfryman/puppet-nginx/stargazers","contributors_url":"https://api.github.com/repos/jfryman/puppet-nginx/contributors","subscribers_url":"https://api.github.com/repos/jfryman/puppet-nginx/subscribers","subscription_url":"https://api.github.com/repos/jfryman/puppet-nginx/subscription","commits_url":"https://api.github.com/repos/jfryman/puppet-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jfryman/puppet-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jfryman/puppet-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jfryman/puppet-nginx/issues/comments/{number}","contents_url":"https://api.github.com/repos/jfryman/puppet-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/jfryman/puppet-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jfryman/puppet-nginx/merges","archive_url":"https://api.github.com/repos/jfryman/puppet-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jfryman/puppet-nginx/downloads","issues_url":"https://api.github.com/repos/jfryman/puppet-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/jfryman/puppet-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/jfryman/puppet-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/jfryman/puppet-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jfryman/puppet-nginx/labels{/name}","releases_url":"https://api.github.com/repos/jfryman/puppet-nginx/releases{/id}","created_at":"2011-05-24T01:53:48Z","updated_at":"2014-01-03T11:33:45Z","pushed_at":"2014-01-02T23:31:53Z","git_url":"git://github.com/jfryman/puppet-nginx.git","ssh_url":"git@github.com:jfryman/puppet-nginx.git","clone_url":"https://github.com/jfryman/puppet-nginx.git","svn_url":"https://github.com/jfryman/puppet-nginx","homepage":"","size":1631,"stargazers_count":165,"watchers_count":165,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":329,"mirror_url":null,"open_issues_count":42,"forks":329,"open_issues":42,"watchers":165,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jfryman/puppet-nginx/pulls/223"},"html":{"href":"https://github.com/jfryman/puppet-nginx/pull/223"},"issue":{"href":"https://api.github.com/repos/jfryman/puppet-nginx/issues/223"},"comments":{"href":"https://api.github.com/repos/jfryman/puppet-nginx/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/jfryman/puppet-nginx/pulls/223/comments"},"statuses":{"href":"https://api.github.com/repos/jfryman/puppet-nginx/statuses/d22402c4048a6b5b67995fe5610e945dc2afc282"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":1,"changed_files":1}}