GitHub PullRequestReviewCommentEvent at 2014-08-01 15:40:32
Repository: makedrive
Actor: sedge
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/makedrive/pulls/comments/15702581","id":15702581,"diff_hunk":"@@ -95,16 +99,17 @@ SyncMessage.INFRMT = \"INVALID FORMAT\";\n SyncMessage.INCONT = \"INVALID CONTENT\";\n \n function isValidName(name) {\n-  return name === SyncMessage.SRCLIST ||\n-         name === SyncMessage.CHKSUM  ||\n-         name === SyncMessage.DIFFS   ||\n-         name === SyncMessage.LOCKED  ||\n-         name === SyncMessage.PATCH   ||\n-         name === SyncMessage.SYNC    ||\n-         name === SyncMessage.RESET   ||\n-         name === SyncMessage.AUTHZ   ||\n-         name === SyncMessage.IMPL    ||\n-         name === SyncMessage.INFRMT  ||\n+  return name === SyncMessage.SRCLIST      ||\n+         name === SyncMessage.CHKSUM       ||\n+         name === SyncMessage.DIFFS        ||\n+         name === SyncMessage.LOCKED       ||\n+         name === SyncMessage.PATCH        ||\n+         name === SyncMessage.VERIFICATION ||","path":"lib/syncmessage.js","position":37,"original_position":37,"commit_id":"94892dbdbeaf423d685066e5539c5f1216eda4fe","original_commit_id":"9855a8c4ebabb581af0d8c008a619edfeeeb4ca5","user":{"login":"sedge","id":1616860,"avatar_url":"https://avatars.githubusercontent.com/u/1616860?v=1","gravatar_id":"92e900674f4c9e7fad7e60809f32c83b","url":"https://api.github.com/users/sedge","html_url":"https://github.com/sedge","followers_url":"https://api.github.com/users/sedge/followers","following_url":"https://api.github.com/users/sedge/following{/other_user}","gists_url":"https://api.github.com/users/sedge/gists{/gist_id}","starred_url":"https://api.github.com/users/sedge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sedge/subscriptions","organizations_url":"https://api.github.com/users/sedge/orgs","repos_url":"https://api.github.com/users/sedge/repos","events_url":"https://api.github.com/users/sedge/events{/privacy}","received_events_url":"https://api.github.com/users/sedge/received_events","type":"User","site_admin":false},"body":"Why here?","created_at":"2014-08-01T15:40:32Z","updated_at":"2014-08-01T15:40:32Z","html_url":"https://github.com/mozilla/makedrive/pull/178#discussion_r15702581","pull_request_url":"https://api.github.com/repos/mozilla/makedrive/pulls/178","_links":{"self":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/comments/15702581"},"html":{"href":"https://github.com/mozilla/makedrive/pull/178#discussion_r15702581"},"pull_request":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/178"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/makedrive/pulls/178","id":19214535,"html_url":"https://github.com/mozilla/makedrive/pull/178","diff_url":"https://github.com/mozilla/makedrive/pull/178.diff","patch_url":"https://github.com/mozilla/makedrive/pull/178.patch","issue_url":"https://api.github.com/repos/mozilla/makedrive/issues/178","number":178,"state":"open","title":"Fixed Issue #32 - Verify that the client has patched","user":{"login":"gideonthomas","id":5816130,"avatar_url":"https://avatars.githubusercontent.com/u/5816130?v=1","gravatar_id":"b258eac8f9bbbd1cc58948ed37ef4f55","url":"https://api.github.com/users/gideonthomas","html_url":"https://github.com/gideonthomas","followers_url":"https://api.github.com/users/gideonthomas/followers","following_url":"https://api.github.com/users/gideonthomas/following{/other_user}","gists_url":"https://api.github.com/users/gideonthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/gideonthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gideonthomas/subscriptions","organizations_url":"https://api.github.com/users/gideonthomas/orgs","repos_url":"https://api.github.com/users/gideonthomas/repos","events_url":"https://api.github.com/users/gideonthomas/events{/privacy}","received_events_url":"https://api.github.com/users/gideonthomas/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-01T14:56:13Z","updated_at":"2014-08-01T15:40:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cb6bf071592386661129f05d3730151d4b31d55","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/makedrive/pulls/178/commits","review_comments_url":"https://api.github.com/repos/mozilla/makedrive/pulls/178/comments","review_comment_url":"https://api.github.com/repos/mozilla/makedrive/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/makedrive/issues/178/comments","statuses_url":"https://api.github.com/repos/mozilla/makedrive/statuses/94892dbdbeaf423d685066e5539c5f1216eda4fe","head":{"label":"gideonthomas:issue32","ref":"issue32","sha":"94892dbdbeaf423d685066e5539c5f1216eda4fe","user":{"login":"gideonthomas","id":5816130,"avatar_url":"https://avatars.githubusercontent.com/u/5816130?v=1","gravatar_id":"b258eac8f9bbbd1cc58948ed37ef4f55","url":"https://api.github.com/users/gideonthomas","html_url":"https://github.com/gideonthomas","followers_url":"https://api.github.com/users/gideonthomas/followers","following_url":"https://api.github.com/users/gideonthomas/following{/other_user}","gists_url":"https://api.github.com/users/gideonthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/gideonthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gideonthomas/subscriptions","organizations_url":"https://api.github.com/users/gideonthomas/orgs","repos_url":"https://api.github.com/users/gideonthomas/repos","events_url":"https://api.github.com/users/gideonthomas/events{/privacy}","received_events_url":"https://api.github.com/users/gideonthomas/received_events","type":"User","site_admin":false},"repo":{"id":21875658,"name":"makedrive","full_name":"gideonthomas/makedrive","owner":{"login":"gideonthomas","id":5816130,"avatar_url":"https://avatars.githubusercontent.com/u/5816130?v=1","gravatar_id":"b258eac8f9bbbd1cc58948ed37ef4f55","url":"https://api.github.com/users/gideonthomas","html_url":"https://github.com/gideonthomas","followers_url":"https://api.github.com/users/gideonthomas/followers","following_url":"https://api.github.com/users/gideonthomas/following{/other_user}","gists_url":"https://api.github.com/users/gideonthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/gideonthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gideonthomas/subscriptions","organizations_url":"https://api.github.com/users/gideonthomas/orgs","repos_url":"https://api.github.com/users/gideonthomas/repos","events_url":"https://api.github.com/users/gideonthomas/events{/privacy}","received_events_url":"https://api.github.com/users/gideonthomas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gideonthomas/makedrive","description":"Webmaker Filesystem","fork":true,"url":"https://api.github.com/repos/gideonthomas/makedrive","forks_url":"https://api.github.com/repos/gideonthomas/makedrive/forks","keys_url":"https://api.github.com/repos/gideonthomas/makedrive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gideonthomas/makedrive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gideonthomas/makedrive/teams","hooks_url":"https://api.github.com/repos/gideonthomas/makedrive/hooks","issue_events_url":"https://api.github.com/repos/gideonthomas/makedrive/issues/events{/number}","events_url":"https://api.github.com/repos/gideonthomas/makedrive/events","assignees_url":"https://api.github.com/repos/gideonthomas/makedrive/assignees{/user}","branches_url":"https://api.github.com/repos/gideonthomas/makedrive/branches{/branch}","tags_url":"https://api.github.com/repos/gideonthomas/makedrive/tags","blobs_url":"https://api.github.com/repos/gideonthomas/makedrive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gideonthomas/makedrive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gideonthomas/makedrive/git/refs{/sha}","trees_url":"https://api.github.com/repos/gideonthomas/makedrive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gideonthomas/makedrive/statuses/{sha}","languages_url":"https://api.github.com/repos/gideonthomas/makedrive/languages","stargazers_url":"https://api.github.com/repos/gideonthomas/makedrive/stargazers","contributors_url":"https://api.github.com/repos/gideonthomas/makedrive/contributors","subscribers_url":"https://api.github.com/repos/gideonthomas/makedrive/subscribers","subscription_url":"https://api.github.com/repos/gideonthomas/makedrive/subscription","commits_url":"https://api.github.com/repos/gideonthomas/makedrive/commits{/sha}","git_commits_url":"https://api.github.com/repos/gideonthomas/makedrive/git/commits{/sha}","comments_url":"https://api.github.com/repos/gideonthomas/makedrive/comments{/number}","issue_comment_url":"https://api.github.com/repos/gideonthomas/makedrive/issues/comments/{number}","contents_url":"https://api.github.com/repos/gideonthomas/makedrive/contents/{+path}","compare_url":"https://api.github.com/repos/gideonthomas/makedrive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gideonthomas/makedrive/merges","archive_url":"https://api.github.com/repos/gideonthomas/makedrive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gideonthomas/makedrive/downloads","issues_url":"https://api.github.com/repos/gideonthomas/makedrive/issues{/number}","pulls_url":"https://api.github.com/repos/gideonthomas/makedrive/pulls{/number}","milestones_url":"https://api.github.com/repos/gideonthomas/makedrive/milestones{/number}","notifications_url":"https://api.github.com/repos/gideonthomas/makedrive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gideonthomas/makedrive/labels{/name}","releases_url":"https://api.github.com/repos/gideonthomas/makedrive/releases{/id}","created_at":"2014-07-15T20:56:54Z","updated_at":"2014-07-11T23:42:27Z","pushed_at":"2014-08-01T15:16:01Z","git_url":"git://github.com/gideonthomas/makedrive.git","ssh_url":"git@github.com:gideonthomas/makedrive.git","clone_url":"https://github.com/gideonthomas/makedrive.git","svn_url":"https://github.com/gideonthomas/makedrive","homepage":null,"size":3272,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"bfd26dd21d3251b300b9d2f82e9d42f2e5be45c9","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=1","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":18801832,"name":"makedrive","full_name":"mozilla/makedrive","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=1","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/makedrive","description":"Webmaker Filesystem","fork":false,"url":"https://api.github.com/repos/mozilla/makedrive","forks_url":"https://api.github.com/repos/mozilla/makedrive/forks","keys_url":"https://api.github.com/repos/mozilla/makedrive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/makedrive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/makedrive/teams","hooks_url":"https://api.github.com/repos/mozilla/makedrive/hooks","issue_events_url":"https://api.github.com/repos/mozilla/makedrive/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/makedrive/events","assignees_url":"https://api.github.com/repos/mozilla/makedrive/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/makedrive/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/makedrive/tags","blobs_url":"https://api.github.com/repos/mozilla/makedrive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/makedrive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/makedrive/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/makedrive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/makedrive/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/makedrive/languages","stargazers_url":"https://api.github.com/repos/mozilla/makedrive/stargazers","contributors_url":"https://api.github.com/repos/mozilla/makedrive/contributors","subscribers_url":"https://api.github.com/repos/mozilla/makedrive/subscribers","subscription_url":"https://api.github.com/repos/mozilla/makedrive/subscription","commits_url":"https://api.github.com/repos/mozilla/makedrive/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/makedrive/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/makedrive/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/makedrive/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/makedrive/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/makedrive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/makedrive/merges","archive_url":"https://api.github.com/repos/mozilla/makedrive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/makedrive/downloads","issues_url":"https://api.github.com/repos/mozilla/makedrive/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/makedrive/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/makedrive/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/makedrive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/makedrive/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/makedrive/releases{/id}","created_at":"2014-04-15T13:53:43Z","updated_at":"2014-07-30T12:25:22Z","pushed_at":"2014-07-31T20:05:36Z","git_url":"git://github.com/mozilla/makedrive.git","ssh_url":"git@github.com:mozilla/makedrive.git","clone_url":"https://github.com/mozilla/makedrive.git","svn_url":"https://github.com/mozilla/makedrive","homepage":null,"size":5750,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":30,"forks":8,"open_issues":30,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/178"},"html":{"href":"https://github.com/mozilla/makedrive/pull/178"},"issue":{"href":"https://api.github.com/repos/mozilla/makedrive/issues/178"},"comments":{"href":"https://api.github.com/repos/mozilla/makedrive/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/makedrive/statuses/94892dbdbeaf423d685066e5539c5f1216eda4fe"}}}}