GitHub PullRequestReviewCommentEvent at 2014-12-11 20:53:32
Repository: swarm
Actor: aluzzardi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/docker/swarm/pulls/comments/21708597","id":21708597,"diff_hunk":"@@ -0,0 +1,51 @@\n+package discovery\n+\n+import (\n+\t\"errors\"\n+\t\"fmt\"\n+\t\"net/url\"\n+\t\"time\"\n+\n+\tlog \"github.com/Sirupsen/logrus\"\n+)\n+\n+type InitFunc func(url string) (DiscoveryService, error)\n+\n+type DiscoveryService interface {\n+\tFetch() ([]string, error)\n+\tWatch(int) <-chan time.Time","path":"discovery/discovery.go","position":16,"original_position":16,"commit_id":"c3fc9c7d4b3343c90e368a22e6e8d0cb385bda98","original_commit_id":"c3fc9c7d4b3343c90e368a22e6e8d0cb385bda98","user":{"login":"aluzzardi","id":179503,"avatar_url":"https://avatars.githubusercontent.com/u/179503?v=3","gravatar_id":"","url":"https://api.github.com/users/aluzzardi","html_url":"https://github.com/aluzzardi","followers_url":"https://api.github.com/users/aluzzardi/followers","following_url":"https://api.github.com/users/aluzzardi/following{/other_user}","gists_url":"https://api.github.com/users/aluzzardi/gists{/gist_id}","starred_url":"https://api.github.com/users/aluzzardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aluzzardi/subscriptions","organizations_url":"https://api.github.com/users/aluzzardi/orgs","repos_url":"https://api.github.com/users/aluzzardi/repos","events_url":"https://api.github.com/users/aluzzardi/events{/privacy}","received_events_url":"https://api.github.com/users/aluzzardi/received_events","type":"User","site_admin":false},"body":"Why is this a time.Time channel rather than bool or struct{}? Is the value being used?","created_at":"2014-12-11T20:53:32Z","updated_at":"2014-12-11T20:53:32Z","html_url":"https://github.com/docker/swarm/pull/164#discussion_r21708597","pull_request_url":"https://api.github.com/repos/docker/swarm/pulls/164","_links":{"self":{"href":"https://api.github.com/repos/docker/swarm/pulls/comments/21708597"},"html":{"href":"https://github.com/docker/swarm/pull/164#discussion_r21708597"},"pull_request":{"href":"https://api.github.com/repos/docker/swarm/pulls/164"}}},"pull_request":{"url":"https://api.github.com/repos/docker/swarm/pulls/164","id":25868791,"html_url":"https://github.com/docker/swarm/pull/164","diff_url":"https://github.com/docker/swarm/pull/164.diff","patch_url":"https://github.com/docker/swarm/pull/164.patch","issue_url":"https://api.github.com/repos/docker/swarm/issues/164","number":164,"state":"open","locked":false,"title":"Discovery Service backends token/etcd/file","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"body":"This is an initial version, feel free to comment.\r\n\r\nReplace the `--token` flag by a more generic `--discovery` flag supporting multiple backends. See https://github.com/vieux/swarm/blob/discovery/README.md for more info.\r\n\r\ntoken\r\n-------\r\nBasic usage: `--discovery token://XXXXXXXXXX` (replace `--token XXXXXXXXXX`) works for both `join` and `manage`\r\nyou can also use your own service implementing our discovery api: `--discovery discovery://example.com:5000/XXXXXXXXXX`\r\n\r\netcd\r\n-----\r\nIf you already have your own etcd, you can use it with `--discovery etcd://example.com:5001/XXXXXXXXXX`\r\nin both `join` and `manage`\r\n\r\nfile\r\n----\r\nYou can also use a static file describing your cluster like this \r\n```\r\n192.168.0.1:2575\r\n192.168.0.2:2575\r\n192.168.0.3:2575\r\n```\r\n\r\nThen use `--discovery file://path/to/file`.\r\nIn this static setup, join makes no sense, so you only have to use this in `manage`\r\n\r\nNote: `swarm create` make sense only when you are using `token://`\r\n\r\nclose #145","created_at":"2014-12-11T00:50:28Z","updated_at":"2014-12-11T20:53:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15c7ab19b96f85413d0b4e262c9d728ad95c635d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/swarm/pulls/164/commits","review_comments_url":"https://api.github.com/repos/docker/swarm/pulls/164/comments","review_comment_url":"https://api.github.com/repos/docker/swarm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/swarm/issues/164/comments","statuses_url":"https://api.github.com/repos/docker/swarm/statuses/c3fc9c7d4b3343c90e368a22e6e8d0cb385bda98","head":{"label":"vieux:discovery","ref":"discovery","sha":"c3fc9c7d4b3343c90e368a22e6e8d0cb385bda98","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"repo":{"id":27796788,"name":"swarm","full_name":"vieux/swarm","owner":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vieux/swarm","description":"Swarm: a Docker-native clustering system","fork":true,"url":"https://api.github.com/repos/vieux/swarm","forks_url":"https://api.github.com/repos/vieux/swarm/forks","keys_url":"https://api.github.com/repos/vieux/swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vieux/swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vieux/swarm/teams","hooks_url":"https://api.github.com/repos/vieux/swarm/hooks","issue_events_url":"https://api.github.com/repos/vieux/swarm/issues/events{/number}","events_url":"https://api.github.com/repos/vieux/swarm/events","assignees_url":"https://api.github.com/repos/vieux/swarm/assignees{/user}","branches_url":"https://api.github.com/repos/vieux/swarm/branches{/branch}","tags_url":"https://api.github.com/repos/vieux/swarm/tags","blobs_url":"https://api.github.com/repos/vieux/swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vieux/swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vieux/swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/vieux/swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vieux/swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/vieux/swarm/languages","stargazers_url":"https://api.github.com/repos/vieux/swarm/stargazers","contributors_url":"https://api.github.com/repos/vieux/swarm/contributors","subscribers_url":"https://api.github.com/repos/vieux/swarm/subscribers","subscription_url":"https://api.github.com/repos/vieux/swarm/subscription","commits_url":"https://api.github.com/repos/vieux/swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/vieux/swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/vieux/swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/vieux/swarm/issues/comments/{number}","contents_url":"https://api.github.com/repos/vieux/swarm/contents/{+path}","compare_url":"https://api.github.com/repos/vieux/swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vieux/swarm/merges","archive_url":"https://api.github.com/repos/vieux/swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vieux/swarm/downloads","issues_url":"https://api.github.com/repos/vieux/swarm/issues{/number}","pulls_url":"https://api.github.com/repos/vieux/swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/vieux/swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/vieux/swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vieux/swarm/labels{/name}","releases_url":"https://api.github.com/repos/vieux/swarm/releases{/id}","created_at":"2014-12-10T01:40:25Z","updated_at":"2014-12-10T01:40:26Z","pushed_at":"2014-12-11T01:39:25Z","git_url":"git://github.com/vieux/swarm.git","ssh_url":"git@github.com:vieux/swarm.git","clone_url":"https://github.com/vieux/swarm.git","svn_url":"https://github.com/vieux/swarm","homepage":"","size":4542,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"495080fc802404cb8828e853d7b01573fccf4a99","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":19360616,"name":"swarm","full_name":"docker/swarm","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/swarm","description":"Swarm: a Docker-native clustering system","fork":false,"url":"https://api.github.com/repos/docker/swarm","forks_url":"https://api.github.com/repos/docker/swarm/forks","keys_url":"https://api.github.com/repos/docker/swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/swarm/teams","hooks_url":"https://api.github.com/repos/docker/swarm/hooks","issue_events_url":"https://api.github.com/repos/docker/swarm/issues/events{/number}","events_url":"https://api.github.com/repos/docker/swarm/events","assignees_url":"https://api.github.com/repos/docker/swarm/assignees{/user}","branches_url":"https://api.github.com/repos/docker/swarm/branches{/branch}","tags_url":"https://api.github.com/repos/docker/swarm/tags","blobs_url":"https://api.github.com/repos/docker/swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/swarm/languages","stargazers_url":"https://api.github.com/repos/docker/swarm/stargazers","contributors_url":"https://api.github.com/repos/docker/swarm/contributors","subscribers_url":"https://api.github.com/repos/docker/swarm/subscribers","subscription_url":"https://api.github.com/repos/docker/swarm/subscription","commits_url":"https://api.github.com/repos/docker/swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/swarm/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/swarm/contents/{+path}","compare_url":"https://api.github.com/repos/docker/swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/swarm/merges","archive_url":"https://api.github.com/repos/docker/swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/swarm/downloads","issues_url":"https://api.github.com/repos/docker/swarm/issues{/number}","pulls_url":"https://api.github.com/repos/docker/swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/swarm/labels{/name}","releases_url":"https://api.github.com/repos/docker/swarm/releases{/id}","created_at":"2014-05-01T23:15:17Z","updated_at":"2014-12-11T18:30:44Z","pushed_at":"2014-12-11T01:13:48Z","git_url":"git://github.com/docker/swarm.git","ssh_url":"git@github.com:docker/swarm.git","clone_url":"https://github.com/docker/swarm.git","svn_url":"https://github.com/docker/swarm","homepage":"","size":4542,"stargazers_count":1709,"watchers_count":1709,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":7,"forks":127,"open_issues":7,"watchers":1709,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/swarm/pulls/164"},"html":{"href":"https://github.com/docker/swarm/pull/164"},"issue":{"href":"https://api.github.com/repos/docker/swarm/issues/164"},"comments":{"href":"https://api.github.com/repos/docker/swarm/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/swarm/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/swarm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/swarm/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/docker/swarm/statuses/c3fc9c7d4b3343c90e368a22e6e8d0cb385bda98"}}}}