GitHub PullRequestReviewCommentEvent at 2014-11-19 16:27:51
Repository: meritop
Actor: xiang90
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/go-distributed/meritop/pulls/comments/20587098","id":20587098,"diff_hunk":"@@ -155,6 +207,36 @@ func (f *framework) watchAll(who string, taskIDs []uint64) []chan bool {\n }\n \n func (f *framework) DataRequest(toID uint64, req string) {\n+\t// getAddressFromTaskID\n+\taddr, ok := f.addressMap[toID]\n+\tif !ok {\n+\t\tlog.Printf(\"ID = %d not found\", toID)\n+\t\treturn\n+\t}\n+\t// send request\n+\t// throw the future into the event loop waiting for responses\n+\turl := fmt.Sprintf(\"http://%s%s\", addr,\n+\t\t// it passes self taskID in url to tell the other side\n+\t\tMakeDataRequestPath(f.taskID, req))\n+\tgo func(url string) {","path":"framework.go","position":null,"original_position":104,"commit_id":"4d203e7bb9205a2e5bbb91bd2179279e22ed42a3","original_commit_id":"2fe81cd7196434fe499454332b4a4c2ad7816942","user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"body":"@xiaoyunwu @fengjingchao \r\nIt is not about `blocking` or `unblocking`. The user can always call this function in a routine. I am a little bit worrying about our error handling mechanism here.\r\n\r\nSo the framework will take care of all the retry logic for the application user in the future? And the framework simply panics if it cannot handle the error?","created_at":"2014-11-19T16:27:51Z","updated_at":"2014-11-19T16:27:51Z","html_url":"https://github.com/go-distributed/meritop/pull/36#discussion_r20587098","pull_request_url":"https://api.github.com/repos/go-distributed/meritop/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/go-distributed/meritop/pulls/comments/20587098"},"html":{"href":"https://github.com/go-distributed/meritop/pull/36#discussion_r20587098"},"pull_request":{"href":"https://api.github.com/repos/go-distributed/meritop/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/go-distributed/meritop/pulls/36","id":24653226,"html_url":"https://github.com/go-distributed/meritop/pull/36","diff_url":"https://github.com/go-distributed/meritop/pull/36.diff","patch_url":"https://github.com/go-distributed/meritop/pull/36.patch","issue_url":"https://api.github.com/repos/go-distributed/meritop/issues/36","number":36,"state":"open","locked":false,"title":"Framework: DataRequest implementation","user":{"login":"fengjingchao","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/fengjingchao","html_url":"https://github.com/fengjingchao","followers_url":"https://api.github.com/users/fengjingchao/followers","following_url":"https://api.github.com/users/fengjingchao/following{/other_user}","gists_url":"https://api.github.com/users/fengjingchao/gists{/gist_id}","starred_url":"https://api.github.com/users/fengjingchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengjingchao/subscriptions","organizations_url":"https://api.github.com/users/fengjingchao/orgs","repos_url":"https://api.github.com/users/fengjingchao/repos","events_url":"https://api.github.com/users/fengjingchao/events{/privacy}","received_events_url":"https://api.github.com/users/fengjingchao/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-18T23:16:34Z","updated_at":"2014-11-19T16:27:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"790c3500565f389fa2db1d2291156bc52670d5fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/go-distributed/meritop/pulls/36/commits","review_comments_url":"https://api.github.com/repos/go-distributed/meritop/pulls/36/comments","review_comment_url":"https://api.github.com/repos/go-distributed/meritop/pulls/comments/{number}","comments_url":"https://api.github.com/repos/go-distributed/meritop/issues/36/comments","statuses_url":"https://api.github.com/repos/go-distributed/meritop/statuses/4d203e7bb9205a2e5bbb91bd2179279e22ed42a3","head":{"label":"fengjingchao:master","ref":"master","sha":"4d203e7bb9205a2e5bbb91bd2179279e22ed42a3","user":{"login":"fengjingchao","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/fengjingchao","html_url":"https://github.com/fengjingchao","followers_url":"https://api.github.com/users/fengjingchao/followers","following_url":"https://api.github.com/users/fengjingchao/following{/other_user}","gists_url":"https://api.github.com/users/fengjingchao/gists{/gist_id}","starred_url":"https://api.github.com/users/fengjingchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengjingchao/subscriptions","organizations_url":"https://api.github.com/users/fengjingchao/orgs","repos_url":"https://api.github.com/users/fengjingchao/repos","events_url":"https://api.github.com/users/fengjingchao/events{/privacy}","received_events_url":"https://api.github.com/users/fengjingchao/received_events","type":"User","site_admin":false},"repo":{"id":26405881,"name":"meritop","full_name":"fengjingchao/meritop","owner":{"login":"fengjingchao","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/fengjingchao","html_url":"https://github.com/fengjingchao","followers_url":"https://api.github.com/users/fengjingchao/followers","following_url":"https://api.github.com/users/fengjingchao/following{/other_user}","gists_url":"https://api.github.com/users/fengjingchao/gists{/gist_id}","starred_url":"https://api.github.com/users/fengjingchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengjingchao/subscriptions","organizations_url":"https://api.github.com/users/fengjingchao/orgs","repos_url":"https://api.github.com/users/fengjingchao/repos","events_url":"https://api.github.com/users/fengjingchao/events{/privacy}","received_events_url":"https://api.github.com/users/fengjingchao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fengjingchao/meritop","description":"","fork":true,"url":"https://api.github.com/repos/fengjingchao/meritop","forks_url":"https://api.github.com/repos/fengjingchao/meritop/forks","keys_url":"https://api.github.com/repos/fengjingchao/meritop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fengjingchao/meritop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fengjingchao/meritop/teams","hooks_url":"https://api.github.com/repos/fengjingchao/meritop/hooks","issue_events_url":"https://api.github.com/repos/fengjingchao/meritop/issues/events{/number}","events_url":"https://api.github.com/repos/fengjingchao/meritop/events","assignees_url":"https://api.github.com/repos/fengjingchao/meritop/assignees{/user}","branches_url":"https://api.github.com/repos/fengjingchao/meritop/branches{/branch}","tags_url":"https://api.github.com/repos/fengjingchao/meritop/tags","blobs_url":"https://api.github.com/repos/fengjingchao/meritop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fengjingchao/meritop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fengjingchao/meritop/git/refs{/sha}","trees_url":"https://api.github.com/repos/fengjingchao/meritop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fengjingchao/meritop/statuses/{sha}","languages_url":"https://api.github.com/repos/fengjingchao/meritop/languages","stargazers_url":"https://api.github.com/repos/fengjingchao/meritop/stargazers","contributors_url":"https://api.github.com/repos/fengjingchao/meritop/contributors","subscribers_url":"https://api.github.com/repos/fengjingchao/meritop/subscribers","subscription_url":"https://api.github.com/repos/fengjingchao/meritop/subscription","commits_url":"https://api.github.com/repos/fengjingchao/meritop/commits{/sha}","git_commits_url":"https://api.github.com/repos/fengjingchao/meritop/git/commits{/sha}","comments_url":"https://api.github.com/repos/fengjingchao/meritop/comments{/number}","issue_comment_url":"https://api.github.com/repos/fengjingchao/meritop/issues/comments/{number}","contents_url":"https://api.github.com/repos/fengjingchao/meritop/contents/{+path}","compare_url":"https://api.github.com/repos/fengjingchao/meritop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fengjingchao/meritop/merges","archive_url":"https://api.github.com/repos/fengjingchao/meritop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fengjingchao/meritop/downloads","issues_url":"https://api.github.com/repos/fengjingchao/meritop/issues{/number}","pulls_url":"https://api.github.com/repos/fengjingchao/meritop/pulls{/number}","milestones_url":"https://api.github.com/repos/fengjingchao/meritop/milestones{/number}","notifications_url":"https://api.github.com/repos/fengjingchao/meritop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fengjingchao/meritop/labels{/name}","releases_url":"https://api.github.com/repos/fengjingchao/meritop/releases{/id}","created_at":"2014-11-09T19:09:39Z","updated_at":"2014-11-19T07:31:12Z","pushed_at":"2014-11-19T07:31:12Z","git_url":"git://github.com/fengjingchao/meritop.git","ssh_url":"git@github.com:fengjingchao/meritop.git","clone_url":"https://github.com/fengjingchao/meritop.git","svn_url":"https://github.com/fengjingchao/meritop","homepage":null,"size":314,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-distributed:master","ref":"master","sha":"940fc8914257651563fb13cf740c33d946b06fcd","user":{"login":"go-distributed","id":6145847,"avatar_url":"https://avatars.githubusercontent.com/u/6145847?v=3","gravatar_id":"","url":"https://api.github.com/users/go-distributed","html_url":"https://github.com/go-distributed","followers_url":"https://api.github.com/users/go-distributed/followers","following_url":"https://api.github.com/users/go-distributed/following{/other_user}","gists_url":"https://api.github.com/users/go-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/go-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-distributed/subscriptions","organizations_url":"https://api.github.com/users/go-distributed/orgs","repos_url":"https://api.github.com/users/go-distributed/repos","events_url":"https://api.github.com/users/go-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/go-distributed/received_events","type":"Organization","site_admin":false},"repo":{"id":24970635,"name":"meritop","full_name":"go-distributed/meritop","owner":{"login":"go-distributed","id":6145847,"avatar_url":"https://avatars.githubusercontent.com/u/6145847?v=3","gravatar_id":"","url":"https://api.github.com/users/go-distributed","html_url":"https://github.com/go-distributed","followers_url":"https://api.github.com/users/go-distributed/followers","following_url":"https://api.github.com/users/go-distributed/following{/other_user}","gists_url":"https://api.github.com/users/go-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/go-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-distributed/subscriptions","organizations_url":"https://api.github.com/users/go-distributed/orgs","repos_url":"https://api.github.com/users/go-distributed/repos","events_url":"https://api.github.com/users/go-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/go-distributed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-distributed/meritop","description":"","fork":false,"url":"https://api.github.com/repos/go-distributed/meritop","forks_url":"https://api.github.com/repos/go-distributed/meritop/forks","keys_url":"https://api.github.com/repos/go-distributed/meritop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-distributed/meritop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-distributed/meritop/teams","hooks_url":"https://api.github.com/repos/go-distributed/meritop/hooks","issue_events_url":"https://api.github.com/repos/go-distributed/meritop/issues/events{/number}","events_url":"https://api.github.com/repos/go-distributed/meritop/events","assignees_url":"https://api.github.com/repos/go-distributed/meritop/assignees{/user}","branches_url":"https://api.github.com/repos/go-distributed/meritop/branches{/branch}","tags_url":"https://api.github.com/repos/go-distributed/meritop/tags","blobs_url":"https://api.github.com/repos/go-distributed/meritop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-distributed/meritop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-distributed/meritop/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-distributed/meritop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-distributed/meritop/statuses/{sha}","languages_url":"https://api.github.com/repos/go-distributed/meritop/languages","stargazers_url":"https://api.github.com/repos/go-distributed/meritop/stargazers","contributors_url":"https://api.github.com/repos/go-distributed/meritop/contributors","subscribers_url":"https://api.github.com/repos/go-distributed/meritop/subscribers","subscription_url":"https://api.github.com/repos/go-distributed/meritop/subscription","commits_url":"https://api.github.com/repos/go-distributed/meritop/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-distributed/meritop/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-distributed/meritop/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-distributed/meritop/issues/comments/{number}","contents_url":"https://api.github.com/repos/go-distributed/meritop/contents/{+path}","compare_url":"https://api.github.com/repos/go-distributed/meritop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-distributed/meritop/merges","archive_url":"https://api.github.com/repos/go-distributed/meritop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-distributed/meritop/downloads","issues_url":"https://api.github.com/repos/go-distributed/meritop/issues{/number}","pulls_url":"https://api.github.com/repos/go-distributed/meritop/pulls{/number}","milestones_url":"https://api.github.com/repos/go-distributed/meritop/milestones{/number}","notifications_url":"https://api.github.com/repos/go-distributed/meritop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-distributed/meritop/labels{/name}","releases_url":"https://api.github.com/repos/go-distributed/meritop/releases{/id}","created_at":"2014-10-09T02:41:20Z","updated_at":"2014-11-19T15:07:46Z","pushed_at":"2014-11-18T23:15:38Z","git_url":"git://github.com/go-distributed/meritop.git","ssh_url":"git@github.com:go-distributed/meritop.git","clone_url":"https://github.com/go-distributed/meritop.git","svn_url":"https://github.com/go-distributed/meritop","homepage":null,"size":789,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-distributed/meritop/pulls/36"},"html":{"href":"https://github.com/go-distributed/meritop/pull/36"},"issue":{"href":"https://api.github.com/repos/go-distributed/meritop/issues/36"},"comments":{"href":"https://api.github.com/repos/go-distributed/meritop/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/go-distributed/meritop/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/go-distributed/meritop/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/go-distributed/meritop/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/go-distributed/meritop/statuses/4d203e7bb9205a2e5bbb91bd2179279e22ed42a3"}}}}