GitHub PullRequestReviewCommentEvent at 2014-08-12 09:28:20
Repository: junit
Actor: stefanbirkner
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/junit-team/junit/pulls/comments/16103366","id":16103366,"diff_hunk":"@@ -84,7 +84,16 @@ public void newFolderWithGivenFolderThrowsIllegalArgumentExceptionIfFolderExists\n         thrown.expectMessage(\"a folder with the name 'level1' already exists\");\n         tempFolder.newFolder(\"level1\");\n     }\n-\n+    \n+    @Test\n+    public void newFolderWithGivenFolderThrowsIOExceptionIfFolderNameConsistsOfMultiplePathComponents()\n+            throws IOException {\n+        thrown.expect(IOException.class);\n+        thrown.expectMessage(\"name cannot consist of multiple path components\");\n+        tempFolder.create();","path":"src/test/java/org/junit/tests/experimental/rules/TemporaryFolderUsageTest.java","position":11,"original_position":11,"commit_id":"07dcfaa5b4a49b2ae5efb539beac4704d00fc156","original_commit_id":"07dcfaa5b4a49b2ae5efb539beac4704d00fc156","user":{"login":"stefanbirkner","id":711349,"avatar_url":"https://avatars.githubusercontent.com/u/711349?v=2","gravatar_id":"fa5767c967d4733b5937d4e9c265ee4b","url":"https://api.github.com/users/stefanbirkner","html_url":"https://github.com/stefanbirkner","followers_url":"https://api.github.com/users/stefanbirkner/followers","following_url":"https://api.github.com/users/stefanbirkner/following{/other_user}","gists_url":"https://api.github.com/users/stefanbirkner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanbirkner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanbirkner/subscriptions","organizations_url":"https://api.github.com/users/stefanbirkner/orgs","repos_url":"https://api.github.com/users/stefanbirkner/repos","events_url":"https://api.github.com/users/stefanbirkner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanbirkner/received_events","type":"User","site_admin":false},"body":"This line should be placed before the `thrown.expect...` calls, because the exception must be thrown by `tempFolder.newFolder`.","created_at":"2014-08-12T09:28:20Z","updated_at":"2014-08-12T09:28:20Z","html_url":"https://github.com/junit-team/junit/pull/974#discussion_r16103366","pull_request_url":"https://api.github.com/repos/junit-team/junit/pulls/974","_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit/pulls/comments/16103366"},"html":{"href":"https://github.com/junit-team/junit/pull/974#discussion_r16103366"},"pull_request":{"href":"https://api.github.com/repos/junit-team/junit/pulls/974"}}},"pull_request":{"url":"https://api.github.com/repos/junit-team/junit/pulls/974","id":19564284,"html_url":"https://github.com/junit-team/junit/pull/974","diff_url":"https://github.com/junit-team/junit/pull/974.diff","patch_url":"https://github.com/junit-team/junit/pull/974.patch","issue_url":"https://api.github.com/repos/junit-team/junit/issues/974","number":974,"state":"open","title":"Update TemporaryFolder.newFolder() to give a better error message if a path contains a slash","user":{"login":"priav03","id":8236393,"avatar_url":"https://avatars.githubusercontent.com/u/8236393?v=2","gravatar_id":"2fa41af96c9fdf5fa5af74862f9d2838","url":"https://api.github.com/users/priav03","html_url":"https://github.com/priav03","followers_url":"https://api.github.com/users/priav03/followers","following_url":"https://api.github.com/users/priav03/following{/other_user}","gists_url":"https://api.github.com/users/priav03/gists{/gist_id}","starred_url":"https://api.github.com/users/priav03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priav03/subscriptions","organizations_url":"https://api.github.com/users/priav03/orgs","repos_url":"https://api.github.com/users/priav03/repos","events_url":"https://api.github.com/users/priav03/events{/privacy}","received_events_url":"https://api.github.com/users/priav03/received_events","type":"User","site_admin":false},"body":"Please review the fix and let me know if it does good.","created_at":"2014-08-09T13:24:48Z","updated_at":"2014-08-12T09:28:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f66d33a81617811f344b68c4931d1c47c3b52a96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/junit-team/junit/pulls/974/commits","review_comments_url":"https://api.github.com/repos/junit-team/junit/pulls/974/comments","review_comment_url":"https://api.github.com/repos/junit-team/junit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/junit-team/junit/issues/974/comments","statuses_url":"https://api.github.com/repos/junit-team/junit/statuses/07dcfaa5b4a49b2ae5efb539beac4704d00fc156","head":{"label":"priav03:master","ref":"master","sha":"07dcfaa5b4a49b2ae5efb539beac4704d00fc156","user":{"login":"priav03","id":8236393,"avatar_url":"https://avatars.githubusercontent.com/u/8236393?v=2","gravatar_id":"2fa41af96c9fdf5fa5af74862f9d2838","url":"https://api.github.com/users/priav03","html_url":"https://github.com/priav03","followers_url":"https://api.github.com/users/priav03/followers","following_url":"https://api.github.com/users/priav03/following{/other_user}","gists_url":"https://api.github.com/users/priav03/gists{/gist_id}","starred_url":"https://api.github.com/users/priav03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priav03/subscriptions","organizations_url":"https://api.github.com/users/priav03/orgs","repos_url":"https://api.github.com/users/priav03/repos","events_url":"https://api.github.com/users/priav03/events{/privacy}","received_events_url":"https://api.github.com/users/priav03/received_events","type":"User","site_admin":false},"repo":{"id":22786492,"name":"junit","full_name":"priav03/junit","owner":{"login":"priav03","id":8236393,"avatar_url":"https://avatars.githubusercontent.com/u/8236393?v=2","gravatar_id":"2fa41af96c9fdf5fa5af74862f9d2838","url":"https://api.github.com/users/priav03","html_url":"https://github.com/priav03","followers_url":"https://api.github.com/users/priav03/followers","following_url":"https://api.github.com/users/priav03/following{/other_user}","gists_url":"https://api.github.com/users/priav03/gists{/gist_id}","starred_url":"https://api.github.com/users/priav03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priav03/subscriptions","organizations_url":"https://api.github.com/users/priav03/orgs","repos_url":"https://api.github.com/users/priav03/repos","events_url":"https://api.github.com/users/priav03/events{/privacy}","received_events_url":"https://api.github.com/users/priav03/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/priav03/junit","description":"A programmer-oriented testing framework for Java.","fork":true,"url":"https://api.github.com/repos/priav03/junit","forks_url":"https://api.github.com/repos/priav03/junit/forks","keys_url":"https://api.github.com/repos/priav03/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/priav03/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/priav03/junit/teams","hooks_url":"https://api.github.com/repos/priav03/junit/hooks","issue_events_url":"https://api.github.com/repos/priav03/junit/issues/events{/number}","events_url":"https://api.github.com/repos/priav03/junit/events","assignees_url":"https://api.github.com/repos/priav03/junit/assignees{/user}","branches_url":"https://api.github.com/repos/priav03/junit/branches{/branch}","tags_url":"https://api.github.com/repos/priav03/junit/tags","blobs_url":"https://api.github.com/repos/priav03/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/priav03/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/priav03/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/priav03/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/priav03/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/priav03/junit/languages","stargazers_url":"https://api.github.com/repos/priav03/junit/stargazers","contributors_url":"https://api.github.com/repos/priav03/junit/contributors","subscribers_url":"https://api.github.com/repos/priav03/junit/subscribers","subscription_url":"https://api.github.com/repos/priav03/junit/subscription","commits_url":"https://api.github.com/repos/priav03/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/priav03/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/priav03/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/priav03/junit/issues/comments/{number}","contents_url":"https://api.github.com/repos/priav03/junit/contents/{+path}","compare_url":"https://api.github.com/repos/priav03/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/priav03/junit/merges","archive_url":"https://api.github.com/repos/priav03/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/priav03/junit/downloads","issues_url":"https://api.github.com/repos/priav03/junit/issues{/number}","pulls_url":"https://api.github.com/repos/priav03/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/priav03/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/priav03/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/priav03/junit/labels{/name}","releases_url":"https://api.github.com/repos/priav03/junit/releases{/id}","created_at":"2014-08-09T13:15:48Z","updated_at":"2014-08-09T13:22:29Z","pushed_at":"2014-08-11T19:08:11Z","git_url":"git://github.com/priav03/junit.git","ssh_url":"git@github.com:priav03/junit.git","clone_url":"https://github.com/priav03/junit.git","svn_url":"https://github.com/priav03/junit","homepage":"","size":11171,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"junit-team:master","ref":"master","sha":"7c6c36d0de0caf3b44ea80f93c7c4efe6644e1fc","user":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=2","gravatar_id":"075328bf957813f5bdb0756dd026f8d7","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"repo":{"id":106310,"name":"junit","full_name":"junit-team/junit","owner":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=2","gravatar_id":"075328bf957813f5bdb0756dd026f8d7","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/junit-team/junit","description":"A programmer-oriented testing framework for Java.","fork":false,"url":"https://api.github.com/repos/junit-team/junit","forks_url":"https://api.github.com/repos/junit-team/junit/forks","keys_url":"https://api.github.com/repos/junit-team/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junit-team/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junit-team/junit/teams","hooks_url":"https://api.github.com/repos/junit-team/junit/hooks","issue_events_url":"https://api.github.com/repos/junit-team/junit/issues/events{/number}","events_url":"https://api.github.com/repos/junit-team/junit/events","assignees_url":"https://api.github.com/repos/junit-team/junit/assignees{/user}","branches_url":"https://api.github.com/repos/junit-team/junit/branches{/branch}","tags_url":"https://api.github.com/repos/junit-team/junit/tags","blobs_url":"https://api.github.com/repos/junit-team/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junit-team/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junit-team/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/junit-team/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junit-team/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/junit-team/junit/languages","stargazers_url":"https://api.github.com/repos/junit-team/junit/stargazers","contributors_url":"https://api.github.com/repos/junit-team/junit/contributors","subscribers_url":"https://api.github.com/repos/junit-team/junit/subscribers","subscription_url":"https://api.github.com/repos/junit-team/junit/subscription","commits_url":"https://api.github.com/repos/junit-team/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/junit-team/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/junit-team/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/junit-team/junit/issues/comments/{number}","contents_url":"https://api.github.com/repos/junit-team/junit/contents/{+path}","compare_url":"https://api.github.com/repos/junit-team/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junit-team/junit/merges","archive_url":"https://api.github.com/repos/junit-team/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junit-team/junit/downloads","issues_url":"https://api.github.com/repos/junit-team/junit/issues{/number}","pulls_url":"https://api.github.com/repos/junit-team/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/junit-team/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/junit-team/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junit-team/junit/labels{/name}","releases_url":"https://api.github.com/repos/junit-team/junit/releases{/id}","created_at":"2009-01-13T03:41:26Z","updated_at":"2014-08-11T11:18:38Z","pushed_at":"2014-08-05T19:06:32Z","git_url":"git://github.com/junit-team/junit.git","ssh_url":"git@github.com:junit-team/junit.git","clone_url":"https://github.com/junit-team/junit.git","svn_url":"https://github.com/junit-team/junit","homepage":"","size":29749,"stargazers_count":2785,"watchers_count":2785,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1038,"mirror_url":null,"open_issues_count":144,"forks":1038,"open_issues":144,"watchers":2785,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit/pulls/974"},"html":{"href":"https://github.com/junit-team/junit/pull/974"},"issue":{"href":"https://api.github.com/repos/junit-team/junit/issues/974"},"comments":{"href":"https://api.github.com/repos/junit-team/junit/issues/974/comments"},"review_comments":{"href":"https://api.github.com/repos/junit-team/junit/pulls/974/comments"},"review_comment":{"href":"https://api.github.com/repos/junit-team/junit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/junit-team/junit/pulls/974/commits"},"statuses":{"href":"https://api.github.com/repos/junit-team/junit/statuses/07dcfaa5b4a49b2ae5efb539beac4704d00fc156"}}}}