GitHub PullRequestReviewCommentEvent at 2014-10-02 15:51:23
Repository: sequelize
Actor: janmeier
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments/18347979","id":18347979,"diff_hunk":"@@ -311,6 +311,39 @@ describe(Support.getTestDialectTeaser(\"DAOFactory\"), function () {\n       })))\n     })\n \n+    it('allows unique on column with field aliases', function() {\n+      var User = this.sequelize.define('UserWithUniqueFieldAlias', {\n+        userName: { type: Sequelize.STRING, unique: 'user_name_unique', field: 'user_name' }\n+      });\n+      return User.sync({ force: true }).bind(this).then(function() {\n+        return this.sequelize.queryInterface.showIndex(User.tableName).then(function(indexes) {\n+          var idxPrimary, idxUnique;\n+          if (dialect === 'sqlite') {\n+            expect(indexes).to.have.length(1);","path":"test/dao-factory.test.js","position":12,"original_position":12,"commit_id":"4b52b819fda6e9794296c0f652e75fae5880fc77","original_commit_id":"4b52b819fda6e9794296c0f652e75fae5880fc77","user":{"login":"janmeier","id":1210224,"avatar_url":"https://avatars.githubusercontent.com/u/1210224?v=2","gravatar_id":"","url":"https://api.github.com/users/janmeier","html_url":"https://github.com/janmeier","followers_url":"https://api.github.com/users/janmeier/followers","following_url":"https://api.github.com/users/janmeier/following{/other_user}","gists_url":"https://api.github.com/users/janmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/janmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janmeier/subscriptions","organizations_url":"https://api.github.com/users/janmeier/orgs","repos_url":"https://api.github.com/users/janmeier/repos","events_url":"https://api.github.com/users/janmeier/events{/privacy}","received_events_url":"https://api.github.com/users/janmeier/received_events","type":"User","site_admin":false},"body":"Oh yes, the joy of working with indexes :) - good work","created_at":"2014-10-02T15:51:23Z","updated_at":"2014-10-02T15:51:23Z","html_url":"https://github.com/sequelize/sequelize/pull/2374#discussion_r18347979","pull_request_url":"https://api.github.com/repos/sequelize/sequelize/pulls/2374","_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments/18347979"},"html":{"href":"https://github.com/sequelize/sequelize/pull/2374#discussion_r18347979"},"pull_request":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/2374"}}},"pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/2374","id":22071494,"html_url":"https://github.com/sequelize/sequelize/pull/2374","diff_url":"https://github.com/sequelize/sequelize/pull/2374.diff","patch_url":"https://github.com/sequelize/sequelize/pull/2374.patch","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/2374","number":2374,"state":"open","locked":false,"title":"Fixes issue #2373","user":{"login":"rfink","id":108414,"avatar_url":"https://avatars.githubusercontent.com/u/108414?v=2","gravatar_id":"","url":"https://api.github.com/users/rfink","html_url":"https://github.com/rfink","followers_url":"https://api.github.com/users/rfink/followers","following_url":"https://api.github.com/users/rfink/following{/other_user}","gists_url":"https://api.github.com/users/rfink/gists{/gist_id}","starred_url":"https://api.github.com/users/rfink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfink/subscriptions","organizations_url":"https://api.github.com/users/rfink/orgs","repos_url":"https://api.github.com/users/rfink/repos","events_url":"https://api.github.com/users/rfink/events{/privacy}","received_events_url":"https://api.github.com/users/rfink/received_events","type":"User","site_admin":false},"body":"Use field if supplied, otherwise fall back to attribute (fixes issue #2373)","created_at":"2014-10-01T13:13:51Z","updated_at":"2014-10-02T15:51:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fa62bcc181f7749d562e81f342b8a1c652e0318","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sequelize/sequelize/pulls/2374/commits","review_comments_url":"https://api.github.com/repos/sequelize/sequelize/pulls/2374/comments","review_comment_url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/2374/comments","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/4b52b819fda6e9794296c0f652e75fae5880fc77","head":{"label":"rfink:bugfix/indexes_with_field_names","ref":"bugfix/indexes_with_field_names","sha":"4b52b819fda6e9794296c0f652e75fae5880fc77","user":{"login":"rfink","id":108414,"avatar_url":"https://avatars.githubusercontent.com/u/108414?v=2","gravatar_id":"","url":"https://api.github.com/users/rfink","html_url":"https://github.com/rfink","followers_url":"https://api.github.com/users/rfink/followers","following_url":"https://api.github.com/users/rfink/following{/other_user}","gists_url":"https://api.github.com/users/rfink/gists{/gist_id}","starred_url":"https://api.github.com/users/rfink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfink/subscriptions","organizations_url":"https://api.github.com/users/rfink/orgs","repos_url":"https://api.github.com/users/rfink/repos","events_url":"https://api.github.com/users/rfink/events{/privacy}","received_events_url":"https://api.github.com/users/rfink/received_events","type":"User","site_admin":false},"repo":{"id":21446486,"name":"sequelize","full_name":"rfink/sequelize","owner":{"login":"rfink","id":108414,"avatar_url":"https://avatars.githubusercontent.com/u/108414?v=2","gravatar_id":"","url":"https://api.github.com/users/rfink","html_url":"https://github.com/rfink","followers_url":"https://api.github.com/users/rfink/followers","following_url":"https://api.github.com/users/rfink/following{/other_user}","gists_url":"https://api.github.com/users/rfink/gists{/gist_id}","starred_url":"https://api.github.com/users/rfink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfink/subscriptions","organizations_url":"https://api.github.com/users/rfink/orgs","repos_url":"https://api.github.com/users/rfink/repos","events_url":"https://api.github.com/users/rfink/events{/privacy}","received_events_url":"https://api.github.com/users/rfink/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rfink/sequelize","description":"Sequelize is an easy-to-use multi sql dialect object-relationship-mapper for node.js. It currently supports MySQL, MariaDB, SQLite and PostgreSQL.","fork":true,"url":"https://api.github.com/repos/rfink/sequelize","forks_url":"https://api.github.com/repos/rfink/sequelize/forks","keys_url":"https://api.github.com/repos/rfink/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rfink/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rfink/sequelize/teams","hooks_url":"https://api.github.com/repos/rfink/sequelize/hooks","issue_events_url":"https://api.github.com/repos/rfink/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/rfink/sequelize/events","assignees_url":"https://api.github.com/repos/rfink/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/rfink/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/rfink/sequelize/tags","blobs_url":"https://api.github.com/repos/rfink/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rfink/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rfink/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/rfink/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rfink/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/rfink/sequelize/languages","stargazers_url":"https://api.github.com/repos/rfink/sequelize/stargazers","contributors_url":"https://api.github.com/repos/rfink/sequelize/contributors","subscribers_url":"https://api.github.com/repos/rfink/sequelize/subscribers","subscription_url":"https://api.github.com/repos/rfink/sequelize/subscription","commits_url":"https://api.github.com/repos/rfink/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/rfink/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/rfink/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/rfink/sequelize/issues/comments/{number}","contents_url":"https://api.github.com/repos/rfink/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/rfink/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rfink/sequelize/merges","archive_url":"https://api.github.com/repos/rfink/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rfink/sequelize/downloads","issues_url":"https://api.github.com/repos/rfink/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/rfink/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/rfink/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/rfink/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rfink/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/rfink/sequelize/releases{/id}","created_at":"2014-07-03T01:54:15Z","updated_at":"2014-07-02T16:08:48Z","pushed_at":"2014-10-01T14:53:37Z","git_url":"git://github.com/rfink/sequelize.git","ssh_url":"git@github.com:rfink/sequelize.git","clone_url":"https://github.com/rfink/sequelize.git","svn_url":"https://github.com/rfink/sequelize","homepage":"http://sequelizejs.com","size":34384,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sequelize:master","ref":"master","sha":"1d8aff72b434d82e9379e432ab7137719ca4b2dd","user":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=2","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"repo":{"id":790359,"name":"sequelize","full_name":"sequelize/sequelize","owner":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=2","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequelize/sequelize","description":"Sequelize is an easy-to-use multi sql dialect object-relationship-mapper for node.js. It currently supports MySQL, MariaDB, SQLite and PostgreSQL.","fork":false,"url":"https://api.github.com/repos/sequelize/sequelize","forks_url":"https://api.github.com/repos/sequelize/sequelize/forks","keys_url":"https://api.github.com/repos/sequelize/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequelize/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequelize/sequelize/teams","hooks_url":"https://api.github.com/repos/sequelize/sequelize/hooks","issue_events_url":"https://api.github.com/repos/sequelize/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/sequelize/sequelize/events","assignees_url":"https://api.github.com/repos/sequelize/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/sequelize/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/sequelize/sequelize/tags","blobs_url":"https://api.github.com/repos/sequelize/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequelize/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequelize/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequelize/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/sequelize/sequelize/languages","stargazers_url":"https://api.github.com/repos/sequelize/sequelize/stargazers","contributors_url":"https://api.github.com/repos/sequelize/sequelize/contributors","subscribers_url":"https://api.github.com/repos/sequelize/sequelize/subscribers","subscription_url":"https://api.github.com/repos/sequelize/sequelize/subscription","commits_url":"https://api.github.com/repos/sequelize/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequelize/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequelize/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequelize/sequelize/issues/comments/{number}","contents_url":"https://api.github.com/repos/sequelize/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/sequelize/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequelize/sequelize/merges","archive_url":"https://api.github.com/repos/sequelize/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequelize/sequelize/downloads","issues_url":"https://api.github.com/repos/sequelize/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/sequelize/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/sequelize/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/sequelize/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequelize/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/sequelize/sequelize/releases{/id}","created_at":"2010-07-22T07:11:11Z","updated_at":"2014-10-02T14:53:10Z","pushed_at":"2014-10-01T07:37:56Z","git_url":"git://github.com/sequelize/sequelize.git","ssh_url":"git@github.com:sequelize/sequelize.git","clone_url":"https://github.com/sequelize/sequelize.git","svn_url":"https://github.com/sequelize/sequelize","homepage":"http://sequelizejs.com","size":57655,"stargazers_count":2558,"watchers_count":2558,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":588,"mirror_url":null,"open_issues_count":222,"forks":588,"open_issues":222,"watchers":2558,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/2374"},"html":{"href":"https://github.com/sequelize/sequelize/pull/2374"},"issue":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/2374"},"comments":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/2374/comments"},"review_comments":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/2374/comments"},"review_comment":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/2374/commits"},"statuses":{"href":"https://api.github.com/repos/sequelize/sequelize/statuses/4b52b819fda6e9794296c0f652e75fae5880fc77"}}}}