GitHub PullRequestReviewCommentEvent at 2014-09-23 14:55:30
Repository: jbosstools-forge
Actor: gastaldi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls/comments/17913535","id":17913535,"diff_hunk":"@@ -162,4 +168,90 @@ protected String getSupportedInputType() {\n \tprotected Class<?>[] getSupportedInputComponentTypes() {\n \t\treturn new Class<?>[] { UISelectMany.class };\n \t}\n+\n+\tprivate static final Set<Table> TABLE_STATUS_CHANGE = Sets\n+\t\t\t.getConcurrentSet();\n+\n+\t@Override\n+\tpublic void updateState(Table control, InputComponent<?, ?> input) {\n+\t\tif (!TABLE_STATUS_CHANGE.add(control)) {\n+\t\t\treturn;\n+\t\t}\n+\t\ttry {\n+\t\t\tsuper.updateState(control, input);\n+\t\t\tupdateValues(control, input);\n+\t\t} finally {\n+\t\t\tTABLE_STATUS_CHANGE.remove(control);\n+\t\t}\n+\n+\t}\n+\n+\t@SuppressWarnings(\"unchecked\")\n+\tprivate void updateValues(Table table, InputComponent<?, ?> input) {\n+\t\tUISelectMany<Object> selectMany = (UISelectMany<Object>) input;\n+\t\tIterable<Object> valueChoices = selectMany.getValueChoices();\n+\t\tif (valueChoices == null)\n+\t\t\treturn;\n+\t\tList<String> newItems = new ArrayList<String>();","path":"plugins/org.jboss.tools.forge.ui/src/org/jboss/tools/forge/ui/internal/ext/control/many/CheckboxTableControlBuilder.java","position":107,"original_position":107,"commit_id":"4397f32144b82dab267a7d3c17374f64f5595e88","original_commit_id":"4397f32144b82dab267a7d3c17374f64f5595e88","user":{"login":"gastaldi","id":54133,"avatar_url":"https://avatars.githubusercontent.com/u/54133?v=2","gravatar_id":"","url":"https://api.github.com/users/gastaldi","html_url":"https://github.com/gastaldi","followers_url":"https://api.github.com/users/gastaldi/followers","following_url":"https://api.github.com/users/gastaldi/following{/other_user}","gists_url":"https://api.github.com/users/gastaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/gastaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gastaldi/subscriptions","organizations_url":"https://api.github.com/users/gastaldi/orgs","repos_url":"https://api.github.com/users/gastaldi/repos","events_url":"https://api.github.com/users/gastaldi/events{/privacy}","received_events_url":"https://api.github.com/users/gastaldi/received_events","type":"User","site_admin":false},"body":"nope, it's an Iterable","created_at":"2014-09-23T14:55:30Z","updated_at":"2014-09-23T14:55:30Z","html_url":"https://github.com/jbosstools/jbosstools-forge/pull/108#discussion_r17913535","pull_request_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls/108","_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls/comments/17913535"},"html":{"href":"https://github.com/jbosstools/jbosstools-forge/pull/108#discussion_r17913535"},"pull_request":{"href":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls/108","id":21621335,"html_url":"https://github.com/jbosstools/jbosstools-forge/pull/108","diff_url":"https://github.com/jbosstools/jbosstools-forge/pull/108.diff","patch_url":"https://github.com/jbosstools/jbosstools-forge/pull/108.patch","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/issues/108","number":108,"state":"open","locked":false,"title":"JBIDE-18413: Refreshing CheckboxTableControlBuilder choices when value choices change","user":{"login":"gastaldi","id":54133,"avatar_url":"https://avatars.githubusercontent.com/u/54133?v=2","gravatar_id":"","url":"https://api.github.com/users/gastaldi","html_url":"https://github.com/gastaldi","followers_url":"https://api.github.com/users/gastaldi/followers","following_url":"https://api.github.com/users/gastaldi/following{/other_user}","gists_url":"https://api.github.com/users/gastaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/gastaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gastaldi/subscriptions","organizations_url":"https://api.github.com/users/gastaldi/orgs","repos_url":"https://api.github.com/users/gastaldi/repos","events_url":"https://api.github.com/users/gastaldi/events{/privacy}","received_events_url":"https://api.github.com/users/gastaldi/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-23T01:47:51Z","updated_at":"2014-09-23T14:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ac72d4cf1038632b172159796b8340e5529d218","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls/108/commits","review_comments_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls/108/comments","review_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/issues/108/comments","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/statuses/4397f32144b82dab267a7d3c17374f64f5595e88","head":{"label":"gastaldi:JBIDE-18413","ref":"JBIDE-18413","sha":"4397f32144b82dab267a7d3c17374f64f5595e88","user":{"login":"gastaldi","id":54133,"avatar_url":"https://avatars.githubusercontent.com/u/54133?v=2","gravatar_id":"","url":"https://api.github.com/users/gastaldi","html_url":"https://github.com/gastaldi","followers_url":"https://api.github.com/users/gastaldi/followers","following_url":"https://api.github.com/users/gastaldi/following{/other_user}","gists_url":"https://api.github.com/users/gastaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/gastaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gastaldi/subscriptions","organizations_url":"https://api.github.com/users/gastaldi/orgs","repos_url":"https://api.github.com/users/gastaldi/repos","events_url":"https://api.github.com/users/gastaldi/events{/privacy}","received_events_url":"https://api.github.com/users/gastaldi/received_events","type":"User","site_admin":false},"repo":{"id":6597252,"name":"jbosstools-forge","full_name":"gastaldi/jbosstools-forge","owner":{"login":"gastaldi","id":54133,"avatar_url":"https://avatars.githubusercontent.com/u/54133?v=2","gravatar_id":"","url":"https://api.github.com/users/gastaldi","html_url":"https://github.com/gastaldi","followers_url":"https://api.github.com/users/gastaldi/followers","following_url":"https://api.github.com/users/gastaldi/following{/other_user}","gists_url":"https://api.github.com/users/gastaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/gastaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gastaldi/subscriptions","organizations_url":"https://api.github.com/users/gastaldi/orgs","repos_url":"https://api.github.com/users/gastaldi/repos","events_url":"https://api.github.com/users/gastaldi/events{/privacy}","received_events_url":"https://api.github.com/users/gastaldi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gastaldi/jbosstools-forge","description":"JBoss Tools :: Forge { forge }","fork":true,"url":"https://api.github.com/repos/gastaldi/jbosstools-forge","forks_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/forks","keys_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/teams","hooks_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/hooks","issue_events_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/issues/events{/number}","events_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/events","assignees_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/assignees{/user}","branches_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/branches{/branch}","tags_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/tags","blobs_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/git/refs{/sha}","trees_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/statuses/{sha}","languages_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/languages","stargazers_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/stargazers","contributors_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/contributors","subscribers_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/subscribers","subscription_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/subscription","commits_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/commits{/sha}","git_commits_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/git/commits{/sha}","comments_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/comments{/number}","issue_comment_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/issues/comments/{number}","contents_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/contents/{+path}","compare_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/merges","archive_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/downloads","issues_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/issues{/number}","pulls_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/pulls{/number}","milestones_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/milestones{/number}","notifications_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/labels{/name}","releases_url":"https://api.github.com/repos/gastaldi/jbosstools-forge/releases{/id}","created_at":"2012-11-08T14:09:37Z","updated_at":"2014-09-08T14:40:01Z","pushed_at":"2014-09-23T14:19:07Z","git_url":"git://github.com/gastaldi/jbosstools-forge.git","ssh_url":"git@github.com:gastaldi/jbosstools-forge.git","clone_url":"https://github.com/gastaldi/jbosstools-forge.git","svn_url":"https://github.com/gastaldi/jbosstools-forge","homepage":"","size":52081,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jbosstools:jbosstools-4.2.x","ref":"jbosstools-4.2.x","sha":"845166dd8827a2443a05328b396968d87fedda89","user":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=2","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"repo":{"id":6308279,"name":"jbosstools-forge","full_name":"jbosstools/jbosstools-forge","owner":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=2","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jbosstools/jbosstools-forge","description":"JBoss Tools :: Forge { forge }","fork":false,"url":"https://api.github.com/repos/jbosstools/jbosstools-forge","forks_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/forks","keys_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/teams","hooks_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/hooks","issue_events_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/issues/events{/number}","events_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/events","assignees_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/assignees{/user}","branches_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/branches{/branch}","tags_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/tags","blobs_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/statuses/{sha}","languages_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/languages","stargazers_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/stargazers","contributors_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/contributors","subscribers_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/subscribers","subscription_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/subscription","commits_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/issues/comments/{number}","contents_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/contents/{+path}","compare_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/merges","archive_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/downloads","issues_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/issues{/number}","pulls_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls{/number}","milestones_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/milestones{/number}","notifications_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/labels{/name}","releases_url":"https://api.github.com/repos/jbosstools/jbosstools-forge/releases{/id}","created_at":"2012-10-20T11:22:55Z","updated_at":"2014-09-05T19:54:18Z","pushed_at":"2014-09-23T14:19:05Z","git_url":"git://github.com/jbosstools/jbosstools-forge.git","ssh_url":"git@github.com:jbosstools/jbosstools-forge.git","clone_url":"https://github.com/jbosstools/jbosstools-forge.git","svn_url":"https://github.com/jbosstools/jbosstools-forge","homepage":"","size":57141,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":1,"forks":22,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls/108"},"html":{"href":"https://github.com/jbosstools/jbosstools-forge/pull/108"},"issue":{"href":"https://api.github.com/repos/jbosstools/jbosstools-forge/issues/108"},"comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-forge/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jbosstools/jbosstools-forge/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/jbosstools/jbosstools-forge/statuses/4397f32144b82dab267a7d3c17374f64f5595e88"}}}}