GitHub PullRequestReviewCommentEvent at 2014-10-14 13:37:46
Repository: blaze
Actor: brittainhard
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ContinuumIO/blaze/pulls/comments/18828092","id":18828092,"diff_hunk":"@@ -101,10 +95,10 @@ def compute_up(t, x, **kwargs):\n     if (t.key in x.dtype.names or\n         isinstance(t.key, list) and all(k in x.dtype.names for k in t.key)):\n         result = np.sort(x, order=t.key)\n-    elif t.key:\n-        raise NotImplementedError(\"Sort key %s not supported\" % str(t.key))\n+    elif t.key not in x.dtype.names or not all(k in x.dtype.names for k in t.key):\n+        raise ValueError(\"Column %s not found in numpy array\" % t.key)\n     else:\n-        result = np.sort(x)\n+        result = np.sort(x) # pragma: no cover","path":"blaze/compute/numpy.py","position":43,"original_position":43,"commit_id":"70d6169c9b4335e5bb2c9754a6b93bdaa94f7f3a","original_commit_id":"70d6169c9b4335e5bb2c9754a6b93bdaa94f7f3a","user":{"login":"brittainhard","id":5440553,"avatar_url":"https://avatars.githubusercontent.com/u/5440553?v=2","gravatar_id":"","url":"https://api.github.com/users/brittainhard","html_url":"https://github.com/brittainhard","followers_url":"https://api.github.com/users/brittainhard/followers","following_url":"https://api.github.com/users/brittainhard/following{/other_user}","gists_url":"https://api.github.com/users/brittainhard/gists{/gist_id}","starred_url":"https://api.github.com/users/brittainhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittainhard/subscriptions","organizations_url":"https://api.github.com/users/brittainhard/orgs","repos_url":"https://api.github.com/users/brittainhard/repos","events_url":"https://api.github.com/users/brittainhard/events{/privacy}","received_events_url":"https://api.github.com/users/brittainhard/received_events","type":"User","site_admin":false},"body":"In this case that line of code is pretty well impossible to reach. I regarded it as a sort of catch all for anything that might pass through that function that doesn't meet the criteria of the first two control flow statements. I couldn't understand how to run that statement nor did I want to get rid of it. I felt like it was gonna stay around so hiding it from coverage felt like the best thing. It's kind of tricky deciding what should be covered or not sometimes. ","created_at":"2014-10-14T13:37:46Z","updated_at":"2014-10-14T13:37:46Z","html_url":"https://github.com/ContinuumIO/blaze/pull/739#discussion_r18828092","pull_request_url":"https://api.github.com/repos/ContinuumIO/blaze/pulls/739","_links":{"self":{"href":"https://api.github.com/repos/ContinuumIO/blaze/pulls/comments/18828092"},"html":{"href":"https://github.com/ContinuumIO/blaze/pull/739#discussion_r18828092"},"pull_request":{"href":"https://api.github.com/repos/ContinuumIO/blaze/pulls/739"}}},"pull_request":{"url":"https://api.github.com/repos/ContinuumIO/blaze/pulls/739","id":22680279,"html_url":"https://github.com/ContinuumIO/blaze/pull/739","diff_url":"https://github.com/ContinuumIO/blaze/pull/739.diff","patch_url":"https://github.com/ContinuumIO/blaze/pull/739.patch","issue_url":"https://api.github.com/repos/ContinuumIO/blaze/issues/739","number":739,"state":"open","locked":false,"title":"Docs Makefile additions, compute/numpy tests.","user":{"login":"brittainhard","id":5440553,"avatar_url":"https://avatars.githubusercontent.com/u/5440553?v=2","gravatar_id":"","url":"https://api.github.com/users/brittainhard","html_url":"https://github.com/brittainhard","followers_url":"https://api.github.com/users/brittainhard/followers","following_url":"https://api.github.com/users/brittainhard/following{/other_user}","gists_url":"https://api.github.com/users/brittainhard/gists{/gist_id}","starred_url":"https://api.github.com/users/brittainhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittainhard/subscriptions","organizations_url":"https://api.github.com/users/brittainhard/orgs","repos_url":"https://api.github.com/users/brittainhard/repos","events_url":"https://api.github.com/users/brittainhard/events{/privacy}","received_events_url":"https://api.github.com/users/brittainhard/received_events","type":"User","site_admin":false},"body":"Fixes the problem of capabilities.py failing to create the graph the first time docs are built on a machine. Simple fix. Also, there are some tests and random changes to compute_numpy in here that I added in. Going to remove the other pull request. @mrocklin @cpcloud ","created_at":"2014-10-14T00:00:18Z","updated_at":"2014-10-14T13:37:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4823f6c3791ac03f665036fbf600ec5aa049befa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ContinuumIO/blaze/pulls/739/commits","review_comments_url":"https://api.github.com/repos/ContinuumIO/blaze/pulls/739/comments","review_comment_url":"https://api.github.com/repos/ContinuumIO/blaze/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ContinuumIO/blaze/issues/739/comments","statuses_url":"https://api.github.com/repos/ContinuumIO/blaze/statuses/70d6169c9b4335e5bb2c9754a6b93bdaa94f7f3a","head":{"label":"brittainhard:capabilities_makefile","ref":"capabilities_makefile","sha":"70d6169c9b4335e5bb2c9754a6b93bdaa94f7f3a","user":{"login":"brittainhard","id":5440553,"avatar_url":"https://avatars.githubusercontent.com/u/5440553?v=2","gravatar_id":"","url":"https://api.github.com/users/brittainhard","html_url":"https://github.com/brittainhard","followers_url":"https://api.github.com/users/brittainhard/followers","following_url":"https://api.github.com/users/brittainhard/following{/other_user}","gists_url":"https://api.github.com/users/brittainhard/gists{/gist_id}","starred_url":"https://api.github.com/users/brittainhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittainhard/subscriptions","organizations_url":"https://api.github.com/users/brittainhard/orgs","repos_url":"https://api.github.com/users/brittainhard/repos","events_url":"https://api.github.com/users/brittainhard/events{/privacy}","received_events_url":"https://api.github.com/users/brittainhard/received_events","type":"User","site_admin":false},"repo":{"id":23762069,"name":"blaze","full_name":"brittainhard/blaze","owner":{"login":"brittainhard","id":5440553,"avatar_url":"https://avatars.githubusercontent.com/u/5440553?v=2","gravatar_id":"","url":"https://api.github.com/users/brittainhard","html_url":"https://github.com/brittainhard","followers_url":"https://api.github.com/users/brittainhard/followers","following_url":"https://api.github.com/users/brittainhard/following{/other_user}","gists_url":"https://api.github.com/users/brittainhard/gists{/gist_id}","starred_url":"https://api.github.com/users/brittainhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittainhard/subscriptions","organizations_url":"https://api.github.com/users/brittainhard/orgs","repos_url":"https://api.github.com/users/brittainhard/repos","events_url":"https://api.github.com/users/brittainhard/events{/privacy}","received_events_url":"https://api.github.com/users/brittainhard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brittainhard/blaze","description":"NumPy and Pandas interface to Big Data","fork":true,"url":"https://api.github.com/repos/brittainhard/blaze","forks_url":"https://api.github.com/repos/brittainhard/blaze/forks","keys_url":"https://api.github.com/repos/brittainhard/blaze/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brittainhard/blaze/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brittainhard/blaze/teams","hooks_url":"https://api.github.com/repos/brittainhard/blaze/hooks","issue_events_url":"https://api.github.com/repos/brittainhard/blaze/issues/events{/number}","events_url":"https://api.github.com/repos/brittainhard/blaze/events","assignees_url":"https://api.github.com/repos/brittainhard/blaze/assignees{/user}","branches_url":"https://api.github.com/repos/brittainhard/blaze/branches{/branch}","tags_url":"https://api.github.com/repos/brittainhard/blaze/tags","blobs_url":"https://api.github.com/repos/brittainhard/blaze/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brittainhard/blaze/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brittainhard/blaze/git/refs{/sha}","trees_url":"https://api.github.com/repos/brittainhard/blaze/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brittainhard/blaze/statuses/{sha}","languages_url":"https://api.github.com/repos/brittainhard/blaze/languages","stargazers_url":"https://api.github.com/repos/brittainhard/blaze/stargazers","contributors_url":"https://api.github.com/repos/brittainhard/blaze/contributors","subscribers_url":"https://api.github.com/repos/brittainhard/blaze/subscribers","subscription_url":"https://api.github.com/repos/brittainhard/blaze/subscription","commits_url":"https://api.github.com/repos/brittainhard/blaze/commits{/sha}","git_commits_url":"https://api.github.com/repos/brittainhard/blaze/git/commits{/sha}","comments_url":"https://api.github.com/repos/brittainhard/blaze/comments{/number}","issue_comment_url":"https://api.github.com/repos/brittainhard/blaze/issues/comments/{number}","contents_url":"https://api.github.com/repos/brittainhard/blaze/contents/{+path}","compare_url":"https://api.github.com/repos/brittainhard/blaze/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brittainhard/blaze/merges","archive_url":"https://api.github.com/repos/brittainhard/blaze/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brittainhard/blaze/downloads","issues_url":"https://api.github.com/repos/brittainhard/blaze/issues{/number}","pulls_url":"https://api.github.com/repos/brittainhard/blaze/pulls{/number}","milestones_url":"https://api.github.com/repos/brittainhard/blaze/milestones{/number}","notifications_url":"https://api.github.com/repos/brittainhard/blaze/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brittainhard/blaze/labels{/name}","releases_url":"https://api.github.com/repos/brittainhard/blaze/releases{/id}","created_at":"2014-09-07T14:43:31Z","updated_at":"2014-09-08T19:30:49Z","pushed_at":"2014-10-13T19:50:47Z","git_url":"git://github.com/brittainhard/blaze.git","ssh_url":"git@github.com:brittainhard/blaze.git","clone_url":"https://github.com/brittainhard/blaze.git","svn_url":"https://github.com/brittainhard/blaze","homepage":"blaze.pydata.org","size":9084,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ContinuumIO:master","ref":"master","sha":"96e406fe37a38a07c1d66f9f7d0abfd85f5d3304","user":{"login":"ContinuumIO","id":1158637,"avatar_url":"https://avatars.githubusercontent.com/u/1158637?v=2","gravatar_id":"","url":"https://api.github.com/users/ContinuumIO","html_url":"https://github.com/ContinuumIO","followers_url":"https://api.github.com/users/ContinuumIO/followers","following_url":"https://api.github.com/users/ContinuumIO/following{/other_user}","gists_url":"https://api.github.com/users/ContinuumIO/gists{/gist_id}","starred_url":"https://api.github.com/users/ContinuumIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ContinuumIO/subscriptions","organizations_url":"https://api.github.com/users/ContinuumIO/orgs","repos_url":"https://api.github.com/users/ContinuumIO/repos","events_url":"https://api.github.com/users/ContinuumIO/events{/privacy}","received_events_url":"https://api.github.com/users/ContinuumIO/received_events","type":"Organization","site_admin":false},"repo":{"id":6404963,"name":"blaze","full_name":"ContinuumIO/blaze","owner":{"login":"ContinuumIO","id":1158637,"avatar_url":"https://avatars.githubusercontent.com/u/1158637?v=2","gravatar_id":"","url":"https://api.github.com/users/ContinuumIO","html_url":"https://github.com/ContinuumIO","followers_url":"https://api.github.com/users/ContinuumIO/followers","following_url":"https://api.github.com/users/ContinuumIO/following{/other_user}","gists_url":"https://api.github.com/users/ContinuumIO/gists{/gist_id}","starred_url":"https://api.github.com/users/ContinuumIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ContinuumIO/subscriptions","organizations_url":"https://api.github.com/users/ContinuumIO/orgs","repos_url":"https://api.github.com/users/ContinuumIO/repos","events_url":"https://api.github.com/users/ContinuumIO/events{/privacy}","received_events_url":"https://api.github.com/users/ContinuumIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ContinuumIO/blaze","description":"NumPy and Pandas interface to Big Data","fork":false,"url":"https://api.github.com/repos/ContinuumIO/blaze","forks_url":"https://api.github.com/repos/ContinuumIO/blaze/forks","keys_url":"https://api.github.com/repos/ContinuumIO/blaze/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ContinuumIO/blaze/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ContinuumIO/blaze/teams","hooks_url":"https://api.github.com/repos/ContinuumIO/blaze/hooks","issue_events_url":"https://api.github.com/repos/ContinuumIO/blaze/issues/events{/number}","events_url":"https://api.github.com/repos/ContinuumIO/blaze/events","assignees_url":"https://api.github.com/repos/ContinuumIO/blaze/assignees{/user}","branches_url":"https://api.github.com/repos/ContinuumIO/blaze/branches{/branch}","tags_url":"https://api.github.com/repos/ContinuumIO/blaze/tags","blobs_url":"https://api.github.com/repos/ContinuumIO/blaze/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ContinuumIO/blaze/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ContinuumIO/blaze/git/refs{/sha}","trees_url":"https://api.github.com/repos/ContinuumIO/blaze/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ContinuumIO/blaze/statuses/{sha}","languages_url":"https://api.github.com/repos/ContinuumIO/blaze/languages","stargazers_url":"https://api.github.com/repos/ContinuumIO/blaze/stargazers","contributors_url":"https://api.github.com/repos/ContinuumIO/blaze/contributors","subscribers_url":"https://api.github.com/repos/ContinuumIO/blaze/subscribers","subscription_url":"https://api.github.com/repos/ContinuumIO/blaze/subscription","commits_url":"https://api.github.com/repos/ContinuumIO/blaze/commits{/sha}","git_commits_url":"https://api.github.com/repos/ContinuumIO/blaze/git/commits{/sha}","comments_url":"https://api.github.com/repos/ContinuumIO/blaze/comments{/number}","issue_comment_url":"https://api.github.com/repos/ContinuumIO/blaze/issues/comments/{number}","contents_url":"https://api.github.com/repos/ContinuumIO/blaze/contents/{+path}","compare_url":"https://api.github.com/repos/ContinuumIO/blaze/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ContinuumIO/blaze/merges","archive_url":"https://api.github.com/repos/ContinuumIO/blaze/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ContinuumIO/blaze/downloads","issues_url":"https://api.github.com/repos/ContinuumIO/blaze/issues{/number}","pulls_url":"https://api.github.com/repos/ContinuumIO/blaze/pulls{/number}","milestones_url":"https://api.github.com/repos/ContinuumIO/blaze/milestones{/number}","notifications_url":"https://api.github.com/repos/ContinuumIO/blaze/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ContinuumIO/blaze/labels{/name}","releases_url":"https://api.github.com/repos/ContinuumIO/blaze/releases{/id}","created_at":"2012-10-26T14:25:22Z","updated_at":"2014-10-13T21:08:59Z","pushed_at":"2014-10-14T00:49:58Z","git_url":"git://github.com/ContinuumIO/blaze.git","ssh_url":"git@github.com:ContinuumIO/blaze.git","clone_url":"https://github.com/ContinuumIO/blaze.git","svn_url":"https://github.com/ContinuumIO/blaze","homepage":"blaze.pydata.org","size":26284,"stargazers_count":874,"watchers_count":874,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":98,"forks":99,"open_issues":98,"watchers":874,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ContinuumIO/blaze/pulls/739"},"html":{"href":"https://github.com/ContinuumIO/blaze/pull/739"},"issue":{"href":"https://api.github.com/repos/ContinuumIO/blaze/issues/739"},"comments":{"href":"https://api.github.com/repos/ContinuumIO/blaze/issues/739/comments"},"review_comments":{"href":"https://api.github.com/repos/ContinuumIO/blaze/pulls/739/comments"},"review_comment":{"href":"https://api.github.com/repos/ContinuumIO/blaze/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ContinuumIO/blaze/pulls/739/commits"},"statuses":{"href":"https://api.github.com/repos/ContinuumIO/blaze/statuses/70d6169c9b4335e5bb2c9754a6b93bdaa94f7f3a"}}}}