GitHub PullRequestEvent at 2014-12-11 01:31:55
Repository: pfsense
Actor: phil-davis
Payload: {"action":"opened","number":1378,"pull_request":{"url":"https://api.github.com/repos/pfsense/pfsense/pulls/1378","id":25870543,"html_url":"https://github.com/pfsense/pfsense/pull/1378","diff_url":"https://github.com/pfsense/pfsense/pull/1378.diff","patch_url":"https://github.com/pfsense/pfsense/pull/1378.patch","issue_url":"https://api.github.com/repos/pfsense/pfsense/issues/1378","number":1378,"state":"open","locked":false,"title":"Gateway Status Widget keep IP address bold","user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"body":"Forum: https://forum.pfsense.org/index.php?topic=85187.msg467438#msg467438\r\n\r\nThe bold is specified literally in gateways.widget.php for the gateway IP box, so we need to send it bold from here also when providing an update.\r\nBecause this now uses a \"/\" in the string (to terminate the bold) have to choose another delimiter between the status text and status color - picked \"^\" because I can't think where it will appear elsewhere in the real data.\r\nThis whole string of stuff that is returned by getstats.php back to the browser is a long string with a bunch of delimiters inside delimiters already (vertical bar separated fields, inside that comma-separated fields...) and is already subject to stuff going wrong if any of the real text in the fields contains a vertical bar or comma or... Not about to try to re-engineer all that right now!","created_at":"2014-12-11T01:31:55Z","updated_at":"2014-12-11T01:31:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pfsense/pfsense/pulls/1378/commits","review_comments_url":"https://api.github.com/repos/pfsense/pfsense/pulls/1378/comments","review_comment_url":"https://api.github.com/repos/pfsense/pfsense/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pfsense/pfsense/issues/1378/comments","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/2cc10e2cdee54d72921a0f5e1dc527b436eff0f0","head":{"label":"phil-davis:patch-10","ref":"patch-10","sha":"2cc10e2cdee54d72921a0f5e1dc527b436eff0f0","user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"repo":{"id":27484209,"name":"pfsense","full_name":"phil-davis/pfsense","owner":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phil-davis/pfsense","description":"Main repository for pfSense","fork":true,"url":"https://api.github.com/repos/phil-davis/pfsense","forks_url":"https://api.github.com/repos/phil-davis/pfsense/forks","keys_url":"https://api.github.com/repos/phil-davis/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phil-davis/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phil-davis/pfsense/teams","hooks_url":"https://api.github.com/repos/phil-davis/pfsense/hooks","issue_events_url":"https://api.github.com/repos/phil-davis/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/phil-davis/pfsense/events","assignees_url":"https://api.github.com/repos/phil-davis/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/phil-davis/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/phil-davis/pfsense/tags","blobs_url":"https://api.github.com/repos/phil-davis/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phil-davis/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phil-davis/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/phil-davis/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phil-davis/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/phil-davis/pfsense/languages","stargazers_url":"https://api.github.com/repos/phil-davis/pfsense/stargazers","contributors_url":"https://api.github.com/repos/phil-davis/pfsense/contributors","subscribers_url":"https://api.github.com/repos/phil-davis/pfsense/subscribers","subscription_url":"https://api.github.com/repos/phil-davis/pfsense/subscription","commits_url":"https://api.github.com/repos/phil-davis/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/phil-davis/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/phil-davis/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/phil-davis/pfsense/issues/comments/{number}","contents_url":"https://api.github.com/repos/phil-davis/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/phil-davis/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phil-davis/pfsense/merges","archive_url":"https://api.github.com/repos/phil-davis/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phil-davis/pfsense/downloads","issues_url":"https://api.github.com/repos/phil-davis/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/phil-davis/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/phil-davis/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/phil-davis/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phil-davis/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/phil-davis/pfsense/releases{/id}","created_at":"2014-12-03T11:38:33Z","updated_at":"2014-12-03T11:38:39Z","pushed_at":"2014-12-11T01:30:09Z","git_url":"git://github.com/phil-davis/pfsense.git","ssh_url":"git@github.com:phil-davis/pfsense.git","clone_url":"https://github.com/phil-davis/pfsense.git","svn_url":"https://github.com/phil-davis/pfsense","homepage":"http://www.pfsense.org","size":51270,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pfsense:master","ref":"master","sha":"6346f188e1c48de0457c9b39b0a1807b04355969","user":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"repo":{"id":1740040,"name":"pfsense","full_name":"pfsense/pfsense","owner":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pfsense/pfsense","description":"Main repository for pfSense","fork":false,"url":"https://api.github.com/repos/pfsense/pfsense","forks_url":"https://api.github.com/repos/pfsense/pfsense/forks","keys_url":"https://api.github.com/repos/pfsense/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfsense/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfsense/pfsense/teams","hooks_url":"https://api.github.com/repos/pfsense/pfsense/hooks","issue_events_url":"https://api.github.com/repos/pfsense/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/pfsense/pfsense/events","assignees_url":"https://api.github.com/repos/pfsense/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/pfsense/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/pfsense/pfsense/tags","blobs_url":"https://api.github.com/repos/pfsense/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfsense/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfsense/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfsense/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/pfsense/pfsense/languages","stargazers_url":"https://api.github.com/repos/pfsense/pfsense/stargazers","contributors_url":"https://api.github.com/repos/pfsense/pfsense/contributors","subscribers_url":"https://api.github.com/repos/pfsense/pfsense/subscribers","subscription_url":"https://api.github.com/repos/pfsense/pfsense/subscription","commits_url":"https://api.github.com/repos/pfsense/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfsense/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfsense/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfsense/pfsense/issues/comments/{number}","contents_url":"https://api.github.com/repos/pfsense/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/pfsense/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfsense/pfsense/merges","archive_url":"https://api.github.com/repos/pfsense/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfsense/pfsense/downloads","issues_url":"https://api.github.com/repos/pfsense/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/pfsense/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/pfsense/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/pfsense/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfsense/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/pfsense/pfsense/releases{/id}","created_at":"2011-05-12T19:44:21Z","updated_at":"2014-12-10T16:46:56Z","pushed_at":"2014-12-10T16:46:56Z","git_url":"git://github.com/pfsense/pfsense.git","ssh_url":"git@github.com:pfsense/pfsense.git","clone_url":"https://github.com/pfsense/pfsense.git","svn_url":"https://github.com/pfsense/pfsense","homepage":"http://www.pfsense.org","size":77635,"stargazers_count":456,"watchers_count":456,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":292,"mirror_url":null,"open_issues_count":30,"forks":292,"open_issues":30,"watchers":456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1378"},"html":{"href":"https://github.com/pfsense/pfsense/pull/1378"},"issue":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/1378"},"comments":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/1378/comments"},"review_comments":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1378/comments"},"review_comment":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1378/commits"},"statuses":{"href":"https://api.github.com/repos/pfsense/pfsense/statuses/2cc10e2cdee54d72921a0f5e1dc527b436eff0f0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":3,"deletions":3,"changed_files":2}}