GitHub PullRequestEvent at 2014-06-04 13:08:27
Repository: chef
Actor: mirw
Payload: {"action":"closed","number":126,"pull_request":{"url":"https://api.github.com/repos/Metaswitch/chef/pulls/126","id":16706125,"html_url":"https://github.com/Metaswitch/chef/pull/126","diff_url":"https://github.com/Metaswitch/chef/pull/126.diff","patch_url":"https://github.com/Metaswitch/chef/pull/126.patch","issue_url":"https://api.github.com/repos/Metaswitch/chef/issues/126","number":126,"state":"closed","title":"[Reviewer: Mike] Trusted peers","user":{"login":"mirw","id":2963879,"avatar_url":"https://avatars.githubusercontent.com/u/2963879?","gravatar_id":"ff79fd61cea85f47f31eb8da854a3315","url":"https://api.github.com/users/mirw","html_url":"https://github.com/mirw","followers_url":"https://api.github.com/users/mirw/followers","following_url":"https://api.github.com/users/mirw/following{/other_user}","gists_url":"https://api.github.com/users/mirw/gists{/gist_id}","starred_url":"https://api.github.com/users/mirw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirw/subscriptions","organizations_url":"https://api.github.com/users/mirw/orgs","repos_url":"https://api.github.com/users/mirw/repos","events_url":"https://api.github.com/users/mirw/events{/privacy}","received_events_url":"https://api.github.com/users/mirw/received_events","type":"User","site_admin":false},"body":"Mike,\r\n\r\nPlease can you review my enhancement to make the list of trusted peers configurable (rather than hard-coded to `198.147.226.2`?  I've made all bono nodes pick up this configuration, and made ibcf nodes just a clone of bono nodes (although they won't be picked up in the bono cluster domain name in DNS).\r\n\r\nI've live-tested, and also updated the dogfood environment to have the correct trusted peer configured.\r\n\r\nMatt","created_at":"2014-06-04T12:46:14Z","updated_at":"2014-06-04T13:08:27Z","closed_at":"2014-06-04T13:08:27Z","merged_at":"2014-06-04T13:08:27Z","merge_commit_sha":"9a34d9a2de365c2c455e636ce8db045dbc267ed6","assignee":{"login":"mirw","id":2963879,"avatar_url":"https://avatars.githubusercontent.com/u/2963879?","gravatar_id":"ff79fd61cea85f47f31eb8da854a3315","url":"https://api.github.com/users/mirw","html_url":"https://github.com/mirw","followers_url":"https://api.github.com/users/mirw/followers","following_url":"https://api.github.com/users/mirw/following{/other_user}","gists_url":"https://api.github.com/users/mirw/gists{/gist_id}","starred_url":"https://api.github.com/users/mirw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirw/subscriptions","organizations_url":"https://api.github.com/users/mirw/orgs","repos_url":"https://api.github.com/users/mirw/repos","events_url":"https://api.github.com/users/mirw/events{/privacy}","received_events_url":"https://api.github.com/users/mirw/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/chef/pulls/126/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/chef/pulls/126/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/chef/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Metaswitch/chef/issues/126/comments","statuses_url":"https://api.github.com/repos/Metaswitch/chef/statuses/0735e82b3c136d68ccb0ef73fdcc316a047dad32","head":{"label":"Metaswitch:trusted_peers","ref":"trusted_peers","sha":"0735e82b3c136d68ccb0ef73fdcc316a047dad32","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?","gravatar_id":"0c1ee184a78bad0e5e8557204519661c","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9885464,"name":"chef","full_name":"Metaswitch/chef","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?","gravatar_id":"0c1ee184a78bad0e5e8557204519661c","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/chef","description":"Repo to hold chef recipes for Clearwater deployment","fork":false,"url":"https://api.github.com/repos/Metaswitch/chef","forks_url":"https://api.github.com/repos/Metaswitch/chef/forks","keys_url":"https://api.github.com/repos/Metaswitch/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/chef/teams","hooks_url":"https://api.github.com/repos/Metaswitch/chef/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/chef/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/chef/events","assignees_url":"https://api.github.com/repos/Metaswitch/chef/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/chef/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/chef/tags","blobs_url":"https://api.github.com/repos/Metaswitch/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/chef/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/chef/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/chef/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/chef/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/chef/subscription","commits_url":"https://api.github.com/repos/Metaswitch/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/chef/issues/comments/{number}","contents_url":"https://api.github.com/repos/Metaswitch/chef/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/chef/merges","archive_url":"https://api.github.com/repos/Metaswitch/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/chef/downloads","issues_url":"https://api.github.com/repos/Metaswitch/chef/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/chef/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/chef/releases{/id}","created_at":"2013-05-06T11:34:36Z","updated_at":"2014-06-04T13:08:27Z","pushed_at":"2014-06-04T13:08:27Z","git_url":"git://github.com/Metaswitch/chef.git","ssh_url":"git@github.com:Metaswitch/chef.git","clone_url":"https://github.com/Metaswitch/chef.git","svn_url":"https://github.com/Metaswitch/chef","homepage":null,"size":2626,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":2,"default_branch":"master"}},"base":{"label":"Metaswitch:master","ref":"master","sha":"e6216e2e534c50f3396b3c96aac741ae70f06aee","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?","gravatar_id":"0c1ee184a78bad0e5e8557204519661c","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9885464,"name":"chef","full_name":"Metaswitch/chef","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?","gravatar_id":"0c1ee184a78bad0e5e8557204519661c","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/chef","description":"Repo to hold chef recipes for Clearwater deployment","fork":false,"url":"https://api.github.com/repos/Metaswitch/chef","forks_url":"https://api.github.com/repos/Metaswitch/chef/forks","keys_url":"https://api.github.com/repos/Metaswitch/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/chef/teams","hooks_url":"https://api.github.com/repos/Metaswitch/chef/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/chef/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/chef/events","assignees_url":"https://api.github.com/repos/Metaswitch/chef/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/chef/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/chef/tags","blobs_url":"https://api.github.com/repos/Metaswitch/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/chef/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/chef/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/chef/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/chef/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/chef/subscription","commits_url":"https://api.github.com/repos/Metaswitch/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/chef/issues/comments/{number}","contents_url":"https://api.github.com/repos/Metaswitch/chef/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/chef/merges","archive_url":"https://api.github.com/repos/Metaswitch/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/chef/downloads","issues_url":"https://api.github.com/repos/Metaswitch/chef/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/chef/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/chef/releases{/id}","created_at":"2013-05-06T11:34:36Z","updated_at":"2014-06-04T13:08:27Z","pushed_at":"2014-06-04T13:08:27Z","git_url":"git://github.com/Metaswitch/chef.git","ssh_url":"git@github.com:Metaswitch/chef.git","clone_url":"https://github.com/Metaswitch/chef.git","svn_url":"https://github.com/Metaswitch/chef","homepage":null,"size":2626,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/chef/pulls/126"},"html":{"href":"https://github.com/Metaswitch/chef/pull/126"},"issue":{"href":"https://api.github.com/repos/Metaswitch/chef/issues/126"},"comments":{"href":"https://api.github.com/repos/Metaswitch/chef/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/chef/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/chef/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/chef/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/chef/statuses/0735e82b3c136d68ccb0ef73fdcc316a047dad32"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mirw","id":2963879,"avatar_url":"https://avatars.githubusercontent.com/u/2963879?","gravatar_id":"ff79fd61cea85f47f31eb8da854a3315","url":"https://api.github.com/users/mirw","html_url":"https://github.com/mirw","followers_url":"https://api.github.com/users/mirw/followers","following_url":"https://api.github.com/users/mirw/following{/other_user}","gists_url":"https://api.github.com/users/mirw/gists{/gist_id}","starred_url":"https://api.github.com/users/mirw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirw/subscriptions","organizations_url":"https://api.github.com/users/mirw/orgs","repos_url":"https://api.github.com/users/mirw/repos","events_url":"https://api.github.com/users/mirw/events{/privacy}","received_events_url":"https://api.github.com/users/mirw/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"commits":2,"additions":11,"deletions":44,"changed_files":6}}