GitHub PullRequestReviewCommentEvent at 2014-10-03 11:02:20
Repository: LicensesDialog
Actor: hameno
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/PSDev/LicensesDialog/pulls/comments/18389731","id":18389731,"diff_hunk":"@@ -21,6 +21,9 @@\n \n public class GnuGeneralPublicLicense20 extends License {\n \n+    private String cachedSummaryText = null;","path":"library/src/main/java/de/psdev/licensesdialog/licenses/GnuGeneralPublicLicense20.java","position":4,"original_position":4,"commit_id":"ddb0e51f38287f931002dad820cc9823ec10eb44","original_commit_id":"ddb0e51f38287f931002dad820cc9823ec10eb44","user":{"login":"hameno","id":365084,"avatar_url":"https://avatars.githubusercontent.com/u/365084?v=2","gravatar_id":"","url":"https://api.github.com/users/hameno","html_url":"https://github.com/hameno","followers_url":"https://api.github.com/users/hameno/followers","following_url":"https://api.github.com/users/hameno/following{/other_user}","gists_url":"https://api.github.com/users/hameno/gists{/gist_id}","starred_url":"https://api.github.com/users/hameno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hameno/subscriptions","organizations_url":"https://api.github.com/users/hameno/orgs","repos_url":"https://api.github.com/users/hameno/repos","events_url":"https://api.github.com/users/hameno/events{/privacy}","received_events_url":"https://api.github.com/users/hameno/received_events","type":"User","site_admin":false},"body":"Please use the naming convention used in this project (m-prefixed)","created_at":"2014-10-03T11:02:20Z","updated_at":"2014-10-03T11:02:20Z","html_url":"https://github.com/PSDev/LicensesDialog/pull/35#discussion_r18389731","pull_request_url":"https://api.github.com/repos/PSDev/LicensesDialog/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/PSDev/LicensesDialog/pulls/comments/18389731"},"html":{"href":"https://github.com/PSDev/LicensesDialog/pull/35#discussion_r18389731"},"pull_request":{"href":"https://api.github.com/repos/PSDev/LicensesDialog/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/PSDev/LicensesDialog/pulls/35","id":22197242,"html_url":"https://github.com/PSDev/LicensesDialog/pull/35","diff_url":"https://github.com/PSDev/LicensesDialog/pull/35.diff","patch_url":"https://github.com/PSDev/LicensesDialog/pull/35.patch","issue_url":"https://api.github.com/repos/PSDev/LicensesDialog/issues/35","number":35,"state":"open","locked":false,"title":"Using System.getProperty(\"line.separator\") instead of '\\n' and adding pre-caching of licenses text","user":{"login":"ngdelamo","id":4471465,"avatar_url":"https://avatars.githubusercontent.com/u/4471465?v=2","gravatar_id":"","url":"https://api.github.com/users/ngdelamo","html_url":"https://github.com/ngdelamo","followers_url":"https://api.github.com/users/ngdelamo/followers","following_url":"https://api.github.com/users/ngdelamo/following{/other_user}","gists_url":"https://api.github.com/users/ngdelamo/gists{/gist_id}","starred_url":"https://api.github.com/users/ngdelamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngdelamo/subscriptions","organizations_url":"https://api.github.com/users/ngdelamo/orgs","repos_url":"https://api.github.com/users/ngdelamo/repos","events_url":"https://api.github.com/users/ngdelamo/events{/privacy}","received_events_url":"https://api.github.com/users/ngdelamo/received_events","type":"User","site_admin":false},"body":"In some Android versions using '\\n' does not lead to a new line on TextViews. Instead, the standard System.getProperty(\"line.separator\") must be used. This was affecting licenses text, since the method for reading them was adding '\\n' characters that were not being shown in the licenses dialog (see the following image from a screenshot on a Nexus 5 running Android 4.4.4)\r\n![licenses_dialgo_line_break](https://cloud.githubusercontent.com/assets/4471465/4504754/cac9d91c-4aea-11e4-8576-30f8cc7fa350.jpg)\r\n\r\nAlso, when a license's text was requested, either by using 'getSummaryText' or 'getFullText', a fresh new read from the raw resource was performed. This can slow down the dialog when multiple instances of the same license are used, which is quite common (most licenses on our projects are apache 2.0). I added some changes to read the raw resource once and store the resulting String, so subsequent calls to the previous methods would return the cached String.","created_at":"2014-10-03T10:56:05Z","updated_at":"2014-10-03T11:02:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6db2705ed55699047a590eefb31692f3dfeb815","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PSDev/LicensesDialog/pulls/35/commits","review_comments_url":"https://api.github.com/repos/PSDev/LicensesDialog/pulls/35/comments","review_comment_url":"https://api.github.com/repos/PSDev/LicensesDialog/pulls/comments/{number}","comments_url":"https://api.github.com/repos/PSDev/LicensesDialog/issues/35/comments","statuses_url":"https://api.github.com/repos/PSDev/LicensesDialog/statuses/ddb0e51f38287f931002dad820cc9823ec10eb44","head":{"label":"ngdelamo:master","ref":"master","sha":"ddb0e51f38287f931002dad820cc9823ec10eb44","user":{"login":"ngdelamo","id":4471465,"avatar_url":"https://avatars.githubusercontent.com/u/4471465?v=2","gravatar_id":"","url":"https://api.github.com/users/ngdelamo","html_url":"https://github.com/ngdelamo","followers_url":"https://api.github.com/users/ngdelamo/followers","following_url":"https://api.github.com/users/ngdelamo/following{/other_user}","gists_url":"https://api.github.com/users/ngdelamo/gists{/gist_id}","starred_url":"https://api.github.com/users/ngdelamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngdelamo/subscriptions","organizations_url":"https://api.github.com/users/ngdelamo/orgs","repos_url":"https://api.github.com/users/ngdelamo/repos","events_url":"https://api.github.com/users/ngdelamo/events{/privacy}","received_events_url":"https://api.github.com/users/ngdelamo/received_events","type":"User","site_admin":false},"repo":{"id":24753668,"name":"LicensesDialog","full_name":"ngdelamo/LicensesDialog","owner":{"login":"ngdelamo","id":4471465,"avatar_url":"https://avatars.githubusercontent.com/u/4471465?v=2","gravatar_id":"","url":"https://api.github.com/users/ngdelamo","html_url":"https://github.com/ngdelamo","followers_url":"https://api.github.com/users/ngdelamo/followers","following_url":"https://api.github.com/users/ngdelamo/following{/other_user}","gists_url":"https://api.github.com/users/ngdelamo/gists{/gist_id}","starred_url":"https://api.github.com/users/ngdelamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngdelamo/subscriptions","organizations_url":"https://api.github.com/users/ngdelamo/orgs","repos_url":"https://api.github.com/users/ngdelamo/repos","events_url":"https://api.github.com/users/ngdelamo/events{/privacy}","received_events_url":"https://api.github.com/users/ngdelamo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngdelamo/LicensesDialog","description":"LicensesDialog is an open source library to display licenses of third-party libraries in an Android app.","fork":true,"url":"https://api.github.com/repos/ngdelamo/LicensesDialog","forks_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/forks","keys_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/teams","hooks_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/hooks","issue_events_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/issues/events{/number}","events_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/events","assignees_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/assignees{/user}","branches_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/branches{/branch}","tags_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/tags","blobs_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/statuses/{sha}","languages_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/languages","stargazers_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/stargazers","contributors_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/contributors","subscribers_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/subscribers","subscription_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/subscription","commits_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/issues/comments/{number}","contents_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/contents/{+path}","compare_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/merges","archive_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/downloads","issues_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/issues{/number}","pulls_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/pulls{/number}","milestones_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/milestones{/number}","notifications_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/labels{/name}","releases_url":"https://api.github.com/repos/ngdelamo/LicensesDialog/releases{/id}","created_at":"2014-10-03T09:48:43Z","updated_at":"2014-10-03T09:58:10Z","pushed_at":"2014-10-03T10:12:30Z","git_url":"git://github.com/ngdelamo/LicensesDialog.git","ssh_url":"git@github.com:ngdelamo/LicensesDialog.git","clone_url":"https://github.com/ngdelamo/LicensesDialog.git","svn_url":"https://github.com/ngdelamo/LicensesDialog","homepage":"http://psdev.de/LicensesDialog","size":1510,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PSDev:master","ref":"master","sha":"c8f5075b959db700f998acd9c7857e2f93d7ff32","user":{"login":"PSDev","id":1948996,"avatar_url":"https://avatars.githubusercontent.com/u/1948996?v=2","gravatar_id":"","url":"https://api.github.com/users/PSDev","html_url":"https://github.com/PSDev","followers_url":"https://api.github.com/users/PSDev/followers","following_url":"https://api.github.com/users/PSDev/following{/other_user}","gists_url":"https://api.github.com/users/PSDev/gists{/gist_id}","starred_url":"https://api.github.com/users/PSDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PSDev/subscriptions","organizations_url":"https://api.github.com/users/PSDev/orgs","repos_url":"https://api.github.com/users/PSDev/repos","events_url":"https://api.github.com/users/PSDev/events{/privacy}","received_events_url":"https://api.github.com/users/PSDev/received_events","type":"Organization","site_admin":false},"repo":{"id":9040104,"name":"LicensesDialog","full_name":"PSDev/LicensesDialog","owner":{"login":"PSDev","id":1948996,"avatar_url":"https://avatars.githubusercontent.com/u/1948996?v=2","gravatar_id":"","url":"https://api.github.com/users/PSDev","html_url":"https://github.com/PSDev","followers_url":"https://api.github.com/users/PSDev/followers","following_url":"https://api.github.com/users/PSDev/following{/other_user}","gists_url":"https://api.github.com/users/PSDev/gists{/gist_id}","starred_url":"https://api.github.com/users/PSDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PSDev/subscriptions","organizations_url":"https://api.github.com/users/PSDev/orgs","repos_url":"https://api.github.com/users/PSDev/repos","events_url":"https://api.github.com/users/PSDev/events{/privacy}","received_events_url":"https://api.github.com/users/PSDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PSDev/LicensesDialog","description":"LicensesDialog is an open source library to display licenses of third-party libraries in an Android app.","fork":false,"url":"https://api.github.com/repos/PSDev/LicensesDialog","forks_url":"https://api.github.com/repos/PSDev/LicensesDialog/forks","keys_url":"https://api.github.com/repos/PSDev/LicensesDialog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PSDev/LicensesDialog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PSDev/LicensesDialog/teams","hooks_url":"https://api.github.com/repos/PSDev/LicensesDialog/hooks","issue_events_url":"https://api.github.com/repos/PSDev/LicensesDialog/issues/events{/number}","events_url":"https://api.github.com/repos/PSDev/LicensesDialog/events","assignees_url":"https://api.github.com/repos/PSDev/LicensesDialog/assignees{/user}","branches_url":"https://api.github.com/repos/PSDev/LicensesDialog/branches{/branch}","tags_url":"https://api.github.com/repos/PSDev/LicensesDialog/tags","blobs_url":"https://api.github.com/repos/PSDev/LicensesDialog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PSDev/LicensesDialog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PSDev/LicensesDialog/git/refs{/sha}","trees_url":"https://api.github.com/repos/PSDev/LicensesDialog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PSDev/LicensesDialog/statuses/{sha}","languages_url":"https://api.github.com/repos/PSDev/LicensesDialog/languages","stargazers_url":"https://api.github.com/repos/PSDev/LicensesDialog/stargazers","contributors_url":"https://api.github.com/repos/PSDev/LicensesDialog/contributors","subscribers_url":"https://api.github.com/repos/PSDev/LicensesDialog/subscribers","subscription_url":"https://api.github.com/repos/PSDev/LicensesDialog/subscription","commits_url":"https://api.github.com/repos/PSDev/LicensesDialog/commits{/sha}","git_commits_url":"https://api.github.com/repos/PSDev/LicensesDialog/git/commits{/sha}","comments_url":"https://api.github.com/repos/PSDev/LicensesDialog/comments{/number}","issue_comment_url":"https://api.github.com/repos/PSDev/LicensesDialog/issues/comments/{number}","contents_url":"https://api.github.com/repos/PSDev/LicensesDialog/contents/{+path}","compare_url":"https://api.github.com/repos/PSDev/LicensesDialog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PSDev/LicensesDialog/merges","archive_url":"https://api.github.com/repos/PSDev/LicensesDialog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PSDev/LicensesDialog/downloads","issues_url":"https://api.github.com/repos/PSDev/LicensesDialog/issues{/number}","pulls_url":"https://api.github.com/repos/PSDev/LicensesDialog/pulls{/number}","milestones_url":"https://api.github.com/repos/PSDev/LicensesDialog/milestones{/number}","notifications_url":"https://api.github.com/repos/PSDev/LicensesDialog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PSDev/LicensesDialog/labels{/name}","releases_url":"https://api.github.com/repos/PSDev/LicensesDialog/releases{/id}","created_at":"2013-03-26T20:50:31Z","updated_at":"2014-10-02T15:34:58Z","pushed_at":"2014-09-28T10:14:19Z","git_url":"git://github.com/PSDev/LicensesDialog.git","ssh_url":"git@github.com:PSDev/LicensesDialog.git","clone_url":"https://github.com/PSDev/LicensesDialog.git","svn_url":"https://github.com/PSDev/LicensesDialog","homepage":"http://psdev.de/LicensesDialog","size":1510,"stargazers_count":139,"watchers_count":139,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":37,"mirror_url":null,"open_issues_count":2,"forks":37,"open_issues":2,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PSDev/LicensesDialog/pulls/35"},"html":{"href":"https://github.com/PSDev/LicensesDialog/pull/35"},"issue":{"href":"https://api.github.com/repos/PSDev/LicensesDialog/issues/35"},"comments":{"href":"https://api.github.com/repos/PSDev/LicensesDialog/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/PSDev/LicensesDialog/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/PSDev/LicensesDialog/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/PSDev/LicensesDialog/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/PSDev/LicensesDialog/statuses/ddb0e51f38287f931002dad820cc9823ec10eb44"}}}}