GitHub PullRequestReviewCommentEvent at 2014-03-24 18:46:43
Repository: WAVED
Actor: seanblue
Payload: {"comment":{"url":"https://api.github.com/repos/KSHSK/WAVED/pulls/comments/10899546","id":10899546,"diff_hunk":"@@ -310,7 +310,21 @@ define([\n     };\n \n     ProjectViewModel.prototype.refreshWorkspace = function() {\n-        //TODO\n+        var i;\n+        var j;\n+        for (i = 0; i < self._components.length; i++) {\n+            var properties = self._components[i].viewModel.properties;\n+            for (j = 0; j < properties.length; j++) {\n+                properties[j].value = properties[j].originalValue;\n+            }\n+        }\n+\n+        // Reapply automatically applied actions.\n+        for (i = 0; i < self._actions.length; i++) {","path":"Source/models/ProjectViewModel.js","position":15,"original_position":15,"commit_id":"5cff4eb81ea3a4fc89322efe23cbf915adb55cde","original_commit_id":"5cff4eb81ea3a4fc89322efe23cbf915adb55cde","user":{"login":"seanblue","id":5884067,"avatar_url":"https://avatars.githubusercontent.com/u/5884067?","gravatar_id":"56a2fb3bf7fa47d27a2470273280aacf","url":"https://api.github.com/users/seanblue","html_url":"https://github.com/seanblue","followers_url":"https://api.github.com/users/seanblue/followers","following_url":"https://api.github.com/users/seanblue/following{/other_user}","gists_url":"https://api.github.com/users/seanblue/gists{/gist_id}","starred_url":"https://api.github.com/users/seanblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanblue/subscriptions","organizations_url":"https://api.github.com/users/seanblue/orgs","repos_url":"https://api.github.com/users/seanblue/repos","events_url":"https://api.github.com/users/seanblue/events{/privacy}","received_events_url":"https://api.github.com/users/seanblue/received_events","type":"User","site_admin":false},"body":"I've never heard the term hoisted, but I think it looks cleaner and is safer when it's a new variable `i` for each loop.","created_at":"2014-03-24T18:46:43Z","updated_at":"2014-03-24T18:46:43Z","html_url":"https://github.com/KSHSK/WAVED/pull/148#discussion_r10899546","pull_request_url":"https://api.github.com/repos/KSHSK/WAVED/pulls/148","_links":{"self":{"href":"https://api.github.com/repos/KSHSK/WAVED/pulls/comments/10899546"},"html":{"href":"https://github.com/KSHSK/WAVED/pull/148#discussion_r10899546"},"pull_request":{"href":"https://api.github.com/repos/KSHSK/WAVED/pulls/148"}}}}