GitHub PullRequestReviewCommentEvent at 2014-10-27 17:33:37
Repository: repose
Actor: dkowis
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/repose/pulls/comments/19421782","id":19421782,"diff_hunk":"@@ -1,9 +1,8 @@\n <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n <web-app version=\"3.0\" xmlns=\"http://java.sun.com/xml/ns/javaee\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd\">","path":"repose-aggregator/core/web-application/src/main/webapp/WEB-INF/web.xml","position":2,"original_position":2,"commit_id":"0dba6189790772219439ca3bbdbb9ac2723f88c2","original_commit_id":"0dba6189790772219439ca3bbdbb9ac2723f88c2","user":{"login":"dkowis","id":28048,"avatar_url":"https://avatars.githubusercontent.com/u/28048?v=2","gravatar_id":"","url":"https://api.github.com/users/dkowis","html_url":"https://github.com/dkowis","followers_url":"https://api.github.com/users/dkowis/followers","following_url":"https://api.github.com/users/dkowis/following{/other_user}","gists_url":"https://api.github.com/users/dkowis/gists{/gist_id}","starred_url":"https://api.github.com/users/dkowis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkowis/subscriptions","organizations_url":"https://api.github.com/users/dkowis/orgs","repos_url":"https://api.github.com/users/dkowis/repos","events_url":"https://api.github.com/users/dkowis/events{/privacy}","received_events_url":"https://api.github.com/users/dkowis/received_events","type":"User","site_admin":false},"body":"Web-xml needs to be completely empty I think. If we have this, then they will show up as context-params, whcih I think will be handled by spring properties, which would invalidate our checks in core....","created_at":"2014-10-27T17:33:37Z","updated_at":"2014-10-27T17:33:37Z","html_url":"https://github.com/rackerlabs/repose/pull/1150#discussion_r19421782","pull_request_url":"https://api.github.com/repos/rackerlabs/repose/pulls/1150","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/repose/pulls/comments/19421782"},"html":{"href":"https://github.com/rackerlabs/repose/pull/1150#discussion_r19421782"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/repose/pulls/1150"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/repose/pulls/1150","id":23400482,"html_url":"https://github.com/rackerlabs/repose/pull/1150","diff_url":"https://github.com/rackerlabs/repose/pull/1150.diff","patch_url":"https://github.com/rackerlabs/repose/pull/1150.patch","issue_url":"https://api.github.com/repos/rackerlabs/repose/issues/1150","number":1150,"state":"open","locked":false,"title":"Rep 1240 war build","user":{"login":"tylerroyal","id":3344417,"avatar_url":"https://avatars.githubusercontent.com/u/3344417?v=2","gravatar_id":"","url":"https://api.github.com/users/tylerroyal","html_url":"https://github.com/tylerroyal","followers_url":"https://api.github.com/users/tylerroyal/followers","following_url":"https://api.github.com/users/tylerroyal/following{/other_user}","gists_url":"https://api.github.com/users/tylerroyal/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerroyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerroyal/subscriptions","organizations_url":"https://api.github.com/users/tylerroyal/orgs","repos_url":"https://api.github.com/users/tylerroyal/repos","events_url":"https://api.github.com/users/tylerroyal/events{/privacy}","received_events_url":"https://api.github.com/users/tylerroyal/received_events","type":"User","site_admin":false},"body":"Changing the war build to use a WebApplicationInitializer","created_at":"2014-10-27T17:29:26Z","updated_at":"2014-10-27T17:33:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6aef65a351fa50956e1ba7d9f870a85fad87f075","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/repose/pulls/1150/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/repose/pulls/1150/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/repose/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rackerlabs/repose/issues/1150/comments","statuses_url":"https://api.github.com/repos/rackerlabs/repose/statuses/0dba6189790772219439ca3bbdbb9ac2723f88c2","head":{"label":"rackerlabs:REP-1240_War-Build","ref":"REP-1240_War-Build","sha":"0dba6189790772219439ca3bbdbb9ac2723f88c2","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=2","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1981821,"name":"repose","full_name":"rackerlabs/repose","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=2","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/repose","description":"The powerful, programmable, API Middleware Platform","fork":false,"url":"https://api.github.com/repos/rackerlabs/repose","forks_url":"https://api.github.com/repos/rackerlabs/repose/forks","keys_url":"https://api.github.com/repos/rackerlabs/repose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/repose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/repose/teams","hooks_url":"https://api.github.com/repos/rackerlabs/repose/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/repose/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/repose/events","assignees_url":"https://api.github.com/repos/rackerlabs/repose/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/repose/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/repose/tags","blobs_url":"https://api.github.com/repos/rackerlabs/repose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/repose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/repose/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/repose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/repose/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/repose/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/repose/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/repose/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/repose/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/repose/subscription","commits_url":"https://api.github.com/repos/rackerlabs/repose/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/repose/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/repose/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/repose/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackerlabs/repose/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/repose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/repose/merges","archive_url":"https://api.github.com/repos/rackerlabs/repose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/repose/downloads","issues_url":"https://api.github.com/repos/rackerlabs/repose/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/repose/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/repose/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/repose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/repose/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/repose/releases{/id}","created_at":"2011-07-01T04:39:34Z","updated_at":"2014-10-23T18:44:13Z","pushed_at":"2014-10-27T17:27:43Z","git_url":"git://github.com/rackerlabs/repose.git","ssh_url":"git@github.com:rackerlabs/repose.git","clone_url":"https://github.com/rackerlabs/repose.git","svn_url":"https://github.com/rackerlabs/repose","homepage":"http://www.openrepose.org/","size":117229,"stargazers_count":166,"watchers_count":166,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":50,"mirror_url":null,"open_issues_count":8,"forks":50,"open_issues":8,"watchers":166,"default_branch":"master"}},"base":{"label":"rackerlabs:REP-1158_core_spring","ref":"REP-1158_core_spring","sha":"ff9e777cf91bf8a60bf9e8178c86f4a2d97efb28","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=2","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1981821,"name":"repose","full_name":"rackerlabs/repose","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=2","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/repose","description":"The powerful, programmable, API Middleware Platform","fork":false,"url":"https://api.github.com/repos/rackerlabs/repose","forks_url":"https://api.github.com/repos/rackerlabs/repose/forks","keys_url":"https://api.github.com/repos/rackerlabs/repose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/repose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/repose/teams","hooks_url":"https://api.github.com/repos/rackerlabs/repose/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/repose/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/repose/events","assignees_url":"https://api.github.com/repos/rackerlabs/repose/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/repose/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/repose/tags","blobs_url":"https://api.github.com/repos/rackerlabs/repose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/repose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/repose/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/repose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/repose/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/repose/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/repose/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/repose/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/repose/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/repose/subscription","commits_url":"https://api.github.com/repos/rackerlabs/repose/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/repose/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/repose/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/repose/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackerlabs/repose/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/repose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/repose/merges","archive_url":"https://api.github.com/repos/rackerlabs/repose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/repose/downloads","issues_url":"https://api.github.com/repos/rackerlabs/repose/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/repose/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/repose/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/repose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/repose/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/repose/releases{/id}","created_at":"2011-07-01T04:39:34Z","updated_at":"2014-10-23T18:44:13Z","pushed_at":"2014-10-27T17:27:43Z","git_url":"git://github.com/rackerlabs/repose.git","ssh_url":"git@github.com:rackerlabs/repose.git","clone_url":"https://github.com/rackerlabs/repose.git","svn_url":"https://github.com/rackerlabs/repose","homepage":"http://www.openrepose.org/","size":117229,"stargazers_count":166,"watchers_count":166,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":50,"mirror_url":null,"open_issues_count":8,"forks":50,"open_issues":8,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/repose/pulls/1150"},"html":{"href":"https://github.com/rackerlabs/repose/pull/1150"},"issue":{"href":"https://api.github.com/repos/rackerlabs/repose/issues/1150"},"comments":{"href":"https://api.github.com/repos/rackerlabs/repose/issues/1150/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/repose/pulls/1150/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/repose/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/repose/pulls/1150/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/repose/statuses/0dba6189790772219439ca3bbdbb9ac2723f88c2"}}}}