GitHub PullRequestReviewCommentEvent at 2014-09-10 07:40:21
Repository: crosswalk
Actor: tiwanek
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/17346835","id":17346835,"diff_hunk":"@@ -101,22 +101,69 @@ bool ApplicationStorageImpl::GetInstalledApplicationIDs(\n }\n \n bool ApplicationStorageImpl::AddApplication(const ApplicationData* application,\n-                                            const base::Time& install_time) {\n-  return true;\n+    const base::Time& install_time) {\n+  return SetPermissions(application->ID(),\n+                        application->Path(),\n+                        application->permission_map_);\n }\n \n bool ApplicationStorageImpl::UpdateApplication(\n     ApplicationData* application, const base::Time& install_time) {\n-  return true;\n+  return UpdatePermissions(application->ID(),\n+                           application->Path(),\n+                           application->permission_map_);","path":"application/common/application_storage_impl_tizen.cc","position":17,"original_position":17,"commit_id":"dff5e184b2a932f300a69b01e06d21fd52dbee84","original_commit_id":"dff5e184b2a932f300a69b01e06d21fd52dbee84","user":{"login":"tiwanek","id":5700502,"avatar_url":"https://avatars.githubusercontent.com/u/5700502?v=2","gravatar_id":"312dd0d8273e5dcfcbc5b229fd3009e6","url":"https://api.github.com/users/tiwanek","html_url":"https://github.com/tiwanek","followers_url":"https://api.github.com/users/tiwanek/followers","following_url":"https://api.github.com/users/tiwanek/following{/other_user}","gists_url":"https://api.github.com/users/tiwanek/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanek/subscriptions","organizations_url":"https://api.github.com/users/tiwanek/orgs","repos_url":"https://api.github.com/users/tiwanek/repos","events_url":"https://api.github.com/users/tiwanek/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanek/received_events","type":"User","site_admin":false},"body":"Friend declaration. This is done same way in application_storage_impl.cc","created_at":"2014-09-10T07:40:21Z","updated_at":"2014-09-10T07:40:21Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/2397#discussion_r17346835","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2397","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/17346835"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/2397#discussion_r17346835"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2397"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2397","id":20811758,"html_url":"https://github.com/crosswalk-project/crosswalk/pull/2397","diff_url":"https://github.com/crosswalk-project/crosswalk/pull/2397.diff","patch_url":"https://github.com/crosswalk-project/crosswalk/pull/2397.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2397","number":2397,"state":"open","locked":false,"title":"[Tizen] Application Security","user":{"login":"tiwanek","id":5700502,"avatar_url":"https://avatars.githubusercontent.com/u/5700502?v=2","gravatar_id":"312dd0d8273e5dcfcbc5b229fd3009e6","url":"https://api.github.com/users/tiwanek","html_url":"https://github.com/tiwanek","followers_url":"https://api.github.com/users/tiwanek/followers","following_url":"https://api.github.com/users/tiwanek/following{/other_user}","gists_url":"https://api.github.com/users/tiwanek/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanek/subscriptions","organizations_url":"https://api.github.com/users/tiwanek/orgs","repos_url":"https://api.github.com/users/tiwanek/repos","events_url":"https://api.github.com/users/tiwanek/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanek/received_events","type":"User","site_admin":false},"body":"Implementation of abstraction of security for installation process and EP.\r\nFor tizen installer will call security-manager API set correct\r\nprivleges for apps.\r\n\r\nBUG=XWALK-1731\r\n\r\n[Verification]\r\n  rpm -i security-manager-0.1.0-2.2.armv7l.rpm \\\r\n         libcynara-admin-0.2.2-10.1.armv7l.rpm \\\r\n         cynara-0.2.2-10.1.armv7l.rpm \\\r\n         libsecurity-manager-client-0.1.0-2.2.armv7l.rpm\r\n  systemctl start cynara\r\n  systemctl start security-manager\r\n  systemctl enable security-manager\r\n  (install and run app)","created_at":"2014-09-05T14:38:20Z","updated_at":"2014-09-10T07:40:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a52337058ae54b46a33c71502c9c7d2cd45a6a1c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2397/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2397/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2397/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/dff5e184b2a932f300a69b01e06d21fd52dbee84","head":{"label":"tiwanek:XWALK-1731-2","ref":"XWALK-1731-2","sha":"dff5e184b2a932f300a69b01e06d21fd52dbee84","user":{"login":"tiwanek","id":5700502,"avatar_url":"https://avatars.githubusercontent.com/u/5700502?v=2","gravatar_id":"312dd0d8273e5dcfcbc5b229fd3009e6","url":"https://api.github.com/users/tiwanek","html_url":"https://github.com/tiwanek","followers_url":"https://api.github.com/users/tiwanek/followers","following_url":"https://api.github.com/users/tiwanek/following{/other_user}","gists_url":"https://api.github.com/users/tiwanek/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanek/subscriptions","organizations_url":"https://api.github.com/users/tiwanek/orgs","repos_url":"https://api.github.com/users/tiwanek/repos","events_url":"https://api.github.com/users/tiwanek/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanek/received_events","type":"User","site_admin":false},"repo":{"id":19305661,"name":"crosswalk","full_name":"tiwanek/crosswalk","owner":{"login":"tiwanek","id":5700502,"avatar_url":"https://avatars.githubusercontent.com/u/5700502?v=2","gravatar_id":"312dd0d8273e5dcfcbc5b229fd3009e6","url":"https://api.github.com/users/tiwanek","html_url":"https://github.com/tiwanek","followers_url":"https://api.github.com/users/tiwanek/followers","following_url":"https://api.github.com/users/tiwanek/following{/other_user}","gists_url":"https://api.github.com/users/tiwanek/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanek/subscriptions","organizations_url":"https://api.github.com/users/tiwanek/orgs","repos_url":"https://api.github.com/users/tiwanek/repos","events_url":"https://api.github.com/users/tiwanek/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiwanek/crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/tiwanek/crosswalk","forks_url":"https://api.github.com/repos/tiwanek/crosswalk/forks","keys_url":"https://api.github.com/repos/tiwanek/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiwanek/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiwanek/crosswalk/teams","hooks_url":"https://api.github.com/repos/tiwanek/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/tiwanek/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/tiwanek/crosswalk/events","assignees_url":"https://api.github.com/repos/tiwanek/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/tiwanek/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/tiwanek/crosswalk/tags","blobs_url":"https://api.github.com/repos/tiwanek/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiwanek/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiwanek/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiwanek/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiwanek/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/tiwanek/crosswalk/languages","stargazers_url":"https://api.github.com/repos/tiwanek/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/tiwanek/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/tiwanek/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/tiwanek/crosswalk/subscription","commits_url":"https://api.github.com/repos/tiwanek/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiwanek/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiwanek/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiwanek/crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/tiwanek/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/tiwanek/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiwanek/crosswalk/merges","archive_url":"https://api.github.com/repos/tiwanek/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiwanek/crosswalk/downloads","issues_url":"https://api.github.com/repos/tiwanek/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/tiwanek/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/tiwanek/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/tiwanek/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiwanek/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/tiwanek/crosswalk/releases{/id}","created_at":"2014-04-30T07:54:30Z","updated_at":"2014-09-01T13:20:14Z","pushed_at":"2014-09-10T06:26:47Z","git_url":"git://github.com/tiwanek/crosswalk.git","ssh_url":"git@github.com:tiwanek/crosswalk.git","clone_url":"https://github.com/tiwanek/crosswalk.git","svn_url":"https://github.com/tiwanek/crosswalk","homepage":"","size":10244,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"c94e6382e9338547e48d70533e6f9c025307ccd5","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=2","gravatar_id":"92669bf554412548daa0c4b8d74b861e","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":9207280,"name":"crosswalk","full_name":"crosswalk-project/crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=2","gravatar_id":"92669bf554412548daa0c4b8d74b861e","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk/releases{/id}","created_at":"2013-04-03T23:30:12Z","updated_at":"2014-09-09T04:09:30Z","pushed_at":"2014-09-10T07:39:16Z","git_url":"git://github.com/crosswalk-project/crosswalk.git","ssh_url":"git@github.com:crosswalk-project/crosswalk.git","clone_url":"https://github.com/crosswalk-project/crosswalk.git","svn_url":"https://github.com/crosswalk-project/crosswalk","homepage":"https://crosswalk-project.org/","size":155585,"stargazers_count":329,"watchers_count":329,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":125,"mirror_url":null,"open_issues_count":114,"forks":125,"open_issues":114,"watchers":329,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2397"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/2397"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2397"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2397/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2397/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2397/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/dff5e184b2a932f300a69b01e06d21fd52dbee84"}}}}