GitHub PullRequestReviewCommentEvent at 2014-07-10 06:56:21
Repository: docker
Actor: LK4D4
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dotcloud/docker/pulls/comments/14751715","id":14751715,"diff_hunk":"@@ -798,7 +798,7 @@ func (b *buildFile) Build(context io.Reader) (string, error) {\n \t\tstepN      = 0\n \t)\n \tfor _, line := range strings.Split(dockerfile, \"\\n\") {\n-\t\tline = strings.Trim(strings.Replace(line, \"\\t\", \" \", -1), \" \\t\\r\\n\")\n+\t\tline = strings.Trim(line, \" \\t\\r\\n\")","path":"server/buildfile.go","position":5,"original_position":5,"commit_id":"cdc168018b964ad768fef91a59aaf18ca832b1ea","original_commit_id":"cdc168018b964ad768fef91a59aaf18ca832b1ea","user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?","gravatar_id":"b76a8f4849829643862f7c5dd89cb11e","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"body":"Yup :) Let's use `TrimSpace` everywhere :cat2: ","created_at":"2014-07-10T06:56:21Z","updated_at":"2014-07-10T06:56:21Z","html_url":"https://github.com/dotcloud/docker/pull/6951#discussion_r14751715","pull_request_url":"https://api.github.com/repos/dotcloud/docker/pulls/6951","_links":{"self":{"href":"https://api.github.com/repos/dotcloud/docker/pulls/comments/14751715"},"html":{"href":"https://github.com/dotcloud/docker/pull/6951#discussion_r14751715"},"pull_request":{"href":"https://api.github.com/repos/dotcloud/docker/pulls/6951"}}},"pull_request":{"url":"https://api.github.com/repos/dotcloud/docker/pulls/6951","id":18202805,"html_url":"https://github.com/dotcloud/docker/pull/6951","diff_url":"https://github.com/dotcloud/docker/pull/6951.diff","patch_url":"https://github.com/dotcloud/docker/pull/6951.patch","issue_url":"https://api.github.com/repos/dotcloud/docker/issues/6951","number":6951,"state":"open","title":"Remove transliteration of tabs to spaces in literal commands. ","user":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?","gravatar_id":"1b641a79b2717f2d582ad455b40d5b89","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"body":"Tabs and spaces are still transliterated for line start/end and command start/end.\r\n\r\ncloses #2315\r\n\r\n","created_at":"2014-07-10T06:31:45Z","updated_at":"2014-07-10T06:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af34d77884ee8da7b48f4c01d935c74860b55a51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotcloud/docker/pulls/6951/commits","review_comments_url":"https://api.github.com/repos/dotcloud/docker/pulls/6951/comments","review_comment_url":"https://api.github.com/repos/dotcloud/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dotcloud/docker/issues/6951/comments","statuses_url":"https://api.github.com/repos/dotcloud/docker/statuses/cdc168018b964ad768fef91a59aaf18ca832b1ea","head":{"label":"erikh:2315-dont-kill-tabs","ref":"2315-dont-kill-tabs","sha":"cdc168018b964ad768fef91a59aaf18ca832b1ea","user":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?","gravatar_id":"1b641a79b2717f2d582ad455b40d5b89","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"repo":{"id":17471699,"name":"docker","full_name":"erikh/docker","owner":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?","gravatar_id":"1b641a79b2717f2d582ad455b40d5b89","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikh/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/erikh/docker","forks_url":"https://api.github.com/repos/erikh/docker/forks","keys_url":"https://api.github.com/repos/erikh/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikh/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikh/docker/teams","hooks_url":"https://api.github.com/repos/erikh/docker/hooks","issue_events_url":"https://api.github.com/repos/erikh/docker/issues/events{/number}","events_url":"https://api.github.com/repos/erikh/docker/events","assignees_url":"https://api.github.com/repos/erikh/docker/assignees{/user}","branches_url":"https://api.github.com/repos/erikh/docker/branches{/branch}","tags_url":"https://api.github.com/repos/erikh/docker/tags","blobs_url":"https://api.github.com/repos/erikh/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikh/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikh/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikh/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikh/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/erikh/docker/languages","stargazers_url":"https://api.github.com/repos/erikh/docker/stargazers","contributors_url":"https://api.github.com/repos/erikh/docker/contributors","subscribers_url":"https://api.github.com/repos/erikh/docker/subscribers","subscription_url":"https://api.github.com/repos/erikh/docker/subscription","commits_url":"https://api.github.com/repos/erikh/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikh/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikh/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikh/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/erikh/docker/contents/{+path}","compare_url":"https://api.github.com/repos/erikh/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikh/docker/merges","archive_url":"https://api.github.com/repos/erikh/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikh/docker/downloads","issues_url":"https://api.github.com/repos/erikh/docker/issues{/number}","pulls_url":"https://api.github.com/repos/erikh/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/erikh/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/erikh/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikh/docker/labels{/name}","releases_url":"https://api.github.com/repos/erikh/docker/releases{/id}","created_at":"2014-03-06T08:54:07Z","updated_at":"2014-07-03T07:21:47Z","pushed_at":"2014-07-10T06:22:56Z","git_url":"git://github.com/erikh/docker.git","ssh_url":"git@github.com:erikh/docker.git","clone_url":"https://github.com/erikh/docker.git","svn_url":"https://github.com/erikh/docker","homepage":"http://www.docker.io","size":28954,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotcloud:master","ref":"master","sha":"439d7ea701b44724e1e02ff67a220fab7fa9bd1f","user":{"login":"dotcloud","id":171922,"avatar_url":"https://avatars.githubusercontent.com/u/171922?","gravatar_id":"d2fbb59e6c8b80a26e48b06ea30d53fd","url":"https://api.github.com/users/dotcloud","html_url":"https://github.com/dotcloud","followers_url":"https://api.github.com/users/dotcloud/followers","following_url":"https://api.github.com/users/dotcloud/following{/other_user}","gists_url":"https://api.github.com/users/dotcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/dotcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotcloud/subscriptions","organizations_url":"https://api.github.com/users/dotcloud/orgs","repos_url":"https://api.github.com/users/dotcloud/repos","events_url":"https://api.github.com/users/dotcloud/events{/privacy}","received_events_url":"https://api.github.com/users/dotcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"dotcloud/docker","owner":{"login":"dotcloud","id":171922,"avatar_url":"https://avatars.githubusercontent.com/u/171922?","gravatar_id":"d2fbb59e6c8b80a26e48b06ea30d53fd","url":"https://api.github.com/users/dotcloud","html_url":"https://github.com/dotcloud","followers_url":"https://api.github.com/users/dotcloud/followers","following_url":"https://api.github.com/users/dotcloud/following{/other_user}","gists_url":"https://api.github.com/users/dotcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/dotcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotcloud/subscriptions","organizations_url":"https://api.github.com/users/dotcloud/orgs","repos_url":"https://api.github.com/users/dotcloud/repos","events_url":"https://api.github.com/users/dotcloud/events{/privacy}","received_events_url":"https://api.github.com/users/dotcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotcloud/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/dotcloud/docker","forks_url":"https://api.github.com/repos/dotcloud/docker/forks","keys_url":"https://api.github.com/repos/dotcloud/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotcloud/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotcloud/docker/teams","hooks_url":"https://api.github.com/repos/dotcloud/docker/hooks","issue_events_url":"https://api.github.com/repos/dotcloud/docker/issues/events{/number}","events_url":"https://api.github.com/repos/dotcloud/docker/events","assignees_url":"https://api.github.com/repos/dotcloud/docker/assignees{/user}","branches_url":"https://api.github.com/repos/dotcloud/docker/branches{/branch}","tags_url":"https://api.github.com/repos/dotcloud/docker/tags","blobs_url":"https://api.github.com/repos/dotcloud/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotcloud/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotcloud/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotcloud/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotcloud/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/dotcloud/docker/languages","stargazers_url":"https://api.github.com/repos/dotcloud/docker/stargazers","contributors_url":"https://api.github.com/repos/dotcloud/docker/contributors","subscribers_url":"https://api.github.com/repos/dotcloud/docker/subscribers","subscription_url":"https://api.github.com/repos/dotcloud/docker/subscription","commits_url":"https://api.github.com/repos/dotcloud/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotcloud/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotcloud/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotcloud/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/dotcloud/docker/contents/{+path}","compare_url":"https://api.github.com/repos/dotcloud/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotcloud/docker/merges","archive_url":"https://api.github.com/repos/dotcloud/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotcloud/docker/downloads","issues_url":"https://api.github.com/repos/dotcloud/docker/issues{/number}","pulls_url":"https://api.github.com/repos/dotcloud/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/dotcloud/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/dotcloud/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotcloud/docker/labels{/name}","releases_url":"https://api.github.com/repos/dotcloud/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2014-07-10T06:45:48Z","pushed_at":"2014-07-10T06:26:14Z","git_url":"git://github.com/dotcloud/docker.git","ssh_url":"git@github.com:dotcloud/docker.git","clone_url":"https://github.com/dotcloud/docker.git","svn_url":"https://github.com/dotcloud/docker","homepage":"http://www.docker.com","size":116419,"stargazers_count":13494,"watchers_count":13494,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2415,"mirror_url":null,"open_issues_count":668,"forks":2415,"open_issues":668,"watchers":13494,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotcloud/docker/pulls/6951"},"html":{"href":"https://github.com/dotcloud/docker/pull/6951"},"issue":{"href":"https://api.github.com/repos/dotcloud/docker/issues/6951"},"comments":{"href":"https://api.github.com/repos/dotcloud/docker/issues/6951/comments"},"review_comments":{"href":"https://api.github.com/repos/dotcloud/docker/pulls/6951/comments"},"review_comment":{"href":"https://api.github.com/repos/dotcloud/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dotcloud/docker/pulls/6951/commits"},"statuses":{"href":"https://api.github.com/repos/dotcloud/docker/statuses/cdc168018b964ad768fef91a59aaf18ca832b1ea"}}}}