GitHub PullRequestReviewCommentEvent at 2014-08-14 12:54:02
Repository: flapjack
Actor: jessereynolds
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/flapjack/flapjack/pulls/comments/16235706","id":16235706,"diff_hunk":"@@ -48,12 +48,12 @@ production:\n       syslog_errors: yes\n   nagios-receiver:\n     fifo: \"/var/cache/nagios3/event_stream.fifo\"\n-    pid_file: \"/var/run/flapjack/flapjack-nagios-receiver.pid\"\n-    log_file: \"/var/log/flapjack/flapjack-nagios-receiver.log\"\n+    pid_dir: \"/var/run/flapjack/flapjack-nagios-receiver.pid\"","path":"etc/flapjack_config.yaml.example","position":17,"original_position":17,"commit_id":"86e99509df338dd60b4183a12ca1659da56dff1c","original_commit_id":"86e99509df338dd60b4183a12ca1659da56dff1c","user":{"login":"jessereynolds","id":391439,"avatar_url":"https://avatars.githubusercontent.com/u/391439?v=2","gravatar_id":"ae0689a4447971bf0515180c6232366f","url":"https://api.github.com/users/jessereynolds","html_url":"https://github.com/jessereynolds","followers_url":"https://api.github.com/users/jessereynolds/followers","following_url":"https://api.github.com/users/jessereynolds/following{/other_user}","gists_url":"https://api.github.com/users/jessereynolds/gists{/gist_id}","starred_url":"https://api.github.com/users/jessereynolds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessereynolds/subscriptions","organizations_url":"https://api.github.com/users/jessereynolds/orgs","repos_url":"https://api.github.com/users/jessereynolds/repos","events_url":"https://api.github.com/users/jessereynolds/events{/privacy}","received_events_url":"https://api.github.com/users/jessereynolds/received_events","type":"User","site_admin":false},"body":"that looks like a pid file, not a dir? ","created_at":"2014-08-14T12:54:02Z","updated_at":"2014-08-14T12:54:02Z","html_url":"https://github.com/flapjack/flapjack/pull/606#discussion_r16235706","pull_request_url":"https://api.github.com/repos/flapjack/flapjack/pulls/606","_links":{"self":{"href":"https://api.github.com/repos/flapjack/flapjack/pulls/comments/16235706"},"html":{"href":"https://github.com/flapjack/flapjack/pull/606#discussion_r16235706"},"pull_request":{"href":"https://api.github.com/repos/flapjack/flapjack/pulls/606"}}},"pull_request":{"url":"https://api.github.com/repos/flapjack/flapjack/pulls/606","id":19776796,"html_url":"https://github.com/flapjack/flapjack/pull/606","diff_url":"https://github.com/flapjack/flapjack/pull/606.diff","patch_url":"https://github.com/flapjack/flapjack/pull/606.patch","issue_url":"https://api.github.com/repos/flapjack/flapjack/issues/606","number":606,"state":"open","locked":false,"title":"PID and consistency fixes","user":{"login":"Hobbsee","id":3038925,"avatar_url":"https://avatars.githubusercontent.com/u/3038925?v=2","gravatar_id":"22af999dc97a139c1e515b0ccb9ee993","url":"https://api.github.com/users/Hobbsee","html_url":"https://github.com/Hobbsee","followers_url":"https://api.github.com/users/Hobbsee/followers","following_url":"https://api.github.com/users/Hobbsee/following{/other_user}","gists_url":"https://api.github.com/users/Hobbsee/gists{/gist_id}","starred_url":"https://api.github.com/users/Hobbsee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hobbsee/subscriptions","organizations_url":"https://api.github.com/users/Hobbsee/orgs","repos_url":"https://api.github.com/users/Hobbsee/repos","events_url":"https://api.github.com/users/Hobbsee/events{/privacy}","received_events_url":"https://api.github.com/users/Hobbsee/received_events","type":"User","site_admin":false},"body":"- Switch to using pid_file and pid_dir to keep all our pids in the same\n   location (rather than occasionally sending them to /var).  Apply the\n   same to log locations.\n - The above change means flapper needs sudo to run\n - DRY nagios and nsca receiver code.\n - Give the same outputs for flapper, receiver and server, including\n   the pid and uptime for a status.\n - Check that the flapper and receiver processes terminate correctly.","created_at":"2014-08-14T09:30:57Z","updated_at":"2014-08-14T12:54:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f9d19e539e244b3585ddc875fb7ec1a57ad6d53","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flapjack/flapjack/pulls/606/commits","review_comments_url":"https://api.github.com/repos/flapjack/flapjack/pulls/606/comments","review_comment_url":"https://api.github.com/repos/flapjack/flapjack/pulls/comments/{number}","comments_url":"https://api.github.com/repos/flapjack/flapjack/issues/606/comments","statuses_url":"https://api.github.com/repos/flapjack/flapjack/statuses/86e99509df338dd60b4183a12ca1659da56dff1c","head":{"label":"flapjack:pidfile-fixes","ref":"pidfile-fixes","sha":"86e99509df338dd60b4183a12ca1659da56dff1c","user":{"login":"flapjack","id":2343953,"avatar_url":"https://avatars.githubusercontent.com/u/2343953?v=2","gravatar_id":"c49b8ba436c628f552e9cb9b768b18e8","url":"https://api.github.com/users/flapjack","html_url":"https://github.com/flapjack","followers_url":"https://api.github.com/users/flapjack/followers","following_url":"https://api.github.com/users/flapjack/following{/other_user}","gists_url":"https://api.github.com/users/flapjack/gists{/gist_id}","starred_url":"https://api.github.com/users/flapjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flapjack/subscriptions","organizations_url":"https://api.github.com/users/flapjack/orgs","repos_url":"https://api.github.com/users/flapjack/repos","events_url":"https://api.github.com/users/flapjack/events{/privacy}","received_events_url":"https://api.github.com/users/flapjack/received_events","type":"Organization","site_admin":false},"repo":{"id":145744,"name":"flapjack","full_name":"flapjack/flapjack","owner":{"login":"flapjack","id":2343953,"avatar_url":"https://avatars.githubusercontent.com/u/2343953?v=2","gravatar_id":"c49b8ba436c628f552e9cb9b768b18e8","url":"https://api.github.com/users/flapjack","html_url":"https://github.com/flapjack","followers_url":"https://api.github.com/users/flapjack/followers","following_url":"https://api.github.com/users/flapjack/following{/other_user}","gists_url":"https://api.github.com/users/flapjack/gists{/gist_id}","starred_url":"https://api.github.com/users/flapjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flapjack/subscriptions","organizations_url":"https://api.github.com/users/flapjack/orgs","repos_url":"https://api.github.com/users/flapjack/repos","events_url":"https://api.github.com/users/flapjack/events{/privacy}","received_events_url":"https://api.github.com/users/flapjack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flapjack/flapjack","description":"Monitoring notification routing + event processing system","fork":false,"url":"https://api.github.com/repos/flapjack/flapjack","forks_url":"https://api.github.com/repos/flapjack/flapjack/forks","keys_url":"https://api.github.com/repos/flapjack/flapjack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flapjack/flapjack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flapjack/flapjack/teams","hooks_url":"https://api.github.com/repos/flapjack/flapjack/hooks","issue_events_url":"https://api.github.com/repos/flapjack/flapjack/issues/events{/number}","events_url":"https://api.github.com/repos/flapjack/flapjack/events","assignees_url":"https://api.github.com/repos/flapjack/flapjack/assignees{/user}","branches_url":"https://api.github.com/repos/flapjack/flapjack/branches{/branch}","tags_url":"https://api.github.com/repos/flapjack/flapjack/tags","blobs_url":"https://api.github.com/repos/flapjack/flapjack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flapjack/flapjack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flapjack/flapjack/git/refs{/sha}","trees_url":"https://api.github.com/repos/flapjack/flapjack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flapjack/flapjack/statuses/{sha}","languages_url":"https://api.github.com/repos/flapjack/flapjack/languages","stargazers_url":"https://api.github.com/repos/flapjack/flapjack/stargazers","contributors_url":"https://api.github.com/repos/flapjack/flapjack/contributors","subscribers_url":"https://api.github.com/repos/flapjack/flapjack/subscribers","subscription_url":"https://api.github.com/repos/flapjack/flapjack/subscription","commits_url":"https://api.github.com/repos/flapjack/flapjack/commits{/sha}","git_commits_url":"https://api.github.com/repos/flapjack/flapjack/git/commits{/sha}","comments_url":"https://api.github.com/repos/flapjack/flapjack/comments{/number}","issue_comment_url":"https://api.github.com/repos/flapjack/flapjack/issues/comments/{number}","contents_url":"https://api.github.com/repos/flapjack/flapjack/contents/{+path}","compare_url":"https://api.github.com/repos/flapjack/flapjack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flapjack/flapjack/merges","archive_url":"https://api.github.com/repos/flapjack/flapjack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flapjack/flapjack/downloads","issues_url":"https://api.github.com/repos/flapjack/flapjack/issues{/number}","pulls_url":"https://api.github.com/repos/flapjack/flapjack/pulls{/number}","milestones_url":"https://api.github.com/repos/flapjack/flapjack/milestones{/number}","notifications_url":"https://api.github.com/repos/flapjack/flapjack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flapjack/flapjack/labels{/name}","releases_url":"https://api.github.com/repos/flapjack/flapjack/releases{/id}","created_at":"2009-03-08T11:47:49Z","updated_at":"2014-08-11T21:14:24Z","pushed_at":"2014-08-14T12:27:10Z","git_url":"git://github.com/flapjack/flapjack.git","ssh_url":"git@github.com:flapjack/flapjack.git","clone_url":"https://github.com/flapjack/flapjack.git","svn_url":"https://github.com/flapjack/flapjack","homepage":"flapjack.io","size":24999,"stargazers_count":344,"watchers_count":344,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":46,"mirror_url":null,"open_issues_count":106,"forks":46,"open_issues":106,"watchers":344,"default_branch":"master"}},"base":{"label":"flapjack:master","ref":"master","sha":"49f16e371ec37331e6d6d29a0cee0c07cc830062","user":{"login":"flapjack","id":2343953,"avatar_url":"https://avatars.githubusercontent.com/u/2343953?v=2","gravatar_id":"c49b8ba436c628f552e9cb9b768b18e8","url":"https://api.github.com/users/flapjack","html_url":"https://github.com/flapjack","followers_url":"https://api.github.com/users/flapjack/followers","following_url":"https://api.github.com/users/flapjack/following{/other_user}","gists_url":"https://api.github.com/users/flapjack/gists{/gist_id}","starred_url":"https://api.github.com/users/flapjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flapjack/subscriptions","organizations_url":"https://api.github.com/users/flapjack/orgs","repos_url":"https://api.github.com/users/flapjack/repos","events_url":"https://api.github.com/users/flapjack/events{/privacy}","received_events_url":"https://api.github.com/users/flapjack/received_events","type":"Organization","site_admin":false},"repo":{"id":145744,"name":"flapjack","full_name":"flapjack/flapjack","owner":{"login":"flapjack","id":2343953,"avatar_url":"https://avatars.githubusercontent.com/u/2343953?v=2","gravatar_id":"c49b8ba436c628f552e9cb9b768b18e8","url":"https://api.github.com/users/flapjack","html_url":"https://github.com/flapjack","followers_url":"https://api.github.com/users/flapjack/followers","following_url":"https://api.github.com/users/flapjack/following{/other_user}","gists_url":"https://api.github.com/users/flapjack/gists{/gist_id}","starred_url":"https://api.github.com/users/flapjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flapjack/subscriptions","organizations_url":"https://api.github.com/users/flapjack/orgs","repos_url":"https://api.github.com/users/flapjack/repos","events_url":"https://api.github.com/users/flapjack/events{/privacy}","received_events_url":"https://api.github.com/users/flapjack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flapjack/flapjack","description":"Monitoring notification routing + event processing system","fork":false,"url":"https://api.github.com/repos/flapjack/flapjack","forks_url":"https://api.github.com/repos/flapjack/flapjack/forks","keys_url":"https://api.github.com/repos/flapjack/flapjack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flapjack/flapjack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flapjack/flapjack/teams","hooks_url":"https://api.github.com/repos/flapjack/flapjack/hooks","issue_events_url":"https://api.github.com/repos/flapjack/flapjack/issues/events{/number}","events_url":"https://api.github.com/repos/flapjack/flapjack/events","assignees_url":"https://api.github.com/repos/flapjack/flapjack/assignees{/user}","branches_url":"https://api.github.com/repos/flapjack/flapjack/branches{/branch}","tags_url":"https://api.github.com/repos/flapjack/flapjack/tags","blobs_url":"https://api.github.com/repos/flapjack/flapjack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flapjack/flapjack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flapjack/flapjack/git/refs{/sha}","trees_url":"https://api.github.com/repos/flapjack/flapjack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flapjack/flapjack/statuses/{sha}","languages_url":"https://api.github.com/repos/flapjack/flapjack/languages","stargazers_url":"https://api.github.com/repos/flapjack/flapjack/stargazers","contributors_url":"https://api.github.com/repos/flapjack/flapjack/contributors","subscribers_url":"https://api.github.com/repos/flapjack/flapjack/subscribers","subscription_url":"https://api.github.com/repos/flapjack/flapjack/subscription","commits_url":"https://api.github.com/repos/flapjack/flapjack/commits{/sha}","git_commits_url":"https://api.github.com/repos/flapjack/flapjack/git/commits{/sha}","comments_url":"https://api.github.com/repos/flapjack/flapjack/comments{/number}","issue_comment_url":"https://api.github.com/repos/flapjack/flapjack/issues/comments/{number}","contents_url":"https://api.github.com/repos/flapjack/flapjack/contents/{+path}","compare_url":"https://api.github.com/repos/flapjack/flapjack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flapjack/flapjack/merges","archive_url":"https://api.github.com/repos/flapjack/flapjack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flapjack/flapjack/downloads","issues_url":"https://api.github.com/repos/flapjack/flapjack/issues{/number}","pulls_url":"https://api.github.com/repos/flapjack/flapjack/pulls{/number}","milestones_url":"https://api.github.com/repos/flapjack/flapjack/milestones{/number}","notifications_url":"https://api.github.com/repos/flapjack/flapjack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flapjack/flapjack/labels{/name}","releases_url":"https://api.github.com/repos/flapjack/flapjack/releases{/id}","created_at":"2009-03-08T11:47:49Z","updated_at":"2014-08-11T21:14:24Z","pushed_at":"2014-08-14T12:27:10Z","git_url":"git://github.com/flapjack/flapjack.git","ssh_url":"git@github.com:flapjack/flapjack.git","clone_url":"https://github.com/flapjack/flapjack.git","svn_url":"https://github.com/flapjack/flapjack","homepage":"flapjack.io","size":24999,"stargazers_count":344,"watchers_count":344,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":46,"mirror_url":null,"open_issues_count":106,"forks":46,"open_issues":106,"watchers":344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flapjack/flapjack/pulls/606"},"html":{"href":"https://github.com/flapjack/flapjack/pull/606"},"issue":{"href":"https://api.github.com/repos/flapjack/flapjack/issues/606"},"comments":{"href":"https://api.github.com/repos/flapjack/flapjack/issues/606/comments"},"review_comments":{"href":"https://api.github.com/repos/flapjack/flapjack/pulls/606/comments"},"review_comment":{"href":"https://api.github.com/repos/flapjack/flapjack/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/flapjack/flapjack/pulls/606/commits"},"statuses":{"href":"https://api.github.com/repos/flapjack/flapjack/statuses/86e99509df338dd60b4183a12ca1659da56dff1c"}}}}