GitHub PullRequestReviewCommentEvent at 2014-10-07 23:07:50
Repository: angular.js
Actor: jeffbcross
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/18555735","id":18555735,"diff_hunk":"@@ -69,7 +75,9 @@ var ngOptionsMinErr = minErr('ngOptions');\n  *      DOM element.\n  *   * `trackexpr`: Used when working with an array of objects. The result of this expression will be\n  *      used to identify the objects in the array. The `trackexpr` will most likely refer to the\n- *     `value` variable (e.g. `value.propertyName`).\n+ *     `value` variable (e.g. `value.propertyName`). With this the selection is preserved\n+ *      even when the options are recreated (e.g. reloaded from the server).\n+ *      Note that this does not work when there is a `select` expression that is different from the `trackexpr`.","path":"src/ng/directive/select.js","position":20,"original_position":20,"commit_id":"35da770dbb8c2e7c33767bc35a6a4a947e120f3f","original_commit_id":"35da770dbb8c2e7c33767bc35a6a4a947e120f3f","user":{"login":"jeffbcross","id":463703,"avatar_url":"https://avatars.githubusercontent.com/u/463703?v=2","gravatar_id":"","url":"https://api.github.com/users/jeffbcross","html_url":"https://github.com/jeffbcross","followers_url":"https://api.github.com/users/jeffbcross/followers","following_url":"https://api.github.com/users/jeffbcross/following{/other_user}","gists_url":"https://api.github.com/users/jeffbcross/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbcross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbcross/subscriptions","organizations_url":"https://api.github.com/users/jeffbcross/orgs","repos_url":"https://api.github.com/users/jeffbcross/repos","events_url":"https://api.github.com/users/jeffbcross/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbcross/received_events","type":"User","site_admin":false},"body":"I should add a test for this...I'm not sure it's still true.","created_at":"2014-10-07T23:07:50Z","updated_at":"2014-10-07T23:07:50Z","html_url":"https://github.com/angular/angular.js/pull/9419#discussion_r18555735","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/9419","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/18555735"},"html":{"href":"https://github.com/angular/angular.js/pull/9419#discussion_r18555735"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/9419"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/9419","id":22235077,"html_url":"https://github.com/angular/angular.js/pull/9419","diff_url":"https://github.com/angular/angular.js/pull/9419.diff","patch_url":"https://github.com/angular/angular.js/pull/9419.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/9419","number":9419,"state":"open","locked":false,"title":"fix(select): make ngOptions support selectAs and trackBy together","user":{"login":"jeffbcross","id":463703,"avatar_url":"https://avatars.githubusercontent.com/u/463703?v=2","gravatar_id":"","url":"https://api.github.com/users/jeffbcross","html_url":"https://github.com/jeffbcross","followers_url":"https://api.github.com/users/jeffbcross/followers","following_url":"https://api.github.com/users/jeffbcross/following{/other_user}","gists_url":"https://api.github.com/users/jeffbcross/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbcross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbcross/subscriptions","organizations_url":"https://api.github.com/users/jeffbcross/orgs","repos_url":"https://api.github.com/users/jeffbcross/repos","events_url":"https://api.github.com/users/jeffbcross/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbcross/received_events","type":"User","site_admin":false},"body":"This commit implements a function, \"getSelected()\", that takes the\r\nselectAs expression into account when determining if a particular\r\noption is selected or not. Previously, the selectAs part of the\r\nngOptions comprehension expression was being ignored.\r\n\r\nFixes #6564","created_at":"2014-10-03T22:58:43Z","updated_at":"2014-10-07T23:07:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d3784ef2c54da46a6724af8f96e7d1c826a4251","assignee":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars.githubusercontent.com/u/216296?v=2","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/68","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/68/labels","id":807522,"number":68,"title":"1.3.0-rc.5","description":"","creator":{"login":"jeffbcross","id":463703,"avatar_url":"https://avatars.githubusercontent.com/u/463703?v=2","gravatar_id":"","url":"https://api.github.com/users/jeffbcross","html_url":"https://github.com/jeffbcross","followers_url":"https://api.github.com/users/jeffbcross/followers","following_url":"https://api.github.com/users/jeffbcross/following{/other_user}","gists_url":"https://api.github.com/users/jeffbcross/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbcross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbcross/subscriptions","organizations_url":"https://api.github.com/users/jeffbcross/orgs","repos_url":"https://api.github.com/users/jeffbcross/repos","events_url":"https://api.github.com/users/jeffbcross/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbcross/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":38,"state":"open","created_at":"2014-09-29T23:19:19Z","updated_at":"2014-10-07T23:07:34Z","due_on":"2014-10-06T07:00:00Z"},"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/9419/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/9419/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/9419/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/35da770dbb8c2e7c33767bc35a6a4a947e120f3f","head":{"label":"jeffbcross:issue-6564","ref":"issue-6564","sha":"35da770dbb8c2e7c33767bc35a6a4a947e120f3f","user":{"login":"jeffbcross","id":463703,"avatar_url":"https://avatars.githubusercontent.com/u/463703?v=2","gravatar_id":"","url":"https://api.github.com/users/jeffbcross","html_url":"https://github.com/jeffbcross","followers_url":"https://api.github.com/users/jeffbcross/followers","following_url":"https://api.github.com/users/jeffbcross/following{/other_user}","gists_url":"https://api.github.com/users/jeffbcross/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbcross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbcross/subscriptions","organizations_url":"https://api.github.com/users/jeffbcross/orgs","repos_url":"https://api.github.com/users/jeffbcross/repos","events_url":"https://api.github.com/users/jeffbcross/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbcross/received_events","type":"User","site_admin":false},"repo":{"id":11615089,"name":"angular.js","full_name":"jeffbcross/angular.js","owner":{"login":"jeffbcross","id":463703,"avatar_url":"https://avatars.githubusercontent.com/u/463703?v=2","gravatar_id":"","url":"https://api.github.com/users/jeffbcross","html_url":"https://github.com/jeffbcross","followers_url":"https://api.github.com/users/jeffbcross/followers","following_url":"https://api.github.com/users/jeffbcross/following{/other_user}","gists_url":"https://api.github.com/users/jeffbcross/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbcross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbcross/subscriptions","organizations_url":"https://api.github.com/users/jeffbcross/orgs","repos_url":"https://api.github.com/users/jeffbcross/repos","events_url":"https://api.github.com/users/jeffbcross/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbcross/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffbcross/angular.js","description":"","fork":true,"url":"https://api.github.com/repos/jeffbcross/angular.js","forks_url":"https://api.github.com/repos/jeffbcross/angular.js/forks","keys_url":"https://api.github.com/repos/jeffbcross/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffbcross/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffbcross/angular.js/teams","hooks_url":"https://api.github.com/repos/jeffbcross/angular.js/hooks","issue_events_url":"https://api.github.com/repos/jeffbcross/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/jeffbcross/angular.js/events","assignees_url":"https://api.github.com/repos/jeffbcross/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/jeffbcross/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/jeffbcross/angular.js/tags","blobs_url":"https://api.github.com/repos/jeffbcross/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffbcross/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffbcross/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffbcross/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffbcross/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffbcross/angular.js/languages","stargazers_url":"https://api.github.com/repos/jeffbcross/angular.js/stargazers","contributors_url":"https://api.github.com/repos/jeffbcross/angular.js/contributors","subscribers_url":"https://api.github.com/repos/jeffbcross/angular.js/subscribers","subscription_url":"https://api.github.com/repos/jeffbcross/angular.js/subscription","commits_url":"https://api.github.com/repos/jeffbcross/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffbcross/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffbcross/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffbcross/angular.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/jeffbcross/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/jeffbcross/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffbcross/angular.js/merges","archive_url":"https://api.github.com/repos/jeffbcross/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffbcross/angular.js/downloads","issues_url":"https://api.github.com/repos/jeffbcross/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/jeffbcross/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffbcross/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffbcross/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffbcross/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/jeffbcross/angular.js/releases{/id}","created_at":"2013-07-23T17:51:49Z","updated_at":"2014-10-02T18:05:01Z","pushed_at":"2014-10-07T21:10:34Z","git_url":"git://github.com/jeffbcross/angular.js.git","ssh_url":"git@github.com:jeffbcross/angular.js.git","clone_url":"https://github.com/jeffbcross/angular.js.git","svn_url":"https://github.com/jeffbcross/angular.js","homepage":"http://angularjs.org","size":58457,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"8ee1ba4b94d6fccff06d8781f7ed256c6ce664ff","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=2","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=2","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","created_at":"2010-01-06T00:34:37Z","updated_at":"2014-10-07T22:05:08Z","pushed_at":"2014-10-07T22:48:23Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":238967,"stargazers_count":29629,"watchers_count":29629,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11142,"mirror_url":null,"open_issues_count":1161,"forks":11142,"open_issues":1161,"watchers":29629,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/9419"},"html":{"href":"https://github.com/angular/angular.js/pull/9419"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/9419"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/9419/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/9419/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/9419/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/35da770dbb8c2e7c33767bc35a6a4a947e120f3f"}}}}