GitHub PullRequestEvent at 2014-06-21 11:20:50
Repository: Sylius
Actor: pjedrzejewski
Payload: {"action":"closed","number":1608,"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/1608","id":17040309,"html_url":"https://github.com/Sylius/Sylius/pull/1608","diff_url":"https://github.com/Sylius/Sylius/pull/1608.diff","patch_url":"https://github.com/Sylius/Sylius/pull/1608.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/1608","number":1608,"state":"closed","title":"[payment] allow set traversable as payment's details.","user":{"login":"makasim","id":143206,"avatar_url":"https://avatars.githubusercontent.com/u/143206?","gravatar_id":"13588b6015fc4f91316ea3ad1a18a0f5","url":"https://api.github.com/users/makasim","html_url":"https://github.com/makasim","followers_url":"https://api.github.com/users/makasim/followers","following_url":"https://api.github.com/users/makasim/following{/other_user}","gists_url":"https://api.github.com/users/makasim/gists{/gist_id}","starred_url":"https://api.github.com/users/makasim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makasim/subscriptions","organizations_url":"https://api.github.com/users/makasim/orgs","repos_url":"https://api.github.com/users/makasim/repos","events_url":"https://api.github.com/users/makasim/events{/privacy}","received_events_url":"https://api.github.com/users/makasim/received_events","type":"User","site_admin":false},"body":"This PR contains **BC break** in `PaymentInterface::setDetails` method. Removing this gives us some advantages:\r\n\r\n* Simplify CaptureXXXAction logic a bit. we do not need to force array everytime we set details: `$payment->setDetails((array) $details);`\r\n\r\n* Compatibility with [DetailsAwareInterface](https://github.com/Payum/Payum/blob/master/src/Payum/Core/Model/DetailsAwareInterface.php). I have plans to reuse `PaymentInterface` in PayumBundle as unified layer for doing payments. I need these interfaces to be compatible to simplify things.  \r\n\r\n\r\nMerge **only** after https://github.com/Sylius/Sylius/pull/1607 is merged","created_at":"2014-06-12T07:07:09Z","updated_at":"2014-06-21T11:20:50Z","closed_at":"2014-06-21T11:20:50Z","merged_at":null,"merge_commit_sha":"e3d12ef58883b76e7339611fa4ee30f817ce9e76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/1608/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/1608/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/1608/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/40aba41834b2417f659f3b1a167ed46fa60e4864","head":{"label":"formapro-forks:payment-details-allow-traversable","ref":"payment-details-allow-traversable","sha":"40aba41834b2417f659f3b1a167ed46fa60e4864","user":{"login":"formapro-forks","id":5163809,"avatar_url":"https://avatars.githubusercontent.com/u/5163809?","gravatar_id":null,"url":"https://api.github.com/users/formapro-forks","html_url":"https://github.com/formapro-forks","followers_url":"https://api.github.com/users/formapro-forks/followers","following_url":"https://api.github.com/users/formapro-forks/following{/other_user}","gists_url":"https://api.github.com/users/formapro-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/formapro-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/formapro-forks/subscriptions","organizations_url":"https://api.github.com/users/formapro-forks/orgs","repos_url":"https://api.github.com/users/formapro-forks/repos","events_url":"https://api.github.com/users/formapro-forks/events{/privacy}","received_events_url":"https://api.github.com/users/formapro-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":11863669,"name":"Sylius","full_name":"formapro-forks/Sylius","owner":{"login":"formapro-forks","id":5163809,"avatar_url":"https://avatars.githubusercontent.com/u/5163809?","gravatar_id":null,"url":"https://api.github.com/users/formapro-forks","html_url":"https://github.com/formapro-forks","followers_url":"https://api.github.com/users/formapro-forks/followers","following_url":"https://api.github.com/users/formapro-forks/following{/other_user}","gists_url":"https://api.github.com/users/formapro-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/formapro-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/formapro-forks/subscriptions","organizations_url":"https://api.github.com/users/formapro-forks/orgs","repos_url":"https://api.github.com/users/formapro-forks/repos","events_url":"https://api.github.com/users/formapro-forks/events{/privacy}","received_events_url":"https://api.github.com/users/formapro-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/formapro-forks/Sylius","description":"The official Sylius repository. Modern ecommerce for Symfony2.","fork":true,"url":"https://api.github.com/repos/formapro-forks/Sylius","forks_url":"https://api.github.com/repos/formapro-forks/Sylius/forks","keys_url":"https://api.github.com/repos/formapro-forks/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/formapro-forks/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/formapro-forks/Sylius/teams","hooks_url":"https://api.github.com/repos/formapro-forks/Sylius/hooks","issue_events_url":"https://api.github.com/repos/formapro-forks/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/formapro-forks/Sylius/events","assignees_url":"https://api.github.com/repos/formapro-forks/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/formapro-forks/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/formapro-forks/Sylius/tags","blobs_url":"https://api.github.com/repos/formapro-forks/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/formapro-forks/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/formapro-forks/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/formapro-forks/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/formapro-forks/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/formapro-forks/Sylius/languages","stargazers_url":"https://api.github.com/repos/formapro-forks/Sylius/stargazers","contributors_url":"https://api.github.com/repos/formapro-forks/Sylius/contributors","subscribers_url":"https://api.github.com/repos/formapro-forks/Sylius/subscribers","subscription_url":"https://api.github.com/repos/formapro-forks/Sylius/subscription","commits_url":"https://api.github.com/repos/formapro-forks/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/formapro-forks/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/formapro-forks/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/formapro-forks/Sylius/issues/comments/{number}","contents_url":"https://api.github.com/repos/formapro-forks/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/formapro-forks/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/formapro-forks/Sylius/merges","archive_url":"https://api.github.com/repos/formapro-forks/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/formapro-forks/Sylius/downloads","issues_url":"https://api.github.com/repos/formapro-forks/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/formapro-forks/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/formapro-forks/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/formapro-forks/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/formapro-forks/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/formapro-forks/Sylius/releases{/id}","created_at":"2013-08-03T13:43:52Z","updated_at":"2014-06-21T11:20:50Z","pushed_at":"2014-06-17T14:01:24Z","git_url":"git://github.com/formapro-forks/Sylius.git","ssh_url":"git@github.com:formapro-forks/Sylius.git","clone_url":"https://github.com/formapro-forks/Sylius.git","svn_url":"https://github.com/formapro-forks/Sylius","homepage":"Sylius.org","size":12408,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"02e71799659e4f013da1efc12764413182d8adfb","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?","gravatar_id":"51710342957a82f3a2ed91d1d45f11dc","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?","gravatar_id":"51710342957a82f3a2ed91d1d45f11dc","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments/{number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","created_at":"2011-11-05T22:05:52Z","updated_at":"2014-06-21T11:20:50Z","pushed_at":"2014-06-21T11:20:50Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"Sylius.org","size":37052,"stargazers_count":1172,"watchers_count":1172,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":384,"mirror_url":null,"open_issues_count":324,"forks":384,"open_issues":324,"watchers":1172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/1608"},"html":{"href":"https://github.com/Sylius/Sylius/pull/1608"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/1608"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/1608/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/1608/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/1608/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/40aba41834b2417f659f3b1a167ed46fa60e4864"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":2,"additions":46,"deletions":15,"changed_files":8}}