GitHub PullRequestReviewCommentEvent at 2014-07-12 08:45:46
Repository: iGCS
Actor: cnatoli
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fightingwalrus/iGCS/pulls/comments/14852276","id":14852276,"diff_hunk":"@@ -0,0 +1,201 @@\n+//\n+//  GCSHayesAT.m\n+//  iGCS\n+//\n+//  Created by Andrew Brown on 4/11/14.\n+//\n+//\n+\n+#import \"GCSSikAT.h\"\n+\n+NSString *const GCSSikHayesModeKeyName = @\"GCSSkikHayesModeKey\";\n+\n+NSString *const GCSSikHayesModeDescription[] = {\n+    [AT] = @\"AT\",\n+    [RT] = @\"RT\"\n+};\n+\n+// notes from docs...\n+// The first column is the S register to set if you want to change that parameter.\n+// So for example, to set the transmit power to 10dBm, use 'ATS4=10'.\n+// Most parameters only take effect on the next reboot. So the usual pattern\n+// is to set the parameters you want, then use 'AT&W' to write the parameters to EEPROM,\n+// then reboot using 'ATZ'. The exception is the transmit power, which changes immediately\n+// (although it will revert to the old setting on reboot unless you use AT&W).\n+//\n+@interface GCSSikAT () {\n+    NSArray *_matchRegisters;\n+}\n+\n+@end\n+\n+@implementation GCSSikAT\n+\n+-(id) init {\n+    self = [super init];\n+    if (self) {\n+        // registers that *must* match on both of the connected radios\n+        // for things to work. The radios firmware must also match.\n+        _matchRegisters = @[@(AirSpeed), @(MinFrequency), @(MaxFrequency),\n+                              @(NumberOfChannels), @(NetId), @(EnableECC), @(LbtRssi)];\n+\n+        // default is AT in order to work with the locally connected radio\n+        _hayesMode = AT;\n+    }\n+    return self;\n+}\n+\n+\n+#pragma mark - public AT/RT commands\n+\n+-(NSString *)showRadioVersionCommand {\n+    if (_hayesMode == AT) {","path":"iGCS/Comm/Interfaces/iGCS/GCSSikAT.m","position":52,"original_position":52,"commit_id":"b5c695a837276a752e7bc02a66c0713314c82e72","original_commit_id":"b5c695a837276a752e7bc02a66c0713314c82e72","user":{"login":"cnatoli","id":3847976,"avatar_url":"https://avatars.githubusercontent.com/u/3847976?","gravatar_id":"53fa6b6aafe6758a8356ef26ffa3e631","url":"https://api.github.com/users/cnatoli","html_url":"https://github.com/cnatoli","followers_url":"https://api.github.com/users/cnatoli/followers","following_url":"https://api.github.com/users/cnatoli/following{/other_user}","gists_url":"https://api.github.com/users/cnatoli/gists{/gist_id}","starred_url":"https://api.github.com/users/cnatoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnatoli/subscriptions","organizations_url":"https://api.github.com/users/cnatoli/orgs","repos_url":"https://api.github.com/users/cnatoli/repos","events_url":"https://api.github.com/users/cnatoli/events{/privacy}","received_events_url":"https://api.github.com/users/cnatoli/received_events","type":"User","site_admin":false},"body":"As a matter of personal taste, would prefer 1-liner returns using ternary operators throughout.","created_at":"2014-07-12T08:45:46Z","updated_at":"2014-07-12T08:45:46Z","html_url":"https://github.com/fightingwalrus/iGCS/pull/66#discussion_r14852276","pull_request_url":"https://api.github.com/repos/fightingwalrus/iGCS/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/fightingwalrus/iGCS/pulls/comments/14852276"},"html":{"href":"https://github.com/fightingwalrus/iGCS/pull/66#discussion_r14852276"},"pull_request":{"href":"https://api.github.com/repos/fightingwalrus/iGCS/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/fightingwalrus/iGCS/pulls/66","id":15739845,"html_url":"https://github.com/fightingwalrus/iGCS/pull/66","diff_url":"https://github.com/fightingwalrus/iGCS/pull/66.diff","patch_url":"https://github.com/fightingwalrus/iGCS/pull/66.patch","issue_url":"https://api.github.com/repos/fightingwalrus/iGCS/issues/66","number":66,"state":"open","title":"Igcs 58 radio config","user":{"login":"andymoe","id":10627,"avatar_url":"https://avatars.githubusercontent.com/u/10627?","gravatar_id":"7ffeb51dc9d81acce3fb0643d1b5ca07","url":"https://api.github.com/users/andymoe","html_url":"https://github.com/andymoe","followers_url":"https://api.github.com/users/andymoe/followers","following_url":"https://api.github.com/users/andymoe/following{/other_user}","gists_url":"https://api.github.com/users/andymoe/gists{/gist_id}","starred_url":"https://api.github.com/users/andymoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymoe/subscriptions","organizations_url":"https://api.github.com/users/andymoe/orgs","repos_url":"https://api.github.com/users/andymoe/repos","events_url":"https://api.github.com/users/andymoe/events{/privacy}","received_events_url":"https://api.github.com/users/andymoe/received_events","type":"User","site_admin":false},"body":"PR so @cnatoli can follow along with further development and keep me honest.","created_at":"2014-05-11T05:01:59Z","updated_at":"2014-07-12T08:45:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"084929d2ad33161d1d4b53265263708d20269171","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fightingwalrus/iGCS/pulls/66/commits","review_comments_url":"https://api.github.com/repos/fightingwalrus/iGCS/pulls/66/comments","review_comment_url":"https://api.github.com/repos/fightingwalrus/iGCS/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fightingwalrus/iGCS/issues/66/comments","statuses_url":"https://api.github.com/repos/fightingwalrus/iGCS/statuses/b5c695a837276a752e7bc02a66c0713314c82e72","head":{"label":"fightingwalrus:igcs-58-radio-config","ref":"igcs-58-radio-config","sha":"b5c695a837276a752e7bc02a66c0713314c82e72","user":{"login":"fightingwalrus","id":5784240,"avatar_url":"https://avatars.githubusercontent.com/u/5784240?","gravatar_id":"84ef7a6a10f9edab8eb52121adb4cd23","url":"https://api.github.com/users/fightingwalrus","html_url":"https://github.com/fightingwalrus","followers_url":"https://api.github.com/users/fightingwalrus/followers","following_url":"https://api.github.com/users/fightingwalrus/following{/other_user}","gists_url":"https://api.github.com/users/fightingwalrus/gists{/gist_id}","starred_url":"https://api.github.com/users/fightingwalrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fightingwalrus/subscriptions","organizations_url":"https://api.github.com/users/fightingwalrus/orgs","repos_url":"https://api.github.com/users/fightingwalrus/repos","events_url":"https://api.github.com/users/fightingwalrus/events{/privacy}","received_events_url":"https://api.github.com/users/fightingwalrus/received_events","type":"Organization","site_admin":false},"repo":{"id":8741793,"name":"iGCS","full_name":"fightingwalrus/iGCS","owner":{"login":"fightingwalrus","id":5784240,"avatar_url":"https://avatars.githubusercontent.com/u/5784240?","gravatar_id":"84ef7a6a10f9edab8eb52121adb4cd23","url":"https://api.github.com/users/fightingwalrus","html_url":"https://github.com/fightingwalrus","followers_url":"https://api.github.com/users/fightingwalrus/followers","following_url":"https://api.github.com/users/fightingwalrus/following{/other_user}","gists_url":"https://api.github.com/users/fightingwalrus/gists{/gist_id}","starred_url":"https://api.github.com/users/fightingwalrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fightingwalrus/subscriptions","organizations_url":"https://api.github.com/users/fightingwalrus/orgs","repos_url":"https://api.github.com/users/fightingwalrus/repos","events_url":"https://api.github.com/users/fightingwalrus/events{/privacy}","received_events_url":"https://api.github.com/users/fightingwalrus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fightingwalrus/iGCS","description":"iPad Ground Control Station for small drones","fork":false,"url":"https://api.github.com/repos/fightingwalrus/iGCS","forks_url":"https://api.github.com/repos/fightingwalrus/iGCS/forks","keys_url":"https://api.github.com/repos/fightingwalrus/iGCS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fightingwalrus/iGCS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fightingwalrus/iGCS/teams","hooks_url":"https://api.github.com/repos/fightingwalrus/iGCS/hooks","issue_events_url":"https://api.github.com/repos/fightingwalrus/iGCS/issues/events{/number}","events_url":"https://api.github.com/repos/fightingwalrus/iGCS/events","assignees_url":"https://api.github.com/repos/fightingwalrus/iGCS/assignees{/user}","branches_url":"https://api.github.com/repos/fightingwalrus/iGCS/branches{/branch}","tags_url":"https://api.github.com/repos/fightingwalrus/iGCS/tags","blobs_url":"https://api.github.com/repos/fightingwalrus/iGCS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fightingwalrus/iGCS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fightingwalrus/iGCS/git/refs{/sha}","trees_url":"https://api.github.com/repos/fightingwalrus/iGCS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fightingwalrus/iGCS/statuses/{sha}","languages_url":"https://api.github.com/repos/fightingwalrus/iGCS/languages","stargazers_url":"https://api.github.com/repos/fightingwalrus/iGCS/stargazers","contributors_url":"https://api.github.com/repos/fightingwalrus/iGCS/contributors","subscribers_url":"https://api.github.com/repos/fightingwalrus/iGCS/subscribers","subscription_url":"https://api.github.com/repos/fightingwalrus/iGCS/subscription","commits_url":"https://api.github.com/repos/fightingwalrus/iGCS/commits{/sha}","git_commits_url":"https://api.github.com/repos/fightingwalrus/iGCS/git/commits{/sha}","comments_url":"https://api.github.com/repos/fightingwalrus/iGCS/comments{/number}","issue_comment_url":"https://api.github.com/repos/fightingwalrus/iGCS/issues/comments/{number}","contents_url":"https://api.github.com/repos/fightingwalrus/iGCS/contents/{+path}","compare_url":"https://api.github.com/repos/fightingwalrus/iGCS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fightingwalrus/iGCS/merges","archive_url":"https://api.github.com/repos/fightingwalrus/iGCS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fightingwalrus/iGCS/downloads","issues_url":"https://api.github.com/repos/fightingwalrus/iGCS/issues{/number}","pulls_url":"https://api.github.com/repos/fightingwalrus/iGCS/pulls{/number}","milestones_url":"https://api.github.com/repos/fightingwalrus/iGCS/milestones{/number}","notifications_url":"https://api.github.com/repos/fightingwalrus/iGCS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fightingwalrus/iGCS/labels{/name}","releases_url":"https://api.github.com/repos/fightingwalrus/iGCS/releases{/id}","created_at":"2013-03-13T00:43:30Z","updated_at":"2014-06-30T11:14:35Z","pushed_at":"2014-07-12T05:39:24Z","git_url":"git://github.com/fightingwalrus/iGCS.git","ssh_url":"git@github.com:fightingwalrus/iGCS.git","clone_url":"https://github.com/fightingwalrus/iGCS.git","svn_url":"https://github.com/fightingwalrus/iGCS","homepage":"www.fightingwalrus.com","size":25389,"stargazers_count":34,"watchers_count":34,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":34,"default_branch":"master"}},"base":{"label":"fightingwalrus:master","ref":"master","sha":"feaef3dca8544355ae2ef2fb344f6ee9fede7f24","user":{"login":"fightingwalrus","id":5784240,"avatar_url":"https://avatars.githubusercontent.com/u/5784240?","gravatar_id":"84ef7a6a10f9edab8eb52121adb4cd23","url":"https://api.github.com/users/fightingwalrus","html_url":"https://github.com/fightingwalrus","followers_url":"https://api.github.com/users/fightingwalrus/followers","following_url":"https://api.github.com/users/fightingwalrus/following{/other_user}","gists_url":"https://api.github.com/users/fightingwalrus/gists{/gist_id}","starred_url":"https://api.github.com/users/fightingwalrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fightingwalrus/subscriptions","organizations_url":"https://api.github.com/users/fightingwalrus/orgs","repos_url":"https://api.github.com/users/fightingwalrus/repos","events_url":"https://api.github.com/users/fightingwalrus/events{/privacy}","received_events_url":"https://api.github.com/users/fightingwalrus/received_events","type":"Organization","site_admin":false},"repo":{"id":8741793,"name":"iGCS","full_name":"fightingwalrus/iGCS","owner":{"login":"fightingwalrus","id":5784240,"avatar_url":"https://avatars.githubusercontent.com/u/5784240?","gravatar_id":"84ef7a6a10f9edab8eb52121adb4cd23","url":"https://api.github.com/users/fightingwalrus","html_url":"https://github.com/fightingwalrus","followers_url":"https://api.github.com/users/fightingwalrus/followers","following_url":"https://api.github.com/users/fightingwalrus/following{/other_user}","gists_url":"https://api.github.com/users/fightingwalrus/gists{/gist_id}","starred_url":"https://api.github.com/users/fightingwalrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fightingwalrus/subscriptions","organizations_url":"https://api.github.com/users/fightingwalrus/orgs","repos_url":"https://api.github.com/users/fightingwalrus/repos","events_url":"https://api.github.com/users/fightingwalrus/events{/privacy}","received_events_url":"https://api.github.com/users/fightingwalrus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fightingwalrus/iGCS","description":"iPad Ground Control Station for small drones","fork":false,"url":"https://api.github.com/repos/fightingwalrus/iGCS","forks_url":"https://api.github.com/repos/fightingwalrus/iGCS/forks","keys_url":"https://api.github.com/repos/fightingwalrus/iGCS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fightingwalrus/iGCS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fightingwalrus/iGCS/teams","hooks_url":"https://api.github.com/repos/fightingwalrus/iGCS/hooks","issue_events_url":"https://api.github.com/repos/fightingwalrus/iGCS/issues/events{/number}","events_url":"https://api.github.com/repos/fightingwalrus/iGCS/events","assignees_url":"https://api.github.com/repos/fightingwalrus/iGCS/assignees{/user}","branches_url":"https://api.github.com/repos/fightingwalrus/iGCS/branches{/branch}","tags_url":"https://api.github.com/repos/fightingwalrus/iGCS/tags","blobs_url":"https://api.github.com/repos/fightingwalrus/iGCS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fightingwalrus/iGCS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fightingwalrus/iGCS/git/refs{/sha}","trees_url":"https://api.github.com/repos/fightingwalrus/iGCS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fightingwalrus/iGCS/statuses/{sha}","languages_url":"https://api.github.com/repos/fightingwalrus/iGCS/languages","stargazers_url":"https://api.github.com/repos/fightingwalrus/iGCS/stargazers","contributors_url":"https://api.github.com/repos/fightingwalrus/iGCS/contributors","subscribers_url":"https://api.github.com/repos/fightingwalrus/iGCS/subscribers","subscription_url":"https://api.github.com/repos/fightingwalrus/iGCS/subscription","commits_url":"https://api.github.com/repos/fightingwalrus/iGCS/commits{/sha}","git_commits_url":"https://api.github.com/repos/fightingwalrus/iGCS/git/commits{/sha}","comments_url":"https://api.github.com/repos/fightingwalrus/iGCS/comments{/number}","issue_comment_url":"https://api.github.com/repos/fightingwalrus/iGCS/issues/comments/{number}","contents_url":"https://api.github.com/repos/fightingwalrus/iGCS/contents/{+path}","compare_url":"https://api.github.com/repos/fightingwalrus/iGCS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fightingwalrus/iGCS/merges","archive_url":"https://api.github.com/repos/fightingwalrus/iGCS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fightingwalrus/iGCS/downloads","issues_url":"https://api.github.com/repos/fightingwalrus/iGCS/issues{/number}","pulls_url":"https://api.github.com/repos/fightingwalrus/iGCS/pulls{/number}","milestones_url":"https://api.github.com/repos/fightingwalrus/iGCS/milestones{/number}","notifications_url":"https://api.github.com/repos/fightingwalrus/iGCS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fightingwalrus/iGCS/labels{/name}","releases_url":"https://api.github.com/repos/fightingwalrus/iGCS/releases{/id}","created_at":"2013-03-13T00:43:30Z","updated_at":"2014-06-30T11:14:35Z","pushed_at":"2014-07-12T05:39:24Z","git_url":"git://github.com/fightingwalrus/iGCS.git","ssh_url":"git@github.com:fightingwalrus/iGCS.git","clone_url":"https://github.com/fightingwalrus/iGCS.git","svn_url":"https://github.com/fightingwalrus/iGCS","homepage":"www.fightingwalrus.com","size":25389,"stargazers_count":34,"watchers_count":34,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fightingwalrus/iGCS/pulls/66"},"html":{"href":"https://github.com/fightingwalrus/iGCS/pull/66"},"issue":{"href":"https://api.github.com/repos/fightingwalrus/iGCS/issues/66"},"comments":{"href":"https://api.github.com/repos/fightingwalrus/iGCS/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/fightingwalrus/iGCS/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/fightingwalrus/iGCS/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fightingwalrus/iGCS/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/fightingwalrus/iGCS/statuses/b5c695a837276a752e7bc02a66c0713314c82e72"}}}}