GitHub PullRequestEvent at 2014-07-11 10:20:56
Repository: ImpressPages
Actor: denistorresan
Payload: {"action":"opened","number":508,"pull_request":{"url":"https://api.github.com/repos/impresspages/ImpressPages/pulls/508","id":18270829,"html_url":"https://github.com/impresspages/ImpressPages/pull/508","diff_url":"https://github.com/impresspages/ImpressPages/pull/508.diff","patch_url":"https://github.com/impresspages/ImpressPages/pull/508.patch","issue_url":"https://api.github.com/repos/impresspages/ImpressPages/issues/508","number":508,"state":"open","title":"Fix Undefined index: websiteId on 1 step installation","user":{"login":"denistorresan","id":1846826,"avatar_url":"https://avatars.githubusercontent.com/u/1846826?","gravatar_id":"7e985bd0c73bcd7284793139330c1501","url":"https://api.github.com/users/denistorresan","html_url":"https://github.com/denistorresan","followers_url":"https://api.github.com/users/denistorresan/followers","following_url":"https://api.github.com/users/denistorresan/following{/other_user}","gists_url":"https://api.github.com/users/denistorresan/gists{/gist_id}","starred_url":"https://api.github.com/users/denistorresan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denistorresan/subscriptions","organizations_url":"https://api.github.com/users/denistorresan/orgs","repos_url":"https://api.github.com/users/denistorresan/repos","events_url":"https://api.github.com/users/denistorresan/events{/privacy}","received_events_url":"https://api.github.com/users/denistorresan/received_events","type":"User","site_admin":false},"body":"I discovered this error that cause a js alert popup on the very first step of the installation wizard.\r\nThis is caused by the websiteId in session is empty, than the method Model::sendUsageStatistics try to get from it db (and at the very first step db connection is not initialized).\r\nThe problem is related to session that is not yet started at the very first step, so I initialized it (if not already started) in the install/index.php.\r\n\r\nThis is the error I get (PHP 5.4, Windows 7):\r\nhttp://screencast.com/t/SPrrDlKX\r\n\r\nUnexpected error.<br />\r\n<b>Notice</b>:  Undefined index: websiteId in <b>C:\\WORKAREA\\Progetti\\fabvla\\impresspages\\htdocs\\install\\Plugin\\Install\\Helper.php</b> on line <b>353</b><br />","created_at":"2014-07-11T10:20:56Z","updated_at":"2014-07-11T10:20:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/impresspages/ImpressPages/pulls/508/commits","review_comments_url":"https://api.github.com/repos/impresspages/ImpressPages/pulls/508/comments","review_comment_url":"https://api.github.com/repos/impresspages/ImpressPages/pulls/comments/{number}","comments_url":"https://api.github.com/repos/impresspages/ImpressPages/issues/508/comments","statuses_url":"https://api.github.com/repos/impresspages/ImpressPages/statuses/7c03661158305afbbf9e19c6d91c53f6e077eb10","head":{"label":"fabvla:master","ref":"master","sha":"7c03661158305afbbf9e19c6d91c53f6e077eb10","user":{"login":"fabvla","id":8113959,"avatar_url":"https://avatars.githubusercontent.com/u/8113959?","gravatar_id":null,"url":"https://api.github.com/users/fabvla","html_url":"https://github.com/fabvla","followers_url":"https://api.github.com/users/fabvla/followers","following_url":"https://api.github.com/users/fabvla/following{/other_user}","gists_url":"https://api.github.com/users/fabvla/gists{/gist_id}","starred_url":"https://api.github.com/users/fabvla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabvla/subscriptions","organizations_url":"https://api.github.com/users/fabvla/orgs","repos_url":"https://api.github.com/users/fabvla/repos","events_url":"https://api.github.com/users/fabvla/events{/privacy}","received_events_url":"https://api.github.com/users/fabvla/received_events","type":"Organization","site_admin":false},"repo":{"id":21652486,"name":"ImpressPages","full_name":"fabvla/ImpressPages","owner":{"login":"fabvla","id":8113959,"avatar_url":"https://avatars.githubusercontent.com/u/8113959?","gravatar_id":null,"url":"https://api.github.com/users/fabvla","html_url":"https://github.com/fabvla","followers_url":"https://api.github.com/users/fabvla/followers","following_url":"https://api.github.com/users/fabvla/following{/other_user}","gists_url":"https://api.github.com/users/fabvla/gists{/gist_id}","starred_url":"https://api.github.com/users/fabvla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabvla/subscriptions","organizations_url":"https://api.github.com/users/fabvla/orgs","repos_url":"https://api.github.com/users/fabvla/repos","events_url":"https://api.github.com/users/fabvla/events{/privacy}","received_events_url":"https://api.github.com/users/fabvla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabvla/ImpressPages","description":"ImpressPages is php framework with admin panel. Build functional website in one hour.","fork":true,"url":"https://api.github.com/repos/fabvla/ImpressPages","forks_url":"https://api.github.com/repos/fabvla/ImpressPages/forks","keys_url":"https://api.github.com/repos/fabvla/ImpressPages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabvla/ImpressPages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabvla/ImpressPages/teams","hooks_url":"https://api.github.com/repos/fabvla/ImpressPages/hooks","issue_events_url":"https://api.github.com/repos/fabvla/ImpressPages/issues/events{/number}","events_url":"https://api.github.com/repos/fabvla/ImpressPages/events","assignees_url":"https://api.github.com/repos/fabvla/ImpressPages/assignees{/user}","branches_url":"https://api.github.com/repos/fabvla/ImpressPages/branches{/branch}","tags_url":"https://api.github.com/repos/fabvla/ImpressPages/tags","blobs_url":"https://api.github.com/repos/fabvla/ImpressPages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabvla/ImpressPages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabvla/ImpressPages/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabvla/ImpressPages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabvla/ImpressPages/statuses/{sha}","languages_url":"https://api.github.com/repos/fabvla/ImpressPages/languages","stargazers_url":"https://api.github.com/repos/fabvla/ImpressPages/stargazers","contributors_url":"https://api.github.com/repos/fabvla/ImpressPages/contributors","subscribers_url":"https://api.github.com/repos/fabvla/ImpressPages/subscribers","subscription_url":"https://api.github.com/repos/fabvla/ImpressPages/subscription","commits_url":"https://api.github.com/repos/fabvla/ImpressPages/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabvla/ImpressPages/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabvla/ImpressPages/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabvla/ImpressPages/issues/comments/{number}","contents_url":"https://api.github.com/repos/fabvla/ImpressPages/contents/{+path}","compare_url":"https://api.github.com/repos/fabvla/ImpressPages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabvla/ImpressPages/merges","archive_url":"https://api.github.com/repos/fabvla/ImpressPages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabvla/ImpressPages/downloads","issues_url":"https://api.github.com/repos/fabvla/ImpressPages/issues{/number}","pulls_url":"https://api.github.com/repos/fabvla/ImpressPages/pulls{/number}","milestones_url":"https://api.github.com/repos/fabvla/ImpressPages/milestones{/number}","notifications_url":"https://api.github.com/repos/fabvla/ImpressPages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabvla/ImpressPages/labels{/name}","releases_url":"https://api.github.com/repos/fabvla/ImpressPages/releases{/id}","created_at":"2014-07-09T13:05:52Z","updated_at":"2014-07-10T14:56:30Z","pushed_at":"2014-07-11T10:16:57Z","git_url":"git://github.com/fabvla/ImpressPages.git","ssh_url":"git@github.com:fabvla/ImpressPages.git","clone_url":"https://github.com/fabvla/ImpressPages.git","svn_url":"https://github.com/fabvla/ImpressPages","homepage":"http://www.impresspages.org","size":80852,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"impresspages:master","ref":"master","sha":"7934ad559c280091900010889eb5e48954b604cf","user":{"login":"impresspages","id":175242,"avatar_url":"https://avatars.githubusercontent.com/u/175242?","gravatar_id":"7ea8a4aa9a082f13a5cfb4d98dbe9c50","url":"https://api.github.com/users/impresspages","html_url":"https://github.com/impresspages","followers_url":"https://api.github.com/users/impresspages/followers","following_url":"https://api.github.com/users/impresspages/following{/other_user}","gists_url":"https://api.github.com/users/impresspages/gists{/gist_id}","starred_url":"https://api.github.com/users/impresspages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/impresspages/subscriptions","organizations_url":"https://api.github.com/users/impresspages/orgs","repos_url":"https://api.github.com/users/impresspages/repos","events_url":"https://api.github.com/users/impresspages/events{/privacy}","received_events_url":"https://api.github.com/users/impresspages/received_events","type":"Organization","site_admin":false},"repo":{"id":471883,"name":"ImpressPages","full_name":"impresspages/ImpressPages","owner":{"login":"impresspages","id":175242,"avatar_url":"https://avatars.githubusercontent.com/u/175242?","gravatar_id":"7ea8a4aa9a082f13a5cfb4d98dbe9c50","url":"https://api.github.com/users/impresspages","html_url":"https://github.com/impresspages","followers_url":"https://api.github.com/users/impresspages/followers","following_url":"https://api.github.com/users/impresspages/following{/other_user}","gists_url":"https://api.github.com/users/impresspages/gists{/gist_id}","starred_url":"https://api.github.com/users/impresspages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/impresspages/subscriptions","organizations_url":"https://api.github.com/users/impresspages/orgs","repos_url":"https://api.github.com/users/impresspages/repos","events_url":"https://api.github.com/users/impresspages/events{/privacy}","received_events_url":"https://api.github.com/users/impresspages/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/impresspages/ImpressPages","description":"ImpressPages is php framework with admin panel. Build functional website in one hour.","fork":false,"url":"https://api.github.com/repos/impresspages/ImpressPages","forks_url":"https://api.github.com/repos/impresspages/ImpressPages/forks","keys_url":"https://api.github.com/repos/impresspages/ImpressPages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/impresspages/ImpressPages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/impresspages/ImpressPages/teams","hooks_url":"https://api.github.com/repos/impresspages/ImpressPages/hooks","issue_events_url":"https://api.github.com/repos/impresspages/ImpressPages/issues/events{/number}","events_url":"https://api.github.com/repos/impresspages/ImpressPages/events","assignees_url":"https://api.github.com/repos/impresspages/ImpressPages/assignees{/user}","branches_url":"https://api.github.com/repos/impresspages/ImpressPages/branches{/branch}","tags_url":"https://api.github.com/repos/impresspages/ImpressPages/tags","blobs_url":"https://api.github.com/repos/impresspages/ImpressPages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/impresspages/ImpressPages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/impresspages/ImpressPages/git/refs{/sha}","trees_url":"https://api.github.com/repos/impresspages/ImpressPages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/impresspages/ImpressPages/statuses/{sha}","languages_url":"https://api.github.com/repos/impresspages/ImpressPages/languages","stargazers_url":"https://api.github.com/repos/impresspages/ImpressPages/stargazers","contributors_url":"https://api.github.com/repos/impresspages/ImpressPages/contributors","subscribers_url":"https://api.github.com/repos/impresspages/ImpressPages/subscribers","subscription_url":"https://api.github.com/repos/impresspages/ImpressPages/subscription","commits_url":"https://api.github.com/repos/impresspages/ImpressPages/commits{/sha}","git_commits_url":"https://api.github.com/repos/impresspages/ImpressPages/git/commits{/sha}","comments_url":"https://api.github.com/repos/impresspages/ImpressPages/comments{/number}","issue_comment_url":"https://api.github.com/repos/impresspages/ImpressPages/issues/comments/{number}","contents_url":"https://api.github.com/repos/impresspages/ImpressPages/contents/{+path}","compare_url":"https://api.github.com/repos/impresspages/ImpressPages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/impresspages/ImpressPages/merges","archive_url":"https://api.github.com/repos/impresspages/ImpressPages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/impresspages/ImpressPages/downloads","issues_url":"https://api.github.com/repos/impresspages/ImpressPages/issues{/number}","pulls_url":"https://api.github.com/repos/impresspages/ImpressPages/pulls{/number}","milestones_url":"https://api.github.com/repos/impresspages/ImpressPages/milestones{/number}","notifications_url":"https://api.github.com/repos/impresspages/ImpressPages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/impresspages/ImpressPages/labels{/name}","releases_url":"https://api.github.com/repos/impresspages/ImpressPages/releases{/id}","created_at":"2010-01-14T13:05:56Z","updated_at":"2014-07-04T05:56:43Z","pushed_at":"2014-07-10T15:17:15Z","git_url":"git://github.com/impresspages/ImpressPages.git","ssh_url":"git@github.com:impresspages/ImpressPages.git","clone_url":"https://github.com/impresspages/ImpressPages.git","svn_url":"https://github.com/impresspages/ImpressPages","homepage":"http://www.impresspages.org","size":80852,"stargazers_count":269,"watchers_count":269,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":75,"mirror_url":null,"open_issues_count":43,"forks":75,"open_issues":43,"watchers":269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/impresspages/ImpressPages/pulls/508"},"html":{"href":"https://github.com/impresspages/ImpressPages/pull/508"},"issue":{"href":"https://api.github.com/repos/impresspages/ImpressPages/issues/508"},"comments":{"href":"https://api.github.com/repos/impresspages/ImpressPages/issues/508/comments"},"review_comments":{"href":"https://api.github.com/repos/impresspages/ImpressPages/pulls/508/comments"},"review_comment":{"href":"https://api.github.com/repos/impresspages/ImpressPages/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/impresspages/ImpressPages/pulls/508/commits"},"statuses":{"href":"https://api.github.com/repos/impresspages/ImpressPages/statuses/7c03661158305afbbf9e19c6d91c53f6e077eb10"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":4,"deletions":0,"changed_files":1}}