GitHub PullRequestReviewCommentEvent at 2014-09-08 17:50:47
Repository: activator-template-cache
Actor: havocp
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls/comments/17254374","id":17254374,"diff_hunk":"@@ -52,16 +52,16 @@ object DefaultTemplateCache {\n \n   /** Creates a default template cache for us. */\n   def apply(actorFactory: ActorRefFactory,\n-    location: File,\n-    remote: RemoteTemplateRepository = defaultRemoteRepo,\n+    baseDir: File,\n+    remotes: IndexedSeq[RemoteTemplateRepository] = IndexedSeq(defaultRemoteRepo),\n     seedRepository: Option[File] = None,\n     autoUpdate: Boolean = defaultAutoUpdate)(\n       implicit timeout: Timeout): TemplateCache = {\n     // If we have a seed repository, copy it over.\n-    seedRepository foreach (repo => ZipInstallHelper.copyLocalCacheIfNeeded(location, repo))\n+    seedRepository foreach (repo => ZipInstallHelper.copyLocalCacheIfNeeded(baseDir, repo))","path":"templates-cache/src/main/scala/activator/cache/DefaultTemplateCache.scala","position":29,"original_position":29,"commit_id":"7e765bfb36a2121e7dbd33e81d92b8a13f294a6d","original_commit_id":"7e765bfb36a2121e7dbd33e81d92b8a13f294a6d","user":{"login":"havocp","id":218689,"avatar_url":"https://avatars.githubusercontent.com/u/218689?v=2","gravatar_id":"874f23791a8b1efcd1dcaee1851daa1b","url":"https://api.github.com/users/havocp","html_url":"https://github.com/havocp","followers_url":"https://api.github.com/users/havocp/followers","following_url":"https://api.github.com/users/havocp/following{/other_user}","gists_url":"https://api.github.com/users/havocp/gists{/gist_id}","starred_url":"https://api.github.com/users/havocp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/havocp/subscriptions","organizations_url":"https://api.github.com/users/havocp/orgs","repos_url":"https://api.github.com/users/havocp/repos","events_url":"https://api.github.com/users/havocp/events{/privacy}","received_events_url":"https://api.github.com/users/havocp/received_events","type":"User","site_admin":false},"body":"Do I have it right that each repo is now under `baseDir / repoName`? If so does this correctly copy the seed repository to `baseDir / repoName` or does it put it right under `baseDir`? it just looks here based on variable names like we're copying a repo to the basedir instead of a subdir of baseDir, but i didn't trace through the code to verify.","created_at":"2014-09-08T17:50:47Z","updated_at":"2014-09-08T17:50:47Z","html_url":"https://github.com/typesafehub/activator-template-cache/pull/36#discussion_r17254374","pull_request_url":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls/comments/17254374"},"html":{"href":"https://github.com/typesafehub/activator-template-cache/pull/36#discussion_r17254374"},"pull_request":{"href":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls/36","id":20693910,"html_url":"https://github.com/typesafehub/activator-template-cache/pull/36","diff_url":"https://github.com/typesafehub/activator-template-cache/pull/36.diff","patch_url":"https://github.com/typesafehub/activator-template-cache/pull/36.patch","issue_url":"https://api.github.com/repos/typesafehub/activator-template-cache/issues/36","number":36,"state":"open","locked":false,"title":"Support for multiple template repositories","user":{"login":"grahamar","id":1964861,"avatar_url":"https://avatars.githubusercontent.com/u/1964861?v=2","gravatar_id":"6b9083809e1d8eaa4fe45ef29ea4eda2","url":"https://api.github.com/users/grahamar","html_url":"https://github.com/grahamar","followers_url":"https://api.github.com/users/grahamar/followers","following_url":"https://api.github.com/users/grahamar/following{/other_user}","gists_url":"https://api.github.com/users/grahamar/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamar/subscriptions","organizations_url":"https://api.github.com/users/grahamar/orgs","repos_url":"https://api.github.com/users/grahamar/repos","events_url":"https://api.github.com/users/grahamar/events{/privacy}","received_events_url":"https://api.github.com/users/grahamar/received_events","type":"User","site_admin":false},"body":"A working first stab at support for multiple template repositories. Main aim is to allow for internal company repositories so that company specific templates needn't pollute the public repository.","created_at":"2014-09-03T17:52:40Z","updated_at":"2014-09-08T17:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6860b4dc267b28dbd689c75cbf36dadeebc3fbbc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls/36/commits","review_comments_url":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls/36/comments","review_comment_url":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls/comments/{number}","comments_url":"https://api.github.com/repos/typesafehub/activator-template-cache/issues/36/comments","statuses_url":"https://api.github.com/repos/typesafehub/activator-template-cache/statuses/7e765bfb36a2121e7dbd33e81d92b8a13f294a6d","head":{"label":"grahamar:master","ref":"master","sha":"7e765bfb36a2121e7dbd33e81d92b8a13f294a6d","user":{"login":"grahamar","id":1964861,"avatar_url":"https://avatars.githubusercontent.com/u/1964861?v=2","gravatar_id":"6b9083809e1d8eaa4fe45ef29ea4eda2","url":"https://api.github.com/users/grahamar","html_url":"https://github.com/grahamar","followers_url":"https://api.github.com/users/grahamar/followers","following_url":"https://api.github.com/users/grahamar/following{/other_user}","gists_url":"https://api.github.com/users/grahamar/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamar/subscriptions","organizations_url":"https://api.github.com/users/grahamar/orgs","repos_url":"https://api.github.com/users/grahamar/repos","events_url":"https://api.github.com/users/grahamar/events{/privacy}","received_events_url":"https://api.github.com/users/grahamar/received_events","type":"User","site_admin":false},"repo":{"id":20515924,"name":"activator-template-cache","full_name":"grahamar/activator-template-cache","owner":{"login":"grahamar","id":1964861,"avatar_url":"https://avatars.githubusercontent.com/u/1964861?v=2","gravatar_id":"6b9083809e1d8eaa4fe45ef29ea4eda2","url":"https://api.github.com/users/grahamar","html_url":"https://github.com/grahamar","followers_url":"https://api.github.com/users/grahamar/followers","following_url":"https://api.github.com/users/grahamar/following{/other_user}","gists_url":"https://api.github.com/users/grahamar/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamar/subscriptions","organizations_url":"https://api.github.com/users/grahamar/orgs","repos_url":"https://api.github.com/users/grahamar/repos","events_url":"https://api.github.com/users/grahamar/events{/privacy}","received_events_url":"https://api.github.com/users/grahamar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grahamar/activator-template-cache","description":"Creating and resolving templates for the activator project","fork":true,"url":"https://api.github.com/repos/grahamar/activator-template-cache","forks_url":"https://api.github.com/repos/grahamar/activator-template-cache/forks","keys_url":"https://api.github.com/repos/grahamar/activator-template-cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grahamar/activator-template-cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grahamar/activator-template-cache/teams","hooks_url":"https://api.github.com/repos/grahamar/activator-template-cache/hooks","issue_events_url":"https://api.github.com/repos/grahamar/activator-template-cache/issues/events{/number}","events_url":"https://api.github.com/repos/grahamar/activator-template-cache/events","assignees_url":"https://api.github.com/repos/grahamar/activator-template-cache/assignees{/user}","branches_url":"https://api.github.com/repos/grahamar/activator-template-cache/branches{/branch}","tags_url":"https://api.github.com/repos/grahamar/activator-template-cache/tags","blobs_url":"https://api.github.com/repos/grahamar/activator-template-cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grahamar/activator-template-cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grahamar/activator-template-cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/grahamar/activator-template-cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grahamar/activator-template-cache/statuses/{sha}","languages_url":"https://api.github.com/repos/grahamar/activator-template-cache/languages","stargazers_url":"https://api.github.com/repos/grahamar/activator-template-cache/stargazers","contributors_url":"https://api.github.com/repos/grahamar/activator-template-cache/contributors","subscribers_url":"https://api.github.com/repos/grahamar/activator-template-cache/subscribers","subscription_url":"https://api.github.com/repos/grahamar/activator-template-cache/subscription","commits_url":"https://api.github.com/repos/grahamar/activator-template-cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/grahamar/activator-template-cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/grahamar/activator-template-cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/grahamar/activator-template-cache/issues/comments/{number}","contents_url":"https://api.github.com/repos/grahamar/activator-template-cache/contents/{+path}","compare_url":"https://api.github.com/repos/grahamar/activator-template-cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grahamar/activator-template-cache/merges","archive_url":"https://api.github.com/repos/grahamar/activator-template-cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grahamar/activator-template-cache/downloads","issues_url":"https://api.github.com/repos/grahamar/activator-template-cache/issues{/number}","pulls_url":"https://api.github.com/repos/grahamar/activator-template-cache/pulls{/number}","milestones_url":"https://api.github.com/repos/grahamar/activator-template-cache/milestones{/number}","notifications_url":"https://api.github.com/repos/grahamar/activator-template-cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grahamar/activator-template-cache/labels{/name}","releases_url":"https://api.github.com/repos/grahamar/activator-template-cache/releases{/id}","created_at":"2014-06-05T07:29:34Z","updated_at":"2014-09-02T16:19:30Z","pushed_at":"2014-09-04T13:55:51Z","git_url":"git://github.com/grahamar/activator-template-cache.git","ssh_url":"git@github.com:grahamar/activator-template-cache.git","clone_url":"https://github.com/grahamar/activator-template-cache.git","svn_url":"https://github.com/grahamar/activator-template-cache","homepage":null,"size":356,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typesafehub:master","ref":"master","sha":"0d9bfb4dcb412361e610d84dddd126e3dbb007bb","user":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=2","gravatar_id":"c2651ca793557fc38d7b90b064ec791b","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"repo":{"id":11101676,"name":"activator-template-cache","full_name":"typesafehub/activator-template-cache","owner":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=2","gravatar_id":"c2651ca793557fc38d7b90b064ec791b","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typesafehub/activator-template-cache","description":"Creating and resolving templates for the activator project","fork":false,"url":"https://api.github.com/repos/typesafehub/activator-template-cache","forks_url":"https://api.github.com/repos/typesafehub/activator-template-cache/forks","keys_url":"https://api.github.com/repos/typesafehub/activator-template-cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typesafehub/activator-template-cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typesafehub/activator-template-cache/teams","hooks_url":"https://api.github.com/repos/typesafehub/activator-template-cache/hooks","issue_events_url":"https://api.github.com/repos/typesafehub/activator-template-cache/issues/events{/number}","events_url":"https://api.github.com/repos/typesafehub/activator-template-cache/events","assignees_url":"https://api.github.com/repos/typesafehub/activator-template-cache/assignees{/user}","branches_url":"https://api.github.com/repos/typesafehub/activator-template-cache/branches{/branch}","tags_url":"https://api.github.com/repos/typesafehub/activator-template-cache/tags","blobs_url":"https://api.github.com/repos/typesafehub/activator-template-cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typesafehub/activator-template-cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typesafehub/activator-template-cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/typesafehub/activator-template-cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typesafehub/activator-template-cache/statuses/{sha}","languages_url":"https://api.github.com/repos/typesafehub/activator-template-cache/languages","stargazers_url":"https://api.github.com/repos/typesafehub/activator-template-cache/stargazers","contributors_url":"https://api.github.com/repos/typesafehub/activator-template-cache/contributors","subscribers_url":"https://api.github.com/repos/typesafehub/activator-template-cache/subscribers","subscription_url":"https://api.github.com/repos/typesafehub/activator-template-cache/subscription","commits_url":"https://api.github.com/repos/typesafehub/activator-template-cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/typesafehub/activator-template-cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/typesafehub/activator-template-cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/typesafehub/activator-template-cache/issues/comments/{number}","contents_url":"https://api.github.com/repos/typesafehub/activator-template-cache/contents/{+path}","compare_url":"https://api.github.com/repos/typesafehub/activator-template-cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typesafehub/activator-template-cache/merges","archive_url":"https://api.github.com/repos/typesafehub/activator-template-cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typesafehub/activator-template-cache/downloads","issues_url":"https://api.github.com/repos/typesafehub/activator-template-cache/issues{/number}","pulls_url":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls{/number}","milestones_url":"https://api.github.com/repos/typesafehub/activator-template-cache/milestones{/number}","notifications_url":"https://api.github.com/repos/typesafehub/activator-template-cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typesafehub/activator-template-cache/labels{/name}","releases_url":"https://api.github.com/repos/typesafehub/activator-template-cache/releases{/id}","created_at":"2013-07-01T17:15:33Z","updated_at":"2014-06-25T19:15:03Z","pushed_at":"2014-07-24T21:16:52Z","git_url":"git://github.com/typesafehub/activator-template-cache.git","ssh_url":"git@github.com:typesafehub/activator-template-cache.git","clone_url":"https://github.com/typesafehub/activator-template-cache.git","svn_url":"https://github.com/typesafehub/activator-template-cache","homepage":null,"size":1022,"stargazers_count":6,"watchers_count":6,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls/36"},"html":{"href":"https://github.com/typesafehub/activator-template-cache/pull/36"},"issue":{"href":"https://api.github.com/repos/typesafehub/activator-template-cache/issues/36"},"comments":{"href":"https://api.github.com/repos/typesafehub/activator-template-cache/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/typesafehub/activator-template-cache/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/typesafehub/activator-template-cache/statuses/7e765bfb36a2121e7dbd33e81d92b8a13f294a6d"}}}}