GitHub PullRequestReviewCommentEvent at 2014-05-21 13:57:17
Repository: HPCC-Platform
Actor: ghalliday
Payload: {"comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/12896851","id":12896851,"diff_hunk":"@@ -389,6 +389,12 @@ static void throwHeapExhausted(unsigned pages)\n     throw MakeStringException(ROXIEMM_MEMORY_POOL_EXHAUSTED, \"Memory pool exhausted\");\n }\n \n+static void throwHeapExhausted(unsigned newPages, unsigned oldPages)\n+{\n+    DBGLOG(\"RoxieMemMgr: Memory pool (%u pages) exhausted requested %u, had %u\", heapTotalPages, newPages, oldPages);\n+    throw MakeStringException(ROXIEMM_MEMORY_POOL_EXHAUSTED, \"Memory pool exhausted\");","path":"roxie/roxiemem/roxiemem.cpp","position":7,"original_position":7,"commit_id":"d975ce869d375024b166a03278e5e93d288af5c9","original_commit_id":"d975ce869d375024b166a03278e5e93d288af5c9","user":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?","gravatar_id":"402dddc31c0e131326457e9ffd436352","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"body":"Would it be useful to include the number of pages information into the exception as well?\r\n","created_at":"2014-05-21T13:57:17Z","updated_at":"2014-05-21T13:57:17Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/5914#discussion_r12896851","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/5914","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/12896851"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/5914#discussion_r12896851"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/5914"}}}}