GitHub PullRequestReviewCommentEvent at 2014-11-11 16:00:11
Repository: makedrive
Actor: humphd
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/makedrive/pulls/comments/20158962","id":20158962,"diff_hunk":"@@ -30,21 +30,6 @@ var app = server.app;\n var serverURL = 'http://127.0.0.1:' + env.get('PORT'),\n     socketURL = serverURL.replace( 'http', 'ws' );\n \n-// Mock Webmaker auth","path":"tests/lib/util.js","position":4,"original_position":4,"commit_id":"05ba065565587dbe7914ccd9d16b298a602bd38d","original_commit_id":"05ba065565587dbe7914ccd9d16b298a602bd38d","user":{"login":"humphd","id":427398,"avatar_url":"https://avatars.githubusercontent.com/u/427398?v=3","gravatar_id":"","url":"https://api.github.com/users/humphd","html_url":"https://github.com/humphd","followers_url":"https://api.github.com/users/humphd/followers","following_url":"https://api.github.com/users/humphd/following{/other_user}","gists_url":"https://api.github.com/users/humphd/gists{/gist_id}","starred_url":"https://api.github.com/users/humphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphd/subscriptions","organizations_url":"https://api.github.com/users/humphd/orgs","repos_url":"https://api.github.com/users/humphd/repos","events_url":"https://api.github.com/users/humphd/events{/privacy}","received_events_url":"https://api.github.com/users/humphd/received_events","type":"User","site_admin":false},"body":"I don't understand why you've changed all this?  Why not have the tests configured to use a `passport-webmaker.js` provider, and then this fakes authentication for you.  Nothing would need to change in this code, or the tests.","created_at":"2014-11-11T16:00:11Z","updated_at":"2014-11-11T16:00:11Z","html_url":"https://github.com/mozilla/makedrive/pull/463#discussion_r20158962","pull_request_url":"https://api.github.com/repos/mozilla/makedrive/pulls/463","_links":{"self":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/comments/20158962"},"html":{"href":"https://github.com/mozilla/makedrive/pull/463#discussion_r20158962"},"pull_request":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/463"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/makedrive/pulls/463","id":24169602,"html_url":"https://github.com/mozilla/makedrive/pull/463","diff_url":"https://github.com/mozilla/makedrive/pull/463.diff","patch_url":"https://github.com/mozilla/makedrive/pull/463.patch","issue_url":"https://api.github.com/repos/mozilla/makedrive/issues/463","number":463,"state":"open","locked":false,"title":"issue 451 - MakeDrive auth should be pluggable, configurable, optional","user":{"login":"alicoding","id":4368149,"avatar_url":"https://avatars.githubusercontent.com/u/4368149?v=3","gravatar_id":"","url":"https://api.github.com/users/alicoding","html_url":"https://github.com/alicoding","followers_url":"https://api.github.com/users/alicoding/followers","following_url":"https://api.github.com/users/alicoding/following{/other_user}","gists_url":"https://api.github.com/users/alicoding/gists{/gist_id}","starred_url":"https://api.github.com/users/alicoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicoding/subscriptions","organizations_url":"https://api.github.com/users/alicoding/orgs","repos_url":"https://api.github.com/users/alicoding/repos","events_url":"https://api.github.com/users/alicoding/events{/privacy}","received_events_url":"https://api.github.com/users/alicoding/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-10T19:11:26Z","updated_at":"2014-11-11T16:00:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6318265b8a744b7f3ffa257bce55ee393337698a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/makedrive/pulls/463/commits","review_comments_url":"https://api.github.com/repos/mozilla/makedrive/pulls/463/comments","review_comment_url":"https://api.github.com/repos/mozilla/makedrive/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/makedrive/issues/463/comments","statuses_url":"https://api.github.com/repos/mozilla/makedrive/statuses/05ba065565587dbe7914ccd9d16b298a602bd38d","head":{"label":"alicoding:passport","ref":"passport","sha":"05ba065565587dbe7914ccd9d16b298a602bd38d","user":{"login":"alicoding","id":4368149,"avatar_url":"https://avatars.githubusercontent.com/u/4368149?v=3","gravatar_id":"","url":"https://api.github.com/users/alicoding","html_url":"https://github.com/alicoding","followers_url":"https://api.github.com/users/alicoding/followers","following_url":"https://api.github.com/users/alicoding/following{/other_user}","gists_url":"https://api.github.com/users/alicoding/gists{/gist_id}","starred_url":"https://api.github.com/users/alicoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicoding/subscriptions","organizations_url":"https://api.github.com/users/alicoding/orgs","repos_url":"https://api.github.com/users/alicoding/repos","events_url":"https://api.github.com/users/alicoding/events{/privacy}","received_events_url":"https://api.github.com/users/alicoding/received_events","type":"User","site_admin":false},"repo":{"id":21656710,"name":"makedrive","full_name":"alicoding/makedrive","owner":{"login":"alicoding","id":4368149,"avatar_url":"https://avatars.githubusercontent.com/u/4368149?v=3","gravatar_id":"","url":"https://api.github.com/users/alicoding","html_url":"https://github.com/alicoding","followers_url":"https://api.github.com/users/alicoding/followers","following_url":"https://api.github.com/users/alicoding/following{/other_user}","gists_url":"https://api.github.com/users/alicoding/gists{/gist_id}","starred_url":"https://api.github.com/users/alicoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicoding/subscriptions","organizations_url":"https://api.github.com/users/alicoding/orgs","repos_url":"https://api.github.com/users/alicoding/repos","events_url":"https://api.github.com/users/alicoding/events{/privacy}","received_events_url":"https://api.github.com/users/alicoding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alicoding/makedrive","description":"Webmaker Filesystem","fork":true,"url":"https://api.github.com/repos/alicoding/makedrive","forks_url":"https://api.github.com/repos/alicoding/makedrive/forks","keys_url":"https://api.github.com/repos/alicoding/makedrive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alicoding/makedrive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alicoding/makedrive/teams","hooks_url":"https://api.github.com/repos/alicoding/makedrive/hooks","issue_events_url":"https://api.github.com/repos/alicoding/makedrive/issues/events{/number}","events_url":"https://api.github.com/repos/alicoding/makedrive/events","assignees_url":"https://api.github.com/repos/alicoding/makedrive/assignees{/user}","branches_url":"https://api.github.com/repos/alicoding/makedrive/branches{/branch}","tags_url":"https://api.github.com/repos/alicoding/makedrive/tags","blobs_url":"https://api.github.com/repos/alicoding/makedrive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alicoding/makedrive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alicoding/makedrive/git/refs{/sha}","trees_url":"https://api.github.com/repos/alicoding/makedrive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alicoding/makedrive/statuses/{sha}","languages_url":"https://api.github.com/repos/alicoding/makedrive/languages","stargazers_url":"https://api.github.com/repos/alicoding/makedrive/stargazers","contributors_url":"https://api.github.com/repos/alicoding/makedrive/contributors","subscribers_url":"https://api.github.com/repos/alicoding/makedrive/subscribers","subscription_url":"https://api.github.com/repos/alicoding/makedrive/subscription","commits_url":"https://api.github.com/repos/alicoding/makedrive/commits{/sha}","git_commits_url":"https://api.github.com/repos/alicoding/makedrive/git/commits{/sha}","comments_url":"https://api.github.com/repos/alicoding/makedrive/comments{/number}","issue_comment_url":"https://api.github.com/repos/alicoding/makedrive/issues/comments/{number}","contents_url":"https://api.github.com/repos/alicoding/makedrive/contents/{+path}","compare_url":"https://api.github.com/repos/alicoding/makedrive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alicoding/makedrive/merges","archive_url":"https://api.github.com/repos/alicoding/makedrive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alicoding/makedrive/downloads","issues_url":"https://api.github.com/repos/alicoding/makedrive/issues{/number}","pulls_url":"https://api.github.com/repos/alicoding/makedrive/pulls{/number}","milestones_url":"https://api.github.com/repos/alicoding/makedrive/milestones{/number}","notifications_url":"https://api.github.com/repos/alicoding/makedrive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alicoding/makedrive/labels{/name}","releases_url":"https://api.github.com/repos/alicoding/makedrive/releases{/id}","created_at":"2014-07-09T15:02:48Z","updated_at":"2014-07-10T14:28:23Z","pushed_at":"2014-11-11T00:26:06Z","git_url":"git://github.com/alicoding/makedrive.git","ssh_url":"git@github.com:alicoding/makedrive.git","clone_url":"https://github.com/alicoding/makedrive.git","svn_url":"https://github.com/alicoding/makedrive","homepage":null,"size":6145,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"c6eb90af28cf83c69db062c4eec9230901512213","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":18801832,"name":"makedrive","full_name":"mozilla/makedrive","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/makedrive","description":"Webmaker Filesystem","fork":false,"url":"https://api.github.com/repos/mozilla/makedrive","forks_url":"https://api.github.com/repos/mozilla/makedrive/forks","keys_url":"https://api.github.com/repos/mozilla/makedrive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/makedrive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/makedrive/teams","hooks_url":"https://api.github.com/repos/mozilla/makedrive/hooks","issue_events_url":"https://api.github.com/repos/mozilla/makedrive/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/makedrive/events","assignees_url":"https://api.github.com/repos/mozilla/makedrive/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/makedrive/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/makedrive/tags","blobs_url":"https://api.github.com/repos/mozilla/makedrive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/makedrive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/makedrive/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/makedrive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/makedrive/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/makedrive/languages","stargazers_url":"https://api.github.com/repos/mozilla/makedrive/stargazers","contributors_url":"https://api.github.com/repos/mozilla/makedrive/contributors","subscribers_url":"https://api.github.com/repos/mozilla/makedrive/subscribers","subscription_url":"https://api.github.com/repos/mozilla/makedrive/subscription","commits_url":"https://api.github.com/repos/mozilla/makedrive/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/makedrive/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/makedrive/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/makedrive/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/makedrive/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/makedrive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/makedrive/merges","archive_url":"https://api.github.com/repos/mozilla/makedrive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/makedrive/downloads","issues_url":"https://api.github.com/repos/mozilla/makedrive/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/makedrive/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/makedrive/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/makedrive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/makedrive/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/makedrive/releases{/id}","created_at":"2014-04-15T13:53:43Z","updated_at":"2014-11-10T18:06:37Z","pushed_at":"2014-11-06T21:59:57Z","git_url":"git://github.com/mozilla/makedrive.git","ssh_url":"git@github.com:mozilla/makedrive.git","clone_url":"https://github.com/mozilla/makedrive.git","svn_url":"https://github.com/mozilla/makedrive","homepage":null,"size":8713,"stargazers_count":325,"watchers_count":325,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":65,"forks":29,"open_issues":65,"watchers":325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/463"},"html":{"href":"https://github.com/mozilla/makedrive/pull/463"},"issue":{"href":"https://api.github.com/repos/mozilla/makedrive/issues/463"},"comments":{"href":"https://api.github.com/repos/mozilla/makedrive/issues/463/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/463/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/makedrive/pulls/463/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/makedrive/statuses/05ba065565587dbe7914ccd9d16b298a602bd38d"}}}}