GitHub PullRequestEvent at 2014-02-07 16:05:34
Repository: nn
Actor: andresy
Payload: {"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/torch/nn/pulls/2","id":11087850,"html_url":"https://github.com/torch/nn/pull/2","diff_url":"https://github.com/torch/nn/pull/2.diff","patch_url":"https://github.com/torch/nn/pull/2.patch","issue_url":"https://api.github.com/repos/torch/nn/issues/2","number":2,"state":"closed","title":"removed c89 restriction","user":{"login":"sigmike","id":28259,"avatar_url":"https://gravatar.com/avatar/352f3b19dfbfc17e7f7498dc2f658cac?d=https%3A%2F%2Fidenticons.github.com%2Ff60ce135766f04f6cff01c4f46b83812.png&r=x","gravatar_id":"352f3b19dfbfc17e7f7498dc2f658cac","url":"https://api.github.com/users/sigmike","html_url":"https://github.com/sigmike","followers_url":"https://api.github.com/users/sigmike/followers","following_url":"https://api.github.com/users/sigmike/following{/other_user}","gists_url":"https://api.github.com/users/sigmike/gists{/gist_id}","starred_url":"https://api.github.com/users/sigmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigmike/subscriptions","organizations_url":"https://api.github.com/users/sigmike/orgs","repos_url":"https://api.github.com/users/sigmike/repos","events_url":"https://api.github.com/users/sigmike/events{/privacy}","received_events_url":"https://api.github.com/users/sigmike/received_events","type":"User","site_admin":false},"body":"I had to remove the c89 restriction to make nn build.\r\nOtherwise I get this error:\r\n```\r\nIn file included from generic/THVector.c:1:0,\r\n                from /home/mike/.local/include/torch/TH/THVector.h:566,\r\n                from /home/mike/.local/include/torch/TH/TH.h:11,\r\n                from /home/mike/devel/nn/init.c:1:\r\n/home/mike/.local/include/torch/TH/generic/THVector.c:6:18: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘void’\r\n static TH_INLINE void THVector_(fill)(real *x, const real c, const long n) {\r\n```\r\n\r\nThe reason is torch was built without the c89 restriction, so `TH_INLINE` was defined to `inline` and used in `THVector.c`. In c89, the `inline` keyword doesn't seem to be recognized so it fails when nn is built.\r\n\r\nIs this c89 flag mandatory for nn?","created_at":"2013-12-25T18:00:40Z","updated_at":"2014-02-07T16:05:34Z","closed_at":"2014-02-07T16:05:34Z","merged_at":null,"merge_commit_sha":"e43020c4e0afbbbdc95e92cd5c88a5030bcfdb57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/torch/nn/pulls/2/commits","review_comments_url":"https://api.github.com/repos/torch/nn/pulls/2/comments","review_comment_url":"https://api.github.com/repos/torch/nn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/torch/nn/issues/2/comments","statuses_url":"https://api.github.com/repos/torch/nn/statuses/6da14f3305f3884e018532a54fc1f3cea40a5d9c","head":{"label":"sigmike:master","ref":"master","sha":"6da14f3305f3884e018532a54fc1f3cea40a5d9c","user":{"login":"sigmike","id":28259,"avatar_url":"https://gravatar.com/avatar/352f3b19dfbfc17e7f7498dc2f658cac?d=https%3A%2F%2Fidenticons.github.com%2Ff60ce135766f04f6cff01c4f46b83812.png&r=x","gravatar_id":"352f3b19dfbfc17e7f7498dc2f658cac","url":"https://api.github.com/users/sigmike","html_url":"https://github.com/sigmike","followers_url":"https://api.github.com/users/sigmike/followers","following_url":"https://api.github.com/users/sigmike/following{/other_user}","gists_url":"https://api.github.com/users/sigmike/gists{/gist_id}","starred_url":"https://api.github.com/users/sigmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigmike/subscriptions","organizations_url":"https://api.github.com/users/sigmike/orgs","repos_url":"https://api.github.com/users/sigmike/repos","events_url":"https://api.github.com/users/sigmike/events{/privacy}","received_events_url":"https://api.github.com/users/sigmike/received_events","type":"User","site_admin":false},"repo":{"id":15438549,"name":"nn","full_name":"sigmike/nn","owner":{"login":"sigmike","id":28259,"avatar_url":"https://gravatar.com/avatar/352f3b19dfbfc17e7f7498dc2f658cac?d=https%3A%2F%2Fidenticons.github.com%2Ff60ce135766f04f6cff01c4f46b83812.png&r=x","gravatar_id":"352f3b19dfbfc17e7f7498dc2f658cac","url":"https://api.github.com/users/sigmike","html_url":"https://github.com/sigmike","followers_url":"https://api.github.com/users/sigmike/followers","following_url":"https://api.github.com/users/sigmike/following{/other_user}","gists_url":"https://api.github.com/users/sigmike/gists{/gist_id}","starred_url":"https://api.github.com/users/sigmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigmike/subscriptions","organizations_url":"https://api.github.com/users/sigmike/orgs","repos_url":"https://api.github.com/users/sigmike/repos","events_url":"https://api.github.com/users/sigmike/events{/privacy}","received_events_url":"https://api.github.com/users/sigmike/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sigmike/nn","description":"","fork":true,"url":"https://api.github.com/repos/sigmike/nn","forks_url":"https://api.github.com/repos/sigmike/nn/forks","keys_url":"https://api.github.com/repos/sigmike/nn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sigmike/nn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sigmike/nn/teams","hooks_url":"https://api.github.com/repos/sigmike/nn/hooks","issue_events_url":"https://api.github.com/repos/sigmike/nn/issues/events{/number}","events_url":"https://api.github.com/repos/sigmike/nn/events","assignees_url":"https://api.github.com/repos/sigmike/nn/assignees{/user}","branches_url":"https://api.github.com/repos/sigmike/nn/branches{/branch}","tags_url":"https://api.github.com/repos/sigmike/nn/tags","blobs_url":"https://api.github.com/repos/sigmike/nn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sigmike/nn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sigmike/nn/git/refs{/sha}","trees_url":"https://api.github.com/repos/sigmike/nn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sigmike/nn/statuses/{sha}","languages_url":"https://api.github.com/repos/sigmike/nn/languages","stargazers_url":"https://api.github.com/repos/sigmike/nn/stargazers","contributors_url":"https://api.github.com/repos/sigmike/nn/contributors","subscribers_url":"https://api.github.com/repos/sigmike/nn/subscribers","subscription_url":"https://api.github.com/repos/sigmike/nn/subscription","commits_url":"https://api.github.com/repos/sigmike/nn/commits{/sha}","git_commits_url":"https://api.github.com/repos/sigmike/nn/git/commits{/sha}","comments_url":"https://api.github.com/repos/sigmike/nn/comments{/number}","issue_comment_url":"https://api.github.com/repos/sigmike/nn/issues/comments/{number}","contents_url":"https://api.github.com/repos/sigmike/nn/contents/{+path}","compare_url":"https://api.github.com/repos/sigmike/nn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sigmike/nn/merges","archive_url":"https://api.github.com/repos/sigmike/nn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sigmike/nn/downloads","issues_url":"https://api.github.com/repos/sigmike/nn/issues{/number}","pulls_url":"https://api.github.com/repos/sigmike/nn/pulls{/number}","milestones_url":"https://api.github.com/repos/sigmike/nn/milestones{/number}","notifications_url":"https://api.github.com/repos/sigmike/nn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sigmike/nn/labels{/name}","releases_url":"https://api.github.com/repos/sigmike/nn/releases{/id}","created_at":"2013-12-25T17:52:54Z","updated_at":"2014-02-07T16:05:34Z","pushed_at":"2013-12-25T17:53:21Z","git_url":"git://github.com/sigmike/nn.git","ssh_url":"git@github.com:sigmike/nn.git","clone_url":"https://github.com/sigmike/nn.git","svn_url":"https://github.com/sigmike/nn","homepage":null,"size":426,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"torch:master","ref":"master","sha":"b55dbaa78b80b3845498001895bb8f1d9fa3f579","user":{"login":"torch","id":4978924,"avatar_url":"https://gravatar.com/avatar/26967197c3dd8dc0a7a5bf89e3c6550b?d=https%3A%2F%2Fidenticons.github.com%2Fe9fee491d2a483ca6eb386bbc8042c30.png&r=x","gravatar_id":"26967197c3dd8dc0a7a5bf89e3c6550b","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"repo":{"id":13677447,"name":"nn","full_name":"torch/nn","owner":{"login":"torch","id":4978924,"avatar_url":"https://gravatar.com/avatar/26967197c3dd8dc0a7a5bf89e3c6550b?d=https%3A%2F%2Fidenticons.github.com%2Fe9fee491d2a483ca6eb386bbc8042c30.png&r=x","gravatar_id":"26967197c3dd8dc0a7a5bf89e3c6550b","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/torch/nn","description":"","fork":false,"url":"https://api.github.com/repos/torch/nn","forks_url":"https://api.github.com/repos/torch/nn/forks","keys_url":"https://api.github.com/repos/torch/nn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torch/nn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torch/nn/teams","hooks_url":"https://api.github.com/repos/torch/nn/hooks","issue_events_url":"https://api.github.com/repos/torch/nn/issues/events{/number}","events_url":"https://api.github.com/repos/torch/nn/events","assignees_url":"https://api.github.com/repos/torch/nn/assignees{/user}","branches_url":"https://api.github.com/repos/torch/nn/branches{/branch}","tags_url":"https://api.github.com/repos/torch/nn/tags","blobs_url":"https://api.github.com/repos/torch/nn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torch/nn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torch/nn/git/refs{/sha}","trees_url":"https://api.github.com/repos/torch/nn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torch/nn/statuses/{sha}","languages_url":"https://api.github.com/repos/torch/nn/languages","stargazers_url":"https://api.github.com/repos/torch/nn/stargazers","contributors_url":"https://api.github.com/repos/torch/nn/contributors","subscribers_url":"https://api.github.com/repos/torch/nn/subscribers","subscription_url":"https://api.github.com/repos/torch/nn/subscription","commits_url":"https://api.github.com/repos/torch/nn/commits{/sha}","git_commits_url":"https://api.github.com/repos/torch/nn/git/commits{/sha}","comments_url":"https://api.github.com/repos/torch/nn/comments{/number}","issue_comment_url":"https://api.github.com/repos/torch/nn/issues/comments/{number}","contents_url":"https://api.github.com/repos/torch/nn/contents/{+path}","compare_url":"https://api.github.com/repos/torch/nn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torch/nn/merges","archive_url":"https://api.github.com/repos/torch/nn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torch/nn/downloads","issues_url":"https://api.github.com/repos/torch/nn/issues{/number}","pulls_url":"https://api.github.com/repos/torch/nn/pulls{/number}","milestones_url":"https://api.github.com/repos/torch/nn/milestones{/number}","notifications_url":"https://api.github.com/repos/torch/nn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torch/nn/labels{/name}","releases_url":"https://api.github.com/repos/torch/nn/releases{/id}","created_at":"2013-10-18T12:27:25Z","updated_at":"2014-02-07T16:05:23Z","pushed_at":"2014-02-07T16:05:34Z","git_url":"git://github.com/torch/nn.git","ssh_url":"git@github.com:torch/nn.git","clone_url":"https://github.com/torch/nn.git","svn_url":"https://github.com/torch/nn","homepage":null,"size":460,"stargazers_count":3,"watchers_count":3,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":3,"default_branch":"legacy","master_branch":"legacy"}},"_links":{"self":{"href":"https://api.github.com/repos/torch/nn/pulls/2"},"html":{"href":"https://github.com/torch/nn/pull/2"},"issue":{"href":"https://api.github.com/repos/torch/nn/issues/2"},"comments":{"href":"https://api.github.com/repos/torch/nn/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/torch/nn/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/torch/nn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/torch/nn/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/torch/nn/statuses/6da14f3305f3884e018532a54fc1f3cea40a5d9c"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":5,"additions":18,"deletions":2,"changed_files":2}}