GitHub PullRequestReviewCommentEvent at 2014-12-15 22:17:04
Repository: jclouds-labs
Actor: nacx
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments/21861967","id":21861967,"diff_hunk":"@@ -0,0 +1,92 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.jclouds.shipyard;\n+\n+import com.google.auto.service.AutoService;\n+import com.google.common.collect.ImmutableSet;\n+import com.google.inject.Module;\n+\n+import org.jclouds.Constants;\n+import org.jclouds.apis.ApiMetadata;\n+import org.jclouds.compute.ComputeServiceContext;\n+import org.jclouds.http.okhttp.config.OkHttpCommandExecutorServiceModule;\n+import org.jclouds.rest.internal.BaseHttpApiMetadata;\n+import org.jclouds.shipyard.config.ShipyardHttpApiModule;\n+import org.jclouds.shipyard.config.ShipyardProperties;\n+\n+import java.net.URI;\n+import java.util.Properties;\n+\n+import static org.jclouds.reflect.Reflection2.typeToken;\n+\n+@AutoService(ApiMetadata.class)\n+public class ShipyardApiMetadata extends BaseHttpApiMetadata<ShipyardApi> {\n+\n+   @Override\n+   public Builder toBuilder() {\n+      return new Builder().fromApiMetadata(this);\n+   }\n+\n+   public ShipyardApiMetadata() {\n+      this(new Builder());\n+   }\n+\n+   protected ShipyardApiMetadata(Builder builder) {\n+      super(builder);\n+   }\n+\n+   public static Properties defaultProperties() {\n+      Properties properties = BaseHttpApiMetadata.defaultProperties();\n+      properties.setProperty(Constants.PROPERTY_MAX_RETRIES, \"5\");\n+      properties.setProperty(ShipyardProperties.SHIPYARD_CREDENTIAL, \"<remote-service-key-given-by-shipyard-cli>\");\n+      return properties;\n+   }\n+\n+   public static class Builder extends BaseHttpApiMetadata.Builder<ShipyardApi, Builder> {\n+\n+      protected Builder() {\n+         super(ShipyardApi.class);\n+         id(\"shipyard\")\n+           .name(\"Shipyard Remote Docker Management API\")\n+           .identityName(\"<service-key>\")\n+           .credentialName(null)","path":"shipyard/src/main/java/org/jclouds/shipyard/ShipyardApiMetadata.java","position":66,"original_position":66,"commit_id":"b7de04216246b47578ce1f39af5f3e97637472a8","original_commit_id":"b7de04216246b47578ce1f39af5f3e97637472a8","user":{"login":"nacx","id":446705,"avatar_url":"https://avatars.githubusercontent.com/u/446705?v=3","gravatar_id":"","url":"https://api.github.com/users/nacx","html_url":"https://github.com/nacx","followers_url":"https://api.github.com/users/nacx/followers","following_url":"https://api.github.com/users/nacx/following{/other_user}","gists_url":"https://api.github.com/users/nacx/gists{/gist_id}","starred_url":"https://api.github.com/users/nacx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nacx/subscriptions","organizations_url":"https://api.github.com/users/nacx/orgs","repos_url":"https://api.github.com/users/nacx/repos","events_url":"https://api.github.com/users/nacx/events{/privacy}","received_events_url":"https://api.github.com/users/nacx/received_events","type":"User","site_admin":false},"body":"This should *describe* the credential. If no credential is needed, just say something like \"not used\" or so, but don't leave this `null`.","created_at":"2014-12-15T22:17:04Z","updated_at":"2014-12-15T22:17:04Z","html_url":"https://github.com/jclouds/jclouds-labs/pull/116#discussion_r21861967","pull_request_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments/21861967"},"html":{"href":"https://github.com/jclouds/jclouds-labs/pull/116#discussion_r21861967"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/116","id":25931970,"html_url":"https://github.com/jclouds/jclouds-labs/pull/116","diff_url":"https://github.com/jclouds/jclouds-labs/pull/116.diff","patch_url":"https://github.com/jclouds/jclouds-labs/pull/116.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/116","number":116,"state":"open","locked":false,"title":"JCLOUDS-782: init for shipyard provider","user":{"login":"cdancy","id":7871459,"avatar_url":"https://avatars.githubusercontent.com/u/7871459?v=3","gravatar_id":"","url":"https://api.github.com/users/cdancy","html_url":"https://github.com/cdancy","followers_url":"https://api.github.com/users/cdancy/followers","following_url":"https://api.github.com/users/cdancy/following{/other_user}","gists_url":"https://api.github.com/users/cdancy/gists{/gist_id}","starred_url":"https://api.github.com/users/cdancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdancy/subscriptions","organizations_url":"https://api.github.com/users/cdancy/orgs","repos_url":"https://api.github.com/users/cdancy/repos","events_url":"https://api.github.com/users/cdancy/events{/privacy}","received_events_url":"https://api.github.com/users/cdancy/received_events","type":"User","site_admin":false},"body":"Initial commit for shipyard provider. My intent was to have the entire provider coded and in something like \"good working shape\" before I submitted a PR but @nacx strongly suggested I not do this.\r\n\r\nThis code base is a fork of the work @andreaturli is doing with docker so there may be more than a few similarities. Shipyard itself is essentially a docker manager allowing users to connect N number of engines (docker daemons) to a single source allowing you to work with them from a single location. A few points to note:\r\n\r\n-There are literally no testers at this point. Working on this...\r\n-Around 10 files or so are json that gets handed back from shipyard. Used for testing purposes and do not need to be looked over.\r\n-The idea here is to implement the entirety of ComputeServiceAdapter. All methods except 'createNodeWithGroupIntoName' have been coded. Working on this...\r\n-All 'listNodes*' methods are being ignored. Not entirely sure why...\r\n\r\nshipyard API can be found here: http://shipyard-project.com/docs/api/\r\n\r\nSo with that said please take a peek and let me know what you think!","created_at":"2014-12-11T21:06:20Z","updated_at":"2014-12-15T22:17:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d902fabbddbf2df314d2f008318b8ea12161a528","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/116/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/116/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/116/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs/statuses/b7de04216246b47578ce1f39af5f3e97637472a8","head":{"label":"cdancy:JCLOUDS-782","ref":"JCLOUDS-782","sha":"b7de04216246b47578ce1f39af5f3e97637472a8","user":{"login":"cdancy","id":7871459,"avatar_url":"https://avatars.githubusercontent.com/u/7871459?v=3","gravatar_id":"","url":"https://api.github.com/users/cdancy","html_url":"https://github.com/cdancy","followers_url":"https://api.github.com/users/cdancy/followers","following_url":"https://api.github.com/users/cdancy/following{/other_user}","gists_url":"https://api.github.com/users/cdancy/gists{/gist_id}","starred_url":"https://api.github.com/users/cdancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdancy/subscriptions","organizations_url":"https://api.github.com/users/cdancy/orgs","repos_url":"https://api.github.com/users/cdancy/repos","events_url":"https://api.github.com/users/cdancy/events{/privacy}","received_events_url":"https://api.github.com/users/cdancy/received_events","type":"User","site_admin":false},"repo":{"id":26974779,"name":"jclouds-labs","full_name":"cdancy/jclouds-labs","owner":{"login":"cdancy","id":7871459,"avatar_url":"https://avatars.githubusercontent.com/u/7871459?v=3","gravatar_id":"","url":"https://api.github.com/users/cdancy","html_url":"https://github.com/cdancy","followers_url":"https://api.github.com/users/cdancy/followers","following_url":"https://api.github.com/users/cdancy/following{/other_user}","gists_url":"https://api.github.com/users/cdancy/gists{/gist_id}","starred_url":"https://api.github.com/users/cdancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdancy/subscriptions","organizations_url":"https://api.github.com/users/cdancy/orgs","repos_url":"https://api.github.com/users/cdancy/repos","events_url":"https://api.github.com/users/cdancy/events{/privacy}","received_events_url":"https://api.github.com/users/cdancy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdancy/jclouds-labs","description":"Read-only mirror of ASF Git Repo for jclouds labs","fork":true,"url":"https://api.github.com/repos/cdancy/jclouds-labs","forks_url":"https://api.github.com/repos/cdancy/jclouds-labs/forks","keys_url":"https://api.github.com/repos/cdancy/jclouds-labs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdancy/jclouds-labs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdancy/jclouds-labs/teams","hooks_url":"https://api.github.com/repos/cdancy/jclouds-labs/hooks","issue_events_url":"https://api.github.com/repos/cdancy/jclouds-labs/issues/events{/number}","events_url":"https://api.github.com/repos/cdancy/jclouds-labs/events","assignees_url":"https://api.github.com/repos/cdancy/jclouds-labs/assignees{/user}","branches_url":"https://api.github.com/repos/cdancy/jclouds-labs/branches{/branch}","tags_url":"https://api.github.com/repos/cdancy/jclouds-labs/tags","blobs_url":"https://api.github.com/repos/cdancy/jclouds-labs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdancy/jclouds-labs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdancy/jclouds-labs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdancy/jclouds-labs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdancy/jclouds-labs/statuses/{sha}","languages_url":"https://api.github.com/repos/cdancy/jclouds-labs/languages","stargazers_url":"https://api.github.com/repos/cdancy/jclouds-labs/stargazers","contributors_url":"https://api.github.com/repos/cdancy/jclouds-labs/contributors","subscribers_url":"https://api.github.com/repos/cdancy/jclouds-labs/subscribers","subscription_url":"https://api.github.com/repos/cdancy/jclouds-labs/subscription","commits_url":"https://api.github.com/repos/cdancy/jclouds-labs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdancy/jclouds-labs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdancy/jclouds-labs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdancy/jclouds-labs/issues/comments/{number}","contents_url":"https://api.github.com/repos/cdancy/jclouds-labs/contents/{+path}","compare_url":"https://api.github.com/repos/cdancy/jclouds-labs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdancy/jclouds-labs/merges","archive_url":"https://api.github.com/repos/cdancy/jclouds-labs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdancy/jclouds-labs/downloads","issues_url":"https://api.github.com/repos/cdancy/jclouds-labs/issues{/number}","pulls_url":"https://api.github.com/repos/cdancy/jclouds-labs/pulls{/number}","milestones_url":"https://api.github.com/repos/cdancy/jclouds-labs/milestones{/number}","notifications_url":"https://api.github.com/repos/cdancy/jclouds-labs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdancy/jclouds-labs/labels{/name}","releases_url":"https://api.github.com/repos/cdancy/jclouds-labs/releases{/id}","created_at":"2014-11-21T19:33:37Z","updated_at":"2014-11-21T19:33:39Z","pushed_at":"2014-12-12T15:24:48Z","git_url":"git://github.com/cdancy/jclouds-labs.git","ssh_url":"git@github.com:cdancy/jclouds-labs.git","clone_url":"https://github.com/cdancy/jclouds-labs.git","svn_url":"https://github.com/cdancy/jclouds-labs","homepage":null,"size":29065,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jclouds:master","ref":"master","sha":"1b689dc17ff1cc78e981ca87e13094b47109d3fa","user":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10040970,"name":"jclouds-labs","full_name":"jclouds/jclouds-labs","owner":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds-labs","description":"Read-only mirror of ASF Git Repo for jclouds labs","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds-labs","forks_url":"https://api.github.com/repos/jclouds/jclouds-labs/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds-labs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds-labs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds-labs/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds-labs/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds-labs/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds-labs/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds-labs/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds-labs/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds-labs/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds-labs/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds-labs/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds-labs/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds-labs/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds-labs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/comments/{number}","contents_url":"https://api.github.com/repos/jclouds/jclouds-labs/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds-labs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds-labs/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds-labs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds-labs/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds-labs/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds-labs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds-labs/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds-labs/releases{/id}","created_at":"2013-05-13T20:47:47Z","updated_at":"2014-12-10T02:57:17Z","pushed_at":"2014-11-27T14:32:53Z","git_url":"git://github.com/jclouds/jclouds-labs.git","ssh_url":"git@github.com:jclouds/jclouds-labs.git","clone_url":"https://github.com/jclouds/jclouds-labs.git","svn_url":"https://github.com/jclouds/jclouds-labs","homepage":null,"size":27819,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":5,"forks":53,"open_issues":5,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/116"},"html":{"href":"https://github.com/jclouds/jclouds-labs/pull/116"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/issues/116"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/statuses/b7de04216246b47578ce1f39af5f3e97637472a8"}}}}