GitHub PullRequestReviewCommentEvent at 2014-11-26 18:38:18
Repository: floating-action-button
Actor: maniac103
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/shamanland/floating-action-button/pulls/comments/20954472","id":20954472,"diff_hunk":"@@ -217,8 +222,19 @@ public void initBackground() {\n                 Drawable shadow = layers.getDrawable(0);\n                 Drawable circle = layers.getDrawable(1);\n \n-                if (shadow instanceof GradientDrawable) {\n-                    ((GradientDrawable) shadow.mutate()).setGradientRadius(getShadowRadius(shadow, circle));\n+                if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) {\n+                    if (shadow instanceof GradientDrawable) {\n+                        ((GradientDrawable) shadow.mutate()).setGradientRadius(getShadowRadius(shadow, circle));\n+                    }\n+                } else {\n+                    setOutlineProvider(new ViewOutlineProvider() {\n+                        @Override\n+                        public void getOutline(View view, Outline outline) {\n+                            circle.getOutline(outline);\n+                        }\n+                    });\n+                    shadow.setAlpha(0);","path":"lib/src/main/java/com/shamanland/fab/FloatingActionButton.java","position":46,"original_position":46,"commit_id":"422096785886cfce83a1cda965dfa5d228e7181a","original_commit_id":"422096785886cfce83a1cda965dfa5d228e7181a","user":{"login":"maniac103","id":781373,"avatar_url":"https://avatars.githubusercontent.com/u/781373?v=3","gravatar_id":"","url":"https://api.github.com/users/maniac103","html_url":"https://github.com/maniac103","followers_url":"https://api.github.com/users/maniac103/followers","following_url":"https://api.github.com/users/maniac103/following{/other_user}","gists_url":"https://api.github.com/users/maniac103/gists{/gist_id}","starred_url":"https://api.github.com/users/maniac103/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniac103/subscriptions","organizations_url":"https://api.github.com/users/maniac103/orgs","repos_url":"https://api.github.com/users/maniac103/repos","events_url":"https://api.github.com/users/maniac103/events{/privacy}","received_events_url":"https://api.github.com/users/maniac103/received_events","type":"User","site_admin":false},"body":"It shouldn't. AFAICT the circle defines the FAB size.\n\nBTW, it might be even worth a thought to just do setBackground(circle) on API 21+ - doing so will likely remove the need for the outline provider.","created_at":"2014-11-26T18:38:18Z","updated_at":"2014-11-26T18:38:18Z","html_url":"https://github.com/shamanland/floating-action-button/pull/11#discussion_r20954472","pull_request_url":"https://api.github.com/repos/shamanland/floating-action-button/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/shamanland/floating-action-button/pulls/comments/20954472"},"html":{"href":"https://github.com/shamanland/floating-action-button/pull/11#discussion_r20954472"},"pull_request":{"href":"https://api.github.com/repos/shamanland/floating-action-button/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/shamanland/floating-action-button/pulls/11","id":25104664,"html_url":"https://github.com/shamanland/floating-action-button/pull/11","diff_url":"https://github.com/shamanland/floating-action-button/pull/11.diff","patch_url":"https://github.com/shamanland/floating-action-button/pull/11.patch","issue_url":"https://api.github.com/repos/shamanland/floating-action-button/issues/11","number":11,"state":"open","locked":false,"title":"Handle elevation on API 21 devices","user":{"login":"jendib","id":2623413,"avatar_url":"https://avatars.githubusercontent.com/u/2623413?v=3","gravatar_id":"","url":"https://api.github.com/users/jendib","html_url":"https://github.com/jendib","followers_url":"https://api.github.com/users/jendib/followers","following_url":"https://api.github.com/users/jendib/following{/other_user}","gists_url":"https://api.github.com/users/jendib/gists{/gist_id}","starred_url":"https://api.github.com/users/jendib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jendib/subscriptions","organizations_url":"https://api.github.com/users/jendib/orgs","repos_url":"https://api.github.com/users/jendib/repos","events_url":"https://api.github.com/users/jendib/events{/privacy}","received_events_url":"https://api.github.com/users/jendib/received_events","type":"User","site_admin":false},"body":"It's not overly clean, feel free to rework it if necessary, but I managed to get a shadow similar to Google apps.","created_at":"2014-11-26T18:28:10Z","updated_at":"2014-11-26T18:38:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"332e2d0e48b6b5c4f2001c5cc106b9d9bd6a35d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shamanland/floating-action-button/pulls/11/commits","review_comments_url":"https://api.github.com/repos/shamanland/floating-action-button/pulls/11/comments","review_comment_url":"https://api.github.com/repos/shamanland/floating-action-button/pulls/comments/{number}","comments_url":"https://api.github.com/repos/shamanland/floating-action-button/issues/11/comments","statuses_url":"https://api.github.com/repos/shamanland/floating-action-button/statuses/422096785886cfce83a1cda965dfa5d228e7181a","head":{"label":"jendib:patch-1","ref":"patch-1","sha":"422096785886cfce83a1cda965dfa5d228e7181a","user":{"login":"jendib","id":2623413,"avatar_url":"https://avatars.githubusercontent.com/u/2623413?v=3","gravatar_id":"","url":"https://api.github.com/users/jendib","html_url":"https://github.com/jendib","followers_url":"https://api.github.com/users/jendib/followers","following_url":"https://api.github.com/users/jendib/following{/other_user}","gists_url":"https://api.github.com/users/jendib/gists{/gist_id}","starred_url":"https://api.github.com/users/jendib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jendib/subscriptions","organizations_url":"https://api.github.com/users/jendib/orgs","repos_url":"https://api.github.com/users/jendib/repos","events_url":"https://api.github.com/users/jendib/events{/privacy}","received_events_url":"https://api.github.com/users/jendib/received_events","type":"User","site_admin":false},"repo":{"id":27190261,"name":"floating-action-button","full_name":"jendib/floating-action-button","owner":{"login":"jendib","id":2623413,"avatar_url":"https://avatars.githubusercontent.com/u/2623413?v=3","gravatar_id":"","url":"https://api.github.com/users/jendib","html_url":"https://github.com/jendib","followers_url":"https://api.github.com/users/jendib/followers","following_url":"https://api.github.com/users/jendib/following{/other_user}","gists_url":"https://api.github.com/users/jendib/gists{/gist_id}","starred_url":"https://api.github.com/users/jendib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jendib/subscriptions","organizations_url":"https://api.github.com/users/jendib/orgs","repos_url":"https://api.github.com/users/jendib/repos","events_url":"https://api.github.com/users/jendib/events{/privacy}","received_events_url":"https://api.github.com/users/jendib/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jendib/floating-action-button","description":"Implementation of a circular button made of paper that lifts and emits ink reactions on press.","fork":true,"url":"https://api.github.com/repos/jendib/floating-action-button","forks_url":"https://api.github.com/repos/jendib/floating-action-button/forks","keys_url":"https://api.github.com/repos/jendib/floating-action-button/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jendib/floating-action-button/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jendib/floating-action-button/teams","hooks_url":"https://api.github.com/repos/jendib/floating-action-button/hooks","issue_events_url":"https://api.github.com/repos/jendib/floating-action-button/issues/events{/number}","events_url":"https://api.github.com/repos/jendib/floating-action-button/events","assignees_url":"https://api.github.com/repos/jendib/floating-action-button/assignees{/user}","branches_url":"https://api.github.com/repos/jendib/floating-action-button/branches{/branch}","tags_url":"https://api.github.com/repos/jendib/floating-action-button/tags","blobs_url":"https://api.github.com/repos/jendib/floating-action-button/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jendib/floating-action-button/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jendib/floating-action-button/git/refs{/sha}","trees_url":"https://api.github.com/repos/jendib/floating-action-button/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jendib/floating-action-button/statuses/{sha}","languages_url":"https://api.github.com/repos/jendib/floating-action-button/languages","stargazers_url":"https://api.github.com/repos/jendib/floating-action-button/stargazers","contributors_url":"https://api.github.com/repos/jendib/floating-action-button/contributors","subscribers_url":"https://api.github.com/repos/jendib/floating-action-button/subscribers","subscription_url":"https://api.github.com/repos/jendib/floating-action-button/subscription","commits_url":"https://api.github.com/repos/jendib/floating-action-button/commits{/sha}","git_commits_url":"https://api.github.com/repos/jendib/floating-action-button/git/commits{/sha}","comments_url":"https://api.github.com/repos/jendib/floating-action-button/comments{/number}","issue_comment_url":"https://api.github.com/repos/jendib/floating-action-button/issues/comments/{number}","contents_url":"https://api.github.com/repos/jendib/floating-action-button/contents/{+path}","compare_url":"https://api.github.com/repos/jendib/floating-action-button/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jendib/floating-action-button/merges","archive_url":"https://api.github.com/repos/jendib/floating-action-button/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jendib/floating-action-button/downloads","issues_url":"https://api.github.com/repos/jendib/floating-action-button/issues{/number}","pulls_url":"https://api.github.com/repos/jendib/floating-action-button/pulls{/number}","milestones_url":"https://api.github.com/repos/jendib/floating-action-button/milestones{/number}","notifications_url":"https://api.github.com/repos/jendib/floating-action-button/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jendib/floating-action-button/labels{/name}","releases_url":"https://api.github.com/repos/jendib/floating-action-button/releases{/id}","created_at":"2014-11-26T18:25:01Z","updated_at":"2014-11-26T18:25:02Z","pushed_at":"2014-11-26T18:28:02Z","git_url":"git://github.com/jendib/floating-action-button.git","ssh_url":"git@github.com:jendib/floating-action-button.git","clone_url":"https://github.com/jendib/floating-action-button.git","svn_url":"https://github.com/jendib/floating-action-button","homepage":"http://shamanland.github.io/floating-action-button","size":307,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shamanland:master","ref":"master","sha":"7a1d2b44cabc9a02aa700698bde9262157245e56","user":{"login":"shamanland","id":1835811,"avatar_url":"https://avatars.githubusercontent.com/u/1835811?v=3","gravatar_id":"","url":"https://api.github.com/users/shamanland","html_url":"https://github.com/shamanland","followers_url":"https://api.github.com/users/shamanland/followers","following_url":"https://api.github.com/users/shamanland/following{/other_user}","gists_url":"https://api.github.com/users/shamanland/gists{/gist_id}","starred_url":"https://api.github.com/users/shamanland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamanland/subscriptions","organizations_url":"https://api.github.com/users/shamanland/orgs","repos_url":"https://api.github.com/users/shamanland/repos","events_url":"https://api.github.com/users/shamanland/events{/privacy}","received_events_url":"https://api.github.com/users/shamanland/received_events","type":"Organization","site_admin":false},"repo":{"id":22543774,"name":"floating-action-button","full_name":"shamanland/floating-action-button","owner":{"login":"shamanland","id":1835811,"avatar_url":"https://avatars.githubusercontent.com/u/1835811?v=3","gravatar_id":"","url":"https://api.github.com/users/shamanland","html_url":"https://github.com/shamanland","followers_url":"https://api.github.com/users/shamanland/followers","following_url":"https://api.github.com/users/shamanland/following{/other_user}","gists_url":"https://api.github.com/users/shamanland/gists{/gist_id}","starred_url":"https://api.github.com/users/shamanland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamanland/subscriptions","organizations_url":"https://api.github.com/users/shamanland/orgs","repos_url":"https://api.github.com/users/shamanland/repos","events_url":"https://api.github.com/users/shamanland/events{/privacy}","received_events_url":"https://api.github.com/users/shamanland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shamanland/floating-action-button","description":"Implementation of a circular button made of paper that lifts and emits ink reactions on press.","fork":false,"url":"https://api.github.com/repos/shamanland/floating-action-button","forks_url":"https://api.github.com/repos/shamanland/floating-action-button/forks","keys_url":"https://api.github.com/repos/shamanland/floating-action-button/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shamanland/floating-action-button/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shamanland/floating-action-button/teams","hooks_url":"https://api.github.com/repos/shamanland/floating-action-button/hooks","issue_events_url":"https://api.github.com/repos/shamanland/floating-action-button/issues/events{/number}","events_url":"https://api.github.com/repos/shamanland/floating-action-button/events","assignees_url":"https://api.github.com/repos/shamanland/floating-action-button/assignees{/user}","branches_url":"https://api.github.com/repos/shamanland/floating-action-button/branches{/branch}","tags_url":"https://api.github.com/repos/shamanland/floating-action-button/tags","blobs_url":"https://api.github.com/repos/shamanland/floating-action-button/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shamanland/floating-action-button/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shamanland/floating-action-button/git/refs{/sha}","trees_url":"https://api.github.com/repos/shamanland/floating-action-button/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shamanland/floating-action-button/statuses/{sha}","languages_url":"https://api.github.com/repos/shamanland/floating-action-button/languages","stargazers_url":"https://api.github.com/repos/shamanland/floating-action-button/stargazers","contributors_url":"https://api.github.com/repos/shamanland/floating-action-button/contributors","subscribers_url":"https://api.github.com/repos/shamanland/floating-action-button/subscribers","subscription_url":"https://api.github.com/repos/shamanland/floating-action-button/subscription","commits_url":"https://api.github.com/repos/shamanland/floating-action-button/commits{/sha}","git_commits_url":"https://api.github.com/repos/shamanland/floating-action-button/git/commits{/sha}","comments_url":"https://api.github.com/repos/shamanland/floating-action-button/comments{/number}","issue_comment_url":"https://api.github.com/repos/shamanland/floating-action-button/issues/comments/{number}","contents_url":"https://api.github.com/repos/shamanland/floating-action-button/contents/{+path}","compare_url":"https://api.github.com/repos/shamanland/floating-action-button/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shamanland/floating-action-button/merges","archive_url":"https://api.github.com/repos/shamanland/floating-action-button/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shamanland/floating-action-button/downloads","issues_url":"https://api.github.com/repos/shamanland/floating-action-button/issues{/number}","pulls_url":"https://api.github.com/repos/shamanland/floating-action-button/pulls{/number}","milestones_url":"https://api.github.com/repos/shamanland/floating-action-button/milestones{/number}","notifications_url":"https://api.github.com/repos/shamanland/floating-action-button/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shamanland/floating-action-button/labels{/name}","releases_url":"https://api.github.com/repos/shamanland/floating-action-button/releases{/id}","created_at":"2014-08-02T10:08:35Z","updated_at":"2014-11-26T12:52:31Z","pushed_at":"2014-09-16T09:40:32Z","git_url":"git://github.com/shamanland/floating-action-button.git","ssh_url":"git@github.com:shamanland/floating-action-button.git","clone_url":"https://github.com/shamanland/floating-action-button.git","svn_url":"https://github.com/shamanland/floating-action-button","homepage":"http://shamanland.github.io/floating-action-button","size":508,"stargazers_count":165,"watchers_count":165,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":3,"forks":27,"open_issues":3,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shamanland/floating-action-button/pulls/11"},"html":{"href":"https://github.com/shamanland/floating-action-button/pull/11"},"issue":{"href":"https://api.github.com/repos/shamanland/floating-action-button/issues/11"},"comments":{"href":"https://api.github.com/repos/shamanland/floating-action-button/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/shamanland/floating-action-button/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/shamanland/floating-action-button/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/shamanland/floating-action-button/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/shamanland/floating-action-button/statuses/422096785886cfce83a1cda965dfa5d228e7181a"}}}}