GitHub PullRequestReviewCommentEvent at 2014-11-09 15:54:55
Repository: homebrew
Actor: mikemcquaid
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/20059508","id":20059508,"diff_hunk":"@@ -14,25 +14,44 @@ class CrosstoolNg < Formula\n   depends_on 'gawk'\n   depends_on 'binutils'\n   depends_on 'libelf'\n+  depends_on 'homebrew/dupes/grep' => :optional\n+  depends_on 'homebrew/dupes/make' => :optional\n \n   # Avoid superenv to prevent https://github.com/mxcl/homebrew/pull/10552#issuecomment-9736248\n   env :std\n \n-  # Fixes clang offsetof compatability. Took better patch from #14547\n-  patch :DATA\n+  # Patch to fix clang offsetof. Can be removed when adopted upstream.\n+  patch do\n+    url \"http://patchwork.ozlabs.org/patch/400328/raw/\"\n+    sha1 \"0baca77c863e6876f6fb1838db9e5cb60c6fe89c\"\n+  end\n+\n+  # Patch to make regex BSD grep compatible. Can be removed when adopted upstream.","path":"Library/Formula/crosstool-ng.rb","position":29,"original_position":29,"commit_id":"89feb302a9b3276640a3e419dc0b06b36052234b","original_commit_id":"89feb302a9b3276640a3e419dc0b06b36052234b","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"body":"Please link to the upstream patch submission as a Ruby comment here.","created_at":"2014-11-09T15:54:55Z","updated_at":"2014-11-09T15:54:55Z","html_url":"https://github.com/Homebrew/homebrew/pull/32884#discussion_r20059508","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/32884","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/20059508"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/32884#discussion_r20059508"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/32884"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/32884","id":22169279,"html_url":"https://github.com/Homebrew/homebrew/pull/32884","diff_url":"https://github.com/Homebrew/homebrew/pull/32884.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/32884.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/32884","number":32884,"state":"open","locked":false,"title":"Add crosstool-ng compile options for GNU variants of grep & make","user":{"login":"jasmas","id":6385332,"avatar_url":"https://avatars.githubusercontent.com/u/6385332?v=3","gravatar_id":"","url":"https://api.github.com/users/jasmas","html_url":"https://github.com/jasmas","followers_url":"https://api.github.com/users/jasmas/followers","following_url":"https://api.github.com/users/jasmas/following{/other_user}","gists_url":"https://api.github.com/users/jasmas/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmas/subscriptions","organizations_url":"https://api.github.com/users/jasmas/orgs","repos_url":"https://api.github.com/users/jasmas/repos","events_url":"https://api.github.com/users/jasmas/events{/privacy}","received_events_url":"https://api.github.com/users/jasmas/received_events","type":"User","site_admin":false},"body":"For building some toolchains with crosstool-ng, newer versions of the GNU variants of make and grep may be required. These changes add the optional requirements out of dupes and pass the path to the GNU executable to crosstool's configure script.","created_at":"2014-10-02T20:50:59Z","updated_at":"2014-11-09T15:54:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02aacea94a0df0bf83bd6597cc572bc64d33993f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/32884/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/32884/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/32884/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/89feb302a9b3276640a3e419dc0b06b36052234b","head":{"label":"jasmas:ctng-gnu-fix","ref":"ctng-gnu-fix","sha":"89feb302a9b3276640a3e419dc0b06b36052234b","user":{"login":"jasmas","id":6385332,"avatar_url":"https://avatars.githubusercontent.com/u/6385332?v=3","gravatar_id":"","url":"https://api.github.com/users/jasmas","html_url":"https://github.com/jasmas","followers_url":"https://api.github.com/users/jasmas/followers","following_url":"https://api.github.com/users/jasmas/following{/other_user}","gists_url":"https://api.github.com/users/jasmas/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmas/subscriptions","organizations_url":"https://api.github.com/users/jasmas/orgs","repos_url":"https://api.github.com/users/jasmas/repos","events_url":"https://api.github.com/users/jasmas/events{/privacy}","received_events_url":"https://api.github.com/users/jasmas/received_events","type":"User","site_admin":false},"repo":{"id":16475897,"name":"homebrew","full_name":"jasmas/homebrew","owner":{"login":"jasmas","id":6385332,"avatar_url":"https://avatars.githubusercontent.com/u/6385332?v=3","gravatar_id":"","url":"https://api.github.com/users/jasmas","html_url":"https://github.com/jasmas","followers_url":"https://api.github.com/users/jasmas/followers","following_url":"https://api.github.com/users/jasmas/following{/other_user}","gists_url":"https://api.github.com/users/jasmas/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmas/subscriptions","organizations_url":"https://api.github.com/users/jasmas/orgs","repos_url":"https://api.github.com/users/jasmas/repos","events_url":"https://api.github.com/users/jasmas/events{/privacy}","received_events_url":"https://api.github.com/users/jasmas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasmas/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/jasmas/homebrew","forks_url":"https://api.github.com/repos/jasmas/homebrew/forks","keys_url":"https://api.github.com/repos/jasmas/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasmas/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasmas/homebrew/teams","hooks_url":"https://api.github.com/repos/jasmas/homebrew/hooks","issue_events_url":"https://api.github.com/repos/jasmas/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/jasmas/homebrew/events","assignees_url":"https://api.github.com/repos/jasmas/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/jasmas/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/jasmas/homebrew/tags","blobs_url":"https://api.github.com/repos/jasmas/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasmas/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasmas/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasmas/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasmas/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/jasmas/homebrew/languages","stargazers_url":"https://api.github.com/repos/jasmas/homebrew/stargazers","contributors_url":"https://api.github.com/repos/jasmas/homebrew/contributors","subscribers_url":"https://api.github.com/repos/jasmas/homebrew/subscribers","subscription_url":"https://api.github.com/repos/jasmas/homebrew/subscription","commits_url":"https://api.github.com/repos/jasmas/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasmas/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasmas/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasmas/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/jasmas/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/jasmas/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasmas/homebrew/merges","archive_url":"https://api.github.com/repos/jasmas/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasmas/homebrew/downloads","issues_url":"https://api.github.com/repos/jasmas/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/jasmas/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/jasmas/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/jasmas/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasmas/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/jasmas/homebrew/releases{/id}","created_at":"2014-02-03T10:16:51Z","updated_at":"2014-10-12T22:40:27Z","pushed_at":"2014-10-19T05:29:35Z","git_url":"git://github.com/jasmas/homebrew.git","ssh_url":"git@github.com:jasmas/homebrew.git","clone_url":"https://github.com/jasmas/homebrew.git","svn_url":"https://github.com/jasmas/homebrew","homepage":"http://brew.sh","size":44685,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"91ef4aea6a12bb2e581477bbfe964e3f52d29e1d","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":"The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2014-11-09T14:25:40Z","pushed_at":"2014-11-09T05:04:38Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1241210,"stargazers_count":20005,"watchers_count":20005,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":9937,"mirror_url":null,"open_issues_count":264,"forks":9937,"open_issues":264,"watchers":20005,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/32884"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/32884"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/32884"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/32884/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/32884/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/32884/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/89feb302a9b3276640a3e419dc0b06b36052234b"}}}}