GitHub PullRequestReviewCommentEvent at 2014-09-22 16:22:29
Repository: juju
Actor: fwereade
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/17859640","id":17859640,"diff_hunk":"@@ -337,9 +366,40 @@ func (ctx *HookContext) finalizeContext(process string, err error) error {\n \t\t}\n \t\tctx.metrics = nil\n \t}\n+\n+\tif isAction {\n+\t\treturn ctx.finalizeAction(err)\n+\t}","path":"worker/uniter/context.go","position":157,"original_position":157,"commit_id":"c5ca1866c4802fc9b2124b07c3e31fc5c2ef37b1","original_commit_id":"c5ca1866c4802fc9b2124b07c3e31fc5c2ef37b1","user":{"login":"fwereade","id":372078,"avatar_url":"https://avatars.githubusercontent.com/u/372078?v=2","gravatar_id":"","url":"https://api.github.com/users/fwereade","html_url":"https://github.com/fwereade","followers_url":"https://api.github.com/users/fwereade/followers","following_url":"https://api.github.com/users/fwereade/following{/other_user}","gists_url":"https://api.github.com/users/fwereade/gists{/gist_id}","starred_url":"https://api.github.com/users/fwereade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwereade/subscriptions","organizations_url":"https://api.github.com/users/fwereade/orgs","repos_url":"https://api.github.com/users/fwereade/repos","events_url":"https://api.github.com/users/fwereade/events{/privacy}","received_events_url":"https://api.github.com/users/fwereade/received_events","type":"User","site_admin":false},"body":"as suggested, deferring this block might be nicer than duping it. Be careful about overwriting err, though.","created_at":"2014-09-22T16:22:29Z","updated_at":"2014-09-22T16:22:29Z","html_url":"https://github.com/juju/juju/pull/617#discussion_r17859640","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/617","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/17859640"},"html":{"href":"https://github.com/juju/juju/pull/617#discussion_r17859640"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/617"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/617","id":20354500,"html_url":"https://github.com/juju/juju/pull/617","diff_url":"https://github.com/juju/juju/pull/617.diff","patch_url":"https://github.com/juju/juju/pull/617.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/617","number":617,"state":"open","locked":false,"title":"ActionFinish called after Action completion","user":{"login":"binary132","id":936243,"avatar_url":"https://avatars.githubusercontent.com/u/936243?v=2","gravatar_id":"","url":"https://api.github.com/users/binary132","html_url":"https://github.com/binary132","followers_url":"https://api.github.com/users/binary132/followers","following_url":"https://api.github.com/users/binary132/following{/other_user}","gists_url":"https://api.github.com/users/binary132/gists{/gist_id}","starred_url":"https://api.github.com/users/binary132/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary132/subscriptions","organizations_url":"https://api.github.com/users/binary132/orgs","repos_url":"https://api.github.com/users/binary132/repos","events_url":"https://api.github.com/users/binary132/events{/privacy}","received_events_url":"https://api.github.com/users/binary132/received_events","type":"User","site_admin":false},"body":"The worker now calls ActionFinish on state to call home with the results of an Action.\r\n\r\nThe unit will not be set to an error state unless the API call to ActionFinish fails.  Any other errors generated by the Action will be encapsulated in the results message, which is sent back to state with the final state of the Action (complete or fail.)","created_at":"2014-08-27T06:16:30Z","updated_at":"2014-09-22T16:22:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd3431f69d4e146ff28767dce725a240a0d667d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/617/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/617/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju/issues/617/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/c5ca1866c4802fc9b2124b07c3e31fc5c2ef37b1","head":{"label":"binary132:action-uniter-response","ref":"action-uniter-response","sha":"c5ca1866c4802fc9b2124b07c3e31fc5c2ef37b1","user":{"login":"binary132","id":936243,"avatar_url":"https://avatars.githubusercontent.com/u/936243?v=2","gravatar_id":"","url":"https://api.github.com/users/binary132","html_url":"https://github.com/binary132","followers_url":"https://api.github.com/users/binary132/followers","following_url":"https://api.github.com/users/binary132/following{/other_user}","gists_url":"https://api.github.com/users/binary132/gists{/gist_id}","starred_url":"https://api.github.com/users/binary132/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary132/subscriptions","organizations_url":"https://api.github.com/users/binary132/orgs","repos_url":"https://api.github.com/users/binary132/repos","events_url":"https://api.github.com/users/binary132/events{/privacy}","received_events_url":"https://api.github.com/users/binary132/received_events","type":"User","site_admin":false},"repo":{"id":20457767,"name":"juju","full_name":"binary132/juju","owner":{"login":"binary132","id":936243,"avatar_url":"https://avatars.githubusercontent.com/u/936243?v=2","gravatar_id":"","url":"https://api.github.com/users/binary132","html_url":"https://github.com/binary132","followers_url":"https://api.github.com/users/binary132/followers","following_url":"https://api.github.com/users/binary132/following{/other_user}","gists_url":"https://api.github.com/users/binary132/gists{/gist_id}","starred_url":"https://api.github.com/users/binary132/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary132/subscriptions","organizations_url":"https://api.github.com/users/binary132/orgs","repos_url":"https://api.github.com/users/binary132/repos","events_url":"https://api.github.com/users/binary132/events{/privacy}","received_events_url":"https://api.github.com/users/binary132/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/binary132/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/binary132/juju","forks_url":"https://api.github.com/repos/binary132/juju/forks","keys_url":"https://api.github.com/repos/binary132/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binary132/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binary132/juju/teams","hooks_url":"https://api.github.com/repos/binary132/juju/hooks","issue_events_url":"https://api.github.com/repos/binary132/juju/issues/events{/number}","events_url":"https://api.github.com/repos/binary132/juju/events","assignees_url":"https://api.github.com/repos/binary132/juju/assignees{/user}","branches_url":"https://api.github.com/repos/binary132/juju/branches{/branch}","tags_url":"https://api.github.com/repos/binary132/juju/tags","blobs_url":"https://api.github.com/repos/binary132/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binary132/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binary132/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/binary132/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binary132/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/binary132/juju/languages","stargazers_url":"https://api.github.com/repos/binary132/juju/stargazers","contributors_url":"https://api.github.com/repos/binary132/juju/contributors","subscribers_url":"https://api.github.com/repos/binary132/juju/subscribers","subscription_url":"https://api.github.com/repos/binary132/juju/subscription","commits_url":"https://api.github.com/repos/binary132/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/binary132/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/binary132/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/binary132/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/binary132/juju/contents/{+path}","compare_url":"https://api.github.com/repos/binary132/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binary132/juju/merges","archive_url":"https://api.github.com/repos/binary132/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binary132/juju/downloads","issues_url":"https://api.github.com/repos/binary132/juju/issues{/number}","pulls_url":"https://api.github.com/repos/binary132/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/binary132/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/binary132/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binary132/juju/labels{/name}","releases_url":"https://api.github.com/repos/binary132/juju/releases{/id}","created_at":"2014-06-03T20:10:23Z","updated_at":"2014-06-25T16:57:32Z","pushed_at":"2014-09-22T15:12:20Z","git_url":"git://github.com/binary132/juju.git","ssh_url":"git@github.com:binary132/juju.git","clone_url":"https://github.com/binary132/juju.git","svn_url":"https://github.com/binary132/juju","homepage":null,"size":32020,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"e11173302d22f123701ab07b76671bd6d945dc47","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2014-09-20T08:48:46Z","pushed_at":"2014-09-22T13:43:27Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":47761,"stargazers_count":207,"watchers_count":207,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":62,"forks":57,"open_issues":62,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/617"},"html":{"href":"https://github.com/juju/juju/pull/617"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/617"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/617/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/617/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/617/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/c5ca1866c4802fc9b2124b07c3e31fc5c2ef37b1"}}}}