GitHub PullRequestEvent at 2014-06-17 00:27:31
Repository: socket.io-client
Actor: guille
Payload: {"action":"closed","number":697,"pull_request":{"url":"https://api.github.com/repos/Automattic/socket.io-client/pulls/697","id":17210731,"html_url":"https://github.com/Automattic/socket.io-client/pull/697","diff_url":"https://github.com/Automattic/socket.io-client/pull/697.diff","patch_url":"https://github.com/Automattic/socket.io-client/pull/697.patch","issue_url":"https://api.github.com/repos/Automattic/socket.io-client/issues/697","number":697,"state":"closed","title":"Delete bad test, set timeouts before disconnecting eioc","user":{"login":"rase-","id":1220601,"avatar_url":"https://avatars.githubusercontent.com/u/1220601?","gravatar_id":"ef31e3ab88603aac93db2c852dbc315f","url":"https://api.github.com/users/rase-","html_url":"https://github.com/rase-","followers_url":"https://api.github.com/users/rase-/followers","following_url":"https://api.github.com/users/rase-/following{/other_user}","gists_url":"https://api.github.com/users/rase-/gists{/gist_id}","starred_url":"https://api.github.com/users/rase-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rase-/subscriptions","organizations_url":"https://api.github.com/users/rase-/orgs","repos_url":"https://api.github.com/users/rase-/repos","events_url":"https://api.github.com/users/rase-/events{/privacy}","received_events_url":"https://api.github.com/users/rase-/received_events","type":"User","site_admin":false},"body":"Add a forceNew to all io calls to make sure tests are run in isolation of each other (no caching). Add timeout before disconnecting engine.io client so that the connection will be properly established before it's being closed. Remove a bad test that assumes the packet buffer operates totally synchronously and only passed because of the previous test's state being cached.","created_at":"2014-06-17T00:26:34Z","updated_at":"2014-06-17T00:27:30Z","closed_at":"2014-06-17T00:27:30Z","merged_at":null,"merge_commit_sha":"dc1d6aa4c1a5e0336f4df1a3f42b9f84c8f6ad87","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/socket.io-client/pulls/697/commits","review_comments_url":"https://api.github.com/repos/Automattic/socket.io-client/pulls/697/comments","review_comment_url":"https://api.github.com/repos/Automattic/socket.io-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Automattic/socket.io-client/issues/697/comments","statuses_url":"https://api.github.com/repos/Automattic/socket.io-client/statuses/5834fed8a98ffd35b02a945a5f4712e68e0aeeef","head":{"label":"rase-:fix/tests","ref":"fix/tests","sha":"5834fed8a98ffd35b02a945a5f4712e68e0aeeef","user":{"login":"rase-","id":1220601,"avatar_url":"https://avatars.githubusercontent.com/u/1220601?","gravatar_id":"ef31e3ab88603aac93db2c852dbc315f","url":"https://api.github.com/users/rase-","html_url":"https://github.com/rase-","followers_url":"https://api.github.com/users/rase-/followers","following_url":"https://api.github.com/users/rase-/following{/other_user}","gists_url":"https://api.github.com/users/rase-/gists{/gist_id}","starred_url":"https://api.github.com/users/rase-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rase-/subscriptions","organizations_url":"https://api.github.com/users/rase-/orgs","repos_url":"https://api.github.com/users/rase-/repos","events_url":"https://api.github.com/users/rase-/events{/privacy}","received_events_url":"https://api.github.com/users/rase-/received_events","type":"User","site_admin":false},"repo":{"id":17636461,"name":"socket.io-client","full_name":"rase-/socket.io-client","owner":{"login":"rase-","id":1220601,"avatar_url":"https://avatars.githubusercontent.com/u/1220601?","gravatar_id":"ef31e3ab88603aac93db2c852dbc315f","url":"https://api.github.com/users/rase-","html_url":"https://github.com/rase-","followers_url":"https://api.github.com/users/rase-/followers","following_url":"https://api.github.com/users/rase-/following{/other_user}","gists_url":"https://api.github.com/users/rase-/gists{/gist_id}","starred_url":"https://api.github.com/users/rase-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rase-/subscriptions","organizations_url":"https://api.github.com/users/rase-/orgs","repos_url":"https://api.github.com/users/rase-/repos","events_url":"https://api.github.com/users/rase-/events{/privacy}","received_events_url":"https://api.github.com/users/rase-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rase-/socket.io-client","description":"Sockets for the rest of us","fork":true,"url":"https://api.github.com/repos/rase-/socket.io-client","forks_url":"https://api.github.com/repos/rase-/socket.io-client/forks","keys_url":"https://api.github.com/repos/rase-/socket.io-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rase-/socket.io-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rase-/socket.io-client/teams","hooks_url":"https://api.github.com/repos/rase-/socket.io-client/hooks","issue_events_url":"https://api.github.com/repos/rase-/socket.io-client/issues/events{/number}","events_url":"https://api.github.com/repos/rase-/socket.io-client/events","assignees_url":"https://api.github.com/repos/rase-/socket.io-client/assignees{/user}","branches_url":"https://api.github.com/repos/rase-/socket.io-client/branches{/branch}","tags_url":"https://api.github.com/repos/rase-/socket.io-client/tags","blobs_url":"https://api.github.com/repos/rase-/socket.io-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rase-/socket.io-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rase-/socket.io-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/rase-/socket.io-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rase-/socket.io-client/statuses/{sha}","languages_url":"https://api.github.com/repos/rase-/socket.io-client/languages","stargazers_url":"https://api.github.com/repos/rase-/socket.io-client/stargazers","contributors_url":"https://api.github.com/repos/rase-/socket.io-client/contributors","subscribers_url":"https://api.github.com/repos/rase-/socket.io-client/subscribers","subscription_url":"https://api.github.com/repos/rase-/socket.io-client/subscription","commits_url":"https://api.github.com/repos/rase-/socket.io-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/rase-/socket.io-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/rase-/socket.io-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/rase-/socket.io-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/rase-/socket.io-client/contents/{+path}","compare_url":"https://api.github.com/repos/rase-/socket.io-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rase-/socket.io-client/merges","archive_url":"https://api.github.com/repos/rase-/socket.io-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rase-/socket.io-client/downloads","issues_url":"https://api.github.com/repos/rase-/socket.io-client/issues{/number}","pulls_url":"https://api.github.com/repos/rase-/socket.io-client/pulls{/number}","milestones_url":"https://api.github.com/repos/rase-/socket.io-client/milestones{/number}","notifications_url":"https://api.github.com/repos/rase-/socket.io-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rase-/socket.io-client/labels{/name}","releases_url":"https://api.github.com/repos/rase-/socket.io-client/releases{/id}","created_at":"2014-03-11T15:54:08Z","updated_at":"2014-06-17T00:27:31Z","pushed_at":"2014-06-17T00:24:36Z","git_url":"git://github.com/rase-/socket.io-client.git","ssh_url":"git@github.com:rase-/socket.io-client.git","clone_url":"https://github.com/rase-/socket.io-client.git","svn_url":"https://github.com/rase-/socket.io-client","homepage":"http://socket.io","size":3823,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"b282b9654e12e5bcd1475eba3e2aac1c28d18b6a","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?","gravatar_id":"f0e0363f91f915ebc9cd3c6671bc5b5c","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":557977,"name":"socket.io-client","full_name":"Automattic/socket.io-client","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?","gravatar_id":"f0e0363f91f915ebc9cd3c6671bc5b5c","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/socket.io-client","description":"Realtime application framework (client)","fork":false,"url":"https://api.github.com/repos/Automattic/socket.io-client","forks_url":"https://api.github.com/repos/Automattic/socket.io-client/forks","keys_url":"https://api.github.com/repos/Automattic/socket.io-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/socket.io-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/socket.io-client/teams","hooks_url":"https://api.github.com/repos/Automattic/socket.io-client/hooks","issue_events_url":"https://api.github.com/repos/Automattic/socket.io-client/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/socket.io-client/events","assignees_url":"https://api.github.com/repos/Automattic/socket.io-client/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/socket.io-client/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/socket.io-client/tags","blobs_url":"https://api.github.com/repos/Automattic/socket.io-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/socket.io-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/socket.io-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/socket.io-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/socket.io-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/socket.io-client/languages","stargazers_url":"https://api.github.com/repos/Automattic/socket.io-client/stargazers","contributors_url":"https://api.github.com/repos/Automattic/socket.io-client/contributors","subscribers_url":"https://api.github.com/repos/Automattic/socket.io-client/subscribers","subscription_url":"https://api.github.com/repos/Automattic/socket.io-client/subscription","commits_url":"https://api.github.com/repos/Automattic/socket.io-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/socket.io-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/socket.io-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/socket.io-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/Automattic/socket.io-client/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/socket.io-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/socket.io-client/merges","archive_url":"https://api.github.com/repos/Automattic/socket.io-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/socket.io-client/downloads","issues_url":"https://api.github.com/repos/Automattic/socket.io-client/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/socket.io-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/socket.io-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/socket.io-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/socket.io-client/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/socket.io-client/releases{/id}","created_at":"2010-03-11T18:23:03Z","updated_at":"2014-06-17T00:27:30Z","pushed_at":"2014-06-17T00:27:30Z","git_url":"git://github.com/Automattic/socket.io-client.git","ssh_url":"git@github.com:Automattic/socket.io-client.git","clone_url":"https://github.com/Automattic/socket.io-client.git","svn_url":"https://github.com/Automattic/socket.io-client","homepage":"http://socket.io","size":7946,"stargazers_count":2323,"watchers_count":2323,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":729,"mirror_url":null,"open_issues_count":256,"forks":729,"open_issues":256,"watchers":2323,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/socket.io-client/pulls/697"},"html":{"href":"https://github.com/Automattic/socket.io-client/pull/697"},"issue":{"href":"https://api.github.com/repos/Automattic/socket.io-client/issues/697"},"comments":{"href":"https://api.github.com/repos/Automattic/socket.io-client/issues/697/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/socket.io-client/pulls/697/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/socket.io-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Automattic/socket.io-client/pulls/697/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/socket.io-client/statuses/5834fed8a98ffd35b02a945a5f4712e68e0aeeef"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":26,"deletions":33,"changed_files":1}}