GitHub PullRequestEvent at 2014-09-30 06:15:20
Repository: koast
Actor: rafkhan
Payload: {"action":"opened","number":33,"pull_request":{"url":"https://api.github.com/repos/rangle/koast/pulls/33","id":21983628,"html_url":"https://github.com/rangle/koast/pull/33","diff_url":"https://github.com/rangle/koast/pull/33.diff","patch_url":"https://github.com/rangle/koast/pull/33.patch","issue_url":"https://api.github.com/repos/rangle/koast/issues/33","number":33,"state":"open","locked":false,"title":"Mongo map refactor","user":{"login":"rafkhan","id":528695,"avatar_url":"https://avatars.githubusercontent.com/u/528695?v=2","gravatar_id":"","url":"https://api.github.com/users/rafkhan","html_url":"https://github.com/rafkhan","followers_url":"https://api.github.com/users/rafkhan/followers","following_url":"https://api.github.com/users/rafkhan/following{/other_user}","gists_url":"https://api.github.com/users/rafkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/rafkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafkhan/subscriptions","organizations_url":"https://api.github.com/users/rafkhan/orgs","repos_url":"https://api.github.com/users/rafkhan/repos","events_url":"https://api.github.com/users/rafkhan/events{/privacy}","received_events_url":"https://api.github.com/users/rafkhan/received_events","type":"User","site_admin":false},"body":"@yuri @e-schultz \r\nSo, I started implemented the mongo mapper .auto() function as a function that generates an express router. However, I realized there is absolutely no point whatsoever to having auto because the user can simply type:\r\n\r\n```javascript\r\nrouter.get('/asd/:id', mapper.get('model'));\r\nrouter.post('/asd/:id', mapper.post('model'));\r\nrouter.del('/asd/:id', mapper.del('model'));\r\n```\r\n\r\nI don't think making this anymore abstract is necessary. It adds more complexity with almost no gain. So I semi sarcastically removed it and pushed it here. (Compounded with the bootstrapper PR).\r\n\r\nAlso, tests still pass even with .auto() commented out...","created_at":"2014-09-30T06:15:20Z","updated_at":"2014-09-30T06:15:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rangle/koast/pulls/33/commits","review_comments_url":"https://api.github.com/repos/rangle/koast/pulls/33/comments","review_comment_url":"https://api.github.com/repos/rangle/koast/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rangle/koast/issues/33/comments","statuses_url":"https://api.github.com/repos/rangle/koast/statuses/5d96ad04b3084828c77005cb95a759e2ba3eb6e0","head":{"label":"rafkhan:mongo-map-refactor","ref":"mongo-map-refactor","sha":"5d96ad04b3084828c77005cb95a759e2ba3eb6e0","user":{"login":"rafkhan","id":528695,"avatar_url":"https://avatars.githubusercontent.com/u/528695?v=2","gravatar_id":"","url":"https://api.github.com/users/rafkhan","html_url":"https://github.com/rafkhan","followers_url":"https://api.github.com/users/rafkhan/followers","following_url":"https://api.github.com/users/rafkhan/following{/other_user}","gists_url":"https://api.github.com/users/rafkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/rafkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafkhan/subscriptions","organizations_url":"https://api.github.com/users/rafkhan/orgs","repos_url":"https://api.github.com/users/rafkhan/repos","events_url":"https://api.github.com/users/rafkhan/events{/privacy}","received_events_url":"https://api.github.com/users/rafkhan/received_events","type":"User","site_admin":false},"repo":{"id":23595578,"name":"koast","full_name":"rafkhan/koast","owner":{"login":"rafkhan","id":528695,"avatar_url":"https://avatars.githubusercontent.com/u/528695?v=2","gravatar_id":"","url":"https://api.github.com/users/rafkhan","html_url":"https://github.com/rafkhan","followers_url":"https://api.github.com/users/rafkhan/followers","following_url":"https://api.github.com/users/rafkhan/following{/other_user}","gists_url":"https://api.github.com/users/rafkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/rafkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafkhan/subscriptions","organizations_url":"https://api.github.com/users/rafkhan/orgs","repos_url":"https://api.github.com/users/rafkhan/repos","events_url":"https://api.github.com/users/rafkhan/events{/privacy}","received_events_url":"https://api.github.com/users/rafkhan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rafkhan/koast","description":"A thin server with an attitude","fork":true,"url":"https://api.github.com/repos/rafkhan/koast","forks_url":"https://api.github.com/repos/rafkhan/koast/forks","keys_url":"https://api.github.com/repos/rafkhan/koast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rafkhan/koast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rafkhan/koast/teams","hooks_url":"https://api.github.com/repos/rafkhan/koast/hooks","issue_events_url":"https://api.github.com/repos/rafkhan/koast/issues/events{/number}","events_url":"https://api.github.com/repos/rafkhan/koast/events","assignees_url":"https://api.github.com/repos/rafkhan/koast/assignees{/user}","branches_url":"https://api.github.com/repos/rafkhan/koast/branches{/branch}","tags_url":"https://api.github.com/repos/rafkhan/koast/tags","blobs_url":"https://api.github.com/repos/rafkhan/koast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rafkhan/koast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rafkhan/koast/git/refs{/sha}","trees_url":"https://api.github.com/repos/rafkhan/koast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rafkhan/koast/statuses/{sha}","languages_url":"https://api.github.com/repos/rafkhan/koast/languages","stargazers_url":"https://api.github.com/repos/rafkhan/koast/stargazers","contributors_url":"https://api.github.com/repos/rafkhan/koast/contributors","subscribers_url":"https://api.github.com/repos/rafkhan/koast/subscribers","subscription_url":"https://api.github.com/repos/rafkhan/koast/subscription","commits_url":"https://api.github.com/repos/rafkhan/koast/commits{/sha}","git_commits_url":"https://api.github.com/repos/rafkhan/koast/git/commits{/sha}","comments_url":"https://api.github.com/repos/rafkhan/koast/comments{/number}","issue_comment_url":"https://api.github.com/repos/rafkhan/koast/issues/comments/{number}","contents_url":"https://api.github.com/repos/rafkhan/koast/contents/{+path}","compare_url":"https://api.github.com/repos/rafkhan/koast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rafkhan/koast/merges","archive_url":"https://api.github.com/repos/rafkhan/koast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rafkhan/koast/downloads","issues_url":"https://api.github.com/repos/rafkhan/koast/issues{/number}","pulls_url":"https://api.github.com/repos/rafkhan/koast/pulls{/number}","milestones_url":"https://api.github.com/repos/rafkhan/koast/milestones{/number}","notifications_url":"https://api.github.com/repos/rafkhan/koast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rafkhan/koast/labels{/name}","releases_url":"https://api.github.com/repos/rafkhan/koast/releases{/id}","created_at":"2014-09-02T21:06:54Z","updated_at":"2014-09-11T22:19:20Z","pushed_at":"2014-09-30T06:11:35Z","git_url":"git://github.com/rafkhan/koast.git","ssh_url":"git@github.com:rafkhan/koast.git","clone_url":"https://github.com/rafkhan/koast.git","svn_url":"https://github.com/rafkhan/koast","homepage":null,"size":572,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rangle:master","ref":"master","sha":"d12fab9d990e6a981e28ebf23d50dd361df977a8","user":{"login":"rangle","id":4304982,"avatar_url":"https://avatars.githubusercontent.com/u/4304982?v=2","gravatar_id":"","url":"https://api.github.com/users/rangle","html_url":"https://github.com/rangle","followers_url":"https://api.github.com/users/rangle/followers","following_url":"https://api.github.com/users/rangle/following{/other_user}","gists_url":"https://api.github.com/users/rangle/gists{/gist_id}","starred_url":"https://api.github.com/users/rangle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rangle/subscriptions","organizations_url":"https://api.github.com/users/rangle/orgs","repos_url":"https://api.github.com/users/rangle/repos","events_url":"https://api.github.com/users/rangle/events{/privacy}","received_events_url":"https://api.github.com/users/rangle/received_events","type":"Organization","site_admin":false},"repo":{"id":16519256,"name":"koast","full_name":"rangle/koast","owner":{"login":"rangle","id":4304982,"avatar_url":"https://avatars.githubusercontent.com/u/4304982?v=2","gravatar_id":"","url":"https://api.github.com/users/rangle","html_url":"https://github.com/rangle","followers_url":"https://api.github.com/users/rangle/followers","following_url":"https://api.github.com/users/rangle/following{/other_user}","gists_url":"https://api.github.com/users/rangle/gists{/gist_id}","starred_url":"https://api.github.com/users/rangle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rangle/subscriptions","organizations_url":"https://api.github.com/users/rangle/orgs","repos_url":"https://api.github.com/users/rangle/repos","events_url":"https://api.github.com/users/rangle/events{/privacy}","received_events_url":"https://api.github.com/users/rangle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rangle/koast","description":"A thin server with an attitude","fork":false,"url":"https://api.github.com/repos/rangle/koast","forks_url":"https://api.github.com/repos/rangle/koast/forks","keys_url":"https://api.github.com/repos/rangle/koast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rangle/koast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rangle/koast/teams","hooks_url":"https://api.github.com/repos/rangle/koast/hooks","issue_events_url":"https://api.github.com/repos/rangle/koast/issues/events{/number}","events_url":"https://api.github.com/repos/rangle/koast/events","assignees_url":"https://api.github.com/repos/rangle/koast/assignees{/user}","branches_url":"https://api.github.com/repos/rangle/koast/branches{/branch}","tags_url":"https://api.github.com/repos/rangle/koast/tags","blobs_url":"https://api.github.com/repos/rangle/koast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rangle/koast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rangle/koast/git/refs{/sha}","trees_url":"https://api.github.com/repos/rangle/koast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rangle/koast/statuses/{sha}","languages_url":"https://api.github.com/repos/rangle/koast/languages","stargazers_url":"https://api.github.com/repos/rangle/koast/stargazers","contributors_url":"https://api.github.com/repos/rangle/koast/contributors","subscribers_url":"https://api.github.com/repos/rangle/koast/subscribers","subscription_url":"https://api.github.com/repos/rangle/koast/subscription","commits_url":"https://api.github.com/repos/rangle/koast/commits{/sha}","git_commits_url":"https://api.github.com/repos/rangle/koast/git/commits{/sha}","comments_url":"https://api.github.com/repos/rangle/koast/comments{/number}","issue_comment_url":"https://api.github.com/repos/rangle/koast/issues/comments/{number}","contents_url":"https://api.github.com/repos/rangle/koast/contents/{+path}","compare_url":"https://api.github.com/repos/rangle/koast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rangle/koast/merges","archive_url":"https://api.github.com/repos/rangle/koast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rangle/koast/downloads","issues_url":"https://api.github.com/repos/rangle/koast/issues{/number}","pulls_url":"https://api.github.com/repos/rangle/koast/pulls{/number}","milestones_url":"https://api.github.com/repos/rangle/koast/milestones{/number}","notifications_url":"https://api.github.com/repos/rangle/koast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rangle/koast/labels{/name}","releases_url":"https://api.github.com/repos/rangle/koast/releases{/id}","created_at":"2014-02-04T17:22:11Z","updated_at":"2014-09-09T02:41:12Z","pushed_at":"2014-09-30T00:06:25Z","git_url":"git://github.com/rangle/koast.git","ssh_url":"git@github.com:rangle/koast.git","clone_url":"https://github.com/rangle/koast.git","svn_url":"https://github.com/rangle/koast","homepage":null,"size":1666,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rangle/koast/pulls/33"},"html":{"href":"https://github.com/rangle/koast/pull/33"},"issue":{"href":"https://api.github.com/repos/rangle/koast/issues/33"},"comments":{"href":"https://api.github.com/repos/rangle/koast/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/rangle/koast/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/rangle/koast/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rangle/koast/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/rangle/koast/statuses/5d96ad04b3084828c77005cb95a759e2ba3eb6e0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":155,"deletions":1,"changed_files":6}}