GitHub PullRequestReviewCommentEvent at 2014-08-01 09:16:20
Repository: performanceplatform-admin
Actor: jcbashdown
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls/comments/15687665","id":15687665,"diff_hunk":"@@ -12,28 +28,48 @@ def get_context(session):\n                                 session['oauth_token']['access_token'])\n         context = {\n             'user': session['oauth_user'],\n-            'data_sets': admin_client.list_data_sets(),\n+            'data_sets': admin_client.list_data_sets()\n         }\n+    context['environment'] = environment_dict()\n \n     return context\n \n \n+def environment_dict():\n+    return {\n+        'name': GOVUK_ENV,\n+        'human_name': GOVUK_ENV[:1].upper() + GOVUK_ENV[1:]\n+    }\n+\n+\n+@app.route(\"/sign-out\")\n+def oauth_sign_out():\n+    session.clear()\n+    flash(\"You have been signed out of Backdrop\", category=\"success\")\n+    session_context = get_context(session)\n+    session_context['signon_base_url'] = app.config['SIGNON_BASE_URL']\n+    return render_template(\"signon/signout.html\", **session_context)","path":"admin/main.py","position":52,"original_position":52,"commit_id":"a596fdff41a717ddee26c342d92a99dee78e2b5f","original_commit_id":"a596fdff41a717ddee26c342d92a99dee78e2b5f","user":{"login":"jcbashdown","id":677893,"avatar_url":"https://avatars.githubusercontent.com/u/677893?v=1","gravatar_id":"6dca9a54fa48c13b620f1f0c2dccc751","url":"https://api.github.com/users/jcbashdown","html_url":"https://github.com/jcbashdown","followers_url":"https://api.github.com/users/jcbashdown/followers","following_url":"https://api.github.com/users/jcbashdown/following{/other_user}","gists_url":"https://api.github.com/users/jcbashdown/gists{/gist_id}","starred_url":"https://api.github.com/users/jcbashdown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcbashdown/subscriptions","organizations_url":"https://api.github.com/users/jcbashdown/orgs","repos_url":"https://api.github.com/users/jcbashdown/repos","events_url":"https://api.github.com/users/jcbashdown/events{/privacy}","received_events_url":"https://api.github.com/users/jcbashdown/received_events","type":"User","site_admin":false},"body":"Spoke to Rob, will make this change. It's unclear why we did this in backdorp. Haha, backdorp!","created_at":"2014-08-01T09:16:20Z","updated_at":"2014-08-01T09:16:20Z","html_url":"https://github.com/alphagov/performanceplatform-admin/pull/19#discussion_r15687665","pull_request_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls/comments/15687665"},"html":{"href":"https://github.com/alphagov/performanceplatform-admin/pull/19#discussion_r15687665"},"pull_request":{"href":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls/19","id":19164967,"html_url":"https://github.com/alphagov/performanceplatform-admin/pull/19","diff_url":"https://github.com/alphagov/performanceplatform-admin/pull/19.diff","patch_url":"https://github.com/alphagov/performanceplatform-admin/pull/19.patch","issue_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/issues/19","number":19,"state":"open","title":"Template fixes","user":{"login":"jcbashdown","id":677893,"avatar_url":"https://avatars.githubusercontent.com/u/677893?v=1","gravatar_id":"6dca9a54fa48c13b620f1f0c2dccc751","url":"https://api.github.com/users/jcbashdown","html_url":"https://github.com/jcbashdown","followers_url":"https://api.github.com/users/jcbashdown/followers","following_url":"https://api.github.com/users/jcbashdown/following{/other_user}","gists_url":"https://api.github.com/users/jcbashdown/gists{/gist_id}","starred_url":"https://api.github.com/users/jcbashdown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcbashdown/subscriptions","organizations_url":"https://api.github.com/users/jcbashdown/orgs","repos_url":"https://api.github.com/users/jcbashdown/repos","events_url":"https://api.github.com/users/jcbashdown/events{/privacy}","received_events_url":"https://api.github.com/users/jcbashdown/received_events","type":"User","site_admin":false},"body":"Template fixes addressing Alex's comments and other things I put to one side on the first pass.\r\n\r\nIncludes a fix to autocompilation (which was broken due to a name change)\r\n\r\nWhat to do about the contact link? Shall I take it out until we do this page? Link to some existing page?","created_at":"2014-07-31T17:12:42Z","updated_at":"2014-08-01T09:16:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7adc71137bf8091e73c2d10a0740afd630bbc15d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls/19/commits","review_comments_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls/19/comments","review_comment_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/issues/19/comments","statuses_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/statuses/a596fdff41a717ddee26c342d92a99dee78e2b5f","head":{"label":"alphagov:template-fixes","ref":"template-fixes","sha":"a596fdff41a717ddee26c342d92a99dee78e2b5f","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=1","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":21730553,"name":"performanceplatform-admin","full_name":"alphagov/performanceplatform-admin","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=1","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/performanceplatform-admin","description":"A Flask app to let authorised users update performance data on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/performanceplatform-admin","forks_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/forks","keys_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/events","assignees_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/merges","archive_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/releases{/id}","created_at":"2014-07-11T09:33:07Z","updated_at":"2014-07-24T11:58:10Z","pushed_at":"2014-07-31T17:27:49Z","git_url":"git://github.com/alphagov/performanceplatform-admin.git","ssh_url":"git@github.com:alphagov/performanceplatform-admin.git","clone_url":"https://github.com/alphagov/performanceplatform-admin.git","svn_url":"https://github.com/alphagov/performanceplatform-admin","homepage":null,"size":1509,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"773330a94a948e81c750fde28807c86ec818e343","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=1","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":21730553,"name":"performanceplatform-admin","full_name":"alphagov/performanceplatform-admin","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=1","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/performanceplatform-admin","description":"A Flask app to let authorised users update performance data on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/performanceplatform-admin","forks_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/forks","keys_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/events","assignees_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/merges","archive_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/performanceplatform-admin/releases{/id}","created_at":"2014-07-11T09:33:07Z","updated_at":"2014-07-24T11:58:10Z","pushed_at":"2014-07-31T17:27:49Z","git_url":"git://github.com/alphagov/performanceplatform-admin.git","ssh_url":"git@github.com:alphagov/performanceplatform-admin.git","clone_url":"https://github.com/alphagov/performanceplatform-admin.git","svn_url":"https://github.com/alphagov/performanceplatform-admin","homepage":null,"size":1509,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls/19"},"html":{"href":"https://github.com/alphagov/performanceplatform-admin/pull/19"},"issue":{"href":"https://api.github.com/repos/alphagov/performanceplatform-admin/issues/19"},"comments":{"href":"https://api.github.com/repos/alphagov/performanceplatform-admin/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/performanceplatform-admin/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/performanceplatform-admin/statuses/a596fdff41a717ddee26c342d92a99dee78e2b5f"}}}}