GitHub PullRequestEvent at 2014-09-11 20:11:27
Repository: html-proofer
Actor: akoeplinger
Payload: {"action":"opened","number":112,"pull_request":{"url":"https://api.github.com/repos/gjtorikian/html-proofer/pulls/112","id":21113915,"html_url":"https://github.com/gjtorikian/html-proofer/pull/112","diff_url":"https://github.com/gjtorikian/html-proofer/pull/112.diff","patch_url":"https://github.com/gjtorikian/html-proofer/pull/112.patch","issue_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/112","number":112,"state":"open","locked":false,"title":"Cache the Uri parser instance in Checkable, results in a 14x performance increase","user":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars.githubusercontent.com/u/1376924?v=2","gravatar_id":"fa82a718ff28a0e28fd4e802e5fe2870","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"body":"The parts getter in Checkable is called **very** often, which means caching the Uri parser instance instead of recreating it on every call massively improves performance.\r\n\r\nHere's a small timing of a site with ~30 files (external checks ignored):\r\n\r\n|before|after|\r\n|------------|------------------|\r\n|**real 0m25.782s**|**real 0m1.810s**|\r\n|user 0m25.377s|user 0m1.681s|\r\n|sys 0m0.384s|sys 0m0.122s|\r\n\r\n\r\n","created_at":"2014-09-11T20:11:27Z","updated_at":"2014-09-11T20:11:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gjtorikian/html-proofer/pulls/112/commits","review_comments_url":"https://api.github.com/repos/gjtorikian/html-proofer/pulls/112/comments","review_comment_url":"https://api.github.com/repos/gjtorikian/html-proofer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/112/comments","statuses_url":"https://api.github.com/repos/gjtorikian/html-proofer/statuses/3c62fa2d0a77910aca1dacf25e1073a3e4c076d5","head":{"label":"akoeplinger:perf","ref":"perf","sha":"3c62fa2d0a77910aca1dacf25e1073a3e4c076d5","user":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars.githubusercontent.com/u/1376924?v=2","gravatar_id":"fa82a718ff28a0e28fd4e802e5fe2870","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"repo":{"id":23933502,"name":"html-proofer","full_name":"akoeplinger/html-proofer","owner":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars.githubusercontent.com/u/1376924?v=2","gravatar_id":"fa82a718ff28a0e28fd4e802e5fe2870","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akoeplinger/html-proofer","description":"Test your rendered HTML files to make sure they're accurate.","fork":true,"url":"https://api.github.com/repos/akoeplinger/html-proofer","forks_url":"https://api.github.com/repos/akoeplinger/html-proofer/forks","keys_url":"https://api.github.com/repos/akoeplinger/html-proofer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akoeplinger/html-proofer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akoeplinger/html-proofer/teams","hooks_url":"https://api.github.com/repos/akoeplinger/html-proofer/hooks","issue_events_url":"https://api.github.com/repos/akoeplinger/html-proofer/issues/events{/number}","events_url":"https://api.github.com/repos/akoeplinger/html-proofer/events","assignees_url":"https://api.github.com/repos/akoeplinger/html-proofer/assignees{/user}","branches_url":"https://api.github.com/repos/akoeplinger/html-proofer/branches{/branch}","tags_url":"https://api.github.com/repos/akoeplinger/html-proofer/tags","blobs_url":"https://api.github.com/repos/akoeplinger/html-proofer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akoeplinger/html-proofer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akoeplinger/html-proofer/git/refs{/sha}","trees_url":"https://api.github.com/repos/akoeplinger/html-proofer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akoeplinger/html-proofer/statuses/{sha}","languages_url":"https://api.github.com/repos/akoeplinger/html-proofer/languages","stargazers_url":"https://api.github.com/repos/akoeplinger/html-proofer/stargazers","contributors_url":"https://api.github.com/repos/akoeplinger/html-proofer/contributors","subscribers_url":"https://api.github.com/repos/akoeplinger/html-proofer/subscribers","subscription_url":"https://api.github.com/repos/akoeplinger/html-proofer/subscription","commits_url":"https://api.github.com/repos/akoeplinger/html-proofer/commits{/sha}","git_commits_url":"https://api.github.com/repos/akoeplinger/html-proofer/git/commits{/sha}","comments_url":"https://api.github.com/repos/akoeplinger/html-proofer/comments{/number}","issue_comment_url":"https://api.github.com/repos/akoeplinger/html-proofer/issues/comments/{number}","contents_url":"https://api.github.com/repos/akoeplinger/html-proofer/contents/{+path}","compare_url":"https://api.github.com/repos/akoeplinger/html-proofer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akoeplinger/html-proofer/merges","archive_url":"https://api.github.com/repos/akoeplinger/html-proofer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akoeplinger/html-proofer/downloads","issues_url":"https://api.github.com/repos/akoeplinger/html-proofer/issues{/number}","pulls_url":"https://api.github.com/repos/akoeplinger/html-proofer/pulls{/number}","milestones_url":"https://api.github.com/repos/akoeplinger/html-proofer/milestones{/number}","notifications_url":"https://api.github.com/repos/akoeplinger/html-proofer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akoeplinger/html-proofer/labels{/name}","releases_url":"https://api.github.com/repos/akoeplinger/html-proofer/releases{/id}","created_at":"2014-09-11T19:57:02Z","updated_at":"2014-09-06T16:33:34Z","pushed_at":"2014-09-11T19:58:25Z","git_url":"git://github.com/akoeplinger/html-proofer.git","ssh_url":"git@github.com:akoeplinger/html-proofer.git","clone_url":"https://github.com/akoeplinger/html-proofer.git","svn_url":"https://github.com/akoeplinger/html-proofer","homepage":"","size":3008,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gjtorikian:master","ref":"master","sha":"89cb82518006ae8ecf6e63d3b90a840334ebf1c2","user":{"login":"gjtorikian","id":64050,"avatar_url":"https://avatars.githubusercontent.com/u/64050?v=2","gravatar_id":"befd819b3fced8c6bd3dba7e633dd068","url":"https://api.github.com/users/gjtorikian","html_url":"https://github.com/gjtorikian","followers_url":"https://api.github.com/users/gjtorikian/followers","following_url":"https://api.github.com/users/gjtorikian/following{/other_user}","gists_url":"https://api.github.com/users/gjtorikian/gists{/gist_id}","starred_url":"https://api.github.com/users/gjtorikian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjtorikian/subscriptions","organizations_url":"https://api.github.com/users/gjtorikian/orgs","repos_url":"https://api.github.com/users/gjtorikian/repos","events_url":"https://api.github.com/users/gjtorikian/events{/privacy}","received_events_url":"https://api.github.com/users/gjtorikian/received_events","type":"User","site_admin":true},"repo":{"id":8451893,"name":"html-proofer","full_name":"gjtorikian/html-proofer","owner":{"login":"gjtorikian","id":64050,"avatar_url":"https://avatars.githubusercontent.com/u/64050?v=2","gravatar_id":"befd819b3fced8c6bd3dba7e633dd068","url":"https://api.github.com/users/gjtorikian","html_url":"https://github.com/gjtorikian","followers_url":"https://api.github.com/users/gjtorikian/followers","following_url":"https://api.github.com/users/gjtorikian/following{/other_user}","gists_url":"https://api.github.com/users/gjtorikian/gists{/gist_id}","starred_url":"https://api.github.com/users/gjtorikian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjtorikian/subscriptions","organizations_url":"https://api.github.com/users/gjtorikian/orgs","repos_url":"https://api.github.com/users/gjtorikian/repos","events_url":"https://api.github.com/users/gjtorikian/events{/privacy}","received_events_url":"https://api.github.com/users/gjtorikian/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/gjtorikian/html-proofer","description":"Test your rendered HTML files to make sure they're accurate.","fork":false,"url":"https://api.github.com/repos/gjtorikian/html-proofer","forks_url":"https://api.github.com/repos/gjtorikian/html-proofer/forks","keys_url":"https://api.github.com/repos/gjtorikian/html-proofer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gjtorikian/html-proofer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gjtorikian/html-proofer/teams","hooks_url":"https://api.github.com/repos/gjtorikian/html-proofer/hooks","issue_events_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/events{/number}","events_url":"https://api.github.com/repos/gjtorikian/html-proofer/events","assignees_url":"https://api.github.com/repos/gjtorikian/html-proofer/assignees{/user}","branches_url":"https://api.github.com/repos/gjtorikian/html-proofer/branches{/branch}","tags_url":"https://api.github.com/repos/gjtorikian/html-proofer/tags","blobs_url":"https://api.github.com/repos/gjtorikian/html-proofer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gjtorikian/html-proofer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gjtorikian/html-proofer/git/refs{/sha}","trees_url":"https://api.github.com/repos/gjtorikian/html-proofer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gjtorikian/html-proofer/statuses/{sha}","languages_url":"https://api.github.com/repos/gjtorikian/html-proofer/languages","stargazers_url":"https://api.github.com/repos/gjtorikian/html-proofer/stargazers","contributors_url":"https://api.github.com/repos/gjtorikian/html-proofer/contributors","subscribers_url":"https://api.github.com/repos/gjtorikian/html-proofer/subscribers","subscription_url":"https://api.github.com/repos/gjtorikian/html-proofer/subscription","commits_url":"https://api.github.com/repos/gjtorikian/html-proofer/commits{/sha}","git_commits_url":"https://api.github.com/repos/gjtorikian/html-proofer/git/commits{/sha}","comments_url":"https://api.github.com/repos/gjtorikian/html-proofer/comments{/number}","issue_comment_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues/comments/{number}","contents_url":"https://api.github.com/repos/gjtorikian/html-proofer/contents/{+path}","compare_url":"https://api.github.com/repos/gjtorikian/html-proofer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gjtorikian/html-proofer/merges","archive_url":"https://api.github.com/repos/gjtorikian/html-proofer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gjtorikian/html-proofer/downloads","issues_url":"https://api.github.com/repos/gjtorikian/html-proofer/issues{/number}","pulls_url":"https://api.github.com/repos/gjtorikian/html-proofer/pulls{/number}","milestones_url":"https://api.github.com/repos/gjtorikian/html-proofer/milestones{/number}","notifications_url":"https://api.github.com/repos/gjtorikian/html-proofer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gjtorikian/html-proofer/labels{/name}","releases_url":"https://api.github.com/repos/gjtorikian/html-proofer/releases{/id}","created_at":"2013-02-27T08:35:49Z","updated_at":"2014-09-06T16:33:34Z","pushed_at":"2014-09-07T22:38:53Z","git_url":"git://github.com/gjtorikian/html-proofer.git","ssh_url":"git@github.com:gjtorikian/html-proofer.git","clone_url":"https://github.com/gjtorikian/html-proofer.git","svn_url":"https://github.com/gjtorikian/html-proofer","homepage":"","size":3008,"stargazers_count":57,"watchers_count":57,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":11,"forks":8,"open_issues":11,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gjtorikian/html-proofer/pulls/112"},"html":{"href":"https://github.com/gjtorikian/html-proofer/pull/112"},"issue":{"href":"https://api.github.com/repos/gjtorikian/html-proofer/issues/112"},"comments":{"href":"https://api.github.com/repos/gjtorikian/html-proofer/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/gjtorikian/html-proofer/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/gjtorikian/html-proofer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gjtorikian/html-proofer/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/gjtorikian/html-proofer/statuses/3c62fa2d0a77910aca1dacf25e1073a3e4c076d5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":2,"changed_files":1}}