GitHub PullRequestEvent at 2014-08-24 07:00:00
Repository: themoviedb
Actor: jzgdev
Payload: {"action":"opened","number":34,"pull_request":{"url":"https://api.github.com/repos/ahmetabdi/themoviedb/pulls/34","id":20217401,"html_url":"https://github.com/ahmetabdi/themoviedb/pull/34","diff_url":"https://github.com/ahmetabdi/themoviedb/pull/34.diff","patch_url":"https://github.com/ahmetabdi/themoviedb/pull/34.patch","issue_url":"https://api.github.com/repos/ahmetabdi/themoviedb/issues/34","number":34,"state":"open","locked":false,"title":"Updates to person.rb","user":{"login":"jzgdev","id":6233998,"avatar_url":"https://avatars.githubusercontent.com/u/6233998?v=2","gravatar_id":"82e5626ac5d4fe62be36303531d007d0","url":"https://api.github.com/users/jzgdev","html_url":"https://github.com/jzgdev","followers_url":"https://api.github.com/users/jzgdev/followers","following_url":"https://api.github.com/users/jzgdev/following{/other_user}","gists_url":"https://api.github.com/users/jzgdev/gists{/gist_id}","starred_url":"https://api.github.com/users/jzgdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzgdev/subscriptions","organizations_url":"https://api.github.com/users/jzgdev/orgs","repos_url":"https://api.github.com/users/jzgdev/repos","events_url":"https://api.github.com/users/jzgdev/events{/privacy}","received_events_url":"https://api.github.com/users/jzgdev/received_events","type":"User","site_admin":false},"body":"When using the gem in my project I had issues with `person.credits` not displaying all credits, only movie credits. I updated the gem to include methods for `person.credits => Tmdb::Person.credits` which now queries `combined_credits`. If the credits still need to be split between movie and TV, I included `person.tv_credits => Tmdb::Person.tv_credits` which queries `/tv_credits` and `person.movie_credits => Tmdb::Person.movie_credits` which queries `/movie_credits`. While I was at it, I decided to include the other missing methods for People including:\r\n`person.external_ids => Tmdb::Person.external_ids` which queries `/external_ids`\r\n`person.tagged_images => Tmdb::Person.tagged_images` which queries `/tagged_images`","created_at":"2014-08-24T06:59:59Z","updated_at":"2014-08-24T06:59:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ahmetabdi/themoviedb/pulls/34/commits","review_comments_url":"https://api.github.com/repos/ahmetabdi/themoviedb/pulls/34/comments","review_comment_url":"https://api.github.com/repos/ahmetabdi/themoviedb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ahmetabdi/themoviedb/issues/34/comments","statuses_url":"https://api.github.com/repos/ahmetabdi/themoviedb/statuses/ca3c1bf8e1d5aec66fd63e3e907c522523fa4dbd","head":{"label":"jzgdev:master","ref":"master","sha":"ca3c1bf8e1d5aec66fd63e3e907c522523fa4dbd","user":{"login":"jzgdev","id":6233998,"avatar_url":"https://avatars.githubusercontent.com/u/6233998?v=2","gravatar_id":"82e5626ac5d4fe62be36303531d007d0","url":"https://api.github.com/users/jzgdev","html_url":"https://github.com/jzgdev","followers_url":"https://api.github.com/users/jzgdev/followers","following_url":"https://api.github.com/users/jzgdev/following{/other_user}","gists_url":"https://api.github.com/users/jzgdev/gists{/gist_id}","starred_url":"https://api.github.com/users/jzgdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzgdev/subscriptions","organizations_url":"https://api.github.com/users/jzgdev/orgs","repos_url":"https://api.github.com/users/jzgdev/repos","events_url":"https://api.github.com/users/jzgdev/events{/privacy}","received_events_url":"https://api.github.com/users/jzgdev/received_events","type":"User","site_admin":false},"repo":{"id":23269229,"name":"themoviedb","full_name":"jzgdev/themoviedb","owner":{"login":"jzgdev","id":6233998,"avatar_url":"https://avatars.githubusercontent.com/u/6233998?v=2","gravatar_id":"82e5626ac5d4fe62be36303531d007d0","url":"https://api.github.com/users/jzgdev","html_url":"https://github.com/jzgdev","followers_url":"https://api.github.com/users/jzgdev/followers","following_url":"https://api.github.com/users/jzgdev/following{/other_user}","gists_url":"https://api.github.com/users/jzgdev/gists{/gist_id}","starred_url":"https://api.github.com/users/jzgdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzgdev/subscriptions","organizations_url":"https://api.github.com/users/jzgdev/orgs","repos_url":"https://api.github.com/users/jzgdev/repos","events_url":"https://api.github.com/users/jzgdev/events{/privacy}","received_events_url":"https://api.github.com/users/jzgdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jzgdev/themoviedb","description":"A Ruby wrapper for the The Movie Database API.","fork":true,"url":"https://api.github.com/repos/jzgdev/themoviedb","forks_url":"https://api.github.com/repos/jzgdev/themoviedb/forks","keys_url":"https://api.github.com/repos/jzgdev/themoviedb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jzgdev/themoviedb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jzgdev/themoviedb/teams","hooks_url":"https://api.github.com/repos/jzgdev/themoviedb/hooks","issue_events_url":"https://api.github.com/repos/jzgdev/themoviedb/issues/events{/number}","events_url":"https://api.github.com/repos/jzgdev/themoviedb/events","assignees_url":"https://api.github.com/repos/jzgdev/themoviedb/assignees{/user}","branches_url":"https://api.github.com/repos/jzgdev/themoviedb/branches{/branch}","tags_url":"https://api.github.com/repos/jzgdev/themoviedb/tags","blobs_url":"https://api.github.com/repos/jzgdev/themoviedb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jzgdev/themoviedb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jzgdev/themoviedb/git/refs{/sha}","trees_url":"https://api.github.com/repos/jzgdev/themoviedb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jzgdev/themoviedb/statuses/{sha}","languages_url":"https://api.github.com/repos/jzgdev/themoviedb/languages","stargazers_url":"https://api.github.com/repos/jzgdev/themoviedb/stargazers","contributors_url":"https://api.github.com/repos/jzgdev/themoviedb/contributors","subscribers_url":"https://api.github.com/repos/jzgdev/themoviedb/subscribers","subscription_url":"https://api.github.com/repos/jzgdev/themoviedb/subscription","commits_url":"https://api.github.com/repos/jzgdev/themoviedb/commits{/sha}","git_commits_url":"https://api.github.com/repos/jzgdev/themoviedb/git/commits{/sha}","comments_url":"https://api.github.com/repos/jzgdev/themoviedb/comments{/number}","issue_comment_url":"https://api.github.com/repos/jzgdev/themoviedb/issues/comments/{number}","contents_url":"https://api.github.com/repos/jzgdev/themoviedb/contents/{+path}","compare_url":"https://api.github.com/repos/jzgdev/themoviedb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jzgdev/themoviedb/merges","archive_url":"https://api.github.com/repos/jzgdev/themoviedb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jzgdev/themoviedb/downloads","issues_url":"https://api.github.com/repos/jzgdev/themoviedb/issues{/number}","pulls_url":"https://api.github.com/repos/jzgdev/themoviedb/pulls{/number}","milestones_url":"https://api.github.com/repos/jzgdev/themoviedb/milestones{/number}","notifications_url":"https://api.github.com/repos/jzgdev/themoviedb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jzgdev/themoviedb/labels{/name}","releases_url":"https://api.github.com/repos/jzgdev/themoviedb/releases{/id}","created_at":"2014-08-24T00:16:00Z","updated_at":"2014-08-24T05:37:03Z","pushed_at":"2014-08-24T06:44:25Z","git_url":"git://github.com/jzgdev/themoviedb.git","ssh_url":"git@github.com:jzgdev/themoviedb.git","clone_url":"https://github.com/jzgdev/themoviedb.git","svn_url":"https://github.com/jzgdev/themoviedb","homepage":"https://rubygems.org/gems/themoviedb","size":354,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ahmetabdi:master","ref":"master","sha":"9b0ce3e42cb3bfd5f3958e639eb76be0aaaf63c0","user":{"login":"ahmetabdi","id":778015,"avatar_url":"https://avatars.githubusercontent.com/u/778015?v=2","gravatar_id":"904dab774a20f6622a96d0d9fee21cf2","url":"https://api.github.com/users/ahmetabdi","html_url":"https://github.com/ahmetabdi","followers_url":"https://api.github.com/users/ahmetabdi/followers","following_url":"https://api.github.com/users/ahmetabdi/following{/other_user}","gists_url":"https://api.github.com/users/ahmetabdi/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetabdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetabdi/subscriptions","organizations_url":"https://api.github.com/users/ahmetabdi/orgs","repos_url":"https://api.github.com/users/ahmetabdi/repos","events_url":"https://api.github.com/users/ahmetabdi/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetabdi/received_events","type":"User","site_admin":false},"repo":{"id":9413655,"name":"themoviedb","full_name":"ahmetabdi/themoviedb","owner":{"login":"ahmetabdi","id":778015,"avatar_url":"https://avatars.githubusercontent.com/u/778015?v=2","gravatar_id":"904dab774a20f6622a96d0d9fee21cf2","url":"https://api.github.com/users/ahmetabdi","html_url":"https://github.com/ahmetabdi","followers_url":"https://api.github.com/users/ahmetabdi/followers","following_url":"https://api.github.com/users/ahmetabdi/following{/other_user}","gists_url":"https://api.github.com/users/ahmetabdi/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetabdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetabdi/subscriptions","organizations_url":"https://api.github.com/users/ahmetabdi/orgs","repos_url":"https://api.github.com/users/ahmetabdi/repos","events_url":"https://api.github.com/users/ahmetabdi/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetabdi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmetabdi/themoviedb","description":"A Ruby wrapper for the The Movie Database API.","fork":false,"url":"https://api.github.com/repos/ahmetabdi/themoviedb","forks_url":"https://api.github.com/repos/ahmetabdi/themoviedb/forks","keys_url":"https://api.github.com/repos/ahmetabdi/themoviedb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmetabdi/themoviedb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmetabdi/themoviedb/teams","hooks_url":"https://api.github.com/repos/ahmetabdi/themoviedb/hooks","issue_events_url":"https://api.github.com/repos/ahmetabdi/themoviedb/issues/events{/number}","events_url":"https://api.github.com/repos/ahmetabdi/themoviedb/events","assignees_url":"https://api.github.com/repos/ahmetabdi/themoviedb/assignees{/user}","branches_url":"https://api.github.com/repos/ahmetabdi/themoviedb/branches{/branch}","tags_url":"https://api.github.com/repos/ahmetabdi/themoviedb/tags","blobs_url":"https://api.github.com/repos/ahmetabdi/themoviedb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmetabdi/themoviedb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmetabdi/themoviedb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmetabdi/themoviedb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmetabdi/themoviedb/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmetabdi/themoviedb/languages","stargazers_url":"https://api.github.com/repos/ahmetabdi/themoviedb/stargazers","contributors_url":"https://api.github.com/repos/ahmetabdi/themoviedb/contributors","subscribers_url":"https://api.github.com/repos/ahmetabdi/themoviedb/subscribers","subscription_url":"https://api.github.com/repos/ahmetabdi/themoviedb/subscription","commits_url":"https://api.github.com/repos/ahmetabdi/themoviedb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmetabdi/themoviedb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmetabdi/themoviedb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmetabdi/themoviedb/issues/comments/{number}","contents_url":"https://api.github.com/repos/ahmetabdi/themoviedb/contents/{+path}","compare_url":"https://api.github.com/repos/ahmetabdi/themoviedb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmetabdi/themoviedb/merges","archive_url":"https://api.github.com/repos/ahmetabdi/themoviedb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmetabdi/themoviedb/downloads","issues_url":"https://api.github.com/repos/ahmetabdi/themoviedb/issues{/number}","pulls_url":"https://api.github.com/repos/ahmetabdi/themoviedb/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmetabdi/themoviedb/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmetabdi/themoviedb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmetabdi/themoviedb/labels{/name}","releases_url":"https://api.github.com/repos/ahmetabdi/themoviedb/releases{/id}","created_at":"2013-04-13T12:59:15Z","updated_at":"2014-08-24T00:15:48Z","pushed_at":"2014-07-24T14:53:27Z","git_url":"git://github.com/ahmetabdi/themoviedb.git","ssh_url":"git@github.com:ahmetabdi/themoviedb.git","clone_url":"https://github.com/ahmetabdi/themoviedb.git","svn_url":"https://github.com/ahmetabdi/themoviedb","homepage":"https://rubygems.org/gems/themoviedb","size":911,"stargazers_count":72,"watchers_count":72,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":32,"mirror_url":null,"open_issues_count":3,"forks":32,"open_issues":3,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ahmetabdi/themoviedb/pulls/34"},"html":{"href":"https://github.com/ahmetabdi/themoviedb/pull/34"},"issue":{"href":"https://api.github.com/repos/ahmetabdi/themoviedb/issues/34"},"comments":{"href":"https://api.github.com/repos/ahmetabdi/themoviedb/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/ahmetabdi/themoviedb/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/ahmetabdi/themoviedb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ahmetabdi/themoviedb/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/ahmetabdi/themoviedb/statuses/ca3c1bf8e1d5aec66fd63e3e907c522523fa4dbd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":49,"deletions":8,"changed_files":2}}