GitHub PullRequestEvent at 2014-06-07 16:37:26
Repository: sentiment
Actor: thisandagain
Payload: {"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/thisandagain/sentiment/pulls/11","id":15890217,"html_url":"https://github.com/thisandagain/sentiment/pull/11","diff_url":"https://github.com/thisandagain/sentiment/pull/11.diff","patch_url":"https://github.com/thisandagain/sentiment/pull/11.patch","issue_url":"https://api.github.com/repos/thisandagain/sentiment/issues/11","number":11,"state":"closed","title":"Speed up of token iteration loop","user":{"login":"MicahFulton","id":3694627,"avatar_url":"https://avatars.githubusercontent.com/u/3694627?","gravatar_id":"ceb3b4cee9becec8fb48597d2a2e6f5a","url":"https://api.github.com/users/MicahFulton","html_url":"https://github.com/MicahFulton","followers_url":"https://api.github.com/users/MicahFulton/followers","following_url":"https://api.github.com/users/MicahFulton/following{/other_user}","gists_url":"https://api.github.com/users/MicahFulton/gists{/gist_id}","starred_url":"https://api.github.com/users/MicahFulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicahFulton/subscriptions","organizations_url":"https://api.github.com/users/MicahFulton/orgs","repos_url":"https://api.github.com/users/MicahFulton/repos","events_url":"https://api.github.com/users/MicahFulton/events{/privacy}","received_events_url":"https://api.github.com/users/MicahFulton/received_events","type":"User","site_admin":false},"body":"I know it is a micro optimization but from local testing it appears to speed up the execution by approximately 30,000 ops/sec see below benchmarks I ran locally:\r\n\r\nfor loop\r\nsentiment (Latest) x 502,382 ops/sec ±4.20% (88 runs sampled)\r\nSentimental (1.0.1) x 213,516 ops/sec ±1.05% (96 runs sampled)\r\n\r\nsentiment (Latest) x 506,713 ops/sec ±0.83% (97 runs sampled)\r\nSentimental (1.0.1) x 223,512 ops/sec ±0.93% (98 runs sampled)\r\n\r\nsentiment (Latest) x 520,691 ops/sec ±0.76% (95 runs sampled)\r\nSentimental (1.0.1) x 221,518 ops/sec ±1.00% (95 runs sampled)\r\n\r\nsentiment (Latest) x 547,038 ops/sec ±0.94% (96 runs sampled)\r\nSentimental (1.0.1) x 226,558 ops/sec ±0.87% (96 runs sampled)\r\n\r\nsentiment (Latest) x 532,363 ops/sec ±1.10% (96 runs sampled)\r\nSentimental (1.0.1) x 223,907 ops/sec ±0.98% (96 runs sampled)\r\n\r\nsentiment (Latest) x 525,713 ops/sec ±1.15% (94 runs sampled)\r\nSentimental (1.0.1) x 213,533 ops/sec ±0.99% (96 runs sampled) \r\n\r\nAverage:  522, 483\r\n\r\nwhile loop\r\nsentiment (Latest) x 571,028 ops/sec ±1.29% (91 runs sampled)\r\nSentimental (1.0.1) x 37,201 ops/sec ±1.39% (91 runs sampled)\r\n\r\nsentiment (Latest) x 560,211 ops/sec ±0.91% (97 runs sampled)\r\nSentimental (1.0.1) x 224,161 ops/sec ±1.13% (97 runs sampled)\r\n\r\nsentiment (Latest) x 576,046 ops/sec ±0.82% (95 runs sampled)\r\nSentimental (1.0.1) x 219,440 ops/sec ±1.47% (97 runs sampled)\r\n\r\nsentiment (Latest) x 550,552 ops/sec ±1.07% (94 runs sampled)\r\nSentimental (1.0.1) x 218,546 ops/sec ±1.02% (94 runs sampled)\r\n\r\nsentiment (Latest) x 538,910 ops/sec ±1.38% (95 runs sampled)\r\nSentimental (1.0.1) x 222,141 ops/sec ±0.92% (99 runs sampled)\r\n\r\nsentiment (Latest) x 522,955 ops/sec ±0.93% (98 runs sampled)\r\nSentimental (1.0.1) x 218,881 ops/sec ±1.05% (93 runs sampled)\r\n\r\nAverage 553, 82\r\n\r\nAverage speed up of 30,800 ops/sec","created_at":"2014-05-14T17:01:52Z","updated_at":"2014-06-07T16:37:26Z","closed_at":"2014-06-07T16:37:26Z","merged_at":"2014-06-07T16:37:26Z","merge_commit_sha":"841f6f60c4a49b1df01504256d1198d78942e8a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thisandagain/sentiment/pulls/11/commits","review_comments_url":"https://api.github.com/repos/thisandagain/sentiment/pulls/11/comments","review_comment_url":"https://api.github.com/repos/thisandagain/sentiment/pulls/comments/{number}","comments_url":"https://api.github.com/repos/thisandagain/sentiment/issues/11/comments","statuses_url":"https://api.github.com/repos/thisandagain/sentiment/statuses/8346087630493b3c235dd7a018ef8474ee038bd2","head":{"label":"MicahFulton:master","ref":"master","sha":"8346087630493b3c235dd7a018ef8474ee038bd2","user":{"login":"MicahFulton","id":3694627,"avatar_url":"https://avatars.githubusercontent.com/u/3694627?","gravatar_id":"ceb3b4cee9becec8fb48597d2a2e6f5a","url":"https://api.github.com/users/MicahFulton","html_url":"https://github.com/MicahFulton","followers_url":"https://api.github.com/users/MicahFulton/followers","following_url":"https://api.github.com/users/MicahFulton/following{/other_user}","gists_url":"https://api.github.com/users/MicahFulton/gists{/gist_id}","starred_url":"https://api.github.com/users/MicahFulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicahFulton/subscriptions","organizations_url":"https://api.github.com/users/MicahFulton/orgs","repos_url":"https://api.github.com/users/MicahFulton/repos","events_url":"https://api.github.com/users/MicahFulton/events{/privacy}","received_events_url":"https://api.github.com/users/MicahFulton/received_events","type":"User","site_admin":false},"repo":{"id":19787836,"name":"sentiment","full_name":"MicahFulton/sentiment","owner":{"login":"MicahFulton","id":3694627,"avatar_url":"https://avatars.githubusercontent.com/u/3694627?","gravatar_id":"ceb3b4cee9becec8fb48597d2a2e6f5a","url":"https://api.github.com/users/MicahFulton","html_url":"https://github.com/MicahFulton","followers_url":"https://api.github.com/users/MicahFulton/followers","following_url":"https://api.github.com/users/MicahFulton/following{/other_user}","gists_url":"https://api.github.com/users/MicahFulton/gists{/gist_id}","starred_url":"https://api.github.com/users/MicahFulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicahFulton/subscriptions","organizations_url":"https://api.github.com/users/MicahFulton/orgs","repos_url":"https://api.github.com/users/MicahFulton/repos","events_url":"https://api.github.com/users/MicahFulton/events{/privacy}","received_events_url":"https://api.github.com/users/MicahFulton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MicahFulton/sentiment","description":"AFINN-based sentiment analysis for Node.js.","fork":true,"url":"https://api.github.com/repos/MicahFulton/sentiment","forks_url":"https://api.github.com/repos/MicahFulton/sentiment/forks","keys_url":"https://api.github.com/repos/MicahFulton/sentiment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MicahFulton/sentiment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MicahFulton/sentiment/teams","hooks_url":"https://api.github.com/repos/MicahFulton/sentiment/hooks","issue_events_url":"https://api.github.com/repos/MicahFulton/sentiment/issues/events{/number}","events_url":"https://api.github.com/repos/MicahFulton/sentiment/events","assignees_url":"https://api.github.com/repos/MicahFulton/sentiment/assignees{/user}","branches_url":"https://api.github.com/repos/MicahFulton/sentiment/branches{/branch}","tags_url":"https://api.github.com/repos/MicahFulton/sentiment/tags","blobs_url":"https://api.github.com/repos/MicahFulton/sentiment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MicahFulton/sentiment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MicahFulton/sentiment/git/refs{/sha}","trees_url":"https://api.github.com/repos/MicahFulton/sentiment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MicahFulton/sentiment/statuses/{sha}","languages_url":"https://api.github.com/repos/MicahFulton/sentiment/languages","stargazers_url":"https://api.github.com/repos/MicahFulton/sentiment/stargazers","contributors_url":"https://api.github.com/repos/MicahFulton/sentiment/contributors","subscribers_url":"https://api.github.com/repos/MicahFulton/sentiment/subscribers","subscription_url":"https://api.github.com/repos/MicahFulton/sentiment/subscription","commits_url":"https://api.github.com/repos/MicahFulton/sentiment/commits{/sha}","git_commits_url":"https://api.github.com/repos/MicahFulton/sentiment/git/commits{/sha}","comments_url":"https://api.github.com/repos/MicahFulton/sentiment/comments{/number}","issue_comment_url":"https://api.github.com/repos/MicahFulton/sentiment/issues/comments/{number}","contents_url":"https://api.github.com/repos/MicahFulton/sentiment/contents/{+path}","compare_url":"https://api.github.com/repos/MicahFulton/sentiment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MicahFulton/sentiment/merges","archive_url":"https://api.github.com/repos/MicahFulton/sentiment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MicahFulton/sentiment/downloads","issues_url":"https://api.github.com/repos/MicahFulton/sentiment/issues{/number}","pulls_url":"https://api.github.com/repos/MicahFulton/sentiment/pulls{/number}","milestones_url":"https://api.github.com/repos/MicahFulton/sentiment/milestones{/number}","notifications_url":"https://api.github.com/repos/MicahFulton/sentiment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MicahFulton/sentiment/labels{/name}","releases_url":"https://api.github.com/repos/MicahFulton/sentiment/releases{/id}","created_at":"2014-05-14T16:47:52Z","updated_at":"2014-06-07T16:37:26Z","pushed_at":"2014-05-14T16:58:03Z","git_url":"git://github.com/MicahFulton/sentiment.git","ssh_url":"git@github.com:MicahFulton/sentiment.git","clone_url":"https://github.com/MicahFulton/sentiment.git","svn_url":"https://github.com/MicahFulton/sentiment","homepage":"","size":160,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thisandagain:master","ref":"master","sha":"90fd1fcd602a2cc55d96c6fe3f4a85c3e61f1341","user":{"login":"thisandagain","id":747641,"avatar_url":"https://avatars.githubusercontent.com/u/747641?","gravatar_id":"db5eb2cddf05b4ae2eaee2c3798f85ba","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"repo":{"id":6119227,"name":"sentiment","full_name":"thisandagain/sentiment","owner":{"login":"thisandagain","id":747641,"avatar_url":"https://avatars.githubusercontent.com/u/747641?","gravatar_id":"db5eb2cddf05b4ae2eaee2c3798f85ba","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thisandagain/sentiment","description":"AFINN-based sentiment analysis for Node.js.","fork":false,"url":"https://api.github.com/repos/thisandagain/sentiment","forks_url":"https://api.github.com/repos/thisandagain/sentiment/forks","keys_url":"https://api.github.com/repos/thisandagain/sentiment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thisandagain/sentiment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thisandagain/sentiment/teams","hooks_url":"https://api.github.com/repos/thisandagain/sentiment/hooks","issue_events_url":"https://api.github.com/repos/thisandagain/sentiment/issues/events{/number}","events_url":"https://api.github.com/repos/thisandagain/sentiment/events","assignees_url":"https://api.github.com/repos/thisandagain/sentiment/assignees{/user}","branches_url":"https://api.github.com/repos/thisandagain/sentiment/branches{/branch}","tags_url":"https://api.github.com/repos/thisandagain/sentiment/tags","blobs_url":"https://api.github.com/repos/thisandagain/sentiment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thisandagain/sentiment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thisandagain/sentiment/git/refs{/sha}","trees_url":"https://api.github.com/repos/thisandagain/sentiment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thisandagain/sentiment/statuses/{sha}","languages_url":"https://api.github.com/repos/thisandagain/sentiment/languages","stargazers_url":"https://api.github.com/repos/thisandagain/sentiment/stargazers","contributors_url":"https://api.github.com/repos/thisandagain/sentiment/contributors","subscribers_url":"https://api.github.com/repos/thisandagain/sentiment/subscribers","subscription_url":"https://api.github.com/repos/thisandagain/sentiment/subscription","commits_url":"https://api.github.com/repos/thisandagain/sentiment/commits{/sha}","git_commits_url":"https://api.github.com/repos/thisandagain/sentiment/git/commits{/sha}","comments_url":"https://api.github.com/repos/thisandagain/sentiment/comments{/number}","issue_comment_url":"https://api.github.com/repos/thisandagain/sentiment/issues/comments/{number}","contents_url":"https://api.github.com/repos/thisandagain/sentiment/contents/{+path}","compare_url":"https://api.github.com/repos/thisandagain/sentiment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thisandagain/sentiment/merges","archive_url":"https://api.github.com/repos/thisandagain/sentiment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thisandagain/sentiment/downloads","issues_url":"https://api.github.com/repos/thisandagain/sentiment/issues{/number}","pulls_url":"https://api.github.com/repos/thisandagain/sentiment/pulls{/number}","milestones_url":"https://api.github.com/repos/thisandagain/sentiment/milestones{/number}","notifications_url":"https://api.github.com/repos/thisandagain/sentiment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thisandagain/sentiment/labels{/name}","releases_url":"https://api.github.com/repos/thisandagain/sentiment/releases{/id}","created_at":"2012-10-08T03:45:22Z","updated_at":"2014-06-07T16:37:26Z","pushed_at":"2014-06-07T16:37:26Z","git_url":"git://github.com/thisandagain/sentiment.git","ssh_url":"git@github.com:thisandagain/sentiment.git","clone_url":"https://github.com/thisandagain/sentiment.git","svn_url":"https://github.com/thisandagain/sentiment","homepage":"","size":268,"stargazers_count":199,"watchers_count":199,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":22,"mirror_url":null,"open_issues_count":0,"forks":22,"open_issues":0,"watchers":199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thisandagain/sentiment/pulls/11"},"html":{"href":"https://github.com/thisandagain/sentiment/pull/11"},"issue":{"href":"https://api.github.com/repos/thisandagain/sentiment/issues/11"},"comments":{"href":"https://api.github.com/repos/thisandagain/sentiment/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/thisandagain/sentiment/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/thisandagain/sentiment/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/thisandagain/sentiment/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/thisandagain/sentiment/statuses/8346087630493b3c235dd7a018ef8474ee038bd2"}},"merged":true,"mergeable":true,"mergeable_state":"clean","merged_by":{"login":"thisandagain","id":747641,"avatar_url":"https://avatars.githubusercontent.com/u/747641?","gravatar_id":"db5eb2cddf05b4ae2eaee2c3798f85ba","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}