GitHub PullRequestReviewCommentEvent at 2014-01-12 03:26:06
Repository: mixxx
Actor: rryan
Payload: {"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/8812630","id":8812630,"diff_hunk":"@@ -65,6 +66,16 @@ void VinylControlControl::trackUnloaded(TrackPointer pTrack) {\n     m_pCurrentTrack.clear();\n }\n \n+void VinylControlControl::notifySeek() {","path":"src/engine/vinylcontrolcontrol.cpp","position":14,"original_position":14,"commit_id":"9c935421daf7e2067569cf6147e7efa8a0f79ce0","original_commit_id":"9c935421daf7e2067569cf6147e7efa8a0f79ce0","user":{"login":"rryan","id":26527,"avatar_url":"https://gravatar.com/avatar/169672d4f18bf00666136d090a74693f?d=https%3A%2F%2Fidenticons.github.com%2F6488517bf6015b4964f5576aae4206e9.png&r=x","gravatar_id":"169672d4f18bf00666136d090a74693f","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"body":"Ok -- I'll play around with this post-merge. I don't think it should be that hard but there is an atomicity issue since you can't atomically update the pointer and the enum (you could if you made a queued seek a pointer to a struct and updated the pointer atomically but that's equally gross to do in the callback).","created_at":"2014-01-12T03:26:06Z","updated_at":"2014-01-12T03:26:06Z","html_url":"https://github.com/mixxxdj/mixxx/pull/148#discussion_r8812630","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/148","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/8812630"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/148#discussion_r8812630"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/148"}}}}