GitHub PullRequestEvent at 2014-02-28 17:50:41
Repository: node-url
Actor: jackwanders
Payload: {"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/isaacs/node-url/pulls/3","id":13061770,"html_url":"https://github.com/isaacs/node-url/pull/3","diff_url":"https://github.com/isaacs/node-url/pull/3.diff","patch_url":"https://github.com/isaacs/node-url/pull/3.patch","issue_url":"https://api.github.com/repos/isaacs/node-url/issues/3","number":3,"state":"open","title":"use a regex to find the first non-host character","user":{"login":"jackwanders","id":752393,"avatar_url":"https://avatars.githubusercontent.com/u/752393","gravatar_id":"5621c3ef433ce51034cd1ebbe5daef88","url":"https://api.github.com/users/jackwanders","html_url":"https://github.com/jackwanders","followers_url":"https://api.github.com/users/jackwanders/followers","following_url":"https://api.github.com/users/jackwanders/following{/other_user}","gists_url":"https://api.github.com/users/jackwanders/gists{/gist_id}","starred_url":"https://api.github.com/users/jackwanders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackwanders/subscriptions","organizations_url":"https://api.github.com/users/jackwanders/orgs","repos_url":"https://api.github.com/users/jackwanders/repos","events_url":"https://api.github.com/users/jackwanders/events{/privacy}","received_events_url":"https://api.github.com/users/jackwanders/received_events","type":"User","site_admin":false},"body":"I was looking into how your url package parsed URLs, and I thought I'd suggest a more compact way to find the index of the first non-host character. \r\n\r\nWhile not super-important, here's a jsperf of the two methods: http://jsperf.com/loop-vs-regex-for-node-url-parse","created_at":"2014-02-28T17:50:39Z","updated_at":"2014-02-28T17:50:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/isaacs/node-url/pulls/3/commits","review_comments_url":"https://api.github.com/repos/isaacs/node-url/pulls/3/comments","review_comment_url":"https://api.github.com/repos/isaacs/node-url/pulls/comments/{number}","comments_url":"https://api.github.com/repos/isaacs/node-url/issues/3/comments","statuses_url":"https://api.github.com/repos/isaacs/node-url/statuses/82637e80db74bacdc03aa91012fd9eea21255d0c","head":{"label":"jackwanders:master","ref":"master","sha":"82637e80db74bacdc03aa91012fd9eea21255d0c","user":{"login":"jackwanders","id":752393,"avatar_url":"https://avatars.githubusercontent.com/u/752393","gravatar_id":"5621c3ef433ce51034cd1ebbe5daef88","url":"https://api.github.com/users/jackwanders","html_url":"https://github.com/jackwanders","followers_url":"https://api.github.com/users/jackwanders/followers","following_url":"https://api.github.com/users/jackwanders/following{/other_user}","gists_url":"https://api.github.com/users/jackwanders/gists{/gist_id}","starred_url":"https://api.github.com/users/jackwanders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackwanders/subscriptions","organizations_url":"https://api.github.com/users/jackwanders/orgs","repos_url":"https://api.github.com/users/jackwanders/repos","events_url":"https://api.github.com/users/jackwanders/events{/privacy}","received_events_url":"https://api.github.com/users/jackwanders/received_events","type":"User","site_admin":false},"repo":{"id":17294290,"name":"node-url","full_name":"jackwanders/node-url","owner":{"login":"jackwanders","id":752393,"avatar_url":"https://avatars.githubusercontent.com/u/752393","gravatar_id":"5621c3ef433ce51034cd1ebbe5daef88","url":"https://api.github.com/users/jackwanders","html_url":"https://github.com/jackwanders","followers_url":"https://api.github.com/users/jackwanders/followers","following_url":"https://api.github.com/users/jackwanders/following{/other_user}","gists_url":"https://api.github.com/users/jackwanders/gists{/gist_id}","starred_url":"https://api.github.com/users/jackwanders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackwanders/subscriptions","organizations_url":"https://api.github.com/users/jackwanders/orgs","repos_url":"https://api.github.com/users/jackwanders/repos","events_url":"https://api.github.com/users/jackwanders/events{/privacy}","received_events_url":"https://api.github.com/users/jackwanders/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackwanders/node-url","description":"The url module from node","fork":true,"url":"https://api.github.com/repos/jackwanders/node-url","forks_url":"https://api.github.com/repos/jackwanders/node-url/forks","keys_url":"https://api.github.com/repos/jackwanders/node-url/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackwanders/node-url/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackwanders/node-url/teams","hooks_url":"https://api.github.com/repos/jackwanders/node-url/hooks","issue_events_url":"https://api.github.com/repos/jackwanders/node-url/issues/events{/number}","events_url":"https://api.github.com/repos/jackwanders/node-url/events","assignees_url":"https://api.github.com/repos/jackwanders/node-url/assignees{/user}","branches_url":"https://api.github.com/repos/jackwanders/node-url/branches{/branch}","tags_url":"https://api.github.com/repos/jackwanders/node-url/tags","blobs_url":"https://api.github.com/repos/jackwanders/node-url/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackwanders/node-url/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackwanders/node-url/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackwanders/node-url/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackwanders/node-url/statuses/{sha}","languages_url":"https://api.github.com/repos/jackwanders/node-url/languages","stargazers_url":"https://api.github.com/repos/jackwanders/node-url/stargazers","contributors_url":"https://api.github.com/repos/jackwanders/node-url/contributors","subscribers_url":"https://api.github.com/repos/jackwanders/node-url/subscribers","subscription_url":"https://api.github.com/repos/jackwanders/node-url/subscription","commits_url":"https://api.github.com/repos/jackwanders/node-url/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackwanders/node-url/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackwanders/node-url/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackwanders/node-url/issues/comments/{number}","contents_url":"https://api.github.com/repos/jackwanders/node-url/contents/{+path}","compare_url":"https://api.github.com/repos/jackwanders/node-url/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackwanders/node-url/merges","archive_url":"https://api.github.com/repos/jackwanders/node-url/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackwanders/node-url/downloads","issues_url":"https://api.github.com/repos/jackwanders/node-url/issues{/number}","pulls_url":"https://api.github.com/repos/jackwanders/node-url/pulls{/number}","milestones_url":"https://api.github.com/repos/jackwanders/node-url/milestones{/number}","notifications_url":"https://api.github.com/repos/jackwanders/node-url/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackwanders/node-url/labels{/name}","releases_url":"https://api.github.com/repos/jackwanders/node-url/releases{/id}","created_at":"2014-02-28T17:42:18Z","updated_at":"2014-02-28T17:50:39Z","pushed_at":"2014-02-28T17:44:51Z","git_url":"git://github.com/jackwanders/node-url.git","ssh_url":"git@github.com:jackwanders/node-url.git","clone_url":"https://github.com/jackwanders/node-url.git","svn_url":"https://github.com/jackwanders/node-url","homepage":"","size":97,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"isaacs:master","ref":"master","sha":"258407d4a09c8314bf0217518650199d20af5d9b","user":{"login":"isaacs","id":9287,"avatar_url":"https://avatars.githubusercontent.com/u/9287","gravatar_id":"73a2b24daecb976af81e010b7a3ce3c6","url":"https://api.github.com/users/isaacs","html_url":"https://github.com/isaacs","followers_url":"https://api.github.com/users/isaacs/followers","following_url":"https://api.github.com/users/isaacs/following{/other_user}","gists_url":"https://api.github.com/users/isaacs/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacs/subscriptions","organizations_url":"https://api.github.com/users/isaacs/orgs","repos_url":"https://api.github.com/users/isaacs/repos","events_url":"https://api.github.com/users/isaacs/events{/privacy}","received_events_url":"https://api.github.com/users/isaacs/received_events","type":"User","site_admin":false},"repo":{"id":1293193,"name":"node-url","full_name":"isaacs/node-url","owner":{"login":"isaacs","id":9287,"avatar_url":"https://avatars.githubusercontent.com/u/9287","gravatar_id":"73a2b24daecb976af81e010b7a3ce3c6","url":"https://api.github.com/users/isaacs","html_url":"https://github.com/isaacs","followers_url":"https://api.github.com/users/isaacs/followers","following_url":"https://api.github.com/users/isaacs/following{/other_user}","gists_url":"https://api.github.com/users/isaacs/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacs/subscriptions","organizations_url":"https://api.github.com/users/isaacs/orgs","repos_url":"https://api.github.com/users/isaacs/repos","events_url":"https://api.github.com/users/isaacs/events{/privacy}","received_events_url":"https://api.github.com/users/isaacs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isaacs/node-url","description":"The url module from node","fork":false,"url":"https://api.github.com/repos/isaacs/node-url","forks_url":"https://api.github.com/repos/isaacs/node-url/forks","keys_url":"https://api.github.com/repos/isaacs/node-url/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaacs/node-url/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaacs/node-url/teams","hooks_url":"https://api.github.com/repos/isaacs/node-url/hooks","issue_events_url":"https://api.github.com/repos/isaacs/node-url/issues/events{/number}","events_url":"https://api.github.com/repos/isaacs/node-url/events","assignees_url":"https://api.github.com/repos/isaacs/node-url/assignees{/user}","branches_url":"https://api.github.com/repos/isaacs/node-url/branches{/branch}","tags_url":"https://api.github.com/repos/isaacs/node-url/tags","blobs_url":"https://api.github.com/repos/isaacs/node-url/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaacs/node-url/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaacs/node-url/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaacs/node-url/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaacs/node-url/statuses/{sha}","languages_url":"https://api.github.com/repos/isaacs/node-url/languages","stargazers_url":"https://api.github.com/repos/isaacs/node-url/stargazers","contributors_url":"https://api.github.com/repos/isaacs/node-url/contributors","subscribers_url":"https://api.github.com/repos/isaacs/node-url/subscribers","subscription_url":"https://api.github.com/repos/isaacs/node-url/subscription","commits_url":"https://api.github.com/repos/isaacs/node-url/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaacs/node-url/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaacs/node-url/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaacs/node-url/issues/comments/{number}","contents_url":"https://api.github.com/repos/isaacs/node-url/contents/{+path}","compare_url":"https://api.github.com/repos/isaacs/node-url/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaacs/node-url/merges","archive_url":"https://api.github.com/repos/isaacs/node-url/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaacs/node-url/downloads","issues_url":"https://api.github.com/repos/isaacs/node-url/issues{/number}","pulls_url":"https://api.github.com/repos/isaacs/node-url/pulls{/number}","milestones_url":"https://api.github.com/repos/isaacs/node-url/milestones{/number}","notifications_url":"https://api.github.com/repos/isaacs/node-url/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaacs/node-url/labels{/name}","releases_url":"https://api.github.com/repos/isaacs/node-url/releases{/id}","created_at":"2011-01-25T22:11:29Z","updated_at":"2013-12-01T20:25:58Z","pushed_at":"2011-01-25T22:11:42Z","git_url":"git://github.com/isaacs/node-url.git","ssh_url":"git@github.com:isaacs/node-url.git","clone_url":"https://github.com/isaacs/node-url.git","svn_url":"https://github.com/isaacs/node-url","homepage":"","size":97,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":13,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/isaacs/node-url/pulls/3"},"html":{"href":"https://github.com/isaacs/node-url/pull/3"},"issue":{"href":"https://api.github.com/repos/isaacs/node-url/issues/3"},"comments":{"href":"https://api.github.com/repos/isaacs/node-url/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/isaacs/node-url/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/isaacs/node-url/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/isaacs/node-url/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/isaacs/node-url/statuses/82637e80db74bacdc03aa91012fd9eea21255d0c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":6,"changed_files":1}}