GitHub PullRequestReviewCommentEvent at 2014-12-08 20:51:37
Repository: cfacter
Actor: MikaelSmith
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments/21484226","id":21484226,"diff_hunk":"@@ -0,0 +1,41 @@\n+// boost includes are not always warning-clean. Disable warnings that\n+// cause problems before including the headers, then re-enable the warnings.\n+#pragma GCC diagnostic push\n+#pragma GCC diagnostic ignored \"-Wattributes\"\n+#include <boost/filesystem/path.hpp>\n+#include <boost/locale.hpp>\n+#pragma GCC diagnostic pop\n+\n+#include <windows.h>\n+\n+extern \"C\" BOOL WINAPI DllMain(\n+    HINSTANCE hinstDLL,  // handle to DLL module\n+    DWORD fdwReason,     // reason for calling function\n+    LPVOID lpReserved )  // reserved\n+{\n+    // Perform actions based on the reason for calling.\n+    switch (fdwReason)\n+    {\n+        case DLL_PROCESS_ATTACH:\n+            // Initialize once for each new process.\n+            // Return FALSE to fail DLL load.\n+\n+            // Setup default UTF-8 aware Locales; this must be done on startup for any use of libfacter.\n+            std::locale::global(boost::locale::generator().generate(\"\"));","path":"lib/src/util/windows/dllmain.cc","position":24,"original_position":24,"commit_id":"08f3f57047ced0e5218a7dfea4a591628ad7b33d","original_commit_id":"3c94c9428a9bf5905d61ead65f08fbce71743f2e","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Probably not (especially if it can throw an exception).","created_at":"2014-12-08T20:51:37Z","updated_at":"2014-12-08T20:51:37Z","html_url":"https://github.com/puppetlabs/cfacter/pull/234#discussion_r21484226","pull_request_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/234","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments/21484226"},"html":{"href":"https://github.com/puppetlabs/cfacter/pull/234#discussion_r21484226"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/234","id":25542753,"html_url":"https://github.com/puppetlabs/cfacter/pull/234","diff_url":"https://github.com/puppetlabs/cfacter/pull/234.diff","patch_url":"https://github.com/puppetlabs/cfacter/pull/234.patch","issue_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/234","number":234,"state":"open","locked":false,"title":"(WIP, CFACT-137) Fix Unicode support","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Command-line arguments aren't necessarily passed in Unicode, Boost.Log and\r\nBoost.Filesystem use wchar_t instead of UTF-8 by default, and Ruby uses\r\nlocal encoding by default. Change all of these to use UTF-8 in char.","created_at":"2014-12-05T01:09:50Z","updated_at":"2014-12-08T20:51:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"041aa1cf983c94b4362b394eadcd7c68ae2bd17d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/234/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/234/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/234/comments","statuses_url":"https://api.github.com/repos/puppetlabs/cfacter/statuses/08f3f57047ced0e5218a7dfea4a591628ad7b33d","head":{"label":"MikaelSmith:bug/master/CFACT-137-UNICODE-fix-test","ref":"bug/master/CFACT-137-UNICODE-fix-test","sha":"08f3f57047ced0e5218a7dfea4a591628ad7b33d","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"repo":{"id":21927560,"name":"cfacter","full_name":"MikaelSmith/cfacter","owner":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikaelSmith/cfacter","description":"Collect and display system facts from a C++ library.","fork":true,"url":"https://api.github.com/repos/MikaelSmith/cfacter","forks_url":"https://api.github.com/repos/MikaelSmith/cfacter/forks","keys_url":"https://api.github.com/repos/MikaelSmith/cfacter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikaelSmith/cfacter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikaelSmith/cfacter/teams","hooks_url":"https://api.github.com/repos/MikaelSmith/cfacter/hooks","issue_events_url":"https://api.github.com/repos/MikaelSmith/cfacter/issues/events{/number}","events_url":"https://api.github.com/repos/MikaelSmith/cfacter/events","assignees_url":"https://api.github.com/repos/MikaelSmith/cfacter/assignees{/user}","branches_url":"https://api.github.com/repos/MikaelSmith/cfacter/branches{/branch}","tags_url":"https://api.github.com/repos/MikaelSmith/cfacter/tags","blobs_url":"https://api.github.com/repos/MikaelSmith/cfacter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikaelSmith/cfacter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikaelSmith/cfacter/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikaelSmith/cfacter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikaelSmith/cfacter/statuses/{sha}","languages_url":"https://api.github.com/repos/MikaelSmith/cfacter/languages","stargazers_url":"https://api.github.com/repos/MikaelSmith/cfacter/stargazers","contributors_url":"https://api.github.com/repos/MikaelSmith/cfacter/contributors","subscribers_url":"https://api.github.com/repos/MikaelSmith/cfacter/subscribers","subscription_url":"https://api.github.com/repos/MikaelSmith/cfacter/subscription","commits_url":"https://api.github.com/repos/MikaelSmith/cfacter/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikaelSmith/cfacter/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikaelSmith/cfacter/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikaelSmith/cfacter/issues/comments/{number}","contents_url":"https://api.github.com/repos/MikaelSmith/cfacter/contents/{+path}","compare_url":"https://api.github.com/repos/MikaelSmith/cfacter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikaelSmith/cfacter/merges","archive_url":"https://api.github.com/repos/MikaelSmith/cfacter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikaelSmith/cfacter/downloads","issues_url":"https://api.github.com/repos/MikaelSmith/cfacter/issues{/number}","pulls_url":"https://api.github.com/repos/MikaelSmith/cfacter/pulls{/number}","milestones_url":"https://api.github.com/repos/MikaelSmith/cfacter/milestones{/number}","notifications_url":"https://api.github.com/repos/MikaelSmith/cfacter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikaelSmith/cfacter/labels{/name}","releases_url":"https://api.github.com/repos/MikaelSmith/cfacter/releases{/id}","created_at":"2014-07-17T03:41:22Z","updated_at":"2014-12-04T00:10:38Z","pushed_at":"2014-12-08T20:48:13Z","git_url":"git://github.com/MikaelSmith/cfacter.git","ssh_url":"git@github.com:MikaelSmith/cfacter.git","clone_url":"https://github.com/MikaelSmith/cfacter.git","svn_url":"https://github.com/MikaelSmith/cfacter","homepage":"https://tickets.puppetlabs.com/browse/CFACT","size":5896,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"374dd978b2148d1fc485c9410a441754a2cb6c5b","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":17602228,"name":"cfacter","full_name":"puppetlabs/cfacter","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/cfacter","description":"Collect and display system facts from a C++ library.","fork":false,"url":"https://api.github.com/repos/puppetlabs/cfacter","forks_url":"https://api.github.com/repos/puppetlabs/cfacter/forks","keys_url":"https://api.github.com/repos/puppetlabs/cfacter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/cfacter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/cfacter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/cfacter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/cfacter/events","assignees_url":"https://api.github.com/repos/puppetlabs/cfacter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/cfacter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/cfacter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/cfacter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/cfacter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/cfacter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/cfacter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/cfacter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/cfacter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/cfacter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/cfacter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/cfacter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/cfacter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/cfacter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/cfacter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/cfacter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/cfacter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/cfacter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/cfacter/merges","archive_url":"https://api.github.com/repos/puppetlabs/cfacter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/cfacter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/cfacter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/cfacter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/cfacter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/cfacter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/cfacter/releases{/id}","created_at":"2014-03-10T17:48:17Z","updated_at":"2014-12-05T21:40:09Z","pushed_at":"2014-12-04T00:09:41Z","git_url":"git://github.com/puppetlabs/cfacter.git","ssh_url":"git@github.com:puppetlabs/cfacter.git","clone_url":"https://github.com/puppetlabs/cfacter.git","svn_url":"https://github.com/puppetlabs/cfacter","homepage":"https://tickets.puppetlabs.com/browse/CFACT","size":78601,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":2,"forks":24,"open_issues":2,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/234"},"html":{"href":"https://github.com/puppetlabs/cfacter/pull/234"},"issue":{"href":"https://api.github.com/repos/puppetlabs/cfacter/issues/234"},"comments":{"href":"https://api.github.com/repos/puppetlabs/cfacter/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/cfacter/statuses/08f3f57047ced0e5218a7dfea4a591628ad7b33d"}}}}