GitHub PullRequestEvent at 2014-10-03 14:00:37
Repository: libusbmuxd
Actor: nikias
Payload: {"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/pulls/6","id":13936189,"html_url":"https://github.com/libimobiledevice/libusbmuxd/pull/6","diff_url":"https://github.com/libimobiledevice/libusbmuxd/pull/6.diff","patch_url":"https://github.com/libimobiledevice/libusbmuxd/pull/6.patch","issue_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/issues/6","number":6,"state":"closed","locked":false,"title":"Avoid exporting non-public symbols","user":{"login":"hyperair","id":88355,"avatar_url":"https://avatars.githubusercontent.com/u/88355?v=2","gravatar_id":"","url":"https://api.github.com/users/hyperair","html_url":"https://github.com/hyperair","followers_url":"https://api.github.com/users/hyperair/followers","following_url":"https://api.github.com/users/hyperair/following{/other_user}","gists_url":"https://api.github.com/users/hyperair/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperair/subscriptions","organizations_url":"https://api.github.com/users/hyperair/orgs","repos_url":"https://api.github.com/users/hyperair/repos","events_url":"https://api.github.com/users/hyperair/events{/privacy}","received_events_url":"https://api.github.com/users/hyperair/received_events","type":"User","site_admin":false},"body":"Between libusbmuxd 1.0.8 and 1.0.9, some private symbols were removed from the library, which technically breaks ABI. This pull request adds -fvisibility=hidden to GLOBAL_CFLAGS and explicitly exports the public symbols as per [1] to avoid exporting these symbols as part of the ABI and avoiding future breakage.\r\n\r\nThis also effectively decouples the iproxy binary from libusbmuxd's private symbols so that they can be upgraded separately.\r\n\r\n[1] http://gcc.gnu.org/wiki/Visibility","created_at":"2014-03-25T04:05:05Z","updated_at":"2014-10-03T14:00:37Z","closed_at":"2014-10-03T14:00:37Z","merged_at":null,"merge_commit_sha":"b533c9ea432b71a0c6ad1ca2c5b393455c0f4e55","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/pulls/6/commits","review_comments_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/pulls/6/comments","review_comment_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/issues/6/comments","statuses_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/statuses/4f087e00eb5c578abba68838da61d94e132f8e8f","head":{"label":"hyperair:master","ref":"master","sha":"4f087e00eb5c578abba68838da61d94e132f8e8f","user":{"login":"hyperair","id":88355,"avatar_url":"https://avatars.githubusercontent.com/u/88355?v=2","gravatar_id":"","url":"https://api.github.com/users/hyperair","html_url":"https://github.com/hyperair","followers_url":"https://api.github.com/users/hyperair/followers","following_url":"https://api.github.com/users/hyperair/following{/other_user}","gists_url":"https://api.github.com/users/hyperair/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperair/subscriptions","organizations_url":"https://api.github.com/users/hyperair/orgs","repos_url":"https://api.github.com/users/hyperair/repos","events_url":"https://api.github.com/users/hyperair/events{/privacy}","received_events_url":"https://api.github.com/users/hyperair/received_events","type":"User","site_admin":false},"repo":{"id":18088266,"name":"libusbmuxd","full_name":"hyperair/libusbmuxd","owner":{"login":"hyperair","id":88355,"avatar_url":"https://avatars.githubusercontent.com/u/88355?v=2","gravatar_id":"","url":"https://api.github.com/users/hyperair","html_url":"https://github.com/hyperair","followers_url":"https://api.github.com/users/hyperair/followers","following_url":"https://api.github.com/users/hyperair/following{/other_user}","gists_url":"https://api.github.com/users/hyperair/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperair/subscriptions","organizations_url":"https://api.github.com/users/hyperair/orgs","repos_url":"https://api.github.com/users/hyperair/repos","events_url":"https://api.github.com/users/hyperair/events{/privacy}","received_events_url":"https://api.github.com/users/hyperair/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hyperair/libusbmuxd","description":"A client library to multiplex connections from and to iOS devices","fork":true,"url":"https://api.github.com/repos/hyperair/libusbmuxd","forks_url":"https://api.github.com/repos/hyperair/libusbmuxd/forks","keys_url":"https://api.github.com/repos/hyperair/libusbmuxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperair/libusbmuxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperair/libusbmuxd/teams","hooks_url":"https://api.github.com/repos/hyperair/libusbmuxd/hooks","issue_events_url":"https://api.github.com/repos/hyperair/libusbmuxd/issues/events{/number}","events_url":"https://api.github.com/repos/hyperair/libusbmuxd/events","assignees_url":"https://api.github.com/repos/hyperair/libusbmuxd/assignees{/user}","branches_url":"https://api.github.com/repos/hyperair/libusbmuxd/branches{/branch}","tags_url":"https://api.github.com/repos/hyperair/libusbmuxd/tags","blobs_url":"https://api.github.com/repos/hyperair/libusbmuxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperair/libusbmuxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperair/libusbmuxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperair/libusbmuxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperair/libusbmuxd/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperair/libusbmuxd/languages","stargazers_url":"https://api.github.com/repos/hyperair/libusbmuxd/stargazers","contributors_url":"https://api.github.com/repos/hyperair/libusbmuxd/contributors","subscribers_url":"https://api.github.com/repos/hyperair/libusbmuxd/subscribers","subscription_url":"https://api.github.com/repos/hyperair/libusbmuxd/subscription","commits_url":"https://api.github.com/repos/hyperair/libusbmuxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperair/libusbmuxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperair/libusbmuxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperair/libusbmuxd/issues/comments/{number}","contents_url":"https://api.github.com/repos/hyperair/libusbmuxd/contents/{+path}","compare_url":"https://api.github.com/repos/hyperair/libusbmuxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperair/libusbmuxd/merges","archive_url":"https://api.github.com/repos/hyperair/libusbmuxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperair/libusbmuxd/downloads","issues_url":"https://api.github.com/repos/hyperair/libusbmuxd/issues{/number}","pulls_url":"https://api.github.com/repos/hyperair/libusbmuxd/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperair/libusbmuxd/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperair/libusbmuxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperair/libusbmuxd/labels{/name}","releases_url":"https://api.github.com/repos/hyperair/libusbmuxd/releases{/id}","created_at":"2014-03-25T04:00:24Z","updated_at":"2014-03-25T04:05:05Z","pushed_at":"2014-03-25T04:00:46Z","git_url":"git://github.com/hyperair/libusbmuxd.git","ssh_url":"git@github.com:hyperair/libusbmuxd.git","clone_url":"https://github.com/hyperair/libusbmuxd.git","svn_url":"https://github.com/hyperair/libusbmuxd","homepage":"","size":200,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libimobiledevice:master","ref":"master","sha":"185eb2b935ea307d9ed1ad2d00240c953132e558","user":{"login":"libimobiledevice","id":3584568,"avatar_url":"https://avatars.githubusercontent.com/u/3584568?v=2","gravatar_id":"","url":"https://api.github.com/users/libimobiledevice","html_url":"https://github.com/libimobiledevice","followers_url":"https://api.github.com/users/libimobiledevice/followers","following_url":"https://api.github.com/users/libimobiledevice/following{/other_user}","gists_url":"https://api.github.com/users/libimobiledevice/gists{/gist_id}","starred_url":"https://api.github.com/users/libimobiledevice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libimobiledevice/subscriptions","organizations_url":"https://api.github.com/users/libimobiledevice/orgs","repos_url":"https://api.github.com/users/libimobiledevice/repos","events_url":"https://api.github.com/users/libimobiledevice/events{/privacy}","received_events_url":"https://api.github.com/users/libimobiledevice/received_events","type":"Organization","site_admin":false},"repo":{"id":12892000,"name":"libusbmuxd","full_name":"libimobiledevice/libusbmuxd","owner":{"login":"libimobiledevice","id":3584568,"avatar_url":"https://avatars.githubusercontent.com/u/3584568?v=2","gravatar_id":"","url":"https://api.github.com/users/libimobiledevice","html_url":"https://github.com/libimobiledevice","followers_url":"https://api.github.com/users/libimobiledevice/followers","following_url":"https://api.github.com/users/libimobiledevice/following{/other_user}","gists_url":"https://api.github.com/users/libimobiledevice/gists{/gist_id}","starred_url":"https://api.github.com/users/libimobiledevice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libimobiledevice/subscriptions","organizations_url":"https://api.github.com/users/libimobiledevice/orgs","repos_url":"https://api.github.com/users/libimobiledevice/repos","events_url":"https://api.github.com/users/libimobiledevice/events{/privacy}","received_events_url":"https://api.github.com/users/libimobiledevice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libimobiledevice/libusbmuxd","description":"A client library to multiplex connections from and to iOS devices","fork":false,"url":"https://api.github.com/repos/libimobiledevice/libusbmuxd","forks_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/forks","keys_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/teams","hooks_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/hooks","issue_events_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/issues/events{/number}","events_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/events","assignees_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/assignees{/user}","branches_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/branches{/branch}","tags_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/tags","blobs_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/statuses/{sha}","languages_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/languages","stargazers_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/stargazers","contributors_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/contributors","subscribers_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/subscribers","subscription_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/subscription","commits_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/issues/comments/{number}","contents_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/contents/{+path}","compare_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/merges","archive_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/downloads","issues_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/issues{/number}","pulls_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/pulls{/number}","milestones_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/milestones{/number}","notifications_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/labels{/name}","releases_url":"https://api.github.com/repos/libimobiledevice/libusbmuxd/releases{/id}","created_at":"2013-09-17T09:59:04Z","updated_at":"2014-09-26T09:23:46Z","pushed_at":"2014-10-03T13:59:39Z","git_url":"git://github.com/libimobiledevice/libusbmuxd.git","ssh_url":"git@github.com:libimobiledevice/libusbmuxd.git","clone_url":"https://github.com/libimobiledevice/libusbmuxd.git","svn_url":"https://github.com/libimobiledevice/libusbmuxd","homepage":"","size":535,"stargazers_count":32,"watchers_count":32,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":4,"forks":21,"open_issues":4,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libimobiledevice/libusbmuxd/pulls/6"},"html":{"href":"https://github.com/libimobiledevice/libusbmuxd/pull/6"},"issue":{"href":"https://api.github.com/repos/libimobiledevice/libusbmuxd/issues/6"},"comments":{"href":"https://api.github.com/repos/libimobiledevice/libusbmuxd/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/libimobiledevice/libusbmuxd/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/libimobiledevice/libusbmuxd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/libimobiledevice/libusbmuxd/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/libimobiledevice/libusbmuxd/statuses/4f087e00eb5c578abba68838da61d94e132f8e8f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":8,"review_comments":0,"commits":2,"additions":44,"deletions":27,"changed_files":10}}