GitHub PullRequestReviewCommentEvent at 2014-01-14 21:01:03
Repository: elasticsearch
Actor: dakrone
Payload: {"comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/8875777","id":8875777,"diff_hunk":"@@ -48,9 +48,11 @@\n     @Inject\n     public RestGetWarmerAction(Settings settings, Client client, RestController controller) {\n         super(settings, client);\n-\n+        controller.registerHandler(GET, \"/_warmer\", this);\n+        controller.registerHandler(GET, \"/_warmer/{name}\", this);","path":"src/main/java/org/elasticsearch/rest/action/admin/indices/warmer/get/RestGetWarmerAction.java","position":6,"original_position":6,"commit_id":"18e2d81bbed15c0d3d8d5174c50b5738cbe647f6","original_commit_id":"18e2d81bbed15c0d3d8d5174c50b5738cbe647f6","user":{"login":"dakrone","id":19060,"avatar_url":"https://gravatar.com/avatar/bcacd00a7f05c4772329cf9f446c7987?d=https%3A%2F%2Fidenticons.github.com%2F8f2ba96517924ee3d08ec132c4bad818.png&r=x","gravatar_id":"bcacd00a7f05c4772329cf9f446c7987","url":"https://api.github.com/users/dakrone","html_url":"https://github.com/dakrone","followers_url":"https://api.github.com/users/dakrone/followers","following_url":"https://api.github.com/users/dakrone/following{/other_user}","gists_url":"https://api.github.com/users/dakrone/gists{/gist_id}","starred_url":"https://api.github.com/users/dakrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakrone/subscriptions","organizations_url":"https://api.github.com/users/dakrone/orgs","repos_url":"https://api.github.com/users/dakrone/repos","events_url":"https://api.github.com/users/dakrone/events{/privacy}","received_events_url":"https://api.github.com/users/dakrone/received_events","type":"User","site_admin":false},"body":"How about adding `(GET, \"/_warmers\", this)` for retrieving all warmers to follow the plural precendence?","created_at":"2014-01-14T21:01:03Z","updated_at":"2014-01-14T21:01:03Z","html_url":"https://github.com/elasticsearch/elasticsearch/pull/4710#discussion_r8875777","pull_request_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/4710","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/8875777"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/4710#discussion_r8875777"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/4710"}}}}