GitHub PullRequestReviewCommentEvent at 2014-01-22 23:34:21
Repository: hifi
Actor: ZappoMan
Payload: {"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/9097592","id":9097592,"diff_hunk":"@@ -55,10 +55,8 @@ void Agent::run() {\n     // XXXBHG - this seems less than ideal. There might be classes (like jurisdiction listeners, that need access to\n     // other node types, but for them to get access to those node types, we have to add them here. It seems like \n     // NodeList should support adding types of interest\n-    const NODE_TYPE AGENT_NODE_TYPES_OF_INTEREST[] = { NODE_TYPE_VOXEL_SERVER, NODE_TYPE_PARTICLE_SERVER,\n-                                                       NODE_TYPE_AUDIO_MIXER, NODE_TYPE_AVATAR_MIXER };\n-    \n-    nodeList->setNodeTypesOfInterest(AGENT_NODE_TYPES_OF_INTEREST, sizeof(AGENT_NODE_TYPES_OF_INTEREST));\n+    nodeList->addSetOfNodeTypesToNodeInterestSet(QSet<NODE_TYPE>() << NODE_TYPE_VOXEL_SERVER << NODE_TYPE_PARTICLE_SERVER","path":"assignment-client/src/Agent.cpp","position":8,"original_position":8,"commit_id":"e9e2557576714417f758f3b9c4e49dd59a3358f4","original_commit_id":"e9e2557576714417f758f3b9c4e49dd59a3358f4","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://gravatar.com/avatar/c42557c73e8386a04239c421c97732b3?d=https%3A%2F%2Fidenticons.github.com%2Fc967cb23211ed9daffad2061cdb59286.png&r=x","gravatar_id":"c42557c73e8386a04239c421c97732b3","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"With this new API of  \"add\" to Interest set, doesn't it mean we can call it from multiple places with different sets, and the result will be the union of the calls? if so, then as the comment above mentions, it would be better to add these calls in the jurisdiction listeners (since they're the ones that know they want particle servers and voxel servers)...","created_at":"2014-01-22T23:34:21Z","updated_at":"2014-01-22T23:34:21Z","html_url":"https://github.com/highfidelity/hifi/pull/1630#discussion_r9097592","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/1630","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/9097592"},"html":{"href":"https://github.com/highfidelity/hifi/pull/1630#discussion_r9097592"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/1630"}}}}