GitHub PullRequestReviewCommentEvent at 2014-11-29 22:18:44
Repository: secor
Actor: pgarbacki
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pinterest/secor/pulls/comments/21056641","id":21056641,"diff_hunk":"@@ -115,11 +122,41 @@ private void exportToTsdb(Stat stat)\n     public void exportStats() throws Exception {\n         List<Stat> stats = getStats();\n         System.out.println(JSONArray.toJSONString(stats));\n+\n+        // if there is a valid openTSDB port configured export to openTSDB\n         if (mConfig.getTsdbHostport() != null && !mConfig.getTsdbHostport().isEmpty()) {\n             for (Stat stat : stats) {\n                 exportToTsdb(stat);\n             }\n         }\n+\n+        // if there is a valid statsD port configured export to statsD\n+        if (mConfig.getStatsDHostPort() != null && !mConfig.getStatsDHostPort().isEmpty()) {\n+                exportToStatsD(stats);","path":"src/main/java/com/pinterest/secor/tools/ProgressMonitor.java","position":46,"original_position":46,"commit_id":"7752d30afbd386483d31663a26af8841dd75d1a6","original_commit_id":"7752d30afbd386483d31663a26af8841dd75d1a6","user":{"login":"pgarbacki","id":5000576,"avatar_url":"https://avatars.githubusercontent.com/u/5000576?v=3","gravatar_id":"","url":"https://api.github.com/users/pgarbacki","html_url":"https://github.com/pgarbacki","followers_url":"https://api.github.com/users/pgarbacki/followers","following_url":"https://api.github.com/users/pgarbacki/following{/other_user}","gists_url":"https://api.github.com/users/pgarbacki/gists{/gist_id}","starred_url":"https://api.github.com/users/pgarbacki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgarbacki/subscriptions","organizations_url":"https://api.github.com/users/pgarbacki/orgs","repos_url":"https://api.github.com/users/pgarbacki/repos","events_url":"https://api.github.com/users/pgarbacki/events{/privacy}","received_events_url":"https://api.github.com/users/pgarbacki/received_events","type":"User","site_admin":false},"body":"Indentation.","created_at":"2014-11-29T22:18:44Z","updated_at":"2014-11-29T22:18:44Z","html_url":"https://github.com/pinterest/secor/pull/51#discussion_r21056641","pull_request_url":"https://api.github.com/repos/pinterest/secor/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/pinterest/secor/pulls/comments/21056641"},"html":{"href":"https://github.com/pinterest/secor/pull/51#discussion_r21056641"},"pull_request":{"href":"https://api.github.com/repos/pinterest/secor/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/pinterest/secor/pulls/51","id":25020285,"html_url":"https://github.com/pinterest/secor/pull/51","diff_url":"https://github.com/pinterest/secor/pull/51.diff","patch_url":"https://github.com/pinterest/secor/pull/51.patch","issue_url":"https://api.github.com/repos/pinterest/secor/issues/51","number":51,"state":"open","locked":false,"title":"Statsd","user":{"login":"lefthandmagic","id":973192,"avatar_url":"https://avatars.githubusercontent.com/u/973192?v=3","gravatar_id":"","url":"https://api.github.com/users/lefthandmagic","html_url":"https://github.com/lefthandmagic","followers_url":"https://api.github.com/users/lefthandmagic/followers","following_url":"https://api.github.com/users/lefthandmagic/following{/other_user}","gists_url":"https://api.github.com/users/lefthandmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/lefthandmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lefthandmagic/subscriptions","organizations_url":"https://api.github.com/users/lefthandmagic/orgs","repos_url":"https://api.github.com/users/lefthandmagic/repos","events_url":"https://api.github.com/users/lefthandmagic/events{/privacy}","received_events_url":"https://api.github.com/users/lefthandmagic/received_events","type":"User","site_admin":false},"body":"Hey @pgarbacki I'm not sure if you'd like this to make it to the main branch. We do not use openTSDB and use graphite instead and I thought I saw a couple of people asking about ability to monitor using graphite. \r\n\r\nI made this change to facilitate monitoring for us primarily, but thought it might be useful for others as well. Lemme know what you think/any code suggestion if you wanna merge. ","created_at":"2014-11-25T16:24:10Z","updated_at":"2014-11-29T22:18:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"620a223cd144f9d74eabdcc81c2858966c417735","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pinterest/secor/pulls/51/commits","review_comments_url":"https://api.github.com/repos/pinterest/secor/pulls/51/comments","review_comment_url":"https://api.github.com/repos/pinterest/secor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pinterest/secor/issues/51/comments","statuses_url":"https://api.github.com/repos/pinterest/secor/statuses/7752d30afbd386483d31663a26af8841dd75d1a6","head":{"label":"lefthandmagic:statsd","ref":"statsd","sha":"7752d30afbd386483d31663a26af8841dd75d1a6","user":{"login":"lefthandmagic","id":973192,"avatar_url":"https://avatars.githubusercontent.com/u/973192?v=3","gravatar_id":"","url":"https://api.github.com/users/lefthandmagic","html_url":"https://github.com/lefthandmagic","followers_url":"https://api.github.com/users/lefthandmagic/followers","following_url":"https://api.github.com/users/lefthandmagic/following{/other_user}","gists_url":"https://api.github.com/users/lefthandmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/lefthandmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lefthandmagic/subscriptions","organizations_url":"https://api.github.com/users/lefthandmagic/orgs","repos_url":"https://api.github.com/users/lefthandmagic/repos","events_url":"https://api.github.com/users/lefthandmagic/events{/privacy}","received_events_url":"https://api.github.com/users/lefthandmagic/received_events","type":"User","site_admin":false},"repo":{"id":26491807,"name":"secor","full_name":"lefthandmagic/secor","owner":{"login":"lefthandmagic","id":973192,"avatar_url":"https://avatars.githubusercontent.com/u/973192?v=3","gravatar_id":"","url":"https://api.github.com/users/lefthandmagic","html_url":"https://github.com/lefthandmagic","followers_url":"https://api.github.com/users/lefthandmagic/followers","following_url":"https://api.github.com/users/lefthandmagic/following{/other_user}","gists_url":"https://api.github.com/users/lefthandmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/lefthandmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lefthandmagic/subscriptions","organizations_url":"https://api.github.com/users/lefthandmagic/orgs","repos_url":"https://api.github.com/users/lefthandmagic/repos","events_url":"https://api.github.com/users/lefthandmagic/events{/privacy}","received_events_url":"https://api.github.com/users/lefthandmagic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lefthandmagic/secor","description":"Secor is a service implementing Kafka log persistence","fork":true,"url":"https://api.github.com/repos/lefthandmagic/secor","forks_url":"https://api.github.com/repos/lefthandmagic/secor/forks","keys_url":"https://api.github.com/repos/lefthandmagic/secor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lefthandmagic/secor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lefthandmagic/secor/teams","hooks_url":"https://api.github.com/repos/lefthandmagic/secor/hooks","issue_events_url":"https://api.github.com/repos/lefthandmagic/secor/issues/events{/number}","events_url":"https://api.github.com/repos/lefthandmagic/secor/events","assignees_url":"https://api.github.com/repos/lefthandmagic/secor/assignees{/user}","branches_url":"https://api.github.com/repos/lefthandmagic/secor/branches{/branch}","tags_url":"https://api.github.com/repos/lefthandmagic/secor/tags","blobs_url":"https://api.github.com/repos/lefthandmagic/secor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lefthandmagic/secor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lefthandmagic/secor/git/refs{/sha}","trees_url":"https://api.github.com/repos/lefthandmagic/secor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lefthandmagic/secor/statuses/{sha}","languages_url":"https://api.github.com/repos/lefthandmagic/secor/languages","stargazers_url":"https://api.github.com/repos/lefthandmagic/secor/stargazers","contributors_url":"https://api.github.com/repos/lefthandmagic/secor/contributors","subscribers_url":"https://api.github.com/repos/lefthandmagic/secor/subscribers","subscription_url":"https://api.github.com/repos/lefthandmagic/secor/subscription","commits_url":"https://api.github.com/repos/lefthandmagic/secor/commits{/sha}","git_commits_url":"https://api.github.com/repos/lefthandmagic/secor/git/commits{/sha}","comments_url":"https://api.github.com/repos/lefthandmagic/secor/comments{/number}","issue_comment_url":"https://api.github.com/repos/lefthandmagic/secor/issues/comments/{number}","contents_url":"https://api.github.com/repos/lefthandmagic/secor/contents/{+path}","compare_url":"https://api.github.com/repos/lefthandmagic/secor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lefthandmagic/secor/merges","archive_url":"https://api.github.com/repos/lefthandmagic/secor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lefthandmagic/secor/downloads","issues_url":"https://api.github.com/repos/lefthandmagic/secor/issues{/number}","pulls_url":"https://api.github.com/repos/lefthandmagic/secor/pulls{/number}","milestones_url":"https://api.github.com/repos/lefthandmagic/secor/milestones{/number}","notifications_url":"https://api.github.com/repos/lefthandmagic/secor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lefthandmagic/secor/labels{/name}","releases_url":"https://api.github.com/repos/lefthandmagic/secor/releases{/id}","created_at":"2014-11-11T15:49:19Z","updated_at":"2014-11-25T15:50:01Z","pushed_at":"2014-11-26T07:06:12Z","git_url":"git://github.com/lefthandmagic/secor.git","ssh_url":"git@github.com:lefthandmagic/secor.git","clone_url":"https://github.com/lefthandmagic/secor.git","svn_url":"https://github.com/lefthandmagic/secor","homepage":"","size":401,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pinterest:master","ref":"master","sha":"5c086751e5b560f1447221f85a543f8d72fd1d96","user":{"login":"pinterest","id":541152,"avatar_url":"https://avatars.githubusercontent.com/u/541152?v=3","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"repo":{"id":18818296,"name":"secor","full_name":"pinterest/secor","owner":{"login":"pinterest","id":541152,"avatar_url":"https://avatars.githubusercontent.com/u/541152?v=3","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pinterest/secor","description":"Secor is a service implementing Kafka log persistence","fork":false,"url":"https://api.github.com/repos/pinterest/secor","forks_url":"https://api.github.com/repos/pinterest/secor/forks","keys_url":"https://api.github.com/repos/pinterest/secor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pinterest/secor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pinterest/secor/teams","hooks_url":"https://api.github.com/repos/pinterest/secor/hooks","issue_events_url":"https://api.github.com/repos/pinterest/secor/issues/events{/number}","events_url":"https://api.github.com/repos/pinterest/secor/events","assignees_url":"https://api.github.com/repos/pinterest/secor/assignees{/user}","branches_url":"https://api.github.com/repos/pinterest/secor/branches{/branch}","tags_url":"https://api.github.com/repos/pinterest/secor/tags","blobs_url":"https://api.github.com/repos/pinterest/secor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pinterest/secor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pinterest/secor/git/refs{/sha}","trees_url":"https://api.github.com/repos/pinterest/secor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pinterest/secor/statuses/{sha}","languages_url":"https://api.github.com/repos/pinterest/secor/languages","stargazers_url":"https://api.github.com/repos/pinterest/secor/stargazers","contributors_url":"https://api.github.com/repos/pinterest/secor/contributors","subscribers_url":"https://api.github.com/repos/pinterest/secor/subscribers","subscription_url":"https://api.github.com/repos/pinterest/secor/subscription","commits_url":"https://api.github.com/repos/pinterest/secor/commits{/sha}","git_commits_url":"https://api.github.com/repos/pinterest/secor/git/commits{/sha}","comments_url":"https://api.github.com/repos/pinterest/secor/comments{/number}","issue_comment_url":"https://api.github.com/repos/pinterest/secor/issues/comments/{number}","contents_url":"https://api.github.com/repos/pinterest/secor/contents/{+path}","compare_url":"https://api.github.com/repos/pinterest/secor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pinterest/secor/merges","archive_url":"https://api.github.com/repos/pinterest/secor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pinterest/secor/downloads","issues_url":"https://api.github.com/repos/pinterest/secor/issues{/number}","pulls_url":"https://api.github.com/repos/pinterest/secor/pulls{/number}","milestones_url":"https://api.github.com/repos/pinterest/secor/milestones{/number}","notifications_url":"https://api.github.com/repos/pinterest/secor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pinterest/secor/labels{/name}","releases_url":"https://api.github.com/repos/pinterest/secor/releases{/id}","created_at":"2014-04-15T22:26:44Z","updated_at":"2014-11-28T23:01:00Z","pushed_at":"2014-11-28T00:55:09Z","git_url":"git://github.com/pinterest/secor.git","ssh_url":"git@github.com:pinterest/secor.git","clone_url":"https://github.com/pinterest/secor.git","svn_url":"https://github.com/pinterest/secor","homepage":"","size":1204,"stargazers_count":191,"watchers_count":191,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":15,"forks":52,"open_issues":15,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pinterest/secor/pulls/51"},"html":{"href":"https://github.com/pinterest/secor/pull/51"},"issue":{"href":"https://api.github.com/repos/pinterest/secor/issues/51"},"comments":{"href":"https://api.github.com/repos/pinterest/secor/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/pinterest/secor/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/pinterest/secor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pinterest/secor/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/pinterest/secor/statuses/7752d30afbd386483d31663a26af8841dd75d1a6"}}}}