GitHub PullRequestReviewCommentEvent at 2014-09-01 11:20:28
Repository: noscript
Actor: doochik
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/yandex-ui/noscript/pulls/comments/16950211","id":16950211,"diff_hunk":"@@ -415,9 +428,11 @@ ns.router._parseParam = function(param) {\n     // фильтр \"==\"\n     if (chunks.length === 3) {\n         param_is_optional = false;\n-        param_default = chunks[2];\n-        ns.assert(param_default, 'ns.router', \"Parameter '%s' value must be specified\", paramName);\n-        ns.assert(ns.router._isParamValid(param_default, param_type), 'ns.router', \"Wrong value for '%s' parameter\", paramName);\n+        param_is_filter = true;\n+        param_filter_value = param_default = chunks[2];","path":"src/ns.router.js","position":47,"original_position":47,"commit_id":"b40b667792009e64d2ffc97c92f8918b84935283","original_commit_id":"b40b667792009e64d2ffc97c92f8918b84935283","user":{"login":"doochik","id":31961,"avatar_url":"https://avatars.githubusercontent.com/u/31961?v=2","gravatar_id":"c6614b77fb5f3104068bb1a84038f2b7","url":"https://api.github.com/users/doochik","html_url":"https://github.com/doochik","followers_url":"https://api.github.com/users/doochik/followers","following_url":"https://api.github.com/users/doochik/following{/other_user}","gists_url":"https://api.github.com/users/doochik/gists{/gist_id}","starred_url":"https://api.github.com/users/doochik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doochik/subscriptions","organizations_url":"https://api.github.com/users/doochik/orgs","repos_url":"https://api.github.com/users/doochik/repos","events_url":"https://api.github.com/users/doochik/events{/privacy}","received_events_url":"https://api.github.com/users/doochik/received_events","type":"User","site_admin":false},"body":"Мерж мой PR и будем все это в мастер вливать","created_at":"2014-09-01T11:20:28Z","updated_at":"2014-09-01T11:20:28Z","html_url":"https://github.com/yandex-ui/noscript/pull/435#discussion_r16950211","pull_request_url":"https://api.github.com/repos/yandex-ui/noscript/pulls/435","_links":{"self":{"href":"https://api.github.com/repos/yandex-ui/noscript/pulls/comments/16950211"},"html":{"href":"https://github.com/yandex-ui/noscript/pull/435#discussion_r16950211"},"pull_request":{"href":"https://api.github.com/repos/yandex-ui/noscript/pulls/435"}}},"pull_request":{"url":"https://api.github.com/repos/yandex-ui/noscript/pulls/435","id":20443703,"html_url":"https://github.com/yandex-ui/noscript/pull/435","diff_url":"https://github.com/yandex-ui/noscript/pull/435.diff","patch_url":"https://github.com/yandex-ui/noscript/pull/435.patch","issue_url":"https://api.github.com/repos/yandex-ui/noscript/issues/435","number":435,"state":"open","locked":false,"title":"Фикс generateUrl для роутов с фильтрами","user":{"login":"Bacher","id":2598671,"avatar_url":"https://avatars.githubusercontent.com/u/2598671?v=2","gravatar_id":"00591be2de1319d596da3ca99d2073a7","url":"https://api.github.com/users/Bacher","html_url":"https://github.com/Bacher","followers_url":"https://api.github.com/users/Bacher/followers","following_url":"https://api.github.com/users/Bacher/following{/other_user}","gists_url":"https://api.github.com/users/Bacher/gists{/gist_id}","starred_url":"https://api.github.com/users/Bacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bacher/subscriptions","organizations_url":"https://api.github.com/users/Bacher/orgs","repos_url":"https://api.github.com/users/Bacher/repos","events_url":"https://api.github.com/users/Bacher/events{/privacy}","received_events_url":"https://api.github.com/users/Bacher/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-28T14:54:51Z","updated_at":"2014-09-01T11:20:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ed0c0e8d22d05fa5c24e8097ca5db9eee9fff04","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yandex-ui/noscript/pulls/435/commits","review_comments_url":"https://api.github.com/repos/yandex-ui/noscript/pulls/435/comments","review_comment_url":"https://api.github.com/repos/yandex-ui/noscript/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yandex-ui/noscript/issues/435/comments","statuses_url":"https://api.github.com/repos/yandex-ui/noscript/statuses/b40b667792009e64d2ffc97c92f8918b84935283","head":{"label":"Bacher:route-generate-filters-fix","ref":"route-generate-filters-fix","sha":"b40b667792009e64d2ffc97c92f8918b84935283","user":{"login":"Bacher","id":2598671,"avatar_url":"https://avatars.githubusercontent.com/u/2598671?v=2","gravatar_id":"00591be2de1319d596da3ca99d2073a7","url":"https://api.github.com/users/Bacher","html_url":"https://github.com/Bacher","followers_url":"https://api.github.com/users/Bacher/followers","following_url":"https://api.github.com/users/Bacher/following{/other_user}","gists_url":"https://api.github.com/users/Bacher/gists{/gist_id}","starred_url":"https://api.github.com/users/Bacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bacher/subscriptions","organizations_url":"https://api.github.com/users/Bacher/orgs","repos_url":"https://api.github.com/users/Bacher/repos","events_url":"https://api.github.com/users/Bacher/events{/privacy}","received_events_url":"https://api.github.com/users/Bacher/received_events","type":"User","site_admin":false},"repo":{"id":22991427,"name":"noscript","full_name":"Bacher/noscript","owner":{"login":"Bacher","id":2598671,"avatar_url":"https://avatars.githubusercontent.com/u/2598671?v=2","gravatar_id":"00591be2de1319d596da3ca99d2073a7","url":"https://api.github.com/users/Bacher","html_url":"https://github.com/Bacher","followers_url":"https://api.github.com/users/Bacher/followers","following_url":"https://api.github.com/users/Bacher/following{/other_user}","gists_url":"https://api.github.com/users/Bacher/gists{/gist_id}","starred_url":"https://api.github.com/users/Bacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bacher/subscriptions","organizations_url":"https://api.github.com/users/Bacher/orgs","repos_url":"https://api.github.com/users/Bacher/repos","events_url":"https://api.github.com/users/Bacher/events{/privacy}","received_events_url":"https://api.github.com/users/Bacher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Bacher/noscript","description":"noscript","fork":true,"url":"https://api.github.com/repos/Bacher/noscript","forks_url":"https://api.github.com/repos/Bacher/noscript/forks","keys_url":"https://api.github.com/repos/Bacher/noscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bacher/noscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bacher/noscript/teams","hooks_url":"https://api.github.com/repos/Bacher/noscript/hooks","issue_events_url":"https://api.github.com/repos/Bacher/noscript/issues/events{/number}","events_url":"https://api.github.com/repos/Bacher/noscript/events","assignees_url":"https://api.github.com/repos/Bacher/noscript/assignees{/user}","branches_url":"https://api.github.com/repos/Bacher/noscript/branches{/branch}","tags_url":"https://api.github.com/repos/Bacher/noscript/tags","blobs_url":"https://api.github.com/repos/Bacher/noscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bacher/noscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bacher/noscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bacher/noscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bacher/noscript/statuses/{sha}","languages_url":"https://api.github.com/repos/Bacher/noscript/languages","stargazers_url":"https://api.github.com/repos/Bacher/noscript/stargazers","contributors_url":"https://api.github.com/repos/Bacher/noscript/contributors","subscribers_url":"https://api.github.com/repos/Bacher/noscript/subscribers","subscription_url":"https://api.github.com/repos/Bacher/noscript/subscription","commits_url":"https://api.github.com/repos/Bacher/noscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bacher/noscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bacher/noscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bacher/noscript/issues/comments/{number}","contents_url":"https://api.github.com/repos/Bacher/noscript/contents/{+path}","compare_url":"https://api.github.com/repos/Bacher/noscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bacher/noscript/merges","archive_url":"https://api.github.com/repos/Bacher/noscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bacher/noscript/downloads","issues_url":"https://api.github.com/repos/Bacher/noscript/issues{/number}","pulls_url":"https://api.github.com/repos/Bacher/noscript/pulls{/number}","milestones_url":"https://api.github.com/repos/Bacher/noscript/milestones{/number}","notifications_url":"https://api.github.com/repos/Bacher/noscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bacher/noscript/labels{/name}","releases_url":"https://api.github.com/repos/Bacher/noscript/releases{/id}","created_at":"2014-08-15T14:04:49Z","updated_at":"2014-08-28T14:16:32Z","pushed_at":"2014-08-30T11:00:44Z","git_url":"git://github.com/Bacher/noscript.git","ssh_url":"git@github.com:Bacher/noscript.git","clone_url":"https://github.com/Bacher/noscript.git","svn_url":"https://github.com/Bacher/noscript","homepage":"","size":3843,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"yandex-ui:master","ref":"master","sha":"cce5054793096f1fd4fed6bff6d89ef01bb7aad3","user":{"login":"yandex-ui","id":914728,"avatar_url":"https://avatars.githubusercontent.com/u/914728?v=2","gravatar_id":"ca4cee9af0bbfae9ce0c86f9e3a59953","url":"https://api.github.com/users/yandex-ui","html_url":"https://github.com/yandex-ui","followers_url":"https://api.github.com/users/yandex-ui/followers","following_url":"https://api.github.com/users/yandex-ui/following{/other_user}","gists_url":"https://api.github.com/users/yandex-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex-ui/subscriptions","organizations_url":"https://api.github.com/users/yandex-ui/orgs","repos_url":"https://api.github.com/users/yandex-ui/repos","events_url":"https://api.github.com/users/yandex-ui/events{/privacy}","received_events_url":"https://api.github.com/users/yandex-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":2283674,"name":"noscript","full_name":"yandex-ui/noscript","owner":{"login":"yandex-ui","id":914728,"avatar_url":"https://avatars.githubusercontent.com/u/914728?v=2","gravatar_id":"ca4cee9af0bbfae9ce0c86f9e3a59953","url":"https://api.github.com/users/yandex-ui","html_url":"https://github.com/yandex-ui","followers_url":"https://api.github.com/users/yandex-ui/followers","following_url":"https://api.github.com/users/yandex-ui/following{/other_user}","gists_url":"https://api.github.com/users/yandex-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex-ui/subscriptions","organizations_url":"https://api.github.com/users/yandex-ui/orgs","repos_url":"https://api.github.com/users/yandex-ui/repos","events_url":"https://api.github.com/users/yandex-ui/events{/privacy}","received_events_url":"https://api.github.com/users/yandex-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yandex-ui/noscript","description":"noscript","fork":false,"url":"https://api.github.com/repos/yandex-ui/noscript","forks_url":"https://api.github.com/repos/yandex-ui/noscript/forks","keys_url":"https://api.github.com/repos/yandex-ui/noscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yandex-ui/noscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yandex-ui/noscript/teams","hooks_url":"https://api.github.com/repos/yandex-ui/noscript/hooks","issue_events_url":"https://api.github.com/repos/yandex-ui/noscript/issues/events{/number}","events_url":"https://api.github.com/repos/yandex-ui/noscript/events","assignees_url":"https://api.github.com/repos/yandex-ui/noscript/assignees{/user}","branches_url":"https://api.github.com/repos/yandex-ui/noscript/branches{/branch}","tags_url":"https://api.github.com/repos/yandex-ui/noscript/tags","blobs_url":"https://api.github.com/repos/yandex-ui/noscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yandex-ui/noscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yandex-ui/noscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/yandex-ui/noscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yandex-ui/noscript/statuses/{sha}","languages_url":"https://api.github.com/repos/yandex-ui/noscript/languages","stargazers_url":"https://api.github.com/repos/yandex-ui/noscript/stargazers","contributors_url":"https://api.github.com/repos/yandex-ui/noscript/contributors","subscribers_url":"https://api.github.com/repos/yandex-ui/noscript/subscribers","subscription_url":"https://api.github.com/repos/yandex-ui/noscript/subscription","commits_url":"https://api.github.com/repos/yandex-ui/noscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/yandex-ui/noscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/yandex-ui/noscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/yandex-ui/noscript/issues/comments/{number}","contents_url":"https://api.github.com/repos/yandex-ui/noscript/contents/{+path}","compare_url":"https://api.github.com/repos/yandex-ui/noscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yandex-ui/noscript/merges","archive_url":"https://api.github.com/repos/yandex-ui/noscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yandex-ui/noscript/downloads","issues_url":"https://api.github.com/repos/yandex-ui/noscript/issues{/number}","pulls_url":"https://api.github.com/repos/yandex-ui/noscript/pulls{/number}","milestones_url":"https://api.github.com/repos/yandex-ui/noscript/milestones{/number}","notifications_url":"https://api.github.com/repos/yandex-ui/noscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yandex-ui/noscript/labels{/name}","releases_url":"https://api.github.com/repos/yandex-ui/noscript/releases{/id}","created_at":"2011-08-28T14:55:35Z","updated_at":"2014-08-27T12:04:02Z","pushed_at":"2014-09-01T07:28:00Z","git_url":"git://github.com/yandex-ui/noscript.git","ssh_url":"git@github.com:yandex-ui/noscript.git","clone_url":"https://github.com/yandex-ui/noscript.git","svn_url":"https://github.com/yandex-ui/noscript","homepage":"","size":13564,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":16,"mirror_url":null,"open_issues_count":110,"forks":16,"open_issues":110,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yandex-ui/noscript/pulls/435"},"html":{"href":"https://github.com/yandex-ui/noscript/pull/435"},"issue":{"href":"https://api.github.com/repos/yandex-ui/noscript/issues/435"},"comments":{"href":"https://api.github.com/repos/yandex-ui/noscript/issues/435/comments"},"review_comments":{"href":"https://api.github.com/repos/yandex-ui/noscript/pulls/435/comments"},"review_comment":{"href":"https://api.github.com/repos/yandex-ui/noscript/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yandex-ui/noscript/pulls/435/commits"},"statuses":{"href":"https://api.github.com/repos/yandex-ui/noscript/statuses/b40b667792009e64d2ffc97c92f8918b84935283"}}}}