GitHub PullRequestReviewCommentEvent at 2014-11-12 23:35:33
Repository: xbmc
Actor: ulion
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/20261600","id":20261600,"diff_hunk":"@@ -76,6 +76,25 @@ void CCircularCache::Close()\n   m_buf = NULL;\n }\n \n+int64_t CCircularCache::GetCacheForward(const bool bAll /* = false */)\n+{\n+  CSingleLock lock(m_sync);\n+\n+  return (m_end - m_cur);\n+}\n+\n+bool CCircularCache::IsCacheFull(size_t iSize)","path":"xbmc/filesystem/CircularCache.cpp","position":11,"original_position":11,"commit_id":"483296d2970530dce2f7c64681d9632ae9fee813","original_commit_id":"483296d2970530dce2f7c64681d9632ae9fee813","user":{"login":"ulion","id":175133,"avatar_url":"https://avatars.githubusercontent.com/u/175133?v=3","gravatar_id":"","url":"https://api.github.com/users/ulion","html_url":"https://github.com/ulion","followers_url":"https://api.github.com/users/ulion/followers","following_url":"https://api.github.com/users/ulion/following{/other_user}","gists_url":"https://api.github.com/users/ulion/gists{/gist_id}","starred_url":"https://api.github.com/users/ulion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulion/subscriptions","organizations_url":"https://api.github.com/users/ulion/orgs","repos_url":"https://api.github.com/users/ulion/repos","events_url":"https://api.github.com/users/ulion/events{/privacy}","received_events_url":"https://api.github.com/users/ulion/received_events","type":"User","site_admin":false},"body":"the function name is not clear, consider a new name?","created_at":"2014-11-12T23:35:33Z","updated_at":"2014-11-12T23:35:33Z","html_url":"https://github.com/xbmc/xbmc/pull/5708#discussion_r20261600","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5708","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/20261600"},"html":{"href":"https://github.com/xbmc/xbmc/pull/5708#discussion_r20261600"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5708"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/5708","id":24315067,"html_url":"https://github.com/xbmc/xbmc/pull/5708","diff_url":"https://github.com/xbmc/xbmc/pull/5708.diff","patch_url":"https://github.com/xbmc/xbmc/pull/5708.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/5708","number":5708,"state":"open","locked":false,"title":"Double file cache fix. Fixes ticket #15500","user":{"login":"arnova","id":544531,"avatar_url":"https://avatars.githubusercontent.com/u/544531?v=3","gravatar_id":"","url":"https://api.github.com/users/arnova","html_url":"https://github.com/arnova","followers_url":"https://api.github.com/users/arnova/followers","following_url":"https://api.github.com/users/arnova/following{/other_user}","gists_url":"https://api.github.com/users/arnova/gists{/gist_id}","starred_url":"https://api.github.com/users/arnova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnova/subscriptions","organizations_url":"https://api.github.com/users/arnova/orgs","repos_url":"https://api.github.com/users/arnova/repos","events_url":"https://api.github.com/users/arnova/events{/privacy}","received_events_url":"https://api.github.com/users/arnova/received_events","type":"User","site_admin":false},"body":"Double caching for e.g. dvdplayer has been broken for a long time. While debugging this problem (which took quite some time) I also noticed that CurlFile didn't return the proper (read: most optimal) chunksize, furthermore FileCache never reported cache full. The actual problem for double cache was that when the cache was full, we still kept reading from the source which get disposed due to seek-requests which in turn also caused seek backs in the stream (which are really slow on e.g. http). This revealed itself while playing mp4 files with high a/v offset but generally this should improve performance (especially on slow systems) for all cached files.\r\n\r\nWould be great if this could be included for Helix.","created_at":"2014-11-12T18:49:12Z","updated_at":"2014-11-12T23:35:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"847db9736b6575db585dd74bc9b649c612df3b3d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5708/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5708/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/5708/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/483296d2970530dce2f7c64681d9632ae9fee813","head":{"label":"arnova:double_cache_inthread_fix","ref":"double_cache_inthread_fix","sha":"483296d2970530dce2f7c64681d9632ae9fee813","user":{"login":"arnova","id":544531,"avatar_url":"https://avatars.githubusercontent.com/u/544531?v=3","gravatar_id":"","url":"https://api.github.com/users/arnova","html_url":"https://github.com/arnova","followers_url":"https://api.github.com/users/arnova/followers","following_url":"https://api.github.com/users/arnova/following{/other_user}","gists_url":"https://api.github.com/users/arnova/gists{/gist_id}","starred_url":"https://api.github.com/users/arnova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnova/subscriptions","organizations_url":"https://api.github.com/users/arnova/orgs","repos_url":"https://api.github.com/users/arnova/repos","events_url":"https://api.github.com/users/arnova/events{/privacy}","received_events_url":"https://api.github.com/users/arnova/received_events","type":"User","site_admin":false},"repo":{"id":1396979,"name":"xbmc","full_name":"arnova/xbmc","owner":{"login":"arnova","id":544531,"avatar_url":"https://avatars.githubusercontent.com/u/544531?v=3","gravatar_id":"","url":"https://api.github.com/users/arnova","html_url":"https://github.com/arnova","followers_url":"https://api.github.com/users/arnova/followers","following_url":"https://api.github.com/users/arnova/following{/other_user}","gists_url":"https://api.github.com/users/arnova/gists{/gist_id}","starred_url":"https://api.github.com/users/arnova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnova/subscriptions","organizations_url":"https://api.github.com/users/arnova/orgs","repos_url":"https://api.github.com/users/arnova/repos","events_url":"https://api.github.com/users/arnova/events{/privacy}","received_events_url":"https://api.github.com/users/arnova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arnova/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/arnova/xbmc","forks_url":"https://api.github.com/repos/arnova/xbmc/forks","keys_url":"https://api.github.com/repos/arnova/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arnova/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arnova/xbmc/teams","hooks_url":"https://api.github.com/repos/arnova/xbmc/hooks","issue_events_url":"https://api.github.com/repos/arnova/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/arnova/xbmc/events","assignees_url":"https://api.github.com/repos/arnova/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/arnova/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/arnova/xbmc/tags","blobs_url":"https://api.github.com/repos/arnova/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arnova/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arnova/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/arnova/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arnova/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/arnova/xbmc/languages","stargazers_url":"https://api.github.com/repos/arnova/xbmc/stargazers","contributors_url":"https://api.github.com/repos/arnova/xbmc/contributors","subscribers_url":"https://api.github.com/repos/arnova/xbmc/subscribers","subscription_url":"https://api.github.com/repos/arnova/xbmc/subscription","commits_url":"https://api.github.com/repos/arnova/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/arnova/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/arnova/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/arnova/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/arnova/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/arnova/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arnova/xbmc/merges","archive_url":"https://api.github.com/repos/arnova/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arnova/xbmc/downloads","issues_url":"https://api.github.com/repos/arnova/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/arnova/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/arnova/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/arnova/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arnova/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/arnova/xbmc/releases{/id}","created_at":"2011-02-22T09:32:06Z","updated_at":"2014-07-13T09:21:06Z","pushed_at":"2014-11-12T21:29:21Z","git_url":"git://github.com/arnova/xbmc.git","ssh_url":"git@github.com:arnova/xbmc.git","clone_url":"https://github.com/arnova/xbmc.git","svn_url":"https://github.com/arnova/xbmc","homepage":"http://xbmc.org","size":470822,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"89dc834d92ade5046e4fd4a415843ed629b17ebc","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2014-11-12T22:38:30Z","pushed_at":"2014-11-12T20:44:22Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1796820,"stargazers_count":3457,"watchers_count":3457,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2460,"mirror_url":null,"open_issues_count":215,"forks":2460,"open_issues":215,"watchers":3457,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5708"},"html":{"href":"https://github.com/xbmc/xbmc/pull/5708"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/5708"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/5708/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5708/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5708/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/483296d2970530dce2f7c64681d9632ae9fee813"}}}}