GitHub PullRequestReviewCommentEvent at 2014-07-27 14:15:28
Repository: website
Actor: Hatlen
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/website/pulls/comments/15439435","id":15439435,"diff_hunk":"@@ -1280,14 +1280,16 @@ classes:\n       for a specific id, use `DS.Store`'s `find()` method:\n \n       ```javascript\n-      var person = store.find('person', 123);\n+      store.find('person', 123).then(function (person) {\n+      });\n       ```\n \n       If your application has multiple `DS.Store` instances (an unusual case), you can\n       specify which store should be used:\n \n       ```javascript\n-      var person = store.find('person', 123);\n+      store.find('person', 123).then(function (person) {\n+      });","path":"data/data_api.yml","position":15,"original_position":15,"commit_id":"a80841d2c38c7a33d4f38f3654def64e03ffcd49","original_commit_id":"a80841d2c38c7a33d4f38f3654def64e03ffcd49","user":{"login":"Hatlen","id":670740,"avatar_url":"https://avatars.githubusercontent.com/u/670740?","gravatar_id":"126f4ec1dee1bdf1a5d1c1b966ac684e","url":"https://api.github.com/users/Hatlen","html_url":"https://github.com/Hatlen","followers_url":"https://api.github.com/users/Hatlen/followers","following_url":"https://api.github.com/users/Hatlen/following{/other_user}","gists_url":"https://api.github.com/users/Hatlen/gists{/gist_id}","starred_url":"https://api.github.com/users/Hatlen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hatlen/subscriptions","organizations_url":"https://api.github.com/users/Hatlen/orgs","repos_url":"https://api.github.com/users/Hatlen/repos","events_url":"https://api.github.com/users/Hatlen/events{/privacy}","received_events_url":"https://api.github.com/users/Hatlen/received_events","type":"User","site_admin":false},"body":"@bmac here's the pull request on the ember data repo https://github.com/emberjs/data/pull/2128.\r\n\r\n","created_at":"2014-07-27T14:15:28Z","updated_at":"2014-07-27T14:15:28Z","html_url":"https://github.com/emberjs/website/pull/1625#discussion_r15439435","pull_request_url":"https://api.github.com/repos/emberjs/website/pulls/1625","_links":{"self":{"href":"https://api.github.com/repos/emberjs/website/pulls/comments/15439435"},"html":{"href":"https://github.com/emberjs/website/pull/1625#discussion_r15439435"},"pull_request":{"href":"https://api.github.com/repos/emberjs/website/pulls/1625"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/website/pulls/1625","id":18940167,"html_url":"https://github.com/emberjs/website/pull/1625","diff_url":"https://github.com/emberjs/website/pull/1625.diff","patch_url":"https://github.com/emberjs/website/pull/1625.patch","issue_url":"https://api.github.com/repos/emberjs/website/issues/1625","number":1625,"state":"closed","title":"Documentation fix, (find returns promises)","user":{"login":"Hatlen","id":670740,"avatar_url":"https://avatars.githubusercontent.com/u/670740?","gravatar_id":"126f4ec1dee1bdf1a5d1c1b966ac684e","url":"https://api.github.com/users/Hatlen","html_url":"https://github.com/Hatlen","followers_url":"https://api.github.com/users/Hatlen/followers","following_url":"https://api.github.com/users/Hatlen/following{/other_user}","gists_url":"https://api.github.com/users/Hatlen/gists{/gist_id}","starred_url":"https://api.github.com/users/Hatlen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hatlen/subscriptions","organizations_url":"https://api.github.com/users/Hatlen/orgs","repos_url":"https://api.github.com/users/Hatlen/repos","events_url":"https://api.github.com/users/Hatlen/events{/privacy}","received_events_url":"https://api.github.com/users/Hatlen/received_events","type":"User","site_admin":false},"body":"I tried to find all occurences when find was used as if it returned a post object and not a promise, but there might be some ones left.\r\n\r\nMaybe the lines that look like this: \r\n```js\r\nstore.find('post', 1).then(function (post) {\r\n});\r\n```\r\n\r\nWould benefit from some more explanation of the fact that it returns a promise object, but I'm not sure how one would do that.","created_at":"2014-07-27T11:49:24Z","updated_at":"2014-07-27T14:15:28Z","closed_at":"2014-07-27T12:37:09Z","merged_at":"2014-07-27T12:37:09Z","merge_commit_sha":"2f7cb752047f10f0d74043acb6d8b7747b035e52","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/website/pulls/1625/commits","review_comments_url":"https://api.github.com/repos/emberjs/website/pulls/1625/comments","review_comment_url":"https://api.github.com/repos/emberjs/website/pulls/comments/{number}","comments_url":"https://api.github.com/repos/emberjs/website/issues/1625/comments","statuses_url":"https://api.github.com/repos/emberjs/website/statuses/a80841d2c38c7a33d4f38f3654def64e03ffcd49","head":{"label":"Hatlen:find_returns_promises_fix","ref":"find_returns_promises_fix","sha":"a80841d2c38c7a33d4f38f3654def64e03ffcd49","user":{"login":"Hatlen","id":670740,"avatar_url":"https://avatars.githubusercontent.com/u/670740?","gravatar_id":"126f4ec1dee1bdf1a5d1c1b966ac684e","url":"https://api.github.com/users/Hatlen","html_url":"https://github.com/Hatlen","followers_url":"https://api.github.com/users/Hatlen/followers","following_url":"https://api.github.com/users/Hatlen/following{/other_user}","gists_url":"https://api.github.com/users/Hatlen/gists{/gist_id}","starred_url":"https://api.github.com/users/Hatlen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hatlen/subscriptions","organizations_url":"https://api.github.com/users/Hatlen/orgs","repos_url":"https://api.github.com/users/Hatlen/repos","events_url":"https://api.github.com/users/Hatlen/events{/privacy}","received_events_url":"https://api.github.com/users/Hatlen/received_events","type":"User","site_admin":false},"repo":{"id":21903134,"name":"website","full_name":"Hatlen/website","owner":{"login":"Hatlen","id":670740,"avatar_url":"https://avatars.githubusercontent.com/u/670740?","gravatar_id":"126f4ec1dee1bdf1a5d1c1b966ac684e","url":"https://api.github.com/users/Hatlen","html_url":"https://github.com/Hatlen","followers_url":"https://api.github.com/users/Hatlen/followers","following_url":"https://api.github.com/users/Hatlen/following{/other_user}","gists_url":"https://api.github.com/users/Hatlen/gists{/gist_id}","starred_url":"https://api.github.com/users/Hatlen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hatlen/subscriptions","organizations_url":"https://api.github.com/users/Hatlen/orgs","repos_url":"https://api.github.com/users/Hatlen/repos","events_url":"https://api.github.com/users/Hatlen/events{/privacy}","received_events_url":"https://api.github.com/users/Hatlen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hatlen/website","description":"Source for emberjs.com","fork":true,"url":"https://api.github.com/repos/Hatlen/website","forks_url":"https://api.github.com/repos/Hatlen/website/forks","keys_url":"https://api.github.com/repos/Hatlen/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hatlen/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hatlen/website/teams","hooks_url":"https://api.github.com/repos/Hatlen/website/hooks","issue_events_url":"https://api.github.com/repos/Hatlen/website/issues/events{/number}","events_url":"https://api.github.com/repos/Hatlen/website/events","assignees_url":"https://api.github.com/repos/Hatlen/website/assignees{/user}","branches_url":"https://api.github.com/repos/Hatlen/website/branches{/branch}","tags_url":"https://api.github.com/repos/Hatlen/website/tags","blobs_url":"https://api.github.com/repos/Hatlen/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hatlen/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hatlen/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hatlen/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hatlen/website/statuses/{sha}","languages_url":"https://api.github.com/repos/Hatlen/website/languages","stargazers_url":"https://api.github.com/repos/Hatlen/website/stargazers","contributors_url":"https://api.github.com/repos/Hatlen/website/contributors","subscribers_url":"https://api.github.com/repos/Hatlen/website/subscribers","subscription_url":"https://api.github.com/repos/Hatlen/website/subscription","commits_url":"https://api.github.com/repos/Hatlen/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hatlen/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hatlen/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hatlen/website/issues/comments/{number}","contents_url":"https://api.github.com/repos/Hatlen/website/contents/{+path}","compare_url":"https://api.github.com/repos/Hatlen/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hatlen/website/merges","archive_url":"https://api.github.com/repos/Hatlen/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hatlen/website/downloads","issues_url":"https://api.github.com/repos/Hatlen/website/issues{/number}","pulls_url":"https://api.github.com/repos/Hatlen/website/pulls{/number}","milestones_url":"https://api.github.com/repos/Hatlen/website/milestones{/number}","notifications_url":"https://api.github.com/repos/Hatlen/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hatlen/website/labels{/name}","releases_url":"https://api.github.com/repos/Hatlen/website/releases{/id}","created_at":"2014-07-16T14:05:42Z","updated_at":"2014-07-27T11:34:47Z","pushed_at":"2014-07-27T11:40:35Z","git_url":"git://github.com/Hatlen/website.git","ssh_url":"git@github.com:Hatlen/website.git","clone_url":"https://github.com/Hatlen/website.git","svn_url":"https://github.com/Hatlen/website","homepage":"","size":39732,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"ebdf282c1a0ee1fd7623126c7ecce1e00dfe0e21","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?","gravatar_id":"792333d2bad390e8a2e23f5e2f41f214","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":2649031,"name":"website","full_name":"emberjs/website","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?","gravatar_id":"792333d2bad390e8a2e23f5e2f41f214","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/website","description":"Source for emberjs.com","fork":false,"url":"https://api.github.com/repos/emberjs/website","forks_url":"https://api.github.com/repos/emberjs/website/forks","keys_url":"https://api.github.com/repos/emberjs/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/website/teams","hooks_url":"https://api.github.com/repos/emberjs/website/hooks","issue_events_url":"https://api.github.com/repos/emberjs/website/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/website/events","assignees_url":"https://api.github.com/repos/emberjs/website/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/website/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/website/tags","blobs_url":"https://api.github.com/repos/emberjs/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/website/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/website/languages","stargazers_url":"https://api.github.com/repos/emberjs/website/stargazers","contributors_url":"https://api.github.com/repos/emberjs/website/contributors","subscribers_url":"https://api.github.com/repos/emberjs/website/subscribers","subscription_url":"https://api.github.com/repos/emberjs/website/subscription","commits_url":"https://api.github.com/repos/emberjs/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/website/issues/comments/{number}","contents_url":"https://api.github.com/repos/emberjs/website/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/website/merges","archive_url":"https://api.github.com/repos/emberjs/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/website/downloads","issues_url":"https://api.github.com/repos/emberjs/website/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/website/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/website/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/website/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/website/releases{/id}","created_at":"2011-10-26T05:30:05Z","updated_at":"2014-07-26T03:18:35Z","pushed_at":"2014-07-27T12:37:11Z","git_url":"git://github.com/emberjs/website.git","ssh_url":"git@github.com:emberjs/website.git","clone_url":"https://github.com/emberjs/website.git","svn_url":"https://github.com/emberjs/website","homepage":"","size":53989,"stargazers_count":388,"watchers_count":388,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":931,"mirror_url":null,"open_issues_count":93,"forks":931,"open_issues":93,"watchers":388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/website/pulls/1625"},"html":{"href":"https://github.com/emberjs/website/pull/1625"},"issue":{"href":"https://api.github.com/repos/emberjs/website/issues/1625"},"comments":{"href":"https://api.github.com/repos/emberjs/website/issues/1625/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/website/pulls/1625/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/website/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/emberjs/website/pulls/1625/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/website/statuses/a80841d2c38c7a33d4f38f3654def64e03ffcd49"}}}}