GitHub PullRequestReviewCommentEvent at 2014-03-24 14:51:52
Repository: qmore
Actor: james-lawrence
Payload: {"comment":{"url":"https://api.github.com/repos/wr0ngway/qmore/pulls/comments/10887446","id":10887446,"diff_hunk":"@@ -14,12 +14,19 @@ Alternatively, if you have some other way of launching workers (e.g. qless-pool)\n \n     Qless::Pool.pool_factory.reserver_class = Qmore::JobReserver\n     Qmore.client == Qless::Pool.pool_factory.client\n+    # Redis persistance defaults to using the Qmore.client.\n+    Qmore.persistance = Qless::Persistance::Redis.new(Qmore.client.redis)\n+    # Configure the monitor thread with the persistance type, and the interval at which to update\n+    # Monitor defaults to using Qmore.persistance and 2 minutes\n+    Qmore.monitor = Qless::persistance::Monitor.new(Qmore.persistance, 120)","path":"README.md","position":8,"original_position":8,"commit_id":"5e20a85550cd7dd5604aa4f57b296fb89d17d6a7","original_commit_id":"5e20a85550cd7dd5604aa4f57b296fb89d17d6a7","user":{"login":"james-lawrence","id":2835871,"avatar_url":"https://avatars.githubusercontent.com/u/2835871?","gravatar_id":"eb42cde590e78871dc6e36fea655a35a","url":"https://api.github.com/users/james-lawrence","html_url":"https://github.com/james-lawrence","followers_url":"https://api.github.com/users/james-lawrence/followers","following_url":"https://api.github.com/users/james-lawrence/following{/other_user}","gists_url":"https://api.github.com/users/james-lawrence/gists{/gist_id}","starred_url":"https://api.github.com/users/james-lawrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-lawrence/subscriptions","organizations_url":"https://api.github.com/users/james-lawrence/orgs","repos_url":"https://api.github.com/users/james-lawrence/repos","events_url":"https://api.github.com/users/james-lawrence/events{/privacy}","received_events_url":"https://api.github.com/users/james-lawrence/received_events","type":"User","site_admin":false},"body":"disagree. having the separate class for monitoring allows more flexibility.\r\nFor example if I write a file based persistence object how I have to include how to monitor it as well?\r\nSame goes if I want a different monitoring strategy for example publish/subscribe. Now I need to update every persistence class?\r\n\r\nThey are two very different responsibilities.","created_at":"2014-03-24T14:51:52Z","updated_at":"2014-03-24T14:51:52Z","html_url":"https://github.com/wr0ngway/qmore/pull/6#discussion_r10887446","pull_request_url":"https://api.github.com/repos/wr0ngway/qmore/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/wr0ngway/qmore/pulls/comments/10887446"},"html":{"href":"https://github.com/wr0ngway/qmore/pull/6#discussion_r10887446"},"pull_request":{"href":"https://api.github.com/repos/wr0ngway/qmore/pulls/6"}}}}