GitHub PullRequestReviewCommentEvent at 2014-09-26 15:17:09
Repository: accumulo
Actor: joshelser
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/accumulo/pulls/comments/18094633","id":18094633,"diff_hunk":"@@ -103,6 +103,25 @@\n   void create(String tableName, boolean versioningIter, TimeType timeType) throws AccumuloException, AccumuloSecurityException, TableExistsException;\n \n   /**\n+   * @param tableName\n+   *          the name of the table\n+   * @param limitVersion\n+   *          Enables/disables the versioning iterator, which will limit the number of Key versions kept.\n+   * @param timeType\n+   *          specifies logical or real-time based time recording for entries in the table\n+   * @param properties\n+   *          initial table properties the user wants\n+   * @throws AccumuloException\n+   *           if a general error occurs\n+   * @throws AccumuloSecurityException\n+   *           if the user does not have permission\n+   * @throws TableExistsException\n+   *           if the table already exists\n+   */\n+  void create(String tableName, boolean limitVersion, TimeType timeType, Map<String,String> properties) throws AccumuloException, AccumuloSecurityException,","path":"core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java","position":19,"original_position":19,"commit_id":"202252344a0ba11eb8121dcbbb37604a91852d35","original_commit_id":"202252344a0ba11eb8121dcbbb37604a91852d35","user":{"login":"joshelser","id":67863,"avatar_url":"https://avatars.githubusercontent.com/u/67863?v=2","gravatar_id":"","url":"https://api.github.com/users/joshelser","html_url":"https://github.com/joshelser","followers_url":"https://api.github.com/users/joshelser/followers","following_url":"https://api.github.com/users/joshelser/following{/other_user}","gists_url":"https://api.github.com/users/joshelser/gists{/gist_id}","starred_url":"https://api.github.com/users/joshelser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshelser/subscriptions","organizations_url":"https://api.github.com/users/joshelser/orgs","repos_url":"https://api.github.com/users/joshelser/repos","events_url":"https://api.github.com/users/joshelser/events{/privacy}","received_events_url":"https://api.github.com/users/joshelser/received_events","type":"User","site_admin":false},"body":"Thanks for the details everyone. I forgot about tablets not moving across volumes (and thus the default tablet could get stuck elsewhere). No need to split out those changes or make a separate issue for them.","created_at":"2014-09-26T15:17:09Z","updated_at":"2014-09-26T15:17:09Z","html_url":"https://github.com/apache/accumulo/pull/16#discussion_r18094633","pull_request_url":"https://api.github.com/repos/apache/accumulo/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments/18094633"},"html":{"href":"https://github.com/apache/accumulo/pull/16#discussion_r18094633"},"pull_request":{"href":"https://api.github.com/repos/apache/accumulo/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/apache/accumulo/pulls/16","id":21663067,"html_url":"https://github.com/apache/accumulo/pull/16","diff_url":"https://github.com/apache/accumulo/pull/16.diff","patch_url":"https://github.com/apache/accumulo/pull/16.patch","issue_url":"https://api.github.com/repos/apache/accumulo/issues/16","number":16,"state":"open","locked":false,"title":"ACCUMULO-3089: Create volume chooser from table properties","user":{"login":"hustjl22","id":8439441,"avatar_url":"https://avatars.githubusercontent.com/u/8439441?v=2","gravatar_id":"","url":"https://api.github.com/users/hustjl22","html_url":"https://github.com/hustjl22","followers_url":"https://api.github.com/users/hustjl22/followers","following_url":"https://api.github.com/users/hustjl22/following{/other_user}","gists_url":"https://api.github.com/users/hustjl22/gists{/gist_id}","starred_url":"https://api.github.com/users/hustjl22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hustjl22/subscriptions","organizations_url":"https://api.github.com/users/hustjl22/orgs","repos_url":"https://api.github.com/users/hustjl22/repos","events_url":"https://api.github.com/users/hustjl22/events{/privacy}","received_events_url":"https://api.github.com/users/hustjl22/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-23T17:45:23Z","updated_at":"2014-09-26T15:17:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c0c2ed8aaf4a163c35d225adb9ffc31cf857045","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/accumulo/pulls/16/commits","review_comments_url":"https://api.github.com/repos/apache/accumulo/pulls/16/comments","review_comment_url":"https://api.github.com/repos/apache/accumulo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/accumulo/issues/16/comments","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/202252344a0ba11eb8121dcbbb37604a91852d35","head":{"label":"hustjl22:ACCUMULO-3089","ref":"ACCUMULO-3089","sha":"202252344a0ba11eb8121dcbbb37604a91852d35","user":{"login":"hustjl22","id":8439441,"avatar_url":"https://avatars.githubusercontent.com/u/8439441?v=2","gravatar_id":"","url":"https://api.github.com/users/hustjl22","html_url":"https://github.com/hustjl22","followers_url":"https://api.github.com/users/hustjl22/followers","following_url":"https://api.github.com/users/hustjl22/following{/other_user}","gists_url":"https://api.github.com/users/hustjl22/gists{/gist_id}","starred_url":"https://api.github.com/users/hustjl22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hustjl22/subscriptions","organizations_url":"https://api.github.com/users/hustjl22/orgs","repos_url":"https://api.github.com/users/hustjl22/repos","events_url":"https://api.github.com/users/hustjl22/events{/privacy}","received_events_url":"https://api.github.com/users/hustjl22/received_events","type":"User","site_admin":false},"repo":{"id":22919401,"name":"accumulo","full_name":"hustjl22/accumulo","owner":{"login":"hustjl22","id":8439441,"avatar_url":"https://avatars.githubusercontent.com/u/8439441?v=2","gravatar_id":"","url":"https://api.github.com/users/hustjl22","html_url":"https://github.com/hustjl22","followers_url":"https://api.github.com/users/hustjl22/followers","following_url":"https://api.github.com/users/hustjl22/following{/other_user}","gists_url":"https://api.github.com/users/hustjl22/gists{/gist_id}","starred_url":"https://api.github.com/users/hustjl22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hustjl22/subscriptions","organizations_url":"https://api.github.com/users/hustjl22/orgs","repos_url":"https://api.github.com/users/hustjl22/repos","events_url":"https://api.github.com/users/hustjl22/events{/privacy}","received_events_url":"https://api.github.com/users/hustjl22/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hustjl22/accumulo","description":"Mirror of Apache Accumulo","fork":true,"url":"https://api.github.com/repos/hustjl22/accumulo","forks_url":"https://api.github.com/repos/hustjl22/accumulo/forks","keys_url":"https://api.github.com/repos/hustjl22/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hustjl22/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hustjl22/accumulo/teams","hooks_url":"https://api.github.com/repos/hustjl22/accumulo/hooks","issue_events_url":"https://api.github.com/repos/hustjl22/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/hustjl22/accumulo/events","assignees_url":"https://api.github.com/repos/hustjl22/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/hustjl22/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/hustjl22/accumulo/tags","blobs_url":"https://api.github.com/repos/hustjl22/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hustjl22/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hustjl22/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/hustjl22/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hustjl22/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/hustjl22/accumulo/languages","stargazers_url":"https://api.github.com/repos/hustjl22/accumulo/stargazers","contributors_url":"https://api.github.com/repos/hustjl22/accumulo/contributors","subscribers_url":"https://api.github.com/repos/hustjl22/accumulo/subscribers","subscription_url":"https://api.github.com/repos/hustjl22/accumulo/subscription","commits_url":"https://api.github.com/repos/hustjl22/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/hustjl22/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/hustjl22/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/hustjl22/accumulo/issues/comments/{number}","contents_url":"https://api.github.com/repos/hustjl22/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/hustjl22/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hustjl22/accumulo/merges","archive_url":"https://api.github.com/repos/hustjl22/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hustjl22/accumulo/downloads","issues_url":"https://api.github.com/repos/hustjl22/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/hustjl22/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/hustjl22/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/hustjl22/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hustjl22/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/hustjl22/accumulo/releases{/id}","created_at":"2014-08-13T14:53:25Z","updated_at":"2014-08-14T14:09:07Z","pushed_at":"2014-09-23T16:49:19Z","git_url":"git://github.com/hustjl22/accumulo.git","ssh_url":"git@github.com:hustjl22/accumulo.git","clone_url":"https://github.com/hustjl22/accumulo.git","svn_url":"https://github.com/hustjl22/accumulo","homepage":"","size":31463,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a697516751426ec5143cea860ed6cbbaa85cf9af","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2524488,"name":"accumulo","full_name":"apache/accumulo","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/accumulo","description":"Mirror of Apache Accumulo","fork":false,"url":"https://api.github.com/repos/apache/accumulo","forks_url":"https://api.github.com/repos/apache/accumulo/forks","keys_url":"https://api.github.com/repos/apache/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/accumulo/teams","hooks_url":"https://api.github.com/repos/apache/accumulo/hooks","issue_events_url":"https://api.github.com/repos/apache/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/accumulo/events","assignees_url":"https://api.github.com/repos/apache/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/accumulo/tags","blobs_url":"https://api.github.com/repos/apache/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/accumulo/languages","stargazers_url":"https://api.github.com/repos/apache/accumulo/stargazers","contributors_url":"https://api.github.com/repos/apache/accumulo/contributors","subscribers_url":"https://api.github.com/repos/apache/accumulo/subscribers","subscription_url":"https://api.github.com/repos/apache/accumulo/subscription","commits_url":"https://api.github.com/repos/apache/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/accumulo/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/accumulo/merges","archive_url":"https://api.github.com/repos/apache/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/accumulo/downloads","issues_url":"https://api.github.com/repos/apache/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/apache/accumulo/releases{/id}","created_at":"2011-10-06T07:00:09Z","updated_at":"2014-09-25T13:52:13Z","pushed_at":"2014-09-26T01:15:39Z","git_url":"git://github.com/apache/accumulo.git","ssh_url":"git@github.com:apache/accumulo.git","clone_url":"https://github.com/apache/accumulo.git","svn_url":"https://github.com/apache/accumulo","homepage":"","size":69678,"stargazers_count":117,"watchers_count":117,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":"git://git.apache.org/accumulo.git","open_issues_count":2,"forks":74,"open_issues":2,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/16"},"html":{"href":"https://github.com/apache/accumulo/pull/16"},"issue":{"href":"https://api.github.com/repos/apache/accumulo/issues/16"},"comments":{"href":"https://api.github.com/repos/apache/accumulo/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/accumulo/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/accumulo/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/apache/accumulo/statuses/202252344a0ba11eb8121dcbbb37604a91852d35"}}}}