GitHub PullRequestReviewCommentEvent at 2014-12-12 08:13:55
Repository: cstore_fdw
Actor: pykello
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/citusdata/cstore_fdw/pulls/comments/21732210","id":21732210,"diff_hunk":"@@ -443,6 +525,63 @@ CopyIntoCStoreTable(const CopyStmt *copyStatement, const char *queryString)\n \n \n /*\n+ * CopyFromCStoreTable handles a \"COPY cstore_table TO ...\" statement. Statement\n+ * is converted to \"COPY (SELECT * FROM cstore_table) TO ...\" and forwarded to\n+ * postgres native COPY handler. Function returns number of files copied to external\n+ * stream. Copying selected columns from cstore table is not currently supported.\n+ */\n+static uint64\n+CopyOutCStoreTable(CopyStmt* copyStatement, const char* queryString)\n+{\n+\t/*\n+\t * Re-write query to be in form of\n+\t * \"COPY (SELECT * FROM <cstore_table>) TO .....\".\n+\t */","path":"cstore_fdw.c","position":324,"original_position":324,"commit_id":"e2bb6204e4bf21d83b11edba3dcdc2c0734813cc","original_commit_id":"e2bb6204e4bf21d83b11edba3dcdc2c0734813cc","user":{"login":"pykello","id":628106,"avatar_url":"https://avatars.githubusercontent.com/u/628106?v=3","gravatar_id":"","url":"https://api.github.com/users/pykello","html_url":"https://github.com/pykello","followers_url":"https://api.github.com/users/pykello/followers","following_url":"https://api.github.com/users/pykello/following{/other_user}","gists_url":"https://api.github.com/users/pykello/gists{/gist_id}","starred_url":"https://api.github.com/users/pykello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pykello/subscriptions","organizations_url":"https://api.github.com/users/pykello/orgs","repos_url":"https://api.github.com/users/pykello/repos","events_url":"https://api.github.com/users/pykello/events{/privacy}","received_events_url":"https://api.github.com/users/pykello/received_events","type":"User","site_admin":false},"body":"We have already mentioned this in the function comments. I think we can remove this from here.","created_at":"2014-12-12T08:13:55Z","updated_at":"2014-12-12T08:13:55Z","html_url":"https://github.com/citusdata/cstore_fdw/pull/42#discussion_r21732210","pull_request_url":"https://api.github.com/repos/citusdata/cstore_fdw/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/citusdata/cstore_fdw/pulls/comments/21732210"},"html":{"href":"https://github.com/citusdata/cstore_fdw/pull/42#discussion_r21732210"},"pull_request":{"href":"https://api.github.com/repos/citusdata/cstore_fdw/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/citusdata/cstore_fdw/pulls/42","id":25887053,"html_url":"https://github.com/citusdata/cstore_fdw/pull/42","diff_url":"https://github.com/citusdata/cstore_fdw/pull/42.diff","patch_url":"https://github.com/citusdata/cstore_fdw/pull/42.patch","issue_url":"https://api.github.com/repos/citusdata/cstore_fdw/issues/42","number":42,"state":"open","locked":false,"title":"Implemented COPY <cstore_table> TO ... feature","user":{"login":"mtuncer","id":9413470,"avatar_url":"https://avatars.githubusercontent.com/u/9413470?v=3","gravatar_id":"","url":"https://api.github.com/users/mtuncer","html_url":"https://github.com/mtuncer","followers_url":"https://api.github.com/users/mtuncer/followers","following_url":"https://api.github.com/users/mtuncer/following{/other_user}","gists_url":"https://api.github.com/users/mtuncer/gists{/gist_id}","starred_url":"https://api.github.com/users/mtuncer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtuncer/subscriptions","organizations_url":"https://api.github.com/users/mtuncer/orgs","repos_url":"https://api.github.com/users/mtuncer/repos","events_url":"https://api.github.com/users/mtuncer/events{/privacy}","received_events_url":"https://api.github.com/users/mtuncer/received_events","type":"User","site_admin":false},"body":"COPY <cstore_table> TO ... statement is converted to COPY (select * from <cstore_table>) TO ... format and forwarded to native COPY function of postgresql\r\n\r\nA minor bug in drop command is fixed to allow dropping of multiple cstore tables at once.","created_at":"2014-12-11T09:42:51Z","updated_at":"2014-12-12T08:13:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39d94e454f302865752d4a68ae13897c0789e3a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citusdata/cstore_fdw/pulls/42/commits","review_comments_url":"https://api.github.com/repos/citusdata/cstore_fdw/pulls/42/comments","review_comment_url":"https://api.github.com/repos/citusdata/cstore_fdw/pulls/comments/{number}","comments_url":"https://api.github.com/repos/citusdata/cstore_fdw/issues/42/comments","statuses_url":"https://api.github.com/repos/citusdata/cstore_fdw/statuses/e2bb6204e4bf21d83b11edba3dcdc2c0734813cc","head":{"label":"mtuncer:develop","ref":"develop","sha":"e2bb6204e4bf21d83b11edba3dcdc2c0734813cc","user":{"login":"mtuncer","id":9413470,"avatar_url":"https://avatars.githubusercontent.com/u/9413470?v=3","gravatar_id":"","url":"https://api.github.com/users/mtuncer","html_url":"https://github.com/mtuncer","followers_url":"https://api.github.com/users/mtuncer/followers","following_url":"https://api.github.com/users/mtuncer/following{/other_user}","gists_url":"https://api.github.com/users/mtuncer/gists{/gist_id}","starred_url":"https://api.github.com/users/mtuncer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtuncer/subscriptions","organizations_url":"https://api.github.com/users/mtuncer/orgs","repos_url":"https://api.github.com/users/mtuncer/repos","events_url":"https://api.github.com/users/mtuncer/events{/privacy}","received_events_url":"https://api.github.com/users/mtuncer/received_events","type":"User","site_admin":false},"repo":{"id":26799055,"name":"cstore_fdw","full_name":"mtuncer/cstore_fdw","owner":{"login":"mtuncer","id":9413470,"avatar_url":"https://avatars.githubusercontent.com/u/9413470?v=3","gravatar_id":"","url":"https://api.github.com/users/mtuncer","html_url":"https://github.com/mtuncer","followers_url":"https://api.github.com/users/mtuncer/followers","following_url":"https://api.github.com/users/mtuncer/following{/other_user}","gists_url":"https://api.github.com/users/mtuncer/gists{/gist_id}","starred_url":"https://api.github.com/users/mtuncer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtuncer/subscriptions","organizations_url":"https://api.github.com/users/mtuncer/orgs","repos_url":"https://api.github.com/users/mtuncer/repos","events_url":"https://api.github.com/users/mtuncer/events{/privacy}","received_events_url":"https://api.github.com/users/mtuncer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtuncer/cstore_fdw","description":"Fast columnar store for analytics with PostgreSQL","fork":true,"url":"https://api.github.com/repos/mtuncer/cstore_fdw","forks_url":"https://api.github.com/repos/mtuncer/cstore_fdw/forks","keys_url":"https://api.github.com/repos/mtuncer/cstore_fdw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtuncer/cstore_fdw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtuncer/cstore_fdw/teams","hooks_url":"https://api.github.com/repos/mtuncer/cstore_fdw/hooks","issue_events_url":"https://api.github.com/repos/mtuncer/cstore_fdw/issues/events{/number}","events_url":"https://api.github.com/repos/mtuncer/cstore_fdw/events","assignees_url":"https://api.github.com/repos/mtuncer/cstore_fdw/assignees{/user}","branches_url":"https://api.github.com/repos/mtuncer/cstore_fdw/branches{/branch}","tags_url":"https://api.github.com/repos/mtuncer/cstore_fdw/tags","blobs_url":"https://api.github.com/repos/mtuncer/cstore_fdw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtuncer/cstore_fdw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtuncer/cstore_fdw/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtuncer/cstore_fdw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtuncer/cstore_fdw/statuses/{sha}","languages_url":"https://api.github.com/repos/mtuncer/cstore_fdw/languages","stargazers_url":"https://api.github.com/repos/mtuncer/cstore_fdw/stargazers","contributors_url":"https://api.github.com/repos/mtuncer/cstore_fdw/contributors","subscribers_url":"https://api.github.com/repos/mtuncer/cstore_fdw/subscribers","subscription_url":"https://api.github.com/repos/mtuncer/cstore_fdw/subscription","commits_url":"https://api.github.com/repos/mtuncer/cstore_fdw/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtuncer/cstore_fdw/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtuncer/cstore_fdw/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtuncer/cstore_fdw/issues/comments/{number}","contents_url":"https://api.github.com/repos/mtuncer/cstore_fdw/contents/{+path}","compare_url":"https://api.github.com/repos/mtuncer/cstore_fdw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtuncer/cstore_fdw/merges","archive_url":"https://api.github.com/repos/mtuncer/cstore_fdw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtuncer/cstore_fdw/downloads","issues_url":"https://api.github.com/repos/mtuncer/cstore_fdw/issues{/number}","pulls_url":"https://api.github.com/repos/mtuncer/cstore_fdw/pulls{/number}","milestones_url":"https://api.github.com/repos/mtuncer/cstore_fdw/milestones{/number}","notifications_url":"https://api.github.com/repos/mtuncer/cstore_fdw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtuncer/cstore_fdw/labels{/name}","releases_url":"https://api.github.com/repos/mtuncer/cstore_fdw/releases{/id}","created_at":"2014-11-18T08:17:00Z","updated_at":"2014-11-18T08:17:01Z","pushed_at":"2014-12-11T14:47:05Z","git_url":"git://github.com/mtuncer/cstore_fdw.git","ssh_url":"git@github.com:mtuncer/cstore_fdw.git","clone_url":"https://github.com/mtuncer/cstore_fdw.git","svn_url":"https://github.com/mtuncer/cstore_fdw","homepage":"http://citusdata.github.io/cstore_fdw/","size":416,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citusdata:develop","ref":"develop","sha":"968d37db3f2e1db33fdeea3ffc85aeb3a243d9d1","user":{"login":"citusdata","id":2545424,"avatar_url":"https://avatars.githubusercontent.com/u/2545424?v=3","gravatar_id":"","url":"https://api.github.com/users/citusdata","html_url":"https://github.com/citusdata","followers_url":"https://api.github.com/users/citusdata/followers","following_url":"https://api.github.com/users/citusdata/following{/other_user}","gists_url":"https://api.github.com/users/citusdata/gists{/gist_id}","starred_url":"https://api.github.com/users/citusdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citusdata/subscriptions","organizations_url":"https://api.github.com/users/citusdata/orgs","repos_url":"https://api.github.com/users/citusdata/repos","events_url":"https://api.github.com/users/citusdata/events{/privacy}","received_events_url":"https://api.github.com/users/citusdata/received_events","type":"Organization","site_admin":false},"repo":{"id":18400513,"name":"cstore_fdw","full_name":"citusdata/cstore_fdw","owner":{"login":"citusdata","id":2545424,"avatar_url":"https://avatars.githubusercontent.com/u/2545424?v=3","gravatar_id":"","url":"https://api.github.com/users/citusdata","html_url":"https://github.com/citusdata","followers_url":"https://api.github.com/users/citusdata/followers","following_url":"https://api.github.com/users/citusdata/following{/other_user}","gists_url":"https://api.github.com/users/citusdata/gists{/gist_id}","starred_url":"https://api.github.com/users/citusdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citusdata/subscriptions","organizations_url":"https://api.github.com/users/citusdata/orgs","repos_url":"https://api.github.com/users/citusdata/repos","events_url":"https://api.github.com/users/citusdata/events{/privacy}","received_events_url":"https://api.github.com/users/citusdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citusdata/cstore_fdw","description":"Fast columnar store for analytics with PostgreSQL","fork":false,"url":"https://api.github.com/repos/citusdata/cstore_fdw","forks_url":"https://api.github.com/repos/citusdata/cstore_fdw/forks","keys_url":"https://api.github.com/repos/citusdata/cstore_fdw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citusdata/cstore_fdw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citusdata/cstore_fdw/teams","hooks_url":"https://api.github.com/repos/citusdata/cstore_fdw/hooks","issue_events_url":"https://api.github.com/repos/citusdata/cstore_fdw/issues/events{/number}","events_url":"https://api.github.com/repos/citusdata/cstore_fdw/events","assignees_url":"https://api.github.com/repos/citusdata/cstore_fdw/assignees{/user}","branches_url":"https://api.github.com/repos/citusdata/cstore_fdw/branches{/branch}","tags_url":"https://api.github.com/repos/citusdata/cstore_fdw/tags","blobs_url":"https://api.github.com/repos/citusdata/cstore_fdw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citusdata/cstore_fdw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citusdata/cstore_fdw/git/refs{/sha}","trees_url":"https://api.github.com/repos/citusdata/cstore_fdw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citusdata/cstore_fdw/statuses/{sha}","languages_url":"https://api.github.com/repos/citusdata/cstore_fdw/languages","stargazers_url":"https://api.github.com/repos/citusdata/cstore_fdw/stargazers","contributors_url":"https://api.github.com/repos/citusdata/cstore_fdw/contributors","subscribers_url":"https://api.github.com/repos/citusdata/cstore_fdw/subscribers","subscription_url":"https://api.github.com/repos/citusdata/cstore_fdw/subscription","commits_url":"https://api.github.com/repos/citusdata/cstore_fdw/commits{/sha}","git_commits_url":"https://api.github.com/repos/citusdata/cstore_fdw/git/commits{/sha}","comments_url":"https://api.github.com/repos/citusdata/cstore_fdw/comments{/number}","issue_comment_url":"https://api.github.com/repos/citusdata/cstore_fdw/issues/comments/{number}","contents_url":"https://api.github.com/repos/citusdata/cstore_fdw/contents/{+path}","compare_url":"https://api.github.com/repos/citusdata/cstore_fdw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citusdata/cstore_fdw/merges","archive_url":"https://api.github.com/repos/citusdata/cstore_fdw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citusdata/cstore_fdw/downloads","issues_url":"https://api.github.com/repos/citusdata/cstore_fdw/issues{/number}","pulls_url":"https://api.github.com/repos/citusdata/cstore_fdw/pulls{/number}","milestones_url":"https://api.github.com/repos/citusdata/cstore_fdw/milestones{/number}","notifications_url":"https://api.github.com/repos/citusdata/cstore_fdw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citusdata/cstore_fdw/labels{/name}","releases_url":"https://api.github.com/repos/citusdata/cstore_fdw/releases{/id}","created_at":"2014-04-03T11:24:43Z","updated_at":"2014-12-12T03:13:17Z","pushed_at":"2014-12-10T14:47:07Z","git_url":"git://github.com/citusdata/cstore_fdw.git","ssh_url":"git@github.com:citusdata/cstore_fdw.git","clone_url":"https://github.com/citusdata/cstore_fdw.git","svn_url":"https://github.com/citusdata/cstore_fdw","homepage":"http://citusdata.github.io/cstore_fdw/","size":1833,"stargazers_count":316,"watchers_count":316,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":14,"forks":29,"open_issues":14,"watchers":316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citusdata/cstore_fdw/pulls/42"},"html":{"href":"https://github.com/citusdata/cstore_fdw/pull/42"},"issue":{"href":"https://api.github.com/repos/citusdata/cstore_fdw/issues/42"},"comments":{"href":"https://api.github.com/repos/citusdata/cstore_fdw/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/citusdata/cstore_fdw/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/citusdata/cstore_fdw/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/citusdata/cstore_fdw/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/citusdata/cstore_fdw/statuses/e2bb6204e4bf21d83b11edba3dcdc2c0734813cc"}}}}