GitHub PullRequestReviewCommentEvent at 2014-12-26 11:25:42
Repository: oxyplot
Actor: objorke
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/oxyplot/oxyplot/pulls/comments/22282346","id":22282346,"diff_hunk":"@@ -499,8 +499,9 @@ public void DrawRectangles(IList<OxyRect> rectangles, OxyColor fill, OxyColor st\n         /// <param name=\"fontFamily\">The font family.</param>\n         /// <param name=\"fontSize\">Size of the font.</param>\n         /// <param name=\"fontWeight\">The font weight.</param>\n+        /// <param name=\"angle\">The text angle.</param>\n         /// <returns>The text size.</returns>\n-        public OxySize MeasureText(string text, string fontFamily, double fontSize, double fontWeight)\n+        public OxySize MeasureText(string text, string fontFamily, double fontSize, double fontWeight, double angle = 0)","path":"Source/OxyPlot.WindowsUniversal/RenderContext.cs","position":7,"original_position":7,"commit_id":"d167bfd4dee88f923a46149c2ac271c273f2c5f4","original_commit_id":"d167bfd4dee88f923a46149c2ac271c273f2c5f4","user":{"login":"objorke","id":439716,"avatar_url":"https://avatars.githubusercontent.com/u/439716?v=3","gravatar_id":"","url":"https://api.github.com/users/objorke","html_url":"https://github.com/objorke","followers_url":"https://api.github.com/users/objorke/followers","following_url":"https://api.github.com/users/objorke/following{/other_user}","gists_url":"https://api.github.com/users/objorke/gists{/gist_id}","starred_url":"https://api.github.com/users/objorke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objorke/subscriptions","organizations_url":"https://api.github.com/users/objorke/orgs","repos_url":"https://api.github.com/users/objorke/repos","events_url":"https://api.github.com/users/objorke/events{/privacy}","received_events_url":"https://api.github.com/users/objorke/received_events","type":"User","site_admin":false},"body":"revert","created_at":"2014-12-26T11:25:42Z","updated_at":"2014-12-26T11:25:42Z","html_url":"https://github.com/oxyplot/oxyplot/pull/297#discussion_r22282346","pull_request_url":"https://api.github.com/repos/oxyplot/oxyplot/pulls/297","_links":{"self":{"href":"https://api.github.com/repos/oxyplot/oxyplot/pulls/comments/22282346"},"html":{"href":"https://github.com/oxyplot/oxyplot/pull/297#discussion_r22282346"},"pull_request":{"href":"https://api.github.com/repos/oxyplot/oxyplot/pulls/297"}}},"pull_request":{"url":"https://api.github.com/repos/oxyplot/oxyplot/pulls/297","id":26561642,"html_url":"https://github.com/oxyplot/oxyplot/pull/297","diff_url":"https://github.com/oxyplot/oxyplot/pull/297.diff","patch_url":"https://github.com/oxyplot/oxyplot/pull/297.patch","issue_url":"https://api.github.com/repos/oxyplot/oxyplot/issues/297","number":297,"state":"open","locked":false,"title":"Xaxis label cuts off bugfix","user":{"login":"archeg","id":700094,"avatar_url":"https://avatars.githubusercontent.com/u/700094?v=3","gravatar_id":"","url":"https://api.github.com/users/archeg","html_url":"https://github.com/archeg","followers_url":"https://api.github.com/users/archeg/followers","following_url":"https://api.github.com/users/archeg/following{/other_user}","gists_url":"https://api.github.com/users/archeg/gists{/gist_id}","starred_url":"https://api.github.com/users/archeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archeg/subscriptions","organizations_url":"https://api.github.com/users/archeg/orgs","repos_url":"https://api.github.com/users/archeg/repos","events_url":"https://api.github.com/users/archeg/events{/privacy}","received_events_url":"https://api.github.com/users/archeg/received_events","type":"User","site_admin":false},"body":"Please check carefully this one as this is my first pull request ever in github. Please let me know of any improvements/problems - I'll be glad to fix it.\r\nThe issue: https://github.com/oxyplot/oxyplot/issues/185 \r\n\r\nI haven't found a suitable method for rotating the bounding box, so I wrote it myself.\r\nMeasureText now accepts `double angle = 0`, that controls the angle of text measured. \r\n\r\nI have also added an example of other issue mentioned in the ticket. It is quite near the original issue, but the code responsible for it in in the other place, I yet haven't looked at that. \r\n\r\nTests are green, everything except Xamarin compiles - I wasn't able to compile Xamarin because of license, asked a question in gitter. ~~But it should work as the change in xamarin is very simple.~~ I will use buildserver to check that for now","created_at":"2014-12-24T15:10:07Z","updated_at":"2014-12-26T11:25:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65962fa3ba79cf1cfa479edf7b8e22fbc3188fba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/oxyplot/oxyplot/pulls/297/commits","review_comments_url":"https://api.github.com/repos/oxyplot/oxyplot/pulls/297/comments","review_comment_url":"https://api.github.com/repos/oxyplot/oxyplot/pulls/comments/{number}","comments_url":"https://api.github.com/repos/oxyplot/oxyplot/issues/297/comments","statuses_url":"https://api.github.com/repos/oxyplot/oxyplot/statuses/d167bfd4dee88f923a46149c2ac271c273f2c5f4","head":{"label":"archeg:xaxis-label-cuts-off-bugfix","ref":"xaxis-label-cuts-off-bugfix","sha":"d167bfd4dee88f923a46149c2ac271c273f2c5f4","user":{"login":"archeg","id":700094,"avatar_url":"https://avatars.githubusercontent.com/u/700094?v=3","gravatar_id":"","url":"https://api.github.com/users/archeg","html_url":"https://github.com/archeg","followers_url":"https://api.github.com/users/archeg/followers","following_url":"https://api.github.com/users/archeg/following{/other_user}","gists_url":"https://api.github.com/users/archeg/gists{/gist_id}","starred_url":"https://api.github.com/users/archeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archeg/subscriptions","organizations_url":"https://api.github.com/users/archeg/orgs","repos_url":"https://api.github.com/users/archeg/repos","events_url":"https://api.github.com/users/archeg/events{/privacy}","received_events_url":"https://api.github.com/users/archeg/received_events","type":"User","site_admin":false},"repo":{"id":28451736,"name":"oxyplot","full_name":"archeg/oxyplot","owner":{"login":"archeg","id":700094,"avatar_url":"https://avatars.githubusercontent.com/u/700094?v=3","gravatar_id":"","url":"https://api.github.com/users/archeg","html_url":"https://github.com/archeg","followers_url":"https://api.github.com/users/archeg/followers","following_url":"https://api.github.com/users/archeg/following{/other_user}","gists_url":"https://api.github.com/users/archeg/gists{/gist_id}","starred_url":"https://api.github.com/users/archeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archeg/subscriptions","organizations_url":"https://api.github.com/users/archeg/orgs","repos_url":"https://api.github.com/users/archeg/repos","events_url":"https://api.github.com/users/archeg/events{/privacy}","received_events_url":"https://api.github.com/users/archeg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/archeg/oxyplot","description":"source code and examples","fork":true,"url":"https://api.github.com/repos/archeg/oxyplot","forks_url":"https://api.github.com/repos/archeg/oxyplot/forks","keys_url":"https://api.github.com/repos/archeg/oxyplot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/archeg/oxyplot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/archeg/oxyplot/teams","hooks_url":"https://api.github.com/repos/archeg/oxyplot/hooks","issue_events_url":"https://api.github.com/repos/archeg/oxyplot/issues/events{/number}","events_url":"https://api.github.com/repos/archeg/oxyplot/events","assignees_url":"https://api.github.com/repos/archeg/oxyplot/assignees{/user}","branches_url":"https://api.github.com/repos/archeg/oxyplot/branches{/branch}","tags_url":"https://api.github.com/repos/archeg/oxyplot/tags","blobs_url":"https://api.github.com/repos/archeg/oxyplot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/archeg/oxyplot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/archeg/oxyplot/git/refs{/sha}","trees_url":"https://api.github.com/repos/archeg/oxyplot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/archeg/oxyplot/statuses/{sha}","languages_url":"https://api.github.com/repos/archeg/oxyplot/languages","stargazers_url":"https://api.github.com/repos/archeg/oxyplot/stargazers","contributors_url":"https://api.github.com/repos/archeg/oxyplot/contributors","subscribers_url":"https://api.github.com/repos/archeg/oxyplot/subscribers","subscription_url":"https://api.github.com/repos/archeg/oxyplot/subscription","commits_url":"https://api.github.com/repos/archeg/oxyplot/commits{/sha}","git_commits_url":"https://api.github.com/repos/archeg/oxyplot/git/commits{/sha}","comments_url":"https://api.github.com/repos/archeg/oxyplot/comments{/number}","issue_comment_url":"https://api.github.com/repos/archeg/oxyplot/issues/comments/{number}","contents_url":"https://api.github.com/repos/archeg/oxyplot/contents/{+path}","compare_url":"https://api.github.com/repos/archeg/oxyplot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/archeg/oxyplot/merges","archive_url":"https://api.github.com/repos/archeg/oxyplot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/archeg/oxyplot/downloads","issues_url":"https://api.github.com/repos/archeg/oxyplot/issues{/number}","pulls_url":"https://api.github.com/repos/archeg/oxyplot/pulls{/number}","milestones_url":"https://api.github.com/repos/archeg/oxyplot/milestones{/number}","notifications_url":"https://api.github.com/repos/archeg/oxyplot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/archeg/oxyplot/labels{/name}","releases_url":"https://api.github.com/repos/archeg/oxyplot/releases{/id}","created_at":"2014-12-24T14:46:57Z","updated_at":"2014-12-24T14:47:04Z","pushed_at":"2014-12-24T15:51:18Z","git_url":"git://github.com/archeg/oxyplot.git","ssh_url":"git@github.com:archeg/oxyplot.git","clone_url":"https://github.com/archeg/oxyplot.git","svn_url":"https://github.com/archeg/oxyplot","homepage":"","size":33981,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oxyplot:develop","ref":"develop","sha":"455a4e81bc67320e3ffcab7ac4d58eed9a01ed32","user":{"login":"oxyplot","id":8432466,"avatar_url":"https://avatars.githubusercontent.com/u/8432466?v=3","gravatar_id":"","url":"https://api.github.com/users/oxyplot","html_url":"https://github.com/oxyplot","followers_url":"https://api.github.com/users/oxyplot/followers","following_url":"https://api.github.com/users/oxyplot/following{/other_user}","gists_url":"https://api.github.com/users/oxyplot/gists{/gist_id}","starred_url":"https://api.github.com/users/oxyplot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxyplot/subscriptions","organizations_url":"https://api.github.com/users/oxyplot/orgs","repos_url":"https://api.github.com/users/oxyplot/repos","events_url":"https://api.github.com/users/oxyplot/events{/privacy}","received_events_url":"https://api.github.com/users/oxyplot/received_events","type":"Organization","site_admin":false},"repo":{"id":22894999,"name":"oxyplot","full_name":"oxyplot/oxyplot","owner":{"login":"oxyplot","id":8432466,"avatar_url":"https://avatars.githubusercontent.com/u/8432466?v=3","gravatar_id":"","url":"https://api.github.com/users/oxyplot","html_url":"https://github.com/oxyplot","followers_url":"https://api.github.com/users/oxyplot/followers","following_url":"https://api.github.com/users/oxyplot/following{/other_user}","gists_url":"https://api.github.com/users/oxyplot/gists{/gist_id}","starred_url":"https://api.github.com/users/oxyplot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxyplot/subscriptions","organizations_url":"https://api.github.com/users/oxyplot/orgs","repos_url":"https://api.github.com/users/oxyplot/repos","events_url":"https://api.github.com/users/oxyplot/events{/privacy}","received_events_url":"https://api.github.com/users/oxyplot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oxyplot/oxyplot","description":"source code and examples","fork":false,"url":"https://api.github.com/repos/oxyplot/oxyplot","forks_url":"https://api.github.com/repos/oxyplot/oxyplot/forks","keys_url":"https://api.github.com/repos/oxyplot/oxyplot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oxyplot/oxyplot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oxyplot/oxyplot/teams","hooks_url":"https://api.github.com/repos/oxyplot/oxyplot/hooks","issue_events_url":"https://api.github.com/repos/oxyplot/oxyplot/issues/events{/number}","events_url":"https://api.github.com/repos/oxyplot/oxyplot/events","assignees_url":"https://api.github.com/repos/oxyplot/oxyplot/assignees{/user}","branches_url":"https://api.github.com/repos/oxyplot/oxyplot/branches{/branch}","tags_url":"https://api.github.com/repos/oxyplot/oxyplot/tags","blobs_url":"https://api.github.com/repos/oxyplot/oxyplot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oxyplot/oxyplot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oxyplot/oxyplot/git/refs{/sha}","trees_url":"https://api.github.com/repos/oxyplot/oxyplot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oxyplot/oxyplot/statuses/{sha}","languages_url":"https://api.github.com/repos/oxyplot/oxyplot/languages","stargazers_url":"https://api.github.com/repos/oxyplot/oxyplot/stargazers","contributors_url":"https://api.github.com/repos/oxyplot/oxyplot/contributors","subscribers_url":"https://api.github.com/repos/oxyplot/oxyplot/subscribers","subscription_url":"https://api.github.com/repos/oxyplot/oxyplot/subscription","commits_url":"https://api.github.com/repos/oxyplot/oxyplot/commits{/sha}","git_commits_url":"https://api.github.com/repos/oxyplot/oxyplot/git/commits{/sha}","comments_url":"https://api.github.com/repos/oxyplot/oxyplot/comments{/number}","issue_comment_url":"https://api.github.com/repos/oxyplot/oxyplot/issues/comments/{number}","contents_url":"https://api.github.com/repos/oxyplot/oxyplot/contents/{+path}","compare_url":"https://api.github.com/repos/oxyplot/oxyplot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oxyplot/oxyplot/merges","archive_url":"https://api.github.com/repos/oxyplot/oxyplot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oxyplot/oxyplot/downloads","issues_url":"https://api.github.com/repos/oxyplot/oxyplot/issues{/number}","pulls_url":"https://api.github.com/repos/oxyplot/oxyplot/pulls{/number}","milestones_url":"https://api.github.com/repos/oxyplot/oxyplot/milestones{/number}","notifications_url":"https://api.github.com/repos/oxyplot/oxyplot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oxyplot/oxyplot/labels{/name}","releases_url":"https://api.github.com/repos/oxyplot/oxyplot/releases{/id}","created_at":"2014-08-12T22:47:55Z","updated_at":"2014-12-23T11:10:14Z","pushed_at":"2014-12-22T08:13:58Z","git_url":"git://github.com/oxyplot/oxyplot.git","ssh_url":"git@github.com:oxyplot/oxyplot.git","clone_url":"https://github.com/oxyplot/oxyplot.git","svn_url":"https://github.com/oxyplot/oxyplot","homepage":"","size":33981,"stargazers_count":123,"watchers_count":123,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":192,"forks":72,"open_issues":192,"watchers":123,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oxyplot/oxyplot/pulls/297"},"html":{"href":"https://github.com/oxyplot/oxyplot/pull/297"},"issue":{"href":"https://api.github.com/repos/oxyplot/oxyplot/issues/297"},"comments":{"href":"https://api.github.com/repos/oxyplot/oxyplot/issues/297/comments"},"review_comments":{"href":"https://api.github.com/repos/oxyplot/oxyplot/pulls/297/comments"},"review_comment":{"href":"https://api.github.com/repos/oxyplot/oxyplot/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/oxyplot/oxyplot/pulls/297/commits"},"statuses":{"href":"https://api.github.com/repos/oxyplot/oxyplot/statuses/d167bfd4dee88f923a46149c2ac271c273f2c5f4"}}}}