GitHub PullRequestReviewCommentEvent at 2014-12-03 14:59:12
Repository: angular
Actor: gkalpak
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/21235955","id":21235955,"diff_hunk":"@@ -41,7 +42,35 @@ var js2dartOptions = {\n   outputLanguage: 'dart'\n };\n \n-var PUB_CMD = process.platform === 'win32' ? 'pub.bat' : 'pub';\n+var DART_SDK = false;\n+\n+try {\n+  which.sync('dart');\n+  console.log('Dart SDK detected');\n+  if (process.platform === 'win32') {\n+    DART_SDK = {\n+      PUB: 'pub.bat',\n+      ANALYZER: 'dartanalyzer.bat'\n+    };\n+  } else {\n+    DART_SDK = {\n+      PUB: 'pub',\n+      ANALYZER: 'dartanalyzer'\n+    };\n+  }\n+} catch (e) {\n+  console.log('Dart SDK is not available, Dart tasks will be skipped.');\n+  var gulpTaskFn = gulp.task.bind(gulp);\n+  gulp.task = function (name, deps, fn) {\n+    if (name.indexOf('.dart') == -1) {","path":"gulpfile.js","position":33,"original_position":33,"commit_id":"51d07e8356d164966a2c58b694e2683609f3e5ad","original_commit_id":"51d07e8356d164966a2c58b694e2683609f3e5ad","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"I know, but `===` makes the intent more clear.\r\nWhenever I see a `==` I start wondering if it is used on purpose or just as an \"equally well working\" alternative to `===`. So, from a maintainance point of view, `===` is more straightforward (imo).","created_at":"2014-12-03T14:59:12Z","updated_at":"2014-12-03T14:59:12Z","html_url":"https://github.com/angular/angular/pull/275#discussion_r21235955","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/275","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/21235955"},"html":{"href":"https://github.com/angular/angular/pull/275#discussion_r21235955"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/275"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/275","id":25422125,"html_url":"https://github.com/angular/angular/pull/275","diff_url":"https://github.com/angular/angular/pull/275.diff","patch_url":"https://github.com/angular/angular/pull/275.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/275","number":275,"state":"open","locked":false,"title":"chore(gulp): Skip Dart tasks when the SDK is not detected","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"fixes #268","created_at":"2014-12-03T14:28:41Z","updated_at":"2014-12-03T14:59:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a203ce1ebb807c37b2610b60276d6ebde775e6e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/275/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/275/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular/angular/issues/275/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/51d07e8356d164966a2c58b694e2683609f3e5ad","head":{"label":"vicb:1203-bdart","ref":"1203-bdart","sha":"51d07e8356d164966a2c58b694e2683609f3e5ad","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"repo":{"id":24640725,"name":"angular","full_name":"vicb/angular","owner":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vicb/angular","description":"","fork":true,"url":"https://api.github.com/repos/vicb/angular","forks_url":"https://api.github.com/repos/vicb/angular/forks","keys_url":"https://api.github.com/repos/vicb/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vicb/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vicb/angular/teams","hooks_url":"https://api.github.com/repos/vicb/angular/hooks","issue_events_url":"https://api.github.com/repos/vicb/angular/issues/events{/number}","events_url":"https://api.github.com/repos/vicb/angular/events","assignees_url":"https://api.github.com/repos/vicb/angular/assignees{/user}","branches_url":"https://api.github.com/repos/vicb/angular/branches{/branch}","tags_url":"https://api.github.com/repos/vicb/angular/tags","blobs_url":"https://api.github.com/repos/vicb/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vicb/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vicb/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/vicb/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vicb/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/vicb/angular/languages","stargazers_url":"https://api.github.com/repos/vicb/angular/stargazers","contributors_url":"https://api.github.com/repos/vicb/angular/contributors","subscribers_url":"https://api.github.com/repos/vicb/angular/subscribers","subscription_url":"https://api.github.com/repos/vicb/angular/subscription","commits_url":"https://api.github.com/repos/vicb/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/vicb/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/vicb/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/vicb/angular/issues/comments/{number}","contents_url":"https://api.github.com/repos/vicb/angular/contents/{+path}","compare_url":"https://api.github.com/repos/vicb/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vicb/angular/merges","archive_url":"https://api.github.com/repos/vicb/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vicb/angular/downloads","issues_url":"https://api.github.com/repos/vicb/angular/issues{/number}","pulls_url":"https://api.github.com/repos/vicb/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/vicb/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/vicb/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vicb/angular/labels{/name}","releases_url":"https://api.github.com/repos/vicb/angular/releases{/id}","created_at":"2014-09-30T14:12:47Z","updated_at":"2014-10-30T09:14:45Z","pushed_at":"2014-12-03T14:28:09Z","git_url":"git://github.com/vicb/angular.git","ssh_url":"git@github.com:vicb/angular.git","clone_url":"https://github.com/vicb/angular.git","svn_url":"https://github.com/vicb/angular","homepage":null,"size":1283,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"f088e9ef15b05da279cb0dae725f84daa0da4476","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2014-12-03T11:19:34Z","pushed_at":"2014-12-03T09:53:56Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":null,"size":3898,"stargazers_count":402,"watchers_count":402,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":69,"forks":106,"open_issues":69,"watchers":402,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/275"},"html":{"href":"https://github.com/angular/angular/pull/275"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/275"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/51d07e8356d164966a2c58b694e2683609f3e5ad"}}}}