GitHub PullRequestEvent at 2014-06-10 15:19:08
Repository: node-xmpp-server
Actor: chris-rock
Payload: {"action":"closed","number":51,"pull_request":{"url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/pulls/51","id":16926623,"html_url":"https://github.com/node-xmpp/node-xmpp-server/pull/51","diff_url":"https://github.com/node-xmpp/node-xmpp-server/pull/51.diff","patch_url":"https://github.com/node-xmpp/node-xmpp-server/pull/51.patch","issue_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/issues/51","number":51,"state":"closed","title":"Close stream with error if 'to' not specified","user":{"login":"krnekit","id":1368764,"avatar_url":"https://avatars.githubusercontent.com/u/1368764?","gravatar_id":"42bb0999dd3bb72959dd91531c5c930c","url":"https://api.github.com/users/krnekit","html_url":"https://github.com/krnekit","followers_url":"https://api.github.com/users/krnekit/followers","following_url":"https://api.github.com/users/krnekit/following{/other_user}","gists_url":"https://api.github.com/users/krnekit/gists{/gist_id}","starred_url":"https://api.github.com/users/krnekit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnekit/subscriptions","organizations_url":"https://api.github.com/users/krnekit/orgs","repos_url":"https://api.github.com/users/krnekit/repos","events_url":"https://api.github.com/users/krnekit/events{/privacy}","received_events_url":"https://api.github.com/users/krnekit/received_events","type":"User","site_admin":false},"body":"If stream has empty or absent 'to', the server crashes. This is due to proceeding to authenticate and trying to create JID object with empty domain, which throws 'Argument error'.\r\nThis stream attribute is mandatory, so we can close it with corresponding error. See more: http://xmpp.org/rfcs/rfc6120.html#streams-attr-to","created_at":"2014-06-10T08:02:20Z","updated_at":"2014-06-10T15:19:08Z","closed_at":"2014-06-10T15:19:08Z","merged_at":"2014-06-10T15:19:08Z","merge_commit_sha":"f43fe7c0886ebe08c8564df42cd88cc9c09b0cc3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/pulls/51/commits","review_comments_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/pulls/51/comments","review_comment_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/pulls/comments/{number}","comments_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/issues/51/comments","statuses_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/statuses/798eb915a20c111c01fd608735baec16321a1001","head":{"label":"krnekit:stream-empty-to","ref":"stream-empty-to","sha":"798eb915a20c111c01fd608735baec16321a1001","user":{"login":"krnekit","id":1368764,"avatar_url":"https://avatars.githubusercontent.com/u/1368764?","gravatar_id":"42bb0999dd3bb72959dd91531c5c930c","url":"https://api.github.com/users/krnekit","html_url":"https://github.com/krnekit","followers_url":"https://api.github.com/users/krnekit/followers","following_url":"https://api.github.com/users/krnekit/following{/other_user}","gists_url":"https://api.github.com/users/krnekit/gists{/gist_id}","starred_url":"https://api.github.com/users/krnekit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnekit/subscriptions","organizations_url":"https://api.github.com/users/krnekit/orgs","repos_url":"https://api.github.com/users/krnekit/repos","events_url":"https://api.github.com/users/krnekit/events{/privacy}","received_events_url":"https://api.github.com/users/krnekit/received_events","type":"User","site_admin":false},"repo":{"id":20556954,"name":"node-xmpp-server","full_name":"krnekit/node-xmpp-server","owner":{"login":"krnekit","id":1368764,"avatar_url":"https://avatars.githubusercontent.com/u/1368764?","gravatar_id":"42bb0999dd3bb72959dd91531c5c930c","url":"https://api.github.com/users/krnekit","html_url":"https://github.com/krnekit","followers_url":"https://api.github.com/users/krnekit/followers","following_url":"https://api.github.com/users/krnekit/following{/other_user}","gists_url":"https://api.github.com/users/krnekit/gists{/gist_id}","starred_url":"https://api.github.com/users/krnekit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnekit/subscriptions","organizations_url":"https://api.github.com/users/krnekit/orgs","repos_url":"https://api.github.com/users/krnekit/repos","events_url":"https://api.github.com/users/krnekit/events{/privacy}","received_events_url":"https://api.github.com/users/krnekit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krnekit/node-xmpp-server","description":"XMPP Server using node-xmpp","fork":true,"url":"https://api.github.com/repos/krnekit/node-xmpp-server","forks_url":"https://api.github.com/repos/krnekit/node-xmpp-server/forks","keys_url":"https://api.github.com/repos/krnekit/node-xmpp-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krnekit/node-xmpp-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krnekit/node-xmpp-server/teams","hooks_url":"https://api.github.com/repos/krnekit/node-xmpp-server/hooks","issue_events_url":"https://api.github.com/repos/krnekit/node-xmpp-server/issues/events{/number}","events_url":"https://api.github.com/repos/krnekit/node-xmpp-server/events","assignees_url":"https://api.github.com/repos/krnekit/node-xmpp-server/assignees{/user}","branches_url":"https://api.github.com/repos/krnekit/node-xmpp-server/branches{/branch}","tags_url":"https://api.github.com/repos/krnekit/node-xmpp-server/tags","blobs_url":"https://api.github.com/repos/krnekit/node-xmpp-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krnekit/node-xmpp-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krnekit/node-xmpp-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/krnekit/node-xmpp-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krnekit/node-xmpp-server/statuses/{sha}","languages_url":"https://api.github.com/repos/krnekit/node-xmpp-server/languages","stargazers_url":"https://api.github.com/repos/krnekit/node-xmpp-server/stargazers","contributors_url":"https://api.github.com/repos/krnekit/node-xmpp-server/contributors","subscribers_url":"https://api.github.com/repos/krnekit/node-xmpp-server/subscribers","subscription_url":"https://api.github.com/repos/krnekit/node-xmpp-server/subscription","commits_url":"https://api.github.com/repos/krnekit/node-xmpp-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/krnekit/node-xmpp-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/krnekit/node-xmpp-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/krnekit/node-xmpp-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/krnekit/node-xmpp-server/contents/{+path}","compare_url":"https://api.github.com/repos/krnekit/node-xmpp-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krnekit/node-xmpp-server/merges","archive_url":"https://api.github.com/repos/krnekit/node-xmpp-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krnekit/node-xmpp-server/downloads","issues_url":"https://api.github.com/repos/krnekit/node-xmpp-server/issues{/number}","pulls_url":"https://api.github.com/repos/krnekit/node-xmpp-server/pulls{/number}","milestones_url":"https://api.github.com/repos/krnekit/node-xmpp-server/milestones{/number}","notifications_url":"https://api.github.com/repos/krnekit/node-xmpp-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krnekit/node-xmpp-server/labels{/name}","releases_url":"https://api.github.com/repos/krnekit/node-xmpp-server/releases{/id}","created_at":"2014-06-06T08:42:21Z","updated_at":"2014-06-10T15:19:08Z","pushed_at":"2014-06-10T15:05:17Z","git_url":"git://github.com/krnekit/node-xmpp-server.git","ssh_url":"git@github.com:krnekit/node-xmpp-server.git","clone_url":"https://github.com/krnekit/node-xmpp-server.git","svn_url":"https://github.com/krnekit/node-xmpp-server","homepage":null,"size":246,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"node-xmpp:master","ref":"master","sha":"2728c4b6ae29111d455e3edf941706b01d093d78","user":{"login":"node-xmpp","id":5985248,"avatar_url":"https://avatars.githubusercontent.com/u/5985248?","gravatar_id":"46b74153b7c49249d92d906b0fdc9a55","url":"https://api.github.com/users/node-xmpp","html_url":"https://github.com/node-xmpp","followers_url":"https://api.github.com/users/node-xmpp/followers","following_url":"https://api.github.com/users/node-xmpp/following{/other_user}","gists_url":"https://api.github.com/users/node-xmpp/gists{/gist_id}","starred_url":"https://api.github.com/users/node-xmpp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-xmpp/subscriptions","organizations_url":"https://api.github.com/users/node-xmpp/orgs","repos_url":"https://api.github.com/users/node-xmpp/repos","events_url":"https://api.github.com/users/node-xmpp/events{/privacy}","received_events_url":"https://api.github.com/users/node-xmpp/received_events","type":"Organization","site_admin":false},"repo":{"id":14604436,"name":"node-xmpp-server","full_name":"node-xmpp/node-xmpp-server","owner":{"login":"node-xmpp","id":5985248,"avatar_url":"https://avatars.githubusercontent.com/u/5985248?","gravatar_id":"46b74153b7c49249d92d906b0fdc9a55","url":"https://api.github.com/users/node-xmpp","html_url":"https://github.com/node-xmpp","followers_url":"https://api.github.com/users/node-xmpp/followers","following_url":"https://api.github.com/users/node-xmpp/following{/other_user}","gists_url":"https://api.github.com/users/node-xmpp/gists{/gist_id}","starred_url":"https://api.github.com/users/node-xmpp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-xmpp/subscriptions","organizations_url":"https://api.github.com/users/node-xmpp/orgs","repos_url":"https://api.github.com/users/node-xmpp/repos","events_url":"https://api.github.com/users/node-xmpp/events{/privacy}","received_events_url":"https://api.github.com/users/node-xmpp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/node-xmpp/node-xmpp-server","description":"XMPP Server using node-xmpp","fork":false,"url":"https://api.github.com/repos/node-xmpp/node-xmpp-server","forks_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/forks","keys_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/teams","hooks_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/hooks","issue_events_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/issues/events{/number}","events_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/events","assignees_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/assignees{/user}","branches_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/branches{/branch}","tags_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/tags","blobs_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/statuses/{sha}","languages_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/languages","stargazers_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/stargazers","contributors_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/contributors","subscribers_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/subscribers","subscription_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/subscription","commits_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/contents/{+path}","compare_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/merges","archive_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/downloads","issues_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/issues{/number}","pulls_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/pulls{/number}","milestones_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/milestones{/number}","notifications_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/labels{/name}","releases_url":"https://api.github.com/repos/node-xmpp/node-xmpp-server/releases{/id}","created_at":"2013-11-22T00:26:04Z","updated_at":"2014-06-10T15:19:08Z","pushed_at":"2014-06-10T15:19:08Z","git_url":"git://github.com/node-xmpp/node-xmpp-server.git","ssh_url":"git@github.com:node-xmpp/node-xmpp-server.git","clone_url":"https://github.com/node-xmpp/node-xmpp-server.git","svn_url":"https://github.com/node-xmpp/node-xmpp-server","homepage":null,"size":1206,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/node-xmpp/node-xmpp-server/pulls/51"},"html":{"href":"https://github.com/node-xmpp/node-xmpp-server/pull/51"},"issue":{"href":"https://api.github.com/repos/node-xmpp/node-xmpp-server/issues/51"},"comments":{"href":"https://api.github.com/repos/node-xmpp/node-xmpp-server/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/node-xmpp/node-xmpp-server/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/node-xmpp/node-xmpp-server/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/node-xmpp/node-xmpp-server/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/node-xmpp/node-xmpp-server/statuses/798eb915a20c111c01fd608735baec16321a1001"}},"merged":true,"mergeable":true,"mergeable_state":"unstable","merged_by":{"login":"chris-rock","id":1178413,"avatar_url":"https://avatars.githubusercontent.com/u/1178413?","gravatar_id":"f59cf51b88cf75171f7687652b19c5b0","url":"https://api.github.com/users/chris-rock","html_url":"https://github.com/chris-rock","followers_url":"https://api.github.com/users/chris-rock/followers","following_url":"https://api.github.com/users/chris-rock/following{/other_user}","gists_url":"https://api.github.com/users/chris-rock/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-rock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-rock/subscriptions","organizations_url":"https://api.github.com/users/chris-rock/orgs","repos_url":"https://api.github.com/users/chris-rock/repos","events_url":"https://api.github.com/users/chris-rock/events{/privacy}","received_events_url":"https://api.github.com/users/chris-rock/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":2,"additions":76,"deletions":6,"changed_files":2}}