GitHub PullRequestEvent at 2014-08-08 01:04:46
Repository: angular.js
Actor: caitp
Payload: {"action":"closed","number":8519,"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/8519","id":19446074,"html_url":"https://github.com/angular/angular.js/pull/8519","diff_url":"https://github.com/angular/angular.js/pull/8519.diff","patch_url":"https://github.com/angular/angular.js/pull/8519.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/8519","number":8519,"state":"closed","title":"docs: ngSanitize is out ng core at AngularJS 1.2.21","user":{"login":"juampy72","id":108130,"avatar_url":"https://avatars.githubusercontent.com/u/108130?v=2","gravatar_id":"02bdc5e43feee5754c491d60b3b1e538","url":"https://api.github.com/users/juampy72","html_url":"https://github.com/juampy72","followers_url":"https://api.github.com/users/juampy72/followers","following_url":"https://api.github.com/users/juampy72/following{/other_user}","gists_url":"https://api.github.com/users/juampy72/gists{/gist_id}","starred_url":"https://api.github.com/users/juampy72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juampy72/subscriptions","organizations_url":"https://api.github.com/users/juampy72/orgs","repos_url":"https://api.github.com/users/juampy72/repos","events_url":"https://api.github.com/users/juampy72/events{/privacy}","received_events_url":"https://api.github.com/users/juampy72/received_events","type":"User","site_admin":false},"body":"When using ngBindHTML directive, ngSanitize module must be added as a dependency.\r\n\r\nNot doing so results in the following error:\r\n\r\n```\r\nError: [$sce:unsafe] http://errors.angularjs.org/1.2.21/$sce/unsafe\r\n    at Error (native)\r\n    at http://somesite/js/angular.min.js?n9wkqz:6:450\r\n    at e (http://somesite/js/angular.min.js?n9wkqz:117:34)\r\n    at getTrusted (http://somesite/js/angular.min.js?n9wkqz:118:327)\r\n    at Object.e.(anonymous function) [as getTrustedHtml] (http://somesite/js/angular.min.js?n9wkqz:120:71)\r\n    at Object.fn (http://somesite/js/angular.min.js?n9wkqz:192:234)\r\n    at k.$digest (http://somesite/js/angular.min.js?n9wkqz:109:213)\r\n    at k.$apply (http://somesite/js/angular.min.js?n9wkqz:112:173)\r\n    at h (http://somesite/js/angular.min.js?n9wkqz:72:300)\r\n    at w (http://somesite/js/angular.min.js?n9wkqz:77:288) \r\n```\r\n\r\nYou can see that the API reference for ngBindHTML includes the module below:\r\n\r\n![selection_004](https://cloud.githubusercontent.com/assets/108130/3837185/9cdf6e08-1de6-11e4-93fa-a4a99b919e8c.png)\r\n","created_at":"2014-08-07T03:55:12Z","updated_at":"2014-08-08T01:04:43Z","closed_at":"2014-08-08T01:04:43Z","merged_at":null,"merge_commit_sha":"fa8cfc5ae37f340ce27f9f481ba6249a7645a5ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/8519/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/8519/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/8519/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/3730e439e22cd8997a43b8f331081ad47a478aa7","head":{"label":"juampy72:patch-2","ref":"patch-2","sha":"3730e439e22cd8997a43b8f331081ad47a478aa7","user":{"login":"juampy72","id":108130,"avatar_url":"https://avatars.githubusercontent.com/u/108130?v=2","gravatar_id":"02bdc5e43feee5754c491d60b3b1e538","url":"https://api.github.com/users/juampy72","html_url":"https://github.com/juampy72","followers_url":"https://api.github.com/users/juampy72/followers","following_url":"https://api.github.com/users/juampy72/following{/other_user}","gists_url":"https://api.github.com/users/juampy72/gists{/gist_id}","starred_url":"https://api.github.com/users/juampy72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juampy72/subscriptions","organizations_url":"https://api.github.com/users/juampy72/orgs","repos_url":"https://api.github.com/users/juampy72/repos","events_url":"https://api.github.com/users/juampy72/events{/privacy}","received_events_url":"https://api.github.com/users/juampy72/received_events","type":"User","site_admin":false},"repo":{"id":22698882,"name":"angular.js","full_name":"juampy72/angular.js","owner":{"login":"juampy72","id":108130,"avatar_url":"https://avatars.githubusercontent.com/u/108130?v=2","gravatar_id":"02bdc5e43feee5754c491d60b3b1e538","url":"https://api.github.com/users/juampy72","html_url":"https://github.com/juampy72","followers_url":"https://api.github.com/users/juampy72/followers","following_url":"https://api.github.com/users/juampy72/following{/other_user}","gists_url":"https://api.github.com/users/juampy72/gists{/gist_id}","starred_url":"https://api.github.com/users/juampy72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juampy72/subscriptions","organizations_url":"https://api.github.com/users/juampy72/orgs","repos_url":"https://api.github.com/users/juampy72/repos","events_url":"https://api.github.com/users/juampy72/events{/privacy}","received_events_url":"https://api.github.com/users/juampy72/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juampy72/angular.js","description":"HTML enhanced for web apps","fork":true,"url":"https://api.github.com/repos/juampy72/angular.js","forks_url":"https://api.github.com/repos/juampy72/angular.js/forks","keys_url":"https://api.github.com/repos/juampy72/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juampy72/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juampy72/angular.js/teams","hooks_url":"https://api.github.com/repos/juampy72/angular.js/hooks","issue_events_url":"https://api.github.com/repos/juampy72/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/juampy72/angular.js/events","assignees_url":"https://api.github.com/repos/juampy72/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/juampy72/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/juampy72/angular.js/tags","blobs_url":"https://api.github.com/repos/juampy72/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juampy72/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juampy72/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/juampy72/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juampy72/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/juampy72/angular.js/languages","stargazers_url":"https://api.github.com/repos/juampy72/angular.js/stargazers","contributors_url":"https://api.github.com/repos/juampy72/angular.js/contributors","subscribers_url":"https://api.github.com/repos/juampy72/angular.js/subscribers","subscription_url":"https://api.github.com/repos/juampy72/angular.js/subscription","commits_url":"https://api.github.com/repos/juampy72/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/juampy72/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/juampy72/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/juampy72/angular.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/juampy72/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/juampy72/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juampy72/angular.js/merges","archive_url":"https://api.github.com/repos/juampy72/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juampy72/angular.js/downloads","issues_url":"https://api.github.com/repos/juampy72/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/juampy72/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/juampy72/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/juampy72/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juampy72/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/juampy72/angular.js/releases{/id}","created_at":"2014-08-06T21:32:47Z","updated_at":"2014-08-07T03:52:12Z","pushed_at":"2014-08-08T00:42:24Z","git_url":"git://github.com/juampy72/angular.js.git","ssh_url":"git@github.com:juampy72/angular.js.git","clone_url":"https://github.com/juampy72/angular.js.git","svn_url":"https://github.com/juampy72/angular.js","homepage":"http://angularjs.org","size":53956,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"7df7d1a9bc9362fea657fbeb95bc9ff53740062d","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=2","gravatar_id":"f0d91e5cf8ad1ce7972cc486baa20c42","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=2","gravatar_id":"f0d91e5cf8ad1ce7972cc486baa20c42","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","created_at":"2010-01-06T00:34:37Z","updated_at":"2014-08-08T00:29:01Z","pushed_at":"2014-08-08T01:04:21Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":206273,"stargazers_count":26974,"watchers_count":26974,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9763,"mirror_url":null,"open_issues_count":1109,"forks":9763,"open_issues":1109,"watchers":26974,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/8519"},"html":{"href":"https://github.com/angular/angular.js/pull/8519"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/8519"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/8519/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/8519/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/8519/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/3730e439e22cd8997a43b8f331081ad47a478aa7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":7,"review_comments":2,"commits":1,"additions":4,"deletions":2,"changed_files":1}}