GitHub PullRequestReviewCommentEvent at 2014-08-28 13:51:57
Repository: COSDev
Actor: brianjgeiger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls/comments/16839830","id":16839830,"diff_hunk":"@@ -16,6 +16,7 @@ Before sending a pull request for code review, make sure you have met the :ref:`\n \n - It may be difficult not to perceive code review as personal criticism, but, keep in mind, it is a review of the code, not the person. We can all learn from eachother, and code reviews provide a good environment to do so.\n - After addressing all comments from a review, ping your reviewer by ``@mentioning`` them in a comment.\n+- If you would like to propose a change to a style guideline, post an issue or send a PR to the `COSDev <https://github.com/CenterForOpenScience/COSDev>`_ repo rather than discussing it in the PR.","path":"docs/process/code_review.rst","position":4,"original_position":4,"commit_id":"0cd99af0dcd8386a672af275d28c3339a52ccb66","original_commit_id":"0cd99af0dcd8386a672af275d28c3339a52ccb66","user":{"login":"brianjgeiger","id":6599111,"avatar_url":"https://avatars.githubusercontent.com/u/6599111?v=2","gravatar_id":"3dd8757ba100b8406413706886243811","url":"https://api.github.com/users/brianjgeiger","html_url":"https://github.com/brianjgeiger","followers_url":"https://api.github.com/users/brianjgeiger/followers","following_url":"https://api.github.com/users/brianjgeiger/following{/other_user}","gists_url":"https://api.github.com/users/brianjgeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/brianjgeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianjgeiger/subscriptions","organizations_url":"https://api.github.com/users/brianjgeiger/orgs","repos_url":"https://api.github.com/users/brianjgeiger/repos","events_url":"https://api.github.com/users/brianjgeiger/events{/privacy}","received_events_url":"https://api.github.com/users/brianjgeiger/received_events","type":"User","site_admin":false},"body":"Okay, I understand. To make it a bit more clear, how about starting with, \"If there is a style guideline that affects your PR and you believe the guideline is incorrect, post an issue etc etc\".","created_at":"2014-08-28T13:51:57Z","updated_at":"2014-08-28T13:51:57Z","html_url":"https://github.com/CenterForOpenScience/COSDev/pull/4#discussion_r16839830","pull_request_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls/comments/16839830"},"html":{"href":"https://github.com/CenterForOpenScience/COSDev/pull/4#discussion_r16839830"},"pull_request":{"href":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls/4","id":20330199,"html_url":"https://github.com/CenterForOpenScience/COSDev/pull/4","diff_url":"https://github.com/CenterForOpenScience/COSDev/pull/4.diff","patch_url":"https://github.com/CenterForOpenScience/COSDev/pull/4.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/issues/4","number":4,"state":"open","locked":false,"title":"Add guidelines for PR descriptions and style comments","user":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=2","gravatar_id":"c74f9cfd7776305a82ede0b765d65402","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-26T19:10:12Z","updated_at":"2014-08-28T13:51:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e18f471d5f7922eccfe0ae515eb8358fe0c4c371","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls/4/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls/4/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/issues/4/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/statuses/0cd99af0dcd8386a672af275d28c3339a52ccb66","head":{"label":"CenterForOpenScience:pr-guide","ref":"pr-guide","sha":"0cd99af0dcd8386a672af275d28c3339a52ccb66","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=2","gravatar_id":"9aa77e0718ce23c583ab6de0f046c20f","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":22643804,"name":"COSDev","full_name":"CenterForOpenScience/COSDev","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=2","gravatar_id":"9aa77e0718ce23c583ab6de0f046c20f","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/COSDev","description":"COS Development Docs","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/COSDev","forks_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/issues/comments/{number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/releases{/id}","created_at":"2014-08-05T13:07:37Z","updated_at":"2014-08-19T17:56:24Z","pushed_at":"2014-08-28T13:48:05Z","git_url":"git://github.com/CenterForOpenScience/COSDev.git","ssh_url":"git@github.com:CenterForOpenScience/COSDev.git","clone_url":"https://github.com/CenterForOpenScience/COSDev.git","svn_url":"https://github.com/CenterForOpenScience/COSDev","homepage":"http://cosdev.readthedocs.org","size":384,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"CenterForOpenScience:master","ref":"master","sha":"a620914cad1e8bf2770356fcb339435ebfa36b83","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=2","gravatar_id":"9aa77e0718ce23c583ab6de0f046c20f","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":22643804,"name":"COSDev","full_name":"CenterForOpenScience/COSDev","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=2","gravatar_id":"9aa77e0718ce23c583ab6de0f046c20f","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/COSDev","description":"COS Development Docs","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/COSDev","forks_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/issues/comments/{number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/COSDev/releases{/id}","created_at":"2014-08-05T13:07:37Z","updated_at":"2014-08-19T17:56:24Z","pushed_at":"2014-08-28T13:48:05Z","git_url":"git://github.com/CenterForOpenScience/COSDev.git","ssh_url":"git@github.com:CenterForOpenScience/COSDev.git","clone_url":"https://github.com/CenterForOpenScience/COSDev.git","svn_url":"https://github.com/CenterForOpenScience/COSDev","homepage":"http://cosdev.readthedocs.org","size":384,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls/4"},"html":{"href":"https://github.com/CenterForOpenScience/COSDev/pull/4"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/COSDev/issues/4"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/COSDev/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/COSDev/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/COSDev/statuses/0cd99af0dcd8386a672af275d28c3339a52ccb66"}}}}