GitHub PullRequestReviewCommentEvent at 2014-10-13 17:06:32
Repository: go-statsdclient
Actor: dtjm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls/comments/18781143","id":18781143,"diff_hunk":"@@ -0,0 +1,34 @@\n+package statsdclient\n+\n+import (\n+\t\"net\"\n+)\n+\n+type writeToConn struct {\n+\tpacketListener net.PacketConn\n+\tremoteAddr     *net.UDPAddr\n+}\n+\n+func newWriteToConn(raddr string) (*writeToConn, error) {\n+\t// need to create the local socket for sending messages from\n+\tpacketListener, err := net.ListenPacket(\"udp\", \"127.0.0.1:0\")\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\n+\t// resolve the udp address provided\n+\tremoteAddr, err := net.ResolveUDPAddr(\"udp\", raddr)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\n+\treturn &writeToConn{packetListener: packetListener, remoteAddr: remoteAddr}, nil\n+}\n+\n+func (w *writeToConn) Write(p []byte) (int, error) {","path":"writetoconn.go","position":28,"original_position":28,"commit_id":"3ef2def5ae711bd0e99ed38698a7a74a83bd2680","original_commit_id":"3ef2def5ae711bd0e99ed38698a7a74a83bd2680","user":{"login":"dtjm","id":118077,"avatar_url":"https://avatars.githubusercontent.com/u/118077?v=2","gravatar_id":"","url":"https://api.github.com/users/dtjm","html_url":"https://github.com/dtjm","followers_url":"https://api.github.com/users/dtjm/followers","following_url":"https://api.github.com/users/dtjm/following{/other_user}","gists_url":"https://api.github.com/users/dtjm/gists{/gist_id}","starred_url":"https://api.github.com/users/dtjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtjm/subscriptions","organizations_url":"https://api.github.com/users/dtjm/orgs","repos_url":"https://api.github.com/users/dtjm/repos","events_url":"https://api.github.com/users/dtjm/events{/privacy}","received_events_url":"https://api.github.com/users/dtjm/received_events","type":"User","site_admin":false},"body":"Do we want to return an error for byte slices larger than 64k? (or whatever the UDP message size limit is)","created_at":"2014-10-13T17:06:32Z","updated_at":"2014-10-13T17:06:32Z","html_url":"https://github.com/sendgrid/go-statsdclient/pull/19#discussion_r18781143","pull_request_url":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls/comments/18781143"},"html":{"href":"https://github.com/sendgrid/go-statsdclient/pull/19#discussion_r18781143"},"pull_request":{"href":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls/19","id":22657432,"html_url":"https://github.com/sendgrid/go-statsdclient/pull/19","diff_url":"https://github.com/sendgrid/go-statsdclient/pull/19.diff","patch_url":"https://github.com/sendgrid/go-statsdclient/pull/19.patch","issue_url":"https://api.github.com/repos/sendgrid/go-statsdclient/issues/19","number":19,"state":"open","locked":false,"title":"Try this using the WriteTo method","user":{"login":"partkyle","id":360387,"avatar_url":"https://avatars.githubusercontent.com/u/360387?v=2","gravatar_id":"","url":"https://api.github.com/users/partkyle","html_url":"https://github.com/partkyle","followers_url":"https://api.github.com/users/partkyle/followers","following_url":"https://api.github.com/users/partkyle/following{/other_user}","gists_url":"https://api.github.com/users/partkyle/gists{/gist_id}","starred_url":"https://api.github.com/users/partkyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/partkyle/subscriptions","organizations_url":"https://api.github.com/users/partkyle/orgs","repos_url":"https://api.github.com/users/partkyle/repos","events_url":"https://api.github.com/users/partkyle/events{/privacy}","received_events_url":"https://api.github.com/users/partkyle/received_events","type":"User","site_admin":false},"body":"This should resolve the same issue that #18 does, and it doesn't require an external dependencies, or using raw syscalls.","created_at":"2014-10-13T16:45:26Z","updated_at":"2014-10-13T17:06:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"487634c3fd21776ff549d9b05ab6cc54682cb15f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls/19/commits","review_comments_url":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls/19/comments","review_comment_url":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sendgrid/go-statsdclient/issues/19/comments","statuses_url":"https://api.github.com/repos/sendgrid/go-statsdclient/statuses/3ef2def5ae711bd0e99ed38698a7a74a83bd2680","head":{"label":"sendgrid:writeTo-conn-wrapper","ref":"writeTo-conn-wrapper","sha":"3ef2def5ae711bd0e99ed38698a7a74a83bd2680","user":{"login":"sendgrid","id":181234,"avatar_url":"https://avatars.githubusercontent.com/u/181234?v=2","gravatar_id":"","url":"https://api.github.com/users/sendgrid","html_url":"https://github.com/sendgrid","followers_url":"https://api.github.com/users/sendgrid/followers","following_url":"https://api.github.com/users/sendgrid/following{/other_user}","gists_url":"https://api.github.com/users/sendgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/sendgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sendgrid/subscriptions","organizations_url":"https://api.github.com/users/sendgrid/orgs","repos_url":"https://api.github.com/users/sendgrid/repos","events_url":"https://api.github.com/users/sendgrid/events{/privacy}","received_events_url":"https://api.github.com/users/sendgrid/received_events","type":"Organization","site_admin":false},"repo":{"id":15615643,"name":"go-statsdclient","full_name":"sendgrid/go-statsdclient","owner":{"login":"sendgrid","id":181234,"avatar_url":"https://avatars.githubusercontent.com/u/181234?v=2","gravatar_id":"","url":"https://api.github.com/users/sendgrid","html_url":"https://github.com/sendgrid","followers_url":"https://api.github.com/users/sendgrid/followers","following_url":"https://api.github.com/users/sendgrid/following{/other_user}","gists_url":"https://api.github.com/users/sendgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/sendgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sendgrid/subscriptions","organizations_url":"https://api.github.com/users/sendgrid/orgs","repos_url":"https://api.github.com/users/sendgrid/repos","events_url":"https://api.github.com/users/sendgrid/events{/privacy}","received_events_url":"https://api.github.com/users/sendgrid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sendgrid/go-statsdclient","description":"A client library for statsd written in Go (forked from cyberdelia/statsd)","fork":true,"url":"https://api.github.com/repos/sendgrid/go-statsdclient","forks_url":"https://api.github.com/repos/sendgrid/go-statsdclient/forks","keys_url":"https://api.github.com/repos/sendgrid/go-statsdclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sendgrid/go-statsdclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sendgrid/go-statsdclient/teams","hooks_url":"https://api.github.com/repos/sendgrid/go-statsdclient/hooks","issue_events_url":"https://api.github.com/repos/sendgrid/go-statsdclient/issues/events{/number}","events_url":"https://api.github.com/repos/sendgrid/go-statsdclient/events","assignees_url":"https://api.github.com/repos/sendgrid/go-statsdclient/assignees{/user}","branches_url":"https://api.github.com/repos/sendgrid/go-statsdclient/branches{/branch}","tags_url":"https://api.github.com/repos/sendgrid/go-statsdclient/tags","blobs_url":"https://api.github.com/repos/sendgrid/go-statsdclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sendgrid/go-statsdclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sendgrid/go-statsdclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/sendgrid/go-statsdclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sendgrid/go-statsdclient/statuses/{sha}","languages_url":"https://api.github.com/repos/sendgrid/go-statsdclient/languages","stargazers_url":"https://api.github.com/repos/sendgrid/go-statsdclient/stargazers","contributors_url":"https://api.github.com/repos/sendgrid/go-statsdclient/contributors","subscribers_url":"https://api.github.com/repos/sendgrid/go-statsdclient/subscribers","subscription_url":"https://api.github.com/repos/sendgrid/go-statsdclient/subscription","commits_url":"https://api.github.com/repos/sendgrid/go-statsdclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/sendgrid/go-statsdclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/sendgrid/go-statsdclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/sendgrid/go-statsdclient/issues/comments/{number}","contents_url":"https://api.github.com/repos/sendgrid/go-statsdclient/contents/{+path}","compare_url":"https://api.github.com/repos/sendgrid/go-statsdclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sendgrid/go-statsdclient/merges","archive_url":"https://api.github.com/repos/sendgrid/go-statsdclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sendgrid/go-statsdclient/downloads","issues_url":"https://api.github.com/repos/sendgrid/go-statsdclient/issues{/number}","pulls_url":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls{/number}","milestones_url":"https://api.github.com/repos/sendgrid/go-statsdclient/milestones{/number}","notifications_url":"https://api.github.com/repos/sendgrid/go-statsdclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sendgrid/go-statsdclient/labels{/name}","releases_url":"https://api.github.com/repos/sendgrid/go-statsdclient/releases{/id}","created_at":"2014-01-03T17:53:24Z","updated_at":"2014-07-07T22:40:35Z","pushed_at":"2014-10-13T16:43:48Z","git_url":"git://github.com/sendgrid/go-statsdclient.git","ssh_url":"git@github.com:sendgrid/go-statsdclient.git","clone_url":"https://github.com/sendgrid/go-statsdclient.git","svn_url":"https://github.com/sendgrid/go-statsdclient","homepage":"","size":637,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"sendgrid:master","ref":"master","sha":"f67fe40f8ae0cf702d7be9e36a145e4f7beffdd8","user":{"login":"sendgrid","id":181234,"avatar_url":"https://avatars.githubusercontent.com/u/181234?v=2","gravatar_id":"","url":"https://api.github.com/users/sendgrid","html_url":"https://github.com/sendgrid","followers_url":"https://api.github.com/users/sendgrid/followers","following_url":"https://api.github.com/users/sendgrid/following{/other_user}","gists_url":"https://api.github.com/users/sendgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/sendgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sendgrid/subscriptions","organizations_url":"https://api.github.com/users/sendgrid/orgs","repos_url":"https://api.github.com/users/sendgrid/repos","events_url":"https://api.github.com/users/sendgrid/events{/privacy}","received_events_url":"https://api.github.com/users/sendgrid/received_events","type":"Organization","site_admin":false},"repo":{"id":15615643,"name":"go-statsdclient","full_name":"sendgrid/go-statsdclient","owner":{"login":"sendgrid","id":181234,"avatar_url":"https://avatars.githubusercontent.com/u/181234?v=2","gravatar_id":"","url":"https://api.github.com/users/sendgrid","html_url":"https://github.com/sendgrid","followers_url":"https://api.github.com/users/sendgrid/followers","following_url":"https://api.github.com/users/sendgrid/following{/other_user}","gists_url":"https://api.github.com/users/sendgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/sendgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sendgrid/subscriptions","organizations_url":"https://api.github.com/users/sendgrid/orgs","repos_url":"https://api.github.com/users/sendgrid/repos","events_url":"https://api.github.com/users/sendgrid/events{/privacy}","received_events_url":"https://api.github.com/users/sendgrid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sendgrid/go-statsdclient","description":"A client library for statsd written in Go (forked from cyberdelia/statsd)","fork":true,"url":"https://api.github.com/repos/sendgrid/go-statsdclient","forks_url":"https://api.github.com/repos/sendgrid/go-statsdclient/forks","keys_url":"https://api.github.com/repos/sendgrid/go-statsdclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sendgrid/go-statsdclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sendgrid/go-statsdclient/teams","hooks_url":"https://api.github.com/repos/sendgrid/go-statsdclient/hooks","issue_events_url":"https://api.github.com/repos/sendgrid/go-statsdclient/issues/events{/number}","events_url":"https://api.github.com/repos/sendgrid/go-statsdclient/events","assignees_url":"https://api.github.com/repos/sendgrid/go-statsdclient/assignees{/user}","branches_url":"https://api.github.com/repos/sendgrid/go-statsdclient/branches{/branch}","tags_url":"https://api.github.com/repos/sendgrid/go-statsdclient/tags","blobs_url":"https://api.github.com/repos/sendgrid/go-statsdclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sendgrid/go-statsdclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sendgrid/go-statsdclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/sendgrid/go-statsdclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sendgrid/go-statsdclient/statuses/{sha}","languages_url":"https://api.github.com/repos/sendgrid/go-statsdclient/languages","stargazers_url":"https://api.github.com/repos/sendgrid/go-statsdclient/stargazers","contributors_url":"https://api.github.com/repos/sendgrid/go-statsdclient/contributors","subscribers_url":"https://api.github.com/repos/sendgrid/go-statsdclient/subscribers","subscription_url":"https://api.github.com/repos/sendgrid/go-statsdclient/subscription","commits_url":"https://api.github.com/repos/sendgrid/go-statsdclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/sendgrid/go-statsdclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/sendgrid/go-statsdclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/sendgrid/go-statsdclient/issues/comments/{number}","contents_url":"https://api.github.com/repos/sendgrid/go-statsdclient/contents/{+path}","compare_url":"https://api.github.com/repos/sendgrid/go-statsdclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sendgrid/go-statsdclient/merges","archive_url":"https://api.github.com/repos/sendgrid/go-statsdclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sendgrid/go-statsdclient/downloads","issues_url":"https://api.github.com/repos/sendgrid/go-statsdclient/issues{/number}","pulls_url":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls{/number}","milestones_url":"https://api.github.com/repos/sendgrid/go-statsdclient/milestones{/number}","notifications_url":"https://api.github.com/repos/sendgrid/go-statsdclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sendgrid/go-statsdclient/labels{/name}","releases_url":"https://api.github.com/repos/sendgrid/go-statsdclient/releases{/id}","created_at":"2014-01-03T17:53:24Z","updated_at":"2014-07-07T22:40:35Z","pushed_at":"2014-10-13T16:43:48Z","git_url":"git://github.com/sendgrid/go-statsdclient.git","ssh_url":"git@github.com:sendgrid/go-statsdclient.git","clone_url":"https://github.com/sendgrid/go-statsdclient.git","svn_url":"https://github.com/sendgrid/go-statsdclient","homepage":"","size":637,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls/19"},"html":{"href":"https://github.com/sendgrid/go-statsdclient/pull/19"},"issue":{"href":"https://api.github.com/repos/sendgrid/go-statsdclient/issues/19"},"comments":{"href":"https://api.github.com/repos/sendgrid/go-statsdclient/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sendgrid/go-statsdclient/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/sendgrid/go-statsdclient/statuses/3ef2def5ae711bd0e99ed38698a7a74a83bd2680"}}}}