GitHub PullRequestReviewCommentEvent at 2014-11-12 09:33:04
Repository: HPCC-Platform
Actor: jakesmith
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/20208916","id":20208916,"diff_hunk":"@@ -10020,6 +10020,12 @@ class CWorkflowScheduleConnection : public CInterface, implements IWorkflowSched\n         eventQueue->addPropTree(\"Item\", eventItem.getLink());\n     }\n \n+    virtual void remove()\n+    {\n+        baseconn->close(true);","path":"common/workunit/workunit.cpp","position":6,"original_position":6,"commit_id":"0ab54ae307a59d0f79b8270227334d9daa9116da","original_commit_id":"0ab54ae307a59d0f79b8270227334d9daa9116da","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"body":"Perhaps remove() is only called in context of successfull lock() and therefore valid 'baseconn', but this looks like it should really have a 'if (baseconn)' check, in case not setup.","created_at":"2014-11-12T09:33:04Z","updated_at":"2014-11-12T09:33:04Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6629#discussion_r20208916","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6629","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/20208916"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/6629#discussion_r20208916"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6629"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6629","id":24157246,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6629","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6629.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6629.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6629","number":6629,"state":"open","locked":false,"title":"HPCC-12563 Clean up scheduling workunits that are failed then deleted","user":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?v=3","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>","created_at":"2014-11-10T16:15:22Z","updated_at":"2014-11-12T09:33:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78e91de42aac8f0d5cffaf22246abaa7f0b6a005","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6629/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6629/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6629/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/0ab54ae307a59d0f79b8270227334d9daa9116da","head":{"label":"ghalliday:issue12563","ref":"issue12563","sha":"0ab54ae307a59d0f79b8270227334d9daa9116da","user":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?v=3","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"repo":{"id":2034867,"name":"HPCC-Platform","full_name":"ghalliday/HPCC-Platform","owner":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?v=3","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghalliday/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/ghalliday/HPCC-Platform","forks_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/ghalliday/HPCC-Platform/releases{/id}","created_at":"2011-07-12T08:05:04Z","updated_at":"2014-09-01T13:30:07Z","pushed_at":"2014-11-11T15:45:55Z","git_url":"git://github.com/ghalliday/HPCC-Platform.git","ssh_url":"git@github.com:ghalliday/HPCC-Platform.git","clone_url":"https://github.com/ghalliday/HPCC-Platform.git","svn_url":"https://github.com/ghalliday/HPCC-Platform","homepage":"www.hpccsystems.com","size":136702,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"f2a1b20ef44cd802f3dc17d31a084d7e073a0526","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2014-10-28T21:46:08Z","pushed_at":"2014-11-12T09:28:00Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":270280,"stargazers_count":236,"watchers_count":236,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":429,"forks":94,"open_issues":429,"watchers":236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6629"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/6629"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6629"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6629/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6629/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6629/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/0ab54ae307a59d0f79b8270227334d9daa9116da"}}}}