GitHub PullRequestReviewCommentEvent at 2014-11-27 20:36:51
Repository: fireplace
Actor: mstriemer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/21010314","id":21010314,"diff_hunk":"@@ -53,6 +63,22 @@ define('installer_iframe',\n         }\n     }\n \n+    // Wait for events that need to be sorted by manifest URL.\n+    z.page.on('iframe-check-for-update iframe-apply-update', function(e, data) {\n+        console.log('Received message from iframe installer (' + data.name + ')');\n+        var manifestURL = data.manifestURL;\n+        var name = data.name;\n+        var def = deferreds[name][manifestURL];","path":"src/media/js/installer_iframe.js","position":41,"original_position":41,"commit_id":"be6293edeac88e93338ed391b94a83e6721e314f","original_commit_id":"be6293edeac88e93338ed391b94a83e6721e314f","user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"body":"I'm not sure if we'll ever get multiple requests for the same URL but should we reset the deferred here (`deferreds[name][manifestURL] = undefined;` or `delete deferreds[name][manifestURL]`)? If there's a \"Check for updates\" button you'd expect it to do another check rather than returning the cached results.","created_at":"2014-11-27T20:36:51Z","updated_at":"2014-11-27T20:36:51Z","html_url":"https://github.com/mozilla/fireplace/pull/823#discussion_r21010314","pull_request_url":"https://api.github.com/repos/mozilla/fireplace/pulls/823","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/21010314"},"html":{"href":"https://github.com/mozilla/fireplace/pull/823#discussion_r21010314"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/823"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/823","id":25006510,"html_url":"https://github.com/mozilla/fireplace/pull/823","diff_url":"https://github.com/mozilla/fireplace/pull/823.diff","patch_url":"https://github.com/mozilla/fireplace/pull/823.patch","issue_url":"https://api.github.com/repos/mozilla/fireplace/issues/823","number":823,"state":"open","locked":false,"title":"Check for Marketplace update, offer to download it if one is available (bug 1097430)","user":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"body":" * [ ] Merge zamboni side for the packaged app: mozilla/zamboni#2740\r\n * [x] Implement `applyUpdate()` in direct installer\r\n * [x] Style the banner and its buttons following mockups\r\n * [x] Map banner buttons, and change the content when the user chooses \"download\"\r\n * [x] Unit Tests\r\n\r\nTo test locally, you need to emulate the fact that you've got a Marketplace package installed. It can be done on Firefox Desktop while serving fireplace with gulp. Assuming you are serving Marketplace from `http://localhost:8675`:\r\n- Build a dummy packaged app, put it in `src/app.zip`\r\n- Build a dummy manifest and make it reference the app by setting  `\"package_path\": \"http://localhost:8675/app.zip\"`, then put it in `src/packaged.webapp`\r\n- Open `http://localhost:8675` in your browser, open the console and install the app with `navigator.mozApps.installPackage('http://localhost:8675/packaged.webapp')`\r\n- Verify with `navigator.getInstalled()` that the install worked, the package and manifest need to be valid, the result of `installPackage()` should give you hints if it failed\r\n- Reload `http://localhost:8675` - It should check for update in the background, but not find any yet\r\n- Bump version in manifest - reload `http://localhost:8675`, now it should offer you to upgrade\r\n- Clicking download should download the app and update it to the new version\r\n- If you reload `http://localhost:8675` should no longer offer you the update","created_at":"2014-11-25T13:13:47Z","updated_at":"2014-11-27T20:36:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0933c3925ed03a8d34e4e3866e1d11d295fd1860","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fireplace/pulls/823/commits","review_comments_url":"https://api.github.com/repos/mozilla/fireplace/pulls/823/comments","review_comment_url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/fireplace/issues/823/comments","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/be6293edeac88e93338ed391b94a83e6721e314f","head":{"label":"diox:update-notification","ref":"update-notification","sha":"be6293edeac88e93338ed391b94a83e6721e314f","user":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"repo":{"id":10312455,"name":"fireplace","full_name":"diox/fireplace","owner":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diox/fireplace","description":"Ignition, the Remix","fork":true,"url":"https://api.github.com/repos/diox/fireplace","forks_url":"https://api.github.com/repos/diox/fireplace/forks","keys_url":"https://api.github.com/repos/diox/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diox/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diox/fireplace/teams","hooks_url":"https://api.github.com/repos/diox/fireplace/hooks","issue_events_url":"https://api.github.com/repos/diox/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/diox/fireplace/events","assignees_url":"https://api.github.com/repos/diox/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/diox/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/diox/fireplace/tags","blobs_url":"https://api.github.com/repos/diox/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diox/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diox/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/diox/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diox/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/diox/fireplace/languages","stargazers_url":"https://api.github.com/repos/diox/fireplace/stargazers","contributors_url":"https://api.github.com/repos/diox/fireplace/contributors","subscribers_url":"https://api.github.com/repos/diox/fireplace/subscribers","subscription_url":"https://api.github.com/repos/diox/fireplace/subscription","commits_url":"https://api.github.com/repos/diox/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/diox/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/diox/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/diox/fireplace/issues/comments/{number}","contents_url":"https://api.github.com/repos/diox/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/diox/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diox/fireplace/merges","archive_url":"https://api.github.com/repos/diox/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diox/fireplace/downloads","issues_url":"https://api.github.com/repos/diox/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/diox/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/diox/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/diox/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diox/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/diox/fireplace/releases{/id}","created_at":"2013-05-27T10:09:58Z","updated_at":"2014-11-21T14:33:28Z","pushed_at":"2014-11-27T17:24:45Z","git_url":"git://github.com/diox/fireplace.git","ssh_url":"git@github.com:diox/fireplace.git","clone_url":"https://github.com/diox/fireplace.git","svn_url":"https://github.com/diox/fireplace","homepage":"https://marketplace.firefox.com/","size":22182,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"79a9676794478a02ef05649f9dda17f28cfb4cfd","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8046076,"name":"fireplace","full_name":"mozilla/fireplace","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fireplace","description":"Ignition, the Remix","fork":false,"url":"https://api.github.com/repos/mozilla/fireplace","forks_url":"https://api.github.com/repos/mozilla/fireplace/forks","keys_url":"https://api.github.com/repos/mozilla/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fireplace/teams","hooks_url":"https://api.github.com/repos/mozilla/fireplace/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fireplace/events","assignees_url":"https://api.github.com/repos/mozilla/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fireplace/tags","blobs_url":"https://api.github.com/repos/mozilla/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fireplace/languages","stargazers_url":"https://api.github.com/repos/mozilla/fireplace/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fireplace/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fireplace/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fireplace/subscription","commits_url":"https://api.github.com/repos/mozilla/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fireplace/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fireplace/merges","archive_url":"https://api.github.com/repos/mozilla/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fireplace/downloads","issues_url":"https://api.github.com/repos/mozilla/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fireplace/releases{/id}","created_at":"2013-02-06T06:41:06Z","updated_at":"2014-11-26T23:06:40Z","pushed_at":"2014-11-26T23:06:40Z","git_url":"git://github.com/mozilla/fireplace.git","ssh_url":"git@github.com:mozilla/fireplace.git","clone_url":"https://github.com/mozilla/fireplace.git","svn_url":"https://github.com/mozilla/fireplace","homepage":"https://marketplace.firefox.com/","size":89514,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":4,"forks":88,"open_issues":4,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/823"},"html":{"href":"https://github.com/mozilla/fireplace/pull/823"},"issue":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/823"},"comments":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/823/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/823/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/823/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fireplace/statuses/be6293edeac88e93338ed391b94a83e6721e314f"}}}}