GitHub PullRequestEvent at 2014-06-30 21:57:48
Repository: julia
Actor: JeffBezanson
Payload: {"action":"closed","number":3656,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/3656","id":6799461,"html_url":"https://github.com/JuliaLang/julia/pull/3656","diff_url":"https://github.com/JuliaLang/julia/pull/3656.diff","patch_url":"https://github.com/JuliaLang/julia/pull/3656.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/3656","number":3656,"state":"closed","title":"RFM: mark/reset for IOStream, IOBuffer, & AsyncStream (addresses #2638)","user":{"login":"kmsquire","id":223250,"avatar_url":"https://avatars.githubusercontent.com/u/223250?","gravatar_id":"42c8c4ab92de3390bcd2f637ef6ca16c","url":"https://api.github.com/users/kmsquire","html_url":"https://github.com/kmsquire","followers_url":"https://api.github.com/users/kmsquire/followers","following_url":"https://api.github.com/users/kmsquire/following{/other_user}","gists_url":"https://api.github.com/users/kmsquire/gists{/gist_id}","starred_url":"https://api.github.com/users/kmsquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmsquire/subscriptions","organizations_url":"https://api.github.com/users/kmsquire/orgs","repos_url":"https://api.github.com/users/kmsquire/repos","events_url":"https://api.github.com/users/kmsquire/events{/privacy}","received_events_url":"https://api.github.com/users/kmsquire/received_events","type":"User","site_admin":false},"body":"**Edit:**\r\n\r\nThe current patch provides:\r\n\r\n1) `mark()`,  `reset()`, `unmark()`, and `ismarked()` for `IOStream` and `IOBuffer` (and `AsyncStream` through `IOBuffer`)\r\n2) Simple testing for `AsyncStreams`  and `IOStream`\r\n\r\nThese are loosely based on ideas from Java's BufferedReader, which allows a programmer to mark a location in an IO stream, and then seek back to that location later, even if the IO stream itself is not seekable:\r\n\r\n```\r\nm = mark(b::IO)  - marks a position in the wrapped IO object\r\nreset(b::IO, m)  - resets b back to a marked position; the mark is removed\r\nunmark(b::IO, m) - removes a mark\r\nismarked(b::IO)  - returns true if b is marked\r\n```\r\n\r\nSee #2638 for further discussion.\r\n","created_at":"2013-07-09T08:05:39Z","updated_at":"2014-06-30T21:57:47Z","closed_at":"2014-06-30T21:57:47Z","merged_at":"2014-06-30T21:57:47Z","merge_commit_sha":"54502b7f7a80a4f2216defa513b67d3a92d1d14b","assignee":null,"milestone":{"url":"https://api.github.com/repos/JuliaLang/julia/milestones/7","labels_url":"https://api.github.com/repos/JuliaLang/julia/milestones/7/labels","id":268826,"number":7,"title":"0.3","description":"Enhancements beyond 0.2.0 that are breaking, i.e. not backward compatible.","creator":{"login":"vtjnash","id":330950,"avatar_url":"https://avatars.githubusercontent.com/u/330950?","gravatar_id":"8af4d5971a2308b86a94f58fb98129c5","url":"https://api.github.com/users/vtjnash","html_url":"https://github.com/vtjnash","followers_url":"https://api.github.com/users/vtjnash/followers","following_url":"https://api.github.com/users/vtjnash/following{/other_user}","gists_url":"https://api.github.com/users/vtjnash/gists{/gist_id}","starred_url":"https://api.github.com/users/vtjnash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtjnash/subscriptions","organizations_url":"https://api.github.com/users/vtjnash/orgs","repos_url":"https://api.github.com/users/vtjnash/repos","events_url":"https://api.github.com/users/vtjnash/events{/privacy}","received_events_url":"https://api.github.com/users/vtjnash/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":192,"state":"open","created_at":"2013-02-17T05:16:31Z","updated_at":"2014-06-30T21:57:47Z","due_on":null},"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/3656/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/3656/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/3656/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/990f8f1f4a9bdec0b86ed4acb9ad8931358d0663","head":{"label":"kmsquire:buffered_reader","ref":"buffered_reader","sha":"990f8f1f4a9bdec0b86ed4acb9ad8931358d0663","user":{"login":"kmsquire","id":223250,"avatar_url":"https://avatars.githubusercontent.com/u/223250?","gravatar_id":"42c8c4ab92de3390bcd2f637ef6ca16c","url":"https://api.github.com/users/kmsquire","html_url":"https://github.com/kmsquire","followers_url":"https://api.github.com/users/kmsquire/followers","following_url":"https://api.github.com/users/kmsquire/following{/other_user}","gists_url":"https://api.github.com/users/kmsquire/gists{/gist_id}","starred_url":"https://api.github.com/users/kmsquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmsquire/subscriptions","organizations_url":"https://api.github.com/users/kmsquire/orgs","repos_url":"https://api.github.com/users/kmsquire/repos","events_url":"https://api.github.com/users/kmsquire/events{/privacy}","received_events_url":"https://api.github.com/users/kmsquire/received_events","type":"User","site_admin":false},"repo":{"id":4196602,"name":"julia","full_name":"kmsquire/julia","owner":{"login":"kmsquire","id":223250,"avatar_url":"https://avatars.githubusercontent.com/u/223250?","gravatar_id":"42c8c4ab92de3390bcd2f637ef6ca16c","url":"https://api.github.com/users/kmsquire","html_url":"https://github.com/kmsquire","followers_url":"https://api.github.com/users/kmsquire/followers","following_url":"https://api.github.com/users/kmsquire/following{/other_user}","gists_url":"https://api.github.com/users/kmsquire/gists{/gist_id}","starred_url":"https://api.github.com/users/kmsquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmsquire/subscriptions","organizations_url":"https://api.github.com/users/kmsquire/orgs","repos_url":"https://api.github.com/users/kmsquire/repos","events_url":"https://api.github.com/users/kmsquire/events{/privacy}","received_events_url":"https://api.github.com/users/kmsquire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmsquire/julia","description":"The Julia Language: a fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/kmsquire/julia","forks_url":"https://api.github.com/repos/kmsquire/julia/forks","keys_url":"https://api.github.com/repos/kmsquire/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmsquire/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmsquire/julia/teams","hooks_url":"https://api.github.com/repos/kmsquire/julia/hooks","issue_events_url":"https://api.github.com/repos/kmsquire/julia/issues/events{/number}","events_url":"https://api.github.com/repos/kmsquire/julia/events","assignees_url":"https://api.github.com/repos/kmsquire/julia/assignees{/user}","branches_url":"https://api.github.com/repos/kmsquire/julia/branches{/branch}","tags_url":"https://api.github.com/repos/kmsquire/julia/tags","blobs_url":"https://api.github.com/repos/kmsquire/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmsquire/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmsquire/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmsquire/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmsquire/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/kmsquire/julia/languages","stargazers_url":"https://api.github.com/repos/kmsquire/julia/stargazers","contributors_url":"https://api.github.com/repos/kmsquire/julia/contributors","subscribers_url":"https://api.github.com/repos/kmsquire/julia/subscribers","subscription_url":"https://api.github.com/repos/kmsquire/julia/subscription","commits_url":"https://api.github.com/repos/kmsquire/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmsquire/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmsquire/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmsquire/julia/issues/comments/{number}","contents_url":"https://api.github.com/repos/kmsquire/julia/contents/{+path}","compare_url":"https://api.github.com/repos/kmsquire/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmsquire/julia/merges","archive_url":"https://api.github.com/repos/kmsquire/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmsquire/julia/downloads","issues_url":"https://api.github.com/repos/kmsquire/julia/issues{/number}","pulls_url":"https://api.github.com/repos/kmsquire/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/kmsquire/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/kmsquire/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmsquire/julia/labels{/name}","releases_url":"https://api.github.com/repos/kmsquire/julia/releases{/id}","created_at":"2012-05-01T21:11:16Z","updated_at":"2014-06-25T04:19:42Z","pushed_at":"2014-06-25T04:19:42Z","git_url":"git://github.com/kmsquire/julia.git","ssh_url":"git@github.com:kmsquire/julia.git","clone_url":"https://github.com/kmsquire/julia.git","svn_url":"https://github.com/kmsquire/julia","homepage":"http://julialang.org/","size":58458,"stargazers_count":1,"watchers_count":1,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"aca9b6e1c847fc52b1aff78c2ede62463506da06","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?","gravatar_id":"d57c99557ab0dc0fa44b4c84447d0f15","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?","gravatar_id":"d57c99557ab0dc0fa44b4c84447d0f15","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/{number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2014-06-30T10:47:34Z","pushed_at":"2014-06-30T21:57:47Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":137990,"stargazers_count":3927,"watchers_count":3927,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":802,"mirror_url":null,"open_issues_count":787,"forks":802,"open_issues":787,"watchers":3927,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/3656"},"html":{"href":"https://github.com/JuliaLang/julia/pull/3656"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/3656"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/3656/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/3656/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/3656/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/990f8f1f4a9bdec0b86ed4acb9ad8931358d0663"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"JeffBezanson","id":744556,"avatar_url":"https://avatars.githubusercontent.com/u/744556?","gravatar_id":"b4b8db23d8096b722483a57d21b7d65d","url":"https://api.github.com/users/JeffBezanson","html_url":"https://github.com/JeffBezanson","followers_url":"https://api.github.com/users/JeffBezanson/followers","following_url":"https://api.github.com/users/JeffBezanson/following{/other_user}","gists_url":"https://api.github.com/users/JeffBezanson/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffBezanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffBezanson/subscriptions","organizations_url":"https://api.github.com/users/JeffBezanson/orgs","repos_url":"https://api.github.com/users/JeffBezanson/repos","events_url":"https://api.github.com/users/JeffBezanson/events{/privacy}","received_events_url":"https://api.github.com/users/JeffBezanson/received_events","type":"User","site_admin":false},"comments":58,"review_comments":4,"commits":1,"additions":477,"deletions":321,"changed_files":9}}