GitHub PullRequestReviewCommentEvent at 2014-06-17 01:06:40
Repository: buttonmen
Actor: blackshadowshade
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/comments/13838786","id":13838786,"diff_hunk":"@@ -56,8 +58,13 @@ public function load($recipe, $name = NULL, $isRecipeAltered = FALSE) {\n             $this->dieArray[] = $die;\n             if (is_null($die)) {\n                 $this->hasUnimplementedSkill = TRUE;\n-            } elseif (BMDie::unimplemented_skill_in_recipe($dieRecipe)) {\n-                $this->hasUnimplementedSkill = TRUE;\n+            } else {\n+                if (BMDie::unimplemented_skill_in_recipe($dieRecipe)) {\n+                    $this->hasUnimplementedSkill = TRUE;\n+                }\n+                foreach (array_keys($die->skillList) as $skill) {","path":"src/engine/BMButton.php","position":26,"original_position":26,"commit_id":"a0dbace61ac18b06ae2bcbf7817d18a441be58c7","original_commit_id":"a0dbace61ac18b06ae2bcbf7817d18a441be58c7","user":{"login":"blackshadowshade","id":2898401,"avatar_url":"https://avatars.githubusercontent.com/u/2898401?","gravatar_id":"03ea43da01767ea5c516703f334f254b","url":"https://api.github.com/users/blackshadowshade","html_url":"https://github.com/blackshadowshade","followers_url":"https://api.github.com/users/blackshadowshade/followers","following_url":"https://api.github.com/users/blackshadowshade/following{/other_user}","gists_url":"https://api.github.com/users/blackshadowshade/gists{/gist_id}","starred_url":"https://api.github.com/users/blackshadowshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackshadowshade/subscriptions","organizations_url":"https://api.github.com/users/blackshadowshade/orgs","repos_url":"https://api.github.com/users/blackshadowshade/repos","events_url":"https://api.github.com/users/blackshadowshade/events{/privacy}","received_events_url":"https://api.github.com/users/blackshadowshade/received_events","type":"User","site_admin":false},"body":"The internal skill class names don't go to the clients, they stop at BMInterface.","created_at":"2014-06-17T01:06:40Z","updated_at":"2014-06-17T01:06:40Z","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/979#discussion_r13838786","pull_request_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/979","_links":{"self":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/comments/13838786"},"html":{"href":"https://github.com/buttonmen-dev/buttonmen/pull/979#discussion_r13838786"},"pull_request":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/979"}}},"pull_request":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/979","id":17196517,"html_url":"https://github.com/buttonmen-dev/buttonmen/pull/979","diff_url":"https://github.com/buttonmen-dev/buttonmen/pull/979.diff","patch_url":"https://github.com/buttonmen-dev/buttonmen/pull/979.patch","issue_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/979","number":979,"state":"open","title":"create game UI modification to allow button limiting by button set, TL status, or die skills","user":{"login":"cgolubi1","id":2898207,"avatar_url":"https://avatars.githubusercontent.com/u/2898207?","gravatar_id":"804a577000a3e716a918fa25d51dc370","url":"https://api.github.com/users/cgolubi1","html_url":"https://github.com/cgolubi1","followers_url":"https://api.github.com/users/cgolubi1/followers","following_url":"https://api.github.com/users/cgolubi1/following{/other_user}","gists_url":"https://api.github.com/users/cgolubi1/gists{/gist_id}","starred_url":"https://api.github.com/users/cgolubi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgolubi1/subscriptions","organizations_url":"https://api.github.com/users/cgolubi1/orgs","repos_url":"https://api.github.com/users/cgolubi1/repos","events_url":"https://api.github.com/users/cgolubi1/events{/privacy}","received_events_url":"https://api.github.com/users/cgolubi1/received_events","type":"User","site_admin":false},"body":"* Fixes #109 (we can open new tickets for other requested changes)\r\n* Jenkins: http://jenkins.buttonweavers.com:8080/job/buttonmen-cgolubi1/254/","created_at":"2014-06-16T19:10:06Z","updated_at":"2014-06-17T01:06:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e37307d46a248bb2b8261df6f4fe4bf0cbcbbaaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/979/commits","review_comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/979/comments","review_comment_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/comments/{number}","comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/979/comments","statuses_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/statuses/a0dbace61ac18b06ae2bcbf7817d18a441be58c7","head":{"label":"cgolubi1:109_button_selection_ui","ref":"109_button_selection_ui","sha":"a0dbace61ac18b06ae2bcbf7817d18a441be58c7","user":{"login":"cgolubi1","id":2898207,"avatar_url":"https://avatars.githubusercontent.com/u/2898207?","gravatar_id":"804a577000a3e716a918fa25d51dc370","url":"https://api.github.com/users/cgolubi1","html_url":"https://github.com/cgolubi1","followers_url":"https://api.github.com/users/cgolubi1/followers","following_url":"https://api.github.com/users/cgolubi1/following{/other_user}","gists_url":"https://api.github.com/users/cgolubi1/gists{/gist_id}","starred_url":"https://api.github.com/users/cgolubi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgolubi1/subscriptions","organizations_url":"https://api.github.com/users/cgolubi1/orgs","repos_url":"https://api.github.com/users/cgolubi1/repos","events_url":"https://api.github.com/users/cgolubi1/events{/privacy}","received_events_url":"https://api.github.com/users/cgolubi1/received_events","type":"User","site_admin":false},"repo":{"id":6894409,"name":"buttonmen","full_name":"cgolubi1/buttonmen","owner":{"login":"cgolubi1","id":2898207,"avatar_url":"https://avatars.githubusercontent.com/u/2898207?","gravatar_id":"804a577000a3e716a918fa25d51dc370","url":"https://api.github.com/users/cgolubi1","html_url":"https://github.com/cgolubi1","followers_url":"https://api.github.com/users/cgolubi1/followers","following_url":"https://api.github.com/users/cgolubi1/following{/other_user}","gists_url":"https://api.github.com/users/cgolubi1/gists{/gist_id}","starred_url":"https://api.github.com/users/cgolubi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgolubi1/subscriptions","organizations_url":"https://api.github.com/users/cgolubi1/orgs","repos_url":"https://api.github.com/users/cgolubi1/repos","events_url":"https://api.github.com/users/cgolubi1/events{/privacy}","received_events_url":"https://api.github.com/users/cgolubi1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgolubi1/buttonmen","description":"Buttonmen - an online dice game","fork":true,"url":"https://api.github.com/repos/cgolubi1/buttonmen","forks_url":"https://api.github.com/repos/cgolubi1/buttonmen/forks","keys_url":"https://api.github.com/repos/cgolubi1/buttonmen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgolubi1/buttonmen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgolubi1/buttonmen/teams","hooks_url":"https://api.github.com/repos/cgolubi1/buttonmen/hooks","issue_events_url":"https://api.github.com/repos/cgolubi1/buttonmen/issues/events{/number}","events_url":"https://api.github.com/repos/cgolubi1/buttonmen/events","assignees_url":"https://api.github.com/repos/cgolubi1/buttonmen/assignees{/user}","branches_url":"https://api.github.com/repos/cgolubi1/buttonmen/branches{/branch}","tags_url":"https://api.github.com/repos/cgolubi1/buttonmen/tags","blobs_url":"https://api.github.com/repos/cgolubi1/buttonmen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgolubi1/buttonmen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgolubi1/buttonmen/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgolubi1/buttonmen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgolubi1/buttonmen/statuses/{sha}","languages_url":"https://api.github.com/repos/cgolubi1/buttonmen/languages","stargazers_url":"https://api.github.com/repos/cgolubi1/buttonmen/stargazers","contributors_url":"https://api.github.com/repos/cgolubi1/buttonmen/contributors","subscribers_url":"https://api.github.com/repos/cgolubi1/buttonmen/subscribers","subscription_url":"https://api.github.com/repos/cgolubi1/buttonmen/subscription","commits_url":"https://api.github.com/repos/cgolubi1/buttonmen/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgolubi1/buttonmen/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgolubi1/buttonmen/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgolubi1/buttonmen/issues/comments/{number}","contents_url":"https://api.github.com/repos/cgolubi1/buttonmen/contents/{+path}","compare_url":"https://api.github.com/repos/cgolubi1/buttonmen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgolubi1/buttonmen/merges","archive_url":"https://api.github.com/repos/cgolubi1/buttonmen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgolubi1/buttonmen/downloads","issues_url":"https://api.github.com/repos/cgolubi1/buttonmen/issues{/number}","pulls_url":"https://api.github.com/repos/cgolubi1/buttonmen/pulls{/number}","milestones_url":"https://api.github.com/repos/cgolubi1/buttonmen/milestones{/number}","notifications_url":"https://api.github.com/repos/cgolubi1/buttonmen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgolubi1/buttonmen/labels{/name}","releases_url":"https://api.github.com/repos/cgolubi1/buttonmen/releases{/id}","created_at":"2012-11-28T01:47:46Z","updated_at":"2014-06-17T00:23:05Z","pushed_at":"2014-06-16T23:37:44Z","git_url":"git://github.com/cgolubi1/buttonmen.git","ssh_url":"git@github.com:cgolubi1/buttonmen.git","clone_url":"https://github.com/cgolubi1/buttonmen.git","svn_url":"https://github.com/cgolubi1/buttonmen","homepage":null,"size":31615,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buttonmen-dev:master","ref":"master","sha":"35bcdfadaa12e91781228b1681fa24048ee35a94","user":{"login":"buttonmen-dev","id":2898279,"avatar_url":"https://avatars.githubusercontent.com/u/2898279?","gravatar_id":null,"url":"https://api.github.com/users/buttonmen-dev","html_url":"https://github.com/buttonmen-dev","followers_url":"https://api.github.com/users/buttonmen-dev/followers","following_url":"https://api.github.com/users/buttonmen-dev/following{/other_user}","gists_url":"https://api.github.com/users/buttonmen-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/buttonmen-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buttonmen-dev/subscriptions","organizations_url":"https://api.github.com/users/buttonmen-dev/orgs","repos_url":"https://api.github.com/users/buttonmen-dev/repos","events_url":"https://api.github.com/users/buttonmen-dev/events{/privacy}","received_events_url":"https://api.github.com/users/buttonmen-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":6877175,"name":"buttonmen","full_name":"buttonmen-dev/buttonmen","owner":{"login":"buttonmen-dev","id":2898279,"avatar_url":"https://avatars.githubusercontent.com/u/2898279?","gravatar_id":null,"url":"https://api.github.com/users/buttonmen-dev","html_url":"https://github.com/buttonmen-dev","followers_url":"https://api.github.com/users/buttonmen-dev/followers","following_url":"https://api.github.com/users/buttonmen-dev/following{/other_user}","gists_url":"https://api.github.com/users/buttonmen-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/buttonmen-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buttonmen-dev/subscriptions","organizations_url":"https://api.github.com/users/buttonmen-dev/orgs","repos_url":"https://api.github.com/users/buttonmen-dev/repos","events_url":"https://api.github.com/users/buttonmen-dev/events{/privacy}","received_events_url":"https://api.github.com/users/buttonmen-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buttonmen-dev/buttonmen","description":"Buttonmen - an online dice game","fork":false,"url":"https://api.github.com/repos/buttonmen-dev/buttonmen","forks_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/forks","keys_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/teams","hooks_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/hooks","issue_events_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/events{/number}","events_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/events","assignees_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/assignees{/user}","branches_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/branches{/branch}","tags_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/tags","blobs_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/refs{/sha}","trees_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/statuses/{sha}","languages_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/languages","stargazers_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/stargazers","contributors_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/contributors","subscribers_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/subscribers","subscription_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/subscription","commits_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/commits{/sha}","git_commits_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/commits{/sha}","comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/comments{/number}","issue_comment_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/comments/{number}","contents_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/contents/{+path}","compare_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/merges","archive_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/downloads","issues_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues{/number}","pulls_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls{/number}","milestones_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/milestones{/number}","notifications_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/labels{/name}","releases_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/releases{/id}","created_at":"2012-11-27T03:55:05Z","updated_at":"2014-06-17T00:23:05Z","pushed_at":"2014-06-17T00:23:05Z","git_url":"git://github.com/buttonmen-dev/buttonmen.git","ssh_url":"git@github.com:buttonmen-dev/buttonmen.git","clone_url":"https://github.com/buttonmen-dev/buttonmen.git","svn_url":"https://github.com/buttonmen-dev/buttonmen","homepage":null,"size":34390,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9,"mirror_url":null,"open_issues_count":223,"forks":9,"open_issues":223,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/979"},"html":{"href":"https://github.com/buttonmen-dev/buttonmen/pull/979"},"issue":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/979"},"comments":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/979/comments"},"review_comments":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/979/comments"},"review_comment":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/979/commits"},"statuses":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/statuses/a0dbace61ac18b06ae2bcbf7817d18a441be58c7"}}}}