GitHub PullRequestEvent at 2014-08-14 16:52:15
Repository: RxJava
Actor: benjchristensen
Payload: {"action":"closed","number":1577,"pull_request":{"url":"https://api.github.com/repos/Netflix/RxJava/pulls/1577","id":19781277,"html_url":"https://github.com/Netflix/RxJava/pull/1577","diff_url":"https://github.com/Netflix/RxJava/pull/1577.diff","patch_url":"https://github.com/Netflix/RxJava/pull/1577.patch","issue_url":"https://api.github.com/repos/Netflix/RxJava/issues/1577","number":1577,"state":"closed","locked":false,"title":"Fix the compose covariance","user":{"login":"zsxwing","id":1000778,"avatar_url":"https://avatars.githubusercontent.com/u/1000778?v=2","gravatar_id":"296dc6fb8472e818b3e8ad4f778b4f91","url":"https://api.github.com/users/zsxwing","html_url":"https://github.com/zsxwing","followers_url":"https://api.github.com/users/zsxwing/followers","following_url":"https://api.github.com/users/zsxwing/following{/other_user}","gists_url":"https://api.github.com/users/zsxwing/gists{/gist_id}","starred_url":"https://api.github.com/users/zsxwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsxwing/subscriptions","organizations_url":"https://api.github.com/users/zsxwing/orgs","repos_url":"https://api.github.com/users/zsxwing/repos","events_url":"https://api.github.com/users/zsxwing/events{/privacy}","received_events_url":"https://api.github.com/users/zsxwing/received_events","type":"User","site_admin":false},"body":"Changed the return type of `compose` from `Observable<? extends R>` to `Observable<R>`. The reason is that if returning `Observable<? extends R>`, the following codes won't work in Java:\r\n\r\n```Java\r\n        Observable<String> o1 = Observable.from(\"s1\");\r\n        Observable<String> o2 = o1.compose(new Transformer<String, String>() {\r\n            @Override\r\n            public Observable<? extends String> call(Observable<? extends String> t1) {\r\n                return Observable.from(\"s2\");\r\n            }\r\n        });\r\n```\r\nwe have to write:\r\n```Java\r\n        Observable<String> o1 = Observable.from(\"s1\");\r\n        Observable<? extends String> o2 = o1.compose(new Transformer<String, String>() {\r\n            @Override\r\n            public Observable<? extends String> call(Observable<? extends String> t1) {\r\n                return Observable.from(\"s2\");\r\n            }\r\n        });\r\n```\r\nBecause we cannot assign `Observable<? extends R>` to a `Observable<R>` variable, we should avoid to return `Observable<? extends R>`, otherwise the API will be inconvenient.","created_at":"2014-08-14T11:17:49Z","updated_at":"2014-08-14T16:52:14Z","closed_at":"2014-08-14T16:52:14Z","merged_at":"2014-08-14T16:52:14Z","merge_commit_sha":"34658750ebdf99f6adfe58fe9489af107e5cc446","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/RxJava/pulls/1577/commits","review_comments_url":"https://api.github.com/repos/Netflix/RxJava/pulls/1577/comments","review_comment_url":"https://api.github.com/repos/Netflix/RxJava/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Netflix/RxJava/issues/1577/comments","statuses_url":"https://api.github.com/repos/Netflix/RxJava/statuses/a0c52f16b3dce06b73ea209f9c33b19c6164ac2d","head":{"label":"zsxwing:compose-covariance","ref":"compose-covariance","sha":"a0c52f16b3dce06b73ea209f9c33b19c6164ac2d","user":{"login":"zsxwing","id":1000778,"avatar_url":"https://avatars.githubusercontent.com/u/1000778?v=2","gravatar_id":"296dc6fb8472e818b3e8ad4f778b4f91","url":"https://api.github.com/users/zsxwing","html_url":"https://github.com/zsxwing","followers_url":"https://api.github.com/users/zsxwing/followers","following_url":"https://api.github.com/users/zsxwing/following{/other_user}","gists_url":"https://api.github.com/users/zsxwing/gists{/gist_id}","starred_url":"https://api.github.com/users/zsxwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsxwing/subscriptions","organizations_url":"https://api.github.com/users/zsxwing/orgs","repos_url":"https://api.github.com/users/zsxwing/repos","events_url":"https://api.github.com/users/zsxwing/events{/privacy}","received_events_url":"https://api.github.com/users/zsxwing/received_events","type":"User","site_admin":false},"repo":{"id":12863876,"name":"RxJava","full_name":"zsxwing/RxJava","owner":{"login":"zsxwing","id":1000778,"avatar_url":"https://avatars.githubusercontent.com/u/1000778?v=2","gravatar_id":"296dc6fb8472e818b3e8ad4f778b4f91","url":"https://api.github.com/users/zsxwing","html_url":"https://github.com/zsxwing","followers_url":"https://api.github.com/users/zsxwing/followers","following_url":"https://api.github.com/users/zsxwing/following{/other_user}","gists_url":"https://api.github.com/users/zsxwing/gists{/gist_id}","starred_url":"https://api.github.com/users/zsxwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsxwing/subscriptions","organizations_url":"https://api.github.com/users/zsxwing/orgs","repos_url":"https://api.github.com/users/zsxwing/repos","events_url":"https://api.github.com/users/zsxwing/events{/privacy}","received_events_url":"https://api.github.com/users/zsxwing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zsxwing/RxJava","description":"RxJava - a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":true,"url":"https://api.github.com/repos/zsxwing/RxJava","forks_url":"https://api.github.com/repos/zsxwing/RxJava/forks","keys_url":"https://api.github.com/repos/zsxwing/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zsxwing/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zsxwing/RxJava/teams","hooks_url":"https://api.github.com/repos/zsxwing/RxJava/hooks","issue_events_url":"https://api.github.com/repos/zsxwing/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/zsxwing/RxJava/events","assignees_url":"https://api.github.com/repos/zsxwing/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/zsxwing/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/zsxwing/RxJava/tags","blobs_url":"https://api.github.com/repos/zsxwing/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zsxwing/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zsxwing/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/zsxwing/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zsxwing/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/zsxwing/RxJava/languages","stargazers_url":"https://api.github.com/repos/zsxwing/RxJava/stargazers","contributors_url":"https://api.github.com/repos/zsxwing/RxJava/contributors","subscribers_url":"https://api.github.com/repos/zsxwing/RxJava/subscribers","subscription_url":"https://api.github.com/repos/zsxwing/RxJava/subscription","commits_url":"https://api.github.com/repos/zsxwing/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/zsxwing/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/zsxwing/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/zsxwing/RxJava/issues/comments/{number}","contents_url":"https://api.github.com/repos/zsxwing/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/zsxwing/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zsxwing/RxJava/merges","archive_url":"https://api.github.com/repos/zsxwing/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zsxwing/RxJava/downloads","issues_url":"https://api.github.com/repos/zsxwing/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/zsxwing/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/zsxwing/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/zsxwing/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zsxwing/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/zsxwing/RxJava/releases{/id}","created_at":"2013-09-16T09:50:55Z","updated_at":"2014-07-04T08:45:27Z","pushed_at":"2014-08-14T11:25:57Z","git_url":"git://github.com/zsxwing/RxJava.git","ssh_url":"git@github.com:zsxwing/RxJava.git","clone_url":"https://github.com/zsxwing/RxJava.git","svn_url":"https://github.com/zsxwing/RxJava","homepage":"","size":15577,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"6c8ca2f0f55ec174837ac5a852e0049d08877d64","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=2","gravatar_id":"9452a86b2d066c6e6e35fe2ea83d16a5","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":7508411,"name":"RxJava","full_name":"Netflix/RxJava","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=2","gravatar_id":"9452a86b2d066c6e6e35fe2ea83d16a5","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/RxJava","description":"RxJava – Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":false,"url":"https://api.github.com/repos/Netflix/RxJava","forks_url":"https://api.github.com/repos/Netflix/RxJava/forks","keys_url":"https://api.github.com/repos/Netflix/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/RxJava/teams","hooks_url":"https://api.github.com/repos/Netflix/RxJava/hooks","issue_events_url":"https://api.github.com/repos/Netflix/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/RxJava/events","assignees_url":"https://api.github.com/repos/Netflix/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/RxJava/tags","blobs_url":"https://api.github.com/repos/Netflix/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/RxJava/languages","stargazers_url":"https://api.github.com/repos/Netflix/RxJava/stargazers","contributors_url":"https://api.github.com/repos/Netflix/RxJava/contributors","subscribers_url":"https://api.github.com/repos/Netflix/RxJava/subscribers","subscription_url":"https://api.github.com/repos/Netflix/RxJava/subscription","commits_url":"https://api.github.com/repos/Netflix/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/RxJava/issues/comments/{number}","contents_url":"https://api.github.com/repos/Netflix/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/RxJava/merges","archive_url":"https://api.github.com/repos/Netflix/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/RxJava/downloads","issues_url":"https://api.github.com/repos/Netflix/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/RxJava/releases{/id}","created_at":"2013-01-08T20:11:48Z","updated_at":"2014-08-14T16:49:44Z","pushed_at":"2014-08-14T16:52:14Z","git_url":"git://github.com/Netflix/RxJava.git","ssh_url":"git@github.com:Netflix/RxJava.git","clone_url":"https://github.com/Netflix/RxJava.git","svn_url":"https://github.com/Netflix/RxJava","homepage":"","size":592766,"stargazers_count":2910,"watchers_count":2910,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":467,"mirror_url":null,"open_issues_count":50,"forks":467,"open_issues":50,"watchers":2910,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/1577"},"html":{"href":"https://github.com/Netflix/RxJava/pull/1577"},"issue":{"href":"https://api.github.com/repos/Netflix/RxJava/issues/1577"},"comments":{"href":"https://api.github.com/repos/Netflix/RxJava/issues/1577/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/1577/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/1577/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/RxJava/statuses/a0c52f16b3dce06b73ea209f9c33b19c6164ac2d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"benjchristensen","id":813492,"avatar_url":"https://avatars.githubusercontent.com/u/813492?v=2","gravatar_id":"25a69d1e333ff36b77cf01b84b764182","url":"https://api.github.com/users/benjchristensen","html_url":"https://github.com/benjchristensen","followers_url":"https://api.github.com/users/benjchristensen/followers","following_url":"https://api.github.com/users/benjchristensen/following{/other_user}","gists_url":"https://api.github.com/users/benjchristensen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjchristensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjchristensen/subscriptions","organizations_url":"https://api.github.com/users/benjchristensen/orgs","repos_url":"https://api.github.com/users/benjchristensen/repos","events_url":"https://api.github.com/users/benjchristensen/events{/privacy}","received_events_url":"https://api.github.com/users/benjchristensen/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":2,"additions":7,"deletions":7,"changed_files":3}}