GitHub PullRequestReviewCommentEvent at 2014-12-19 00:16:55
Repository: etcd
Actor: xiang90
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/22082059","id":22082059,"diff_hunk":"@@ -36,7 +36,7 @@ func IsDirWriteable(dir string) error {\n \treturn os.Remove(f)\n }\n \n-// ReadDir returns the filenames in the given directory.\n+// ReadDir returns the filenames in the given directory, in arbitrary order.","path":"pkg/fileutil/fileutil.go","position":5,"original_position":5,"commit_id":"6910efea5fcf2c154a08556c8bcbf2b93c306760","original_commit_id":"6910efea5fcf2c154a08556c8bcbf2b93c306760","user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"body":"how about sorting the names in readDir?","created_at":"2014-12-19T00:16:55Z","updated_at":"2014-12-19T00:16:55Z","html_url":"https://github.com/coreos/etcd/pull/1965#discussion_r22082059","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/1965","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/22082059"},"html":{"href":"https://github.com/coreos/etcd/pull/1965#discussion_r22082059"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1965"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/1965","id":26342658,"html_url":"https://github.com/coreos/etcd/pull/1965","diff_url":"https://github.com/coreos/etcd/pull/1965.diff","patch_url":"https://github.com/coreos/etcd/pull/1965.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/1965","number":1965,"state":"open","locked":false,"title":"pkg/fileutil: sort files in tests","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":"Readdirnames makes no guarantees about ordering, so sort before testing the\nlisting. This test was failing consistently on Linux for me.\n\nAlso, simplify sort.Strings invocation in wal.\n\n\n/cc @barakmich @xiang90","created_at":"2014-12-19T00:13:06Z","updated_at":"2014-12-19T00:16:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4d3b7dc9e8698c58f9743e93d15ecc9c5047546","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/1965/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/1965/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/1965/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/6910efea5fcf2c154a08556c8bcbf2b93c306760","head":{"label":"jonboulle:fileutil","ref":"fileutil","sha":"6910efea5fcf2c154a08556c8bcbf2b93c306760","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"repo":{"id":16238846,"name":"etcd","full_name":"jonboulle/etcd","owner":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonboulle/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":true,"url":"https://api.github.com/repos/jonboulle/etcd","forks_url":"https://api.github.com/repos/jonboulle/etcd/forks","keys_url":"https://api.github.com/repos/jonboulle/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonboulle/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonboulle/etcd/teams","hooks_url":"https://api.github.com/repos/jonboulle/etcd/hooks","issue_events_url":"https://api.github.com/repos/jonboulle/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/jonboulle/etcd/events","assignees_url":"https://api.github.com/repos/jonboulle/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/jonboulle/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/jonboulle/etcd/tags","blobs_url":"https://api.github.com/repos/jonboulle/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonboulle/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonboulle/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonboulle/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonboulle/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/jonboulle/etcd/languages","stargazers_url":"https://api.github.com/repos/jonboulle/etcd/stargazers","contributors_url":"https://api.github.com/repos/jonboulle/etcd/contributors","subscribers_url":"https://api.github.com/repos/jonboulle/etcd/subscribers","subscription_url":"https://api.github.com/repos/jonboulle/etcd/subscription","commits_url":"https://api.github.com/repos/jonboulle/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonboulle/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonboulle/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonboulle/etcd/issues/comments/{number}","contents_url":"https://api.github.com/repos/jonboulle/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/jonboulle/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonboulle/etcd/merges","archive_url":"https://api.github.com/repos/jonboulle/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonboulle/etcd/downloads","issues_url":"https://api.github.com/repos/jonboulle/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/jonboulle/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/jonboulle/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/jonboulle/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonboulle/etcd/labels{/name}","releases_url":"https://api.github.com/repos/jonboulle/etcd/releases{/id}","created_at":"2014-01-25T20:07:46Z","updated_at":"2014-09-04T19:32:13Z","pushed_at":"2014-12-19T00:14:58Z","git_url":"git://github.com/jonboulle/etcd.git","ssh_url":"git@github.com:jonboulle/etcd.git","clone_url":"https://github.com/jonboulle/etcd.git","svn_url":"https://github.com/jonboulle/etcd","homepage":"","size":13435,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"1d859790e5bdb9c4161ae7342d811417f6b4f4ac","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments/{number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","created_at":"2013-07-06T21:57:21Z","updated_at":"2014-12-19T00:09:49Z","pushed_at":"2014-12-19T00:09:48Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"","size":23230,"stargazers_count":5016,"watchers_count":5016,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":539,"mirror_url":null,"open_issues_count":91,"forks":539,"open_issues":91,"watchers":5016,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1965"},"html":{"href":"https://github.com/coreos/etcd/pull/1965"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/1965"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/1965/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1965/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1965/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/6910efea5fcf2c154a08556c8bcbf2b93c306760"}}}}