GitHub PullRequestReviewCommentEvent at 2014-10-13 17:59:28
Repository: logstash
Actor: untergeek
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/elasticsearch/logstash/pulls/comments/18783985","id":18783985,"diff_hunk":"@@ -303,7 +304,7 @@ def receive(event)\n \n     index = event.sprintf(@index)\n \n-    document_id = @document_id ? event.sprintf(@document_id) : nil\n+    document_id = @document_id ? event.sprintf(@document_id) : event[\"_id\"]","path":"lib/logstash/outputs/elasticsearch.rb","position":18,"original_position":18,"commit_id":"effd7ab5191ac7d8237cbbb660dafe0541e91b91","original_commit_id":"effd7ab5191ac7d8237cbbb660dafe0541e91b91","user":{"login":"untergeek","id":1020383,"avatar_url":"https://avatars.githubusercontent.com/u/1020383?v=2","gravatar_id":"","url":"https://api.github.com/users/untergeek","html_url":"https://github.com/untergeek","followers_url":"https://api.github.com/users/untergeek/followers","following_url":"https://api.github.com/users/untergeek/following{/other_user}","gists_url":"https://api.github.com/users/untergeek/gists{/gist_id}","starred_url":"https://api.github.com/users/untergeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untergeek/subscriptions","organizations_url":"https://api.github.com/users/untergeek/orgs","repos_url":"https://api.github.com/users/untergeek/repos","events_url":"https://api.github.com/users/untergeek/events{/privacy}","received_events_url":"https://api.github.com/users/untergeek/received_events","type":"User","site_admin":false},"body":"I don't understand.  Why do you need nil?  Why not test for `\"\"`?","created_at":"2014-10-13T17:59:28Z","updated_at":"2014-10-13T17:59:28Z","html_url":"https://github.com/elasticsearch/logstash/pull/1783#discussion_r18783985","pull_request_url":"https://api.github.com/repos/elasticsearch/logstash/pulls/1783","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/comments/18783985"},"html":{"href":"https://github.com/elasticsearch/logstash/pull/1783#discussion_r18783985"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/1783"}}},"pull_request":{"url":"https://api.github.com/repos/elasticsearch/logstash/pulls/1783","id":21765219,"html_url":"https://github.com/elasticsearch/logstash/pull/1783","diff_url":"https://github.com/elasticsearch/logstash/pull/1783.diff","patch_url":"https://github.com/elasticsearch/logstash/pull/1783.patch","issue_url":"https://api.github.com/repos/elasticsearch/logstash/issues/1783","number":1783,"state":"open","locked":false,"title":"elasticsearch_http: Use source._id automatically","user":{"login":"zde","id":644743,"avatar_url":"https://avatars.githubusercontent.com/u/644743?v=2","gravatar_id":"","url":"https://api.github.com/users/zde","html_url":"https://github.com/zde","followers_url":"https://api.github.com/users/zde/followers","following_url":"https://api.github.com/users/zde/following{/other_user}","gists_url":"https://api.github.com/users/zde/gists{/gist_id}","starred_url":"https://api.github.com/users/zde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zde/subscriptions","organizations_url":"https://api.github.com/users/zde/orgs","repos_url":"https://api.github.com/users/zde/repos","events_url":"https://api.github.com/users/zde/events{/privacy}","received_events_url":"https://api.github.com/users/zde/received_events","type":"User","site_admin":false},"body":"This is an alternative to using document_id option.  Better suited to diverse deployments when some sources provide unique id and others don't.","created_at":"2014-09-25T07:24:40Z","updated_at":"2014-10-13T17:59:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43abad04c3a986618baf92dc9982cea490a5a112","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elasticsearch/logstash/pulls/1783/commits","review_comments_url":"https://api.github.com/repos/elasticsearch/logstash/pulls/1783/comments","review_comment_url":"https://api.github.com/repos/elasticsearch/logstash/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elasticsearch/logstash/issues/1783/comments","statuses_url":"https://api.github.com/repos/elasticsearch/logstash/statuses/effd7ab5191ac7d8237cbbb660dafe0541e91b91","head":{"label":"zde:master","ref":"master","sha":"effd7ab5191ac7d8237cbbb660dafe0541e91b91","user":{"login":"zde","id":644743,"avatar_url":"https://avatars.githubusercontent.com/u/644743?v=2","gravatar_id":"","url":"https://api.github.com/users/zde","html_url":"https://github.com/zde","followers_url":"https://api.github.com/users/zde/followers","following_url":"https://api.github.com/users/zde/following{/other_user}","gists_url":"https://api.github.com/users/zde/gists{/gist_id}","starred_url":"https://api.github.com/users/zde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zde/subscriptions","organizations_url":"https://api.github.com/users/zde/orgs","repos_url":"https://api.github.com/users/zde/repos","events_url":"https://api.github.com/users/zde/events{/privacy}","received_events_url":"https://api.github.com/users/zde/received_events","type":"User","site_admin":false},"repo":{"id":24382705,"name":"logstash","full_name":"zde/logstash","owner":{"login":"zde","id":644743,"avatar_url":"https://avatars.githubusercontent.com/u/644743?v=2","gravatar_id":"","url":"https://api.github.com/users/zde","html_url":"https://github.com/zde","followers_url":"https://api.github.com/users/zde/followers","following_url":"https://api.github.com/users/zde/following{/other_user}","gists_url":"https://api.github.com/users/zde/gists{/gist_id}","starred_url":"https://api.github.com/users/zde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zde/subscriptions","organizations_url":"https://api.github.com/users/zde/orgs","repos_url":"https://api.github.com/users/zde/repos","events_url":"https://api.github.com/users/zde/events{/privacy}","received_events_url":"https://api.github.com/users/zde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zde/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":true,"url":"https://api.github.com/repos/zde/logstash","forks_url":"https://api.github.com/repos/zde/logstash/forks","keys_url":"https://api.github.com/repos/zde/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zde/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zde/logstash/teams","hooks_url":"https://api.github.com/repos/zde/logstash/hooks","issue_events_url":"https://api.github.com/repos/zde/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/zde/logstash/events","assignees_url":"https://api.github.com/repos/zde/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/zde/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/zde/logstash/tags","blobs_url":"https://api.github.com/repos/zde/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zde/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zde/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/zde/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zde/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/zde/logstash/languages","stargazers_url":"https://api.github.com/repos/zde/logstash/stargazers","contributors_url":"https://api.github.com/repos/zde/logstash/contributors","subscribers_url":"https://api.github.com/repos/zde/logstash/subscribers","subscription_url":"https://api.github.com/repos/zde/logstash/subscription","commits_url":"https://api.github.com/repos/zde/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/zde/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/zde/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/zde/logstash/issues/comments/{number}","contents_url":"https://api.github.com/repos/zde/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/zde/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zde/logstash/merges","archive_url":"https://api.github.com/repos/zde/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zde/logstash/downloads","issues_url":"https://api.github.com/repos/zde/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/zde/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/zde/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/zde/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zde/logstash/labels{/name}","releases_url":"https://api.github.com/repos/zde/logstash/releases{/id}","created_at":"2014-09-23T17:48:34Z","updated_at":"2014-09-23T18:25:31Z","pushed_at":"2014-09-26T13:32:57Z","git_url":"git://github.com/zde/logstash.git","ssh_url":"git@github.com:zde/logstash.git","clone_url":"https://github.com/zde/logstash.git","svn_url":"https://github.com/zde/logstash","homepage":"http://logstash.net/","size":70006,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elasticsearch:master","ref":"master","sha":"a536eefad2251f690cab0ba545cedf4d16a21365","user":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=2","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elasticsearch/logstash","owner":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?v=2","gravatar_id":"","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticsearch/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":false,"url":"https://api.github.com/repos/elasticsearch/logstash","forks_url":"https://api.github.com/repos/elasticsearch/logstash/forks","keys_url":"https://api.github.com/repos/elasticsearch/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticsearch/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticsearch/logstash/teams","hooks_url":"https://api.github.com/repos/elasticsearch/logstash/hooks","issue_events_url":"https://api.github.com/repos/elasticsearch/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elasticsearch/logstash/events","assignees_url":"https://api.github.com/repos/elasticsearch/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elasticsearch/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elasticsearch/logstash/tags","blobs_url":"https://api.github.com/repos/elasticsearch/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticsearch/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticsearch/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticsearch/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticsearch/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticsearch/logstash/languages","stargazers_url":"https://api.github.com/repos/elasticsearch/logstash/stargazers","contributors_url":"https://api.github.com/repos/elasticsearch/logstash/contributors","subscribers_url":"https://api.github.com/repos/elasticsearch/logstash/subscribers","subscription_url":"https://api.github.com/repos/elasticsearch/logstash/subscription","commits_url":"https://api.github.com/repos/elasticsearch/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticsearch/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticsearch/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticsearch/logstash/issues/comments/{number}","contents_url":"https://api.github.com/repos/elasticsearch/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elasticsearch/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticsearch/logstash/merges","archive_url":"https://api.github.com/repos/elasticsearch/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticsearch/logstash/downloads","issues_url":"https://api.github.com/repos/elasticsearch/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elasticsearch/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticsearch/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticsearch/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticsearch/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elasticsearch/logstash/releases{/id}","created_at":"2010-11-18T01:31:50Z","updated_at":"2014-10-13T09:44:18Z","pushed_at":"2014-10-10T21:35:03Z","git_url":"git://github.com/elasticsearch/logstash.git","ssh_url":"git@github.com:elasticsearch/logstash.git","clone_url":"https://github.com/elasticsearch/logstash.git","svn_url":"https://github.com/elasticsearch/logstash","homepage":"http://logstash.net/","size":93379,"stargazers_count":3090,"watchers_count":3090,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1195,"mirror_url":null,"open_issues_count":495,"forks":1195,"open_issues":495,"watchers":3090,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/1783"},"html":{"href":"https://github.com/elasticsearch/logstash/pull/1783"},"issue":{"href":"https://api.github.com/repos/elasticsearch/logstash/issues/1783"},"comments":{"href":"https://api.github.com/repos/elasticsearch/logstash/issues/1783/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/1783/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elasticsearch/logstash/pulls/1783/commits"},"statuses":{"href":"https://api.github.com/repos/elasticsearch/logstash/statuses/effd7ab5191ac7d8237cbbb660dafe0541e91b91"}}}}