GitHub PullRequestReviewCommentEvent at 2014-09-27 16:57:54
Repository: matplotlib
Actor: mdboom
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/18124615","id":18124615,"diff_hunk":"@@ -140,6 +141,18 @@ def test_Bug_2543_newer_python():\n         with mpl.rc_context():\n             mpl.rcParams['svg.fonttype'] = True\n \n+def test_Issue_1713():\n+    utf32_be = os.path.join(os.path.dirname(__file__),\n+                           'test_utf32_be_rcparams.rc')\n+    old_lang = os.environ.get('LANG', None)\n+    os.environ['LANG'] = 'en_US.UTF-32-BE'","path":"lib/matplotlib/tests/test_rcparams.py","position":16,"original_position":16,"commit_id":"4374d8eb7b154904ace48b3ba713dbefe567861b","original_commit_id":"4374d8eb7b154904ace48b3ba713dbefe567861b","user":{"login":"mdboom","id":38294,"avatar_url":"https://avatars.githubusercontent.com/u/38294?v=2","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"body":"Will this test fail if the OS doesn't have the `en_US.UTF-32-BE` locale installed?","created_at":"2014-09-27T16:57:54Z","updated_at":"2014-09-27T16:57:54Z","html_url":"https://github.com/matplotlib/matplotlib/pull/3575#discussion_r18124615","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/3575","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/18124615"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/3575#discussion_r18124615"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/3575"}}},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/3575","id":21891007,"html_url":"https://github.com/matplotlib/matplotlib/pull/3575","diff_url":"https://github.com/matplotlib/matplotlib/pull/3575.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/3575.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/3575","number":3575,"state":"open","locked":false,"title":"Supports locale-specified encoding for rcfile.","user":{"login":"frutiger","id":2180969,"avatar_url":"https://avatars.githubusercontent.com/u/2180969?v=2","gravatar_id":"","url":"https://api.github.com/users/frutiger","html_url":"https://github.com/frutiger","followers_url":"https://api.github.com/users/frutiger/followers","following_url":"https://api.github.com/users/frutiger/following{/other_user}","gists_url":"https://api.github.com/users/frutiger/gists{/gist_id}","starred_url":"https://api.github.com/users/frutiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frutiger/subscriptions","organizations_url":"https://api.github.com/users/frutiger/orgs","repos_url":"https://api.github.com/users/frutiger/repos","events_url":"https://api.github.com/users/frutiger/events{/privacy}","received_events_url":"https://api.github.com/users/frutiger/received_events","type":"User","site_admin":false},"body":"This commit fixes issue #1317.  The locale for the encoding is obtained from\r\nthe Python `locale` module, which can be specified by the `LANG` environment\r\nvariable.\r\n\r\nThis was tested by adding a test rc file encoded in UTF-32-BE, and testing that\r\nit decoded correctly.","created_at":"2014-09-27T16:16:05Z","updated_at":"2014-09-27T16:57:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72311728516cf3ae49bd13c035029e396879536b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/3575/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/3575/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/3575/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/4374d8eb7b154904ace48b3ba713dbefe567861b","head":{"label":"frutiger:locale_encoded_rcfile","ref":"locale_encoded_rcfile","sha":"4374d8eb7b154904ace48b3ba713dbefe567861b","user":{"login":"frutiger","id":2180969,"avatar_url":"https://avatars.githubusercontent.com/u/2180969?v=2","gravatar_id":"","url":"https://api.github.com/users/frutiger","html_url":"https://github.com/frutiger","followers_url":"https://api.github.com/users/frutiger/followers","following_url":"https://api.github.com/users/frutiger/following{/other_user}","gists_url":"https://api.github.com/users/frutiger/gists{/gist_id}","starred_url":"https://api.github.com/users/frutiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frutiger/subscriptions","organizations_url":"https://api.github.com/users/frutiger/orgs","repos_url":"https://api.github.com/users/frutiger/repos","events_url":"https://api.github.com/users/frutiger/events{/privacy}","received_events_url":"https://api.github.com/users/frutiger/received_events","type":"User","site_admin":false},"repo":{"id":24536252,"name":"matplotlib","full_name":"frutiger/matplotlib","owner":{"login":"frutiger","id":2180969,"avatar_url":"https://avatars.githubusercontent.com/u/2180969?v=2","gravatar_id":"","url":"https://api.github.com/users/frutiger","html_url":"https://github.com/frutiger","followers_url":"https://api.github.com/users/frutiger/followers","following_url":"https://api.github.com/users/frutiger/following{/other_user}","gists_url":"https://api.github.com/users/frutiger/gists{/gist_id}","starred_url":"https://api.github.com/users/frutiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frutiger/subscriptions","organizations_url":"https://api.github.com/users/frutiger/orgs","repos_url":"https://api.github.com/users/frutiger/repos","events_url":"https://api.github.com/users/frutiger/events{/privacy}","received_events_url":"https://api.github.com/users/frutiger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frutiger/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/frutiger/matplotlib","forks_url":"https://api.github.com/repos/frutiger/matplotlib/forks","keys_url":"https://api.github.com/repos/frutiger/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frutiger/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frutiger/matplotlib/teams","hooks_url":"https://api.github.com/repos/frutiger/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/frutiger/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/frutiger/matplotlib/events","assignees_url":"https://api.github.com/repos/frutiger/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/frutiger/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/frutiger/matplotlib/tags","blobs_url":"https://api.github.com/repos/frutiger/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frutiger/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frutiger/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/frutiger/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frutiger/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/frutiger/matplotlib/languages","stargazers_url":"https://api.github.com/repos/frutiger/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/frutiger/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/frutiger/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/frutiger/matplotlib/subscription","commits_url":"https://api.github.com/repos/frutiger/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/frutiger/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/frutiger/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/frutiger/matplotlib/issues/comments/{number}","contents_url":"https://api.github.com/repos/frutiger/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/frutiger/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frutiger/matplotlib/merges","archive_url":"https://api.github.com/repos/frutiger/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frutiger/matplotlib/downloads","issues_url":"https://api.github.com/repos/frutiger/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/frutiger/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/frutiger/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/frutiger/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frutiger/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/frutiger/matplotlib/releases{/id}","created_at":"2014-09-27T16:05:42Z","updated_at":"2014-09-27T13:55:08Z","pushed_at":"2014-09-27T16:10:19Z","git_url":"git://github.com/frutiger/matplotlib.git","ssh_url":"git@github.com:frutiger/matplotlib.git","clone_url":"https://github.com/frutiger/matplotlib.git","svn_url":"https://github.com/frutiger/matplotlib","homepage":"http://matplotlib.org/","size":249763,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"a348d7d9b555ff792002ce0b276fad78b9db5fd1","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=2","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=2","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments/{number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","created_at":"2011-02-19T03:17:12Z","updated_at":"2014-09-27T13:55:08Z","pushed_at":"2014-09-27T16:50:55Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":249763,"stargazers_count":2021,"watchers_count":2021,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":907,"mirror_url":null,"open_issues_count":406,"forks":907,"open_issues":406,"watchers":2021,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/3575"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/3575"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/3575"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/3575/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/3575/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/3575/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/4374d8eb7b154904ace48b3ba713dbefe567861b"}}}}