GitHub PullRequestReviewCommentEvent at 2014-08-07 16:34:38
Repository: wildfly-core
Actor: ctomc
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/15946929","id":15946929,"diff_hunk":"@@ -47,7 +47,11 @@\n         <module name=\"org.jboss.logging\"/>\n         <module name=\"org.jboss.modules\"/>\n         <module name=\"org.jboss.sasl\"/>\n-        <module name=\"org.jboss.xnio\"/>        \n+        <module name=\"org.jboss.xnio\"/>   \n+        <module name=\"org.keycloak.keycloak-core\" optional=\"true\"/>","path":"core-build/src/main/resources/modules/system/layers/base/org/jboss/as/domain-http-interface/main/module.xml","position":6,"original_position":6,"commit_id":"04015a5cefa24e05313b19932a03fc68c27b947f","original_commit_id":"04015a5cefa24e05313b19932a03fc68c27b947f","user":{"login":"ctomc","id":824084,"avatar_url":"https://avatars.githubusercontent.com/u/824084?v=2","gravatar_id":"530c34add6b714edb43eaf8f1240caec","url":"https://api.github.com/users/ctomc","html_url":"https://github.com/ctomc","followers_url":"https://api.github.com/users/ctomc/followers","following_url":"https://api.github.com/users/ctomc/following{/other_user}","gists_url":"https://api.github.com/users/ctomc/gists{/gist_id}","starred_url":"https://api.github.com/users/ctomc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctomc/subscriptions","organizations_url":"https://api.github.com/users/ctomc/orgs","repos_url":"https://api.github.com/users/ctomc/repos","events_url":"https://api.github.com/users/ctomc/events{/privacy}","received_events_url":"https://api.github.com/users/ctomc/received_events","type":"User","site_admin":false},"body":"what if you specify one keycloak module that exports all needed deps.\r\nthis way deps could be controlled in single place and all modules that need dependency to keycloak will have dep to only one module.","created_at":"2014-08-07T16:34:38Z","updated_at":"2014-08-07T16:34:38Z","html_url":"https://github.com/wildfly/wildfly-core/pull/84#discussion_r15946929","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/15946929"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/84#discussion_r15946929"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/84","id":19477041,"html_url":"https://github.com/wildfly/wildfly-core/pull/84","diff_url":"https://github.com/wildfly/wildfly-core/pull/84.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/84.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/84","number":84,"state":"open","title":"[WFLY-3591] Add keycloak auth to http management endpoint","user":{"login":"ssilvert","id":507202,"avatar_url":"https://avatars.githubusercontent.com/u/507202?v=2","gravatar_id":"c3338d55d858d45400ef0e537dac277c","url":"https://api.github.com/users/ssilvert","html_url":"https://github.com/ssilvert","followers_url":"https://api.github.com/users/ssilvert/followers","following_url":"https://api.github.com/users/ssilvert/following{/other_user}","gists_url":"https://api.github.com/users/ssilvert/gists{/gist_id}","starred_url":"https://api.github.com/users/ssilvert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssilvert/subscriptions","organizations_url":"https://api.github.com/users/ssilvert/orgs","repos_url":"https://api.github.com/users/ssilvert/repos","events_url":"https://api.github.com/users/ssilvert/events{/privacy}","received_events_url":"https://api.github.com/users/ssilvert/received_events","type":"User","site_admin":false},"body":"This PR adds the ability to specify &lt;keycloak/&gt; as the authentication provider for the ManagementRealm in domain-http.  It does not actually pull any Keycloak artifacts into the target build.  On its own, this PR doesn't add any functionality in wildfly-core.  However, this is needed so that Keycloak can be added to wildfly full.","created_at":"2014-08-07T16:11:52Z","updated_at":"2014-08-07T16:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56a57c0e9919d833a31a4bd3f1bb22781bff22ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/84/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/84/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/84/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/04015a5cefa24e05313b19932a03fc68c27b947f","head":{"label":"ssilvert:keycloak","ref":"keycloak","sha":"04015a5cefa24e05313b19932a03fc68c27b947f","user":{"login":"ssilvert","id":507202,"avatar_url":"https://avatars.githubusercontent.com/u/507202?v=2","gravatar_id":"c3338d55d858d45400ef0e537dac277c","url":"https://api.github.com/users/ssilvert","html_url":"https://github.com/ssilvert","followers_url":"https://api.github.com/users/ssilvert/followers","following_url":"https://api.github.com/users/ssilvert/following{/other_user}","gists_url":"https://api.github.com/users/ssilvert/gists{/gist_id}","starred_url":"https://api.github.com/users/ssilvert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssilvert/subscriptions","organizations_url":"https://api.github.com/users/ssilvert/orgs","repos_url":"https://api.github.com/users/ssilvert/repos","events_url":"https://api.github.com/users/ssilvert/events{/privacy}","received_events_url":"https://api.github.com/users/ssilvert/received_events","type":"User","site_admin":false},"repo":{"id":21954917,"name":"wildfly-core","full_name":"ssilvert/wildfly-core","owner":{"login":"ssilvert","id":507202,"avatar_url":"https://avatars.githubusercontent.com/u/507202?v=2","gravatar_id":"c3338d55d858d45400ef0e537dac277c","url":"https://api.github.com/users/ssilvert","html_url":"https://github.com/ssilvert","followers_url":"https://api.github.com/users/ssilvert/followers","following_url":"https://api.github.com/users/ssilvert/following{/other_user}","gists_url":"https://api.github.com/users/ssilvert/gists{/gist_id}","starred_url":"https://api.github.com/users/ssilvert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssilvert/subscriptions","organizations_url":"https://api.github.com/users/ssilvert/orgs","repos_url":"https://api.github.com/users/ssilvert/repos","events_url":"https://api.github.com/users/ssilvert/events{/privacy}","received_events_url":"https://api.github.com/users/ssilvert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ssilvert/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/ssilvert/wildfly-core","forks_url":"https://api.github.com/repos/ssilvert/wildfly-core/forks","keys_url":"https://api.github.com/repos/ssilvert/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssilvert/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssilvert/wildfly-core/teams","hooks_url":"https://api.github.com/repos/ssilvert/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/ssilvert/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/ssilvert/wildfly-core/events","assignees_url":"https://api.github.com/repos/ssilvert/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/ssilvert/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/ssilvert/wildfly-core/tags","blobs_url":"https://api.github.com/repos/ssilvert/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssilvert/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssilvert/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssilvert/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssilvert/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ssilvert/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/ssilvert/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/ssilvert/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/ssilvert/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/ssilvert/wildfly-core/subscription","commits_url":"https://api.github.com/repos/ssilvert/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssilvert/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssilvert/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssilvert/wildfly-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/ssilvert/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/ssilvert/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssilvert/wildfly-core/merges","archive_url":"https://api.github.com/repos/ssilvert/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssilvert/wildfly-core/downloads","issues_url":"https://api.github.com/repos/ssilvert/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/ssilvert/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ssilvert/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ssilvert/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssilvert/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/ssilvert/wildfly-core/releases{/id}","created_at":"2014-07-17T19:35:13Z","updated_at":"2014-07-03T01:32:09Z","pushed_at":"2014-08-07T13:48:06Z","git_url":"git://github.com/ssilvert/wildfly-core.git","ssh_url":"git@github.com:ssilvert/wildfly-core.git","clone_url":"https://github.com/ssilvert/wildfly-core.git","svn_url":"https://github.com/ssilvert/wildfly-core","homepage":null,"size":32541,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"3f0af7032f16231c926ac7b0f15e104d8363f00b","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=2","gravatar_id":null,"url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=2","gravatar_id":null,"url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","created_at":"2014-07-01T16:33:34Z","updated_at":"2014-07-29T21:14:49Z","pushed_at":"2014-08-07T02:18:06Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":34566,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":40,"mirror_url":null,"open_issues_count":18,"forks":40,"open_issues":18,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/84"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/84"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/84"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/04015a5cefa24e05313b19932a03fc68c27b947f"}}}}