GitHub PullRequestReviewCommentEvent at 2014-06-06 13:58:02
Repository: open-data-certificate
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/theodi/open-data-certificate/pulls/comments/13490555","id":13490555,"diff_hunk":"@@ -111,28 +111,36 @@ def mandatory_questions\n   def valid?(context = nil)\n     super(context)\n     unless errors.empty?\n-\n       sections.each do |section|\n-        unless section.errors.empty?\n-          puts \"section '#{section.title}' errors: #{section.errors.full_messages}\"\n-\n-          questions.each do |question|\n-            unless question.errors.empty?\n-              puts \"question '#{question.text}' errors: #{question.errors.full_messages}\"\n-\n-              question.answers.each do |answer|\n-                puts \"answer '#{answer.text}' errors: #{answer.errors.full_messages}\" unless answer.errors.empty?\n-              end\n+        validate_sections\n+      end\n+    end\n \n-            end\n-          end\n+    return errors.empty?\n+  end\n \n-        end\n+  def validate_sections\n+    sections.each do |section|\n+      unless section.errors.empty?\n+        puts \"section '#{section.title}' errors: #{section.errors.full_messages}\"","path":"app/models/survey.rb","position":29,"original_position":29,"commit_id":"87e027320ff72549fc24e7c29a71fa725265dccb","original_commit_id":"87e027320ff72549fc24e7c29a71fa725265dccb","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [81/80]<br>Do not write to stdout. Use Rails' logger if you want to log.","created_at":"2014-06-06T13:58:02Z","updated_at":"2014-06-06T13:58:02Z","html_url":"https://github.com/theodi/open-data-certificate/pull/788#discussion_r13490555","pull_request_url":"https://api.github.com/repos/theodi/open-data-certificate/pulls/788","_links":{"self":{"href":"https://api.github.com/repos/theodi/open-data-certificate/pulls/comments/13490555"},"html":{"href":"https://github.com/theodi/open-data-certificate/pull/788#discussion_r13490555"},"pull_request":{"href":"https://api.github.com/repos/theodi/open-data-certificate/pulls/788"}}},"pull_request":{"url":"https://api.github.com/repos/theodi/open-data-certificate/pulls/788","id":16645643,"html_url":"https://github.com/theodi/open-data-certificate/pull/788","diff_url":"https://github.com/theodi/open-data-certificate/pull/788.diff","patch_url":"https://github.com/theodi/open-data-certificate/pull/788.patch","issue_url":"https://api.github.com/repos/theodi/open-data-certificate/issues/788","number":788,"state":"open","title":"Improve Code Climate score","user":{"login":"pezholio","id":109774,"avatar_url":"https://avatars.githubusercontent.com/u/109774?","gravatar_id":"75830be2998f0ae905c0b5daf4e1214b","url":"https://api.github.com/users/pezholio","html_url":"https://github.com/pezholio","followers_url":"https://api.github.com/users/pezholio/followers","following_url":"https://api.github.com/users/pezholio/following{/other_user}","gists_url":"https://api.github.com/users/pezholio/gists{/gist_id}","starred_url":"https://api.github.com/users/pezholio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pezholio/subscriptions","organizations_url":"https://api.github.com/users/pezholio/orgs","repos_url":"https://api.github.com/users/pezholio/repos","events_url":"https://api.github.com/users/pezholio/events{/privacy}","received_events_url":"https://api.github.com/users/pezholio/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-03T10:40:28Z","updated_at":"2014-06-06T13:58:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4be1124fa522167e81b2a4ed73b8f35488d170c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theodi/open-data-certificate/pulls/788/commits","review_comments_url":"https://api.github.com/repos/theodi/open-data-certificate/pulls/788/comments","review_comment_url":"https://api.github.com/repos/theodi/open-data-certificate/pulls/comments/{number}","comments_url":"https://api.github.com/repos/theodi/open-data-certificate/issues/788/comments","statuses_url":"https://api.github.com/repos/theodi/open-data-certificate/statuses/87e027320ff72549fc24e7c29a71fa725265dccb","head":{"label":"theodi:feature-improve-code-climate","ref":"feature-improve-code-climate","sha":"87e027320ff72549fc24e7c29a71fa725265dccb","user":{"login":"theodi","id":2492770,"avatar_url":"https://avatars.githubusercontent.com/u/2492770?","gravatar_id":"07ab537732bae0cb3167a3bd8f42f885","url":"https://api.github.com/users/theodi","html_url":"https://github.com/theodi","followers_url":"https://api.github.com/users/theodi/followers","following_url":"https://api.github.com/users/theodi/following{/other_user}","gists_url":"https://api.github.com/users/theodi/gists{/gist_id}","starred_url":"https://api.github.com/users/theodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theodi/subscriptions","organizations_url":"https://api.github.com/users/theodi/orgs","repos_url":"https://api.github.com/users/theodi/repos","events_url":"https://api.github.com/users/theodi/events{/privacy}","received_events_url":"https://api.github.com/users/theodi/received_events","type":"Organization","site_admin":false},"repo":{"id":8458155,"name":"open-data-certificate","full_name":"theodi/open-data-certificate","owner":{"login":"theodi","id":2492770,"avatar_url":"https://avatars.githubusercontent.com/u/2492770?","gravatar_id":"07ab537732bae0cb3167a3bd8f42f885","url":"https://api.github.com/users/theodi","html_url":"https://github.com/theodi","followers_url":"https://api.github.com/users/theodi/followers","following_url":"https://api.github.com/users/theodi/following{/other_user}","gists_url":"https://api.github.com/users/theodi/gists{/gist_id}","starred_url":"https://api.github.com/users/theodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theodi/subscriptions","organizations_url":"https://api.github.com/users/theodi/orgs","repos_url":"https://api.github.com/users/theodi/repos","events_url":"https://api.github.com/users/theodi/events{/privacy}","received_events_url":"https://api.github.com/users/theodi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theodi/open-data-certificate","description":"The ODI's Open Data Certificate","fork":false,"url":"https://api.github.com/repos/theodi/open-data-certificate","forks_url":"https://api.github.com/repos/theodi/open-data-certificate/forks","keys_url":"https://api.github.com/repos/theodi/open-data-certificate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theodi/open-data-certificate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theodi/open-data-certificate/teams","hooks_url":"https://api.github.com/repos/theodi/open-data-certificate/hooks","issue_events_url":"https://api.github.com/repos/theodi/open-data-certificate/issues/events{/number}","events_url":"https://api.github.com/repos/theodi/open-data-certificate/events","assignees_url":"https://api.github.com/repos/theodi/open-data-certificate/assignees{/user}","branches_url":"https://api.github.com/repos/theodi/open-data-certificate/branches{/branch}","tags_url":"https://api.github.com/repos/theodi/open-data-certificate/tags","blobs_url":"https://api.github.com/repos/theodi/open-data-certificate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theodi/open-data-certificate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theodi/open-data-certificate/git/refs{/sha}","trees_url":"https://api.github.com/repos/theodi/open-data-certificate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theodi/open-data-certificate/statuses/{sha}","languages_url":"https://api.github.com/repos/theodi/open-data-certificate/languages","stargazers_url":"https://api.github.com/repos/theodi/open-data-certificate/stargazers","contributors_url":"https://api.github.com/repos/theodi/open-data-certificate/contributors","subscribers_url":"https://api.github.com/repos/theodi/open-data-certificate/subscribers","subscription_url":"https://api.github.com/repos/theodi/open-data-certificate/subscription","commits_url":"https://api.github.com/repos/theodi/open-data-certificate/commits{/sha}","git_commits_url":"https://api.github.com/repos/theodi/open-data-certificate/git/commits{/sha}","comments_url":"https://api.github.com/repos/theodi/open-data-certificate/comments{/number}","issue_comment_url":"https://api.github.com/repos/theodi/open-data-certificate/issues/comments/{number}","contents_url":"https://api.github.com/repos/theodi/open-data-certificate/contents/{+path}","compare_url":"https://api.github.com/repos/theodi/open-data-certificate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theodi/open-data-certificate/merges","archive_url":"https://api.github.com/repos/theodi/open-data-certificate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theodi/open-data-certificate/downloads","issues_url":"https://api.github.com/repos/theodi/open-data-certificate/issues{/number}","pulls_url":"https://api.github.com/repos/theodi/open-data-certificate/pulls{/number}","milestones_url":"https://api.github.com/repos/theodi/open-data-certificate/milestones{/number}","notifications_url":"https://api.github.com/repos/theodi/open-data-certificate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theodi/open-data-certificate/labels{/name}","releases_url":"https://api.github.com/repos/theodi/open-data-certificate/releases{/id}","created_at":"2013-02-27T14:49:12Z","updated_at":"2014-06-06T13:57:41Z","pushed_at":"2014-06-06T13:57:40Z","git_url":"git://github.com/theodi/open-data-certificate.git","ssh_url":"git@github.com:theodi/open-data-certificate.git","clone_url":"https://github.com/theodi/open-data-certificate.git","svn_url":"https://github.com/theodi/open-data-certificate","homepage":"https://certificates.theodi.org/","size":17390,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":22,"mirror_url":null,"open_issues_count":97,"forks":22,"open_issues":97,"watchers":21,"default_branch":"master"}},"base":{"label":"theodi:master","ref":"master","sha":"1cb2260865d54d5c9956ed5adee0d2a40b99c1c6","user":{"login":"theodi","id":2492770,"avatar_url":"https://avatars.githubusercontent.com/u/2492770?","gravatar_id":"07ab537732bae0cb3167a3bd8f42f885","url":"https://api.github.com/users/theodi","html_url":"https://github.com/theodi","followers_url":"https://api.github.com/users/theodi/followers","following_url":"https://api.github.com/users/theodi/following{/other_user}","gists_url":"https://api.github.com/users/theodi/gists{/gist_id}","starred_url":"https://api.github.com/users/theodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theodi/subscriptions","organizations_url":"https://api.github.com/users/theodi/orgs","repos_url":"https://api.github.com/users/theodi/repos","events_url":"https://api.github.com/users/theodi/events{/privacy}","received_events_url":"https://api.github.com/users/theodi/received_events","type":"Organization","site_admin":false},"repo":{"id":8458155,"name":"open-data-certificate","full_name":"theodi/open-data-certificate","owner":{"login":"theodi","id":2492770,"avatar_url":"https://avatars.githubusercontent.com/u/2492770?","gravatar_id":"07ab537732bae0cb3167a3bd8f42f885","url":"https://api.github.com/users/theodi","html_url":"https://github.com/theodi","followers_url":"https://api.github.com/users/theodi/followers","following_url":"https://api.github.com/users/theodi/following{/other_user}","gists_url":"https://api.github.com/users/theodi/gists{/gist_id}","starred_url":"https://api.github.com/users/theodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theodi/subscriptions","organizations_url":"https://api.github.com/users/theodi/orgs","repos_url":"https://api.github.com/users/theodi/repos","events_url":"https://api.github.com/users/theodi/events{/privacy}","received_events_url":"https://api.github.com/users/theodi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theodi/open-data-certificate","description":"The ODI's Open Data Certificate","fork":false,"url":"https://api.github.com/repos/theodi/open-data-certificate","forks_url":"https://api.github.com/repos/theodi/open-data-certificate/forks","keys_url":"https://api.github.com/repos/theodi/open-data-certificate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theodi/open-data-certificate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theodi/open-data-certificate/teams","hooks_url":"https://api.github.com/repos/theodi/open-data-certificate/hooks","issue_events_url":"https://api.github.com/repos/theodi/open-data-certificate/issues/events{/number}","events_url":"https://api.github.com/repos/theodi/open-data-certificate/events","assignees_url":"https://api.github.com/repos/theodi/open-data-certificate/assignees{/user}","branches_url":"https://api.github.com/repos/theodi/open-data-certificate/branches{/branch}","tags_url":"https://api.github.com/repos/theodi/open-data-certificate/tags","blobs_url":"https://api.github.com/repos/theodi/open-data-certificate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theodi/open-data-certificate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theodi/open-data-certificate/git/refs{/sha}","trees_url":"https://api.github.com/repos/theodi/open-data-certificate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theodi/open-data-certificate/statuses/{sha}","languages_url":"https://api.github.com/repos/theodi/open-data-certificate/languages","stargazers_url":"https://api.github.com/repos/theodi/open-data-certificate/stargazers","contributors_url":"https://api.github.com/repos/theodi/open-data-certificate/contributors","subscribers_url":"https://api.github.com/repos/theodi/open-data-certificate/subscribers","subscription_url":"https://api.github.com/repos/theodi/open-data-certificate/subscription","commits_url":"https://api.github.com/repos/theodi/open-data-certificate/commits{/sha}","git_commits_url":"https://api.github.com/repos/theodi/open-data-certificate/git/commits{/sha}","comments_url":"https://api.github.com/repos/theodi/open-data-certificate/comments{/number}","issue_comment_url":"https://api.github.com/repos/theodi/open-data-certificate/issues/comments/{number}","contents_url":"https://api.github.com/repos/theodi/open-data-certificate/contents/{+path}","compare_url":"https://api.github.com/repos/theodi/open-data-certificate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theodi/open-data-certificate/merges","archive_url":"https://api.github.com/repos/theodi/open-data-certificate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theodi/open-data-certificate/downloads","issues_url":"https://api.github.com/repos/theodi/open-data-certificate/issues{/number}","pulls_url":"https://api.github.com/repos/theodi/open-data-certificate/pulls{/number}","milestones_url":"https://api.github.com/repos/theodi/open-data-certificate/milestones{/number}","notifications_url":"https://api.github.com/repos/theodi/open-data-certificate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theodi/open-data-certificate/labels{/name}","releases_url":"https://api.github.com/repos/theodi/open-data-certificate/releases{/id}","created_at":"2013-02-27T14:49:12Z","updated_at":"2014-06-06T13:57:41Z","pushed_at":"2014-06-06T13:57:40Z","git_url":"git://github.com/theodi/open-data-certificate.git","ssh_url":"git@github.com:theodi/open-data-certificate.git","clone_url":"https://github.com/theodi/open-data-certificate.git","svn_url":"https://github.com/theodi/open-data-certificate","homepage":"https://certificates.theodi.org/","size":17390,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":22,"mirror_url":null,"open_issues_count":97,"forks":22,"open_issues":97,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theodi/open-data-certificate/pulls/788"},"html":{"href":"https://github.com/theodi/open-data-certificate/pull/788"},"issue":{"href":"https://api.github.com/repos/theodi/open-data-certificate/issues/788"},"comments":{"href":"https://api.github.com/repos/theodi/open-data-certificate/issues/788/comments"},"review_comments":{"href":"https://api.github.com/repos/theodi/open-data-certificate/pulls/788/comments"},"review_comment":{"href":"https://api.github.com/repos/theodi/open-data-certificate/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/theodi/open-data-certificate/pulls/788/commits"},"statuses":{"href":"https://api.github.com/repos/theodi/open-data-certificate/statuses/87e027320ff72549fc24e7c29a71fa725265dccb"}}}}