GitHub PullRequestEvent at 2014-07-27 19:17:25
Repository: factory-muffin
Actor: scottrobertson
Payload: {"action":"closed","number":101,"pull_request":{"url":"https://api.github.com/repos/thephpleague/factory-muffin/pulls/101","id":18943312,"html_url":"https://github.com/thephpleague/factory-muffin/pull/101","diff_url":"https://github.com/thephpleague/factory-muffin/pull/101.diff","patch_url":"https://github.com/thephpleague/factory-muffin/pull/101.patch","issue_url":"https://api.github.com/repos/thephpleague/factory-muffin/issues/101","number":101,"state":"closed","title":"A Load Of Fixes","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?","gravatar_id":"838bf3ed69d559cb46956c509c9464af","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"There's quite a lot here. I'll go through them all.\r\n\r\n1. After I added that .gitattributes file, git was complaining about the line endings on 3 of the files, so that's what the first commit is for.\r\n2. In the facades test file, for some reason the indentation was done with 2 spaces instead of 4 spaces, so that's what the second commit fixes.\r\n3. All docblocks should provide a short description that must end in a fullstop character, and ideally should remain on a single line.\r\n4. The `@var` annotation is deprecated and has been replaced by the `@type` annotation.\r\n5. The `@link` annotation is deprecated. I went for simply removing it entirely since I've updated the `@license` annotation to include the license url, which gives away the main github url.\r\n6. There should be blank line of comment between `@param`, `@throws`, and `@returns` annotations, and the annotations should be in that order.\r\n7. All `@param` annotations should be aligned. (this mainly wasn't an issue, although, I have corrected the types and descriptions on some of these - the same goes for the return types too)\r\n\r\nAll these docblock standards are from the psr docblock standard proposal, and I believe, are the standards phpdocumentor and sami uses.","created_at":"2014-07-27T19:02:28Z","updated_at":"2014-07-27T19:17:25Z","closed_at":"2014-07-27T19:17:25Z","merged_at":"2014-07-27T19:17:25Z","merge_commit_sha":"156bd9c2f764ff37db8d5a0e1163be6fb4b4d28f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thephpleague/factory-muffin/pulls/101/commits","review_comments_url":"https://api.github.com/repos/thephpleague/factory-muffin/pulls/101/comments","review_comment_url":"https://api.github.com/repos/thephpleague/factory-muffin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/thephpleague/factory-muffin/issues/101/comments","statuses_url":"https://api.github.com/repos/thephpleague/factory-muffin/statuses/5901a6fdf51add64fb136dbb5e26aa1b9abdb5bd","head":{"label":"GrahamCampbell:cs","ref":"cs","sha":"5901a6fdf51add64fb136dbb5e26aa1b9abdb5bd","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?","gravatar_id":"838bf3ed69d559cb46956c509c9464af","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"repo":{"id":22318229,"name":"factory-muffin","full_name":"GrahamCampbell/factory-muffin","owner":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?","gravatar_id":"838bf3ed69d559cb46956c509c9464af","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GrahamCampbell/factory-muffin","description":"Enable the rapid creation of objects for the purpose of testing.","fork":true,"url":"https://api.github.com/repos/GrahamCampbell/factory-muffin","forks_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/forks","keys_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/teams","hooks_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/hooks","issue_events_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/issues/events{/number}","events_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/events","assignees_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/assignees{/user}","branches_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/branches{/branch}","tags_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/tags","blobs_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/git/refs{/sha}","trees_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/statuses/{sha}","languages_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/languages","stargazers_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/stargazers","contributors_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/contributors","subscribers_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/subscribers","subscription_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/subscription","commits_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/commits{/sha}","git_commits_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/git/commits{/sha}","comments_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/comments{/number}","issue_comment_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/issues/comments/{number}","contents_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/contents/{+path}","compare_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/merges","archive_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/downloads","issues_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/issues{/number}","pulls_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/pulls{/number}","milestones_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/milestones{/number}","notifications_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/labels{/name}","releases_url":"https://api.github.com/repos/GrahamCampbell/factory-muffin/releases{/id}","created_at":"2014-07-27T18:21:05Z","updated_at":"2014-07-27T11:27:13Z","pushed_at":"2014-07-27T18:50:54Z","git_url":"git://github.com/GrahamCampbell/factory-muffin.git","ssh_url":"git@github.com:GrahamCampbell/factory-muffin.git","clone_url":"https://github.com/GrahamCampbell/factory-muffin.git","svn_url":"https://github.com/GrahamCampbell/factory-muffin","homepage":null,"size":1436,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thephpleague:master","ref":"master","sha":"833c0d1cdf9a4d6a6f7c3d53484ae2b86cf32364","user":{"login":"thephpleague","id":527621,"avatar_url":"https://avatars.githubusercontent.com/u/527621?","gravatar_id":"18875aa293f692d34632520b76b4a0bc","url":"https://api.github.com/users/thephpleague","html_url":"https://github.com/thephpleague","followers_url":"https://api.github.com/users/thephpleague/followers","following_url":"https://api.github.com/users/thephpleague/following{/other_user}","gists_url":"https://api.github.com/users/thephpleague/gists{/gist_id}","starred_url":"https://api.github.com/users/thephpleague/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thephpleague/subscriptions","organizations_url":"https://api.github.com/users/thephpleague/orgs","repos_url":"https://api.github.com/users/thephpleague/repos","events_url":"https://api.github.com/users/thephpleague/events{/privacy}","received_events_url":"https://api.github.com/users/thephpleague/received_events","type":"Organization","site_admin":false},"repo":{"id":7930464,"name":"factory-muffin","full_name":"thephpleague/factory-muffin","owner":{"login":"thephpleague","id":527621,"avatar_url":"https://avatars.githubusercontent.com/u/527621?","gravatar_id":"18875aa293f692d34632520b76b4a0bc","url":"https://api.github.com/users/thephpleague","html_url":"https://github.com/thephpleague","followers_url":"https://api.github.com/users/thephpleague/followers","following_url":"https://api.github.com/users/thephpleague/following{/other_user}","gists_url":"https://api.github.com/users/thephpleague/gists{/gist_id}","starred_url":"https://api.github.com/users/thephpleague/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thephpleague/subscriptions","organizations_url":"https://api.github.com/users/thephpleague/orgs","repos_url":"https://api.github.com/users/thephpleague/repos","events_url":"https://api.github.com/users/thephpleague/events{/privacy}","received_events_url":"https://api.github.com/users/thephpleague/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thephpleague/factory-muffin","description":"Enable the rapid creation of objects for the purpose of testing.","fork":false,"url":"https://api.github.com/repos/thephpleague/factory-muffin","forks_url":"https://api.github.com/repos/thephpleague/factory-muffin/forks","keys_url":"https://api.github.com/repos/thephpleague/factory-muffin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thephpleague/factory-muffin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thephpleague/factory-muffin/teams","hooks_url":"https://api.github.com/repos/thephpleague/factory-muffin/hooks","issue_events_url":"https://api.github.com/repos/thephpleague/factory-muffin/issues/events{/number}","events_url":"https://api.github.com/repos/thephpleague/factory-muffin/events","assignees_url":"https://api.github.com/repos/thephpleague/factory-muffin/assignees{/user}","branches_url":"https://api.github.com/repos/thephpleague/factory-muffin/branches{/branch}","tags_url":"https://api.github.com/repos/thephpleague/factory-muffin/tags","blobs_url":"https://api.github.com/repos/thephpleague/factory-muffin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thephpleague/factory-muffin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thephpleague/factory-muffin/git/refs{/sha}","trees_url":"https://api.github.com/repos/thephpleague/factory-muffin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thephpleague/factory-muffin/statuses/{sha}","languages_url":"https://api.github.com/repos/thephpleague/factory-muffin/languages","stargazers_url":"https://api.github.com/repos/thephpleague/factory-muffin/stargazers","contributors_url":"https://api.github.com/repos/thephpleague/factory-muffin/contributors","subscribers_url":"https://api.github.com/repos/thephpleague/factory-muffin/subscribers","subscription_url":"https://api.github.com/repos/thephpleague/factory-muffin/subscription","commits_url":"https://api.github.com/repos/thephpleague/factory-muffin/commits{/sha}","git_commits_url":"https://api.github.com/repos/thephpleague/factory-muffin/git/commits{/sha}","comments_url":"https://api.github.com/repos/thephpleague/factory-muffin/comments{/number}","issue_comment_url":"https://api.github.com/repos/thephpleague/factory-muffin/issues/comments/{number}","contents_url":"https://api.github.com/repos/thephpleague/factory-muffin/contents/{+path}","compare_url":"https://api.github.com/repos/thephpleague/factory-muffin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thephpleague/factory-muffin/merges","archive_url":"https://api.github.com/repos/thephpleague/factory-muffin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thephpleague/factory-muffin/downloads","issues_url":"https://api.github.com/repos/thephpleague/factory-muffin/issues{/number}","pulls_url":"https://api.github.com/repos/thephpleague/factory-muffin/pulls{/number}","milestones_url":"https://api.github.com/repos/thephpleague/factory-muffin/milestones{/number}","notifications_url":"https://api.github.com/repos/thephpleague/factory-muffin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thephpleague/factory-muffin/labels{/name}","releases_url":"https://api.github.com/repos/thephpleague/factory-muffin/releases{/id}","created_at":"2013-01-31T04:51:12Z","updated_at":"2014-07-27T11:27:13Z","pushed_at":"2014-07-27T19:17:25Z","git_url":"git://github.com/thephpleague/factory-muffin.git","ssh_url":"git@github.com:thephpleague/factory-muffin.git","clone_url":"https://github.com/thephpleague/factory-muffin.git","svn_url":"https://github.com/thephpleague/factory-muffin","homepage":null,"size":1436,"stargazers_count":100,"watchers_count":100,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":20,"mirror_url":null,"open_issues_count":8,"forks":20,"open_issues":8,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thephpleague/factory-muffin/pulls/101"},"html":{"href":"https://github.com/thephpleague/factory-muffin/pull/101"},"issue":{"href":"https://api.github.com/repos/thephpleague/factory-muffin/issues/101"},"comments":{"href":"https://api.github.com/repos/thephpleague/factory-muffin/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/thephpleague/factory-muffin/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/thephpleague/factory-muffin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/thephpleague/factory-muffin/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/thephpleague/factory-muffin/statuses/5901a6fdf51add64fb136dbb5e26aa1b9abdb5bd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"scottrobertson","id":68361,"avatar_url":"https://avatars.githubusercontent.com/u/68361?","gravatar_id":"9b31527bbbd10dbe3f26ad7fdc65645d","url":"https://api.github.com/users/scottrobertson","html_url":"https://github.com/scottrobertson","followers_url":"https://api.github.com/users/scottrobertson/followers","following_url":"https://api.github.com/users/scottrobertson/following{/other_user}","gists_url":"https://api.github.com/users/scottrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/scottrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottrobertson/subscriptions","organizations_url":"https://api.github.com/users/scottrobertson/orgs","repos_url":"https://api.github.com/users/scottrobertson/repos","events_url":"https://api.github.com/users/scottrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/scottrobertson/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":301,"deletions":290,"changed_files":18}}