GitHub PullRequestReviewCommentEvent at 2014-11-26 22:03:14
Repository: logstash-filter-elasticsearch
Actor: jordansissel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls/comments/20966845","id":20966845,"diff_hunk":"@@ -38,8 +38,14 @@ class LogStash::Filters::Elasticsearch < LogStash::Filters::Base\n \n   # Elasticsearch query string\n   config :query, :validate => :string\n+ \n+  # Index to search in\n+  config :index, :validate => :string, :default => \"\"\n \n-  # Comma-delimited list of `<field>:<direction>` pairs that define the sort order\n+  # Types to search in\n+  config :type, :validate => :string, :default => \"\"\n+\n+  # Comma-delimited list of <field>:<direction> pairs that define the sort order\n   config :sort, :validate => :string, :default => \"@timestamp:desc\"","path":"lib/logstash/filters/elasticsearch.rb","position":13,"original_position":13,"commit_id":"b425d0e913cd7f094132af9174d1018281e8def5","original_commit_id":"b425d0e913cd7f094132af9174d1018281e8def5","user":{"login":"jordansissel","id":131818,"avatar_url":"https://avatars.githubusercontent.com/u/131818?v=3","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false},"body":"can we do an :array instead?\r\n\r\n`[ \"@timestamp:desc\", \"user:asc\" ]`","created_at":"2014-11-26T22:03:14Z","updated_at":"2014-11-26T22:03:14Z","html_url":"https://github.com/logstash-plugins/logstash-filter-elasticsearch/pull/4#discussion_r20966845","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls/comments/20966845"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-elasticsearch/pull/4#discussion_r20966845"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls/4","id":24981227,"html_url":"https://github.com/logstash-plugins/logstash-filter-elasticsearch/pull/4","diff_url":"https://github.com/logstash-plugins/logstash-filter-elasticsearch/pull/4.diff","patch_url":"https://github.com/logstash-plugins/logstash-filter-elasticsearch/pull/4.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/issues/4","number":4,"state":"open","locked":false,"title":"handle zero-result queries, specify index/type, add stub of rspec","user":{"login":"kurtado","id":1161427,"avatar_url":"https://avatars.githubusercontent.com/u/1161427?v=3","gravatar_id":"","url":"https://api.github.com/users/kurtado","html_url":"https://github.com/kurtado","followers_url":"https://api.github.com/users/kurtado/followers","following_url":"https://api.github.com/users/kurtado/following{/other_user}","gists_url":"https://api.github.com/users/kurtado/gists{/gist_id}","starred_url":"https://api.github.com/users/kurtado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurtado/subscriptions","organizations_url":"https://api.github.com/users/kurtado/orgs","repos_url":"https://api.github.com/users/kurtado/repos","events_url":"https://api.github.com/users/kurtado/events{/privacy}","received_events_url":"https://api.github.com/users/kurtado/received_events","type":"User","site_admin":false},"body":"Attempting to aggregate several PRs, feature requests and issues:\r\n\r\nhttps://github.com/elasticsearch/logstash-contrib/pull/57\r\nhttps://github.com/elasticsearch/logstash-contrib/issues/95\r\nhttps://github.com/elasticsearch/logstash-contrib/pull/96\r\n\r\nwith help and input from @greem @sisutcliffe @bleskes et al.\r\n","created_at":"2014-11-25T02:40:58Z","updated_at":"2014-11-26T22:03:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"458e9d2d3138ad642b2e73d36ce3a0786b7c9bcb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls/4/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls/4/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls/comments/{number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/issues/4/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/statuses/b425d0e913cd7f094132af9174d1018281e8def5","head":{"label":"kurtado:add-index-handle-errors","ref":"add-index-handle-errors","sha":"b425d0e913cd7f094132af9174d1018281e8def5","user":{"login":"kurtado","id":1161427,"avatar_url":"https://avatars.githubusercontent.com/u/1161427?v=3","gravatar_id":"","url":"https://api.github.com/users/kurtado","html_url":"https://github.com/kurtado","followers_url":"https://api.github.com/users/kurtado/followers","following_url":"https://api.github.com/users/kurtado/following{/other_user}","gists_url":"https://api.github.com/users/kurtado/gists{/gist_id}","starred_url":"https://api.github.com/users/kurtado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurtado/subscriptions","organizations_url":"https://api.github.com/users/kurtado/orgs","repos_url":"https://api.github.com/users/kurtado/repos","events_url":"https://api.github.com/users/kurtado/events{/privacy}","received_events_url":"https://api.github.com/users/kurtado/received_events","type":"User","site_admin":false},"repo":{"id":27086551,"name":"logstash-filter-elasticsearch","full_name":"kurtado/logstash-filter-elasticsearch","owner":{"login":"kurtado","id":1161427,"avatar_url":"https://avatars.githubusercontent.com/u/1161427?v=3","gravatar_id":"","url":"https://api.github.com/users/kurtado","html_url":"https://github.com/kurtado","followers_url":"https://api.github.com/users/kurtado/followers","following_url":"https://api.github.com/users/kurtado/following{/other_user}","gists_url":"https://api.github.com/users/kurtado/gists{/gist_id}","starred_url":"https://api.github.com/users/kurtado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurtado/subscriptions","organizations_url":"https://api.github.com/users/kurtado/orgs","repos_url":"https://api.github.com/users/kurtado/repos","events_url":"https://api.github.com/users/kurtado/events{/privacy}","received_events_url":"https://api.github.com/users/kurtado/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kurtado/logstash-filter-elasticsearch","description":"Elasticsearch filter for Logstash","fork":true,"url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch","forks_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/forks","keys_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/teams","hooks_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/events","assignees_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/tags","blobs_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/subscription","commits_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/merges","archive_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/downloads","issues_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/kurtado/logstash-filter-elasticsearch/releases{/id}","created_at":"2014-11-24T17:29:51Z","updated_at":"2014-11-24T17:29:52Z","pushed_at":"2014-11-25T02:36:09Z","git_url":"git://github.com/kurtado/logstash-filter-elasticsearch.git","ssh_url":"git@github.com:kurtado/logstash-filter-elasticsearch.git","clone_url":"https://github.com/kurtado/logstash-filter-elasticsearch.git","svn_url":"https://github.com/kurtado/logstash-filter-elasticsearch","homepage":null,"size":101,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"677a5837e83feddbdf995c622a52e2868ce9decd","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":23465478,"name":"logstash-filter-elasticsearch","full_name":"logstash-plugins/logstash-filter-elasticsearch","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-filter-elasticsearch","description":"Elasticsearch filter for Logstash","fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/releases{/id}","created_at":"2014-08-29T13:51:15Z","updated_at":"2014-11-19T20:21:43Z","pushed_at":"2014-11-19T22:58:30Z","git_url":"git://github.com/logstash-plugins/logstash-filter-elasticsearch.git","ssh_url":"git@github.com:logstash-plugins/logstash-filter-elasticsearch.git","clone_url":"https://github.com/logstash-plugins/logstash-filter-elasticsearch.git","svn_url":"https://github.com/logstash-plugins/logstash-filter-elasticsearch","homepage":null,"size":218,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls/4"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-elasticsearch/pull/4"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/issues/4"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-elasticsearch/statuses/b425d0e913cd7f094132af9174d1018281e8def5"}}}}