GitHub PullRequestEvent at 2014-07-28 16:16:33
Repository: Command-T
Actor: wincent
Payload: {"action":"closed","number":57,"pull_request":{"url":"https://api.github.com/repos/wincent/Command-T/pulls/57","id":9587105,"html_url":"https://github.com/wincent/Command-T/pull/57","diff_url":"https://github.com/wincent/Command-T/pull/57.diff","patch_url":"https://github.com/wincent/Command-T/pull/57.patch","issue_url":"https://api.github.com/repos/wincent/Command-T/issues/57","number":57,"state":"closed","title":"Avoid calling expand when unnecessary","user":{"login":"pfhayes","id":403100,"avatar_url":"https://avatars.githubusercontent.com/u/403100?","gravatar_id":"9410edeccb76eae700bb56973708ddef","url":"https://api.github.com/users/pfhayes","html_url":"https://github.com/pfhayes","followers_url":"https://api.github.com/users/pfhayes/followers","following_url":"https://api.github.com/users/pfhayes/following{/other_user}","gists_url":"https://api.github.com/users/pfhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfhayes/subscriptions","organizations_url":"https://api.github.com/users/pfhayes/orgs","repos_url":"https://api.github.com/users/pfhayes/repos","events_url":"https://api.github.com/users/pfhayes/events{/privacy}","received_events_url":"https://api.github.com/users/pfhayes/received_events","type":"User","site_admin":false},"body":"Calling expand(fnamescape(...)) can be expensive on very large filelists, even when wildignore is empty. Now, when wildignore is empty (either by default, or through the Command-T override), we skip making the step and assume the file is never excluded. This makes calling Command-T much snappier when the generated file list is very long.","created_at":"2013-11-01T01:21:45Z","updated_at":"2014-07-28T16:16:33Z","closed_at":"2014-07-28T16:16:33Z","merged_at":null,"merge_commit_sha":"8948b14b5910ba1063254c00e10a8f57657174b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wincent/Command-T/pulls/57/commits","review_comments_url":"https://api.github.com/repos/wincent/Command-T/pulls/57/comments","review_comment_url":"https://api.github.com/repos/wincent/Command-T/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wincent/Command-T/issues/57/comments","statuses_url":"https://api.github.com/repos/wincent/Command-T/statuses/739b878d6cdca3048765d09f839ea6cd5991da0e","head":{"label":"pfhayes:expand","ref":"expand","sha":"739b878d6cdca3048765d09f839ea6cd5991da0e","user":{"login":"pfhayes","id":403100,"avatar_url":"https://avatars.githubusercontent.com/u/403100?","gravatar_id":"9410edeccb76eae700bb56973708ddef","url":"https://api.github.com/users/pfhayes","html_url":"https://github.com/pfhayes","followers_url":"https://api.github.com/users/pfhayes/followers","following_url":"https://api.github.com/users/pfhayes/following{/other_user}","gists_url":"https://api.github.com/users/pfhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfhayes/subscriptions","organizations_url":"https://api.github.com/users/pfhayes/orgs","repos_url":"https://api.github.com/users/pfhayes/repos","events_url":"https://api.github.com/users/pfhayes/events{/privacy}","received_events_url":"https://api.github.com/users/pfhayes/received_events","type":"User","site_admin":false},"repo":{"id":7472099,"name":"Command-T","full_name":"pfhayes/Command-T","owner":{"login":"pfhayes","id":403100,"avatar_url":"https://avatars.githubusercontent.com/u/403100?","gravatar_id":"9410edeccb76eae700bb56973708ddef","url":"https://api.github.com/users/pfhayes","html_url":"https://github.com/pfhayes","followers_url":"https://api.github.com/users/pfhayes/followers","following_url":"https://api.github.com/users/pfhayes/following{/other_user}","gists_url":"https://api.github.com/users/pfhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfhayes/subscriptions","organizations_url":"https://api.github.com/users/pfhayes/orgs","repos_url":"https://api.github.com/users/pfhayes/repos","events_url":"https://api.github.com/users/pfhayes/events{/privacy}","received_events_url":"https://api.github.com/users/pfhayes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfhayes/Command-T","description":"Mirror of the official Command-T repository at git.wincent.com","fork":true,"url":"https://api.github.com/repos/pfhayes/Command-T","forks_url":"https://api.github.com/repos/pfhayes/Command-T/forks","keys_url":"https://api.github.com/repos/pfhayes/Command-T/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfhayes/Command-T/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfhayes/Command-T/teams","hooks_url":"https://api.github.com/repos/pfhayes/Command-T/hooks","issue_events_url":"https://api.github.com/repos/pfhayes/Command-T/issues/events{/number}","events_url":"https://api.github.com/repos/pfhayes/Command-T/events","assignees_url":"https://api.github.com/repos/pfhayes/Command-T/assignees{/user}","branches_url":"https://api.github.com/repos/pfhayes/Command-T/branches{/branch}","tags_url":"https://api.github.com/repos/pfhayes/Command-T/tags","blobs_url":"https://api.github.com/repos/pfhayes/Command-T/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfhayes/Command-T/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfhayes/Command-T/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfhayes/Command-T/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfhayes/Command-T/statuses/{sha}","languages_url":"https://api.github.com/repos/pfhayes/Command-T/languages","stargazers_url":"https://api.github.com/repos/pfhayes/Command-T/stargazers","contributors_url":"https://api.github.com/repos/pfhayes/Command-T/contributors","subscribers_url":"https://api.github.com/repos/pfhayes/Command-T/subscribers","subscription_url":"https://api.github.com/repos/pfhayes/Command-T/subscription","commits_url":"https://api.github.com/repos/pfhayes/Command-T/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfhayes/Command-T/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfhayes/Command-T/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfhayes/Command-T/issues/comments/{number}","contents_url":"https://api.github.com/repos/pfhayes/Command-T/contents/{+path}","compare_url":"https://api.github.com/repos/pfhayes/Command-T/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfhayes/Command-T/merges","archive_url":"https://api.github.com/repos/pfhayes/Command-T/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfhayes/Command-T/downloads","issues_url":"https://api.github.com/repos/pfhayes/Command-T/issues{/number}","pulls_url":"https://api.github.com/repos/pfhayes/Command-T/pulls{/number}","milestones_url":"https://api.github.com/repos/pfhayes/Command-T/milestones{/number}","notifications_url":"https://api.github.com/repos/pfhayes/Command-T/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfhayes/Command-T/labels{/name}","releases_url":"https://api.github.com/repos/pfhayes/Command-T/releases{/id}","created_at":"2013-01-06T20:08:22Z","updated_at":"2013-11-01T01:21:45Z","pushed_at":"2014-07-27T21:56:26Z","git_url":"git://github.com/pfhayes/Command-T.git","ssh_url":"git@github.com:pfhayes/Command-T.git","clone_url":"https://github.com/pfhayes/Command-T.git","svn_url":"https://github.com/pfhayes/Command-T","homepage":"https://wincent.com/products/command-t","size":2942,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"wincent:master","ref":"master","sha":"89896bd88a3d0cd5c41f8754dfa004dda91fb488","user":{"login":"wincent","id":7074,"avatar_url":"https://avatars.githubusercontent.com/u/7074?","gravatar_id":"ef9ecd30591995af2cf62cde10b26e49","url":"https://api.github.com/users/wincent","html_url":"https://github.com/wincent","followers_url":"https://api.github.com/users/wincent/followers","following_url":"https://api.github.com/users/wincent/following{/other_user}","gists_url":"https://api.github.com/users/wincent/gists{/gist_id}","starred_url":"https://api.github.com/users/wincent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wincent/subscriptions","organizations_url":"https://api.github.com/users/wincent/orgs","repos_url":"https://api.github.com/users/wincent/repos","events_url":"https://api.github.com/users/wincent/events{/privacy}","received_events_url":"https://api.github.com/users/wincent/received_events","type":"User","site_admin":false},"repo":{"id":553200,"name":"Command-T","full_name":"wincent/Command-T","owner":{"login":"wincent","id":7074,"avatar_url":"https://avatars.githubusercontent.com/u/7074?","gravatar_id":"ef9ecd30591995af2cf62cde10b26e49","url":"https://api.github.com/users/wincent","html_url":"https://github.com/wincent","followers_url":"https://api.github.com/users/wincent/followers","following_url":"https://api.github.com/users/wincent/following{/other_user}","gists_url":"https://api.github.com/users/wincent/gists{/gist_id}","starred_url":"https://api.github.com/users/wincent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wincent/subscriptions","organizations_url":"https://api.github.com/users/wincent/orgs","repos_url":"https://api.github.com/users/wincent/repos","events_url":"https://api.github.com/users/wincent/events{/privacy}","received_events_url":"https://api.github.com/users/wincent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wincent/Command-T","description":"Mirror of the official Command-T repository at git.wincent.com","fork":false,"url":"https://api.github.com/repos/wincent/Command-T","forks_url":"https://api.github.com/repos/wincent/Command-T/forks","keys_url":"https://api.github.com/repos/wincent/Command-T/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wincent/Command-T/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wincent/Command-T/teams","hooks_url":"https://api.github.com/repos/wincent/Command-T/hooks","issue_events_url":"https://api.github.com/repos/wincent/Command-T/issues/events{/number}","events_url":"https://api.github.com/repos/wincent/Command-T/events","assignees_url":"https://api.github.com/repos/wincent/Command-T/assignees{/user}","branches_url":"https://api.github.com/repos/wincent/Command-T/branches{/branch}","tags_url":"https://api.github.com/repos/wincent/Command-T/tags","blobs_url":"https://api.github.com/repos/wincent/Command-T/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wincent/Command-T/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wincent/Command-T/git/refs{/sha}","trees_url":"https://api.github.com/repos/wincent/Command-T/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wincent/Command-T/statuses/{sha}","languages_url":"https://api.github.com/repos/wincent/Command-T/languages","stargazers_url":"https://api.github.com/repos/wincent/Command-T/stargazers","contributors_url":"https://api.github.com/repos/wincent/Command-T/contributors","subscribers_url":"https://api.github.com/repos/wincent/Command-T/subscribers","subscription_url":"https://api.github.com/repos/wincent/Command-T/subscription","commits_url":"https://api.github.com/repos/wincent/Command-T/commits{/sha}","git_commits_url":"https://api.github.com/repos/wincent/Command-T/git/commits{/sha}","comments_url":"https://api.github.com/repos/wincent/Command-T/comments{/number}","issue_comment_url":"https://api.github.com/repos/wincent/Command-T/issues/comments/{number}","contents_url":"https://api.github.com/repos/wincent/Command-T/contents/{+path}","compare_url":"https://api.github.com/repos/wincent/Command-T/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wincent/Command-T/merges","archive_url":"https://api.github.com/repos/wincent/Command-T/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wincent/Command-T/downloads","issues_url":"https://api.github.com/repos/wincent/Command-T/issues{/number}","pulls_url":"https://api.github.com/repos/wincent/Command-T/pulls{/number}","milestones_url":"https://api.github.com/repos/wincent/Command-T/milestones{/number}","notifications_url":"https://api.github.com/repos/wincent/Command-T/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wincent/Command-T/labels{/name}","releases_url":"https://api.github.com/repos/wincent/Command-T/releases{/id}","created_at":"2010-03-08T22:11:39Z","updated_at":"2014-07-27T04:16:51Z","pushed_at":"2014-07-28T16:14:41Z","git_url":"git://github.com/wincent/Command-T.git","ssh_url":"git@github.com:wincent/Command-T.git","clone_url":"https://github.com/wincent/Command-T.git","svn_url":"https://github.com/wincent/Command-T","homepage":"https://wincent.com/products/command-t","size":10876,"stargazers_count":1081,"watchers_count":1081,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":136,"mirror_url":null,"open_issues_count":20,"forks":136,"open_issues":20,"watchers":1081,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wincent/Command-T/pulls/57"},"html":{"href":"https://github.com/wincent/Command-T/pull/57"},"issue":{"href":"https://api.github.com/repos/wincent/Command-T/issues/57"},"comments":{"href":"https://api.github.com/repos/wincent/Command-T/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/wincent/Command-T/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/wincent/Command-T/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wincent/Command-T/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/wincent/Command-T/statuses/739b878d6cdca3048765d09f839ea6cd5991da0e"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":3,"additions":45,"deletions":9,"changed_files":4}}