GitHub PullRequestReviewCommentEvent at 2014-10-15 08:05:58
Repository: DataStructures.jl
Actor: kmsquire
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/comments/18879379","id":18879379,"diff_hunk":"@@ -0,0 +1,533 @@\n+## A SortedDict is a wrapper around balancedTree with\n+## methods similiar to those of Julia container Dict.\n+\n+\n+type SortedDict{K, D, Ord <: Ordering} <: Associative{K,D}\n+    bt::BalancedTree23{K,D,Ord}\n+end\n+\n+## Constructor takes an ordering object which defaults\n+## to Forward\n+\n+function SortedDict{K,D, Ord <: Ordering}(d::Associative{K,D}, o::Ord=Forward)\n+    bt1 = BalancedTree23{K,D,Ord}(o)\n+    for pr in d\n+        insert!(bt1, pr[1], pr[2], false)\n+    end\n+    SortedDict(bt1)\n+end\n+\n+\n+\n+## An SDToken is a small structure for iterating\n+## over the items in a sorted dict order.  It is\n+## a wrapper around an (SortedDict,Int) pair; the int is the index\n+## of the current item in t.data.  An iterator\n+## should never point to a deleted item.  An iterator\n+## that points to the before-start item (=1)\n+## or the after-end item (=2) cannot be  dereferenced.","path":"src/sortedDict.jl","position":null,"original_position":28,"commit_id":"f60645b0c121949b114ce17e8fb88d7e22b30457","original_commit_id":"967d1a63cab0a2de87e69a6d01aa7e7d2ebc27a2","user":{"login":"kmsquire","id":223250,"avatar_url":"https://avatars.githubusercontent.com/u/223250?v=2","gravatar_id":"","url":"https://api.github.com/users/kmsquire","html_url":"https://github.com/kmsquire","followers_url":"https://api.github.com/users/kmsquire/followers","following_url":"https://api.github.com/users/kmsquire/following{/other_user}","gists_url":"https://api.github.com/users/kmsquire/gists{/gist_id}","starred_url":"https://api.github.com/users/kmsquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmsquire/subscriptions","organizations_url":"https://api.github.com/users/kmsquire/orgs","repos_url":"https://api.github.com/users/kmsquire/repos","events_url":"https://api.github.com/users/kmsquire/events{/privacy}","received_events_url":"https://api.github.com/users/kmsquire/received_events","type":"User","site_admin":false},"body":"Okay, I finally had a chance to read through all of that in some detail. I agree that the use of the type parameters is annoying, and really shouldn't be necessary.  \r\n\r\nI just added a comment in the issue you raised, which might point to a way to deal with this, but it will probably take some exploration. I'll see if I can't help along that line at some point.","created_at":"2014-10-15T08:05:58Z","updated_at":"2014-10-15T08:05:58Z","html_url":"https://github.com/JuliaLang/DataStructures.jl/pull/53#discussion_r18879379","pull_request_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/comments/18879379"},"html":{"href":"https://github.com/JuliaLang/DataStructures.jl/pull/53#discussion_r18879379"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/53","id":20843609,"html_url":"https://github.com/JuliaLang/DataStructures.jl/pull/53","diff_url":"https://github.com/JuliaLang/DataStructures.jl/pull/53.diff","patch_url":"https://github.com/JuliaLang/DataStructures.jl/pull/53.patch","issue_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues/53","number":53,"state":"open","locked":false,"title":"Sorted dict 1","user":{"login":"StephenVavasis","id":7881863,"avatar_url":"https://avatars.githubusercontent.com/u/7881863?v=2","gravatar_id":"","url":"https://api.github.com/users/StephenVavasis","html_url":"https://github.com/StephenVavasis","followers_url":"https://api.github.com/users/StephenVavasis/followers","following_url":"https://api.github.com/users/StephenVavasis/following{/other_user}","gists_url":"https://api.github.com/users/StephenVavasis/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenVavasis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenVavasis/subscriptions","organizations_url":"https://api.github.com/users/StephenVavasis/orgs","repos_url":"https://api.github.com/users/StephenVavasis/repos","events_url":"https://api.github.com/users/StephenVavasis/events{/privacy}","received_events_url":"https://api.github.com/users/StephenVavasis/received_events","type":"User","site_admin":false},"body":"Pull request for SortedDict and BalancedTree23 taking into account Kevin Squire's feedback from the past 12 days.","created_at":"2014-09-06T01:29:04Z","updated_at":"2014-10-15T08:05:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/53/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/53/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues/53/comments","statuses_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/statuses/f60645b0c121949b114ce17e8fb88d7e22b30457","head":{"label":"StephenVavasis:SortedDict-1","ref":"SortedDict-1","sha":"f60645b0c121949b114ce17e8fb88d7e22b30457","user":{"login":"StephenVavasis","id":7881863,"avatar_url":"https://avatars.githubusercontent.com/u/7881863?v=2","gravatar_id":"","url":"https://api.github.com/users/StephenVavasis","html_url":"https://github.com/StephenVavasis","followers_url":"https://api.github.com/users/StephenVavasis/followers","following_url":"https://api.github.com/users/StephenVavasis/following{/other_user}","gists_url":"https://api.github.com/users/StephenVavasis/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenVavasis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenVavasis/subscriptions","organizations_url":"https://api.github.com/users/StephenVavasis/orgs","repos_url":"https://api.github.com/users/StephenVavasis/repos","events_url":"https://api.github.com/users/StephenVavasis/events{/privacy}","received_events_url":"https://api.github.com/users/StephenVavasis/received_events","type":"User","site_admin":false},"repo":{"id":23091876,"name":"DataStructures.jl","full_name":"StephenVavasis/DataStructures.jl","owner":{"login":"StephenVavasis","id":7881863,"avatar_url":"https://avatars.githubusercontent.com/u/7881863?v=2","gravatar_id":"","url":"https://api.github.com/users/StephenVavasis","html_url":"https://github.com/StephenVavasis","followers_url":"https://api.github.com/users/StephenVavasis/followers","following_url":"https://api.github.com/users/StephenVavasis/following{/other_user}","gists_url":"https://api.github.com/users/StephenVavasis/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenVavasis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenVavasis/subscriptions","organizations_url":"https://api.github.com/users/StephenVavasis/orgs","repos_url":"https://api.github.com/users/StephenVavasis/repos","events_url":"https://api.github.com/users/StephenVavasis/events{/privacy}","received_events_url":"https://api.github.com/users/StephenVavasis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StephenVavasis/DataStructures.jl","description":"Julia implementation of Data structures","fork":true,"url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl","forks_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/forks","keys_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/teams","hooks_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/hooks","issue_events_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/issues/events{/number}","events_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/events","assignees_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/assignees{/user}","branches_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/branches{/branch}","tags_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/tags","blobs_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/languages","stargazers_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/stargazers","contributors_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/contributors","subscribers_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/subscribers","subscription_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/subscription","commits_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/issues/comments/{number}","contents_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/contents/{+path}","compare_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/merges","archive_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/downloads","issues_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/issues{/number}","pulls_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/labels{/name}","releases_url":"https://api.github.com/repos/StephenVavasis/DataStructures.jl/releases{/id}","created_at":"2014-08-19T01:02:37Z","updated_at":"2014-08-19T05:05:01Z","pushed_at":"2014-10-13T22:25:02Z","git_url":"git://github.com/StephenVavasis/DataStructures.jl.git","ssh_url":"git@github.com:StephenVavasis/DataStructures.jl.git","clone_url":"https://github.com/StephenVavasis/DataStructures.jl.git","svn_url":"https://github.com/StephenVavasis/DataStructures.jl","homepage":"","size":1376,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"b4aea82ce1cf165b96115f9271efd33776435fe0","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=2","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":8756512,"name":"DataStructures.jl","full_name":"JuliaLang/DataStructures.jl","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=2","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/DataStructures.jl","description":"Julia implementation of Data structures","fork":false,"url":"https://api.github.com/repos/JuliaLang/DataStructures.jl","forks_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/forks","keys_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/teams","hooks_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/events","assignees_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/tags","blobs_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/subscription","commits_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues/comments/{number}","contents_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/merges","archive_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/downloads","issues_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/releases{/id}","created_at":"2013-03-13T16:28:14Z","updated_at":"2014-10-13T08:52:04Z","pushed_at":"2014-10-15T06:59:44Z","git_url":"git://github.com/JuliaLang/DataStructures.jl.git","ssh_url":"git@github.com:JuliaLang/DataStructures.jl.git","clone_url":"https://github.com/JuliaLang/DataStructures.jl.git","svn_url":"https://github.com/JuliaLang/DataStructures.jl","homepage":"","size":2422,"stargazers_count":31,"watchers_count":31,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":11,"forks":28,"open_issues":11,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/53"},"html":{"href":"https://github.com/JuliaLang/DataStructures.jl/pull/53"},"issue":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues/53"},"comments":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/statuses/f60645b0c121949b114ce17e8fb88d7e22b30457"}}}}