GitHub PullRequestReviewCommentEvent at 2014-08-21 09:14:30
Repository: ember-cli
Actor: selvagsz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/comments/16528135","id":16528135,"diff_hunk":"@@ -53,7 +53,7 @@ module.exports = Task.extend({\n           }\n           ui.write('File: ' + file + '\\n');\n         }\n-        ui.write(err.stack);\n+        ui.write(err.stack + '\\n');","path":"lib/tasks/build.js","position":5,"original_position":5,"commit_id":"10b3d9f4972fda64f4653354f4a7a16c5ff9c833","original_commit_id":"10b3d9f4972fda64f4653354f4a7a16c5ff9c833","user":{"login":"selvagsz","id":2162441,"avatar_url":"https://avatars.githubusercontent.com/u/2162441?v=2","gravatar_id":"27d14fa62cd583c0dd02bc0ce0b03226","url":"https://api.github.com/users/selvagsz","html_url":"https://github.com/selvagsz","followers_url":"https://api.github.com/users/selvagsz/followers","following_url":"https://api.github.com/users/selvagsz/following{/other_user}","gists_url":"https://api.github.com/users/selvagsz/gists{/gist_id}","starred_url":"https://api.github.com/users/selvagsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvagsz/subscriptions","organizations_url":"https://api.github.com/users/selvagsz/orgs","repos_url":"https://api.github.com/users/selvagsz/repos","events_url":"https://api.github.com/users/selvagsz/events{/privacy}","received_events_url":"https://api.github.com/users/selvagsz/received_events","type":"User","site_admin":false},"body":"Grepping shows 169 matches of `\\n`. Is everything supposed to be replaced by the `EOL`?","created_at":"2014-08-21T09:14:30Z","updated_at":"2014-08-21T09:14:30Z","html_url":"https://github.com/stefanpenner/ember-cli/pull/1715#discussion_r16528135","pull_request_url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1715","_links":{"self":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/comments/16528135"},"html":{"href":"https://github.com/stefanpenner/ember-cli/pull/1715#discussion_r16528135"},"pull_request":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1715"}}},"pull_request":{"url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1715","id":20074056,"html_url":"https://github.com/stefanpenner/ember-cli/pull/1715","diff_url":"https://github.com/stefanpenner/ember-cli/pull/1715.diff","patch_url":"https://github.com/stefanpenner/ember-cli/pull/1715.patch","issue_url":"https://api.github.com/repos/stefanpenner/ember-cli/issues/1715","number":1715,"state":"open","locked":false,"title":"Adds a new line after build error stack trace","user":{"login":"selvagsz","id":2162441,"avatar_url":"https://avatars.githubusercontent.com/u/2162441?v=2","gravatar_id":"27d14fa62cd583c0dd02bc0ce0b03226","url":"https://api.github.com/users/selvagsz","html_url":"https://github.com/selvagsz","followers_url":"https://api.github.com/users/selvagsz/followers","following_url":"https://api.github.com/users/selvagsz/following{/other_user}","gists_url":"https://api.github.com/users/selvagsz/gists{/gist_id}","starred_url":"https://api.github.com/users/selvagsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvagsz/subscriptions","organizations_url":"https://api.github.com/users/selvagsz/orgs","repos_url":"https://api.github.com/users/selvagsz/repos","events_url":"https://api.github.com/users/selvagsz/events{/privacy}","received_events_url":"https://api.github.com/users/selvagsz/received_events","type":"User","site_admin":false},"body":"Just a minor prettify in build stack error trace\r\n\r\n**Before:**\r\n\r\n![stack-before-new-line-termination](https://cloud.githubusercontent.com/assets/2162441/3988220/df6da2c2-28ad-11e4-852a-72dec0476445.jpg)\r\n\r\n\r\n**After:**\r\n\r\n![stack-after-new-line-termination](https://cloud.githubusercontent.com/assets/2162441/3988226/e55a095a-28ad-11e4-8a91-a4324dfa3614.jpg)\r\n\r\n\r\n","created_at":"2014-08-20T21:07:24Z","updated_at":"2014-08-21T09:14:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2269bff4d4d97bd044c42624a3739f8d07464c56","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1715/commits","review_comments_url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1715/comments","review_comment_url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/comments/{number}","comments_url":"https://api.github.com/repos/stefanpenner/ember-cli/issues/1715/comments","statuses_url":"https://api.github.com/repos/stefanpenner/ember-cli/statuses/10b3d9f4972fda64f4653354f4a7a16c5ff9c833","head":{"label":"selvagsz:add-new-line-after-error-stack","ref":"add-new-line-after-error-stack","sha":"10b3d9f4972fda64f4653354f4a7a16c5ff9c833","user":{"login":"selvagsz","id":2162441,"avatar_url":"https://avatars.githubusercontent.com/u/2162441?v=2","gravatar_id":"27d14fa62cd583c0dd02bc0ce0b03226","url":"https://api.github.com/users/selvagsz","html_url":"https://github.com/selvagsz","followers_url":"https://api.github.com/users/selvagsz/followers","following_url":"https://api.github.com/users/selvagsz/following{/other_user}","gists_url":"https://api.github.com/users/selvagsz/gists{/gist_id}","starred_url":"https://api.github.com/users/selvagsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvagsz/subscriptions","organizations_url":"https://api.github.com/users/selvagsz/orgs","repos_url":"https://api.github.com/users/selvagsz/repos","events_url":"https://api.github.com/users/selvagsz/events{/privacy}","received_events_url":"https://api.github.com/users/selvagsz/received_events","type":"User","site_admin":false},"repo":{"id":18940437,"name":"ember-cli","full_name":"selvagsz/ember-cli","owner":{"login":"selvagsz","id":2162441,"avatar_url":"https://avatars.githubusercontent.com/u/2162441?v=2","gravatar_id":"27d14fa62cd583c0dd02bc0ce0b03226","url":"https://api.github.com/users/selvagsz","html_url":"https://github.com/selvagsz","followers_url":"https://api.github.com/users/selvagsz/followers","following_url":"https://api.github.com/users/selvagsz/following{/other_user}","gists_url":"https://api.github.com/users/selvagsz/gists{/gist_id}","starred_url":"https://api.github.com/users/selvagsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvagsz/subscriptions","organizations_url":"https://api.github.com/users/selvagsz/orgs","repos_url":"https://api.github.com/users/selvagsz/repos","events_url":"https://api.github.com/users/selvagsz/events{/privacy}","received_events_url":"https://api.github.com/users/selvagsz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/selvagsz/ember-cli","description":"","fork":true,"url":"https://api.github.com/repos/selvagsz/ember-cli","forks_url":"https://api.github.com/repos/selvagsz/ember-cli/forks","keys_url":"https://api.github.com/repos/selvagsz/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/selvagsz/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/selvagsz/ember-cli/teams","hooks_url":"https://api.github.com/repos/selvagsz/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/selvagsz/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/selvagsz/ember-cli/events","assignees_url":"https://api.github.com/repos/selvagsz/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/selvagsz/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/selvagsz/ember-cli/tags","blobs_url":"https://api.github.com/repos/selvagsz/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/selvagsz/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/selvagsz/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/selvagsz/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/selvagsz/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/selvagsz/ember-cli/languages","stargazers_url":"https://api.github.com/repos/selvagsz/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/selvagsz/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/selvagsz/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/selvagsz/ember-cli/subscription","commits_url":"https://api.github.com/repos/selvagsz/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/selvagsz/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/selvagsz/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/selvagsz/ember-cli/issues/comments/{number}","contents_url":"https://api.github.com/repos/selvagsz/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/selvagsz/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/selvagsz/ember-cli/merges","archive_url":"https://api.github.com/repos/selvagsz/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/selvagsz/ember-cli/downloads","issues_url":"https://api.github.com/repos/selvagsz/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/selvagsz/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/selvagsz/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/selvagsz/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/selvagsz/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/selvagsz/ember-cli/releases{/id}","created_at":"2014-04-19T12:13:39Z","updated_at":"2014-08-12T15:05:03Z","pushed_at":"2014-08-21T06:26:11Z","git_url":"git://github.com/selvagsz/ember-cli.git","ssh_url":"git@github.com:selvagsz/ember-cli.git","clone_url":"https://github.com/selvagsz/ember-cli.git","svn_url":"https://github.com/selvagsz/ember-cli","homepage":null,"size":2167,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"stefanpenner:master","ref":"master","sha":"a7fdf14718f3bb0e747347fd7550419aadbf4dbf","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=2","gravatar_id":"8ccebbc3d28f903d5c214efd3447ac71","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"repo":{"id":14089735,"name":"ember-cli","full_name":"stefanpenner/ember-cli","owner":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=2","gravatar_id":"8ccebbc3d28f903d5c214efd3447ac71","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanpenner/ember-cli","description":"","fork":false,"url":"https://api.github.com/repos/stefanpenner/ember-cli","forks_url":"https://api.github.com/repos/stefanpenner/ember-cli/forks","keys_url":"https://api.github.com/repos/stefanpenner/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanpenner/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanpenner/ember-cli/teams","hooks_url":"https://api.github.com/repos/stefanpenner/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/stefanpenner/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/stefanpenner/ember-cli/events","assignees_url":"https://api.github.com/repos/stefanpenner/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/stefanpenner/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/stefanpenner/ember-cli/tags","blobs_url":"https://api.github.com/repos/stefanpenner/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanpenner/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanpenner/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanpenner/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanpenner/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanpenner/ember-cli/languages","stargazers_url":"https://api.github.com/repos/stefanpenner/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/stefanpenner/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/stefanpenner/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/stefanpenner/ember-cli/subscription","commits_url":"https://api.github.com/repos/stefanpenner/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanpenner/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanpenner/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanpenner/ember-cli/issues/comments/{number}","contents_url":"https://api.github.com/repos/stefanpenner/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/stefanpenner/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanpenner/ember-cli/merges","archive_url":"https://api.github.com/repos/stefanpenner/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanpenner/ember-cli/downloads","issues_url":"https://api.github.com/repos/stefanpenner/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/stefanpenner/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanpenner/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanpenner/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanpenner/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/stefanpenner/ember-cli/releases{/id}","created_at":"2013-11-03T17:34:43Z","updated_at":"2014-08-20T21:56:16Z","pushed_at":"2014-08-21T00:22:25Z","git_url":"git://github.com/stefanpenner/ember-cli.git","ssh_url":"git@github.com:stefanpenner/ember-cli.git","clone_url":"https://github.com/stefanpenner/ember-cli.git","svn_url":"https://github.com/stefanpenner/ember-cli","homepage":"http:/www.ember-cli.com/","size":25083,"stargazers_count":1000,"watchers_count":1000,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":288,"mirror_url":null,"open_issues_count":92,"forks":288,"open_issues":92,"watchers":1000,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1715"},"html":{"href":"https://github.com/stefanpenner/ember-cli/pull/1715"},"issue":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/issues/1715"},"comments":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/issues/1715/comments"},"review_comments":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1715/comments"},"review_comment":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/pulls/1715/commits"},"statuses":{"href":"https://api.github.com/repos/stefanpenner/ember-cli/statuses/10b3d9f4972fda64f4653354f4a7a16c5ff9c833"}}}}