GitHub PullRequestReviewCommentEvent at 2014-06-19 18:16:13
Repository: entity_embed
Actor: cs-shadow
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/drupal-media/entity_embed/pulls/comments/13984325","id":13984325,"diff_hunk":"@@ -33,6 +36,44 @@\n         }\n       });\n \n+      // Register the entity embed widget.\n+      editor.widgets.add('entityembed', {\n+        // Minimum HTML which is required by this widget to work.\n+        requiredContent: 'div[data-entity-type,data-entity-uuid]',\n+\n+        // Add entity embed button\n+        button: 'Insert entity',\n+\n+        // Generate the preview of the element and render it.\n+        upcast: function (element) {\n+          var attributes = element.attributes;\n+          if (element.name != 'div') {","path":"js/plugins/entityembed/plugin.js","position":25,"original_position":25,"commit_id":"31b442b38941e47c6f5633f2c7fadd1843a0ac35","original_commit_id":"31b442b38941e47c6f5633f2c7fadd1843a0ac35","user":{"login":"cs-shadow","id":2458024,"avatar_url":"https://avatars.githubusercontent.com/u/2458024?","gravatar_id":"1cb04621cff4dee0672597efba12d924","url":"https://api.github.com/users/cs-shadow","html_url":"https://github.com/cs-shadow","followers_url":"https://api.github.com/users/cs-shadow/followers","following_url":"https://api.github.com/users/cs-shadow/following{/other_user}","gists_url":"https://api.github.com/users/cs-shadow/gists{/gist_id}","starred_url":"https://api.github.com/users/cs-shadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs-shadow/subscriptions","organizations_url":"https://api.github.com/users/cs-shadow/orgs","repos_url":"https://api.github.com/users/cs-shadow/repos","events_url":"https://api.github.com/users/cs-shadow/events{/privacy}","received_events_url":"https://api.github.com/users/cs-shadow/received_events","type":"User","site_admin":false},"body":"I see, Will remove that check then.\r\n\r\n(@slashrsm, use backtick to wrap html, otherwise its just a bunch commas and fullstops.)","created_at":"2014-06-19T18:16:13Z","updated_at":"2014-06-19T18:16:13Z","html_url":"https://github.com/drupal-media/entity_embed/pull/52#discussion_r13984325","pull_request_url":"https://api.github.com/repos/drupal-media/entity_embed/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/drupal-media/entity_embed/pulls/comments/13984325"},"html":{"href":"https://github.com/drupal-media/entity_embed/pull/52#discussion_r13984325"},"pull_request":{"href":"https://api.github.com/repos/drupal-media/entity_embed/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/drupal-media/entity_embed/pulls/52","id":17251134,"html_url":"https://github.com/drupal-media/entity_embed/pull/52","diff_url":"https://github.com/drupal-media/entity_embed/pull/52.diff","patch_url":"https://github.com/drupal-media/entity_embed/pull/52.patch","issue_url":"https://api.github.com/repos/drupal-media/entity_embed/issues/52","number":52,"state":"open","title":"Add a preview for the selected entity in WYSIWYG","user":{"login":"cs-shadow","id":2458024,"avatar_url":"https://avatars.githubusercontent.com/u/2458024?","gravatar_id":"1cb04621cff4dee0672597efba12d924","url":"https://api.github.com/users/cs-shadow","html_url":"https://github.com/cs-shadow","followers_url":"https://api.github.com/users/cs-shadow/followers","following_url":"https://api.github.com/users/cs-shadow/following{/other_user}","gists_url":"https://api.github.com/users/cs-shadow/gists{/gist_id}","starred_url":"https://api.github.com/users/cs-shadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs-shadow/subscriptions","organizations_url":"https://api.github.com/users/cs-shadow/orgs","repos_url":"https://api.github.com/users/cs-shadow/repos","events_url":"https://api.github.com/users/cs-shadow/events{/privacy}","received_events_url":"https://api.github.com/users/cs-shadow/received_events","type":"User","site_admin":false},"body":"d.o issue: https://drupal.org/node/2280547","created_at":"2014-06-17T17:57:55Z","updated_at":"2014-06-19T18:16:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"887ea4007bd5fd6597f0bcbccce33ae4623702ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/drupal-media/entity_embed/pulls/52/commits","review_comments_url":"https://api.github.com/repos/drupal-media/entity_embed/pulls/52/comments","review_comment_url":"https://api.github.com/repos/drupal-media/entity_embed/pulls/comments/{number}","comments_url":"https://api.github.com/repos/drupal-media/entity_embed/issues/52/comments","statuses_url":"https://api.github.com/repos/drupal-media/entity_embed/statuses/31b442b38941e47c6f5633f2c7fadd1843a0ac35","head":{"label":"cs-shadow:preview","ref":"preview","sha":"31b442b38941e47c6f5633f2c7fadd1843a0ac35","user":{"login":"cs-shadow","id":2458024,"avatar_url":"https://avatars.githubusercontent.com/u/2458024?","gravatar_id":"1cb04621cff4dee0672597efba12d924","url":"https://api.github.com/users/cs-shadow","html_url":"https://github.com/cs-shadow","followers_url":"https://api.github.com/users/cs-shadow/followers","following_url":"https://api.github.com/users/cs-shadow/following{/other_user}","gists_url":"https://api.github.com/users/cs-shadow/gists{/gist_id}","starred_url":"https://api.github.com/users/cs-shadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs-shadow/subscriptions","organizations_url":"https://api.github.com/users/cs-shadow/orgs","repos_url":"https://api.github.com/users/cs-shadow/repos","events_url":"https://api.github.com/users/cs-shadow/events{/privacy}","received_events_url":"https://api.github.com/users/cs-shadow/received_events","type":"User","site_admin":false},"repo":{"id":19744974,"name":"entity_embed","full_name":"cs-shadow/entity_embed","owner":{"login":"cs-shadow","id":2458024,"avatar_url":"https://avatars.githubusercontent.com/u/2458024?","gravatar_id":"1cb04621cff4dee0672597efba12d924","url":"https://api.github.com/users/cs-shadow","html_url":"https://github.com/cs-shadow","followers_url":"https://api.github.com/users/cs-shadow/followers","following_url":"https://api.github.com/users/cs-shadow/following{/other_user}","gists_url":"https://api.github.com/users/cs-shadow/gists{/gist_id}","starred_url":"https://api.github.com/users/cs-shadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs-shadow/subscriptions","organizations_url":"https://api.github.com/users/cs-shadow/orgs","repos_url":"https://api.github.com/users/cs-shadow/repos","events_url":"https://api.github.com/users/cs-shadow/events{/privacy}","received_events_url":"https://api.github.com/users/cs-shadow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cs-shadow/entity_embed","description":"Allows any entity to be embedded using a WYSIWYG and text format","fork":true,"url":"https://api.github.com/repos/cs-shadow/entity_embed","forks_url":"https://api.github.com/repos/cs-shadow/entity_embed/forks","keys_url":"https://api.github.com/repos/cs-shadow/entity_embed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cs-shadow/entity_embed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cs-shadow/entity_embed/teams","hooks_url":"https://api.github.com/repos/cs-shadow/entity_embed/hooks","issue_events_url":"https://api.github.com/repos/cs-shadow/entity_embed/issues/events{/number}","events_url":"https://api.github.com/repos/cs-shadow/entity_embed/events","assignees_url":"https://api.github.com/repos/cs-shadow/entity_embed/assignees{/user}","branches_url":"https://api.github.com/repos/cs-shadow/entity_embed/branches{/branch}","tags_url":"https://api.github.com/repos/cs-shadow/entity_embed/tags","blobs_url":"https://api.github.com/repos/cs-shadow/entity_embed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cs-shadow/entity_embed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cs-shadow/entity_embed/git/refs{/sha}","trees_url":"https://api.github.com/repos/cs-shadow/entity_embed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cs-shadow/entity_embed/statuses/{sha}","languages_url":"https://api.github.com/repos/cs-shadow/entity_embed/languages","stargazers_url":"https://api.github.com/repos/cs-shadow/entity_embed/stargazers","contributors_url":"https://api.github.com/repos/cs-shadow/entity_embed/contributors","subscribers_url":"https://api.github.com/repos/cs-shadow/entity_embed/subscribers","subscription_url":"https://api.github.com/repos/cs-shadow/entity_embed/subscription","commits_url":"https://api.github.com/repos/cs-shadow/entity_embed/commits{/sha}","git_commits_url":"https://api.github.com/repos/cs-shadow/entity_embed/git/commits{/sha}","comments_url":"https://api.github.com/repos/cs-shadow/entity_embed/comments{/number}","issue_comment_url":"https://api.github.com/repos/cs-shadow/entity_embed/issues/comments/{number}","contents_url":"https://api.github.com/repos/cs-shadow/entity_embed/contents/{+path}","compare_url":"https://api.github.com/repos/cs-shadow/entity_embed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cs-shadow/entity_embed/merges","archive_url":"https://api.github.com/repos/cs-shadow/entity_embed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cs-shadow/entity_embed/downloads","issues_url":"https://api.github.com/repos/cs-shadow/entity_embed/issues{/number}","pulls_url":"https://api.github.com/repos/cs-shadow/entity_embed/pulls{/number}","milestones_url":"https://api.github.com/repos/cs-shadow/entity_embed/milestones{/number}","notifications_url":"https://api.github.com/repos/cs-shadow/entity_embed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cs-shadow/entity_embed/labels{/name}","releases_url":"https://api.github.com/repos/cs-shadow/entity_embed/releases{/id}","created_at":"2014-05-13T15:37:58Z","updated_at":"2014-06-19T18:10:49Z","pushed_at":"2014-06-19T18:10:50Z","git_url":"git://github.com/cs-shadow/entity_embed.git","ssh_url":"git@github.com:cs-shadow/entity_embed.git","clone_url":"https://github.com/cs-shadow/entity_embed.git","svn_url":"https://github.com/cs-shadow/entity_embed","homepage":null,"size":1181,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x-1.x"}},"base":{"label":"drupal-media:8.x-1.x","ref":"8.x-1.x","sha":"3ed6c746d3bb121f5fe64eafd2ef1d5cd5dba381","user":{"login":"drupal-media","id":7276699,"avatar_url":"https://avatars.githubusercontent.com/u/7276699?","gravatar_id":null,"url":"https://api.github.com/users/drupal-media","html_url":"https://github.com/drupal-media","followers_url":"https://api.github.com/users/drupal-media/followers","following_url":"https://api.github.com/users/drupal-media/following{/other_user}","gists_url":"https://api.github.com/users/drupal-media/gists{/gist_id}","starred_url":"https://api.github.com/users/drupal-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupal-media/subscriptions","organizations_url":"https://api.github.com/users/drupal-media/orgs","repos_url":"https://api.github.com/users/drupal-media/repos","events_url":"https://api.github.com/users/drupal-media/events{/privacy}","received_events_url":"https://api.github.com/users/drupal-media/received_events","type":"Organization","site_admin":false},"repo":{"id":18717762,"name":"entity_embed","full_name":"drupal-media/entity_embed","owner":{"login":"drupal-media","id":7276699,"avatar_url":"https://avatars.githubusercontent.com/u/7276699?","gravatar_id":null,"url":"https://api.github.com/users/drupal-media","html_url":"https://github.com/drupal-media","followers_url":"https://api.github.com/users/drupal-media/followers","following_url":"https://api.github.com/users/drupal-media/following{/other_user}","gists_url":"https://api.github.com/users/drupal-media/gists{/gist_id}","starred_url":"https://api.github.com/users/drupal-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupal-media/subscriptions","organizations_url":"https://api.github.com/users/drupal-media/orgs","repos_url":"https://api.github.com/users/drupal-media/repos","events_url":"https://api.github.com/users/drupal-media/events{/privacy}","received_events_url":"https://api.github.com/users/drupal-media/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drupal-media/entity_embed","description":"Allows any entity to be embedded using a WYSIWYG and text format","fork":false,"url":"https://api.github.com/repos/drupal-media/entity_embed","forks_url":"https://api.github.com/repos/drupal-media/entity_embed/forks","keys_url":"https://api.github.com/repos/drupal-media/entity_embed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drupal-media/entity_embed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drupal-media/entity_embed/teams","hooks_url":"https://api.github.com/repos/drupal-media/entity_embed/hooks","issue_events_url":"https://api.github.com/repos/drupal-media/entity_embed/issues/events{/number}","events_url":"https://api.github.com/repos/drupal-media/entity_embed/events","assignees_url":"https://api.github.com/repos/drupal-media/entity_embed/assignees{/user}","branches_url":"https://api.github.com/repos/drupal-media/entity_embed/branches{/branch}","tags_url":"https://api.github.com/repos/drupal-media/entity_embed/tags","blobs_url":"https://api.github.com/repos/drupal-media/entity_embed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drupal-media/entity_embed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drupal-media/entity_embed/git/refs{/sha}","trees_url":"https://api.github.com/repos/drupal-media/entity_embed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drupal-media/entity_embed/statuses/{sha}","languages_url":"https://api.github.com/repos/drupal-media/entity_embed/languages","stargazers_url":"https://api.github.com/repos/drupal-media/entity_embed/stargazers","contributors_url":"https://api.github.com/repos/drupal-media/entity_embed/contributors","subscribers_url":"https://api.github.com/repos/drupal-media/entity_embed/subscribers","subscription_url":"https://api.github.com/repos/drupal-media/entity_embed/subscription","commits_url":"https://api.github.com/repos/drupal-media/entity_embed/commits{/sha}","git_commits_url":"https://api.github.com/repos/drupal-media/entity_embed/git/commits{/sha}","comments_url":"https://api.github.com/repos/drupal-media/entity_embed/comments{/number}","issue_comment_url":"https://api.github.com/repos/drupal-media/entity_embed/issues/comments/{number}","contents_url":"https://api.github.com/repos/drupal-media/entity_embed/contents/{+path}","compare_url":"https://api.github.com/repos/drupal-media/entity_embed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drupal-media/entity_embed/merges","archive_url":"https://api.github.com/repos/drupal-media/entity_embed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drupal-media/entity_embed/downloads","issues_url":"https://api.github.com/repos/drupal-media/entity_embed/issues{/number}","pulls_url":"https://api.github.com/repos/drupal-media/entity_embed/pulls{/number}","milestones_url":"https://api.github.com/repos/drupal-media/entity_embed/milestones{/number}","notifications_url":"https://api.github.com/repos/drupal-media/entity_embed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drupal-media/entity_embed/labels{/name}","releases_url":"https://api.github.com/repos/drupal-media/entity_embed/releases{/id}","created_at":"2014-04-13T00:08:52Z","updated_at":"2014-06-19T14:56:48Z","pushed_at":"2014-06-19T14:56:48Z","git_url":"git://github.com/drupal-media/entity_embed.git","ssh_url":"git@github.com:drupal-media/entity_embed.git","clone_url":"https://github.com/drupal-media/entity_embed.git","svn_url":"https://github.com/drupal-media/entity_embed","homepage":null,"size":2266,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":6,"default_branch":"8.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/drupal-media/entity_embed/pulls/52"},"html":{"href":"https://github.com/drupal-media/entity_embed/pull/52"},"issue":{"href":"https://api.github.com/repos/drupal-media/entity_embed/issues/52"},"comments":{"href":"https://api.github.com/repos/drupal-media/entity_embed/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/drupal-media/entity_embed/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/drupal-media/entity_embed/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/drupal-media/entity_embed/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/drupal-media/entity_embed/statuses/31b442b38941e47c6f5633f2c7fadd1843a0ac35"}}}}