GitHub PullRequestEvent at 2014-07-10 07:49:26
Repository: liferay-plugins
Actor: hhuijser
Payload: {"action":"closed","number":210,"pull_request":{"url":"https://api.github.com/repos/hhuijser/liferay-plugins/pulls/210","id":18203540,"html_url":"https://github.com/hhuijser/liferay-plugins/pull/210","diff_url":"https://github.com/hhuijser/liferay-plugins/pull/210.diff","patch_url":"https://github.com/hhuijser/liferay-plugins/pull/210.patch","issue_url":"https://api.github.com/repos/hhuijser/liferay-plugins/issues/210","number":210,"state":"closed","title":"Lps 48297","user":{"login":"zxdgoal","id":4162471,"avatar_url":"https://avatars.githubusercontent.com/u/4162471?","gravatar_id":"4119177f35016ccf62d754146d0e0dcd","url":"https://api.github.com/users/zxdgoal","html_url":"https://github.com/zxdgoal","followers_url":"https://api.github.com/users/zxdgoal/followers","following_url":"https://api.github.com/users/zxdgoal/following{/other_user}","gists_url":"https://api.github.com/users/zxdgoal/gists{/gist_id}","starred_url":"https://api.github.com/users/zxdgoal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxdgoal/subscriptions","organizations_url":"https://api.github.com/users/zxdgoal/orgs","repos_url":"https://api.github.com/users/zxdgoal/repos","events_url":"https://api.github.com/users/zxdgoal/events{/privacy}","received_events_url":"https://api.github.com/users/zxdgoal/received_events","type":"User","site_admin":false},"body":"https://issues.liferay.com/browse/LPS-48297\r\n \r\nThe method of updatePage() in WikiPagelocalServiceUtilImpl.java will return a new page whose version is one larger than the old page's.\r\n\r\nHowever, in my view, the version of page should not be added when it is just marked as spam or not spam without reverting to its old version. So, I removed that method. Now the content can been seen after created by a user and its version is not changed after markings.\r\n\r\nI commented some lines in the code because I cannot understand why the  workflow action is save draft, which leads that the page cannot be displayed correctly after edition when it is a spam. ","created_at":"2014-07-10T07:01:28Z","updated_at":"2014-07-10T07:49:26Z","closed_at":"2014-07-10T07:49:26Z","merged_at":null,"merge_commit_sha":"734983d69a203f170c605c96f25373d269228f30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hhuijser/liferay-plugins/pulls/210/commits","review_comments_url":"https://api.github.com/repos/hhuijser/liferay-plugins/pulls/210/comments","review_comment_url":"https://api.github.com/repos/hhuijser/liferay-plugins/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hhuijser/liferay-plugins/issues/210/comments","statuses_url":"https://api.github.com/repos/hhuijser/liferay-plugins/statuses/f16a427283fb0346bc03201f515d84cf0ee696a8","head":{"label":"zxdgoal:LPS-48297","ref":"LPS-48297","sha":"f16a427283fb0346bc03201f515d84cf0ee696a8","user":{"login":"zxdgoal","id":4162471,"avatar_url":"https://avatars.githubusercontent.com/u/4162471?","gravatar_id":"4119177f35016ccf62d754146d0e0dcd","url":"https://api.github.com/users/zxdgoal","html_url":"https://github.com/zxdgoal","followers_url":"https://api.github.com/users/zxdgoal/followers","following_url":"https://api.github.com/users/zxdgoal/following{/other_user}","gists_url":"https://api.github.com/users/zxdgoal/gists{/gist_id}","starred_url":"https://api.github.com/users/zxdgoal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxdgoal/subscriptions","organizations_url":"https://api.github.com/users/zxdgoal/orgs","repos_url":"https://api.github.com/users/zxdgoal/repos","events_url":"https://api.github.com/users/zxdgoal/events{/privacy}","received_events_url":"https://api.github.com/users/zxdgoal/received_events","type":"User","site_admin":false},"repo":{"id":21025593,"name":"liferay-plugins","full_name":"zxdgoal/liferay-plugins","owner":{"login":"zxdgoal","id":4162471,"avatar_url":"https://avatars.githubusercontent.com/u/4162471?","gravatar_id":"4119177f35016ccf62d754146d0e0dcd","url":"https://api.github.com/users/zxdgoal","html_url":"https://github.com/zxdgoal","followers_url":"https://api.github.com/users/zxdgoal/followers","following_url":"https://api.github.com/users/zxdgoal/following{/other_user}","gists_url":"https://api.github.com/users/zxdgoal/gists{/gist_id}","starred_url":"https://api.github.com/users/zxdgoal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxdgoal/subscriptions","organizations_url":"https://api.github.com/users/zxdgoal/orgs","repos_url":"https://api.github.com/users/zxdgoal/repos","events_url":"https://api.github.com/users/zxdgoal/events{/privacy}","received_events_url":"https://api.github.com/users/zxdgoal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zxdgoal/liferay-plugins","description":"","fork":true,"url":"https://api.github.com/repos/zxdgoal/liferay-plugins","forks_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/forks","keys_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/teams","hooks_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/hooks","issue_events_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/events","assignees_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/tags","blobs_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/languages","stargazers_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/stargazers","contributors_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/contributors","subscribers_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/subscribers","subscription_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/subscription","commits_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/issues/comments/{number}","contents_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/merges","archive_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/downloads","issues_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/labels{/name}","releases_url":"https://api.github.com/repos/zxdgoal/liferay-plugins/releases{/id}","created_at":"2014-06-20T04:42:02Z","updated_at":"2014-06-20T04:42:09Z","pushed_at":"2014-07-10T06:37:54Z","git_url":"git://github.com/zxdgoal/liferay-plugins.git","ssh_url":"git@github.com:zxdgoal/liferay-plugins.git","clone_url":"https://github.com/zxdgoal/liferay-plugins.git","svn_url":"https://github.com/zxdgoal/liferay-plugins","homepage":"","size":1272353,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hhuijser:master","ref":"master","sha":"13a20b9d3db1b84c4022f6462fcce355d99a7da6","user":{"login":"hhuijser","id":862245,"avatar_url":"https://avatars.githubusercontent.com/u/862245?","gravatar_id":"da2cd23d88e5869f5417409eacc2d89e","url":"https://api.github.com/users/hhuijser","html_url":"https://github.com/hhuijser","followers_url":"https://api.github.com/users/hhuijser/followers","following_url":"https://api.github.com/users/hhuijser/following{/other_user}","gists_url":"https://api.github.com/users/hhuijser/gists{/gist_id}","starred_url":"https://api.github.com/users/hhuijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhuijser/subscriptions","organizations_url":"https://api.github.com/users/hhuijser/orgs","repos_url":"https://api.github.com/users/hhuijser/repos","events_url":"https://api.github.com/users/hhuijser/events{/privacy}","received_events_url":"https://api.github.com/users/hhuijser/received_events","type":"User","site_admin":false},"repo":{"id":2032654,"name":"liferay-plugins","full_name":"hhuijser/liferay-plugins","owner":{"login":"hhuijser","id":862245,"avatar_url":"https://avatars.githubusercontent.com/u/862245?","gravatar_id":"da2cd23d88e5869f5417409eacc2d89e","url":"https://api.github.com/users/hhuijser","html_url":"https://github.com/hhuijser","followers_url":"https://api.github.com/users/hhuijser/followers","following_url":"https://api.github.com/users/hhuijser/following{/other_user}","gists_url":"https://api.github.com/users/hhuijser/gists{/gist_id}","starred_url":"https://api.github.com/users/hhuijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhuijser/subscriptions","organizations_url":"https://api.github.com/users/hhuijser/orgs","repos_url":"https://api.github.com/users/hhuijser/repos","events_url":"https://api.github.com/users/hhuijser/events{/privacy}","received_events_url":"https://api.github.com/users/hhuijser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hhuijser/liferay-plugins","description":"","fork":true,"url":"https://api.github.com/repos/hhuijser/liferay-plugins","forks_url":"https://api.github.com/repos/hhuijser/liferay-plugins/forks","keys_url":"https://api.github.com/repos/hhuijser/liferay-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhuijser/liferay-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhuijser/liferay-plugins/teams","hooks_url":"https://api.github.com/repos/hhuijser/liferay-plugins/hooks","issue_events_url":"https://api.github.com/repos/hhuijser/liferay-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/hhuijser/liferay-plugins/events","assignees_url":"https://api.github.com/repos/hhuijser/liferay-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/hhuijser/liferay-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/hhuijser/liferay-plugins/tags","blobs_url":"https://api.github.com/repos/hhuijser/liferay-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhuijser/liferay-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhuijser/liferay-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhuijser/liferay-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhuijser/liferay-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/hhuijser/liferay-plugins/languages","stargazers_url":"https://api.github.com/repos/hhuijser/liferay-plugins/stargazers","contributors_url":"https://api.github.com/repos/hhuijser/liferay-plugins/contributors","subscribers_url":"https://api.github.com/repos/hhuijser/liferay-plugins/subscribers","subscription_url":"https://api.github.com/repos/hhuijser/liferay-plugins/subscription","commits_url":"https://api.github.com/repos/hhuijser/liferay-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhuijser/liferay-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhuijser/liferay-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhuijser/liferay-plugins/issues/comments/{number}","contents_url":"https://api.github.com/repos/hhuijser/liferay-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/hhuijser/liferay-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhuijser/liferay-plugins/merges","archive_url":"https://api.github.com/repos/hhuijser/liferay-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhuijser/liferay-plugins/downloads","issues_url":"https://api.github.com/repos/hhuijser/liferay-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/hhuijser/liferay-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/hhuijser/liferay-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/hhuijser/liferay-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhuijser/liferay-plugins/labels{/name}","releases_url":"https://api.github.com/repos/hhuijser/liferay-plugins/releases{/id}","created_at":"2011-07-11T21:04:34Z","updated_at":"2014-06-26T03:22:25Z","pushed_at":"2014-07-09T04:55:02Z","git_url":"git://github.com/hhuijser/liferay-plugins.git","ssh_url":"git@github.com:hhuijser/liferay-plugins.git","clone_url":"https://github.com/hhuijser/liferay-plugins.git","svn_url":"https://github.com/hhuijser/liferay-plugins","homepage":"","size":1238501,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hhuijser/liferay-plugins/pulls/210"},"html":{"href":"https://github.com/hhuijser/liferay-plugins/pull/210"},"issue":{"href":"https://api.github.com/repos/hhuijser/liferay-plugins/issues/210"},"comments":{"href":"https://api.github.com/repos/hhuijser/liferay-plugins/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/hhuijser/liferay-plugins/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/hhuijser/liferay-plugins/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hhuijser/liferay-plugins/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/hhuijser/liferay-plugins/statuses/f16a427283fb0346bc03201f515d84cf0ee696a8"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":3,"additions":12,"deletions":27,"changed_files":3}}