GitHub PullRequestReviewCommentEvent at 2014-10-01 23:42:03
Repository: floats
Actor: kortschak
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/gonum/floats/pulls/comments/18315553","id":18315553,"diff_hunk":"@@ -359,6 +387,8 @@ func Fill(f func() float64, s []float64) {\n // found indices to inds.\n // If k > 0 and there are fewer than k elements in s satisfying f,\n // all of the found elements will be returned along with an error.\n+// Note that the elements of the input inds will be modified, but you should","path":"floats.go","position":251,"original_position":251,"commit_id":"a60bb67e33a77663bbec34a2c21aea868b3b119e","original_commit_id":"a60bb67e33a77663bbec34a2c21aea868b3b119e","user":{"login":"kortschak","id":275221,"avatar_url":"https://avatars.githubusercontent.com/u/275221?v=2","gravatar_id":"","url":"https://api.github.com/users/kortschak","html_url":"https://github.com/kortschak","followers_url":"https://api.github.com/users/kortschak/followers","following_url":"https://api.github.com/users/kortschak/following{/other_user}","gists_url":"https://api.github.com/users/kortschak/gists{/gist_id}","starred_url":"https://api.github.com/users/kortschak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kortschak/subscriptions","organizations_url":"https://api.github.com/users/kortschak/orgs","repos_url":"https://api.github.com/users/kortschak/repos","events_url":"https://api.github.com/users/kortschak/events{/privacy}","received_events_url":"https://api.github.com/users/kortschak/received_events","type":"User","site_admin":false},"body":"\"The caller should store the index result as a new slice may be allocated.\"\r\n\r\n(see text from builtin/append)","created_at":"2014-10-01T23:42:03Z","updated_at":"2014-10-01T23:42:03Z","html_url":"https://github.com/gonum/floats/pull/10#discussion_r18315553","pull_request_url":"https://api.github.com/repos/gonum/floats/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/gonum/floats/pulls/comments/18315553"},"html":{"href":"https://github.com/gonum/floats/pull/10#discussion_r18315553"},"pull_request":{"href":"https://api.github.com/repos/gonum/floats/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/gonum/floats/pulls/10","id":22111481,"html_url":"https://github.com/gonum/floats/pull/10","diff_url":"https://github.com/gonum/floats/pull/10.diff","patch_url":"https://github.com/gonum/floats/pull/10.patch","issue_url":"https://api.github.com/repos/gonum/floats/issues/10","number":10,"state":"open","locked":false,"title":"Improve docs, and make the variable names consistent","user":{"login":"jonlawlor","id":4468162,"avatar_url":"https://avatars.githubusercontent.com/u/4468162?v=2","gravatar_id":"","url":"https://api.github.com/users/jonlawlor","html_url":"https://github.com/jonlawlor","followers_url":"https://api.github.com/users/jonlawlor/followers","following_url":"https://api.github.com/users/jonlawlor/following{/other_user}","gists_url":"https://api.github.com/users/jonlawlor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonlawlor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonlawlor/subscriptions","organizations_url":"https://api.github.com/users/jonlawlor/orgs","repos_url":"https://api.github.com/users/jonlawlor/repos","events_url":"https://api.github.com/users/jonlawlor/events{/privacy}","received_events_url":"https://api.github.com/users/jonlawlor/received_events","type":"User","site_admin":false},"body":"Expanded most of the documentation, and renamed some of the variables\r\nso that variables that are mutated are (almost) always called dst.","created_at":"2014-10-01T23:14:44Z","updated_at":"2014-10-01T23:42:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"751ba0a896a8832dfa48672efc22dd33e29a1977","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gonum/floats/pulls/10/commits","review_comments_url":"https://api.github.com/repos/gonum/floats/pulls/10/comments","review_comment_url":"https://api.github.com/repos/gonum/floats/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gonum/floats/issues/10/comments","statuses_url":"https://api.github.com/repos/gonum/floats/statuses/a60bb67e33a77663bbec34a2c21aea868b3b119e","head":{"label":"gonum:improve-docs-and-unify-vars","ref":"improve-docs-and-unify-vars","sha":"a60bb67e33a77663bbec34a2c21aea868b3b119e","user":{"login":"gonum","id":3771091,"avatar_url":"https://avatars.githubusercontent.com/u/3771091?v=2","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"repo":{"id":11395800,"name":"floats","full_name":"gonum/floats","owner":{"login":"gonum","id":3771091,"avatar_url":"https://avatars.githubusercontent.com/u/3771091?v=2","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gonum/floats","description":"Operations on slices of floats","fork":false,"url":"https://api.github.com/repos/gonum/floats","forks_url":"https://api.github.com/repos/gonum/floats/forks","keys_url":"https://api.github.com/repos/gonum/floats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonum/floats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonum/floats/teams","hooks_url":"https://api.github.com/repos/gonum/floats/hooks","issue_events_url":"https://api.github.com/repos/gonum/floats/issues/events{/number}","events_url":"https://api.github.com/repos/gonum/floats/events","assignees_url":"https://api.github.com/repos/gonum/floats/assignees{/user}","branches_url":"https://api.github.com/repos/gonum/floats/branches{/branch}","tags_url":"https://api.github.com/repos/gonum/floats/tags","blobs_url":"https://api.github.com/repos/gonum/floats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonum/floats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonum/floats/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonum/floats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonum/floats/statuses/{sha}","languages_url":"https://api.github.com/repos/gonum/floats/languages","stargazers_url":"https://api.github.com/repos/gonum/floats/stargazers","contributors_url":"https://api.github.com/repos/gonum/floats/contributors","subscribers_url":"https://api.github.com/repos/gonum/floats/subscribers","subscription_url":"https://api.github.com/repos/gonum/floats/subscription","commits_url":"https://api.github.com/repos/gonum/floats/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonum/floats/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonum/floats/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonum/floats/issues/comments/{number}","contents_url":"https://api.github.com/repos/gonum/floats/contents/{+path}","compare_url":"https://api.github.com/repos/gonum/floats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonum/floats/merges","archive_url":"https://api.github.com/repos/gonum/floats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonum/floats/downloads","issues_url":"https://api.github.com/repos/gonum/floats/issues{/number}","pulls_url":"https://api.github.com/repos/gonum/floats/pulls{/number}","milestones_url":"https://api.github.com/repos/gonum/floats/milestones{/number}","notifications_url":"https://api.github.com/repos/gonum/floats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonum/floats/labels{/name}","releases_url":"https://api.github.com/repos/gonum/floats/releases{/id}","created_at":"2013-07-13T23:41:30Z","updated_at":"2014-09-15T12:26:11Z","pushed_at":"2014-10-01T23:13:49Z","git_url":"git://github.com/gonum/floats.git","ssh_url":"git@github.com:gonum/floats.git","clone_url":"https://github.com/gonum/floats.git","svn_url":"https://github.com/gonum/floats","homepage":"","size":506,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"gonum:master","ref":"master","sha":"fe067ba1d8846096db24b99d2a60a46123a079bf","user":{"login":"gonum","id":3771091,"avatar_url":"https://avatars.githubusercontent.com/u/3771091?v=2","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"repo":{"id":11395800,"name":"floats","full_name":"gonum/floats","owner":{"login":"gonum","id":3771091,"avatar_url":"https://avatars.githubusercontent.com/u/3771091?v=2","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gonum/floats","description":"Operations on slices of floats","fork":false,"url":"https://api.github.com/repos/gonum/floats","forks_url":"https://api.github.com/repos/gonum/floats/forks","keys_url":"https://api.github.com/repos/gonum/floats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonum/floats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonum/floats/teams","hooks_url":"https://api.github.com/repos/gonum/floats/hooks","issue_events_url":"https://api.github.com/repos/gonum/floats/issues/events{/number}","events_url":"https://api.github.com/repos/gonum/floats/events","assignees_url":"https://api.github.com/repos/gonum/floats/assignees{/user}","branches_url":"https://api.github.com/repos/gonum/floats/branches{/branch}","tags_url":"https://api.github.com/repos/gonum/floats/tags","blobs_url":"https://api.github.com/repos/gonum/floats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonum/floats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonum/floats/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonum/floats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonum/floats/statuses/{sha}","languages_url":"https://api.github.com/repos/gonum/floats/languages","stargazers_url":"https://api.github.com/repos/gonum/floats/stargazers","contributors_url":"https://api.github.com/repos/gonum/floats/contributors","subscribers_url":"https://api.github.com/repos/gonum/floats/subscribers","subscription_url":"https://api.github.com/repos/gonum/floats/subscription","commits_url":"https://api.github.com/repos/gonum/floats/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonum/floats/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonum/floats/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonum/floats/issues/comments/{number}","contents_url":"https://api.github.com/repos/gonum/floats/contents/{+path}","compare_url":"https://api.github.com/repos/gonum/floats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonum/floats/merges","archive_url":"https://api.github.com/repos/gonum/floats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonum/floats/downloads","issues_url":"https://api.github.com/repos/gonum/floats/issues{/number}","pulls_url":"https://api.github.com/repos/gonum/floats/pulls{/number}","milestones_url":"https://api.github.com/repos/gonum/floats/milestones{/number}","notifications_url":"https://api.github.com/repos/gonum/floats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonum/floats/labels{/name}","releases_url":"https://api.github.com/repos/gonum/floats/releases{/id}","created_at":"2013-07-13T23:41:30Z","updated_at":"2014-09-15T12:26:11Z","pushed_at":"2014-10-01T23:13:49Z","git_url":"git://github.com/gonum/floats.git","ssh_url":"git@github.com:gonum/floats.git","clone_url":"https://github.com/gonum/floats.git","svn_url":"https://github.com/gonum/floats","homepage":"","size":506,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gonum/floats/pulls/10"},"html":{"href":"https://github.com/gonum/floats/pull/10"},"issue":{"href":"https://api.github.com/repos/gonum/floats/issues/10"},"comments":{"href":"https://api.github.com/repos/gonum/floats/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/gonum/floats/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/gonum/floats/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gonum/floats/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/gonum/floats/statuses/a60bb67e33a77663bbec34a2c21aea868b3b119e"}}}}