GitHub PullRequestReviewCommentEvent at 2014-03-07 13:22:07
Repository: sequelize
Actor: mickhansen
Payload: {"comment":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments/10382499","id":10382499,"diff_hunk":"@@ -76,53 +79,80 @@ Validator.extend('is', function(str, pattern, modifiers) {\n   return this.regex(str, pattern, modifiers);\n })\n \n-\n-var DaoValidator = module.exports = function(modelInstance, options) {\n-  options = options || {}\n-  options.skip = options.skip || []\n+/**\n+ * The Main DAO Validator.\n+ *\n+ * @param {sequelize.Model} modelInstance The model instance.\n+ * @param {Object=} optOptions A dict with options.\n+ * @constructor\n+ */\n+var DaoValidator = module.exports = function(modelInstance, optOptions) {","path":"lib/dao-validator.js","position":25,"original_position":25,"commit_id":"90c2e5c0677dc62bdb915772af10c7e677528e95","original_commit_id":"aaa1eb3cf7253c6464c541c6f3be55daf35fe21c","user":{"login":"mickhansen","id":699049,"avatar_url":"https://gravatar.com/avatar/8232088deccefbd3b48d63b6cec6a09d?d=https%3A%2F%2Fidenticons.github.com%2F418f3aeb5ca772053b40e20950ad7c9e.png&r=x","gravatar_id":"8232088deccefbd3b48d63b6cec6a09d","url":"https://api.github.com/users/mickhansen","html_url":"https://github.com/mickhansen","followers_url":"https://api.github.com/users/mickhansen/followers","following_url":"https://api.github.com/users/mickhansen/following{/other_user}","gists_url":"https://api.github.com/users/mickhansen/gists{/gist_id}","starred_url":"https://api.github.com/users/mickhansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickhansen/subscriptions","organizations_url":"https://api.github.com/users/mickhansen/orgs","repos_url":"https://api.github.com/users/mickhansen/repos","events_url":"https://api.github.com/users/mickhansen/events{/privacy}","received_events_url":"https://api.github.com/users/mickhansen/received_events","type":"User","site_admin":false},"body":"Yeah it's probably optional, but usually we just call it 'options' anyways :)","created_at":"2014-03-07T13:22:07Z","updated_at":"2014-03-07T13:22:07Z","html_url":"https://github.com/sequelize/sequelize/pull/1476#discussion_r10382499","pull_request_url":"https://api.github.com/repos/sequelize/sequelize/pulls/1476","_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments/10382499"},"html":{"href":"https://github.com/sequelize/sequelize/pull/1476#discussion_r10382499"},"pull_request":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/1476"}}}}