GitHub PullRequestReviewCommentEvent at 2014-12-28 18:59:53
Repository: rust
Actor: alexcrichton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/22299453","id":22299453,"diff_hunk":"@@ -60,13 +60,15 @@ use option::Option::{mod, Some, None};\n /// Eventually, this will be implemented by default for types that implement\n /// `Eq`.","path":"src/libcore/cmp.rs","position":2,"original_position":2,"commit_id":"70f7f63eaec4d1d8509dea660a4767ac0baed403","original_commit_id":"70f7f63eaec4d1d8509dea660a4767ac0baed403","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"This clause should probably be removed for now.","created_at":"2014-12-28T18:59:53Z","updated_at":"2014-12-28T18:59:53Z","html_url":"https://github.com/rust-lang/rust/pull/20065#discussion_r22299453","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/20065","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/22299453"},"html":{"href":"https://github.com/rust-lang/rust/pull/20065#discussion_r22299453"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/20065"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/20065","id":26413491,"html_url":"https://github.com/rust-lang/rust/pull/20065","diff_url":"https://github.com/rust-lang/rust/pull/20065.diff","patch_url":"https://github.com/rust-lang/rust/pull/20065.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/20065","number":20065,"state":"open","locked":false,"title":"Stabilize cmp","user":{"login":"aturon","id":709807,"avatar_url":"https://avatars.githubusercontent.com/u/709807?v=3","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"body":"This patch marks `PartialEq`, `Eq`, `PartialOrd`, and `Ord` as\r\n`#[stable]`, as well as the majorify of manual implementaitons of these\r\ntraits. The traits match the [reform RFC](https://github.com/rust-lang/rfcs/pull/439).\r\n\r\nIn the future, many of the impls should be generalized; see #20063.\r\nHowever, there is no problem stabilizing the less general impls, since\r\ngeneralizing later is not a breaking change.\r\n\r\nr? @alexcrichton ","created_at":"2014-12-20T07:28:57Z","updated_at":"2014-12-28T18:59:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32e6b9237087a9c925a579541a90b4fd985e8b8a","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/20065/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/20065/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/20065/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/70f7f63eaec4d1d8509dea660a4767ac0baed403","head":{"label":"aturon:stab-2-cmp","ref":"stab-2-cmp","sha":"70f7f63eaec4d1d8509dea660a4767ac0baed403","user":{"login":"aturon","id":709807,"avatar_url":"https://avatars.githubusercontent.com/u/709807?v=3","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"repo":{"id":19056749,"name":"rust","full_name":"aturon/rust","owner":{"login":"aturon","id":709807,"avatar_url":"https://avatars.githubusercontent.com/u/709807?v=3","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aturon/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/aturon/rust","forks_url":"https://api.github.com/repos/aturon/rust/forks","keys_url":"https://api.github.com/repos/aturon/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aturon/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aturon/rust/teams","hooks_url":"https://api.github.com/repos/aturon/rust/hooks","issue_events_url":"https://api.github.com/repos/aturon/rust/issues/events{/number}","events_url":"https://api.github.com/repos/aturon/rust/events","assignees_url":"https://api.github.com/repos/aturon/rust/assignees{/user}","branches_url":"https://api.github.com/repos/aturon/rust/branches{/branch}","tags_url":"https://api.github.com/repos/aturon/rust/tags","blobs_url":"https://api.github.com/repos/aturon/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aturon/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aturon/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/aturon/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aturon/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/aturon/rust/languages","stargazers_url":"https://api.github.com/repos/aturon/rust/stargazers","contributors_url":"https://api.github.com/repos/aturon/rust/contributors","subscribers_url":"https://api.github.com/repos/aturon/rust/subscribers","subscription_url":"https://api.github.com/repos/aturon/rust/subscription","commits_url":"https://api.github.com/repos/aturon/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/aturon/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/aturon/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/aturon/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/aturon/rust/contents/{+path}","compare_url":"https://api.github.com/repos/aturon/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aturon/rust/merges","archive_url":"https://api.github.com/repos/aturon/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aturon/rust/downloads","issues_url":"https://api.github.com/repos/aturon/rust/issues{/number}","pulls_url":"https://api.github.com/repos/aturon/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/aturon/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/aturon/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aturon/rust/labels{/name}","releases_url":"https://api.github.com/repos/aturon/rust/releases{/id}","created_at":"2014-04-23T04:19:14Z","updated_at":"2014-06-21T05:46:22Z","pushed_at":"2014-12-20T08:37:36Z","git_url":"git://github.com/aturon/rust.git","ssh_url":"git@github.com:aturon/rust.git","clone_url":"https://github.com/aturon/rust.git","svn_url":"https://github.com/aturon/rust","homepage":"http://www.rust-lang.org","size":199999,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"1c2df5cc3cfc0c9e80adf9fa6504d55056741c5a","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2014-12-28T18:23:46Z","pushed_at":"2014-12-28T16:21:58Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":401211,"stargazers_count":8168,"watchers_count":8168,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1576,"mirror_url":null,"open_issues_count":2332,"forks":1576,"open_issues":2332,"watchers":8168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/20065"},"html":{"href":"https://github.com/rust-lang/rust/pull/20065"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/20065"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/20065/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/20065/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/20065/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/70f7f63eaec4d1d8509dea660a4767ac0baed403"}}}}