GitHub PullRequestReviewCommentEvent at 2014-10-06 18:04:59
Repository: nexus-oss
Actor: mcculls
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sonatype/nexus-oss/pulls/comments/18473518","id":18473518,"diff_hunk":"@@ -56,10 +56,15 @@ protected Object newScript() {\n \n   @Override\n   public DependencyData dependencies(InputStream is, String name, long modified) {\n-    return new DependencyDataImpl(scriptingContainer,\n-        callMethod(\"dependencies\", new Object[]{name, is}, Object.class),\n-        modified);\n-  }\n+    try {\n+      return new DependencyDataImpl(scriptingContainer,\n+          callMethod(\"dependencies\", new Object[]{name, is}, Object.class),\n+          modified);\n+    }\n+    finally {\n+      IOUtil.close(is);","path":"plugins/rubygem/nexus-ruby-tools/src/main/java/org/sonatype/nexus/ruby/DefaultRubygemsGateway.java","position":14,"original_position":14,"commit_id":"eb2c1d7c63f862c586a1b916e7d7a8477998730f","original_commit_id":"eb2c1d7c63f862c586a1b916e7d7a8477998730f","user":{"login":"mcculls","id":145851,"avatar_url":"https://avatars.githubusercontent.com/u/145851?v=2","gravatar_id":"","url":"https://api.github.com/users/mcculls","html_url":"https://github.com/mcculls","followers_url":"https://api.github.com/users/mcculls/followers","following_url":"https://api.github.com/users/mcculls/following{/other_user}","gists_url":"https://api.github.com/users/mcculls/gists{/gist_id}","starred_url":"https://api.github.com/users/mcculls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcculls/subscriptions","organizations_url":"https://api.github.com/users/mcculls/orgs","repos_url":"https://api.github.com/users/mcculls/repos","events_url":"https://api.github.com/users/mcculls/events{/privacy}","received_events_url":"https://api.github.com/users/mcculls/received_events","type":"User","site_admin":false},"body":"Is it possible to move this close to the same place where the inputstream is opened? Otherwise it looks like a side-effect that calling this method with a given inputstream will end up closing it.","created_at":"2014-10-06T18:04:59Z","updated_at":"2014-10-06T18:04:59Z","html_url":"https://github.com/sonatype/nexus-oss/pull/759#discussion_r18473518","pull_request_url":"https://api.github.com/repos/sonatype/nexus-oss/pulls/759","_links":{"self":{"href":"https://api.github.com/repos/sonatype/nexus-oss/pulls/comments/18473518"},"html":{"href":"https://github.com/sonatype/nexus-oss/pull/759#discussion_r18473518"},"pull_request":{"href":"https://api.github.com/repos/sonatype/nexus-oss/pulls/759"}}},"pull_request":{"url":"https://api.github.com/repos/sonatype/nexus-oss/pulls/759","id":22296383,"html_url":"https://github.com/sonatype/nexus-oss/pull/759","diff_url":"https://github.com/sonatype/nexus-oss/pull/759.diff","patch_url":"https://github.com/sonatype/nexus-oss/pull/759.patch","issue_url":"https://api.github.com/repos/sonatype/nexus-oss/issues/759","number":759,"state":"open","locked":false,"title":"Input streams","user":{"login":"mkristian","id":35058,"avatar_url":"https://avatars.githubusercontent.com/u/35058?v=2","gravatar_id":"","url":"https://api.github.com/users/mkristian","html_url":"https://github.com/mkristian","followers_url":"https://api.github.com/users/mkristian/followers","following_url":"https://api.github.com/users/mkristian/following{/other_user}","gists_url":"https://api.github.com/users/mkristian/gists{/gist_id}","starred_url":"https://api.github.com/users/mkristian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkristian/subscriptions","organizations_url":"https://api.github.com/users/mkristian/orgs","repos_url":"https://api.github.com/users/mkristian/repos","events_url":"https://api.github.com/users/mkristian/events{/privacy}","received_events_url":"https://api.github.com/users/mkristian/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-06T16:30:28Z","updated_at":"2014-10-06T18:04:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8761399765f39c581776bba35889341007737cf3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sonatype/nexus-oss/pulls/759/commits","review_comments_url":"https://api.github.com/repos/sonatype/nexus-oss/pulls/759/comments","review_comment_url":"https://api.github.com/repos/sonatype/nexus-oss/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sonatype/nexus-oss/issues/759/comments","statuses_url":"https://api.github.com/repos/sonatype/nexus-oss/statuses/eb2c1d7c63f862c586a1b916e7d7a8477998730f","head":{"label":"mkristian:InputStreams","ref":"InputStreams","sha":"eb2c1d7c63f862c586a1b916e7d7a8477998730f","user":{"login":"mkristian","id":35058,"avatar_url":"https://avatars.githubusercontent.com/u/35058?v=2","gravatar_id":"","url":"https://api.github.com/users/mkristian","html_url":"https://github.com/mkristian","followers_url":"https://api.github.com/users/mkristian/followers","following_url":"https://api.github.com/users/mkristian/following{/other_user}","gists_url":"https://api.github.com/users/mkristian/gists{/gist_id}","starred_url":"https://api.github.com/users/mkristian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkristian/subscriptions","organizations_url":"https://api.github.com/users/mkristian/orgs","repos_url":"https://api.github.com/users/mkristian/repos","events_url":"https://api.github.com/users/mkristian/events{/privacy}","received_events_url":"https://api.github.com/users/mkristian/received_events","type":"User","site_admin":false},"repo":{"id":24850992,"name":"nexus-oss","full_name":"mkristian/nexus-oss","owner":{"login":"mkristian","id":35058,"avatar_url":"https://avatars.githubusercontent.com/u/35058?v=2","gravatar_id":"","url":"https://api.github.com/users/mkristian","html_url":"https://github.com/mkristian","followers_url":"https://api.github.com/users/mkristian/followers","following_url":"https://api.github.com/users/mkristian/following{/other_user}","gists_url":"https://api.github.com/users/mkristian/gists{/gist_id}","starred_url":"https://api.github.com/users/mkristian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkristian/subscriptions","organizations_url":"https://api.github.com/users/mkristian/orgs","repos_url":"https://api.github.com/users/mkristian/repos","events_url":"https://api.github.com/users/mkristian/events{/privacy}","received_events_url":"https://api.github.com/users/mkristian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkristian/nexus-oss","description":"Sonatype Nexus OSS","fork":true,"url":"https://api.github.com/repos/mkristian/nexus-oss","forks_url":"https://api.github.com/repos/mkristian/nexus-oss/forks","keys_url":"https://api.github.com/repos/mkristian/nexus-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkristian/nexus-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkristian/nexus-oss/teams","hooks_url":"https://api.github.com/repos/mkristian/nexus-oss/hooks","issue_events_url":"https://api.github.com/repos/mkristian/nexus-oss/issues/events{/number}","events_url":"https://api.github.com/repos/mkristian/nexus-oss/events","assignees_url":"https://api.github.com/repos/mkristian/nexus-oss/assignees{/user}","branches_url":"https://api.github.com/repos/mkristian/nexus-oss/branches{/branch}","tags_url":"https://api.github.com/repos/mkristian/nexus-oss/tags","blobs_url":"https://api.github.com/repos/mkristian/nexus-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkristian/nexus-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkristian/nexus-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkristian/nexus-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkristian/nexus-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/mkristian/nexus-oss/languages","stargazers_url":"https://api.github.com/repos/mkristian/nexus-oss/stargazers","contributors_url":"https://api.github.com/repos/mkristian/nexus-oss/contributors","subscribers_url":"https://api.github.com/repos/mkristian/nexus-oss/subscribers","subscription_url":"https://api.github.com/repos/mkristian/nexus-oss/subscription","commits_url":"https://api.github.com/repos/mkristian/nexus-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkristian/nexus-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkristian/nexus-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkristian/nexus-oss/issues/comments/{number}","contents_url":"https://api.github.com/repos/mkristian/nexus-oss/contents/{+path}","compare_url":"https://api.github.com/repos/mkristian/nexus-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkristian/nexus-oss/merges","archive_url":"https://api.github.com/repos/mkristian/nexus-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkristian/nexus-oss/downloads","issues_url":"https://api.github.com/repos/mkristian/nexus-oss/issues{/number}","pulls_url":"https://api.github.com/repos/mkristian/nexus-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/mkristian/nexus-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/mkristian/nexus-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkristian/nexus-oss/labels{/name}","releases_url":"https://api.github.com/repos/mkristian/nexus-oss/releases{/id}","created_at":"2014-10-06T15:12:18Z","updated_at":"2014-09-25T03:35:54Z","pushed_at":"2014-10-06T16:26:35Z","git_url":"git://github.com/mkristian/nexus-oss.git","ssh_url":"git@github.com:mkristian/nexus-oss.git","clone_url":"https://github.com/mkristian/nexus-oss.git","svn_url":"https://github.com/mkristian/nexus-oss","homepage":"http://links.sonatype.com/products/nexus/oss/home","size":773112,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonatype:NEXUS-6905-merge-rubygems","ref":"NEXUS-6905-merge-rubygems","sha":"9b79d2b1542a099da9175f5f278ef228d728009b","user":{"login":"sonatype","id":44938,"avatar_url":"https://avatars.githubusercontent.com/u/44938?v=2","gravatar_id":"","url":"https://api.github.com/users/sonatype","html_url":"https://github.com/sonatype","followers_url":"https://api.github.com/users/sonatype/followers","following_url":"https://api.github.com/users/sonatype/following{/other_user}","gists_url":"https://api.github.com/users/sonatype/gists{/gist_id}","starred_url":"https://api.github.com/users/sonatype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonatype/subscriptions","organizations_url":"https://api.github.com/users/sonatype/orgs","repos_url":"https://api.github.com/users/sonatype/repos","events_url":"https://api.github.com/users/sonatype/events{/privacy}","received_events_url":"https://api.github.com/users/sonatype/received_events","type":"Organization","site_admin":false},"repo":{"id":10146961,"name":"nexus-oss","full_name":"sonatype/nexus-oss","owner":{"login":"sonatype","id":44938,"avatar_url":"https://avatars.githubusercontent.com/u/44938?v=2","gravatar_id":"","url":"https://api.github.com/users/sonatype","html_url":"https://github.com/sonatype","followers_url":"https://api.github.com/users/sonatype/followers","following_url":"https://api.github.com/users/sonatype/following{/other_user}","gists_url":"https://api.github.com/users/sonatype/gists{/gist_id}","starred_url":"https://api.github.com/users/sonatype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonatype/subscriptions","organizations_url":"https://api.github.com/users/sonatype/orgs","repos_url":"https://api.github.com/users/sonatype/repos","events_url":"https://api.github.com/users/sonatype/events{/privacy}","received_events_url":"https://api.github.com/users/sonatype/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonatype/nexus-oss","description":"Sonatype Nexus OSS","fork":false,"url":"https://api.github.com/repos/sonatype/nexus-oss","forks_url":"https://api.github.com/repos/sonatype/nexus-oss/forks","keys_url":"https://api.github.com/repos/sonatype/nexus-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonatype/nexus-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonatype/nexus-oss/teams","hooks_url":"https://api.github.com/repos/sonatype/nexus-oss/hooks","issue_events_url":"https://api.github.com/repos/sonatype/nexus-oss/issues/events{/number}","events_url":"https://api.github.com/repos/sonatype/nexus-oss/events","assignees_url":"https://api.github.com/repos/sonatype/nexus-oss/assignees{/user}","branches_url":"https://api.github.com/repos/sonatype/nexus-oss/branches{/branch}","tags_url":"https://api.github.com/repos/sonatype/nexus-oss/tags","blobs_url":"https://api.github.com/repos/sonatype/nexus-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonatype/nexus-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonatype/nexus-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonatype/nexus-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonatype/nexus-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/sonatype/nexus-oss/languages","stargazers_url":"https://api.github.com/repos/sonatype/nexus-oss/stargazers","contributors_url":"https://api.github.com/repos/sonatype/nexus-oss/contributors","subscribers_url":"https://api.github.com/repos/sonatype/nexus-oss/subscribers","subscription_url":"https://api.github.com/repos/sonatype/nexus-oss/subscription","commits_url":"https://api.github.com/repos/sonatype/nexus-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonatype/nexus-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonatype/nexus-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonatype/nexus-oss/issues/comments/{number}","contents_url":"https://api.github.com/repos/sonatype/nexus-oss/contents/{+path}","compare_url":"https://api.github.com/repos/sonatype/nexus-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonatype/nexus-oss/merges","archive_url":"https://api.github.com/repos/sonatype/nexus-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonatype/nexus-oss/downloads","issues_url":"https://api.github.com/repos/sonatype/nexus-oss/issues{/number}","pulls_url":"https://api.github.com/repos/sonatype/nexus-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/sonatype/nexus-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/sonatype/nexus-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonatype/nexus-oss/labels{/name}","releases_url":"https://api.github.com/repos/sonatype/nexus-oss/releases{/id}","created_at":"2013-05-18T20:48:57Z","updated_at":"2014-09-25T03:35:54Z","pushed_at":"2014-10-06T17:44:53Z","git_url":"git://github.com/sonatype/nexus-oss.git","ssh_url":"git@github.com:sonatype/nexus-oss.git","clone_url":"https://github.com/sonatype/nexus-oss.git","svn_url":"https://github.com/sonatype/nexus-oss","homepage":"http://links.sonatype.com/products/nexus/oss/home","size":773112,"stargazers_count":102,"watchers_count":102,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":17,"forks":62,"open_issues":17,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonatype/nexus-oss/pulls/759"},"html":{"href":"https://github.com/sonatype/nexus-oss/pull/759"},"issue":{"href":"https://api.github.com/repos/sonatype/nexus-oss/issues/759"},"comments":{"href":"https://api.github.com/repos/sonatype/nexus-oss/issues/759/comments"},"review_comments":{"href":"https://api.github.com/repos/sonatype/nexus-oss/pulls/759/comments"},"review_comment":{"href":"https://api.github.com/repos/sonatype/nexus-oss/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sonatype/nexus-oss/pulls/759/commits"},"statuses":{"href":"https://api.github.com/repos/sonatype/nexus-oss/statuses/eb2c1d7c63f862c586a1b916e7d7a8477998730f"}}}}