GitHub PushEvent at 2014-08-27 10:18:04
Repository: Mudlet
Actor: ahmedcharles
Payload: {"shas":[["1a901e217c8a4bbe536117dbe2d32aea202d2d51","ae4fd07f940f481dcdd4c0d643be611597a2662d@outlook.com","Use the text of the GPLv2, just like the COPYING file.","Ahmed Charles",false],["beca49e4cd54356fd945623f1fbae26352245682","ae4fd07f940f481dcdd4c0d643be611597a2662d@outlook.com","Merge pull request #92 from ahmedcharles/about\n\nUse the text of the GPLv2, just like the COPYING file.","Ahmed Charles",false],["0c2cdc56ded710f7526ad207ec8d4e9ac7e33626","8198ec53cc2e2287bf8312772bb76dd577b1a59b@virginmedia.com","Fixup: unsquash cust.line. form \"cancel\" button + swap pressed() to clicked()\n\nRemoved the fixed constraint on the cancel button on the custom_lines.ui\nform - as on some systems it was too narrow - it now fills the available\nwidth of the dialog.  I clarified the tool-tip for this button slightly\nto make the information more closely match reality\n\nFollowing comments from Vadim, changed code associated with all buttons on\nthis form to use the clicked() signal rather than the previous pressed()\none.\n\nAlso correct a spelling mistake in several error messages.\n\nNoting the same usage on the room_exits.ui form, performed the SAME change\nfrom pressed() to clicked() signals there.\n\nAlso to avoid any squishing of the four buttons on the bottom of THAT\ndialog set uniform minimum sizes for them.\n\nSigned-off-by: Stephen Lyons <slysven@virginmedia.com>","Stephen Lyons",false],["328ff62e0a9d6250716bbfc910787e3d6b357369","ae4fd07f940f481dcdd4c0d643be611597a2662d@outlook.com","Merge pull request #87 from SlySven/fixup_customLineProperties\n\nFixup: unsquash cust.line. form \"cancel\" button + swap pressed() to\nclicked()","Ahmed Charles",false],["fa86697548463172085a31c88a98c9da25b57617","ae4fd07f940f481dcdd4c0d643be611597a2662d@outlook.com","Remove unnecessary .gitignore.","Ahmed Charles",false],["be509421bed9b6507b37d725d07d096011989c89","ae4fd07f940f481dcdd4c0d643be611597a2662d@outlook.com","Merge pull request #94 from ahmedcharles/gitignore\n\nRemove unnecessary .gitignore.","Ahmed Charles",false],["ee603f8d5549aab7f669c8b73e9ea3a5e7ea4457","28d6f4a03fe2d0ee2d5a975547724c773a53e26f@gmail.com","Re-enabled profile deletion and renaming features.","Vadim Peretokin",false],["84b6a19f09320c055258b6d615f490e87618460a","28d6f4a03fe2d0ee2d5a975547724c773a53e26f@gmail.com","Refactored some variable names to make the code easier to read & added comments.","Vadim Peretokin",false],["0ebe6fffc6a280fff0d20de116338ede20733cca","28d6f4a03fe2d0ee2d5a975547724c773a53e26f@gmail.com","Removed recursive directory deletion function in favour of one introduced with Qt 5.0.","Vadim Peretokin",false],["6a6bfd6923ded91e9c99e09e4f1950f4bd19c84e","ae4fd07f940f481dcdd4c0d643be611597a2662d@outlook.com","Merge pull request #88 from vadi2/development\n\nRe-enable profile deletion and renaming features","Ahmed Charles",false],["65900190364482c354c953b7a5f5c499ef4d028f","8198ec53cc2e2287bf8312772bb76dd577b1a59b@virginmedia.com","BugFix: Fix-up various iconic issues.\n\nIn four places (one a twin entry) the resource path was given as:\n\":/icons/icons/<icon>.png\" when it should have been: \":/icons/<icon>.png\",\nadditionally as one of these uses was for a dialog box where it closed\nthat box and committed any changes made with no option to cancel without\nundoing them I feel it would be more appropriate to use an \"apply\" icon\n(a green tick) rather than the originally intended \"dialog-close\" (a\nwhite cross on a red filled in circle).\n\nThe main application was assigned the 16x16 icon but this appears blurry\non the system task switching control (on at least Linux and Windows)\nplatforms.  Using the 48x48 icon appears much better and has been\nchanged in mudlet::mudlet().  The central debug console was not assigned\nan icon so in the system task switcher it appeared as a plain icon\n(at least in Linux) - I have created a suitable icon (putting a quarter\nsize bug on the bottom right quarter of the mudlet 48x48 icon).\nSimilarly I have created one for the profile_preferences.ui form with\na superimposed spanner and actually used the mudlet_notepad one that was\nalready present but not used for the profile notes editor.  This makes\nif a bit easy to tell which window is which when swapping between them\nby keyboard!\n\nWhen the profile_preferences.ui has the \"Use Mudlet on a netbook\"\nfeature set, the icon that appears on the Main Toolbar to toggle in\nand out of \"fullscreen\" mode is the Oxygen \"dialog-cancel\" one, however\nthere is a specific icon \"view-fullscreen\" which more closely relates\nto the function of this control, I have included it and changed to that\none.  As the control is actually a toggle I also have included the\ncorresponding \"view-restore\" image as well which it might be possible\nto code to use...\n\nOn the \"replay\" toolbar the \"replay speed down\" icon was spelt as\n\"port.png\" rather than \"import.png\" so the downward pointing double\narrow was not shown, leaving an empty button in some situations.\n\nWithin the Trigger Editor it has been commented by users that the icon\nlabelled \"save\" and featuring a disc symbol does not actually write\nanything in a permanent manner and though the tooltip does warn of this\nI believe a more coherant use could be made by replacing some of the\nicons.  Building on the top tool bar \"item\" and \"group\" use of a page\nand a folder respectively I have used the executing and error/stop\nsub-icons from the oxygen \"printer-printing\" and \"printer-error\" images\nand placed them on top of a page image to replace the\ntag-checkbox-checked amd tag-checkbox for the item enabled/disabled\ntreeWidget icons, a second pair rendered in grey scale becomes the\nancestor disabled pair and one with a \"bug\" to the same scale represents\ncode that cannot be Lua compiled.  Combining both executing and error\nsub-icons ontop of a pair of circular arrows on top of a page replaces\nthe activate/deactive toolbar button and the circular executing sub-icon\nrecoloured from green to orange with an arrow indicating the affixing of\nthe sub-icon onto a page becomes the slightly previously misleading\n\"save\" (code) button next to it on the top toolbar.  In the special case\nof a \"circular\" Alias a variant of this in red with a red cross over the\narrow is used as it indicates that the \"code\" cannot be affixed to the\n\"page\", which does represent the fact that the page can't be saved until\nit is fixed.  As a nice side effect, that extends the page metaphor, is\nthe oxygen \"document-import\" and \"document-export\" icons that,\nparticularly in the export case, emphasises that only the selected page\n(or folder) IS what is exported.  Also, as we no longer use the oxygen\n\"save\" (disk) icon to write the code into the system, we can now use\nit for the save profile (replacing the double disc \"save all\" icon)\nwhich sits more nicely alongside the \"save as\" (disc with a pencil\nwriting a new label) icon that is already used.  Finally, the delete\nitem used the oxygen \"edit-delete-shred\" image but that uses a\n\"crumpled\" page which although perhaps appropriate does look visually\nat odds with the clean straight edges of the other \"page\" icons.\nAs there didn't seem to be a \"document-delete\" image in the Oxygen set\nI had to make one to match.\n\nSigned-off-by: Stephen Lyons <slysven@virginmedia.com>","Stephen Lyons",true]],"size":11,"ref":"refs/heads/icons","head":"65900190364482c354c953b7a5f5c499ef4d028f"}