GitHub PullRequestReviewCommentEvent at 2014-09-18 16:15:56
Repository: manageiq
Actor: Fryguy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/17737320","id":17737320,"diff_hunk":"@@ -0,0 +1,21 @@\n+require \"spec_helper\"\n+require Rails.root.join(\"db/migrate/20140918140859_add_cloud_tenant_sti_column\")\n+\n+class CloudTenant < ActiveRecord::Base; end\n+\n+describe AddCloudTenantStiColumn do\n+  let(:cloud_tenant_stub) { migration_stub(:CloudTenant) }\n+\n+  migration_context :up do\n+    it \"Sets the default type for Cloud Tenant records to 'CloudTenantOpenstack'\" do\n+      cloud_tenant_stub.create!(:name => \"tenant 1\")\n+      cloud_tenant_stub.create!(:name => \"tenant 2\")\n+\n+      cloud_tenant_stub.count.should be == 2","path":"vmdb/spec/migrations/20140918140859_add_cloud_tenant_sti_column_spec.rb","position":14,"original_position":14,"commit_id":"c0838f492ebfab1cbd08ce1906c6d450462dc3b3","original_commit_id":"c0838f492ebfab1cbd08ce1906c6d450462dc3b3","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=2","gravatar_id":"9bf7b39ca5a72a232bb13f32f6d5f6c3","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"Actually, you don't need this assertion...it's testing ActiveRecord, which is not buying us anything.","created_at":"2014-09-18T16:15:56Z","updated_at":"2014-09-18T16:15:56Z","html_url":"https://github.com/ManageIQ/manageiq/pull/654#discussion_r17737320","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/654","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/17737320"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/654#discussion_r17737320"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/654"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/654","id":21436903,"html_url":"https://github.com/ManageIQ/manageiq/pull/654","diff_url":"https://github.com/ManageIQ/manageiq/pull/654.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/654.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/654","number":654,"state":"open","locked":false,"title":"Add modeling for template many-to-many tenant","user":{"login":"blomquisg","id":14183,"avatar_url":"https://avatars.githubusercontent.com/u/14183?v=2","gravatar_id":"1b29432e2ffc0d02126eb293cb448342","url":"https://api.github.com/users/blomquisg","html_url":"https://github.com/blomquisg","followers_url":"https://api.github.com/users/blomquisg/followers","following_url":"https://api.github.com/users/blomquisg/following{/other_user}","gists_url":"https://api.github.com/users/blomquisg/gists{/gist_id}","starred_url":"https://api.github.com/users/blomquisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blomquisg/subscriptions","organizations_url":"https://api.github.com/users/blomquisg/orgs","repos_url":"https://api.github.com/users/blomquisg/repos","events_url":"https://api.github.com/users/blomquisg/events{/privacy}","received_events_url":"https://api.github.com/users/blomquisg/received_events","type":"User","site_admin":false},"body":"In OpenStack, an image (TemplateOpenstack) can exist in more than one project\r\n(CloudTenantOpenstack).  These migration and model changes allow an OpenStack\r\ntemplate to list the tenants it can be used in, and allows a Cloud Tenant to\r\nlist the templates associated with it.\r\n\r\nThe table is named \"cloud_tenants_vms\" to reflect the physical tables used in\r\nfor the join.\r\n\r\nDespite the table name referring to the generic objects, the relationship is\r\npurposefully restricted to Openstack templates and Openstack cloud tenants in\r\nthe association defined in the models.  This keeps the notion of the\r\nmany-to-many relationship restricted to the most specific level.\r\n\r\nThe relationship methods are named:\r\n\r\n* TemplateOpenstack#cloud_tenants\r\n* CloudTenantOpenstack#opentack_templates\r\n\r\nAdditionally, to facilitate keeping the relationship as specific as possible,\r\nCloudTenant is now sublassed to CloudTenantOpenstack.  Since all of the existing\r\ncloud tenants are only openstack tenants, the migration initializes all of the\r\nCloudTenant records to have a type of CloudTenantOpenstack.","created_at":"2014-09-18T14:28:18Z","updated_at":"2014-09-18T16:15:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f88016ccfb60dafca0774394caa90ff48cb9992","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/654/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/654/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/654/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/c0838f492ebfab1cbd08ce1906c6d450462dc3b3","head":{"label":"blomquisg:add_template_tenant_relationship","ref":"add_template_tenant_relationship","sha":"c0838f492ebfab1cbd08ce1906c6d450462dc3b3","user":{"login":"blomquisg","id":14183,"avatar_url":"https://avatars.githubusercontent.com/u/14183?v=2","gravatar_id":"1b29432e2ffc0d02126eb293cb448342","url":"https://api.github.com/users/blomquisg","html_url":"https://github.com/blomquisg","followers_url":"https://api.github.com/users/blomquisg/followers","following_url":"https://api.github.com/users/blomquisg/following{/other_user}","gists_url":"https://api.github.com/users/blomquisg/gists{/gist_id}","starred_url":"https://api.github.com/users/blomquisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blomquisg/subscriptions","organizations_url":"https://api.github.com/users/blomquisg/orgs","repos_url":"https://api.github.com/users/blomquisg/repos","events_url":"https://api.github.com/users/blomquisg/events{/privacy}","received_events_url":"https://api.github.com/users/blomquisg/received_events","type":"User","site_admin":false},"repo":{"id":20887624,"name":"manageiq","full_name":"blomquisg/manageiq","owner":{"login":"blomquisg","id":14183,"avatar_url":"https://avatars.githubusercontent.com/u/14183?v=2","gravatar_id":"1b29432e2ffc0d02126eb293cb448342","url":"https://api.github.com/users/blomquisg","html_url":"https://github.com/blomquisg","followers_url":"https://api.github.com/users/blomquisg/followers","following_url":"https://api.github.com/users/blomquisg/following{/other_user}","gists_url":"https://api.github.com/users/blomquisg/gists{/gist_id}","starred_url":"https://api.github.com/users/blomquisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blomquisg/subscriptions","organizations_url":"https://api.github.com/users/blomquisg/orgs","repos_url":"https://api.github.com/users/blomquisg/repos","events_url":"https://api.github.com/users/blomquisg/events{/privacy}","received_events_url":"https://api.github.com/users/blomquisg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blomquisg/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/blomquisg/manageiq","forks_url":"https://api.github.com/repos/blomquisg/manageiq/forks","keys_url":"https://api.github.com/repos/blomquisg/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blomquisg/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blomquisg/manageiq/teams","hooks_url":"https://api.github.com/repos/blomquisg/manageiq/hooks","issue_events_url":"https://api.github.com/repos/blomquisg/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/blomquisg/manageiq/events","assignees_url":"https://api.github.com/repos/blomquisg/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/blomquisg/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/blomquisg/manageiq/tags","blobs_url":"https://api.github.com/repos/blomquisg/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blomquisg/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blomquisg/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/blomquisg/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blomquisg/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/blomquisg/manageiq/languages","stargazers_url":"https://api.github.com/repos/blomquisg/manageiq/stargazers","contributors_url":"https://api.github.com/repos/blomquisg/manageiq/contributors","subscribers_url":"https://api.github.com/repos/blomquisg/manageiq/subscribers","subscription_url":"https://api.github.com/repos/blomquisg/manageiq/subscription","commits_url":"https://api.github.com/repos/blomquisg/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/blomquisg/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/blomquisg/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/blomquisg/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/blomquisg/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/blomquisg/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blomquisg/manageiq/merges","archive_url":"https://api.github.com/repos/blomquisg/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blomquisg/manageiq/downloads","issues_url":"https://api.github.com/repos/blomquisg/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/blomquisg/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/blomquisg/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/blomquisg/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blomquisg/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/blomquisg/manageiq/releases{/id}","created_at":"2014-06-16T14:22:04Z","updated_at":"2014-06-24T21:02:56Z","pushed_at":"2014-09-18T15:23:01Z","git_url":"git://github.com/blomquisg/manageiq.git","ssh_url":"git@github.com:blomquisg/manageiq.git","clone_url":"https://github.com/blomquisg/manageiq.git","svn_url":"https://github.com/blomquisg/manageiq","homepage":null,"size":57727,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"9efc6c0c3eac9823c32bffff82f35150b25c7ce7","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=2","gravatar_id":"6e2fbc6e71ee5df101885996971f41e0","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=2","gravatar_id":"6e2fbc6e71ee5df101885996971f41e0","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2014-09-16T08:04:06Z","pushed_at":"2014-09-18T15:50:18Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":69354,"stargazers_count":49,"watchers_count":49,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":120,"forks":58,"open_issues":120,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/654"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/654"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/654"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/654/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/654/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/654/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/c0838f492ebfab1cbd08ce1906c6d450462dc3b3"}}}}