GitHub PullRequestReviewCommentEvent at 2014-07-03 09:22:33
Repository: incubator-brooklyn
Actor: aledsage
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/14504276","id":14504276,"diff_hunk":"@@ -48,11 +49,13 @@\n \n     private volatile boolean running = true;\n \n+\n+    // FIXME Delete","path":"core/src/main/java/brooklyn/entity/rebind/persister/BrooklynMementoPersisterToObjectStore.java","position":13,"original_position":13,"commit_id":"648eb8fb7ea66cdef01950bfd0c9d65b056d6d25","original_commit_id":"648eb8fb7ea66cdef01950bfd0c9d65b056d6d25","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?","gravatar_id":"e3028779c14cdec6ce964238c999d638","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"body":"You're right; not sure what this was about! I'm guessing I started to write a comment about something else that needs deleted but forgot to finish my sentence (e.g. shutting laptop lid before getting off a train - oops; thanks for spotting!)\r\n\r\nI'll delete this, and rebase.","created_at":"2014-07-03T09:22:33Z","updated_at":"2014-07-03T09:22:33Z","html_url":"https://github.com/apache/incubator-brooklyn/pull/34#discussion_r14504276","pull_request_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/14504276"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/34#discussion_r14504276"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/34","id":17800718,"html_url":"https://github.com/apache/incubator-brooklyn/pull/34","diff_url":"https://github.com/apache/incubator-brooklyn/pull/34.diff","patch_url":"https://github.com/apache/incubator-brooklyn/pull/34.patch","issue_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/34","number":34,"state":"open","title":"Feature/persistence exception handler","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?","gravatar_id":"e3028779c14cdec6ce964238c999d638","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"body":"Policy+enricher persistence are now enabled by default.\r\n\r\nHowever, these have not been tested thoroughly with all entity/policy types. Therefore, errors on persist+rebind on policies/enrichers are logged at warning and then we continue (i.e. we'll continue without the policy on rebind). We'll change this default once we're confident it works for all policies.","created_at":"2014-06-30T21:55:20Z","updated_at":"2014-07-03T09:22:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3999e28bd8f0fa40c2d13859a5fb517cf4c6e930","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/34/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/34/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/34/comments","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/648eb8fb7ea66cdef01950bfd0c9d65b056d6d25","head":{"label":"aledsage:feature/PersistenceExceptionHandler","ref":"feature/PersistenceExceptionHandler","sha":"648eb8fb7ea66cdef01950bfd0c9d65b056d6d25","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?","gravatar_id":"e3028779c14cdec6ce964238c999d638","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"repo":{"id":21017170,"name":"incubator-brooklyn","full_name":"aledsage/incubator-brooklyn","owner":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?","gravatar_id":"e3028779c14cdec6ce964238c999d638","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aledsage/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":true,"url":"https://api.github.com/repos/aledsage/incubator-brooklyn","forks_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/aledsage/incubator-brooklyn/releases{/id}","created_at":"2014-06-19T22:03:41Z","updated_at":"2014-06-24T09:45:44Z","pushed_at":"2014-07-03T08:59:25Z","git_url":"git://github.com/aledsage/incubator-brooklyn.git","ssh_url":"git@github.com:aledsage/incubator-brooklyn.git","clone_url":"https://github.com/aledsage/incubator-brooklyn.git","svn_url":"https://github.com/aledsage/incubator-brooklyn","homepage":null,"size":220782,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"60a55767ce472931f4cdd6106e24d054c38409bc","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":19368221,"name":"incubator-brooklyn","full_name":"apache/incubator-brooklyn","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":false,"url":"https://api.github.com/repos/apache/incubator-brooklyn","forks_url":"https://api.github.com/repos/apache/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/apache/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/apache/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/apache/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/apache/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-brooklyn/releases{/id}","created_at":"2014-05-02T07:00:07Z","updated_at":"2014-07-02T13:19:41Z","pushed_at":"2014-07-02T16:49:53Z","git_url":"git://github.com/apache/incubator-brooklyn.git","ssh_url":"git@github.com:apache/incubator-brooklyn.git","clone_url":"https://github.com/apache/incubator-brooklyn.git","svn_url":"https://github.com/apache/incubator-brooklyn","homepage":null,"size":224526,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":16,"mirror_url":"git://git.apache.org/incubator-brooklyn.git","open_issues_count":13,"forks":16,"open_issues":13,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/34"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/34"},"issue":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/34"},"comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/648eb8fb7ea66cdef01950bfd0c9d65b056d6d25"}}}}