GitHub PullRequestEvent at 2014-02-25 18:30:24
Repository: mbxmapkit
Actor: incanus
Payload: {"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/mapbox/mbxmapkit/pulls/23","id":11744727,"html_url":"https://github.com/mapbox/mbxmapkit/pull/23","diff_url":"https://github.com/mapbox/mbxmapkit/pull/23.diff","patch_url":"https://github.com/mapbox/mbxmapkit/pull/23.patch","issue_url":"https://api.github.com/repos/mapbox/mbxmapkit/issues/23","number":23,"state":"closed","title":"Fix for #22: Only write to cache for an HTTP 200, sweep empty png files.","user":{"login":"wsnook","id":1828676,"avatar_url":"https://gravatar.com/avatar/b1c8b86d32db6e54f10b6ce888a2e03b?d=https%3A%2F%2Fidenticons.github.com%2Fe5351a0bf03c7aea5bad24d47541a7bd.png&r=x","gravatar_id":"b1c8b86d32db6e54f10b6ce888a2e03b","url":"https://api.github.com/users/wsnook","html_url":"https://github.com/wsnook","followers_url":"https://api.github.com/users/wsnook/followers","following_url":"https://api.github.com/users/wsnook/following{/other_user}","gists_url":"https://api.github.com/users/wsnook/gists{/gist_id}","starred_url":"https://api.github.com/users/wsnook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsnook/subscriptions","organizations_url":"https://api.github.com/users/wsnook/orgs","repos_url":"https://api.github.com/users/wsnook/repos","events_url":"https://api.github.com/users/wsnook/events{/privacy}","received_events_url":"https://api.github.com/users/wsnook/received_events","type":"User","site_admin":false},"body":"This addresses issue #22 where empty PNG files were getting written to cache for tiles which failed to load while the app was running in airplane mode. There are two parts to the change:\r\n1) For tiles that aren't in the cache, `loadTileAtPath:result:` now takes a closer look at the type of response generated by the tile request. Anything other than an HTTP 200 is treated as an error (i.e. don't write file to cache, call `result(data,error)` with nil data and an NSError describing the problem).\r\n2) sweepCache now deletes any cached images which have a size of 0 bytes. For devices with an existing cache folder, this should clean up any debris which may have been created by the old  `loadTileAtPath:result:` code.","created_at":"2014-01-22T05:41:31Z","updated_at":"2014-02-25T18:30:23Z","closed_at":"2014-02-25T18:30:23Z","merged_at":"2014-02-25T18:30:23Z","merge_commit_sha":"727a7a0e61c0082e5bfb659fd0b8533dca24d50e","assignee":null,"milestone":{"url":"https://api.github.com/repos/mapbox/mbxmapkit/milestones/1","labels_url":"https://api.github.com/repos/mapbox/mbxmapkit/milestones/1/labels","id":573576,"number":1,"title":"0.2.0","description":"","creator":{"login":"incanus","id":17722,"avatar_url":"https://gravatar.com/avatar/39f0706e7558c15a2abe1a0c5aba7fdf?d=https%3A%2F%2Fidenticons.github.com%2F657ad4f3e2afdf70f27fe834691fb65a.png&r=x","gravatar_id":"39f0706e7558c15a2abe1a0c5aba7fdf","url":"https://api.github.com/users/incanus","html_url":"https://github.com/incanus","followers_url":"https://api.github.com/users/incanus/followers","following_url":"https://api.github.com/users/incanus/following{/other_user}","gists_url":"https://api.github.com/users/incanus/gists{/gist_id}","starred_url":"https://api.github.com/users/incanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incanus/subscriptions","organizations_url":"https://api.github.com/users/incanus/orgs","repos_url":"https://api.github.com/users/incanus/repos","events_url":"https://api.github.com/users/incanus/events{/privacy}","received_events_url":"https://api.github.com/users/incanus/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":9,"state":"open","created_at":"2014-02-18T22:33:01Z","updated_at":"2014-02-25T18:30:23Z","due_on":null},"commits_url":"https://api.github.com/repos/mapbox/mbxmapkit/pulls/23/commits","review_comments_url":"https://api.github.com/repos/mapbox/mbxmapkit/pulls/23/comments","review_comment_url":"https://api.github.com/repos/mapbox/mbxmapkit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mapbox/mbxmapkit/issues/23/comments","statuses_url":"https://api.github.com/repos/mapbox/mbxmapkit/statuses/af8a45fdd338baf71ec27417c6282eafd2214ff3","head":{"label":"wsnook:issue22","ref":"issue22","sha":"af8a45fdd338baf71ec27417c6282eafd2214ff3","user":{"login":"wsnook","id":1828676,"avatar_url":"https://gravatar.com/avatar/b1c8b86d32db6e54f10b6ce888a2e03b?d=https%3A%2F%2Fidenticons.github.com%2Fe5351a0bf03c7aea5bad24d47541a7bd.png&r=x","gravatar_id":"b1c8b86d32db6e54f10b6ce888a2e03b","url":"https://api.github.com/users/wsnook","html_url":"https://github.com/wsnook","followers_url":"https://api.github.com/users/wsnook/followers","following_url":"https://api.github.com/users/wsnook/following{/other_user}","gists_url":"https://api.github.com/users/wsnook/gists{/gist_id}","starred_url":"https://api.github.com/users/wsnook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsnook/subscriptions","organizations_url":"https://api.github.com/users/wsnook/orgs","repos_url":"https://api.github.com/users/wsnook/repos","events_url":"https://api.github.com/users/wsnook/events{/privacy}","received_events_url":"https://api.github.com/users/wsnook/received_events","type":"User","site_admin":false},"repo":{"id":15661920,"name":"mbxmapkit","full_name":"wsnook/mbxmapkit","owner":{"login":"wsnook","id":1828676,"avatar_url":"https://gravatar.com/avatar/b1c8b86d32db6e54f10b6ce888a2e03b?d=https%3A%2F%2Fidenticons.github.com%2Fe5351a0bf03c7aea5bad24d47541a7bd.png&r=x","gravatar_id":"b1c8b86d32db6e54f10b6ce888a2e03b","url":"https://api.github.com/users/wsnook","html_url":"https://github.com/wsnook","followers_url":"https://api.github.com/users/wsnook/followers","following_url":"https://api.github.com/users/wsnook/following{/other_user}","gists_url":"https://api.github.com/users/wsnook/gists{/gist_id}","starred_url":"https://api.github.com/users/wsnook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsnook/subscriptions","organizations_url":"https://api.github.com/users/wsnook/orgs","repos_url":"https://api.github.com/users/wsnook/repos","events_url":"https://api.github.com/users/wsnook/events{/privacy}","received_events_url":"https://api.github.com/users/wsnook/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wsnook/mbxmapkit","description":"One-line MapBox integration with MapKit on iOS and OS X","fork":true,"url":"https://api.github.com/repos/wsnook/mbxmapkit","forks_url":"https://api.github.com/repos/wsnook/mbxmapkit/forks","keys_url":"https://api.github.com/repos/wsnook/mbxmapkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wsnook/mbxmapkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wsnook/mbxmapkit/teams","hooks_url":"https://api.github.com/repos/wsnook/mbxmapkit/hooks","issue_events_url":"https://api.github.com/repos/wsnook/mbxmapkit/issues/events{/number}","events_url":"https://api.github.com/repos/wsnook/mbxmapkit/events","assignees_url":"https://api.github.com/repos/wsnook/mbxmapkit/assignees{/user}","branches_url":"https://api.github.com/repos/wsnook/mbxmapkit/branches{/branch}","tags_url":"https://api.github.com/repos/wsnook/mbxmapkit/tags","blobs_url":"https://api.github.com/repos/wsnook/mbxmapkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wsnook/mbxmapkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wsnook/mbxmapkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/wsnook/mbxmapkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wsnook/mbxmapkit/statuses/{sha}","languages_url":"https://api.github.com/repos/wsnook/mbxmapkit/languages","stargazers_url":"https://api.github.com/repos/wsnook/mbxmapkit/stargazers","contributors_url":"https://api.github.com/repos/wsnook/mbxmapkit/contributors","subscribers_url":"https://api.github.com/repos/wsnook/mbxmapkit/subscribers","subscription_url":"https://api.github.com/repos/wsnook/mbxmapkit/subscription","commits_url":"https://api.github.com/repos/wsnook/mbxmapkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/wsnook/mbxmapkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/wsnook/mbxmapkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/wsnook/mbxmapkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/wsnook/mbxmapkit/contents/{+path}","compare_url":"https://api.github.com/repos/wsnook/mbxmapkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wsnook/mbxmapkit/merges","archive_url":"https://api.github.com/repos/wsnook/mbxmapkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wsnook/mbxmapkit/downloads","issues_url":"https://api.github.com/repos/wsnook/mbxmapkit/issues{/number}","pulls_url":"https://api.github.com/repos/wsnook/mbxmapkit/pulls{/number}","milestones_url":"https://api.github.com/repos/wsnook/mbxmapkit/milestones{/number}","notifications_url":"https://api.github.com/repos/wsnook/mbxmapkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wsnook/mbxmapkit/labels{/name}","releases_url":"https://api.github.com/repos/wsnook/mbxmapkit/releases{/id}","created_at":"2014-01-06T00:55:41Z","updated_at":"2014-02-25T18:30:23Z","pushed_at":"2014-02-08T10:13:10Z","git_url":"git://github.com/wsnook/mbxmapkit.git","ssh_url":"git@github.com:wsnook/mbxmapkit.git","clone_url":"https://github.com/wsnook/mbxmapkit.git","svn_url":"https://github.com/wsnook/mbxmapkit","homepage":"","size":2920,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"31be0407a32e0e0aaea0f82e4e9f63f59993b6e7","user":{"login":"mapbox","id":600935,"avatar_url":"https://gravatar.com/avatar/29f0667ed68eab9113d8e58f94c24a9e?d=https%3A%2F%2Fidenticons.github.com%2F3c7486c61d6e15f43b36bf5be1104d98.png&r=x","gravatar_id":"29f0667ed68eab9113d8e58f94c24a9e","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":12901928,"name":"mbxmapkit","full_name":"mapbox/mbxmapkit","owner":{"login":"mapbox","id":600935,"avatar_url":"https://gravatar.com/avatar/29f0667ed68eab9113d8e58f94c24a9e?d=https%3A%2F%2Fidenticons.github.com%2F3c7486c61d6e15f43b36bf5be1104d98.png&r=x","gravatar_id":"29f0667ed68eab9113d8e58f94c24a9e","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mbxmapkit","description":"One-line MapBox integration with MapKit on iOS and OS X","fork":false,"url":"https://api.github.com/repos/mapbox/mbxmapkit","forks_url":"https://api.github.com/repos/mapbox/mbxmapkit/forks","keys_url":"https://api.github.com/repos/mapbox/mbxmapkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mbxmapkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mbxmapkit/teams","hooks_url":"https://api.github.com/repos/mapbox/mbxmapkit/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mbxmapkit/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mbxmapkit/events","assignees_url":"https://api.github.com/repos/mapbox/mbxmapkit/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mbxmapkit/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mbxmapkit/tags","blobs_url":"https://api.github.com/repos/mapbox/mbxmapkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mbxmapkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mbxmapkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mbxmapkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mbxmapkit/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mbxmapkit/languages","stargazers_url":"https://api.github.com/repos/mapbox/mbxmapkit/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mbxmapkit/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mbxmapkit/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mbxmapkit/subscription","commits_url":"https://api.github.com/repos/mapbox/mbxmapkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mbxmapkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mbxmapkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mbxmapkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/mapbox/mbxmapkit/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mbxmapkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mbxmapkit/merges","archive_url":"https://api.github.com/repos/mapbox/mbxmapkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mbxmapkit/downloads","issues_url":"https://api.github.com/repos/mapbox/mbxmapkit/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mbxmapkit/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mbxmapkit/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mbxmapkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mbxmapkit/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mbxmapkit/releases{/id}","created_at":"2013-09-17T17:26:09Z","updated_at":"2014-02-25T18:30:23Z","pushed_at":"2014-02-25T18:30:23Z","git_url":"git://github.com/mapbox/mbxmapkit.git","ssh_url":"git@github.com:mapbox/mbxmapkit.git","clone_url":"https://github.com/mapbox/mbxmapkit.git","svn_url":"https://github.com/mapbox/mbxmapkit","homepage":"","size":3044,"stargazers_count":189,"watchers_count":189,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":20,"mirror_url":null,"open_issues_count":18,"forks":20,"open_issues":18,"watchers":189,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mbxmapkit/pulls/23"},"html":{"href":"https://github.com/mapbox/mbxmapkit/pull/23"},"issue":{"href":"https://api.github.com/repos/mapbox/mbxmapkit/issues/23"},"comments":{"href":"https://api.github.com/repos/mapbox/mbxmapkit/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mbxmapkit/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mbxmapkit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mbxmapkit/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mbxmapkit/statuses/af8a45fdd338baf71ec27417c6282eafd2214ff3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"incanus","id":17722,"avatar_url":"https://gravatar.com/avatar/39f0706e7558c15a2abe1a0c5aba7fdf?d=https%3A%2F%2Fidenticons.github.com%2F657ad4f3e2afdf70f27fe834691fb65a.png&r=x","gravatar_id":"39f0706e7558c15a2abe1a0c5aba7fdf","url":"https://api.github.com/users/incanus","html_url":"https://github.com/incanus","followers_url":"https://api.github.com/users/incanus/followers","following_url":"https://api.github.com/users/incanus/following{/other_user}","gists_url":"https://api.github.com/users/incanus/gists{/gist_id}","starred_url":"https://api.github.com/users/incanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incanus/subscriptions","organizations_url":"https://api.github.com/users/incanus/orgs","repos_url":"https://api.github.com/users/incanus/repos","events_url":"https://api.github.com/users/incanus/events{/privacy}","received_events_url":"https://api.github.com/users/incanus/received_events","type":"User","site_admin":false},"comments":15,"review_comments":0,"commits":1,"additions":35,"deletions":4,"changed_files":1}}