GitHub PullRequestEvent at 2014-09-12 17:48:23
Repository: socorro
Actor: twobraids
Payload: {"action":"closed","number":2360,"pull_request":{"url":"https://api.github.com/repos/mozilla/socorro/pulls/2360","id":21151793,"html_url":"https://github.com/mozilla/socorro/pull/2360","diff_url":"https://github.com/mozilla/socorro/pull/2360.diff","patch_url":"https://github.com/mozilla/socorro/pull/2360.patch","issue_url":"https://api.github.com/repos/mozilla/socorro/issues/2360","number":2360,"state":"closed","locked":false,"title":"fixes Bug 1066316 - fix PG extension table insert for reprocessing jobs","user":{"login":"twobraids","id":581227,"avatar_url":"https://avatars.githubusercontent.com/u/581227?v=2","gravatar_id":"532ea239a8414ba61b469614dfce6144","url":"https://api.github.com/users/twobraids","html_url":"https://github.com/twobraids","followers_url":"https://api.github.com/users/twobraids/followers","following_url":"https://api.github.com/users/twobraids/following{/other_user}","gists_url":"https://api.github.com/users/twobraids/gists{/gist_id}","starred_url":"https://api.github.com/users/twobraids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twobraids/subscriptions","organizations_url":"https://api.github.com/users/twobraids/orgs","repos_url":"https://api.github.com/users/twobraids/repos","events_url":"https://api.github.com/users/twobraids/events{/privacy}","received_events_url":"https://api.github.com/users/twobraids/received_events","type":"User","site_admin":false},"body":"during reprocessing of a crash, the extensions associated with a crash may already exist in the extensions table.  The simple insert, unprotected by transaction checkpoints, will fail and derail the whole save to PG transaction. \r\n\r\nthis PR deletes the extensions data first then does the insert.  \r\n\r\nWhy not check to see if there is data already there and then just not insert if data is there?  We may be reprocessing to deal with missing extensions data, so just because there is already data there doesn't mean that we can skip this.\r\n\r\nWhat about using \"upsert\" sql - that would be fine and result in one fewer round trip between client and database, but \"upsert\" sql is opaque and not easy to understand at a glance.  This was faster to\r\nimplement.  \r\n\r\nWhat about using \"transaction check points\"? Too many round trips between the client and the server as each extension row insert would add two more client/server round trips.  \r\n","created_at":"2014-09-12T13:16:09Z","updated_at":"2014-09-12T17:48:23Z","closed_at":"2014-09-12T17:48:23Z","merged_at":"2014-09-12T17:48:23Z","merge_commit_sha":"7253dd26ebb9d8de3a83222dfec9f35b1202f722","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/socorro/pulls/2360/commits","review_comments_url":"https://api.github.com/repos/mozilla/socorro/pulls/2360/comments","review_comment_url":"https://api.github.com/repos/mozilla/socorro/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/socorro/issues/2360/comments","statuses_url":"https://api.github.com/repos/mozilla/socorro/statuses/2c449ec74683b6458d0f59367a4c77b949dadef2","head":{"label":"twobraids:clearer-than-upsert","ref":"clearer-than-upsert","sha":"2c449ec74683b6458d0f59367a4c77b949dadef2","user":{"login":"twobraids","id":581227,"avatar_url":"https://avatars.githubusercontent.com/u/581227?v=2","gravatar_id":"532ea239a8414ba61b469614dfce6144","url":"https://api.github.com/users/twobraids","html_url":"https://github.com/twobraids","followers_url":"https://api.github.com/users/twobraids/followers","following_url":"https://api.github.com/users/twobraids/following{/other_user}","gists_url":"https://api.github.com/users/twobraids/gists{/gist_id}","starred_url":"https://api.github.com/users/twobraids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twobraids/subscriptions","organizations_url":"https://api.github.com/users/twobraids/orgs","repos_url":"https://api.github.com/users/twobraids/repos","events_url":"https://api.github.com/users/twobraids/events{/privacy}","received_events_url":"https://api.github.com/users/twobraids/received_events","type":"User","site_admin":false},"repo":{"id":2617288,"name":"socorro","full_name":"twobraids/socorro","owner":{"login":"twobraids","id":581227,"avatar_url":"https://avatars.githubusercontent.com/u/581227?v=2","gravatar_id":"532ea239a8414ba61b469614dfce6144","url":"https://api.github.com/users/twobraids","html_url":"https://github.com/twobraids","followers_url":"https://api.github.com/users/twobraids/followers","following_url":"https://api.github.com/users/twobraids/following{/other_user}","gists_url":"https://api.github.com/users/twobraids/gists{/gist_id}","starred_url":"https://api.github.com/users/twobraids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twobraids/subscriptions","organizations_url":"https://api.github.com/users/twobraids/orgs","repos_url":"https://api.github.com/users/twobraids/repos","events_url":"https://api.github.com/users/twobraids/events{/privacy}","received_events_url":"https://api.github.com/users/twobraids/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twobraids/socorro","description":"Socorro is a server to accept and process Breakpad crash reports. ","fork":true,"url":"https://api.github.com/repos/twobraids/socorro","forks_url":"https://api.github.com/repos/twobraids/socorro/forks","keys_url":"https://api.github.com/repos/twobraids/socorro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twobraids/socorro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twobraids/socorro/teams","hooks_url":"https://api.github.com/repos/twobraids/socorro/hooks","issue_events_url":"https://api.github.com/repos/twobraids/socorro/issues/events{/number}","events_url":"https://api.github.com/repos/twobraids/socorro/events","assignees_url":"https://api.github.com/repos/twobraids/socorro/assignees{/user}","branches_url":"https://api.github.com/repos/twobraids/socorro/branches{/branch}","tags_url":"https://api.github.com/repos/twobraids/socorro/tags","blobs_url":"https://api.github.com/repos/twobraids/socorro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twobraids/socorro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twobraids/socorro/git/refs{/sha}","trees_url":"https://api.github.com/repos/twobraids/socorro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twobraids/socorro/statuses/{sha}","languages_url":"https://api.github.com/repos/twobraids/socorro/languages","stargazers_url":"https://api.github.com/repos/twobraids/socorro/stargazers","contributors_url":"https://api.github.com/repos/twobraids/socorro/contributors","subscribers_url":"https://api.github.com/repos/twobraids/socorro/subscribers","subscription_url":"https://api.github.com/repos/twobraids/socorro/subscription","commits_url":"https://api.github.com/repos/twobraids/socorro/commits{/sha}","git_commits_url":"https://api.github.com/repos/twobraids/socorro/git/commits{/sha}","comments_url":"https://api.github.com/repos/twobraids/socorro/comments{/number}","issue_comment_url":"https://api.github.com/repos/twobraids/socorro/issues/comments/{number}","contents_url":"https://api.github.com/repos/twobraids/socorro/contents/{+path}","compare_url":"https://api.github.com/repos/twobraids/socorro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twobraids/socorro/merges","archive_url":"https://api.github.com/repos/twobraids/socorro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twobraids/socorro/downloads","issues_url":"https://api.github.com/repos/twobraids/socorro/issues{/number}","pulls_url":"https://api.github.com/repos/twobraids/socorro/pulls{/number}","milestones_url":"https://api.github.com/repos/twobraids/socorro/milestones{/number}","notifications_url":"https://api.github.com/repos/twobraids/socorro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twobraids/socorro/labels{/name}","releases_url":"https://api.github.com/repos/twobraids/socorro/releases{/id}","created_at":"2011-10-21T00:42:48Z","updated_at":"2014-06-19T15:41:15Z","pushed_at":"2014-09-12T17:29:15Z","git_url":"git://github.com/twobraids/socorro.git","ssh_url":"git@github.com:twobraids/socorro.git","clone_url":"https://github.com/twobraids/socorro.git","svn_url":"https://github.com/twobraids/socorro","homepage":"https://wiki.mozilla.org/Socorro","size":162577,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"849858f46421a3ecb87b3da82b99cf12027214d0","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":2263742,"name":"socorro","full_name":"mozilla/socorro","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/socorro","description":"Socorro is a server to accept and process Breakpad crash reports. ","fork":false,"url":"https://api.github.com/repos/mozilla/socorro","forks_url":"https://api.github.com/repos/mozilla/socorro/forks","keys_url":"https://api.github.com/repos/mozilla/socorro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/socorro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/socorro/teams","hooks_url":"https://api.github.com/repos/mozilla/socorro/hooks","issue_events_url":"https://api.github.com/repos/mozilla/socorro/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/socorro/events","assignees_url":"https://api.github.com/repos/mozilla/socorro/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/socorro/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/socorro/tags","blobs_url":"https://api.github.com/repos/mozilla/socorro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/socorro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/socorro/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/socorro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/socorro/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/socorro/languages","stargazers_url":"https://api.github.com/repos/mozilla/socorro/stargazers","contributors_url":"https://api.github.com/repos/mozilla/socorro/contributors","subscribers_url":"https://api.github.com/repos/mozilla/socorro/subscribers","subscription_url":"https://api.github.com/repos/mozilla/socorro/subscription","commits_url":"https://api.github.com/repos/mozilla/socorro/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/socorro/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/socorro/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/socorro/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/socorro/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/socorro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/socorro/merges","archive_url":"https://api.github.com/repos/mozilla/socorro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/socorro/downloads","issues_url":"https://api.github.com/repos/mozilla/socorro/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/socorro/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/socorro/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/socorro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/socorro/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/socorro/releases{/id}","created_at":"2011-08-24T19:21:49Z","updated_at":"2014-09-09T01:39:52Z","pushed_at":"2014-09-12T17:48:23Z","git_url":"git://github.com/mozilla/socorro.git","ssh_url":"git@github.com:mozilla/socorro.git","clone_url":"https://github.com/mozilla/socorro.git","svn_url":"https://github.com/mozilla/socorro","homepage":"https://wiki.mozilla.org/Socorro","size":189285,"stargazers_count":187,"watchers_count":187,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":96,"mirror_url":null,"open_issues_count":0,"forks":96,"open_issues":0,"watchers":187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/2360"},"html":{"href":"https://github.com/mozilla/socorro/pull/2360"},"issue":{"href":"https://api.github.com/repos/mozilla/socorro/issues/2360"},"comments":{"href":"https://api.github.com/repos/mozilla/socorro/issues/2360/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/2360/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/socorro/pulls/2360/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/socorro/statuses/2c449ec74683b6458d0f59367a4c77b949dadef2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"twobraids","id":581227,"avatar_url":"https://avatars.githubusercontent.com/u/581227?v=2","gravatar_id":"532ea239a8414ba61b469614dfce6144","url":"https://api.github.com/users/twobraids","html_url":"https://github.com/twobraids","followers_url":"https://api.github.com/users/twobraids/followers","following_url":"https://api.github.com/users/twobraids/following{/other_user}","gists_url":"https://api.github.com/users/twobraids/gists{/gist_id}","starred_url":"https://api.github.com/users/twobraids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twobraids/subscriptions","organizations_url":"https://api.github.com/users/twobraids/orgs","repos_url":"https://api.github.com/users/twobraids/repos","events_url":"https://api.github.com/users/twobraids/events{/privacy}","received_events_url":"https://api.github.com/users/twobraids/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"commits":1,"additions":30,"deletions":6,"changed_files":2}}