GitHub PullRequestReviewCommentEvent at 2014-08-12 03:20:21
Repository: runtime
Actor: rwaldron
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/tessel/runtime/pulls/comments/16093937","id":16093937,"diff_hunk":"@@ -273,7 +273,13 @@ static int l_regex_replace (lua_State *L)\n       const char* sect = NULL;\n       if (lua_isnil(L, -1)) {\n         sect = \"undefined\";\n-        sect_len = 9;\n+        sect_len = strlen(\"undefined\");\n+      } else if (lua_isboolean(L, -1) && lua_toboolean(L, -1) == 1) {\n+        sect = \"true\";\n+        sect_len = strlen(\"true\");\n+      } else if (lua_isboolean(L, -1) && lua_toboolean(L, -1) == 0) {\n+        sect = \"false\";\n+        sect_len = strlen(\"false\");","path":"src/colony/lua_hsregex.c","position":11,"original_position":11,"commit_id":"7f4d723a7a1a77ee45b9d17167cce9d1a337b7bc","original_commit_id":"7f4d723a7a1a77ee45b9d17167cce9d1a337b7bc","user":{"login":"rwaldron","id":27985,"avatar_url":"https://avatars.githubusercontent.com/u/27985?v=2","gravatar_id":"36c697d974542aadaee06a0f39cb1437","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"body":"I'm not familiar enough with this layer, but is the result just a value coerced to a string? That's all that's supposed to happen: http://es5.github.io/#x15.5.4.11 \r\n\r\n> The result is a String value derived from the original input by replacing each matched substring with the corresponding return value of the function call, converted to a String if need be.\r\n","created_at":"2014-08-12T03:20:21Z","updated_at":"2014-08-12T03:20:21Z","html_url":"https://github.com/tessel/runtime/pull/394#discussion_r16093937","pull_request_url":"https://api.github.com/repos/tessel/runtime/pulls/394","_links":{"self":{"href":"https://api.github.com/repos/tessel/runtime/pulls/comments/16093937"},"html":{"href":"https://github.com/tessel/runtime/pull/394#discussion_r16093937"},"pull_request":{"href":"https://api.github.com/repos/tessel/runtime/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/tessel/runtime/pulls/394","id":19640373,"html_url":"https://github.com/tessel/runtime/pull/394","diff_url":"https://github.com/tessel/runtime/pull/394.diff","patch_url":"https://github.com/tessel/runtime/pull/394.patch","issue_url":"https://api.github.com/repos/tessel/runtime/issues/394","number":394,"state":"open","title":"Implements \"true\" and \"false\" in regex replace. Fixes #292.","user":{"login":"tcr","id":80639,"avatar_url":"https://avatars.githubusercontent.com/u/80639?v=2","gravatar_id":"281c788cb0df2e48454ccda6ba623286","url":"https://api.github.com/users/tcr","html_url":"https://github.com/tcr","followers_url":"https://api.github.com/users/tcr/followers","following_url":"https://api.github.com/users/tcr/following{/other_user}","gists_url":"https://api.github.com/users/tcr/gists{/gist_id}","starred_url":"https://api.github.com/users/tcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcr/subscriptions","organizations_url":"https://api.github.com/users/tcr/orgs","repos_url":"https://api.github.com/users/tcr/repos","events_url":"https://api.github.com/users/tcr/events{/privacy}","received_events_url":"https://api.github.com/users/tcr/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-12T03:00:59Z","updated_at":"2014-08-12T03:20:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"106723d8f27f8b41aeabe9a8462286a7b59d19db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tessel/runtime/pulls/394/commits","review_comments_url":"https://api.github.com/repos/tessel/runtime/pulls/394/comments","review_comment_url":"https://api.github.com/repos/tessel/runtime/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tessel/runtime/issues/394/comments","statuses_url":"https://api.github.com/repos/tessel/runtime/statuses/7f4d723a7a1a77ee45b9d17167cce9d1a337b7bc","head":{"label":"tessel:tcr-292","ref":"tcr-292","sha":"7f4d723a7a1a77ee45b9d17167cce9d1a337b7bc","user":{"login":"tessel","id":5573563,"avatar_url":"https://avatars.githubusercontent.com/u/5573563?v=2","gravatar_id":"9c6fed6c1f75a3051ddf064b9a91c841","url":"https://api.github.com/users/tessel","html_url":"https://github.com/tessel","followers_url":"https://api.github.com/users/tessel/followers","following_url":"https://api.github.com/users/tessel/following{/other_user}","gists_url":"https://api.github.com/users/tessel/gists{/gist_id}","starred_url":"https://api.github.com/users/tessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tessel/subscriptions","organizations_url":"https://api.github.com/users/tessel/orgs","repos_url":"https://api.github.com/users/tessel/repos","events_url":"https://api.github.com/users/tessel/events{/privacy}","received_events_url":"https://api.github.com/users/tessel/received_events","type":"Organization","site_admin":false},"repo":{"id":14543043,"name":"runtime","full_name":"tessel/runtime","owner":{"login":"tessel","id":5573563,"avatar_url":"https://avatars.githubusercontent.com/u/5573563?v=2","gravatar_id":"9c6fed6c1f75a3051ddf064b9a91c841","url":"https://api.github.com/users/tessel","html_url":"https://github.com/tessel","followers_url":"https://api.github.com/users/tessel/followers","following_url":"https://api.github.com/users/tessel/following{/other_user}","gists_url":"https://api.github.com/users/tessel/gists{/gist_id}","starred_url":"https://api.github.com/users/tessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tessel/subscriptions","organizations_url":"https://api.github.com/users/tessel/orgs","repos_url":"https://api.github.com/users/tessel/repos","events_url":"https://api.github.com/users/tessel/events{/privacy}","received_events_url":"https://api.github.com/users/tessel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tessel/runtime","description":"Tessel JS runtime","fork":false,"url":"https://api.github.com/repos/tessel/runtime","forks_url":"https://api.github.com/repos/tessel/runtime/forks","keys_url":"https://api.github.com/repos/tessel/runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tessel/runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tessel/runtime/teams","hooks_url":"https://api.github.com/repos/tessel/runtime/hooks","issue_events_url":"https://api.github.com/repos/tessel/runtime/issues/events{/number}","events_url":"https://api.github.com/repos/tessel/runtime/events","assignees_url":"https://api.github.com/repos/tessel/runtime/assignees{/user}","branches_url":"https://api.github.com/repos/tessel/runtime/branches{/branch}","tags_url":"https://api.github.com/repos/tessel/runtime/tags","blobs_url":"https://api.github.com/repos/tessel/runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tessel/runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tessel/runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/tessel/runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tessel/runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/tessel/runtime/languages","stargazers_url":"https://api.github.com/repos/tessel/runtime/stargazers","contributors_url":"https://api.github.com/repos/tessel/runtime/contributors","subscribers_url":"https://api.github.com/repos/tessel/runtime/subscribers","subscription_url":"https://api.github.com/repos/tessel/runtime/subscription","commits_url":"https://api.github.com/repos/tessel/runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/tessel/runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/tessel/runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/tessel/runtime/issues/comments/{number}","contents_url":"https://api.github.com/repos/tessel/runtime/contents/{+path}","compare_url":"https://api.github.com/repos/tessel/runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tessel/runtime/merges","archive_url":"https://api.github.com/repos/tessel/runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tessel/runtime/downloads","issues_url":"https://api.github.com/repos/tessel/runtime/issues{/number}","pulls_url":"https://api.github.com/repos/tessel/runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/tessel/runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/tessel/runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tessel/runtime/labels{/name}","releases_url":"https://api.github.com/repos/tessel/runtime/releases{/id}","created_at":"2013-11-20T01:16:24Z","updated_at":"2014-08-08T10:53:50Z","pushed_at":"2014-08-12T03:06:41Z","git_url":"git://github.com/tessel/runtime.git","ssh_url":"git@github.com:tessel/runtime.git","clone_url":"https://github.com/tessel/runtime.git","svn_url":"https://github.com/tessel/runtime","homepage":"","size":29598,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":14,"mirror_url":null,"open_issues_count":119,"forks":14,"open_issues":119,"watchers":37,"default_branch":"master"}},"base":{"label":"tessel:master","ref":"master","sha":"5d82284076f8873cfdbd185fd84aac2965631117","user":{"login":"tessel","id":5573563,"avatar_url":"https://avatars.githubusercontent.com/u/5573563?v=2","gravatar_id":"9c6fed6c1f75a3051ddf064b9a91c841","url":"https://api.github.com/users/tessel","html_url":"https://github.com/tessel","followers_url":"https://api.github.com/users/tessel/followers","following_url":"https://api.github.com/users/tessel/following{/other_user}","gists_url":"https://api.github.com/users/tessel/gists{/gist_id}","starred_url":"https://api.github.com/users/tessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tessel/subscriptions","organizations_url":"https://api.github.com/users/tessel/orgs","repos_url":"https://api.github.com/users/tessel/repos","events_url":"https://api.github.com/users/tessel/events{/privacy}","received_events_url":"https://api.github.com/users/tessel/received_events","type":"Organization","site_admin":false},"repo":{"id":14543043,"name":"runtime","full_name":"tessel/runtime","owner":{"login":"tessel","id":5573563,"avatar_url":"https://avatars.githubusercontent.com/u/5573563?v=2","gravatar_id":"9c6fed6c1f75a3051ddf064b9a91c841","url":"https://api.github.com/users/tessel","html_url":"https://github.com/tessel","followers_url":"https://api.github.com/users/tessel/followers","following_url":"https://api.github.com/users/tessel/following{/other_user}","gists_url":"https://api.github.com/users/tessel/gists{/gist_id}","starred_url":"https://api.github.com/users/tessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tessel/subscriptions","organizations_url":"https://api.github.com/users/tessel/orgs","repos_url":"https://api.github.com/users/tessel/repos","events_url":"https://api.github.com/users/tessel/events{/privacy}","received_events_url":"https://api.github.com/users/tessel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tessel/runtime","description":"Tessel JS runtime","fork":false,"url":"https://api.github.com/repos/tessel/runtime","forks_url":"https://api.github.com/repos/tessel/runtime/forks","keys_url":"https://api.github.com/repos/tessel/runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tessel/runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tessel/runtime/teams","hooks_url":"https://api.github.com/repos/tessel/runtime/hooks","issue_events_url":"https://api.github.com/repos/tessel/runtime/issues/events{/number}","events_url":"https://api.github.com/repos/tessel/runtime/events","assignees_url":"https://api.github.com/repos/tessel/runtime/assignees{/user}","branches_url":"https://api.github.com/repos/tessel/runtime/branches{/branch}","tags_url":"https://api.github.com/repos/tessel/runtime/tags","blobs_url":"https://api.github.com/repos/tessel/runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tessel/runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tessel/runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/tessel/runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tessel/runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/tessel/runtime/languages","stargazers_url":"https://api.github.com/repos/tessel/runtime/stargazers","contributors_url":"https://api.github.com/repos/tessel/runtime/contributors","subscribers_url":"https://api.github.com/repos/tessel/runtime/subscribers","subscription_url":"https://api.github.com/repos/tessel/runtime/subscription","commits_url":"https://api.github.com/repos/tessel/runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/tessel/runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/tessel/runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/tessel/runtime/issues/comments/{number}","contents_url":"https://api.github.com/repos/tessel/runtime/contents/{+path}","compare_url":"https://api.github.com/repos/tessel/runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tessel/runtime/merges","archive_url":"https://api.github.com/repos/tessel/runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tessel/runtime/downloads","issues_url":"https://api.github.com/repos/tessel/runtime/issues{/number}","pulls_url":"https://api.github.com/repos/tessel/runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/tessel/runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/tessel/runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tessel/runtime/labels{/name}","releases_url":"https://api.github.com/repos/tessel/runtime/releases{/id}","created_at":"2013-11-20T01:16:24Z","updated_at":"2014-08-08T10:53:50Z","pushed_at":"2014-08-12T03:06:41Z","git_url":"git://github.com/tessel/runtime.git","ssh_url":"git@github.com:tessel/runtime.git","clone_url":"https://github.com/tessel/runtime.git","svn_url":"https://github.com/tessel/runtime","homepage":"","size":29598,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":14,"mirror_url":null,"open_issues_count":119,"forks":14,"open_issues":119,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tessel/runtime/pulls/394"},"html":{"href":"https://github.com/tessel/runtime/pull/394"},"issue":{"href":"https://api.github.com/repos/tessel/runtime/issues/394"},"comments":{"href":"https://api.github.com/repos/tessel/runtime/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/tessel/runtime/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/tessel/runtime/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tessel/runtime/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/tessel/runtime/statuses/7f4d723a7a1a77ee45b9d17167cce9d1a337b7bc"}}}}