GitHub PullRequestReviewCommentEvent at 2014-10-13 15:11:14
Repository: frontend
Actor: benlovell
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments/18774743","id":18774743,"diff_hunk":"@@ -0,0 +1,39 @@\n+RSpec.describe EmbeddedToolsController do\n+\n+  describe \"#alternate_url\" do\n+    before do\n+      allow(subject).to receive(:url_for).and_return('http://some.url')\n+    end\n+\n+    context \"no alternate_url on the mount_point\" do\n+      let(:mount_point){\n+        double(alternate_locale: 'en', alternate_tool_id: 'tool_name' )\n+      }\n+\n+      it \"ignores the mount point\" do\n+        allow(ToolMountPoint).to receive(:for).and_return(mount_point)\n+        expect( subject.send(:alternate_url) ).to eq('http://some.url')","path":"spec/controllers/embedded_tools_controller_spec.rb","position":15,"original_position":15,"commit_id":"04a26ebb516e77252faad81842339315488af078","original_commit_id":"04a26ebb516e77252faad81842339315488af078","user":{"login":"benlovell","id":41963,"avatar_url":"https://avatars.githubusercontent.com/u/41963?v=2","gravatar_id":"","url":"https://api.github.com/users/benlovell","html_url":"https://github.com/benlovell","followers_url":"https://api.github.com/users/benlovell/followers","following_url":"https://api.github.com/users/benlovell/following{/other_user}","gists_url":"https://api.github.com/users/benlovell/gists{/gist_id}","starred_url":"https://api.github.com/users/benlovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlovell/subscriptions","organizations_url":"https://api.github.com/users/benlovell/orgs","repos_url":"https://api.github.com/users/benlovell/repos","events_url":"https://api.github.com/users/benlovell/events{/privacy}","received_events_url":"https://api.github.com/users/benlovell/received_events","type":"User","site_admin":false},"body":"Can you quote strings consistently.","created_at":"2014-10-13T15:11:14Z","updated_at":"2014-10-13T15:11:14Z","html_url":"https://github.com/moneyadviceservice/frontend/pull/719#discussion_r18774743","pull_request_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/719","_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments/18774743"},"html":{"href":"https://github.com/moneyadviceservice/frontend/pull/719#discussion_r18774743"},"pull_request":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/719"}}},"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/719","id":22650798,"html_url":"https://github.com/moneyadviceservice/frontend/pull/719","diff_url":"https://github.com/moneyadviceservice/frontend/pull/719.diff","patch_url":"https://github.com/moneyadviceservice/frontend/pull/719.patch","issue_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/719","number":719,"state":"open","locked":false,"title":"Mount mortgage_calculator","user":{"login":"mconnell","id":32398,"avatar_url":"https://avatars.githubusercontent.com/u/32398?v=2","gravatar_id":"","url":"https://api.github.com/users/mconnell","html_url":"https://github.com/mconnell","followers_url":"https://api.github.com/users/mconnell/followers","following_url":"https://api.github.com/users/mconnell/following{/other_user}","gists_url":"https://api.github.com/users/mconnell/gists{/gist_id}","starred_url":"https://api.github.com/users/mconnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconnell/subscriptions","organizations_url":"https://api.github.com/users/mconnell/orgs","repos_url":"https://api.github.com/users/mconnell/repos","events_url":"https://api.github.com/users/mconnell/events{/privacy}","received_events_url":"https://api.github.com/users/mconnell/received_events","type":"User","site_admin":false},"body":"This PR adds version 1.0.0 of the mortgage_calculator to frontend.","created_at":"2014-10-13T15:00:57Z","updated_at":"2014-10-13T15:11:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3519f72dccbd6fa587379b6afbb2d1dff6116fc7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/719/commits","review_comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/719/comments","review_comment_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/719/comments","statuses_url":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/04a26ebb516e77252faad81842339315488af078","head":{"label":"moneyadviceservice:mount_mortgage_calculator","ref":"mount_mortgage_calculator","sha":"04a26ebb516e77252faad81842339315488af078","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=2","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":15315123,"name":"frontend","full_name":"moneyadviceservice/frontend","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=2","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/frontend","description":"The Money Advice Service's improved website.","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/frontend","forks_url":"https://api.github.com/repos/moneyadviceservice/frontend/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/frontend/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/frontend/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/frontend/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/frontend/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/frontend/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/frontend/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/moneyadviceservice/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/frontend/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/frontend/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/frontend/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/frontend/releases{/id}","created_at":"2013-12-19T15:25:21Z","updated_at":"2014-09-24T13:05:02Z","pushed_at":"2014-10-13T14:55:27Z","git_url":"git://github.com/moneyadviceservice/frontend.git","ssh_url":"git@github.com:moneyadviceservice/frontend.git","clone_url":"https://github.com/moneyadviceservice/frontend.git","svn_url":"https://github.com/moneyadviceservice/frontend","homepage":"https://www.moneyadviceservice.org.uk  ","size":53248,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":2,"default_branch":"master"}},"base":{"label":"moneyadviceservice:master","ref":"master","sha":"b49861acf839d9ebfb5f178296b0e79190daa722","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=2","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":15315123,"name":"frontend","full_name":"moneyadviceservice/frontend","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=2","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/frontend","description":"The Money Advice Service's improved website.","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/frontend","forks_url":"https://api.github.com/repos/moneyadviceservice/frontend/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/frontend/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/frontend/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/frontend/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/frontend/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/frontend/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/frontend/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/moneyadviceservice/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/frontend/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/frontend/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/frontend/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/frontend/releases{/id}","created_at":"2013-12-19T15:25:21Z","updated_at":"2014-09-24T13:05:02Z","pushed_at":"2014-10-13T14:55:27Z","git_url":"git://github.com/moneyadviceservice/frontend.git","ssh_url":"git@github.com:moneyadviceservice/frontend.git","clone_url":"https://github.com/moneyadviceservice/frontend.git","svn_url":"https://github.com/moneyadviceservice/frontend","homepage":"https://www.moneyadviceservice.org.uk  ","size":53248,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/719"},"html":{"href":"https://github.com/moneyadviceservice/frontend/pull/719"},"issue":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/issues/719"},"comments":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/issues/719/comments"},"review_comments":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/719/comments"},"review_comment":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/719/commits"},"statuses":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/04a26ebb516e77252faad81842339315488af078"}}}}