GitHub PullRequestEvent at 2014-06-27 17:40:49
Repository: http
Actor: jeffbcross
Payload: {"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/angular/http/pulls/28","id":17490427,"html_url":"https://github.com/angular/http/pull/28","diff_url":"https://github.com/angular/http/pull/28.diff","patch_url":"https://github.com/angular/http/pull/28.patch","issue_url":"https://api.github.com/repos/angular/http/issues/28","number":28,"state":"closed","title":"fix(http): strip hash fragment in fullUrl()","user":{"login":"caitp","id":2294695,"avatar_url":"https://avatars.githubusercontent.com/u/2294695?","gravatar_id":"bf1b0db965c4015382f468b96b72d87e","url":"https://api.github.com/users/caitp","html_url":"https://github.com/caitp","followers_url":"https://api.github.com/users/caitp/followers","following_url":"https://api.github.com/users/caitp/following{/other_user}","gists_url":"https://api.github.com/users/caitp/gists{/gist_id}","starred_url":"https://api.github.com/users/caitp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caitp/subscriptions","organizations_url":"https://api.github.com/users/caitp/orgs","repos_url":"https://api.github.com/users/caitp/repos","events_url":"https://api.github.com/users/caitp/events{/privacy}","received_events_url":"https://api.github.com/users/caitp/received_events","type":"User","site_admin":false},"body":"Useful in cases where location.url is used, or when a hash fragment is inadvertently included.\n\nThis does not solve the case where HTML5-mode is not supported and local paths use something like index.html#/users. That's a case which may be worth solving, but it's a fair bit harder, and eventually won't be worth solving at all.\n\nCloses #27","created_at":"2014-06-23T18:25:23Z","updated_at":"2014-06-27T17:40:49Z","closed_at":"2014-06-27T17:40:49Z","merged_at":null,"merge_commit_sha":"a7152d505e6a13b08a4d5c169ce4cc6e93bf4983","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular/http/milestones/1","labels_url":"https://api.github.com/repos/angular/http/milestones/1/labels","id":596580,"number":1,"title":"2.0.0-pre-1","description":"Foundation for ngHttp module.","creator":{"login":"jeffbcross","id":463703,"avatar_url":"https://avatars.githubusercontent.com/u/463703?","gravatar_id":"007ba2fad36ea1313710744713dd6594","url":"https://api.github.com/users/jeffbcross","html_url":"https://github.com/jeffbcross","followers_url":"https://api.github.com/users/jeffbcross/followers","following_url":"https://api.github.com/users/jeffbcross/following{/other_user}","gists_url":"https://api.github.com/users/jeffbcross/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbcross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbcross/subscriptions","organizations_url":"https://api.github.com/users/jeffbcross/orgs","repos_url":"https://api.github.com/users/jeffbcross/repos","events_url":"https://api.github.com/users/jeffbcross/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbcross/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":6,"state":"open","created_at":"2014-03-13T21:01:12Z","updated_at":"2014-06-27T17:40:49Z","due_on":null},"commits_url":"https://api.github.com/repos/angular/http/pulls/28/commits","review_comments_url":"https://api.github.com/repos/angular/http/pulls/28/comments","review_comment_url":"https://api.github.com/repos/angular/http/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular/http/issues/28/comments","statuses_url":"https://api.github.com/repos/angular/http/statuses/69396ffffae40df967481af5e8f00a94634007c9","head":{"label":"caitp:issue-27","ref":"issue-27","sha":"69396ffffae40df967481af5e8f00a94634007c9","user":{"login":"caitp","id":2294695,"avatar_url":"https://avatars.githubusercontent.com/u/2294695?","gravatar_id":"bf1b0db965c4015382f468b96b72d87e","url":"https://api.github.com/users/caitp","html_url":"https://github.com/caitp","followers_url":"https://api.github.com/users/caitp/followers","following_url":"https://api.github.com/users/caitp/following{/other_user}","gists_url":"https://api.github.com/users/caitp/gists{/gist_id}","starred_url":"https://api.github.com/users/caitp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caitp/subscriptions","organizations_url":"https://api.github.com/users/caitp/orgs","repos_url":"https://api.github.com/users/caitp/repos","events_url":"https://api.github.com/users/caitp/events{/privacy}","received_events_url":"https://api.github.com/users/caitp/received_events","type":"User","site_admin":false},"repo":{"id":21010548,"name":"http","full_name":"caitp/http","owner":{"login":"caitp","id":2294695,"avatar_url":"https://avatars.githubusercontent.com/u/2294695?","gravatar_id":"bf1b0db965c4015382f468b96b72d87e","url":"https://api.github.com/users/caitp","html_url":"https://github.com/caitp","followers_url":"https://api.github.com/users/caitp/followers","following_url":"https://api.github.com/users/caitp/following{/other_user}","gists_url":"https://api.github.com/users/caitp/gists{/gist_id}","starred_url":"https://api.github.com/users/caitp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caitp/subscriptions","organizations_url":"https://api.github.com/users/caitp/orgs","repos_url":"https://api.github.com/users/caitp/repos","events_url":"https://api.github.com/users/caitp/events{/privacy}","received_events_url":"https://api.github.com/users/caitp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caitp/http","description":"Angular 2.0 HTTP Module","fork":true,"url":"https://api.github.com/repos/caitp/http","forks_url":"https://api.github.com/repos/caitp/http/forks","keys_url":"https://api.github.com/repos/caitp/http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caitp/http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caitp/http/teams","hooks_url":"https://api.github.com/repos/caitp/http/hooks","issue_events_url":"https://api.github.com/repos/caitp/http/issues/events{/number}","events_url":"https://api.github.com/repos/caitp/http/events","assignees_url":"https://api.github.com/repos/caitp/http/assignees{/user}","branches_url":"https://api.github.com/repos/caitp/http/branches{/branch}","tags_url":"https://api.github.com/repos/caitp/http/tags","blobs_url":"https://api.github.com/repos/caitp/http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caitp/http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caitp/http/git/refs{/sha}","trees_url":"https://api.github.com/repos/caitp/http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caitp/http/statuses/{sha}","languages_url":"https://api.github.com/repos/caitp/http/languages","stargazers_url":"https://api.github.com/repos/caitp/http/stargazers","contributors_url":"https://api.github.com/repos/caitp/http/contributors","subscribers_url":"https://api.github.com/repos/caitp/http/subscribers","subscription_url":"https://api.github.com/repos/caitp/http/subscription","commits_url":"https://api.github.com/repos/caitp/http/commits{/sha}","git_commits_url":"https://api.github.com/repos/caitp/http/git/commits{/sha}","comments_url":"https://api.github.com/repos/caitp/http/comments{/number}","issue_comment_url":"https://api.github.com/repos/caitp/http/issues/comments/{number}","contents_url":"https://api.github.com/repos/caitp/http/contents/{+path}","compare_url":"https://api.github.com/repos/caitp/http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caitp/http/merges","archive_url":"https://api.github.com/repos/caitp/http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caitp/http/downloads","issues_url":"https://api.github.com/repos/caitp/http/issues{/number}","pulls_url":"https://api.github.com/repos/caitp/http/pulls{/number}","milestones_url":"https://api.github.com/repos/caitp/http/milestones{/number}","notifications_url":"https://api.github.com/repos/caitp/http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caitp/http/labels{/name}","releases_url":"https://api.github.com/repos/caitp/http/releases{/id}","created_at":"2014-06-19T18:12:05Z","updated_at":"2014-06-23T19:56:07Z","pushed_at":"2014-06-23T18:22:46Z","git_url":"git://github.com/caitp/http.git","ssh_url":"git@github.com:caitp/http.git","clone_url":"https://github.com/caitp/http.git","svn_url":"https://github.com/caitp/http","homepage":null,"size":344,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"233d6a71453e764d60d6adc6571fd62a9fe6afe1","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?","gravatar_id":"f0d91e5cf8ad1ce7972cc486baa20c42","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":17232013,"name":"http","full_name":"angular/http","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?","gravatar_id":"f0d91e5cf8ad1ce7972cc486baa20c42","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/http","description":"Angular 2.0 HTTP Module","fork":false,"url":"https://api.github.com/repos/angular/http","forks_url":"https://api.github.com/repos/angular/http/forks","keys_url":"https://api.github.com/repos/angular/http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/http/teams","hooks_url":"https://api.github.com/repos/angular/http/hooks","issue_events_url":"https://api.github.com/repos/angular/http/issues/events{/number}","events_url":"https://api.github.com/repos/angular/http/events","assignees_url":"https://api.github.com/repos/angular/http/assignees{/user}","branches_url":"https://api.github.com/repos/angular/http/branches{/branch}","tags_url":"https://api.github.com/repos/angular/http/tags","blobs_url":"https://api.github.com/repos/angular/http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/http/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/http/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/http/languages","stargazers_url":"https://api.github.com/repos/angular/http/stargazers","contributors_url":"https://api.github.com/repos/angular/http/contributors","subscribers_url":"https://api.github.com/repos/angular/http/subscribers","subscription_url":"https://api.github.com/repos/angular/http/subscription","commits_url":"https://api.github.com/repos/angular/http/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/http/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/http/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/http/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular/http/contents/{+path}","compare_url":"https://api.github.com/repos/angular/http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/http/merges","archive_url":"https://api.github.com/repos/angular/http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/http/downloads","issues_url":"https://api.github.com/repos/angular/http/issues{/number}","pulls_url":"https://api.github.com/repos/angular/http/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/http/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/http/labels{/name}","releases_url":"https://api.github.com/repos/angular/http/releases{/id}","created_at":"2014-02-27T01:14:13Z","updated_at":"2014-06-25T13:31:31Z","pushed_at":"2014-06-27T17:37:51Z","git_url":"git://github.com/angular/http.git","ssh_url":"git@github.com:angular/http.git","clone_url":"https://github.com/angular/http.git","svn_url":"https://github.com/angular/http","homepage":null,"size":603,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":3,"mirror_url":null,"open_issues_count":16,"forks":3,"open_issues":16,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/http/pulls/28"},"html":{"href":"https://github.com/angular/http/pull/28"},"issue":{"href":"https://api.github.com/repos/angular/http/issues/28"},"comments":{"href":"https://api.github.com/repos/angular/http/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/http/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/http/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular/http/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/angular/http/statuses/69396ffffae40df967481af5e8f00a94634007c9"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":10,"deletions":0,"changed_files":2}}