GitHub PullRequestReviewCommentEvent at 2014-10-09 20:15:56
Repository: slate
Actor: kevin-buttercoin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/tripit/slate/pulls/comments/18671082","id":18671082,"diff_hunk":"@@ -53,7 +53,7 @@\n         });\n         highlight.call(this);\n       } else {\n-        searchResults.html('<li>No Results Found for \"' + this.value + '\"</li>');\n+        searchResults.html('<li>No Results Found for \"' + this.value.escapeHTML() + '\"</li>');","path":"source/javascripts/app/search.js","position":5,"original_position":5,"commit_id":"b40b3b47ed69cd2f130958eb733ad7e9efa996a7","original_commit_id":"b40b3b47ed69cd2f130958eb733ad7e9efa996a7","user":{"login":"kevin-buttercoin","id":4991153,"avatar_url":"https://avatars.githubusercontent.com/u/4991153?v=2","gravatar_id":"","url":"https://api.github.com/users/kevin-buttercoin","html_url":"https://github.com/kevin-buttercoin","followers_url":"https://api.github.com/users/kevin-buttercoin/followers","following_url":"https://api.github.com/users/kevin-buttercoin/following{/other_user}","gists_url":"https://api.github.com/users/kevin-buttercoin/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-buttercoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-buttercoin/subscriptions","organizations_url":"https://api.github.com/users/kevin-buttercoin/orgs","repos_url":"https://api.github.com/users/kevin-buttercoin/repos","events_url":"https://api.github.com/users/kevin-buttercoin/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-buttercoin/received_events","type":"User","site_admin":false},"body":"Yeah, no worries.  I didn't actually realize that .text escaped the value, so that's way better.  I'll make the change and submit it. :)","created_at":"2014-10-09T20:15:56Z","updated_at":"2014-10-09T20:15:56Z","html_url":"https://github.com/tripit/slate/pull/113#discussion_r18671082","pull_request_url":"https://api.github.com/repos/tripit/slate/pulls/113","_links":{"self":{"href":"https://api.github.com/repos/tripit/slate/pulls/comments/18671082"},"html":{"href":"https://github.com/tripit/slate/pull/113#discussion_r18671082"},"pull_request":{"href":"https://api.github.com/repos/tripit/slate/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/tripit/slate/pulls/113","id":22463050,"html_url":"https://github.com/tripit/slate/pull/113","diff_url":"https://github.com/tripit/slate/pull/113.diff","patch_url":"https://github.com/tripit/slate/pull/113.patch","issue_url":"https://api.github.com/repos/tripit/slate/issues/113","number":113,"state":"open","locked":false,"title":"fixed XSS vuln in searchbox","user":{"login":"kevin-buttercoin","id":4991153,"avatar_url":"https://avatars.githubusercontent.com/u/4991153?v=2","gravatar_id":"","url":"https://api.github.com/users/kevin-buttercoin","html_url":"https://github.com/kevin-buttercoin","followers_url":"https://api.github.com/users/kevin-buttercoin/followers","following_url":"https://api.github.com/users/kevin-buttercoin/following{/other_user}","gists_url":"https://api.github.com/users/kevin-buttercoin/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-buttercoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-buttercoin/subscriptions","organizations_url":"https://api.github.com/users/kevin-buttercoin/orgs","repos_url":"https://api.github.com/users/kevin-buttercoin/repos","events_url":"https://api.github.com/users/kevin-buttercoin/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-buttercoin/received_events","type":"User","site_admin":false},"body":"Fixes issue described here:\r\n\r\nhttps://github.com/tripit/slate/issues/112","created_at":"2014-10-08T23:41:39Z","updated_at":"2014-10-09T20:15:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bec949af20a37f334114f77d2b683feb411a30f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tripit/slate/pulls/113/commits","review_comments_url":"https://api.github.com/repos/tripit/slate/pulls/113/comments","review_comment_url":"https://api.github.com/repos/tripit/slate/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tripit/slate/issues/113/comments","statuses_url":"https://api.github.com/repos/tripit/slate/statuses/b40b3b47ed69cd2f130958eb733ad7e9efa996a7","head":{"label":"kevin-buttercoin:master","ref":"master","sha":"b40b3b47ed69cd2f130958eb733ad7e9efa996a7","user":{"login":"kevin-buttercoin","id":4991153,"avatar_url":"https://avatars.githubusercontent.com/u/4991153?v=2","gravatar_id":"","url":"https://api.github.com/users/kevin-buttercoin","html_url":"https://github.com/kevin-buttercoin","followers_url":"https://api.github.com/users/kevin-buttercoin/followers","following_url":"https://api.github.com/users/kevin-buttercoin/following{/other_user}","gists_url":"https://api.github.com/users/kevin-buttercoin/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-buttercoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-buttercoin/subscriptions","organizations_url":"https://api.github.com/users/kevin-buttercoin/orgs","repos_url":"https://api.github.com/users/kevin-buttercoin/repos","events_url":"https://api.github.com/users/kevin-buttercoin/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-buttercoin/received_events","type":"User","site_admin":false},"repo":{"id":24965560,"name":"slate","full_name":"kevin-buttercoin/slate","owner":{"login":"kevin-buttercoin","id":4991153,"avatar_url":"https://avatars.githubusercontent.com/u/4991153?v=2","gravatar_id":"","url":"https://api.github.com/users/kevin-buttercoin","html_url":"https://github.com/kevin-buttercoin","followers_url":"https://api.github.com/users/kevin-buttercoin/followers","following_url":"https://api.github.com/users/kevin-buttercoin/following{/other_user}","gists_url":"https://api.github.com/users/kevin-buttercoin/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-buttercoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-buttercoin/subscriptions","organizations_url":"https://api.github.com/users/kevin-buttercoin/orgs","repos_url":"https://api.github.com/users/kevin-buttercoin/repos","events_url":"https://api.github.com/users/kevin-buttercoin/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-buttercoin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevin-buttercoin/slate","description":"Beautiful static documentation for your API","fork":true,"url":"https://api.github.com/repos/kevin-buttercoin/slate","forks_url":"https://api.github.com/repos/kevin-buttercoin/slate/forks","keys_url":"https://api.github.com/repos/kevin-buttercoin/slate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevin-buttercoin/slate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevin-buttercoin/slate/teams","hooks_url":"https://api.github.com/repos/kevin-buttercoin/slate/hooks","issue_events_url":"https://api.github.com/repos/kevin-buttercoin/slate/issues/events{/number}","events_url":"https://api.github.com/repos/kevin-buttercoin/slate/events","assignees_url":"https://api.github.com/repos/kevin-buttercoin/slate/assignees{/user}","branches_url":"https://api.github.com/repos/kevin-buttercoin/slate/branches{/branch}","tags_url":"https://api.github.com/repos/kevin-buttercoin/slate/tags","blobs_url":"https://api.github.com/repos/kevin-buttercoin/slate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevin-buttercoin/slate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevin-buttercoin/slate/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevin-buttercoin/slate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevin-buttercoin/slate/statuses/{sha}","languages_url":"https://api.github.com/repos/kevin-buttercoin/slate/languages","stargazers_url":"https://api.github.com/repos/kevin-buttercoin/slate/stargazers","contributors_url":"https://api.github.com/repos/kevin-buttercoin/slate/contributors","subscribers_url":"https://api.github.com/repos/kevin-buttercoin/slate/subscribers","subscription_url":"https://api.github.com/repos/kevin-buttercoin/slate/subscription","commits_url":"https://api.github.com/repos/kevin-buttercoin/slate/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevin-buttercoin/slate/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevin-buttercoin/slate/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevin-buttercoin/slate/issues/comments/{number}","contents_url":"https://api.github.com/repos/kevin-buttercoin/slate/contents/{+path}","compare_url":"https://api.github.com/repos/kevin-buttercoin/slate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevin-buttercoin/slate/merges","archive_url":"https://api.github.com/repos/kevin-buttercoin/slate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevin-buttercoin/slate/downloads","issues_url":"https://api.github.com/repos/kevin-buttercoin/slate/issues{/number}","pulls_url":"https://api.github.com/repos/kevin-buttercoin/slate/pulls{/number}","milestones_url":"https://api.github.com/repos/kevin-buttercoin/slate/milestones{/number}","notifications_url":"https://api.github.com/repos/kevin-buttercoin/slate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevin-buttercoin/slate/labels{/name}","releases_url":"https://api.github.com/repos/kevin-buttercoin/slate/releases{/id}","created_at":"2014-10-08T23:35:40Z","updated_at":"2014-10-08T23:38:52Z","pushed_at":"2014-10-09T15:46:48Z","git_url":"git://github.com/kevin-buttercoin/slate.git","ssh_url":"git@github.com:kevin-buttercoin/slate.git","clone_url":"https://github.com/kevin-buttercoin/slate.git","svn_url":"https://github.com/kevin-buttercoin/slate","homepage":"","size":500,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tripit:master","ref":"master","sha":"9c7ea33305743972d7e4397cb79ef67b59655fac","user":{"login":"tripit","id":421724,"avatar_url":"https://avatars.githubusercontent.com/u/421724?v=2","gravatar_id":"","url":"https://api.github.com/users/tripit","html_url":"https://github.com/tripit","followers_url":"https://api.github.com/users/tripit/followers","following_url":"https://api.github.com/users/tripit/following{/other_user}","gists_url":"https://api.github.com/users/tripit/gists{/gist_id}","starred_url":"https://api.github.com/users/tripit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tripit/subscriptions","organizations_url":"https://api.github.com/users/tripit/orgs","repos_url":"https://api.github.com/users/tripit/repos","events_url":"https://api.github.com/users/tripit/events{/privacy}","received_events_url":"https://api.github.com/users/tripit/received_events","type":"Organization","site_admin":false},"repo":{"id":12820537,"name":"slate","full_name":"tripit/slate","owner":{"login":"tripit","id":421724,"avatar_url":"https://avatars.githubusercontent.com/u/421724?v=2","gravatar_id":"","url":"https://api.github.com/users/tripit","html_url":"https://github.com/tripit","followers_url":"https://api.github.com/users/tripit/followers","following_url":"https://api.github.com/users/tripit/following{/other_user}","gists_url":"https://api.github.com/users/tripit/gists{/gist_id}","starred_url":"https://api.github.com/users/tripit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tripit/subscriptions","organizations_url":"https://api.github.com/users/tripit/orgs","repos_url":"https://api.github.com/users/tripit/repos","events_url":"https://api.github.com/users/tripit/events{/privacy}","received_events_url":"https://api.github.com/users/tripit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tripit/slate","description":"Beautiful static documentation for your API","fork":false,"url":"https://api.github.com/repos/tripit/slate","forks_url":"https://api.github.com/repos/tripit/slate/forks","keys_url":"https://api.github.com/repos/tripit/slate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tripit/slate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tripit/slate/teams","hooks_url":"https://api.github.com/repos/tripit/slate/hooks","issue_events_url":"https://api.github.com/repos/tripit/slate/issues/events{/number}","events_url":"https://api.github.com/repos/tripit/slate/events","assignees_url":"https://api.github.com/repos/tripit/slate/assignees{/user}","branches_url":"https://api.github.com/repos/tripit/slate/branches{/branch}","tags_url":"https://api.github.com/repos/tripit/slate/tags","blobs_url":"https://api.github.com/repos/tripit/slate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tripit/slate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tripit/slate/git/refs{/sha}","trees_url":"https://api.github.com/repos/tripit/slate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tripit/slate/statuses/{sha}","languages_url":"https://api.github.com/repos/tripit/slate/languages","stargazers_url":"https://api.github.com/repos/tripit/slate/stargazers","contributors_url":"https://api.github.com/repos/tripit/slate/contributors","subscribers_url":"https://api.github.com/repos/tripit/slate/subscribers","subscription_url":"https://api.github.com/repos/tripit/slate/subscription","commits_url":"https://api.github.com/repos/tripit/slate/commits{/sha}","git_commits_url":"https://api.github.com/repos/tripit/slate/git/commits{/sha}","comments_url":"https://api.github.com/repos/tripit/slate/comments{/number}","issue_comment_url":"https://api.github.com/repos/tripit/slate/issues/comments/{number}","contents_url":"https://api.github.com/repos/tripit/slate/contents/{+path}","compare_url":"https://api.github.com/repos/tripit/slate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tripit/slate/merges","archive_url":"https://api.github.com/repos/tripit/slate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tripit/slate/downloads","issues_url":"https://api.github.com/repos/tripit/slate/issues{/number}","pulls_url":"https://api.github.com/repos/tripit/slate/pulls{/number}","milestones_url":"https://api.github.com/repos/tripit/slate/milestones{/number}","notifications_url":"https://api.github.com/repos/tripit/slate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tripit/slate/labels{/name}","releases_url":"https://api.github.com/repos/tripit/slate/releases{/id}","created_at":"2013-09-13T22:15:24Z","updated_at":"2014-10-09T14:42:39Z","pushed_at":"2014-10-05T19:31:44Z","git_url":"git://github.com/tripit/slate.git","ssh_url":"git@github.com:tripit/slate.git","clone_url":"https://github.com/tripit/slate.git","svn_url":"https://github.com/tripit/slate","homepage":"","size":3685,"stargazers_count":1398,"watchers_count":1398,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":515,"mirror_url":null,"open_issues_count":19,"forks":515,"open_issues":19,"watchers":1398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tripit/slate/pulls/113"},"html":{"href":"https://github.com/tripit/slate/pull/113"},"issue":{"href":"https://api.github.com/repos/tripit/slate/issues/113"},"comments":{"href":"https://api.github.com/repos/tripit/slate/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/tripit/slate/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/tripit/slate/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tripit/slate/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/tripit/slate/statuses/b40b3b47ed69cd2f130958eb733ad7e9efa996a7"}}}}