GitHub PullRequestReviewCommentEvent at 2014-05-21 15:50:36
Repository: edx-platform
Actor: cahrens
Payload: {"comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/12904012","id":12904012,"diff_hunk":"@@ -0,0 +1,30 @@\n+\"\"\"\n+Mixin to support editing in Studio.","path":"common/lib/xmodule/xmodule/studio_editable.py","position":2,"original_position":2,"commit_id":"5eb1c4dd875935631953e0b972bc75816010582d","original_commit_id":"5eb1c4dd875935631953e0b972bc75816010582d","user":{"login":"cahrens","id":484484,"avatar_url":"https://avatars.githubusercontent.com/u/484484?","gravatar_id":"c61f992b89d30875e4626db835a07b77","url":"https://api.github.com/users/cahrens","html_url":"https://github.com/cahrens","followers_url":"https://api.github.com/users/cahrens/followers","following_url":"https://api.github.com/users/cahrens/following{/other_user}","gists_url":"https://api.github.com/users/cahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/cahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahrens/subscriptions","organizations_url":"https://api.github.com/users/cahrens/orgs","repos_url":"https://api.github.com/users/cahrens/repos","events_url":"https://api.github.com/users/cahrens/events{/privacy}","received_events_url":"https://api.github.com/users/cahrens/received_events","type":"User","site_admin":false},"body":"For reorderable children, we need to create the HTML for the ol/li structure. This is how drag and drop works. We could have done it just for verticals, but then every other xblock/xmodule that wants to enable reordering of children would have to copy the ol/li structure into its HTML. Instead, we created a mixin to make it easier for xmodule/xblocks to add Studio editing support.\r\n\r\nI envision other things going into this mixin to support general handling of saving settings changes for xblocks.","created_at":"2014-05-21T15:50:36Z","updated_at":"2014-05-21T15:50:36Z","html_url":"https://github.com/edx/edx-platform/pull/3579#discussion_r12904012","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/3579","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/12904012"},"html":{"href":"https://github.com/edx/edx-platform/pull/3579#discussion_r12904012"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/3579"}}}}