GitHub PullRequestReviewCommentEvent at 2014-10-22 19:38:10
Repository: SignalR-Client-Cpp
Actor: halter73
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls/comments/19238735","id":19238735,"diff_hunk":"@@ -0,0 +1,86 @@\n+// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.\r\n+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\r\n+\r\n+#include <cpprest/ws_client.h>\r\n+#include \"url_builder.h\"\r\n+\r\n+namespace signalr\r\n+{\r\n+    template<typename T = web::experimental::web_sockets::client::websocket_client> // testing\r\n+    class websocket_transport\r\n+    {\r\n+        //TODO: make non-copyable or implement move =operator (needed at all?)\r","path":"src/signalrclient/websocket_transport.h","position":12,"original_position":12,"commit_id":"a4a25a4d3a3496a0df5891410efea3e07c47c7de","original_commit_id":"a4a25a4d3a3496a0df5891410efea3e07c47c7de","user":{"login":"halter73","id":54385,"avatar_url":"https://avatars.githubusercontent.com/u/54385?v=2","gravatar_id":"","url":"https://api.github.com/users/halter73","html_url":"https://github.com/halter73","followers_url":"https://api.github.com/users/halter73/followers","following_url":"https://api.github.com/users/halter73/following{/other_user}","gists_url":"https://api.github.com/users/halter73/gists{/gist_id}","starred_url":"https://api.github.com/users/halter73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halter73/subscriptions","organizations_url":"https://api.github.com/users/halter73/orgs","repos_url":"https://api.github.com/users/halter73/repos","events_url":"https://api.github.com/users/halter73/events{/privacy}","received_events_url":"https://api.github.com/users/halter73/received_events","type":"User","site_admin":false},"body":"I don't see any reason to allow copying.","created_at":"2014-10-22T19:38:10Z","updated_at":"2014-10-22T19:38:10Z","html_url":"https://github.com/aspnet/SignalR-Client-Cpp/pull/12#discussion_r19238735","pull_request_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls/comments/19238735"},"html":{"href":"https://github.com/aspnet/SignalR-Client-Cpp/pull/12#discussion_r19238735"},"pull_request":{"href":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls/12","id":23124135,"html_url":"https://github.com/aspnet/SignalR-Client-Cpp/pull/12","diff_url":"https://github.com/aspnet/SignalR-Client-Cpp/pull/12.diff","patch_url":"https://github.com/aspnet/SignalR-Client-Cpp/pull/12.patch","issue_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/issues/12","number":12,"state":"open","locked":false,"title":"WCF (Websocket Communication Foundation) - a skeleton for websocket transport","user":{"login":"moozzyk","id":1438884,"avatar_url":"https://avatars.githubusercontent.com/u/1438884?v=2","gravatar_id":"","url":"https://api.github.com/users/moozzyk","html_url":"https://github.com/moozzyk","followers_url":"https://api.github.com/users/moozzyk/followers","following_url":"https://api.github.com/users/moozzyk/following{/other_user}","gists_url":"https://api.github.com/users/moozzyk/gists{/gist_id}","starred_url":"https://api.github.com/users/moozzyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moozzyk/subscriptions","organizations_url":"https://api.github.com/users/moozzyk/orgs","repos_url":"https://api.github.com/users/moozzyk/repos","events_url":"https://api.github.com/users/moozzyk/events{/privacy}","received_events_url":"https://api.github.com/users/moozzyk/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-21T22:48:46Z","updated_at":"2014-10-22T19:38:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"468106c94f718e790499fdc51478d62befb8aa2e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls/12/commits","review_comments_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls/12/comments","review_comment_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/issues/12/comments","statuses_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/statuses/a4a25a4d3a3496a0df5891410efea3e07c47c7de","head":{"label":"aspnet:websocket_transport","ref":"websocket_transport","sha":"a4a25a4d3a3496a0df5891410efea3e07c47c7de","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=2","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":24436973,"name":"SignalR-Client-Cpp","full_name":"aspnet/SignalR-Client-Cpp","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=2","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/SignalR-Client-Cpp","description":"","fork":false,"url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp","forks_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/forks","keys_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/teams","hooks_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/hooks","issue_events_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/events","assignees_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/tags","blobs_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/languages","stargazers_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/stargazers","contributors_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/contributors","subscribers_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/subscribers","subscription_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/subscription","commits_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/merges","archive_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/downloads","issues_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/releases{/id}","created_at":"2014-09-25T00:02:40Z","updated_at":"2014-10-20T10:44:09Z","pushed_at":"2014-10-21T22:47:21Z","git_url":"git://github.com/aspnet/SignalR-Client-Cpp.git","ssh_url":"git@github.com:aspnet/SignalR-Client-Cpp.git","clone_url":"https://github.com/aspnet/SignalR-Client-Cpp.git","svn_url":"https://github.com/aspnet/SignalR-Client-Cpp","homepage":null,"size":1367,"stargazers_count":4,"watchers_count":4,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"aspnet:connect_url","ref":"connect_url","sha":"7dc8ad49a5e013233157b1f174a0ef4cae0b9271","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=2","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":24436973,"name":"SignalR-Client-Cpp","full_name":"aspnet/SignalR-Client-Cpp","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=2","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/SignalR-Client-Cpp","description":"","fork":false,"url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp","forks_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/forks","keys_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/teams","hooks_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/hooks","issue_events_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/events","assignees_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/tags","blobs_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/languages","stargazers_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/stargazers","contributors_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/contributors","subscribers_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/subscribers","subscription_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/subscription","commits_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/merges","archive_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/downloads","issues_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/releases{/id}","created_at":"2014-09-25T00:02:40Z","updated_at":"2014-10-20T10:44:09Z","pushed_at":"2014-10-21T22:47:21Z","git_url":"git://github.com/aspnet/SignalR-Client-Cpp.git","ssh_url":"git@github.com:aspnet/SignalR-Client-Cpp.git","clone_url":"https://github.com/aspnet/SignalR-Client-Cpp.git","svn_url":"https://github.com/aspnet/SignalR-Client-Cpp","homepage":null,"size":1367,"stargazers_count":4,"watchers_count":4,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls/12"},"html":{"href":"https://github.com/aspnet/SignalR-Client-Cpp/pull/12"},"issue":{"href":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/issues/12"},"comments":{"href":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/SignalR-Client-Cpp/statuses/a4a25a4d3a3496a0df5891410efea3e07c47c7de"}}}}