GitHub PullRequestReviewCommentEvent at 2014-03-12 18:21:30
Repository: facter
Actor: adrienthebo
Payload: {"comment":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments/10532424","id":10532424,"diff_hunk":"@@ -32,13 +34,16 @@\n   setcode do\n     require 'facter/util/macosx'\n     result = \"physical\"\n-    output = Facter::Util::Macosx.profiler_data(\"SPDisplaysDataType\")\n+    # use SPHardwareDataType for VMware and VirtualBox, since it is the most reliable source.\n+    output = Facter::Util::Macosx.profiler_data(\"SPHardwareDataType\")\n     if output.is_a?(Hash)\n-      result = \"parallels\" if output[\"spdisplays_vendor-id\"] =~ /0x1ab8/\n-      result = \"parallels\" if output[\"spdisplays_vendor\"] =~ /[Pp]arallels/\n-      result = \"vmware\" if output[\"spdisplays_vendor-id\"] =~ /0x15ad/\n-      result = \"vmware\" if output[\"spdisplays_vendor\"] =~ /VM[wW]are/\n-      result = \"virtualbox\" if output[\"spdisplays_vendor-id\"] =~ /0x80ee/\n+      result = \"vmware\" if output[\"machine_model\"] =~ /VMware/","path":"lib/facter/virtual.rb","position":40,"original_position":40,"commit_id":"9b641dcfeedaf38b23e82595511fd52658b668da","original_commit_id":"9b641dcfeedaf38b23e82595511fd52658b668da","user":{"login":"adrienthebo","id":172194,"avatar_url":"https://gravatar.com/avatar/3bc6d4c30aba3b9e7d15a92d4b894d27?d=https%3A%2F%2Fidenticons.github.com%2Fe038842abd6d061ef27df1ccd03359bf.png&r=x","gravatar_id":"3bc6d4c30aba3b9e7d15a92d4b894d27","url":"https://api.github.com/users/adrienthebo","html_url":"https://github.com/adrienthebo","followers_url":"https://api.github.com/users/adrienthebo/followers","following_url":"https://api.github.com/users/adrienthebo/following{/other_user}","gists_url":"https://api.github.com/users/adrienthebo/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienthebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienthebo/subscriptions","organizations_url":"https://api.github.com/users/adrienthebo/orgs","repos_url":"https://api.github.com/users/adrienthebo/repos","events_url":"https://api.github.com/users/adrienthebo/events{/privacy}","received_events_url":"https://api.github.com/users/adrienthebo/received_events","type":"User","site_admin":false},"body":"The previous implementation of this had some limited case insensitivity, does that need to be preserved?","created_at":"2014-03-12T18:21:30Z","updated_at":"2014-03-12T18:21:30Z","html_url":"https://github.com/puppetlabs/facter/pull/608#discussion_r10532424","pull_request_url":"https://api.github.com/repos/puppetlabs/facter/pulls/608","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments/10532424"},"html":{"href":"https://github.com/puppetlabs/facter/pull/608#discussion_r10532424"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/608"}}}}