GitHub PullRequestReviewCommentEvent at 2014-07-20 03:35:24
Repository: JabbR
Actor: alfhenrik
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/JabbR/JabbR/pulls/comments/15147421","id":15147421,"diff_hunk":"@@ -41,7 +41,8 @@ public class HomeModule : JabbRModule\n                         Version = Constants.JabbRVersion,\n                         IsAdmin = Principal.HasClaim(JabbRClaimTypes.Admin),\n                         ClientLanguageResources = BuildClientResources(),\n-                        MaxMessageLength = settings.MaxMessageLength\n+                        MaxMessageLength = settings.MaxMessageLength,\n+                        AllowRoomCreation = settings.AllowRoomCreation","path":"JabbR/Nancy/HomeModule.cs","position":15,"original_position":15,"commit_id":"fa8104e9f0115296beeab3f259bc8ae3f3fc052a","original_commit_id":"fa8104e9f0115296beeab3f259bc8ae3f3fc052a","user":{"login":"alfhenrik","id":1035315,"avatar_url":"https://avatars.githubusercontent.com/u/1035315?","gravatar_id":"de0ee1937ada29a8c7be1db1505c690b","url":"https://api.github.com/users/alfhenrik","html_url":"https://github.com/alfhenrik","followers_url":"https://api.github.com/users/alfhenrik/followers","following_url":"https://api.github.com/users/alfhenrik/following{/other_user}","gists_url":"https://api.github.com/users/alfhenrik/gists{/gist_id}","starred_url":"https://api.github.com/users/alfhenrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfhenrik/subscriptions","organizations_url":"https://api.github.com/users/alfhenrik/orgs","repos_url":"https://api.github.com/users/alfhenrik/repos","events_url":"https://api.github.com/users/alfhenrik/events{/privacy}","received_events_url":"https://api.github.com/users/alfhenrik/received_events","type":"User","site_admin":false},"body":"Two options (I'm unsure which one would be better)\r\n```\r\nAllowRoomCreation = settings.AllowRoomCreation || Principal.HasClaim(JabbRClaimTypes.Admin)\r\n```\r\nor\r\n```\r\nviewModel.AllowRoomCreation = settings.AllowRoomCreation || viewModel.IsAdmin;\r\n```\r\n","created_at":"2014-07-20T03:35:24Z","updated_at":"2014-07-20T03:35:24Z","html_url":"https://github.com/JabbR/JabbR/pull/1165#discussion_r15147421","pull_request_url":"https://api.github.com/repos/JabbR/JabbR/pulls/1165","_links":{"self":{"href":"https://api.github.com/repos/JabbR/JabbR/pulls/comments/15147421"},"html":{"href":"https://github.com/JabbR/JabbR/pull/1165#discussion_r15147421"},"pull_request":{"href":"https://api.github.com/repos/JabbR/JabbR/pulls/1165"}}},"pull_request":{"url":"https://api.github.com/repos/JabbR/JabbR/pulls/1165","id":18619457,"html_url":"https://github.com/JabbR/JabbR/pull/1165","diff_url":"https://github.com/JabbR/JabbR/pull/1165.diff","patch_url":"https://github.com/JabbR/JabbR/pull/1165.patch","issue_url":"https://api.github.com/repos/JabbR/JabbR/issues/1165","number":1165,"state":"open","title":"Add a create room button to the UI","user":{"login":"alfhenrik","id":1035315,"avatar_url":"https://avatars.githubusercontent.com/u/1035315?","gravatar_id":"de0ee1937ada29a8c7be1db1505c690b","url":"https://api.github.com/users/alfhenrik","html_url":"https://github.com/alfhenrik","followers_url":"https://api.github.com/users/alfhenrik/followers","following_url":"https://api.github.com/users/alfhenrik/following{/other_user}","gists_url":"https://api.github.com/users/alfhenrik/gists{/gist_id}","starred_url":"https://api.github.com/users/alfhenrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfhenrik/subscriptions","organizations_url":"https://api.github.com/users/alfhenrik/orgs","repos_url":"https://api.github.com/users/alfhenrik/repos","events_url":"https://api.github.com/users/alfhenrik/events{/privacy}","received_events_url":"https://api.github.com/users/alfhenrik/received_events","type":"User","site_admin":false},"body":"The button will be visible on the lobby, and also when in a room (as you\r\nmight still want to create a new room while in another room)\r\n\r\nIn the lobby\r\n![image](https://cloud.githubusercontent.com/assets/1035315/3634290/f389efa0-0f20-11e4-8ae5-86f7ec52ccd7.png)\r\n\r\nIn a room\r\n![image](https://cloud.githubusercontent.com/assets/1035315/3634292/018511ca-0f21-11e4-81ce-a6948a37251b.png)\r\n\r\nCreating a new room\r\n![image](https://cloud.githubusercontent.com/assets/1035315/3634389/e2bb3ba8-0f29-11e4-9f00-c88fdd4fc03f.png)\r\n\r\nWithout entering a room name\r\n![image](https://cloud.githubusercontent.com/assets/1035315/3634390/fcefc44e-0f29-11e4-8d2b-87b108bfb3ec.png)\r\n\r\nEntering a room name\r\n![image](https://cloud.githubusercontent.com/assets/1035315/3634395/24200d76-0f2a-11e4-934e-b19c8050e48e.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1035315/3634397/2abbb662-0f2a-11e4-86b3-08cef041f22b.png)\r\n\r\nTrying to create a room that already exists\r\n![image](https://cloud.githubusercontent.com/assets/1035315/3634398/3fc6bc64-0f2a-11e4-80af-b326aed7f88a.png)\r\n\r\nFix #1154.","created_at":"2014-07-19T09:51:55Z","updated_at":"2014-07-20T03:35:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db0cdf770c8b069a21ea2f89008d84e8676ed0be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JabbR/JabbR/pulls/1165/commits","review_comments_url":"https://api.github.com/repos/JabbR/JabbR/pulls/1165/comments","review_comment_url":"https://api.github.com/repos/JabbR/JabbR/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JabbR/JabbR/issues/1165/comments","statuses_url":"https://api.github.com/repos/JabbR/JabbR/statuses/fa8104e9f0115296beeab3f259bc8ae3f3fc052a","head":{"label":"JabbR:create-room-button","ref":"create-room-button","sha":"fa8104e9f0115296beeab3f259bc8ae3f3fc052a","user":{"login":"JabbR","id":4121427,"avatar_url":"https://avatars.githubusercontent.com/u/4121427?","gravatar_id":null,"url":"https://api.github.com/users/JabbR","html_url":"https://github.com/JabbR","followers_url":"https://api.github.com/users/JabbR/followers","following_url":"https://api.github.com/users/JabbR/following{/other_user}","gists_url":"https://api.github.com/users/JabbR/gists{/gist_id}","starred_url":"https://api.github.com/users/JabbR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabbR/subscriptions","organizations_url":"https://api.github.com/users/JabbR/orgs","repos_url":"https://api.github.com/users/JabbR/repos","events_url":"https://api.github.com/users/JabbR/events{/privacy}","received_events_url":"https://api.github.com/users/JabbR/received_events","type":"Organization","site_admin":false},"repo":{"id":2292256,"name":"JabbR","full_name":"JabbR/JabbR","owner":{"login":"JabbR","id":4121427,"avatar_url":"https://avatars.githubusercontent.com/u/4121427?","gravatar_id":null,"url":"https://api.github.com/users/JabbR","html_url":"https://github.com/JabbR","followers_url":"https://api.github.com/users/JabbR/followers","following_url":"https://api.github.com/users/JabbR/following{/other_user}","gists_url":"https://api.github.com/users/JabbR/gists{/gist_id}","starred_url":"https://api.github.com/users/JabbR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabbR/subscriptions","organizations_url":"https://api.github.com/users/JabbR/orgs","repos_url":"https://api.github.com/users/JabbR/repos","events_url":"https://api.github.com/users/JabbR/events{/privacy}","received_events_url":"https://api.github.com/users/JabbR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JabbR/JabbR","description":"Collaborative chat done right","fork":false,"url":"https://api.github.com/repos/JabbR/JabbR","forks_url":"https://api.github.com/repos/JabbR/JabbR/forks","keys_url":"https://api.github.com/repos/JabbR/JabbR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JabbR/JabbR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JabbR/JabbR/teams","hooks_url":"https://api.github.com/repos/JabbR/JabbR/hooks","issue_events_url":"https://api.github.com/repos/JabbR/JabbR/issues/events{/number}","events_url":"https://api.github.com/repos/JabbR/JabbR/events","assignees_url":"https://api.github.com/repos/JabbR/JabbR/assignees{/user}","branches_url":"https://api.github.com/repos/JabbR/JabbR/branches{/branch}","tags_url":"https://api.github.com/repos/JabbR/JabbR/tags","blobs_url":"https://api.github.com/repos/JabbR/JabbR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JabbR/JabbR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JabbR/JabbR/git/refs{/sha}","trees_url":"https://api.github.com/repos/JabbR/JabbR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JabbR/JabbR/statuses/{sha}","languages_url":"https://api.github.com/repos/JabbR/JabbR/languages","stargazers_url":"https://api.github.com/repos/JabbR/JabbR/stargazers","contributors_url":"https://api.github.com/repos/JabbR/JabbR/contributors","subscribers_url":"https://api.github.com/repos/JabbR/JabbR/subscribers","subscription_url":"https://api.github.com/repos/JabbR/JabbR/subscription","commits_url":"https://api.github.com/repos/JabbR/JabbR/commits{/sha}","git_commits_url":"https://api.github.com/repos/JabbR/JabbR/git/commits{/sha}","comments_url":"https://api.github.com/repos/JabbR/JabbR/comments{/number}","issue_comment_url":"https://api.github.com/repos/JabbR/JabbR/issues/comments/{number}","contents_url":"https://api.github.com/repos/JabbR/JabbR/contents/{+path}","compare_url":"https://api.github.com/repos/JabbR/JabbR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JabbR/JabbR/merges","archive_url":"https://api.github.com/repos/JabbR/JabbR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JabbR/JabbR/downloads","issues_url":"https://api.github.com/repos/JabbR/JabbR/issues{/number}","pulls_url":"https://api.github.com/repos/JabbR/JabbR/pulls{/number}","milestones_url":"https://api.github.com/repos/JabbR/JabbR/milestones{/number}","notifications_url":"https://api.github.com/repos/JabbR/JabbR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JabbR/JabbR/labels{/name}","releases_url":"https://api.github.com/repos/JabbR/JabbR/releases{/id}","created_at":"2011-08-30T01:35:41Z","updated_at":"2014-07-19T21:25:56Z","pushed_at":"2014-07-20T02:35:47Z","git_url":"git://github.com/JabbR/JabbR.git","ssh_url":"git@github.com:JabbR/JabbR.git","clone_url":"https://github.com/JabbR/JabbR.git","svn_url":"https://github.com/JabbR/JabbR","homepage":"http://about.jabbr.net","size":49127,"stargazers_count":982,"watchers_count":982,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":453,"mirror_url":null,"open_issues_count":134,"forks":453,"open_issues":134,"watchers":982,"default_branch":"dev"}},"base":{"label":"JabbR:dev","ref":"dev","sha":"1f2f583553095f9e93b69ef1a86f0e1da783093d","user":{"login":"JabbR","id":4121427,"avatar_url":"https://avatars.githubusercontent.com/u/4121427?","gravatar_id":null,"url":"https://api.github.com/users/JabbR","html_url":"https://github.com/JabbR","followers_url":"https://api.github.com/users/JabbR/followers","following_url":"https://api.github.com/users/JabbR/following{/other_user}","gists_url":"https://api.github.com/users/JabbR/gists{/gist_id}","starred_url":"https://api.github.com/users/JabbR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabbR/subscriptions","organizations_url":"https://api.github.com/users/JabbR/orgs","repos_url":"https://api.github.com/users/JabbR/repos","events_url":"https://api.github.com/users/JabbR/events{/privacy}","received_events_url":"https://api.github.com/users/JabbR/received_events","type":"Organization","site_admin":false},"repo":{"id":2292256,"name":"JabbR","full_name":"JabbR/JabbR","owner":{"login":"JabbR","id":4121427,"avatar_url":"https://avatars.githubusercontent.com/u/4121427?","gravatar_id":null,"url":"https://api.github.com/users/JabbR","html_url":"https://github.com/JabbR","followers_url":"https://api.github.com/users/JabbR/followers","following_url":"https://api.github.com/users/JabbR/following{/other_user}","gists_url":"https://api.github.com/users/JabbR/gists{/gist_id}","starred_url":"https://api.github.com/users/JabbR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabbR/subscriptions","organizations_url":"https://api.github.com/users/JabbR/orgs","repos_url":"https://api.github.com/users/JabbR/repos","events_url":"https://api.github.com/users/JabbR/events{/privacy}","received_events_url":"https://api.github.com/users/JabbR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JabbR/JabbR","description":"Collaborative chat done right","fork":false,"url":"https://api.github.com/repos/JabbR/JabbR","forks_url":"https://api.github.com/repos/JabbR/JabbR/forks","keys_url":"https://api.github.com/repos/JabbR/JabbR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JabbR/JabbR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JabbR/JabbR/teams","hooks_url":"https://api.github.com/repos/JabbR/JabbR/hooks","issue_events_url":"https://api.github.com/repos/JabbR/JabbR/issues/events{/number}","events_url":"https://api.github.com/repos/JabbR/JabbR/events","assignees_url":"https://api.github.com/repos/JabbR/JabbR/assignees{/user}","branches_url":"https://api.github.com/repos/JabbR/JabbR/branches{/branch}","tags_url":"https://api.github.com/repos/JabbR/JabbR/tags","blobs_url":"https://api.github.com/repos/JabbR/JabbR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JabbR/JabbR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JabbR/JabbR/git/refs{/sha}","trees_url":"https://api.github.com/repos/JabbR/JabbR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JabbR/JabbR/statuses/{sha}","languages_url":"https://api.github.com/repos/JabbR/JabbR/languages","stargazers_url":"https://api.github.com/repos/JabbR/JabbR/stargazers","contributors_url":"https://api.github.com/repos/JabbR/JabbR/contributors","subscribers_url":"https://api.github.com/repos/JabbR/JabbR/subscribers","subscription_url":"https://api.github.com/repos/JabbR/JabbR/subscription","commits_url":"https://api.github.com/repos/JabbR/JabbR/commits{/sha}","git_commits_url":"https://api.github.com/repos/JabbR/JabbR/git/commits{/sha}","comments_url":"https://api.github.com/repos/JabbR/JabbR/comments{/number}","issue_comment_url":"https://api.github.com/repos/JabbR/JabbR/issues/comments/{number}","contents_url":"https://api.github.com/repos/JabbR/JabbR/contents/{+path}","compare_url":"https://api.github.com/repos/JabbR/JabbR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JabbR/JabbR/merges","archive_url":"https://api.github.com/repos/JabbR/JabbR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JabbR/JabbR/downloads","issues_url":"https://api.github.com/repos/JabbR/JabbR/issues{/number}","pulls_url":"https://api.github.com/repos/JabbR/JabbR/pulls{/number}","milestones_url":"https://api.github.com/repos/JabbR/JabbR/milestones{/number}","notifications_url":"https://api.github.com/repos/JabbR/JabbR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JabbR/JabbR/labels{/name}","releases_url":"https://api.github.com/repos/JabbR/JabbR/releases{/id}","created_at":"2011-08-30T01:35:41Z","updated_at":"2014-07-19T21:25:56Z","pushed_at":"2014-07-20T02:35:47Z","git_url":"git://github.com/JabbR/JabbR.git","ssh_url":"git@github.com:JabbR/JabbR.git","clone_url":"https://github.com/JabbR/JabbR.git","svn_url":"https://github.com/JabbR/JabbR","homepage":"http://about.jabbr.net","size":49127,"stargazers_count":982,"watchers_count":982,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":453,"mirror_url":null,"open_issues_count":134,"forks":453,"open_issues":134,"watchers":982,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/JabbR/JabbR/pulls/1165"},"html":{"href":"https://github.com/JabbR/JabbR/pull/1165"},"issue":{"href":"https://api.github.com/repos/JabbR/JabbR/issues/1165"},"comments":{"href":"https://api.github.com/repos/JabbR/JabbR/issues/1165/comments"},"review_comments":{"href":"https://api.github.com/repos/JabbR/JabbR/pulls/1165/comments"},"review_comment":{"href":"https://api.github.com/repos/JabbR/JabbR/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JabbR/JabbR/pulls/1165/commits"},"statuses":{"href":"https://api.github.com/repos/JabbR/JabbR/statuses/fa8104e9f0115296beeab3f259bc8ae3f3fc052a"}}}}