GitHub PullRequestReviewCommentEvent at 2014-04-26 20:48:36
Repository: phobos
Actor: acehreli
Payload: {"comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/12026265","id":12026265,"diff_hunk":"@@ -746,142 +743,146 @@ seed (the range must be non-empty).\n \n See also: $(LREF sum) is similar to $(D reduce!((a, b) => a + b)) that offers\n precise summing of floating point numbers.\n- */\n++/\n template reduce(fun...) if (fun.length >= 1)\n {\n-    import std.exception : enforce;\n+    alias binfuns = staticMap!(binaryFun, fun);\n+    static if (fun.length > 1)\n+        import std.typecons : tuple, isTuple;\n+\n+    /+\n+    No-seed version. The first element of $(D r) is used as the seed's value.\n \n-    auto reduce(Args...)(Args args)\n-    if (Args.length > 0 && Args.length <= 2 && isIterable!(Args[$ - 1]))\n+    For each function $(D f) in the predicates $(D fun), the corresponding","path":"std/algorithm.d","position":30,"original_position":30,"commit_id":"4b59acadb36d1095a614a9cd30496216948ecdb0","original_commit_id":"4b59acadb36d1095a614a9cd30496216948ecdb0","user":{"login":"acehreli","id":122712,"avatar_url":"https://avatars.githubusercontent.com/u/122712?","gravatar_id":"caaed597fc8993f78e1664a2ed9077d9","url":"https://api.github.com/users/acehreli","html_url":"https://github.com/acehreli","followers_url":"https://api.github.com/users/acehreli/followers","following_url":"https://api.github.com/users/acehreli/following{/other_user}","gists_url":"https://api.github.com/users/acehreli/gists{/gist_id}","starred_url":"https://api.github.com/users/acehreli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acehreli/subscriptions","organizations_url":"https://api.github.com/users/acehreli/orgs","repos_url":"https://api.github.com/users/acehreli/repos","events_url":"https://api.github.com/users/acehreli/events{/privacy}","received_events_url":"https://api.github.com/users/acehreli/received_events","type":"User","site_admin":false},"body":"Thanks. Yes, function sounds much better to me non-native-English ears. :) (Note: I think there are more instances of \"predicate\" in this diff.)","created_at":"2014-04-26T20:48:36Z","updated_at":"2014-04-26T20:48:36Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/2060#discussion_r12026265","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2060","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/12026265"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2060#discussion_r12026265"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2060"}}}}