GitHub PullRequestReviewCommentEvent at 2014-02-09 13:17:30
Repository: cgmath-rs
Actor: bjz
Payload: {"comment":{"url":"https://api.github.com/repos/bjz/cgmath-rs/pulls/comments/9568715","id":9568715,"diff_hunk":"@@ -15,7 +15,59 @@\n \n //! Axis-aligned bounding boxes\n \n-use point::{Point2, Point3};\n+use point::{Point, Point2, Point3};\n+use vector::{Vector, Vec2, Vec3};\n+use array::build;\n+use std::fmt;\n+use std::num::{zero, one};\n+use std::iter::Iterator;\n+\n+pub trait Aabb\n+<\n+    S: Primitive,\n+    V: Vector<S, Slice>,\n+    P: Point<S, V, Slice>,\n+    Slice\n+> {\n+    fn new(p1: &P, p2: &P) -> Self;","path":"src/cgmath/aabb.rs","position":19,"original_position":19,"commit_id":"a391d4450bccf6d9bd3b65f2b0bf7ff8014c694e","original_commit_id":"a391d4450bccf6d9bd3b65f2b0bf7ff8014c694e","user":{"login":"bjz","id":695077,"avatar_url":"https://gravatar.com/avatar/e52a48f76fc911d40711f788d74773a0?d=https%3A%2F%2Fidenticons.github.com%2F6c1c1c803cfd93c6a4e2c4a1c3322fe8.png&r=x","gravatar_id":"e52a48f76fc911d40711f788d74773a0","url":"https://api.github.com/users/bjz","html_url":"https://github.com/bjz","followers_url":"https://api.github.com/users/bjz/followers","following_url":"https://api.github.com/users/bjz/following{/other_user}","gists_url":"https://api.github.com/users/bjz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjz/subscriptions","organizations_url":"https://api.github.com/users/bjz/orgs","repos_url":"https://api.github.com/users/bjz/repos","events_url":"https://api.github.com/users/bjz/events{/privacy}","received_events_url":"https://api.github.com/users/bjz/received_events","type":"User","site_admin":false},"body":"Why are these taken by ref?","created_at":"2014-02-09T13:17:30Z","updated_at":"2014-02-09T13:17:30Z","html_url":"https://github.com/bjz/cgmath-rs/pull/40#discussion_r9568715","pull_request_url":"https://api.github.com/repos/bjz/cgmath-rs/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/bjz/cgmath-rs/pulls/comments/9568715"},"html":{"href":"https://github.com/bjz/cgmath-rs/pull/40#discussion_r9568715"},"pull_request":{"href":"https://api.github.com/repos/bjz/cgmath-rs/pulls/40"}}}}