GitHub PullRequestEvent at 2014-01-23 17:01:36
Repository: twilio-node
Actor: porsager
Payload: {"action":"opened","number":32,"pull_request":{"url":"https://api.github.com/repos/twilio/twilio-node/pulls/32","id":11809599,"html_url":"https://github.com/twilio/twilio-node/pull/32","diff_url":"https://github.com/twilio/twilio-node/pull/32.diff","patch_url":"https://github.com/twilio/twilio-node/pull/32.patch","issue_url":"https://github.com/twilio/twilio-node/pull/32","number":32,"state":"open","title":"Make nodeClientResponse unenumerable to allow for stringification of the data object.","user":{"login":"porsager","id":1288405,"avatar_url":"https://gravatar.com/avatar/d00c5776650868745b00859d2a50924c?d=https%3A%2F%2Fidenticons.github.com%2Fccdcb9d9c69733d39df0949590d04391.png&r=x","gravatar_id":"d00c5776650868745b00859d2a50924c","url":"https://api.github.com/users/porsager","html_url":"https://github.com/porsager","followers_url":"https://api.github.com/users/porsager/followers","following_url":"https://api.github.com/users/porsager/following{/other_user}","gists_url":"https://api.github.com/users/porsager/gists{/gist_id}","starred_url":"https://api.github.com/users/porsager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porsager/subscriptions","organizations_url":"https://api.github.com/users/porsager/orgs","repos_url":"https://api.github.com/users/porsager/repos","events_url":"https://api.github.com/users/porsager/events{/privacy}","received_events_url":"https://api.github.com/users/porsager/received_events","type":"User","site_admin":false},"body":"Having the entire response on the data object could lead to unexpected consequences.\r\nWhen making requests for a single object in a resource the data can't be stringified directly since stringifying the nodeClientResponse is too big an operation. (and what would the purpose be?)\r\nIf the property is defined with enumerable set to false, then it won't be included when stringified.\r\nAn example is using a get for a single call:\r\n```\r\nclient.calls('CA123...').get(function(err, data){\r\n  var json = JSON.stringify(data); //this would be a very heavy operation.\r\n});\r\n```","created_at":"2014-01-23T17:01:36Z","updated_at":"2014-01-23T17:01:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://github.com/twilio/twilio-node/pull/32/commits","review_comments_url":"https://github.com/twilio/twilio-node/pull/32/comments","review_comment_url":"/repos/twilio/twilio-node/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twilio/twilio-node/issues/32/comments","statuses_url":"https://api.github.com/repos/twilio/twilio-node/statuses/4ae8bff1b6526bea702eaba135d1074985ea8a08","head":{"label":"porsager:patch-1","ref":"patch-1","sha":"4ae8bff1b6526bea702eaba135d1074985ea8a08","user":{"login":"porsager","id":1288405,"avatar_url":"https://gravatar.com/avatar/d00c5776650868745b00859d2a50924c?d=https%3A%2F%2Fidenticons.github.com%2Fccdcb9d9c69733d39df0949590d04391.png&r=x","gravatar_id":"d00c5776650868745b00859d2a50924c","url":"https://api.github.com/users/porsager","html_url":"https://github.com/porsager","followers_url":"https://api.github.com/users/porsager/followers","following_url":"https://api.github.com/users/porsager/following{/other_user}","gists_url":"https://api.github.com/users/porsager/gists{/gist_id}","starred_url":"https://api.github.com/users/porsager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porsager/subscriptions","organizations_url":"https://api.github.com/users/porsager/orgs","repos_url":"https://api.github.com/users/porsager/repos","events_url":"https://api.github.com/users/porsager/events{/privacy}","received_events_url":"https://api.github.com/users/porsager/received_events","type":"User","site_admin":false},"repo":{"id":16178414,"name":"twilio-node","full_name":"porsager/twilio-node","owner":{"login":"porsager","id":1288405,"avatar_url":"https://gravatar.com/avatar/d00c5776650868745b00859d2a50924c?d=https%3A%2F%2Fidenticons.github.com%2Fccdcb9d9c69733d39df0949590d04391.png&r=x","gravatar_id":"d00c5776650868745b00859d2a50924c","url":"https://api.github.com/users/porsager","html_url":"https://github.com/porsager","followers_url":"https://api.github.com/users/porsager/followers","following_url":"https://api.github.com/users/porsager/following{/other_user}","gists_url":"https://api.github.com/users/porsager/gists{/gist_id}","starred_url":"https://api.github.com/users/porsager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porsager/subscriptions","organizations_url":"https://api.github.com/users/porsager/orgs","repos_url":"https://api.github.com/users/porsager/repos","events_url":"https://api.github.com/users/porsager/events{/privacy}","received_events_url":"https://api.github.com/users/porsager/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/porsager/twilio-node","description":"Node.js helper library","fork":true,"url":"https://api.github.com/repos/porsager/twilio-node","forks_url":"https://api.github.com/repos/porsager/twilio-node/forks","keys_url":"https://api.github.com/repos/porsager/twilio-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/porsager/twilio-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/porsager/twilio-node/teams","hooks_url":"https://api.github.com/repos/porsager/twilio-node/hooks","issue_events_url":"https://api.github.com/repos/porsager/twilio-node/issues/events{/number}","events_url":"https://api.github.com/repos/porsager/twilio-node/events","assignees_url":"https://api.github.com/repos/porsager/twilio-node/assignees{/user}","branches_url":"https://api.github.com/repos/porsager/twilio-node/branches{/branch}","tags_url":"https://api.github.com/repos/porsager/twilio-node/tags","blobs_url":"https://api.github.com/repos/porsager/twilio-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/porsager/twilio-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/porsager/twilio-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/porsager/twilio-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/porsager/twilio-node/statuses/{sha}","languages_url":"https://api.github.com/repos/porsager/twilio-node/languages","stargazers_url":"https://api.github.com/repos/porsager/twilio-node/stargazers","contributors_url":"https://api.github.com/repos/porsager/twilio-node/contributors","subscribers_url":"https://api.github.com/repos/porsager/twilio-node/subscribers","subscription_url":"https://api.github.com/repos/porsager/twilio-node/subscription","commits_url":"https://api.github.com/repos/porsager/twilio-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/porsager/twilio-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/porsager/twilio-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/porsager/twilio-node/issues/comments/{number}","contents_url":"https://api.github.com/repos/porsager/twilio-node/contents/{+path}","compare_url":"https://api.github.com/repos/porsager/twilio-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/porsager/twilio-node/merges","archive_url":"https://api.github.com/repos/porsager/twilio-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/porsager/twilio-node/downloads","issues_url":"https://api.github.com/repos/porsager/twilio-node/issues{/number}","pulls_url":"https://api.github.com/repos/porsager/twilio-node/pulls{/number}","milestones_url":"https://api.github.com/repos/porsager/twilio-node/milestones{/number}","notifications_url":"https://api.github.com/repos/porsager/twilio-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/porsager/twilio-node/labels{/name}","releases_url":"https://api.github.com/repos/porsager/twilio-node/releases{/id}","created_at":"2014-01-23T16:43:05Z","updated_at":"2014-01-23T17:01:36Z","pushed_at":"2014-01-23T16:55:10Z","git_url":"git://github.com/porsager/twilio-node.git","ssh_url":"git@github.com:porsager/twilio-node.git","clone_url":"https://github.com/porsager/twilio-node.git","svn_url":"https://github.com/porsager/twilio-node","homepage":"http://twilio.github.io/twilio-node/","size":7122,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"twilio:master","ref":"master","sha":"30d201dc3b21d09c9f1c2f41966fcf6a3515564d","user":{"login":"twilio","id":109142,"avatar_url":"https://gravatar.com/avatar/3a74d32af962bf0784230eabd46a5a32?d=https%3A%2F%2Fidenticons.github.com%2Fb47b3f62cb92dfb3ea3350727017df79.png&r=x","gravatar_id":"3a74d32af962bf0784230eabd46a5a32","url":"https://api.github.com/users/twilio","html_url":"https://github.com/twilio","followers_url":"https://api.github.com/users/twilio/followers","following_url":"https://api.github.com/users/twilio/following{/other_user}","gists_url":"https://api.github.com/users/twilio/gists{/gist_id}","starred_url":"https://api.github.com/users/twilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilio/subscriptions","organizations_url":"https://api.github.com/users/twilio/orgs","repos_url":"https://api.github.com/users/twilio/repos","events_url":"https://api.github.com/users/twilio/events{/privacy}","received_events_url":"https://api.github.com/users/twilio/received_events","type":"Organization","site_admin":false},"repo":{"id":8281084,"name":"twilio-node","full_name":"twilio/twilio-node","owner":{"login":"twilio","id":109142,"avatar_url":"https://gravatar.com/avatar/3a74d32af962bf0784230eabd46a5a32?d=https%3A%2F%2Fidenticons.github.com%2Fb47b3f62cb92dfb3ea3350727017df79.png&r=x","gravatar_id":"3a74d32af962bf0784230eabd46a5a32","url":"https://api.github.com/users/twilio","html_url":"https://github.com/twilio","followers_url":"https://api.github.com/users/twilio/followers","following_url":"https://api.github.com/users/twilio/following{/other_user}","gists_url":"https://api.github.com/users/twilio/gists{/gist_id}","starred_url":"https://api.github.com/users/twilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilio/subscriptions","organizations_url":"https://api.github.com/users/twilio/orgs","repos_url":"https://api.github.com/users/twilio/repos","events_url":"https://api.github.com/users/twilio/events{/privacy}","received_events_url":"https://api.github.com/users/twilio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twilio/twilio-node","description":"Node.js helper library","fork":false,"url":"https://api.github.com/repos/twilio/twilio-node","forks_url":"https://api.github.com/repos/twilio/twilio-node/forks","keys_url":"https://api.github.com/repos/twilio/twilio-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twilio/twilio-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twilio/twilio-node/teams","hooks_url":"https://api.github.com/repos/twilio/twilio-node/hooks","issue_events_url":"https://api.github.com/repos/twilio/twilio-node/issues/events{/number}","events_url":"https://api.github.com/repos/twilio/twilio-node/events","assignees_url":"https://api.github.com/repos/twilio/twilio-node/assignees{/user}","branches_url":"https://api.github.com/repos/twilio/twilio-node/branches{/branch}","tags_url":"https://api.github.com/repos/twilio/twilio-node/tags","blobs_url":"https://api.github.com/repos/twilio/twilio-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twilio/twilio-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twilio/twilio-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/twilio/twilio-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twilio/twilio-node/statuses/{sha}","languages_url":"https://api.github.com/repos/twilio/twilio-node/languages","stargazers_url":"https://api.github.com/repos/twilio/twilio-node/stargazers","contributors_url":"https://api.github.com/repos/twilio/twilio-node/contributors","subscribers_url":"https://api.github.com/repos/twilio/twilio-node/subscribers","subscription_url":"https://api.github.com/repos/twilio/twilio-node/subscription","commits_url":"https://api.github.com/repos/twilio/twilio-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/twilio/twilio-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/twilio/twilio-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/twilio/twilio-node/issues/comments/{number}","contents_url":"https://api.github.com/repos/twilio/twilio-node/contents/{+path}","compare_url":"https://api.github.com/repos/twilio/twilio-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twilio/twilio-node/merges","archive_url":"https://api.github.com/repos/twilio/twilio-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twilio/twilio-node/downloads","issues_url":"https://api.github.com/repos/twilio/twilio-node/issues{/number}","pulls_url":"https://api.github.com/repos/twilio/twilio-node/pulls{/number}","milestones_url":"https://api.github.com/repos/twilio/twilio-node/milestones{/number}","notifications_url":"https://api.github.com/repos/twilio/twilio-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twilio/twilio-node/labels{/name}","releases_url":"https://api.github.com/repos/twilio/twilio-node/releases{/id}","created_at":"2013-02-19T01:38:34Z","updated_at":"2014-01-17T03:52:11Z","pushed_at":"2013-12-27T19:39:49Z","git_url":"git://github.com/twilio/twilio-node.git","ssh_url":"git@github.com:twilio/twilio-node.git","clone_url":"https://github.com/twilio/twilio-node.git","svn_url":"https://github.com/twilio/twilio-node","homepage":"http://twilio.github.io/twilio-node/","size":7303,"stargazers_count":82,"watchers_count":82,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":22,"mirror_url":null,"open_issues_count":7,"forks":22,"open_issues":7,"watchers":82,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twilio/twilio-node/pulls/32"},"html":{"href":"https://github.com/twilio/twilio-node/pull/32"},"issue":{"href":"https://api.github.com/repos/twilio/twilio-node/issues/32"},"comments":{"href":"https://api.github.com/repos/twilio/twilio-node/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/twilio/twilio-node/pulls/32/comments"},"statuses":{"href":"https://api.github.com/repos/twilio/twilio-node/statuses/4ae8bff1b6526bea702eaba135d1074985ea8a08"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}