GitHub PullRequestEvent at 2014-08-13 08:32:00
Repository: sane
Actor: bcardarella
Payload: {"action":"opened","number":24,"pull_request":{"url":"https://api.github.com/repos/amasad/sane/pulls/24","id":19710839,"html_url":"https://github.com/amasad/sane/pull/24","diff_url":"https://github.com/amasad/sane/pull/24.diff","patch_url":"https://github.com/amasad/sane/pull/24.patch","issue_url":"https://api.github.com/repos/amasad/sane/issues/24","number":24,"state":"open","title":"Include root directory in event callbacks","user":{"login":"bcardarella","id":18524,"avatar_url":"https://avatars.githubusercontent.com/u/18524?v=2","gravatar_id":"ed5f3e2d77dcf44a67efa72e09e9f28f","url":"https://api.github.com/users/bcardarella","html_url":"https://github.com/bcardarella","followers_url":"https://api.github.com/users/bcardarella/followers","following_url":"https://api.github.com/users/bcardarella/following{/other_user}","gists_url":"https://api.github.com/users/bcardarella/gists{/gist_id}","starred_url":"https://api.github.com/users/bcardarella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcardarella/subscriptions","organizations_url":"https://api.github.com/users/bcardarella/orgs","repos_url":"https://api.github.com/users/bcardarella/repos","events_url":"https://api.github.com/users/bcardarella/events{/privacy}","received_events_url":"https://api.github.com/users/bcardarella/received_events","type":"User","site_admin":false},"body":"If you have multiple watchers running the relative file path alone is\r\nnot enough to decide if an action should be taken or not. Including the\r\nroot path of the watcher provides more insight.\r\n\r\nI have opted to add the root path as a 2nd argument to the event\r\ncallback so as to (hopefully) make this change backwards compatible.\r\n\r\nember-cli is using multiple watchers for many of the Broccoli trees. I have a use-case where I would like to filter out certain files from the watcher callbacks but require more information than just the relative filepath","created_at":"2014-08-13T08:31:59Z","updated_at":"2014-08-13T08:31:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amasad/sane/pulls/24/commits","review_comments_url":"https://api.github.com/repos/amasad/sane/pulls/24/comments","review_comment_url":"https://api.github.com/repos/amasad/sane/pulls/comments/{number}","comments_url":"https://api.github.com/repos/amasad/sane/issues/24/comments","statuses_url":"https://api.github.com/repos/amasad/sane/statuses/40d1ae771dc15422576b54537b98e0551db5785b","head":{"label":"bcardarella:bc-include-root-dir-on-events","ref":"bc-include-root-dir-on-events","sha":"40d1ae771dc15422576b54537b98e0551db5785b","user":{"login":"bcardarella","id":18524,"avatar_url":"https://avatars.githubusercontent.com/u/18524?v=2","gravatar_id":"ed5f3e2d77dcf44a67efa72e09e9f28f","url":"https://api.github.com/users/bcardarella","html_url":"https://github.com/bcardarella","followers_url":"https://api.github.com/users/bcardarella/followers","following_url":"https://api.github.com/users/bcardarella/following{/other_user}","gists_url":"https://api.github.com/users/bcardarella/gists{/gist_id}","starred_url":"https://api.github.com/users/bcardarella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcardarella/subscriptions","organizations_url":"https://api.github.com/users/bcardarella/orgs","repos_url":"https://api.github.com/users/bcardarella/repos","events_url":"https://api.github.com/users/bcardarella/events{/privacy}","received_events_url":"https://api.github.com/users/bcardarella/received_events","type":"User","site_admin":false},"repo":{"id":22907001,"name":"sane","full_name":"bcardarella/sane","owner":{"login":"bcardarella","id":18524,"avatar_url":"https://avatars.githubusercontent.com/u/18524?v=2","gravatar_id":"ed5f3e2d77dcf44a67efa72e09e9f28f","url":"https://api.github.com/users/bcardarella","html_url":"https://github.com/bcardarella","followers_url":"https://api.github.com/users/bcardarella/followers","following_url":"https://api.github.com/users/bcardarella/following{/other_user}","gists_url":"https://api.github.com/users/bcardarella/gists{/gist_id}","starred_url":"https://api.github.com/users/bcardarella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcardarella/subscriptions","organizations_url":"https://api.github.com/users/bcardarella/orgs","repos_url":"https://api.github.com/users/bcardarella/repos","events_url":"https://api.github.com/users/bcardarella/events{/privacy}","received_events_url":"https://api.github.com/users/bcardarella/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcardarella/sane","description":"sane aims to be fast, small, and reliable filesystem watcher. No bells and whistles, just change events.","fork":true,"url":"https://api.github.com/repos/bcardarella/sane","forks_url":"https://api.github.com/repos/bcardarella/sane/forks","keys_url":"https://api.github.com/repos/bcardarella/sane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcardarella/sane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcardarella/sane/teams","hooks_url":"https://api.github.com/repos/bcardarella/sane/hooks","issue_events_url":"https://api.github.com/repos/bcardarella/sane/issues/events{/number}","events_url":"https://api.github.com/repos/bcardarella/sane/events","assignees_url":"https://api.github.com/repos/bcardarella/sane/assignees{/user}","branches_url":"https://api.github.com/repos/bcardarella/sane/branches{/branch}","tags_url":"https://api.github.com/repos/bcardarella/sane/tags","blobs_url":"https://api.github.com/repos/bcardarella/sane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcardarella/sane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcardarella/sane/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcardarella/sane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcardarella/sane/statuses/{sha}","languages_url":"https://api.github.com/repos/bcardarella/sane/languages","stargazers_url":"https://api.github.com/repos/bcardarella/sane/stargazers","contributors_url":"https://api.github.com/repos/bcardarella/sane/contributors","subscribers_url":"https://api.github.com/repos/bcardarella/sane/subscribers","subscription_url":"https://api.github.com/repos/bcardarella/sane/subscription","commits_url":"https://api.github.com/repos/bcardarella/sane/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcardarella/sane/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcardarella/sane/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcardarella/sane/issues/comments/{number}","contents_url":"https://api.github.com/repos/bcardarella/sane/contents/{+path}","compare_url":"https://api.github.com/repos/bcardarella/sane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcardarella/sane/merges","archive_url":"https://api.github.com/repos/bcardarella/sane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcardarella/sane/downloads","issues_url":"https://api.github.com/repos/bcardarella/sane/issues{/number}","pulls_url":"https://api.github.com/repos/bcardarella/sane/pulls{/number}","milestones_url":"https://api.github.com/repos/bcardarella/sane/milestones{/number}","notifications_url":"https://api.github.com/repos/bcardarella/sane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcardarella/sane/labels{/name}","releases_url":"https://api.github.com/repos/bcardarella/sane/releases{/id}","created_at":"2014-08-13T07:38:15Z","updated_at":"2014-07-30T21:52:13Z","pushed_at":"2014-08-13T08:30:53Z","git_url":"git://github.com/bcardarella/sane.git","ssh_url":"git@github.com:bcardarella/sane.git","clone_url":"https://github.com/bcardarella/sane.git","svn_url":"https://github.com/bcardarella/sane","homepage":null,"size":601,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amasad:master","ref":"master","sha":"acd15e0f0a44d670343453a70c5de383a1e7c4c5","user":{"login":"amasad","id":587518,"avatar_url":"https://avatars.githubusercontent.com/u/587518?v=2","gravatar_id":"03637ef1a5121222c8db0ed48c34e124","url":"https://api.github.com/users/amasad","html_url":"https://github.com/amasad","followers_url":"https://api.github.com/users/amasad/followers","following_url":"https://api.github.com/users/amasad/following{/other_user}","gists_url":"https://api.github.com/users/amasad/gists{/gist_id}","starred_url":"https://api.github.com/users/amasad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amasad/subscriptions","organizations_url":"https://api.github.com/users/amasad/orgs","repos_url":"https://api.github.com/users/amasad/repos","events_url":"https://api.github.com/users/amasad/events{/privacy}","received_events_url":"https://api.github.com/users/amasad/received_events","type":"User","site_admin":false},"repo":{"id":17180970,"name":"sane","full_name":"amasad/sane","owner":{"login":"amasad","id":587518,"avatar_url":"https://avatars.githubusercontent.com/u/587518?v=2","gravatar_id":"03637ef1a5121222c8db0ed48c34e124","url":"https://api.github.com/users/amasad","html_url":"https://github.com/amasad","followers_url":"https://api.github.com/users/amasad/followers","following_url":"https://api.github.com/users/amasad/following{/other_user}","gists_url":"https://api.github.com/users/amasad/gists{/gist_id}","starred_url":"https://api.github.com/users/amasad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amasad/subscriptions","organizations_url":"https://api.github.com/users/amasad/orgs","repos_url":"https://api.github.com/users/amasad/repos","events_url":"https://api.github.com/users/amasad/events{/privacy}","received_events_url":"https://api.github.com/users/amasad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amasad/sane","description":"sane aims to be fast, small, and reliable filesystem watcher. No bells and whistles, just change events.","fork":false,"url":"https://api.github.com/repos/amasad/sane","forks_url":"https://api.github.com/repos/amasad/sane/forks","keys_url":"https://api.github.com/repos/amasad/sane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amasad/sane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amasad/sane/teams","hooks_url":"https://api.github.com/repos/amasad/sane/hooks","issue_events_url":"https://api.github.com/repos/amasad/sane/issues/events{/number}","events_url":"https://api.github.com/repos/amasad/sane/events","assignees_url":"https://api.github.com/repos/amasad/sane/assignees{/user}","branches_url":"https://api.github.com/repos/amasad/sane/branches{/branch}","tags_url":"https://api.github.com/repos/amasad/sane/tags","blobs_url":"https://api.github.com/repos/amasad/sane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amasad/sane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amasad/sane/git/refs{/sha}","trees_url":"https://api.github.com/repos/amasad/sane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amasad/sane/statuses/{sha}","languages_url":"https://api.github.com/repos/amasad/sane/languages","stargazers_url":"https://api.github.com/repos/amasad/sane/stargazers","contributors_url":"https://api.github.com/repos/amasad/sane/contributors","subscribers_url":"https://api.github.com/repos/amasad/sane/subscribers","subscription_url":"https://api.github.com/repos/amasad/sane/subscription","commits_url":"https://api.github.com/repos/amasad/sane/commits{/sha}","git_commits_url":"https://api.github.com/repos/amasad/sane/git/commits{/sha}","comments_url":"https://api.github.com/repos/amasad/sane/comments{/number}","issue_comment_url":"https://api.github.com/repos/amasad/sane/issues/comments/{number}","contents_url":"https://api.github.com/repos/amasad/sane/contents/{+path}","compare_url":"https://api.github.com/repos/amasad/sane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amasad/sane/merges","archive_url":"https://api.github.com/repos/amasad/sane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amasad/sane/downloads","issues_url":"https://api.github.com/repos/amasad/sane/issues{/number}","pulls_url":"https://api.github.com/repos/amasad/sane/pulls{/number}","milestones_url":"https://api.github.com/repos/amasad/sane/milestones{/number}","notifications_url":"https://api.github.com/repos/amasad/sane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amasad/sane/labels{/name}","releases_url":"https://api.github.com/repos/amasad/sane/releases{/id}","created_at":"2014-02-25T17:07:47Z","updated_at":"2014-07-30T21:52:13Z","pushed_at":"2014-07-20T18:51:20Z","git_url":"git://github.com/amasad/sane.git","ssh_url":"git@github.com:amasad/sane.git","clone_url":"https://github.com/amasad/sane.git","svn_url":"https://github.com/amasad/sane","homepage":null,"size":601,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9,"mirror_url":null,"open_issues_count":6,"forks":9,"open_issues":6,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amasad/sane/pulls/24"},"html":{"href":"https://github.com/amasad/sane/pull/24"},"issue":{"href":"https://api.github.com/repos/amasad/sane/issues/24"},"comments":{"href":"https://api.github.com/repos/amasad/sane/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/amasad/sane/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/amasad/sane/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/amasad/sane/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/amasad/sane/statuses/40d1ae771dc15422576b54537b98e0551db5785b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":33,"deletions":21,"changed_files":3}}