GitHub PullRequestEvent at 2014-06-18 22:34:53
Repository: framework
Actor: Shadowfiend
Payload: {"action":"closed","number":1568,"pull_request":{"url":"https://api.github.com/repos/lift/framework/pulls/1568","id":16354065,"html_url":"https://github.com/lift/framework/pull/1568","diff_url":"https://github.com/lift/framework/pull/1568.diff","patch_url":"https://github.com/lift/framework/pull/1568.patch","issue_url":"https://api.github.com/repos/lift/framework/issues/1568","number":1568,"state":"closed","title":"Bounded Binding: Remove old bind strategy","user":{"login":"Shadowfiend","id":8245,"avatar_url":"https://avatars.githubusercontent.com/u/8245?","gravatar_id":"36b4b730bc6d058fd0737fc44119ed6f","url":"https://api.github.com/users/Shadowfiend","html_url":"https://github.com/Shadowfiend","followers_url":"https://api.github.com/users/Shadowfiend/followers","following_url":"https://api.github.com/users/Shadowfiend/following{/other_user}","gists_url":"https://api.github.com/users/Shadowfiend/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowfiend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowfiend/subscriptions","organizations_url":"https://api.github.com/users/Shadowfiend/orgs","repos_url":"https://api.github.com/users/Shadowfiend/repos","events_url":"https://api.github.com/users/Shadowfiend/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowfiend/received_events","type":"User","site_admin":false},"body":"#1548 reopened with respect to `lift_30`. This is now ready for review.\r\n\r\nThe PR blows away `bind` and most things that came with it. It preserves a few functions\r\nthat were in `BindHelpers` that were related to more general HTML manipulation, which\r\nnow live in an `HtmlHelpers` trait instead. It also rearranges the `ToCssBindPromoter`\r\nimplicits so that they are implicit classes and in a single centralized place (a\r\n`CssBindImplicits` trait). These are mixed into `HtmlHelpers` and through there into\r\n`Helpers`, so importing `Helpers._` will continue to import the appropriate implicit\r\nconversions.\r\n\r\nThe second thing this does is rewrite few points where we were still leaning on\r\nthe old binding strategy, particularly `PaginatorSnippet`, the `Menu` snippet, mapper\r\nview support stuff, `LiftScreen`, and lift-proto's `Crudify` and `ProtoUser`. The\r\nsnippets themselves may not be optimal now; however, I made the rewriting function\r\nvery similarly to how it functioned before (using CSS classes instead of the element\r\nnames that the binding style was using), leaving decisions on whether the snippets\r\nshould be further reworked for another time.\r\n\r\nDone/pending work:\r\n - [x] Remove `BindHelpers` and `BindHelpersSpec`\r\n - [x] Move still-used generic stuff to `HtmlHelpers`\r\n - [x] Preserve `BindHelpersSpec`s for `HtmlHelpers` stuff in `HtmlHelpersSpec`\r\n - [x] Port snippets still using `bind` to CSS selector transforms\r\n - [x] Put implicits for `ToCssBindPromoter` in a common place\r\n - [x] Ensure untested stuff in `HtmlHelpers` is tested\r\n - [x] Make `LiftScreen` compile without `bind`\r\n - [x] Make `lift-proto` compile without `bind`\r\n - [x] Make `lift-mapper` compile without `bind`\r\n - [x] Make sure all specs are passing","created_at":"2014-05-27T04:30:57Z","updated_at":"2014-06-18T22:34:53Z","closed_at":"2014-06-18T22:34:53Z","merged_at":null,"merge_commit_sha":"e7a056a968bde457a912039aeb653eecbaa5b6c3","assignee":null,"milestone":{"url":"https://api.github.com/repos/lift/framework/milestones/53","labels_url":"https://api.github.com/repos/lift/framework/milestones/53/labels","id":388592,"number":53,"title":"3.0-M2","description":"","creator":{"login":"fmpwizard","id":62802,"avatar_url":"https://avatars.githubusercontent.com/u/62802?","gravatar_id":"ffd17116dd89d84c2783d1b2a63d8370","url":"https://api.github.com/users/fmpwizard","html_url":"https://github.com/fmpwizard","followers_url":"https://api.github.com/users/fmpwizard/followers","following_url":"https://api.github.com/users/fmpwizard/following{/other_user}","gists_url":"https://api.github.com/users/fmpwizard/gists{/gist_id}","starred_url":"https://api.github.com/users/fmpwizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmpwizard/subscriptions","organizations_url":"https://api.github.com/users/fmpwizard/orgs","repos_url":"https://api.github.com/users/fmpwizard/repos","events_url":"https://api.github.com/users/fmpwizard/events{/privacy}","received_events_url":"https://api.github.com/users/fmpwizard/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":12,"state":"open","created_at":"2013-07-28T04:58:09Z","updated_at":"2014-06-18T22:34:53Z","due_on":null},"commits_url":"https://api.github.com/repos/lift/framework/pulls/1568/commits","review_comments_url":"https://api.github.com/repos/lift/framework/pulls/1568/comments","review_comment_url":"https://api.github.com/repos/lift/framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lift/framework/issues/1568/comments","statuses_url":"https://api.github.com/repos/lift/framework/statuses/b13c08c223d594c8c7cbabd74e099ea9484a7c4e","head":{"label":"lift:bounded-binding","ref":"bounded-binding","sha":"b13c08c223d594c8c7cbabd74e099ea9484a7c4e","user":{"login":"lift","id":317975,"avatar_url":"https://avatars.githubusercontent.com/u/317975?","gravatar_id":"9ed0b3a677a32bc9220d89e63b3054aa","url":"https://api.github.com/users/lift","html_url":"https://github.com/lift","followers_url":"https://api.github.com/users/lift/followers","following_url":"https://api.github.com/users/lift/following{/other_user}","gists_url":"https://api.github.com/users/lift/gists{/gist_id}","starred_url":"https://api.github.com/users/lift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lift/subscriptions","organizations_url":"https://api.github.com/users/lift/orgs","repos_url":"https://api.github.com/users/lift/repos","events_url":"https://api.github.com/users/lift/events{/privacy}","received_events_url":"https://api.github.com/users/lift/received_events","type":"Organization","site_admin":false},"repo":{"id":1295197,"name":"framework","full_name":"lift/framework","owner":{"login":"lift","id":317975,"avatar_url":"https://avatars.githubusercontent.com/u/317975?","gravatar_id":"9ed0b3a677a32bc9220d89e63b3054aa","url":"https://api.github.com/users/lift","html_url":"https://github.com/lift","followers_url":"https://api.github.com/users/lift/followers","following_url":"https://api.github.com/users/lift/following{/other_user}","gists_url":"https://api.github.com/users/lift/gists{/gist_id}","starred_url":"https://api.github.com/users/lift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lift/subscriptions","organizations_url":"https://api.github.com/users/lift/orgs","repos_url":"https://api.github.com/users/lift/repos","events_url":"https://api.github.com/users/lift/events{/privacy}","received_events_url":"https://api.github.com/users/lift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lift/framework","description":"Lift Framework","fork":false,"url":"https://api.github.com/repos/lift/framework","forks_url":"https://api.github.com/repos/lift/framework/forks","keys_url":"https://api.github.com/repos/lift/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lift/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lift/framework/teams","hooks_url":"https://api.github.com/repos/lift/framework/hooks","issue_events_url":"https://api.github.com/repos/lift/framework/issues/events{/number}","events_url":"https://api.github.com/repos/lift/framework/events","assignees_url":"https://api.github.com/repos/lift/framework/assignees{/user}","branches_url":"https://api.github.com/repos/lift/framework/branches{/branch}","tags_url":"https://api.github.com/repos/lift/framework/tags","blobs_url":"https://api.github.com/repos/lift/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lift/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lift/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/lift/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lift/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/lift/framework/languages","stargazers_url":"https://api.github.com/repos/lift/framework/stargazers","contributors_url":"https://api.github.com/repos/lift/framework/contributors","subscribers_url":"https://api.github.com/repos/lift/framework/subscribers","subscription_url":"https://api.github.com/repos/lift/framework/subscription","commits_url":"https://api.github.com/repos/lift/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/lift/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/lift/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/lift/framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/lift/framework/contents/{+path}","compare_url":"https://api.github.com/repos/lift/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lift/framework/merges","archive_url":"https://api.github.com/repos/lift/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lift/framework/downloads","issues_url":"https://api.github.com/repos/lift/framework/issues{/number}","pulls_url":"https://api.github.com/repos/lift/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/lift/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/lift/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lift/framework/labels{/name}","releases_url":"https://api.github.com/repos/lift/framework/releases{/id}","created_at":"2011-01-26T13:25:28Z","updated_at":"2014-06-18T22:34:53Z","pushed_at":"2014-06-18T22:34:53Z","git_url":"git://github.com/lift/framework.git","ssh_url":"git@github.com:lift/framework.git","clone_url":"https://github.com/lift/framework.git","svn_url":"https://github.com/lift/framework","homepage":"http://liftweb.net","size":30504,"stargazers_count":792,"watchers_count":792,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":197,"mirror_url":null,"open_issues_count":125,"forks":197,"open_issues":125,"watchers":792,"default_branch":"master"}},"base":{"label":"lift:lift_30","ref":"lift_30","sha":"8a53ed83877fca59ca1af3b6b73d9ef12ee936ac","user":{"login":"lift","id":317975,"avatar_url":"https://avatars.githubusercontent.com/u/317975?","gravatar_id":"9ed0b3a677a32bc9220d89e63b3054aa","url":"https://api.github.com/users/lift","html_url":"https://github.com/lift","followers_url":"https://api.github.com/users/lift/followers","following_url":"https://api.github.com/users/lift/following{/other_user}","gists_url":"https://api.github.com/users/lift/gists{/gist_id}","starred_url":"https://api.github.com/users/lift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lift/subscriptions","organizations_url":"https://api.github.com/users/lift/orgs","repos_url":"https://api.github.com/users/lift/repos","events_url":"https://api.github.com/users/lift/events{/privacy}","received_events_url":"https://api.github.com/users/lift/received_events","type":"Organization","site_admin":false},"repo":{"id":1295197,"name":"framework","full_name":"lift/framework","owner":{"login":"lift","id":317975,"avatar_url":"https://avatars.githubusercontent.com/u/317975?","gravatar_id":"9ed0b3a677a32bc9220d89e63b3054aa","url":"https://api.github.com/users/lift","html_url":"https://github.com/lift","followers_url":"https://api.github.com/users/lift/followers","following_url":"https://api.github.com/users/lift/following{/other_user}","gists_url":"https://api.github.com/users/lift/gists{/gist_id}","starred_url":"https://api.github.com/users/lift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lift/subscriptions","organizations_url":"https://api.github.com/users/lift/orgs","repos_url":"https://api.github.com/users/lift/repos","events_url":"https://api.github.com/users/lift/events{/privacy}","received_events_url":"https://api.github.com/users/lift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lift/framework","description":"Lift Framework","fork":false,"url":"https://api.github.com/repos/lift/framework","forks_url":"https://api.github.com/repos/lift/framework/forks","keys_url":"https://api.github.com/repos/lift/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lift/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lift/framework/teams","hooks_url":"https://api.github.com/repos/lift/framework/hooks","issue_events_url":"https://api.github.com/repos/lift/framework/issues/events{/number}","events_url":"https://api.github.com/repos/lift/framework/events","assignees_url":"https://api.github.com/repos/lift/framework/assignees{/user}","branches_url":"https://api.github.com/repos/lift/framework/branches{/branch}","tags_url":"https://api.github.com/repos/lift/framework/tags","blobs_url":"https://api.github.com/repos/lift/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lift/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lift/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/lift/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lift/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/lift/framework/languages","stargazers_url":"https://api.github.com/repos/lift/framework/stargazers","contributors_url":"https://api.github.com/repos/lift/framework/contributors","subscribers_url":"https://api.github.com/repos/lift/framework/subscribers","subscription_url":"https://api.github.com/repos/lift/framework/subscription","commits_url":"https://api.github.com/repos/lift/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/lift/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/lift/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/lift/framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/lift/framework/contents/{+path}","compare_url":"https://api.github.com/repos/lift/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lift/framework/merges","archive_url":"https://api.github.com/repos/lift/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lift/framework/downloads","issues_url":"https://api.github.com/repos/lift/framework/issues{/number}","pulls_url":"https://api.github.com/repos/lift/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/lift/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/lift/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lift/framework/labels{/name}","releases_url":"https://api.github.com/repos/lift/framework/releases{/id}","created_at":"2011-01-26T13:25:28Z","updated_at":"2014-06-18T22:34:53Z","pushed_at":"2014-06-18T22:34:53Z","git_url":"git://github.com/lift/framework.git","ssh_url":"git@github.com:lift/framework.git","clone_url":"https://github.com/lift/framework.git","svn_url":"https://github.com/lift/framework","homepage":"http://liftweb.net","size":30504,"stargazers_count":792,"watchers_count":792,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":197,"mirror_url":null,"open_issues_count":125,"forks":197,"open_issues":125,"watchers":792,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lift/framework/pulls/1568"},"html":{"href":"https://github.com/lift/framework/pull/1568"},"issue":{"href":"https://api.github.com/repos/lift/framework/issues/1568"},"comments":{"href":"https://api.github.com/repos/lift/framework/issues/1568/comments"},"review_comments":{"href":"https://api.github.com/repos/lift/framework/pulls/1568/comments"},"review_comment":{"href":"https://api.github.com/repos/lift/framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lift/framework/pulls/1568/commits"},"statuses":{"href":"https://api.github.com/repos/lift/framework/statuses/b13c08c223d594c8c7cbabd74e099ea9484a7c4e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":8,"review_comments":0,"commits":32,"additions":1494,"deletions":3019,"changed_files":25}}