GitHub PullRequestReviewCommentEvent at 2014-09-03 09:39:28
Repository: akka
Actor: drewhk
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/17039358","id":17039358,"diff_hunk":"@@ -64,24 +56,45 @@ class NewDslHttpServerPipeline(settings: ServerSettings,\n             val flow = entityParts.withOutput(publisher)\n             HttpRequest(method, effectiveUri, headers, createEntity(publisher.publisher), protocol)\n         }\n-        .withOutput(requestPublisher)\n \n-    val responseSubscriber = SubscriberIn[HttpResponse]()\n-    val responseFlowBeforeMerge: ClosedFlow[HttpResponse, HttpResponse] =\n+    val responseFlowBeforeMerge: OpenFlow[HttpResponse, HttpResponse] =\n       From[HttpResponse]\n-        .withInput(responseSubscriber)\n-        .withOutput(merge.in2)\n \n-    val responseFlowAfterMerge: ClosedFlow[Any, ByteString] =\n+    val responseFlowAfterMerge: OpenInputFlow[Any, ByteString] =\n       From[Any]\n-        .withInput(merge.out)\n         .transform(applyApplicationBypass)\n         .transform(responseRendererFactory.newRenderer)\n         .flatten(FlattenStrategy.concatOpenOutputFlow)\n         .transform(errorLogger(log, \"Outgoing response stream error\"))\n         .withOutput(SubscriberOut(tcpConn.outputStream))\n \n-    Http.IncomingConnection(tcpConn.remoteAddress, requestPublisher.publisher, responseSubscriber.subscriber)\n+    val responseSubscriber = SubscriberInput[HttpResponse]()\n+    val requestPublisher = PublisherOutput[HttpRequest]()\n+\n+    // building using EdgeBuilder\n+    val materialized: MaterializedGraph = {\n+      val g = EdgeBuilder()\n+      val broadcast = g.broadcast[(RequestOutput, OpenOutputFlow[RequestOutput, RequestOutput])]\n+      val merge = g.merge[MessageStart, HttpResponse, Any]\n+\n+      g(requestFlowBeforeBroadcast) ~> broadcast ~> requestFlowAfterBroadcast ~> requestPublisher\n+      g(responseSubscriber) ~> responseFlowBeforeMerge ~> merge ~> responseFlowAfterMerge\n+      g(broadcast) ~> applicationBypassFlow ~~> merge","path":"akka-http-core/src/main/scala/akka/http/server/NewDslHttpServerPipeline.scala","position":65,"original_position":65,"commit_id":"bf198869987fe0d3abeb9e369a32de50d4808fdc","original_commit_id":"bf198869987fe0d3abeb9e369a32de50d4808fdc","user":{"login":"drewhk","id":932285,"avatar_url":"https://avatars.githubusercontent.com/u/932285?v=2","gravatar_id":"e00d3476c1ca077dd6ba6897e724655d","url":"https://api.github.com/users/drewhk","html_url":"https://github.com/drewhk","followers_url":"https://api.github.com/users/drewhk/followers","following_url":"https://api.github.com/users/drewhk/following{/other_user}","gists_url":"https://api.github.com/users/drewhk/gists{/gist_id}","starred_url":"https://api.github.com/users/drewhk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewhk/subscriptions","organizations_url":"https://api.github.com/users/drewhk/orgs","repos_url":"https://api.github.com/users/drewhk/repos","events_url":"https://api.github.com/users/drewhk/events{/privacy}","received_events_url":"https://api.github.com/users/drewhk/received_events","type":"User","site_admin":false},"body":"The ```g(...)``` call at the beginning will be replaced by implicit conversion if I see correctly?","created_at":"2014-09-03T09:39:28Z","updated_at":"2014-09-03T09:39:28Z","html_url":"https://github.com/akka/akka/pull/15769#discussion_r17039358","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/15769","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/17039358"},"html":{"href":"https://github.com/akka/akka/pull/15769#discussion_r17039358"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/15769"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/15769","id":20453159,"html_url":"https://github.com/akka/akka/pull/15769","diff_url":"https://github.com/akka/akka/pull/15769.diff","patch_url":"https://github.com/akka/akka/pull/15769.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/15769","number":15769,"state":"open","locked":false,"title":"Adds a shallow shim of the Graph DSL","user":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=2","gravatar_id":"505fd54698c7a09b24577a37ff77518a","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"body":"* has two different graph builders\r\n* adds tests of what compiles and what not\r\n* writes HttpPipeline with both graph builders\r\n\r\nFixes #15767","created_at":"2014-08-28T17:15:27Z","updated_at":"2014-09-03T09:39:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89ccc0076e9608125d54471ea4cf46f6a6c2c2d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/15769/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/15769/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments/{number}","comments_url":"https://api.github.com/repos/akka/akka/issues/15769/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/bf198869987fe0d3abeb9e369a32de50d4808fdc","head":{"label":"2m:wip-graph-dsl","ref":"wip-graph-dsl","sha":"bf198869987fe0d3abeb9e369a32de50d4808fdc","user":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=2","gravatar_id":"505fd54698c7a09b24577a37ff77518a","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"repo":{"id":18794399,"name":"akka","full_name":"2m/akka","owner":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=2","gravatar_id":"505fd54698c7a09b24577a37ff77518a","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/2m/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/2m/akka","forks_url":"https://api.github.com/repos/2m/akka/forks","keys_url":"https://api.github.com/repos/2m/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2m/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2m/akka/teams","hooks_url":"https://api.github.com/repos/2m/akka/hooks","issue_events_url":"https://api.github.com/repos/2m/akka/issues/events{/number}","events_url":"https://api.github.com/repos/2m/akka/events","assignees_url":"https://api.github.com/repos/2m/akka/assignees{/user}","branches_url":"https://api.github.com/repos/2m/akka/branches{/branch}","tags_url":"https://api.github.com/repos/2m/akka/tags","blobs_url":"https://api.github.com/repos/2m/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2m/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2m/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/2m/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2m/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/2m/akka/languages","stargazers_url":"https://api.github.com/repos/2m/akka/stargazers","contributors_url":"https://api.github.com/repos/2m/akka/contributors","subscribers_url":"https://api.github.com/repos/2m/akka/subscribers","subscription_url":"https://api.github.com/repos/2m/akka/subscription","commits_url":"https://api.github.com/repos/2m/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/2m/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/2m/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/2m/akka/issues/comments/{number}","contents_url":"https://api.github.com/repos/2m/akka/contents/{+path}","compare_url":"https://api.github.com/repos/2m/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2m/akka/merges","archive_url":"https://api.github.com/repos/2m/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2m/akka/downloads","issues_url":"https://api.github.com/repos/2m/akka/issues{/number}","pulls_url":"https://api.github.com/repos/2m/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/2m/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/2m/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2m/akka/labels{/name}","releases_url":"https://api.github.com/repos/2m/akka/releases{/id}","created_at":"2014-04-15T09:23:35Z","updated_at":"2014-08-18T08:15:42Z","pushed_at":"2014-08-28T17:13:46Z","git_url":"git://github.com/2m/akka.git","ssh_url":"git@github.com:2m/akka.git","clone_url":"https://github.com/2m/akka.git","svn_url":"https://github.com/2m/akka","homepage":"http://akka.io","size":154431,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:release-2.3-dev","ref":"release-2.3-dev","sha":"298c6caa5fceaa40da26d57dd26633e42484abf4","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=2","gravatar_id":"0ff72320fb1bc5db35ba4fae61614eb0","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=2","gravatar_id":"0ff72320fb1bc5db35ba4fae61614eb0","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments/{number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2014-09-03T07:19:11Z","pushed_at":"2014-09-03T06:56:33Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":227280,"stargazers_count":2935,"watchers_count":2935,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":792,"mirror_url":null,"open_issues_count":395,"forks":792,"open_issues":395,"watchers":2935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/15769"},"html":{"href":"https://github.com/akka/akka/pull/15769"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/15769"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/15769/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/15769/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/15769/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/bf198869987fe0d3abeb9e369a32de50d4808fdc"}}}}