GitHub PullRequestReviewCommentEvent at 2014-03-18 20:53:09
Repository: ka-lite
Actor: ruimalheiro
Payload: {"comment":{"url":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments/10725086","id":10725086,"diff_hunk":"@@ -66,15 +58,34 @@ function handleFailedAPI(resp, error_text, error_id) {\n             show_message(\"error\", error_text + \": \" + gettext(\"You are not authorized to complete the request.  Please <a href='/securesync/login/' target='_blank'>login</a> as an administrator, then retry.\"), error_id);\n             break;\n         default:\n-            //communicate_api_failure(resp)\n             messages = $.parseJSON(resp.responseText);\n-            if (messages && !(\"error\" in messages)) {\n-                // this should be an assert--should never happen\n-                show_message(\"error\", error_text + \": \" + gettext(\"Uninterpretable message received.\"), error_id);\n-            } else {\n-                show_message(\"error\", error_text + \": \" + messages[\"error\"], error_id);\n+\n+            if(!messages){\n+                messages = \"info\";\n+            }\n+\n+            switch(typeof messages) {","path":"kalite/static/js/distributed-server.js","position":31,"original_position":31,"commit_id":"3f03ab42b4dac01fca0f00d978a1891b3e6166f0","original_commit_id":"da11d145ea6aa64813f5c14730f68dfaccf7c3ed","user":{"login":"ruimalheiro","id":1102381,"avatar_url":"https://avatars.githubusercontent.com/u/1102381?","gravatar_id":"a63f358c80cd33bff8a2b7a0e01db28c","url":"https://api.github.com/users/ruimalheiro","html_url":"https://github.com/ruimalheiro","followers_url":"https://api.github.com/users/ruimalheiro/followers","following_url":"https://api.github.com/users/ruimalheiro/following{/other_user}","gists_url":"https://api.github.com/users/ruimalheiro/gists{/gist_id}","starred_url":"https://api.github.com/users/ruimalheiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruimalheiro/subscriptions","organizations_url":"https://api.github.com/users/ruimalheiro/orgs","repos_url":"https://api.github.com/users/ruimalheiro/repos","events_url":"https://api.github.com/users/ruimalheiro/events{/privacy}","received_events_url":"https://api.github.com/users/ruimalheiro/received_events","type":"User","site_admin":false},"body":"@bcipolli I understand - Let me try to fix it then. :+1: ","created_at":"2014-03-18T20:53:09Z","updated_at":"2014-03-18T20:53:09Z","html_url":"https://github.com/learningequality/ka-lite/pull/1708#discussion_r10725086","pull_request_url":"https://api.github.com/repos/learningequality/ka-lite/pulls/1708","_links":{"self":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments/10725086"},"html":{"href":"https://github.com/learningequality/ka-lite/pull/1708#discussion_r10725086"},"pull_request":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/1708"}}}}