GitHub PullRequestReviewCommentEvent at 2014-04-01 02:24:24
Repository: eslint
Actor: btmills
Payload: {"comment":{"url":"https://api.github.com/repos/eslint/eslint/pulls/comments/11145556","id":11145556,"diff_hunk":"@@ -129,9 +129,7 @@ function Config(options) {\n             require(path.resolve(__dirname, \"..\", \"conf\", \"eslint.json\"));\n     this.baseConfig.format = options.format;\n     this.useEslintrc = (options.eslintrc !== false);\n-    this.env = options.env ? options.env.split(\",\").filter(function (s) {\n-        return s.length > 0;\n-    }) : null;\n+    this.env = options.env;","path":"lib/config.js","position":7,"original_position":7,"commit_id":"7dcbfca8352eaeb108c5e1a514738b096e970c3b","original_commit_id":"7dcbfca8352eaeb108c5e1a514738b096e970c3b","user":{"login":"btmills","id":1709537,"avatar_url":"https://avatars.githubusercontent.com/u/1709537?","gravatar_id":"f6e9da7497bf755aa9c85432633548c6","url":"https://api.github.com/users/btmills","html_url":"https://github.com/btmills","followers_url":"https://api.github.com/users/btmills/followers","following_url":"https://api.github.com/users/btmills/following{/other_user}","gists_url":"https://api.github.com/users/btmills/gists{/gist_id}","starred_url":"https://api.github.com/users/btmills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btmills/subscriptions","organizations_url":"https://api.github.com/users/btmills/orgs","repos_url":"https://api.github.com/users/btmills/repos","events_url":"https://api.github.com/users/btmills/events{/privacy}","received_events_url":"https://api.github.com/users/btmills/received_events","type":"User","site_admin":false},"body":"@gkz My bad! I incorrectly applied the change to `lib/options.js`. Works fine now. :+1: ","created_at":"2014-04-01T02:24:24Z","updated_at":"2014-04-01T02:24:24Z","html_url":"https://github.com/eslint/eslint/pull/747#discussion_r11145556","pull_request_url":"https://api.github.com/repos/eslint/eslint/pulls/747","_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments/11145556"},"html":{"href":"https://github.com/eslint/eslint/pull/747#discussion_r11145556"},"pull_request":{"href":"https://api.github.com/repos/eslint/eslint/pulls/747"}}}}