GitHub PullRequestReviewCommentEvent at 2014-04-14 13:51:58
Repository: ecma402
Actor: clmath
Payload: {"comment":{"url":"https://api.github.com/repos/ibm-js/ecma402/pulls/comments/11584662","id":11584662,"diff_hunk":"@@ -1,1725 +1,1253 @@\n-define(\n-\t[ \"dojo/request\", \"./calendars\", \"./Record\", \"./List\" ],\n-\tfunction(request, calendars, Record, List) {\n-\t\t//\n-\t\t// JavaScript implementation of Internationalization APIs as defined in ECMA standard 402 version 1.0\n-\t\t//\n-\t\t\n-\t\tvar unicodeLocaleExtensions = /-u(-[a-z0-9]{2,8})+/g;\n-\t\tvar dateTimeProperties = [ \"weekday\", \"era\", \"year\", \"month\", \"day\", \"hour\", \"minute\", \"second\", \"timeZoneName\" ];\n-\t\tvar availableLocalesList = CanonicalizeLocaleList(getCLDRJson(\"config\", \"availableLocales\").availableLocales);\n-\t\tvar aliases = getCLDRJson(\"supplemental\", \"aliases\").supplemental.metadata.alias;\n-\t\tvar localeAliases = getCLDRJson(\"supplemental\", \"localeAliases\").supplemental.metadata.alias;\n-\t\tvar parentLocales = getCLDRJson(\"supplemental\", \"parentLocales\").supplemental.parentLocales;\n-\t\tvar currencyData = getCLDRJson(\"supplemental\", \"currencyData\").supplemental.currencyData.fractions;\n-\t\tvar timeData = getCLDRJson(\"supplemental\", \"timeData\").supplemental.timeData;\n-\t\tvar likelySubtags = getCLDRJson(\"supplemental\", \"likelySubtags\").supplemental.likelySubtags;\n-\t\tvar numberingSystems = getCLDRJson(\"supplemental\", \"numberingSystems\").supplemental.numberingSystems;\n-\t\tvar availableNumberingSystems = [ \"latn\" ];\n-\t\tfor( var ns in numberingSystems){\n-\t\t\tif(numberingSystems[ns]._type==\"numeric\"&&ns!=\"latn\"){\n-\t\t\t\tavailableNumberingSystems.push(ns);\n-\t\t\t}\n-\t\t}\n-\n-\t\t// Utility function for Synchronous JSON loading using Dojo require.\n-\t\tfunction getCLDRJson(locale, path) {\n-\t\t\tvar result = undefined;\n-\t\t\tvar url = require.toUrl(\"ecma402/cldr/\"+locale+\"/\"+path+\".json\");\n-\t\t\tvar options = {\n-\t\t\t\tsync : true,\n-\t\t\t\thandleAs : \"json\"\n-\t\t\t};\n-\t\t\trequest(url, options).then(function(data) {\n-\t\t\t\tresult = data;\n-\t\t\t}, function(error) {\n-\t\t\t\tresult = null;\n-\t\t\t});\n-\t\t\treturn result;\n-\t\t}\n-\n-\t\t// ECMA 402 Section 6.1\n-\t\tfunction _toUpperCaseIdentifier(/* String */identifier) {\n-\t\t\tvar match = /[a-z]/g;\n-\t\t\treturn identifier.replace(match, function(m) {\n-\t\t\t\treturn m.toUpperCase();\n-\t\t\t}); // String\n-\t\t}\n+/* JavaScript implementation of Internationalization APIs as defined in ECMA standard 402 version 1.0 */\n+require.config({","path":"Intl.js","position":49,"original_position":49,"commit_id":"95c84f3bb6e086ce14fbb6380969291e1a96277d","original_commit_id":"95c84f3bb6e086ce14fbb6380969291e1a96277d","user":{"login":"clmath","id":1646979,"avatar_url":"https://avatars.githubusercontent.com/u/1646979?","gravatar_id":"6830655947b2cbb847fdd460f2136931","url":"https://api.github.com/users/clmath","html_url":"https://github.com/clmath","followers_url":"https://api.github.com/users/clmath/followers","following_url":"https://api.github.com/users/clmath/following{/other_user}","gists_url":"https://api.github.com/users/clmath/gists{/gist_id}","starred_url":"https://api.github.com/users/clmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clmath/subscriptions","organizations_url":"https://api.github.com/users/clmath/orgs","repos_url":"https://api.github.com/users/clmath/repos","events_url":"https://api.github.com/users/clmath/events{/privacy}","received_events_url":"https://api.github.com/users/clmath/received_events","type":"User","site_admin":false},"body":"This will break almost all applications. Requirejs config is shared for the whole application. So the modification of baseUrl, paths, and shim is forbidden as this could overwrite user config and prevent the resolution of other modules.\r\nInstead you can use relative paths to refer to ./requirejs/text for instance.","created_at":"2014-04-14T13:51:58Z","updated_at":"2014-04-14T13:51:58Z","html_url":"https://github.com/ibm-js/ecma402/pull/8#discussion_r11584662","pull_request_url":"https://api.github.com/repos/ibm-js/ecma402/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/ibm-js/ecma402/pulls/comments/11584662"},"html":{"href":"https://github.com/ibm-js/ecma402/pull/8#discussion_r11584662"},"pull_request":{"href":"https://api.github.com/repos/ibm-js/ecma402/pulls/8"}}}}