GitHub PullRequestReviewCommentEvent at 2014-03-21 21:51:25
Repository: razor-server
Actor: smcclellan
Payload: {"comment":{"url":"https://api.github.com/repos/puppetlabs/razor-server/pulls/comments/10856072","id":10856072,"diff_hunk":"@@ -85,13 +84,13 @@ def metadata\n     # there is both a file-based and a DB-backed task with the same\n     # name, we use the file-based one.\n     def self.find(name)\n-      if yaml = find_on_task_paths(\"#{name}.yaml\")\n+      if yaml = find_on_task_paths(name, 'metadata.yaml')\n         metadata = YAML::load(File::read(yaml)) || {}\n         new(name, metadata)\n       elsif inst = Razor::Data::Task[:name => name]\n         inst\n       elsif !yaml\n-        raise TaskNotFoundError, _(\"No task %{name}.yaml on search path\") % {name: name}\n+        raise TaskNotFoundError, _(\"Tried to look up task %{name} but could not find a directory %{name}.task on the search path\") % {name: name}","path":"lib/razor/task.rb","position":43,"original_position":43,"commit_id":"c19ed75bed960e13e807bdcd211948c2a10d3ed1","original_commit_id":"c19ed75bed960e13e807bdcd211948c2a10d3ed1","user":{"login":"smcclellan","id":6577757,"avatar_url":"https://avatars.githubusercontent.com/u/6577757?","gravatar_id":"ac25dfebee668089f078156e970f31ec","url":"https://api.github.com/users/smcclellan","html_url":"https://github.com/smcclellan","followers_url":"https://api.github.com/users/smcclellan/followers","following_url":"https://api.github.com/users/smcclellan/following{/other_user}","gists_url":"https://api.github.com/users/smcclellan/gists{/gist_id}","starred_url":"https://api.github.com/users/smcclellan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcclellan/subscriptions","organizations_url":"https://api.github.com/users/smcclellan/orgs","repos_url":"https://api.github.com/users/smcclellan/repos","events_url":"https://api.github.com/users/smcclellan/events{/privacy}","received_events_url":"https://api.github.com/users/smcclellan/received_events","type":"User","site_admin":false},"body":"This raises a separate question of whether error messages should:\r\na) discuss how to fix the problem according to the current implementation (David's suggestion that was adopted here), or\r\nb) just explain the conceptual problem (Daniel's suggestion above).\r\nI think either approach is coherent, we just need to be consistent.","created_at":"2014-03-21T21:51:25Z","updated_at":"2014-03-21T21:51:25Z","html_url":"https://github.com/puppetlabs/razor-server/pull/163#discussion_r10856072","pull_request_url":"https://api.github.com/repos/puppetlabs/razor-server/pulls/163","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/razor-server/pulls/comments/10856072"},"html":{"href":"https://github.com/puppetlabs/razor-server/pull/163#discussion_r10856072"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/razor-server/pulls/163"}}}}