GitHub PullRequestReviewCommentEvent at 2014-07-17 15:06:38
Repository: relex
Actor: linas
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opencog/relex/pulls/comments/15062733","id":15062733,"diff_hunk":"@@ -588,6 +588,93 @@ public boolean test_comparatives()\n \t\t\t\t    \"_comparative(enjoyable, maths)\\n\"+\r\n \t\t\t\t    \"_advmod(enjoyable, less)\\n\"+\r\n \t\t\t\t    \"degree(enjoyable, comparative)\\n\");\r\n+\t\t\r\n+\t\t//Comparatives Without More/less terms\r\n+\t\trc &= test_sentence (\"Her great-grandson is nicer than her great-granddaughter.\",\r\n+\t\t\t\t    \"_subj(is, great grandson)\\n\"+\r\n+\t\t\t\t    \"than(great grandson, great granddaughter)\\n\"+\r\n+\t\t\t\t    \"_predadj(great-grandson, nice)\\n\"+\r\n+\t\t\t\t    \"_poss(great grandson, her)\\n\"+\r\n+\t\t\t\t    \"_poss(great granddaughter, her)\\n\"+\r\n+\t\t\t\t    \"_comparative(nicer, great grandson)\\n\"+\r\n+\t\t\t\t    \"degree(nice, comparative\\n\");\r\n+\t\t\r\n+\t\trc &= test_sentence (\"George is cleverer than Norman.\",\r\n+\t\t\t\t    \"_subj(is, George)\\n\"+\r\n+\t\t\t\t    \"than(George, Norman)\\n\"+\r\n+\t\t\t\t    \"_predadj(George, clever)\\n\"+\r\n+\t\t\t\t    \"_comparative(clever, George)\\n\"+\r\n+\t\t\t\t    \"degree(clever, comparative)\\n\");\r\n+\t\t\r\n+\t\trc &= test_sentence (\"Kim is taller than Linda.\",\r\n+\t\t\t\t    \"_subj(is, Kim)\\n\"+\r\n+\t\t\t\t    \"than(Kim, Linda)\\n\"+\r\n+\t\t\t\t    \"_predadj(Kim, tall)\\n\"+\r\n+\t\t\t\t    \"_comparative(tall, kim)\\n\"+\r\n+\t\t\t\t    \"degree(tall, comparative)\\n\");\t\r\n+\t\t\t\t\r\n+\t\trc &= test_sentence (\"Venus is brighter than Pluto.\",\r\n+\t\t\t\t    \"_subj(is, Venus)\\n\"+\r\n+\t\t\t\t    \"than(Venus, Pluto)\\n\"+\r\n+\t\t\t\t    \"_predadj(Venus, bright)\\n\"+\r\n+\t\t\t\t    \"_comparative(bright, Venus)\\n\"+\r\n+\t\t\t\t    \"degree(bright, comparative)\\n\");\r\n+\t\t\r\n+\t\trc &= test_sentence (\"Mary is shorter than Jane.\",\r\n+\t\t\t\t    \"_subj(is, Mary)\\n\"+\r\n+\t\t\t\t    \"than(Mary, Jane)\\n\"+\r\n+\t\t\t\t    \"_predadj(Mary, short)\\n\"+\r\n+\t\t\t\t    \"_comparative(short, Mary)\\n\"+\r\n+\t\t\t\t    \"degree(short, comparative)\\n\");\r\n+\t\t\r\n+\t\trc &= test_sentence (\"I am happier than you.\",\r\n+\t\t\t\t    \"_subj(am, I)\\n\"+\r\n+\t\t\t\t    \"than(I, you)\\n\"+\r\n+\t\t\t\t    \"_predadj(I, happy)\\n\"+\r\n+\t\t\t\t    \"_comparative(happy, I)\\n\"+\r\n+\t\t\t\t    \"degree(happy, comparative)\");\r\n+\t\t\r\n+\t\trc &= test_sentence (\"His house is bigger than hers.\",\r\n+\t\t\t\t    \"_subj(is, house)\\n\"+\r\n+\t\t\t\t    \"than(house, hers)\\n\"+\r\n+\t\t\t\t    \"_predadj(house, bigger)\\n\"+\r\n+\t\t\t\t    \"_poss(house, him)\\n\"+\r\n+\t\t\t\t    \"_comparative(bigger ,house)\\n\"+\r\n+\t\t\t\t    \"degree(bigger, comparative)\");\r\n+\t\t\r\n+\t\trc &= test_sentence (\"She is two years older than me.\",\r\n+\t\t\t\t    \"_obj(is, year)\\n\"+\r\n+\t\t\t\t    \"_subj(is, she)\\n\"+\r\n+\t\t\t\t    \"_amod(year, old)\\n\"+\r\n+\t\t\t\t    \"_quantity(year, two)\\n\"+\r\n+\t\t\t\t    \"numeric-FLAG(two, T)\\n\" +\r\n+\t\t\t\t    \"than(she, me)\\n\"+\r\n+\t\t\t\t    \"_comparative(old, she)\\n\"+\r\n+\t\t\t\t    \"degree(older, comparative)\");\r\n+\t\t\r\n+\t\trc &= test_sentence (\"New York is much bigger than Boston.\",\r\n+\t\t\t\t    \"_subj(is, New_York)\\n\"+\r\n+\t\t\t\t    \"_amod(much, bigger)\\n\"+\r\n+\t\t\t\t    \"than(New_York, Boston)\\n\"+\r\n+\t\t\t\t    \"_comparative(big, New_York)\\n\"+\r\n+\t\t\t\t    \"degree(biger, comparative)\");\r\n+\r\n+\t\trc &= test_sentence (\"He is a better player than Ronaldo.\",\r\n+\t\t\t\t    \"_obj(is, player)\\n\"+\r\n+\t\t\t\t    \"_subj(is, he)\\n\"+\r\n+\t\t\t\t    \"_amod(player, well)\\n\"+\r","path":"src/java_test/relex/test/TestRelEx.java","position":78,"original_position":78,"commit_id":"1d04226805f699c3590d475ecae054ce5fbd5518","original_commit_id":"1d04226805f699c3590d475ecae054ce5fbd5518","user":{"login":"linas","id":94368,"avatar_url":"https://avatars.githubusercontent.com/u/94368?","gravatar_id":"a221b4b4e6dd199750731c51ee864a91","url":"https://api.github.com/users/linas","html_url":"https://github.com/linas","followers_url":"https://api.github.com/users/linas/followers","following_url":"https://api.github.com/users/linas/following{/other_user}","gists_url":"https://api.github.com/users/linas/gists{/gist_id}","starred_url":"https://api.github.com/users/linas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linas/subscriptions","organizations_url":"https://api.github.com/users/linas/orgs","repos_url":"https://api.github.com/users/linas/repos","events_url":"https://api.github.com/users/linas/events{/privacy}","received_events_url":"https://api.github.com/users/linas/received_events","type":"User","site_admin":false},"body":"For me, _amod here is just fine, unless @ruiting  wants something else.   The A link is an adjective link, the lower-case m (not AM, but Am) is used with comparatives.  See http://www.abisource.com/projects/link-grammar/dict/index.html\r\n\r\nThe link-grammar subscript .a-c is NOT a \"POS tag\" -- it looks kind-of-like one, but it isn't.  Its just some arbitrary string used to simplify dictionary maintenance.  However, as it happens, the link-grammar .a-c subscript will appear only on comparative adjectives.\r\n\r\nNormally, the declension is \"good better best\"  not \"well better best\"  Although for health, one can say: \"Is he sick? No, he is better, he is well.\"  But for most cases \"good\" should be the default.","created_at":"2014-07-17T15:06:38Z","updated_at":"2014-07-17T15:06:38Z","html_url":"https://github.com/opencog/relex/pull/123#discussion_r15062733","pull_request_url":"https://api.github.com/repos/opencog/relex/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/opencog/relex/pulls/comments/15062733"},"html":{"href":"https://github.com/opencog/relex/pull/123#discussion_r15062733"},"pull_request":{"href":"https://api.github.com/repos/opencog/relex/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/opencog/relex/pulls/123","id":18460217,"html_url":"https://github.com/opencog/relex/pull/123","diff_url":"https://github.com/opencog/relex/pull/123.diff","patch_url":"https://github.com/opencog/relex/pull/123.patch","issue_url":"https://api.github.com/repos/opencog/relex/issues/123","number":123,"state":"closed","title":"Comparatives Without More/less terms","user":{"login":"kkasunperera","id":1896937,"avatar_url":"https://avatars.githubusercontent.com/u/1896937?","gravatar_id":"812a5bca864808b589e6a945fb0533a0","url":"https://api.github.com/users/kkasunperera","html_url":"https://github.com/kkasunperera","followers_url":"https://api.github.com/users/kkasunperera/followers","following_url":"https://api.github.com/users/kkasunperera/following{/other_user}","gists_url":"https://api.github.com/users/kkasunperera/gists{/gist_id}","starred_url":"https://api.github.com/users/kkasunperera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkasunperera/subscriptions","organizations_url":"https://api.github.com/users/kkasunperera/orgs","repos_url":"https://api.github.com/users/kkasunperera/repos","events_url":"https://api.github.com/users/kkasunperera/events{/privacy}","received_events_url":"https://api.github.com/users/kkasunperera/received_events","type":"User","site_admin":false},"body":"@ruiting @linas please check newly added test sentences. ","created_at":"2014-07-16T10:34:39Z","updated_at":"2014-07-17T15:06:38Z","closed_at":"2014-07-16T14:43:21Z","merged_at":"2014-07-16T14:43:21Z","merge_commit_sha":"6286b1531fe980c2df4ea8b4e2eb726924fcbf34","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencog/relex/pulls/123/commits","review_comments_url":"https://api.github.com/repos/opencog/relex/pulls/123/comments","review_comment_url":"https://api.github.com/repos/opencog/relex/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opencog/relex/issues/123/comments","statuses_url":"https://api.github.com/repos/opencog/relex/statuses/1d04226805f699c3590d475ecae054ce5fbd5518","head":{"label":"kkasunperera:newunittests","ref":"newunittests","sha":"1d04226805f699c3590d475ecae054ce5fbd5518","user":{"login":"kkasunperera","id":1896937,"avatar_url":"https://avatars.githubusercontent.com/u/1896937?","gravatar_id":"812a5bca864808b589e6a945fb0533a0","url":"https://api.github.com/users/kkasunperera","html_url":"https://github.com/kkasunperera","followers_url":"https://api.github.com/users/kkasunperera/followers","following_url":"https://api.github.com/users/kkasunperera/following{/other_user}","gists_url":"https://api.github.com/users/kkasunperera/gists{/gist_id}","starred_url":"https://api.github.com/users/kkasunperera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkasunperera/subscriptions","organizations_url":"https://api.github.com/users/kkasunperera/orgs","repos_url":"https://api.github.com/users/kkasunperera/repos","events_url":"https://api.github.com/users/kkasunperera/events{/privacy}","received_events_url":"https://api.github.com/users/kkasunperera/received_events","type":"User","site_admin":false},"repo":{"id":17587521,"name":"relex","full_name":"kkasunperera/relex","owner":{"login":"kkasunperera","id":1896937,"avatar_url":"https://avatars.githubusercontent.com/u/1896937?","gravatar_id":"812a5bca864808b589e6a945fb0533a0","url":"https://api.github.com/users/kkasunperera","html_url":"https://github.com/kkasunperera","followers_url":"https://api.github.com/users/kkasunperera/followers","following_url":"https://api.github.com/users/kkasunperera/following{/other_user}","gists_url":"https://api.github.com/users/kkasunperera/gists{/gist_id}","starred_url":"https://api.github.com/users/kkasunperera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkasunperera/subscriptions","organizations_url":"https://api.github.com/users/kkasunperera/orgs","repos_url":"https://api.github.com/users/kkasunperera/repos","events_url":"https://api.github.com/users/kkasunperera/events{/privacy}","received_events_url":"https://api.github.com/users/kkasunperera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkasunperera/relex","description":"Dependency Relationship Extractor, standalone & OpenCog Natural Langage Processing (NLP) Pipeline","fork":true,"url":"https://api.github.com/repos/kkasunperera/relex","forks_url":"https://api.github.com/repos/kkasunperera/relex/forks","keys_url":"https://api.github.com/repos/kkasunperera/relex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkasunperera/relex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkasunperera/relex/teams","hooks_url":"https://api.github.com/repos/kkasunperera/relex/hooks","issue_events_url":"https://api.github.com/repos/kkasunperera/relex/issues/events{/number}","events_url":"https://api.github.com/repos/kkasunperera/relex/events","assignees_url":"https://api.github.com/repos/kkasunperera/relex/assignees{/user}","branches_url":"https://api.github.com/repos/kkasunperera/relex/branches{/branch}","tags_url":"https://api.github.com/repos/kkasunperera/relex/tags","blobs_url":"https://api.github.com/repos/kkasunperera/relex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkasunperera/relex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkasunperera/relex/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkasunperera/relex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkasunperera/relex/statuses/{sha}","languages_url":"https://api.github.com/repos/kkasunperera/relex/languages","stargazers_url":"https://api.github.com/repos/kkasunperera/relex/stargazers","contributors_url":"https://api.github.com/repos/kkasunperera/relex/contributors","subscribers_url":"https://api.github.com/repos/kkasunperera/relex/subscribers","subscription_url":"https://api.github.com/repos/kkasunperera/relex/subscription","commits_url":"https://api.github.com/repos/kkasunperera/relex/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkasunperera/relex/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkasunperera/relex/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkasunperera/relex/issues/comments/{number}","contents_url":"https://api.github.com/repos/kkasunperera/relex/contents/{+path}","compare_url":"https://api.github.com/repos/kkasunperera/relex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkasunperera/relex/merges","archive_url":"https://api.github.com/repos/kkasunperera/relex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkasunperera/relex/downloads","issues_url":"https://api.github.com/repos/kkasunperera/relex/issues{/number}","pulls_url":"https://api.github.com/repos/kkasunperera/relex/pulls{/number}","milestones_url":"https://api.github.com/repos/kkasunperera/relex/milestones{/number}","notifications_url":"https://api.github.com/repos/kkasunperera/relex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkasunperera/relex/labels{/name}","releases_url":"https://api.github.com/repos/kkasunperera/relex/releases{/id}","created_at":"2014-03-10T09:27:49Z","updated_at":"2014-07-07T15:37:01Z","pushed_at":"2014-07-17T10:44:13Z","git_url":"git://github.com/kkasunperera/relex.git","ssh_url":"git@github.com:kkasunperera/relex.git","clone_url":"https://github.com/kkasunperera/relex.git","svn_url":"https://github.com/kkasunperera/relex","homepage":"http://wiki.opencog.org/w/RelEx_Dependency_Relationship_Extractor","size":10118,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencog:master","ref":"master","sha":"c95cd4827ee005d72b2718fd1de2a3bedc6bb182","user":{"login":"opencog","id":2109913,"avatar_url":"https://avatars.githubusercontent.com/u/2109913?","gravatar_id":"16d9541d87b425cff27f9ecd14a1cc84","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"repo":{"id":16505851,"name":"relex","full_name":"opencog/relex","owner":{"login":"opencog","id":2109913,"avatar_url":"https://avatars.githubusercontent.com/u/2109913?","gravatar_id":"16d9541d87b425cff27f9ecd14a1cc84","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencog/relex","description":"English Dependency Relationship Extractor","fork":false,"url":"https://api.github.com/repos/opencog/relex","forks_url":"https://api.github.com/repos/opencog/relex/forks","keys_url":"https://api.github.com/repos/opencog/relex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencog/relex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencog/relex/teams","hooks_url":"https://api.github.com/repos/opencog/relex/hooks","issue_events_url":"https://api.github.com/repos/opencog/relex/issues/events{/number}","events_url":"https://api.github.com/repos/opencog/relex/events","assignees_url":"https://api.github.com/repos/opencog/relex/assignees{/user}","branches_url":"https://api.github.com/repos/opencog/relex/branches{/branch}","tags_url":"https://api.github.com/repos/opencog/relex/tags","blobs_url":"https://api.github.com/repos/opencog/relex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencog/relex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencog/relex/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencog/relex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencog/relex/statuses/{sha}","languages_url":"https://api.github.com/repos/opencog/relex/languages","stargazers_url":"https://api.github.com/repos/opencog/relex/stargazers","contributors_url":"https://api.github.com/repos/opencog/relex/contributors","subscribers_url":"https://api.github.com/repos/opencog/relex/subscribers","subscription_url":"https://api.github.com/repos/opencog/relex/subscription","commits_url":"https://api.github.com/repos/opencog/relex/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencog/relex/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencog/relex/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencog/relex/issues/comments/{number}","contents_url":"https://api.github.com/repos/opencog/relex/contents/{+path}","compare_url":"https://api.github.com/repos/opencog/relex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencog/relex/merges","archive_url":"https://api.github.com/repos/opencog/relex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencog/relex/downloads","issues_url":"https://api.github.com/repos/opencog/relex/issues{/number}","pulls_url":"https://api.github.com/repos/opencog/relex/pulls{/number}","milestones_url":"https://api.github.com/repos/opencog/relex/milestones{/number}","notifications_url":"https://api.github.com/repos/opencog/relex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencog/relex/labels{/name}","releases_url":"https://api.github.com/repos/opencog/relex/releases{/id}","created_at":"2014-02-04T08:05:49Z","updated_at":"2014-07-04T22:17:04Z","pushed_at":"2014-07-17T14:23:14Z","git_url":"git://github.com/opencog/relex.git","ssh_url":"git@github.com:opencog/relex.git","clone_url":"https://github.com/opencog/relex.git","svn_url":"https://github.com/opencog/relex","homepage":"http://wiki.opencog.org/w/RelEx","size":11739,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":17,"mirror_url":null,"open_issues_count":28,"forks":17,"open_issues":28,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencog/relex/pulls/123"},"html":{"href":"https://github.com/opencog/relex/pull/123"},"issue":{"href":"https://api.github.com/repos/opencog/relex/issues/123"},"comments":{"href":"https://api.github.com/repos/opencog/relex/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/opencog/relex/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/opencog/relex/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opencog/relex/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/opencog/relex/statuses/1d04226805f699c3590d475ecae054ce5fbd5518"}}}}