GitHub PullRequestReviewCommentEvent at 2014-11-18 15:48:33
Repository: plone.recipe.codeanalysis
Actor: gforcada
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls/comments/20513492","id":20513492,"diff_hunk":"@@ -70,3 +70,20 @@ def test_find_files(self):\n         sorted_output = '\\n'.join(sorted(output.splitlines()))\n         expect = '\\n'.join([x.name for x in temp_files])\n         self.assertEqual(expect, sorted_output)\n+\n+","path":"plone/recipe/codeanalysis/tests/test_utils.py","position":5,"original_position":5,"commit_id":"9050e08d46985fc6581ab4d5597ba508f1e9b5cc","original_commit_id":"9050e08d46985fc6581ab4d5597ba508f1e9b5cc","user":{"login":"gforcada","id":1155680,"avatar_url":"https://avatars.githubusercontent.com/u/1155680?v=3","gravatar_id":"","url":"https://api.github.com/users/gforcada","html_url":"https://github.com/gforcada","followers_url":"https://api.github.com/users/gforcada/followers","following_url":"https://api.github.com/users/gforcada/following{/other_user}","gists_url":"https://api.github.com/users/gforcada/gists{/gist_id}","starred_url":"https://api.github.com/users/gforcada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gforcada/subscriptions","organizations_url":"https://api.github.com/users/gforcada/orgs","repos_url":"https://api.github.com/users/gforcada/repos","events_url":"https://api.github.com/users/gforcada/events{/privacy}","received_events_url":"https://api.github.com/users/gforcada/received_events","type":"User","site_admin":false},"body":"Just one line between two methods of a class (pep8) as travis already complained ","created_at":"2014-11-18T15:48:33Z","updated_at":"2014-11-18T15:48:33Z","html_url":"https://github.com/plone/plone.recipe.codeanalysis/pull/102#discussion_r20513492","pull_request_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls/comments/20513492"},"html":{"href":"https://github.com/plone/plone.recipe.codeanalysis/pull/102#discussion_r20513492"},"pull_request":{"href":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls/102","id":24619450,"html_url":"https://github.com/plone/plone.recipe.codeanalysis/pull/102","diff_url":"https://github.com/plone/plone.recipe.codeanalysis/pull/102.diff","patch_url":"https://github.com/plone/plone.recipe.codeanalysis/pull/102.patch","issue_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/issues/102","number":102,"state":"open","locked":false,"title":"fix(utils): Find files but not directories","user":{"login":"do3cc","id":147512,"avatar_url":"https://avatars.githubusercontent.com/u/147512?v=3","gravatar_id":"","url":"https://api.github.com/users/do3cc","html_url":"https://github.com/do3cc","followers_url":"https://api.github.com/users/do3cc/followers","following_url":"https://api.github.com/users/do3cc/following{/other_user}","gists_url":"https://api.github.com/users/do3cc/gists{/gist_id}","starred_url":"https://api.github.com/users/do3cc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/do3cc/subscriptions","organizations_url":"https://api.github.com/users/do3cc/orgs","repos_url":"https://api.github.com/users/do3cc/repos","events_url":"https://api.github.com/users/do3cc/events{/privacy}","received_events_url":"https://api.github.com/users/do3cc/received_events","type":"User","site_admin":false},"body":"This occured in ploneintranet, where\r\na directory has a name of something.js\r\nThe checker treated it as a file.","created_at":"2014-11-18T15:34:45Z","updated_at":"2014-11-18T15:48:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29dfd81446a0bd8dee876c97e53ea5ec8cbcfacf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls/102/commits","review_comments_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls/102/comments","review_comment_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls/comments/{number}","comments_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/issues/102/comments","statuses_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/statuses/9050e08d46985fc6581ab4d5597ba508f1e9b5cc","head":{"label":"plone:no_directories","ref":"no_directories","sha":"9050e08d46985fc6581ab4d5597ba508f1e9b5cc","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":11405954,"name":"plone.recipe.codeanalysis","full_name":"plone/plone.recipe.codeanalysis","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/plone.recipe.codeanalysis","description":"provides static code analysis for Buildout-based Python projects, including flake8, JSHint, CSS Lint, and other code checks","fork":false,"url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis","forks_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/forks","keys_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/teams","hooks_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/hooks","issue_events_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/issues/events{/number}","events_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/events","assignees_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/assignees{/user}","branches_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/branches{/branch}","tags_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/tags","blobs_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/languages","stargazers_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/stargazers","contributors_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/contributors","subscribers_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/subscribers","subscription_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/subscription","commits_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/issues/comments/{number}","contents_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/contents/{+path}","compare_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/merges","archive_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/downloads","issues_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/issues{/number}","pulls_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/labels{/name}","releases_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/releases{/id}","created_at":"2013-07-14T16:49:40Z","updated_at":"2014-11-09T19:32:59Z","pushed_at":"2014-11-18T15:34:38Z","git_url":"git://github.com/plone/plone.recipe.codeanalysis.git","ssh_url":"git@github.com:plone/plone.recipe.codeanalysis.git","clone_url":"https://github.com/plone/plone.recipe.codeanalysis.git","svn_url":"https://github.com/plone/plone.recipe.codeanalysis","homepage":"https://pypi.python.org/pypi/plone.recipe.codeanalysis","size":2138,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":37,"forks":6,"open_issues":37,"watchers":9,"default_branch":"master"}},"base":{"label":"plone:master","ref":"master","sha":"0aebef31cb55f907e8112a4535fecc81504e7afe","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":11405954,"name":"plone.recipe.codeanalysis","full_name":"plone/plone.recipe.codeanalysis","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/plone.recipe.codeanalysis","description":"provides static code analysis for Buildout-based Python projects, including flake8, JSHint, CSS Lint, and other code checks","fork":false,"url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis","forks_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/forks","keys_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/teams","hooks_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/hooks","issue_events_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/issues/events{/number}","events_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/events","assignees_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/assignees{/user}","branches_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/branches{/branch}","tags_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/tags","blobs_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/languages","stargazers_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/stargazers","contributors_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/contributors","subscribers_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/subscribers","subscription_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/subscription","commits_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/issues/comments/{number}","contents_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/contents/{+path}","compare_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/merges","archive_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/downloads","issues_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/issues{/number}","pulls_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/labels{/name}","releases_url":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/releases{/id}","created_at":"2013-07-14T16:49:40Z","updated_at":"2014-11-09T19:32:59Z","pushed_at":"2014-11-18T15:34:38Z","git_url":"git://github.com/plone/plone.recipe.codeanalysis.git","ssh_url":"git@github.com:plone/plone.recipe.codeanalysis.git","clone_url":"https://github.com/plone/plone.recipe.codeanalysis.git","svn_url":"https://github.com/plone/plone.recipe.codeanalysis","homepage":"https://pypi.python.org/pypi/plone.recipe.codeanalysis","size":2138,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":37,"forks":6,"open_issues":37,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls/102"},"html":{"href":"https://github.com/plone/plone.recipe.codeanalysis/pull/102"},"issue":{"href":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/issues/102"},"comments":{"href":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/plone/plone.recipe.codeanalysis/statuses/9050e08d46985fc6581ab4d5597ba508f1e9b5cc"}}}}