GitHub PullRequestReviewCommentEvent at 2014-09-28 04:20:29
Repository: rust-openssl
Actor: vhbit
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments/18127476","id":18127476,"diff_hunk":"@@ -9,6 +9,11 @@ extern crate libc;\n extern crate serialize;","path":"src/lib.rs","position":1,"original_position":1,"commit_id":"3f413e9354238919bce6dc87e3415919f301d487","original_commit_id":"4fd169a1e5d465a10d5a815877479baa960a16eb","user":{"login":"vhbit","id":140199,"avatar_url":"https://avatars.githubusercontent.com/u/140199?v=2","gravatar_id":"","url":"https://api.github.com/users/vhbit","html_url":"https://github.com/vhbit","followers_url":"https://api.github.com/users/vhbit/followers","following_url":"https://api.github.com/users/vhbit/following{/other_user}","gists_url":"https://api.github.com/users/vhbit/gists{/gist_id}","starred_url":"https://api.github.com/users/vhbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhbit/subscriptions","organizations_url":"https://api.github.com/users/vhbit/orgs","repos_url":"https://api.github.com/users/vhbit/repos","events_url":"https://api.github.com/users/vhbit/events{/privacy}","received_events_url":"https://api.github.com/users/vhbit/received_events","type":"User","site_admin":false},"body":"No, it seems to be editor issue as I periodically get wrong permissions after changes. I will keep eye on it and find exactly when it happens. ","created_at":"2014-09-28T04:20:29Z","updated_at":"2014-09-28T04:20:29Z","html_url":"https://github.com/sfackler/rust-openssl/pull/53#discussion_r18127476","pull_request_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments/18127476"},"html":{"href":"https://github.com/sfackler/rust-openssl/pull/53#discussion_r18127476"},"pull_request":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/53","id":21833145,"html_url":"https://github.com/sfackler/rust-openssl/pull/53","diff_url":"https://github.com/sfackler/rust-openssl/pull/53.diff","patch_url":"https://github.com/sfackler/rust-openssl/pull/53.patch","issue_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/53","number":53,"state":"open","locked":false,"title":"Certificate/PKey generation & PEM export","user":{"login":"vhbit","id":140199,"avatar_url":"https://avatars.githubusercontent.com/u/140199?v=2","gravatar_id":"","url":"https://api.github.com/users/vhbit","html_url":"https://github.com/vhbit","followers_url":"https://api.github.com/users/vhbit/followers","following_url":"https://api.github.com/users/vhbit/following{/other_user}","gists_url":"https://api.github.com/users/vhbit/gists{/gist_id}","starred_url":"https://api.github.com/users/vhbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhbit/subscriptions","organizations_url":"https://api.github.com/users/vhbit/orgs","repos_url":"https://api.github.com/users/vhbit/repos","events_url":"https://api.github.com/users/vhbit/events{/privacy}","received_events_url":"https://api.github.com/users/vhbit/received_events","type":"User","site_admin":false},"body":"Notes:\r\n\r\n* required a lot of restructuring and one of the questions if there is any particular reason (except of historical) for every module to declare it's own `ffi` submodule? I would like to combine them in one huge shared `ffi` which will be accessible from all modules without a lot of boilerplate. \r\n\r\n* there are a couple of FIXME's left which I'll address one-by-one, the primary reason for early PR is to get as flawless merge as possible considering how many project structure changes are in and potential other PRs.","created_at":"2014-09-26T07:48:08Z","updated_at":"2014-09-28T04:20:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdfc1ba41ea74063a555e70d9aff978201c07b1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/53/commits","review_comments_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/53/comments","review_comment_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/53/comments","statuses_url":"https://api.github.com/repos/sfackler/rust-openssl/statuses/3f413e9354238919bce6dc87e3415919f301d487","head":{"label":"vhbit:cert-gen","ref":"cert-gen","sha":"3f413e9354238919bce6dc87e3415919f301d487","user":{"login":"vhbit","id":140199,"avatar_url":"https://avatars.githubusercontent.com/u/140199?v=2","gravatar_id":"","url":"https://api.github.com/users/vhbit","html_url":"https://github.com/vhbit","followers_url":"https://api.github.com/users/vhbit/followers","following_url":"https://api.github.com/users/vhbit/following{/other_user}","gists_url":"https://api.github.com/users/vhbit/gists{/gist_id}","starred_url":"https://api.github.com/users/vhbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhbit/subscriptions","organizations_url":"https://api.github.com/users/vhbit/orgs","repos_url":"https://api.github.com/users/vhbit/repos","events_url":"https://api.github.com/users/vhbit/events{/privacy}","received_events_url":"https://api.github.com/users/vhbit/received_events","type":"User","site_admin":false},"repo":{"id":23966066,"name":"rust-openssl","full_name":"vhbit/rust-openssl","owner":{"login":"vhbit","id":140199,"avatar_url":"https://avatars.githubusercontent.com/u/140199?v=2","gravatar_id":"","url":"https://api.github.com/users/vhbit","html_url":"https://github.com/vhbit","followers_url":"https://api.github.com/users/vhbit/followers","following_url":"https://api.github.com/users/vhbit/following{/other_user}","gists_url":"https://api.github.com/users/vhbit/gists{/gist_id}","starred_url":"https://api.github.com/users/vhbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhbit/subscriptions","organizations_url":"https://api.github.com/users/vhbit/orgs","repos_url":"https://api.github.com/users/vhbit/repos","events_url":"https://api.github.com/users/vhbit/events{/privacy}","received_events_url":"https://api.github.com/users/vhbit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vhbit/rust-openssl","description":"OpenSSL bindings for Rust","fork":true,"url":"https://api.github.com/repos/vhbit/rust-openssl","forks_url":"https://api.github.com/repos/vhbit/rust-openssl/forks","keys_url":"https://api.github.com/repos/vhbit/rust-openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vhbit/rust-openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vhbit/rust-openssl/teams","hooks_url":"https://api.github.com/repos/vhbit/rust-openssl/hooks","issue_events_url":"https://api.github.com/repos/vhbit/rust-openssl/issues/events{/number}","events_url":"https://api.github.com/repos/vhbit/rust-openssl/events","assignees_url":"https://api.github.com/repos/vhbit/rust-openssl/assignees{/user}","branches_url":"https://api.github.com/repos/vhbit/rust-openssl/branches{/branch}","tags_url":"https://api.github.com/repos/vhbit/rust-openssl/tags","blobs_url":"https://api.github.com/repos/vhbit/rust-openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vhbit/rust-openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vhbit/rust-openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/vhbit/rust-openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vhbit/rust-openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/vhbit/rust-openssl/languages","stargazers_url":"https://api.github.com/repos/vhbit/rust-openssl/stargazers","contributors_url":"https://api.github.com/repos/vhbit/rust-openssl/contributors","subscribers_url":"https://api.github.com/repos/vhbit/rust-openssl/subscribers","subscription_url":"https://api.github.com/repos/vhbit/rust-openssl/subscription","commits_url":"https://api.github.com/repos/vhbit/rust-openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/vhbit/rust-openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/vhbit/rust-openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/vhbit/rust-openssl/issues/comments/{number}","contents_url":"https://api.github.com/repos/vhbit/rust-openssl/contents/{+path}","compare_url":"https://api.github.com/repos/vhbit/rust-openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vhbit/rust-openssl/merges","archive_url":"https://api.github.com/repos/vhbit/rust-openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vhbit/rust-openssl/downloads","issues_url":"https://api.github.com/repos/vhbit/rust-openssl/issues{/number}","pulls_url":"https://api.github.com/repos/vhbit/rust-openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/vhbit/rust-openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/vhbit/rust-openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vhbit/rust-openssl/labels{/name}","releases_url":"https://api.github.com/repos/vhbit/rust-openssl/releases{/id}","created_at":"2014-09-12T15:33:36Z","updated_at":"2014-09-12T17:37:35Z","pushed_at":"2014-09-28T04:19:03Z","git_url":"git://github.com/vhbit/rust-openssl.git","ssh_url":"git@github.com:vhbit/rust-openssl.git","clone_url":"https://github.com/vhbit/rust-openssl.git","svn_url":"https://github.com/vhbit/rust-openssl","homepage":"","size":530,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sfackler:master","ref":"master","sha":"fa53c79e4892dfc260bc6d1e2b52892f5607de72","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=2","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"repo":{"id":15500883,"name":"rust-openssl","full_name":"sfackler/rust-openssl","owner":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=2","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfackler/rust-openssl","description":"OpenSSL bindings for Rust","fork":false,"url":"https://api.github.com/repos/sfackler/rust-openssl","forks_url":"https://api.github.com/repos/sfackler/rust-openssl/forks","keys_url":"https://api.github.com/repos/sfackler/rust-openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfackler/rust-openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfackler/rust-openssl/teams","hooks_url":"https://api.github.com/repos/sfackler/rust-openssl/hooks","issue_events_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/events{/number}","events_url":"https://api.github.com/repos/sfackler/rust-openssl/events","assignees_url":"https://api.github.com/repos/sfackler/rust-openssl/assignees{/user}","branches_url":"https://api.github.com/repos/sfackler/rust-openssl/branches{/branch}","tags_url":"https://api.github.com/repos/sfackler/rust-openssl/tags","blobs_url":"https://api.github.com/repos/sfackler/rust-openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfackler/rust-openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfackler/rust-openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfackler/rust-openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfackler/rust-openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/sfackler/rust-openssl/languages","stargazers_url":"https://api.github.com/repos/sfackler/rust-openssl/stargazers","contributors_url":"https://api.github.com/repos/sfackler/rust-openssl/contributors","subscribers_url":"https://api.github.com/repos/sfackler/rust-openssl/subscribers","subscription_url":"https://api.github.com/repos/sfackler/rust-openssl/subscription","commits_url":"https://api.github.com/repos/sfackler/rust-openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfackler/rust-openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfackler/rust-openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/comments/{number}","contents_url":"https://api.github.com/repos/sfackler/rust-openssl/contents/{+path}","compare_url":"https://api.github.com/repos/sfackler/rust-openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfackler/rust-openssl/merges","archive_url":"https://api.github.com/repos/sfackler/rust-openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfackler/rust-openssl/downloads","issues_url":"https://api.github.com/repos/sfackler/rust-openssl/issues{/number}","pulls_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/sfackler/rust-openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/sfackler/rust-openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfackler/rust-openssl/labels{/name}","releases_url":"https://api.github.com/repos/sfackler/rust-openssl/releases{/id}","created_at":"2013-12-28T23:56:50Z","updated_at":"2014-09-27T01:46:11Z","pushed_at":"2014-09-28T04:04:04Z","git_url":"git://github.com/sfackler/rust-openssl.git","ssh_url":"git@github.com:sfackler/rust-openssl.git","clone_url":"https://github.com/sfackler/rust-openssl.git","svn_url":"https://github.com/sfackler/rust-openssl","homepage":"","size":1708,"stargazers_count":40,"watchers_count":40,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":8,"forks":31,"open_issues":8,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/53"},"html":{"href":"https://github.com/sfackler/rust-openssl/pull/53"},"issue":{"href":"https://api.github.com/repos/sfackler/rust-openssl/issues/53"},"comments":{"href":"https://api.github.com/repos/sfackler/rust-openssl/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/sfackler/rust-openssl/statuses/3f413e9354238919bce6dc87e3415919f301d487"}}}}