GitHub PullRequestReviewCommentEvent at 2014-12-28 13:59:45
Repository: appleseed
Actor: est77
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/22298074","id":22298074,"diff_hunk":"@@ -638,7 +638,7 @@ void ShadingPoint::initialize_osl_shader_globals(\n         m_shader_globals.dIdx = OSL::Vec3(0.0f, 0.0f, 0.0f);\n         m_shader_globals.dIdy = OSL::Vec3(0.0f, 0.0f, 0.0f);\n \n-        m_shader_globals.N = Vector3f(get_shading_normal());\n+        m_shader_globals.N = Vector3f(get_original_shading_normal());","path":"src/appleseed/renderer/kernel/shading/shadingpoint.cpp","position":5,"original_position":5,"commit_id":"766d508b4896d2921ee9d9f4c0ae35fc1458cbf7","original_commit_id":"766d508b4896d2921ee9d9f4c0ae35fc1458cbf7","user":{"login":"est77","id":409013,"avatar_url":"https://avatars.githubusercontent.com/u/409013?v=3","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"body":"The OSL material does not support appleseed's bump / normal mapping, so it does not really change anything.","created_at":"2014-12-28T13:59:45Z","updated_at":"2014-12-28T13:59:45Z","html_url":"https://github.com/appleseedhq/appleseed/pull/649#discussion_r22298074","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/649","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/22298074"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/649#discussion_r22298074"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/649"}}},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/649","id":26624049,"html_url":"https://github.com/appleseedhq/appleseed/pull/649","diff_url":"https://github.com/appleseedhq/appleseed/pull/649.diff","patch_url":"https://github.com/appleseedhq/appleseed/pull/649.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/649","number":649,"state":"open","locked":false,"title":"BSDF sampling refactor #3","user":{"login":"est77","id":409013,"avatar_url":"https://avatars.githubusercontent.com/u/409013?v=3","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"body":"- Do not dll-export BSDFSample.\r\n- Added methods to ShadingPoint to update the shading basis.\r\n- Update the shading basis in ShadingPoint when using OSL shaders.","created_at":"2014-12-28T13:40:22Z","updated_at":"2014-12-28T13:59:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14ee892179d114cfb585f72f2efca695a919206b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/649/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/649/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/{number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/649/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/766d508b4896d2921ee9d9f4c0ae35fc1458cbf7","head":{"label":"est77:est_bsdf_sample_refactor","ref":"est_bsdf_sample_refactor","sha":"766d508b4896d2921ee9d9f4c0ae35fc1458cbf7","user":{"login":"est77","id":409013,"avatar_url":"https://avatars.githubusercontent.com/u/409013?v=3","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"repo":{"id":10621343,"name":"appleseed","full_name":"est77/appleseed","owner":{"login":"est77","id":409013,"avatar_url":"https://avatars.githubusercontent.com/u/409013?v=3","gravatar_id":"","url":"https://api.github.com/users/est77","html_url":"https://github.com/est77","followers_url":"https://api.github.com/users/est77/followers","following_url":"https://api.github.com/users/est77/following{/other_user}","gists_url":"https://api.github.com/users/est77/gists{/gist_id}","starred_url":"https://api.github.com/users/est77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est77/subscriptions","organizations_url":"https://api.github.com/users/est77/orgs","repos_url":"https://api.github.com/users/est77/repos","events_url":"https://api.github.com/users/est77/events{/privacy}","received_events_url":"https://api.github.com/users/est77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/est77/appleseed","description":"appleseed is a modern, physically-based production renderer.","fork":true,"url":"https://api.github.com/repos/est77/appleseed","forks_url":"https://api.github.com/repos/est77/appleseed/forks","keys_url":"https://api.github.com/repos/est77/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/est77/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/est77/appleseed/teams","hooks_url":"https://api.github.com/repos/est77/appleseed/hooks","issue_events_url":"https://api.github.com/repos/est77/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/est77/appleseed/events","assignees_url":"https://api.github.com/repos/est77/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/est77/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/est77/appleseed/tags","blobs_url":"https://api.github.com/repos/est77/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/est77/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/est77/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/est77/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/est77/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/est77/appleseed/languages","stargazers_url":"https://api.github.com/repos/est77/appleseed/stargazers","contributors_url":"https://api.github.com/repos/est77/appleseed/contributors","subscribers_url":"https://api.github.com/repos/est77/appleseed/subscribers","subscription_url":"https://api.github.com/repos/est77/appleseed/subscription","commits_url":"https://api.github.com/repos/est77/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/est77/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/est77/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/est77/appleseed/issues/comments/{number}","contents_url":"https://api.github.com/repos/est77/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/est77/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/est77/appleseed/merges","archive_url":"https://api.github.com/repos/est77/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/est77/appleseed/downloads","issues_url":"https://api.github.com/repos/est77/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/est77/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/est77/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/est77/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/est77/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/est77/appleseed/releases{/id}","created_at":"2013-06-11T12:49:35Z","updated_at":"2014-12-26T23:01:49Z","pushed_at":"2014-12-28T13:36:39Z","git_url":"git://github.com/est77/appleseed.git","ssh_url":"git@github.com:est77/appleseed.git","clone_url":"https://github.com/est77/appleseed.git","svn_url":"https://github.com/est77/appleseed","homepage":"http://appleseedhq.net/","size":498246,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"4469d5db39d517e2a2b709d837767dcbf2e55930","user":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars.githubusercontent.com/u/6373510?v=3","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":753784,"name":"appleseed","full_name":"appleseedhq/appleseed","owner":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars.githubusercontent.com/u/6373510?v=3","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed","description":"appleseed is a modern, physically-based production renderer.","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed","forks_url":"https://api.github.com/repos/appleseedhq/appleseed/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/comments/{number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed/releases{/id}","created_at":"2010-07-02T16:33:51Z","updated_at":"2014-12-27T15:15:41Z","pushed_at":"2014-12-27T15:15:41Z","git_url":"git://github.com/appleseedhq/appleseed.git","ssh_url":"git@github.com:appleseedhq/appleseed.git","clone_url":"https://github.com/appleseedhq/appleseed.git","svn_url":"https://github.com/appleseedhq/appleseed","homepage":"http://appleseedhq.net/","size":557544,"stargazers_count":146,"watchers_count":146,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":170,"forks":50,"open_issues":170,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/649"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/649"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/649"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/649/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/649/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/649/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed/statuses/766d508b4896d2921ee9d9f4c0ae35fc1458cbf7"}}}}