GitHub PullRequestReviewCommentEvent at 2014-10-19 06:59:40
Repository: scikit-learn
Actor: agramfort
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/19058300","id":19058300,"diff_hunk":"@@ -107,9 +109,18 @@ def fit(self, X, y):\n         for cur_class in y_ind:\n             center_mask = y_ind == cur_class\n             nk[cur_class] = np.sum(center_mask)\n-            if sp.issparse(X):\n+            if is_X_sparse:\n                 center_mask = np.where(center_mask)[0]\n-            self.centroids_[cur_class] = X[center_mask].mean(axis=0)\n+\n+            # XXX: Update other averaging methods according to the metrics.\n+            if self.metric == \"manhattan\":\n+                # NumPy does not calculate median of sparse matrices.\n+                if not is_X_sparse:\n+                    self.centroids_[cur_class] = np.median(X[center_mask], axis=0)\n+                else:\n+                    self.centroids_[cur_class] = csc_row_median(X[center_mask])\n+            else:\n+                self.centroids_[cur_class] = X[center_mask].mean(axis=0)","path":"sklearn/neighbors/nearest_centroid.py","position":37,"original_position":37,"commit_id":"33647213fedefc3321259ee39f5b6fa6d4fb5059","original_commit_id":"33647213fedefc3321259ee39f5b6fa6d4fb5059","user":{"login":"agramfort","id":161052,"avatar_url":"https://avatars.githubusercontent.com/u/161052?v=2","gravatar_id":"","url":"https://api.github.com/users/agramfort","html_url":"https://github.com/agramfort","followers_url":"https://api.github.com/users/agramfort/followers","following_url":"https://api.github.com/users/agramfort/following{/other_user}","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","organizations_url":"https://api.github.com/users/agramfort/orgs","repos_url":"https://api.github.com/users/agramfort/repos","events_url":"https://api.github.com/users/agramfort/events{/privacy}","received_events_url":"https://api.github.com/users/agramfort/received_events","type":"User","site_admin":false},"body":"is it me or only euclidian and manhattan metrics are supported?\r\n\r\nany good reason why no docstring is modified?","created_at":"2014-10-19T06:59:40Z","updated_at":"2014-10-19T06:59:40Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/3772#discussion_r19058300","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3772","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/19058300"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/3772#discussion_r19058300"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3772"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3772","id":22715990,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/3772","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/3772.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/3772.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3772","number":3772,"state":"open","locked":false,"title":"[MRG] ENH: Patches Nearest Centroid for metric=manhattan for sparse and dense data","user":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=2","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/scikit-learn/scikit-learn/issues/743\r\n\r\nI have also added a utility for calculating the median of csc sparse matrices, since NumPy does not handle it and it is not a trivial one-liner","created_at":"2014-10-14T14:37:30Z","updated_at":"2014-10-19T06:59:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b795142ae6bbf04f9a958a0dabb53e779bc9dbcc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3772/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3772/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3772/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/33647213fedefc3321259ee39f5b6fa6d4fb5059","head":{"label":"MechCoder:manhattan_metric","ref":"manhattan_metric","sha":"33647213fedefc3321259ee39f5b6fa6d4fb5059","user":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=2","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"repo":{"id":9655682,"name":"scikit-learn","full_name":"MechCoder/scikit-learn","owner":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=2","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MechCoder/scikit-learn","description":"Work in Progress","fork":true,"url":"https://api.github.com/repos/MechCoder/scikit-learn","forks_url":"https://api.github.com/repos/MechCoder/scikit-learn/forks","keys_url":"https://api.github.com/repos/MechCoder/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MechCoder/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MechCoder/scikit-learn/teams","hooks_url":"https://api.github.com/repos/MechCoder/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/MechCoder/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/MechCoder/scikit-learn/events","assignees_url":"https://api.github.com/repos/MechCoder/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/MechCoder/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/MechCoder/scikit-learn/tags","blobs_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MechCoder/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/MechCoder/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/MechCoder/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/MechCoder/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/MechCoder/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/MechCoder/scikit-learn/subscription","commits_url":"https://api.github.com/repos/MechCoder/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/MechCoder/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/MechCoder/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/MechCoder/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/MechCoder/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MechCoder/scikit-learn/merges","archive_url":"https://api.github.com/repos/MechCoder/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MechCoder/scikit-learn/downloads","issues_url":"https://api.github.com/repos/MechCoder/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/MechCoder/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/MechCoder/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/MechCoder/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MechCoder/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/MechCoder/scikit-learn/releases{/id}","created_at":"2013-04-24T19:16:18Z","updated_at":"2014-07-17T15:12:34Z","pushed_at":"2014-10-18T09:46:17Z","git_url":"git://github.com/MechCoder/scikit-learn.git","ssh_url":"git@github.com:MechCoder/scikit-learn.git","clone_url":"https://github.com/MechCoder/scikit-learn.git","svn_url":"https://github.com/MechCoder/scikit-learn","homepage":"http://scikit-learn.org","size":58167,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"b27ee407adb8150cff2f119eb93f6831b2f3f99d","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=2","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=2","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2014-10-19T04:54:08Z","pushed_at":"2014-10-17T11:59:23Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":121797,"stargazers_count":4089,"watchers_count":4089,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2325,"mirror_url":null,"open_issues_count":516,"forks":2325,"open_issues":516,"watchers":4089,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3772"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/3772"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3772"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3772/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3772/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3772/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/33647213fedefc3321259ee39f5b6fa6d4fb5059"}}}}