GitHub PullRequestReviewCommentEvent at 2014-06-12 12:50:26
Repository: appblocks
Actor: abhideep
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sarality/appblocks/pulls/comments/13699286","id":13699286,"diff_hunk":"@@ -0,0 +1,81 @@\n+package com.sarality.app.view.action;\n+\n+import java.util.List;\n+\n+import android.util.Log;\n+import android.util.SparseArray;\n+import android.view.View;\n+\n+public class ComponentAction<T> {\n+\n+  // Tag for Logging\n+  private static final String TAG = \"ComponentAction\";\n+\n+  // Map of View ID and compositeView Action\n+  SparseArray<CompositeViewAction<T>> viewMap = new SparseArray<CompositeViewAction<T>>();","path":"src/java/com/sarality/app/view/action/ComponentAction.java","position":15,"original_position":15,"commit_id":"4be2de61f03d979891eeb3a14769f7f6e4d9e8b7","original_commit_id":"4be2de61f03d979891eeb3a14769f7f6e4d9e8b7","user":{"login":"abhideep","id":5652836,"avatar_url":"https://avatars.githubusercontent.com/u/5652836?","gravatar_id":"288c85a5481c9611b85466e2c17f23f3","url":"https://api.github.com/users/abhideep","html_url":"https://github.com/abhideep","followers_url":"https://api.github.com/users/abhideep/followers","following_url":"https://api.github.com/users/abhideep/following{/other_user}","gists_url":"https://api.github.com/users/abhideep/gists{/gist_id}","starred_url":"https://api.github.com/users/abhideep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhideep/subscriptions","organizations_url":"https://api.github.com/users/abhideep/orgs","repos_url":"https://api.github.com/users/abhideep/repos","events_url":"https://api.github.com/users/abhideep/events{/privacy}","received_events_url":"https://api.github.com/users/abhideep/received_events","type":"User","site_admin":false},"body":"I don't think this SparseArray is good enough here. What you want is a\r\nMap<Integer, Map<TriggerType, List<ViewAction<T>>>\r\nor \r\nMap<Integer, Map<TriggerType, CompositeViewAction<T>>>\r\n\r\nWhen you call registerAction(ViewAction viewAction)\r\nYou simply add to the list of action and create CompositeAction when needed.\r\n\r\nI don't see why CompositeAction needs to keep track of which ones are OnClickListeners on it and which are onTouch. That's not it's role.\r\n\r\nWhile we are at it, let's call this class ComponentActionManager. We might want to use ComponentAction in the future for a different purpose \r\n","created_at":"2014-06-12T12:50:26Z","updated_at":"2014-06-12T12:50:26Z","html_url":"https://github.com/sarality/appblocks/pull/62#discussion_r13699286","pull_request_url":"https://api.github.com/repos/sarality/appblocks/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/sarality/appblocks/pulls/comments/13699286"},"html":{"href":"https://github.com/sarality/appblocks/pull/62#discussion_r13699286"},"pull_request":{"href":"https://api.github.com/repos/sarality/appblocks/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/sarality/appblocks/pulls/62","id":17041164,"html_url":"https://github.com/sarality/appblocks/pull/62","diff_url":"https://github.com/sarality/appblocks/pull/62.diff","patch_url":"https://github.com/sarality/appblocks/pull/62.patch","issue_url":"https://api.github.com/repos/sarality/appblocks/issues/62","number":62,"state":"open","title":"Compositeview","user":{"login":"sunayna","id":5754536,"avatar_url":"https://avatars.githubusercontent.com/u/5754536?","gravatar_id":"b2eb2f287e08ef06f221b9e4bd20a473","url":"https://api.github.com/users/sunayna","html_url":"https://github.com/sunayna","followers_url":"https://api.github.com/users/sunayna/followers","following_url":"https://api.github.com/users/sunayna/following{/other_user}","gists_url":"https://api.github.com/users/sunayna/gists{/gist_id}","starred_url":"https://api.github.com/users/sunayna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunayna/subscriptions","organizations_url":"https://api.github.com/users/sunayna/orgs","repos_url":"https://api.github.com/users/sunayna/repos","events_url":"https://api.github.com/users/sunayna/events{/privacy}","received_events_url":"https://api.github.com/users/sunayna/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-12T07:37:00Z","updated_at":"2014-06-12T12:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d883a75c67dbb23e82b1d859540715cd01e5996a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sarality/appblocks/pulls/62/commits","review_comments_url":"https://api.github.com/repos/sarality/appblocks/pulls/62/comments","review_comment_url":"https://api.github.com/repos/sarality/appblocks/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sarality/appblocks/issues/62/comments","statuses_url":"https://api.github.com/repos/sarality/appblocks/statuses/4be2de61f03d979891eeb3a14769f7f6e4d9e8b7","head":{"label":"sarality:compositeview","ref":"compositeview","sha":"4be2de61f03d979891eeb3a14769f7f6e4d9e8b7","user":{"login":"sarality","id":5752439,"avatar_url":"https://avatars.githubusercontent.com/u/5752439?","gravatar_id":null,"url":"https://api.github.com/users/sarality","html_url":"https://github.com/sarality","followers_url":"https://api.github.com/users/sarality/followers","following_url":"https://api.github.com/users/sarality/following{/other_user}","gists_url":"https://api.github.com/users/sarality/gists{/gist_id}","starred_url":"https://api.github.com/users/sarality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarality/subscriptions","organizations_url":"https://api.github.com/users/sarality/orgs","repos_url":"https://api.github.com/users/sarality/repos","events_url":"https://api.github.com/users/sarality/events{/privacy}","received_events_url":"https://api.github.com/users/sarality/received_events","type":"Organization","site_admin":false},"repo":{"id":16136525,"name":"appblocks","full_name":"sarality/appblocks","owner":{"login":"sarality","id":5752439,"avatar_url":"https://avatars.githubusercontent.com/u/5752439?","gravatar_id":null,"url":"https://api.github.com/users/sarality","html_url":"https://github.com/sarality","followers_url":"https://api.github.com/users/sarality/followers","following_url":"https://api.github.com/users/sarality/following{/other_user}","gists_url":"https://api.github.com/users/sarality/gists{/gist_id}","starred_url":"https://api.github.com/users/sarality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarality/subscriptions","organizations_url":"https://api.github.com/users/sarality/orgs","repos_url":"https://api.github.com/users/sarality/repos","events_url":"https://api.github.com/users/sarality/events{/privacy}","received_events_url":"https://api.github.com/users/sarality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sarality/appblocks","description":"The Building Blocks to make it easier to build Android Apps","fork":false,"url":"https://api.github.com/repos/sarality/appblocks","forks_url":"https://api.github.com/repos/sarality/appblocks/forks","keys_url":"https://api.github.com/repos/sarality/appblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarality/appblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarality/appblocks/teams","hooks_url":"https://api.github.com/repos/sarality/appblocks/hooks","issue_events_url":"https://api.github.com/repos/sarality/appblocks/issues/events{/number}","events_url":"https://api.github.com/repos/sarality/appblocks/events","assignees_url":"https://api.github.com/repos/sarality/appblocks/assignees{/user}","branches_url":"https://api.github.com/repos/sarality/appblocks/branches{/branch}","tags_url":"https://api.github.com/repos/sarality/appblocks/tags","blobs_url":"https://api.github.com/repos/sarality/appblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarality/appblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarality/appblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarality/appblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarality/appblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/sarality/appblocks/languages","stargazers_url":"https://api.github.com/repos/sarality/appblocks/stargazers","contributors_url":"https://api.github.com/repos/sarality/appblocks/contributors","subscribers_url":"https://api.github.com/repos/sarality/appblocks/subscribers","subscription_url":"https://api.github.com/repos/sarality/appblocks/subscription","commits_url":"https://api.github.com/repos/sarality/appblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarality/appblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarality/appblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarality/appblocks/issues/comments/{number}","contents_url":"https://api.github.com/repos/sarality/appblocks/contents/{+path}","compare_url":"https://api.github.com/repos/sarality/appblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarality/appblocks/merges","archive_url":"https://api.github.com/repos/sarality/appblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarality/appblocks/downloads","issues_url":"https://api.github.com/repos/sarality/appblocks/issues{/number}","pulls_url":"https://api.github.com/repos/sarality/appblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/sarality/appblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/sarality/appblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarality/appblocks/labels{/name}","releases_url":"https://api.github.com/repos/sarality/appblocks/releases{/id}","created_at":"2014-01-22T10:44:45Z","updated_at":"2014-06-12T07:37:00Z","pushed_at":"2014-06-12T07:35:59Z","git_url":"git://github.com/sarality/appblocks.git","ssh_url":"git@github.com:sarality/appblocks.git","clone_url":"https://github.com/sarality/appblocks.git","svn_url":"https://github.com/sarality/appblocks","homepage":null,"size":2112,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"sarality:master","ref":"master","sha":"a4cf4d09e44722bf123be8546fcf8a80915dc344","user":{"login":"sarality","id":5752439,"avatar_url":"https://avatars.githubusercontent.com/u/5752439?","gravatar_id":null,"url":"https://api.github.com/users/sarality","html_url":"https://github.com/sarality","followers_url":"https://api.github.com/users/sarality/followers","following_url":"https://api.github.com/users/sarality/following{/other_user}","gists_url":"https://api.github.com/users/sarality/gists{/gist_id}","starred_url":"https://api.github.com/users/sarality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarality/subscriptions","organizations_url":"https://api.github.com/users/sarality/orgs","repos_url":"https://api.github.com/users/sarality/repos","events_url":"https://api.github.com/users/sarality/events{/privacy}","received_events_url":"https://api.github.com/users/sarality/received_events","type":"Organization","site_admin":false},"repo":{"id":16136525,"name":"appblocks","full_name":"sarality/appblocks","owner":{"login":"sarality","id":5752439,"avatar_url":"https://avatars.githubusercontent.com/u/5752439?","gravatar_id":null,"url":"https://api.github.com/users/sarality","html_url":"https://github.com/sarality","followers_url":"https://api.github.com/users/sarality/followers","following_url":"https://api.github.com/users/sarality/following{/other_user}","gists_url":"https://api.github.com/users/sarality/gists{/gist_id}","starred_url":"https://api.github.com/users/sarality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarality/subscriptions","organizations_url":"https://api.github.com/users/sarality/orgs","repos_url":"https://api.github.com/users/sarality/repos","events_url":"https://api.github.com/users/sarality/events{/privacy}","received_events_url":"https://api.github.com/users/sarality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sarality/appblocks","description":"The Building Blocks to make it easier to build Android Apps","fork":false,"url":"https://api.github.com/repos/sarality/appblocks","forks_url":"https://api.github.com/repos/sarality/appblocks/forks","keys_url":"https://api.github.com/repos/sarality/appblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarality/appblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarality/appblocks/teams","hooks_url":"https://api.github.com/repos/sarality/appblocks/hooks","issue_events_url":"https://api.github.com/repos/sarality/appblocks/issues/events{/number}","events_url":"https://api.github.com/repos/sarality/appblocks/events","assignees_url":"https://api.github.com/repos/sarality/appblocks/assignees{/user}","branches_url":"https://api.github.com/repos/sarality/appblocks/branches{/branch}","tags_url":"https://api.github.com/repos/sarality/appblocks/tags","blobs_url":"https://api.github.com/repos/sarality/appblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarality/appblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarality/appblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarality/appblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarality/appblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/sarality/appblocks/languages","stargazers_url":"https://api.github.com/repos/sarality/appblocks/stargazers","contributors_url":"https://api.github.com/repos/sarality/appblocks/contributors","subscribers_url":"https://api.github.com/repos/sarality/appblocks/subscribers","subscription_url":"https://api.github.com/repos/sarality/appblocks/subscription","commits_url":"https://api.github.com/repos/sarality/appblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarality/appblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarality/appblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarality/appblocks/issues/comments/{number}","contents_url":"https://api.github.com/repos/sarality/appblocks/contents/{+path}","compare_url":"https://api.github.com/repos/sarality/appblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarality/appblocks/merges","archive_url":"https://api.github.com/repos/sarality/appblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarality/appblocks/downloads","issues_url":"https://api.github.com/repos/sarality/appblocks/issues{/number}","pulls_url":"https://api.github.com/repos/sarality/appblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/sarality/appblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/sarality/appblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarality/appblocks/labels{/name}","releases_url":"https://api.github.com/repos/sarality/appblocks/releases{/id}","created_at":"2014-01-22T10:44:45Z","updated_at":"2014-06-12T07:37:00Z","pushed_at":"2014-06-12T07:35:59Z","git_url":"git://github.com/sarality/appblocks.git","ssh_url":"git@github.com:sarality/appblocks.git","clone_url":"https://github.com/sarality/appblocks.git","svn_url":"https://github.com/sarality/appblocks","homepage":null,"size":2112,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sarality/appblocks/pulls/62"},"html":{"href":"https://github.com/sarality/appblocks/pull/62"},"issue":{"href":"https://api.github.com/repos/sarality/appblocks/issues/62"},"comments":{"href":"https://api.github.com/repos/sarality/appblocks/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/sarality/appblocks/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/sarality/appblocks/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sarality/appblocks/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/sarality/appblocks/statuses/4be2de61f03d979891eeb3a14769f7f6e4d9e8b7"}}}}