GitHub PullRequestEvent at 2014-01-29 15:26:04
Repository: django-oscar
Actor: codeinthehole
Payload: {"action":"opened","number":1161,"pull_request":{"url":"https://api.github.com/repos/tangentlabs/django-oscar/pulls/1161","id":11994900,"html_url":"https://github.com/tangentlabs/django-oscar/pull/1161","diff_url":"https://github.com/tangentlabs/django-oscar/pull/1161.diff","patch_url":"https://github.com/tangentlabs/django-oscar/pull/1161.patch","issue_url":"https://api.github.com/repos/tangentlabs/django-oscar/issues/1161","number":1161,"state":"open","title":"Use a custom get_model that fails noisily","user":{"login":"maikhoepfel","id":509427,"avatar_url":"https://gravatar.com/avatar/9a313a0126d7f38f6e5bf0a337e9fbf4?d=https%3A%2F%2Fidenticons.github.com%2Fd610d91afe1cb0cd8dcaf23b551c8540.png&r=x","gravatar_id":"9a313a0126d7f38f6e5bf0a337e9fbf4","url":"https://api.github.com/users/maikhoepfel","html_url":"https://github.com/maikhoepfel","followers_url":"https://api.github.com/users/maikhoepfel/followers","following_url":"https://api.github.com/users/maikhoepfel/following{/other_user}","gists_url":"https://api.github.com/users/maikhoepfel/gists{/gist_id}","starred_url":"https://api.github.com/users/maikhoepfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maikhoepfel/subscriptions","organizations_url":"https://api.github.com/users/maikhoepfel/orgs","repos_url":"https://api.github.com/users/maikhoepfel/repos","events_url":"https://api.github.com/users/maikhoepfel/events{/privacy}","received_events_url":"https://api.github.com/users/maikhoepfel/received_events","type":"User","site_admin":false},"body":"Django's core `get_model` returns `None` when it can't match a model within `INSTALLED_APPS`.  This has caused a few subtle issues recently.  \r\n\r\nIt's time to wrap `get_model` with a function that raises an exception if the model import fails.  All uses of `get_model` will need to be replaced (I think).","created_at":"2014-01-29T15:26:04Z","updated_at":"2014-01-29T15:26:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":{"url":"https://api.github.com/repos/tangentlabs/django-oscar/milestones/6","labels_url":"https://api.github.com/repos/tangentlabs/django-oscar/milestones/6/labels","id":246360,"number":6,"title":"0.7","description":"0.7 will be a consolidation release where lots of small issues are resolved but we don't introduce major new features.","creator":{"login":"codeinthehole","id":80975,"avatar_url":"https://gravatar.com/avatar/52d39c7b27386ca98bc016119d95b8b8?d=https%3A%2F%2Fidenticons.github.com%2Faad3fa6aeff4c7b21c762ffa85322247.png&r=x","gravatar_id":"52d39c7b27386ca98bc016119d95b8b8","url":"https://api.github.com/users/codeinthehole","html_url":"https://github.com/codeinthehole","followers_url":"https://api.github.com/users/codeinthehole/followers","following_url":"https://api.github.com/users/codeinthehole/following{/other_user}","gists_url":"https://api.github.com/users/codeinthehole/gists{/gist_id}","starred_url":"https://api.github.com/users/codeinthehole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeinthehole/subscriptions","organizations_url":"https://api.github.com/users/codeinthehole/orgs","repos_url":"https://api.github.com/users/codeinthehole/repos","events_url":"https://api.github.com/users/codeinthehole/events{/privacy}","received_events_url":"https://api.github.com/users/codeinthehole/received_events","type":"User","site_admin":false},"open_issues":71,"closed_issues":28,"state":"open","created_at":"2013-01-17T14:47:38Z","updated_at":"2014-01-28T00:14:41Z","due_on":"2014-02-21T08:00:00Z"},"commits_url":"https://api.github.com/repos/tangentlabs/django-oscar/pulls/1161/commits","review_comments_url":"https://api.github.com/repos/tangentlabs/django-oscar/pulls/1161/comments","review_comment_url":"/repos/tangentlabs/django-oscar/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tangentlabs/django-oscar/issues/1161/comments","statuses_url":"https://api.github.com/repos/tangentlabs/django-oscar/statuses/ab4957073e14c4caeb168b22b1856c3c99bd203b","head":{"label":"tangentlabs:fix/getmodel","ref":"fix/getmodel","sha":"ab4957073e14c4caeb168b22b1856c3c99bd203b","user":{"login":"tangentlabs","id":564970,"avatar_url":"https://gravatar.com/avatar/b2e2cdf25b74872bedb5ad1c4223cfa9?d=https%3A%2F%2Fidenticons.github.com%2F78233266afd9300a9de7a1ec31b5fb4a.png&r=x","gravatar_id":"b2e2cdf25b74872bedb5ad1c4223cfa9","url":"https://api.github.com/users/tangentlabs","html_url":"https://github.com/tangentlabs","followers_url":"https://api.github.com/users/tangentlabs/followers","following_url":"https://api.github.com/users/tangentlabs/following{/other_user}","gists_url":"https://api.github.com/users/tangentlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/tangentlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangentlabs/subscriptions","organizations_url":"https://api.github.com/users/tangentlabs/orgs","repos_url":"https://api.github.com/users/tangentlabs/repos","events_url":"https://api.github.com/users/tangentlabs/events{/privacy}","received_events_url":"https://api.github.com/users/tangentlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1151051,"name":"django-oscar","full_name":"tangentlabs/django-oscar","owner":{"login":"tangentlabs","id":564970,"avatar_url":"https://gravatar.com/avatar/b2e2cdf25b74872bedb5ad1c4223cfa9?d=https%3A%2F%2Fidenticons.github.com%2F78233266afd9300a9de7a1ec31b5fb4a.png&r=x","gravatar_id":"b2e2cdf25b74872bedb5ad1c4223cfa9","url":"https://api.github.com/users/tangentlabs","html_url":"https://github.com/tangentlabs","followers_url":"https://api.github.com/users/tangentlabs/followers","following_url":"https://api.github.com/users/tangentlabs/following{/other_user}","gists_url":"https://api.github.com/users/tangentlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/tangentlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangentlabs/subscriptions","organizations_url":"https://api.github.com/users/tangentlabs/orgs","repos_url":"https://api.github.com/users/tangentlabs/repos","events_url":"https://api.github.com/users/tangentlabs/events{/privacy}","received_events_url":"https://api.github.com/users/tangentlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tangentlabs/django-oscar","description":"Domain-driven e-commerce for Django","fork":false,"url":"https://api.github.com/repos/tangentlabs/django-oscar","forks_url":"https://api.github.com/repos/tangentlabs/django-oscar/forks","keys_url":"https://api.github.com/repos/tangentlabs/django-oscar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangentlabs/django-oscar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangentlabs/django-oscar/teams","hooks_url":"https://api.github.com/repos/tangentlabs/django-oscar/hooks","issue_events_url":"https://api.github.com/repos/tangentlabs/django-oscar/issues/events{/number}","events_url":"https://api.github.com/repos/tangentlabs/django-oscar/events","assignees_url":"https://api.github.com/repos/tangentlabs/django-oscar/assignees{/user}","branches_url":"https://api.github.com/repos/tangentlabs/django-oscar/branches{/branch}","tags_url":"https://api.github.com/repos/tangentlabs/django-oscar/tags","blobs_url":"https://api.github.com/repos/tangentlabs/django-oscar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangentlabs/django-oscar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangentlabs/django-oscar/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangentlabs/django-oscar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangentlabs/django-oscar/statuses/{sha}","languages_url":"https://api.github.com/repos/tangentlabs/django-oscar/languages","stargazers_url":"https://api.github.com/repos/tangentlabs/django-oscar/stargazers","contributors_url":"https://api.github.com/repos/tangentlabs/django-oscar/contributors","subscribers_url":"https://api.github.com/repos/tangentlabs/django-oscar/subscribers","subscription_url":"https://api.github.com/repos/tangentlabs/django-oscar/subscription","commits_url":"https://api.github.com/repos/tangentlabs/django-oscar/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangentlabs/django-oscar/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangentlabs/django-oscar/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangentlabs/django-oscar/issues/comments/{number}","contents_url":"https://api.github.com/repos/tangentlabs/django-oscar/contents/{+path}","compare_url":"https://api.github.com/repos/tangentlabs/django-oscar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangentlabs/django-oscar/merges","archive_url":"https://api.github.com/repos/tangentlabs/django-oscar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangentlabs/django-oscar/downloads","issues_url":"https://api.github.com/repos/tangentlabs/django-oscar/issues{/number}","pulls_url":"https://api.github.com/repos/tangentlabs/django-oscar/pulls{/number}","milestones_url":"https://api.github.com/repos/tangentlabs/django-oscar/milestones{/number}","notifications_url":"https://api.github.com/repos/tangentlabs/django-oscar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangentlabs/django-oscar/labels{/name}","releases_url":"https://api.github.com/repos/tangentlabs/django-oscar/releases{/id}","created_at":"2010-12-08T21:30:32Z","updated_at":"2014-01-29T15:25:09Z","pushed_at":"2014-01-29T15:25:09Z","git_url":"git://github.com/tangentlabs/django-oscar.git","ssh_url":"git@github.com:tangentlabs/django-oscar.git","clone_url":"https://github.com/tangentlabs/django-oscar.git","svn_url":"https://github.com/tangentlabs/django-oscar","homepage":"http://oscarcommerce.com","size":88413,"stargazers_count":832,"watchers_count":832,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":315,"mirror_url":null,"open_issues_count":154,"forks":315,"open_issues":154,"watchers":832,"default_branch":"master","master_branch":"master"}},"base":{"label":"tangentlabs:master","ref":"master","sha":"b262e9f0d931e8d8ebda50c71a8f3051c0c0d5fa","user":{"login":"tangentlabs","id":564970,"avatar_url":"https://gravatar.com/avatar/b2e2cdf25b74872bedb5ad1c4223cfa9?d=https%3A%2F%2Fidenticons.github.com%2F78233266afd9300a9de7a1ec31b5fb4a.png&r=x","gravatar_id":"b2e2cdf25b74872bedb5ad1c4223cfa9","url":"https://api.github.com/users/tangentlabs","html_url":"https://github.com/tangentlabs","followers_url":"https://api.github.com/users/tangentlabs/followers","following_url":"https://api.github.com/users/tangentlabs/following{/other_user}","gists_url":"https://api.github.com/users/tangentlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/tangentlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangentlabs/subscriptions","organizations_url":"https://api.github.com/users/tangentlabs/orgs","repos_url":"https://api.github.com/users/tangentlabs/repos","events_url":"https://api.github.com/users/tangentlabs/events{/privacy}","received_events_url":"https://api.github.com/users/tangentlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1151051,"name":"django-oscar","full_name":"tangentlabs/django-oscar","owner":{"login":"tangentlabs","id":564970,"avatar_url":"https://gravatar.com/avatar/b2e2cdf25b74872bedb5ad1c4223cfa9?d=https%3A%2F%2Fidenticons.github.com%2F78233266afd9300a9de7a1ec31b5fb4a.png&r=x","gravatar_id":"b2e2cdf25b74872bedb5ad1c4223cfa9","url":"https://api.github.com/users/tangentlabs","html_url":"https://github.com/tangentlabs","followers_url":"https://api.github.com/users/tangentlabs/followers","following_url":"https://api.github.com/users/tangentlabs/following{/other_user}","gists_url":"https://api.github.com/users/tangentlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/tangentlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangentlabs/subscriptions","organizations_url":"https://api.github.com/users/tangentlabs/orgs","repos_url":"https://api.github.com/users/tangentlabs/repos","events_url":"https://api.github.com/users/tangentlabs/events{/privacy}","received_events_url":"https://api.github.com/users/tangentlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tangentlabs/django-oscar","description":"Domain-driven e-commerce for Django","fork":false,"url":"https://api.github.com/repos/tangentlabs/django-oscar","forks_url":"https://api.github.com/repos/tangentlabs/django-oscar/forks","keys_url":"https://api.github.com/repos/tangentlabs/django-oscar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangentlabs/django-oscar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangentlabs/django-oscar/teams","hooks_url":"https://api.github.com/repos/tangentlabs/django-oscar/hooks","issue_events_url":"https://api.github.com/repos/tangentlabs/django-oscar/issues/events{/number}","events_url":"https://api.github.com/repos/tangentlabs/django-oscar/events","assignees_url":"https://api.github.com/repos/tangentlabs/django-oscar/assignees{/user}","branches_url":"https://api.github.com/repos/tangentlabs/django-oscar/branches{/branch}","tags_url":"https://api.github.com/repos/tangentlabs/django-oscar/tags","blobs_url":"https://api.github.com/repos/tangentlabs/django-oscar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangentlabs/django-oscar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangentlabs/django-oscar/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangentlabs/django-oscar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangentlabs/django-oscar/statuses/{sha}","languages_url":"https://api.github.com/repos/tangentlabs/django-oscar/languages","stargazers_url":"https://api.github.com/repos/tangentlabs/django-oscar/stargazers","contributors_url":"https://api.github.com/repos/tangentlabs/django-oscar/contributors","subscribers_url":"https://api.github.com/repos/tangentlabs/django-oscar/subscribers","subscription_url":"https://api.github.com/repos/tangentlabs/django-oscar/subscription","commits_url":"https://api.github.com/repos/tangentlabs/django-oscar/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangentlabs/django-oscar/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangentlabs/django-oscar/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangentlabs/django-oscar/issues/comments/{number}","contents_url":"https://api.github.com/repos/tangentlabs/django-oscar/contents/{+path}","compare_url":"https://api.github.com/repos/tangentlabs/django-oscar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangentlabs/django-oscar/merges","archive_url":"https://api.github.com/repos/tangentlabs/django-oscar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangentlabs/django-oscar/downloads","issues_url":"https://api.github.com/repos/tangentlabs/django-oscar/issues{/number}","pulls_url":"https://api.github.com/repos/tangentlabs/django-oscar/pulls{/number}","milestones_url":"https://api.github.com/repos/tangentlabs/django-oscar/milestones{/number}","notifications_url":"https://api.github.com/repos/tangentlabs/django-oscar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangentlabs/django-oscar/labels{/name}","releases_url":"https://api.github.com/repos/tangentlabs/django-oscar/releases{/id}","created_at":"2010-12-08T21:30:32Z","updated_at":"2014-01-29T15:25:09Z","pushed_at":"2014-01-29T15:25:09Z","git_url":"git://github.com/tangentlabs/django-oscar.git","ssh_url":"git@github.com:tangentlabs/django-oscar.git","clone_url":"https://github.com/tangentlabs/django-oscar.git","svn_url":"https://github.com/tangentlabs/django-oscar","homepage":"http://oscarcommerce.com","size":88413,"stargazers_count":832,"watchers_count":832,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":315,"mirror_url":null,"open_issues_count":154,"forks":315,"open_issues":154,"watchers":832,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tangentlabs/django-oscar/pulls/1161"},"html":{"href":"https://github.com/tangentlabs/django-oscar/pull/1161"},"issue":{"href":"https://api.github.com/repos/tangentlabs/django-oscar/issues/1161"},"comments":{"href":"https://api.github.com/repos/tangentlabs/django-oscar/issues/1161/comments"},"review_comments":{"href":"https://api.github.com/repos/tangentlabs/django-oscar/pulls/1161/comments"},"commits":{"href":"https://api.github.com/repos/tangentlabs/django-oscar/pulls/1161/commits"},"statuses":{"href":"https://api.github.com/repos/tangentlabs/django-oscar/statuses/ab4957073e14c4caeb168b22b1856c3c99bd203b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":119,"deletions":104,"changed_files":92}}