GitHub PullRequestReviewCommentEvent at 2014-10-02 20:47:16
Repository: edx-ora2
Actor: caesar2164
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls/comments/18366674","id":18366674,"diff_hunk":"@@ -446,25 +446,25 @@ OpenAssessment.ResponseView.prototype = {\n \n     /**\n      When selecting a file for upload, do some quick client-side validation\n-     to ensure that it is an image, and is not larger than the maximum file\n+     to ensure that it is an image or a PDF, and is not larger than the maximum file\n      size.\n \n      Args:\n         files (list): A collection of files used for upload. This function assumes\n             there is only one file being uploaded at any time. This file must\n-            be less than 5 MB and an image.\n+            be less than 5 MB and an image or PDF.\n \n      **/\n     prepareUpload: function(files) {\n         this.files = null;\n-        this.imageType = files[0].type;\n+        this.fileType = files[0].type;\n         if (files[0].size > this.MAX_FILE_SIZE) {\n             this.baseView.toggleActionError(\n                 'upload', gettext(\"File size must be 5MB or less.\")\n             );\n-        } else if (this.imageType.substring(0,6) != 'image/') {\n+        } else if (this.fileType.substring(0,6) != 'image/' && this.fileType !== 'application/pdf') {","path":"openassessment/xblock/static/js/src/lms/oa_response.js","position":24,"original_position":24,"commit_id":"59ef026d9d5cfe65c7eb6f3a711d9b97252849c1","original_commit_id":"59ef026d9d5cfe65c7eb6f3a711d9b97252849c1","user":{"login":"caesar2164","id":3364609,"avatar_url":"https://avatars.githubusercontent.com/u/3364609?v=2","gravatar_id":"","url":"https://api.github.com/users/caesar2164","html_url":"https://github.com/caesar2164","followers_url":"https://api.github.com/users/caesar2164/followers","following_url":"https://api.github.com/users/caesar2164/following{/other_user}","gists_url":"https://api.github.com/users/caesar2164/gists{/gist_id}","starred_url":"https://api.github.com/users/caesar2164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesar2164/subscriptions","organizations_url":"https://api.github.com/users/caesar2164/orgs","repos_url":"https://api.github.com/users/caesar2164/repos","events_url":"https://api.github.com/users/caesar2164/events{/privacy}","received_events_url":"https://api.github.com/users/caesar2164/received_events","type":"User","site_admin":false},"body":"@stvstnfrd - they actually do both. See openassessment/xblock/submission_mixin.py:192","created_at":"2014-10-02T20:47:16Z","updated_at":"2014-10-02T20:47:16Z","html_url":"https://github.com/Stanford-Online/edx-ora2/pull/3#discussion_r18366674","pull_request_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls/comments/18366674"},"html":{"href":"https://github.com/Stanford-Online/edx-ora2/pull/3#discussion_r18366674"},"pull_request":{"href":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls/3","id":22165965,"html_url":"https://github.com/Stanford-Online/edx-ora2/pull/3","diff_url":"https://github.com/Stanford-Online/edx-ora2/pull/3.diff","patch_url":"https://github.com/Stanford-Online/edx-ora2/pull/3.patch","issue_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/issues/3","number":3,"state":"open","locked":false,"title":"Allow PDF uploads in image upload","user":{"login":"caesar2164","id":3364609,"avatar_url":"https://avatars.githubusercontent.com/u/3364609?v=2","gravatar_id":"","url":"https://api.github.com/users/caesar2164","html_url":"https://github.com/caesar2164","followers_url":"https://api.github.com/users/caesar2164/followers","following_url":"https://api.github.com/users/caesar2164/following{/other_user}","gists_url":"https://api.github.com/users/caesar2164/gists{/gist_id}","starred_url":"https://api.github.com/users/caesar2164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesar2164/subscriptions","organizations_url":"https://api.github.com/users/caesar2164/orgs","repos_url":"https://api.github.com/users/caesar2164/repos","events_url":"https://api.github.com/users/caesar2164/events{/privacy}","received_events_url":"https://api.github.com/users/caesar2164/received_events","type":"User","site_admin":false},"body":"@jrbl & @stvstnfrd - Changes to allow PDF uploads using image upload feature.","created_at":"2014-10-02T19:59:25Z","updated_at":"2014-10-02T20:47:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"874720aa60ee19c5dfbf3666781842547bcffcaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/issues/3/comments","statuses_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/statuses/59ef026d9d5cfe65c7eb6f3a711d9b97252849c1","head":{"label":"Stanford-Online:giulio/pdf-upload","ref":"giulio/pdf-upload","sha":"59ef026d9d5cfe65c7eb6f3a711d9b97252849c1","user":{"login":"Stanford-Online","id":2159497,"avatar_url":"https://avatars.githubusercontent.com/u/2159497?v=2","gravatar_id":"","url":"https://api.github.com/users/Stanford-Online","html_url":"https://github.com/Stanford-Online","followers_url":"https://api.github.com/users/Stanford-Online/followers","following_url":"https://api.github.com/users/Stanford-Online/following{/other_user}","gists_url":"https://api.github.com/users/Stanford-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanford-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanford-Online/subscriptions","organizations_url":"https://api.github.com/users/Stanford-Online/orgs","repos_url":"https://api.github.com/users/Stanford-Online/repos","events_url":"https://api.github.com/users/Stanford-Online/events{/privacy}","received_events_url":"https://api.github.com/users/Stanford-Online/received_events","type":"Organization","site_admin":false},"repo":{"id":22652644,"name":"edx-ora2","full_name":"Stanford-Online/edx-ora2","owner":{"login":"Stanford-Online","id":2159497,"avatar_url":"https://avatars.githubusercontent.com/u/2159497?v=2","gravatar_id":"","url":"https://api.github.com/users/Stanford-Online","html_url":"https://github.com/Stanford-Online","followers_url":"https://api.github.com/users/Stanford-Online/followers","following_url":"https://api.github.com/users/Stanford-Online/following{/other_user}","gists_url":"https://api.github.com/users/Stanford-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanford-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanford-Online/subscriptions","organizations_url":"https://api.github.com/users/Stanford-Online/orgs","repos_url":"https://api.github.com/users/Stanford-Online/repos","events_url":"https://api.github.com/users/Stanford-Online/events{/privacy}","received_events_url":"https://api.github.com/users/Stanford-Online/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stanford-Online/edx-ora2","description":"Open Response Assessment Suite","fork":true,"url":"https://api.github.com/repos/Stanford-Online/edx-ora2","forks_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/forks","keys_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/teams","hooks_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/hooks","issue_events_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/issues/events{/number}","events_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/events","assignees_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/assignees{/user}","branches_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/branches{/branch}","tags_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/tags","blobs_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/statuses/{sha}","languages_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/languages","stargazers_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/stargazers","contributors_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/contributors","subscribers_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/subscribers","subscription_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/subscription","commits_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/issues/comments/{number}","contents_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/contents/{+path}","compare_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/merges","archive_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/downloads","issues_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/issues{/number}","pulls_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls{/number}","milestones_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/milestones{/number}","notifications_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/labels{/name}","releases_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/releases{/id}","created_at":"2014-08-05T17:27:33Z","updated_at":"2014-08-21T21:48:14Z","pushed_at":"2014-10-02T19:57:52Z","git_url":"git://github.com/Stanford-Online/edx-ora2.git","ssh_url":"git@github.com:Stanford-Online/edx-ora2.git","clone_url":"https://github.com/Stanford-Online/edx-ora2.git","svn_url":"https://github.com/Stanford-Online/edx-ora2","homepage":"","size":65026,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Stanford-Online:upstream-release-2014-09-18","ref":"upstream-release-2014-09-18","sha":"9e0218e9294b7611b1aaf0368435aa331f13d524","user":{"login":"Stanford-Online","id":2159497,"avatar_url":"https://avatars.githubusercontent.com/u/2159497?v=2","gravatar_id":"","url":"https://api.github.com/users/Stanford-Online","html_url":"https://github.com/Stanford-Online","followers_url":"https://api.github.com/users/Stanford-Online/followers","following_url":"https://api.github.com/users/Stanford-Online/following{/other_user}","gists_url":"https://api.github.com/users/Stanford-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanford-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanford-Online/subscriptions","organizations_url":"https://api.github.com/users/Stanford-Online/orgs","repos_url":"https://api.github.com/users/Stanford-Online/repos","events_url":"https://api.github.com/users/Stanford-Online/events{/privacy}","received_events_url":"https://api.github.com/users/Stanford-Online/received_events","type":"Organization","site_admin":false},"repo":{"id":22652644,"name":"edx-ora2","full_name":"Stanford-Online/edx-ora2","owner":{"login":"Stanford-Online","id":2159497,"avatar_url":"https://avatars.githubusercontent.com/u/2159497?v=2","gravatar_id":"","url":"https://api.github.com/users/Stanford-Online","html_url":"https://github.com/Stanford-Online","followers_url":"https://api.github.com/users/Stanford-Online/followers","following_url":"https://api.github.com/users/Stanford-Online/following{/other_user}","gists_url":"https://api.github.com/users/Stanford-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanford-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanford-Online/subscriptions","organizations_url":"https://api.github.com/users/Stanford-Online/orgs","repos_url":"https://api.github.com/users/Stanford-Online/repos","events_url":"https://api.github.com/users/Stanford-Online/events{/privacy}","received_events_url":"https://api.github.com/users/Stanford-Online/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stanford-Online/edx-ora2","description":"Open Response Assessment Suite","fork":true,"url":"https://api.github.com/repos/Stanford-Online/edx-ora2","forks_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/forks","keys_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/teams","hooks_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/hooks","issue_events_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/issues/events{/number}","events_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/events","assignees_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/assignees{/user}","branches_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/branches{/branch}","tags_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/tags","blobs_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/statuses/{sha}","languages_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/languages","stargazers_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/stargazers","contributors_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/contributors","subscribers_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/subscribers","subscription_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/subscription","commits_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/issues/comments/{number}","contents_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/contents/{+path}","compare_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/merges","archive_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/downloads","issues_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/issues{/number}","pulls_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls{/number}","milestones_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/milestones{/number}","notifications_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/labels{/name}","releases_url":"https://api.github.com/repos/Stanford-Online/edx-ora2/releases{/id}","created_at":"2014-08-05T17:27:33Z","updated_at":"2014-08-21T21:48:14Z","pushed_at":"2014-10-02T19:57:52Z","git_url":"git://github.com/Stanford-Online/edx-ora2.git","ssh_url":"git@github.com:Stanford-Online/edx-ora2.git","clone_url":"https://github.com/Stanford-Online/edx-ora2.git","svn_url":"https://github.com/Stanford-Online/edx-ora2","homepage":"","size":65026,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls/3"},"html":{"href":"https://github.com/Stanford-Online/edx-ora2/pull/3"},"issue":{"href":"https://api.github.com/repos/Stanford-Online/edx-ora2/issues/3"},"comments":{"href":"https://api.github.com/repos/Stanford-Online/edx-ora2/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Stanford-Online/edx-ora2/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Stanford-Online/edx-ora2/statuses/59ef026d9d5cfe65c7eb6f3a711d9b97252849c1"}}}}