GitHub PullRequestReviewCommentEvent at 2014-05-29 02:40:28
Repository: backdrop
Actor: jenlampton
Payload: {"comment":{"url":"https://api.github.com/repos/backdrop/backdrop/pulls/comments/13166774","id":13166774,"diff_hunk":"@@ -5174,6 +5174,11 @@ function drupal_page_set_cache() {\n       }\n     }\n \n+    if (variable_get('maintenance_mode', 0)) {\n+      // Cache maintenance pages for 10 seconds.\n+      $cache->expire = time() + 10;","path":"core/includes/common.inc","position":6,"original_position":6,"commit_id":"2ad90e9f94506d0a08320b24a7f4534a62722a2e","original_commit_id":"2ad90e9f94506d0a08320b24a7f4534a62722a2e","user":{"login":"jenlampton","id":397895,"avatar_url":"https://avatars.githubusercontent.com/u/397895?","gravatar_id":"0b3ef5635a7ccca8f7e585572130017b","url":"https://api.github.com/users/jenlampton","html_url":"https://github.com/jenlampton","followers_url":"https://api.github.com/users/jenlampton/followers","following_url":"https://api.github.com/users/jenlampton/following{/other_user}","gists_url":"https://api.github.com/users/jenlampton/gists{/gist_id}","starred_url":"https://api.github.com/users/jenlampton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenlampton/subscriptions","organizations_url":"https://api.github.com/users/jenlampton/orgs","repos_url":"https://api.github.com/users/jenlampton/repos","events_url":"https://api.github.com/users/jenlampton/events{/privacy}","received_events_url":"https://api.github.com/users/jenlampton/received_events","type":"User","site_admin":false},"body":"can we add a check for\r\n\r\n    $lifetime = variable_get('maintenance_page_lifetime', 10);\r\n    $cache->expire = time() + $lifetime;\r\n","created_at":"2014-05-29T02:40:28Z","updated_at":"2014-05-29T02:40:28Z","html_url":"https://github.com/backdrop/backdrop/pull/61#discussion_r13166774","pull_request_url":"https://api.github.com/repos/backdrop/backdrop/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/backdrop/backdrop/pulls/comments/13166774"},"html":{"href":"https://github.com/backdrop/backdrop/pull/61#discussion_r13166774"},"pull_request":{"href":"https://api.github.com/repos/backdrop/backdrop/pulls/61"}}}}