GitHub PullRequestReviewCommentEvent at 2014-10-25 14:17:24
Repository: MINGW-packages
Actor: alex85k
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls/comments/19375638","id":19375638,"diff_hunk":"@@ -16,6 +16,11 @@ options=(strip)\n source=(\"http://www.gaia-gis.it/gaia-sins/freexl-$pkgver.tar.gz\")\n sha256sums=('cf2b110f5fc7089fa61c7421f59caa4125b13087b4686ed82dba7abedf2ec266')\n \n+prepare() {\n+  cd \"${srcdir}/freexl-${pkgver}\"\n+  sed -i freexl.pc.in -e \"s|-lfreexl -lm|-lfreexl -liconv -lm|g\"","path":"mingw-w64-libfreexl/PKGBUILD","position":15,"original_position":15,"commit_id":"62cd1289cc66b75c7ce2547fc6a4476884e5baf9","original_commit_id":"62cd1289cc66b75c7ce2547fc6a4476884e5baf9","user":{"login":"alex85k","id":4124648,"avatar_url":"https://avatars.githubusercontent.com/u/4124648?v=2","gravatar_id":"","url":"https://api.github.com/users/alex85k","html_url":"https://github.com/alex85k","followers_url":"https://api.github.com/users/alex85k/followers","following_url":"https://api.github.com/users/alex85k/following{/other_user}","gists_url":"https://api.github.com/users/alex85k/gists{/gist_id}","starred_url":"https://api.github.com/users/alex85k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex85k/subscriptions","organizations_url":"https://api.github.com/users/alex85k/orgs","repos_url":"https://api.github.com/users/alex85k/repos","events_url":"https://api.github.com/users/alex85k/events{/privacy}","received_events_url":"https://api.github.com/users/alex85k/received_events","type":"User","site_admin":false},"body":"freexl.a contained calls to iconv functions but no -liconv was in pkg-config descriptor freexl.pc\r\nIs this sed-patching normal or the .patch file is needed?","created_at":"2014-10-25T14:17:24Z","updated_at":"2014-10-25T14:17:24Z","html_url":"https://github.com/Alexpux/MINGW-packages/pull/302#discussion_r19375638","pull_request_url":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls/302","_links":{"self":{"href":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls/comments/19375638"},"html":{"href":"https://github.com/Alexpux/MINGW-packages/pull/302#discussion_r19375638"},"pull_request":{"href":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls/302","id":23339542,"html_url":"https://github.com/Alexpux/MINGW-packages/pull/302","diff_url":"https://github.com/Alexpux/MINGW-packages/pull/302.diff","patch_url":"https://github.com/Alexpux/MINGW-packages/pull/302.patch","issue_url":"https://api.github.com/repos/Alexpux/MINGW-packages/issues/302","number":302,"state":"open","locked":false,"title":"new packages: libspatialite 4.2.0, spatialite-tools, fix libfreexl pkg-config","user":{"login":"alex85k","id":4124648,"avatar_url":"https://avatars.githubusercontent.com/u/4124648?v=2","gravatar_id":"","url":"https://api.github.com/users/alex85k","html_url":"https://github.com/alex85k","followers_url":"https://api.github.com/users/alex85k/followers","following_url":"https://api.github.com/users/alex85k/following{/other_user}","gists_url":"https://api.github.com/users/alex85k/gists{/gist_id}","starred_url":"https://api.github.com/users/alex85k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex85k/subscriptions","organizations_url":"https://api.github.com/users/alex85k/orgs","repos_url":"https://api.github.com/users/alex85k/repos","events_url":"https://api.github.com/users/alex85k/events{/privacy}","received_events_url":"https://api.github.com/users/alex85k/received_events","type":"User","site_admin":false},"body":"I have managed to compile spatialite executables (spatial-extended sqlite), but some patching was done.\r\nCould you have a look? (I'll comment the problematic places of code)","created_at":"2014-10-25T14:15:49Z","updated_at":"2014-10-25T14:17:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e9f41b33087550a5137e4a35666292991709401","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls/302/commits","review_comments_url":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls/302/comments","review_comment_url":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Alexpux/MINGW-packages/issues/302/comments","statuses_url":"https://api.github.com/repos/Alexpux/MINGW-packages/statuses/62cd1289cc66b75c7ce2547fc6a4476884e5baf9","head":{"label":"alex85k:libspatialite","ref":"libspatialite","sha":"62cd1289cc66b75c7ce2547fc6a4476884e5baf9","user":{"login":"alex85k","id":4124648,"avatar_url":"https://avatars.githubusercontent.com/u/4124648?v=2","gravatar_id":"","url":"https://api.github.com/users/alex85k","html_url":"https://github.com/alex85k","followers_url":"https://api.github.com/users/alex85k/followers","following_url":"https://api.github.com/users/alex85k/following{/other_user}","gists_url":"https://api.github.com/users/alex85k/gists{/gist_id}","starred_url":"https://api.github.com/users/alex85k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex85k/subscriptions","organizations_url":"https://api.github.com/users/alex85k/orgs","repos_url":"https://api.github.com/users/alex85k/repos","events_url":"https://api.github.com/users/alex85k/events{/privacy}","received_events_url":"https://api.github.com/users/alex85k/received_events","type":"User","site_admin":false},"repo":{"id":25534550,"name":"MINGW-packages","full_name":"alex85k/MINGW-packages","owner":{"login":"alex85k","id":4124648,"avatar_url":"https://avatars.githubusercontent.com/u/4124648?v=2","gravatar_id":"","url":"https://api.github.com/users/alex85k","html_url":"https://github.com/alex85k","followers_url":"https://api.github.com/users/alex85k/followers","following_url":"https://api.github.com/users/alex85k/following{/other_user}","gists_url":"https://api.github.com/users/alex85k/gists{/gist_id}","starred_url":"https://api.github.com/users/alex85k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex85k/subscriptions","organizations_url":"https://api.github.com/users/alex85k/orgs","repos_url":"https://api.github.com/users/alex85k/repos","events_url":"https://api.github.com/users/alex85k/events{/privacy}","received_events_url":"https://api.github.com/users/alex85k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alex85k/MINGW-packages","description":"Package scripts for MinGW-w64 targets to build under MSYS2.","fork":true,"url":"https://api.github.com/repos/alex85k/MINGW-packages","forks_url":"https://api.github.com/repos/alex85k/MINGW-packages/forks","keys_url":"https://api.github.com/repos/alex85k/MINGW-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alex85k/MINGW-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alex85k/MINGW-packages/teams","hooks_url":"https://api.github.com/repos/alex85k/MINGW-packages/hooks","issue_events_url":"https://api.github.com/repos/alex85k/MINGW-packages/issues/events{/number}","events_url":"https://api.github.com/repos/alex85k/MINGW-packages/events","assignees_url":"https://api.github.com/repos/alex85k/MINGW-packages/assignees{/user}","branches_url":"https://api.github.com/repos/alex85k/MINGW-packages/branches{/branch}","tags_url":"https://api.github.com/repos/alex85k/MINGW-packages/tags","blobs_url":"https://api.github.com/repos/alex85k/MINGW-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alex85k/MINGW-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alex85k/MINGW-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/alex85k/MINGW-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alex85k/MINGW-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/alex85k/MINGW-packages/languages","stargazers_url":"https://api.github.com/repos/alex85k/MINGW-packages/stargazers","contributors_url":"https://api.github.com/repos/alex85k/MINGW-packages/contributors","subscribers_url":"https://api.github.com/repos/alex85k/MINGW-packages/subscribers","subscription_url":"https://api.github.com/repos/alex85k/MINGW-packages/subscription","commits_url":"https://api.github.com/repos/alex85k/MINGW-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/alex85k/MINGW-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/alex85k/MINGW-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/alex85k/MINGW-packages/issues/comments/{number}","contents_url":"https://api.github.com/repos/alex85k/MINGW-packages/contents/{+path}","compare_url":"https://api.github.com/repos/alex85k/MINGW-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alex85k/MINGW-packages/merges","archive_url":"https://api.github.com/repos/alex85k/MINGW-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alex85k/MINGW-packages/downloads","issues_url":"https://api.github.com/repos/alex85k/MINGW-packages/issues{/number}","pulls_url":"https://api.github.com/repos/alex85k/MINGW-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/alex85k/MINGW-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/alex85k/MINGW-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alex85k/MINGW-packages/labels{/name}","releases_url":"https://api.github.com/repos/alex85k/MINGW-packages/releases{/id}","created_at":"2014-10-21T16:59:38Z","updated_at":"2014-10-20T23:27:06Z","pushed_at":"2014-10-25T14:12:55Z","git_url":"git://github.com/alex85k/MINGW-packages.git","ssh_url":"git@github.com:alex85k/MINGW-packages.git","clone_url":"https://github.com/alex85k/MINGW-packages.git","svn_url":"https://github.com/alex85k/MINGW-packages","homepage":null,"size":7795,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alexpux:master","ref":"master","sha":"3a04036ae18cc49a40deb182a405f4924369f0e4","user":{"login":"Alexpux","id":1898153,"avatar_url":"https://avatars.githubusercontent.com/u/1898153?v=2","gravatar_id":"","url":"https://api.github.com/users/Alexpux","html_url":"https://github.com/Alexpux","followers_url":"https://api.github.com/users/Alexpux/followers","following_url":"https://api.github.com/users/Alexpux/following{/other_user}","gists_url":"https://api.github.com/users/Alexpux/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexpux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexpux/subscriptions","organizations_url":"https://api.github.com/users/Alexpux/orgs","repos_url":"https://api.github.com/users/Alexpux/repos","events_url":"https://api.github.com/users/Alexpux/events{/privacy}","received_events_url":"https://api.github.com/users/Alexpux/received_events","type":"User","site_admin":false},"repo":{"id":14447732,"name":"MINGW-packages","full_name":"Alexpux/MINGW-packages","owner":{"login":"Alexpux","id":1898153,"avatar_url":"https://avatars.githubusercontent.com/u/1898153?v=2","gravatar_id":"","url":"https://api.github.com/users/Alexpux","html_url":"https://github.com/Alexpux","followers_url":"https://api.github.com/users/Alexpux/followers","following_url":"https://api.github.com/users/Alexpux/following{/other_user}","gists_url":"https://api.github.com/users/Alexpux/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexpux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexpux/subscriptions","organizations_url":"https://api.github.com/users/Alexpux/orgs","repos_url":"https://api.github.com/users/Alexpux/repos","events_url":"https://api.github.com/users/Alexpux/events{/privacy}","received_events_url":"https://api.github.com/users/Alexpux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Alexpux/MINGW-packages","description":"Package scripts for MinGW-w64 targets to build under MSYS2.","fork":false,"url":"https://api.github.com/repos/Alexpux/MINGW-packages","forks_url":"https://api.github.com/repos/Alexpux/MINGW-packages/forks","keys_url":"https://api.github.com/repos/Alexpux/MINGW-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alexpux/MINGW-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alexpux/MINGW-packages/teams","hooks_url":"https://api.github.com/repos/Alexpux/MINGW-packages/hooks","issue_events_url":"https://api.github.com/repos/Alexpux/MINGW-packages/issues/events{/number}","events_url":"https://api.github.com/repos/Alexpux/MINGW-packages/events","assignees_url":"https://api.github.com/repos/Alexpux/MINGW-packages/assignees{/user}","branches_url":"https://api.github.com/repos/Alexpux/MINGW-packages/branches{/branch}","tags_url":"https://api.github.com/repos/Alexpux/MINGW-packages/tags","blobs_url":"https://api.github.com/repos/Alexpux/MINGW-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alexpux/MINGW-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alexpux/MINGW-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alexpux/MINGW-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alexpux/MINGW-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/Alexpux/MINGW-packages/languages","stargazers_url":"https://api.github.com/repos/Alexpux/MINGW-packages/stargazers","contributors_url":"https://api.github.com/repos/Alexpux/MINGW-packages/contributors","subscribers_url":"https://api.github.com/repos/Alexpux/MINGW-packages/subscribers","subscription_url":"https://api.github.com/repos/Alexpux/MINGW-packages/subscription","commits_url":"https://api.github.com/repos/Alexpux/MINGW-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alexpux/MINGW-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alexpux/MINGW-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alexpux/MINGW-packages/issues/comments/{number}","contents_url":"https://api.github.com/repos/Alexpux/MINGW-packages/contents/{+path}","compare_url":"https://api.github.com/repos/Alexpux/MINGW-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alexpux/MINGW-packages/merges","archive_url":"https://api.github.com/repos/Alexpux/MINGW-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alexpux/MINGW-packages/downloads","issues_url":"https://api.github.com/repos/Alexpux/MINGW-packages/issues{/number}","pulls_url":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/Alexpux/MINGW-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/Alexpux/MINGW-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alexpux/MINGW-packages/labels{/name}","releases_url":"https://api.github.com/repos/Alexpux/MINGW-packages/releases{/id}","created_at":"2013-11-16T13:47:02Z","updated_at":"2014-10-20T23:27:06Z","pushed_at":"2014-10-25T12:41:46Z","git_url":"git://github.com/Alexpux/MINGW-packages.git","ssh_url":"git@github.com:Alexpux/MINGW-packages.git","clone_url":"https://github.com/Alexpux/MINGW-packages.git","svn_url":"https://github.com/Alexpux/MINGW-packages","homepage":null,"size":20232,"stargazers_count":101,"watchers_count":101,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":43,"forks":47,"open_issues":43,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls/302"},"html":{"href":"https://github.com/Alexpux/MINGW-packages/pull/302"},"issue":{"href":"https://api.github.com/repos/Alexpux/MINGW-packages/issues/302"},"comments":{"href":"https://api.github.com/repos/Alexpux/MINGW-packages/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Alexpux/MINGW-packages/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/Alexpux/MINGW-packages/statuses/62cd1289cc66b75c7ce2547fc6a4476884e5baf9"}}}}