GitHub PullRequestReviewCommentEvent at 2014-11-10 14:17:32
Repository: OpenMOC
Actor: samuelshaner
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/20083486","id":20083486,"diff_hunk":"@@ -1532,7 +1537,7 @@ std::vector<int> Geometry::getFSRsToMaterialIDs() {\n  * @brief Sets the _FSR_keys_map map\n  * @param FSR_keys_map map of FSR keys to FSR IDs\n  */\n-void Geometry::setFSRKeysMap(std::map<std::size_t, fsr_data> FSR_keys_map){\n+void Geometry::setFSRKeysMap(std::unordered_map<std::size_t, fsr_data> FSR_keys_map){","path":"src/Geometry.cpp","position":46,"original_position":46,"commit_id":"dbbe06ba3e7a460be0a600aa0370fd3308106ffa","original_commit_id":"dbbe06ba3e7a460be0a600aa0370fd3308106ffa","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"I added this for the `@details`: The _FSR_keys_map stores a hash of a std::string representing the Lattice/Cell/Universe hierarchy for a unique region and the associated FSR data. fsr_data is a struct that contains a unique FSR id and a Point located in the highest level Universe that is contained in the FSR. This method is used when the tracks are read from file to avoid unnecessary segmentation. \r\n\r\nIt is a public class method since it needs to be called in `TrackGenerator`.","created_at":"2014-11-10T14:17:32Z","updated_at":"2014-11-10T14:17:32Z","html_url":"https://github.com/mit-crpg/OpenMOC/pull/111#discussion_r20083486","pull_request_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/20083486"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/111#discussion_r20083486"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/111","id":24053428,"html_url":"https://github.com/mit-crpg/OpenMOC/pull/111","diff_url":"https://github.com/mit-crpg/OpenMOC/pull/111.diff","patch_url":"https://github.com/mit-crpg/OpenMOC/pull/111.patch","issue_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/111","number":111,"state":"open","locked":false,"title":"Fixed error in CMFD computeDs and increased segmentation performance","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"- Fixed error in CMFD computeDs method.\r\n- Changed convergence to be based on FSR energy-integrated fission source.\r\n- Increased segmentation performance by looping on over the surfaces in the current cell (instead of all surfaces for all cells in the current universe) to check for next surface crossing.\r\n- Changed FSR keys map from `map` to `unordered_map`. The `unordered_map` scales as O(1) whereas `map` scales as O(log(n)) so the `unordered_map` is needed for large problems. ","created_at":"2014-11-07T13:44:09Z","updated_at":"2014-11-10T14:17:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c4a1addb93106ff5787c1123772d33670258f8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/111/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/111/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/111/comments","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/dbbe06ba3e7a460be0a600aa0370fd3308106ffa","head":{"label":"samuelshaner:develop","ref":"develop","sha":"dbbe06ba3e7a460be0a600aa0370fd3308106ffa","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"repo":{"id":17918430,"name":"OpenMOC","full_name":"samuelshaner/OpenMOC","owner":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuelshaner/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":true,"url":"https://api.github.com/repos/samuelshaner/OpenMOC","forks_url":"https://api.github.com/repos/samuelshaner/OpenMOC/forks","keys_url":"https://api.github.com/repos/samuelshaner/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuelshaner/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuelshaner/OpenMOC/teams","hooks_url":"https://api.github.com/repos/samuelshaner/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/samuelshaner/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/samuelshaner/OpenMOC/events","assignees_url":"https://api.github.com/repos/samuelshaner/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/samuelshaner/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/samuelshaner/OpenMOC/tags","blobs_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuelshaner/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/samuelshaner/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/samuelshaner/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/samuelshaner/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/samuelshaner/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/samuelshaner/OpenMOC/subscription","commits_url":"https://api.github.com/repos/samuelshaner/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuelshaner/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuelshaner/OpenMOC/issues/comments/{number}","contents_url":"https://api.github.com/repos/samuelshaner/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/samuelshaner/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuelshaner/OpenMOC/merges","archive_url":"https://api.github.com/repos/samuelshaner/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuelshaner/OpenMOC/downloads","issues_url":"https://api.github.com/repos/samuelshaner/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/samuelshaner/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/samuelshaner/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/samuelshaner/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuelshaner/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/samuelshaner/OpenMOC/releases{/id}","created_at":"2014-03-19T20:03:02Z","updated_at":"2014-03-19T20:03:02Z","pushed_at":"2014-11-07T13:39:45Z","git_url":"git://github.com/samuelshaner/OpenMOC.git","ssh_url":"git@github.com:samuelshaner/OpenMOC.git","clone_url":"https://github.com/samuelshaner/OpenMOC.git","svn_url":"https://github.com/samuelshaner/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":72392,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"6740613765a448f41e7a105a1a593491c4385c0a","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":8780988,"name":"OpenMOC","full_name":"mit-crpg/OpenMOC","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":false,"url":"https://api.github.com/repos/mit-crpg/OpenMOC","forks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/forks","keys_url":"https://api.github.com/repos/mit-crpg/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/OpenMOC/teams","hooks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/events","assignees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/tags","blobs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscription","commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/comments/{number}","contents_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/OpenMOC/merges","archive_url":"https://api.github.com/repos/mit-crpg/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/OpenMOC/downloads","issues_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/OpenMOC/releases{/id}","created_at":"2013-03-14T17:19:26Z","updated_at":"2014-10-24T23:03:03Z","pushed_at":"2014-11-05T02:18:10Z","git_url":"git://github.com/mit-crpg/OpenMOC.git","ssh_url":"git@github.com:mit-crpg/OpenMOC.git","clone_url":"https://github.com/mit-crpg/OpenMOC.git","svn_url":"https://github.com/mit-crpg/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":82133,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":25,"forks":15,"open_issues":25,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/111"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/111"},"issue":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/111"},"comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/dbbe06ba3e7a460be0a600aa0370fd3308106ffa"}}}}