GitHub PullRequestReviewCommentEvent at 2014-07-06 11:45:03
Repository: symfony
Actor: romainneutron
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/14574864","id":14574864,"diff_hunk":"@@ -256,7 +256,7 @@ public function getProcess()\n         $options = $this->options;\n \n         $arguments = array_merge($this->prefix, $this->arguments);\n-        $script = implode(' ', array_map(array(__NAMESPACE__.'\\\\ProcessUtils', 'escapeArgument'), $arguments));\n+        $script = $arguments[0].implode(' ', array_map(array(__NAMESPACE__.'\\\\ProcessUtils', 'escapeArgument'), array_slice($arguments, 1)));","path":"src/Symfony/Component/Process/ProcessBuilder.php","position":5,"original_position":5,"commit_id":"a6ff7e4ab9e0a53cc162d39014c044eb39ac49c3","original_commit_id":"a6ff7e4ab9e0a53cc162d39014c044eb39ac49c3","user":{"login":"romainneutron","id":137574,"avatar_url":"https://avatars.githubusercontent.com/u/137574?","gravatar_id":"ce776a5e957c937a56c721b7d6701960","url":"https://api.github.com/users/romainneutron","html_url":"https://github.com/romainneutron","followers_url":"https://api.github.com/users/romainneutron/followers","following_url":"https://api.github.com/users/romainneutron/following{/other_user}","gists_url":"https://api.github.com/users/romainneutron/gists{/gist_id}","starred_url":"https://api.github.com/users/romainneutron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romainneutron/subscriptions","organizations_url":"https://api.github.com/users/romainneutron/orgs","repos_url":"https://api.github.com/users/romainneutron/repos","events_url":"https://api.github.com/users/romainneutron/events{/privacy}","received_events_url":"https://api.github.com/users/romainneutron/received_events","type":"User","site_admin":false},"body":"That would be indeed a nice feature. Please open a new PR for this feature as it would be easier to review this new feature in a separate thread","created_at":"2014-07-06T11:45:03Z","updated_at":"2014-07-06T11:45:03Z","html_url":"https://github.com/symfony/symfony/pull/11311#discussion_r14574864","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/11311","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/14574864"},"html":{"href":"https://github.com/symfony/symfony/pull/11311#discussion_r14574864"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11311"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/11311","id":18009457,"html_url":"https://github.com/symfony/symfony/pull/11311","diff_url":"https://github.com/symfony/symfony/pull/11311.diff","patch_url":"https://github.com/symfony/symfony/pull/11311.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/11311","number":11311,"state":"open","title":"[FrameworkBundle] Additional helper commands to control PHP's built-in web server","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?","gravatar_id":"b5fe043ff5cd47b3b35d95e78fce5539","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #10827\r\n| License       | MIT\r\n| Doc PR        | \r\n\r\nBasically, both the ``server:status`` and ``server:stop`` wouldn't be really reliable if you had stopped the web server by, for example, killing the process. But honestly I don't know how to platform-independently determine if a process is still running given its PID. Maybe such a way could be a good improvement for the Process component.","created_at":"2014-07-05T11:01:42Z","updated_at":"2014-07-06T11:45:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e79454e2aa37b7dde912223cacf7a8968b4e9f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/11311/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/11311/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/11311/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/a6ff7e4ab9e0a53cc162d39014c044eb39ac49c3","head":{"label":"xabbuh:issue-10827","ref":"issue-10827","sha":"a6ff7e4ab9e0a53cc162d39014c044eb39ac49c3","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?","gravatar_id":"b5fe043ff5cd47b3b35d95e78fce5539","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"repo":{"id":9551743,"name":"symfony","full_name":"xabbuh/symfony","owner":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?","gravatar_id":"b5fe043ff5cd47b3b35d95e78fce5539","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xabbuh/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/xabbuh/symfony","forks_url":"https://api.github.com/repos/xabbuh/symfony/forks","keys_url":"https://api.github.com/repos/xabbuh/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xabbuh/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xabbuh/symfony/teams","hooks_url":"https://api.github.com/repos/xabbuh/symfony/hooks","issue_events_url":"https://api.github.com/repos/xabbuh/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/xabbuh/symfony/events","assignees_url":"https://api.github.com/repos/xabbuh/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/xabbuh/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/xabbuh/symfony/tags","blobs_url":"https://api.github.com/repos/xabbuh/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xabbuh/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xabbuh/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/xabbuh/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xabbuh/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/xabbuh/symfony/languages","stargazers_url":"https://api.github.com/repos/xabbuh/symfony/stargazers","contributors_url":"https://api.github.com/repos/xabbuh/symfony/contributors","subscribers_url":"https://api.github.com/repos/xabbuh/symfony/subscribers","subscription_url":"https://api.github.com/repos/xabbuh/symfony/subscription","commits_url":"https://api.github.com/repos/xabbuh/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/xabbuh/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/xabbuh/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/xabbuh/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/xabbuh/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/xabbuh/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xabbuh/symfony/merges","archive_url":"https://api.github.com/repos/xabbuh/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xabbuh/symfony/downloads","issues_url":"https://api.github.com/repos/xabbuh/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/xabbuh/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/xabbuh/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/xabbuh/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xabbuh/symfony/labels{/name}","releases_url":"https://api.github.com/repos/xabbuh/symfony/releases{/id}","created_at":"2013-04-19T18:23:15Z","updated_at":"2014-07-05T08:26:55Z","pushed_at":"2014-07-05T13:36:21Z","git_url":"git://github.com/xabbuh/symfony.git","ssh_url":"git@github.com:xabbuh/symfony.git","clone_url":"https://github.com/xabbuh/symfony.git","svn_url":"https://github.com/xabbuh/symfony","homepage":"symfony.com","size":39868,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"8b54211471c815337d4b2ac67963de09779407a6","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2014-07-06T10:40:16Z","pushed_at":"2014-07-04T06:17:54Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":155470,"stargazers_count":8560,"watchers_count":8560,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":3287,"mirror_url":null,"open_issues_count":800,"forks":3287,"open_issues":800,"watchers":8560,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11311"},"html":{"href":"https://github.com/symfony/symfony/pull/11311"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/11311"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/11311/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11311/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11311/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/a6ff7e4ab9e0a53cc162d39014c044eb39ac49c3"}}}}