GitHub PullRequestEvent at 2014-05-17 10:01:44
Repository: thorax
Actor: kpdecker
Payload: {"action":"closed","number":370,"pull_request":{"url":"https://api.github.com/repos/walmartlabs/thorax/pulls/370","id":15943994,"html_url":"https://github.com/walmartlabs/thorax/pull/370","diff_url":"https://github.com/walmartlabs/thorax/pull/370.diff","patch_url":"https://github.com/walmartlabs/thorax/pull/370.patch","issue_url":"https://api.github.com/repos/walmartlabs/thorax/issues/370","number":370,"state":"closed","title":"Always cleanup bindToRoute","user":{"login":"kpdecker","id":196390,"avatar_url":"https://avatars.githubusercontent.com/u/196390?","gravatar_id":"1d0a77e7fa25279e2ec61a6f802b2862","url":"https://api.github.com/users/kpdecker","html_url":"https://github.com/kpdecker","followers_url":"https://api.github.com/users/kpdecker/followers","following_url":"https://api.github.com/users/kpdecker/following{/other_user}","gists_url":"https://api.github.com/users/kpdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/kpdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpdecker/subscriptions","organizations_url":"https://api.github.com/users/kpdecker/orgs","repos_url":"https://api.github.com/users/kpdecker/repos","events_url":"https://api.github.com/users/kpdecker/events{/privacy}","received_events_url":"https://api.github.com/users/kpdecker/received_events","type":"User","site_admin":false},"body":"If someone is explicitly calling `Backbone.history.loadUrl` on the same\nroute then the bindToRoute logic will leak as the event handler is never\ncleaned.\n\nSince this is something that presumably is relatively rare and backbone\nitself does some cleanup and routing events in response to this,\nrestructuring the bindToRoute handle so that it will terminate the bound\nevents in response to any route event.\n\n/cc @eastridge @ryan-roemer @candid","created_at":"2014-05-15T16:30:43Z","updated_at":"2014-05-17T10:01:44Z","closed_at":"2014-05-17T10:01:44Z","merged_at":"2014-05-17T10:01:44Z","merge_commit_sha":"6d98763d06784d94b90cd8b82a0f193c252c0084","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/walmartlabs/thorax/pulls/370/commits","review_comments_url":"https://api.github.com/repos/walmartlabs/thorax/pulls/370/comments","review_comment_url":"https://api.github.com/repos/walmartlabs/thorax/pulls/comments/{number}","comments_url":"https://api.github.com/repos/walmartlabs/thorax/issues/370/comments","statuses_url":"https://api.github.com/repos/walmartlabs/thorax/statuses/d519e8d72636ce775b8383c9167adf8f380e986b","head":{"label":"walmartlabs:bind-to-route-leak","ref":"bind-to-route-leak","sha":"d519e8d72636ce775b8383c9167adf8f380e986b","user":{"login":"walmartlabs","id":768298,"avatar_url":"https://avatars.githubusercontent.com/u/768298?","gravatar_id":"fc99ca7b0cb55469b4ca83a1d7790958","url":"https://api.github.com/users/walmartlabs","html_url":"https://github.com/walmartlabs","followers_url":"https://api.github.com/users/walmartlabs/followers","following_url":"https://api.github.com/users/walmartlabs/following{/other_user}","gists_url":"https://api.github.com/users/walmartlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/walmartlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walmartlabs/subscriptions","organizations_url":"https://api.github.com/users/walmartlabs/orgs","repos_url":"https://api.github.com/users/walmartlabs/repos","events_url":"https://api.github.com/users/walmartlabs/events{/privacy}","received_events_url":"https://api.github.com/users/walmartlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2522940,"name":"thorax","full_name":"walmartlabs/thorax","owner":{"login":"walmartlabs","id":768298,"avatar_url":"https://avatars.githubusercontent.com/u/768298?","gravatar_id":"fc99ca7b0cb55469b4ca83a1d7790958","url":"https://api.github.com/users/walmartlabs","html_url":"https://github.com/walmartlabs","followers_url":"https://api.github.com/users/walmartlabs/followers","following_url":"https://api.github.com/users/walmartlabs/following{/other_user}","gists_url":"https://api.github.com/users/walmartlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/walmartlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walmartlabs/subscriptions","organizations_url":"https://api.github.com/users/walmartlabs/orgs","repos_url":"https://api.github.com/users/walmartlabs/repos","events_url":"https://api.github.com/users/walmartlabs/events{/privacy}","received_events_url":"https://api.github.com/users/walmartlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/walmartlabs/thorax","description":"Strengthening your Backbone","fork":false,"url":"https://api.github.com/repos/walmartlabs/thorax","forks_url":"https://api.github.com/repos/walmartlabs/thorax/forks","keys_url":"https://api.github.com/repos/walmartlabs/thorax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/walmartlabs/thorax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/walmartlabs/thorax/teams","hooks_url":"https://api.github.com/repos/walmartlabs/thorax/hooks","issue_events_url":"https://api.github.com/repos/walmartlabs/thorax/issues/events{/number}","events_url":"https://api.github.com/repos/walmartlabs/thorax/events","assignees_url":"https://api.github.com/repos/walmartlabs/thorax/assignees{/user}","branches_url":"https://api.github.com/repos/walmartlabs/thorax/branches{/branch}","tags_url":"https://api.github.com/repos/walmartlabs/thorax/tags","blobs_url":"https://api.github.com/repos/walmartlabs/thorax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/walmartlabs/thorax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/walmartlabs/thorax/git/refs{/sha}","trees_url":"https://api.github.com/repos/walmartlabs/thorax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/walmartlabs/thorax/statuses/{sha}","languages_url":"https://api.github.com/repos/walmartlabs/thorax/languages","stargazers_url":"https://api.github.com/repos/walmartlabs/thorax/stargazers","contributors_url":"https://api.github.com/repos/walmartlabs/thorax/contributors","subscribers_url":"https://api.github.com/repos/walmartlabs/thorax/subscribers","subscription_url":"https://api.github.com/repos/walmartlabs/thorax/subscription","commits_url":"https://api.github.com/repos/walmartlabs/thorax/commits{/sha}","git_commits_url":"https://api.github.com/repos/walmartlabs/thorax/git/commits{/sha}","comments_url":"https://api.github.com/repos/walmartlabs/thorax/comments{/number}","issue_comment_url":"https://api.github.com/repos/walmartlabs/thorax/issues/comments/{number}","contents_url":"https://api.github.com/repos/walmartlabs/thorax/contents/{+path}","compare_url":"https://api.github.com/repos/walmartlabs/thorax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/walmartlabs/thorax/merges","archive_url":"https://api.github.com/repos/walmartlabs/thorax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/walmartlabs/thorax/downloads","issues_url":"https://api.github.com/repos/walmartlabs/thorax/issues{/number}","pulls_url":"https://api.github.com/repos/walmartlabs/thorax/pulls{/number}","milestones_url":"https://api.github.com/repos/walmartlabs/thorax/milestones{/number}","notifications_url":"https://api.github.com/repos/walmartlabs/thorax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/walmartlabs/thorax/labels{/name}","releases_url":"https://api.github.com/repos/walmartlabs/thorax/releases{/id}","created_at":"2011-10-05T23:21:17Z","updated_at":"2014-05-17T10:01:44Z","pushed_at":"2014-05-17T10:01:43Z","git_url":"git://github.com/walmartlabs/thorax.git","ssh_url":"git@github.com:walmartlabs/thorax.git","clone_url":"https://github.com/walmartlabs/thorax.git","svn_url":"https://github.com/walmartlabs/thorax","homepage":"http://thoraxjs.org/","size":8891,"stargazers_count":1179,"watchers_count":1179,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":110,"mirror_url":null,"open_issues_count":51,"forks":110,"open_issues":51,"watchers":1179,"default_branch":"master"}},"base":{"label":"walmartlabs:master","ref":"master","sha":"6a9356c6384f0144a8cb6c9eabd7142bc9e0662b","user":{"login":"walmartlabs","id":768298,"avatar_url":"https://avatars.githubusercontent.com/u/768298?","gravatar_id":"fc99ca7b0cb55469b4ca83a1d7790958","url":"https://api.github.com/users/walmartlabs","html_url":"https://github.com/walmartlabs","followers_url":"https://api.github.com/users/walmartlabs/followers","following_url":"https://api.github.com/users/walmartlabs/following{/other_user}","gists_url":"https://api.github.com/users/walmartlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/walmartlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walmartlabs/subscriptions","organizations_url":"https://api.github.com/users/walmartlabs/orgs","repos_url":"https://api.github.com/users/walmartlabs/repos","events_url":"https://api.github.com/users/walmartlabs/events{/privacy}","received_events_url":"https://api.github.com/users/walmartlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2522940,"name":"thorax","full_name":"walmartlabs/thorax","owner":{"login":"walmartlabs","id":768298,"avatar_url":"https://avatars.githubusercontent.com/u/768298?","gravatar_id":"fc99ca7b0cb55469b4ca83a1d7790958","url":"https://api.github.com/users/walmartlabs","html_url":"https://github.com/walmartlabs","followers_url":"https://api.github.com/users/walmartlabs/followers","following_url":"https://api.github.com/users/walmartlabs/following{/other_user}","gists_url":"https://api.github.com/users/walmartlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/walmartlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walmartlabs/subscriptions","organizations_url":"https://api.github.com/users/walmartlabs/orgs","repos_url":"https://api.github.com/users/walmartlabs/repos","events_url":"https://api.github.com/users/walmartlabs/events{/privacy}","received_events_url":"https://api.github.com/users/walmartlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/walmartlabs/thorax","description":"Strengthening your Backbone","fork":false,"url":"https://api.github.com/repos/walmartlabs/thorax","forks_url":"https://api.github.com/repos/walmartlabs/thorax/forks","keys_url":"https://api.github.com/repos/walmartlabs/thorax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/walmartlabs/thorax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/walmartlabs/thorax/teams","hooks_url":"https://api.github.com/repos/walmartlabs/thorax/hooks","issue_events_url":"https://api.github.com/repos/walmartlabs/thorax/issues/events{/number}","events_url":"https://api.github.com/repos/walmartlabs/thorax/events","assignees_url":"https://api.github.com/repos/walmartlabs/thorax/assignees{/user}","branches_url":"https://api.github.com/repos/walmartlabs/thorax/branches{/branch}","tags_url":"https://api.github.com/repos/walmartlabs/thorax/tags","blobs_url":"https://api.github.com/repos/walmartlabs/thorax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/walmartlabs/thorax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/walmartlabs/thorax/git/refs{/sha}","trees_url":"https://api.github.com/repos/walmartlabs/thorax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/walmartlabs/thorax/statuses/{sha}","languages_url":"https://api.github.com/repos/walmartlabs/thorax/languages","stargazers_url":"https://api.github.com/repos/walmartlabs/thorax/stargazers","contributors_url":"https://api.github.com/repos/walmartlabs/thorax/contributors","subscribers_url":"https://api.github.com/repos/walmartlabs/thorax/subscribers","subscription_url":"https://api.github.com/repos/walmartlabs/thorax/subscription","commits_url":"https://api.github.com/repos/walmartlabs/thorax/commits{/sha}","git_commits_url":"https://api.github.com/repos/walmartlabs/thorax/git/commits{/sha}","comments_url":"https://api.github.com/repos/walmartlabs/thorax/comments{/number}","issue_comment_url":"https://api.github.com/repos/walmartlabs/thorax/issues/comments/{number}","contents_url":"https://api.github.com/repos/walmartlabs/thorax/contents/{+path}","compare_url":"https://api.github.com/repos/walmartlabs/thorax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/walmartlabs/thorax/merges","archive_url":"https://api.github.com/repos/walmartlabs/thorax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/walmartlabs/thorax/downloads","issues_url":"https://api.github.com/repos/walmartlabs/thorax/issues{/number}","pulls_url":"https://api.github.com/repos/walmartlabs/thorax/pulls{/number}","milestones_url":"https://api.github.com/repos/walmartlabs/thorax/milestones{/number}","notifications_url":"https://api.github.com/repos/walmartlabs/thorax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/walmartlabs/thorax/labels{/name}","releases_url":"https://api.github.com/repos/walmartlabs/thorax/releases{/id}","created_at":"2011-10-05T23:21:17Z","updated_at":"2014-05-17T10:01:44Z","pushed_at":"2014-05-17T10:01:43Z","git_url":"git://github.com/walmartlabs/thorax.git","ssh_url":"git@github.com:walmartlabs/thorax.git","clone_url":"https://github.com/walmartlabs/thorax.git","svn_url":"https://github.com/walmartlabs/thorax","homepage":"http://thoraxjs.org/","size":8891,"stargazers_count":1179,"watchers_count":1179,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":110,"mirror_url":null,"open_issues_count":51,"forks":110,"open_issues":51,"watchers":1179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/walmartlabs/thorax/pulls/370"},"html":{"href":"https://github.com/walmartlabs/thorax/pull/370"},"issue":{"href":"https://api.github.com/repos/walmartlabs/thorax/issues/370"},"comments":{"href":"https://api.github.com/repos/walmartlabs/thorax/issues/370/comments"},"review_comments":{"href":"https://api.github.com/repos/walmartlabs/thorax/pulls/370/comments"},"review_comment":{"href":"https://api.github.com/repos/walmartlabs/thorax/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/walmartlabs/thorax/pulls/370/commits"},"statuses":{"href":"https://api.github.com/repos/walmartlabs/thorax/statuses/d519e8d72636ce775b8383c9167adf8f380e986b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kpdecker","id":196390,"avatar_url":"https://avatars.githubusercontent.com/u/196390?","gravatar_id":"1d0a77e7fa25279e2ec61a6f802b2862","url":"https://api.github.com/users/kpdecker","html_url":"https://github.com/kpdecker","followers_url":"https://api.github.com/users/kpdecker/followers","following_url":"https://api.github.com/users/kpdecker/following{/other_user}","gists_url":"https://api.github.com/users/kpdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/kpdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpdecker/subscriptions","organizations_url":"https://api.github.com/users/kpdecker/orgs","repos_url":"https://api.github.com/users/kpdecker/repos","events_url":"https://api.github.com/users/kpdecker/events{/privacy}","received_events_url":"https://api.github.com/users/kpdecker/received_events","type":"User","site_admin":false},"comments":16,"review_comments":0,"commits":7,"additions":103,"deletions":11,"changed_files":2}}