GitHub PullRequestEvent at 2014-10-27 16:08:45
Repository: instar
Actor: boxed
Payload: {"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/boxed/instar/pulls/3","id":23343387,"html_url":"https://github.com/boxed/instar/pull/3","diff_url":"https://github.com/boxed/instar/pull/3.diff","patch_url":"https://github.com/boxed/instar/pull/3.patch","issue_url":"https://api.github.com/repos/boxed/instar/issues/3","number":3,"state":"closed","locked":false,"title":"make it work under cljs","user":{"login":"piranha","id":6553,"avatar_url":"https://avatars.githubusercontent.com/u/6553?v=2","gravatar_id":"","url":"https://api.github.com/users/piranha","html_url":"https://github.com/piranha","followers_url":"https://api.github.com/users/piranha/followers","following_url":"https://api.github.com/users/piranha/following{/other_user}","gists_url":"https://api.github.com/users/piranha/gists{/gist_id}","starred_url":"https://api.github.com/users/piranha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piranha/subscriptions","organizations_url":"https://api.github.com/users/piranha/orgs","repos_url":"https://api.github.com/users/piranha/repos","events_url":"https://api.github.com/users/piranha/events{/privacy}","received_events_url":"https://api.github.com/users/piranha/received_events","type":"User","site_admin":false},"body":"I figured that it was a problem of `clj->js`. To be honest, I would love to rework those stacks into clojure transients, but it's a bit too late and I didn't figure out how to run all expansions. Maybe `lazy-seq` would help there... Anyway, those changes make it work under CLJS. I figured that having separate `index-of` is better than trying to figure out than converting all paths into javascript arrays. :)","created_at":"2014-10-25T20:38:24Z","updated_at":"2014-10-27T16:08:44Z","closed_at":"2014-10-27T16:08:44Z","merged_at":"2014-10-27T16:08:44Z","merge_commit_sha":"4af06e6e46f27f417e083eee027eef2a4291f411","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boxed/instar/pulls/3/commits","review_comments_url":"https://api.github.com/repos/boxed/instar/pulls/3/comments","review_comment_url":"https://api.github.com/repos/boxed/instar/pulls/comments/{number}","comments_url":"https://api.github.com/repos/boxed/instar/issues/3/comments","statuses_url":"https://api.github.com/repos/boxed/instar/statuses/45415b15ea14652fdd6821e70a0b32e5c22f4fdc","head":{"label":"piranha:master","ref":"master","sha":"45415b15ea14652fdd6821e70a0b32e5c22f4fdc","user":{"login":"piranha","id":6553,"avatar_url":"https://avatars.githubusercontent.com/u/6553?v=2","gravatar_id":"","url":"https://api.github.com/users/piranha","html_url":"https://github.com/piranha","followers_url":"https://api.github.com/users/piranha/followers","following_url":"https://api.github.com/users/piranha/following{/other_user}","gists_url":"https://api.github.com/users/piranha/gists{/gist_id}","starred_url":"https://api.github.com/users/piranha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piranha/subscriptions","organizations_url":"https://api.github.com/users/piranha/orgs","repos_url":"https://api.github.com/users/piranha/repos","events_url":"https://api.github.com/users/piranha/events{/privacy}","received_events_url":"https://api.github.com/users/piranha/received_events","type":"User","site_admin":false},"repo":{"id":25745689,"name":"instar","full_name":"piranha/instar","owner":{"login":"piranha","id":6553,"avatar_url":"https://avatars.githubusercontent.com/u/6553?v=2","gravatar_id":"","url":"https://api.github.com/users/piranha","html_url":"https://github.com/piranha","followers_url":"https://api.github.com/users/piranha/followers","following_url":"https://api.github.com/users/piranha/following{/other_user}","gists_url":"https://api.github.com/users/piranha/gists{/gist_id}","starred_url":"https://api.github.com/users/piranha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piranha/subscriptions","organizations_url":"https://api.github.com/users/piranha/orgs","repos_url":"https://api.github.com/users/piranha/repos","events_url":"https://api.github.com/users/piranha/events{/privacy}","received_events_url":"https://api.github.com/users/piranha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/piranha/instar","description":"Simpler and more powerful assoc/dissoc/update-in for both Clojure and ClojureScript","fork":true,"url":"https://api.github.com/repos/piranha/instar","forks_url":"https://api.github.com/repos/piranha/instar/forks","keys_url":"https://api.github.com/repos/piranha/instar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piranha/instar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piranha/instar/teams","hooks_url":"https://api.github.com/repos/piranha/instar/hooks","issue_events_url":"https://api.github.com/repos/piranha/instar/issues/events{/number}","events_url":"https://api.github.com/repos/piranha/instar/events","assignees_url":"https://api.github.com/repos/piranha/instar/assignees{/user}","branches_url":"https://api.github.com/repos/piranha/instar/branches{/branch}","tags_url":"https://api.github.com/repos/piranha/instar/tags","blobs_url":"https://api.github.com/repos/piranha/instar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piranha/instar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piranha/instar/git/refs{/sha}","trees_url":"https://api.github.com/repos/piranha/instar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piranha/instar/statuses/{sha}","languages_url":"https://api.github.com/repos/piranha/instar/languages","stargazers_url":"https://api.github.com/repos/piranha/instar/stargazers","contributors_url":"https://api.github.com/repos/piranha/instar/contributors","subscribers_url":"https://api.github.com/repos/piranha/instar/subscribers","subscription_url":"https://api.github.com/repos/piranha/instar/subscription","commits_url":"https://api.github.com/repos/piranha/instar/commits{/sha}","git_commits_url":"https://api.github.com/repos/piranha/instar/git/commits{/sha}","comments_url":"https://api.github.com/repos/piranha/instar/comments{/number}","issue_comment_url":"https://api.github.com/repos/piranha/instar/issues/comments/{number}","contents_url":"https://api.github.com/repos/piranha/instar/contents/{+path}","compare_url":"https://api.github.com/repos/piranha/instar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piranha/instar/merges","archive_url":"https://api.github.com/repos/piranha/instar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piranha/instar/downloads","issues_url":"https://api.github.com/repos/piranha/instar/issues{/number}","pulls_url":"https://api.github.com/repos/piranha/instar/pulls{/number}","milestones_url":"https://api.github.com/repos/piranha/instar/milestones{/number}","notifications_url":"https://api.github.com/repos/piranha/instar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piranha/instar/labels{/name}","releases_url":"https://api.github.com/repos/piranha/instar/releases{/id}","created_at":"2014-10-25T20:34:58Z","updated_at":"2014-10-25T20:35:06Z","pushed_at":"2014-10-25T20:45:41Z","git_url":"git://github.com/piranha/instar.git","ssh_url":"git@github.com:piranha/instar.git","clone_url":"https://github.com/piranha/instar.git","svn_url":"https://github.com/piranha/instar","homepage":"","size":115,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boxed:master","ref":"master","sha":"4f06413247daabce7bfc68310c84d7ee9a88e5f9","user":{"login":"boxed","id":332428,"avatar_url":"https://avatars.githubusercontent.com/u/332428?v=2","gravatar_id":"","url":"https://api.github.com/users/boxed","html_url":"https://github.com/boxed","followers_url":"https://api.github.com/users/boxed/followers","following_url":"https://api.github.com/users/boxed/following{/other_user}","gists_url":"https://api.github.com/users/boxed/gists{/gist_id}","starred_url":"https://api.github.com/users/boxed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boxed/subscriptions","organizations_url":"https://api.github.com/users/boxed/orgs","repos_url":"https://api.github.com/users/boxed/repos","events_url":"https://api.github.com/users/boxed/events{/privacy}","received_events_url":"https://api.github.com/users/boxed/received_events","type":"User","site_admin":false},"repo":{"id":21763078,"name":"instar","full_name":"boxed/instar","owner":{"login":"boxed","id":332428,"avatar_url":"https://avatars.githubusercontent.com/u/332428?v=2","gravatar_id":"","url":"https://api.github.com/users/boxed","html_url":"https://github.com/boxed","followers_url":"https://api.github.com/users/boxed/followers","following_url":"https://api.github.com/users/boxed/following{/other_user}","gists_url":"https://api.github.com/users/boxed/gists{/gist_id}","starred_url":"https://api.github.com/users/boxed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boxed/subscriptions","organizations_url":"https://api.github.com/users/boxed/orgs","repos_url":"https://api.github.com/users/boxed/repos","events_url":"https://api.github.com/users/boxed/events{/privacy}","received_events_url":"https://api.github.com/users/boxed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boxed/instar","description":"Simpler and more powerful assoc/dissoc/update-in for both Clojure and ClojureScript","fork":false,"url":"https://api.github.com/repos/boxed/instar","forks_url":"https://api.github.com/repos/boxed/instar/forks","keys_url":"https://api.github.com/repos/boxed/instar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boxed/instar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boxed/instar/teams","hooks_url":"https://api.github.com/repos/boxed/instar/hooks","issue_events_url":"https://api.github.com/repos/boxed/instar/issues/events{/number}","events_url":"https://api.github.com/repos/boxed/instar/events","assignees_url":"https://api.github.com/repos/boxed/instar/assignees{/user}","branches_url":"https://api.github.com/repos/boxed/instar/branches{/branch}","tags_url":"https://api.github.com/repos/boxed/instar/tags","blobs_url":"https://api.github.com/repos/boxed/instar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boxed/instar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boxed/instar/git/refs{/sha}","trees_url":"https://api.github.com/repos/boxed/instar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boxed/instar/statuses/{sha}","languages_url":"https://api.github.com/repos/boxed/instar/languages","stargazers_url":"https://api.github.com/repos/boxed/instar/stargazers","contributors_url":"https://api.github.com/repos/boxed/instar/contributors","subscribers_url":"https://api.github.com/repos/boxed/instar/subscribers","subscription_url":"https://api.github.com/repos/boxed/instar/subscription","commits_url":"https://api.github.com/repos/boxed/instar/commits{/sha}","git_commits_url":"https://api.github.com/repos/boxed/instar/git/commits{/sha}","comments_url":"https://api.github.com/repos/boxed/instar/comments{/number}","issue_comment_url":"https://api.github.com/repos/boxed/instar/issues/comments/{number}","contents_url":"https://api.github.com/repos/boxed/instar/contents/{+path}","compare_url":"https://api.github.com/repos/boxed/instar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boxed/instar/merges","archive_url":"https://api.github.com/repos/boxed/instar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boxed/instar/downloads","issues_url":"https://api.github.com/repos/boxed/instar/issues{/number}","pulls_url":"https://api.github.com/repos/boxed/instar/pulls{/number}","milestones_url":"https://api.github.com/repos/boxed/instar/milestones{/number}","notifications_url":"https://api.github.com/repos/boxed/instar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boxed/instar/labels{/name}","releases_url":"https://api.github.com/repos/boxed/instar/releases{/id}","created_at":"2014-07-12T08:43:38Z","updated_at":"2014-09-18T16:44:50Z","pushed_at":"2014-10-27T16:08:44Z","git_url":"git://github.com/boxed/instar.git","ssh_url":"git@github.com:boxed/instar.git","clone_url":"https://github.com/boxed/instar.git","svn_url":"https://github.com/boxed/instar","homepage":"","size":328,"stargazers_count":27,"watchers_count":27,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boxed/instar/pulls/3"},"html":{"href":"https://github.com/boxed/instar/pull/3"},"issue":{"href":"https://api.github.com/repos/boxed/instar/issues/3"},"comments":{"href":"https://api.github.com/repos/boxed/instar/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/boxed/instar/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/boxed/instar/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/boxed/instar/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/boxed/instar/statuses/45415b15ea14652fdd6821e70a0b32e5c22f4fdc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"boxed","id":332428,"avatar_url":"https://avatars.githubusercontent.com/u/332428?v=2","gravatar_id":"","url":"https://api.github.com/users/boxed","html_url":"https://github.com/boxed","followers_url":"https://api.github.com/users/boxed/followers","following_url":"https://api.github.com/users/boxed/following{/other_user}","gists_url":"https://api.github.com/users/boxed/gists{/gist_id}","starred_url":"https://api.github.com/users/boxed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boxed/subscriptions","organizations_url":"https://api.github.com/users/boxed/orgs","repos_url":"https://api.github.com/users/boxed/repos","events_url":"https://api.github.com/users/boxed/events{/privacy}","received_events_url":"https://api.github.com/users/boxed/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":3,"additions":74,"deletions":26,"changed_files":6}}