GitHub PullRequestReviewCommentEvent at 2014-07-10 18:46:21
Repository: nexpose-client
Actor: gschneider-r7
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/comments/14784879","id":14784879,"diff_hunk":"@@ -99,6 +99,7 @@ def to_xml\n       xml = %(<AssetGroup id=\"#{@id}\" name=\"#{replace_entities(@name)}\")\n       xml << %( description=\"#{replace_entities(@description)}\") if @description\n       xml << '>'\n+      xml << \"<Description>#{replace_entities(@description)}</Description>\" if @description","path":"lib/nexpose/group.rb","position":null,"original_position":4,"commit_id":"14ef506f2ab8b60e17030149b8165d89fee490b7","original_commit_id":"49ab22c88a2d78d817583c562d349534e12dd347","user":{"login":"gschneider-r7","id":4418817,"avatar_url":"https://avatars.githubusercontent.com/u/4418817?","gravatar_id":"8ebcf22b6be874d7255bdff4ee55c2dc","url":"https://api.github.com/users/gschneider-r7","html_url":"https://github.com/gschneider-r7","followers_url":"https://api.github.com/users/gschneider-r7/followers","following_url":"https://api.github.com/users/gschneider-r7/following{/other_user}","gists_url":"https://api.github.com/users/gschneider-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/gschneider-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gschneider-r7/subscriptions","organizations_url":"https://api.github.com/users/gschneider-r7/orgs","repos_url":"https://api.github.com/users/gschneider-r7/repos","events_url":"https://api.github.com/users/gschneider-r7/events{/privacy}","received_events_url":"https://api.github.com/users/gschneider-r7/received_events","type":"User","site_admin":false},"body":"Good idea. I've added a new commit with these changes.","created_at":"2014-07-10T18:46:21Z","updated_at":"2014-07-10T18:46:21Z","html_url":"https://github.com/rapid7/nexpose-client/pull/70#discussion_r14784879","pull_request_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/comments/14784879"},"html":{"href":"https://github.com/rapid7/nexpose-client/pull/70#discussion_r14784879"},"pull_request":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/70","id":18073891,"html_url":"https://github.com/rapid7/nexpose-client/pull/70","diff_url":"https://github.com/rapid7/nexpose-client/pull/70.diff","patch_url":"https://github.com/rapid7/nexpose-client/pull/70.patch","issue_url":"https://api.github.com/repos/rapid7/nexpose-client/issues/70","number":70,"state":"open","title":"Add support for new Description tag in site and group configs","user":{"login":"gschneider-r7","id":4418817,"avatar_url":"https://avatars.githubusercontent.com/u/4418817?","gravatar_id":"8ebcf22b6be874d7255bdff4ee55c2dc","url":"https://api.github.com/users/gschneider-r7","html_url":"https://github.com/gschneider-r7","followers_url":"https://api.github.com/users/gschneider-r7/followers","following_url":"https://api.github.com/users/gschneider-r7/following{/other_user}","gists_url":"https://api.github.com/users/gschneider-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/gschneider-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gschneider-r7/subscriptions","organizations_url":"https://api.github.com/users/gschneider-r7/orgs","repos_url":"https://api.github.com/users/gschneider-r7/repos","events_url":"https://api.github.com/users/gschneider-r7/events{/privacy}","received_events_url":"https://api.github.com/users/gschneider-r7/received_events","type":"User","site_admin":false},"body":"This is needed to support site and group descriptions with newline characters in an upcoming Nexpose release. This change should be backwards-compatible, though, and can probably be merged in at any time. The `<Description>` tag is ignored by current Nexpose versions and is optional for future versions.","created_at":"2014-07-07T22:44:28Z","updated_at":"2014-07-10T18:46:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdfc81955bb798c9d1c434db6cf01f38d378bcb0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/70/commits","review_comments_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/70/comments","review_comment_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rapid7/nexpose-client/issues/70/comments","statuses_url":"https://api.github.com/repos/rapid7/nexpose-client/statuses/14ef506f2ab8b60e17030149b8165d89fee490b7","head":{"label":"gschneider-r7:master","ref":"master","sha":"14ef506f2ab8b60e17030149b8165d89fee490b7","user":{"login":"gschneider-r7","id":4418817,"avatar_url":"https://avatars.githubusercontent.com/u/4418817?","gravatar_id":"8ebcf22b6be874d7255bdff4ee55c2dc","url":"https://api.github.com/users/gschneider-r7","html_url":"https://github.com/gschneider-r7","followers_url":"https://api.github.com/users/gschneider-r7/followers","following_url":"https://api.github.com/users/gschneider-r7/following{/other_user}","gists_url":"https://api.github.com/users/gschneider-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/gschneider-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gschneider-r7/subscriptions","organizations_url":"https://api.github.com/users/gschneider-r7/orgs","repos_url":"https://api.github.com/users/gschneider-r7/repos","events_url":"https://api.github.com/users/gschneider-r7/events{/privacy}","received_events_url":"https://api.github.com/users/gschneider-r7/received_events","type":"User","site_admin":false},"repo":{"id":18924681,"name":"nexpose-client","full_name":"gschneider-r7/nexpose-client","owner":{"login":"gschneider-r7","id":4418817,"avatar_url":"https://avatars.githubusercontent.com/u/4418817?","gravatar_id":"8ebcf22b6be874d7255bdff4ee55c2dc","url":"https://api.github.com/users/gschneider-r7","html_url":"https://github.com/gschneider-r7","followers_url":"https://api.github.com/users/gschneider-r7/followers","following_url":"https://api.github.com/users/gschneider-r7/following{/other_user}","gists_url":"https://api.github.com/users/gschneider-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/gschneider-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gschneider-r7/subscriptions","organizations_url":"https://api.github.com/users/gschneider-r7/orgs","repos_url":"https://api.github.com/users/gschneider-r7/repos","events_url":"https://api.github.com/users/gschneider-r7/events{/privacy}","received_events_url":"https://api.github.com/users/gschneider-r7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gschneider-r7/nexpose-client","description":"Rapid7 Nexpose API client library written in Ruby","fork":true,"url":"https://api.github.com/repos/gschneider-r7/nexpose-client","forks_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/forks","keys_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/teams","hooks_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/hooks","issue_events_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/issues/events{/number}","events_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/events","assignees_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/assignees{/user}","branches_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/branches{/branch}","tags_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/tags","blobs_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/statuses/{sha}","languages_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/languages","stargazers_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/stargazers","contributors_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/contributors","subscribers_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/subscribers","subscription_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/subscription","commits_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/contents/{+path}","compare_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/merges","archive_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/downloads","issues_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/issues{/number}","pulls_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/pulls{/number}","milestones_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/milestones{/number}","notifications_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/labels{/name}","releases_url":"https://api.github.com/repos/gschneider-r7/nexpose-client/releases{/id}","created_at":"2014-04-18T20:28:45Z","updated_at":"2014-07-07T22:21:41Z","pushed_at":"2014-07-10T18:45:46Z","git_url":"git://github.com/gschneider-r7/nexpose-client.git","ssh_url":"git@github.com:gschneider-r7/nexpose-client.git","clone_url":"https://github.com/gschneider-r7/nexpose-client.git","svn_url":"https://github.com/gschneider-r7/nexpose-client","homepage":"http://www.rapid7.com/","size":886,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"43e903b321c421b793539dd8f9d8555f7f01fde3","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?","gravatar_id":"5d198df57a51ac06525bfa48c3ff9f6c","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":2622467,"name":"nexpose-client","full_name":"rapid7/nexpose-client","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?","gravatar_id":"5d198df57a51ac06525bfa48c3ff9f6c","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/nexpose-client","description":"Rapid7 Nexpose API client library written in Ruby","fork":false,"url":"https://api.github.com/repos/rapid7/nexpose-client","forks_url":"https://api.github.com/repos/rapid7/nexpose-client/forks","keys_url":"https://api.github.com/repos/rapid7/nexpose-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/nexpose-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/nexpose-client/teams","hooks_url":"https://api.github.com/repos/rapid7/nexpose-client/hooks","issue_events_url":"https://api.github.com/repos/rapid7/nexpose-client/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/nexpose-client/events","assignees_url":"https://api.github.com/repos/rapid7/nexpose-client/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/nexpose-client/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/nexpose-client/tags","blobs_url":"https://api.github.com/repos/rapid7/nexpose-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/nexpose-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/nexpose-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/nexpose-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/nexpose-client/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/nexpose-client/languages","stargazers_url":"https://api.github.com/repos/rapid7/nexpose-client/stargazers","contributors_url":"https://api.github.com/repos/rapid7/nexpose-client/contributors","subscribers_url":"https://api.github.com/repos/rapid7/nexpose-client/subscribers","subscription_url":"https://api.github.com/repos/rapid7/nexpose-client/subscription","commits_url":"https://api.github.com/repos/rapid7/nexpose-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/nexpose-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/nexpose-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/nexpose-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/rapid7/nexpose-client/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/nexpose-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/nexpose-client/merges","archive_url":"https://api.github.com/repos/rapid7/nexpose-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/nexpose-client/downloads","issues_url":"https://api.github.com/repos/rapid7/nexpose-client/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/nexpose-client/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/nexpose-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/nexpose-client/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/nexpose-client/releases{/id}","created_at":"2011-10-21T19:04:49Z","updated_at":"2014-06-26T21:05:00Z","pushed_at":"2014-07-03T18:10:04Z","git_url":"git://github.com/rapid7/nexpose-client.git","ssh_url":"git@github.com:rapid7/nexpose-client.git","clone_url":"https://github.com/rapid7/nexpose-client.git","svn_url":"https://github.com/rapid7/nexpose-client","homepage":"http://www.rapid7.com/","size":4885,"stargazers_count":55,"watchers_count":55,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":38,"mirror_url":null,"open_issues_count":5,"forks":38,"open_issues":5,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/70"},"html":{"href":"https://github.com/rapid7/nexpose-client/pull/70"},"issue":{"href":"https://api.github.com/repos/rapid7/nexpose-client/issues/70"},"comments":{"href":"https://api.github.com/repos/rapid7/nexpose-client/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/nexpose-client/statuses/14ef506f2ab8b60e17030149b8165d89fee490b7"}}}}