GitHub PullRequestReviewCommentEvent at 2014-10-29 12:49:17
Repository: swarrot
Actor: odolbeau
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/swarrot/swarrot/pulls/comments/19534777","id":19534777,"diff_hunk":"@@ -33,6 +35,12 @@ public function sleep(array $options)\n     {\n         // Since this should be called after the consumer was not able to retrieve a message,\n         // it means that the queue is empty, so we can simply return false to force the consumer to stop\n+        $this->logger && $this->logger->info(","path":"src/Swarrot/Processor/Insomniac/InsomniacProcessor.php","position":24,"original_position":24,"commit_id":"17e4f4269c8aa442f4081facf4481338e29ab4b4","original_commit_id":"17e4f4269c8aa442f4081facf4481338e29ab4b4","user":{"login":"odolbeau","id":680206,"avatar_url":"https://avatars.githubusercontent.com/u/680206?v=2","gravatar_id":"","url":"https://api.github.com/users/odolbeau","html_url":"https://github.com/odolbeau","followers_url":"https://api.github.com/users/odolbeau/followers","following_url":"https://api.github.com/users/odolbeau/following{/other_user}","gists_url":"https://api.github.com/users/odolbeau/gists{/gist_id}","starred_url":"https://api.github.com/users/odolbeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odolbeau/subscriptions","organizations_url":"https://api.github.com/users/odolbeau/orgs","repos_url":"https://api.github.com/users/odolbeau/repos","events_url":"https://api.github.com/users/odolbeau/events{/privacy}","received_events_url":"https://api.github.com/users/odolbeau/received_events","type":"User","site_admin":false},"body":"The only difference between `and` and `&&` is the priority isn't it ?\r\nWhat's the difference in this case ? (except readability maybe, which is already a good argument. :D)","created_at":"2014-10-29T12:49:17Z","updated_at":"2014-10-29T12:49:17Z","html_url":"https://github.com/swarrot/swarrot/pull/69#discussion_r19534777","pull_request_url":"https://api.github.com/repos/swarrot/swarrot/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/swarrot/swarrot/pulls/comments/19534777"},"html":{"href":"https://github.com/swarrot/swarrot/pull/69#discussion_r19534777"},"pull_request":{"href":"https://api.github.com/repos/swarrot/swarrot/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/swarrot/swarrot/pulls/69","id":23525980,"html_url":"https://github.com/swarrot/swarrot/pull/69","diff_url":"https://github.com/swarrot/swarrot/pull/69.diff","patch_url":"https://github.com/swarrot/swarrot/pull/69.patch","issue_url":"https://api.github.com/repos/swarrot/swarrot/issues/69","number":69,"state":"open","locked":false,"title":"Update logger calls","user":{"login":"odolbeau","id":680206,"avatar_url":"https://avatars.githubusercontent.com/u/680206?v=2","gravatar_id":"","url":"https://api.github.com/users/odolbeau","html_url":"https://github.com/odolbeau","followers_url":"https://api.github.com/users/odolbeau/followers","following_url":"https://api.github.com/users/odolbeau/following{/other_user}","gists_url":"https://api.github.com/users/odolbeau/gists{/gist_id}","starred_url":"https://api.github.com/users/odolbeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odolbeau/subscriptions","organizations_url":"https://api.github.com/users/odolbeau/orgs","repos_url":"https://api.github.com/users/odolbeau/repos","events_url":"https://api.github.com/users/odolbeau/events{/privacy}","received_events_url":"https://api.github.com/users/odolbeau/received_events","type":"User","site_admin":false},"body":"All logger calls now add a `swarrot_processor` key in context.","created_at":"2014-10-29T12:19:38Z","updated_at":"2014-10-29T12:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e2f1a8434f2f7d640e9f60d690ccb30a0790787","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/swarrot/swarrot/pulls/69/commits","review_comments_url":"https://api.github.com/repos/swarrot/swarrot/pulls/69/comments","review_comment_url":"https://api.github.com/repos/swarrot/swarrot/pulls/comments/{number}","comments_url":"https://api.github.com/repos/swarrot/swarrot/issues/69/comments","statuses_url":"https://api.github.com/repos/swarrot/swarrot/statuses/17e4f4269c8aa442f4081facf4481338e29ab4b4","head":{"label":"odolbeau:update-logger-calls","ref":"update-logger-calls","sha":"17e4f4269c8aa442f4081facf4481338e29ab4b4","user":{"login":"odolbeau","id":680206,"avatar_url":"https://avatars.githubusercontent.com/u/680206?v=2","gravatar_id":"","url":"https://api.github.com/users/odolbeau","html_url":"https://github.com/odolbeau","followers_url":"https://api.github.com/users/odolbeau/followers","following_url":"https://api.github.com/users/odolbeau/following{/other_user}","gists_url":"https://api.github.com/users/odolbeau/gists{/gist_id}","starred_url":"https://api.github.com/users/odolbeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odolbeau/subscriptions","organizations_url":"https://api.github.com/users/odolbeau/orgs","repos_url":"https://api.github.com/users/odolbeau/repos","events_url":"https://api.github.com/users/odolbeau/events{/privacy}","received_events_url":"https://api.github.com/users/odolbeau/received_events","type":"User","site_admin":false},"repo":{"id":18836746,"name":"swarrot","full_name":"odolbeau/swarrot","owner":{"login":"odolbeau","id":680206,"avatar_url":"https://avatars.githubusercontent.com/u/680206?v=2","gravatar_id":"","url":"https://api.github.com/users/odolbeau","html_url":"https://github.com/odolbeau","followers_url":"https://api.github.com/users/odolbeau/followers","following_url":"https://api.github.com/users/odolbeau/following{/other_user}","gists_url":"https://api.github.com/users/odolbeau/gists{/gist_id}","starred_url":"https://api.github.com/users/odolbeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odolbeau/subscriptions","organizations_url":"https://api.github.com/users/odolbeau/orgs","repos_url":"https://api.github.com/users/odolbeau/repos","events_url":"https://api.github.com/users/odolbeau/events{/privacy}","received_events_url":"https://api.github.com/users/odolbeau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/odolbeau/swarrot","description":"A lib to consume message from any Broker","fork":true,"url":"https://api.github.com/repos/odolbeau/swarrot","forks_url":"https://api.github.com/repos/odolbeau/swarrot/forks","keys_url":"https://api.github.com/repos/odolbeau/swarrot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odolbeau/swarrot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odolbeau/swarrot/teams","hooks_url":"https://api.github.com/repos/odolbeau/swarrot/hooks","issue_events_url":"https://api.github.com/repos/odolbeau/swarrot/issues/events{/number}","events_url":"https://api.github.com/repos/odolbeau/swarrot/events","assignees_url":"https://api.github.com/repos/odolbeau/swarrot/assignees{/user}","branches_url":"https://api.github.com/repos/odolbeau/swarrot/branches{/branch}","tags_url":"https://api.github.com/repos/odolbeau/swarrot/tags","blobs_url":"https://api.github.com/repos/odolbeau/swarrot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odolbeau/swarrot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odolbeau/swarrot/git/refs{/sha}","trees_url":"https://api.github.com/repos/odolbeau/swarrot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odolbeau/swarrot/statuses/{sha}","languages_url":"https://api.github.com/repos/odolbeau/swarrot/languages","stargazers_url":"https://api.github.com/repos/odolbeau/swarrot/stargazers","contributors_url":"https://api.github.com/repos/odolbeau/swarrot/contributors","subscribers_url":"https://api.github.com/repos/odolbeau/swarrot/subscribers","subscription_url":"https://api.github.com/repos/odolbeau/swarrot/subscription","commits_url":"https://api.github.com/repos/odolbeau/swarrot/commits{/sha}","git_commits_url":"https://api.github.com/repos/odolbeau/swarrot/git/commits{/sha}","comments_url":"https://api.github.com/repos/odolbeau/swarrot/comments{/number}","issue_comment_url":"https://api.github.com/repos/odolbeau/swarrot/issues/comments/{number}","contents_url":"https://api.github.com/repos/odolbeau/swarrot/contents/{+path}","compare_url":"https://api.github.com/repos/odolbeau/swarrot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odolbeau/swarrot/merges","archive_url":"https://api.github.com/repos/odolbeau/swarrot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odolbeau/swarrot/downloads","issues_url":"https://api.github.com/repos/odolbeau/swarrot/issues{/number}","pulls_url":"https://api.github.com/repos/odolbeau/swarrot/pulls{/number}","milestones_url":"https://api.github.com/repos/odolbeau/swarrot/milestones{/number}","notifications_url":"https://api.github.com/repos/odolbeau/swarrot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odolbeau/swarrot/labels{/name}","releases_url":"https://api.github.com/repos/odolbeau/swarrot/releases{/id}","created_at":"2014-04-16T11:10:11Z","updated_at":"2014-06-27T20:51:54Z","pushed_at":"2014-10-29T12:21:14Z","git_url":"git://github.com/odolbeau/swarrot.git","ssh_url":"git@github.com:odolbeau/swarrot.git","clone_url":"https://github.com/odolbeau/swarrot.git","svn_url":"https://github.com/odolbeau/swarrot","homepage":"","size":779,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swarrot:master","ref":"master","sha":"eddf811bf0efc2ee2e894f84be44e477e8f7a17d","user":{"login":"swarrot","id":6749375,"avatar_url":"https://avatars.githubusercontent.com/u/6749375?v=2","gravatar_id":"","url":"https://api.github.com/users/swarrot","html_url":"https://github.com/swarrot","followers_url":"https://api.github.com/users/swarrot/followers","following_url":"https://api.github.com/users/swarrot/following{/other_user}","gists_url":"https://api.github.com/users/swarrot/gists{/gist_id}","starred_url":"https://api.github.com/users/swarrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swarrot/subscriptions","organizations_url":"https://api.github.com/users/swarrot/orgs","repos_url":"https://api.github.com/users/swarrot/repos","events_url":"https://api.github.com/users/swarrot/events{/privacy}","received_events_url":"https://api.github.com/users/swarrot/received_events","type":"Organization","site_admin":false},"repo":{"id":17061305,"name":"swarrot","full_name":"swarrot/swarrot","owner":{"login":"swarrot","id":6749375,"avatar_url":"https://avatars.githubusercontent.com/u/6749375?v=2","gravatar_id":"","url":"https://api.github.com/users/swarrot","html_url":"https://github.com/swarrot","followers_url":"https://api.github.com/users/swarrot/followers","following_url":"https://api.github.com/users/swarrot/following{/other_user}","gists_url":"https://api.github.com/users/swarrot/gists{/gist_id}","starred_url":"https://api.github.com/users/swarrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swarrot/subscriptions","organizations_url":"https://api.github.com/users/swarrot/orgs","repos_url":"https://api.github.com/users/swarrot/repos","events_url":"https://api.github.com/users/swarrot/events{/privacy}","received_events_url":"https://api.github.com/users/swarrot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swarrot/swarrot","description":"A lib to consume message from any Broker","fork":false,"url":"https://api.github.com/repos/swarrot/swarrot","forks_url":"https://api.github.com/repos/swarrot/swarrot/forks","keys_url":"https://api.github.com/repos/swarrot/swarrot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swarrot/swarrot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swarrot/swarrot/teams","hooks_url":"https://api.github.com/repos/swarrot/swarrot/hooks","issue_events_url":"https://api.github.com/repos/swarrot/swarrot/issues/events{/number}","events_url":"https://api.github.com/repos/swarrot/swarrot/events","assignees_url":"https://api.github.com/repos/swarrot/swarrot/assignees{/user}","branches_url":"https://api.github.com/repos/swarrot/swarrot/branches{/branch}","tags_url":"https://api.github.com/repos/swarrot/swarrot/tags","blobs_url":"https://api.github.com/repos/swarrot/swarrot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swarrot/swarrot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swarrot/swarrot/git/refs{/sha}","trees_url":"https://api.github.com/repos/swarrot/swarrot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swarrot/swarrot/statuses/{sha}","languages_url":"https://api.github.com/repos/swarrot/swarrot/languages","stargazers_url":"https://api.github.com/repos/swarrot/swarrot/stargazers","contributors_url":"https://api.github.com/repos/swarrot/swarrot/contributors","subscribers_url":"https://api.github.com/repos/swarrot/swarrot/subscribers","subscription_url":"https://api.github.com/repos/swarrot/swarrot/subscription","commits_url":"https://api.github.com/repos/swarrot/swarrot/commits{/sha}","git_commits_url":"https://api.github.com/repos/swarrot/swarrot/git/commits{/sha}","comments_url":"https://api.github.com/repos/swarrot/swarrot/comments{/number}","issue_comment_url":"https://api.github.com/repos/swarrot/swarrot/issues/comments/{number}","contents_url":"https://api.github.com/repos/swarrot/swarrot/contents/{+path}","compare_url":"https://api.github.com/repos/swarrot/swarrot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swarrot/swarrot/merges","archive_url":"https://api.github.com/repos/swarrot/swarrot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swarrot/swarrot/downloads","issues_url":"https://api.github.com/repos/swarrot/swarrot/issues{/number}","pulls_url":"https://api.github.com/repos/swarrot/swarrot/pulls{/number}","milestones_url":"https://api.github.com/repos/swarrot/swarrot/milestones{/number}","notifications_url":"https://api.github.com/repos/swarrot/swarrot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swarrot/swarrot/labels{/name}","releases_url":"https://api.github.com/repos/swarrot/swarrot/releases{/id}","created_at":"2014-02-21T15:57:54Z","updated_at":"2014-10-11T18:18:24Z","pushed_at":"2014-10-25T11:07:41Z","git_url":"git://github.com/swarrot/swarrot.git","ssh_url":"git@github.com:swarrot/swarrot.git","clone_url":"https://github.com/swarrot/swarrot.git","svn_url":"https://github.com/swarrot/swarrot","homepage":"","size":1716,"stargazers_count":82,"watchers_count":82,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":9,"forks":17,"open_issues":9,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swarrot/swarrot/pulls/69"},"html":{"href":"https://github.com/swarrot/swarrot/pull/69"},"issue":{"href":"https://api.github.com/repos/swarrot/swarrot/issues/69"},"comments":{"href":"https://api.github.com/repos/swarrot/swarrot/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/swarrot/swarrot/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/swarrot/swarrot/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/swarrot/swarrot/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/swarrot/swarrot/statuses/17e4f4269c8aa442f4081facf4481338e29ab4b4"}}}}