GitHub PullRequestEvent at 2014-12-16 23:24:58
Repository: selector-utils
Actor: fractaltheory
Payload: {"action":"opened","number":12,"pull_request":{"url":"https://api.github.com/repos/mobify/selector-utils/pulls/12","id":26189058,"html_url":"https://github.com/mobify/selector-utils/pull/12","diff_url":"https://github.com/mobify/selector-utils/pull/12.diff","patch_url":"https://github.com/mobify/selector-utils/pull/12.patch","issue_url":"https://api.github.com/repos/mobify/selector-utils/issues/12","number":12,"state":"open","locked":false,"title":"Added tests and refactored traversal utils","user":{"login":"fractaltheory","id":1211726,"avatar_url":"https://avatars.githubusercontent.com/u/1211726?v=3","gravatar_id":"","url":"https://api.github.com/users/fractaltheory","html_url":"https://github.com/fractaltheory","followers_url":"https://api.github.com/users/fractaltheory/followers","following_url":"https://api.github.com/users/fractaltheory/following{/other_user}","gists_url":"https://api.github.com/users/fractaltheory/gists{/gist_id}","starred_url":"https://api.github.com/users/fractaltheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fractaltheory/subscriptions","organizations_url":"https://api.github.com/users/fractaltheory/orgs","repos_url":"https://api.github.com/users/fractaltheory/repos","events_url":"https://api.github.com/users/fractaltheory/events{/privacy}","received_events_url":"https://api.github.com/users/fractaltheory/received_events","type":"User","site_admin":false},"body":"(Originally authored by @donnielrt)\r\n\r\nThis PR is opened based on #5 --- we originally were going to emulate jQuery's dir() function but determined it was essentially doing the same thing Don has written here. In particular, the main difference was the [test for nodeType !== 9](https://github.com/jquery/jquery/blob/master/src/traversing.js#L24) (i.e. document node), however this check is necessary only for traversals like .parents() (which we aren't implementing here). Additionally, since we are using Zepto's .prev() and .next() functions for our heavy lifting, we do not need to check for [nodeType == 1](https://github.com/jquery/jquery/blob/master/src/traversing.js#L25) (i.e. element node).\r\n\r\nThe tests Don had written from #5 are present here as well.\r\n\r\nStatus: **Opened for review**\r\n\r\nReviewers: @donnielrt @scalvert\r\n\r\n## How to test-drive this PR\r\n- Install this branch into a project and compare behavior to a jQuery instance of nextAll and nextUntil\r\n  \r\n## Research resources\r\n- https://github.com/jquery/jquery/blob/master/src/traversing.js#L24\r\n- http://api.jquery.com/nextall/\r\n- http://api.jquery.com/nextuntil/","created_at":"2014-12-16T23:24:57Z","updated_at":"2014-12-16T23:24:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c41450fd229bf2f567df2682b031bc410676a4c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mobify/selector-utils/pulls/12/commits","review_comments_url":"https://api.github.com/repos/mobify/selector-utils/pulls/12/comments","review_comment_url":"https://api.github.com/repos/mobify/selector-utils/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mobify/selector-utils/issues/12/comments","statuses_url":"https://api.github.com/repos/mobify/selector-utils/statuses/2fea1bf17a25760dd32e7043cad07c3c31b68769","head":{"label":"mobify:traversals","ref":"traversals","sha":"2fea1bf17a25760dd32e7043cad07c3c31b68769","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":25661637,"name":"selector-utils","full_name":"mobify/selector-utils","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/selector-utils","description":"Selector utility functions that can be selectively included in your Adaptive.js builds.","fork":false,"url":"https://api.github.com/repos/mobify/selector-utils","forks_url":"https://api.github.com/repos/mobify/selector-utils/forks","keys_url":"https://api.github.com/repos/mobify/selector-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/selector-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/selector-utils/teams","hooks_url":"https://api.github.com/repos/mobify/selector-utils/hooks","issue_events_url":"https://api.github.com/repos/mobify/selector-utils/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/selector-utils/events","assignees_url":"https://api.github.com/repos/mobify/selector-utils/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/selector-utils/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/selector-utils/tags","blobs_url":"https://api.github.com/repos/mobify/selector-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/selector-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/selector-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/selector-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/selector-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/selector-utils/languages","stargazers_url":"https://api.github.com/repos/mobify/selector-utils/stargazers","contributors_url":"https://api.github.com/repos/mobify/selector-utils/contributors","subscribers_url":"https://api.github.com/repos/mobify/selector-utils/subscribers","subscription_url":"https://api.github.com/repos/mobify/selector-utils/subscription","commits_url":"https://api.github.com/repos/mobify/selector-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/selector-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/selector-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/selector-utils/issues/comments/{number}","contents_url":"https://api.github.com/repos/mobify/selector-utils/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/selector-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/selector-utils/merges","archive_url":"https://api.github.com/repos/mobify/selector-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/selector-utils/downloads","issues_url":"https://api.github.com/repos/mobify/selector-utils/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/selector-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/selector-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/selector-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/selector-utils/labels{/name}","releases_url":"https://api.github.com/repos/mobify/selector-utils/releases{/id}","created_at":"2014-10-23T23:01:11Z","updated_at":"2014-12-15T19:10:20Z","pushed_at":"2014-12-16T23:14:24Z","git_url":"git://github.com/mobify/selector-utils.git","ssh_url":"git@github.com:mobify/selector-utils.git","clone_url":"https://github.com/mobify/selector-utils.git","svn_url":"https://github.com/mobify/selector-utils","homepage":"","size":676,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"mobify:master","ref":"master","sha":"f90b3ea1d72035107b906365697d3a81e508b46d","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":25661637,"name":"selector-utils","full_name":"mobify/selector-utils","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/selector-utils","description":"Selector utility functions that can be selectively included in your Adaptive.js builds.","fork":false,"url":"https://api.github.com/repos/mobify/selector-utils","forks_url":"https://api.github.com/repos/mobify/selector-utils/forks","keys_url":"https://api.github.com/repos/mobify/selector-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/selector-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/selector-utils/teams","hooks_url":"https://api.github.com/repos/mobify/selector-utils/hooks","issue_events_url":"https://api.github.com/repos/mobify/selector-utils/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/selector-utils/events","assignees_url":"https://api.github.com/repos/mobify/selector-utils/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/selector-utils/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/selector-utils/tags","blobs_url":"https://api.github.com/repos/mobify/selector-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/selector-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/selector-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/selector-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/selector-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/selector-utils/languages","stargazers_url":"https://api.github.com/repos/mobify/selector-utils/stargazers","contributors_url":"https://api.github.com/repos/mobify/selector-utils/contributors","subscribers_url":"https://api.github.com/repos/mobify/selector-utils/subscribers","subscription_url":"https://api.github.com/repos/mobify/selector-utils/subscription","commits_url":"https://api.github.com/repos/mobify/selector-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/selector-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/selector-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/selector-utils/issues/comments/{number}","contents_url":"https://api.github.com/repos/mobify/selector-utils/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/selector-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/selector-utils/merges","archive_url":"https://api.github.com/repos/mobify/selector-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/selector-utils/downloads","issues_url":"https://api.github.com/repos/mobify/selector-utils/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/selector-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/selector-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/selector-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/selector-utils/labels{/name}","releases_url":"https://api.github.com/repos/mobify/selector-utils/releases{/id}","created_at":"2014-10-23T23:01:11Z","updated_at":"2014-12-15T19:10:20Z","pushed_at":"2014-12-16T23:14:24Z","git_url":"git://github.com/mobify/selector-utils.git","ssh_url":"git@github.com:mobify/selector-utils.git","clone_url":"https://github.com/mobify/selector-utils.git","svn_url":"https://github.com/mobify/selector-utils","homepage":"","size":676,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/selector-utils/pulls/12"},"html":{"href":"https://github.com/mobify/selector-utils/pull/12"},"issue":{"href":"https://api.github.com/repos/mobify/selector-utils/issues/12"},"comments":{"href":"https://api.github.com/repos/mobify/selector-utils/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/selector-utils/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/selector-utils/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mobify/selector-utils/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/selector-utils/statuses/2fea1bf17a25760dd32e7043cad07c3c31b68769"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":156,"deletions":1,"changed_files":4}}