GitHub PullRequestReviewCommentEvent at 2014-07-21 09:53:35
Repository: crosswalk
Actor: rakuco
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/15161210","id":15161210,"diff_hunk":"@@ -158,6 +169,178 @@ class URLRequestApplicationJob : public net::URLRequestFileJob {\n   base::WeakPtrFactory<URLRequestApplicationJob> weak_factory_;\n };\n \n+#if defined(OS_TIZEN)\n+class URLRequestAppEncryptedFileJob : public net::URLRequestJob {","path":"application/browser/application_protocols.cc","position":46,"original_position":46,"commit_id":"a3090236e6573560ec9d8db83da730f6784a38bd","original_commit_id":"a3090236e6573560ec9d8db83da730f6784a38bd","user":{"login":"rakuco","id":36417,"avatar_url":"https://avatars.githubusercontent.com/u/36417?","gravatar_id":null,"url":"https://api.github.com/users/rakuco","html_url":"https://github.com/rakuco","followers_url":"https://api.github.com/users/rakuco/followers","following_url":"https://api.github.com/users/rakuco/following{/other_user}","gists_url":"https://api.github.com/users/rakuco/gists{/gist_id}","starred_url":"https://api.github.com/users/rakuco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakuco/subscriptions","organizations_url":"https://api.github.com/users/rakuco/orgs","repos_url":"https://api.github.com/users/rakuco/repos","events_url":"https://api.github.com/users/rakuco/events{/privacy}","received_events_url":"https://api.github.com/users/rakuco/received_events","type":"User","site_admin":false},"body":"This is huge, and is probably going to be a PITA to maintain across Chromium releases. Are you sure you need to reimplement so much code?","created_at":"2014-07-21T09:53:35Z","updated_at":"2014-07-21T09:53:35Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/2211#discussion_r15161210","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2211","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/15161210"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/2211#discussion_r15161210"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2211"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2211","id":18640728,"html_url":"https://github.com/crosswalk-project/crosswalk/pull/2211","diff_url":"https://github.com/crosswalk-project/crosswalk/pull/2211.diff","patch_url":"https://github.com/crosswalk-project/crosswalk/pull/2211.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2211","number":2211,"state":"open","title":"[Tizen] Application resource protection implementation","user":{"login":"yejingfu","id":3795602,"avatar_url":"https://avatars.githubusercontent.com/u/3795602?","gravatar_id":"0a2c219dc07d893d88e0486fa738bcd5","url":"https://api.github.com/users/yejingfu","html_url":"https://github.com/yejingfu","followers_url":"https://api.github.com/users/yejingfu/followers","following_url":"https://api.github.com/users/yejingfu/following{/other_user}","gists_url":"https://api.github.com/users/yejingfu/gists{/gist_id}","starred_url":"https://api.github.com/users/yejingfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yejingfu/subscriptions","organizations_url":"https://api.github.com/users/yejingfu/orgs","repos_url":"https://api.github.com/users/yejingfu/repos","events_url":"https://api.github.com/users/yejingfu/events{/privacy}","received_events_url":"https://api.github.com/users/yejingfu/received_events","type":"User","site_admin":false},"body":"This is the first commit which includes:\r\n- Add the attribute \"encryption\" in the tizen:setting in config.xml.\r\n- If the value is \"enable\", the WRT must encrypt the HTML, CSS, JS file resources when the application is installed. And the WRT should be able to decrypt the encrypted data when the application is loaded for running. According to the spec, the encryption is performed at the installation moment (not at packaging time).\r\n\r\nFor security consideration, I do not implement the encyption & decryption algorithm. They need supports from the system level, such as the trust-zone on ARM or chaabi on IA. But at this moment the Tizen does not include such the security module. Another solution may be storing the security key within system-level storage like gnome-keyring or some external / internal storage. However this is still not supported by Tizen. So at present I leave the encryption & decryption not implemented until we get support from system in the future. I will be back to finish the feature when the security module is available at system-level.\r\n\r\nXWALK-1172","created_at":"2014-07-21T07:22:24Z","updated_at":"2014-07-21T09:53:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b44b0c7925d52b491bfe1b3b6c33ed56a9225d72","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2211/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2211/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2211/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/a3090236e6573560ec9d8db83da730f6784a38bd","head":{"label":"yejingfu:resource-protection","ref":"resource-protection","sha":"a3090236e6573560ec9d8db83da730f6784a38bd","user":{"login":"yejingfu","id":3795602,"avatar_url":"https://avatars.githubusercontent.com/u/3795602?","gravatar_id":"0a2c219dc07d893d88e0486fa738bcd5","url":"https://api.github.com/users/yejingfu","html_url":"https://github.com/yejingfu","followers_url":"https://api.github.com/users/yejingfu/followers","following_url":"https://api.github.com/users/yejingfu/following{/other_user}","gists_url":"https://api.github.com/users/yejingfu/gists{/gist_id}","starred_url":"https://api.github.com/users/yejingfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yejingfu/subscriptions","organizations_url":"https://api.github.com/users/yejingfu/orgs","repos_url":"https://api.github.com/users/yejingfu/repos","events_url":"https://api.github.com/users/yejingfu/events{/privacy}","received_events_url":"https://api.github.com/users/yejingfu/received_events","type":"User","site_admin":false},"repo":{"id":21030425,"name":"crosswalk","full_name":"yejingfu/crosswalk","owner":{"login":"yejingfu","id":3795602,"avatar_url":"https://avatars.githubusercontent.com/u/3795602?","gravatar_id":"0a2c219dc07d893d88e0486fa738bcd5","url":"https://api.github.com/users/yejingfu","html_url":"https://github.com/yejingfu","followers_url":"https://api.github.com/users/yejingfu/followers","following_url":"https://api.github.com/users/yejingfu/following{/other_user}","gists_url":"https://api.github.com/users/yejingfu/gists{/gist_id}","starred_url":"https://api.github.com/users/yejingfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yejingfu/subscriptions","organizations_url":"https://api.github.com/users/yejingfu/orgs","repos_url":"https://api.github.com/users/yejingfu/repos","events_url":"https://api.github.com/users/yejingfu/events{/privacy}","received_events_url":"https://api.github.com/users/yejingfu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yejingfu/crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/yejingfu/crosswalk","forks_url":"https://api.github.com/repos/yejingfu/crosswalk/forks","keys_url":"https://api.github.com/repos/yejingfu/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yejingfu/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yejingfu/crosswalk/teams","hooks_url":"https://api.github.com/repos/yejingfu/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/yejingfu/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/yejingfu/crosswalk/events","assignees_url":"https://api.github.com/repos/yejingfu/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/yejingfu/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/yejingfu/crosswalk/tags","blobs_url":"https://api.github.com/repos/yejingfu/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yejingfu/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yejingfu/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/yejingfu/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yejingfu/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/yejingfu/crosswalk/languages","stargazers_url":"https://api.github.com/repos/yejingfu/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/yejingfu/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/yejingfu/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/yejingfu/crosswalk/subscription","commits_url":"https://api.github.com/repos/yejingfu/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/yejingfu/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/yejingfu/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/yejingfu/crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/yejingfu/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/yejingfu/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yejingfu/crosswalk/merges","archive_url":"https://api.github.com/repos/yejingfu/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yejingfu/crosswalk/downloads","issues_url":"https://api.github.com/repos/yejingfu/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/yejingfu/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/yejingfu/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/yejingfu/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yejingfu/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/yejingfu/crosswalk/releases{/id}","created_at":"2014-06-20T08:12:09Z","updated_at":"2014-07-02T08:47:50Z","pushed_at":"2014-07-21T07:20:03Z","git_url":"git://github.com/yejingfu/crosswalk.git","ssh_url":"git@github.com:yejingfu/crosswalk.git","clone_url":"https://github.com/yejingfu/crosswalk.git","svn_url":"https://github.com/yejingfu/crosswalk","homepage":"","size":9669,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"36849e95b15af0795d965c3ae623d759f9708a46","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?","gravatar_id":"92669bf554412548daa0c4b8d74b861e","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":9207280,"name":"crosswalk","full_name":"crosswalk-project/crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?","gravatar_id":"92669bf554412548daa0c4b8d74b861e","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk","description":"465a7a1bdee77895be20653fc6244bf53df0dcd5","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk/releases{/id}","created_at":"2013-04-03T23:30:12Z","updated_at":"2014-07-21T08:37:35Z","pushed_at":"2014-07-21T09:17:02Z","git_url":"git://github.com/crosswalk-project/crosswalk.git","ssh_url":"git@github.com:crosswalk-project/crosswalk.git","clone_url":"https://github.com/crosswalk-project/crosswalk.git","svn_url":"https://github.com/crosswalk-project/crosswalk","homepage":"","size":54288,"stargazers_count":281,"watchers_count":281,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":105,"mirror_url":null,"open_issues_count":105,"forks":105,"open_issues":105,"watchers":281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2211"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/2211"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2211"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2211/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2211/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2211/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/a3090236e6573560ec9d8db83da730f6784a38bd"}}}}