GitHub PullRequestEvent at 2014-02-07 13:39:05
Repository: pymssql
Actor: ramiro
Payload: {"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/ramiro/pymssql/pulls/2","id":12301045,"html_url":"https://github.com/ramiro/pymssql/pull/2","diff_url":"https://github.com/ramiro/pymssql/pull/2.diff","patch_url":"https://github.com/ramiro/pymssql/pull/2.patch","issue_url":"https://api.github.com/repos/ramiro/pymssql/issues/2","number":2,"state":"closed","title":"convert_python_value: For uuid, don't check python version","user":{"login":"msabramo","id":305268,"avatar_url":"https://gravatar.com/avatar/3d91a2f54a0ad7f3044458a064ea7a84?d=https%3A%2F%2Fidenticons.github.com%2F0d145b716defe62e054bf09c2e78a9e4.png&r=x","gravatar_id":"3d91a2f54a0ad7f3044458a064ea7a84","url":"https://api.github.com/users/msabramo","html_url":"https://github.com/msabramo","followers_url":"https://api.github.com/users/msabramo/followers","following_url":"https://api.github.com/users/msabramo/following{/other_user}","gists_url":"https://api.github.com/users/msabramo/gists{/gist_id}","starred_url":"https://api.github.com/users/msabramo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabramo/subscriptions","organizations_url":"https://api.github.com/users/msabramo/orgs","repos_url":"https://api.github.com/users/msabramo/repos","events_url":"https://api.github.com/users/msabramo/events{/privacy}","received_events_url":"https://api.github.com/users/msabramo/received_events","type":"User","site_admin":false},"body":"For uuid, don't check `PY_MAJOR_VERSION >= 2 and PY_MINOR_VERSION >= 5`.\r\n\r\nThis is incorrect for Python 3.3. I think you copied it from another part of the code (I removed it in https://github.com/pymssql/pymssql/commit/1fe0ea1)\r\n\r\nSince we don't support Python < 2.6, we can just remove this check.","created_at":"2014-02-07T06:01:57Z","updated_at":"2014-02-07T13:39:04Z","closed_at":"2014-02-07T13:39:04Z","merged_at":null,"merge_commit_sha":"214bb3072510096fdf7982f4f81ecf07463f1767","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ramiro/pymssql/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ramiro/pymssql/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ramiro/pymssql/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ramiro/pymssql/issues/2/comments","statuses_url":"https://api.github.com/repos/ramiro/pymssql/statuses/d610b3ac75374953a413af546a0dda0d18c67ae6","head":{"label":"msabramo:ramiro-uuids-in-sp-input-params","ref":"ramiro-uuids-in-sp-input-params","sha":"d610b3ac75374953a413af546a0dda0d18c67ae6","user":{"login":"msabramo","id":305268,"avatar_url":"https://gravatar.com/avatar/3d91a2f54a0ad7f3044458a064ea7a84?d=https%3A%2F%2Fidenticons.github.com%2F0d145b716defe62e054bf09c2e78a9e4.png&r=x","gravatar_id":"3d91a2f54a0ad7f3044458a064ea7a84","url":"https://api.github.com/users/msabramo","html_url":"https://github.com/msabramo","followers_url":"https://api.github.com/users/msabramo/followers","following_url":"https://api.github.com/users/msabramo/following{/other_user}","gists_url":"https://api.github.com/users/msabramo/gists{/gist_id}","starred_url":"https://api.github.com/users/msabramo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabramo/subscriptions","organizations_url":"https://api.github.com/users/msabramo/orgs","repos_url":"https://api.github.com/users/msabramo/repos","events_url":"https://api.github.com/users/msabramo/events{/privacy}","received_events_url":"https://api.github.com/users/msabramo/received_events","type":"User","site_admin":false},"repo":{"id":12704784,"name":"pymssql","full_name":"msabramo/pymssql","owner":{"login":"msabramo","id":305268,"avatar_url":"https://gravatar.com/avatar/3d91a2f54a0ad7f3044458a064ea7a84?d=https%3A%2F%2Fidenticons.github.com%2F0d145b716defe62e054bf09c2e78a9e4.png&r=x","gravatar_id":"3d91a2f54a0ad7f3044458a064ea7a84","url":"https://api.github.com/users/msabramo","html_url":"https://github.com/msabramo","followers_url":"https://api.github.com/users/msabramo/followers","following_url":"https://api.github.com/users/msabramo/following{/other_user}","gists_url":"https://api.github.com/users/msabramo/gists{/gist_id}","starred_url":"https://api.github.com/users/msabramo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabramo/subscriptions","organizations_url":"https://api.github.com/users/msabramo/orgs","repos_url":"https://api.github.com/users/msabramo/repos","events_url":"https://api.github.com/users/msabramo/events{/privacy}","received_events_url":"https://api.github.com/users/msabramo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msabramo/pymssql","description":"My fork of pymssql/pymssql","fork":true,"url":"https://api.github.com/repos/msabramo/pymssql","forks_url":"https://api.github.com/repos/msabramo/pymssql/forks","keys_url":"https://api.github.com/repos/msabramo/pymssql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msabramo/pymssql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msabramo/pymssql/teams","hooks_url":"https://api.github.com/repos/msabramo/pymssql/hooks","issue_events_url":"https://api.github.com/repos/msabramo/pymssql/issues/events{/number}","events_url":"https://api.github.com/repos/msabramo/pymssql/events","assignees_url":"https://api.github.com/repos/msabramo/pymssql/assignees{/user}","branches_url":"https://api.github.com/repos/msabramo/pymssql/branches{/branch}","tags_url":"https://api.github.com/repos/msabramo/pymssql/tags","blobs_url":"https://api.github.com/repos/msabramo/pymssql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msabramo/pymssql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msabramo/pymssql/git/refs{/sha}","trees_url":"https://api.github.com/repos/msabramo/pymssql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msabramo/pymssql/statuses/{sha}","languages_url":"https://api.github.com/repos/msabramo/pymssql/languages","stargazers_url":"https://api.github.com/repos/msabramo/pymssql/stargazers","contributors_url":"https://api.github.com/repos/msabramo/pymssql/contributors","subscribers_url":"https://api.github.com/repos/msabramo/pymssql/subscribers","subscription_url":"https://api.github.com/repos/msabramo/pymssql/subscription","commits_url":"https://api.github.com/repos/msabramo/pymssql/commits{/sha}","git_commits_url":"https://api.github.com/repos/msabramo/pymssql/git/commits{/sha}","comments_url":"https://api.github.com/repos/msabramo/pymssql/comments{/number}","issue_comment_url":"https://api.github.com/repos/msabramo/pymssql/issues/comments/{number}","contents_url":"https://api.github.com/repos/msabramo/pymssql/contents/{+path}","compare_url":"https://api.github.com/repos/msabramo/pymssql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msabramo/pymssql/merges","archive_url":"https://api.github.com/repos/msabramo/pymssql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msabramo/pymssql/downloads","issues_url":"https://api.github.com/repos/msabramo/pymssql/issues{/number}","pulls_url":"https://api.github.com/repos/msabramo/pymssql/pulls{/number}","milestones_url":"https://api.github.com/repos/msabramo/pymssql/milestones{/number}","notifications_url":"https://api.github.com/repos/msabramo/pymssql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msabramo/pymssql/labels{/name}","releases_url":"https://api.github.com/repos/msabramo/pymssql/releases{/id}","created_at":"2013-09-09T15:18:03Z","updated_at":"2014-02-07T06:01:57Z","pushed_at":"2014-02-07T05:59:00Z","git_url":"git://github.com/msabramo/pymssql.git","ssh_url":"git@github.com:msabramo/pymssql.git","clone_url":"https://github.com/msabramo/pymssql.git","svn_url":"https://github.com/msabramo/pymssql","homepage":"","size":8454,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"ramiro:uuids-in-sp-input-params","ref":"uuids-in-sp-input-params","sha":"3442d5c86734ace41eadc66f780473bb490d8a93","user":{"login":"ramiro","id":40661,"avatar_url":"https://gravatar.com/avatar/86bbd1a5d022713ef9c950e707aef675?d=https%3A%2F%2Fidenticons.github.com%2F455465a1662bafac8a32155d1e96ec97.png&r=x","gravatar_id":"86bbd1a5d022713ef9c950e707aef675","url":"https://api.github.com/users/ramiro","html_url":"https://github.com/ramiro","followers_url":"https://api.github.com/users/ramiro/followers","following_url":"https://api.github.com/users/ramiro/following{/other_user}","gists_url":"https://api.github.com/users/ramiro/gists{/gist_id}","starred_url":"https://api.github.com/users/ramiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramiro/subscriptions","organizations_url":"https://api.github.com/users/ramiro/orgs","repos_url":"https://api.github.com/users/ramiro/repos","events_url":"https://api.github.com/users/ramiro/events{/privacy}","received_events_url":"https://api.github.com/users/ramiro/received_events","type":"User","site_admin":false},"repo":{"id":12715172,"name":"pymssql","full_name":"ramiro/pymssql","owner":{"login":"ramiro","id":40661,"avatar_url":"https://gravatar.com/avatar/86bbd1a5d022713ef9c950e707aef675?d=https%3A%2F%2Fidenticons.github.com%2F455465a1662bafac8a32155d1e96ec97.png&r=x","gravatar_id":"86bbd1a5d022713ef9c950e707aef675","url":"https://api.github.com/users/ramiro","html_url":"https://github.com/ramiro","followers_url":"https://api.github.com/users/ramiro/followers","following_url":"https://api.github.com/users/ramiro/following{/other_user}","gists_url":"https://api.github.com/users/ramiro/gists{/gist_id}","starred_url":"https://api.github.com/users/ramiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramiro/subscriptions","organizations_url":"https://api.github.com/users/ramiro/orgs","repos_url":"https://api.github.com/users/ramiro/repos","events_url":"https://api.github.com/users/ramiro/events{/privacy}","received_events_url":"https://api.github.com/users/ramiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramiro/pymssql","description":"The new official home for pymssql","fork":true,"url":"https://api.github.com/repos/ramiro/pymssql","forks_url":"https://api.github.com/repos/ramiro/pymssql/forks","keys_url":"https://api.github.com/repos/ramiro/pymssql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramiro/pymssql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramiro/pymssql/teams","hooks_url":"https://api.github.com/repos/ramiro/pymssql/hooks","issue_events_url":"https://api.github.com/repos/ramiro/pymssql/issues/events{/number}","events_url":"https://api.github.com/repos/ramiro/pymssql/events","assignees_url":"https://api.github.com/repos/ramiro/pymssql/assignees{/user}","branches_url":"https://api.github.com/repos/ramiro/pymssql/branches{/branch}","tags_url":"https://api.github.com/repos/ramiro/pymssql/tags","blobs_url":"https://api.github.com/repos/ramiro/pymssql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramiro/pymssql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramiro/pymssql/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramiro/pymssql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramiro/pymssql/statuses/{sha}","languages_url":"https://api.github.com/repos/ramiro/pymssql/languages","stargazers_url":"https://api.github.com/repos/ramiro/pymssql/stargazers","contributors_url":"https://api.github.com/repos/ramiro/pymssql/contributors","subscribers_url":"https://api.github.com/repos/ramiro/pymssql/subscribers","subscription_url":"https://api.github.com/repos/ramiro/pymssql/subscription","commits_url":"https://api.github.com/repos/ramiro/pymssql/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramiro/pymssql/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramiro/pymssql/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramiro/pymssql/issues/comments/{number}","contents_url":"https://api.github.com/repos/ramiro/pymssql/contents/{+path}","compare_url":"https://api.github.com/repos/ramiro/pymssql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramiro/pymssql/merges","archive_url":"https://api.github.com/repos/ramiro/pymssql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramiro/pymssql/downloads","issues_url":"https://api.github.com/repos/ramiro/pymssql/issues{/number}","pulls_url":"https://api.github.com/repos/ramiro/pymssql/pulls{/number}","milestones_url":"https://api.github.com/repos/ramiro/pymssql/milestones{/number}","notifications_url":"https://api.github.com/repos/ramiro/pymssql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramiro/pymssql/labels{/name}","releases_url":"https://api.github.com/repos/ramiro/pymssql/releases{/id}","created_at":"2013-09-09T23:09:18Z","updated_at":"2014-01-14T00:36:52Z","pushed_at":"2014-01-13T20:31:51Z","git_url":"git://github.com/ramiro/pymssql.git","ssh_url":"git@github.com:ramiro/pymssql.git","clone_url":"https://github.com/ramiro/pymssql.git","svn_url":"https://github.com/ramiro/pymssql","homepage":null,"size":8451,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ramiro/pymssql/pulls/2"},"html":{"href":"https://github.com/ramiro/pymssql/pull/2"},"issue":{"href":"https://api.github.com/repos/ramiro/pymssql/issues/2"},"comments":{"href":"https://api.github.com/repos/ramiro/pymssql/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ramiro/pymssql/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ramiro/pymssql/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ramiro/pymssql/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ramiro/pymssql/statuses/d610b3ac75374953a413af546a0dda0d18c67ae6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}