GitHub PullRequestReviewCommentEvent at 2014-06-12 08:56:04
Repository: iris
Actor: bjlittle
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SciTools/iris/pulls/comments/13692607","id":13692607,"diff_hunk":"@@ -1605,5 +1605,17 @@ def save(cube, filename, netcdf_format='NETCDF4', local_keys=None,\n                        shuffle, fletcher32, contiguous, chunksizes, endian,\n                        least_significant_digit)\n \n+        conventions = _CF_CONVENTIONS_VERSION\n+\n+        # Perform a CF patch of the conventions attribute.\n+        cf_profile_available = (\n+            'cf_profile' in iris.site_configuration and\n+            iris.site_configuration['cf_profile'] not in [None, False])\n+        if cf_profile_available:\n+            cf_patch_conventions = iris.site_configuration.get(\n+                'cf_patch_conventions')","path":"lib/iris/fileformats/netcdf.py","position":12,"original_position":12,"commit_id":"7ea01e1dcc1e8e97003225e61fb5e87db57479d4","original_commit_id":"7ea01e1dcc1e8e97003225e61fb5e87db57479d4","user":{"login":"bjlittle","id":2051656,"avatar_url":"https://avatars.githubusercontent.com/u/2051656?","gravatar_id":"907798185f1ed99aead3bb410977197b","url":"https://api.github.com/users/bjlittle","html_url":"https://github.com/bjlittle","followers_url":"https://api.github.com/users/bjlittle/followers","following_url":"https://api.github.com/users/bjlittle/following{/other_user}","gists_url":"https://api.github.com/users/bjlittle/gists{/gist_id}","starred_url":"https://api.github.com/users/bjlittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjlittle/subscriptions","organizations_url":"https://api.github.com/users/bjlittle/orgs","repos_url":"https://api.github.com/users/bjlittle/repos","events_url":"https://api.github.com/users/bjlittle/events{/privacy}","received_events_url":"https://api.github.com/users/bjlittle/received_events","type":"User","site_admin":false},"body":"@cpelley I like your use of `get` here ... since we're in this space do you think that you could apply the same to line +718 for the `cf_patch` hook?","created_at":"2014-06-12T08:56:04Z","updated_at":"2014-06-12T08:56:04Z","html_url":"https://github.com/SciTools/iris/pull/1172#discussion_r13692607","pull_request_url":"https://api.github.com/repos/SciTools/iris/pulls/1172","_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/13692607"},"html":{"href":"https://github.com/SciTools/iris/pull/1172#discussion_r13692607"},"pull_request":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1172"}}},"pull_request":{"url":"https://api.github.com/repos/SciTools/iris/pulls/1172","id":16994100,"html_url":"https://github.com/SciTools/iris/pull/1172","diff_url":"https://github.com/SciTools/iris/pull/1172.diff","patch_url":"https://github.com/SciTools/iris/pull/1172.patch","issue_url":"https://api.github.com/repos/SciTools/iris/issues/1172","number":1172,"state":"open","title":"ENH: Support for patching conventions.","user":{"login":"cpelley","id":2071643,"avatar_url":"https://avatars.githubusercontent.com/u/2071643?","gravatar_id":"0301d4c954ffec1f934bee9b9fd6805f","url":"https://api.github.com/users/cpelley","html_url":"https://github.com/cpelley","followers_url":"https://api.github.com/users/cpelley/followers","following_url":"https://api.github.com/users/cpelley/following{/other_user}","gists_url":"https://api.github.com/users/cpelley/gists{/gist_id}","starred_url":"https://api.github.com/users/cpelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpelley/subscriptions","organizations_url":"https://api.github.com/users/cpelley/orgs","repos_url":"https://api.github.com/users/cpelley/repos","events_url":"https://api.github.com/users/cpelley/events{/privacy}","received_events_url":"https://api.github.com/users/cpelley/received_events","type":"User","site_admin":false},"body":"This allows iris to handle patching of the conventions global attribute via a defined `cf_patch_conventions` function.","created_at":"2014-06-11T12:19:21Z","updated_at":"2014-06-12T08:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bca6c2dac11b1f70b97f1c9e0fefd70b3a71c977","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SciTools/iris/pulls/1172/commits","review_comments_url":"https://api.github.com/repos/SciTools/iris/pulls/1172/comments","review_comment_url":"https://api.github.com/repos/SciTools/iris/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SciTools/iris/issues/1172/comments","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/7ea01e1dcc1e8e97003225e61fb5e87db57479d4","head":{"label":"cpelley:monet_convention","ref":"monet_convention","sha":"7ea01e1dcc1e8e97003225e61fb5e87db57479d4","user":{"login":"cpelley","id":2071643,"avatar_url":"https://avatars.githubusercontent.com/u/2071643?","gravatar_id":"0301d4c954ffec1f934bee9b9fd6805f","url":"https://api.github.com/users/cpelley","html_url":"https://github.com/cpelley","followers_url":"https://api.github.com/users/cpelley/followers","following_url":"https://api.github.com/users/cpelley/following{/other_user}","gists_url":"https://api.github.com/users/cpelley/gists{/gist_id}","starred_url":"https://api.github.com/users/cpelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpelley/subscriptions","organizations_url":"https://api.github.com/users/cpelley/orgs","repos_url":"https://api.github.com/users/cpelley/repos","events_url":"https://api.github.com/users/cpelley/events{/privacy}","received_events_url":"https://api.github.com/users/cpelley/received_events","type":"User","site_admin":false},"repo":{"id":6763274,"name":"iris","full_name":"cpelley/iris","owner":{"login":"cpelley","id":2071643,"avatar_url":"https://avatars.githubusercontent.com/u/2071643?","gravatar_id":"0301d4c954ffec1f934bee9b9fd6805f","url":"https://api.github.com/users/cpelley","html_url":"https://github.com/cpelley","followers_url":"https://api.github.com/users/cpelley/followers","following_url":"https://api.github.com/users/cpelley/following{/other_user}","gists_url":"https://api.github.com/users/cpelley/gists{/gist_id}","starred_url":"https://api.github.com/users/cpelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpelley/subscriptions","organizations_url":"https://api.github.com/users/cpelley/orgs","repos_url":"https://api.github.com/users/cpelley/repos","events_url":"https://api.github.com/users/cpelley/events{/privacy}","received_events_url":"https://api.github.com/users/cpelley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpelley/iris","description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","fork":true,"url":"https://api.github.com/repos/cpelley/iris","forks_url":"https://api.github.com/repos/cpelley/iris/forks","keys_url":"https://api.github.com/repos/cpelley/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpelley/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpelley/iris/teams","hooks_url":"https://api.github.com/repos/cpelley/iris/hooks","issue_events_url":"https://api.github.com/repos/cpelley/iris/issues/events{/number}","events_url":"https://api.github.com/repos/cpelley/iris/events","assignees_url":"https://api.github.com/repos/cpelley/iris/assignees{/user}","branches_url":"https://api.github.com/repos/cpelley/iris/branches{/branch}","tags_url":"https://api.github.com/repos/cpelley/iris/tags","blobs_url":"https://api.github.com/repos/cpelley/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpelley/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpelley/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpelley/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpelley/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/cpelley/iris/languages","stargazers_url":"https://api.github.com/repos/cpelley/iris/stargazers","contributors_url":"https://api.github.com/repos/cpelley/iris/contributors","subscribers_url":"https://api.github.com/repos/cpelley/iris/subscribers","subscription_url":"https://api.github.com/repos/cpelley/iris/subscription","commits_url":"https://api.github.com/repos/cpelley/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpelley/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpelley/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpelley/iris/issues/comments/{number}","contents_url":"https://api.github.com/repos/cpelley/iris/contents/{+path}","compare_url":"https://api.github.com/repos/cpelley/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpelley/iris/merges","archive_url":"https://api.github.com/repos/cpelley/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpelley/iris/downloads","issues_url":"https://api.github.com/repos/cpelley/iris/issues{/number}","pulls_url":"https://api.github.com/repos/cpelley/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/cpelley/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/cpelley/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpelley/iris/labels{/name}","releases_url":"https://api.github.com/repos/cpelley/iris/releases{/id}","created_at":"2012-11-19T16:19:57Z","updated_at":"2014-06-11T13:39:29Z","pushed_at":"2014-06-11T13:39:29Z","git_url":"git://github.com/cpelley/iris.git","ssh_url":"git@github.com:cpelley/iris.git","clone_url":"https://github.com/cpelley/iris.git","svn_url":"https://github.com/cpelley/iris","homepage":"http://scitools.org.uk/iris/","size":79493,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"null"}},"base":{"label":"SciTools:master","ref":"master","sha":"a3734a4c801d0e7c65c4e042b39b47d697faea97","user":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?","gravatar_id":null,"url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":5312648,"name":"iris","full_name":"SciTools/iris","owner":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?","gravatar_id":null,"url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciTools/iris","description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","fork":false,"url":"https://api.github.com/repos/SciTools/iris","forks_url":"https://api.github.com/repos/SciTools/iris/forks","keys_url":"https://api.github.com/repos/SciTools/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/iris/teams","hooks_url":"https://api.github.com/repos/SciTools/iris/hooks","issue_events_url":"https://api.github.com/repos/SciTools/iris/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/iris/events","assignees_url":"https://api.github.com/repos/SciTools/iris/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/iris/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/iris/tags","blobs_url":"https://api.github.com/repos/SciTools/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/iris/languages","stargazers_url":"https://api.github.com/repos/SciTools/iris/stargazers","contributors_url":"https://api.github.com/repos/SciTools/iris/contributors","subscribers_url":"https://api.github.com/repos/SciTools/iris/subscribers","subscription_url":"https://api.github.com/repos/SciTools/iris/subscription","commits_url":"https://api.github.com/repos/SciTools/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/iris/issues/comments/{number}","contents_url":"https://api.github.com/repos/SciTools/iris/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/iris/merges","archive_url":"https://api.github.com/repos/SciTools/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/iris/downloads","issues_url":"https://api.github.com/repos/SciTools/iris/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/iris/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/iris/releases{/id}","created_at":"2012-08-06T10:09:14Z","updated_at":"2014-06-10T12:47:28Z","pushed_at":"2014-06-10T10:27:05Z","git_url":"git://github.com/SciTools/iris.git","ssh_url":"git@github.com:SciTools/iris.git","clone_url":"https://github.com/SciTools/iris.git","svn_url":"https://github.com/SciTools/iris","homepage":"http://scitools.org.uk/iris/","size":127201,"stargazers_count":62,"watchers_count":62,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":51,"mirror_url":null,"open_issues_count":171,"forks":51,"open_issues":171,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1172"},"html":{"href":"https://github.com/SciTools/iris/pull/1172"},"issue":{"href":"https://api.github.com/repos/SciTools/iris/issues/1172"},"comments":{"href":"https://api.github.com/repos/SciTools/iris/issues/1172/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1172/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1172/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/iris/statuses/7ea01e1dcc1e8e97003225e61fb5e87db57479d4"}}}}