GitHub PullRequestReviewCommentEvent at 2014-09-04 14:12:53
Repository: govuk_frontend_toolkit_gem
Actor: edds
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls/comments/17115088","id":17115088,"diff_hunk":"@@ -1,8 +1,34 @@\n #!/bin/sh\n set -e\n-git submodule init\n-git submodule update\n+\n+# Checkout master as we are currently have an individual commit checked out on\n+# a detached tree. This means when we commit later it will be on a branch\n+git reset --hard origin/master\n+git checkout master","path":"jenkins.sh","position":null,"original_position":9,"commit_id":"558b0eb8cdb82eda12bae446f29921758eee8995","original_commit_id":"4e1d9c46818d0682f1b711683e00bc5496fdf429","user":{"login":"edds","id":35035,"avatar_url":"https://avatars.githubusercontent.com/u/35035?v=2","gravatar_id":"5ce91fa49a613cbc3e20d5f96856473f","url":"https://api.github.com/users/edds","html_url":"https://github.com/edds","followers_url":"https://api.github.com/users/edds/followers","following_url":"https://api.github.com/users/edds/following{/other_user}","gists_url":"https://api.github.com/users/edds/gists{/gist_id}","starred_url":"https://api.github.com/users/edds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edds/subscriptions","organizations_url":"https://api.github.com/users/edds/orgs","repos_url":"https://api.github.com/users/edds/repos","events_url":"https://api.github.com/users/edds/events{/privacy}","received_events_url":"https://api.github.com/users/edds/received_events","type":"User","site_admin":false},"body":"fixed in 558b0eb","created_at":"2014-09-04T14:12:53Z","updated_at":"2014-09-04T14:12:53Z","html_url":"https://github.com/alphagov/govuk_frontend_toolkit_gem/pull/8#discussion_r17115088","pull_request_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls/comments/17115088"},"html":{"href":"https://github.com/alphagov/govuk_frontend_toolkit_gem/pull/8#discussion_r17115088"},"pull_request":{"href":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls/8","id":20729454,"html_url":"https://github.com/alphagov/govuk_frontend_toolkit_gem/pull/8","diff_url":"https://github.com/alphagov/govuk_frontend_toolkit_gem/pull/8.diff","patch_url":"https://github.com/alphagov/govuk_frontend_toolkit_gem/pull/8.patch","issue_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/issues/8","number":8,"state":"open","locked":false,"title":"Bump to 1.6.1 and use version from submodule","user":{"login":"edds","id":35035,"avatar_url":"https://avatars.githubusercontent.com/u/35035?v=2","gravatar_id":"5ce91fa49a613cbc3e20d5f96856473f","url":"https://api.github.com/users/edds","html_url":"https://github.com/edds","followers_url":"https://api.github.com/users/edds/followers","following_url":"https://api.github.com/users/edds/following{/other_user}","gists_url":"https://api.github.com/users/edds/gists{/gist_id}","starred_url":"https://api.github.com/users/edds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edds/subscriptions","organizations_url":"https://api.github.com/users/edds/orgs","repos_url":"https://api.github.com/users/edds/repos","events_url":"https://api.github.com/users/edds/events{/privacy}","received_events_url":"https://api.github.com/users/edds/received_events","type":"User","site_admin":false},"body":"Use the version from the submodule for the gem version. So it is\r\nconsistent with other types of toolkit packages.\r\n\r\nChange the jenins.sh to update the version of the submodule as part of jenkins.sh and commit the updated submodule after the gem has been published. I can then update jenkins to push the master branch as a post build step.","created_at":"2014-09-04T08:47:02Z","updated_at":"2014-09-04T14:12:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9326d6e6ce1076135f99af63b92f92b459cad659","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls/8/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls/8/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/issues/8/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/statuses/558b0eb8cdb82eda12bae446f29921758eee8995","head":{"label":"alphagov:version-from-submodule","ref":"version-from-submodule","sha":"558b0eb8cdb82eda12bae446f29921758eee8995","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":8459112,"name":"govuk_frontend_toolkit_gem","full_name":"alphagov/govuk_frontend_toolkit_gem","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk_frontend_toolkit_gem","description":"A gem wrapper around the govuk_frontend_toolkit files to enable easy integration with Rails","fork":false,"url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem","forks_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/forks","keys_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/events","assignees_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/merges","archive_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/releases{/id}","created_at":"2013-02-27T15:37:17Z","updated_at":"2014-09-03T13:08:14Z","pushed_at":"2014-09-04T14:12:23Z","git_url":"git://github.com/alphagov/govuk_frontend_toolkit_gem.git","ssh_url":"git@github.com:alphagov/govuk_frontend_toolkit_gem.git","clone_url":"https://github.com/alphagov/govuk_frontend_toolkit_gem.git","svn_url":"https://github.com/alphagov/govuk_frontend_toolkit_gem","homepage":null,"size":746,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":9,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"977c638aa3b4ed9e92ef967389cb3c69dd2b68cc","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":8459112,"name":"govuk_frontend_toolkit_gem","full_name":"alphagov/govuk_frontend_toolkit_gem","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk_frontend_toolkit_gem","description":"A gem wrapper around the govuk_frontend_toolkit files to enable easy integration with Rails","fork":false,"url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem","forks_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/forks","keys_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/events","assignees_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/merges","archive_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/releases{/id}","created_at":"2013-02-27T15:37:17Z","updated_at":"2014-09-03T13:08:14Z","pushed_at":"2014-09-04T14:12:23Z","git_url":"git://github.com/alphagov/govuk_frontend_toolkit_gem.git","ssh_url":"git@github.com:alphagov/govuk_frontend_toolkit_gem.git","clone_url":"https://github.com/alphagov/govuk_frontend_toolkit_gem.git","svn_url":"https://github.com/alphagov/govuk_frontend_toolkit_gem","homepage":null,"size":746,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls/8"},"html":{"href":"https://github.com/alphagov/govuk_frontend_toolkit_gem/pull/8"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/issues/8"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit_gem/statuses/558b0eb8cdb82eda12bae446f29921758eee8995"}}}}