GitHub PullRequestReviewCommentEvent at 2014-03-14 13:08:13
Repository: zf2
Actor: fabiocarneiro
Payload: {"comment":{"url":"https://api.github.com/repos/zendframework/zf2/pulls/comments/10606180","id":10606180,"diff_hunk":"@@ -217,22 +198,18 @@ public function isValid()\n     /**\n      * {@inheritdoc}\n      */\n-    public function setValidationGroup($name)\n+    public function setValidationGroup($groups)\n     {\n-        if ($name === self::VALIDATE_ALL) {\n+        if ($groups === self::VALIDATE_ALL) {\n             $this->validationGroup = null;\n             return $this;\n         }\n \n-        if (is_array($name)) {\n-            // Best effort check if the validation group was set by a form for BC\n-            if (count($name) == count($this->collectionData) && is_array(reset($name))) {\n-                return parent::setValidationGroup(reset($name));\n-            }\n-            return parent::setValidationGroup($name);\n+        if (is_array($groups)) {\n+            foreach($groups as $group) {\n+                $this->inputFilter->setValidationGroup($group);","path":"library/Zend/InputFilter/CollectionInputFilter.php","position":79,"original_position":79,"commit_id":"3497d381769279f48db895844d784ff3978d7d7c","original_commit_id":"3497d381769279f48db895844d784ff3978d7d7c","user":{"login":"fabiocarneiro","id":1375034,"avatar_url":"https://gravatar.com/avatar/40921315034780a22a45a37953886f61?d=https%3A%2F%2Fidenticons.github.com%2Fef643b323f379bb68bcdc35586edc3a3.png&r=x","gravatar_id":"40921315034780a22a45a37953886f61","url":"https://api.github.com/users/fabiocarneiro","html_url":"https://github.com/fabiocarneiro","followers_url":"https://api.github.com/users/fabiocarneiro/followers","following_url":"https://api.github.com/users/fabiocarneiro/following{/other_user}","gists_url":"https://api.github.com/users/fabiocarneiro/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocarneiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocarneiro/subscriptions","organizations_url":"https://api.github.com/users/fabiocarneiro/orgs","repos_url":"https://api.github.com/users/fabiocarneiro/repos","events_url":"https://api.github.com/users/fabiocarneiro/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocarneiro/received_events","type":"User","site_admin":false},"body":"That is the point. You must overwrite the previous one, since each iteration is dealing with a \"new\" InputFilter.","created_at":"2014-03-14T13:08:13Z","updated_at":"2014-03-14T13:08:13Z","html_url":"https://github.com/zendframework/zf2/pull/5968#discussion_r10606180","pull_request_url":"https://api.github.com/repos/zendframework/zf2/pulls/5968","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/comments/10606180"},"html":{"href":"https://github.com/zendframework/zf2/pull/5968#discussion_r10606180"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/5968"}}}}