GitHub PullRequestReviewCommentEvent at 2014-09-11 04:17:43
Repository: double_entry
Actor: eadz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/envato/double_entry/pulls/comments/17403572","id":17403572,"diff_hunk":"@@ -9,9 +9,16 @@ module DoubleEntry\n   #\n   # Account balances are created on demand when transfers occur.\n   class AccountBalance < ActiveRecord::Base\n-    extend EncapsulateAsMoney\n \n-    encapsulate_as_money :balance","path":"lib/double_entry/account_balance.rb","position":6,"original_position":6,"commit_id":"79cd61ae82047b14d4121e0b15b7945e211cff5d","original_commit_id":"cde2a880d4f5c97da8c98b4342e3096a0f9dd580","user":{"login":"eadz","id":11939,"avatar_url":"https://avatars.githubusercontent.com/u/11939?v=2","gravatar_id":"a9ea609a9224d6aa46d043986257afc0","url":"https://api.github.com/users/eadz","html_url":"https://github.com/eadz","followers_url":"https://api.github.com/users/eadz/followers","following_url":"https://api.github.com/users/eadz/following{/other_user}","gists_url":"https://api.github.com/users/eadz/gists{/gist_id}","starred_url":"https://api.github.com/users/eadz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eadz/subscriptions","organizations_url":"https://api.github.com/users/eadz/orgs","repos_url":"https://api.github.com/users/eadz/repos","events_url":"https://api.github.com/users/eadz/events{/privacy}","received_events_url":"https://api.github.com/users/eadz/received_events","type":"User","site_admin":false},"body":"From my attempts, currency support is specific to double entry. For encapsulate as money, if I wanted currency support I would store the currencies in the DB, but for double entry that doesn't make as much sense ( although one could do that but it would bloat the tables quite a bit). ","created_at":"2014-09-11T04:17:43Z","updated_at":"2014-09-11T04:17:43Z","html_url":"https://github.com/envato/double_entry/pull/53#discussion_r17403572","pull_request_url":"https://api.github.com/repos/envato/double_entry/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/envato/double_entry/pulls/comments/17403572"},"html":{"href":"https://github.com/envato/double_entry/pull/53#discussion_r17403572"},"pull_request":{"href":"https://api.github.com/repos/envato/double_entry/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/envato/double_entry/pulls/53","id":19263444,"html_url":"https://github.com/envato/double_entry/pull/53","diff_url":"https://github.com/envato/double_entry/pull/53.diff","patch_url":"https://github.com/envato/double_entry/pull/53.patch","issue_url":"https://api.github.com/repos/envato/double_entry/issues/53","number":53,"state":"open","locked":false,"title":"Add currency support","user":{"login":"eadz","id":11939,"avatar_url":"https://avatars.githubusercontent.com/u/11939?v=2","gravatar_id":"a9ea609a9224d6aa46d043986257afc0","url":"https://api.github.com/users/eadz","html_url":"https://github.com/eadz","followers_url":"https://api.github.com/users/eadz/followers","following_url":"https://api.github.com/users/eadz/following{/other_user}","gists_url":"https://api.github.com/users/eadz/gists{/gist_id}","starred_url":"https://api.github.com/users/eadz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eadz/subscriptions","organizations_url":"https://api.github.com/users/eadz/orgs","repos_url":"https://api.github.com/users/eadz/repos","events_url":"https://api.github.com/users/eadz/events{/privacy}","received_events_url":"https://api.github.com/users/eadz/received_events","type":"User","site_admin":false},"body":"* adds the option to set the default currency\r\n* adds per-account currency settings\r\n* all balances are in the defined currency for the account\r\n* multiple currencies are supported\r\n\r\n![image](https://cloud.githubusercontent.com/assets/11939/3793394/2b793d5e-1b96-11e4-8020-5414318dda2e.png)\r\n","created_at":"2014-08-04T03:10:58Z","updated_at":"2014-09-11T04:17:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0628ebf9a77d7eed74dd8ac9b8cbd86c2349b259","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/envato/double_entry/pulls/53/commits","review_comments_url":"https://api.github.com/repos/envato/double_entry/pulls/53/comments","review_comment_url":"https://api.github.com/repos/envato/double_entry/pulls/comments/{number}","comments_url":"https://api.github.com/repos/envato/double_entry/issues/53/comments","statuses_url":"https://api.github.com/repos/envato/double_entry/statuses/79cd61ae82047b14d4121e0b15b7945e211cff5d","head":{"label":"eadz:add_currency_support","ref":"add_currency_support","sha":"79cd61ae82047b14d4121e0b15b7945e211cff5d","user":{"login":"eadz","id":11939,"avatar_url":"https://avatars.githubusercontent.com/u/11939?v=2","gravatar_id":"a9ea609a9224d6aa46d043986257afc0","url":"https://api.github.com/users/eadz","html_url":"https://github.com/eadz","followers_url":"https://api.github.com/users/eadz/followers","following_url":"https://api.github.com/users/eadz/following{/other_user}","gists_url":"https://api.github.com/users/eadz/gists{/gist_id}","starred_url":"https://api.github.com/users/eadz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eadz/subscriptions","organizations_url":"https://api.github.com/users/eadz/orgs","repos_url":"https://api.github.com/users/eadz/repos","events_url":"https://api.github.com/users/eadz/events{/privacy}","received_events_url":"https://api.github.com/users/eadz/received_events","type":"User","site_admin":false},"repo":{"id":22187390,"name":"double_entry","full_name":"eadz/double_entry","owner":{"login":"eadz","id":11939,"avatar_url":"https://avatars.githubusercontent.com/u/11939?v=2","gravatar_id":"a9ea609a9224d6aa46d043986257afc0","url":"https://api.github.com/users/eadz","html_url":"https://github.com/eadz","followers_url":"https://api.github.com/users/eadz/followers","following_url":"https://api.github.com/users/eadz/following{/other_user}","gists_url":"https://api.github.com/users/eadz/gists{/gist_id}","starred_url":"https://api.github.com/users/eadz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eadz/subscriptions","organizations_url":"https://api.github.com/users/eadz/orgs","repos_url":"https://api.github.com/users/eadz/repos","events_url":"https://api.github.com/users/eadz/events{/privacy}","received_events_url":"https://api.github.com/users/eadz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eadz/double_entry","description":"","fork":true,"url":"https://api.github.com/repos/eadz/double_entry","forks_url":"https://api.github.com/repos/eadz/double_entry/forks","keys_url":"https://api.github.com/repos/eadz/double_entry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eadz/double_entry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eadz/double_entry/teams","hooks_url":"https://api.github.com/repos/eadz/double_entry/hooks","issue_events_url":"https://api.github.com/repos/eadz/double_entry/issues/events{/number}","events_url":"https://api.github.com/repos/eadz/double_entry/events","assignees_url":"https://api.github.com/repos/eadz/double_entry/assignees{/user}","branches_url":"https://api.github.com/repos/eadz/double_entry/branches{/branch}","tags_url":"https://api.github.com/repos/eadz/double_entry/tags","blobs_url":"https://api.github.com/repos/eadz/double_entry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eadz/double_entry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eadz/double_entry/git/refs{/sha}","trees_url":"https://api.github.com/repos/eadz/double_entry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eadz/double_entry/statuses/{sha}","languages_url":"https://api.github.com/repos/eadz/double_entry/languages","stargazers_url":"https://api.github.com/repos/eadz/double_entry/stargazers","contributors_url":"https://api.github.com/repos/eadz/double_entry/contributors","subscribers_url":"https://api.github.com/repos/eadz/double_entry/subscribers","subscription_url":"https://api.github.com/repos/eadz/double_entry/subscription","commits_url":"https://api.github.com/repos/eadz/double_entry/commits{/sha}","git_commits_url":"https://api.github.com/repos/eadz/double_entry/git/commits{/sha}","comments_url":"https://api.github.com/repos/eadz/double_entry/comments{/number}","issue_comment_url":"https://api.github.com/repos/eadz/double_entry/issues/comments/{number}","contents_url":"https://api.github.com/repos/eadz/double_entry/contents/{+path}","compare_url":"https://api.github.com/repos/eadz/double_entry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eadz/double_entry/merges","archive_url":"https://api.github.com/repos/eadz/double_entry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eadz/double_entry/downloads","issues_url":"https://api.github.com/repos/eadz/double_entry/issues{/number}","pulls_url":"https://api.github.com/repos/eadz/double_entry/pulls{/number}","milestones_url":"https://api.github.com/repos/eadz/double_entry/milestones{/number}","notifications_url":"https://api.github.com/repos/eadz/double_entry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eadz/double_entry/labels{/name}","releases_url":"https://api.github.com/repos/eadz/double_entry/releases{/id}","created_at":"2014-07-24T00:00:31Z","updated_at":"2014-08-06T05:09:47Z","pushed_at":"2014-09-11T04:15:50Z","git_url":"git://github.com/eadz/double_entry.git","ssh_url":"git@github.com:eadz/double_entry.git","clone_url":"https://github.com/eadz/double_entry.git","svn_url":"https://github.com/eadz/double_entry","homepage":null,"size":625,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envato:master","ref":"master","sha":"ca12550b0bc88bfea2f048ebf25d093dcab9feec","user":{"login":"envato","id":14786,"avatar_url":"https://avatars.githubusercontent.com/u/14786?v=2","gravatar_id":"c1ad027efed3efea605708ae63b25be0","url":"https://api.github.com/users/envato","html_url":"https://github.com/envato","followers_url":"https://api.github.com/users/envato/followers","following_url":"https://api.github.com/users/envato/following{/other_user}","gists_url":"https://api.github.com/users/envato/gists{/gist_id}","starred_url":"https://api.github.com/users/envato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envato/subscriptions","organizations_url":"https://api.github.com/users/envato/orgs","repos_url":"https://api.github.com/users/envato/repos","events_url":"https://api.github.com/users/envato/events{/privacy}","received_events_url":"https://api.github.com/users/envato/received_events","type":"Organization","site_admin":false},"repo":{"id":20909885,"name":"double_entry","full_name":"envato/double_entry","owner":{"login":"envato","id":14786,"avatar_url":"https://avatars.githubusercontent.com/u/14786?v=2","gravatar_id":"c1ad027efed3efea605708ae63b25be0","url":"https://api.github.com/users/envato","html_url":"https://github.com/envato","followers_url":"https://api.github.com/users/envato/followers","following_url":"https://api.github.com/users/envato/following{/other_user}","gists_url":"https://api.github.com/users/envato/gists{/gist_id}","starred_url":"https://api.github.com/users/envato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envato/subscriptions","organizations_url":"https://api.github.com/users/envato/orgs","repos_url":"https://api.github.com/users/envato/repos","events_url":"https://api.github.com/users/envato/events{/privacy}","received_events_url":"https://api.github.com/users/envato/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envato/double_entry","description":"","fork":false,"url":"https://api.github.com/repos/envato/double_entry","forks_url":"https://api.github.com/repos/envato/double_entry/forks","keys_url":"https://api.github.com/repos/envato/double_entry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envato/double_entry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envato/double_entry/teams","hooks_url":"https://api.github.com/repos/envato/double_entry/hooks","issue_events_url":"https://api.github.com/repos/envato/double_entry/issues/events{/number}","events_url":"https://api.github.com/repos/envato/double_entry/events","assignees_url":"https://api.github.com/repos/envato/double_entry/assignees{/user}","branches_url":"https://api.github.com/repos/envato/double_entry/branches{/branch}","tags_url":"https://api.github.com/repos/envato/double_entry/tags","blobs_url":"https://api.github.com/repos/envato/double_entry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envato/double_entry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envato/double_entry/git/refs{/sha}","trees_url":"https://api.github.com/repos/envato/double_entry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envato/double_entry/statuses/{sha}","languages_url":"https://api.github.com/repos/envato/double_entry/languages","stargazers_url":"https://api.github.com/repos/envato/double_entry/stargazers","contributors_url":"https://api.github.com/repos/envato/double_entry/contributors","subscribers_url":"https://api.github.com/repos/envato/double_entry/subscribers","subscription_url":"https://api.github.com/repos/envato/double_entry/subscription","commits_url":"https://api.github.com/repos/envato/double_entry/commits{/sha}","git_commits_url":"https://api.github.com/repos/envato/double_entry/git/commits{/sha}","comments_url":"https://api.github.com/repos/envato/double_entry/comments{/number}","issue_comment_url":"https://api.github.com/repos/envato/double_entry/issues/comments/{number}","contents_url":"https://api.github.com/repos/envato/double_entry/contents/{+path}","compare_url":"https://api.github.com/repos/envato/double_entry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envato/double_entry/merges","archive_url":"https://api.github.com/repos/envato/double_entry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envato/double_entry/downloads","issues_url":"https://api.github.com/repos/envato/double_entry/issues{/number}","pulls_url":"https://api.github.com/repos/envato/double_entry/pulls{/number}","milestones_url":"https://api.github.com/repos/envato/double_entry/milestones{/number}","notifications_url":"https://api.github.com/repos/envato/double_entry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envato/double_entry/labels{/name}","releases_url":"https://api.github.com/repos/envato/double_entry/releases{/id}","created_at":"2014-06-17T04:10:25Z","updated_at":"2014-09-10T09:27:24Z","pushed_at":"2014-09-05T09:49:26Z","git_url":"git://github.com/envato/double_entry.git","ssh_url":"git@github.com:envato/double_entry.git","clone_url":"https://github.com/envato/double_entry.git","svn_url":"https://github.com/envato/double_entry","homepage":null,"size":2654,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envato/double_entry/pulls/53"},"html":{"href":"https://github.com/envato/double_entry/pull/53"},"issue":{"href":"https://api.github.com/repos/envato/double_entry/issues/53"},"comments":{"href":"https://api.github.com/repos/envato/double_entry/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/envato/double_entry/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/envato/double_entry/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/envato/double_entry/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/envato/double_entry/statuses/79cd61ae82047b14d4121e0b15b7945e211cff5d"}}}}