GitHub PullRequestReviewCommentEvent at 2014-05-16 21:31:41
Repository: EntityFramework
Actor: emilcicos
Payload: {"comment":{"url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/12760692","id":12760692,"diff_hunk":"@@ -137,9 +131,22 @@ public class CSharpModelCodeGenerator\n             [NotNull] IProperty property, [NotNull] IndentedStringBuilder stringBuilder)\n         {\n             stringBuilder\n-                .Append(\"ps.Property(e => e.\")\n-                .Append(property.Name)\n-                .Append(\")\");\n+                .Append(\"ps.Property<\")\n+                .Append(CSharpHelper.GetTypeName(property.PropertyType))\n+                .Append(\">(\")\n+                .Append(DelimitString(property.Name));\n+\n+            if (!property.IsClrProperty)\n+            {\n+                stringBuilder.Append(\", shadowProperty: true\");\n+            }\n+\n+            if (!property.IsClrProperty)","path":"src/Microsoft.Data.Entity.Migrations/CSharpModelCodeGenerator.cs","position":39,"original_position":39,"commit_id":"de74f374db7fa6efb2edaff8a4d4d75077ceef5d","original_commit_id":"de74f374db7fa6efb2edaff8a4d4d75077ceef5d","user":{"login":"emilcicos","id":6577834,"avatar_url":"https://avatars.githubusercontent.com/u/6577834?","gravatar_id":"f8234cd7c41199f46cb1d57840a8963b","url":"https://api.github.com/users/emilcicos","html_url":"https://github.com/emilcicos","followers_url":"https://api.github.com/users/emilcicos/followers","following_url":"https://api.github.com/users/emilcicos/following{/other_user}","gists_url":"https://api.github.com/users/emilcicos/gists{/gist_id}","starred_url":"https://api.github.com/users/emilcicos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilcicos/subscriptions","organizations_url":"https://api.github.com/users/emilcicos/orgs","repos_url":"https://api.github.com/users/emilcicos/repos","events_url":"https://api.github.com/users/emilcicos/events{/privacy}","received_events_url":"https://api.github.com/users/emilcicos/received_events","type":"User","site_admin":false},"body":"Yes, and I will add a unit test for that.","created_at":"2014-05-16T21:31:41Z","updated_at":"2014-05-16T21:31:41Z","html_url":"https://github.com/aspnet/EntityFramework/pull/174#discussion_r12760692","pull_request_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/12760692"},"html":{"href":"https://github.com/aspnet/EntityFramework/pull/174#discussion_r12760692"},"pull_request":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/174"}}}}