GitHub PullRequestReviewCommentEvent at 2014-10-30 23:37:16
Repository: astropy
Actor: astrofrog
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/19644019","id":19644019,"diff_hunk":"@@ -13,3 +23,54 @@ def test_pickle_longitude_wrap_angle():\n \n     assert a.rad == b.rad\n     assert a.wrap_angle == b.wrap_angle\n+\n+\n+_names = [coord.Angle,\n+          coord.CartesianPoints,","path":"astropy/coordinates/tests/test_pickle.py","position":23,"original_position":23,"commit_id":"8b76b3d9ef5020c35a685f79b497c1b9bd0f60f8","original_commit_id":"8b76b3d9ef5020c35a685f79b497c1b9bd0f60f8","user":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=2","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"body":"The ``CartesianPoints`` class no longer exists, can you remove this line?","created_at":"2014-10-30T23:37:16Z","updated_at":"2014-10-30T23:37:16Z","html_url":"https://github.com/astropy/astropy/pull/1947#discussion_r19644019","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/1947","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/19644019"},"html":{"href":"https://github.com/astropy/astropy/pull/1947#discussion_r19644019"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/1947"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/1947","id":11261681,"html_url":"https://github.com/astropy/astropy/pull/1947","diff_url":"https://github.com/astropy/astropy/pull/1947.diff","patch_url":"https://github.com/astropy/astropy/pull/1947.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/1947","number":1947,"state":"open","locked":false,"title":"Issue 1943 - systematically testing pickling of astropy classes","user":{"login":"ktchrn","id":6324463,"avatar_url":"https://avatars.githubusercontent.com/u/6324463?v=2","gravatar_id":"","url":"https://api.github.com/users/ktchrn","html_url":"https://github.com/ktchrn","followers_url":"https://api.github.com/users/ktchrn/followers","following_url":"https://api.github.com/users/ktchrn/following{/other_user}","gists_url":"https://api.github.com/users/ktchrn/gists{/gist_id}","starred_url":"https://api.github.com/users/ktchrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktchrn/subscriptions","organizations_url":"https://api.github.com/users/ktchrn/orgs","repos_url":"https://api.github.com/users/ktchrn/repos","events_url":"https://api.github.com/users/ktchrn/events{/privacy}","received_events_url":"https://api.github.com/users/ktchrn/received_events","type":"User","site_admin":false},"body":"Made sure existing pickling tests included multiple protocols.\r\nAdded basic tests for most base classes and some subclasses with additional attributes.\r\nMost of these tests only check whether or not attributes survive pickling, not whether or not they have the same value before and after. Only the NDData test checks for changes to the various arrays it stores.\r\n\r\nSome of the failures may be irrelevant (e.g. is constants not being pickleable actually a problem?).\r\nSome of the failures are currently xfails by design (e.g. coordinates.DynamicTransform, which can have a function as an attribute).\r\n\r\nSuccessfully reproduces the Issue 1942 problem.","created_at":"2014-01-06T19:59:25Z","updated_at":"2014-10-30T23:37:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbe5859399a7e33e3503428d0039324fe84318f3","assignee":null,"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/15","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/15/labels","id":643887,"number":15,"title":"v1.0.0","description":"","creator":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=2","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"open_issues":140,"closed_issues":61,"state":"open","created_at":"2014-04-29T16:03:02Z","updated_at":"2014-10-30T17:16:47Z","due_on":"2014-11-17T08:00:00Z"},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/1947/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/1947/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/1947/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/8b76b3d9ef5020c35a685f79b497c1b9bd0f60f8","head":{"label":"ktchrn:pickle-tests-issue-1943","ref":"pickle-tests-issue-1943","sha":"8b76b3d9ef5020c35a685f79b497c1b9bd0f60f8","user":{"login":"ktchrn","id":6324463,"avatar_url":"https://avatars.githubusercontent.com/u/6324463?v=2","gravatar_id":"","url":"https://api.github.com/users/ktchrn","html_url":"https://github.com/ktchrn","followers_url":"https://api.github.com/users/ktchrn/followers","following_url":"https://api.github.com/users/ktchrn/following{/other_user}","gists_url":"https://api.github.com/users/ktchrn/gists{/gist_id}","starred_url":"https://api.github.com/users/ktchrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktchrn/subscriptions","organizations_url":"https://api.github.com/users/ktchrn/orgs","repos_url":"https://api.github.com/users/ktchrn/repos","events_url":"https://api.github.com/users/ktchrn/events{/privacy}","received_events_url":"https://api.github.com/users/ktchrn/received_events","type":"User","site_admin":false},"repo":{"id":15656738,"name":"astropy","full_name":"ktchrn/astropy","owner":{"login":"ktchrn","id":6324463,"avatar_url":"https://avatars.githubusercontent.com/u/6324463?v=2","gravatar_id":"","url":"https://api.github.com/users/ktchrn","html_url":"https://github.com/ktchrn","followers_url":"https://api.github.com/users/ktchrn/followers","following_url":"https://api.github.com/users/ktchrn/following{/other_user}","gists_url":"https://api.github.com/users/ktchrn/gists{/gist_id}","starred_url":"https://api.github.com/users/ktchrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktchrn/subscriptions","organizations_url":"https://api.github.com/users/ktchrn/orgs","repos_url":"https://api.github.com/users/ktchrn/repos","events_url":"https://api.github.com/users/ktchrn/events{/privacy}","received_events_url":"https://api.github.com/users/ktchrn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktchrn/astropy","description":"Main Astropy repository","fork":true,"url":"https://api.github.com/repos/ktchrn/astropy","forks_url":"https://api.github.com/repos/ktchrn/astropy/forks","keys_url":"https://api.github.com/repos/ktchrn/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktchrn/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktchrn/astropy/teams","hooks_url":"https://api.github.com/repos/ktchrn/astropy/hooks","issue_events_url":"https://api.github.com/repos/ktchrn/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/ktchrn/astropy/events","assignees_url":"https://api.github.com/repos/ktchrn/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/ktchrn/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/ktchrn/astropy/tags","blobs_url":"https://api.github.com/repos/ktchrn/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktchrn/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktchrn/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktchrn/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktchrn/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/ktchrn/astropy/languages","stargazers_url":"https://api.github.com/repos/ktchrn/astropy/stargazers","contributors_url":"https://api.github.com/repos/ktchrn/astropy/contributors","subscribers_url":"https://api.github.com/repos/ktchrn/astropy/subscribers","subscription_url":"https://api.github.com/repos/ktchrn/astropy/subscription","commits_url":"https://api.github.com/repos/ktchrn/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktchrn/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktchrn/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktchrn/astropy/issues/comments/{number}","contents_url":"https://api.github.com/repos/ktchrn/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/ktchrn/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktchrn/astropy/merges","archive_url":"https://api.github.com/repos/ktchrn/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktchrn/astropy/downloads","issues_url":"https://api.github.com/repos/ktchrn/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/ktchrn/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/ktchrn/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/ktchrn/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktchrn/astropy/labels{/name}","releases_url":"https://api.github.com/repos/ktchrn/astropy/releases{/id}","created_at":"2014-01-05T18:54:26Z","updated_at":"2014-05-20T21:47:15Z","pushed_at":"2014-10-30T12:38:45Z","git_url":"git://github.com/ktchrn/astropy.git","ssh_url":"git@github.com:ktchrn/astropy.git","clone_url":"https://github.com/ktchrn/astropy.git","svn_url":"https://github.com/ktchrn/astropy","homepage":"astropy.org","size":24732,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"1f295e35fe312749aa5e0bec971aca4db430012c","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=2","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=2","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments/{number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","created_at":"2011-07-21T01:33:49Z","updated_at":"2014-10-30T09:12:57Z","pushed_at":"2014-10-30T18:49:31Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":71554,"stargazers_count":459,"watchers_count":459,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":309,"mirror_url":null,"open_issues_count":411,"forks":309,"open_issues":411,"watchers":459,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/1947"},"html":{"href":"https://github.com/astropy/astropy/pull/1947"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/1947"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/1947/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/1947/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/1947/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/8b76b3d9ef5020c35a685f79b497c1b9bd0f60f8"}}}}