GitHub PullRequestReviewCommentEvent at 2014-01-25 19:20:45
Repository: vagrant-proxyconf
Actor: tmatilai
Payload: {"comment":{"url":"https://api.github.com/repos/tmatilai/vagrant-proxyconf/pulls/comments/9172569","id":9172569,"diff_hunk":"@@ -84,7 +84,12 @@ def write_config(config, opts = {})\n             comm.sudo(\"chmod #{opts[:mode] || '0644'} #{tmp}\")\n             comm.sudo(\"chown #{opts[:owner] || 'root:root'} #{tmp}\")\n             comm.sudo(\"mkdir -p #{File.dirname(path)}\")\n-            comm.sudo(\"mv #{tmp} #{path}\")\n+\n+            if opts[:append]\n+              comm.sudo(\"cat #{tmp} | tee -a #{path}\")","path":"lib/vagrant-proxyconf/action/base.rb","position":7,"original_position":7,"commit_id":"217cd30de9b0b2f4eda52e3fae181be73481810a","original_commit_id":"217cd30de9b0b2f4eda52e3fae181be73481810a","user":{"login":"tmatilai","id":79116,"avatar_url":"https://gravatar.com/avatar/dc1b5e60b297c92392d3695e98b4ed53?d=https%3A%2F%2Fidenticons.github.com%2F2bb9d11bfdac13dd5cc91127c564c07f.png&r=x","gravatar_id":"dc1b5e60b297c92392d3695e98b4ed53","url":"https://api.github.com/users/tmatilai","html_url":"https://github.com/tmatilai","followers_url":"https://api.github.com/users/tmatilai/followers","following_url":"https://api.github.com/users/tmatilai/following{/other_user}","gists_url":"https://api.github.com/users/tmatilai/gists{/gist_id}","starred_url":"https://api.github.com/users/tmatilai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmatilai/subscriptions","organizations_url":"https://api.github.com/users/tmatilai/orgs","repos_url":"https://api.github.com/users/tmatilai/repos","events_url":"https://api.github.com/users/tmatilai/events{/privacy}","received_events_url":"https://api.github.com/users/tmatilai/received_events","type":"User","site_admin":false},"body":"First, `\"cat #{tmp} >> #{path}\"` would be simpler. But this ignores `:mode` and `:owner` options as those are set only for the `tmp` file.","created_at":"2014-01-25T19:20:45Z","updated_at":"2014-01-25T19:20:45Z","html_url":"https://github.com/tmatilai/vagrant-proxyconf/pull/40#discussion_r9172569","pull_request_url":"https://api.github.com/repos/tmatilai/vagrant-proxyconf/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/tmatilai/vagrant-proxyconf/pulls/comments/9172569"},"html":{"href":"https://github.com/tmatilai/vagrant-proxyconf/pull/40#discussion_r9172569"},"pull_request":{"href":"https://api.github.com/repos/tmatilai/vagrant-proxyconf/pulls/40"}}}}