GitHub PullRequestReviewCommentEvent at 2014-07-10 18:35:43
Repository: wf-uicomponents
Actor: clairesarsam-wf
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/comments/14784212","id":14784212,"diff_hunk":"@@ -290,7 +292,9 @@ define(function(require) {\n             // The scrollbar shouldn't be shorter than MIN_HEIGHT\n             var MIN_HEIGHT = this._options.minHeight || 8;\n             var height = Math.max(MIN_HEIGHT, (this._viewportHeight / this._scrollableVirtualHeight) * this._layout.getViewportSize().height);\n-\n+            if (height >= this._layout.getViewportSize().height) {","path":"src/scroll_bar/ScrollBar.js","position":14,"original_position":14,"commit_id":"eeb97d5a3adebdc93686d17a90ec4705f75206f3","original_commit_id":"eeb97d5a3adebdc93686d17a90ec4705f75206f3","user":{"login":"clairesarsam-wf","id":6198081,"avatar_url":"https://avatars.githubusercontent.com/u/6198081?","gravatar_id":"bc23fa0e979cdd6c02bf129a42e09aae","url":"https://api.github.com/users/clairesarsam-wf","html_url":"https://github.com/clairesarsam-wf","followers_url":"https://api.github.com/users/clairesarsam-wf/followers","following_url":"https://api.github.com/users/clairesarsam-wf/following{/other_user}","gists_url":"https://api.github.com/users/clairesarsam-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/clairesarsam-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clairesarsam-wf/subscriptions","organizations_url":"https://api.github.com/users/clairesarsam-wf/orgs","repos_url":"https://api.github.com/users/clairesarsam-wf/repos","events_url":"https://api.github.com/users/clairesarsam-wf/events{/privacy}","received_events_url":"https://api.github.com/users/clairesarsam-wf/received_events","type":"User","site_admin":false},"body":"@timmccall-wf I think that would be more readable, but the term 'pill' isn't used anywhere else in the `ScrollBar` code. Do you think `scrollBarHeight` would be as good?","created_at":"2014-07-10T18:35:43Z","updated_at":"2014-07-10T18:35:43Z","html_url":"https://github.com/WebFilings/wf-uicomponents/pull/56#discussion_r14784212","pull_request_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/comments/14784212"},"html":{"href":"https://github.com/WebFilings/wf-uicomponents/pull/56#discussion_r14784212"},"pull_request":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/56","id":18229105,"html_url":"https://github.com/WebFilings/wf-uicomponents/pull/56","diff_url":"https://github.com/WebFilings/wf-uicomponents/pull/56.diff","patch_url":"https://github.com/WebFilings/wf-uicomponents/pull/56.patch","issue_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/56","number":56,"state":"open","title":"Fix ScrollBar Exceeding Viewport Top/Bottom","user":{"login":"clairesarsam-wf","id":6198081,"avatar_url":"https://avatars.githubusercontent.com/u/6198081?","gravatar_id":"bc23fa0e979cdd6c02bf129a42e09aae","url":"https://api.github.com/users/clairesarsam-wf","html_url":"https://github.com/clairesarsam-wf","followers_url":"https://api.github.com/users/clairesarsam-wf/followers","following_url":"https://api.github.com/users/clairesarsam-wf/following{/other_user}","gists_url":"https://api.github.com/users/clairesarsam-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/clairesarsam-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clairesarsam-wf/subscriptions","organizations_url":"https://api.github.com/users/clairesarsam-wf/orgs","repos_url":"https://api.github.com/users/clairesarsam-wf/repos","events_url":"https://api.github.com/users/clairesarsam-wf/events{/privacy}","received_events_url":"https://api.github.com/users/clairesarsam-wf/received_events","type":"User","site_admin":false},"body":"There are two ScrollBar bugs that this PR addresses.\r\n* When the ScrollList is dragged above or below it's bounds, the ScrollBar also exceeded it's bounds.\r\n* When the ScrollList was zoomed out such that the ScrollList was shorter than the viewport, the ScrollBar would become taller than the viewport.\r\n\r\nSolutions\r\n* The ScrollBar positioning is now bound between `0` and the height of the viewport minus the height of the ScrollBar.\r\n* When the ScrollList is shorter than the viewport, the ScrollBar height is set to `0`, since it isn't necessary to scroll something that is already completely visible.\r\n\r\n**Unit Tests**\r\n-----\r\nCheck that the ScrollBar height is set to zero when the ScrollList is zoomed out far enough.\r\n\r\n**How To +10/QA**\r\n-----\r\n```bash\r\n# skip the following steps if you've already initialized the project\r\n$ git clone git@github.com:WebFilings/wf-uicomponents.git\r\n$ cd wf-uicomponents\r\n\r\n# do not skip these!\r\n$ git fetch && \r\ngit checkout HY-1094 && \r\n./init.sh && \r\ngrunt qa\r\n```\r\n\r\n* All tests should pass with no console errors\r\n* In the ScrollList Demo, set the Fake Document to have 1 page. You should not see the ScrollBar. Zoom in, and the ScrollBar should appear.\r\n* At the top or bottom of the page, click and drag so that the grey space above/below the ScrollList is visible. The ScrollBar should not move to overlap the header or footer.\r\n\r\n---\r\n\r\nPlease review: @timmccall-wf @shanesizer-wf @lancefisher-wf \r\nFYA: @joshschlick-wf ","created_at":"2014-07-10T16:09:09Z","updated_at":"2014-07-10T18:35:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1a3218feab23320006c9891c72d44f5be880098","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/56/commits","review_comments_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/56/comments","review_comment_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/comments/{number}","comments_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/56/comments","statuses_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/statuses/eeb97d5a3adebdc93686d17a90ec4705f75206f3","head":{"label":"WebFilings:HY-1094","ref":"HY-1094","sha":"eeb97d5a3adebdc93686d17a90ec4705f75206f3","user":{"login":"WebFilings","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?","gravatar_id":"81083d3675346193de94e8471a272512","url":"https://api.github.com/users/WebFilings","html_url":"https://github.com/WebFilings","followers_url":"https://api.github.com/users/WebFilings/followers","following_url":"https://api.github.com/users/WebFilings/following{/other_user}","gists_url":"https://api.github.com/users/WebFilings/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFilings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFilings/subscriptions","organizations_url":"https://api.github.com/users/WebFilings/orgs","repos_url":"https://api.github.com/users/WebFilings/repos","events_url":"https://api.github.com/users/WebFilings/events{/privacy}","received_events_url":"https://api.github.com/users/WebFilings/received_events","type":"Organization","site_admin":false},"repo":{"id":15975978,"name":"wf-uicomponents","full_name":"WebFilings/wf-uicomponents","owner":{"login":"WebFilings","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?","gravatar_id":"81083d3675346193de94e8471a272512","url":"https://api.github.com/users/WebFilings","html_url":"https://github.com/WebFilings","followers_url":"https://api.github.com/users/WebFilings/followers","following_url":"https://api.github.com/users/WebFilings/following{/other_user}","gists_url":"https://api.github.com/users/WebFilings/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFilings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFilings/subscriptions","organizations_url":"https://api.github.com/users/WebFilings/orgs","repos_url":"https://api.github.com/users/WebFilings/repos","events_url":"https://api.github.com/users/WebFilings/events{/privacy}","received_events_url":"https://api.github.com/users/WebFilings/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebFilings/wf-uicomponents","description":"","fork":false,"url":"https://api.github.com/repos/WebFilings/wf-uicomponents","forks_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/forks","keys_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/teams","hooks_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/hooks","issue_events_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/events{/number}","events_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/events","assignees_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/assignees{/user}","branches_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/branches{/branch}","tags_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/tags","blobs_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/statuses/{sha}","languages_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/languages","stargazers_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/stargazers","contributors_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/contributors","subscribers_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/subscribers","subscription_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/subscription","commits_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/comments/{number}","contents_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/contents/{+path}","compare_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/merges","archive_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/downloads","issues_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues{/number}","pulls_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls{/number}","milestones_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/milestones{/number}","notifications_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/labels{/name}","releases_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/releases{/id}","created_at":"2014-01-16T17:54:42Z","updated_at":"2014-06-25T19:50:08Z","pushed_at":"2014-07-10T18:02:48Z","git_url":"git://github.com/WebFilings/wf-uicomponents.git","ssh_url":"git@github.com:WebFilings/wf-uicomponents.git","clone_url":"https://github.com/WebFilings/wf-uicomponents.git","svn_url":"https://github.com/WebFilings/wf-uicomponents","homepage":null,"size":3062,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":8,"default_branch":"master"}},"base":{"label":"WebFilings:master","ref":"master","sha":"0331dbc3808d8ffcd79e45f36502e247f253d9c9","user":{"login":"WebFilings","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?","gravatar_id":"81083d3675346193de94e8471a272512","url":"https://api.github.com/users/WebFilings","html_url":"https://github.com/WebFilings","followers_url":"https://api.github.com/users/WebFilings/followers","following_url":"https://api.github.com/users/WebFilings/following{/other_user}","gists_url":"https://api.github.com/users/WebFilings/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFilings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFilings/subscriptions","organizations_url":"https://api.github.com/users/WebFilings/orgs","repos_url":"https://api.github.com/users/WebFilings/repos","events_url":"https://api.github.com/users/WebFilings/events{/privacy}","received_events_url":"https://api.github.com/users/WebFilings/received_events","type":"Organization","site_admin":false},"repo":{"id":15975978,"name":"wf-uicomponents","full_name":"WebFilings/wf-uicomponents","owner":{"login":"WebFilings","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?","gravatar_id":"81083d3675346193de94e8471a272512","url":"https://api.github.com/users/WebFilings","html_url":"https://github.com/WebFilings","followers_url":"https://api.github.com/users/WebFilings/followers","following_url":"https://api.github.com/users/WebFilings/following{/other_user}","gists_url":"https://api.github.com/users/WebFilings/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFilings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFilings/subscriptions","organizations_url":"https://api.github.com/users/WebFilings/orgs","repos_url":"https://api.github.com/users/WebFilings/repos","events_url":"https://api.github.com/users/WebFilings/events{/privacy}","received_events_url":"https://api.github.com/users/WebFilings/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebFilings/wf-uicomponents","description":"","fork":false,"url":"https://api.github.com/repos/WebFilings/wf-uicomponents","forks_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/forks","keys_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/teams","hooks_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/hooks","issue_events_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/events{/number}","events_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/events","assignees_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/assignees{/user}","branches_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/branches{/branch}","tags_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/tags","blobs_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/statuses/{sha}","languages_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/languages","stargazers_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/stargazers","contributors_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/contributors","subscribers_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/subscribers","subscription_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/subscription","commits_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/comments/{number}","contents_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/contents/{+path}","compare_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/merges","archive_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/downloads","issues_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues{/number}","pulls_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls{/number}","milestones_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/milestones{/number}","notifications_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/labels{/name}","releases_url":"https://api.github.com/repos/WebFilings/wf-uicomponents/releases{/id}","created_at":"2014-01-16T17:54:42Z","updated_at":"2014-06-25T19:50:08Z","pushed_at":"2014-07-10T18:02:48Z","git_url":"git://github.com/WebFilings/wf-uicomponents.git","ssh_url":"git@github.com:WebFilings/wf-uicomponents.git","clone_url":"https://github.com/WebFilings/wf-uicomponents.git","svn_url":"https://github.com/WebFilings/wf-uicomponents","homepage":null,"size":3062,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/56"},"html":{"href":"https://github.com/WebFilings/wf-uicomponents/pull/56"},"issue":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/56"},"comments":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/WebFilings/wf-uicomponents/statuses/eeb97d5a3adebdc93686d17a90ec4705f75206f3"}}}}