GitHub PullRequestReviewCommentEvent at 2014-10-29 16:44:52
Repository: NIPAP
Actor: plajjan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SpriteLink/NIPAP/pulls/comments/19552120","id":19552120,"diff_hunk":"@@ -129,6 +129,26 @@ <h3 class=\"options-group-heading\">Prefix options</h3>\n \t\t\t\t<div class=\"option\">\n \t\t\t\t\t<dl>\n \t\t\t\t\t\t<dt>\n+\t\t\t\t\t\tExpires\n+\t\t\t\t\t\t</dt>\n+\t\t\t\t\t\t<dd>\n+\t\t\t\t\t\t<div class=\"col-md-6\">\n+\t\t\t\t\t\t\t<p class=\"input-group\">\n+\t\t\t\t\t\t\t<input type=\"text\" class=\"form-control input-sm\" datepicker-popup=\"yyyy-MM-dd HH:mm:ss\" ng-model=\"prefix.expires\" is-open=\"prefix.dp_opened\" starting-day=\"1\" ng-required=\"true\" close-text=\"Close\" />","path":"nipap-www/nipapwww/public/templates/prefix_form.html","position":null,"original_position":9,"commit_id":"7ad18d7ba560b1fd75b1df49a60deb54a2c916b4","original_commit_id":"f6a3e49d068a7eea7578dd9da5e8409a8cd7f53c","user":{"login":"plajjan","id":841628,"avatar_url":"https://avatars.githubusercontent.com/u/841628?v=2","gravatar_id":"","url":"https://api.github.com/users/plajjan","html_url":"https://github.com/plajjan","followers_url":"https://api.github.com/users/plajjan/followers","following_url":"https://api.github.com/users/plajjan/following{/other_user}","gists_url":"https://api.github.com/users/plajjan/gists{/gist_id}","starred_url":"https://api.github.com/users/plajjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plajjan/subscriptions","organizations_url":"https://api.github.com/users/plajjan/orgs","repos_url":"https://api.github.com/users/plajjan/repos","events_url":"https://api.github.com/users/plajjan/events{/privacy}","received_events_url":"https://api.github.com/users/plajjan/received_events","type":"User","site_admin":false},"body":"Okay, we could use $parent instead. Perhaps that's better. I've verified it works and it means we don't have to create another object in between.","created_at":"2014-10-29T16:44:52Z","updated_at":"2014-10-29T16:44:52Z","html_url":"https://github.com/SpriteLink/NIPAP/pull/658#discussion_r19552120","pull_request_url":"https://api.github.com/repos/SpriteLink/NIPAP/pulls/658","_links":{"self":{"href":"https://api.github.com/repos/SpriteLink/NIPAP/pulls/comments/19552120"},"html":{"href":"https://github.com/SpriteLink/NIPAP/pull/658#discussion_r19552120"},"pull_request":{"href":"https://api.github.com/repos/SpriteLink/NIPAP/pulls/658"}}},"pull_request":{"url":"https://api.github.com/repos/SpriteLink/NIPAP/pulls/658","id":23512311,"html_url":"https://github.com/SpriteLink/NIPAP/pull/658","diff_url":"https://github.com/SpriteLink/NIPAP/pull/658.diff","patch_url":"https://github.com/SpriteLink/NIPAP/pull/658.patch","issue_url":"https://api.github.com/repos/SpriteLink/NIPAP/issues/658","number":658,"state":"open","locked":false,"title":"Add expires field to web UI","user":{"login":"plajjan","id":841628,"avatar_url":"https://avatars.githubusercontent.com/u/841628?v=2","gravatar_id":"","url":"https://api.github.com/users/plajjan","html_url":"https://github.com/plajjan","followers_url":"https://api.github.com/users/plajjan/followers","following_url":"https://api.github.com/users/plajjan/following{/other_user}","gists_url":"https://api.github.com/users/plajjan/gists{/gist_id}","starred_url":"https://api.github.com/users/plajjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plajjan/subscriptions","organizations_url":"https://api.github.com/users/plajjan/orgs","repos_url":"https://api.github.com/users/plajjan/repos","events_url":"https://api.github.com/users/plajjan/events{/privacy}","received_events_url":"https://api.github.com/users/plajjan/received_events","type":"User","site_admin":false},"body":"This adds the expires field to the web UI. Not much to say about it. I use the angular-ui bootstrap component DatePicker.\r\n\r\nHad to mangle some faulty CSS which messed up the look of the datepicker.\r\n\r\nI'm quite certain that timezones are not correctly handled. I'm not quite sure how we should do it so I'm deferring that for the future (tricky part is likely that client and web server is in different timezones, so we can't rely on the local timezone of the web server).\r\n\r\nFixes #599.","created_at":"2014-10-29T07:27:36Z","updated_at":"2014-10-29T16:44:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ace4e2983c794b7caeb07ca296b49a6d1449c631","assignee":{"login":"garberg","id":849751,"avatar_url":"https://avatars.githubusercontent.com/u/849751?v=2","gravatar_id":"","url":"https://api.github.com/users/garberg","html_url":"https://github.com/garberg","followers_url":"https://api.github.com/users/garberg/followers","following_url":"https://api.github.com/users/garberg/following{/other_user}","gists_url":"https://api.github.com/users/garberg/gists{/gist_id}","starred_url":"https://api.github.com/users/garberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garberg/subscriptions","organizations_url":"https://api.github.com/users/garberg/orgs","repos_url":"https://api.github.com/users/garberg/repos","events_url":"https://api.github.com/users/garberg/events{/privacy}","received_events_url":"https://api.github.com/users/garberg/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/SpriteLink/NIPAP/milestones/33","labels_url":"https://api.github.com/repos/SpriteLink/NIPAP/milestones/33/labels","id":735950,"number":33,"title":"Version 0.27 - Icarus","description":"Let's do tags for VRFs, pools and finally add AVPs (strong demand!!).\r\n\r\nI want to add a RESTful API that is experimental but that will eventually become our primary API. Having it in parallel and experimental for some time will allow us to fine tune some stuff. Further, I'm thinking it will allow us to revamp pynipap, which doesn't have the best structure at this point and when relaxing the consistency checks for assignments / hosts, I would like to rename the \"type\" field. With a new API we can do that.\r\n\r\nAlso, the REST API should of course support versioning, unlike our current API.","creator":{"login":"plajjan","id":841628,"avatar_url":"https://avatars.githubusercontent.com/u/841628?v=2","gravatar_id":"","url":"https://api.github.com/users/plajjan","html_url":"https://github.com/plajjan","followers_url":"https://api.github.com/users/plajjan/followers","following_url":"https://api.github.com/users/plajjan/following{/other_user}","gists_url":"https://api.github.com/users/plajjan/gists{/gist_id}","starred_url":"https://api.github.com/users/plajjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plajjan/subscriptions","organizations_url":"https://api.github.com/users/plajjan/orgs","repos_url":"https://api.github.com/users/plajjan/repos","events_url":"https://api.github.com/users/plajjan/events{/privacy}","received_events_url":"https://api.github.com/users/plajjan/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":57,"state":"open","created_at":"2014-07-29T17:37:15Z","updated_at":"2014-10-29T07:34:42Z","due_on":null},"commits_url":"https://api.github.com/repos/SpriteLink/NIPAP/pulls/658/commits","review_comments_url":"https://api.github.com/repos/SpriteLink/NIPAP/pulls/658/comments","review_comment_url":"https://api.github.com/repos/SpriteLink/NIPAP/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SpriteLink/NIPAP/issues/658/comments","statuses_url":"https://api.github.com/repos/SpriteLink/NIPAP/statuses/7ad18d7ba560b1fd75b1df49a60deb54a2c916b4","head":{"label":"plajjan:599-web-expires","ref":"599-web-expires","sha":"7ad18d7ba560b1fd75b1df49a60deb54a2c916b4","user":{"login":"plajjan","id":841628,"avatar_url":"https://avatars.githubusercontent.com/u/841628?v=2","gravatar_id":"","url":"https://api.github.com/users/plajjan","html_url":"https://github.com/plajjan","followers_url":"https://api.github.com/users/plajjan/followers","following_url":"https://api.github.com/users/plajjan/following{/other_user}","gists_url":"https://api.github.com/users/plajjan/gists{/gist_id}","starred_url":"https://api.github.com/users/plajjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plajjan/subscriptions","organizations_url":"https://api.github.com/users/plajjan/orgs","repos_url":"https://api.github.com/users/plajjan/repos","events_url":"https://api.github.com/users/plajjan/events{/privacy}","received_events_url":"https://api.github.com/users/plajjan/received_events","type":"User","site_admin":false},"repo":{"id":12816541,"name":"NIPAP","full_name":"plajjan/NIPAP","owner":{"login":"plajjan","id":841628,"avatar_url":"https://avatars.githubusercontent.com/u/841628?v=2","gravatar_id":"","url":"https://api.github.com/users/plajjan","html_url":"https://github.com/plajjan","followers_url":"https://api.github.com/users/plajjan/followers","following_url":"https://api.github.com/users/plajjan/following{/other_user}","gists_url":"https://api.github.com/users/plajjan/gists{/gist_id}","starred_url":"https://api.github.com/users/plajjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plajjan/subscriptions","organizations_url":"https://api.github.com/users/plajjan/orgs","repos_url":"https://api.github.com/users/plajjan/repos","events_url":"https://api.github.com/users/plajjan/events{/privacy}","received_events_url":"https://api.github.com/users/plajjan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/plajjan/NIPAP","description":"Neat IP Address Planner - NIPAP is the best open source IPAM in the known universe, challenging classical IP address management (IPAM) systems in many areas.","fork":true,"url":"https://api.github.com/repos/plajjan/NIPAP","forks_url":"https://api.github.com/repos/plajjan/NIPAP/forks","keys_url":"https://api.github.com/repos/plajjan/NIPAP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plajjan/NIPAP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plajjan/NIPAP/teams","hooks_url":"https://api.github.com/repos/plajjan/NIPAP/hooks","issue_events_url":"https://api.github.com/repos/plajjan/NIPAP/issues/events{/number}","events_url":"https://api.github.com/repos/plajjan/NIPAP/events","assignees_url":"https://api.github.com/repos/plajjan/NIPAP/assignees{/user}","branches_url":"https://api.github.com/repos/plajjan/NIPAP/branches{/branch}","tags_url":"https://api.github.com/repos/plajjan/NIPAP/tags","blobs_url":"https://api.github.com/repos/plajjan/NIPAP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plajjan/NIPAP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plajjan/NIPAP/git/refs{/sha}","trees_url":"https://api.github.com/repos/plajjan/NIPAP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plajjan/NIPAP/statuses/{sha}","languages_url":"https://api.github.com/repos/plajjan/NIPAP/languages","stargazers_url":"https://api.github.com/repos/plajjan/NIPAP/stargazers","contributors_url":"https://api.github.com/repos/plajjan/NIPAP/contributors","subscribers_url":"https://api.github.com/repos/plajjan/NIPAP/subscribers","subscription_url":"https://api.github.com/repos/plajjan/NIPAP/subscription","commits_url":"https://api.github.com/repos/plajjan/NIPAP/commits{/sha}","git_commits_url":"https://api.github.com/repos/plajjan/NIPAP/git/commits{/sha}","comments_url":"https://api.github.com/repos/plajjan/NIPAP/comments{/number}","issue_comment_url":"https://api.github.com/repos/plajjan/NIPAP/issues/comments/{number}","contents_url":"https://api.github.com/repos/plajjan/NIPAP/contents/{+path}","compare_url":"https://api.github.com/repos/plajjan/NIPAP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plajjan/NIPAP/merges","archive_url":"https://api.github.com/repos/plajjan/NIPAP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plajjan/NIPAP/downloads","issues_url":"https://api.github.com/repos/plajjan/NIPAP/issues{/number}","pulls_url":"https://api.github.com/repos/plajjan/NIPAP/pulls{/number}","milestones_url":"https://api.github.com/repos/plajjan/NIPAP/milestones{/number}","notifications_url":"https://api.github.com/repos/plajjan/NIPAP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plajjan/NIPAP/labels{/name}","releases_url":"https://api.github.com/repos/plajjan/NIPAP/releases{/id}","created_at":"2013-09-13T18:29:17Z","updated_at":"2014-08-01T15:36:36Z","pushed_at":"2014-10-29T16:22:49Z","git_url":"git://github.com/plajjan/NIPAP.git","ssh_url":"git@github.com:plajjan/NIPAP.git","clone_url":"https://github.com/plajjan/NIPAP.git","svn_url":"https://github.com/plajjan/NIPAP","homepage":"SpriteLink.GitHub.com/NIPAP","size":6238,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpriteLink:master","ref":"master","sha":"1ee4a5bb8ebc78b10f26138e3acd0a6f76e2cc41","user":{"login":"SpriteLink","id":1081314,"avatar_url":"https://avatars.githubusercontent.com/u/1081314?v=2","gravatar_id":"","url":"https://api.github.com/users/SpriteLink","html_url":"https://github.com/SpriteLink","followers_url":"https://api.github.com/users/SpriteLink/followers","following_url":"https://api.github.com/users/SpriteLink/following{/other_user}","gists_url":"https://api.github.com/users/SpriteLink/gists{/gist_id}","starred_url":"https://api.github.com/users/SpriteLink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpriteLink/subscriptions","organizations_url":"https://api.github.com/users/SpriteLink/orgs","repos_url":"https://api.github.com/users/SpriteLink/repos","events_url":"https://api.github.com/users/SpriteLink/events{/privacy}","received_events_url":"https://api.github.com/users/SpriteLink/received_events","type":"Organization","site_admin":false},"repo":{"id":2087868,"name":"NIPAP","full_name":"SpriteLink/NIPAP","owner":{"login":"SpriteLink","id":1081314,"avatar_url":"https://avatars.githubusercontent.com/u/1081314?v=2","gravatar_id":"","url":"https://api.github.com/users/SpriteLink","html_url":"https://github.com/SpriteLink","followers_url":"https://api.github.com/users/SpriteLink/followers","following_url":"https://api.github.com/users/SpriteLink/following{/other_user}","gists_url":"https://api.github.com/users/SpriteLink/gists{/gist_id}","starred_url":"https://api.github.com/users/SpriteLink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpriteLink/subscriptions","organizations_url":"https://api.github.com/users/SpriteLink/orgs","repos_url":"https://api.github.com/users/SpriteLink/repos","events_url":"https://api.github.com/users/SpriteLink/events{/privacy}","received_events_url":"https://api.github.com/users/SpriteLink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpriteLink/NIPAP","description":"Neat IP Address Planner - NIPAP is the best open source IPAM in the known universe, challenging classical IP address management (IPAM) systems in many areas.","fork":false,"url":"https://api.github.com/repos/SpriteLink/NIPAP","forks_url":"https://api.github.com/repos/SpriteLink/NIPAP/forks","keys_url":"https://api.github.com/repos/SpriteLink/NIPAP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpriteLink/NIPAP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpriteLink/NIPAP/teams","hooks_url":"https://api.github.com/repos/SpriteLink/NIPAP/hooks","issue_events_url":"https://api.github.com/repos/SpriteLink/NIPAP/issues/events{/number}","events_url":"https://api.github.com/repos/SpriteLink/NIPAP/events","assignees_url":"https://api.github.com/repos/SpriteLink/NIPAP/assignees{/user}","branches_url":"https://api.github.com/repos/SpriteLink/NIPAP/branches{/branch}","tags_url":"https://api.github.com/repos/SpriteLink/NIPAP/tags","blobs_url":"https://api.github.com/repos/SpriteLink/NIPAP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpriteLink/NIPAP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpriteLink/NIPAP/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpriteLink/NIPAP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpriteLink/NIPAP/statuses/{sha}","languages_url":"https://api.github.com/repos/SpriteLink/NIPAP/languages","stargazers_url":"https://api.github.com/repos/SpriteLink/NIPAP/stargazers","contributors_url":"https://api.github.com/repos/SpriteLink/NIPAP/contributors","subscribers_url":"https://api.github.com/repos/SpriteLink/NIPAP/subscribers","subscription_url":"https://api.github.com/repos/SpriteLink/NIPAP/subscription","commits_url":"https://api.github.com/repos/SpriteLink/NIPAP/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpriteLink/NIPAP/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpriteLink/NIPAP/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpriteLink/NIPAP/issues/comments/{number}","contents_url":"https://api.github.com/repos/SpriteLink/NIPAP/contents/{+path}","compare_url":"https://api.github.com/repos/SpriteLink/NIPAP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpriteLink/NIPAP/merges","archive_url":"https://api.github.com/repos/SpriteLink/NIPAP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpriteLink/NIPAP/downloads","issues_url":"https://api.github.com/repos/SpriteLink/NIPAP/issues{/number}","pulls_url":"https://api.github.com/repos/SpriteLink/NIPAP/pulls{/number}","milestones_url":"https://api.github.com/repos/SpriteLink/NIPAP/milestones{/number}","notifications_url":"https://api.github.com/repos/SpriteLink/NIPAP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpriteLink/NIPAP/labels{/name}","releases_url":"https://api.github.com/repos/SpriteLink/NIPAP/releases{/id}","created_at":"2011-07-22T09:14:49Z","updated_at":"2014-10-27T18:24:49Z","pushed_at":"2014-10-29T08:38:25Z","git_url":"git://github.com/SpriteLink/NIPAP.git","ssh_url":"git@github.com:SpriteLink/NIPAP.git","clone_url":"https://github.com/SpriteLink/NIPAP.git","svn_url":"https://github.com/SpriteLink/NIPAP","homepage":"SpriteLink.GitHub.com/NIPAP","size":39677,"stargazers_count":51,"watchers_count":51,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":95,"forks":19,"open_issues":95,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpriteLink/NIPAP/pulls/658"},"html":{"href":"https://github.com/SpriteLink/NIPAP/pull/658"},"issue":{"href":"https://api.github.com/repos/SpriteLink/NIPAP/issues/658"},"comments":{"href":"https://api.github.com/repos/SpriteLink/NIPAP/issues/658/comments"},"review_comments":{"href":"https://api.github.com/repos/SpriteLink/NIPAP/pulls/658/comments"},"review_comment":{"href":"https://api.github.com/repos/SpriteLink/NIPAP/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SpriteLink/NIPAP/pulls/658/commits"},"statuses":{"href":"https://api.github.com/repos/SpriteLink/NIPAP/statuses/7ad18d7ba560b1fd75b1df49a60deb54a2c916b4"}}}}