GitHub PullRequestReviewCommentEvent at 2014-10-20 22:53:51
Repository: is210_lesson_08
Actor: cheuschober
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls/comments/19119886","id":19119886,"diff_hunk":"@@ -0,0 +1,21 @@\n+#!/usr/bin/env python\n+# -*- coding: utf-8 -*-\n+\"\"\"Lesson 08 Task 04 file\"\"\"\n+\n+import task_02\n+\n+\n+class Tigerpaw(task_02.Tire):\n+    \"\"\"\"\"A subclass of Tire, round rubber thing.\n+\n+    Args:\n+        miles (integer): The number of miles on the Tire. Defaults to 0.\n+\n+    Attributes:\n+       miles (integer): The number of miles on the Tire.\n+    \"\"\"\n+    __maximum_miles = 750\n+\n+    def __init__(self, miles=0):\n+        task_02.Tire.__init__(self)\n+        self.miles = miles","path":"task_04.py","position":21,"original_position":21,"commit_id":"fb2e03e23ca76f0bc3f4ae5c03c74cf86a7db05c","original_commit_id":"fb2e03e23ca76f0bc3f4ae5c03c74cf86a7db05c","user":{"login":"cheuschober","id":1184479,"avatar_url":"https://avatars.githubusercontent.com/u/1184479?v=2","gravatar_id":"","url":"https://api.github.com/users/cheuschober","html_url":"https://github.com/cheuschober","followers_url":"https://api.github.com/users/cheuschober/followers","following_url":"https://api.github.com/users/cheuschober/following{/other_user}","gists_url":"https://api.github.com/users/cheuschober/gists{/gist_id}","starred_url":"https://api.github.com/users/cheuschober/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheuschober/subscriptions","organizations_url":"https://api.github.com/users/cheuschober/orgs","repos_url":"https://api.github.com/users/cheuschober/repos","events_url":"https://api.github.com/users/cheuschober/events{/privacy}","received_events_url":"https://api.github.com/users/cheuschober/received_events","type":"User","site_admin":false},"body":"Because the constructor was already inherited, you didn't need to re-declare it here and, in fact, you effectively broke our rule of Once-and-Only-Once. Imagine if I needed to make a change to the `Tire` constructor. I would now have to go find this file and do it here too. The tests were specifically looking for the duplication but it's something you should try to avoid especially where the constructor was inherited.","created_at":"2014-10-20T22:53:51Z","updated_at":"2014-10-20T22:53:51Z","html_url":"https://github.com/is210-2014-fall-02/is210_lesson_08/pull/1#discussion_r19119886","pull_request_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls/comments/19119886"},"html":{"href":"https://github.com/is210-2014-fall-02/is210_lesson_08/pull/1#discussion_r19119886"},"pull_request":{"href":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls/1","id":22795458,"html_url":"https://github.com/is210-2014-fall-02/is210_lesson_08/pull/1","diff_url":"https://github.com/is210-2014-fall-02/is210_lesson_08/pull/1.diff","patch_url":"https://github.com/is210-2014-fall-02/is210_lesson_08/pull/1.patch","issue_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/issues/1","number":1,"state":"closed","locked":false,"title":"Assignment 8","user":{"login":"pwengerd","id":7590339,"avatar_url":"https://avatars.githubusercontent.com/u/7590339?v=2","gravatar_id":"","url":"https://api.github.com/users/pwengerd","html_url":"https://github.com/pwengerd","followers_url":"https://api.github.com/users/pwengerd/followers","following_url":"https://api.github.com/users/pwengerd/following{/other_user}","gists_url":"https://api.github.com/users/pwengerd/gists{/gist_id}","starred_url":"https://api.github.com/users/pwengerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwengerd/subscriptions","organizations_url":"https://api.github.com/users/pwengerd/orgs","repos_url":"https://api.github.com/users/pwengerd/repos","events_url":"https://api.github.com/users/pwengerd/events{/privacy}","received_events_url":"https://api.github.com/users/pwengerd/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-15T16:17:04Z","updated_at":"2014-10-20T22:53:51Z","closed_at":"2014-10-20T22:47:28Z","merged_at":"2014-10-20T22:47:28Z","merge_commit_sha":"f10a2bd788a7646befe2bdb110496f40ad3a7e35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls/1/commits","review_comments_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls/1/comments","review_comment_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls/comments/{number}","comments_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/issues/1/comments","statuses_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/statuses/fb2e03e23ca76f0bc3f4ae5c03c74cf86a7db05c","head":{"label":"pwengerd:master","ref":"master","sha":"fb2e03e23ca76f0bc3f4ae5c03c74cf86a7db05c","user":{"login":"pwengerd","id":7590339,"avatar_url":"https://avatars.githubusercontent.com/u/7590339?v=2","gravatar_id":"","url":"https://api.github.com/users/pwengerd","html_url":"https://github.com/pwengerd","followers_url":"https://api.github.com/users/pwengerd/followers","following_url":"https://api.github.com/users/pwengerd/following{/other_user}","gists_url":"https://api.github.com/users/pwengerd/gists{/gist_id}","starred_url":"https://api.github.com/users/pwengerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwengerd/subscriptions","organizations_url":"https://api.github.com/users/pwengerd/orgs","repos_url":"https://api.github.com/users/pwengerd/repos","events_url":"https://api.github.com/users/pwengerd/events{/privacy}","received_events_url":"https://api.github.com/users/pwengerd/received_events","type":"User","site_admin":false},"repo":{"id":25261691,"name":"is210_lesson_08","full_name":"pwengerd/is210_lesson_08","owner":{"login":"pwengerd","id":7590339,"avatar_url":"https://avatars.githubusercontent.com/u/7590339?v=2","gravatar_id":"","url":"https://api.github.com/users/pwengerd","html_url":"https://github.com/pwengerd","followers_url":"https://api.github.com/users/pwengerd/followers","following_url":"https://api.github.com/users/pwengerd/following{/other_user}","gists_url":"https://api.github.com/users/pwengerd/gists{/gist_id}","starred_url":"https://api.github.com/users/pwengerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwengerd/subscriptions","organizations_url":"https://api.github.com/users/pwengerd/orgs","repos_url":"https://api.github.com/users/pwengerd/repos","events_url":"https://api.github.com/users/pwengerd/events{/privacy}","received_events_url":"https://api.github.com/users/pwengerd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pwengerd/is210_lesson_08","description":"","fork":true,"url":"https://api.github.com/repos/pwengerd/is210_lesson_08","forks_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/forks","keys_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/teams","hooks_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/hooks","issue_events_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/issues/events{/number}","events_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/events","assignees_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/assignees{/user}","branches_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/branches{/branch}","tags_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/tags","blobs_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/git/refs{/sha}","trees_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/statuses/{sha}","languages_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/languages","stargazers_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/stargazers","contributors_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/contributors","subscribers_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/subscribers","subscription_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/subscription","commits_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/commits{/sha}","git_commits_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/git/commits{/sha}","comments_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/comments{/number}","issue_comment_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/issues/comments/{number}","contents_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/contents/{+path}","compare_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/merges","archive_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/downloads","issues_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/issues{/number}","pulls_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/pulls{/number}","milestones_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/milestones{/number}","notifications_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/labels{/name}","releases_url":"https://api.github.com/repos/pwengerd/is210_lesson_08/releases{/id}","created_at":"2014-10-15T15:46:05Z","updated_at":"2014-10-15T16:16:30Z","pushed_at":"2014-10-20T12:46:27Z","git_url":"git://github.com/pwengerd/is210_lesson_08.git","ssh_url":"git@github.com:pwengerd/is210_lesson_08.git","clone_url":"https://github.com/pwengerd/is210_lesson_08.git","svn_url":"https://github.com/pwengerd/is210_lesson_08","homepage":null,"size":253,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"is210-2014-fall-02:pwengerd","ref":"pwengerd","sha":"7b03dd930df8580e5932135b7c6a36a67d67255a","user":{"login":"is210-2014-fall-02","id":8573916,"avatar_url":"https://avatars.githubusercontent.com/u/8573916?v=2","gravatar_id":"","url":"https://api.github.com/users/is210-2014-fall-02","html_url":"https://github.com/is210-2014-fall-02","followers_url":"https://api.github.com/users/is210-2014-fall-02/followers","following_url":"https://api.github.com/users/is210-2014-fall-02/following{/other_user}","gists_url":"https://api.github.com/users/is210-2014-fall-02/gists{/gist_id}","starred_url":"https://api.github.com/users/is210-2014-fall-02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/is210-2014-fall-02/subscriptions","organizations_url":"https://api.github.com/users/is210-2014-fall-02/orgs","repos_url":"https://api.github.com/users/is210-2014-fall-02/repos","events_url":"https://api.github.com/users/is210-2014-fall-02/events{/privacy}","received_events_url":"https://api.github.com/users/is210-2014-fall-02/received_events","type":"Organization","site_admin":false},"repo":{"id":25226033,"name":"is210_lesson_08","full_name":"is210-2014-fall-02/is210_lesson_08","owner":{"login":"is210-2014-fall-02","id":8573916,"avatar_url":"https://avatars.githubusercontent.com/u/8573916?v=2","gravatar_id":"","url":"https://api.github.com/users/is210-2014-fall-02","html_url":"https://github.com/is210-2014-fall-02","followers_url":"https://api.github.com/users/is210-2014-fall-02/followers","following_url":"https://api.github.com/users/is210-2014-fall-02/following{/other_user}","gists_url":"https://api.github.com/users/is210-2014-fall-02/gists{/gist_id}","starred_url":"https://api.github.com/users/is210-2014-fall-02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/is210-2014-fall-02/subscriptions","organizations_url":"https://api.github.com/users/is210-2014-fall-02/orgs","repos_url":"https://api.github.com/users/is210-2014-fall-02/repos","events_url":"https://api.github.com/users/is210-2014-fall-02/events{/privacy}","received_events_url":"https://api.github.com/users/is210-2014-fall-02/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/is210-2014-fall-02/is210_lesson_08","description":"","fork":true,"url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08","forks_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/forks","keys_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/keys{/key_id}","collaborators_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/teams","hooks_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/hooks","issue_events_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/issues/events{/number}","events_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/events","assignees_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/assignees{/user}","branches_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/branches{/branch}","tags_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/tags","blobs_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/git/refs{/sha}","trees_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/git/trees{/sha}","statuses_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/statuses/{sha}","languages_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/languages","stargazers_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/stargazers","contributors_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/contributors","subscribers_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/subscribers","subscription_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/subscription","commits_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/commits{/sha}","git_commits_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/git/commits{/sha}","comments_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/comments{/number}","issue_comment_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/issues/comments/{number}","contents_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/contents/{+path}","compare_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/compare/{base}...{head}","merges_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/merges","archive_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/downloads","issues_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/issues{/number}","pulls_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls{/number}","milestones_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/milestones{/number}","notifications_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/labels{/name}","releases_url":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/releases{/id}","created_at":"2014-10-14T20:51:12Z","updated_at":"2014-10-15T17:38:40Z","pushed_at":"2014-10-20T22:47:29Z","git_url":"git://github.com/is210-2014-fall-02/is210_lesson_08.git","ssh_url":"git@github.com:is210-2014-fall-02/is210_lesson_08.git","clone_url":"https://github.com/is210-2014-fall-02/is210_lesson_08.git","svn_url":"https://github.com/is210-2014-fall-02/is210_lesson_08","homepage":null,"size":294,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls/1"},"html":{"href":"https://github.com/is210-2014-fall-02/is210_lesson_08/pull/1"},"issue":{"href":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/issues/1"},"comments":{"href":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/is210-2014-fall-02/is210_lesson_08/statuses/fb2e03e23ca76f0bc3f4ae5c03c74cf86a7db05c"}}}}