GitHub PullRequestReviewCommentEvent at 2014-06-19 18:17:52
Repository: opentuner
Actor: soundnsilence
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jansel/opentuner/pulls/comments/13984425","id":13984425,"diff_hunk":"@@ -327,9 +327,9 @@ def set_linear(self, cfg_dst, a, cfg_a, b, cfg_b, c, cfg_c):\n   def search_space_size(self):\n     return 1\n \n-  # Stochastic variators\n+  # Stochastic variators \n   def sv_swarm(self, position, global_best, local_best, *args, **kwargs):\n-    raise NotImplementedError()\n+    log.debug('%s is not updated', self.__class__)","path":"opentuner/search/manipulator.py","position":8,"original_position":8,"commit_id":"388b831ee1b8289024aa08f05e175858594aa2f9","original_commit_id":"388b831ee1b8289024aa08f05e175858594aa2f9","user":{"login":"soundnsilence","id":3497815,"avatar_url":"https://avatars.githubusercontent.com/u/3497815?","gravatar_id":"1935ffdd0af1d4f1ee7b33aea39fcf98","url":"https://api.github.com/users/soundnsilence","html_url":"https://github.com/soundnsilence","followers_url":"https://api.github.com/users/soundnsilence/followers","following_url":"https://api.github.com/users/soundnsilence/following{/other_user}","gists_url":"https://api.github.com/users/soundnsilence/gists{/gist_id}","starred_url":"https://api.github.com/users/soundnsilence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundnsilence/subscriptions","organizations_url":"https://api.github.com/users/soundnsilence/orgs","repos_url":"https://api.github.com/users/soundnsilence/repos","events_url":"https://api.github.com/users/soundnsilence/events{/privacy}","received_events_url":"https://api.github.com/users/soundnsilence/received_events","type":"User","site_admin":false},"body":"In my current version I am in fact trying to eliminate unpredictable\r\nchanges. The sv_swarm is a stochastic function that recombines three parent\r\nvalues, and is likely to be very parameter-specific for complex types. At\r\nthe moment I don't have good operator for ordinal values.\r\n\r\nRegardless documentation is needed definitely. I'm adding it now.\r\n\r\n\r\nOn Thu, Jun 19, 2014 at 2:06 PM, Jason Ansel <notifications@github.com>\r\nwrote:\r\n\r\n> In opentuner/search/manipulator.py:\r\n>\r\n> >    def sv_swarm(self, position, global_best, local_best, *args, **kwargs):\r\n> > -    raise NotImplementedError()\r\n> > +    log.debug('%s is not updated', self.__class__)\r\n>\r\n> Is there a default implementation of this that we could provide that would\r\n> be better than doing nothing? What do we tell people implementing custom\r\n> parameter types to write for this method? Can we improve documentation?\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/jansel/opentuner/pull/32/files#r13983776>.\r\n>\r\n\r\n\r\n\r\nOn Thu, Jun 19, 2014 at 2:06 PM, Jason Ansel <notifications@github.com>\r\nwrote:\r\n\r\n> In opentuner/search/manipulator.py:\r\n>\r\n> >    def sv_swarm(self, position, global_best, local_best, *args, **kwargs):\r\n> > -    raise NotImplementedError()\r\n> > +    log.debug('%s is not updated', self.__class__)\r\n>\r\n> Is there a default implementation of this that we could provide that would\r\n> be better than doing nothing? What do we tell people implementing custom\r\n> parameter types to write for this method? Can we improve documentation?\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/jansel/opentuner/pull/32/files#r13983776>.\r\n>","created_at":"2014-06-19T18:17:52Z","updated_at":"2014-06-19T18:17:52Z","html_url":"https://github.com/jansel/opentuner/pull/32#discussion_r13984425","pull_request_url":"https://api.github.com/repos/jansel/opentuner/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/jansel/opentuner/pulls/comments/13984425"},"html":{"href":"https://github.com/jansel/opentuner/pull/32#discussion_r13984425"},"pull_request":{"href":"https://api.github.com/repos/jansel/opentuner/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/jansel/opentuner/pulls/32","id":17357653,"html_url":"https://github.com/jansel/opentuner/pull/32","diff_url":"https://github.com/jansel/opentuner/pull/32.diff","patch_url":"https://github.com/jansel/opentuner/pull/32.patch","issue_url":"https://api.github.com/repos/jansel/opentuner/issues/32","number":32,"state":"closed","title":"SV updates","user":{"login":"soundnsilence","id":3497815,"avatar_url":"https://avatars.githubusercontent.com/u/3497815?","gravatar_id":"1935ffdd0af1d4f1ee7b33aea39fcf98","url":"https://api.github.com/users/soundnsilence","html_url":"https://github.com/soundnsilence","followers_url":"https://api.github.com/users/soundnsilence/followers","following_url":"https://api.github.com/users/soundnsilence/following{/other_user}","gists_url":"https://api.github.com/users/soundnsilence/gists{/gist_id}","starred_url":"https://api.github.com/users/soundnsilence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundnsilence/subscriptions","organizations_url":"https://api.github.com/users/soundnsilence/orgs","repos_url":"https://api.github.com/users/soundnsilence/repos","events_url":"https://api.github.com/users/soundnsilence/events{/privacy}","received_events_url":"https://api.github.com/users/soundnsilence/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-19T15:32:15Z","updated_at":"2014-06-19T18:17:52Z","closed_at":"2014-06-19T18:08:57Z","merged_at":"2014-06-19T18:08:57Z","merge_commit_sha":"d79541861a2fe23f8a578bf7b7f78a07ac2a4a89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jansel/opentuner/pulls/32/commits","review_comments_url":"https://api.github.com/repos/jansel/opentuner/pulls/32/comments","review_comment_url":"https://api.github.com/repos/jansel/opentuner/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jansel/opentuner/issues/32/comments","statuses_url":"https://api.github.com/repos/jansel/opentuner/statuses/388b831ee1b8289024aa08f05e175858594aa2f9","head":{"label":"soundnsilence:master","ref":"master","sha":"388b831ee1b8289024aa08f05e175858594aa2f9","user":{"login":"soundnsilence","id":3497815,"avatar_url":"https://avatars.githubusercontent.com/u/3497815?","gravatar_id":"1935ffdd0af1d4f1ee7b33aea39fcf98","url":"https://api.github.com/users/soundnsilence","html_url":"https://github.com/soundnsilence","followers_url":"https://api.github.com/users/soundnsilence/followers","following_url":"https://api.github.com/users/soundnsilence/following{/other_user}","gists_url":"https://api.github.com/users/soundnsilence/gists{/gist_id}","starred_url":"https://api.github.com/users/soundnsilence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundnsilence/subscriptions","organizations_url":"https://api.github.com/users/soundnsilence/orgs","repos_url":"https://api.github.com/users/soundnsilence/repos","events_url":"https://api.github.com/users/soundnsilence/events{/privacy}","received_events_url":"https://api.github.com/users/soundnsilence/received_events","type":"User","site_admin":false},"repo":{"id":13394169,"name":"opentuner-1","full_name":"soundnsilence/opentuner-1","owner":{"login":"soundnsilence","id":3497815,"avatar_url":"https://avatars.githubusercontent.com/u/3497815?","gravatar_id":"1935ffdd0af1d4f1ee7b33aea39fcf98","url":"https://api.github.com/users/soundnsilence","html_url":"https://github.com/soundnsilence","followers_url":"https://api.github.com/users/soundnsilence/followers","following_url":"https://api.github.com/users/soundnsilence/following{/other_user}","gists_url":"https://api.github.com/users/soundnsilence/gists{/gist_id}","starred_url":"https://api.github.com/users/soundnsilence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundnsilence/subscriptions","organizations_url":"https://api.github.com/users/soundnsilence/orgs","repos_url":"https://api.github.com/users/soundnsilence/repos","events_url":"https://api.github.com/users/soundnsilence/events{/privacy}","received_events_url":"https://api.github.com/users/soundnsilence/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soundnsilence/opentuner-1","description":"An extensible framework for program autotuning","fork":true,"url":"https://api.github.com/repos/soundnsilence/opentuner-1","forks_url":"https://api.github.com/repos/soundnsilence/opentuner-1/forks","keys_url":"https://api.github.com/repos/soundnsilence/opentuner-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soundnsilence/opentuner-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soundnsilence/opentuner-1/teams","hooks_url":"https://api.github.com/repos/soundnsilence/opentuner-1/hooks","issue_events_url":"https://api.github.com/repos/soundnsilence/opentuner-1/issues/events{/number}","events_url":"https://api.github.com/repos/soundnsilence/opentuner-1/events","assignees_url":"https://api.github.com/repos/soundnsilence/opentuner-1/assignees{/user}","branches_url":"https://api.github.com/repos/soundnsilence/opentuner-1/branches{/branch}","tags_url":"https://api.github.com/repos/soundnsilence/opentuner-1/tags","blobs_url":"https://api.github.com/repos/soundnsilence/opentuner-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soundnsilence/opentuner-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soundnsilence/opentuner-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/soundnsilence/opentuner-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soundnsilence/opentuner-1/statuses/{sha}","languages_url":"https://api.github.com/repos/soundnsilence/opentuner-1/languages","stargazers_url":"https://api.github.com/repos/soundnsilence/opentuner-1/stargazers","contributors_url":"https://api.github.com/repos/soundnsilence/opentuner-1/contributors","subscribers_url":"https://api.github.com/repos/soundnsilence/opentuner-1/subscribers","subscription_url":"https://api.github.com/repos/soundnsilence/opentuner-1/subscription","commits_url":"https://api.github.com/repos/soundnsilence/opentuner-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/soundnsilence/opentuner-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/soundnsilence/opentuner-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/soundnsilence/opentuner-1/issues/comments/{number}","contents_url":"https://api.github.com/repos/soundnsilence/opentuner-1/contents/{+path}","compare_url":"https://api.github.com/repos/soundnsilence/opentuner-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soundnsilence/opentuner-1/merges","archive_url":"https://api.github.com/repos/soundnsilence/opentuner-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soundnsilence/opentuner-1/downloads","issues_url":"https://api.github.com/repos/soundnsilence/opentuner-1/issues{/number}","pulls_url":"https://api.github.com/repos/soundnsilence/opentuner-1/pulls{/number}","milestones_url":"https://api.github.com/repos/soundnsilence/opentuner-1/milestones{/number}","notifications_url":"https://api.github.com/repos/soundnsilence/opentuner-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soundnsilence/opentuner-1/labels{/name}","releases_url":"https://api.github.com/repos/soundnsilence/opentuner-1/releases{/id}","created_at":"2013-10-07T19:56:46Z","updated_at":"2014-06-19T18:08:57Z","pushed_at":"2014-06-19T18:02:41Z","git_url":"git://github.com/soundnsilence/opentuner-1.git","ssh_url":"git@github.com:soundnsilence/opentuner-1.git","clone_url":"https://github.com/soundnsilence/opentuner-1.git","svn_url":"https://github.com/soundnsilence/opentuner-1","homepage":"http://opentuner.org/","size":823,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jansel:master","ref":"master","sha":"7963484e79ef097c5eedfd4bbfd236e34370cf32","user":{"login":"jansel","id":533820,"avatar_url":"https://avatars.githubusercontent.com/u/533820?","gravatar_id":"c85e386181977a6a7dced526bc07c791","url":"https://api.github.com/users/jansel","html_url":"https://github.com/jansel","followers_url":"https://api.github.com/users/jansel/followers","following_url":"https://api.github.com/users/jansel/following{/other_user}","gists_url":"https://api.github.com/users/jansel/gists{/gist_id}","starred_url":"https://api.github.com/users/jansel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jansel/subscriptions","organizations_url":"https://api.github.com/users/jansel/orgs","repos_url":"https://api.github.com/users/jansel/repos","events_url":"https://api.github.com/users/jansel/events{/privacy}","received_events_url":"https://api.github.com/users/jansel/received_events","type":"User","site_admin":false},"repo":{"id":6891172,"name":"opentuner","full_name":"jansel/opentuner","owner":{"login":"jansel","id":533820,"avatar_url":"https://avatars.githubusercontent.com/u/533820?","gravatar_id":"c85e386181977a6a7dced526bc07c791","url":"https://api.github.com/users/jansel","html_url":"https://github.com/jansel","followers_url":"https://api.github.com/users/jansel/followers","following_url":"https://api.github.com/users/jansel/following{/other_user}","gists_url":"https://api.github.com/users/jansel/gists{/gist_id}","starred_url":"https://api.github.com/users/jansel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jansel/subscriptions","organizations_url":"https://api.github.com/users/jansel/orgs","repos_url":"https://api.github.com/users/jansel/repos","events_url":"https://api.github.com/users/jansel/events{/privacy}","received_events_url":"https://api.github.com/users/jansel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jansel/opentuner","description":"An extensible framework for program autotuning","fork":false,"url":"https://api.github.com/repos/jansel/opentuner","forks_url":"https://api.github.com/repos/jansel/opentuner/forks","keys_url":"https://api.github.com/repos/jansel/opentuner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jansel/opentuner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jansel/opentuner/teams","hooks_url":"https://api.github.com/repos/jansel/opentuner/hooks","issue_events_url":"https://api.github.com/repos/jansel/opentuner/issues/events{/number}","events_url":"https://api.github.com/repos/jansel/opentuner/events","assignees_url":"https://api.github.com/repos/jansel/opentuner/assignees{/user}","branches_url":"https://api.github.com/repos/jansel/opentuner/branches{/branch}","tags_url":"https://api.github.com/repos/jansel/opentuner/tags","blobs_url":"https://api.github.com/repos/jansel/opentuner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jansel/opentuner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jansel/opentuner/git/refs{/sha}","trees_url":"https://api.github.com/repos/jansel/opentuner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jansel/opentuner/statuses/{sha}","languages_url":"https://api.github.com/repos/jansel/opentuner/languages","stargazers_url":"https://api.github.com/repos/jansel/opentuner/stargazers","contributors_url":"https://api.github.com/repos/jansel/opentuner/contributors","subscribers_url":"https://api.github.com/repos/jansel/opentuner/subscribers","subscription_url":"https://api.github.com/repos/jansel/opentuner/subscription","commits_url":"https://api.github.com/repos/jansel/opentuner/commits{/sha}","git_commits_url":"https://api.github.com/repos/jansel/opentuner/git/commits{/sha}","comments_url":"https://api.github.com/repos/jansel/opentuner/comments{/number}","issue_comment_url":"https://api.github.com/repos/jansel/opentuner/issues/comments/{number}","contents_url":"https://api.github.com/repos/jansel/opentuner/contents/{+path}","compare_url":"https://api.github.com/repos/jansel/opentuner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jansel/opentuner/merges","archive_url":"https://api.github.com/repos/jansel/opentuner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jansel/opentuner/downloads","issues_url":"https://api.github.com/repos/jansel/opentuner/issues{/number}","pulls_url":"https://api.github.com/repos/jansel/opentuner/pulls{/number}","milestones_url":"https://api.github.com/repos/jansel/opentuner/milestones{/number}","notifications_url":"https://api.github.com/repos/jansel/opentuner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jansel/opentuner/labels{/name}","releases_url":"https://api.github.com/repos/jansel/opentuner/releases{/id}","created_at":"2012-11-27T21:22:13Z","updated_at":"2014-06-19T18:08:57Z","pushed_at":"2014-06-19T18:08:57Z","git_url":"git://github.com/jansel/opentuner.git","ssh_url":"git@github.com:jansel/opentuner.git","clone_url":"https://github.com/jansel/opentuner.git","svn_url":"https://github.com/jansel/opentuner","homepage":"http://opentuner.org/","size":35965,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":19,"mirror_url":null,"open_issues_count":7,"forks":19,"open_issues":7,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jansel/opentuner/pulls/32"},"html":{"href":"https://github.com/jansel/opentuner/pull/32"},"issue":{"href":"https://api.github.com/repos/jansel/opentuner/issues/32"},"comments":{"href":"https://api.github.com/repos/jansel/opentuner/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/jansel/opentuner/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/jansel/opentuner/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jansel/opentuner/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/jansel/opentuner/statuses/388b831ee1b8289024aa08f05e175858594aa2f9"}}}}