GitHub PullRequestReviewCommentEvent at 2014-12-22 09:03:05
Repository: izettle-toolbox
Actor: adamvoncorswant
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/comments/22158507","id":22158507,"diff_hunk":"@@ -0,0 +1,88 @@\n+package com.izettle.tlv;\n+\n+import com.izettle.java.ArrayUtils;\n+import com.izettle.java.Hex;\n+\n+import java.util.*;\n+\n+/**\n+ * ISO 7816 / ASN.1 compliantish decoder.\n+ * @author fidde\n+ */\n+public class TLVDecoder {\n+\n+\tprivate Set<Integer> expandTags = new HashSet<>();","path":"izettle-emv/src/main/java/com/izettle/tlv/TLVDecoder.java","position":14,"original_position":14,"commit_id":"959b7397742eab9d6bf7c77be176f8c811c43bd6","original_commit_id":"959b7397742eab9d6bf7c77be176f8c811c43bd6","user":{"login":"adamvoncorswant","id":1142587,"avatar_url":"https://avatars.githubusercontent.com/u/1142587?v=3","gravatar_id":"","url":"https://api.github.com/users/adamvoncorswant","html_url":"https://github.com/adamvoncorswant","followers_url":"https://api.github.com/users/adamvoncorswant/followers","following_url":"https://api.github.com/users/adamvoncorswant/following{/other_user}","gists_url":"https://api.github.com/users/adamvoncorswant/gists{/gist_id}","starred_url":"https://api.github.com/users/adamvoncorswant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamvoncorswant/subscriptions","organizations_url":"https://api.github.com/users/adamvoncorswant/orgs","repos_url":"https://api.github.com/users/adamvoncorswant/repos","events_url":"https://api.github.com/users/adamvoncorswant/events{/privacy}","received_events_url":"https://api.github.com/users/adamvoncorswant/received_events","type":"User","site_admin":false},"body":"final?","created_at":"2014-12-22T09:03:05Z","updated_at":"2014-12-22T09:03:05Z","html_url":"https://github.com/iZettle/izettle-toolbox/pull/97#discussion_r22158507","pull_request_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/comments/22158507"},"html":{"href":"https://github.com/iZettle/izettle-toolbox/pull/97#discussion_r22158507"},"pull_request":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/97","id":26223291,"html_url":"https://github.com/iZettle/izettle-toolbox/pull/97","diff_url":"https://github.com/iZettle/izettle-toolbox/pull/97.diff","patch_url":"https://github.com/iZettle/izettle-toolbox/pull/97.patch","issue_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/97","number":97,"state":"open","locked":false,"title":"TLV Redux","user":{"login":"fiddeandersson","id":1296440,"avatar_url":"https://avatars.githubusercontent.com/u/1296440?v=3","gravatar_id":"","url":"https://api.github.com/users/fiddeandersson","html_url":"https://github.com/fiddeandersson","followers_url":"https://api.github.com/users/fiddeandersson/followers","following_url":"https://api.github.com/users/fiddeandersson/following{/other_user}","gists_url":"https://api.github.com/users/fiddeandersson/gists{/gist_id}","starred_url":"https://api.github.com/users/fiddeandersson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiddeandersson/subscriptions","organizations_url":"https://api.github.com/users/fiddeandersson/orgs","repos_url":"https://api.github.com/users/fiddeandersson/repos","events_url":"https://api.github.com/users/fiddeandersson/events{/privacy}","received_events_url":"https://api.github.com/users/fiddeandersson/received_events","type":"User","site_admin":false},"body":"Alright @adamvoncorswant, feel free to take a peek when you get a moment. Never before has there been such a test-covered parser :tada: \r\n\r\nFYI @linnie if you're interested. EMV stuff and all that.","created_at":"2014-12-17T13:22:09Z","updated_at":"2014-12-22T09:03:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b10076c25120bbd309690a6905a154546f0663e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/97/commits","review_comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/97/comments","review_comment_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/comments/{number}","comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/97/comments","statuses_url":"https://api.github.com/repos/iZettle/izettle-toolbox/statuses/959b7397742eab9d6bf7c77be176f8c811c43bd6","head":{"label":"iZettle:tlv-redux","ref":"tlv-redux","sha":"959b7397742eab9d6bf7c77be176f8c811c43bd6","user":{"login":"iZettle","id":1272526,"avatar_url":"https://avatars.githubusercontent.com/u/1272526?v=3","gravatar_id":"","url":"https://api.github.com/users/iZettle","html_url":"https://github.com/iZettle","followers_url":"https://api.github.com/users/iZettle/followers","following_url":"https://api.github.com/users/iZettle/following{/other_user}","gists_url":"https://api.github.com/users/iZettle/gists{/gist_id}","starred_url":"https://api.github.com/users/iZettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iZettle/subscriptions","organizations_url":"https://api.github.com/users/iZettle/orgs","repos_url":"https://api.github.com/users/iZettle/repos","events_url":"https://api.github.com/users/iZettle/events{/privacy}","received_events_url":"https://api.github.com/users/iZettle/received_events","type":"Organization","site_admin":false},"repo":{"id":13087671,"name":"izettle-toolbox","full_name":"iZettle/izettle-toolbox","owner":{"login":"iZettle","id":1272526,"avatar_url":"https://avatars.githubusercontent.com/u/1272526?v=3","gravatar_id":"","url":"https://api.github.com/users/iZettle","html_url":"https://github.com/iZettle","followers_url":"https://api.github.com/users/iZettle/followers","following_url":"https://api.github.com/users/iZettle/following{/other_user}","gists_url":"https://api.github.com/users/iZettle/gists{/gist_id}","starred_url":"https://api.github.com/users/iZettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iZettle/subscriptions","organizations_url":"https://api.github.com/users/iZettle/orgs","repos_url":"https://api.github.com/users/iZettle/repos","events_url":"https://api.github.com/users/iZettle/events{/privacy}","received_events_url":"https://api.github.com/users/iZettle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iZettle/izettle-toolbox","description":"","fork":false,"url":"https://api.github.com/repos/iZettle/izettle-toolbox","forks_url":"https://api.github.com/repos/iZettle/izettle-toolbox/forks","keys_url":"https://api.github.com/repos/iZettle/izettle-toolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iZettle/izettle-toolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iZettle/izettle-toolbox/teams","hooks_url":"https://api.github.com/repos/iZettle/izettle-toolbox/hooks","issue_events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/events{/number}","events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/events","assignees_url":"https://api.github.com/repos/iZettle/izettle-toolbox/assignees{/user}","branches_url":"https://api.github.com/repos/iZettle/izettle-toolbox/branches{/branch}","tags_url":"https://api.github.com/repos/iZettle/izettle-toolbox/tags","blobs_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iZettle/izettle-toolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/iZettle/izettle-toolbox/languages","stargazers_url":"https://api.github.com/repos/iZettle/izettle-toolbox/stargazers","contributors_url":"https://api.github.com/repos/iZettle/izettle-toolbox/contributors","subscribers_url":"https://api.github.com/repos/iZettle/izettle-toolbox/subscribers","subscription_url":"https://api.github.com/repos/iZettle/izettle-toolbox/subscription","commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/comments/{number}","contents_url":"https://api.github.com/repos/iZettle/izettle-toolbox/contents/{+path}","compare_url":"https://api.github.com/repos/iZettle/izettle-toolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iZettle/izettle-toolbox/merges","archive_url":"https://api.github.com/repos/iZettle/izettle-toolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iZettle/izettle-toolbox/downloads","issues_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues{/number}","pulls_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/iZettle/izettle-toolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/iZettle/izettle-toolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iZettle/izettle-toolbox/labels{/name}","releases_url":"https://api.github.com/repos/iZettle/izettle-toolbox/releases{/id}","created_at":"2013-09-25T08:01:29Z","updated_at":"2014-09-02T13:33:31Z","pushed_at":"2014-12-19T16:04:29Z","git_url":"git://github.com/iZettle/izettle-toolbox.git","ssh_url":"git@github.com:iZettle/izettle-toolbox.git","clone_url":"https://github.com/iZettle/izettle-toolbox.git","svn_url":"https://github.com/iZettle/izettle-toolbox","homepage":null,"size":5116,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"iZettle:master","ref":"master","sha":"33890a81fb330c7a0301635e65a1db336960631d","user":{"login":"iZettle","id":1272526,"avatar_url":"https://avatars.githubusercontent.com/u/1272526?v=3","gravatar_id":"","url":"https://api.github.com/users/iZettle","html_url":"https://github.com/iZettle","followers_url":"https://api.github.com/users/iZettle/followers","following_url":"https://api.github.com/users/iZettle/following{/other_user}","gists_url":"https://api.github.com/users/iZettle/gists{/gist_id}","starred_url":"https://api.github.com/users/iZettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iZettle/subscriptions","organizations_url":"https://api.github.com/users/iZettle/orgs","repos_url":"https://api.github.com/users/iZettle/repos","events_url":"https://api.github.com/users/iZettle/events{/privacy}","received_events_url":"https://api.github.com/users/iZettle/received_events","type":"Organization","site_admin":false},"repo":{"id":13087671,"name":"izettle-toolbox","full_name":"iZettle/izettle-toolbox","owner":{"login":"iZettle","id":1272526,"avatar_url":"https://avatars.githubusercontent.com/u/1272526?v=3","gravatar_id":"","url":"https://api.github.com/users/iZettle","html_url":"https://github.com/iZettle","followers_url":"https://api.github.com/users/iZettle/followers","following_url":"https://api.github.com/users/iZettle/following{/other_user}","gists_url":"https://api.github.com/users/iZettle/gists{/gist_id}","starred_url":"https://api.github.com/users/iZettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iZettle/subscriptions","organizations_url":"https://api.github.com/users/iZettle/orgs","repos_url":"https://api.github.com/users/iZettle/repos","events_url":"https://api.github.com/users/iZettle/events{/privacy}","received_events_url":"https://api.github.com/users/iZettle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iZettle/izettle-toolbox","description":"","fork":false,"url":"https://api.github.com/repos/iZettle/izettle-toolbox","forks_url":"https://api.github.com/repos/iZettle/izettle-toolbox/forks","keys_url":"https://api.github.com/repos/iZettle/izettle-toolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iZettle/izettle-toolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iZettle/izettle-toolbox/teams","hooks_url":"https://api.github.com/repos/iZettle/izettle-toolbox/hooks","issue_events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/events{/number}","events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/events","assignees_url":"https://api.github.com/repos/iZettle/izettle-toolbox/assignees{/user}","branches_url":"https://api.github.com/repos/iZettle/izettle-toolbox/branches{/branch}","tags_url":"https://api.github.com/repos/iZettle/izettle-toolbox/tags","blobs_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iZettle/izettle-toolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/iZettle/izettle-toolbox/languages","stargazers_url":"https://api.github.com/repos/iZettle/izettle-toolbox/stargazers","contributors_url":"https://api.github.com/repos/iZettle/izettle-toolbox/contributors","subscribers_url":"https://api.github.com/repos/iZettle/izettle-toolbox/subscribers","subscription_url":"https://api.github.com/repos/iZettle/izettle-toolbox/subscription","commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/comments/{number}","contents_url":"https://api.github.com/repos/iZettle/izettle-toolbox/contents/{+path}","compare_url":"https://api.github.com/repos/iZettle/izettle-toolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iZettle/izettle-toolbox/merges","archive_url":"https://api.github.com/repos/iZettle/izettle-toolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iZettle/izettle-toolbox/downloads","issues_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues{/number}","pulls_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/iZettle/izettle-toolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/iZettle/izettle-toolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iZettle/izettle-toolbox/labels{/name}","releases_url":"https://api.github.com/repos/iZettle/izettle-toolbox/releases{/id}","created_at":"2013-09-25T08:01:29Z","updated_at":"2014-09-02T13:33:31Z","pushed_at":"2014-12-19T16:04:29Z","git_url":"git://github.com/iZettle/izettle-toolbox.git","ssh_url":"git@github.com:iZettle/izettle-toolbox.git","clone_url":"https://github.com/iZettle/izettle-toolbox.git","svn_url":"https://github.com/iZettle/izettle-toolbox","homepage":null,"size":5116,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/97"},"html":{"href":"https://github.com/iZettle/izettle-toolbox/pull/97"},"issue":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/97"},"comments":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/statuses/959b7397742eab9d6bf7c77be176f8c811c43bd6"}}}}