GitHub PullRequestReviewCommentEvent at 2014-07-18 16:24:24
Repository: deis
Actor: bacongobbler
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/deis/deis/pulls/comments/15119969","id":15119969,"diff_hunk":"@@ -113,7 +114,7 @@ if __name__ == '__main__':\n         body = {}\n         body['receive_user'] = user\n         body['receive_repo'] = app\n-        body['image'] = target_image\n+        body['image'] = build_image_reference","path":"builder/templates/builder","position":13,"original_position":13,"commit_id":"a305b30c2660cd8243a67b5abd0aa129f127d8ab","original_commit_id":"a305b30c2660cd8243a67b5abd0aa129f127d8ab","user":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?","gravatar_id":"65e1d16c6d56dd57fa47b30dcb429eed","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"body":"We have an entire `registry` module which interacts with the docker images living on the registry. It's how we achieve `config:set` et al. See https://github.com/deis/deis/tree/master/controller/registry","created_at":"2014-07-18T16:24:24Z","updated_at":"2014-07-18T16:24:24Z","html_url":"https://github.com/deis/deis/pull/1325#discussion_r15119969","pull_request_url":"https://api.github.com/repos/deis/deis/pulls/1325","_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/comments/15119969"},"html":{"href":"https://github.com/deis/deis/pull/1325#discussion_r15119969"},"pull_request":{"href":"https://api.github.com/repos/deis/deis/pulls/1325"}}},"pull_request":{"url":"https://api.github.com/repos/deis/deis/pulls/1325","id":18390522,"html_url":"https://github.com/deis/deis/pull/1325","diff_url":"https://github.com/deis/deis/pull/1325.diff","patch_url":"https://github.com/deis/deis/pull/1325.patch","issue_url":"https://api.github.com/repos/deis/deis/issues/1325","number":1325,"state":"open","title":"fix(controller): Determine registry address during start","user":{"login":"johanneswuerbach","id":864578,"avatar_url":"https://avatars.githubusercontent.com/u/864578?","gravatar_id":"06623d168d507ad99921b405593468bf","url":"https://api.github.com/users/johanneswuerbach","html_url":"https://github.com/johanneswuerbach","followers_url":"https://api.github.com/users/johanneswuerbach/followers","following_url":"https://api.github.com/users/johanneswuerbach/following{/other_user}","gists_url":"https://api.github.com/users/johanneswuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneswuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneswuerbach/subscriptions","organizations_url":"https://api.github.com/users/johanneswuerbach/orgs","repos_url":"https://api.github.com/users/johanneswuerbach/repos","events_url":"https://api.github.com/users/johanneswuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/johanneswuerbach/received_events","type":"User","site_admin":false},"body":"Before this change re-deploying apps failed when the registry was re-scheduled to a different instance in the cluster.\r\n\r\nFixes #1128","created_at":"2014-07-15T06:22:24Z","updated_at":"2014-07-18T16:24:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9dc3c68229d6c60243a3369dae6db3aca6b757a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/deis/deis/pulls/1325/commits","review_comments_url":"https://api.github.com/repos/deis/deis/pulls/1325/comments","review_comment_url":"https://api.github.com/repos/deis/deis/pulls/comments/{number}","comments_url":"https://api.github.com/repos/deis/deis/issues/1325/comments","statuses_url":"https://api.github.com/repos/deis/deis/statuses/a305b30c2660cd8243a67b5abd0aa129f127d8ab","head":{"label":"johanneswuerbach:moving-registry","ref":"moving-registry","sha":"a305b30c2660cd8243a67b5abd0aa129f127d8ab","user":{"login":"johanneswuerbach","id":864578,"avatar_url":"https://avatars.githubusercontent.com/u/864578?","gravatar_id":"06623d168d507ad99921b405593468bf","url":"https://api.github.com/users/johanneswuerbach","html_url":"https://github.com/johanneswuerbach","followers_url":"https://api.github.com/users/johanneswuerbach/followers","following_url":"https://api.github.com/users/johanneswuerbach/following{/other_user}","gists_url":"https://api.github.com/users/johanneswuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneswuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneswuerbach/subscriptions","organizations_url":"https://api.github.com/users/johanneswuerbach/orgs","repos_url":"https://api.github.com/users/johanneswuerbach/repos","events_url":"https://api.github.com/users/johanneswuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/johanneswuerbach/received_events","type":"User","site_admin":false},"repo":{"id":18689654,"name":"deis","full_name":"johanneswuerbach/deis","owner":{"login":"johanneswuerbach","id":864578,"avatar_url":"https://avatars.githubusercontent.com/u/864578?","gravatar_id":"06623d168d507ad99921b405593468bf","url":"https://api.github.com/users/johanneswuerbach","html_url":"https://github.com/johanneswuerbach","followers_url":"https://api.github.com/users/johanneswuerbach/followers","following_url":"https://api.github.com/users/johanneswuerbach/following{/other_user}","gists_url":"https://api.github.com/users/johanneswuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneswuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneswuerbach/subscriptions","organizations_url":"https://api.github.com/users/johanneswuerbach/orgs","repos_url":"https://api.github.com/users/johanneswuerbach/repos","events_url":"https://api.github.com/users/johanneswuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/johanneswuerbach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johanneswuerbach/deis","description":"Your PaaS. Your Rules. ","fork":true,"url":"https://api.github.com/repos/johanneswuerbach/deis","forks_url":"https://api.github.com/repos/johanneswuerbach/deis/forks","keys_url":"https://api.github.com/repos/johanneswuerbach/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johanneswuerbach/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johanneswuerbach/deis/teams","hooks_url":"https://api.github.com/repos/johanneswuerbach/deis/hooks","issue_events_url":"https://api.github.com/repos/johanneswuerbach/deis/issues/events{/number}","events_url":"https://api.github.com/repos/johanneswuerbach/deis/events","assignees_url":"https://api.github.com/repos/johanneswuerbach/deis/assignees{/user}","branches_url":"https://api.github.com/repos/johanneswuerbach/deis/branches{/branch}","tags_url":"https://api.github.com/repos/johanneswuerbach/deis/tags","blobs_url":"https://api.github.com/repos/johanneswuerbach/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johanneswuerbach/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johanneswuerbach/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/johanneswuerbach/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johanneswuerbach/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/johanneswuerbach/deis/languages","stargazers_url":"https://api.github.com/repos/johanneswuerbach/deis/stargazers","contributors_url":"https://api.github.com/repos/johanneswuerbach/deis/contributors","subscribers_url":"https://api.github.com/repos/johanneswuerbach/deis/subscribers","subscription_url":"https://api.github.com/repos/johanneswuerbach/deis/subscription","commits_url":"https://api.github.com/repos/johanneswuerbach/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/johanneswuerbach/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/johanneswuerbach/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/johanneswuerbach/deis/issues/comments/{number}","contents_url":"https://api.github.com/repos/johanneswuerbach/deis/contents/{+path}","compare_url":"https://api.github.com/repos/johanneswuerbach/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johanneswuerbach/deis/merges","archive_url":"https://api.github.com/repos/johanneswuerbach/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johanneswuerbach/deis/downloads","issues_url":"https://api.github.com/repos/johanneswuerbach/deis/issues{/number}","pulls_url":"https://api.github.com/repos/johanneswuerbach/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/johanneswuerbach/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/johanneswuerbach/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johanneswuerbach/deis/labels{/name}","releases_url":"https://api.github.com/repos/johanneswuerbach/deis/releases{/id}","created_at":"2014-04-11T21:41:55Z","updated_at":"2014-07-15T03:43:51Z","pushed_at":"2014-07-15T08:03:44Z","git_url":"git://github.com/johanneswuerbach/deis.git","ssh_url":"git@github.com:johanneswuerbach/deis.git","clone_url":"https://github.com/johanneswuerbach/deis.git","svn_url":"https://github.com/johanneswuerbach/deis","homepage":"http://deis.io","size":4773,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"dd6893137cffdb42b6e0e381b1edae421fba0d63","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?","gravatar_id":"3be647c7cec998059028846be064c7ba","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":11589713,"name":"deis","full_name":"deis/deis","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?","gravatar_id":"3be647c7cec998059028846be064c7ba","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/deis","description":"Your PaaS. Your Rules. ","fork":false,"url":"https://api.github.com/repos/deis/deis","forks_url":"https://api.github.com/repos/deis/deis/forks","keys_url":"https://api.github.com/repos/deis/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/deis/teams","hooks_url":"https://api.github.com/repos/deis/deis/hooks","issue_events_url":"https://api.github.com/repos/deis/deis/issues/events{/number}","events_url":"https://api.github.com/repos/deis/deis/events","assignees_url":"https://api.github.com/repos/deis/deis/assignees{/user}","branches_url":"https://api.github.com/repos/deis/deis/branches{/branch}","tags_url":"https://api.github.com/repos/deis/deis/tags","blobs_url":"https://api.github.com/repos/deis/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/deis/languages","stargazers_url":"https://api.github.com/repos/deis/deis/stargazers","contributors_url":"https://api.github.com/repos/deis/deis/contributors","subscribers_url":"https://api.github.com/repos/deis/deis/subscribers","subscription_url":"https://api.github.com/repos/deis/deis/subscription","commits_url":"https://api.github.com/repos/deis/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/deis/issues/comments/{number}","contents_url":"https://api.github.com/repos/deis/deis/contents/{+path}","compare_url":"https://api.github.com/repos/deis/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/deis/merges","archive_url":"https://api.github.com/repos/deis/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/deis/downloads","issues_url":"https://api.github.com/repos/deis/deis/issues{/number}","pulls_url":"https://api.github.com/repos/deis/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/deis/labels{/name}","releases_url":"https://api.github.com/repos/deis/deis/releases{/id}","created_at":"2013-07-22T19:02:40Z","updated_at":"2014-07-18T15:18:41Z","pushed_at":"2014-07-18T15:32:25Z","git_url":"git://github.com/deis/deis.git","ssh_url":"git@github.com:deis/deis.git","clone_url":"https://github.com/deis/deis.git","svn_url":"https://github.com/deis/deis","homepage":"http://deis.io","size":25661,"stargazers_count":2149,"watchers_count":2149,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":244,"mirror_url":null,"open_issues_count":160,"forks":244,"open_issues":160,"watchers":2149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/1325"},"html":{"href":"https://github.com/deis/deis/pull/1325"},"issue":{"href":"https://api.github.com/repos/deis/deis/issues/1325"},"comments":{"href":"https://api.github.com/repos/deis/deis/issues/1325/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/deis/pulls/1325/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/deis/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/deis/deis/pulls/1325/commits"},"statuses":{"href":"https://api.github.com/repos/deis/deis/statuses/a305b30c2660cd8243a67b5abd0aa129f127d8ab"}}}}