GitHub PullRequestReviewCommentEvent at 2014-07-26 04:19:09
Repository: sufia
Actor: jcoyne
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/projecthydra/sufia/pulls/comments/15431977","id":15431977,"diff_hunk":"@@ -42,6 +42,24 @@\n       end\n     end\n \n+    it \"should set recent documents\" do\n+      gf3 = GenericFile.new(title:['Test 3 Document'], read_groups:['public'])","path":"spec/controllers/homepage_controller_spec.rb","position":18,"original_position":18,"commit_id":"fc4fa399d5ad91c3237e2a0f9da3a22c517ecf81","original_commit_id":"fc4fa399d5ad91c3237e2a0f9da3a22c517ecf81","user":{"login":"jcoyne","id":92044,"avatar_url":"https://avatars.githubusercontent.com/u/92044?","gravatar_id":"9d5a28f7f32c760abcf49ad155683181","url":"https://api.github.com/users/jcoyne","html_url":"https://github.com/jcoyne","followers_url":"https://api.github.com/users/jcoyne/followers","following_url":"https://api.github.com/users/jcoyne/following{/other_user}","gists_url":"https://api.github.com/users/jcoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoyne/subscriptions","organizations_url":"https://api.github.com/users/jcoyne/orgs","repos_url":"https://api.github.com/users/jcoyne/repos","events_url":"https://api.github.com/users/jcoyne/events{/privacy}","received_events_url":"https://api.github.com/users/jcoyne/received_events","type":"User","site_admin":false},"body":"everything before the `get :index` ought to be in a `before` block.","created_at":"2014-07-26T04:19:09Z","updated_at":"2014-07-26T04:19:09Z","html_url":"https://github.com/projecthydra/sufia/pull/606#discussion_r15431977","pull_request_url":"https://api.github.com/repos/projecthydra/sufia/pulls/606","_links":{"self":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/comments/15431977"},"html":{"href":"https://github.com/projecthydra/sufia/pull/606#discussion_r15431977"},"pull_request":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/606"}}},"pull_request":{"url":"https://api.github.com/repos/projecthydra/sufia/pulls/606","id":18919741,"html_url":"https://github.com/projecthydra/sufia/pull/606","diff_url":"https://github.com/projecthydra/sufia/pull/606.diff","patch_url":"https://github.com/projecthydra/sufia/pull/606.patch","issue_url":"https://api.github.com/repos/projecthydra/sufia/issues/606","number":606,"state":"open","title":"fixed sorting issue on 'recently uploaded'","user":{"login":"bmaddy","id":74879,"avatar_url":"https://avatars.githubusercontent.com/u/74879?","gravatar_id":"9d918873b8f880041d8f3a8ccc11f23c","url":"https://api.github.com/users/bmaddy","html_url":"https://github.com/bmaddy","followers_url":"https://api.github.com/users/bmaddy/followers","following_url":"https://api.github.com/users/bmaddy/following{/other_user}","gists_url":"https://api.github.com/users/bmaddy/gists{/gist_id}","starred_url":"https://api.github.com/users/bmaddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmaddy/subscriptions","organizations_url":"https://api.github.com/users/bmaddy/orgs","repos_url":"https://api.github.com/users/bmaddy/repos","events_url":"https://api.github.com/users/bmaddy/events{/privacy}","received_events_url":"https://api.github.com/users/bmaddy/received_events","type":"User","site_admin":false},"body":"I also got rid of a few deprecation warnings.\r\n\r\nPSU bug: https://scm.dlt.psu.edu/issues/9463","created_at":"2014-07-25T21:16:47Z","updated_at":"2014-07-26T04:19:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"370629396490e62f7f96edbe12d9ba788bb73aa7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projecthydra/sufia/pulls/606/commits","review_comments_url":"https://api.github.com/repos/projecthydra/sufia/pulls/606/comments","review_comment_url":"https://api.github.com/repos/projecthydra/sufia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/projecthydra/sufia/issues/606/comments","statuses_url":"https://api.github.com/repos/projecthydra/sufia/statuses/fc4fa399d5ad91c3237e2a0f9da3a22c517ecf81","head":{"label":"bmaddy:recently_uploaded","ref":"recently_uploaded","sha":"fc4fa399d5ad91c3237e2a0f9da3a22c517ecf81","user":{"login":"bmaddy","id":74879,"avatar_url":"https://avatars.githubusercontent.com/u/74879?","gravatar_id":"9d918873b8f880041d8f3a8ccc11f23c","url":"https://api.github.com/users/bmaddy","html_url":"https://github.com/bmaddy","followers_url":"https://api.github.com/users/bmaddy/followers","following_url":"https://api.github.com/users/bmaddy/following{/other_user}","gists_url":"https://api.github.com/users/bmaddy/gists{/gist_id}","starred_url":"https://api.github.com/users/bmaddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmaddy/subscriptions","organizations_url":"https://api.github.com/users/bmaddy/orgs","repos_url":"https://api.github.com/users/bmaddy/repos","events_url":"https://api.github.com/users/bmaddy/events{/privacy}","received_events_url":"https://api.github.com/users/bmaddy/received_events","type":"User","site_admin":false},"repo":{"id":16554965,"name":"sufia","full_name":"bmaddy/sufia","owner":{"login":"bmaddy","id":74879,"avatar_url":"https://avatars.githubusercontent.com/u/74879?","gravatar_id":"9d918873b8f880041d8f3a8ccc11f23c","url":"https://api.github.com/users/bmaddy","html_url":"https://github.com/bmaddy","followers_url":"https://api.github.com/users/bmaddy/followers","following_url":"https://api.github.com/users/bmaddy/following{/other_user}","gists_url":"https://api.github.com/users/bmaddy/gists{/gist_id}","starred_url":"https://api.github.com/users/bmaddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmaddy/subscriptions","organizations_url":"https://api.github.com/users/bmaddy/orgs","repos_url":"https://api.github.com/users/bmaddy/repos","events_url":"https://api.github.com/users/bmaddy/events{/privacy}","received_events_url":"https://api.github.com/users/bmaddy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmaddy/sufia","description":"Sufia is a Rails engine for creating a self-deposit institutional repository. A web application for ingest, curation, search, and display of digital assets. Powered by Hydra technologies (Rails, Hydra-head, Blacklight, Solr, Fedora Commons, etc.)","fork":true,"url":"https://api.github.com/repos/bmaddy/sufia","forks_url":"https://api.github.com/repos/bmaddy/sufia/forks","keys_url":"https://api.github.com/repos/bmaddy/sufia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmaddy/sufia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmaddy/sufia/teams","hooks_url":"https://api.github.com/repos/bmaddy/sufia/hooks","issue_events_url":"https://api.github.com/repos/bmaddy/sufia/issues/events{/number}","events_url":"https://api.github.com/repos/bmaddy/sufia/events","assignees_url":"https://api.github.com/repos/bmaddy/sufia/assignees{/user}","branches_url":"https://api.github.com/repos/bmaddy/sufia/branches{/branch}","tags_url":"https://api.github.com/repos/bmaddy/sufia/tags","blobs_url":"https://api.github.com/repos/bmaddy/sufia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmaddy/sufia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmaddy/sufia/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmaddy/sufia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmaddy/sufia/statuses/{sha}","languages_url":"https://api.github.com/repos/bmaddy/sufia/languages","stargazers_url":"https://api.github.com/repos/bmaddy/sufia/stargazers","contributors_url":"https://api.github.com/repos/bmaddy/sufia/contributors","subscribers_url":"https://api.github.com/repos/bmaddy/sufia/subscribers","subscription_url":"https://api.github.com/repos/bmaddy/sufia/subscription","commits_url":"https://api.github.com/repos/bmaddy/sufia/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmaddy/sufia/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmaddy/sufia/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmaddy/sufia/issues/comments/{number}","contents_url":"https://api.github.com/repos/bmaddy/sufia/contents/{+path}","compare_url":"https://api.github.com/repos/bmaddy/sufia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmaddy/sufia/merges","archive_url":"https://api.github.com/repos/bmaddy/sufia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmaddy/sufia/downloads","issues_url":"https://api.github.com/repos/bmaddy/sufia/issues{/number}","pulls_url":"https://api.github.com/repos/bmaddy/sufia/pulls{/number}","milestones_url":"https://api.github.com/repos/bmaddy/sufia/milestones{/number}","notifications_url":"https://api.github.com/repos/bmaddy/sufia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmaddy/sufia/labels{/name}","releases_url":"https://api.github.com/repos/bmaddy/sufia/releases{/id}","created_at":"2014-02-05T19:08:51Z","updated_at":"2014-07-22T14:58:14Z","pushed_at":"2014-07-25T21:15:51Z","git_url":"git://github.com/bmaddy/sufia.git","ssh_url":"git@github.com:bmaddy/sufia.git","clone_url":"https://github.com/bmaddy/sufia.git","svn_url":"https://github.com/bmaddy/sufia","homepage":"","size":50962,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projecthydra:master","ref":"master","sha":"e8f043687e4cdf9943c5967b20818ff15930357e","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?","gravatar_id":"3213c2451b77aebba8b383361276259c","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":7653178,"name":"sufia","full_name":"projecthydra/sufia","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?","gravatar_id":"3213c2451b77aebba8b383361276259c","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/sufia","description":"Sufia is a Rails engine for creating a self-deposit institutional repository. A web application for ingest, curation, search, and display of digital assets. Powered by Hydra technologies (Rails, Hydra-head, Blacklight, Solr, Fedora Commons, etc.)","fork":false,"url":"https://api.github.com/repos/projecthydra/sufia","forks_url":"https://api.github.com/repos/projecthydra/sufia/forks","keys_url":"https://api.github.com/repos/projecthydra/sufia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/sufia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/sufia/teams","hooks_url":"https://api.github.com/repos/projecthydra/sufia/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/sufia/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/sufia/events","assignees_url":"https://api.github.com/repos/projecthydra/sufia/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/sufia/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/sufia/tags","blobs_url":"https://api.github.com/repos/projecthydra/sufia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/sufia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/sufia/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/sufia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/sufia/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/sufia/languages","stargazers_url":"https://api.github.com/repos/projecthydra/sufia/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/sufia/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/sufia/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/sufia/subscription","commits_url":"https://api.github.com/repos/projecthydra/sufia/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/sufia/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/sufia/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/sufia/issues/comments/{number}","contents_url":"https://api.github.com/repos/projecthydra/sufia/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/sufia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/sufia/merges","archive_url":"https://api.github.com/repos/projecthydra/sufia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/sufia/downloads","issues_url":"https://api.github.com/repos/projecthydra/sufia/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/sufia/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/sufia/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/sufia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/sufia/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/sufia/releases{/id}","created_at":"2013-01-16T20:23:18Z","updated_at":"2014-07-03T18:40:29Z","pushed_at":"2014-07-26T04:18:02Z","git_url":"git://github.com/projecthydra/sufia.git","ssh_url":"git@github.com:projecthydra/sufia.git","clone_url":"https://github.com/projecthydra/sufia.git","svn_url":"https://github.com/projecthydra/sufia","homepage":"","size":60165,"stargazers_count":34,"watchers_count":34,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":33,"mirror_url":null,"open_issues_count":37,"forks":33,"open_issues":37,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/606"},"html":{"href":"https://github.com/projecthydra/sufia/pull/606"},"issue":{"href":"https://api.github.com/repos/projecthydra/sufia/issues/606"},"comments":{"href":"https://api.github.com/repos/projecthydra/sufia/issues/606/comments"},"review_comments":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/606/comments"},"review_comment":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/606/commits"},"statuses":{"href":"https://api.github.com/repos/projecthydra/sufia/statuses/fc4fa399d5ad91c3237e2a0f9da3a22c517ecf81"}}}}