GitHub PullRequestReviewCommentEvent at 2014-11-07 22:28:32
Repository: jclouds-labs-google
Actor: mattstep
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments/20041916","id":20041916,"diff_hunk":"@@ -77,26 +78,44 @@\n    @VisibleForTesting\n    static final class OAuthCredentialsForCredentials extends CacheLoader<Credentials, OAuthCredentials> {\n       private final String keyFactoryAlgorithm;\n+      private final CredentialType credentialType;\n \n-      @Inject OAuthCredentialsForCredentials(@Named(SIGNATURE_OR_MAC_ALGORITHM) String signatureOrMacAlgorithm) {\n+      @Inject\n+      public OAuthCredentialsForCredentials(@Named(SIGNATURE_OR_MAC_ALGORITHM) String signatureOrMacAlgorithm,\n+            CredentialType credentialType) {\n          this.keyFactoryAlgorithm = OAUTH_ALGORITHM_NAMES_TO_KEYFACTORY_ALGORITHM_NAMES.get(checkNotNull(\n                  signatureOrMacAlgorithm, \"signatureOrMacAlgorithm\"));\n+         this.credentialType = credentialType;\n       }\n \n       @Override public OAuthCredentials load(Credentials in) {\n          try {\n-            String identity = in.identity;\n             String privateKeyInPemFormat = in.credential;\n+            String identity = in.identity;\n+\n+            // If passing Bearer tokens, simply create and pass it along\n+            if (credentialType == CredentialType.BEARER_TOKEN_CREDENTIALS) {","path":"oauth/src/main/java/org/jclouds/oauth/v2/functions/OAuthCredentialsSupplier.java","position":62,"original_position":62,"commit_id":"21a10dcde672166d0696a3f3d6c23c3901a70113","original_commit_id":"21a10dcde672166d0696a3f3d6c23c3901a70113","user":{"login":"mattstep","id":436917,"avatar_url":"https://avatars.githubusercontent.com/u/436917?v=3","gravatar_id":"","url":"https://api.github.com/users/mattstep","html_url":"https://github.com/mattstep","followers_url":"https://api.github.com/users/mattstep/followers","following_url":"https://api.github.com/users/mattstep/following{/other_user}","gists_url":"https://api.github.com/users/mattstep/gists{/gist_id}","starred_url":"https://api.github.com/users/mattstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattstep/subscriptions","organizations_url":"https://api.github.com/users/mattstep/orgs","repos_url":"https://api.github.com/users/mattstep/repos","events_url":"https://api.github.com/users/mattstep/events{/privacy}","received_events_url":"https://api.github.com/users/mattstep/received_events","type":"User","site_admin":false},"body":"static import","created_at":"2014-11-07T22:28:32Z","updated_at":"2014-11-07T22:28:32Z","html_url":"https://github.com/jclouds/jclouds-labs-google/pull/84#discussion_r20041916","pull_request_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments/20041916"},"html":{"href":"https://github.com/jclouds/jclouds-labs-google/pull/84#discussion_r20041916"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/84","id":24087028,"html_url":"https://github.com/jclouds/jclouds-labs-google/pull/84","diff_url":"https://github.com/jclouds/jclouds-labs-google/pull/84.diff","patch_url":"https://github.com/jclouds/jclouds-labs-google/pull/84.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/84","number":84,"state":"open","locked":false,"title":"Support reading key from file","user":{"login":"ccustine","id":124975,"avatar_url":"https://avatars.githubusercontent.com/u/124975?v=3","gravatar_id":"","url":"https://api.github.com/users/ccustine","html_url":"https://github.com/ccustine","followers_url":"https://api.github.com/users/ccustine/followers","following_url":"https://api.github.com/users/ccustine/following{/other_user}","gists_url":"https://api.github.com/users/ccustine/gists{/gist_id}","starred_url":"https://api.github.com/users/ccustine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccustine/subscriptions","organizations_url":"https://api.github.com/users/ccustine/orgs","repos_url":"https://api.github.com/users/ccustine/repos","events_url":"https://api.github.com/users/ccustine/events{/privacy}","received_events_url":"https://api.github.com/users/ccustine/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-07T22:23:58Z","updated_at":"2014-11-07T22:28:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94ffbbcd8cd43dc7c4b23d19d811e7f9d7e8d6d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/84/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/84/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/84/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/statuses/21a10dcde672166d0696a3f3d6c23c3901a70113","head":{"label":"ccustine:features/fixes","ref":"features/fixes","sha":"21a10dcde672166d0696a3f3d6c23c3901a70113","user":{"login":"ccustine","id":124975,"avatar_url":"https://avatars.githubusercontent.com/u/124975?v=3","gravatar_id":"","url":"https://api.github.com/users/ccustine","html_url":"https://github.com/ccustine","followers_url":"https://api.github.com/users/ccustine/followers","following_url":"https://api.github.com/users/ccustine/following{/other_user}","gists_url":"https://api.github.com/users/ccustine/gists{/gist_id}","starred_url":"https://api.github.com/users/ccustine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccustine/subscriptions","organizations_url":"https://api.github.com/users/ccustine/orgs","repos_url":"https://api.github.com/users/ccustine/repos","events_url":"https://api.github.com/users/ccustine/events{/privacy}","received_events_url":"https://api.github.com/users/ccustine/received_events","type":"User","site_admin":false},"repo":{"id":21996376,"name":"jclouds-labs-google","full_name":"ccustine/jclouds-labs-google","owner":{"login":"ccustine","id":124975,"avatar_url":"https://avatars.githubusercontent.com/u/124975?v=3","gravatar_id":"","url":"https://api.github.com/users/ccustine","html_url":"https://github.com/ccustine","followers_url":"https://api.github.com/users/ccustine/followers","following_url":"https://api.github.com/users/ccustine/following{/other_user}","gists_url":"https://api.github.com/users/ccustine/gists{/gist_id}","starred_url":"https://api.github.com/users/ccustine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccustine/subscriptions","organizations_url":"https://api.github.com/users/ccustine/orgs","repos_url":"https://api.github.com/users/ccustine/repos","events_url":"https://api.github.com/users/ccustine/events{/privacy}","received_events_url":"https://api.github.com/users/ccustine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ccustine/jclouds-labs-google","description":"Read-only mirror of ASF Git Repo for jclouds labs-google","fork":true,"url":"https://api.github.com/repos/ccustine/jclouds-labs-google","forks_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/forks","keys_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/teams","hooks_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/hooks","issue_events_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/issues/events{/number}","events_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/events","assignees_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/assignees{/user}","branches_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/branches{/branch}","tags_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/tags","blobs_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/statuses/{sha}","languages_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/languages","stargazers_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/stargazers","contributors_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/contributors","subscribers_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/subscribers","subscription_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/subscription","commits_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/issues/comments/{number}","contents_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/contents/{+path}","compare_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/merges","archive_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/downloads","issues_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/issues{/number}","pulls_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/pulls{/number}","milestones_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/milestones{/number}","notifications_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/labels{/name}","releases_url":"https://api.github.com/repos/ccustine/jclouds-labs-google/releases{/id}","created_at":"2014-07-18T22:32:23Z","updated_at":"2014-06-27T22:24:12Z","pushed_at":"2014-11-07T22:20:07Z","git_url":"git://github.com/ccustine/jclouds-labs-google.git","ssh_url":"git@github.com:ccustine/jclouds-labs-google.git","clone_url":"https://github.com/ccustine/jclouds-labs-google.git","svn_url":"https://github.com/ccustine/jclouds-labs-google","homepage":null,"size":1479,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jclouds:master","ref":"master","sha":"04c02a993209a6a100104e747837ed2ef63506dc","user":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10040995,"name":"jclouds-labs-google","full_name":"jclouds/jclouds-labs-google","owner":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds-labs-google","description":"Read-only mirror of ASF Git Repo for jclouds labs-google","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds-labs-google","forks_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/comments/{number}","contents_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/releases{/id}","created_at":"2013-05-13T20:48:38Z","updated_at":"2014-11-06T15:16:19Z","pushed_at":"2014-11-07T16:18:46Z","git_url":"git://github.com/jclouds/jclouds-labs-google.git","ssh_url":"git@github.com:jclouds/jclouds-labs-google.git","clone_url":"https://github.com/jclouds/jclouds-labs-google.git","svn_url":"https://github.com/jclouds/jclouds-labs-google","homepage":null,"size":4164,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":1,"forks":32,"open_issues":1,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/84"},"html":{"href":"https://github.com/jclouds/jclouds-labs-google/pull/84"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/84"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/statuses/21a10dcde672166d0696a3f3d6c23c3901a70113"}}}}