GitHub PullRequestReviewCommentEvent at 2014-11-19 07:12:03
Repository: qutip
Actor: jrjohansson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/qutip/qutip/pulls/comments/20560503","id":20560503,"diff_hunk":"@@ -54,12 +54,10 @@\n from qutip.graph import reverse_cuthill_mckee, weighted_bipartite_matching\n import qutip.settings as settings\n from qutip.utilities import _version2int\n-\n-if settings.debug:\n-    import qutip.logging\n-    import inspect\n-    logger = qutip.logging.get_logger('steady_state')\n-    logger.setLevel('DEBUG')\n+import qutip.logging\n+import inspect\n+logger = qutip.logging.get_logger()\n+logger.setLevel('DEBUG')","path":"qutip/steadystate.py","position":13,"original_position":13,"commit_id":"bb0b70dea7ef30948f6e0f9f3a13086376fe2a78","original_commit_id":"bb0b70dea7ef30948f6e0f9f3a13086376fe2a78","user":{"login":"jrjohansson","id":1198183,"avatar_url":"https://avatars.githubusercontent.com/u/1198183?v=3","gravatar_id":"","url":"https://api.github.com/users/jrjohansson","html_url":"https://github.com/jrjohansson","followers_url":"https://api.github.com/users/jrjohansson/followers","following_url":"https://api.github.com/users/jrjohansson/following{/other_user}","gists_url":"https://api.github.com/users/jrjohansson/gists{/gist_id}","starred_url":"https://api.github.com/users/jrjohansson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrjohansson/subscriptions","organizations_url":"https://api.github.com/users/jrjohansson/orgs","repos_url":"https://api.github.com/users/jrjohansson/repos","events_url":"https://api.github.com/users/jrjohansson/events{/privacy}","received_events_url":"https://api.github.com/users/jrjohansson/received_events","type":"User","site_admin":false},"body":"setLevel should be taken care of inside qutip.logging.get_logger so it should not be necessary if qutip.settings.debug is true ? or maybe there is a glitch there?","created_at":"2014-11-19T07:12:03Z","updated_at":"2014-11-19T07:12:03Z","html_url":"https://github.com/qutip/qutip/pull/261#discussion_r20560503","pull_request_url":"https://api.github.com/repos/qutip/qutip/pulls/261","_links":{"self":{"href":"https://api.github.com/repos/qutip/qutip/pulls/comments/20560503"},"html":{"href":"https://github.com/qutip/qutip/pull/261#discussion_r20560503"},"pull_request":{"href":"https://api.github.com/repos/qutip/qutip/pulls/261"}}},"pull_request":{"url":"https://api.github.com/repos/qutip/qutip/pulls/261","id":24669012,"html_url":"https://github.com/qutip/qutip/pull/261","diff_url":"https://github.com/qutip/qutip/pull/261.diff","patch_url":"https://github.com/qutip/qutip/pull/261.patch","issue_url":"https://api.github.com/repos/qutip/qutip/issues/261","number":261,"state":"open","locked":false,"title":"Fixed logging in SS module","user":{"login":"nonhermitian","id":1249193,"avatar_url":"https://avatars.githubusercontent.com/u/1249193?v=3","gravatar_id":"","url":"https://api.github.com/users/nonhermitian","html_url":"https://github.com/nonhermitian","followers_url":"https://api.github.com/users/nonhermitian/followers","following_url":"https://api.github.com/users/nonhermitian/following{/other_user}","gists_url":"https://api.github.com/users/nonhermitian/gists{/gist_id}","starred_url":"https://api.github.com/users/nonhermitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonhermitian/subscriptions","organizations_url":"https://api.github.com/users/nonhermitian/orgs","repos_url":"https://api.github.com/users/nonhermitian/repos","events_url":"https://api.github.com/users/nonhermitian/events{/privacy}","received_events_url":"https://api.github.com/users/nonhermitian/received_events","type":"User","site_admin":false},"body":"- The debug setting is off by default so conditional loading of the\r\nlogging feature does not work.  Here we load the logger by default, but\r\ndo not log anything unless the debug feature is set.\r\n\r\n- Also got rid of the inspect stack as I do not see the point of that.","created_at":"2014-11-19T06:49:55Z","updated_at":"2014-11-19T07:12:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a12303f14de95a2dbcc82dfb7671fed7df05bd4","assignee":{"login":"nonhermitian","id":1249193,"avatar_url":"https://avatars.githubusercontent.com/u/1249193?v=3","gravatar_id":"","url":"https://api.github.com/users/nonhermitian","html_url":"https://github.com/nonhermitian","followers_url":"https://api.github.com/users/nonhermitian/followers","following_url":"https://api.github.com/users/nonhermitian/following{/other_user}","gists_url":"https://api.github.com/users/nonhermitian/gists{/gist_id}","starred_url":"https://api.github.com/users/nonhermitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonhermitian/subscriptions","organizations_url":"https://api.github.com/users/nonhermitian/orgs","repos_url":"https://api.github.com/users/nonhermitian/repos","events_url":"https://api.github.com/users/nonhermitian/events{/privacy}","received_events_url":"https://api.github.com/users/nonhermitian/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/qutip/qutip/pulls/261/commits","review_comments_url":"https://api.github.com/repos/qutip/qutip/pulls/261/comments","review_comment_url":"https://api.github.com/repos/qutip/qutip/pulls/comments/{number}","comments_url":"https://api.github.com/repos/qutip/qutip/issues/261/comments","statuses_url":"https://api.github.com/repos/qutip/qutip/statuses/bb0b70dea7ef30948f6e0f9f3a13086376fe2a78","head":{"label":"nonhermitian:steady_state_logging","ref":"steady_state_logging","sha":"bb0b70dea7ef30948f6e0f9f3a13086376fe2a78","user":{"login":"nonhermitian","id":1249193,"avatar_url":"https://avatars.githubusercontent.com/u/1249193?v=3","gravatar_id":"","url":"https://api.github.com/users/nonhermitian","html_url":"https://github.com/nonhermitian","followers_url":"https://api.github.com/users/nonhermitian/followers","following_url":"https://api.github.com/users/nonhermitian/following{/other_user}","gists_url":"https://api.github.com/users/nonhermitian/gists{/gist_id}","starred_url":"https://api.github.com/users/nonhermitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonhermitian/subscriptions","organizations_url":"https://api.github.com/users/nonhermitian/orgs","repos_url":"https://api.github.com/users/nonhermitian/repos","events_url":"https://api.github.com/users/nonhermitian/events{/privacy}","received_events_url":"https://api.github.com/users/nonhermitian/received_events","type":"User","site_admin":false},"repo":{"id":26847087,"name":"qutip","full_name":"nonhermitian/qutip","owner":{"login":"nonhermitian","id":1249193,"avatar_url":"https://avatars.githubusercontent.com/u/1249193?v=3","gravatar_id":"","url":"https://api.github.com/users/nonhermitian","html_url":"https://github.com/nonhermitian","followers_url":"https://api.github.com/users/nonhermitian/followers","following_url":"https://api.github.com/users/nonhermitian/following{/other_user}","gists_url":"https://api.github.com/users/nonhermitian/gists{/gist_id}","starred_url":"https://api.github.com/users/nonhermitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonhermitian/subscriptions","organizations_url":"https://api.github.com/users/nonhermitian/orgs","repos_url":"https://api.github.com/users/nonhermitian/repos","events_url":"https://api.github.com/users/nonhermitian/events{/privacy}","received_events_url":"https://api.github.com/users/nonhermitian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nonhermitian/qutip","description":"QuTiP: Quantum Toolbox in Python","fork":true,"url":"https://api.github.com/repos/nonhermitian/qutip","forks_url":"https://api.github.com/repos/nonhermitian/qutip/forks","keys_url":"https://api.github.com/repos/nonhermitian/qutip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nonhermitian/qutip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nonhermitian/qutip/teams","hooks_url":"https://api.github.com/repos/nonhermitian/qutip/hooks","issue_events_url":"https://api.github.com/repos/nonhermitian/qutip/issues/events{/number}","events_url":"https://api.github.com/repos/nonhermitian/qutip/events","assignees_url":"https://api.github.com/repos/nonhermitian/qutip/assignees{/user}","branches_url":"https://api.github.com/repos/nonhermitian/qutip/branches{/branch}","tags_url":"https://api.github.com/repos/nonhermitian/qutip/tags","blobs_url":"https://api.github.com/repos/nonhermitian/qutip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nonhermitian/qutip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nonhermitian/qutip/git/refs{/sha}","trees_url":"https://api.github.com/repos/nonhermitian/qutip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nonhermitian/qutip/statuses/{sha}","languages_url":"https://api.github.com/repos/nonhermitian/qutip/languages","stargazers_url":"https://api.github.com/repos/nonhermitian/qutip/stargazers","contributors_url":"https://api.github.com/repos/nonhermitian/qutip/contributors","subscribers_url":"https://api.github.com/repos/nonhermitian/qutip/subscribers","subscription_url":"https://api.github.com/repos/nonhermitian/qutip/subscription","commits_url":"https://api.github.com/repos/nonhermitian/qutip/commits{/sha}","git_commits_url":"https://api.github.com/repos/nonhermitian/qutip/git/commits{/sha}","comments_url":"https://api.github.com/repos/nonhermitian/qutip/comments{/number}","issue_comment_url":"https://api.github.com/repos/nonhermitian/qutip/issues/comments/{number}","contents_url":"https://api.github.com/repos/nonhermitian/qutip/contents/{+path}","compare_url":"https://api.github.com/repos/nonhermitian/qutip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nonhermitian/qutip/merges","archive_url":"https://api.github.com/repos/nonhermitian/qutip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nonhermitian/qutip/downloads","issues_url":"https://api.github.com/repos/nonhermitian/qutip/issues{/number}","pulls_url":"https://api.github.com/repos/nonhermitian/qutip/pulls{/number}","milestones_url":"https://api.github.com/repos/nonhermitian/qutip/milestones{/number}","notifications_url":"https://api.github.com/repos/nonhermitian/qutip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nonhermitian/qutip/labels{/name}","releases_url":"https://api.github.com/repos/nonhermitian/qutip/releases{/id}","created_at":"2014-11-19T06:02:58Z","updated_at":"2014-11-19T06:02:59Z","pushed_at":"2014-11-19T07:02:10Z","git_url":"git://github.com/nonhermitian/qutip.git","ssh_url":"git@github.com:nonhermitian/qutip.git","clone_url":"https://github.com/nonhermitian/qutip.git","svn_url":"https://github.com/nonhermitian/qutip","homepage":null,"size":24984,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qutip:master","ref":"master","sha":"2167595da1702054b6eb185452bb98ffc530f70c","user":{"login":"qutip","id":2517630,"avatar_url":"https://avatars.githubusercontent.com/u/2517630?v=3","gravatar_id":"","url":"https://api.github.com/users/qutip","html_url":"https://github.com/qutip","followers_url":"https://api.github.com/users/qutip/followers","following_url":"https://api.github.com/users/qutip/following{/other_user}","gists_url":"https://api.github.com/users/qutip/gists{/gist_id}","starred_url":"https://api.github.com/users/qutip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qutip/subscriptions","organizations_url":"https://api.github.com/users/qutip/orgs","repos_url":"https://api.github.com/users/qutip/repos","events_url":"https://api.github.com/users/qutip/events{/privacy}","received_events_url":"https://api.github.com/users/qutip/received_events","type":"Organization","site_admin":false},"repo":{"id":6136261,"name":"qutip","full_name":"qutip/qutip","owner":{"login":"qutip","id":2517630,"avatar_url":"https://avatars.githubusercontent.com/u/2517630?v=3","gravatar_id":"","url":"https://api.github.com/users/qutip","html_url":"https://github.com/qutip","followers_url":"https://api.github.com/users/qutip/followers","following_url":"https://api.github.com/users/qutip/following{/other_user}","gists_url":"https://api.github.com/users/qutip/gists{/gist_id}","starred_url":"https://api.github.com/users/qutip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qutip/subscriptions","organizations_url":"https://api.github.com/users/qutip/orgs","repos_url":"https://api.github.com/users/qutip/repos","events_url":"https://api.github.com/users/qutip/events{/privacy}","received_events_url":"https://api.github.com/users/qutip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qutip/qutip","description":"QuTiP: Quantum Toolbox in Python","fork":false,"url":"https://api.github.com/repos/qutip/qutip","forks_url":"https://api.github.com/repos/qutip/qutip/forks","keys_url":"https://api.github.com/repos/qutip/qutip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qutip/qutip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qutip/qutip/teams","hooks_url":"https://api.github.com/repos/qutip/qutip/hooks","issue_events_url":"https://api.github.com/repos/qutip/qutip/issues/events{/number}","events_url":"https://api.github.com/repos/qutip/qutip/events","assignees_url":"https://api.github.com/repos/qutip/qutip/assignees{/user}","branches_url":"https://api.github.com/repos/qutip/qutip/branches{/branch}","tags_url":"https://api.github.com/repos/qutip/qutip/tags","blobs_url":"https://api.github.com/repos/qutip/qutip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qutip/qutip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qutip/qutip/git/refs{/sha}","trees_url":"https://api.github.com/repos/qutip/qutip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qutip/qutip/statuses/{sha}","languages_url":"https://api.github.com/repos/qutip/qutip/languages","stargazers_url":"https://api.github.com/repos/qutip/qutip/stargazers","contributors_url":"https://api.github.com/repos/qutip/qutip/contributors","subscribers_url":"https://api.github.com/repos/qutip/qutip/subscribers","subscription_url":"https://api.github.com/repos/qutip/qutip/subscription","commits_url":"https://api.github.com/repos/qutip/qutip/commits{/sha}","git_commits_url":"https://api.github.com/repos/qutip/qutip/git/commits{/sha}","comments_url":"https://api.github.com/repos/qutip/qutip/comments{/number}","issue_comment_url":"https://api.github.com/repos/qutip/qutip/issues/comments/{number}","contents_url":"https://api.github.com/repos/qutip/qutip/contents/{+path}","compare_url":"https://api.github.com/repos/qutip/qutip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qutip/qutip/merges","archive_url":"https://api.github.com/repos/qutip/qutip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qutip/qutip/downloads","issues_url":"https://api.github.com/repos/qutip/qutip/issues{/number}","pulls_url":"https://api.github.com/repos/qutip/qutip/pulls{/number}","milestones_url":"https://api.github.com/repos/qutip/qutip/milestones{/number}","notifications_url":"https://api.github.com/repos/qutip/qutip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qutip/qutip/labels{/name}","releases_url":"https://api.github.com/repos/qutip/qutip/releases{/id}","created_at":"2012-10-09T06:20:46Z","updated_at":"2014-11-19T06:11:00Z","pushed_at":"2014-11-19T06:11:00Z","git_url":"git://github.com/qutip/qutip.git","ssh_url":"git@github.com:qutip/qutip.git","clone_url":"https://github.com/qutip/qutip.git","svn_url":"https://github.com/qutip/qutip","homepage":null,"size":24984,"stargazers_count":67,"watchers_count":67,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":24,"forks":48,"open_issues":24,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qutip/qutip/pulls/261"},"html":{"href":"https://github.com/qutip/qutip/pull/261"},"issue":{"href":"https://api.github.com/repos/qutip/qutip/issues/261"},"comments":{"href":"https://api.github.com/repos/qutip/qutip/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/qutip/qutip/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/qutip/qutip/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/qutip/qutip/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/qutip/qutip/statuses/bb0b70dea7ef30948f6e0f9f3a13086376fe2a78"}}}}