GitHub PullRequestReviewCommentEvent at 2014-07-04 17:59:33
Repository: RxJava
Actor: akarnokd
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/RxJava/pulls/comments/14565901","id":14565901,"diff_hunk":"@@ -136,7 +136,22 @@ private void pollQueue() {\n                     if (v == null) {\n                         break;\n                     }\n-                    on.accept(observer, v);\n+\n+                    switch (on.kind(v)) {","path":"rxjava-core/src/main/java/rx/internal/operators/OperatorObserveOn.java","position":43,"original_position":43,"commit_id":"a329581ecd3af9ba565115a6d5d49304da89c907","original_commit_id":"a329581ecd3af9ba565115a6d5d49304da89c907","user":{"login":"akarnokd","id":1269832,"avatar_url":"https://avatars.githubusercontent.com/u/1269832?","gravatar_id":"db0a0198951e15aadcb42b40452c29f7","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"body":"This kind switch adds about 20% overhead to the value delivery. Use on.isError and on.isCompleted instead","created_at":"2014-07-04T17:59:33Z","updated_at":"2014-07-04T17:59:33Z","html_url":"https://github.com/Netflix/RxJava/pull/1409#discussion_r14565901","pull_request_url":"https://api.github.com/repos/Netflix/RxJava/pulls/1409","_links":{"self":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/comments/14565901"},"html":{"href":"https://github.com/Netflix/RxJava/pull/1409#discussion_r14565901"},"pull_request":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/1409"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/RxJava/pulls/1409","id":18001956,"html_url":"https://github.com/Netflix/RxJava/pull/1409","diff_url":"https://github.com/Netflix/RxJava/pull/1409.diff","patch_url":"https://github.com/Netflix/RxJava/pull/1409.patch","issue_url":"https://api.github.com/repos/Netflix/RxJava/issues/1409","number":1409,"state":"open","title":"Avoiding OperatorObserveOn from calling subscriber.onNext(..) after unsu...","user":{"login":"dpsm","id":42935,"avatar_url":"https://avatars.githubusercontent.com/u/42935?","gravatar_id":"df16e966d2b14f209127440a7b0c0ef6","url":"https://api.github.com/users/dpsm","html_url":"https://github.com/dpsm","followers_url":"https://api.github.com/users/dpsm/followers","following_url":"https://api.github.com/users/dpsm/following{/other_user}","gists_url":"https://api.github.com/users/dpsm/gists{/gist_id}","starred_url":"https://api.github.com/users/dpsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpsm/subscriptions","organizations_url":"https://api.github.com/users/dpsm/orgs","repos_url":"https://api.github.com/users/dpsm/repos","events_url":"https://api.github.com/users/dpsm/events{/privacy}","received_events_url":"https://api.github.com/users/dpsm/received_events","type":"User","site_admin":false},"body":"...bscribe().\r\n\r\nThe OperatorObserveOn operator uses a scheduler to cancel subscriptions as well\r\nas to deliver the objects passing through it's onNext(..) in the right context.\r\n\r\nCalling unsubscribe will schedule the actual unsubscription while not making sure\r\nthat the child subscriber will no longer receive calls to onNext(..) after\r\nunsubscribe() returns.\r\n\r\nThis fix makes sure that after unsubscribe() returns no more onNext(..) calls will be\r\nmade on the child subscribers.\r\n\r\nSigned-off-by: David Marques <dpsmarques@gmail.com>","created_at":"2014-07-04T17:43:00Z","updated_at":"2014-07-04T17:59:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ca60cba27ea6044e359610f5dbe63bfee1c018b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/RxJava/pulls/1409/commits","review_comments_url":"https://api.github.com/repos/Netflix/RxJava/pulls/1409/comments","review_comment_url":"https://api.github.com/repos/Netflix/RxJava/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Netflix/RxJava/issues/1409/comments","statuses_url":"https://api.github.com/repos/Netflix/RxJava/statuses/a329581ecd3af9ba565115a6d5d49304da89c907","head":{"label":"dpsm:master","ref":"master","sha":"a329581ecd3af9ba565115a6d5d49304da89c907","user":{"login":"dpsm","id":42935,"avatar_url":"https://avatars.githubusercontent.com/u/42935?","gravatar_id":"df16e966d2b14f209127440a7b0c0ef6","url":"https://api.github.com/users/dpsm","html_url":"https://github.com/dpsm","followers_url":"https://api.github.com/users/dpsm/followers","following_url":"https://api.github.com/users/dpsm/following{/other_user}","gists_url":"https://api.github.com/users/dpsm/gists{/gist_id}","starred_url":"https://api.github.com/users/dpsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpsm/subscriptions","organizations_url":"https://api.github.com/users/dpsm/orgs","repos_url":"https://api.github.com/users/dpsm/repos","events_url":"https://api.github.com/users/dpsm/events{/privacy}","received_events_url":"https://api.github.com/users/dpsm/received_events","type":"User","site_admin":false},"repo":{"id":20490733,"name":"RxJava","full_name":"dpsm/RxJava","owner":{"login":"dpsm","id":42935,"avatar_url":"https://avatars.githubusercontent.com/u/42935?","gravatar_id":"df16e966d2b14f209127440a7b0c0ef6","url":"https://api.github.com/users/dpsm","html_url":"https://github.com/dpsm","followers_url":"https://api.github.com/users/dpsm/followers","following_url":"https://api.github.com/users/dpsm/following{/other_user}","gists_url":"https://api.github.com/users/dpsm/gists{/gist_id}","starred_url":"https://api.github.com/users/dpsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpsm/subscriptions","organizations_url":"https://api.github.com/users/dpsm/orgs","repos_url":"https://api.github.com/users/dpsm/repos","events_url":"https://api.github.com/users/dpsm/events{/privacy}","received_events_url":"https://api.github.com/users/dpsm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpsm/RxJava","description":"RxJava – Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":true,"url":"https://api.github.com/repos/dpsm/RxJava","forks_url":"https://api.github.com/repos/dpsm/RxJava/forks","keys_url":"https://api.github.com/repos/dpsm/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpsm/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpsm/RxJava/teams","hooks_url":"https://api.github.com/repos/dpsm/RxJava/hooks","issue_events_url":"https://api.github.com/repos/dpsm/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/dpsm/RxJava/events","assignees_url":"https://api.github.com/repos/dpsm/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/dpsm/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/dpsm/RxJava/tags","blobs_url":"https://api.github.com/repos/dpsm/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpsm/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpsm/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpsm/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpsm/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/dpsm/RxJava/languages","stargazers_url":"https://api.github.com/repos/dpsm/RxJava/stargazers","contributors_url":"https://api.github.com/repos/dpsm/RxJava/contributors","subscribers_url":"https://api.github.com/repos/dpsm/RxJava/subscribers","subscription_url":"https://api.github.com/repos/dpsm/RxJava/subscription","commits_url":"https://api.github.com/repos/dpsm/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpsm/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpsm/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpsm/RxJava/issues/comments/{number}","contents_url":"https://api.github.com/repos/dpsm/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/dpsm/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpsm/RxJava/merges","archive_url":"https://api.github.com/repos/dpsm/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpsm/RxJava/downloads","issues_url":"https://api.github.com/repos/dpsm/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/dpsm/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/dpsm/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/dpsm/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpsm/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/dpsm/RxJava/releases{/id}","created_at":"2014-06-04T16:15:50Z","updated_at":"2014-07-04T17:42:18Z","pushed_at":"2014-07-04T17:42:17Z","git_url":"git://github.com/dpsm/RxJava.git","ssh_url":"git@github.com:dpsm/RxJava.git","clone_url":"https://github.com/dpsm/RxJava.git","svn_url":"https://github.com/dpsm/RxJava","homepage":"","size":12768,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"ad357784cbbfbaf3a054d726dc6268bb5731cbc3","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?","gravatar_id":"9452a86b2d066c6e6e35fe2ea83d16a5","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":7508411,"name":"RxJava","full_name":"Netflix/RxJava","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?","gravatar_id":"9452a86b2d066c6e6e35fe2ea83d16a5","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/RxJava","description":"RxJava – Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":false,"url":"https://api.github.com/repos/Netflix/RxJava","forks_url":"https://api.github.com/repos/Netflix/RxJava/forks","keys_url":"https://api.github.com/repos/Netflix/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/RxJava/teams","hooks_url":"https://api.github.com/repos/Netflix/RxJava/hooks","issue_events_url":"https://api.github.com/repos/Netflix/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/RxJava/events","assignees_url":"https://api.github.com/repos/Netflix/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/RxJava/tags","blobs_url":"https://api.github.com/repos/Netflix/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/RxJava/languages","stargazers_url":"https://api.github.com/repos/Netflix/RxJava/stargazers","contributors_url":"https://api.github.com/repos/Netflix/RxJava/contributors","subscribers_url":"https://api.github.com/repos/Netflix/RxJava/subscribers","subscription_url":"https://api.github.com/repos/Netflix/RxJava/subscription","commits_url":"https://api.github.com/repos/Netflix/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/RxJava/issues/comments/{number}","contents_url":"https://api.github.com/repos/Netflix/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/RxJava/merges","archive_url":"https://api.github.com/repos/Netflix/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/RxJava/downloads","issues_url":"https://api.github.com/repos/Netflix/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/RxJava/releases{/id}","created_at":"2013-01-08T20:11:48Z","updated_at":"2014-07-04T12:07:09Z","pushed_at":"2014-07-03T16:19:09Z","git_url":"git://github.com/Netflix/RxJava.git","ssh_url":"git@github.com:Netflix/RxJava.git","clone_url":"https://github.com/Netflix/RxJava.git","svn_url":"https://github.com/Netflix/RxJava","homepage":"","size":561085,"stargazers_count":2588,"watchers_count":2588,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":427,"mirror_url":null,"open_issues_count":105,"forks":427,"open_issues":105,"watchers":2588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/1409"},"html":{"href":"https://github.com/Netflix/RxJava/pull/1409"},"issue":{"href":"https://api.github.com/repos/Netflix/RxJava/issues/1409"},"comments":{"href":"https://api.github.com/repos/Netflix/RxJava/issues/1409/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/1409/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Netflix/RxJava/pulls/1409/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/RxJava/statuses/a329581ecd3af9ba565115a6d5d49304da89c907"}}}}