GitHub PullRequestReviewCommentEvent at 2014-10-15 07:33:00
Repository: juju
Actor: fwereade
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/18878241","id":18878241,"diff_hunk":"@@ -0,0 +1,39 @@\n+package rebootstate","path":"utils/rebootstate/reboot.go","position":1,"original_position":1,"commit_id":"7f8c786a9cc3451e3953f83dc712d2197abe184b","original_commit_id":"7f8c786a9cc3451e3953f83dc712d2197abe184b","user":{"login":"fwereade","id":372078,"avatar_url":"https://avatars.githubusercontent.com/u/372078?v=2","gravatar_id":"","url":"https://api.github.com/users/fwereade","html_url":"https://github.com/fwereade","followers_url":"https://api.github.com/users/fwereade/followers","following_url":"https://api.github.com/users/fwereade/following{/other_user}","gists_url":"https://api.github.com/users/fwereade/gists{/gist_id}","starred_url":"https://api.github.com/users/fwereade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwereade/subscriptions","organizations_url":"https://api.github.com/users/fwereade/orgs","repos_url":"https://api.github.com/users/fwereade/repos","events_url":"https://api.github.com/users/fwereade/events{/privacy}","received_events_url":"https://api.github.com/users/fwereade/received_events","type":"User","site_admin":false},"body":"I feel like this package ought to be `worker/reboot/state` -- what else uses it?","created_at":"2014-10-15T07:33:00Z","updated_at":"2014-10-15T07:33:00Z","html_url":"https://github.com/juju/juju/pull/782#discussion_r18878241","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/782","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/18878241"},"html":{"href":"https://github.com/juju/juju/pull/782#discussion_r18878241"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/782"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/782","id":21405703,"html_url":"https://github.com/juju/juju/pull/782","diff_url":"https://github.com/juju/juju/pull/782.diff","patch_url":"https://github.com/juju/juju/pull/782.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/782","number":782,"state":"open","locked":false,"title":"reboot worker","user":{"login":"gabriel-samfira","id":903160,"avatar_url":"https://avatars.githubusercontent.com/u/903160?v=2","gravatar_id":"","url":"https://api.github.com/users/gabriel-samfira","html_url":"https://github.com/gabriel-samfira","followers_url":"https://api.github.com/users/gabriel-samfira/followers","following_url":"https://api.github.com/users/gabriel-samfira/following{/other_user}","gists_url":"https://api.github.com/users/gabriel-samfira/gists{/gist_id}","starred_url":"https://api.github.com/users/gabriel-samfira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabriel-samfira/subscriptions","organizations_url":"https://api.github.com/users/gabriel-samfira/orgs","repos_url":"https://api.github.com/users/gabriel-samfira/repos","events_url":"https://api.github.com/users/gabriel-samfira/events{/privacy}","received_events_url":"https://api.github.com/users/gabriel-samfira/received_events","type":"User","site_admin":false},"body":"This is the final PR for the reboot functionallity. It add a Reboot worker that waits for the machines reboot flag to be changed, and reacts.\r\n\r\nThis branch depends on:\r\n\r\nhttps://github.com/juju/juju/pull/707\r\nhttps://github.com/juju/juju/pull/728\r\nhttps://github.com/juju/juju/pull/744","created_at":"2014-09-18T00:33:24Z","updated_at":"2014-10-15T07:33:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e8896116c840897d24a1083fd491968b34105cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/782/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/782/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju/issues/782/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/7f8c786a9cc3451e3953f83dc712d2197abe184b","head":{"label":"gabriel-samfira:reboot-worker","ref":"reboot-worker","sha":"7f8c786a9cc3451e3953f83dc712d2197abe184b","user":{"login":"gabriel-samfira","id":903160,"avatar_url":"https://avatars.githubusercontent.com/u/903160?v=2","gravatar_id":"","url":"https://api.github.com/users/gabriel-samfira","html_url":"https://github.com/gabriel-samfira","followers_url":"https://api.github.com/users/gabriel-samfira/followers","following_url":"https://api.github.com/users/gabriel-samfira/following{/other_user}","gists_url":"https://api.github.com/users/gabriel-samfira/gists{/gist_id}","starred_url":"https://api.github.com/users/gabriel-samfira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabriel-samfira/subscriptions","organizations_url":"https://api.github.com/users/gabriel-samfira/orgs","repos_url":"https://api.github.com/users/gabriel-samfira/repos","events_url":"https://api.github.com/users/gabriel-samfira/events{/privacy}","received_events_url":"https://api.github.com/users/gabriel-samfira/received_events","type":"User","site_admin":false},"repo":{"id":20686648,"name":"juju","full_name":"gabriel-samfira/juju","owner":{"login":"gabriel-samfira","id":903160,"avatar_url":"https://avatars.githubusercontent.com/u/903160?v=2","gravatar_id":"","url":"https://api.github.com/users/gabriel-samfira","html_url":"https://github.com/gabriel-samfira","followers_url":"https://api.github.com/users/gabriel-samfira/followers","following_url":"https://api.github.com/users/gabriel-samfira/following{/other_user}","gists_url":"https://api.github.com/users/gabriel-samfira/gists{/gist_id}","starred_url":"https://api.github.com/users/gabriel-samfira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabriel-samfira/subscriptions","organizations_url":"https://api.github.com/users/gabriel-samfira/orgs","repos_url":"https://api.github.com/users/gabriel-samfira/repos","events_url":"https://api.github.com/users/gabriel-samfira/events{/privacy}","received_events_url":"https://api.github.com/users/gabriel-samfira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabriel-samfira/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/gabriel-samfira/juju","forks_url":"https://api.github.com/repos/gabriel-samfira/juju/forks","keys_url":"https://api.github.com/repos/gabriel-samfira/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabriel-samfira/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabriel-samfira/juju/teams","hooks_url":"https://api.github.com/repos/gabriel-samfira/juju/hooks","issue_events_url":"https://api.github.com/repos/gabriel-samfira/juju/issues/events{/number}","events_url":"https://api.github.com/repos/gabriel-samfira/juju/events","assignees_url":"https://api.github.com/repos/gabriel-samfira/juju/assignees{/user}","branches_url":"https://api.github.com/repos/gabriel-samfira/juju/branches{/branch}","tags_url":"https://api.github.com/repos/gabriel-samfira/juju/tags","blobs_url":"https://api.github.com/repos/gabriel-samfira/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabriel-samfira/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabriel-samfira/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabriel-samfira/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabriel-samfira/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/gabriel-samfira/juju/languages","stargazers_url":"https://api.github.com/repos/gabriel-samfira/juju/stargazers","contributors_url":"https://api.github.com/repos/gabriel-samfira/juju/contributors","subscribers_url":"https://api.github.com/repos/gabriel-samfira/juju/subscribers","subscription_url":"https://api.github.com/repos/gabriel-samfira/juju/subscription","commits_url":"https://api.github.com/repos/gabriel-samfira/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabriel-samfira/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabriel-samfira/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabriel-samfira/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/gabriel-samfira/juju/contents/{+path}","compare_url":"https://api.github.com/repos/gabriel-samfira/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabriel-samfira/juju/merges","archive_url":"https://api.github.com/repos/gabriel-samfira/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabriel-samfira/juju/downloads","issues_url":"https://api.github.com/repos/gabriel-samfira/juju/issues{/number}","pulls_url":"https://api.github.com/repos/gabriel-samfira/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/gabriel-samfira/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/gabriel-samfira/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabriel-samfira/juju/labels{/name}","releases_url":"https://api.github.com/repos/gabriel-samfira/juju/releases{/id}","created_at":"2014-06-10T13:41:36Z","updated_at":"2014-08-01T13:48:50Z","pushed_at":"2014-10-10T20:44:56Z","git_url":"git://github.com/gabriel-samfira/juju.git","ssh_url":"git@github.com:gabriel-samfira/juju.git","clone_url":"https://github.com/gabriel-samfira/juju.git","svn_url":"https://github.com/gabriel-samfira/juju","homepage":"juju.ubuntu.com","size":33602,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"8c9b8531050d0d55728c075d47ac8b102cd9f039","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2014-10-14T05:52:01Z","pushed_at":"2014-10-15T06:29:09Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":51108,"stargazers_count":216,"watchers_count":216,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":55,"forks":62,"open_issues":55,"watchers":216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/782"},"html":{"href":"https://github.com/juju/juju/pull/782"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/782"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/782/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/782/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/782/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/7f8c786a9cc3451e3953f83dc712d2197abe184b"}}}}