GitHub PullRequestEvent at 2014-03-04 23:39:17
Repository: openFrameworks
Actor: cinghiale
Payload: {"action":"opened","number":2829,"pull_request":{"url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/2829","id":13188825,"html_url":"https://github.com/openframeworks/openFrameworks/pull/2829","diff_url":"https://github.com/openframeworks/openFrameworks/pull/2829.diff","patch_url":"https://github.com/openframeworks/openFrameworks/pull/2829.patch","issue_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/2829","number":2829,"state":"open","title":"ofVbo: don't use stride to calculate the buffer length","user":{"login":"cinghiale","id":129572,"avatar_url":"https://gravatar.com/avatar/eed13437ebd34bac3d24d41387301bd6?d=https%3A%2F%2Fidenticons.github.com%2Ff6ad03efa71f3379a290325a14e3aead.png&r=x","gravatar_id":"eed13437ebd34bac3d24d41387301bd6","url":"https://api.github.com/users/cinghiale","html_url":"https://github.com/cinghiale","followers_url":"https://api.github.com/users/cinghiale/followers","following_url":"https://api.github.com/users/cinghiale/following{/other_user}","gists_url":"https://api.github.com/users/cinghiale/gists{/gist_id}","starred_url":"https://api.github.com/users/cinghiale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinghiale/subscriptions","organizations_url":"https://api.github.com/users/cinghiale/orgs","repos_url":"https://api.github.com/users/cinghiale/repos","events_url":"https://api.github.com/users/cinghiale/events{/privacy}","received_events_url":"https://api.github.com/users/cinghiale/received_events","type":"User","site_admin":false},"body":"ofVbo: don't use stride to calculate the buffer length\r\n------------------------------------------------------\r\n\r\nIn current implementation of setAttributeData/updateAttributeData the stride argument is used for two orthogonal concepts:\r\n\r\n1. to calculate the size of the buffer\r\n2. as an argument of glVertexAttribPointer\r\n\r\nthis make impossible to use a tightly packed array as an argument to a shader.","created_at":"2014-03-04T23:39:15Z","updated_at":"2014-03-04T23:39:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/2829/commits","review_comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/2829/comments","review_comment_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/2829/comments","statuses_url":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/9f8fe70a392f15b5e5cdd81c59eefaf94b647830","head":{"label":"cinghiale:master","ref":"master","sha":"9f8fe70a392f15b5e5cdd81c59eefaf94b647830","user":{"login":"cinghiale","id":129572,"avatar_url":"https://gravatar.com/avatar/eed13437ebd34bac3d24d41387301bd6?d=https%3A%2F%2Fidenticons.github.com%2Ff6ad03efa71f3379a290325a14e3aead.png&r=x","gravatar_id":"eed13437ebd34bac3d24d41387301bd6","url":"https://api.github.com/users/cinghiale","html_url":"https://github.com/cinghiale","followers_url":"https://api.github.com/users/cinghiale/followers","following_url":"https://api.github.com/users/cinghiale/following{/other_user}","gists_url":"https://api.github.com/users/cinghiale/gists{/gist_id}","starred_url":"https://api.github.com/users/cinghiale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinghiale/subscriptions","organizations_url":"https://api.github.com/users/cinghiale/orgs","repos_url":"https://api.github.com/users/cinghiale/repos","events_url":"https://api.github.com/users/cinghiale/events{/privacy}","received_events_url":"https://api.github.com/users/cinghiale/received_events","type":"User","site_admin":false},"repo":{"id":17402193,"name":"openFrameworks","full_name":"cinghiale/openFrameworks","owner":{"login":"cinghiale","id":129572,"avatar_url":"https://gravatar.com/avatar/eed13437ebd34bac3d24d41387301bd6?d=https%3A%2F%2Fidenticons.github.com%2Ff6ad03efa71f3379a290325a14e3aead.png&r=x","gravatar_id":"eed13437ebd34bac3d24d41387301bd6","url":"https://api.github.com/users/cinghiale","html_url":"https://github.com/cinghiale","followers_url":"https://api.github.com/users/cinghiale/followers","following_url":"https://api.github.com/users/cinghiale/following{/other_user}","gists_url":"https://api.github.com/users/cinghiale/gists{/gist_id}","starred_url":"https://api.github.com/users/cinghiale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinghiale/subscriptions","organizations_url":"https://api.github.com/users/cinghiale/orgs","repos_url":"https://api.github.com/users/cinghiale/repos","events_url":"https://api.github.com/users/cinghiale/events{/privacy}","received_events_url":"https://api.github.com/users/cinghiale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cinghiale/openFrameworks","description":"OpenFrameworks is a cross platform open source toolkit for creative coding in C++.","fork":true,"url":"https://api.github.com/repos/cinghiale/openFrameworks","forks_url":"https://api.github.com/repos/cinghiale/openFrameworks/forks","keys_url":"https://api.github.com/repos/cinghiale/openFrameworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cinghiale/openFrameworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cinghiale/openFrameworks/teams","hooks_url":"https://api.github.com/repos/cinghiale/openFrameworks/hooks","issue_events_url":"https://api.github.com/repos/cinghiale/openFrameworks/issues/events{/number}","events_url":"https://api.github.com/repos/cinghiale/openFrameworks/events","assignees_url":"https://api.github.com/repos/cinghiale/openFrameworks/assignees{/user}","branches_url":"https://api.github.com/repos/cinghiale/openFrameworks/branches{/branch}","tags_url":"https://api.github.com/repos/cinghiale/openFrameworks/tags","blobs_url":"https://api.github.com/repos/cinghiale/openFrameworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cinghiale/openFrameworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cinghiale/openFrameworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/cinghiale/openFrameworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cinghiale/openFrameworks/statuses/{sha}","languages_url":"https://api.github.com/repos/cinghiale/openFrameworks/languages","stargazers_url":"https://api.github.com/repos/cinghiale/openFrameworks/stargazers","contributors_url":"https://api.github.com/repos/cinghiale/openFrameworks/contributors","subscribers_url":"https://api.github.com/repos/cinghiale/openFrameworks/subscribers","subscription_url":"https://api.github.com/repos/cinghiale/openFrameworks/subscription","commits_url":"https://api.github.com/repos/cinghiale/openFrameworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/cinghiale/openFrameworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/cinghiale/openFrameworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/cinghiale/openFrameworks/issues/comments/{number}","contents_url":"https://api.github.com/repos/cinghiale/openFrameworks/contents/{+path}","compare_url":"https://api.github.com/repos/cinghiale/openFrameworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cinghiale/openFrameworks/merges","archive_url":"https://api.github.com/repos/cinghiale/openFrameworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cinghiale/openFrameworks/downloads","issues_url":"https://api.github.com/repos/cinghiale/openFrameworks/issues{/number}","pulls_url":"https://api.github.com/repos/cinghiale/openFrameworks/pulls{/number}","milestones_url":"https://api.github.com/repos/cinghiale/openFrameworks/milestones{/number}","notifications_url":"https://api.github.com/repos/cinghiale/openFrameworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cinghiale/openFrameworks/labels{/name}","releases_url":"https://api.github.com/repos/cinghiale/openFrameworks/releases{/id}","created_at":"2014-03-04T13:09:20Z","updated_at":"2014-03-04T23:39:15Z","pushed_at":"2014-03-04T15:00:04Z","git_url":"git://github.com/cinghiale/openFrameworks.git","ssh_url":"git@github.com:cinghiale/openFrameworks.git","clone_url":"https://github.com/cinghiale/openFrameworks.git","svn_url":"https://github.com/cinghiale/openFrameworks","homepage":"http://openframeworks.cc","size":1027799,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"openframeworks:master","ref":"master","sha":"e3ac9eb75738aa53674bed2a6e759f6d07e9088f","user":{"login":"openframeworks","id":142866,"avatar_url":"https://gravatar.com/avatar/1061569f505705f6ba1f485673c5cc3b?d=https%3A%2F%2Fidenticons.github.com%2Fa539871f08dd8f7c88f24bb7e1c1ed79.png&r=x","gravatar_id":"1061569f505705f6ba1f485673c5cc3b","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"repo":{"id":345337,"name":"openFrameworks","full_name":"openframeworks/openFrameworks","owner":{"login":"openframeworks","id":142866,"avatar_url":"https://gravatar.com/avatar/1061569f505705f6ba1f485673c5cc3b?d=https%3A%2F%2Fidenticons.github.com%2Fa539871f08dd8f7c88f24bb7e1c1ed79.png&r=x","gravatar_id":"1061569f505705f6ba1f485673c5cc3b","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openframeworks/openFrameworks","description":"OpenFrameworks is a cross platform open source toolkit for creative coding in C++.","fork":false,"url":"https://api.github.com/repos/openframeworks/openFrameworks","forks_url":"https://api.github.com/repos/openframeworks/openFrameworks/forks","keys_url":"https://api.github.com/repos/openframeworks/openFrameworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openframeworks/openFrameworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openframeworks/openFrameworks/teams","hooks_url":"https://api.github.com/repos/openframeworks/openFrameworks/hooks","issue_events_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/events{/number}","events_url":"https://api.github.com/repos/openframeworks/openFrameworks/events","assignees_url":"https://api.github.com/repos/openframeworks/openFrameworks/assignees{/user}","branches_url":"https://api.github.com/repos/openframeworks/openFrameworks/branches{/branch}","tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/tags","blobs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/{sha}","languages_url":"https://api.github.com/repos/openframeworks/openFrameworks/languages","stargazers_url":"https://api.github.com/repos/openframeworks/openFrameworks/stargazers","contributors_url":"https://api.github.com/repos/openframeworks/openFrameworks/contributors","subscribers_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscribers","subscription_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscription","commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/comments/{number}","contents_url":"https://api.github.com/repos/openframeworks/openFrameworks/contents/{+path}","compare_url":"https://api.github.com/repos/openframeworks/openFrameworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openframeworks/openFrameworks/merges","archive_url":"https://api.github.com/repos/openframeworks/openFrameworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openframeworks/openFrameworks/downloads","issues_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues{/number}","pulls_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls{/number}","milestones_url":"https://api.github.com/repos/openframeworks/openFrameworks/milestones{/number}","notifications_url":"https://api.github.com/repos/openframeworks/openFrameworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openframeworks/openFrameworks/labels{/name}","releases_url":"https://api.github.com/repos/openframeworks/openFrameworks/releases{/id}","created_at":"2009-10-21T21:55:54Z","updated_at":"2014-03-04T09:04:52Z","pushed_at":"2014-03-04T09:04:52Z","git_url":"git://github.com/openframeworks/openFrameworks.git","ssh_url":"git@github.com:openframeworks/openFrameworks.git","clone_url":"https://github.com/openframeworks/openFrameworks.git","svn_url":"https://github.com/openframeworks/openFrameworks","homepage":"http://openframeworks.cc","size":1027799,"stargazers_count":2698,"watchers_count":2698,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":843,"mirror_url":null,"open_issues_count":611,"forks":843,"open_issues":611,"watchers":2698,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/2829"},"html":{"href":"https://github.com/openframeworks/openFrameworks/pull/2829"},"issue":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/issues/2829"},"comments":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/issues/2829/comments"},"review_comments":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/2829/comments"},"review_comment":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/2829/commits"},"statuses":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/9f8fe70a392f15b5e5cdd81c59eefaf94b647830"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":2}}