GitHub PullRequestReviewCommentEvent at 2014-08-15 15:16:47
Repository: manageiq
Actor: brandondunne
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/16297175","id":16297175,"diff_hunk":"@@ -93,12 +93,12 @@\n \n       it \"check_disk_space - 0 percent\" do\n         max_disk_space_in_kb = 10000\n-        lambda{ @vim_vm.check_disk_space('create', @ds_mor, max_disk_space_in_kb, 0)}.should_not raise_error(MiqException::MiqVmSnapshotError)\n+        lambda{ @vim_vm.check_disk_space('create', @ds_mor, max_disk_space_in_kb, 0)}.should_not raise_error\n       end\n \n       it \"check_disk_space - 10 percent\" do\n         max_disk_space_in_kb = 10000\n-        lambda{ @vim_vm.check_disk_space('create', @ds_mor, max_disk_space_in_kb, 10)}.should_not raise_error(MiqException::MiqVmSnapshotError)\n+        lambda{ @vim_vm.check_disk_space('create', @ds_mor, max_disk_space_in_kb, 10)}.should_not raise_error","path":"lib/spec/VMwareWebService/MiqVimVm_spec.rb","position":20,"original_position":20,"commit_id":"64924f950f08bb378e70408dfb0665404eb72ee0","original_commit_id":"64924f950f08bb378e70408dfb0665404eb72ee0","user":{"login":"brandondunne","id":651659,"avatar_url":"https://avatars.githubusercontent.com/u/651659?v=2","gravatar_id":"491e2e188b760beb431c91f0d7161afc","url":"https://api.github.com/users/brandondunne","html_url":"https://github.com/brandondunne","followers_url":"https://api.github.com/users/brandondunne/followers","following_url":"https://api.github.com/users/brandondunne/following{/other_user}","gists_url":"https://api.github.com/users/brandondunne/gists{/gist_id}","starred_url":"https://api.github.com/users/brandondunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandondunne/subscriptions","organizations_url":"https://api.github.com/users/brandondunne/orgs","repos_url":"https://api.github.com/users/brandondunne/repos","events_url":"https://api.github.com/users/brandondunne/events{/privacy}","received_events_url":"https://api.github.com/users/brandondunne/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2014-08-15T15:16:47Z","updated_at":"2014-08-15T15:16:47Z","html_url":"https://github.com/ManageIQ/manageiq/pull/362#discussion_r16297175","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/362","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/16297175"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/362#discussion_r16297175"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/362"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/362","id":19533836,"html_url":"https://github.com/ManageIQ/manageiq/pull/362","diff_url":"https://github.com/ManageIQ/manageiq/pull/362.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/362.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/362","number":362,"state":"open","locked":false,"title":"Upgrade to rspec 2.14","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=2","gravatar_id":"cf358de2534f820f5342180bb0e861ef","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"body":"This adds\r\n- expect(obj).to receive(:method)\r\n- allow(obj).to receive(:method) #stubbing\r\n- allow_any_instance_of(Class).to receive(:method)\r\n\r\nPersonally, this makes specs much easier to write.\r\n\r\nThis PR only updates deprecated methods in specs. It does nothing else","created_at":"2014-08-08T15:29:18Z","updated_at":"2014-08-15T15:16:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79d325d75028a39df4062f2ba89d4f210c1cd62a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/362/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/362/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/362/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/64924f950f08bb378e70408dfb0665404eb72ee0","head":{"label":"kbrock:gem_rspec_2_13","ref":"gem_rspec_2_13","sha":"64924f950f08bb378e70408dfb0665404eb72ee0","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=2","gravatar_id":"cf358de2534f820f5342180bb0e861ef","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"repo":{"id":20886492,"name":"manageiq","full_name":"kbrock/manageiq","owner":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=2","gravatar_id":"cf358de2534f820f5342180bb0e861ef","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbrock/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/kbrock/manageiq","forks_url":"https://api.github.com/repos/kbrock/manageiq/forks","keys_url":"https://api.github.com/repos/kbrock/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbrock/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbrock/manageiq/teams","hooks_url":"https://api.github.com/repos/kbrock/manageiq/hooks","issue_events_url":"https://api.github.com/repos/kbrock/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/kbrock/manageiq/events","assignees_url":"https://api.github.com/repos/kbrock/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/kbrock/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/kbrock/manageiq/tags","blobs_url":"https://api.github.com/repos/kbrock/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbrock/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbrock/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbrock/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbrock/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/kbrock/manageiq/languages","stargazers_url":"https://api.github.com/repos/kbrock/manageiq/stargazers","contributors_url":"https://api.github.com/repos/kbrock/manageiq/contributors","subscribers_url":"https://api.github.com/repos/kbrock/manageiq/subscribers","subscription_url":"https://api.github.com/repos/kbrock/manageiq/subscription","commits_url":"https://api.github.com/repos/kbrock/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbrock/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbrock/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbrock/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/kbrock/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/kbrock/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbrock/manageiq/merges","archive_url":"https://api.github.com/repos/kbrock/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbrock/manageiq/downloads","issues_url":"https://api.github.com/repos/kbrock/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/kbrock/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/kbrock/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/kbrock/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbrock/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/kbrock/manageiq/releases{/id}","created_at":"2014-06-16T13:49:17Z","updated_at":"2014-06-26T20:45:13Z","pushed_at":"2014-08-15T13:42:32Z","git_url":"git://github.com/kbrock/manageiq.git","ssh_url":"git@github.com:kbrock/manageiq.git","clone_url":"https://github.com/kbrock/manageiq.git","svn_url":"https://github.com/kbrock/manageiq","homepage":null,"size":57165,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"733bce41a632524cbe9af1e7eb9f99f014bb5bdb","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=2","gravatar_id":"6e2fbc6e71ee5df101885996971f41e0","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=2","gravatar_id":"6e2fbc6e71ee5df101885996971f41e0","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2014-08-13T13:46:09Z","pushed_at":"2014-08-15T14:58:26Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":64476,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":47,"mirror_url":null,"open_issues_count":77,"forks":47,"open_issues":77,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/362"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/362"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/362"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/64924f950f08bb378e70408dfb0665404eb72ee0"}}}}