GitHub PullRequestEvent at 2014-12-10 20:06:31
Repository: georchestra
Actor: pmauduit
Payload: {"action":"opened","number":843,"pull_request":{"url":"https://api.github.com/repos/georchestra/georchestra/pulls/843","id":25851038,"html_url":"https://github.com/georchestra/georchestra/pull/843","diff_url":"https://github.com/georchestra/georchestra/pull/843.diff","patch_url":"https://github.com/georchestra/georchestra/pull/843.patch","issue_url":"https://api.github.com/repos/georchestra/georchestra/issues/843","number":843,"state":"open","locked":false,"title":"Ldapadmin testsuite","user":{"login":"pmauduit","id":594335,"avatar_url":"https://avatars.githubusercontent.com/u/594335?v=3","gravatar_id":"","url":"https://api.github.com/users/pmauduit","html_url":"https://github.com/pmauduit","followers_url":"https://api.github.com/users/pmauduit/followers","following_url":"https://api.github.com/users/pmauduit/following{/other_user}","gists_url":"https://api.github.com/users/pmauduit/gists{/gist_id}","starred_url":"https://api.github.com/users/pmauduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmauduit/subscriptions","organizations_url":"https://api.github.com/users/pmauduit/orgs","repos_url":"https://api.github.com/users/pmauduit/repos","events_url":"https://api.github.com/users/pmauduit/events{/privacy}","received_events_url":"https://api.github.com/users/pmauduit/received_events","type":"User","site_admin":false},"body":"This PR aims to leverage a bit the test coverage specifically on the LDAPAdmin application. After applying these commits, the global test coverage increases from 19% to 73%. In addition, some minor modifications have been made, related to using Apache DBCP and the configuration/build process.\r\n\r\nEven if the goal is to make sure further developments won't imply regressions, some manual tests have been made:\r\n\r\n\r\n- User\r\n  - [x] Create\r\n  - [x] Update\r\n  - [x] Delete\r\n\r\n- Group\r\n  - [x] Create\r\n  - [x] Update\r\n  - [x] Delete\r\n\r\n- User / Group\r\n  - [x] Affectation\r\n  - [x] De-affectation\r\n\r\n- [x] Lost Password\r\n\r\nNote: exim was misconfigured on my computer, but the mail has been frozen in the exim4 queue, after checking, it was correctly sent by the webapp.\r\n\r\n- [x] New account\r\n\r\nNote: same remark, both \"welcome mail\" and \"mail to warn the useradmin\" were sent.\r\n\r\n","created_at":"2014-12-10T20:06:29Z","updated_at":"2014-12-10T20:06:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/georchestra/georchestra/pulls/843/commits","review_comments_url":"https://api.github.com/repos/georchestra/georchestra/pulls/843/comments","review_comment_url":"https://api.github.com/repos/georchestra/georchestra/pulls/comments/{number}","comments_url":"https://api.github.com/repos/georchestra/georchestra/issues/843/comments","statuses_url":"https://api.github.com/repos/georchestra/georchestra/statuses/a9d9f4e75a1a1f2bc04fe0cdf7828e76d9a2e706","head":{"label":"pmauduit:ldapadmin_testsuite","ref":"ldapadmin_testsuite","sha":"a9d9f4e75a1a1f2bc04fe0cdf7828e76d9a2e706","user":{"login":"pmauduit","id":594335,"avatar_url":"https://avatars.githubusercontent.com/u/594335?v=3","gravatar_id":"","url":"https://api.github.com/users/pmauduit","html_url":"https://github.com/pmauduit","followers_url":"https://api.github.com/users/pmauduit/followers","following_url":"https://api.github.com/users/pmauduit/following{/other_user}","gists_url":"https://api.github.com/users/pmauduit/gists{/gist_id}","starred_url":"https://api.github.com/users/pmauduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmauduit/subscriptions","organizations_url":"https://api.github.com/users/pmauduit/orgs","repos_url":"https://api.github.com/users/pmauduit/repos","events_url":"https://api.github.com/users/pmauduit/events{/privacy}","received_events_url":"https://api.github.com/users/pmauduit/received_events","type":"User","site_admin":false},"repo":{"id":7039484,"name":"georchestra","full_name":"pmauduit/georchestra","owner":{"login":"pmauduit","id":594335,"avatar_url":"https://avatars.githubusercontent.com/u/594335?v=3","gravatar_id":"","url":"https://api.github.com/users/pmauduit","html_url":"https://github.com/pmauduit","followers_url":"https://api.github.com/users/pmauduit/followers","following_url":"https://api.github.com/users/pmauduit/following{/other_user}","gists_url":"https://api.github.com/users/pmauduit/gists{/gist_id}","starred_url":"https://api.github.com/users/pmauduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmauduit/subscriptions","organizations_url":"https://api.github.com/users/pmauduit/orgs","repos_url":"https://api.github.com/users/pmauduit/repos","events_url":"https://api.github.com/users/pmauduit/events{/privacy}","received_events_url":"https://api.github.com/users/pmauduit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmauduit/georchestra","description":"This is the main geOrchestra repository","fork":true,"url":"https://api.github.com/repos/pmauduit/georchestra","forks_url":"https://api.github.com/repos/pmauduit/georchestra/forks","keys_url":"https://api.github.com/repos/pmauduit/georchestra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmauduit/georchestra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmauduit/georchestra/teams","hooks_url":"https://api.github.com/repos/pmauduit/georchestra/hooks","issue_events_url":"https://api.github.com/repos/pmauduit/georchestra/issues/events{/number}","events_url":"https://api.github.com/repos/pmauduit/georchestra/events","assignees_url":"https://api.github.com/repos/pmauduit/georchestra/assignees{/user}","branches_url":"https://api.github.com/repos/pmauduit/georchestra/branches{/branch}","tags_url":"https://api.github.com/repos/pmauduit/georchestra/tags","blobs_url":"https://api.github.com/repos/pmauduit/georchestra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmauduit/georchestra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmauduit/georchestra/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmauduit/georchestra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmauduit/georchestra/statuses/{sha}","languages_url":"https://api.github.com/repos/pmauduit/georchestra/languages","stargazers_url":"https://api.github.com/repos/pmauduit/georchestra/stargazers","contributors_url":"https://api.github.com/repos/pmauduit/georchestra/contributors","subscribers_url":"https://api.github.com/repos/pmauduit/georchestra/subscribers","subscription_url":"https://api.github.com/repos/pmauduit/georchestra/subscription","commits_url":"https://api.github.com/repos/pmauduit/georchestra/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmauduit/georchestra/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmauduit/georchestra/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmauduit/georchestra/issues/comments/{number}","contents_url":"https://api.github.com/repos/pmauduit/georchestra/contents/{+path}","compare_url":"https://api.github.com/repos/pmauduit/georchestra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmauduit/georchestra/merges","archive_url":"https://api.github.com/repos/pmauduit/georchestra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmauduit/georchestra/downloads","issues_url":"https://api.github.com/repos/pmauduit/georchestra/issues{/number}","pulls_url":"https://api.github.com/repos/pmauduit/georchestra/pulls{/number}","milestones_url":"https://api.github.com/repos/pmauduit/georchestra/milestones{/number}","notifications_url":"https://api.github.com/repos/pmauduit/georchestra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmauduit/georchestra/labels{/name}","releases_url":"https://api.github.com/repos/pmauduit/georchestra/releases{/id}","created_at":"2012-12-06T17:06:01Z","updated_at":"2014-07-27T20:57:30Z","pushed_at":"2014-12-10T19:56:14Z","git_url":"git://github.com/pmauduit/georchestra.git","ssh_url":"git@github.com:pmauduit/georchestra.git","clone_url":"https://github.com/pmauduit/georchestra.git","svn_url":"https://github.com/pmauduit/georchestra","homepage":"http://www.georchestra.org/","size":230367,"stargazers_count":0,"watchers_count":0,"language":"Game Maker Language","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"georchestra:master","ref":"master","sha":"2a52a91a7ff7e6bddb75f34cdc9bdfc138575603","user":{"login":"georchestra","id":773831,"avatar_url":"https://avatars.githubusercontent.com/u/773831?v=3","gravatar_id":"","url":"https://api.github.com/users/georchestra","html_url":"https://github.com/georchestra","followers_url":"https://api.github.com/users/georchestra/followers","following_url":"https://api.github.com/users/georchestra/following{/other_user}","gists_url":"https://api.github.com/users/georchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/georchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georchestra/subscriptions","organizations_url":"https://api.github.com/users/georchestra/orgs","repos_url":"https://api.github.com/users/georchestra/repos","events_url":"https://api.github.com/users/georchestra/events{/privacy}","received_events_url":"https://api.github.com/users/georchestra/received_events","type":"Organization","site_admin":false},"repo":{"id":6066709,"name":"georchestra","full_name":"georchestra/georchestra","owner":{"login":"georchestra","id":773831,"avatar_url":"https://avatars.githubusercontent.com/u/773831?v=3","gravatar_id":"","url":"https://api.github.com/users/georchestra","html_url":"https://github.com/georchestra","followers_url":"https://api.github.com/users/georchestra/followers","following_url":"https://api.github.com/users/georchestra/following{/other_user}","gists_url":"https://api.github.com/users/georchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/georchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georchestra/subscriptions","organizations_url":"https://api.github.com/users/georchestra/orgs","repos_url":"https://api.github.com/users/georchestra/repos","events_url":"https://api.github.com/users/georchestra/events{/privacy}","received_events_url":"https://api.github.com/users/georchestra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/georchestra/georchestra","description":"This is the main geOrchestra repository","fork":false,"url":"https://api.github.com/repos/georchestra/georchestra","forks_url":"https://api.github.com/repos/georchestra/georchestra/forks","keys_url":"https://api.github.com/repos/georchestra/georchestra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georchestra/georchestra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georchestra/georchestra/teams","hooks_url":"https://api.github.com/repos/georchestra/georchestra/hooks","issue_events_url":"https://api.github.com/repos/georchestra/georchestra/issues/events{/number}","events_url":"https://api.github.com/repos/georchestra/georchestra/events","assignees_url":"https://api.github.com/repos/georchestra/georchestra/assignees{/user}","branches_url":"https://api.github.com/repos/georchestra/georchestra/branches{/branch}","tags_url":"https://api.github.com/repos/georchestra/georchestra/tags","blobs_url":"https://api.github.com/repos/georchestra/georchestra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georchestra/georchestra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georchestra/georchestra/git/refs{/sha}","trees_url":"https://api.github.com/repos/georchestra/georchestra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georchestra/georchestra/statuses/{sha}","languages_url":"https://api.github.com/repos/georchestra/georchestra/languages","stargazers_url":"https://api.github.com/repos/georchestra/georchestra/stargazers","contributors_url":"https://api.github.com/repos/georchestra/georchestra/contributors","subscribers_url":"https://api.github.com/repos/georchestra/georchestra/subscribers","subscription_url":"https://api.github.com/repos/georchestra/georchestra/subscription","commits_url":"https://api.github.com/repos/georchestra/georchestra/commits{/sha}","git_commits_url":"https://api.github.com/repos/georchestra/georchestra/git/commits{/sha}","comments_url":"https://api.github.com/repos/georchestra/georchestra/comments{/number}","issue_comment_url":"https://api.github.com/repos/georchestra/georchestra/issues/comments/{number}","contents_url":"https://api.github.com/repos/georchestra/georchestra/contents/{+path}","compare_url":"https://api.github.com/repos/georchestra/georchestra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georchestra/georchestra/merges","archive_url":"https://api.github.com/repos/georchestra/georchestra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georchestra/georchestra/downloads","issues_url":"https://api.github.com/repos/georchestra/georchestra/issues{/number}","pulls_url":"https://api.github.com/repos/georchestra/georchestra/pulls{/number}","milestones_url":"https://api.github.com/repos/georchestra/georchestra/milestones{/number}","notifications_url":"https://api.github.com/repos/georchestra/georchestra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georchestra/georchestra/labels{/name}","releases_url":"https://api.github.com/repos/georchestra/georchestra/releases{/id}","created_at":"2012-10-03T20:55:45Z","updated_at":"2014-12-06T16:26:13Z","pushed_at":"2014-12-10T13:19:51Z","git_url":"git://github.com/georchestra/georchestra.git","ssh_url":"git@github.com:georchestra/georchestra.git","clone_url":"https://github.com/georchestra/georchestra.git","svn_url":"https://github.com/georchestra/georchestra","homepage":"http://www.georchestra.org/","size":257201,"stargazers_count":17,"watchers_count":17,"language":"Game Maker Language","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":195,"forks":29,"open_issues":195,"watchers":17,"default_branch":"14.06"}},"_links":{"self":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/843"},"html":{"href":"https://github.com/georchestra/georchestra/pull/843"},"issue":{"href":"https://api.github.com/repos/georchestra/georchestra/issues/843"},"comments":{"href":"https://api.github.com/repos/georchestra/georchestra/issues/843/comments"},"review_comments":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/843/comments"},"review_comment":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/georchestra/georchestra/pulls/843/commits"},"statuses":{"href":"https://api.github.com/repos/georchestra/georchestra/statuses/a9d9f4e75a1a1f2bc04fe0cdf7828e76d9a2e706"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":39,"additions":3026,"deletions":1171,"changed_files":49}}