GitHub PullRequestEvent at 2014-03-12 11:06:57
Repository: foreman
Actor: domcleal
Payload: {"action":"closed","number":1261,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/1261","id":13023857,"html_url":"https://github.com/theforeman/foreman/pull/1261","diff_url":"https://github.com/theforeman/foreman/pull/1261.diff","patch_url":"https://github.com/theforeman/foreman/pull/1261.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/1261","number":1261,"state":"closed","title":"Fixes 4465: remove pretrans section of foreman.spec","user":{"login":"jmontleon","id":1850500,"avatar_url":"https://gravatar.com/avatar/86c8481505859ccfc22675d6e9956266?d=https%3A%2F%2Fidenticons.github.com%2Fee5558f137b456287a3279b3cd88a542.png&r=x","gravatar_id":"86c8481505859ccfc22675d6e9956266","url":"https://api.github.com/users/jmontleon","html_url":"https://github.com/jmontleon","followers_url":"https://api.github.com/users/jmontleon/followers","following_url":"https://api.github.com/users/jmontleon/following{/other_user}","gists_url":"https://api.github.com/users/jmontleon/gists{/gist_id}","starred_url":"https://api.github.com/users/jmontleon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmontleon/subscriptions","organizations_url":"https://api.github.com/users/jmontleon/orgs","repos_url":"https://api.github.com/users/jmontleon/repos","events_url":"https://api.github.com/users/jmontleon/events{/privacy}","received_events_url":"https://api.github.com/users/jmontleon/received_events","type":"User","site_admin":false},"body":"The pretrans section can cause problems when doing a kickstart that includes foreman due to bash not being available prior to the transaction running and rpm guidelines suggest writing it in lua (http://www.rpm.org/wiki/PackagerDocs/RpmLua) if it is necessary but Ohad suggested just removing it.","created_at":"2014-02-27T21:11:32Z","updated_at":"2014-03-12T11:06:57Z","closed_at":"2014-03-12T11:06:57Z","merged_at":null,"merge_commit_sha":"89b028b5518ba0bd763c1adcbe93ae4ff3a96658","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/1261/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/1261/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/{number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/1261/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/6559776fa095f8721efc78a85ac0f0a70e1e1e79","head":{"label":"jmontleon:remove_pretrans","ref":"remove_pretrans","sha":"6559776fa095f8721efc78a85ac0f0a70e1e1e79","user":{"login":"jmontleon","id":1850500,"avatar_url":"https://gravatar.com/avatar/86c8481505859ccfc22675d6e9956266?d=https%3A%2F%2Fidenticons.github.com%2Fee5558f137b456287a3279b3cd88a542.png&r=x","gravatar_id":"86c8481505859ccfc22675d6e9956266","url":"https://api.github.com/users/jmontleon","html_url":"https://github.com/jmontleon","followers_url":"https://api.github.com/users/jmontleon/followers","following_url":"https://api.github.com/users/jmontleon/following{/other_user}","gists_url":"https://api.github.com/users/jmontleon/gists{/gist_id}","starred_url":"https://api.github.com/users/jmontleon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmontleon/subscriptions","organizations_url":"https://api.github.com/users/jmontleon/orgs","repos_url":"https://api.github.com/users/jmontleon/repos","events_url":"https://api.github.com/users/jmontleon/events{/privacy}","received_events_url":"https://api.github.com/users/jmontleon/received_events","type":"User","site_admin":false},"repo":{"id":11207883,"name":"foreman","full_name":"jmontleon/foreman","owner":{"login":"jmontleon","id":1850500,"avatar_url":"https://gravatar.com/avatar/86c8481505859ccfc22675d6e9956266?d=https%3A%2F%2Fidenticons.github.com%2Fee5558f137b456287a3279b3cd88a542.png&r=x","gravatar_id":"86c8481505859ccfc22675d6e9956266","url":"https://api.github.com/users/jmontleon","html_url":"https://github.com/jmontleon","followers_url":"https://api.github.com/users/jmontleon/followers","following_url":"https://api.github.com/users/jmontleon/following{/other_user}","gists_url":"https://api.github.com/users/jmontleon/gists{/gist_id}","starred_url":"https://api.github.com/users/jmontleon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmontleon/subscriptions","organizations_url":"https://api.github.com/users/jmontleon/orgs","repos_url":"https://api.github.com/users/jmontleon/repos","events_url":"https://api.github.com/users/jmontleon/events{/privacy}","received_events_url":"https://api.github.com/users/jmontleon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmontleon/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/jmontleon/foreman","forks_url":"https://api.github.com/repos/jmontleon/foreman/forks","keys_url":"https://api.github.com/repos/jmontleon/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmontleon/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmontleon/foreman/teams","hooks_url":"https://api.github.com/repos/jmontleon/foreman/hooks","issue_events_url":"https://api.github.com/repos/jmontleon/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/jmontleon/foreman/events","assignees_url":"https://api.github.com/repos/jmontleon/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/jmontleon/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/jmontleon/foreman/tags","blobs_url":"https://api.github.com/repos/jmontleon/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmontleon/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmontleon/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmontleon/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmontleon/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/jmontleon/foreman/languages","stargazers_url":"https://api.github.com/repos/jmontleon/foreman/stargazers","contributors_url":"https://api.github.com/repos/jmontleon/foreman/contributors","subscribers_url":"https://api.github.com/repos/jmontleon/foreman/subscribers","subscription_url":"https://api.github.com/repos/jmontleon/foreman/subscription","commits_url":"https://api.github.com/repos/jmontleon/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmontleon/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmontleon/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmontleon/foreman/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmontleon/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/jmontleon/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmontleon/foreman/merges","archive_url":"https://api.github.com/repos/jmontleon/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmontleon/foreman/downloads","issues_url":"https://api.github.com/repos/jmontleon/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/jmontleon/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/jmontleon/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/jmontleon/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmontleon/foreman/labels{/name}","releases_url":"https://api.github.com/repos/jmontleon/foreman/releases{/id}","created_at":"2013-07-05T20:25:50Z","updated_at":"2014-02-27T21:14:10Z","pushed_at":"2014-02-27T21:14:10Z","git_url":"git://github.com/jmontleon/foreman.git","ssh_url":"git@github.com:jmontleon/foreman.git","clone_url":"https://github.com/jmontleon/foreman.git","svn_url":"https://github.com/jmontleon/foreman","homepage":"http://theforeman.org","size":13912,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"8cf10332a45283feba57c6263ff4a0eda86ac52f","user":{"login":"theforeman","id":1439844,"avatar_url":"https://gravatar.com/avatar/debaffa7d317b9ec76a588682fb1e640?d=https%3A%2F%2Fidenticons.github.com%2Fb168fcd02e2a21e35a46b2a827b6ec6e.png&r=x","gravatar_id":"debaffa7d317b9ec76a588682fb1e640","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://gravatar.com/avatar/debaffa7d317b9ec76a588682fb1e640?d=https%3A%2F%2Fidenticons.github.com%2Fb168fcd02e2a21e35a46b2a827b6ec6e.png&r=x","gravatar_id":"debaffa7d317b9ec76a588682fb1e640","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments/{number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2014-03-12T11:06:28Z","pushed_at":"2014-03-12T11:06:27Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":34957,"stargazers_count":408,"watchers_count":408,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":254,"mirror_url":null,"open_issues_count":43,"forks":254,"open_issues":43,"watchers":408,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/1261"},"html":{"href":"https://github.com/theforeman/foreman/pull/1261"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/1261"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/1261/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/1261/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/1261/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/6559776fa095f8721efc78a85ac0f0a70e1e1e79"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":0,"deletions":33,"changed_files":1}}