GitHub PullRequestEvent at 2014-01-18 15:50:16
Repository: python-social-auth
Actor: omab
Payload: {"action":"closed","number":75,"pull_request":{"url":"https://api.github.com/repos/omab/python-social-auth/pulls/75","id":9700285,"html_url":"https://github.com/omab/python-social-auth/pull/75","diff_url":"https://github.com/omab/python-social-auth/pull/75.diff","patch_url":"https://github.com/omab/python-social-auth/pull/75.patch","issue_url":"https://github.com/omab/python-social-auth/pull/75","number":75,"state":"closed","title":"Update partial from session with more recent values from kwargs","user":{"login":"branden","id":42242,"avatar_url":"https://gravatar.com/avatar/49d8f54f43fa381bfa383748dc152f4c?d=https%3A%2F%2Fidenticons.github.com%2Fe670686b2fdef49617758e01e648b0b7.png&r=x","gravatar_id":"49d8f54f43fa381bfa383748dc152f4c","url":"https://api.github.com/users/branden","html_url":"https://github.com/branden","followers_url":"https://api.github.com/users/branden/followers","following_url":"https://api.github.com/users/branden/following{/other_user}","gists_url":"https://api.github.com/users/branden/gists{/gist_id}","starred_url":"https://api.github.com/users/branden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branden/subscriptions","organizations_url":"https://api.github.com/users/branden/orgs","repos_url":"https://api.github.com/users/branden/repos","events_url":"https://api.github.com/users/branden/events{/privacy}","received_events_url":"https://api.github.com/users/branden/received_events","type":"User","site_admin":false},"body":"If I redirect from the connect pipeline to a login page which on success redirects back to complete the pipeline, the `user` kwarg retains its previously set value of `None`, when I expect it to be replaced with the logged in user. This fix handles my use case, and it feels consistent—treating the outcome of the redirect as another stage in the pipeline, overwriting previously set kwargs—but I'm not sure if this breaks existing use cases that aren't covered by the tests.","created_at":"2013-11-05T22:56:23Z","updated_at":"2014-01-18T15:50:16Z","closed_at":"2014-01-18T15:50:16Z","merged_at":"2014-01-18T15:50:16Z","merge_commit_sha":"f6bf4cf78e685992ad49e0b6b376a2a2fde6da13","assignee":null,"milestone":null,"commits_url":"https://github.com/omab/python-social-auth/pull/75/commits","review_comments_url":"https://github.com/omab/python-social-auth/pull/75/comments","review_comment_url":"/repos/omab/python-social-auth/pulls/comments/{number}","comments_url":"https://api.github.com/repos/omab/python-social-auth/issues/75/comments","statuses_url":"https://api.github.com/repos/omab/python-social-auth/statuses/228b36bb7067306dd2e263abba2318873b3b87fa","head":{"label":"branden:master","ref":"master","sha":"228b36bb7067306dd2e263abba2318873b3b87fa","user":{"login":"branden","id":42242,"avatar_url":"https://gravatar.com/avatar/49d8f54f43fa381bfa383748dc152f4c?d=https%3A%2F%2Fidenticons.github.com%2Fe670686b2fdef49617758e01e648b0b7.png&r=x","gravatar_id":"49d8f54f43fa381bfa383748dc152f4c","url":"https://api.github.com/users/branden","html_url":"https://github.com/branden","followers_url":"https://api.github.com/users/branden/followers","following_url":"https://api.github.com/users/branden/following{/other_user}","gists_url":"https://api.github.com/users/branden/gists{/gist_id}","starred_url":"https://api.github.com/users/branden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branden/subscriptions","organizations_url":"https://api.github.com/users/branden/orgs","repos_url":"https://api.github.com/users/branden/repos","events_url":"https://api.github.com/users/branden/events{/privacy}","received_events_url":"https://api.github.com/users/branden/received_events","type":"User","site_admin":false},"repo":{"id":14129677,"name":"python-social-auth","full_name":"branden/python-social-auth","owner":{"login":"branden","id":42242,"avatar_url":"https://gravatar.com/avatar/49d8f54f43fa381bfa383748dc152f4c?d=https%3A%2F%2Fidenticons.github.com%2Fe670686b2fdef49617758e01e648b0b7.png&r=x","gravatar_id":"49d8f54f43fa381bfa383748dc152f4c","url":"https://api.github.com/users/branden","html_url":"https://github.com/branden","followers_url":"https://api.github.com/users/branden/followers","following_url":"https://api.github.com/users/branden/following{/other_user}","gists_url":"https://api.github.com/users/branden/gists{/gist_id}","starred_url":"https://api.github.com/users/branden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branden/subscriptions","organizations_url":"https://api.github.com/users/branden/orgs","repos_url":"https://api.github.com/users/branden/repos","events_url":"https://api.github.com/users/branden/events{/privacy}","received_events_url":"https://api.github.com/users/branden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/branden/python-social-auth","description":"Social auth made simple","fork":true,"url":"https://api.github.com/repos/branden/python-social-auth","forks_url":"https://api.github.com/repos/branden/python-social-auth/forks","keys_url":"https://api.github.com/repos/branden/python-social-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/branden/python-social-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/branden/python-social-auth/teams","hooks_url":"https://api.github.com/repos/branden/python-social-auth/hooks","issue_events_url":"https://api.github.com/repos/branden/python-social-auth/issues/events{/number}","events_url":"https://api.github.com/repos/branden/python-social-auth/events","assignees_url":"https://api.github.com/repos/branden/python-social-auth/assignees{/user}","branches_url":"https://api.github.com/repos/branden/python-social-auth/branches{/branch}","tags_url":"https://api.github.com/repos/branden/python-social-auth/tags","blobs_url":"https://api.github.com/repos/branden/python-social-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/branden/python-social-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/branden/python-social-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/branden/python-social-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/branden/python-social-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/branden/python-social-auth/languages","stargazers_url":"https://api.github.com/repos/branden/python-social-auth/stargazers","contributors_url":"https://api.github.com/repos/branden/python-social-auth/contributors","subscribers_url":"https://api.github.com/repos/branden/python-social-auth/subscribers","subscription_url":"https://api.github.com/repos/branden/python-social-auth/subscription","commits_url":"https://api.github.com/repos/branden/python-social-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/branden/python-social-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/branden/python-social-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/branden/python-social-auth/issues/comments/{number}","contents_url":"https://api.github.com/repos/branden/python-social-auth/contents/{+path}","compare_url":"https://api.github.com/repos/branden/python-social-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/branden/python-social-auth/merges","archive_url":"https://api.github.com/repos/branden/python-social-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/branden/python-social-auth/downloads","issues_url":"https://api.github.com/repos/branden/python-social-auth/issues{/number}","pulls_url":"https://api.github.com/repos/branden/python-social-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/branden/python-social-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/branden/python-social-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/branden/python-social-auth/labels{/name}","releases_url":"https://api.github.com/repos/branden/python-social-auth/releases{/id}","created_at":"2013-11-05T02:11:48Z","updated_at":"2014-01-18T15:50:16Z","pushed_at":"2013-11-05T22:45:09Z","git_url":"git://github.com/branden/python-social-auth.git","ssh_url":"git@github.com:branden/python-social-auth.git","clone_url":"https://github.com/branden/python-social-auth.git","svn_url":"https://github.com/branden/python-social-auth","homepage":"http://psa.matiasaguirre.net","size":1308,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"omab:master","ref":"master","sha":"6d63ad61c6fa6d0215e2b5b5cf9358f9b6ee6e79","user":{"login":"omab","id":91022,"avatar_url":"https://gravatar.com/avatar/5280f15cedf540b544eecc30fcf3027c?d=https%3A%2F%2Fidenticons.github.com%2F59dceb194dc25b2c234936afe9e82929.png&r=x","gravatar_id":"5280f15cedf540b544eecc30fcf3027c","url":"https://api.github.com/users/omab","html_url":"https://github.com/omab","followers_url":"https://api.github.com/users/omab/followers","following_url":"https://api.github.com/users/omab/following{/other_user}","gists_url":"https://api.github.com/users/omab/gists{/gist_id}","starred_url":"https://api.github.com/users/omab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omab/subscriptions","organizations_url":"https://api.github.com/users/omab/orgs","repos_url":"https://api.github.com/users/omab/repos","events_url":"https://api.github.com/users/omab/events{/privacy}","received_events_url":"https://api.github.com/users/omab/received_events","type":"User","site_admin":false},"repo":{"id":7133153,"name":"python-social-auth","full_name":"omab/python-social-auth","owner":{"login":"omab","id":91022,"avatar_url":"https://gravatar.com/avatar/5280f15cedf540b544eecc30fcf3027c?d=https%3A%2F%2Fidenticons.github.com%2F59dceb194dc25b2c234936afe9e82929.png&r=x","gravatar_id":"5280f15cedf540b544eecc30fcf3027c","url":"https://api.github.com/users/omab","html_url":"https://github.com/omab","followers_url":"https://api.github.com/users/omab/followers","following_url":"https://api.github.com/users/omab/following{/other_user}","gists_url":"https://api.github.com/users/omab/gists{/gist_id}","starred_url":"https://api.github.com/users/omab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omab/subscriptions","organizations_url":"https://api.github.com/users/omab/orgs","repos_url":"https://api.github.com/users/omab/repos","events_url":"https://api.github.com/users/omab/events{/privacy}","received_events_url":"https://api.github.com/users/omab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omab/python-social-auth","description":"Social auth made simple","fork":false,"url":"https://api.github.com/repos/omab/python-social-auth","forks_url":"https://api.github.com/repos/omab/python-social-auth/forks","keys_url":"https://api.github.com/repos/omab/python-social-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omab/python-social-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omab/python-social-auth/teams","hooks_url":"https://api.github.com/repos/omab/python-social-auth/hooks","issue_events_url":"https://api.github.com/repos/omab/python-social-auth/issues/events{/number}","events_url":"https://api.github.com/repos/omab/python-social-auth/events","assignees_url":"https://api.github.com/repos/omab/python-social-auth/assignees{/user}","branches_url":"https://api.github.com/repos/omab/python-social-auth/branches{/branch}","tags_url":"https://api.github.com/repos/omab/python-social-auth/tags","blobs_url":"https://api.github.com/repos/omab/python-social-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omab/python-social-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omab/python-social-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/omab/python-social-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omab/python-social-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/omab/python-social-auth/languages","stargazers_url":"https://api.github.com/repos/omab/python-social-auth/stargazers","contributors_url":"https://api.github.com/repos/omab/python-social-auth/contributors","subscribers_url":"https://api.github.com/repos/omab/python-social-auth/subscribers","subscription_url":"https://api.github.com/repos/omab/python-social-auth/subscription","commits_url":"https://api.github.com/repos/omab/python-social-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/omab/python-social-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/omab/python-social-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/omab/python-social-auth/issues/comments/{number}","contents_url":"https://api.github.com/repos/omab/python-social-auth/contents/{+path}","compare_url":"https://api.github.com/repos/omab/python-social-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omab/python-social-auth/merges","archive_url":"https://api.github.com/repos/omab/python-social-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omab/python-social-auth/downloads","issues_url":"https://api.github.com/repos/omab/python-social-auth/issues{/number}","pulls_url":"https://api.github.com/repos/omab/python-social-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/omab/python-social-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/omab/python-social-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omab/python-social-auth/labels{/name}","releases_url":"https://api.github.com/repos/omab/python-social-auth/releases{/id}","created_at":"2012-12-12T16:08:42Z","updated_at":"2014-01-18T15:22:11Z","pushed_at":"2014-01-18T15:50:16Z","git_url":"git://github.com/omab/python-social-auth.git","ssh_url":"git@github.com:omab/python-social-auth.git","clone_url":"https://github.com/omab/python-social-auth.git","svn_url":"https://github.com/omab/python-social-auth","homepage":"http://psa.matiasaguirre.net","size":3377,"stargazers_count":579,"watchers_count":579,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":127,"mirror_url":null,"open_issues_count":10,"forks":127,"open_issues":10,"watchers":579,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omab/python-social-auth/pulls/75"},"html":{"href":"https://github.com/omab/python-social-auth/pull/75"},"issue":{"href":"https://api.github.com/repos/omab/python-social-auth/issues/75"},"comments":{"href":"https://api.github.com/repos/omab/python-social-auth/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/omab/python-social-auth/pulls/75/comments"},"statuses":{"href":"https://api.github.com/repos/omab/python-social-auth/statuses/228b36bb7067306dd2e263abba2318873b3b87fa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"omab","id":91022,"avatar_url":"https://gravatar.com/avatar/5280f15cedf540b544eecc30fcf3027c?d=https%3A%2F%2Fidenticons.github.com%2F59dceb194dc25b2c234936afe9e82929.png&r=x","gravatar_id":"5280f15cedf540b544eecc30fcf3027c","url":"https://api.github.com/users/omab","html_url":"https://github.com/omab","followers_url":"https://api.github.com/users/omab/followers","following_url":"https://api.github.com/users/omab/following{/other_user}","gists_url":"https://api.github.com/users/omab/gists{/gist_id}","starred_url":"https://api.github.com/users/omab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omab/subscriptions","organizations_url":"https://api.github.com/users/omab/orgs","repos_url":"https://api.github.com/users/omab/repos","events_url":"https://api.github.com/users/omab/events{/privacy}","received_events_url":"https://api.github.com/users/omab/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":22,"deletions":13,"changed_files":3}}