GitHub PullRequestReviewCommentEvent at 2014-08-17 17:04:14
Repository: rails
Actor: robin850
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/16330662","id":16330662,"diff_hunk":"@@ -1,15 +1,9 @@\n-<%\n-  traces = { \"Application Trace\" => @application_trace,\n-             \"Framework Trace\"   => @framework_trace,\n-             \"Full Trace\"        => @full_trace }\n-%>\n-\n Rails.root: <%= defined?(Rails) && Rails.respond_to?(:root) ? Rails.root : \"unset\" %>\n \n-<% traces.each do |name, trace| %>\n+<% @traces.each do |name, trace| %>\n <% if trace.any? %>\n <%= name %>\n-<%= trace.join(\"\\n\") %>\n+<%= trace.map(&:trace).join(\"\\n\") %>","path":"actionpack/lib/action_dispatch/middleware/templates/rescues/_trace.text.erb","position":14,"original_position":14,"commit_id":"28595e01283b5c14f20929e782c1fca52ea7a0cc","original_commit_id":"28595e01283b5c14f20929e782c1fca52ea7a0cc","user":{"login":"robin850","id":354185,"avatar_url":"https://avatars.githubusercontent.com/u/354185?v=2","gravatar_id":"2d27b53e2eeb6a053552332020628029","url":"https://api.github.com/users/robin850","html_url":"https://github.com/robin850","followers_url":"https://api.github.com/users/robin850/followers","following_url":"https://api.github.com/users/robin850/following{/other_user}","gists_url":"https://api.github.com/users/robin850/gists{/gist_id}","starred_url":"https://api.github.com/users/robin850/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robin850/subscriptions","organizations_url":"https://api.github.com/users/robin850/orgs","repos_url":"https://api.github.com/users/robin850/repos","events_url":"https://api.github.com/users/robin850/events{/privacy}","received_events_url":"https://api.github.com/users/robin850/received_events","type":"User","site_admin":false},"body":"Excuse me to ask it here but how can this actually work please ? :blush: `trace` is an array of hashes and they don't respond to `:trace`.","created_at":"2014-08-17T17:04:14Z","updated_at":"2014-08-17T17:04:14Z","html_url":"https://github.com/rails/rails/pull/16427#discussion_r16330662","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/16427","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/16330662"},"html":{"href":"https://github.com/rails/rails/pull/16427#discussion_r16330662"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/16427"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/16427","id":19515020,"html_url":"https://github.com/rails/rails/pull/16427","diff_url":"https://github.com/rails/rails/pull/16427.diff","patch_url":"https://github.com/rails/rails/pull/16427.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/16427","number":16427,"state":"closed","locked":false,"title":"Full stack source extract","user":{"login":"ryandao","id":705116,"avatar_url":"https://avatars.githubusercontent.com/u/705116?v=2","gravatar_id":"a808b20427b991fb6d52edab724b24f8","url":"https://api.github.com/users/ryandao","html_url":"https://github.com/ryandao","followers_url":"https://api.github.com/users/ryandao/followers","following_url":"https://api.github.com/users/ryandao/following{/other_user}","gists_url":"https://api.github.com/users/ryandao/gists{/gist_id}","starred_url":"https://api.github.com/users/ryandao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryandao/subscriptions","organizations_url":"https://api.github.com/users/ryandao/orgs","repos_url":"https://api.github.com/users/ryandao/repos","events_url":"https://api.github.com/users/ryandao/events{/privacy}","received_events_url":"https://api.github.com/users/ryandao/received_events","type":"User","site_admin":false},"body":"This adds the ability to view code from the entire stack trace in the error page. ","created_at":"2014-08-08T08:31:10Z","updated_at":"2014-08-17T17:04:14Z","closed_at":"2014-08-08T15:00:18Z","merged_at":"2014-08-08T15:00:18Z","merge_commit_sha":"b8c3a82d0039bc89fc0643f2436bc1610a07301b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/16427/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/16427/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rails/rails/issues/16427/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/28595e01283b5c14f20929e782c1fca52ea7a0cc","head":{"label":"ryandao:full_stack_source_extract","ref":"full_stack_source_extract","sha":"28595e01283b5c14f20929e782c1fca52ea7a0cc","user":{"login":"ryandao","id":705116,"avatar_url":"https://avatars.githubusercontent.com/u/705116?v=2","gravatar_id":"a808b20427b991fb6d52edab724b24f8","url":"https://api.github.com/users/ryandao","html_url":"https://github.com/ryandao","followers_url":"https://api.github.com/users/ryandao/followers","following_url":"https://api.github.com/users/ryandao/following{/other_user}","gists_url":"https://api.github.com/users/ryandao/gists{/gist_id}","starred_url":"https://api.github.com/users/ryandao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryandao/subscriptions","organizations_url":"https://api.github.com/users/ryandao/orgs","repos_url":"https://api.github.com/users/ryandao/repos","events_url":"https://api.github.com/users/ryandao/events{/privacy}","received_events_url":"https://api.github.com/users/ryandao/received_events","type":"User","site_admin":false},"repo":{"id":22378276,"name":"rails","full_name":"ryandao/rails","owner":{"login":"ryandao","id":705116,"avatar_url":"https://avatars.githubusercontent.com/u/705116?v=2","gravatar_id":"a808b20427b991fb6d52edab724b24f8","url":"https://api.github.com/users/ryandao","html_url":"https://github.com/ryandao","followers_url":"https://api.github.com/users/ryandao/followers","following_url":"https://api.github.com/users/ryandao/following{/other_user}","gists_url":"https://api.github.com/users/ryandao/gists{/gist_id}","starred_url":"https://api.github.com/users/ryandao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryandao/subscriptions","organizations_url":"https://api.github.com/users/ryandao/orgs","repos_url":"https://api.github.com/users/ryandao/repos","events_url":"https://api.github.com/users/ryandao/events{/privacy}","received_events_url":"https://api.github.com/users/ryandao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryandao/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/ryandao/rails","forks_url":"https://api.github.com/repos/ryandao/rails/forks","keys_url":"https://api.github.com/repos/ryandao/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryandao/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryandao/rails/teams","hooks_url":"https://api.github.com/repos/ryandao/rails/hooks","issue_events_url":"https://api.github.com/repos/ryandao/rails/issues/events{/number}","events_url":"https://api.github.com/repos/ryandao/rails/events","assignees_url":"https://api.github.com/repos/ryandao/rails/assignees{/user}","branches_url":"https://api.github.com/repos/ryandao/rails/branches{/branch}","tags_url":"https://api.github.com/repos/ryandao/rails/tags","blobs_url":"https://api.github.com/repos/ryandao/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryandao/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryandao/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryandao/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryandao/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/ryandao/rails/languages","stargazers_url":"https://api.github.com/repos/ryandao/rails/stargazers","contributors_url":"https://api.github.com/repos/ryandao/rails/contributors","subscribers_url":"https://api.github.com/repos/ryandao/rails/subscribers","subscription_url":"https://api.github.com/repos/ryandao/rails/subscription","commits_url":"https://api.github.com/repos/ryandao/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryandao/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryandao/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryandao/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/ryandao/rails/contents/{+path}","compare_url":"https://api.github.com/repos/ryandao/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryandao/rails/merges","archive_url":"https://api.github.com/repos/ryandao/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryandao/rails/downloads","issues_url":"https://api.github.com/repos/ryandao/rails/issues{/number}","pulls_url":"https://api.github.com/repos/ryandao/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/ryandao/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/ryandao/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryandao/rails/labels{/name}","releases_url":"https://api.github.com/repos/ryandao/rails/releases{/id}","created_at":"2014-07-29T11:59:31Z","updated_at":"2014-07-30T15:02:16Z","pushed_at":"2014-08-08T08:05:16Z","git_url":"git://github.com/ryandao/rails.git","ssh_url":"git@github.com:ryandao/rails.git","clone_url":"https://github.com/ryandao/rails.git","svn_url":"https://github.com/ryandao/rails","homepage":"http://rubyonrails.org","size":117478,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"30529dc00f96777c325dff496930f560fb9d59e9","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=2","gravatar_id":"30f39a09e233e8369dddf6feb4be0308","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=2","gravatar_id":"30f39a09e233e8369dddf6feb4be0308","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2014-08-17T15:26:10Z","pushed_at":"2014-08-17T16:53:59Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":361726,"stargazers_count":22865,"watchers_count":22865,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":8592,"mirror_url":null,"open_issues_count":691,"forks":8592,"open_issues":691,"watchers":22865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/16427"},"html":{"href":"https://github.com/rails/rails/pull/16427"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/16427"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/16427/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/16427/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/16427/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/28595e01283b5c14f20929e782c1fca52ea7a0cc"}}}}