GitHub PullRequestReviewCommentEvent at 2014-10-04 18:23:57
Repository: joomla-cms
Actor: betweenbrain
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/18430817","id":18430817,"diff_hunk":"@@ -96,29 +96,45 @@ a.grid_true {\n \n /* For collapsible sidebar */\n #j-sidebar-container {\n-\tmargin-left: 10px;\n+\tmargin-right: 10px;\n+}\n+div#j-sidebar-container.j-toggle-hidden {","path":"administrator/templates/isis/less/template-rtl.less","position":7,"original_position":7,"commit_id":"112c53afc62c930ef5b877b2684984e522239634","original_commit_id":"112c53afc62c930ef5b877b2684984e522239634","user":{"login":"betweenbrain","id":634119,"avatar_url":"https://avatars.githubusercontent.com/u/634119?v=2","gravatar_id":"","url":"https://api.github.com/users/betweenbrain","html_url":"https://github.com/betweenbrain","followers_url":"https://api.github.com/users/betweenbrain/followers","following_url":"https://api.github.com/users/betweenbrain/following{/other_user}","gists_url":"https://api.github.com/users/betweenbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/betweenbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betweenbrain/subscriptions","organizations_url":"https://api.github.com/users/betweenbrain/orgs","repos_url":"https://api.github.com/users/betweenbrain/repos","events_url":"https://api.github.com/users/betweenbrain/events{/privacy}","received_events_url":"https://api.github.com/users/betweenbrain/received_events","type":"User","site_admin":false},"body":"There is really no need for `div` in this, and other declarations, since we're dealing with an ID here. While it is used elsewhere, I'd suggest not using it here and we can clean the others up later.","created_at":"2014-10-04T18:23:57Z","updated_at":"2014-10-04T18:23:57Z","html_url":"https://github.com/joomla/joomla-cms/pull/4450#discussion_r18430817","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/4450","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/18430817"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/4450#discussion_r18430817"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/4450"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/4450","id":22242328,"html_url":"https://github.com/joomla/joomla-cms/pull/4450","diff_url":"https://github.com/joomla/joomla-cms/pull/4450.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/4450.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/4450","number":4450,"state":"open","locked":false,"title":"Update to sidebar toggle styling","user":{"login":"dbhurley","id":5251425,"avatar_url":"https://avatars.githubusercontent.com/u/5251425?v=2","gravatar_id":"","url":"https://api.github.com/users/dbhurley","html_url":"https://github.com/dbhurley","followers_url":"https://api.github.com/users/dbhurley/followers","following_url":"https://api.github.com/users/dbhurley/following{/other_user}","gists_url":"https://api.github.com/users/dbhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbhurley/subscriptions","organizations_url":"https://api.github.com/users/dbhurley/orgs","repos_url":"https://api.github.com/users/dbhurley/repos","events_url":"https://api.github.com/users/dbhurley/events{/privacy}","received_events_url":"https://api.github.com/users/dbhurley/received_events","type":"User","site_admin":false},"body":"Update to UI and language file naming conventions","created_at":"2014-10-04T10:51:33Z","updated_at":"2014-10-04T18:23:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c78e493dcd1d15fbdd23874eb247cbb6a088a7e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/4450/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/4450/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/4450/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/112c53afc62c930ef5b877b2684984e522239634","head":{"label":"dbhurley:sidebar-update","ref":"sidebar-update","sha":"112c53afc62c930ef5b877b2684984e522239634","user":{"login":"dbhurley","id":5251425,"avatar_url":"https://avatars.githubusercontent.com/u/5251425?v=2","gravatar_id":"","url":"https://api.github.com/users/dbhurley","html_url":"https://github.com/dbhurley","followers_url":"https://api.github.com/users/dbhurley/followers","following_url":"https://api.github.com/users/dbhurley/following{/other_user}","gists_url":"https://api.github.com/users/dbhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbhurley/subscriptions","organizations_url":"https://api.github.com/users/dbhurley/orgs","repos_url":"https://api.github.com/users/dbhurley/repos","events_url":"https://api.github.com/users/dbhurley/events{/privacy}","received_events_url":"https://api.github.com/users/dbhurley/received_events","type":"User","site_admin":false},"repo":{"id":8680714,"name":"joomla-cms","full_name":"dbhurley/joomla-cms","owner":{"login":"dbhurley","id":5251425,"avatar_url":"https://avatars.githubusercontent.com/u/5251425?v=2","gravatar_id":"","url":"https://api.github.com/users/dbhurley","html_url":"https://github.com/dbhurley","followers_url":"https://api.github.com/users/dbhurley/followers","following_url":"https://api.github.com/users/dbhurley/following{/other_user}","gists_url":"https://api.github.com/users/dbhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbhurley/subscriptions","organizations_url":"https://api.github.com/users/dbhurley/orgs","repos_url":"https://api.github.com/users/dbhurley/repos","events_url":"https://api.github.com/users/dbhurley/events{/privacy}","received_events_url":"https://api.github.com/users/dbhurley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbhurley/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/dbhurley/joomla-cms","forks_url":"https://api.github.com/repos/dbhurley/joomla-cms/forks","keys_url":"https://api.github.com/repos/dbhurley/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbhurley/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbhurley/joomla-cms/teams","hooks_url":"https://api.github.com/repos/dbhurley/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/dbhurley/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/dbhurley/joomla-cms/events","assignees_url":"https://api.github.com/repos/dbhurley/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/dbhurley/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/dbhurley/joomla-cms/tags","blobs_url":"https://api.github.com/repos/dbhurley/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbhurley/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbhurley/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbhurley/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbhurley/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/dbhurley/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/dbhurley/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/dbhurley/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/dbhurley/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/dbhurley/joomla-cms/subscription","commits_url":"https://api.github.com/repos/dbhurley/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbhurley/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbhurley/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbhurley/joomla-cms/issues/comments/{number}","contents_url":"https://api.github.com/repos/dbhurley/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/dbhurley/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbhurley/joomla-cms/merges","archive_url":"https://api.github.com/repos/dbhurley/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbhurley/joomla-cms/downloads","issues_url":"https://api.github.com/repos/dbhurley/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/dbhurley/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/dbhurley/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/dbhurley/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbhurley/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/dbhurley/joomla-cms/releases{/id}","created_at":"2013-03-10T04:50:35Z","updated_at":"2014-07-26T13:48:33Z","pushed_at":"2014-10-04T10:53:11Z","git_url":"git://github.com/dbhurley/joomla-cms.git","ssh_url":"git@github.com:dbhurley/joomla-cms.git","clone_url":"https://github.com/dbhurley/joomla-cms.git","svn_url":"https://github.com/dbhurley/joomla-cms","homepage":"http://joomla.org","size":104362,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"joomla:staging","ref":"staging","sha":"ff42a7e1881ba7df8aa69843834ca26b299ac482","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=2","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=2","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/{number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","created_at":"2011-09-27T02:07:38Z","updated_at":"2014-10-04T15:22:15Z","pushed_at":"2014-10-04T17:58:51Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"http://joomla.org","size":275651,"stargazers_count":1295,"watchers_count":1295,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1391,"mirror_url":null,"open_issues_count":434,"forks":1391,"open_issues":434,"watchers":1295,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/4450"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/4450"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/4450"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/4450/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/4450/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/4450/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/112c53afc62c930ef5b877b2684984e522239634"}}}}