GitHub PushEvent at 2014-09-29 02:28:28
Repository: libmarquise
Actor: barneydesmond
Payload: {"shas":[["9da941101d6301d134ccc59f05acd5128c5f7add","c31cc92c4de6a742e29c2cce71987a046e40ae71@anchor.net.au","Set the LSB of all sourcedict addresses to zero\n\nWe've identified a problem with the way that sourcedicts are stored in\nthe vault. Normally, we generate an address and pass it along with\npoints and sourcedicts. For simple points, the address gets coerced to\nan even number by setting the least significant bit to zero. Extended\npoints have their LSB set to one.\n\nThe same is not happening for sourcedicts. This means that it's possible\nfor data points and their associated sourcedict to be stored at\ndifferent addresses. This is bad, because we can enumerate the\nsourcedicts, but won't necessarily find data points at the corresponding\naddress.\n\nWe've determined that the correct behaviour, at least if we follow the\n\"official\" Marquise client, is to set the LSB of all sourcedicts to\nzero.","Barney Desmond",false],["c2da2007d3188e850c8236b05aa8f4af934ef932","f4e2cff0138e8cd5600e8ca295bf078683584659@tesser.org","Clear the LSB of the address in marquise_hash_identifier\n\nThis is so we don't have to worry about whether it's been zeroed or not\nfor consistency reasons, and to match the corresponding functionality in\nthe reference implementation (Marquise Haskell module).","Sharif Olorin",false],["a907cb38296998fe1d7fc01d90b20d844290b005","f4e2cff0138e8cd5600e8ca295bf078683584659@tesser.org","Should ensure the LSB is clear on write as well\n\nAt least until we sort out the confusion wrt extended addresses.","Sharif Olorin",false],["72abb169d78b014b41c2471936f7891832c38fdb","f4e2cff0138e8cd5600e8ca295bf078683584659@tesser.org","Add test for LSB-clearing in marquise_hash_identifier","Sharif Olorin",false],["05cc7a1a2c60cc2f0133349d01eb0dac59325bcd","7258370914e11e215b05e7df178d13f0c141ac47@gmail.com","Merge pull request #20 from anchor/slightly-different-address-fix\n\nAssign correct addresses to spooled sourcedicts, zero LSB in all cases","Barney Desmond",true]],"size":5,"ref":"refs/heads/master","head":"05cc7a1a2c60cc2f0133349d01eb0dac59325bcd"}