GitHub PullRequestReviewCommentEvent at 2014-12-05 13:05:44
Repository: bitcoin
Actor: luke-jr
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/21370735","id":21370735,"diff_hunk":"@@ -754,6 +760,22 @@ if test x$bitcoin_enable_qt != xno; then\n   fi\n fi\n \n+# conditional search for and use libzmq\n+AC_MSG_CHECKING([whether to build ZMQ support])\n+if test \"x$use_zmq\" == \"xyes\"; then\n+  AC_MSG_RESULT([yes])\n+  PKG_CHECK_MODULES([ZMQ],[libzmq],\n+    [AC_DEFINE([ENABLE_ZMQ],[1],[Define to 1 to enable ZMQ functions])],\n+    [AC_DEFINE([ENABLE_ZMQ],[0],[Define to 1 to enable ZMQ functions])\n+     AC_MSG_WARN([libzmq not found, disabling])","path":"configure.ac","position":24,"original_position":24,"commit_id":"6392f40a49b759b1165699c6cb880b8d2c8beb07","original_commit_id":"6392f40a49b759b1165699c6cb880b8d2c8beb07","user":{"login":"luke-jr","id":1095675,"avatar_url":"https://avatars.githubusercontent.com/u/1095675?v=3","gravatar_id":"","url":"https://api.github.com/users/luke-jr","html_url":"https://github.com/luke-jr","followers_url":"https://api.github.com/users/luke-jr/followers","following_url":"https://api.github.com/users/luke-jr/following{/other_user}","gists_url":"https://api.github.com/users/luke-jr/gists{/gist_id}","starred_url":"https://api.github.com/users/luke-jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luke-jr/subscriptions","organizations_url":"https://api.github.com/users/luke-jr/orgs","repos_url":"https://api.github.com/users/luke-jr/repos","events_url":"https://api.github.com/users/luke-jr/events{/privacy}","received_events_url":"https://api.github.com/users/luke-jr/received_events","type":"User","site_admin":false},"body":"Better to error if --enable-zmq is explicitly passed.","created_at":"2014-12-05T13:05:44Z","updated_at":"2014-12-05T13:05:44Z","html_url":"https://github.com/bitcoin/bitcoin/pull/5303#discussion_r21370735","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5303","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/21370735"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/5303#discussion_r21370735"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5303"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5303","id":24627125,"html_url":"https://github.com/bitcoin/bitcoin/pull/5303","diff_url":"https://github.com/bitcoin/bitcoin/pull/5303.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/5303.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5303","number":5303,"state":"open","locked":false,"title":"Add ZMQ support.  Report blocks and transactions via ZMQ.","user":{"login":"jgarzik","id":494411,"avatar_url":"https://avatars.githubusercontent.com/u/494411?v=3","gravatar_id":"","url":"https://api.github.com/users/jgarzik","html_url":"https://github.com/jgarzik","followers_url":"https://api.github.com/users/jgarzik/followers","following_url":"https://api.github.com/users/jgarzik/following{/other_user}","gists_url":"https://api.github.com/users/jgarzik/gists{/gist_id}","starred_url":"https://api.github.com/users/jgarzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgarzik/subscriptions","organizations_url":"https://api.github.com/users/jgarzik/orgs","repos_url":"https://api.github.com/users/jgarzik/repos","events_url":"https://api.github.com/users/jgarzik/events{/privacy}","received_events_url":"https://api.github.com/users/jgarzik/received_events","type":"User","site_admin":false},"body":"Continues Johnathan Corgan's work. Supercedes #4594 ","created_at":"2014-11-18T17:08:03Z","updated_at":"2014-12-05T13:05:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8da8f21ba09c55ec0826a5de6814be55c4bfbe49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5303/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5303/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5303/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/6392f40a49b759b1165699c6cb880b8d2c8beb07","head":{"label":"jgarzik:zmq","ref":"zmq","sha":"6392f40a49b759b1165699c6cb880b8d2c8beb07","user":{"login":"jgarzik","id":494411,"avatar_url":"https://avatars.githubusercontent.com/u/494411?v=3","gravatar_id":"","url":"https://api.github.com/users/jgarzik","html_url":"https://github.com/jgarzik","followers_url":"https://api.github.com/users/jgarzik/followers","following_url":"https://api.github.com/users/jgarzik/following{/other_user}","gists_url":"https://api.github.com/users/jgarzik/gists{/gist_id}","starred_url":"https://api.github.com/users/jgarzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgarzik/subscriptions","organizations_url":"https://api.github.com/users/jgarzik/orgs","repos_url":"https://api.github.com/users/jgarzik/repos","events_url":"https://api.github.com/users/jgarzik/events{/privacy}","received_events_url":"https://api.github.com/users/jgarzik/received_events","type":"User","site_admin":false},"repo":{"id":1183300,"name":"bitcoin","full_name":"jgarzik/bitcoin","owner":{"login":"jgarzik","id":494411,"avatar_url":"https://avatars.githubusercontent.com/u/494411?v=3","gravatar_id":"","url":"https://api.github.com/users/jgarzik","html_url":"https://github.com/jgarzik","followers_url":"https://api.github.com/users/jgarzik/followers","following_url":"https://api.github.com/users/jgarzik/following{/other_user}","gists_url":"https://api.github.com/users/jgarzik/gists{/gist_id}","starred_url":"https://api.github.com/users/jgarzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgarzik/subscriptions","organizations_url":"https://api.github.com/users/jgarzik/orgs","repos_url":"https://api.github.com/users/jgarzik/repos","events_url":"https://api.github.com/users/jgarzik/events{/privacy}","received_events_url":"https://api.github.com/users/jgarzik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgarzik/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/jgarzik/bitcoin","forks_url":"https://api.github.com/repos/jgarzik/bitcoin/forks","keys_url":"https://api.github.com/repos/jgarzik/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgarzik/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgarzik/bitcoin/teams","hooks_url":"https://api.github.com/repos/jgarzik/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/jgarzik/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/jgarzik/bitcoin/events","assignees_url":"https://api.github.com/repos/jgarzik/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/jgarzik/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/jgarzik/bitcoin/tags","blobs_url":"https://api.github.com/repos/jgarzik/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgarzik/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgarzik/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgarzik/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgarzik/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/jgarzik/bitcoin/languages","stargazers_url":"https://api.github.com/repos/jgarzik/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/jgarzik/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/jgarzik/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/jgarzik/bitcoin/subscription","commits_url":"https://api.github.com/repos/jgarzik/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgarzik/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgarzik/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgarzik/bitcoin/issues/comments/{number}","contents_url":"https://api.github.com/repos/jgarzik/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/jgarzik/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgarzik/bitcoin/merges","archive_url":"https://api.github.com/repos/jgarzik/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgarzik/bitcoin/downloads","issues_url":"https://api.github.com/repos/jgarzik/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/jgarzik/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/jgarzik/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/jgarzik/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgarzik/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/jgarzik/bitcoin/releases{/id}","created_at":"2010-12-20T03:27:16Z","updated_at":"2014-08-17T19:51:56Z","pushed_at":"2014-11-19T04:22:55Z","git_url":"git://github.com/jgarzik/bitcoin.git","ssh_url":"git@github.com:jgarzik/bitcoin.git","clone_url":"https://github.com/jgarzik/bitcoin.git","svn_url":"https://github.com/jgarzik/bitcoin","homepage":"http://www.bitcoin.org","size":36505,"stargazers_count":20,"watchers_count":20,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":20,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"7715c847472f565ca79429db0d8505f126617878","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2014-12-05T11:01:49Z","pushed_at":"2014-12-05T11:01:49Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":98447,"stargazers_count":6130,"watchers_count":6130,"language":"TypeScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4460,"mirror_url":null,"open_issues_count":433,"forks":4460,"open_issues":433,"watchers":6130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5303"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/5303"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/5303"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/5303/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5303/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5303/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/6392f40a49b759b1165699c6cb880b8d2c8beb07"}}}}