GitHub PullRequestReviewCommentEvent at 2014-10-31 18:32:08
Repository: Markus
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/19684899","id":19684899,"diff_hunk":"@@ -313,7 +313,7 @@ class AnnotationsControllerTest < AuthenticatedControllerTest\n   end\n \n   should 'recognize action to destroy' do\n-    assert_recognizes( {:action => 'destroy', :controller => 'annotations'},\n-                       {:path => 'annotations', :method => 'delete'} )\n+    assert_recognizes( {:action => 'destroy', :controller => 'annotations', id: '1'},\n+                       {:path => 'annotations/1', :method => 'delete'} )","path":"test/functional/annotations_controller_test.rb","position":7,"original_position":7,"commit_id":"b6caa040fa5f20ddc8ffc663cf31a86945b40057","original_commit_id":"b6caa040fa5f20ddc8ffc663cf31a86945b40057","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Use the new Ruby 1.9 hash syntax.","created_at":"2014-10-31T18:32:08Z","updated_at":"2014-10-31T18:32:08Z","html_url":"https://github.com/MarkUsProject/Markus/pull/1861#discussion_r19684899","pull_request_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1861","_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/19684899"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/1861#discussion_r19684899"},"pull_request":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1861"}}},"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1861","id":23696825,"html_url":"https://github.com/MarkUsProject/Markus/pull/1861","diff_url":"https://github.com/MarkUsProject/Markus/pull/1861.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/1861.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/1861","number":1861,"state":"open","locked":false,"title":"Fix errors and deprecation warnings","user":{"login":"YusiFan","id":1100855,"avatar_url":"https://avatars.githubusercontent.com/u/1100855?v=2","gravatar_id":"","url":"https://api.github.com/users/YusiFan","html_url":"https://github.com/YusiFan","followers_url":"https://api.github.com/users/YusiFan/followers","following_url":"https://api.github.com/users/YusiFan/following{/other_user}","gists_url":"https://api.github.com/users/YusiFan/gists{/gist_id}","starred_url":"https://api.github.com/users/YusiFan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YusiFan/subscriptions","organizations_url":"https://api.github.com/users/YusiFan/orgs","repos_url":"https://api.github.com/users/YusiFan/repos","events_url":"https://api.github.com/users/YusiFan/events{/privacy}","received_events_url":"https://api.github.com/users/YusiFan/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-31T18:32:03Z","updated_at":"2014-10-31T18:32:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85ad2548a922be1075a5657c0b19769e3c2bfdc2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1861/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1861/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/1861/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/b6caa040fa5f20ddc8ffc663cf31a86945b40057","head":{"label":"YusiFan:rails4_new","ref":"rails4_new","sha":"b6caa040fa5f20ddc8ffc663cf31a86945b40057","user":{"login":"YusiFan","id":1100855,"avatar_url":"https://avatars.githubusercontent.com/u/1100855?v=2","gravatar_id":"","url":"https://api.github.com/users/YusiFan","html_url":"https://github.com/YusiFan","followers_url":"https://api.github.com/users/YusiFan/followers","following_url":"https://api.github.com/users/YusiFan/following{/other_user}","gists_url":"https://api.github.com/users/YusiFan/gists{/gist_id}","starred_url":"https://api.github.com/users/YusiFan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YusiFan/subscriptions","organizations_url":"https://api.github.com/users/YusiFan/orgs","repos_url":"https://api.github.com/users/YusiFan/repos","events_url":"https://api.github.com/users/YusiFan/events{/privacy}","received_events_url":"https://api.github.com/users/YusiFan/received_events","type":"User","site_admin":false},"repo":{"id":23925968,"name":"Markus","full_name":"YusiFan/Markus","owner":{"login":"YusiFan","id":1100855,"avatar_url":"https://avatars.githubusercontent.com/u/1100855?v=2","gravatar_id":"","url":"https://api.github.com/users/YusiFan","html_url":"https://github.com/YusiFan","followers_url":"https://api.github.com/users/YusiFan/followers","following_url":"https://api.github.com/users/YusiFan/following{/other_user}","gists_url":"https://api.github.com/users/YusiFan/gists{/gist_id}","starred_url":"https://api.github.com/users/YusiFan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YusiFan/subscriptions","organizations_url":"https://api.github.com/users/YusiFan/orgs","repos_url":"https://api.github.com/users/YusiFan/repos","events_url":"https://api.github.com/users/YusiFan/events{/privacy}","received_events_url":"https://api.github.com/users/YusiFan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YusiFan/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/YusiFan/Markus","forks_url":"https://api.github.com/repos/YusiFan/Markus/forks","keys_url":"https://api.github.com/repos/YusiFan/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YusiFan/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YusiFan/Markus/teams","hooks_url":"https://api.github.com/repos/YusiFan/Markus/hooks","issue_events_url":"https://api.github.com/repos/YusiFan/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/YusiFan/Markus/events","assignees_url":"https://api.github.com/repos/YusiFan/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/YusiFan/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/YusiFan/Markus/tags","blobs_url":"https://api.github.com/repos/YusiFan/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YusiFan/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YusiFan/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/YusiFan/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YusiFan/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/YusiFan/Markus/languages","stargazers_url":"https://api.github.com/repos/YusiFan/Markus/stargazers","contributors_url":"https://api.github.com/repos/YusiFan/Markus/contributors","subscribers_url":"https://api.github.com/repos/YusiFan/Markus/subscribers","subscription_url":"https://api.github.com/repos/YusiFan/Markus/subscription","commits_url":"https://api.github.com/repos/YusiFan/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/YusiFan/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/YusiFan/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/YusiFan/Markus/issues/comments/{number}","contents_url":"https://api.github.com/repos/YusiFan/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/YusiFan/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YusiFan/Markus/merges","archive_url":"https://api.github.com/repos/YusiFan/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YusiFan/Markus/downloads","issues_url":"https://api.github.com/repos/YusiFan/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/YusiFan/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/YusiFan/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/YusiFan/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YusiFan/Markus/labels{/name}","releases_url":"https://api.github.com/repos/YusiFan/Markus/releases{/id}","created_at":"2014-09-11T16:21:17Z","updated_at":"2014-09-12T20:20:24Z","pushed_at":"2014-10-31T05:57:05Z","git_url":"git://github.com/YusiFan/Markus.git","ssh_url":"git@github.com:YusiFan/Markus.git","clone_url":"https://github.com/YusiFan/Markus.git","svn_url":"https://github.com/YusiFan/Markus","homepage":"http://www.markusproject.org","size":17451,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkUsProject:rails4","ref":"rails4","sha":"570d7ad033b96f97e2a588611693b57c916f9878","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=2","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=2","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments/{number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","created_at":"2010-09-26T16:18:08Z","updated_at":"2014-10-30T16:16:19Z","pushed_at":"2014-10-30T15:09:23Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":47783,"stargazers_count":114,"watchers_count":114,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":117,"forks":135,"open_issues":117,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1861"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/1861"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/1861"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/1861/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1861/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/1861/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/b6caa040fa5f20ddc8ffc663cf31a86945b40057"}}}}