GitHub PullRequestReviewCommentEvent at 2014-10-12 23:07:30
Repository: Plasma
Actor: dpogue
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/H-uru/Plasma/pulls/comments/18750957","id":18750957,"diff_hunk":"@@ -1,11 +1,15 @@\n # Detect Clang compiler\n-if(\"${CMAKE_CXX_COMPILER_ID}\" STREQUAL \"Clang\")\n+if(\"${CMAKE_CXX_COMPILER_ID}\" STREQUAL \"Clang\" OR\n+   \"${CMAKE_CXX_COMPILER_ID}\" STREQUAL \"AppleClang\")","path":"cmake/CompilerChecks.cmake","position":4,"original_position":4,"commit_id":"7d0c73eda3f2cb6efb6f96f2762e6bd812df9300","original_commit_id":"7d0c73eda3f2cb6efb6f96f2762e6bd812df9300","user":{"login":"dpogue","id":241708,"avatar_url":"https://avatars.githubusercontent.com/u/241708?v=2","gravatar_id":"","url":"https://api.github.com/users/dpogue","html_url":"https://github.com/dpogue","followers_url":"https://api.github.com/users/dpogue/followers","following_url":"https://api.github.com/users/dpogue/following{/other_user}","gists_url":"https://api.github.com/users/dpogue/gists{/gist_id}","starred_url":"https://api.github.com/users/dpogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpogue/subscriptions","organizations_url":"https://api.github.com/users/dpogue/orgs","repos_url":"https://api.github.com/users/dpogue/repos","events_url":"https://api.github.com/users/dpogue/events{/privacy}","received_events_url":"https://api.github.com/users/dpogue/received_events","type":"User","site_admin":false},"body":"One suggested way of doing this was `if(\"${CMAKE_CXX_COMPILER_ID}\" MATCHES \".*Clang\")`","created_at":"2014-10-12T23:07:30Z","updated_at":"2014-10-12T23:07:30Z","html_url":"https://github.com/H-uru/Plasma/pull/452#discussion_r18750957","pull_request_url":"https://api.github.com/repos/H-uru/Plasma/pulls/452","_links":{"self":{"href":"https://api.github.com/repos/H-uru/Plasma/pulls/comments/18750957"},"html":{"href":"https://github.com/H-uru/Plasma/pull/452#discussion_r18750957"},"pull_request":{"href":"https://api.github.com/repos/H-uru/Plasma/pulls/452"}}},"pull_request":{"url":"https://api.github.com/repos/H-uru/Plasma/pulls/452","id":22619818,"html_url":"https://github.com/H-uru/Plasma/pull/452","diff_url":"https://github.com/H-uru/Plasma/pull/452.diff","patch_url":"https://github.com/H-uru/Plasma/pull/452.patch","issue_url":"https://api.github.com/repos/H-uru/Plasma/issues/452","number":452,"state":"open","locked":false,"title":"Some fixes for OSX compilation.  Closes #450","user":{"login":"zrax","id":714191,"avatar_url":"https://avatars.githubusercontent.com/u/714191?v=2","gravatar_id":"","url":"https://api.github.com/users/zrax","html_url":"https://github.com/zrax","followers_url":"https://api.github.com/users/zrax/followers","following_url":"https://api.github.com/users/zrax/following{/other_user}","gists_url":"https://api.github.com/users/zrax/gists{/gist_id}","starred_url":"https://api.github.com/users/zrax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrax/subscriptions","organizations_url":"https://api.github.com/users/zrax/orgs","repos_url":"https://api.github.com/users/zrax/repos","events_url":"https://api.github.com/users/zrax/events{/privacy}","received_events_url":"https://api.github.com/users/zrax/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-12T20:28:30Z","updated_at":"2014-10-12T23:07:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d85c356a2e35d04d5cd33c9293f8b6d44cf72a39","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/H-uru/Plasma/pulls/452/commits","review_comments_url":"https://api.github.com/repos/H-uru/Plasma/pulls/452/comments","review_comment_url":"https://api.github.com/repos/H-uru/Plasma/pulls/comments/{number}","comments_url":"https://api.github.com/repos/H-uru/Plasma/issues/452/comments","statuses_url":"https://api.github.com/repos/H-uru/Plasma/statuses/7d0c73eda3f2cb6efb6f96f2762e6bd812df9300","head":{"label":"zrax:osx_fix","ref":"osx_fix","sha":"7d0c73eda3f2cb6efb6f96f2762e6bd812df9300","user":{"login":"zrax","id":714191,"avatar_url":"https://avatars.githubusercontent.com/u/714191?v=2","gravatar_id":"","url":"https://api.github.com/users/zrax","html_url":"https://github.com/zrax","followers_url":"https://api.github.com/users/zrax/followers","following_url":"https://api.github.com/users/zrax/following{/other_user}","gists_url":"https://api.github.com/users/zrax/gists{/gist_id}","starred_url":"https://api.github.com/users/zrax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrax/subscriptions","organizations_url":"https://api.github.com/users/zrax/orgs","repos_url":"https://api.github.com/users/zrax/repos","events_url":"https://api.github.com/users/zrax/events{/privacy}","received_events_url":"https://api.github.com/users/zrax/received_events","type":"User","site_admin":false},"repo":{"id":1608036,"name":"Plasma","full_name":"zrax/Plasma","owner":{"login":"zrax","id":714191,"avatar_url":"https://avatars.githubusercontent.com/u/714191?v=2","gravatar_id":"","url":"https://api.github.com/users/zrax","html_url":"https://github.com/zrax","followers_url":"https://api.github.com/users/zrax/followers","following_url":"https://api.github.com/users/zrax/following{/other_user}","gists_url":"https://api.github.com/users/zrax/gists{/gist_id}","starred_url":"https://api.github.com/users/zrax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrax/subscriptions","organizations_url":"https://api.github.com/users/zrax/orgs","repos_url":"https://api.github.com/users/zrax/repos","events_url":"https://api.github.com/users/zrax/events{/privacy}","received_events_url":"https://api.github.com/users/zrax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zrax/Plasma","description":"Cyan Worlds's Plasma game engine","fork":true,"url":"https://api.github.com/repos/zrax/Plasma","forks_url":"https://api.github.com/repos/zrax/Plasma/forks","keys_url":"https://api.github.com/repos/zrax/Plasma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zrax/Plasma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zrax/Plasma/teams","hooks_url":"https://api.github.com/repos/zrax/Plasma/hooks","issue_events_url":"https://api.github.com/repos/zrax/Plasma/issues/events{/number}","events_url":"https://api.github.com/repos/zrax/Plasma/events","assignees_url":"https://api.github.com/repos/zrax/Plasma/assignees{/user}","branches_url":"https://api.github.com/repos/zrax/Plasma/branches{/branch}","tags_url":"https://api.github.com/repos/zrax/Plasma/tags","blobs_url":"https://api.github.com/repos/zrax/Plasma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zrax/Plasma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zrax/Plasma/git/refs{/sha}","trees_url":"https://api.github.com/repos/zrax/Plasma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zrax/Plasma/statuses/{sha}","languages_url":"https://api.github.com/repos/zrax/Plasma/languages","stargazers_url":"https://api.github.com/repos/zrax/Plasma/stargazers","contributors_url":"https://api.github.com/repos/zrax/Plasma/contributors","subscribers_url":"https://api.github.com/repos/zrax/Plasma/subscribers","subscription_url":"https://api.github.com/repos/zrax/Plasma/subscription","commits_url":"https://api.github.com/repos/zrax/Plasma/commits{/sha}","git_commits_url":"https://api.github.com/repos/zrax/Plasma/git/commits{/sha}","comments_url":"https://api.github.com/repos/zrax/Plasma/comments{/number}","issue_comment_url":"https://api.github.com/repos/zrax/Plasma/issues/comments/{number}","contents_url":"https://api.github.com/repos/zrax/Plasma/contents/{+path}","compare_url":"https://api.github.com/repos/zrax/Plasma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zrax/Plasma/merges","archive_url":"https://api.github.com/repos/zrax/Plasma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zrax/Plasma/downloads","issues_url":"https://api.github.com/repos/zrax/Plasma/issues{/number}","pulls_url":"https://api.github.com/repos/zrax/Plasma/pulls{/number}","milestones_url":"https://api.github.com/repos/zrax/Plasma/milestones{/number}","notifications_url":"https://api.github.com/repos/zrax/Plasma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zrax/Plasma/labels{/name}","releases_url":"https://api.github.com/repos/zrax/Plasma/releases{/id}","created_at":"2011-04-13T06:51:11Z","updated_at":"2014-06-05T02:55:31Z","pushed_at":"2014-10-12T20:27:51Z","git_url":"git://github.com/zrax/Plasma.git","ssh_url":"git@github.com:zrax/Plasma.git","clone_url":"https://github.com/zrax/Plasma.git","svn_url":"https://github.com/zrax/Plasma","homepage":"","size":36196,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"H-uru:master","ref":"master","sha":"4f5a941d41e33e9bfacb05994a80aa280b8f3904","user":{"login":"H-uru","id":714185,"avatar_url":"https://avatars.githubusercontent.com/u/714185?v=2","gravatar_id":"","url":"https://api.github.com/users/H-uru","html_url":"https://github.com/H-uru","followers_url":"https://api.github.com/users/H-uru/followers","following_url":"https://api.github.com/users/H-uru/following{/other_user}","gists_url":"https://api.github.com/users/H-uru/gists{/gist_id}","starred_url":"https://api.github.com/users/H-uru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/H-uru/subscriptions","organizations_url":"https://api.github.com/users/H-uru/orgs","repos_url":"https://api.github.com/users/H-uru/repos","events_url":"https://api.github.com/users/H-uru/events{/privacy}","received_events_url":"https://api.github.com/users/H-uru/received_events","type":"Organization","site_admin":false},"repo":{"id":1579856,"name":"Plasma","full_name":"H-uru/Plasma","owner":{"login":"H-uru","id":714185,"avatar_url":"https://avatars.githubusercontent.com/u/714185?v=2","gravatar_id":"","url":"https://api.github.com/users/H-uru","html_url":"https://github.com/H-uru","followers_url":"https://api.github.com/users/H-uru/followers","following_url":"https://api.github.com/users/H-uru/following{/other_user}","gists_url":"https://api.github.com/users/H-uru/gists{/gist_id}","starred_url":"https://api.github.com/users/H-uru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/H-uru/subscriptions","organizations_url":"https://api.github.com/users/H-uru/orgs","repos_url":"https://api.github.com/users/H-uru/repos","events_url":"https://api.github.com/users/H-uru/events{/privacy}","received_events_url":"https://api.github.com/users/H-uru/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/H-uru/Plasma","description":"Cyan Worlds's Plasma game engine","fork":false,"url":"https://api.github.com/repos/H-uru/Plasma","forks_url":"https://api.github.com/repos/H-uru/Plasma/forks","keys_url":"https://api.github.com/repos/H-uru/Plasma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/H-uru/Plasma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/H-uru/Plasma/teams","hooks_url":"https://api.github.com/repos/H-uru/Plasma/hooks","issue_events_url":"https://api.github.com/repos/H-uru/Plasma/issues/events{/number}","events_url":"https://api.github.com/repos/H-uru/Plasma/events","assignees_url":"https://api.github.com/repos/H-uru/Plasma/assignees{/user}","branches_url":"https://api.github.com/repos/H-uru/Plasma/branches{/branch}","tags_url":"https://api.github.com/repos/H-uru/Plasma/tags","blobs_url":"https://api.github.com/repos/H-uru/Plasma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/H-uru/Plasma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/H-uru/Plasma/git/refs{/sha}","trees_url":"https://api.github.com/repos/H-uru/Plasma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/H-uru/Plasma/statuses/{sha}","languages_url":"https://api.github.com/repos/H-uru/Plasma/languages","stargazers_url":"https://api.github.com/repos/H-uru/Plasma/stargazers","contributors_url":"https://api.github.com/repos/H-uru/Plasma/contributors","subscribers_url":"https://api.github.com/repos/H-uru/Plasma/subscribers","subscription_url":"https://api.github.com/repos/H-uru/Plasma/subscription","commits_url":"https://api.github.com/repos/H-uru/Plasma/commits{/sha}","git_commits_url":"https://api.github.com/repos/H-uru/Plasma/git/commits{/sha}","comments_url":"https://api.github.com/repos/H-uru/Plasma/comments{/number}","issue_comment_url":"https://api.github.com/repos/H-uru/Plasma/issues/comments/{number}","contents_url":"https://api.github.com/repos/H-uru/Plasma/contents/{+path}","compare_url":"https://api.github.com/repos/H-uru/Plasma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/H-uru/Plasma/merges","archive_url":"https://api.github.com/repos/H-uru/Plasma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/H-uru/Plasma/downloads","issues_url":"https://api.github.com/repos/H-uru/Plasma/issues{/number}","pulls_url":"https://api.github.com/repos/H-uru/Plasma/pulls{/number}","milestones_url":"https://api.github.com/repos/H-uru/Plasma/milestones{/number}","notifications_url":"https://api.github.com/repos/H-uru/Plasma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/H-uru/Plasma/labels{/name}","releases_url":"https://api.github.com/repos/H-uru/Plasma/releases{/id}","created_at":"2011-04-06T23:41:12Z","updated_at":"2014-08-07T11:10:44Z","pushed_at":"2014-08-09T19:25:17Z","git_url":"git://github.com/H-uru/Plasma.git","ssh_url":"git@github.com:H-uru/Plasma.git","clone_url":"https://github.com/H-uru/Plasma.git","svn_url":"https://github.com/H-uru/Plasma","homepage":"","size":41791,"stargazers_count":72,"watchers_count":72,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":40,"forks":29,"open_issues":40,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/H-uru/Plasma/pulls/452"},"html":{"href":"https://github.com/H-uru/Plasma/pull/452"},"issue":{"href":"https://api.github.com/repos/H-uru/Plasma/issues/452"},"comments":{"href":"https://api.github.com/repos/H-uru/Plasma/issues/452/comments"},"review_comments":{"href":"https://api.github.com/repos/H-uru/Plasma/pulls/452/comments"},"review_comment":{"href":"https://api.github.com/repos/H-uru/Plasma/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/H-uru/Plasma/pulls/452/commits"},"statuses":{"href":"https://api.github.com/repos/H-uru/Plasma/statuses/7d0c73eda3f2cb6efb6f96f2762e6bd812df9300"}}}}