GitHub PullRequestEvent at 2014-06-26 13:47:50
Repository: fxos-certsuite
Actor: dminor
Payload: {"action":"opened","number":134,"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/pulls/134","id":17648684,"html_url":"https://github.com/mozilla-b2g/fxos-certsuite/pull/134","diff_url":"https://github.com/mozilla-b2g/fxos-certsuite/pull/134.diff","patch_url":"https://github.com/mozilla-b2g/fxos-certsuite/pull/134.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/issues/134","number":134,"state":"open","title":"Fix permissions tests","user":{"login":"dminor","id":273932,"avatar_url":"https://avatars.githubusercontent.com/u/273932?","gravatar_id":"1ddb38853c9929f0b24595101523abe1","url":"https://api.github.com/users/dminor","html_url":"https://github.com/dminor","followers_url":"https://api.github.com/users/dminor/followers","following_url":"https://api.github.com/users/dminor/following{/other_user}","gists_url":"https://api.github.com/users/dminor/gists{/gist_id}","starred_url":"https://api.github.com/users/dminor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dminor/subscriptions","organizations_url":"https://api.github.com/users/dminor/orgs","repos_url":"https://api.github.com/users/dminor/repos","events_url":"https://api.github.com/users/dminor/events{/privacy}","received_events_url":"https://api.github.com/users/dminor/received_events","type":"User","site_admin":false},"body":"This moves to getting a list of permissions from the device and using that to test rather than using hand written tests for each permission.\r\n\r\nUsing PermissionSettingsModule.addPermission() bypasses PermissionsTable.jsm checks for app type, so it doesn't make sense to test the affect of setting the permissions to 'allow' for each app type. Instead, I'm using getPermission to read the default values for each permission for each app type, but only running addPermission once for each permission.","created_at":"2014-06-26T13:47:50Z","updated_at":"2014-06-26T13:47:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/pulls/134/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/pulls/134/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/issues/134/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/statuses/d7aa0990fd6afb249d4c8abb7eff8e27f775c280","head":{"label":"dminor:fix-permissions-tests","ref":"fix-permissions-tests","sha":"d7aa0990fd6afb249d4c8abb7eff8e27f775c280","user":{"login":"dminor","id":273932,"avatar_url":"https://avatars.githubusercontent.com/u/273932?","gravatar_id":"1ddb38853c9929f0b24595101523abe1","url":"https://api.github.com/users/dminor","html_url":"https://github.com/dminor","followers_url":"https://api.github.com/users/dminor/followers","following_url":"https://api.github.com/users/dminor/following{/other_user}","gists_url":"https://api.github.com/users/dminor/gists{/gist_id}","starred_url":"https://api.github.com/users/dminor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dminor/subscriptions","organizations_url":"https://api.github.com/users/dminor/orgs","repos_url":"https://api.github.com/users/dminor/repos","events_url":"https://api.github.com/users/dminor/events{/privacy}","received_events_url":"https://api.github.com/users/dminor/received_events","type":"User","site_admin":false},"repo":{"id":17415016,"name":"fxos-certsuite","full_name":"dminor/fxos-certsuite","owner":{"login":"dminor","id":273932,"avatar_url":"https://avatars.githubusercontent.com/u/273932?","gravatar_id":"1ddb38853c9929f0b24595101523abe1","url":"https://api.github.com/users/dminor","html_url":"https://github.com/dminor","followers_url":"https://api.github.com/users/dminor/followers","following_url":"https://api.github.com/users/dminor/following{/other_user}","gists_url":"https://api.github.com/users/dminor/gists{/gist_id}","starred_url":"https://api.github.com/users/dminor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dminor/subscriptions","organizations_url":"https://api.github.com/users/dminor/orgs","repos_url":"https://api.github.com/users/dminor/repos","events_url":"https://api.github.com/users/dminor/events{/privacy}","received_events_url":"https://api.github.com/users/dminor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dminor/fxos-certsuite","description":"","fork":true,"url":"https://api.github.com/repos/dminor/fxos-certsuite","forks_url":"https://api.github.com/repos/dminor/fxos-certsuite/forks","keys_url":"https://api.github.com/repos/dminor/fxos-certsuite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dminor/fxos-certsuite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dminor/fxos-certsuite/teams","hooks_url":"https://api.github.com/repos/dminor/fxos-certsuite/hooks","issue_events_url":"https://api.github.com/repos/dminor/fxos-certsuite/issues/events{/number}","events_url":"https://api.github.com/repos/dminor/fxos-certsuite/events","assignees_url":"https://api.github.com/repos/dminor/fxos-certsuite/assignees{/user}","branches_url":"https://api.github.com/repos/dminor/fxos-certsuite/branches{/branch}","tags_url":"https://api.github.com/repos/dminor/fxos-certsuite/tags","blobs_url":"https://api.github.com/repos/dminor/fxos-certsuite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dminor/fxos-certsuite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dminor/fxos-certsuite/git/refs{/sha}","trees_url":"https://api.github.com/repos/dminor/fxos-certsuite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dminor/fxos-certsuite/statuses/{sha}","languages_url":"https://api.github.com/repos/dminor/fxos-certsuite/languages","stargazers_url":"https://api.github.com/repos/dminor/fxos-certsuite/stargazers","contributors_url":"https://api.github.com/repos/dminor/fxos-certsuite/contributors","subscribers_url":"https://api.github.com/repos/dminor/fxos-certsuite/subscribers","subscription_url":"https://api.github.com/repos/dminor/fxos-certsuite/subscription","commits_url":"https://api.github.com/repos/dminor/fxos-certsuite/commits{/sha}","git_commits_url":"https://api.github.com/repos/dminor/fxos-certsuite/git/commits{/sha}","comments_url":"https://api.github.com/repos/dminor/fxos-certsuite/comments{/number}","issue_comment_url":"https://api.github.com/repos/dminor/fxos-certsuite/issues/comments/{number}","contents_url":"https://api.github.com/repos/dminor/fxos-certsuite/contents/{+path}","compare_url":"https://api.github.com/repos/dminor/fxos-certsuite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dminor/fxos-certsuite/merges","archive_url":"https://api.github.com/repos/dminor/fxos-certsuite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dminor/fxos-certsuite/downloads","issues_url":"https://api.github.com/repos/dminor/fxos-certsuite/issues{/number}","pulls_url":"https://api.github.com/repos/dminor/fxos-certsuite/pulls{/number}","milestones_url":"https://api.github.com/repos/dminor/fxos-certsuite/milestones{/number}","notifications_url":"https://api.github.com/repos/dminor/fxos-certsuite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dminor/fxos-certsuite/labels{/name}","releases_url":"https://api.github.com/repos/dminor/fxos-certsuite/releases{/id}","created_at":"2014-03-04T19:58:31Z","updated_at":"2014-06-20T22:01:15Z","pushed_at":"2014-06-26T13:27:14Z","git_url":"git://github.com/dminor/fxos-certsuite.git","ssh_url":"git@github.com:dminor/fxos-certsuite.git","clone_url":"https://github.com/dminor/fxos-certsuite.git","svn_url":"https://github.com/dminor/fxos-certsuite","homepage":null,"size":18907,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"20f6d56f4ae8cd0271fd022f66ab2fbc7a24bb0a","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":16845981,"name":"fxos-certsuite","full_name":"mozilla-b2g/fxos-certsuite","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/fxos-certsuite","description":"Tests and tools to verify the functionality and characteristics of Firefox OS on real devices.","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite","forks_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/releases{/id}","created_at":"2014-02-14T18:38:23Z","updated_at":"2014-06-25T14:20:46Z","pushed_at":"2014-06-26T12:38:16Z","git_url":"git://github.com/mozilla-b2g/fxos-certsuite.git","ssh_url":"git@github.com:mozilla-b2g/fxos-certsuite.git","clone_url":"https://github.com/mozilla-b2g/fxos-certsuite.git","svn_url":"https://github.com/mozilla-b2g/fxos-certsuite","homepage":"","size":22299,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/pulls/134"},"html":{"href":"https://github.com/mozilla-b2g/fxos-certsuite/pull/134"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/issues/134"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/fxos-certsuite/statuses/d7aa0990fd6afb249d4c8abb7eff8e27f775c280"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":1181,"deletions":1728,"changed_files":16}}