GitHub PullRequestReviewCommentEvent at 2014-11-18 12:12:05
Repository: HPCC-Platform
Actor: richardkchapman
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/20501214","id":20501214,"diff_hunk":"@@ -814,6 +840,41 @@ class RoxieListener : public Thread, implements IRoxieListener, implements IThre\n         info.append(\"</ACCESSINFO>\\n\");\n     }\n \n+    void setAffinity(int numCores)\n+    {\n+#ifndef _WIN32\n+        if (numCores > 0)","path":"roxie/ccd/ccdlistener.cpp","position":47,"original_position":47,"commit_id":"3db551a9dde3f5e9ec90e1340c01df5deb46384f","original_commit_id":"3db551a9dde3f5e9ec90e1340c01df5deb46384f","user":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"body":"I could, but I coded it in such a way that it will work correctly if you request more cores than are available.","created_at":"2014-11-18T12:12:05Z","updated_at":"2014-11-18T12:12:05Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6655#discussion_r20501214","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6655","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/20501214"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/6655#discussion_r20501214"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6655"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6655","id":24552438,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6655","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6655.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6655.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6655","number":6655,"state":"open","locked":false,"title":"HPCC-12599 Option in Roxie to bind queries to cores","user":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"body":"Set coresPerQuery in RoxieTopology.xml or bindCores in workunit\r\ndebug values ir in query XML to indicate that execution of this\r\nquery should be bould to at most N cores out of the ones that\r\nthe Roxie process itself is bould to.\r\n\r\nSigned-off-by: Richard Chapman <rchapman@hpccsystems.com>","created_at":"2014-11-17T17:37:12Z","updated_at":"2014-11-18T12:12:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f96b482e0c9f1aee7f505d1a5f7dec19de0328f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6655/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6655/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6655/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/3db551a9dde3f5e9ec90e1340c01df5deb46384f","head":{"label":"richardkchapman:roxie-affinity","ref":"roxie-affinity","sha":"3db551a9dde3f5e9ec90e1340c01df5deb46384f","user":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"repo":{"id":2031005,"name":"HPCC-Platform","full_name":"richardkchapman/HPCC-Platform","owner":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richardkchapman/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/richardkchapman/HPCC-Platform","forks_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/releases{/id}","created_at":"2011-07-11T15:22:03Z","updated_at":"2014-07-01T10:03:54Z","pushed_at":"2014-11-18T10:30:09Z","git_url":"git://github.com/richardkchapman/HPCC-Platform.git","ssh_url":"git@github.com:richardkchapman/HPCC-Platform.git","clone_url":"https://github.com/richardkchapman/HPCC-Platform.git","svn_url":"https://github.com/richardkchapman/HPCC-Platform","homepage":"www.hpccsystems.com","size":133786,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"240d601d86fb8f30fbd02aed8f623954556fbb4a","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2014-11-18T09:42:51Z","pushed_at":"2014-11-18T12:02:58Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":272039,"stargazers_count":236,"watchers_count":236,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":427,"forks":94,"open_issues":427,"watchers":236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6655"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/6655"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6655"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6655/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6655/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6655/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/3db551a9dde3f5e9ec90e1340c01df5deb46384f"}}}}