GitHub PullRequestReviewCommentEvent at 2014-06-25 16:48:50
Repository: deploy
Actor: philwills
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/deploy/pulls/comments/14198077","id":14198077,"diff_hunk":"@@ -328,7 +322,7 @@ object TeamCity {\n \n     object build {\n       def detail(buildLocator: BuildLocator) = TeamCityWS.url(\"/app/rest/builds/%s\" format buildLocator)\n-      def list(buildLocator: BuildLocator) = TeamCityWS.url(\"/app/rest/builds/?locator=%s\" format buildLocator)\n+      def list(buildLocator: BuildLocator) = TeamCityWS.url(s\"/app/rest/builds/?locator=$buildLocator&fields=build(id,number,status,startDate,branchName,buildTypeId,webUrl)\")","path":"riff-raff/app/ci/teamcity/teamcity.scala","position":39,"original_position":39,"commit_id":"775644067213fb98dc05f14e6fe7e45597112c48","original_commit_id":"775644067213fb98dc05f14e6fe7e45597112c48","user":{"login":"philwills","id":68329,"avatar_url":"https://avatars.githubusercontent.com/u/68329?","gravatar_id":"13d76c620e5b3defa9637a31bcce3a65","url":"https://api.github.com/users/philwills","html_url":"https://github.com/philwills","followers_url":"https://api.github.com/users/philwills/followers","following_url":"https://api.github.com/users/philwills/following{/other_user}","gists_url":"https://api.github.com/users/philwills/gists{/gist_id}","starred_url":"https://api.github.com/users/philwills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwills/subscriptions","organizations_url":"https://api.github.com/users/philwills/orgs","repos_url":"https://api.github.com/users/philwills/repos","events_url":"https://api.github.com/users/philwills/events{/privacy}","received_events_url":"https://api.github.com/users/philwills/received_events","type":"User","site_admin":false},"body":"It's magic Scala 2.10+ string templating.  Instead of saying `format buildLocator`, you just use $ to reference the value.","created_at":"2014-06-25T16:48:50Z","updated_at":"2014-06-25T16:48:50Z","html_url":"https://github.com/guardian/deploy/pull/183#discussion_r14198077","pull_request_url":"https://api.github.com/repos/guardian/deploy/pulls/183","_links":{"self":{"href":"https://api.github.com/repos/guardian/deploy/pulls/comments/14198077"},"html":{"href":"https://github.com/guardian/deploy/pull/183#discussion_r14198077"},"pull_request":{"href":"https://api.github.com/repos/guardian/deploy/pulls/183"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/deploy/pulls/183","id":17599744,"html_url":"https://github.com/guardian/deploy/pull/183","diff_url":"https://github.com/guardian/deploy/pull/183.diff","patch_url":"https://github.com/guardian/deploy/pull/183.patch","issue_url":"https://api.github.com/repos/guardian/deploy/issues/183","number":183,"state":"open","title":"Update to work with Teamcity 8","user":{"login":"philwills","id":68329,"avatar_url":"https://avatars.githubusercontent.com/u/68329?","gravatar_id":"13d76c620e5b3defa9637a31bcce3a65","url":"https://api.github.com/users/philwills","html_url":"https://github.com/philwills","followers_url":"https://api.github.com/users/philwills/followers","following_url":"https://api.github.com/users/philwills/following{/other_user}","gists_url":"https://api.github.com/users/philwills/gists{/gist_id}","starred_url":"https://api.github.com/users/philwills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwills/subscriptions","organizations_url":"https://api.github.com/users/philwills/orgs","repos_url":"https://api.github.com/users/philwills/repos","events_url":"https://api.github.com/users/philwills/events{/privacy}","received_events_url":"https://api.github.com/users/philwills/received_events","type":"User","site_admin":false},"body":"Unfortunately, have to rely on the 'experimental' fields parameter (http://youtrack.jetbrains.com/issue/TW-26176)\r\n\r\nObviously best not to merge until we actually have TC 8.","created_at":"2014-06-25T16:03:43Z","updated_at":"2014-06-25T16:48:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef3e03a966c4153f470b03f1023ddd84eef9cadd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/deploy/pulls/183/commits","review_comments_url":"https://api.github.com/repos/guardian/deploy/pulls/183/comments","review_comment_url":"https://api.github.com/repos/guardian/deploy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/deploy/issues/183/comments","statuses_url":"https://api.github.com/repos/guardian/deploy/statuses/775644067213fb98dc05f14e6fe7e45597112c48","head":{"label":"guardian:pw-teamcity-8","ref":"pw-teamcity-8","sha":"775644067213fb98dc05f14e6fe7e45597112c48","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":2233038,"name":"deploy","full_name":"guardian/deploy","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/deploy","description":"Guardian deployment libraries and RiffRaff frontend","fork":false,"url":"https://api.github.com/repos/guardian/deploy","forks_url":"https://api.github.com/repos/guardian/deploy/forks","keys_url":"https://api.github.com/repos/guardian/deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/deploy/teams","hooks_url":"https://api.github.com/repos/guardian/deploy/hooks","issue_events_url":"https://api.github.com/repos/guardian/deploy/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/deploy/events","assignees_url":"https://api.github.com/repos/guardian/deploy/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/deploy/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/deploy/tags","blobs_url":"https://api.github.com/repos/guardian/deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/deploy/languages","stargazers_url":"https://api.github.com/repos/guardian/deploy/stargazers","contributors_url":"https://api.github.com/repos/guardian/deploy/contributors","subscribers_url":"https://api.github.com/repos/guardian/deploy/subscribers","subscription_url":"https://api.github.com/repos/guardian/deploy/subscription","commits_url":"https://api.github.com/repos/guardian/deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/deploy/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/deploy/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/deploy/merges","archive_url":"https://api.github.com/repos/guardian/deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/deploy/downloads","issues_url":"https://api.github.com/repos/guardian/deploy/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/deploy/labels{/name}","releases_url":"https://api.github.com/repos/guardian/deploy/releases{/id}","created_at":"2011-08-19T09:05:26Z","updated_at":"2014-06-18T15:52:19Z","pushed_at":"2014-06-25T16:03:29Z","git_url":"git://github.com/guardian/deploy.git","ssh_url":"git@github.com:guardian/deploy.git","clone_url":"https://github.com/guardian/deploy.git","svn_url":"https://github.com/guardian/deploy","homepage":"","size":12204,"stargazers_count":48,"watchers_count":48,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":18,"forks":5,"open_issues":18,"watchers":48,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"f859a23991e7ca4a0d7e210d85b2a82e10467fd8","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":2233038,"name":"deploy","full_name":"guardian/deploy","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/deploy","description":"Guardian deployment libraries and RiffRaff frontend","fork":false,"url":"https://api.github.com/repos/guardian/deploy","forks_url":"https://api.github.com/repos/guardian/deploy/forks","keys_url":"https://api.github.com/repos/guardian/deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/deploy/teams","hooks_url":"https://api.github.com/repos/guardian/deploy/hooks","issue_events_url":"https://api.github.com/repos/guardian/deploy/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/deploy/events","assignees_url":"https://api.github.com/repos/guardian/deploy/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/deploy/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/deploy/tags","blobs_url":"https://api.github.com/repos/guardian/deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/deploy/languages","stargazers_url":"https://api.github.com/repos/guardian/deploy/stargazers","contributors_url":"https://api.github.com/repos/guardian/deploy/contributors","subscribers_url":"https://api.github.com/repos/guardian/deploy/subscribers","subscription_url":"https://api.github.com/repos/guardian/deploy/subscription","commits_url":"https://api.github.com/repos/guardian/deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/deploy/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/deploy/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/deploy/merges","archive_url":"https://api.github.com/repos/guardian/deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/deploy/downloads","issues_url":"https://api.github.com/repos/guardian/deploy/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/deploy/labels{/name}","releases_url":"https://api.github.com/repos/guardian/deploy/releases{/id}","created_at":"2011-08-19T09:05:26Z","updated_at":"2014-06-18T15:52:19Z","pushed_at":"2014-06-25T16:03:29Z","git_url":"git://github.com/guardian/deploy.git","ssh_url":"git@github.com:guardian/deploy.git","clone_url":"https://github.com/guardian/deploy.git","svn_url":"https://github.com/guardian/deploy","homepage":"","size":12204,"stargazers_count":48,"watchers_count":48,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":18,"forks":5,"open_issues":18,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/deploy/pulls/183"},"html":{"href":"https://github.com/guardian/deploy/pull/183"},"issue":{"href":"https://api.github.com/repos/guardian/deploy/issues/183"},"comments":{"href":"https://api.github.com/repos/guardian/deploy/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/deploy/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/deploy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/deploy/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/deploy/statuses/775644067213fb98dc05f14e6fe7e45597112c48"}}}}