GitHub PullRequestReviewCommentEvent at 2014-12-26 17:32:39
Repository: lobby
Actor: Frozen-byte
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/FAForever/lobby/pulls/comments/22285908","id":22285908,"diff_hunk":"@@ -27,6 +28,12 @@\n def developer():\r\n     return sys.executable.endswith(\"python.exe\")\r\n \r\n+def isWindows():\r\n+    if platform.system() == \"Windows\":\r\n+        return True\r\n+    else:\r\n+        return False\r\n+\r\n try:\r","path":"src/util/__init__.py","position":18,"original_position":18,"commit_id":"3701ba8071b9b9d0ef2ba5b754982fe68d8dd20e","original_commit_id":"3701ba8071b9b9d0ef2ba5b754982fe68d8dd20e","user":{"login":"Frozen-byte","id":3965439,"avatar_url":"https://avatars.githubusercontent.com/u/3965439?v=3","gravatar_id":"","url":"https://api.github.com/users/Frozen-byte","html_url":"https://github.com/Frozen-byte","followers_url":"https://api.github.com/users/Frozen-byte/followers","following_url":"https://api.github.com/users/Frozen-byte/following{/other_user}","gists_url":"https://api.github.com/users/Frozen-byte/gists{/gist_id}","starred_url":"https://api.github.com/users/Frozen-byte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frozen-byte/subscriptions","organizations_url":"https://api.github.com/users/Frozen-byte/orgs","repos_url":"https://api.github.com/users/Frozen-byte/repos","events_url":"https://api.github.com/users/Frozen-byte/events{/privacy}","received_events_url":"https://api.github.com/users/Frozen-byte/received_events","type":"User","site_admin":false},"body":"Well, this should be noted into the Comment-Header. I did not realized that this file is deprecated. Where is the new file for general custom functions?","created_at":"2014-12-26T17:32:39Z","updated_at":"2014-12-26T17:32:39Z","html_url":"https://github.com/FAForever/lobby/pull/156#discussion_r22285908","pull_request_url":"https://api.github.com/repos/FAForever/lobby/pulls/156","_links":{"self":{"href":"https://api.github.com/repos/FAForever/lobby/pulls/comments/22285908"},"html":{"href":"https://github.com/FAForever/lobby/pull/156#discussion_r22285908"},"pull_request":{"href":"https://api.github.com/repos/FAForever/lobby/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/FAForever/lobby/pulls/156","id":26222297,"html_url":"https://github.com/FAForever/lobby/pull/156","diff_url":"https://github.com/FAForever/lobby/pull/156.diff","patch_url":"https://github.com/FAForever/lobby/pull/156.patch","issue_url":"https://api.github.com/repos/FAForever/lobby/issues/156","number":156,"state":"open","locked":false,"title":"Integrate Linux support for Lobby","user":{"login":"Frozen-byte","id":3965439,"avatar_url":"https://avatars.githubusercontent.com/u/3965439?v=3","gravatar_id":"","url":"https://api.github.com/users/Frozen-byte","html_url":"https://github.com/Frozen-byte","followers_url":"https://api.github.com/users/Frozen-byte/followers","following_url":"https://api.github.com/users/Frozen-byte/following{/other_user}","gists_url":"https://api.github.com/users/Frozen-byte/gists{/gist_id}","starred_url":"https://api.github.com/users/Frozen-byte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frozen-byte/subscriptions","organizations_url":"https://api.github.com/users/Frozen-byte/orgs","repos_url":"https://api.github.com/users/Frozen-byte/repos","events_url":"https://api.github.com/users/Frozen-byte/events{/privacy}","received_events_url":"https://api.github.com/users/Frozen-byte/received_events","type":"User","site_admin":false},"body":"The changes I've made so far to get the Lobby running.\r\nCurrently the game is not startable but Client is made functional.","created_at":"2014-12-17T13:02:48Z","updated_at":"2014-12-26T17:32:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d01ed83201f7966e80a5453e986219092bb841a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FAForever/lobby/pulls/156/commits","review_comments_url":"https://api.github.com/repos/FAForever/lobby/pulls/156/comments","review_comment_url":"https://api.github.com/repos/FAForever/lobby/pulls/comments/{number}","comments_url":"https://api.github.com/repos/FAForever/lobby/issues/156/comments","statuses_url":"https://api.github.com/repos/FAForever/lobby/statuses/3701ba8071b9b9d0ef2ba5b754982fe68d8dd20e","head":{"label":"Frozen-byte:develop","ref":"develop","sha":"3701ba8071b9b9d0ef2ba5b754982fe68d8dd20e","user":{"login":"Frozen-byte","id":3965439,"avatar_url":"https://avatars.githubusercontent.com/u/3965439?v=3","gravatar_id":"","url":"https://api.github.com/users/Frozen-byte","html_url":"https://github.com/Frozen-byte","followers_url":"https://api.github.com/users/Frozen-byte/followers","following_url":"https://api.github.com/users/Frozen-byte/following{/other_user}","gists_url":"https://api.github.com/users/Frozen-byte/gists{/gist_id}","starred_url":"https://api.github.com/users/Frozen-byte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frozen-byte/subscriptions","organizations_url":"https://api.github.com/users/Frozen-byte/orgs","repos_url":"https://api.github.com/users/Frozen-byte/repos","events_url":"https://api.github.com/users/Frozen-byte/events{/privacy}","received_events_url":"https://api.github.com/users/Frozen-byte/received_events","type":"User","site_admin":false},"repo":{"id":28008174,"name":"lobby","full_name":"Frozen-byte/lobby","owner":{"login":"Frozen-byte","id":3965439,"avatar_url":"https://avatars.githubusercontent.com/u/3965439?v=3","gravatar_id":"","url":"https://api.github.com/users/Frozen-byte","html_url":"https://github.com/Frozen-byte","followers_url":"https://api.github.com/users/Frozen-byte/followers","following_url":"https://api.github.com/users/Frozen-byte/following{/other_user}","gists_url":"https://api.github.com/users/Frozen-byte/gists{/gist_id}","starred_url":"https://api.github.com/users/Frozen-byte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frozen-byte/subscriptions","organizations_url":"https://api.github.com/users/Frozen-byte/orgs","repos_url":"https://api.github.com/users/Frozen-byte/repos","events_url":"https://api.github.com/users/Frozen-byte/events{/privacy}","received_events_url":"https://api.github.com/users/Frozen-byte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Frozen-byte/lobby","description":"FAF Python Client","fork":true,"url":"https://api.github.com/repos/Frozen-byte/lobby","forks_url":"https://api.github.com/repos/Frozen-byte/lobby/forks","keys_url":"https://api.github.com/repos/Frozen-byte/lobby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Frozen-byte/lobby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Frozen-byte/lobby/teams","hooks_url":"https://api.github.com/repos/Frozen-byte/lobby/hooks","issue_events_url":"https://api.github.com/repos/Frozen-byte/lobby/issues/events{/number}","events_url":"https://api.github.com/repos/Frozen-byte/lobby/events","assignees_url":"https://api.github.com/repos/Frozen-byte/lobby/assignees{/user}","branches_url":"https://api.github.com/repos/Frozen-byte/lobby/branches{/branch}","tags_url":"https://api.github.com/repos/Frozen-byte/lobby/tags","blobs_url":"https://api.github.com/repos/Frozen-byte/lobby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Frozen-byte/lobby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Frozen-byte/lobby/git/refs{/sha}","trees_url":"https://api.github.com/repos/Frozen-byte/lobby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Frozen-byte/lobby/statuses/{sha}","languages_url":"https://api.github.com/repos/Frozen-byte/lobby/languages","stargazers_url":"https://api.github.com/repos/Frozen-byte/lobby/stargazers","contributors_url":"https://api.github.com/repos/Frozen-byte/lobby/contributors","subscribers_url":"https://api.github.com/repos/Frozen-byte/lobby/subscribers","subscription_url":"https://api.github.com/repos/Frozen-byte/lobby/subscription","commits_url":"https://api.github.com/repos/Frozen-byte/lobby/commits{/sha}","git_commits_url":"https://api.github.com/repos/Frozen-byte/lobby/git/commits{/sha}","comments_url":"https://api.github.com/repos/Frozen-byte/lobby/comments{/number}","issue_comment_url":"https://api.github.com/repos/Frozen-byte/lobby/issues/comments/{number}","contents_url":"https://api.github.com/repos/Frozen-byte/lobby/contents/{+path}","compare_url":"https://api.github.com/repos/Frozen-byte/lobby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Frozen-byte/lobby/merges","archive_url":"https://api.github.com/repos/Frozen-byte/lobby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Frozen-byte/lobby/downloads","issues_url":"https://api.github.com/repos/Frozen-byte/lobby/issues{/number}","pulls_url":"https://api.github.com/repos/Frozen-byte/lobby/pulls{/number}","milestones_url":"https://api.github.com/repos/Frozen-byte/lobby/milestones{/number}","notifications_url":"https://api.github.com/repos/Frozen-byte/lobby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Frozen-byte/lobby/labels{/name}","releases_url":"https://api.github.com/repos/Frozen-byte/lobby/releases{/id}","created_at":"2014-12-14T21:10:56Z","updated_at":"2014-12-17T13:46:06Z","pushed_at":"2014-12-17T13:46:05Z","git_url":"git://github.com/Frozen-byte/lobby.git","ssh_url":"git@github.com:Frozen-byte/lobby.git","clone_url":"https://github.com/Frozen-byte/lobby.git","svn_url":"https://github.com/Frozen-byte/lobby","homepage":"","size":9116,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"FAForever:develop","ref":"develop","sha":"8ee0e8c4f5a42e0becd20b08de71c77261997d2c","user":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"repo":{"id":24400684,"name":"lobby","full_name":"FAForever/lobby","owner":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FAForever/lobby","description":"FAF Python Client","fork":false,"url":"https://api.github.com/repos/FAForever/lobby","forks_url":"https://api.github.com/repos/FAForever/lobby/forks","keys_url":"https://api.github.com/repos/FAForever/lobby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FAForever/lobby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FAForever/lobby/teams","hooks_url":"https://api.github.com/repos/FAForever/lobby/hooks","issue_events_url":"https://api.github.com/repos/FAForever/lobby/issues/events{/number}","events_url":"https://api.github.com/repos/FAForever/lobby/events","assignees_url":"https://api.github.com/repos/FAForever/lobby/assignees{/user}","branches_url":"https://api.github.com/repos/FAForever/lobby/branches{/branch}","tags_url":"https://api.github.com/repos/FAForever/lobby/tags","blobs_url":"https://api.github.com/repos/FAForever/lobby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FAForever/lobby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FAForever/lobby/git/refs{/sha}","trees_url":"https://api.github.com/repos/FAForever/lobby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FAForever/lobby/statuses/{sha}","languages_url":"https://api.github.com/repos/FAForever/lobby/languages","stargazers_url":"https://api.github.com/repos/FAForever/lobby/stargazers","contributors_url":"https://api.github.com/repos/FAForever/lobby/contributors","subscribers_url":"https://api.github.com/repos/FAForever/lobby/subscribers","subscription_url":"https://api.github.com/repos/FAForever/lobby/subscription","commits_url":"https://api.github.com/repos/FAForever/lobby/commits{/sha}","git_commits_url":"https://api.github.com/repos/FAForever/lobby/git/commits{/sha}","comments_url":"https://api.github.com/repos/FAForever/lobby/comments{/number}","issue_comment_url":"https://api.github.com/repos/FAForever/lobby/issues/comments/{number}","contents_url":"https://api.github.com/repos/FAForever/lobby/contents/{+path}","compare_url":"https://api.github.com/repos/FAForever/lobby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FAForever/lobby/merges","archive_url":"https://api.github.com/repos/FAForever/lobby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FAForever/lobby/downloads","issues_url":"https://api.github.com/repos/FAForever/lobby/issues{/number}","pulls_url":"https://api.github.com/repos/FAForever/lobby/pulls{/number}","milestones_url":"https://api.github.com/repos/FAForever/lobby/milestones{/number}","notifications_url":"https://api.github.com/repos/FAForever/lobby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FAForever/lobby/labels{/name}","releases_url":"https://api.github.com/repos/FAForever/lobby/releases{/id}","created_at":"2014-09-24T04:25:57Z","updated_at":"2014-12-26T15:53:12Z","pushed_at":"2014-12-26T15:53:11Z","git_url":"git://github.com/FAForever/lobby.git","ssh_url":"git@github.com:FAForever/lobby.git","clone_url":"https://github.com/FAForever/lobby.git","svn_url":"https://github.com/FAForever/lobby","homepage":"","size":10141,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":73,"forks":14,"open_issues":73,"watchers":13,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/FAForever/lobby/pulls/156"},"html":{"href":"https://github.com/FAForever/lobby/pull/156"},"issue":{"href":"https://api.github.com/repos/FAForever/lobby/issues/156"},"comments":{"href":"https://api.github.com/repos/FAForever/lobby/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/FAForever/lobby/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/FAForever/lobby/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/FAForever/lobby/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/FAForever/lobby/statuses/3701ba8071b9b9d0ef2ba5b754982fe68d8dd20e"}}}}