GitHub PullRequestEvent at 2014-04-07 02:10:44
Repository: backbone.layoutmanager
Actor: STRML
Payload: {"action":"opened","number":438,"pull_request":{"url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/pulls/438","id":14430915,"html_url":"https://github.com/tbranyen/backbone.layoutmanager/pull/438","diff_url":"https://github.com/tbranyen/backbone.layoutmanager/pull/438.diff","patch_url":"https://github.com/tbranyen/backbone.layoutmanager/pull/438.patch","issue_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/issues/438","number":438,"state":"open","title":"Added browserify test & build task, updated UMD definition.","user":{"login":"STRML","id":1197375,"avatar_url":"https://avatars.githubusercontent.com/u/1197375?","gravatar_id":"836f2e9873e81dadef104376e52207d2","url":"https://api.github.com/users/STRML","html_url":"https://github.com/STRML","followers_url":"https://api.github.com/users/STRML/followers","following_url":"https://api.github.com/users/STRML/following{/other_user}","gists_url":"https://api.github.com/users/STRML/gists{/gist_id}","starred_url":"https://api.github.com/users/STRML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STRML/subscriptions","organizations_url":"https://api.github.com/users/STRML/orgs","repos_url":"https://api.github.com/users/STRML/repos","events_url":"https://api.github.com/users/STRML/events{/privacy}","received_events_url":"https://api.github.com/users/STRML/received_events","type":"User","site_admin":false},"body":"The UMD definition in #436 was close but had an issue with [L11](https://github.com/tbranyen/backbone.layoutmanager/commit/ca5a3edf0397738058e6d3194461740832ec4b33#diff-ba55fcfab2e1723ff437c1eec10d55e4R11). This line could actually be stricken as the var was never used.\r\n\r\nThis PR cleans up the UMD definition, moving the browser definition into the `else` block. Additionally, I removed the explicit bind to `window.Backbone.Layout`, as it is already exported on [L834](https://github.com/tbranyen/backbone.layoutmanager/blob/ca5a3edf0397738058e6d3194461740832ec4b33/backbone.layoutmanager.js#L834).\r\n\r\nThis PR also adds a browserify build task and a basic test to ensure template rendering works with the browserified build.","created_at":"2014-04-07T02:10:44Z","updated_at":"2014-04-07T02:10:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/pulls/438/commits","review_comments_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/pulls/438/comments","review_comment_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/issues/438/comments","statuses_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/statuses/1bb1b3f941ac04e7f0a9e2630dc39d1f6c623fef","head":{"label":"STRML:browserify","ref":"browserify","sha":"1bb1b3f941ac04e7f0a9e2630dc39d1f6c623fef","user":{"login":"STRML","id":1197375,"avatar_url":"https://avatars.githubusercontent.com/u/1197375?","gravatar_id":"836f2e9873e81dadef104376e52207d2","url":"https://api.github.com/users/STRML","html_url":"https://github.com/STRML","followers_url":"https://api.github.com/users/STRML/followers","following_url":"https://api.github.com/users/STRML/following{/other_user}","gists_url":"https://api.github.com/users/STRML/gists{/gist_id}","starred_url":"https://api.github.com/users/STRML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STRML/subscriptions","organizations_url":"https://api.github.com/users/STRML/orgs","repos_url":"https://api.github.com/users/STRML/repos","events_url":"https://api.github.com/users/STRML/events{/privacy}","received_events_url":"https://api.github.com/users/STRML/received_events","type":"User","site_admin":false},"repo":{"id":8130899,"name":"backbone.layoutmanager","full_name":"STRML/backbone.layoutmanager","owner":{"login":"STRML","id":1197375,"avatar_url":"https://avatars.githubusercontent.com/u/1197375?","gravatar_id":"836f2e9873e81dadef104376e52207d2","url":"https://api.github.com/users/STRML","html_url":"https://github.com/STRML","followers_url":"https://api.github.com/users/STRML/followers","following_url":"https://api.github.com/users/STRML/following{/other_user}","gists_url":"https://api.github.com/users/STRML/gists{/gist_id}","starred_url":"https://api.github.com/users/STRML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STRML/subscriptions","organizations_url":"https://api.github.com/users/STRML/orgs","repos_url":"https://api.github.com/users/STRML/repos","events_url":"https://api.github.com/users/STRML/events{/privacy}","received_events_url":"https://api.github.com/users/STRML/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/STRML/backbone.layoutmanager","description":"A layout and template manager for Backbone.js applications.","fork":true,"url":"https://api.github.com/repos/STRML/backbone.layoutmanager","forks_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/forks","keys_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/teams","hooks_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/hooks","issue_events_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/issues/events{/number}","events_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/events","assignees_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/assignees{/user}","branches_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/branches{/branch}","tags_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/tags","blobs_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/git/refs{/sha}","trees_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/statuses/{sha}","languages_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/languages","stargazers_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/stargazers","contributors_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/contributors","subscribers_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/subscribers","subscription_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/subscription","commits_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/commits{/sha}","git_commits_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/git/commits{/sha}","comments_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/comments{/number}","issue_comment_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/issues/comments/{number}","contents_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/contents/{+path}","compare_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/merges","archive_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/downloads","issues_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/issues{/number}","pulls_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/pulls{/number}","milestones_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/milestones{/number}","notifications_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/labels{/name}","releases_url":"https://api.github.com/repos/STRML/backbone.layoutmanager/releases{/id}","created_at":"2013-02-11T01:34:46Z","updated_at":"2014-04-07T02:10:44Z","pushed_at":"2014-04-07T02:09:28Z","git_url":"git://github.com/STRML/backbone.layoutmanager.git","ssh_url":"git@github.com:STRML/backbone.layoutmanager.git","clone_url":"https://github.com/STRML/backbone.layoutmanager.git","svn_url":"https://github.com/STRML/backbone.layoutmanager","homepage":"http://layoutmanager.org/","size":1733,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"tbranyen:master","ref":"master","sha":"ca5a3edf0397738058e6d3194461740832ec4b33","user":{"login":"tbranyen","id":181635,"avatar_url":"https://avatars.githubusercontent.com/u/181635?","gravatar_id":"21dbcdbf46f8ee3774c1b9b3efadfa9e","url":"https://api.github.com/users/tbranyen","html_url":"https://github.com/tbranyen","followers_url":"https://api.github.com/users/tbranyen/followers","following_url":"https://api.github.com/users/tbranyen/following{/other_user}","gists_url":"https://api.github.com/users/tbranyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tbranyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbranyen/subscriptions","organizations_url":"https://api.github.com/users/tbranyen/orgs","repos_url":"https://api.github.com/users/tbranyen/repos","events_url":"https://api.github.com/users/tbranyen/events{/privacy}","received_events_url":"https://api.github.com/users/tbranyen/received_events","type":"User","site_admin":false},"repo":{"id":2724003,"name":"backbone.layoutmanager","full_name":"tbranyen/backbone.layoutmanager","owner":{"login":"tbranyen","id":181635,"avatar_url":"https://avatars.githubusercontent.com/u/181635?","gravatar_id":"21dbcdbf46f8ee3774c1b9b3efadfa9e","url":"https://api.github.com/users/tbranyen","html_url":"https://github.com/tbranyen","followers_url":"https://api.github.com/users/tbranyen/followers","following_url":"https://api.github.com/users/tbranyen/following{/other_user}","gists_url":"https://api.github.com/users/tbranyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tbranyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbranyen/subscriptions","organizations_url":"https://api.github.com/users/tbranyen/orgs","repos_url":"https://api.github.com/users/tbranyen/repos","events_url":"https://api.github.com/users/tbranyen/events{/privacy}","received_events_url":"https://api.github.com/users/tbranyen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbranyen/backbone.layoutmanager","description":"A layout and template manager for Backbone.js applications.","fork":false,"url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager","forks_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/forks","keys_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/teams","hooks_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/hooks","issue_events_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/issues/events{/number}","events_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/events","assignees_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/assignees{/user}","branches_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/branches{/branch}","tags_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/tags","blobs_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/statuses/{sha}","languages_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/languages","stargazers_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/stargazers","contributors_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/contributors","subscribers_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/subscribers","subscription_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/subscription","commits_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/issues/comments/{number}","contents_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/contents/{+path}","compare_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/merges","archive_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/downloads","issues_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/issues{/number}","pulls_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/pulls{/number}","milestones_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/milestones{/number}","notifications_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/labels{/name}","releases_url":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/releases{/id}","created_at":"2011-11-07T03:48:13Z","updated_at":"2014-04-05T15:00:54Z","pushed_at":"2014-04-05T15:00:54Z","git_url":"git://github.com/tbranyen/backbone.layoutmanager.git","ssh_url":"git@github.com:tbranyen/backbone.layoutmanager.git","clone_url":"https://github.com/tbranyen/backbone.layoutmanager.git","svn_url":"https://github.com/tbranyen/backbone.layoutmanager","homepage":"http://layoutmanager.org/","size":5997,"stargazers_count":1567,"watchers_count":1567,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":172,"mirror_url":null,"open_issues_count":16,"forks":172,"open_issues":16,"watchers":1567,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/pulls/438"},"html":{"href":"https://github.com/tbranyen/backbone.layoutmanager/pull/438"},"issue":{"href":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/issues/438"},"comments":{"href":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/tbranyen/backbone.layoutmanager/statuses/1bb1b3f941ac04e7f0a9e2630dc39d1f6c623fef"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":83,"deletions":12,"changed_files":8}}