GitHub PullRequestReviewCommentEvent at 2014-05-15 13:22:41
Repository: biom-format
Actor: adamrp
Payload: {"comment":{"url":"https://api.github.com/repos/biocore/biom-format/pulls/comments/12688159","id":12688159,"diff_hunk":"@@ -1006,7 +1006,7 @@ def filter(self, ids_to_keep, axis='sample', invert=False, inplace=True):\n \n         Parameters\n         ----------\n-        ids_to_keep : function(id, metadata, values) -> bool, or iterable\n+        ids_to_keep : function(values, id, metadata) -> bool, or iterable","path":"biom/table.py","position":5,"original_position":5,"commit_id":"669e221c8698a2e7dfb0f03f6c8ccc92bf850c7f","original_commit_id":"669e221c8698a2e7dfb0f03f6c8ccc92bf850c7f","user":{"login":"adamrp","id":2574407,"avatar_url":"https://avatars.githubusercontent.com/u/2574407?","gravatar_id":"f02990b66a519545b89fb0357d4b4bda","url":"https://api.github.com/users/adamrp","html_url":"https://github.com/adamrp","followers_url":"https://api.github.com/users/adamrp/followers","following_url":"https://api.github.com/users/adamrp/following{/other_user}","gists_url":"https://api.github.com/users/adamrp/gists{/gist_id}","starred_url":"https://api.github.com/users/adamrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamrp/subscriptions","organizations_url":"https://api.github.com/users/adamrp/orgs","repos_url":"https://api.github.com/users/adamrp/repos","events_url":"https://api.github.com/users/adamrp/events{/privacy}","received_events_url":"https://api.github.com/users/adamrp/received_events","type":"User","site_admin":false},"body":"Why did we switch the order of these parameters?","created_at":"2014-05-15T13:22:41Z","updated_at":"2014-05-15T13:22:41Z","html_url":"https://github.com/biocore/biom-format/pull/402#discussion_r12688159","pull_request_url":"https://api.github.com/repos/biocore/biom-format/pulls/402","_links":{"self":{"href":"https://api.github.com/repos/biocore/biom-format/pulls/comments/12688159"},"html":{"href":"https://github.com/biocore/biom-format/pull/402#discussion_r12688159"},"pull_request":{"href":"https://api.github.com/repos/biocore/biom-format/pulls/402"}}}}