GitHub PullRequestReviewCommentEvent at 2014-12-22 14:01:26
Repository: izettle-toolbox
Actor: adamvoncorswant
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/comments/22166816","id":22166816,"diff_hunk":"@@ -0,0 +1,22 @@\n+package com.izettle.java.uuid.uuid1;\n+\n+import static com.izettle.java.uuid.uuid1.UUID1Generator.*;\n+import static com.izettle.java.uuid.uuid1.UUID1Generator.CLOCK_OFFSET;\n+\n+import java.util.Date;\n+import java.util.UUID;\n+\n+public final class UUID1Utils {\n+\n+\tprivate UUID1Utils() {\n+\t}\n+\n+\t/**\n+\t * Extracts a UUID timestamp and returns it as a Date.\n+\t * @param uuid1 The UUID to extract from.\n+\t * @return The extracted date.\n+\t */\n+\tpublic static Date getDateFromUUID1(UUID uuid1) {\n+\t\treturn new Date((uuid1.timestamp() - CLOCK_OFFSET) / CLOCK_MULTIPLIER);","path":"izettle-java/src/main/java/com/izettle/java/uuid/uuid1/UUID1Utils.java","position":20,"original_position":20,"commit_id":"4dfabadf3a8032b904895ff4665cc2bb1d54cb56","original_commit_id":"4dfabadf3a8032b904895ff4665cc2bb1d54cb56","user":{"login":"adamvoncorswant","id":1142587,"avatar_url":"https://avatars.githubusercontent.com/u/1142587?v=3","gravatar_id":"","url":"https://api.github.com/users/adamvoncorswant","html_url":"https://github.com/adamvoncorswant","followers_url":"https://api.github.com/users/adamvoncorswant/followers","following_url":"https://api.github.com/users/adamvoncorswant/following{/other_user}","gists_url":"https://api.github.com/users/adamvoncorswant/gists{/gist_id}","starred_url":"https://api.github.com/users/adamvoncorswant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamvoncorswant/subscriptions","organizations_url":"https://api.github.com/users/adamvoncorswant/orgs","repos_url":"https://api.github.com/users/adamvoncorswant/repos","events_url":"https://api.github.com/users/adamvoncorswant/events{/privacy}","received_events_url":"https://api.github.com/users/adamvoncorswant/received_events","type":"User","site_admin":false},"body":"Never mind. Just realized that the call `uuid.timestamp()` will throw an exception if it's not a type 1 uuid.","created_at":"2014-12-22T14:01:26Z","updated_at":"2014-12-22T14:01:26Z","html_url":"https://github.com/iZettle/izettle-toolbox/pull/98#discussion_r22166816","pull_request_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/comments/22166816"},"html":{"href":"https://github.com/iZettle/izettle-toolbox/pull/98#discussion_r22166816"},"pull_request":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/98","id":26297693,"html_url":"https://github.com/iZettle/izettle-toolbox/pull/98","diff_url":"https://github.com/iZettle/izettle-toolbox/pull/98.diff","patch_url":"https://github.com/iZettle/izettle-toolbox/pull/98.patch","issue_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/98","number":98,"state":"open","locked":false,"title":"Add support for UUID version 1 to UUIDFactory","user":{"login":"erikryverling","id":1917608,"avatar_url":"https://avatars.githubusercontent.com/u/1917608?v=3","gravatar_id":"","url":"https://api.github.com/users/erikryverling","html_url":"https://github.com/erikryverling","followers_url":"https://api.github.com/users/erikryverling/followers","following_url":"https://api.github.com/users/erikryverling/following{/other_user}","gists_url":"https://api.github.com/users/erikryverling/gists{/gist_id}","starred_url":"https://api.github.com/users/erikryverling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikryverling/subscriptions","organizations_url":"https://api.github.com/users/erikryverling/orgs","repos_url":"https://api.github.com/users/erikryverling/repos","events_url":"https://api.github.com/users/erikryverling/events{/privacy}","received_events_url":"https://api.github.com/users/erikryverling/received_events","type":"User","site_admin":false},"body":"Also improved documentation and minor cleanup.\r\n\r\nThe UUID1 implementation is standardized and compatible with other implementations, such as [python's uuid.uuid()](https://docs.python.org/2/library/uuid.html#uuid.uuid1). \r\n\r\n@adamvoncorswant @fredrikbackstrom Please have a look.","created_at":"2014-12-18T12:47:13Z","updated_at":"2014-12-22T14:01:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcdf889d86cb1bbc933033094a4dbd6f133e7f18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/98/commits","review_comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/98/comments","review_comment_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/comments/{number}","comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/98/comments","statuses_url":"https://api.github.com/repos/iZettle/izettle-toolbox/statuses/4dfabadf3a8032b904895ff4665cc2bb1d54cb56","head":{"label":"iZettle:add-support-for-uuid1-to-uuid-factory","ref":"add-support-for-uuid1-to-uuid-factory","sha":"4dfabadf3a8032b904895ff4665cc2bb1d54cb56","user":{"login":"iZettle","id":1272526,"avatar_url":"https://avatars.githubusercontent.com/u/1272526?v=3","gravatar_id":"","url":"https://api.github.com/users/iZettle","html_url":"https://github.com/iZettle","followers_url":"https://api.github.com/users/iZettle/followers","following_url":"https://api.github.com/users/iZettle/following{/other_user}","gists_url":"https://api.github.com/users/iZettle/gists{/gist_id}","starred_url":"https://api.github.com/users/iZettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iZettle/subscriptions","organizations_url":"https://api.github.com/users/iZettle/orgs","repos_url":"https://api.github.com/users/iZettle/repos","events_url":"https://api.github.com/users/iZettle/events{/privacy}","received_events_url":"https://api.github.com/users/iZettle/received_events","type":"Organization","site_admin":false},"repo":{"id":13087671,"name":"izettle-toolbox","full_name":"iZettle/izettle-toolbox","owner":{"login":"iZettle","id":1272526,"avatar_url":"https://avatars.githubusercontent.com/u/1272526?v=3","gravatar_id":"","url":"https://api.github.com/users/iZettle","html_url":"https://github.com/iZettle","followers_url":"https://api.github.com/users/iZettle/followers","following_url":"https://api.github.com/users/iZettle/following{/other_user}","gists_url":"https://api.github.com/users/iZettle/gists{/gist_id}","starred_url":"https://api.github.com/users/iZettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iZettle/subscriptions","organizations_url":"https://api.github.com/users/iZettle/orgs","repos_url":"https://api.github.com/users/iZettle/repos","events_url":"https://api.github.com/users/iZettle/events{/privacy}","received_events_url":"https://api.github.com/users/iZettle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iZettle/izettle-toolbox","description":"","fork":false,"url":"https://api.github.com/repos/iZettle/izettle-toolbox","forks_url":"https://api.github.com/repos/iZettle/izettle-toolbox/forks","keys_url":"https://api.github.com/repos/iZettle/izettle-toolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iZettle/izettle-toolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iZettle/izettle-toolbox/teams","hooks_url":"https://api.github.com/repos/iZettle/izettle-toolbox/hooks","issue_events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/events{/number}","events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/events","assignees_url":"https://api.github.com/repos/iZettle/izettle-toolbox/assignees{/user}","branches_url":"https://api.github.com/repos/iZettle/izettle-toolbox/branches{/branch}","tags_url":"https://api.github.com/repos/iZettle/izettle-toolbox/tags","blobs_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iZettle/izettle-toolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/iZettle/izettle-toolbox/languages","stargazers_url":"https://api.github.com/repos/iZettle/izettle-toolbox/stargazers","contributors_url":"https://api.github.com/repos/iZettle/izettle-toolbox/contributors","subscribers_url":"https://api.github.com/repos/iZettle/izettle-toolbox/subscribers","subscription_url":"https://api.github.com/repos/iZettle/izettle-toolbox/subscription","commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/comments/{number}","contents_url":"https://api.github.com/repos/iZettle/izettle-toolbox/contents/{+path}","compare_url":"https://api.github.com/repos/iZettle/izettle-toolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iZettle/izettle-toolbox/merges","archive_url":"https://api.github.com/repos/iZettle/izettle-toolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iZettle/izettle-toolbox/downloads","issues_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues{/number}","pulls_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/iZettle/izettle-toolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/iZettle/izettle-toolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iZettle/izettle-toolbox/labels{/name}","releases_url":"https://api.github.com/repos/iZettle/izettle-toolbox/releases{/id}","created_at":"2013-09-25T08:01:29Z","updated_at":"2014-12-22T13:42:35Z","pushed_at":"2014-12-22T13:42:35Z","git_url":"git://github.com/iZettle/izettle-toolbox.git","ssh_url":"git@github.com:iZettle/izettle-toolbox.git","clone_url":"https://github.com/iZettle/izettle-toolbox.git","svn_url":"https://github.com/iZettle/izettle-toolbox","homepage":null,"size":5116,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"iZettle:master","ref":"master","sha":"33890a81fb330c7a0301635e65a1db336960631d","user":{"login":"iZettle","id":1272526,"avatar_url":"https://avatars.githubusercontent.com/u/1272526?v=3","gravatar_id":"","url":"https://api.github.com/users/iZettle","html_url":"https://github.com/iZettle","followers_url":"https://api.github.com/users/iZettle/followers","following_url":"https://api.github.com/users/iZettle/following{/other_user}","gists_url":"https://api.github.com/users/iZettle/gists{/gist_id}","starred_url":"https://api.github.com/users/iZettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iZettle/subscriptions","organizations_url":"https://api.github.com/users/iZettle/orgs","repos_url":"https://api.github.com/users/iZettle/repos","events_url":"https://api.github.com/users/iZettle/events{/privacy}","received_events_url":"https://api.github.com/users/iZettle/received_events","type":"Organization","site_admin":false},"repo":{"id":13087671,"name":"izettle-toolbox","full_name":"iZettle/izettle-toolbox","owner":{"login":"iZettle","id":1272526,"avatar_url":"https://avatars.githubusercontent.com/u/1272526?v=3","gravatar_id":"","url":"https://api.github.com/users/iZettle","html_url":"https://github.com/iZettle","followers_url":"https://api.github.com/users/iZettle/followers","following_url":"https://api.github.com/users/iZettle/following{/other_user}","gists_url":"https://api.github.com/users/iZettle/gists{/gist_id}","starred_url":"https://api.github.com/users/iZettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iZettle/subscriptions","organizations_url":"https://api.github.com/users/iZettle/orgs","repos_url":"https://api.github.com/users/iZettle/repos","events_url":"https://api.github.com/users/iZettle/events{/privacy}","received_events_url":"https://api.github.com/users/iZettle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iZettle/izettle-toolbox","description":"","fork":false,"url":"https://api.github.com/repos/iZettle/izettle-toolbox","forks_url":"https://api.github.com/repos/iZettle/izettle-toolbox/forks","keys_url":"https://api.github.com/repos/iZettle/izettle-toolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iZettle/izettle-toolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iZettle/izettle-toolbox/teams","hooks_url":"https://api.github.com/repos/iZettle/izettle-toolbox/hooks","issue_events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/events{/number}","events_url":"https://api.github.com/repos/iZettle/izettle-toolbox/events","assignees_url":"https://api.github.com/repos/iZettle/izettle-toolbox/assignees{/user}","branches_url":"https://api.github.com/repos/iZettle/izettle-toolbox/branches{/branch}","tags_url":"https://api.github.com/repos/iZettle/izettle-toolbox/tags","blobs_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iZettle/izettle-toolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/iZettle/izettle-toolbox/languages","stargazers_url":"https://api.github.com/repos/iZettle/izettle-toolbox/stargazers","contributors_url":"https://api.github.com/repos/iZettle/izettle-toolbox/contributors","subscribers_url":"https://api.github.com/repos/iZettle/izettle-toolbox/subscribers","subscription_url":"https://api.github.com/repos/iZettle/izettle-toolbox/subscription","commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/iZettle/izettle-toolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/iZettle/izettle-toolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/comments/{number}","contents_url":"https://api.github.com/repos/iZettle/izettle-toolbox/contents/{+path}","compare_url":"https://api.github.com/repos/iZettle/izettle-toolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iZettle/izettle-toolbox/merges","archive_url":"https://api.github.com/repos/iZettle/izettle-toolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iZettle/izettle-toolbox/downloads","issues_url":"https://api.github.com/repos/iZettle/izettle-toolbox/issues{/number}","pulls_url":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/iZettle/izettle-toolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/iZettle/izettle-toolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iZettle/izettle-toolbox/labels{/name}","releases_url":"https://api.github.com/repos/iZettle/izettle-toolbox/releases{/id}","created_at":"2013-09-25T08:01:29Z","updated_at":"2014-12-22T13:42:35Z","pushed_at":"2014-12-22T13:42:35Z","git_url":"git://github.com/iZettle/izettle-toolbox.git","ssh_url":"git@github.com:iZettle/izettle-toolbox.git","clone_url":"https://github.com/iZettle/izettle-toolbox.git","svn_url":"https://github.com/iZettle/izettle-toolbox","homepage":null,"size":5116,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/98"},"html":{"href":"https://github.com/iZettle/izettle-toolbox/pull/98"},"issue":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/98"},"comments":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/iZettle/izettle-toolbox/statuses/4dfabadf3a8032b904895ff4665cc2bb1d54cb56"}}}}