GitHub PullRequestReviewCommentEvent at 2014-10-15 12:31:44
Repository: finder-frontend
Actor: evilstreak
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/comments/18890084","id":18890084,"diff_hunk":"@@ -51,13 +51,7 @@ def facet_sentence_fragments\n \n   def document_type\n     # TODO: get this from the content api respose\n-    {\n-      \"cma-cases\" => \"cma_case\",\n-      \"aaib-reports\" => \"aaib_report\",\n-      \"international-development-funding\" => \"international_development_fund\",\n-      \"drug-device-alerts\" => \"medical_safety_alert\",\n-      \"drug-safety-update\" => \"drug_safety_update\",\n-    }.fetch(@slug)\n+    SLUG_TO_DOCUMENT_TYPE_MAPPINGS.fetch(@slug)","path":"app/models/finder.rb","position":11,"original_position":11,"commit_id":"b35bfb6eb6816f3fe840d9ecd685132d3cd7f0c2","original_commit_id":"b35bfb6eb6816f3fe840d9ecd685132d3cd7f0c2","user":{"login":"evilstreak","id":74812,"avatar_url":"https://avatars.githubusercontent.com/u/74812?v=2","gravatar_id":"","url":"https://api.github.com/users/evilstreak","html_url":"https://github.com/evilstreak","followers_url":"https://api.github.com/users/evilstreak/followers","following_url":"https://api.github.com/users/evilstreak/following{/other_user}","gists_url":"https://api.github.com/users/evilstreak/gists{/gist_id}","starred_url":"https://api.github.com/users/evilstreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilstreak/subscriptions","organizations_url":"https://api.github.com/users/evilstreak/orgs","repos_url":"https://api.github.com/users/evilstreak/repos","events_url":"https://api.github.com/users/evilstreak/events{/privacy}","received_events_url":"https://api.github.com/users/evilstreak/received_events","type":"User","site_admin":false},"body":"We won't ever be providing an interface layer for this. As soon as finders and finder email signup pages are in content store we'll pull `document_type` from those, which will necessitate changing this everywhere anyway.","created_at":"2014-10-15T12:31:44Z","updated_at":"2014-10-15T12:31:44Z","html_url":"https://github.com/alphagov/finder-frontend/pull/93#discussion_r18890084","pull_request_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/comments/18890084"},"html":{"href":"https://github.com/alphagov/finder-frontend/pull/93#discussion_r18890084"},"pull_request":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/93","id":22636781,"html_url":"https://github.com/alphagov/finder-frontend/pull/93","diff_url":"https://github.com/alphagov/finder-frontend/pull/93.diff","patch_url":"https://github.com/alphagov/finder-frontend/pull/93.patch","issue_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/93","number":93,"state":"open","locked":false,"title":"Email subscription with filters","user":{"login":"Themitchell","id":326561,"avatar_url":"https://avatars.githubusercontent.com/u/326561?v=2","gravatar_id":"","url":"https://api.github.com/users/Themitchell","html_url":"https://github.com/Themitchell","followers_url":"https://api.github.com/users/Themitchell/followers","following_url":"https://api.github.com/users/Themitchell/following{/other_user}","gists_url":"https://api.github.com/users/Themitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/Themitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Themitchell/subscriptions","organizations_url":"https://api.github.com/users/Themitchell/orgs","repos_url":"https://api.github.com/users/Themitchell/repos","events_url":"https://api.github.com/users/Themitchell/events{/privacy}","received_events_url":"https://api.github.com/users/Themitchell/received_events","type":"User","site_admin":false},"body":"This pull request includes work to allow email signup with a list of tags in order to filter email subscriptions. This involves hard coding the list of facets on which drug device alerts can be filtered for email. The mechanism has however been built with other means of getting this facet information via an API rather than the schema.\r\n\r\nTrello ticket here:\r\nhttps://trello.com/c/9cA1JxhB/341-mhra-alerts-signing-up-to-either-drug-safety-alerts-or-medical-device-alerts-5-1\r\n\r\nIt also includes a piece of work to switch over subscription from using the govuk_delivery_api to using the new email-alert-api, as per this story:\r\nhttps://trello.com/c/D7GNMvSv/348-swap-finder-frontend-and-specialist-publisher-to-use-new-email-alert-api-3\r\n\r\nIn order to handle some of the test in cucumber we have upgraded rspec and capybara.\r\n\r\nThis story is dependent of the deploy of http://www.github.com/alphagov/static in order to pull the new selectable styling for checkboxes found here:\r\nhttps://github.com/alphagov/static/pull/468","created_at":"2014-10-13T10:34:52Z","updated_at":"2014-10-15T12:31:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e4d8b68eb551949b7ccb74e5b6250d3facf68da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/93/commits","review_comments_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/93/comments","review_comment_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/93/comments","statuses_url":"https://api.github.com/repos/alphagov/finder-frontend/statuses/b35bfb6eb6816f3fe840d9ecd685132d3cd7f0c2","head":{"label":"alphagov:feature/email-subscription-with-filters","ref":"feature/email-subscription-with-filters","sha":"b35bfb6eb6816f3fe840d9ecd685132d3cd7f0c2","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176176,"name":"finder-frontend","full_name":"alphagov/finder-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/finder-frontend","description":"Faceted searching over documents.","fork":false,"url":"https://api.github.com/repos/alphagov/finder-frontend","forks_url":"https://api.github.com/repos/alphagov/finder-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/finder-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/finder-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/finder-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/finder-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/finder-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/finder-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/finder-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/finder-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/finder-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/finder-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/finder-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/finder-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/finder-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/finder-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/finder-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/finder-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/finder-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/finder-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/finder-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/finder-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/finder-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/finder-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/finder-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/finder-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/finder-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/finder-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/finder-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/finder-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/finder-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/finder-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/finder-frontend/releases{/id}","created_at":"2014-01-23T15:21:03Z","updated_at":"2014-10-07T10:32:37Z","pushed_at":"2014-10-13T10:27:32Z","git_url":"git://github.com/alphagov/finder-frontend.git","ssh_url":"git@github.com:alphagov/finder-frontend.git","clone_url":"https://github.com/alphagov/finder-frontend.git","svn_url":"https://github.com/alphagov/finder-frontend","homepage":"","size":3279,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"8133024fc9807a35f5a005bbb8c46a8ca5628bc4","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176176,"name":"finder-frontend","full_name":"alphagov/finder-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=2","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/finder-frontend","description":"Faceted searching over documents.","fork":false,"url":"https://api.github.com/repos/alphagov/finder-frontend","forks_url":"https://api.github.com/repos/alphagov/finder-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/finder-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/finder-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/finder-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/finder-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/finder-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/finder-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/finder-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/finder-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/finder-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/finder-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/finder-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/finder-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/finder-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/finder-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/finder-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/finder-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/finder-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/finder-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/finder-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/finder-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/finder-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/finder-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/finder-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/finder-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/finder-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/finder-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/finder-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/finder-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/finder-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/finder-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/finder-frontend/releases{/id}","created_at":"2014-01-23T15:21:03Z","updated_at":"2014-10-07T10:32:37Z","pushed_at":"2014-10-13T10:27:32Z","git_url":"git://github.com/alphagov/finder-frontend.git","ssh_url":"git@github.com:alphagov/finder-frontend.git","clone_url":"https://github.com/alphagov/finder-frontend.git","svn_url":"https://github.com/alphagov/finder-frontend","homepage":"","size":3279,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/93"},"html":{"href":"https://github.com/alphagov/finder-frontend/pull/93"},"issue":{"href":"https://api.github.com/repos/alphagov/finder-frontend/issues/93"},"comments":{"href":"https://api.github.com/repos/alphagov/finder-frontend/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/finder-frontend/statuses/b35bfb6eb6816f3fe840d9ecd685132d3cd7f0c2"}}}}