GitHub PullRequestReviewCommentEvent at 2014-11-17 19:09:32
Repository: tbd
Actor: twmarshall
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/twmarshall/tbd/pulls/comments/20456717","id":20456717,"diff_hunk":"@@ -0,0 +1,378 @@\n+package tbd.sql;","path":"core/src/main/java/tbd/sql/Datum.java","position":1,"original_position":1,"commit_id":"1622ef6944f78c0a75561209bc3593668111630e","original_commit_id":"1622ef6944f78c0a75561209bc3593668111630e","user":{"login":"twmarshall","id":1149333,"avatar_url":"https://avatars.githubusercontent.com/u/1149333?v=3","gravatar_id":"","url":"https://api.github.com/users/twmarshall","html_url":"https://github.com/twmarshall","followers_url":"https://api.github.com/users/twmarshall/followers","following_url":"https://api.github.com/users/twmarshall/following{/other_user}","gists_url":"https://api.github.com/users/twmarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/twmarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twmarshall/subscriptions","organizations_url":"https://api.github.com/users/twmarshall/orgs","repos_url":"https://api.github.com/users/twmarshall/repos","events_url":"https://api.github.com/users/twmarshall/events{/privacy}","received_events_url":"https://api.github.com/users/twmarshall/received_events","type":"User","site_admin":false},"body":"You need to include the Apache license at the top of all of these files, just like it is at the top of every file already in the repo. I'm not going to repeat this for every file in this review that needs it, because this review is already getting cluttered, but pretty much every new file that you create needs it (certainly at least every source code file)","created_at":"2014-11-17T19:09:32Z","updated_at":"2014-11-17T19:09:32Z","html_url":"https://github.com/twmarshall/tbd/pull/31#discussion_r20456717","pull_request_url":"https://api.github.com/repos/twmarshall/tbd/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/twmarshall/tbd/pulls/comments/20456717"},"html":{"href":"https://github.com/twmarshall/tbd/pull/31#discussion_r20456717"},"pull_request":{"href":"https://api.github.com/repos/twmarshall/tbd/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/twmarshall/tbd/pulls/31","id":24517677,"html_url":"https://github.com/twmarshall/tbd/pull/31","diff_url":"https://github.com/twmarshall/tbd/pull/31.diff","patch_url":"https://github.com/twmarshall/tbd/pull/31.patch","issue_url":"https://api.github.com/repos/twmarshall/tbd/issues/31","number":31,"state":"open","locked":false,"title":"Erzhuo Wang's SQL code","user":{"login":"ernestwang","id":5026293,"avatar_url":"https://avatars.githubusercontent.com/u/5026293?v=3","gravatar_id":"","url":"https://api.github.com/users/ernestwang","html_url":"https://github.com/ernestwang","followers_url":"https://api.github.com/users/ernestwang/followers","following_url":"https://api.github.com/users/ernestwang/following{/other_user}","gists_url":"https://api.github.com/users/ernestwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ernestwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ernestwang/subscriptions","organizations_url":"https://api.github.com/users/ernestwang/orgs","repos_url":"https://api.github.com/users/ernestwang/repos","events_url":"https://api.github.com/users/ernestwang/events{/privacy}","received_events_url":"https://api.github.com/users/ernestwang/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-17T06:50:39Z","updated_at":"2014-11-17T19:09:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7df462d5dd9ef56031e1c67899f1417898cb79f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twmarshall/tbd/pulls/31/commits","review_comments_url":"https://api.github.com/repos/twmarshall/tbd/pulls/31/comments","review_comment_url":"https://api.github.com/repos/twmarshall/tbd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twmarshall/tbd/issues/31/comments","statuses_url":"https://api.github.com/repos/twmarshall/tbd/statuses/1622ef6944f78c0a75561209bc3593668111630e","head":{"label":"ernestwang:erzhuow","ref":"erzhuow","sha":"1622ef6944f78c0a75561209bc3593668111630e","user":{"login":"ernestwang","id":5026293,"avatar_url":"https://avatars.githubusercontent.com/u/5026293?v=3","gravatar_id":"","url":"https://api.github.com/users/ernestwang","html_url":"https://github.com/ernestwang","followers_url":"https://api.github.com/users/ernestwang/followers","following_url":"https://api.github.com/users/ernestwang/following{/other_user}","gists_url":"https://api.github.com/users/ernestwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ernestwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ernestwang/subscriptions","organizations_url":"https://api.github.com/users/ernestwang/orgs","repos_url":"https://api.github.com/users/ernestwang/repos","events_url":"https://api.github.com/users/ernestwang/events{/privacy}","received_events_url":"https://api.github.com/users/ernestwang/received_events","type":"User","site_admin":false},"repo":{"id":26743699,"name":"tbd","full_name":"ernestwang/tbd","owner":{"login":"ernestwang","id":5026293,"avatar_url":"https://avatars.githubusercontent.com/u/5026293?v=3","gravatar_id":"","url":"https://api.github.com/users/ernestwang","html_url":"https://github.com/ernestwang","followers_url":"https://api.github.com/users/ernestwang/followers","following_url":"https://api.github.com/users/ernestwang/following{/other_user}","gists_url":"https://api.github.com/users/ernestwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ernestwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ernestwang/subscriptions","organizations_url":"https://api.github.com/users/ernestwang/orgs","repos_url":"https://api.github.com/users/ernestwang/repos","events_url":"https://api.github.com/users/ernestwang/events{/privacy}","received_events_url":"https://api.github.com/users/ernestwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ernestwang/tbd","description":"","fork":true,"url":"https://api.github.com/repos/ernestwang/tbd","forks_url":"https://api.github.com/repos/ernestwang/tbd/forks","keys_url":"https://api.github.com/repos/ernestwang/tbd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ernestwang/tbd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ernestwang/tbd/teams","hooks_url":"https://api.github.com/repos/ernestwang/tbd/hooks","issue_events_url":"https://api.github.com/repos/ernestwang/tbd/issues/events{/number}","events_url":"https://api.github.com/repos/ernestwang/tbd/events","assignees_url":"https://api.github.com/repos/ernestwang/tbd/assignees{/user}","branches_url":"https://api.github.com/repos/ernestwang/tbd/branches{/branch}","tags_url":"https://api.github.com/repos/ernestwang/tbd/tags","blobs_url":"https://api.github.com/repos/ernestwang/tbd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ernestwang/tbd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ernestwang/tbd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ernestwang/tbd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ernestwang/tbd/statuses/{sha}","languages_url":"https://api.github.com/repos/ernestwang/tbd/languages","stargazers_url":"https://api.github.com/repos/ernestwang/tbd/stargazers","contributors_url":"https://api.github.com/repos/ernestwang/tbd/contributors","subscribers_url":"https://api.github.com/repos/ernestwang/tbd/subscribers","subscription_url":"https://api.github.com/repos/ernestwang/tbd/subscription","commits_url":"https://api.github.com/repos/ernestwang/tbd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ernestwang/tbd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ernestwang/tbd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ernestwang/tbd/issues/comments/{number}","contents_url":"https://api.github.com/repos/ernestwang/tbd/contents/{+path}","compare_url":"https://api.github.com/repos/ernestwang/tbd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ernestwang/tbd/merges","archive_url":"https://api.github.com/repos/ernestwang/tbd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ernestwang/tbd/downloads","issues_url":"https://api.github.com/repos/ernestwang/tbd/issues{/number}","pulls_url":"https://api.github.com/repos/ernestwang/tbd/pulls{/number}","milestones_url":"https://api.github.com/repos/ernestwang/tbd/milestones{/number}","notifications_url":"https://api.github.com/repos/ernestwang/tbd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ernestwang/tbd/labels{/name}","releases_url":"https://api.github.com/repos/ernestwang/tbd/releases{/id}","created_at":"2014-11-17T06:40:00Z","updated_at":"2014-11-17T06:40:01Z","pushed_at":"2014-11-17T06:49:00Z","git_url":"git://github.com/ernestwang/tbd.git","ssh_url":"git@github.com:ernestwang/tbd.git","clone_url":"https://github.com/ernestwang/tbd.git","svn_url":"https://github.com/ernestwang/tbd","homepage":null,"size":7835,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twmarshall:master","ref":"master","sha":"4f7ec659284512e359730e48676f768bad9c7983","user":{"login":"twmarshall","id":1149333,"avatar_url":"https://avatars.githubusercontent.com/u/1149333?v=3","gravatar_id":"","url":"https://api.github.com/users/twmarshall","html_url":"https://github.com/twmarshall","followers_url":"https://api.github.com/users/twmarshall/followers","following_url":"https://api.github.com/users/twmarshall/following{/other_user}","gists_url":"https://api.github.com/users/twmarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/twmarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twmarshall/subscriptions","organizations_url":"https://api.github.com/users/twmarshall/orgs","repos_url":"https://api.github.com/users/twmarshall/repos","events_url":"https://api.github.com/users/twmarshall/events{/privacy}","received_events_url":"https://api.github.com/users/twmarshall/received_events","type":"User","site_admin":false},"repo":{"id":15982419,"name":"tbd","full_name":"twmarshall/tbd","owner":{"login":"twmarshall","id":1149333,"avatar_url":"https://avatars.githubusercontent.com/u/1149333?v=3","gravatar_id":"","url":"https://api.github.com/users/twmarshall","html_url":"https://github.com/twmarshall","followers_url":"https://api.github.com/users/twmarshall/followers","following_url":"https://api.github.com/users/twmarshall/following{/other_user}","gists_url":"https://api.github.com/users/twmarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/twmarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twmarshall/subscriptions","organizations_url":"https://api.github.com/users/twmarshall/orgs","repos_url":"https://api.github.com/users/twmarshall/repos","events_url":"https://api.github.com/users/twmarshall/events{/privacy}","received_events_url":"https://api.github.com/users/twmarshall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twmarshall/tbd","description":"","fork":false,"url":"https://api.github.com/repos/twmarshall/tbd","forks_url":"https://api.github.com/repos/twmarshall/tbd/forks","keys_url":"https://api.github.com/repos/twmarshall/tbd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twmarshall/tbd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twmarshall/tbd/teams","hooks_url":"https://api.github.com/repos/twmarshall/tbd/hooks","issue_events_url":"https://api.github.com/repos/twmarshall/tbd/issues/events{/number}","events_url":"https://api.github.com/repos/twmarshall/tbd/events","assignees_url":"https://api.github.com/repos/twmarshall/tbd/assignees{/user}","branches_url":"https://api.github.com/repos/twmarshall/tbd/branches{/branch}","tags_url":"https://api.github.com/repos/twmarshall/tbd/tags","blobs_url":"https://api.github.com/repos/twmarshall/tbd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twmarshall/tbd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twmarshall/tbd/git/refs{/sha}","trees_url":"https://api.github.com/repos/twmarshall/tbd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twmarshall/tbd/statuses/{sha}","languages_url":"https://api.github.com/repos/twmarshall/tbd/languages","stargazers_url":"https://api.github.com/repos/twmarshall/tbd/stargazers","contributors_url":"https://api.github.com/repos/twmarshall/tbd/contributors","subscribers_url":"https://api.github.com/repos/twmarshall/tbd/subscribers","subscription_url":"https://api.github.com/repos/twmarshall/tbd/subscription","commits_url":"https://api.github.com/repos/twmarshall/tbd/commits{/sha}","git_commits_url":"https://api.github.com/repos/twmarshall/tbd/git/commits{/sha}","comments_url":"https://api.github.com/repos/twmarshall/tbd/comments{/number}","issue_comment_url":"https://api.github.com/repos/twmarshall/tbd/issues/comments/{number}","contents_url":"https://api.github.com/repos/twmarshall/tbd/contents/{+path}","compare_url":"https://api.github.com/repos/twmarshall/tbd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twmarshall/tbd/merges","archive_url":"https://api.github.com/repos/twmarshall/tbd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twmarshall/tbd/downloads","issues_url":"https://api.github.com/repos/twmarshall/tbd/issues{/number}","pulls_url":"https://api.github.com/repos/twmarshall/tbd/pulls{/number}","milestones_url":"https://api.github.com/repos/twmarshall/tbd/milestones{/number}","notifications_url":"https://api.github.com/repos/twmarshall/tbd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twmarshall/tbd/labels{/name}","releases_url":"https://api.github.com/repos/twmarshall/tbd/releases{/id}","created_at":"2014-01-16T22:05:14Z","updated_at":"2014-09-05T14:49:37Z","pushed_at":"2014-11-17T18:28:12Z","git_url":"git://github.com/twmarshall/tbd.git","ssh_url":"git@github.com:twmarshall/tbd.git","clone_url":"https://github.com/twmarshall/tbd.git","svn_url":"https://github.com/twmarshall/tbd","homepage":null,"size":7835,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twmarshall/tbd/pulls/31"},"html":{"href":"https://github.com/twmarshall/tbd/pull/31"},"issue":{"href":"https://api.github.com/repos/twmarshall/tbd/issues/31"},"comments":{"href":"https://api.github.com/repos/twmarshall/tbd/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/twmarshall/tbd/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/twmarshall/tbd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twmarshall/tbd/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/twmarshall/tbd/statuses/1622ef6944f78c0a75561209bc3593668111630e"}}}}