GitHub PushEvent at 2014-05-10 01:57:18
Repository: canvas-lms
Actor: zywfu
Payload: {"shas":[["2f9c6f82e18e3b1bee50b25452976ea50b8f497b","ff87a0776152510efd53bb1f4ea089dbbc90e730@instructure.com","rails3: path proxies to request.path in rails3, which doesn't include query params\n\nChange-Id: I278ac02f4f9f89a4cc11532c85c98f615304f360\nReviewed-on: https://gerrit.instructure.com/30162\nReviewed-by: Cody Cutrer <cody@instructure.com>\nTested-by: Jenkins <jenkins@instructure.com>\nProduct-Review: Derek DeVries <ddevries@instructure.com>\nQA-Review: Derek DeVries <ddevries@instructure.com>","Derek DeVries",false],["39a7266315779eb57b61880eeb25b15a7d89fb75","eb5ce5e6a76c243326fecfa94534101600f87bd9@instructure.com","remove unused actions in rubric_assessments_controller\n\nthe index and show actions are unused. the index view was\nremoved awhile ago in 91ce600f.\n\nChange-Id: Ib84fc2e9e524aec3143a4395d15f9c1320798648\nReviewed-on: https://gerrit.instructure.com/29983\nTested-by: Jenkins <jenkins@instructure.com>\nReviewed-by: Derek DeVries <ddevries@instructure.com>\nProduct-Review: Jon Willesen <jonw@instructure.com>\nQA-Review: Jon Willesen <jonw@instructure.com>","Jon Willesen",false],["2fd1b3f131e73d61bb099cab3b15319fdd29823f","49761a8c1f00c6a9ec3f8c339135c9857c1ecbe2@gmail.com","convert shared/_inlined_preview js_block into js_bundle\n\ntest plan:\n* regression test shared inlined preview\n\nChange-Id: I1e2f70258878c14b0fd28e8848b6c87b096c027d\nReviewed-on: https://gerrit.instructure.com/29110\nReviewed-by: Jon Jensen <jon@instructure.com>\nTested-by: Jenkins <jenkins@instructure.com>\nProduct-Review: Marc LeGendre <marc@instructure.com>\nQA-Review: Marc LeGendre <marc@instructure.com>","Landon Wilkins",false],["4654c34bef99d7e8becc14436bf45132c9f24454","ff87a0776152510efd53bb1f4ea089dbbc90e730@instructure.com","rails3: fix for erubis issues and quizzes controller specs\n\nthings fixed:\n  - erubis is in actionpack gemspec in rails3, so we don't need it in the gemfile\n  - don't directly initialize a SafeBuffer, and instead initialize OutputBuffer\n  - Fix comparison of hash with indifferent access in quizzes spec\n  - plugins in rails3 aren't loaded in init.rb so rails_xss is still being\n    loaded in rails3. However we have parts of the code that actually reference\n    rails_xss classes directly so we want to keep the RailsXss::Erubis constant\n    defined in erubis.rb. However we don't want to actually monkey patch\n    the activesupport or string methods anymore for xss (rails3 takes care of\n    this for us)\n\nChange-Id: I327bf042dfa7dcedd39acb463eda1420d3dbd98c\nReviewed-on: https://gerrit.instructure.com/30108\nTested-by: Jenkins <jenkins@instructure.com>\nReviewed-by: Cameron Matheson <cameron@instructure.com>\nProduct-Review: Derek DeVries <ddevries@instructure.com>\nQA-Review: Derek DeVries <ddevries@instructure.com>","Derek DeVries",false],["e4530487ebbd12dc58aab1890fd7f3e791211cde","4816dabf8db1bc6cac35b3a24cab2ff844b5b0c7@instructure.com","returns shard aware participant ids from discussion view api\n\nfixes CNVS-10549\n\ntest plan\n- create a discussion topic\n- reply to the topic with a user on another shard\n- view the discussion as the original topic creator\n- ensure that the reply shows the correct author\n\nChange-Id: I5115f6fd3a21f6c8b986e7a9e0c95b5fe4be1587\nReviewed-on: https://gerrit.instructure.com/30080\nTested-by: Jenkins <jenkins@instructure.com>\nReviewed-by: Zach Pendleton <zachp@instructure.com>\nProduct-Review: Zach Pendleton <zachp@instructure.com>\nQA-Review: Matt Fairbourn <mfairbourn@instructure.com>","Joel Hough",false],["03a35fcea84eb24a89297cd19b58c023092b81f1","01acd3247a4780711d0930f64c5667e7367603a2@instructure.com","announce selected student, assignment for srgb\n\nfixes CNVS-10369\n\ntest plan\n- in screenreader gradebook\n- use the dropdowns to select students, assignments\n- verify that screenreader/JAWS/etc announces the selected\n  student/assignment\n- use prev/next buttons to select students, assignments\n- verify correct text is read\n- in VO buttons will announce that that they are dimmed when you try to\n  click with last/first student/assignment selected, in JAWS it should\n  be announced as \"unavailable\" when navigating over it\n- verify when clicking, that assignment / student name is appended after\n  the last item in the page (this will be visually hidden a separate commit)\n\nChange-Id: I83f9447256777947c14641f04578a69d6f2dffe7\nReviewed-on: https://gerrit.instructure.com/29045\nReviewed-by: Liz Abinante <labinante@instructure.com>\nTested-by: Jenkins <jenkins@instructure.com>\nQA-Review: Caleb Guanzon <cguanzon@instructure.com>\nReviewed-by: Mike Nomitch <mnomitch@instructure.com>\nProduct-Review: Aaron Cannon <acannon@instructure.com>","Matthew Irish",false],["6fca0880bba0264b0cb7c8cd3cc0847f21594b7a","c4fe2b1d90ef8f2548c8aeabfa633434316f0305@instructure.com","fix authentication_audits_api_spec for rails 3\n\noptions is never defined, and it only happens to work in rails 2\ncause it's an internal method of rspec 1 that returns an empty hash\n\nChange-Id: Ifa43d54bd8739188f61dbf9ce0ffd7e4ef782719\nReviewed-on: https://gerrit.instructure.com/30167\nTested-by: Jenkins <jenkins@instructure.com>\nReviewed-by: Derek DeVries <ddevries@instructure.com>\nProduct-Review: Cody Cutrer <cody@instructure.com>\nQA-Review: Cody Cutrer <cody@instructure.com>","Cody Cutrer",false],["aa4d0e7e899df21d6c932a0cb8a0301886db0c3a","c4fe2b1d90ef8f2548c8aeabfa633434316f0305@instructure.com","fix deprecation notices about using formats in rails 3\n\nChange-Id: I80b8482d543ec303517dd43fc6c0a6404699326f\nReviewed-on: https://gerrit.instructure.com/30154\nTested-by: Jenkins <jenkins@instructure.com>\nReviewed-by: Jon Willesen <jonw@instructure.com>\nProduct-Review: Cody Cutrer <cody@instructure.com>\nQA-Review: Cody Cutrer <cody@instructure.com>","Cody Cutrer",false],["018008ae56da5bc3c5c1057b55c3a6030d7698a0","3a5f4ed991dbfa5c9ef76ad729d240ca12f62180@instructure.com","set answer text to identifier for bb learn true/false questions\n\ntest plan:\n* import the package referenced in the ticket\n* should not import the wrong answer text for the questions\n\nfixes #CNVS-9381 frd\n\nChange-Id: I42e125c64bf5009b4384d7cc18edf75d7bcfc9f1\nReviewed-on: https://gerrit.instructure.com/30164\nReviewed-by: Bracken Mosbacker <bracken@instructure.com>\nProduct-Review: Bracken Mosbacker <bracken@instructure.com>\nTested-by: Jenkins <jenkins@instructure.com>\nQA-Review: Matt Fairbourn <mfairbourn@instructure.com>","James Williams",false],["d55a261ffb7810ab2f8760cbb3802d637a51b712","eb5ce5e6a76c243326fecfa94534101600f87bd9@instructure.com","fix rails3 specs for rubrics_controller_spec\n\nChange-Id: I5d842aa9dbba5c709eea637b8dc136eab787220f\nReviewed-on: https://gerrit.instructure.com/30172\nTested-by: Jenkins <jenkins@instructure.com>\nReviewed-by: Derek DeVries <ddevries@instructure.com>\nProduct-Review: Jon Willesen <jonw@instructure.com>\nQA-Review: Jon Willesen <jonw@instructure.com>","Jon Willesen",false],["afe2e87acbe7bc266838e6530e688690a278df94","5108e8d39c3daf832a5d5b01c70727c22a362224@instructure.com","allow setting start_at, end_at for enrollments api\n\nfixes SIS-160\n\nTest Plan\n---------\n  - Create an enrollment via the api with start_at and end_at parameters\n  - verify start_at and end_at are poplutated for resulting record in enrollments table\n  - verify user can only access course during start_at and end_at times\n\nChange-Id: Icfeaded1f43c6b0309d41280d7caa17482b9182e\nReviewed-on: https://gerrit.instructure.com/30136\nTested-by: Jenkins <jenkins@instructure.com>\nReviewed-by: Ken Romney <kromney@instructure.com>\nReviewed-by: Duane Johnson <duane@instructure.com>\nProduct-Review: Duane Johnson <duane@instructure.com>\nQA-Review: Jeremy Putnam <jeremyp@instructure.com>","Eric Adams",false],["b49a9a8a5b2e21e404628bc932b1e9390fb997f4","d630b17dcb6f54330e202f868831681842596d45@instructure.com","Updated pl translation","Transifreq",false],["97d1103a5f05a75813a7a05bebf77bbd6899bb5c","d630b17dcb6f54330e202f868831681842596d45@instructure.com","Updated pl translation","Transifreq",false],["8b77c9768a76b3189d54ca1fa5926377eecd62b6","d630b17dcb6f54330e202f868831681842596d45@instructure.com","Updated ja translation","Transifreq",false],["a52e267ba2f7e48bf73da58a0eb1fe691bff721c","f862f167b85d41b225785c70d70808bc7337c1fe@instructure.com","make the codecogs equation base url a setting\n\nfixes CNVS-10049\n\ntest-plan:\n\n * clear codecogs.equation_image_link setting\n * visit /equation_images/%5Csqrt%5B2%5D%7B900%7D%3Dx\n * should be redirected to http://latex.codecogs.com/gif.latex?%5Csqrt%5B2%5D%7B900%7D%3Dx\n * set codecogs.equation_image_link setting to \"http://example.com/\"\n * visit /equation_images/%5Csqrt%5B2%5D%7B900%7D%3Dx\n * should be redirected to http://example.com/?%5Csqrt%5B2%5D%7B900%7D%3Dx\n\nChange-Id: Ic683111ec4109bacdd5c06c633c70129ab688fcc\nReviewed-on: https://gerrit.instructure.com/30212\nReviewed-by: Jacob Fugal <jacob@instructure.com>\nQA-Review: Jacob Fugal <jacob@instructure.com>\nProduct-Review: Jacob Fugal <jacob@instructure.com>\nQA-Review: Clare Strong <clare@instructure.com>\nTested-by: Cody Cutrer <cody@instructure.com>","Jacob Fugal",false],["bff1859df31d33db59706a276579495a64968d63","2b43fb8b7a234825d50dd49ce7892d78a59da8f3@instructure.com","add speed_grader_url to the quizzes api\n\nTest plan:\n  - As a teacher, you should be able to see \"speed_grader_url\" that\n    goes to the correct url when you query the quizzes index api and the\n    quiz show api.\n  - As a student, you should not see the \"speed_grader_url\" key when\n    you query the quizzes index api and the quiz show api.\n\nChange-Id: I9a827846fcf201d031715567e8af1f6ffda4a343\nReviewed-on: https://gerrit.instructure.com/30127\nTested-by: Jenkins <jenkins@instructure.com>\nQA-Review: Caleb Guanzon <cguanzon@instructure.com>\nReviewed-by: Jason Madsen <jmadsen@instructure.com>\nProduct-Review: Stanley Stuart <stanley@instructure.com>","Stanley Stuart",false],["5a37b27bf72452f7373f961b450013775cd862b6","c4fe2b1d90ef8f2548c8aeabfa633434316f0305@instructure.com","fix gradebooks_controller_spec for rails 3\n\nChange-Id: I927859cd69aecf78c593cc5507144a01fc7340ed\nReviewed-on: https://gerrit.instructure.com/30094\nTested-by: Jenkins <jenkins@instructure.com>\nReviewed-by: James Williams  <jamesw@instructure.com>\nProduct-Review: Cody Cutrer <cody@instructure.com>\nQA-Review: Cody Cutrer <cody@instructure.com>","Cody Cutrer",false],["e38d1a5c03aad9e46d589bca5db76f7385320a04","10b0771d20c18ad0d98c1d000665e443052b40b0@instructure.com","additional partner data for kaltura\n\nfixes PS-931\n\ntest plan\n*upload file on files page\n*additional partner_data should be available on kaltura\n*should include root_acount_id, context_code\n\nChange-Id: If0849dc373acdbbc56cae30434c48adfb016d8c7\nReviewed-on: https://gerrit.instructure.com/28662\nProduct-Review: Adam Phillipps <adam@instructure.com>\nQA-Review: Adam Phillipps <adam@instructure.com>\nTested-by: Jenkins <jenkins@instructure.com>\nReviewed-by: Brandon Broschinsky <brandonbr@instructure.com>\nReviewed-by: Bracken Mosbacker <bracken@instructure.com>","Nathan Mills",false],["30273990fbf028aefeec07b87faea3c0b66ede76","675dc611bafb0b7348dd3baf7e005b6916fb954d@instructure.com","spec: check image pending\n\nChange-Id: Ib1c4c3de05949ff44a69435583738fe607b9bc8e\nReviewed-on: https://gerrit.instructure.com/30222\nReviewed-by: Shawn Meredith <shawn@instructure.com>\nProduct-Review: Shawn Meredith <shawn@instructure.com>\nQA-Review: Shawn Meredith <shawn@instructure.com>\nReviewed-by: Hannah Bottalla <hannah@instructure.com>\nProduct-Review: Hannah Bottalla <hannah@instructure.com>\nQA-Review: Hannah Bottalla <hannah@instructure.com>\nTested-by: Hannah Bottalla <hannah@instructure.com>","Hannah Bottalla",false],["b91897bc9d2d9fb0bba1aefc35c49c30c242ef53","01acd3247a4780711d0930f64c5667e7367603a2@instructure.com","layout changes for srgb\n\n- i18n's everything\n- shuffles content a bit\n- adds some styling\n- added empty states for the various sections rather than just hiding them\n- also removes jquery patch that adds \"disabled\" class when disabling an\n  element\n\ncloses CNVS-9390\n\ntest plan\n=========\nthe layout should look nicer\ntests should still pass\ngeneral regression tests of srgb\n\nChange-Id: Iba2c0239d2e0312e26225652190c5280120598fd\nReviewed-on: https://gerrit.instructure.com/29845\nReviewed-by: Matthew Irish <mirish@instructure.com>\nProduct-Review: Matthew Irish <mirish@instructure.com>\nTested-by: Jenkins <jenkins@instructure.com>\nQA-Review: Amber Taniuchi <amber@instructure.com>","Matthew Irish",false]],"size":1000,"ref":"refs/heads/master","head":"7af788b6127534b235d72ea6425d2ceed6ba4a81"}