GitHub PullRequestReviewCommentEvent at 2014-01-17 01:04:44
Repository: binary-data
Actor: hannesm
Payload: {"comment":{"url":"https://api.github.com/repos/dylan-lang/binary-data/pulls/comments/8954401","id":8954401,"diff_hunk":"@@ -95,58 +279,103 @@ For example:\n       over <ip-option-frame> 0;\n     end;\n \n+    define binary-data router-alert-ip-option (ip-option-frame)\n+      over <ip-option-frame> 20;\n+      field router-alert-length :: <unsigned-byte> = 4;\n+      field router-alert-value :: <2byte-big-endian-unsigned-integer>;\n+    end;\n+\n This defines the ``<end-of-option-ip-option>`` which has the ``option-type``\n field in the ip-option frame set to ``0``. An ``<end-of-option-ip-option>``\n does not contain any further fields, thus only has the two fields inherited from\n the ``<ip-option-frame>``.\n \n-Frame Options\n-=============\n+The ``<router-alert-ip-option>`` specifies two more fields, which are\n+appended to the inherited fields.\n \n-.. note:: These frame options do not compose. The presence of one prohibits\n-   the presence of the others.\n+Container Frame Options\n+-----------------------\n \n-``length``:\n-   ...\n+``length`` *expression*:\n+   A Dylan expression which emits the length of the frame. A binding\n+   to the frame instance is available as the local variable ``frame``.\n \n-``over``:\n-   See `Variably Typed Container Frame`_ for an example of how this is\n-   used.\n+``over`` *binary-data-type* *value*:\n+   This frame can be stacked as payload to *binary-data-type* with the\n+   *value* in the layering field.\n \n+``summary`` *format-string*, *arguments*:\n+   The generic function :gf:`summary` is specialized using\n+   :gf:`format-to-string` on the *format-string*, applying the frame\n+   instance to all *arguments*, which should be unary functions.\n ","path":"documentation/source/usage.rst","position":281,"original_position":281,"commit_id":"e168a96539c48f949441db17a1d48bc6086f6d39","original_commit_id":"e8a4e955382e5c57b708c29f29db15ccc828f433","user":{"login":"hannesm","id":228456,"avatar_url":"https://gravatar.com/avatar/25558b4457cf73159f5427fdf2b4a717?d=https%3A%2F%2Fidenticons.github.com%2F66bb32616e97da1462012be4d68ca71c.png&r=x","gravatar_id":"25558b4457cf73159f5427fdf2b4a717","url":"https://api.github.com/users/hannesm","html_url":"https://github.com/hannesm","followers_url":"https://api.github.com/users/hannesm/followers","following_url":"https://api.github.com/users/hannesm/following{/other_user}","gists_url":"https://api.github.com/users/hannesm/gists{/gist_id}","starred_url":"https://api.github.com/users/hannesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannesm/subscriptions","organizations_url":"https://api.github.com/users/hannesm/orgs","repos_url":"https://api.github.com/users/hannesm/repos","events_url":"https://api.github.com/users/hannesm/events{/privacy}","received_events_url":"https://api.github.com/users/hannesm/received_events","type":"User","site_admin":false},"body":"an example of this usage is https://github.com/dylan-hackers/network-night-vision/blob/master/protocols/ipv4.dylan#L56 .. the binary-data-definer macro calls itself after parsing summary, over, or length...","created_at":"2014-01-17T01:04:44Z","updated_at":"2014-01-17T01:04:44Z","html_url":"https://github.com/dylan-lang/binary-data/pull/15#discussion_r8954401","pull_request_url":"https://api.github.com/repos/dylan-lang/binary-data/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/dylan-lang/binary-data/pulls/comments/8954401"},"html":{"href":"https://github.com/dylan-lang/binary-data/pull/15#discussion_r8954401"},"pull_request":{"href":"https://api.github.com/repos/dylan-lang/binary-data/pulls/15"}}}}