GitHub PullRequestReviewCommentEvent at 2014-08-06 12:14:21
Repository: jissues
Actor: allenzhao
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/joomla/jissues/pulls/comments/15869524","id":15869524,"diff_hunk":"@@ -98,6 +98,7 @@ public function getFunctions()\n \t\t\tnew \\Twig_SimpleFunction('issueLink', array($this, 'issueLink')),\n \t\t\tnew \\Twig_SimpleFunction('getRelTypes', array($this, 'getRelTypes')),\n \t\t\tnew \\Twig_SimpleFunction('getTimezones', array($this, 'getTimezones')),\n+\t\t\tnew \\Twig_SimpleFunction('getContrastColor', array($this, 'getContrastColor'))","path":"src/JTracker/View/Renderer/TrackerExtension.php","position":4,"original_position":4,"commit_id":"65522a1d7d9aef811829a99593c548315f5e7f33","original_commit_id":"65522a1d7d9aef811829a99593c548315f5e7f33","user":{"login":"allenzhao","id":3326332,"avatar_url":"https://avatars.githubusercontent.com/u/3326332?v=2","gravatar_id":"38930e6a27ff95cd9450e7c91cbf9b3c","url":"https://api.github.com/users/allenzhao","html_url":"https://github.com/allenzhao","followers_url":"https://api.github.com/users/allenzhao/followers","following_url":"https://api.github.com/users/allenzhao/following{/other_user}","gists_url":"https://api.github.com/users/allenzhao/gists{/gist_id}","starred_url":"https://api.github.com/users/allenzhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenzhao/subscriptions","organizations_url":"https://api.github.com/users/allenzhao/orgs","repos_url":"https://api.github.com/users/allenzhao/repos","events_url":"https://api.github.com/users/allenzhao/events{/privacy}","received_events_url":"https://api.github.com/users/allenzhao/received_events","type":"User","site_admin":false},"body":"It's already implemented [here](https://github.com/allenzhao/jissues/blob/issuecategory/src/JTracker/View/Renderer/TrackerExtension.php#L340)","created_at":"2014-08-06T12:14:21Z","updated_at":"2014-08-06T12:14:21Z","html_url":"https://github.com/joomla/jissues/pull/409#discussion_r15869524","pull_request_url":"https://api.github.com/repos/joomla/jissues/pulls/409","_links":{"self":{"href":"https://api.github.com/repos/joomla/jissues/pulls/comments/15869524"},"html":{"href":"https://github.com/joomla/jissues/pull/409#discussion_r15869524"},"pull_request":{"href":"https://api.github.com/repos/joomla/jissues/pulls/409"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/jissues/pulls/409","id":19385390,"html_url":"https://github.com/joomla/jissues/pull/409","diff_url":"https://github.com/joomla/jissues/pull/409.diff","patch_url":"https://github.com/joomla/jissues/pull/409.patch","issue_url":"https://api.github.com/repos/joomla/jissues/issues/409","number":409,"state":"open","title":"Feature: category #317","user":{"login":"allenzhao","id":3326332,"avatar_url":"https://avatars.githubusercontent.com/u/3326332?v=2","gravatar_id":"38930e6a27ff95cd9450e7c91cbf9b3c","url":"https://api.github.com/users/allenzhao","html_url":"https://github.com/allenzhao","followers_url":"https://api.github.com/users/allenzhao/followers","following_url":"https://api.github.com/users/allenzhao/following{/other_user}","gists_url":"https://api.github.com/users/allenzhao/gists{/gist_id}","starred_url":"https://api.github.com/users/allenzhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenzhao/subscriptions","organizations_url":"https://api.github.com/users/allenzhao/orgs","repos_url":"https://api.github.com/users/allenzhao/repos","events_url":"https://api.github.com/users/allenzhao/events{/privacy}","received_events_url":"https://api.github.com/users/allenzhao/received_events","type":"User","site_admin":false},"body":"This is the implementation of #317\r\nHere are some to-dos for me:\r\n- [ ] Deploy a live site to test\r\n- [ ] UI needs to be changed \r\n- [ ] **Color** of the UI not implemented\r\n\r\n@elkuku @b2z Please review the code. And especially the `etc/mysql.sql` file. I will probably deploy a live site later today, but need your advices on how(or where, etc), so you can test with full - feature. Do we need a fake account and fake repo?\r\n\r\nAnd for the UI part, any ideas?\r\n\r\nThanks!","created_at":"2014-08-06T05:23:04Z","updated_at":"2014-08-06T12:14:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5280f019baf4c0593a4c17e5f2c48f93770cc0e9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joomla/jissues/pulls/409/commits","review_comments_url":"https://api.github.com/repos/joomla/jissues/pulls/409/comments","review_comment_url":"https://api.github.com/repos/joomla/jissues/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joomla/jissues/issues/409/comments","statuses_url":"https://api.github.com/repos/joomla/jissues/statuses/65522a1d7d9aef811829a99593c548315f5e7f33","head":{"label":"allenzhao:issuecategory","ref":"issuecategory","sha":"65522a1d7d9aef811829a99593c548315f5e7f33","user":{"login":"allenzhao","id":3326332,"avatar_url":"https://avatars.githubusercontent.com/u/3326332?v=2","gravatar_id":"38930e6a27ff95cd9450e7c91cbf9b3c","url":"https://api.github.com/users/allenzhao","html_url":"https://github.com/allenzhao","followers_url":"https://api.github.com/users/allenzhao/followers","following_url":"https://api.github.com/users/allenzhao/following{/other_user}","gists_url":"https://api.github.com/users/allenzhao/gists{/gist_id}","starred_url":"https://api.github.com/users/allenzhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenzhao/subscriptions","organizations_url":"https://api.github.com/users/allenzhao/orgs","repos_url":"https://api.github.com/users/allenzhao/repos","events_url":"https://api.github.com/users/allenzhao/events{/privacy}","received_events_url":"https://api.github.com/users/allenzhao/received_events","type":"User","site_admin":false},"repo":{"id":17099406,"name":"jissues","full_name":"allenzhao/jissues","owner":{"login":"allenzhao","id":3326332,"avatar_url":"https://avatars.githubusercontent.com/u/3326332?v=2","gravatar_id":"38930e6a27ff95cd9450e7c91cbf9b3c","url":"https://api.github.com/users/allenzhao","html_url":"https://github.com/allenzhao","followers_url":"https://api.github.com/users/allenzhao/followers","following_url":"https://api.github.com/users/allenzhao/following{/other_user}","gists_url":"https://api.github.com/users/allenzhao/gists{/gist_id}","starred_url":"https://api.github.com/users/allenzhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenzhao/subscriptions","organizations_url":"https://api.github.com/users/allenzhao/orgs","repos_url":"https://api.github.com/users/allenzhao/repos","events_url":"https://api.github.com/users/allenzhao/events{/privacy}","received_events_url":"https://api.github.com/users/allenzhao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/allenzhao/jissues","description":"Issue Tracking application integrating with GitHub to replace the existing Joomlacode solution.","fork":true,"url":"https://api.github.com/repos/allenzhao/jissues","forks_url":"https://api.github.com/repos/allenzhao/jissues/forks","keys_url":"https://api.github.com/repos/allenzhao/jissues/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allenzhao/jissues/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allenzhao/jissues/teams","hooks_url":"https://api.github.com/repos/allenzhao/jissues/hooks","issue_events_url":"https://api.github.com/repos/allenzhao/jissues/issues/events{/number}","events_url":"https://api.github.com/repos/allenzhao/jissues/events","assignees_url":"https://api.github.com/repos/allenzhao/jissues/assignees{/user}","branches_url":"https://api.github.com/repos/allenzhao/jissues/branches{/branch}","tags_url":"https://api.github.com/repos/allenzhao/jissues/tags","blobs_url":"https://api.github.com/repos/allenzhao/jissues/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allenzhao/jissues/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allenzhao/jissues/git/refs{/sha}","trees_url":"https://api.github.com/repos/allenzhao/jissues/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allenzhao/jissues/statuses/{sha}","languages_url":"https://api.github.com/repos/allenzhao/jissues/languages","stargazers_url":"https://api.github.com/repos/allenzhao/jissues/stargazers","contributors_url":"https://api.github.com/repos/allenzhao/jissues/contributors","subscribers_url":"https://api.github.com/repos/allenzhao/jissues/subscribers","subscription_url":"https://api.github.com/repos/allenzhao/jissues/subscription","commits_url":"https://api.github.com/repos/allenzhao/jissues/commits{/sha}","git_commits_url":"https://api.github.com/repos/allenzhao/jissues/git/commits{/sha}","comments_url":"https://api.github.com/repos/allenzhao/jissues/comments{/number}","issue_comment_url":"https://api.github.com/repos/allenzhao/jissues/issues/comments/{number}","contents_url":"https://api.github.com/repos/allenzhao/jissues/contents/{+path}","compare_url":"https://api.github.com/repos/allenzhao/jissues/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allenzhao/jissues/merges","archive_url":"https://api.github.com/repos/allenzhao/jissues/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allenzhao/jissues/downloads","issues_url":"https://api.github.com/repos/allenzhao/jissues/issues{/number}","pulls_url":"https://api.github.com/repos/allenzhao/jissues/pulls{/number}","milestones_url":"https://api.github.com/repos/allenzhao/jissues/milestones{/number}","notifications_url":"https://api.github.com/repos/allenzhao/jissues/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allenzhao/jissues/labels{/name}","releases_url":"https://api.github.com/repos/allenzhao/jissues/releases{/id}","created_at":"2014-02-23T01:52:05Z","updated_at":"2014-07-14T22:41:11Z","pushed_at":"2014-08-06T05:08:06Z","git_url":"git://github.com/allenzhao/jissues.git","ssh_url":"git@github.com:allenzhao/jissues.git","clone_url":"https://github.com/allenzhao/jissues.git","svn_url":"https://github.com/allenzhao/jissues","homepage":"https://plus.google.com/u/0/communities/102541713885101375024","size":10848,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"gsocdev"}},"base":{"label":"joomla:master","ref":"master","sha":"6db672cc6454b90c10f03be53a61e1a0a8425f52","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=2","gravatar_id":"ebafeb89560f7a68353d0ccc03fe79c7","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":6099080,"name":"jissues","full_name":"joomla/jissues","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=2","gravatar_id":"ebafeb89560f7a68353d0ccc03fe79c7","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/jissues","description":"Issue Tracking application integrating with GitHub to replace the existing Joomlacode solution.","fork":false,"url":"https://api.github.com/repos/joomla/jissues","forks_url":"https://api.github.com/repos/joomla/jissues/forks","keys_url":"https://api.github.com/repos/joomla/jissues/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/jissues/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/jissues/teams","hooks_url":"https://api.github.com/repos/joomla/jissues/hooks","issue_events_url":"https://api.github.com/repos/joomla/jissues/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/jissues/events","assignees_url":"https://api.github.com/repos/joomla/jissues/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/jissues/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/jissues/tags","blobs_url":"https://api.github.com/repos/joomla/jissues/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/jissues/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/jissues/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/jissues/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/jissues/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/jissues/languages","stargazers_url":"https://api.github.com/repos/joomla/jissues/stargazers","contributors_url":"https://api.github.com/repos/joomla/jissues/contributors","subscribers_url":"https://api.github.com/repos/joomla/jissues/subscribers","subscription_url":"https://api.github.com/repos/joomla/jissues/subscription","commits_url":"https://api.github.com/repos/joomla/jissues/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/jissues/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/jissues/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/jissues/issues/comments/{number}","contents_url":"https://api.github.com/repos/joomla/jissues/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/jissues/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/jissues/merges","archive_url":"https://api.github.com/repos/joomla/jissues/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/jissues/downloads","issues_url":"https://api.github.com/repos/joomla/jissues/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/jissues/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/jissues/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/jissues/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/jissues/labels{/name}","releases_url":"https://api.github.com/repos/joomla/jissues/releases{/id}","created_at":"2012-10-06T02:12:43Z","updated_at":"2014-06-30T14:17:59Z","pushed_at":"2014-08-04T23:33:28Z","git_url":"git://github.com/joomla/jissues.git","ssh_url":"git@github.com:joomla/jissues.git","clone_url":"https://github.com/joomla/jissues.git","svn_url":"https://github.com/joomla/jissues","homepage":"https://plus.google.com/u/0/communities/102541713885101375024","size":17901,"stargazers_count":47,"watchers_count":47,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":45,"mirror_url":null,"open_issues_count":59,"forks":45,"open_issues":59,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/jissues/pulls/409"},"html":{"href":"https://github.com/joomla/jissues/pull/409"},"issue":{"href":"https://api.github.com/repos/joomla/jissues/issues/409"},"comments":{"href":"https://api.github.com/repos/joomla/jissues/issues/409/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/jissues/pulls/409/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/jissues/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joomla/jissues/pulls/409/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/jissues/statuses/65522a1d7d9aef811829a99593c548315f5e7f33"}}}}