GitHub PullRequestEvent at 2014-06-19 02:32:47
Repository: ElectricalAge
Actor: Sukasa
Payload: {"action":"opened","number":44,"pull_request":{"url":"https://api.github.com/repos/Dolu1990/ElectricalAge/pulls/44","id":17330809,"html_url":"https://github.com/Dolu1990/ElectricalAge/pull/44","diff_url":"https://github.com/Dolu1990/ElectricalAge/pull/44.diff","patch_url":"https://github.com/Dolu1990/ElectricalAge/pull/44.patch","issue_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/issues/44","number":44,"state":"open","title":"Small bit of clarification to item constructors","user":{"login":"Sukasa","id":1186656,"avatar_url":"https://avatars.githubusercontent.com/u/1186656?","gravatar_id":"1b70a4a9eb6d1251337a00052a6fc5e0","url":"https://api.github.com/users/Sukasa","html_url":"https://github.com/Sukasa","followers_url":"https://api.github.com/users/Sukasa/followers","following_url":"https://api.github.com/users/Sukasa/following{/other_user}","gists_url":"https://api.github.com/users/Sukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Sukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sukasa/subscriptions","organizations_url":"https://api.github.com/users/Sukasa/orgs","repos_url":"https://api.github.com/users/Sukasa/repos","events_url":"https://api.github.com/users/Sukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Sukasa/received_events","type":"User","site_admin":false},"body":"Since I want to contribute, I figured I would start small with little bits of clean-up and clarification in the code, and then as I learn the codebase more I would like to see if I can reduce the amount of code copy-paste around and help to keep the number of bugs down as well as make it easier to add to the codebase in future.\r\n\r\nThis simply adds an explicit enum for armour type (boots, legging, etc) to help clean away the 'magic numbers' in some of the code.  If you are open to it, I would definitely like to do more as stated above.","created_at":"2014-06-19T02:32:46Z","updated_at":"2014-06-19T02:32:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/pulls/44/commits","review_comments_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/pulls/44/comments","review_comment_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/issues/44/comments","statuses_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/statuses/d79941b26756b4d5b5a3f2444a5d1741ceb30b3f","head":{"label":"Sukasa:1.7.2","ref":"1.7.2","sha":"d79941b26756b4d5b5a3f2444a5d1741ceb30b3f","user":{"login":"Sukasa","id":1186656,"avatar_url":"https://avatars.githubusercontent.com/u/1186656?","gravatar_id":"1b70a4a9eb6d1251337a00052a6fc5e0","url":"https://api.github.com/users/Sukasa","html_url":"https://github.com/Sukasa","followers_url":"https://api.github.com/users/Sukasa/followers","following_url":"https://api.github.com/users/Sukasa/following{/other_user}","gists_url":"https://api.github.com/users/Sukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Sukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sukasa/subscriptions","organizations_url":"https://api.github.com/users/Sukasa/orgs","repos_url":"https://api.github.com/users/Sukasa/repos","events_url":"https://api.github.com/users/Sukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Sukasa/received_events","type":"User","site_admin":false},"repo":{"id":20985055,"name":"ElectricalAge","full_name":"Sukasa/ElectricalAge","owner":{"login":"Sukasa","id":1186656,"avatar_url":"https://avatars.githubusercontent.com/u/1186656?","gravatar_id":"1b70a4a9eb6d1251337a00052a6fc5e0","url":"https://api.github.com/users/Sukasa","html_url":"https://github.com/Sukasa","followers_url":"https://api.github.com/users/Sukasa/followers","following_url":"https://api.github.com/users/Sukasa/following{/other_user}","gists_url":"https://api.github.com/users/Sukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Sukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sukasa/subscriptions","organizations_url":"https://api.github.com/users/Sukasa/orgs","repos_url":"https://api.github.com/users/Sukasa/repos","events_url":"https://api.github.com/users/Sukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Sukasa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sukasa/ElectricalAge","description":"Minecraft mod","fork":true,"url":"https://api.github.com/repos/Sukasa/ElectricalAge","forks_url":"https://api.github.com/repos/Sukasa/ElectricalAge/forks","keys_url":"https://api.github.com/repos/Sukasa/ElectricalAge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sukasa/ElectricalAge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sukasa/ElectricalAge/teams","hooks_url":"https://api.github.com/repos/Sukasa/ElectricalAge/hooks","issue_events_url":"https://api.github.com/repos/Sukasa/ElectricalAge/issues/events{/number}","events_url":"https://api.github.com/repos/Sukasa/ElectricalAge/events","assignees_url":"https://api.github.com/repos/Sukasa/ElectricalAge/assignees{/user}","branches_url":"https://api.github.com/repos/Sukasa/ElectricalAge/branches{/branch}","tags_url":"https://api.github.com/repos/Sukasa/ElectricalAge/tags","blobs_url":"https://api.github.com/repos/Sukasa/ElectricalAge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sukasa/ElectricalAge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sukasa/ElectricalAge/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sukasa/ElectricalAge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sukasa/ElectricalAge/statuses/{sha}","languages_url":"https://api.github.com/repos/Sukasa/ElectricalAge/languages","stargazers_url":"https://api.github.com/repos/Sukasa/ElectricalAge/stargazers","contributors_url":"https://api.github.com/repos/Sukasa/ElectricalAge/contributors","subscribers_url":"https://api.github.com/repos/Sukasa/ElectricalAge/subscribers","subscription_url":"https://api.github.com/repos/Sukasa/ElectricalAge/subscription","commits_url":"https://api.github.com/repos/Sukasa/ElectricalAge/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sukasa/ElectricalAge/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sukasa/ElectricalAge/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sukasa/ElectricalAge/issues/comments/{number}","contents_url":"https://api.github.com/repos/Sukasa/ElectricalAge/contents/{+path}","compare_url":"https://api.github.com/repos/Sukasa/ElectricalAge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sukasa/ElectricalAge/merges","archive_url":"https://api.github.com/repos/Sukasa/ElectricalAge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sukasa/ElectricalAge/downloads","issues_url":"https://api.github.com/repos/Sukasa/ElectricalAge/issues{/number}","pulls_url":"https://api.github.com/repos/Sukasa/ElectricalAge/pulls{/number}","milestones_url":"https://api.github.com/repos/Sukasa/ElectricalAge/milestones{/number}","notifications_url":"https://api.github.com/repos/Sukasa/ElectricalAge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sukasa/ElectricalAge/labels{/name}","releases_url":"https://api.github.com/repos/Sukasa/ElectricalAge/releases{/id}","created_at":"2014-06-19T02:29:42Z","updated_at":"2014-06-19T02:32:47Z","pushed_at":"2014-06-19T02:30:20Z","git_url":"git://github.com/Sukasa/ElectricalAge.git","ssh_url":"git@github.com:Sukasa/ElectricalAge.git","clone_url":"https://github.com/Sukasa/ElectricalAge.git","svn_url":"https://github.com/Sukasa/ElectricalAge","homepage":null,"size":69850,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.7.2"}},"base":{"label":"Dolu1990:1.7.2","ref":"1.7.2","sha":"6f10602987d3a43012a9867a030c7077a6272620","user":{"login":"Dolu1990","id":4832082,"avatar_url":"https://avatars.githubusercontent.com/u/4832082?","gravatar_id":"337b71079e721019935020b73770e141","url":"https://api.github.com/users/Dolu1990","html_url":"https://github.com/Dolu1990","followers_url":"https://api.github.com/users/Dolu1990/followers","following_url":"https://api.github.com/users/Dolu1990/following{/other_user}","gists_url":"https://api.github.com/users/Dolu1990/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolu1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolu1990/subscriptions","organizations_url":"https://api.github.com/users/Dolu1990/orgs","repos_url":"https://api.github.com/users/Dolu1990/repos","events_url":"https://api.github.com/users/Dolu1990/events{/privacy}","received_events_url":"https://api.github.com/users/Dolu1990/received_events","type":"User","site_admin":false},"repo":{"id":11009533,"name":"ElectricalAge","full_name":"Dolu1990/ElectricalAge","owner":{"login":"Dolu1990","id":4832082,"avatar_url":"https://avatars.githubusercontent.com/u/4832082?","gravatar_id":"337b71079e721019935020b73770e141","url":"https://api.github.com/users/Dolu1990","html_url":"https://github.com/Dolu1990","followers_url":"https://api.github.com/users/Dolu1990/followers","following_url":"https://api.github.com/users/Dolu1990/following{/other_user}","gists_url":"https://api.github.com/users/Dolu1990/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolu1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolu1990/subscriptions","organizations_url":"https://api.github.com/users/Dolu1990/orgs","repos_url":"https://api.github.com/users/Dolu1990/repos","events_url":"https://api.github.com/users/Dolu1990/events{/privacy}","received_events_url":"https://api.github.com/users/Dolu1990/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dolu1990/ElectricalAge","description":"Minecraft mod","fork":false,"url":"https://api.github.com/repos/Dolu1990/ElectricalAge","forks_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/forks","keys_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/teams","hooks_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/hooks","issue_events_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/issues/events{/number}","events_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/events","assignees_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/assignees{/user}","branches_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/branches{/branch}","tags_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/tags","blobs_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/statuses/{sha}","languages_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/languages","stargazers_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/stargazers","contributors_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/contributors","subscribers_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/subscribers","subscription_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/subscription","commits_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/issues/comments/{number}","contents_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/contents/{+path}","compare_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/merges","archive_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/downloads","issues_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/issues{/number}","pulls_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/pulls{/number}","milestones_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/milestones{/number}","notifications_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/labels{/name}","releases_url":"https://api.github.com/repos/Dolu1990/ElectricalAge/releases{/id}","created_at":"2013-06-27T22:26:06Z","updated_at":"2014-06-18T21:02:30Z","pushed_at":"2014-06-18T14:15:35Z","git_url":"git://github.com/Dolu1990/ElectricalAge.git","ssh_url":"git@github.com:Dolu1990/ElectricalAge.git","clone_url":"https://github.com/Dolu1990/ElectricalAge.git","svn_url":"https://github.com/Dolu1990/ElectricalAge","homepage":null,"size":69850,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":11,"forks":4,"open_issues":11,"watchers":8,"default_branch":"1.7.2"}},"_links":{"self":{"href":"https://api.github.com/repos/Dolu1990/ElectricalAge/pulls/44"},"html":{"href":"https://github.com/Dolu1990/ElectricalAge/pull/44"},"issue":{"href":"https://api.github.com/repos/Dolu1990/ElectricalAge/issues/44"},"comments":{"href":"https://api.github.com/repos/Dolu1990/ElectricalAge/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/Dolu1990/ElectricalAge/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/Dolu1990/ElectricalAge/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Dolu1990/ElectricalAge/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/Dolu1990/ElectricalAge/statuses/d79941b26756b4d5b5a3f2444a5d1741ceb30b3f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":39,"deletions":21,"changed_files":3}}