GitHub PullRequestReviewCommentEvent at 2014-02-27 15:53:39
Repository: traitsui
Actor: rkern
Payload: {"comment":{"url":"https://api.github.com/repos/enthought/traitsui/pulls/comments/10128189","id":10128189,"diff_hunk":"@@ -239,11 +239,15 @@ def add_button ( self, action, bbox, role, method=None, enabled=True,\n \n         return button\n \n-    def _on_help(self):\n+    def _on_help(self, event=None):\n         \"\"\"Handles the user clicking the Help button.\n         \"\"\"\n-        # FIXME: Needs porting to PyQt.\n-        self.ui.handler.show_help(self.ui.info, event.GetEventObject())\n+        # FIXME: Needs porting to PyQt.  \n+        if event:\n+            control = event.GetEventObject()","path":"traitsui/qt4/ui_base.py","position":12,"original_position":12,"commit_id":"15cd2f245b5f1076d2f9cf69c5fc8f6af9667c96","original_commit_id":"15cd2f245b5f1076d2f9cf69c5fc8f6af9667c96","user":{"login":"rkern","id":46135,"avatar_url":"https://avatars.githubusercontent.com/u/46135","gravatar_id":"764323a14e554c97ab74177e0bce51d4","url":"https://api.github.com/users/rkern","html_url":"https://github.com/rkern","followers_url":"https://api.github.com/users/rkern/followers","following_url":"https://api.github.com/users/rkern/following{/other_user}","gists_url":"https://api.github.com/users/rkern/gists{/gist_id}","starred_url":"https://api.github.com/users/rkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkern/subscriptions","organizations_url":"https://api.github.com/users/rkern/orgs","repos_url":"https://api.github.com/users/rkern/repos","events_url":"https://api.github.com/users/rkern/events{/privacy}","received_events_url":"https://api.github.com/users/rkern/received_events","type":"User","site_admin":false},"body":"The `GetEventObject` is a wx-ism, hence the comment about porting to PyQt before it. Much of the initial porting effort was simple copy-paste with fixups that followed.\r\n\r\nDoes this `_on_help()` method *ever* get passed an event object? If so, then we need to process it correctly. If not, then we can just remove the argument entirely.","created_at":"2014-02-27T15:53:39Z","updated_at":"2014-02-27T15:53:39Z","html_url":"https://github.com/enthought/traitsui/pull/160#discussion_r10128189","pull_request_url":"https://api.github.com/repos/enthought/traitsui/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/enthought/traitsui/pulls/comments/10128189"},"html":{"href":"https://github.com/enthought/traitsui/pull/160#discussion_r10128189"},"pull_request":{"href":"https://api.github.com/repos/enthought/traitsui/pulls/160"}}}}