GitHub PullRequestReviewCommentEvent at 2014-10-07 17:16:43
Repository: wf-uicomponents
Actor: davidmarne-wf
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls/comments/18534115","id":18534115,"diff_hunk":"@@ -295,8 +281,13 @@ define(function(require) {\n             }\n \n             // Let this release event play out before scrolling.\n+            var done = function () {\n+                scrollList.onScrollToItemFinished.dispatch();\n+            };\n+\n             setTimeout(function() {\n-                scrollList.scrollToItem({ index: itemIndex, duration: 250 });\n+                scrollList.onScrollToItemStarted.dispatch();","path":"src/scroll_list/PeekInterceptor.js","position":null,"original_position":37,"commit_id":"b168944a06761d13b20c1e95de7b3c4d054ffb40","original_commit_id":"a9207f702cd171548ae0a0613e41803ece491e67","user":{"login":"davidmarne-wf","id":7361956,"avatar_url":"https://avatars.githubusercontent.com/u/7361956?v=2","gravatar_id":"","url":"https://api.github.com/users/davidmarne-wf","html_url":"https://github.com/davidmarne-wf","followers_url":"https://api.github.com/users/davidmarne-wf/followers","following_url":"https://api.github.com/users/davidmarne-wf/following{/other_user}","gists_url":"https://api.github.com/users/davidmarne-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmarne-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmarne-wf/subscriptions","organizations_url":"https://api.github.com/users/davidmarne-wf/orgs","repos_url":"https://api.github.com/users/davidmarne-wf/repos","events_url":"https://api.github.com/users/davidmarne-wf/events{/privacy}","received_events_url":"https://api.github.com/users/davidmarne-wf/received_events","type":"User","site_admin":false},"body":"Very true, moved","created_at":"2014-10-07T17:16:43Z","updated_at":"2014-10-07T17:16:43Z","html_url":"https://github.com/Workiva/wf-uicomponents/pull/98#discussion_r18534115","pull_request_url":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls/comments/18534115"},"html":{"href":"https://github.com/Workiva/wf-uicomponents/pull/98#discussion_r18534115"},"pull_request":{"href":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls/98","id":22314238,"html_url":"https://github.com/Workiva/wf-uicomponents/pull/98","diff_url":"https://github.com/Workiva/wf-uicomponents/pull/98.diff","patch_url":"https://github.com/Workiva/wf-uicomponents/pull/98.patch","issue_url":"https://api.github.com/repos/Workiva/wf-uicomponents/issues/98","number":98,"state":"open","locked":false,"title":"UIComponents changes for HYDRA-706","user":{"login":"davidmarne-wf","id":7361956,"avatar_url":"https://avatars.githubusercontent.com/u/7361956?v=2","gravatar_id":"","url":"https://api.github.com/users/davidmarne-wf","html_url":"https://github.com/davidmarne-wf","followers_url":"https://api.github.com/users/davidmarne-wf/followers","following_url":"https://api.github.com/users/davidmarne-wf/following{/other_user}","gists_url":"https://api.github.com/users/davidmarne-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmarne-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmarne-wf/subscriptions","organizations_url":"https://api.github.com/users/davidmarne-wf/orgs","repos_url":"https://api.github.com/users/davidmarne-wf/repos","events_url":"https://api.github.com/users/davidmarne-wf/events{/privacy}","received_events_url":"https://api.github.com/users/davidmarne-wf/received_events","type":"User","site_admin":false},"body":"### What I Did\r\nAdded events for onScrollToItem so when the peek interceptor tells a page to snap we can disable zoom canvas until the snap animation is done.\r\nI also removed a check in the peek interceptor that caused the page to automatically snap when a direction changed happens while dragging\r\n\r\n### How to test\r\nThe events can be tested along with HYDRA-706, however one can test the direction change issue by doing the following\r\nclone wf-uicomponents and checkout this branch\r\ncd pdf_client_services/viewer/bower_components\r\nrm -rf wf-uicomponents\r\nln -s ~/path/to/clone/of/wf-uicomponents\r\nrm -rf wf-js-viewer\r\nln -s ~/path/to/clone/of/wf-js-viewer\r\ncd pdf_client_services\r\nnode run path/to/doc.pdf\r\nnpm start\r\n\r\nAssure you can drag up and down all during the same gesture (without picking up your finger) without the page snapping\r\n\r\nScreencasts:\r\nBefore:\r\nhttp://www.screencast.com/t/H1554gpPJF\r\nAfter:\r\nhttp://www.screencast.com/t/3g784aiG","created_at":"2014-10-06T21:06:52Z","updated_at":"2014-10-07T17:16:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77d772d2e00783bcf854796402615b7721cd3bae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls/98/commits","review_comments_url":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls/98/comments","review_comment_url":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Workiva/wf-uicomponents/issues/98/comments","statuses_url":"https://api.github.com/repos/Workiva/wf-uicomponents/statuses/b168944a06761d13b20c1e95de7b3c4d054ffb40","head":{"label":"Workiva:HYDRA-706_ui_components","ref":"HYDRA-706_ui_components","sha":"b168944a06761d13b20c1e95de7b3c4d054ffb40","user":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=2","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":15975978,"name":"wf-uicomponents","full_name":"Workiva/wf-uicomponents","owner":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=2","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/wf-uicomponents","description":"","fork":false,"url":"https://api.github.com/repos/Workiva/wf-uicomponents","forks_url":"https://api.github.com/repos/Workiva/wf-uicomponents/forks","keys_url":"https://api.github.com/repos/Workiva/wf-uicomponents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/wf-uicomponents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/wf-uicomponents/teams","hooks_url":"https://api.github.com/repos/Workiva/wf-uicomponents/hooks","issue_events_url":"https://api.github.com/repos/Workiva/wf-uicomponents/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/wf-uicomponents/events","assignees_url":"https://api.github.com/repos/Workiva/wf-uicomponents/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/wf-uicomponents/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/wf-uicomponents/tags","blobs_url":"https://api.github.com/repos/Workiva/wf-uicomponents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/wf-uicomponents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/wf-uicomponents/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/wf-uicomponents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/wf-uicomponents/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/wf-uicomponents/languages","stargazers_url":"https://api.github.com/repos/Workiva/wf-uicomponents/stargazers","contributors_url":"https://api.github.com/repos/Workiva/wf-uicomponents/contributors","subscribers_url":"https://api.github.com/repos/Workiva/wf-uicomponents/subscribers","subscription_url":"https://api.github.com/repos/Workiva/wf-uicomponents/subscription","commits_url":"https://api.github.com/repos/Workiva/wf-uicomponents/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/wf-uicomponents/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/wf-uicomponents/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/wf-uicomponents/issues/comments/{number}","contents_url":"https://api.github.com/repos/Workiva/wf-uicomponents/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/wf-uicomponents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/wf-uicomponents/merges","archive_url":"https://api.github.com/repos/Workiva/wf-uicomponents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/wf-uicomponents/downloads","issues_url":"https://api.github.com/repos/Workiva/wf-uicomponents/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/wf-uicomponents/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/wf-uicomponents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/wf-uicomponents/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/wf-uicomponents/releases{/id}","created_at":"2014-01-16T17:54:42Z","updated_at":"2014-10-01T10:05:20Z","pushed_at":"2014-10-07T17:16:21Z","git_url":"git://github.com/Workiva/wf-uicomponents.git","ssh_url":"git@github.com:Workiva/wf-uicomponents.git","clone_url":"https://github.com/Workiva/wf-uicomponents.git","svn_url":"https://github.com/Workiva/wf-uicomponents","homepage":null,"size":4518,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":10,"default_branch":"master"}},"base":{"label":"Workiva:master","ref":"master","sha":"7bd4f5e80d65c7dbfce8c7d01ea1fe84426839b7","user":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=2","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":15975978,"name":"wf-uicomponents","full_name":"Workiva/wf-uicomponents","owner":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=2","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/wf-uicomponents","description":"","fork":false,"url":"https://api.github.com/repos/Workiva/wf-uicomponents","forks_url":"https://api.github.com/repos/Workiva/wf-uicomponents/forks","keys_url":"https://api.github.com/repos/Workiva/wf-uicomponents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/wf-uicomponents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/wf-uicomponents/teams","hooks_url":"https://api.github.com/repos/Workiva/wf-uicomponents/hooks","issue_events_url":"https://api.github.com/repos/Workiva/wf-uicomponents/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/wf-uicomponents/events","assignees_url":"https://api.github.com/repos/Workiva/wf-uicomponents/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/wf-uicomponents/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/wf-uicomponents/tags","blobs_url":"https://api.github.com/repos/Workiva/wf-uicomponents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/wf-uicomponents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/wf-uicomponents/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/wf-uicomponents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/wf-uicomponents/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/wf-uicomponents/languages","stargazers_url":"https://api.github.com/repos/Workiva/wf-uicomponents/stargazers","contributors_url":"https://api.github.com/repos/Workiva/wf-uicomponents/contributors","subscribers_url":"https://api.github.com/repos/Workiva/wf-uicomponents/subscribers","subscription_url":"https://api.github.com/repos/Workiva/wf-uicomponents/subscription","commits_url":"https://api.github.com/repos/Workiva/wf-uicomponents/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/wf-uicomponents/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/wf-uicomponents/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/wf-uicomponents/issues/comments/{number}","contents_url":"https://api.github.com/repos/Workiva/wf-uicomponents/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/wf-uicomponents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/wf-uicomponents/merges","archive_url":"https://api.github.com/repos/Workiva/wf-uicomponents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/wf-uicomponents/downloads","issues_url":"https://api.github.com/repos/Workiva/wf-uicomponents/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/wf-uicomponents/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/wf-uicomponents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/wf-uicomponents/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/wf-uicomponents/releases{/id}","created_at":"2014-01-16T17:54:42Z","updated_at":"2014-10-01T10:05:20Z","pushed_at":"2014-10-07T17:16:21Z","git_url":"git://github.com/Workiva/wf-uicomponents.git","ssh_url":"git@github.com:Workiva/wf-uicomponents.git","clone_url":"https://github.com/Workiva/wf-uicomponents.git","svn_url":"https://github.com/Workiva/wf-uicomponents","homepage":null,"size":4518,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls/98"},"html":{"href":"https://github.com/Workiva/wf-uicomponents/pull/98"},"issue":{"href":"https://api.github.com/repos/Workiva/wf-uicomponents/issues/98"},"comments":{"href":"https://api.github.com/repos/Workiva/wf-uicomponents/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Workiva/wf-uicomponents/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/Workiva/wf-uicomponents/statuses/b168944a06761d13b20c1e95de7b3c4d054ffb40"}}}}