GitHub PushEvent at 2014-02-14 16:12:23
Repository: chromium
Actor: tzik
Payload: {"shas":[["0b4731f8b49724c2f389921c4faae26f352f180c","3d0f2e86506506a556fde7597408f9d8669cd6bf@chromium.org","Rename ServiceConnector back to ServiceManager\n\nBUG=None\nTEST=None\nTBR=darin\n\nReview URL: https://codereview.chromium.org/164313002\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251111 0039d316-1c4b-4281-b951-d872f2087c98","davemoore@chromium.org",false],["a5fc73eec17220fb061c6dbbcc36846f386d9bcb","56f4ff77fb104e6bf8288e1b5bf18c980417b664@chromium.org","Revert 251094 \"Revert 250826 \"Remove Profile dependency from app...\"\n\nSpeculative re-land. Sync tests are passing now, but we're not sure\nwhich revert fixed them. Let's see if this makes the tree red again\nor not.\n\n> Revert 250826 \"Remove Profile dependency from apps::ShellWindow\"\n> \n> Speculative revert for failures:\n> \n> http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201\n> \n> > Remove Profile dependency from apps::ShellWindow\n> > \n> > Part of the effort to remove src/chrome dependencies from src/{apps, extensions}\n> > \n> > BUG=341690\n> > TBR=tapted@chromium.org,stevenjb@chromium.org\n> > \n> > Review URL: https://codereview.chromium.org/157813007\n> \n> TBR=rockot@chromium.org\n> \n> Review URL: https://codereview.chromium.org/163913004\n\nTBR=asvitkine@chromium.org\n\nReview URL: https://codereview.chromium.org/164613002\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251112 0039d316-1c4b-4281-b951-d872f2087c98","asvitkine@chromium.org",false],["e3eac422c0cd5db311a567e6137c073b73d9bfaa","5ee0edb9e2229c0838f1959779f1949031de0123@chromium.org","Revert 250967 \"Revert of [sync]: add ManagedUserSigninManagerWra...\"\n\n> Revert of [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService (https://codereview.chromium.org/137753012/)\n> \n> Reason for revert:\n> Possible build bustage on Win64.\n> \n> Original issue's description:\n> > [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService\n> > \n> > BUG=80194\n> > \n> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250814\n> \n> TBR=bauerb@chromium.org,rogerta@chromium.org,pavely@chromium.org\n> NOTREECHECKS=true\n> NOTRY=true\n> BUG=80194\n> \n> Review URL: https://codereview.chromium.org/162943002\n\nTBR=tim@chromium.org\n\nReview URL: https://codereview.chromium.org/163983005\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251114 0039d316-1c4b-4281-b951-d872f2087c98","tim@chromium.org",false],["1477ef4c522c910b5f1933f6ebf095e8d9f4d8d7","03425f25694f7f064e7dac10b215ca984b0e586b@chromium.org","Mojo: Make a public test_support shared library.\n\nThe test runner can then inject dependencies into it (just as we do for\nsystem and gles2).\n\nThis removes public/tests's base dependency.\n\nR=sky@chromium.org\n\nReview URL: https://codereview.chromium.org/160003007\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251115 0039d316-1c4b-4281-b951-d872f2087c98","viettrungluu@chromium.org",false],["9d337bc7383bef4366f949b08867ba4fa9b874a9","9eae700b126882548d7c35b49948977d42cb6d0e@chromium.org","Clean up dependencies for disk_cache histogram_macros.h.\n\nThe current mechanism by which these convenience macros find their\nbackend is confusing, at best; the macro has the form of our include\nguard macros, but describes a CC file. Embedded within the\nhistogram_macros.h then is an abstraction violation: it just knows\nwhich object has backend information depending on which file it was\nincluded from.\n\nSome downstream reviews have made this even more confusing; rather\nthan continue this, let's parameterize the backend object to the\nconvenience macros, so each translation unit is responsible for\nknowing its own context.\n\nR=mmenke@chromium.org, rvargas@chromium.org\nTBR=mmenke@chromium.org\nBUG=None\n\nReview URL: https://codereview.chromium.org/140893013\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251116 0039d316-1c4b-4281-b951-d872f2087c98","gavinp@chromium.org",false],["8574f3799570d32195eee8c4caa682f9dd9318cd","f87f6765869c7c92d898c99d47c97b4eb8053dae@chromium.org","Roll V8 back to version 3.24.35.\n\nR=danno@chromium.org\n\nReview URL: https://codereview.chromium.org/164593002\n\nPatch from Michael Starzinger <mstarzinger@chromium.org>.\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251119 0039d316-1c4b-4281-b951-d872f2087c98","danno@chromium.org",false],["06a9e16c718e2358e395ec77d13175972439ad12","8f80f660b944b36f84ea34aafca49e94791e330f@google.com","Update .DEPS.git\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251120 0039d316-1c4b-4281-b951-d872f2087c98","chrome-admin@google.com",false],["0a48ae827b6c59c1a2ccfd5c72b535fc9ab3ad73","f8c74e3b858acfee0062c38a452f1a29b8635085@chromium.org","Remove references to TestingProfile from password store unit tests.\n\nBUG=334665\n\nReview URL: https://codereview.chromium.org/160463002\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251122 0039d316-1c4b-4281-b951-d872f2087c98","dubroy@chromium.org",false],["d20047855420a541542823876c0ca30dbe5ccf14","db97f61d07c31fd69698b8602ab9b0e934f96b23@chromium.org","cros: Add SAML redirect banner for enrollment.\n\nBUG=334624\n\nReview URL: https://codereview.chromium.org/130813009\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251123 0039d316-1c4b-4281-b951-d872f2087c98","xiyuan@chromium.org",false],["7793ba70c773bdd08d6ed6b8b051f439343cfdb6","348b1b6801801c3d890b2e1589a8e36441d09fdc@chromium.org","Re-enable prerender_page_with_link tests.\n\nRework the wait functions to use a TestNavigationObserver (waits for\nDidStopLoading) rather than the commit, to avoid potential flakiness where the\nload is still progressing. (prerender_loader_with_session_storage.html only\nupdates sessionStorage.counter at onload.)\n\nBUG=249179,121130\n\nReview URL: https://codereview.chromium.org/161323002\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251124 0039d316-1c4b-4281-b951-d872f2087c98","davidben@chromium.org",false],["d36a2ac7e11b57719587881008d822f949bc9afc","ef9c8b62e4b79d0ca1962c14411c987d8ed320be@chromium.org","OneClickSigninHelper::CanOffer checks IsEnableWebBasedSignin\n\nBefore, the CanOffer method could return true, while the web based signin was disabled through about:flags. This meant that neither the save password prompt, nor the sign-in interstitial were shown.\n\nThis CL ensures that CanOffer returns false if the web based signing is disabled in about:flags.\n\nBUG=339804\n\nReview URL: https://codereview.chromium.org/160363002\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251125 0039d316-1c4b-4281-b951-d872f2087c98","vabr@chromium.org",false],["f1ccb86565dcdd1523fa5fdc0a2f273cc4e9cb9f","260f5074942ca36dab941199ff6b19fcaa26ccde@chromium.org","Revise user-data-dir switch handling; avoid crashes.\n\nChrome needs a pre-existing or creatable user-data-dir to run.\nChromeMainDelegate::PreSandboxStartup was CHECK'ing for this.\n(crashing on startup with --user-data-dir=\"M:\\invalid\")\n(crashing on startup with --user-data-dir=\"C:\\windows\")\n\nSupposedly, we had a dialog to let users choose another dir.\n(I've never gotten this to work on M28-M32 stable versions)\n\nRevise the user-data-dir code to warn on invalid paths.\n(see crbug.com/318999#c18 for the warning screenshot)\nThen attempt to use the default directory as a backup.\n(no alternate dir selection UI, users can try again)\n\nThis should avoid many of the numerous related crashes.\n\nBUG=318999\nTEST=Supplying an invalid --user-data-dir=<path> will warn users and attempt to use the default directory instead of silently crashing.\nR=sky@chromium.org\n\nReview URL: https://codereview.chromium.org/123693003\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251126 0039d316-1c4b-4281-b951-d872f2087c98","msw@chromium.org",false],["d73094483607f852e13b7e909beb8f5141a34db9","03b08926e49d80331ab322c2b9e0332109fbfd39@chromium.org","cc: add more devtools instrumentation\n\nThis adds didRequestMainThreadFrame() and didDrawFrame() so we can better\ntrack impl-side frame lifecycle in DevTools\n\nR=danakj, nduca\n\nReview URL: https://codereview.chromium.org/144463016\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251127 0039d316-1c4b-4281-b951-d872f2087c98","caseq@chromium.org",false],["92339b8f56474a4a4f4cac32b508689425a6a3a3","e0ecec33d035b5d152e4f1b2095cff786e4e5e4f@chromium.org","Use the new animation tween types to improve the animation effects for app list folder operation.\n\nBUG=342832\n\nReview URL: https://codereview.chromium.org/162363002\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251128 0039d316-1c4b-4281-b951-d872f2087c98","jennyz@chromium.org",false],["29e871c3fd942e586096f192c5b2a814d63df5ae","e9f353807ebc85a9b7242a049c584f6ec9c16bff@chromium.org","Fix misspelling of notifications.\n\nBUG=NONE\n\nReview URL: https://codereview.chromium.org/161173004\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251130 0039d316-1c4b-4281-b951-d872f2087c98","koss@chromium.org",false],["c55275523a10864086ef2d3ae639c40f70637e7c","abf96d2b3281e948693e472f328c90c97b1ff409@chromium.org","Add method GetKeyFromSystem to WiFiService on Windows and Mac.\n\nBUG=328960\n\nReview URL: https://codereview.chromium.org/156943002\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251131 0039d316-1c4b-4281-b951-d872f2087c98","mef@chromium.org",false],["6f3ac60a0cad4ec72854ff1c2224c607eae01a3b","348b1b6801801c3d890b2e1589a8e36441d09fdc@chromium.org","Do not trigger CrossSiteResourceHandler for streams or user certs.\n\nWhen a resource request gets pre-empted in favor of either a stream or user\ncertificate installation, do not trigger CrossSiteResourceHandler behavior.\n\nAdd a regression test to ensure the DCHECK does not fire.\n\nBUG=342999\n\nReview URL: https://codereview.chromium.org/161003002\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251132 0039d316-1c4b-4281-b951-d872f2087c98","davidben@chromium.org",false],["951a7e9c7844f5bd019960e19a08522d258975b6","3f91fd28d7148db0bd254a9250e975013257c6dd@chromium.org","Makes the hint text darker for lower rows.\n\n\nBUG=332073\n\nReview URL: https://codereview.chromium.org/163413006\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251133 0039d316-1c4b-4281-b951-d872f2087c98","rsadam@chromium.org",false],["47b779fca8a5b22ec61e2469d14c33c9cd5bf86c","56f4ff77fb104e6bf8288e1b5bf18c980417b664@chromium.org","Revert 251095 \"Revert 250828 \"Add a UMA stat to track if the Bro...\"\n\nSpeculative re-land to see if this causes sync tests failures again.\nIf it does, then we will know if this is the cause.\n\n> Revert 250828 \"Add a UMA stat to track if the Browser blacklist ...\"\n> \n> Speculative revert for failures here:\n> \n> http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201\n> \n> > Add a UMA stat to track if the Browser blacklist is Set on the Renderer\n> > \n> > This shouldn't be happening, but we got some crash reports suggesting it\n> > does. Unable to repo locally so this stat will verify it does occur and\n> > then can be used to verify our fixes actually fix it.\n> > \n> > BUG=329023\n> > \n> > Review URL: https://codereview.chromium.org/140763008\n> \n> TBR=csharp@chromium.org\n> \n> Review URL: https://codereview.chromium.org/163633005\n\nTBR=asvitkine@chromium.org\n\nReview URL: https://codereview.chromium.org/164833002\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251134 0039d316-1c4b-4281-b951-d872f2087c98","asvitkine@chromium.org",false],["9eba93a294ccc08160be066c011f90bcae07bc00","c6f220a65156364bb8ada719a685abd37e55ac4e@chromium.org","[GCM] Add basic collapse key support for upstream\n\nMessages are collapsed based on app + token as long as they have not\nbeen sent over the wire yet. If messages are resent (because original send\nfailed for some reason) no collapsing is done at this point in time.\n\nBUG=284553\n\nReview URL: https://codereview.chromium.org/148293002\n\ngit-svn-id: svn://svn.chromium.org/chrome/trunk/src@251135 0039d316-1c4b-4281-b951-d872f2087c98","zea@chromium.org",false]],"size":133,"ref":"refs/heads/lkgr","head":"c7df30c5fe7ccc402de05cdf745e08c97e9d4b57"}