GitHub PullRequestEvent at 2014-06-23 19:45:12
Repository: secureheaders
Actor: oreoshake
Payload: {"action":"closed","number":93,"pull_request":{"url":"https://api.github.com/repos/twitter/secureheaders/pulls/93","id":17432522,"html_url":"https://github.com/twitter/secureheaders/pull/93","diff_url":"https://github.com/twitter/secureheaders/pull/93.diff","patch_url":"https://github.com/twitter/secureheaders/pull/93.patch","issue_url":"https://api.github.com/repos/twitter/secureheaders/issues/93","number":93,"state":"closed","title":"Implemented Padrino hook in a more Padrino way","user":{"login":"dariocravero","id":376268,"avatar_url":"https://avatars.githubusercontent.com/u/376268?","gravatar_id":"7e6dfcf7994a368f5b5b2b1356c0daa3","url":"https://api.github.com/users/dariocravero","html_url":"https://github.com/dariocravero","followers_url":"https://api.github.com/users/dariocravero/followers","following_url":"https://api.github.com/users/dariocravero/following{/other_user}","gists_url":"https://api.github.com/users/dariocravero/gists{/gist_id}","starred_url":"https://api.github.com/users/dariocravero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dariocravero/subscriptions","organizations_url":"https://api.github.com/users/dariocravero/orgs","repos_url":"https://api.github.com/users/dariocravero/repos","events_url":"https://api.github.com/users/dariocravero/events{/privacy}","received_events_url":"https://api.github.com/users/dariocravero/received_events","type":"User","site_admin":false},"body":"Hi guys,\r\n\r\nFirst of all, thanks a million for having a Padrino example in place :). Much appreciated!! I was reviewing our plugin requests and spotted one for `secureheaders` padrino/padrino-recipes#46 (ref padrino/padrino-framework#1048), so I came around your gem and found that we could make the integration a bit more Padrino style.\r\nThis PR implements a register hook closer to the way we load most gems. It also hints that the configuration should be moved towards `before_load` in `config/boot.rb`.\r\n\r\nWhat do you think about that?\r\nThanks, :)\r\nDarío\r\n\r\n/cc @postmodern @achiu","created_at":"2014-06-20T23:13:13Z","updated_at":"2014-06-23T19:45:12Z","closed_at":"2014-06-23T19:45:12Z","merged_at":null,"merge_commit_sha":"40c8af5f0b076ebd3330bccd389f341f8214ae5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/secureheaders/pulls/93/commits","review_comments_url":"https://api.github.com/repos/twitter/secureheaders/pulls/93/comments","review_comment_url":"https://api.github.com/repos/twitter/secureheaders/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twitter/secureheaders/issues/93/comments","statuses_url":"https://api.github.com/repos/twitter/secureheaders/statuses/7c481b3314b461d9c609dc992e7127e0ab59fcba","head":{"label":"dariocravero:master","ref":"master","sha":"7c481b3314b461d9c609dc992e7127e0ab59fcba","user":{"login":"dariocravero","id":376268,"avatar_url":"https://avatars.githubusercontent.com/u/376268?","gravatar_id":"7e6dfcf7994a368f5b5b2b1356c0daa3","url":"https://api.github.com/users/dariocravero","html_url":"https://github.com/dariocravero","followers_url":"https://api.github.com/users/dariocravero/followers","following_url":"https://api.github.com/users/dariocravero/following{/other_user}","gists_url":"https://api.github.com/users/dariocravero/gists{/gist_id}","starred_url":"https://api.github.com/users/dariocravero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dariocravero/subscriptions","organizations_url":"https://api.github.com/users/dariocravero/orgs","repos_url":"https://api.github.com/users/dariocravero/repos","events_url":"https://api.github.com/users/dariocravero/events{/privacy}","received_events_url":"https://api.github.com/users/dariocravero/received_events","type":"User","site_admin":false},"repo":{"id":21054661,"name":"secureheaders","full_name":"dariocravero/secureheaders","owner":{"login":"dariocravero","id":376268,"avatar_url":"https://avatars.githubusercontent.com/u/376268?","gravatar_id":"7e6dfcf7994a368f5b5b2b1356c0daa3","url":"https://api.github.com/users/dariocravero","html_url":"https://github.com/dariocravero","followers_url":"https://api.github.com/users/dariocravero/followers","following_url":"https://api.github.com/users/dariocravero/following{/other_user}","gists_url":"https://api.github.com/users/dariocravero/gists{/gist_id}","starred_url":"https://api.github.com/users/dariocravero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dariocravero/subscriptions","organizations_url":"https://api.github.com/users/dariocravero/orgs","repos_url":"https://api.github.com/users/dariocravero/repos","events_url":"https://api.github.com/users/dariocravero/events{/privacy}","received_events_url":"https://api.github.com/users/dariocravero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dariocravero/secureheaders","description":"Security related headers all in one gem","fork":true,"url":"https://api.github.com/repos/dariocravero/secureheaders","forks_url":"https://api.github.com/repos/dariocravero/secureheaders/forks","keys_url":"https://api.github.com/repos/dariocravero/secureheaders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dariocravero/secureheaders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dariocravero/secureheaders/teams","hooks_url":"https://api.github.com/repos/dariocravero/secureheaders/hooks","issue_events_url":"https://api.github.com/repos/dariocravero/secureheaders/issues/events{/number}","events_url":"https://api.github.com/repos/dariocravero/secureheaders/events","assignees_url":"https://api.github.com/repos/dariocravero/secureheaders/assignees{/user}","branches_url":"https://api.github.com/repos/dariocravero/secureheaders/branches{/branch}","tags_url":"https://api.github.com/repos/dariocravero/secureheaders/tags","blobs_url":"https://api.github.com/repos/dariocravero/secureheaders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dariocravero/secureheaders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dariocravero/secureheaders/git/refs{/sha}","trees_url":"https://api.github.com/repos/dariocravero/secureheaders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dariocravero/secureheaders/statuses/{sha}","languages_url":"https://api.github.com/repos/dariocravero/secureheaders/languages","stargazers_url":"https://api.github.com/repos/dariocravero/secureheaders/stargazers","contributors_url":"https://api.github.com/repos/dariocravero/secureheaders/contributors","subscribers_url":"https://api.github.com/repos/dariocravero/secureheaders/subscribers","subscription_url":"https://api.github.com/repos/dariocravero/secureheaders/subscription","commits_url":"https://api.github.com/repos/dariocravero/secureheaders/commits{/sha}","git_commits_url":"https://api.github.com/repos/dariocravero/secureheaders/git/commits{/sha}","comments_url":"https://api.github.com/repos/dariocravero/secureheaders/comments{/number}","issue_comment_url":"https://api.github.com/repos/dariocravero/secureheaders/issues/comments/{number}","contents_url":"https://api.github.com/repos/dariocravero/secureheaders/contents/{+path}","compare_url":"https://api.github.com/repos/dariocravero/secureheaders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dariocravero/secureheaders/merges","archive_url":"https://api.github.com/repos/dariocravero/secureheaders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dariocravero/secureheaders/downloads","issues_url":"https://api.github.com/repos/dariocravero/secureheaders/issues{/number}","pulls_url":"https://api.github.com/repos/dariocravero/secureheaders/pulls{/number}","milestones_url":"https://api.github.com/repos/dariocravero/secureheaders/milestones{/number}","notifications_url":"https://api.github.com/repos/dariocravero/secureheaders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dariocravero/secureheaders/labels{/name}","releases_url":"https://api.github.com/repos/dariocravero/secureheaders/releases{/id}","created_at":"2014-06-20T22:42:06Z","updated_at":"2014-06-23T19:45:12Z","pushed_at":"2014-06-20T23:08:07Z","git_url":"git://github.com/dariocravero/secureheaders.git","ssh_url":"git@github.com:dariocravero/secureheaders.git","clone_url":"https://github.com/dariocravero/secureheaders.git","svn_url":"https://github.com/dariocravero/secureheaders","homepage":"","size":991,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"e51350485e5621a7ccba8b9d31c5a5908941ec0b","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":7122663,"name":"secureheaders","full_name":"twitter/secureheaders","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/secureheaders","description":"Security related headers all in one gem","fork":false,"url":"https://api.github.com/repos/twitter/secureheaders","forks_url":"https://api.github.com/repos/twitter/secureheaders/forks","keys_url":"https://api.github.com/repos/twitter/secureheaders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/secureheaders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/secureheaders/teams","hooks_url":"https://api.github.com/repos/twitter/secureheaders/hooks","issue_events_url":"https://api.github.com/repos/twitter/secureheaders/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/secureheaders/events","assignees_url":"https://api.github.com/repos/twitter/secureheaders/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/secureheaders/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/secureheaders/tags","blobs_url":"https://api.github.com/repos/twitter/secureheaders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/secureheaders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/secureheaders/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/secureheaders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/secureheaders/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/secureheaders/languages","stargazers_url":"https://api.github.com/repos/twitter/secureheaders/stargazers","contributors_url":"https://api.github.com/repos/twitter/secureheaders/contributors","subscribers_url":"https://api.github.com/repos/twitter/secureheaders/subscribers","subscription_url":"https://api.github.com/repos/twitter/secureheaders/subscription","commits_url":"https://api.github.com/repos/twitter/secureheaders/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/secureheaders/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/secureheaders/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/secureheaders/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/secureheaders/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/secureheaders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/secureheaders/merges","archive_url":"https://api.github.com/repos/twitter/secureheaders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/secureheaders/downloads","issues_url":"https://api.github.com/repos/twitter/secureheaders/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/secureheaders/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/secureheaders/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/secureheaders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/secureheaders/labels{/name}","releases_url":"https://api.github.com/repos/twitter/secureheaders/releases{/id}","created_at":"2012-12-12T01:41:57Z","updated_at":"2014-06-23T19:45:12Z","pushed_at":"2014-06-23T19:45:12Z","git_url":"git://github.com/twitter/secureheaders.git","ssh_url":"git@github.com:twitter/secureheaders.git","clone_url":"https://github.com/twitter/secureheaders.git","svn_url":"https://github.com/twitter/secureheaders","homepage":"","size":991,"stargazers_count":1100,"watchers_count":1100,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":41,"mirror_url":null,"open_issues_count":10,"forks":41,"open_issues":10,"watchers":1100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/secureheaders/pulls/93"},"html":{"href":"https://github.com/twitter/secureheaders/pull/93"},"issue":{"href":"https://api.github.com/repos/twitter/secureheaders/issues/93"},"comments":{"href":"https://api.github.com/repos/twitter/secureheaders/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/secureheaders/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/secureheaders/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twitter/secureheaders/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/secureheaders/statuses/7c481b3314b461d9c609dc992e7127e0ab59fcba"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":36,"deletions":14,"changed_files":2}}