GitHub PullRequestReviewCommentEvent at 2014-10-29 09:20:15
Repository: odoo
Actor: Whisno
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/19526351","id":19526351,"diff_hunk":"@@ -448,24 +448,91 @@ def cancel(self, cr, uid, ids, context=None):\n             account_move_obj.button_cancel(cr, uid, move_ids, context=context)\n             account_move_obj.unlink(cr, uid, move_ids, context)\n \n-    def get_data_for_reconciliations(self, cr, uid, ids, excluded_ids=None, search_reconciliation_proposition=True, context=None):\n+    def reconciliation_widget_preprocess(self, cr, uid, statement_ids=None, context=None):\n+        \"\"\" Get statement lines of the specified statements or all unreconciled statement lines and try to automatically reconcile them / find them a partner.\n+            Return ids of statement lines left to reconcile and other data for the reconciliation widget. \"\"\"\n+        bs_obj = self.pool.get('account.bank.statement')\n+\n+        # Get statement lines\n+        st_lines_filter = [('journal_entry_id', '=', False), ('account_id', '=', False)]\n+        if statement_ids:\n+            st_lines_filter += [('statement_id', 'in', statement_ids)]\n+        st_lines = self.search(cr, uid, st_lines_filter, order='statement_id, id')\n+\n+        # Try to automatically reconcile statement lines\n+        automatic_reconciliation_entries = []\n+        st_lines_left = []\n+        for st_line in self.browse(cr, uid, st_lines):\n+            counterpart = self.get_unambiguous_reconciliation_proposition(cr, uid, st_line, context=context)\n+            if counterpart:\n+                for move_line_dict in counterpart:\n+                    # get_reconciliation_proposition() returns informations about move lines whereas process_reconciliation() expects informations\n+                    # about how to create new move lines to reconcile existing ones. So, if get_reconciliation_proposition() gives us a move line\n+                    # whose id is 7 and debit is 500, and we want to totally reconcile it, we need to feed process_reconciliation() with :\n+                    # 'counterpart_move_line_id': 7,\n+                    # 'credit': 500\n+                    # This is what the reconciliation widget does.\n+                    move_line_dict['counterpart_move_line_id'] = move_line_dict['id']","path":"addons/account/account_bank_statement.py","position":29,"original_position":29,"commit_id":"a46fd8437bf1c7b12b7b078b9afd9a6660a2a6f1","original_commit_id":"a46fd8437bf1c7b12b7b078b9afd9a6660a2a6f1","user":{"login":"Whisno","id":6009089,"avatar_url":"https://avatars.githubusercontent.com/u/6009089?v=2","gravatar_id":"","url":"https://api.github.com/users/Whisno","html_url":"https://github.com/Whisno","followers_url":"https://api.github.com/users/Whisno/followers","following_url":"https://api.github.com/users/Whisno/following{/other_user}","gists_url":"https://api.github.com/users/Whisno/gists{/gist_id}","starred_url":"https://api.github.com/users/Whisno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Whisno/subscriptions","organizations_url":"https://api.github.com/users/Whisno/orgs","repos_url":"https://api.github.com/users/Whisno/repos","events_url":"https://api.github.com/users/Whisno/events{/privacy}","received_events_url":"https://api.github.com/users/Whisno/received_events","type":"User","site_admin":false},"body":"It won't because : \r\n","created_at":"2014-10-29T09:20:15Z","updated_at":"2014-10-29T09:20:15Z","html_url":"https://github.com/odoo/odoo/pull/3345#discussion_r19526351","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/3345","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/19526351"},"html":{"href":"https://github.com/odoo/odoo/pull/3345#discussion_r19526351"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/3345"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/3345","id":23453956,"html_url":"https://github.com/odoo/odoo/pull/3345","diff_url":"https://github.com/odoo/odoo/pull/3345.diff","patch_url":"https://github.com/odoo/odoo/pull/3345.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/3345","number":3345,"state":"open","locked":false,"title":"Master reconciliation and statement import ama","user":{"login":"qdp-odoo","id":7628598,"avatar_url":"https://avatars.githubusercontent.com/u/7628598?v=2","gravatar_id":"","url":"https://api.github.com/users/qdp-odoo","html_url":"https://github.com/qdp-odoo","followers_url":"https://api.github.com/users/qdp-odoo/followers","following_url":"https://api.github.com/users/qdp-odoo/following{/other_user}","gists_url":"https://api.github.com/users/qdp-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/qdp-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qdp-odoo/subscriptions","organizations_url":"https://api.github.com/users/qdp-odoo/orgs","repos_url":"https://api.github.com/users/qdp-odoo/repos","events_url":"https://api.github.com/users/qdp-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/qdp-odoo/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-28T12:58:26Z","updated_at":"2014-10-29T09:20:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcdfc8ebc469aa3bf022afa453f8eaab42cb6512","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/3345/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/3345/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/3345/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/a46fd8437bf1c7b12b7b078b9afd9a6660a2a6f1","head":{"label":"odoo-dev:master-reconciliation-and-statement-import-ama","ref":"master-reconciliation-and-statement-import-ama","sha":"a46fd8437bf1c7b12b7b078b9afd9a6660a2a6f1","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=2","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=2","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","created_at":"2014-05-16T11:16:19Z","updated_at":"2014-10-18T14:37:38Z","pushed_at":"2014-10-29T09:19:27Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":958062,"stargazers_count":34,"watchers_count":34,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":9,"forks":12,"open_issues":9,"watchers":34,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"90b81a283af6bbaf0ed59cd430ea5ff197998a7c","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=2","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=2","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","created_at":"2014-05-13T15:38:58Z","updated_at":"2014-10-29T08:30:35Z","pushed_at":"2014-10-29T09:10:40Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":926529,"stargazers_count":1474,"watchers_count":1474,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1107,"mirror_url":null,"open_issues_count":1325,"forks":1107,"open_issues":1325,"watchers":1474,"default_branch":"8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/3345"},"html":{"href":"https://github.com/odoo/odoo/pull/3345"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/3345"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/3345/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/3345/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/3345/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/a46fd8437bf1c7b12b7b078b9afd9a6660a2a6f1"}}}}