GitHub PullRequestReviewCommentEvent at 2014-11-29 14:02:49
Repository: symfony
Actor: fabpot
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/21054083","id":21054083,"diff_hunk":"@@ -50,9 +50,14 @@ class Locale extends \\Locale\n      * @return array              The country names with their codes as keys\n      *\n      * @throws \\RuntimeException  When the resource bundles cannot be loaded\n+     *\n+     * @deprecated Deprecated since version 2.7, to be removed in Symfony 3.0.\n+     *             Use {@link \\Symfony\\Component\\Intl\\Intl::getRegionBundle()->getCountryNames()} instead.\n      */\n     public static function getDisplayCountries($locale)\n     {\n+\t    trigger_error('Deprecated since version 2.7, to be removed in Symfony 3.0. Use \\Symfony\\Component\\Intl\\Intl::getRegionBundle()->getCountryNames() instead.', E_USER_DEPRECATED);","path":"src/Symfony/Component/Locale/Locale.php","position":21,"original_position":21,"commit_id":"138ac93699728b55634ba56b09167eaa32091a10","original_commit_id":"138ac93699728b55634ba56b09167eaa32091a10","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"body":"Looks like you have a tab here (same in other places).","created_at":"2014-11-29T14:02:49Z","updated_at":"2014-11-29T14:02:49Z","html_url":"https://github.com/symfony/symfony/pull/12746#discussion_r21054083","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/12746","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/21054083"},"html":{"href":"https://github.com/symfony/symfony/pull/12746#discussion_r21054083"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12746"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/12746","id":25223228,"html_url":"https://github.com/symfony/symfony/pull/12746","diff_url":"https://github.com/symfony/symfony/pull/12746.diff","patch_url":"https://github.com/symfony/symfony/pull/12746.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/12746","number":12746,"state":"open","locked":false,"title":"[Locale] Adding a deprecation note about the Locale component","user":{"login":"rodrigobb","id":1637465,"avatar_url":"https://avatars.githubusercontent.com/u/1637465?v=3","gravatar_id":"","url":"https://api.github.com/users/rodrigobb","html_url":"https://github.com/rodrigobb","followers_url":"https://api.github.com/users/rodrigobb/followers","following_url":"https://api.github.com/users/rodrigobb/following{/other_user}","gists_url":"https://api.github.com/users/rodrigobb/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigobb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigobb/subscriptions","organizations_url":"https://api.github.com/users/rodrigobb/orgs","repos_url":"https://api.github.com/users/rodrigobb/repos","events_url":"https://api.github.com/users/rodrigobb/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigobb/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #12635 \r\n| License       | MIT\r\n| Doc PR        | -\r\n","created_at":"2014-11-29T14:00:59Z","updated_at":"2014-11-29T14:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc8ed7f9cd292ecc4cfbdffa0de28282eb89b42c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/12746/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/12746/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/12746/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/138ac93699728b55634ba56b09167eaa32091a10","head":{"label":"rodrigobb:ticket_12635","ref":"ticket_12635","sha":"138ac93699728b55634ba56b09167eaa32091a10","user":{"login":"rodrigobb","id":1637465,"avatar_url":"https://avatars.githubusercontent.com/u/1637465?v=3","gravatar_id":"","url":"https://api.github.com/users/rodrigobb","html_url":"https://github.com/rodrigobb","followers_url":"https://api.github.com/users/rodrigobb/followers","following_url":"https://api.github.com/users/rodrigobb/following{/other_user}","gists_url":"https://api.github.com/users/rodrigobb/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigobb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigobb/subscriptions","organizations_url":"https://api.github.com/users/rodrigobb/orgs","repos_url":"https://api.github.com/users/rodrigobb/repos","events_url":"https://api.github.com/users/rodrigobb/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigobb/received_events","type":"User","site_admin":false},"repo":{"id":27299081,"name":"symfony","full_name":"rodrigobb/symfony","owner":{"login":"rodrigobb","id":1637465,"avatar_url":"https://avatars.githubusercontent.com/u/1637465?v=3","gravatar_id":"","url":"https://api.github.com/users/rodrigobb","html_url":"https://github.com/rodrigobb","followers_url":"https://api.github.com/users/rodrigobb/followers","following_url":"https://api.github.com/users/rodrigobb/following{/other_user}","gists_url":"https://api.github.com/users/rodrigobb/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigobb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigobb/subscriptions","organizations_url":"https://api.github.com/users/rodrigobb/orgs","repos_url":"https://api.github.com/users/rodrigobb/repos","events_url":"https://api.github.com/users/rodrigobb/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigobb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rodrigobb/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/rodrigobb/symfony","forks_url":"https://api.github.com/repos/rodrigobb/symfony/forks","keys_url":"https://api.github.com/repos/rodrigobb/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rodrigobb/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rodrigobb/symfony/teams","hooks_url":"https://api.github.com/repos/rodrigobb/symfony/hooks","issue_events_url":"https://api.github.com/repos/rodrigobb/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/rodrigobb/symfony/events","assignees_url":"https://api.github.com/repos/rodrigobb/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/rodrigobb/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/rodrigobb/symfony/tags","blobs_url":"https://api.github.com/repos/rodrigobb/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rodrigobb/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rodrigobb/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/rodrigobb/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rodrigobb/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/rodrigobb/symfony/languages","stargazers_url":"https://api.github.com/repos/rodrigobb/symfony/stargazers","contributors_url":"https://api.github.com/repos/rodrigobb/symfony/contributors","subscribers_url":"https://api.github.com/repos/rodrigobb/symfony/subscribers","subscription_url":"https://api.github.com/repos/rodrigobb/symfony/subscription","commits_url":"https://api.github.com/repos/rodrigobb/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/rodrigobb/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/rodrigobb/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/rodrigobb/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/rodrigobb/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/rodrigobb/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rodrigobb/symfony/merges","archive_url":"https://api.github.com/repos/rodrigobb/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rodrigobb/symfony/downloads","issues_url":"https://api.github.com/repos/rodrigobb/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/rodrigobb/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/rodrigobb/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/rodrigobb/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rodrigobb/symfony/labels{/name}","releases_url":"https://api.github.com/repos/rodrigobb/symfony/releases{/id}","created_at":"2014-11-29T10:42:36Z","updated_at":"2014-11-29T10:42:48Z","pushed_at":"2014-11-29T13:59:11Z","git_url":"git://github.com/rodrigobb/symfony.git","ssh_url":"git@github.com:rodrigobb/symfony.git","clone_url":"https://github.com/rodrigobb/symfony.git","svn_url":"https://github.com/rodrigobb/symfony","homepage":"symfony.com","size":45875,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.7"}},"base":{"label":"symfony:2.7","ref":"2.7","sha":"3274632fe073ffb53260e106fd3b2ddf3ec25917","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2014-11-29T13:59:12Z","pushed_at":"2014-11-29T13:59:14Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":195993,"stargazers_count":9285,"watchers_count":9285,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3599,"mirror_url":null,"open_issues_count":928,"forks":3599,"open_issues":928,"watchers":9285,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12746"},"html":{"href":"https://github.com/symfony/symfony/pull/12746"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/12746"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/12746/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12746/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12746/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/138ac93699728b55634ba56b09167eaa32091a10"}}}}