GitHub PullRequestEvent at 2014-10-22 12:54:34
Repository: web_design
Actor: JulianNorton
Payload: {"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/JulianNorton/web_design/pulls/14","id":23095346,"html_url":"https://github.com/JulianNorton/web_design/pull/14","diff_url":"https://github.com/JulianNorton/web_design/pull/14.diff","patch_url":"https://github.com/JulianNorton/web_design/pull/14.patch","issue_url":"https://api.github.com/repos/JulianNorton/web_design/issues/14","number":14,"state":"closed","locked":false,"title":"Fixed the button hover and active jerkiness","user":{"login":"GeKorm","id":6104345,"avatar_url":"https://avatars.githubusercontent.com/u/6104345?v=2","gravatar_id":"","url":"https://api.github.com/users/GeKorm","html_url":"https://github.com/GeKorm","followers_url":"https://api.github.com/users/GeKorm/followers","following_url":"https://api.github.com/users/GeKorm/following{/other_user}","gists_url":"https://api.github.com/users/GeKorm/gists{/gist_id}","starred_url":"https://api.github.com/users/GeKorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeKorm/subscriptions","organizations_url":"https://api.github.com/users/GeKorm/orgs","repos_url":"https://api.github.com/users/GeKorm/repos","events_url":"https://api.github.com/users/GeKorm/events{/privacy}","received_events_url":"https://api.github.com/users/GeKorm/received_events","type":"User","site_admin":false},"body":"The current implementation causes the layout below the button to jerk up and down when hovering or clicking it. This is because borders affect the element's offset height. My proposal is to use box-shadow to achieve the same effects without any side-effects.","created_at":"2014-10-21T15:42:02Z","updated_at":"2014-10-22T12:54:34Z","closed_at":"2014-10-22T12:54:34Z","merged_at":"2014-10-22T12:54:34Z","merge_commit_sha":"3a211e892507556c7197510340a18e9b79b229b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JulianNorton/web_design/pulls/14/commits","review_comments_url":"https://api.github.com/repos/JulianNorton/web_design/pulls/14/comments","review_comment_url":"https://api.github.com/repos/JulianNorton/web_design/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JulianNorton/web_design/issues/14/comments","statuses_url":"https://api.github.com/repos/JulianNorton/web_design/statuses/16c3cce5213343c3023eb29ef8a7e39084e2cf56","head":{"label":"GeKorm:patch-1","ref":"patch-1","sha":"16c3cce5213343c3023eb29ef8a7e39084e2cf56","user":{"login":"GeKorm","id":6104345,"avatar_url":"https://avatars.githubusercontent.com/u/6104345?v=2","gravatar_id":"","url":"https://api.github.com/users/GeKorm","html_url":"https://github.com/GeKorm","followers_url":"https://api.github.com/users/GeKorm/followers","following_url":"https://api.github.com/users/GeKorm/following{/other_user}","gists_url":"https://api.github.com/users/GeKorm/gists{/gist_id}","starred_url":"https://api.github.com/users/GeKorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeKorm/subscriptions","organizations_url":"https://api.github.com/users/GeKorm/orgs","repos_url":"https://api.github.com/users/GeKorm/repos","events_url":"https://api.github.com/users/GeKorm/events{/privacy}","received_events_url":"https://api.github.com/users/GeKorm/received_events","type":"User","site_admin":false},"repo":{"id":25528989,"name":"web_design","full_name":"GeKorm/web_design","owner":{"login":"GeKorm","id":6104345,"avatar_url":"https://avatars.githubusercontent.com/u/6104345?v=2","gravatar_id":"","url":"https://api.github.com/users/GeKorm","html_url":"https://github.com/GeKorm","followers_url":"https://api.github.com/users/GeKorm/followers","following_url":"https://api.github.com/users/GeKorm/following{/other_user}","gists_url":"https://api.github.com/users/GeKorm/gists{/gist_id}","starred_url":"https://api.github.com/users/GeKorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeKorm/subscriptions","organizations_url":"https://api.github.com/users/GeKorm/orgs","repos_url":"https://api.github.com/users/GeKorm/repos","events_url":"https://api.github.com/users/GeKorm/events{/privacy}","received_events_url":"https://api.github.com/users/GeKorm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GeKorm/web_design","description":"/r/web_design","fork":true,"url":"https://api.github.com/repos/GeKorm/web_design","forks_url":"https://api.github.com/repos/GeKorm/web_design/forks","keys_url":"https://api.github.com/repos/GeKorm/web_design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeKorm/web_design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeKorm/web_design/teams","hooks_url":"https://api.github.com/repos/GeKorm/web_design/hooks","issue_events_url":"https://api.github.com/repos/GeKorm/web_design/issues/events{/number}","events_url":"https://api.github.com/repos/GeKorm/web_design/events","assignees_url":"https://api.github.com/repos/GeKorm/web_design/assignees{/user}","branches_url":"https://api.github.com/repos/GeKorm/web_design/branches{/branch}","tags_url":"https://api.github.com/repos/GeKorm/web_design/tags","blobs_url":"https://api.github.com/repos/GeKorm/web_design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeKorm/web_design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeKorm/web_design/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeKorm/web_design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeKorm/web_design/statuses/{sha}","languages_url":"https://api.github.com/repos/GeKorm/web_design/languages","stargazers_url":"https://api.github.com/repos/GeKorm/web_design/stargazers","contributors_url":"https://api.github.com/repos/GeKorm/web_design/contributors","subscribers_url":"https://api.github.com/repos/GeKorm/web_design/subscribers","subscription_url":"https://api.github.com/repos/GeKorm/web_design/subscription","commits_url":"https://api.github.com/repos/GeKorm/web_design/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeKorm/web_design/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeKorm/web_design/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeKorm/web_design/issues/comments/{number}","contents_url":"https://api.github.com/repos/GeKorm/web_design/contents/{+path}","compare_url":"https://api.github.com/repos/GeKorm/web_design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeKorm/web_design/merges","archive_url":"https://api.github.com/repos/GeKorm/web_design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeKorm/web_design/downloads","issues_url":"https://api.github.com/repos/GeKorm/web_design/issues{/number}","pulls_url":"https://api.github.com/repos/GeKorm/web_design/pulls{/number}","milestones_url":"https://api.github.com/repos/GeKorm/web_design/milestones{/number}","notifications_url":"https://api.github.com/repos/GeKorm/web_design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeKorm/web_design/labels{/name}","releases_url":"https://api.github.com/repos/GeKorm/web_design/releases{/id}","created_at":"2014-10-21T15:08:03Z","updated_at":"2014-09-30T21:13:52Z","pushed_at":"2014-10-21T15:40:59Z","git_url":"git://github.com/GeKorm/web_design.git","ssh_url":"git@github.com:GeKorm/web_design.git","clone_url":"https://github.com/GeKorm/web_design.git","svn_url":"https://github.com/GeKorm/web_design","homepage":null,"size":172,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JulianNorton:master","ref":"master","sha":"6f58209f8752e6968f71f5282e19218146284448","user":{"login":"JulianNorton","id":2412992,"avatar_url":"https://avatars.githubusercontent.com/u/2412992?v=2","gravatar_id":"","url":"https://api.github.com/users/JulianNorton","html_url":"https://github.com/JulianNorton","followers_url":"https://api.github.com/users/JulianNorton/followers","following_url":"https://api.github.com/users/JulianNorton/following{/other_user}","gists_url":"https://api.github.com/users/JulianNorton/gists{/gist_id}","starred_url":"https://api.github.com/users/JulianNorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulianNorton/subscriptions","organizations_url":"https://api.github.com/users/JulianNorton/orgs","repos_url":"https://api.github.com/users/JulianNorton/repos","events_url":"https://api.github.com/users/JulianNorton/events{/privacy}","received_events_url":"https://api.github.com/users/JulianNorton/received_events","type":"User","site_admin":false},"repo":{"id":23122700,"name":"web_design","full_name":"JulianNorton/web_design","owner":{"login":"JulianNorton","id":2412992,"avatar_url":"https://avatars.githubusercontent.com/u/2412992?v=2","gravatar_id":"","url":"https://api.github.com/users/JulianNorton","html_url":"https://github.com/JulianNorton","followers_url":"https://api.github.com/users/JulianNorton/followers","following_url":"https://api.github.com/users/JulianNorton/following{/other_user}","gists_url":"https://api.github.com/users/JulianNorton/gists{/gist_id}","starred_url":"https://api.github.com/users/JulianNorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulianNorton/subscriptions","organizations_url":"https://api.github.com/users/JulianNorton/orgs","repos_url":"https://api.github.com/users/JulianNorton/repos","events_url":"https://api.github.com/users/JulianNorton/events{/privacy}","received_events_url":"https://api.github.com/users/JulianNorton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JulianNorton/web_design","description":"/r/web_design","fork":false,"url":"https://api.github.com/repos/JulianNorton/web_design","forks_url":"https://api.github.com/repos/JulianNorton/web_design/forks","keys_url":"https://api.github.com/repos/JulianNorton/web_design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JulianNorton/web_design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JulianNorton/web_design/teams","hooks_url":"https://api.github.com/repos/JulianNorton/web_design/hooks","issue_events_url":"https://api.github.com/repos/JulianNorton/web_design/issues/events{/number}","events_url":"https://api.github.com/repos/JulianNorton/web_design/events","assignees_url":"https://api.github.com/repos/JulianNorton/web_design/assignees{/user}","branches_url":"https://api.github.com/repos/JulianNorton/web_design/branches{/branch}","tags_url":"https://api.github.com/repos/JulianNorton/web_design/tags","blobs_url":"https://api.github.com/repos/JulianNorton/web_design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JulianNorton/web_design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JulianNorton/web_design/git/refs{/sha}","trees_url":"https://api.github.com/repos/JulianNorton/web_design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JulianNorton/web_design/statuses/{sha}","languages_url":"https://api.github.com/repos/JulianNorton/web_design/languages","stargazers_url":"https://api.github.com/repos/JulianNorton/web_design/stargazers","contributors_url":"https://api.github.com/repos/JulianNorton/web_design/contributors","subscribers_url":"https://api.github.com/repos/JulianNorton/web_design/subscribers","subscription_url":"https://api.github.com/repos/JulianNorton/web_design/subscription","commits_url":"https://api.github.com/repos/JulianNorton/web_design/commits{/sha}","git_commits_url":"https://api.github.com/repos/JulianNorton/web_design/git/commits{/sha}","comments_url":"https://api.github.com/repos/JulianNorton/web_design/comments{/number}","issue_comment_url":"https://api.github.com/repos/JulianNorton/web_design/issues/comments/{number}","contents_url":"https://api.github.com/repos/JulianNorton/web_design/contents/{+path}","compare_url":"https://api.github.com/repos/JulianNorton/web_design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JulianNorton/web_design/merges","archive_url":"https://api.github.com/repos/JulianNorton/web_design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JulianNorton/web_design/downloads","issues_url":"https://api.github.com/repos/JulianNorton/web_design/issues{/number}","pulls_url":"https://api.github.com/repos/JulianNorton/web_design/pulls{/number}","milestones_url":"https://api.github.com/repos/JulianNorton/web_design/milestones{/number}","notifications_url":"https://api.github.com/repos/JulianNorton/web_design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JulianNorton/web_design/labels{/name}","releases_url":"https://api.github.com/repos/JulianNorton/web_design/releases{/id}","created_at":"2014-08-19T19:17:10Z","updated_at":"2014-09-30T21:13:52Z","pushed_at":"2014-10-22T12:54:34Z","git_url":"git://github.com/JulianNorton/web_design.git","ssh_url":"git@github.com:JulianNorton/web_design.git","clone_url":"https://github.com/JulianNorton/web_design.git","svn_url":"https://github.com/JulianNorton/web_design","homepage":null,"size":414,"stargazers_count":9,"watchers_count":9,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JulianNorton/web_design/pulls/14"},"html":{"href":"https://github.com/JulianNorton/web_design/pull/14"},"issue":{"href":"https://api.github.com/repos/JulianNorton/web_design/issues/14"},"comments":{"href":"https://api.github.com/repos/JulianNorton/web_design/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/JulianNorton/web_design/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/JulianNorton/web_design/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JulianNorton/web_design/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/JulianNorton/web_design/statuses/16c3cce5213343c3023eb29ef8a7e39084e2cf56"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"JulianNorton","id":2412992,"avatar_url":"https://avatars.githubusercontent.com/u/2412992?v=2","gravatar_id":"","url":"https://api.github.com/users/JulianNorton","html_url":"https://github.com/JulianNorton","followers_url":"https://api.github.com/users/JulianNorton/followers","following_url":"https://api.github.com/users/JulianNorton/following{/other_user}","gists_url":"https://api.github.com/users/JulianNorton/gists{/gist_id}","starred_url":"https://api.github.com/users/JulianNorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulianNorton/subscriptions","organizations_url":"https://api.github.com/users/JulianNorton/orgs","repos_url":"https://api.github.com/users/JulianNorton/repos","events_url":"https://api.github.com/users/JulianNorton/events{/privacy}","received_events_url":"https://api.github.com/users/JulianNorton/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":12,"changed_files":1}}