GitHub PullRequestReviewCommentEvent at 2014-04-15 21:07:01
Repository: deploy
Actor: philwills
Payload: {"comment":{"url":"https://api.github.com/repos/guardian/deploy/pulls/comments/11657942","id":11657942,"diff_hunk":"@@ -131,17 +123,6 @@ trait ApiTracker[T] {\n     Result((updated.toSet diff previous.toSet).toList, updated, previous)\n   }\n \n-  def queueNotify(result: Result) {\n-    agent.queueUpdate(Update{\n-      notify(result.diff, result.previous)\n-      promises.send { promisesMade =>\n-        promisesMade.foreach(_.success(result.updated))","path":"riff-raff/app/ci/artifact.scala","position":62,"original_position":62,"commit_id":"40ca00bfb6d9c206e21d68dab17165ea94563d9e","original_commit_id":"40ca00bfb6d9c206e21d68dab17165ea94563d9e","user":{"login":"philwills","id":68329,"avatar_url":"https://avatars.githubusercontent.com/u/68329?","gravatar_id":"13d76c620e5b3defa9637a31bcce3a65","url":"https://api.github.com/users/philwills","html_url":"https://github.com/philwills","followers_url":"https://api.github.com/users/philwills/followers","following_url":"https://api.github.com/users/philwills/following{/other_user}","gists_url":"https://api.github.com/users/philwills/gists{/gist_id}","starred_url":"https://api.github.com/users/philwills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwills/subscriptions","organizations_url":"https://api.github.com/users/philwills/orgs","repos_url":"https://api.github.com/users/philwills/repos","events_url":"https://api.github.com/users/philwills/events{/privacy}","received_events_url":"https://api.github.com/users/philwills/received_events","type":"User","site_admin":false},"body":"Thanks. I've got a different plan from restoring it as was, but had\nforgotten I'd gutted the existing implementation early on.\n\nWill have a think about time interval as opposed to 100 builds. Think you\nmight be right given the wide spectrum of build cadences.\n\nPlease consider the environment before printing this email.\n------------------------------------------------------------------\nVisit theguardian.com   \n\nOn your mobile, download the Guardian iPhone app theguardian.com/iphone and our iPad edition theguardian.com/iPad   \nSave up to 57% by subscribing to the Guardian and Observer - choose the papers you want and get full digital access.\nVisit subscribe.theguardian.com\n\nThis e-mail and all attachments are confidential and may also\nbe privileged. If you are not the named recipient, please notify\nthe sender and delete the e-mail and all attachments immediately.\nDo not disclose the contents to another person. You may not use\nthe information for any purpose, or store, or copy, it in any way.\n \nGuardian News & Media Limited is not liable for any computer\nviruses or other material transmitted with or as part of this\ne-mail. You should employ virus checking software.\n \nGuardian News & Media Limited\n \nA member of Guardian Media Group plc\nRegistered Office\nPO Box 68164\nKings Place\n90 York Way\nLondon\nN1P 2AP\n \nRegistered in England Number 908396\n\n--------------------------------------------------------------------------","created_at":"2014-04-15T21:07:01Z","updated_at":"2014-04-15T21:07:01Z","html_url":"https://github.com/guardian/deploy/pull/162#discussion_r11657942","pull_request_url":"https://api.github.com/repos/guardian/deploy/pulls/162","_links":{"self":{"href":"https://api.github.com/repos/guardian/deploy/pulls/comments/11657942"},"html":{"href":"https://github.com/guardian/deploy/pull/162#discussion_r11657942"},"pull_request":{"href":"https://api.github.com/repos/guardian/deploy/pulls/162"}}}}