GitHub PullRequestReviewCommentEvent at 2014-10-26 07:47:50
Repository: flask
Actor: untitaker
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mitsuhiko/flask/pulls/comments/19379721","id":19379721,"diff_hunk":"@@ -154,10 +154,9 @@ What to use depends on what you have in mind.  For the SQLite 3 extension\n we will use the class-based approach because it will provide users with an\n object that handles opening and closing database connections.\n \n-What's important about classes is that they encourage to be shared around\n-on module level.  In that case, the object itself must not under any\n-circumstances store any application specific state and must be shareable\n-between different application.\n+What's important about classes is that they encourage sharing on the module","path":"docs/extensiondev.rst","position":17,"original_position":17,"commit_id":"9d24b1eac99bd69ac99c6a2dd652b912a4217cc3","original_commit_id":"9d24b1eac99bd69ac99c6a2dd652b912a4217cc3","user":{"login":"untitaker","id":837573,"avatar_url":"https://avatars.githubusercontent.com/u/837573?v=2","gravatar_id":"","url":"https://api.github.com/users/untitaker","html_url":"https://github.com/untitaker","followers_url":"https://api.github.com/users/untitaker/followers","following_url":"https://api.github.com/users/untitaker/following{/other_user}","gists_url":"https://api.github.com/users/untitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/untitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untitaker/subscriptions","organizations_url":"https://api.github.com/users/untitaker/orgs","repos_url":"https://api.github.com/users/untitaker/repos","events_url":"https://api.github.com/users/untitaker/events{/privacy}","received_events_url":"https://api.github.com/users/untitaker/received_events","type":"User","site_admin":false},"body":"I think it's more specific if the classes encourage \"to be shared\" instead of just \"sharing\".","created_at":"2014-10-26T07:47:50Z","updated_at":"2014-10-26T07:47:50Z","html_url":"https://github.com/mitsuhiko/flask/pull/1221#discussion_r19379721","pull_request_url":"https://api.github.com/repos/mitsuhiko/flask/pulls/1221","_links":{"self":{"href":"https://api.github.com/repos/mitsuhiko/flask/pulls/comments/19379721"},"html":{"href":"https://github.com/mitsuhiko/flask/pull/1221#discussion_r19379721"},"pull_request":{"href":"https://api.github.com/repos/mitsuhiko/flask/pulls/1221"}}},"pull_request":{"url":"https://api.github.com/repos/mitsuhiko/flask/pulls/1221","id":23346307,"html_url":"https://github.com/mitsuhiko/flask/pull/1221","diff_url":"https://github.com/mitsuhiko/flask/pull/1221.diff","patch_url":"https://github.com/mitsuhiko/flask/pull/1221.patch","issue_url":"https://api.github.com/repos/mitsuhiko/flask/issues/1221","number":1221,"state":"open","locked":false,"title":"Some grammar and typo fixes","user":{"login":"jeffwidman","id":483314,"avatar_url":"https://avatars.githubusercontent.com/u/483314?v=2","gravatar_id":"","url":"https://api.github.com/users/jeffwidman","html_url":"https://github.com/jeffwidman","followers_url":"https://api.github.com/users/jeffwidman/followers","following_url":"https://api.github.com/users/jeffwidman/following{/other_user}","gists_url":"https://api.github.com/users/jeffwidman/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffwidman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffwidman/subscriptions","organizations_url":"https://api.github.com/users/jeffwidman/orgs","repos_url":"https://api.github.com/users/jeffwidman/repos","events_url":"https://api.github.com/users/jeffwidman/events{/privacy}","received_events_url":"https://api.github.com/users/jeffwidman/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-26T01:56:33Z","updated_at":"2014-10-26T07:47:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96c95952fab84b5c0d78215a277f95311fcc80e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mitsuhiko/flask/pulls/1221/commits","review_comments_url":"https://api.github.com/repos/mitsuhiko/flask/pulls/1221/comments","review_comment_url":"https://api.github.com/repos/mitsuhiko/flask/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mitsuhiko/flask/issues/1221/comments","statuses_url":"https://api.github.com/repos/mitsuhiko/flask/statuses/9d24b1eac99bd69ac99c6a2dd652b912a4217cc3","head":{"label":"jeffwidman:patch-1","ref":"patch-1","sha":"9d24b1eac99bd69ac99c6a2dd652b912a4217cc3","user":{"login":"jeffwidman","id":483314,"avatar_url":"https://avatars.githubusercontent.com/u/483314?v=2","gravatar_id":"","url":"https://api.github.com/users/jeffwidman","html_url":"https://github.com/jeffwidman","followers_url":"https://api.github.com/users/jeffwidman/followers","following_url":"https://api.github.com/users/jeffwidman/following{/other_user}","gists_url":"https://api.github.com/users/jeffwidman/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffwidman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffwidman/subscriptions","organizations_url":"https://api.github.com/users/jeffwidman/orgs","repos_url":"https://api.github.com/users/jeffwidman/repos","events_url":"https://api.github.com/users/jeffwidman/events{/privacy}","received_events_url":"https://api.github.com/users/jeffwidman/received_events","type":"User","site_admin":false},"repo":{"id":25753642,"name":"flask","full_name":"jeffwidman/flask","owner":{"login":"jeffwidman","id":483314,"avatar_url":"https://avatars.githubusercontent.com/u/483314?v=2","gravatar_id":"","url":"https://api.github.com/users/jeffwidman","html_url":"https://github.com/jeffwidman","followers_url":"https://api.github.com/users/jeffwidman/followers","following_url":"https://api.github.com/users/jeffwidman/following{/other_user}","gists_url":"https://api.github.com/users/jeffwidman/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffwidman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffwidman/subscriptions","organizations_url":"https://api.github.com/users/jeffwidman/orgs","repos_url":"https://api.github.com/users/jeffwidman/repos","events_url":"https://api.github.com/users/jeffwidman/events{/privacy}","received_events_url":"https://api.github.com/users/jeffwidman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffwidman/flask","description":"A microframework based on Werkzeug, Jinja2 and good intentions","fork":true,"url":"https://api.github.com/repos/jeffwidman/flask","forks_url":"https://api.github.com/repos/jeffwidman/flask/forks","keys_url":"https://api.github.com/repos/jeffwidman/flask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffwidman/flask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffwidman/flask/teams","hooks_url":"https://api.github.com/repos/jeffwidman/flask/hooks","issue_events_url":"https://api.github.com/repos/jeffwidman/flask/issues/events{/number}","events_url":"https://api.github.com/repos/jeffwidman/flask/events","assignees_url":"https://api.github.com/repos/jeffwidman/flask/assignees{/user}","branches_url":"https://api.github.com/repos/jeffwidman/flask/branches{/branch}","tags_url":"https://api.github.com/repos/jeffwidman/flask/tags","blobs_url":"https://api.github.com/repos/jeffwidman/flask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffwidman/flask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffwidman/flask/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffwidman/flask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffwidman/flask/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffwidman/flask/languages","stargazers_url":"https://api.github.com/repos/jeffwidman/flask/stargazers","contributors_url":"https://api.github.com/repos/jeffwidman/flask/contributors","subscribers_url":"https://api.github.com/repos/jeffwidman/flask/subscribers","subscription_url":"https://api.github.com/repos/jeffwidman/flask/subscription","commits_url":"https://api.github.com/repos/jeffwidman/flask/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffwidman/flask/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffwidman/flask/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffwidman/flask/issues/comments/{number}","contents_url":"https://api.github.com/repos/jeffwidman/flask/contents/{+path}","compare_url":"https://api.github.com/repos/jeffwidman/flask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffwidman/flask/merges","archive_url":"https://api.github.com/repos/jeffwidman/flask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffwidman/flask/downloads","issues_url":"https://api.github.com/repos/jeffwidman/flask/issues{/number}","pulls_url":"https://api.github.com/repos/jeffwidman/flask/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffwidman/flask/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffwidman/flask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffwidman/flask/labels{/name}","releases_url":"https://api.github.com/repos/jeffwidman/flask/releases{/id}","created_at":"2014-10-26T01:55:41Z","updated_at":"2014-10-26T00:47:33Z","pushed_at":"2014-10-26T01:56:10Z","git_url":"git://github.com/jeffwidman/flask.git","ssh_url":"git@github.com:jeffwidman/flask.git","clone_url":"https://github.com/jeffwidman/flask.git","svn_url":"https://github.com/jeffwidman/flask","homepage":"http://flask.pocoo.org/","size":14498,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mitsuhiko:ext-deprecation","ref":"ext-deprecation","sha":"ec0339be3cb7bd6e107987dcce39ec61be966754","user":{"login":"mitsuhiko","id":7396,"avatar_url":"https://avatars.githubusercontent.com/u/7396?v=2","gravatar_id":"","url":"https://api.github.com/users/mitsuhiko","html_url":"https://github.com/mitsuhiko","followers_url":"https://api.github.com/users/mitsuhiko/followers","following_url":"https://api.github.com/users/mitsuhiko/following{/other_user}","gists_url":"https://api.github.com/users/mitsuhiko/gists{/gist_id}","starred_url":"https://api.github.com/users/mitsuhiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitsuhiko/subscriptions","organizations_url":"https://api.github.com/users/mitsuhiko/orgs","repos_url":"https://api.github.com/users/mitsuhiko/repos","events_url":"https://api.github.com/users/mitsuhiko/events{/privacy}","received_events_url":"https://api.github.com/users/mitsuhiko/received_events","type":"User","site_admin":false},"repo":{"id":596892,"name":"flask","full_name":"mitsuhiko/flask","owner":{"login":"mitsuhiko","id":7396,"avatar_url":"https://avatars.githubusercontent.com/u/7396?v=2","gravatar_id":"","url":"https://api.github.com/users/mitsuhiko","html_url":"https://github.com/mitsuhiko","followers_url":"https://api.github.com/users/mitsuhiko/followers","following_url":"https://api.github.com/users/mitsuhiko/following{/other_user}","gists_url":"https://api.github.com/users/mitsuhiko/gists{/gist_id}","starred_url":"https://api.github.com/users/mitsuhiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitsuhiko/subscriptions","organizations_url":"https://api.github.com/users/mitsuhiko/orgs","repos_url":"https://api.github.com/users/mitsuhiko/repos","events_url":"https://api.github.com/users/mitsuhiko/events{/privacy}","received_events_url":"https://api.github.com/users/mitsuhiko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitsuhiko/flask","description":"A microframework based on Werkzeug, Jinja2 and good intentions","fork":false,"url":"https://api.github.com/repos/mitsuhiko/flask","forks_url":"https://api.github.com/repos/mitsuhiko/flask/forks","keys_url":"https://api.github.com/repos/mitsuhiko/flask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitsuhiko/flask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitsuhiko/flask/teams","hooks_url":"https://api.github.com/repos/mitsuhiko/flask/hooks","issue_events_url":"https://api.github.com/repos/mitsuhiko/flask/issues/events{/number}","events_url":"https://api.github.com/repos/mitsuhiko/flask/events","assignees_url":"https://api.github.com/repos/mitsuhiko/flask/assignees{/user}","branches_url":"https://api.github.com/repos/mitsuhiko/flask/branches{/branch}","tags_url":"https://api.github.com/repos/mitsuhiko/flask/tags","blobs_url":"https://api.github.com/repos/mitsuhiko/flask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitsuhiko/flask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitsuhiko/flask/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitsuhiko/flask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitsuhiko/flask/statuses/{sha}","languages_url":"https://api.github.com/repos/mitsuhiko/flask/languages","stargazers_url":"https://api.github.com/repos/mitsuhiko/flask/stargazers","contributors_url":"https://api.github.com/repos/mitsuhiko/flask/contributors","subscribers_url":"https://api.github.com/repos/mitsuhiko/flask/subscribers","subscription_url":"https://api.github.com/repos/mitsuhiko/flask/subscription","commits_url":"https://api.github.com/repos/mitsuhiko/flask/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitsuhiko/flask/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitsuhiko/flask/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitsuhiko/flask/issues/comments/{number}","contents_url":"https://api.github.com/repos/mitsuhiko/flask/contents/{+path}","compare_url":"https://api.github.com/repos/mitsuhiko/flask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitsuhiko/flask/merges","archive_url":"https://api.github.com/repos/mitsuhiko/flask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitsuhiko/flask/downloads","issues_url":"https://api.github.com/repos/mitsuhiko/flask/issues{/number}","pulls_url":"https://api.github.com/repos/mitsuhiko/flask/pulls{/number}","milestones_url":"https://api.github.com/repos/mitsuhiko/flask/milestones{/number}","notifications_url":"https://api.github.com/repos/mitsuhiko/flask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitsuhiko/flask/labels{/name}","releases_url":"https://api.github.com/repos/mitsuhiko/flask/releases{/id}","created_at":"2010-04-06T11:11:59Z","updated_at":"2014-10-26T07:44:44Z","pushed_at":"2014-10-26T00:01:53Z","git_url":"git://github.com/mitsuhiko/flask.git","ssh_url":"git@github.com:mitsuhiko/flask.git","clone_url":"https://github.com/mitsuhiko/flask.git","svn_url":"https://github.com/mitsuhiko/flask","homepage":"http://flask.pocoo.org/","size":14498,"stargazers_count":11286,"watchers_count":11286,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3038,"mirror_url":null,"open_issues_count":111,"forks":3038,"open_issues":111,"watchers":11286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitsuhiko/flask/pulls/1221"},"html":{"href":"https://github.com/mitsuhiko/flask/pull/1221"},"issue":{"href":"https://api.github.com/repos/mitsuhiko/flask/issues/1221"},"comments":{"href":"https://api.github.com/repos/mitsuhiko/flask/issues/1221/comments"},"review_comments":{"href":"https://api.github.com/repos/mitsuhiko/flask/pulls/1221/comments"},"review_comment":{"href":"https://api.github.com/repos/mitsuhiko/flask/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mitsuhiko/flask/pulls/1221/commits"},"statuses":{"href":"https://api.github.com/repos/mitsuhiko/flask/statuses/9d24b1eac99bd69ac99c6a2dd652b912a4217cc3"}}}}