GitHub PullRequestReviewCommentEvent at 2014-07-25 17:25:42
Repository: jenkins
Actor: tfennelly
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/15413105","id":15413105,"diff_hunk":"@@ -1571,26 +1571,46 @@ function updateBuildHistory(ajaxUrl,nBuild) {\n             new Ajax.Request(ajaxUrl, {\n                 requestHeaders: bh.headers,\n                 onSuccess: function(rsp) {\n-                    var rows = bh.rows;\n-\n-                    //delete rows with transitive data\n-                    while (rows.length > 2 && Element.hasClassName(rows[1], \"transitive\"))\n-                        Element.remove(rows[1]);\n-\n-                    // insert new rows\n-                    var div = document.createElement('div');\n-                    div.innerHTML = rsp.responseText;\n-                    Behaviour.applySubtree(div);\n-\n-                    var pivot = rows[0];\n-                    var newRows = $(div).firstDescendant().rows;\n-                    for (var i = newRows.length - 1; i >= 0; i--) {\n-                        pivot.parentNode.insertBefore(newRows[i], pivot.nextSibling);\n+                    try {\n+                        var div = document.createElement('div');\n+                        div.innerHTML = rsp.responseText;\n+                        Behaviour.applySubtree(div);\n+                        var newRows = $(div).getElementsBySelector('.build-entry');\n+\n+                        if (newRows.length === 0) {\n+                            return;\n+                        }\n+\n+                        //delete rows with transitive data\n+                        var rows = bh.getElementsBySelector('.build-entry');\n+                        for (var i = 0; i < rows.length; i++) {\n+                            if ($(rows[i]).hasClassName(\"transitive\")) {\n+                                rows[i].parentNode.removeChild(rows[i]);\n+                            }\n+                        }\n+                        rows = bh.getElementsBySelector('.build-entry');\n+\n+                        // insert new rows\n+                        var pivot = undefined;","path":"war/src/main/webapp/scripts/hudson-behavior.js","position":39,"original_position":39,"commit_id":"046fa72876502f731520d9a91b120a24ca9ca44e","original_commit_id":"046fa72876502f731520d9a91b120a24ca9ca44e","user":{"login":"tfennelly","id":429311,"avatar_url":"https://avatars.githubusercontent.com/u/429311?","gravatar_id":"6bbe8793b28e60ea9893fcdd7e5bf978","url":"https://api.github.com/users/tfennelly","html_url":"https://github.com/tfennelly","followers_url":"https://api.github.com/users/tfennelly/followers","following_url":"https://api.github.com/users/tfennelly/following{/other_user}","gists_url":"https://api.github.com/users/tfennelly/gists{/gist_id}","starred_url":"https://api.github.com/users/tfennelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfennelly/subscriptions","organizations_url":"https://api.github.com/users/tfennelly/orgs","repos_url":"https://api.github.com/users/tfennelly/repos","events_url":"https://api.github.com/users/tfennelly/events{/privacy}","received_events_url":"https://api.github.com/users/tfennelly/received_events","type":"User","site_admin":false},"body":"Sure... that's just a habit.  Not a bad one imo.","created_at":"2014-07-25T17:25:42Z","updated_at":"2014-07-25T17:25:42Z","html_url":"https://github.com/jenkinsci/jenkins/pull/1321#discussion_r15413105","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1321","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/15413105"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1321#discussion_r15413105"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1321"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1321","id":18489819,"html_url":"https://github.com/jenkinsci/jenkins/pull/1321","diff_url":"https://github.com/jenkinsci/jenkins/pull/1321.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1321.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1321","number":1321,"state":"open","title":"[WIP] Replace table based panes (build queue, build executors, build history) with a div based approach","user":{"login":"tfennelly","id":429311,"avatar_url":"https://avatars.githubusercontent.com/u/429311?","gravatar_id":"6bbe8793b28e60ea9893fcdd7e5bf978","url":"https://api.github.com/users/tfennelly","html_url":"https://github.com/tfennelly","followers_url":"https://api.github.com/users/tfennelly/followers","following_url":"https://api.github.com/users/tfennelly/following{/other_user}","gists_url":"https://api.github.com/users/tfennelly/gists{/gist_id}","starred_url":"https://api.github.com/users/tfennelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfennelly/subscriptions","organizations_url":"https://api.github.com/users/tfennelly/orgs","repos_url":"https://api.github.com/users/tfennelly/repos","events_url":"https://api.github.com/users/tfennelly/events{/privacy}","received_events_url":"https://api.github.com/users/tfennelly/received_events","type":"User","site_admin":false},"body":"This is a WIP.\r\n\r\nTrying to replace the current `<l:pane>` based panels with `<div>` based alternatives:\r\n\r\n1.  Created a new set of tags (`<l:divpane>`, `<l:divpaneRow>` and `<l:divpaneCell>`) to replace the current `<l:pane>` tag.\r\n2.  Updated the Build Queue, Executors and History panes to use this approach.\r\n3.  Can see it here: http://166.78.9.27:8080/\r\n\r\nIntentionally looks similar to current pane but I'm hoping it will work better with new layout.\r\n\r\nLooking for people to let me know what they think of this and what issues they foresee.","created_at":"2014-07-16T19:35:42Z","updated_at":"2014-07-25T17:25:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"619d8fef3ff867f0ee3ce74fd91e679cb0877aa9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1321/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1321/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1321/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/046fa72876502f731520d9a91b120a24ca9ca44e","head":{"label":"tfennelly:JENKINS-23810","ref":"JENKINS-23810","sha":"046fa72876502f731520d9a91b120a24ca9ca44e","user":{"login":"tfennelly","id":429311,"avatar_url":"https://avatars.githubusercontent.com/u/429311?","gravatar_id":"6bbe8793b28e60ea9893fcdd7e5bf978","url":"https://api.github.com/users/tfennelly","html_url":"https://github.com/tfennelly","followers_url":"https://api.github.com/users/tfennelly/followers","following_url":"https://api.github.com/users/tfennelly/following{/other_user}","gists_url":"https://api.github.com/users/tfennelly/gists{/gist_id}","starred_url":"https://api.github.com/users/tfennelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfennelly/subscriptions","organizations_url":"https://api.github.com/users/tfennelly/orgs","repos_url":"https://api.github.com/users/tfennelly/repos","events_url":"https://api.github.com/users/tfennelly/events{/privacy}","received_events_url":"https://api.github.com/users/tfennelly/received_events","type":"User","site_admin":false},"repo":{"id":14962669,"name":"jenkins","full_name":"tfennelly/jenkins","owner":{"login":"tfennelly","id":429311,"avatar_url":"https://avatars.githubusercontent.com/u/429311?","gravatar_id":"6bbe8793b28e60ea9893fcdd7e5bf978","url":"https://api.github.com/users/tfennelly","html_url":"https://github.com/tfennelly","followers_url":"https://api.github.com/users/tfennelly/followers","following_url":"https://api.github.com/users/tfennelly/following{/other_user}","gists_url":"https://api.github.com/users/tfennelly/gists{/gist_id}","starred_url":"https://api.github.com/users/tfennelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfennelly/subscriptions","organizations_url":"https://api.github.com/users/tfennelly/orgs","repos_url":"https://api.github.com/users/tfennelly/repos","events_url":"https://api.github.com/users/tfennelly/events{/privacy}","received_events_url":"https://api.github.com/users/tfennelly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tfennelly/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/tfennelly/jenkins","forks_url":"https://api.github.com/repos/tfennelly/jenkins/forks","keys_url":"https://api.github.com/repos/tfennelly/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tfennelly/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tfennelly/jenkins/teams","hooks_url":"https://api.github.com/repos/tfennelly/jenkins/hooks","issue_events_url":"https://api.github.com/repos/tfennelly/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/tfennelly/jenkins/events","assignees_url":"https://api.github.com/repos/tfennelly/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/tfennelly/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/tfennelly/jenkins/tags","blobs_url":"https://api.github.com/repos/tfennelly/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tfennelly/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tfennelly/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/tfennelly/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tfennelly/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/tfennelly/jenkins/languages","stargazers_url":"https://api.github.com/repos/tfennelly/jenkins/stargazers","contributors_url":"https://api.github.com/repos/tfennelly/jenkins/contributors","subscribers_url":"https://api.github.com/repos/tfennelly/jenkins/subscribers","subscription_url":"https://api.github.com/repos/tfennelly/jenkins/subscription","commits_url":"https://api.github.com/repos/tfennelly/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/tfennelly/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/tfennelly/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/tfennelly/jenkins/issues/comments/{number}","contents_url":"https://api.github.com/repos/tfennelly/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/tfennelly/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tfennelly/jenkins/merges","archive_url":"https://api.github.com/repos/tfennelly/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tfennelly/jenkins/downloads","issues_url":"https://api.github.com/repos/tfennelly/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/tfennelly/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/tfennelly/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/tfennelly/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tfennelly/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/tfennelly/jenkins/releases{/id}","created_at":"2013-12-05T18:53:16Z","updated_at":"2014-07-07T09:08:12Z","pushed_at":"2014-07-24T23:25:14Z","git_url":"git://github.com/tfennelly/jenkins.git","ssh_url":"git@github.com:tfennelly/jenkins.git","clone_url":"https://github.com/tfennelly/jenkins.git","svn_url":"https://github.com/tfennelly/jenkins","homepage":"http://jenkins-ci.org/","size":78085,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"7d0d10c0a82dcbe37d547a87b0c0d78e918971b4","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?","gravatar_id":"ceb204ad3216b4594ba32364def06deb","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?","gravatar_id":"ceb204ad3216b4594ba32364def06deb","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments/{number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","created_at":"2010-11-22T21:21:23Z","updated_at":"2014-07-25T12:41:36Z","pushed_at":"2014-07-25T11:18:51Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":362910,"stargazers_count":3064,"watchers_count":3064,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":1397,"mirror_url":null,"open_issues_count":73,"forks":1397,"open_issues":73,"watchers":3064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1321"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1321"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1321"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1321/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1321/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1321/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/046fa72876502f731520d9a91b120a24ca9ca44e"}}}}