GitHub PullRequestEvent at 2014-01-15 21:22:04
Repository: wingolfsplattform
Actor: jbx26
Payload: {"action":"opened","number":14,"pull_request":{"url":"https://api.github.com/repos/fiedl/wingolfsplattform/pulls/14","id":11553761,"html_url":"https://github.com/fiedl/wingolfsplattform/pull/14","diff_url":"https://github.com/fiedl/wingolfsplattform/pull/14.diff","patch_url":"https://github.com/fiedl/wingolfsplattform/pull/14.patch","issue_url":"https://github.com/fiedl/wingolfsplattform/pull/14","number":14,"state":"open","title":"Jb/flat member list","user":{"login":"jbx26","id":5446630,"avatar_url":"https://gravatar.com/avatar/fdc6b2ccc31b6d0b3d7f919dffdc8702?d=https%3A%2F%2Fidenticons.github.com%2F5764d8f614f821cbd6f8d3bbef089db3.png&r=x","gravatar_id":"fdc6b2ccc31b6d0b3d7f919dffdc8702","url":"https://api.github.com/users/jbx26","html_url":"https://github.com/jbx26","followers_url":"https://api.github.com/users/jbx26/followers","following_url":"https://api.github.com/users/jbx26/following{/other_user}","gists_url":"https://api.github.com/users/jbx26/gists{/gist_id}","starred_url":"https://api.github.com/users/jbx26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbx26/subscriptions","organizations_url":"https://api.github.com/users/jbx26/orgs","repos_url":"https://api.github.com/users/jbx26/repos","events_url":"https://api.github.com/users/jbx26/events{/privacy}","received_events_url":"https://api.github.com/users/jbx26/received_events","type":"User","site_admin":false},"body":"My intension:\r\nI wanted to reduce the database accesses \r\nby caching it or\r\nby fetching the necessary data only or \r\nby reducing the complexity of data shown to the user.\r\n\r\nMy changes:\r\n1. The computation if the user can manage a group does not longer create officers and admin groups\r\n2. The Aktivitaetszahl and the My_Groups_Table are cached as long as a group membership of the user is commited.\r\n3. Fixed a bug that indirect members were not unique\r\n4. Increased Capybara default_wait_time for bundle exec rake\r\n5. For a group show all indirect members in a flat list and do NOT show the subgroups or the user group membershio for subgroups\r\n6. Show officers if there are any officer sub groups\r\n7. Do NOT show links for each officer.\r\n\r\nThe effect:\r\nThe most group pages last 2 seconds instead of 4-6 seconds. The \"WingolfAmHochschulort\" group is loadable.","created_at":"2014-01-15T21:22:03Z","updated_at":"2014-01-15T21:22:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d1681e10a226f2071f3bf4fc4d183d4bb3f0169","assignee":null,"milestone":null,"commits_url":"https://github.com/fiedl/wingolfsplattform/pull/14/commits","review_comments_url":"https://github.com/fiedl/wingolfsplattform/pull/14/comments","review_comment_url":"/repos/fiedl/wingolfsplattform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fiedl/wingolfsplattform/issues/14/comments","statuses_url":"https://api.github.com/repos/fiedl/wingolfsplattform/statuses/d30140901cd5ba2cfad37340bbac024911a7431d","head":{"label":"fiedl:jb/flat_member_list","ref":"jb/flat_member_list","sha":"d30140901cd5ba2cfad37340bbac024911a7431d","user":{"login":"fiedl","id":1679688,"avatar_url":"https://gravatar.com/avatar/53db0a9ff52824941a90d07d83d7d055?d=https%3A%2F%2Fidenticons.github.com%2F6eedef007bd2575e25630acf8c2ac652.png&r=x","gravatar_id":"53db0a9ff52824941a90d07d83d7d055","url":"https://api.github.com/users/fiedl","html_url":"https://github.com/fiedl","followers_url":"https://api.github.com/users/fiedl/followers","following_url":"https://api.github.com/users/fiedl/following{/other_user}","gists_url":"https://api.github.com/users/fiedl/gists{/gist_id}","starred_url":"https://api.github.com/users/fiedl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiedl/subscriptions","organizations_url":"https://api.github.com/users/fiedl/orgs","repos_url":"https://api.github.com/users/fiedl/repos","events_url":"https://api.github.com/users/fiedl/events{/privacy}","received_events_url":"https://api.github.com/users/fiedl/received_events","type":"User","site_admin":false},"repo":{"id":4224957,"name":"wingolfsplattform","full_name":"fiedl/wingolfsplattform","owner":{"login":"fiedl","id":1679688,"avatar_url":"https://gravatar.com/avatar/53db0a9ff52824941a90d07d83d7d055?d=https%3A%2F%2Fidenticons.github.com%2F6eedef007bd2575e25630acf8c2ac652.png&r=x","gravatar_id":"53db0a9ff52824941a90d07d83d7d055","url":"https://api.github.com/users/fiedl","html_url":"https://github.com/fiedl","followers_url":"https://api.github.com/users/fiedl/followers","following_url":"https://api.github.com/users/fiedl/following{/other_user}","gists_url":"https://api.github.com/users/fiedl/gists{/gist_id}","starred_url":"https://api.github.com/users/fiedl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiedl/subscriptions","organizations_url":"https://api.github.com/users/fiedl/orgs","repos_url":"https://api.github.com/users/fiedl/repos","events_url":"https://api.github.com/users/fiedl/events{/privacy}","received_events_url":"https://api.github.com/users/fiedl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fiedl/wingolfsplattform","description":"Wingolfsplattform. AK Internet von Wingolfsbund und VAW.","fork":false,"url":"https://api.github.com/repos/fiedl/wingolfsplattform","forks_url":"https://api.github.com/repos/fiedl/wingolfsplattform/forks","keys_url":"https://api.github.com/repos/fiedl/wingolfsplattform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fiedl/wingolfsplattform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fiedl/wingolfsplattform/teams","hooks_url":"https://api.github.com/repos/fiedl/wingolfsplattform/hooks","issue_events_url":"https://api.github.com/repos/fiedl/wingolfsplattform/issues/events{/number}","events_url":"https://api.github.com/repos/fiedl/wingolfsplattform/events","assignees_url":"https://api.github.com/repos/fiedl/wingolfsplattform/assignees{/user}","branches_url":"https://api.github.com/repos/fiedl/wingolfsplattform/branches{/branch}","tags_url":"https://api.github.com/repos/fiedl/wingolfsplattform/tags","blobs_url":"https://api.github.com/repos/fiedl/wingolfsplattform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fiedl/wingolfsplattform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fiedl/wingolfsplattform/git/refs{/sha}","trees_url":"https://api.github.com/repos/fiedl/wingolfsplattform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fiedl/wingolfsplattform/statuses/{sha}","languages_url":"https://api.github.com/repos/fiedl/wingolfsplattform/languages","stargazers_url":"https://api.github.com/repos/fiedl/wingolfsplattform/stargazers","contributors_url":"https://api.github.com/repos/fiedl/wingolfsplattform/contributors","subscribers_url":"https://api.github.com/repos/fiedl/wingolfsplattform/subscribers","subscription_url":"https://api.github.com/repos/fiedl/wingolfsplattform/subscription","commits_url":"https://api.github.com/repos/fiedl/wingolfsplattform/commits{/sha}","git_commits_url":"https://api.github.com/repos/fiedl/wingolfsplattform/git/commits{/sha}","comments_url":"https://api.github.com/repos/fiedl/wingolfsplattform/comments{/number}","issue_comment_url":"https://api.github.com/repos/fiedl/wingolfsplattform/issues/comments/{number}","contents_url":"https://api.github.com/repos/fiedl/wingolfsplattform/contents/{+path}","compare_url":"https://api.github.com/repos/fiedl/wingolfsplattform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fiedl/wingolfsplattform/merges","archive_url":"https://api.github.com/repos/fiedl/wingolfsplattform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fiedl/wingolfsplattform/downloads","issues_url":"https://api.github.com/repos/fiedl/wingolfsplattform/issues{/number}","pulls_url":"https://api.github.com/repos/fiedl/wingolfsplattform/pulls{/number}","milestones_url":"https://api.github.com/repos/fiedl/wingolfsplattform/milestones{/number}","notifications_url":"https://api.github.com/repos/fiedl/wingolfsplattform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fiedl/wingolfsplattform/labels{/name}","releases_url":"https://api.github.com/repos/fiedl/wingolfsplattform/releases{/id}","created_at":"2012-05-04T13:18:35Z","updated_at":"2014-01-15T21:22:03Z","pushed_at":"2014-01-15T21:12:23Z","git_url":"git://github.com/fiedl/wingolfsplattform.git","ssh_url":"git@github.com:fiedl/wingolfsplattform.git","clone_url":"https://github.com/fiedl/wingolfsplattform.git","svn_url":"https://github.com/fiedl/wingolfsplattform","homepage":"","size":17832,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master","master_branch":"master"}},"base":{"label":"fiedl:master","ref":"master","sha":"b396315341b7c75d7642dd50857a7a334d9e7878","user":{"login":"fiedl","id":1679688,"avatar_url":"https://gravatar.com/avatar/53db0a9ff52824941a90d07d83d7d055?d=https%3A%2F%2Fidenticons.github.com%2F6eedef007bd2575e25630acf8c2ac652.png&r=x","gravatar_id":"53db0a9ff52824941a90d07d83d7d055","url":"https://api.github.com/users/fiedl","html_url":"https://github.com/fiedl","followers_url":"https://api.github.com/users/fiedl/followers","following_url":"https://api.github.com/users/fiedl/following{/other_user}","gists_url":"https://api.github.com/users/fiedl/gists{/gist_id}","starred_url":"https://api.github.com/users/fiedl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiedl/subscriptions","organizations_url":"https://api.github.com/users/fiedl/orgs","repos_url":"https://api.github.com/users/fiedl/repos","events_url":"https://api.github.com/users/fiedl/events{/privacy}","received_events_url":"https://api.github.com/users/fiedl/received_events","type":"User","site_admin":false},"repo":{"id":4224957,"name":"wingolfsplattform","full_name":"fiedl/wingolfsplattform","owner":{"login":"fiedl","id":1679688,"avatar_url":"https://gravatar.com/avatar/53db0a9ff52824941a90d07d83d7d055?d=https%3A%2F%2Fidenticons.github.com%2F6eedef007bd2575e25630acf8c2ac652.png&r=x","gravatar_id":"53db0a9ff52824941a90d07d83d7d055","url":"https://api.github.com/users/fiedl","html_url":"https://github.com/fiedl","followers_url":"https://api.github.com/users/fiedl/followers","following_url":"https://api.github.com/users/fiedl/following{/other_user}","gists_url":"https://api.github.com/users/fiedl/gists{/gist_id}","starred_url":"https://api.github.com/users/fiedl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiedl/subscriptions","organizations_url":"https://api.github.com/users/fiedl/orgs","repos_url":"https://api.github.com/users/fiedl/repos","events_url":"https://api.github.com/users/fiedl/events{/privacy}","received_events_url":"https://api.github.com/users/fiedl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fiedl/wingolfsplattform","description":"Wingolfsplattform. AK Internet von Wingolfsbund und VAW.","fork":false,"url":"https://api.github.com/repos/fiedl/wingolfsplattform","forks_url":"https://api.github.com/repos/fiedl/wingolfsplattform/forks","keys_url":"https://api.github.com/repos/fiedl/wingolfsplattform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fiedl/wingolfsplattform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fiedl/wingolfsplattform/teams","hooks_url":"https://api.github.com/repos/fiedl/wingolfsplattform/hooks","issue_events_url":"https://api.github.com/repos/fiedl/wingolfsplattform/issues/events{/number}","events_url":"https://api.github.com/repos/fiedl/wingolfsplattform/events","assignees_url":"https://api.github.com/repos/fiedl/wingolfsplattform/assignees{/user}","branches_url":"https://api.github.com/repos/fiedl/wingolfsplattform/branches{/branch}","tags_url":"https://api.github.com/repos/fiedl/wingolfsplattform/tags","blobs_url":"https://api.github.com/repos/fiedl/wingolfsplattform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fiedl/wingolfsplattform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fiedl/wingolfsplattform/git/refs{/sha}","trees_url":"https://api.github.com/repos/fiedl/wingolfsplattform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fiedl/wingolfsplattform/statuses/{sha}","languages_url":"https://api.github.com/repos/fiedl/wingolfsplattform/languages","stargazers_url":"https://api.github.com/repos/fiedl/wingolfsplattform/stargazers","contributors_url":"https://api.github.com/repos/fiedl/wingolfsplattform/contributors","subscribers_url":"https://api.github.com/repos/fiedl/wingolfsplattform/subscribers","subscription_url":"https://api.github.com/repos/fiedl/wingolfsplattform/subscription","commits_url":"https://api.github.com/repos/fiedl/wingolfsplattform/commits{/sha}","git_commits_url":"https://api.github.com/repos/fiedl/wingolfsplattform/git/commits{/sha}","comments_url":"https://api.github.com/repos/fiedl/wingolfsplattform/comments{/number}","issue_comment_url":"https://api.github.com/repos/fiedl/wingolfsplattform/issues/comments/{number}","contents_url":"https://api.github.com/repos/fiedl/wingolfsplattform/contents/{+path}","compare_url":"https://api.github.com/repos/fiedl/wingolfsplattform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fiedl/wingolfsplattform/merges","archive_url":"https://api.github.com/repos/fiedl/wingolfsplattform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fiedl/wingolfsplattform/downloads","issues_url":"https://api.github.com/repos/fiedl/wingolfsplattform/issues{/number}","pulls_url":"https://api.github.com/repos/fiedl/wingolfsplattform/pulls{/number}","milestones_url":"https://api.github.com/repos/fiedl/wingolfsplattform/milestones{/number}","notifications_url":"https://api.github.com/repos/fiedl/wingolfsplattform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fiedl/wingolfsplattform/labels{/name}","releases_url":"https://api.github.com/repos/fiedl/wingolfsplattform/releases{/id}","created_at":"2012-05-04T13:18:35Z","updated_at":"2014-01-15T21:22:03Z","pushed_at":"2014-01-15T21:12:23Z","git_url":"git://github.com/fiedl/wingolfsplattform.git","ssh_url":"git@github.com:fiedl/wingolfsplattform.git","clone_url":"https://github.com/fiedl/wingolfsplattform.git","svn_url":"https://github.com/fiedl/wingolfsplattform","homepage":"","size":17832,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fiedl/wingolfsplattform/pulls/14"},"html":{"href":"https://github.com/fiedl/wingolfsplattform/pull/14"},"issue":{"href":"https://api.github.com/repos/fiedl/wingolfsplattform/issues/14"},"comments":{"href":"https://api.github.com/repos/fiedl/wingolfsplattform/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/fiedl/wingolfsplattform/pulls/14/comments"},"statuses":{"href":"https://api.github.com/repos/fiedl/wingolfsplattform/statuses/d30140901cd5ba2cfad37340bbac024911a7431d"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":10,"additions":59,"deletions":31,"changed_files":13}}