GitHub PullRequestReviewCommentEvent at 2014-07-31 15:03:24
Repository: daybed
Actor: ametaireau
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spiral-project/daybed/pulls/comments/15647371","id":15647371,"diff_hunk":"@@ -83,12 +92,19 @@ def get(request):\n         return request.db.get_record(model_id, record_id)\n     except RecordNotFound:\n         request.response.status = \"404 Not Found\"\n-        return {\"msg\": \"%s: record not found %s\" % (model_id, record_id)}\n+        return {\n+            \"error\": \"404 Not Found\",\n+            \"msg\": \"%s: record not found %s\" % (model_id, record_id)\n+        }\n \n \n @record.put(validators=record_validator, permission='put_record')\n def put(request):\n     \"\"\"Updates or creates a record.\"\"\"\n+    # if we are asked only for validation, don't do anything more.\n+    if request.headers.get('Daybed-Validate-Only', 'false') == 'true':","path":"daybed/views/records.py","position":79,"original_position":79,"commit_id":"38039e5fb15a9ba9a4bac16a38b44b107303e5a6","original_commit_id":"be8e35464e09f5ed135517d60dcf3d030351ec07","user":{"login":"ametaireau","id":67073,"avatar_url":"https://avatars.githubusercontent.com/u/67073?v=1","gravatar_id":"1b3ec4d4db1722e0459151ff9fd054f2","url":"https://api.github.com/users/ametaireau","html_url":"https://github.com/ametaireau","followers_url":"https://api.github.com/users/ametaireau/followers","following_url":"https://api.github.com/users/ametaireau/following{/other_user}","gists_url":"https://api.github.com/users/ametaireau/gists{/gist_id}","starred_url":"https://api.github.com/users/ametaireau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ametaireau/subscriptions","organizations_url":"https://api.github.com/users/ametaireau/orgs","repos_url":"https://api.github.com/users/ametaireau/repos","events_url":"https://api.github.com/users/ametaireau/events{/privacy}","received_events_url":"https://api.github.com/users/ametaireau/received_events","type":"User","site_admin":false},"body":"Not related to this PR, but I guess we should remove the \"Daybed\" prefix :)","created_at":"2014-07-31T15:03:24Z","updated_at":"2014-07-31T15:03:24Z","html_url":"https://github.com/spiral-project/daybed/pull/185#discussion_r15647371","pull_request_url":"https://api.github.com/repos/spiral-project/daybed/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/spiral-project/daybed/pulls/comments/15647371"},"html":{"href":"https://github.com/spiral-project/daybed/pull/185#discussion_r15647371"},"pull_request":{"href":"https://api.github.com/repos/spiral-project/daybed/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/spiral-project/daybed/pulls/185","id":19039141,"html_url":"https://github.com/spiral-project/daybed/pull/185","diff_url":"https://github.com/spiral-project/daybed/pull/185.diff","patch_url":"https://github.com/spiral-project/daybed/pull/185.patch","issue_url":"https://api.github.com/repos/spiral-project/daybed/issues/185","number":185,"state":"open","title":"Add PUT and PATCH on models/{modelname}/acls endpoint.","user":{"login":"Natim","id":229453,"avatar_url":"https://avatars.githubusercontent.com/u/229453?v=1","gravatar_id":"48e87ebebf7bee2a0ca10aa2362795a6","url":"https://api.github.com/users/Natim","html_url":"https://github.com/Natim","followers_url":"https://api.github.com/users/Natim/followers","following_url":"https://api.github.com/users/Natim/following{/other_user}","gists_url":"https://api.github.com/users/Natim/gists{/gist_id}","starred_url":"https://api.github.com/users/Natim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Natim/subscriptions","organizations_url":"https://api.github.com/users/Natim/orgs","repos_url":"https://api.github.com/users/Natim/repos","events_url":"https://api.github.com/users/Natim/events{/privacy}","received_events_url":"https://api.github.com/users/Natim/received_events","type":"User","site_admin":false},"body":null,"created_at":"2014-07-29T16:47:55Z","updated_at":"2014-07-31T15:03:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cde5ff7064f1823628d6c00cdf9fddc77bca7c18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spiral-project/daybed/pulls/185/commits","review_comments_url":"https://api.github.com/repos/spiral-project/daybed/pulls/185/comments","review_comment_url":"https://api.github.com/repos/spiral-project/daybed/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spiral-project/daybed/issues/185/comments","statuses_url":"https://api.github.com/repos/spiral-project/daybed/statuses/38039e5fb15a9ba9a4bac16a38b44b107303e5a6","head":{"label":"spiral-project:patch_acls","ref":"patch_acls","sha":"38039e5fb15a9ba9a4bac16a38b44b107303e5a6","user":{"login":"spiral-project","id":991307,"avatar_url":"https://avatars.githubusercontent.com/u/991307?v=1","gravatar_id":"149544843e9dac05d3a0dc1fd0eef7c7","url":"https://api.github.com/users/spiral-project","html_url":"https://github.com/spiral-project","followers_url":"https://api.github.com/users/spiral-project/followers","following_url":"https://api.github.com/users/spiral-project/following{/other_user}","gists_url":"https://api.github.com/users/spiral-project/gists{/gist_id}","starred_url":"https://api.github.com/users/spiral-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiral-project/subscriptions","organizations_url":"https://api.github.com/users/spiral-project/orgs","repos_url":"https://api.github.com/users/spiral-project/repos","events_url":"https://api.github.com/users/spiral-project/events{/privacy}","received_events_url":"https://api.github.com/users/spiral-project/received_events","type":"Organization","site_admin":false},"repo":{"id":4032943,"name":"daybed","full_name":"spiral-project/daybed","owner":{"login":"spiral-project","id":991307,"avatar_url":"https://avatars.githubusercontent.com/u/991307?v=1","gravatar_id":"149544843e9dac05d3a0dc1fd0eef7c7","url":"https://api.github.com/users/spiral-project","html_url":"https://github.com/spiral-project","followers_url":"https://api.github.com/users/spiral-project/followers","following_url":"https://api.github.com/users/spiral-project/following{/other_user}","gists_url":"https://api.github.com/users/spiral-project/gists{/gist_id}","starred_url":"https://api.github.com/users/spiral-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiral-project/subscriptions","organizations_url":"https://api.github.com/users/spiral-project/orgs","repos_url":"https://api.github.com/users/spiral-project/repos","events_url":"https://api.github.com/users/spiral-project/events{/privacy}","received_events_url":"https://api.github.com/users/spiral-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spiral-project/daybed","description":"Form validation and data storage API","fork":false,"url":"https://api.github.com/repos/spiral-project/daybed","forks_url":"https://api.github.com/repos/spiral-project/daybed/forks","keys_url":"https://api.github.com/repos/spiral-project/daybed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spiral-project/daybed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spiral-project/daybed/teams","hooks_url":"https://api.github.com/repos/spiral-project/daybed/hooks","issue_events_url":"https://api.github.com/repos/spiral-project/daybed/issues/events{/number}","events_url":"https://api.github.com/repos/spiral-project/daybed/events","assignees_url":"https://api.github.com/repos/spiral-project/daybed/assignees{/user}","branches_url":"https://api.github.com/repos/spiral-project/daybed/branches{/branch}","tags_url":"https://api.github.com/repos/spiral-project/daybed/tags","blobs_url":"https://api.github.com/repos/spiral-project/daybed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spiral-project/daybed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spiral-project/daybed/git/refs{/sha}","trees_url":"https://api.github.com/repos/spiral-project/daybed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spiral-project/daybed/statuses/{sha}","languages_url":"https://api.github.com/repos/spiral-project/daybed/languages","stargazers_url":"https://api.github.com/repos/spiral-project/daybed/stargazers","contributors_url":"https://api.github.com/repos/spiral-project/daybed/contributors","subscribers_url":"https://api.github.com/repos/spiral-project/daybed/subscribers","subscription_url":"https://api.github.com/repos/spiral-project/daybed/subscription","commits_url":"https://api.github.com/repos/spiral-project/daybed/commits{/sha}","git_commits_url":"https://api.github.com/repos/spiral-project/daybed/git/commits{/sha}","comments_url":"https://api.github.com/repos/spiral-project/daybed/comments{/number}","issue_comment_url":"https://api.github.com/repos/spiral-project/daybed/issues/comments/{number}","contents_url":"https://api.github.com/repos/spiral-project/daybed/contents/{+path}","compare_url":"https://api.github.com/repos/spiral-project/daybed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spiral-project/daybed/merges","archive_url":"https://api.github.com/repos/spiral-project/daybed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spiral-project/daybed/downloads","issues_url":"https://api.github.com/repos/spiral-project/daybed/issues{/number}","pulls_url":"https://api.github.com/repos/spiral-project/daybed/pulls{/number}","milestones_url":"https://api.github.com/repos/spiral-project/daybed/milestones{/number}","notifications_url":"https://api.github.com/repos/spiral-project/daybed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spiral-project/daybed/labels{/name}","releases_url":"https://api.github.com/repos/spiral-project/daybed/releases{/id}","created_at":"2012-04-15T15:45:01Z","updated_at":"2014-07-23T14:26:06Z","pushed_at":"2014-07-31T14:59:07Z","git_url":"git://github.com/spiral-project/daybed.git","ssh_url":"git@github.com:spiral-project/daybed.git","clone_url":"https://github.com/spiral-project/daybed.git","svn_url":"https://github.com/spiral-project/daybed","homepage":"http://daybed.rtfd.org/","size":4620,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":26,"forks":6,"open_issues":26,"watchers":27,"default_branch":"master"}},"base":{"label":"spiral-project:master","ref":"master","sha":"9db3381e8b9d943da6569cf7a43e88842a6427a0","user":{"login":"spiral-project","id":991307,"avatar_url":"https://avatars.githubusercontent.com/u/991307?v=1","gravatar_id":"149544843e9dac05d3a0dc1fd0eef7c7","url":"https://api.github.com/users/spiral-project","html_url":"https://github.com/spiral-project","followers_url":"https://api.github.com/users/spiral-project/followers","following_url":"https://api.github.com/users/spiral-project/following{/other_user}","gists_url":"https://api.github.com/users/spiral-project/gists{/gist_id}","starred_url":"https://api.github.com/users/spiral-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiral-project/subscriptions","organizations_url":"https://api.github.com/users/spiral-project/orgs","repos_url":"https://api.github.com/users/spiral-project/repos","events_url":"https://api.github.com/users/spiral-project/events{/privacy}","received_events_url":"https://api.github.com/users/spiral-project/received_events","type":"Organization","site_admin":false},"repo":{"id":4032943,"name":"daybed","full_name":"spiral-project/daybed","owner":{"login":"spiral-project","id":991307,"avatar_url":"https://avatars.githubusercontent.com/u/991307?v=1","gravatar_id":"149544843e9dac05d3a0dc1fd0eef7c7","url":"https://api.github.com/users/spiral-project","html_url":"https://github.com/spiral-project","followers_url":"https://api.github.com/users/spiral-project/followers","following_url":"https://api.github.com/users/spiral-project/following{/other_user}","gists_url":"https://api.github.com/users/spiral-project/gists{/gist_id}","starred_url":"https://api.github.com/users/spiral-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiral-project/subscriptions","organizations_url":"https://api.github.com/users/spiral-project/orgs","repos_url":"https://api.github.com/users/spiral-project/repos","events_url":"https://api.github.com/users/spiral-project/events{/privacy}","received_events_url":"https://api.github.com/users/spiral-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spiral-project/daybed","description":"Form validation and data storage API","fork":false,"url":"https://api.github.com/repos/spiral-project/daybed","forks_url":"https://api.github.com/repos/spiral-project/daybed/forks","keys_url":"https://api.github.com/repos/spiral-project/daybed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spiral-project/daybed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spiral-project/daybed/teams","hooks_url":"https://api.github.com/repos/spiral-project/daybed/hooks","issue_events_url":"https://api.github.com/repos/spiral-project/daybed/issues/events{/number}","events_url":"https://api.github.com/repos/spiral-project/daybed/events","assignees_url":"https://api.github.com/repos/spiral-project/daybed/assignees{/user}","branches_url":"https://api.github.com/repos/spiral-project/daybed/branches{/branch}","tags_url":"https://api.github.com/repos/spiral-project/daybed/tags","blobs_url":"https://api.github.com/repos/spiral-project/daybed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spiral-project/daybed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spiral-project/daybed/git/refs{/sha}","trees_url":"https://api.github.com/repos/spiral-project/daybed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spiral-project/daybed/statuses/{sha}","languages_url":"https://api.github.com/repos/spiral-project/daybed/languages","stargazers_url":"https://api.github.com/repos/spiral-project/daybed/stargazers","contributors_url":"https://api.github.com/repos/spiral-project/daybed/contributors","subscribers_url":"https://api.github.com/repos/spiral-project/daybed/subscribers","subscription_url":"https://api.github.com/repos/spiral-project/daybed/subscription","commits_url":"https://api.github.com/repos/spiral-project/daybed/commits{/sha}","git_commits_url":"https://api.github.com/repos/spiral-project/daybed/git/commits{/sha}","comments_url":"https://api.github.com/repos/spiral-project/daybed/comments{/number}","issue_comment_url":"https://api.github.com/repos/spiral-project/daybed/issues/comments/{number}","contents_url":"https://api.github.com/repos/spiral-project/daybed/contents/{+path}","compare_url":"https://api.github.com/repos/spiral-project/daybed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spiral-project/daybed/merges","archive_url":"https://api.github.com/repos/spiral-project/daybed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spiral-project/daybed/downloads","issues_url":"https://api.github.com/repos/spiral-project/daybed/issues{/number}","pulls_url":"https://api.github.com/repos/spiral-project/daybed/pulls{/number}","milestones_url":"https://api.github.com/repos/spiral-project/daybed/milestones{/number}","notifications_url":"https://api.github.com/repos/spiral-project/daybed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spiral-project/daybed/labels{/name}","releases_url":"https://api.github.com/repos/spiral-project/daybed/releases{/id}","created_at":"2012-04-15T15:45:01Z","updated_at":"2014-07-23T14:26:06Z","pushed_at":"2014-07-31T14:59:07Z","git_url":"git://github.com/spiral-project/daybed.git","ssh_url":"git@github.com:spiral-project/daybed.git","clone_url":"https://github.com/spiral-project/daybed.git","svn_url":"https://github.com/spiral-project/daybed","homepage":"http://daybed.rtfd.org/","size":4620,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":26,"forks":6,"open_issues":26,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spiral-project/daybed/pulls/185"},"html":{"href":"https://github.com/spiral-project/daybed/pull/185"},"issue":{"href":"https://api.github.com/repos/spiral-project/daybed/issues/185"},"comments":{"href":"https://api.github.com/repos/spiral-project/daybed/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/spiral-project/daybed/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/spiral-project/daybed/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spiral-project/daybed/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/spiral-project/daybed/statuses/38039e5fb15a9ba9a4bac16a38b44b107303e5a6"}}}}