GitHub PullRequestReviewCommentEvent at 2014-11-13 16:06:47
Repository: harprofiler
Actor: benpatterson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/edx/harprofiler/pulls/comments/20301130","id":20301130,"diff_hunk":"@@ -56,45 +56,41 @@ Usage\n \n run pageload profiler::\n \n-    $ python harprofiler.py\n+    $ harprofiler-c myconfig.yaml\n \n * results are saved in timestamped .har files\n \n \n haruploader\n------------\n+==========\n \n-The :code:`haruploader` module is used for sending har files to a :code:`harstorage` instance.\n+The `haruploader` module is used for sending har files to a `harstorage` instance.\n \n harstorage references:\n     * `On google code <https://code.google.com/p/harstorage/w/list/>`_\n     * `Original Github repository <https://github.com/pavel-paulau/harstorage>`_\n \n run uploader as standalone script:\n-    * Args: \n+    * Args:\n         Path to HAR file or directory containing har files to be uploaded.\n-    * Options:     \n-        :code:`--url`: URL of harstorage instance (default: 'http://localhost:5000')\n-    * Example:     \n-        :code:`python haruploader.py /path/to/HAR/file.har --url http://127.0.0.1:8000`\n+    * Options:\n+       `--url`: URL of harstorage instance (default: 'http://localhost:5000')\n+    * Example:\n+        `haruploader /path/to/file.har --url http://127.0.0.1:8000`\n     * For help text:\n-        :code:`python haruploader.py -h`\n+        `haruploader -h`\n \n run uploader as part of harprofiler:\n-    Just make sure that `harstorage_url` is set in the config file, and :code:`harprofiler` will run the uploader after it creates the HARs. This will call the :code:`upload_hars` method, using as args the :code:`har_dir` and :code:`harstorage_url` settings provided in the configuration file.\n+    Just make sure that `harstorage_url` is set in the config file, and `harprofiler` will run the uploader after it creates the HARs. This will call the `upload_hars` method, using as args the `har_dir` and `harstorage_url` settings provided in the configuration file.","path":"README.rst","position":65,"original_position":65,"commit_id":"b23de53aa0b3c157fbb06d9a6ebc21798aa0e689","original_commit_id":"b23de53aa0b3c157fbb06d9a6ebc21798aa0e689","user":{"login":"benpatterson","id":2004678,"avatar_url":"https://avatars.githubusercontent.com/u/2004678?v=3","gravatar_id":"","url":"https://api.github.com/users/benpatterson","html_url":"https://github.com/benpatterson","followers_url":"https://api.github.com/users/benpatterson/followers","following_url":"https://api.github.com/users/benpatterson/following{/other_user}","gists_url":"https://api.github.com/users/benpatterson/gists{/gist_id}","starred_url":"https://api.github.com/users/benpatterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benpatterson/subscriptions","organizations_url":"https://api.github.com/users/benpatterson/orgs","repos_url":"https://api.github.com/users/benpatterson/repos","events_url":"https://api.github.com/users/benpatterson/events{/privacy}","received_events_url":"https://api.github.com/users/benpatterson/received_events","type":"User","site_admin":false},"body":"s/Just make/Make. Also, maybe reduce this to something like \"if `harstorage_url` and/or `har_dir` are not set, then the uploader will not run.\"","created_at":"2014-11-13T16:06:47Z","updated_at":"2014-11-13T16:06:47Z","html_url":"https://github.com/edx/harprofiler/pull/25#discussion_r20301130","pull_request_url":"https://api.github.com/repos/edx/harprofiler/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/edx/harprofiler/pulls/comments/20301130"},"html":{"href":"https://github.com/edx/harprofiler/pull/25#discussion_r20301130"},"pull_request":{"href":"https://api.github.com/repos/edx/harprofiler/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/edx/harprofiler/pulls/25","id":24245975,"html_url":"https://github.com/edx/harprofiler/pull/25","diff_url":"https://github.com/edx/harprofiler/pull/25.diff","patch_url":"https://github.com/edx/harprofiler/pull/25.patch","issue_url":"https://api.github.com/repos/edx/harprofiler/issues/25","number":25,"state":"open","locked":false,"title":"packaging with a setup.py and proper package hierarchy","user":{"login":"cgoldberg","id":1113081,"avatar_url":"https://avatars.githubusercontent.com/u/1113081?v=3","gravatar_id":"","url":"https://api.github.com/users/cgoldberg","html_url":"https://github.com/cgoldberg","followers_url":"https://api.github.com/users/cgoldberg/followers","following_url":"https://api.github.com/users/cgoldberg/following{/other_user}","gists_url":"https://api.github.com/users/cgoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/cgoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgoldberg/subscriptions","organizations_url":"https://api.github.com/users/cgoldberg/orgs","repos_url":"https://api.github.com/users/cgoldberg/repos","events_url":"https://api.github.com/users/cgoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/cgoldberg/received_events","type":"User","site_admin":false},"body":"it's now a python package!\r\n\r\nto develop inside a virtualenv:\r\n(env)$ pip install -e .\r\n\r\nto run the tests:\r\n(env)$ python -m unittest discover\r\n","created_at":"2014-11-11T20:07:06Z","updated_at":"2014-11-13T16:06:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1df05e218bac32ec3702978608a45b7d1b85cf6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/harprofiler/pulls/25/commits","review_comments_url":"https://api.github.com/repos/edx/harprofiler/pulls/25/comments","review_comment_url":"https://api.github.com/repos/edx/harprofiler/pulls/comments/{number}","comments_url":"https://api.github.com/repos/edx/harprofiler/issues/25/comments","statuses_url":"https://api.github.com/repos/edx/harprofiler/statuses/b23de53aa0b3c157fbb06d9a6ebc21798aa0e689","head":{"label":"edx:package-me-up","ref":"package-me-up","sha":"b23de53aa0b3c157fbb06d9a6ebc21798aa0e689","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":25822061,"name":"harprofiler","full_name":"edx/harprofiler","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/harprofiler","description":"record har files for automated web pageloads","fork":false,"url":"https://api.github.com/repos/edx/harprofiler","forks_url":"https://api.github.com/repos/edx/harprofiler/forks","keys_url":"https://api.github.com/repos/edx/harprofiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/harprofiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/harprofiler/teams","hooks_url":"https://api.github.com/repos/edx/harprofiler/hooks","issue_events_url":"https://api.github.com/repos/edx/harprofiler/issues/events{/number}","events_url":"https://api.github.com/repos/edx/harprofiler/events","assignees_url":"https://api.github.com/repos/edx/harprofiler/assignees{/user}","branches_url":"https://api.github.com/repos/edx/harprofiler/branches{/branch}","tags_url":"https://api.github.com/repos/edx/harprofiler/tags","blobs_url":"https://api.github.com/repos/edx/harprofiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/harprofiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/harprofiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/harprofiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/harprofiler/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/harprofiler/languages","stargazers_url":"https://api.github.com/repos/edx/harprofiler/stargazers","contributors_url":"https://api.github.com/repos/edx/harprofiler/contributors","subscribers_url":"https://api.github.com/repos/edx/harprofiler/subscribers","subscription_url":"https://api.github.com/repos/edx/harprofiler/subscription","commits_url":"https://api.github.com/repos/edx/harprofiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/harprofiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/harprofiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/harprofiler/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/harprofiler/contents/{+path}","compare_url":"https://api.github.com/repos/edx/harprofiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/harprofiler/merges","archive_url":"https://api.github.com/repos/edx/harprofiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/harprofiler/downloads","issues_url":"https://api.github.com/repos/edx/harprofiler/issues{/number}","pulls_url":"https://api.github.com/repos/edx/harprofiler/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/harprofiler/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/harprofiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/harprofiler/labels{/name}","releases_url":"https://api.github.com/repos/edx/harprofiler/releases{/id}","created_at":"2014-10-27T14:08:37Z","updated_at":"2014-11-05T15:59:20Z","pushed_at":"2014-11-13T16:06:28Z","git_url":"git://github.com/edx/harprofiler.git","ssh_url":"git@github.com:edx/harprofiler.git","clone_url":"https://github.com/edx/harprofiler.git","svn_url":"https://github.com/edx/harprofiler","homepage":null,"size":474,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":8,"forks":2,"open_issues":8,"watchers":1,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"6ddfdd4aa36e9604f6e0675a09e90826768113e6","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":25822061,"name":"harprofiler","full_name":"edx/harprofiler","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/harprofiler","description":"record har files for automated web pageloads","fork":false,"url":"https://api.github.com/repos/edx/harprofiler","forks_url":"https://api.github.com/repos/edx/harprofiler/forks","keys_url":"https://api.github.com/repos/edx/harprofiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/harprofiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/harprofiler/teams","hooks_url":"https://api.github.com/repos/edx/harprofiler/hooks","issue_events_url":"https://api.github.com/repos/edx/harprofiler/issues/events{/number}","events_url":"https://api.github.com/repos/edx/harprofiler/events","assignees_url":"https://api.github.com/repos/edx/harprofiler/assignees{/user}","branches_url":"https://api.github.com/repos/edx/harprofiler/branches{/branch}","tags_url":"https://api.github.com/repos/edx/harprofiler/tags","blobs_url":"https://api.github.com/repos/edx/harprofiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/harprofiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/harprofiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/harprofiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/harprofiler/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/harprofiler/languages","stargazers_url":"https://api.github.com/repos/edx/harprofiler/stargazers","contributors_url":"https://api.github.com/repos/edx/harprofiler/contributors","subscribers_url":"https://api.github.com/repos/edx/harprofiler/subscribers","subscription_url":"https://api.github.com/repos/edx/harprofiler/subscription","commits_url":"https://api.github.com/repos/edx/harprofiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/harprofiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/harprofiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/harprofiler/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/harprofiler/contents/{+path}","compare_url":"https://api.github.com/repos/edx/harprofiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/harprofiler/merges","archive_url":"https://api.github.com/repos/edx/harprofiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/harprofiler/downloads","issues_url":"https://api.github.com/repos/edx/harprofiler/issues{/number}","pulls_url":"https://api.github.com/repos/edx/harprofiler/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/harprofiler/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/harprofiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/harprofiler/labels{/name}","releases_url":"https://api.github.com/repos/edx/harprofiler/releases{/id}","created_at":"2014-10-27T14:08:37Z","updated_at":"2014-11-05T15:59:20Z","pushed_at":"2014-11-13T16:06:28Z","git_url":"git://github.com/edx/harprofiler.git","ssh_url":"git@github.com:edx/harprofiler.git","clone_url":"https://github.com/edx/harprofiler.git","svn_url":"https://github.com/edx/harprofiler","homepage":null,"size":474,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":8,"forks":2,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/harprofiler/pulls/25"},"html":{"href":"https://github.com/edx/harprofiler/pull/25"},"issue":{"href":"https://api.github.com/repos/edx/harprofiler/issues/25"},"comments":{"href":"https://api.github.com/repos/edx/harprofiler/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/harprofiler/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/harprofiler/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/edx/harprofiler/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/edx/harprofiler/statuses/b23de53aa0b3c157fbb06d9a6ebc21798aa0e689"}}}}