GitHub PullRequestReviewCommentEvent at 2014-09-17 09:51:56
Repository: certificate-transparency
Actor: pphaneuf
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/17655400","id":17655400,"diff_hunk":"@@ -295,6 +300,9 @@ void HttpHandler::GetEntries(evhttp_request *req) const {\n   // we should return an empty result instead.\n   end = std::min(end, tree_size - 1);\n \n+  // Limit the number of entries returned in a single request.\n+  end = std::min(end, start + FLAGS_max_leaf_entries_per_response);","path":"cpp/server/handler.cc","position":29,"original_position":29,"commit_id":"724ccf8a3cc2d26007b4dca6f92547b0829cd0d5","original_commit_id":"724ccf8a3cc2d26007b4dca6f92547b0829cd0d5","user":{"login":"pphaneuf","id":40400,"avatar_url":"https://avatars.githubusercontent.com/u/40400?v=2","gravatar_id":"9ca8853825f37993dbec533c52178410","url":"https://api.github.com/users/pphaneuf","html_url":"https://github.com/pphaneuf","followers_url":"https://api.github.com/users/pphaneuf/followers","following_url":"https://api.github.com/users/pphaneuf/following{/other_user}","gists_url":"https://api.github.com/users/pphaneuf/gists{/gist_id}","starred_url":"https://api.github.com/users/pphaneuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pphaneuf/subscriptions","organizations_url":"https://api.github.com/users/pphaneuf/orgs","repos_url":"https://api.github.com/users/pphaneuf/repos","events_url":"https://api.github.com/users/pphaneuf/events{/privacy}","received_events_url":"https://api.github.com/users/pphaneuf/received_events","type":"User","site_admin":false},"body":"I'd like that, but C++0x and C++11 both require compiler switches to be passed on, which would need detection depending on the compiler (and if they're missing, etc)...","created_at":"2014-09-17T09:51:56Z","updated_at":"2014-09-17T09:51:56Z","html_url":"https://github.com/google/certificate-transparency/pull/152#discussion_r17655400","pull_request_url":"https://api.github.com/repos/google/certificate-transparency/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/17655400"},"html":{"href":"https://github.com/google/certificate-transparency/pull/152#discussion_r17655400"},"pull_request":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/152","id":21311298,"html_url":"https://github.com/google/certificate-transparency/pull/152","diff_url":"https://github.com/google/certificate-transparency/pull/152.diff","patch_url":"https://github.com/google/certificate-transparency/pull/152.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency/issues/152","number":152,"state":"open","locked":false,"title":"Limit the number of entries returned per request.","user":{"login":"pphaneuf","id":40400,"avatar_url":"https://avatars.githubusercontent.com/u/40400?v=2","gravatar_id":"9ca8853825f37993dbec533c52178410","url":"https://api.github.com/users/pphaneuf","html_url":"https://github.com/pphaneuf","followers_url":"https://api.github.com/users/pphaneuf/followers","following_url":"https://api.github.com/users/pphaneuf/following{/other_user}","gists_url":"https://api.github.com/users/pphaneuf/gists{/gist_id}","starred_url":"https://api.github.com/users/pphaneuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pphaneuf/subscriptions","organizations_url":"https://api.github.com/users/pphaneuf/orgs","repos_url":"https://api.github.com/users/pphaneuf/repos","events_url":"https://api.github.com/users/pphaneuf/events{/privacy}","received_events_url":"https://api.github.com/users/pphaneuf/received_events","type":"User","site_admin":false},"body":"See also: https://codereview.appspot.com/136690043/","created_at":"2014-09-16T16:40:44Z","updated_at":"2014-09-17T09:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01ac0b7b18409cef9291e2c413834cc99d00dc40","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency/pulls/152/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency/pulls/152/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/{number}","comments_url":"https://api.github.com/repos/google/certificate-transparency/issues/152/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/724ccf8a3cc2d26007b4dca6f92547b0829cd0d5","head":{"label":"pphaneuf:limit_get_entries","ref":"limit_get_entries","sha":"724ccf8a3cc2d26007b4dca6f92547b0829cd0d5","user":{"login":"pphaneuf","id":40400,"avatar_url":"https://avatars.githubusercontent.com/u/40400?v=2","gravatar_id":"9ca8853825f37993dbec533c52178410","url":"https://api.github.com/users/pphaneuf","html_url":"https://github.com/pphaneuf","followers_url":"https://api.github.com/users/pphaneuf/followers","following_url":"https://api.github.com/users/pphaneuf/following{/other_user}","gists_url":"https://api.github.com/users/pphaneuf/gists{/gist_id}","starred_url":"https://api.github.com/users/pphaneuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pphaneuf/subscriptions","organizations_url":"https://api.github.com/users/pphaneuf/orgs","repos_url":"https://api.github.com/users/pphaneuf/repos","events_url":"https://api.github.com/users/pphaneuf/events{/privacy}","received_events_url":"https://api.github.com/users/pphaneuf/received_events","type":"User","site_admin":false},"repo":{"id":19991870,"name":"certificate-transparency","full_name":"pphaneuf/certificate-transparency","owner":{"login":"pphaneuf","id":40400,"avatar_url":"https://avatars.githubusercontent.com/u/40400?v=2","gravatar_id":"9ca8853825f37993dbec533c52178410","url":"https://api.github.com/users/pphaneuf","html_url":"https://github.com/pphaneuf","followers_url":"https://api.github.com/users/pphaneuf/followers","following_url":"https://api.github.com/users/pphaneuf/following{/other_user}","gists_url":"https://api.github.com/users/pphaneuf/gists{/gist_id}","starred_url":"https://api.github.com/users/pphaneuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pphaneuf/subscriptions","organizations_url":"https://api.github.com/users/pphaneuf/orgs","repos_url":"https://api.github.com/users/pphaneuf/repos","events_url":"https://api.github.com/users/pphaneuf/events{/privacy}","received_events_url":"https://api.github.com/users/pphaneuf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pphaneuf/certificate-transparency","description":"Auditing for TLS certificates.","fork":true,"url":"https://api.github.com/repos/pphaneuf/certificate-transparency","forks_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/forks","keys_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/events","assignees_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/issues/comments/{number}","contents_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/merges","archive_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/pphaneuf/certificate-transparency/releases{/id}","created_at":"2014-05-20T18:11:01Z","updated_at":"2014-06-30T14:29:00Z","pushed_at":"2014-09-16T16:40:07Z","git_url":"git://github.com/pphaneuf/certificate-transparency.git","ssh_url":"git@github.com:pphaneuf/certificate-transparency.git","clone_url":"https://github.com/pphaneuf/certificate-transparency.git","svn_url":"https://github.com/pphaneuf/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":20092,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"42038306b53fa1fef8e18c1b9c31bf9cb0bd76c3","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=2","gravatar_id":"24ba30616d2a20673f54c2aee36d159e","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":19989605,"name":"certificate-transparency","full_name":"google/certificate-transparency","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=2","gravatar_id":"24ba30616d2a20673f54c2aee36d159e","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/certificate-transparency","description":"Auditing for TLS certificates.","fork":false,"url":"https://api.github.com/repos/google/certificate-transparency","forks_url":"https://api.github.com/repos/google/certificate-transparency/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency/issues/comments/{number}","contents_url":"https://api.github.com/repos/google/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency/releases{/id}","created_at":"2014-05-20T17:03:47Z","updated_at":"2014-09-09T02:12:46Z","pushed_at":"2014-09-16T16:39:06Z","git_url":"git://github.com/google/certificate-transparency.git","ssh_url":"git@github.com:google/certificate-transparency.git","clone_url":"https://github.com/google/certificate-transparency.git","svn_url":"https://github.com/google/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":19881,"stargazers_count":50,"watchers_count":50,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":14,"forks":18,"open_issues":14,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/152"},"html":{"href":"https://github.com/google/certificate-transparency/pull/152"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/152"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency/statuses/724ccf8a3cc2d26007b4dca6f92547b0829cd0d5"}}}}