GitHub PullRequestEvent at 2014-10-03 08:37:50
Repository: bs58
Actor: jprichardson
Payload: {"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/cryptocoinjs/bs58/pulls/9","id":22191149,"html_url":"https://github.com/cryptocoinjs/bs58/pull/9","diff_url":"https://github.com/cryptocoinjs/bs58/pull/9.diff","patch_url":"https://github.com/cryptocoinjs/bs58/pull/9.patch","issue_url":"https://api.github.com/repos/cryptocoinjs/bs58/issues/9","number":9,"state":"closed","locked":false,"title":"No browserify requirement","user":{"login":"dcousens","id":413395,"avatar_url":"https://avatars.githubusercontent.com/u/413395?v=2","gravatar_id":"","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false},"body":"I love browserify, but, in this case we gain very little from forcing our API to use it. \r\nInfact, I'd wager that for many use cases, the user might not even need the `Buffer` API for what they intend to use the decode for.\r\nTherefore, IMHO, it is better to put that responsibility on the user and just give back what we are working with internally, an `Array`.\r\n\r\nThis would require a version bump to `2.0.0` though.\r\n@jprichardson thoughts?","created_at":"2014-10-03T08:17:59Z","updated_at":"2014-10-03T08:37:50Z","closed_at":"2014-10-03T08:37:50Z","merged_at":"2014-10-03T08:37:50Z","merge_commit_sha":"9b42759fa2f643683c7f0b82c6c743fb0e5d63b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cryptocoinjs/bs58/pulls/9/commits","review_comments_url":"https://api.github.com/repos/cryptocoinjs/bs58/pulls/9/comments","review_comment_url":"https://api.github.com/repos/cryptocoinjs/bs58/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cryptocoinjs/bs58/issues/9/comments","statuses_url":"https://api.github.com/repos/cryptocoinjs/bs58/statuses/6966e4f11ac1cdfc03646c1efdda256bf8613000","head":{"label":"cryptocoinjs:nobrows","ref":"nobrows","sha":"6966e4f11ac1cdfc03646c1efdda256bf8613000","user":{"login":"cryptocoinjs","id":5800468,"avatar_url":"https://avatars.githubusercontent.com/u/5800468?v=2","gravatar_id":"","url":"https://api.github.com/users/cryptocoinjs","html_url":"https://github.com/cryptocoinjs","followers_url":"https://api.github.com/users/cryptocoinjs/followers","following_url":"https://api.github.com/users/cryptocoinjs/following{/other_user}","gists_url":"https://api.github.com/users/cryptocoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptocoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptocoinjs/subscriptions","organizations_url":"https://api.github.com/users/cryptocoinjs/orgs","repos_url":"https://api.github.com/users/cryptocoinjs/repos","events_url":"https://api.github.com/users/cryptocoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/cryptocoinjs/received_events","type":"Organization","site_admin":false},"repo":{"id":14131022,"name":"bs58","full_name":"cryptocoinjs/bs58","owner":{"login":"cryptocoinjs","id":5800468,"avatar_url":"https://avatars.githubusercontent.com/u/5800468?v=2","gravatar_id":"","url":"https://api.github.com/users/cryptocoinjs","html_url":"https://github.com/cryptocoinjs","followers_url":"https://api.github.com/users/cryptocoinjs/followers","following_url":"https://api.github.com/users/cryptocoinjs/following{/other_user}","gists_url":"https://api.github.com/users/cryptocoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptocoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptocoinjs/subscriptions","organizations_url":"https://api.github.com/users/cryptocoinjs/orgs","repos_url":"https://api.github.com/users/cryptocoinjs/repos","events_url":"https://api.github.com/users/cryptocoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/cryptocoinjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cryptocoinjs/bs58","description":"Base58 encoding/decoding for Bitcoin","fork":false,"url":"https://api.github.com/repos/cryptocoinjs/bs58","forks_url":"https://api.github.com/repos/cryptocoinjs/bs58/forks","keys_url":"https://api.github.com/repos/cryptocoinjs/bs58/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cryptocoinjs/bs58/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cryptocoinjs/bs58/teams","hooks_url":"https://api.github.com/repos/cryptocoinjs/bs58/hooks","issue_events_url":"https://api.github.com/repos/cryptocoinjs/bs58/issues/events{/number}","events_url":"https://api.github.com/repos/cryptocoinjs/bs58/events","assignees_url":"https://api.github.com/repos/cryptocoinjs/bs58/assignees{/user}","branches_url":"https://api.github.com/repos/cryptocoinjs/bs58/branches{/branch}","tags_url":"https://api.github.com/repos/cryptocoinjs/bs58/tags","blobs_url":"https://api.github.com/repos/cryptocoinjs/bs58/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cryptocoinjs/bs58/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cryptocoinjs/bs58/git/refs{/sha}","trees_url":"https://api.github.com/repos/cryptocoinjs/bs58/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cryptocoinjs/bs58/statuses/{sha}","languages_url":"https://api.github.com/repos/cryptocoinjs/bs58/languages","stargazers_url":"https://api.github.com/repos/cryptocoinjs/bs58/stargazers","contributors_url":"https://api.github.com/repos/cryptocoinjs/bs58/contributors","subscribers_url":"https://api.github.com/repos/cryptocoinjs/bs58/subscribers","subscription_url":"https://api.github.com/repos/cryptocoinjs/bs58/subscription","commits_url":"https://api.github.com/repos/cryptocoinjs/bs58/commits{/sha}","git_commits_url":"https://api.github.com/repos/cryptocoinjs/bs58/git/commits{/sha}","comments_url":"https://api.github.com/repos/cryptocoinjs/bs58/comments{/number}","issue_comment_url":"https://api.github.com/repos/cryptocoinjs/bs58/issues/comments/{number}","contents_url":"https://api.github.com/repos/cryptocoinjs/bs58/contents/{+path}","compare_url":"https://api.github.com/repos/cryptocoinjs/bs58/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cryptocoinjs/bs58/merges","archive_url":"https://api.github.com/repos/cryptocoinjs/bs58/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cryptocoinjs/bs58/downloads","issues_url":"https://api.github.com/repos/cryptocoinjs/bs58/issues{/number}","pulls_url":"https://api.github.com/repos/cryptocoinjs/bs58/pulls{/number}","milestones_url":"https://api.github.com/repos/cryptocoinjs/bs58/milestones{/number}","notifications_url":"https://api.github.com/repos/cryptocoinjs/bs58/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cryptocoinjs/bs58/labels{/name}","releases_url":"https://api.github.com/repos/cryptocoinjs/bs58/releases{/id}","created_at":"2013-11-05T03:21:35Z","updated_at":"2014-09-21T09:08:16Z","pushed_at":"2014-10-03T08:37:50Z","git_url":"git://github.com/cryptocoinjs/bs58.git","ssh_url":"git@github.com:cryptocoinjs/bs58.git","clone_url":"https://github.com/cryptocoinjs/bs58.git","svn_url":"https://github.com/cryptocoinjs/bs58","homepage":null,"size":441,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":11,"default_branch":"master"}},"base":{"label":"cryptocoinjs:master","ref":"master","sha":"004c26145ad5e4e785fd7d9b1abfcefacb7502e2","user":{"login":"cryptocoinjs","id":5800468,"avatar_url":"https://avatars.githubusercontent.com/u/5800468?v=2","gravatar_id":"","url":"https://api.github.com/users/cryptocoinjs","html_url":"https://github.com/cryptocoinjs","followers_url":"https://api.github.com/users/cryptocoinjs/followers","following_url":"https://api.github.com/users/cryptocoinjs/following{/other_user}","gists_url":"https://api.github.com/users/cryptocoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptocoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptocoinjs/subscriptions","organizations_url":"https://api.github.com/users/cryptocoinjs/orgs","repos_url":"https://api.github.com/users/cryptocoinjs/repos","events_url":"https://api.github.com/users/cryptocoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/cryptocoinjs/received_events","type":"Organization","site_admin":false},"repo":{"id":14131022,"name":"bs58","full_name":"cryptocoinjs/bs58","owner":{"login":"cryptocoinjs","id":5800468,"avatar_url":"https://avatars.githubusercontent.com/u/5800468?v=2","gravatar_id":"","url":"https://api.github.com/users/cryptocoinjs","html_url":"https://github.com/cryptocoinjs","followers_url":"https://api.github.com/users/cryptocoinjs/followers","following_url":"https://api.github.com/users/cryptocoinjs/following{/other_user}","gists_url":"https://api.github.com/users/cryptocoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptocoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptocoinjs/subscriptions","organizations_url":"https://api.github.com/users/cryptocoinjs/orgs","repos_url":"https://api.github.com/users/cryptocoinjs/repos","events_url":"https://api.github.com/users/cryptocoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/cryptocoinjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cryptocoinjs/bs58","description":"Base58 encoding/decoding for Bitcoin","fork":false,"url":"https://api.github.com/repos/cryptocoinjs/bs58","forks_url":"https://api.github.com/repos/cryptocoinjs/bs58/forks","keys_url":"https://api.github.com/repos/cryptocoinjs/bs58/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cryptocoinjs/bs58/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cryptocoinjs/bs58/teams","hooks_url":"https://api.github.com/repos/cryptocoinjs/bs58/hooks","issue_events_url":"https://api.github.com/repos/cryptocoinjs/bs58/issues/events{/number}","events_url":"https://api.github.com/repos/cryptocoinjs/bs58/events","assignees_url":"https://api.github.com/repos/cryptocoinjs/bs58/assignees{/user}","branches_url":"https://api.github.com/repos/cryptocoinjs/bs58/branches{/branch}","tags_url":"https://api.github.com/repos/cryptocoinjs/bs58/tags","blobs_url":"https://api.github.com/repos/cryptocoinjs/bs58/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cryptocoinjs/bs58/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cryptocoinjs/bs58/git/refs{/sha}","trees_url":"https://api.github.com/repos/cryptocoinjs/bs58/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cryptocoinjs/bs58/statuses/{sha}","languages_url":"https://api.github.com/repos/cryptocoinjs/bs58/languages","stargazers_url":"https://api.github.com/repos/cryptocoinjs/bs58/stargazers","contributors_url":"https://api.github.com/repos/cryptocoinjs/bs58/contributors","subscribers_url":"https://api.github.com/repos/cryptocoinjs/bs58/subscribers","subscription_url":"https://api.github.com/repos/cryptocoinjs/bs58/subscription","commits_url":"https://api.github.com/repos/cryptocoinjs/bs58/commits{/sha}","git_commits_url":"https://api.github.com/repos/cryptocoinjs/bs58/git/commits{/sha}","comments_url":"https://api.github.com/repos/cryptocoinjs/bs58/comments{/number}","issue_comment_url":"https://api.github.com/repos/cryptocoinjs/bs58/issues/comments/{number}","contents_url":"https://api.github.com/repos/cryptocoinjs/bs58/contents/{+path}","compare_url":"https://api.github.com/repos/cryptocoinjs/bs58/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cryptocoinjs/bs58/merges","archive_url":"https://api.github.com/repos/cryptocoinjs/bs58/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cryptocoinjs/bs58/downloads","issues_url":"https://api.github.com/repos/cryptocoinjs/bs58/issues{/number}","pulls_url":"https://api.github.com/repos/cryptocoinjs/bs58/pulls{/number}","milestones_url":"https://api.github.com/repos/cryptocoinjs/bs58/milestones{/number}","notifications_url":"https://api.github.com/repos/cryptocoinjs/bs58/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cryptocoinjs/bs58/labels{/name}","releases_url":"https://api.github.com/repos/cryptocoinjs/bs58/releases{/id}","created_at":"2013-11-05T03:21:35Z","updated_at":"2014-09-21T09:08:16Z","pushed_at":"2014-10-03T08:37:50Z","git_url":"git://github.com/cryptocoinjs/bs58.git","ssh_url":"git@github.com:cryptocoinjs/bs58.git","clone_url":"https://github.com/cryptocoinjs/bs58.git","svn_url":"https://github.com/cryptocoinjs/bs58","homepage":null,"size":441,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cryptocoinjs/bs58/pulls/9"},"html":{"href":"https://github.com/cryptocoinjs/bs58/pull/9"},"issue":{"href":"https://api.github.com/repos/cryptocoinjs/bs58/issues/9"},"comments":{"href":"https://api.github.com/repos/cryptocoinjs/bs58/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/cryptocoinjs/bs58/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/cryptocoinjs/bs58/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cryptocoinjs/bs58/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/cryptocoinjs/bs58/statuses/6966e4f11ac1cdfc03646c1efdda256bf8613000"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jprichardson","id":150063,"avatar_url":"https://avatars.githubusercontent.com/u/150063?v=2","gravatar_id":"","url":"https://api.github.com/users/jprichardson","html_url":"https://github.com/jprichardson","followers_url":"https://api.github.com/users/jprichardson/followers","following_url":"https://api.github.com/users/jprichardson/following{/other_user}","gists_url":"https://api.github.com/users/jprichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/jprichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprichardson/subscriptions","organizations_url":"https://api.github.com/users/jprichardson/orgs","repos_url":"https://api.github.com/users/jprichardson/repos","events_url":"https://api.github.com/users/jprichardson/events{/privacy}","received_events_url":"https://api.github.com/users/jprichardson/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":3,"additions":6,"deletions":8,"changed_files":3}}