GitHub PullRequestReviewCommentEvent at 2014-09-04 21:16:40
Repository: ec-metal
Actor: irvingpop
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opscode/ec-metal/pulls/comments/17142948","id":17142948,"diff_hunk":"@@ -64,8 +64,8 @@ def cloud_machine_created?(vmname)\n         recipe 'private-chef::bugfixes' if node['harness']['apply_ec_bugfixes'] == true\n         recipe 'private-chef::drbd' if topo.is_backend?(vmname) and !topo.is_standalone?(vmname)\n         recipe 'private-chef::provision_phase2'\n-        recipe 'private-chef::users' if vmname == topo.bootstrap_node_name &&\n-          node['harness']['osc_install'] == false\n+        # recipe 'private-chef::users' if vmname == topo.bootstrap_node_name &&\n+        #   node['harness']['osc_install'] == false","path":"cookbooks/ec-harness/providers/private_chef_ha.rb","position":7,"original_position":7,"commit_id":"a792ca34127e7c90184481d9569e219d69e85473","original_commit_id":"a792ca34127e7c90184481d9569e219d69e85473","user":{"login":"irvingpop","id":1616328,"avatar_url":"https://avatars.githubusercontent.com/u/1616328?v=2","gravatar_id":"2ab9646154934c38afccb1ef7ea2bdc6","url":"https://api.github.com/users/irvingpop","html_url":"https://github.com/irvingpop","followers_url":"https://api.github.com/users/irvingpop/followers","following_url":"https://api.github.com/users/irvingpop/following{/other_user}","gists_url":"https://api.github.com/users/irvingpop/gists{/gist_id}","starred_url":"https://api.github.com/users/irvingpop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irvingpop/subscriptions","organizations_url":"https://api.github.com/users/irvingpop/orgs","repos_url":"https://api.github.com/users/irvingpop/repos","events_url":"https://api.github.com/users/irvingpop/events{/privacy}","received_events_url":"https://api.github.com/users/irvingpop/received_events","type":"User","site_admin":false},"body":"Instead of commenting out, could we make it conditional on installing private-chef?   we could push that down to the recipe level I think.","created_at":"2014-09-04T21:16:40Z","updated_at":"2014-09-04T21:16:40Z","html_url":"https://github.com/opscode/ec-metal/pull/80#discussion_r17142948","pull_request_url":"https://api.github.com/repos/opscode/ec-metal/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/opscode/ec-metal/pulls/comments/17142948"},"html":{"href":"https://github.com/opscode/ec-metal/pull/80#discussion_r17142948"},"pull_request":{"href":"https://api.github.com/repos/opscode/ec-metal/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/opscode/ec-metal/pulls/80","id":20767452,"html_url":"https://github.com/opscode/ec-metal/pull/80","diff_url":"https://github.com/opscode/ec-metal/pull/80.diff","patch_url":"https://github.com/opscode/ec-metal/pull/80.patch","issue_url":"https://api.github.com/repos/opscode/ec-metal/issues/80","number":80,"state":"open","locked":false,"title":"WIP chef server core changes.","user":{"login":"patrick-wright","id":6841563,"avatar_url":"https://avatars.githubusercontent.com/u/6841563?v=2","gravatar_id":"989e8e262e509338653a78584eb0547c","url":"https://api.github.com/users/patrick-wright","html_url":"https://github.com/patrick-wright","followers_url":"https://api.github.com/users/patrick-wright/followers","following_url":"https://api.github.com/users/patrick-wright/following{/other_user}","gists_url":"https://api.github.com/users/patrick-wright/gists{/gist_id}","starred_url":"https://api.github.com/users/patrick-wright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrick-wright/subscriptions","organizations_url":"https://api.github.com/users/patrick-wright/orgs","repos_url":"https://api.github.com/users/patrick-wright/repos","events_url":"https://api.github.com/users/patrick-wright/events{/privacy}","received_events_url":"https://api.github.com/users/patrick-wright/received_events","type":"User","site_admin":false},"body":"waiting for CI builds since the initial cs12 builds (locally built) cause pkg signing errors and the version metadata is missing for rhel.  I'll test these changes work with the new builds before merging.\r\n\r\nnote: users recipe doesn't work with cs12  (or at least when I tried it)","created_at":"2014-09-04T19:39:08Z","updated_at":"2014-09-04T21:16:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e54c9733ad840de78099fa0efa133f7603027dd1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode/ec-metal/pulls/80/commits","review_comments_url":"https://api.github.com/repos/opscode/ec-metal/pulls/80/comments","review_comment_url":"https://api.github.com/repos/opscode/ec-metal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode/ec-metal/issues/80/comments","statuses_url":"https://api.github.com/repos/opscode/ec-metal/statuses/a792ca34127e7c90184481d9569e219d69e85473","head":{"label":"opscode:pw/chef-server-core","ref":"pw/chef-server-core","sha":"a792ca34127e7c90184481d9569e219d69e85473","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":18124922,"name":"ec-metal","full_name":"opscode/ec-metal","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/ec-metal","description":"Chef-metal based tool for creating, managing and testing Enterprise Chef HA clusters","fork":false,"url":"https://api.github.com/repos/opscode/ec-metal","forks_url":"https://api.github.com/repos/opscode/ec-metal/forks","keys_url":"https://api.github.com/repos/opscode/ec-metal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/ec-metal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/ec-metal/teams","hooks_url":"https://api.github.com/repos/opscode/ec-metal/hooks","issue_events_url":"https://api.github.com/repos/opscode/ec-metal/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/ec-metal/events","assignees_url":"https://api.github.com/repos/opscode/ec-metal/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/ec-metal/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/ec-metal/tags","blobs_url":"https://api.github.com/repos/opscode/ec-metal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/ec-metal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/ec-metal/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/ec-metal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/ec-metal/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/ec-metal/languages","stargazers_url":"https://api.github.com/repos/opscode/ec-metal/stargazers","contributors_url":"https://api.github.com/repos/opscode/ec-metal/contributors","subscribers_url":"https://api.github.com/repos/opscode/ec-metal/subscribers","subscription_url":"https://api.github.com/repos/opscode/ec-metal/subscription","commits_url":"https://api.github.com/repos/opscode/ec-metal/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/ec-metal/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/ec-metal/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/ec-metal/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/ec-metal/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/ec-metal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/ec-metal/merges","archive_url":"https://api.github.com/repos/opscode/ec-metal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/ec-metal/downloads","issues_url":"https://api.github.com/repos/opscode/ec-metal/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/ec-metal/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/ec-metal/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/ec-metal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/ec-metal/labels{/name}","releases_url":"https://api.github.com/repos/opscode/ec-metal/releases{/id}","created_at":"2014-03-26T02:49:47Z","updated_at":"2014-09-04T15:31:03Z","pushed_at":"2014-09-04T20:52:37Z","git_url":"git://github.com/opscode/ec-metal.git","ssh_url":"git@github.com:opscode/ec-metal.git","clone_url":"https://github.com/opscode/ec-metal.git","svn_url":"https://github.com/opscode/ec-metal","homepage":null,"size":4289,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":12,"forks":7,"open_issues":12,"watchers":12,"default_branch":"master"}},"base":{"label":"opscode:master","ref":"master","sha":"da32dd1198f31a745549ee13e62705c55ccb18ae","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":18124922,"name":"ec-metal","full_name":"opscode/ec-metal","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=2","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/ec-metal","description":"Chef-metal based tool for creating, managing and testing Enterprise Chef HA clusters","fork":false,"url":"https://api.github.com/repos/opscode/ec-metal","forks_url":"https://api.github.com/repos/opscode/ec-metal/forks","keys_url":"https://api.github.com/repos/opscode/ec-metal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/ec-metal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/ec-metal/teams","hooks_url":"https://api.github.com/repos/opscode/ec-metal/hooks","issue_events_url":"https://api.github.com/repos/opscode/ec-metal/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/ec-metal/events","assignees_url":"https://api.github.com/repos/opscode/ec-metal/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/ec-metal/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/ec-metal/tags","blobs_url":"https://api.github.com/repos/opscode/ec-metal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/ec-metal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/ec-metal/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/ec-metal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/ec-metal/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/ec-metal/languages","stargazers_url":"https://api.github.com/repos/opscode/ec-metal/stargazers","contributors_url":"https://api.github.com/repos/opscode/ec-metal/contributors","subscribers_url":"https://api.github.com/repos/opscode/ec-metal/subscribers","subscription_url":"https://api.github.com/repos/opscode/ec-metal/subscription","commits_url":"https://api.github.com/repos/opscode/ec-metal/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/ec-metal/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/ec-metal/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/ec-metal/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/ec-metal/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/ec-metal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/ec-metal/merges","archive_url":"https://api.github.com/repos/opscode/ec-metal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/ec-metal/downloads","issues_url":"https://api.github.com/repos/opscode/ec-metal/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/ec-metal/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/ec-metal/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/ec-metal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/ec-metal/labels{/name}","releases_url":"https://api.github.com/repos/opscode/ec-metal/releases{/id}","created_at":"2014-03-26T02:49:47Z","updated_at":"2014-09-04T15:31:03Z","pushed_at":"2014-09-04T20:52:37Z","git_url":"git://github.com/opscode/ec-metal.git","ssh_url":"git@github.com:opscode/ec-metal.git","clone_url":"https://github.com/opscode/ec-metal.git","svn_url":"https://github.com/opscode/ec-metal","homepage":null,"size":4289,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":12,"forks":7,"open_issues":12,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode/ec-metal/pulls/80"},"html":{"href":"https://github.com/opscode/ec-metal/pull/80"},"issue":{"href":"https://api.github.com/repos/opscode/ec-metal/issues/80"},"comments":{"href":"https://api.github.com/repos/opscode/ec-metal/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode/ec-metal/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode/ec-metal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode/ec-metal/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/opscode/ec-metal/statuses/a792ca34127e7c90184481d9569e219d69e85473"}}}}