GitHub PullRequestEvent at 2014-09-18 23:05:52
Repository: liferay-portal
Actor: natecavanaugh
Payload: {"action":"closed","number":2802,"pull_request":{"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/pulls/2802","id":21340380,"html_url":"https://github.com/natecavanaugh/liferay-portal/pull/2802","diff_url":"https://github.com/natecavanaugh/liferay-portal/pull/2802.diff","patch_url":"https://github.com/natecavanaugh/liferay-portal/pull/2802.patch","issue_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/2802","number":2802,"state":"closed","locked":false,"title":"LPS-49584","user":{"login":"jonmak08","id":860951,"avatar_url":"https://avatars.githubusercontent.com/u/860951?v=2","gravatar_id":"7c3f186b835c807d05b511917f1ecdb1","url":"https://api.github.com/users/jonmak08","html_url":"https://github.com/jonmak08","followers_url":"https://api.github.com/users/jonmak08/followers","following_url":"https://api.github.com/users/jonmak08/following{/other_user}","gists_url":"https://api.github.com/users/jonmak08/gists{/gist_id}","starred_url":"https://api.github.com/users/jonmak08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonmak08/subscriptions","organizations_url":"https://api.github.com/users/jonmak08/orgs","repos_url":"https://api.github.com/users/jonmak08/repos","events_url":"https://api.github.com/users/jonmak08/events{/privacy}","received_events_url":"https://api.github.com/users/jonmak08/received_events","type":"User","site_admin":false},"body":"Hey @natecavanaugh,\r\n\r\nAttached is an update for http://issues.liferay.com/browse/LPS-49584.\r\n\r\nNOTE: \"When running ```ant format-source```, you'll get an error saying that there are missing language keys. The aui:select tag tries to take the name attribute and convert it into a hyphenated label that then gets translated by the language keys. The thing is that we are passing in label=\"\", so it doesn't actually convert anything, but ant format-source still complains, seems like an issue with the format-source task.\" - @Robert-Frampton \r\n\r\nPlease let me know if you have any questions.  Thanks!","created_at":"2014-09-17T01:38:03Z","updated_at":"2014-09-18T23:05:51Z","closed_at":"2014-09-18T23:05:51Z","merged_at":null,"merge_commit_sha":"72720fcf1ca22e1306d8d73ef34cb0b83dfaaa75","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/pulls/2802/commits","review_comments_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/pulls/2802/comments","review_comment_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/2802/comments","statuses_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/statuses/6971cbd6462f4df77910f882a4ba783b9f7e2b02","head":{"label":"jonmak08:pull-request-1070-LPS-49584","ref":"pull-request-1070-LPS-49584","sha":"6971cbd6462f4df77910f882a4ba783b9f7e2b02","user":{"login":"jonmak08","id":860951,"avatar_url":"https://avatars.githubusercontent.com/u/860951?v=2","gravatar_id":"7c3f186b835c807d05b511917f1ecdb1","url":"https://api.github.com/users/jonmak08","html_url":"https://github.com/jonmak08","followers_url":"https://api.github.com/users/jonmak08/followers","following_url":"https://api.github.com/users/jonmak08/following{/other_user}","gists_url":"https://api.github.com/users/jonmak08/gists{/gist_id}","starred_url":"https://api.github.com/users/jonmak08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonmak08/subscriptions","organizations_url":"https://api.github.com/users/jonmak08/orgs","repos_url":"https://api.github.com/users/jonmak08/repos","events_url":"https://api.github.com/users/jonmak08/events{/privacy}","received_events_url":"https://api.github.com/users/jonmak08/received_events","type":"User","site_admin":false},"repo":{"id":1925148,"name":"liferay-portal","full_name":"jonmak08/liferay-portal","owner":{"login":"jonmak08","id":860951,"avatar_url":"https://avatars.githubusercontent.com/u/860951?v=2","gravatar_id":"7c3f186b835c807d05b511917f1ecdb1","url":"https://api.github.com/users/jonmak08","html_url":"https://github.com/jonmak08","followers_url":"https://api.github.com/users/jonmak08/followers","following_url":"https://api.github.com/users/jonmak08/following{/other_user}","gists_url":"https://api.github.com/users/jonmak08/gists{/gist_id}","starred_url":"https://api.github.com/users/jonmak08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonmak08/subscriptions","organizations_url":"https://api.github.com/users/jonmak08/orgs","repos_url":"https://api.github.com/users/jonmak08/repos","events_url":"https://api.github.com/users/jonmak08/events{/privacy}","received_events_url":"https://api.github.com/users/jonmak08/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonmak08/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/jonmak08/liferay-portal","forks_url":"https://api.github.com/repos/jonmak08/liferay-portal/forks","keys_url":"https://api.github.com/repos/jonmak08/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonmak08/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonmak08/liferay-portal/teams","hooks_url":"https://api.github.com/repos/jonmak08/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/jonmak08/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/jonmak08/liferay-portal/events","assignees_url":"https://api.github.com/repos/jonmak08/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/jonmak08/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/jonmak08/liferay-portal/tags","blobs_url":"https://api.github.com/repos/jonmak08/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonmak08/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonmak08/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonmak08/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonmak08/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/jonmak08/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/jonmak08/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/jonmak08/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/jonmak08/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/jonmak08/liferay-portal/subscription","commits_url":"https://api.github.com/repos/jonmak08/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonmak08/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonmak08/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonmak08/liferay-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/jonmak08/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/jonmak08/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonmak08/liferay-portal/merges","archive_url":"https://api.github.com/repos/jonmak08/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonmak08/liferay-portal/downloads","issues_url":"https://api.github.com/repos/jonmak08/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/jonmak08/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/jonmak08/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/jonmak08/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonmak08/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/jonmak08/liferay-portal/releases{/id}","created_at":"2011-06-20T18:47:04Z","updated_at":"2014-06-25T14:49:19Z","pushed_at":"2014-09-18T22:25:23Z","git_url":"git://github.com/jonmak08/liferay-portal.git","ssh_url":"git@github.com:jonmak08/liferay-portal.git","clone_url":"https://github.com/jonmak08/liferay-portal.git","svn_url":"https://github.com/jonmak08/liferay-portal","homepage":"http://liferay.com","size":3838604,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":2,"default_branch":"master"}},"base":{"label":"natecavanaugh:master","ref":"master","sha":"3ebcd393894692944dc0a0433d79edda9ffb00e4","user":{"login":"natecavanaugh","id":116871,"avatar_url":"https://avatars.githubusercontent.com/u/116871?v=2","gravatar_id":"3f754d8a639c608d338b580b446c59d6","url":"https://api.github.com/users/natecavanaugh","html_url":"https://github.com/natecavanaugh","followers_url":"https://api.github.com/users/natecavanaugh/followers","following_url":"https://api.github.com/users/natecavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/natecavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/natecavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natecavanaugh/subscriptions","organizations_url":"https://api.github.com/users/natecavanaugh/orgs","repos_url":"https://api.github.com/users/natecavanaugh/repos","events_url":"https://api.github.com/users/natecavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/natecavanaugh/received_events","type":"User","site_admin":false},"repo":{"id":1325549,"name":"liferay-portal","full_name":"natecavanaugh/liferay-portal","owner":{"login":"natecavanaugh","id":116871,"avatar_url":"https://avatars.githubusercontent.com/u/116871?v=2","gravatar_id":"3f754d8a639c608d338b580b446c59d6","url":"https://api.github.com/users/natecavanaugh","html_url":"https://github.com/natecavanaugh","followers_url":"https://api.github.com/users/natecavanaugh/followers","following_url":"https://api.github.com/users/natecavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/natecavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/natecavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natecavanaugh/subscriptions","organizations_url":"https://api.github.com/users/natecavanaugh/orgs","repos_url":"https://api.github.com/users/natecavanaugh/repos","events_url":"https://api.github.com/users/natecavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/natecavanaugh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natecavanaugh/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal","forks_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/forks","keys_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/teams","hooks_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/events","assignees_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/tags","blobs_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/subscription","commits_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/merges","archive_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/downloads","issues_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/releases{/id}","created_at":"2011-02-03T20:17:10Z","updated_at":"2014-06-25T17:31:24Z","pushed_at":"2014-09-18T23:05:42Z","git_url":"git://github.com/natecavanaugh/liferay-portal.git","ssh_url":"git@github.com:natecavanaugh/liferay-portal.git","clone_url":"https://github.com/natecavanaugh/liferay-portal.git","svn_url":"https://github.com/natecavanaugh/liferay-portal","homepage":"http://liferay.com","size":3906244,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/natecavanaugh/liferay-portal/pulls/2802"},"html":{"href":"https://github.com/natecavanaugh/liferay-portal/pull/2802"},"issue":{"href":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/2802"},"comments":{"href":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/2802/comments"},"review_comments":{"href":"https://api.github.com/repos/natecavanaugh/liferay-portal/pulls/2802/comments"},"review_comment":{"href":"https://api.github.com/repos/natecavanaugh/liferay-portal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/natecavanaugh/liferay-portal/pulls/2802/commits"},"statuses":{"href":"https://api.github.com/repos/natecavanaugh/liferay-portal/statuses/6971cbd6462f4df77910f882a4ba783b9f7e2b02"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":3,"additions":224,"deletions":199,"changed_files":2}}