GitHub PullRequestReviewCommentEvent at 2014-12-09 03:27:47
Repository: scikit-learn
Actor: jnothman
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/21505358","id":21505358,"diff_hunk":"@@ -667,6 +667,77 @@ def fit(self, X):\n \n \n class FeatureAgglomeration(AgglomerativeClustering, AgglomerationTransform):\n+    \"\"\"Agglomerate features.\n+\n+    Similar to AgglomerativeClustering, but recursively merges features\n+    instead of samples.\n+\n+    Parameters\n+    ----------\n+    n_clusters : int, default 2\n+        The number of clusters to find.\n+\n+    connectivity : sparse matrix, optional\n+        Connectivity matrix. Defines for each sample the neighboring\n+        samples following a given structure of the data.\n+        Default is None, i.e, the hierarchical clustering algorithm is\n+        unstructured.\n+\n+    affinity : string or callable, default \"euclidean\"\n+        Metric used to compute the linkage. Can be \"euclidean\", \"l1\", \"l2\",\n+        \"manhattan\", \"cosine\", or 'precomputed'.\n+        If linkage is \"ward\", only \"euclidean\" is accepted.\n+\n+    memory : Instance of joblib.Memory or string, optional\n+        Used to cache the output of the computation of the tree.\n+        By default, no caching is done. If a string is given, it is the\n+        path to the caching directory.\n+\n+    n_components : int, optional\n+        The number of connected components in the graph defined by the\n+        connectivity matrix. If not set, it is estimated.\n+\n+    compute_full_tree : bool or 'auto', optional, default \"auto\"\n+        Stop early the construction of the tree at n_clusters. This is\n+        useful to decrease computation time if the number of clusters is\n+        not small compared to the number of samples. This option is\n+        useful only when specifying a connectivity matrix. Note also that\n+        when varying the number of clusters and using caching, it may\n+        be advantageous to compute the full tree.\n+\n+    linkage : {\"ward\", \"complete\", \"average\"}, optional, default \"ward\"\n+        Which linkage criterion to use. The linkage criterion determines which\n+        distance to use between sets of observation. The algorithm will merge\n+        the pairs of cluster that minimize this criterion.\n+\n+        - ward minimizes the variance of the clusters being merged.\n+        - average uses the average of the distances of each observation of\n+          the two sets.\n+        - complete or maximum linkage uses the maximum distances between\n+          all observations of the two sets.\n+\n+    pooling_func : callable, default np.mean\n+        This combines the values of agglomerated features into a single\n+        value, and should accept an array of shape [M, N] and the keyword\n+        argument `axis=1`, and reduce it to an array of size [M].\n+\n+    Attributes\n+    ----------\n+    labels_ : array-like, (n_samples,)\n+        cluster labels for each point","path":"sklearn/cluster/hierarchical.py","position":61,"original_position":61,"commit_id":"54f761d823de4abd12df13c4dd35dc379a1591a1","original_commit_id":"54f761d823de4abd12df13c4dd35dc379a1591a1","user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"body":"should be for each feature","created_at":"2014-12-09T03:27:47Z","updated_at":"2014-12-09T03:27:47Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/3946#discussion_r21505358","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3946","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/21505358"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/3946#discussion_r21505358"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3946"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3946","id":25677166,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/3946","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/3946.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/3946.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3946","number":3946,"state":"open","locked":false,"title":"[MRG+1] Fix FeatureAgglomeration docs","user":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=3","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"body":"The docs are not displayed properly here, http://scikit-learn.org/stable/modules/generated/sklearn.cluster.FeatureAgglomeration.html (I keep running into these)","created_at":"2014-12-08T16:20:46Z","updated_at":"2014-12-09T03:27:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fd20c0bcb7368e13ee4f61583cad83719403913","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3946/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3946/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3946/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/54f761d823de4abd12df13c4dd35dc379a1591a1","head":{"label":"MechCoder:doc_fix","ref":"doc_fix","sha":"54f761d823de4abd12df13c4dd35dc379a1591a1","user":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=3","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"repo":{"id":9655682,"name":"scikit-learn","full_name":"MechCoder/scikit-learn","owner":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=3","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MechCoder/scikit-learn","description":"Work in Progress","fork":true,"url":"https://api.github.com/repos/MechCoder/scikit-learn","forks_url":"https://api.github.com/repos/MechCoder/scikit-learn/forks","keys_url":"https://api.github.com/repos/MechCoder/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MechCoder/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MechCoder/scikit-learn/teams","hooks_url":"https://api.github.com/repos/MechCoder/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/MechCoder/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/MechCoder/scikit-learn/events","assignees_url":"https://api.github.com/repos/MechCoder/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/MechCoder/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/MechCoder/scikit-learn/tags","blobs_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MechCoder/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/MechCoder/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/MechCoder/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/MechCoder/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/MechCoder/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/MechCoder/scikit-learn/subscription","commits_url":"https://api.github.com/repos/MechCoder/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/MechCoder/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/MechCoder/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/MechCoder/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/MechCoder/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MechCoder/scikit-learn/merges","archive_url":"https://api.github.com/repos/MechCoder/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MechCoder/scikit-learn/downloads","issues_url":"https://api.github.com/repos/MechCoder/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/MechCoder/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/MechCoder/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/MechCoder/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MechCoder/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/MechCoder/scikit-learn/releases{/id}","created_at":"2013-04-24T19:16:18Z","updated_at":"2014-12-08T15:56:55Z","pushed_at":"2014-12-08T20:03:53Z","git_url":"git://github.com/MechCoder/scikit-learn.git","ssh_url":"git@github.com:MechCoder/scikit-learn.git","clone_url":"https://github.com/MechCoder/scikit-learn.git","svn_url":"https://github.com/MechCoder/scikit-learn","homepage":"http://scikit-learn.org","size":58051,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"2cfdc1c5fe6b9364356a74fdbb95fa435a22e051","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2014-12-09T03:13:02Z","pushed_at":"2014-12-09T03:00:23Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":112545,"stargazers_count":4513,"watchers_count":4513,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2597,"mirror_url":null,"open_issues_count":537,"forks":2597,"open_issues":537,"watchers":4513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3946"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/3946"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3946"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3946/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3946/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3946/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/54f761d823de4abd12df13c4dd35dc379a1591a1"}}}}