GitHub PullRequestReviewCommentEvent at 2014-07-24 12:09:22
Repository: cockpit
Actor: stefwalter
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/15342541","id":15342541,"diff_hunk":"@@ -181,9 +181,14 @@\n               </tr>\n               <tr>\n                 <td>Domain</td>\n-                <td id=\"system_information_realms\"></td>\n+<td id=\"system_information_realms\"></td>\n+\n+                <div id=\"realms-leave-error\"></div></td>\n                 <td>\n-                  <button class=\"btn btn-default\" onclick=\"cockpit_go_down('realms')\">Change</button>\n+                  <button class=\"btn btn-default\" id=\"realms-join\">Join</button>\n+                  <button class=\"btn btn-default realms-leave-button\" translatable=\"yes\" id=\"realms-leave-0\" style=\"float:left\">Leave</button>\n+\n+<div class=\"realms-leave-spinner waiting\" id=\"realms-leave-spinner-0\" translatable=\"yes\" style=\"float:left\"/>","path":"modules/shell/shell.html","position":13,"original_position":13,"commit_id":"badbeef8d15e5ee7e4ca0e9829be9c4a63b92e24","original_commit_id":"badbeef8d15e5ee7e4ca0e9829be9c4a63b92e24","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?","gravatar_id":"45fd329b5f827be87edcc98eb1a2301a","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"body":"Broken indentation here. Suggest not using zero in id, and just handle one domain.","created_at":"2014-07-24T12:09:22Z","updated_at":"2014-07-24T12:09:22Z","html_url":"https://github.com/cockpit-project/cockpit/pull/911#discussion_r15342541","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/911","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/15342541"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/911#discussion_r15342541"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/911"}}},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/911","id":18795183,"html_url":"https://github.com/cockpit-project/cockpit/pull/911","diff_url":"https://github.com/cockpit-project/cockpit/pull/911.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/911.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/911","number":911,"state":"open","title":"shell: moves join and leave domain buttons","user":{"login":"pdonlon","id":2906828,"avatar_url":"https://avatars.githubusercontent.com/u/2906828?","gravatar_id":"561d6cb7b3bdaaabccc0335f34e0f677","url":"https://api.github.com/users/pdonlon","html_url":"https://github.com/pdonlon","followers_url":"https://api.github.com/users/pdonlon/followers","following_url":"https://api.github.com/users/pdonlon/following{/other_user}","gists_url":"https://api.github.com/users/pdonlon/gists{/gist_id}","starred_url":"https://api.github.com/users/pdonlon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdonlon/subscriptions","organizations_url":"https://api.github.com/users/pdonlon/orgs","repos_url":"https://api.github.com/users/pdonlon/repos","events_url":"https://api.github.com/users/pdonlon/events{/privacy}","received_events_url":"https://api.github.com/users/pdonlon/received_events","type":"User","site_admin":false},"body":"moved join and leave buttons to system information and removes unneeded page\r\n\r\nFixes: #868","created_at":"2014-07-23T18:56:40Z","updated_at":"2014-07-24T12:09:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22c4eb09a5e6af488d5221875241e54009d6eccf","assignee":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?","gravatar_id":"45fd329b5f827be87edcc98eb1a2301a","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/cockpit-project/cockpit/milestones/12","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones/12/labels","id":701393,"number":12,"title":"Fedora 21","description":"Due on Fedora Alpha change deadline. Further bug fixing can continue after that.","creator":{"login":"mvollmer","id":3228183,"avatar_url":"https://avatars.githubusercontent.com/u/3228183?","gravatar_id":"3afc7019e6a7bc52795564b088ec5357","url":"https://api.github.com/users/mvollmer","html_url":"https://github.com/mvollmer","followers_url":"https://api.github.com/users/mvollmer/followers","following_url":"https://api.github.com/users/mvollmer/following{/other_user}","gists_url":"https://api.github.com/users/mvollmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mvollmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvollmer/subscriptions","organizations_url":"https://api.github.com/users/mvollmer/orgs","repos_url":"https://api.github.com/users/mvollmer/repos","events_url":"https://api.github.com/users/mvollmer/events{/privacy}","received_events_url":"https://api.github.com/users/mvollmer/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":68,"state":"open","created_at":"2014-06-25T15:37:49Z","updated_at":"2014-07-24T09:40:50Z","due_on":"2014-07-22T07:00:00Z"},"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/911/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/911/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/911/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/badbeef8d15e5ee7e4ca0e9829be9c4a63b92e24","head":{"label":"pdonlon:bug862","ref":"bug862","sha":"badbeef8d15e5ee7e4ca0e9829be9c4a63b92e24","user":{"login":"pdonlon","id":2906828,"avatar_url":"https://avatars.githubusercontent.com/u/2906828?","gravatar_id":"561d6cb7b3bdaaabccc0335f34e0f677","url":"https://api.github.com/users/pdonlon","html_url":"https://github.com/pdonlon","followers_url":"https://api.github.com/users/pdonlon/followers","following_url":"https://api.github.com/users/pdonlon/following{/other_user}","gists_url":"https://api.github.com/users/pdonlon/gists{/gist_id}","starred_url":"https://api.github.com/users/pdonlon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdonlon/subscriptions","organizations_url":"https://api.github.com/users/pdonlon/orgs","repos_url":"https://api.github.com/users/pdonlon/repos","events_url":"https://api.github.com/users/pdonlon/events{/privacy}","received_events_url":"https://api.github.com/users/pdonlon/received_events","type":"User","site_admin":false},"repo":{"id":20688137,"name":"cockpit","full_name":"pdonlon/cockpit","owner":{"login":"pdonlon","id":2906828,"avatar_url":"https://avatars.githubusercontent.com/u/2906828?","gravatar_id":"561d6cb7b3bdaaabccc0335f34e0f677","url":"https://api.github.com/users/pdonlon","html_url":"https://github.com/pdonlon","followers_url":"https://api.github.com/users/pdonlon/followers","following_url":"https://api.github.com/users/pdonlon/following{/other_user}","gists_url":"https://api.github.com/users/pdonlon/gists{/gist_id}","starred_url":"https://api.github.com/users/pdonlon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdonlon/subscriptions","organizations_url":"https://api.github.com/users/pdonlon/orgs","repos_url":"https://api.github.com/users/pdonlon/repos","events_url":"https://api.github.com/users/pdonlon/events{/privacy}","received_events_url":"https://api.github.com/users/pdonlon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pdonlon/cockpit","description":"Cockpit, a user interface for GNU/Linux servers","fork":true,"url":"https://api.github.com/repos/pdonlon/cockpit","forks_url":"https://api.github.com/repos/pdonlon/cockpit/forks","keys_url":"https://api.github.com/repos/pdonlon/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdonlon/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdonlon/cockpit/teams","hooks_url":"https://api.github.com/repos/pdonlon/cockpit/hooks","issue_events_url":"https://api.github.com/repos/pdonlon/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/pdonlon/cockpit/events","assignees_url":"https://api.github.com/repos/pdonlon/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/pdonlon/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/pdonlon/cockpit/tags","blobs_url":"https://api.github.com/repos/pdonlon/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdonlon/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdonlon/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdonlon/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdonlon/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/pdonlon/cockpit/languages","stargazers_url":"https://api.github.com/repos/pdonlon/cockpit/stargazers","contributors_url":"https://api.github.com/repos/pdonlon/cockpit/contributors","subscribers_url":"https://api.github.com/repos/pdonlon/cockpit/subscribers","subscription_url":"https://api.github.com/repos/pdonlon/cockpit/subscription","commits_url":"https://api.github.com/repos/pdonlon/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdonlon/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdonlon/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdonlon/cockpit/issues/comments/{number}","contents_url":"https://api.github.com/repos/pdonlon/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/pdonlon/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdonlon/cockpit/merges","archive_url":"https://api.github.com/repos/pdonlon/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdonlon/cockpit/downloads","issues_url":"https://api.github.com/repos/pdonlon/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/pdonlon/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/pdonlon/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/pdonlon/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdonlon/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/pdonlon/cockpit/releases{/id}","created_at":"2014-06-10T14:21:11Z","updated_at":"2014-06-24T16:22:01Z","pushed_at":"2014-07-23T20:07:42Z","git_url":"git://github.com/pdonlon/cockpit.git","ssh_url":"git@github.com:pdonlon/cockpit.git","clone_url":"https://github.com/pdonlon/cockpit.git","svn_url":"https://github.com/pdonlon/cockpit","homepage":"http://www.cockpit-project.org/","size":6651,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"c8247fafe46dc18c48f2dd62ceac812726f3990c","user":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?","gravatar_id":"dbc3ef59744e7aff84ae447e664bcd05","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"name":"cockpit","full_name":"cockpit-project/cockpit","owner":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?","gravatar_id":"dbc3ef59744e7aff84ae447e664bcd05","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockpit-project/cockpit","description":"Cockpit, a user interface for GNU/Linux servers","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments/{number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","created_at":"2013-11-01T17:36:46Z","updated_at":"2014-07-24T12:08:45Z","pushed_at":"2014-07-24T07:35:22Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":25005,"stargazers_count":723,"watchers_count":723,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":51,"mirror_url":null,"open_issues_count":199,"forks":51,"open_issues":199,"watchers":723,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/911"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/911"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/911"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/911/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/911/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/911/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/badbeef8d15e5ee7e4ca0e9829be9c4a63b92e24"}}}}