GitHub PullRequestReviewCommentEvent at 2014-10-15 07:32:20
Repository: Bonsai
Actor: biddisco
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/egaburov/Bonsai/pulls/comments/18878225","id":18878225,"diff_hunk":"@@ -2,6 +2,13 @@\n \n #include <string>\n #include \"IDType.h\"\n+#ifdef BONSAI_CATALYST_STDLIB\n+ #include <boost/lexical_cast.hpp>","path":"runtime/include/BonsaiSharedData.h","position":5,"original_position":5,"commit_id":"bf5f1a419199f4c76daf77cda37484f395cdee56","original_commit_id":"bf5f1a419199f4c76daf77cda37484f395cdee56","user":{"login":"biddisco","id":941548,"avatar_url":"https://avatars.githubusercontent.com/u/941548?v=2","gravatar_id":"","url":"https://api.github.com/users/biddisco","html_url":"https://github.com/biddisco","followers_url":"https://api.github.com/users/biddisco/followers","following_url":"https://api.github.com/users/biddisco/following{/other_user}","gists_url":"https://api.github.com/users/biddisco/gists{/gist_id}","starred_url":"https://api.github.com/users/biddisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biddisco/subscriptions","organizations_url":"https://api.github.com/users/biddisco/orgs","repos_url":"https://api.github.com/users/biddisco/repos","events_url":"https://api.github.com/users/biddisco/events{/privacy}","received_events_url":"https://api.github.com/users/biddisco/received_events","type":"User","site_admin":false},"body":"Evghenii\r\n\r\nIt’s because my paraview uses CUDA and on OSX, if you need CUDA you have to link with libstdc++ and not libc++, which in tunr means you have to use the old c++ headers (though you can still have c++11 extensions like auto if you use -std=c++11)\r\n\r\nit makes my life simpler if I can add a flag for libstdc++ in cmake and allow everything to link the same\r\n\r\nJB\r\n\r\nFrom: Evghenii Gaburov [mailto:notifications@github.com]\r\nSent: 15 October 2014 09:29\r\nTo: egaburov/Bonsai\r\nCc: Biddiscombe, John A.\r\nSubject: Re: [Bonsai] Titan2 d demo (#4)\r\n\r\n\r\nIn runtime/include/BonsaiSharedData.h:\r\n\r\n> @@ -2,6 +2,13 @@\r\n\r\n>\r\n\r\n>  #include <string>\r\n\r\n>  #include \"IDType.h\"\r\n\r\n> +#ifdef BONSAI_CATALYST_STDLIB\r\n\r\n> + #include <boost/lexical_cast.hpp>\r\n\r\nI don't think you need to use boost to use to_string. OS X supports C++11, which has std::to_string. Or is there any other reason to use boost?\r\n\r\n—\r\nReply to this email directly or view it on GitHub<https://github.com/egaburov/Bonsai/pull/4/files#r18878133>.\r\n","created_at":"2014-10-15T07:32:20Z","updated_at":"2014-10-15T07:32:20Z","html_url":"https://github.com/egaburov/Bonsai/pull/4#discussion_r18878225","pull_request_url":"https://api.github.com/repos/egaburov/Bonsai/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/egaburov/Bonsai/pulls/comments/18878225"},"html":{"href":"https://github.com/egaburov/Bonsai/pull/4#discussion_r18878225"},"pull_request":{"href":"https://api.github.com/repos/egaburov/Bonsai/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/egaburov/Bonsai/pulls/4","id":22744433,"html_url":"https://github.com/egaburov/Bonsai/pull/4","diff_url":"https://github.com/egaburov/Bonsai/pull/4.diff","patch_url":"https://github.com/egaburov/Bonsai/pull/4.patch","issue_url":"https://api.github.com/repos/egaburov/Bonsai/issues/4","number":4,"state":"open","locked":false,"title":"Titan2 d demo","user":{"login":"biddisco","id":941548,"avatar_url":"https://avatars.githubusercontent.com/u/941548?v=2","gravatar_id":"","url":"https://api.github.com/users/biddisco","html_url":"https://github.com/biddisco","followers_url":"https://api.github.com/users/biddisco/followers","following_url":"https://api.github.com/users/biddisco/following{/other_user}","gists_url":"https://api.github.com/users/biddisco/gists{/gist_id}","starred_url":"https://api.github.com/users/biddisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biddisco/subscriptions","organizations_url":"https://api.github.com/users/biddisco/orgs","repos_url":"https://api.github.com/users/biddisco/repos","events_url":"https://api.github.com/users/biddisco/events{/privacy}","received_events_url":"https://api.github.com/users/biddisco/received_events","type":"User","site_admin":false},"body":"I moved stuff around so I can build snapserve and catalyst in one go, fixed up the cmakelists so it works for me if you use the tools/CMakeLists file.\r\n\r\nAdded first round of paraview integration. Just started and this is messy, so will be cleaned up lots. Working on live insitu viz now.\r\n\r\nWill delete this repo and fork from the origin so that pull requests go there. Not sure how to change the origin of the github repo directly.","created_at":"2014-10-14T21:23:21Z","updated_at":"2014-10-15T07:32:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01e04710ce6adbd1d44806637d7d7bb769674ef2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/egaburov/Bonsai/pulls/4/commits","review_comments_url":"https://api.github.com/repos/egaburov/Bonsai/pulls/4/comments","review_comment_url":"https://api.github.com/repos/egaburov/Bonsai/pulls/comments/{number}","comments_url":"https://api.github.com/repos/egaburov/Bonsai/issues/4/comments","statuses_url":"https://api.github.com/repos/egaburov/Bonsai/statuses/bf5f1a419199f4c76daf77cda37484f395cdee56","head":{"label":"biddisco:Titan2D-demo","ref":"Titan2D-demo","sha":"bf5f1a419199f4c76daf77cda37484f395cdee56","user":{"login":"biddisco","id":941548,"avatar_url":"https://avatars.githubusercontent.com/u/941548?v=2","gravatar_id":"","url":"https://api.github.com/users/biddisco","html_url":"https://github.com/biddisco","followers_url":"https://api.github.com/users/biddisco/followers","following_url":"https://api.github.com/users/biddisco/following{/other_user}","gists_url":"https://api.github.com/users/biddisco/gists{/gist_id}","starred_url":"https://api.github.com/users/biddisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biddisco/subscriptions","organizations_url":"https://api.github.com/users/biddisco/orgs","repos_url":"https://api.github.com/users/biddisco/repos","events_url":"https://api.github.com/users/biddisco/events{/privacy}","received_events_url":"https://api.github.com/users/biddisco/received_events","type":"User","site_admin":false},"repo":{"id":25112166,"name":"Bonsai","full_name":"biddisco/Bonsai","owner":{"login":"biddisco","id":941548,"avatar_url":"https://avatars.githubusercontent.com/u/941548?v=2","gravatar_id":"","url":"https://api.github.com/users/biddisco","html_url":"https://github.com/biddisco","followers_url":"https://api.github.com/users/biddisco/followers","following_url":"https://api.github.com/users/biddisco/following{/other_user}","gists_url":"https://api.github.com/users/biddisco/gists{/gist_id}","starred_url":"https://api.github.com/users/biddisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biddisco/subscriptions","organizations_url":"https://api.github.com/users/biddisco/orgs","repos_url":"https://api.github.com/users/biddisco/repos","events_url":"https://api.github.com/users/biddisco/events{/privacy}","received_events_url":"https://api.github.com/users/biddisco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/biddisco/Bonsai","description":"Bonsai GPU tree code","fork":true,"url":"https://api.github.com/repos/biddisco/Bonsai","forks_url":"https://api.github.com/repos/biddisco/Bonsai/forks","keys_url":"https://api.github.com/repos/biddisco/Bonsai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biddisco/Bonsai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biddisco/Bonsai/teams","hooks_url":"https://api.github.com/repos/biddisco/Bonsai/hooks","issue_events_url":"https://api.github.com/repos/biddisco/Bonsai/issues/events{/number}","events_url":"https://api.github.com/repos/biddisco/Bonsai/events","assignees_url":"https://api.github.com/repos/biddisco/Bonsai/assignees{/user}","branches_url":"https://api.github.com/repos/biddisco/Bonsai/branches{/branch}","tags_url":"https://api.github.com/repos/biddisco/Bonsai/tags","blobs_url":"https://api.github.com/repos/biddisco/Bonsai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biddisco/Bonsai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biddisco/Bonsai/git/refs{/sha}","trees_url":"https://api.github.com/repos/biddisco/Bonsai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biddisco/Bonsai/statuses/{sha}","languages_url":"https://api.github.com/repos/biddisco/Bonsai/languages","stargazers_url":"https://api.github.com/repos/biddisco/Bonsai/stargazers","contributors_url":"https://api.github.com/repos/biddisco/Bonsai/contributors","subscribers_url":"https://api.github.com/repos/biddisco/Bonsai/subscribers","subscription_url":"https://api.github.com/repos/biddisco/Bonsai/subscription","commits_url":"https://api.github.com/repos/biddisco/Bonsai/commits{/sha}","git_commits_url":"https://api.github.com/repos/biddisco/Bonsai/git/commits{/sha}","comments_url":"https://api.github.com/repos/biddisco/Bonsai/comments{/number}","issue_comment_url":"https://api.github.com/repos/biddisco/Bonsai/issues/comments/{number}","contents_url":"https://api.github.com/repos/biddisco/Bonsai/contents/{+path}","compare_url":"https://api.github.com/repos/biddisco/Bonsai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biddisco/Bonsai/merges","archive_url":"https://api.github.com/repos/biddisco/Bonsai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biddisco/Bonsai/downloads","issues_url":"https://api.github.com/repos/biddisco/Bonsai/issues{/number}","pulls_url":"https://api.github.com/repos/biddisco/Bonsai/pulls{/number}","milestones_url":"https://api.github.com/repos/biddisco/Bonsai/milestones{/number}","notifications_url":"https://api.github.com/repos/biddisco/Bonsai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biddisco/Bonsai/labels{/name}","releases_url":"https://api.github.com/repos/biddisco/Bonsai/releases{/id}","created_at":"2014-10-12T07:30:13Z","updated_at":"2014-03-04T12:03:36Z","pushed_at":"2014-10-14T21:19:24Z","git_url":"git://github.com/biddisco/Bonsai.git","ssh_url":"git@github.com:biddisco/Bonsai.git","clone_url":"https://github.com/biddisco/Bonsai.git","svn_url":"https://github.com/biddisco/Bonsai","homepage":"http://castle.strw.leidenuniv.nl/software/bonsai-gpu-tree-code.html","size":89578,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"egaburov:Titan2D-demo","ref":"Titan2D-demo","sha":"1e54d39a1e63e492a2d9eb2c86171a2c0c739416","user":{"login":"egaburov","id":1485713,"avatar_url":"https://avatars.githubusercontent.com/u/1485713?v=2","gravatar_id":"","url":"https://api.github.com/users/egaburov","html_url":"https://github.com/egaburov","followers_url":"https://api.github.com/users/egaburov/followers","following_url":"https://api.github.com/users/egaburov/following{/other_user}","gists_url":"https://api.github.com/users/egaburov/gists{/gist_id}","starred_url":"https://api.github.com/users/egaburov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egaburov/subscriptions","organizations_url":"https://api.github.com/users/egaburov/orgs","repos_url":"https://api.github.com/users/egaburov/repos","events_url":"https://api.github.com/users/egaburov/events{/privacy}","received_events_url":"https://api.github.com/users/egaburov/received_events","type":"User","site_admin":false},"repo":{"id":17400474,"name":"Bonsai","full_name":"egaburov/Bonsai","owner":{"login":"egaburov","id":1485713,"avatar_url":"https://avatars.githubusercontent.com/u/1485713?v=2","gravatar_id":"","url":"https://api.github.com/users/egaburov","html_url":"https://github.com/egaburov","followers_url":"https://api.github.com/users/egaburov/followers","following_url":"https://api.github.com/users/egaburov/following{/other_user}","gists_url":"https://api.github.com/users/egaburov/gists{/gist_id}","starred_url":"https://api.github.com/users/egaburov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egaburov/subscriptions","organizations_url":"https://api.github.com/users/egaburov/orgs","repos_url":"https://api.github.com/users/egaburov/repos","events_url":"https://api.github.com/users/egaburov/events{/privacy}","received_events_url":"https://api.github.com/users/egaburov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/egaburov/Bonsai","description":"Bonsai GPU tree code","fork":true,"url":"https://api.github.com/repos/egaburov/Bonsai","forks_url":"https://api.github.com/repos/egaburov/Bonsai/forks","keys_url":"https://api.github.com/repos/egaburov/Bonsai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/egaburov/Bonsai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/egaburov/Bonsai/teams","hooks_url":"https://api.github.com/repos/egaburov/Bonsai/hooks","issue_events_url":"https://api.github.com/repos/egaburov/Bonsai/issues/events{/number}","events_url":"https://api.github.com/repos/egaburov/Bonsai/events","assignees_url":"https://api.github.com/repos/egaburov/Bonsai/assignees{/user}","branches_url":"https://api.github.com/repos/egaburov/Bonsai/branches{/branch}","tags_url":"https://api.github.com/repos/egaburov/Bonsai/tags","blobs_url":"https://api.github.com/repos/egaburov/Bonsai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/egaburov/Bonsai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/egaburov/Bonsai/git/refs{/sha}","trees_url":"https://api.github.com/repos/egaburov/Bonsai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/egaburov/Bonsai/statuses/{sha}","languages_url":"https://api.github.com/repos/egaburov/Bonsai/languages","stargazers_url":"https://api.github.com/repos/egaburov/Bonsai/stargazers","contributors_url":"https://api.github.com/repos/egaburov/Bonsai/contributors","subscribers_url":"https://api.github.com/repos/egaburov/Bonsai/subscribers","subscription_url":"https://api.github.com/repos/egaburov/Bonsai/subscription","commits_url":"https://api.github.com/repos/egaburov/Bonsai/commits{/sha}","git_commits_url":"https://api.github.com/repos/egaburov/Bonsai/git/commits{/sha}","comments_url":"https://api.github.com/repos/egaburov/Bonsai/comments{/number}","issue_comment_url":"https://api.github.com/repos/egaburov/Bonsai/issues/comments/{number}","contents_url":"https://api.github.com/repos/egaburov/Bonsai/contents/{+path}","compare_url":"https://api.github.com/repos/egaburov/Bonsai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/egaburov/Bonsai/merges","archive_url":"https://api.github.com/repos/egaburov/Bonsai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/egaburov/Bonsai/downloads","issues_url":"https://api.github.com/repos/egaburov/Bonsai/issues{/number}","pulls_url":"https://api.github.com/repos/egaburov/Bonsai/pulls{/number}","milestones_url":"https://api.github.com/repos/egaburov/Bonsai/milestones{/number}","notifications_url":"https://api.github.com/repos/egaburov/Bonsai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/egaburov/Bonsai/labels{/name}","releases_url":"https://api.github.com/repos/egaburov/Bonsai/releases{/id}","created_at":"2014-03-04T11:59:23Z","updated_at":"2014-03-04T12:03:36Z","pushed_at":"2014-10-14T06:53:20Z","git_url":"git://github.com/egaburov/Bonsai.git","ssh_url":"git@github.com:egaburov/Bonsai.git","clone_url":"https://github.com/egaburov/Bonsai.git","svn_url":"https://github.com/egaburov/Bonsai","homepage":"http://castle.strw.leidenuniv.nl/software/bonsai-gpu-tree-code.html","size":89578,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/egaburov/Bonsai/pulls/4"},"html":{"href":"https://github.com/egaburov/Bonsai/pull/4"},"issue":{"href":"https://api.github.com/repos/egaburov/Bonsai/issues/4"},"comments":{"href":"https://api.github.com/repos/egaburov/Bonsai/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/egaburov/Bonsai/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/egaburov/Bonsai/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/egaburov/Bonsai/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/egaburov/Bonsai/statuses/bf5f1a419199f4c76daf77cda37484f395cdee56"}}}}