GitHub PullRequestEvent at 2014-01-17 11:01:22
Repository: AndroidSlidingUpPanel
Actor: matto1990
Payload: {"action":"opened","number":97,"pull_request":{"url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/pulls/97","id":11616376,"html_url":"https://github.com/umano/AndroidSlidingUpPanel/pull/97","diff_url":"https://github.com/umano/AndroidSlidingUpPanel/pull/97.diff","patch_url":"https://github.com/umano/AndroidSlidingUpPanel/pull/97.patch","issue_url":"https://github.com/umano/AndroidSlidingUpPanel/pull/97","number":97,"state":"open","title":"Fixed parents overriding touch intercepts (SlidingUpPanel inside DrawerLayout)","user":{"login":"matto1990","id":97068,"avatar_url":"https://gravatar.com/avatar/0a04b2cf3f8827fee6310c52d350a5fc?d=https%3A%2F%2Fidenticons.github.com%2F1887b07316b9161692d54fcdbbd41e46.png&r=x","gravatar_id":"0a04b2cf3f8827fee6310c52d350a5fc","url":"https://api.github.com/users/matto1990","html_url":"https://github.com/matto1990","followers_url":"https://api.github.com/users/matto1990/followers","following_url":"https://api.github.com/users/matto1990/following{/other_user}","gists_url":"https://api.github.com/users/matto1990/gists{/gist_id}","starred_url":"https://api.github.com/users/matto1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matto1990/subscriptions","organizations_url":"https://api.github.com/users/matto1990/orgs","repos_url":"https://api.github.com/users/matto1990/repos","events_url":"https://api.github.com/users/matto1990/events{/privacy}","received_events_url":"https://api.github.com/users/matto1990/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI was having a problem when I was using SlidingUpPanelLayout inside a DrawerLayout. If you started dragging the panel up and then moved your finger slightly either left or right the DrawerPanel would take over and start moving the drawer left and right.\r\n\r\nThe solution was to call `requestDisallowInterceptTouchEvent` inside `onInterceptTouchEvent` with the value we are going to return. Therefore we will still allow the drawer to intercept if we don't want it, but we will effectively lock the drawer if we've decided the user has started dragging the SlidingUpPanel.\r\n\r\nLet me know if there are any changes which need to be made.\r\n\r\nMatt","created_at":"2014-01-17T11:01:22Z","updated_at":"2014-01-17T11:01:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://github.com/umano/AndroidSlidingUpPanel/pull/97/commits","review_comments_url":"https://github.com/umano/AndroidSlidingUpPanel/pull/97/comments","review_comment_url":"/repos/umano/AndroidSlidingUpPanel/pulls/comments/{number}","comments_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/issues/97/comments","statuses_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/statuses/0b7b1f136964157d6840ceb27cbadb3601da0f5a","head":{"label":"ribot:fix_parent_intercept","ref":"fix_parent_intercept","sha":"0b7b1f136964157d6840ceb27cbadb3601da0f5a","user":{"login":"ribot","id":26924,"avatar_url":"https://gravatar.com/avatar/7dbd905e28a97ddade84e44562628067?d=https%3A%2F%2Fidenticons.github.com%2Ff5e083092550d2f93898e9829e677e39.png&r=x","gravatar_id":"7dbd905e28a97ddade84e44562628067","url":"https://api.github.com/users/ribot","html_url":"https://github.com/ribot","followers_url":"https://api.github.com/users/ribot/followers","following_url":"https://api.github.com/users/ribot/following{/other_user}","gists_url":"https://api.github.com/users/ribot/gists{/gist_id}","starred_url":"https://api.github.com/users/ribot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ribot/subscriptions","organizations_url":"https://api.github.com/users/ribot/orgs","repos_url":"https://api.github.com/users/ribot/repos","events_url":"https://api.github.com/users/ribot/events{/privacy}","received_events_url":"https://api.github.com/users/ribot/received_events","type":"Organization","site_admin":false},"repo":{"id":15997258,"name":"AndroidSlidingUpPanel","full_name":"ribot/AndroidSlidingUpPanel","owner":{"login":"ribot","id":26924,"avatar_url":"https://gravatar.com/avatar/7dbd905e28a97ddade84e44562628067?d=https%3A%2F%2Fidenticons.github.com%2Ff5e083092550d2f93898e9829e677e39.png&r=x","gravatar_id":"7dbd905e28a97ddade84e44562628067","url":"https://api.github.com/users/ribot","html_url":"https://github.com/ribot","followers_url":"https://api.github.com/users/ribot/followers","following_url":"https://api.github.com/users/ribot/following{/other_user}","gists_url":"https://api.github.com/users/ribot/gists{/gist_id}","starred_url":"https://api.github.com/users/ribot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ribot/subscriptions","organizations_url":"https://api.github.com/users/ribot/orgs","repos_url":"https://api.github.com/users/ribot/repos","events_url":"https://api.github.com/users/ribot/events{/privacy}","received_events_url":"https://api.github.com/users/ribot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ribot/AndroidSlidingUpPanel","description":"Android Sliding Up Panel Demo","fork":true,"url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel","forks_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/forks","keys_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/teams","hooks_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/hooks","issue_events_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/issues/events{/number}","events_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/events","assignees_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/assignees{/user}","branches_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/branches{/branch}","tags_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/tags","blobs_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/statuses/{sha}","languages_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/languages","stargazers_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/stargazers","contributors_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/contributors","subscribers_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/subscribers","subscription_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/subscription","commits_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/issues/comments/{number}","contents_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/contents/{+path}","compare_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/merges","archive_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/downloads","issues_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/issues{/number}","pulls_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/pulls{/number}","milestones_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/milestones{/number}","notifications_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/labels{/name}","releases_url":"https://api.github.com/repos/ribot/AndroidSlidingUpPanel/releases{/id}","created_at":"2014-01-17T10:50:21Z","updated_at":"2014-01-17T11:01:22Z","pushed_at":"2014-01-17T10:57:05Z","git_url":"git://github.com/ribot/AndroidSlidingUpPanel.git","ssh_url":"git@github.com:ribot/AndroidSlidingUpPanel.git","clone_url":"https://github.com/ribot/AndroidSlidingUpPanel.git","svn_url":"https://github.com/ribot/AndroidSlidingUpPanel","homepage":null,"size":2461,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"umano:master","ref":"master","sha":"d38270f531d77d8f2bffe3b8baf1d08b5acdb83a","user":{"login":"umano","id":4552937,"avatar_url":"https://gravatar.com/avatar/ccac5fbb2cff4d861fe863b79a61deaa?d=https%3A%2F%2Fidenticons.github.com%2F63c91b71b34283b791d022f8ef6a68a2.png&r=x","gravatar_id":"ccac5fbb2cff4d861fe863b79a61deaa","url":"https://api.github.com/users/umano","html_url":"https://github.com/umano","followers_url":"https://api.github.com/users/umano/followers","following_url":"https://api.github.com/users/umano/following{/other_user}","gists_url":"https://api.github.com/users/umano/gists{/gist_id}","starred_url":"https://api.github.com/users/umano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umano/subscriptions","organizations_url":"https://api.github.com/users/umano/orgs","repos_url":"https://api.github.com/users/umano/repos","events_url":"https://api.github.com/users/umano/events{/privacy}","received_events_url":"https://api.github.com/users/umano/received_events","type":"Organization","site_admin":false},"repo":{"id":10410764,"name":"AndroidSlidingUpPanel","full_name":"umano/AndroidSlidingUpPanel","owner":{"login":"umano","id":4552937,"avatar_url":"https://gravatar.com/avatar/ccac5fbb2cff4d861fe863b79a61deaa?d=https%3A%2F%2Fidenticons.github.com%2F63c91b71b34283b791d022f8ef6a68a2.png&r=x","gravatar_id":"ccac5fbb2cff4d861fe863b79a61deaa","url":"https://api.github.com/users/umano","html_url":"https://github.com/umano","followers_url":"https://api.github.com/users/umano/followers","following_url":"https://api.github.com/users/umano/following{/other_user}","gists_url":"https://api.github.com/users/umano/gists{/gist_id}","starred_url":"https://api.github.com/users/umano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umano/subscriptions","organizations_url":"https://api.github.com/users/umano/orgs","repos_url":"https://api.github.com/users/umano/repos","events_url":"https://api.github.com/users/umano/events{/privacy}","received_events_url":"https://api.github.com/users/umano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/umano/AndroidSlidingUpPanel","description":"Android Sliding Up Panel Demo","fork":false,"url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel","forks_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/forks","keys_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/teams","hooks_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/hooks","issue_events_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/issues/events{/number}","events_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/events","assignees_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/assignees{/user}","branches_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/branches{/branch}","tags_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/tags","blobs_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/git/refs{/sha}","trees_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/statuses/{sha}","languages_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/languages","stargazers_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/stargazers","contributors_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/contributors","subscribers_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/subscribers","subscription_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/subscription","commits_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/commits{/sha}","git_commits_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/git/commits{/sha}","comments_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/comments{/number}","issue_comment_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/issues/comments/{number}","contents_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/contents/{+path}","compare_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/merges","archive_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/downloads","issues_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/issues{/number}","pulls_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/pulls{/number}","milestones_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/milestones{/number}","notifications_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/labels{/name}","releases_url":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/releases{/id}","created_at":"2013-05-31T18:33:53Z","updated_at":"2014-01-17T09:01:26Z","pushed_at":"2014-01-05T19:18:07Z","git_url":"git://github.com/umano/AndroidSlidingUpPanel.git","ssh_url":"git@github.com:umano/AndroidSlidingUpPanel.git","clone_url":"https://github.com/umano/AndroidSlidingUpPanel.git","svn_url":"https://github.com/umano/AndroidSlidingUpPanel","homepage":null,"size":2461,"stargazers_count":777,"watchers_count":777,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":223,"mirror_url":null,"open_issues_count":20,"forks":223,"open_issues":20,"watchers":777,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/pulls/97"},"html":{"href":"https://github.com/umano/AndroidSlidingUpPanel/pull/97"},"issue":{"href":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/issues/97"},"comments":{"href":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/pulls/97/comments"},"statuses":{"href":"https://api.github.com/repos/umano/AndroidSlidingUpPanel/statuses/0b7b1f136964157d6840ceb27cbadb3601da0f5a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":8,"deletions":1,"changed_files":2}}