GitHub PushEvent at 2014-12-09 18:28:19
Repository: sideci-sample-rails
Actor: sideci-sample
Payload: {"shas":[["4ed60af60d8b0ce6696f03d2d77916713c39af12","d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","Revert to 4.1 behavior for casting PG arrays\n\nThe user is able to pass PG string literals in 4.1, and have it\nconverted to an array. This is also possible in 4.2, but it would remain\nin string form until saving and reloading, which breaks our\n`attr = save.reload.attr` contract. I think we should deprecate this in\n5.0, and only allow array input from user sources. However, this\ncurrently constitutes a breaking change to public API that did not go\nthrough a deprecation cycle.","Sean Griffin",true],["7daeb98c769a3968a2ccf48ff593909bf1a9d7b0","d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","Don't error when `attributes` is called on a frozen AR model\n\n`freeze` will ultimately end up freezing the `AttributeSet`, which in\nturn freezes its `@attributes` hash. However, we actually insert a\nspecial object to lazily instantiate the values of the hash on demand.\nWhen it does need to actually instantiate all of them for iteration (the\nonly case is `ActiveRecord::Base#attributes`, which calls\n`AttributeSet#to_h`), it will set an instance variable as a performance\noptimization\n\nSince it's just an optimization for subsequent calls, and that method\nbeing called at all is a very uncommon case, we can just leave the ivar\nalone if we're frozen, as opposed to coming up with some overly\ncomplicated mechanism for freezing which allows us to continue to modify\nourselves.\n\nFixes #17960","Sean Griffin",true],["3502e6ed7c7a720e6b4d358d9ff7b3242e52a36f","ebd73beb044ee5759f027a56464cea105bbc60a7@gmail.com","Remove unused \"Developer\" fixtures from tests\n\nThe `RecursiveCallbackDeveloper` and `ImmutableMethodDeveloper` classes\nare not used anymore in tests, and neither is the `@cancelled` variable.","claudiob",true],["42418cfc94d1356d35d28d786f63e7fab9406ad6","d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","Allow custom handling of non-standard types in `time_zone_conversion`\n\nPostgreSQL for example, allows infinity as a valid value for date time\ncolumns. The PG type has explicit handling for that case. However, time\nzone conversion will end up trampling that handling. Unfortunately, we\ncan't call super and then convert time zones.\n\nHowever, if we get back nil from `.in_time_zone`, it's something we\ndidn't expect so we can let the superclass handle it.\n\nFixes #17971","Sean Griffin",true],["65588b7463b227fd63f73b56b3df9d3ea5ab8996","d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","Update test case for TZ aware attributes\n\nThe test added in 42418cfc94d1356d35d28d786f63e7fab9406ad6 wasn't\nactually testing anything, since the bug was with TZ aware attributes\nonly.","Sean Griffin",true],["083505a7d6ddb8082e448726c7710a4bf66d6a69","37b8411fc533112bb69dd1aa56980922c21ae5e0@gmail.com","[ci skip] Fix typo","yui-knk",true],["11f491e06af73f309c0bb9395bcad30db3945b05","84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","Merge pull request #17977 from yui-knk/fix/typo\n\n[ci skip] Fix typo","Rafael Mendonça França",true],["57a6d805153ede840a3b57ab70ae1810978a2512","999e8c50cd8b45fcffd2276fb62f876489a73119@gmail.com","Merge pull request #17972 from claudiob/remove-unused-callback-fixtures\n\nRemove unused \"Developer\" fixtures from tests","Carlos Antonio da Silva",true],["8e52954349c29d5f190f01b21e9087885afd8dab","06648be64f8fbc529d817d157ec32d385ea42f22@dio.jp","Unused csv fixture file","Akira Matsuda",true],["112274ebffa0cb3e5e15e61a866031d9200c5331","ef48541db1adfd685e6c05ada4c0bec436ea3aa7@gmail.com","Fix options overwritten by super","Jose Añasco",true],["5c7b5dc741f6980de2592e9b113ae385000a6da7","84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","Merge pull request #17975 from merongivian/add_test_for_search_field\n\nFix options overwritten by super","Rafael Mendonça França",true],["6d59473b4873a81d7cc56023d17f8ec83075b803","bbcf2e084264b283c8b709566edfcf822f9d2b7d@gmail.com","Adding a tip in the guides about possible database permission problems on\nloading fixtures to the database.\n\nReference #17542","andrey.nering@gmail.com",true],["44a6ed2fe5330d78db6eee0f3eb0ced8e7f4f421","a1b4a5d79a04170be8c419b6b204d1834682e890@gmail.com","Merge pull request #17982 from andreynering/testing-documentation\n\nTesting Guides: adding TIP about database permission problems [ci skip]","Richard Schneeman",true]],"size":13,"ref":"refs/heads/master","head":"44a6ed2fe5330d78db6eee0f3eb0ced8e7f4f421"}