GitHub PullRequestReviewCommentEvent at 2014-12-17 17:57:21
Repository: testing
Actor: mhilton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/testing/pulls/comments/21990365","id":21990365,"diff_hunk":"@@ -95,6 +96,16 @@ var assertJSONCallTests = []struct {\n \t\t\treturn resp, err\n \t\t},\n \t},\n+}, {\n+\tabout: \"expect error\",\n+\tparams: httptesting.JSONCallParams{\n+\t\tURL:          \"/\",\n+\t\tExpectStatus: http.StatusTeapot,\n+\t\tDo: func(req *http.Request) (*http.Response, error) {\n+\t\t\treturn nil, fmt.Errorf(\"some error\")\n+\t\t},\n+\t\tExpectError: \"some error\",\n+\t},","path":"httptesting/http_test.go","position":30,"original_position":30,"commit_id":"74bdc85852aaa750bc89008875c14357e879a477","original_commit_id":"74bdc85852aaa750bc89008875c14357e879a477","user":{"login":"mhilton","id":1136018,"avatar_url":"https://avatars.githubusercontent.com/u/1136018?v=3","gravatar_id":"","url":"https://api.github.com/users/mhilton","html_url":"https://github.com/mhilton","followers_url":"https://api.github.com/users/mhilton/followers","following_url":"https://api.github.com/users/mhilton/following{/other_user}","gists_url":"https://api.github.com/users/mhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilton/subscriptions","organizations_url":"https://api.github.com/users/mhilton/orgs","repos_url":"https://api.github.com/users/mhilton/repos","events_url":"https://api.github.com/users/mhilton/events{/privacy}","received_events_url":"https://api.github.com/users/mhilton/received_events","type":"User","site_admin":false},"body":"Possibly add a test that makes use of a regular expression in ExpectError?","created_at":"2014-12-17T17:57:21Z","updated_at":"2014-12-17T17:57:21Z","html_url":"https://github.com/juju/testing/pull/46#discussion_r21990365","pull_request_url":"https://api.github.com/repos/juju/testing/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/juju/testing/pulls/comments/21990365"},"html":{"href":"https://github.com/juju/testing/pull/46#discussion_r21990365"},"pull_request":{"href":"https://api.github.com/repos/juju/testing/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/juju/testing/pulls/46","id":26243007,"html_url":"https://github.com/juju/testing/pull/46","diff_url":"https://github.com/juju/testing/pull/46.diff","patch_url":"https://github.com/juju/testing/pull/46.patch","issue_url":"https://api.github.com/repos/juju/testing/issues/46","number":46,"state":"open","locked":false,"title":"httptesting: add ExpectError parameter","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"body":"This allows us to check Do error conditions.","created_at":"2014-12-17T17:52:02Z","updated_at":"2014-12-17T17:57:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddb703ae7b4bdc306d99ce7025af6cd88d60e832","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/testing/pulls/46/commits","review_comments_url":"https://api.github.com/repos/juju/testing/pulls/46/comments","review_comment_url":"https://api.github.com/repos/juju/testing/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/testing/issues/46/comments","statuses_url":"https://api.github.com/repos/juju/testing/statuses/74bdc85852aaa750bc89008875c14357e879a477","head":{"label":"rogpeppe:004-httptesting-expect-error","ref":"004-httptesting-expect-error","sha":"74bdc85852aaa750bc89008875c14357e879a477","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"repo":{"id":20296179,"name":"juju-testing","full_name":"rogpeppe/juju-testing","owner":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rogpeppe/juju-testing","description":"Testing gocheck suites and checkers used across juju projects","fork":true,"url":"https://api.github.com/repos/rogpeppe/juju-testing","forks_url":"https://api.github.com/repos/rogpeppe/juju-testing/forks","keys_url":"https://api.github.com/repos/rogpeppe/juju-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rogpeppe/juju-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rogpeppe/juju-testing/teams","hooks_url":"https://api.github.com/repos/rogpeppe/juju-testing/hooks","issue_events_url":"https://api.github.com/repos/rogpeppe/juju-testing/issues/events{/number}","events_url":"https://api.github.com/repos/rogpeppe/juju-testing/events","assignees_url":"https://api.github.com/repos/rogpeppe/juju-testing/assignees{/user}","branches_url":"https://api.github.com/repos/rogpeppe/juju-testing/branches{/branch}","tags_url":"https://api.github.com/repos/rogpeppe/juju-testing/tags","blobs_url":"https://api.github.com/repos/rogpeppe/juju-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rogpeppe/juju-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rogpeppe/juju-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/rogpeppe/juju-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rogpeppe/juju-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/rogpeppe/juju-testing/languages","stargazers_url":"https://api.github.com/repos/rogpeppe/juju-testing/stargazers","contributors_url":"https://api.github.com/repos/rogpeppe/juju-testing/contributors","subscribers_url":"https://api.github.com/repos/rogpeppe/juju-testing/subscribers","subscription_url":"https://api.github.com/repos/rogpeppe/juju-testing/subscription","commits_url":"https://api.github.com/repos/rogpeppe/juju-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/rogpeppe/juju-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/rogpeppe/juju-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/rogpeppe/juju-testing/issues/comments/{number}","contents_url":"https://api.github.com/repos/rogpeppe/juju-testing/contents/{+path}","compare_url":"https://api.github.com/repos/rogpeppe/juju-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rogpeppe/juju-testing/merges","archive_url":"https://api.github.com/repos/rogpeppe/juju-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rogpeppe/juju-testing/downloads","issues_url":"https://api.github.com/repos/rogpeppe/juju-testing/issues{/number}","pulls_url":"https://api.github.com/repos/rogpeppe/juju-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/rogpeppe/juju-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/rogpeppe/juju-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rogpeppe/juju-testing/labels{/name}","releases_url":"https://api.github.com/repos/rogpeppe/juju-testing/releases{/id}","created_at":"2014-05-29T14:20:06Z","updated_at":"2014-06-10T12:05:00Z","pushed_at":"2014-12-17T17:55:45Z","git_url":"git://github.com/rogpeppe/juju-testing.git","ssh_url":"git@github.com:rogpeppe/juju-testing.git","clone_url":"https://github.com/rogpeppe/juju-testing.git","svn_url":"https://github.com/rogpeppe/juju-testing","homepage":null,"size":361,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"c6b6363b09f3c08601a6949855df2f3a4d182730","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":16748962,"name":"testing","full_name":"juju/testing","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/testing","description":"Testing gocheck suites and checkers used across juju projects","fork":false,"url":"https://api.github.com/repos/juju/testing","forks_url":"https://api.github.com/repos/juju/testing/forks","keys_url":"https://api.github.com/repos/juju/testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/testing/teams","hooks_url":"https://api.github.com/repos/juju/testing/hooks","issue_events_url":"https://api.github.com/repos/juju/testing/issues/events{/number}","events_url":"https://api.github.com/repos/juju/testing/events","assignees_url":"https://api.github.com/repos/juju/testing/assignees{/user}","branches_url":"https://api.github.com/repos/juju/testing/branches{/branch}","tags_url":"https://api.github.com/repos/juju/testing/tags","blobs_url":"https://api.github.com/repos/juju/testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/testing/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/testing/languages","stargazers_url":"https://api.github.com/repos/juju/testing/stargazers","contributors_url":"https://api.github.com/repos/juju/testing/contributors","subscribers_url":"https://api.github.com/repos/juju/testing/subscribers","subscription_url":"https://api.github.com/repos/juju/testing/subscription","commits_url":"https://api.github.com/repos/juju/testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/testing/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/testing/contents/{+path}","compare_url":"https://api.github.com/repos/juju/testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/testing/merges","archive_url":"https://api.github.com/repos/juju/testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/testing/downloads","issues_url":"https://api.github.com/repos/juju/testing/issues{/number}","pulls_url":"https://api.github.com/repos/juju/testing/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/testing/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/testing/labels{/name}","releases_url":"https://api.github.com/repos/juju/testing/releases{/id}","created_at":"2014-02-11T23:08:23Z","updated_at":"2014-12-17T14:12:25Z","pushed_at":"2014-12-17T14:12:25Z","git_url":"git://github.com/juju/testing.git","ssh_url":"git@github.com:juju/testing.git","clone_url":"https://github.com/juju/testing.git","svn_url":"https://github.com/juju/testing","homepage":null,"size":544,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":6,"forks":18,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/testing/pulls/46"},"html":{"href":"https://github.com/juju/testing/pull/46"},"issue":{"href":"https://api.github.com/repos/juju/testing/issues/46"},"comments":{"href":"https://api.github.com/repos/juju/testing/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/testing/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/testing/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/testing/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/juju/testing/statuses/74bdc85852aaa750bc89008875c14357e879a477"}}}}