GitHub PullRequestEvent at 2014-05-29 20:01:03
Repository: node-mysql
Actor: dougwilson
Payload: {"action":"closed","number":834,"pull_request":{"url":"https://api.github.com/repos/felixge/node-mysql/pulls/834","id":16500307,"html_url":"https://github.com/felixge/node-mysql/pull/834","diff_url":"https://github.com/felixge/node-mysql/pull/834.diff","patch_url":"https://github.com/felixge/node-mysql/pull/834.patch","issue_url":"https://api.github.com/repos/felixge/node-mysql/issues/834","number":834,"state":"closed","title":"call the callback when getting a connection from the pool fails","user":{"login":"edgework","id":5122883,"avatar_url":"https://avatars.githubusercontent.com/u/5122883?","gravatar_id":"0c9c8f27d98e516acecfa23b07b1eb1d","url":"https://api.github.com/users/edgework","html_url":"https://github.com/edgework","followers_url":"https://api.github.com/users/edgework/followers","following_url":"https://api.github.com/users/edgework/following{/other_user}","gists_url":"https://api.github.com/users/edgework/gists{/gist_id}","starred_url":"https://api.github.com/users/edgework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgework/subscriptions","organizations_url":"https://api.github.com/users/edgework/orgs","repos_url":"https://api.github.com/users/edgework/repos","events_url":"https://api.github.com/users/edgework/events{/privacy}","received_events_url":"https://api.github.com/users/edgework/received_events","type":"User","site_admin":false},"body":"When getting a connection from a pool fails the ping test, the callback is never called. This fixes it.","created_at":"2014-05-29T19:56:50Z","updated_at":"2014-05-29T20:01:02Z","closed_at":"2014-05-29T20:01:02Z","merged_at":null,"merge_commit_sha":"11e56948bf9be2936d40b256a8e3bd24c3e94be6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/felixge/node-mysql/pulls/834/commits","review_comments_url":"https://api.github.com/repos/felixge/node-mysql/pulls/834/comments","review_comment_url":"https://api.github.com/repos/felixge/node-mysql/pulls/comments/{number}","comments_url":"https://api.github.com/repos/felixge/node-mysql/issues/834/comments","statuses_url":"https://api.github.com/repos/felixge/node-mysql/statuses/84594a4ac2d420eadba8c5d04c07dd5483abd605","head":{"label":"edgework:master","ref":"master","sha":"84594a4ac2d420eadba8c5d04c07dd5483abd605","user":{"login":"edgework","id":5122883,"avatar_url":"https://avatars.githubusercontent.com/u/5122883?","gravatar_id":"0c9c8f27d98e516acecfa23b07b1eb1d","url":"https://api.github.com/users/edgework","html_url":"https://github.com/edgework","followers_url":"https://api.github.com/users/edgework/followers","following_url":"https://api.github.com/users/edgework/following{/other_user}","gists_url":"https://api.github.com/users/edgework/gists{/gist_id}","starred_url":"https://api.github.com/users/edgework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgework/subscriptions","organizations_url":"https://api.github.com/users/edgework/orgs","repos_url":"https://api.github.com/users/edgework/repos","events_url":"https://api.github.com/users/edgework/events{/privacy}","received_events_url":"https://api.github.com/users/edgework/received_events","type":"User","site_admin":false},"repo":{"id":20306418,"name":"node-mysql","full_name":"edgework/node-mysql","owner":{"login":"edgework","id":5122883,"avatar_url":"https://avatars.githubusercontent.com/u/5122883?","gravatar_id":"0c9c8f27d98e516acecfa23b07b1eb1d","url":"https://api.github.com/users/edgework","html_url":"https://github.com/edgework","followers_url":"https://api.github.com/users/edgework/followers","following_url":"https://api.github.com/users/edgework/following{/other_user}","gists_url":"https://api.github.com/users/edgework/gists{/gist_id}","starred_url":"https://api.github.com/users/edgework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgework/subscriptions","organizations_url":"https://api.github.com/users/edgework/orgs","repos_url":"https://api.github.com/users/edgework/repos","events_url":"https://api.github.com/users/edgework/events{/privacy}","received_events_url":"https://api.github.com/users/edgework/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edgework/node-mysql","description":"A pure node.js JavaScript Client implementing the MySql protocol.","fork":true,"url":"https://api.github.com/repos/edgework/node-mysql","forks_url":"https://api.github.com/repos/edgework/node-mysql/forks","keys_url":"https://api.github.com/repos/edgework/node-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgework/node-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgework/node-mysql/teams","hooks_url":"https://api.github.com/repos/edgework/node-mysql/hooks","issue_events_url":"https://api.github.com/repos/edgework/node-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/edgework/node-mysql/events","assignees_url":"https://api.github.com/repos/edgework/node-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/edgework/node-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/edgework/node-mysql/tags","blobs_url":"https://api.github.com/repos/edgework/node-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgework/node-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgework/node-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgework/node-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgework/node-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/edgework/node-mysql/languages","stargazers_url":"https://api.github.com/repos/edgework/node-mysql/stargazers","contributors_url":"https://api.github.com/repos/edgework/node-mysql/contributors","subscribers_url":"https://api.github.com/repos/edgework/node-mysql/subscribers","subscription_url":"https://api.github.com/repos/edgework/node-mysql/subscription","commits_url":"https://api.github.com/repos/edgework/node-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgework/node-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgework/node-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgework/node-mysql/issues/comments/{number}","contents_url":"https://api.github.com/repos/edgework/node-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/edgework/node-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgework/node-mysql/merges","archive_url":"https://api.github.com/repos/edgework/node-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgework/node-mysql/downloads","issues_url":"https://api.github.com/repos/edgework/node-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/edgework/node-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/edgework/node-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/edgework/node-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgework/node-mysql/labels{/name}","releases_url":"https://api.github.com/repos/edgework/node-mysql/releases{/id}","created_at":"2014-05-29T19:52:17Z","updated_at":"2014-05-29T19:56:50Z","pushed_at":"2014-05-29T19:54:10Z","git_url":"git://github.com/edgework/node-mysql.git","ssh_url":"git@github.com:edgework/node-mysql.git","clone_url":"https://github.com/edgework/node-mysql.git","svn_url":"https://github.com/edgework/node-mysql","homepage":"","size":5405,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"felixge:master","ref":"master","sha":"e97cb18a72d83e50b49b4c3d1af00951c7db9578","user":{"login":"felixge","id":15000,"avatar_url":"https://avatars.githubusercontent.com/u/15000?","gravatar_id":"23968f0ca75b13463d2db5343e5c2096","url":"https://api.github.com/users/felixge","html_url":"https://github.com/felixge","followers_url":"https://api.github.com/users/felixge/followers","following_url":"https://api.github.com/users/felixge/following{/other_user}","gists_url":"https://api.github.com/users/felixge/gists{/gist_id}","starred_url":"https://api.github.com/users/felixge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixge/subscriptions","organizations_url":"https://api.github.com/users/felixge/orgs","repos_url":"https://api.github.com/users/felixge/repos","events_url":"https://api.github.com/users/felixge/events{/privacy}","received_events_url":"https://api.github.com/users/felixge/received_events","type":"User","site_admin":false},"repo":{"id":805461,"name":"node-mysql","full_name":"felixge/node-mysql","owner":{"login":"felixge","id":15000,"avatar_url":"https://avatars.githubusercontent.com/u/15000?","gravatar_id":"23968f0ca75b13463d2db5343e5c2096","url":"https://api.github.com/users/felixge","html_url":"https://github.com/felixge","followers_url":"https://api.github.com/users/felixge/followers","following_url":"https://api.github.com/users/felixge/following{/other_user}","gists_url":"https://api.github.com/users/felixge/gists{/gist_id}","starred_url":"https://api.github.com/users/felixge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixge/subscriptions","organizations_url":"https://api.github.com/users/felixge/orgs","repos_url":"https://api.github.com/users/felixge/repos","events_url":"https://api.github.com/users/felixge/events{/privacy}","received_events_url":"https://api.github.com/users/felixge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felixge/node-mysql","description":"A pure node.js JavaScript Client implementing the MySql protocol.","fork":false,"url":"https://api.github.com/repos/felixge/node-mysql","forks_url":"https://api.github.com/repos/felixge/node-mysql/forks","keys_url":"https://api.github.com/repos/felixge/node-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felixge/node-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felixge/node-mysql/teams","hooks_url":"https://api.github.com/repos/felixge/node-mysql/hooks","issue_events_url":"https://api.github.com/repos/felixge/node-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/felixge/node-mysql/events","assignees_url":"https://api.github.com/repos/felixge/node-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/felixge/node-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/felixge/node-mysql/tags","blobs_url":"https://api.github.com/repos/felixge/node-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felixge/node-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felixge/node-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/felixge/node-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felixge/node-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/felixge/node-mysql/languages","stargazers_url":"https://api.github.com/repos/felixge/node-mysql/stargazers","contributors_url":"https://api.github.com/repos/felixge/node-mysql/contributors","subscribers_url":"https://api.github.com/repos/felixge/node-mysql/subscribers","subscription_url":"https://api.github.com/repos/felixge/node-mysql/subscription","commits_url":"https://api.github.com/repos/felixge/node-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/felixge/node-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/felixge/node-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/felixge/node-mysql/issues/comments/{number}","contents_url":"https://api.github.com/repos/felixge/node-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/felixge/node-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felixge/node-mysql/merges","archive_url":"https://api.github.com/repos/felixge/node-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felixge/node-mysql/downloads","issues_url":"https://api.github.com/repos/felixge/node-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/felixge/node-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/felixge/node-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/felixge/node-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felixge/node-mysql/labels{/name}","releases_url":"https://api.github.com/repos/felixge/node-mysql/releases{/id}","created_at":"2010-07-29T14:58:13Z","updated_at":"2014-05-29T18:45:38Z","pushed_at":"2014-05-29T18:30:09Z","git_url":"git://github.com/felixge/node-mysql.git","ssh_url":"git@github.com:felixge/node-mysql.git","clone_url":"https://github.com/felixge/node-mysql.git","svn_url":"https://github.com/felixge/node-mysql","homepage":"","size":5405,"stargazers_count":3463,"watchers_count":3463,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":582,"mirror_url":null,"open_issues_count":42,"forks":582,"open_issues":42,"watchers":3463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/felixge/node-mysql/pulls/834"},"html":{"href":"https://github.com/felixge/node-mysql/pull/834"},"issue":{"href":"https://api.github.com/repos/felixge/node-mysql/issues/834"},"comments":{"href":"https://api.github.com/repos/felixge/node-mysql/issues/834/comments"},"review_comments":{"href":"https://api.github.com/repos/felixge/node-mysql/pulls/834/comments"},"review_comment":{"href":"https://api.github.com/repos/felixge/node-mysql/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/felixge/node-mysql/pulls/834/commits"},"statuses":{"href":"https://api.github.com/repos/felixge/node-mysql/statuses/84594a4ac2d420eadba8c5d04c07dd5483abd605"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":4,"deletions":1,"changed_files":1}}