GitHub PullRequestReviewCommentEvent at 2014-10-14 17:03:09
Repository: semian
Actor: camilo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/semian/pulls/comments/18842353","id":18842353,"diff_hunk":"@@ -74,6 +74,21 @@ Semian[:mysql_master].acquire do\n end\n ```\n \n+By default Semian circuit breaks on top of the `Semian::TimeoutError`, you can\n+tune it:\n+\n+```ruby\n+Semian.register(:mysql_master, timeout: 0.5, success_threshold: 2, error_threshold: 5, circuit_break_timeout: 20)","path":"README.md","position":8,"original_position":8,"commit_id":"257c28fcbfcb054d892eaa77af7efd0a0b78e131","original_commit_id":"257c28fcbfcb054d892eaa77af7efd0a0b78e131","user":{"login":"camilo","id":7748,"avatar_url":"https://avatars.githubusercontent.com/u/7748?v=2","gravatar_id":"","url":"https://api.github.com/users/camilo","html_url":"https://github.com/camilo","followers_url":"https://api.github.com/users/camilo/followers","following_url":"https://api.github.com/users/camilo/following{/other_user}","gists_url":"https://api.github.com/users/camilo/gists{/gist_id}","starred_url":"https://api.github.com/users/camilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camilo/subscriptions","organizations_url":"https://api.github.com/users/camilo/orgs","repos_url":"https://api.github.com/users/camilo/repos","events_url":"https://api.github.com/users/camilo/events{/privacy}","received_events_url":"https://api.github.com/users/camilo/received_events","type":"User","site_admin":false},"body":"has the err/success threshold been explained somewhere else?  ","created_at":"2014-10-14T17:03:09Z","updated_at":"2014-10-14T17:03:09Z","html_url":"https://github.com/Shopify/semian/pull/5#discussion_r18842353","pull_request_url":"https://api.github.com/repos/Shopify/semian/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/Shopify/semian/pulls/comments/18842353"},"html":{"href":"https://github.com/Shopify/semian/pull/5#discussion_r18842353"},"pull_request":{"href":"https://api.github.com/repos/Shopify/semian/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/semian/pulls/5","id":22725626,"html_url":"https://github.com/Shopify/semian/pull/5","diff_url":"https://github.com/Shopify/semian/pull/5.diff","patch_url":"https://github.com/Shopify/semian/pull/5.patch","issue_url":"https://api.github.com/repos/Shopify/semian/issues/5","number":5,"state":"open","locked":false,"title":"readme: add documentation for CB","user":{"login":"Sirupsen","id":97400,"avatar_url":"https://avatars.githubusercontent.com/u/97400?v=2","gravatar_id":"","url":"https://api.github.com/users/Sirupsen","html_url":"https://github.com/Sirupsen","followers_url":"https://api.github.com/users/Sirupsen/followers","following_url":"https://api.github.com/users/Sirupsen/following{/other_user}","gists_url":"https://api.github.com/users/Sirupsen/gists{/gist_id}","starred_url":"https://api.github.com/users/Sirupsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sirupsen/subscriptions","organizations_url":"https://api.github.com/users/Sirupsen/orgs","repos_url":"https://api.github.com/users/Sirupsen/repos","events_url":"https://api.github.com/users/Sirupsen/events{/privacy}","received_events_url":"https://api.github.com/users/Sirupsen/received_events","type":"User","site_admin":false},"body":"This is how I envision this would work based on our discussion. \r\n\r\n@csfrancis @camilo thoughts?","created_at":"2014-10-14T16:47:45Z","updated_at":"2014-10-14T17:03:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"220a171217123b08327d86823325da2c866b8427","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/semian/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Shopify/semian/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Shopify/semian/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Shopify/semian/issues/5/comments","statuses_url":"https://api.github.com/repos/Shopify/semian/statuses/257c28fcbfcb054d892eaa77af7efd0a0b78e131","head":{"label":"Shopify:cb-docs","ref":"cb-docs","sha":"257c28fcbfcb054d892eaa77af7efd0a0b78e131","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=2","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":24375548,"name":"semian","full_name":"Shopify/semian","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=2","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/semian","description":null,"fork":false,"url":"https://api.github.com/repos/Shopify/semian","forks_url":"https://api.github.com/repos/Shopify/semian/forks","keys_url":"https://api.github.com/repos/Shopify/semian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/semian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/semian/teams","hooks_url":"https://api.github.com/repos/Shopify/semian/hooks","issue_events_url":"https://api.github.com/repos/Shopify/semian/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/semian/events","assignees_url":"https://api.github.com/repos/Shopify/semian/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/semian/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/semian/tags","blobs_url":"https://api.github.com/repos/Shopify/semian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/semian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/semian/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/semian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/semian/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/semian/languages","stargazers_url":"https://api.github.com/repos/Shopify/semian/stargazers","contributors_url":"https://api.github.com/repos/Shopify/semian/contributors","subscribers_url":"https://api.github.com/repos/Shopify/semian/subscribers","subscription_url":"https://api.github.com/repos/Shopify/semian/subscription","commits_url":"https://api.github.com/repos/Shopify/semian/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/semian/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/semian/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/semian/issues/comments/{number}","contents_url":"https://api.github.com/repos/Shopify/semian/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/semian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/semian/merges","archive_url":"https://api.github.com/repos/Shopify/semian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/semian/downloads","issues_url":"https://api.github.com/repos/Shopify/semian/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/semian/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/semian/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/semian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/semian/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/semian/releases{/id}","created_at":"2014-09-23T14:47:19Z","updated_at":"2014-10-14T14:17:02Z","pushed_at":"2014-10-14T16:47:13Z","git_url":"git://github.com/Shopify/semian.git","ssh_url":"git@github.com:Shopify/semian.git","clone_url":"https://github.com/Shopify/semian.git","svn_url":"https://github.com/Shopify/semian","homepage":null,"size":351,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":13,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"d82223aaa7a16db4717f942c997e46ee75a799f2","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=2","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":24375548,"name":"semian","full_name":"Shopify/semian","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=2","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/semian","description":null,"fork":false,"url":"https://api.github.com/repos/Shopify/semian","forks_url":"https://api.github.com/repos/Shopify/semian/forks","keys_url":"https://api.github.com/repos/Shopify/semian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/semian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/semian/teams","hooks_url":"https://api.github.com/repos/Shopify/semian/hooks","issue_events_url":"https://api.github.com/repos/Shopify/semian/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/semian/events","assignees_url":"https://api.github.com/repos/Shopify/semian/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/semian/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/semian/tags","blobs_url":"https://api.github.com/repos/Shopify/semian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/semian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/semian/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/semian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/semian/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/semian/languages","stargazers_url":"https://api.github.com/repos/Shopify/semian/stargazers","contributors_url":"https://api.github.com/repos/Shopify/semian/contributors","subscribers_url":"https://api.github.com/repos/Shopify/semian/subscribers","subscription_url":"https://api.github.com/repos/Shopify/semian/subscription","commits_url":"https://api.github.com/repos/Shopify/semian/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/semian/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/semian/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/semian/issues/comments/{number}","contents_url":"https://api.github.com/repos/Shopify/semian/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/semian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/semian/merges","archive_url":"https://api.github.com/repos/Shopify/semian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/semian/downloads","issues_url":"https://api.github.com/repos/Shopify/semian/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/semian/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/semian/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/semian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/semian/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/semian/releases{/id}","created_at":"2014-09-23T14:47:19Z","updated_at":"2014-10-14T14:17:02Z","pushed_at":"2014-10-14T16:47:13Z","git_url":"git://github.com/Shopify/semian.git","ssh_url":"git@github.com:Shopify/semian.git","clone_url":"https://github.com/Shopify/semian.git","svn_url":"https://github.com/Shopify/semian","homepage":null,"size":351,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/semian/pulls/5"},"html":{"href":"https://github.com/Shopify/semian/pull/5"},"issue":{"href":"https://api.github.com/repos/Shopify/semian/issues/5"},"comments":{"href":"https://api.github.com/repos/Shopify/semian/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/semian/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/semian/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Shopify/semian/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/semian/statuses/257c28fcbfcb054d892eaa77af7efd0a0b78e131"}}}}