GitHub PullRequestReviewCommentEvent at 2014-09-25 23:25:44
Repository: go-systemd
Actor: bcwaldon
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/go-systemd/pulls/comments/18066797","id":18066797,"diff_hunk":"@@ -74,50 +76,54 @@ func (c *Conn) runJob(job string, args ...interface{}) (string, error) {\n // requirement dependencies. It is not recommended to make use of the latter\n // two options.\n //\n-// Result string: one of done, canceled, timeout, failed, dependency, skipped.\n+// If the provided channel is non-nil, a result string will be sent to it upon\n+// job completion: one of done, canceled, timeout, failed, dependency, skipped.\n // done indicates successful execution of a job. canceled indicates that a job\n // has been canceled  before it finished execution. timeout indicates that the\n // job timeout was reached. failed indicates that the job failed. dependency\n // indicates that a job this job has been depending on failed and the job hence\n // has been removed too. skipped indicates that a job was skipped because it\n // didn't apply to the units current state.\n-func (c *Conn) StartUnit(name string, mode string) (string, error) {\n-\treturn c.runJob(\"org.freedesktop.systemd1.Manager.StartUnit\", name, mode)\n+//\n+// If no error occurs, the ID of the underlying systemd job will be returned. If\n+// an error does occur, it will be returned to the user alongside a job ID of 0.","path":"dbus/methods.go","position":68,"original_position":68,"commit_id":"337fd0d592b74ccce40f70a189800fca672083dd","original_commit_id":"337fd0d592b74ccce40f70a189800fca672083dd","user":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=2","gravatar_id":"","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"body":"Sure.","created_at":"2014-09-25T23:25:44Z","updated_at":"2014-09-25T23:25:44Z","html_url":"https://github.com/coreos/go-systemd/pull/65#discussion_r18066797","pull_request_url":"https://api.github.com/repos/coreos/go-systemd/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/comments/18066797"},"html":{"href":"https://github.com/coreos/go-systemd/pull/65#discussion_r18066797"},"pull_request":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/go-systemd/pulls/65","id":21800760,"html_url":"https://github.com/coreos/go-systemd/pull/65","diff_url":"https://github.com/coreos/go-systemd/pull/65.diff","patch_url":"https://github.com/coreos/go-systemd/pull/65.patch","issue_url":"https://api.github.com/repos/coreos/go-systemd/issues/65","number":65,"state":"open","locked":false,"title":"dbus: methods return chan, do not block","user":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=2","gravatar_id":"","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"body":"Allow callers to ignore the result of jobs corresponding to unit methods by returning the response channel. Doing this allows fleet to stop caring about the result of jobs and work around https://github.com/coreos/fleet/issues/903.","created_at":"2014-09-25T18:00:24Z","updated_at":"2014-09-25T23:25:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff206f0e483cc2107020a769819da4f026369954","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/go-systemd/pulls/65/commits","review_comments_url":"https://api.github.com/repos/coreos/go-systemd/pulls/65/comments","review_comment_url":"https://api.github.com/repos/coreos/go-systemd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/coreos/go-systemd/issues/65/comments","statuses_url":"https://api.github.com/repos/coreos/go-systemd/statuses/337fd0d592b74ccce40f70a189800fca672083dd","head":{"label":"bcwaldon:async-jobs","ref":"async-jobs","sha":"337fd0d592b74ccce40f70a189800fca672083dd","user":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=2","gravatar_id":"","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"repo":{"id":14316494,"name":"go-systemd","full_name":"bcwaldon/go-systemd","owner":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=2","gravatar_id":"","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcwaldon/go-systemd","description":"Go bindings to systemd socket activation, journal and D-BUS","fork":true,"url":"https://api.github.com/repos/bcwaldon/go-systemd","forks_url":"https://api.github.com/repos/bcwaldon/go-systemd/forks","keys_url":"https://api.github.com/repos/bcwaldon/go-systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcwaldon/go-systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcwaldon/go-systemd/teams","hooks_url":"https://api.github.com/repos/bcwaldon/go-systemd/hooks","issue_events_url":"https://api.github.com/repos/bcwaldon/go-systemd/issues/events{/number}","events_url":"https://api.github.com/repos/bcwaldon/go-systemd/events","assignees_url":"https://api.github.com/repos/bcwaldon/go-systemd/assignees{/user}","branches_url":"https://api.github.com/repos/bcwaldon/go-systemd/branches{/branch}","tags_url":"https://api.github.com/repos/bcwaldon/go-systemd/tags","blobs_url":"https://api.github.com/repos/bcwaldon/go-systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcwaldon/go-systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcwaldon/go-systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcwaldon/go-systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcwaldon/go-systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/bcwaldon/go-systemd/languages","stargazers_url":"https://api.github.com/repos/bcwaldon/go-systemd/stargazers","contributors_url":"https://api.github.com/repos/bcwaldon/go-systemd/contributors","subscribers_url":"https://api.github.com/repos/bcwaldon/go-systemd/subscribers","subscription_url":"https://api.github.com/repos/bcwaldon/go-systemd/subscription","commits_url":"https://api.github.com/repos/bcwaldon/go-systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcwaldon/go-systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcwaldon/go-systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcwaldon/go-systemd/issues/comments/{number}","contents_url":"https://api.github.com/repos/bcwaldon/go-systemd/contents/{+path}","compare_url":"https://api.github.com/repos/bcwaldon/go-systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcwaldon/go-systemd/merges","archive_url":"https://api.github.com/repos/bcwaldon/go-systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcwaldon/go-systemd/downloads","issues_url":"https://api.github.com/repos/bcwaldon/go-systemd/issues{/number}","pulls_url":"https://api.github.com/repos/bcwaldon/go-systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/bcwaldon/go-systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/bcwaldon/go-systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcwaldon/go-systemd/labels{/name}","releases_url":"https://api.github.com/repos/bcwaldon/go-systemd/releases{/id}","created_at":"2013-11-11T23:20:23Z","updated_at":"2014-05-03T19:37:41Z","pushed_at":"2014-09-25T22:22:56Z","git_url":"git://github.com/bcwaldon/go-systemd.git","ssh_url":"git@github.com:bcwaldon/go-systemd.git","clone_url":"https://github.com/bcwaldon/go-systemd.git","svn_url":"https://github.com/bcwaldon/go-systemd","homepage":"","size":493,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"7a81740665de3d730bf98811f6b2ae5746e42a32","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=2","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":12821303,"name":"go-systemd","full_name":"coreos/go-systemd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=2","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/go-systemd","description":"Go bindings to systemd socket activation, journal and D-BUS","fork":false,"url":"https://api.github.com/repos/coreos/go-systemd","forks_url":"https://api.github.com/repos/coreos/go-systemd/forks","keys_url":"https://api.github.com/repos/coreos/go-systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/go-systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/go-systemd/teams","hooks_url":"https://api.github.com/repos/coreos/go-systemd/hooks","issue_events_url":"https://api.github.com/repos/coreos/go-systemd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/go-systemd/events","assignees_url":"https://api.github.com/repos/coreos/go-systemd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/go-systemd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/go-systemd/tags","blobs_url":"https://api.github.com/repos/coreos/go-systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/go-systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/go-systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/go-systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/go-systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/go-systemd/languages","stargazers_url":"https://api.github.com/repos/coreos/go-systemd/stargazers","contributors_url":"https://api.github.com/repos/coreos/go-systemd/contributors","subscribers_url":"https://api.github.com/repos/coreos/go-systemd/subscribers","subscription_url":"https://api.github.com/repos/coreos/go-systemd/subscription","commits_url":"https://api.github.com/repos/coreos/go-systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/go-systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/go-systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/go-systemd/issues/comments/{number}","contents_url":"https://api.github.com/repos/coreos/go-systemd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/go-systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/go-systemd/merges","archive_url":"https://api.github.com/repos/coreos/go-systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/go-systemd/downloads","issues_url":"https://api.github.com/repos/coreos/go-systemd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/go-systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/go-systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/go-systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/go-systemd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/go-systemd/releases{/id}","created_at":"2013-09-13T23:13:51Z","updated_at":"2014-09-20T10:09:37Z","pushed_at":"2014-09-17T17:15:43Z","git_url":"git://github.com/coreos/go-systemd.git","ssh_url":"git@github.com:coreos/go-systemd.git","clone_url":"https://github.com/coreos/go-systemd.git","svn_url":"https://github.com/coreos/go-systemd","homepage":"","size":1403,"stargazers_count":96,"watchers_count":96,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":6,"forks":34,"open_issues":6,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/65"},"html":{"href":"https://github.com/coreos/go-systemd/pull/65"},"issue":{"href":"https://api.github.com/repos/coreos/go-systemd/issues/65"},"comments":{"href":"https://api.github.com/repos/coreos/go-systemd/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/coreos/go-systemd/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/go-systemd/statuses/337fd0d592b74ccce40f70a189800fca672083dd"}}}}