GitHub PullRequestReviewCommentEvent at 2014-09-10 19:52:07
Repository: cp
Actor: mauriciopasquier
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/lainventoria/cp/pulls/comments/17384307","id":17384307,"diff_hunk":"@@ -0,0 +1,63 @@\n+# encoding: utf-8\n+require './test/test_helper'\n+\n+feature 'Vistas minimas' do\n+  background do\n+    @obra =  create :obra\n+  end\n+\n+  scenario 'Se lista la obra' do\n+    visit obras_path\n+\n+    page.must_have_content @obra.nombre\n+  end\n+\n+  scenario 'Se puede acceder a vista detallada' do\n+    visit obra_path(@obra)\n+\n+    find('input#obra_nombre').value.must_equal @obra.nombre\n+    find('input#obra_direccion').value.must_equal @obra.direccion\n+    page.must_have_link 'Listar Obras', obras_path\n+    page.must_have_link 'Editar Obra', edit_obra_path(@obra)\n+  end\n+\n+  scenario 'Widgets en vista detallada' do\n+    visit obra_path(@obra)\n+\n+    page.must_have_content 'Situacion Economica'\n+    page.must_have_content 'Situacion Financiera'","path":"test/integration/obras/vistas_test.rb","position":28,"original_position":28,"commit_id":"051042c0003db9a4a71122455768cd69351e8288","original_commit_id":"051042c0003db9a4a71122455768cd69351e8288","user":{"login":"mauriciopasquier","id":142792,"avatar_url":"https://avatars.githubusercontent.com/u/142792?v=2","gravatar_id":"544829d129e61a639d313d9165eb5570","url":"https://api.github.com/users/mauriciopasquier","html_url":"https://github.com/mauriciopasquier","followers_url":"https://api.github.com/users/mauriciopasquier/followers","following_url":"https://api.github.com/users/mauriciopasquier/following{/other_user}","gists_url":"https://api.github.com/users/mauriciopasquier/gists{/gist_id}","starred_url":"https://api.github.com/users/mauriciopasquier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauriciopasquier/subscriptions","organizations_url":"https://api.github.com/users/mauriciopasquier/orgs","repos_url":"https://api.github.com/users/mauriciopasquier/repos","events_url":"https://api.github.com/users/mauriciopasquier/events{/privacy}","received_events_url":"https://api.github.com/users/mauriciopasquier/received_events","type":"User","site_admin":false},"body":"+1 a escribir con tildes, ver que falla el test y corregir el código, en vez de hacer el test mal para que pase el código sin tildes :P ","created_at":"2014-09-10T19:52:07Z","updated_at":"2014-09-10T19:52:07Z","html_url":"https://github.com/lainventoria/cp/pull/348#discussion_r17384307","pull_request_url":"https://api.github.com/repos/lainventoria/cp/pulls/348","_links":{"self":{"href":"https://api.github.com/repos/lainventoria/cp/pulls/comments/17384307"},"html":{"href":"https://github.com/lainventoria/cp/pull/348#discussion_r17384307"},"pull_request":{"href":"https://api.github.com/repos/lainventoria/cp/pulls/348"}}},"pull_request":{"url":"https://api.github.com/repos/lainventoria/cp/pulls/348","id":21041805,"html_url":"https://github.com/lainventoria/cp/pull/348","diff_url":"https://github.com/lainventoria/cp/pull/348.diff","patch_url":"https://github.com/lainventoria/cp/pull/348.patch","issue_url":"https://api.github.com/repos/lainventoria/cp/issues/348","number":348,"state":"open","locked":false,"title":"test de integracion de obras","user":{"login":"m4tu5","id":5273876,"avatar_url":"https://avatars.githubusercontent.com/u/5273876?v=2","gravatar_id":"50af919f3122f59bd9fb972769bbeb46","url":"https://api.github.com/users/m4tu5","html_url":"https://github.com/m4tu5","followers_url":"https://api.github.com/users/m4tu5/followers","following_url":"https://api.github.com/users/m4tu5/following{/other_user}","gists_url":"https://api.github.com/users/m4tu5/gists{/gist_id}","starred_url":"https://api.github.com/users/m4tu5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4tu5/subscriptions","organizations_url":"https://api.github.com/users/m4tu5/orgs","repos_url":"https://api.github.com/users/m4tu5/repos","events_url":"https://api.github.com/users/m4tu5/events{/privacy}","received_events_url":"https://api.github.com/users/m4tu5/received_events","type":"User","site_admin":false},"body":"* crea una nueva obra\r\n* edita una obra existente\r\n* verifica las vistas de obras\r\n    * listado de obras\r\n    * detalle de obra y widgets\r\n    * listado de cajas asociadas","created_at":"2014-09-10T18:54:20Z","updated_at":"2014-09-10T19:52:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb47da527f74c3683d616bf471d42e57154399d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lainventoria/cp/pulls/348/commits","review_comments_url":"https://api.github.com/repos/lainventoria/cp/pulls/348/comments","review_comment_url":"https://api.github.com/repos/lainventoria/cp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lainventoria/cp/issues/348/comments","statuses_url":"https://api.github.com/repos/lainventoria/cp/statuses/051042c0003db9a4a71122455768cd69351e8288","head":{"label":"lainventoria:feature/integracion-obras","ref":"feature/integracion-obras","sha":"051042c0003db9a4a71122455768cd69351e8288","user":{"login":"lainventoria","id":2395596,"avatar_url":"https://avatars.githubusercontent.com/u/2395596?v=2","gravatar_id":"8bfea8695bca1fe7d005261b6a22b77a","url":"https://api.github.com/users/lainventoria","html_url":"https://github.com/lainventoria","followers_url":"https://api.github.com/users/lainventoria/followers","following_url":"https://api.github.com/users/lainventoria/following{/other_user}","gists_url":"https://api.github.com/users/lainventoria/gists{/gist_id}","starred_url":"https://api.github.com/users/lainventoria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lainventoria/subscriptions","organizations_url":"https://api.github.com/users/lainventoria/orgs","repos_url":"https://api.github.com/users/lainventoria/repos","events_url":"https://api.github.com/users/lainventoria/events{/privacy}","received_events_url":"https://api.github.com/users/lainventoria/received_events","type":"Organization","site_admin":false},"repo":{"id":15752293,"name":"cp","full_name":"lainventoria/cp","owner":{"login":"lainventoria","id":2395596,"avatar_url":"https://avatars.githubusercontent.com/u/2395596?v=2","gravatar_id":"8bfea8695bca1fe7d005261b6a22b77a","url":"https://api.github.com/users/lainventoria","html_url":"https://github.com/lainventoria","followers_url":"https://api.github.com/users/lainventoria/followers","following_url":"https://api.github.com/users/lainventoria/following{/other_user}","gists_url":"https://api.github.com/users/lainventoria/gists{/gist_id}","starred_url":"https://api.github.com/users/lainventoria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lainventoria/subscriptions","organizations_url":"https://api.github.com/users/lainventoria/orgs","repos_url":"https://api.github.com/users/lainventoria/repos","events_url":"https://api.github.com/users/lainventoria/events{/privacy}","received_events_url":"https://api.github.com/users/lainventoria/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lainventoria/cp","description":"Sistema de Gestión de Obras","fork":false,"url":"https://api.github.com/repos/lainventoria/cp","forks_url":"https://api.github.com/repos/lainventoria/cp/forks","keys_url":"https://api.github.com/repos/lainventoria/cp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lainventoria/cp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lainventoria/cp/teams","hooks_url":"https://api.github.com/repos/lainventoria/cp/hooks","issue_events_url":"https://api.github.com/repos/lainventoria/cp/issues/events{/number}","events_url":"https://api.github.com/repos/lainventoria/cp/events","assignees_url":"https://api.github.com/repos/lainventoria/cp/assignees{/user}","branches_url":"https://api.github.com/repos/lainventoria/cp/branches{/branch}","tags_url":"https://api.github.com/repos/lainventoria/cp/tags","blobs_url":"https://api.github.com/repos/lainventoria/cp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lainventoria/cp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lainventoria/cp/git/refs{/sha}","trees_url":"https://api.github.com/repos/lainventoria/cp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lainventoria/cp/statuses/{sha}","languages_url":"https://api.github.com/repos/lainventoria/cp/languages","stargazers_url":"https://api.github.com/repos/lainventoria/cp/stargazers","contributors_url":"https://api.github.com/repos/lainventoria/cp/contributors","subscribers_url":"https://api.github.com/repos/lainventoria/cp/subscribers","subscription_url":"https://api.github.com/repos/lainventoria/cp/subscription","commits_url":"https://api.github.com/repos/lainventoria/cp/commits{/sha}","git_commits_url":"https://api.github.com/repos/lainventoria/cp/git/commits{/sha}","comments_url":"https://api.github.com/repos/lainventoria/cp/comments{/number}","issue_comment_url":"https://api.github.com/repos/lainventoria/cp/issues/comments/{number}","contents_url":"https://api.github.com/repos/lainventoria/cp/contents/{+path}","compare_url":"https://api.github.com/repos/lainventoria/cp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lainventoria/cp/merges","archive_url":"https://api.github.com/repos/lainventoria/cp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lainventoria/cp/downloads","issues_url":"https://api.github.com/repos/lainventoria/cp/issues{/number}","pulls_url":"https://api.github.com/repos/lainventoria/cp/pulls{/number}","milestones_url":"https://api.github.com/repos/lainventoria/cp/milestones{/number}","notifications_url":"https://api.github.com/repos/lainventoria/cp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lainventoria/cp/labels{/name}","releases_url":"https://api.github.com/repos/lainventoria/cp/releases{/id}","created_at":"2014-01-09T00:19:38Z","updated_at":"2014-09-02T10:56:55Z","pushed_at":"2014-09-10T19:26:37Z","git_url":"git://github.com/lainventoria/cp.git","ssh_url":"git@github.com:lainventoria/cp.git","clone_url":"https://github.com/lainventoria/cp.git","svn_url":"https://github.com/lainventoria/cp","homepage":null,"size":9284,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":24,"forks":0,"open_issues":24,"watchers":2,"default_branch":"develop"}},"base":{"label":"lainventoria:develop","ref":"develop","sha":"80ccf12e345ac257d89ad6d009a26f7e825699ec","user":{"login":"lainventoria","id":2395596,"avatar_url":"https://avatars.githubusercontent.com/u/2395596?v=2","gravatar_id":"8bfea8695bca1fe7d005261b6a22b77a","url":"https://api.github.com/users/lainventoria","html_url":"https://github.com/lainventoria","followers_url":"https://api.github.com/users/lainventoria/followers","following_url":"https://api.github.com/users/lainventoria/following{/other_user}","gists_url":"https://api.github.com/users/lainventoria/gists{/gist_id}","starred_url":"https://api.github.com/users/lainventoria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lainventoria/subscriptions","organizations_url":"https://api.github.com/users/lainventoria/orgs","repos_url":"https://api.github.com/users/lainventoria/repos","events_url":"https://api.github.com/users/lainventoria/events{/privacy}","received_events_url":"https://api.github.com/users/lainventoria/received_events","type":"Organization","site_admin":false},"repo":{"id":15752293,"name":"cp","full_name":"lainventoria/cp","owner":{"login":"lainventoria","id":2395596,"avatar_url":"https://avatars.githubusercontent.com/u/2395596?v=2","gravatar_id":"8bfea8695bca1fe7d005261b6a22b77a","url":"https://api.github.com/users/lainventoria","html_url":"https://github.com/lainventoria","followers_url":"https://api.github.com/users/lainventoria/followers","following_url":"https://api.github.com/users/lainventoria/following{/other_user}","gists_url":"https://api.github.com/users/lainventoria/gists{/gist_id}","starred_url":"https://api.github.com/users/lainventoria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lainventoria/subscriptions","organizations_url":"https://api.github.com/users/lainventoria/orgs","repos_url":"https://api.github.com/users/lainventoria/repos","events_url":"https://api.github.com/users/lainventoria/events{/privacy}","received_events_url":"https://api.github.com/users/lainventoria/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lainventoria/cp","description":"Sistema de Gestión de Obras","fork":false,"url":"https://api.github.com/repos/lainventoria/cp","forks_url":"https://api.github.com/repos/lainventoria/cp/forks","keys_url":"https://api.github.com/repos/lainventoria/cp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lainventoria/cp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lainventoria/cp/teams","hooks_url":"https://api.github.com/repos/lainventoria/cp/hooks","issue_events_url":"https://api.github.com/repos/lainventoria/cp/issues/events{/number}","events_url":"https://api.github.com/repos/lainventoria/cp/events","assignees_url":"https://api.github.com/repos/lainventoria/cp/assignees{/user}","branches_url":"https://api.github.com/repos/lainventoria/cp/branches{/branch}","tags_url":"https://api.github.com/repos/lainventoria/cp/tags","blobs_url":"https://api.github.com/repos/lainventoria/cp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lainventoria/cp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lainventoria/cp/git/refs{/sha}","trees_url":"https://api.github.com/repos/lainventoria/cp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lainventoria/cp/statuses/{sha}","languages_url":"https://api.github.com/repos/lainventoria/cp/languages","stargazers_url":"https://api.github.com/repos/lainventoria/cp/stargazers","contributors_url":"https://api.github.com/repos/lainventoria/cp/contributors","subscribers_url":"https://api.github.com/repos/lainventoria/cp/subscribers","subscription_url":"https://api.github.com/repos/lainventoria/cp/subscription","commits_url":"https://api.github.com/repos/lainventoria/cp/commits{/sha}","git_commits_url":"https://api.github.com/repos/lainventoria/cp/git/commits{/sha}","comments_url":"https://api.github.com/repos/lainventoria/cp/comments{/number}","issue_comment_url":"https://api.github.com/repos/lainventoria/cp/issues/comments/{number}","contents_url":"https://api.github.com/repos/lainventoria/cp/contents/{+path}","compare_url":"https://api.github.com/repos/lainventoria/cp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lainventoria/cp/merges","archive_url":"https://api.github.com/repos/lainventoria/cp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lainventoria/cp/downloads","issues_url":"https://api.github.com/repos/lainventoria/cp/issues{/number}","pulls_url":"https://api.github.com/repos/lainventoria/cp/pulls{/number}","milestones_url":"https://api.github.com/repos/lainventoria/cp/milestones{/number}","notifications_url":"https://api.github.com/repos/lainventoria/cp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lainventoria/cp/labels{/name}","releases_url":"https://api.github.com/repos/lainventoria/cp/releases{/id}","created_at":"2014-01-09T00:19:38Z","updated_at":"2014-09-02T10:56:55Z","pushed_at":"2014-09-10T19:26:37Z","git_url":"git://github.com/lainventoria/cp.git","ssh_url":"git@github.com:lainventoria/cp.git","clone_url":"https://github.com/lainventoria/cp.git","svn_url":"https://github.com/lainventoria/cp","homepage":null,"size":9284,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":24,"forks":0,"open_issues":24,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/lainventoria/cp/pulls/348"},"html":{"href":"https://github.com/lainventoria/cp/pull/348"},"issue":{"href":"https://api.github.com/repos/lainventoria/cp/issues/348"},"comments":{"href":"https://api.github.com/repos/lainventoria/cp/issues/348/comments"},"review_comments":{"href":"https://api.github.com/repos/lainventoria/cp/pulls/348/comments"},"review_comment":{"href":"https://api.github.com/repos/lainventoria/cp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lainventoria/cp/pulls/348/commits"},"statuses":{"href":"https://api.github.com/repos/lainventoria/cp/statuses/051042c0003db9a4a71122455768cd69351e8288"}}}}