GitHub PullRequestEvent at 2014-07-08 09:03:45
Repository: h
Actor: gergely-ujvari
Payload: {"action":"closed","number":1288,"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/1288","id":18079038,"html_url":"https://github.com/hypothesis/h/pull/1288","diff_url":"https://github.com/hypothesis/h/pull/1288.diff","patch_url":"https://github.com/hypothesis/h/pull/1288.patch","issue_url":"https://api.github.com/repos/hypothesis/h/issues/1288","number":1288,"state":"closed","title":"Use $route.reload() instead of refresh events","user":{"login":"tilgovi","id":20818,"avatar_url":"https://avatars.githubusercontent.com/u/20818?","gravatar_id":"097005ba3431bda404fcc27976aa3150","url":"https://api.github.com/users/tilgovi","html_url":"https://github.com/tilgovi","followers_url":"https://api.github.com/users/tilgovi/followers","following_url":"https://api.github.com/users/tilgovi/following{/other_user}","gists_url":"https://api.github.com/users/tilgovi/gists{/gist_id}","starred_url":"https://api.github.com/users/tilgovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilgovi/subscriptions","organizations_url":"https://api.github.com/users/tilgovi/orgs","repos_url":"https://api.github.com/users/tilgovi/repos","events_url":"https://api.github.com/users/tilgovi/events{/privacy}","received_events_url":"https://api.github.com/users/tilgovi/received_events","type":"User","site_admin":false},"body":"Rather than using extra events to trigger a round trip through the\r\nvisual search directive callbacks and query parsing, simply rely on\r\n$location.search() at the time the route controller is instantiated\r\nand stop using `reloadOnSearch: false` in the route definitions so\r\nthat changes to the search trigger a refresh of the view.\r\n\r\nThe QueryParser now splits `populateFilter` into `parseModels` and\r\n`populateFilter` so that the models can be parsed when the visual\r\nsearch callback fires and the filter can be populated separately\r\nfrom the query string after the route reload.\r\n\r\nSummary of improvements:\r\n\r\n- Drop the VSSearch and RefreshSearch events.\r\n- Make the search.query scope property a simple value instead of a\r\n  function. This reduces the work required for the watcher and is\r\n  possible because we no longer update the query string unless the\r\n  query changes and the route will reload if it does.\r\n- Clearing the stream is no longer necessary, since it starts clear\r\n  on each route reload.","created_at":"2014-07-08T01:34:59Z","updated_at":"2014-07-08T09:03:45Z","closed_at":"2014-07-08T09:03:45Z","merged_at":"2014-07-08T09:03:45Z","merge_commit_sha":"1ad49f3688cc1f64c76ab6117f99e92e4caaf11d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hypothesis/h/pulls/1288/commits","review_comments_url":"https://api.github.com/repos/hypothesis/h/pulls/1288/comments","review_comment_url":"https://api.github.com/repos/hypothesis/h/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/1288/comments","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/5f43a3dc53d0f0f5b9d5b94ab123bf4ba2ccf8fb","head":{"label":"tilgovi:stream-search-refactor","ref":"stream-search-refactor","sha":"5f43a3dc53d0f0f5b9d5b94ab123bf4ba2ccf8fb","user":{"login":"tilgovi","id":20818,"avatar_url":"https://avatars.githubusercontent.com/u/20818?","gravatar_id":"097005ba3431bda404fcc27976aa3150","url":"https://api.github.com/users/tilgovi","html_url":"https://github.com/tilgovi","followers_url":"https://api.github.com/users/tilgovi/followers","following_url":"https://api.github.com/users/tilgovi/following{/other_user}","gists_url":"https://api.github.com/users/tilgovi/gists{/gist_id}","starred_url":"https://api.github.com/users/tilgovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilgovi/subscriptions","organizations_url":"https://api.github.com/users/tilgovi/orgs","repos_url":"https://api.github.com/users/tilgovi/repos","events_url":"https://api.github.com/users/tilgovi/events{/privacy}","received_events_url":"https://api.github.com/users/tilgovi/received_events","type":"User","site_admin":false},"repo":{"id":4641842,"name":"h","full_name":"tilgovi/h","owner":{"login":"tilgovi","id":20818,"avatar_url":"https://avatars.githubusercontent.com/u/20818?","gravatar_id":"097005ba3431bda404fcc27976aa3150","url":"https://api.github.com/users/tilgovi","html_url":"https://github.com/tilgovi","followers_url":"https://api.github.com/users/tilgovi/followers","following_url":"https://api.github.com/users/tilgovi/following{/other_user}","gists_url":"https://api.github.com/users/tilgovi/gists{/gist_id}","starred_url":"https://api.github.com/users/tilgovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilgovi/subscriptions","organizations_url":"https://api.github.com/users/tilgovi/orgs","repos_url":"https://api.github.com/users/tilgovi/repos","events_url":"https://api.github.com/users/tilgovi/events{/privacy}","received_events_url":"https://api.github.com/users/tilgovi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tilgovi/h","description":"The Internet, peer reviewed.","fork":true,"url":"https://api.github.com/repos/tilgovi/h","forks_url":"https://api.github.com/repos/tilgovi/h/forks","keys_url":"https://api.github.com/repos/tilgovi/h/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tilgovi/h/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tilgovi/h/teams","hooks_url":"https://api.github.com/repos/tilgovi/h/hooks","issue_events_url":"https://api.github.com/repos/tilgovi/h/issues/events{/number}","events_url":"https://api.github.com/repos/tilgovi/h/events","assignees_url":"https://api.github.com/repos/tilgovi/h/assignees{/user}","branches_url":"https://api.github.com/repos/tilgovi/h/branches{/branch}","tags_url":"https://api.github.com/repos/tilgovi/h/tags","blobs_url":"https://api.github.com/repos/tilgovi/h/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tilgovi/h/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tilgovi/h/git/refs{/sha}","trees_url":"https://api.github.com/repos/tilgovi/h/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tilgovi/h/statuses/{sha}","languages_url":"https://api.github.com/repos/tilgovi/h/languages","stargazers_url":"https://api.github.com/repos/tilgovi/h/stargazers","contributors_url":"https://api.github.com/repos/tilgovi/h/contributors","subscribers_url":"https://api.github.com/repos/tilgovi/h/subscribers","subscription_url":"https://api.github.com/repos/tilgovi/h/subscription","commits_url":"https://api.github.com/repos/tilgovi/h/commits{/sha}","git_commits_url":"https://api.github.com/repos/tilgovi/h/git/commits{/sha}","comments_url":"https://api.github.com/repos/tilgovi/h/comments{/number}","issue_comment_url":"https://api.github.com/repos/tilgovi/h/issues/comments/{number}","contents_url":"https://api.github.com/repos/tilgovi/h/contents/{+path}","compare_url":"https://api.github.com/repos/tilgovi/h/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tilgovi/h/merges","archive_url":"https://api.github.com/repos/tilgovi/h/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tilgovi/h/downloads","issues_url":"https://api.github.com/repos/tilgovi/h/issues{/number}","pulls_url":"https://api.github.com/repos/tilgovi/h/pulls{/number}","milestones_url":"https://api.github.com/repos/tilgovi/h/milestones{/number}","notifications_url":"https://api.github.com/repos/tilgovi/h/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tilgovi/h/labels{/name}","releases_url":"https://api.github.com/repos/tilgovi/h/releases{/id}","created_at":"2012-06-12T19:21:43Z","updated_at":"2014-05-16T15:47:00Z","pushed_at":"2014-07-08T01:34:09Z","git_url":"git://github.com/tilgovi/h.git","ssh_url":"git@github.com:tilgovi/h.git","clone_url":"https://github.com/tilgovi/h.git","svn_url":"https://github.com/tilgovi/h","homepage":"https://hypothes.is/","size":3017,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"hypothesis:stream-search-refactor","ref":"stream-search-refactor","sha":"dd74bab0cf80c83623fe5dc0224c183bd38482c1","user":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?","gravatar_id":"95447824e3f558893f0fda4402920cba","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":3910945,"name":"h","full_name":"hypothesis/h","owner":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?","gravatar_id":"95447824e3f558893f0fda4402920cba","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hypothesis/h","description":"The Internet, peer reviewed.","fork":false,"url":"https://api.github.com/repos/hypothesis/h","forks_url":"https://api.github.com/repos/hypothesis/h/forks","keys_url":"https://api.github.com/repos/hypothesis/h/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/h/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/h/teams","hooks_url":"https://api.github.com/repos/hypothesis/h/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/h/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/h/events","assignees_url":"https://api.github.com/repos/hypothesis/h/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/h/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/h/tags","blobs_url":"https://api.github.com/repos/hypothesis/h/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/h/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/h/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/h/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/h/languages","stargazers_url":"https://api.github.com/repos/hypothesis/h/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/h/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/h/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/h/subscription","commits_url":"https://api.github.com/repos/hypothesis/h/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/h/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/h/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/h/issues/comments/{number}","contents_url":"https://api.github.com/repos/hypothesis/h/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/h/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/h/merges","archive_url":"https://api.github.com/repos/hypothesis/h/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/h/downloads","issues_url":"https://api.github.com/repos/hypothesis/h/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/h/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/h/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/h/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/h/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/h/releases{/id}","created_at":"2012-04-02T19:56:59Z","updated_at":"2014-07-07T11:31:10Z","pushed_at":"2014-07-08T09:03:45Z","git_url":"git://github.com/hypothesis/h.git","ssh_url":"git@github.com:hypothesis/h.git","clone_url":"https://github.com/hypothesis/h.git","svn_url":"https://github.com/hypothesis/h","homepage":"https://hypothes.is/","size":36862,"stargazers_count":300,"watchers_count":300,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":89,"mirror_url":null,"open_issues_count":251,"forks":89,"open_issues":251,"watchers":300,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hypothesis/h/pulls/1288"},"html":{"href":"https://github.com/hypothesis/h/pull/1288"},"issue":{"href":"https://api.github.com/repos/hypothesis/h/issues/1288"},"comments":{"href":"https://api.github.com/repos/hypothesis/h/issues/1288/comments"},"review_comments":{"href":"https://api.github.com/repos/hypothesis/h/pulls/1288/comments"},"review_comment":{"href":"https://api.github.com/repos/hypothesis/h/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hypothesis/h/pulls/1288/commits"},"statuses":{"href":"https://api.github.com/repos/hypothesis/h/statuses/5f43a3dc53d0f0f5b9d5b94ab123bf4ba2ccf8fb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gergely-ujvari","id":2094134,"avatar_url":"https://avatars.githubusercontent.com/u/2094134?","gravatar_id":"2b5ce8d2fd5e8f5fec91514bd31a4a94","url":"https://api.github.com/users/gergely-ujvari","html_url":"https://github.com/gergely-ujvari","followers_url":"https://api.github.com/users/gergely-ujvari/followers","following_url":"https://api.github.com/users/gergely-ujvari/following{/other_user}","gists_url":"https://api.github.com/users/gergely-ujvari/gists{/gist_id}","starred_url":"https://api.github.com/users/gergely-ujvari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gergely-ujvari/subscriptions","organizations_url":"https://api.github.com/users/gergely-ujvari/orgs","repos_url":"https://api.github.com/users/gergely-ujvari/repos","events_url":"https://api.github.com/users/gergely-ujvari/events{/privacy}","received_events_url":"https://api.github.com/users/gergely-ujvari/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":42,"deletions":67,"changed_files":6}}