GitHub PullRequestEvent at 2014-12-08 17:38:01
Repository: Umbraco-CMS
Actor: arknu
Payload: {"action":"closed","number":530,"pull_request":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/530","id":24101995,"html_url":"https://github.com/umbraco/Umbraco-CMS/pull/530","diff_url":"https://github.com/umbraco/Umbraco-CMS/pull/530.diff","patch_url":"https://github.com/umbraco/Umbraco-CMS/pull/530.patch","issue_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/530","number":530,"state":"closed","locked":false,"title":"U4-5774: Add format parameter to GetCropUrl","user":{"login":"arknu","id":4654741,"avatar_url":"https://avatars.githubusercontent.com/u/4654741?v=3","gravatar_id":"","url":"https://api.github.com/users/arknu","html_url":"https://github.com/arknu","followers_url":"https://api.github.com/users/arknu/followers","following_url":"https://api.github.com/users/arknu/following{/other_user}","gists_url":"https://api.github.com/users/arknu/gists{/gist_id}","starred_url":"https://api.github.com/users/arknu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arknu/subscriptions","organizations_url":"https://api.github.com/users/arknu/orgs","repos_url":"https://api.github.com/users/arknu/repos","events_url":"https://api.github.com/users/arknu/events{/privacy}","received_events_url":"https://api.github.com/users/arknu/received_events","type":"User","site_admin":false},"body":"This adds a `format` parameter to GetCropUrl to allow for changing the format. Photographs are by far the most frequent use case for the Image Cropper and those are much better compressed in JPEG.\r\n\r\n**UPDATE**: I have revised this PR to provide no default value for the parameter and instead pull the image format from the umbracoExtension property when available. If it isn't, the existing behavior is used instead.\r\n\r\nAs the `format` parameter is optional, it is API compatible with v. 7.1.\r\nThis does not add a setting to change the default format, although that would probably be a good feature.","created_at":"2014-11-08T14:47:36Z","updated_at":"2014-12-08T17:38:00Z","closed_at":"2014-12-08T17:38:00Z","merged_at":null,"merge_commit_sha":"f8d6c0471503666d929612d1a38fed3c97b5cabd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/530/commits","review_comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/530/comments","review_comment_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/comments/{number}","comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/530/comments","statuses_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/statuses/0adcf076470ee947da0f6a8dba2ae1267c1a0fe2","head":{"label":"arknu:imageprocessor-jpeg","ref":"imageprocessor-jpeg","sha":"0adcf076470ee947da0f6a8dba2ae1267c1a0fe2","user":{"login":"arknu","id":4654741,"avatar_url":"https://avatars.githubusercontent.com/u/4654741?v=3","gravatar_id":"","url":"https://api.github.com/users/arknu","html_url":"https://github.com/arknu","followers_url":"https://api.github.com/users/arknu/followers","following_url":"https://api.github.com/users/arknu/following{/other_user}","gists_url":"https://api.github.com/users/arknu/gists{/gist_id}","starred_url":"https://api.github.com/users/arknu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arknu/subscriptions","organizations_url":"https://api.github.com/users/arknu/orgs","repos_url":"https://api.github.com/users/arknu/repos","events_url":"https://api.github.com/users/arknu/events{/privacy}","received_events_url":"https://api.github.com/users/arknu/received_events","type":"User","site_admin":false},"repo":{"id":17176246,"name":"Umbraco-CMS","full_name":"arknu/Umbraco-CMS","owner":{"login":"arknu","id":4654741,"avatar_url":"https://avatars.githubusercontent.com/u/4654741?v=3","gravatar_id":"","url":"https://api.github.com/users/arknu","html_url":"https://github.com/arknu","followers_url":"https://api.github.com/users/arknu/followers","following_url":"https://api.github.com/users/arknu/following{/other_user}","gists_url":"https://api.github.com/users/arknu/gists{/gist_id}","starred_url":"https://api.github.com/users/arknu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arknu/subscriptions","organizations_url":"https://api.github.com/users/arknu/orgs","repos_url":"https://api.github.com/users/arknu/repos","events_url":"https://api.github.com/users/arknu/events{/privacy}","received_events_url":"https://api.github.com/users/arknu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arknu/Umbraco-CMS","description":"The simple, flexible and friendly ASP.NET CMS used by more than 175.000 websites","fork":true,"url":"https://api.github.com/repos/arknu/Umbraco-CMS","forks_url":"https://api.github.com/repos/arknu/Umbraco-CMS/forks","keys_url":"https://api.github.com/repos/arknu/Umbraco-CMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arknu/Umbraco-CMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arknu/Umbraco-CMS/teams","hooks_url":"https://api.github.com/repos/arknu/Umbraco-CMS/hooks","issue_events_url":"https://api.github.com/repos/arknu/Umbraco-CMS/issues/events{/number}","events_url":"https://api.github.com/repos/arknu/Umbraco-CMS/events","assignees_url":"https://api.github.com/repos/arknu/Umbraco-CMS/assignees{/user}","branches_url":"https://api.github.com/repos/arknu/Umbraco-CMS/branches{/branch}","tags_url":"https://api.github.com/repos/arknu/Umbraco-CMS/tags","blobs_url":"https://api.github.com/repos/arknu/Umbraco-CMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arknu/Umbraco-CMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arknu/Umbraco-CMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/arknu/Umbraco-CMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arknu/Umbraco-CMS/statuses/{sha}","languages_url":"https://api.github.com/repos/arknu/Umbraco-CMS/languages","stargazers_url":"https://api.github.com/repos/arknu/Umbraco-CMS/stargazers","contributors_url":"https://api.github.com/repos/arknu/Umbraco-CMS/contributors","subscribers_url":"https://api.github.com/repos/arknu/Umbraco-CMS/subscribers","subscription_url":"https://api.github.com/repos/arknu/Umbraco-CMS/subscription","commits_url":"https://api.github.com/repos/arknu/Umbraco-CMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/arknu/Umbraco-CMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/arknu/Umbraco-CMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/arknu/Umbraco-CMS/issues/comments/{number}","contents_url":"https://api.github.com/repos/arknu/Umbraco-CMS/contents/{+path}","compare_url":"https://api.github.com/repos/arknu/Umbraco-CMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arknu/Umbraco-CMS/merges","archive_url":"https://api.github.com/repos/arknu/Umbraco-CMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arknu/Umbraco-CMS/downloads","issues_url":"https://api.github.com/repos/arknu/Umbraco-CMS/issues{/number}","pulls_url":"https://api.github.com/repos/arknu/Umbraco-CMS/pulls{/number}","milestones_url":"https://api.github.com/repos/arknu/Umbraco-CMS/milestones{/number}","notifications_url":"https://api.github.com/repos/arknu/Umbraco-CMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arknu/Umbraco-CMS/labels{/name}","releases_url":"https://api.github.com/repos/arknu/Umbraco-CMS/releases{/id}","created_at":"2014-02-25T14:46:05Z","updated_at":"2014-07-18T15:01:26Z","pushed_at":"2014-12-08T17:37:06Z","git_url":"git://github.com/arknu/Umbraco-CMS.git","ssh_url":"git@github.com:arknu/Umbraco-CMS.git","clone_url":"https://github.com/arknu/Umbraco-CMS.git","svn_url":"https://github.com/arknu/Umbraco-CMS","homepage":"http://umbraco.com","size":100825,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"7.1.0"}},"base":{"label":"umbraco:7.2.0","ref":"7.2.0","sha":"db4495cf50a0d994811479a7709524eade9bcca6","user":{"login":"umbraco","id":1419552,"avatar_url":"https://avatars.githubusercontent.com/u/1419552?v=3","gravatar_id":"","url":"https://api.github.com/users/umbraco","html_url":"https://github.com/umbraco","followers_url":"https://api.github.com/users/umbraco/followers","following_url":"https://api.github.com/users/umbraco/following{/other_user}","gists_url":"https://api.github.com/users/umbraco/gists{/gist_id}","starred_url":"https://api.github.com/users/umbraco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umbraco/subscriptions","organizations_url":"https://api.github.com/users/umbraco/orgs","repos_url":"https://api.github.com/users/umbraco/repos","events_url":"https://api.github.com/users/umbraco/events{/privacy}","received_events_url":"https://api.github.com/users/umbraco/received_events","type":"Organization","site_admin":false},"repo":{"id":10601208,"name":"Umbraco-CMS","full_name":"umbraco/Umbraco-CMS","owner":{"login":"umbraco","id":1419552,"avatar_url":"https://avatars.githubusercontent.com/u/1419552?v=3","gravatar_id":"","url":"https://api.github.com/users/umbraco","html_url":"https://github.com/umbraco","followers_url":"https://api.github.com/users/umbraco/followers","following_url":"https://api.github.com/users/umbraco/following{/other_user}","gists_url":"https://api.github.com/users/umbraco/gists{/gist_id}","starred_url":"https://api.github.com/users/umbraco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umbraco/subscriptions","organizations_url":"https://api.github.com/users/umbraco/orgs","repos_url":"https://api.github.com/users/umbraco/repos","events_url":"https://api.github.com/users/umbraco/events{/privacy}","received_events_url":"https://api.github.com/users/umbraco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/umbraco/Umbraco-CMS","description":"The simple, flexible and friendly ASP.NET CMS used by more than 225.000 websites","fork":false,"url":"https://api.github.com/repos/umbraco/Umbraco-CMS","forks_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/forks","keys_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/teams","hooks_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/hooks","issue_events_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/events{/number}","events_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/events","assignees_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/assignees{/user}","branches_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/branches{/branch}","tags_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/tags","blobs_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/statuses/{sha}","languages_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/languages","stargazers_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/stargazers","contributors_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/contributors","subscribers_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/subscribers","subscription_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/subscription","commits_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/comments/{number}","contents_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/contents/{+path}","compare_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/merges","archive_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/downloads","issues_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues{/number}","pulls_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls{/number}","milestones_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/milestones{/number}","notifications_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/labels{/name}","releases_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/releases{/id}","created_at":"2013-06-10T13:50:46Z","updated_at":"2014-12-08T06:34:59Z","pushed_at":"2014-12-08T06:34:59Z","git_url":"git://github.com/umbraco/Umbraco-CMS.git","ssh_url":"git@github.com:umbraco/Umbraco-CMS.git","clone_url":"https://github.com/umbraco/Umbraco-CMS.git","svn_url":"https://github.com/umbraco/Umbraco-CMS","homepage":"http://umbraco.com","size":249817,"stargazers_count":640,"watchers_count":640,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":519,"mirror_url":null,"open_issues_count":70,"forks":519,"open_issues":70,"watchers":640,"default_branch":"7.2.1"}},"_links":{"self":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/530"},"html":{"href":"https://github.com/umbraco/Umbraco-CMS/pull/530"},"issue":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/530"},"comments":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/530/comments"},"review_comments":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/530/comments"},"review_comment":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/530/commits"},"statuses":{"href":"https://api.github.com/repos/umbraco/Umbraco-CMS/statuses/0adcf076470ee947da0f6a8dba2ae1267c1a0fe2"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":16,"review_comments":0,"commits":5,"additions":38,"deletions":8,"changed_files":1}}