GitHub PullRequestReviewCommentEvent at 2014-10-01 18:02:10
Repository: k
Actor: yilongli
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kframework/k/pulls/comments/18296158","id":18296158,"diff_hunk":"@@ -92,20 +84,46 @@ public ASTNode visit(Module node, Void _)  {\n \n             sort2_loop:\n                 for (Sort sort2 : node.getAllSorts()) {\n-                    // TODO(AndreiS): deal with equivalent sorts\n-                    if (context.isSubsortedEq(sort2, sort1) || context.isSubsortedEq(sort1, sort2)\n-                            || context.isListSort(sort2)) {\n+                    if (sort1.equals(sort2)\n+                            || context.isSubsorted(sort2, sort1)) {\n                         continue;\n                     }\n \n-                    for (Production production : productions) {\n+                    for (Production production : sort1Prods) {\n                         if (!context.isSubsorted(sort2, production.getChildSort(0))) {\n                             continue sort2_loop;\n                         }\n                     }\n \n-                    transformedNode.addSubsort(sort2, sort1, context);\n-                    change = true;\n+                    if (context.isSubsorted(sort1, sort2)) {","path":"k-core/src/main/java/org/kframework/compile/transformers/CompleteSortLattice.java","position":88,"original_position":88,"commit_id":"88d407ea71ab71b4add77f9369b8360959799ec0","original_commit_id":"8fd92ca8a84ae29a77d8dba889e89af8810d50fc","user":{"login":"yilongli","id":4922997,"avatar_url":"https://avatars.githubusercontent.com/u/4922997?v=2","gravatar_id":"","url":"https://api.github.com/users/yilongli","html_url":"https://github.com/yilongli","followers_url":"https://api.github.com/users/yilongli/followers","following_url":"https://api.github.com/users/yilongli/following{/other_user}","gists_url":"https://api.github.com/users/yilongli/gists{/gist_id}","starred_url":"https://api.github.com/users/yilongli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yilongli/subscriptions","organizations_url":"https://api.github.com/users/yilongli/orgs","repos_url":"https://api.github.com/users/yilongli/repos","events_url":"https://api.github.com/users/yilongli/events{/privacy}","received_events_url":"https://api.github.com/users/yilongli/received_events","type":"User","site_admin":false},"body":"alright, then I am fine with it","created_at":"2014-10-01T18:02:10Z","updated_at":"2014-10-01T18:02:10Z","html_url":"https://github.com/kframework/k/pull/1020#discussion_r18296158","pull_request_url":"https://api.github.com/repos/kframework/k/pulls/1020","_links":{"self":{"href":"https://api.github.com/repos/kframework/k/pulls/comments/18296158"},"html":{"href":"https://github.com/kframework/k/pull/1020#discussion_r18296158"},"pull_request":{"href":"https://api.github.com/repos/kframework/k/pulls/1020"}}},"pull_request":{"url":"https://api.github.com/repos/kframework/k/pulls/1020","id":22026941,"html_url":"https://github.com/kframework/k/pull/1020","diff_url":"https://github.com/kframework/k/pull/1020.diff","patch_url":"https://github.com/kframework/k/pull/1020.patch","issue_url":"https://api.github.com/repos/kframework/k/issues/1020","number":1020,"state":"open","locked":false,"title":"implement equivalent sorts","user":{"login":"osa1","id":448274,"avatar_url":"https://avatars.githubusercontent.com/u/448274?v=2","gravatar_id":"","url":"https://api.github.com/users/osa1","html_url":"https://github.com/osa1","followers_url":"https://api.github.com/users/osa1/followers","following_url":"https://api.github.com/users/osa1/following{/other_user}","gists_url":"https://api.github.com/users/osa1/gists{/gist_id}","starred_url":"https://api.github.com/users/osa1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osa1/subscriptions","organizations_url":"https://api.github.com/users/osa1/orgs","repos_url":"https://api.github.com/users/osa1/repos","events_url":"https://api.github.com/users/osa1/events{/privacy}","received_events_url":"https://api.github.com/users/osa1/received_events","type":"User","site_admin":false},"body":"Very crude first implementation. Some tests are expected to fail. Not ready for merge.\r\n\r\n@yilongli @andreistefanescu can you have a look?","created_at":"2014-09-30T18:59:42Z","updated_at":"2014-10-01T18:02:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5eb006d8eab18347f8d4b5f38f5418a0fc0f612","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kframework/k/pulls/1020/commits","review_comments_url":"https://api.github.com/repos/kframework/k/pulls/1020/comments","review_comment_url":"https://api.github.com/repos/kframework/k/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kframework/k/issues/1020/comments","statuses_url":"https://api.github.com/repos/kframework/k/statuses/88d407ea71ab71b4add77f9369b8360959799ec0","head":{"label":"osa1:lattice-stuff","ref":"lattice-stuff","sha":"88d407ea71ab71b4add77f9369b8360959799ec0","user":{"login":"osa1","id":448274,"avatar_url":"https://avatars.githubusercontent.com/u/448274?v=2","gravatar_id":"","url":"https://api.github.com/users/osa1","html_url":"https://github.com/osa1","followers_url":"https://api.github.com/users/osa1/followers","following_url":"https://api.github.com/users/osa1/following{/other_user}","gists_url":"https://api.github.com/users/osa1/gists{/gist_id}","starred_url":"https://api.github.com/users/osa1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osa1/subscriptions","organizations_url":"https://api.github.com/users/osa1/orgs","repos_url":"https://api.github.com/users/osa1/repos","events_url":"https://api.github.com/users/osa1/events{/privacy}","received_events_url":"https://api.github.com/users/osa1/received_events","type":"User","site_admin":false},"repo":{"id":13075204,"name":"k","full_name":"osa1/k","owner":{"login":"osa1","id":448274,"avatar_url":"https://avatars.githubusercontent.com/u/448274?v=2","gravatar_id":"","url":"https://api.github.com/users/osa1","html_url":"https://github.com/osa1","followers_url":"https://api.github.com/users/osa1/followers","following_url":"https://api.github.com/users/osa1/following{/other_user}","gists_url":"https://api.github.com/users/osa1/gists{/gist_id}","starred_url":"https://api.github.com/users/osa1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osa1/subscriptions","organizations_url":"https://api.github.com/users/osa1/orgs","repos_url":"https://api.github.com/users/osa1/repos","events_url":"https://api.github.com/users/osa1/events{/privacy}","received_events_url":"https://api.github.com/users/osa1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/osa1/k","description":"The K tools","fork":true,"url":"https://api.github.com/repos/osa1/k","forks_url":"https://api.github.com/repos/osa1/k/forks","keys_url":"https://api.github.com/repos/osa1/k/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osa1/k/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osa1/k/teams","hooks_url":"https://api.github.com/repos/osa1/k/hooks","issue_events_url":"https://api.github.com/repos/osa1/k/issues/events{/number}","events_url":"https://api.github.com/repos/osa1/k/events","assignees_url":"https://api.github.com/repos/osa1/k/assignees{/user}","branches_url":"https://api.github.com/repos/osa1/k/branches{/branch}","tags_url":"https://api.github.com/repos/osa1/k/tags","blobs_url":"https://api.github.com/repos/osa1/k/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osa1/k/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osa1/k/git/refs{/sha}","trees_url":"https://api.github.com/repos/osa1/k/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osa1/k/statuses/{sha}","languages_url":"https://api.github.com/repos/osa1/k/languages","stargazers_url":"https://api.github.com/repos/osa1/k/stargazers","contributors_url":"https://api.github.com/repos/osa1/k/contributors","subscribers_url":"https://api.github.com/repos/osa1/k/subscribers","subscription_url":"https://api.github.com/repos/osa1/k/subscription","commits_url":"https://api.github.com/repos/osa1/k/commits{/sha}","git_commits_url":"https://api.github.com/repos/osa1/k/git/commits{/sha}","comments_url":"https://api.github.com/repos/osa1/k/comments{/number}","issue_comment_url":"https://api.github.com/repos/osa1/k/issues/comments/{number}","contents_url":"https://api.github.com/repos/osa1/k/contents/{+path}","compare_url":"https://api.github.com/repos/osa1/k/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osa1/k/merges","archive_url":"https://api.github.com/repos/osa1/k/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osa1/k/downloads","issues_url":"https://api.github.com/repos/osa1/k/issues{/number}","pulls_url":"https://api.github.com/repos/osa1/k/pulls{/number}","milestones_url":"https://api.github.com/repos/osa1/k/milestones{/number}","notifications_url":"https://api.github.com/repos/osa1/k/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osa1/k/labels{/name}","releases_url":"https://api.github.com/repos/osa1/k/releases{/id}","created_at":"2013-09-24T19:58:56Z","updated_at":"2014-07-04T09:35:12Z","pushed_at":"2014-10-01T17:21:54Z","git_url":"git://github.com/osa1/k.git","ssh_url":"git@github.com:osa1/k.git","clone_url":"https://github.com/osa1/k.git","svn_url":"https://github.com/osa1/k","homepage":"kframework.org","size":250810,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kframework:master","ref":"master","sha":"397620c0499df1065a990dbe6209fdbb022a9de7","user":{"login":"kframework","id":5104335,"avatar_url":"https://avatars.githubusercontent.com/u/5104335?v=2","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"repo":{"id":11711223,"name":"k","full_name":"kframework/k","owner":{"login":"kframework","id":5104335,"avatar_url":"https://avatars.githubusercontent.com/u/5104335?v=2","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kframework/k","description":"The K tools","fork":false,"url":"https://api.github.com/repos/kframework/k","forks_url":"https://api.github.com/repos/kframework/k/forks","keys_url":"https://api.github.com/repos/kframework/k/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kframework/k/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kframework/k/teams","hooks_url":"https://api.github.com/repos/kframework/k/hooks","issue_events_url":"https://api.github.com/repos/kframework/k/issues/events{/number}","events_url":"https://api.github.com/repos/kframework/k/events","assignees_url":"https://api.github.com/repos/kframework/k/assignees{/user}","branches_url":"https://api.github.com/repos/kframework/k/branches{/branch}","tags_url":"https://api.github.com/repos/kframework/k/tags","blobs_url":"https://api.github.com/repos/kframework/k/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kframework/k/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kframework/k/git/refs{/sha}","trees_url":"https://api.github.com/repos/kframework/k/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kframework/k/statuses/{sha}","languages_url":"https://api.github.com/repos/kframework/k/languages","stargazers_url":"https://api.github.com/repos/kframework/k/stargazers","contributors_url":"https://api.github.com/repos/kframework/k/contributors","subscribers_url":"https://api.github.com/repos/kframework/k/subscribers","subscription_url":"https://api.github.com/repos/kframework/k/subscription","commits_url":"https://api.github.com/repos/kframework/k/commits{/sha}","git_commits_url":"https://api.github.com/repos/kframework/k/git/commits{/sha}","comments_url":"https://api.github.com/repos/kframework/k/comments{/number}","issue_comment_url":"https://api.github.com/repos/kframework/k/issues/comments/{number}","contents_url":"https://api.github.com/repos/kframework/k/contents/{+path}","compare_url":"https://api.github.com/repos/kframework/k/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kframework/k/merges","archive_url":"https://api.github.com/repos/kframework/k/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kframework/k/downloads","issues_url":"https://api.github.com/repos/kframework/k/issues{/number}","pulls_url":"https://api.github.com/repos/kframework/k/pulls{/number}","milestones_url":"https://api.github.com/repos/kframework/k/milestones{/number}","notifications_url":"https://api.github.com/repos/kframework/k/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kframework/k/labels{/name}","releases_url":"https://api.github.com/repos/kframework/k/releases{/id}","created_at":"2013-07-27T21:22:53Z","updated_at":"2014-09-30T23:58:33Z","pushed_at":"2014-10-01T16:09:12Z","git_url":"git://github.com/kframework/k.git","ssh_url":"git@github.com:kframework/k.git","clone_url":"https://github.com/kframework/k.git","svn_url":"https://github.com/kframework/k","homepage":"kframework.org","size":346875,"stargazers_count":40,"watchers_count":40,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":293,"forks":42,"open_issues":293,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kframework/k/pulls/1020"},"html":{"href":"https://github.com/kframework/k/pull/1020"},"issue":{"href":"https://api.github.com/repos/kframework/k/issues/1020"},"comments":{"href":"https://api.github.com/repos/kframework/k/issues/1020/comments"},"review_comments":{"href":"https://api.github.com/repos/kframework/k/pulls/1020/comments"},"review_comment":{"href":"https://api.github.com/repos/kframework/k/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kframework/k/pulls/1020/commits"},"statuses":{"href":"https://api.github.com/repos/kframework/k/statuses/88d407ea71ab71b4add77f9369b8360959799ec0"}}}}