GitHub PullRequestReviewCommentEvent at 2014-05-05 16:04:17
Repository: chill
Actor: ianoc
Payload: {"comment":{"url":"https://api.github.com/repos/twitter/chill/pulls/comments/12285109","id":12285109,"diff_hunk":"@@ -54,10 +76,37 @@ object AvroSerializerSpec extends Specification {\n \n   \"SpecificRecordJsonSerializer\" should {\n     \"Serialize and Deserialize Avro Record\" in {\n-      val kryo = getKryo(AvroSerializer.SpecificRecordJsonSerializer[FiscalRecord](FiscalRecord.SCHEMA$))\n+      val kryo = getKryoForSpecificRecord(AvroSerializer.SpecificRecordJsonSerializer[FiscalRecord](FiscalRecord.SCHEMA$))\n       val bytes = kryo.toBytesWithClass(testRrecord)\n       val result = kryo.fromBytes(bytes).asInstanceOf[FiscalRecord]\n       testRrecord must_== result\n     }\n   }\n+\n+  \"GenericRecordSerializer\" should {\n+    \"Serialize and Deserialize Avro Record\" in {\n+      val kryo = getKryoForGenericRecord(AvroSerializer.GenericRecordSerialize[GenericRecord](schema))\n+      val bytes = kryo.toBytesWithClass(user)\n+      val result = kryo.fromBytes(bytes).asInstanceOf[GenericRecord]\n+      user must_== result","path":"chill-avro/src/test/scala/com/twitter/chill/avro/AvroSerializerSpec.scala","position":76,"original_position":76,"commit_id":"6586e9e1d6338ea410e1d060aed5d014cb4ae434","original_commit_id":"6586e9e1d6338ea410e1d060aed5d014cb4ae434","user":{"login":"ianoc","id":446652,"avatar_url":"https://avatars.githubusercontent.com/u/446652?","gravatar_id":"36ce3c50fa3c11de597342acef7d93af","url":"https://api.github.com/users/ianoc","html_url":"https://github.com/ianoc","followers_url":"https://api.github.com/users/ianoc/followers","following_url":"https://api.github.com/users/ianoc/following{/other_user}","gists_url":"https://api.github.com/users/ianoc/gists{/gist_id}","starred_url":"https://api.github.com/users/ianoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianoc/subscriptions","organizations_url":"https://api.github.com/users/ianoc/orgs","repos_url":"https://api.github.com/users/ianoc/repos","events_url":"https://api.github.com/users/ianoc/events{/privacy}","received_events_url":"https://api.github.com/users/ianoc/received_events","type":"User","site_admin":false},"body":"Can someone add/include a test thats failing? Will help us help debug","created_at":"2014-05-05T16:04:17Z","updated_at":"2014-05-05T16:04:17Z","html_url":"https://github.com/twitter/chill/pull/184#discussion_r12285109","pull_request_url":"https://api.github.com/repos/twitter/chill/pulls/184","_links":{"self":{"href":"https://api.github.com/repos/twitter/chill/pulls/comments/12285109"},"html":{"href":"https://github.com/twitter/chill/pull/184#discussion_r12285109"},"pull_request":{"href":"https://api.github.com/repos/twitter/chill/pulls/184"}}}}