GitHub PullRequestReviewCommentEvent at 2014-08-21 19:07:26
Repository: robottelo
Actor: omaciel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/16560094","id":16560094,"diff_hunk":"@@ -1207,40 +1208,60 @@ class Meta(object):\n         api_path = 'katello/api/v2/systems/:system_id/packages'\n \n \n-class System(orm.Entity):\n+class System(orm.Entity, factory.EntityFactoryMixin):\n     \"\"\"A representation of a System entity.\"\"\"\n-    name = orm.StringField(required=True)\n+    content_view = orm.OneToOneField('ContentView')\n     description = orm.StringField()\n-    # Physical location of the content host\n-    location = orm.StringField()\n-    # Any number of facts about this content host\n-    fact = orm.StringField(null=True)\n-    # Type of the content host, it should always be 'content host'\n-    system_type = orm.StringField(default='content host', required=True)\n-    # IDs of the guests running on this content host\n-    # FIXME figure out related resource\n-    # guest = orm.OneToManyField()\n-    # List of products installed on the content host\n+    environment = orm.OneToOneField('Environment')\n+    facts = orm.DictField(\n+        default={'uname.machine': 'unknown'},","path":"robottelo/entities.py","position":32,"original_position":32,"commit_id":"46e47672cc36e53fa80bbc3f1881ffffbea2b7c0","original_commit_id":"46e47672cc36e53fa80bbc3f1881ffffbea2b7c0","user":{"login":"omaciel","id":53362,"avatar_url":"https://avatars.githubusercontent.com/u/53362?v=2","gravatar_id":"5be9b08cd178f87cca6de19f00a9992c","url":"https://api.github.com/users/omaciel","html_url":"https://github.com/omaciel","followers_url":"https://api.github.com/users/omaciel/followers","following_url":"https://api.github.com/users/omaciel/following{/other_user}","gists_url":"https://api.github.com/users/omaciel/gists{/gist_id}","starred_url":"https://api.github.com/users/omaciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omaciel/subscriptions","organizations_url":"https://api.github.com/users/omaciel/orgs","repos_url":"https://api.github.com/users/omaciel/repos","events_url":"https://api.github.com/users/omaciel/events{/privacy}","received_events_url":"https://api.github.com/users/omaciel/received_events","type":"User","site_admin":false},"body":"how about ``default={u'uname.machine': u'unknown'},``?","created_at":"2014-08-21T19:07:26Z","updated_at":"2014-08-21T19:07:26Z","html_url":"https://github.com/omaciel/robottelo/pull/1218#discussion_r16560094","pull_request_url":"https://api.github.com/repos/omaciel/robottelo/pulls/1218","_links":{"self":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/16560094"},"html":{"href":"https://github.com/omaciel/robottelo/pull/1218#discussion_r16560094"},"pull_request":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1218"}}},"pull_request":{"url":"https://api.github.com/repos/omaciel/robottelo/pulls/1218","id":20058160,"html_url":"https://github.com/omaciel/robottelo/pull/1218","diff_url":"https://github.com/omaciel/robottelo/pull/1218.diff","patch_url":"https://github.com/omaciel/robottelo/pull/1218.patch","issue_url":"https://api.github.com/repos/omaciel/robottelo/issues/1218","number":1218,"state":"open","locked":false,"title":"Make System().create() work","user":{"login":"Ichimonji10","id":1012989,"avatar_url":"https://avatars.githubusercontent.com/u/1012989?v=2","gravatar_id":"0d55b0822baba206e15373fbe457bf70","url":"https://api.github.com/users/Ichimonji10","html_url":"https://github.com/Ichimonji10","followers_url":"https://api.github.com/users/Ichimonji10/followers","following_url":"https://api.github.com/users/Ichimonji10/following{/other_user}","gists_url":"https://api.github.com/users/Ichimonji10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichimonji10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichimonji10/subscriptions","organizations_url":"https://api.github.com/users/Ichimonji10/orgs","repos_url":"https://api.github.com/users/Ichimonji10/repos","events_url":"https://api.github.com/users/Ichimonji10/events{/privacy}","received_events_url":"https://api.github.com/users/Ichimonji10/received_events","type":"User","site_admin":false},"body":"The two commit messages spell out the changes quite clearly. In short:\r\n\r\n* Make `System().create()` work.\r\n* Add `System` to some of the test cases in module `tests.foreman.api.test_multiple_paths`.\r\n\r\nNote that the `System` entity has not been added to *all* of the tests in `test_multiple_paths`, as the API requires a system's UUID, not ID. This is rather strange, and some code must be devised to adapt to this situation. Overriding `System.path` to use the system's UUID instead of ID may be a good solution.","created_at":"2014-08-20T16:54:18Z","updated_at":"2014-08-21T19:07:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fa4bacaa5cefb64c46fc7e777f6f1a19f88565c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/omaciel/robottelo/pulls/1218/commits","review_comments_url":"https://api.github.com/repos/omaciel/robottelo/pulls/1218/comments","review_comment_url":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/omaciel/robottelo/issues/1218/comments","statuses_url":"https://api.github.com/repos/omaciel/robottelo/statuses/46e47672cc36e53fa80bbc3f1881ffffbea2b7c0","head":{"label":"Ichimonji10:system-entity","ref":"system-entity","sha":"46e47672cc36e53fa80bbc3f1881ffffbea2b7c0","user":{"login":"Ichimonji10","id":1012989,"avatar_url":"https://avatars.githubusercontent.com/u/1012989?v=2","gravatar_id":"0d55b0822baba206e15373fbe457bf70","url":"https://api.github.com/users/Ichimonji10","html_url":"https://github.com/Ichimonji10","followers_url":"https://api.github.com/users/Ichimonji10/followers","following_url":"https://api.github.com/users/Ichimonji10/following{/other_user}","gists_url":"https://api.github.com/users/Ichimonji10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichimonji10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichimonji10/subscriptions","organizations_url":"https://api.github.com/users/Ichimonji10/orgs","repos_url":"https://api.github.com/users/Ichimonji10/repos","events_url":"https://api.github.com/users/Ichimonji10/events{/privacy}","received_events_url":"https://api.github.com/users/Ichimonji10/received_events","type":"User","site_admin":false},"repo":{"id":20566902,"name":"robottelo","full_name":"Ichimonji10/robottelo","owner":{"login":"Ichimonji10","id":1012989,"avatar_url":"https://avatars.githubusercontent.com/u/1012989?v=2","gravatar_id":"0d55b0822baba206e15373fbe457bf70","url":"https://api.github.com/users/Ichimonji10","html_url":"https://github.com/Ichimonji10","followers_url":"https://api.github.com/users/Ichimonji10/followers","following_url":"https://api.github.com/users/Ichimonji10/following{/other_user}","gists_url":"https://api.github.com/users/Ichimonji10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ichimonji10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ichimonji10/subscriptions","organizations_url":"https://api.github.com/users/Ichimonji10/orgs","repos_url":"https://api.github.com/users/Ichimonji10/repos","events_url":"https://api.github.com/users/Ichimonji10/events{/privacy}","received_events_url":"https://api.github.com/users/Ichimonji10/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ichimonji10/robottelo","description":"An automation testing framework for the Katello project.","fork":true,"url":"https://api.github.com/repos/Ichimonji10/robottelo","forks_url":"https://api.github.com/repos/Ichimonji10/robottelo/forks","keys_url":"https://api.github.com/repos/Ichimonji10/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ichimonji10/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ichimonji10/robottelo/teams","hooks_url":"https://api.github.com/repos/Ichimonji10/robottelo/hooks","issue_events_url":"https://api.github.com/repos/Ichimonji10/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/Ichimonji10/robottelo/events","assignees_url":"https://api.github.com/repos/Ichimonji10/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/Ichimonji10/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/Ichimonji10/robottelo/tags","blobs_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ichimonji10/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/Ichimonji10/robottelo/languages","stargazers_url":"https://api.github.com/repos/Ichimonji10/robottelo/stargazers","contributors_url":"https://api.github.com/repos/Ichimonji10/robottelo/contributors","subscribers_url":"https://api.github.com/repos/Ichimonji10/robottelo/subscribers","subscription_url":"https://api.github.com/repos/Ichimonji10/robottelo/subscription","commits_url":"https://api.github.com/repos/Ichimonji10/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ichimonji10/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ichimonji10/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ichimonji10/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/Ichimonji10/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/Ichimonji10/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ichimonji10/robottelo/merges","archive_url":"https://api.github.com/repos/Ichimonji10/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ichimonji10/robottelo/downloads","issues_url":"https://api.github.com/repos/Ichimonji10/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/Ichimonji10/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/Ichimonji10/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/Ichimonji10/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ichimonji10/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/Ichimonji10/robottelo/releases{/id}","created_at":"2014-06-06T14:38:05Z","updated_at":"2014-06-25T13:36:09Z","pushed_at":"2014-08-21T17:43:09Z","git_url":"git://github.com/Ichimonji10/robottelo.git","ssh_url":"git@github.com:Ichimonji10/robottelo.git","clone_url":"https://github.com/Ichimonji10/robottelo.git","svn_url":"https://github.com/Ichimonji10/robottelo","homepage":null,"size":8547,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"omaciel:master","ref":"master","sha":"6edd6a20a65eb2c79ea922a32a596b56cae96954","user":{"login":"omaciel","id":53362,"avatar_url":"https://avatars.githubusercontent.com/u/53362?v=2","gravatar_id":"5be9b08cd178f87cca6de19f00a9992c","url":"https://api.github.com/users/omaciel","html_url":"https://github.com/omaciel","followers_url":"https://api.github.com/users/omaciel/followers","following_url":"https://api.github.com/users/omaciel/following{/other_user}","gists_url":"https://api.github.com/users/omaciel/gists{/gist_id}","starred_url":"https://api.github.com/users/omaciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omaciel/subscriptions","organizations_url":"https://api.github.com/users/omaciel/orgs","repos_url":"https://api.github.com/users/omaciel/repos","events_url":"https://api.github.com/users/omaciel/events{/privacy}","received_events_url":"https://api.github.com/users/omaciel/received_events","type":"User","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"omaciel/robottelo","owner":{"login":"omaciel","id":53362,"avatar_url":"https://avatars.githubusercontent.com/u/53362?v=2","gravatar_id":"5be9b08cd178f87cca6de19f00a9992c","url":"https://api.github.com/users/omaciel","html_url":"https://github.com/omaciel","followers_url":"https://api.github.com/users/omaciel/followers","following_url":"https://api.github.com/users/omaciel/following{/other_user}","gists_url":"https://api.github.com/users/omaciel/gists{/gist_id}","starred_url":"https://api.github.com/users/omaciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omaciel/subscriptions","organizations_url":"https://api.github.com/users/omaciel/orgs","repos_url":"https://api.github.com/users/omaciel/repos","events_url":"https://api.github.com/users/omaciel/events{/privacy}","received_events_url":"https://api.github.com/users/omaciel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omaciel/robottelo","description":"An automation testing framework for the Katello project.","fork":false,"url":"https://api.github.com/repos/omaciel/robottelo","forks_url":"https://api.github.com/repos/omaciel/robottelo/forks","keys_url":"https://api.github.com/repos/omaciel/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omaciel/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omaciel/robottelo/teams","hooks_url":"https://api.github.com/repos/omaciel/robottelo/hooks","issue_events_url":"https://api.github.com/repos/omaciel/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/omaciel/robottelo/events","assignees_url":"https://api.github.com/repos/omaciel/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/omaciel/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/omaciel/robottelo/tags","blobs_url":"https://api.github.com/repos/omaciel/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omaciel/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omaciel/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/omaciel/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omaciel/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/omaciel/robottelo/languages","stargazers_url":"https://api.github.com/repos/omaciel/robottelo/stargazers","contributors_url":"https://api.github.com/repos/omaciel/robottelo/contributors","subscribers_url":"https://api.github.com/repos/omaciel/robottelo/subscribers","subscription_url":"https://api.github.com/repos/omaciel/robottelo/subscription","commits_url":"https://api.github.com/repos/omaciel/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/omaciel/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/omaciel/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/omaciel/robottelo/issues/comments/{number}","contents_url":"https://api.github.com/repos/omaciel/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/omaciel/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omaciel/robottelo/merges","archive_url":"https://api.github.com/repos/omaciel/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omaciel/robottelo/downloads","issues_url":"https://api.github.com/repos/omaciel/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/omaciel/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/omaciel/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/omaciel/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omaciel/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/omaciel/robottelo/releases{/id}","created_at":"2012-04-12T01:36:39Z","updated_at":"2014-06-27T23:03:18Z","pushed_at":"2014-08-21T14:21:54Z","git_url":"git://github.com/omaciel/robottelo.git","ssh_url":"git@github.com:omaciel/robottelo.git","clone_url":"https://github.com/omaciel/robottelo.git","svn_url":"https://github.com/omaciel/robottelo","homepage":null,"size":19823,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":18,"mirror_url":null,"open_issues_count":97,"forks":18,"open_issues":97,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1218"},"html":{"href":"https://github.com/omaciel/robottelo/pull/1218"},"issue":{"href":"https://api.github.com/repos/omaciel/robottelo/issues/1218"},"comments":{"href":"https://api.github.com/repos/omaciel/robottelo/issues/1218/comments"},"review_comments":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1218/comments"},"review_comment":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/omaciel/robottelo/pulls/1218/commits"},"statuses":{"href":"https://api.github.com/repos/omaciel/robottelo/statuses/46e47672cc36e53fa80bbc3f1881ffffbea2b7c0"}}}}