GitHub PullRequestEvent at 2014-06-16 09:11:32
Repository: bundler
Actor: TimMoore
Payload: {"action":"opened","number":3067,"pull_request":{"url":"https://api.github.com/repos/bundler/bundler/pulls/3067","id":17167601,"html_url":"https://github.com/bundler/bundler/pull/3067","diff_url":"https://github.com/bundler/bundler/pull/3067.diff","patch_url":"https://github.com/bundler/bundler/pull/3067.patch","issue_url":"https://api.github.com/repos/bundler/bundler/issues/3067","number":3067,"state":"open","title":"Fix gem_helper_spec.rb when run with git 2.0","user":{"login":"TimMoore","id":44385,"avatar_url":"https://avatars.githubusercontent.com/u/44385?","gravatar_id":"2e90f09dc8fd7f1506b245f09e97bb7c","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"body":"Git now errors out if you haven't set a default push behavior.\r\n\r\nThis caused a spec failure:\r\n\r\n```\r\nFailures:\r\n\r\n  1) Bundler::GemHelper gem management #release_gem succeeds on releasing\r\n     Failure/Error: subject.release_gem\r\n     RuntimeError:\r\n       Couldn't git push. `git push  2>&1' failed with the following output:\r\n       \r\n       warning: push.default is unset; its implicit value has changed in\r\n       Git 2.0 from 'matching' to 'simple'. To squelch this message\r\n       and maintain the traditional behavior, use:\r\n       \r\n         git config --global push.default matching\r\n       \r\n       To squelch this message and adopt the new behavior now, use:\r\n       \r\n         git config --global push.default simple\r\n       \r\n       When push.default is set to 'matching', git will push local branches\r\n       to the remote branches that already exist with the same name.\r\n       \r\n       Since Git 2.0, Git defaults to the more conservative 'simple'\r\n       behavior, which only pushes the current branch to the corresponding\r\n       remote branch that 'git pull' uses to update the current branch.\r\n       \r\n       See 'git help config' and search for 'push.default' for further information.\r\n       (the 'simple' mode was introduced in Git 1.7.11. Use the similar mode\r\n       'current' instead of 'simple' if you sometimes use older versions of Git)\r\n       \r\n       fatal: The current branch master has no upstream branch.\r\n       To push the current branch and set the remote as upstream, use\r\n       \r\n           git push --set-upstream origin master\r\n     # ./lib/bundler/gem_helper.rb:103:in `perform_git_push'\r\n     # ./lib/bundler/gem_helper.rb:95:in `git_push'\r\n     # ./lib/bundler/gem_helper.rb:76:in `block in release_gem'\r\n     # ./lib/bundler/gem_helper.rb:128:in `tag_version'\r\n     # ./lib/bundler/gem_helper.rb:76:in `release_gem'\r\n     # ./spec/bundler/gem_helper_spec.rb:208:in `block (5 levels) in <top (required)>'\r\n\r\nFinished in 1.14 seconds (files took 0.32351 seconds to load)\r\n1 example, 1 failure\r\n\r\nFailed examples:\r\n\r\nrspec ./spec/bundler/gem_helper_spec.rb:200 # Bundler::GemHelper gem management #release_gem succeeds on releasing\r\n```\r\n\r\nThe spec still passes with reasonably-recent but older versions of git, too. I tested with git version 1.8.5.2. As the message says above, the \"simple\" mode was added in 1.7.11, so versions before that will probably fail, but that version was released two years ago so I think it should be OK. If not, I can change it to use another mode. For this test case, it probably won't matter.","created_at":"2014-06-16T09:11:31Z","updated_at":"2014-06-16T09:11:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bundler/bundler/pulls/3067/commits","review_comments_url":"https://api.github.com/repos/bundler/bundler/pulls/3067/comments","review_comment_url":"https://api.github.com/repos/bundler/bundler/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bundler/bundler/issues/3067/comments","statuses_url":"https://api.github.com/repos/bundler/bundler/statuses/e7b21b8629705f515d7ea1beeb66b4f22daa7149","head":{"label":"TimMoore:fix-git-2.0","ref":"fix-git-2.0","sha":"e7b21b8629705f515d7ea1beeb66b4f22daa7149","user":{"login":"TimMoore","id":44385,"avatar_url":"https://avatars.githubusercontent.com/u/44385?","gravatar_id":"2e90f09dc8fd7f1506b245f09e97bb7c","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"repo":{"id":10596176,"name":"bundler","full_name":"TimMoore/bundler","owner":{"login":"TimMoore","id":44385,"avatar_url":"https://avatars.githubusercontent.com/u/44385?","gravatar_id":"2e90f09dc8fd7f1506b245f09e97bb7c","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TimMoore/bundler","description":"Manage your application's gem dependencies with less pain","fork":true,"url":"https://api.github.com/repos/TimMoore/bundler","forks_url":"https://api.github.com/repos/TimMoore/bundler/forks","keys_url":"https://api.github.com/repos/TimMoore/bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TimMoore/bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TimMoore/bundler/teams","hooks_url":"https://api.github.com/repos/TimMoore/bundler/hooks","issue_events_url":"https://api.github.com/repos/TimMoore/bundler/issues/events{/number}","events_url":"https://api.github.com/repos/TimMoore/bundler/events","assignees_url":"https://api.github.com/repos/TimMoore/bundler/assignees{/user}","branches_url":"https://api.github.com/repos/TimMoore/bundler/branches{/branch}","tags_url":"https://api.github.com/repos/TimMoore/bundler/tags","blobs_url":"https://api.github.com/repos/TimMoore/bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TimMoore/bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TimMoore/bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/TimMoore/bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TimMoore/bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/TimMoore/bundler/languages","stargazers_url":"https://api.github.com/repos/TimMoore/bundler/stargazers","contributors_url":"https://api.github.com/repos/TimMoore/bundler/contributors","subscribers_url":"https://api.github.com/repos/TimMoore/bundler/subscribers","subscription_url":"https://api.github.com/repos/TimMoore/bundler/subscription","commits_url":"https://api.github.com/repos/TimMoore/bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/TimMoore/bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/TimMoore/bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/TimMoore/bundler/issues/comments/{number}","contents_url":"https://api.github.com/repos/TimMoore/bundler/contents/{+path}","compare_url":"https://api.github.com/repos/TimMoore/bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TimMoore/bundler/merges","archive_url":"https://api.github.com/repos/TimMoore/bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TimMoore/bundler/downloads","issues_url":"https://api.github.com/repos/TimMoore/bundler/issues{/number}","pulls_url":"https://api.github.com/repos/TimMoore/bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/TimMoore/bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/TimMoore/bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TimMoore/bundler/labels{/name}","releases_url":"https://api.github.com/repos/TimMoore/bundler/releases{/id}","created_at":"2013-06-10T08:26:10Z","updated_at":"2014-06-16T09:11:31Z","pushed_at":"2014-06-16T09:04:26Z","git_url":"git://github.com/TimMoore/bundler.git","ssh_url":"git@github.com:TimMoore/bundler.git","clone_url":"https://github.com/TimMoore/bundler.git","svn_url":"https://github.com/TimMoore/bundler","homepage":"http://gembundler.com","size":14247,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bundler:master","ref":"master","sha":"b3d2fc82c5cb649c683b465445ffe75ec4c3d4e7","user":{"login":"bundler","id":1137638,"avatar_url":"https://avatars.githubusercontent.com/u/1137638?","gravatar_id":"08c396ce3c6d84fd8ef749da5e7a4f2b","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":488514,"name":"bundler","full_name":"bundler/bundler","owner":{"login":"bundler","id":1137638,"avatar_url":"https://avatars.githubusercontent.com/u/1137638?","gravatar_id":"08c396ce3c6d84fd8ef749da5e7a4f2b","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bundler/bundler","description":"Manage your application's gem dependencies with less pain","fork":false,"url":"https://api.github.com/repos/bundler/bundler","forks_url":"https://api.github.com/repos/bundler/bundler/forks","keys_url":"https://api.github.com/repos/bundler/bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bundler/bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bundler/bundler/teams","hooks_url":"https://api.github.com/repos/bundler/bundler/hooks","issue_events_url":"https://api.github.com/repos/bundler/bundler/issues/events{/number}","events_url":"https://api.github.com/repos/bundler/bundler/events","assignees_url":"https://api.github.com/repos/bundler/bundler/assignees{/user}","branches_url":"https://api.github.com/repos/bundler/bundler/branches{/branch}","tags_url":"https://api.github.com/repos/bundler/bundler/tags","blobs_url":"https://api.github.com/repos/bundler/bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bundler/bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bundler/bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/bundler/bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bundler/bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/bundler/bundler/languages","stargazers_url":"https://api.github.com/repos/bundler/bundler/stargazers","contributors_url":"https://api.github.com/repos/bundler/bundler/contributors","subscribers_url":"https://api.github.com/repos/bundler/bundler/subscribers","subscription_url":"https://api.github.com/repos/bundler/bundler/subscription","commits_url":"https://api.github.com/repos/bundler/bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/bundler/bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/bundler/bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/bundler/bundler/issues/comments/{number}","contents_url":"https://api.github.com/repos/bundler/bundler/contents/{+path}","compare_url":"https://api.github.com/repos/bundler/bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bundler/bundler/merges","archive_url":"https://api.github.com/repos/bundler/bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bundler/bundler/downloads","issues_url":"https://api.github.com/repos/bundler/bundler/issues{/number}","pulls_url":"https://api.github.com/repos/bundler/bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/bundler/bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/bundler/bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bundler/bundler/labels{/name}","releases_url":"https://api.github.com/repos/bundler/bundler/releases{/id}","created_at":"2010-01-26T00:46:38Z","updated_at":"2014-06-16T05:37:57Z","pushed_at":"2014-06-16T05:37:58Z","git_url":"git://github.com/bundler/bundler.git","ssh_url":"git@github.com:bundler/bundler.git","clone_url":"https://github.com/bundler/bundler.git","svn_url":"https://github.com/bundler/bundler","homepage":"http://bundler.io","size":24668,"stargazers_count":2472,"watchers_count":2472,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":994,"mirror_url":null,"open_issues_count":75,"forks":994,"open_issues":75,"watchers":2472,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bundler/bundler/pulls/3067"},"html":{"href":"https://github.com/bundler/bundler/pull/3067"},"issue":{"href":"https://api.github.com/repos/bundler/bundler/issues/3067"},"comments":{"href":"https://api.github.com/repos/bundler/bundler/issues/3067/comments"},"review_comments":{"href":"https://api.github.com/repos/bundler/bundler/pulls/3067/comments"},"review_comment":{"href":"https://api.github.com/repos/bundler/bundler/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bundler/bundler/pulls/3067/commits"},"statuses":{"href":"https://api.github.com/repos/bundler/bundler/statuses/e7b21b8629705f515d7ea1beeb66b4f22daa7149"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}