GitHub PullRequestReviewCommentEvent at 2014-10-08 15:49:27
Repository: invenio
Actor: invenio-developers
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/18591784","id":18591784,"diff_hunk":"@@ -23,23 +23,28 @@","path":"invenio/modules/knowledge/dblayer.py","position":0,"original_position":0,"commit_id":"4c94185100d43145b13be8c739bb85a1d276c765","original_commit_id":"4c94185100d43145b13be8c739bb85a1d276c765","user":{"login":"invenio-developers","id":7439566,"avatar_url":"https://avatars.githubusercontent.com/u/7439566?v=2","gravatar_id":"","url":"https://api.github.com/users/invenio-developers","html_url":"https://github.com/invenio-developers","followers_url":"https://api.github.com/users/invenio-developers/followers","following_url":"https://api.github.com/users/invenio-developers/following{/other_user}","gists_url":"https://api.github.com/users/invenio-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/invenio-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenio-developers/subscriptions","organizations_url":"https://api.github.com/users/invenio-developers/orgs","repos_url":"https://api.github.com/users/invenio-developers/repos","events_url":"https://api.github.com/users/invenio-developers/events{/privacy}","received_events_url":"https://api.github.com/users/invenio-developers/received_events","type":"User","site_admin":false},"body":"1: D200 One-line docstring should not occupy 3 lines\n4: I102 copyright year is outdated, expected 2014 but got 2013\n26:1: F401 'sessionmaker' imported but unused\n35: D401 First line should be imperative: 'Return', not 'Returns'\n35: D400 First line should end with '.', not '}'\n35: D205 Blank line missing between one-line summary and description\n35: D208 Docstring is over-indented\n43:21: E261 at least two spaces before inline comment\n61:27: E231 missing whitespace after ':'\n61:40: E231 missing whitespace after ':'\n62:36: E231 missing whitespace after ':'\n63:31: E231 missing whitespace after ':'\n69: D401 First line should be imperative: 'Return', not 'Returns'\n82: D401 First line should be imperative: 'Return', not 'Returns'\n90:38: E251 unexpected spaces around keyword / parameter equals\n90:40: E251 unexpected spaces around keyword / parameter equals\n96: D401 First line should be imperative: 'Return', not 'Returns'\n106:36: E251 unexpected spaces around keyword / parameter equals\n106:38: E251 unexpected spaces around keyword / parameter equals\n109: D401 First line should be imperative: 'Return', not 'Returns'\n117:36: E251 unexpected spaces around keyword / parameter equals\n117:38: E251 unexpected spaces around keyword / parameter equals\n120: D401 First line should be imperative: 'Return', not 'Returns'\n147:47: E128 continuation line under-indented for visual indent\n160:25: E231 missing whitespace after ':'\n160:39: E231 missing whitespace after ':'\n161:22: E127 continuation line over-indented for visual indent\n166: D401 First line should be imperative: 'Return', not 'Returns'\n166: D400 First line should end with '.', not 'z'\n166: D205 Blank line missing between one-line summary and description\n177:45: E251 unexpected spaces around keyword / parameter equals\n177:47: E251 unexpected spaces around keyword / parameter equals\n188: D401 First line should be imperative: 'Save', not 'Saves'\n203:50: E251 unexpected spaces around keyword / parameter equals\n203:52: E251 unexpected spaces around keyword / parameter equals\n205:39: E251 unexpected spaces around keyword / parameter equals\n205:41: E251 unexpected spaces around keyword / parameter equals\n207:35: E251 unexpected spaces around keyword / parameter equals\n207:37: E251 unexpected spaces around keyword / parameter equals\n207:55: E251 unexpected spaces around keyword / parameter equals\n207:57: E251 unexpected spaces around keyword / parameter equals\n207:82: E251 unexpected spaces around keyword / parameter equals\n207:84: E251 unexpected spaces around keyword / parameter equals\n207:110: E251 unexpected spaces around keyword / parameter equals\n207:112: E251 unexpected spaces around keyword / parameter equals\n215: D401 First line should be imperative: 'Return', not 'Returns'\n228: D401 First line should be imperative: 'Add', not 'Adds'\n228: D400 First line should end with '.', not 'f'\n228: D205 Blank line missing between one-line summary and description\n239:16: E261 at least two spaces before inline comment\n239:17: E262 inline comment should start with '# '\n248:39: E251 unexpected spaces around keyword / parameter equals\n248:41: E251 unexpected spaces around keyword / parameter equals\n251:27: E251 unexpected spaces around keyword / parameter equals\n251:29: E251 unexpected spaces around keyword / parameter equals\n251:50: E251 unexpected spaces around keyword / parameter equals\n251:52: E251 unexpected spaces around keyword / parameter equals\n251:75: E251 unexpected spaces around keyword / parameter equals\n251:77: E251 unexpected spaces around keyword / parameter equals\n259:20: E261 at least two spaces before inline comment\n259:21: E262 inline comment should start with '# '\n261:1: E302 expected 2 blank lines, found 1\n261: D401 First line should be imperative: 'Delete', not 'Deletes'\n261: D400 First line should end with '.', not 'b'\n271: D401 First line should be imperative: 'Return', not 'Returns'\n271: D400 First line should end with '.', not 's'\n280:1: E302 expected 2 blank lines, found 1\n280:60: E251 unexpected spaces around keyword / parameter equals\n280:62: E251 unexpected spaces around keyword / parameter equals\n280: D401 First line should be imperative: 'Update', not 'Updates'\n280: D400 First line should end with '.', not 'n'\n288:1: E302 expected 2 blank lines, found 1\n288: D401 First line should be imperative: 'Add', not 'Adds'\n288: D400 First line should end with '.', not 'b'\n295:1: E302 expected 2 blank lines, found 1\n295: D401 First line should be imperative: 'Remove', not 'Removes'\n295: D400 First line should end with '.', not 'b'\n303:1: E302 expected 2 blank lines, found 1\n303: D401 First line should be imperative: 'Return', not 'Returns'\n303: D400 First line should end with '.', not 'b'\n314:1: E302 expected 2 blank lines, found 1\n314: D401 First line should be imperative: 'Return', not 'Returns'\n314: D209 Put multi-line docstring closing quotes on separate line\n314: D400 First line should end with '.', not 'B'\n314: D205 Blank line missing between one-line summary and description\n314: D208 Docstring is over-indented\n324:1: E302 expected 2 blank lines, found 1\n324: D401 First line should be imperative: 'Return', not 'Returns'\n324: D209 Put multi-line docstring closing quotes on separate line\n324: D400 First line should end with '.', not 'B'\n324: D205 Blank line missing between one-line summary and description\n324: D208 Docstring is over-indented\n334:1: E302 expected 2 blank lines, found 1\n334: D401 First line should be imperative: 'Return', not 'Returns'\n334: D205 Blank line missing between one-line summary and description\n351:20: E261 at least two spaces before inline comment\n353:1: E302 expected 2 blank lines, found 1\n353: D401 First line should be imperative: 'Update', not 'Updates'\n353: D400 First line should end with '.', not 'e'\n364:1: E302 expected 2 blank lines, found 1\n364: D401 First line should be imperative: 'Return', not 'Returns'\n364: D400 First line should end with '.', not 'a'\n364: D205 Blank line missing between one-line summary and description\n364: D208 Docstring is over-indented\n374:42: E261 at least two spaces before inline comment\n374:43: E262 inline comment should start with '# '\n385:1: E302 expected 2 blank lines, found 1\n385: D401 First line should be imperative: 'Return', not 'Returns'\n385: D400 First line should end with '.', not 'e'\n385: D205 Blank line missing between one-line summary and description\n385: D208 Docstring is over-indented\n397:43: E261 at least two spaces before inline comment\n397:44: E262 inline comment should start with '# '\n407:19: E128 continuation line under-indented for visual indent\n409:1: E302 expected 2 blank lines, found 1\n409: D401 First line should be imperative: 'Return', not 'Returns'\n409: D400 First line should end with '.', not 'e'\n409: D208 Docstring is over-indented\n433:43: E261 at least two spaces before inline comment\n433:44: E262 inline comment should start with '# '\n441:19: E128 continuation line under-indented for visual indent\n445:1: E302 expected 2 blank lines, found 1\n445: D401 First line should be imperative: 'Return', not 'Returns'\n445: D400 First line should end with '.', not 'e'\n445: D205 Blank line missing between one-line summary and description\n445: D208 Docstring is over-indented\n458:43: E261 at least two spaces before inline comment\n458:44: E262 inline comment should start with '# '\n469:19: E128 continuation line under-indented for visual indent","created_at":"2014-10-08T15:49:27Z","updated_at":"2014-10-08T15:49:27Z","html_url":"https://github.com/inveniosoftware/invenio/pull/2389#discussion_r18591784","pull_request_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2389","_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/18591784"},"html":{"href":"https://github.com/inveniosoftware/invenio/pull/2389#discussion_r18591784"},"pull_request":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2389"}}},"pull_request":{"url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2389","id":22433151,"html_url":"https://github.com/inveniosoftware/invenio/pull/2389","diff_url":"https://github.com/inveniosoftware/invenio/pull/2389.diff","patch_url":"https://github.com/inveniosoftware/invenio/pull/2389.patch","issue_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2389","number":2389,"state":"open","locked":false,"title":"knowledge: migrate sql interface to sqlalchemy","user":{"login":"hachreak","id":377047,"avatar_url":"https://avatars.githubusercontent.com/u/377047?v=2","gravatar_id":"","url":"https://api.github.com/users/hachreak","html_url":"https://github.com/hachreak","followers_url":"https://api.github.com/users/hachreak/followers","following_url":"https://api.github.com/users/hachreak/following{/other_user}","gists_url":"https://api.github.com/users/hachreak/gists{/gist_id}","starred_url":"https://api.github.com/users/hachreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachreak/subscriptions","organizations_url":"https://api.github.com/users/hachreak/orgs","repos_url":"https://api.github.com/users/hachreak/repos","events_url":"https://api.github.com/users/hachreak/events{/privacy}","received_events_url":"https://api.github.com/users/hachreak/received_events","type":"User","site_admin":false},"body":"* Replaces run_sql queries with SQLAchemy query.\r\n\r\nSigned-off-by: Leonardo Rossi <leonardo.r@cern.ch>","created_at":"2014-10-08T15:49:22Z","updated_at":"2014-10-08T15:49:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fa40ac0004642daa7d391183b819ce4301f196a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2389/commits","review_comments_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2389/comments","review_comment_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2389/comments","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio/statuses/4c94185100d43145b13be8c739bb85a1d276c765","head":{"label":"hachreak:runsql2sqlalchemy_knowledge","ref":"runsql2sqlalchemy_knowledge","sha":"4c94185100d43145b13be8c739bb85a1d276c765","user":{"login":"hachreak","id":377047,"avatar_url":"https://avatars.githubusercontent.com/u/377047?v=2","gravatar_id":"","url":"https://api.github.com/users/hachreak","html_url":"https://github.com/hachreak","followers_url":"https://api.github.com/users/hachreak/followers","following_url":"https://api.github.com/users/hachreak/following{/other_user}","gists_url":"https://api.github.com/users/hachreak/gists{/gist_id}","starred_url":"https://api.github.com/users/hachreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachreak/subscriptions","organizations_url":"https://api.github.com/users/hachreak/orgs","repos_url":"https://api.github.com/users/hachreak/repos","events_url":"https://api.github.com/users/hachreak/events{/privacy}","received_events_url":"https://api.github.com/users/hachreak/received_events","type":"User","site_admin":false},"repo":{"id":23670712,"name":"invenio","full_name":"hachreak/invenio","owner":{"login":"hachreak","id":377047,"avatar_url":"https://avatars.githubusercontent.com/u/377047?v=2","gravatar_id":"","url":"https://api.github.com/users/hachreak","html_url":"https://github.com/hachreak","followers_url":"https://api.github.com/users/hachreak/followers","following_url":"https://api.github.com/users/hachreak/following{/other_user}","gists_url":"https://api.github.com/users/hachreak/gists{/gist_id}","starred_url":"https://api.github.com/users/hachreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachreak/subscriptions","organizations_url":"https://api.github.com/users/hachreak/orgs","repos_url":"https://api.github.com/users/hachreak/repos","events_url":"https://api.github.com/users/hachreak/events{/privacy}","received_events_url":"https://api.github.com/users/hachreak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hachreak/invenio","description":"Invenio digital library software","fork":true,"url":"https://api.github.com/repos/hachreak/invenio","forks_url":"https://api.github.com/repos/hachreak/invenio/forks","keys_url":"https://api.github.com/repos/hachreak/invenio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hachreak/invenio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hachreak/invenio/teams","hooks_url":"https://api.github.com/repos/hachreak/invenio/hooks","issue_events_url":"https://api.github.com/repos/hachreak/invenio/issues/events{/number}","events_url":"https://api.github.com/repos/hachreak/invenio/events","assignees_url":"https://api.github.com/repos/hachreak/invenio/assignees{/user}","branches_url":"https://api.github.com/repos/hachreak/invenio/branches{/branch}","tags_url":"https://api.github.com/repos/hachreak/invenio/tags","blobs_url":"https://api.github.com/repos/hachreak/invenio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hachreak/invenio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hachreak/invenio/git/refs{/sha}","trees_url":"https://api.github.com/repos/hachreak/invenio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hachreak/invenio/statuses/{sha}","languages_url":"https://api.github.com/repos/hachreak/invenio/languages","stargazers_url":"https://api.github.com/repos/hachreak/invenio/stargazers","contributors_url":"https://api.github.com/repos/hachreak/invenio/contributors","subscribers_url":"https://api.github.com/repos/hachreak/invenio/subscribers","subscription_url":"https://api.github.com/repos/hachreak/invenio/subscription","commits_url":"https://api.github.com/repos/hachreak/invenio/commits{/sha}","git_commits_url":"https://api.github.com/repos/hachreak/invenio/git/commits{/sha}","comments_url":"https://api.github.com/repos/hachreak/invenio/comments{/number}","issue_comment_url":"https://api.github.com/repos/hachreak/invenio/issues/comments/{number}","contents_url":"https://api.github.com/repos/hachreak/invenio/contents/{+path}","compare_url":"https://api.github.com/repos/hachreak/invenio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hachreak/invenio/merges","archive_url":"https://api.github.com/repos/hachreak/invenio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hachreak/invenio/downloads","issues_url":"https://api.github.com/repos/hachreak/invenio/issues{/number}","pulls_url":"https://api.github.com/repos/hachreak/invenio/pulls{/number}","milestones_url":"https://api.github.com/repos/hachreak/invenio/milestones{/number}","notifications_url":"https://api.github.com/repos/hachreak/invenio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hachreak/invenio/labels{/name}","releases_url":"https://api.github.com/repos/hachreak/invenio/releases{/id}","created_at":"2014-09-04T16:41:39Z","updated_at":"2014-08-29T21:25:45Z","pushed_at":"2014-10-08T15:48:45Z","git_url":"git://github.com/hachreak/invenio.git","ssh_url":"git@github.com:hachreak/invenio.git","clone_url":"https://github.com/hachreak/invenio.git","svn_url":"https://github.com/hachreak/invenio","homepage":"http://invenio-software.org/","size":71756,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"pu"}},"base":{"label":"inveniosoftware:pu","ref":"pu","sha":"6155a73c6c10b76f2709959a61ee05ebd2a61dbd","user":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars.githubusercontent.com/u/1157480?v=2","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":2665618,"name":"invenio","full_name":"inveniosoftware/invenio","owner":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars.githubusercontent.com/u/1157480?v=2","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inveniosoftware/invenio","description":"Invenio digital library software","fork":false,"url":"https://api.github.com/repos/inveniosoftware/invenio","forks_url":"https://api.github.com/repos/inveniosoftware/invenio/forks","keys_url":"https://api.github.com/repos/inveniosoftware/invenio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inveniosoftware/invenio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inveniosoftware/invenio/teams","hooks_url":"https://api.github.com/repos/inveniosoftware/invenio/hooks","issue_events_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/events{/number}","events_url":"https://api.github.com/repos/inveniosoftware/invenio/events","assignees_url":"https://api.github.com/repos/inveniosoftware/invenio/assignees{/user}","branches_url":"https://api.github.com/repos/inveniosoftware/invenio/branches{/branch}","tags_url":"https://api.github.com/repos/inveniosoftware/invenio/tags","blobs_url":"https://api.github.com/repos/inveniosoftware/invenio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inveniosoftware/invenio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inveniosoftware/invenio/git/refs{/sha}","trees_url":"https://api.github.com/repos/inveniosoftware/invenio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio/statuses/{sha}","languages_url":"https://api.github.com/repos/inveniosoftware/invenio/languages","stargazers_url":"https://api.github.com/repos/inveniosoftware/invenio/stargazers","contributors_url":"https://api.github.com/repos/inveniosoftware/invenio/contributors","subscribers_url":"https://api.github.com/repos/inveniosoftware/invenio/subscribers","subscription_url":"https://api.github.com/repos/inveniosoftware/invenio/subscription","commits_url":"https://api.github.com/repos/inveniosoftware/invenio/commits{/sha}","git_commits_url":"https://api.github.com/repos/inveniosoftware/invenio/git/commits{/sha}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/comments{/number}","issue_comment_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/comments/{number}","contents_url":"https://api.github.com/repos/inveniosoftware/invenio/contents/{+path}","compare_url":"https://api.github.com/repos/inveniosoftware/invenio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inveniosoftware/invenio/merges","archive_url":"https://api.github.com/repos/inveniosoftware/invenio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inveniosoftware/invenio/downloads","issues_url":"https://api.github.com/repos/inveniosoftware/invenio/issues{/number}","pulls_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls{/number}","milestones_url":"https://api.github.com/repos/inveniosoftware/invenio/milestones{/number}","notifications_url":"https://api.github.com/repos/inveniosoftware/invenio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inveniosoftware/invenio/labels{/name}","releases_url":"https://api.github.com/repos/inveniosoftware/invenio/releases{/id}","created_at":"2011-10-28T14:33:51Z","updated_at":"2014-09-29T20:00:05Z","pushed_at":"2014-10-08T13:04:43Z","git_url":"git://github.com/inveniosoftware/invenio.git","ssh_url":"git@github.com:inveniosoftware/invenio.git","clone_url":"https://github.com/inveniosoftware/invenio.git","svn_url":"https://github.com/inveniosoftware/invenio","homepage":"http://invenio-software.org/","size":87169,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":857,"forks":99,"open_issues":857,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2389"},"html":{"href":"https://github.com/inveniosoftware/invenio/pull/2389"},"issue":{"href":"https://api.github.com/repos/inveniosoftware/invenio/issues/2389"},"comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio/issues/2389/comments"},"review_comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2389/comments"},"review_comment":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2389/commits"},"statuses":{"href":"https://api.github.com/repos/inveniosoftware/invenio/statuses/4c94185100d43145b13be8c739bb85a1d276c765"}}}}