GitHub PullRequestReviewCommentEvent at 2014-03-19 07:26:37
Repository: cmssw
Actor: VinInn
Payload: {"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/10739159","id":10739159,"diff_hunk":"@@ -283,32 +283,36 @@ void RectangularEtaPhiTrackingRegion:: initEtaRange( const GlobalVector & dir, c\n \t\t\t );\n }\n \n-TrackingRegion::Hits RectangularEtaPhiTrackingRegion::hits(\n+TrackingRegion::ctfHits RectangularEtaPhiTrackingRegion::hits(\n       const edm::Event& ev,\n       const edm::EventSetup& es,\n       const  SeedingLayer* layer) const\n {\n-  return hits_(ev, es, *layer, [&](const SeedingLayer& l) -> TrackingRegion::Hits { return l.hits(ev, es);});\n+  std::cout << \"RectangularEtaPhiTrackingRegion old style hits\" << std::endl;","path":"RecoTracker/TkTrackingRegions/src/RectangularEtaPhiTrackingRegion.cc","position":11,"original_position":11,"commit_id":"4161f29326e0cc6be2d9bb4e112e5af554b3f310","original_commit_id":"4161f29326e0cc6be2d9bb4e112e5af554b3f310","user":{"login":"VinInn","id":4143702,"avatar_url":"https://avatars.githubusercontent.com/u/4143702?","gravatar_id":"5f08665ebee9ba0e427cca5060ff023a","url":"https://api.github.com/users/VinInn","html_url":"https://github.com/VinInn","followers_url":"https://api.github.com/users/VinInn/followers","following_url":"https://api.github.com/users/VinInn/following{/other_user}","gists_url":"https://api.github.com/users/VinInn/gists{/gist_id}","starred_url":"https://api.github.com/users/VinInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VinInn/subscriptions","organizations_url":"https://api.github.com/users/VinInn/orgs","repos_url":"https://api.github.com/users/VinInn/repos","events_url":"https://api.github.com/users/VinInn/events{/privacy}","received_events_url":"https://api.github.com/users/VinInn/received_events","type":"User","site_admin":false},"body":"short cut.\r\ncan be an assert or an exception. It should never go through this code...\r\nWill transform in one of those later (Actually the whole method is supposed to go away once the SeedingLayerSetsHits migration is over.)\r\n","created_at":"2014-03-19T07:26:37Z","updated_at":"2014-03-19T07:26:37Z","html_url":"https://github.com/cms-sw/cmssw/pull/2884#discussion_r10739159","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/2884","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/10739159"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/2884#discussion_r10739159"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/2884"}}}}