GitHub PullRequestReviewCommentEvent at 2014-06-09 14:41:39
Repository: juju-gui
Actor: hatched
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/13543550","id":13543550,"diff_hunk":"@@ -57,10 +66,99 @@ YUI.add('browser-cache', function(Y) {\n     set: function(key, data) {\n       this._storage[key] = Y.clone(data);\n       return this._storage[key];\n-    }\n+    },\n+\n+    /**\n+      Updates the internal charm model cache.\n+\n+      @method updateEntityList\n+      @param {Object} entityList Either a single charm/bundle model or an object\n+        of models from the charmstore transformed results.\n+    */\n+    updateEntityList: function(entityList) {\n+      // Check to see if this is a single charm model or not\n+      if (entityList instanceof Y.Model) {\n+        this._storage._entities.add(entityList);\n+      } else {\n+        Object.keys(entityList).forEach(function(key) {","path":"app/utils/cache.js","position":40,"original_position":40,"commit_id":"b37a7d86de720add7d085ecc65a87b775462b153","original_commit_id":"b37a7d86de720add7d085ecc65a87b775462b153","user":{"login":"hatched","id":532033,"avatar_url":"https://avatars.githubusercontent.com/u/532033?","gravatar_id":"e95b5dccab0d75eadaccfe04bfd7ad59","url":"https://api.github.com/users/hatched","html_url":"https://github.com/hatched","followers_url":"https://api.github.com/users/hatched/followers","following_url":"https://api.github.com/users/hatched/following{/other_user}","gists_url":"https://api.github.com/users/hatched/gists{/gist_id}","starred_url":"https://api.github.com/users/hatched/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatched/subscriptions","organizations_url":"https://api.github.com/users/hatched/orgs","repos_url":"https://api.github.com/users/hatched/repos","events_url":"https://api.github.com/users/hatched/events{/privacy}","received_events_url":"https://api.github.com/users/hatched/received_events","type":"User","site_admin":false},"body":"Now that you mention it I think I might be able to pass the array format from charmworld in, I'll investigate. ","created_at":"2014-06-09T14:41:39Z","updated_at":"2014-06-09T14:41:39Z","html_url":"https://github.com/juju/juju-gui/pull/372#discussion_r13543550","pull_request_url":"https://api.github.com/repos/juju/juju-gui/pulls/372","_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/13543550"},"html":{"href":"https://github.com/juju/juju-gui/pull/372#discussion_r13543550"},"pull_request":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/372"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/372","id":16845466,"html_url":"https://github.com/juju/juju-gui/pull/372","diff_url":"https://github.com/juju/juju-gui/pull/372.diff","patch_url":"https://github.com/juju/juju-gui/pull/372.patch","issue_url":"https://api.github.com/repos/juju/juju-gui/issues/372","number":372,"state":"open","title":"WIP: Hook cache up to the charmbrowser and charm details views ","user":{"login":"hatched","id":532033,"avatar_url":"https://avatars.githubusercontent.com/u/532033?","gravatar_id":"e95b5dccab0d75eadaccfe04bfd7ad59","url":"https://api.github.com/users/hatched","html_url":"https://github.com/hatched","followers_url":"https://api.github.com/users/hatched/followers","following_url":"https://api.github.com/users/hatched/following{/other_user}","gists_url":"https://api.github.com/users/hatched/gists{/gist_id}","starred_url":"https://api.github.com/users/hatched/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatched/subscriptions","organizations_url":"https://api.github.com/users/hatched/orgs","repos_url":"https://api.github.com/users/hatched/repos","events_url":"https://api.github.com/users/hatched/events{/privacy}","received_events_url":"https://api.github.com/users/hatched/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-06T22:11:11Z","updated_at":"2014-06-09T14:41:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d44ecfaa1471127b0436b2b667cf6d295fff132d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju-gui/pulls/372/commits","review_comments_url":"https://api.github.com/repos/juju/juju-gui/pulls/372/comments","review_comment_url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju-gui/issues/372/comments","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/b37a7d86de720add7d085ecc65a87b775462b153","head":{"label":"hatched:cache-charmbrowser-requests","ref":"cache-charmbrowser-requests","sha":"b37a7d86de720add7d085ecc65a87b775462b153","user":{"login":"hatched","id":532033,"avatar_url":"https://avatars.githubusercontent.com/u/532033?","gravatar_id":"e95b5dccab0d75eadaccfe04bfd7ad59","url":"https://api.github.com/users/hatched","html_url":"https://github.com/hatched","followers_url":"https://api.github.com/users/hatched/followers","following_url":"https://api.github.com/users/hatched/following{/other_user}","gists_url":"https://api.github.com/users/hatched/gists{/gist_id}","starred_url":"https://api.github.com/users/hatched/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatched/subscriptions","organizations_url":"https://api.github.com/users/hatched/orgs","repos_url":"https://api.github.com/users/hatched/repos","events_url":"https://api.github.com/users/hatched/events{/privacy}","received_events_url":"https://api.github.com/users/hatched/received_events","type":"User","site_admin":false},"repo":{"id":14962756,"name":"juju-gui","full_name":"hatched/juju-gui","owner":{"login":"hatched","id":532033,"avatar_url":"https://avatars.githubusercontent.com/u/532033?","gravatar_id":"e95b5dccab0d75eadaccfe04bfd7ad59","url":"https://api.github.com/users/hatched","html_url":"https://github.com/hatched","followers_url":"https://api.github.com/users/hatched/followers","following_url":"https://api.github.com/users/hatched/following{/other_user}","gists_url":"https://api.github.com/users/hatched/gists{/gist_id}","starred_url":"https://api.github.com/users/hatched/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatched/subscriptions","organizations_url":"https://api.github.com/users/hatched/orgs","repos_url":"https://api.github.com/users/hatched/repos","events_url":"https://api.github.com/users/hatched/events{/privacy}","received_events_url":"https://api.github.com/users/hatched/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hatched/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":true,"url":"https://api.github.com/repos/hatched/juju-gui","forks_url":"https://api.github.com/repos/hatched/juju-gui/forks","keys_url":"https://api.github.com/repos/hatched/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hatched/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hatched/juju-gui/teams","hooks_url":"https://api.github.com/repos/hatched/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/hatched/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/hatched/juju-gui/events","assignees_url":"https://api.github.com/repos/hatched/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/hatched/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/hatched/juju-gui/tags","blobs_url":"https://api.github.com/repos/hatched/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hatched/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hatched/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/hatched/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hatched/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/hatched/juju-gui/languages","stargazers_url":"https://api.github.com/repos/hatched/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/hatched/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/hatched/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/hatched/juju-gui/subscription","commits_url":"https://api.github.com/repos/hatched/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/hatched/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/hatched/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/hatched/juju-gui/issues/comments/{number}","contents_url":"https://api.github.com/repos/hatched/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/hatched/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hatched/juju-gui/merges","archive_url":"https://api.github.com/repos/hatched/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hatched/juju-gui/downloads","issues_url":"https://api.github.com/repos/hatched/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/hatched/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/hatched/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/hatched/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hatched/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/hatched/juju-gui/releases{/id}","created_at":"2013-12-05T18:57:16Z","updated_at":"2014-06-06T22:11:11Z","pushed_at":"2014-06-06T22:09:10Z","git_url":"git://github.com/hatched/juju-gui.git","ssh_url":"git@github.com:hatched/juju-gui.git","clone_url":"https://github.com/hatched/juju-gui.git","svn_url":"https://github.com/hatched/juju-gui","homepage":null,"size":100968,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:develop","ref":"develop","sha":"c875b806031a0851850452df5aab038573e3b3de","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":14960387,"name":"juju-gui","full_name":"juju/juju-gui","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":false,"url":"https://api.github.com/repos/juju/juju-gui","forks_url":"https://api.github.com/repos/juju/juju-gui/forks","keys_url":"https://api.github.com/repos/juju/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju-gui/teams","hooks_url":"https://api.github.com/repos/juju/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/juju/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju-gui/events","assignees_url":"https://api.github.com/repos/juju/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju-gui/tags","blobs_url":"https://api.github.com/repos/juju/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju-gui/languages","stargazers_url":"https://api.github.com/repos/juju/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/juju/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/juju/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/juju/juju-gui/subscription","commits_url":"https://api.github.com/repos/juju/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju-gui/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju-gui/merges","archive_url":"https://api.github.com/repos/juju/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju-gui/downloads","issues_url":"https://api.github.com/repos/juju/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju-gui/releases{/id}","created_at":"2013-12-05T17:15:48Z","updated_at":"2014-06-06T18:51:56Z","pushed_at":"2014-06-06T18:51:56Z","git_url":"git://github.com/juju/juju-gui.git","ssh_url":"git@github.com:juju/juju-gui.git","clone_url":"https://github.com/juju/juju-gui.git","svn_url":"https://github.com/juju/juju-gui","homepage":null,"size":105845,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":26,"mirror_url":null,"open_issues_count":2,"forks":26,"open_issues":2,"watchers":25,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/372"},"html":{"href":"https://github.com/juju/juju-gui/pull/372"},"issue":{"href":"https://api.github.com/repos/juju/juju-gui/issues/372"},"comments":{"href":"https://api.github.com/repos/juju/juju-gui/issues/372/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/372/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/372/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju-gui/statuses/b37a7d86de720add7d085ecc65a87b775462b153"}}}}