GitHub PullRequestReviewCommentEvent at 2014-08-15 15:23:15
Repository: pdf.js
Actor: Snuffleupagus
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/16297508","id":16297508,"diff_hunk":"@@ -46,6 +46,7 @@ var TextLayerBuilder = (function TextLayerBuilderClosure() {\n     this.isViewerInPresentationMode = options.isViewerInPresentationMode;\n     this.textDivs = [];\n     this.findController = options.findController || null;\n+    this.debugFonts = options.debugFonts;","path":"web/text_layer_builder.js","position":4,"original_position":4,"commit_id":"99d554144f6211e1ee4bd452d8d206b0d29fc192","original_commit_id":"99d554144f6211e1ee4bd452d8d206b0d29fc192","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=2","gravatar_id":"e05382aa67ec592c3eb32e9cd9edd65e","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"body":"Should we have `|| null` at the end of this line too?","created_at":"2014-08-15T15:23:15Z","updated_at":"2014-08-15T15:23:15Z","html_url":"https://github.com/mozilla/pdf.js/pull/5193#discussion_r16297508","pull_request_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/5193","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/16297508"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/5193#discussion_r16297508"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/5193"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/5193","id":19847201,"html_url":"https://github.com/mozilla/pdf.js/pull/5193","diff_url":"https://github.com/mozilla/pdf.js/pull/5193.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/5193.patch","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5193","number":5193,"state":"open","locked":false,"title":"Only use data-font-name attributes when necessary.","user":{"login":"nnethercote","id":1940286,"avatar_url":"https://avatars.githubusercontent.com/u/1940286?v=2","gravatar_id":"bf26ca64c4f7f6337cd3bbda3a33f166","url":"https://api.github.com/users/nnethercote","html_url":"https://github.com/nnethercote","followers_url":"https://api.github.com/users/nnethercote/followers","following_url":"https://api.github.com/users/nnethercote/following{/other_user}","gists_url":"https://api.github.com/users/nnethercote/gists{/gist_id}","starred_url":"https://api.github.com/users/nnethercote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnethercote/subscriptions","organizations_url":"https://api.github.com/users/nnethercote/orgs","repos_url":"https://api.github.com/users/nnethercote/repos","events_url":"https://api.github.com/users/nnethercote/events{/privacy}","received_events_url":"https://api.github.com/users/nnethercote/received_events","type":"User","site_admin":false},"body":"The data-font-name attribute of textLayer divs are only used by the Font\r\nInspector. This change omits them when Font Inspector is disabled.","created_at":"2014-08-15T14:39:54Z","updated_at":"2014-08-15T15:23:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bd2c53ed5af01ba624ae993daa9cdcf611d7aa0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/5193/commits","review_comments_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/5193/comments","review_comment_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5193/comments","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/99d554144f6211e1ee4bd452d8d206b0d29fc192","head":{"label":"nnethercote:data-font-name","ref":"data-font-name","sha":"99d554144f6211e1ee4bd452d8d206b0d29fc192","user":{"login":"nnethercote","id":1940286,"avatar_url":"https://avatars.githubusercontent.com/u/1940286?v=2","gravatar_id":"bf26ca64c4f7f6337cd3bbda3a33f166","url":"https://api.github.com/users/nnethercote","html_url":"https://github.com/nnethercote","followers_url":"https://api.github.com/users/nnethercote/followers","following_url":"https://api.github.com/users/nnethercote/following{/other_user}","gists_url":"https://api.github.com/users/nnethercote/gists{/gist_id}","starred_url":"https://api.github.com/users/nnethercote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnethercote/subscriptions","organizations_url":"https://api.github.com/users/nnethercote/orgs","repos_url":"https://api.github.com/users/nnethercote/repos","events_url":"https://api.github.com/users/nnethercote/events{/privacy}","received_events_url":"https://api.github.com/users/nnethercote/received_events","type":"User","site_admin":false},"repo":{"id":15978946,"name":"pdf.js","full_name":"nnethercote/pdf.js","owner":{"login":"nnethercote","id":1940286,"avatar_url":"https://avatars.githubusercontent.com/u/1940286?v=2","gravatar_id":"bf26ca64c4f7f6337cd3bbda3a33f166","url":"https://api.github.com/users/nnethercote","html_url":"https://github.com/nnethercote","followers_url":"https://api.github.com/users/nnethercote/followers","following_url":"https://api.github.com/users/nnethercote/following{/other_user}","gists_url":"https://api.github.com/users/nnethercote/gists{/gist_id}","starred_url":"https://api.github.com/users/nnethercote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnethercote/subscriptions","organizations_url":"https://api.github.com/users/nnethercote/orgs","repos_url":"https://api.github.com/users/nnethercote/repos","events_url":"https://api.github.com/users/nnethercote/events{/privacy}","received_events_url":"https://api.github.com/users/nnethercote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nnethercote/pdf.js","description":"PDF Reader in JavaScript","fork":true,"url":"https://api.github.com/repos/nnethercote/pdf.js","forks_url":"https://api.github.com/repos/nnethercote/pdf.js/forks","keys_url":"https://api.github.com/repos/nnethercote/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nnethercote/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nnethercote/pdf.js/teams","hooks_url":"https://api.github.com/repos/nnethercote/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/nnethercote/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/nnethercote/pdf.js/events","assignees_url":"https://api.github.com/repos/nnethercote/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/nnethercote/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/nnethercote/pdf.js/tags","blobs_url":"https://api.github.com/repos/nnethercote/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nnethercote/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nnethercote/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nnethercote/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nnethercote/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/nnethercote/pdf.js/languages","stargazers_url":"https://api.github.com/repos/nnethercote/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/nnethercote/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/nnethercote/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/nnethercote/pdf.js/subscription","commits_url":"https://api.github.com/repos/nnethercote/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nnethercote/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nnethercote/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nnethercote/pdf.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/nnethercote/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/nnethercote/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nnethercote/pdf.js/merges","archive_url":"https://api.github.com/repos/nnethercote/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nnethercote/pdf.js/downloads","issues_url":"https://api.github.com/repos/nnethercote/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/nnethercote/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/nnethercote/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/nnethercote/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nnethercote/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/nnethercote/pdf.js/releases{/id}","created_at":"2014-01-16T19:42:51Z","updated_at":"2014-06-26T01:46:17Z","pushed_at":"2014-08-15T15:19:09Z","git_url":"git://github.com/nnethercote/pdf.js.git","ssh_url":"git@github.com:nnethercote/pdf.js.git","clone_url":"https://github.com/nnethercote/pdf.js.git","svn_url":"https://github.com/nnethercote/pdf.js","homepage":"","size":38634,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"5eb6a353d98b24a36a6d138c554752ef8873b70e","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1663468,"name":"pdf.js","full_name":"mozilla/pdf.js","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/pdf.js","description":"PDF Reader in JavaScript","fork":false,"url":"https://api.github.com/repos/mozilla/pdf.js","forks_url":"https://api.github.com/repos/mozilla/pdf.js/forks","keys_url":"https://api.github.com/repos/mozilla/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pdf.js/teams","hooks_url":"https://api.github.com/repos/mozilla/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pdf.js/events","assignees_url":"https://api.github.com/repos/mozilla/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pdf.js/tags","blobs_url":"https://api.github.com/repos/mozilla/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pdf.js/languages","stargazers_url":"https://api.github.com/repos/mozilla/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pdf.js/subscription","commits_url":"https://api.github.com/repos/mozilla/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pdf.js/merges","archive_url":"https://api.github.com/repos/mozilla/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pdf.js/downloads","issues_url":"https://api.github.com/repos/mozilla/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pdf.js/releases{/id}","created_at":"2011-04-26T06:32:03Z","updated_at":"2014-08-15T13:42:52Z","pushed_at":"2014-08-15T15:21:32Z","git_url":"git://github.com/mozilla/pdf.js.git","ssh_url":"git@github.com:mozilla/pdf.js.git","clone_url":"https://github.com/mozilla/pdf.js.git","svn_url":"https://github.com/mozilla/pdf.js","homepage":"","size":115958,"stargazers_count":9403,"watchers_count":9403,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1999,"mirror_url":null,"open_issues_count":413,"forks":1999,"open_issues":413,"watchers":9403,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/5193"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/5193"},"issue":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/5193"},"comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/5193/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/5193/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/5193/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pdf.js/statuses/99d554144f6211e1ee4bd452d8d206b0d29fc192"}}}}