GitHub PullRequestReviewCommentEvent at 2014-05-06 23:42:20
Repository: biom-format
Actor: adamrp
Payload: {"comment":{"url":"https://api.github.com/repos/biocore/biom-format/pulls/comments/12355807","id":12355807,"diff_hunk":"@@ -606,15 +606,32 @@ def copy(self):\n                               self.observation_ids[:], self.sample_metadata,\n                               self.observation_metadata, self.table_id)\n \n-    def iter_sample_data(self):\n-        \"\"\"Yields sample values\"\"\"\n-        for samp_v in self._iter_samp():\n-            yield self._to_dense(samp_v)\n+    def iter_data(self, axis='sample'):\n+        \"\"\"Yields axis values\n \n-    def iter_observation_data(self):\n-        \"\"\"Yields observation values\"\"\"\n-        for obs_v in self._iter_obs():\n-            yield self._to_dense(obs_v)\n+        Parameters\n+        ----------\n+        axis: 'sample' or 'observation'\n+            axis to iterate over\n+\n+        Returns\n+        -------\n+        generator\n+            yields of values for each value in 'axis'","path":"biom/table.py","position":36,"original_position":36,"commit_id":"be573ff13547278761547b506edff5a79d73c030","original_commit_id":"be573ff13547278761547b506edff5a79d73c030","user":{"login":"adamrp","id":2574407,"avatar_url":"https://avatars.githubusercontent.com/u/2574407?","gravatar_id":"f02990b66a519545b89fb0357d4b4bda","url":"https://api.github.com/users/adamrp","html_url":"https://github.com/adamrp","followers_url":"https://api.github.com/users/adamrp/followers","following_url":"https://api.github.com/users/adamrp/following{/other_user}","gists_url":"https://api.github.com/users/adamrp/gists{/gist_id}","starred_url":"https://api.github.com/users/adamrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamrp/subscriptions","organizations_url":"https://api.github.com/users/adamrp/orgs","repos_url":"https://api.github.com/users/adamrp/repos","events_url":"https://api.github.com/users/adamrp/events{/privacy}","received_events_url":"https://api.github.com/users/adamrp/received_events","type":"User","site_admin":false},"body":"I think you accidentally a word","created_at":"2014-05-06T23:42:20Z","updated_at":"2014-05-06T23:42:20Z","html_url":"https://github.com/biocore/biom-format/pull/330#discussion_r12355807","pull_request_url":"https://api.github.com/repos/biocore/biom-format/pulls/330","_links":{"self":{"href":"https://api.github.com/repos/biocore/biom-format/pulls/comments/12355807"},"html":{"href":"https://github.com/biocore/biom-format/pull/330#discussion_r12355807"},"pull_request":{"href":"https://api.github.com/repos/biocore/biom-format/pulls/330"}}}}