GitHub PullRequestEvent at 2014-09-21 19:15:45
Repository: api-pagination
Actor: davidcelis
Payload: {"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/davidcelis/api-pagination/pulls/13","id":17207302,"html_url":"https://github.com/davidcelis/api-pagination/pull/13","diff_url":"https://github.com/davidcelis/api-pagination/pull/13.diff","patch_url":"https://github.com/davidcelis/api-pagination/pull/13.patch","issue_url":"https://api.github.com/repos/davidcelis/api-pagination/issues/13","number":13,"state":"closed","locked":false,"title":"Enable options for paginate_with and allow custom serializers","user":{"login":"mattvanhorn","id":20461,"avatar_url":"https://avatars.githubusercontent.com/u/20461?v=2","gravatar_id":"985ff04dc441ad87b0cefcd31823575d","url":"https://api.github.com/users/mattvanhorn","html_url":"https://github.com/mattvanhorn","followers_url":"https://api.github.com/users/mattvanhorn/followers","following_url":"https://api.github.com/users/mattvanhorn/following{/other_user}","gists_url":"https://api.github.com/users/mattvanhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/mattvanhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattvanhorn/subscriptions","organizations_url":"https://api.github.com/users/mattvanhorn/orgs","repos_url":"https://api.github.com/users/mattvanhorn/repos","events_url":"https://api.github.com/users/mattvanhorn/events{/privacy}","received_events_url":"https://api.github.com/users/mattvanhorn/received_events","type":"User","site_admin":false},"body":"Hey David, \r\nI made these changes so I could get this to work with something I'm doing using the Oat gem (https://github.com/ismasan/oat) emitting JSON-API.\r\n\r\nexample of use here: https://gist.github.com/mattvanhorn/73326e5ec984f123f2b0\r\n\r\nIn that example, a CampaignsSerializer instance responds to #to_json, and outputs a JSON-API formatted body. But it does not respond to the paginator methods very easily. I tried a lot of approaches to allow this, and I like this one more than the others,  (for example, injecting a serializer.)\r\n\r\nWhat do you think?","created_at":"2014-06-16T22:40:36Z","updated_at":"2014-09-21T19:15:45Z","closed_at":"2014-09-21T19:15:45Z","merged_at":null,"merge_commit_sha":"a43b178dabbb01b8289f899d737e319c09430a7f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/davidcelis/api-pagination/pulls/13/commits","review_comments_url":"https://api.github.com/repos/davidcelis/api-pagination/pulls/13/comments","review_comment_url":"https://api.github.com/repos/davidcelis/api-pagination/pulls/comments/{number}","comments_url":"https://api.github.com/repos/davidcelis/api-pagination/issues/13/comments","statuses_url":"https://api.github.com/repos/davidcelis/api-pagination/statuses/8f7d09c1773bfc611def60e0c1bfd46579bd8ec2","head":{"label":"mattvanhorn:master","ref":"master","sha":"8f7d09c1773bfc611def60e0c1bfd46579bd8ec2","user":{"login":"mattvanhorn","id":20461,"avatar_url":"https://avatars.githubusercontent.com/u/20461?v=2","gravatar_id":"985ff04dc441ad87b0cefcd31823575d","url":"https://api.github.com/users/mattvanhorn","html_url":"https://github.com/mattvanhorn","followers_url":"https://api.github.com/users/mattvanhorn/followers","following_url":"https://api.github.com/users/mattvanhorn/following{/other_user}","gists_url":"https://api.github.com/users/mattvanhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/mattvanhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattvanhorn/subscriptions","organizations_url":"https://api.github.com/users/mattvanhorn/orgs","repos_url":"https://api.github.com/users/mattvanhorn/repos","events_url":"https://api.github.com/users/mattvanhorn/events{/privacy}","received_events_url":"https://api.github.com/users/mattvanhorn/received_events","type":"User","site_admin":false},"repo":{"id":20897095,"name":"api-pagination","full_name":"mattvanhorn/api-pagination","owner":{"login":"mattvanhorn","id":20461,"avatar_url":"https://avatars.githubusercontent.com/u/20461?v=2","gravatar_id":"985ff04dc441ad87b0cefcd31823575d","url":"https://api.github.com/users/mattvanhorn","html_url":"https://github.com/mattvanhorn","followers_url":"https://api.github.com/users/mattvanhorn/followers","following_url":"https://api.github.com/users/mattvanhorn/following{/other_user}","gists_url":"https://api.github.com/users/mattvanhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/mattvanhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattvanhorn/subscriptions","organizations_url":"https://api.github.com/users/mattvanhorn/orgs","repos_url":"https://api.github.com/users/mattvanhorn/repos","events_url":"https://api.github.com/users/mattvanhorn/events{/privacy}","received_events_url":"https://api.github.com/users/mattvanhorn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattvanhorn/api-pagination","description":"Link header pagination for Rails and Grape APIs.","fork":true,"url":"https://api.github.com/repos/mattvanhorn/api-pagination","forks_url":"https://api.github.com/repos/mattvanhorn/api-pagination/forks","keys_url":"https://api.github.com/repos/mattvanhorn/api-pagination/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattvanhorn/api-pagination/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattvanhorn/api-pagination/teams","hooks_url":"https://api.github.com/repos/mattvanhorn/api-pagination/hooks","issue_events_url":"https://api.github.com/repos/mattvanhorn/api-pagination/issues/events{/number}","events_url":"https://api.github.com/repos/mattvanhorn/api-pagination/events","assignees_url":"https://api.github.com/repos/mattvanhorn/api-pagination/assignees{/user}","branches_url":"https://api.github.com/repos/mattvanhorn/api-pagination/branches{/branch}","tags_url":"https://api.github.com/repos/mattvanhorn/api-pagination/tags","blobs_url":"https://api.github.com/repos/mattvanhorn/api-pagination/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattvanhorn/api-pagination/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattvanhorn/api-pagination/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattvanhorn/api-pagination/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattvanhorn/api-pagination/statuses/{sha}","languages_url":"https://api.github.com/repos/mattvanhorn/api-pagination/languages","stargazers_url":"https://api.github.com/repos/mattvanhorn/api-pagination/stargazers","contributors_url":"https://api.github.com/repos/mattvanhorn/api-pagination/contributors","subscribers_url":"https://api.github.com/repos/mattvanhorn/api-pagination/subscribers","subscription_url":"https://api.github.com/repos/mattvanhorn/api-pagination/subscription","commits_url":"https://api.github.com/repos/mattvanhorn/api-pagination/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattvanhorn/api-pagination/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattvanhorn/api-pagination/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattvanhorn/api-pagination/issues/comments/{number}","contents_url":"https://api.github.com/repos/mattvanhorn/api-pagination/contents/{+path}","compare_url":"https://api.github.com/repos/mattvanhorn/api-pagination/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattvanhorn/api-pagination/merges","archive_url":"https://api.github.com/repos/mattvanhorn/api-pagination/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattvanhorn/api-pagination/downloads","issues_url":"https://api.github.com/repos/mattvanhorn/api-pagination/issues{/number}","pulls_url":"https://api.github.com/repos/mattvanhorn/api-pagination/pulls{/number}","milestones_url":"https://api.github.com/repos/mattvanhorn/api-pagination/milestones{/number}","notifications_url":"https://api.github.com/repos/mattvanhorn/api-pagination/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattvanhorn/api-pagination/labels{/name}","releases_url":"https://api.github.com/repos/mattvanhorn/api-pagination/releases{/id}","created_at":"2014-06-16T19:08:05Z","updated_at":"2014-06-16T22:40:37Z","pushed_at":"2014-06-16T22:30:39Z","git_url":"git://github.com/mattvanhorn/api-pagination.git","ssh_url":"git@github.com:mattvanhorn/api-pagination.git","clone_url":"https://github.com/mattvanhorn/api-pagination.git","svn_url":"https://github.com/mattvanhorn/api-pagination","homepage":"","size":179,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"davidcelis:master","ref":"master","sha":"3e0e1bf96714fe606931b929683ecf71009fafae","user":{"login":"davidcelis","id":36873,"avatar_url":"https://avatars.githubusercontent.com/u/36873?v=2","gravatar_id":"9b0144a16ba125a94460c5d45f07efb9","url":"https://api.github.com/users/davidcelis","html_url":"https://github.com/davidcelis","followers_url":"https://api.github.com/users/davidcelis/followers","following_url":"https://api.github.com/users/davidcelis/following{/other_user}","gists_url":"https://api.github.com/users/davidcelis/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcelis/subscriptions","organizations_url":"https://api.github.com/users/davidcelis/orgs","repos_url":"https://api.github.com/users/davidcelis/repos","events_url":"https://api.github.com/users/davidcelis/events{/privacy}","received_events_url":"https://api.github.com/users/davidcelis/received_events","type":"User","site_admin":false},"repo":{"id":11061183,"name":"api-pagination","full_name":"davidcelis/api-pagination","owner":{"login":"davidcelis","id":36873,"avatar_url":"https://avatars.githubusercontent.com/u/36873?v=2","gravatar_id":"9b0144a16ba125a94460c5d45f07efb9","url":"https://api.github.com/users/davidcelis","html_url":"https://github.com/davidcelis","followers_url":"https://api.github.com/users/davidcelis/followers","following_url":"https://api.github.com/users/davidcelis/following{/other_user}","gists_url":"https://api.github.com/users/davidcelis/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcelis/subscriptions","organizations_url":"https://api.github.com/users/davidcelis/orgs","repos_url":"https://api.github.com/users/davidcelis/repos","events_url":"https://api.github.com/users/davidcelis/events{/privacy}","received_events_url":"https://api.github.com/users/davidcelis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidcelis/api-pagination","description":"Link header pagination for Rails and Grape APIs.","fork":false,"url":"https://api.github.com/repos/davidcelis/api-pagination","forks_url":"https://api.github.com/repos/davidcelis/api-pagination/forks","keys_url":"https://api.github.com/repos/davidcelis/api-pagination/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidcelis/api-pagination/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidcelis/api-pagination/teams","hooks_url":"https://api.github.com/repos/davidcelis/api-pagination/hooks","issue_events_url":"https://api.github.com/repos/davidcelis/api-pagination/issues/events{/number}","events_url":"https://api.github.com/repos/davidcelis/api-pagination/events","assignees_url":"https://api.github.com/repos/davidcelis/api-pagination/assignees{/user}","branches_url":"https://api.github.com/repos/davidcelis/api-pagination/branches{/branch}","tags_url":"https://api.github.com/repos/davidcelis/api-pagination/tags","blobs_url":"https://api.github.com/repos/davidcelis/api-pagination/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidcelis/api-pagination/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidcelis/api-pagination/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidcelis/api-pagination/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidcelis/api-pagination/statuses/{sha}","languages_url":"https://api.github.com/repos/davidcelis/api-pagination/languages","stargazers_url":"https://api.github.com/repos/davidcelis/api-pagination/stargazers","contributors_url":"https://api.github.com/repos/davidcelis/api-pagination/contributors","subscribers_url":"https://api.github.com/repos/davidcelis/api-pagination/subscribers","subscription_url":"https://api.github.com/repos/davidcelis/api-pagination/subscription","commits_url":"https://api.github.com/repos/davidcelis/api-pagination/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidcelis/api-pagination/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidcelis/api-pagination/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidcelis/api-pagination/issues/comments/{number}","contents_url":"https://api.github.com/repos/davidcelis/api-pagination/contents/{+path}","compare_url":"https://api.github.com/repos/davidcelis/api-pagination/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidcelis/api-pagination/merges","archive_url":"https://api.github.com/repos/davidcelis/api-pagination/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidcelis/api-pagination/downloads","issues_url":"https://api.github.com/repos/davidcelis/api-pagination/issues{/number}","pulls_url":"https://api.github.com/repos/davidcelis/api-pagination/pulls{/number}","milestones_url":"https://api.github.com/repos/davidcelis/api-pagination/milestones{/number}","notifications_url":"https://api.github.com/repos/davidcelis/api-pagination/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidcelis/api-pagination/labels{/name}","releases_url":"https://api.github.com/repos/davidcelis/api-pagination/releases{/id}","created_at":"2013-06-29T23:09:55Z","updated_at":"2014-09-12T22:42:32Z","pushed_at":"2014-09-21T19:15:28Z","git_url":"git://github.com/davidcelis/api-pagination.git","ssh_url":"git@github.com:davidcelis/api-pagination.git","clone_url":"https://github.com/davidcelis/api-pagination.git","svn_url":"https://github.com/davidcelis/api-pagination","homepage":"","size":716,"stargazers_count":106,"watchers_count":106,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":1,"forks":27,"open_issues":1,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/davidcelis/api-pagination/pulls/13"},"html":{"href":"https://github.com/davidcelis/api-pagination/pull/13"},"issue":{"href":"https://api.github.com/repos/davidcelis/api-pagination/issues/13"},"comments":{"href":"https://api.github.com/repos/davidcelis/api-pagination/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/davidcelis/api-pagination/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/davidcelis/api-pagination/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/davidcelis/api-pagination/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/davidcelis/api-pagination/statuses/8f7d09c1773bfc611def60e0c1bfd46579bd8ec2"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":8,"review_comments":0,"commits":2,"additions":156,"deletions":17,"changed_files":7}}