GitHub PullRequestReviewCommentEvent at 2014-06-25 01:48:34
Repository: orcm
Actor: lrrajesh
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/open-mpi/orcm/pulls/comments/14165758","id":14165758,"diff_hunk":"@@ -51,32 +47,40 @@ orcm_sst_orcmsd_component_t mca_sst_orcmsd_component = {\n \n static int component_register(void)\n {\n+    int var_id;\n+    mca_base_component_t *component = & mca_sst_orcmsd_component.super.base_version;\n     mca_sst_orcmsd_component.node_regex = NULL;\n-    (void) mca_base_var_register (\"orcm\", \"orcm\", NULL, \"node_regex\",\n+    var_id =  mca_base_component_var_register (component, \"node_regex\",\n                                \"node_regex of allocated nodes.\",\n                                MCA_BASE_VAR_TYPE_STRING, NULL, 0,\n                                MCA_BASE_VAR_FLAG_INTERNAL,\n                                OPAL_INFO_LVL_9,\n-                               MCA_BASE_VAR_SCOPE_CONSTANT,\n+                               MCA_BASE_VAR_SCOPE_READONLY,\n                                &mca_sst_orcmsd_component.node_regex);\n+    (void) mca_base_var_register_synonym(var_id, \"orcm\", \"orcm\", NULL,","path":"orcm/mca/sst/orcmsd/sst_orcmsd_component.c","position":27,"original_position":27,"commit_id":"b2b4c964a8a4cdb0d92a3005aed4c1a615832466","original_commit_id":"b2b4c964a8a4cdb0d92a3005aed4c1a615832466","user":{"login":"lrrajesh","id":7571286,"avatar_url":"https://avatars.githubusercontent.com/u/7571286?","gravatar_id":"8eec3923952c9ed54571e7869be2f88a","url":"https://api.github.com/users/lrrajesh","html_url":"https://github.com/lrrajesh","followers_url":"https://api.github.com/users/lrrajesh/followers","following_url":"https://api.github.com/users/lrrajesh/following{/other_user}","gists_url":"https://api.github.com/users/lrrajesh/gists{/gist_id}","starred_url":"https://api.github.com/users/lrrajesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrrajesh/subscriptions","organizations_url":"https://api.github.com/users/lrrajesh/orgs","repos_url":"https://api.github.com/users/lrrajesh/repos","events_url":"https://api.github.com/users/lrrajesh/events{/privacy}","received_events_url":"https://api.github.com/users/lrrajesh/received_events","type":"User","site_admin":false},"body":"Synonym gives me a short form of Mac name. It is easy to remember with short name. If you don't like I will remove this.\r\n\r\nSent from my iPhones\r\n\r\nOn Jun 24, 2014, at 6:26 PM, \"rhc54\" <notifications@github.com<mailto:notifications@github.com>> wrote:\r\n\r\n\r\nIn orcm/mca/sst/orcmsd/sst_orcmsd_component.c:\r\n\r\n>                                 &mca_sst_orcmsd_component.node_regex);\r\n> +    (void) mca_base_var_register_synonym(var_id, \"orcm\", \"orcm\", NULL,\r\n\r\n\r\nIs there some reason to create these synonyms? I see nothing wrong with leaving the param as \"sst_orcmsd_node_regex\". It would be more accurate and in keeping with the normal MCA param convention. We only use synonyms for backward compatibility, and that isn't the case here.\r\n\r\n—\r\nReply to this email directly or view it on GitHub<https://github.com/open-mpi/orcm/pull/7/files#r14165356>.","created_at":"2014-06-25T01:48:34Z","updated_at":"2014-06-25T01:48:34Z","html_url":"https://github.com/open-mpi/orcm/pull/7#discussion_r14165758","pull_request_url":"https://api.github.com/repos/open-mpi/orcm/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/open-mpi/orcm/pulls/comments/14165758"},"html":{"href":"https://github.com/open-mpi/orcm/pull/7#discussion_r14165758"},"pull_request":{"href":"https://api.github.com/repos/open-mpi/orcm/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/open-mpi/orcm/pulls/7","id":17567343,"html_url":"https://github.com/open-mpi/orcm/pull/7","diff_url":"https://github.com/open-mpi/orcm/pull/7.diff","patch_url":"https://github.com/open-mpi/orcm/pull/7.patch","issue_url":"https://api.github.com/repos/open-mpi/orcm/issues/7","number":7,"state":"open","title":"klocwork, help file changes and segfault issue resolved in job launch code.","user":{"login":"lrrajesh","id":7571286,"avatar_url":"https://avatars.githubusercontent.com/u/7571286?","gravatar_id":"8eec3923952c9ed54571e7869be2f88a","url":"https://api.github.com/users/lrrajesh","html_url":"https://github.com/lrrajesh","followers_url":"https://api.github.com/users/lrrajesh/followers","following_url":"https://api.github.com/users/lrrajesh/following{/other_user}","gists_url":"https://api.github.com/users/lrrajesh/gists{/gist_id}","starred_url":"https://api.github.com/users/lrrajesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrrajesh/subscriptions","organizations_url":"https://api.github.com/users/lrrajesh/orgs","repos_url":"https://api.github.com/users/lrrajesh/repos","events_url":"https://api.github.com/users/lrrajesh/events{/privacy}","received_events_url":"https://api.github.com/users/lrrajesh/received_events","type":"User","site_admin":false},"body":"Following are the changes in this branch\r\n\r\n1) klocwork reported issues in job launch code (orun.c, orcmsd.c, sst_orcmsd.c)\r\n2) Changes related to help file lookup for orcmsd tool\r\n3) Fixing a segfault issue  with the mca destructor for the newly added mca parameter in the sst_orcmsd_components file (orcm_node_regex, orcm_base_jobid, orcm_base_vpid).","created_at":"2014-06-25T01:12:12Z","updated_at":"2014-06-25T01:48:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5dd0d319ddf628b28011a92839175b2c6794a7c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/open-mpi/orcm/pulls/7/commits","review_comments_url":"https://api.github.com/repos/open-mpi/orcm/pulls/7/comments","review_comment_url":"https://api.github.com/repos/open-mpi/orcm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/open-mpi/orcm/issues/7/comments","statuses_url":"https://api.github.com/repos/open-mpi/orcm/statuses/b2b4c964a8a4cdb0d92a3005aed4c1a615832466","head":{"label":"lrrajesh:master","ref":"master","sha":"b2b4c964a8a4cdb0d92a3005aed4c1a615832466","user":{"login":"lrrajesh","id":7571286,"avatar_url":"https://avatars.githubusercontent.com/u/7571286?","gravatar_id":"8eec3923952c9ed54571e7869be2f88a","url":"https://api.github.com/users/lrrajesh","html_url":"https://github.com/lrrajesh","followers_url":"https://api.github.com/users/lrrajesh/followers","following_url":"https://api.github.com/users/lrrajesh/following{/other_user}","gists_url":"https://api.github.com/users/lrrajesh/gists{/gist_id}","starred_url":"https://api.github.com/users/lrrajesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrrajesh/subscriptions","organizations_url":"https://api.github.com/users/lrrajesh/orgs","repos_url":"https://api.github.com/users/lrrajesh/repos","events_url":"https://api.github.com/users/lrrajesh/events{/privacy}","received_events_url":"https://api.github.com/users/lrrajesh/received_events","type":"User","site_admin":false},"repo":{"id":20452146,"name":"orcm","full_name":"lrrajesh/orcm","owner":{"login":"lrrajesh","id":7571286,"avatar_url":"https://avatars.githubusercontent.com/u/7571286?","gravatar_id":"8eec3923952c9ed54571e7869be2f88a","url":"https://api.github.com/users/lrrajesh","html_url":"https://github.com/lrrajesh","followers_url":"https://api.github.com/users/lrrajesh/followers","following_url":"https://api.github.com/users/lrrajesh/following{/other_user}","gists_url":"https://api.github.com/users/lrrajesh/gists{/gist_id}","starred_url":"https://api.github.com/users/lrrajesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrrajesh/subscriptions","organizations_url":"https://api.github.com/users/lrrajesh/orgs","repos_url":"https://api.github.com/users/lrrajesh/repos","events_url":"https://api.github.com/users/lrrajesh/events{/privacy}","received_events_url":"https://api.github.com/users/lrrajesh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lrrajesh/orcm","description":"Open Resilient Cluster Manager","fork":true,"url":"https://api.github.com/repos/lrrajesh/orcm","forks_url":"https://api.github.com/repos/lrrajesh/orcm/forks","keys_url":"https://api.github.com/repos/lrrajesh/orcm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lrrajesh/orcm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lrrajesh/orcm/teams","hooks_url":"https://api.github.com/repos/lrrajesh/orcm/hooks","issue_events_url":"https://api.github.com/repos/lrrajesh/orcm/issues/events{/number}","events_url":"https://api.github.com/repos/lrrajesh/orcm/events","assignees_url":"https://api.github.com/repos/lrrajesh/orcm/assignees{/user}","branches_url":"https://api.github.com/repos/lrrajesh/orcm/branches{/branch}","tags_url":"https://api.github.com/repos/lrrajesh/orcm/tags","blobs_url":"https://api.github.com/repos/lrrajesh/orcm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lrrajesh/orcm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lrrajesh/orcm/git/refs{/sha}","trees_url":"https://api.github.com/repos/lrrajesh/orcm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lrrajesh/orcm/statuses/{sha}","languages_url":"https://api.github.com/repos/lrrajesh/orcm/languages","stargazers_url":"https://api.github.com/repos/lrrajesh/orcm/stargazers","contributors_url":"https://api.github.com/repos/lrrajesh/orcm/contributors","subscribers_url":"https://api.github.com/repos/lrrajesh/orcm/subscribers","subscription_url":"https://api.github.com/repos/lrrajesh/orcm/subscription","commits_url":"https://api.github.com/repos/lrrajesh/orcm/commits{/sha}","git_commits_url":"https://api.github.com/repos/lrrajesh/orcm/git/commits{/sha}","comments_url":"https://api.github.com/repos/lrrajesh/orcm/comments{/number}","issue_comment_url":"https://api.github.com/repos/lrrajesh/orcm/issues/comments/{number}","contents_url":"https://api.github.com/repos/lrrajesh/orcm/contents/{+path}","compare_url":"https://api.github.com/repos/lrrajesh/orcm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lrrajesh/orcm/merges","archive_url":"https://api.github.com/repos/lrrajesh/orcm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lrrajesh/orcm/downloads","issues_url":"https://api.github.com/repos/lrrajesh/orcm/issues{/number}","pulls_url":"https://api.github.com/repos/lrrajesh/orcm/pulls{/number}","milestones_url":"https://api.github.com/repos/lrrajesh/orcm/milestones{/number}","notifications_url":"https://api.github.com/repos/lrrajesh/orcm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lrrajesh/orcm/labels{/name}","releases_url":"https://api.github.com/repos/lrrajesh/orcm/releases{/id}","created_at":"2014-06-03T17:21:36Z","updated_at":"2014-06-25T01:12:12Z","pushed_at":"2014-06-25T01:05:42Z","git_url":"git://github.com/lrrajesh/orcm.git","ssh_url":"git@github.com:lrrajesh/orcm.git","clone_url":"https://github.com/lrrajesh/orcm.git","svn_url":"https://github.com/lrrajesh/orcm","homepage":null,"size":5202,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-mpi:master","ref":"master","sha":"4af505f1a99be963ef0fd32b0ad8c041b975ff6c","user":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars.githubusercontent.com/u/2165682?","gravatar_id":null,"url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"repo":{"id":18601405,"name":"orcm","full_name":"open-mpi/orcm","owner":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars.githubusercontent.com/u/2165682?","gravatar_id":null,"url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-mpi/orcm","description":"Open Resilient Cluster Manager","fork":false,"url":"https://api.github.com/repos/open-mpi/orcm","forks_url":"https://api.github.com/repos/open-mpi/orcm/forks","keys_url":"https://api.github.com/repos/open-mpi/orcm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-mpi/orcm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-mpi/orcm/teams","hooks_url":"https://api.github.com/repos/open-mpi/orcm/hooks","issue_events_url":"https://api.github.com/repos/open-mpi/orcm/issues/events{/number}","events_url":"https://api.github.com/repos/open-mpi/orcm/events","assignees_url":"https://api.github.com/repos/open-mpi/orcm/assignees{/user}","branches_url":"https://api.github.com/repos/open-mpi/orcm/branches{/branch}","tags_url":"https://api.github.com/repos/open-mpi/orcm/tags","blobs_url":"https://api.github.com/repos/open-mpi/orcm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-mpi/orcm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-mpi/orcm/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-mpi/orcm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-mpi/orcm/statuses/{sha}","languages_url":"https://api.github.com/repos/open-mpi/orcm/languages","stargazers_url":"https://api.github.com/repos/open-mpi/orcm/stargazers","contributors_url":"https://api.github.com/repos/open-mpi/orcm/contributors","subscribers_url":"https://api.github.com/repos/open-mpi/orcm/subscribers","subscription_url":"https://api.github.com/repos/open-mpi/orcm/subscription","commits_url":"https://api.github.com/repos/open-mpi/orcm/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-mpi/orcm/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-mpi/orcm/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-mpi/orcm/issues/comments/{number}","contents_url":"https://api.github.com/repos/open-mpi/orcm/contents/{+path}","compare_url":"https://api.github.com/repos/open-mpi/orcm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-mpi/orcm/merges","archive_url":"https://api.github.com/repos/open-mpi/orcm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-mpi/orcm/downloads","issues_url":"https://api.github.com/repos/open-mpi/orcm/issues{/number}","pulls_url":"https://api.github.com/repos/open-mpi/orcm/pulls{/number}","milestones_url":"https://api.github.com/repos/open-mpi/orcm/milestones{/number}","notifications_url":"https://api.github.com/repos/open-mpi/orcm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-mpi/orcm/labels{/name}","releases_url":"https://api.github.com/repos/open-mpi/orcm/releases{/id}","created_at":"2014-04-09T14:59:55Z","updated_at":"2014-06-24T18:00:21Z","pushed_at":"2014-06-24T18:00:21Z","git_url":"git://github.com/open-mpi/orcm.git","ssh_url":"git@github.com:open-mpi/orcm.git","clone_url":"https://github.com/open-mpi/orcm.git","svn_url":"https://github.com/open-mpi/orcm","homepage":null,"size":7274,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-mpi/orcm/pulls/7"},"html":{"href":"https://github.com/open-mpi/orcm/pull/7"},"issue":{"href":"https://api.github.com/repos/open-mpi/orcm/issues/7"},"comments":{"href":"https://api.github.com/repos/open-mpi/orcm/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/open-mpi/orcm/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/open-mpi/orcm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/open-mpi/orcm/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/open-mpi/orcm/statuses/b2b4c964a8a4cdb0d92a3005aed4c1a615832466"}}}}