GitHub PullRequestReviewCommentEvent at 2014-12-02 15:19:23
Repository: statsmodels
Actor: jseabold
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/comments/21164570","id":21164570,"diff_hunk":"@@ -1606,12 +1617,16 @@ class OrdinalGEE(GEE):\n         \"    Estimation of ordinal response marginal regression models\\n\"\n         \"    using Generalized Estimating Equations (GEE).\\n\" +\n         _gee_init_doc % {'extra_params': base._missing_param_doc,\n+                         'family_doc': _gee_ordinal_family_doc,\n                          'example': _gee_ordinal_example})\n \n     def __init__(self, endog, exog, groups, time=None, family=None,\n                        cov_struct=None, missing='none', offset=None,\n                        dep_data=None, constraint=None):\n \n+        if family is None:\n+            family = families.Binomial()","path":"statsmodels/genmod/generalized_estimating_equations.py","position":178,"original_position":113,"commit_id":"484edaa0471a1843eaa76be5668a7f76faba5cd2","original_commit_id":"c1cbae17303c8e2d564329b8e7cd1c4d98a720c4","user":{"login":"jseabold","id":296164,"avatar_url":"https://avatars.githubusercontent.com/u/296164?v=3","gravatar_id":"","url":"https://api.github.com/users/jseabold","html_url":"https://github.com/jseabold","followers_url":"https://api.github.com/users/jseabold/followers","following_url":"https://api.github.com/users/jseabold/following{/other_user}","gists_url":"https://api.github.com/users/jseabold/gists{/gist_id}","starred_url":"https://api.github.com/users/jseabold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseabold/subscriptions","organizations_url":"https://api.github.com/users/jseabold/orgs","repos_url":"https://api.github.com/users/jseabold/repos","events_url":"https://api.github.com/users/jseabold/events{/privacy}","received_events_url":"https://api.github.com/users/jseabold/received_events","type":"User","site_admin":false},"body":"If the class instance is mutable, this should be fixed in RLM.","created_at":"2014-12-02T15:19:23Z","updated_at":"2014-12-02T15:19:23Z","html_url":"https://github.com/statsmodels/statsmodels/pull/2053#discussion_r21164570","pull_request_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/2053","_links":{"self":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/comments/21164570"},"html":{"href":"https://github.com/statsmodels/statsmodels/pull/2053#discussion_r21164570"},"pull_request":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/2053"}}},"pull_request":{"url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/2053","id":22989235,"html_url":"https://github.com/statsmodels/statsmodels/pull/2053","diff_url":"https://github.com/statsmodels/statsmodels/pull/2053.diff","patch_url":"https://github.com/statsmodels/statsmodels/pull/2053.patch","issue_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/2053","number":2053,"state":"open","locked":false,"title":"Add NominalGEE and OrdinalGEE to api","user":{"login":"kshedden","id":2666691,"avatar_url":"https://avatars.githubusercontent.com/u/2666691?v=3","gravatar_id":"","url":"https://api.github.com/users/kshedden","html_url":"https://github.com/kshedden","followers_url":"https://api.github.com/users/kshedden/followers","following_url":"https://api.github.com/users/kshedden/following{/other_user}","gists_url":"https://api.github.com/users/kshedden/gists{/gist_id}","starred_url":"https://api.github.com/users/kshedden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshedden/subscriptions","organizations_url":"https://api.github.com/users/kshedden/orgs","repos_url":"https://api.github.com/users/kshedden/repos","events_url":"https://api.github.com/users/kshedden/events{/privacy}","received_events_url":"https://api.github.com/users/kshedden/received_events","type":"User","site_admin":false},"body":"This PR adds NominalGEE and OrdinalGEE to the API.  Some related enhancements are bundled in too, specifically:\r\n\r\n* Privatize the Multinomial and MultinomialLogit classes, make _Multinomial the default family for NominalGEE.  Automate the setting of the number of levels.\r\n\r\n* Make binomial the default family for OrdinalGEE.\r\n\r\n* Docstring changes related to above.","created_at":"2014-10-20T01:31:24Z","updated_at":"2014-12-02T15:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f9592f61f933cea1e95f632450fe9b9776b48ca","assignee":null,"milestone":{"url":"https://api.github.com/repos/statsmodels/statsmodels/milestones/8","labels_url":"https://api.github.com/repos/statsmodels/statsmodels/milestones/8/labels","id":857455,"number":8,"title":"0.6.1","description":null,"creator":{"login":"jseabold","id":296164,"avatar_url":"https://avatars.githubusercontent.com/u/296164?v=3","gravatar_id":"","url":"https://api.github.com/users/jseabold","html_url":"https://github.com/jseabold","followers_url":"https://api.github.com/users/jseabold/followers","following_url":"https://api.github.com/users/jseabold/following{/other_user}","gists_url":"https://api.github.com/users/jseabold/gists{/gist_id}","starred_url":"https://api.github.com/users/jseabold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseabold/subscriptions","organizations_url":"https://api.github.com/users/jseabold/orgs","repos_url":"https://api.github.com/users/jseabold/repos","events_url":"https://api.github.com/users/jseabold/events{/privacy}","received_events_url":"https://api.github.com/users/jseabold/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":6,"state":"open","created_at":"2014-11-07T15:03:56Z","updated_at":"2014-11-24T15:11:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/2053/commits","review_comments_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/2053/comments","review_comment_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/comments/{number}","comments_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/2053/comments","statuses_url":"https://api.github.com/repos/statsmodels/statsmodels/statuses/484edaa0471a1843eaa76be5668a7f76faba5cd2","head":{"label":"kshedden:categorical-gee-api","ref":"categorical-gee-api","sha":"484edaa0471a1843eaa76be5668a7f76faba5cd2","user":{"login":"kshedden","id":2666691,"avatar_url":"https://avatars.githubusercontent.com/u/2666691?v=3","gravatar_id":"","url":"https://api.github.com/users/kshedden","html_url":"https://github.com/kshedden","followers_url":"https://api.github.com/users/kshedden/followers","following_url":"https://api.github.com/users/kshedden/following{/other_user}","gists_url":"https://api.github.com/users/kshedden/gists{/gist_id}","starred_url":"https://api.github.com/users/kshedden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshedden/subscriptions","organizations_url":"https://api.github.com/users/kshedden/orgs","repos_url":"https://api.github.com/users/kshedden/repos","events_url":"https://api.github.com/users/kshedden/events{/privacy}","received_events_url":"https://api.github.com/users/kshedden/received_events","type":"User","site_admin":false},"repo":{"id":15666435,"name":"statsmodels","full_name":"kshedden/statsmodels","owner":{"login":"kshedden","id":2666691,"avatar_url":"https://avatars.githubusercontent.com/u/2666691?v=3","gravatar_id":"","url":"https://api.github.com/users/kshedden","html_url":"https://github.com/kshedden","followers_url":"https://api.github.com/users/kshedden/followers","following_url":"https://api.github.com/users/kshedden/following{/other_user}","gists_url":"https://api.github.com/users/kshedden/gists{/gist_id}","starred_url":"https://api.github.com/users/kshedden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshedden/subscriptions","organizations_url":"https://api.github.com/users/kshedden/orgs","repos_url":"https://api.github.com/users/kshedden/repos","events_url":"https://api.github.com/users/kshedden/events{/privacy}","received_events_url":"https://api.github.com/users/kshedden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kshedden/statsmodels","description":"Statsmodels: statistical modeling and econometrics in Python","fork":true,"url":"https://api.github.com/repos/kshedden/statsmodels","forks_url":"https://api.github.com/repos/kshedden/statsmodels/forks","keys_url":"https://api.github.com/repos/kshedden/statsmodels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kshedden/statsmodels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kshedden/statsmodels/teams","hooks_url":"https://api.github.com/repos/kshedden/statsmodels/hooks","issue_events_url":"https://api.github.com/repos/kshedden/statsmodels/issues/events{/number}","events_url":"https://api.github.com/repos/kshedden/statsmodels/events","assignees_url":"https://api.github.com/repos/kshedden/statsmodels/assignees{/user}","branches_url":"https://api.github.com/repos/kshedden/statsmodels/branches{/branch}","tags_url":"https://api.github.com/repos/kshedden/statsmodels/tags","blobs_url":"https://api.github.com/repos/kshedden/statsmodels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kshedden/statsmodels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kshedden/statsmodels/git/refs{/sha}","trees_url":"https://api.github.com/repos/kshedden/statsmodels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kshedden/statsmodels/statuses/{sha}","languages_url":"https://api.github.com/repos/kshedden/statsmodels/languages","stargazers_url":"https://api.github.com/repos/kshedden/statsmodels/stargazers","contributors_url":"https://api.github.com/repos/kshedden/statsmodels/contributors","subscribers_url":"https://api.github.com/repos/kshedden/statsmodels/subscribers","subscription_url":"https://api.github.com/repos/kshedden/statsmodels/subscription","commits_url":"https://api.github.com/repos/kshedden/statsmodels/commits{/sha}","git_commits_url":"https://api.github.com/repos/kshedden/statsmodels/git/commits{/sha}","comments_url":"https://api.github.com/repos/kshedden/statsmodels/comments{/number}","issue_comment_url":"https://api.github.com/repos/kshedden/statsmodels/issues/comments/{number}","contents_url":"https://api.github.com/repos/kshedden/statsmodels/contents/{+path}","compare_url":"https://api.github.com/repos/kshedden/statsmodels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kshedden/statsmodels/merges","archive_url":"https://api.github.com/repos/kshedden/statsmodels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kshedden/statsmodels/downloads","issues_url":"https://api.github.com/repos/kshedden/statsmodels/issues{/number}","pulls_url":"https://api.github.com/repos/kshedden/statsmodels/pulls{/number}","milestones_url":"https://api.github.com/repos/kshedden/statsmodels/milestones{/number}","notifications_url":"https://api.github.com/repos/kshedden/statsmodels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kshedden/statsmodels/labels{/name}","releases_url":"https://api.github.com/repos/kshedden/statsmodels/releases{/id}","created_at":"2014-01-06T05:53:14Z","updated_at":"2014-11-20T23:26:51Z","pushed_at":"2014-11-30T03:18:59Z","git_url":"git://github.com/kshedden/statsmodels.git","ssh_url":"git@github.com:kshedden/statsmodels.git","clone_url":"https://github.com/kshedden/statsmodels.git","svn_url":"https://github.com/kshedden/statsmodels","homepage":"http://statsmodels.sourceforge.net/devel/","size":22457,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"statsmodels:master","ref":"master","sha":"7473965c9c71e2bc89951fda7f75bc2f780b3b3e","user":{"login":"statsmodels","id":717666,"avatar_url":"https://avatars.githubusercontent.com/u/717666?v=3","gravatar_id":"","url":"https://api.github.com/users/statsmodels","html_url":"https://github.com/statsmodels","followers_url":"https://api.github.com/users/statsmodels/followers","following_url":"https://api.github.com/users/statsmodels/following{/other_user}","gists_url":"https://api.github.com/users/statsmodels/gists{/gist_id}","starred_url":"https://api.github.com/users/statsmodels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statsmodels/subscriptions","organizations_url":"https://api.github.com/users/statsmodels/orgs","repos_url":"https://api.github.com/users/statsmodels/repos","events_url":"https://api.github.com/users/statsmodels/events{/privacy}","received_events_url":"https://api.github.com/users/statsmodels/received_events","type":"Organization","site_admin":false},"repo":{"id":1885237,"name":"statsmodels","full_name":"statsmodels/statsmodels","owner":{"login":"statsmodels","id":717666,"avatar_url":"https://avatars.githubusercontent.com/u/717666?v=3","gravatar_id":"","url":"https://api.github.com/users/statsmodels","html_url":"https://github.com/statsmodels","followers_url":"https://api.github.com/users/statsmodels/followers","following_url":"https://api.github.com/users/statsmodels/following{/other_user}","gists_url":"https://api.github.com/users/statsmodels/gists{/gist_id}","starred_url":"https://api.github.com/users/statsmodels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statsmodels/subscriptions","organizations_url":"https://api.github.com/users/statsmodels/orgs","repos_url":"https://api.github.com/users/statsmodels/repos","events_url":"https://api.github.com/users/statsmodels/events{/privacy}","received_events_url":"https://api.github.com/users/statsmodels/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/statsmodels/statsmodels","description":"Statsmodels: statistical modeling and econometrics in Python","fork":false,"url":"https://api.github.com/repos/statsmodels/statsmodels","forks_url":"https://api.github.com/repos/statsmodels/statsmodels/forks","keys_url":"https://api.github.com/repos/statsmodels/statsmodels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/statsmodels/statsmodels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/statsmodels/statsmodels/teams","hooks_url":"https://api.github.com/repos/statsmodels/statsmodels/hooks","issue_events_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/events{/number}","events_url":"https://api.github.com/repos/statsmodels/statsmodels/events","assignees_url":"https://api.github.com/repos/statsmodels/statsmodels/assignees{/user}","branches_url":"https://api.github.com/repos/statsmodels/statsmodels/branches{/branch}","tags_url":"https://api.github.com/repos/statsmodels/statsmodels/tags","blobs_url":"https://api.github.com/repos/statsmodels/statsmodels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/statsmodels/statsmodels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/statsmodels/statsmodels/git/refs{/sha}","trees_url":"https://api.github.com/repos/statsmodels/statsmodels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/statsmodels/statsmodels/statuses/{sha}","languages_url":"https://api.github.com/repos/statsmodels/statsmodels/languages","stargazers_url":"https://api.github.com/repos/statsmodels/statsmodels/stargazers","contributors_url":"https://api.github.com/repos/statsmodels/statsmodels/contributors","subscribers_url":"https://api.github.com/repos/statsmodels/statsmodels/subscribers","subscription_url":"https://api.github.com/repos/statsmodels/statsmodels/subscription","commits_url":"https://api.github.com/repos/statsmodels/statsmodels/commits{/sha}","git_commits_url":"https://api.github.com/repos/statsmodels/statsmodels/git/commits{/sha}","comments_url":"https://api.github.com/repos/statsmodels/statsmodels/comments{/number}","issue_comment_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/comments/{number}","contents_url":"https://api.github.com/repos/statsmodels/statsmodels/contents/{+path}","compare_url":"https://api.github.com/repos/statsmodels/statsmodels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/statsmodels/statsmodels/merges","archive_url":"https://api.github.com/repos/statsmodels/statsmodels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/statsmodels/statsmodels/downloads","issues_url":"https://api.github.com/repos/statsmodels/statsmodels/issues{/number}","pulls_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls{/number}","milestones_url":"https://api.github.com/repos/statsmodels/statsmodels/milestones{/number}","notifications_url":"https://api.github.com/repos/statsmodels/statsmodels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/statsmodels/statsmodels/labels{/name}","releases_url":"https://api.github.com/repos/statsmodels/statsmodels/releases{/id}","created_at":"2011-06-12T17:04:50Z","updated_at":"2014-12-02T09:26:51Z","pushed_at":"2014-11-24T15:09:31Z","git_url":"git://github.com/statsmodels/statsmodels.git","ssh_url":"git@github.com:statsmodels/statsmodels.git","clone_url":"https://github.com/statsmodels/statsmodels.git","svn_url":"https://github.com/statsmodels/statsmodels","homepage":"http://statsmodels.sourceforge.net/devel/","size":44063,"stargazers_count":815,"watchers_count":815,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":325,"mirror_url":null,"open_issues_count":804,"forks":325,"open_issues":804,"watchers":815,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/2053"},"html":{"href":"https://github.com/statsmodels/statsmodels/pull/2053"},"issue":{"href":"https://api.github.com/repos/statsmodels/statsmodels/issues/2053"},"comments":{"href":"https://api.github.com/repos/statsmodels/statsmodels/issues/2053/comments"},"review_comments":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/2053/comments"},"review_comment":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/2053/commits"},"statuses":{"href":"https://api.github.com/repos/statsmodels/statsmodels/statuses/484edaa0471a1843eaa76be5668a7f76faba5cd2"}}}}