GitHub PullRequestReviewCommentEvent at 2014-12-06 17:29:23
Repository: banana-rdf
Actor: jmvanel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/w3c/banana-rdf/pulls/comments/21417785","id":21417785,"diff_hunk":"@@ -4,6 +4,9 @@ import scala.util.Try\n \n /**\n  * A typeclass for `T`s supporting transactions.","path":"rdf/common/src/main/scala/org/w3/banana/Transactor.scala","position":3,"original_position":3,"commit_id":"008bb6875fb132fe9227ccf2e21eac75e4708e74","original_commit_id":"e0ca26082992f485dcde091fd850347f5facc1f6","user":{"login":"jmvanel","id":896281,"avatar_url":"https://avatars.githubusercontent.com/u/896281?v=3","gravatar_id":"","url":"https://api.github.com/users/jmvanel","html_url":"https://github.com/jmvanel","followers_url":"https://api.github.com/users/jmvanel/followers","following_url":"https://api.github.com/users/jmvanel/following{/other_user}","gists_url":"https://api.github.com/users/jmvanel/gists{/gist_id}","starred_url":"https://api.github.com/users/jmvanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmvanel/subscriptions","organizations_url":"https://api.github.com/users/jmvanel/orgs","repos_url":"https://api.github.com/users/jmvanel/repos","events_url":"https://api.github.com/users/jmvanel/events{/privacy}","received_events_url":"https://api.github.com/users/jmvanel/received_events","type":"User","site_admin":false},"body":"I didn't remove the original definition :\r\n\r\n \"A typeclass for As supporting transactions.\"\r\n\r\nI just added the @tparam 's .\r\n\r\nWhat I can say in favour of the @tparam is that they provide a structured information, in case tha main paragraph does not provide it.\r\n\r\n","created_at":"2014-12-06T17:29:23Z","updated_at":"2014-12-06T17:29:23Z","html_url":"https://github.com/w3c/banana-rdf/pull/210#discussion_r21417785","pull_request_url":"https://api.github.com/repos/w3c/banana-rdf/pulls/210","_links":{"self":{"href":"https://api.github.com/repos/w3c/banana-rdf/pulls/comments/21417785"},"html":{"href":"https://github.com/w3c/banana-rdf/pull/210#discussion_r21417785"},"pull_request":{"href":"https://api.github.com/repos/w3c/banana-rdf/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/banana-rdf/pulls/210","id":25617673,"html_url":"https://github.com/w3c/banana-rdf/pull/210","diff_url":"https://github.com/w3c/banana-rdf/pull/210.diff","patch_url":"https://github.com/w3c/banana-rdf/pull/210.patch","issue_url":"https://api.github.com/repos/w3c/banana-rdf/issues/210","number":210,"state":"open","locked":false,"title":"Radical","user":{"login":"jmvanel","id":896281,"avatar_url":"https://avatars.githubusercontent.com/u/896281?v=3","gravatar_id":"","url":"https://api.github.com/users/jmvanel","html_url":"https://github.com/jmvanel","followers_url":"https://api.github.com/users/jmvanel/followers","following_url":"https://api.github.com/users/jmvanel/following{/other_user}","gists_url":"https://api.github.com/users/jmvanel/gists{/gist_id}","starred_url":"https://api.github.com/users/jmvanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmvanel/subscriptions","organizations_url":"https://api.github.com/users/jmvanel/orgs","repos_url":"https://api.github.com/users/jmvanel/repos","events_url":"https://api.github.com/users/jmvanel/events{/privacy}","received_events_url":"https://api.github.com/users/jmvanel/received_events","type":"User","site_admin":false},"body":"Implement JSON-LD writing for Jena :\r\n    a no-brainer\r\n\r\n￼Added some documentation for Generic Parameters, with @tparam :\r\n    it is actually pasted in 3 files; maybe do that only in RDFStore.scala ?","created_at":"2014-12-06T10:56:15Z","updated_at":"2014-12-06T17:29:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30c3c7d4287f752ed7681de870208a0f9563d645","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/w3c/banana-rdf/pulls/210/commits","review_comments_url":"https://api.github.com/repos/w3c/banana-rdf/pulls/210/comments","review_comment_url":"https://api.github.com/repos/w3c/banana-rdf/pulls/comments/{number}","comments_url":"https://api.github.com/repos/w3c/banana-rdf/issues/210/comments","statuses_url":"https://api.github.com/repos/w3c/banana-rdf/statuses/008bb6875fb132fe9227ccf2e21eac75e4708e74","head":{"label":"jmvanel:radical","ref":"radical","sha":"008bb6875fb132fe9227ccf2e21eac75e4708e74","user":{"login":"jmvanel","id":896281,"avatar_url":"https://avatars.githubusercontent.com/u/896281?v=3","gravatar_id":"","url":"https://api.github.com/users/jmvanel","html_url":"https://github.com/jmvanel","followers_url":"https://api.github.com/users/jmvanel/followers","following_url":"https://api.github.com/users/jmvanel/following{/other_user}","gists_url":"https://api.github.com/users/jmvanel/gists{/gist_id}","starred_url":"https://api.github.com/users/jmvanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmvanel/subscriptions","organizations_url":"https://api.github.com/users/jmvanel/orgs","repos_url":"https://api.github.com/users/jmvanel/repos","events_url":"https://api.github.com/users/jmvanel/events{/privacy}","received_events_url":"https://api.github.com/users/jmvanel/received_events","type":"User","site_admin":false},"repo":{"id":18410522,"name":"banana-rdf","full_name":"jmvanel/banana-rdf","owner":{"login":"jmvanel","id":896281,"avatar_url":"https://avatars.githubusercontent.com/u/896281?v=3","gravatar_id":"","url":"https://api.github.com/users/jmvanel","html_url":"https://github.com/jmvanel","followers_url":"https://api.github.com/users/jmvanel/followers","following_url":"https://api.github.com/users/jmvanel/following{/other_user}","gists_url":"https://api.github.com/users/jmvanel/gists{/gist_id}","starred_url":"https://api.github.com/users/jmvanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmvanel/subscriptions","organizations_url":"https://api.github.com/users/jmvanel/orgs","repos_url":"https://api.github.com/users/jmvanel/repos","events_url":"https://api.github.com/users/jmvanel/events{/privacy}","received_events_url":"https://api.github.com/users/jmvanel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmvanel/banana-rdf","description":"Banana RDF","fork":true,"url":"https://api.github.com/repos/jmvanel/banana-rdf","forks_url":"https://api.github.com/repos/jmvanel/banana-rdf/forks","keys_url":"https://api.github.com/repos/jmvanel/banana-rdf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmvanel/banana-rdf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmvanel/banana-rdf/teams","hooks_url":"https://api.github.com/repos/jmvanel/banana-rdf/hooks","issue_events_url":"https://api.github.com/repos/jmvanel/banana-rdf/issues/events{/number}","events_url":"https://api.github.com/repos/jmvanel/banana-rdf/events","assignees_url":"https://api.github.com/repos/jmvanel/banana-rdf/assignees{/user}","branches_url":"https://api.github.com/repos/jmvanel/banana-rdf/branches{/branch}","tags_url":"https://api.github.com/repos/jmvanel/banana-rdf/tags","blobs_url":"https://api.github.com/repos/jmvanel/banana-rdf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmvanel/banana-rdf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmvanel/banana-rdf/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmvanel/banana-rdf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmvanel/banana-rdf/statuses/{sha}","languages_url":"https://api.github.com/repos/jmvanel/banana-rdf/languages","stargazers_url":"https://api.github.com/repos/jmvanel/banana-rdf/stargazers","contributors_url":"https://api.github.com/repos/jmvanel/banana-rdf/contributors","subscribers_url":"https://api.github.com/repos/jmvanel/banana-rdf/subscribers","subscription_url":"https://api.github.com/repos/jmvanel/banana-rdf/subscription","commits_url":"https://api.github.com/repos/jmvanel/banana-rdf/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmvanel/banana-rdf/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmvanel/banana-rdf/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmvanel/banana-rdf/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmvanel/banana-rdf/contents/{+path}","compare_url":"https://api.github.com/repos/jmvanel/banana-rdf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmvanel/banana-rdf/merges","archive_url":"https://api.github.com/repos/jmvanel/banana-rdf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmvanel/banana-rdf/downloads","issues_url":"https://api.github.com/repos/jmvanel/banana-rdf/issues{/number}","pulls_url":"https://api.github.com/repos/jmvanel/banana-rdf/pulls{/number}","milestones_url":"https://api.github.com/repos/jmvanel/banana-rdf/milestones{/number}","notifications_url":"https://api.github.com/repos/jmvanel/banana-rdf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmvanel/banana-rdf/labels{/name}","releases_url":"https://api.github.com/repos/jmvanel/banana-rdf/releases{/id}","created_at":"2014-04-03T16:44:00Z","updated_at":"2014-09-17T18:00:47Z","pushed_at":"2014-12-06T17:19:36Z","git_url":"git://github.com/jmvanel/banana-rdf.git","ssh_url":"git@github.com:jmvanel/banana-rdf.git","clone_url":"https://github.com/jmvanel/banana-rdf.git","svn_url":"https://github.com/jmvanel/banana-rdf","homepage":null,"size":4376,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:radical","ref":"radical","sha":"c7db8564e8cf0f4c76f5f0c939cafbc435464ab2","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":4179427,"name":"banana-rdf","full_name":"w3c/banana-rdf","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/banana-rdf","description":"Banana RDF","fork":false,"url":"https://api.github.com/repos/w3c/banana-rdf","forks_url":"https://api.github.com/repos/w3c/banana-rdf/forks","keys_url":"https://api.github.com/repos/w3c/banana-rdf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/banana-rdf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/banana-rdf/teams","hooks_url":"https://api.github.com/repos/w3c/banana-rdf/hooks","issue_events_url":"https://api.github.com/repos/w3c/banana-rdf/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/banana-rdf/events","assignees_url":"https://api.github.com/repos/w3c/banana-rdf/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/banana-rdf/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/banana-rdf/tags","blobs_url":"https://api.github.com/repos/w3c/banana-rdf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/banana-rdf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/banana-rdf/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/banana-rdf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/banana-rdf/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/banana-rdf/languages","stargazers_url":"https://api.github.com/repos/w3c/banana-rdf/stargazers","contributors_url":"https://api.github.com/repos/w3c/banana-rdf/contributors","subscribers_url":"https://api.github.com/repos/w3c/banana-rdf/subscribers","subscription_url":"https://api.github.com/repos/w3c/banana-rdf/subscription","commits_url":"https://api.github.com/repos/w3c/banana-rdf/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/banana-rdf/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/banana-rdf/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/banana-rdf/issues/comments/{number}","contents_url":"https://api.github.com/repos/w3c/banana-rdf/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/banana-rdf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/banana-rdf/merges","archive_url":"https://api.github.com/repos/w3c/banana-rdf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/banana-rdf/downloads","issues_url":"https://api.github.com/repos/w3c/banana-rdf/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/banana-rdf/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/banana-rdf/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/banana-rdf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/banana-rdf/labels{/name}","releases_url":"https://api.github.com/repos/w3c/banana-rdf/releases{/id}","created_at":"2012-04-30T03:02:56Z","updated_at":"2014-12-05T11:51:22Z","pushed_at":"2014-12-05T18:28:49Z","git_url":"git://github.com/w3c/banana-rdf.git","ssh_url":"git@github.com:w3c/banana-rdf.git","clone_url":"https://github.com/w3c/banana-rdf.git","svn_url":"https://github.com/w3c/banana-rdf","homepage":null,"size":6401,"stargazers_count":98,"watchers_count":98,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":70,"forks":28,"open_issues":70,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/banana-rdf/pulls/210"},"html":{"href":"https://github.com/w3c/banana-rdf/pull/210"},"issue":{"href":"https://api.github.com/repos/w3c/banana-rdf/issues/210"},"comments":{"href":"https://api.github.com/repos/w3c/banana-rdf/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/banana-rdf/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/banana-rdf/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/w3c/banana-rdf/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/banana-rdf/statuses/008bb6875fb132fe9227ccf2e21eac75e4708e74"}}}}