GitHub PullRequestEvent at 2014-10-28 12:47:15
Repository: stream-transcoder.js
Actor: trenskow
Payload: {"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/trenskow/stream-transcoder.js/pulls/10","id":23430489,"html_url":"https://github.com/trenskow/stream-transcoder.js/pull/10","diff_url":"https://github.com/trenskow/stream-transcoder.js/pull/10.diff","patch_url":"https://github.com/trenskow/stream-transcoder.js/pull/10.patch","issue_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/issues/10","number":10,"state":"closed","locked":false,"title":"Handle additional format for size metadata","user":{"login":"pskupinski","id":206943,"avatar_url":"https://avatars.githubusercontent.com/u/206943?v=2","gravatar_id":"","url":"https://api.github.com/users/pskupinski","html_url":"https://github.com/pskupinski","followers_url":"https://api.github.com/users/pskupinski/followers","following_url":"https://api.github.com/users/pskupinski/following{/other_user}","gists_url":"https://api.github.com/users/pskupinski/gists{/gist_id}","starred_url":"https://api.github.com/users/pskupinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pskupinski/subscriptions","organizations_url":"https://api.github.com/users/pskupinski/orgs","repos_url":"https://api.github.com/users/pskupinski/repos","events_url":"https://api.github.com/users/pskupinski/events{/privacy}","received_events_url":"https://api.github.com/users/pskupinski/received_events","type":"User","site_admin":false},"body":"There are other ways ffmpeg outputs the size than just \\d+x\\d+ followed\r\nby a comma or newline.  There is a case where ffmpeg will output\r\nadditional metadata before the comma/newline in the form of\r\n\"600x338 [SAR 845:843 DAR 500:281]\".  This does not work with the parser\r\nas is, and will result in no size metadata being output which can be\r\nproblematic for anything relying on it being there.\r\n\r\nFor example, take a look at the metadata output for the given file: https://cdn1.lockerdome.com/uploads/381d165f31e9dcad7c08080f5f113d0472f97c540e43a3bccfad6ca950fc329c_:original","created_at":"2014-10-28T02:16:57Z","updated_at":"2014-10-28T12:47:15Z","closed_at":"2014-10-28T12:47:15Z","merged_at":"2014-10-28T12:47:15Z","merge_commit_sha":"8475fe8237c4e2b3356e3f77f56f9713593ada3d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/pulls/10/commits","review_comments_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/pulls/10/comments","review_comment_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/issues/10/comments","statuses_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/statuses/1ae73066e4118436aee157e3871ddeb61f2e26eb","head":{"label":"pskupinski:improve-size-parsing","ref":"improve-size-parsing","sha":"1ae73066e4118436aee157e3871ddeb61f2e26eb","user":{"login":"pskupinski","id":206943,"avatar_url":"https://avatars.githubusercontent.com/u/206943?v=2","gravatar_id":"","url":"https://api.github.com/users/pskupinski","html_url":"https://github.com/pskupinski","followers_url":"https://api.github.com/users/pskupinski/followers","following_url":"https://api.github.com/users/pskupinski/following{/other_user}","gists_url":"https://api.github.com/users/pskupinski/gists{/gist_id}","starred_url":"https://api.github.com/users/pskupinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pskupinski/subscriptions","organizations_url":"https://api.github.com/users/pskupinski/orgs","repos_url":"https://api.github.com/users/pskupinski/repos","events_url":"https://api.github.com/users/pskupinski/events{/privacy}","received_events_url":"https://api.github.com/users/pskupinski/received_events","type":"User","site_admin":false},"repo":{"id":14543247,"name":"stream-transcoder.js","full_name":"pskupinski/stream-transcoder.js","owner":{"login":"pskupinski","id":206943,"avatar_url":"https://avatars.githubusercontent.com/u/206943?v=2","gravatar_id":"","url":"https://api.github.com/users/pskupinski","html_url":"https://github.com/pskupinski","followers_url":"https://api.github.com/users/pskupinski/followers","following_url":"https://api.github.com/users/pskupinski/following{/other_user}","gists_url":"https://api.github.com/users/pskupinski/gists{/gist_id}","starred_url":"https://api.github.com/users/pskupinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pskupinski/subscriptions","organizations_url":"https://api.github.com/users/pskupinski/orgs","repos_url":"https://api.github.com/users/pskupinski/repos","events_url":"https://api.github.com/users/pskupinski/events{/privacy}","received_events_url":"https://api.github.com/users/pskupinski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pskupinski/stream-transcoder.js","description":"FFmpeg based media transcoder that operates on streams.","fork":true,"url":"https://api.github.com/repos/pskupinski/stream-transcoder.js","forks_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/forks","keys_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/teams","hooks_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/hooks","issue_events_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/issues/events{/number}","events_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/events","assignees_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/assignees{/user}","branches_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/branches{/branch}","tags_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/tags","blobs_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/statuses/{sha}","languages_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/languages","stargazers_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/stargazers","contributors_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/contributors","subscribers_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/subscribers","subscription_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/subscription","commits_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/contents/{+path}","compare_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/merges","archive_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/downloads","issues_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/issues{/number}","pulls_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/pulls{/number}","milestones_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/milestones{/number}","notifications_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/labels{/name}","releases_url":"https://api.github.com/repos/pskupinski/stream-transcoder.js/releases{/id}","created_at":"2013-11-20T01:26:30Z","updated_at":"2014-10-27T21:35:45Z","pushed_at":"2014-10-28T01:36:08Z","git_url":"git://github.com/pskupinski/stream-transcoder.js.git","ssh_url":"git@github.com:pskupinski/stream-transcoder.js.git","clone_url":"https://github.com/pskupinski/stream-transcoder.js.git","svn_url":"https://github.com/pskupinski/stream-transcoder.js","homepage":null,"size":131,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trenskow:master","ref":"master","sha":"8f321e2a936fbf6b73dea1d3be15feb3168369b0","user":{"login":"trenskow","id":726715,"avatar_url":"https://avatars.githubusercontent.com/u/726715?v=2","gravatar_id":"","url":"https://api.github.com/users/trenskow","html_url":"https://github.com/trenskow","followers_url":"https://api.github.com/users/trenskow/followers","following_url":"https://api.github.com/users/trenskow/following{/other_user}","gists_url":"https://api.github.com/users/trenskow/gists{/gist_id}","starred_url":"https://api.github.com/users/trenskow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trenskow/subscriptions","organizations_url":"https://api.github.com/users/trenskow/orgs","repos_url":"https://api.github.com/users/trenskow/repos","events_url":"https://api.github.com/users/trenskow/events{/privacy}","received_events_url":"https://api.github.com/users/trenskow/received_events","type":"User","site_admin":false},"repo":{"id":11948021,"name":"stream-transcoder.js","full_name":"trenskow/stream-transcoder.js","owner":{"login":"trenskow","id":726715,"avatar_url":"https://avatars.githubusercontent.com/u/726715?v=2","gravatar_id":"","url":"https://api.github.com/users/trenskow","html_url":"https://github.com/trenskow","followers_url":"https://api.github.com/users/trenskow/followers","following_url":"https://api.github.com/users/trenskow/following{/other_user}","gists_url":"https://api.github.com/users/trenskow/gists{/gist_id}","starred_url":"https://api.github.com/users/trenskow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trenskow/subscriptions","organizations_url":"https://api.github.com/users/trenskow/orgs","repos_url":"https://api.github.com/users/trenskow/repos","events_url":"https://api.github.com/users/trenskow/events{/privacy}","received_events_url":"https://api.github.com/users/trenskow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trenskow/stream-transcoder.js","description":"FFmpeg based media transcoder that operates on streams.","fork":false,"url":"https://api.github.com/repos/trenskow/stream-transcoder.js","forks_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/forks","keys_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/teams","hooks_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/hooks","issue_events_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/issues/events{/number}","events_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/events","assignees_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/assignees{/user}","branches_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/branches{/branch}","tags_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/tags","blobs_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/statuses/{sha}","languages_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/languages","stargazers_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/stargazers","contributors_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/contributors","subscribers_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/subscribers","subscription_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/subscription","commits_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/contents/{+path}","compare_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/merges","archive_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/downloads","issues_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/issues{/number}","pulls_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/pulls{/number}","milestones_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/milestones{/number}","notifications_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/labels{/name}","releases_url":"https://api.github.com/repos/trenskow/stream-transcoder.js/releases{/id}","created_at":"2013-08-07T10:59:53Z","updated_at":"2014-09-03T23:17:02Z","pushed_at":"2014-10-28T12:47:15Z","git_url":"git://github.com/trenskow/stream-transcoder.js.git","ssh_url":"git@github.com:trenskow/stream-transcoder.js.git","clone_url":"https://github.com/trenskow/stream-transcoder.js.git","svn_url":"https://github.com/trenskow/stream-transcoder.js","homepage":null,"size":231,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trenskow/stream-transcoder.js/pulls/10"},"html":{"href":"https://github.com/trenskow/stream-transcoder.js/pull/10"},"issue":{"href":"https://api.github.com/repos/trenskow/stream-transcoder.js/issues/10"},"comments":{"href":"https://api.github.com/repos/trenskow/stream-transcoder.js/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/trenskow/stream-transcoder.js/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/trenskow/stream-transcoder.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/trenskow/stream-transcoder.js/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/trenskow/stream-transcoder.js/statuses/1ae73066e4118436aee157e3871ddeb61f2e26eb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"trenskow","id":726715,"avatar_url":"https://avatars.githubusercontent.com/u/726715?v=2","gravatar_id":"","url":"https://api.github.com/users/trenskow","html_url":"https://github.com/trenskow","followers_url":"https://api.github.com/users/trenskow/followers","following_url":"https://api.github.com/users/trenskow/following{/other_user}","gists_url":"https://api.github.com/users/trenskow/gists{/gist_id}","starred_url":"https://api.github.com/users/trenskow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trenskow/subscriptions","organizations_url":"https://api.github.com/users/trenskow/orgs","repos_url":"https://api.github.com/users/trenskow/repos","events_url":"https://api.github.com/users/trenskow/events{/privacy}","received_events_url":"https://api.github.com/users/trenskow/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}