GitHub PullRequestReviewCommentEvent at 2014-07-11 16:28:15
Repository: hubstats
Actor: ehlertij
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sportngin/hubstats/pulls/comments/14829794","id":14829794,"diff_hunk":"@@ -4,14 +4,21 @@ module Hubstats\n   class PullRequestsController < ApplicationController\n \n     def index\n-      @pull_requests = Hubstats::PullRequest.includes(:user).includes(:repo)\n+      params[:label].sub!('%20',' ') if params[:label]","path":"app/controllers/hubstats/pull_requests_controller.rb","position":5,"original_position":5,"commit_id":"c3287267f305a015d8ed3ebf426b62a719180515","original_commit_id":"c3287267f305a015d8ed3ebf426b62a719180515","user":{"login":"ehlertij","id":174227,"avatar_url":"https://avatars.githubusercontent.com/u/174227?","gravatar_id":"11c1fcb84ab1fdf769cbc3f7c8466528","url":"https://api.github.com/users/ehlertij","html_url":"https://github.com/ehlertij","followers_url":"https://api.github.com/users/ehlertij/followers","following_url":"https://api.github.com/users/ehlertij/following{/other_user}","gists_url":"https://api.github.com/users/ehlertij/gists{/gist_id}","starred_url":"https://api.github.com/users/ehlertij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehlertij/subscriptions","organizations_url":"https://api.github.com/users/ehlertij/orgs","repos_url":"https://api.github.com/users/ehlertij/repos","events_url":"https://api.github.com/users/ehlertij/events{/privacy}","received_events_url":"https://api.github.com/users/ehlertij/received_events","type":"User","site_admin":false},"body":"You should be able to use `URI.decode(params[:label])` here instead to convert the `%20` characters to spaces.","created_at":"2014-07-11T16:28:15Z","updated_at":"2014-07-11T16:28:15Z","html_url":"https://github.com/sportngin/hubstats/pull/28#discussion_r14829794","pull_request_url":"https://api.github.com/repos/sportngin/hubstats/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/sportngin/hubstats/pulls/comments/14829794"},"html":{"href":"https://github.com/sportngin/hubstats/pull/28#discussion_r14829794"},"pull_request":{"href":"https://api.github.com/repos/sportngin/hubstats/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/sportngin/hubstats/pulls/28","id":18247356,"html_url":"https://github.com/sportngin/hubstats/pull/28","diff_url":"https://github.com/sportngin/hubstats/pull/28.diff","patch_url":"https://github.com/sportngin/hubstats/pull/28.patch","issue_url":"https://api.github.com/repos/sportngin/hubstats/issues/28","number":28,"state":"open","title":"Added Filtering by Label","user":{"login":"elliothursh","id":2453875,"avatar_url":"https://avatars.githubusercontent.com/u/2453875?","gravatar_id":"9216098977456848b3c792465f604452","url":"https://api.github.com/users/elliothursh","html_url":"https://github.com/elliothursh","followers_url":"https://api.github.com/users/elliothursh/followers","following_url":"https://api.github.com/users/elliothursh/following{/other_user}","gists_url":"https://api.github.com/users/elliothursh/gists{/gist_id}","starred_url":"https://api.github.com/users/elliothursh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliothursh/subscriptions","organizations_url":"https://api.github.com/users/elliothursh/orgs","repos_url":"https://api.github.com/users/elliothursh/repos","events_url":"https://api.github.com/users/elliothursh/events{/privacy}","received_events_url":"https://api.github.com/users/elliothursh/received_events","type":"User","site_admin":false},"body":"## Description and Impact\r\nAllows For filtering by label\r\n\r\n## Rollback Plan\r\n* To roll back this change, revert the merge with: `git revert -m 1 MERGE_SHA` and perform another deploy.\r\n\r\n## URLs\r\n> Links to bug tickets or user stories.\r\n\r\n#### Risk Level:\r\n- [X] Low\r\n- [ ] Medium\r\n- [ ] High\r\n\r\n","created_at":"2014-07-10T21:22:59Z","updated_at":"2014-07-11T16:28:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95af6edd2124dbe1e49bed9bd444f55804173f77","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sportngin/hubstats/pulls/28/commits","review_comments_url":"https://api.github.com/repos/sportngin/hubstats/pulls/28/comments","review_comment_url":"https://api.github.com/repos/sportngin/hubstats/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sportngin/hubstats/issues/28/comments","statuses_url":"https://api.github.com/repos/sportngin/hubstats/statuses/c3287267f305a015d8ed3ebf426b62a719180515","head":{"label":"sportngin:label-filtering","ref":"label-filtering","sha":"c3287267f305a015d8ed3ebf426b62a719180515","user":{"login":"sportngin","id":3728684,"avatar_url":"https://avatars.githubusercontent.com/u/3728684?","gravatar_id":"7ea1840324741122e771fe7e3f6fe9bd","url":"https://api.github.com/users/sportngin","html_url":"https://github.com/sportngin","followers_url":"https://api.github.com/users/sportngin/followers","following_url":"https://api.github.com/users/sportngin/following{/other_user}","gists_url":"https://api.github.com/users/sportngin/gists{/gist_id}","starred_url":"https://api.github.com/users/sportngin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sportngin/subscriptions","organizations_url":"https://api.github.com/users/sportngin/orgs","repos_url":"https://api.github.com/users/sportngin/repos","events_url":"https://api.github.com/users/sportngin/events{/privacy}","received_events_url":"https://api.github.com/users/sportngin/received_events","type":"Organization","site_admin":false},"repo":{"id":20231003,"name":"hubstats","full_name":"sportngin/hubstats","owner":{"login":"sportngin","id":3728684,"avatar_url":"https://avatars.githubusercontent.com/u/3728684?","gravatar_id":"7ea1840324741122e771fe7e3f6fe9bd","url":"https://api.github.com/users/sportngin","html_url":"https://github.com/sportngin","followers_url":"https://api.github.com/users/sportngin/followers","following_url":"https://api.github.com/users/sportngin/following{/other_user}","gists_url":"https://api.github.com/users/sportngin/gists{/gist_id}","starred_url":"https://api.github.com/users/sportngin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sportngin/subscriptions","organizations_url":"https://api.github.com/users/sportngin/orgs","repos_url":"https://api.github.com/users/sportngin/repos","events_url":"https://api.github.com/users/sportngin/events{/privacy}","received_events_url":"https://api.github.com/users/sportngin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sportngin/hubstats","description":"Gamification of Github","fork":false,"url":"https://api.github.com/repos/sportngin/hubstats","forks_url":"https://api.github.com/repos/sportngin/hubstats/forks","keys_url":"https://api.github.com/repos/sportngin/hubstats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sportngin/hubstats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sportngin/hubstats/teams","hooks_url":"https://api.github.com/repos/sportngin/hubstats/hooks","issue_events_url":"https://api.github.com/repos/sportngin/hubstats/issues/events{/number}","events_url":"https://api.github.com/repos/sportngin/hubstats/events","assignees_url":"https://api.github.com/repos/sportngin/hubstats/assignees{/user}","branches_url":"https://api.github.com/repos/sportngin/hubstats/branches{/branch}","tags_url":"https://api.github.com/repos/sportngin/hubstats/tags","blobs_url":"https://api.github.com/repos/sportngin/hubstats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sportngin/hubstats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sportngin/hubstats/git/refs{/sha}","trees_url":"https://api.github.com/repos/sportngin/hubstats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sportngin/hubstats/statuses/{sha}","languages_url":"https://api.github.com/repos/sportngin/hubstats/languages","stargazers_url":"https://api.github.com/repos/sportngin/hubstats/stargazers","contributors_url":"https://api.github.com/repos/sportngin/hubstats/contributors","subscribers_url":"https://api.github.com/repos/sportngin/hubstats/subscribers","subscription_url":"https://api.github.com/repos/sportngin/hubstats/subscription","commits_url":"https://api.github.com/repos/sportngin/hubstats/commits{/sha}","git_commits_url":"https://api.github.com/repos/sportngin/hubstats/git/commits{/sha}","comments_url":"https://api.github.com/repos/sportngin/hubstats/comments{/number}","issue_comment_url":"https://api.github.com/repos/sportngin/hubstats/issues/comments/{number}","contents_url":"https://api.github.com/repos/sportngin/hubstats/contents/{+path}","compare_url":"https://api.github.com/repos/sportngin/hubstats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sportngin/hubstats/merges","archive_url":"https://api.github.com/repos/sportngin/hubstats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sportngin/hubstats/downloads","issues_url":"https://api.github.com/repos/sportngin/hubstats/issues{/number}","pulls_url":"https://api.github.com/repos/sportngin/hubstats/pulls{/number}","milestones_url":"https://api.github.com/repos/sportngin/hubstats/milestones{/number}","notifications_url":"https://api.github.com/repos/sportngin/hubstats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sportngin/hubstats/labels{/name}","releases_url":"https://api.github.com/repos/sportngin/hubstats/releases{/id}","created_at":"2014-05-27T18:41:53Z","updated_at":"2014-06-26T20:58:33Z","pushed_at":"2014-07-11T16:23:07Z","git_url":"git://github.com/sportngin/hubstats.git","ssh_url":"git@github.com:sportngin/hubstats.git","clone_url":"https://github.com/sportngin/hubstats.git","svn_url":"https://github.com/sportngin/hubstats","homepage":null,"size":1564,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"sportngin:master","ref":"master","sha":"e6826d0cfb07f257dc96745817765c6994ebd7ea","user":{"login":"sportngin","id":3728684,"avatar_url":"https://avatars.githubusercontent.com/u/3728684?","gravatar_id":"7ea1840324741122e771fe7e3f6fe9bd","url":"https://api.github.com/users/sportngin","html_url":"https://github.com/sportngin","followers_url":"https://api.github.com/users/sportngin/followers","following_url":"https://api.github.com/users/sportngin/following{/other_user}","gists_url":"https://api.github.com/users/sportngin/gists{/gist_id}","starred_url":"https://api.github.com/users/sportngin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sportngin/subscriptions","organizations_url":"https://api.github.com/users/sportngin/orgs","repos_url":"https://api.github.com/users/sportngin/repos","events_url":"https://api.github.com/users/sportngin/events{/privacy}","received_events_url":"https://api.github.com/users/sportngin/received_events","type":"Organization","site_admin":false},"repo":{"id":20231003,"name":"hubstats","full_name":"sportngin/hubstats","owner":{"login":"sportngin","id":3728684,"avatar_url":"https://avatars.githubusercontent.com/u/3728684?","gravatar_id":"7ea1840324741122e771fe7e3f6fe9bd","url":"https://api.github.com/users/sportngin","html_url":"https://github.com/sportngin","followers_url":"https://api.github.com/users/sportngin/followers","following_url":"https://api.github.com/users/sportngin/following{/other_user}","gists_url":"https://api.github.com/users/sportngin/gists{/gist_id}","starred_url":"https://api.github.com/users/sportngin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sportngin/subscriptions","organizations_url":"https://api.github.com/users/sportngin/orgs","repos_url":"https://api.github.com/users/sportngin/repos","events_url":"https://api.github.com/users/sportngin/events{/privacy}","received_events_url":"https://api.github.com/users/sportngin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sportngin/hubstats","description":"Gamification of Github","fork":false,"url":"https://api.github.com/repos/sportngin/hubstats","forks_url":"https://api.github.com/repos/sportngin/hubstats/forks","keys_url":"https://api.github.com/repos/sportngin/hubstats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sportngin/hubstats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sportngin/hubstats/teams","hooks_url":"https://api.github.com/repos/sportngin/hubstats/hooks","issue_events_url":"https://api.github.com/repos/sportngin/hubstats/issues/events{/number}","events_url":"https://api.github.com/repos/sportngin/hubstats/events","assignees_url":"https://api.github.com/repos/sportngin/hubstats/assignees{/user}","branches_url":"https://api.github.com/repos/sportngin/hubstats/branches{/branch}","tags_url":"https://api.github.com/repos/sportngin/hubstats/tags","blobs_url":"https://api.github.com/repos/sportngin/hubstats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sportngin/hubstats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sportngin/hubstats/git/refs{/sha}","trees_url":"https://api.github.com/repos/sportngin/hubstats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sportngin/hubstats/statuses/{sha}","languages_url":"https://api.github.com/repos/sportngin/hubstats/languages","stargazers_url":"https://api.github.com/repos/sportngin/hubstats/stargazers","contributors_url":"https://api.github.com/repos/sportngin/hubstats/contributors","subscribers_url":"https://api.github.com/repos/sportngin/hubstats/subscribers","subscription_url":"https://api.github.com/repos/sportngin/hubstats/subscription","commits_url":"https://api.github.com/repos/sportngin/hubstats/commits{/sha}","git_commits_url":"https://api.github.com/repos/sportngin/hubstats/git/commits{/sha}","comments_url":"https://api.github.com/repos/sportngin/hubstats/comments{/number}","issue_comment_url":"https://api.github.com/repos/sportngin/hubstats/issues/comments/{number}","contents_url":"https://api.github.com/repos/sportngin/hubstats/contents/{+path}","compare_url":"https://api.github.com/repos/sportngin/hubstats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sportngin/hubstats/merges","archive_url":"https://api.github.com/repos/sportngin/hubstats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sportngin/hubstats/downloads","issues_url":"https://api.github.com/repos/sportngin/hubstats/issues{/number}","pulls_url":"https://api.github.com/repos/sportngin/hubstats/pulls{/number}","milestones_url":"https://api.github.com/repos/sportngin/hubstats/milestones{/number}","notifications_url":"https://api.github.com/repos/sportngin/hubstats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sportngin/hubstats/labels{/name}","releases_url":"https://api.github.com/repos/sportngin/hubstats/releases{/id}","created_at":"2014-05-27T18:41:53Z","updated_at":"2014-06-26T20:58:33Z","pushed_at":"2014-07-11T16:23:07Z","git_url":"git://github.com/sportngin/hubstats.git","ssh_url":"git@github.com:sportngin/hubstats.git","clone_url":"https://github.com/sportngin/hubstats.git","svn_url":"https://github.com/sportngin/hubstats","homepage":null,"size":1564,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sportngin/hubstats/pulls/28"},"html":{"href":"https://github.com/sportngin/hubstats/pull/28"},"issue":{"href":"https://api.github.com/repos/sportngin/hubstats/issues/28"},"comments":{"href":"https://api.github.com/repos/sportngin/hubstats/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/sportngin/hubstats/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/sportngin/hubstats/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sportngin/hubstats/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/sportngin/hubstats/statuses/c3287267f305a015d8ed3ebf426b62a719180515"}}}}