GitHub PullRequestReviewCommentEvent at 2014-07-15 09:17:46
Repository: cabal
Actor: 23Skidoo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/haskell/cabal/pulls/comments/14924020","id":14924020,"diff_hunk":"@@ -332,28 +332,23 @@ maybeExit cmd = do\n   res <- cmd\n   unless (res == ExitSuccess) $ exitWith res\n \n-printRawCommandAndArgs :: Verbosity -> FilePath -> [String] -> IO ()\n-printRawCommandAndArgs verbosity path args\n- | verbosity >= deafening = print (path, args)\n+printRawCommandAndArgs :: Verbosity","path":"Cabal/Distribution/Simple/Utils.hs","position":7,"original_position":7,"commit_id":"2ff605857fbd21ff3f9a976384d78cd439623088","original_commit_id":"2ff605857fbd21ff3f9a976384d78cd439623088","user":{"login":"23Skidoo","id":47439,"avatar_url":"https://avatars.githubusercontent.com/u/47439?","gravatar_id":"55d9f8a76c1f96f930d25fdd1fcc1fb8","url":"https://api.github.com/users/23Skidoo","html_url":"https://github.com/23Skidoo","followers_url":"https://api.github.com/users/23Skidoo/followers","following_url":"https://api.github.com/users/23Skidoo/following{/other_user}","gists_url":"https://api.github.com/users/23Skidoo/gists{/gist_id}","starred_url":"https://api.github.com/users/23Skidoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/23Skidoo/subscriptions","organizations_url":"https://api.github.com/users/23Skidoo/orgs","repos_url":"https://api.github.com/users/23Skidoo/repos","events_url":"https://api.github.com/users/23Skidoo/events{/privacy}","received_events_url":"https://api.github.com/users/23Skidoo/received_events","type":"User","site_admin":false},"body":"Why do you need to do this? I think it was not printing the environment on purpose.","created_at":"2014-07-15T09:17:46Z","updated_at":"2014-07-15T09:17:46Z","html_url":"https://github.com/haskell/cabal/pull/1947#discussion_r14924020","pull_request_url":"https://api.github.com/repos/haskell/cabal/pulls/1947","_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments/14924020"},"html":{"href":"https://github.com/haskell/cabal/pull/1947#discussion_r14924020"},"pull_request":{"href":"https://api.github.com/repos/haskell/cabal/pulls/1947"}}},"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/1947","id":17152969,"html_url":"https://github.com/haskell/cabal/pull/1947","diff_url":"https://github.com/haskell/cabal/pull/1947.diff","patch_url":"https://github.com/haskell/cabal/pull/1947.patch","issue_url":"https://api.github.com/repos/haskell/cabal/issues/1947","number":1947,"state":"open","title":"#1945 Make hpc-related activity conditional on --enable-library-coverage flag","user":{"login":"sardonicpresence","id":7886140,"avatar_url":"https://avatars.githubusercontent.com/u/7886140?","gravatar_id":"bd6913ae5f4af9e2a384fe884027bf0e","url":"https://api.github.com/users/sardonicpresence","html_url":"https://github.com/sardonicpresence","followers_url":"https://api.github.com/users/sardonicpresence/followers","following_url":"https://api.github.com/users/sardonicpresence/following{/other_user}","gists_url":"https://api.github.com/users/sardonicpresence/gists{/gist_id}","starred_url":"https://api.github.com/users/sardonicpresence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sardonicpresence/subscriptions","organizations_url":"https://api.github.com/users/sardonicpresence/orgs","repos_url":"https://api.github.com/users/sardonicpresence/repos","events_url":"https://api.github.com/users/sardonicpresence/events{/privacy}","received_events_url":"https://api.github.com/users/sardonicpresence/received_events","type":"User","site_admin":false},"body":"Instead of applying hpc flags directly via 'enableCoverage' I've added a 'withCoverage' flag to LocalBuildInfo that is then checked before setting HPXTIXFILE or calling 'markupTest' or 'markupPackage' and used to generate -fhpc and -hpcdir flags in the GHC-specific code.\r\n\r\nAdded initially-failing now passing tests to PackageTests/TestSuiteExeV10.","created_at":"2014-06-15T14:07:42Z","updated_at":"2014-07-15T09:17:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78590534622e9f52f1bed8264cdd3a96cf20c903","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/haskell/cabal/pulls/1947/commits","review_comments_url":"https://api.github.com/repos/haskell/cabal/pulls/1947/comments","review_comment_url":"https://api.github.com/repos/haskell/cabal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/1947/comments","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/2ff605857fbd21ff3f9a976384d78cd439623088","head":{"label":"sardonicpresence:master","ref":"master","sha":"2ff605857fbd21ff3f9a976384d78cd439623088","user":{"login":"sardonicpresence","id":7886140,"avatar_url":"https://avatars.githubusercontent.com/u/7886140?","gravatar_id":"bd6913ae5f4af9e2a384fe884027bf0e","url":"https://api.github.com/users/sardonicpresence","html_url":"https://github.com/sardonicpresence","followers_url":"https://api.github.com/users/sardonicpresence/followers","following_url":"https://api.github.com/users/sardonicpresence/following{/other_user}","gists_url":"https://api.github.com/users/sardonicpresence/gists{/gist_id}","starred_url":"https://api.github.com/users/sardonicpresence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sardonicpresence/subscriptions","organizations_url":"https://api.github.com/users/sardonicpresence/orgs","repos_url":"https://api.github.com/users/sardonicpresence/repos","events_url":"https://api.github.com/users/sardonicpresence/events{/privacy}","received_events_url":"https://api.github.com/users/sardonicpresence/received_events","type":"User","site_admin":false},"repo":{"id":20826084,"name":"cabal","full_name":"sardonicpresence/cabal","owner":{"login":"sardonicpresence","id":7886140,"avatar_url":"https://avatars.githubusercontent.com/u/7886140?","gravatar_id":"bd6913ae5f4af9e2a384fe884027bf0e","url":"https://api.github.com/users/sardonicpresence","html_url":"https://github.com/sardonicpresence","followers_url":"https://api.github.com/users/sardonicpresence/followers","following_url":"https://api.github.com/users/sardonicpresence/following{/other_user}","gists_url":"https://api.github.com/users/sardonicpresence/gists{/gist_id}","starred_url":"https://api.github.com/users/sardonicpresence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sardonicpresence/subscriptions","organizations_url":"https://api.github.com/users/sardonicpresence/orgs","repos_url":"https://api.github.com/users/sardonicpresence/repos","events_url":"https://api.github.com/users/sardonicpresence/events{/privacy}","received_events_url":"https://api.github.com/users/sardonicpresence/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sardonicpresence/cabal","description":"Fork of haskell/cabal","fork":true,"url":"https://api.github.com/repos/sardonicpresence/cabal","forks_url":"https://api.github.com/repos/sardonicpresence/cabal/forks","keys_url":"https://api.github.com/repos/sardonicpresence/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sardonicpresence/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sardonicpresence/cabal/teams","hooks_url":"https://api.github.com/repos/sardonicpresence/cabal/hooks","issue_events_url":"https://api.github.com/repos/sardonicpresence/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/sardonicpresence/cabal/events","assignees_url":"https://api.github.com/repos/sardonicpresence/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/sardonicpresence/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/sardonicpresence/cabal/tags","blobs_url":"https://api.github.com/repos/sardonicpresence/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sardonicpresence/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sardonicpresence/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/sardonicpresence/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sardonicpresence/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/sardonicpresence/cabal/languages","stargazers_url":"https://api.github.com/repos/sardonicpresence/cabal/stargazers","contributors_url":"https://api.github.com/repos/sardonicpresence/cabal/contributors","subscribers_url":"https://api.github.com/repos/sardonicpresence/cabal/subscribers","subscription_url":"https://api.github.com/repos/sardonicpresence/cabal/subscription","commits_url":"https://api.github.com/repos/sardonicpresence/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/sardonicpresence/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/sardonicpresence/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/sardonicpresence/cabal/issues/comments/{number}","contents_url":"https://api.github.com/repos/sardonicpresence/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/sardonicpresence/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sardonicpresence/cabal/merges","archive_url":"https://api.github.com/repos/sardonicpresence/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sardonicpresence/cabal/downloads","issues_url":"https://api.github.com/repos/sardonicpresence/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/sardonicpresence/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/sardonicpresence/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/sardonicpresence/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sardonicpresence/cabal/labels{/name}","releases_url":"https://api.github.com/repos/sardonicpresence/cabal/releases{/id}","created_at":"2014-06-14T05:50:24Z","updated_at":"2014-06-26T16:19:09Z","pushed_at":"2014-06-26T16:19:09Z","git_url":"git://github.com/sardonicpresence/cabal.git","ssh_url":"git@github.com:sardonicpresence/cabal.git","clone_url":"https://github.com/sardonicpresence/cabal.git","svn_url":"https://github.com/sardonicpresence/cabal","homepage":"","size":23394,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"cb4f1ac2aedadc54a3acd51658279658d5493a9f","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?","gravatar_id":"f92c0b083ed9db8211f9e58d7facbcc0","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":3728161,"name":"cabal","full_name":"haskell/cabal","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?","gravatar_id":"f92c0b083ed9db8211f9e58d7facbcc0","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":false,"url":"https://api.github.com/repos/haskell/cabal","forks_url":"https://api.github.com/repos/haskell/cabal/forks","keys_url":"https://api.github.com/repos/haskell/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/cabal/teams","hooks_url":"https://api.github.com/repos/haskell/cabal/hooks","issue_events_url":"https://api.github.com/repos/haskell/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/cabal/events","assignees_url":"https://api.github.com/repos/haskell/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/cabal/tags","blobs_url":"https://api.github.com/repos/haskell/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/cabal/languages","stargazers_url":"https://api.github.com/repos/haskell/cabal/stargazers","contributors_url":"https://api.github.com/repos/haskell/cabal/contributors","subscribers_url":"https://api.github.com/repos/haskell/cabal/subscribers","subscription_url":"https://api.github.com/repos/haskell/cabal/subscription","commits_url":"https://api.github.com/repos/haskell/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/cabal/issues/comments/{number}","contents_url":"https://api.github.com/repos/haskell/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/cabal/merges","archive_url":"https://api.github.com/repos/haskell/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/cabal/downloads","issues_url":"https://api.github.com/repos/haskell/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/cabal/labels{/name}","releases_url":"https://api.github.com/repos/haskell/cabal/releases{/id}","created_at":"2012-03-15T12:53:38Z","updated_at":"2014-07-13T01:49:12Z","pushed_at":"2014-07-15T08:51:13Z","git_url":"git://github.com/haskell/cabal.git","ssh_url":"git@github.com:haskell/cabal.git","clone_url":"https://github.com/haskell/cabal.git","svn_url":"https://github.com/haskell/cabal","homepage":"http://haskell.org/cabal","size":32434,"stargazers_count":336,"watchers_count":336,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":180,"mirror_url":null,"open_issues_count":563,"forks":180,"open_issues":563,"watchers":336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/1947"},"html":{"href":"https://github.com/haskell/cabal/pull/1947"},"issue":{"href":"https://api.github.com/repos/haskell/cabal/issues/1947"},"comments":{"href":"https://api.github.com/repos/haskell/cabal/issues/1947/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/cabal/pulls/1947/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/haskell/cabal/pulls/1947/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/cabal/statuses/2ff605857fbd21ff3f9a976384d78cd439623088"}}}}