GitHub PullRequestReviewCommentEvent at 2014-08-29 14:11:57
Repository: debug_kit
Actor: ravage84
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/debug_kit/pulls/comments/16899374","id":16899374,"diff_hunk":"@@ -0,0 +1,87 @@\n+<?php\n+/**\n+ * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)\n+ * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)\n+ *\n+ * Licensed under The MIT License\n+ * Redistributions of files must retain the above copyright notice.\n+ *\n+ * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)\n+ * @link          http://cakephp.org CakePHP(tm) Project\n+ * @since         DebugKit 3.0.0\n+ * @license       http://www.opensource.org/licenses/mit-license.php MIT License\n+ */\n+namespace DebugKit\\Test\\TestCase\\Controller;\n+\n+use Cake\\Cache\\Cache;\n+use Cake\\Routing\\Router;\n+use Cake\\TestSuite\\ControllerTestCase;\n+\n+/**\n+ * Toolbar controller test.\n+ */\n+class ToolbarControllerTestCase extends ControllerTestCase {\n+\n+/**\n+ * Fixtures.\n+ *\n+ * @var array\n+ */\n+\tpublic $fixtures = ['plugin.debug_kit.request', 'plugin.debug_kit.panel'];\n+\n+/**\n+ * Don't reload routes.\n+ *\n+ * @var bool\n+ */\n+\tpublic $loadRoutes = false;\n+\n+/**\n+ * Setup method.\n+ *\n+ * @return void\n+ */\n+\tpublic function setUp() {\n+\t\tparent::setUp();\n+\t\tRouter::plugin('DebugKit', function($routes) {\n+\t\t\t$routes->connect(\n+\t\t\t\t'/toolbar/clear_cache/*',\n+\t\t\t\t['plugin' => 'DebugKit', 'controller' => 'Toolbar', 'action' => 'clearCache']);\n+\t\t});\n+\t}\n+\n+/**\n+ * Test clearing the cache does not work with GET\n+ *\n+ * @expectedException Cake\\Error\\MethodNotAllowedException\n+ */\n+\tpublic function testClearCacheNoGet() {\n+\t\t$this->testAction('/debug_kit/toolbar/clear_cache', [\n+\t\t\t'method' => 'GET',\n+\t\t\t'query' => ['name' => 'testing'],\n+\t\t\t'return' => 'contents'\n+\t\t]);\n+\t}\n+\n+/**\n+ * Test clearing the cache.\n+ */","path":"tests/TestCase/Controller/ToolbarControllerTest.php","position":68,"original_position":68,"commit_id":"7fef8024282f57d890419ac99d93cbf97eeaa6b4","original_commit_id":"7fef8024282f57d890419ac99d93cbf97eeaa6b4","user":{"login":"ravage84","id":625761,"avatar_url":"https://avatars.githubusercontent.com/u/625761?v=2","gravatar_id":"20ed9d43e10978144f49a0d57743c369","url":"https://api.github.com/users/ravage84","html_url":"https://github.com/ravage84","followers_url":"https://api.github.com/users/ravage84/followers","following_url":"https://api.github.com/users/ravage84/following{/other_user}","gists_url":"https://api.github.com/users/ravage84/gists{/gist_id}","starred_url":"https://api.github.com/users/ravage84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravage84/subscriptions","organizations_url":"https://api.github.com/users/ravage84/orgs","repos_url":"https://api.github.com/users/ravage84/repos","events_url":"https://api.github.com/users/ravage84/events{/privacy}","received_events_url":"https://api.github.com/users/ravage84/received_events","type":"User","site_admin":false},"body":"Same","created_at":"2014-08-29T14:11:57Z","updated_at":"2014-08-29T14:11:57Z","html_url":"https://github.com/cakephp/debug_kit/pull/207#discussion_r16899374","pull_request_url":"https://api.github.com/repos/cakephp/debug_kit/pulls/207","_links":{"self":{"href":"https://api.github.com/repos/cakephp/debug_kit/pulls/comments/16899374"},"html":{"href":"https://github.com/cakephp/debug_kit/pull/207#discussion_r16899374"},"pull_request":{"href":"https://api.github.com/repos/cakephp/debug_kit/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/cakephp/debug_kit/pulls/207","id":20498603,"html_url":"https://github.com/cakephp/debug_kit/pull/207","diff_url":"https://github.com/cakephp/debug_kit/pull/207.diff","patch_url":"https://github.com/cakephp/debug_kit/pull/207.patch","issue_url":"https://api.github.com/repos/cakephp/debug_kit/issues/207","number":207,"state":"open","locked":false,"title":"Cache panel","user":{"login":"markstory","id":24086,"avatar_url":"https://avatars.githubusercontent.com/u/24086?v=2","gravatar_id":"669144d1ab0a861af5d54175371bc586","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"body":"This set of changes adds a panel to track cache use. It does a few things:\r\n\r\n* Track the number of read/write/delete operations on each cache engine.\r\n* Track the number of cache misses.\r\n* Add timers for each and every cache operation.\r\n* Provide a button to clear a cache from the UI.\r\n\r\nThis is all done by dynamically reconfiguring Cache at runtime with proxies. It was nice to see the investments we made around improving dependency injection pay off.","created_at":"2014-08-29T13:18:47Z","updated_at":"2014-08-29T14:11:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0046b730e18da525363b0c88107eeb8ee928ace","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cakephp/debug_kit/pulls/207/commits","review_comments_url":"https://api.github.com/repos/cakephp/debug_kit/pulls/207/comments","review_comment_url":"https://api.github.com/repos/cakephp/debug_kit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cakephp/debug_kit/issues/207/comments","statuses_url":"https://api.github.com/repos/cakephp/debug_kit/statuses/7fef8024282f57d890419ac99d93cbf97eeaa6b4","head":{"label":"cakephp:cache-panel","ref":"cache-panel","sha":"7fef8024282f57d890419ac99d93cbf97eeaa6b4","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=2","gravatar_id":"12cd092be901674cdbf0d3d964e945d5","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":423066,"name":"debug_kit","full_name":"cakephp/debug_kit","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=2","gravatar_id":"12cd092be901674cdbf0d3d964e945d5","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/debug_kit","description":"Official CakePHP Debug Kit Git Repository","fork":false,"url":"https://api.github.com/repos/cakephp/debug_kit","forks_url":"https://api.github.com/repos/cakephp/debug_kit/forks","keys_url":"https://api.github.com/repos/cakephp/debug_kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/debug_kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/debug_kit/teams","hooks_url":"https://api.github.com/repos/cakephp/debug_kit/hooks","issue_events_url":"https://api.github.com/repos/cakephp/debug_kit/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/debug_kit/events","assignees_url":"https://api.github.com/repos/cakephp/debug_kit/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/debug_kit/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/debug_kit/tags","blobs_url":"https://api.github.com/repos/cakephp/debug_kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/debug_kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/debug_kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/debug_kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/debug_kit/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/debug_kit/languages","stargazers_url":"https://api.github.com/repos/cakephp/debug_kit/stargazers","contributors_url":"https://api.github.com/repos/cakephp/debug_kit/contributors","subscribers_url":"https://api.github.com/repos/cakephp/debug_kit/subscribers","subscription_url":"https://api.github.com/repos/cakephp/debug_kit/subscription","commits_url":"https://api.github.com/repos/cakephp/debug_kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/debug_kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/debug_kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/debug_kit/issues/comments/{number}","contents_url":"https://api.github.com/repos/cakephp/debug_kit/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/debug_kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/debug_kit/merges","archive_url":"https://api.github.com/repos/cakephp/debug_kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/debug_kit/downloads","issues_url":"https://api.github.com/repos/cakephp/debug_kit/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/debug_kit/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/debug_kit/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/debug_kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/debug_kit/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/debug_kit/releases{/id}","created_at":"2009-12-12T03:24:12Z","updated_at":"2014-08-29T00:16:40Z","pushed_at":"2014-08-29T03:29:38Z","git_url":"git://github.com/cakephp/debug_kit.git","ssh_url":"git@github.com:cakephp/debug_kit.git","clone_url":"https://github.com/cakephp/debug_kit.git","svn_url":"https://github.com/cakephp/debug_kit","homepage":"http://cakephp.org","size":3865,"stargazers_count":782,"watchers_count":782,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":512,"mirror_url":null,"open_issues_count":18,"forks":512,"open_issues":18,"watchers":782,"default_branch":"master"}},"base":{"label":"cakephp:3.0","ref":"3.0","sha":"db97de6127a2c7bfc347fbbc71a03d42744fe22e","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=2","gravatar_id":"12cd092be901674cdbf0d3d964e945d5","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":423066,"name":"debug_kit","full_name":"cakephp/debug_kit","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=2","gravatar_id":"12cd092be901674cdbf0d3d964e945d5","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/debug_kit","description":"Official CakePHP Debug Kit Git Repository","fork":false,"url":"https://api.github.com/repos/cakephp/debug_kit","forks_url":"https://api.github.com/repos/cakephp/debug_kit/forks","keys_url":"https://api.github.com/repos/cakephp/debug_kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/debug_kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/debug_kit/teams","hooks_url":"https://api.github.com/repos/cakephp/debug_kit/hooks","issue_events_url":"https://api.github.com/repos/cakephp/debug_kit/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/debug_kit/events","assignees_url":"https://api.github.com/repos/cakephp/debug_kit/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/debug_kit/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/debug_kit/tags","blobs_url":"https://api.github.com/repos/cakephp/debug_kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/debug_kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/debug_kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/debug_kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/debug_kit/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/debug_kit/languages","stargazers_url":"https://api.github.com/repos/cakephp/debug_kit/stargazers","contributors_url":"https://api.github.com/repos/cakephp/debug_kit/contributors","subscribers_url":"https://api.github.com/repos/cakephp/debug_kit/subscribers","subscription_url":"https://api.github.com/repos/cakephp/debug_kit/subscription","commits_url":"https://api.github.com/repos/cakephp/debug_kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/debug_kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/debug_kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/debug_kit/issues/comments/{number}","contents_url":"https://api.github.com/repos/cakephp/debug_kit/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/debug_kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/debug_kit/merges","archive_url":"https://api.github.com/repos/cakephp/debug_kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/debug_kit/downloads","issues_url":"https://api.github.com/repos/cakephp/debug_kit/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/debug_kit/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/debug_kit/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/debug_kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/debug_kit/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/debug_kit/releases{/id}","created_at":"2009-12-12T03:24:12Z","updated_at":"2014-08-29T00:16:40Z","pushed_at":"2014-08-29T03:29:38Z","git_url":"git://github.com/cakephp/debug_kit.git","ssh_url":"git@github.com:cakephp/debug_kit.git","clone_url":"https://github.com/cakephp/debug_kit.git","svn_url":"https://github.com/cakephp/debug_kit","homepage":"http://cakephp.org","size":3865,"stargazers_count":782,"watchers_count":782,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":512,"mirror_url":null,"open_issues_count":18,"forks":512,"open_issues":18,"watchers":782,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/debug_kit/pulls/207"},"html":{"href":"https://github.com/cakephp/debug_kit/pull/207"},"issue":{"href":"https://api.github.com/repos/cakephp/debug_kit/issues/207"},"comments":{"href":"https://api.github.com/repos/cakephp/debug_kit/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/debug_kit/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/debug_kit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cakephp/debug_kit/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/debug_kit/statuses/7fef8024282f57d890419ac99d93cbf97eeaa6b4"}}}}