GitHub PullRequestEvent at 2014-08-05 09:10:56
Repository: freeradius-server
Actor: nchaigne
Payload: {"action":"opened","number":755,"pull_request":{"url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/755","id":19330280,"html_url":"https://github.com/FreeRADIUS/freeradius-server/pull/755","diff_url":"https://github.com/FreeRADIUS/freeradius-server/pull/755.diff","patch_url":"https://github.com/FreeRADIUS/freeradius-server/pull/755.patch","issue_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues/755","number":755,"state":"open","title":"dhcpclient - allow to specify interface and send/recv at raw packet level","user":{"login":"nchaigne","id":6780490,"avatar_url":"https://avatars.githubusercontent.com/u/6780490?v=2","gravatar_id":"30403a7edc431fc5135776b735e75859","url":"https://api.github.com/users/nchaigne","html_url":"https://github.com/nchaigne","followers_url":"https://api.github.com/users/nchaigne/followers","following_url":"https://api.github.com/users/nchaigne/following{/other_user}","gists_url":"https://api.github.com/users/nchaigne/gists{/gist_id}","starred_url":"https://api.github.com/users/nchaigne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nchaigne/subscriptions","organizations_url":"https://api.github.com/users/nchaigne/orgs","repos_url":"https://api.github.com/users/nchaigne/repos","events_url":"https://api.github.com/users/nchaigne/events{/privacy}","received_events_url":"https://api.github.com/users/nchaigne/received_events","type":"User","site_admin":false},"body":"This replace the following pull request (which can be closed):\r\nhttps://github.com/FreeRADIUS/freeradius-server/pull/741\r\n\r\n\r\n\r\nAs discussed earlier on the list:\r\n- if the client host has multiple interfaces,\r\n- and at least one of them already has an IP address, Then the source IP\r\naddress cannot be 0.0.0.0 (even with \"Packet-Src-IP-Address=0.0.0.0\").\r\nAn actual IP address is automatically used as source.\r\nThis is modified by the device driver.\r\n\r\nThis patch does the following:\r\n- Add an option to dhcpclient allowing to specify which network\r\ninterface to use.\r\n- Open a raw socket on the low level packet interface. This allows\r\npacket data to be left unchanged by the device driver.\r\n- Encode Ethernet (send to ff:ff:ff:ff:ff:ff), IP and UDP layers\r\nmanually. And let FreeRADIUS do the DHCP stuff, as before.\r\n\r\n(This required new specific socket / send / recv functions.)\r\n\r\nThe existing behaviour of dhcpclient is unchanged, it is used if the new\r\noption -i is not set (or if destination is not broadcast).","created_at":"2014-08-05T09:10:55Z","updated_at":"2014-08-05T09:10:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/755/commits","review_comments_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/755/comments","review_comment_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/comments/{number}","comments_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues/755/comments","statuses_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/statuses/377787e57ab9a2e11f7452c7aafd8efb83512ba3","head":{"label":"nchaigne:v3.0.x","ref":"v3.0.x","sha":"377787e57ab9a2e11f7452c7aafd8efb83512ba3","user":{"login":"nchaigne","id":6780490,"avatar_url":"https://avatars.githubusercontent.com/u/6780490?v=2","gravatar_id":"30403a7edc431fc5135776b735e75859","url":"https://api.github.com/users/nchaigne","html_url":"https://github.com/nchaigne","followers_url":"https://api.github.com/users/nchaigne/followers","following_url":"https://api.github.com/users/nchaigne/following{/other_user}","gists_url":"https://api.github.com/users/nchaigne/gists{/gist_id}","starred_url":"https://api.github.com/users/nchaigne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nchaigne/subscriptions","organizations_url":"https://api.github.com/users/nchaigne/orgs","repos_url":"https://api.github.com/users/nchaigne/repos","events_url":"https://api.github.com/users/nchaigne/events{/privacy}","received_events_url":"https://api.github.com/users/nchaigne/received_events","type":"User","site_admin":false},"repo":{"id":22636538,"name":"freeradius-server","full_name":"nchaigne/freeradius-server","owner":{"login":"nchaigne","id":6780490,"avatar_url":"https://avatars.githubusercontent.com/u/6780490?v=2","gravatar_id":"30403a7edc431fc5135776b735e75859","url":"https://api.github.com/users/nchaigne","html_url":"https://github.com/nchaigne","followers_url":"https://api.github.com/users/nchaigne/followers","following_url":"https://api.github.com/users/nchaigne/following{/other_user}","gists_url":"https://api.github.com/users/nchaigne/gists{/gist_id}","starred_url":"https://api.github.com/users/nchaigne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nchaigne/subscriptions","organizations_url":"https://api.github.com/users/nchaigne/orgs","repos_url":"https://api.github.com/users/nchaigne/repos","events_url":"https://api.github.com/users/nchaigne/events{/privacy}","received_events_url":"https://api.github.com/users/nchaigne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nchaigne/freeradius-server","description":"The FreeRADIUS Server.  RADIUS, DHCP, and VMPS.","fork":true,"url":"https://api.github.com/repos/nchaigne/freeradius-server","forks_url":"https://api.github.com/repos/nchaigne/freeradius-server/forks","keys_url":"https://api.github.com/repos/nchaigne/freeradius-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nchaigne/freeradius-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nchaigne/freeradius-server/teams","hooks_url":"https://api.github.com/repos/nchaigne/freeradius-server/hooks","issue_events_url":"https://api.github.com/repos/nchaigne/freeradius-server/issues/events{/number}","events_url":"https://api.github.com/repos/nchaigne/freeradius-server/events","assignees_url":"https://api.github.com/repos/nchaigne/freeradius-server/assignees{/user}","branches_url":"https://api.github.com/repos/nchaigne/freeradius-server/branches{/branch}","tags_url":"https://api.github.com/repos/nchaigne/freeradius-server/tags","blobs_url":"https://api.github.com/repos/nchaigne/freeradius-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nchaigne/freeradius-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nchaigne/freeradius-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nchaigne/freeradius-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nchaigne/freeradius-server/statuses/{sha}","languages_url":"https://api.github.com/repos/nchaigne/freeradius-server/languages","stargazers_url":"https://api.github.com/repos/nchaigne/freeradius-server/stargazers","contributors_url":"https://api.github.com/repos/nchaigne/freeradius-server/contributors","subscribers_url":"https://api.github.com/repos/nchaigne/freeradius-server/subscribers","subscription_url":"https://api.github.com/repos/nchaigne/freeradius-server/subscription","commits_url":"https://api.github.com/repos/nchaigne/freeradius-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nchaigne/freeradius-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nchaigne/freeradius-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nchaigne/freeradius-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/nchaigne/freeradius-server/contents/{+path}","compare_url":"https://api.github.com/repos/nchaigne/freeradius-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nchaigne/freeradius-server/merges","archive_url":"https://api.github.com/repos/nchaigne/freeradius-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nchaigne/freeradius-server/downloads","issues_url":"https://api.github.com/repos/nchaigne/freeradius-server/issues{/number}","pulls_url":"https://api.github.com/repos/nchaigne/freeradius-server/pulls{/number}","milestones_url":"https://api.github.com/repos/nchaigne/freeradius-server/milestones{/number}","notifications_url":"https://api.github.com/repos/nchaigne/freeradius-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nchaigne/freeradius-server/labels{/name}","releases_url":"https://api.github.com/repos/nchaigne/freeradius-server/releases{/id}","created_at":"2014-08-05T08:38:23Z","updated_at":"2014-07-29T16:16:52Z","pushed_at":"2014-08-05T09:07:15Z","git_url":"git://github.com/nchaigne/freeradius-server.git","ssh_url":"git@github.com:nchaigne/freeradius-server.git","clone_url":"https://github.com/nchaigne/freeradius-server.git","svn_url":"https://github.com/nchaigne/freeradius-server","homepage":"http://freeradius.org","size":87558,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FreeRADIUS:v3.0.x","ref":"v3.0.x","sha":"e94616e915de74f2841bc2e5594d89049abb6822","user":{"login":"FreeRADIUS","id":2430370,"avatar_url":"https://avatars.githubusercontent.com/u/2430370?v=2","gravatar_id":"acafaaf6fa20d26886e995d98f45e897","url":"https://api.github.com/users/FreeRADIUS","html_url":"https://github.com/FreeRADIUS","followers_url":"https://api.github.com/users/FreeRADIUS/followers","following_url":"https://api.github.com/users/FreeRADIUS/following{/other_user}","gists_url":"https://api.github.com/users/FreeRADIUS/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRADIUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRADIUS/subscriptions","organizations_url":"https://api.github.com/users/FreeRADIUS/orgs","repos_url":"https://api.github.com/users/FreeRADIUS/repos","events_url":"https://api.github.com/users/FreeRADIUS/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRADIUS/received_events","type":"Organization","site_admin":false},"repo":{"id":35649,"name":"freeradius-server","full_name":"FreeRADIUS/freeradius-server","owner":{"login":"FreeRADIUS","id":2430370,"avatar_url":"https://avatars.githubusercontent.com/u/2430370?v=2","gravatar_id":"acafaaf6fa20d26886e995d98f45e897","url":"https://api.github.com/users/FreeRADIUS","html_url":"https://github.com/FreeRADIUS","followers_url":"https://api.github.com/users/FreeRADIUS/followers","following_url":"https://api.github.com/users/FreeRADIUS/following{/other_user}","gists_url":"https://api.github.com/users/FreeRADIUS/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRADIUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRADIUS/subscriptions","organizations_url":"https://api.github.com/users/FreeRADIUS/orgs","repos_url":"https://api.github.com/users/FreeRADIUS/repos","events_url":"https://api.github.com/users/FreeRADIUS/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRADIUS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeRADIUS/freeradius-server","description":"The FreeRADIUS Server.  RADIUS, DHCP, and VMPS.","fork":false,"url":"https://api.github.com/repos/FreeRADIUS/freeradius-server","forks_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/forks","keys_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/teams","hooks_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/hooks","issue_events_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues/events{/number}","events_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/events","assignees_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/assignees{/user}","branches_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/branches{/branch}","tags_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/tags","blobs_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/languages","stargazers_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/stargazers","contributors_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/contributors","subscribers_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/subscribers","subscription_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/subscription","commits_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/contents/{+path}","compare_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/merges","archive_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/downloads","issues_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues{/number}","pulls_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/labels{/name}","releases_url":"https://api.github.com/repos/FreeRADIUS/freeradius-server/releases{/id}","created_at":"2008-07-20T18:04:09Z","updated_at":"2014-07-29T16:16:52Z","pushed_at":"2014-08-05T03:19:20Z","git_url":"git://github.com/FreeRADIUS/freeradius-server.git","ssh_url":"git@github.com:FreeRADIUS/freeradius-server.git","clone_url":"https://github.com/FreeRADIUS/freeradius-server.git","svn_url":"https://github.com/FreeRADIUS/freeradius-server","homepage":"http://freeradius.org","size":87558,"stargazers_count":209,"watchers_count":209,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":208,"mirror_url":null,"open_issues_count":21,"forks":208,"open_issues":21,"watchers":209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/755"},"html":{"href":"https://github.com/FreeRADIUS/freeradius-server/pull/755"},"issue":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues/755"},"comments":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/issues/755/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/755/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/pulls/755/commits"},"statuses":{"href":"https://api.github.com/repos/FreeRADIUS/freeradius-server/statuses/377787e57ab9a2e11f7452c7aafd8efb83512ba3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":542,"deletions":27,"changed_files":5}}