GitHub PullRequestReviewCommentEvent at 2014-07-09 08:40:36
Repository: govuk_content_models
Actor: vinayvinay
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/govuk_content_models/pulls/comments/14698721","id":14698721,"diff_hunk":"@@ -93,10 +93,12 @@ def send_fact_check(edition, details)\n     take_action(edition, __method__, details)\n   end\n \n-  # Advances state if possible (i.e. if in \"fact_check\" state)\n   # Always records the action.\n   def receive_fact_check(edition, details)\n-    edition.receive_fact_check\n+    # advance state if possible (i.e. if in \"fact_check\" state),\n+    # save separately without validation\n+    edition.receive_fact_check(false)","path":"app/models/workflow_actor.rb","position":null,"original_position":10,"commit_id":"09b56a0526343fd14badf66b473769dd641e155a","original_commit_id":"e8eec71471a8b8ade98b34c6a947673b9c59150e","user":{"login":"vinayvinay","id":230074,"avatar_url":"https://avatars.githubusercontent.com/u/230074?","gravatar_id":"3178e805eaaa2705c941a4d5f1a03e91","url":"https://api.github.com/users/vinayvinay","html_url":"https://github.com/vinayvinay","followers_url":"https://api.github.com/users/vinayvinay/followers","following_url":"https://api.github.com/users/vinayvinay/following{/other_user}","gists_url":"https://api.github.com/users/vinayvinay/gists{/gist_id}","starred_url":"https://api.github.com/users/vinayvinay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinayvinay/subscriptions","organizations_url":"https://api.github.com/users/vinayvinay/orgs","repos_url":"https://api.github.com/users/vinayvinay/repos","events_url":"https://api.github.com/users/vinayvinay/events{/privacy}","received_events_url":"https://api.github.com/users/vinayvinay/received_events","type":"User","site_admin":false},"body":"@danielroseman: corrected, :point_up:","created_at":"2014-07-09T08:40:36Z","updated_at":"2014-07-09T08:40:36Z","html_url":"https://github.com/alphagov/govuk_content_models/pull/191#discussion_r14698721","pull_request_url":"https://api.github.com/repos/alphagov/govuk_content_models/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk_content_models/pulls/comments/14698721"},"html":{"href":"https://github.com/alphagov/govuk_content_models/pull/191#discussion_r14698721"},"pull_request":{"href":"https://api.github.com/repos/alphagov/govuk_content_models/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk_content_models/pulls/191","id":18146453,"html_url":"https://github.com/alphagov/govuk_content_models/pull/191","diff_url":"https://github.com/alphagov/govuk_content_models/pull/191.diff","patch_url":"https://github.com/alphagov/govuk_content_models/pull/191.patch","issue_url":"https://api.github.com/repos/alphagov/govuk_content_models/issues/191","number":191,"state":"open","title":"Errors shouldn't block receiving fact check","user":{"login":"vinayvinay","id":230074,"avatar_url":"https://avatars.githubusercontent.com/u/230074?","gravatar_id":"3178e805eaaa2705c941a4d5f1a03e91","url":"https://api.github.com/users/vinayvinay","html_url":"https://github.com/vinayvinay","followers_url":"https://api.github.com/users/vinayvinay/followers","following_url":"https://api.github.com/users/vinayvinay/following{/other_user}","gists_url":"https://api.github.com/users/vinayvinay/gists{/gist_id}","starred_url":"https://api.github.com/users/vinayvinay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinayvinay/subscriptions","organizations_url":"https://api.github.com/users/vinayvinay/orgs","repos_url":"https://api.github.com/users/vinayvinay/repos","events_url":"https://api.github.com/users/vinayvinay/events{/privacy}","received_events_url":"https://api.github.com/users/vinayvinay/received_events","type":"User","site_admin":false},"body":"www.agileplannerapp.com/boards/173808/cards/5005\r\n\r\nthe edition mentioned in the story had invalid links in one of its parts. errors were causing it to remain in 'fact_check' even after calling event 'receive_fact_check'.\r\n\r\nit seems unnecessary to validate the document when we're receiving fact check response, hence this change.","created_at":"2014-07-09T08:03:46Z","updated_at":"2014-07-09T08:40:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"916d99175d9eaee0d1979635e432d28c3781a12e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk_content_models/pulls/191/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk_content_models/pulls/191/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk_content_models/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/govuk_content_models/issues/191/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk_content_models/statuses/09b56a0526343fd14badf66b473769dd641e155a","head":{"label":"alphagov:production-bug-importing-vehicles","ref":"production-bug-importing-vehicles","sha":"09b56a0526343fd14badf66b473769dd641e155a","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":4324088,"name":"govuk_content_models","full_name":"alphagov/govuk_content_models","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk_content_models","description":"Shared content models for Panopticon and Publisher, as an Engine.","fork":false,"url":"https://api.github.com/repos/alphagov/govuk_content_models","forks_url":"https://api.github.com/repos/alphagov/govuk_content_models/forks","keys_url":"https://api.github.com/repos/alphagov/govuk_content_models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk_content_models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk_content_models/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk_content_models/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk_content_models/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk_content_models/events","assignees_url":"https://api.github.com/repos/alphagov/govuk_content_models/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk_content_models/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk_content_models/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk_content_models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk_content_models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk_content_models/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk_content_models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk_content_models/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk_content_models/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk_content_models/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk_content_models/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk_content_models/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk_content_models/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk_content_models/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk_content_models/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk_content_models/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk_content_models/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/govuk_content_models/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk_content_models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk_content_models/merges","archive_url":"https://api.github.com/repos/alphagov/govuk_content_models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk_content_models/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk_content_models/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk_content_models/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk_content_models/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk_content_models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk_content_models/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk_content_models/releases{/id}","created_at":"2012-05-14T13:17:38Z","updated_at":"2014-06-26T15:44:23Z","pushed_at":"2014-07-09T08:33:35Z","git_url":"git://github.com/alphagov/govuk_content_models.git","ssh_url":"git@github.com:alphagov/govuk_content_models.git","clone_url":"https://github.com/alphagov/govuk_content_models.git","svn_url":"https://github.com/alphagov/govuk_content_models","homepage":null,"size":6347,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"3bce05beece2cfe73ac60dedd27aa72614dc4ddb","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":4324088,"name":"govuk_content_models","full_name":"alphagov/govuk_content_models","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk_content_models","description":"Shared content models for Panopticon and Publisher, as an Engine.","fork":false,"url":"https://api.github.com/repos/alphagov/govuk_content_models","forks_url":"https://api.github.com/repos/alphagov/govuk_content_models/forks","keys_url":"https://api.github.com/repos/alphagov/govuk_content_models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk_content_models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk_content_models/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk_content_models/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk_content_models/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk_content_models/events","assignees_url":"https://api.github.com/repos/alphagov/govuk_content_models/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk_content_models/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk_content_models/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk_content_models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk_content_models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk_content_models/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk_content_models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk_content_models/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk_content_models/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk_content_models/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk_content_models/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk_content_models/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk_content_models/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk_content_models/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk_content_models/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk_content_models/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk_content_models/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/govuk_content_models/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk_content_models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk_content_models/merges","archive_url":"https://api.github.com/repos/alphagov/govuk_content_models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk_content_models/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk_content_models/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk_content_models/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk_content_models/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk_content_models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk_content_models/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk_content_models/releases{/id}","created_at":"2012-05-14T13:17:38Z","updated_at":"2014-06-26T15:44:23Z","pushed_at":"2014-07-09T08:33:35Z","git_url":"git://github.com/alphagov/govuk_content_models.git","ssh_url":"git@github.com:alphagov/govuk_content_models.git","clone_url":"https://github.com/alphagov/govuk_content_models.git","svn_url":"https://github.com/alphagov/govuk_content_models","homepage":null,"size":6347,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk_content_models/pulls/191"},"html":{"href":"https://github.com/alphagov/govuk_content_models/pull/191"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk_content_models/issues/191"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk_content_models/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk_content_models/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk_content_models/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk_content_models/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk_content_models/statuses/09b56a0526343fd14badf66b473769dd641e155a"}}}}