GitHub PullRequestReviewCommentEvent at 2014-02-05 18:43:09
Repository: edx-tim
Actor: ormsbee
Payload: {"comment":{"url":"https://api.github.com/repos/edx/edx-tim/pulls/comments/9472316","id":9472316,"diff_hunk":"@@ -58,9 +46,15 @@ class Meta:\n class Submission(models.Model):\n     \"\"\"A single response by a student for a given problem in a given course.\n \n-    A student may have multiple submissions for the same problem.\n+    A student may have multiple submissions for the same problem. Submissions\n+    should never be mutated. If the student makes another Submission, or if we\n+    have to make corrective Submissions to fix bugs, those should be new\n+    objects. We want to keep Submissions immutable both for audit purposes, and\n+    because it makes caching trivial.\n \n     \"\"\"\n+    uuid = UUIDField(primary_key=True)","path":"apps/submissions/models.py","position":40,"original_position":40,"commit_id":"6d5e33127d53fd967ba81ba4ba76f088c8b1c7fa","original_commit_id":"42848cf61913eb7ca551b29e694d680ff344c726","user":{"login":"ormsbee","id":41625,"avatar_url":"https://gravatar.com/avatar/36df5c42f80b1152b764c7ddac7e4d8a?d=https%3A%2F%2Fidenticons.github.com%2Fb0c58d6ddaf657626dbbe772558dfce4.png&r=x","gravatar_id":"36df5c42f80b1152b764c7ddac7e4d8a","url":"https://api.github.com/users/ormsbee","html_url":"https://github.com/ormsbee","followers_url":"https://api.github.com/users/ormsbee/followers","following_url":"https://api.github.com/users/ormsbee/following{/other_user}","gists_url":"https://api.github.com/users/ormsbee/gists{/gist_id}","starred_url":"https://api.github.com/users/ormsbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ormsbee/subscriptions","organizations_url":"https://api.github.com/users/ormsbee/orgs","repos_url":"https://api.github.com/users/ormsbee/repos","events_url":"https://api.github.com/users/ormsbee/events{/privacy}","received_events_url":"https://api.github.com/users/ormsbee/received_events","type":"User","site_admin":false},"body":"Please don't make it the uuid the primary key. We can give it a unique index and do lookups on it for the purpose of the API, but if we make it the primary key, certain Django machinery (inheritance, generic relations) won't work properly.","created_at":"2014-02-05T18:43:09Z","updated_at":"2014-02-05T18:43:09Z","html_url":"https://github.com/edx/edx-tim/pull/26#discussion_r9472316","pull_request_url":"https://api.github.com/repos/edx/edx-tim/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-tim/pulls/comments/9472316"},"html":{"href":"https://github.com/edx/edx-tim/pull/26#discussion_r9472316"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-tim/pulls/26"}}}}