GitHub PullRequestReviewCommentEvent at 2014-05-15 18:47:37
Repository: react
Actor: spicyj
Payload: {"comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/12706198","id":12706198,"diff_hunk":"@@ -191,9 +202,16 @@ var EventPluginHub = {\n    */\n   deleteListener: function(id, registrationName) {\n     var bankForRegistrationName = listenerBank[registrationName];\n+    // TODO: This should never be null -- when is it?","path":"src/event/EventPluginHub.js","position":null,"original_position":36,"commit_id":"0f0e5b1c7492e7206b6dd57f0a81279cdef5967b","original_commit_id":"ccdbf1b8c6701c06d6c28eb66fb38c7e83a4d327","user":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?","gravatar_id":"5a6ea2485c7fc9b8eb0867ba6a3d40af","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"body":"Yeah, but the only caller (ReactDOMComponent) only calls if it's a valid name that was in prevProps (and so was presumably put already).","created_at":"2014-05-15T18:47:37Z","updated_at":"2014-05-15T18:47:37Z","html_url":"https://github.com/facebook/react/pull/1536#discussion_r12706198","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/1536","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/12706198"},"html":{"href":"https://github.com/facebook/react/pull/1536#discussion_r12706198"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/1536"}}}}