GitHub PullRequestReviewCommentEvent at 2014-09-05 19:34:46
Repository: easybuild-framework
Actor: boegel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/17192804","id":17192804,"diff_hunk":"@@ -1082,6 +1082,12 @@ def det_short_module_name(self, ec, force_visible=False):\n         self.log.debug(\"Determining short module name for %s (force_visible: %s)\" % (ec, force_visible))\n         mod_name = self._det_module_name_with(self.mns.det_short_module_name, ec, force_visible=force_visible)\n         self.log.debug(\"Obtained valid short module name %s\" % mod_name)\n+\n+        # sanity check: obtained module name should pass the 'is_module_for' check","path":"easybuild/framework/easyconfig/easyconfig.py","position":14,"original_position":14,"commit_id":"6b6cb7dffe2e5961f62186c976797232f773c931","original_commit_id":"6b6cb7dffe2e5961f62186c976797232f773c931","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=2","gravatar_id":"93efe8c67147791f743923763ff6197d","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"the check should only be done using a *short* module name (e.g. `OpenMPI/1.6.4`), never with a full module name (e.g. `Compiler/GCC/4.7.2/OpenMPI/1.6.4`), while `_det_module_name_with` is used for both short/full module names","created_at":"2014-09-05T19:34:46Z","updated_at":"2014-09-05T19:34:46Z","html_url":"https://github.com/hpcugent/easybuild-framework/pull/1017#discussion_r17192804","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1017","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/17192804"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/1017#discussion_r17192804"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1017"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1017","id":20167837,"html_url":"https://github.com/hpcugent/easybuild-framework/pull/1017","diff_url":"https://github.com/hpcugent/easybuild-framework/pull/1017.diff","patch_url":"https://github.com/hpcugent/easybuild-framework/pull/1017.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1017","number":1017,"state":"open","locked":false,"title":"fix conflict specification included in module files","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=2","gravatar_id":"93efe8c67147791f743923763ff6197d","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"fix conflict specification included in module files (see #994), base it on short module name obtained from active module naming scheme\r\n\r\nthis forced me to resort to another solution for verifying toolchain definitions vs the loaded toolchain module, since this basically means we can no longer obtain the (isolated) software name from a given module file (keeping in mind that a custom module naming scheme may be embedded a software name in some weird way)\r\n\r\nthe inner function `tc_elem_present` now using a regex to check whether a module name *could* be for a software package with the specified name, which is the best I can come up with\r\n\r\nthis approach should work most of the time, but it possible to come with a (weird) module naming scheme that breaks the assumptions made in `tc_elem_present`...","created_at":"2014-08-22T12:13:20Z","updated_at":"2014-09-05T19:34:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"caad9f1e1857e086fd7078a6a690cd6c2025974a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1017/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1017/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1017/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/6b6cb7dffe2e5961f62186c976797232f773c931","head":{"label":"boegel:fix_conflicts","ref":"fix_conflicts","sha":"6b6cb7dffe2e5961f62186c976797232f773c931","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=2","gravatar_id":"93efe8c67147791f743923763ff6197d","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"repo":{"id":4125402,"name":"easybuild-framework","full_name":"boegel/easybuild-framework","owner":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=2","gravatar_id":"93efe8c67147791f743923763ff6197d","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boegel/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":true,"url":"https://api.github.com/repos/boegel/easybuild-framework","forks_url":"https://api.github.com/repos/boegel/easybuild-framework/forks","keys_url":"https://api.github.com/repos/boegel/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boegel/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boegel/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/boegel/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/boegel/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/boegel/easybuild-framework/events","assignees_url":"https://api.github.com/repos/boegel/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/boegel/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/boegel/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/boegel/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boegel/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boegel/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/boegel/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boegel/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/boegel/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/boegel/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/boegel/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/boegel/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/boegel/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/boegel/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/boegel/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/boegel/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/boegel/easybuild-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/boegel/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/boegel/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boegel/easybuild-framework/merges","archive_url":"https://api.github.com/repos/boegel/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boegel/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/boegel/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/boegel/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/boegel/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/boegel/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boegel/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/boegel/easybuild-framework/releases{/id}","created_at":"2012-04-24T14:16:06Z","updated_at":"2014-06-24T15:04:17Z","pushed_at":"2014-09-05T18:04:22Z","git_url":"git://github.com/boegel/easybuild-framework.git","ssh_url":"git@github.com:boegel/easybuild-framework.git","clone_url":"https://github.com/boegel/easybuild-framework.git","svn_url":"https://github.com/boegel/easybuild-framework","homepage":"","size":14331,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"9772034270cff70a37e1fd3d3a7da8dce6d2f08e","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=2","gravatar_id":"b12f36a4d0f123b4b185272bf876c728","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":3662176,"name":"easybuild-framework","full_name":"hpcugent/easybuild-framework","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=2","gravatar_id":"b12f36a4d0f123b4b185272bf876c728","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-framework","forks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-framework/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-framework/releases{/id}","created_at":"2012-03-08T17:07:43Z","updated_at":"2014-08-13T15:51:33Z","pushed_at":"2014-09-05T07:19:40Z","git_url":"git://github.com/hpcugent/easybuild-framework.git","ssh_url":"git@github.com:hpcugent/easybuild-framework.git","clone_url":"https://github.com/hpcugent/easybuild-framework.git","svn_url":"https://github.com/hpcugent/easybuild-framework","homepage":"http://hpcugent.github.com/easybuild/","size":16624,"stargazers_count":36,"watchers_count":36,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":43,"mirror_url":null,"open_issues_count":211,"forks":43,"open_issues":211,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1017"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/1017"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1017"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1017/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1017/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1017/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/6b6cb7dffe2e5961f62186c976797232f773c931"}}}}