GitHub PullRequestReviewCommentEvent at 2014-07-16 16:10:00
Repository: go-contacts-api
Actor: hodgestar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/praekelt/go-contacts-api/pulls/comments/15008210","id":15008210,"diff_hunk":"@@ -60,13 +76,20 @@ def create(self, object_id, data):\n         \"\"\"\n         raise NotImplementedError()\n \n+    @inlineCallbacks\n     def update(self, object_id, data):\n         \"\"\"\n         Update an object. May return a deferred.\n \n         ``object_id`` may not be ``None``.\n         \"\"\"\n-        raise NotImplementedError()\n+        fields = self._pick_contact_fields(data)\n+        try:\n+            contact = yield self.contact_store.update_contact(\n+                object_id, **fields)\n+        except ContactNotFoundError:\n+            returnValue(None)\n+        returnValue(contact.get_data())","path":"go_contacts/backends/riak.py","position":50,"original_position":50,"commit_id":"59a37e91834b8a5d2efba9867f0041fb24ca9c28","original_commit_id":"59a37e91834b8a5d2efba9867f0041fb24ca9c28","user":{"login":"hodgestar","id":165551,"avatar_url":"https://avatars.githubusercontent.com/u/165551?","gravatar_id":"337cadae5be17c19e2defb615d7de9f8","url":"https://api.github.com/users/hodgestar","html_url":"https://github.com/hodgestar","followers_url":"https://api.github.com/users/hodgestar/followers","following_url":"https://api.github.com/users/hodgestar/following{/other_user}","gists_url":"https://api.github.com/users/hodgestar/gists{/gist_id}","starred_url":"https://api.github.com/users/hodgestar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hodgestar/subscriptions","organizations_url":"https://api.github.com/users/hodgestar/orgs","repos_url":"https://api.github.com/users/hodgestar/repos","events_url":"https://api.github.com/users/hodgestar/events{/privacy}","received_events_url":"https://api.github.com/users/hodgestar/received_events","type":"User","site_admin":false},"body":"Agreed. I've updated #3 to include that.","created_at":"2014-07-16T16:10:00Z","updated_at":"2014-07-16T16:10:00Z","html_url":"https://github.com/praekelt/go-contacts-api/pull/2#discussion_r15008210","pull_request_url":"https://api.github.com/repos/praekelt/go-contacts-api/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/praekelt/go-contacts-api/pulls/comments/15008210"},"html":{"href":"https://github.com/praekelt/go-contacts-api/pull/2#discussion_r15008210"},"pull_request":{"href":"https://api.github.com/repos/praekelt/go-contacts-api/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/praekelt/go-contacts-api/pulls/2","id":18475030,"html_url":"https://github.com/praekelt/go-contacts-api/pull/2","diff_url":"https://github.com/praekelt/go-contacts-api/pull/2.diff","patch_url":"https://github.com/praekelt/go-contacts-api/pull/2.patch","issue_url":"https://api.github.com/repos/praekelt/go-contacts-api/issues/2","number":2,"state":"open","title":"Implement contact updating.","user":{"login":"hodgestar","id":165551,"avatar_url":"https://avatars.githubusercontent.com/u/165551?","gravatar_id":"337cadae5be17c19e2defb615d7de9f8","url":"https://api.github.com/users/hodgestar","html_url":"https://github.com/hodgestar","followers_url":"https://api.github.com/users/hodgestar/followers","following_url":"https://api.github.com/users/hodgestar/following{/other_user}","gists_url":"https://api.github.com/users/hodgestar/gists{/gist_id}","starred_url":"https://api.github.com/users/hodgestar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hodgestar/subscriptions","organizations_url":"https://api.github.com/users/hodgestar/orgs","repos_url":"https://api.github.com/users/hodgestar/repos","events_url":"https://api.github.com/users/hodgestar/events{/privacy}","received_events_url":"https://api.github.com/users/hodgestar/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-16T15:26:31Z","updated_at":"2014-07-16T16:10:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2536109b96203ea6aa07f9d2a9ec878158dd2c0","assignee":{"login":"hodgestar","id":165551,"avatar_url":"https://avatars.githubusercontent.com/u/165551?","gravatar_id":"337cadae5be17c19e2defb615d7de9f8","url":"https://api.github.com/users/hodgestar","html_url":"https://github.com/hodgestar","followers_url":"https://api.github.com/users/hodgestar/followers","following_url":"https://api.github.com/users/hodgestar/following{/other_user}","gists_url":"https://api.github.com/users/hodgestar/gists{/gist_id}","starred_url":"https://api.github.com/users/hodgestar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hodgestar/subscriptions","organizations_url":"https://api.github.com/users/hodgestar/orgs","repos_url":"https://api.github.com/users/hodgestar/repos","events_url":"https://api.github.com/users/hodgestar/events{/privacy}","received_events_url":"https://api.github.com/users/hodgestar/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/praekelt/go-contacts-api/pulls/2/commits","review_comments_url":"https://api.github.com/repos/praekelt/go-contacts-api/pulls/2/comments","review_comment_url":"https://api.github.com/repos/praekelt/go-contacts-api/pulls/comments/{number}","comments_url":"https://api.github.com/repos/praekelt/go-contacts-api/issues/2/comments","statuses_url":"https://api.github.com/repos/praekelt/go-contacts-api/statuses/59a37e91834b8a5d2efba9867f0041fb24ca9c28","head":{"label":"praekelt:feature/issue-2-contact-updating","ref":"feature/issue-2-contact-updating","sha":"59a37e91834b8a5d2efba9867f0041fb24ca9c28","user":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?","gravatar_id":"47edf894fc0eb65da3ac49bba7086967","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"repo":{"id":21815898,"name":"go-contacts-api","full_name":"praekelt/go-contacts-api","owner":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?","gravatar_id":"47edf894fc0eb65da3ac49bba7086967","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekelt/go-contacts-api","description":"A contacts and group API for Vumi Go","fork":false,"url":"https://api.github.com/repos/praekelt/go-contacts-api","forks_url":"https://api.github.com/repos/praekelt/go-contacts-api/forks","keys_url":"https://api.github.com/repos/praekelt/go-contacts-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekelt/go-contacts-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekelt/go-contacts-api/teams","hooks_url":"https://api.github.com/repos/praekelt/go-contacts-api/hooks","issue_events_url":"https://api.github.com/repos/praekelt/go-contacts-api/issues/events{/number}","events_url":"https://api.github.com/repos/praekelt/go-contacts-api/events","assignees_url":"https://api.github.com/repos/praekelt/go-contacts-api/assignees{/user}","branches_url":"https://api.github.com/repos/praekelt/go-contacts-api/branches{/branch}","tags_url":"https://api.github.com/repos/praekelt/go-contacts-api/tags","blobs_url":"https://api.github.com/repos/praekelt/go-contacts-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekelt/go-contacts-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekelt/go-contacts-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekelt/go-contacts-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekelt/go-contacts-api/statuses/{sha}","languages_url":"https://api.github.com/repos/praekelt/go-contacts-api/languages","stargazers_url":"https://api.github.com/repos/praekelt/go-contacts-api/stargazers","contributors_url":"https://api.github.com/repos/praekelt/go-contacts-api/contributors","subscribers_url":"https://api.github.com/repos/praekelt/go-contacts-api/subscribers","subscription_url":"https://api.github.com/repos/praekelt/go-contacts-api/subscription","commits_url":"https://api.github.com/repos/praekelt/go-contacts-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekelt/go-contacts-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekelt/go-contacts-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekelt/go-contacts-api/issues/comments/{number}","contents_url":"https://api.github.com/repos/praekelt/go-contacts-api/contents/{+path}","compare_url":"https://api.github.com/repos/praekelt/go-contacts-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekelt/go-contacts-api/merges","archive_url":"https://api.github.com/repos/praekelt/go-contacts-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekelt/go-contacts-api/downloads","issues_url":"https://api.github.com/repos/praekelt/go-contacts-api/issues{/number}","pulls_url":"https://api.github.com/repos/praekelt/go-contacts-api/pulls{/number}","milestones_url":"https://api.github.com/repos/praekelt/go-contacts-api/milestones{/number}","notifications_url":"https://api.github.com/repos/praekelt/go-contacts-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekelt/go-contacts-api/labels{/name}","releases_url":"https://api.github.com/repos/praekelt/go-contacts-api/releases{/id}","created_at":"2014-07-14T10:29:23Z","updated_at":"2014-07-14T10:40:18Z","pushed_at":"2014-07-16T15:26:28Z","git_url":"git://github.com/praekelt/go-contacts-api.git","ssh_url":"git@github.com:praekelt/go-contacts-api.git","clone_url":"https://github.com/praekelt/go-contacts-api.git","svn_url":"https://github.com/praekelt/go-contacts-api","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"praekelt:develop","ref":"develop","sha":"f76c5b3e87c9bb5d11a8166a7a50e4a87a181460","user":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?","gravatar_id":"47edf894fc0eb65da3ac49bba7086967","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"repo":{"id":21815898,"name":"go-contacts-api","full_name":"praekelt/go-contacts-api","owner":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?","gravatar_id":"47edf894fc0eb65da3ac49bba7086967","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekelt/go-contacts-api","description":"A contacts and group API for Vumi Go","fork":false,"url":"https://api.github.com/repos/praekelt/go-contacts-api","forks_url":"https://api.github.com/repos/praekelt/go-contacts-api/forks","keys_url":"https://api.github.com/repos/praekelt/go-contacts-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekelt/go-contacts-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekelt/go-contacts-api/teams","hooks_url":"https://api.github.com/repos/praekelt/go-contacts-api/hooks","issue_events_url":"https://api.github.com/repos/praekelt/go-contacts-api/issues/events{/number}","events_url":"https://api.github.com/repos/praekelt/go-contacts-api/events","assignees_url":"https://api.github.com/repos/praekelt/go-contacts-api/assignees{/user}","branches_url":"https://api.github.com/repos/praekelt/go-contacts-api/branches{/branch}","tags_url":"https://api.github.com/repos/praekelt/go-contacts-api/tags","blobs_url":"https://api.github.com/repos/praekelt/go-contacts-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekelt/go-contacts-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekelt/go-contacts-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekelt/go-contacts-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekelt/go-contacts-api/statuses/{sha}","languages_url":"https://api.github.com/repos/praekelt/go-contacts-api/languages","stargazers_url":"https://api.github.com/repos/praekelt/go-contacts-api/stargazers","contributors_url":"https://api.github.com/repos/praekelt/go-contacts-api/contributors","subscribers_url":"https://api.github.com/repos/praekelt/go-contacts-api/subscribers","subscription_url":"https://api.github.com/repos/praekelt/go-contacts-api/subscription","commits_url":"https://api.github.com/repos/praekelt/go-contacts-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekelt/go-contacts-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekelt/go-contacts-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekelt/go-contacts-api/issues/comments/{number}","contents_url":"https://api.github.com/repos/praekelt/go-contacts-api/contents/{+path}","compare_url":"https://api.github.com/repos/praekelt/go-contacts-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekelt/go-contacts-api/merges","archive_url":"https://api.github.com/repos/praekelt/go-contacts-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekelt/go-contacts-api/downloads","issues_url":"https://api.github.com/repos/praekelt/go-contacts-api/issues{/number}","pulls_url":"https://api.github.com/repos/praekelt/go-contacts-api/pulls{/number}","milestones_url":"https://api.github.com/repos/praekelt/go-contacts-api/milestones{/number}","notifications_url":"https://api.github.com/repos/praekelt/go-contacts-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekelt/go-contacts-api/labels{/name}","releases_url":"https://api.github.com/repos/praekelt/go-contacts-api/releases{/id}","created_at":"2014-07-14T10:29:23Z","updated_at":"2014-07-14T10:40:18Z","pushed_at":"2014-07-16T15:26:28Z","git_url":"git://github.com/praekelt/go-contacts-api.git","ssh_url":"git@github.com:praekelt/go-contacts-api.git","clone_url":"https://github.com/praekelt/go-contacts-api.git","svn_url":"https://github.com/praekelt/go-contacts-api","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/praekelt/go-contacts-api/pulls/2"},"html":{"href":"https://github.com/praekelt/go-contacts-api/pull/2"},"issue":{"href":"https://api.github.com/repos/praekelt/go-contacts-api/issues/2"},"comments":{"href":"https://api.github.com/repos/praekelt/go-contacts-api/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/praekelt/go-contacts-api/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/praekelt/go-contacts-api/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/praekelt/go-contacts-api/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/praekelt/go-contacts-api/statuses/59a37e91834b8a5d2efba9867f0041fb24ca9c28"}}}}