GitHub PullRequestReviewCommentEvent at 2014-09-29 06:06:46
Repository: main
Actor: digawp
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/comments/18138398","id":18138398,"diff_hunk":"@@ -4,14 +4,79 @@\n #include \"datastore.h\"\n \n using Assert = Microsoft::VisualStudio::CppUnitTestFramework::Assert;\n+using DataStore = You::DataStore::DataStore;\n \n namespace YouDataStoreTests {\n+\n+const std::wstring TASK_ID = L\"id\";\n+const std::wstring DESCRIPTION = L\"desc\";\n+const std::wstring DEADLINE = L\"deadl\";\n+const std::wstring PRIORITY = L\"pri\";\n+const std::wstring DEPENDENCIES = L\"depend\";\n+const DataStore::STask stask = {\n+\t\t{ TASK_ID, L\"0\" },\n+\t\t{ DESCRIPTION, L\"bla bla\" },\n+\t\t{ DEADLINE, L\"xxxxxx\" },\n+\t\t{ PRIORITY, L\"urgent\" },\n+\t\t{ DEPENDENCIES, L\"12345\" }\n+};\n+\n TEST_CLASS(DataStoreApiTest) {\n public:\n-\tTEST_METHOD(DataStoreDummyTest) {\n-\t\t// You::DataStore::DataStore sut;\n-\t\t// sut.post(std::unordered_map<std::wstring, std::wstring>());\n-\t\tAssert::IsTrue(true);\n+\tDataStore sut;\n+\n+\tTEST_METHOD(DataStore_Post_Basic_Test) {\n+\t\t// Assert::IsTrue(sut.document.empty());\n+\t\tbool result = sut.post(0, DataStore::STask());","path":"You-DataStore-Tests/datastore_api_test.cpp","position":31,"original_position":31,"commit_id":"4db873deb08bc7fcb3c47d6ec95951e8104c73b4","original_commit_id":"08c3e91e27387ca40adef643e09633b75f4338a6","user":{"login":"digawp","id":6761424,"avatar_url":"https://avatars.githubusercontent.com/u/6761424?v=2","gravatar_id":"","url":"https://api.github.com/users/digawp","html_url":"https://github.com/digawp","followers_url":"https://api.github.com/users/digawp/followers","following_url":"https://api.github.com/users/digawp/following{/other_user}","gists_url":"https://api.github.com/users/digawp/gists{/gist_id}","starred_url":"https://api.github.com/users/digawp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digawp/subscriptions","organizations_url":"https://api.github.com/users/digawp/orgs","repos_url":"https://api.github.com/users/digawp/repos","events_url":"https://api.github.com/users/digawp/events{/privacy}","received_events_url":"https://api.github.com/users/digawp/received_events","type":"User","site_admin":false},"body":"But I can't access the privates of the DataStore right? An alternative would be to use get, but is it okay? I am supposed to test each component independently right?","created_at":"2014-09-29T06:06:46Z","updated_at":"2014-09-29T06:06:46Z","html_url":"https://github.com/cs2103aug2014-w10-1c/main/pull/80#discussion_r18138398","pull_request_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/comments/18138398"},"html":{"href":"https://github.com/cs2103aug2014-w10-1c/main/pull/80#discussion_r18138398"},"pull_request":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/80","id":21902967,"html_url":"https://github.com/cs2103aug2014-w10-1c/main/pull/80","diff_url":"https://github.com/cs2103aug2014-w10-1c/main/pull/80.diff","patch_url":"https://github.com/cs2103aug2014-w10-1c/main/pull/80.patch","issue_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues/80","number":80,"state":"open","locked":false,"title":"Implement primitive datastore operations","user":{"login":"digawp","id":6761424,"avatar_url":"https://avatars.githubusercontent.com/u/6761424?v=2","gravatar_id":"","url":"https://api.github.com/users/digawp","html_url":"https://github.com/digawp","followers_url":"https://api.github.com/users/digawp/followers","following_url":"https://api.github.com/users/digawp/following{/other_user}","gists_url":"https://api.github.com/users/digawp/gists{/gist_id}","starred_url":"https://api.github.com/users/digawp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digawp/subscriptions","organizations_url":"https://api.github.com/users/digawp/orgs","repos_url":"https://api.github.com/users/digawp/repos","events_url":"https://api.github.com/users/digawp/events{/privacy}","received_events_url":"https://api.github.com/users/digawp/received_events","type":"User","site_admin":false},"body":"Post, put, get, and erase.\r\nNot yet transactional, need to clarify something with @evansb first","created_at":"2014-09-28T15:34:04Z","updated_at":"2014-09-29T06:06:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"610a24e68771f9375a81d912250aff52ac31217c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/80/commits","review_comments_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/80/comments","review_comment_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues/80/comments","statuses_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/statuses/4db873deb08bc7fcb3c47d6ec95951e8104c73b4","head":{"label":"digawp:implement-datastore","ref":"implement-datastore","sha":"4db873deb08bc7fcb3c47d6ec95951e8104c73b4","user":{"login":"digawp","id":6761424,"avatar_url":"https://avatars.githubusercontent.com/u/6761424?v=2","gravatar_id":"","url":"https://api.github.com/users/digawp","html_url":"https://github.com/digawp","followers_url":"https://api.github.com/users/digawp/followers","following_url":"https://api.github.com/users/digawp/following{/other_user}","gists_url":"https://api.github.com/users/digawp/gists{/gist_id}","starred_url":"https://api.github.com/users/digawp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digawp/subscriptions","organizations_url":"https://api.github.com/users/digawp/orgs","repos_url":"https://api.github.com/users/digawp/repos","events_url":"https://api.github.com/users/digawp/events{/privacy}","received_events_url":"https://api.github.com/users/digawp/received_events","type":"User","site_admin":false},"repo":{"id":24126162,"name":"main","full_name":"digawp/main","owner":{"login":"digawp","id":6761424,"avatar_url":"https://avatars.githubusercontent.com/u/6761424?v=2","gravatar_id":"","url":"https://api.github.com/users/digawp","html_url":"https://github.com/digawp","followers_url":"https://api.github.com/users/digawp/followers","following_url":"https://api.github.com/users/digawp/following{/other_user}","gists_url":"https://api.github.com/users/digawp/gists{/gist_id}","starred_url":"https://api.github.com/users/digawp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digawp/subscriptions","organizations_url":"https://api.github.com/users/digawp/orgs","repos_url":"https://api.github.com/users/digawp/repos","events_url":"https://api.github.com/users/digawp/events{/privacy}","received_events_url":"https://api.github.com/users/digawp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/digawp/main","description":"The You Task Management App","fork":true,"url":"https://api.github.com/repos/digawp/main","forks_url":"https://api.github.com/repos/digawp/main/forks","keys_url":"https://api.github.com/repos/digawp/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digawp/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digawp/main/teams","hooks_url":"https://api.github.com/repos/digawp/main/hooks","issue_events_url":"https://api.github.com/repos/digawp/main/issues/events{/number}","events_url":"https://api.github.com/repos/digawp/main/events","assignees_url":"https://api.github.com/repos/digawp/main/assignees{/user}","branches_url":"https://api.github.com/repos/digawp/main/branches{/branch}","tags_url":"https://api.github.com/repos/digawp/main/tags","blobs_url":"https://api.github.com/repos/digawp/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digawp/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digawp/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/digawp/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digawp/main/statuses/{sha}","languages_url":"https://api.github.com/repos/digawp/main/languages","stargazers_url":"https://api.github.com/repos/digawp/main/stargazers","contributors_url":"https://api.github.com/repos/digawp/main/contributors","subscribers_url":"https://api.github.com/repos/digawp/main/subscribers","subscription_url":"https://api.github.com/repos/digawp/main/subscription","commits_url":"https://api.github.com/repos/digawp/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/digawp/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/digawp/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/digawp/main/issues/comments/{number}","contents_url":"https://api.github.com/repos/digawp/main/contents/{+path}","compare_url":"https://api.github.com/repos/digawp/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digawp/main/merges","archive_url":"https://api.github.com/repos/digawp/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digawp/main/downloads","issues_url":"https://api.github.com/repos/digawp/main/issues{/number}","pulls_url":"https://api.github.com/repos/digawp/main/pulls{/number}","milestones_url":"https://api.github.com/repos/digawp/main/milestones{/number}","notifications_url":"https://api.github.com/repos/digawp/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digawp/main/labels{/name}","releases_url":"https://api.github.com/repos/digawp/main/releases{/id}","created_at":"2014-09-17T02:13:34Z","updated_at":"2014-09-22T10:07:13Z","pushed_at":"2014-09-29T03:57:26Z","git_url":"git://github.com/digawp/main.git","ssh_url":"git@github.com:digawp/main.git","clone_url":"https://github.com/digawp/main.git","svn_url":"https://github.com/digawp/main","homepage":null,"size":500,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"datastore"}},"base":{"label":"cs2103aug2014-w10-1c:master","ref":"master","sha":"5c44207be960d6c216699bfdfd7c4caa93ca54d8","user":{"login":"cs2103aug2014-w10-1c","id":8623584,"avatar_url":"https://avatars.githubusercontent.com/u/8623584?v=2","gravatar_id":"","url":"https://api.github.com/users/cs2103aug2014-w10-1c","html_url":"https://github.com/cs2103aug2014-w10-1c","followers_url":"https://api.github.com/users/cs2103aug2014-w10-1c/followers","following_url":"https://api.github.com/users/cs2103aug2014-w10-1c/following{/other_user}","gists_url":"https://api.github.com/users/cs2103aug2014-w10-1c/gists{/gist_id}","starred_url":"https://api.github.com/users/cs2103aug2014-w10-1c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs2103aug2014-w10-1c/subscriptions","organizations_url":"https://api.github.com/users/cs2103aug2014-w10-1c/orgs","repos_url":"https://api.github.com/users/cs2103aug2014-w10-1c/repos","events_url":"https://api.github.com/users/cs2103aug2014-w10-1c/events{/privacy}","received_events_url":"https://api.github.com/users/cs2103aug2014-w10-1c/received_events","type":"Organization","site_admin":false},"repo":{"id":23566519,"name":"main","full_name":"cs2103aug2014-w10-1c/main","owner":{"login":"cs2103aug2014-w10-1c","id":8623584,"avatar_url":"https://avatars.githubusercontent.com/u/8623584?v=2","gravatar_id":"","url":"https://api.github.com/users/cs2103aug2014-w10-1c","html_url":"https://github.com/cs2103aug2014-w10-1c","followers_url":"https://api.github.com/users/cs2103aug2014-w10-1c/followers","following_url":"https://api.github.com/users/cs2103aug2014-w10-1c/following{/other_user}","gists_url":"https://api.github.com/users/cs2103aug2014-w10-1c/gists{/gist_id}","starred_url":"https://api.github.com/users/cs2103aug2014-w10-1c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs2103aug2014-w10-1c/subscriptions","organizations_url":"https://api.github.com/users/cs2103aug2014-w10-1c/orgs","repos_url":"https://api.github.com/users/cs2103aug2014-w10-1c/repos","events_url":"https://api.github.com/users/cs2103aug2014-w10-1c/events{/privacy}","received_events_url":"https://api.github.com/users/cs2103aug2014-w10-1c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cs2103aug2014-w10-1c/main","description":"The You Task Management App","fork":false,"url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main","forks_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/forks","keys_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/teams","hooks_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/hooks","issue_events_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues/events{/number}","events_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/events","assignees_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/assignees{/user}","branches_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/branches{/branch}","tags_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/tags","blobs_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/statuses/{sha}","languages_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/languages","stargazers_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/stargazers","contributors_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/contributors","subscribers_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/subscribers","subscription_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/subscription","commits_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues/comments/{number}","contents_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/contents/{+path}","compare_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/merges","archive_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/downloads","issues_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues{/number}","pulls_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls{/number}","milestones_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/milestones{/number}","notifications_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/labels{/name}","releases_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/releases{/id}","created_at":"2014-09-02T05:42:41Z","updated_at":"2014-09-20T03:39:44Z","pushed_at":"2014-09-28T22:45:08Z","git_url":"git://github.com/cs2103aug2014-w10-1c/main.git","ssh_url":"git@github.com:cs2103aug2014-w10-1c/main.git","clone_url":"https://github.com/cs2103aug2014-w10-1c/main.git","svn_url":"https://github.com/cs2103aug2014-w10-1c/main","homepage":null,"size":1414,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":32,"forks":4,"open_issues":32,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/80"},"html":{"href":"https://github.com/cs2103aug2014-w10-1c/main/pull/80"},"issue":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues/80"},"comments":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/statuses/4db873deb08bc7fcb3c47d6ec95951e8104c73b4"}}}}