GitHub PullRequestEvent at 2014-10-24 17:15:22
Repository: salt
Actor: plastikos
Payload: {"action":"opened","number":16878,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/16878","id":23310576,"html_url":"https://github.com/saltstack/salt/pull/16878","diff_url":"https://github.com/saltstack/salt/pull/16878.diff","patch_url":"https://github.com/saltstack/salt/pull/16878.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/16878","number":16878,"state":"open","locked":false,"title":"Improve filter_by() base argument:","user":{"login":"plastikos","id":3281727,"avatar_url":"https://avatars.githubusercontent.com/u/3281727?v=2","gravatar_id":"","url":"https://api.github.com/users/plastikos","html_url":"https://github.com/plastikos","followers_url":"https://api.github.com/users/plastikos/followers","following_url":"https://api.github.com/users/plastikos/following{/other_user}","gists_url":"https://api.github.com/users/plastikos/gists{/gist_id}","starred_url":"https://api.github.com/users/plastikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plastikos/subscriptions","organizations_url":"https://api.github.com/users/plastikos/orgs","repos_url":"https://api.github.com/users/plastikos/repos","events_url":"https://api.github.com/users/plastikos/events{/privacy}","received_events_url":"https://api.github.com/users/plastikos/received_events","type":"User","site_admin":false},"body":"  * Change filter_by() base argument to a key in lookup_dict rather\r\n    than a dictionary.  This allows more compact usage and more\r\n    readable use of base values/defaults in the lookup_dict.\r\n\r\n  * Change/improve function-local documentation for lookup_dict().\r\n\r\n  * Add specific use-case of \"base\" argument for lookup_dict() in the\r\n    formulas documentation.\r\n\r\n  * Expand filter_by() unit testing to validate use of base argument.\r\n\r\n  * Add unit test for salt.utils.dictupdate.update() to provide\r\n    complete depth-of-testing of filter_by() which uses\r\n    dictupdate.update().","created_at":"2014-10-24T17:15:21Z","updated_at":"2014-10-24T17:15:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/16878/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/16878/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments/{number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/16878/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/65e477dd67b43a60b8ff3318b01db61d2ea19ffd","head":{"label":"plastikos:improvement-filter_by","ref":"improvement-filter_by","sha":"65e477dd67b43a60b8ff3318b01db61d2ea19ffd","user":{"login":"plastikos","id":3281727,"avatar_url":"https://avatars.githubusercontent.com/u/3281727?v=2","gravatar_id":"","url":"https://api.github.com/users/plastikos","html_url":"https://github.com/plastikos","followers_url":"https://api.github.com/users/plastikos/followers","following_url":"https://api.github.com/users/plastikos/following{/other_user}","gists_url":"https://api.github.com/users/plastikos/gists{/gist_id}","starred_url":"https://api.github.com/users/plastikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plastikos/subscriptions","organizations_url":"https://api.github.com/users/plastikos/orgs","repos_url":"https://api.github.com/users/plastikos/repos","events_url":"https://api.github.com/users/plastikos/events{/privacy}","received_events_url":"https://api.github.com/users/plastikos/received_events","type":"User","site_admin":false},"repo":{"id":19778119,"name":"salt","full_name":"plastikos/salt","owner":{"login":"plastikos","id":3281727,"avatar_url":"https://avatars.githubusercontent.com/u/3281727?v=2","gravatar_id":"","url":"https://api.github.com/users/plastikos","html_url":"https://github.com/plastikos","followers_url":"https://api.github.com/users/plastikos/followers","following_url":"https://api.github.com/users/plastikos/following{/other_user}","gists_url":"https://api.github.com/users/plastikos/gists{/gist_id}","starred_url":"https://api.github.com/users/plastikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plastikos/subscriptions","organizations_url":"https://api.github.com/users/plastikos/orgs","repos_url":"https://api.github.com/users/plastikos/repos","events_url":"https://api.github.com/users/plastikos/events{/privacy}","received_events_url":"https://api.github.com/users/plastikos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/plastikos/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/plastikos/salt","forks_url":"https://api.github.com/repos/plastikos/salt/forks","keys_url":"https://api.github.com/repos/plastikos/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plastikos/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plastikos/salt/teams","hooks_url":"https://api.github.com/repos/plastikos/salt/hooks","issue_events_url":"https://api.github.com/repos/plastikos/salt/issues/events{/number}","events_url":"https://api.github.com/repos/plastikos/salt/events","assignees_url":"https://api.github.com/repos/plastikos/salt/assignees{/user}","branches_url":"https://api.github.com/repos/plastikos/salt/branches{/branch}","tags_url":"https://api.github.com/repos/plastikos/salt/tags","blobs_url":"https://api.github.com/repos/plastikos/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plastikos/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plastikos/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/plastikos/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plastikos/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/plastikos/salt/languages","stargazers_url":"https://api.github.com/repos/plastikos/salt/stargazers","contributors_url":"https://api.github.com/repos/plastikos/salt/contributors","subscribers_url":"https://api.github.com/repos/plastikos/salt/subscribers","subscription_url":"https://api.github.com/repos/plastikos/salt/subscription","commits_url":"https://api.github.com/repos/plastikos/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/plastikos/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/plastikos/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/plastikos/salt/issues/comments/{number}","contents_url":"https://api.github.com/repos/plastikos/salt/contents/{+path}","compare_url":"https://api.github.com/repos/plastikos/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plastikos/salt/merges","archive_url":"https://api.github.com/repos/plastikos/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plastikos/salt/downloads","issues_url":"https://api.github.com/repos/plastikos/salt/issues{/number}","pulls_url":"https://api.github.com/repos/plastikos/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/plastikos/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/plastikos/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plastikos/salt/labels{/name}","releases_url":"https://api.github.com/repos/plastikos/salt/releases{/id}","created_at":"2014-05-14T12:15:36Z","updated_at":"2014-10-20T22:21:39Z","pushed_at":"2014-10-24T17:14:13Z","git_url":"git://github.com/plastikos/salt.git","ssh_url":"git@github.com:plastikos/salt.git","clone_url":"https://github.com/plastikos/salt.git","svn_url":"https://github.com/plastikos/salt","homepage":"saltstack.com","size":65652,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"50d51e76e08dae125cdcb5554bb0968daed09308","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=2","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=2","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Infrastructure automation and management system","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments/{number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2014-10-24T16:39:19Z","pushed_at":"2014-10-24T15:34:29Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.com","size":190802,"stargazers_count":4181,"watchers_count":4181,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1683,"mirror_url":null,"open_issues_count":1796,"forks":1683,"open_issues":1796,"watchers":4181,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/16878"},"html":{"href":"https://github.com/saltstack/salt/pull/16878"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/16878"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/16878/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/16878/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/16878/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/65e477dd67b43a60b8ff3318b01db61d2ea19ffd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":220,"deletions":28,"changed_files":5}}