GitHub PullRequestEvent at 2014-01-29 14:28:24
Repository: yiistrap
Actor: Crisu83
Payload: {"action":"closed","number":171,"pull_request":{"url":"https://api.github.com/repos/Crisu83/yiistrap/pulls/171","id":11079752,"html_url":"https://github.com/Crisu83/yiistrap/pull/171","diff_url":"https://github.com/Crisu83/yiistrap/pull/171.diff","patch_url":"https://github.com/Crisu83/yiistrap/pull/171.patch","issue_url":"https://api.github.com/repos/Crisu83/yiistrap/issues/171","number":171,"state":"closed","title":"BS3 compatibility: Tweaks to form control width, input addons, pills, tabs, pagination, labels, and badges","user":{"login":"kazuo","id":428797,"avatar_url":"https://gravatar.com/avatar/ed3563ae7dcfabffb4ad4b7b59dcfc14?d=https%3A%2F%2Fidenticons.github.com%2Ff0afee9e0bc1ae94ce827405a9d05ff0.png&r=x","gravatar_id":"ed3563ae7dcfabffb4ad4b7b59dcfc14","url":"https://api.github.com/users/kazuo","html_url":"https://github.com/kazuo","followers_url":"https://api.github.com/users/kazuo/followers","following_url":"https://api.github.com/users/kazuo/following{/other_user}","gists_url":"https://api.github.com/users/kazuo/gists{/gist_id}","starred_url":"https://api.github.com/users/kazuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazuo/subscriptions","organizations_url":"https://api.github.com/users/kazuo/orgs","repos_url":"https://api.github.com/users/kazuo/repos","events_url":"https://api.github.com/users/kazuo/events{/privacy}","received_events_url":"https://api.github.com/users/kazuo/received_events","type":"User","site_admin":false},"body":"Issue #153\r\n\r\nFor individual form elements such as text fields, text areas, select inputs, the corresponding method will wrap a div tag if a width size is applied. \r\n\r\nFor element widths that uses the \"span\" option will be converted to its \"col-md-*\" equivalent. For example, passing in `array('span' => 8)` would be the same as `array('md' => 8)`. In BS3, you can choose the type of width depending on the display such has `xs`, `md`, and `lg`. You can stack the column types in your `$htmlOptions` and it will apply those classes. For example: `array('xs' => 6, 'md' => 6)` will apply both `col-xs-6` and `col-md-6` classes to the element.\r\n\r\nBy the way, badge colors in BS3 are gone. I thought about re-adding them with an additional LESS/CSS, but decided to stay close to stock BS3 as much possible. \r\n\r\nI modified `TbHtml::inputAddOn()` to properly parse the string from `TbHtml::buttonDropdown()` to fix the look of the appending/prepending of those types of buttons to input elements.\r\n\r\nI marked a number of constants as \"deprecated\" for BS3. I didn't want to completely remove them in case you want to keep it there for backward compatibility (I changed the constant values to the BS3 equivalent if they have one). \r\n\r\nThis is still far from complete, but we'll get there :)","created_at":"2013-12-24T21:13:21Z","updated_at":"2014-01-29T14:28:23Z","closed_at":"2014-01-29T14:28:23Z","merged_at":null,"merge_commit_sha":"7e5116d73c3d067ed6d111d521b5647ea88988aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Crisu83/yiistrap/pulls/171/commits","review_comments_url":"https://api.github.com/repos/Crisu83/yiistrap/pulls/171/comments","review_comment_url":"/repos/Crisu83/yiistrap/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Crisu83/yiistrap/issues/171/comments","statuses_url":"https://api.github.com/repos/Crisu83/yiistrap/statuses/1c6a1f416151ee0b14bc2194f19732711100fd47","head":{"label":"kazuo:bs3","ref":"bs3","sha":"1c6a1f416151ee0b14bc2194f19732711100fd47","user":{"login":"kazuo","id":428797,"avatar_url":"https://gravatar.com/avatar/ed3563ae7dcfabffb4ad4b7b59dcfc14?d=https%3A%2F%2Fidenticons.github.com%2Ff0afee9e0bc1ae94ce827405a9d05ff0.png&r=x","gravatar_id":"ed3563ae7dcfabffb4ad4b7b59dcfc14","url":"https://api.github.com/users/kazuo","html_url":"https://github.com/kazuo","followers_url":"https://api.github.com/users/kazuo/followers","following_url":"https://api.github.com/users/kazuo/following{/other_user}","gists_url":"https://api.github.com/users/kazuo/gists{/gist_id}","starred_url":"https://api.github.com/users/kazuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazuo/subscriptions","organizations_url":"https://api.github.com/users/kazuo/orgs","repos_url":"https://api.github.com/users/kazuo/repos","events_url":"https://api.github.com/users/kazuo/events{/privacy}","received_events_url":"https://api.github.com/users/kazuo/received_events","type":"User","site_admin":false},"repo":{"id":14628727,"name":"yiistrap","full_name":"kazuo/yiistrap","owner":{"login":"kazuo","id":428797,"avatar_url":"https://gravatar.com/avatar/ed3563ae7dcfabffb4ad4b7b59dcfc14?d=https%3A%2F%2Fidenticons.github.com%2Ff0afee9e0bc1ae94ce827405a9d05ff0.png&r=x","gravatar_id":"ed3563ae7dcfabffb4ad4b7b59dcfc14","url":"https://api.github.com/users/kazuo","html_url":"https://github.com/kazuo","followers_url":"https://api.github.com/users/kazuo/followers","following_url":"https://api.github.com/users/kazuo/following{/other_user}","gists_url":"https://api.github.com/users/kazuo/gists{/gist_id}","starred_url":"https://api.github.com/users/kazuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazuo/subscriptions","organizations_url":"https://api.github.com/users/kazuo/orgs","repos_url":"https://api.github.com/users/kazuo/repos","events_url":"https://api.github.com/users/kazuo/events{/privacy}","received_events_url":"https://api.github.com/users/kazuo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kazuo/yiistrap","description":"Twitter Bootstrap for the Yii PHP framework.","fork":true,"url":"https://api.github.com/repos/kazuo/yiistrap","forks_url":"https://api.github.com/repos/kazuo/yiistrap/forks","keys_url":"https://api.github.com/repos/kazuo/yiistrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kazuo/yiistrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kazuo/yiistrap/teams","hooks_url":"https://api.github.com/repos/kazuo/yiistrap/hooks","issue_events_url":"https://api.github.com/repos/kazuo/yiistrap/issues/events{/number}","events_url":"https://api.github.com/repos/kazuo/yiistrap/events","assignees_url":"https://api.github.com/repos/kazuo/yiistrap/assignees{/user}","branches_url":"https://api.github.com/repos/kazuo/yiistrap/branches{/branch}","tags_url":"https://api.github.com/repos/kazuo/yiistrap/tags","blobs_url":"https://api.github.com/repos/kazuo/yiistrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kazuo/yiistrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kazuo/yiistrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/kazuo/yiistrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kazuo/yiistrap/statuses/{sha}","languages_url":"https://api.github.com/repos/kazuo/yiistrap/languages","stargazers_url":"https://api.github.com/repos/kazuo/yiistrap/stargazers","contributors_url":"https://api.github.com/repos/kazuo/yiistrap/contributors","subscribers_url":"https://api.github.com/repos/kazuo/yiistrap/subscribers","subscription_url":"https://api.github.com/repos/kazuo/yiistrap/subscription","commits_url":"https://api.github.com/repos/kazuo/yiistrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/kazuo/yiistrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/kazuo/yiistrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/kazuo/yiistrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/kazuo/yiistrap/contents/{+path}","compare_url":"https://api.github.com/repos/kazuo/yiistrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kazuo/yiistrap/merges","archive_url":"https://api.github.com/repos/kazuo/yiistrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kazuo/yiistrap/downloads","issues_url":"https://api.github.com/repos/kazuo/yiistrap/issues{/number}","pulls_url":"https://api.github.com/repos/kazuo/yiistrap/pulls{/number}","milestones_url":"https://api.github.com/repos/kazuo/yiistrap/milestones{/number}","notifications_url":"https://api.github.com/repos/kazuo/yiistrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kazuo/yiistrap/labels{/name}","releases_url":"https://api.github.com/repos/kazuo/yiistrap/releases{/id}","created_at":"2013-11-22T20:28:53Z","updated_at":"2014-01-29T14:28:23Z","pushed_at":"2014-01-13T03:58:13Z","git_url":"git://github.com/kazuo/yiistrap.git","ssh_url":"git@github.com:kazuo/yiistrap.git","clone_url":"https://github.com/kazuo/yiistrap.git","svn_url":"https://github.com/kazuo/yiistrap","homepage":"http://www.getyiistrap.com","size":4548,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":1,"default_branch":"bs3","master_branch":"bs3"}},"base":{"label":"Crisu83:bs3","ref":"bs3","sha":"c99f0b4a71b2824b8c60b8585ca5d5e2c3d45cfa","user":{"login":"Crisu83","id":1044868,"avatar_url":"https://gravatar.com/avatar/4484acb7484aaf2ee2db4fac2bab274d?d=https%3A%2F%2Fidenticons.github.com%2Fed0053c99ceb3c74bc4c55ff95f43275.png&r=x","gravatar_id":"4484acb7484aaf2ee2db4fac2bab274d","url":"https://api.github.com/users/Crisu83","html_url":"https://github.com/Crisu83","followers_url":"https://api.github.com/users/Crisu83/followers","following_url":"https://api.github.com/users/Crisu83/following{/other_user}","gists_url":"https://api.github.com/users/Crisu83/gists{/gist_id}","starred_url":"https://api.github.com/users/Crisu83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crisu83/subscriptions","organizations_url":"https://api.github.com/users/Crisu83/orgs","repos_url":"https://api.github.com/users/Crisu83/repos","events_url":"https://api.github.com/users/Crisu83/events{/privacy}","received_events_url":"https://api.github.com/users/Crisu83/received_events","type":"User","site_admin":false},"repo":{"id":7869357,"name":"yiistrap","full_name":"Crisu83/yiistrap","owner":{"login":"Crisu83","id":1044868,"avatar_url":"https://gravatar.com/avatar/4484acb7484aaf2ee2db4fac2bab274d?d=https%3A%2F%2Fidenticons.github.com%2Fed0053c99ceb3c74bc4c55ff95f43275.png&r=x","gravatar_id":"4484acb7484aaf2ee2db4fac2bab274d","url":"https://api.github.com/users/Crisu83","html_url":"https://github.com/Crisu83","followers_url":"https://api.github.com/users/Crisu83/followers","following_url":"https://api.github.com/users/Crisu83/following{/other_user}","gists_url":"https://api.github.com/users/Crisu83/gists{/gist_id}","starred_url":"https://api.github.com/users/Crisu83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crisu83/subscriptions","organizations_url":"https://api.github.com/users/Crisu83/orgs","repos_url":"https://api.github.com/users/Crisu83/repos","events_url":"https://api.github.com/users/Crisu83/events{/privacy}","received_events_url":"https://api.github.com/users/Crisu83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Crisu83/yiistrap","description":"Twitter Bootstrap for the Yii PHP framework.","fork":false,"url":"https://api.github.com/repos/Crisu83/yiistrap","forks_url":"https://api.github.com/repos/Crisu83/yiistrap/forks","keys_url":"https://api.github.com/repos/Crisu83/yiistrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crisu83/yiistrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crisu83/yiistrap/teams","hooks_url":"https://api.github.com/repos/Crisu83/yiistrap/hooks","issue_events_url":"https://api.github.com/repos/Crisu83/yiistrap/issues/events{/number}","events_url":"https://api.github.com/repos/Crisu83/yiistrap/events","assignees_url":"https://api.github.com/repos/Crisu83/yiistrap/assignees{/user}","branches_url":"https://api.github.com/repos/Crisu83/yiistrap/branches{/branch}","tags_url":"https://api.github.com/repos/Crisu83/yiistrap/tags","blobs_url":"https://api.github.com/repos/Crisu83/yiistrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crisu83/yiistrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crisu83/yiistrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crisu83/yiistrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crisu83/yiistrap/statuses/{sha}","languages_url":"https://api.github.com/repos/Crisu83/yiistrap/languages","stargazers_url":"https://api.github.com/repos/Crisu83/yiistrap/stargazers","contributors_url":"https://api.github.com/repos/Crisu83/yiistrap/contributors","subscribers_url":"https://api.github.com/repos/Crisu83/yiistrap/subscribers","subscription_url":"https://api.github.com/repos/Crisu83/yiistrap/subscription","commits_url":"https://api.github.com/repos/Crisu83/yiistrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crisu83/yiistrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crisu83/yiistrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crisu83/yiistrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/Crisu83/yiistrap/contents/{+path}","compare_url":"https://api.github.com/repos/Crisu83/yiistrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crisu83/yiistrap/merges","archive_url":"https://api.github.com/repos/Crisu83/yiistrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crisu83/yiistrap/downloads","issues_url":"https://api.github.com/repos/Crisu83/yiistrap/issues{/number}","pulls_url":"https://api.github.com/repos/Crisu83/yiistrap/pulls{/number}","milestones_url":"https://api.github.com/repos/Crisu83/yiistrap/milestones{/number}","notifications_url":"https://api.github.com/repos/Crisu83/yiistrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crisu83/yiistrap/labels{/name}","releases_url":"https://api.github.com/repos/Crisu83/yiistrap/releases{/id}","created_at":"2013-01-28T12:33:06Z","updated_at":"2014-01-17T07:23:33Z","pushed_at":"2013-12-16T13:19:10Z","git_url":"git://github.com/Crisu83/yiistrap.git","ssh_url":"git@github.com:Crisu83/yiistrap.git","clone_url":"https://github.com/Crisu83/yiistrap.git","svn_url":"https://github.com/Crisu83/yiistrap","homepage":"http://www.getyiistrap.com","size":5562,"stargazers_count":203,"watchers_count":203,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":138,"mirror_url":null,"open_issues_count":21,"forks":138,"open_issues":21,"watchers":203,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Crisu83/yiistrap/pulls/171"},"html":{"href":"https://github.com/Crisu83/yiistrap/pull/171"},"issue":{"href":"https://api.github.com/repos/Crisu83/yiistrap/issues/171"},"comments":{"href":"https://api.github.com/repos/Crisu83/yiistrap/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/Crisu83/yiistrap/pulls/171/comments"},"commits":{"href":"https://api.github.com/repos/Crisu83/yiistrap/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/Crisu83/yiistrap/statuses/1c6a1f416151ee0b14bc2194f19732711100fd47"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":12,"additions":396,"deletions":71,"changed_files":3}}