GitHub PullRequestReviewCommentEvent at 2014-07-06 15:43:44
Repository: csympy
Actor: certik
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/sympy/csympy/pulls/comments/14575789","id":14575789,"diff_hunk":"@@ -0,0 +1,212 @@\n+/**\n+ *  \\file complex.h\n+ *  Class for Complex built on top of Number class\n+ *\n+ **/\n+#ifndef CSYMPY_COMPLEX_H\n+#define CSYMPY_COMPLEX_H\n+\n+#include <gmpxx.h>\n+\n+#include \"basic.h\"\n+#include \"number.h\"\n+#include \"integer.h\"\n+#include \"rational.h\"\n+\n+namespace CSymPy {\n+//! Complex Class\n+class Complex : public Number {\n+public:\n+\t//! `real_` : Real part of the complex Number\n+    //! `imaginary_` : Imaginary part of the complex Number\n+    // Complex Number is of the form `real + i(imaginary)`\n+    mpq_class real_;\n+    mpq_class imaginary_;\n+\n+public:\n+\t//! Constructor of Complex class\n+    Complex(mpq_class real, mpq_class imaginary);","path":"src/complex.h","position":28,"original_position":28,"commit_id":"7b380671545804ef429daf2115d2d9423ba79638","original_commit_id":"7b380671545804ef429daf2115d2d9423ba79638","user":{"login":"certik","id":20568,"avatar_url":"https://avatars.githubusercontent.com/u/20568?","gravatar_id":"29d62e4d73bf4a16a7755f6862a6031f","url":"https://api.github.com/users/certik","html_url":"https://github.com/certik","followers_url":"https://api.github.com/users/certik/followers","following_url":"https://api.github.com/users/certik/following{/other_user}","gists_url":"https://api.github.com/users/certik/gists{/gist_id}","starred_url":"https://api.github.com/users/certik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certik/subscriptions","organizations_url":"https://api.github.com/users/certik/orgs","repos_url":"https://api.github.com/users/certik/repos","events_url":"https://api.github.com/users/certik/events{/privacy}","received_events_url":"https://api.github.com/users/certik/received_events","type":"User","site_admin":false},"body":"Same here.","created_at":"2014-07-06T15:43:44Z","updated_at":"2014-07-06T15:43:44Z","html_url":"https://github.com/sympy/csympy/pull/223#discussion_r14575789","pull_request_url":"https://api.github.com/repos/sympy/csympy/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/sympy/csympy/pulls/comments/14575789"},"html":{"href":"https://github.com/sympy/csympy/pull/223#discussion_r14575789"},"pull_request":{"href":"https://api.github.com/repos/sympy/csympy/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/csympy/pulls/223","id":17744207,"html_url":"https://github.com/sympy/csympy/pull/223","diff_url":"https://github.com/sympy/csympy/pull/223.diff","patch_url":"https://github.com/sympy/csympy/pull/223.patch","issue_url":"https://api.github.com/repos/sympy/csympy/issues/223","number":223,"state":"open","title":"Complex Module (Resolves #47)","user":{"login":"sushant-hiray","id":2182581,"avatar_url":"https://avatars.githubusercontent.com/u/2182581?","gravatar_id":"03db473da44b1eb6d892a71846a59b45","url":"https://api.github.com/users/sushant-hiray","html_url":"https://github.com/sushant-hiray","followers_url":"https://api.github.com/users/sushant-hiray/followers","following_url":"https://api.github.com/users/sushant-hiray/following{/other_user}","gists_url":"https://api.github.com/users/sushant-hiray/gists{/gist_id}","starred_url":"https://api.github.com/users/sushant-hiray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushant-hiray/subscriptions","organizations_url":"https://api.github.com/users/sushant-hiray/orgs","repos_url":"https://api.github.com/users/sushant-hiray/repos","events_url":"https://api.github.com/users/sushant-hiray/events{/privacy}","received_events_url":"https://api.github.com/users/sushant-hiray/received_events","type":"User","site_admin":false},"body":"I've implemented some basic functions:\r\nStuff yet to be implemented:\r\n- [x]  add\r\n- [x]  sub\r\n- [x] mul\r\n- [x] div\r\n- [ ] pow\r\n- [x] is_zero\r\n- [x] is_one\r\n\r\n`compare`/`is_positive`/`is_negative` cannot be implemented as complex numbers cannot be totally ordered\r\n","created_at":"2014-06-29T04:42:04Z","updated_at":"2014-07-06T15:43:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b4bd8b02a4409309e6eae70c1d29abbab37d747","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/csympy/pulls/223/commits","review_comments_url":"https://api.github.com/repos/sympy/csympy/pulls/223/comments","review_comment_url":"https://api.github.com/repos/sympy/csympy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sympy/csympy/issues/223/comments","statuses_url":"https://api.github.com/repos/sympy/csympy/statuses/7b380671545804ef429daf2115d2d9423ba79638","head":{"label":"sushant-hiray:complex","ref":"complex","sha":"7b380671545804ef429daf2115d2d9423ba79638","user":{"login":"sushant-hiray","id":2182581,"avatar_url":"https://avatars.githubusercontent.com/u/2182581?","gravatar_id":"03db473da44b1eb6d892a71846a59b45","url":"https://api.github.com/users/sushant-hiray","html_url":"https://github.com/sushant-hiray","followers_url":"https://api.github.com/users/sushant-hiray/followers","following_url":"https://api.github.com/users/sushant-hiray/following{/other_user}","gists_url":"https://api.github.com/users/sushant-hiray/gists{/gist_id}","starred_url":"https://api.github.com/users/sushant-hiray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushant-hiray/subscriptions","organizations_url":"https://api.github.com/users/sushant-hiray/orgs","repos_url":"https://api.github.com/users/sushant-hiray/repos","events_url":"https://api.github.com/users/sushant-hiray/events{/privacy}","received_events_url":"https://api.github.com/users/sushant-hiray/received_events","type":"User","site_admin":false},"repo":{"id":17418292,"name":"csympy","full_name":"sushant-hiray/csympy","owner":{"login":"sushant-hiray","id":2182581,"avatar_url":"https://avatars.githubusercontent.com/u/2182581?","gravatar_id":"03db473da44b1eb6d892a71846a59b45","url":"https://api.github.com/users/sushant-hiray","html_url":"https://github.com/sushant-hiray","followers_url":"https://api.github.com/users/sushant-hiray/followers","following_url":"https://api.github.com/users/sushant-hiray/following{/other_user}","gists_url":"https://api.github.com/users/sushant-hiray/gists{/gist_id}","starred_url":"https://api.github.com/users/sushant-hiray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushant-hiray/subscriptions","organizations_url":"https://api.github.com/users/sushant-hiray/orgs","repos_url":"https://api.github.com/users/sushant-hiray/repos","events_url":"https://api.github.com/users/sushant-hiray/events{/privacy}","received_events_url":"https://api.github.com/users/sushant-hiray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sushant-hiray/csympy","description":"Fast symbolic manipulation library, written in C++","fork":true,"url":"https://api.github.com/repos/sushant-hiray/csympy","forks_url":"https://api.github.com/repos/sushant-hiray/csympy/forks","keys_url":"https://api.github.com/repos/sushant-hiray/csympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sushant-hiray/csympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sushant-hiray/csympy/teams","hooks_url":"https://api.github.com/repos/sushant-hiray/csympy/hooks","issue_events_url":"https://api.github.com/repos/sushant-hiray/csympy/issues/events{/number}","events_url":"https://api.github.com/repos/sushant-hiray/csympy/events","assignees_url":"https://api.github.com/repos/sushant-hiray/csympy/assignees{/user}","branches_url":"https://api.github.com/repos/sushant-hiray/csympy/branches{/branch}","tags_url":"https://api.github.com/repos/sushant-hiray/csympy/tags","blobs_url":"https://api.github.com/repos/sushant-hiray/csympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sushant-hiray/csympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sushant-hiray/csympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sushant-hiray/csympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sushant-hiray/csympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sushant-hiray/csympy/languages","stargazers_url":"https://api.github.com/repos/sushant-hiray/csympy/stargazers","contributors_url":"https://api.github.com/repos/sushant-hiray/csympy/contributors","subscribers_url":"https://api.github.com/repos/sushant-hiray/csympy/subscribers","subscription_url":"https://api.github.com/repos/sushant-hiray/csympy/subscription","commits_url":"https://api.github.com/repos/sushant-hiray/csympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sushant-hiray/csympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sushant-hiray/csympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sushant-hiray/csympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/sushant-hiray/csympy/contents/{+path}","compare_url":"https://api.github.com/repos/sushant-hiray/csympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sushant-hiray/csympy/merges","archive_url":"https://api.github.com/repos/sushant-hiray/csympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sushant-hiray/csympy/downloads","issues_url":"https://api.github.com/repos/sushant-hiray/csympy/issues{/number}","pulls_url":"https://api.github.com/repos/sushant-hiray/csympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sushant-hiray/csympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sushant-hiray/csympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sushant-hiray/csympy/labels{/name}","releases_url":"https://api.github.com/repos/sushant-hiray/csympy/releases{/id}","created_at":"2014-03-04T21:47:08Z","updated_at":"2014-06-25T06:07:36Z","pushed_at":"2014-07-06T04:24:12Z","git_url":"git://github.com/sushant-hiray/csympy.git","ssh_url":"git@github.com:sushant-hiray/csympy.git","clone_url":"https://github.com/sushant-hiray/csympy.git","svn_url":"https://github.com/sushant-hiray/csympy","homepage":"http://sympy.org","size":2479,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"958cd60e0b2af7c340f35e66bb36a41fe797c6b9","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?","gravatar_id":"cbddfebe00a15f38108875eaafa827de","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":42376,"name":"csympy","full_name":"sympy/csympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?","gravatar_id":"cbddfebe00a15f38108875eaafa827de","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/csympy","description":"Fast symbolic manipulation library, written in C++","fork":false,"url":"https://api.github.com/repos/sympy/csympy","forks_url":"https://api.github.com/repos/sympy/csympy/forks","keys_url":"https://api.github.com/repos/sympy/csympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/csympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/csympy/teams","hooks_url":"https://api.github.com/repos/sympy/csympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/csympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/csympy/events","assignees_url":"https://api.github.com/repos/sympy/csympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/csympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/csympy/tags","blobs_url":"https://api.github.com/repos/sympy/csympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/csympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/csympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/csympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/csympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/csympy/languages","stargazers_url":"https://api.github.com/repos/sympy/csympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/csympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/csympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/csympy/subscription","commits_url":"https://api.github.com/repos/sympy/csympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/csympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/csympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/csympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/sympy/csympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/csympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/csympy/merges","archive_url":"https://api.github.com/repos/sympy/csympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/csympy/downloads","issues_url":"https://api.github.com/repos/sympy/csympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/csympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/csympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/csympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/csympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/csympy/releases{/id}","created_at":"2008-08-13T18:40:14Z","updated_at":"2014-06-29T23:14:14Z","pushed_at":"2014-07-05T14:11:04Z","git_url":"git://github.com/sympy/csympy.git","ssh_url":"git@github.com:sympy/csympy.git","clone_url":"https://github.com/sympy/csympy.git","svn_url":"https://github.com/sympy/csympy","homepage":"http://sympy.org","size":5006,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":26,"mirror_url":null,"open_issues_count":51,"forks":26,"open_issues":51,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/csympy/pulls/223"},"html":{"href":"https://github.com/sympy/csympy/pull/223"},"issue":{"href":"https://api.github.com/repos/sympy/csympy/issues/223"},"comments":{"href":"https://api.github.com/repos/sympy/csympy/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/csympy/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/csympy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sympy/csympy/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/csympy/statuses/7b380671545804ef429daf2115d2d9423ba79638"}}}}