GitHub PullRequestEvent at 2014-08-19 20:45:53
Repository: kue
Actor: estien
Payload: {"action":"opened","number":393,"pull_request":{"url":"https://api.github.com/repos/LearnBoost/kue/pulls/393","id":20007954,"html_url":"https://github.com/LearnBoost/kue/pull/393","diff_url":"https://github.com/LearnBoost/kue/pull/393.diff","patch_url":"https://github.com/LearnBoost/kue/pull/393.patch","issue_url":"https://api.github.com/repos/LearnBoost/kue/issues/393","number":393,"state":"open","locked":false,"title":"Fix allowing kue app to be hosted as child of another parent express app","user":{"login":"estien","id":464085,"avatar_url":"https://avatars.githubusercontent.com/u/464085?v=2","gravatar_id":"92d5c0cd0dbb1f5e4837540e96be7cf8","url":"https://api.github.com/users/estien","html_url":"https://github.com/estien","followers_url":"https://api.github.com/users/estien/followers","following_url":"https://api.github.com/users/estien/following{/other_user}","gists_url":"https://api.github.com/users/estien/gists{/gist_id}","starred_url":"https://api.github.com/users/estien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estien/subscriptions","organizations_url":"https://api.github.com/users/estien/orgs","repos_url":"https://api.github.com/users/estien/repos","events_url":"https://api.github.com/users/estien/events{/privacy}","received_events_url":"https://api.github.com/users/estien/received_events","type":"User","site_admin":false},"body":"With this added slash in the base path redirect, the kue app performs correct redirects if it is hosted as part of a parent express app, on its own dedicated path, like so:\r\n\r\n```js\r\nvar app = require('express')();\r\napp.use('/kueapp', require('kue').app);\r\napp.listen(1337); // the kue app is now available on http://localhost:1337/kueapp\r\n```\r\n\r\nThis fixes the current failing behavior, as a redirect without the slash sends the user to http://localhost:1337/kueappactive, which returns 404.","created_at":"2014-08-19T20:45:52Z","updated_at":"2014-08-19T20:45:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LearnBoost/kue/pulls/393/commits","review_comments_url":"https://api.github.com/repos/LearnBoost/kue/pulls/393/comments","review_comment_url":"https://api.github.com/repos/LearnBoost/kue/pulls/comments/{number}","comments_url":"https://api.github.com/repos/LearnBoost/kue/issues/393/comments","statuses_url":"https://api.github.com/repos/LearnBoost/kue/statuses/2085a32140116a2cd01b5b845c5b665ad20af278","head":{"label":"estien:master","ref":"master","sha":"2085a32140116a2cd01b5b845c5b665ad20af278","user":{"login":"estien","id":464085,"avatar_url":"https://avatars.githubusercontent.com/u/464085?v=2","gravatar_id":"92d5c0cd0dbb1f5e4837540e96be7cf8","url":"https://api.github.com/users/estien","html_url":"https://github.com/estien","followers_url":"https://api.github.com/users/estien/followers","following_url":"https://api.github.com/users/estien/following{/other_user}","gists_url":"https://api.github.com/users/estien/gists{/gist_id}","starred_url":"https://api.github.com/users/estien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estien/subscriptions","organizations_url":"https://api.github.com/users/estien/orgs","repos_url":"https://api.github.com/users/estien/repos","events_url":"https://api.github.com/users/estien/events{/privacy}","received_events_url":"https://api.github.com/users/estien/received_events","type":"User","site_admin":false},"repo":{"id":23124933,"name":"kue","full_name":"estien/kue","owner":{"login":"estien","id":464085,"avatar_url":"https://avatars.githubusercontent.com/u/464085?v=2","gravatar_id":"92d5c0cd0dbb1f5e4837540e96be7cf8","url":"https://api.github.com/users/estien","html_url":"https://github.com/estien","followers_url":"https://api.github.com/users/estien/followers","following_url":"https://api.github.com/users/estien/following{/other_user}","gists_url":"https://api.github.com/users/estien/gists{/gist_id}","starred_url":"https://api.github.com/users/estien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estien/subscriptions","organizations_url":"https://api.github.com/users/estien/orgs","repos_url":"https://api.github.com/users/estien/repos","events_url":"https://api.github.com/users/estien/events{/privacy}","received_events_url":"https://api.github.com/users/estien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/estien/kue","description":"Kue is a priority job queue backed by redis, built for node.js.","fork":true,"url":"https://api.github.com/repos/estien/kue","forks_url":"https://api.github.com/repos/estien/kue/forks","keys_url":"https://api.github.com/repos/estien/kue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/estien/kue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/estien/kue/teams","hooks_url":"https://api.github.com/repos/estien/kue/hooks","issue_events_url":"https://api.github.com/repos/estien/kue/issues/events{/number}","events_url":"https://api.github.com/repos/estien/kue/events","assignees_url":"https://api.github.com/repos/estien/kue/assignees{/user}","branches_url":"https://api.github.com/repos/estien/kue/branches{/branch}","tags_url":"https://api.github.com/repos/estien/kue/tags","blobs_url":"https://api.github.com/repos/estien/kue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/estien/kue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/estien/kue/git/refs{/sha}","trees_url":"https://api.github.com/repos/estien/kue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/estien/kue/statuses/{sha}","languages_url":"https://api.github.com/repos/estien/kue/languages","stargazers_url":"https://api.github.com/repos/estien/kue/stargazers","contributors_url":"https://api.github.com/repos/estien/kue/contributors","subscribers_url":"https://api.github.com/repos/estien/kue/subscribers","subscription_url":"https://api.github.com/repos/estien/kue/subscription","commits_url":"https://api.github.com/repos/estien/kue/commits{/sha}","git_commits_url":"https://api.github.com/repos/estien/kue/git/commits{/sha}","comments_url":"https://api.github.com/repos/estien/kue/comments{/number}","issue_comment_url":"https://api.github.com/repos/estien/kue/issues/comments/{number}","contents_url":"https://api.github.com/repos/estien/kue/contents/{+path}","compare_url":"https://api.github.com/repos/estien/kue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/estien/kue/merges","archive_url":"https://api.github.com/repos/estien/kue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/estien/kue/downloads","issues_url":"https://api.github.com/repos/estien/kue/issues{/number}","pulls_url":"https://api.github.com/repos/estien/kue/pulls{/number}","milestones_url":"https://api.github.com/repos/estien/kue/milestones{/number}","notifications_url":"https://api.github.com/repos/estien/kue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/estien/kue/labels{/name}","releases_url":"https://api.github.com/repos/estien/kue/releases{/id}","created_at":"2014-08-19T20:34:07Z","updated_at":"2014-08-19T20:37:28Z","pushed_at":"2014-08-19T20:37:28Z","git_url":"git://github.com/estien/kue.git","ssh_url":"git@github.com:estien/kue.git","clone_url":"https://github.com/estien/kue.git","svn_url":"https://github.com/estien/kue","homepage":"http://learnboost.github.io/kue","size":7936,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LearnBoost:master","ref":"master","sha":"aaf243247a325084332486367748ec5cb897277c","user":{"login":"LearnBoost","id":204174,"avatar_url":"https://avatars.githubusercontent.com/u/204174?v=2","gravatar_id":"07100ee5e8dedd7c96195b2aa422dbb5","url":"https://api.github.com/users/LearnBoost","html_url":"https://github.com/LearnBoost","followers_url":"https://api.github.com/users/LearnBoost/followers","following_url":"https://api.github.com/users/LearnBoost/following{/other_user}","gists_url":"https://api.github.com/users/LearnBoost/gists{/gist_id}","starred_url":"https://api.github.com/users/LearnBoost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LearnBoost/subscriptions","organizations_url":"https://api.github.com/users/LearnBoost/orgs","repos_url":"https://api.github.com/users/LearnBoost/repos","events_url":"https://api.github.com/users/LearnBoost/events{/privacy}","received_events_url":"https://api.github.com/users/LearnBoost/received_events","type":"Organization","site_admin":false},"repo":{"id":1963063,"name":"kue","full_name":"LearnBoost/kue","owner":{"login":"LearnBoost","id":204174,"avatar_url":"https://avatars.githubusercontent.com/u/204174?v=2","gravatar_id":"07100ee5e8dedd7c96195b2aa422dbb5","url":"https://api.github.com/users/LearnBoost","html_url":"https://github.com/LearnBoost","followers_url":"https://api.github.com/users/LearnBoost/followers","following_url":"https://api.github.com/users/LearnBoost/following{/other_user}","gists_url":"https://api.github.com/users/LearnBoost/gists{/gist_id}","starred_url":"https://api.github.com/users/LearnBoost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LearnBoost/subscriptions","organizations_url":"https://api.github.com/users/LearnBoost/orgs","repos_url":"https://api.github.com/users/LearnBoost/repos","events_url":"https://api.github.com/users/LearnBoost/events{/privacy}","received_events_url":"https://api.github.com/users/LearnBoost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LearnBoost/kue","description":"Kue is a priority job queue backed by redis, built for node.js.","fork":false,"url":"https://api.github.com/repos/LearnBoost/kue","forks_url":"https://api.github.com/repos/LearnBoost/kue/forks","keys_url":"https://api.github.com/repos/LearnBoost/kue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LearnBoost/kue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LearnBoost/kue/teams","hooks_url":"https://api.github.com/repos/LearnBoost/kue/hooks","issue_events_url":"https://api.github.com/repos/LearnBoost/kue/issues/events{/number}","events_url":"https://api.github.com/repos/LearnBoost/kue/events","assignees_url":"https://api.github.com/repos/LearnBoost/kue/assignees{/user}","branches_url":"https://api.github.com/repos/LearnBoost/kue/branches{/branch}","tags_url":"https://api.github.com/repos/LearnBoost/kue/tags","blobs_url":"https://api.github.com/repos/LearnBoost/kue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LearnBoost/kue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LearnBoost/kue/git/refs{/sha}","trees_url":"https://api.github.com/repos/LearnBoost/kue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LearnBoost/kue/statuses/{sha}","languages_url":"https://api.github.com/repos/LearnBoost/kue/languages","stargazers_url":"https://api.github.com/repos/LearnBoost/kue/stargazers","contributors_url":"https://api.github.com/repos/LearnBoost/kue/contributors","subscribers_url":"https://api.github.com/repos/LearnBoost/kue/subscribers","subscription_url":"https://api.github.com/repos/LearnBoost/kue/subscription","commits_url":"https://api.github.com/repos/LearnBoost/kue/commits{/sha}","git_commits_url":"https://api.github.com/repos/LearnBoost/kue/git/commits{/sha}","comments_url":"https://api.github.com/repos/LearnBoost/kue/comments{/number}","issue_comment_url":"https://api.github.com/repos/LearnBoost/kue/issues/comments/{number}","contents_url":"https://api.github.com/repos/LearnBoost/kue/contents/{+path}","compare_url":"https://api.github.com/repos/LearnBoost/kue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LearnBoost/kue/merges","archive_url":"https://api.github.com/repos/LearnBoost/kue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LearnBoost/kue/downloads","issues_url":"https://api.github.com/repos/LearnBoost/kue/issues{/number}","pulls_url":"https://api.github.com/repos/LearnBoost/kue/pulls{/number}","milestones_url":"https://api.github.com/repos/LearnBoost/kue/milestones{/number}","notifications_url":"https://api.github.com/repos/LearnBoost/kue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LearnBoost/kue/labels{/name}","releases_url":"https://api.github.com/repos/LearnBoost/kue/releases{/id}","created_at":"2011-06-27T22:37:37Z","updated_at":"2014-08-19T18:58:52Z","pushed_at":"2014-08-10T18:39:50Z","git_url":"git://github.com/LearnBoost/kue.git","ssh_url":"git@github.com:LearnBoost/kue.git","clone_url":"https://github.com/LearnBoost/kue.git","svn_url":"https://github.com/LearnBoost/kue","homepage":"http://learnboost.github.io/kue","size":7936,"stargazers_count":2144,"watchers_count":2144,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":328,"mirror_url":null,"open_issues_count":31,"forks":328,"open_issues":31,"watchers":2144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LearnBoost/kue/pulls/393"},"html":{"href":"https://github.com/LearnBoost/kue/pull/393"},"issue":{"href":"https://api.github.com/repos/LearnBoost/kue/issues/393"},"comments":{"href":"https://api.github.com/repos/LearnBoost/kue/issues/393/comments"},"review_comments":{"href":"https://api.github.com/repos/LearnBoost/kue/pulls/393/comments"},"review_comment":{"href":"https://api.github.com/repos/LearnBoost/kue/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/LearnBoost/kue/pulls/393/commits"},"statuses":{"href":"https://api.github.com/repos/LearnBoost/kue/statuses/2085a32140116a2cd01b5b845c5b665ad20af278"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}