GitHub PullRequestReviewCommentEvent at 2014-11-04 17:50:02
Repository: lc1-challenge-app
Actor: gaitonde
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls/comments/19821096","id":19821096,"diff_hunk":"@@ -18,17 +19,16 @@ module.exports = function(app) {\n \tapp.use(bodyParser.json());\n \tparams.extend(app);\n \n-\t//TODO(DG: 10/31/2014): Refactor to node-config\n-\tvar auth0Domain = process.env.TC_AUTH0_DOMAIN || 'serenity-tc.auth0.com';\n-\tvar auth0Client = process.env.TC_AUTH0_CLIENT || 'foo';\n-\tvar auth0Secret = process.env.TC_AUTH0_SECRET || 'bar';\n-\t\n+\tvar auth0Domain =  config.auth0Domain;\n+\tvar auth0Client = config.auth0Client;","path":"server/appirio_node_modules/tc-server-auth/index.js","position":18,"original_position":18,"commit_id":"fea233f5f67713d2a794dc86d1acd4ba14441f33","original_commit_id":"fea233f5f67713d2a794dc86d1acd4ba14441f33","user":{"login":"gaitonde","id":599066,"avatar_url":"https://avatars.githubusercontent.com/u/599066?v=2","gravatar_id":"","url":"https://api.github.com/users/gaitonde","html_url":"https://github.com/gaitonde","followers_url":"https://api.github.com/users/gaitonde/followers","following_url":"https://api.github.com/users/gaitonde/following{/other_user}","gists_url":"https://api.github.com/users/gaitonde/gists{/gist_id}","starred_url":"https://api.github.com/users/gaitonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaitonde/subscriptions","organizations_url":"https://api.github.com/users/gaitonde/orgs","repos_url":"https://api.github.com/users/gaitonde/repos","events_url":"https://api.github.com/users/gaitonde/events{/privacy}","received_events_url":"https://api.github.com/users/gaitonde/received_events","type":"User","site_admin":false},"body":"Should use config.has() and config.get() but don't fail silently. Fail fast, fail hard.","created_at":"2014-11-04T17:50:02Z","updated_at":"2014-11-04T17:50:02Z","html_url":"https://github.com/appirio-tech/lc1-challenge-app/pull/6#discussion_r19821096","pull_request_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls/comments/19821096"},"html":{"href":"https://github.com/appirio-tech/lc1-challenge-app/pull/6#discussion_r19821096"},"pull_request":{"href":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls/6","id":23804499,"html_url":"https://github.com/appirio-tech/lc1-challenge-app/pull/6","diff_url":"https://github.com/appirio-tech/lc1-challenge-app/pull/6.diff","patch_url":"https://github.com/appirio-tech/lc1-challenge-app/pull/6.patch","issue_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/issues/6","number":6,"state":"open","locked":false,"title":"added node-config and refactored tc-server-auth to use it.","user":{"login":"kbowerma","id":1180747,"avatar_url":"https://avatars.githubusercontent.com/u/1180747?v=2","gravatar_id":"","url":"https://api.github.com/users/kbowerma","html_url":"https://github.com/kbowerma","followers_url":"https://api.github.com/users/kbowerma/followers","following_url":"https://api.github.com/users/kbowerma/following{/other_user}","gists_url":"https://api.github.com/users/kbowerma/gists{/gist_id}","starred_url":"https://api.github.com/users/kbowerma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbowerma/subscriptions","organizations_url":"https://api.github.com/users/kbowerma/orgs","repos_url":"https://api.github.com/users/kbowerma/repos","events_url":"https://api.github.com/users/kbowerma/events{/privacy}","received_events_url":"https://api.github.com/users/kbowerma/received_events","type":"User","site_admin":false},"body":"@indytechcook, @gaitonde \r\n\r\nI wanted to get config in before I ran the s3 challenge,   Lets spend 5 minutes on this tomorrow.","created_at":"2014-11-04T01:04:23Z","updated_at":"2014-11-04T17:50:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fd01db1a80f50a22b069096abca841d2d23769d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls/6/commits","review_comments_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls/6/comments","review_comment_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls/comments/{number}","comments_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/issues/6/comments","statuses_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/statuses/fea233f5f67713d2a794dc86d1acd4ba14441f33","head":{"label":"appirio-tech:node-config","ref":"node-config","sha":"fea233f5f67713d2a794dc86d1acd4ba14441f33","user":{"login":"appirio-tech","id":8822926,"avatar_url":"https://avatars.githubusercontent.com/u/8822926?v=2","gravatar_id":"","url":"https://api.github.com/users/appirio-tech","html_url":"https://github.com/appirio-tech","followers_url":"https://api.github.com/users/appirio-tech/followers","following_url":"https://api.github.com/users/appirio-tech/following{/other_user}","gists_url":"https://api.github.com/users/appirio-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/appirio-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appirio-tech/subscriptions","organizations_url":"https://api.github.com/users/appirio-tech/orgs","repos_url":"https://api.github.com/users/appirio-tech/repos","events_url":"https://api.github.com/users/appirio-tech/events{/privacy}","received_events_url":"https://api.github.com/users/appirio-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":25348147,"name":"lc1-challenge-app","full_name":"appirio-tech/lc1-challenge-app","owner":{"login":"appirio-tech","id":8822926,"avatar_url":"https://avatars.githubusercontent.com/u/8822926?v=2","gravatar_id":"","url":"https://api.github.com/users/appirio-tech","html_url":"https://github.com/appirio-tech","followers_url":"https://api.github.com/users/appirio-tech/followers","following_url":"https://api.github.com/users/appirio-tech/following{/other_user}","gists_url":"https://api.github.com/users/appirio-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/appirio-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appirio-tech/subscriptions","organizations_url":"https://api.github.com/users/appirio-tech/orgs","repos_url":"https://api.github.com/users/appirio-tech/repos","events_url":"https://api.github.com/users/appirio-tech/events{/privacy}","received_events_url":"https://api.github.com/users/appirio-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appirio-tech/lc1-challenge-app","description":"Louder Crowd Challenge App","fork":false,"url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app","forks_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/forks","keys_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/teams","hooks_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/hooks","issue_events_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/issues/events{/number}","events_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/events","assignees_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/assignees{/user}","branches_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/branches{/branch}","tags_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/tags","blobs_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/statuses/{sha}","languages_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/languages","stargazers_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/stargazers","contributors_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/contributors","subscribers_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/subscribers","subscription_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/subscription","commits_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/issues/comments/{number}","contents_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/contents/{+path}","compare_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/merges","archive_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/downloads","issues_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/issues{/number}","pulls_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls{/number}","milestones_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/milestones{/number}","notifications_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/labels{/name}","releases_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/releases{/id}","created_at":"2014-10-17T08:44:03Z","updated_at":"2014-10-30T19:59:33Z","pushed_at":"2014-11-04T16:18:56Z","git_url":"git://github.com/appirio-tech/lc1-challenge-app.git","ssh_url":"git@github.com:appirio-tech/lc1-challenge-app.git","clone_url":"https://github.com/appirio-tech/lc1-challenge-app.git","svn_url":"https://github.com/appirio-tech/lc1-challenge-app","homepage":null,"size":4510,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"appirio-tech:master","ref":"master","sha":"f0d724d80c3925f9720f27b7a3efd5409de8bcca","user":{"login":"appirio-tech","id":8822926,"avatar_url":"https://avatars.githubusercontent.com/u/8822926?v=2","gravatar_id":"","url":"https://api.github.com/users/appirio-tech","html_url":"https://github.com/appirio-tech","followers_url":"https://api.github.com/users/appirio-tech/followers","following_url":"https://api.github.com/users/appirio-tech/following{/other_user}","gists_url":"https://api.github.com/users/appirio-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/appirio-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appirio-tech/subscriptions","organizations_url":"https://api.github.com/users/appirio-tech/orgs","repos_url":"https://api.github.com/users/appirio-tech/repos","events_url":"https://api.github.com/users/appirio-tech/events{/privacy}","received_events_url":"https://api.github.com/users/appirio-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":25348147,"name":"lc1-challenge-app","full_name":"appirio-tech/lc1-challenge-app","owner":{"login":"appirio-tech","id":8822926,"avatar_url":"https://avatars.githubusercontent.com/u/8822926?v=2","gravatar_id":"","url":"https://api.github.com/users/appirio-tech","html_url":"https://github.com/appirio-tech","followers_url":"https://api.github.com/users/appirio-tech/followers","following_url":"https://api.github.com/users/appirio-tech/following{/other_user}","gists_url":"https://api.github.com/users/appirio-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/appirio-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appirio-tech/subscriptions","organizations_url":"https://api.github.com/users/appirio-tech/orgs","repos_url":"https://api.github.com/users/appirio-tech/repos","events_url":"https://api.github.com/users/appirio-tech/events{/privacy}","received_events_url":"https://api.github.com/users/appirio-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appirio-tech/lc1-challenge-app","description":"Louder Crowd Challenge App","fork":false,"url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app","forks_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/forks","keys_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/teams","hooks_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/hooks","issue_events_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/issues/events{/number}","events_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/events","assignees_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/assignees{/user}","branches_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/branches{/branch}","tags_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/tags","blobs_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/statuses/{sha}","languages_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/languages","stargazers_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/stargazers","contributors_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/contributors","subscribers_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/subscribers","subscription_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/subscription","commits_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/issues/comments/{number}","contents_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/contents/{+path}","compare_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/merges","archive_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/downloads","issues_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/issues{/number}","pulls_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls{/number}","milestones_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/milestones{/number}","notifications_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/labels{/name}","releases_url":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/releases{/id}","created_at":"2014-10-17T08:44:03Z","updated_at":"2014-10-30T19:59:33Z","pushed_at":"2014-11-04T16:18:56Z","git_url":"git://github.com/appirio-tech/lc1-challenge-app.git","ssh_url":"git@github.com:appirio-tech/lc1-challenge-app.git","clone_url":"https://github.com/appirio-tech/lc1-challenge-app.git","svn_url":"https://github.com/appirio-tech/lc1-challenge-app","homepage":null,"size":4510,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls/6"},"html":{"href":"https://github.com/appirio-tech/lc1-challenge-app/pull/6"},"issue":{"href":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/issues/6"},"comments":{"href":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/appirio-tech/lc1-challenge-app/statuses/fea233f5f67713d2a794dc86d1acd4ba14441f33"}}}}