GitHub PullRequestReviewCommentEvent at 2014-08-21 10:12:14
Repository: SeoBundle
Actor: ElectricMaxxx
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments/16530596","id":16530596,"diff_hunk":"@@ -131,4 +137,42 @@ public function getXsdValidationBasePath()\n     {\n         return __DIR__.'/../Resources/config/schema';\n     }\n+\n+    /**\n+     * @param $config\n+     * @param XmlFileLoader $loader\n+     * @param ContainerBuilder $container\n+     */\n+    private function loadPhpcr($config, XmlFileLoader $loader, ContainerBuilder $container)\n+    {\n+        if (class_exists('Symfony\\Cmf\\Bundle\\RoutingBundle\\CmfRoutingBundle')) {\n+            $loader->load('phpcr.xml');","path":"DependencyInjection/CmfSeoExtension.php","position":33,"original_position":33,"commit_id":"93a8742d57ca516174d688ced24533dfc79b5e9e","original_commit_id":"93a8742d57ca516174d688ced24533dfc79b5e9e","user":{"login":"ElectricMaxxx","id":2905834,"avatar_url":"https://avatars.githubusercontent.com/u/2905834?v=2","gravatar_id":"7ba68aaf6959aff27499a9475c31e803","url":"https://api.github.com/users/ElectricMaxxx","html_url":"https://github.com/ElectricMaxxx","followers_url":"https://api.github.com/users/ElectricMaxxx/followers","following_url":"https://api.github.com/users/ElectricMaxxx/following{/other_user}","gists_url":"https://api.github.com/users/ElectricMaxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/ElectricMaxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElectricMaxxx/subscriptions","organizations_url":"https://api.github.com/users/ElectricMaxxx/orgs","repos_url":"https://api.github.com/users/ElectricMaxxx/repos","events_url":"https://api.github.com/users/ElectricMaxxx/events{/privacy}","received_events_url":"https://api.github.com/users/ElectricMaxxx/received_events","type":"User","site_admin":false},"body":"why a property and not a constant?","created_at":"2014-08-21T10:12:14Z","updated_at":"2014-08-21T10:12:14Z","html_url":"https://github.com/symfony-cmf/SeoBundle/pull/175#discussion_r16530596","pull_request_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments/16530596"},"html":{"href":"https://github.com/symfony-cmf/SeoBundle/pull/175#discussion_r16530596"},"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/175","id":18301359,"html_url":"https://github.com/symfony-cmf/SeoBundle/pull/175","diff_url":"https://github.com/symfony-cmf/SeoBundle/pull/175.diff","patch_url":"https://github.com/symfony-cmf/SeoBundle/pull/175.patch","issue_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/175","number":175,"state":"open","locked":false,"title":"implementing alternate languages for content documents","user":{"login":"ElectricMaxxx","id":2905834,"avatar_url":"https://avatars.githubusercontent.com/u/2905834?v=2","gravatar_id":"7ba68aaf6959aff27499a9475c31e803","url":"https://api.github.com/users/ElectricMaxxx","html_url":"https://github.com/ElectricMaxxx","followers_url":"https://api.github.com/users/ElectricMaxxx/followers","following_url":"https://api.github.com/users/ElectricMaxxx/following{/other_user}","gists_url":"https://api.github.com/users/ElectricMaxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/ElectricMaxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElectricMaxxx/subscriptions","organizations_url":"https://api.github.com/users/ElectricMaxxx/orgs","repos_url":"https://api.github.com/users/ElectricMaxxx/repos","events_url":"https://api.github.com/users/ElectricMaxxx/events{/privacy}","received_events_url":"https://api.github.com/users/ElectricMaxxx/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | [no]\r\n| New feature?  | [yes]\r\n| BC breaks?    | [no]\r\n| Deprecations? | [no]\r\n| Tests pass?   | [no]\r\n| Fixed tickets | [#166]\r\n| License       | MIT\r\n| Doc PR        | not yet\r\n\r\nI started to implement that feature. Thought we should take care for the existence of the `ManagerRegistry` and when it exists the `SeoPresentation::setAlternateLocales()` method will figure out urls (by `UrlGenerator`) and pass that information to sonatas `PageService`. By doing it that way the user just needs to add the right TwigHelper `{{ sonata_seo_lang_alternates() }}` to see the result. Same procedure as all other metadata comes into the template.\r\n\r\nTodo:\r\n* [x] implement logic in `ContentListener`\r\n* [x] add registry by compiler pass\r\n* [x] add method in `SeoPresentation` to compute and set the alternate lang values to `PageService`\r\n* [ ] tests for unit and frontend\r\n* [ ] take care on current route\r\n* [ ] fix strange url problem","created_at":"2014-07-11T20:55:47Z","updated_at":"2014-08-21T10:12:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbe86bf334bc65143a16f05b78e204b4b6f22051","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/175/commits","review_comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/175/comments","review_comment_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/175/comments","statuses_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/93a8742d57ca516174d688ced24533dfc79b5e9e","head":{"label":"symfony-cmf:lang-alternate","ref":"lang-alternate","sha":"93a8742d57ca516174d688ced24533dfc79b5e9e","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=2","gravatar_id":"b763f9b4c5b60eb4a8b1b5d530cdd59a","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":16372913,"name":"SeoBundle","full_name":"symfony-cmf/SeoBundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=2","gravatar_id":"b763f9b4c5b60eb4a8b1b5d530cdd59a","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/SeoBundle","description":"A SEO Solution for duplicate contents, page titles, etc.","fork":false,"url":"https://api.github.com/repos/symfony-cmf/SeoBundle","forks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/releases{/id}","created_at":"2014-01-30T09:17:14Z","updated_at":"2014-08-10T20:06:04Z","pushed_at":"2014-08-21T09:49:52Z","git_url":"git://github.com/symfony-cmf/SeoBundle.git","ssh_url":"git@github.com:symfony-cmf/SeoBundle.git","clone_url":"https://github.com/symfony-cmf/SeoBundle.git","svn_url":"https://github.com/symfony-cmf/SeoBundle","homepage":"","size":6195,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":7,"mirror_url":null,"open_issues_count":16,"forks":7,"open_issues":16,"watchers":5,"default_branch":"master"}},"base":{"label":"symfony-cmf:master","ref":"master","sha":"6626e636fb34dd17347f8a004e0d349278eb2b91","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=2","gravatar_id":"b763f9b4c5b60eb4a8b1b5d530cdd59a","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":16372913,"name":"SeoBundle","full_name":"symfony-cmf/SeoBundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=2","gravatar_id":"b763f9b4c5b60eb4a8b1b5d530cdd59a","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/SeoBundle","description":"A SEO Solution for duplicate contents, page titles, etc.","fork":false,"url":"https://api.github.com/repos/symfony-cmf/SeoBundle","forks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/releases{/id}","created_at":"2014-01-30T09:17:14Z","updated_at":"2014-08-10T20:06:04Z","pushed_at":"2014-08-21T09:49:52Z","git_url":"git://github.com/symfony-cmf/SeoBundle.git","ssh_url":"git@github.com:symfony-cmf/SeoBundle.git","clone_url":"https://github.com/symfony-cmf/SeoBundle.git","svn_url":"https://github.com/symfony-cmf/SeoBundle","homepage":"","size":6195,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":7,"mirror_url":null,"open_issues_count":16,"forks":7,"open_issues":16,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/175"},"html":{"href":"https://github.com/symfony-cmf/SeoBundle/pull/175"},"issue":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/175"},"comments":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/93a8742d57ca516174d688ced24533dfc79b5e9e"}}}}