GitHub PullRequestReviewCommentEvent at 2014-08-11 07:49:26
Repository: phpcr-odm
Actor: dbu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/phpcr-odm/pulls/comments/16040853","id":16040853,"diff_hunk":"@@ -2242,8 +2227,8 @@ private function executeInserts($documents)\n                     //populate $associationChangesets to force executeUpdates($associationUpdates)\n                     //to only update association fields\n                     $data = isset($associationChangesets[$oid]['fields']) ? $associationChangesets[$oid]['fields'] : array();\n-                    $data[$fieldName] = $fieldValue;\n-                    $associationChangesets[$oid] = array('fields' => $data, 'reorderings' => array());\n+                    $data[$fieldName] = array($fieldValue, null);","path":"lib/Doctrine/ODM/PHPCR/UnitOfWork.php","position":176,"original_position":177,"commit_id":"9aaf15e23a609b6c6b571178409753fd572732d1","original_commit_id":"d491475a240f3b0c840a98467a3f43e5cdfe3ae9","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars.githubusercontent.com/u/76576?v=2","gravatar_id":"c9f4f8ce2c2936bacaf49500b5a127dc","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"that would be the old value of an association? could it be the previous reference/referrers collection, or previous parent?","created_at":"2014-08-11T07:49:26Z","updated_at":"2014-08-11T07:49:26Z","html_url":"https://github.com/doctrine/phpcr-odm/pull/539#discussion_r16040853","pull_request_url":"https://api.github.com/repos/doctrine/phpcr-odm/pulls/539","_links":{"self":{"href":"https://api.github.com/repos/doctrine/phpcr-odm/pulls/comments/16040853"},"html":{"href":"https://github.com/doctrine/phpcr-odm/pull/539#discussion_r16040853"},"pull_request":{"href":"https://api.github.com/repos/doctrine/phpcr-odm/pulls/539"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/phpcr-odm/pulls/539","id":19473685,"html_url":"https://github.com/doctrine/phpcr-odm/pull/539","diff_url":"https://github.com/doctrine/phpcr-odm/pull/539.diff","patch_url":"https://github.com/doctrine/phpcr-odm/pull/539.patch","issue_url":"https://api.github.com/repos/doctrine/phpcr-odm/issues/539","number":539,"state":"open","title":"fixed issues in PreUpdateEventArgs due to different changeset structure","user":{"login":"lsmith77","id":300279,"avatar_url":"https://avatars.githubusercontent.com/u/300279?v=2","gravatar_id":"54787afbd0e7c30936101c2fa84bd89b","url":"https://api.github.com/users/lsmith77","html_url":"https://github.com/lsmith77","followers_url":"https://api.github.com/users/lsmith77/followers","following_url":"https://api.github.com/users/lsmith77/following{/other_user}","gists_url":"https://api.github.com/users/lsmith77/gists{/gist_id}","starred_url":"https://api.github.com/users/lsmith77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsmith77/subscriptions","organizations_url":"https://api.github.com/users/lsmith77/orgs","repos_url":"https://api.github.com/users/lsmith77/repos","events_url":"https://api.github.com/users/lsmith77/events{/privacy}","received_events_url":"https://api.github.com/users/lsmith77/received_events","type":"User","site_admin":false},"body":"fix https://github.com/doctrine/phpcr-odm-documentation/issues/60\r\n\r\nthis is a rather large refactoring, undoing the copy of the 'originalData' in the changeset structure that added in the development of 1.2.0 to handle recomputing changesets. this data structure is no longer necessary since we changed the changeset structure to match that of the ORM in order to properly support ``PreUpdateEventArgs`` which already contains the data from the changed fields.\r\n\r\nthere is still an open question about the behavior of the ORM:\r\nhttp://www.doctrine-project.org/jira/browse/DDC-3120","created_at":"2014-08-07T15:20:36Z","updated_at":"2014-08-11T07:49:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a33635ef5f069903dfe14d3e1b913e7f3ab06ece","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/phpcr-odm/pulls/539/commits","review_comments_url":"https://api.github.com/repos/doctrine/phpcr-odm/pulls/539/comments","review_comment_url":"https://api.github.com/repos/doctrine/phpcr-odm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/doctrine/phpcr-odm/issues/539/comments","statuses_url":"https://api.github.com/repos/doctrine/phpcr-odm/statuses/9aaf15e23a609b6c6b571178409753fd572732d1","head":{"label":"doctrine:PreUpdateEventArgs","ref":"PreUpdateEventArgs","sha":"9aaf15e23a609b6c6b571178409753fd572732d1","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=2","gravatar_id":"ba1cea66dea9be22341d7d104d0f22b1","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":1352419,"name":"phpcr-odm","full_name":"doctrine/phpcr-odm","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=2","gravatar_id":"ba1cea66dea9be22341d7d104d0f22b1","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/phpcr-odm","description":"Doctrine2 PHPCR ODM","fork":false,"url":"https://api.github.com/repos/doctrine/phpcr-odm","forks_url":"https://api.github.com/repos/doctrine/phpcr-odm/forks","keys_url":"https://api.github.com/repos/doctrine/phpcr-odm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/phpcr-odm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/phpcr-odm/teams","hooks_url":"https://api.github.com/repos/doctrine/phpcr-odm/hooks","issue_events_url":"https://api.github.com/repos/doctrine/phpcr-odm/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/phpcr-odm/events","assignees_url":"https://api.github.com/repos/doctrine/phpcr-odm/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/phpcr-odm/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/phpcr-odm/tags","blobs_url":"https://api.github.com/repos/doctrine/phpcr-odm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/phpcr-odm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/phpcr-odm/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/phpcr-odm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/phpcr-odm/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/phpcr-odm/languages","stargazers_url":"https://api.github.com/repos/doctrine/phpcr-odm/stargazers","contributors_url":"https://api.github.com/repos/doctrine/phpcr-odm/contributors","subscribers_url":"https://api.github.com/repos/doctrine/phpcr-odm/subscribers","subscription_url":"https://api.github.com/repos/doctrine/phpcr-odm/subscription","commits_url":"https://api.github.com/repos/doctrine/phpcr-odm/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/phpcr-odm/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/phpcr-odm/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/phpcr-odm/issues/comments/{number}","contents_url":"https://api.github.com/repos/doctrine/phpcr-odm/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/phpcr-odm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/phpcr-odm/merges","archive_url":"https://api.github.com/repos/doctrine/phpcr-odm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/phpcr-odm/downloads","issues_url":"https://api.github.com/repos/doctrine/phpcr-odm/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/phpcr-odm/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/phpcr-odm/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/phpcr-odm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/phpcr-odm/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/phpcr-odm/releases{/id}","created_at":"2011-02-10T21:22:18Z","updated_at":"2014-08-11T02:52:36Z","pushed_at":"2014-08-10T17:48:08Z","git_url":"git://github.com/doctrine/phpcr-odm.git","ssh_url":"git@github.com:doctrine/phpcr-odm.git","clone_url":"https://github.com/doctrine/phpcr-odm.git","svn_url":"https://github.com/doctrine/phpcr-odm","homepage":"http://www.doctrine-project.org/projects/phpcr-odm.html","size":12020,"stargazers_count":122,"watchers_count":122,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":72,"mirror_url":null,"open_issues_count":39,"forks":72,"open_issues":39,"watchers":122,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"02600ad81477aa726ef22b1f3a84a171f24b93d7","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=2","gravatar_id":"ba1cea66dea9be22341d7d104d0f22b1","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":1352419,"name":"phpcr-odm","full_name":"doctrine/phpcr-odm","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=2","gravatar_id":"ba1cea66dea9be22341d7d104d0f22b1","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/phpcr-odm","description":"Doctrine2 PHPCR ODM","fork":false,"url":"https://api.github.com/repos/doctrine/phpcr-odm","forks_url":"https://api.github.com/repos/doctrine/phpcr-odm/forks","keys_url":"https://api.github.com/repos/doctrine/phpcr-odm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/phpcr-odm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/phpcr-odm/teams","hooks_url":"https://api.github.com/repos/doctrine/phpcr-odm/hooks","issue_events_url":"https://api.github.com/repos/doctrine/phpcr-odm/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/phpcr-odm/events","assignees_url":"https://api.github.com/repos/doctrine/phpcr-odm/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/phpcr-odm/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/phpcr-odm/tags","blobs_url":"https://api.github.com/repos/doctrine/phpcr-odm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/phpcr-odm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/phpcr-odm/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/phpcr-odm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/phpcr-odm/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/phpcr-odm/languages","stargazers_url":"https://api.github.com/repos/doctrine/phpcr-odm/stargazers","contributors_url":"https://api.github.com/repos/doctrine/phpcr-odm/contributors","subscribers_url":"https://api.github.com/repos/doctrine/phpcr-odm/subscribers","subscription_url":"https://api.github.com/repos/doctrine/phpcr-odm/subscription","commits_url":"https://api.github.com/repos/doctrine/phpcr-odm/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/phpcr-odm/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/phpcr-odm/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/phpcr-odm/issues/comments/{number}","contents_url":"https://api.github.com/repos/doctrine/phpcr-odm/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/phpcr-odm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/phpcr-odm/merges","archive_url":"https://api.github.com/repos/doctrine/phpcr-odm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/phpcr-odm/downloads","issues_url":"https://api.github.com/repos/doctrine/phpcr-odm/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/phpcr-odm/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/phpcr-odm/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/phpcr-odm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/phpcr-odm/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/phpcr-odm/releases{/id}","created_at":"2011-02-10T21:22:18Z","updated_at":"2014-08-11T02:52:36Z","pushed_at":"2014-08-10T17:48:08Z","git_url":"git://github.com/doctrine/phpcr-odm.git","ssh_url":"git@github.com:doctrine/phpcr-odm.git","clone_url":"https://github.com/doctrine/phpcr-odm.git","svn_url":"https://github.com/doctrine/phpcr-odm","homepage":"http://www.doctrine-project.org/projects/phpcr-odm.html","size":12020,"stargazers_count":122,"watchers_count":122,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":72,"mirror_url":null,"open_issues_count":39,"forks":72,"open_issues":39,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/phpcr-odm/pulls/539"},"html":{"href":"https://github.com/doctrine/phpcr-odm/pull/539"},"issue":{"href":"https://api.github.com/repos/doctrine/phpcr-odm/issues/539"},"comments":{"href":"https://api.github.com/repos/doctrine/phpcr-odm/issues/539/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/phpcr-odm/pulls/539/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/phpcr-odm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/doctrine/phpcr-odm/pulls/539/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/phpcr-odm/statuses/9aaf15e23a609b6c6b571178409753fd572732d1"}}}}