GitHub PullRequestReviewCommentEvent at 2014-07-28 17:51:24
Repository: puppet
Actor: hlindberg
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/15478166","id":15478166,"diff_hunk":"@@ -59,6 +59,79 @@\n     end\n   end\n \n+\n+  action (:dump) do\n+    summary \"Outputs a dump of the internal parse tree for debugging\"\n+    arguments \"-e <source>| [<manifest> ...] \"\n+    returns \"A dump of the resulting AST model unless there are syntax or validation errors.\"\n+    description <<-'EOT'\n+      This action parses and validates the Puppet DSL syntax without compiling a catalog\n+      or syncing any resources. It automatically turns on the future parser for the parsing.\n+\n+      The command accepts one or more manifests (.pp) files, or an -e followed by the puppet\n+      source text.\n+      If no arguments are given, the stdin is read (unless it is attached to a terminal)\n+\n+      The output format of the dumped tree is not API, it may change from time to time.\n+    EOT\n+\n+    option \"--e <source>\" do\n+      default_to { nil }\n+      summary \"dump one source expression given on the command line.\"\n+    end\n+\n+    option(\"--[no-]validate\") do\n+      summary \"Whether or not to validate the parsed result, if no-validate only syntax errors are reported\"\n+    end\n+\n+    when_invoked do |*args|\n+      require 'puppet/pops'\n+      options = args.pop\n+      if options[:e]\n+        dump_parse(options[:e], 'command-line-string', options, false)\n+      elsif (files = args).empty?","path":"lib/puppet/face/parser.rb","position":34,"original_position":34,"commit_id":"9b0ced40201f1f4c52dd49f0e41eff25465178af","original_commit_id":"9b0ced40201f1f4c52dd49f0e41eff25465178af","user":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?","gravatar_id":"52e653caac881b973a60a6c23d416089","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"body":"fixing.","created_at":"2014-07-28T17:51:24Z","updated_at":"2014-07-28T17:51:24Z","html_url":"https://github.com/puppetlabs/puppet/pull/2914#discussion_r15478166","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2914","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/15478166"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2914#discussion_r15478166"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2914"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2914","id":18941052,"html_url":"https://github.com/puppetlabs/puppet/pull/2914","diff_url":"https://github.com/puppetlabs/puppet/pull/2914.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/2914.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2914","number":2914,"state":"open","title":"(PUP-2898) Add 4x Resource Expressions","user":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?","gravatar_id":"52e653caac881b973a60a6c23d416089","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"body":"This adds the 4x style resource expressions. They are now R-values (can be assigned).\r\n\r\nThis also improves the support for debugging a parser; a dump option has been added to the puppet parser command - it outputs the resulting model and can run with --validate or --no-validate to see the non validated tree. It accepts a string on the command line with -e, or from stdin, or from one or more .pp files. (A very useful debugging tool).\r\n\r\nFurther improvements made to generation of a debugging parser, and to the format of what it displays when used.\r\n\r\nThe ModelTreeDumper has a format change for the block expression - it now breaks and indents as it was not useful in practice (hard to read and compare). As a consequence many tests needed to change (all to the better (easier to read and compare results).\r\n\r\nAdditional maintenance is also included (dead code removal, removal of stale comments with TODOs etc).\r\n","created_at":"2014-07-27T14:10:48Z","updated_at":"2014-07-28T17:51:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff9b9664227e9ae83e214079f6165e2bd4c28b4e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2914/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2914/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2914/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/9b0ced40201f1f4c52dd49f0e41eff25465178af","head":{"label":"hlindberg:PUP-2898_resource-expressions","ref":"PUP-2898_resource-expressions","sha":"9b0ced40201f1f4c52dd49f0e41eff25465178af","user":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?","gravatar_id":"52e653caac881b973a60a6c23d416089","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"repo":{"id":5693635,"name":"puppet","full_name":"hlindberg/puppet","owner":{"login":"hlindberg","id":563066,"avatar_url":"https://avatars.githubusercontent.com/u/563066?","gravatar_id":"52e653caac881b973a60a6c23d416089","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hlindberg/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/hlindberg/puppet","forks_url":"https://api.github.com/repos/hlindberg/puppet/forks","keys_url":"https://api.github.com/repos/hlindberg/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hlindberg/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hlindberg/puppet/teams","hooks_url":"https://api.github.com/repos/hlindberg/puppet/hooks","issue_events_url":"https://api.github.com/repos/hlindberg/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/hlindberg/puppet/events","assignees_url":"https://api.github.com/repos/hlindberg/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/hlindberg/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/hlindberg/puppet/tags","blobs_url":"https://api.github.com/repos/hlindberg/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hlindberg/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hlindberg/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/hlindberg/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hlindberg/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/hlindberg/puppet/languages","stargazers_url":"https://api.github.com/repos/hlindberg/puppet/stargazers","contributors_url":"https://api.github.com/repos/hlindberg/puppet/contributors","subscribers_url":"https://api.github.com/repos/hlindberg/puppet/subscribers","subscription_url":"https://api.github.com/repos/hlindberg/puppet/subscription","commits_url":"https://api.github.com/repos/hlindberg/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/hlindberg/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/hlindberg/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/hlindberg/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/hlindberg/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/hlindberg/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hlindberg/puppet/merges","archive_url":"https://api.github.com/repos/hlindberg/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hlindberg/puppet/downloads","issues_url":"https://api.github.com/repos/hlindberg/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/hlindberg/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/hlindberg/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/hlindberg/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hlindberg/puppet/labels{/name}","releases_url":"https://api.github.com/repos/hlindberg/puppet/releases{/id}","created_at":"2012-09-05T21:08:12Z","updated_at":"2014-06-25T01:27:30Z","pushed_at":"2014-07-28T17:34:41Z","git_url":"git://github.com/hlindberg/puppet.git","ssh_url":"git@github.com:hlindberg/puppet.git","clone_url":"https://github.com/hlindberg/puppet.git","svn_url":"https://github.com/hlindberg/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":44888,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"fd7cf5fdf0aa5f7faaae94045463726a971a0a82","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2014-07-28T17:13:28Z","pushed_at":"2014-07-25T22:16:57Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":105154,"stargazers_count":2487,"watchers_count":2487,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1079,"mirror_url":null,"open_issues_count":34,"forks":1079,"open_issues":34,"watchers":2487,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2914"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2914"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2914"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2914/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2914/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2914/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/9b0ced40201f1f4c52dd49f0e41eff25465178af"}}}}