GitHub PullRequestEvent at 2014-06-13 13:49:47
Repository: BetterTTV
Actor: lewisje
Payload: {"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/night/BetterTTV/pulls/19","id":17104142,"html_url":"https://github.com/night/BetterTTV/pull/19","diff_url":"https://github.com/night/BetterTTV/pull/19.diff","patch_url":"https://github.com/night/BetterTTV/pull/19.patch","issue_url":"https://api.github.com/repos/night/BetterTTV/issues/19","number":19,"state":"closed","title":"BetterColorChange","user":{"login":"lewisje","id":4865237,"avatar_url":"https://avatars.githubusercontent.com/u/4865237?","gravatar_id":"0ff39b8463217e0df66d3911377d0e0a","url":"https://api.github.com/users/lewisje","html_url":"https://github.com/lewisje","followers_url":"https://api.github.com/users/lewisje/followers","following_url":"https://api.github.com/users/lewisje/following{/other_user}","gists_url":"https://api.github.com/users/lewisje/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisje/subscriptions","organizations_url":"https://api.github.com/users/lewisje/orgs","repos_url":"https://api.github.com/users/lewisje/repos","events_url":"https://api.github.com/users/lewisje/events{/privacy}","received_events_url":"https://api.github.com/users/lewisje/received_events","type":"User","site_admin":false},"body":"Sorry, I misunderstood the meaning of \"background === 'light'\" as whether DarkenTTV was off; now I know it means that the color would *look best* on a light background.\r\n\r\nI changed the lightening algorithm again, to something closer to what was originally intended; for colors to be lightened, instead of lightening by 20%, I inverted luminosity, darkened by 80%, then inverted again, so even Black, Blue, Red, and Magenta would become light enough without special-case logic.\r\n\r\nBelow are the results when I ran gulp:\r\n> [07:07:24] Using gulpfile C:\\Users\\lewisje\\Documents\\GitHub\\BetterTTV\\gulpfile.js\r\n> [07:07:24] Starting 'templates'...\r\n> [07:07:24] Finished 'templates' after 473 ms\r\n> [07:07:24] Starting 'scripts'...\r\n> [07:07:24] Finished 'scripts' after 11 ms\r\n> [07:07:24] Starting 'default'...\r\n> [07:07:24] Finished 'default' after 20 µs","created_at":"2014-06-13T11:14:45Z","updated_at":"2014-06-13T13:49:47Z","closed_at":"2014-06-13T13:49:47Z","merged_at":null,"merge_commit_sha":"c4d0030da2543a10862fddad8645ca18cab1671d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/night/BetterTTV/pulls/19/commits","review_comments_url":"https://api.github.com/repos/night/BetterTTV/pulls/19/comments","review_comment_url":"https://api.github.com/repos/night/BetterTTV/pulls/comments/{number}","comments_url":"https://api.github.com/repos/night/BetterTTV/issues/19/comments","statuses_url":"https://api.github.com/repos/night/BetterTTV/statuses/54d031fd7a2eb360e4cc48f641e0f6dbbc552f69","head":{"label":"lewisje:master","ref":"master","sha":"54d031fd7a2eb360e4cc48f641e0f6dbbc552f69","user":{"login":"lewisje","id":4865237,"avatar_url":"https://avatars.githubusercontent.com/u/4865237?","gravatar_id":"0ff39b8463217e0df66d3911377d0e0a","url":"https://api.github.com/users/lewisje","html_url":"https://github.com/lewisje","followers_url":"https://api.github.com/users/lewisje/followers","following_url":"https://api.github.com/users/lewisje/following{/other_user}","gists_url":"https://api.github.com/users/lewisje/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisje/subscriptions","organizations_url":"https://api.github.com/users/lewisje/orgs","repos_url":"https://api.github.com/users/lewisje/repos","events_url":"https://api.github.com/users/lewisje/events{/privacy}","received_events_url":"https://api.github.com/users/lewisje/received_events","type":"User","site_admin":false},"repo":{"id":20795842,"name":"BetterTTV","full_name":"lewisje/BetterTTV","owner":{"login":"lewisje","id":4865237,"avatar_url":"https://avatars.githubusercontent.com/u/4865237?","gravatar_id":"0ff39b8463217e0df66d3911377d0e0a","url":"https://api.github.com/users/lewisje","html_url":"https://github.com/lewisje","followers_url":"https://api.github.com/users/lewisje/followers","following_url":"https://api.github.com/users/lewisje/following{/other_user}","gists_url":"https://api.github.com/users/lewisje/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisje/subscriptions","organizations_url":"https://api.github.com/users/lewisje/orgs","repos_url":"https://api.github.com/users/lewisje/repos","events_url":"https://api.github.com/users/lewisje/events{/privacy}","received_events_url":"https://api.github.com/users/lewisje/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lewisje/BetterTTV","description":"BetterTTV enhances Twitch with new features, bug fixes, and reduced clutter.","fork":true,"url":"https://api.github.com/repos/lewisje/BetterTTV","forks_url":"https://api.github.com/repos/lewisje/BetterTTV/forks","keys_url":"https://api.github.com/repos/lewisje/BetterTTV/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lewisje/BetterTTV/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lewisje/BetterTTV/teams","hooks_url":"https://api.github.com/repos/lewisje/BetterTTV/hooks","issue_events_url":"https://api.github.com/repos/lewisje/BetterTTV/issues/events{/number}","events_url":"https://api.github.com/repos/lewisje/BetterTTV/events","assignees_url":"https://api.github.com/repos/lewisje/BetterTTV/assignees{/user}","branches_url":"https://api.github.com/repos/lewisje/BetterTTV/branches{/branch}","tags_url":"https://api.github.com/repos/lewisje/BetterTTV/tags","blobs_url":"https://api.github.com/repos/lewisje/BetterTTV/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lewisje/BetterTTV/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lewisje/BetterTTV/git/refs{/sha}","trees_url":"https://api.github.com/repos/lewisje/BetterTTV/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lewisje/BetterTTV/statuses/{sha}","languages_url":"https://api.github.com/repos/lewisje/BetterTTV/languages","stargazers_url":"https://api.github.com/repos/lewisje/BetterTTV/stargazers","contributors_url":"https://api.github.com/repos/lewisje/BetterTTV/contributors","subscribers_url":"https://api.github.com/repos/lewisje/BetterTTV/subscribers","subscription_url":"https://api.github.com/repos/lewisje/BetterTTV/subscription","commits_url":"https://api.github.com/repos/lewisje/BetterTTV/commits{/sha}","git_commits_url":"https://api.github.com/repos/lewisje/BetterTTV/git/commits{/sha}","comments_url":"https://api.github.com/repos/lewisje/BetterTTV/comments{/number}","issue_comment_url":"https://api.github.com/repos/lewisje/BetterTTV/issues/comments/{number}","contents_url":"https://api.github.com/repos/lewisje/BetterTTV/contents/{+path}","compare_url":"https://api.github.com/repos/lewisje/BetterTTV/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lewisje/BetterTTV/merges","archive_url":"https://api.github.com/repos/lewisje/BetterTTV/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lewisje/BetterTTV/downloads","issues_url":"https://api.github.com/repos/lewisje/BetterTTV/issues{/number}","pulls_url":"https://api.github.com/repos/lewisje/BetterTTV/pulls{/number}","milestones_url":"https://api.github.com/repos/lewisje/BetterTTV/milestones{/number}","notifications_url":"https://api.github.com/repos/lewisje/BetterTTV/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lewisje/BetterTTV/labels{/name}","releases_url":"https://api.github.com/repos/lewisje/BetterTTV/releases{/id}","created_at":"2014-06-13T07:27:42Z","updated_at":"2014-06-13T13:49:47Z","pushed_at":"2014-06-13T10:30:30Z","git_url":"git://github.com/lewisje/BetterTTV.git","ssh_url":"git@github.com:lewisje/BetterTTV.git","clone_url":"https://github.com/lewisje/BetterTTV.git","svn_url":"https://github.com/lewisje/BetterTTV","homepage":"http://betterttv.com","size":2136,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"night:master","ref":"master","sha":"1137b28725e199508ea30ff7578d146379039324","user":{"login":"night","id":2942184,"avatar_url":"https://avatars.githubusercontent.com/u/2942184?","gravatar_id":"b8d7d0a04ab24adae244bd2e91553e92","url":"https://api.github.com/users/night","html_url":"https://github.com/night","followers_url":"https://api.github.com/users/night/followers","following_url":"https://api.github.com/users/night/following{/other_user}","gists_url":"https://api.github.com/users/night/gists{/gist_id}","starred_url":"https://api.github.com/users/night/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/night/subscriptions","organizations_url":"https://api.github.com/users/night/orgs","repos_url":"https://api.github.com/users/night/repos","events_url":"https://api.github.com/users/night/events{/privacy}","received_events_url":"https://api.github.com/users/night/received_events","type":"User","site_admin":false},"repo":{"id":19358114,"name":"BetterTTV","full_name":"night/BetterTTV","owner":{"login":"night","id":2942184,"avatar_url":"https://avatars.githubusercontent.com/u/2942184?","gravatar_id":"b8d7d0a04ab24adae244bd2e91553e92","url":"https://api.github.com/users/night","html_url":"https://github.com/night","followers_url":"https://api.github.com/users/night/followers","following_url":"https://api.github.com/users/night/following{/other_user}","gists_url":"https://api.github.com/users/night/gists{/gist_id}","starred_url":"https://api.github.com/users/night/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/night/subscriptions","organizations_url":"https://api.github.com/users/night/orgs","repos_url":"https://api.github.com/users/night/repos","events_url":"https://api.github.com/users/night/events{/privacy}","received_events_url":"https://api.github.com/users/night/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/night/BetterTTV","description":"BetterTTV enhances Twitch with new features, bug fixes, and reduced clutter.","fork":false,"url":"https://api.github.com/repos/night/BetterTTV","forks_url":"https://api.github.com/repos/night/BetterTTV/forks","keys_url":"https://api.github.com/repos/night/BetterTTV/keys{/key_id}","collaborators_url":"https://api.github.com/repos/night/BetterTTV/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/night/BetterTTV/teams","hooks_url":"https://api.github.com/repos/night/BetterTTV/hooks","issue_events_url":"https://api.github.com/repos/night/BetterTTV/issues/events{/number}","events_url":"https://api.github.com/repos/night/BetterTTV/events","assignees_url":"https://api.github.com/repos/night/BetterTTV/assignees{/user}","branches_url":"https://api.github.com/repos/night/BetterTTV/branches{/branch}","tags_url":"https://api.github.com/repos/night/BetterTTV/tags","blobs_url":"https://api.github.com/repos/night/BetterTTV/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/night/BetterTTV/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/night/BetterTTV/git/refs{/sha}","trees_url":"https://api.github.com/repos/night/BetterTTV/git/trees{/sha}","statuses_url":"https://api.github.com/repos/night/BetterTTV/statuses/{sha}","languages_url":"https://api.github.com/repos/night/BetterTTV/languages","stargazers_url":"https://api.github.com/repos/night/BetterTTV/stargazers","contributors_url":"https://api.github.com/repos/night/BetterTTV/contributors","subscribers_url":"https://api.github.com/repos/night/BetterTTV/subscribers","subscription_url":"https://api.github.com/repos/night/BetterTTV/subscription","commits_url":"https://api.github.com/repos/night/BetterTTV/commits{/sha}","git_commits_url":"https://api.github.com/repos/night/BetterTTV/git/commits{/sha}","comments_url":"https://api.github.com/repos/night/BetterTTV/comments{/number}","issue_comment_url":"https://api.github.com/repos/night/BetterTTV/issues/comments/{number}","contents_url":"https://api.github.com/repos/night/BetterTTV/contents/{+path}","compare_url":"https://api.github.com/repos/night/BetterTTV/compare/{base}...{head}","merges_url":"https://api.github.com/repos/night/BetterTTV/merges","archive_url":"https://api.github.com/repos/night/BetterTTV/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/night/BetterTTV/downloads","issues_url":"https://api.github.com/repos/night/BetterTTV/issues{/number}","pulls_url":"https://api.github.com/repos/night/BetterTTV/pulls{/number}","milestones_url":"https://api.github.com/repos/night/BetterTTV/milestones{/number}","notifications_url":"https://api.github.com/repos/night/BetterTTV/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/night/BetterTTV/labels{/name}","releases_url":"https://api.github.com/repos/night/BetterTTV/releases{/id}","created_at":"2014-05-01T21:15:17Z","updated_at":"2014-06-13T07:09:41Z","pushed_at":"2014-06-12T05:36:47Z","git_url":"git://github.com/night/BetterTTV.git","ssh_url":"git@github.com:night/BetterTTV.git","clone_url":"https://github.com/night/BetterTTV.git","svn_url":"https://github.com/night/BetterTTV","homepage":"http://betterttv.com","size":2136,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/night/BetterTTV/pulls/19"},"html":{"href":"https://github.com/night/BetterTTV/pull/19"},"issue":{"href":"https://api.github.com/repos/night/BetterTTV/issues/19"},"comments":{"href":"https://api.github.com/repos/night/BetterTTV/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/night/BetterTTV/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/night/BetterTTV/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/night/BetterTTV/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/night/BetterTTV/statuses/54d031fd7a2eb360e4cc48f641e0f6dbbc552f69"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":3,"additions":77,"deletions":17,"changed_files":1}}