GitHub PullRequestReviewCommentEvent at 2014-08-23 14:11:37
Repository: publish
Actor: mottosso
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/abstractfactory/publish/pulls/comments/16630821","id":16630821,"diff_hunk":"@@ -38,16 +38,23 @@ def __str__(self):\n     def __repr__(self):\n         return u\"%s.%s(%r)\" % (__name__, type(self).__name__, self.__str__())\n \n-    def __init__(self, instance):\n-        self.instance = instance\n+    def __init__(self, context):\n+        self.context = context\n         self.errors = list()\n \n     @abc.abstractmethod\n     def process(self):\n         return None\n \n+    def instances(self):","path":"publish/abstract.py","position":14,"original_position":14,"commit_id":"9842d61dbeb576a034812c3bd78e97896585e252","original_commit_id":"9842d61dbeb576a034812c3bd78e97896585e252","user":{"login":"mottosso","id":2152766,"avatar_url":"https://avatars.githubusercontent.com/u/2152766?v=2","gravatar_id":"1dc5f5c20aadc75577c7dd365022ebe7","url":"https://api.github.com/users/mottosso","html_url":"https://github.com/mottosso","followers_url":"https://api.github.com/users/mottosso/followers","following_url":"https://api.github.com/users/mottosso/following{/other_user}","gists_url":"https://api.github.com/users/mottosso/gists{/gist_id}","starred_url":"https://api.github.com/users/mottosso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mottosso/subscriptions","organizations_url":"https://api.github.com/users/mottosso/orgs","repos_url":"https://api.github.com/users/mottosso/repos","events_url":"https://api.github.com/users/mottosso/events{/privacy}","received_events_url":"https://api.github.com/users/mottosso/received_events","type":"User","site_admin":false},"body":"What do you think about making this a `@property`? My motivation lies in sticking with verbs for functions/methods, and nouns for attributes/properties. That is, either going with \"compute_instances()\" or something similar, or:\r\n\r\n```python\r\n@property\r\ndef instances(self):\r\n    ...\r\n```","created_at":"2014-08-23T14:11:37Z","updated_at":"2014-08-23T14:11:37Z","html_url":"https://github.com/abstractfactory/publish/pull/53#discussion_r16630821","pull_request_url":"https://api.github.com/repos/abstractfactory/publish/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/abstractfactory/publish/pulls/comments/16630821"},"html":{"href":"https://github.com/abstractfactory/publish/pull/53#discussion_r16630821"},"pull_request":{"href":"https://api.github.com/repos/abstractfactory/publish/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/abstractfactory/publish/pulls/53","id":20209692,"html_url":"https://github.com/abstractfactory/publish/pull/53","diff_url":"https://github.com/abstractfactory/publish/pull/53.diff","patch_url":"https://github.com/abstractfactory/publish/pull/53.patch","issue_url":"https://api.github.com/repos/abstractfactory/publish/issues/53","number":53,"state":"open","locked":false,"title":"Attempt at #49","user":{"login":"tokejepsen","id":1860085,"avatar_url":"https://avatars.githubusercontent.com/u/1860085?v=2","gravatar_id":"1de121013330bfd2921323b83bfc6505","url":"https://api.github.com/users/tokejepsen","html_url":"https://github.com/tokejepsen","followers_url":"https://api.github.com/users/tokejepsen/followers","following_url":"https://api.github.com/users/tokejepsen/following{/other_user}","gists_url":"https://api.github.com/users/tokejepsen/gists{/gist_id}","starred_url":"https://api.github.com/users/tokejepsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokejepsen/subscriptions","organizations_url":"https://api.github.com/users/tokejepsen/orgs","repos_url":"https://api.github.com/users/tokejepsen/repos","events_url":"https://api.github.com/users/tokejepsen/events{/privacy}","received_events_url":"https://api.github.com/users/tokejepsen/received_events","type":"User","site_admin":false},"body":"All plugins now inherit from the same Filter base class.\r\nThere is a convenience function for plugins, to get the relevant\r\ninstances called with `self.instances`.","created_at":"2014-08-23T13:13:21Z","updated_at":"2014-08-23T14:11:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4e63919980bc6d72580c729de8866271e4808de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/abstractfactory/publish/pulls/53/commits","review_comments_url":"https://api.github.com/repos/abstractfactory/publish/pulls/53/comments","review_comment_url":"https://api.github.com/repos/abstractfactory/publish/pulls/comments/{number}","comments_url":"https://api.github.com/repos/abstractfactory/publish/issues/53/comments","statuses_url":"https://api.github.com/repos/abstractfactory/publish/statuses/9842d61dbeb576a034812c3bd78e97896585e252","head":{"label":"tokejepsen:master","ref":"master","sha":"9842d61dbeb576a034812c3bd78e97896585e252","user":{"login":"tokejepsen","id":1860085,"avatar_url":"https://avatars.githubusercontent.com/u/1860085?v=2","gravatar_id":"1de121013330bfd2921323b83bfc6505","url":"https://api.github.com/users/tokejepsen","html_url":"https://github.com/tokejepsen","followers_url":"https://api.github.com/users/tokejepsen/followers","following_url":"https://api.github.com/users/tokejepsen/following{/other_user}","gists_url":"https://api.github.com/users/tokejepsen/gists{/gist_id}","starred_url":"https://api.github.com/users/tokejepsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokejepsen/subscriptions","organizations_url":"https://api.github.com/users/tokejepsen/orgs","repos_url":"https://api.github.com/users/tokejepsen/repos","events_url":"https://api.github.com/users/tokejepsen/events{/privacy}","received_events_url":"https://api.github.com/users/tokejepsen/received_events","type":"User","site_admin":false},"repo":{"id":23052380,"name":"publish","full_name":"tokejepsen/publish","owner":{"login":"tokejepsen","id":1860085,"avatar_url":"https://avatars.githubusercontent.com/u/1860085?v=2","gravatar_id":"1de121013330bfd2921323b83bfc6505","url":"https://api.github.com/users/tokejepsen","html_url":"https://github.com/tokejepsen","followers_url":"https://api.github.com/users/tokejepsen/followers","following_url":"https://api.github.com/users/tokejepsen/following{/other_user}","gists_url":"https://api.github.com/users/tokejepsen/gists{/gist_id}","starred_url":"https://api.github.com/users/tokejepsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokejepsen/subscriptions","organizations_url":"https://api.github.com/users/tokejepsen/orgs","repos_url":"https://api.github.com/users/tokejepsen/repos","events_url":"https://api.github.com/users/tokejepsen/events{/privacy}","received_events_url":"https://api.github.com/users/tokejepsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tokejepsen/publish","description":"quality assurance for content","fork":true,"url":"https://api.github.com/repos/tokejepsen/publish","forks_url":"https://api.github.com/repos/tokejepsen/publish/forks","keys_url":"https://api.github.com/repos/tokejepsen/publish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tokejepsen/publish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tokejepsen/publish/teams","hooks_url":"https://api.github.com/repos/tokejepsen/publish/hooks","issue_events_url":"https://api.github.com/repos/tokejepsen/publish/issues/events{/number}","events_url":"https://api.github.com/repos/tokejepsen/publish/events","assignees_url":"https://api.github.com/repos/tokejepsen/publish/assignees{/user}","branches_url":"https://api.github.com/repos/tokejepsen/publish/branches{/branch}","tags_url":"https://api.github.com/repos/tokejepsen/publish/tags","blobs_url":"https://api.github.com/repos/tokejepsen/publish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tokejepsen/publish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tokejepsen/publish/git/refs{/sha}","trees_url":"https://api.github.com/repos/tokejepsen/publish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tokejepsen/publish/statuses/{sha}","languages_url":"https://api.github.com/repos/tokejepsen/publish/languages","stargazers_url":"https://api.github.com/repos/tokejepsen/publish/stargazers","contributors_url":"https://api.github.com/repos/tokejepsen/publish/contributors","subscribers_url":"https://api.github.com/repos/tokejepsen/publish/subscribers","subscription_url":"https://api.github.com/repos/tokejepsen/publish/subscription","commits_url":"https://api.github.com/repos/tokejepsen/publish/commits{/sha}","git_commits_url":"https://api.github.com/repos/tokejepsen/publish/git/commits{/sha}","comments_url":"https://api.github.com/repos/tokejepsen/publish/comments{/number}","issue_comment_url":"https://api.github.com/repos/tokejepsen/publish/issues/comments/{number}","contents_url":"https://api.github.com/repos/tokejepsen/publish/contents/{+path}","compare_url":"https://api.github.com/repos/tokejepsen/publish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tokejepsen/publish/merges","archive_url":"https://api.github.com/repos/tokejepsen/publish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tokejepsen/publish/downloads","issues_url":"https://api.github.com/repos/tokejepsen/publish/issues{/number}","pulls_url":"https://api.github.com/repos/tokejepsen/publish/pulls{/number}","milestones_url":"https://api.github.com/repos/tokejepsen/publish/milestones{/number}","notifications_url":"https://api.github.com/repos/tokejepsen/publish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tokejepsen/publish/labels{/name}","releases_url":"https://api.github.com/repos/tokejepsen/publish/releases{/id}","created_at":"2014-08-17T22:58:08Z","updated_at":"2014-08-17T23:05:36Z","pushed_at":"2014-08-23T13:13:00Z","git_url":"git://github.com/tokejepsen/publish.git","ssh_url":"git@github.com:tokejepsen/publish.git","clone_url":"https://github.com/tokejepsen/publish.git","svn_url":"https://github.com/tokejepsen/publish","homepage":"https://github.com/abstractfactory/publish","size":5285,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"abstractfactory:master","ref":"master","sha":"71665a80186c9f77d7316be20d3caa6876380d6f","user":{"login":"abstractfactory","id":5812121,"avatar_url":"https://avatars.githubusercontent.com/u/5812121?v=2","gravatar_id":null,"url":"https://api.github.com/users/abstractfactory","html_url":"https://github.com/abstractfactory","followers_url":"https://api.github.com/users/abstractfactory/followers","following_url":"https://api.github.com/users/abstractfactory/following{/other_user}","gists_url":"https://api.github.com/users/abstractfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/abstractfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abstractfactory/subscriptions","organizations_url":"https://api.github.com/users/abstractfactory/orgs","repos_url":"https://api.github.com/users/abstractfactory/repos","events_url":"https://api.github.com/users/abstractfactory/events{/privacy}","received_events_url":"https://api.github.com/users/abstractfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":22350324,"name":"publish","full_name":"abstractfactory/publish","owner":{"login":"abstractfactory","id":5812121,"avatar_url":"https://avatars.githubusercontent.com/u/5812121?v=2","gravatar_id":null,"url":"https://api.github.com/users/abstractfactory","html_url":"https://github.com/abstractfactory","followers_url":"https://api.github.com/users/abstractfactory/followers","following_url":"https://api.github.com/users/abstractfactory/following{/other_user}","gists_url":"https://api.github.com/users/abstractfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/abstractfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abstractfactory/subscriptions","organizations_url":"https://api.github.com/users/abstractfactory/orgs","repos_url":"https://api.github.com/users/abstractfactory/repos","events_url":"https://api.github.com/users/abstractfactory/events{/privacy}","received_events_url":"https://api.github.com/users/abstractfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/abstractfactory/publish","description":"quality assurance for content","fork":false,"url":"https://api.github.com/repos/abstractfactory/publish","forks_url":"https://api.github.com/repos/abstractfactory/publish/forks","keys_url":"https://api.github.com/repos/abstractfactory/publish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abstractfactory/publish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abstractfactory/publish/teams","hooks_url":"https://api.github.com/repos/abstractfactory/publish/hooks","issue_events_url":"https://api.github.com/repos/abstractfactory/publish/issues/events{/number}","events_url":"https://api.github.com/repos/abstractfactory/publish/events","assignees_url":"https://api.github.com/repos/abstractfactory/publish/assignees{/user}","branches_url":"https://api.github.com/repos/abstractfactory/publish/branches{/branch}","tags_url":"https://api.github.com/repos/abstractfactory/publish/tags","blobs_url":"https://api.github.com/repos/abstractfactory/publish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abstractfactory/publish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abstractfactory/publish/git/refs{/sha}","trees_url":"https://api.github.com/repos/abstractfactory/publish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abstractfactory/publish/statuses/{sha}","languages_url":"https://api.github.com/repos/abstractfactory/publish/languages","stargazers_url":"https://api.github.com/repos/abstractfactory/publish/stargazers","contributors_url":"https://api.github.com/repos/abstractfactory/publish/contributors","subscribers_url":"https://api.github.com/repos/abstractfactory/publish/subscribers","subscription_url":"https://api.github.com/repos/abstractfactory/publish/subscription","commits_url":"https://api.github.com/repos/abstractfactory/publish/commits{/sha}","git_commits_url":"https://api.github.com/repos/abstractfactory/publish/git/commits{/sha}","comments_url":"https://api.github.com/repos/abstractfactory/publish/comments{/number}","issue_comment_url":"https://api.github.com/repos/abstractfactory/publish/issues/comments/{number}","contents_url":"https://api.github.com/repos/abstractfactory/publish/contents/{+path}","compare_url":"https://api.github.com/repos/abstractfactory/publish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abstractfactory/publish/merges","archive_url":"https://api.github.com/repos/abstractfactory/publish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abstractfactory/publish/downloads","issues_url":"https://api.github.com/repos/abstractfactory/publish/issues{/number}","pulls_url":"https://api.github.com/repos/abstractfactory/publish/pulls{/number}","milestones_url":"https://api.github.com/repos/abstractfactory/publish/milestones{/number}","notifications_url":"https://api.github.com/repos/abstractfactory/publish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abstractfactory/publish/labels{/name}","releases_url":"https://api.github.com/repos/abstractfactory/publish/releases{/id}","created_at":"2014-07-28T16:51:15Z","updated_at":"2014-08-07T01:52:28Z","pushed_at":"2014-08-23T08:31:54Z","git_url":"git://github.com/abstractfactory/publish.git","ssh_url":"git@github.com:abstractfactory/publish.git","clone_url":"https://github.com/abstractfactory/publish.git","svn_url":"https://github.com/abstractfactory/publish","homepage":"https://github.com/abstractfactory/publish","size":15557,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":27,"forks":5,"open_issues":27,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/abstractfactory/publish/pulls/53"},"html":{"href":"https://github.com/abstractfactory/publish/pull/53"},"issue":{"href":"https://api.github.com/repos/abstractfactory/publish/issues/53"},"comments":{"href":"https://api.github.com/repos/abstractfactory/publish/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/abstractfactory/publish/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/abstractfactory/publish/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/abstractfactory/publish/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/abstractfactory/publish/statuses/9842d61dbeb576a034812c3bd78e97896585e252"}}}}