GitHub PullRequestReviewCommentEvent at 2014-03-11 17:43:19
Repository: homebrew
Actor: mikemcquaid
Payload: {"comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/10485958","id":10485958,"diff_hunk":"@@ -0,0 +1,31 @@\n+require \"formula\"\n+\n+class ApacheSpark < Formula\n+  homepage \"https://spark.incubator.apache.org/\"\n+  url \"http://d3kbcqa49mib13.cloudfront.net/spark-0.9.0-incubating.tgz\"\n+  version \"0.9\"\n+  sha1 \"87c7dcb52847de78085881d9192a61fcab58272c\"\n+\n+  def install\n+    # build using internal sbt setup\n+    system \"./sbt/sbt\", \"assembly\"\n+    # remove windows stuff\n+    rm Dir['bin/*.cmd']\n+    rm Dir['sbin/*.cmd']\n+    libexec.install Dir['*']\n+    bin.write_exec_script libexec/'bin/spark-shell'\n+  end\n+\n+  def caveats\n+    s = <<-EOS.undent\n+        Apache Spark has been installed into #{prefix}\n+        Most file live under the #{libexec} directory and\n+        only spark-shell has been linked.\n+    EOS\n+    s\n+  end\n+\n+  test do\n+    system \"#{libexec}/bin/spark-shell\", \"-h\"","path":"Library/Formula/apache-spark.rb","position":29,"original_position":29,"commit_id":"73310eb58b172aad3bfa3cef7860af5158bb557b","original_commit_id":"73310eb58b172aad3bfa3cef7860af5158bb557b","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://gravatar.com/avatar/215e0166d4d8265395c5d9076da73c70?d=https%3A%2F%2Fidenticons.github.com%2F19e490b885e34ade007230f7a58dc9a4.png&r=x","gravatar_id":"215e0166d4d8265395c5d9076da73c70","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"body":"Can this test be modified to do something more substantial then e.g. `--version` or `--help`? See `cmake.rb` for an example of a formula with a good test. Thanks!","created_at":"2014-03-11T17:43:19Z","updated_at":"2014-03-11T17:43:19Z","html_url":"https://github.com/Homebrew/homebrew/pull/27433#discussion_r10485958","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/27433","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/10485958"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/27433#discussion_r10485958"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/27433"}}}}