GitHub PullRequestEvent at 2014-01-20 21:53:00
Repository: hibernate-orm
Actor: brmeyer
Payload: {"action":"closed","number":563,"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/563","id":7343139,"html_url":"https://github.com/hibernate/hibernate-orm/pull/563","diff_url":"https://github.com/hibernate/hibernate-orm/pull/563.diff","patch_url":"https://github.com/hibernate/hibernate-orm/pull/563.patch","issue_url":"https://github.com/hibernate/hibernate-orm/pull/563","number":563,"state":"closed","title":"HHH-8404: Correctly render 'ListIndexExpression'.","user":{"login":"ben-arbitrage","id":5137215,"avatar_url":"https://gravatar.com/avatar/a7d92f397fddff7d82d6372f981439e4?d=https%3A%2F%2Fidenticons.github.com%2F207415e980de9be20bae6b12731392f9.png&r=x","gravatar_id":"a7d92f397fddff7d82d6372f981439e4","url":"https://api.github.com/users/ben-arbitrage","html_url":"https://github.com/ben-arbitrage","followers_url":"https://api.github.com/users/ben-arbitrage/followers","following_url":"https://api.github.com/users/ben-arbitrage/following{/other_user}","gists_url":"https://api.github.com/users/ben-arbitrage/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-arbitrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-arbitrage/subscriptions","organizations_url":"https://api.github.com/users/ben-arbitrage/orgs","repos_url":"https://api.github.com/users/ben-arbitrage/repos","events_url":"https://api.github.com/users/ben-arbitrage/events{/privacy}","received_events_url":"https://api.github.com/users/ben-arbitrage/received_events","type":"User","site_admin":false},"body":"A correctly rendered 'index' expression should be \"index(foo)\" where 'foo' is\r\nthe name (or alias) of the list table. Since 'ListAttributeJoin' passes 'this'\r\nas 'origin' when creating a 'ListIndexExpression', \"origin.getPathIdentifier()\"\r\nwill already refer to this list table on the right-hand side of the join.\r\nAppending the list attribute (which is relative to the table on the left-hand\r\nside of the join) does not make sense.","created_at":"2013-08-02T04:53:47Z","updated_at":"2014-01-20T21:52:57Z","closed_at":"2014-01-20T21:52:57Z","merged_at":null,"merge_commit_sha":"e4d29c2e27dbfb59f3f1a46e89825301cea98817","assignee":null,"milestone":null,"commits_url":"https://github.com/hibernate/hibernate-orm/pull/563/commits","review_comments_url":"https://github.com/hibernate/hibernate-orm/pull/563/comments","review_comment_url":"/repos/hibernate/hibernate-orm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/563/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-orm/statuses/5a0f8189d3799eb12e906ec5712862d5f4be89fb","head":{"label":"ben-arbitrage:HHH-8404","ref":"HHH-8404","sha":"5a0f8189d3799eb12e906ec5712862d5f4be89fb","user":{"login":"ben-arbitrage","id":5137215,"avatar_url":"https://gravatar.com/avatar/a7d92f397fddff7d82d6372f981439e4?d=https%3A%2F%2Fidenticons.github.com%2F207415e980de9be20bae6b12731392f9.png&r=x","gravatar_id":"a7d92f397fddff7d82d6372f981439e4","url":"https://api.github.com/users/ben-arbitrage","html_url":"https://github.com/ben-arbitrage","followers_url":"https://api.github.com/users/ben-arbitrage/followers","following_url":"https://api.github.com/users/ben-arbitrage/following{/other_user}","gists_url":"https://api.github.com/users/ben-arbitrage/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-arbitrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-arbitrage/subscriptions","organizations_url":"https://api.github.com/users/ben-arbitrage/orgs","repos_url":"https://api.github.com/users/ben-arbitrage/repos","events_url":"https://api.github.com/users/ben-arbitrage/events{/privacy}","received_events_url":"https://api.github.com/users/ben-arbitrage/received_events","type":"User","site_admin":false},"repo":{"id":11813529,"name":"hibernate-orm","full_name":"ben-arbitrage/hibernate-orm","owner":{"login":"ben-arbitrage","id":5137215,"avatar_url":"https://gravatar.com/avatar/a7d92f397fddff7d82d6372f981439e4?d=https%3A%2F%2Fidenticons.github.com%2F207415e980de9be20bae6b12731392f9.png&r=x","gravatar_id":"a7d92f397fddff7d82d6372f981439e4","url":"https://api.github.com/users/ben-arbitrage","html_url":"https://github.com/ben-arbitrage","followers_url":"https://api.github.com/users/ben-arbitrage/followers","following_url":"https://api.github.com/users/ben-arbitrage/following{/other_user}","gists_url":"https://api.github.com/users/ben-arbitrage/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-arbitrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-arbitrage/subscriptions","organizations_url":"https://api.github.com/users/ben-arbitrage/orgs","repos_url":"https://api.github.com/users/ben-arbitrage/repos","events_url":"https://api.github.com/users/ben-arbitrage/events{/privacy}","received_events_url":"https://api.github.com/users/ben-arbitrage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ben-arbitrage/hibernate-orm","description":"Hibernate's core Object/Relational Mapping functionality","fork":true,"url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm","forks_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/forks","keys_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/teams","hooks_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/hooks","issue_events_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/issues/events{/number}","events_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/events","assignees_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/assignees{/user}","branches_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/branches{/branch}","tags_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/tags","blobs_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/statuses/{sha}","languages_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/languages","stargazers_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/stargazers","contributors_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/contributors","subscribers_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/subscribers","subscription_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/subscription","commits_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/issues/comments/{number}","contents_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/contents/{+path}","compare_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/merges","archive_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/downloads","issues_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/issues{/number}","pulls_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/pulls{/number}","milestones_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/milestones{/number}","notifications_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/labels{/name}","releases_url":"https://api.github.com/repos/ben-arbitrage/hibernate-orm/releases{/id}","created_at":"2013-08-01T09:56:35Z","updated_at":"2013-08-21T19:40:46Z","pushed_at":"2013-08-02T04:52:57Z","git_url":"git://github.com/ben-arbitrage/hibernate-orm.git","ssh_url":"git@github.com:ben-arbitrage/hibernate-orm.git","clone_url":"https://github.com/ben-arbitrage/hibernate-orm.git","svn_url":"https://github.com/ben-arbitrage/hibernate-orm","homepage":"http://hibernate.org","size":110277,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"8ccbd7d1212804dc27e7c0e84edf08db128710c0","user":{"login":"hibernate","id":348262,"avatar_url":"https://gravatar.com/avatar/ce9572f319e848be149196b772776981?d=https%3A%2F%2Fidenticons.github.com%2Fefad18a5eb0eaea968760589083a8921.png&r=x","gravatar_id":"ce9572f319e848be149196b772776981","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":961036,"name":"hibernate-orm","full_name":"hibernate/hibernate-orm","owner":{"login":"hibernate","id":348262,"avatar_url":"https://gravatar.com/avatar/ce9572f319e848be149196b772776981?d=https%3A%2F%2Fidenticons.github.com%2Fefad18a5eb0eaea968760589083a8921.png&r=x","gravatar_id":"ce9572f319e848be149196b772776981","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-orm","description":"Hibernate's core Object/Relational Mapping functionality","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-orm","forks_url":"https://api.github.com/repos/hibernate/hibernate-orm/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-orm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-orm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-orm/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-orm/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-orm/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-orm/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-orm/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-orm/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-orm/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-orm/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-orm/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-orm/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-orm/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-orm/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-orm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-orm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-orm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/comments/{number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-orm/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-orm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-orm/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-orm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-orm/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-orm/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-orm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-orm/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-orm/releases{/id}","created_at":"2010-10-04T16:15:52Z","updated_at":"2014-01-16T17:39:02Z","pushed_at":"2014-01-16T17:38:59Z","git_url":"git://github.com/hibernate/hibernate-orm.git","ssh_url":"git@github.com:hibernate/hibernate-orm.git","clone_url":"https://github.com/hibernate/hibernate-orm.git","svn_url":"https://github.com/hibernate/hibernate-orm","homepage":"http://hibernate.org","size":207215,"stargazers_count":852,"watchers_count":852,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":true,"forks_count":620,"mirror_url":null,"open_issues_count":35,"forks":620,"open_issues":35,"watchers":852,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/563"},"html":{"href":"https://github.com/hibernate/hibernate-orm/pull/563"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/issues/563"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/563/comments"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-orm/statuses/5a0f8189d3799eb12e906ec5712862d5f4be89fb"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}