GitHub PullRequestEvent at 2014-05-05 11:10:48
Repository: core
Actor: kacfengine
Payload: {"action":"closed","number":1678,"pull_request":{"url":"https://api.github.com/repos/cfengine/core/pulls/1678","id":15476242,"html_url":"https://github.com/cfengine/core/pull/1678","diff_url":"https://github.com/cfengine/core/pull/1678.diff","patch_url":"https://github.com/cfengine/core/pull/1678.patch","issue_url":"https://api.github.com/repos/cfengine/core/issues/1678","number":1678,"state":"closed","title":"Select() error code is no longer lost because of recv().","user":{"login":"jimis","id":3584514,"avatar_url":"https://avatars.githubusercontent.com/u/3584514?","gravatar_id":"9207bae5f3a51e4bc03d6fdfde53d7b1","url":"https://api.github.com/users/jimis","html_url":"https://github.com/jimis","followers_url":"https://api.github.com/users/jimis/followers","following_url":"https://api.github.com/users/jimis/following{/other_user}","gists_url":"https://api.github.com/users/jimis/gists{/gist_id}","starred_url":"https://api.github.com/users/jimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimis/subscriptions","organizations_url":"https://api.github.com/users/jimis/orgs","repos_url":"https://api.github.com/users/jimis/repos","events_url":"https://api.github.com/users/jimis/events{/privacy}","received_events_url":"https://api.github.com/users/jimis/received_events","type":"User","site_admin":false},"body":"This is a very simple change, looks big because of white space movement, please review accordingly.\r\n\r\nDuring stress testing, it happened that I got some weird error codes reported for ```select()```. The fact is that select's error was lost, and recv's error was being reported.","created_at":"2014-05-04T22:32:27Z","updated_at":"2014-05-05T11:10:47Z","closed_at":"2014-05-05T11:10:47Z","merged_at":"2014-05-05T11:10:47Z","merge_commit_sha":"27f5b6c7d233e46f1297bd058de2a05719a17c5b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfengine/core/pulls/1678/commits","review_comments_url":"https://api.github.com/repos/cfengine/core/pulls/1678/comments","review_comment_url":"https://api.github.com/repos/cfengine/core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cfengine/core/issues/1678/comments","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/56afde78024563bc1daf6e3a5f8f44b65f3b04e5","head":{"label":"jimis:select_error_lost","ref":"select_error_lost","sha":"56afde78024563bc1daf6e3a5f8f44b65f3b04e5","user":{"login":"jimis","id":3584514,"avatar_url":"https://avatars.githubusercontent.com/u/3584514?","gravatar_id":"9207bae5f3a51e4bc03d6fdfde53d7b1","url":"https://api.github.com/users/jimis","html_url":"https://github.com/jimis","followers_url":"https://api.github.com/users/jimis/followers","following_url":"https://api.github.com/users/jimis/following{/other_user}","gists_url":"https://api.github.com/users/jimis/gists{/gist_id}","starred_url":"https://api.github.com/users/jimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimis/subscriptions","organizations_url":"https://api.github.com/users/jimis/orgs","repos_url":"https://api.github.com/users/jimis/repos","events_url":"https://api.github.com/users/jimis/events{/privacy}","received_events_url":"https://api.github.com/users/jimis/received_events","type":"User","site_admin":false},"repo":{"id":8216817,"name":"core","full_name":"jimis/core","owner":{"login":"jimis","id":3584514,"avatar_url":"https://avatars.githubusercontent.com/u/3584514?","gravatar_id":"9207bae5f3a51e4bc03d6fdfde53d7b1","url":"https://api.github.com/users/jimis","html_url":"https://github.com/jimis","followers_url":"https://api.github.com/users/jimis/followers","following_url":"https://api.github.com/users/jimis/following{/other_user}","gists_url":"https://api.github.com/users/jimis/gists{/gist_id}","starred_url":"https://api.github.com/users/jimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimis/subscriptions","organizations_url":"https://api.github.com/users/jimis/orgs","repos_url":"https://api.github.com/users/jimis/repos","events_url":"https://api.github.com/users/jimis/events{/privacy}","received_events_url":"https://api.github.com/users/jimis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimis/core","description":"CFEngine Community","fork":true,"url":"https://api.github.com/repos/jimis/core","forks_url":"https://api.github.com/repos/jimis/core/forks","keys_url":"https://api.github.com/repos/jimis/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimis/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimis/core/teams","hooks_url":"https://api.github.com/repos/jimis/core/hooks","issue_events_url":"https://api.github.com/repos/jimis/core/issues/events{/number}","events_url":"https://api.github.com/repos/jimis/core/events","assignees_url":"https://api.github.com/repos/jimis/core/assignees{/user}","branches_url":"https://api.github.com/repos/jimis/core/branches{/branch}","tags_url":"https://api.github.com/repos/jimis/core/tags","blobs_url":"https://api.github.com/repos/jimis/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimis/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimis/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimis/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimis/core/statuses/{sha}","languages_url":"https://api.github.com/repos/jimis/core/languages","stargazers_url":"https://api.github.com/repos/jimis/core/stargazers","contributors_url":"https://api.github.com/repos/jimis/core/contributors","subscribers_url":"https://api.github.com/repos/jimis/core/subscribers","subscription_url":"https://api.github.com/repos/jimis/core/subscription","commits_url":"https://api.github.com/repos/jimis/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimis/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimis/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimis/core/issues/comments/{number}","contents_url":"https://api.github.com/repos/jimis/core/contents/{+path}","compare_url":"https://api.github.com/repos/jimis/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimis/core/merges","archive_url":"https://api.github.com/repos/jimis/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimis/core/downloads","issues_url":"https://api.github.com/repos/jimis/core/issues{/number}","pulls_url":"https://api.github.com/repos/jimis/core/pulls{/number}","milestones_url":"https://api.github.com/repos/jimis/core/milestones{/number}","notifications_url":"https://api.github.com/repos/jimis/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimis/core/labels{/name}","releases_url":"https://api.github.com/repos/jimis/core/releases{/id}","created_at":"2013-02-15T10:54:22Z","updated_at":"2014-05-05T11:10:47Z","pushed_at":"2014-05-04T22:29:44Z","git_url":"git://github.com/jimis/core.git","ssh_url":"git@github.com:jimis/core.git","clone_url":"https://github.com/jimis/core.git","svn_url":"https://github.com/jimis/core","homepage":"https://cfengine.com/community/","size":48478,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfengine:master","ref":"master","sha":"837ad2264d141f1e683380f0515d1a03bbd144ea","user":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?","gravatar_id":"c297053642cc180a967666f8b141d5c5","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"repo":{"id":3543548,"name":"core","full_name":"cfengine/core","owner":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?","gravatar_id":"c297053642cc180a967666f8b141d5c5","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfengine/core","description":"CFEngine Community","fork":false,"url":"https://api.github.com/repos/cfengine/core","forks_url":"https://api.github.com/repos/cfengine/core/forks","keys_url":"https://api.github.com/repos/cfengine/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfengine/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfengine/core/teams","hooks_url":"https://api.github.com/repos/cfengine/core/hooks","issue_events_url":"https://api.github.com/repos/cfengine/core/issues/events{/number}","events_url":"https://api.github.com/repos/cfengine/core/events","assignees_url":"https://api.github.com/repos/cfengine/core/assignees{/user}","branches_url":"https://api.github.com/repos/cfengine/core/branches{/branch}","tags_url":"https://api.github.com/repos/cfengine/core/tags","blobs_url":"https://api.github.com/repos/cfengine/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfengine/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfengine/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfengine/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/{sha}","languages_url":"https://api.github.com/repos/cfengine/core/languages","stargazers_url":"https://api.github.com/repos/cfengine/core/stargazers","contributors_url":"https://api.github.com/repos/cfengine/core/contributors","subscribers_url":"https://api.github.com/repos/cfengine/core/subscribers","subscription_url":"https://api.github.com/repos/cfengine/core/subscription","commits_url":"https://api.github.com/repos/cfengine/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfengine/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfengine/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfengine/core/issues/comments/{number}","contents_url":"https://api.github.com/repos/cfengine/core/contents/{+path}","compare_url":"https://api.github.com/repos/cfengine/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfengine/core/merges","archive_url":"https://api.github.com/repos/cfengine/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfengine/core/downloads","issues_url":"https://api.github.com/repos/cfengine/core/issues{/number}","pulls_url":"https://api.github.com/repos/cfengine/core/pulls{/number}","milestones_url":"https://api.github.com/repos/cfengine/core/milestones{/number}","notifications_url":"https://api.github.com/repos/cfengine/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfengine/core/labels{/name}","releases_url":"https://api.github.com/repos/cfengine/core/releases{/id}","created_at":"2012-02-25T09:19:05Z","updated_at":"2014-05-05T11:10:47Z","pushed_at":"2014-05-05T11:10:47Z","git_url":"git://github.com/cfengine/core.git","ssh_url":"git@github.com:cfengine/core.git","clone_url":"https://github.com/cfengine/core.git","svn_url":"https://github.com/cfengine/core","homepage":"https://cfengine.com/community/","size":70099,"stargazers_count":185,"watchers_count":185,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":116,"mirror_url":null,"open_issues_count":38,"forks":116,"open_issues":38,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/1678"},"html":{"href":"https://github.com/cfengine/core/pull/1678"},"issue":{"href":"https://api.github.com/repos/cfengine/core/issues/1678"},"comments":{"href":"https://api.github.com/repos/cfengine/core/issues/1678/comments"},"review_comments":{"href":"https://api.github.com/repos/cfengine/core/pulls/1678/comments"},"review_comment":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cfengine/core/pulls/1678/commits"},"statuses":{"href":"https://api.github.com/repos/cfengine/core/statuses/56afde78024563bc1daf6e3a5f8f44b65f3b04e5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kacfengine","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?","gravatar_id":"051c8986741264f2671890948d4f4d30","url":"https://api.github.com/users/kacfengine","html_url":"https://github.com/kacfengine","followers_url":"https://api.github.com/users/kacfengine/followers","following_url":"https://api.github.com/users/kacfengine/following{/other_user}","gists_url":"https://api.github.com/users/kacfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/kacfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacfengine/subscriptions","organizations_url":"https://api.github.com/users/kacfengine/orgs","repos_url":"https://api.github.com/users/kacfengine/repos","events_url":"https://api.github.com/users/kacfengine/events{/privacy}","received_events_url":"https://api.github.com/users/kacfengine/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":50,"deletions":53,"changed_files":1}}