GitHub PullRequestReviewCommentEvent at 2014-12-03 14:57:17
Repository: iris
Actor: esc24
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SciTools/iris/pulls/comments/21235799","id":21235799,"diff_hunk":"@@ -642,6 +642,72 @@ def grid_definition_template_5(section, metadata):\n                                      'grid_latitude', 'grid_longitude', cs)\n \n \n+def grid_definition_template_12(section, metadata):\n+    \"\"\"\n+    Translate template representing transverse Mercator.\n+\n+    Updates the metadata in-place with the translations.\n+\n+    Args:\n+\n+    * section:\n+        Dictionary of coded key/value pairs from section 3 of the message.\n+\n+    * metadata:\n+        :class:`collections.OrderedDict` of metadata.\n+\n+    \"\"\"\n+    major, minor, radius = ellipsoid_geometry(section)\n+    geog_cs = ellipsoid(section['shapeOfTheEarth'], major, minor, radius)\n+\n+    lat = section['latitudeOfReferencePoint'] * _GRID_ACCURACY_IN_DEGREES\n+    lon = section['longitudeOfReferencePoint'] * _GRID_ACCURACY_IN_DEGREES\n+    scale = section['scaleFactorAtReferencePoint']\n+    CM_TO_M = 0.01\n+    easting = section['XR'] * CM_TO_M\n+    northing = section['YR'] * CM_TO_M\n+    cs = icoord_systems.TransverseMercator(lat, lon, easting, northing,\n+                                           scale, geog_cs)\n+\n+    # Rather unhelpfully this grid definition template seems to be\n+    # overspecified, and thus open to inconsistency.\n+    last_x = section['x1'] + (section['Ni'] - 1) * section['Di']","path":"lib/iris/fileformats/grib/_load_convert.py","position":63,"original_position":33,"commit_id":"01c388027867c2fd5b8ff6f2ddcd40f2592e9e1d","original_commit_id":"05cb1940e234cf1747f6b56cbf445fc07e276fcd","user":{"login":"esc24","id":1634089,"avatar_url":"https://avatars.githubusercontent.com/u/1634089?v=3","gravatar_id":"","url":"https://api.github.com/users/esc24","html_url":"https://github.com/esc24","followers_url":"https://api.github.com/users/esc24/followers","following_url":"https://api.github.com/users/esc24/following{/other_user}","gists_url":"https://api.github.com/users/esc24/gists{/gist_id}","starred_url":"https://api.github.com/users/esc24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esc24/subscriptions","organizations_url":"https://api.github.com/users/esc24/orgs","repos_url":"https://api.github.com/users/esc24/repos","events_url":"https://api.github.com/users/esc24/events{/privacy}","received_events_url":"https://api.github.com/users/esc24/received_events","type":"User","site_admin":false},"body":"I was hoping `gribapi.grib_get_native_type` might come to the rescue, but native didn't mean what I hoped it would.","created_at":"2014-12-03T14:57:17Z","updated_at":"2014-12-03T14:57:17Z","html_url":"https://github.com/SciTools/iris/pull/1475#discussion_r21235799","pull_request_url":"https://api.github.com/repos/SciTools/iris/pulls/1475","_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/21235799"},"html":{"href":"https://github.com/SciTools/iris/pull/1475#discussion_r21235799"},"pull_request":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1475"}}},"pull_request":{"url":"https://api.github.com/repos/SciTools/iris/pulls/1475","id":25337794,"html_url":"https://github.com/SciTools/iris/pull/1475","diff_url":"https://github.com/SciTools/iris/pull/1475.diff","patch_url":"https://github.com/SciTools/iris/pull/1475.patch","issue_url":"https://api.github.com/repos/SciTools/iris/issues/1475","number":1475,"state":"open","locked":false,"title":"Add load support for GRIB2 GDT 12.","user":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=3","gravatar_id":"","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-02T12:26:32Z","updated_at":"2014-12-03T14:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a39f4bec6e6e3ea0c2e7c37f98e0a8f99894180c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SciTools/iris/pulls/1475/commits","review_comments_url":"https://api.github.com/repos/SciTools/iris/pulls/1475/comments","review_comment_url":"https://api.github.com/repos/SciTools/iris/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SciTools/iris/issues/1475/comments","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/01c388027867c2fd5b8ff6f2ddcd40f2592e9e1d","head":{"label":"rhattersley:grib2-gdt12","ref":"grib2-gdt12","sha":"01c388027867c2fd5b8ff6f2ddcd40f2592e9e1d","user":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=3","gravatar_id":"","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"repo":{"id":5312787,"name":"iris","full_name":"rhattersley/iris","owner":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=3","gravatar_id":"","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhattersley/iris","description":"","fork":true,"url":"https://api.github.com/repos/rhattersley/iris","forks_url":"https://api.github.com/repos/rhattersley/iris/forks","keys_url":"https://api.github.com/repos/rhattersley/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhattersley/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhattersley/iris/teams","hooks_url":"https://api.github.com/repos/rhattersley/iris/hooks","issue_events_url":"https://api.github.com/repos/rhattersley/iris/issues/events{/number}","events_url":"https://api.github.com/repos/rhattersley/iris/events","assignees_url":"https://api.github.com/repos/rhattersley/iris/assignees{/user}","branches_url":"https://api.github.com/repos/rhattersley/iris/branches{/branch}","tags_url":"https://api.github.com/repos/rhattersley/iris/tags","blobs_url":"https://api.github.com/repos/rhattersley/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhattersley/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhattersley/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhattersley/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhattersley/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/rhattersley/iris/languages","stargazers_url":"https://api.github.com/repos/rhattersley/iris/stargazers","contributors_url":"https://api.github.com/repos/rhattersley/iris/contributors","subscribers_url":"https://api.github.com/repos/rhattersley/iris/subscribers","subscription_url":"https://api.github.com/repos/rhattersley/iris/subscription","commits_url":"https://api.github.com/repos/rhattersley/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhattersley/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhattersley/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhattersley/iris/issues/comments/{number}","contents_url":"https://api.github.com/repos/rhattersley/iris/contents/{+path}","compare_url":"https://api.github.com/repos/rhattersley/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhattersley/iris/merges","archive_url":"https://api.github.com/repos/rhattersley/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhattersley/iris/downloads","issues_url":"https://api.github.com/repos/rhattersley/iris/issues{/number}","pulls_url":"https://api.github.com/repos/rhattersley/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/rhattersley/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/rhattersley/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhattersley/iris/labels{/name}","releases_url":"https://api.github.com/repos/rhattersley/iris/releases{/id}","created_at":"2012-08-06T10:24:45Z","updated_at":"2014-11-25T10:39:03Z","pushed_at":"2014-12-03T12:55:25Z","git_url":"git://github.com/rhattersley/iris.git","ssh_url":"git@github.com:rhattersley/iris.git","clone_url":"https://github.com/rhattersley/iris.git","svn_url":"https://github.com/rhattersley/iris","homepage":null,"size":98636,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"SciTools:master","ref":"master","sha":"4d96f71ec3c8f3aa91fb81cba64f5bab08e723c0","user":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":5312648,"name":"iris","full_name":"SciTools/iris","owner":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciTools/iris","description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","fork":false,"url":"https://api.github.com/repos/SciTools/iris","forks_url":"https://api.github.com/repos/SciTools/iris/forks","keys_url":"https://api.github.com/repos/SciTools/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/iris/teams","hooks_url":"https://api.github.com/repos/SciTools/iris/hooks","issue_events_url":"https://api.github.com/repos/SciTools/iris/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/iris/events","assignees_url":"https://api.github.com/repos/SciTools/iris/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/iris/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/iris/tags","blobs_url":"https://api.github.com/repos/SciTools/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/iris/languages","stargazers_url":"https://api.github.com/repos/SciTools/iris/stargazers","contributors_url":"https://api.github.com/repos/SciTools/iris/contributors","subscribers_url":"https://api.github.com/repos/SciTools/iris/subscribers","subscription_url":"https://api.github.com/repos/SciTools/iris/subscription","commits_url":"https://api.github.com/repos/SciTools/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/iris/issues/comments/{number}","contents_url":"https://api.github.com/repos/SciTools/iris/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/iris/merges","archive_url":"https://api.github.com/repos/SciTools/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/iris/downloads","issues_url":"https://api.github.com/repos/SciTools/iris/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/iris/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/iris/releases{/id}","created_at":"2012-08-06T10:09:14Z","updated_at":"2014-12-03T12:46:10Z","pushed_at":"2014-12-03T12:46:10Z","git_url":"git://github.com/SciTools/iris.git","ssh_url":"git@github.com:SciTools/iris.git","clone_url":"https://github.com/SciTools/iris.git","svn_url":"https://github.com/SciTools/iris","homepage":"http://scitools.org.uk/iris/","size":141987,"stargazers_count":76,"watchers_count":76,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":148,"forks":66,"open_issues":148,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1475"},"html":{"href":"https://github.com/SciTools/iris/pull/1475"},"issue":{"href":"https://api.github.com/repos/SciTools/iris/issues/1475"},"comments":{"href":"https://api.github.com/repos/SciTools/iris/issues/1475/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1475/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1475/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/iris/statuses/01c388027867c2fd5b8ff6f2ddcd40f2592e9e1d"}}}}