GitHub PullRequestReviewCommentEvent at 2014-11-13 08:53:07
Repository: cockpit
Actor: mvollmer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/20278408","id":20278408,"diff_hunk":"@@ -0,0 +1,111 @@\n+<!DOCTYPE html>\n+<!--\n+  This file is part of Cockpit.\n+\n+  Copyright (C) 2014 Red Hat, Inc.\n+\n+  Cockpit is free software; you can redistribute it and/or modify it\n+  under the terms of the GNU Lesser General Public License as published by\n+  the Free Software Foundation; either version 2.1 of the License, or\n+  (at your option) any later version.\n+\n+  Cockpit is distributed in the hope that it will be useful, but\n+  WITHOUT ANY WARRANTY; without even the implied warranty of\n+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+  Lesser General Public License for more details.\n+\n+  You should have received a copy of the GNU Lesser General Public License\n+  along with Cockpit; If not, see <http://www.gnu.org/licenses/>.\n+-->\n+<html>\n+<head>\n+    <title>Locale Tests</title>\n+    <meta charset=\"utf-8\">\n+    <link rel=\"stylesheet\" href=\"../../lib/qunit-1.14.0.css\" type=\"text/css\" media=\"screen\" />\n+    <script src=\"../../lib/jquery.v2.1.0.js\"></script>\n+    <script src=\"../../lib/qunit-1.14.0.js\"></script>\n+    <script src=\"../../lib/qunit-tap.js\"></script>\n+    <script src=\"../../tools/qunit-config.js\"></script>\n+\n+    <script src=\"cockpit.js\"></script>\n+</head>\n+<body>\n+    <h1 id=\"qunit-header\">Locale Tests</h1>\n+    <h2 id=\"qunit-banner\"></h2><div id=\"qunit-testrunner-toolbar\"></div>\n+    <h2 id=\"qunit-userAgent\"></h2><ol id=\"qunit-tests\"></ol>\n+    <div id=\"qunit-fixture\">test markup, will be hidden</div>\n+    <div id=\"done-flag\" style=\"display:none\">Done</div>\n+</body>\n+<script>\n+\n+var pig_latin = {\n+    \"\": { \"language\": \"pig\", \"plural-forms\": \"nplurals=2; plural=(n != 1);\" },\n+    \"Marmalade\": [ null, \"Armalademay\" ],\n+    \"$0 bucket\": [ \"$0 buckets\", \"$0 ucketbay\", \"$0 ucketsbay\" ],\n+    \"explain\\u0004Marmalade\": [ null, \"ArmaladeMAY\" ],\n+    \"explain\\u0004$0 bucket\": [ \"explain\\u0004$0 buckets\", \"$0 ucketBAY\", \"$0 ucketsBAY\" ]\n+};\n+\n+var ru = {\n+    \"\": { \"language\": \"pig\", \"plural-forms\": \"nplurals=3; plural=(n%10==1 && n%100!=11 ? 0 : n%10>=2 && n%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2);\" },","path":"pkg/base/test-locale.html","position":50,"original_position":50,"commit_id":"04bbbe4042b55fd06b6dd342cb61e12a13d47f3d","original_commit_id":"04bbbe4042b55fd06b6dd342cb61e12a13d47f3d","user":{"login":"mvollmer","id":3228183,"avatar_url":"https://avatars.githubusercontent.com/u/3228183?v=3","gravatar_id":"","url":"https://api.github.com/users/mvollmer","html_url":"https://github.com/mvollmer","followers_url":"https://api.github.com/users/mvollmer/followers","following_url":"https://api.github.com/users/mvollmer/following{/other_user}","gists_url":"https://api.github.com/users/mvollmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mvollmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvollmer/subscriptions","organizations_url":"https://api.github.com/users/mvollmer/orgs","repos_url":"https://api.github.com/users/mvollmer/repos","events_url":"https://api.github.com/users/mvollmer/events{/privacy}","received_events_url":"https://api.github.com/users/mvollmer/received_events","type":"User","site_admin":false},"body":"language: \"ru\".","created_at":"2014-11-13T08:53:07Z","updated_at":"2014-11-13T08:53:07Z","html_url":"https://github.com/cockpit-project/cockpit/pull/1466#discussion_r20278408","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1466","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/20278408"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/1466#discussion_r20278408"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1466"}}},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1466","id":24212223,"html_url":"https://github.com/cockpit-project/cockpit/pull/1466","diff_url":"https://github.com/cockpit-project/cockpit/pull/1466.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/1466.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/1466","number":1466,"state":"open","locked":false,"title":"Localization infrastructure","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"body":"Redo our localization infrastructure so it works from pages and with AMD loading. We reload the page when the language changes. API documented, tested. Automatically detect language.\r\n\r\nLogin page not yet translated, but can be.","created_at":"2014-11-11T11:07:14Z","updated_at":"2014-11-13T08:53:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f73d7b475ab3514078aa08b51f8a215633a9ac86","assignee":null,"milestone":{"url":"https://api.github.com/repos/cockpit-project/cockpit/milestones/4","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones/4/labels","id":572654,"number":4,"title":"Modular Webapp","description":"The webapp will be loaded from multiple sources and combined in the browser.","creator":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":74,"state":"open","created_at":"2014-02-18T08:59:10Z","updated_at":"2014-11-13T08:17:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1466/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1466/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/1466/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/04bbbe4042b55fd06b6dd342cb61e12a13d47f3d","head":{"label":"stefwalter:localization","ref":"localization","sha":"04bbbe4042b55fd06b6dd342cb61e12a13d47f3d","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"repo":{"id":14296513,"name":"cockpit","full_name":"stefwalter/cockpit","owner":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefwalter/cockpit","description":"Cockpit, a user interface for Linux servers","fork":true,"url":"https://api.github.com/repos/stefwalter/cockpit","forks_url":"https://api.github.com/repos/stefwalter/cockpit/forks","keys_url":"https://api.github.com/repos/stefwalter/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefwalter/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefwalter/cockpit/teams","hooks_url":"https://api.github.com/repos/stefwalter/cockpit/hooks","issue_events_url":"https://api.github.com/repos/stefwalter/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/stefwalter/cockpit/events","assignees_url":"https://api.github.com/repos/stefwalter/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/stefwalter/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/stefwalter/cockpit/tags","blobs_url":"https://api.github.com/repos/stefwalter/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefwalter/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefwalter/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefwalter/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefwalter/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/stefwalter/cockpit/languages","stargazers_url":"https://api.github.com/repos/stefwalter/cockpit/stargazers","contributors_url":"https://api.github.com/repos/stefwalter/cockpit/contributors","subscribers_url":"https://api.github.com/repos/stefwalter/cockpit/subscribers","subscription_url":"https://api.github.com/repos/stefwalter/cockpit/subscription","commits_url":"https://api.github.com/repos/stefwalter/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefwalter/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefwalter/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefwalter/cockpit/issues/comments/{number}","contents_url":"https://api.github.com/repos/stefwalter/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/stefwalter/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefwalter/cockpit/merges","archive_url":"https://api.github.com/repos/stefwalter/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefwalter/cockpit/downloads","issues_url":"https://api.github.com/repos/stefwalter/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/stefwalter/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/stefwalter/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/stefwalter/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefwalter/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/stefwalter/cockpit/releases{/id}","created_at":"2013-11-11T09:27:50Z","updated_at":"2014-07-04T08:10:15Z","pushed_at":"2014-11-13T08:36:50Z","git_url":"git://github.com/stefwalter/cockpit.git","ssh_url":"git@github.com:stefwalter/cockpit.git","clone_url":"https://github.com/stefwalter/cockpit.git","svn_url":"https://github.com/stefwalter/cockpit","homepage":"http://www.cockpit-project.org/","size":15544,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"64c2d2808237b5c15882d1614fb893354b729d36","user":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"name":"cockpit","full_name":"cockpit-project/cockpit","owner":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockpit-project/cockpit","description":"Cockpit, a user interface for GNU/Linux servers","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments/{number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","created_at":"2013-11-01T17:36:46Z","updated_at":"2014-11-12T20:33:10Z","pushed_at":"2014-11-12T13:17:41Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":35258,"stargazers_count":787,"watchers_count":787,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":265,"forks":62,"open_issues":265,"watchers":787,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1466"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/1466"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/1466"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/1466/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1466/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1466/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/04bbbe4042b55fd06b6dd342cb61e12a13d47f3d"}}}}