GitHub PullRequestReviewCommentEvent at 2014-09-03 12:39:15
Repository: routemaster
Actor: cassiomarques
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/HouseTrip/routemaster/pulls/comments/17046172","id":17046172,"diff_hunk":"@@ -15,6 +17,23 @@\n     let(:subscriptions)  { [] }\n \n     let(:perform) { subject.run(5) }\n+    let(:app) { Routemaster::Application }\n+\n+    around do |example|\n+      @old = ENV['EXCEPTION_SERVICE']","path":"spec/services/watch_spec.rb","position":16,"original_position":16,"commit_id":"4136a3f37b55ac2e98aca3c26c096243d3a8c612","original_commit_id":"4136a3f37b55ac2e98aca3c26c096243d3a8c612","user":{"login":"cassiomarques","id":13071,"avatar_url":"https://avatars.githubusercontent.com/u/13071?v=2","gravatar_id":"e9202d96b693676af44a254915e1a48f","url":"https://api.github.com/users/cassiomarques","html_url":"https://github.com/cassiomarques","followers_url":"https://api.github.com/users/cassiomarques/followers","following_url":"https://api.github.com/users/cassiomarques/following{/other_user}","gists_url":"https://api.github.com/users/cassiomarques/gists{/gist_id}","starred_url":"https://api.github.com/users/cassiomarques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cassiomarques/subscriptions","organizations_url":"https://api.github.com/users/cassiomarques/orgs","repos_url":"https://api.github.com/users/cassiomarques/repos","events_url":"https://api.github.com/users/cassiomarques/events{/privacy}","received_events_url":"https://api.github.com/users/cassiomarques/received_events","type":"User","site_admin":false},"body":"If you're mot using `@old` inside any test, then it can be a local variable instead of an instance one.","created_at":"2014-09-03T12:39:15Z","updated_at":"2014-09-03T12:39:15Z","html_url":"https://github.com/HouseTrip/routemaster/pull/25#discussion_r17046172","pull_request_url":"https://api.github.com/repos/HouseTrip/routemaster/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/HouseTrip/routemaster/pulls/comments/17046172"},"html":{"href":"https://github.com/HouseTrip/routemaster/pull/25#discussion_r17046172"},"pull_request":{"href":"https://api.github.com/repos/HouseTrip/routemaster/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/HouseTrip/routemaster/pulls/25","id":20668514,"html_url":"https://github.com/HouseTrip/routemaster/pull/25","diff_url":"https://github.com/HouseTrip/routemaster/pull/25.diff","patch_url":"https://github.com/HouseTrip/routemaster/pull/25.patch","issue_url":"https://api.github.com/repos/HouseTrip/routemaster/issues/25","number":25,"state":"open","locked":false,"title":"Platform: Error reporting in Watch process [#75373108]","user":{"login":"marcusleemitchell","id":26367,"avatar_url":"https://avatars.githubusercontent.com/u/26367?v=2","gravatar_id":"c0afdc1c900a8f7b429f786507e19758","url":"https://api.github.com/users/marcusleemitchell","html_url":"https://github.com/marcusleemitchell","followers_url":"https://api.github.com/users/marcusleemitchell/followers","following_url":"https://api.github.com/users/marcusleemitchell/following{/other_user}","gists_url":"https://api.github.com/users/marcusleemitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusleemitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusleemitchell/subscriptions","organizations_url":"https://api.github.com/users/marcusleemitchell/orgs","repos_url":"https://api.github.com/users/marcusleemitchell/repos","events_url":"https://api.github.com/users/marcusleemitchell/events{/privacy}","received_events_url":"https://api.github.com/users/marcusleemitchell/received_events","type":"User","site_admin":false},"body":"TODO: describe your changes\r\n\r\n===\r\n\r\nPivotal tracker story [#75373108](https://www.pivotaltracker.com/story/show/75373108) in project *Platform*:\r\n\r\n> https://github.com/HouseTrip/routemaster/issues/8","created_at":"2014-09-03T10:42:01Z","updated_at":"2014-09-03T12:39:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98cb8f50f99d4e3dafbefc47cdf4ebe04c40dd32","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HouseTrip/routemaster/pulls/25/commits","review_comments_url":"https://api.github.com/repos/HouseTrip/routemaster/pulls/25/comments","review_comment_url":"https://api.github.com/repos/HouseTrip/routemaster/pulls/comments/{number}","comments_url":"https://api.github.com/repos/HouseTrip/routemaster/issues/25/comments","statuses_url":"https://api.github.com/repos/HouseTrip/routemaster/statuses/4136a3f37b55ac2e98aca3c26c096243d3a8c612","head":{"label":"HouseTrip:platform/error-reporting-in-watch-process-75373108","ref":"platform/error-reporting-in-watch-process-75373108","sha":"4136a3f37b55ac2e98aca3c26c096243d3a8c612","user":{"login":"HouseTrip","id":142723,"avatar_url":"https://avatars.githubusercontent.com/u/142723?v=2","gravatar_id":"d8db298b62716cc389471867da61ddb6","url":"https://api.github.com/users/HouseTrip","html_url":"https://github.com/HouseTrip","followers_url":"https://api.github.com/users/HouseTrip/followers","following_url":"https://api.github.com/users/HouseTrip/following{/other_user}","gists_url":"https://api.github.com/users/HouseTrip/gists{/gist_id}","starred_url":"https://api.github.com/users/HouseTrip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HouseTrip/subscriptions","organizations_url":"https://api.github.com/users/HouseTrip/orgs","repos_url":"https://api.github.com/users/HouseTrip/repos","events_url":"https://api.github.com/users/HouseTrip/events{/privacy}","received_events_url":"https://api.github.com/users/HouseTrip/received_events","type":"Organization","site_admin":false},"repo":{"id":20881361,"name":"routemaster","full_name":"HouseTrip/routemaster","owner":{"login":"HouseTrip","id":142723,"avatar_url":"https://avatars.githubusercontent.com/u/142723?v=2","gravatar_id":"d8db298b62716cc389471867da61ddb6","url":"https://api.github.com/users/HouseTrip","html_url":"https://github.com/HouseTrip","followers_url":"https://api.github.com/users/HouseTrip/followers","following_url":"https://api.github.com/users/HouseTrip/following{/other_user}","gists_url":"https://api.github.com/users/HouseTrip/gists{/gist_id}","starred_url":"https://api.github.com/users/HouseTrip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HouseTrip/subscriptions","organizations_url":"https://api.github.com/users/HouseTrip/orgs","repos_url":"https://api.github.com/users/HouseTrip/repos","events_url":"https://api.github.com/users/HouseTrip/events{/privacy}","received_events_url":"https://api.github.com/users/HouseTrip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HouseTrip/routemaster","description":"HTTP Event Bus for event-driven REST architectures","fork":false,"url":"https://api.github.com/repos/HouseTrip/routemaster","forks_url":"https://api.github.com/repos/HouseTrip/routemaster/forks","keys_url":"https://api.github.com/repos/HouseTrip/routemaster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HouseTrip/routemaster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HouseTrip/routemaster/teams","hooks_url":"https://api.github.com/repos/HouseTrip/routemaster/hooks","issue_events_url":"https://api.github.com/repos/HouseTrip/routemaster/issues/events{/number}","events_url":"https://api.github.com/repos/HouseTrip/routemaster/events","assignees_url":"https://api.github.com/repos/HouseTrip/routemaster/assignees{/user}","branches_url":"https://api.github.com/repos/HouseTrip/routemaster/branches{/branch}","tags_url":"https://api.github.com/repos/HouseTrip/routemaster/tags","blobs_url":"https://api.github.com/repos/HouseTrip/routemaster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HouseTrip/routemaster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HouseTrip/routemaster/git/refs{/sha}","trees_url":"https://api.github.com/repos/HouseTrip/routemaster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HouseTrip/routemaster/statuses/{sha}","languages_url":"https://api.github.com/repos/HouseTrip/routemaster/languages","stargazers_url":"https://api.github.com/repos/HouseTrip/routemaster/stargazers","contributors_url":"https://api.github.com/repos/HouseTrip/routemaster/contributors","subscribers_url":"https://api.github.com/repos/HouseTrip/routemaster/subscribers","subscription_url":"https://api.github.com/repos/HouseTrip/routemaster/subscription","commits_url":"https://api.github.com/repos/HouseTrip/routemaster/commits{/sha}","git_commits_url":"https://api.github.com/repos/HouseTrip/routemaster/git/commits{/sha}","comments_url":"https://api.github.com/repos/HouseTrip/routemaster/comments{/number}","issue_comment_url":"https://api.github.com/repos/HouseTrip/routemaster/issues/comments/{number}","contents_url":"https://api.github.com/repos/HouseTrip/routemaster/contents/{+path}","compare_url":"https://api.github.com/repos/HouseTrip/routemaster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HouseTrip/routemaster/merges","archive_url":"https://api.github.com/repos/HouseTrip/routemaster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HouseTrip/routemaster/downloads","issues_url":"https://api.github.com/repos/HouseTrip/routemaster/issues{/number}","pulls_url":"https://api.github.com/repos/HouseTrip/routemaster/pulls{/number}","milestones_url":"https://api.github.com/repos/HouseTrip/routemaster/milestones{/number}","notifications_url":"https://api.github.com/repos/HouseTrip/routemaster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HouseTrip/routemaster/labels{/name}","releases_url":"https://api.github.com/repos/HouseTrip/routemaster/releases{/id}","created_at":"2014-06-16T10:41:54Z","updated_at":"2014-07-20T20:12:49Z","pushed_at":"2014-09-02T10:23:08Z","git_url":"git://github.com/HouseTrip/routemaster.git","ssh_url":"git@github.com:HouseTrip/routemaster.git","clone_url":"https://github.com/HouseTrip/routemaster.git","svn_url":"https://github.com/HouseTrip/routemaster","homepage":null,"size":728,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"HouseTrip:master","ref":"master","sha":"75d27bed64cd472380673133933af4ffa0ef0cbd","user":{"login":"HouseTrip","id":142723,"avatar_url":"https://avatars.githubusercontent.com/u/142723?v=2","gravatar_id":"d8db298b62716cc389471867da61ddb6","url":"https://api.github.com/users/HouseTrip","html_url":"https://github.com/HouseTrip","followers_url":"https://api.github.com/users/HouseTrip/followers","following_url":"https://api.github.com/users/HouseTrip/following{/other_user}","gists_url":"https://api.github.com/users/HouseTrip/gists{/gist_id}","starred_url":"https://api.github.com/users/HouseTrip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HouseTrip/subscriptions","organizations_url":"https://api.github.com/users/HouseTrip/orgs","repos_url":"https://api.github.com/users/HouseTrip/repos","events_url":"https://api.github.com/users/HouseTrip/events{/privacy}","received_events_url":"https://api.github.com/users/HouseTrip/received_events","type":"Organization","site_admin":false},"repo":{"id":20881361,"name":"routemaster","full_name":"HouseTrip/routemaster","owner":{"login":"HouseTrip","id":142723,"avatar_url":"https://avatars.githubusercontent.com/u/142723?v=2","gravatar_id":"d8db298b62716cc389471867da61ddb6","url":"https://api.github.com/users/HouseTrip","html_url":"https://github.com/HouseTrip","followers_url":"https://api.github.com/users/HouseTrip/followers","following_url":"https://api.github.com/users/HouseTrip/following{/other_user}","gists_url":"https://api.github.com/users/HouseTrip/gists{/gist_id}","starred_url":"https://api.github.com/users/HouseTrip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HouseTrip/subscriptions","organizations_url":"https://api.github.com/users/HouseTrip/orgs","repos_url":"https://api.github.com/users/HouseTrip/repos","events_url":"https://api.github.com/users/HouseTrip/events{/privacy}","received_events_url":"https://api.github.com/users/HouseTrip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HouseTrip/routemaster","description":"HTTP Event Bus for event-driven REST architectures","fork":false,"url":"https://api.github.com/repos/HouseTrip/routemaster","forks_url":"https://api.github.com/repos/HouseTrip/routemaster/forks","keys_url":"https://api.github.com/repos/HouseTrip/routemaster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HouseTrip/routemaster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HouseTrip/routemaster/teams","hooks_url":"https://api.github.com/repos/HouseTrip/routemaster/hooks","issue_events_url":"https://api.github.com/repos/HouseTrip/routemaster/issues/events{/number}","events_url":"https://api.github.com/repos/HouseTrip/routemaster/events","assignees_url":"https://api.github.com/repos/HouseTrip/routemaster/assignees{/user}","branches_url":"https://api.github.com/repos/HouseTrip/routemaster/branches{/branch}","tags_url":"https://api.github.com/repos/HouseTrip/routemaster/tags","blobs_url":"https://api.github.com/repos/HouseTrip/routemaster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HouseTrip/routemaster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HouseTrip/routemaster/git/refs{/sha}","trees_url":"https://api.github.com/repos/HouseTrip/routemaster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HouseTrip/routemaster/statuses/{sha}","languages_url":"https://api.github.com/repos/HouseTrip/routemaster/languages","stargazers_url":"https://api.github.com/repos/HouseTrip/routemaster/stargazers","contributors_url":"https://api.github.com/repos/HouseTrip/routemaster/contributors","subscribers_url":"https://api.github.com/repos/HouseTrip/routemaster/subscribers","subscription_url":"https://api.github.com/repos/HouseTrip/routemaster/subscription","commits_url":"https://api.github.com/repos/HouseTrip/routemaster/commits{/sha}","git_commits_url":"https://api.github.com/repos/HouseTrip/routemaster/git/commits{/sha}","comments_url":"https://api.github.com/repos/HouseTrip/routemaster/comments{/number}","issue_comment_url":"https://api.github.com/repos/HouseTrip/routemaster/issues/comments/{number}","contents_url":"https://api.github.com/repos/HouseTrip/routemaster/contents/{+path}","compare_url":"https://api.github.com/repos/HouseTrip/routemaster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HouseTrip/routemaster/merges","archive_url":"https://api.github.com/repos/HouseTrip/routemaster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HouseTrip/routemaster/downloads","issues_url":"https://api.github.com/repos/HouseTrip/routemaster/issues{/number}","pulls_url":"https://api.github.com/repos/HouseTrip/routemaster/pulls{/number}","milestones_url":"https://api.github.com/repos/HouseTrip/routemaster/milestones{/number}","notifications_url":"https://api.github.com/repos/HouseTrip/routemaster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HouseTrip/routemaster/labels{/name}","releases_url":"https://api.github.com/repos/HouseTrip/routemaster/releases{/id}","created_at":"2014-06-16T10:41:54Z","updated_at":"2014-07-20T20:12:49Z","pushed_at":"2014-09-02T10:23:08Z","git_url":"git://github.com/HouseTrip/routemaster.git","ssh_url":"git@github.com:HouseTrip/routemaster.git","clone_url":"https://github.com/HouseTrip/routemaster.git","svn_url":"https://github.com/HouseTrip/routemaster","homepage":null,"size":728,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HouseTrip/routemaster/pulls/25"},"html":{"href":"https://github.com/HouseTrip/routemaster/pull/25"},"issue":{"href":"https://api.github.com/repos/HouseTrip/routemaster/issues/25"},"comments":{"href":"https://api.github.com/repos/HouseTrip/routemaster/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/HouseTrip/routemaster/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/HouseTrip/routemaster/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/HouseTrip/routemaster/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/HouseTrip/routemaster/statuses/4136a3f37b55ac2e98aca3c26c096243d3a8c612"}}}}