GitHub PullRequestReviewCommentEvent at 2014-08-28 07:59:06
Repository: core
Actor: LukasReschke
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/16825609","id":16825609,"diff_hunk":"@@ -12,7 +12,7 @@\n \t\t</title>\n \t\t<meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" />\n \t\t<meta name=\"viewport\" content=\"width=device-width, minimum-scale=1.0, maximum-scale=1.0\">\n-\t\t<meta name=\"apple-itunes-app\" content=\"app-id=543672169\">\n+\t\t<meta name=\"apple-itunes-app\" content=\"app-id=<?php print_unescaped($theme->getiTunesAppId()); ?>\">","path":"core/templates/layout.guest.php","position":5,"original_position":5,"commit_id":"49da0a794317042e8598b0735119854950444a7f","original_commit_id":"49da0a794317042e8598b0735119854950444a7f","user":{"login":"LukasReschke","id":878997,"avatar_url":"https://avatars.githubusercontent.com/u/878997?v=2","gravatar_id":"f080e75d370a4d8e550983a4898bcf3b","url":"https://api.github.com/users/LukasReschke","html_url":"https://github.com/LukasReschke","followers_url":"https://api.github.com/users/LukasReschke/followers","following_url":"https://api.github.com/users/LukasReschke/following{/other_user}","gists_url":"https://api.github.com/users/LukasReschke/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasReschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasReschke/subscriptions","organizations_url":"https://api.github.com/users/LukasReschke/orgs","repos_url":"https://api.github.com/users/LukasReschke/repos","events_url":"https://api.github.com/users/LukasReschke/events{/privacy}","received_events_url":"https://api.github.com/users/LukasReschke/received_events","type":"User","site_admin":false},"body":"The other ones might contain values that we don't want to encode. Yours is numeric only and therefore safe to use `p` for.","created_at":"2014-08-28T07:59:06Z","updated_at":"2014-08-28T07:59:06Z","html_url":"https://github.com/owncloud/core/pull/10667#discussion_r16825609","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/10667","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/16825609"},"html":{"href":"https://github.com/owncloud/core/pull/10667#discussion_r16825609"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/10667"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/10667","id":20369404,"html_url":"https://github.com/owncloud/core/pull/10667","diff_url":"https://github.com/owncloud/core/pull/10667.diff","patch_url":"https://github.com/owncloud/core/pull/10667.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/10667","number":10667,"state":"open","locked":false,"title":"defaults: add customizable defaultiTunesAppId","user":{"login":"pmjdebruijn","id":929583,"avatar_url":"https://avatars.githubusercontent.com/u/929583?v=2","gravatar_id":"4ca07172db21def7b70425f716a661f3","url":"https://api.github.com/users/pmjdebruijn","html_url":"https://github.com/pmjdebruijn","followers_url":"https://api.github.com/users/pmjdebruijn/followers","following_url":"https://api.github.com/users/pmjdebruijn/following{/other_user}","gists_url":"https://api.github.com/users/pmjdebruijn/gists{/gist_id}","starred_url":"https://api.github.com/users/pmjdebruijn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmjdebruijn/subscriptions","organizations_url":"https://api.github.com/users/pmjdebruijn/orgs","repos_url":"https://api.github.com/users/pmjdebruijn/repos","events_url":"https://api.github.com/users/pmjdebruijn/events{/privacy}","received_events_url":"https://api.github.com/users/pmjdebruijn/received_events","type":"User","site_admin":false},"body":"App URLs are already theme customizable however the itunes html meta app-id isn't yet.\r\n\r\nPlease review thoroughly before merging.","created_at":"2014-08-27T12:16:50Z","updated_at":"2014-08-28T07:59:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e132554a6f6bf390c2284aa0fa06ab13f1b2b8e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/core/pulls/10667/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/10667/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/10667/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/49da0a794317042e8598b0735119854950444a7f","head":{"label":"pmjdebruijn:itunes-appid","ref":"itunes-appid","sha":"49da0a794317042e8598b0735119854950444a7f","user":{"login":"pmjdebruijn","id":929583,"avatar_url":"https://avatars.githubusercontent.com/u/929583?v=2","gravatar_id":"4ca07172db21def7b70425f716a661f3","url":"https://api.github.com/users/pmjdebruijn","html_url":"https://github.com/pmjdebruijn","followers_url":"https://api.github.com/users/pmjdebruijn/followers","following_url":"https://api.github.com/users/pmjdebruijn/following{/other_user}","gists_url":"https://api.github.com/users/pmjdebruijn/gists{/gist_id}","starred_url":"https://api.github.com/users/pmjdebruijn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmjdebruijn/subscriptions","organizations_url":"https://api.github.com/users/pmjdebruijn/orgs","repos_url":"https://api.github.com/users/pmjdebruijn/repos","events_url":"https://api.github.com/users/pmjdebruijn/events{/privacy}","received_events_url":"https://api.github.com/users/pmjdebruijn/received_events","type":"User","site_admin":false},"repo":{"id":23387759,"name":"core","full_name":"pmjdebruijn/core","owner":{"login":"pmjdebruijn","id":929583,"avatar_url":"https://avatars.githubusercontent.com/u/929583?v=2","gravatar_id":"4ca07172db21def7b70425f716a661f3","url":"https://api.github.com/users/pmjdebruijn","html_url":"https://github.com/pmjdebruijn","followers_url":"https://api.github.com/users/pmjdebruijn/followers","following_url":"https://api.github.com/users/pmjdebruijn/following{/other_user}","gists_url":"https://api.github.com/users/pmjdebruijn/gists{/gist_id}","starred_url":"https://api.github.com/users/pmjdebruijn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmjdebruijn/subscriptions","organizations_url":"https://api.github.com/users/pmjdebruijn/orgs","repos_url":"https://api.github.com/users/pmjdebruijn/repos","events_url":"https://api.github.com/users/pmjdebruijn/events{/privacy}","received_events_url":"https://api.github.com/users/pmjdebruijn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmjdebruijn/core","description":"The ownCloud core","fork":true,"url":"https://api.github.com/repos/pmjdebruijn/core","forks_url":"https://api.github.com/repos/pmjdebruijn/core/forks","keys_url":"https://api.github.com/repos/pmjdebruijn/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmjdebruijn/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmjdebruijn/core/teams","hooks_url":"https://api.github.com/repos/pmjdebruijn/core/hooks","issue_events_url":"https://api.github.com/repos/pmjdebruijn/core/issues/events{/number}","events_url":"https://api.github.com/repos/pmjdebruijn/core/events","assignees_url":"https://api.github.com/repos/pmjdebruijn/core/assignees{/user}","branches_url":"https://api.github.com/repos/pmjdebruijn/core/branches{/branch}","tags_url":"https://api.github.com/repos/pmjdebruijn/core/tags","blobs_url":"https://api.github.com/repos/pmjdebruijn/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmjdebruijn/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmjdebruijn/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmjdebruijn/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmjdebruijn/core/statuses/{sha}","languages_url":"https://api.github.com/repos/pmjdebruijn/core/languages","stargazers_url":"https://api.github.com/repos/pmjdebruijn/core/stargazers","contributors_url":"https://api.github.com/repos/pmjdebruijn/core/contributors","subscribers_url":"https://api.github.com/repos/pmjdebruijn/core/subscribers","subscription_url":"https://api.github.com/repos/pmjdebruijn/core/subscription","commits_url":"https://api.github.com/repos/pmjdebruijn/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmjdebruijn/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmjdebruijn/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmjdebruijn/core/issues/comments/{number}","contents_url":"https://api.github.com/repos/pmjdebruijn/core/contents/{+path}","compare_url":"https://api.github.com/repos/pmjdebruijn/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmjdebruijn/core/merges","archive_url":"https://api.github.com/repos/pmjdebruijn/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmjdebruijn/core/downloads","issues_url":"https://api.github.com/repos/pmjdebruijn/core/issues{/number}","pulls_url":"https://api.github.com/repos/pmjdebruijn/core/pulls{/number}","milestones_url":"https://api.github.com/repos/pmjdebruijn/core/milestones{/number}","notifications_url":"https://api.github.com/repos/pmjdebruijn/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmjdebruijn/core/labels{/name}","releases_url":"https://api.github.com/repos/pmjdebruijn/core/releases{/id}","created_at":"2014-08-27T11:50:27Z","updated_at":"2014-08-27T10:01:24Z","pushed_at":"2014-08-27T12:07:51Z","git_url":"git://github.com/pmjdebruijn/core.git","ssh_url":"git@github.com:pmjdebruijn/core.git","clone_url":"https://github.com/pmjdebruijn/core.git","svn_url":"https://github.com/pmjdebruijn/core","homepage":null,"size":148694,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"c35d60f6d80dbb244b6223de3fdb894b0ef34d34","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=2","gravatar_id":"021e207e86fe81a7d81c67ef1ff38a0c","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=2","gravatar_id":"021e207e86fe81a7d81c67ef1ff38a0c","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments/{number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2014-08-27T19:57:11Z","pushed_at":"2014-08-28T07:37:40Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":null,"size":672316,"stargazers_count":2489,"watchers_count":2489,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":825,"mirror_url":null,"open_issues_count":1258,"forks":825,"open_issues":1258,"watchers":2489,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/10667"},"html":{"href":"https://github.com/owncloud/core/pull/10667"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/10667"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/10667/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/10667/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/10667/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/49da0a794317042e8598b0735119854950444a7f"}}}}