GitHub PullRequestReviewCommentEvent at 2014-08-29 16:27:49
Repository: diaspora
Actor: svbergerem
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/16906929","id":16906929,"diff_hunk":"@@ -27,6 +27,14 @@ def index\n     @ordered_participants = {}\n     @conversations.each { |c| @ordered_participants[c.id] = (c.messages.map{|m| m.author}.reverse + c.participants).uniq }\n \n+    all_contacts_and_ids = Contact.connection.select_rows(\n+      Contact.connection.unprepared_statement {\n+        current_user.contacts.where(:sharing => true).joins(:person => :profile).\n+          select(\"contacts.id, profiles.first_name, profiles.last_name, people.diaspora_handle\").to_sql\n+      }\n+    ).map{|r| {:value => r[0], :name => Person.name_from_attrs(r[1], r[2], r[3]).gsub(/(\")/, \"'\")} }\n+    @contacts_json = all_contacts_and_ids.to_json","path":"app/controllers/conversations_controller.rb","position":10,"original_position":10,"commit_id":"024358611e22ee052e301b9948f1e61ab044c803","original_commit_id":"024358611e22ee052e301b9948f1e61ab044c803","user":{"login":"svbergerem","id":3798614,"avatar_url":"https://avatars.githubusercontent.com/u/3798614?v=2","gravatar_id":"0a7a8e89c6cb44581168a132e95e5a58","url":"https://api.github.com/users/svbergerem","html_url":"https://github.com/svbergerem","followers_url":"https://api.github.com/users/svbergerem/followers","following_url":"https://api.github.com/users/svbergerem/following{/other_user}","gists_url":"https://api.github.com/users/svbergerem/gists{/gist_id}","starred_url":"https://api.github.com/users/svbergerem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svbergerem/subscriptions","organizations_url":"https://api.github.com/users/svbergerem/orgs","repos_url":"https://api.github.com/users/svbergerem/repos","events_url":"https://api.github.com/users/svbergerem/events{/privacy}","received_events_url":"https://api.github.com/users/svbergerem/received_events","type":"User","site_admin":false},"body":"I just copied that code from conversations/new. I'll see if your version works too and change it in both places.","created_at":"2014-08-29T16:27:49Z","updated_at":"2014-08-29T16:27:49Z","html_url":"https://github.com/diaspora/diaspora/pull/5178#discussion_r16906929","pull_request_url":"https://api.github.com/repos/diaspora/diaspora/pulls/5178","_links":{"self":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/16906929"},"html":{"href":"https://github.com/diaspora/diaspora/pull/5178#discussion_r16906929"},"pull_request":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/5178"}}},"pull_request":{"url":"https://api.github.com/repos/diaspora/diaspora/pulls/5178","id":20496988,"html_url":"https://github.com/diaspora/diaspora/pull/5178","diff_url":"https://github.com/diaspora/diaspora/pull/5178.diff","patch_url":"https://github.com/diaspora/diaspora/pull/5178.patch","issue_url":"https://api.github.com/repos/diaspora/diaspora/issues/5178","number":5178,"state":"open","locked":false,"title":"[WIP] Display new conversation form on conversations/index","user":{"login":"svbergerem","id":3798614,"avatar_url":"https://avatars.githubusercontent.com/u/3798614?v=2","gravatar_id":"0a7a8e89c6cb44581168a132e95e5a58","url":"https://api.github.com/users/svbergerem","html_url":"https://github.com/svbergerem","followers_url":"https://api.github.com/users/svbergerem/followers","following_url":"https://api.github.com/users/svbergerem/following{/other_user}","gists_url":"https://api.github.com/users/svbergerem/gists{/gist_id}","starred_url":"https://api.github.com/users/svbergerem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svbergerem/subscriptions","organizations_url":"https://api.github.com/users/svbergerem/orgs","repos_url":"https://api.github.com/users/svbergerem/repos","events_url":"https://api.github.com/users/svbergerem/events{/privacy}","received_events_url":"https://api.github.com/users/svbergerem/received_events","type":"User","site_admin":false},"body":"Fixes #4114, might also fix #5177. Should be already fully functional. Needs some style fixes and some new/adapted tests.\r\n\r\n![](https://cloud.githubusercontent.com/assets/3798614/4090139/350e44f8-2f79-11e4-9753-8fa231dca851.png)","created_at":"2014-08-29T12:40:46Z","updated_at":"2014-08-29T16:27:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d487c7074dc4c3dc373cc710d50fd66942e66327","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/diaspora/diaspora/pulls/5178/commits","review_comments_url":"https://api.github.com/repos/diaspora/diaspora/pulls/5178/comments","review_comment_url":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/{number}","comments_url":"https://api.github.com/repos/diaspora/diaspora/issues/5178/comments","statuses_url":"https://api.github.com/repos/diaspora/diaspora/statuses/024358611e22ee052e301b9948f1e61ab044c803","head":{"label":"svbergerem:new-conversations","ref":"new-conversations","sha":"024358611e22ee052e301b9948f1e61ab044c803","user":{"login":"svbergerem","id":3798614,"avatar_url":"https://avatars.githubusercontent.com/u/3798614?v=2","gravatar_id":"0a7a8e89c6cb44581168a132e95e5a58","url":"https://api.github.com/users/svbergerem","html_url":"https://github.com/svbergerem","followers_url":"https://api.github.com/users/svbergerem/followers","following_url":"https://api.github.com/users/svbergerem/following{/other_user}","gists_url":"https://api.github.com/users/svbergerem/gists{/gist_id}","starred_url":"https://api.github.com/users/svbergerem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svbergerem/subscriptions","organizations_url":"https://api.github.com/users/svbergerem/orgs","repos_url":"https://api.github.com/users/svbergerem/repos","events_url":"https://api.github.com/users/svbergerem/events{/privacy}","received_events_url":"https://api.github.com/users/svbergerem/received_events","type":"User","site_admin":false},"repo":{"id":8634427,"name":"diaspora","full_name":"svbergerem/diaspora","owner":{"login":"svbergerem","id":3798614,"avatar_url":"https://avatars.githubusercontent.com/u/3798614?v=2","gravatar_id":"0a7a8e89c6cb44581168a132e95e5a58","url":"https://api.github.com/users/svbergerem","html_url":"https://github.com/svbergerem","followers_url":"https://api.github.com/users/svbergerem/followers","following_url":"https://api.github.com/users/svbergerem/following{/other_user}","gists_url":"https://api.github.com/users/svbergerem/gists{/gist_id}","starred_url":"https://api.github.com/users/svbergerem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svbergerem/subscriptions","organizations_url":"https://api.github.com/users/svbergerem/orgs","repos_url":"https://api.github.com/users/svbergerem/repos","events_url":"https://api.github.com/users/svbergerem/events{/privacy}","received_events_url":"https://api.github.com/users/svbergerem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/svbergerem/diaspora","description":"Distributed and contextual social networking","fork":true,"url":"https://api.github.com/repos/svbergerem/diaspora","forks_url":"https://api.github.com/repos/svbergerem/diaspora/forks","keys_url":"https://api.github.com/repos/svbergerem/diaspora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svbergerem/diaspora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svbergerem/diaspora/teams","hooks_url":"https://api.github.com/repos/svbergerem/diaspora/hooks","issue_events_url":"https://api.github.com/repos/svbergerem/diaspora/issues/events{/number}","events_url":"https://api.github.com/repos/svbergerem/diaspora/events","assignees_url":"https://api.github.com/repos/svbergerem/diaspora/assignees{/user}","branches_url":"https://api.github.com/repos/svbergerem/diaspora/branches{/branch}","tags_url":"https://api.github.com/repos/svbergerem/diaspora/tags","blobs_url":"https://api.github.com/repos/svbergerem/diaspora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svbergerem/diaspora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svbergerem/diaspora/git/refs{/sha}","trees_url":"https://api.github.com/repos/svbergerem/diaspora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svbergerem/diaspora/statuses/{sha}","languages_url":"https://api.github.com/repos/svbergerem/diaspora/languages","stargazers_url":"https://api.github.com/repos/svbergerem/diaspora/stargazers","contributors_url":"https://api.github.com/repos/svbergerem/diaspora/contributors","subscribers_url":"https://api.github.com/repos/svbergerem/diaspora/subscribers","subscription_url":"https://api.github.com/repos/svbergerem/diaspora/subscription","commits_url":"https://api.github.com/repos/svbergerem/diaspora/commits{/sha}","git_commits_url":"https://api.github.com/repos/svbergerem/diaspora/git/commits{/sha}","comments_url":"https://api.github.com/repos/svbergerem/diaspora/comments{/number}","issue_comment_url":"https://api.github.com/repos/svbergerem/diaspora/issues/comments/{number}","contents_url":"https://api.github.com/repos/svbergerem/diaspora/contents/{+path}","compare_url":"https://api.github.com/repos/svbergerem/diaspora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svbergerem/diaspora/merges","archive_url":"https://api.github.com/repos/svbergerem/diaspora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svbergerem/diaspora/downloads","issues_url":"https://api.github.com/repos/svbergerem/diaspora/issues{/number}","pulls_url":"https://api.github.com/repos/svbergerem/diaspora/pulls{/number}","milestones_url":"https://api.github.com/repos/svbergerem/diaspora/milestones{/number}","notifications_url":"https://api.github.com/repos/svbergerem/diaspora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svbergerem/diaspora/labels{/name}","releases_url":"https://api.github.com/repos/svbergerem/diaspora/releases{/id}","created_at":"2013-03-07T19:05:26Z","updated_at":"2014-08-10T21:23:03Z","pushed_at":"2014-08-29T16:25:34Z","git_url":"git://github.com/svbergerem/diaspora.git","ssh_url":"git@github.com:svbergerem/diaspora.git","clone_url":"https://github.com/svbergerem/diaspora.git","svn_url":"https://github.com/svbergerem/diaspora","homepage":"http://diaspora.github.com/diaspora","size":166065,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"diaspora:develop","ref":"develop","sha":"79e1a9aafd9da995ae85d1fbfeddfd7a02aea08f","user":{"login":"diaspora","id":293207,"avatar_url":"https://avatars.githubusercontent.com/u/293207?v=2","gravatar_id":"ec6ad75082d8e2567258f6f8bc43fcd9","url":"https://api.github.com/users/diaspora","html_url":"https://github.com/diaspora","followers_url":"https://api.github.com/users/diaspora/followers","following_url":"https://api.github.com/users/diaspora/following{/other_user}","gists_url":"https://api.github.com/users/diaspora/gists{/gist_id}","starred_url":"https://api.github.com/users/diaspora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diaspora/subscriptions","organizations_url":"https://api.github.com/users/diaspora/orgs","repos_url":"https://api.github.com/users/diaspora/repos","events_url":"https://api.github.com/users/diaspora/events{/privacy}","received_events_url":"https://api.github.com/users/diaspora/received_events","type":"Organization","site_admin":false},"repo":{"id":911765,"name":"diaspora","full_name":"diaspora/diaspora","owner":{"login":"diaspora","id":293207,"avatar_url":"https://avatars.githubusercontent.com/u/293207?v=2","gravatar_id":"ec6ad75082d8e2567258f6f8bc43fcd9","url":"https://api.github.com/users/diaspora","html_url":"https://github.com/diaspora","followers_url":"https://api.github.com/users/diaspora/followers","following_url":"https://api.github.com/users/diaspora/following{/other_user}","gists_url":"https://api.github.com/users/diaspora/gists{/gist_id}","starred_url":"https://api.github.com/users/diaspora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diaspora/subscriptions","organizations_url":"https://api.github.com/users/diaspora/orgs","repos_url":"https://api.github.com/users/diaspora/repos","events_url":"https://api.github.com/users/diaspora/events{/privacy}","received_events_url":"https://api.github.com/users/diaspora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diaspora/diaspora","description":"Distributed and contextual social networking","fork":false,"url":"https://api.github.com/repos/diaspora/diaspora","forks_url":"https://api.github.com/repos/diaspora/diaspora/forks","keys_url":"https://api.github.com/repos/diaspora/diaspora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diaspora/diaspora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diaspora/diaspora/teams","hooks_url":"https://api.github.com/repos/diaspora/diaspora/hooks","issue_events_url":"https://api.github.com/repos/diaspora/diaspora/issues/events{/number}","events_url":"https://api.github.com/repos/diaspora/diaspora/events","assignees_url":"https://api.github.com/repos/diaspora/diaspora/assignees{/user}","branches_url":"https://api.github.com/repos/diaspora/diaspora/branches{/branch}","tags_url":"https://api.github.com/repos/diaspora/diaspora/tags","blobs_url":"https://api.github.com/repos/diaspora/diaspora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diaspora/diaspora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diaspora/diaspora/git/refs{/sha}","trees_url":"https://api.github.com/repos/diaspora/diaspora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diaspora/diaspora/statuses/{sha}","languages_url":"https://api.github.com/repos/diaspora/diaspora/languages","stargazers_url":"https://api.github.com/repos/diaspora/diaspora/stargazers","contributors_url":"https://api.github.com/repos/diaspora/diaspora/contributors","subscribers_url":"https://api.github.com/repos/diaspora/diaspora/subscribers","subscription_url":"https://api.github.com/repos/diaspora/diaspora/subscription","commits_url":"https://api.github.com/repos/diaspora/diaspora/commits{/sha}","git_commits_url":"https://api.github.com/repos/diaspora/diaspora/git/commits{/sha}","comments_url":"https://api.github.com/repos/diaspora/diaspora/comments{/number}","issue_comment_url":"https://api.github.com/repos/diaspora/diaspora/issues/comments/{number}","contents_url":"https://api.github.com/repos/diaspora/diaspora/contents/{+path}","compare_url":"https://api.github.com/repos/diaspora/diaspora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diaspora/diaspora/merges","archive_url":"https://api.github.com/repos/diaspora/diaspora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diaspora/diaspora/downloads","issues_url":"https://api.github.com/repos/diaspora/diaspora/issues{/number}","pulls_url":"https://api.github.com/repos/diaspora/diaspora/pulls{/number}","milestones_url":"https://api.github.com/repos/diaspora/diaspora/milestones{/number}","notifications_url":"https://api.github.com/repos/diaspora/diaspora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diaspora/diaspora/labels{/name}","releases_url":"https://api.github.com/repos/diaspora/diaspora/releases{/id}","created_at":"2010-09-15T05:20:04Z","updated_at":"2014-08-29T15:57:49Z","pushed_at":"2014-08-29T15:42:41Z","git_url":"git://github.com/diaspora/diaspora.git","ssh_url":"git@github.com:diaspora/diaspora.git","clone_url":"https://github.com/diaspora/diaspora.git","svn_url":"https://github.com/diaspora/diaspora","homepage":"https://diasporafoundation.org/","size":313809,"stargazers_count":9368,"watchers_count":9368,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2376,"mirror_url":null,"open_issues_count":352,"forks":2376,"open_issues":352,"watchers":9368,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/5178"},"html":{"href":"https://github.com/diaspora/diaspora/pull/5178"},"issue":{"href":"https://api.github.com/repos/diaspora/diaspora/issues/5178"},"comments":{"href":"https://api.github.com/repos/diaspora/diaspora/issues/5178/comments"},"review_comments":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/5178/comments"},"review_comment":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/5178/commits"},"statuses":{"href":"https://api.github.com/repos/diaspora/diaspora/statuses/024358611e22ee052e301b9948f1e61ab044c803"}}}}