GitHub PullRequestReviewCommentEvent at 2014-11-06 18:31:18
Repository: fxa-oauth-client
Actor: seanmonstar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls/comments/19963757","id":19963757,"diff_hunk":"@@ -0,0 +1,103 @@\n+#!/usr/bin/env node\n+\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed with this\n+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */\n+\n+const onError = require('../lib/error').onError;\n+const Client = require('../');\n+const log = require('npmlog');\n+\n+process.on('uncaughtException', onError);\n+log.pause();\n+log.heading = 'fxa';\n+\n+var program = require('commander');\n+\n+const ENVS = ['prod', 'stage', 'stable', 'nightly', 'latest'];\n+const URLS = {\n+  'prod': [\n+    'https://oauth.accounts.firefox.com',\n+    'https://api.accounts.firefox.com'\n+  ],\n+  'stage': [\n+    'https://oauth.stage.mozaws.net',\n+    'https://api-accounts.stage.mozaws.net'\n+  ],\n+  'stable': [\n+    'https://oauth-stable.dev.lcip.org',\n+    'https://stable.dev.lcip.org/auth'\n+  ],\n+  'nightly': [\n+    'https://oauth-nightly.dev.lcip.org',\n+    'https://nightly.dev.lcip.org/auth'\n+  ],\n+  'latest': [\n+    'https://oauth-latest.dev.lcip.org',\n+    'https://latest.dev.lcip.org/auth'\n+  ]\n+};\n+\n+program\n+  .version(require('../package.json').version)\n+  .option(\n+    '-e, --env <env>',\n+    'Target a server environment: [' + ENVS.join(', ') + ']. Default: stable',\n+    function(env) {\n+      program.url = URLS[env][0];\n+      program.fxa = URLS[env][1];\n+    },\n+    'stable'\n+  )\n+  .option(\n+    '-u, --user <email>',\n+    'Env: FXA_USER',\n+    process.env.FXA_USER\n+  )\n+  .option(\n+    '-p, --password <password>',\n+    'Env: FXA_PASSWORD',\n+    process.env.FXA_PASSWORD","path":"bin/fxa-oauth.js","position":60,"original_position":60,"commit_id":"bd3816e7199dac10b55618f5da170db5836b9387","original_commit_id":"bd3816e7199dac10b55618f5da170db5836b9387","user":{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?v=2","gravatar_id":"","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"body":"I agree. I was logging `process.argv`, and noticed that it'd be quite impossible to make sure I cleaned out the password before dumping to the debug log. I'd hate for someone to submit that with their password inside...","created_at":"2014-11-06T18:31:18Z","updated_at":"2014-11-06T18:31:18Z","html_url":"https://github.com/mozilla/fxa-oauth-client/pull/1#discussion_r19963757","pull_request_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls/comments/19963757"},"html":{"href":"https://github.com/mozilla/fxa-oauth-client/pull/1#discussion_r19963757"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls/1","id":23925554,"html_url":"https://github.com/mozilla/fxa-oauth-client/pull/1","diff_url":"https://github.com/mozilla/fxa-oauth-client/pull/1.diff","patch_url":"https://github.com/mozilla/fxa-oauth-client/pull/1.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/issues/1","number":1,"state":"open","locked":false,"title":"feat(token): add first command: token","user":{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?v=2","gravatar_id":"","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"body":"Besides the token command, this includes much of the underlying\r\ndesign that all commands will build off of.","created_at":"2014-11-05T18:10:54Z","updated_at":"2014-11-06T18:31:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45ffb7acba3570a3ef07242241384c54ee6c0b70","assignee":{"login":"rfk","id":34695,"avatar_url":"https://avatars.githubusercontent.com/u/34695?v=2","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/issues/1/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/statuses/bd3816e7199dac10b55618f5da170db5836b9387","head":{"label":"mozilla:get-token","ref":"get-token","sha":"bd3816e7199dac10b55618f5da170db5836b9387","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":24154030,"name":"fxa-oauth-client","full_name":"mozilla/fxa-oauth-client","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-oauth-client","description":"","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-oauth-client","forks_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/releases{/id}","created_at":"2014-09-17T17:00:52Z","updated_at":"2014-09-22T18:36:25Z","pushed_at":"2014-11-05T18:10:43Z","git_url":"git://github.com/mozilla/fxa-oauth-client.git","ssh_url":"git@github.com:mozilla/fxa-oauth-client.git","clone_url":"https://github.com/mozilla/fxa-oauth-client.git","svn_url":"https://github.com/mozilla/fxa-oauth-client","homepage":null,"size":128,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"26bc05f49f415f978c10c9d5e8464580746b5e39","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":24154030,"name":"fxa-oauth-client","full_name":"mozilla/fxa-oauth-client","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-oauth-client","description":"","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-oauth-client","forks_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-oauth-client/releases{/id}","created_at":"2014-09-17T17:00:52Z","updated_at":"2014-09-22T18:36:25Z","pushed_at":"2014-11-05T18:10:43Z","git_url":"git://github.com/mozilla/fxa-oauth-client.git","ssh_url":"git@github.com:mozilla/fxa-oauth-client.git","clone_url":"https://github.com/mozilla/fxa-oauth-client.git","svn_url":"https://github.com/mozilla/fxa-oauth-client","homepage":null,"size":128,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls/1"},"html":{"href":"https://github.com/mozilla/fxa-oauth-client/pull/1"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-client/issues/1"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-client/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-client/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-oauth-client/statuses/bd3816e7199dac10b55618f5da170db5836b9387"}}}}