GitHub PullRequestReviewCommentEvent at 2014-10-23 09:23:54
Repository: simple_blog
Actor: mixandgo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mixandgo/simple_blog/pulls/comments/19266803","id":19266803,"diff_hunk":"@@ -18,16 +16,24 @@ var KeywordParser = (function () {\n     }\n   };\n \n-  var keywordIsBlacklisted = function(keyword) {\n-    // skip if keyword is shorter than 2 characters\n-    // and skip if word is in blackListKeywords\"\n-    return (keyword.length <= 2) || (blackListKeywords.indexOf(keyword.toLowerCase()) != -1)\n-  };\n+  var lowerCaseList = function(word) {","path":"app/assets/javascripts/simple_blog_admin/popular_keywords.js","position":null,"original_position":18,"commit_id":"2643a53dc832da73ebf6806066823a2a7b148713","original_commit_id":"8f86fa5a56a1c9b4d662b660c396b6aad7c7afc9","user":{"login":"mixandgo","id":8421,"avatar_url":"https://avatars.githubusercontent.com/u/8421?v=2","gravatar_id":"","url":"https://api.github.com/users/mixandgo","html_url":"https://github.com/mixandgo","followers_url":"https://api.github.com/users/mixandgo/followers","following_url":"https://api.github.com/users/mixandgo/following{/other_user}","gists_url":"https://api.github.com/users/mixandgo/gists{/gist_id}","starred_url":"https://api.github.com/users/mixandgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixandgo/subscriptions","organizations_url":"https://api.github.com/users/mixandgo/orgs","repos_url":"https://api.github.com/users/mixandgo/repos","events_url":"https://api.github.com/users/mixandgo/events{/privacy}","received_events_url":"https://api.github.com/users/mixandgo/received_events","type":"User","site_admin":false},"body":"That's not the point. What I mean is that the function ia already built into javascript, you don't need to re-define a second function that does the exact same thing.\r\n\r\n> On 23 Oct 2014, at 12:06, Marcu Alexandru <notifications@github.com> wrote:\r\n> \r\n> In app/assets/javascripts/simple_blog_admin/popular_keywords.js:\r\n> \r\n> > @@ -18,16 +16,24 @@ var KeywordParser = (function () {\r\n> >      }\r\n> >    };\r\n> >  \r\n> > -  var keywordIsBlacklisted = function(keyword) {\r\n> > -    // skip if keyword is shorter than 2 characters\r\n> > -    // and skip if word is in blackListKeywords\"\r\n> > -    return (keyword.length <= 2) || (blackListKeywords.indexOf(keyword.toLowerCase()) != -1)\r\n> > -  };\r\n> > +  var lowerCaseList = function(word) {\r\n> i think it's important to lowercase everything so that we don't count words differently just because one is titleize and the other one isn't.\r\n> \r\n> maybe rename it lowerCaseWord\r\n> \r\n> —\r\n> Reply to this email directly or view it on GitHub.","created_at":"2014-10-23T09:23:54Z","updated_at":"2014-10-23T09:23:54Z","html_url":"https://github.com/mixandgo/simple_blog/pull/42#discussion_r19266803","pull_request_url":"https://api.github.com/repos/mixandgo/simple_blog/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/mixandgo/simple_blog/pulls/comments/19266803"},"html":{"href":"https://github.com/mixandgo/simple_blog/pull/42#discussion_r19266803"},"pull_request":{"href":"https://api.github.com/repos/mixandgo/simple_blog/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/mixandgo/simple_blog/pulls/42","id":23148710,"html_url":"https://github.com/mixandgo/simple_blog/pull/42","diff_url":"https://github.com/mixandgo/simple_blog/pull/42.diff","patch_url":"https://github.com/mixandgo/simple_blog/pull/42.patch","issue_url":"https://api.github.com/repos/mixandgo/simple_blog/issues/42","number":42,"state":"open","locked":false,"title":"Feature/fix keyword parser r0","user":{"login":"xskander","id":686964,"avatar_url":"https://avatars.githubusercontent.com/u/686964?v=2","gravatar_id":"","url":"https://api.github.com/users/xskander","html_url":"https://github.com/xskander","followers_url":"https://api.github.com/users/xskander/followers","following_url":"https://api.github.com/users/xskander/following{/other_user}","gists_url":"https://api.github.com/users/xskander/gists{/gist_id}","starred_url":"https://api.github.com/users/xskander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xskander/subscriptions","organizations_url":"https://api.github.com/users/xskander/orgs","repos_url":"https://api.github.com/users/xskander/repos","events_url":"https://api.github.com/users/xskander/events{/privacy}","received_events_url":"https://api.github.com/users/xskander/received_events","type":"User","site_admin":false},"body":"add back keyword parser","created_at":"2014-10-22T10:47:45Z","updated_at":"2014-10-23T09:23:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a75bcbb3e42225ad1682edffcdf66df0579e8643","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixandgo/simple_blog/pulls/42/commits","review_comments_url":"https://api.github.com/repos/mixandgo/simple_blog/pulls/42/comments","review_comment_url":"https://api.github.com/repos/mixandgo/simple_blog/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mixandgo/simple_blog/issues/42/comments","statuses_url":"https://api.github.com/repos/mixandgo/simple_blog/statuses/2643a53dc832da73ebf6806066823a2a7b148713","head":{"label":"mixandgo:feature/fix_keyword_parser_r0","ref":"feature/fix_keyword_parser_r0","sha":"2643a53dc832da73ebf6806066823a2a7b148713","user":{"login":"mixandgo","id":8421,"avatar_url":"https://avatars.githubusercontent.com/u/8421?v=2","gravatar_id":"","url":"https://api.github.com/users/mixandgo","html_url":"https://github.com/mixandgo","followers_url":"https://api.github.com/users/mixandgo/followers","following_url":"https://api.github.com/users/mixandgo/following{/other_user}","gists_url":"https://api.github.com/users/mixandgo/gists{/gist_id}","starred_url":"https://api.github.com/users/mixandgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixandgo/subscriptions","organizations_url":"https://api.github.com/users/mixandgo/orgs","repos_url":"https://api.github.com/users/mixandgo/repos","events_url":"https://api.github.com/users/mixandgo/events{/privacy}","received_events_url":"https://api.github.com/users/mixandgo/received_events","type":"User","site_admin":false},"repo":{"id":14232692,"name":"simple_blog","full_name":"mixandgo/simple_blog","owner":{"login":"mixandgo","id":8421,"avatar_url":"https://avatars.githubusercontent.com/u/8421?v=2","gravatar_id":"","url":"https://api.github.com/users/mixandgo","html_url":"https://github.com/mixandgo","followers_url":"https://api.github.com/users/mixandgo/followers","following_url":"https://api.github.com/users/mixandgo/following{/other_user}","gists_url":"https://api.github.com/users/mixandgo/gists{/gist_id}","starred_url":"https://api.github.com/users/mixandgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixandgo/subscriptions","organizations_url":"https://api.github.com/users/mixandgo/orgs","repos_url":"https://api.github.com/users/mixandgo/repos","events_url":"https://api.github.com/users/mixandgo/events{/privacy}","received_events_url":"https://api.github.com/users/mixandgo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mixandgo/simple_blog","description":"Simple Ruby on Rails engine that you can plug into your app","fork":false,"url":"https://api.github.com/repos/mixandgo/simple_blog","forks_url":"https://api.github.com/repos/mixandgo/simple_blog/forks","keys_url":"https://api.github.com/repos/mixandgo/simple_blog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixandgo/simple_blog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixandgo/simple_blog/teams","hooks_url":"https://api.github.com/repos/mixandgo/simple_blog/hooks","issue_events_url":"https://api.github.com/repos/mixandgo/simple_blog/issues/events{/number}","events_url":"https://api.github.com/repos/mixandgo/simple_blog/events","assignees_url":"https://api.github.com/repos/mixandgo/simple_blog/assignees{/user}","branches_url":"https://api.github.com/repos/mixandgo/simple_blog/branches{/branch}","tags_url":"https://api.github.com/repos/mixandgo/simple_blog/tags","blobs_url":"https://api.github.com/repos/mixandgo/simple_blog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixandgo/simple_blog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixandgo/simple_blog/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixandgo/simple_blog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixandgo/simple_blog/statuses/{sha}","languages_url":"https://api.github.com/repos/mixandgo/simple_blog/languages","stargazers_url":"https://api.github.com/repos/mixandgo/simple_blog/stargazers","contributors_url":"https://api.github.com/repos/mixandgo/simple_blog/contributors","subscribers_url":"https://api.github.com/repos/mixandgo/simple_blog/subscribers","subscription_url":"https://api.github.com/repos/mixandgo/simple_blog/subscription","commits_url":"https://api.github.com/repos/mixandgo/simple_blog/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixandgo/simple_blog/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixandgo/simple_blog/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixandgo/simple_blog/issues/comments/{number}","contents_url":"https://api.github.com/repos/mixandgo/simple_blog/contents/{+path}","compare_url":"https://api.github.com/repos/mixandgo/simple_blog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixandgo/simple_blog/merges","archive_url":"https://api.github.com/repos/mixandgo/simple_blog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixandgo/simple_blog/downloads","issues_url":"https://api.github.com/repos/mixandgo/simple_blog/issues{/number}","pulls_url":"https://api.github.com/repos/mixandgo/simple_blog/pulls{/number}","milestones_url":"https://api.github.com/repos/mixandgo/simple_blog/milestones{/number}","notifications_url":"https://api.github.com/repos/mixandgo/simple_blog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixandgo/simple_blog/labels{/name}","releases_url":"https://api.github.com/repos/mixandgo/simple_blog/releases{/id}","created_at":"2013-11-08T12:40:54Z","updated_at":"2014-09-11T08:36:45Z","pushed_at":"2014-10-23T09:17:53Z","git_url":"git://github.com/mixandgo/simple_blog.git","ssh_url":"git@github.com:mixandgo/simple_blog.git","clone_url":"https://github.com/mixandgo/simple_blog.git","svn_url":"https://github.com/mixandgo/simple_blog","homepage":"","size":1374,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"mixandgo:master","ref":"master","sha":"313f877119b764b41bcdaeab37c76e769a542f4e","user":{"login":"mixandgo","id":8421,"avatar_url":"https://avatars.githubusercontent.com/u/8421?v=2","gravatar_id":"","url":"https://api.github.com/users/mixandgo","html_url":"https://github.com/mixandgo","followers_url":"https://api.github.com/users/mixandgo/followers","following_url":"https://api.github.com/users/mixandgo/following{/other_user}","gists_url":"https://api.github.com/users/mixandgo/gists{/gist_id}","starred_url":"https://api.github.com/users/mixandgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixandgo/subscriptions","organizations_url":"https://api.github.com/users/mixandgo/orgs","repos_url":"https://api.github.com/users/mixandgo/repos","events_url":"https://api.github.com/users/mixandgo/events{/privacy}","received_events_url":"https://api.github.com/users/mixandgo/received_events","type":"User","site_admin":false},"repo":{"id":14232692,"name":"simple_blog","full_name":"mixandgo/simple_blog","owner":{"login":"mixandgo","id":8421,"avatar_url":"https://avatars.githubusercontent.com/u/8421?v=2","gravatar_id":"","url":"https://api.github.com/users/mixandgo","html_url":"https://github.com/mixandgo","followers_url":"https://api.github.com/users/mixandgo/followers","following_url":"https://api.github.com/users/mixandgo/following{/other_user}","gists_url":"https://api.github.com/users/mixandgo/gists{/gist_id}","starred_url":"https://api.github.com/users/mixandgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixandgo/subscriptions","organizations_url":"https://api.github.com/users/mixandgo/orgs","repos_url":"https://api.github.com/users/mixandgo/repos","events_url":"https://api.github.com/users/mixandgo/events{/privacy}","received_events_url":"https://api.github.com/users/mixandgo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mixandgo/simple_blog","description":"Simple Ruby on Rails engine that you can plug into your app","fork":false,"url":"https://api.github.com/repos/mixandgo/simple_blog","forks_url":"https://api.github.com/repos/mixandgo/simple_blog/forks","keys_url":"https://api.github.com/repos/mixandgo/simple_blog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixandgo/simple_blog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixandgo/simple_blog/teams","hooks_url":"https://api.github.com/repos/mixandgo/simple_blog/hooks","issue_events_url":"https://api.github.com/repos/mixandgo/simple_blog/issues/events{/number}","events_url":"https://api.github.com/repos/mixandgo/simple_blog/events","assignees_url":"https://api.github.com/repos/mixandgo/simple_blog/assignees{/user}","branches_url":"https://api.github.com/repos/mixandgo/simple_blog/branches{/branch}","tags_url":"https://api.github.com/repos/mixandgo/simple_blog/tags","blobs_url":"https://api.github.com/repos/mixandgo/simple_blog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixandgo/simple_blog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixandgo/simple_blog/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixandgo/simple_blog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixandgo/simple_blog/statuses/{sha}","languages_url":"https://api.github.com/repos/mixandgo/simple_blog/languages","stargazers_url":"https://api.github.com/repos/mixandgo/simple_blog/stargazers","contributors_url":"https://api.github.com/repos/mixandgo/simple_blog/contributors","subscribers_url":"https://api.github.com/repos/mixandgo/simple_blog/subscribers","subscription_url":"https://api.github.com/repos/mixandgo/simple_blog/subscription","commits_url":"https://api.github.com/repos/mixandgo/simple_blog/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixandgo/simple_blog/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixandgo/simple_blog/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixandgo/simple_blog/issues/comments/{number}","contents_url":"https://api.github.com/repos/mixandgo/simple_blog/contents/{+path}","compare_url":"https://api.github.com/repos/mixandgo/simple_blog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixandgo/simple_blog/merges","archive_url":"https://api.github.com/repos/mixandgo/simple_blog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixandgo/simple_blog/downloads","issues_url":"https://api.github.com/repos/mixandgo/simple_blog/issues{/number}","pulls_url":"https://api.github.com/repos/mixandgo/simple_blog/pulls{/number}","milestones_url":"https://api.github.com/repos/mixandgo/simple_blog/milestones{/number}","notifications_url":"https://api.github.com/repos/mixandgo/simple_blog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixandgo/simple_blog/labels{/name}","releases_url":"https://api.github.com/repos/mixandgo/simple_blog/releases{/id}","created_at":"2013-11-08T12:40:54Z","updated_at":"2014-09-11T08:36:45Z","pushed_at":"2014-10-23T09:17:53Z","git_url":"git://github.com/mixandgo/simple_blog.git","ssh_url":"git@github.com:mixandgo/simple_blog.git","clone_url":"https://github.com/mixandgo/simple_blog.git","svn_url":"https://github.com/mixandgo/simple_blog","homepage":"","size":1374,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixandgo/simple_blog/pulls/42"},"html":{"href":"https://github.com/mixandgo/simple_blog/pull/42"},"issue":{"href":"https://api.github.com/repos/mixandgo/simple_blog/issues/42"},"comments":{"href":"https://api.github.com/repos/mixandgo/simple_blog/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/mixandgo/simple_blog/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/mixandgo/simple_blog/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mixandgo/simple_blog/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/mixandgo/simple_blog/statuses/2643a53dc832da73ebf6806066823a2a7b148713"}}}}