GitHub PullRequestReviewCommentEvent at 2014-03-30 22:28:27
Repository: meteor
Actor: Slava
Payload: {"comment":{"url":"https://api.github.com/repos/meteor/meteor/pulls/comments/11100834","id":11100834,"diff_hunk":"@@ -71,6 +74,36 @@ CssTools = {\n     });\n \n     return newAst;\n+  },\n+\n+  // We are looking for all relative urls defined with the `url()` functionnal\n+  // notation and rewriting them to the equivalent absolute url using the\n+  // `position.source` path provided by css-parse\n+  rebaseCssUrls: function (ast) {","path":"packages/minifiers/minifiers.js","position":26,"original_position":26,"commit_id":"d1e9af9a8bb7bd6016e05ffc5ecd1a969a600ca8","original_commit_id":"d1e9af9a8bb7bd6016e05ffc5ecd1a969a600ca8","user":{"login":"Slava","id":2608446,"avatar_url":"https://avatars.githubusercontent.com/u/2608446?","gravatar_id":"d2ec30e55fdefdfba201cf408bb392d4","url":"https://api.github.com/users/Slava","html_url":"https://github.com/Slava","followers_url":"https://api.github.com/users/Slava/followers","following_url":"https://api.github.com/users/Slava/following{/other_user}","gists_url":"https://api.github.com/users/Slava/gists{/gist_id}","starred_url":"https://api.github.com/users/Slava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slava/subscriptions","organizations_url":"https://api.github.com/users/Slava/orgs","repos_url":"https://api.github.com/users/Slava/repos","events_url":"https://api.github.com/users/Slava/events{/privacy}","received_events_url":"https://api.github.com/users/Slava/received_events","type":"User","site_admin":false},"body":"not to nit pick but is \"rebase\" carrying the same meaning as the comment describes? I don't know how to use this word so leave it if you think it fits :).\r\n\r\nAlso, this method causes changes to the argument rather than returning a modified copy. If it is easy to efficiently copy and modify the passed AST, then do this. If it requires deep-cloning or some other expensive or redundant manipulations (especially given that we use it only once in this file so far), just reflect this in the function name or comment.","created_at":"2014-03-30T22:28:27Z","updated_at":"2014-03-30T22:28:27Z","html_url":"https://github.com/meteor/meteor/pull/1986#discussion_r11100834","pull_request_url":"https://api.github.com/repos/meteor/meteor/pulls/1986","_links":{"self":{"href":"https://api.github.com/repos/meteor/meteor/pulls/comments/11100834"},"html":{"href":"https://github.com/meteor/meteor/pull/1986#discussion_r11100834"},"pull_request":{"href":"https://api.github.com/repos/meteor/meteor/pulls/1986"}}}}