GitHub PullRequestReviewCommentEvent at 2014-05-14 10:53:32
Repository: cartopy
Actor: rhattersley
Payload: {"comment":{"url":"https://api.github.com/repos/SciTools/cartopy/pulls/comments/12630233","id":12630233,"diff_hunk":"@@ -1482,6 +1505,24 @@ def add_wmts(self, wmts, layer_name, matrix_set_name=None):\n         artist = ogc_artist.WMTSArtist(wmts, layer_name, matrix_set_name)\n         return self.add_artist(artist)\n \n+    def add_wms(self, wms, layer, **kwargs):\n+        \"\"\"\n+        Add the specified WMS layer to the axes.\n+\n+        Parameters\n+        ----------\n+        wms : string or :class:`owslib.wms.WebMapService` instance\n+            The web map service URL or owslib WMS instance to use.\n+        layer : string or iterable of string\n+            The name of the layer(s) to use.\n+\n+        All other keywords are passed through to the construction of the","path":"lib/cartopy/mpl/geoaxes.py","position":52,"original_position":52,"commit_id":"6e0c1b77b038485dd4fa2de3b42c9a9d1e656ee9","original_commit_id":"6e0c1b77b038485dd4fa2de3b42c9a9d1e656ee9","user":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?","gravatar_id":"1889af9f21c3e07af149e04f23a9619b","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"body":"There are two sets of \"unbounded\" keyword args relevant when adding a WMS: the ones for matplotlib.AxesImage and the ones for the service's getmap call. It's not clear why you'd want to prefer one over the other, so how about defining a parameter for each? e.g.\r\n```python\r\ndef add_wms(self, wms, layer, wms_kwargs=None, im_kwargs=None):\r\n```","created_at":"2014-05-14T10:53:32Z","updated_at":"2014-05-14T10:53:32Z","html_url":"https://github.com/SciTools/cartopy/pull/415#discussion_r12630233","pull_request_url":"https://api.github.com/repos/SciTools/cartopy/pulls/415","_links":{"self":{"href":"https://api.github.com/repos/SciTools/cartopy/pulls/comments/12630233"},"html":{"href":"https://github.com/SciTools/cartopy/pull/415#discussion_r12630233"},"pull_request":{"href":"https://api.github.com/repos/SciTools/cartopy/pulls/415"}}}}