GitHub PullRequestEvent at 2014-02-18 22:03:18
Repository: Classy
Actor: cloudkite
Payload: {"action":"closed","number":34,"pull_request":{"url":"https://api.github.com/repos/cloudkite/Classy/pulls/34","id":11897867,"html_url":"https://github.com/cloudkite/Classy/pull/34","diff_url":"https://github.com/cloudkite/Classy/pull/34.diff","patch_url":"https://github.com/cloudkite/Classy/pull/34.patch","issue_url":"https://api.github.com/repos/cloudkite/Classy/issues/34","number":34,"state":"closed","title":"Multiple style class support","user":{"login":"Ajax64","id":2103236,"avatar_url":"https://gravatar.com/avatar/2140492d6f1edbc111b0157320453aef?d=https%3A%2F%2Fidenticons.github.com%2F433a394334ffe54a0d598c2cc174d508.png&r=x","gravatar_id":"2140492d6f1edbc111b0157320453aef","url":"https://api.github.com/users/Ajax64","html_url":"https://github.com/Ajax64","followers_url":"https://api.github.com/users/Ajax64/followers","following_url":"https://api.github.com/users/Ajax64/following{/other_user}","gists_url":"https://api.github.com/users/Ajax64/gists{/gist_id}","starred_url":"https://api.github.com/users/Ajax64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ajax64/subscriptions","organizations_url":"https://api.github.com/users/Ajax64/orgs","repos_url":"https://api.github.com/users/Ajax64/repos","events_url":"https://api.github.com/users/Ajax64/events{/privacy}","received_events_url":"https://api.github.com/users/Ajax64/received_events","type":"User","site_admin":false},"body":"Hey mate,\r\n\r\nI added support for multiple style class values (as in CSS) and updated the sorting order of the selectors so that the last one (on cad file) overwrites the previously declared one. I am not sure what my implications my changes in the styleItem: method will have as your previously traversed the style nodes in reverse order.\r\n\r\nI did not update the parser to support selectors with multiple classes (like CSS: .style1.style2) but it works fine if you declare just multiple selectors.\r\n\r\nPlease let me think what you think about that.\r\n\r\nCheers,\r\n\r\nAlex\r\n\r\n\r\nChangelog:\r\n\r\n- added support for multiple style_class values by assigning a string which can contain whitespace separated values\r\n- changed the sorting of the style selectors by precedence so that it matches the order in the cas file (would match more the behaviour of the CSS standard)\r\n- changed styling order of items to traverse style nodes from top to bottom order instead of reverse","created_at":"2014-01-27T11:31:08Z","updated_at":"2014-02-18T22:03:17Z","closed_at":"2014-02-18T22:03:17Z","merged_at":null,"merge_commit_sha":"7101ef969fab171f220ee3a9f8d0d2ca40d9ebc7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudkite/Classy/pulls/34/commits","review_comments_url":"https://api.github.com/repos/cloudkite/Classy/pulls/34/comments","review_comment_url":"https://api.github.com/repos/cloudkite/Classy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cloudkite/Classy/issues/34/comments","statuses_url":"https://api.github.com/repos/cloudkite/Classy/statuses/10e548fc637d9bcbd78cda01ed37471a45fd674a","head":{"label":"Ajax64:MultipleClasses","ref":"MultipleClasses","sha":"10e548fc637d9bcbd78cda01ed37471a45fd674a","user":{"login":"Ajax64","id":2103236,"avatar_url":"https://gravatar.com/avatar/2140492d6f1edbc111b0157320453aef?d=https%3A%2F%2Fidenticons.github.com%2F433a394334ffe54a0d598c2cc174d508.png&r=x","gravatar_id":"2140492d6f1edbc111b0157320453aef","url":"https://api.github.com/users/Ajax64","html_url":"https://github.com/Ajax64","followers_url":"https://api.github.com/users/Ajax64/followers","following_url":"https://api.github.com/users/Ajax64/following{/other_user}","gists_url":"https://api.github.com/users/Ajax64/gists{/gist_id}","starred_url":"https://api.github.com/users/Ajax64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ajax64/subscriptions","organizations_url":"https://api.github.com/users/Ajax64/orgs","repos_url":"https://api.github.com/users/Ajax64/repos","events_url":"https://api.github.com/users/Ajax64/events{/privacy}","received_events_url":"https://api.github.com/users/Ajax64/received_events","type":"User","site_admin":false},"repo":{"id":16140360,"name":"Classy","full_name":"Ajax64/Classy","owner":{"login":"Ajax64","id":2103236,"avatar_url":"https://gravatar.com/avatar/2140492d6f1edbc111b0157320453aef?d=https%3A%2F%2Fidenticons.github.com%2F433a394334ffe54a0d598c2cc174d508.png&r=x","gravatar_id":"2140492d6f1edbc111b0157320453aef","url":"https://api.github.com/users/Ajax64","html_url":"https://github.com/Ajax64","followers_url":"https://api.github.com/users/Ajax64/followers","following_url":"https://api.github.com/users/Ajax64/following{/other_user}","gists_url":"https://api.github.com/users/Ajax64/gists{/gist_id}","starred_url":"https://api.github.com/users/Ajax64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ajax64/subscriptions","organizations_url":"https://api.github.com/users/Ajax64/orgs","repos_url":"https://api.github.com/users/Ajax64/repos","events_url":"https://api.github.com/users/Ajax64/events{/privacy}","received_events_url":"https://api.github.com/users/Ajax64/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ajax64/Classy","description":"Expressive, flexible, and powerful stylesheets for UIView and friends.","fork":true,"url":"https://api.github.com/repos/Ajax64/Classy","forks_url":"https://api.github.com/repos/Ajax64/Classy/forks","keys_url":"https://api.github.com/repos/Ajax64/Classy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ajax64/Classy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ajax64/Classy/teams","hooks_url":"https://api.github.com/repos/Ajax64/Classy/hooks","issue_events_url":"https://api.github.com/repos/Ajax64/Classy/issues/events{/number}","events_url":"https://api.github.com/repos/Ajax64/Classy/events","assignees_url":"https://api.github.com/repos/Ajax64/Classy/assignees{/user}","branches_url":"https://api.github.com/repos/Ajax64/Classy/branches{/branch}","tags_url":"https://api.github.com/repos/Ajax64/Classy/tags","blobs_url":"https://api.github.com/repos/Ajax64/Classy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ajax64/Classy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ajax64/Classy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ajax64/Classy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ajax64/Classy/statuses/{sha}","languages_url":"https://api.github.com/repos/Ajax64/Classy/languages","stargazers_url":"https://api.github.com/repos/Ajax64/Classy/stargazers","contributors_url":"https://api.github.com/repos/Ajax64/Classy/contributors","subscribers_url":"https://api.github.com/repos/Ajax64/Classy/subscribers","subscription_url":"https://api.github.com/repos/Ajax64/Classy/subscription","commits_url":"https://api.github.com/repos/Ajax64/Classy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ajax64/Classy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ajax64/Classy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ajax64/Classy/issues/comments/{number}","contents_url":"https://api.github.com/repos/Ajax64/Classy/contents/{+path}","compare_url":"https://api.github.com/repos/Ajax64/Classy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ajax64/Classy/merges","archive_url":"https://api.github.com/repos/Ajax64/Classy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ajax64/Classy/downloads","issues_url":"https://api.github.com/repos/Ajax64/Classy/issues{/number}","pulls_url":"https://api.github.com/repos/Ajax64/Classy/pulls{/number}","milestones_url":"https://api.github.com/repos/Ajax64/Classy/milestones{/number}","notifications_url":"https://api.github.com/repos/Ajax64/Classy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ajax64/Classy/labels{/name}","releases_url":"https://api.github.com/repos/Ajax64/Classy/releases{/id}","created_at":"2014-01-22T13:45:22Z","updated_at":"2014-02-18T22:03:17Z","pushed_at":"2014-01-27T13:11:47Z","git_url":"git://github.com/Ajax64/Classy.git","ssh_url":"git@github.com:Ajax64/Classy.git","clone_url":"https://github.com/Ajax64/Classy.git","svn_url":"https://github.com/Ajax64/Classy","homepage":"classy.as","size":1541,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"cloudkite:master","ref":"master","sha":"26acc10217376d72f1c6f44869c419016317ffe1","user":{"login":"cloudkite","id":598870,"avatar_url":"https://gravatar.com/avatar/c312558032cc8212dec5873ec771bf0e?d=https%3A%2F%2Fidenticons.github.com%2Fa7565b41e30239afe5aff7e4a02d9380.png&r=x","gravatar_id":"c312558032cc8212dec5873ec771bf0e","url":"https://api.github.com/users/cloudkite","html_url":"https://github.com/cloudkite","followers_url":"https://api.github.com/users/cloudkite/followers","following_url":"https://api.github.com/users/cloudkite/following{/other_user}","gists_url":"https://api.github.com/users/cloudkite/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudkite/subscriptions","organizations_url":"https://api.github.com/users/cloudkite/orgs","repos_url":"https://api.github.com/users/cloudkite/repos","events_url":"https://api.github.com/users/cloudkite/events{/privacy}","received_events_url":"https://api.github.com/users/cloudkite/received_events","type":"User","site_admin":false},"repo":{"id":12853729,"name":"Classy","full_name":"cloudkite/Classy","owner":{"login":"cloudkite","id":598870,"avatar_url":"https://gravatar.com/avatar/c312558032cc8212dec5873ec771bf0e?d=https%3A%2F%2Fidenticons.github.com%2Fa7565b41e30239afe5aff7e4a02d9380.png&r=x","gravatar_id":"c312558032cc8212dec5873ec771bf0e","url":"https://api.github.com/users/cloudkite","html_url":"https://github.com/cloudkite","followers_url":"https://api.github.com/users/cloudkite/followers","following_url":"https://api.github.com/users/cloudkite/following{/other_user}","gists_url":"https://api.github.com/users/cloudkite/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudkite/subscriptions","organizations_url":"https://api.github.com/users/cloudkite/orgs","repos_url":"https://api.github.com/users/cloudkite/repos","events_url":"https://api.github.com/users/cloudkite/events{/privacy}","received_events_url":"https://api.github.com/users/cloudkite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cloudkite/Classy","description":"Expressive, flexible, and powerful stylesheets for UIView and friends.","fork":false,"url":"https://api.github.com/repos/cloudkite/Classy","forks_url":"https://api.github.com/repos/cloudkite/Classy/forks","keys_url":"https://api.github.com/repos/cloudkite/Classy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudkite/Classy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudkite/Classy/teams","hooks_url":"https://api.github.com/repos/cloudkite/Classy/hooks","issue_events_url":"https://api.github.com/repos/cloudkite/Classy/issues/events{/number}","events_url":"https://api.github.com/repos/cloudkite/Classy/events","assignees_url":"https://api.github.com/repos/cloudkite/Classy/assignees{/user}","branches_url":"https://api.github.com/repos/cloudkite/Classy/branches{/branch}","tags_url":"https://api.github.com/repos/cloudkite/Classy/tags","blobs_url":"https://api.github.com/repos/cloudkite/Classy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudkite/Classy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudkite/Classy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudkite/Classy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudkite/Classy/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudkite/Classy/languages","stargazers_url":"https://api.github.com/repos/cloudkite/Classy/stargazers","contributors_url":"https://api.github.com/repos/cloudkite/Classy/contributors","subscribers_url":"https://api.github.com/repos/cloudkite/Classy/subscribers","subscription_url":"https://api.github.com/repos/cloudkite/Classy/subscription","commits_url":"https://api.github.com/repos/cloudkite/Classy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudkite/Classy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudkite/Classy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudkite/Classy/issues/comments/{number}","contents_url":"https://api.github.com/repos/cloudkite/Classy/contents/{+path}","compare_url":"https://api.github.com/repos/cloudkite/Classy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudkite/Classy/merges","archive_url":"https://api.github.com/repos/cloudkite/Classy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudkite/Classy/downloads","issues_url":"https://api.github.com/repos/cloudkite/Classy/issues{/number}","pulls_url":"https://api.github.com/repos/cloudkite/Classy/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudkite/Classy/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudkite/Classy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudkite/Classy/labels{/name}","releases_url":"https://api.github.com/repos/cloudkite/Classy/releases{/id}","created_at":"2013-09-15T22:29:27Z","updated_at":"2014-01-30T22:55:51Z","pushed_at":"2014-01-30T22:55:51Z","git_url":"git://github.com/cloudkite/Classy.git","ssh_url":"git@github.com:cloudkite/Classy.git","clone_url":"https://github.com/cloudkite/Classy.git","svn_url":"https://github.com/cloudkite/Classy","homepage":"classy.as","size":2450,"stargazers_count":288,"watchers_count":288,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":14,"mirror_url":null,"open_issues_count":5,"forks":14,"open_issues":5,"watchers":288,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudkite/Classy/pulls/34"},"html":{"href":"https://github.com/cloudkite/Classy/pull/34"},"issue":{"href":"https://api.github.com/repos/cloudkite/Classy/issues/34"},"comments":{"href":"https://api.github.com/repos/cloudkite/Classy/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudkite/Classy/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudkite/Classy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cloudkite/Classy/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/cloudkite/Classy/statuses/10e548fc637d9bcbd78cda01ed37471a45fd674a"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":3,"additions":80,"deletions":9,"changed_files":8}}