GitHub PullRequestReviewCommentEvent at 2014-11-25 06:07:38
Repository: voter-js
Actor: miccrun
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ScottTZhang/voter-js/pulls/comments/20844947","id":20844947,"diff_hunk":"@@ -418,31 +403,27 @@ app.all('/surveys/edit/:id', function(req, res) {\n         }\n         for (var j = 0; j < q.items.length; j++) {\n           var it = q.items[j];\n-          if ((it.itemVal == '' || it.itemVal == null) && it.itemDelete != '1') {\n+          if ((it.item == '' || it.item == null) && it.itemDelete != '1') {\n             survey.questions[i].items[j].itemExcept = 'Please fill in item.';\n             hasErr = true;\n           }\n         }\n       }\n     }\n-    var flattenedSurvey = flattenSurvey(survey);\n     if(hasErr) {\n-      return res.render('edit-survey-form.html', {\n-        data: flattenedSurvey,\n-        msg: \"Some input errors\"\n-      });\n+      return res.render('edit-survey-form.html', {data: survey, msg: \"Some input errors\"});","path":"main.js","position":197,"original_position":197,"commit_id":"faa22e6c818093509b3b6ed45b2909c3f5fbcb48","original_commit_id":"faa22e6c818093509b3b6ed45b2909c3f5fbcb48","user":{"login":"miccrun","id":1203661,"avatar_url":"https://avatars.githubusercontent.com/u/1203661?v=3","gravatar_id":"","url":"https://api.github.com/users/miccrun","html_url":"https://github.com/miccrun","followers_url":"https://api.github.com/users/miccrun/followers","following_url":"https://api.github.com/users/miccrun/following{/other_user}","gists_url":"https://api.github.com/users/miccrun/gists{/gist_id}","starred_url":"https://api.github.com/users/miccrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miccrun/subscriptions","organizations_url":"https://api.github.com/users/miccrun/orgs","repos_url":"https://api.github.com/users/miccrun/repos","events_url":"https://api.github.com/users/miccrun/events{/privacy}","received_events_url":"https://api.github.com/users/miccrun/received_events","type":"User","site_admin":false},"body":"Same as before.","created_at":"2014-11-25T06:07:38Z","updated_at":"2014-11-25T06:07:38Z","html_url":"https://github.com/ScottTZhang/voter-js/pull/4#discussion_r20844947","pull_request_url":"https://api.github.com/repos/ScottTZhang/voter-js/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/ScottTZhang/voter-js/pulls/comments/20844947"},"html":{"href":"https://github.com/ScottTZhang/voter-js/pull/4#discussion_r20844947"},"pull_request":{"href":"https://api.github.com/repos/ScottTZhang/voter-js/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/ScottTZhang/voter-js/pulls/4","id":24986640,"html_url":"https://github.com/ScottTZhang/voter-js/pull/4","diff_url":"https://github.com/ScottTZhang/voter-js/pull/4.diff","patch_url":"https://github.com/ScottTZhang/voter-js/pull/4.patch","issue_url":"https://api.github.com/repos/ScottTZhang/voter-js/issues/4","number":4,"state":"open","locked":false,"title":"nested survey object in edit/add survey","user":{"login":"ScottTZhang","id":3688311,"avatar_url":"https://avatars.githubusercontent.com/u/3688311?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottTZhang","html_url":"https://github.com/ScottTZhang","followers_url":"https://api.github.com/users/ScottTZhang/followers","following_url":"https://api.github.com/users/ScottTZhang/following{/other_user}","gists_url":"https://api.github.com/users/ScottTZhang/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottTZhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottTZhang/subscriptions","organizations_url":"https://api.github.com/users/ScottTZhang/orgs","repos_url":"https://api.github.com/users/ScottTZhang/repos","events_url":"https://api.github.com/users/ScottTZhang/events{/privacy}","received_events_url":"https://api.github.com/users/ScottTZhang/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-25T06:01:59Z","updated_at":"2014-11-25T06:07:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"502c960692f0ab9c932f4942a1d0d4cfff0398b7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ScottTZhang/voter-js/pulls/4/commits","review_comments_url":"https://api.github.com/repos/ScottTZhang/voter-js/pulls/4/comments","review_comment_url":"https://api.github.com/repos/ScottTZhang/voter-js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ScottTZhang/voter-js/issues/4/comments","statuses_url":"https://api.github.com/repos/ScottTZhang/voter-js/statuses/faa22e6c818093509b3b6ed45b2909c3f5fbcb48","head":{"label":"ScottTZhang:nest","ref":"nest","sha":"faa22e6c818093509b3b6ed45b2909c3f5fbcb48","user":{"login":"ScottTZhang","id":3688311,"avatar_url":"https://avatars.githubusercontent.com/u/3688311?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottTZhang","html_url":"https://github.com/ScottTZhang","followers_url":"https://api.github.com/users/ScottTZhang/followers","following_url":"https://api.github.com/users/ScottTZhang/following{/other_user}","gists_url":"https://api.github.com/users/ScottTZhang/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottTZhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottTZhang/subscriptions","organizations_url":"https://api.github.com/users/ScottTZhang/orgs","repos_url":"https://api.github.com/users/ScottTZhang/repos","events_url":"https://api.github.com/users/ScottTZhang/events{/privacy}","received_events_url":"https://api.github.com/users/ScottTZhang/received_events","type":"User","site_admin":false},"repo":{"id":26159145,"name":"voter-js","full_name":"ScottTZhang/voter-js","owner":{"login":"ScottTZhang","id":3688311,"avatar_url":"https://avatars.githubusercontent.com/u/3688311?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottTZhang","html_url":"https://github.com/ScottTZhang","followers_url":"https://api.github.com/users/ScottTZhang/followers","following_url":"https://api.github.com/users/ScottTZhang/following{/other_user}","gists_url":"https://api.github.com/users/ScottTZhang/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottTZhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottTZhang/subscriptions","organizations_url":"https://api.github.com/users/ScottTZhang/orgs","repos_url":"https://api.github.com/users/ScottTZhang/repos","events_url":"https://api.github.com/users/ScottTZhang/events{/privacy}","received_events_url":"https://api.github.com/users/ScottTZhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ScottTZhang/voter-js","description":"","fork":false,"url":"https://api.github.com/repos/ScottTZhang/voter-js","forks_url":"https://api.github.com/repos/ScottTZhang/voter-js/forks","keys_url":"https://api.github.com/repos/ScottTZhang/voter-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScottTZhang/voter-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScottTZhang/voter-js/teams","hooks_url":"https://api.github.com/repos/ScottTZhang/voter-js/hooks","issue_events_url":"https://api.github.com/repos/ScottTZhang/voter-js/issues/events{/number}","events_url":"https://api.github.com/repos/ScottTZhang/voter-js/events","assignees_url":"https://api.github.com/repos/ScottTZhang/voter-js/assignees{/user}","branches_url":"https://api.github.com/repos/ScottTZhang/voter-js/branches{/branch}","tags_url":"https://api.github.com/repos/ScottTZhang/voter-js/tags","blobs_url":"https://api.github.com/repos/ScottTZhang/voter-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScottTZhang/voter-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScottTZhang/voter-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScottTZhang/voter-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScottTZhang/voter-js/statuses/{sha}","languages_url":"https://api.github.com/repos/ScottTZhang/voter-js/languages","stargazers_url":"https://api.github.com/repos/ScottTZhang/voter-js/stargazers","contributors_url":"https://api.github.com/repos/ScottTZhang/voter-js/contributors","subscribers_url":"https://api.github.com/repos/ScottTZhang/voter-js/subscribers","subscription_url":"https://api.github.com/repos/ScottTZhang/voter-js/subscription","commits_url":"https://api.github.com/repos/ScottTZhang/voter-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScottTZhang/voter-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScottTZhang/voter-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScottTZhang/voter-js/issues/comments/{number}","contents_url":"https://api.github.com/repos/ScottTZhang/voter-js/contents/{+path}","compare_url":"https://api.github.com/repos/ScottTZhang/voter-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScottTZhang/voter-js/merges","archive_url":"https://api.github.com/repos/ScottTZhang/voter-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScottTZhang/voter-js/downloads","issues_url":"https://api.github.com/repos/ScottTZhang/voter-js/issues{/number}","pulls_url":"https://api.github.com/repos/ScottTZhang/voter-js/pulls{/number}","milestones_url":"https://api.github.com/repos/ScottTZhang/voter-js/milestones{/number}","notifications_url":"https://api.github.com/repos/ScottTZhang/voter-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScottTZhang/voter-js/labels{/name}","releases_url":"https://api.github.com/repos/ScottTZhang/voter-js/releases{/id}","created_at":"2014-11-04T08:11:40Z","updated_at":"2014-11-25T05:02:23Z","pushed_at":"2014-11-25T06:00:32Z","git_url":"git://github.com/ScottTZhang/voter-js.git","ssh_url":"git@github.com:ScottTZhang/voter-js.git","clone_url":"https://github.com/ScottTZhang/voter-js.git","svn_url":"https://github.com/ScottTZhang/voter-js","homepage":null,"size":1172,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"ScottTZhang:master","ref":"master","sha":"5403aa8233c744bb1a70226c0d207968cfe9fe47","user":{"login":"ScottTZhang","id":3688311,"avatar_url":"https://avatars.githubusercontent.com/u/3688311?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottTZhang","html_url":"https://github.com/ScottTZhang","followers_url":"https://api.github.com/users/ScottTZhang/followers","following_url":"https://api.github.com/users/ScottTZhang/following{/other_user}","gists_url":"https://api.github.com/users/ScottTZhang/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottTZhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottTZhang/subscriptions","organizations_url":"https://api.github.com/users/ScottTZhang/orgs","repos_url":"https://api.github.com/users/ScottTZhang/repos","events_url":"https://api.github.com/users/ScottTZhang/events{/privacy}","received_events_url":"https://api.github.com/users/ScottTZhang/received_events","type":"User","site_admin":false},"repo":{"id":26159145,"name":"voter-js","full_name":"ScottTZhang/voter-js","owner":{"login":"ScottTZhang","id":3688311,"avatar_url":"https://avatars.githubusercontent.com/u/3688311?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottTZhang","html_url":"https://github.com/ScottTZhang","followers_url":"https://api.github.com/users/ScottTZhang/followers","following_url":"https://api.github.com/users/ScottTZhang/following{/other_user}","gists_url":"https://api.github.com/users/ScottTZhang/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottTZhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottTZhang/subscriptions","organizations_url":"https://api.github.com/users/ScottTZhang/orgs","repos_url":"https://api.github.com/users/ScottTZhang/repos","events_url":"https://api.github.com/users/ScottTZhang/events{/privacy}","received_events_url":"https://api.github.com/users/ScottTZhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ScottTZhang/voter-js","description":"","fork":false,"url":"https://api.github.com/repos/ScottTZhang/voter-js","forks_url":"https://api.github.com/repos/ScottTZhang/voter-js/forks","keys_url":"https://api.github.com/repos/ScottTZhang/voter-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScottTZhang/voter-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScottTZhang/voter-js/teams","hooks_url":"https://api.github.com/repos/ScottTZhang/voter-js/hooks","issue_events_url":"https://api.github.com/repos/ScottTZhang/voter-js/issues/events{/number}","events_url":"https://api.github.com/repos/ScottTZhang/voter-js/events","assignees_url":"https://api.github.com/repos/ScottTZhang/voter-js/assignees{/user}","branches_url":"https://api.github.com/repos/ScottTZhang/voter-js/branches{/branch}","tags_url":"https://api.github.com/repos/ScottTZhang/voter-js/tags","blobs_url":"https://api.github.com/repos/ScottTZhang/voter-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScottTZhang/voter-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScottTZhang/voter-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScottTZhang/voter-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScottTZhang/voter-js/statuses/{sha}","languages_url":"https://api.github.com/repos/ScottTZhang/voter-js/languages","stargazers_url":"https://api.github.com/repos/ScottTZhang/voter-js/stargazers","contributors_url":"https://api.github.com/repos/ScottTZhang/voter-js/contributors","subscribers_url":"https://api.github.com/repos/ScottTZhang/voter-js/subscribers","subscription_url":"https://api.github.com/repos/ScottTZhang/voter-js/subscription","commits_url":"https://api.github.com/repos/ScottTZhang/voter-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScottTZhang/voter-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScottTZhang/voter-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScottTZhang/voter-js/issues/comments/{number}","contents_url":"https://api.github.com/repos/ScottTZhang/voter-js/contents/{+path}","compare_url":"https://api.github.com/repos/ScottTZhang/voter-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScottTZhang/voter-js/merges","archive_url":"https://api.github.com/repos/ScottTZhang/voter-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScottTZhang/voter-js/downloads","issues_url":"https://api.github.com/repos/ScottTZhang/voter-js/issues{/number}","pulls_url":"https://api.github.com/repos/ScottTZhang/voter-js/pulls{/number}","milestones_url":"https://api.github.com/repos/ScottTZhang/voter-js/milestones{/number}","notifications_url":"https://api.github.com/repos/ScottTZhang/voter-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScottTZhang/voter-js/labels{/name}","releases_url":"https://api.github.com/repos/ScottTZhang/voter-js/releases{/id}","created_at":"2014-11-04T08:11:40Z","updated_at":"2014-11-25T05:02:23Z","pushed_at":"2014-11-25T06:00:32Z","git_url":"git://github.com/ScottTZhang/voter-js.git","ssh_url":"git@github.com:ScottTZhang/voter-js.git","clone_url":"https://github.com/ScottTZhang/voter-js.git","svn_url":"https://github.com/ScottTZhang/voter-js","homepage":null,"size":1172,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ScottTZhang/voter-js/pulls/4"},"html":{"href":"https://github.com/ScottTZhang/voter-js/pull/4"},"issue":{"href":"https://api.github.com/repos/ScottTZhang/voter-js/issues/4"},"comments":{"href":"https://api.github.com/repos/ScottTZhang/voter-js/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/ScottTZhang/voter-js/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/ScottTZhang/voter-js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ScottTZhang/voter-js/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/ScottTZhang/voter-js/statuses/faa22e6c818093509b3b6ed45b2909c3f5fbcb48"}}}}