GitHub PullRequestEvent at 2014-10-01 08:02:53
Repository: nickel.rs
Actor: JeffBelgum
Payload: {"action":"opened","number":86,"pull_request":{"url":"https://api.github.com/repos/nickel-org/nickel.rs/pulls/86","id":22057031,"html_url":"https://github.com/nickel-org/nickel.rs/pull/86","diff_url":"https://github.com/nickel-org/nickel.rs/pull/86.diff","patch_url":"https://github.com/nickel-org/nickel.rs/pull/86.patch","issue_url":"https://api.github.com/repos/nickel-org/nickel.rs/issues/86","number":86,"state":"open","locked":false,"title":"Introduce a favicon middleware to handle /favicon.ico requests","user":{"login":"JeffBelgum","id":4001770,"avatar_url":"https://avatars.githubusercontent.com/u/4001770?v=2","gravatar_id":"","url":"https://api.github.com/users/JeffBelgum","html_url":"https://github.com/JeffBelgum","followers_url":"https://api.github.com/users/JeffBelgum/followers","following_url":"https://api.github.com/users/JeffBelgum/following{/other_user}","gists_url":"https://api.github.com/users/JeffBelgum/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffBelgum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffBelgum/subscriptions","organizations_url":"https://api.github.com/users/JeffBelgum/orgs","repos_url":"https://api.github.com/users/JeffBelgum/repos","events_url":"https://api.github.com/users/JeffBelgum/events{/privacy}","received_events_url":"https://api.github.com/users/JeffBelgum/received_events","type":"User","site_admin":false},"body":"Hi all,\r\n\r\nI don't know if you are interested in a contribution like this. I did it as an exercise to learn a bit about how Nickle works. If it's something that fits with the project's short term goals, great! I modeled it closely after express's serve-favicon middlewhere. The biggest omission is the cache-control header.\r\n\r\nI also wasn't sure of the best way to handle errors both at the file io level and for bad requests. Any input there would be appreciated.\r\n\r\nJeff","created_at":"2014-10-01T08:02:53Z","updated_at":"2014-10-01T08:02:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nickel-org/nickel.rs/pulls/86/commits","review_comments_url":"https://api.github.com/repos/nickel-org/nickel.rs/pulls/86/comments","review_comment_url":"https://api.github.com/repos/nickel-org/nickel.rs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nickel-org/nickel.rs/issues/86/comments","statuses_url":"https://api.github.com/repos/nickel-org/nickel.rs/statuses/c337d0ce0663a92e0d926dca4260a95853b1bb11","head":{"label":"JeffBelgum:master","ref":"master","sha":"c337d0ce0663a92e0d926dca4260a95853b1bb11","user":{"login":"JeffBelgum","id":4001770,"avatar_url":"https://avatars.githubusercontent.com/u/4001770?v=2","gravatar_id":"","url":"https://api.github.com/users/JeffBelgum","html_url":"https://github.com/JeffBelgum","followers_url":"https://api.github.com/users/JeffBelgum/followers","following_url":"https://api.github.com/users/JeffBelgum/following{/other_user}","gists_url":"https://api.github.com/users/JeffBelgum/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffBelgum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffBelgum/subscriptions","organizations_url":"https://api.github.com/users/JeffBelgum/orgs","repos_url":"https://api.github.com/users/JeffBelgum/repos","events_url":"https://api.github.com/users/JeffBelgum/events{/privacy}","received_events_url":"https://api.github.com/users/JeffBelgum/received_events","type":"User","site_admin":false},"repo":{"id":24669855,"name":"nickel.rs","full_name":"JeffBelgum/nickel.rs","owner":{"login":"JeffBelgum","id":4001770,"avatar_url":"https://avatars.githubusercontent.com/u/4001770?v=2","gravatar_id":"","url":"https://api.github.com/users/JeffBelgum","html_url":"https://github.com/JeffBelgum","followers_url":"https://api.github.com/users/JeffBelgum/followers","following_url":"https://api.github.com/users/JeffBelgum/following{/other_user}","gists_url":"https://api.github.com/users/JeffBelgum/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffBelgum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffBelgum/subscriptions","organizations_url":"https://api.github.com/users/JeffBelgum/orgs","repos_url":"https://api.github.com/users/JeffBelgum/repos","events_url":"https://api.github.com/users/JeffBelgum/events{/privacy}","received_events_url":"https://api.github.com/users/JeffBelgum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JeffBelgum/nickel.rs","description":"An expressjs inspired web framework for Rust","fork":true,"url":"https://api.github.com/repos/JeffBelgum/nickel.rs","forks_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/forks","keys_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/teams","hooks_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/hooks","issue_events_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/issues/events{/number}","events_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/events","assignees_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/assignees{/user}","branches_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/branches{/branch}","tags_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/tags","blobs_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/statuses/{sha}","languages_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/languages","stargazers_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/stargazers","contributors_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/contributors","subscribers_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/subscribers","subscription_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/subscription","commits_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/issues/comments/{number}","contents_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/contents/{+path}","compare_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/merges","archive_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/downloads","issues_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/issues{/number}","pulls_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/pulls{/number}","milestones_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/milestones{/number}","notifications_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/labels{/name}","releases_url":"https://api.github.com/repos/JeffBelgum/nickel.rs/releases{/id}","created_at":"2014-10-01T07:43:00Z","updated_at":"2014-10-01T07:45:42Z","pushed_at":"2014-10-01T07:53:54Z","git_url":"git://github.com/JeffBelgum/nickel.rs.git","ssh_url":"git@github.com:JeffBelgum/nickel.rs.git","clone_url":"https://github.com/JeffBelgum/nickel.rs.git","svn_url":"https://github.com/JeffBelgum/nickel.rs","homepage":"http://nickel.rs","size":3388,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nickel-org:master","ref":"master","sha":"d05cd9af2febad09336fc95f43f85e41f2eefb57","user":{"login":"nickel-org","id":7941614,"avatar_url":"https://avatars.githubusercontent.com/u/7941614?v=2","gravatar_id":"","url":"https://api.github.com/users/nickel-org","html_url":"https://github.com/nickel-org","followers_url":"https://api.github.com/users/nickel-org/followers","following_url":"https://api.github.com/users/nickel-org/following{/other_user}","gists_url":"https://api.github.com/users/nickel-org/gists{/gist_id}","starred_url":"https://api.github.com/users/nickel-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickel-org/subscriptions","organizations_url":"https://api.github.com/users/nickel-org/orgs","repos_url":"https://api.github.com/users/nickel-org/repos","events_url":"https://api.github.com/users/nickel-org/events{/privacy}","received_events_url":"https://api.github.com/users/nickel-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20462243,"name":"nickel.rs","full_name":"nickel-org/nickel.rs","owner":{"login":"nickel-org","id":7941614,"avatar_url":"https://avatars.githubusercontent.com/u/7941614?v=2","gravatar_id":"","url":"https://api.github.com/users/nickel-org","html_url":"https://github.com/nickel-org","followers_url":"https://api.github.com/users/nickel-org/followers","following_url":"https://api.github.com/users/nickel-org/following{/other_user}","gists_url":"https://api.github.com/users/nickel-org/gists{/gist_id}","starred_url":"https://api.github.com/users/nickel-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickel-org/subscriptions","organizations_url":"https://api.github.com/users/nickel-org/orgs","repos_url":"https://api.github.com/users/nickel-org/repos","events_url":"https://api.github.com/users/nickel-org/events{/privacy}","received_events_url":"https://api.github.com/users/nickel-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nickel-org/nickel.rs","description":"An expressjs inspired web framework for Rust","fork":false,"url":"https://api.github.com/repos/nickel-org/nickel.rs","forks_url":"https://api.github.com/repos/nickel-org/nickel.rs/forks","keys_url":"https://api.github.com/repos/nickel-org/nickel.rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickel-org/nickel.rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickel-org/nickel.rs/teams","hooks_url":"https://api.github.com/repos/nickel-org/nickel.rs/hooks","issue_events_url":"https://api.github.com/repos/nickel-org/nickel.rs/issues/events{/number}","events_url":"https://api.github.com/repos/nickel-org/nickel.rs/events","assignees_url":"https://api.github.com/repos/nickel-org/nickel.rs/assignees{/user}","branches_url":"https://api.github.com/repos/nickel-org/nickel.rs/branches{/branch}","tags_url":"https://api.github.com/repos/nickel-org/nickel.rs/tags","blobs_url":"https://api.github.com/repos/nickel-org/nickel.rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickel-org/nickel.rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickel-org/nickel.rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickel-org/nickel.rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickel-org/nickel.rs/statuses/{sha}","languages_url":"https://api.github.com/repos/nickel-org/nickel.rs/languages","stargazers_url":"https://api.github.com/repos/nickel-org/nickel.rs/stargazers","contributors_url":"https://api.github.com/repos/nickel-org/nickel.rs/contributors","subscribers_url":"https://api.github.com/repos/nickel-org/nickel.rs/subscribers","subscription_url":"https://api.github.com/repos/nickel-org/nickel.rs/subscription","commits_url":"https://api.github.com/repos/nickel-org/nickel.rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickel-org/nickel.rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickel-org/nickel.rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickel-org/nickel.rs/issues/comments/{number}","contents_url":"https://api.github.com/repos/nickel-org/nickel.rs/contents/{+path}","compare_url":"https://api.github.com/repos/nickel-org/nickel.rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickel-org/nickel.rs/merges","archive_url":"https://api.github.com/repos/nickel-org/nickel.rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickel-org/nickel.rs/downloads","issues_url":"https://api.github.com/repos/nickel-org/nickel.rs/issues{/number}","pulls_url":"https://api.github.com/repos/nickel-org/nickel.rs/pulls{/number}","milestones_url":"https://api.github.com/repos/nickel-org/nickel.rs/milestones{/number}","notifications_url":"https://api.github.com/repos/nickel-org/nickel.rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickel-org/nickel.rs/labels{/name}","releases_url":"https://api.github.com/repos/nickel-org/nickel.rs/releases{/id}","created_at":"2014-06-03T22:36:19Z","updated_at":"2014-09-30T23:54:28Z","pushed_at":"2014-09-29T21:48:50Z","git_url":"git://github.com/nickel-org/nickel.rs.git","ssh_url":"git@github.com:nickel-org/nickel.rs.git","clone_url":"https://github.com/nickel-org/nickel.rs.git","svn_url":"https://github.com/nickel-org/nickel.rs","homepage":"http://nickel.rs","size":3388,"stargazers_count":330,"watchers_count":330,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":16,"forks":30,"open_issues":16,"watchers":330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nickel-org/nickel.rs/pulls/86"},"html":{"href":"https://github.com/nickel-org/nickel.rs/pull/86"},"issue":{"href":"https://api.github.com/repos/nickel-org/nickel.rs/issues/86"},"comments":{"href":"https://api.github.com/repos/nickel-org/nickel.rs/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/nickel-org/nickel.rs/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/nickel-org/nickel.rs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nickel-org/nickel.rs/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/nickel-org/nickel.rs/statuses/c337d0ce0663a92e0d926dca4260a95853b1bb11"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":87,"deletions":0,"changed_files":3}}