GitHub PullRequestReviewCommentEvent at 2014-05-23 14:17:13
Repository: gamgee
Actor: MauricioCarneiro
Payload: {"comment":{"url":"https://api.github.com/repos/MauricioCarneiro/gamgee/pulls/comments/13000369","id":13000369,"diff_hunk":"@@ -54,20 +46,22 @@ SamBody::SamBody(SamBody&& other) noexcept :\n  *       until a data field (cigar, bases, etc.) is accessed, after which it will be\n  *       shared via reference counting with the Cigar, etc. objects\n  */\n-SamBody& SamBody::operator=(const SamBody& other) {\n+Sam& Sam::operator=(const Sam& other) {\n   if ( &other == this )  \n     return *this;\n-  m_body = utils::make_shared_sam(utils::sam_deep_copy(other.m_body.get())); ///< shared_ptr assignment will take care of deallocating old sam record if necessary\n+  m_header = utils::make_shared_sam_header(utils::sam_header_deep_copy(other.m_header.get())); ///< shared_ptr assignment will take care of deallocating old sam record if necessary","path":"gamgee/sam.cpp","position":64,"original_position":64,"commit_id":"9df4de2cf80d8fc1568eac39be925b1c176800aa","original_commit_id":"9df4de2cf80d8fc1568eac39be925b1c176800aa","user":{"login":"MauricioCarneiro","id":1843628,"avatar_url":"https://avatars.githubusercontent.com/u/1843628?","gravatar_id":"33e009132b1bc3c5bd7be7e0762d4c46","url":"https://api.github.com/users/MauricioCarneiro","html_url":"https://github.com/MauricioCarneiro","followers_url":"https://api.github.com/users/MauricioCarneiro/followers","following_url":"https://api.github.com/users/MauricioCarneiro/following{/other_user}","gists_url":"https://api.github.com/users/MauricioCarneiro/gists{/gist_id}","starred_url":"https://api.github.com/users/MauricioCarneiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MauricioCarneiro/subscriptions","organizations_url":"https://api.github.com/users/MauricioCarneiro/orgs","repos_url":"https://api.github.com/users/MauricioCarneiro/repos","events_url":"https://api.github.com/users/MauricioCarneiro/events{/privacy}","received_events_url":"https://api.github.com/users/MauricioCarneiro/received_events","type":"User","site_admin":false},"body":"I agree, but let's get this one through now (as there is nothing wrong with it), and discuss a new implementation for a future pull-request.","created_at":"2014-05-23T14:17:13Z","updated_at":"2014-05-23T14:17:13Z","html_url":"https://github.com/MauricioCarneiro/gamgee/pull/47#discussion_r13000369","pull_request_url":"https://api.github.com/repos/MauricioCarneiro/gamgee/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/MauricioCarneiro/gamgee/pulls/comments/13000369"},"html":{"href":"https://github.com/MauricioCarneiro/gamgee/pull/47#discussion_r13000369"},"pull_request":{"href":"https://api.github.com/repos/MauricioCarneiro/gamgee/pulls/47"}}}}