GitHub PullRequestReviewCommentEvent at 2014-08-19 22:55:53
Repository: katello
Actor: parthaa
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Katello/katello/pulls/comments/16449814","id":16449814,"diff_hunk":"@@ -66,25 +64,6 @@ def self.delete_orphaned_content\n   end\n \n   module InstanceMethods\n-    def save_repo_orchestration\n-      case orchestration_for\n-      when :update\n-        if self.pulp_update_needed?\n-          pre_queue.create(:name => \"update pulp repo: #{self.name}\", :priority => 2,\n-                           :action => [self, :refresh_pulp_repo, nil, nil, nil])","path":"app/models/katello/glue/pulp/repo.rb","position":18,"original_position":18,"commit_id":"9fdda3c7c2a7050b144c194d57d50a8ef8cbdb58","original_commit_id":"9fdda3c7c2a7050b144c194d57d50a8ef8cbdb58","user":{"login":"parthaa","id":1069779,"avatar_url":"https://avatars.githubusercontent.com/u/1069779?v=2","gravatar_id":"60992dc40784d685839b7767e00b7bc4","url":"https://api.github.com/users/parthaa","html_url":"https://github.com/parthaa","followers_url":"https://api.github.com/users/parthaa/followers","following_url":"https://api.github.com/users/parthaa/following{/other_user}","gists_url":"https://api.github.com/users/parthaa/gists{/gist_id}","starred_url":"https://api.github.com/users/parthaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parthaa/subscriptions","organizations_url":"https://api.github.com/users/parthaa/orgs","repos_url":"https://api.github.com/users/parthaa/repos","events_url":"https://api.github.com/users/parthaa/events{/privacy}","received_events_url":"https://api.github.com/users/parthaa/received_events","type":"User","site_admin":false},"body":"I was looking to see if the refresh_pulp_repo method was deleted. But sounds like provider.rb's  refresh manifest code is still using 'refresh_pulp_repo' . I recommend one of the following\r\n* Change refresh_pulp_repo's implementation and make it call the plan_action(::Actions::Pulp::Repository::Refresh, repository) OR\r\n* Create an issue to dynflow refresh manifest call.\r\n\r\nI do not want 2 different places doing the same thing in the code base.","created_at":"2014-08-19T22:55:53Z","updated_at":"2014-08-19T22:55:53Z","html_url":"https://github.com/Katello/katello/pull/4564#discussion_r16449814","pull_request_url":"https://api.github.com/repos/Katello/katello/pulls/4564","_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/16449814"},"html":{"href":"https://github.com/Katello/katello/pull/4564#discussion_r16449814"},"pull_request":{"href":"https://api.github.com/repos/Katello/katello/pulls/4564"}}},"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/4564","id":19623780,"html_url":"https://github.com/Katello/katello/pull/4564","diff_url":"https://github.com/Katello/katello/pull/4564.diff","patch_url":"https://github.com/Katello/katello/pull/4564.patch","issue_url":"https://api.github.com/repos/Katello/katello/issues/4564","number":4564,"state":"open","locked":false,"title":"Fixes #6297 - delayed jobs is dead, long live foreman-tasks","user":{"login":"iNecas","id":190443,"avatar_url":"https://avatars.githubusercontent.com/u/190443?v=2","gravatar_id":"08cb45efffe7995a6bcbb904e9066f79","url":"https://api.github.com/users/iNecas","html_url":"https://github.com/iNecas","followers_url":"https://api.github.com/users/iNecas/followers","following_url":"https://api.github.com/users/iNecas/following{/other_user}","gists_url":"https://api.github.com/users/iNecas/gists{/gist_id}","starred_url":"https://api.github.com/users/iNecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNecas/subscriptions","organizations_url":"https://api.github.com/users/iNecas/orgs","repos_url":"https://api.github.com/users/iNecas/repos","events_url":"https://api.github.com/users/iNecas/events{/privacy}","received_events_url":"https://api.github.com/users/iNecas/received_events","type":"User","site_admin":false},"body":"This pull request finishes the conversion of the async tasks based on delayed\njobs to the foreman tasks. The changes include:\n\n* #6296 - dynflowize auto-attach\n* #6304 - remove apply default info feature from the code for now\n* #6182 - dynflowize repository update (thanks @aruzicka)\n* #6297 - dynflowize content upload and after-sync callbacks\n* #6297 - remove unused code around delayed jobs\n* #6297 - updating the gemspec and rpm spec files to not use katello-jobs\n          and use foreman-tasks service instead (already available\n          in the foreman-tasks gem)\n* #6283 - use dynflow API to figure out if the foreman tasks is running or not\n\nSorry for the longish pull-request but since the changes need some testing, it\nmight be easier to test all at once, than everything separately, when all we\nneed at the end is not having to use delayed jobs.\n\nThere should not be any changes in the behavior of the app, except\nforeman-tasks service instead of katello-jobs, the ping returning\n'foreman_tasks' instead of 'katello_jobs  and repo synchronizations and\npackage uploads tracked in foreman tasks.","created_at":"2014-08-11T20:01:08Z","updated_at":"2014-08-19T22:55:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af9f96cabd1407d001b14a0f8c1c46d67403ce52","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Katello/katello/pulls/4564/commits","review_comments_url":"https://api.github.com/repos/Katello/katello/pulls/4564/comments","review_comment_url":"https://api.github.com/repos/Katello/katello/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Katello/katello/issues/4564/comments","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/9fdda3c7c2a7050b144c194d57d50a8ef8cbdb58","head":{"label":"iNecas:issue/6297","ref":"issue/6297","sha":"9fdda3c7c2a7050b144c194d57d50a8ef8cbdb58","user":{"login":"iNecas","id":190443,"avatar_url":"https://avatars.githubusercontent.com/u/190443?v=2","gravatar_id":"08cb45efffe7995a6bcbb904e9066f79","url":"https://api.github.com/users/iNecas","html_url":"https://github.com/iNecas","followers_url":"https://api.github.com/users/iNecas/followers","following_url":"https://api.github.com/users/iNecas/following{/other_user}","gists_url":"https://api.github.com/users/iNecas/gists{/gist_id}","starred_url":"https://api.github.com/users/iNecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNecas/subscriptions","organizations_url":"https://api.github.com/users/iNecas/orgs","repos_url":"https://api.github.com/users/iNecas/repos","events_url":"https://api.github.com/users/iNecas/events{/privacy}","received_events_url":"https://api.github.com/users/iNecas/received_events","type":"User","site_admin":false},"repo":{"id":4063892,"name":"katello","full_name":"iNecas/katello","owner":{"login":"iNecas","id":190443,"avatar_url":"https://avatars.githubusercontent.com/u/190443?v=2","gravatar_id":"08cb45efffe7995a6bcbb904e9066f79","url":"https://api.github.com/users/iNecas","html_url":"https://github.com/iNecas","followers_url":"https://api.github.com/users/iNecas/followers","following_url":"https://api.github.com/users/iNecas/following{/other_user}","gists_url":"https://api.github.com/users/iNecas/gists{/gist_id}","starred_url":"https://api.github.com/users/iNecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNecas/subscriptions","organizations_url":"https://api.github.com/users/iNecas/orgs","repos_url":"https://api.github.com/users/iNecas/repos","events_url":"https://api.github.com/users/iNecas/events{/privacy}","received_events_url":"https://api.github.com/users/iNecas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iNecas/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":true,"url":"https://api.github.com/repos/iNecas/katello","forks_url":"https://api.github.com/repos/iNecas/katello/forks","keys_url":"https://api.github.com/repos/iNecas/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iNecas/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iNecas/katello/teams","hooks_url":"https://api.github.com/repos/iNecas/katello/hooks","issue_events_url":"https://api.github.com/repos/iNecas/katello/issues/events{/number}","events_url":"https://api.github.com/repos/iNecas/katello/events","assignees_url":"https://api.github.com/repos/iNecas/katello/assignees{/user}","branches_url":"https://api.github.com/repos/iNecas/katello/branches{/branch}","tags_url":"https://api.github.com/repos/iNecas/katello/tags","blobs_url":"https://api.github.com/repos/iNecas/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iNecas/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iNecas/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/iNecas/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iNecas/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/iNecas/katello/languages","stargazers_url":"https://api.github.com/repos/iNecas/katello/stargazers","contributors_url":"https://api.github.com/repos/iNecas/katello/contributors","subscribers_url":"https://api.github.com/repos/iNecas/katello/subscribers","subscription_url":"https://api.github.com/repos/iNecas/katello/subscription","commits_url":"https://api.github.com/repos/iNecas/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/iNecas/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/iNecas/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/iNecas/katello/issues/comments/{number}","contents_url":"https://api.github.com/repos/iNecas/katello/contents/{+path}","compare_url":"https://api.github.com/repos/iNecas/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iNecas/katello/merges","archive_url":"https://api.github.com/repos/iNecas/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iNecas/katello/downloads","issues_url":"https://api.github.com/repos/iNecas/katello/issues{/number}","pulls_url":"https://api.github.com/repos/iNecas/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/iNecas/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/iNecas/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iNecas/katello/labels{/name}","releases_url":"https://api.github.com/repos/iNecas/katello/releases{/id}","created_at":"2012-04-18T13:19:11Z","updated_at":"2014-06-19T07:00:12Z","pushed_at":"2014-08-19T15:24:56Z","git_url":"git://github.com/iNecas/katello.git","ssh_url":"git@github.com:iNecas/katello.git","clone_url":"https://github.com/iNecas/katello.git","svn_url":"https://github.com/iNecas/katello","homepage":"katello.org","size":68636,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"adfca73a7e3d1cba921230d9c036f9d6597f0b43","user":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=2","gravatar_id":"e9275d7a67c7ce8d173df524050b724c","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":4007018,"name":"katello","full_name":"Katello/katello","owner":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=2","gravatar_id":"e9275d7a67c7ce8d173df524050b724c","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":false,"url":"https://api.github.com/repos/Katello/katello","forks_url":"https://api.github.com/repos/Katello/katello/forks","keys_url":"https://api.github.com/repos/Katello/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/katello/teams","hooks_url":"https://api.github.com/repos/Katello/katello/hooks","issue_events_url":"https://api.github.com/repos/Katello/katello/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/katello/events","assignees_url":"https://api.github.com/repos/Katello/katello/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/katello/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/katello/tags","blobs_url":"https://api.github.com/repos/Katello/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/katello/languages","stargazers_url":"https://api.github.com/repos/Katello/katello/stargazers","contributors_url":"https://api.github.com/repos/Katello/katello/contributors","subscribers_url":"https://api.github.com/repos/Katello/katello/subscribers","subscription_url":"https://api.github.com/repos/Katello/katello/subscription","commits_url":"https://api.github.com/repos/Katello/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/katello/issues/comments/{number}","contents_url":"https://api.github.com/repos/Katello/katello/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/katello/merges","archive_url":"https://api.github.com/repos/Katello/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/katello/downloads","issues_url":"https://api.github.com/repos/Katello/katello/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/katello/labels{/name}","releases_url":"https://api.github.com/repos/Katello/katello/releases{/id}","created_at":"2012-04-12T16:59:08Z","updated_at":"2014-08-03T22:35:52Z","pushed_at":"2014-08-18T22:18:30Z","git_url":"git://github.com/Katello/katello.git","ssh_url":"git@github.com:Katello/katello.git","clone_url":"https://github.com/Katello/katello.git","svn_url":"https://github.com/Katello/katello","homepage":"katello.org","size":244024,"stargazers_count":133,"watchers_count":133,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":90,"mirror_url":null,"open_issues_count":101,"forks":90,"open_issues":101,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/4564"},"html":{"href":"https://github.com/Katello/katello/pull/4564"},"issue":{"href":"https://api.github.com/repos/Katello/katello/issues/4564"},"comments":{"href":"https://api.github.com/repos/Katello/katello/issues/4564/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/katello/pulls/4564/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Katello/katello/pulls/4564/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/katello/statuses/9fdda3c7c2a7050b144c194d57d50a8ef8cbdb58"}}}}