GitHub PushEvent at 2014-11-07 13:56:59
Repository: phabricator-tools
Actor: aevri
Payload: {"shas":[["30ad1c6e2669356ab8dcf89f9b97a3bf64ac97eb","ada025f3ec64df6c5365d7b4138a1efb16c206d8@bloomberg.net","Refactor, extract phlsys_timer from arcydreporter\n\nExtract \"Timer\" and \"timer_context\" from abdt_arcydreporter.py so that\nwe may re-use them. Use 'rope' to do the extraction safely.\n\nTest Plan:\n\nmake sure refs to 'Timer' are correct\n$ git grep Timer\n\nmake sure refs to 'timer_context' are correct\n$ git grep timer_context\n\nJust in case\n$ ./precommit.sh","Angelos Evripiotis",true],["5157a5cbcef93f17101ba1282cd88700d63f20a4","ada025f3ec64df6c5365d7b4138a1efb16c206d8@bloomberg.net","Add phlsys_timer.Timer.restart(), for convenience\n\nWhen you're timing something in a loop, it's pretty common to want to\nget the duration and re-start the timer. Combine these into a single\nmethod for convenience.\n\nThis is used in subsequent commits.\n\nTest Plan:\nAdded doctest\n$ ./precommit.sh","Angelos Evripiotis",true],["2fe9f6c379927b5c718d0ef45e7a256295d9732f","ada025f3ec64df6c5365d7b4138a1efb16c206d8@bloomberg.net","Add '--external-report-command' to arcyd\n\nMake it easier to hook up arcyd to external monitoring by providing an\noptional callback to an external command, which will be provided with a\nreport in json.\n\nSet this up in the test shell for easy exercising.\n\nTest Plan:\n\nCheck that happy path logs json reports to file\n$ ./testbed/arcyd/test_shell.sh\n    $ tail -f ../arcyd/savereport.txt\n    .. logs json reports as expected ..\n    $ exit\n\nAdd 'false' line into 'savereport', to exercise unhappy case\n$ ./testbed/arcyd/test_shell.sh\n    .. wait ..\n    $ exit\n    .. error appears in logs as expected ..\n\nMake 'savereport' non-executable, to check that we fail fast\n$ chmod -x testbed/arcyd/savereport\n$ ./testbed/arcyd/test_shell.sh\n    .. wait ..\n    $ exit\n    .. fatal error appears in logs as expected ..\n\nCheck that other code paths are unaffected\n$ ./precommit.sh","Angelos Evripiotis",true]],"size":3,"ref":"refs/heads/master","head":"2fe9f6c379927b5c718d0ef45e7a256295d9732f"}