GitHub PullRequestReviewCommentEvent at 2014-09-26 19:07:39
Repository: scisql
Actor: smonkewitz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wangd/scisql/pulls/comments/18107635","id":18107635,"diff_hunk":"@@ -0,0 +1,59 @@\n+import argparse\n+import operator\n+import sys\n+import json\n+\n+__ver = {\n+    'atleast_version': operator.ge,\n+    'exact_version': operator.eq,\n+    'max_version': operator.le,\n+}\n+\n+def __parse_version(version):\n+    return tuple(map(int, version.split('.')))\n+\n+def check(version, **kw):\n+\n+    ok = True\n+    msg = None\n+    try:\n+        mv = __parse_version(version)\n+    except:\n+        msg = 'Invalid MYSQL_SERVER_VERSION {0}'.format(version)\n+        ok = False\n+    for constraint in __ver.keys():\n+        if constraint in kw:\n+            try:\n+                    dv = __parse_version(kw[constraint])\n+            except:\n+                msg = 'Invalid {0} value {1}'.format(constraint, kw[constraint])\n+                ok = False\n+            if not __ver[constraint](mv, dv):\n+                msg = 'MySQL server version {0} violates {1}={2}'.format(version, constraint, kw[constraint])\n+                ok = False\n+        return (ok, msg)\n+\n+def main():\n+\n+    parser = argparse.ArgumentParser()\n+    parser.add_argument('-v', '--version', help=\"toto\")\n+    parser.add_argument('-c', '--constraints', nargs=\"+\", type=str, help=\"titi\")","path":"tools/mysqlversion.py","position":40,"original_position":40,"commit_id":"65ea3e7b3efc9fa526376340d20634ccfba9ddcb","original_commit_id":"65ea3e7b3efc9fa526376340d20634ccfba9ddcb","user":{"login":"smonkewitz","id":620114,"avatar_url":"https://avatars.githubusercontent.com/u/620114?v=2","gravatar_id":"","url":"https://api.github.com/users/smonkewitz","html_url":"https://github.com/smonkewitz","followers_url":"https://api.github.com/users/smonkewitz/followers","following_url":"https://api.github.com/users/smonkewitz/following{/other_user}","gists_url":"https://api.github.com/users/smonkewitz/gists{/gist_id}","starred_url":"https://api.github.com/users/smonkewitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smonkewitz/subscriptions","organizations_url":"https://api.github.com/users/smonkewitz/orgs","repos_url":"https://api.github.com/users/smonkewitz/repos","events_url":"https://api.github.com/users/smonkewitz/events{/privacy}","received_events_url":"https://api.github.com/users/smonkewitz/received_events","type":"User","site_admin":false},"body":"Not a deal breaker, but it would be nicer if you added --atleast-version, etc... Also \"titi\" and \"toto\" are humorous, but not actually helpful :)","created_at":"2014-09-26T19:07:39Z","updated_at":"2014-09-26T19:07:39Z","html_url":"https://github.com/wangd/scisql/pull/5#discussion_r18107635","pull_request_url":"https://api.github.com/repos/wangd/scisql/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/wangd/scisql/pulls/comments/18107635"},"html":{"href":"https://github.com/wangd/scisql/pull/5#discussion_r18107635"},"pull_request":{"href":"https://api.github.com/repos/wangd/scisql/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/wangd/scisql/pulls/5","id":21852195,"html_url":"https://github.com/wangd/scisql/pull/5","diff_url":"https://github.com/wangd/scisql/pull/5.diff","patch_url":"https://github.com/wangd/scisql/pull/5.patch","issue_url":"https://api.github.com/repos/wangd/scisql/issues/5","number":5,"state":"open","locked":false,"title":"U/fjammes/dm 750","user":{"login":"fjammes","id":290045,"avatar_url":"https://avatars.githubusercontent.com/u/290045?v=2","gravatar_id":"","url":"https://api.github.com/users/fjammes","html_url":"https://github.com/fjammes","followers_url":"https://api.github.com/users/fjammes/followers","following_url":"https://api.github.com/users/fjammes/following{/other_user}","gists_url":"https://api.github.com/users/fjammes/gists{/gist_id}","starred_url":"https://api.github.com/users/fjammes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjammes/subscriptions","organizations_url":"https://api.github.com/users/fjammes/orgs","repos_url":"https://api.github.com/users/fjammes/repos","events_url":"https://api.github.com/users/fjammes/events{/privacy}","received_events_url":"https://api.github.com/users/fjammes/received_events","type":"User","site_admin":false},"body":"Hi Serge, \r\n\r\nCode is finished, but I still need to write documentation. (I may also had colored log if I've enough time.)\r\nIn order to test, you can use and update test/test-install-process.sh.\r\n\r\nThanks,\r\n\r\nFabrice","created_at":"2014-09-26T14:33:07Z","updated_at":"2014-09-26T19:07:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52a64d170d34de22c84ca6128b69856c334fc7a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wangd/scisql/pulls/5/commits","review_comments_url":"https://api.github.com/repos/wangd/scisql/pulls/5/comments","review_comment_url":"https://api.github.com/repos/wangd/scisql/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wangd/scisql/issues/5/comments","statuses_url":"https://api.github.com/repos/wangd/scisql/statuses/65ea3e7b3efc9fa526376340d20634ccfba9ddcb","head":{"label":"fjammes:u/fjammes/DM-750","ref":"u/fjammes/DM-750","sha":"65ea3e7b3efc9fa526376340d20634ccfba9ddcb","user":{"login":"fjammes","id":290045,"avatar_url":"https://avatars.githubusercontent.com/u/290045?v=2","gravatar_id":"","url":"https://api.github.com/users/fjammes","html_url":"https://github.com/fjammes","followers_url":"https://api.github.com/users/fjammes/followers","following_url":"https://api.github.com/users/fjammes/following{/other_user}","gists_url":"https://api.github.com/users/fjammes/gists{/gist_id}","starred_url":"https://api.github.com/users/fjammes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjammes/subscriptions","organizations_url":"https://api.github.com/users/fjammes/orgs","repos_url":"https://api.github.com/users/fjammes/repos","events_url":"https://api.github.com/users/fjammes/events{/privacy}","received_events_url":"https://api.github.com/users/fjammes/received_events","type":"User","site_admin":false},"repo":{"id":23917537,"name":"scisql","full_name":"fjammes/scisql","owner":{"login":"fjammes","id":290045,"avatar_url":"https://avatars.githubusercontent.com/u/290045?v=2","gravatar_id":"","url":"https://api.github.com/users/fjammes","html_url":"https://github.com/fjammes","followers_url":"https://api.github.com/users/fjammes/followers","following_url":"https://api.github.com/users/fjammes/following{/other_user}","gists_url":"https://api.github.com/users/fjammes/gists{/gist_id}","starred_url":"https://api.github.com/users/fjammes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjammes/subscriptions","organizations_url":"https://api.github.com/users/fjammes/orgs","repos_url":"https://api.github.com/users/fjammes/repos","events_url":"https://api.github.com/users/fjammes/events{/privacy}","received_events_url":"https://api.github.com/users/fjammes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fjammes/scisql","description":"  Science-specific tools and extensions for SQL. Currently the project contains user defined functions (UDFs) for MySQL including spatial geometry, astronomy specific functions and mathematical functions.  The project was motivated by the needs of the Large Synoptic Survey Telescope (LSST).","fork":true,"url":"https://api.github.com/repos/fjammes/scisql","forks_url":"https://api.github.com/repos/fjammes/scisql/forks","keys_url":"https://api.github.com/repos/fjammes/scisql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fjammes/scisql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fjammes/scisql/teams","hooks_url":"https://api.github.com/repos/fjammes/scisql/hooks","issue_events_url":"https://api.github.com/repos/fjammes/scisql/issues/events{/number}","events_url":"https://api.github.com/repos/fjammes/scisql/events","assignees_url":"https://api.github.com/repos/fjammes/scisql/assignees{/user}","branches_url":"https://api.github.com/repos/fjammes/scisql/branches{/branch}","tags_url":"https://api.github.com/repos/fjammes/scisql/tags","blobs_url":"https://api.github.com/repos/fjammes/scisql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fjammes/scisql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fjammes/scisql/git/refs{/sha}","trees_url":"https://api.github.com/repos/fjammes/scisql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fjammes/scisql/statuses/{sha}","languages_url":"https://api.github.com/repos/fjammes/scisql/languages","stargazers_url":"https://api.github.com/repos/fjammes/scisql/stargazers","contributors_url":"https://api.github.com/repos/fjammes/scisql/contributors","subscribers_url":"https://api.github.com/repos/fjammes/scisql/subscribers","subscription_url":"https://api.github.com/repos/fjammes/scisql/subscription","commits_url":"https://api.github.com/repos/fjammes/scisql/commits{/sha}","git_commits_url":"https://api.github.com/repos/fjammes/scisql/git/commits{/sha}","comments_url":"https://api.github.com/repos/fjammes/scisql/comments{/number}","issue_comment_url":"https://api.github.com/repos/fjammes/scisql/issues/comments/{number}","contents_url":"https://api.github.com/repos/fjammes/scisql/contents/{+path}","compare_url":"https://api.github.com/repos/fjammes/scisql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fjammes/scisql/merges","archive_url":"https://api.github.com/repos/fjammes/scisql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fjammes/scisql/downloads","issues_url":"https://api.github.com/repos/fjammes/scisql/issues{/number}","pulls_url":"https://api.github.com/repos/fjammes/scisql/pulls{/number}","milestones_url":"https://api.github.com/repos/fjammes/scisql/milestones{/number}","notifications_url":"https://api.github.com/repos/fjammes/scisql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fjammes/scisql/labels{/name}","releases_url":"https://api.github.com/repos/fjammes/scisql/releases{/id}","created_at":"2014-09-11T12:36:21Z","updated_at":"2014-09-03T20:41:07Z","pushed_at":"2014-09-26T11:17:11Z","git_url":"git://github.com/fjammes/scisql.git","ssh_url":"git@github.com:fjammes/scisql.git","clone_url":"https://github.com/fjammes/scisql.git","svn_url":"https://github.com/fjammes/scisql","homepage":"","size":1641,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wangd:master","ref":"master","sha":"28a98f1725e2da215988128a90ab32b27c447004","user":{"login":"wangd","id":571458,"avatar_url":"https://avatars.githubusercontent.com/u/571458?v=2","gravatar_id":"","url":"https://api.github.com/users/wangd","html_url":"https://github.com/wangd","followers_url":"https://api.github.com/users/wangd/followers","following_url":"https://api.github.com/users/wangd/following{/other_user}","gists_url":"https://api.github.com/users/wangd/gists{/gist_id}","starred_url":"https://api.github.com/users/wangd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangd/subscriptions","organizations_url":"https://api.github.com/users/wangd/orgs","repos_url":"https://api.github.com/users/wangd/repos","events_url":"https://api.github.com/users/wangd/events{/privacy}","received_events_url":"https://api.github.com/users/wangd/received_events","type":"User","site_admin":false},"repo":{"id":23636505,"name":"scisql","full_name":"wangd/scisql","owner":{"login":"wangd","id":571458,"avatar_url":"https://avatars.githubusercontent.com/u/571458?v=2","gravatar_id":"","url":"https://api.github.com/users/wangd","html_url":"https://github.com/wangd","followers_url":"https://api.github.com/users/wangd/followers","following_url":"https://api.github.com/users/wangd/following{/other_user}","gists_url":"https://api.github.com/users/wangd/gists{/gist_id}","starred_url":"https://api.github.com/users/wangd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangd/subscriptions","organizations_url":"https://api.github.com/users/wangd/orgs","repos_url":"https://api.github.com/users/wangd/repos","events_url":"https://api.github.com/users/wangd/events{/privacy}","received_events_url":"https://api.github.com/users/wangd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wangd/scisql","description":"  Science-specific tools and extensions for SQL. Currently the project contains user defined functions (UDFs) for MySQL including spatial geometry, astronomy specific functions and mathematical functions.  The project was motivated by the needs of the Large Synoptic Survey Telescope (LSST).","fork":false,"url":"https://api.github.com/repos/wangd/scisql","forks_url":"https://api.github.com/repos/wangd/scisql/forks","keys_url":"https://api.github.com/repos/wangd/scisql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wangd/scisql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wangd/scisql/teams","hooks_url":"https://api.github.com/repos/wangd/scisql/hooks","issue_events_url":"https://api.github.com/repos/wangd/scisql/issues/events{/number}","events_url":"https://api.github.com/repos/wangd/scisql/events","assignees_url":"https://api.github.com/repos/wangd/scisql/assignees{/user}","branches_url":"https://api.github.com/repos/wangd/scisql/branches{/branch}","tags_url":"https://api.github.com/repos/wangd/scisql/tags","blobs_url":"https://api.github.com/repos/wangd/scisql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wangd/scisql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wangd/scisql/git/refs{/sha}","trees_url":"https://api.github.com/repos/wangd/scisql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wangd/scisql/statuses/{sha}","languages_url":"https://api.github.com/repos/wangd/scisql/languages","stargazers_url":"https://api.github.com/repos/wangd/scisql/stargazers","contributors_url":"https://api.github.com/repos/wangd/scisql/contributors","subscribers_url":"https://api.github.com/repos/wangd/scisql/subscribers","subscription_url":"https://api.github.com/repos/wangd/scisql/subscription","commits_url":"https://api.github.com/repos/wangd/scisql/commits{/sha}","git_commits_url":"https://api.github.com/repos/wangd/scisql/git/commits{/sha}","comments_url":"https://api.github.com/repos/wangd/scisql/comments{/number}","issue_comment_url":"https://api.github.com/repos/wangd/scisql/issues/comments/{number}","contents_url":"https://api.github.com/repos/wangd/scisql/contents/{+path}","compare_url":"https://api.github.com/repos/wangd/scisql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wangd/scisql/merges","archive_url":"https://api.github.com/repos/wangd/scisql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wangd/scisql/downloads","issues_url":"https://api.github.com/repos/wangd/scisql/issues{/number}","pulls_url":"https://api.github.com/repos/wangd/scisql/pulls{/number}","milestones_url":"https://api.github.com/repos/wangd/scisql/milestones{/number}","notifications_url":"https://api.github.com/repos/wangd/scisql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wangd/scisql/labels{/name}","releases_url":"https://api.github.com/repos/wangd/scisql/releases{/id}","created_at":"2014-09-03T20:33:53Z","updated_at":"2014-09-03T20:41:07Z","pushed_at":"2014-09-03T20:58:26Z","git_url":"git://github.com/wangd/scisql.git","ssh_url":"git@github.com:wangd/scisql.git","clone_url":"https://github.com/wangd/scisql.git","svn_url":"https://github.com/wangd/scisql","homepage":"","size":1816,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wangd/scisql/pulls/5"},"html":{"href":"https://github.com/wangd/scisql/pull/5"},"issue":{"href":"https://api.github.com/repos/wangd/scisql/issues/5"},"comments":{"href":"https://api.github.com/repos/wangd/scisql/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/wangd/scisql/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/wangd/scisql/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wangd/scisql/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/wangd/scisql/statuses/65ea3e7b3efc9fa526376340d20634ccfba9ddcb"}}}}