GitHub PullRequestReviewCommentEvent at 2014-01-15 17:33:36
Repository: spark
Actor: devoncarew
Payload: {"comment":{"url":"https://api.github.com/repos/dart-lang/spark/pulls/comments/8904261","id":8904261,"diff_hunk":"@@ -13,7 +13,15 @@ import '../common/widget.dart';\n @CustomTag('spark-button')\n class SparkButton extends Widget {\n   @published bool primary = false;\n-  @published bool active = true;\n+\n+  // TODO: changing this field does not cause the btnClasses to be re-calculated","path":"widgets/lib/spark_button/spark_button.dart","position":6,"original_position":6,"commit_id":"ce2eb22175401d5906b832ee5765617930decfc7","original_commit_id":"ce2eb22175401d5906b832ee5765617930decfc7","user":{"login":"devoncarew","id":1269969,"avatar_url":"https://gravatar.com/avatar/a4184620e2a180ff0e315e1e0f1eb8d5?d=https%3A%2F%2Fidenticons.github.com%2F7490fa3d9e9a8f6b381272e235a3141c.png&r=x","gravatar_id":"a4184620e2a180ff0e315e1e0f1eb8d5","url":"https://api.github.com/users/devoncarew","html_url":"https://github.com/devoncarew","followers_url":"https://api.github.com/users/devoncarew/followers","following_url":"https://api.github.com/users/devoncarew/following{/other_user}","gists_url":"https://api.github.com/users/devoncarew/gists{/gist_id}","starred_url":"https://api.github.com/users/devoncarew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devoncarew/subscriptions","organizations_url":"https://api.github.com/users/devoncarew/orgs","repos_url":"https://api.github.com/users/devoncarew/repos","events_url":"https://api.github.com/users/devoncarew/events{/privacy}","received_events_url":"https://api.github.com/users/devoncarew/received_events","type":"User","site_admin":false},"body":"@ussuri, so you're aware, just having `@published bool active = true;` was not updating the visual state of the button.","created_at":"2014-01-15T17:33:36Z","updated_at":"2014-01-15T17:33:36Z","html_url":"https://github.com/dart-lang/spark/pull/688#discussion_r8904261","pull_request_url":"https://api.github.com/repos/dart-lang/spark/pulls/688","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/spark/pulls/comments/8904261"},"html":{"href":"https://github.com/dart-lang/spark/pull/688#discussion_r8904261"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/spark/pulls/688"}}}}