GitHub PullRequestReviewCommentEvent at 2014-12-08 20:00:22
Repository: jquery
Actor: mzgol
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery/pulls/comments/21480239","id":21480239,"diff_hunk":"@@ -7,10 +7,9 @@ define([\n \t\"../selector\"\n ], function( jQuery, rnotwhite, access, support ) {\n \n-var nodeHook, boolHook,\n+var boolHook,\n \tattrHandle = jQuery.expr.attrHandle,\n \truseDefault = /^(?:checked|selected)$/i,\n-\tgetSetAttribute = support.getSetAttribute,\n \tgetSetInput = support.input;","path":"src/attributes/attr.js","position":9,"original_position":9,"commit_id":"b1ab967a0f760d5f898a9d6b812b9b3432d6d3cb","original_commit_id":"b1ab967a0f760d5f898a9d6b812b9b3432d6d3cb","user":{"login":"mzgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mzgol","html_url":"https://github.com/mzgol","followers_url":"https://api.github.com/users/mzgol/followers","following_url":"https://api.github.com/users/mzgol/following{/other_user}","gists_url":"https://api.github.com/users/mzgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mzgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzgol/subscriptions","organizations_url":"https://api.github.com/users/mzgol/orgs","repos_url":"https://api.github.com/users/mzgol/repos","events_url":"https://api.github.com/users/mzgol/events{/privacy}","received_events_url":"https://api.github.com/users/mzgol/received_events","type":"User","site_admin":false},"body":"Heh. :) I guess we can discuss it if you prefer the other option; there would be a lot of comments to add so it's a matter for a separate PR anyway. Current way is consistent with the rest of the code so let's leave it as is and we can revisit later. :)","created_at":"2014-12-08T20:00:22Z","updated_at":"2014-12-08T20:00:22Z","html_url":"https://github.com/jquery/jquery/pull/1837#discussion_r21480239","pull_request_url":"https://api.github.com/repos/jquery/jquery/pulls/1837","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments/21480239"},"html":{"href":"https://github.com/jquery/jquery/pull/1837#discussion_r21480239"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery/pulls/1837"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery/pulls/1837","id":23840673,"html_url":"https://github.com/jquery/jquery/pull/1837","diff_url":"https://github.com/jquery/jquery/pull/1837.diff","patch_url":"https://github.com/jquery/jquery/pull/1837.patch","issue_url":"https://api.github.com/repos/jquery/jquery/issues/1837","number":1837,"state":"open","locked":false,"title":"Misc: Drop support for older browsers; update support comments","user":{"login":"mzgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mzgol","html_url":"https://github.com/mzgol","followers_url":"https://api.github.com/users/mzgol/followers","following_url":"https://api.github.com/users/mzgol/following{/other_user}","gists_url":"https://api.github.com/users/mzgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mzgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzgol/subscriptions","organizations_url":"https://api.github.com/users/mzgol/orgs","repos_url":"https://api.github.com/users/mzgol/repos","events_url":"https://api.github.com/users/mzgol/events{/privacy}","received_events_url":"https://api.github.com/users/mzgol/received_events","type":"User","site_admin":false},"body":"That includes IE<8, Opera 12.x, Firefox<29, Safari<6.0 and some hacks\r\nfor old Blackberry.\r\n\r\nFixes gh-1836\r\nFixes gh-1701\r\nRefs gh-1815\r\nRefs gh-1820","created_at":"2014-11-04T15:49:58Z","updated_at":"2014-12-08T20:00:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea9e9250bf40d107645913c57f96e458c37b60e0","assignee":{"login":"mzgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mzgol","html_url":"https://github.com/mzgol","followers_url":"https://api.github.com/users/mzgol/followers","following_url":"https://api.github.com/users/mzgol/following{/other_user}","gists_url":"https://api.github.com/users/mzgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mzgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzgol/subscriptions","organizations_url":"https://api.github.com/users/mzgol/orgs","repos_url":"https://api.github.com/users/mzgol/repos","events_url":"https://api.github.com/users/mzgol/events{/privacy}","received_events_url":"https://api.github.com/users/mzgol/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/jquery/jquery/milestones/2","labels_url":"https://api.github.com/repos/jquery/jquery/milestones/2/labels","id":561714,"number":2,"title":"3.0.0","description":"","creator":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"open_issues":51,"closed_issues":32,"state":"open","created_at":"2014-02-07T02:09:56Z","updated_at":"2014-12-08T03:41:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jquery/jquery/pulls/1837/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery/pulls/1837/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jquery/jquery/issues/1837/comments","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/b1ab967a0f760d5f898a9d6b812b9b3432d6d3cb","head":{"label":"mzgol:drop-old","ref":"drop-old","sha":"b1ab967a0f760d5f898a9d6b812b9b3432d6d3cb","user":{"login":"mzgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mzgol","html_url":"https://github.com/mzgol","followers_url":"https://api.github.com/users/mzgol/followers","following_url":"https://api.github.com/users/mzgol/following{/other_user}","gists_url":"https://api.github.com/users/mzgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mzgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzgol/subscriptions","organizations_url":"https://api.github.com/users/mzgol/orgs","repos_url":"https://api.github.com/users/mzgol/repos","events_url":"https://api.github.com/users/mzgol/events{/privacy}","received_events_url":"https://api.github.com/users/mzgol/received_events","type":"User","site_admin":false},"repo":{"id":8512091,"name":"jquery","full_name":"mzgol/jquery","owner":{"login":"mzgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mzgol","html_url":"https://github.com/mzgol","followers_url":"https://api.github.com/users/mzgol/followers","following_url":"https://api.github.com/users/mzgol/following{/other_user}","gists_url":"https://api.github.com/users/mzgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mzgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzgol/subscriptions","organizations_url":"https://api.github.com/users/mzgol/orgs","repos_url":"https://api.github.com/users/mzgol/repos","events_url":"https://api.github.com/users/mzgol/events{/privacy}","received_events_url":"https://api.github.com/users/mzgol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mzgol/jquery","description":"jQuery JavaScript Library","fork":true,"url":"https://api.github.com/repos/mzgol/jquery","forks_url":"https://api.github.com/repos/mzgol/jquery/forks","keys_url":"https://api.github.com/repos/mzgol/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mzgol/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mzgol/jquery/teams","hooks_url":"https://api.github.com/repos/mzgol/jquery/hooks","issue_events_url":"https://api.github.com/repos/mzgol/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/mzgol/jquery/events","assignees_url":"https://api.github.com/repos/mzgol/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/mzgol/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/mzgol/jquery/tags","blobs_url":"https://api.github.com/repos/mzgol/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mzgol/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mzgol/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/mzgol/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mzgol/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/mzgol/jquery/languages","stargazers_url":"https://api.github.com/repos/mzgol/jquery/stargazers","contributors_url":"https://api.github.com/repos/mzgol/jquery/contributors","subscribers_url":"https://api.github.com/repos/mzgol/jquery/subscribers","subscription_url":"https://api.github.com/repos/mzgol/jquery/subscription","commits_url":"https://api.github.com/repos/mzgol/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/mzgol/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/mzgol/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/mzgol/jquery/issues/comments/{number}","contents_url":"https://api.github.com/repos/mzgol/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/mzgol/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mzgol/jquery/merges","archive_url":"https://api.github.com/repos/mzgol/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mzgol/jquery/downloads","issues_url":"https://api.github.com/repos/mzgol/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/mzgol/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/mzgol/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/mzgol/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mzgol/jquery/labels{/name}","releases_url":"https://api.github.com/repos/mzgol/jquery/releases{/id}","created_at":"2013-03-01T23:04:07Z","updated_at":"2014-05-07T21:22:52Z","pushed_at":"2014-12-08T13:08:37Z","git_url":"git://github.com/mzgol/jquery.git","ssh_url":"git@github.com:mzgol/jquery.git","clone_url":"https://github.com/mzgol/jquery.git","svn_url":"https://github.com/mzgol/jquery","homepage":"http://jquery.com/","size":22309,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:compat","ref":"compat","sha":"a467f8653a6fab2903148df80ab0ce9f5f4fd04f","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":167174,"name":"jquery","full_name":"jquery/jquery","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery","description":"jQuery JavaScript Library","fork":false,"url":"https://api.github.com/repos/jquery/jquery","forks_url":"https://api.github.com/repos/jquery/jquery/forks","keys_url":"https://api.github.com/repos/jquery/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery/teams","hooks_url":"https://api.github.com/repos/jquery/jquery/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery/events","assignees_url":"https://api.github.com/repos/jquery/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery/tags","blobs_url":"https://api.github.com/repos/jquery/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery/subscription","commits_url":"https://api.github.com/repos/jquery/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery/issues/comments/{number}","contents_url":"https://api.github.com/repos/jquery/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery/merges","archive_url":"https://api.github.com/repos/jquery/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery/downloads","issues_url":"https://api.github.com/repos/jquery/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery/releases{/id}","created_at":"2009-04-03T15:20:14Z","updated_at":"2014-12-08T19:33:12Z","pushed_at":"2014-12-08T06:27:35Z","git_url":"git://github.com/jquery/jquery.git","ssh_url":"git@github.com:jquery/jquery.git","clone_url":"https://github.com/jquery/jquery.git","svn_url":"https://github.com/jquery/jquery","homepage":"http://jquery.com/","size":34502,"stargazers_count":32740,"watchers_count":32740,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":7642,"mirror_url":null,"open_issues_count":108,"forks":7642,"open_issues":108,"watchers":32740,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/1837"},"html":{"href":"https://github.com/jquery/jquery/pull/1837"},"issue":{"href":"https://api.github.com/repos/jquery/jquery/issues/1837"},"comments":{"href":"https://api.github.com/repos/jquery/jquery/issues/1837/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery/pulls/1837/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery/pulls/1837/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery/statuses/b1ab967a0f760d5f898a9d6b812b9b3432d6d3cb"}}}}