GitHub PullRequestReviewCommentEvent at 2014-02-23 22:00:18
Repository: jquery
Actor: gibson042
Payload: {"comment":{"url":"https://api.github.com/repos/jquery/jquery/pulls/comments/9977949","id":9977949,"diff_hunk":"@@ -4,89 +4,43 @@ define([\n ], function( jQuery, support ) {\n \n (function() {\n-\tvar a, reliableHiddenOffsetsVal, boxSizingVal, boxSizingReliableVal,\n-\t\tpixelPositionVal,\n-\t\tdiv = document.createElement( \"div\" ),\n-\t\tcontainerStyles = \"border:0;width:0;height:0;position:absolute;top:0;left:-9999px\",\n-\t\t// Support: Firefox<29, Android 2.3 (Prefixed box-sizing versions).\n-\t\tdivReset =\n-\t\t\t\"-webkit-box-sizing:content-box;-moz-box-sizing:content-box;box-sizing:content-box;\" +\n-\t\t\t\"display:block;padding:0;margin:0;border:0\";\n+\t// Minified: b,c,d,e,f,g, h,i","path":"src/css/support.js","position":12,"original_position":12,"commit_id":"0f6a2bb0f6bb5753de81a3bc1f845fe8a4577dea","original_commit_id":"0f6a2bb0f6bb5753de81a3bc1f845fe8a4577dea","user":{"login":"gibson042","id":1199584,"avatar_url":"https://gravatar.com/avatar/f16d4602c1c90646438a0b534ff61889?d=https%3A%2F%2Fidenticons.github.com%2F359f00fbfd097202af2f58315ac01983.png&r=x","gravatar_id":"f16d4602c1c90646438a0b534ff61889","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"body":"The thing is, related code exists in multiple source files (and they're not even siblings). I want to leave _something_ to make it clear why a seemingly small future change might inordinately increase the size of jquery.min.js.gz. Would `Minify: var b,c,d,e,f,g, h,i` be a better syntax?","created_at":"2014-02-23T22:00:18Z","updated_at":"2014-02-23T22:00:18Z","html_url":"https://github.com/jquery/jquery/pull/1518#discussion_r9977949","pull_request_url":"https://api.github.com/repos/jquery/jquery/pulls/1518","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments/9977949"},"html":{"href":"https://github.com/jquery/jquery/pull/1518#discussion_r9977949"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery/pulls/1518"}}}}