GitHub PullRequestReviewCommentEvent at 2014-12-23 21:58:22
Repository: shopify-sinatra-app
Actor: eychu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls/comments/22237873","id":22237873,"diff_hunk":"@@ -171,40 +170,38 @@ def self.registered(app)\n       app.set :shared_secret, ENV['SHOPIFY_SHARED_SECRET']\n       app.set :secret, ENV['SECRET']\n \n-      app.use Rack::Flash, :sweep => true\n+      app.use Rack::Flash, sweep: true\n       app.use Rack::MethodOverride\n-      app.use Rack::Session::Cookie, :key => '#{base_url}.session',\n-                                     :path => '/',\n-                                     :secret => app.settings.secret,\n-                                     :expire_after => 60*30 # half an hour in seconds\n+      app.use Rack::Session::Cookie, key: '#{base_url}.session',\n+                                     path: '/',\n+                                     secret: app.settings.secret,\n+                                     expire_after: 60 * 30 # half an hour in seconds\n \n-      app.set :redis_url, ENV[\"REDISCLOUD_URL\"] || \"redis://localhost:6379/\"\n+      app.set :redis_url, ENV['REDISCLOUD_URL'] || 'redis://localhost:6379/'\n       redis_uri = URI.parse(app.settings.redis_url)\n-      Resque.redis = ::Redis.new(:host => redis_uri.host,\n-                               :port => redis_uri.port,\n-                               :password => redis_uri.password)\n-      Resque.redis.namespace = \"resque\"\n+      Resque.redis = ::Redis.new(host: redis_uri.host,\n+                                 port: redis_uri.port,\n+                                 password: redis_uri.password)\n+      Resque.redis.namespace = 'resque'\n       app.set :redis, app.settings.redis_url\n \n       app.use OmniAuth::Builder do\n         provider :shopify,\n-          app.settings.api_key,\n-          app.settings.shared_secret,\n-\n-          :scope => app.settings.scope,\n-\n-          :setup => lambda { |env|\n-            params = Rack::Utils.parse_query(env['QUERY_STRING'])\n-            site_url = \"https://#{params['shop']}\"\n-            env['omniauth.strategy'].options[:client_options][:site] = site_url\n-          }\n+                 app.settings.api_key,\n+                 app.settings.shared_secret,\n+                 scope: app.settings.scope,\n+                 setup: lambda { |env|\n+                   params = Rack::Utils.parse_query(env['QUERY_STRING'])\n+                   site_url = \"https://#{params['shop']}\"\n+                   env['omniauth.strategy'].options[:client_options][:site] = site_url\n+                 }","path":"lib/sinatra/shopify-sinatra-app.rb","position":172,"original_position":172,"commit_id":"8c4ac8e6fc252c024b00a197aca4ea22577cb288","original_commit_id":"505534903d291656cb07ce00fb20d192e9b1d363","user":{"login":"eychu","id":4329677,"avatar_url":"https://avatars.githubusercontent.com/u/4329677?v=3","gravatar_id":"","url":"https://api.github.com/users/eychu","html_url":"https://github.com/eychu","followers_url":"https://api.github.com/users/eychu/followers","following_url":"https://api.github.com/users/eychu/following{/other_user}","gists_url":"https://api.github.com/users/eychu/gists{/gist_id}","starred_url":"https://api.github.com/users/eychu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eychu/subscriptions","organizations_url":"https://api.github.com/users/eychu/orgs","repos_url":"https://api.github.com/users/eychu/repos","events_url":"https://api.github.com/users/eychu/events{/privacy}","received_events_url":"https://api.github.com/users/eychu/received_events","type":"User","site_admin":false},"body":"fixing here https://github.com/eychu/shopify-sinatra-app/commit/8c4ac8e6fc252c024b00a197aca4ea22577cb288","created_at":"2014-12-23T21:58:22Z","updated_at":"2014-12-23T21:58:22Z","html_url":"https://github.com/pickle27/shopify-sinatra-app/pull/3#discussion_r22237873","pull_request_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls/comments/22237873"},"html":{"href":"https://github.com/pickle27/shopify-sinatra-app/pull/3#discussion_r22237873"},"pull_request":{"href":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls/3","id":26530037,"html_url":"https://github.com/pickle27/shopify-sinatra-app/pull/3","diff_url":"https://github.com/pickle27/shopify-sinatra-app/pull/3.diff","patch_url":"https://github.com/pickle27/shopify-sinatra-app/pull/3.patch","issue_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/issues/3","number":3,"state":"open","locked":false,"title":"standardize ruby code","user":{"login":"eychu","id":4329677,"avatar_url":"https://avatars.githubusercontent.com/u/4329677?v=3","gravatar_id":"","url":"https://api.github.com/users/eychu","html_url":"https://github.com/eychu","followers_url":"https://api.github.com/users/eychu/followers","following_url":"https://api.github.com/users/eychu/following{/other_user}","gists_url":"https://api.github.com/users/eychu/gists{/gist_id}","starred_url":"https://api.github.com/users/eychu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eychu/subscriptions","organizations_url":"https://api.github.com/users/eychu/orgs","repos_url":"https://api.github.com/users/eychu/repos","events_url":"https://api.github.com/users/eychu/events{/privacy}","received_events_url":"https://api.github.com/users/eychu/received_events","type":"User","site_admin":false},"body":"by rubocop (https://github.com/bbatsov/rubocop)","created_at":"2014-12-23T20:17:48Z","updated_at":"2014-12-23T21:58:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c78e0e927cfacccf3cfb9b1339c41df03a1848d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls/3/commits","review_comments_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls/3/comments","review_comment_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/issues/3/comments","statuses_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/statuses/8c4ac8e6fc252c024b00a197aca4ea22577cb288","head":{"label":"eychu:master","ref":"master","sha":"8c4ac8e6fc252c024b00a197aca4ea22577cb288","user":{"login":"eychu","id":4329677,"avatar_url":"https://avatars.githubusercontent.com/u/4329677?v=3","gravatar_id":"","url":"https://api.github.com/users/eychu","html_url":"https://github.com/eychu","followers_url":"https://api.github.com/users/eychu/followers","following_url":"https://api.github.com/users/eychu/following{/other_user}","gists_url":"https://api.github.com/users/eychu/gists{/gist_id}","starred_url":"https://api.github.com/users/eychu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eychu/subscriptions","organizations_url":"https://api.github.com/users/eychu/orgs","repos_url":"https://api.github.com/users/eychu/repos","events_url":"https://api.github.com/users/eychu/events{/privacy}","received_events_url":"https://api.github.com/users/eychu/received_events","type":"User","site_admin":false},"repo":{"id":28380678,"name":"shopify-sinatra-app","full_name":"eychu/shopify-sinatra-app","owner":{"login":"eychu","id":4329677,"avatar_url":"https://avatars.githubusercontent.com/u/4329677?v=3","gravatar_id":"","url":"https://api.github.com/users/eychu","html_url":"https://github.com/eychu","followers_url":"https://api.github.com/users/eychu/followers","following_url":"https://api.github.com/users/eychu/following{/other_user}","gists_url":"https://api.github.com/users/eychu/gists{/gist_id}","starred_url":"https://api.github.com/users/eychu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eychu/subscriptions","organizations_url":"https://api.github.com/users/eychu/orgs","repos_url":"https://api.github.com/users/eychu/repos","events_url":"https://api.github.com/users/eychu/events{/privacy}","received_events_url":"https://api.github.com/users/eychu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eychu/shopify-sinatra-app","description":"\"A classy shopify app\"","fork":true,"url":"https://api.github.com/repos/eychu/shopify-sinatra-app","forks_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/forks","keys_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/teams","hooks_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/hooks","issue_events_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/issues/events{/number}","events_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/events","assignees_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/assignees{/user}","branches_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/branches{/branch}","tags_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/tags","blobs_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/statuses/{sha}","languages_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/languages","stargazers_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/stargazers","contributors_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/contributors","subscribers_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/subscribers","subscription_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/subscription","commits_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/issues/comments/{number}","contents_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/contents/{+path}","compare_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/merges","archive_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/downloads","issues_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/issues{/number}","pulls_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/pulls{/number}","milestones_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/milestones{/number}","notifications_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/labels{/name}","releases_url":"https://api.github.com/repos/eychu/shopify-sinatra-app/releases{/id}","created_at":"2014-12-23T06:00:27Z","updated_at":"2014-12-23T21:55:47Z","pushed_at":"2014-12-23T21:55:46Z","git_url":"git://github.com/eychu/shopify-sinatra-app.git","ssh_url":"git@github.com:eychu/shopify-sinatra-app.git","clone_url":"https://github.com/eychu/shopify-sinatra-app.git","svn_url":"https://github.com/eychu/shopify-sinatra-app","homepage":null,"size":342,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pickle27:master","ref":"master","sha":"f061ad6432fe951233dfbfb88b207fa7543dc237","user":{"login":"pickle27","id":1965489,"avatar_url":"https://avatars.githubusercontent.com/u/1965489?v=3","gravatar_id":"","url":"https://api.github.com/users/pickle27","html_url":"https://github.com/pickle27","followers_url":"https://api.github.com/users/pickle27/followers","following_url":"https://api.github.com/users/pickle27/following{/other_user}","gists_url":"https://api.github.com/users/pickle27/gists{/gist_id}","starred_url":"https://api.github.com/users/pickle27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pickle27/subscriptions","organizations_url":"https://api.github.com/users/pickle27/orgs","repos_url":"https://api.github.com/users/pickle27/repos","events_url":"https://api.github.com/users/pickle27/events{/privacy}","received_events_url":"https://api.github.com/users/pickle27/received_events","type":"User","site_admin":false},"repo":{"id":20626669,"name":"shopify-sinatra-app","full_name":"pickle27/shopify-sinatra-app","owner":{"login":"pickle27","id":1965489,"avatar_url":"https://avatars.githubusercontent.com/u/1965489?v=3","gravatar_id":"","url":"https://api.github.com/users/pickle27","html_url":"https://github.com/pickle27","followers_url":"https://api.github.com/users/pickle27/followers","following_url":"https://api.github.com/users/pickle27/following{/other_user}","gists_url":"https://api.github.com/users/pickle27/gists{/gist_id}","starred_url":"https://api.github.com/users/pickle27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pickle27/subscriptions","organizations_url":"https://api.github.com/users/pickle27/orgs","repos_url":"https://api.github.com/users/pickle27/repos","events_url":"https://api.github.com/users/pickle27/events{/privacy}","received_events_url":"https://api.github.com/users/pickle27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pickle27/shopify-sinatra-app","description":"\"A classy shopify app\"","fork":false,"url":"https://api.github.com/repos/pickle27/shopify-sinatra-app","forks_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/forks","keys_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/teams","hooks_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/hooks","issue_events_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/issues/events{/number}","events_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/events","assignees_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/assignees{/user}","branches_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/branches{/branch}","tags_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/tags","blobs_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/statuses/{sha}","languages_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/languages","stargazers_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/stargazers","contributors_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/contributors","subscribers_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/subscribers","subscription_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/subscription","commits_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/issues/comments/{number}","contents_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/contents/{+path}","compare_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/merges","archive_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/downloads","issues_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/issues{/number}","pulls_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls{/number}","milestones_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/milestones{/number}","notifications_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/labels{/name}","releases_url":"https://api.github.com/repos/pickle27/shopify-sinatra-app/releases{/id}","created_at":"2014-06-08T21:14:30Z","updated_at":"2014-12-23T17:28:21Z","pushed_at":"2014-12-23T17:28:21Z","git_url":"git://github.com/pickle27/shopify-sinatra-app.git","ssh_url":"git@github.com:pickle27/shopify-sinatra-app.git","clone_url":"https://github.com/pickle27/shopify-sinatra-app.git","svn_url":"https://github.com/pickle27/shopify-sinatra-app","homepage":null,"size":342,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls/3"},"html":{"href":"https://github.com/pickle27/shopify-sinatra-app/pull/3"},"issue":{"href":"https://api.github.com/repos/pickle27/shopify-sinatra-app/issues/3"},"comments":{"href":"https://api.github.com/repos/pickle27/shopify-sinatra-app/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pickle27/shopify-sinatra-app/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/pickle27/shopify-sinatra-app/statuses/8c4ac8e6fc252c024b00a197aca4ea22577cb288"}}}}