GitHub PullRequestReviewCommentEvent at 2014-01-08 14:43:16
Repository: riak_core
Actor: seancribbs
Payload: {"comment":{"url":"https://api.github.com/repos/basho/riak_core/pulls/comments/8725686","id":8725686,"diff_hunk":"@@ -221,70 +70,62 @@\n %% intra-cluster data handoff.\n {mapping, \"handoff.port\", \"riak_core.handoff_port\", [\n   {default, {{handoff_port}} },\n-  {datatype, integer}\n+  {datatype, integer},\n+  {level, advanced}\n ]}.\n \n %% @doc To encrypt riak_core intra-cluster data handoff traffic,\n-%% uncomment the following line and edit its path to an\n-%% appropriate certfile and keyfile.  (This example uses a\n-%% single file with both items concatenated together.)\n+%% uncomment the following line and edit its path to an appropriate\n+%% certfile and keyfile.  (This example uses a single file with both\n+%% items concatenated together.)\n {mapping, \"handoff.ssl.certfile\", \"riak_core.handoff_ssl_options.certfile\", [\n-  {commented, \"/tmp/erlserver.pem\"}\n+%%  {commented, \"/tmp/erlserver.pem\"},","path":"priv/riak_core.schema","position":265,"original_position":245,"commit_id":"a00b295da9e421291273eca1d398f68c91070f4d","original_commit_id":"878aed00c155df21e273d9e05c68ca0f322570ee","user":{"login":"seancribbs","id":1772,"avatar_url":"https://gravatar.com/avatar/ce461b57b6a1f65ce5b6cc1c124673e3?d=https%3A%2F%2Fidenticons.github.com%2F299570476c6f0309545110c592b6a63b.png&r=x","gravatar_id":"ce461b57b6a1f65ce5b6cc1c124673e3","url":"https://api.github.com/users/seancribbs","html_url":"https://github.com/seancribbs","followers_url":"https://api.github.com/users/seancribbs/followers","following_url":"https://api.github.com/users/seancribbs/following{/other_user}","gists_url":"https://api.github.com/users/seancribbs/gists{/gist_id}","starred_url":"https://api.github.com/users/seancribbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seancribbs/subscriptions","organizations_url":"https://api.github.com/users/seancribbs/orgs","repos_url":"https://api.github.com/users/seancribbs/repos","events_url":"https://api.github.com/users/seancribbs/events{/privacy}","received_events_url":"https://api.github.com/users/seancribbs/received_events","type":"User","site_admin":false},"body":". @lucperkins also mentioned this setting, perhaps we could make it point to something more sensible even though it is commented? e.g.\r\n\r\n```erlang\r\n{commented, \"{{platform_etc_dir}}/handoff.pem\"}\r\n```","created_at":"2014-01-08T14:43:16Z","updated_at":"2014-01-08T14:43:16Z","html_url":"https://github.com/basho/riak_core/pull/502#discussion_r8725686","pull_request_url":"https://api.github.com/repos/basho/riak_core/pulls/502","_links":{"self":{"href":"https://api.github.com/repos/basho/riak_core/pulls/comments/8725686"},"html":{"href":"https://github.com/basho/riak_core/pull/502#discussion_r8725686"},"pull_request":{"href":"https://api.github.com/repos/basho/riak_core/pulls/502"}}}}