GitHub PullRequestReviewCommentEvent at 2014-05-21 21:21:26
Repository: Beluga
Actor: Masadow
Payload: {"comment":{"url":"https://api.github.com/repos/HaxeBeluga/Beluga/pulls/comments/12923746","id":12923746,"diff_hunk":"@@ -34,7 +34,8 @@ class APIBuilder\n \t\t\t\t\tpack: [\"beluga\", \"module\", module.name.toLowerCase(), \"api\"],\n \t\t\t\t\tname: module.name.charAt(0).toUpperCase() + module.name.substr(1) + \"Api\"\n \t\t\t\t},\n-\t\t\t\t[macro beluga, macro cast ModuleLoader.getModuleInstanceByName($v{module.name})])\n+\t\t\t\t[])\n+\t\t\t\t//[macro beluga, macro cast ModuleLoader.getModuleInstanceByName($v{module.name})])","path":"beluga/core/api/APIBuilder.hx","position":6,"original_position":6,"commit_id":"565c4e8a59359f75341a518bed8fbe1e284fd0d0","original_commit_id":"565c4e8a59359f75341a518bed8fbe1e284fd0d0","user":{"login":"Masadow","id":2227736,"avatar_url":"https://avatars.githubusercontent.com/u/2227736?","gravatar_id":"a279c153f484f6d9656d41c41e82f45f","url":"https://api.github.com/users/Masadow","html_url":"https://github.com/Masadow","followers_url":"https://api.github.com/users/Masadow/followers","following_url":"https://api.github.com/users/Masadow/following{/other_user}","gists_url":"https://api.github.com/users/Masadow/gists{/gist_id}","starred_url":"https://api.github.com/users/Masadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Masadow/subscriptions","organizations_url":"https://api.github.com/users/Masadow/orgs","repos_url":"https://api.github.com/users/Masadow/repos","events_url":"https://api.github.com/users/Masadow/events{/privacy}","received_events_url":"https://api.github.com/users/Masadow/received_events","type":"User","site_admin":false},"body":"You mean why I didn't deleted the comment ? I should definitely have done it and will fix it.\r\n\r\nI changed the initialisation of modules because of Neko. You can't pass an object which is still constructed as a parameter of another construct, the reference will be lost.","created_at":"2014-05-21T21:21:26Z","updated_at":"2014-05-21T21:21:26Z","html_url":"https://github.com/HaxeBeluga/Beluga/pull/115#discussion_r12923746","pull_request_url":"https://api.github.com/repos/HaxeBeluga/Beluga/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/HaxeBeluga/Beluga/pulls/comments/12923746"},"html":{"href":"https://github.com/HaxeBeluga/Beluga/pull/115#discussion_r12923746"},"pull_request":{"href":"https://api.github.com/repos/HaxeBeluga/Beluga/pulls/115"}}}}