GitHub PullRequestReviewCommentEvent at 2014-03-06 16:20:20
Repository: markdown
Actor: maximal
Payload: {"comment":{"url":"https://api.github.com/repos/cebe/markdown/pulls/comments/10348147","id":10348147,"diff_hunk":"@@ -290,6 +290,8 @@ private function parseInlineWithWhitespace($text)\n \t\t\t\tbreak;\n \t\t\t}\n \t\t\t// switch between found whitespace or marker\n+\t\t\t$pos = false;\n+\t\t\t$matchedMarkers = [];","path":"Parser.php","position":null,"original_position":91,"commit_id":"dc254edcabf478af2d640be37fbe292e9ceb36fe","original_commit_id":"aa5693166937ad4e6cd366ea3249acb84234dea1","user":{"login":"maximal","id":980679,"avatar_url":"https://gravatar.com/avatar/31ceb4e3685510931b4ba4a4effb7c4e?d=https%3A%2F%2Fidenticons.github.com%2Fcc172759a983c0d2f0fa59449f0e4a95.png&r=x","gravatar_id":"31ceb4e3685510931b4ba4a4effb7c4e","url":"https://api.github.com/users/maximal","html_url":"https://github.com/maximal","followers_url":"https://api.github.com/users/maximal/followers","following_url":"https://api.github.com/users/maximal/following{/other_user}","gists_url":"https://api.github.com/users/maximal/gists{/gist_id}","starred_url":"https://api.github.com/users/maximal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximal/subscriptions","organizations_url":"https://api.github.com/users/maximal/orgs","repos_url":"https://api.github.com/users/maximal/repos","events_url":"https://api.github.com/users/maximal/events{/privacy}","received_events_url":"https://api.github.com/users/maximal/received_events","type":"User","site_admin":false},"body":"By the way, another point.\r\nIt’s not beautiful code where variables are set in one (inner, `if`) scope and used in another (outer). Yes, PHP allows to do that, but I’d aware of it.\r\nIf project was mine I’d declare variables in common outer scope of their using.","created_at":"2014-03-06T16:20:20Z","updated_at":"2014-03-06T16:20:20Z","html_url":"https://github.com/cebe/markdown/pull/37#discussion_r10348147","pull_request_url":"https://api.github.com/repos/cebe/markdown/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/cebe/markdown/pulls/comments/10348147"},"html":{"href":"https://github.com/cebe/markdown/pull/37#discussion_r10348147"},"pull_request":{"href":"https://api.github.com/repos/cebe/markdown/pulls/37"}}}}