GitHub PullRequestReviewCommentEvent at 2014-09-03 18:56:47
Repository: open-transit-indicators
Actor: lossyrob
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls/comments/17071886","id":17071886,"diff_hunk":"@@ -5,7 +5,7 @@ import spray.util.LoggingContext\n import spray.routing.ExceptionHandler\n import spray.http.StatusCodes._\n \n-class GeoTrellisServiceActor extends GeoTrellisService with Actor {\n+class GeoTrellisServiceActor extends GeoTrellisServiceRoute with Actor with ProductionGtfsDatabase {","path":"geotrellis/src/main/scala/GeoTrellisServiceActor.scala","position":5,"original_position":5,"commit_id":"b3665a43eb73a7b5f1c82cb003ea1371666b78e1","original_commit_id":"b3665a43eb73a7b5f1c82cb003ea1371666b78e1","user":{"login":"lossyrob","id":2320142,"avatar_url":"https://avatars.githubusercontent.com/u/2320142?v=2","gravatar_id":"c8a092133d7280956d85a40a0279b24c","url":"https://api.github.com/users/lossyrob","html_url":"https://github.com/lossyrob","followers_url":"https://api.github.com/users/lossyrob/followers","following_url":"https://api.github.com/users/lossyrob/following{/other_user}","gists_url":"https://api.github.com/users/lossyrob/gists{/gist_id}","starred_url":"https://api.github.com/users/lossyrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lossyrob/subscriptions","organizations_url":"https://api.github.com/users/lossyrob/orgs","repos_url":"https://api.github.com/users/lossyrob/repos","events_url":"https://api.github.com/users/lossyrob/events{/privacy}","received_events_url":"https://api.github.com/users/lossyrob/received_events","type":"User","site_admin":false},"body":"This is the case of using the Cake pattern to bake in the Production database into the actual GeoTrellisServiceActor.","created_at":"2014-09-03T18:56:47Z","updated_at":"2014-09-03T18:56:47Z","html_url":"https://github.com/WorldBank-Transport/open-transit-indicators/pull/132#discussion_r17071886","pull_request_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls/132","_links":{"self":{"href":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls/comments/17071886"},"html":{"href":"https://github.com/WorldBank-Transport/open-transit-indicators/pull/132#discussion_r17071886"},"pull_request":{"href":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls/132"}}},"pull_request":{"url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls/132","id":20696733,"html_url":"https://github.com/WorldBank-Transport/open-transit-indicators/pull/132","diff_url":"https://github.com/WorldBank-Transport/open-transit-indicators/pull/132.diff","patch_url":"https://github.com/WorldBank-Transport/open-transit-indicators/pull/132.patch","issue_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/issues/132","number":132,"state":"open","locked":false,"title":"Upgrade slick to 2.1.0","user":{"login":"lossyrob","id":2320142,"avatar_url":"https://avatars.githubusercontent.com/u/2320142?v=2","gravatar_id":"c8a092133d7280956d85a40a0279b24c","url":"https://api.github.com/users/lossyrob","html_url":"https://github.com/lossyrob","followers_url":"https://api.github.com/users/lossyrob/followers","following_url":"https://api.github.com/users/lossyrob/following{/other_user}","gists_url":"https://api.github.com/users/lossyrob/gists{/gist_id}","starred_url":"https://api.github.com/users/lossyrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lossyrob/subscriptions","organizations_url":"https://api.github.com/users/lossyrob/orgs","repos_url":"https://api.github.com/users/lossyrob/repos","events_url":"https://api.github.com/users/lossyrob/events{/privacy}","received_events_url":"https://api.github.com/users/lossyrob/received_events","type":"User","site_admin":false},"body":"Also contains some starts to refactors. Making this PR now as to match up with the upgrade to slick 2.1.0 in GeoTrellis and the gtfs-parser project.\r\n\r\nFeel free to ask questions about the work-in-progress refactor on this PR. I'm making comments to point out a couple of things that I changed.","created_at":"2014-09-03T18:37:17Z","updated_at":"2014-09-03T18:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f72665810dda8adb068684b27b40819d95b9ba3c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls/132/commits","review_comments_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls/132/comments","review_comment_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls/comments/{number}","comments_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/issues/132/comments","statuses_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/statuses/b3665a43eb73a7b5f1c82cb003ea1371666b78e1","head":{"label":"lossyrob:transitshed-indicator","ref":"transitshed-indicator","sha":"b3665a43eb73a7b5f1c82cb003ea1371666b78e1","user":{"login":"lossyrob","id":2320142,"avatar_url":"https://avatars.githubusercontent.com/u/2320142?v=2","gravatar_id":"c8a092133d7280956d85a40a0279b24c","url":"https://api.github.com/users/lossyrob","html_url":"https://github.com/lossyrob","followers_url":"https://api.github.com/users/lossyrob/followers","following_url":"https://api.github.com/users/lossyrob/following{/other_user}","gists_url":"https://api.github.com/users/lossyrob/gists{/gist_id}","starred_url":"https://api.github.com/users/lossyrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lossyrob/subscriptions","organizations_url":"https://api.github.com/users/lossyrob/orgs","repos_url":"https://api.github.com/users/lossyrob/repos","events_url":"https://api.github.com/users/lossyrob/events{/privacy}","received_events_url":"https://api.github.com/users/lossyrob/received_events","type":"User","site_admin":false},"repo":{"id":23328852,"name":"open-transit-indicators","full_name":"lossyrob/open-transit-indicators","owner":{"login":"lossyrob","id":2320142,"avatar_url":"https://avatars.githubusercontent.com/u/2320142?v=2","gravatar_id":"c8a092133d7280956d85a40a0279b24c","url":"https://api.github.com/users/lossyrob","html_url":"https://github.com/lossyrob","followers_url":"https://api.github.com/users/lossyrob/followers","following_url":"https://api.github.com/users/lossyrob/following{/other_user}","gists_url":"https://api.github.com/users/lossyrob/gists{/gist_id}","starred_url":"https://api.github.com/users/lossyrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lossyrob/subscriptions","organizations_url":"https://api.github.com/users/lossyrob/orgs","repos_url":"https://api.github.com/users/lossyrob/repos","events_url":"https://api.github.com/users/lossyrob/events{/privacy}","received_events_url":"https://api.github.com/users/lossyrob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lossyrob/open-transit-indicators","description":"An open-source tool to support transport agencies in planning and managing public transit systems","fork":true,"url":"https://api.github.com/repos/lossyrob/open-transit-indicators","forks_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/forks","keys_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/teams","hooks_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/hooks","issue_events_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/issues/events{/number}","events_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/events","assignees_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/assignees{/user}","branches_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/branches{/branch}","tags_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/tags","blobs_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/git/refs{/sha}","trees_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/statuses/{sha}","languages_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/languages","stargazers_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/stargazers","contributors_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/contributors","subscribers_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/subscribers","subscription_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/subscription","commits_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/commits{/sha}","git_commits_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/git/commits{/sha}","comments_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/comments{/number}","issue_comment_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/issues/comments/{number}","contents_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/contents/{+path}","compare_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/merges","archive_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/downloads","issues_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/issues{/number}","pulls_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/pulls{/number}","milestones_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/milestones{/number}","notifications_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/labels{/name}","releases_url":"https://api.github.com/repos/lossyrob/open-transit-indicators/releases{/id}","created_at":"2014-08-25T21:10:32Z","updated_at":"2014-08-15T21:47:13Z","pushed_at":"2014-09-03T18:49:38Z","git_url":"git://github.com/lossyrob/open-transit-indicators.git","ssh_url":"git@github.com:lossyrob/open-transit-indicators.git","clone_url":"https://github.com/lossyrob/open-transit-indicators.git","svn_url":"https://github.com/lossyrob/open-transit-indicators","homepage":null,"size":2342,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"WorldBank-Transport:develop","ref":"develop","sha":"a4d305a486c910906f2066d6a9c4ce21df9735c4","user":{"login":"WorldBank-Transport","id":5641611,"avatar_url":"https://avatars.githubusercontent.com/u/5641611?v=2","gravatar_id":"bd29d1a306c8096286169c2deb377970","url":"https://api.github.com/users/WorldBank-Transport","html_url":"https://github.com/WorldBank-Transport","followers_url":"https://api.github.com/users/WorldBank-Transport/followers","following_url":"https://api.github.com/users/WorldBank-Transport/following{/other_user}","gists_url":"https://api.github.com/users/WorldBank-Transport/gists{/gist_id}","starred_url":"https://api.github.com/users/WorldBank-Transport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WorldBank-Transport/subscriptions","organizations_url":"https://api.github.com/users/WorldBank-Transport/orgs","repos_url":"https://api.github.com/users/WorldBank-Transport/repos","events_url":"https://api.github.com/users/WorldBank-Transport/events{/privacy}","received_events_url":"https://api.github.com/users/WorldBank-Transport/received_events","type":"Organization","site_admin":false},"repo":{"id":18368297,"name":"open-transit-indicators","full_name":"WorldBank-Transport/open-transit-indicators","owner":{"login":"WorldBank-Transport","id":5641611,"avatar_url":"https://avatars.githubusercontent.com/u/5641611?v=2","gravatar_id":"bd29d1a306c8096286169c2deb377970","url":"https://api.github.com/users/WorldBank-Transport","html_url":"https://github.com/WorldBank-Transport","followers_url":"https://api.github.com/users/WorldBank-Transport/followers","following_url":"https://api.github.com/users/WorldBank-Transport/following{/other_user}","gists_url":"https://api.github.com/users/WorldBank-Transport/gists{/gist_id}","starred_url":"https://api.github.com/users/WorldBank-Transport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WorldBank-Transport/subscriptions","organizations_url":"https://api.github.com/users/WorldBank-Transport/orgs","repos_url":"https://api.github.com/users/WorldBank-Transport/repos","events_url":"https://api.github.com/users/WorldBank-Transport/events{/privacy}","received_events_url":"https://api.github.com/users/WorldBank-Transport/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WorldBank-Transport/open-transit-indicators","description":"An open-source tool to support transport agencies in planning and managing public transit systems","fork":false,"url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators","forks_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/forks","keys_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/teams","hooks_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/hooks","issue_events_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/issues/events{/number}","events_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/events","assignees_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/assignees{/user}","branches_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/branches{/branch}","tags_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/tags","blobs_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/git/refs{/sha}","trees_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/statuses/{sha}","languages_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/languages","stargazers_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/stargazers","contributors_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/contributors","subscribers_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/subscribers","subscription_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/subscription","commits_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/commits{/sha}","git_commits_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/git/commits{/sha}","comments_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/comments{/number}","issue_comment_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/issues/comments/{number}","contents_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/contents/{+path}","compare_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/merges","archive_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/downloads","issues_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/issues{/number}","pulls_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls{/number}","milestones_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/milestones{/number}","notifications_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/labels{/name}","releases_url":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/releases{/id}","created_at":"2014-04-02T14:01:04Z","updated_at":"2014-09-02T15:02:08Z","pushed_at":"2014-09-03T18:12:19Z","git_url":"git://github.com/WorldBank-Transport/open-transit-indicators.git","ssh_url":"git@github.com:WorldBank-Transport/open-transit-indicators.git","clone_url":"https://github.com/WorldBank-Transport/open-transit-indicators.git","svn_url":"https://github.com/WorldBank-Transport/open-transit-indicators","homepage":null,"size":6831,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls/132"},"html":{"href":"https://github.com/WorldBank-Transport/open-transit-indicators/pull/132"},"issue":{"href":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/issues/132"},"comments":{"href":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/WorldBank-Transport/open-transit-indicators/statuses/b3665a43eb73a7b5f1c82cb003ea1371666b78e1"}}}}