GitHub PullRequestReviewCommentEvent at 2014-07-03 15:12:08
Repository: immuno
Actor: iskandr
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hammerlab/immuno/pulls/comments/14518731","id":14518731,"diff_hunk":"@@ -279,38 +265,55 @@ function renderEpitopeScores(epitopes) {\n }\n \n function renderEpitopeSequence(epitopes) {\n+  var peptide = epitopes.node().parentNode.__data__,\n+      mutStart = peptide.mutStart,\n+      mutEnd = peptide.mutEnd;\n+  console.log(mutStart, mutEnd);\n   epitopes.selectAll('.ep-sequence')\n       .data(function(d) { return d.sequence.split(''); })\n     .enter().append('text')\n       .text(function(d, i) { return d; })\n       .style('font-size', '1.1em')\n-      .attr('class', 'ep-sequence')\n+      .attr('class', function(d, i) {\n+        var idx = this.parentNode.__data__.start + i;","path":"immuno/viz/peptides.js","position":204,"original_position":204,"commit_id":"e001e77cbcc9d5463ff43ae9b114c126327f9bc7","original_commit_id":"e001e77cbcc9d5463ff43ae9b114c126327f9bc7","user":{"login":"iskandr","id":48441,"avatar_url":"https://avatars.githubusercontent.com/u/48441?","gravatar_id":"d609a555932e36684370a2ba96924389","url":"https://api.github.com/users/iskandr","html_url":"https://github.com/iskandr","followers_url":"https://api.github.com/users/iskandr/followers","following_url":"https://api.github.com/users/iskandr/following{/other_user}","gists_url":"https://api.github.com/users/iskandr/gists{/gist_id}","starred_url":"https://api.github.com/users/iskandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iskandr/subscriptions","organizations_url":"https://api.github.com/users/iskandr/orgs","repos_url":"https://api.github.com/users/iskandr/repos","events_url":"https://api.github.com/users/iskandr/events{/privacy}","received_events_url":"https://api.github.com/users/iskandr/received_events","type":"User","site_admin":false},"body":"As an outside to this code I have a really hard time figuring out what \"this\" refers to, much less a bunch of indirection like \"this.parentNode.__data__\". Any chance you could comment it? ","created_at":"2014-07-03T15:12:08Z","updated_at":"2014-07-03T15:12:08Z","html_url":"https://github.com/hammerlab/immuno/pull/103#discussion_r14518731","pull_request_url":"https://api.github.com/repos/hammerlab/immuno/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/hammerlab/immuno/pulls/comments/14518731"},"html":{"href":"https://github.com/hammerlab/immuno/pull/103#discussion_r14518731"},"pull_request":{"href":"https://api.github.com/repos/hammerlab/immuno/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/hammerlab/immuno/pulls/103","id":17925329,"html_url":"https://github.com/hammerlab/immuno/pull/103","diff_url":"https://github.com/hammerlab/immuno/pull/103.diff","patch_url":"https://github.com/hammerlab/immuno/pull/103.patch","issue_url":"https://api.github.com/repos/hammerlab/immuno/issues/103","number":103,"state":"open","title":"Improve styling and fix bugs","user":{"login":"ihodes","id":167803,"avatar_url":"https://avatars.githubusercontent.com/u/167803?","gravatar_id":"5406fa6d405a74abaacf516ed0c61e71","url":"https://api.github.com/users/ihodes","html_url":"https://github.com/ihodes","followers_url":"https://api.github.com/users/ihodes/followers","following_url":"https://api.github.com/users/ihodes/following{/other_user}","gists_url":"https://api.github.com/users/ihodes/gists{/gist_id}","starred_url":"https://api.github.com/users/ihodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihodes/subscriptions","organizations_url":"https://api.github.com/users/ihodes/orgs","repos_url":"https://api.github.com/users/ihodes/repos","events_url":"https://api.github.com/users/ihodes/events{/privacy}","received_events_url":"https://api.github.com/users/ihodes/received_events","type":"User","site_admin":false},"body":"Fixes #96 fixes #92 fixes #87 fixes #94 fixes #74 \r\n\r\nColor non-mutated epitopes grey, change coloring to yellow, color\r\nepitope sequence mutations red as well.\r\n\r\nCode cleanup as well.","created_at":"2014-07-03T04:31:59Z","updated_at":"2014-07-03T15:12:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cf8dd48c77e6c59fbcadbc342bfef3c6e263e63","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hammerlab/immuno/pulls/103/commits","review_comments_url":"https://api.github.com/repos/hammerlab/immuno/pulls/103/comments","review_comment_url":"https://api.github.com/repos/hammerlab/immuno/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hammerlab/immuno/issues/103/comments","statuses_url":"https://api.github.com/repos/hammerlab/immuno/statuses/e001e77cbcc9d5463ff43ae9b114c126327f9bc7","head":{"label":"hammerlab:different_epitope_colors_feature_87","ref":"different_epitope_colors_feature_87","sha":"e001e77cbcc9d5463ff43ae9b114c126327f9bc7","user":{"login":"hammerlab","id":6563873,"avatar_url":"https://avatars.githubusercontent.com/u/6563873?","gravatar_id":"b2ae0016d5cb6ef6df51cea0452b7c04","url":"https://api.github.com/users/hammerlab","html_url":"https://github.com/hammerlab","followers_url":"https://api.github.com/users/hammerlab/followers","following_url":"https://api.github.com/users/hammerlab/following{/other_user}","gists_url":"https://api.github.com/users/hammerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/hammerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammerlab/subscriptions","organizations_url":"https://api.github.com/users/hammerlab/orgs","repos_url":"https://api.github.com/users/hammerlab/repos","events_url":"https://api.github.com/users/hammerlab/events{/privacy}","received_events_url":"https://api.github.com/users/hammerlab/received_events","type":"Organization","site_admin":false},"repo":{"id":17490575,"name":"immuno","full_name":"hammerlab/immuno","owner":{"login":"hammerlab","id":6563873,"avatar_url":"https://avatars.githubusercontent.com/u/6563873?","gravatar_id":"b2ae0016d5cb6ef6df51cea0452b7c04","url":"https://api.github.com/users/hammerlab","html_url":"https://github.com/hammerlab","followers_url":"https://api.github.com/users/hammerlab/followers","following_url":"https://api.github.com/users/hammerlab/following{/other_user}","gists_url":"https://api.github.com/users/hammerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/hammerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammerlab/subscriptions","organizations_url":"https://api.github.com/users/hammerlab/orgs","repos_url":"https://api.github.com/users/hammerlab/repos","events_url":"https://api.github.com/users/hammerlab/events{/privacy}","received_events_url":"https://api.github.com/users/hammerlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hammerlab/immuno","description":"Use somatic mutations to choose a personalized cancer vaccine (tumor-specific immunogenic peptides)","fork":false,"url":"https://api.github.com/repos/hammerlab/immuno","forks_url":"https://api.github.com/repos/hammerlab/immuno/forks","keys_url":"https://api.github.com/repos/hammerlab/immuno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hammerlab/immuno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hammerlab/immuno/teams","hooks_url":"https://api.github.com/repos/hammerlab/immuno/hooks","issue_events_url":"https://api.github.com/repos/hammerlab/immuno/issues/events{/number}","events_url":"https://api.github.com/repos/hammerlab/immuno/events","assignees_url":"https://api.github.com/repos/hammerlab/immuno/assignees{/user}","branches_url":"https://api.github.com/repos/hammerlab/immuno/branches{/branch}","tags_url":"https://api.github.com/repos/hammerlab/immuno/tags","blobs_url":"https://api.github.com/repos/hammerlab/immuno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hammerlab/immuno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hammerlab/immuno/git/refs{/sha}","trees_url":"https://api.github.com/repos/hammerlab/immuno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hammerlab/immuno/statuses/{sha}","languages_url":"https://api.github.com/repos/hammerlab/immuno/languages","stargazers_url":"https://api.github.com/repos/hammerlab/immuno/stargazers","contributors_url":"https://api.github.com/repos/hammerlab/immuno/contributors","subscribers_url":"https://api.github.com/repos/hammerlab/immuno/subscribers","subscription_url":"https://api.github.com/repos/hammerlab/immuno/subscription","commits_url":"https://api.github.com/repos/hammerlab/immuno/commits{/sha}","git_commits_url":"https://api.github.com/repos/hammerlab/immuno/git/commits{/sha}","comments_url":"https://api.github.com/repos/hammerlab/immuno/comments{/number}","issue_comment_url":"https://api.github.com/repos/hammerlab/immuno/issues/comments/{number}","contents_url":"https://api.github.com/repos/hammerlab/immuno/contents/{+path}","compare_url":"https://api.github.com/repos/hammerlab/immuno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hammerlab/immuno/merges","archive_url":"https://api.github.com/repos/hammerlab/immuno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hammerlab/immuno/downloads","issues_url":"https://api.github.com/repos/hammerlab/immuno/issues{/number}","pulls_url":"https://api.github.com/repos/hammerlab/immuno/pulls{/number}","milestones_url":"https://api.github.com/repos/hammerlab/immuno/milestones{/number}","notifications_url":"https://api.github.com/repos/hammerlab/immuno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hammerlab/immuno/labels{/name}","releases_url":"https://api.github.com/repos/hammerlab/immuno/releases{/id}","created_at":"2014-03-06T19:56:01Z","updated_at":"2014-06-25T20:05:38Z","pushed_at":"2014-07-03T04:31:51Z","git_url":"git://github.com/hammerlab/immuno.git","ssh_url":"git@github.com:hammerlab/immuno.git","clone_url":"https://github.com/hammerlab/immuno.git","svn_url":"https://github.com/hammerlab/immuno","homepage":null,"size":2142,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":25,"forks":1,"open_issues":25,"watchers":5,"default_branch":"master"}},"base":{"label":"hammerlab:master","ref":"master","sha":"c4251833cb9ff4ac94f9620c82be579b379d8f70","user":{"login":"hammerlab","id":6563873,"avatar_url":"https://avatars.githubusercontent.com/u/6563873?","gravatar_id":"b2ae0016d5cb6ef6df51cea0452b7c04","url":"https://api.github.com/users/hammerlab","html_url":"https://github.com/hammerlab","followers_url":"https://api.github.com/users/hammerlab/followers","following_url":"https://api.github.com/users/hammerlab/following{/other_user}","gists_url":"https://api.github.com/users/hammerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/hammerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammerlab/subscriptions","organizations_url":"https://api.github.com/users/hammerlab/orgs","repos_url":"https://api.github.com/users/hammerlab/repos","events_url":"https://api.github.com/users/hammerlab/events{/privacy}","received_events_url":"https://api.github.com/users/hammerlab/received_events","type":"Organization","site_admin":false},"repo":{"id":17490575,"name":"immuno","full_name":"hammerlab/immuno","owner":{"login":"hammerlab","id":6563873,"avatar_url":"https://avatars.githubusercontent.com/u/6563873?","gravatar_id":"b2ae0016d5cb6ef6df51cea0452b7c04","url":"https://api.github.com/users/hammerlab","html_url":"https://github.com/hammerlab","followers_url":"https://api.github.com/users/hammerlab/followers","following_url":"https://api.github.com/users/hammerlab/following{/other_user}","gists_url":"https://api.github.com/users/hammerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/hammerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammerlab/subscriptions","organizations_url":"https://api.github.com/users/hammerlab/orgs","repos_url":"https://api.github.com/users/hammerlab/repos","events_url":"https://api.github.com/users/hammerlab/events{/privacy}","received_events_url":"https://api.github.com/users/hammerlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hammerlab/immuno","description":"Use somatic mutations to choose a personalized cancer vaccine (tumor-specific immunogenic peptides)","fork":false,"url":"https://api.github.com/repos/hammerlab/immuno","forks_url":"https://api.github.com/repos/hammerlab/immuno/forks","keys_url":"https://api.github.com/repos/hammerlab/immuno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hammerlab/immuno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hammerlab/immuno/teams","hooks_url":"https://api.github.com/repos/hammerlab/immuno/hooks","issue_events_url":"https://api.github.com/repos/hammerlab/immuno/issues/events{/number}","events_url":"https://api.github.com/repos/hammerlab/immuno/events","assignees_url":"https://api.github.com/repos/hammerlab/immuno/assignees{/user}","branches_url":"https://api.github.com/repos/hammerlab/immuno/branches{/branch}","tags_url":"https://api.github.com/repos/hammerlab/immuno/tags","blobs_url":"https://api.github.com/repos/hammerlab/immuno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hammerlab/immuno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hammerlab/immuno/git/refs{/sha}","trees_url":"https://api.github.com/repos/hammerlab/immuno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hammerlab/immuno/statuses/{sha}","languages_url":"https://api.github.com/repos/hammerlab/immuno/languages","stargazers_url":"https://api.github.com/repos/hammerlab/immuno/stargazers","contributors_url":"https://api.github.com/repos/hammerlab/immuno/contributors","subscribers_url":"https://api.github.com/repos/hammerlab/immuno/subscribers","subscription_url":"https://api.github.com/repos/hammerlab/immuno/subscription","commits_url":"https://api.github.com/repos/hammerlab/immuno/commits{/sha}","git_commits_url":"https://api.github.com/repos/hammerlab/immuno/git/commits{/sha}","comments_url":"https://api.github.com/repos/hammerlab/immuno/comments{/number}","issue_comment_url":"https://api.github.com/repos/hammerlab/immuno/issues/comments/{number}","contents_url":"https://api.github.com/repos/hammerlab/immuno/contents/{+path}","compare_url":"https://api.github.com/repos/hammerlab/immuno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hammerlab/immuno/merges","archive_url":"https://api.github.com/repos/hammerlab/immuno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hammerlab/immuno/downloads","issues_url":"https://api.github.com/repos/hammerlab/immuno/issues{/number}","pulls_url":"https://api.github.com/repos/hammerlab/immuno/pulls{/number}","milestones_url":"https://api.github.com/repos/hammerlab/immuno/milestones{/number}","notifications_url":"https://api.github.com/repos/hammerlab/immuno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hammerlab/immuno/labels{/name}","releases_url":"https://api.github.com/repos/hammerlab/immuno/releases{/id}","created_at":"2014-03-06T19:56:01Z","updated_at":"2014-06-25T20:05:38Z","pushed_at":"2014-07-03T04:31:51Z","git_url":"git://github.com/hammerlab/immuno.git","ssh_url":"git@github.com:hammerlab/immuno.git","clone_url":"https://github.com/hammerlab/immuno.git","svn_url":"https://github.com/hammerlab/immuno","homepage":null,"size":2142,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":25,"forks":1,"open_issues":25,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hammerlab/immuno/pulls/103"},"html":{"href":"https://github.com/hammerlab/immuno/pull/103"},"issue":{"href":"https://api.github.com/repos/hammerlab/immuno/issues/103"},"comments":{"href":"https://api.github.com/repos/hammerlab/immuno/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/hammerlab/immuno/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/hammerlab/immuno/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hammerlab/immuno/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/hammerlab/immuno/statuses/e001e77cbcc9d5463ff43ae9b114c126327f9bc7"}}}}