GitHub PullRequestReviewCommentEvent at 2014-03-26 12:37:12
Repository: gaia
Actor: bebef1987
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/10973973","id":10973973,"diff_hunk":"@@ -143,12 +143,13 @@ def __init__(self, marionette):\n         update = self.wait_for_element_present(*self._update_locator)\n         self.wait_for_condition(lambda m: update.location['y'] == 0)\n \n-    def tap_update(self):\n+    def tap_update(self, switch_to_contact_details=True):","path":"tests/python/gaia-ui-tests/gaiatest/apps/contacts/regions/contact_form.py","position":14,"original_position":14,"commit_id":"eabb9e95250dea198ceb1a0e498857bb865ee904","original_commit_id":"eabb9e95250dea198ceb1a0e498857bb865ee904","user":{"login":"bebef1987","id":703611,"avatar_url":"https://avatars.githubusercontent.com/u/703611?","gravatar_id":"77a6657b87d0604634d880dfda11e336","url":"https://api.github.com/users/bebef1987","html_url":"https://github.com/bebef1987","followers_url":"https://api.github.com/users/bebef1987/followers","following_url":"https://api.github.com/users/bebef1987/following{/other_user}","gists_url":"https://api.github.com/users/bebef1987/gists{/gist_id}","starred_url":"https://api.github.com/users/bebef1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebef1987/subscriptions","organizations_url":"https://api.github.com/users/bebef1987/orgs","repos_url":"https://api.github.com/users/bebef1987/repos","events_url":"https://api.github.com/users/bebef1987/events{/privacy}","received_events_url":"https://api.github.com/users/bebef1987/received_events","type":"User","site_admin":false},"body":"@zacc which method? the only other place we return details is in the `tap_cancel` method but that's not used in our test","created_at":"2014-03-26T12:37:12Z","updated_at":"2014-03-26T12:37:12Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/16835#discussion_r10973973","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/16835","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/10973973"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/16835#discussion_r10973973"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/16835"}}}}