GitHub PullRequestReviewCommentEvent at 2014-09-09 19:29:20
Repository: jclouds
Actor: jdaggett
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/17322298","id":17322298,"diff_hunk":"@@ -92,20 +95,11 @@ public static PaginationOptions marker(String marker) {\n       }\n \n       /**\n-       * @see PaginationOptions#limit\n+       * @see PaginationOptions#limit(int)\n        */\n       public static PaginationOptions limit(int limit) {\n          PaginationOptions options = new PaginationOptions();\n          return options.limit(limit);\n       }\n-\n-      /**\n-       * @see PaginationOptions#changesSince(Date)\n-       */\n-      public static PaginationOptions changesSince(Date since) {","path":"apis/openstack-keystone/src/main/java/org/jclouds/openstack/v2_0/options/PaginationOptions.java","position":47,"original_position":47,"commit_id":"c813ea9f9405a86e9202c8ad9b597882b7c9bfb1","original_commit_id":"c813ea9f9405a86e9202c8ad9b597882b7c9bfb1","user":{"login":"jdaggett","id":871593,"avatar_url":"https://avatars.githubusercontent.com/u/871593?v=2","gravatar_id":"41ddf7219b29474aba876fc4ad3c4ae3","url":"https://api.github.com/users/jdaggett","html_url":"https://github.com/jdaggett","followers_url":"https://api.github.com/users/jdaggett/followers","following_url":"https://api.github.com/users/jdaggett/following{/other_user}","gists_url":"https://api.github.com/users/jdaggett/gists{/gist_id}","starred_url":"https://api.github.com/users/jdaggett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdaggett/subscriptions","organizations_url":"https://api.github.com/users/jdaggett/orgs","repos_url":"https://api.github.com/users/jdaggett/repos","events_url":"https://api.github.com/users/jdaggett/events{/privacy}","received_events_url":"https://api.github.com/users/jdaggett/received_events","type":"User","site_admin":false},"body":"@demobox I added it back and deprecated appropriately. Good catch, thx!","created_at":"2014-09-09T19:29:20Z","updated_at":"2014-09-09T19:29:20Z","html_url":"https://github.com/jclouds/jclouds/pull/499#discussion_r17322298","pull_request_url":"https://api.github.com/repos/jclouds/jclouds/pulls/499","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/17322298"},"html":{"href":"https://github.com/jclouds/jclouds/pull/499#discussion_r17322298"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds/pulls/499","id":20452775,"html_url":"https://github.com/jclouds/jclouds/pull/499","diff_url":"https://github.com/jclouds/jclouds/pull/499.diff","patch_url":"https://github.com/jclouds/jclouds/pull/499.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds/issues/499","number":499,"state":"open","locked":false,"title":"JCLOUDS-686: Remove changesSince() query from base PaginationOptions","user":{"login":"jdaggett","id":871593,"avatar_url":"https://avatars.githubusercontent.com/u/871593?v=2","gravatar_id":"41ddf7219b29474aba876fc4ad3c4ae3","url":"https://api.github.com/users/jdaggett","html_url":"https://github.com/jdaggett","followers_url":"https://api.github.com/users/jdaggett/followers","following_url":"https://api.github.com/users/jdaggett/following{/other_user}","gists_url":"https://api.github.com/users/jdaggett/gists{/gist_id}","starred_url":"https://api.github.com/users/jdaggett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdaggett/subscriptions","organizations_url":"https://api.github.com/users/jdaggett/orgs","repos_url":"https://api.github.com/users/jdaggett/repos","events_url":"https://api.github.com/users/jdaggett/events{/privacy}","received_events_url":"https://api.github.com/users/jdaggett/received_events","type":"User","site_admin":false},"body":"This PR deprecates the `changesSince(Date ifModifiedSince)` method in PaginationOptions. `changes-since` is specific to Nova (and [Glance](https://github.com/jclouds/jclouds-labs-openstack/pull/137)) and has moved to the Nova `ListOptions` class. \r\n\r\nNova `ListOptions.maxResults(int maxKeys)` has been deprecated in lieu of `limit(int limit)`.\r\n\r\nUpdated tests updated and cleaned up a few doc links.\r\n\r\nJIRA: https://issues.apache.org/jira/browse/JCLOUDS-686\r\nRelated PR for Glance: https://github.com/jclouds/jclouds-labs-openstack/pull/137","created_at":"2014-08-28T17:08:14Z","updated_at":"2014-09-09T19:29:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7be208634fd706434aad0a991a8a18ece88ce51c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds/pulls/499/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds/pulls/499/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jclouds/jclouds/issues/499/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds/statuses/c813ea9f9405a86e9202c8ad9b597882b7c9bfb1","head":{"label":"rackspace:fix/pagination","ref":"fix/pagination","sha":"c813ea9f9405a86e9202c8ad9b597882b7c9bfb1","user":{"login":"rackspace","id":3949923,"avatar_url":"https://avatars.githubusercontent.com/u/3949923?v=2","gravatar_id":"cc2ad66c312c32facaf25a69bc6779cb","url":"https://api.github.com/users/rackspace","html_url":"https://github.com/rackspace","followers_url":"https://api.github.com/users/rackspace/followers","following_url":"https://api.github.com/users/rackspace/following{/other_user}","gists_url":"https://api.github.com/users/rackspace/gists{/gist_id}","starred_url":"https://api.github.com/users/rackspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackspace/subscriptions","organizations_url":"https://api.github.com/users/rackspace/orgs","repos_url":"https://api.github.com/users/rackspace/repos","events_url":"https://api.github.com/users/rackspace/events{/privacy}","received_events_url":"https://api.github.com/users/rackspace/received_events","type":"Organization","site_admin":false},"repo":{"id":10088197,"name":"jclouds","full_name":"rackspace/jclouds","owner":{"login":"rackspace","id":3949923,"avatar_url":"https://avatars.githubusercontent.com/u/3949923?v=2","gravatar_id":"cc2ad66c312c32facaf25a69bc6779cb","url":"https://api.github.com/users/rackspace","html_url":"https://github.com/rackspace","followers_url":"https://api.github.com/users/rackspace/followers","following_url":"https://api.github.com/users/rackspace/following{/other_user}","gists_url":"https://api.github.com/users/rackspace/gists{/gist_id}","starred_url":"https://api.github.com/users/rackspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackspace/subscriptions","organizations_url":"https://api.github.com/users/rackspace/orgs","repos_url":"https://api.github.com/users/rackspace/repos","events_url":"https://api.github.com/users/rackspace/events{/privacy}","received_events_url":"https://api.github.com/users/rackspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackspace/jclouds","description":"The Java SDK (powered by Apache jclouds) for the Rackspace Cloud","fork":true,"url":"https://api.github.com/repos/rackspace/jclouds","forks_url":"https://api.github.com/repos/rackspace/jclouds/forks","keys_url":"https://api.github.com/repos/rackspace/jclouds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackspace/jclouds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackspace/jclouds/teams","hooks_url":"https://api.github.com/repos/rackspace/jclouds/hooks","issue_events_url":"https://api.github.com/repos/rackspace/jclouds/issues/events{/number}","events_url":"https://api.github.com/repos/rackspace/jclouds/events","assignees_url":"https://api.github.com/repos/rackspace/jclouds/assignees{/user}","branches_url":"https://api.github.com/repos/rackspace/jclouds/branches{/branch}","tags_url":"https://api.github.com/repos/rackspace/jclouds/tags","blobs_url":"https://api.github.com/repos/rackspace/jclouds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackspace/jclouds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackspace/jclouds/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackspace/jclouds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackspace/jclouds/statuses/{sha}","languages_url":"https://api.github.com/repos/rackspace/jclouds/languages","stargazers_url":"https://api.github.com/repos/rackspace/jclouds/stargazers","contributors_url":"https://api.github.com/repos/rackspace/jclouds/contributors","subscribers_url":"https://api.github.com/repos/rackspace/jclouds/subscribers","subscription_url":"https://api.github.com/repos/rackspace/jclouds/subscription","commits_url":"https://api.github.com/repos/rackspace/jclouds/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackspace/jclouds/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackspace/jclouds/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackspace/jclouds/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackspace/jclouds/contents/{+path}","compare_url":"https://api.github.com/repos/rackspace/jclouds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackspace/jclouds/merges","archive_url":"https://api.github.com/repos/rackspace/jclouds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackspace/jclouds/downloads","issues_url":"https://api.github.com/repos/rackspace/jclouds/issues{/number}","pulls_url":"https://api.github.com/repos/rackspace/jclouds/pulls{/number}","milestones_url":"https://api.github.com/repos/rackspace/jclouds/milestones{/number}","notifications_url":"https://api.github.com/repos/rackspace/jclouds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackspace/jclouds/labels{/name}","releases_url":"https://api.github.com/repos/rackspace/jclouds/releases{/id}","created_at":"2013-05-15T21:18:47Z","updated_at":"2014-07-15T21:43:06Z","pushed_at":"2014-09-04T16:58:40Z","git_url":"git://github.com/rackspace/jclouds.git","ssh_url":"git@github.com:rackspace/jclouds.git","clone_url":"https://github.com/rackspace/jclouds.git","svn_url":"https://github.com/rackspace/jclouds","homepage":"developer.rackspace.com","size":69518,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jclouds:master","ref":"master","sha":"df996f3231005b1ef294223d20efbabe74a23de7","user":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=2","gravatar_id":"08fdc408ec6d07b292b8fdf46b1e3e1e","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10040960,"name":"jclouds","full_name":"jclouds/jclouds","owner":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=2","gravatar_id":"08fdc408ec6d07b292b8fdf46b1e3e1e","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds","description":"Read-only mirror of ASF Git Repo for jclouds","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds","forks_url":"https://api.github.com/repos/jclouds/jclouds/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds/issues/comments/{number}","contents_url":"https://api.github.com/repos/jclouds/jclouds/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds/releases{/id}","created_at":"2013-05-13T20:47:29Z","updated_at":"2014-09-02T22:32:57Z","pushed_at":"2014-09-09T01:47:07Z","git_url":"git://github.com/jclouds/jclouds.git","ssh_url":"git@github.com:jclouds/jclouds.git","clone_url":"https://github.com/jclouds/jclouds.git","svn_url":"https://github.com/jclouds/jclouds","homepage":"http://jclouds.apache.org/","size":164937,"stargazers_count":110,"watchers_count":110,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":188,"mirror_url":null,"open_issues_count":27,"forks":188,"open_issues":27,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/499"},"html":{"href":"https://github.com/jclouds/jclouds/pull/499"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds/issues/499"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds/statuses/c813ea9f9405a86e9202c8ad9b597882b7c9bfb1"}}}}