GitHub PullRequestReviewCommentEvent at 2014-11-04 12:37:24
Repository: crosswalk
Actor: pozdnyakov
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/19799869","id":19799869,"diff_hunk":"@@ -44,20 +44,16 @@ using content::WebContents;\n \n namespace xwalk {\n \n-namespace {\n-\n-// The default size for web content area size.\n-const int kDefaultWidth = 840;\n-const int kDefaultHeight = 600;\n-\n-}  // namespace\n-\n // static\n Runtime* Runtime::CreateWithDefaultWindow(\n     RuntimeContext* runtime_context, const GURL& url, Observer* observer) {\n   Runtime* runtime = Runtime::Create(runtime_context, observer);\n   runtime->LoadURL(url);\n-  runtime->AttachDefaultWindow();\n+  runtime->SetUIStrategy(new RuntimeUIStrategy);","path":"runtime/browser/runtime.cc","position":18,"original_position":18,"commit_id":"571bfc31932d1098ba5e9feede36322dff39fe06","original_commit_id":"571bfc31932d1098ba5e9feede36322dff39fe06","user":{"login":"pozdnyakov","id":998253,"avatar_url":"https://avatars.githubusercontent.com/u/998253?v=2","gravatar_id":"","url":"https://api.github.com/users/pozdnyakov","html_url":"https://github.com/pozdnyakov","followers_url":"https://api.github.com/users/pozdnyakov/followers","following_url":"https://api.github.com/users/pozdnyakov/following{/other_user}","gists_url":"https://api.github.com/users/pozdnyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/pozdnyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pozdnyakov/subscriptions","organizations_url":"https://api.github.com/users/pozdnyakov/orgs","repos_url":"https://api.github.com/users/pozdnyakov/repos","events_url":"https://api.github.com/users/pozdnyakov/events{/privacy}","received_events_url":"https://api.github.com/users/pozdnyakov/received_events","type":"User","site_admin":false},"body":"one instance of ui strategy should be used for all the runtimes created, it's better to move this logic out of Runtime class itself (to Application for example).","created_at":"2014-11-04T12:37:24Z","updated_at":"2014-11-04T12:37:24Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/2562#discussion_r19799869","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2562","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/19799869"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/2562#discussion_r19799869"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2562"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2562","id":23815658,"html_url":"https://github.com/crosswalk-project/crosswalk/pull/2562","diff_url":"https://github.com/crosswalk-project/crosswalk/pull/2562.diff","patch_url":"https://github.com/crosswalk-project/crosswalk/pull/2562.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2562","number":2562,"state":"open","locked":false,"title":"Re-factor the runtime class.","user":{"login":"takethathe","id":779336,"avatar_url":"https://avatars.githubusercontent.com/u/779336?v=2","gravatar_id":"","url":"https://api.github.com/users/takethathe","html_url":"https://github.com/takethathe","followers_url":"https://api.github.com/users/takethathe/followers","following_url":"https://api.github.com/users/takethathe/following{/other_user}","gists_url":"https://api.github.com/users/takethathe/gists{/gist_id}","starred_url":"https://api.github.com/users/takethathe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takethathe/subscriptions","organizations_url":"https://api.github.com/users/takethathe/orgs","repos_url":"https://api.github.com/users/takethathe/repos","events_url":"https://api.github.com/users/takethathe/events{/privacy}","received_events_url":"https://api.github.com/users/takethathe/received_events","type":"User","site_admin":false},"body":"Add RuntimeUIStrategy for creating and showing the runtime window by provided params. This will separate the UI related implementations into the new strategy object.","created_at":"2014-11-04T07:47:51Z","updated_at":"2014-11-04T12:37:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab80d4dae2b1a8961737ac032e6843acf24b5d25","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2562/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2562/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2562/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/571bfc31932d1098ba5e9feede36322dff39fe06","head":{"label":"takethathe:runtime_ui_refactor","ref":"runtime_ui_refactor","sha":"571bfc31932d1098ba5e9feede36322dff39fe06","user":{"login":"takethathe","id":779336,"avatar_url":"https://avatars.githubusercontent.com/u/779336?v=2","gravatar_id":"","url":"https://api.github.com/users/takethathe","html_url":"https://github.com/takethathe","followers_url":"https://api.github.com/users/takethathe/followers","following_url":"https://api.github.com/users/takethathe/following{/other_user}","gists_url":"https://api.github.com/users/takethathe/gists{/gist_id}","starred_url":"https://api.github.com/users/takethathe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takethathe/subscriptions","organizations_url":"https://api.github.com/users/takethathe/orgs","repos_url":"https://api.github.com/users/takethathe/repos","events_url":"https://api.github.com/users/takethathe/events{/privacy}","received_events_url":"https://api.github.com/users/takethathe/received_events","type":"User","site_admin":false},"repo":{"id":12750044,"name":"crosswalk","full_name":"takethathe/crosswalk","owner":{"login":"takethathe","id":779336,"avatar_url":"https://avatars.githubusercontent.com/u/779336?v=2","gravatar_id":"","url":"https://api.github.com/users/takethathe","html_url":"https://github.com/takethathe","followers_url":"https://api.github.com/users/takethathe/followers","following_url":"https://api.github.com/users/takethathe/following{/other_user}","gists_url":"https://api.github.com/users/takethathe/gists{/gist_id}","starred_url":"https://api.github.com/users/takethathe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takethathe/subscriptions","organizations_url":"https://api.github.com/users/takethathe/orgs","repos_url":"https://api.github.com/users/takethathe/repos","events_url":"https://api.github.com/users/takethathe/events{/privacy}","received_events_url":"https://api.github.com/users/takethathe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/takethathe/crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/takethathe/crosswalk","forks_url":"https://api.github.com/repos/takethathe/crosswalk/forks","keys_url":"https://api.github.com/repos/takethathe/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takethathe/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takethathe/crosswalk/teams","hooks_url":"https://api.github.com/repos/takethathe/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/takethathe/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/takethathe/crosswalk/events","assignees_url":"https://api.github.com/repos/takethathe/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/takethathe/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/takethathe/crosswalk/tags","blobs_url":"https://api.github.com/repos/takethathe/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takethathe/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takethathe/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/takethathe/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takethathe/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/takethathe/crosswalk/languages","stargazers_url":"https://api.github.com/repos/takethathe/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/takethathe/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/takethathe/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/takethathe/crosswalk/subscription","commits_url":"https://api.github.com/repos/takethathe/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/takethathe/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/takethathe/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/takethathe/crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/takethathe/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/takethathe/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takethathe/crosswalk/merges","archive_url":"https://api.github.com/repos/takethathe/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takethathe/crosswalk/downloads","issues_url":"https://api.github.com/repos/takethathe/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/takethathe/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/takethathe/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/takethathe/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takethathe/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/takethathe/crosswalk/releases{/id}","created_at":"2013-09-11T07:17:30Z","updated_at":"2014-06-25T06:56:39Z","pushed_at":"2014-11-04T09:12:11Z","git_url":"git://github.com/takethathe/crosswalk.git","ssh_url":"git@github.com:takethathe/crosswalk.git","clone_url":"https://github.com/takethathe/crosswalk.git","svn_url":"https://github.com/takethathe/crosswalk","homepage":null,"size":26388,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"11ee4d9fb5eb63e42976be1149f9f6c2ed8f015c","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=2","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":9207280,"name":"crosswalk","full_name":"crosswalk-project/crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=2","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk/releases{/id}","created_at":"2013-04-03T23:30:12Z","updated_at":"2014-11-04T07:58:40Z","pushed_at":"2014-11-03T19:02:24Z","git_url":"git://github.com/crosswalk-project/crosswalk.git","ssh_url":"git@github.com:crosswalk-project/crosswalk.git","clone_url":"https://github.com/crosswalk-project/crosswalk.git","svn_url":"https://github.com/crosswalk-project/crosswalk","homepage":"https://crosswalk-project.org/","size":159945,"stargazers_count":414,"watchers_count":414,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":107,"forks":154,"open_issues":107,"watchers":414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2562"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/2562"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2562"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2562/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2562/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2562/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/571bfc31932d1098ba5e9feede36322dff39fe06"}}}}