GitHub PullRequestReviewCommentEvent at 2014-05-16 14:52:17
Repository: mule
Actor: marianogonzalez
Payload: {"comment":{"url":"https://api.github.com/repos/mulesoft/mule/pulls/comments/12741987","id":12741987,"diff_hunk":"@@ -124,15 +126,22 @@ public synchronized void close()\n \n     /**\n      * @param txId transaction identifier\n-     * @return journal entries for txId\n+     * @return a copy collection of the journal entries for txId\n      */\n     public synchronized Collection<K> getLogEntries(T txId)\n     {\n-        return entries.get(txId);\n+        Collection<K> entries = this.entries.get(txId);\n+        if (entries == null)\n+        {\n+            return Collections.emptyList();\n+        }\n+        return new ArrayList<K>(entries);","path":"core/src/main/java/org/mule/util/journal/TransactionJournalFile.java","position":25,"original_position":25,"commit_id":"e075bb2077f29b3c142fe71cdd556f172cb7bd86","original_commit_id":"e075bb2077f29b3c142fe71cdd556f172cb7bd86","user":{"login":"marianogonzalez","id":1272771,"avatar_url":"https://avatars.githubusercontent.com/u/1272771?","gravatar_id":"1df5a1c5770a78a0ea698eb3bce9db01","url":"https://api.github.com/users/marianogonzalez","html_url":"https://github.com/marianogonzalez","followers_url":"https://api.github.com/users/marianogonzalez/followers","following_url":"https://api.github.com/users/marianogonzalez/following{/other_user}","gists_url":"https://api.github.com/users/marianogonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/marianogonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marianogonzalez/subscriptions","organizations_url":"https://api.github.com/users/marianogonzalez/orgs","repos_url":"https://api.github.com/users/marianogonzalez/repos","events_url":"https://api.github.com/users/marianogonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/marianogonzalez/received_events","type":"User","site_admin":false},"body":"shouldn't this be a immutable copy?","created_at":"2014-05-16T14:52:17Z","updated_at":"2014-05-16T14:52:17Z","html_url":"https://github.com/mulesoft/mule/pull/716#discussion_r12741987","pull_request_url":"https://api.github.com/repos/mulesoft/mule/pulls/716","_links":{"self":{"href":"https://api.github.com/repos/mulesoft/mule/pulls/comments/12741987"},"html":{"href":"https://github.com/mulesoft/mule/pull/716#discussion_r12741987"},"pull_request":{"href":"https://api.github.com/repos/mulesoft/mule/pulls/716"}}}}