GitHub PullRequestReviewCommentEvent at 2014-03-30 12:21:28
Repository: phobos
Actor: WebDrake
Payload: {"comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/11097795","id":11097795,"diff_hunk":"@@ -175,7 +175,7 @@ template isSeedable(Rng)\n         }));\n }\n \n-unittest\n+@safe pure nothrow unittest","path":"std/random.d","position":5,"original_position":5,"commit_id":"412ec99bea9cc72c69b15dccd2e82de5cc451192","original_commit_id":"412ec99bea9cc72c69b15dccd2e82de5cc451192","user":{"login":"WebDrake","id":125075,"avatar_url":"https://avatars.githubusercontent.com/u/125075?","gravatar_id":"3e16b27aeeb8f618513af87a5436edd4","url":"https://api.github.com/users/WebDrake","html_url":"https://github.com/WebDrake","followers_url":"https://api.github.com/users/WebDrake/followers","following_url":"https://api.github.com/users/WebDrake/following{/other_user}","gists_url":"https://api.github.com/users/WebDrake/gists{/gist_id}","starred_url":"https://api.github.com/users/WebDrake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebDrake/subscriptions","organizations_url":"https://api.github.com/users/WebDrake/orgs","repos_url":"https://api.github.com/users/WebDrake/repos","events_url":"https://api.github.com/users/WebDrake/events{/privacy}","received_events_url":"https://api.github.com/users/WebDrake/received_events","type":"User","site_admin":false},"body":"Basic problem: you add a new unittest that involves `rndGen` to the set and suddenly you get compiler errors because now you're not calling a pure nothrow function.\r\n\r\nThe only case where I'd consider this worthwhile would be for unittests _inside a struct or class_, which do exist, but IIRC they're almost invariably static unittests.","created_at":"2014-03-30T12:21:28Z","updated_at":"2014-03-30T12:21:28Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/2051#discussion_r11097795","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2051","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/11097795"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2051#discussion_r11097795"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2051"}}}}