GitHub PullRequestReviewCommentEvent at 2014-01-23 22:13:40
Repository: dd-agent
Actor: remh
Payload: {"comment":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/comments/9132414","id":9132414,"diff_hunk":"@@ -19,10 +19,22 @@\n     'Innodb_data_writes': ('mysql.innodb.data_writes', RATE),\n     'Innodb_os_log_fsyncs': ('mysql.innodb.os_log_fsyncs', RATE),\n     'Innodb_data_reads': ('mysql.innodb.buffer_pool_size', RATE),\n-    'Created_tmp_disk_tables': ('mysql.performance.created_tmp_disk_tables', GAUGE),\n     'Slow_queries': ('mysql.performance.slow_queries', RATE),\n     'Questions': ('mysql.performance.questions', RATE),\n     'Queries': ('mysql.performance.queries', RATE),\n+    'Com_select': ('mysql.performance.com_select', RATE),\n+    'Com_insert': ('mysql.performance.com_insert', RATE),\n+    'Com_update': ('mysql.performance.com_update', RATE),\n+    'Com_delete': ('mysql.performance.com_delete', RATE),\n+    'Innodb_mutex_spin_waits': ('mysql.innodb.mutex_spin_waits', RATE),\n+    'Innodb_mutex_spin_rounds': ('mysql.innodb.mutex_spin_rounds', RATE),\n+    'Innodb_mutex_os_waits': ('mysql.innodb.mutex_os_waits', RATE),\n+    'Created_tmp_tables': ('mysql.performance.created_tmp_tables', RATE),\n+    'Created_tmp_disk_tables': ('mysql.performance.created_tmp_disk_tables', RATE),\n+    'Created_tmp_files': ('mysql.performance.created_tmp_files', RATE),\n+    'Innodb_row_lock_waits': ('mysql.innodb.row_lock_waits', RATE),\n+    'Innodb_row_lock_time': ('mysql.innodb.row_lock_time', RATE),\n+    'Innodb_current_row_locks': ('mysql.innodb.current_row_locks', RATE),","path":"checks.d/mysql.py","position":20,"original_position":20,"commit_id":"b16d493e9f88a285d0dc0822bae6b0eca40c8144","original_commit_id":"b16d493e9f88a285d0dc0822bae6b0eca40c8144","user":{"login":"remh","id":1311477,"avatar_url":"https://gravatar.com/avatar/b19bbfdc5d165db192bb7ca2c66e8335?d=https%3A%2F%2Fidenticons.github.com%2F4e537dfc817aa1cdbbc719b98ca325c5.png&r=x","gravatar_id":"b19bbfdc5d165db192bb7ca2c66e8335","url":"https://api.github.com/users/remh","html_url":"https://github.com/remh","followers_url":"https://api.github.com/users/remh/followers","following_url":"https://api.github.com/users/remh/following{/other_user}","gists_url":"https://api.github.com/users/remh/gists{/gist_id}","starred_url":"https://api.github.com/users/remh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remh/subscriptions","organizations_url":"https://api.github.com/users/remh/orgs","repos_url":"https://api.github.com/users/remh/repos","events_url":"https://api.github.com/users/remh/events{/privacy}","received_events_url":"https://api.github.com/users/remh/received_events","type":"User","site_admin":false},"body":"Yep agree with that, it should be collected separately.\r\nCould you add them in your PR please ?","created_at":"2014-01-23T22:13:40Z","updated_at":"2014-01-23T22:13:40Z","html_url":"https://github.com/DataDog/dd-agent/pull/726#discussion_r9132414","pull_request_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/726","_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/comments/9132414"},"html":{"href":"https://github.com/DataDog/dd-agent/pull/726#discussion_r9132414"},"pull_request":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/726"}}}}