GitHub PullRequestReviewCommentEvent at 2014-09-16 03:52:50
Repository: cycledash
Actor: danvk
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hammerlab/cycledash/pulls/comments/17582155","id":17582155,"diff_hunk":"@@ -0,0 +1,175 @@\n+/** @jsx React.DOM */\n+var _ = require('underscore'),\n+    d3 = require('d3'),\n+    React = require('react');\n+\n+\n+\n+var VCFTable = React.createClass({\n+   render: function() {\n+     return (\n+       <table>\n+         <VCFTableHeader attrs={this.props.attrs}\n+                         handleChartChange={this.props.handleChartChange} />\n+         <VCFTableFilter chromosomes={this.props.chromosomes}\n+                         records={this.props.records}\n+                         handleFilterUpdate={this.props.handleFilterUpdate}\n+                         handleChromosomeChange={this.props.handleChromosomeChange}\n+                         chromosome={this.props.position.chromosome}\n+                         position={this.props.position}\n+                         handleRelativeRangeChange={this.props.handleRelativeRangeChange}","path":"cycledash/static/js/examine/VCFTable.js","position":20,"original_position":20,"commit_id":"f0d597a5a0d3cbaad74404dc76cb2a288755b260","original_commit_id":"f0d597a5a0d3cbaad74404dc76cb2a288755b260","user":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=2","gravatar_id":"a2aaa6cd108f9a803ec61e20d76963f1","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"body":"Since there's only one range change property, how about just `handleRangeChange`?","created_at":"2014-09-16T03:52:50Z","updated_at":"2014-09-16T03:52:50Z","html_url":"https://github.com/hammerlab/cycledash/pull/24#discussion_r17582155","pull_request_url":"https://api.github.com/repos/hammerlab/cycledash/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/hammerlab/cycledash/pulls/comments/17582155"},"html":{"href":"https://github.com/hammerlab/cycledash/pull/24#discussion_r17582155"},"pull_request":{"href":"https://api.github.com/repos/hammerlab/cycledash/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/hammerlab/cycledash/pulls/24","id":21102398,"html_url":"https://github.com/hammerlab/cycledash/pull/24","diff_url":"https://github.com/hammerlab/cycledash/pull/24.diff","patch_url":"https://github.com/hammerlab/cycledash/pull/24.patch","issue_url":"https://api.github.com/repos/hammerlab/cycledash/issues/24","number":24,"state":"open","locked":false,"title":"Rework the /examine page for debugging VCFs, using React.js + co.","user":{"login":"ihodes","id":167803,"avatar_url":"https://avatars.githubusercontent.com/u/167803?v=2","gravatar_id":"5406fa6d405a74abaacf516ed0c61e71","url":"https://api.github.com/users/ihodes","html_url":"https://github.com/ihodes","followers_url":"https://api.github.com/users/ihodes/followers","following_url":"https://api.github.com/users/ihodes/following{/other_user}","gists_url":"https://api.github.com/users/ihodes/gists{/gist_id}","starred_url":"https://api.github.com/users/ihodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihodes/subscriptions","organizations_url":"https://api.github.com/users/ihodes/orgs","repos_url":"https://api.github.com/users/ihodes/repos","events_url":"https://api.github.com/users/ihodes/events{/privacy}","received_events_url":"https://api.github.com/users/ihodes/received_events","type":"User","site_admin":false},"body":"Redesigned and recombobulated the /examine page for debugging VCFs. \r\n\r\n![](http://cl.ly/image/1e1r3H0d0V0W/Screen%20Shot%202014-09-11%20at%201.04.12%20PM.png)\r\n\r\nIn short, a VCF is loaded into the browser, and can be filtered and ranges selected based on INFO attributes and positions in the genome. Hisograms for the various INFo attributes can be generated, and true/false pos/neg + precision/recall/f1score are shown for the selected rows. \r\n\r\nThis uses react.js, d3.js, vcf.js, vcf.tools.js, idiogrammatik.js.\r\n\r\nThis is a provisional PR, to get this out ASAP. There are edge-cases and :bug: :snail: :bee:, as well as tests, that need accounting for. \r\n\r\nfixes #14 ","created_at":"2014-09-11T17:07:22Z","updated_at":"2014-09-16T03:52:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9342c45d41a82572465601fbbed2b3898247057d","assignee":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=2","gravatar_id":"a2aaa6cd108f9a803ec61e20d76963f1","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/hammerlab/cycledash/pulls/24/commits","review_comments_url":"https://api.github.com/repos/hammerlab/cycledash/pulls/24/comments","review_comment_url":"https://api.github.com/repos/hammerlab/cycledash/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hammerlab/cycledash/issues/24/comments","statuses_url":"https://api.github.com/repos/hammerlab/cycledash/statuses/f0d597a5a0d3cbaad74404dc76cb2a288755b260","head":{"label":"hammerlab:reactify_examine","ref":"reactify_examine","sha":"f0d597a5a0d3cbaad74404dc76cb2a288755b260","user":{"login":"hammerlab","id":6563873,"avatar_url":"https://avatars.githubusercontent.com/u/6563873?v=2","gravatar_id":"b2ae0016d5cb6ef6df51cea0452b7c04","url":"https://api.github.com/users/hammerlab","html_url":"https://github.com/hammerlab","followers_url":"https://api.github.com/users/hammerlab/followers","following_url":"https://api.github.com/users/hammerlab/following{/other_user}","gists_url":"https://api.github.com/users/hammerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/hammerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammerlab/subscriptions","organizations_url":"https://api.github.com/users/hammerlab/orgs","repos_url":"https://api.github.com/users/hammerlab/repos","events_url":"https://api.github.com/users/hammerlab/events{/privacy}","received_events_url":"https://api.github.com/users/hammerlab/received_events","type":"Organization","site_admin":false},"repo":{"id":20279144,"name":"cycledash","full_name":"hammerlab/cycledash","owner":{"login":"hammerlab","id":6563873,"avatar_url":"https://avatars.githubusercontent.com/u/6563873?v=2","gravatar_id":"b2ae0016d5cb6ef6df51cea0452b7c04","url":"https://api.github.com/users/hammerlab","html_url":"https://github.com/hammerlab","followers_url":"https://api.github.com/users/hammerlab/followers","following_url":"https://api.github.com/users/hammerlab/following{/other_user}","gists_url":"https://api.github.com/users/hammerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/hammerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammerlab/subscriptions","organizations_url":"https://api.github.com/users/hammerlab/orgs","repos_url":"https://api.github.com/users/hammerlab/repos","events_url":"https://api.github.com/users/hammerlab/events{/privacy}","received_events_url":"https://api.github.com/users/hammerlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hammerlab/cycledash","description":"Variant Caller Analysis Dashboard and Data Management System","fork":false,"url":"https://api.github.com/repos/hammerlab/cycledash","forks_url":"https://api.github.com/repos/hammerlab/cycledash/forks","keys_url":"https://api.github.com/repos/hammerlab/cycledash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hammerlab/cycledash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hammerlab/cycledash/teams","hooks_url":"https://api.github.com/repos/hammerlab/cycledash/hooks","issue_events_url":"https://api.github.com/repos/hammerlab/cycledash/issues/events{/number}","events_url":"https://api.github.com/repos/hammerlab/cycledash/events","assignees_url":"https://api.github.com/repos/hammerlab/cycledash/assignees{/user}","branches_url":"https://api.github.com/repos/hammerlab/cycledash/branches{/branch}","tags_url":"https://api.github.com/repos/hammerlab/cycledash/tags","blobs_url":"https://api.github.com/repos/hammerlab/cycledash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hammerlab/cycledash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hammerlab/cycledash/git/refs{/sha}","trees_url":"https://api.github.com/repos/hammerlab/cycledash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hammerlab/cycledash/statuses/{sha}","languages_url":"https://api.github.com/repos/hammerlab/cycledash/languages","stargazers_url":"https://api.github.com/repos/hammerlab/cycledash/stargazers","contributors_url":"https://api.github.com/repos/hammerlab/cycledash/contributors","subscribers_url":"https://api.github.com/repos/hammerlab/cycledash/subscribers","subscription_url":"https://api.github.com/repos/hammerlab/cycledash/subscription","commits_url":"https://api.github.com/repos/hammerlab/cycledash/commits{/sha}","git_commits_url":"https://api.github.com/repos/hammerlab/cycledash/git/commits{/sha}","comments_url":"https://api.github.com/repos/hammerlab/cycledash/comments{/number}","issue_comment_url":"https://api.github.com/repos/hammerlab/cycledash/issues/comments/{number}","contents_url":"https://api.github.com/repos/hammerlab/cycledash/contents/{+path}","compare_url":"https://api.github.com/repos/hammerlab/cycledash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hammerlab/cycledash/merges","archive_url":"https://api.github.com/repos/hammerlab/cycledash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hammerlab/cycledash/downloads","issues_url":"https://api.github.com/repos/hammerlab/cycledash/issues{/number}","pulls_url":"https://api.github.com/repos/hammerlab/cycledash/pulls{/number}","milestones_url":"https://api.github.com/repos/hammerlab/cycledash/milestones{/number}","notifications_url":"https://api.github.com/repos/hammerlab/cycledash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hammerlab/cycledash/labels{/name}","releases_url":"https://api.github.com/repos/hammerlab/cycledash/releases{/id}","created_at":"2014-05-29T01:58:41Z","updated_at":"2014-09-03T21:39:21Z","pushed_at":"2014-09-15T21:35:16Z","git_url":"git://github.com/hammerlab/cycledash.git","ssh_url":"git@github.com:hammerlab/cycledash.git","clone_url":"https://github.com/hammerlab/cycledash.git","svn_url":"https://github.com/hammerlab/cycledash","homepage":null,"size":4672,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":1,"default_branch":"master"}},"base":{"label":"hammerlab:master","ref":"master","sha":"7082edb5e80fe9d702d823aae915ed96306fc8ff","user":{"login":"hammerlab","id":6563873,"avatar_url":"https://avatars.githubusercontent.com/u/6563873?v=2","gravatar_id":"b2ae0016d5cb6ef6df51cea0452b7c04","url":"https://api.github.com/users/hammerlab","html_url":"https://github.com/hammerlab","followers_url":"https://api.github.com/users/hammerlab/followers","following_url":"https://api.github.com/users/hammerlab/following{/other_user}","gists_url":"https://api.github.com/users/hammerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/hammerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammerlab/subscriptions","organizations_url":"https://api.github.com/users/hammerlab/orgs","repos_url":"https://api.github.com/users/hammerlab/repos","events_url":"https://api.github.com/users/hammerlab/events{/privacy}","received_events_url":"https://api.github.com/users/hammerlab/received_events","type":"Organization","site_admin":false},"repo":{"id":20279144,"name":"cycledash","full_name":"hammerlab/cycledash","owner":{"login":"hammerlab","id":6563873,"avatar_url":"https://avatars.githubusercontent.com/u/6563873?v=2","gravatar_id":"b2ae0016d5cb6ef6df51cea0452b7c04","url":"https://api.github.com/users/hammerlab","html_url":"https://github.com/hammerlab","followers_url":"https://api.github.com/users/hammerlab/followers","following_url":"https://api.github.com/users/hammerlab/following{/other_user}","gists_url":"https://api.github.com/users/hammerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/hammerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammerlab/subscriptions","organizations_url":"https://api.github.com/users/hammerlab/orgs","repos_url":"https://api.github.com/users/hammerlab/repos","events_url":"https://api.github.com/users/hammerlab/events{/privacy}","received_events_url":"https://api.github.com/users/hammerlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hammerlab/cycledash","description":"Variant Caller Analysis Dashboard and Data Management System","fork":false,"url":"https://api.github.com/repos/hammerlab/cycledash","forks_url":"https://api.github.com/repos/hammerlab/cycledash/forks","keys_url":"https://api.github.com/repos/hammerlab/cycledash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hammerlab/cycledash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hammerlab/cycledash/teams","hooks_url":"https://api.github.com/repos/hammerlab/cycledash/hooks","issue_events_url":"https://api.github.com/repos/hammerlab/cycledash/issues/events{/number}","events_url":"https://api.github.com/repos/hammerlab/cycledash/events","assignees_url":"https://api.github.com/repos/hammerlab/cycledash/assignees{/user}","branches_url":"https://api.github.com/repos/hammerlab/cycledash/branches{/branch}","tags_url":"https://api.github.com/repos/hammerlab/cycledash/tags","blobs_url":"https://api.github.com/repos/hammerlab/cycledash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hammerlab/cycledash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hammerlab/cycledash/git/refs{/sha}","trees_url":"https://api.github.com/repos/hammerlab/cycledash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hammerlab/cycledash/statuses/{sha}","languages_url":"https://api.github.com/repos/hammerlab/cycledash/languages","stargazers_url":"https://api.github.com/repos/hammerlab/cycledash/stargazers","contributors_url":"https://api.github.com/repos/hammerlab/cycledash/contributors","subscribers_url":"https://api.github.com/repos/hammerlab/cycledash/subscribers","subscription_url":"https://api.github.com/repos/hammerlab/cycledash/subscription","commits_url":"https://api.github.com/repos/hammerlab/cycledash/commits{/sha}","git_commits_url":"https://api.github.com/repos/hammerlab/cycledash/git/commits{/sha}","comments_url":"https://api.github.com/repos/hammerlab/cycledash/comments{/number}","issue_comment_url":"https://api.github.com/repos/hammerlab/cycledash/issues/comments/{number}","contents_url":"https://api.github.com/repos/hammerlab/cycledash/contents/{+path}","compare_url":"https://api.github.com/repos/hammerlab/cycledash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hammerlab/cycledash/merges","archive_url":"https://api.github.com/repos/hammerlab/cycledash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hammerlab/cycledash/downloads","issues_url":"https://api.github.com/repos/hammerlab/cycledash/issues{/number}","pulls_url":"https://api.github.com/repos/hammerlab/cycledash/pulls{/number}","milestones_url":"https://api.github.com/repos/hammerlab/cycledash/milestones{/number}","notifications_url":"https://api.github.com/repos/hammerlab/cycledash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hammerlab/cycledash/labels{/name}","releases_url":"https://api.github.com/repos/hammerlab/cycledash/releases{/id}","created_at":"2014-05-29T01:58:41Z","updated_at":"2014-09-03T21:39:21Z","pushed_at":"2014-09-15T21:35:16Z","git_url":"git://github.com/hammerlab/cycledash.git","ssh_url":"git@github.com:hammerlab/cycledash.git","clone_url":"https://github.com/hammerlab/cycledash.git","svn_url":"https://github.com/hammerlab/cycledash","homepage":null,"size":4672,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hammerlab/cycledash/pulls/24"},"html":{"href":"https://github.com/hammerlab/cycledash/pull/24"},"issue":{"href":"https://api.github.com/repos/hammerlab/cycledash/issues/24"},"comments":{"href":"https://api.github.com/repos/hammerlab/cycledash/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/hammerlab/cycledash/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/hammerlab/cycledash/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hammerlab/cycledash/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/hammerlab/cycledash/statuses/f0d597a5a0d3cbaad74404dc76cb2a288755b260"}}}}