GitHub PullRequestReviewCommentEvent at 2014-06-11 07:41:11
Repository: yast-registration
Actor: lslezak
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-registration/pulls/comments/13637149","id":13637149,"diff_hunk":"@@ -62,7 +62,17 @@ def create_addon_with_deps(root)\n     attr_reader :children\n     attr_accessor :depends_on, :regcode\n \n-    def_delegators :@pure_addon, :free, :product_ident, :short_name, :long_name, :description, :eula_url\n+    # delegate methods to underlaying suse connect object\n+    def_delegators :@pure_addon,\n+      :free,","path":"src/lib/registration/addon.rb","position":7,"original_position":7,"commit_id":"2fc265d5777f4e592a44f5ad29bde7a848df31f6","original_commit_id":"2fc265d5777f4e592a44f5ad29bde7a848df31f6","user":{"login":"lslezak","id":907998,"avatar_url":"https://avatars.githubusercontent.com/u/907998?","gravatar_id":"654c5b4f0d657240edff9440a901839b","url":"https://api.github.com/users/lslezak","html_url":"https://github.com/lslezak","followers_url":"https://api.github.com/users/lslezak/followers","following_url":"https://api.github.com/users/lslezak/following{/other_user}","gists_url":"https://api.github.com/users/lslezak/gists{/gist_id}","starred_url":"https://api.github.com/users/lslezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lslezak/subscriptions","organizations_url":"https://api.github.com/users/lslezak/orgs","repos_url":"https://api.github.com/users/lslezak/repos","events_url":"https://api.github.com/users/lslezak/events{/privacy}","received_events_url":"https://api.github.com/users/lslezak/received_events","type":"User","site_admin":false},"body":"Small improvement: What about sorting the symbols alphabetically? That would make searching for an attribute easier/faster...","created_at":"2014-06-11T07:41:11Z","updated_at":"2014-06-11T07:41:11Z","html_url":"https://github.com/yast/yast-registration/pull/101#discussion_r13637149","pull_request_url":"https://api.github.com/repos/yast/yast-registration/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/comments/13637149"},"html":{"href":"https://github.com/yast/yast-registration/pull/101#discussion_r13637149"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-registration/pulls/101","id":16982166,"html_url":"https://github.com/yast/yast-registration/pull/101","diff_url":"https://github.com/yast/yast-registration/pull/101.diff","patch_url":"https://github.com/yast/yast-registration/pull/101.patch","issue_url":"https://api.github.com/repos/yast/yast-registration/issues/101","number":101,"state":"open","title":"add arch to delegators","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars.githubusercontent.com/u/478871?","gravatar_id":"f9a9cf77af20d925b328ee8c95c0068c","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-11T06:59:49Z","updated_at":"2014-06-11T07:41:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5643c54e9a03ea51f2dce194645193c27556ba5e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-registration/pulls/101/commits","review_comments_url":"https://api.github.com/repos/yast/yast-registration/pulls/101/comments","review_comment_url":"https://api.github.com/repos/yast/yast-registration/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yast/yast-registration/issues/101/comments","statuses_url":"https://api.github.com/repos/yast/yast-registration/statuses/2fc265d5777f4e592a44f5ad29bde7a848df31f6","head":{"label":"yast:fix_crash","ref":"fix_crash","sha":"2fc265d5777f4e592a44f5ad29bde7a848df31f6","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368197,"name":"yast-registration","full_name":"yast/yast-registration","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-registration","description":"YaST module registration","fork":false,"url":"https://api.github.com/repos/yast/yast-registration","forks_url":"https://api.github.com/repos/yast/yast-registration/forks","keys_url":"https://api.github.com/repos/yast/yast-registration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-registration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-registration/teams","hooks_url":"https://api.github.com/repos/yast/yast-registration/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-registration/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-registration/events","assignees_url":"https://api.github.com/repos/yast/yast-registration/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-registration/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-registration/tags","blobs_url":"https://api.github.com/repos/yast/yast-registration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-registration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-registration/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-registration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-registration/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-registration/languages","stargazers_url":"https://api.github.com/repos/yast/yast-registration/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-registration/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-registration/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-registration/subscription","commits_url":"https://api.github.com/repos/yast/yast-registration/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-registration/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-registration/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-registration/issues/comments/{number}","contents_url":"https://api.github.com/repos/yast/yast-registration/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-registration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-registration/merges","archive_url":"https://api.github.com/repos/yast/yast-registration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-registration/downloads","issues_url":"https://api.github.com/repos/yast/yast-registration/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-registration/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-registration/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-registration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-registration/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-registration/releases{/id}","created_at":"2012-05-18T10:25:55Z","updated_at":"2014-06-11T07:29:00Z","pushed_at":"2014-06-11T07:28:59Z","git_url":"git://github.com/yast/yast-registration.git","ssh_url":"git@github.com:yast/yast-registration.git","clone_url":"https://github.com/yast/yast-registration.git","svn_url":"https://github.com/yast/yast-registration","homepage":"http://en.opensuse.org/Portal:YaST","size":7205,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"542ed718e6fcb22f0bb36065b142636f0bc7d7ba","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368197,"name":"yast-registration","full_name":"yast/yast-registration","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-registration","description":"YaST module registration","fork":false,"url":"https://api.github.com/repos/yast/yast-registration","forks_url":"https://api.github.com/repos/yast/yast-registration/forks","keys_url":"https://api.github.com/repos/yast/yast-registration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-registration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-registration/teams","hooks_url":"https://api.github.com/repos/yast/yast-registration/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-registration/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-registration/events","assignees_url":"https://api.github.com/repos/yast/yast-registration/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-registration/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-registration/tags","blobs_url":"https://api.github.com/repos/yast/yast-registration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-registration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-registration/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-registration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-registration/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-registration/languages","stargazers_url":"https://api.github.com/repos/yast/yast-registration/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-registration/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-registration/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-registration/subscription","commits_url":"https://api.github.com/repos/yast/yast-registration/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-registration/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-registration/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-registration/issues/comments/{number}","contents_url":"https://api.github.com/repos/yast/yast-registration/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-registration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-registration/merges","archive_url":"https://api.github.com/repos/yast/yast-registration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-registration/downloads","issues_url":"https://api.github.com/repos/yast/yast-registration/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-registration/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-registration/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-registration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-registration/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-registration/releases{/id}","created_at":"2012-05-18T10:25:55Z","updated_at":"2014-06-11T07:29:00Z","pushed_at":"2014-06-11T07:28:59Z","git_url":"git://github.com/yast/yast-registration.git","ssh_url":"git@github.com:yast/yast-registration.git","clone_url":"https://github.com/yast/yast-registration.git","svn_url":"https://github.com/yast/yast-registration","homepage":"http://en.opensuse.org/Portal:YaST","size":7205,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/101"},"html":{"href":"https://github.com/yast/yast-registration/pull/101"},"issue":{"href":"https://api.github.com/repos/yast/yast-registration/issues/101"},"comments":{"href":"https://api.github.com/repos/yast/yast-registration/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-registration/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-registration/statuses/2fc265d5777f4e592a44f5ad29bde7a848df31f6"}}}}