GitHub PullRequestReviewCommentEvent at 2014-05-13 15:38:05
Repository: cloudfeeds-atomhopper
Actor: shintasmith
Payload: {"comment":{"url":"https://api.github.com/repos/rackerlabs/cloudfeeds-atomhopper/pulls/comments/12590240","id":12590240,"diff_hunk":"@@ -0,0 +1,285 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\"\n+         xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+         xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n+\n+    <modelVersion>4.0.0</modelVersion>\n+\n+    <parent>\n+        <groupId>com.rackspace.feeds</groupId>\n+        <artifactId>cloudfeeds-atomhopper</artifactId>\n+        <version>1.2.21.0-SNAPSHOT</version>\n+        <relativePath>./../pom.xml</relativePath>\n+    </parent>\n+\n+    <groupId>com.rackspace.feeds</groupId>\n+    <artifactId>cf-atomhopper</artifactId>\n+    <packaging>war</packaging>\n+\n+    <name>Cloud Feeds Atom Hopper</name>\n+\n+    <dependencies>\n+\n+        <dependency>\n+            <groupId>org.atomhopper</groupId>\n+            <artifactId>atomhopper</artifactId>\n+           <version>${atomhopper.version}</version>\n+            <type>war</type>\n+        </dependency>\n+\n+        <dependency>\n+            <groupId>com.rackspace.feeds</groupId>\n+            <artifactId>cf-jdbc-adapter</artifactId>\n+        </dependency>\n+    </dependencies>\n+\n+    <build>\n+        <plugins>\n+        <plugin>\n+           <groupId>org.apache.maven.plugins</groupId>\n+            <artifactId>maven-war-plugin</artifactId>\n+            <configuration>\n+               <overlays>\n+                    <overlay>\n+                        <groupId>org.atomhopper</groupId>\n+                        <artifactId>atomhopper</artifactId>\n+                        <excludes>\n+                            <!-- override excluding META-INF by default -->\n+                        </excludes>\n+                    </overlay>\n+                </overlays>\n+            </configuration>\n+        </plugin>\n+            <plugin>\n+                <artifactId>maven-resources-plugin</artifactId>\n+                <executions>\n+                    <execution>\n+                        <id>copy-resources</id>\n+                        <phase>package</phase>\n+                        <goals>\n+                            <goal>copy-resources</goal>\n+                        </goals>\n+                        <configuration>\n+                            <outputDirectory>src/main/webapp/META-INF/maven/org.atomhopper/atomhopper</outputDirectory>\n+                            <resources>\n+                                <resource>\n+                                    <directory>target/maven-archiver</directory>\n+                                </resource>\n+                            </resources>\n+                        </configuration>\n+                    </execution>\n+                </executions>\n+            </plugin>\n+        </plugins>\n+    </build>\n+\n+    <profiles>\n+    <!--\n+        By default we turn off this plugin to make builds faster - however,\n+        if you want to build the RPM simply run maven with\n+        the following option, '-P build-rpm'\n+\n+        Example: mvn -P build-rpm clean install\n+    -->\n+    <profile>\n+        <id>build-rpm</id>\n+        <build>\n+            <plugins>\n+                <plugin>\n+                    <groupId>org.apache.maven.plugins</groupId>\n+                    <artifactId>maven-compiler-plugin</artifactId>\n+                </plugin>\n+\n+                <plugin>\n+                    <groupId>org.apache.maven.plugins</groupId>\n+                    <artifactId>maven-war-plugin</artifactId>\n+                    <configuration>\n+                        <failOnMissingWebXml>true</failOnMissingWebXml>\n+                    </configuration>\n+                </plugin>\n+\n+                <plugin>\n+                    <groupId>org.apache.maven.plugins</groupId>\n+                    <artifactId>maven-dependency-plugin</artifactId>\n+                    <executions>\n+                        <execution>\n+                            <phase>validate</phase>\n+                            <goals>\n+                                <goal>copy</goal>\n+                            </goals>\n+                            <configuration>\n+                                <outputDirectory>${endorsed.dir}</outputDirectory>\n+                                <silent>true</silent>\n+                                <artifactItems>\n+                                    <artifactItem>\n+                                        <groupId>javax</groupId>\n+                                        <artifactId>javaee-endorsed-api</artifactId>","path":"atomhopper/pom.xml","position":116,"original_position":116,"commit_id":"0f876ac38e25afdaea12becc52764d11513c2d83","original_commit_id":"0f876ac38e25afdaea12becc52764d11513c2d83","user":{"login":"shintasmith","id":3640870,"avatar_url":"https://avatars.githubusercontent.com/u/3640870?","gravatar_id":"a47206cfd12b21ccb77891d16fa5bfe1","url":"https://api.github.com/users/shintasmith","html_url":"https://github.com/shintasmith","followers_url":"https://api.github.com/users/shintasmith/followers","following_url":"https://api.github.com/users/shintasmith/following{/other_user}","gists_url":"https://api.github.com/users/shintasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/shintasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shintasmith/subscriptions","organizations_url":"https://api.github.com/users/shintasmith/orgs","repos_url":"https://api.github.com/users/shintasmith/repos","events_url":"https://api.github.com/users/shintasmith/events{/privacy}","received_events_url":"https://api.github.com/users/shintasmith/received_events","type":"User","site_admin":false},"body":"Just curious what is this one needed for?","created_at":"2014-05-13T15:38:05Z","updated_at":"2014-05-13T15:38:05Z","html_url":"https://github.com/rackerlabs/cloudfeeds-atomhopper/pull/1#discussion_r12590240","pull_request_url":"https://api.github.com/repos/rackerlabs/cloudfeeds-atomhopper/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/cloudfeeds-atomhopper/pulls/comments/12590240"},"html":{"href":"https://github.com/rackerlabs/cloudfeeds-atomhopper/pull/1#discussion_r12590240"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/cloudfeeds-atomhopper/pulls/1"}}}}