GitHub PullRequestReviewCommentEvent at 2014-04-14 05:49:36
Repository: DefinitelyTyped
Actor: loyd
Payload: {"comment":{"url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/comments/11571869","id":11571869,"diff_hunk":"@@ -42,147 +42,167 @@ declare var module: {\n     loaded: boolean;\r\n     parent: any;\r\n     children: any[];\r\n-}\r\n+};\r\n \r\n // Same as module.exports\r\n declare var exports: any;\r\n declare var SlowBuffer: {\r\n-    new (str: string, encoding?: string): NodeBuffer;\r\n-    new (size: number): NodeBuffer;\r\n-    new (array: any[]): NodeBuffer;\r\n-    prototype: NodeBuffer;\r\n+    new (str: string, encoding?: string): Buffer;\r\n+    new (size: number): Buffer;\r\n+    new (array: any[]): Buffer;\r\n+    prototype: Buffer;\r\n     isBuffer(obj: any): boolean;\r\n     byteLength(string: string, encoding?: string): number;\r\n-    concat(list: NodeBuffer[], totalLength?: number): NodeBuffer;\r\n+    concat(list: Buffer[], totalLength?: number): Buffer;\r\n };\r\n+\r\n+\r\n+// Buffer class\r\n+interface Buffer extends NodeBuffer {}\r","path":"node/node.d.ts","position":68,"original_position":68,"commit_id":"380753960aa7d876d88abbe42077d86f0765e71a","original_commit_id":"380753960aa7d876d88abbe42077d86f0765e71a","user":{"login":"loyd","id":952180,"avatar_url":"https://avatars.githubusercontent.com/u/952180?","gravatar_id":"5c6610c8f25c0a26495fbb8c831a0636","url":"https://api.github.com/users/loyd","html_url":"https://github.com/loyd","followers_url":"https://api.github.com/users/loyd/followers","following_url":"https://api.github.com/users/loyd/following{/other_user}","gists_url":"https://api.github.com/users/loyd/gists{/gist_id}","starred_url":"https://api.github.com/users/loyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loyd/subscriptions","organizations_url":"https://api.github.com/users/loyd/orgs","repos_url":"https://api.github.com/users/loyd/repos","events_url":"https://api.github.com/users/loyd/events{/privacy}","received_events_url":"https://api.github.com/users/loyd/received_events","type":"User","site_admin":false},"body":"It's not code style. In nodejs `Buffer` exists as class. Why we should divide it?","created_at":"2014-04-14T05:49:36Z","updated_at":"2014-04-14T05:49:36Z","html_url":"https://github.com/borisyankov/DefinitelyTyped/pull/2020#discussion_r11571869","pull_request_url":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/2020","_links":{"self":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/comments/11571869"},"html":{"href":"https://github.com/borisyankov/DefinitelyTyped/pull/2020#discussion_r11571869"},"pull_request":{"href":"https://api.github.com/repos/borisyankov/DefinitelyTyped/pulls/2020"}}}}