GitHub PullRequestReviewCommentEvent at 2014-04-29 08:11:50
Repository: kite
Actor: tomwhite
Payload: {"comment":{"url":"https://api.github.com/repos/kite-sdk/kite/pulls/comments/12082992","id":12082992,"diff_hunk":"@@ -0,0 +1,299 @@\n+/**\n+ * Copyright 2013 Cloudera Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.kitesdk.data;\n+\n+import com.google.common.base.Objects;\n+import com.google.common.collect.ImmutableList;\n+import java.util.ArrayList;\n+import java.util.Collection;\n+import java.util.HashSet;\n+import java.util.Set;\n+import javax.annotation.Nullable;\n+import javax.annotation.concurrent.Immutable;\n+import org.kitesdk.data.spi.ColumnMappingParser;\n+import org.kitesdk.data.spi.FieldMapping;\n+\n+/**\n+ * A descriptor for an entity's column mappings, which defines how an entity\n+ * maps to a columnar store.\n+ */\n+@Immutable\n+public class ColumnMapping {\n+\n+  private final Collection<FieldMapping> fieldMappings;\n+\n+  private ColumnMapping(Collection<FieldMapping> mappings) {\n+    fieldMappings = ImmutableList.copyOf(mappings);\n+  }\n+\n+  public Collection<FieldMapping> getFieldMappings() {","path":"kite-data/kite-data-core/src/main/java/org/kitesdk/data/ColumnMapping.java","position":42,"original_position":42,"commit_id":"edee41a16dcc88e72afa1033c85f1a0264f23f79","original_commit_id":"edee41a16dcc88e72afa1033c85f1a0264f23f79","user":{"login":"tomwhite","id":85085,"avatar_url":"https://avatars.githubusercontent.com/u/85085?","gravatar_id":"6304ed357cb664724690be4d04ab5603","url":"https://api.github.com/users/tomwhite","html_url":"https://github.com/tomwhite","followers_url":"https://api.github.com/users/tomwhite/followers","following_url":"https://api.github.com/users/tomwhite/following{/other_user}","gists_url":"https://api.github.com/users/tomwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwhite/subscriptions","organizations_url":"https://api.github.com/users/tomwhite/orgs","repos_url":"https://api.github.com/users/tomwhite/repos","events_url":"https://api.github.com/users/tomwhite/events{/privacy}","received_events_url":"https://api.github.com/users/tomwhite/received_events","type":"User","site_admin":false},"body":"We shouldn't expose an SPI class in the public API. Does this method need to be exposed to users?","created_at":"2014-04-29T08:11:50Z","updated_at":"2014-04-29T08:11:50Z","html_url":"https://github.com/kite-sdk/kite/pull/63#discussion_r12082992","pull_request_url":"https://api.github.com/repos/kite-sdk/kite/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/comments/12082992"},"html":{"href":"https://github.com/kite-sdk/kite/pull/63#discussion_r12082992"},"pull_request":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/63"}}}}