GitHub PullRequestEvent at 2014-01-09 00:47:28
Repository: spree_fancy
Actor: radar
Payload: {"action":"closed","number":86,"pull_request":{"url":"https://api.github.com/repos/spree/spree_fancy/pulls/86","id":11235981,"html_url":"https://github.com/spree/spree_fancy/pull/86","diff_url":"https://github.com/spree/spree_fancy/pull/86.diff","patch_url":"https://github.com/spree/spree_fancy/pull/86.patch","issue_url":"https://github.com/spree/spree_fancy/pull/86","number":86,"state":"closed","title":"fixes easy drop down at checkout","user":{"login":"laertiades","id":5271776,"avatar_url":"https://gravatar.com/avatar/9840ef99fa299616cc131d8dfa55fa45?d=https%3A%2F%2Fidenticons.github.com%2F1c78fcb43f072f7d756e09cca25319a0.png&r=x","gravatar_id":"9840ef99fa299616cc131d8dfa55fa45","url":"https://api.github.com/users/laertiades","html_url":"https://github.com/laertiades","followers_url":"https://api.github.com/users/laertiades/followers","following_url":"https://api.github.com/users/laertiades/following{/other_user}","gists_url":"https://api.github.com/users/laertiades/gists{/gist_id}","starred_url":"https://api.github.com/users/laertiades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laertiades/subscriptions","organizations_url":"https://api.github.com/users/laertiades/orgs","repos_url":"https://api.github.com/users/laertiades/repos","events_url":"https://api.github.com/users/laertiades/events{/privacy}","received_events_url":"https://api.github.com/users/laertiades/received_events","type":"User","site_admin":false},"body":"This pull addresses a number of issues resulting from the use of the easy drop down menu with the state selection menu at checkout.  See https://github.com/spree/spree_fancy/issues/80\r\n\r\nInconsistancy with respect to menu sizing and selection return value have been fixed by upgrading to the current version of easy pull down.\r\n\r\nThe incorrect display of the state selection box for countries without states and the inability to dynamically update state selection options are fixed by overriding the fillStates function which is originally part of checkout.js of the Spree frontend.  In order to use the new function I had to unbind previously set change event handlers and rebind them to a redefined updateState function which references the new fillStates function.\r\n\r\n-Jesse","created_at":"2014-01-05T16:27:15Z","updated_at":"2014-01-09T00:47:28Z","closed_at":"2014-01-09T00:47:28Z","merged_at":null,"merge_commit_sha":"74722e77b2317da6d6b39212d225023f7de9cd2a","assignee":null,"milestone":null,"commits_url":"https://github.com/spree/spree_fancy/pull/86/commits","review_comments_url":"https://github.com/spree/spree_fancy/pull/86/comments","review_comment_url":"/repos/spree/spree_fancy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spree/spree_fancy/issues/86/comments","statuses_url":"https://api.github.com/repos/spree/spree_fancy/statuses/8aa43dbc192ca56c7ad8d9ecf62c97aedc3f2910","head":{"label":"laertiades:2-1-stable","ref":"2-1-stable","sha":"8aa43dbc192ca56c7ad8d9ecf62c97aedc3f2910","user":{"login":"laertiades","id":5271776,"avatar_url":"https://gravatar.com/avatar/9840ef99fa299616cc131d8dfa55fa45?d=https%3A%2F%2Fidenticons.github.com%2F1c78fcb43f072f7d756e09cca25319a0.png&r=x","gravatar_id":"9840ef99fa299616cc131d8dfa55fa45","url":"https://api.github.com/users/laertiades","html_url":"https://github.com/laertiades","followers_url":"https://api.github.com/users/laertiades/followers","following_url":"https://api.github.com/users/laertiades/following{/other_user}","gists_url":"https://api.github.com/users/laertiades/gists{/gist_id}","starred_url":"https://api.github.com/users/laertiades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laertiades/subscriptions","organizations_url":"https://api.github.com/users/laertiades/orgs","repos_url":"https://api.github.com/users/laertiades/repos","events_url":"https://api.github.com/users/laertiades/events{/privacy}","received_events_url":"https://api.github.com/users/laertiades/received_events","type":"User","site_admin":false},"repo":{"id":15642587,"name":"spree_fancy","full_name":"laertiades/spree_fancy","owner":{"login":"laertiades","id":5271776,"avatar_url":"https://gravatar.com/avatar/9840ef99fa299616cc131d8dfa55fa45?d=https%3A%2F%2Fidenticons.github.com%2F1c78fcb43f072f7d756e09cca25319a0.png&r=x","gravatar_id":"9840ef99fa299616cc131d8dfa55fa45","url":"https://api.github.com/users/laertiades","html_url":"https://github.com/laertiades","followers_url":"https://api.github.com/users/laertiades/followers","following_url":"https://api.github.com/users/laertiades/following{/other_user}","gists_url":"https://api.github.com/users/laertiades/gists{/gist_id}","starred_url":"https://api.github.com/users/laertiades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laertiades/subscriptions","organizations_url":"https://api.github.com/users/laertiades/orgs","repos_url":"https://api.github.com/users/laertiades/repos","events_url":"https://api.github.com/users/laertiades/events{/privacy}","received_events_url":"https://api.github.com/users/laertiades/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laertiades/spree_fancy","description":"","fork":true,"url":"https://api.github.com/repos/laertiades/spree_fancy","forks_url":"https://api.github.com/repos/laertiades/spree_fancy/forks","keys_url":"https://api.github.com/repos/laertiades/spree_fancy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laertiades/spree_fancy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laertiades/spree_fancy/teams","hooks_url":"https://api.github.com/repos/laertiades/spree_fancy/hooks","issue_events_url":"https://api.github.com/repos/laertiades/spree_fancy/issues/events{/number}","events_url":"https://api.github.com/repos/laertiades/spree_fancy/events","assignees_url":"https://api.github.com/repos/laertiades/spree_fancy/assignees{/user}","branches_url":"https://api.github.com/repos/laertiades/spree_fancy/branches{/branch}","tags_url":"https://api.github.com/repos/laertiades/spree_fancy/tags","blobs_url":"https://api.github.com/repos/laertiades/spree_fancy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laertiades/spree_fancy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laertiades/spree_fancy/git/refs{/sha}","trees_url":"https://api.github.com/repos/laertiades/spree_fancy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laertiades/spree_fancy/statuses/{sha}","languages_url":"https://api.github.com/repos/laertiades/spree_fancy/languages","stargazers_url":"https://api.github.com/repos/laertiades/spree_fancy/stargazers","contributors_url":"https://api.github.com/repos/laertiades/spree_fancy/contributors","subscribers_url":"https://api.github.com/repos/laertiades/spree_fancy/subscribers","subscription_url":"https://api.github.com/repos/laertiades/spree_fancy/subscription","commits_url":"https://api.github.com/repos/laertiades/spree_fancy/commits{/sha}","git_commits_url":"https://api.github.com/repos/laertiades/spree_fancy/git/commits{/sha}","comments_url":"https://api.github.com/repos/laertiades/spree_fancy/comments{/number}","issue_comment_url":"https://api.github.com/repos/laertiades/spree_fancy/issues/comments/{number}","contents_url":"https://api.github.com/repos/laertiades/spree_fancy/contents/{+path}","compare_url":"https://api.github.com/repos/laertiades/spree_fancy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laertiades/spree_fancy/merges","archive_url":"https://api.github.com/repos/laertiades/spree_fancy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laertiades/spree_fancy/downloads","issues_url":"https://api.github.com/repos/laertiades/spree_fancy/issues{/number}","pulls_url":"https://api.github.com/repos/laertiades/spree_fancy/pulls{/number}","milestones_url":"https://api.github.com/repos/laertiades/spree_fancy/milestones{/number}","notifications_url":"https://api.github.com/repos/laertiades/spree_fancy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laertiades/spree_fancy/labels{/name}","releases_url":"https://api.github.com/repos/laertiades/spree_fancy/releases{/id}","created_at":"2014-01-05T00:35:27Z","updated_at":"2014-01-09T00:47:28Z","pushed_at":"2014-01-05T15:51:24Z","git_url":"git://github.com/laertiades/spree_fancy.git","ssh_url":"git@github.com:laertiades/spree_fancy.git","clone_url":"https://github.com/laertiades/spree_fancy.git","svn_url":"https://github.com/laertiades/spree_fancy","homepage":null,"size":388,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"spree:2-1-stable","ref":"2-1-stable","sha":"3dd09fa59ce0b6d4c8d0bfa923af5e26efdff5aa","user":{"login":"spree","id":56702,"avatar_url":"https://gravatar.com/avatar/a8a976a326bec5a34f35404dcb0d1fa6?d=https%3A%2F%2Fidenticons.github.com%2Fa4713247c553519f3d5df34d190cd021.png&r=x","gravatar_id":"a8a976a326bec5a34f35404dcb0d1fa6","url":"https://api.github.com/users/spree","html_url":"https://github.com/spree","followers_url":"https://api.github.com/users/spree/followers","following_url":"https://api.github.com/users/spree/following{/other_user}","gists_url":"https://api.github.com/users/spree/gists{/gist_id}","starred_url":"https://api.github.com/users/spree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spree/subscriptions","organizations_url":"https://api.github.com/users/spree/orgs","repos_url":"https://api.github.com/users/spree/repos","events_url":"https://api.github.com/users/spree/events{/privacy}","received_events_url":"https://api.github.com/users/spree/received_events","type":"Organization","site_admin":false},"repo":{"id":7034729,"name":"spree_fancy","full_name":"spree/spree_fancy","owner":{"login":"spree","id":56702,"avatar_url":"https://gravatar.com/avatar/a8a976a326bec5a34f35404dcb0d1fa6?d=https%3A%2F%2Fidenticons.github.com%2Fa4713247c553519f3d5df34d190cd021.png&r=x","gravatar_id":"a8a976a326bec5a34f35404dcb0d1fa6","url":"https://api.github.com/users/spree","html_url":"https://github.com/spree","followers_url":"https://api.github.com/users/spree/followers","following_url":"https://api.github.com/users/spree/following{/other_user}","gists_url":"https://api.github.com/users/spree/gists{/gist_id}","starred_url":"https://api.github.com/users/spree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spree/subscriptions","organizations_url":"https://api.github.com/users/spree/orgs","repos_url":"https://api.github.com/users/spree/repos","events_url":"https://api.github.com/users/spree/events{/privacy}","received_events_url":"https://api.github.com/users/spree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spree/spree_fancy","description":"","fork":false,"url":"https://api.github.com/repos/spree/spree_fancy","forks_url":"https://api.github.com/repos/spree/spree_fancy/forks","keys_url":"https://api.github.com/repos/spree/spree_fancy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spree/spree_fancy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spree/spree_fancy/teams","hooks_url":"https://api.github.com/repos/spree/spree_fancy/hooks","issue_events_url":"https://api.github.com/repos/spree/spree_fancy/issues/events{/number}","events_url":"https://api.github.com/repos/spree/spree_fancy/events","assignees_url":"https://api.github.com/repos/spree/spree_fancy/assignees{/user}","branches_url":"https://api.github.com/repos/spree/spree_fancy/branches{/branch}","tags_url":"https://api.github.com/repos/spree/spree_fancy/tags","blobs_url":"https://api.github.com/repos/spree/spree_fancy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spree/spree_fancy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spree/spree_fancy/git/refs{/sha}","trees_url":"https://api.github.com/repos/spree/spree_fancy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spree/spree_fancy/statuses/{sha}","languages_url":"https://api.github.com/repos/spree/spree_fancy/languages","stargazers_url":"https://api.github.com/repos/spree/spree_fancy/stargazers","contributors_url":"https://api.github.com/repos/spree/spree_fancy/contributors","subscribers_url":"https://api.github.com/repos/spree/spree_fancy/subscribers","subscription_url":"https://api.github.com/repos/spree/spree_fancy/subscription","commits_url":"https://api.github.com/repos/spree/spree_fancy/commits{/sha}","git_commits_url":"https://api.github.com/repos/spree/spree_fancy/git/commits{/sha}","comments_url":"https://api.github.com/repos/spree/spree_fancy/comments{/number}","issue_comment_url":"https://api.github.com/repos/spree/spree_fancy/issues/comments/{number}","contents_url":"https://api.github.com/repos/spree/spree_fancy/contents/{+path}","compare_url":"https://api.github.com/repos/spree/spree_fancy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spree/spree_fancy/merges","archive_url":"https://api.github.com/repos/spree/spree_fancy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spree/spree_fancy/downloads","issues_url":"https://api.github.com/repos/spree/spree_fancy/issues{/number}","pulls_url":"https://api.github.com/repos/spree/spree_fancy/pulls{/number}","milestones_url":"https://api.github.com/repos/spree/spree_fancy/milestones{/number}","notifications_url":"https://api.github.com/repos/spree/spree_fancy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spree/spree_fancy/labels{/name}","releases_url":"https://api.github.com/repos/spree/spree_fancy/releases{/id}","created_at":"2012-12-06T11:45:29Z","updated_at":"2014-01-06T21:02:47Z","pushed_at":"2014-01-09T00:47:28Z","git_url":"git://github.com/spree/spree_fancy.git","ssh_url":"git@github.com:spree/spree_fancy.git","clone_url":"https://github.com/spree/spree_fancy.git","svn_url":"https://github.com/spree/spree_fancy","homepage":null,"size":737,"stargazers_count":47,"watchers_count":47,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":119,"mirror_url":null,"open_issues_count":18,"forks":119,"open_issues":18,"watchers":47,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spree/spree_fancy/pulls/86"},"html":{"href":"https://github.com/spree/spree_fancy/pull/86"},"issue":{"href":"https://api.github.com/repos/spree/spree_fancy/issues/86"},"comments":{"href":"https://api.github.com/repos/spree/spree_fancy/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/spree/spree_fancy/pulls/86/comments"},"statuses":{"href":"https://api.github.com/repos/spree/spree_fancy/statuses/8aa43dbc192ca56c7ad8d9ecf62c97aedc3f2910"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":127,"deletions":12,"changed_files":2}}