GitHub PullRequestReviewCommentEvent at 2014-05-19 11:40:19
Repository: gaia
Actor: davehunt
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/12790034","id":12790034,"diff_hunk":"@@ -229,34 +239,55 @@ var GaiaApps = {\n     );\n   },\n \n+  getLaunchPathForName: function(appName) {\n+    let apps = window.wrappedJSObject.applications || window.wrappedJSObject.Applications;\n+    let installedApps = apps.installedApps;\n+\n+    for (let manifestURL in installedApps) {\n+      let app = installedApps[manifestURL];","path":"tests/atoms/gaia_apps.js","position":78,"original_position":78,"commit_id":"27133388bff0bbd01887f7537f25599b97b1d72b","original_commit_id":"27133388bff0bbd01887f7537f25599b97b1d72b","user":{"login":"davehunt","id":122800,"avatar_url":"https://avatars.githubusercontent.com/u/122800?","gravatar_id":"fd74178aadc963ffc6397ad1e22d8ce7","url":"https://api.github.com/users/davehunt","html_url":"https://github.com/davehunt","followers_url":"https://api.github.com/users/davehunt/followers","following_url":"https://api.github.com/users/davehunt/following{/other_user}","gists_url":"https://api.github.com/users/davehunt/gists{/gist_id}","starred_url":"https://api.github.com/users/davehunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehunt/subscriptions","organizations_url":"https://api.github.com/users/davehunt/orgs","repos_url":"https://api.github.com/users/davehunt/repos","events_url":"https://api.github.com/users/davehunt/events{/privacy}","received_events_url":"https://api.github.com/users/davehunt/received_events","type":"User","site_admin":false},"body":"Forgive my tired brain. If the key is really the manifest URL, then your original code is fine. :smile:","created_at":"2014-05-19T11:40:19Z","updated_at":"2014-05-19T11:40:19Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/19326#discussion_r12790034","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/19326","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/12790034"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/19326#discussion_r12790034"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/19326"}}}}