GitHub PullRequestReviewCommentEvent at 2014-11-14 23:57:03
Repository: level_up_exercises
Actor: jmmastey
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/20395322","id":20395322,"diff_hunk":"@@ -0,0 +1,74 @@\n+require 'spec_helper'\n+\n+require_relative 'ab_data_parser'\n+\n+describe ABDataParser do\n+  subject(:parser) { ABDataParser.new }\n+\n+  context 'When passing invalid arguments' do\n+    it 'with 0 arugment' do\n+      expect { parser.parse_data }.to raise_error(ArgumentError)\n+    end\n+\n+    it 'with invalid json obj' do\n+      args = {  file_name: 'test.json', variant_ke: 'test',\n+                result: 'test' }\n+      expect { parser.parse_data(args) }.to raise_error(ArgumentError)\n+    end\n+\n+    it 'with non-json file' do\n+      args = {  file_name: 'test.csv',\n+                variant_key: 'Test', result_key: 'result' }\n+      expect { parser.parse_data(args) }.to raise_error(InvalidFileTypeError)\n+    end\n+\n+    it 'with unkonwn file' do\n+      args = {  file_name: 'test.json',\n+                variant_key: 'Test', result_key: 'result' }\n+      expect { parser.parse_data(args) }.to raise_error(FileNotFoundError)\n+    end\n+  end\n+\n+  context 'When passing valid argument' do\n+    let(:returned_result) do\n+      option = { file_name: 'source_data.json',\n+                 variant_key: 'cohort', result_key: 'result' }\n+      parser.parse_data(option)\n+    end\n+    subject { returned_result }\n+\n+    it 'should not be empty' do\n+      expect(returned_result).not_to be_empty\n+    end\n+\n+    context 'result should contain two variants A and B' do\n+      it 'should have A' do\n+        expect(returned_result).to have_key(:A)","path":"data_science/ab_data_parser_spec.rb","position":46,"original_position":46,"commit_id":"76b648fd0a1e2787410e431b05e56722b37b6a6c","original_commit_id":"76b648fd0a1e2787410e431b05e56722b37b6a6c","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"body":"For instance, is it _really_ a feature of `ABDataParser` that there's an A group? If so, why abstract the `variant_key` at all? If not, then that's not a reasonable assertion in this test.","created_at":"2014-11-14T23:57:03Z","updated_at":"2014-11-14T23:57:03Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/268#discussion_r20395322","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/268","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/20395322"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/268#discussion_r20395322"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/268","id":24416636,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/268","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/268.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/268.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/268","number":268,"state":"open","locked":false,"title":"Update data science solution","user":{"login":"zachary-huang","id":9355572,"avatar_url":"https://avatars.githubusercontent.com/u/9355572?v=3","gravatar_id":"","url":"https://api.github.com/users/zachary-huang","html_url":"https://github.com/zachary-huang","followers_url":"https://api.github.com/users/zachary-huang/followers","following_url":"https://api.github.com/users/zachary-huang/following{/other_user}","gists_url":"https://api.github.com/users/zachary-huang/gists{/gist_id}","starred_url":"https://api.github.com/users/zachary-huang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachary-huang/subscriptions","organizations_url":"https://api.github.com/users/zachary-huang/orgs","repos_url":"https://api.github.com/users/zachary-huang/repos","events_url":"https://api.github.com/users/zachary-huang/events{/privacy}","received_events_url":"https://api.github.com/users/zachary-huang/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-14T02:15:47Z","updated_at":"2014-11-14T23:57:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f90d96cccff8e9f8d68a5e8eba8681fd85b7b5d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/268/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/268/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/268/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/76b648fd0a1e2787410e431b05e56722b37b6a6c","head":{"label":"zachary-huang:data_science_solution","ref":"data_science_solution","sha":"76b648fd0a1e2787410e431b05e56722b37b6a6c","user":{"login":"zachary-huang","id":9355572,"avatar_url":"https://avatars.githubusercontent.com/u/9355572?v=3","gravatar_id":"","url":"https://api.github.com/users/zachary-huang","html_url":"https://github.com/zachary-huang","followers_url":"https://api.github.com/users/zachary-huang/followers","following_url":"https://api.github.com/users/zachary-huang/following{/other_user}","gists_url":"https://api.github.com/users/zachary-huang/gists{/gist_id}","starred_url":"https://api.github.com/users/zachary-huang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachary-huang/subscriptions","organizations_url":"https://api.github.com/users/zachary-huang/orgs","repos_url":"https://api.github.com/users/zachary-huang/repos","events_url":"https://api.github.com/users/zachary-huang/events{/privacy}","received_events_url":"https://api.github.com/users/zachary-huang/received_events","type":"User","site_admin":false},"repo":{"id":25651432,"name":"level_up_exercises","full_name":"zachary-huang/level_up_exercises","owner":{"login":"zachary-huang","id":9355572,"avatar_url":"https://avatars.githubusercontent.com/u/9355572?v=3","gravatar_id":"","url":"https://api.github.com/users/zachary-huang","html_url":"https://github.com/zachary-huang","followers_url":"https://api.github.com/users/zachary-huang/followers","following_url":"https://api.github.com/users/zachary-huang/following{/other_user}","gists_url":"https://api.github.com/users/zachary-huang/gists{/gist_id}","starred_url":"https://api.github.com/users/zachary-huang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachary-huang/subscriptions","organizations_url":"https://api.github.com/users/zachary-huang/orgs","repos_url":"https://api.github.com/users/zachary-huang/repos","events_url":"https://api.github.com/users/zachary-huang/events{/privacy}","received_events_url":"https://api.github.com/users/zachary-huang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zachary-huang/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/zachary-huang/level_up_exercises","forks_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/forks","keys_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/events","assignees_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/merges","archive_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/zachary-huang/level_up_exercises/releases{/id}","created_at":"2014-10-23T18:23:38Z","updated_at":"2014-10-09T06:13:13Z","pushed_at":"2014-11-14T02:14:29Z","git_url":"git://github.com/zachary-huang/level_up_exercises.git","ssh_url":"git@github.com:zachary-huang/level_up_exercises.git","clone_url":"https://github.com/zachary-huang/level_up_exercises.git","svn_url":"https://github.com/zachary-huang/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":332,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"d6fb3782079429bc5629858bbd6c76ee3d4906b0","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2014-10-30T16:04:17Z","pushed_at":"2014-11-05T12:49:26Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":39009,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":5,"forks":46,"open_issues":5,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/268"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/268"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/268"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/76b648fd0a1e2787410e431b05e56722b37b6a6c"}}}}