GitHub PullRequestReviewCommentEvent at 2014-08-29 17:33:53
Repository: restful
Actor: mateu-aguilo-bosch
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Gizra/restful/pulls/comments/16910310","id":16910310,"diff_hunk":"@@ -87,39 +100,41 @@ public function checkRateLimit($request) {\n     $now->setTimestamp(REQUEST_TIME);\n     // Check all rate limits configured for this handler.\n     foreach ($this->getPluginInfo() as $event_name => $info) {\n-      // If the limit is unlimited then skip everything.\n-      $limit = $this->rateLimit($info);\n-      if ($limit == static::UNLIMITED_RATE_LIMIT) {\n-        // User has unlimited access to the resources.\n-        continue;\n-      }\n       // Check if there is a rate_limit plugin for the event.\n       // There are no error checks on purpose, let the exceptions bubble up.\n       $rate_limit_plugin = restful_get_rate_limit_plugin($info['event']);\n       $rate_limit_class = ctools_plugin_get_class($rate_limit_plugin, 'class');\n \n-      $handler = new $rate_limit_class();\n+      /** @var \\RestfulRateLimitBase $handler */","path":"plugins/rate_limit/RestfulRateLimitManager.php","position":60,"original_position":60,"commit_id":"d6d8fe0b789f9556f34dbbd4f72d0527a9f70e7a","original_commit_id":"d6d8fe0b789f9556f34dbbd4f72d0527a9f70e7a","user":{"login":"mateu-aguilo-bosch","id":1140906,"avatar_url":"https://avatars.githubusercontent.com/u/1140906?v=2","gravatar_id":"60104ccf4cf2c8024d1cc94ea9d561cc","url":"https://api.github.com/users/mateu-aguilo-bosch","html_url":"https://github.com/mateu-aguilo-bosch","followers_url":"https://api.github.com/users/mateu-aguilo-bosch/followers","following_url":"https://api.github.com/users/mateu-aguilo-bosch/following{/other_user}","gists_url":"https://api.github.com/users/mateu-aguilo-bosch/gists{/gist_id}","starred_url":"https://api.github.com/users/mateu-aguilo-bosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateu-aguilo-bosch/subscriptions","organizations_url":"https://api.github.com/users/mateu-aguilo-bosch/orgs","repos_url":"https://api.github.com/users/mateu-aguilo-bosch/repos","events_url":"https://api.github.com/users/mateu-aguilo-bosch/events{/privacy}","received_events_url":"https://api.github.com/users/mateu-aguilo-bosch/received_events","type":"User","site_admin":false},"body":"Not a fan of soft type hinting for IDE love, eh? I'll have it removed. :stuck_out_tongue: ","created_at":"2014-08-29T17:33:53Z","updated_at":"2014-08-29T17:33:53Z","html_url":"https://github.com/Gizra/restful/pull/121#discussion_r16910310","pull_request_url":"https://api.github.com/repos/Gizra/restful/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/Gizra/restful/pulls/comments/16910310"},"html":{"href":"https://github.com/Gizra/restful/pull/121#discussion_r16910310"},"pull_request":{"href":"https://api.github.com/repos/Gizra/restful/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/Gizra/restful/pulls/121","id":18958878,"html_url":"https://github.com/Gizra/restful/pull/121","diff_url":"https://github.com/Gizra/restful/pull/121.diff","patch_url":"https://github.com/Gizra/restful/pull/121.patch","issue_url":"https://api.github.com/repos/Gizra/restful/issues/121","number":121,"state":"open","locked":false,"title":"General rate limit","user":{"login":"mateu-aguilo-bosch","id":1140906,"avatar_url":"https://avatars.githubusercontent.com/u/1140906?v=2","gravatar_id":"60104ccf4cf2c8024d1cc94ea9d561cc","url":"https://api.github.com/users/mateu-aguilo-bosch","html_url":"https://github.com/mateu-aguilo-bosch","followers_url":"https://api.github.com/users/mateu-aguilo-bosch/followers","following_url":"https://api.github.com/users/mateu-aguilo-bosch/following{/other_user}","gists_url":"https://api.github.com/users/mateu-aguilo-bosch/gists{/gist_id}","starred_url":"https://api.github.com/users/mateu-aguilo-bosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateu-aguilo-bosch/subscriptions","organizations_url":"https://api.github.com/users/mateu-aguilo-bosch/orgs","repos_url":"https://api.github.com/users/mateu-aguilo-bosch/repos","events_url":"https://api.github.com/users/mateu-aguilo-bosch/events{/privacy}","received_events_url":"https://api.github.com/users/mateu-aguilo-bosch/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-28T10:12:08Z","updated_at":"2014-08-29T17:33:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"356f9ee910b8500bca2adb48785f93e2660d01ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Gizra/restful/pulls/121/commits","review_comments_url":"https://api.github.com/repos/Gizra/restful/pulls/121/comments","review_comment_url":"https://api.github.com/repos/Gizra/restful/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Gizra/restful/issues/121/comments","statuses_url":"https://api.github.com/repos/Gizra/restful/statuses/d6d8fe0b789f9556f34dbbd4f72d0527a9f70e7a","head":{"label":"mateu-aguilo-bosch:105-general-rate-limit","ref":"105-general-rate-limit","sha":"d6d8fe0b789f9556f34dbbd4f72d0527a9f70e7a","user":{"login":"mateu-aguilo-bosch","id":1140906,"avatar_url":"https://avatars.githubusercontent.com/u/1140906?v=2","gravatar_id":"60104ccf4cf2c8024d1cc94ea9d561cc","url":"https://api.github.com/users/mateu-aguilo-bosch","html_url":"https://github.com/mateu-aguilo-bosch","followers_url":"https://api.github.com/users/mateu-aguilo-bosch/followers","following_url":"https://api.github.com/users/mateu-aguilo-bosch/following{/other_user}","gists_url":"https://api.github.com/users/mateu-aguilo-bosch/gists{/gist_id}","starred_url":"https://api.github.com/users/mateu-aguilo-bosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateu-aguilo-bosch/subscriptions","organizations_url":"https://api.github.com/users/mateu-aguilo-bosch/orgs","repos_url":"https://api.github.com/users/mateu-aguilo-bosch/repos","events_url":"https://api.github.com/users/mateu-aguilo-bosch/events{/privacy}","received_events_url":"https://api.github.com/users/mateu-aguilo-bosch/received_events","type":"User","site_admin":false},"repo":{"id":19935082,"name":"restful","full_name":"mateu-aguilo-bosch/restful","owner":{"login":"mateu-aguilo-bosch","id":1140906,"avatar_url":"https://avatars.githubusercontent.com/u/1140906?v=2","gravatar_id":"60104ccf4cf2c8024d1cc94ea9d561cc","url":"https://api.github.com/users/mateu-aguilo-bosch","html_url":"https://github.com/mateu-aguilo-bosch","followers_url":"https://api.github.com/users/mateu-aguilo-bosch/followers","following_url":"https://api.github.com/users/mateu-aguilo-bosch/following{/other_user}","gists_url":"https://api.github.com/users/mateu-aguilo-bosch/gists{/gist_id}","starred_url":"https://api.github.com/users/mateu-aguilo-bosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateu-aguilo-bosch/subscriptions","organizations_url":"https://api.github.com/users/mateu-aguilo-bosch/orgs","repos_url":"https://api.github.com/users/mateu-aguilo-bosch/repos","events_url":"https://api.github.com/users/mateu-aguilo-bosch/events{/privacy}","received_events_url":"https://api.github.com/users/mateu-aguilo-bosch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mateu-aguilo-bosch/restful","description":"RESTful best practices for Drupal","fork":true,"url":"https://api.github.com/repos/mateu-aguilo-bosch/restful","forks_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/forks","keys_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/teams","hooks_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/hooks","issue_events_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/issues/events{/number}","events_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/events","assignees_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/assignees{/user}","branches_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/branches{/branch}","tags_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/tags","blobs_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/git/refs{/sha}","trees_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/statuses/{sha}","languages_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/languages","stargazers_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/stargazers","contributors_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/contributors","subscribers_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/subscribers","subscription_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/subscription","commits_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/commits{/sha}","git_commits_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/git/commits{/sha}","comments_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/comments{/number}","issue_comment_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/issues/comments/{number}","contents_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/contents/{+path}","compare_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/merges","archive_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/downloads","issues_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/issues{/number}","pulls_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/pulls{/number}","milestones_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/milestones{/number}","notifications_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/labels{/name}","releases_url":"https://api.github.com/repos/mateu-aguilo-bosch/restful/releases{/id}","created_at":"2014-05-19T08:55:09Z","updated_at":"2014-06-24T12:38:26Z","pushed_at":"2014-08-29T10:09:56Z","git_url":"git://github.com/mateu-aguilo-bosch/restful.git","ssh_url":"git@github.com:mateu-aguilo-bosch/restful.git","clone_url":"https://github.com/mateu-aguilo-bosch/restful.git","svn_url":"https://github.com/mateu-aguilo-bosch/restful","homepage":"","size":1298,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"7.x-1.x"}},"base":{"label":"Gizra:7.x-1.x","ref":"7.x-1.x","sha":"0b5baee7e70b4b14d2d506517c8b4fe484ffdc1c","user":{"login":"Gizra","id":2484795,"avatar_url":"https://avatars.githubusercontent.com/u/2484795?v=2","gravatar_id":null,"url":"https://api.github.com/users/Gizra","html_url":"https://github.com/Gizra","followers_url":"https://api.github.com/users/Gizra/followers","following_url":"https://api.github.com/users/Gizra/following{/other_user}","gists_url":"https://api.github.com/users/Gizra/gists{/gist_id}","starred_url":"https://api.github.com/users/Gizra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gizra/subscriptions","organizations_url":"https://api.github.com/users/Gizra/orgs","repos_url":"https://api.github.com/users/Gizra/repos","events_url":"https://api.github.com/users/Gizra/events{/privacy}","received_events_url":"https://api.github.com/users/Gizra/received_events","type":"Organization","site_admin":false},"repo":{"id":17918315,"name":"restful","full_name":"Gizra/restful","owner":{"login":"Gizra","id":2484795,"avatar_url":"https://avatars.githubusercontent.com/u/2484795?v=2","gravatar_id":null,"url":"https://api.github.com/users/Gizra","html_url":"https://github.com/Gizra","followers_url":"https://api.github.com/users/Gizra/followers","following_url":"https://api.github.com/users/Gizra/following{/other_user}","gists_url":"https://api.github.com/users/Gizra/gists{/gist_id}","starred_url":"https://api.github.com/users/Gizra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gizra/subscriptions","organizations_url":"https://api.github.com/users/Gizra/orgs","repos_url":"https://api.github.com/users/Gizra/repos","events_url":"https://api.github.com/users/Gizra/events{/privacy}","received_events_url":"https://api.github.com/users/Gizra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Gizra/restful","description":"RESTful best practices for Drupal","fork":false,"url":"https://api.github.com/repos/Gizra/restful","forks_url":"https://api.github.com/repos/Gizra/restful/forks","keys_url":"https://api.github.com/repos/Gizra/restful/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gizra/restful/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gizra/restful/teams","hooks_url":"https://api.github.com/repos/Gizra/restful/hooks","issue_events_url":"https://api.github.com/repos/Gizra/restful/issues/events{/number}","events_url":"https://api.github.com/repos/Gizra/restful/events","assignees_url":"https://api.github.com/repos/Gizra/restful/assignees{/user}","branches_url":"https://api.github.com/repos/Gizra/restful/branches{/branch}","tags_url":"https://api.github.com/repos/Gizra/restful/tags","blobs_url":"https://api.github.com/repos/Gizra/restful/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gizra/restful/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gizra/restful/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gizra/restful/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gizra/restful/statuses/{sha}","languages_url":"https://api.github.com/repos/Gizra/restful/languages","stargazers_url":"https://api.github.com/repos/Gizra/restful/stargazers","contributors_url":"https://api.github.com/repos/Gizra/restful/contributors","subscribers_url":"https://api.github.com/repos/Gizra/restful/subscribers","subscription_url":"https://api.github.com/repos/Gizra/restful/subscription","commits_url":"https://api.github.com/repos/Gizra/restful/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gizra/restful/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gizra/restful/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gizra/restful/issues/comments/{number}","contents_url":"https://api.github.com/repos/Gizra/restful/contents/{+path}","compare_url":"https://api.github.com/repos/Gizra/restful/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gizra/restful/merges","archive_url":"https://api.github.com/repos/Gizra/restful/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gizra/restful/downloads","issues_url":"https://api.github.com/repos/Gizra/restful/issues{/number}","pulls_url":"https://api.github.com/repos/Gizra/restful/pulls{/number}","milestones_url":"https://api.github.com/repos/Gizra/restful/milestones{/number}","notifications_url":"https://api.github.com/repos/Gizra/restful/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gizra/restful/labels{/name}","releases_url":"https://api.github.com/repos/Gizra/restful/releases{/id}","created_at":"2014-03-19T19:58:55Z","updated_at":"2014-08-27T07:58:30Z","pushed_at":"2014-08-29T17:24:23Z","git_url":"git://github.com/Gizra/restful.git","ssh_url":"git@github.com:Gizra/restful.git","clone_url":"https://github.com/Gizra/restful.git","svn_url":"https://github.com/Gizra/restful","homepage":"","size":8013,"stargazers_count":88,"watchers_count":88,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":16,"mirror_url":null,"open_issues_count":18,"forks":16,"open_issues":18,"watchers":88,"default_branch":"7.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Gizra/restful/pulls/121"},"html":{"href":"https://github.com/Gizra/restful/pull/121"},"issue":{"href":"https://api.github.com/repos/Gizra/restful/issues/121"},"comments":{"href":"https://api.github.com/repos/Gizra/restful/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/Gizra/restful/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/Gizra/restful/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Gizra/restful/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/Gizra/restful/statuses/d6d8fe0b789f9556f34dbbd4f72d0527a9f70e7a"}}}}