GitHub PullRequestReviewCommentEvent at 2014-06-24 18:02:55
Repository: bitcoinjs-lib
Actor: weilu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments/14144798","id":14144798,"diff_hunk":"@@ -45,7 +45,7 @@ ECKey.fromWIF = function(string) {\n ECKey.makeRandom = function(compressed, rng) {\n   rng = rng || secureRandom\n \n-  var buffer = new Buffer(rng(32))\n+  var buffer = rng.randomBuffer(32)","path":"src/eckey.js","position":5,"original_position":5,"commit_id":"39a85dc64801721e5a016bb1d5b8ac0eedc04baa","original_commit_id":"39a85dc64801721e5a016bb1d5b8ac0eedc04baa","user":{"login":"weilu","id":412533,"avatar_url":"https://avatars.githubusercontent.com/u/412533?","gravatar_id":"d588d3929adbac0bd3ccb03fe6d7c5ea","url":"https://api.github.com/users/weilu","html_url":"https://github.com/weilu","followers_url":"https://api.github.com/users/weilu/followers","following_url":"https://api.github.com/users/weilu/following{/other_user}","gists_url":"https://api.github.com/users/weilu/gists{/gist_id}","starred_url":"https://api.github.com/users/weilu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weilu/subscriptions","organizations_url":"https://api.github.com/users/weilu/orgs","repos_url":"https://api.github.com/users/weilu/repos","events_url":"https://api.github.com/users/weilu/events{/privacy}","received_events_url":"https://api.github.com/users/weilu/received_events","type":"User","site_admin":false},"body":"Same problem as https://github.com/weilu/bip39/pull/4#discussion_r14144242","created_at":"2014-06-24T18:02:55Z","updated_at":"2014-06-24T18:02:55Z","html_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/223#discussion_r14144798","pull_request_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments/14144798"},"html":{"href":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/223#discussion_r14144798"},"pull_request":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/223","id":17461484,"html_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/223","diff_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/223.diff","patch_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/223.patch","issue_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/223","number":223,"state":"open","title":"ECKey: adds tests for makeRandom","user":{"login":"dcousens","id":413395,"avatar_url":"https://avatars.githubusercontent.com/u/413395?","gravatar_id":"39de8f85714b3e8e9eaa118dc9ac9cb1","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false},"body":"This pull request adds tests for `ECKey.makeRandom`, which has previously not been under appropriate test.\r\nIt uses a stubbed RNG as the `secure-random` RNG is not the focus of this test.\r\n\r\n`secure-random` was also upgraded to version `1.0.0` to use `randomBuffer`.","created_at":"2014-06-23T08:25:52Z","updated_at":"2014-06-24T18:02:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b56c50aa0bdf97d73135b3ae67081a9b72a17ae9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/223/commits","review_comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/223/comments","review_comment_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/223/comments","statuses_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/39a85dc64801721e5a016bb1d5b8ac0eedc04baa","head":{"label":"dcousens:rand","ref":"rand","sha":"39a85dc64801721e5a016bb1d5b8ac0eedc04baa","user":{"login":"dcousens","id":413395,"avatar_url":"https://avatars.githubusercontent.com/u/413395?","gravatar_id":"39de8f85714b3e8e9eaa118dc9ac9cb1","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false},"repo":{"id":16689428,"name":"bitcoinjs-lib","full_name":"dcousens/bitcoinjs-lib","owner":{"login":"dcousens","id":413395,"avatar_url":"https://avatars.githubusercontent.com/u/413395?","gravatar_id":"39de8f85714b3e8e9eaa118dc9ac9cb1","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcousens/bitcoinjs-lib","description":"Bitcoin-related functions implemented in pure JavaScript","fork":true,"url":"https://api.github.com/repos/dcousens/bitcoinjs-lib","forks_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/forks","keys_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/teams","hooks_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/hooks","issue_events_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/issues/events{/number}","events_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/events","assignees_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/assignees{/user}","branches_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/branches{/branch}","tags_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/tags","blobs_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/languages","stargazers_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/stargazers","contributors_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/contributors","subscribers_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/subscribers","subscription_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/subscription","commits_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/issues/comments/{number}","contents_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/contents/{+path}","compare_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/merges","archive_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/downloads","issues_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/issues{/number}","pulls_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/labels{/name}","releases_url":"https://api.github.com/repos/dcousens/bitcoinjs-lib/releases{/id}","created_at":"2014-02-10T08:47:04Z","updated_at":"2014-06-24T07:48:23Z","pushed_at":"2014-06-24T07:48:23Z","git_url":"git://github.com/dcousens/bitcoinjs-lib.git","ssh_url":"git@github.com:dcousens/bitcoinjs-lib.git","clone_url":"https://github.com/dcousens/bitcoinjs-lib.git","svn_url":"https://github.com/dcousens/bitcoinjs-lib","homepage":"","size":6141,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoinjs:master","ref":"master","sha":"d93623e2b18987f28bed32b1a9286eb9d571f46e","user":{"login":"bitcoinjs","id":756696,"avatar_url":"https://avatars.githubusercontent.com/u/756696?","gravatar_id":"4839322796245dd487be1224c5a6ade8","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1701968,"name":"bitcoinjs-lib","full_name":"bitcoinjs/bitcoinjs-lib","owner":{"login":"bitcoinjs","id":756696,"avatar_url":"https://avatars.githubusercontent.com/u/756696?","gravatar_id":"4839322796245dd487be1224c5a6ade8","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoinjs/bitcoinjs-lib","description":"Bitcoin-related functions implemented in pure JavaScript","fork":false,"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib","forks_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/forks","keys_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/teams","hooks_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/hooks","issue_events_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/events","assignees_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/tags","blobs_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/languages","stargazers_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/stargazers","contributors_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/contributors","subscribers_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/subscribers","subscription_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/subscription","commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/merges","archive_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/downloads","issues_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/releases{/id}","created_at":"2011-05-04T16:03:45Z","updated_at":"2014-06-22T15:09:29Z","pushed_at":"2014-06-22T15:07:24Z","git_url":"git://github.com/bitcoinjs/bitcoinjs-lib.git","ssh_url":"git@github.com:bitcoinjs/bitcoinjs-lib.git","clone_url":"https://github.com/bitcoinjs/bitcoinjs-lib.git","svn_url":"https://github.com/bitcoinjs/bitcoinjs-lib","homepage":"","size":6417,"stargazers_count":263,"watchers_count":263,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":121,"mirror_url":null,"open_issues_count":6,"forks":121,"open_issues":6,"watchers":263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/223"},"html":{"href":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/223"},"issue":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/223"},"comments":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/39a85dc64801721e5a016bb1d5b8ac0eedc04baa"}}}}