GitHub PullRequestReviewCommentEvent at 2014-03-05 07:22:41
Repository: khypervisor
Actor: Wonseok
Payload: {"comment":{"url":"https://api.github.com/repos/kesl/khypervisor/pulls/comments/10289721","id":10289721,"diff_hunk":"@@ -77,15 +203,39 @@ hvmm_status_t generic_timer_enable_irq(enum generic_timer_type type)\n                                GIC_INT_PRIORITY_DEFAULT);\n         result = HVMM_STATUS_SUCCESS;\n     }\n+\n     return result;\n }\n \n-hvmm_status_t generic_timer_set_callback(enum generic_timer_type type,\n-                generic_timer_callback_t callback)\n+hvmm_status_t generic_timer_set_callback(timer_callback_t callback,\n+                void *user)\n+{\n+    HVMM_TRACE_ENTER();\n+    _callback[_timer_type] = callback;\n+    HVMM_TRACE_EXIT();\n+    return HVMM_STATUS_SUCCESS;\n+}\n+\n+hvmm_status_t generic_timer_dump(void)\n {\n     HVMM_TRACE_ENTER();\n-    _callback[type] = callback;\n     HVMM_TRACE_EXIT();\n     return HVMM_STATUS_SUCCESS;\n }\n \n+struct timer_ops generic_timer_ops = {\n+    init:           generic_timer_init,\n+    request_irq :    generic_timer_enable_irq,\n+    free_irq :       (void *)0,","path":"hypervisor/generic_timer/generic_timer.c","position":247,"original_position":247,"commit_id":"5db3dcfaf9b25896177464ef4030a85f4d089dc2","original_commit_id":"5db3dcfaf9b25896177464ef4030a85f4d089dc2","user":{"login":"Wonseok","id":1691430,"avatar_url":"https://gravatar.com/avatar/544a4d2d91b957d79b9234242dc8adaf?d=https%3A%2F%2Fidenticons.github.com%2F7ab98e1de1f34881aee74cab429c4ce4.png&r=x","gravatar_id":"544a4d2d91b957d79b9234242dc8adaf","url":"https://api.github.com/users/Wonseok","html_url":"https://github.com/Wonseok","followers_url":"https://api.github.com/users/Wonseok/followers","following_url":"https://api.github.com/users/Wonseok/following{/other_user}","gists_url":"https://api.github.com/users/Wonseok/gists{/gist_id}","starred_url":"https://api.github.com/users/Wonseok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wonseok/subscriptions","organizations_url":"https://api.github.com/users/Wonseok/orgs","repos_url":"https://api.github.com/users/Wonseok/repos","events_url":"https://api.github.com/users/Wonseok/events{/privacy}","received_events_url":"https://api.github.com/users/Wonseok/received_events","type":"User","site_admin":false},"body":"Please use named constant.","created_at":"2014-03-05T07:22:41Z","updated_at":"2014-03-05T07:22:41Z","html_url":"https://github.com/kesl/khypervisor/pull/131#discussion_r10289721","pull_request_url":"https://api.github.com/repos/kesl/khypervisor/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/kesl/khypervisor/pulls/comments/10289721"},"html":{"href":"https://github.com/kesl/khypervisor/pull/131#discussion_r10289721"},"pull_request":{"href":"https://api.github.com/repos/kesl/khypervisor/pulls/131"}}}}