GitHub PullRequestReviewCommentEvent at 2014-09-24 11:44:14
Repository: gitlabhq
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/17966310","id":17966310,"diff_hunk":"@@ -40,29 +40,55 @@ class Users < Grape::API\n       # Create user. Available only for admin\n       #\n       # Parameters:\n-      #   email (required)                  - Email\n-      #   password (required)               - Password\n-      #   name (required)                   - Name\n-      #   username (required)               - Name\n-      #   skype                             - Skype ID\n-      #   linkedin                          - Linkedin\n-      #   twitter                           - Twitter account\n-      #   website_url                       - Website url\n-      #   projects_limit                    - Number of projects user can create\n-      #   extern_uid                        - External authentication provider UID\n-      #   provider                          - External provider\n-      #   bio                               - Bio\n-      #   admin                             - User is admin - true or false (default)\n-      #   can_create_group                  - User can create groups - true or false\n+      #   email (required)                                       - Email\n+      #   password (required unless force_random_password set)   - Password\n+      #   force_random_password (required unless password set)   - generate random password for user - true or false\n+      #   name (required)                                        - Name\n+      #   username (required)                                    - Name\n+      #   skype                                                  - Skype ID\n+      #   linkedin                                               - Linkedin\n+      #   twitter                                                - Twitter account\n+      #   website_url                                            - Website url\n+      #   projects_limit                                         - Number of projects user can create\n+      #   extern_uid                                             - External authentication provider UID\n+      #   provider                                               - External provider\n+      #   bio                                                    - Bio\n+      #   admin                                                  - User is admin - true or false (default)","path":"lib/api/users.rb","position":31,"original_position":31,"commit_id":"9f1c26c5235f4cddabce5ca7658a484a6d86b863","original_commit_id":"9f1c26c5235f4cddabce5ca7658a484a6d86b863","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [106/80]","created_at":"2014-09-24T11:44:14Z","updated_at":"2014-09-24T11:44:14Z","html_url":"https://github.com/gitlabhq/gitlabhq/pull/7681#discussion_r17966310","pull_request_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7681","_links":{"self":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/17966310"},"html":{"href":"https://github.com/gitlabhq/gitlabhq/pull/7681#discussion_r17966310"},"pull_request":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7681"}}},"pull_request":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7681","id":20681045,"html_url":"https://github.com/gitlabhq/gitlabhq/pull/7681","diff_url":"https://github.com/gitlabhq/gitlabhq/pull/7681.diff","patch_url":"https://github.com/gitlabhq/gitlabhq/pull/7681.patch","issue_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7681","number":7681,"state":"open","locked":false,"title":"Extend user add api to allow adding users like from admin panel","user":{"login":"duk3luk3","id":611471,"avatar_url":"https://avatars.githubusercontent.com/u/611471?v=2","gravatar_id":"","url":"https://api.github.com/users/duk3luk3","html_url":"https://github.com/duk3luk3","followers_url":"https://api.github.com/users/duk3luk3/followers","following_url":"https://api.github.com/users/duk3luk3/following{/other_user}","gists_url":"https://api.github.com/users/duk3luk3/gists{/gist_id}","starred_url":"https://api.github.com/users/duk3luk3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duk3luk3/subscriptions","organizations_url":"https://api.github.com/users/duk3luk3/orgs","repos_url":"https://api.github.com/users/duk3luk3/repos","events_url":"https://api.github.com/users/duk3luk3/events{/privacy}","received_events_url":"https://api.github.com/users/duk3luk3/received_events","type":"User","site_admin":false},"body":"- Add force_random_password parameter to have password of new user set\r\n  randomly and expired\r\n- Update docs\r\n- Update tests\r\n\r\nThis is a remake of my [old PR](https://github.com/gitlabhq/gitlabhq/pull/4805) that was abandoned since things about how user registration/signup works were expected to change soon. Since it's been a year and the PR is still applicable, I'm resubmitting it. I've heavily polished and simplified it.\r\n\r\nIt simply adds a new parameter to the /users POST api call that allows to trigger identical behaviour to adding users from the admin panel: Setting the newly signed up user as already confirmed and with an expired password, resulting in a \"You have been added to Gitlab, click here to set a password\" email.\r\n\r\nAs a bonus, I've also fixed two tests for that API call that were succeeding for the wrong reasons.","created_at":"2014-09-03T14:39:49Z","updated_at":"2014-09-24T11:44:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4638140759ff1ad3fc965961866eb9a664324773","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7681/commits","review_comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7681/comments","review_comment_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7681/comments","statuses_url":"https://api.github.com/repos/gitlabhq/gitlabhq/statuses/9f1c26c5235f4cddabce5ca7658a484a6d86b863","head":{"label":"duk3luk3:useradd-api-extension","ref":"useradd-api-extension","sha":"9f1c26c5235f4cddabce5ca7658a484a6d86b863","user":{"login":"duk3luk3","id":611471,"avatar_url":"https://avatars.githubusercontent.com/u/611471?v=2","gravatar_id":"","url":"https://api.github.com/users/duk3luk3","html_url":"https://github.com/duk3luk3","followers_url":"https://api.github.com/users/duk3luk3/followers","following_url":"https://api.github.com/users/duk3luk3/following{/other_user}","gists_url":"https://api.github.com/users/duk3luk3/gists{/gist_id}","starred_url":"https://api.github.com/users/duk3luk3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duk3luk3/subscriptions","organizations_url":"https://api.github.com/users/duk3luk3/orgs","repos_url":"https://api.github.com/users/duk3luk3/repos","events_url":"https://api.github.com/users/duk3luk3/events{/privacy}","received_events_url":"https://api.github.com/users/duk3luk3/received_events","type":"User","site_admin":false},"repo":{"id":12182405,"name":"gitlabhq","full_name":"duk3luk3/gitlabhq","owner":{"login":"duk3luk3","id":611471,"avatar_url":"https://avatars.githubusercontent.com/u/611471?v=2","gravatar_id":"","url":"https://api.github.com/users/duk3luk3","html_url":"https://github.com/duk3luk3","followers_url":"https://api.github.com/users/duk3luk3/followers","following_url":"https://api.github.com/users/duk3luk3/following{/other_user}","gists_url":"https://api.github.com/users/duk3luk3/gists{/gist_id}","starred_url":"https://api.github.com/users/duk3luk3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duk3luk3/subscriptions","organizations_url":"https://api.github.com/users/duk3luk3/orgs","repos_url":"https://api.github.com/users/duk3luk3/repos","events_url":"https://api.github.com/users/duk3luk3/events{/privacy}","received_events_url":"https://api.github.com/users/duk3luk3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duk3luk3/gitlabhq","description":"Project management and code hosting  application. Follow us on twitter @gitlabhq","fork":true,"url":"https://api.github.com/repos/duk3luk3/gitlabhq","forks_url":"https://api.github.com/repos/duk3luk3/gitlabhq/forks","keys_url":"https://api.github.com/repos/duk3luk3/gitlabhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duk3luk3/gitlabhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duk3luk3/gitlabhq/teams","hooks_url":"https://api.github.com/repos/duk3luk3/gitlabhq/hooks","issue_events_url":"https://api.github.com/repos/duk3luk3/gitlabhq/issues/events{/number}","events_url":"https://api.github.com/repos/duk3luk3/gitlabhq/events","assignees_url":"https://api.github.com/repos/duk3luk3/gitlabhq/assignees{/user}","branches_url":"https://api.github.com/repos/duk3luk3/gitlabhq/branches{/branch}","tags_url":"https://api.github.com/repos/duk3luk3/gitlabhq/tags","blobs_url":"https://api.github.com/repos/duk3luk3/gitlabhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duk3luk3/gitlabhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duk3luk3/gitlabhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/duk3luk3/gitlabhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duk3luk3/gitlabhq/statuses/{sha}","languages_url":"https://api.github.com/repos/duk3luk3/gitlabhq/languages","stargazers_url":"https://api.github.com/repos/duk3luk3/gitlabhq/stargazers","contributors_url":"https://api.github.com/repos/duk3luk3/gitlabhq/contributors","subscribers_url":"https://api.github.com/repos/duk3luk3/gitlabhq/subscribers","subscription_url":"https://api.github.com/repos/duk3luk3/gitlabhq/subscription","commits_url":"https://api.github.com/repos/duk3luk3/gitlabhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/duk3luk3/gitlabhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/duk3luk3/gitlabhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/duk3luk3/gitlabhq/issues/comments/{number}","contents_url":"https://api.github.com/repos/duk3luk3/gitlabhq/contents/{+path}","compare_url":"https://api.github.com/repos/duk3luk3/gitlabhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duk3luk3/gitlabhq/merges","archive_url":"https://api.github.com/repos/duk3luk3/gitlabhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duk3luk3/gitlabhq/downloads","issues_url":"https://api.github.com/repos/duk3luk3/gitlabhq/issues{/number}","pulls_url":"https://api.github.com/repos/duk3luk3/gitlabhq/pulls{/number}","milestones_url":"https://api.github.com/repos/duk3luk3/gitlabhq/milestones{/number}","notifications_url":"https://api.github.com/repos/duk3luk3/gitlabhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duk3luk3/gitlabhq/labels{/name}","releases_url":"https://api.github.com/repos/duk3luk3/gitlabhq/releases{/id}","created_at":"2013-08-17T17:15:30Z","updated_at":"2014-07-30T15:25:51Z","pushed_at":"2014-09-24T11:44:06Z","git_url":"git://github.com/duk3luk3/gitlabhq.git","ssh_url":"git@github.com:duk3luk3/gitlabhq.git","clone_url":"https://github.com/duk3luk3/gitlabhq.git","svn_url":"https://github.com/duk3luk3/gitlabhq","homepage":"gitlab.org","size":82436,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"gitlabhq:master","ref":"master","sha":"28b6f09fcc1ea50c44e942ed6c342a42bdf12dc4","user":{"login":"gitlabhq","id":1086321,"avatar_url":"https://avatars.githubusercontent.com/u/1086321?v=2","gravatar_id":"","url":"https://api.github.com/users/gitlabhq","html_url":"https://github.com/gitlabhq","followers_url":"https://api.github.com/users/gitlabhq/followers","following_url":"https://api.github.com/users/gitlabhq/following{/other_user}","gists_url":"https://api.github.com/users/gitlabhq/gists{/gist_id}","starred_url":"https://api.github.com/users/gitlabhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitlabhq/subscriptions","organizations_url":"https://api.github.com/users/gitlabhq/orgs","repos_url":"https://api.github.com/users/gitlabhq/repos","events_url":"https://api.github.com/users/gitlabhq/events{/privacy}","received_events_url":"https://api.github.com/users/gitlabhq/received_events","type":"Organization","site_admin":false},"repo":{"id":2500088,"name":"gitlabhq","full_name":"gitlabhq/gitlabhq","owner":{"login":"gitlabhq","id":1086321,"avatar_url":"https://avatars.githubusercontent.com/u/1086321?v=2","gravatar_id":"","url":"https://api.github.com/users/gitlabhq","html_url":"https://github.com/gitlabhq","followers_url":"https://api.github.com/users/gitlabhq/followers","following_url":"https://api.github.com/users/gitlabhq/following{/other_user}","gists_url":"https://api.github.com/users/gitlabhq/gists{/gist_id}","starred_url":"https://api.github.com/users/gitlabhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitlabhq/subscriptions","organizations_url":"https://api.github.com/users/gitlabhq/orgs","repos_url":"https://api.github.com/users/gitlabhq/repos","events_url":"https://api.github.com/users/gitlabhq/events{/privacy}","received_events_url":"https://api.github.com/users/gitlabhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gitlabhq/gitlabhq","description":"Open source software to collaborate on code. Follow us on twitter @gitlabhq","fork":false,"url":"https://api.github.com/repos/gitlabhq/gitlabhq","forks_url":"https://api.github.com/repos/gitlabhq/gitlabhq/forks","keys_url":"https://api.github.com/repos/gitlabhq/gitlabhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitlabhq/gitlabhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitlabhq/gitlabhq/teams","hooks_url":"https://api.github.com/repos/gitlabhq/gitlabhq/hooks","issue_events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/events{/number}","events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/events","assignees_url":"https://api.github.com/repos/gitlabhq/gitlabhq/assignees{/user}","branches_url":"https://api.github.com/repos/gitlabhq/gitlabhq/branches{/branch}","tags_url":"https://api.github.com/repos/gitlabhq/gitlabhq/tags","blobs_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitlabhq/gitlabhq/statuses/{sha}","languages_url":"https://api.github.com/repos/gitlabhq/gitlabhq/languages","stargazers_url":"https://api.github.com/repos/gitlabhq/gitlabhq/stargazers","contributors_url":"https://api.github.com/repos/gitlabhq/gitlabhq/contributors","subscribers_url":"https://api.github.com/repos/gitlabhq/gitlabhq/subscribers","subscription_url":"https://api.github.com/repos/gitlabhq/gitlabhq/subscription","commits_url":"https://api.github.com/repos/gitlabhq/gitlabhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/comments/{number}","contents_url":"https://api.github.com/repos/gitlabhq/gitlabhq/contents/{+path}","compare_url":"https://api.github.com/repos/gitlabhq/gitlabhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitlabhq/gitlabhq/merges","archive_url":"https://api.github.com/repos/gitlabhq/gitlabhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitlabhq/gitlabhq/downloads","issues_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues{/number}","pulls_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls{/number}","milestones_url":"https://api.github.com/repos/gitlabhq/gitlabhq/milestones{/number}","notifications_url":"https://api.github.com/repos/gitlabhq/gitlabhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitlabhq/gitlabhq/labels{/name}","releases_url":"https://api.github.com/repos/gitlabhq/gitlabhq/releases{/id}","created_at":"2011-10-02T16:25:27Z","updated_at":"2014-09-24T09:56:50Z","pushed_at":"2014-09-24T09:58:11Z","git_url":"git://github.com/gitlabhq/gitlabhq.git","ssh_url":"git@github.com:gitlabhq/gitlabhq.git","clone_url":"https://github.com/gitlabhq/gitlabhq.git","svn_url":"https://github.com/gitlabhq/gitlabhq","homepage":"https://about.gitlab.com/","size":149498,"stargazers_count":13950,"watchers_count":13950,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3619,"mirror_url":null,"open_issues_count":541,"forks":3619,"open_issues":541,"watchers":13950,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7681"},"html":{"href":"https://github.com/gitlabhq/gitlabhq/pull/7681"},"issue":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7681"},"comments":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7681/comments"},"review_comments":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7681/comments"},"review_comment":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7681/commits"},"statuses":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/statuses/9f1c26c5235f4cddabce5ca7658a484a6d86b863"}}}}