GitHub PullRequestEvent at 2014-07-02 11:05:36
Repository: simmetrica
Actor: o
Payload: {"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/o/simmetrica/pulls/12","id":17875003,"html_url":"https://github.com/o/simmetrica/pull/12","diff_url":"https://github.com/o/simmetrica/pull/12.diff","patch_url":"https://github.com/o/simmetrica/pull/12.patch","issue_url":"https://api.github.com/repos/o/simmetrica/issues/12","number":12,"state":"closed","title":"Fixed tests to pass in Python 3.","user":{"login":"d0ugal","id":48211,"avatar_url":"https://avatars.githubusercontent.com/u/48211?","gravatar_id":"305cabbbad7039ea3a7e8b9be6f59619","url":"https://api.github.com/users/d0ugal","html_url":"https://github.com/d0ugal","followers_url":"https://api.github.com/users/d0ugal/followers","following_url":"https://api.github.com/users/d0ugal/following{/other_user}","gists_url":"https://api.github.com/users/d0ugal/gists{/gist_id}","starred_url":"https://api.github.com/users/d0ugal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d0ugal/subscriptions","organizations_url":"https://api.github.com/users/d0ugal/orgs","repos_url":"https://api.github.com/users/d0ugal/repos","events_url":"https://api.github.com/users/d0ugal/events{/privacy}","received_events_url":"https://api.github.com/users/d0ugal/received_events","type":"User","site_admin":false},"body":"The simmetrica code uses a dictionary and range in a few places. This causes some small Python 3 compatibility issues.\r\n    \r\nThe order of the dictionary isn't guaranteed, but the test expects it to be. This fix changes that so it works in Python 3 by sorting the result before comparing.\r\n    \r\nIn Python 3 range() doesn't return a list, but rather returns a range object. Therefore, to make this work in both versions the test makes sure its a list before comparing.\r\n\r\nThis change requires #9 and #10.","created_at":"2014-07-02T09:14:42Z","updated_at":"2014-07-02T11:05:36Z","closed_at":"2014-07-02T11:05:36Z","merged_at":"2014-07-02T11:05:36Z","merge_commit_sha":"c150aac73eb4d9e19361918a8c94d4fcb62d9715","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/o/simmetrica/pulls/12/commits","review_comments_url":"https://api.github.com/repos/o/simmetrica/pulls/12/comments","review_comment_url":"https://api.github.com/repos/o/simmetrica/pulls/comments/{number}","comments_url":"https://api.github.com/repos/o/simmetrica/issues/12/comments","statuses_url":"https://api.github.com/repos/o/simmetrica/statuses/f59f341b6a7302c7eca35674ab37ffa7d9f4d2e7","head":{"label":"d0ugal:python3","ref":"python3","sha":"f59f341b6a7302c7eca35674ab37ffa7d9f4d2e7","user":{"login":"d0ugal","id":48211,"avatar_url":"https://avatars.githubusercontent.com/u/48211?","gravatar_id":"305cabbbad7039ea3a7e8b9be6f59619","url":"https://api.github.com/users/d0ugal","html_url":"https://github.com/d0ugal","followers_url":"https://api.github.com/users/d0ugal/followers","following_url":"https://api.github.com/users/d0ugal/following{/other_user}","gists_url":"https://api.github.com/users/d0ugal/gists{/gist_id}","starred_url":"https://api.github.com/users/d0ugal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d0ugal/subscriptions","organizations_url":"https://api.github.com/users/d0ugal/orgs","repos_url":"https://api.github.com/users/d0ugal/repos","events_url":"https://api.github.com/users/d0ugal/events{/privacy}","received_events_url":"https://api.github.com/users/d0ugal/received_events","type":"User","site_admin":false},"repo":{"id":21416881,"name":"simmetrica","full_name":"d0ugal/simmetrica","owner":{"login":"d0ugal","id":48211,"avatar_url":"https://avatars.githubusercontent.com/u/48211?","gravatar_id":"305cabbbad7039ea3a7e8b9be6f59619","url":"https://api.github.com/users/d0ugal","html_url":"https://github.com/d0ugal","followers_url":"https://api.github.com/users/d0ugal/followers","following_url":"https://api.github.com/users/d0ugal/following{/other_user}","gists_url":"https://api.github.com/users/d0ugal/gists{/gist_id}","starred_url":"https://api.github.com/users/d0ugal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d0ugal/subscriptions","organizations_url":"https://api.github.com/users/d0ugal/orgs","repos_url":"https://api.github.com/users/d0ugal/repos","events_url":"https://api.github.com/users/d0ugal/events{/privacy}","received_events_url":"https://api.github.com/users/d0ugal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d0ugal/simmetrica","description":"Lightweight framework for collecting and aggregating event metrics as timeseries data","fork":true,"url":"https://api.github.com/repos/d0ugal/simmetrica","forks_url":"https://api.github.com/repos/d0ugal/simmetrica/forks","keys_url":"https://api.github.com/repos/d0ugal/simmetrica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d0ugal/simmetrica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d0ugal/simmetrica/teams","hooks_url":"https://api.github.com/repos/d0ugal/simmetrica/hooks","issue_events_url":"https://api.github.com/repos/d0ugal/simmetrica/issues/events{/number}","events_url":"https://api.github.com/repos/d0ugal/simmetrica/events","assignees_url":"https://api.github.com/repos/d0ugal/simmetrica/assignees{/user}","branches_url":"https://api.github.com/repos/d0ugal/simmetrica/branches{/branch}","tags_url":"https://api.github.com/repos/d0ugal/simmetrica/tags","blobs_url":"https://api.github.com/repos/d0ugal/simmetrica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d0ugal/simmetrica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d0ugal/simmetrica/git/refs{/sha}","trees_url":"https://api.github.com/repos/d0ugal/simmetrica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d0ugal/simmetrica/statuses/{sha}","languages_url":"https://api.github.com/repos/d0ugal/simmetrica/languages","stargazers_url":"https://api.github.com/repos/d0ugal/simmetrica/stargazers","contributors_url":"https://api.github.com/repos/d0ugal/simmetrica/contributors","subscribers_url":"https://api.github.com/repos/d0ugal/simmetrica/subscribers","subscription_url":"https://api.github.com/repos/d0ugal/simmetrica/subscription","commits_url":"https://api.github.com/repos/d0ugal/simmetrica/commits{/sha}","git_commits_url":"https://api.github.com/repos/d0ugal/simmetrica/git/commits{/sha}","comments_url":"https://api.github.com/repos/d0ugal/simmetrica/comments{/number}","issue_comment_url":"https://api.github.com/repos/d0ugal/simmetrica/issues/comments/{number}","contents_url":"https://api.github.com/repos/d0ugal/simmetrica/contents/{+path}","compare_url":"https://api.github.com/repos/d0ugal/simmetrica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d0ugal/simmetrica/merges","archive_url":"https://api.github.com/repos/d0ugal/simmetrica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d0ugal/simmetrica/downloads","issues_url":"https://api.github.com/repos/d0ugal/simmetrica/issues{/number}","pulls_url":"https://api.github.com/repos/d0ugal/simmetrica/pulls{/number}","milestones_url":"https://api.github.com/repos/d0ugal/simmetrica/milestones{/number}","notifications_url":"https://api.github.com/repos/d0ugal/simmetrica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d0ugal/simmetrica/labels{/name}","releases_url":"https://api.github.com/repos/d0ugal/simmetrica/releases{/id}","created_at":"2014-07-02T08:28:33Z","updated_at":"2014-07-02T01:43:54Z","pushed_at":"2014-07-02T09:19:05Z","git_url":"git://github.com/d0ugal/simmetrica.git","ssh_url":"git@github.com:d0ugal/simmetrica.git","clone_url":"https://github.com/d0ugal/simmetrica.git","svn_url":"https://github.com/d0ugal/simmetrica","homepage":"","size":552,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"o:master","ref":"master","sha":"5ab6c97b5d6c1b9f3010bfd15bd89b9fd88e4e4b","user":{"login":"o","id":179912,"avatar_url":"https://avatars.githubusercontent.com/u/179912?","gravatar_id":"b1c80db91088bf97ed8e1453a59095b2","url":"https://api.github.com/users/o","html_url":"https://github.com/o","followers_url":"https://api.github.com/users/o/followers","following_url":"https://api.github.com/users/o/following{/other_user}","gists_url":"https://api.github.com/users/o/gists{/gist_id}","starred_url":"https://api.github.com/users/o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o/subscriptions","organizations_url":"https://api.github.com/users/o/orgs","repos_url":"https://api.github.com/users/o/repos","events_url":"https://api.github.com/users/o/events{/privacy}","received_events_url":"https://api.github.com/users/o/received_events","type":"User","site_admin":false},"repo":{"id":8851260,"name":"simmetrica","full_name":"o/simmetrica","owner":{"login":"o","id":179912,"avatar_url":"https://avatars.githubusercontent.com/u/179912?","gravatar_id":"b1c80db91088bf97ed8e1453a59095b2","url":"https://api.github.com/users/o","html_url":"https://github.com/o","followers_url":"https://api.github.com/users/o/followers","following_url":"https://api.github.com/users/o/following{/other_user}","gists_url":"https://api.github.com/users/o/gists{/gist_id}","starred_url":"https://api.github.com/users/o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o/subscriptions","organizations_url":"https://api.github.com/users/o/orgs","repos_url":"https://api.github.com/users/o/repos","events_url":"https://api.github.com/users/o/events{/privacy}","received_events_url":"https://api.github.com/users/o/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/o/simmetrica","description":"Lightweight framework for collecting and aggregating event metrics as timeseries data","fork":false,"url":"https://api.github.com/repos/o/simmetrica","forks_url":"https://api.github.com/repos/o/simmetrica/forks","keys_url":"https://api.github.com/repos/o/simmetrica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/o/simmetrica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/o/simmetrica/teams","hooks_url":"https://api.github.com/repos/o/simmetrica/hooks","issue_events_url":"https://api.github.com/repos/o/simmetrica/issues/events{/number}","events_url":"https://api.github.com/repos/o/simmetrica/events","assignees_url":"https://api.github.com/repos/o/simmetrica/assignees{/user}","branches_url":"https://api.github.com/repos/o/simmetrica/branches{/branch}","tags_url":"https://api.github.com/repos/o/simmetrica/tags","blobs_url":"https://api.github.com/repos/o/simmetrica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/o/simmetrica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/o/simmetrica/git/refs{/sha}","trees_url":"https://api.github.com/repos/o/simmetrica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/o/simmetrica/statuses/{sha}","languages_url":"https://api.github.com/repos/o/simmetrica/languages","stargazers_url":"https://api.github.com/repos/o/simmetrica/stargazers","contributors_url":"https://api.github.com/repos/o/simmetrica/contributors","subscribers_url":"https://api.github.com/repos/o/simmetrica/subscribers","subscription_url":"https://api.github.com/repos/o/simmetrica/subscription","commits_url":"https://api.github.com/repos/o/simmetrica/commits{/sha}","git_commits_url":"https://api.github.com/repos/o/simmetrica/git/commits{/sha}","comments_url":"https://api.github.com/repos/o/simmetrica/comments{/number}","issue_comment_url":"https://api.github.com/repos/o/simmetrica/issues/comments/{number}","contents_url":"https://api.github.com/repos/o/simmetrica/contents/{+path}","compare_url":"https://api.github.com/repos/o/simmetrica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/o/simmetrica/merges","archive_url":"https://api.github.com/repos/o/simmetrica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/o/simmetrica/downloads","issues_url":"https://api.github.com/repos/o/simmetrica/issues{/number}","pulls_url":"https://api.github.com/repos/o/simmetrica/pulls{/number}","milestones_url":"https://api.github.com/repos/o/simmetrica/milestones{/number}","notifications_url":"https://api.github.com/repos/o/simmetrica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/o/simmetrica/labels{/name}","releases_url":"https://api.github.com/repos/o/simmetrica/releases{/id}","created_at":"2013-03-18T09:53:59Z","updated_at":"2014-07-02T01:43:54Z","pushed_at":"2014-07-02T11:05:36Z","git_url":"git://github.com/o/simmetrica.git","ssh_url":"git@github.com:o/simmetrica.git","clone_url":"https://github.com/o/simmetrica.git","svn_url":"https://github.com/o/simmetrica","homepage":"","size":733,"stargazers_count":482,"watchers_count":482,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":23,"mirror_url":null,"open_issues_count":2,"forks":23,"open_issues":2,"watchers":482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/o/simmetrica/pulls/12"},"html":{"href":"https://github.com/o/simmetrica/pull/12"},"issue":{"href":"https://api.github.com/repos/o/simmetrica/issues/12"},"comments":{"href":"https://api.github.com/repos/o/simmetrica/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/o/simmetrica/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/o/simmetrica/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/o/simmetrica/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/o/simmetrica/statuses/f59f341b6a7302c7eca35674ab37ffa7d9f4d2e7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"o","id":179912,"avatar_url":"https://avatars.githubusercontent.com/u/179912?","gravatar_id":"b1c80db91088bf97ed8e1453a59095b2","url":"https://api.github.com/users/o","html_url":"https://github.com/o","followers_url":"https://api.github.com/users/o/followers","following_url":"https://api.github.com/users/o/following{/other_user}","gists_url":"https://api.github.com/users/o/gists{/gist_id}","starred_url":"https://api.github.com/users/o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o/subscriptions","organizations_url":"https://api.github.com/users/o/orgs","repos_url":"https://api.github.com/users/o/repos","events_url":"https://api.github.com/users/o/events{/privacy}","received_events_url":"https://api.github.com/users/o/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":17,"deletions":5,"changed_files":2}}