GitHub PullRequestEvent at 2014-04-17 21:42:25
Repository: CruOrg
Actor: mattdrees
Payload: {"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/CruGlobal/CruOrg/pulls/2","id":14898745,"html_url":"https://github.com/CruGlobal/CruOrg/pull/2","diff_url":"https://github.com/CruGlobal/CruOrg/pull/2.diff","patch_url":"https://github.com/CruGlobal/CruOrg/pull/2.patch","issue_url":"https://api.github.com/repos/CruGlobal/CruOrg/issues/2","number":2,"state":"open","title":"Style modifications","user":{"login":"mattdrees","id":58439,"avatar_url":"https://avatars.githubusercontent.com/u/58439?","gravatar_id":"f302731367bdad29fe30ee230da836aa","url":"https://api.github.com/users/mattdrees","html_url":"https://github.com/mattdrees","followers_url":"https://api.github.com/users/mattdrees/followers","following_url":"https://api.github.com/users/mattdrees/following{/other_user}","gists_url":"https://api.github.com/users/mattdrees/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdrees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdrees/subscriptions","organizations_url":"https://api.github.com/users/mattdrees/orgs","repos_url":"https://api.github.com/users/mattdrees/repos","events_url":"https://api.github.com/users/mattdrees/events{/privacy}","received_events_url":"https://api.github.com/users/mattdrees/received_events","type":"User","site_admin":false},"body":"I'd like to suggest a few changes to the checkstyle.xml doc. \r\n\r\n1. My team has recently decided we want to try to limit method bodies to 15 lines long. Shorter methods are easier to read and also discourage too much unrelated stuff happening in a given method.\r\n2. I like google's [style guide rules for whitespace](http://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s4.6.2-horizontal-whitespace) around commas and other tokens/operators/keywords. I've incorporated their whitespace rules pretty much verbatim.\r\n\r\nDo these changes look reasonable? @palecio-xumak , I'm guessing this is your call, but let me know if I should ask someone else instead.","created_at":"2014-04-17T21:42:24Z","updated_at":"2014-04-17T21:42:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CruGlobal/CruOrg/pulls/2/commits","review_comments_url":"https://api.github.com/repos/CruGlobal/CruOrg/pulls/2/comments","review_comment_url":"https://api.github.com/repos/CruGlobal/CruOrg/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CruGlobal/CruOrg/issues/2/comments","statuses_url":"https://api.github.com/repos/CruGlobal/CruOrg/statuses/5a0f3640f683df3be19e2fdc7e837efb62ef2b6e","head":{"label":"CruGlobal:style-modifications","ref":"style-modifications","sha":"5a0f3640f683df3be19e2fdc7e837efb62ef2b6e","user":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?","gravatar_id":"fff0e4838db6e8e33d895977195fa2ce","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"repo":{"id":18449578,"name":"CruOrg","full_name":"CruGlobal/CruOrg","owner":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?","gravatar_id":"fff0e4838db6e8e33d895977195fa2ce","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CruGlobal/CruOrg","description":"Repository CruOrg","fork":false,"url":"https://api.github.com/repos/CruGlobal/CruOrg","forks_url":"https://api.github.com/repos/CruGlobal/CruOrg/forks","keys_url":"https://api.github.com/repos/CruGlobal/CruOrg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CruGlobal/CruOrg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CruGlobal/CruOrg/teams","hooks_url":"https://api.github.com/repos/CruGlobal/CruOrg/hooks","issue_events_url":"https://api.github.com/repos/CruGlobal/CruOrg/issues/events{/number}","events_url":"https://api.github.com/repos/CruGlobal/CruOrg/events","assignees_url":"https://api.github.com/repos/CruGlobal/CruOrg/assignees{/user}","branches_url":"https://api.github.com/repos/CruGlobal/CruOrg/branches{/branch}","tags_url":"https://api.github.com/repos/CruGlobal/CruOrg/tags","blobs_url":"https://api.github.com/repos/CruGlobal/CruOrg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CruGlobal/CruOrg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CruGlobal/CruOrg/git/refs{/sha}","trees_url":"https://api.github.com/repos/CruGlobal/CruOrg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CruGlobal/CruOrg/statuses/{sha}","languages_url":"https://api.github.com/repos/CruGlobal/CruOrg/languages","stargazers_url":"https://api.github.com/repos/CruGlobal/CruOrg/stargazers","contributors_url":"https://api.github.com/repos/CruGlobal/CruOrg/contributors","subscribers_url":"https://api.github.com/repos/CruGlobal/CruOrg/subscribers","subscription_url":"https://api.github.com/repos/CruGlobal/CruOrg/subscription","commits_url":"https://api.github.com/repos/CruGlobal/CruOrg/commits{/sha}","git_commits_url":"https://api.github.com/repos/CruGlobal/CruOrg/git/commits{/sha}","comments_url":"https://api.github.com/repos/CruGlobal/CruOrg/comments{/number}","issue_comment_url":"https://api.github.com/repos/CruGlobal/CruOrg/issues/comments/{number}","contents_url":"https://api.github.com/repos/CruGlobal/CruOrg/contents/{+path}","compare_url":"https://api.github.com/repos/CruGlobal/CruOrg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CruGlobal/CruOrg/merges","archive_url":"https://api.github.com/repos/CruGlobal/CruOrg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CruGlobal/CruOrg/downloads","issues_url":"https://api.github.com/repos/CruGlobal/CruOrg/issues{/number}","pulls_url":"https://api.github.com/repos/CruGlobal/CruOrg/pulls{/number}","milestones_url":"https://api.github.com/repos/CruGlobal/CruOrg/milestones{/number}","notifications_url":"https://api.github.com/repos/CruGlobal/CruOrg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CruGlobal/CruOrg/labels{/name}","releases_url":"https://api.github.com/repos/CruGlobal/CruOrg/releases{/id}","created_at":"2014-04-04T19:17:34Z","updated_at":"2014-04-17T21:42:24Z","pushed_at":"2014-04-17T21:31:53Z","git_url":"git://github.com/CruGlobal/CruOrg.git","ssh_url":"git@github.com:CruGlobal/CruOrg.git","clone_url":"https://github.com/CruGlobal/CruOrg.git","svn_url":"https://github.com/CruGlobal/CruOrg","homepage":"https://xumak.com","size":408,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"CruGlobal:dev","ref":"dev","sha":"5e936fabc9154ea4a69a6a78ccad3f0d8bfa92cf","user":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?","gravatar_id":"fff0e4838db6e8e33d895977195fa2ce","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"repo":{"id":18449578,"name":"CruOrg","full_name":"CruGlobal/CruOrg","owner":{"login":"CruGlobal","id":1785912,"avatar_url":"https://avatars.githubusercontent.com/u/1785912?","gravatar_id":"fff0e4838db6e8e33d895977195fa2ce","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CruGlobal/CruOrg","description":"Repository CruOrg","fork":false,"url":"https://api.github.com/repos/CruGlobal/CruOrg","forks_url":"https://api.github.com/repos/CruGlobal/CruOrg/forks","keys_url":"https://api.github.com/repos/CruGlobal/CruOrg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CruGlobal/CruOrg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CruGlobal/CruOrg/teams","hooks_url":"https://api.github.com/repos/CruGlobal/CruOrg/hooks","issue_events_url":"https://api.github.com/repos/CruGlobal/CruOrg/issues/events{/number}","events_url":"https://api.github.com/repos/CruGlobal/CruOrg/events","assignees_url":"https://api.github.com/repos/CruGlobal/CruOrg/assignees{/user}","branches_url":"https://api.github.com/repos/CruGlobal/CruOrg/branches{/branch}","tags_url":"https://api.github.com/repos/CruGlobal/CruOrg/tags","blobs_url":"https://api.github.com/repos/CruGlobal/CruOrg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CruGlobal/CruOrg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CruGlobal/CruOrg/git/refs{/sha}","trees_url":"https://api.github.com/repos/CruGlobal/CruOrg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CruGlobal/CruOrg/statuses/{sha}","languages_url":"https://api.github.com/repos/CruGlobal/CruOrg/languages","stargazers_url":"https://api.github.com/repos/CruGlobal/CruOrg/stargazers","contributors_url":"https://api.github.com/repos/CruGlobal/CruOrg/contributors","subscribers_url":"https://api.github.com/repos/CruGlobal/CruOrg/subscribers","subscription_url":"https://api.github.com/repos/CruGlobal/CruOrg/subscription","commits_url":"https://api.github.com/repos/CruGlobal/CruOrg/commits{/sha}","git_commits_url":"https://api.github.com/repos/CruGlobal/CruOrg/git/commits{/sha}","comments_url":"https://api.github.com/repos/CruGlobal/CruOrg/comments{/number}","issue_comment_url":"https://api.github.com/repos/CruGlobal/CruOrg/issues/comments/{number}","contents_url":"https://api.github.com/repos/CruGlobal/CruOrg/contents/{+path}","compare_url":"https://api.github.com/repos/CruGlobal/CruOrg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CruGlobal/CruOrg/merges","archive_url":"https://api.github.com/repos/CruGlobal/CruOrg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CruGlobal/CruOrg/downloads","issues_url":"https://api.github.com/repos/CruGlobal/CruOrg/issues{/number}","pulls_url":"https://api.github.com/repos/CruGlobal/CruOrg/pulls{/number}","milestones_url":"https://api.github.com/repos/CruGlobal/CruOrg/milestones{/number}","notifications_url":"https://api.github.com/repos/CruGlobal/CruOrg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CruGlobal/CruOrg/labels{/name}","releases_url":"https://api.github.com/repos/CruGlobal/CruOrg/releases{/id}","created_at":"2014-04-04T19:17:34Z","updated_at":"2014-04-17T21:42:24Z","pushed_at":"2014-04-17T21:31:53Z","git_url":"git://github.com/CruGlobal/CruOrg.git","ssh_url":"git@github.com:CruGlobal/CruOrg.git","clone_url":"https://github.com/CruGlobal/CruOrg.git","svn_url":"https://github.com/CruGlobal/CruOrg","homepage":"https://xumak.com","size":408,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CruGlobal/CruOrg/pulls/2"},"html":{"href":"https://github.com/CruGlobal/CruOrg/pull/2"},"issue":{"href":"https://api.github.com/repos/CruGlobal/CruOrg/issues/2"},"comments":{"href":"https://api.github.com/repos/CruGlobal/CruOrg/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/CruGlobal/CruOrg/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/CruGlobal/CruOrg/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CruGlobal/CruOrg/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/CruGlobal/CruOrg/statuses/5a0f3640f683df3be19e2fdc7e837efb62ef2b6e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":94,"deletions":34,"changed_files":5}}