GitHub PullRequestEvent at 2014-12-05 01:17:02
Repository: forms
Actor: dg
Payload: {"action":"closed","number":54,"pull_request":{"url":"https://api.github.com/repos/nette/forms/pulls/54","id":25542966,"html_url":"https://github.com/nette/forms/pull/54","diff_url":"https://github.com/nette/forms/pull/54.diff","patch_url":"https://github.com/nette/forms/pull/54.patch","issue_url":"https://api.github.com/repos/nette/forms/issues/54","number":54,"state":"closed","locked":false,"title":"Exclude examples folder for Bower","user":{"login":"Aurielle","id":144428,"avatar_url":"https://avatars.githubusercontent.com/u/144428?v=3","gravatar_id":"","url":"https://api.github.com/users/Aurielle","html_url":"https://github.com/Aurielle","followers_url":"https://api.github.com/users/Aurielle/followers","following_url":"https://api.github.com/users/Aurielle/following{/other_user}","gists_url":"https://api.github.com/users/Aurielle/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurielle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurielle/subscriptions","organizations_url":"https://api.github.com/users/Aurielle/orgs","repos_url":"https://api.github.com/users/Aurielle/repos","events_url":"https://api.github.com/users/Aurielle/events{/privacy}","received_events_url":"https://api.github.com/users/Aurielle/received_events","type":"User","site_admin":false},"body":"I think that examples should be excluded when installing through Bower, because the primary reason is to obtain netteForms.js. @vojtech-dobes's nette.ajax.js is dependant on this repository and including PHP code is, in my opinion, not only unneeded as it bloats the project, but also bad practise – Bower should be used for web component distribution, so shouldn't include PHP scripts if they're not directly related. For everything other we have Composer.\r\n\r\nWhat are your thoughts?","created_at":"2014-12-05T01:14:59Z","updated_at":"2014-12-05T01:17:02Z","closed_at":"2014-12-05T01:17:02Z","merged_at":"2014-12-05T01:17:02Z","merge_commit_sha":"7cd4727481a166c0483e2249f7abd963d58c7056","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nette/forms/pulls/54/commits","review_comments_url":"https://api.github.com/repos/nette/forms/pulls/54/comments","review_comment_url":"https://api.github.com/repos/nette/forms/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nette/forms/issues/54/comments","statuses_url":"https://api.github.com/repos/nette/forms/statuses/096635badaea3962a3ea070ac19363946a623d10","head":{"label":"Aurielle:master","ref":"master","sha":"096635badaea3962a3ea070ac19363946a623d10","user":{"login":"Aurielle","id":144428,"avatar_url":"https://avatars.githubusercontent.com/u/144428?v=3","gravatar_id":"","url":"https://api.github.com/users/Aurielle","html_url":"https://github.com/Aurielle","followers_url":"https://api.github.com/users/Aurielle/followers","following_url":"https://api.github.com/users/Aurielle/following{/other_user}","gists_url":"https://api.github.com/users/Aurielle/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurielle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurielle/subscriptions","organizations_url":"https://api.github.com/users/Aurielle/orgs","repos_url":"https://api.github.com/users/Aurielle/repos","events_url":"https://api.github.com/users/Aurielle/events{/privacy}","received_events_url":"https://api.github.com/users/Aurielle/received_events","type":"User","site_admin":false},"repo":{"id":27567726,"name":"nette-forms","full_name":"Aurielle/nette-forms","owner":{"login":"Aurielle","id":144428,"avatar_url":"https://avatars.githubusercontent.com/u/144428?v=3","gravatar_id":"","url":"https://api.github.com/users/Aurielle","html_url":"https://github.com/Aurielle","followers_url":"https://api.github.com/users/Aurielle/followers","following_url":"https://api.github.com/users/Aurielle/following{/other_user}","gists_url":"https://api.github.com/users/Aurielle/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurielle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurielle/subscriptions","organizations_url":"https://api.github.com/users/Aurielle/orgs","repos_url":"https://api.github.com/users/Aurielle/repos","events_url":"https://api.github.com/users/Aurielle/events{/privacy}","received_events_url":"https://api.github.com/users/Aurielle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Aurielle/nette-forms","description":"Nette Forms: greatly facilitates web forms","fork":true,"url":"https://api.github.com/repos/Aurielle/nette-forms","forks_url":"https://api.github.com/repos/Aurielle/nette-forms/forks","keys_url":"https://api.github.com/repos/Aurielle/nette-forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aurielle/nette-forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aurielle/nette-forms/teams","hooks_url":"https://api.github.com/repos/Aurielle/nette-forms/hooks","issue_events_url":"https://api.github.com/repos/Aurielle/nette-forms/issues/events{/number}","events_url":"https://api.github.com/repos/Aurielle/nette-forms/events","assignees_url":"https://api.github.com/repos/Aurielle/nette-forms/assignees{/user}","branches_url":"https://api.github.com/repos/Aurielle/nette-forms/branches{/branch}","tags_url":"https://api.github.com/repos/Aurielle/nette-forms/tags","blobs_url":"https://api.github.com/repos/Aurielle/nette-forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aurielle/nette-forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aurielle/nette-forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aurielle/nette-forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aurielle/nette-forms/statuses/{sha}","languages_url":"https://api.github.com/repos/Aurielle/nette-forms/languages","stargazers_url":"https://api.github.com/repos/Aurielle/nette-forms/stargazers","contributors_url":"https://api.github.com/repos/Aurielle/nette-forms/contributors","subscribers_url":"https://api.github.com/repos/Aurielle/nette-forms/subscribers","subscription_url":"https://api.github.com/repos/Aurielle/nette-forms/subscription","commits_url":"https://api.github.com/repos/Aurielle/nette-forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aurielle/nette-forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aurielle/nette-forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aurielle/nette-forms/issues/comments/{number}","contents_url":"https://api.github.com/repos/Aurielle/nette-forms/contents/{+path}","compare_url":"https://api.github.com/repos/Aurielle/nette-forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aurielle/nette-forms/merges","archive_url":"https://api.github.com/repos/Aurielle/nette-forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aurielle/nette-forms/downloads","issues_url":"https://api.github.com/repos/Aurielle/nette-forms/issues{/number}","pulls_url":"https://api.github.com/repos/Aurielle/nette-forms/pulls{/number}","milestones_url":"https://api.github.com/repos/Aurielle/nette-forms/milestones{/number}","notifications_url":"https://api.github.com/repos/Aurielle/nette-forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aurielle/nette-forms/labels{/name}","releases_url":"https://api.github.com/repos/Aurielle/nette-forms/releases{/id}","created_at":"2014-12-05T01:00:35Z","updated_at":"2014-12-05T01:04:27Z","pushed_at":"2014-12-05T01:04:27Z","git_url":"git://github.com/Aurielle/nette-forms.git","ssh_url":"git@github.com:Aurielle/nette-forms.git","clone_url":"https://github.com/Aurielle/nette-forms.git","svn_url":"https://github.com/Aurielle/nette-forms","homepage":"http://nette.org","size":1719,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nette:master","ref":"master","sha":"ddb75f5089b89c2ef5b7885f31346b588bca4e00","user":{"login":"nette","id":99965,"avatar_url":"https://avatars.githubusercontent.com/u/99965?v=3","gravatar_id":"","url":"https://api.github.com/users/nette","html_url":"https://github.com/nette","followers_url":"https://api.github.com/users/nette/followers","following_url":"https://api.github.com/users/nette/following{/other_user}","gists_url":"https://api.github.com/users/nette/gists{/gist_id}","starred_url":"https://api.github.com/users/nette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nette/subscriptions","organizations_url":"https://api.github.com/users/nette/orgs","repos_url":"https://api.github.com/users/nette/repos","events_url":"https://api.github.com/users/nette/events{/privacy}","received_events_url":"https://api.github.com/users/nette/received_events","type":"Organization","site_admin":false},"repo":{"id":14788795,"name":"forms","full_name":"nette/forms","owner":{"login":"nette","id":99965,"avatar_url":"https://avatars.githubusercontent.com/u/99965?v=3","gravatar_id":"","url":"https://api.github.com/users/nette","html_url":"https://github.com/nette","followers_url":"https://api.github.com/users/nette/followers","following_url":"https://api.github.com/users/nette/following{/other_user}","gists_url":"https://api.github.com/users/nette/gists{/gist_id}","starred_url":"https://api.github.com/users/nette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nette/subscriptions","organizations_url":"https://api.github.com/users/nette/orgs","repos_url":"https://api.github.com/users/nette/repos","events_url":"https://api.github.com/users/nette/events{/privacy}","received_events_url":"https://api.github.com/users/nette/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nette/forms","description":"Nette Forms: greatly facilitates web forms","fork":false,"url":"https://api.github.com/repos/nette/forms","forks_url":"https://api.github.com/repos/nette/forms/forks","keys_url":"https://api.github.com/repos/nette/forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nette/forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nette/forms/teams","hooks_url":"https://api.github.com/repos/nette/forms/hooks","issue_events_url":"https://api.github.com/repos/nette/forms/issues/events{/number}","events_url":"https://api.github.com/repos/nette/forms/events","assignees_url":"https://api.github.com/repos/nette/forms/assignees{/user}","branches_url":"https://api.github.com/repos/nette/forms/branches{/branch}","tags_url":"https://api.github.com/repos/nette/forms/tags","blobs_url":"https://api.github.com/repos/nette/forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nette/forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nette/forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/nette/forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nette/forms/statuses/{sha}","languages_url":"https://api.github.com/repos/nette/forms/languages","stargazers_url":"https://api.github.com/repos/nette/forms/stargazers","contributors_url":"https://api.github.com/repos/nette/forms/contributors","subscribers_url":"https://api.github.com/repos/nette/forms/subscribers","subscription_url":"https://api.github.com/repos/nette/forms/subscription","commits_url":"https://api.github.com/repos/nette/forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/nette/forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/nette/forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/nette/forms/issues/comments/{number}","contents_url":"https://api.github.com/repos/nette/forms/contents/{+path}","compare_url":"https://api.github.com/repos/nette/forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nette/forms/merges","archive_url":"https://api.github.com/repos/nette/forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nette/forms/downloads","issues_url":"https://api.github.com/repos/nette/forms/issues{/number}","pulls_url":"https://api.github.com/repos/nette/forms/pulls{/number}","milestones_url":"https://api.github.com/repos/nette/forms/milestones{/number}","notifications_url":"https://api.github.com/repos/nette/forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nette/forms/labels{/name}","releases_url":"https://api.github.com/repos/nette/forms/releases{/id}","created_at":"2013-11-28T23:35:47Z","updated_at":"2014-12-05T01:17:02Z","pushed_at":"2014-12-05T01:17:02Z","git_url":"git://github.com/nette/forms.git","ssh_url":"git@github.com:nette/forms.git","clone_url":"https://github.com/nette/forms.git","svn_url":"https://github.com/nette/forms","homepage":"http://nette.org","size":1719,"stargazers_count":67,"watchers_count":67,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":12,"forks":27,"open_issues":12,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nette/forms/pulls/54"},"html":{"href":"https://github.com/nette/forms/pull/54"},"issue":{"href":"https://api.github.com/repos/nette/forms/issues/54"},"comments":{"href":"https://api.github.com/repos/nette/forms/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/nette/forms/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/nette/forms/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nette/forms/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/nette/forms/statuses/096635badaea3962a3ea070ac19363946a623d10"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dg","id":194960,"avatar_url":"https://avatars.githubusercontent.com/u/194960?v=3","gravatar_id":"","url":"https://api.github.com/users/dg","html_url":"https://github.com/dg","followers_url":"https://api.github.com/users/dg/followers","following_url":"https://api.github.com/users/dg/following{/other_user}","gists_url":"https://api.github.com/users/dg/gists{/gist_id}","starred_url":"https://api.github.com/users/dg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dg/subscriptions","organizations_url":"https://api.github.com/users/dg/orgs","repos_url":"https://api.github.com/users/dg/repos","events_url":"https://api.github.com/users/dg/events{/privacy}","received_events_url":"https://api.github.com/users/dg/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}