GitHub PushEvent at 2014-05-29 21:49:08
Repository: subsurface
Actor: dirkhh
Payload: {"shas":[["56395b38946d4b7de9e485098e928e8e432ef920","a00b27378a09822d5638cdfb8c2e7ccc36d74c56@hohndel.org","Don't assume that pressures are always positive\n\nWhen planning a dive, the dive could use more gas than is in the cylinder.\nSo getting a negative end pressure is a useful indication to the user that\nthere plan might not be a good one.\n\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Dirk Hohndel",true],["d054e8c457c2113b39a7d8fe21215c99a86d1d9d","a00b27378a09822d5638cdfb8c2e7ccc36d74c56@hohndel.org","Planner: track gas consumption in cylinders and samples\n\nThis commit is a little bigger than I usually prefer, but it's all\nsomewhat interconnected.\n\n- we pass around the cylinders throughout the planning process and as we\n  create the plan we calculate the gas consumption in every segment and\n  track this both in the end pressure of the cylinder and over time in\n  the samples\n- because of that we no longer try to calculate the gas consumption after\n  being done planning; we just use what we calculated along the way\n- we also no longer add gases during the planning process - all gases\n  have to come from the list of cylinders passed in (which makes sense\n  as we should only use those gases that the user added in the UI or\n  inherited from a the selected dive (when starting to plan with a dive\n  already selected)\n\nWith this patch I think we are close do being able to move all of the\nplanning logic back into the planner.c code where it belongs. The one\nissue that still bothers me is that we are juggling so many dive\nstructures and then keep copying content around. It seems like we should\nbe able to reduce that.\n\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Dirk Hohndel",true]],"size":2,"ref":"refs/heads/master","head":"d054e8c457c2113b39a7d8fe21215c99a86d1d9d"}