GitHub PullRequestEvent at 2014-08-23 19:49:09
Repository: meteor-feature-flag
Actor: recursivefaults
Payload: {"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/pulls/5","id":20096094,"html_url":"https://github.com/recursivefaults/meteor-feature-flag/pull/5","diff_url":"https://github.com/recursivefaults/meteor-feature-flag/pull/5.diff","patch_url":"https://github.com/recursivefaults/meteor-feature-flag/pull/5.patch","issue_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/issues/5","number":5,"state":"closed","locked":false,"title":"Remove check for Meteor.userId() as session can be used without it","user":{"login":"Maxim-Filimonov","id":360645,"avatar_url":"https://avatars.githubusercontent.com/u/360645?v=2","gravatar_id":"a13b3cdba3c785ca92d7cc2abedc3ba3","url":"https://api.github.com/users/Maxim-Filimonov","html_url":"https://github.com/Maxim-Filimonov","followers_url":"https://api.github.com/users/Maxim-Filimonov/followers","following_url":"https://api.github.com/users/Maxim-Filimonov/following{/other_user}","gists_url":"https://api.github.com/users/Maxim-Filimonov/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxim-Filimonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxim-Filimonov/subscriptions","organizations_url":"https://api.github.com/users/Maxim-Filimonov/orgs","repos_url":"https://api.github.com/users/Maxim-Filimonov/repos","events_url":"https://api.github.com/users/Maxim-Filimonov/events{/privacy}","received_events_url":"https://api.github.com/users/Maxim-Filimonov/received_events","type":"User","site_admin":false},"body":"We don't use accounts package but still would like to use that package. I can't see why this check is required as session is based on cookie not necessary on accounts package meteor.userId","created_at":"2014-08-21T08:32:03Z","updated_at":"2014-08-23T19:49:09Z","closed_at":"2014-08-23T19:49:09Z","merged_at":"2014-08-23T19:49:09Z","merge_commit_sha":"55b873f7be6101dcbb45a62817450172966002e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/pulls/5/commits","review_comments_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/pulls/5/comments","review_comment_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/pulls/comments/{number}","comments_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/issues/5/comments","statuses_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/statuses/6b49ad50e967af28fcc76fb57c895c1d9ef6af9d","head":{"label":"Maxim-Filimonov:remove_accounts_package_requirement","ref":"remove_accounts_package_requirement","sha":"6b49ad50e967af28fcc76fb57c895c1d9ef6af9d","user":{"login":"Maxim-Filimonov","id":360645,"avatar_url":"https://avatars.githubusercontent.com/u/360645?v=2","gravatar_id":"a13b3cdba3c785ca92d7cc2abedc3ba3","url":"https://api.github.com/users/Maxim-Filimonov","html_url":"https://github.com/Maxim-Filimonov","followers_url":"https://api.github.com/users/Maxim-Filimonov/followers","following_url":"https://api.github.com/users/Maxim-Filimonov/following{/other_user}","gists_url":"https://api.github.com/users/Maxim-Filimonov/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxim-Filimonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxim-Filimonov/subscriptions","organizations_url":"https://api.github.com/users/Maxim-Filimonov/orgs","repos_url":"https://api.github.com/users/Maxim-Filimonov/repos","events_url":"https://api.github.com/users/Maxim-Filimonov/events{/privacy}","received_events_url":"https://api.github.com/users/Maxim-Filimonov/received_events","type":"User","site_admin":false},"repo":{"id":22899605,"name":"meteor-feature-flag","full_name":"Maxim-Filimonov/meteor-feature-flag","owner":{"login":"Maxim-Filimonov","id":360645,"avatar_url":"https://avatars.githubusercontent.com/u/360645?v=2","gravatar_id":"a13b3cdba3c785ca92d7cc2abedc3ba3","url":"https://api.github.com/users/Maxim-Filimonov","html_url":"https://github.com/Maxim-Filimonov","followers_url":"https://api.github.com/users/Maxim-Filimonov/followers","following_url":"https://api.github.com/users/Maxim-Filimonov/following{/other_user}","gists_url":"https://api.github.com/users/Maxim-Filimonov/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxim-Filimonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxim-Filimonov/subscriptions","organizations_url":"https://api.github.com/users/Maxim-Filimonov/orgs","repos_url":"https://api.github.com/users/Maxim-Filimonov/repos","events_url":"https://api.github.com/users/Maxim-Filimonov/events{/privacy}","received_events_url":"https://api.github.com/users/Maxim-Filimonov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Maxim-Filimonov/meteor-feature-flag","description":"A simple way to feature flag templates and features","fork":true,"url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag","forks_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/forks","keys_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/teams","hooks_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/hooks","issue_events_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/issues/events{/number}","events_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/events","assignees_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/assignees{/user}","branches_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/branches{/branch}","tags_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/tags","blobs_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/git/refs{/sha}","trees_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/statuses/{sha}","languages_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/languages","stargazers_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/stargazers","contributors_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/contributors","subscribers_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/subscribers","subscription_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/subscription","commits_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/commits{/sha}","git_commits_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/git/commits{/sha}","comments_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/comments{/number}","issue_comment_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/issues/comments/{number}","contents_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/contents/{+path}","compare_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/merges","archive_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/downloads","issues_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/issues{/number}","pulls_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/pulls{/number}","milestones_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/milestones{/number}","notifications_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/labels{/name}","releases_url":"https://api.github.com/repos/Maxim-Filimonov/meteor-feature-flag/releases{/id}","created_at":"2014-08-13T02:20:48Z","updated_at":"2014-08-18T08:17:13Z","pushed_at":"2014-08-21T08:33:25Z","git_url":"git://github.com/Maxim-Filimonov/meteor-feature-flag.git","ssh_url":"git@github.com:Maxim-Filimonov/meteor-feature-flag.git","clone_url":"https://github.com/Maxim-Filimonov/meteor-feature-flag.git","svn_url":"https://github.com/Maxim-Filimonov/meteor-feature-flag","homepage":null,"size":205,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"recursivefaults:master","ref":"master","sha":"8f14ebe71c8c82e8d00aef80443bf304478c367f","user":{"login":"recursivefaults","id":792405,"avatar_url":"https://avatars.githubusercontent.com/u/792405?v=2","gravatar_id":"71d55537710ab6fe89b023b6382cffaf","url":"https://api.github.com/users/recursivefaults","html_url":"https://github.com/recursivefaults","followers_url":"https://api.github.com/users/recursivefaults/followers","following_url":"https://api.github.com/users/recursivefaults/following{/other_user}","gists_url":"https://api.github.com/users/recursivefaults/gists{/gist_id}","starred_url":"https://api.github.com/users/recursivefaults/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recursivefaults/subscriptions","organizations_url":"https://api.github.com/users/recursivefaults/orgs","repos_url":"https://api.github.com/users/recursivefaults/repos","events_url":"https://api.github.com/users/recursivefaults/events{/privacy}","received_events_url":"https://api.github.com/users/recursivefaults/received_events","type":"User","site_admin":false},"repo":{"id":12703386,"name":"meteor-feature-flag","full_name":"recursivefaults/meteor-feature-flag","owner":{"login":"recursivefaults","id":792405,"avatar_url":"https://avatars.githubusercontent.com/u/792405?v=2","gravatar_id":"71d55537710ab6fe89b023b6382cffaf","url":"https://api.github.com/users/recursivefaults","html_url":"https://github.com/recursivefaults","followers_url":"https://api.github.com/users/recursivefaults/followers","following_url":"https://api.github.com/users/recursivefaults/following{/other_user}","gists_url":"https://api.github.com/users/recursivefaults/gists{/gist_id}","starred_url":"https://api.github.com/users/recursivefaults/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recursivefaults/subscriptions","organizations_url":"https://api.github.com/users/recursivefaults/orgs","repos_url":"https://api.github.com/users/recursivefaults/repos","events_url":"https://api.github.com/users/recursivefaults/events{/privacy}","received_events_url":"https://api.github.com/users/recursivefaults/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/recursivefaults/meteor-feature-flag","description":"A simple way to feature flag templates and features","fork":false,"url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag","forks_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/forks","keys_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/teams","hooks_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/hooks","issue_events_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/issues/events{/number}","events_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/events","assignees_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/assignees{/user}","branches_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/branches{/branch}","tags_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/tags","blobs_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/git/refs{/sha}","trees_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/statuses/{sha}","languages_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/languages","stargazers_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/stargazers","contributors_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/contributors","subscribers_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/subscribers","subscription_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/subscription","commits_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/commits{/sha}","git_commits_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/git/commits{/sha}","comments_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/comments{/number}","issue_comment_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/issues/comments/{number}","contents_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/contents/{+path}","compare_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/merges","archive_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/downloads","issues_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/issues{/number}","pulls_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/pulls{/number}","milestones_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/milestones{/number}","notifications_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/labels{/name}","releases_url":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/releases{/id}","created_at":"2013-09-09T14:22:15Z","updated_at":"2014-07-16T10:13:30Z","pushed_at":"2014-08-23T19:49:09Z","git_url":"git://github.com/recursivefaults/meteor-feature-flag.git","ssh_url":"git@github.com:recursivefaults/meteor-feature-flag.git","clone_url":"https://github.com/recursivefaults/meteor-feature-flag.git","svn_url":"https://github.com/recursivefaults/meteor-feature-flag","homepage":null,"size":213,"stargazers_count":2,"watchers_count":2,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/pulls/5"},"html":{"href":"https://github.com/recursivefaults/meteor-feature-flag/pull/5"},"issue":{"href":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/issues/5"},"comments":{"href":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/recursivefaults/meteor-feature-flag/statuses/6b49ad50e967af28fcc76fb57c895c1d9ef6af9d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"recursivefaults","id":792405,"avatar_url":"https://avatars.githubusercontent.com/u/792405?v=2","gravatar_id":"71d55537710ab6fe89b023b6382cffaf","url":"https://api.github.com/users/recursivefaults","html_url":"https://github.com/recursivefaults","followers_url":"https://api.github.com/users/recursivefaults/followers","following_url":"https://api.github.com/users/recursivefaults/following{/other_user}","gists_url":"https://api.github.com/users/recursivefaults/gists{/gist_id}","starred_url":"https://api.github.com/users/recursivefaults/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recursivefaults/subscriptions","organizations_url":"https://api.github.com/users/recursivefaults/orgs","repos_url":"https://api.github.com/users/recursivefaults/repos","events_url":"https://api.github.com/users/recursivefaults/events{/privacy}","received_events_url":"https://api.github.com/users/recursivefaults/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":5,"changed_files":1}}