GitHub PullRequestEvent at 2014-07-04 01:03:37
Repository: civicrm-core
Actor: totten
Payload: {"action":"opened","number":3606,"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/3606","id":17975782,"html_url":"https://github.com/civicrm/civicrm-core/pull/3606","diff_url":"https://github.com/civicrm/civicrm-core/pull/3606.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/3606.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/3606","number":3606,"state":"open","title":"CRM-14931 - CRM.loadPage - Dialogs should respect statusBounce","user":{"login":"totten","id":1336047,"avatar_url":"https://avatars.githubusercontent.com/u/1336047?","gravatar_id":"c5744c71cbdb0696a3143d924d55993b","url":"https://api.github.com/users/totten","html_url":"https://github.com/totten","followers_url":"https://api.github.com/users/totten/followers","following_url":"https://api.github.com/users/totten/following{/other_user}","gists_url":"https://api.github.com/users/totten/gists{/gist_id}","starred_url":"https://api.github.com/users/totten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totten/subscriptions","organizations_url":"https://api.github.com/users/totten/orgs","repos_url":"https://api.github.com/users/totten/repos","events_url":"https://api.github.com/users/totten/events{/privacy}","received_events_url":"https://api.github.com/users/totten/received_events","type":"User","site_admin":false},"body":"When a dialog requests a page that sends a status-bounce, show the alert and\nclose the dialog.  I'm not sure if this policy is overly broad (I don't\nknow all the ways in which CRM.loadPage gets used), but it feels like\nan improvement on the \"Manage Case\" screen.\n\nIt's still not ideal -- an empty dialog briefly flashes on the screen while\nthe AJAX request is sent.  But we do need *some* visual feedback about the\npending AJAX request, and that's currently what we have.","created_at":"2014-07-04T01:03:37Z","updated_at":"2014-07-04T01:03:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/3606/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/3606/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/3606/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/03195c55026a0e33d505744f515c8b731e8b0883","head":{"label":"totten:master-dialog-bounce2","ref":"master-dialog-bounce2","sha":"03195c55026a0e33d505744f515c8b731e8b0883","user":{"login":"totten","id":1336047,"avatar_url":"https://avatars.githubusercontent.com/u/1336047?","gravatar_id":"c5744c71cbdb0696a3143d924d55993b","url":"https://api.github.com/users/totten","html_url":"https://github.com/totten","followers_url":"https://api.github.com/users/totten/followers","following_url":"https://api.github.com/users/totten/following{/other_user}","gists_url":"https://api.github.com/users/totten/gists{/gist_id}","starred_url":"https://api.github.com/users/totten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totten/subscriptions","organizations_url":"https://api.github.com/users/totten/orgs","repos_url":"https://api.github.com/users/totten/repos","events_url":"https://api.github.com/users/totten/events{/privacy}","received_events_url":"https://api.github.com/users/totten/received_events","type":"User","site_admin":false},"repo":{"id":8498842,"name":"civicrm-core","full_name":"totten/civicrm-core","owner":{"login":"totten","id":1336047,"avatar_url":"https://avatars.githubusercontent.com/u/1336047?","gravatar_id":"c5744c71cbdb0696a3143d924d55993b","url":"https://api.github.com/users/totten","html_url":"https://github.com/totten","followers_url":"https://api.github.com/users/totten/followers","following_url":"https://api.github.com/users/totten/following{/other_user}","gists_url":"https://api.github.com/users/totten/gists{/gist_id}","starred_url":"https://api.github.com/users/totten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totten/subscriptions","organizations_url":"https://api.github.com/users/totten/orgs","repos_url":"https://api.github.com/users/totten/repos","events_url":"https://api.github.com/users/totten/events{/privacy}","received_events_url":"https://api.github.com/users/totten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/totten/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/totten/civicrm-core","forks_url":"https://api.github.com/repos/totten/civicrm-core/forks","keys_url":"https://api.github.com/repos/totten/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/totten/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/totten/civicrm-core/teams","hooks_url":"https://api.github.com/repos/totten/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/totten/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/totten/civicrm-core/events","assignees_url":"https://api.github.com/repos/totten/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/totten/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/totten/civicrm-core/tags","blobs_url":"https://api.github.com/repos/totten/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/totten/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/totten/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/totten/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/totten/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/totten/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/totten/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/totten/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/totten/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/totten/civicrm-core/subscription","commits_url":"https://api.github.com/repos/totten/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/totten/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/totten/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/totten/civicrm-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/totten/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/totten/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/totten/civicrm-core/merges","archive_url":"https://api.github.com/repos/totten/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/totten/civicrm-core/downloads","issues_url":"https://api.github.com/repos/totten/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/totten/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/totten/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/totten/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/totten/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/totten/civicrm-core/releases{/id}","created_at":"2013-03-01T10:09:08Z","updated_at":"2014-06-24T03:35:48Z","pushed_at":"2014-07-04T01:03:22Z","git_url":"git://github.com/totten/civicrm-core.git","ssh_url":"git@github.com:totten/civicrm-core.git","clone_url":"https://github.com/totten/civicrm-core.git","svn_url":"https://github.com/totten/civicrm-core","homepage":null,"size":44319,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:master","ref":"master","sha":"9d6e9c8d4164485fd9e479013b50ba99a02f90bc","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?","gravatar_id":"0a883f18f7cee6d3360c545d3f155ac8","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"name":"civicrm-core","full_name":"civicrm/civicrm-core","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?","gravatar_id":"0a883f18f7cee6d3360c545d3f155ac8","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","created_at":"2013-03-01T06:11:56Z","updated_at":"2014-06-25T14:34:56Z","pushed_at":"2014-07-03T17:58:11Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":75197,"stargazers_count":62,"watchers_count":62,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":214,"mirror_url":null,"open_issues_count":43,"forks":214,"open_issues":43,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/3606"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/3606"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/3606"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/3606/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/3606/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/3606/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/03195c55026a0e33d505744f515c8b731e8b0883"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":2,"changed_files":2}}