GitHub PullRequestReviewCommentEvent at 2014-11-21 00:07:15
Repository: cpp-ethereum
Actor: subtly
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/20688373","id":20688373,"diff_hunk":"@@ -337,10 +336,12 @@ int main(int argc, char** argv)\n \t\tweb3.connect(remoteHost, remotePort);\n \n #if ETH_JSONRPC\n-\tauto_ptr<WebThreeStubServer> jsonrpcServer;\n+\tunique_ptr<WebThreeStubServer> jsonrpcServer;\n+\tunique_ptr<jsonrpc::AbstractServerConnector> jsonrpcConnector;\n \tif (jsonrpc > -1)\n \t{\n-\t\tjsonrpcServer = auto_ptr<WebThreeStubServer>(new WebThreeStubServer(new jsonrpc::CorsHttpServer(jsonrpc), web3, {us}));\n+\t\tjsonrpcConnector = unique_ptr<jsonrpc::AbstractServerConnector>(new jsonrpc::CorsHttpServer(jsonrpc));\n+\t\tjsonrpcServer = unique_ptr<WebThreeStubServer>(new WebThreeStubServer(*jsonrpcConnector.get(), web3, {us}));","path":"eth/main.cpp","position":19,"original_position":19,"commit_id":"39f0fd1320a9b6c065113100b3a7875de937a6a0","original_commit_id":"39f0fd1320a9b6c065113100b3a7875de937a6a0","user":{"login":"subtly","id":6557250,"avatar_url":"https://avatars.githubusercontent.com/u/6557250?v=3","gravatar_id":"","url":"https://api.github.com/users/subtly","html_url":"https://github.com/subtly","followers_url":"https://api.github.com/users/subtly/followers","following_url":"https://api.github.com/users/subtly/following{/other_user}","gists_url":"https://api.github.com/users/subtly/gists{/gist_id}","starred_url":"https://api.github.com/users/subtly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subtly/subscriptions","organizations_url":"https://api.github.com/users/subtly/orgs","repos_url":"https://api.github.com/users/subtly/repos","events_url":"https://api.github.com/users/subtly/events{/privacy}","received_events_url":"https://api.github.com/users/subtly/received_events","type":"User","site_admin":false},"body":"I don't think unique_ptr should be used if the only use case is to pass a dereferenced pointer.\r\nAlso, why does this use WebThree___ and alethzero uses OurWebThree___?","created_at":"2014-11-21T00:07:15Z","updated_at":"2014-11-21T00:07:15Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/532#discussion_r20688373","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/532","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/20688373"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/532#discussion_r20688373"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/532"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/532","id":24765747,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/532","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/532.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/532.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/532","number":532,"state":"open","locked":false,"title":"cmake dependency refactoring / manage own dependencies / WIP","user":{"login":"sveneh","id":3418608,"avatar_url":"https://avatars.githubusercontent.com/u/3418608?v=3","gravatar_id":"","url":"https://api.github.com/users/sveneh","html_url":"https://github.com/sveneh","followers_url":"https://api.github.com/users/sveneh/followers","following_url":"https://api.github.com/users/sveneh/following{/other_user}","gists_url":"https://api.github.com/users/sveneh/gists{/gist_id}","starred_url":"https://api.github.com/users/sveneh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveneh/subscriptions","organizations_url":"https://api.github.com/users/sveneh/orgs","repos_url":"https://api.github.com/users/sveneh/repos","events_url":"https://api.github.com/users/sveneh/events{/privacy}","received_events_url":"https://api.github.com/users/sveneh/received_events","type":"User","site_admin":false},"body":"**This will significantly change the build system**\r\n\r\nThis is a first step to bring in proper multiplatform support, managed solely from CMake. To enable this, we will manage all library dependencies ourself, instead of relying on package managers like brew or apt-get.\r\n\r\nI.e.: instead of installing dependencies via brew, *use CMake in the extdep folder* (see the Readme there)\r\n\r\nIn the first step, only libraries CryptoPP and Json-RPC-CPP are included; it is a test to see that this workflow will work for everyone. This will also fix #453\r\n\r\nThe included libraries work fine under Ubuntu and OS X. Windows support is not there yet, however the patches from @debris in this PR are necessary to enable Windows support later (see #469)\r\n\r\n\r\n\r\nWhat is still missing:\r\n* Most libraries still need to be CMake-ified, so brew/apt-get  is still needed for them. \r\n* An automatic compile step will be added to provide pre-compiled libraries from buildbot, so that developers won't have to compile libraries themselves\r\n* buildbot will likely complain about this PR, let's see.\r\n\r\n","created_at":"2014-11-20T13:45:50Z","updated_at":"2014-11-21T00:07:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d8b1a50ac619a403071e968bd9fbe9e0976b8b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/532/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/532/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/532/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/39f0fd1320a9b6c065113100b3a7875de937a6a0","head":{"label":"sveneh:build_enhancement","ref":"build_enhancement","sha":"39f0fd1320a9b6c065113100b3a7875de937a6a0","user":{"login":"sveneh","id":3418608,"avatar_url":"https://avatars.githubusercontent.com/u/3418608?v=3","gravatar_id":"","url":"https://api.github.com/users/sveneh","html_url":"https://github.com/sveneh","followers_url":"https://api.github.com/users/sveneh/followers","following_url":"https://api.github.com/users/sveneh/following{/other_user}","gists_url":"https://api.github.com/users/sveneh/gists{/gist_id}","starred_url":"https://api.github.com/users/sveneh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveneh/subscriptions","organizations_url":"https://api.github.com/users/sveneh/orgs","repos_url":"https://api.github.com/users/sveneh/repos","events_url":"https://api.github.com/users/sveneh/events{/privacy}","received_events_url":"https://api.github.com/users/sveneh/received_events","type":"User","site_admin":false},"repo":{"id":25030781,"name":"cpp-ethereum","full_name":"sveneh/cpp-ethereum","owner":{"login":"sveneh","id":3418608,"avatar_url":"https://avatars.githubusercontent.com/u/3418608?v=3","gravatar_id":"","url":"https://api.github.com/users/sveneh","html_url":"https://github.com/sveneh","followers_url":"https://api.github.com/users/sveneh/followers","following_url":"https://api.github.com/users/sveneh/following{/other_user}","gists_url":"https://api.github.com/users/sveneh/gists{/gist_id}","starred_url":"https://api.github.com/users/sveneh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveneh/subscriptions","organizations_url":"https://api.github.com/users/sveneh/orgs","repos_url":"https://api.github.com/users/sveneh/repos","events_url":"https://api.github.com/users/sveneh/events{/privacy}","received_events_url":"https://api.github.com/users/sveneh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sveneh/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":true,"url":"https://api.github.com/repos/sveneh/cpp-ethereum","forks_url":"https://api.github.com/repos/sveneh/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/sveneh/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sveneh/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sveneh/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/sveneh/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/sveneh/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/sveneh/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/sveneh/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/sveneh/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/sveneh/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/sveneh/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sveneh/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sveneh/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/sveneh/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sveneh/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/sveneh/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/sveneh/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/sveneh/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/sveneh/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/sveneh/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/sveneh/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/sveneh/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/sveneh/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/sveneh/cpp-ethereum/issues/comments/{number}","contents_url":"https://api.github.com/repos/sveneh/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/sveneh/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sveneh/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/sveneh/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sveneh/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/sveneh/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/sveneh/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/sveneh/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/sveneh/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sveneh/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/sveneh/cpp-ethereum/releases{/id}","created_at":"2014-10-10T10:22:37Z","updated_at":"2014-10-09T14:31:16Z","pushed_at":"2014-11-20T13:01:12Z","git_url":"git://github.com/sveneh/cpp-ethereum.git","ssh_url":"git@github.com:sveneh/cpp-ethereum.git","clone_url":"https://github.com/sveneh/cpp-ethereum.git","svn_url":"https://github.com/sveneh/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":7114,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"a01859b285bbf8fe47ffec9951a5482418708942","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments/{number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","created_at":"2013-12-26T21:26:06Z","updated_at":"2014-11-20T23:08:53Z","pushed_at":"2014-11-20T23:08:53Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":29280,"stargazers_count":341,"watchers_count":341,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":55,"forks":125,"open_issues":55,"watchers":341,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/532"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/532"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/532"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/532/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/532/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/532/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/39f0fd1320a9b6c065113100b3a7875de937a6a0"}}}}