GitHub PullRequestEvent at 2014-10-06 15:03:46
Repository: flashgg
Actor: sethzenz
Payload: {"action":"opened","number":60,"pull_request":{"url":"https://api.github.com/repos/cms-analysis/flashgg/pulls/60","id":22290203,"html_url":"https://github.com/cms-analysis/flashgg/pull/60","diff_url":"https://github.com/cms-analysis/flashgg/pull/60.diff","patch_url":"https://github.com/cms-analysis/flashgg/pull/60.patch","issue_url":"https://api.github.com/repos/cms-analysis/flashgg/issues/60","number":60,"state":"open","locked":false,"title":"New tag framework","user":{"login":"sethzenz","id":1654834,"avatar_url":"https://avatars.githubusercontent.com/u/1654834?v=2","gravatar_id":"","url":"https://api.github.com/users/sethzenz","html_url":"https://github.com/sethzenz","followers_url":"https://api.github.com/users/sethzenz/followers","following_url":"https://api.github.com/users/sethzenz/following{/other_user}","gists_url":"https://api.github.com/users/sethzenz/gists{/gist_id}","starred_url":"https://api.github.com/users/sethzenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethzenz/subscriptions","organizations_url":"https://api.github.com/users/sethzenz/orgs","repos_url":"https://api.github.com/users/sethzenz/repos","events_url":"https://api.github.com/users/sethzenz/events{/privacy}","received_events_url":"https://api.github.com/users/sethzenz/received_events","type":"User","site_admin":false},"body":"New tag framework described here: https://indico.cern.ch/event/343171/session/16/contribution/32/material/slides/0.pdf\r\n\r\nThe segfault described in the meeting above was due to existing code that had not crashed before, which is why it was a bit unpredictable.  It turns out that PhotonIdUtils::~PhotonIdUtils deleted 3 pointers, which by construction always pointed to only 2 objects.  Thus something was getting double-deleted, which can do bad things to memory.  This pull request includes a fix for this using std::shared_ptr, and everything now works.","created_at":"2014-10-06T15:03:45Z","updated_at":"2014-10-06T15:03:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cms-analysis/flashgg/pulls/60/commits","review_comments_url":"https://api.github.com/repos/cms-analysis/flashgg/pulls/60/comments","review_comment_url":"https://api.github.com/repos/cms-analysis/flashgg/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cms-analysis/flashgg/issues/60/comments","statuses_url":"https://api.github.com/repos/cms-analysis/flashgg/statuses/013abc9e7d01d7f1dad0e94b25c4ad8c88654215","head":{"label":"sethzenz:new_tag_framework","ref":"new_tag_framework","sha":"013abc9e7d01d7f1dad0e94b25c4ad8c88654215","user":{"login":"sethzenz","id":1654834,"avatar_url":"https://avatars.githubusercontent.com/u/1654834?v=2","gravatar_id":"","url":"https://api.github.com/users/sethzenz","html_url":"https://github.com/sethzenz","followers_url":"https://api.github.com/users/sethzenz/followers","following_url":"https://api.github.com/users/sethzenz/following{/other_user}","gists_url":"https://api.github.com/users/sethzenz/gists{/gist_id}","starred_url":"https://api.github.com/users/sethzenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethzenz/subscriptions","organizations_url":"https://api.github.com/users/sethzenz/orgs","repos_url":"https://api.github.com/users/sethzenz/repos","events_url":"https://api.github.com/users/sethzenz/events{/privacy}","received_events_url":"https://api.github.com/users/sethzenz/received_events","type":"User","site_admin":false},"repo":{"id":20297276,"name":"flashgg","full_name":"sethzenz/flashgg","owner":{"login":"sethzenz","id":1654834,"avatar_url":"https://avatars.githubusercontent.com/u/1654834?v=2","gravatar_id":"","url":"https://api.github.com/users/sethzenz","html_url":"https://github.com/sethzenz","followers_url":"https://api.github.com/users/sethzenz/followers","following_url":"https://api.github.com/users/sethzenz/following{/other_user}","gists_url":"https://api.github.com/users/sethzenz/gists{/gist_id}","starred_url":"https://api.github.com/users/sethzenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethzenz/subscriptions","organizations_url":"https://api.github.com/users/sethzenz/orgs","repos_url":"https://api.github.com/users/sethzenz/repos","events_url":"https://api.github.com/users/sethzenz/events{/privacy}","received_events_url":"https://api.github.com/users/sethzenz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sethzenz/flashgg","description":"","fork":true,"url":"https://api.github.com/repos/sethzenz/flashgg","forks_url":"https://api.github.com/repos/sethzenz/flashgg/forks","keys_url":"https://api.github.com/repos/sethzenz/flashgg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sethzenz/flashgg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sethzenz/flashgg/teams","hooks_url":"https://api.github.com/repos/sethzenz/flashgg/hooks","issue_events_url":"https://api.github.com/repos/sethzenz/flashgg/issues/events{/number}","events_url":"https://api.github.com/repos/sethzenz/flashgg/events","assignees_url":"https://api.github.com/repos/sethzenz/flashgg/assignees{/user}","branches_url":"https://api.github.com/repos/sethzenz/flashgg/branches{/branch}","tags_url":"https://api.github.com/repos/sethzenz/flashgg/tags","blobs_url":"https://api.github.com/repos/sethzenz/flashgg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sethzenz/flashgg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sethzenz/flashgg/git/refs{/sha}","trees_url":"https://api.github.com/repos/sethzenz/flashgg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sethzenz/flashgg/statuses/{sha}","languages_url":"https://api.github.com/repos/sethzenz/flashgg/languages","stargazers_url":"https://api.github.com/repos/sethzenz/flashgg/stargazers","contributors_url":"https://api.github.com/repos/sethzenz/flashgg/contributors","subscribers_url":"https://api.github.com/repos/sethzenz/flashgg/subscribers","subscription_url":"https://api.github.com/repos/sethzenz/flashgg/subscription","commits_url":"https://api.github.com/repos/sethzenz/flashgg/commits{/sha}","git_commits_url":"https://api.github.com/repos/sethzenz/flashgg/git/commits{/sha}","comments_url":"https://api.github.com/repos/sethzenz/flashgg/comments{/number}","issue_comment_url":"https://api.github.com/repos/sethzenz/flashgg/issues/comments/{number}","contents_url":"https://api.github.com/repos/sethzenz/flashgg/contents/{+path}","compare_url":"https://api.github.com/repos/sethzenz/flashgg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sethzenz/flashgg/merges","archive_url":"https://api.github.com/repos/sethzenz/flashgg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sethzenz/flashgg/downloads","issues_url":"https://api.github.com/repos/sethzenz/flashgg/issues{/number}","pulls_url":"https://api.github.com/repos/sethzenz/flashgg/pulls{/number}","milestones_url":"https://api.github.com/repos/sethzenz/flashgg/milestones{/number}","notifications_url":"https://api.github.com/repos/sethzenz/flashgg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sethzenz/flashgg/labels{/name}","releases_url":"https://api.github.com/repos/sethzenz/flashgg/releases{/id}","created_at":"2014-05-29T14:52:23Z","updated_at":"2014-07-14T17:16:33Z","pushed_at":"2014-10-06T14:57:31Z","git_url":"git://github.com/sethzenz/flashgg.git","ssh_url":"git@github.com:sethzenz/flashgg.git","clone_url":"https://github.com/sethzenz/flashgg.git","svn_url":"https://github.com/sethzenz/flashgg","homepage":null,"size":3107,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-analysis:master","ref":"master","sha":"abfa6ebe7031ac27ced80680d16c98c9104e9801","user":{"login":"cms-analysis","id":4680210,"avatar_url":"https://avatars.githubusercontent.com/u/4680210?v=2","gravatar_id":"","url":"https://api.github.com/users/cms-analysis","html_url":"https://github.com/cms-analysis","followers_url":"https://api.github.com/users/cms-analysis/followers","following_url":"https://api.github.com/users/cms-analysis/following{/other_user}","gists_url":"https://api.github.com/users/cms-analysis/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-analysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-analysis/subscriptions","organizations_url":"https://api.github.com/users/cms-analysis/orgs","repos_url":"https://api.github.com/users/cms-analysis/repos","events_url":"https://api.github.com/users/cms-analysis/events{/privacy}","received_events_url":"https://api.github.com/users/cms-analysis/received_events","type":"Organization","site_admin":false},"repo":{"id":20220358,"name":"flashgg","full_name":"cms-analysis/flashgg","owner":{"login":"cms-analysis","id":4680210,"avatar_url":"https://avatars.githubusercontent.com/u/4680210?v=2","gravatar_id":"","url":"https://api.github.com/users/cms-analysis","html_url":"https://github.com/cms-analysis","followers_url":"https://api.github.com/users/cms-analysis/followers","following_url":"https://api.github.com/users/cms-analysis/following{/other_user}","gists_url":"https://api.github.com/users/cms-analysis/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-analysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-analysis/subscriptions","organizations_url":"https://api.github.com/users/cms-analysis/orgs","repos_url":"https://api.github.com/users/cms-analysis/repos","events_url":"https://api.github.com/users/cms-analysis/events{/privacy}","received_events_url":"https://api.github.com/users/cms-analysis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-analysis/flashgg","description":"","fork":false,"url":"https://api.github.com/repos/cms-analysis/flashgg","forks_url":"https://api.github.com/repos/cms-analysis/flashgg/forks","keys_url":"https://api.github.com/repos/cms-analysis/flashgg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-analysis/flashgg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-analysis/flashgg/teams","hooks_url":"https://api.github.com/repos/cms-analysis/flashgg/hooks","issue_events_url":"https://api.github.com/repos/cms-analysis/flashgg/issues/events{/number}","events_url":"https://api.github.com/repos/cms-analysis/flashgg/events","assignees_url":"https://api.github.com/repos/cms-analysis/flashgg/assignees{/user}","branches_url":"https://api.github.com/repos/cms-analysis/flashgg/branches{/branch}","tags_url":"https://api.github.com/repos/cms-analysis/flashgg/tags","blobs_url":"https://api.github.com/repos/cms-analysis/flashgg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-analysis/flashgg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-analysis/flashgg/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-analysis/flashgg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-analysis/flashgg/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-analysis/flashgg/languages","stargazers_url":"https://api.github.com/repos/cms-analysis/flashgg/stargazers","contributors_url":"https://api.github.com/repos/cms-analysis/flashgg/contributors","subscribers_url":"https://api.github.com/repos/cms-analysis/flashgg/subscribers","subscription_url":"https://api.github.com/repos/cms-analysis/flashgg/subscription","commits_url":"https://api.github.com/repos/cms-analysis/flashgg/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-analysis/flashgg/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-analysis/flashgg/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-analysis/flashgg/issues/comments/{number}","contents_url":"https://api.github.com/repos/cms-analysis/flashgg/contents/{+path}","compare_url":"https://api.github.com/repos/cms-analysis/flashgg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-analysis/flashgg/merges","archive_url":"https://api.github.com/repos/cms-analysis/flashgg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-analysis/flashgg/downloads","issues_url":"https://api.github.com/repos/cms-analysis/flashgg/issues{/number}","pulls_url":"https://api.github.com/repos/cms-analysis/flashgg/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-analysis/flashgg/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-analysis/flashgg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-analysis/flashgg/labels{/name}","releases_url":"https://api.github.com/repos/cms-analysis/flashgg/releases{/id}","created_at":"2014-05-27T13:10:32Z","updated_at":"2014-09-04T08:37:54Z","pushed_at":"2014-09-30T22:15:07Z","git_url":"git://github.com/cms-analysis/flashgg.git","ssh_url":"git@github.com:cms-analysis/flashgg.git","clone_url":"https://github.com/cms-analysis/flashgg.git","svn_url":"https://github.com/cms-analysis/flashgg","homepage":"","size":3208,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":9,"forks":19,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-analysis/flashgg/pulls/60"},"html":{"href":"https://github.com/cms-analysis/flashgg/pull/60"},"issue":{"href":"https://api.github.com/repos/cms-analysis/flashgg/issues/60"},"comments":{"href":"https://api.github.com/repos/cms-analysis/flashgg/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-analysis/flashgg/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-analysis/flashgg/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cms-analysis/flashgg/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/cms-analysis/flashgg/statuses/013abc9e7d01d7f1dad0e94b25c4ad8c88654215"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":575,"deletions":40,"changed_files":24}}