GitHub PullRequestEvent at 2014-04-29 13:51:26
Repository: tinyobjloader
Actor: syoyo
Payload: {"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/syoyo/tinyobjloader/pulls/12","id":15263458,"html_url":"https://github.com/syoyo/tinyobjloader/pull/12","diff_url":"https://github.com/syoyo/tinyobjloader/pull/12.diff","patch_url":"https://github.com/syoyo/tinyobjloader/pull/12.patch","issue_url":"https://api.github.com/repos/syoyo/tinyobjloader/issues/12","number":12,"state":"closed","title":"Added a LoadObj function that reads from a std::istream.","user":{"login":"burnse","id":5459096,"avatar_url":"https://avatars.githubusercontent.com/u/5459096?","gravatar_id":"322cf45d122044cc605c616f6ab15975","url":"https://api.github.com/users/burnse","html_url":"https://github.com/burnse","followers_url":"https://api.github.com/users/burnse/followers","following_url":"https://api.github.com/users/burnse/following{/other_user}","gists_url":"https://api.github.com/users/burnse/gists{/gist_id}","starred_url":"https://api.github.com/users/burnse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burnse/subscriptions","organizations_url":"https://api.github.com/users/burnse/orgs","repos_url":"https://api.github.com/users/burnse/repos","events_url":"https://api.github.com/users/burnse/events{/privacy}","received_events_url":"https://api.github.com/users/burnse/received_events","type":"User","site_admin":false},"body":"The intention of these changes is to provide the ability to read obj files from a std::istream, or anything extending it.  This should be useful if you want to do something like reading objs from an archive or have generated data and can pass it as a stream.\r\n\r\n- The added version of LoadObj is similar to the existing one, but takes a std::function that is used within the LoadObj function to return a pointer to a std::istream for the specified material when 'mtllib' is parsed.  \r\n- LoadMtl was also modified to accept a std::istream.\r\n\r\n- Modified test.cc to load an object and material from a stringstream just as a very simple example.\r\n\r\n- The original LoadObj function still exists, so this change should not break any existing code.\r\n\r\n- Some C++11 features were used (function, auto, lambdas, unique_ptr), checked compilation of test.cc works using VS2012 (win), clang++ 3.4 (Ubuntu) and g++ 4.8.2 (Ubuntu).  Output looked fine.\r\n\r\nAny problems or changes required?\r\n\r\nThanks for this nice library!","created_at":"2014-04-28T22:08:40Z","updated_at":"2014-04-29T13:51:26Z","closed_at":"2014-04-29T13:51:26Z","merged_at":"2014-04-29T13:51:26Z","merge_commit_sha":"491de7295d32426b5f09b4db2eb9fccbafe5cbf4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/syoyo/tinyobjloader/pulls/12/commits","review_comments_url":"https://api.github.com/repos/syoyo/tinyobjloader/pulls/12/comments","review_comment_url":"https://api.github.com/repos/syoyo/tinyobjloader/pulls/comments/{number}","comments_url":"https://api.github.com/repos/syoyo/tinyobjloader/issues/12/comments","statuses_url":"https://api.github.com/repos/syoyo/tinyobjloader/statuses/b89a46c4176c64c596de3de2f54c39ad63b8d98c","head":{"label":"burnse:feature/StreamReader","ref":"feature/StreamReader","sha":"b89a46c4176c64c596de3de2f54c39ad63b8d98c","user":{"login":"burnse","id":5459096,"avatar_url":"https://avatars.githubusercontent.com/u/5459096?","gravatar_id":"322cf45d122044cc605c616f6ab15975","url":"https://api.github.com/users/burnse","html_url":"https://github.com/burnse","followers_url":"https://api.github.com/users/burnse/followers","following_url":"https://api.github.com/users/burnse/following{/other_user}","gists_url":"https://api.github.com/users/burnse/gists{/gist_id}","starred_url":"https://api.github.com/users/burnse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burnse/subscriptions","organizations_url":"https://api.github.com/users/burnse/orgs","repos_url":"https://api.github.com/users/burnse/repos","events_url":"https://api.github.com/users/burnse/events{/privacy}","received_events_url":"https://api.github.com/users/burnse/received_events","type":"User","site_admin":false},"repo":{"id":19234594,"name":"tinyobjloader","full_name":"burnse/tinyobjloader","owner":{"login":"burnse","id":5459096,"avatar_url":"https://avatars.githubusercontent.com/u/5459096?","gravatar_id":"322cf45d122044cc605c616f6ab15975","url":"https://api.github.com/users/burnse","html_url":"https://github.com/burnse","followers_url":"https://api.github.com/users/burnse/followers","following_url":"https://api.github.com/users/burnse/following{/other_user}","gists_url":"https://api.github.com/users/burnse/gists{/gist_id}","starred_url":"https://api.github.com/users/burnse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burnse/subscriptions","organizations_url":"https://api.github.com/users/burnse/orgs","repos_url":"https://api.github.com/users/burnse/repos","events_url":"https://api.github.com/users/burnse/events{/privacy}","received_events_url":"https://api.github.com/users/burnse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/burnse/tinyobjloader","description":"Tiny but powerful single file wavefront obj loader","fork":true,"url":"https://api.github.com/repos/burnse/tinyobjloader","forks_url":"https://api.github.com/repos/burnse/tinyobjloader/forks","keys_url":"https://api.github.com/repos/burnse/tinyobjloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burnse/tinyobjloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burnse/tinyobjloader/teams","hooks_url":"https://api.github.com/repos/burnse/tinyobjloader/hooks","issue_events_url":"https://api.github.com/repos/burnse/tinyobjloader/issues/events{/number}","events_url":"https://api.github.com/repos/burnse/tinyobjloader/events","assignees_url":"https://api.github.com/repos/burnse/tinyobjloader/assignees{/user}","branches_url":"https://api.github.com/repos/burnse/tinyobjloader/branches{/branch}","tags_url":"https://api.github.com/repos/burnse/tinyobjloader/tags","blobs_url":"https://api.github.com/repos/burnse/tinyobjloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burnse/tinyobjloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burnse/tinyobjloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/burnse/tinyobjloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burnse/tinyobjloader/statuses/{sha}","languages_url":"https://api.github.com/repos/burnse/tinyobjloader/languages","stargazers_url":"https://api.github.com/repos/burnse/tinyobjloader/stargazers","contributors_url":"https://api.github.com/repos/burnse/tinyobjloader/contributors","subscribers_url":"https://api.github.com/repos/burnse/tinyobjloader/subscribers","subscription_url":"https://api.github.com/repos/burnse/tinyobjloader/subscription","commits_url":"https://api.github.com/repos/burnse/tinyobjloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/burnse/tinyobjloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/burnse/tinyobjloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/burnse/tinyobjloader/issues/comments/{number}","contents_url":"https://api.github.com/repos/burnse/tinyobjloader/contents/{+path}","compare_url":"https://api.github.com/repos/burnse/tinyobjloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burnse/tinyobjloader/merges","archive_url":"https://api.github.com/repos/burnse/tinyobjloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burnse/tinyobjloader/downloads","issues_url":"https://api.github.com/repos/burnse/tinyobjloader/issues{/number}","pulls_url":"https://api.github.com/repos/burnse/tinyobjloader/pulls{/number}","milestones_url":"https://api.github.com/repos/burnse/tinyobjloader/milestones{/number}","notifications_url":"https://api.github.com/repos/burnse/tinyobjloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burnse/tinyobjloader/labels{/name}","releases_url":"https://api.github.com/repos/burnse/tinyobjloader/releases{/id}","created_at":"2014-04-28T10:09:29Z","updated_at":"2014-04-29T13:51:26Z","pushed_at":"2014-04-29T12:38:02Z","git_url":"git://github.com/burnse/tinyobjloader.git","ssh_url":"git@github.com:burnse/tinyobjloader.git","clone_url":"https://github.com/burnse/tinyobjloader.git","svn_url":"https://github.com/burnse/tinyobjloader","homepage":null,"size":600,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syoyo:master","ref":"master","sha":"c33b0cf6cc3b56dd0118f54c8b3209df72a274f7","user":{"login":"syoyo","id":18676,"avatar_url":"https://avatars.githubusercontent.com/u/18676?","gravatar_id":"4fa52bafd296cebb0c4465a9e8d04860","url":"https://api.github.com/users/syoyo","html_url":"https://github.com/syoyo","followers_url":"https://api.github.com/users/syoyo/followers","following_url":"https://api.github.com/users/syoyo/following{/other_user}","gists_url":"https://api.github.com/users/syoyo/gists{/gist_id}","starred_url":"https://api.github.com/users/syoyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syoyo/subscriptions","organizations_url":"https://api.github.com/users/syoyo/orgs","repos_url":"https://api.github.com/users/syoyo/repos","events_url":"https://api.github.com/users/syoyo/events{/privacy}","received_events_url":"https://api.github.com/users/syoyo/received_events","type":"User","site_admin":false},"repo":{"id":5421296,"name":"tinyobjloader","full_name":"syoyo/tinyobjloader","owner":{"login":"syoyo","id":18676,"avatar_url":"https://avatars.githubusercontent.com/u/18676?","gravatar_id":"4fa52bafd296cebb0c4465a9e8d04860","url":"https://api.github.com/users/syoyo","html_url":"https://github.com/syoyo","followers_url":"https://api.github.com/users/syoyo/followers","following_url":"https://api.github.com/users/syoyo/following{/other_user}","gists_url":"https://api.github.com/users/syoyo/gists{/gist_id}","starred_url":"https://api.github.com/users/syoyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syoyo/subscriptions","organizations_url":"https://api.github.com/users/syoyo/orgs","repos_url":"https://api.github.com/users/syoyo/repos","events_url":"https://api.github.com/users/syoyo/events{/privacy}","received_events_url":"https://api.github.com/users/syoyo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syoyo/tinyobjloader","description":"Tiny but powerful single file wavefront obj loader","fork":false,"url":"https://api.github.com/repos/syoyo/tinyobjloader","forks_url":"https://api.github.com/repos/syoyo/tinyobjloader/forks","keys_url":"https://api.github.com/repos/syoyo/tinyobjloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syoyo/tinyobjloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syoyo/tinyobjloader/teams","hooks_url":"https://api.github.com/repos/syoyo/tinyobjloader/hooks","issue_events_url":"https://api.github.com/repos/syoyo/tinyobjloader/issues/events{/number}","events_url":"https://api.github.com/repos/syoyo/tinyobjloader/events","assignees_url":"https://api.github.com/repos/syoyo/tinyobjloader/assignees{/user}","branches_url":"https://api.github.com/repos/syoyo/tinyobjloader/branches{/branch}","tags_url":"https://api.github.com/repos/syoyo/tinyobjloader/tags","blobs_url":"https://api.github.com/repos/syoyo/tinyobjloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syoyo/tinyobjloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syoyo/tinyobjloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/syoyo/tinyobjloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syoyo/tinyobjloader/statuses/{sha}","languages_url":"https://api.github.com/repos/syoyo/tinyobjloader/languages","stargazers_url":"https://api.github.com/repos/syoyo/tinyobjloader/stargazers","contributors_url":"https://api.github.com/repos/syoyo/tinyobjloader/contributors","subscribers_url":"https://api.github.com/repos/syoyo/tinyobjloader/subscribers","subscription_url":"https://api.github.com/repos/syoyo/tinyobjloader/subscription","commits_url":"https://api.github.com/repos/syoyo/tinyobjloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/syoyo/tinyobjloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/syoyo/tinyobjloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/syoyo/tinyobjloader/issues/comments/{number}","contents_url":"https://api.github.com/repos/syoyo/tinyobjloader/contents/{+path}","compare_url":"https://api.github.com/repos/syoyo/tinyobjloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syoyo/tinyobjloader/merges","archive_url":"https://api.github.com/repos/syoyo/tinyobjloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syoyo/tinyobjloader/downloads","issues_url":"https://api.github.com/repos/syoyo/tinyobjloader/issues{/number}","pulls_url":"https://api.github.com/repos/syoyo/tinyobjloader/pulls{/number}","milestones_url":"https://api.github.com/repos/syoyo/tinyobjloader/milestones{/number}","notifications_url":"https://api.github.com/repos/syoyo/tinyobjloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syoyo/tinyobjloader/labels{/name}","releases_url":"https://api.github.com/repos/syoyo/tinyobjloader/releases{/id}","created_at":"2012-08-15T02:44:30Z","updated_at":"2014-04-29T09:01:36Z","pushed_at":"2014-04-29T13:51:26Z","git_url":"git://github.com/syoyo/tinyobjloader.git","ssh_url":"git@github.com:syoyo/tinyobjloader.git","clone_url":"https://github.com/syoyo/tinyobjloader.git","svn_url":"https://github.com/syoyo/tinyobjloader","homepage":null,"size":777,"stargazers_count":61,"watchers_count":61,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":25,"mirror_url":null,"open_issues_count":3,"forks":25,"open_issues":3,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syoyo/tinyobjloader/pulls/12"},"html":{"href":"https://github.com/syoyo/tinyobjloader/pull/12"},"issue":{"href":"https://api.github.com/repos/syoyo/tinyobjloader/issues/12"},"comments":{"href":"https://api.github.com/repos/syoyo/tinyobjloader/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/syoyo/tinyobjloader/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/syoyo/tinyobjloader/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/syoyo/tinyobjloader/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/syoyo/tinyobjloader/statuses/b89a46c4176c64c596de3de2f54c39ad63b8d98c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"syoyo","id":18676,"avatar_url":"https://avatars.githubusercontent.com/u/18676?","gravatar_id":"4fa52bafd296cebb0c4465a9e8d04860","url":"https://api.github.com/users/syoyo","html_url":"https://github.com/syoyo","followers_url":"https://api.github.com/users/syoyo/followers","following_url":"https://api.github.com/users/syoyo/following{/other_user}","gists_url":"https://api.github.com/users/syoyo/gists{/gist_id}","starred_url":"https://api.github.com/users/syoyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syoyo/subscriptions","organizations_url":"https://api.github.com/users/syoyo/orgs","repos_url":"https://api.github.com/users/syoyo/repos","events_url":"https://api.github.com/users/syoyo/events{/privacy}","received_events_url":"https://api.github.com/users/syoyo/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":2,"additions":201,"deletions":40,"changed_files":3}}