GitHub PullRequestReviewCommentEvent at 2014-04-16 05:58:05
Repository: sea-c10-rubyonrails
Actor: aqlien
Payload: {"comment":{"url":"https://api.github.com/repos/codefellows/sea-c10-rubyonrails/pulls/comments/11670869","id":11670869,"diff_hunk":"@@ -0,0 +1,44 @@\n+#Author: Alex Lien\r\n+\r\n+class Calculator\r\n+\r\n+#return sum of an array\r\n+  def sum(array)\r\n+    count = 0\r\n+    for n in array\r\n+      count += n\r\n+    end\r\n+    return count\r","path":"week2_homework/calculator.rb","position":11,"original_position":11,"commit_id":"9f0bfd6495b7b3b5197fa7bd4eacd8a3931b001d","original_commit_id":"9f0bfd6495b7b3b5197fa7bd4eacd8a3931b001d","user":{"login":"aqlien","id":6765180,"avatar_url":"https://avatars.githubusercontent.com/u/6765180?","gravatar_id":"227922bdcf7048b47c8890da263bb4af","url":"https://api.github.com/users/aqlien","html_url":"https://github.com/aqlien","followers_url":"https://api.github.com/users/aqlien/followers","following_url":"https://api.github.com/users/aqlien/following{/other_user}","gists_url":"https://api.github.com/users/aqlien/gists{/gist_id}","starred_url":"https://api.github.com/users/aqlien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqlien/subscriptions","organizations_url":"https://api.github.com/users/aqlien/orgs","repos_url":"https://api.github.com/users/aqlien/repos","events_url":"https://api.github.com/users/aqlien/events{/privacy}","received_events_url":"https://api.github.com/users/aqlien/received_events","type":"User","site_admin":false},"body":"I know it's not strictly necessary, but I think it makes the code significantly more human-readable to state the return explicitly. Is it a huge performance hit or other issue if I keep doing it?","created_at":"2014-04-16T05:58:05Z","updated_at":"2014-04-16T05:58:05Z","html_url":"https://github.com/codefellows/sea-c10-rubyonrails/pull/14#discussion_r11670869","pull_request_url":"https://api.github.com/repos/codefellows/sea-c10-rubyonrails/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/codefellows/sea-c10-rubyonrails/pulls/comments/11670869"},"html":{"href":"https://github.com/codefellows/sea-c10-rubyonrails/pull/14#discussion_r11670869"},"pull_request":{"href":"https://api.github.com/repos/codefellows/sea-c10-rubyonrails/pulls/14"}}}}