GitHub PullRequestReviewCommentEvent at 2014-11-18 04:11:10
Repository: modular_has_many
Actor: kgentner
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/kgentner/modular_has_many/pulls/comments/20484828","id":20484828,"diff_hunk":"@@ -0,0 +1,11 @@\n+'use strict';\n+var mongoose = require('mongoose');\n+var Schema = mongoose.Schema;\n+\n+var studentSchema = new Schema({\n+  name: String,\n+  courses: [{ type: Schema.Types.ObjectId, ref: 'Course' }]\n+});\n+//\n+var Student = mongoose.model('Student', studentSchema);","path":"models/student.js","position":10,"original_position":10,"commit_id":"8e62e09a218fd36169eb36224798a21f97c0ddda","original_commit_id":"8e62e09a218fd36169eb36224798a21f97c0ddda","user":{"login":"kgentner","id":6963901,"avatar_url":"https://avatars.githubusercontent.com/u/6963901?v=3","gravatar_id":"","url":"https://api.github.com/users/kgentner","html_url":"https://github.com/kgentner","followers_url":"https://api.github.com/users/kgentner/followers","following_url":"https://api.github.com/users/kgentner/following{/other_user}","gists_url":"https://api.github.com/users/kgentner/gists{/gist_id}","starred_url":"https://api.github.com/users/kgentner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgentner/subscriptions","organizations_url":"https://api.github.com/users/kgentner/orgs","repos_url":"https://api.github.com/users/kgentner/repos","events_url":"https://api.github.com/users/kgentner/events{/privacy}","received_events_url":"https://api.github.com/users/kgentner/received_events","type":"User","site_admin":false},"body":"Yep - jshint max line length is 80. What's the preferable way to do this?\r\n\r\n```var studentSchema = new Schema({name: String, courses:\r\n  [{type: Schema.Types.ObjectId, ref: 'Course' }]});\r\n```\r\n\r\n(OR)\r\n\r\n```var studentSchema = new Schema({\r\n  name: String, courses: [{type: Schema.Types.ObjectId, ref: 'Course' }]\r\n});\r\n```\r\n","created_at":"2014-11-18T04:11:10Z","updated_at":"2014-11-18T04:11:10Z","html_url":"https://github.com/kgentner/modular_has_many/pull/1#discussion_r20484828","pull_request_url":"https://api.github.com/repos/kgentner/modular_has_many/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/kgentner/modular_has_many/pulls/comments/20484828"},"html":{"href":"https://github.com/kgentner/modular_has_many/pull/1#discussion_r20484828"},"pull_request":{"href":"https://api.github.com/repos/kgentner/modular_has_many/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/kgentner/modular_has_many/pulls/1","id":24261324,"html_url":"https://github.com/kgentner/modular_has_many/pull/1","diff_url":"https://github.com/kgentner/modular_has_many/pull/1.diff","patch_url":"https://github.com/kgentner/modular_has_many/pull/1.patch","issue_url":"https://api.github.com/repos/kgentner/modular_has_many/issues/1","number":1,"state":"open","locked":false,"title":"Modular JS Assignment - Submittal","user":{"login":"kgentner","id":6963901,"avatar_url":"https://avatars.githubusercontent.com/u/6963901?v=3","gravatar_id":"","url":"https://api.github.com/users/kgentner","html_url":"https://github.com/kgentner","followers_url":"https://api.github.com/users/kgentner/followers","following_url":"https://api.github.com/users/kgentner/following{/other_user}","gists_url":"https://api.github.com/users/kgentner/gists{/gist_id}","starred_url":"https://api.github.com/users/kgentner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgentner/subscriptions","organizations_url":"https://api.github.com/users/kgentner/orgs","repos_url":"https://api.github.com/users/kgentner/repos","events_url":"https://api.github.com/users/kgentner/events{/privacy}","received_events_url":"https://api.github.com/users/kgentner/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-12T00:17:28Z","updated_at":"2014-11-18T04:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c991ece168b8884e571c7fe5528d83c0a2757a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kgentner/modular_has_many/pulls/1/commits","review_comments_url":"https://api.github.com/repos/kgentner/modular_has_many/pulls/1/comments","review_comment_url":"https://api.github.com/repos/kgentner/modular_has_many/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kgentner/modular_has_many/issues/1/comments","statuses_url":"https://api.github.com/repos/kgentner/modular_has_many/statuses/8e62e09a218fd36169eb36224798a21f97c0ddda","head":{"label":"kgentner:karlg","ref":"karlg","sha":"8e62e09a218fd36169eb36224798a21f97c0ddda","user":{"login":"kgentner","id":6963901,"avatar_url":"https://avatars.githubusercontent.com/u/6963901?v=3","gravatar_id":"","url":"https://api.github.com/users/kgentner","html_url":"https://github.com/kgentner","followers_url":"https://api.github.com/users/kgentner/followers","following_url":"https://api.github.com/users/kgentner/following{/other_user}","gists_url":"https://api.github.com/users/kgentner/gists{/gist_id}","starred_url":"https://api.github.com/users/kgentner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgentner/subscriptions","organizations_url":"https://api.github.com/users/kgentner/orgs","repos_url":"https://api.github.com/users/kgentner/repos","events_url":"https://api.github.com/users/kgentner/events{/privacy}","received_events_url":"https://api.github.com/users/kgentner/received_events","type":"User","site_admin":false},"repo":{"id":26427046,"name":"modular_has_many","full_name":"kgentner/modular_has_many","owner":{"login":"kgentner","id":6963901,"avatar_url":"https://avatars.githubusercontent.com/u/6963901?v=3","gravatar_id":"","url":"https://api.github.com/users/kgentner","html_url":"https://github.com/kgentner","followers_url":"https://api.github.com/users/kgentner/followers","following_url":"https://api.github.com/users/kgentner/following{/other_user}","gists_url":"https://api.github.com/users/kgentner/gists{/gist_id}","starred_url":"https://api.github.com/users/kgentner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgentner/subscriptions","organizations_url":"https://api.github.com/users/kgentner/orgs","repos_url":"https://api.github.com/users/kgentner/repos","events_url":"https://api.github.com/users/kgentner/events{/privacy}","received_events_url":"https://api.github.com/users/kgentner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kgentner/modular_has_many","description":"","fork":false,"url":"https://api.github.com/repos/kgentner/modular_has_many","forks_url":"https://api.github.com/repos/kgentner/modular_has_many/forks","keys_url":"https://api.github.com/repos/kgentner/modular_has_many/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kgentner/modular_has_many/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kgentner/modular_has_many/teams","hooks_url":"https://api.github.com/repos/kgentner/modular_has_many/hooks","issue_events_url":"https://api.github.com/repos/kgentner/modular_has_many/issues/events{/number}","events_url":"https://api.github.com/repos/kgentner/modular_has_many/events","assignees_url":"https://api.github.com/repos/kgentner/modular_has_many/assignees{/user}","branches_url":"https://api.github.com/repos/kgentner/modular_has_many/branches{/branch}","tags_url":"https://api.github.com/repos/kgentner/modular_has_many/tags","blobs_url":"https://api.github.com/repos/kgentner/modular_has_many/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kgentner/modular_has_many/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kgentner/modular_has_many/git/refs{/sha}","trees_url":"https://api.github.com/repos/kgentner/modular_has_many/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kgentner/modular_has_many/statuses/{sha}","languages_url":"https://api.github.com/repos/kgentner/modular_has_many/languages","stargazers_url":"https://api.github.com/repos/kgentner/modular_has_many/stargazers","contributors_url":"https://api.github.com/repos/kgentner/modular_has_many/contributors","subscribers_url":"https://api.github.com/repos/kgentner/modular_has_many/subscribers","subscription_url":"https://api.github.com/repos/kgentner/modular_has_many/subscription","commits_url":"https://api.github.com/repos/kgentner/modular_has_many/commits{/sha}","git_commits_url":"https://api.github.com/repos/kgentner/modular_has_many/git/commits{/sha}","comments_url":"https://api.github.com/repos/kgentner/modular_has_many/comments{/number}","issue_comment_url":"https://api.github.com/repos/kgentner/modular_has_many/issues/comments/{number}","contents_url":"https://api.github.com/repos/kgentner/modular_has_many/contents/{+path}","compare_url":"https://api.github.com/repos/kgentner/modular_has_many/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kgentner/modular_has_many/merges","archive_url":"https://api.github.com/repos/kgentner/modular_has_many/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kgentner/modular_has_many/downloads","issues_url":"https://api.github.com/repos/kgentner/modular_has_many/issues{/number}","pulls_url":"https://api.github.com/repos/kgentner/modular_has_many/pulls{/number}","milestones_url":"https://api.github.com/repos/kgentner/modular_has_many/milestones{/number}","notifications_url":"https://api.github.com/repos/kgentner/modular_has_many/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kgentner/modular_has_many/labels{/name}","releases_url":"https://api.github.com/repos/kgentner/modular_has_many/releases{/id}","created_at":"2014-11-10T08:11:00Z","updated_at":"2014-11-10T08:11:00Z","pushed_at":"2014-11-12T00:15:04Z","git_url":"git://github.com/kgentner/modular_has_many.git","ssh_url":"git@github.com:kgentner/modular_has_many.git","clone_url":"https://github.com/kgentner/modular_has_many.git","svn_url":"https://github.com/kgentner/modular_has_many","homepage":null,"size":152,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kgentner:master","ref":"master","sha":"65c1c9d9d573a860556a91e063464793f2d29390","user":{"login":"kgentner","id":6963901,"avatar_url":"https://avatars.githubusercontent.com/u/6963901?v=3","gravatar_id":"","url":"https://api.github.com/users/kgentner","html_url":"https://github.com/kgentner","followers_url":"https://api.github.com/users/kgentner/followers","following_url":"https://api.github.com/users/kgentner/following{/other_user}","gists_url":"https://api.github.com/users/kgentner/gists{/gist_id}","starred_url":"https://api.github.com/users/kgentner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgentner/subscriptions","organizations_url":"https://api.github.com/users/kgentner/orgs","repos_url":"https://api.github.com/users/kgentner/repos","events_url":"https://api.github.com/users/kgentner/events{/privacy}","received_events_url":"https://api.github.com/users/kgentner/received_events","type":"User","site_admin":false},"repo":{"id":26427046,"name":"modular_has_many","full_name":"kgentner/modular_has_many","owner":{"login":"kgentner","id":6963901,"avatar_url":"https://avatars.githubusercontent.com/u/6963901?v=3","gravatar_id":"","url":"https://api.github.com/users/kgentner","html_url":"https://github.com/kgentner","followers_url":"https://api.github.com/users/kgentner/followers","following_url":"https://api.github.com/users/kgentner/following{/other_user}","gists_url":"https://api.github.com/users/kgentner/gists{/gist_id}","starred_url":"https://api.github.com/users/kgentner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgentner/subscriptions","organizations_url":"https://api.github.com/users/kgentner/orgs","repos_url":"https://api.github.com/users/kgentner/repos","events_url":"https://api.github.com/users/kgentner/events{/privacy}","received_events_url":"https://api.github.com/users/kgentner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kgentner/modular_has_many","description":"","fork":false,"url":"https://api.github.com/repos/kgentner/modular_has_many","forks_url":"https://api.github.com/repos/kgentner/modular_has_many/forks","keys_url":"https://api.github.com/repos/kgentner/modular_has_many/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kgentner/modular_has_many/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kgentner/modular_has_many/teams","hooks_url":"https://api.github.com/repos/kgentner/modular_has_many/hooks","issue_events_url":"https://api.github.com/repos/kgentner/modular_has_many/issues/events{/number}","events_url":"https://api.github.com/repos/kgentner/modular_has_many/events","assignees_url":"https://api.github.com/repos/kgentner/modular_has_many/assignees{/user}","branches_url":"https://api.github.com/repos/kgentner/modular_has_many/branches{/branch}","tags_url":"https://api.github.com/repos/kgentner/modular_has_many/tags","blobs_url":"https://api.github.com/repos/kgentner/modular_has_many/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kgentner/modular_has_many/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kgentner/modular_has_many/git/refs{/sha}","trees_url":"https://api.github.com/repos/kgentner/modular_has_many/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kgentner/modular_has_many/statuses/{sha}","languages_url":"https://api.github.com/repos/kgentner/modular_has_many/languages","stargazers_url":"https://api.github.com/repos/kgentner/modular_has_many/stargazers","contributors_url":"https://api.github.com/repos/kgentner/modular_has_many/contributors","subscribers_url":"https://api.github.com/repos/kgentner/modular_has_many/subscribers","subscription_url":"https://api.github.com/repos/kgentner/modular_has_many/subscription","commits_url":"https://api.github.com/repos/kgentner/modular_has_many/commits{/sha}","git_commits_url":"https://api.github.com/repos/kgentner/modular_has_many/git/commits{/sha}","comments_url":"https://api.github.com/repos/kgentner/modular_has_many/comments{/number}","issue_comment_url":"https://api.github.com/repos/kgentner/modular_has_many/issues/comments/{number}","contents_url":"https://api.github.com/repos/kgentner/modular_has_many/contents/{+path}","compare_url":"https://api.github.com/repos/kgentner/modular_has_many/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kgentner/modular_has_many/merges","archive_url":"https://api.github.com/repos/kgentner/modular_has_many/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kgentner/modular_has_many/downloads","issues_url":"https://api.github.com/repos/kgentner/modular_has_many/issues{/number}","pulls_url":"https://api.github.com/repos/kgentner/modular_has_many/pulls{/number}","milestones_url":"https://api.github.com/repos/kgentner/modular_has_many/milestones{/number}","notifications_url":"https://api.github.com/repos/kgentner/modular_has_many/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kgentner/modular_has_many/labels{/name}","releases_url":"https://api.github.com/repos/kgentner/modular_has_many/releases{/id}","created_at":"2014-11-10T08:11:00Z","updated_at":"2014-11-10T08:11:00Z","pushed_at":"2014-11-12T00:15:04Z","git_url":"git://github.com/kgentner/modular_has_many.git","ssh_url":"git@github.com:kgentner/modular_has_many.git","clone_url":"https://github.com/kgentner/modular_has_many.git","svn_url":"https://github.com/kgentner/modular_has_many","homepage":null,"size":152,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kgentner/modular_has_many/pulls/1"},"html":{"href":"https://github.com/kgentner/modular_has_many/pull/1"},"issue":{"href":"https://api.github.com/repos/kgentner/modular_has_many/issues/1"},"comments":{"href":"https://api.github.com/repos/kgentner/modular_has_many/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/kgentner/modular_has_many/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/kgentner/modular_has_many/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kgentner/modular_has_many/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/kgentner/modular_has_many/statuses/8e62e09a218fd36169eb36224798a21f97c0ddda"}}}}