GitHub PullRequestReviewCommentEvent at 2014-08-14 22:18:48
Repository: gitlabhq
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/16270378","id":16270378,"diff_hunk":"@@ -96,10 +97,17 @@ class Users < Grape::API\n \n         admin = attrs.delete(:admin)\n         user.admin = admin unless admin.nil?\n+\n+        conflict!('Email has already been taken') if attrs[:email] && User.where(:email => attrs[:email])\n+        .where.not(:id => user.id).count > 0\n+\n+        conflict!('Username has already been taken') if attrs[:username] && User.where(:username => attrs[:username])","path":"lib/api/users.rb","position":27,"original_position":27,"commit_id":"9111c924a844269383a90465f5dd403b9a6beecf","original_commit_id":"9111c924a844269383a90465f5dd403b9a6beecf","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Use the new Ruby 1.9 hash syntax.<br>Line is too long. [117/80]","created_at":"2014-08-14T22:18:48Z","updated_at":"2014-08-14T22:18:48Z","html_url":"https://github.com/gitlabhq/gitlabhq/pull/7502#discussion_r16270378","pull_request_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7502","_links":{"self":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/16270378"},"html":{"href":"https://github.com/gitlabhq/gitlabhq/pull/7502#discussion_r16270378"},"pull_request":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7502"}}},"pull_request":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7502","id":19818419,"html_url":"https://github.com/gitlabhq/gitlabhq/pull/7502","diff_url":"https://github.com/gitlabhq/gitlabhq/pull/7502.diff","patch_url":"https://github.com/gitlabhq/gitlabhq/pull/7502.patch","issue_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7502","number":7502,"state":"open","locked":false,"title":"API: Improve error reporting","user":{"login":"jubianchi","id":327237,"avatar_url":"https://avatars.githubusercontent.com/u/327237?v=2","gravatar_id":"f46b6942be65359575174569d8979223","url":"https://api.github.com/users/jubianchi","html_url":"https://github.com/jubianchi","followers_url":"https://api.github.com/users/jubianchi/followers","following_url":"https://api.github.com/users/jubianchi/following{/other_user}","gists_url":"https://api.github.com/users/jubianchi/gists{/gist_id}","starred_url":"https://api.github.com/users/jubianchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jubianchi/subscriptions","organizations_url":"https://api.github.com/users/jubianchi/orgs","repos_url":"https://api.github.com/users/jubianchi/repos","events_url":"https://api.github.com/users/jubianchi/events{/privacy}","received_events_url":"https://api.github.com/users/jubianchi/received_events","type":"User","site_admin":false},"body":"This patch improves API errors messages thus fixing some issues (#6878, #3526, #4209, #5335).\r\n\r\n`404` statuses have been replaced by omre precise ones:\r\n* `409` when there is a conflict\r\n* `400` when a validation problem occurs\r\n\r\nValidation errors are also exposed in API responses.","created_at":"2014-08-14T22:05:38Z","updated_at":"2014-08-14T22:18:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"350f43489099035f748b437e8a0ef0baf5319763","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7502/commits","review_comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7502/comments","review_comment_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7502/comments","statuses_url":"https://api.github.com/repos/gitlabhq/gitlabhq/statuses/9111c924a844269383a90465f5dd403b9a6beecf","head":{"label":"jubianchi:api/improve-error-reporting","ref":"api/improve-error-reporting","sha":"9111c924a844269383a90465f5dd403b9a6beecf","user":{"login":"jubianchi","id":327237,"avatar_url":"https://avatars.githubusercontent.com/u/327237?v=2","gravatar_id":"f46b6942be65359575174569d8979223","url":"https://api.github.com/users/jubianchi","html_url":"https://github.com/jubianchi","followers_url":"https://api.github.com/users/jubianchi/followers","following_url":"https://api.github.com/users/jubianchi/following{/other_user}","gists_url":"https://api.github.com/users/jubianchi/gists{/gist_id}","starred_url":"https://api.github.com/users/jubianchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jubianchi/subscriptions","organizations_url":"https://api.github.com/users/jubianchi/orgs","repos_url":"https://api.github.com/users/jubianchi/repos","events_url":"https://api.github.com/users/jubianchi/events{/privacy}","received_events_url":"https://api.github.com/users/jubianchi/received_events","type":"User","site_admin":false},"repo":{"id":22969548,"name":"gitlabhq","full_name":"jubianchi/gitlabhq","owner":{"login":"jubianchi","id":327237,"avatar_url":"https://avatars.githubusercontent.com/u/327237?v=2","gravatar_id":"f46b6942be65359575174569d8979223","url":"https://api.github.com/users/jubianchi","html_url":"https://github.com/jubianchi","followers_url":"https://api.github.com/users/jubianchi/followers","following_url":"https://api.github.com/users/jubianchi/following{/other_user}","gists_url":"https://api.github.com/users/jubianchi/gists{/gist_id}","starred_url":"https://api.github.com/users/jubianchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jubianchi/subscriptions","organizations_url":"https://api.github.com/users/jubianchi/orgs","repos_url":"https://api.github.com/users/jubianchi/repos","events_url":"https://api.github.com/users/jubianchi/events{/privacy}","received_events_url":"https://api.github.com/users/jubianchi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jubianchi/gitlabhq","description":"Open source software to collaborate on code. Follow us on twitter @gitlabhq","fork":true,"url":"https://api.github.com/repos/jubianchi/gitlabhq","forks_url":"https://api.github.com/repos/jubianchi/gitlabhq/forks","keys_url":"https://api.github.com/repos/jubianchi/gitlabhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jubianchi/gitlabhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jubianchi/gitlabhq/teams","hooks_url":"https://api.github.com/repos/jubianchi/gitlabhq/hooks","issue_events_url":"https://api.github.com/repos/jubianchi/gitlabhq/issues/events{/number}","events_url":"https://api.github.com/repos/jubianchi/gitlabhq/events","assignees_url":"https://api.github.com/repos/jubianchi/gitlabhq/assignees{/user}","branches_url":"https://api.github.com/repos/jubianchi/gitlabhq/branches{/branch}","tags_url":"https://api.github.com/repos/jubianchi/gitlabhq/tags","blobs_url":"https://api.github.com/repos/jubianchi/gitlabhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jubianchi/gitlabhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jubianchi/gitlabhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/jubianchi/gitlabhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jubianchi/gitlabhq/statuses/{sha}","languages_url":"https://api.github.com/repos/jubianchi/gitlabhq/languages","stargazers_url":"https://api.github.com/repos/jubianchi/gitlabhq/stargazers","contributors_url":"https://api.github.com/repos/jubianchi/gitlabhq/contributors","subscribers_url":"https://api.github.com/repos/jubianchi/gitlabhq/subscribers","subscription_url":"https://api.github.com/repos/jubianchi/gitlabhq/subscription","commits_url":"https://api.github.com/repos/jubianchi/gitlabhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/jubianchi/gitlabhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/jubianchi/gitlabhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/jubianchi/gitlabhq/issues/comments/{number}","contents_url":"https://api.github.com/repos/jubianchi/gitlabhq/contents/{+path}","compare_url":"https://api.github.com/repos/jubianchi/gitlabhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jubianchi/gitlabhq/merges","archive_url":"https://api.github.com/repos/jubianchi/gitlabhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jubianchi/gitlabhq/downloads","issues_url":"https://api.github.com/repos/jubianchi/gitlabhq/issues{/number}","pulls_url":"https://api.github.com/repos/jubianchi/gitlabhq/pulls{/number}","milestones_url":"https://api.github.com/repos/jubianchi/gitlabhq/milestones{/number}","notifications_url":"https://api.github.com/repos/jubianchi/gitlabhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jubianchi/gitlabhq/labels{/name}","releases_url":"https://api.github.com/repos/jubianchi/gitlabhq/releases{/id}","created_at":"2014-08-14T21:40:52Z","updated_at":"2014-08-14T21:03:11Z","pushed_at":"2014-08-14T22:18:41Z","git_url":"git://github.com/jubianchi/gitlabhq.git","ssh_url":"git@github.com:jubianchi/gitlabhq.git","clone_url":"https://github.com/jubianchi/gitlabhq.git","svn_url":"https://github.com/jubianchi/gitlabhq","homepage":"https://about.gitlab.com/","size":140175,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gitlabhq:master","ref":"master","sha":"45da59daab5878eb20adc402fbd9c9f44407ed75","user":{"login":"gitlabhq","id":1086321,"avatar_url":"https://avatars.githubusercontent.com/u/1086321?v=2","gravatar_id":"95b7f387358639ec09184a76151bc690","url":"https://api.github.com/users/gitlabhq","html_url":"https://github.com/gitlabhq","followers_url":"https://api.github.com/users/gitlabhq/followers","following_url":"https://api.github.com/users/gitlabhq/following{/other_user}","gists_url":"https://api.github.com/users/gitlabhq/gists{/gist_id}","starred_url":"https://api.github.com/users/gitlabhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitlabhq/subscriptions","organizations_url":"https://api.github.com/users/gitlabhq/orgs","repos_url":"https://api.github.com/users/gitlabhq/repos","events_url":"https://api.github.com/users/gitlabhq/events{/privacy}","received_events_url":"https://api.github.com/users/gitlabhq/received_events","type":"Organization","site_admin":false},"repo":{"id":2500088,"name":"gitlabhq","full_name":"gitlabhq/gitlabhq","owner":{"login":"gitlabhq","id":1086321,"avatar_url":"https://avatars.githubusercontent.com/u/1086321?v=2","gravatar_id":"95b7f387358639ec09184a76151bc690","url":"https://api.github.com/users/gitlabhq","html_url":"https://github.com/gitlabhq","followers_url":"https://api.github.com/users/gitlabhq/followers","following_url":"https://api.github.com/users/gitlabhq/following{/other_user}","gists_url":"https://api.github.com/users/gitlabhq/gists{/gist_id}","starred_url":"https://api.github.com/users/gitlabhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitlabhq/subscriptions","organizations_url":"https://api.github.com/users/gitlabhq/orgs","repos_url":"https://api.github.com/users/gitlabhq/repos","events_url":"https://api.github.com/users/gitlabhq/events{/privacy}","received_events_url":"https://api.github.com/users/gitlabhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gitlabhq/gitlabhq","description":"Open source software to collaborate on code. Follow us on twitter @gitlabhq","fork":false,"url":"https://api.github.com/repos/gitlabhq/gitlabhq","forks_url":"https://api.github.com/repos/gitlabhq/gitlabhq/forks","keys_url":"https://api.github.com/repos/gitlabhq/gitlabhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitlabhq/gitlabhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitlabhq/gitlabhq/teams","hooks_url":"https://api.github.com/repos/gitlabhq/gitlabhq/hooks","issue_events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/events{/number}","events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/events","assignees_url":"https://api.github.com/repos/gitlabhq/gitlabhq/assignees{/user}","branches_url":"https://api.github.com/repos/gitlabhq/gitlabhq/branches{/branch}","tags_url":"https://api.github.com/repos/gitlabhq/gitlabhq/tags","blobs_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitlabhq/gitlabhq/statuses/{sha}","languages_url":"https://api.github.com/repos/gitlabhq/gitlabhq/languages","stargazers_url":"https://api.github.com/repos/gitlabhq/gitlabhq/stargazers","contributors_url":"https://api.github.com/repos/gitlabhq/gitlabhq/contributors","subscribers_url":"https://api.github.com/repos/gitlabhq/gitlabhq/subscribers","subscription_url":"https://api.github.com/repos/gitlabhq/gitlabhq/subscription","commits_url":"https://api.github.com/repos/gitlabhq/gitlabhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/comments/{number}","contents_url":"https://api.github.com/repos/gitlabhq/gitlabhq/contents/{+path}","compare_url":"https://api.github.com/repos/gitlabhq/gitlabhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitlabhq/gitlabhq/merges","archive_url":"https://api.github.com/repos/gitlabhq/gitlabhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitlabhq/gitlabhq/downloads","issues_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues{/number}","pulls_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls{/number}","milestones_url":"https://api.github.com/repos/gitlabhq/gitlabhq/milestones{/number}","notifications_url":"https://api.github.com/repos/gitlabhq/gitlabhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitlabhq/gitlabhq/labels{/name}","releases_url":"https://api.github.com/repos/gitlabhq/gitlabhq/releases{/id}","created_at":"2011-10-02T16:25:27Z","updated_at":"2014-08-14T21:03:11Z","pushed_at":"2014-08-14T12:16:11Z","git_url":"git://github.com/gitlabhq/gitlabhq.git","ssh_url":"git@github.com:gitlabhq/gitlabhq.git","clone_url":"https://github.com/gitlabhq/gitlabhq.git","svn_url":"https://github.com/gitlabhq/gitlabhq","homepage":"https://about.gitlab.com/","size":140175,"stargazers_count":13719,"watchers_count":13719,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3555,"mirror_url":null,"open_issues_count":491,"forks":3555,"open_issues":491,"watchers":13719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7502"},"html":{"href":"https://github.com/gitlabhq/gitlabhq/pull/7502"},"issue":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7502"},"comments":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/7502/comments"},"review_comments":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7502/comments"},"review_comment":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/7502/commits"},"statuses":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/statuses/9111c924a844269383a90465f5dd403b9a6beecf"}}}}