GitHub PullRequestReviewCommentEvent at 2014-08-28 21:30:52
Repository: jclouds-labs-google
Actor: andrewgaul
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments/16869131","id":16869131,"diff_hunk":"@@ -365,12 +367,57 @@ public void testPatchObjectsWithOptions() {\n    }\n \n    @Test(groups = \"live\", dependsOnMethods = \"testPatchObjectsWithOptions\")\n+   public void testMultipartJpegUpload() throws IOException {\n+      long contentLength = 32 * 1024L;\n+      ByteSource byteSource = TestUtils.randomByteSource().slice(0, contentLength);\n+      ByteSourcePayload payload = Payloads.newByteSourcePayload(byteSource);\n+      PayloadEnclosingImpl payloadImpl = new PayloadEnclosingImpl(payload);\n+\n+      ObjectTemplate template = new ObjectTemplate();\n+\n+      ObjectAccessControls oacl = ObjectAccessControls.builder().bucket(BUCKET_NAME).entity(\"allUsers\")\n+               .role(ObjectRole.OWNER).build();\n+\n+      // This would trigger server side validation of md5\n+      HashFunction hf = Hashing.md5();\n+      hcMd5 = hf.newHasher().putBytes(byteSource.read()).hash();\n+\n+      // This would trigger server side validation of crc32c\n+      HashFunction hf2 = Hashing.crc32c();\n+      hcCrc32c = hf2.newHasher().putBytes(byteSource.read()).hash();","path":"google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectApiLiveTest.java","position":37,"original_position":37,"commit_id":"2a2abc43bac8084b558fca41de08214a0a9a2c1e","original_commit_id":"2a2abc43bac8084b558fca41de08214a0a9a2c1e","user":{"login":"andrewgaul","id":848247,"avatar_url":"https://avatars.githubusercontent.com/u/848247?v=2","gravatar_id":"ea6c6f4ca7cbb47a2107508237befb8b","url":"https://api.github.com/users/andrewgaul","html_url":"https://github.com/andrewgaul","followers_url":"https://api.github.com/users/andrewgaul/followers","following_url":"https://api.github.com/users/andrewgaul/following{/other_user}","gists_url":"https://api.github.com/users/andrewgaul/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewgaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewgaul/subscriptions","organizations_url":"https://api.github.com/users/andrewgaul/orgs","repos_url":"https://api.github.com/users/andrewgaul/repos","events_url":"https://api.github.com/users/andrewgaul/events{/privacy}","received_events_url":"https://api.github.com/users/andrewgaul/received_events","type":"User","site_admin":false},"body":"Stream `ByteSource` to conserve memory:\r\n\r\n```\r\nhcCrc32c = byteSource.hash(Hashing.crc32c());\r\n```","created_at":"2014-08-28T21:30:52Z","updated_at":"2014-08-28T21:30:52Z","html_url":"https://github.com/jclouds/jclouds-labs-google/pull/46#discussion_r16869131","pull_request_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments/16869131"},"html":{"href":"https://github.com/jclouds/jclouds-labs-google/pull/46#discussion_r16869131"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/46","id":20464470,"html_url":"https://github.com/jclouds/jclouds-labs-google/pull/46","diff_url":"https://github.com/jclouds/jclouds-labs-google/pull/46.diff","patch_url":"https://github.com/jclouds/jclouds-labs-google/pull/46.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/46","number":46,"state":"open","locked":false,"title":"JCLOUDS-458:Multipart Related Upload","user":{"login":"hsbhathiya","id":4924458,"avatar_url":"https://avatars.githubusercontent.com/u/4924458?v=2","gravatar_id":"6c903c737fa3b83d1b29b2af0041ecf5","url":"https://api.github.com/users/hsbhathiya","html_url":"https://github.com/hsbhathiya","followers_url":"https://api.github.com/users/hsbhathiya/followers","following_url":"https://api.github.com/users/hsbhathiya/following{/other_user}","gists_url":"https://api.github.com/users/hsbhathiya/gists{/gist_id}","starred_url":"https://api.github.com/users/hsbhathiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsbhathiya/subscriptions","organizations_url":"https://api.github.com/users/hsbhathiya/orgs","repos_url":"https://api.github.com/users/hsbhathiya/repos","events_url":"https://api.github.com/users/hsbhathiya/events{/privacy}","received_events_url":"https://api.github.com/users/hsbhathiya/received_events","type":"User","site_admin":false},"body":"\"If you have metadata that you want to send along with the data to upload, you can make a single multipart/related request. As with simple, media-only requests, this is a good choice if the data you are sending is small enough to upload again in its entirety if the connection fails.\"","created_at":"2014-08-28T20:26:45Z","updated_at":"2014-08-28T21:30:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5df13c61af164b10f62a016aa15f62beed168b2e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/46/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/46/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/46/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/statuses/2a2abc43bac8084b558fca41de08214a0a9a2c1e","head":{"label":"hsbhathiya:MultipartRelatedStream","ref":"MultipartRelatedStream","sha":"2a2abc43bac8084b558fca41de08214a0a9a2c1e","user":{"login":"hsbhathiya","id":4924458,"avatar_url":"https://avatars.githubusercontent.com/u/4924458?v=2","gravatar_id":"6c903c737fa3b83d1b29b2af0041ecf5","url":"https://api.github.com/users/hsbhathiya","html_url":"https://github.com/hsbhathiya","followers_url":"https://api.github.com/users/hsbhathiya/followers","following_url":"https://api.github.com/users/hsbhathiya/following{/other_user}","gists_url":"https://api.github.com/users/hsbhathiya/gists{/gist_id}","starred_url":"https://api.github.com/users/hsbhathiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsbhathiya/subscriptions","organizations_url":"https://api.github.com/users/hsbhathiya/orgs","repos_url":"https://api.github.com/users/hsbhathiya/repos","events_url":"https://api.github.com/users/hsbhathiya/events{/privacy}","received_events_url":"https://api.github.com/users/hsbhathiya/received_events","type":"User","site_admin":false},"repo":{"id":19674032,"name":"jclouds-labs-google","full_name":"hsbhathiya/jclouds-labs-google","owner":{"login":"hsbhathiya","id":4924458,"avatar_url":"https://avatars.githubusercontent.com/u/4924458?v=2","gravatar_id":"6c903c737fa3b83d1b29b2af0041ecf5","url":"https://api.github.com/users/hsbhathiya","html_url":"https://github.com/hsbhathiya","followers_url":"https://api.github.com/users/hsbhathiya/followers","following_url":"https://api.github.com/users/hsbhathiya/following{/other_user}","gists_url":"https://api.github.com/users/hsbhathiya/gists{/gist_id}","starred_url":"https://api.github.com/users/hsbhathiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsbhathiya/subscriptions","organizations_url":"https://api.github.com/users/hsbhathiya/orgs","repos_url":"https://api.github.com/users/hsbhathiya/repos","events_url":"https://api.github.com/users/hsbhathiya/events{/privacy}","received_events_url":"https://api.github.com/users/hsbhathiya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hsbhathiya/jclouds-labs-google","description":"Read-only mirror of ASF Git Repo for jclouds labs-google","fork":true,"url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google","forks_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/forks","keys_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/teams","hooks_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/hooks","issue_events_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/issues/events{/number}","events_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/events","assignees_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/assignees{/user}","branches_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/branches{/branch}","tags_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/tags","blobs_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/statuses/{sha}","languages_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/languages","stargazers_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/stargazers","contributors_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/contributors","subscribers_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/subscribers","subscription_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/subscription","commits_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/issues/comments/{number}","contents_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/contents/{+path}","compare_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/merges","archive_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/downloads","issues_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/issues{/number}","pulls_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/pulls{/number}","milestones_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/milestones{/number}","notifications_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/labels{/name}","releases_url":"https://api.github.com/repos/hsbhathiya/jclouds-labs-google/releases{/id}","created_at":"2014-05-11T18:30:57Z","updated_at":"2014-06-24T03:10:17Z","pushed_at":"2014-08-28T20:24:06Z","git_url":"git://github.com/hsbhathiya/jclouds-labs-google.git","ssh_url":"git@github.com:hsbhathiya/jclouds-labs-google.git","clone_url":"https://github.com/hsbhathiya/jclouds-labs-google.git","svn_url":"https://github.com/hsbhathiya/jclouds-labs-google","homepage":null,"size":4353,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jclouds:master","ref":"master","sha":"155fc11246705cdce1658beb20182a44d01f080e","user":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=2","gravatar_id":"08fdc408ec6d07b292b8fdf46b1e3e1e","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10040995,"name":"jclouds-labs-google","full_name":"jclouds/jclouds-labs-google","owner":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=2","gravatar_id":"08fdc408ec6d07b292b8fdf46b1e3e1e","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds-labs-google","description":"Read-only mirror of ASF Git Repo for jclouds labs-google","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds-labs-google","forks_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/comments/{number}","contents_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/releases{/id}","created_at":"2013-05-13T20:48:38Z","updated_at":"2014-08-12T10:48:29Z","pushed_at":"2014-08-28T18:17:51Z","git_url":"git://github.com/jclouds/jclouds-labs-google.git","ssh_url":"git@github.com:jclouds/jclouds-labs-google.git","clone_url":"https://github.com/jclouds/jclouds-labs-google.git","svn_url":"https://github.com/jclouds/jclouds-labs-google","homepage":null,"size":2761,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":24,"mirror_url":null,"open_issues_count":6,"forks":24,"open_issues":6,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/46"},"html":{"href":"https://github.com/jclouds/jclouds-labs-google/pull/46"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/46"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/statuses/2a2abc43bac8084b558fca41de08214a0a9a2c1e"}}}}