GitHub PullRequestReviewCommentEvent at 2014-11-10 08:39:54
Repository: wicket-bootstrap
Actor: martin-g
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls/comments/20070871","id":20070871,"diff_hunk":"@@ -0,0 +1,39 @@\n+package de.agilecoders.wicket.extensions.markup.html.bootstrap.form.validation;\n+\n+import com.google.common.base.Strings;\n+import org.apache.wicket.Component;\n+import org.apache.wicket.behavior.Behavior;\n+import org.apache.wicket.feedback.ErrorLevelFeedbackMessageFilter;\n+import org.apache.wicket.feedback.FeedbackMessage;\n+import org.apache.wicket.feedback.FeedbackMessages;\n+import org.apache.wicket.markup.ComponentTag;\n+\n+/**\n+ * <h1>Component behavior.</h1>\n+ * <p>This behavior add an attribute to dom with error message.</p>","path":"bootstrap-extensions/src/main/java/de/agilecoders/wicket/extensions/markup/html/bootstrap/form/validation/FeedbackMessagePopupBehavior.java","position":13,"original_position":13,"commit_id":"306ebae3865819ba6ac33e8cad8f5ec2fd724acb","original_commit_id":"306ebae3865819ba6ac33e8cad8f5ec2fd724acb","user":{"login":"martin-g","id":232002,"avatar_url":"https://avatars.githubusercontent.com/u/232002?v=3","gravatar_id":"","url":"https://api.github.com/users/martin-g","html_url":"https://github.com/martin-g","followers_url":"https://api.github.com/users/martin-g/followers","following_url":"https://api.github.com/users/martin-g/following{/other_user}","gists_url":"https://api.github.com/users/martin-g/gists{/gist_id}","starred_url":"https://api.github.com/users/martin-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martin-g/subscriptions","organizations_url":"https://api.github.com/users/martin-g/orgs","repos_url":"https://api.github.com/users/martin-g/repos","events_url":"https://api.github.com/users/martin-g/events{/privacy}","received_events_url":"https://api.github.com/users/martin-g/received_events","type":"User","site_admin":false},"body":"Why \"Popup\" in the name ?\r\nI see nothing related to popups","created_at":"2014-11-10T08:39:54Z","updated_at":"2014-11-10T08:39:54Z","html_url":"https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/461#discussion_r20070871","pull_request_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls/461","_links":{"self":{"href":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls/comments/20070871"},"html":{"href":"https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/461#discussion_r20070871"},"pull_request":{"href":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls/461"}}},"pull_request":{"url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls/461","id":24105474,"html_url":"https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/461","diff_url":"https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/461.diff","patch_url":"https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/461.patch","issue_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/issues/461","number":461,"state":"open","locked":false,"title":"validation messages in tooltips","user":{"login":"lehvolk","id":6284727,"avatar_url":"https://avatars.githubusercontent.com/u/6284727?v=3","gravatar_id":"","url":"https://api.github.com/users/lehvolk","html_url":"https://github.com/lehvolk","followers_url":"https://api.github.com/users/lehvolk/followers","following_url":"https://api.github.com/users/lehvolk/following{/other_user}","gists_url":"https://api.github.com/users/lehvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/lehvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lehvolk/subscriptions","organizations_url":"https://api.github.com/users/lehvolk/orgs","repos_url":"https://api.github.com/users/lehvolk/repos","events_url":"https://api.github.com/users/lehvolk/events{/privacy}","received_events_url":"https://api.github.com/users/lehvolk/received_events","type":"User","site_admin":false},"body":"Implementation of two kind presentation of validation messages:\r\n- in tooltips \r\n- in p-tag under the input field\r\n\r\nIn both case validation message disappear on click, keydown, change and blur events of invalid input.\r\n\r\nPS I think ParametrizedFunction is useful class and should be moved into wicket-jquery-selectors (I wrote the todo in javadoc).","created_at":"2014-11-08T19:59:30Z","updated_at":"2014-11-10T08:39:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea08f65331b22d7bb4cfbc7ce844da31b44e340a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls/461/commits","review_comments_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls/461/comments","review_comment_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls/comments/{number}","comments_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/issues/461/comments","statuses_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/statuses/306ebae3865819ba6ac33e8cad8f5ec2fd724acb","head":{"label":"lehvolk:master","ref":"master","sha":"306ebae3865819ba6ac33e8cad8f5ec2fd724acb","user":{"login":"lehvolk","id":6284727,"avatar_url":"https://avatars.githubusercontent.com/u/6284727?v=3","gravatar_id":"","url":"https://api.github.com/users/lehvolk","html_url":"https://github.com/lehvolk","followers_url":"https://api.github.com/users/lehvolk/followers","following_url":"https://api.github.com/users/lehvolk/following{/other_user}","gists_url":"https://api.github.com/users/lehvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/lehvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lehvolk/subscriptions","organizations_url":"https://api.github.com/users/lehvolk/orgs","repos_url":"https://api.github.com/users/lehvolk/repos","events_url":"https://api.github.com/users/lehvolk/events{/privacy}","received_events_url":"https://api.github.com/users/lehvolk/received_events","type":"User","site_admin":false},"repo":{"id":26079970,"name":"wicket-bootstrap","full_name":"lehvolk/wicket-bootstrap","owner":{"login":"lehvolk","id":6284727,"avatar_url":"https://avatars.githubusercontent.com/u/6284727?v=3","gravatar_id":"","url":"https://api.github.com/users/lehvolk","html_url":"https://github.com/lehvolk","followers_url":"https://api.github.com/users/lehvolk/followers","following_url":"https://api.github.com/users/lehvolk/following{/other_user}","gists_url":"https://api.github.com/users/lehvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/lehvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lehvolk/subscriptions","organizations_url":"https://api.github.com/users/lehvolk/orgs","repos_url":"https://api.github.com/users/lehvolk/repos","events_url":"https://api.github.com/users/lehvolk/events{/privacy}","received_events_url":"https://api.github.com/users/lehvolk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lehvolk/wicket-bootstrap","description":"Apache Wicket components for Twitter Bootstrap - Wicket-Bootstrap is based on Twitter's toolkit (bootstrap) and the Apache Wicket Framework.","fork":true,"url":"https://api.github.com/repos/lehvolk/wicket-bootstrap","forks_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/forks","keys_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/teams","hooks_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/events","assignees_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/tags","blobs_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/languages","stargazers_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/subscription","commits_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/merges","archive_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/downloads","issues_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/lehvolk/wicket-bootstrap/releases{/id}","created_at":"2014-11-02T12:37:28Z","updated_at":"2014-11-02T20:55:39Z","pushed_at":"2014-11-08T19:41:05Z","git_url":"git://github.com/lehvolk/wicket-bootstrap.git","ssh_url":"git@github.com:lehvolk/wicket-bootstrap.git","clone_url":"https://github.com/lehvolk/wicket-bootstrap.git","svn_url":"https://github.com/lehvolk/wicket-bootstrap","homepage":"http://wb.agilecoders.de/","size":10162,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"l0rdn1kk0n:master","ref":"master","sha":"812686dcdbe7c0ec645f8fd7168dc758f780021c","user":{"login":"l0rdn1kk0n","id":591176,"avatar_url":"https://avatars.githubusercontent.com/u/591176?v=3","gravatar_id":"","url":"https://api.github.com/users/l0rdn1kk0n","html_url":"https://github.com/l0rdn1kk0n","followers_url":"https://api.github.com/users/l0rdn1kk0n/followers","following_url":"https://api.github.com/users/l0rdn1kk0n/following{/other_user}","gists_url":"https://api.github.com/users/l0rdn1kk0n/gists{/gist_id}","starred_url":"https://api.github.com/users/l0rdn1kk0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l0rdn1kk0n/subscriptions","organizations_url":"https://api.github.com/users/l0rdn1kk0n/orgs","repos_url":"https://api.github.com/users/l0rdn1kk0n/repos","events_url":"https://api.github.com/users/l0rdn1kk0n/events{/privacy}","received_events_url":"https://api.github.com/users/l0rdn1kk0n/received_events","type":"User","site_admin":false},"repo":{"id":3431492,"name":"wicket-bootstrap","full_name":"l0rdn1kk0n/wicket-bootstrap","owner":{"login":"l0rdn1kk0n","id":591176,"avatar_url":"https://avatars.githubusercontent.com/u/591176?v=3","gravatar_id":"","url":"https://api.github.com/users/l0rdn1kk0n","html_url":"https://github.com/l0rdn1kk0n","followers_url":"https://api.github.com/users/l0rdn1kk0n/followers","following_url":"https://api.github.com/users/l0rdn1kk0n/following{/other_user}","gists_url":"https://api.github.com/users/l0rdn1kk0n/gists{/gist_id}","starred_url":"https://api.github.com/users/l0rdn1kk0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l0rdn1kk0n/subscriptions","organizations_url":"https://api.github.com/users/l0rdn1kk0n/orgs","repos_url":"https://api.github.com/users/l0rdn1kk0n/repos","events_url":"https://api.github.com/users/l0rdn1kk0n/events{/privacy}","received_events_url":"https://api.github.com/users/l0rdn1kk0n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/l0rdn1kk0n/wicket-bootstrap","description":"Apache Wicket components for Twitter Bootstrap - Wicket-Bootstrap is based on Twitter's toolkit (bootstrap) and the Apache Wicket Framework.","fork":false,"url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap","forks_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/forks","keys_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/teams","hooks_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/events","assignees_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/tags","blobs_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/languages","stargazers_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/subscription","commits_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/merges","archive_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/downloads","issues_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/releases{/id}","created_at":"2012-02-13T16:04:53Z","updated_at":"2014-11-07T22:57:54Z","pushed_at":"2014-11-10T08:33:45Z","git_url":"git://github.com/l0rdn1kk0n/wicket-bootstrap.git","ssh_url":"git@github.com:l0rdn1kk0n/wicket-bootstrap.git","clone_url":"https://github.com/l0rdn1kk0n/wicket-bootstrap.git","svn_url":"https://github.com/l0rdn1kk0n/wicket-bootstrap","homepage":"http://wb.agilecoders.de/","size":21443,"stargazers_count":200,"watchers_count":200,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":91,"mirror_url":null,"open_issues_count":18,"forks":91,"open_issues":18,"watchers":200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls/461"},"html":{"href":"https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/461"},"issue":{"href":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/issues/461"},"comments":{"href":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/issues/461/comments"},"review_comments":{"href":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls/461/comments"},"review_comment":{"href":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/pulls/461/commits"},"statuses":{"href":"https://api.github.com/repos/l0rdn1kk0n/wicket-bootstrap/statuses/306ebae3865819ba6ac33e8cad8f5ec2fd724acb"}}}}