GitHub PullRequestReviewCommentEvent at 2014-08-19 05:48:45
Repository: scikit-learn
Actor: GaelVaroquaux
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/16398020","id":16398020,"diff_hunk":"@@ -804,6 +958,13 @@ class LogisticRegressionCV(LogisticRegression, BaseEstimator,\n         Otherwise the coefs, intercepts and C that correspond to the\n         best scores across folds are averaged.\n \n+    multi_class : str, optional default 'ovr'","path":"sklearn/linear_model/logistic.py","position":415,"original_position":415,"commit_id":"2f722bb3e10bcf2af55428f28675d610d78db907","original_commit_id":"2f722bb3e10bcf2af55428f28675d610d78db907","user":{"login":"GaelVaroquaux","id":208217,"avatar_url":"https://avatars.githubusercontent.com/u/208217?v=2","gravatar_id":"5c9fb379c4e97b58960d74dcbfc5dee5","url":"https://api.github.com/users/GaelVaroquaux","html_url":"https://github.com/GaelVaroquaux","followers_url":"https://api.github.com/users/GaelVaroquaux/followers","following_url":"https://api.github.com/users/GaelVaroquaux/following{/other_user}","gists_url":"https://api.github.com/users/GaelVaroquaux/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelVaroquaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelVaroquaux/subscriptions","organizations_url":"https://api.github.com/users/GaelVaroquaux/orgs","repos_url":"https://api.github.com/users/GaelVaroquaux/repos","events_url":"https://api.github.com/users/GaelVaroquaux/events{/privacy}","received_events_url":"https://api.github.com/users/GaelVaroquaux/received_events","type":"User","site_admin":false},"body":"Docstring style (see above)","created_at":"2014-08-19T05:48:45Z","updated_at":"2014-08-19T05:48:45Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/3490#discussion_r16398020","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3490","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/16398020"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/3490#discussion_r16398020"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3490"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3490","id":18958515,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/3490","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/3490.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/3490.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3490","number":3490,"state":"open","locked":false,"title":"[MRG+2] Multinomial Logistic Regression","user":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=2","gravatar_id":"92d7b3c4844c27255d0cd305e9f65c67","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"body":"- [x] Refactor code to let multinomial to be an option.\r\n- [x] Test with further data, (e.g make blobs)\r\n- [x] Try speeding up\r\n\r\nBenchmarks for the haxby dataset.\r\n\r\nWhen X is dense and across 9 classes (972, 577) (removing most of the zero features)\r\n![haxby_dense](https://cloud.githubusercontent.com/assets/1867024/3839745/f81b1b0e-1e14-11e4-8bc8-db76b0f37045.png)\r\n\r\nWhen X is sparse and acroos 9 classes (972, 163839)\r\n![haxby_sparse_complete](https://cloud.githubusercontent.com/assets/1867024/3839763/1d378332-1e15-11e4-9753-2833450f9d6e.png)\r\n\r\nBenchmarks for a synthetic dataset, using make_classification (50000, 2000)\r\n![synthetic_multinomial](https://cloud.githubusercontent.com/assets/1867024/3841884/2df55e98-1e32-11e4-81e6-97c03f935de5.png)\r\n\r\n![newsgroup_multinomial](https://cloud.githubusercontent.com/assets/1867024/3841982/0d4c29a0-1e33-11e4-9d0e-b3c1cef03d8a.png)\r\n\r\nFor the arcene data (100 * 10000)\r\n![arcene](https://cloud.githubusercontent.com/assets/1867024/3842731/d5c99326-1e39-11e4-893a-782ef1652558.png)\r\n","created_at":"2014-07-28T10:03:27Z","updated_at":"2014-08-19T05:48:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d98f36d5afe9caf6bdeaf5595016a8bd849929d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3490/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3490/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3490/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/2f722bb3e10bcf2af55428f28675d610d78db907","head":{"label":"MechCoder:multinomial_logreg","ref":"multinomial_logreg","sha":"2f722bb3e10bcf2af55428f28675d610d78db907","user":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=2","gravatar_id":"92d7b3c4844c27255d0cd305e9f65c67","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"repo":{"id":9655682,"name":"scikit-learn","full_name":"MechCoder/scikit-learn","owner":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=2","gravatar_id":"92d7b3c4844c27255d0cd305e9f65c67","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MechCoder/scikit-learn","description":"Work in Progress","fork":true,"url":"https://api.github.com/repos/MechCoder/scikit-learn","forks_url":"https://api.github.com/repos/MechCoder/scikit-learn/forks","keys_url":"https://api.github.com/repos/MechCoder/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MechCoder/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MechCoder/scikit-learn/teams","hooks_url":"https://api.github.com/repos/MechCoder/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/MechCoder/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/MechCoder/scikit-learn/events","assignees_url":"https://api.github.com/repos/MechCoder/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/MechCoder/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/MechCoder/scikit-learn/tags","blobs_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MechCoder/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/MechCoder/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/MechCoder/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/MechCoder/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/MechCoder/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/MechCoder/scikit-learn/subscription","commits_url":"https://api.github.com/repos/MechCoder/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/MechCoder/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/MechCoder/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/MechCoder/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/MechCoder/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/MechCoder/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MechCoder/scikit-learn/merges","archive_url":"https://api.github.com/repos/MechCoder/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MechCoder/scikit-learn/downloads","issues_url":"https://api.github.com/repos/MechCoder/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/MechCoder/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/MechCoder/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/MechCoder/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MechCoder/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/MechCoder/scikit-learn/releases{/id}","created_at":"2013-04-24T19:16:18Z","updated_at":"2014-07-17T15:12:34Z","pushed_at":"2014-08-18T16:36:42Z","git_url":"git://github.com/MechCoder/scikit-learn.git","ssh_url":"git@github.com:MechCoder/scikit-learn.git","clone_url":"https://github.com/MechCoder/scikit-learn.git","svn_url":"https://github.com/MechCoder/scikit-learn","homepage":"http://scikit-learn.org","size":56180,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"05aa8041b4bdf85a22584baccbde16e8655dc166","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=2","gravatar_id":"8a6ecb57b119c5a5b3d882d08a909278","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=2","gravatar_id":"8a6ecb57b119c5a5b3d882d08a909278","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2014-08-19T05:42:49Z","pushed_at":"2014-08-18T14:41:36Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":115302,"stargazers_count":3855,"watchers_count":3855,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2050,"mirror_url":null,"open_issues_count":472,"forks":2050,"open_issues":472,"watchers":3855,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3490"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/3490"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3490"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/3490/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3490/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/3490/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/2f722bb3e10bcf2af55428f28675d610d78db907"}}}}