GitHub PullRequestReviewCommentEvent at 2014-08-08 09:08:25
Repository: NETProvider
Actor: cincuranet
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cincuranet/NETProvider/pulls/comments/15983812","id":15983812,"diff_hunk":"@@ -310,7 +310,10 @@ public byte[] GetBytes()\n \n \t\t\t\tcase DbDataType.Guid:\n \t\t\t\t\treturn this.GetGuid().ToByteArray();\n-\n+\t\t\t\t\t\n+\t\t\t\tcase DbDataType.Null:\n+\t\t\t\t\treturn new byte[0];","path":"NETProvider/src/FirebirdSql.Data.FirebirdClient/Common/DbValue.cs","position":7,"original_position":7,"commit_id":"79662c3d152e420ab99467e22f3e8596f448f0d4","original_commit_id":"79662c3d152e420ab99467e22f3e8596f448f0d4","user":{"login":"cincuranet","id":4540597,"avatar_url":"https://avatars.githubusercontent.com/u/4540597?v=2","gravatar_id":"f1acffba98724b66ac13ef4ef9b241ae","url":"https://api.github.com/users/cincuranet","html_url":"https://github.com/cincuranet","followers_url":"https://api.github.com/users/cincuranet/followers","following_url":"https://api.github.com/users/cincuranet/following{/other_user}","gists_url":"https://api.github.com/users/cincuranet/gists{/gist_id}","starred_url":"https://api.github.com/users/cincuranet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cincuranet/subscriptions","organizations_url":"https://api.github.com/users/cincuranet/orgs","repos_url":"https://api.github.com/users/cincuranet/repos","events_url":"https://api.github.com/users/cincuranet/events{/privacy}","received_events_url":"https://api.github.com/users/cincuranet/received_events","type":"User","site_admin":false},"body":"What's the reason behind this change?","created_at":"2014-08-08T09:08:25Z","updated_at":"2014-08-08T09:08:25Z","html_url":"https://github.com/cincuranet/NETProvider/pull/8#discussion_r15983812","pull_request_url":"https://api.github.com/repos/cincuranet/NETProvider/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/cincuranet/NETProvider/pulls/comments/15983812"},"html":{"href":"https://github.com/cincuranet/NETProvider/pull/8#discussion_r15983812"},"pull_request":{"href":"https://api.github.com/repos/cincuranet/NETProvider/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/cincuranet/NETProvider/pulls/8","id":19340468,"html_url":"https://github.com/cincuranet/NETProvider/pull/8","diff_url":"https://github.com/cincuranet/NETProvider/pull/8.diff","patch_url":"https://github.com/cincuranet/NETProvider/pull/8.patch","issue_url":"https://api.github.com/repos/cincuranet/NETProvider/issues/8","number":8,"state":"open","title":"DNET-550 NotSupportedException occurs when using ServerType embedded","user":{"login":"zabulus","id":2720011,"avatar_url":"https://avatars.githubusercontent.com/u/2720011?v=2","gravatar_id":"d97280de81872463aaa0f07798351c64","url":"https://api.github.com/users/zabulus","html_url":"https://github.com/zabulus","followers_url":"https://api.github.com/users/zabulus/followers","following_url":"https://api.github.com/users/zabulus/following{/other_user}","gists_url":"https://api.github.com/users/zabulus/gists{/gist_id}","starred_url":"https://api.github.com/users/zabulus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zabulus/subscriptions","organizations_url":"https://api.github.com/users/zabulus/orgs","repos_url":"https://api.github.com/users/zabulus/repos","events_url":"https://api.github.com/users/zabulus/events{/privacy}","received_events_url":"https://api.github.com/users/zabulus/received_events","type":"User","site_admin":false},"body":"Found by unit-tests in our current project using fbembed.dll","created_at":"2014-08-05T13:08:46Z","updated_at":"2014-08-08T09:08:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffb8cf3a247366a26e52ef679907336faa2746c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cincuranet/NETProvider/pulls/8/commits","review_comments_url":"https://api.github.com/repos/cincuranet/NETProvider/pulls/8/comments","review_comment_url":"https://api.github.com/repos/cincuranet/NETProvider/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cincuranet/NETProvider/issues/8/comments","statuses_url":"https://api.github.com/repos/cincuranet/NETProvider/statuses/79662c3d152e420ab99467e22f3e8596f448f0d4","head":{"label":"zabulus:DNET_550","ref":"DNET_550","sha":"79662c3d152e420ab99467e22f3e8596f448f0d4","user":{"login":"zabulus","id":2720011,"avatar_url":"https://avatars.githubusercontent.com/u/2720011?v=2","gravatar_id":"d97280de81872463aaa0f07798351c64","url":"https://api.github.com/users/zabulus","html_url":"https://github.com/zabulus","followers_url":"https://api.github.com/users/zabulus/followers","following_url":"https://api.github.com/users/zabulus/following{/other_user}","gists_url":"https://api.github.com/users/zabulus/gists{/gist_id}","starred_url":"https://api.github.com/users/zabulus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zabulus/subscriptions","organizations_url":"https://api.github.com/users/zabulus/orgs","repos_url":"https://api.github.com/users/zabulus/repos","events_url":"https://api.github.com/users/zabulus/events{/privacy}","received_events_url":"https://api.github.com/users/zabulus/received_events","type":"User","site_admin":false},"repo":{"id":18793060,"name":"NETProvider","full_name":"zabulus/NETProvider","owner":{"login":"zabulus","id":2720011,"avatar_url":"https://avatars.githubusercontent.com/u/2720011?v=2","gravatar_id":"d97280de81872463aaa0f07798351c64","url":"https://api.github.com/users/zabulus","html_url":"https://github.com/zabulus","followers_url":"https://api.github.com/users/zabulus/followers","following_url":"https://api.github.com/users/zabulus/following{/other_user}","gists_url":"https://api.github.com/users/zabulus/gists{/gist_id}","starred_url":"https://api.github.com/users/zabulus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zabulus/subscriptions","organizations_url":"https://api.github.com/users/zabulus/orgs","repos_url":"https://api.github.com/users/zabulus/repos","events_url":"https://api.github.com/users/zabulus/events{/privacy}","received_events_url":"https://api.github.com/users/zabulus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zabulus/NETProvider","description":"Firebird ADO.NET Data Provider","fork":true,"url":"https://api.github.com/repos/zabulus/NETProvider","forks_url":"https://api.github.com/repos/zabulus/NETProvider/forks","keys_url":"https://api.github.com/repos/zabulus/NETProvider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zabulus/NETProvider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zabulus/NETProvider/teams","hooks_url":"https://api.github.com/repos/zabulus/NETProvider/hooks","issue_events_url":"https://api.github.com/repos/zabulus/NETProvider/issues/events{/number}","events_url":"https://api.github.com/repos/zabulus/NETProvider/events","assignees_url":"https://api.github.com/repos/zabulus/NETProvider/assignees{/user}","branches_url":"https://api.github.com/repos/zabulus/NETProvider/branches{/branch}","tags_url":"https://api.github.com/repos/zabulus/NETProvider/tags","blobs_url":"https://api.github.com/repos/zabulus/NETProvider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zabulus/NETProvider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zabulus/NETProvider/git/refs{/sha}","trees_url":"https://api.github.com/repos/zabulus/NETProvider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zabulus/NETProvider/statuses/{sha}","languages_url":"https://api.github.com/repos/zabulus/NETProvider/languages","stargazers_url":"https://api.github.com/repos/zabulus/NETProvider/stargazers","contributors_url":"https://api.github.com/repos/zabulus/NETProvider/contributors","subscribers_url":"https://api.github.com/repos/zabulus/NETProvider/subscribers","subscription_url":"https://api.github.com/repos/zabulus/NETProvider/subscription","commits_url":"https://api.github.com/repos/zabulus/NETProvider/commits{/sha}","git_commits_url":"https://api.github.com/repos/zabulus/NETProvider/git/commits{/sha}","comments_url":"https://api.github.com/repos/zabulus/NETProvider/comments{/number}","issue_comment_url":"https://api.github.com/repos/zabulus/NETProvider/issues/comments/{number}","contents_url":"https://api.github.com/repos/zabulus/NETProvider/contents/{+path}","compare_url":"https://api.github.com/repos/zabulus/NETProvider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zabulus/NETProvider/merges","archive_url":"https://api.github.com/repos/zabulus/NETProvider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zabulus/NETProvider/downloads","issues_url":"https://api.github.com/repos/zabulus/NETProvider/issues{/number}","pulls_url":"https://api.github.com/repos/zabulus/NETProvider/pulls{/number}","milestones_url":"https://api.github.com/repos/zabulus/NETProvider/milestones{/number}","notifications_url":"https://api.github.com/repos/zabulus/NETProvider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zabulus/NETProvider/labels{/name}","releases_url":"https://api.github.com/repos/zabulus/NETProvider/releases{/id}","created_at":"2014-04-15T08:37:00Z","updated_at":"2014-07-31T06:27:41Z","pushed_at":"2014-08-05T13:31:19Z","git_url":"git://github.com/zabulus/NETProvider.git","ssh_url":"git@github.com:zabulus/NETProvider.git","clone_url":"https://github.com/zabulus/NETProvider.git","svn_url":"https://github.com/zabulus/NETProvider","homepage":"http://www.firebirdsql.org/en/net-provider/","size":17509,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cincuranet:master","ref":"master","sha":"87610d4efdaad5f4d4294a9d028a1691282e1d13","user":{"login":"cincuranet","id":4540597,"avatar_url":"https://avatars.githubusercontent.com/u/4540597?v=2","gravatar_id":"f1acffba98724b66ac13ef4ef9b241ae","url":"https://api.github.com/users/cincuranet","html_url":"https://github.com/cincuranet","followers_url":"https://api.github.com/users/cincuranet/followers","following_url":"https://api.github.com/users/cincuranet/following{/other_user}","gists_url":"https://api.github.com/users/cincuranet/gists{/gist_id}","starred_url":"https://api.github.com/users/cincuranet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cincuranet/subscriptions","organizations_url":"https://api.github.com/users/cincuranet/orgs","repos_url":"https://api.github.com/users/cincuranet/repos","events_url":"https://api.github.com/users/cincuranet/events{/privacy}","received_events_url":"https://api.github.com/users/cincuranet/received_events","type":"User","site_admin":false},"repo":{"id":11629136,"name":"NETProvider","full_name":"cincuranet/NETProvider","owner":{"login":"cincuranet","id":4540597,"avatar_url":"https://avatars.githubusercontent.com/u/4540597?v=2","gravatar_id":"f1acffba98724b66ac13ef4ef9b241ae","url":"https://api.github.com/users/cincuranet","html_url":"https://github.com/cincuranet","followers_url":"https://api.github.com/users/cincuranet/followers","following_url":"https://api.github.com/users/cincuranet/following{/other_user}","gists_url":"https://api.github.com/users/cincuranet/gists{/gist_id}","starred_url":"https://api.github.com/users/cincuranet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cincuranet/subscriptions","organizations_url":"https://api.github.com/users/cincuranet/orgs","repos_url":"https://api.github.com/users/cincuranet/repos","events_url":"https://api.github.com/users/cincuranet/events{/privacy}","received_events_url":"https://api.github.com/users/cincuranet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cincuranet/NETProvider","description":"Firebird ADO.NET Data Provider","fork":false,"url":"https://api.github.com/repos/cincuranet/NETProvider","forks_url":"https://api.github.com/repos/cincuranet/NETProvider/forks","keys_url":"https://api.github.com/repos/cincuranet/NETProvider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cincuranet/NETProvider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cincuranet/NETProvider/teams","hooks_url":"https://api.github.com/repos/cincuranet/NETProvider/hooks","issue_events_url":"https://api.github.com/repos/cincuranet/NETProvider/issues/events{/number}","events_url":"https://api.github.com/repos/cincuranet/NETProvider/events","assignees_url":"https://api.github.com/repos/cincuranet/NETProvider/assignees{/user}","branches_url":"https://api.github.com/repos/cincuranet/NETProvider/branches{/branch}","tags_url":"https://api.github.com/repos/cincuranet/NETProvider/tags","blobs_url":"https://api.github.com/repos/cincuranet/NETProvider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cincuranet/NETProvider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cincuranet/NETProvider/git/refs{/sha}","trees_url":"https://api.github.com/repos/cincuranet/NETProvider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cincuranet/NETProvider/statuses/{sha}","languages_url":"https://api.github.com/repos/cincuranet/NETProvider/languages","stargazers_url":"https://api.github.com/repos/cincuranet/NETProvider/stargazers","contributors_url":"https://api.github.com/repos/cincuranet/NETProvider/contributors","subscribers_url":"https://api.github.com/repos/cincuranet/NETProvider/subscribers","subscription_url":"https://api.github.com/repos/cincuranet/NETProvider/subscription","commits_url":"https://api.github.com/repos/cincuranet/NETProvider/commits{/sha}","git_commits_url":"https://api.github.com/repos/cincuranet/NETProvider/git/commits{/sha}","comments_url":"https://api.github.com/repos/cincuranet/NETProvider/comments{/number}","issue_comment_url":"https://api.github.com/repos/cincuranet/NETProvider/issues/comments/{number}","contents_url":"https://api.github.com/repos/cincuranet/NETProvider/contents/{+path}","compare_url":"https://api.github.com/repos/cincuranet/NETProvider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cincuranet/NETProvider/merges","archive_url":"https://api.github.com/repos/cincuranet/NETProvider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cincuranet/NETProvider/downloads","issues_url":"https://api.github.com/repos/cincuranet/NETProvider/issues{/number}","pulls_url":"https://api.github.com/repos/cincuranet/NETProvider/pulls{/number}","milestones_url":"https://api.github.com/repos/cincuranet/NETProvider/milestones{/number}","notifications_url":"https://api.github.com/repos/cincuranet/NETProvider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cincuranet/NETProvider/labels{/name}","releases_url":"https://api.github.com/repos/cincuranet/NETProvider/releases{/id}","created_at":"2013-07-24T07:42:19Z","updated_at":"2014-07-13T17:29:18Z","pushed_at":"2014-07-28T07:44:31Z","git_url":"git://github.com/cincuranet/NETProvider.git","ssh_url":"git@github.com:cincuranet/NETProvider.git","clone_url":"https://github.com/cincuranet/NETProvider.git","svn_url":"https://github.com/cincuranet/NETProvider","homepage":"http://www.firebirdsql.org/en/net-provider/","size":19848,"stargazers_count":6,"watchers_count":6,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cincuranet/NETProvider/pulls/8"},"html":{"href":"https://github.com/cincuranet/NETProvider/pull/8"},"issue":{"href":"https://api.github.com/repos/cincuranet/NETProvider/issues/8"},"comments":{"href":"https://api.github.com/repos/cincuranet/NETProvider/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/cincuranet/NETProvider/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/cincuranet/NETProvider/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cincuranet/NETProvider/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/cincuranet/NETProvider/statuses/79662c3d152e420ab99467e22f3e8596f448f0d4"}}}}