GitHub PullRequestReviewCommentEvent at 2014-07-21 13:10:38
Repository: tunes
Actor: johnmanong
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/byronmwong/tunes/pulls/comments/15167215","id":15167215,"diff_hunk":"@@ -33,4 +34,34 @@\n       end\n     end\n   end\n+\n+  describe \"song_from_youtube_url\" do\n+    before do\n+      @video_info = OpenStruct.new({\n+        title: 'Cool Song',\n+        author: OpenStruct.new({\n+          name: 'Cool Artist'\n+        }),\n+        unique_id: 'asdf'\n+      })\n+      YouTubeIt::Client.any_instance.stub(:video_by).and_return(@video_info)\n+    end\n+\n+    it \"creates a song and sound with correct metadata\" do\n+      song = helper.song_from_youtube_url('cool.url/bro')\n+      expect(song[:title]).to eq(@video_info.title)\n+      expect(song[:artist]).to eq(@video_info.author.name)\n+      expect(song.sounds.exists?({sound_type: 'youtube', location: @video_info.unique_id})).to eq(true)\n+    end\n+\n+    describe \"redundant add\" do\n+      before { @song = helper.song_from_youtube_url('blah') }","path":"spec/helpers/songs_helper_spec.rb","position":31,"original_position":31,"commit_id":"cfe9750b4ae20ee193f41a2e126024a05676153d","original_commit_id":"cfe9750b4ae20ee193f41a2e126024a05676153d","user":{"login":"johnmanong","id":4474076,"avatar_url":"https://avatars.githubusercontent.com/u/4474076?","gravatar_id":"c591f789f2ba722ac792a8b536010490","url":"https://api.github.com/users/johnmanong","html_url":"https://github.com/johnmanong","followers_url":"https://api.github.com/users/johnmanong/followers","following_url":"https://api.github.com/users/johnmanong/following{/other_user}","gists_url":"https://api.github.com/users/johnmanong/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmanong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmanong/subscriptions","organizations_url":"https://api.github.com/users/johnmanong/orgs","repos_url":"https://api.github.com/users/johnmanong/repos","events_url":"https://api.github.com/users/johnmanong/events{/privacy}","received_events_url":"https://api.github.com/users/johnmanong/received_events","type":"User","site_admin":false},"body":"sure why not","created_at":"2014-07-21T13:10:38Z","updated_at":"2014-07-21T13:10:38Z","html_url":"https://github.com/byronmwong/tunes/pull/24#discussion_r15167215","pull_request_url":"https://api.github.com/repos/byronmwong/tunes/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/byronmwong/tunes/pulls/comments/15167215"},"html":{"href":"https://github.com/byronmwong/tunes/pull/24#discussion_r15167215"},"pull_request":{"href":"https://api.github.com/repos/byronmwong/tunes/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/byronmwong/tunes/pulls/24","id":18625069,"html_url":"https://github.com/byronmwong/tunes/pull/24","diff_url":"https://github.com/byronmwong/tunes/pull/24.diff","patch_url":"https://github.com/byronmwong/tunes/pull/24.patch","issue_url":"https://api.github.com/repos/byronmwong/tunes/issues/24","number":24,"state":"open","title":"add youtube song creation helper w/ tests (review: john)","user":{"login":"byronmwong","id":1434481,"avatar_url":"https://avatars.githubusercontent.com/u/1434481?","gravatar_id":null,"url":"https://api.github.com/users/byronmwong","html_url":"https://github.com/byronmwong","followers_url":"https://api.github.com/users/byronmwong/followers","following_url":"https://api.github.com/users/byronmwong/following{/other_user}","gists_url":"https://api.github.com/users/byronmwong/gists{/gist_id}","starred_url":"https://api.github.com/users/byronmwong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byronmwong/subscriptions","organizations_url":"https://api.github.com/users/byronmwong/orgs","repos_url":"https://api.github.com/users/byronmwong/repos","events_url":"https://api.github.com/users/byronmwong/events{/privacy}","received_events_url":"https://api.github.com/users/byronmwong/received_events","type":"User","site_admin":false},"body":"@johnmanong peep dis helper game","created_at":"2014-07-19T23:24:47Z","updated_at":"2014-07-21T13:10:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"815b9e6bf9e57b895fe4e94c7f5a0acf4d6a84a9","assignee":{"login":"johnmanong","id":4474076,"avatar_url":"https://avatars.githubusercontent.com/u/4474076?","gravatar_id":"c591f789f2ba722ac792a8b536010490","url":"https://api.github.com/users/johnmanong","html_url":"https://github.com/johnmanong","followers_url":"https://api.github.com/users/johnmanong/followers","following_url":"https://api.github.com/users/johnmanong/following{/other_user}","gists_url":"https://api.github.com/users/johnmanong/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmanong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmanong/subscriptions","organizations_url":"https://api.github.com/users/johnmanong/orgs","repos_url":"https://api.github.com/users/johnmanong/repos","events_url":"https://api.github.com/users/johnmanong/events{/privacy}","received_events_url":"https://api.github.com/users/johnmanong/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/byronmwong/tunes/pulls/24/commits","review_comments_url":"https://api.github.com/repos/byronmwong/tunes/pulls/24/comments","review_comment_url":"https://api.github.com/repos/byronmwong/tunes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/byronmwong/tunes/issues/24/comments","statuses_url":"https://api.github.com/repos/byronmwong/tunes/statuses/cfe9750b4ae20ee193f41a2e126024a05676153d","head":{"label":"byronmwong:feature/youtube_helper","ref":"feature/youtube_helper","sha":"cfe9750b4ae20ee193f41a2e126024a05676153d","user":{"login":"byronmwong","id":1434481,"avatar_url":"https://avatars.githubusercontent.com/u/1434481?","gravatar_id":null,"url":"https://api.github.com/users/byronmwong","html_url":"https://github.com/byronmwong","followers_url":"https://api.github.com/users/byronmwong/followers","following_url":"https://api.github.com/users/byronmwong/following{/other_user}","gists_url":"https://api.github.com/users/byronmwong/gists{/gist_id}","starred_url":"https://api.github.com/users/byronmwong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byronmwong/subscriptions","organizations_url":"https://api.github.com/users/byronmwong/orgs","repos_url":"https://api.github.com/users/byronmwong/repos","events_url":"https://api.github.com/users/byronmwong/events{/privacy}","received_events_url":"https://api.github.com/users/byronmwong/received_events","type":"User","site_admin":false},"repo":{"id":14172434,"name":"tunes","full_name":"byronmwong/tunes","owner":{"login":"byronmwong","id":1434481,"avatar_url":"https://avatars.githubusercontent.com/u/1434481?","gravatar_id":null,"url":"https://api.github.com/users/byronmwong","html_url":"https://github.com/byronmwong","followers_url":"https://api.github.com/users/byronmwong/followers","following_url":"https://api.github.com/users/byronmwong/following{/other_user}","gists_url":"https://api.github.com/users/byronmwong/gists{/gist_id}","starred_url":"https://api.github.com/users/byronmwong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byronmwong/subscriptions","organizations_url":"https://api.github.com/users/byronmwong/orgs","repos_url":"https://api.github.com/users/byronmwong/repos","events_url":"https://api.github.com/users/byronmwong/events{/privacy}","received_events_url":"https://api.github.com/users/byronmwong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/byronmwong/tunes","description":"","fork":false,"url":"https://api.github.com/repos/byronmwong/tunes","forks_url":"https://api.github.com/repos/byronmwong/tunes/forks","keys_url":"https://api.github.com/repos/byronmwong/tunes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/byronmwong/tunes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/byronmwong/tunes/teams","hooks_url":"https://api.github.com/repos/byronmwong/tunes/hooks","issue_events_url":"https://api.github.com/repos/byronmwong/tunes/issues/events{/number}","events_url":"https://api.github.com/repos/byronmwong/tunes/events","assignees_url":"https://api.github.com/repos/byronmwong/tunes/assignees{/user}","branches_url":"https://api.github.com/repos/byronmwong/tunes/branches{/branch}","tags_url":"https://api.github.com/repos/byronmwong/tunes/tags","blobs_url":"https://api.github.com/repos/byronmwong/tunes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/byronmwong/tunes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/byronmwong/tunes/git/refs{/sha}","trees_url":"https://api.github.com/repos/byronmwong/tunes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/byronmwong/tunes/statuses/{sha}","languages_url":"https://api.github.com/repos/byronmwong/tunes/languages","stargazers_url":"https://api.github.com/repos/byronmwong/tunes/stargazers","contributors_url":"https://api.github.com/repos/byronmwong/tunes/contributors","subscribers_url":"https://api.github.com/repos/byronmwong/tunes/subscribers","subscription_url":"https://api.github.com/repos/byronmwong/tunes/subscription","commits_url":"https://api.github.com/repos/byronmwong/tunes/commits{/sha}","git_commits_url":"https://api.github.com/repos/byronmwong/tunes/git/commits{/sha}","comments_url":"https://api.github.com/repos/byronmwong/tunes/comments{/number}","issue_comment_url":"https://api.github.com/repos/byronmwong/tunes/issues/comments/{number}","contents_url":"https://api.github.com/repos/byronmwong/tunes/contents/{+path}","compare_url":"https://api.github.com/repos/byronmwong/tunes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/byronmwong/tunes/merges","archive_url":"https://api.github.com/repos/byronmwong/tunes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/byronmwong/tunes/downloads","issues_url":"https://api.github.com/repos/byronmwong/tunes/issues{/number}","pulls_url":"https://api.github.com/repos/byronmwong/tunes/pulls{/number}","milestones_url":"https://api.github.com/repos/byronmwong/tunes/milestones{/number}","notifications_url":"https://api.github.com/repos/byronmwong/tunes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/byronmwong/tunes/labels{/name}","releases_url":"https://api.github.com/repos/byronmwong/tunes/releases{/id}","created_at":"2013-11-06T12:54:47Z","updated_at":"2014-05-18T07:42:19Z","pushed_at":"2014-07-19T23:23:50Z","git_url":"git://github.com/byronmwong/tunes.git","ssh_url":"git@github.com:byronmwong/tunes.git","clone_url":"https://github.com/byronmwong/tunes.git","svn_url":"https://github.com/byronmwong/tunes","homepage":null,"size":757,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":1,"default_branch":"master"}},"base":{"label":"byronmwong:master","ref":"master","sha":"deafc5bedcb51549258c4d96461f022b38af7a42","user":{"login":"byronmwong","id":1434481,"avatar_url":"https://avatars.githubusercontent.com/u/1434481?","gravatar_id":null,"url":"https://api.github.com/users/byronmwong","html_url":"https://github.com/byronmwong","followers_url":"https://api.github.com/users/byronmwong/followers","following_url":"https://api.github.com/users/byronmwong/following{/other_user}","gists_url":"https://api.github.com/users/byronmwong/gists{/gist_id}","starred_url":"https://api.github.com/users/byronmwong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byronmwong/subscriptions","organizations_url":"https://api.github.com/users/byronmwong/orgs","repos_url":"https://api.github.com/users/byronmwong/repos","events_url":"https://api.github.com/users/byronmwong/events{/privacy}","received_events_url":"https://api.github.com/users/byronmwong/received_events","type":"User","site_admin":false},"repo":{"id":14172434,"name":"tunes","full_name":"byronmwong/tunes","owner":{"login":"byronmwong","id":1434481,"avatar_url":"https://avatars.githubusercontent.com/u/1434481?","gravatar_id":null,"url":"https://api.github.com/users/byronmwong","html_url":"https://github.com/byronmwong","followers_url":"https://api.github.com/users/byronmwong/followers","following_url":"https://api.github.com/users/byronmwong/following{/other_user}","gists_url":"https://api.github.com/users/byronmwong/gists{/gist_id}","starred_url":"https://api.github.com/users/byronmwong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byronmwong/subscriptions","organizations_url":"https://api.github.com/users/byronmwong/orgs","repos_url":"https://api.github.com/users/byronmwong/repos","events_url":"https://api.github.com/users/byronmwong/events{/privacy}","received_events_url":"https://api.github.com/users/byronmwong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/byronmwong/tunes","description":"","fork":false,"url":"https://api.github.com/repos/byronmwong/tunes","forks_url":"https://api.github.com/repos/byronmwong/tunes/forks","keys_url":"https://api.github.com/repos/byronmwong/tunes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/byronmwong/tunes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/byronmwong/tunes/teams","hooks_url":"https://api.github.com/repos/byronmwong/tunes/hooks","issue_events_url":"https://api.github.com/repos/byronmwong/tunes/issues/events{/number}","events_url":"https://api.github.com/repos/byronmwong/tunes/events","assignees_url":"https://api.github.com/repos/byronmwong/tunes/assignees{/user}","branches_url":"https://api.github.com/repos/byronmwong/tunes/branches{/branch}","tags_url":"https://api.github.com/repos/byronmwong/tunes/tags","blobs_url":"https://api.github.com/repos/byronmwong/tunes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/byronmwong/tunes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/byronmwong/tunes/git/refs{/sha}","trees_url":"https://api.github.com/repos/byronmwong/tunes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/byronmwong/tunes/statuses/{sha}","languages_url":"https://api.github.com/repos/byronmwong/tunes/languages","stargazers_url":"https://api.github.com/repos/byronmwong/tunes/stargazers","contributors_url":"https://api.github.com/repos/byronmwong/tunes/contributors","subscribers_url":"https://api.github.com/repos/byronmwong/tunes/subscribers","subscription_url":"https://api.github.com/repos/byronmwong/tunes/subscription","commits_url":"https://api.github.com/repos/byronmwong/tunes/commits{/sha}","git_commits_url":"https://api.github.com/repos/byronmwong/tunes/git/commits{/sha}","comments_url":"https://api.github.com/repos/byronmwong/tunes/comments{/number}","issue_comment_url":"https://api.github.com/repos/byronmwong/tunes/issues/comments/{number}","contents_url":"https://api.github.com/repos/byronmwong/tunes/contents/{+path}","compare_url":"https://api.github.com/repos/byronmwong/tunes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/byronmwong/tunes/merges","archive_url":"https://api.github.com/repos/byronmwong/tunes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/byronmwong/tunes/downloads","issues_url":"https://api.github.com/repos/byronmwong/tunes/issues{/number}","pulls_url":"https://api.github.com/repos/byronmwong/tunes/pulls{/number}","milestones_url":"https://api.github.com/repos/byronmwong/tunes/milestones{/number}","notifications_url":"https://api.github.com/repos/byronmwong/tunes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/byronmwong/tunes/labels{/name}","releases_url":"https://api.github.com/repos/byronmwong/tunes/releases{/id}","created_at":"2013-11-06T12:54:47Z","updated_at":"2014-05-18T07:42:19Z","pushed_at":"2014-07-19T23:23:50Z","git_url":"git://github.com/byronmwong/tunes.git","ssh_url":"git@github.com:byronmwong/tunes.git","clone_url":"https://github.com/byronmwong/tunes.git","svn_url":"https://github.com/byronmwong/tunes","homepage":null,"size":757,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/byronmwong/tunes/pulls/24"},"html":{"href":"https://github.com/byronmwong/tunes/pull/24"},"issue":{"href":"https://api.github.com/repos/byronmwong/tunes/issues/24"},"comments":{"href":"https://api.github.com/repos/byronmwong/tunes/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/byronmwong/tunes/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/byronmwong/tunes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/byronmwong/tunes/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/byronmwong/tunes/statuses/cfe9750b4ae20ee193f41a2e126024a05676153d"}}}}