GitHub PullRequestReviewCommentEvent at 2014-09-19 16:31:50
Repository: loopback-explorer
Actor: bajtos
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/loopback-explorer/pulls/comments/17794688","id":17794688,"diff_hunk":"@@ -164,6 +164,15 @@ describe('model-helper', function() {\n       expect(defs).has.property('Model5');\n       expect(defs).has.property('Model6');\n     });\n+\n+    it('should work if no related models are detected', function() {","path":"test/model-helper.test.js","position":5,"original_position":5,"commit_id":"e965869bf4406d6158bee57a5953d40e08d8c7a8","original_commit_id":"e965869bf4406d6158bee57a5953d40e08d8c7a8","user":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=2","gravatar_id":"281ce53f409dd5f1967594d0e5c0db7c","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"body":"The test name is misleading. I thought `Array.prototype.customFunc` was the important part of the test scenario?","created_at":"2014-09-19T16:31:50Z","updated_at":"2014-09-19T16:31:50Z","html_url":"https://github.com/strongloop/loopback-explorer/pull/50#discussion_r17794688","pull_request_url":"https://api.github.com/repos/strongloop/loopback-explorer/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-explorer/pulls/comments/17794688"},"html":{"href":"https://github.com/strongloop/loopback-explorer/pull/50#discussion_r17794688"},"pull_request":{"href":"https://api.github.com/repos/strongloop/loopback-explorer/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/loopback-explorer/pulls/50","id":21505517,"html_url":"https://github.com/strongloop/loopback-explorer/pull/50","diff_url":"https://github.com/strongloop/loopback-explorer/pull/50.diff","patch_url":"https://github.com/strongloop/loopback-explorer/pull/50.patch","issue_url":"https://api.github.com/repos/strongloop/loopback-explorer/issues/50","number":50,"state":"open","locked":false,"title":"Fix how the array of models is iterated","user":{"login":"raymondfeng","id":540892,"avatar_url":"https://avatars.githubusercontent.com/u/540892?v=2","gravatar_id":"e23c8f6e25edcc39fd224c0223bd8aba","url":"https://api.github.com/users/raymondfeng","html_url":"https://github.com/raymondfeng","followers_url":"https://api.github.com/users/raymondfeng/followers","following_url":"https://api.github.com/users/raymondfeng/following{/other_user}","gists_url":"https://api.github.com/users/raymondfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/raymondfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raymondfeng/subscriptions","organizations_url":"https://api.github.com/users/raymondfeng/orgs","repos_url":"https://api.github.com/users/raymondfeng/repos","events_url":"https://api.github.com/users/raymondfeng/events{/privacy}","received_events_url":"https://api.github.com/users/raymondfeng/received_events","type":"User","site_admin":false},"body":"/to @bajtos \r\n/cc @dashby3000 \r\n\r\nhttps://github.com/strongloop/loopback-explorer/issues/49","created_at":"2014-09-19T15:39:31Z","updated_at":"2014-09-19T16:31:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87971dfdba7d68243112c6d162e951b8fc2c3fba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/loopback-explorer/pulls/50/commits","review_comments_url":"https://api.github.com/repos/strongloop/loopback-explorer/pulls/50/comments","review_comment_url":"https://api.github.com/repos/strongloop/loopback-explorer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/strongloop/loopback-explorer/issues/50/comments","statuses_url":"https://api.github.com/repos/strongloop/loopback-explorer/statuses/e965869bf4406d6158bee57a5953d40e08d8c7a8","head":{"label":"strongloop:feature/fix-issue-49","ref":"feature/fix-issue-49","sha":"e965869bf4406d6158bee57a5953d40e08d8c7a8","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=2","gravatar_id":"4c9f25755f54f494818279ebab42a6eb","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":14149371,"name":"loopback-explorer","full_name":"strongloop/loopback-explorer","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=2","gravatar_id":"4c9f25755f54f494818279ebab42a6eb","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback-explorer","description":"Browse and test your LoopBack app's APIs","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-explorer","forks_url":"https://api.github.com/repos/strongloop/loopback-explorer/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-explorer/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-explorer/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-explorer/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-explorer/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-explorer/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-explorer/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-explorer/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-explorer/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-explorer/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-explorer/issues/comments/{number}","contents_url":"https://api.github.com/repos/strongloop/loopback-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-explorer/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-explorer/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-explorer/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-explorer/releases{/id}","created_at":"2013-11-05T17:59:05Z","updated_at":"2014-09-05T09:51:20Z","pushed_at":"2014-09-19T15:39:07Z","git_url":"git://github.com/strongloop/loopback-explorer.git","ssh_url":"git@github.com:strongloop/loopback-explorer.git","clone_url":"https://github.com/strongloop/loopback-explorer.git","svn_url":"https://github.com/strongloop/loopback-explorer","homepage":null,"size":1720,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":14,"forks":14,"open_issues":14,"watchers":2,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"4757d89f1098c27ea92e44b059caf3707ce9e24a","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=2","gravatar_id":"4c9f25755f54f494818279ebab42a6eb","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":14149371,"name":"loopback-explorer","full_name":"strongloop/loopback-explorer","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=2","gravatar_id":"4c9f25755f54f494818279ebab42a6eb","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback-explorer","description":"Browse and test your LoopBack app's APIs","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-explorer","forks_url":"https://api.github.com/repos/strongloop/loopback-explorer/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-explorer/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-explorer/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-explorer/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-explorer/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-explorer/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-explorer/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-explorer/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-explorer/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-explorer/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-explorer/issues/comments/{number}","contents_url":"https://api.github.com/repos/strongloop/loopback-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-explorer/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-explorer/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-explorer/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-explorer/releases{/id}","created_at":"2013-11-05T17:59:05Z","updated_at":"2014-09-05T09:51:20Z","pushed_at":"2014-09-19T15:39:07Z","git_url":"git://github.com/strongloop/loopback-explorer.git","ssh_url":"git@github.com:strongloop/loopback-explorer.git","clone_url":"https://github.com/strongloop/loopback-explorer.git","svn_url":"https://github.com/strongloop/loopback-explorer","homepage":null,"size":1720,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":14,"forks":14,"open_issues":14,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-explorer/pulls/50"},"html":{"href":"https://github.com/strongloop/loopback-explorer/pull/50"},"issue":{"href":"https://api.github.com/repos/strongloop/loopback-explorer/issues/50"},"comments":{"href":"https://api.github.com/repos/strongloop/loopback-explorer/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/loopback-explorer/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/loopback-explorer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/strongloop/loopback-explorer/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/loopback-explorer/statuses/e965869bf4406d6158bee57a5953d40e08d8c7a8"}}}}