GitHub PullRequestReviewCommentEvent at 2014-07-07 16:43:42
Repository: marionette-device-host
Actor: eliperelman
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls/comments/14607081","id":14607081,"diff_hunk":"@@ -31,12 +27,68 @@ Host.metadata = Object.freeze({\n   host: 'device'\n });\n \n+Host.firstRun = true;\n+\n Host.prototype = {\n+  /**\n+   * Set the options on the Host object, using defaults for missing values\n+   *\n+   * @param {Object} [options] settings provided by caller.\n+   */\n+  setOptions: function(options) {\n+    this.options = _.merge({\n+      host: 'localhost',\n+      port: DEFAULT_PORT\n+    }, this.options, options);\n+  },\n+\n+  /**\n+   * Restart the B2G process and trigger a callback once complete\n+   *\n+   * @param {Function} callback.\n+   */\n+  restartB2G: function(callback) {\n+    var command = 'adb shell stop b2g && adb shell start b2g && sleep 2';","path":"index.js","position":50,"original_position":50,"commit_id":"a529a0843084a22b2a683b0f05c93cb34a609570","original_commit_id":"a529a0843084a22b2a683b0f05c93cb34a609570","user":{"login":"eliperelman","id":285899,"avatar_url":"https://avatars.githubusercontent.com/u/285899?","gravatar_id":"8dc4af17fcbc9d8c1919462680e46c5a","url":"https://api.github.com/users/eliperelman","html_url":"https://github.com/eliperelman","followers_url":"https://api.github.com/users/eliperelman/followers","following_url":"https://api.github.com/users/eliperelman/following{/other_user}","gists_url":"https://api.github.com/users/eliperelman/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperelman/subscriptions","organizations_url":"https://api.github.com/users/eliperelman/orgs","repos_url":"https://api.github.com/users/eliperelman/repos","events_url":"https://api.github.com/users/eliperelman/events{/privacy}","received_events_url":"https://api.github.com/users/eliperelman/received_events","type":"User","site_admin":false},"body":"I think we can address that when the time comes.","created_at":"2014-07-07T16:43:42Z","updated_at":"2014-07-07T16:43:42Z","html_url":"https://github.com/mozilla-b2g/marionette-device-host/pull/1#discussion_r14607081","pull_request_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls/comments/14607081"},"html":{"href":"https://github.com/mozilla-b2g/marionette-device-host/pull/1#discussion_r14607081"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls/1","id":17897490,"html_url":"https://github.com/mozilla-b2g/marionette-device-host/pull/1","diff_url":"https://github.com/mozilla-b2g/marionette-device-host/pull/1.diff","patch_url":"https://github.com/mozilla-b2g/marionette-device-host/pull/1.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/issues/1","number":1,"state":"open","title":"Wait for adb port to be available before starting","user":{"login":"eliperelman","id":285899,"avatar_url":"https://avatars.githubusercontent.com/u/285899?","gravatar_id":"8dc4af17fcbc9d8c1919462680e46c5a","url":"https://api.github.com/users/eliperelman","html_url":"https://github.com/eliperelman","followers_url":"https://api.github.com/users/eliperelman/followers","following_url":"https://api.github.com/users/eliperelman/following{/other_user}","gists_url":"https://api.github.com/users/eliperelman/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperelman/subscriptions","organizations_url":"https://api.github.com/users/eliperelman/orgs","repos_url":"https://api.github.com/users/eliperelman/repos","events_url":"https://api.github.com/users/eliperelman/events{/privacy}","received_events_url":"https://api.github.com/users/eliperelman/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-02T16:42:53Z","updated_at":"2014-07-07T16:43:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"846d5b543d6518c235a7f08bc579f00a7b515f87","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/issues/1/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/statuses/a529a0843084a22b2a683b0f05c93cb34a609570","head":{"label":"eliperelman:bug-1033402-wait-on-port-before-starting","ref":"bug-1033402-wait-on-port-before-starting","sha":"a529a0843084a22b2a683b0f05c93cb34a609570","user":{"login":"eliperelman","id":285899,"avatar_url":"https://avatars.githubusercontent.com/u/285899?","gravatar_id":"8dc4af17fcbc9d8c1919462680e46c5a","url":"https://api.github.com/users/eliperelman","html_url":"https://github.com/eliperelman","followers_url":"https://api.github.com/users/eliperelman/followers","following_url":"https://api.github.com/users/eliperelman/following{/other_user}","gists_url":"https://api.github.com/users/eliperelman/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperelman/subscriptions","organizations_url":"https://api.github.com/users/eliperelman/orgs","repos_url":"https://api.github.com/users/eliperelman/repos","events_url":"https://api.github.com/users/eliperelman/events{/privacy}","received_events_url":"https://api.github.com/users/eliperelman/received_events","type":"User","site_admin":false},"repo":{"id":21431776,"name":"marionette-device-host","full_name":"eliperelman/marionette-device-host","owner":{"login":"eliperelman","id":285899,"avatar_url":"https://avatars.githubusercontent.com/u/285899?","gravatar_id":"8dc4af17fcbc9d8c1919462680e46c5a","url":"https://api.github.com/users/eliperelman","html_url":"https://github.com/eliperelman","followers_url":"https://api.github.com/users/eliperelman/followers","following_url":"https://api.github.com/users/eliperelman/following{/other_user}","gists_url":"https://api.github.com/users/eliperelman/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperelman/subscriptions","organizations_url":"https://api.github.com/users/eliperelman/orgs","repos_url":"https://api.github.com/users/eliperelman/repos","events_url":"https://api.github.com/users/eliperelman/events{/privacy}","received_events_url":"https://api.github.com/users/eliperelman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eliperelman/marionette-device-host","description":"Marionette JS device host","fork":true,"url":"https://api.github.com/repos/eliperelman/marionette-device-host","forks_url":"https://api.github.com/repos/eliperelman/marionette-device-host/forks","keys_url":"https://api.github.com/repos/eliperelman/marionette-device-host/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eliperelman/marionette-device-host/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eliperelman/marionette-device-host/teams","hooks_url":"https://api.github.com/repos/eliperelman/marionette-device-host/hooks","issue_events_url":"https://api.github.com/repos/eliperelman/marionette-device-host/issues/events{/number}","events_url":"https://api.github.com/repos/eliperelman/marionette-device-host/events","assignees_url":"https://api.github.com/repos/eliperelman/marionette-device-host/assignees{/user}","branches_url":"https://api.github.com/repos/eliperelman/marionette-device-host/branches{/branch}","tags_url":"https://api.github.com/repos/eliperelman/marionette-device-host/tags","blobs_url":"https://api.github.com/repos/eliperelman/marionette-device-host/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eliperelman/marionette-device-host/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eliperelman/marionette-device-host/git/refs{/sha}","trees_url":"https://api.github.com/repos/eliperelman/marionette-device-host/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eliperelman/marionette-device-host/statuses/{sha}","languages_url":"https://api.github.com/repos/eliperelman/marionette-device-host/languages","stargazers_url":"https://api.github.com/repos/eliperelman/marionette-device-host/stargazers","contributors_url":"https://api.github.com/repos/eliperelman/marionette-device-host/contributors","subscribers_url":"https://api.github.com/repos/eliperelman/marionette-device-host/subscribers","subscription_url":"https://api.github.com/repos/eliperelman/marionette-device-host/subscription","commits_url":"https://api.github.com/repos/eliperelman/marionette-device-host/commits{/sha}","git_commits_url":"https://api.github.com/repos/eliperelman/marionette-device-host/git/commits{/sha}","comments_url":"https://api.github.com/repos/eliperelman/marionette-device-host/comments{/number}","issue_comment_url":"https://api.github.com/repos/eliperelman/marionette-device-host/issues/comments/{number}","contents_url":"https://api.github.com/repos/eliperelman/marionette-device-host/contents/{+path}","compare_url":"https://api.github.com/repos/eliperelman/marionette-device-host/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eliperelman/marionette-device-host/merges","archive_url":"https://api.github.com/repos/eliperelman/marionette-device-host/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eliperelman/marionette-device-host/downloads","issues_url":"https://api.github.com/repos/eliperelman/marionette-device-host/issues{/number}","pulls_url":"https://api.github.com/repos/eliperelman/marionette-device-host/pulls{/number}","milestones_url":"https://api.github.com/repos/eliperelman/marionette-device-host/milestones{/number}","notifications_url":"https://api.github.com/repos/eliperelman/marionette-device-host/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eliperelman/marionette-device-host/labels{/name}","releases_url":"https://api.github.com/repos/eliperelman/marionette-device-host/releases{/id}","created_at":"2014-07-02T16:41:12Z","updated_at":"2014-01-25T04:32:36Z","pushed_at":"2014-07-03T18:42:07Z","git_url":"git://github.com/eliperelman/marionette-device-host.git","ssh_url":"git@github.com:eliperelman/marionette-device-host.git","clone_url":"https://github.com/eliperelman/marionette-device-host.git","svn_url":"https://github.com/eliperelman/marionette-device-host","homepage":null,"size":112,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"ca177d437d7a061f177b4800d550c7ef2767febb","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":13756062,"name":"marionette-device-host","full_name":"mozilla-b2g/marionette-device-host","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?","gravatar_id":"b1de11f7d6ddaf7b9d527281297c2ee1","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/marionette-device-host","description":"Marionette JS device host","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host","forks_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/releases{/id}","created_at":"2013-10-21T21:43:38Z","updated_at":"2014-01-25T04:32:36Z","pushed_at":"2014-01-25T04:32:36Z","git_url":"git://github.com/mozilla-b2g/marionette-device-host.git","ssh_url":"git@github.com:mozilla-b2g/marionette-device-host.git","clone_url":"https://github.com/mozilla-b2g/marionette-device-host.git","svn_url":"https://github.com/mozilla-b2g/marionette-device-host","homepage":null,"size":151,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls/1"},"html":{"href":"https://github.com/mozilla-b2g/marionette-device-host/pull/1"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/issues/1"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-device-host/statuses/a529a0843084a22b2a683b0f05c93cb34a609570"}}}}