GitHub PullRequestReviewCommentEvent at 2014-03-04 13:14:55
Repository: wiredtiger
Actor: keithbostic
Payload: {"comment":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/10253511","id":10253511,"diff_hunk":"@@ -184,6 +184,20 @@ struct __wt_ovfl_txnc {\n };\n \n /*\n+ * WT_UPD_SKIPPED --\n+ *\tWhen a page is reconciled, there may be updates that cannot be written.\n+ * Those updates are copied and then restored when the page is re-instantiated.\n+ */\n+struct __wt_upd_skipped {\n+\t/*\n+\t * Skipped updates are based on either a WT_INSERT reference or a\n+\t * row-store leaf page WT_UPDATE list.\n+\t */\n+\tvoid\t*head;\t\t/* (WT_UPDATE **) or (WT_INSERT *) */\n+\tuint8_t\t is_insert;\t/* (WT_INSERT *) */","path":"src/include/btmem.h","position":14,"original_position":14,"commit_id":"773f57b85c1a918e16c136716289ae2f25b26ee9","original_commit_id":"773f57b85c1a918e16c136716289ae2f25b26ee9","user":{"login":"keithbostic","id":1393186,"avatar_url":"https://avatars.githubusercontent.com/u/1393186","gravatar_id":"fcd0e0cc1862ab5b7e70bc6f4144a60d","url":"https://api.github.com/users/keithbostic","html_url":"https://github.com/keithbostic","followers_url":"https://api.github.com/users/keithbostic/followers","following_url":"https://api.github.com/users/keithbostic/following{/other_user}","gists_url":"https://api.github.com/users/keithbostic/gists{/gist_id}","starred_url":"https://api.github.com/users/keithbostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithbostic/subscriptions","organizations_url":"https://api.github.com/users/keithbostic/orgs","repos_url":"https://api.github.com/users/keithbostic/repos","events_url":"https://api.github.com/users/keithbostic/events{/privacy}","received_events_url":"https://api.github.com/users/keithbostic/received_events","type":"User","site_admin":false},"body":"I will do something to fix this.  I've been ignoring space issues in WT_PAGE_MODIFY, mostly because I wasn't sure we'd ever use this branch.   The split changes have really grown WT_PAGE_MODIFY, from 80B to 128B, we need to figure out ways to shrink it back to something smaller.","created_at":"2014-03-04T13:14:55Z","updated_at":"2014-03-04T13:14:55Z","html_url":"https://github.com/wiredtiger/wiredtiger/pull/890#discussion_r10253511","pull_request_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/890","_links":{"self":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/10253511"},"html":{"href":"https://github.com/wiredtiger/wiredtiger/pull/890#discussion_r10253511"},"pull_request":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/890"}}}}