GitHub PullRequestReviewCommentEvent at 2014-11-04 17:07:34
Repository: docker
Actor: thaJeztah
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/19817556","id":19817556,"diff_hunk":"@@ -1541,6 +1541,138 @@ Status Codes:\n -   **201** – no error\n -   **404** – no such exec instance\n \n+### Create a volume\n+\n+`POST /volumes`\n+\n+Create a new volume\n+\n+**Example request**:\n+\n+        POST /containers HTTP/1.1\n+        Content-Type: application/json\n+\n+        {\n+         \"path\":\"\",\n+         \"name\":\"\",\n+         \"mode\":\"rw\",\n+        }\n+\n+**Example response**:\n+\n+        HTTP/1.1 201 Created\n+        Content-Type: application/json\n+\n+        {\n+             \"Name\":\"morose_torvalds\"\n+        }\n+\n+Json Parameters:\n+\n+-   **path** Specify the host path of the volume, as a string. Leave empty to\n+      have Docker automatically create this path.\n+-   **name** Specify a name for the new volume, as a string.  Leave empty to\n+      Docker automatically generate a name.\n+-   **mode** Set the write mode of the container, supports \"ro\", and \"rw\".\n+\n+Status Codes:\n+\n+-   **201** – Created\n+\n+###  Delete a volume\n+\n+`DELETE /volumes/(id)`\n+\n+Delete a volume\n+\n+**Example request**:\n+\n+        DELETE /containers HTTP/1.1","path":"docs/sources/reference/api/docker_remote_api_v1.16.md","position":50,"original_position":50,"commit_id":"ee4f631713776c5ead7d4c1ddee1c5193c21b5ff","original_commit_id":"ee4f631713776c5ead7d4c1ddee1c5193c21b5ff","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=2","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"yup, again","created_at":"2014-11-04T17:07:34Z","updated_at":"2014-11-04T17:07:34Z","html_url":"https://github.com/docker/docker/pull/8484#discussion_r19817556","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/8484","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/19817556"},"html":{"href":"https://github.com/docker/docker/pull/8484#discussion_r19817556"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/8484"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/8484","id":22469183,"html_url":"https://github.com/docker/docker/pull/8484","diff_url":"https://github.com/docker/docker/pull/8484.diff","patch_url":"https://github.com/docker/docker/pull/8484.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/8484","number":8484,"state":"open","locked":false,"title":"Proposal: Add volume ls/inspect/rm/create commands","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=2","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"`docker volumes ls` - list all volumes\r\nCan be used with --filter dangling=true to list volumes not in use\r\n\r\n`docker volumes create` - create volumes\r\nCan set, `--name`, `--path`, `--mode`.  Can also be used with no\r\narguments to have everything auto generated\r\n\r\n`docker volumes rm <volume name>` - Remove a volume\r\nVolumes in use by containers cannot be removed.\r\nBind-mounts cannot be removed. (May want to have a way to remove just\r\nthe bind-mount config. Else this does seem to cause issues with tests)\r\n\r\n`docker volumes inspect <volume name>` - Inspect a volume/get its config\r\nSupports `--format` just like container inspect.\r\n\r\n`docker run` can be used to either call a volume by name as `docker run\r\n-v <volume name>:<mount point>` or with `docker run --volumes-from\r\n<volume alias>:<mount point>[:<mode>]`\r\n`docker run -v <path>` will create a volume with a generated name, just\r\nas `docker volumes create` with no args.\r\n\r\nAll existing APIs/UI will work as normal.\r\nThere is no breakage in these changes.\r\n\r\nImplements Proposal https://github.com/docker/docker/issues/8363","created_at":"2014-10-09T03:06:28Z","updated_at":"2014-11-04T17:07:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e1af0a73520456b943bc6539b704911b9e4ff94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/8484/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/8484/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/docker/issues/8484/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/ee4f631713776c5ead7d4c1ddee1c5193c21b5ff","head":{"label":"cpuguy83:add_volumes_command","ref":"add_volumes_command","sha":"ee4f631713776c5ead7d4c1ddee1c5193c21b5ff","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=2","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"repo":{"id":15300899,"name":"docker","full_name":"cpuguy83/docker","owner":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=2","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpuguy83/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/cpuguy83/docker","forks_url":"https://api.github.com/repos/cpuguy83/docker/forks","keys_url":"https://api.github.com/repos/cpuguy83/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpuguy83/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpuguy83/docker/teams","hooks_url":"https://api.github.com/repos/cpuguy83/docker/hooks","issue_events_url":"https://api.github.com/repos/cpuguy83/docker/issues/events{/number}","events_url":"https://api.github.com/repos/cpuguy83/docker/events","assignees_url":"https://api.github.com/repos/cpuguy83/docker/assignees{/user}","branches_url":"https://api.github.com/repos/cpuguy83/docker/branches{/branch}","tags_url":"https://api.github.com/repos/cpuguy83/docker/tags","blobs_url":"https://api.github.com/repos/cpuguy83/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpuguy83/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpuguy83/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpuguy83/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpuguy83/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/cpuguy83/docker/languages","stargazers_url":"https://api.github.com/repos/cpuguy83/docker/stargazers","contributors_url":"https://api.github.com/repos/cpuguy83/docker/contributors","subscribers_url":"https://api.github.com/repos/cpuguy83/docker/subscribers","subscription_url":"https://api.github.com/repos/cpuguy83/docker/subscription","commits_url":"https://api.github.com/repos/cpuguy83/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpuguy83/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpuguy83/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpuguy83/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/cpuguy83/docker/contents/{+path}","compare_url":"https://api.github.com/repos/cpuguy83/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpuguy83/docker/merges","archive_url":"https://api.github.com/repos/cpuguy83/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpuguy83/docker/downloads","issues_url":"https://api.github.com/repos/cpuguy83/docker/issues{/number}","pulls_url":"https://api.github.com/repos/cpuguy83/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/cpuguy83/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/cpuguy83/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpuguy83/docker/labels{/name}","releases_url":"https://api.github.com/repos/cpuguy83/docker/releases{/id}","created_at":"2013-12-19T02:58:40Z","updated_at":"2014-06-25T21:00:46Z","pushed_at":"2014-11-04T02:49:57Z","git_url":"git://github.com/cpuguy83/docker.git","ssh_url":"git@github.com:cpuguy83/docker.git","clone_url":"https://github.com/cpuguy83/docker.git","svn_url":"https://github.com/cpuguy83/docker","homepage":"http://www.docker.io","size":40032,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"5b03a21963931f917297e52cb17a62680f1c2a6e","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=2","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=2","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2014-11-04T16:02:00Z","pushed_at":"2014-11-04T17:02:40Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":155036,"stargazers_count":16307,"watchers_count":16307,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3196,"mirror_url":null,"open_issues_count":864,"forks":3196,"open_issues":864,"watchers":16307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/8484"},"html":{"href":"https://github.com/docker/docker/pull/8484"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/8484"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/8484/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/8484/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/8484/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/ee4f631713776c5ead7d4c1ddee1c5193c21b5ff"}}}}