GitHub PullRequestReviewCommentEvent at 2014-08-22 23:57:07
Repository: courseography
Actor: david-yz-liu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls/comments/16626738","id":16626738,"diff_hunk":"@@ -0,0 +1,120 @@\n+/*global $*/\n+\n+/**\n+ * Generates the duplex timetable grid.\n+ */\n+function generateGrid() {\n+    'use strict';\n+\n+    var rowDiv = $('<div></div>').addClass('row');\n+    var timetableContainerDivFall = createTimeTableContainer();\n+    var timetableContainerDivSpring = createTimeTableContainer();\n+    var timetableTableFall = createTimeTable('F');\n+    var fallCaption = createCaption('Fall');\n+    var fallThead = createThead();\n+    var timetableTableSpring = createTimeTable('S');\n+    var springCaption = createCaption('Spring');\n+    var springThead = createThead();\n+\n+    timetableTableFall.append(fallCaption)\n+        .append(fallThead);\n+    timetableTableSpring.append(springCaption)\n+        .append(springThead);\n+\n+    appendHeaders(fallThead, springThead);\n+    appendTableRows(timetableTableFall, timetableTableSpring);\n+\n+    timetableContainerDivFall.append(timetableTableFall);\n+    timetableContainerDivSpring.append(timetableTableSpring);\n+    rowDiv.append(timetableContainerDivFall)\n+        .append(timetableContainerDivSpring)\n+        .insertBefore($('#info'));\n+}\n+\n+\n+function createThead() {\n+    'use strict';\n+\n+    return $('<thead></thead>');\n+}\n+\n+\n+function createCaption(name) {\n+    'use strict';\n+\n+    return $('<caption></caption>').html(name);\n+}\n+\n+\n+function createTimeTable(suffix) {\n+    'use strict';\n+\n+    return $('<table></table>')\n+        .addClass('timetable table')\n+        .attr('id', 'timetable-' + suffix);\n+}\n+\n+\n+function createTimeTableContainer() {\n+    'use strict';\n+\n+    return $('<div></div>')\n+        .addClass('col-md-6 col-xs-12 timetable-container');\n+}\n+\n+\n+function appendHeaders(fallThead, springThead) {\n+    'use strict';\n+\n+    var days = ['Mon', 'Tue', 'Wed', 'Thu', 'Fri'];\n+    fallThead.append($('<th></th>')\n+        .attr('id', 'no-border')\n+        .addClass('timetable-time'));\n+\n+    for (var j = 0; j < 5; j++) {\n+        fallThead.append($('<th></th>').html(days[j]));\n+        springThead.append($('<th></th>').html(days[j]));\n+    }\n+\n+    springThead.append($('<th></th>')\n+        .attr('id', 'no-border')\n+        .addClass('timetable-time'));\n+}\n+\n+\n+function appendTableRows(timetableTableFall, timetableTableSpring) {\n+    'use strict';\n+\n+    for (var i = 9; i < 22; i++) {\n+        var trFall = $('<tr></tr>');\n+        var trSpring = $('<tr></tr>');\n+        appendTableData(trFall, trSpring, i);\n+        timetableTableSpring.append(trSpring);\n+        timetableTableFall.append(trFall);\n+    }\n+}\n+\n+\n+function appendTableData(trFall, trSpring, time) {\n+    'use strict';\n+\n+    var weekPrefixArray = ['M', 'T', 'W', 'R', 'F'];\n+\n+    var adjustedTime = time === 12 ? 12 : time % 12;\n+    trFall.append($('<td></td>').addClass('timetable-time').html(adjustedTime));\n+\n+    for (var k = 0; k < 5; k++) {\n+        trFall.append($('<td></td>')\n+            .attr('id', weekPrefixArray[k] + time + 'F')\n+            .attr('in-conflict', 'false')\n+            .attr('satisfied', 'true')\n+            .addClass('timetable-cell'));\n+        trSpring.append($('<td></td>')\n+            .attr('id', weekPrefixArray[k] + time + 'S')\n+            .attr('in-conflict', 'false')\n+            .attr('satisfied', 'true')\n+            .addClass('timetable-cell'));\n+    }\n+\n+    trSpring.append($('<td></td>').addClass('timetable-time').html(time));","path":"js/grid/generate_grid.js","position":119,"original_position":119,"commit_id":"bd834b464d912e326e6419b589c7b77f36cce641","original_commit_id":"bd834b464d912e326e6419b589c7b77f36cce641","user":{"login":"david-yz-liu","id":3333115,"avatar_url":"https://avatars.githubusercontent.com/u/3333115?v=2","gravatar_id":"a4ce96e30f6ce10f5935e96666fc9f54","url":"https://api.github.com/users/david-yz-liu","html_url":"https://github.com/david-yz-liu","followers_url":"https://api.github.com/users/david-yz-liu/followers","following_url":"https://api.github.com/users/david-yz-liu/following{/other_user}","gists_url":"https://api.github.com/users/david-yz-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/david-yz-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-yz-liu/subscriptions","organizations_url":"https://api.github.com/users/david-yz-liu/orgs","repos_url":"https://api.github.com/users/david-yz-liu/repos","events_url":"https://api.github.com/users/david-yz-liu/events{/privacy}","received_events_url":"https://api.github.com/users/david-yz-liu/received_events","type":"User","site_admin":false},"body":"Is the \"adjustedTime\" bug fixed in another branch? If not, just fix it here.","created_at":"2014-08-22T23:57:07Z","updated_at":"2014-08-22T23:57:07Z","html_url":"https://github.com/Ian-Stewart-Binks/courseography/pull/159#discussion_r16626738","pull_request_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls/159","_links":{"self":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls/comments/16626738"},"html":{"href":"https://github.com/Ian-Stewart-Binks/courseography/pull/159#discussion_r16626738"},"pull_request":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls/159","id":19915763,"html_url":"https://github.com/Ian-Stewart-Binks/courseography/pull/159","diff_url":"https://github.com/Ian-Stewart-Binks/courseography/pull/159.diff","patch_url":"https://github.com/Ian-Stewart-Binks/courseography/pull/159.patch","issue_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/issues/159","number":159,"state":"open","locked":false,"title":"Refactoring","user":{"login":"david-yz-liu","id":3333115,"avatar_url":"https://avatars.githubusercontent.com/u/3333115?v=2","gravatar_id":"a4ce96e30f6ce10f5935e96666fc9f54","url":"https://api.github.com/users/david-yz-liu","html_url":"https://github.com/david-yz-liu","followers_url":"https://api.github.com/users/david-yz-liu/followers","following_url":"https://api.github.com/users/david-yz-liu/following{/other_user}","gists_url":"https://api.github.com/users/david-yz-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/david-yz-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-yz-liu/subscriptions","organizations_url":"https://api.github.com/users/david-yz-liu/orgs","repos_url":"https://api.github.com/users/david-yz-liu/repos","events_url":"https://api.github.com/users/david-yz-liu/events{/privacy}","received_events_url":"https://api.github.com/users/david-yz-liu/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-18T12:56:54Z","updated_at":"2014-08-22T23:57:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42db0c1acf0b2b2cb8ccfb1e36b896d97427156e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls/159/commits","review_comments_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls/159/comments","review_comment_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/issues/159/comments","statuses_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/statuses/bd834b464d912e326e6419b589c7b77f36cce641","head":{"label":"Ian-Stewart-Binks:refactoring","ref":"refactoring","sha":"bd834b464d912e326e6419b589c7b77f36cce641","user":{"login":"Ian-Stewart-Binks","id":6301000,"avatar_url":"https://avatars.githubusercontent.com/u/6301000?v=2","gravatar_id":"eac791af268a46088c35384de6ba00ab","url":"https://api.github.com/users/Ian-Stewart-Binks","html_url":"https://github.com/Ian-Stewart-Binks","followers_url":"https://api.github.com/users/Ian-Stewart-Binks/followers","following_url":"https://api.github.com/users/Ian-Stewart-Binks/following{/other_user}","gists_url":"https://api.github.com/users/Ian-Stewart-Binks/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian-Stewart-Binks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian-Stewart-Binks/subscriptions","organizations_url":"https://api.github.com/users/Ian-Stewart-Binks/orgs","repos_url":"https://api.github.com/users/Ian-Stewart-Binks/repos","events_url":"https://api.github.com/users/Ian-Stewart-Binks/events{/privacy}","received_events_url":"https://api.github.com/users/Ian-Stewart-Binks/received_events","type":"User","site_admin":false},"repo":{"id":16873349,"name":"courseography","full_name":"Ian-Stewart-Binks/courseography","owner":{"login":"Ian-Stewart-Binks","id":6301000,"avatar_url":"https://avatars.githubusercontent.com/u/6301000?v=2","gravatar_id":"eac791af268a46088c35384de6ba00ab","url":"https://api.github.com/users/Ian-Stewart-Binks","html_url":"https://github.com/Ian-Stewart-Binks","followers_url":"https://api.github.com/users/Ian-Stewart-Binks/followers","following_url":"https://api.github.com/users/Ian-Stewart-Binks/following{/other_user}","gists_url":"https://api.github.com/users/Ian-Stewart-Binks/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian-Stewart-Binks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian-Stewart-Binks/subscriptions","organizations_url":"https://api.github.com/users/Ian-Stewart-Binks/orgs","repos_url":"https://api.github.com/users/Ian-Stewart-Binks/repos","events_url":"https://api.github.com/users/Ian-Stewart-Binks/events{/privacy}","received_events_url":"https://api.github.com/users/Ian-Stewart-Binks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ian-Stewart-Binks/courseography","description":"Courseography is a tool created by David Liu and Ian Stewart-Binks to guide students through their undergraduate computer science careers.","fork":false,"url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography","forks_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/forks","keys_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/teams","hooks_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/hooks","issue_events_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/issues/events{/number}","events_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/events","assignees_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/assignees{/user}","branches_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/branches{/branch}","tags_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/tags","blobs_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/statuses/{sha}","languages_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/languages","stargazers_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/stargazers","contributors_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/contributors","subscribers_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/subscribers","subscription_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/subscription","commits_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/issues/comments/{number}","contents_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/contents/{+path}","compare_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/merges","archive_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/downloads","issues_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/issues{/number}","pulls_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls{/number}","milestones_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/milestones{/number}","notifications_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/labels{/name}","releases_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/releases{/id}","created_at":"2014-02-15T22:32:22Z","updated_at":"2014-08-11T22:43:06Z","pushed_at":"2014-08-19T22:00:09Z","git_url":"git://github.com/Ian-Stewart-Binks/courseography.git","ssh_url":"git@github.com:Ian-Stewart-Binks/courseography.git","clone_url":"https://github.com/Ian-Stewart-Binks/courseography.git","svn_url":"https://github.com/Ian-Stewart-Binks/courseography","homepage":"","size":9469,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":21,"forks":4,"open_issues":21,"watchers":2,"default_branch":"master"}},"base":{"label":"Ian-Stewart-Binks:master","ref":"master","sha":"f7a70452f495d409ab687755b89d0adba8cd6731","user":{"login":"Ian-Stewart-Binks","id":6301000,"avatar_url":"https://avatars.githubusercontent.com/u/6301000?v=2","gravatar_id":"eac791af268a46088c35384de6ba00ab","url":"https://api.github.com/users/Ian-Stewart-Binks","html_url":"https://github.com/Ian-Stewart-Binks","followers_url":"https://api.github.com/users/Ian-Stewart-Binks/followers","following_url":"https://api.github.com/users/Ian-Stewart-Binks/following{/other_user}","gists_url":"https://api.github.com/users/Ian-Stewart-Binks/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian-Stewart-Binks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian-Stewart-Binks/subscriptions","organizations_url":"https://api.github.com/users/Ian-Stewart-Binks/orgs","repos_url":"https://api.github.com/users/Ian-Stewart-Binks/repos","events_url":"https://api.github.com/users/Ian-Stewart-Binks/events{/privacy}","received_events_url":"https://api.github.com/users/Ian-Stewart-Binks/received_events","type":"User","site_admin":false},"repo":{"id":16873349,"name":"courseography","full_name":"Ian-Stewart-Binks/courseography","owner":{"login":"Ian-Stewart-Binks","id":6301000,"avatar_url":"https://avatars.githubusercontent.com/u/6301000?v=2","gravatar_id":"eac791af268a46088c35384de6ba00ab","url":"https://api.github.com/users/Ian-Stewart-Binks","html_url":"https://github.com/Ian-Stewart-Binks","followers_url":"https://api.github.com/users/Ian-Stewart-Binks/followers","following_url":"https://api.github.com/users/Ian-Stewart-Binks/following{/other_user}","gists_url":"https://api.github.com/users/Ian-Stewart-Binks/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian-Stewart-Binks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian-Stewart-Binks/subscriptions","organizations_url":"https://api.github.com/users/Ian-Stewart-Binks/orgs","repos_url":"https://api.github.com/users/Ian-Stewart-Binks/repos","events_url":"https://api.github.com/users/Ian-Stewart-Binks/events{/privacy}","received_events_url":"https://api.github.com/users/Ian-Stewart-Binks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ian-Stewart-Binks/courseography","description":"Courseography is a tool created by David Liu and Ian Stewart-Binks to guide students through their undergraduate computer science careers.","fork":false,"url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography","forks_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/forks","keys_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/teams","hooks_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/hooks","issue_events_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/issues/events{/number}","events_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/events","assignees_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/assignees{/user}","branches_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/branches{/branch}","tags_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/tags","blobs_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/statuses/{sha}","languages_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/languages","stargazers_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/stargazers","contributors_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/contributors","subscribers_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/subscribers","subscription_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/subscription","commits_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/issues/comments/{number}","contents_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/contents/{+path}","compare_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/merges","archive_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/downloads","issues_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/issues{/number}","pulls_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls{/number}","milestones_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/milestones{/number}","notifications_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/labels{/name}","releases_url":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/releases{/id}","created_at":"2014-02-15T22:32:22Z","updated_at":"2014-08-11T22:43:06Z","pushed_at":"2014-08-19T22:00:09Z","git_url":"git://github.com/Ian-Stewart-Binks/courseography.git","ssh_url":"git@github.com:Ian-Stewart-Binks/courseography.git","clone_url":"https://github.com/Ian-Stewart-Binks/courseography.git","svn_url":"https://github.com/Ian-Stewart-Binks/courseography","homepage":"","size":9469,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":21,"forks":4,"open_issues":21,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls/159"},"html":{"href":"https://github.com/Ian-Stewart-Binks/courseography/pull/159"},"issue":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/issues/159"},"comments":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/Ian-Stewart-Binks/courseography/statuses/bd834b464d912e326e6419b589c7b77f36cce641"}}}}