GitHub PullRequestEvent at 2014-09-15 08:32:32
Repository: nixpkgs
Actor: wkennington
Payload: {"action":"closed","number":3654,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3654","id":19908065,"html_url":"https://github.com/NixOS/nixpkgs/pull/3654","diff_url":"https://github.com/NixOS/nixpkgs/pull/3654.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/3654.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/3654","number":3654,"state":"closed","locked":false,"title":"gcc-wrapper: Correctly handle response files.","user":{"login":"aszlig","id":192147,"avatar_url":"https://avatars.githubusercontent.com/u/192147?v=2","gravatar_id":"4f329fab21c0db51b5f79c4ccbe44b47","url":"https://api.github.com/users/aszlig","html_url":"https://github.com/aszlig","followers_url":"https://api.github.com/users/aszlig/followers","following_url":"https://api.github.com/users/aszlig/following{/other_user}","gists_url":"https://api.github.com/users/aszlig/gists{/gist_id}","starred_url":"https://api.github.com/users/aszlig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aszlig/subscriptions","organizations_url":"https://api.github.com/users/aszlig/orgs","repos_url":"https://api.github.com/users/aszlig/repos","events_url":"https://api.github.com/users/aszlig/events{/privacy}","received_events_url":"https://api.github.com/users/aszlig/received_events","type":"User","site_admin":false},"body":"This implements handling of so-called [response files](https://gcc.gnu.org/wiki/Response_Files) (available since GCC 4), which allow arguments to be put in a file and the file will be passed back to `gcc` (and other utilities, such as `ld`) via the `@response_file` syntax.\r\n\r\nThe tricky parts here are that the response files can be nested arbitrarily and have it's own escaping rules (which I'm handling by using [expandargv()](https://gcc.gnu.org/onlinedocs/libiberty/Functions.html#index-expandargv-73) from `libiberty`) and the handling of maximum commandline arguments, so we can't simply expand all args from all response files but have to create a temporary response file.\r\n\r\nCc: @edolstra for review.\r\nOf course, this is meant for the staging branch to see how much I broke with this X-D","created_at":"2014-08-18T09:48:30Z","updated_at":"2014-09-15T08:32:32Z","closed_at":"2014-09-15T08:32:32Z","merged_at":null,"merge_commit_sha":"fb8c6637a69e5aee71335d80d359ec47aaad3aea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3654/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3654/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/3654/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/7f0d9fc56b1f7bab72e02a590599b14f9a9d8127","head":{"label":"aszlig:gcc-wrapper-with-response-file","ref":"gcc-wrapper-with-response-file","sha":"7f0d9fc56b1f7bab72e02a590599b14f9a9d8127","user":{"login":"aszlig","id":192147,"avatar_url":"https://avatars.githubusercontent.com/u/192147?v=2","gravatar_id":"4f329fab21c0db51b5f79c4ccbe44b47","url":"https://api.github.com/users/aszlig","html_url":"https://github.com/aszlig","followers_url":"https://api.github.com/users/aszlig/followers","following_url":"https://api.github.com/users/aszlig/following{/other_user}","gists_url":"https://api.github.com/users/aszlig/gists{/gist_id}","starred_url":"https://api.github.com/users/aszlig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aszlig/subscriptions","organizations_url":"https://api.github.com/users/aszlig/orgs","repos_url":"https://api.github.com/users/aszlig/repos","events_url":"https://api.github.com/users/aszlig/events{/privacy}","received_events_url":"https://api.github.com/users/aszlig/received_events","type":"User","site_admin":false},"repo":{"id":4550110,"name":"nixpkgs","full_name":"aszlig/nixpkgs","owner":{"login":"aszlig","id":192147,"avatar_url":"https://avatars.githubusercontent.com/u/192147?v=2","gravatar_id":"4f329fab21c0db51b5f79c4ccbe44b47","url":"https://api.github.com/users/aszlig","html_url":"https://github.com/aszlig","followers_url":"https://api.github.com/users/aszlig/followers","following_url":"https://api.github.com/users/aszlig/following{/other_user}","gists_url":"https://api.github.com/users/aszlig/gists{/gist_id}","starred_url":"https://api.github.com/users/aszlig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aszlig/subscriptions","organizations_url":"https://api.github.com/users/aszlig/orgs","repos_url":"https://api.github.com/users/aszlig/repos","events_url":"https://api.github.com/users/aszlig/events{/privacy}","received_events_url":"https://api.github.com/users/aszlig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aszlig/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/aszlig/nixpkgs","forks_url":"https://api.github.com/repos/aszlig/nixpkgs/forks","keys_url":"https://api.github.com/repos/aszlig/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aszlig/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aszlig/nixpkgs/teams","hooks_url":"https://api.github.com/repos/aszlig/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/aszlig/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/aszlig/nixpkgs/events","assignees_url":"https://api.github.com/repos/aszlig/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/aszlig/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/aszlig/nixpkgs/tags","blobs_url":"https://api.github.com/repos/aszlig/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aszlig/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aszlig/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/aszlig/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aszlig/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/aszlig/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/aszlig/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/aszlig/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/aszlig/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/aszlig/nixpkgs/subscription","commits_url":"https://api.github.com/repos/aszlig/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/aszlig/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/aszlig/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/aszlig/nixpkgs/issues/comments/{number}","contents_url":"https://api.github.com/repos/aszlig/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/aszlig/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aszlig/nixpkgs/merges","archive_url":"https://api.github.com/repos/aszlig/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aszlig/nixpkgs/downloads","issues_url":"https://api.github.com/repos/aszlig/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/aszlig/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/aszlig/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/aszlig/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aszlig/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/aszlig/nixpkgs/releases{/id}","created_at":"2012-06-04T17:31:30Z","updated_at":"2014-06-19T02:12:02Z","pushed_at":"2014-09-08T03:23:18Z","git_url":"git://github.com/aszlig/nixpkgs.git","ssh_url":"git@github.com:aszlig/nixpkgs.git","clone_url":"https://github.com/aszlig/nixpkgs.git","svn_url":"https://github.com/aszlig/nixpkgs","homepage":null,"size":141367,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"NixOS:staging","ref":"staging","sha":"773595540bd3a52476a7c84799e374d086d1c648","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=2","gravatar_id":"ef3a4fb799584882e0f7a40f9aec1b09","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=2","gravatar_id":"ef3a4fb799584882e0f7a40f9aec1b09","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/{number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","created_at":"2012-06-04T02:49:46Z","updated_at":"2014-09-14T08:35:28Z","pushed_at":"2014-09-15T08:32:32Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":247623,"stargazers_count":321,"watchers_count":321,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":423,"mirror_url":null,"open_issues_count":381,"forks":423,"open_issues":381,"watchers":321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3654"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/3654"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/3654"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/3654/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3654/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/3654/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/7f0d9fc56b1f7bab72e02a590599b14f9a9d8127"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":0,"commits":6,"additions":130,"deletions":7,"changed_files":6}}