GitHub PullRequestReviewCommentEvent at 2014-11-14 16:32:32
Repository: sale-workflow
Actor: lepistone
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OCA/sale-workflow/pulls/comments/20369168","id":20369168,"diff_hunk":"@@ -99,16 +99,17 @@ def test_all_draft_orders(self):\n         order_set.test_exceptions()\n         return True\n \n-    @api.one\n+    @api.multi\n     def _popup_exceptions(self):\n-        model_data_obj = self.env['ir.model.data']\n-        list_obj = self.env['sale.exception.confirm']\n-        list_id = (list_obj\n-                   .with_context(active_id=self.ids[0],\n-                                 active_ids=self.ids)\n-                   .create({}))\n-        view_id = model_data_obj.get_object_reference(\n+        ModelData = self.env['ir.model.data']\n+        Wizard = self.env['sale.exception.confirm']","path":"sale_exceptions/sale.py","position":15,"original_position":15,"commit_id":"e5c445ced824267b7cf4a1656cab65912023ea7c","original_commit_id":"e5c445ced824267b7cf4a1656cab65912023ea7c","user":{"login":"lepistone","id":1314778,"avatar_url":"https://avatars.githubusercontent.com/u/1314778?v=3","gravatar_id":"","url":"https://api.github.com/users/lepistone","html_url":"https://github.com/lepistone","followers_url":"https://api.github.com/users/lepistone/followers","following_url":"https://api.github.com/users/lepistone/following{/other_user}","gists_url":"https://api.github.com/users/lepistone/gists{/gist_id}","starred_url":"https://api.github.com/users/lepistone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepistone/subscriptions","organizations_url":"https://api.github.com/users/lepistone/orgs","repos_url":"https://api.github.com/users/lepistone/repos","events_url":"https://api.github.com/users/lepistone/events{/privacy}","received_events_url":"https://api.github.com/users/lepistone/received_events","type":"User","site_admin":false},"body":"Openerp has its own ways, like you never create an instance with `Wizard()` but with `Wizard.create()`, and you don't `import Wizard` but `self.env['my.wizard']`. Still what I call `wizard` deeply is in an instance of what I call `Wizard`.\r\n\r\nBut, ok, thanks for joining in!","created_at":"2014-11-14T16:32:32Z","updated_at":"2014-11-14T16:32:32Z","html_url":"https://github.com/OCA/sale-workflow/pull/60#discussion_r20369168","pull_request_url":"https://api.github.com/repos/OCA/sale-workflow/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/comments/20369168"},"html":{"href":"https://github.com/OCA/sale-workflow/pull/60#discussion_r20369168"},"pull_request":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/sale-workflow/pulls/60","id":24440373,"html_url":"https://github.com/OCA/sale-workflow/pull/60","diff_url":"https://github.com/OCA/sale-workflow/pull/60.diff","patch_url":"https://github.com/OCA/sale-workflow/pull/60.patch","issue_url":"https://api.github.com/repos/OCA/sale-workflow/issues/60","number":60,"state":"open","locked":false,"title":"Fix display exception","user":{"login":"lepistone","id":1314778,"avatar_url":"https://avatars.githubusercontent.com/u/1314778?v=3","gravatar_id":"","url":"https://api.github.com/users/lepistone","html_url":"https://github.com/lepistone","followers_url":"https://api.github.com/users/lepistone/followers","following_url":"https://api.github.com/users/lepistone/following{/other_user}","gists_url":"https://api.github.com/users/lepistone/gists{/gist_id}","starred_url":"https://api.github.com/users/lepistone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepistone/subscriptions","organizations_url":"https://api.github.com/users/lepistone/orgs","repos_url":"https://api.github.com/users/lepistone/repos","events_url":"https://api.github.com/users/lepistone/events{/privacy}","received_events_url":"https://api.github.com/users/lepistone/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-14T13:14:55Z","updated_at":"2014-11-14T16:32:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed70527a6cb745e9df4a07a2b0a5d635e84e4ef0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OCA/sale-workflow/pulls/60/commits","review_comments_url":"https://api.github.com/repos/OCA/sale-workflow/pulls/60/comments","review_comment_url":"https://api.github.com/repos/OCA/sale-workflow/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OCA/sale-workflow/issues/60/comments","statuses_url":"https://api.github.com/repos/OCA/sale-workflow/statuses/e5c445ced824267b7cf4a1656cab65912023ea7c","head":{"label":"lepistone:fix-display-exception","ref":"fix-display-exception","sha":"e5c445ced824267b7cf4a1656cab65912023ea7c","user":{"login":"lepistone","id":1314778,"avatar_url":"https://avatars.githubusercontent.com/u/1314778?v=3","gravatar_id":"","url":"https://api.github.com/users/lepistone","html_url":"https://github.com/lepistone","followers_url":"https://api.github.com/users/lepistone/followers","following_url":"https://api.github.com/users/lepistone/following{/other_user}","gists_url":"https://api.github.com/users/lepistone/gists{/gist_id}","starred_url":"https://api.github.com/users/lepistone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepistone/subscriptions","organizations_url":"https://api.github.com/users/lepistone/orgs","repos_url":"https://api.github.com/users/lepistone/repos","events_url":"https://api.github.com/users/lepistone/events{/privacy}","received_events_url":"https://api.github.com/users/lepistone/received_events","type":"User","site_admin":false},"repo":{"id":23308478,"name":"sale-workflow","full_name":"lepistone/sale-workflow","owner":{"login":"lepistone","id":1314778,"avatar_url":"https://avatars.githubusercontent.com/u/1314778?v=3","gravatar_id":"","url":"https://api.github.com/users/lepistone","html_url":"https://github.com/lepistone","followers_url":"https://api.github.com/users/lepistone/followers","following_url":"https://api.github.com/users/lepistone/following{/other_user}","gists_url":"https://api.github.com/users/lepistone/gists{/gist_id}","starred_url":"https://api.github.com/users/lepistone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepistone/subscriptions","organizations_url":"https://api.github.com/users/lepistone/orgs","repos_url":"https://api.github.com/users/lepistone/repos","events_url":"https://api.github.com/users/lepistone/events{/privacy}","received_events_url":"https://api.github.com/users/lepistone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lepistone/sale-workflow","description":"","fork":true,"url":"https://api.github.com/repos/lepistone/sale-workflow","forks_url":"https://api.github.com/repos/lepistone/sale-workflow/forks","keys_url":"https://api.github.com/repos/lepistone/sale-workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lepistone/sale-workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lepistone/sale-workflow/teams","hooks_url":"https://api.github.com/repos/lepistone/sale-workflow/hooks","issue_events_url":"https://api.github.com/repos/lepistone/sale-workflow/issues/events{/number}","events_url":"https://api.github.com/repos/lepistone/sale-workflow/events","assignees_url":"https://api.github.com/repos/lepistone/sale-workflow/assignees{/user}","branches_url":"https://api.github.com/repos/lepistone/sale-workflow/branches{/branch}","tags_url":"https://api.github.com/repos/lepistone/sale-workflow/tags","blobs_url":"https://api.github.com/repos/lepistone/sale-workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lepistone/sale-workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lepistone/sale-workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/lepistone/sale-workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lepistone/sale-workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/lepistone/sale-workflow/languages","stargazers_url":"https://api.github.com/repos/lepistone/sale-workflow/stargazers","contributors_url":"https://api.github.com/repos/lepistone/sale-workflow/contributors","subscribers_url":"https://api.github.com/repos/lepistone/sale-workflow/subscribers","subscription_url":"https://api.github.com/repos/lepistone/sale-workflow/subscription","commits_url":"https://api.github.com/repos/lepistone/sale-workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/lepistone/sale-workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/lepistone/sale-workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/lepistone/sale-workflow/issues/comments/{number}","contents_url":"https://api.github.com/repos/lepistone/sale-workflow/contents/{+path}","compare_url":"https://api.github.com/repos/lepistone/sale-workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lepistone/sale-workflow/merges","archive_url":"https://api.github.com/repos/lepistone/sale-workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lepistone/sale-workflow/downloads","issues_url":"https://api.github.com/repos/lepistone/sale-workflow/issues{/number}","pulls_url":"https://api.github.com/repos/lepistone/sale-workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/lepistone/sale-workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/lepistone/sale-workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lepistone/sale-workflow/labels{/name}","releases_url":"https://api.github.com/repos/lepistone/sale-workflow/releases{/id}","created_at":"2014-08-25T09:21:14Z","updated_at":"2014-06-30T13:17:50Z","pushed_at":"2014-11-14T14:39:27Z","git_url":"git://github.com/lepistone/sale-workflow.git","ssh_url":"git@github.com:lepistone/sale-workflow.git","clone_url":"https://github.com/lepistone/sale-workflow.git","svn_url":"https://github.com/lepistone/sale-workflow","homepage":null,"size":692,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.0"}},"base":{"label":"OCA:8.0","ref":"8.0","sha":"2f56ed34a6f668fe32156e933e7cfb9f8d7df552","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20882412,"name":"sale-workflow","full_name":"OCA/sale-workflow","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/sale-workflow","description":"","fork":false,"url":"https://api.github.com/repos/OCA/sale-workflow","forks_url":"https://api.github.com/repos/OCA/sale-workflow/forks","keys_url":"https://api.github.com/repos/OCA/sale-workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/sale-workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/sale-workflow/teams","hooks_url":"https://api.github.com/repos/OCA/sale-workflow/hooks","issue_events_url":"https://api.github.com/repos/OCA/sale-workflow/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/sale-workflow/events","assignees_url":"https://api.github.com/repos/OCA/sale-workflow/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/sale-workflow/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/sale-workflow/tags","blobs_url":"https://api.github.com/repos/OCA/sale-workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/sale-workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/sale-workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/sale-workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/sale-workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/sale-workflow/languages","stargazers_url":"https://api.github.com/repos/OCA/sale-workflow/stargazers","contributors_url":"https://api.github.com/repos/OCA/sale-workflow/contributors","subscribers_url":"https://api.github.com/repos/OCA/sale-workflow/subscribers","subscription_url":"https://api.github.com/repos/OCA/sale-workflow/subscription","commits_url":"https://api.github.com/repos/OCA/sale-workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/sale-workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/sale-workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/sale-workflow/issues/comments/{number}","contents_url":"https://api.github.com/repos/OCA/sale-workflow/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/sale-workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/sale-workflow/merges","archive_url":"https://api.github.com/repos/OCA/sale-workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/sale-workflow/downloads","issues_url":"https://api.github.com/repos/OCA/sale-workflow/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/sale-workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/sale-workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/sale-workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/sale-workflow/labels{/name}","releases_url":"https://api.github.com/repos/OCA/sale-workflow/releases{/id}","created_at":"2014-06-16T11:26:39Z","updated_at":"2014-11-12T09:56:40Z","pushed_at":"2014-11-14T14:08:45Z","git_url":"git://github.com/OCA/sale-workflow.git","ssh_url":"git@github.com:OCA/sale-workflow.git","clone_url":"https://github.com/OCA/sale-workflow.git","svn_url":"https://github.com/OCA/sale-workflow","homepage":null,"size":1998,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":12,"forks":26,"open_issues":12,"watchers":4,"default_branch":"8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/60"},"html":{"href":"https://github.com/OCA/sale-workflow/pull/60"},"issue":{"href":"https://api.github.com/repos/OCA/sale-workflow/issues/60"},"comments":{"href":"https://api.github.com/repos/OCA/sale-workflow/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/sale-workflow/statuses/e5c445ced824267b7cf4a1656cab65912023ea7c"}}}}