GitHub PullRequestReviewCommentEvent at 2014-08-22 20:40:58
Repository: werkzeug
Actor: DasIch
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls/comments/16620256","id":16620256,"diff_hunk":"@@ -0,0 +1,26 @@\n+# -*- coding: utf-8 -*-\n+\"\"\"\n+    tests\n+    ~~~~~\n+\n+    Contains all test Werkzeug tests.\n+\n+    :copyright: (c) 2014 by Armin Ronacher.\n+    :license: BSD, see LICENSE for more details.\n+\"\"\"\n+from __future__ import with_statement\n+\n+from werkzeug._compat import text_type\n+\n+\n+def strict_eq(x, y):","path":"tests/__init__.py","position":16,"original_position":16,"commit_id":"c2a81edf0f6d60e6e071104fcded53b33f0c01ee","original_commit_id":"292821a6095a697622866b1d75be9ed1d2f5b4d5","user":{"login":"DasIch","id":182316,"avatar_url":"https://avatars.githubusercontent.com/u/182316?v=2","gravatar_id":"6abd0c61e52309fc49644db101eb49a3","url":"https://api.github.com/users/DasIch","html_url":"https://github.com/DasIch","followers_url":"https://api.github.com/users/DasIch/followers","following_url":"https://api.github.com/users/DasIch/following{/other_user}","gists_url":"https://api.github.com/users/DasIch/gists{/gist_id}","starred_url":"https://api.github.com/users/DasIch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DasIch/subscriptions","organizations_url":"https://api.github.com/users/DasIch/orgs","repos_url":"https://api.github.com/users/DasIch/repos","events_url":"https://api.github.com/users/DasIch/events{/privacy}","received_events_url":"https://api.github.com/users/DasIch/received_events","type":"User","site_admin":false},"body":"Great :) I was always annoyed by the additional frames introduces by our pep8 conforming assert methods, it's nice to be able to focus on what matters.","created_at":"2014-08-22T20:40:58Z","updated_at":"2014-08-22T20:40:58Z","html_url":"https://github.com/mitsuhiko/werkzeug/pull/518#discussion_r16620256","pull_request_url":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls/518","_links":{"self":{"href":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls/comments/16620256"},"html":{"href":"https://github.com/mitsuhiko/werkzeug/pull/518#discussion_r16620256"},"pull_request":{"href":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls/518"}}},"pull_request":{"url":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls/518","id":15202488,"html_url":"https://github.com/mitsuhiko/werkzeug/pull/518","diff_url":"https://github.com/mitsuhiko/werkzeug/pull/518.diff","patch_url":"https://github.com/mitsuhiko/werkzeug/pull/518.patch","issue_url":"https://api.github.com/repos/mitsuhiko/werkzeug/issues/518","number":518,"state":"open","locked":false,"title":"Port testsuite to py.test","user":{"login":"untitaker","id":837573,"avatar_url":"https://avatars.githubusercontent.com/u/837573?v=2","gravatar_id":"1ad87bb0303238ee876a147dacd557a1","url":"https://api.github.com/users/untitaker","html_url":"https://github.com/untitaker","followers_url":"https://api.github.com/users/untitaker/followers","following_url":"https://api.github.com/users/untitaker/following{/other_user}","gists_url":"https://api.github.com/users/untitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/untitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untitaker/subscriptions","organizations_url":"https://api.github.com/users/untitaker/orgs","repos_url":"https://api.github.com/users/untitaker/repos","events_url":"https://api.github.com/users/untitaker/events{/privacy}","received_events_url":"https://api.github.com/users/untitaker/received_events","type":"User","site_admin":false},"body":"As per https://github.com/pocoo/metaflask/issues/8\r\n\r\n  - [x] Make testsuite discoverable for py.test\r\n    - [x] Move testsuite from ``/werkzeug/testsuite`` to ``/tests``\r\n    - [x] Prefix ``.py``-files with ``test_``\r\n  - [x] Remove all traces of custom testrunner code\r\n  - [x] Remove usage of assertion methods\r\n  - [x] Replace setUp and tearDown with fixtures\r\n  - [x] Remove useless ``Test...``-classes in testsuite. Leaving them where subclassing is used for testing against multiple interfaces, and where they provide some form of separation, but no common superclass other than ``object`` anymore.","created_at":"2014-04-26T13:34:06Z","updated_at":"2014-08-22T20:40:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7766db965daeb2b9d4c2f9ccbbc31029cc3058c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls/518/commits","review_comments_url":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls/518/comments","review_comment_url":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mitsuhiko/werkzeug/issues/518/comments","statuses_url":"https://api.github.com/repos/mitsuhiko/werkzeug/statuses/c2a81edf0f6d60e6e071104fcded53b33f0c01ee","head":{"label":"untitaker:third_party_testrunners","ref":"third_party_testrunners","sha":"c2a81edf0f6d60e6e071104fcded53b33f0c01ee","user":{"login":"untitaker","id":837573,"avatar_url":"https://avatars.githubusercontent.com/u/837573?v=2","gravatar_id":"1ad87bb0303238ee876a147dacd557a1","url":"https://api.github.com/users/untitaker","html_url":"https://github.com/untitaker","followers_url":"https://api.github.com/users/untitaker/followers","following_url":"https://api.github.com/users/untitaker/following{/other_user}","gists_url":"https://api.github.com/users/untitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/untitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untitaker/subscriptions","organizations_url":"https://api.github.com/users/untitaker/orgs","repos_url":"https://api.github.com/users/untitaker/repos","events_url":"https://api.github.com/users/untitaker/events{/privacy}","received_events_url":"https://api.github.com/users/untitaker/received_events","type":"User","site_admin":false},"repo":{"id":6250301,"name":"werkzeug","full_name":"untitaker/werkzeug","owner":{"login":"untitaker","id":837573,"avatar_url":"https://avatars.githubusercontent.com/u/837573?v=2","gravatar_id":"1ad87bb0303238ee876a147dacd557a1","url":"https://api.github.com/users/untitaker","html_url":"https://github.com/untitaker","followers_url":"https://api.github.com/users/untitaker/followers","following_url":"https://api.github.com/users/untitaker/following{/other_user}","gists_url":"https://api.github.com/users/untitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/untitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untitaker/subscriptions","organizations_url":"https://api.github.com/users/untitaker/orgs","repos_url":"https://api.github.com/users/untitaker/repos","events_url":"https://api.github.com/users/untitaker/events{/privacy}","received_events_url":"https://api.github.com/users/untitaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/untitaker/werkzeug","description":"A flexible WSGI implementation and toolkit","fork":true,"url":"https://api.github.com/repos/untitaker/werkzeug","forks_url":"https://api.github.com/repos/untitaker/werkzeug/forks","keys_url":"https://api.github.com/repos/untitaker/werkzeug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/untitaker/werkzeug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/untitaker/werkzeug/teams","hooks_url":"https://api.github.com/repos/untitaker/werkzeug/hooks","issue_events_url":"https://api.github.com/repos/untitaker/werkzeug/issues/events{/number}","events_url":"https://api.github.com/repos/untitaker/werkzeug/events","assignees_url":"https://api.github.com/repos/untitaker/werkzeug/assignees{/user}","branches_url":"https://api.github.com/repos/untitaker/werkzeug/branches{/branch}","tags_url":"https://api.github.com/repos/untitaker/werkzeug/tags","blobs_url":"https://api.github.com/repos/untitaker/werkzeug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/untitaker/werkzeug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/untitaker/werkzeug/git/refs{/sha}","trees_url":"https://api.github.com/repos/untitaker/werkzeug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/untitaker/werkzeug/statuses/{sha}","languages_url":"https://api.github.com/repos/untitaker/werkzeug/languages","stargazers_url":"https://api.github.com/repos/untitaker/werkzeug/stargazers","contributors_url":"https://api.github.com/repos/untitaker/werkzeug/contributors","subscribers_url":"https://api.github.com/repos/untitaker/werkzeug/subscribers","subscription_url":"https://api.github.com/repos/untitaker/werkzeug/subscription","commits_url":"https://api.github.com/repos/untitaker/werkzeug/commits{/sha}","git_commits_url":"https://api.github.com/repos/untitaker/werkzeug/git/commits{/sha}","comments_url":"https://api.github.com/repos/untitaker/werkzeug/comments{/number}","issue_comment_url":"https://api.github.com/repos/untitaker/werkzeug/issues/comments/{number}","contents_url":"https://api.github.com/repos/untitaker/werkzeug/contents/{+path}","compare_url":"https://api.github.com/repos/untitaker/werkzeug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/untitaker/werkzeug/merges","archive_url":"https://api.github.com/repos/untitaker/werkzeug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/untitaker/werkzeug/downloads","issues_url":"https://api.github.com/repos/untitaker/werkzeug/issues{/number}","pulls_url":"https://api.github.com/repos/untitaker/werkzeug/pulls{/number}","milestones_url":"https://api.github.com/repos/untitaker/werkzeug/milestones{/number}","notifications_url":"https://api.github.com/repos/untitaker/werkzeug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/untitaker/werkzeug/labels{/name}","releases_url":"https://api.github.com/repos/untitaker/werkzeug/releases{/id}","created_at":"2012-10-16T19:31:27Z","updated_at":"2014-06-24T14:31:20Z","pushed_at":"2014-08-22T20:33:29Z","git_url":"git://github.com/untitaker/werkzeug.git","ssh_url":"git@github.com:untitaker/werkzeug.git","clone_url":"https://github.com/untitaker/werkzeug.git","svn_url":"https://github.com/untitaker/werkzeug","homepage":"http://werkzeug.pocoo.org/","size":12369,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mitsuhiko:master","ref":"master","sha":"e5e0da4bbf8082521739222f0c48361a09ba497e","user":{"login":"mitsuhiko","id":7396,"avatar_url":"https://avatars.githubusercontent.com/u/7396?v=2","gravatar_id":"181de1fb11dffe39774f3e2e23cda3b6","url":"https://api.github.com/users/mitsuhiko","html_url":"https://github.com/mitsuhiko","followers_url":"https://api.github.com/users/mitsuhiko/followers","following_url":"https://api.github.com/users/mitsuhiko/following{/other_user}","gists_url":"https://api.github.com/users/mitsuhiko/gists{/gist_id}","starred_url":"https://api.github.com/users/mitsuhiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitsuhiko/subscriptions","organizations_url":"https://api.github.com/users/mitsuhiko/orgs","repos_url":"https://api.github.com/users/mitsuhiko/repos","events_url":"https://api.github.com/users/mitsuhiko/events{/privacy}","received_events_url":"https://api.github.com/users/mitsuhiko/received_events","type":"User","site_admin":false},"repo":{"id":997338,"name":"werkzeug","full_name":"mitsuhiko/werkzeug","owner":{"login":"mitsuhiko","id":7396,"avatar_url":"https://avatars.githubusercontent.com/u/7396?v=2","gravatar_id":"181de1fb11dffe39774f3e2e23cda3b6","url":"https://api.github.com/users/mitsuhiko","html_url":"https://github.com/mitsuhiko","followers_url":"https://api.github.com/users/mitsuhiko/followers","following_url":"https://api.github.com/users/mitsuhiko/following{/other_user}","gists_url":"https://api.github.com/users/mitsuhiko/gists{/gist_id}","starred_url":"https://api.github.com/users/mitsuhiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitsuhiko/subscriptions","organizations_url":"https://api.github.com/users/mitsuhiko/orgs","repos_url":"https://api.github.com/users/mitsuhiko/repos","events_url":"https://api.github.com/users/mitsuhiko/events{/privacy}","received_events_url":"https://api.github.com/users/mitsuhiko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitsuhiko/werkzeug","description":"A flexible WSGI implementation and toolkit","fork":false,"url":"https://api.github.com/repos/mitsuhiko/werkzeug","forks_url":"https://api.github.com/repos/mitsuhiko/werkzeug/forks","keys_url":"https://api.github.com/repos/mitsuhiko/werkzeug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitsuhiko/werkzeug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitsuhiko/werkzeug/teams","hooks_url":"https://api.github.com/repos/mitsuhiko/werkzeug/hooks","issue_events_url":"https://api.github.com/repos/mitsuhiko/werkzeug/issues/events{/number}","events_url":"https://api.github.com/repos/mitsuhiko/werkzeug/events","assignees_url":"https://api.github.com/repos/mitsuhiko/werkzeug/assignees{/user}","branches_url":"https://api.github.com/repos/mitsuhiko/werkzeug/branches{/branch}","tags_url":"https://api.github.com/repos/mitsuhiko/werkzeug/tags","blobs_url":"https://api.github.com/repos/mitsuhiko/werkzeug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitsuhiko/werkzeug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitsuhiko/werkzeug/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitsuhiko/werkzeug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitsuhiko/werkzeug/statuses/{sha}","languages_url":"https://api.github.com/repos/mitsuhiko/werkzeug/languages","stargazers_url":"https://api.github.com/repos/mitsuhiko/werkzeug/stargazers","contributors_url":"https://api.github.com/repos/mitsuhiko/werkzeug/contributors","subscribers_url":"https://api.github.com/repos/mitsuhiko/werkzeug/subscribers","subscription_url":"https://api.github.com/repos/mitsuhiko/werkzeug/subscription","commits_url":"https://api.github.com/repos/mitsuhiko/werkzeug/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitsuhiko/werkzeug/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitsuhiko/werkzeug/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitsuhiko/werkzeug/issues/comments/{number}","contents_url":"https://api.github.com/repos/mitsuhiko/werkzeug/contents/{+path}","compare_url":"https://api.github.com/repos/mitsuhiko/werkzeug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitsuhiko/werkzeug/merges","archive_url":"https://api.github.com/repos/mitsuhiko/werkzeug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitsuhiko/werkzeug/downloads","issues_url":"https://api.github.com/repos/mitsuhiko/werkzeug/issues{/number}","pulls_url":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls{/number}","milestones_url":"https://api.github.com/repos/mitsuhiko/werkzeug/milestones{/number}","notifications_url":"https://api.github.com/repos/mitsuhiko/werkzeug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitsuhiko/werkzeug/labels{/name}","releases_url":"https://api.github.com/repos/mitsuhiko/werkzeug/releases{/id}","created_at":"2010-10-18T11:42:40Z","updated_at":"2014-08-22T20:14:03Z","pushed_at":"2014-06-30T23:43:07Z","git_url":"git://github.com/mitsuhiko/werkzeug.git","ssh_url":"git@github.com:mitsuhiko/werkzeug.git","clone_url":"https://github.com/mitsuhiko/werkzeug.git","svn_url":"https://github.com/mitsuhiko/werkzeug","homepage":"http://werkzeug.pocoo.org/","size":15757,"stargazers_count":1556,"watchers_count":1556,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":432,"mirror_url":null,"open_issues_count":172,"forks":432,"open_issues":172,"watchers":1556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls/518"},"html":{"href":"https://github.com/mitsuhiko/werkzeug/pull/518"},"issue":{"href":"https://api.github.com/repos/mitsuhiko/werkzeug/issues/518"},"comments":{"href":"https://api.github.com/repos/mitsuhiko/werkzeug/issues/518/comments"},"review_comments":{"href":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls/518/comments"},"review_comment":{"href":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mitsuhiko/werkzeug/pulls/518/commits"},"statuses":{"href":"https://api.github.com/repos/mitsuhiko/werkzeug/statuses/c2a81edf0f6d60e6e071104fcded53b33f0c01ee"}}}}