GitHub PullRequestReviewCommentEvent at 2014-07-28 18:56:07
Repository: javarosa
Actor: ctsims
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/javarosa/pulls/comments/15482443","id":15482443,"diff_hunk":"@@ -135,8 +135,9 @@\n \tprivate Vector<String> instanceNodeIdStrs;\r\n \tprivate String defaultNamespace;\r\n \tprivate Vector<String> itextKnownForms;\r\n-\tprivate Vector<String> namedActions;\r\n-\tprivate Hashtable<String, IElementHandler> structuredActions;\r\n+\t\r\n+\tprivate static Vector<String> namedActions;\r","path":"core/src/org/javarosa/xform/parse/XFormParser.java","position":7,"original_position":7,"commit_id":"c86a086ed187cc77747af49cb35cd20a5afbe356","original_commit_id":"c86a086ed187cc77747af49cb35cd20a5afbe356","user":{"login":"ctsims","id":155066,"avatar_url":"https://avatars.githubusercontent.com/u/155066?","gravatar_id":"a6a6b824435343e7f34b1c3a4b52ed27","url":"https://api.github.com/users/ctsims","html_url":"https://github.com/ctsims","followers_url":"https://api.github.com/users/ctsims/followers","following_url":"https://api.github.com/users/ctsims/following{/other_user}","gists_url":"https://api.github.com/users/ctsims/gists{/gist_id}","starred_url":"https://api.github.com/users/ctsims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctsims/subscriptions","organizations_url":"https://api.github.com/users/ctsims/orgs","repos_url":"https://api.github.com/users/ctsims/repos","events_url":"https://api.github.com/users/ctsims/events{/privacy}","received_events_url":"https://api.github.com/users/ctsims/received_events","type":"User","site_admin":false},"body":"Is there a reason these needed to be migrated to static? We've been trying pretty hard to pull as much of this class's functionality out of the static domain into a life-cycle'd domain.","created_at":"2014-07-28T18:56:07Z","updated_at":"2014-07-28T18:56:07Z","html_url":"https://github.com/dimagi/javarosa/pull/1#discussion_r15482443","pull_request_url":"https://api.github.com/repos/dimagi/javarosa/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/dimagi/javarosa/pulls/comments/15482443"},"html":{"href":"https://github.com/dimagi/javarosa/pull/1#discussion_r15482443"},"pull_request":{"href":"https://api.github.com/repos/dimagi/javarosa/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/dimagi/javarosa/pulls/1","id":17854647,"html_url":"https://github.com/dimagi/javarosa/pull/1","diff_url":"https://github.com/dimagi/javarosa/pull/1.diff","patch_url":"https://github.com/dimagi/javarosa/pull/1.patch","issue_url":"https://api.github.com/repos/dimagi/javarosa/issues/1","number":1,"state":"open","title":"Automatic GPS capture","user":{"login":"orangejenny","id":1486591,"avatar_url":"https://avatars.githubusercontent.com/u/1486591?","gravatar_id":"e6ad87273ae8fb66948af43f2b3f2f69","url":"https://api.github.com/users/orangejenny","html_url":"https://github.com/orangejenny","followers_url":"https://api.github.com/users/orangejenny/followers","following_url":"https://api.github.com/users/orangejenny/following{/other_user}","gists_url":"https://api.github.com/users/orangejenny/gists{/gist_id}","starred_url":"https://api.github.com/users/orangejenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangejenny/subscriptions","organizations_url":"https://api.github.com/users/orangejenny/orgs","repos_url":"https://api.github.com/users/orangejenny/repos","events_url":"https://api.github.com/users/orangejenny/events{/privacy}","received_events_url":"https://api.github.com/users/orangejenny/received_events","type":"User","site_admin":false},"body":"Changes to XFormParser to support auto-GPS capture.","created_at":"2014-07-01T20:59:52Z","updated_at":"2014-07-28T18:56:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9be12aef78f7d2b54bdf0bea6f3d8b7de82c504c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/javarosa/pulls/1/commits","review_comments_url":"https://api.github.com/repos/dimagi/javarosa/pulls/1/comments","review_comment_url":"https://api.github.com/repos/dimagi/javarosa/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dimagi/javarosa/issues/1/comments","statuses_url":"https://api.github.com/repos/dimagi/javarosa/statuses/c86a086ed187cc77747af49cb35cd20a5afbe356","head":{"label":"dimagi:auto-gps","ref":"auto-gps","sha":"c86a086ed187cc77747af49cb35cd20a5afbe356","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?","gravatar_id":"bf2cc69672a3a75313f476a0fb6ef103","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":20938963,"name":"javarosa","full_name":"dimagi/javarosa","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?","gravatar_id":"bf2cc69672a3a75313f476a0fb6ef103","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/javarosa","description":"","fork":false,"url":"https://api.github.com/repos/dimagi/javarosa","forks_url":"https://api.github.com/repos/dimagi/javarosa/forks","keys_url":"https://api.github.com/repos/dimagi/javarosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/javarosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/javarosa/teams","hooks_url":"https://api.github.com/repos/dimagi/javarosa/hooks","issue_events_url":"https://api.github.com/repos/dimagi/javarosa/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/javarosa/events","assignees_url":"https://api.github.com/repos/dimagi/javarosa/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/javarosa/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/javarosa/tags","blobs_url":"https://api.github.com/repos/dimagi/javarosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/javarosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/javarosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/javarosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/javarosa/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/javarosa/languages","stargazers_url":"https://api.github.com/repos/dimagi/javarosa/stargazers","contributors_url":"https://api.github.com/repos/dimagi/javarosa/contributors","subscribers_url":"https://api.github.com/repos/dimagi/javarosa/subscribers","subscription_url":"https://api.github.com/repos/dimagi/javarosa/subscription","commits_url":"https://api.github.com/repos/dimagi/javarosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/javarosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/javarosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/javarosa/issues/comments/{number}","contents_url":"https://api.github.com/repos/dimagi/javarosa/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/javarosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/javarosa/merges","archive_url":"https://api.github.com/repos/dimagi/javarosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/javarosa/downloads","issues_url":"https://api.github.com/repos/dimagi/javarosa/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/javarosa/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/javarosa/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/javarosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/javarosa/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/javarosa/releases{/id}","created_at":"2014-06-17T20:46:39Z","updated_at":"2014-06-18T20:24:33Z","pushed_at":"2014-07-21T20:38:29Z","git_url":"git://github.com/dimagi/javarosa.git","ssh_url":"git@github.com:dimagi/javarosa.git","clone_url":"https://github.com/dimagi/javarosa.git","svn_url":"https://github.com/dimagi/javarosa","homepage":null,"size":29224,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"eeae17f1d0feaf89086e549dd8e9564dcb4a77e6","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?","gravatar_id":"bf2cc69672a3a75313f476a0fb6ef103","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":20938963,"name":"javarosa","full_name":"dimagi/javarosa","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?","gravatar_id":"bf2cc69672a3a75313f476a0fb6ef103","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/javarosa","description":"","fork":false,"url":"https://api.github.com/repos/dimagi/javarosa","forks_url":"https://api.github.com/repos/dimagi/javarosa/forks","keys_url":"https://api.github.com/repos/dimagi/javarosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/javarosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/javarosa/teams","hooks_url":"https://api.github.com/repos/dimagi/javarosa/hooks","issue_events_url":"https://api.github.com/repos/dimagi/javarosa/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/javarosa/events","assignees_url":"https://api.github.com/repos/dimagi/javarosa/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/javarosa/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/javarosa/tags","blobs_url":"https://api.github.com/repos/dimagi/javarosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/javarosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/javarosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/javarosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/javarosa/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/javarosa/languages","stargazers_url":"https://api.github.com/repos/dimagi/javarosa/stargazers","contributors_url":"https://api.github.com/repos/dimagi/javarosa/contributors","subscribers_url":"https://api.github.com/repos/dimagi/javarosa/subscribers","subscription_url":"https://api.github.com/repos/dimagi/javarosa/subscription","commits_url":"https://api.github.com/repos/dimagi/javarosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/javarosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/javarosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/javarosa/issues/comments/{number}","contents_url":"https://api.github.com/repos/dimagi/javarosa/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/javarosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/javarosa/merges","archive_url":"https://api.github.com/repos/dimagi/javarosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/javarosa/downloads","issues_url":"https://api.github.com/repos/dimagi/javarosa/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/javarosa/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/javarosa/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/javarosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/javarosa/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/javarosa/releases{/id}","created_at":"2014-06-17T20:46:39Z","updated_at":"2014-06-18T20:24:33Z","pushed_at":"2014-07-21T20:38:29Z","git_url":"git://github.com/dimagi/javarosa.git","ssh_url":"git@github.com:dimagi/javarosa.git","clone_url":"https://github.com/dimagi/javarosa.git","svn_url":"https://github.com/dimagi/javarosa","homepage":null,"size":29224,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/javarosa/pulls/1"},"html":{"href":"https://github.com/dimagi/javarosa/pull/1"},"issue":{"href":"https://api.github.com/repos/dimagi/javarosa/issues/1"},"comments":{"href":"https://api.github.com/repos/dimagi/javarosa/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/javarosa/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/javarosa/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dimagi/javarosa/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/javarosa/statuses/c86a086ed187cc77747af49cb35cd20a5afbe356"}}}}