GitHub PullRequestReviewCommentEvent at 2014-08-29 12:30:24
Repository: sogo
Actor: extrafu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/sogo/pulls/comments/16894881","id":16894881,"diff_hunk":"@@ -217,7 +264,30 @@ - (WOResponse *) batchDeleteAction\n                                         andString: [data jsonRepresentation]];\n             }\n           else\n-            response = [self responseWith204];\n+            {\n+              // Verify if the message beeing delete is saved as the root of a collapsed thread\n+              us = [[context activeUser] userSettings];\n+              moduleSettings = [us objectForKey: @\"Mail\"];\n+              threadsCollapsed = [moduleSettings objectForKey:@\"threadsCollapsed\"];\n+              currentMailbox = [co nameInContainer];\n+              currentAccount = [[co container] nameInContainer];\n+              keyForMsgUIDs = [NSString stringWithFormat:@\"/%@/%@\", currentAccount, currentMailbox];\n+\n+              if ([threadsCollapsed boolValue])\n+                {\n+                  if ([[threadsCollapsed objectForKey:keyForMsgUIDs] boolValue])\n+                    {\n+                      mailboxThreadsCollapsed = [threadsCollapsed objectForKey:keyForMsgUIDs];\n+                      for (i = 0; i < [uids count]; i++)\n+                        {\n+                          if ([mailboxThreadsCollapsed containsObject:[uids objectAtIndex:i]])","path":"UI/MailerUI/UIxMailFolderActions.m","position":129,"original_position":129,"commit_id":"11932db4777a70905835d55dce5611caf2f2707f","original_commit_id":"11932db4777a70905835d55dce5611caf2f2707f","user":{"login":"extrafu","id":1616141,"avatar_url":"https://avatars.githubusercontent.com/u/1616141?v=2","gravatar_id":"7be230f9fef84b6bb46675ee532049a7","url":"https://api.github.com/users/extrafu","html_url":"https://github.com/extrafu","followers_url":"https://api.github.com/users/extrafu/followers","following_url":"https://api.github.com/users/extrafu/following{/other_user}","gists_url":"https://api.github.com/users/extrafu/gists{/gist_id}","starred_url":"https://api.github.com/users/extrafu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/extrafu/subscriptions","organizations_url":"https://api.github.com/users/extrafu/orgs","repos_url":"https://api.github.com/users/extrafu/repos","events_url":"https://api.github.com/users/extrafu/events{/privacy}","received_events_url":"https://api.github.com/users/extrafu/received_events","type":"User","site_admin":false},"body":"No need to check this, just call removeObject right away.","created_at":"2014-08-29T12:30:24Z","updated_at":"2014-08-29T12:30:24Z","html_url":"https://github.com/inverse-inc/sogo/pull/51#discussion_r16894881","pull_request_url":"https://api.github.com/repos/inverse-inc/sogo/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/sogo/pulls/comments/16894881"},"html":{"href":"https://github.com/inverse-inc/sogo/pull/51#discussion_r16894881"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/sogo/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/sogo/pulls/51","id":19692182,"html_url":"https://github.com/inverse-inc/sogo/pull/51","diff_url":"https://github.com/inverse-inc/sogo/pull/51.diff","patch_url":"https://github.com/inverse-inc/sogo/pull/51.patch","issue_url":"https://api.github.com/repos/inverse-inc/sogo/issues/51","number":51,"state":"open","locked":false,"title":"Possibility to collapsed threads with persistance","user":{"login":"alexcloutier","id":4387383,"avatar_url":"https://avatars.githubusercontent.com/u/4387383?v=2","gravatar_id":"bd0d1b00946d493dea77b9766d441509","url":"https://api.github.com/users/alexcloutier","html_url":"https://github.com/alexcloutier","followers_url":"https://api.github.com/users/alexcloutier/followers","following_url":"https://api.github.com/users/alexcloutier/following{/other_user}","gists_url":"https://api.github.com/users/alexcloutier/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcloutier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcloutier/subscriptions","organizations_url":"https://api.github.com/users/alexcloutier/orgs","repos_url":"https://api.github.com/users/alexcloutier/repos","events_url":"https://api.github.com/users/alexcloutier/events{/privacy}","received_events_url":"https://api.github.com/users/alexcloutier/received_events","type":"User","site_admin":false},"body":"The user have the possibility to collapse threads of emails. \r\nThe information about the collapsed threads are kept inside the user settings under the module Mail saved by the key : threadsCollapsed","created_at":"2014-08-12T21:46:50Z","updated_at":"2014-08-29T12:30:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73534425845c0e1a6f348642090a67cba93c0176","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inverse-inc/sogo/pulls/51/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/sogo/pulls/51/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/sogo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inverse-inc/sogo/issues/51/comments","statuses_url":"https://api.github.com/repos/inverse-inc/sogo/statuses/11932db4777a70905835d55dce5611caf2f2707f","head":{"label":"alexcloutier:feature/FoldingThreads","ref":"feature/FoldingThreads","sha":"11932db4777a70905835d55dce5611caf2f2707f","user":{"login":"alexcloutier","id":4387383,"avatar_url":"https://avatars.githubusercontent.com/u/4387383?v=2","gravatar_id":"bd0d1b00946d493dea77b9766d441509","url":"https://api.github.com/users/alexcloutier","html_url":"https://github.com/alexcloutier","followers_url":"https://api.github.com/users/alexcloutier/followers","following_url":"https://api.github.com/users/alexcloutier/following{/other_user}","gists_url":"https://api.github.com/users/alexcloutier/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcloutier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcloutier/subscriptions","organizations_url":"https://api.github.com/users/alexcloutier/orgs","repos_url":"https://api.github.com/users/alexcloutier/repos","events_url":"https://api.github.com/users/alexcloutier/events{/privacy}","received_events_url":"https://api.github.com/users/alexcloutier/received_events","type":"User","site_admin":false},"repo":{"id":17179254,"name":"SOGo","full_name":"alexcloutier/SOGo","owner":{"login":"alexcloutier","id":4387383,"avatar_url":"https://avatars.githubusercontent.com/u/4387383?v=2","gravatar_id":"bd0d1b00946d493dea77b9766d441509","url":"https://api.github.com/users/alexcloutier","html_url":"https://github.com/alexcloutier","followers_url":"https://api.github.com/users/alexcloutier/followers","following_url":"https://api.github.com/users/alexcloutier/following{/other_user}","gists_url":"https://api.github.com/users/alexcloutier/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcloutier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcloutier/subscriptions","organizations_url":"https://api.github.com/users/alexcloutier/orgs","repos_url":"https://api.github.com/users/alexcloutier/repos","events_url":"https://api.github.com/users/alexcloutier/events{/privacy}","received_events_url":"https://api.github.com/users/alexcloutier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexcloutier/SOGo","description":"SOGo is a very fast and scalable modern collaboration suite (groupware). It offers calendaring, address book management, and a full-featured Webmail client along with resource sharing and permission handling. It also makes use of documented standards (IMAP, CalDAV, CardDAV, etc.) and thereby provides native connectivity (without plugins) to many clients such as Microsoft Outlook, Apple iCal, the iPhone, Mozilla Lightning, and a plethora of mobile devices.","fork":true,"url":"https://api.github.com/repos/alexcloutier/SOGo","forks_url":"https://api.github.com/repos/alexcloutier/SOGo/forks","keys_url":"https://api.github.com/repos/alexcloutier/SOGo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcloutier/SOGo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcloutier/SOGo/teams","hooks_url":"https://api.github.com/repos/alexcloutier/SOGo/hooks","issue_events_url":"https://api.github.com/repos/alexcloutier/SOGo/issues/events{/number}","events_url":"https://api.github.com/repos/alexcloutier/SOGo/events","assignees_url":"https://api.github.com/repos/alexcloutier/SOGo/assignees{/user}","branches_url":"https://api.github.com/repos/alexcloutier/SOGo/branches{/branch}","tags_url":"https://api.github.com/repos/alexcloutier/SOGo/tags","blobs_url":"https://api.github.com/repos/alexcloutier/SOGo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcloutier/SOGo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcloutier/SOGo/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcloutier/SOGo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcloutier/SOGo/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcloutier/SOGo/languages","stargazers_url":"https://api.github.com/repos/alexcloutier/SOGo/stargazers","contributors_url":"https://api.github.com/repos/alexcloutier/SOGo/contributors","subscribers_url":"https://api.github.com/repos/alexcloutier/SOGo/subscribers","subscription_url":"https://api.github.com/repos/alexcloutier/SOGo/subscription","commits_url":"https://api.github.com/repos/alexcloutier/SOGo/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcloutier/SOGo/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcloutier/SOGo/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcloutier/SOGo/issues/comments/{number}","contents_url":"https://api.github.com/repos/alexcloutier/SOGo/contents/{+path}","compare_url":"https://api.github.com/repos/alexcloutier/SOGo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcloutier/SOGo/merges","archive_url":"https://api.github.com/repos/alexcloutier/SOGo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcloutier/SOGo/downloads","issues_url":"https://api.github.com/repos/alexcloutier/SOGo/issues{/number}","pulls_url":"https://api.github.com/repos/alexcloutier/SOGo/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcloutier/SOGo/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcloutier/SOGo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcloutier/SOGo/labels{/name}","releases_url":"https://api.github.com/repos/alexcloutier/SOGo/releases{/id}","created_at":"2014-02-25T16:14:47Z","updated_at":"2014-06-26T20:09:31Z","pushed_at":"2014-08-28T21:55:58Z","git_url":"git://github.com/alexcloutier/SOGo.git","ssh_url":"git@github.com:alexcloutier/SOGo.git","clone_url":"https://github.com/alexcloutier/SOGo.git","svn_url":"https://github.com/alexcloutier/SOGo","homepage":"http://sogo.nu/","size":43480,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"inverse-inc:master","ref":"master","sha":"5b886e5c4dab6bdf486f937df8bb234c4902f50c","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=2","gravatar_id":"cd5e161364549f5cbadc6121b5ffbc28","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":5855873,"name":"sogo","full_name":"inverse-inc/sogo","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=2","gravatar_id":"cd5e161364549f5cbadc6121b5ffbc28","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/sogo","description":"SOGo is a very fast and scalable modern collaboration suite (groupware). It offers calendaring, address book management, and a full-featured Webmail client along with resource sharing and permission handling. It also makes use of documented standards (IMAP, CalDAV, CardDAV, etc.) and thereby provides native connectivity (without plugins) to many clients such as Microsoft Outlook, Apple iCal, the iPhone, Mozilla Lightning, and a plethora of mobile devices.","fork":false,"url":"https://api.github.com/repos/inverse-inc/sogo","forks_url":"https://api.github.com/repos/inverse-inc/sogo/forks","keys_url":"https://api.github.com/repos/inverse-inc/sogo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/sogo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/sogo/teams","hooks_url":"https://api.github.com/repos/inverse-inc/sogo/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/sogo/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/sogo/events","assignees_url":"https://api.github.com/repos/inverse-inc/sogo/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/sogo/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/sogo/tags","blobs_url":"https://api.github.com/repos/inverse-inc/sogo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/sogo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/sogo/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/sogo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/sogo/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/sogo/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/sogo/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/sogo/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/sogo/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/sogo/subscription","commits_url":"https://api.github.com/repos/inverse-inc/sogo/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/sogo/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/sogo/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/sogo/issues/comments/{number}","contents_url":"https://api.github.com/repos/inverse-inc/sogo/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/sogo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/sogo/merges","archive_url":"https://api.github.com/repos/inverse-inc/sogo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/sogo/downloads","issues_url":"https://api.github.com/repos/inverse-inc/sogo/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/sogo/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/sogo/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/sogo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/sogo/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/sogo/releases{/id}","created_at":"2012-09-18T12:19:38Z","updated_at":"2014-08-29T00:13:19Z","pushed_at":"2014-08-28T14:44:04Z","git_url":"git://github.com/inverse-inc/sogo.git","ssh_url":"git@github.com:inverse-inc/sogo.git","clone_url":"https://github.com/inverse-inc/sogo.git","svn_url":"https://github.com/inverse-inc/sogo","homepage":"http://sogo.nu/","size":52980,"stargazers_count":107,"watchers_count":107,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":42,"mirror_url":null,"open_issues_count":16,"forks":42,"open_issues":16,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/sogo/pulls/51"},"html":{"href":"https://github.com/inverse-inc/sogo/pull/51"},"issue":{"href":"https://api.github.com/repos/inverse-inc/sogo/issues/51"},"comments":{"href":"https://api.github.com/repos/inverse-inc/sogo/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/sogo/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/sogo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/sogo/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/sogo/statuses/11932db4777a70905835d55dce5611caf2f2707f"}}}}