GitHub PullRequestReviewCommentEvent at 2014-10-01 02:41:35
Repository: pythran
Actor: pbrunet
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments/18258984","id":18258984,"diff_hunk":"@@ -34,6 +38,21 @@ def assertAlmostEqual(self, ref, res):\n                 for iref, ires in zip(ref, res):\n                     self.assertAlmostEqual(iref, ires)\n         else:\n+            # special case for nan and inf\n+            try:\n+                if isinf(ref) and isinf(res):\n+                    self.assertAlmostEqual(isneginf(ref), isneginf(res))\n+                    return\n+                if isnan(ref) and isnan(res):\n+                    return\n+            except TypeError:\n+                pass","path":"pythran/tests/test_env.py","position":32,"original_position":32,"commit_id":"5c440caf93fb411c6a902f7946d0e66132a59585","original_commit_id":"5c440caf93fb411c6a902f7946d0e66132a59585","user":{"login":"pbrunet","id":1872390,"avatar_url":"https://avatars.githubusercontent.com/u/1872390?v=2","gravatar_id":"","url":"https://api.github.com/users/pbrunet","html_url":"https://github.com/pbrunet","followers_url":"https://api.github.com/users/pbrunet/followers","following_url":"https://api.github.com/users/pbrunet/following{/other_user}","gists_url":"https://api.github.com/users/pbrunet/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrunet/subscriptions","organizations_url":"https://api.github.com/users/pbrunet/orgs","repos_url":"https://api.github.com/users/pbrunet/repos","events_url":"https://api.github.com/users/pbrunet/events{/privacy}","received_events_url":"https://api.github.com/users/pbrunet/received_events","type":"User","site_admin":false},"body":"Skip TypeError? It looks like we will have the same issue that what we had with numpy two month ago....","created_at":"2014-10-01T02:41:35Z","updated_at":"2014-10-01T02:41:35Z","html_url":"https://github.com/serge-sans-paille/pythran/pull/317#discussion_r18258984","pull_request_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/317","_links":{"self":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments/18258984"},"html":{"href":"https://github.com/serge-sans-paille/pythran/pull/317#discussion_r18258984"},"pull_request":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/317"}}},"pull_request":{"url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/317","id":21510058,"html_url":"https://github.com/serge-sans-paille/pythran/pull/317","diff_url":"https://github.com/serge-sans-paille/pythran/pull/317.diff","patch_url":"https://github.com/serge-sans-paille/pythran/pull/317.patch","issue_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/317","number":317,"state":"open","locked":false,"title":"Strict conformance to numpy's complex handling","user":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=2","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"body":"std::complex and numpy complex behave in slightly different ways...\r\nSee pythran/pythonic/patch/README.rst for the motivation and choices.","created_at":"2014-09-19T16:56:31Z","updated_at":"2014-10-01T02:41:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c5376bf0e687120d07454cf02bfe542491d0f7e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/317/commits","review_comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/317/comments","review_comment_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments/{number}","comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/317/comments","statuses_url":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/5c440caf93fb411c6a902f7946d0e66132a59585","head":{"label":"serge-sans-paille:fix-complex-multiply","ref":"fix-complex-multiply","sha":"5c440caf93fb411c6a902f7946d0e66132a59585","user":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=2","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"repo":{"id":4479494,"name":"pythran","full_name":"serge-sans-paille/pythran","owner":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=2","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serge-sans-paille/pythran","description":"a claimless python to c++ converter","fork":false,"url":"https://api.github.com/repos/serge-sans-paille/pythran","forks_url":"https://api.github.com/repos/serge-sans-paille/pythran/forks","keys_url":"https://api.github.com/repos/serge-sans-paille/pythran/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serge-sans-paille/pythran/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serge-sans-paille/pythran/teams","hooks_url":"https://api.github.com/repos/serge-sans-paille/pythran/hooks","issue_events_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/events{/number}","events_url":"https://api.github.com/repos/serge-sans-paille/pythran/events","assignees_url":"https://api.github.com/repos/serge-sans-paille/pythran/assignees{/user}","branches_url":"https://api.github.com/repos/serge-sans-paille/pythran/branches{/branch}","tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/tags","blobs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/refs{/sha}","trees_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/{sha}","languages_url":"https://api.github.com/repos/serge-sans-paille/pythran/languages","stargazers_url":"https://api.github.com/repos/serge-sans-paille/pythran/stargazers","contributors_url":"https://api.github.com/repos/serge-sans-paille/pythran/contributors","subscribers_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscribers","subscription_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscription","commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/commits{/sha}","git_commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/commits{/sha}","comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/comments{/number}","issue_comment_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/comments/{number}","contents_url":"https://api.github.com/repos/serge-sans-paille/pythran/contents/{+path}","compare_url":"https://api.github.com/repos/serge-sans-paille/pythran/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serge-sans-paille/pythran/merges","archive_url":"https://api.github.com/repos/serge-sans-paille/pythran/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serge-sans-paille/pythran/downloads","issues_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues{/number}","pulls_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls{/number}","milestones_url":"https://api.github.com/repos/serge-sans-paille/pythran/milestones{/number}","notifications_url":"https://api.github.com/repos/serge-sans-paille/pythran/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serge-sans-paille/pythran/labels{/name}","releases_url":"https://api.github.com/repos/serge-sans-paille/pythran/releases{/id}","created_at":"2012-05-29T08:02:14Z","updated_at":"2014-09-22T05:39:31Z","pushed_at":"2014-09-26T14:14:39Z","git_url":"git://github.com/serge-sans-paille/pythran.git","ssh_url":"git@github.com:serge-sans-paille/pythran.git","clone_url":"https://github.com/serge-sans-paille/pythran.git","svn_url":"https://github.com/serge-sans-paille/pythran","homepage":null,"size":21062,"stargazers_count":143,"watchers_count":143,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":34,"forks":28,"open_issues":34,"watchers":143,"default_branch":"master"}},"base":{"label":"serge-sans-paille:master","ref":"master","sha":"1ce52c6e96cad0bb862a5148e4b84bf3b191035e","user":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=2","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"repo":{"id":4479494,"name":"pythran","full_name":"serge-sans-paille/pythran","owner":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=2","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serge-sans-paille/pythran","description":"a claimless python to c++ converter","fork":false,"url":"https://api.github.com/repos/serge-sans-paille/pythran","forks_url":"https://api.github.com/repos/serge-sans-paille/pythran/forks","keys_url":"https://api.github.com/repos/serge-sans-paille/pythran/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serge-sans-paille/pythran/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serge-sans-paille/pythran/teams","hooks_url":"https://api.github.com/repos/serge-sans-paille/pythran/hooks","issue_events_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/events{/number}","events_url":"https://api.github.com/repos/serge-sans-paille/pythran/events","assignees_url":"https://api.github.com/repos/serge-sans-paille/pythran/assignees{/user}","branches_url":"https://api.github.com/repos/serge-sans-paille/pythran/branches{/branch}","tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/tags","blobs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/refs{/sha}","trees_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/{sha}","languages_url":"https://api.github.com/repos/serge-sans-paille/pythran/languages","stargazers_url":"https://api.github.com/repos/serge-sans-paille/pythran/stargazers","contributors_url":"https://api.github.com/repos/serge-sans-paille/pythran/contributors","subscribers_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscribers","subscription_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscription","commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/commits{/sha}","git_commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/commits{/sha}","comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/comments{/number}","issue_comment_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/comments/{number}","contents_url":"https://api.github.com/repos/serge-sans-paille/pythran/contents/{+path}","compare_url":"https://api.github.com/repos/serge-sans-paille/pythran/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serge-sans-paille/pythran/merges","archive_url":"https://api.github.com/repos/serge-sans-paille/pythran/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serge-sans-paille/pythran/downloads","issues_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues{/number}","pulls_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls{/number}","milestones_url":"https://api.github.com/repos/serge-sans-paille/pythran/milestones{/number}","notifications_url":"https://api.github.com/repos/serge-sans-paille/pythran/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serge-sans-paille/pythran/labels{/name}","releases_url":"https://api.github.com/repos/serge-sans-paille/pythran/releases{/id}","created_at":"2012-05-29T08:02:14Z","updated_at":"2014-09-22T05:39:31Z","pushed_at":"2014-09-26T14:14:39Z","git_url":"git://github.com/serge-sans-paille/pythran.git","ssh_url":"git@github.com:serge-sans-paille/pythran.git","clone_url":"https://github.com/serge-sans-paille/pythran.git","svn_url":"https://github.com/serge-sans-paille/pythran","homepage":null,"size":21062,"stargazers_count":143,"watchers_count":143,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":34,"forks":28,"open_issues":34,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/317"},"html":{"href":"https://github.com/serge-sans-paille/pythran/pull/317"},"issue":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/issues/317"},"comments":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/5c440caf93fb411c6a902f7946d0e66132a59585"}}}}