GitHub PullRequestReviewCommentEvent at 2014-11-18 16:32:26
Repository: strong-remoting
Actor: bajtos
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/strong-remoting/pulls/comments/20517683","id":20517683,"diff_hunk":"@@ -126,23 +126,33 @@ describe('strong-remoting-rest', function(){\n         .expect(500)\n         .end(expectErrorResponseContaining({message: 'test-error'}, ['stack'], done));\n     });\n-\n-    it('should disable stack trace', function(done) {\n-      process.env.NODE_ENV = 'production';\n-      var method = givenSharedStaticMethod(\n-        function(cb) {\n-          cb(new Error('test-error'));\n-        }\n-      );\n-\n-      // Send a plain, non-json request to make sure the error handler\n-      // always returns a json response.\n-      request(app).get(method.url)\n-        .expect('Content-Type', /json/)\n-        .expect(500)\n-        .end(expectErrorResponseContaining({message: 'test-error'}, ['stack'], done));","path":"test/rest.test.js","position":18,"original_position":18,"commit_id":"7bcd4fd54de441b44cd6c7a494c763a13263d30b","original_commit_id":"7bcd4fd54de441b44cd6c7a494c763a13263d30b","user":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=3","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"body":"Seems like you have accidentally removed a test, please bring it back.","created_at":"2014-11-18T16:32:26Z","updated_at":"2014-11-18T16:32:26Z","html_url":"https://github.com/strongloop/strong-remoting/pull/135#discussion_r20517683","pull_request_url":"https://api.github.com/repos/strongloop/strong-remoting/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/strongloop/strong-remoting/pulls/comments/20517683"},"html":{"href":"https://github.com/strongloop/strong-remoting/pull/135#discussion_r20517683"},"pull_request":{"href":"https://api.github.com/repos/strongloop/strong-remoting/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/strong-remoting/pulls/135","id":24623465,"html_url":"https://github.com/strongloop/strong-remoting/pull/135","diff_url":"https://github.com/strongloop/strong-remoting/pull/135.diff","patch_url":"https://github.com/strongloop/strong-remoting/pull/135.patch","issue_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/135","number":135,"state":"open","locked":false,"title":"Added options to disable method and url not found on Rest Adapter","user":{"login":"drFabio","id":2636143,"avatar_url":"https://avatars.githubusercontent.com/u/2636143?v=3","gravatar_id":"","url":"https://api.github.com/users/drFabio","html_url":"https://github.com/drFabio","followers_url":"https://api.github.com/users/drFabio/followers","following_url":"https://api.github.com/users/drFabio/following{/other_user}","gists_url":"https://api.github.com/users/drFabio/gists{/gist_id}","starred_url":"https://api.github.com/users/drFabio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drFabio/subscriptions","organizations_url":"https://api.github.com/users/drFabio/orgs","repos_url":"https://api.github.com/users/drFabio/repos","events_url":"https://api.github.com/users/drFabio/events{/privacy}","received_events_url":"https://api.github.com/users/drFabio/received_events","type":"User","site_admin":false},"body":"Added the options handleUrlNotFound and handleMethodNotFound on Rest Adapter","created_at":"2014-11-18T16:23:29Z","updated_at":"2014-11-18T16:32:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4fe3aae3c0e6959938ff494809ea773aee7c79f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/strong-remoting/pulls/135/commits","review_comments_url":"https://api.github.com/repos/strongloop/strong-remoting/pulls/135/comments","review_comment_url":"https://api.github.com/repos/strongloop/strong-remoting/pulls/comments/{number}","comments_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/135/comments","statuses_url":"https://api.github.com/repos/strongloop/strong-remoting/statuses/7bcd4fd54de441b44cd6c7a494c763a13263d30b","head":{"label":"drFabio:feature/fix-issue-129","ref":"feature/fix-issue-129","sha":"7bcd4fd54de441b44cd6c7a494c763a13263d30b","user":{"login":"drFabio","id":2636143,"avatar_url":"https://avatars.githubusercontent.com/u/2636143?v=3","gravatar_id":"","url":"https://api.github.com/users/drFabio","html_url":"https://github.com/drFabio","followers_url":"https://api.github.com/users/drFabio/followers","following_url":"https://api.github.com/users/drFabio/following{/other_user}","gists_url":"https://api.github.com/users/drFabio/gists{/gist_id}","starred_url":"https://api.github.com/users/drFabio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drFabio/subscriptions","organizations_url":"https://api.github.com/users/drFabio/orgs","repos_url":"https://api.github.com/users/drFabio/repos","events_url":"https://api.github.com/users/drFabio/events{/privacy}","received_events_url":"https://api.github.com/users/drFabio/received_events","type":"User","site_admin":false},"repo":{"id":26808565,"name":"strong-remoting","full_name":"drFabio/strong-remoting","owner":{"login":"drFabio","id":2636143,"avatar_url":"https://avatars.githubusercontent.com/u/2636143?v=3","gravatar_id":"","url":"https://api.github.com/users/drFabio","html_url":"https://github.com/drFabio","followers_url":"https://api.github.com/users/drFabio/followers","following_url":"https://api.github.com/users/drFabio/following{/other_user}","gists_url":"https://api.github.com/users/drFabio/gists{/gist_id}","starred_url":"https://api.github.com/users/drFabio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drFabio/subscriptions","organizations_url":"https://api.github.com/users/drFabio/orgs","repos_url":"https://api.github.com/users/drFabio/repos","events_url":"https://api.github.com/users/drFabio/events{/privacy}","received_events_url":"https://api.github.com/users/drFabio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drFabio/strong-remoting","description":"Communicate between objects in servers, mobile apps, and other servers.","fork":true,"url":"https://api.github.com/repos/drFabio/strong-remoting","forks_url":"https://api.github.com/repos/drFabio/strong-remoting/forks","keys_url":"https://api.github.com/repos/drFabio/strong-remoting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drFabio/strong-remoting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drFabio/strong-remoting/teams","hooks_url":"https://api.github.com/repos/drFabio/strong-remoting/hooks","issue_events_url":"https://api.github.com/repos/drFabio/strong-remoting/issues/events{/number}","events_url":"https://api.github.com/repos/drFabio/strong-remoting/events","assignees_url":"https://api.github.com/repos/drFabio/strong-remoting/assignees{/user}","branches_url":"https://api.github.com/repos/drFabio/strong-remoting/branches{/branch}","tags_url":"https://api.github.com/repos/drFabio/strong-remoting/tags","blobs_url":"https://api.github.com/repos/drFabio/strong-remoting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drFabio/strong-remoting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drFabio/strong-remoting/git/refs{/sha}","trees_url":"https://api.github.com/repos/drFabio/strong-remoting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drFabio/strong-remoting/statuses/{sha}","languages_url":"https://api.github.com/repos/drFabio/strong-remoting/languages","stargazers_url":"https://api.github.com/repos/drFabio/strong-remoting/stargazers","contributors_url":"https://api.github.com/repos/drFabio/strong-remoting/contributors","subscribers_url":"https://api.github.com/repos/drFabio/strong-remoting/subscribers","subscription_url":"https://api.github.com/repos/drFabio/strong-remoting/subscription","commits_url":"https://api.github.com/repos/drFabio/strong-remoting/commits{/sha}","git_commits_url":"https://api.github.com/repos/drFabio/strong-remoting/git/commits{/sha}","comments_url":"https://api.github.com/repos/drFabio/strong-remoting/comments{/number}","issue_comment_url":"https://api.github.com/repos/drFabio/strong-remoting/issues/comments/{number}","contents_url":"https://api.github.com/repos/drFabio/strong-remoting/contents/{+path}","compare_url":"https://api.github.com/repos/drFabio/strong-remoting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drFabio/strong-remoting/merges","archive_url":"https://api.github.com/repos/drFabio/strong-remoting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drFabio/strong-remoting/downloads","issues_url":"https://api.github.com/repos/drFabio/strong-remoting/issues{/number}","pulls_url":"https://api.github.com/repos/drFabio/strong-remoting/pulls{/number}","milestones_url":"https://api.github.com/repos/drFabio/strong-remoting/milestones{/number}","notifications_url":"https://api.github.com/repos/drFabio/strong-remoting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drFabio/strong-remoting/labels{/name}","releases_url":"https://api.github.com/repos/drFabio/strong-remoting/releases{/id}","created_at":"2014-11-18T12:39:15Z","updated_at":"2014-11-18T12:39:16Z","pushed_at":"2014-11-18T16:21:52Z","git_url":"git://github.com/drFabio/strong-remoting.git","ssh_url":"git@github.com:drFabio/strong-remoting.git","clone_url":"https://github.com/drFabio/strong-remoting.git","svn_url":"https://github.com/drFabio/strong-remoting","homepage":"www.strongloop.com","size":2939,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"02d6cbcb740a4224b63a149ebf2f7d46b61210c4","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":10045175,"name":"strong-remoting","full_name":"strongloop/strong-remoting","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/strong-remoting","description":"Communicate between objects in servers, mobile apps, and other servers.","fork":false,"url":"https://api.github.com/repos/strongloop/strong-remoting","forks_url":"https://api.github.com/repos/strongloop/strong-remoting/forks","keys_url":"https://api.github.com/repos/strongloop/strong-remoting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/strong-remoting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/strong-remoting/teams","hooks_url":"https://api.github.com/repos/strongloop/strong-remoting/hooks","issue_events_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/strong-remoting/events","assignees_url":"https://api.github.com/repos/strongloop/strong-remoting/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/strong-remoting/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/strong-remoting/tags","blobs_url":"https://api.github.com/repos/strongloop/strong-remoting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/strong-remoting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/strong-remoting/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/strong-remoting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/strong-remoting/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/strong-remoting/languages","stargazers_url":"https://api.github.com/repos/strongloop/strong-remoting/stargazers","contributors_url":"https://api.github.com/repos/strongloop/strong-remoting/contributors","subscribers_url":"https://api.github.com/repos/strongloop/strong-remoting/subscribers","subscription_url":"https://api.github.com/repos/strongloop/strong-remoting/subscription","commits_url":"https://api.github.com/repos/strongloop/strong-remoting/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/strong-remoting/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/strong-remoting/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/comments/{number}","contents_url":"https://api.github.com/repos/strongloop/strong-remoting/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/strong-remoting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/strong-remoting/merges","archive_url":"https://api.github.com/repos/strongloop/strong-remoting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/strong-remoting/downloads","issues_url":"https://api.github.com/repos/strongloop/strong-remoting/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/strong-remoting/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/strong-remoting/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/strong-remoting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/strong-remoting/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/strong-remoting/releases{/id}","created_at":"2013-05-14T01:53:04Z","updated_at":"2014-11-18T07:32:04Z","pushed_at":"2014-11-18T07:32:04Z","git_url":"git://github.com/strongloop/strong-remoting.git","ssh_url":"git@github.com:strongloop/strong-remoting.git","clone_url":"https://github.com/strongloop/strong-remoting.git","svn_url":"https://github.com/strongloop/strong-remoting","homepage":"www.strongloop.com","size":2939,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":13,"forks":20,"open_issues":13,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/strong-remoting/pulls/135"},"html":{"href":"https://github.com/strongloop/strong-remoting/pull/135"},"issue":{"href":"https://api.github.com/repos/strongloop/strong-remoting/issues/135"},"comments":{"href":"https://api.github.com/repos/strongloop/strong-remoting/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/strong-remoting/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/strong-remoting/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/strongloop/strong-remoting/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/strong-remoting/statuses/7bcd4fd54de441b44cd6c7a494c763a13263d30b"}}}}