GitHub PullRequestReviewCommentEvent at 2014-05-22 08:11:21
Repository: core
Actor: PVince81
Payload: {"comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/12939027","id":12939027,"diff_hunk":"@@ -1,4 +1,47 @@\n+var SharingGroupList = {\n+\tapplyMultiplySelect: function(element) {\n+\t\tvar checked = [];\n+\t\tif ($(element).hasClass('groupsselect')) {\n+\t\t\tif (element.data('userGroups')) {\n+\t\t\t\tchecked = element.data('userGroups');\n+\t\t\t}\n+\t\t\tvar checkHandeler = function(group) {\n+\t\t\t\t\t$.post(OC.filePath('settings', 'ajax', 'excludegroups.php'),\n+\t\t\t\t\t\t{changedGroup: group, selectedGroups: JSON.stringify(checked)},\n+\t\t\t\t\t\tfunction() {});\n+\t\t\t\t};\n+\n+\t\t\tvar addGroup = function(select, group) {\n+\t\t\t\t$('select[multiple]').each(function(index, element) {","path":"settings/js/admin.js","position":15,"original_position":15,"commit_id":"63ee1239a9e3ce7583e0c18333d91cff21ebc655","original_commit_id":"63ee1239a9e3ce7583e0c18333d91cff21ebc655","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?","gravatar_id":"e446b529679416eb70eafb4ca4da5bbe","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"body":"See my comment below about the selector.\r\n\r\nI believe you should be able to use `$(select)` here or `$(this)` because the multiSelect plugin should pass you the \"select\" tag (not 100% sure). Else try using a more specific selector.","created_at":"2014-05-22T08:11:21Z","updated_at":"2014-05-22T08:11:21Z","html_url":"https://github.com/owncloud/core/pull/8599#discussion_r12939027","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/8599","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/12939027"},"html":{"href":"https://github.com/owncloud/core/pull/8599#discussion_r12939027"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/8599"}}}}