GitHub PullRequestReviewCommentEvent at 2014-08-07 01:40:24
Repository: kubernetes
Actor: adam-mesos
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/15914747","id":15914747,"diff_hunk":"@@ -0,0 +1,80 @@\n+/*\n+Copyright 2014 Google Inc. All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package registry\n+\n+import (\n+\t\"fmt\"\n+\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/api\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/apiserver\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/labels\"\n+)\n+\n+// BindingStorage implements the RESTStorage interface. When bindings are written, it\n+// changes the location of the affected pods. This information is eventually reflected\n+// in the pod's CurrentState.Host field.\n+type BindingStorage struct {","path":"pkg/registry/bindingstorage.go","position":30,"original_position":30,"commit_id":"1614905ce8531a1c1d57dec99f72690fa3ee6207","original_commit_id":"1614905ce8531a1c1d57dec99f72690fa3ee6207","user":{"login":"adam-mesos","id":6456528,"avatar_url":"https://avatars.githubusercontent.com/u/6456528?v=2","gravatar_id":"0f90ea18a759144735a22aee585ccc23","url":"https://api.github.com/users/adam-mesos","html_url":"https://github.com/adam-mesos","followers_url":"https://api.github.com/users/adam-mesos/followers","following_url":"https://api.github.com/users/adam-mesos/following{/other_user}","gists_url":"https://api.github.com/users/adam-mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-mesos/subscriptions","organizations_url":"https://api.github.com/users/adam-mesos/orgs","repos_url":"https://api.github.com/users/adam-mesos/repos","events_url":"https://api.github.com/users/adam-mesos/events{/privacy}","received_events_url":"https://api.github.com/users/adam-mesos/received_events","type":"User","site_admin":false},"body":"Would love to discuss this more in-real-time over a call. Please email me (adam-at-mesosphere.io) so we can schedule a time and I can invite others working on our Kubernetes-Mesos framework.","created_at":"2014-08-07T01:40:24Z","updated_at":"2014-08-07T01:40:24Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/592#discussion_r15914747","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/592","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/15914747"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/592#discussion_r15914747"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/592"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/592","id":18809283,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/592","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/592.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/592.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/592","number":592,"state":"open","title":"Proposal for scheduler API","user":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=2","gravatar_id":"1a843544abcf9f764d28e3427a4a9610","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"body":"This commit adds a Binding object. The idea is that schedulers can write\r\nthese to cause pods to be asssigned to hosts. No implementation is\r\nprovided; if this is accepted, I'll write that once we get pods moved to\r\na different etcd key.\r\n\r\nThis continues k8s' tradition of phrasing all APIs as RESTful handlers.","created_at":"2014-07-23T23:14:01Z","updated_at":"2014-08-07T01:40:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c1df56e4c2f7b179b884616db202eefbd71624e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/592/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/592/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/592/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/1614905ce8531a1c1d57dec99f72690fa3ee6207","head":{"label":"lavalamp:schedulerApi","ref":"schedulerApi","sha":"1614905ce8531a1c1d57dec99f72690fa3ee6207","user":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=2","gravatar_id":"1a843544abcf9f764d28e3427a4a9610","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"repo":{"id":20749157,"name":"kubernetes","full_name":"lavalamp/kubernetes","owner":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=2","gravatar_id":"1a843544abcf9f764d28e3427a4a9610","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lavalamp/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/lavalamp/kubernetes","forks_url":"https://api.github.com/repos/lavalamp/kubernetes/forks","keys_url":"https://api.github.com/repos/lavalamp/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lavalamp/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lavalamp/kubernetes/teams","hooks_url":"https://api.github.com/repos/lavalamp/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/lavalamp/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/lavalamp/kubernetes/events","assignees_url":"https://api.github.com/repos/lavalamp/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/lavalamp/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/lavalamp/kubernetes/tags","blobs_url":"https://api.github.com/repos/lavalamp/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lavalamp/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lavalamp/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/lavalamp/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lavalamp/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/lavalamp/kubernetes/languages","stargazers_url":"https://api.github.com/repos/lavalamp/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/lavalamp/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/lavalamp/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/lavalamp/kubernetes/subscription","commits_url":"https://api.github.com/repos/lavalamp/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/lavalamp/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/lavalamp/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/lavalamp/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/lavalamp/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/lavalamp/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lavalamp/kubernetes/merges","archive_url":"https://api.github.com/repos/lavalamp/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lavalamp/kubernetes/downloads","issues_url":"https://api.github.com/repos/lavalamp/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/lavalamp/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/lavalamp/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/lavalamp/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lavalamp/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/lavalamp/kubernetes/releases{/id}","created_at":"2014-06-12T00:36:13Z","updated_at":"2014-07-15T22:39:06Z","pushed_at":"2014-08-06T22:05:24Z","git_url":"git://github.com/lavalamp/kubernetes.git","ssh_url":"git@github.com:lavalamp/kubernetes.git","clone_url":"https://github.com/lavalamp/kubernetes.git","svn_url":"https://github.com/lavalamp/kubernetes","homepage":null,"size":9824,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"241ab692f61ae7a5f6f2226dceb552af80eb5c5c","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=2","gravatar_id":"3db02c6238c8b1fb844871330744ec5d","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=2","gravatar_id":"3db02c6238c8b1fb844871330744ec5d","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2014-08-07T00:38:14Z","pushed_at":"2014-08-06T23:59:18Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":null,"size":19758,"stargazers_count":2924,"watchers_count":2924,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":364,"mirror_url":null,"open_issues_count":148,"forks":364,"open_issues":148,"watchers":2924,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/592"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/592"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/592"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/592/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/592/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/592/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/1614905ce8531a1c1d57dec99f72690fa3ee6207"}}}}