GitHub PullRequestReviewCommentEvent at 2014-07-25 16:29:48
Repository: yast-bootloader
Actor: jreidinger
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-bootloader/pulls/comments/15410284","id":15410284,"diff_hunk":"@@ -57,11 +57,16 @@ def main\n         if Mode.update\n           if [\"grub2\", \"grub2-efi\"].include? old_bootloader\n             Builtins.y2milestone \"update of grub2, do not repropose\"\n-            Bootloader.blRead(true, true)\n+            if !BootCommon.was_read || @force_reset\n+              Bootloader.blRead(true, true)\n+              BootCommon.was_read = true","path":"src/clients/bootloader_proposal.rb","position":7,"original_position":7,"commit_id":"3e02aaa43f95423af67c76e5f639caae898aba9c","original_commit_id":"3e02aaa43f95423af67c76e5f639caae898aba9c","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars.githubusercontent.com/u/478871?","gravatar_id":"f9a9cf77af20d925b328ee8c95c0068c","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"This is very tricky. Reason is that we call `Bootloader.blRead(true, true)` instead of `Bootloader.Read`. Reason is that Read contain hardcoded Progress!!! So I need to set it manually. In general this code is quite nasty, but I do not want to break it to much in RC phase and because there is no tests (!!!) expect separated grub2 encrypted password feature I do not feel brave enough.","created_at":"2014-07-25T16:29:48Z","updated_at":"2014-07-25T16:29:48Z","html_url":"https://github.com/yast/yast-bootloader/pull/124#discussion_r15410284","pull_request_url":"https://api.github.com/repos/yast/yast-bootloader/pulls/124","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-bootloader/pulls/comments/15410284"},"html":{"href":"https://github.com/yast/yast-bootloader/pull/124#discussion_r15410284"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-bootloader/pulls/124"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-bootloader/pulls/124","id":18904662,"html_url":"https://github.com/yast/yast-bootloader/pull/124","diff_url":"https://github.com/yast/yast-bootloader/pull/124.diff","patch_url":"https://github.com/yast/yast-bootloader/pull/124.patch","issue_url":"https://api.github.com/repos/yast/yast-bootloader/issues/124","number":124,"state":"open","title":"Fix upgrade repropose","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars.githubusercontent.com/u/478871?","gravatar_id":"f9a9cf77af20d925b328ee8c95c0068c","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-25T16:13:50Z","updated_at":"2014-07-25T16:29:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b5c4af844e290d296f4a1397ac33dee03c89c46","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-bootloader/pulls/124/commits","review_comments_url":"https://api.github.com/repos/yast/yast-bootloader/pulls/124/comments","review_comment_url":"https://api.github.com/repos/yast/yast-bootloader/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yast/yast-bootloader/issues/124/comments","statuses_url":"https://api.github.com/repos/yast/yast-bootloader/statuses/3e02aaa43f95423af67c76e5f639caae898aba9c","head":{"label":"yast:fix_upgrade_repropose","ref":"fix_upgrade_repropose","sha":"3e02aaa43f95423af67c76e5f639caae898aba9c","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368075,"name":"yast-bootloader","full_name":"yast/yast-bootloader","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-bootloader","description":"YaST module bootloader","fork":false,"url":"https://api.github.com/repos/yast/yast-bootloader","forks_url":"https://api.github.com/repos/yast/yast-bootloader/forks","keys_url":"https://api.github.com/repos/yast/yast-bootloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-bootloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-bootloader/teams","hooks_url":"https://api.github.com/repos/yast/yast-bootloader/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-bootloader/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-bootloader/events","assignees_url":"https://api.github.com/repos/yast/yast-bootloader/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-bootloader/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-bootloader/tags","blobs_url":"https://api.github.com/repos/yast/yast-bootloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-bootloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-bootloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-bootloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-bootloader/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-bootloader/languages","stargazers_url":"https://api.github.com/repos/yast/yast-bootloader/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-bootloader/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-bootloader/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-bootloader/subscription","commits_url":"https://api.github.com/repos/yast/yast-bootloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-bootloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-bootloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-bootloader/issues/comments/{number}","contents_url":"https://api.github.com/repos/yast/yast-bootloader/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-bootloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-bootloader/merges","archive_url":"https://api.github.com/repos/yast/yast-bootloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-bootloader/downloads","issues_url":"https://api.github.com/repos/yast/yast-bootloader/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-bootloader/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-bootloader/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-bootloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-bootloader/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-bootloader/releases{/id}","created_at":"2012-05-18T10:22:41Z","updated_at":"2014-06-26T11:41:16Z","pushed_at":"2014-07-25T16:13:42Z","git_url":"git://github.com/yast/yast-bootloader.git","ssh_url":"git@github.com:yast/yast-bootloader.git","clone_url":"https://github.com/yast/yast-bootloader.git","svn_url":"https://github.com/yast/yast-bootloader","homepage":"http://en.opensuse.org/Portal:YaST","size":25103,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"9e7468f46b1bcf6e32cb61e9e417340c94fbab3a","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368075,"name":"yast-bootloader","full_name":"yast/yast-bootloader","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?","gravatar_id":"e467a14202136d0b384e7b8ce386d6d5","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-bootloader","description":"YaST module bootloader","fork":false,"url":"https://api.github.com/repos/yast/yast-bootloader","forks_url":"https://api.github.com/repos/yast/yast-bootloader/forks","keys_url":"https://api.github.com/repos/yast/yast-bootloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-bootloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-bootloader/teams","hooks_url":"https://api.github.com/repos/yast/yast-bootloader/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-bootloader/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-bootloader/events","assignees_url":"https://api.github.com/repos/yast/yast-bootloader/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-bootloader/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-bootloader/tags","blobs_url":"https://api.github.com/repos/yast/yast-bootloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-bootloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-bootloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-bootloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-bootloader/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-bootloader/languages","stargazers_url":"https://api.github.com/repos/yast/yast-bootloader/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-bootloader/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-bootloader/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-bootloader/subscription","commits_url":"https://api.github.com/repos/yast/yast-bootloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-bootloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-bootloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-bootloader/issues/comments/{number}","contents_url":"https://api.github.com/repos/yast/yast-bootloader/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-bootloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-bootloader/merges","archive_url":"https://api.github.com/repos/yast/yast-bootloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-bootloader/downloads","issues_url":"https://api.github.com/repos/yast/yast-bootloader/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-bootloader/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-bootloader/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-bootloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-bootloader/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-bootloader/releases{/id}","created_at":"2012-05-18T10:22:41Z","updated_at":"2014-06-26T11:41:16Z","pushed_at":"2014-07-25T16:13:42Z","git_url":"git://github.com/yast/yast-bootloader.git","ssh_url":"git@github.com:yast/yast-bootloader.git","clone_url":"https://github.com/yast/yast-bootloader.git","svn_url":"https://github.com/yast/yast-bootloader","homepage":"http://en.opensuse.org/Portal:YaST","size":25103,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-bootloader/pulls/124"},"html":{"href":"https://github.com/yast/yast-bootloader/pull/124"},"issue":{"href":"https://api.github.com/repos/yast/yast-bootloader/issues/124"},"comments":{"href":"https://api.github.com/repos/yast/yast-bootloader/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-bootloader/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-bootloader/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-bootloader/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-bootloader/statuses/3e02aaa43f95423af67c76e5f639caae898aba9c"}}}}