GitHub PullRequestReviewCommentEvent at 2014-03-13 08:12:39
Repository: jdeferred
Actor: David402
Payload: {"comment":{"url":"https://api.github.com/repos/David402/jdeferred/pulls/comments/10555461","id":10555461,"diff_hunk":"@@ -110,6 +110,17 @@ public AndroidDeferredManager(ExecutorService executorService) {\n \t\treturn when(promises);\n \t}\n \t\n+\t@SuppressWarnings(\"rawtypes\")\n+    public Promise<MultipleResults, OneReject, MasterProgress> when(AndroidExecutionScope scope,","path":"android/library/src/org/jdeferred/android/AndroidDeferredManager.java","position":5,"original_position":5,"commit_id":"057585f00499cc42460e7f785a7b3cc0d00ce6b1","original_commit_id":"057585f00499cc42460e7f785a7b3cc0d00ce6b1","user":{"login":"David402","id":1995219,"avatar_url":"https://gravatar.com/avatar/bf44e647fea6c5cae3e287e249cf275b?d=https%3A%2F%2Fidenticons.github.com%2F11ee024fe65def2b4c35503767588737.png&r=x","gravatar_id":"bf44e647fea6c5cae3e287e249cf275b","url":"https://api.github.com/users/David402","html_url":"https://github.com/David402","followers_url":"https://api.github.com/users/David402/followers","following_url":"https://api.github.com/users/David402/following{/other_user}","gists_url":"https://api.github.com/users/David402/gists{/gist_id}","starred_url":"https://api.github.com/users/David402/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/David402/subscriptions","organizations_url":"https://api.github.com/users/David402/orgs","repos_url":"https://api.github.com/users/David402/repos","events_url":"https://api.github.com/users/David402/events{/privacy}","received_events_url":"https://api.github.com/users/David402/received_events","type":"User","site_admin":false},"body":"You are right, so make `scope` be the first parameter, like `when(scope, tasks)`, `when(scope, promises)` and `when(scope, promise)`.","created_at":"2014-03-13T08:12:39Z","updated_at":"2014-03-13T08:12:39Z","html_url":"https://github.com/David402/jdeferred/pull/1#discussion_r10555461","pull_request_url":"https://api.github.com/repos/David402/jdeferred/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/David402/jdeferred/pulls/comments/10555461"},"html":{"href":"https://github.com/David402/jdeferred/pull/1#discussion_r10555461"},"pull_request":{"href":"https://api.github.com/repos/David402/jdeferred/pulls/1"}}}}