GitHub PullRequestReviewCommentEvent at 2014-10-31 22:32:34
Repository: ipython
Actor: jdfreder
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jdfreder/ipython/pulls/comments/19697366","id":19697366,"diff_hunk":"@@ -584,12 +584,27 @@ define([\n                 if (registry && registry[class_name]) {\n                     resolve(registry[class_name]);\n                 } else {\n-                    reject(Error('Class not found in registry.'));\n+                    reject(new Error('Class not found in registry.'));\n                 }\n             }\n         });\n     };\n \n+    var resolve_dict = function(d) {\n+        var keys = Object.keys(d);\n+        var values = [];\n+        keys.forEach(function(key) {\n+            values.push(key);","path":"IPython/html/static/base/js/utils.js","position":33,"original_position":33,"commit_id":"0aeb4e875ee23ea92651e791b26d9eb9251169ed","original_commit_id":"0aeb4e875ee23ea92651e791b26d9eb9251169ed","user":{"login":"jdfreder","id":3292874,"avatar_url":"https://avatars.githubusercontent.com/u/3292874?v=2","gravatar_id":"","url":"https://api.github.com/users/jdfreder","html_url":"https://github.com/jdfreder","followers_url":"https://api.github.com/users/jdfreder/followers","following_url":"https://api.github.com/users/jdfreder/following{/other_user}","gists_url":"https://api.github.com/users/jdfreder/gists{/gist_id}","starred_url":"https://api.github.com/users/jdfreder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdfreder/subscriptions","organizations_url":"https://api.github.com/users/jdfreder/orgs","repos_url":"https://api.github.com/users/jdfreder/repos","events_url":"https://api.github.com/users/jdfreder/events{/privacy}","received_events_url":"https://api.github.com/users/jdfreder/received_events","type":"User","site_admin":false},"body":"push(d[key])","created_at":"2014-10-31T22:32:34Z","updated_at":"2014-10-31T22:32:34Z","html_url":"https://github.com/jdfreder/ipython/pull/22#discussion_r19697366","pull_request_url":"https://api.github.com/repos/jdfreder/ipython/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/jdfreder/ipython/pulls/comments/19697366"},"html":{"href":"https://github.com/jdfreder/ipython/pull/22#discussion_r19697366"},"pull_request":{"href":"https://api.github.com/repos/jdfreder/ipython/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/jdfreder/ipython/pulls/22","id":23687305,"html_url":"https://github.com/jdfreder/ipython/pull/22","diff_url":"https://github.com/jdfreder/ipython/pull/22.diff","patch_url":"https://github.com/jdfreder/ipython/pull/22.patch","issue_url":"https://api.github.com/repos/jdfreder/ipython/issues/22","number":22,"state":"open","locked":false,"title":"Simplify code by using Promises in a better way; try_load -> load","user":{"login":"jasongrout","id":192614,"avatar_url":"https://avatars.githubusercontent.com/u/192614?v=2","gravatar_id":"","url":"https://api.github.com/users/jasongrout","html_url":"https://github.com/jasongrout","followers_url":"https://api.github.com/users/jasongrout/followers","following_url":"https://api.github.com/users/jasongrout/following{/other_user}","gists_url":"https://api.github.com/users/jasongrout/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongrout/subscriptions","organizations_url":"https://api.github.com/users/jasongrout/orgs","repos_url":"https://api.github.com/users/jasongrout/repos","events_url":"https://api.github.com/users/jasongrout/events{/privacy}","received_events_url":"https://api.github.com/users/jasongrout/received_events","type":"User","site_admin":false},"body":"I haven't tested this, but I think it should work.","created_at":"2014-10-31T16:14:25Z","updated_at":"2014-10-31T22:32:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89adc07b1ae725ff0e1609bd8f3f979f914fd7ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jdfreder/ipython/pulls/22/commits","review_comments_url":"https://api.github.com/repos/jdfreder/ipython/pulls/22/comments","review_comment_url":"https://api.github.com/repos/jdfreder/ipython/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jdfreder/ipython/issues/22/comments","statuses_url":"https://api.github.com/repos/jdfreder/ipython/statuses/0aeb4e875ee23ea92651e791b26d9eb9251169ed","head":{"label":"jasongrout:race_conditions","ref":"race_conditions","sha":"0aeb4e875ee23ea92651e791b26d9eb9251169ed","user":{"login":"jasongrout","id":192614,"avatar_url":"https://avatars.githubusercontent.com/u/192614?v=2","gravatar_id":"","url":"https://api.github.com/users/jasongrout","html_url":"https://github.com/jasongrout","followers_url":"https://api.github.com/users/jasongrout/followers","following_url":"https://api.github.com/users/jasongrout/following{/other_user}","gists_url":"https://api.github.com/users/jasongrout/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongrout/subscriptions","organizations_url":"https://api.github.com/users/jasongrout/orgs","repos_url":"https://api.github.com/users/jasongrout/repos","events_url":"https://api.github.com/users/jasongrout/events{/privacy}","received_events_url":"https://api.github.com/users/jasongrout/received_events","type":"User","site_admin":false},"repo":{"id":1734383,"name":"ipython","full_name":"jasongrout/ipython","owner":{"login":"jasongrout","id":192614,"avatar_url":"https://avatars.githubusercontent.com/u/192614?v=2","gravatar_id":"","url":"https://api.github.com/users/jasongrout","html_url":"https://github.com/jasongrout","followers_url":"https://api.github.com/users/jasongrout/followers","following_url":"https://api.github.com/users/jasongrout/following{/other_user}","gists_url":"https://api.github.com/users/jasongrout/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongrout/subscriptions","organizations_url":"https://api.github.com/users/jasongrout/orgs","repos_url":"https://api.github.com/users/jasongrout/repos","events_url":"https://api.github.com/users/jasongrout/events{/privacy}","received_events_url":"https://api.github.com/users/jasongrout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasongrout/ipython","description":"Official IPython repository. All documentation is available at: http://ipython.github.com/ipython-doc","fork":true,"url":"https://api.github.com/repos/jasongrout/ipython","forks_url":"https://api.github.com/repos/jasongrout/ipython/forks","keys_url":"https://api.github.com/repos/jasongrout/ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasongrout/ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasongrout/ipython/teams","hooks_url":"https://api.github.com/repos/jasongrout/ipython/hooks","issue_events_url":"https://api.github.com/repos/jasongrout/ipython/issues/events{/number}","events_url":"https://api.github.com/repos/jasongrout/ipython/events","assignees_url":"https://api.github.com/repos/jasongrout/ipython/assignees{/user}","branches_url":"https://api.github.com/repos/jasongrout/ipython/branches{/branch}","tags_url":"https://api.github.com/repos/jasongrout/ipython/tags","blobs_url":"https://api.github.com/repos/jasongrout/ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasongrout/ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasongrout/ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasongrout/ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasongrout/ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/jasongrout/ipython/languages","stargazers_url":"https://api.github.com/repos/jasongrout/ipython/stargazers","contributors_url":"https://api.github.com/repos/jasongrout/ipython/contributors","subscribers_url":"https://api.github.com/repos/jasongrout/ipython/subscribers","subscription_url":"https://api.github.com/repos/jasongrout/ipython/subscription","commits_url":"https://api.github.com/repos/jasongrout/ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasongrout/ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasongrout/ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasongrout/ipython/issues/comments/{number}","contents_url":"https://api.github.com/repos/jasongrout/ipython/contents/{+path}","compare_url":"https://api.github.com/repos/jasongrout/ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasongrout/ipython/merges","archive_url":"https://api.github.com/repos/jasongrout/ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasongrout/ipython/downloads","issues_url":"https://api.github.com/repos/jasongrout/ipython/issues{/number}","pulls_url":"https://api.github.com/repos/jasongrout/ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/jasongrout/ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/jasongrout/ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasongrout/ipython/labels{/name}","releases_url":"https://api.github.com/repos/jasongrout/ipython/releases{/id}","created_at":"2011-05-11T17:33:45Z","updated_at":"2014-08-18T21:17:54Z","pushed_at":"2014-10-31T20:45:26Z","git_url":"git://github.com/jasongrout/ipython.git","ssh_url":"git@github.com:jasongrout/ipython.git","clone_url":"https://github.com/jasongrout/ipython.git","svn_url":"https://github.com/jasongrout/ipython","homepage":"http://ipython.scipy.org","size":62464,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"jdfreder:race_conditions","ref":"race_conditions","sha":"2fef7f346a1af01c2bfe3133cc5a9937fd12f43f","user":{"login":"jdfreder","id":3292874,"avatar_url":"https://avatars.githubusercontent.com/u/3292874?v=2","gravatar_id":"","url":"https://api.github.com/users/jdfreder","html_url":"https://github.com/jdfreder","followers_url":"https://api.github.com/users/jdfreder/followers","following_url":"https://api.github.com/users/jdfreder/following{/other_user}","gists_url":"https://api.github.com/users/jdfreder/gists{/gist_id}","starred_url":"https://api.github.com/users/jdfreder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdfreder/subscriptions","organizations_url":"https://api.github.com/users/jdfreder/orgs","repos_url":"https://api.github.com/users/jdfreder/repos","events_url":"https://api.github.com/users/jdfreder/events{/privacy}","received_events_url":"https://api.github.com/users/jdfreder/received_events","type":"User","site_admin":false},"repo":{"id":7768091,"name":"ipython","full_name":"jdfreder/ipython","owner":{"login":"jdfreder","id":3292874,"avatar_url":"https://avatars.githubusercontent.com/u/3292874?v=2","gravatar_id":"","url":"https://api.github.com/users/jdfreder","html_url":"https://github.com/jdfreder","followers_url":"https://api.github.com/users/jdfreder/followers","following_url":"https://api.github.com/users/jdfreder/following{/other_user}","gists_url":"https://api.github.com/users/jdfreder/gists{/gist_id}","starred_url":"https://api.github.com/users/jdfreder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdfreder/subscriptions","organizations_url":"https://api.github.com/users/jdfreder/orgs","repos_url":"https://api.github.com/users/jdfreder/repos","events_url":"https://api.github.com/users/jdfreder/events{/privacy}","received_events_url":"https://api.github.com/users/jdfreder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdfreder/ipython","description":"Official repository for IPython itself. Other repos in the IPython organization contain things like the website, documentation builds, etc.","fork":true,"url":"https://api.github.com/repos/jdfreder/ipython","forks_url":"https://api.github.com/repos/jdfreder/ipython/forks","keys_url":"https://api.github.com/repos/jdfreder/ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdfreder/ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdfreder/ipython/teams","hooks_url":"https://api.github.com/repos/jdfreder/ipython/hooks","issue_events_url":"https://api.github.com/repos/jdfreder/ipython/issues/events{/number}","events_url":"https://api.github.com/repos/jdfreder/ipython/events","assignees_url":"https://api.github.com/repos/jdfreder/ipython/assignees{/user}","branches_url":"https://api.github.com/repos/jdfreder/ipython/branches{/branch}","tags_url":"https://api.github.com/repos/jdfreder/ipython/tags","blobs_url":"https://api.github.com/repos/jdfreder/ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdfreder/ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdfreder/ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdfreder/ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdfreder/ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/jdfreder/ipython/languages","stargazers_url":"https://api.github.com/repos/jdfreder/ipython/stargazers","contributors_url":"https://api.github.com/repos/jdfreder/ipython/contributors","subscribers_url":"https://api.github.com/repos/jdfreder/ipython/subscribers","subscription_url":"https://api.github.com/repos/jdfreder/ipython/subscription","commits_url":"https://api.github.com/repos/jdfreder/ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdfreder/ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdfreder/ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdfreder/ipython/issues/comments/{number}","contents_url":"https://api.github.com/repos/jdfreder/ipython/contents/{+path}","compare_url":"https://api.github.com/repos/jdfreder/ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdfreder/ipython/merges","archive_url":"https://api.github.com/repos/jdfreder/ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdfreder/ipython/downloads","issues_url":"https://api.github.com/repos/jdfreder/ipython/issues{/number}","pulls_url":"https://api.github.com/repos/jdfreder/ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/jdfreder/ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/jdfreder/ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdfreder/ipython/labels{/name}","releases_url":"https://api.github.com/repos/jdfreder/ipython/releases{/id}","created_at":"2013-01-23T05:05:43Z","updated_at":"2014-09-15T18:39:28Z","pushed_at":"2014-10-31T18:00:50Z","git_url":"git://github.com/jdfreder/ipython.git","ssh_url":"git@github.com:jdfreder/ipython.git","clone_url":"https://github.com/jdfreder/ipython.git","svn_url":"https://github.com/jdfreder/ipython","homepage":"http://ipython.org","size":71981,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jdfreder/ipython/pulls/22"},"html":{"href":"https://github.com/jdfreder/ipython/pull/22"},"issue":{"href":"https://api.github.com/repos/jdfreder/ipython/issues/22"},"comments":{"href":"https://api.github.com/repos/jdfreder/ipython/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/jdfreder/ipython/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/jdfreder/ipython/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jdfreder/ipython/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/jdfreder/ipython/statuses/0aeb4e875ee23ea92651e791b26d9eb9251169ed"}}}}