GitHub PullRequestReviewCommentEvent at 2014-07-03 21:04:45
Repository: geoserver
Actor: ischneider
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/14537819","id":14537819,"diff_hunk":"@@ -7,9 +7,31 @@\n import javax.annotation.Nullable;\n \n import com.google.common.base.Joiner;\n+import java.sql.Connection;\n+import java.sql.SQLException;\n+import javax.sql.DataSource;\n \n public class Dialect {\n \n+    // yuck\n+    static Dialect instance;\n+\n+    // yuck\n+    public static void install(DataSource dataSource) {\n+        try {\n+            Connection conn = dataSource.getConnection();\n+            String driver = conn.getMetaData().getDriverName();\n+            if (driver.indexOf(\"Oracle\") >= 0) {\n+                instance = new OracleDialect();\n+            } else {\n+                instance = new Dialect();\n+            }\n+            conn.close();\n+        } catch (SQLException ex) {\n+            throw new RuntimeException(ex);\n+        }\n+    }\n+","path":"src/community/jdbcconfig/src/main/java/org/geoserver/jdbcconfig/internal/Dialect.java","position":28,"original_position":28,"commit_id":"b67373b70ec7c38181047af0dcc6def105599d76","original_commit_id":"b67373b70ec7c38181047af0dcc6def105599d76","user":{"login":"ischneider","id":794512,"avatar_url":"https://avatars.githubusercontent.com/u/794512?","gravatar_id":"15a62eff50def0e0dfeba59d7a9ea01c","url":"https://api.github.com/users/ischneider","html_url":"https://github.com/ischneider","followers_url":"https://api.github.com/users/ischneider/followers","following_url":"https://api.github.com/users/ischneider/following{/other_user}","gists_url":"https://api.github.com/users/ischneider/gists{/gist_id}","starred_url":"https://api.github.com/users/ischneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ischneider/subscriptions","organizations_url":"https://api.github.com/users/ischneider/orgs","repos_url":"https://api.github.com/users/ischneider/repos","events_url":"https://api.github.com/users/ischneider/events{/privacy}","received_events_url":"https://api.github.com/users/ischneider/received_events","type":"User","site_admin":false},"body":"@jdeolive I'll add a Dialect parameter to the static factory methods","created_at":"2014-07-03T21:04:45Z","updated_at":"2014-07-03T21:04:45Z","html_url":"https://github.com/geoserver/geoserver/pull/631#discussion_r14537819","pull_request_url":"https://api.github.com/repos/geoserver/geoserver/pulls/631","_links":{"self":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/14537819"},"html":{"href":"https://github.com/geoserver/geoserver/pull/631#discussion_r14537819"},"pull_request":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/631"}}},"pull_request":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/631","id":17798783,"html_url":"https://github.com/geoserver/geoserver/pull/631","diff_url":"https://github.com/geoserver/geoserver/pull/631.diff","patch_url":"https://github.com/geoserver/geoserver/pull/631.patch","issue_url":"https://api.github.com/repos/geoserver/geoserver/issues/631","number":631,"state":"open","title":"Jdbcconfig oracle","user":{"login":"ischneider","id":794512,"avatar_url":"https://avatars.githubusercontent.com/u/794512?","gravatar_id":"15a62eff50def0e0dfeba59d7a9ea01c","url":"https://api.github.com/users/ischneider","html_url":"https://github.com/ischneider","followers_url":"https://api.github.com/users/ischneider/followers","following_url":"https://api.github.com/users/ischneider/following{/other_user}","gists_url":"https://api.github.com/users/ischneider/gists{/gist_id}","starred_url":"https://api.github.com/users/ischneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ischneider/subscriptions","organizations_url":"https://api.github.com/users/ischneider/orgs","repos_url":"https://api.github.com/users/ischneider/repos","events_url":"https://api.github.com/users/ischneider/events{/privacy}","received_events_url":"https://api.github.com/users/ischneider/received_events","type":"User","site_admin":false},"body":"This fixes a number of oracle SQL issues.\r\n\r\n@jdeolive, @groldan, @smithkm thoughts?\r\n\r\nI'm not a big fan of the Dialect `instance` field, but the other stuff took a while.\r\n\r\nErr, and just noticed my odd commit message type (stagetraces)... I'll fix that","created_at":"2014-06-30T21:18:23Z","updated_at":"2014-07-03T21:04:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab2fa8caf79ec458ffc8db62ab6f996f7830f681","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geoserver/geoserver/pulls/631/commits","review_comments_url":"https://api.github.com/repos/geoserver/geoserver/pulls/631/comments","review_comment_url":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/{number}","comments_url":"https://api.github.com/repos/geoserver/geoserver/issues/631/comments","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/b67373b70ec7c38181047af0dcc6def105599d76","head":{"label":"ischneider:jdbcconfig-oracle","ref":"jdbcconfig-oracle","sha":"b67373b70ec7c38181047af0dcc6def105599d76","user":{"login":"ischneider","id":794512,"avatar_url":"https://avatars.githubusercontent.com/u/794512?","gravatar_id":"15a62eff50def0e0dfeba59d7a9ea01c","url":"https://api.github.com/users/ischneider","html_url":"https://github.com/ischneider","followers_url":"https://api.github.com/users/ischneider/followers","following_url":"https://api.github.com/users/ischneider/following{/other_user}","gists_url":"https://api.github.com/users/ischneider/gists{/gist_id}","starred_url":"https://api.github.com/users/ischneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ischneider/subscriptions","organizations_url":"https://api.github.com/users/ischneider/orgs","repos_url":"https://api.github.com/users/ischneider/repos","events_url":"https://api.github.com/users/ischneider/events{/privacy}","received_events_url":"https://api.github.com/users/ischneider/received_events","type":"User","site_admin":false},"repo":{"id":4926825,"name":"geoserver","full_name":"ischneider/geoserver","owner":{"login":"ischneider","id":794512,"avatar_url":"https://avatars.githubusercontent.com/u/794512?","gravatar_id":"15a62eff50def0e0dfeba59d7a9ea01c","url":"https://api.github.com/users/ischneider","html_url":"https://github.com/ischneider","followers_url":"https://api.github.com/users/ischneider/followers","following_url":"https://api.github.com/users/ischneider/following{/other_user}","gists_url":"https://api.github.com/users/ischneider/gists{/gist_id}","starred_url":"https://api.github.com/users/ischneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ischneider/subscriptions","organizations_url":"https://api.github.com/users/ischneider/orgs","repos_url":"https://api.github.com/users/ischneider/repos","events_url":"https://api.github.com/users/ischneider/events{/privacy}","received_events_url":"https://api.github.com/users/ischneider/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ischneider/geoserver","description":"Mirror of central GeoServer subversion repository","fork":true,"url":"https://api.github.com/repos/ischneider/geoserver","forks_url":"https://api.github.com/repos/ischneider/geoserver/forks","keys_url":"https://api.github.com/repos/ischneider/geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ischneider/geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ischneider/geoserver/teams","hooks_url":"https://api.github.com/repos/ischneider/geoserver/hooks","issue_events_url":"https://api.github.com/repos/ischneider/geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/ischneider/geoserver/events","assignees_url":"https://api.github.com/repos/ischneider/geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/ischneider/geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/ischneider/geoserver/tags","blobs_url":"https://api.github.com/repos/ischneider/geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ischneider/geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ischneider/geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ischneider/geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ischneider/geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/ischneider/geoserver/languages","stargazers_url":"https://api.github.com/repos/ischneider/geoserver/stargazers","contributors_url":"https://api.github.com/repos/ischneider/geoserver/contributors","subscribers_url":"https://api.github.com/repos/ischneider/geoserver/subscribers","subscription_url":"https://api.github.com/repos/ischneider/geoserver/subscription","commits_url":"https://api.github.com/repos/ischneider/geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ischneider/geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ischneider/geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ischneider/geoserver/issues/comments/{number}","contents_url":"https://api.github.com/repos/ischneider/geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/ischneider/geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ischneider/geoserver/merges","archive_url":"https://api.github.com/repos/ischneider/geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ischneider/geoserver/downloads","issues_url":"https://api.github.com/repos/ischneider/geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/ischneider/geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/ischneider/geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/ischneider/geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ischneider/geoserver/labels{/name}","releases_url":"https://api.github.com/repos/ischneider/geoserver/releases{/id}","created_at":"2012-07-06T15:21:15Z","updated_at":"2014-06-19T21:51:15Z","pushed_at":"2014-07-03T20:01:38Z","git_url":"git://github.com/ischneider/geoserver.git","ssh_url":"git@github.com:ischneider/geoserver.git","clone_url":"https://github.com/ischneider/geoserver.git","svn_url":"https://github.com/ischneider/geoserver","homepage":"http://geoserver.org","size":95209,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"geoserver:master","ref":"master","sha":"b6b0f65049be5ee3b1f3b3387a2dcdf4bab41155","user":{"login":"geoserver","id":186522,"avatar_url":"https://avatars.githubusercontent.com/u/186522?","gravatar_id":"8f84e2675045cd3981614201ac275f8d","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"repo":{"id":2751199,"name":"geoserver","full_name":"geoserver/geoserver","owner":{"login":"geoserver","id":186522,"avatar_url":"https://avatars.githubusercontent.com/u/186522?","gravatar_id":"8f84e2675045cd3981614201ac275f8d","url":"https://api.github.com/users/geoserver","html_url":"https://github.com/geoserver","followers_url":"https://api.github.com/users/geoserver/followers","following_url":"https://api.github.com/users/geoserver/following{/other_user}","gists_url":"https://api.github.com/users/geoserver/gists{/gist_id}","starred_url":"https://api.github.com/users/geoserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoserver/subscriptions","organizations_url":"https://api.github.com/users/geoserver/orgs","repos_url":"https://api.github.com/users/geoserver/repos","events_url":"https://api.github.com/users/geoserver/events{/privacy}","received_events_url":"https://api.github.com/users/geoserver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoserver/geoserver","description":"Official GeoServer repository","fork":false,"url":"https://api.github.com/repos/geoserver/geoserver","forks_url":"https://api.github.com/repos/geoserver/geoserver/forks","keys_url":"https://api.github.com/repos/geoserver/geoserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoserver/geoserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoserver/geoserver/teams","hooks_url":"https://api.github.com/repos/geoserver/geoserver/hooks","issue_events_url":"https://api.github.com/repos/geoserver/geoserver/issues/events{/number}","events_url":"https://api.github.com/repos/geoserver/geoserver/events","assignees_url":"https://api.github.com/repos/geoserver/geoserver/assignees{/user}","branches_url":"https://api.github.com/repos/geoserver/geoserver/branches{/branch}","tags_url":"https://api.github.com/repos/geoserver/geoserver/tags","blobs_url":"https://api.github.com/repos/geoserver/geoserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoserver/geoserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoserver/geoserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoserver/geoserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoserver/geoserver/statuses/{sha}","languages_url":"https://api.github.com/repos/geoserver/geoserver/languages","stargazers_url":"https://api.github.com/repos/geoserver/geoserver/stargazers","contributors_url":"https://api.github.com/repos/geoserver/geoserver/contributors","subscribers_url":"https://api.github.com/repos/geoserver/geoserver/subscribers","subscription_url":"https://api.github.com/repos/geoserver/geoserver/subscription","commits_url":"https://api.github.com/repos/geoserver/geoserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoserver/geoserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoserver/geoserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoserver/geoserver/issues/comments/{number}","contents_url":"https://api.github.com/repos/geoserver/geoserver/contents/{+path}","compare_url":"https://api.github.com/repos/geoserver/geoserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoserver/geoserver/merges","archive_url":"https://api.github.com/repos/geoserver/geoserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoserver/geoserver/downloads","issues_url":"https://api.github.com/repos/geoserver/geoserver/issues{/number}","pulls_url":"https://api.github.com/repos/geoserver/geoserver/pulls{/number}","milestones_url":"https://api.github.com/repos/geoserver/geoserver/milestones{/number}","notifications_url":"https://api.github.com/repos/geoserver/geoserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoserver/geoserver/labels{/name}","releases_url":"https://api.github.com/repos/geoserver/geoserver/releases{/id}","created_at":"2011-11-10T19:56:06Z","updated_at":"2014-07-02T12:47:21Z","pushed_at":"2014-07-03T08:58:50Z","git_url":"git://github.com/geoserver/geoserver.git","ssh_url":"git@github.com:geoserver/geoserver.git","clone_url":"https://github.com/geoserver/geoserver.git","svn_url":"https://github.com/geoserver/geoserver","homepage":"http://geoserver.org","size":170572,"stargazers_count":253,"watchers_count":253,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":309,"mirror_url":null,"open_issues_count":31,"forks":309,"open_issues":31,"watchers":253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/631"},"html":{"href":"https://github.com/geoserver/geoserver/pull/631"},"issue":{"href":"https://api.github.com/repos/geoserver/geoserver/issues/631"},"comments":{"href":"https://api.github.com/repos/geoserver/geoserver/issues/631/comments"},"review_comments":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/631/comments"},"review_comment":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/geoserver/geoserver/pulls/631/commits"},"statuses":{"href":"https://api.github.com/repos/geoserver/geoserver/statuses/b67373b70ec7c38181047af0dcc6def105599d76"}}}}