GitHub PullRequestReviewCommentEvent at 2014-07-12 12:29:09
Repository: portal
Actor: ana-balica
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/systers/portal/pulls/comments/14853056","id":14853056,"diff_hunk":"@@ -0,0 +1,18 @@\n+{% extends \"dashboard/base.html\" %}\n+{% block title %}Edit Profile{% endblock %}\n+{% block content %}\n+<div>\n+  <h3>Edit Profile</h3>\n+  <br>\n+  <div class=\"container\">\n+    {% if user.is_authenticated %}","path":"systers_portal/templates/dashboard/edit_profile.html","position":8,"original_position":8,"commit_id":"a00de48034a211c9cffcdc88f932f20640dc08a7","original_commit_id":"a00de48034a211c9cffcdc88f932f20640dc08a7","user":{"login":"ana-balica","id":2039122,"avatar_url":"https://avatars.githubusercontent.com/u/2039122?","gravatar_id":"2a3082799c3df9a58d06bc1b81107752","url":"https://api.github.com/users/ana-balica","html_url":"https://github.com/ana-balica","followers_url":"https://api.github.com/users/ana-balica/followers","following_url":"https://api.github.com/users/ana-balica/following{/other_user}","gists_url":"https://api.github.com/users/ana-balica/gists{/gist_id}","starred_url":"https://api.github.com/users/ana-balica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ana-balica/subscriptions","organizations_url":"https://api.github.com/users/ana-balica/orgs","repos_url":"https://api.github.com/users/ana-balica/repos","events_url":"https://api.github.com/users/ana-balica/events{/privacy}","received_events_url":"https://api.github.com/users/ana-balica/received_events","type":"User","site_admin":false},"body":"I am not sure if it's necessary to duplicate the authentication check (you have `login_required` in your views), since you don't have an `{% else %}` to show something different than user profile. ","created_at":"2014-07-12T12:29:09Z","updated_at":"2014-07-12T12:29:09Z","html_url":"https://github.com/systers/portal/pull/28#discussion_r14853056","pull_request_url":"https://api.github.com/repos/systers/portal/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/systers/portal/pulls/comments/14853056"},"html":{"href":"https://github.com/systers/portal/pull/28#discussion_r14853056"},"pull_request":{"href":"https://api.github.com/repos/systers/portal/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/systers/portal/pulls/28","id":18158211,"html_url":"https://github.com/systers/portal/pull/28","diff_url":"https://github.com/systers/portal/pull/28.diff","patch_url":"https://github.com/systers/portal/pull/28.patch","issue_url":"https://api.github.com/repos/systers/portal/issues/28","number":28,"state":"open","title":"EDIT profile and template","user":{"login":"dweep123","id":3685786,"avatar_url":"https://avatars.githubusercontent.com/u/3685786?","gravatar_id":"51f636929ce14260e4c16ddd8f84052b","url":"https://api.github.com/users/dweep123","html_url":"https://github.com/dweep123","followers_url":"https://api.github.com/users/dweep123/followers","following_url":"https://api.github.com/users/dweep123/following{/other_user}","gists_url":"https://api.github.com/users/dweep123/gists{/gist_id}","starred_url":"https://api.github.com/users/dweep123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dweep123/subscriptions","organizations_url":"https://api.github.com/users/dweep123/orgs","repos_url":"https://api.github.com/users/dweep123/repos","events_url":"https://api.github.com/users/dweep123/events{/privacy}","received_events_url":"https://api.github.com/users/dweep123/received_events","type":"User","site_admin":false},"body":"This PR depends on View Profile and template PR, because of which tests are failing ,once that is merged it will be rebased.","created_at":"2014-07-09T12:52:13Z","updated_at":"2014-07-12T12:29:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92c6b7f6f0011759881c0c047750048b65f0fb54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/systers/portal/pulls/28/commits","review_comments_url":"https://api.github.com/repos/systers/portal/pulls/28/comments","review_comment_url":"https://api.github.com/repos/systers/portal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/systers/portal/issues/28/comments","statuses_url":"https://api.github.com/repos/systers/portal/statuses/a00de48034a211c9cffcdc88f932f20640dc08a7","head":{"label":"dweep123:edit_profile_and_template","ref":"edit_profile_and_template","sha":"a00de48034a211c9cffcdc88f932f20640dc08a7","user":{"login":"dweep123","id":3685786,"avatar_url":"https://avatars.githubusercontent.com/u/3685786?","gravatar_id":"51f636929ce14260e4c16ddd8f84052b","url":"https://api.github.com/users/dweep123","html_url":"https://github.com/dweep123","followers_url":"https://api.github.com/users/dweep123/followers","following_url":"https://api.github.com/users/dweep123/following{/other_user}","gists_url":"https://api.github.com/users/dweep123/gists{/gist_id}","starred_url":"https://api.github.com/users/dweep123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dweep123/subscriptions","organizations_url":"https://api.github.com/users/dweep123/orgs","repos_url":"https://api.github.com/users/dweep123/repos","events_url":"https://api.github.com/users/dweep123/events{/privacy}","received_events_url":"https://api.github.com/users/dweep123/received_events","type":"User","site_admin":false},"repo":{"id":20594913,"name":"portal","full_name":"dweep123/portal","owner":{"login":"dweep123","id":3685786,"avatar_url":"https://avatars.githubusercontent.com/u/3685786?","gravatar_id":"51f636929ce14260e4c16ddd8f84052b","url":"https://api.github.com/users/dweep123","html_url":"https://github.com/dweep123","followers_url":"https://api.github.com/users/dweep123/followers","following_url":"https://api.github.com/users/dweep123/following{/other_user}","gists_url":"https://api.github.com/users/dweep123/gists{/gist_id}","starred_url":"https://api.github.com/users/dweep123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dweep123/subscriptions","organizations_url":"https://api.github.com/users/dweep123/orgs","repos_url":"https://api.github.com/users/dweep123/repos","events_url":"https://api.github.com/users/dweep123/events{/privacy}","received_events_url":"https://api.github.com/users/dweep123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dweep123/portal","description":"Systers Portal for communities","fork":true,"url":"https://api.github.com/repos/dweep123/portal","forks_url":"https://api.github.com/repos/dweep123/portal/forks","keys_url":"https://api.github.com/repos/dweep123/portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dweep123/portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dweep123/portal/teams","hooks_url":"https://api.github.com/repos/dweep123/portal/hooks","issue_events_url":"https://api.github.com/repos/dweep123/portal/issues/events{/number}","events_url":"https://api.github.com/repos/dweep123/portal/events","assignees_url":"https://api.github.com/repos/dweep123/portal/assignees{/user}","branches_url":"https://api.github.com/repos/dweep123/portal/branches{/branch}","tags_url":"https://api.github.com/repos/dweep123/portal/tags","blobs_url":"https://api.github.com/repos/dweep123/portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dweep123/portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dweep123/portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/dweep123/portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dweep123/portal/statuses/{sha}","languages_url":"https://api.github.com/repos/dweep123/portal/languages","stargazers_url":"https://api.github.com/repos/dweep123/portal/stargazers","contributors_url":"https://api.github.com/repos/dweep123/portal/contributors","subscribers_url":"https://api.github.com/repos/dweep123/portal/subscribers","subscription_url":"https://api.github.com/repos/dweep123/portal/subscription","commits_url":"https://api.github.com/repos/dweep123/portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/dweep123/portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/dweep123/portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/dweep123/portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/dweep123/portal/contents/{+path}","compare_url":"https://api.github.com/repos/dweep123/portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dweep123/portal/merges","archive_url":"https://api.github.com/repos/dweep123/portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dweep123/portal/downloads","issues_url":"https://api.github.com/repos/dweep123/portal/issues{/number}","pulls_url":"https://api.github.com/repos/dweep123/portal/pulls{/number}","milestones_url":"https://api.github.com/repos/dweep123/portal/milestones{/number}","notifications_url":"https://api.github.com/repos/dweep123/portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dweep123/portal/labels{/name}","releases_url":"https://api.github.com/repos/dweep123/portal/releases{/id}","created_at":"2014-06-07T14:30:21Z","updated_at":"2014-07-10T12:17:56Z","pushed_at":"2014-07-12T09:27:08Z","git_url":"git://github.com/dweep123/portal.git","ssh_url":"git@github.com:dweep123/portal.git","clone_url":"https://github.com/dweep123/portal.git","svn_url":"https://github.com/dweep123/portal","homepage":null,"size":16341,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systers:master","ref":"master","sha":"ef837995a128abdcac45d1b5395bd05a16c8e4d8","user":{"login":"systers","id":6520415,"avatar_url":"https://avatars.githubusercontent.com/u/6520415?","gravatar_id":"aab53de132a5fa6fc20896e21cbab23b","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"repo":{"id":19014376,"name":"portal","full_name":"systers/portal","owner":{"login":"systers","id":6520415,"avatar_url":"https://avatars.githubusercontent.com/u/6520415?","gravatar_id":"aab53de132a5fa6fc20896e21cbab23b","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systers/portal","description":"Systers Portal for communities","fork":false,"url":"https://api.github.com/repos/systers/portal","forks_url":"https://api.github.com/repos/systers/portal/forks","keys_url":"https://api.github.com/repos/systers/portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systers/portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systers/portal/teams","hooks_url":"https://api.github.com/repos/systers/portal/hooks","issue_events_url":"https://api.github.com/repos/systers/portal/issues/events{/number}","events_url":"https://api.github.com/repos/systers/portal/events","assignees_url":"https://api.github.com/repos/systers/portal/assignees{/user}","branches_url":"https://api.github.com/repos/systers/portal/branches{/branch}","tags_url":"https://api.github.com/repos/systers/portal/tags","blobs_url":"https://api.github.com/repos/systers/portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systers/portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systers/portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/systers/portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systers/portal/statuses/{sha}","languages_url":"https://api.github.com/repos/systers/portal/languages","stargazers_url":"https://api.github.com/repos/systers/portal/stargazers","contributors_url":"https://api.github.com/repos/systers/portal/contributors","subscribers_url":"https://api.github.com/repos/systers/portal/subscribers","subscription_url":"https://api.github.com/repos/systers/portal/subscription","commits_url":"https://api.github.com/repos/systers/portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/systers/portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/systers/portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/systers/portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/systers/portal/contents/{+path}","compare_url":"https://api.github.com/repos/systers/portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systers/portal/merges","archive_url":"https://api.github.com/repos/systers/portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systers/portal/downloads","issues_url":"https://api.github.com/repos/systers/portal/issues{/number}","pulls_url":"https://api.github.com/repos/systers/portal/pulls{/number}","milestones_url":"https://api.github.com/repos/systers/portal/milestones{/number}","notifications_url":"https://api.github.com/repos/systers/portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systers/portal/labels{/name}","releases_url":"https://api.github.com/repos/systers/portal/releases{/id}","created_at":"2014-04-22T02:29:14Z","updated_at":"2014-06-27T22:46:01Z","pushed_at":"2014-07-11T20:14:33Z","git_url":"git://github.com/systers/portal.git","ssh_url":"git@github.com:systers/portal.git","clone_url":"https://github.com/systers/portal.git","svn_url":"https://github.com/systers/portal","homepage":null,"size":12725,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systers/portal/pulls/28"},"html":{"href":"https://github.com/systers/portal/pull/28"},"issue":{"href":"https://api.github.com/repos/systers/portal/issues/28"},"comments":{"href":"https://api.github.com/repos/systers/portal/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/systers/portal/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/systers/portal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/systers/portal/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/systers/portal/statuses/a00de48034a211c9cffcdc88f932f20640dc08a7"}}}}