GitHub PullRequestEvent at 2014-08-28 18:54:40
Repository: bash-git-prompt
Actor: aks
Payload: {"action":"opened","number":71,"pull_request":{"url":"https://api.github.com/repos/magicmonty/bash-git-prompt/pulls/71","id":20459077,"html_url":"https://github.com/magicmonty/bash-git-prompt/pull/71","diff_url":"https://github.com/magicmonty/bash-git-prompt/pull/71.diff","patch_url":"https://github.com/magicmonty/bash-git-prompt/pull/71.patch","issue_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/issues/71","number":71,"state":"open","locked":false,"title":"Optimizations & aesthetics","user":{"login":"aks","id":3990,"avatar_url":"https://avatars.githubusercontent.com/u/3990?v=2","gravatar_id":"54d7d9bb8a09f76aa534b0ef3f00ca56","url":"https://api.github.com/users/aks","html_url":"https://github.com/aks","followers_url":"https://api.github.com/users/aks/followers","following_url":"https://api.github.com/users/aks/following{/other_user}","gists_url":"https://api.github.com/users/aks/gists{/gist_id}","starred_url":"https://api.github.com/users/aks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aks/subscriptions","organizations_url":"https://api.github.com/users/aks/orgs","repos_url":"https://api.github.com/users/aks/repos","events_url":"https://api.github.com/users/aks/events{/privacy}","received_events_url":"https://api.github.com/users/aks/received_events","type":"User","site_admin":false},"body":"Don't look for the same file each prompt update; use the envar.\r\nDon't redefine the same prompt color names each prompt update; the variables are global.\r\nDon't redefine the same git prompt color mappings on each prompt update; the variables are global.\r\n\r\nTurns out that the `declare -g`'s were not needed.\r\n\r\nSome small aesthetic changes: \r\n\r\n- use `\"$foo\"` not `\"${foo}\"`.  Curly braces are only needed when the surrounding token is a alphanumeric, or, an array reference.  Sometimes, they add readability.\r\n- numbers don't need to be quoted: `[[ \"$value\" = 1 ]]` is better than `[[ \"x$val\" == \"x1\" ]]`.  The latter triggers a _regexp_ match which is unnecessary, and expensive.","created_at":"2014-08-28T18:54:40Z","updated_at":"2014-08-28T18:54:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/pulls/71/commits","review_comments_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/pulls/71/comments","review_comment_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/pulls/comments/{number}","comments_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/issues/71/comments","statuses_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/statuses/a3994cd962d89b90d48cc6acef94de22a857ab07","head":{"label":"aks:master","ref":"master","sha":"a3994cd962d89b90d48cc6acef94de22a857ab07","user":{"login":"aks","id":3990,"avatar_url":"https://avatars.githubusercontent.com/u/3990?v=2","gravatar_id":"54d7d9bb8a09f76aa534b0ef3f00ca56","url":"https://api.github.com/users/aks","html_url":"https://github.com/aks","followers_url":"https://api.github.com/users/aks/followers","following_url":"https://api.github.com/users/aks/following{/other_user}","gists_url":"https://api.github.com/users/aks/gists{/gist_id}","starred_url":"https://api.github.com/users/aks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aks/subscriptions","organizations_url":"https://api.github.com/users/aks/orgs","repos_url":"https://api.github.com/users/aks/repos","events_url":"https://api.github.com/users/aks/events{/privacy}","received_events_url":"https://api.github.com/users/aks/received_events","type":"User","site_admin":false},"repo":{"id":16088620,"name":"bash-git-prompt","full_name":"aks/bash-git-prompt","owner":{"login":"aks","id":3990,"avatar_url":"https://avatars.githubusercontent.com/u/3990?v=2","gravatar_id":"54d7d9bb8a09f76aa534b0ef3f00ca56","url":"https://api.github.com/users/aks","html_url":"https://github.com/aks","followers_url":"https://api.github.com/users/aks/followers","following_url":"https://api.github.com/users/aks/following{/other_user}","gists_url":"https://api.github.com/users/aks/gists{/gist_id}","starred_url":"https://api.github.com/users/aks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aks/subscriptions","organizations_url":"https://api.github.com/users/aks/orgs","repos_url":"https://api.github.com/users/aks/repos","events_url":"https://api.github.com/users/aks/events{/privacy}","received_events_url":"https://api.github.com/users/aks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aks/bash-git-prompt","description":"An informative and fancy bash prompt for Git users","fork":true,"url":"https://api.github.com/repos/aks/bash-git-prompt","forks_url":"https://api.github.com/repos/aks/bash-git-prompt/forks","keys_url":"https://api.github.com/repos/aks/bash-git-prompt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aks/bash-git-prompt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aks/bash-git-prompt/teams","hooks_url":"https://api.github.com/repos/aks/bash-git-prompt/hooks","issue_events_url":"https://api.github.com/repos/aks/bash-git-prompt/issues/events{/number}","events_url":"https://api.github.com/repos/aks/bash-git-prompt/events","assignees_url":"https://api.github.com/repos/aks/bash-git-prompt/assignees{/user}","branches_url":"https://api.github.com/repos/aks/bash-git-prompt/branches{/branch}","tags_url":"https://api.github.com/repos/aks/bash-git-prompt/tags","blobs_url":"https://api.github.com/repos/aks/bash-git-prompt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aks/bash-git-prompt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aks/bash-git-prompt/git/refs{/sha}","trees_url":"https://api.github.com/repos/aks/bash-git-prompt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aks/bash-git-prompt/statuses/{sha}","languages_url":"https://api.github.com/repos/aks/bash-git-prompt/languages","stargazers_url":"https://api.github.com/repos/aks/bash-git-prompt/stargazers","contributors_url":"https://api.github.com/repos/aks/bash-git-prompt/contributors","subscribers_url":"https://api.github.com/repos/aks/bash-git-prompt/subscribers","subscription_url":"https://api.github.com/repos/aks/bash-git-prompt/subscription","commits_url":"https://api.github.com/repos/aks/bash-git-prompt/commits{/sha}","git_commits_url":"https://api.github.com/repos/aks/bash-git-prompt/git/commits{/sha}","comments_url":"https://api.github.com/repos/aks/bash-git-prompt/comments{/number}","issue_comment_url":"https://api.github.com/repos/aks/bash-git-prompt/issues/comments/{number}","contents_url":"https://api.github.com/repos/aks/bash-git-prompt/contents/{+path}","compare_url":"https://api.github.com/repos/aks/bash-git-prompt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aks/bash-git-prompt/merges","archive_url":"https://api.github.com/repos/aks/bash-git-prompt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aks/bash-git-prompt/downloads","issues_url":"https://api.github.com/repos/aks/bash-git-prompt/issues{/number}","pulls_url":"https://api.github.com/repos/aks/bash-git-prompt/pulls{/number}","milestones_url":"https://api.github.com/repos/aks/bash-git-prompt/milestones{/number}","notifications_url":"https://api.github.com/repos/aks/bash-git-prompt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aks/bash-git-prompt/labels{/name}","releases_url":"https://api.github.com/repos/aks/bash-git-prompt/releases{/id}","created_at":"2014-01-21T01:06:25Z","updated_at":"2014-08-28T07:29:55Z","pushed_at":"2014-08-28T18:51:05Z","git_url":"git://github.com/aks/bash-git-prompt.git","ssh_url":"git@github.com:aks/bash-git-prompt.git","clone_url":"https://github.com/aks/bash-git-prompt.git","svn_url":"https://github.com/aks/bash-git-prompt","homepage":null,"size":361,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"magicmonty:master","ref":"master","sha":"926c441b263a508d2ae200c8bfb9905e2c446cc5","user":{"login":"magicmonty","id":315639,"avatar_url":"https://avatars.githubusercontent.com/u/315639?v=2","gravatar_id":"c4999a2764a173a6b08b665d56f249e1","url":"https://api.github.com/users/magicmonty","html_url":"https://github.com/magicmonty","followers_url":"https://api.github.com/users/magicmonty/followers","following_url":"https://api.github.com/users/magicmonty/following{/other_user}","gists_url":"https://api.github.com/users/magicmonty/gists{/gist_id}","starred_url":"https://api.github.com/users/magicmonty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicmonty/subscriptions","organizations_url":"https://api.github.com/users/magicmonty/orgs","repos_url":"https://api.github.com/users/magicmonty/repos","events_url":"https://api.github.com/users/magicmonty/events{/privacy}","received_events_url":"https://api.github.com/users/magicmonty/received_events","type":"User","site_admin":false},"repo":{"id":7006572,"name":"bash-git-prompt","full_name":"magicmonty/bash-git-prompt","owner":{"login":"magicmonty","id":315639,"avatar_url":"https://avatars.githubusercontent.com/u/315639?v=2","gravatar_id":"c4999a2764a173a6b08b665d56f249e1","url":"https://api.github.com/users/magicmonty","html_url":"https://github.com/magicmonty","followers_url":"https://api.github.com/users/magicmonty/followers","following_url":"https://api.github.com/users/magicmonty/following{/other_user}","gists_url":"https://api.github.com/users/magicmonty/gists{/gist_id}","starred_url":"https://api.github.com/users/magicmonty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicmonty/subscriptions","organizations_url":"https://api.github.com/users/magicmonty/orgs","repos_url":"https://api.github.com/users/magicmonty/repos","events_url":"https://api.github.com/users/magicmonty/events{/privacy}","received_events_url":"https://api.github.com/users/magicmonty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magicmonty/bash-git-prompt","description":"An informative and fancy bash prompt for Git users","fork":false,"url":"https://api.github.com/repos/magicmonty/bash-git-prompt","forks_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/forks","keys_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/teams","hooks_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/hooks","issue_events_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/issues/events{/number}","events_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/events","assignees_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/assignees{/user}","branches_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/branches{/branch}","tags_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/tags","blobs_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/git/refs{/sha}","trees_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/statuses/{sha}","languages_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/languages","stargazers_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/stargazers","contributors_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/contributors","subscribers_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/subscribers","subscription_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/subscription","commits_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/commits{/sha}","git_commits_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/git/commits{/sha}","comments_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/comments{/number}","issue_comment_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/issues/comments/{number}","contents_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/contents/{+path}","compare_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/merges","archive_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/downloads","issues_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/issues{/number}","pulls_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/pulls{/number}","milestones_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/milestones{/number}","notifications_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/labels{/name}","releases_url":"https://api.github.com/repos/magicmonty/bash-git-prompt/releases{/id}","created_at":"2012-12-04T20:44:35Z","updated_at":"2014-08-28T14:27:30Z","pushed_at":"2014-08-28T12:59:11Z","git_url":"git://github.com/magicmonty/bash-git-prompt.git","ssh_url":"git@github.com:magicmonty/bash-git-prompt.git","clone_url":"https://github.com/magicmonty/bash-git-prompt.git","svn_url":"https://github.com/magicmonty/bash-git-prompt","homepage":null,"size":1019,"stargazers_count":438,"watchers_count":438,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":198,"mirror_url":null,"open_issues_count":6,"forks":198,"open_issues":6,"watchers":438,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magicmonty/bash-git-prompt/pulls/71"},"html":{"href":"https://github.com/magicmonty/bash-git-prompt/pull/71"},"issue":{"href":"https://api.github.com/repos/magicmonty/bash-git-prompt/issues/71"},"comments":{"href":"https://api.github.com/repos/magicmonty/bash-git-prompt/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/magicmonty/bash-git-prompt/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/magicmonty/bash-git-prompt/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/magicmonty/bash-git-prompt/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/magicmonty/bash-git-prompt/statuses/a3994cd962d89b90d48cc6acef94de22a857ab07"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":100,"deletions":98,"changed_files":3}}