GitHub PullRequestReviewCommentEvent at 2014-03-19 18:16:17
Repository: shogun
Actor: dhruv13J
Payload: {"comment":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/10763240","id":10763240,"diff_hunk":"@@ -54,14 +58,16 @@ void CKNN::init()\n \n \tm_k=3;\n \tm_q=1.0;\n-\tm_use_covertree=false;\n \tm_num_classes=0;\n-\n+\tm_mode=BruteForce;\n+\t// Default value for KDTree leaf size, taken from nanoflann benchmark.\n+\tm_leaf_size = 20;\n+\t\n \t/* use the method classify_multiply_k to experiment with different values\n \t * of k */\n \tSG_ADD(&m_k, \"m_k\", \"Parameter k\", MS_NOT_AVAILABLE);\n \tSG_ADD(&m_q, \"m_q\", \"Parameter q\", MS_AVAILABLE);\n-\tSG_ADD(&m_use_covertree, \"m_use_covertree\", \"Parameter use_covertree\", MS_NOT_AVAILABLE);","path":"src/shogun/multiclass/KNN.cpp","position":50,"original_position":50,"commit_id":"89e9fcda155ddf750e8525aa767dd236874003cb","original_commit_id":"89e9fcda155ddf750e8525aa767dd236874003cb","user":{"login":"dhruv13J","id":4868174,"avatar_url":"https://avatars.githubusercontent.com/u/4868174?","gravatar_id":"b1c4f2df5659e1f34e86fa9e29586fd0","url":"https://api.github.com/users/dhruv13J","html_url":"https://github.com/dhruv13J","followers_url":"https://api.github.com/users/dhruv13J/followers","following_url":"https://api.github.com/users/dhruv13J/following{/other_user}","gists_url":"https://api.github.com/users/dhruv13J/gists{/gist_id}","starred_url":"https://api.github.com/users/dhruv13J/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhruv13J/subscriptions","organizations_url":"https://api.github.com/users/dhruv13J/orgs","repos_url":"https://api.github.com/users/dhruv13J/repos","events_url":"https://api.github.com/users/dhruv13J/events{/privacy}","received_events_url":"https://api.github.com/users/dhruv13J/received_events","type":"User","site_admin":false},"body":"This is the culprit for the failing python integration tests!! ;-)","created_at":"2014-03-19T18:16:17Z","updated_at":"2014-03-19T18:16:17Z","html_url":"https://github.com/shogun-toolbox/shogun/pull/2015#discussion_r10763240","pull_request_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2015","_links":{"self":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/10763240"},"html":{"href":"https://github.com/shogun-toolbox/shogun/pull/2015#discussion_r10763240"},"pull_request":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2015"}}}}