GitHub PullRequestReviewCommentEvent at 2014-12-01 00:50:36
Repository: aodn-portal
Actor: jkburges
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments/21065703","id":21065703,"diff_hunk":"@@ -25,6 +25,9 @@ Portal.data.GeoNetworkRecordFetcher = Ext.extend(Ext.util.Observable, {\n \n         Ext.ux.Ajax.proxyRequest({\n             url: Portal.app.appConfig.geonetwork.url + '/srv/eng/xml.search.summary?' + Ext.urlEncode(params),\n+            headers: {\n+                'Content-Type': 'application/xml'","path":"web-app/js/portal/data/GeoNetworkRecordFetcher.js","position":5,"original_position":5,"commit_id":"bf229a3a17a82812d14c16ae7226b5ae835c9c03","original_commit_id":"bf229a3a17a82812d14c16ae7226b5ae835c9c03","user":{"login":"jkburges","id":1849176,"avatar_url":"https://avatars.githubusercontent.com/u/1849176?v=3","gravatar_id":"","url":"https://api.github.com/users/jkburges","html_url":"https://github.com/jkburges","followers_url":"https://api.github.com/users/jkburges/followers","following_url":"https://api.github.com/users/jkburges/following{/other_user}","gists_url":"https://api.github.com/users/jkburges/gists{/gist_id}","starred_url":"https://api.github.com/users/jkburges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkburges/subscriptions","organizations_url":"https://api.github.com/users/jkburges/orgs","repos_url":"https://api.github.com/users/jkburges/repos","events_url":"https://api.github.com/users/jkburges/events{/privacy}","received_events_url":"https://api.github.com/users/jkburges/received_events","type":"User","site_admin":false},"body":"There seem to be only XML and JSON content types expected by the portal front-end.\r\n\r\nHow about introducing `Ext.ux.Ajax.proxyRequestWithXmlResponse()` and `Ext.ux.Ajax.proxyRequestWithJsonResponse()` which set the header appropriately, and leave no doubt in the programmer's mind what's happening?  And they don't have to \"worry\" about setting headers themselves.","created_at":"2014-12-01T00:50:36Z","updated_at":"2014-12-01T00:50:36Z","html_url":"https://github.com/aodn/aodn-portal/pull/1518#discussion_r21065703","pull_request_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1518","_links":{"self":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments/21065703"},"html":{"href":"https://github.com/aodn/aodn-portal/pull/1518#discussion_r21065703"},"pull_request":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1518"}}},"pull_request":{"url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1518","id":25242331,"html_url":"https://github.com/aodn/aodn-portal/pull/1518","diff_url":"https://github.com/aodn/aodn-portal/pull/1518.diff","patch_url":"https://github.com/aodn/aodn-portal/pull/1518.patch","issue_url":"https://api.github.com/repos/aodn/aodn-portal/issues/1518","number":1518,"state":"open","locked":false,"title":"set correct content type on xml requests","user":{"login":"danfruehauf","id":830676,"avatar_url":"https://avatars.githubusercontent.com/u/830676?v=3","gravatar_id":"","url":"https://api.github.com/users/danfruehauf","html_url":"https://github.com/danfruehauf","followers_url":"https://api.github.com/users/danfruehauf/followers","following_url":"https://api.github.com/users/danfruehauf/following{/other_user}","gists_url":"https://api.github.com/users/danfruehauf/gists{/gist_id}","starred_url":"https://api.github.com/users/danfruehauf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfruehauf/subscriptions","organizations_url":"https://api.github.com/users/danfruehauf/orgs","repos_url":"https://api.github.com/users/danfruehauf/repos","events_url":"https://api.github.com/users/danfruehauf/events{/privacy}","received_events_url":"https://api.github.com/users/danfruehauf/received_events","type":"User","site_admin":false},"body":"fixes #1514 and #1516","created_at":"2014-12-01T00:20:49Z","updated_at":"2014-12-01T00:50:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7a4a62c65ce113a73d3848971b8bd5b2c40d265","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1518/commits","review_comments_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1518/comments","review_comment_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/issues/1518/comments","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/bf229a3a17a82812d14c16ae7226b5ae835c9c03","head":{"label":"aodn:content_type_xml","ref":"content_type_xml","sha":"bf229a3a17a82812d14c16ae7226b5ae835c9c03","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":6806252,"name":"aodn-portal","full_name":"aodn/aodn-portal","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/aodn-portal","description":"AODN Open Geospatial Portal","fork":false,"url":"https://api.github.com/repos/aodn/aodn-portal","forks_url":"https://api.github.com/repos/aodn/aodn-portal/forks","keys_url":"https://api.github.com/repos/aodn/aodn-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/aodn-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/aodn-portal/teams","hooks_url":"https://api.github.com/repos/aodn/aodn-portal/hooks","issue_events_url":"https://api.github.com/repos/aodn/aodn-portal/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/aodn-portal/events","assignees_url":"https://api.github.com/repos/aodn/aodn-portal/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/aodn-portal/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/aodn-portal/tags","blobs_url":"https://api.github.com/repos/aodn/aodn-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/aodn-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/aodn-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/aodn-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/aodn-portal/languages","stargazers_url":"https://api.github.com/repos/aodn/aodn-portal/stargazers","contributors_url":"https://api.github.com/repos/aodn/aodn-portal/contributors","subscribers_url":"https://api.github.com/repos/aodn/aodn-portal/subscribers","subscription_url":"https://api.github.com/repos/aodn/aodn-portal/subscription","commits_url":"https://api.github.com/repos/aodn/aodn-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/aodn-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/aodn-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/aodn/aodn-portal/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/aodn-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/aodn-portal/merges","archive_url":"https://api.github.com/repos/aodn/aodn-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/aodn-portal/downloads","issues_url":"https://api.github.com/repos/aodn/aodn-portal/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/aodn-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/aodn-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/aodn-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/aodn-portal/labels{/name}","releases_url":"https://api.github.com/repos/aodn/aodn-portal/releases{/id}","created_at":"2012-11-22T01:42:50Z","updated_at":"2014-12-01T00:07:53Z","pushed_at":"2014-12-01T00:47:35Z","git_url":"git://github.com/aodn/aodn-portal.git","ssh_url":"git@github.com:aodn/aodn-portal.git","clone_url":"https://github.com/aodn/aodn-portal.git","svn_url":"https://github.com/aodn/aodn-portal","homepage":"","size":78691,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":98,"forks":8,"open_issues":98,"watchers":3,"default_branch":"master"}},"base":{"label":"aodn:master","ref":"master","sha":"f600c9be1c17d786f3eeeed41de45bf9af8be417","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":6806252,"name":"aodn-portal","full_name":"aodn/aodn-portal","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/aodn-portal","description":"AODN Open Geospatial Portal","fork":false,"url":"https://api.github.com/repos/aodn/aodn-portal","forks_url":"https://api.github.com/repos/aodn/aodn-portal/forks","keys_url":"https://api.github.com/repos/aodn/aodn-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/aodn-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/aodn-portal/teams","hooks_url":"https://api.github.com/repos/aodn/aodn-portal/hooks","issue_events_url":"https://api.github.com/repos/aodn/aodn-portal/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/aodn-portal/events","assignees_url":"https://api.github.com/repos/aodn/aodn-portal/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/aodn-portal/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/aodn-portal/tags","blobs_url":"https://api.github.com/repos/aodn/aodn-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/aodn-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/aodn-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/aodn-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/aodn-portal/languages","stargazers_url":"https://api.github.com/repos/aodn/aodn-portal/stargazers","contributors_url":"https://api.github.com/repos/aodn/aodn-portal/contributors","subscribers_url":"https://api.github.com/repos/aodn/aodn-portal/subscribers","subscription_url":"https://api.github.com/repos/aodn/aodn-portal/subscription","commits_url":"https://api.github.com/repos/aodn/aodn-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/aodn-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/aodn-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/aodn/aodn-portal/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/aodn-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/aodn-portal/merges","archive_url":"https://api.github.com/repos/aodn/aodn-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/aodn-portal/downloads","issues_url":"https://api.github.com/repos/aodn/aodn-portal/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/aodn-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/aodn-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/aodn-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/aodn-portal/labels{/name}","releases_url":"https://api.github.com/repos/aodn/aodn-portal/releases{/id}","created_at":"2012-11-22T01:42:50Z","updated_at":"2014-12-01T00:07:53Z","pushed_at":"2014-12-01T00:47:35Z","git_url":"git://github.com/aodn/aodn-portal.git","ssh_url":"git@github.com:aodn/aodn-portal.git","clone_url":"https://github.com/aodn/aodn-portal.git","svn_url":"https://github.com/aodn/aodn-portal","homepage":"","size":78691,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":98,"forks":8,"open_issues":98,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1518"},"html":{"href":"https://github.com/aodn/aodn-portal/pull/1518"},"issue":{"href":"https://api.github.com/repos/aodn/aodn-portal/issues/1518"},"comments":{"href":"https://api.github.com/repos/aodn/aodn-portal/issues/1518/comments"},"review_comments":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1518/comments"},"review_comment":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1518/commits"},"statuses":{"href":"https://api.github.com/repos/aodn/aodn-portal/statuses/bf229a3a17a82812d14c16ae7226b5ae835c9c03"}}}}