GitHub PullRequestEvent at 2014-11-14 21:17:18
Repository: karma-webdriver-launcher
Actor: mtscout6
Payload: {"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/pulls/14","id":15733565,"html_url":"https://github.com/karma-runner/karma-webdriver-launcher/pull/14","diff_url":"https://github.com/karma-runner/karma-webdriver-launcher/pull/14.diff","patch_url":"https://github.com/karma-runner/karma-webdriver-launcher/pull/14.patch","issue_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/issues/14","number":14,"state":"closed","locked":false,"title":"Fix karma hanging after execution","user":{"login":"tatablack","id":1095044,"avatar_url":"https://avatars.githubusercontent.com/u/1095044?v=3","gravatar_id":"","url":"https://api.github.com/users/tatablack","html_url":"https://github.com/tatablack","followers_url":"https://api.github.com/users/tatablack/followers","following_url":"https://api.github.com/users/tatablack/following{/other_user}","gists_url":"https://api.github.com/users/tatablack/gists{/gist_id}","starred_url":"https://api.github.com/users/tatablack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatablack/subscriptions","organizations_url":"https://api.github.com/users/tatablack/orgs","repos_url":"https://api.github.com/users/tatablack/repos","events_url":"https://api.github.com/users/tatablack/events{/privacy}","received_events_url":"https://api.github.com/users/tatablack/received_events","type":"User","site_admin":false},"body":"While trying to use this launcher to execute tests on browsers from a Selenium Grid, I noticed that I had intermittent errors from the grid (browser timeouts, or \"Failed to navigate\" errors). In those cases, Karma would hang just after this launcher printed `Killed Karma test`.\r\n\r\nThese commits change the WD.js invocation style, and solve the issue. Besides, I made sure that the (already existing) Launcher retry mechanism is actually triggered in case of timeouts.","created_at":"2014-05-10T13:46:55Z","updated_at":"2014-11-14T21:17:17Z","closed_at":"2014-11-14T21:17:17Z","merged_at":null,"merge_commit_sha":"0cdf30b9a62799482fbb29b8690789f71b33ed9e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/pulls/14/commits","review_comments_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/pulls/14/comments","review_comment_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/pulls/comments/{number}","comments_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/issues/14/comments","statuses_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/statuses/753b40798ca7a679ba2863131a363914f5fc87e5","head":{"label":"tatablack:fix-karma-hanging","ref":"fix-karma-hanging","sha":"753b40798ca7a679ba2863131a363914f5fc87e5","user":{"login":"tatablack","id":1095044,"avatar_url":"https://avatars.githubusercontent.com/u/1095044?v=3","gravatar_id":"","url":"https://api.github.com/users/tatablack","html_url":"https://github.com/tatablack","followers_url":"https://api.github.com/users/tatablack/followers","following_url":"https://api.github.com/users/tatablack/following{/other_user}","gists_url":"https://api.github.com/users/tatablack/gists{/gist_id}","starred_url":"https://api.github.com/users/tatablack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatablack/subscriptions","organizations_url":"https://api.github.com/users/tatablack/orgs","repos_url":"https://api.github.com/users/tatablack/repos","events_url":"https://api.github.com/users/tatablack/events{/privacy}","received_events_url":"https://api.github.com/users/tatablack/received_events","type":"User","site_admin":false},"repo":{"id":19628396,"name":"karma-webdriver-launcher","full_name":"tatablack/karma-webdriver-launcher","owner":{"login":"tatablack","id":1095044,"avatar_url":"https://avatars.githubusercontent.com/u/1095044?v=3","gravatar_id":"","url":"https://api.github.com/users/tatablack","html_url":"https://github.com/tatablack","followers_url":"https://api.github.com/users/tatablack/followers","following_url":"https://api.github.com/users/tatablack/following{/other_user}","gists_url":"https://api.github.com/users/tatablack/gists{/gist_id}","starred_url":"https://api.github.com/users/tatablack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatablack/subscriptions","organizations_url":"https://api.github.com/users/tatablack/orgs","repos_url":"https://api.github.com/users/tatablack/repos","events_url":"https://api.github.com/users/tatablack/events{/privacy}","received_events_url":"https://api.github.com/users/tatablack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tatablack/karma-webdriver-launcher","description":"A plugin for Karma. Launch any browser with WebDriver.","fork":true,"url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher","forks_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/forks","keys_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/teams","hooks_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/hooks","issue_events_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/issues/events{/number}","events_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/events","assignees_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/assignees{/user}","branches_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/branches{/branch}","tags_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/tags","blobs_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/statuses/{sha}","languages_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/languages","stargazers_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/stargazers","contributors_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/contributors","subscribers_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/subscribers","subscription_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/subscription","commits_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/issues/comments/{number}","contents_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/contents/{+path}","compare_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/merges","archive_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/downloads","issues_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/issues{/number}","pulls_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/pulls{/number}","milestones_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/milestones{/number}","notifications_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/labels{/name}","releases_url":"https://api.github.com/repos/tatablack/karma-webdriver-launcher/releases{/id}","created_at":"2014-05-09T23:10:50Z","updated_at":"2014-05-11T11:46:58Z","pushed_at":"2014-08-05T13:53:40Z","git_url":"git://github.com/tatablack/karma-webdriver-launcher.git","ssh_url":"git@github.com:tatablack/karma-webdriver-launcher.git","clone_url":"https://github.com/tatablack/karma-webdriver-launcher.git","svn_url":"https://github.com/tatablack/karma-webdriver-launcher","homepage":null,"size":164,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"karma-runner:master","ref":"master","sha":"80927653f2af93b688287f1400ddd27062eccf23","user":{"login":"karma-runner","id":3284117,"avatar_url":"https://avatars.githubusercontent.com/u/3284117?v=3","gravatar_id":"","url":"https://api.github.com/users/karma-runner","html_url":"https://github.com/karma-runner","followers_url":"https://api.github.com/users/karma-runner/followers","following_url":"https://api.github.com/users/karma-runner/following{/other_user}","gists_url":"https://api.github.com/users/karma-runner/gists{/gist_id}","starred_url":"https://api.github.com/users/karma-runner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karma-runner/subscriptions","organizations_url":"https://api.github.com/users/karma-runner/orgs","repos_url":"https://api.github.com/users/karma-runner/repos","events_url":"https://api.github.com/users/karma-runner/events{/privacy}","received_events_url":"https://api.github.com/users/karma-runner/received_events","type":"Organization","site_admin":false},"repo":{"id":11011566,"name":"karma-webdriver-launcher","full_name":"karma-runner/karma-webdriver-launcher","owner":{"login":"karma-runner","id":3284117,"avatar_url":"https://avatars.githubusercontent.com/u/3284117?v=3","gravatar_id":"","url":"https://api.github.com/users/karma-runner","html_url":"https://github.com/karma-runner","followers_url":"https://api.github.com/users/karma-runner/followers","following_url":"https://api.github.com/users/karma-runner/following{/other_user}","gists_url":"https://api.github.com/users/karma-runner/gists{/gist_id}","starred_url":"https://api.github.com/users/karma-runner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karma-runner/subscriptions","organizations_url":"https://api.github.com/users/karma-runner/orgs","repos_url":"https://api.github.com/users/karma-runner/repos","events_url":"https://api.github.com/users/karma-runner/events{/privacy}","received_events_url":"https://api.github.com/users/karma-runner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/karma-runner/karma-webdriver-launcher","description":"A plugin for Karma. Launch any browser with WebDriver.","fork":false,"url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher","forks_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/forks","keys_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/teams","hooks_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/hooks","issue_events_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/issues/events{/number}","events_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/events","assignees_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/assignees{/user}","branches_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/branches{/branch}","tags_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/tags","blobs_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/statuses/{sha}","languages_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/languages","stargazers_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/stargazers","contributors_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/contributors","subscribers_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/subscribers","subscription_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/subscription","commits_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/issues/comments/{number}","contents_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/contents/{+path}","compare_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/merges","archive_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/downloads","issues_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/issues{/number}","pulls_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/pulls{/number}","milestones_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/milestones{/number}","notifications_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/labels{/name}","releases_url":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/releases{/id}","created_at":"2013-06-28T00:39:26Z","updated_at":"2014-10-28T17:15:01Z","pushed_at":"2014-11-14T21:16:49Z","git_url":"git://github.com/karma-runner/karma-webdriver-launcher.git","ssh_url":"git@github.com:karma-runner/karma-webdriver-launcher.git","clone_url":"https://github.com/karma-runner/karma-webdriver-launcher.git","svn_url":"https://github.com/karma-runner/karma-webdriver-launcher","homepage":null,"size":326,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":3,"forks":16,"open_issues":3,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/pulls/14"},"html":{"href":"https://github.com/karma-runner/karma-webdriver-launcher/pull/14"},"issue":{"href":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/issues/14"},"comments":{"href":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/karma-runner/karma-webdriver-launcher/statuses/753b40798ca7a679ba2863131a363914f5fc87e5"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":11,"review_comments":2,"commits":4,"additions":17,"deletions":8,"changed_files":1}}