GitHub PullRequestEvent at 2014-10-20 12:26:49
Repository: apns4erl
Actor: elbrujohalcon
Payload: {"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/inaka/apns4erl/pulls/32","id":22912101,"html_url":"https://github.com/inaka/apns4erl/pull/32","diff_url":"https://github.com/inaka/apns4erl/pull/32.diff","patch_url":"https://github.com/inaka/apns4erl/pull/32.patch","issue_url":"https://api.github.com/repos/inaka/apns4erl/issues/32","number":32,"state":"closed","locked":false,"title":"Remove env-section from apns.app.src","user":{"login":"bipthelin","id":1185571,"avatar_url":"https://avatars.githubusercontent.com/u/1185571?v=2","gravatar_id":"","url":"https://api.github.com/users/bipthelin","html_url":"https://github.com/bipthelin","followers_url":"https://api.github.com/users/bipthelin/followers","following_url":"https://api.github.com/users/bipthelin/following{/other_user}","gists_url":"https://api.github.com/users/bipthelin/gists{/gist_id}","starred_url":"https://api.github.com/users/bipthelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bipthelin/subscriptions","organizations_url":"https://api.github.com/users/bipthelin/orgs","repos_url":"https://api.github.com/users/bipthelin/repos","events_url":"https://api.github.com/users/bipthelin/events{/privacy}","received_events_url":"https://api.github.com/users/bipthelin/received_events","type":"User","site_admin":false},"body":"The env-section effectively overrides any value set using\r\napplication:set_env/3 before apns is loaded making it harder to test,\r\netc. The data in env doesn't really add anyhing since the user most\r\ndefinitely want to update that with it's own info","created_at":"2014-10-17T09:14:09Z","updated_at":"2014-10-20T12:26:48Z","closed_at":"2014-10-20T12:26:48Z","merged_at":"2014-10-20T12:26:48Z","merge_commit_sha":"53e3815b002e894a903511994a11e77ebe6b546c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inaka/apns4erl/pulls/32/commits","review_comments_url":"https://api.github.com/repos/inaka/apns4erl/pulls/32/comments","review_comment_url":"https://api.github.com/repos/inaka/apns4erl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inaka/apns4erl/issues/32/comments","statuses_url":"https://api.github.com/repos/inaka/apns4erl/statuses/2f9558499d232db3dbbec8907f60e3f93ecfefd4","head":{"label":"bipthelin:master","ref":"master","sha":"2f9558499d232db3dbbec8907f60e3f93ecfefd4","user":{"login":"bipthelin","id":1185571,"avatar_url":"https://avatars.githubusercontent.com/u/1185571?v=2","gravatar_id":"","url":"https://api.github.com/users/bipthelin","html_url":"https://github.com/bipthelin","followers_url":"https://api.github.com/users/bipthelin/followers","following_url":"https://api.github.com/users/bipthelin/following{/other_user}","gists_url":"https://api.github.com/users/bipthelin/gists{/gist_id}","starred_url":"https://api.github.com/users/bipthelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bipthelin/subscriptions","organizations_url":"https://api.github.com/users/bipthelin/orgs","repos_url":"https://api.github.com/users/bipthelin/repos","events_url":"https://api.github.com/users/bipthelin/events{/privacy}","received_events_url":"https://api.github.com/users/bipthelin/received_events","type":"User","site_admin":false},"repo":{"id":25344480,"name":"apns4erl","full_name":"bipthelin/apns4erl","owner":{"login":"bipthelin","id":1185571,"avatar_url":"https://avatars.githubusercontent.com/u/1185571?v=2","gravatar_id":"","url":"https://api.github.com/users/bipthelin","html_url":"https://github.com/bipthelin","followers_url":"https://api.github.com/users/bipthelin/followers","following_url":"https://api.github.com/users/bipthelin/following{/other_user}","gists_url":"https://api.github.com/users/bipthelin/gists{/gist_id}","starred_url":"https://api.github.com/users/bipthelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bipthelin/subscriptions","organizations_url":"https://api.github.com/users/bipthelin/orgs","repos_url":"https://api.github.com/users/bipthelin/repos","events_url":"https://api.github.com/users/bipthelin/events{/privacy}","received_events_url":"https://api.github.com/users/bipthelin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bipthelin/apns4erl","description":"Apple Push Notification Server for Erlang","fork":true,"url":"https://api.github.com/repos/bipthelin/apns4erl","forks_url":"https://api.github.com/repos/bipthelin/apns4erl/forks","keys_url":"https://api.github.com/repos/bipthelin/apns4erl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bipthelin/apns4erl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bipthelin/apns4erl/teams","hooks_url":"https://api.github.com/repos/bipthelin/apns4erl/hooks","issue_events_url":"https://api.github.com/repos/bipthelin/apns4erl/issues/events{/number}","events_url":"https://api.github.com/repos/bipthelin/apns4erl/events","assignees_url":"https://api.github.com/repos/bipthelin/apns4erl/assignees{/user}","branches_url":"https://api.github.com/repos/bipthelin/apns4erl/branches{/branch}","tags_url":"https://api.github.com/repos/bipthelin/apns4erl/tags","blobs_url":"https://api.github.com/repos/bipthelin/apns4erl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bipthelin/apns4erl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bipthelin/apns4erl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bipthelin/apns4erl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bipthelin/apns4erl/statuses/{sha}","languages_url":"https://api.github.com/repos/bipthelin/apns4erl/languages","stargazers_url":"https://api.github.com/repos/bipthelin/apns4erl/stargazers","contributors_url":"https://api.github.com/repos/bipthelin/apns4erl/contributors","subscribers_url":"https://api.github.com/repos/bipthelin/apns4erl/subscribers","subscription_url":"https://api.github.com/repos/bipthelin/apns4erl/subscription","commits_url":"https://api.github.com/repos/bipthelin/apns4erl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bipthelin/apns4erl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bipthelin/apns4erl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bipthelin/apns4erl/issues/comments/{number}","contents_url":"https://api.github.com/repos/bipthelin/apns4erl/contents/{+path}","compare_url":"https://api.github.com/repos/bipthelin/apns4erl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bipthelin/apns4erl/merges","archive_url":"https://api.github.com/repos/bipthelin/apns4erl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bipthelin/apns4erl/downloads","issues_url":"https://api.github.com/repos/bipthelin/apns4erl/issues{/number}","pulls_url":"https://api.github.com/repos/bipthelin/apns4erl/pulls{/number}","milestones_url":"https://api.github.com/repos/bipthelin/apns4erl/milestones{/number}","notifications_url":"https://api.github.com/repos/bipthelin/apns4erl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bipthelin/apns4erl/labels{/name}","releases_url":"https://api.github.com/repos/bipthelin/apns4erl/releases{/id}","created_at":"2014-10-17T07:17:17Z","updated_at":"2014-10-17T07:26:11Z","pushed_at":"2014-10-20T08:52:32Z","git_url":"git://github.com/bipthelin/apns4erl.git","ssh_url":"git@github.com:bipthelin/apns4erl.git","clone_url":"https://github.com/bipthelin/apns4erl.git","svn_url":"https://github.com/bipthelin/apns4erl","homepage":"http://inaka.github.com/apns4erl","size":815,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inaka:master","ref":"master","sha":"2d5b5bcb32d04bcd8ddfb83c45488da735c9170d","user":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=2","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"repo":{"id":1035547,"name":"apns4erl","full_name":"inaka/apns4erl","owner":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=2","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inaka/apns4erl","description":"Apple Push Notification Server for Erlang","fork":false,"url":"https://api.github.com/repos/inaka/apns4erl","forks_url":"https://api.github.com/repos/inaka/apns4erl/forks","keys_url":"https://api.github.com/repos/inaka/apns4erl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inaka/apns4erl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inaka/apns4erl/teams","hooks_url":"https://api.github.com/repos/inaka/apns4erl/hooks","issue_events_url":"https://api.github.com/repos/inaka/apns4erl/issues/events{/number}","events_url":"https://api.github.com/repos/inaka/apns4erl/events","assignees_url":"https://api.github.com/repos/inaka/apns4erl/assignees{/user}","branches_url":"https://api.github.com/repos/inaka/apns4erl/branches{/branch}","tags_url":"https://api.github.com/repos/inaka/apns4erl/tags","blobs_url":"https://api.github.com/repos/inaka/apns4erl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inaka/apns4erl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inaka/apns4erl/git/refs{/sha}","trees_url":"https://api.github.com/repos/inaka/apns4erl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inaka/apns4erl/statuses/{sha}","languages_url":"https://api.github.com/repos/inaka/apns4erl/languages","stargazers_url":"https://api.github.com/repos/inaka/apns4erl/stargazers","contributors_url":"https://api.github.com/repos/inaka/apns4erl/contributors","subscribers_url":"https://api.github.com/repos/inaka/apns4erl/subscribers","subscription_url":"https://api.github.com/repos/inaka/apns4erl/subscription","commits_url":"https://api.github.com/repos/inaka/apns4erl/commits{/sha}","git_commits_url":"https://api.github.com/repos/inaka/apns4erl/git/commits{/sha}","comments_url":"https://api.github.com/repos/inaka/apns4erl/comments{/number}","issue_comment_url":"https://api.github.com/repos/inaka/apns4erl/issues/comments/{number}","contents_url":"https://api.github.com/repos/inaka/apns4erl/contents/{+path}","compare_url":"https://api.github.com/repos/inaka/apns4erl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inaka/apns4erl/merges","archive_url":"https://api.github.com/repos/inaka/apns4erl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inaka/apns4erl/downloads","issues_url":"https://api.github.com/repos/inaka/apns4erl/issues{/number}","pulls_url":"https://api.github.com/repos/inaka/apns4erl/pulls{/number}","milestones_url":"https://api.github.com/repos/inaka/apns4erl/milestones{/number}","notifications_url":"https://api.github.com/repos/inaka/apns4erl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inaka/apns4erl/labels{/name}","releases_url":"https://api.github.com/repos/inaka/apns4erl/releases{/id}","created_at":"2010-10-29T17:48:38Z","updated_at":"2014-10-06T13:24:43Z","pushed_at":"2014-10-20T12:26:48Z","git_url":"git://github.com/inaka/apns4erl.git","ssh_url":"git@github.com:inaka/apns4erl.git","clone_url":"https://github.com/inaka/apns4erl.git","svn_url":"https://github.com/inaka/apns4erl","homepage":"http://inaka.github.com/apns4erl","size":815,"stargazers_count":124,"watchers_count":124,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":85,"mirror_url":null,"open_issues_count":8,"forks":85,"open_issues":8,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inaka/apns4erl/pulls/32"},"html":{"href":"https://github.com/inaka/apns4erl/pull/32"},"issue":{"href":"https://api.github.com/repos/inaka/apns4erl/issues/32"},"comments":{"href":"https://api.github.com/repos/inaka/apns4erl/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/inaka/apns4erl/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/inaka/apns4erl/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/inaka/apns4erl/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/inaka/apns4erl/statuses/2f9558499d232db3dbbec8907f60e3f93ecfefd4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"elbrujohalcon","id":93657,"avatar_url":"https://avatars.githubusercontent.com/u/93657?v=2","gravatar_id":"","url":"https://api.github.com/users/elbrujohalcon","html_url":"https://github.com/elbrujohalcon","followers_url":"https://api.github.com/users/elbrujohalcon/followers","following_url":"https://api.github.com/users/elbrujohalcon/following{/other_user}","gists_url":"https://api.github.com/users/elbrujohalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/elbrujohalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elbrujohalcon/subscriptions","organizations_url":"https://api.github.com/users/elbrujohalcon/orgs","repos_url":"https://api.github.com/users/elbrujohalcon/repos","events_url":"https://api.github.com/users/elbrujohalcon/events{/privacy}","received_events_url":"https://api.github.com/users/elbrujohalcon/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":14,"deletions":10,"changed_files":2}}