GitHub PullRequestReviewCommentEvent at 2014-03-21 08:48:28
Repository: VisualFSharpPowerTools
Actor: dungpa
Payload: {"comment":{"url":"https://api.github.com/repos/fsprojects/VisualFSharpPowerTools/pulls/comments/10829441","id":10829441,"diff_hunk":"@@ -14,10 +15,14 @@ open Microsoft.FSharp.Compiler.Range\n open FSharpVSPowerTools\n \n let fromPos (snapshot: ITextSnapshot) (startLine, startColumn, endLine, endColumn) =\n+    Debug.Assert(startLine <= endLine, sprintf \"startLine = %d, endLine = %d\" startLine endLine)\n+    Debug.Assert((if startLine = endLine then startColumn < endColumn else true), ","path":"src/FSharpVSPowerTools.Logic/VSUtils.fs","position":13,"original_position":13,"commit_id":"b95cb6382f8e0bb87aa1b76ce0b95bfa2de5f9be","original_commit_id":"b95cb6382f8e0bb87aa1b76ce0b95bfa2de5f9be","user":{"login":"dungpa","id":941060,"avatar_url":"https://avatars.githubusercontent.com/u/941060?","gravatar_id":"8ed97e17be271ab53ada09addc1ef824","url":"https://api.github.com/users/dungpa","html_url":"https://github.com/dungpa","followers_url":"https://api.github.com/users/dungpa/followers","following_url":"https://api.github.com/users/dungpa/following{/other_user}","gists_url":"https://api.github.com/users/dungpa/gists{/gist_id}","starred_url":"https://api.github.com/users/dungpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dungpa/subscriptions","organizations_url":"https://api.github.com/users/dungpa/orgs","repos_url":"https://api.github.com/users/dungpa/repos","events_url":"https://api.github.com/users/dungpa/events{/privacy}","received_events_url":"https://api.github.com/users/dungpa/received_events","type":"User","site_admin":false},"body":"Perhaps you should change the condition to (startLine <> endLine) || (startColumn < endColumn).","created_at":"2014-03-21T08:48:28Z","updated_at":"2014-03-21T08:48:28Z","html_url":"https://github.com/fsprojects/VisualFSharpPowerTools/pull/223#discussion_r10829441","pull_request_url":"https://api.github.com/repos/fsprojects/VisualFSharpPowerTools/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/fsprojects/VisualFSharpPowerTools/pulls/comments/10829441"},"html":{"href":"https://github.com/fsprojects/VisualFSharpPowerTools/pull/223#discussion_r10829441"},"pull_request":{"href":"https://api.github.com/repos/fsprojects/VisualFSharpPowerTools/pulls/223"}}}}