GitHub PullRequestEvent at 2014-11-07 01:16:45
Repository: django-scheduler
Actor: llazzaro
Payload: {"action":"closed","number":89,"pull_request":{"url":"https://api.github.com/repos/llazzaro/django-scheduler/pulls/89","id":24007747,"html_url":"https://github.com/llazzaro/django-scheduler/pull/89","diff_url":"https://github.com/llazzaro/django-scheduler/pull/89.diff","patch_url":"https://github.com/llazzaro/django-scheduler/pull/89.patch","issue_url":"https://api.github.com/repos/llazzaro/django-scheduler/issues/89","number":89,"state":"closed","locked":false,"title":"Recurring occurrences not displayed correctly in week view","user":{"login":"timcallagy","id":4582524,"avatar_url":"https://avatars.githubusercontent.com/u/4582524?v=2","gravatar_id":"","url":"https://api.github.com/users/timcallagy","html_url":"https://github.com/timcallagy","followers_url":"https://api.github.com/users/timcallagy/followers","following_url":"https://api.github.com/users/timcallagy/following{/other_user}","gists_url":"https://api.github.com/users/timcallagy/gists{/gist_id}","starred_url":"https://api.github.com/users/timcallagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timcallagy/subscriptions","organizations_url":"https://api.github.com/users/timcallagy/orgs","repos_url":"https://api.github.com/users/timcallagy/repos","events_url":"https://api.github.com/users/timcallagy/events{/privacy}","received_events_url":"https://api.github.com/users/timcallagy/received_events","type":"User","site_admin":false},"body":"While testing changes in pull request 88 (https://github.com/llazzaro/django-scheduler/pull/86), I noticed some cases where occurrences of recurring events were still not displayed correctly in week view. An occurrence split over two days was only shown on one of those days.\r\nThe problem was that o_starts was being overwritten when multiple rule matches were found. Turning o_starts into a list allows it hold these multiple rule matches. ","created_at":"2014-11-06T19:56:30Z","updated_at":"2014-11-07T01:16:45Z","closed_at":"2014-11-07T01:16:45Z","merged_at":"2014-11-07T01:16:45Z","merge_commit_sha":"968220ababcfddabd4e8ff2bbfff2a64830a31e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/llazzaro/django-scheduler/pulls/89/commits","review_comments_url":"https://api.github.com/repos/llazzaro/django-scheduler/pulls/89/comments","review_comment_url":"https://api.github.com/repos/llazzaro/django-scheduler/pulls/comments/{number}","comments_url":"https://api.github.com/repos/llazzaro/django-scheduler/issues/89/comments","statuses_url":"https://api.github.com/repos/llazzaro/django-scheduler/statuses/eb88e2905ba5f01fbe4c2c7c416a28bcc23f3d43","head":{"label":"timcallagy:week_view_split","ref":"week_view_split","sha":"eb88e2905ba5f01fbe4c2c7c416a28bcc23f3d43","user":{"login":"timcallagy","id":4582524,"avatar_url":"https://avatars.githubusercontent.com/u/4582524?v=2","gravatar_id":"","url":"https://api.github.com/users/timcallagy","html_url":"https://github.com/timcallagy","followers_url":"https://api.github.com/users/timcallagy/followers","following_url":"https://api.github.com/users/timcallagy/following{/other_user}","gists_url":"https://api.github.com/users/timcallagy/gists{/gist_id}","starred_url":"https://api.github.com/users/timcallagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timcallagy/subscriptions","organizations_url":"https://api.github.com/users/timcallagy/orgs","repos_url":"https://api.github.com/users/timcallagy/repos","events_url":"https://api.github.com/users/timcallagy/events{/privacy}","received_events_url":"https://api.github.com/users/timcallagy/received_events","type":"User","site_admin":false},"repo":{"id":25789955,"name":"django-scheduler","full_name":"timcallagy/django-scheduler","owner":{"login":"timcallagy","id":4582524,"avatar_url":"https://avatars.githubusercontent.com/u/4582524?v=2","gravatar_id":"","url":"https://api.github.com/users/timcallagy","html_url":"https://github.com/timcallagy","followers_url":"https://api.github.com/users/timcallagy/followers","following_url":"https://api.github.com/users/timcallagy/following{/other_user}","gists_url":"https://api.github.com/users/timcallagy/gists{/gist_id}","starred_url":"https://api.github.com/users/timcallagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timcallagy/subscriptions","organizations_url":"https://api.github.com/users/timcallagy/orgs","repos_url":"https://api.github.com/users/timcallagy/repos","events_url":"https://api.github.com/users/timcallagy/events{/privacy}","received_events_url":"https://api.github.com/users/timcallagy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timcallagy/django-scheduler","description":"A calendar app for Django","fork":true,"url":"https://api.github.com/repos/timcallagy/django-scheduler","forks_url":"https://api.github.com/repos/timcallagy/django-scheduler/forks","keys_url":"https://api.github.com/repos/timcallagy/django-scheduler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timcallagy/django-scheduler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timcallagy/django-scheduler/teams","hooks_url":"https://api.github.com/repos/timcallagy/django-scheduler/hooks","issue_events_url":"https://api.github.com/repos/timcallagy/django-scheduler/issues/events{/number}","events_url":"https://api.github.com/repos/timcallagy/django-scheduler/events","assignees_url":"https://api.github.com/repos/timcallagy/django-scheduler/assignees{/user}","branches_url":"https://api.github.com/repos/timcallagy/django-scheduler/branches{/branch}","tags_url":"https://api.github.com/repos/timcallagy/django-scheduler/tags","blobs_url":"https://api.github.com/repos/timcallagy/django-scheduler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timcallagy/django-scheduler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timcallagy/django-scheduler/git/refs{/sha}","trees_url":"https://api.github.com/repos/timcallagy/django-scheduler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timcallagy/django-scheduler/statuses/{sha}","languages_url":"https://api.github.com/repos/timcallagy/django-scheduler/languages","stargazers_url":"https://api.github.com/repos/timcallagy/django-scheduler/stargazers","contributors_url":"https://api.github.com/repos/timcallagy/django-scheduler/contributors","subscribers_url":"https://api.github.com/repos/timcallagy/django-scheduler/subscribers","subscription_url":"https://api.github.com/repos/timcallagy/django-scheduler/subscription","commits_url":"https://api.github.com/repos/timcallagy/django-scheduler/commits{/sha}","git_commits_url":"https://api.github.com/repos/timcallagy/django-scheduler/git/commits{/sha}","comments_url":"https://api.github.com/repos/timcallagy/django-scheduler/comments{/number}","issue_comment_url":"https://api.github.com/repos/timcallagy/django-scheduler/issues/comments/{number}","contents_url":"https://api.github.com/repos/timcallagy/django-scheduler/contents/{+path}","compare_url":"https://api.github.com/repos/timcallagy/django-scheduler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timcallagy/django-scheduler/merges","archive_url":"https://api.github.com/repos/timcallagy/django-scheduler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timcallagy/django-scheduler/downloads","issues_url":"https://api.github.com/repos/timcallagy/django-scheduler/issues{/number}","pulls_url":"https://api.github.com/repos/timcallagy/django-scheduler/pulls{/number}","milestones_url":"https://api.github.com/repos/timcallagy/django-scheduler/milestones{/number}","notifications_url":"https://api.github.com/repos/timcallagy/django-scheduler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timcallagy/django-scheduler/labels{/name}","releases_url":"https://api.github.com/repos/timcallagy/django-scheduler/releases{/id}","created_at":"2014-10-26T20:37:13Z","updated_at":"2014-10-27T09:08:53Z","pushed_at":"2014-11-06T19:47:45Z","git_url":"git://github.com/timcallagy/django-scheduler.git","ssh_url":"git@github.com:timcallagy/django-scheduler.git","clone_url":"https://github.com/timcallagy/django-scheduler.git","svn_url":"https://github.com/timcallagy/django-scheduler","homepage":"django-scheduler.leonardolazzaro.com","size":1864,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"llazzaro:master","ref":"master","sha":"0a59d860d7e86a28564128ad1141ce20957d5708","user":{"login":"llazzaro","id":568181,"avatar_url":"https://avatars.githubusercontent.com/u/568181?v=2","gravatar_id":"","url":"https://api.github.com/users/llazzaro","html_url":"https://github.com/llazzaro","followers_url":"https://api.github.com/users/llazzaro/followers","following_url":"https://api.github.com/users/llazzaro/following{/other_user}","gists_url":"https://api.github.com/users/llazzaro/gists{/gist_id}","starred_url":"https://api.github.com/users/llazzaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llazzaro/subscriptions","organizations_url":"https://api.github.com/users/llazzaro/orgs","repos_url":"https://api.github.com/users/llazzaro/repos","events_url":"https://api.github.com/users/llazzaro/events{/privacy}","received_events_url":"https://api.github.com/users/llazzaro/received_events","type":"User","site_admin":false},"repo":{"id":9370804,"name":"django-scheduler","full_name":"llazzaro/django-scheduler","owner":{"login":"llazzaro","id":568181,"avatar_url":"https://avatars.githubusercontent.com/u/568181?v=2","gravatar_id":"","url":"https://api.github.com/users/llazzaro","html_url":"https://github.com/llazzaro","followers_url":"https://api.github.com/users/llazzaro/followers","following_url":"https://api.github.com/users/llazzaro/following{/other_user}","gists_url":"https://api.github.com/users/llazzaro/gists{/gist_id}","starred_url":"https://api.github.com/users/llazzaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llazzaro/subscriptions","organizations_url":"https://api.github.com/users/llazzaro/orgs","repos_url":"https://api.github.com/users/llazzaro/repos","events_url":"https://api.github.com/users/llazzaro/events{/privacy}","received_events_url":"https://api.github.com/users/llazzaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/llazzaro/django-scheduler","description":"A calendar app for Django (inprogress refactor of django-schedule)","fork":false,"url":"https://api.github.com/repos/llazzaro/django-scheduler","forks_url":"https://api.github.com/repos/llazzaro/django-scheduler/forks","keys_url":"https://api.github.com/repos/llazzaro/django-scheduler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/llazzaro/django-scheduler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/llazzaro/django-scheduler/teams","hooks_url":"https://api.github.com/repos/llazzaro/django-scheduler/hooks","issue_events_url":"https://api.github.com/repos/llazzaro/django-scheduler/issues/events{/number}","events_url":"https://api.github.com/repos/llazzaro/django-scheduler/events","assignees_url":"https://api.github.com/repos/llazzaro/django-scheduler/assignees{/user}","branches_url":"https://api.github.com/repos/llazzaro/django-scheduler/branches{/branch}","tags_url":"https://api.github.com/repos/llazzaro/django-scheduler/tags","blobs_url":"https://api.github.com/repos/llazzaro/django-scheduler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/llazzaro/django-scheduler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/llazzaro/django-scheduler/git/refs{/sha}","trees_url":"https://api.github.com/repos/llazzaro/django-scheduler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/llazzaro/django-scheduler/statuses/{sha}","languages_url":"https://api.github.com/repos/llazzaro/django-scheduler/languages","stargazers_url":"https://api.github.com/repos/llazzaro/django-scheduler/stargazers","contributors_url":"https://api.github.com/repos/llazzaro/django-scheduler/contributors","subscribers_url":"https://api.github.com/repos/llazzaro/django-scheduler/subscribers","subscription_url":"https://api.github.com/repos/llazzaro/django-scheduler/subscription","commits_url":"https://api.github.com/repos/llazzaro/django-scheduler/commits{/sha}","git_commits_url":"https://api.github.com/repos/llazzaro/django-scheduler/git/commits{/sha}","comments_url":"https://api.github.com/repos/llazzaro/django-scheduler/comments{/number}","issue_comment_url":"https://api.github.com/repos/llazzaro/django-scheduler/issues/comments/{number}","contents_url":"https://api.github.com/repos/llazzaro/django-scheduler/contents/{+path}","compare_url":"https://api.github.com/repos/llazzaro/django-scheduler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/llazzaro/django-scheduler/merges","archive_url":"https://api.github.com/repos/llazzaro/django-scheduler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/llazzaro/django-scheduler/downloads","issues_url":"https://api.github.com/repos/llazzaro/django-scheduler/issues{/number}","pulls_url":"https://api.github.com/repos/llazzaro/django-scheduler/pulls{/number}","milestones_url":"https://api.github.com/repos/llazzaro/django-scheduler/milestones{/number}","notifications_url":"https://api.github.com/repos/llazzaro/django-scheduler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/llazzaro/django-scheduler/labels{/name}","releases_url":"https://api.github.com/repos/llazzaro/django-scheduler/releases{/id}","created_at":"2013-04-11T13:24:19Z","updated_at":"2014-11-03T10:15:17Z","pushed_at":"2014-11-07T01:16:45Z","git_url":"git://github.com/llazzaro/django-scheduler.git","ssh_url":"git@github.com:llazzaro/django-scheduler.git","clone_url":"https://github.com/llazzaro/django-scheduler.git","svn_url":"https://github.com/llazzaro/django-scheduler","homepage":"","size":3623,"stargazers_count":114,"watchers_count":114,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":26,"forks":56,"open_issues":26,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/llazzaro/django-scheduler/pulls/89"},"html":{"href":"https://github.com/llazzaro/django-scheduler/pull/89"},"issue":{"href":"https://api.github.com/repos/llazzaro/django-scheduler/issues/89"},"comments":{"href":"https://api.github.com/repos/llazzaro/django-scheduler/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/llazzaro/django-scheduler/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/llazzaro/django-scheduler/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/llazzaro/django-scheduler/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/llazzaro/django-scheduler/statuses/eb88e2905ba5f01fbe4c2c7c416a28bcc23f3d43"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"llazzaro","id":568181,"avatar_url":"https://avatars.githubusercontent.com/u/568181?v=2","gravatar_id":"","url":"https://api.github.com/users/llazzaro","html_url":"https://github.com/llazzaro","followers_url":"https://api.github.com/users/llazzaro/followers","following_url":"https://api.github.com/users/llazzaro/following{/other_user}","gists_url":"https://api.github.com/users/llazzaro/gists{/gist_id}","starred_url":"https://api.github.com/users/llazzaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llazzaro/subscriptions","organizations_url":"https://api.github.com/users/llazzaro/orgs","repos_url":"https://api.github.com/users/llazzaro/repos","events_url":"https://api.github.com/users/llazzaro/events{/privacy}","received_events_url":"https://api.github.com/users/llazzaro/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":10,"deletions":4,"changed_files":1}}