GitHub PullRequestReviewCommentEvent at 2014-08-14 23:07:05
Repository: intercom-ruby
Actor: urkle
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/intercom/intercom-ruby/pulls/comments/16272558","id":16272558,"diff_hunk":"@@ -3,9 +3,10 @@ module Intercom\n   # Base class exception from which all public Intercom exceptions will be derived\n   class IntercomError < StandardError\n     attr_reader :http_code, :application_error_code\n-    def initialize(message, http_code: nil, application_error_code: application_error_code)\n+    def initialize(message, http_code = nil, app_error_code = nil)\n+      app_error_code = app_error_code || application_error_code","path":"lib/intercom/errors.rb","position":6,"original_position":6,"commit_id":"253949df3c23fc4a00a0cc7bde82f8bcc0fd1e92","original_commit_id":"253949df3c23fc4a00a0cc7bde82f8bcc0fd1e92","user":{"login":"urkle","id":101123,"avatar_url":"https://avatars.githubusercontent.com/u/101123?v=2","gravatar_id":"2092020215ed16734303313137bf2ce2","url":"https://api.github.com/users/urkle","html_url":"https://github.com/urkle","followers_url":"https://api.github.com/users/urkle/followers","following_url":"https://api.github.com/users/urkle/following{/other_user}","gists_url":"https://api.github.com/users/urkle/gists{/gist_id}","starred_url":"https://api.github.com/users/urkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urkle/subscriptions","organizations_url":"https://api.github.com/users/urkle/orgs","repos_url":"https://api.github.com/users/urkle/repos","events_url":"https://api.github.com/users/urkle/events{/privacy}","received_events_url":"https://api.github.com/users/urkle/received_events","type":"User","site_admin":false},"body":"The previous version of the code simply did\r\n```ruby\r\n@application_error_code = application_error_code\r\n```\r\nwhich would have pulled it JUST from the arguments.    And the code example you\\ referenced only was checking the error code not setting it.    You wouldn't call anything prior to initialize as that is the constructor.  so that line really isn't needed at all and you can revert the name of the argument to be application_error_code.","created_at":"2014-08-14T23:07:05Z","updated_at":"2014-08-14T23:07:05Z","html_url":"https://github.com/intercom/intercom-ruby/pull/99#discussion_r16272558","pull_request_url":"https://api.github.com/repos/intercom/intercom-ruby/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/intercom/intercom-ruby/pulls/comments/16272558"},"html":{"href":"https://github.com/intercom/intercom-ruby/pull/99#discussion_r16272558"},"pull_request":{"href":"https://api.github.com/repos/intercom/intercom-ruby/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/intercom/intercom-ruby/pulls/99","id":19801394,"html_url":"https://github.com/intercom/intercom-ruby/pull/99","diff_url":"https://github.com/intercom/intercom-ruby/pull/99.diff","patch_url":"https://github.com/intercom/intercom-ruby/pull/99.patch","issue_url":"https://api.github.com/repos/intercom/intercom-ruby/issues/99","number":99,"state":"open","locked":false,"title":"Fix old ruby","user":{"login":"Chocksy","id":178892,"avatar_url":"https://avatars.githubusercontent.com/u/178892?v=2","gravatar_id":"5c98d92c88d8d82a89c8b39e2477187f","url":"https://api.github.com/users/Chocksy","html_url":"https://github.com/Chocksy","followers_url":"https://api.github.com/users/Chocksy/followers","following_url":"https://api.github.com/users/Chocksy/following{/other_user}","gists_url":"https://api.github.com/users/Chocksy/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocksy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocksy/subscriptions","organizations_url":"https://api.github.com/users/Chocksy/orgs","repos_url":"https://api.github.com/users/Chocksy/repos","events_url":"https://api.github.com/users/Chocksy/events{/privacy}","received_events_url":"https://api.github.com/users/Chocksy/received_events","type":"User","site_admin":false},"body":"Made multiple changes that are required for compatibility with ruby 1.9.3. \r\n#79 should be fixed by this","created_at":"2014-08-14T17:18:07Z","updated_at":"2014-08-14T23:07:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eba6ce40178f1387b2ffe1e31bdb25a988a42b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/intercom/intercom-ruby/pulls/99/commits","review_comments_url":"https://api.github.com/repos/intercom/intercom-ruby/pulls/99/comments","review_comment_url":"https://api.github.com/repos/intercom/intercom-ruby/pulls/comments/{number}","comments_url":"https://api.github.com/repos/intercom/intercom-ruby/issues/99/comments","statuses_url":"https://api.github.com/repos/intercom/intercom-ruby/statuses/253949df3c23fc4a00a0cc7bde82f8bcc0fd1e92","head":{"label":"Hubstaff:fix-old-ruby","ref":"fix-old-ruby","sha":"253949df3c23fc4a00a0cc7bde82f8bcc0fd1e92","user":{"login":"Hubstaff","id":8418478,"avatar_url":"https://avatars.githubusercontent.com/u/8418478?v=2","gravatar_id":null,"url":"https://api.github.com/users/Hubstaff","html_url":"https://github.com/Hubstaff","followers_url":"https://api.github.com/users/Hubstaff/followers","following_url":"https://api.github.com/users/Hubstaff/following{/other_user}","gists_url":"https://api.github.com/users/Hubstaff/gists{/gist_id}","starred_url":"https://api.github.com/users/Hubstaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hubstaff/subscriptions","organizations_url":"https://api.github.com/users/Hubstaff/orgs","repos_url":"https://api.github.com/users/Hubstaff/repos","events_url":"https://api.github.com/users/Hubstaff/events{/privacy}","received_events_url":"https://api.github.com/users/Hubstaff/received_events","type":"Organization","site_admin":false},"repo":{"id":22845390,"name":"intercom-ruby","full_name":"Hubstaff/intercom-ruby","owner":{"login":"Hubstaff","id":8418478,"avatar_url":"https://avatars.githubusercontent.com/u/8418478?v=2","gravatar_id":null,"url":"https://api.github.com/users/Hubstaff","html_url":"https://github.com/Hubstaff","followers_url":"https://api.github.com/users/Hubstaff/followers","following_url":"https://api.github.com/users/Hubstaff/following{/other_user}","gists_url":"https://api.github.com/users/Hubstaff/gists{/gist_id}","starred_url":"https://api.github.com/users/Hubstaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hubstaff/subscriptions","organizations_url":"https://api.github.com/users/Hubstaff/orgs","repos_url":"https://api.github.com/users/Hubstaff/repos","events_url":"https://api.github.com/users/Hubstaff/events{/privacy}","received_events_url":"https://api.github.com/users/Hubstaff/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Hubstaff/intercom-ruby","description":"Client library for Intercom web service","fork":true,"url":"https://api.github.com/repos/Hubstaff/intercom-ruby","forks_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/forks","keys_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/teams","hooks_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/hooks","issue_events_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/events","assignees_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/tags","blobs_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/languages","stargazers_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/stargazers","contributors_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/contributors","subscribers_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/subscribers","subscription_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/subscription","commits_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/issues/comments/{number}","contents_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/merges","archive_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/downloads","issues_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/labels{/name}","releases_url":"https://api.github.com/repos/Hubstaff/intercom-ruby/releases{/id}","created_at":"2014-08-11T16:06:15Z","updated_at":"2014-08-11T18:16:38Z","pushed_at":"2014-08-14T17:37:15Z","git_url":"git://github.com/Hubstaff/intercom-ruby.git","ssh_url":"git@github.com:Hubstaff/intercom-ruby.git","clone_url":"https://github.com/Hubstaff/intercom-ruby.git","svn_url":"https://github.com/Hubstaff/intercom-ruby","homepage":"","size":1667,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intercom:master","ref":"master","sha":"d93b76a9bd42fede21d980a1c9c6c13362a3a980","user":{"login":"intercom","id":6585,"avatar_url":"https://avatars.githubusercontent.com/u/6585?v=2","gravatar_id":"66a65eb846de0364de57af39acc60a40","url":"https://api.github.com/users/intercom","html_url":"https://github.com/intercom","followers_url":"https://api.github.com/users/intercom/followers","following_url":"https://api.github.com/users/intercom/following{/other_user}","gists_url":"https://api.github.com/users/intercom/gists{/gist_id}","starred_url":"https://api.github.com/users/intercom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intercom/subscriptions","organizations_url":"https://api.github.com/users/intercom/orgs","repos_url":"https://api.github.com/users/intercom/repos","events_url":"https://api.github.com/users/intercom/events{/privacy}","received_events_url":"https://api.github.com/users/intercom/received_events","type":"Organization","site_admin":false},"repo":{"id":3449886,"name":"intercom-ruby","full_name":"intercom/intercom-ruby","owner":{"login":"intercom","id":6585,"avatar_url":"https://avatars.githubusercontent.com/u/6585?v=2","gravatar_id":"66a65eb846de0364de57af39acc60a40","url":"https://api.github.com/users/intercom","html_url":"https://github.com/intercom","followers_url":"https://api.github.com/users/intercom/followers","following_url":"https://api.github.com/users/intercom/following{/other_user}","gists_url":"https://api.github.com/users/intercom/gists{/gist_id}","starred_url":"https://api.github.com/users/intercom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intercom/subscriptions","organizations_url":"https://api.github.com/users/intercom/orgs","repos_url":"https://api.github.com/users/intercom/repos","events_url":"https://api.github.com/users/intercom/events{/privacy}","received_events_url":"https://api.github.com/users/intercom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intercom/intercom-ruby","description":"Client library for Intercom web service","fork":false,"url":"https://api.github.com/repos/intercom/intercom-ruby","forks_url":"https://api.github.com/repos/intercom/intercom-ruby/forks","keys_url":"https://api.github.com/repos/intercom/intercom-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intercom/intercom-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intercom/intercom-ruby/teams","hooks_url":"https://api.github.com/repos/intercom/intercom-ruby/hooks","issue_events_url":"https://api.github.com/repos/intercom/intercom-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/intercom/intercom-ruby/events","assignees_url":"https://api.github.com/repos/intercom/intercom-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/intercom/intercom-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/intercom/intercom-ruby/tags","blobs_url":"https://api.github.com/repos/intercom/intercom-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intercom/intercom-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intercom/intercom-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/intercom/intercom-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intercom/intercom-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/intercom/intercom-ruby/languages","stargazers_url":"https://api.github.com/repos/intercom/intercom-ruby/stargazers","contributors_url":"https://api.github.com/repos/intercom/intercom-ruby/contributors","subscribers_url":"https://api.github.com/repos/intercom/intercom-ruby/subscribers","subscription_url":"https://api.github.com/repos/intercom/intercom-ruby/subscription","commits_url":"https://api.github.com/repos/intercom/intercom-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/intercom/intercom-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/intercom/intercom-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/intercom/intercom-ruby/issues/comments/{number}","contents_url":"https://api.github.com/repos/intercom/intercom-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/intercom/intercom-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intercom/intercom-ruby/merges","archive_url":"https://api.github.com/repos/intercom/intercom-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intercom/intercom-ruby/downloads","issues_url":"https://api.github.com/repos/intercom/intercom-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/intercom/intercom-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/intercom/intercom-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/intercom/intercom-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intercom/intercom-ruby/labels{/name}","releases_url":"https://api.github.com/repos/intercom/intercom-ruby/releases{/id}","created_at":"2012-02-15T13:55:46Z","updated_at":"2014-07-23T21:00:17Z","pushed_at":"2014-08-07T18:07:10Z","git_url":"git://github.com/intercom/intercom-ruby.git","ssh_url":"git@github.com:intercom/intercom-ruby.git","clone_url":"https://github.com/intercom/intercom-ruby.git","svn_url":"https://github.com/intercom/intercom-ruby","homepage":"","size":1667,"stargazers_count":58,"watchers_count":58,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":27,"mirror_url":null,"open_issues_count":14,"forks":27,"open_issues":14,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intercom/intercom-ruby/pulls/99"},"html":{"href":"https://github.com/intercom/intercom-ruby/pull/99"},"issue":{"href":"https://api.github.com/repos/intercom/intercom-ruby/issues/99"},"comments":{"href":"https://api.github.com/repos/intercom/intercom-ruby/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/intercom/intercom-ruby/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/intercom/intercom-ruby/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/intercom/intercom-ruby/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/intercom/intercom-ruby/statuses/253949df3c23fc4a00a0cc7bde82f8bcc0fd1e92"}}}}