GitHub PullRequestReviewCommentEvent at 2014-06-18 18:28:51
Repository: gdrive.provider.anyfetch.com
Actor: Neamar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls/comments/13931774","id":13931774,"diff_hunk":"@@ -18,21 +19,31 @@ module.exports = function(app) {\n   }\n \n   queue.on('job complete', function(id, result) {\n-    var afToken;\n     async.waterfall([\n       function getJob(cb) {\n         kue.Job.get(id, cb);\n       },\n-      function setCursor(job, cb) {\n-        afToken = job.anyfetchToken;\n-\n-        store.hset('cursor', afToken, result, cb);\n+      function removeJob(job, cb) {\n+        var anyfetchToken = job.data.anyfetchToken;\n+        job.remove(rarity.carry([anyfetchToken], cb));\n+      },\n+      function setCursor(anyfetchToken, cb) {\n+        if(!anyfetchToken) {\n+          return cb(null, null, null);","path":"jobs/index.js","position":27,"original_position":27,"commit_id":"4e8f752bfae68df4ccb4b3fb5cd316999d5fb158","original_commit_id":"4e8f752bfae68df4ccb4b3fb5cd316999d5fb158","user":{"login":"Neamar","id":536844,"avatar_url":"https://avatars.githubusercontent.com/u/536844?","gravatar_id":"1bd44880100d5a4ce780441e4b54ddfe","url":"https://api.github.com/users/Neamar","html_url":"https://github.com/Neamar","followers_url":"https://api.github.com/users/Neamar/followers","following_url":"https://api.github.com/users/Neamar/following{/other_user}","gists_url":"https://api.github.com/users/Neamar/gists{/gist_id}","starred_url":"https://api.github.com/users/Neamar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neamar/subscriptions","organizations_url":"https://api.github.com/users/Neamar/orgs","repos_url":"https://api.github.com/users/Neamar/repos","events_url":"https://api.github.com/users/Neamar/events{/privacy}","received_events_url":"https://api.github.com/users/Neamar/received_events","type":"User","site_admin":false},"body":"Shouldn't you throw an error?","created_at":"2014-06-18T18:28:51Z","updated_at":"2014-06-18T18:28:51Z","html_url":"https://github.com/AnyFetch/gdrive.provider.anyfetch.com/pull/13#discussion_r13931774","pull_request_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls/comments/13931774"},"html":{"href":"https://github.com/AnyFetch/gdrive.provider.anyfetch.com/pull/13#discussion_r13931774"},"pull_request":{"href":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls/13","id":17244078,"html_url":"https://github.com/AnyFetch/gdrive.provider.anyfetch.com/pull/13","diff_url":"https://github.com/AnyFetch/gdrive.provider.anyfetch.com/pull/13.diff","patch_url":"https://github.com/AnyFetch/gdrive.provider.anyfetch.com/pull/13.patch","issue_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/issues/13","number":13,"state":"open","title":"Other jobs","user":{"login":"rricard","id":246520,"avatar_url":"https://avatars.githubusercontent.com/u/246520?","gravatar_id":"b46620604f6b72c29c26e3cafabb3ca8","url":"https://api.github.com/users/rricard","html_url":"https://github.com/rricard","followers_url":"https://api.github.com/users/rricard/followers","following_url":"https://api.github.com/users/rricard/following{/other_user}","gists_url":"https://api.github.com/users/rricard/gists{/gist_id}","starred_url":"https://api.github.com/users/rricard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rricard/subscriptions","organizations_url":"https://api.github.com/users/rricard/orgs","repos_url":"https://api.github.com/users/rricard/repos","events_url":"https://api.github.com/users/rricard/events{/privacy}","received_events_url":"https://api.github.com/users/rricard/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-17T15:54:44Z","updated_at":"2014-06-18T18:28:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"604a69853aac3c86a5728acc33461e3e2835b5cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls/13/commits","review_comments_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls/13/comments","review_comment_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls/comments/{number}","comments_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/issues/13/comments","statuses_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/statuses/4e8f752bfae68df4ccb4b3fb5cd316999d5fb158","head":{"label":"AnyFetch:other-jobs","ref":"other-jobs","sha":"4e8f752bfae68df4ccb4b3fb5cd316999d5fb158","user":{"login":"AnyFetch","id":3952848,"avatar_url":"https://avatars.githubusercontent.com/u/3952848?","gravatar_id":"38a329820c5eab64decbf95bf7f3ebcb","url":"https://api.github.com/users/AnyFetch","html_url":"https://github.com/AnyFetch","followers_url":"https://api.github.com/users/AnyFetch/followers","following_url":"https://api.github.com/users/AnyFetch/following{/other_user}","gists_url":"https://api.github.com/users/AnyFetch/gists{/gist_id}","starred_url":"https://api.github.com/users/AnyFetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnyFetch/subscriptions","organizations_url":"https://api.github.com/users/AnyFetch/orgs","repos_url":"https://api.github.com/users/AnyFetch/repos","events_url":"https://api.github.com/users/AnyFetch/events{/privacy}","received_events_url":"https://api.github.com/users/AnyFetch/received_events","type":"Organization","site_admin":false},"repo":{"id":13616884,"name":"gdrive.provider.anyfetch.com","full_name":"AnyFetch/gdrive.provider.anyfetch.com","owner":{"login":"AnyFetch","id":3952848,"avatar_url":"https://avatars.githubusercontent.com/u/3952848?","gravatar_id":"38a329820c5eab64decbf95bf7f3ebcb","url":"https://api.github.com/users/AnyFetch","html_url":"https://github.com/AnyFetch","followers_url":"https://api.github.com/users/AnyFetch/followers","following_url":"https://api.github.com/users/AnyFetch/following{/other_user}","gists_url":"https://api.github.com/users/AnyFetch/gists{/gist_id}","starred_url":"https://api.github.com/users/AnyFetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnyFetch/subscriptions","organizations_url":"https://api.github.com/users/AnyFetch/orgs","repos_url":"https://api.github.com/users/AnyFetch/repos","events_url":"https://api.github.com/users/AnyFetch/events{/privacy}","received_events_url":"https://api.github.com/users/AnyFetch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnyFetch/gdrive.provider.anyfetch.com","description":"anyFetch + Google Drive","fork":false,"url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com","forks_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/forks","keys_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/teams","hooks_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/hooks","issue_events_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/issues/events{/number}","events_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/events","assignees_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/assignees{/user}","branches_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/branches{/branch}","tags_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/tags","blobs_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/statuses/{sha}","languages_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/languages","stargazers_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/stargazers","contributors_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/contributors","subscribers_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/subscribers","subscription_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/subscription","commits_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/issues/comments/{number}","contents_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/contents/{+path}","compare_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/merges","archive_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/downloads","issues_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/issues{/number}","pulls_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls{/number}","milestones_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/milestones{/number}","notifications_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/labels{/name}","releases_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/releases{/id}","created_at":"2013-10-16T11:05:56Z","updated_at":"2014-06-18T17:18:39Z","pushed_at":"2014-06-18T17:18:39Z","git_url":"git://github.com/AnyFetch/gdrive.provider.anyfetch.com.git","ssh_url":"git@github.com:AnyFetch/gdrive.provider.anyfetch.com.git","clone_url":"https://github.com/AnyFetch/gdrive.provider.anyfetch.com.git","svn_url":"https://github.com/AnyFetch/gdrive.provider.anyfetch.com","homepage":"http://google-drive.provider.anyfetch.com","size":1996,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"AnyFetch:flip-table","ref":"flip-table","sha":"86f9e37734d3d805c20c1c655c16711c30a7ed7e","user":{"login":"AnyFetch","id":3952848,"avatar_url":"https://avatars.githubusercontent.com/u/3952848?","gravatar_id":"38a329820c5eab64decbf95bf7f3ebcb","url":"https://api.github.com/users/AnyFetch","html_url":"https://github.com/AnyFetch","followers_url":"https://api.github.com/users/AnyFetch/followers","following_url":"https://api.github.com/users/AnyFetch/following{/other_user}","gists_url":"https://api.github.com/users/AnyFetch/gists{/gist_id}","starred_url":"https://api.github.com/users/AnyFetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnyFetch/subscriptions","organizations_url":"https://api.github.com/users/AnyFetch/orgs","repos_url":"https://api.github.com/users/AnyFetch/repos","events_url":"https://api.github.com/users/AnyFetch/events{/privacy}","received_events_url":"https://api.github.com/users/AnyFetch/received_events","type":"Organization","site_admin":false},"repo":{"id":13616884,"name":"gdrive.provider.anyfetch.com","full_name":"AnyFetch/gdrive.provider.anyfetch.com","owner":{"login":"AnyFetch","id":3952848,"avatar_url":"https://avatars.githubusercontent.com/u/3952848?","gravatar_id":"38a329820c5eab64decbf95bf7f3ebcb","url":"https://api.github.com/users/AnyFetch","html_url":"https://github.com/AnyFetch","followers_url":"https://api.github.com/users/AnyFetch/followers","following_url":"https://api.github.com/users/AnyFetch/following{/other_user}","gists_url":"https://api.github.com/users/AnyFetch/gists{/gist_id}","starred_url":"https://api.github.com/users/AnyFetch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnyFetch/subscriptions","organizations_url":"https://api.github.com/users/AnyFetch/orgs","repos_url":"https://api.github.com/users/AnyFetch/repos","events_url":"https://api.github.com/users/AnyFetch/events{/privacy}","received_events_url":"https://api.github.com/users/AnyFetch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnyFetch/gdrive.provider.anyfetch.com","description":"anyFetch + Google Drive","fork":false,"url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com","forks_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/forks","keys_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/teams","hooks_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/hooks","issue_events_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/issues/events{/number}","events_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/events","assignees_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/assignees{/user}","branches_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/branches{/branch}","tags_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/tags","blobs_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/statuses/{sha}","languages_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/languages","stargazers_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/stargazers","contributors_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/contributors","subscribers_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/subscribers","subscription_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/subscription","commits_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/issues/comments/{number}","contents_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/contents/{+path}","compare_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/merges","archive_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/downloads","issues_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/issues{/number}","pulls_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls{/number}","milestones_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/milestones{/number}","notifications_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/labels{/name}","releases_url":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/releases{/id}","created_at":"2013-10-16T11:05:56Z","updated_at":"2014-06-18T17:18:39Z","pushed_at":"2014-06-18T17:18:39Z","git_url":"git://github.com/AnyFetch/gdrive.provider.anyfetch.com.git","ssh_url":"git@github.com:AnyFetch/gdrive.provider.anyfetch.com.git","clone_url":"https://github.com/AnyFetch/gdrive.provider.anyfetch.com.git","svn_url":"https://github.com/AnyFetch/gdrive.provider.anyfetch.com","homepage":"http://google-drive.provider.anyfetch.com","size":1996,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls/13"},"html":{"href":"https://github.com/AnyFetch/gdrive.provider.anyfetch.com/pull/13"},"issue":{"href":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/issues/13"},"comments":{"href":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/AnyFetch/gdrive.provider.anyfetch.com/statuses/4e8f752bfae68df4ccb4b3fb5cd316999d5fb158"}}}}