GitHub PullRequestReviewCommentEvent at 2014-01-06 18:52:32
Repository: mapstruct
Actor: gunnarmorling
Payload: {"comment":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/8673260","id":8673260,"diff_hunk":"@@ -0,0 +1,97 @@\n+/**\n+ *  Copyright 2012-2013 Gunnar Morling (http://www.gunnarmorling.de/)\n+ *  and/or other contributors as indicated by the @authors tag. See the\n+ *  copyright.txt file in the distribution for a full listing of all\n+ *  contributors.\n+ *\n+ *  Licensed under the Apache License, Version 2.0 (the \"License\");\n+ *  you may not use this file except in compliance with the License.\n+ *  You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ *  Unless required by applicable law or agreed to in writing, software\n+ *  distributed under the License is distributed on an \"AS IS\" BASIS,\n+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ *  See the License for the specific language governing permissions and\n+ *  limitations under the License.\n+ */\n+package org.mapstruct.ap.test.inheritance.complex;\n+\n+import static org.fest.assertions.Assertions.assertThat;\n+\n+import org.mapstruct.ap.testutil.IssueKey;\n+import org.mapstruct.ap.testutil.MapperTestBase;\n+import org.mapstruct.ap.testutil.WithClasses;\n+import org.testng.annotations.Test;\n+\n+/**\n+ * Test for propagation of attributes inherited from super types.\n+ *\n+ * @author Andreas Gudian\n+ */\n+@WithClasses( { Reference.class, SourceBase.class, SourceBaseReferenceMapper.class, SourceComposite.class,\n+    SourceCompositeTargetCompositeMapper.class, SourceExt.class, SourceExt2.class,\n+    StandaloneSourceCompositeTargetCompositeMapper.class, TargetComposite.class } )\n+public class ComplexInheritanceTest extends MapperTestBase {","path":"processor/src/test/java/org/mapstruct/ap/test/inheritance/complex/ComplexInheritanceTest.java","position":36,"original_position":36,"commit_id":"612b7b2226a95cb0ae9580129334023e3cb219b4","original_commit_id":"612b7b2226a95cb0ae9580129334023e3cb219b4","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://gravatar.com/avatar/8e25c0ca4bf25113bd9c0ccc5d118164?d=https%3A%2F%2Fidenticons.github.com%2F6760b957686819cb6636c2319fb4f872.png&r=x","gravatar_id":"8e25c0ca4bf25113bd9c0ccc5d118164","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"body":"Is there a test for making sure that a more specific mapping method actually is applied? Also a test asserting the error in case no unique method can be identified for mapping a specific property would be nice.","created_at":"2014-01-06T18:52:32Z","updated_at":"2014-01-06T18:52:32Z","html_url":"https://github.com/mapstruct/mapstruct/pull/67#discussion_r8673260","pull_request_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/8673260"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/67#discussion_r8673260"},"pull_request":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/67"}}}}