GitHub PullRequestReviewCommentEvent at 2014-10-09 19:15:37
Repository: OpenRA
Actor: pchote
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/18667426","id":18667426,"diff_hunk":"@@ -40,22 +40,30 @@ public Sprite(Sheet sheet, Rectangle bounds, float2 offset, TextureChannel chann\n \n \t\t\tthis.fractionalOffset = offset / this.size;\n \n-\t\t\tvar left = (float)(bounds.Left) / sheet.Size.Width;\n-\t\t\tvar top = (float)(bounds.Top) / sheet.Size.Height;\n-\t\t\tvar right = (float)(bounds.Right) / sheet.Size.Width;\n-\t\t\tvar bottom = (float)(bounds.Bottom) / sheet.Size.Height;\n-\t\t\ttextureCoords = new float2[]\n-\t\t\t{\n-\t\t\t\tnew float2(left, top),\n-\t\t\t\tnew float2(right, top),\n-\t\t\t\tnew float2(left, bottom),\n-\t\t\t\tnew float2(right, bottom),\n-\t\t\t};\n+\t\t\tleft = (float)(bounds.Left) / sheet.Size.Width;\n+\t\t\ttop = (float)(bounds.Top) / sheet.Size.Height;\n+\t\t\tright = (float)(bounds.Right) / sheet.Size.Width;\n+\t\t\tbottom = (float)(bounds.Bottom) / sheet.Size.Height;\n \t\t}\n \n-\t\tpublic float2 FastMapTextureCoords(int k)\n+\t\tpublic float2 TopLeftTextureCoords","path":"OpenRA.Game/Graphics/Sprite.cs","position":31,"original_position":31,"commit_id":"31a096dcf18bdab047cb59f0e3a4c96bab59cb41","original_commit_id":"31a096dcf18bdab047cb59f0e3a4c96bab59cb41","user":{"login":"pchote","id":167819,"avatar_url":"https://avatars.githubusercontent.com/u/167819?v=2","gravatar_id":"","url":"https://api.github.com/users/pchote","html_url":"https://github.com/pchote","followers_url":"https://api.github.com/users/pchote/followers","following_url":"https://api.github.com/users/pchote/following{/other_user}","gists_url":"https://api.github.com/users/pchote/gists{/gist_id}","starred_url":"https://api.github.com/users/pchote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchote/subscriptions","organizations_url":"https://api.github.com/users/pchote/orgs","repos_url":"https://api.github.com/users/pchote/repos","events_url":"https://api.github.com/users/pchote/events{/privacy}","received_events_url":"https://api.github.com/users/pchote/received_events","type":"User","site_admin":false},"body":"These were originally cached as a performance optimization.  Are you sure that the memory savings aren't outweighed by the additional pressure from creating and destroying hundreds more float2's per frame?","created_at":"2014-10-09T19:15:37Z","updated_at":"2014-10-09T19:15:37Z","html_url":"https://github.com/OpenRA/OpenRA/pull/6698#discussion_r18667426","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6698","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/18667426"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/6698#discussion_r18667426"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6698"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6698","id":22298410,"html_url":"https://github.com/OpenRA/OpenRA/pull/6698","diff_url":"https://github.com/OpenRA/OpenRA/pull/6698.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/6698.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/6698","number":6698,"state":"open","locked":false,"title":"Small memory savings","user":{"login":"RoosterDragon","id":3399086,"avatar_url":"https://avatars.githubusercontent.com/u/3399086?v=2","gravatar_id":"","url":"https://api.github.com/users/RoosterDragon","html_url":"https://github.com/RoosterDragon","followers_url":"https://api.github.com/users/RoosterDragon/followers","following_url":"https://api.github.com/users/RoosterDragon/following{/other_user}","gists_url":"https://api.github.com/users/RoosterDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/RoosterDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoosterDragon/subscriptions","organizations_url":"https://api.github.com/users/RoosterDragon/orgs","repos_url":"https://api.github.com/users/RoosterDragon/repos","events_url":"https://api.github.com/users/RoosterDragon/events{/privacy}","received_events_url":"https://api.github.com/users/RoosterDragon/received_events","type":"User","site_admin":false},"body":"Two small changes which save some memory:\r\n\r\n* Indexes into tile arrays are now stored as bytes instead of ints, since the only need to represent very small numbers. The CustomTerrain field in the Map class means this gains us about 5MiB back for medium sized maps.\r\n* We don't store pre-calculated textures coordinate pairs in Sprite, preferring to store pre-calculated values for each corner and return pairs on demand. This allows us to store texture co-ords for sprites using only 4 floats instead of 8. We also remove the array as well. This saved about 5MiB in my tests.","created_at":"2014-10-06T17:00:42Z","updated_at":"2014-10-09T19:15:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7026c820d06758d12a8a389fe4b8921c2fc068f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6698/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6698/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/6698/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/31a096dcf18bdab047cb59f0e3a4c96bab59cb41","head":{"label":"RoosterDragon:memory-savings","ref":"memory-savings","sha":"31a096dcf18bdab047cb59f0e3a4c96bab59cb41","user":{"login":"RoosterDragon","id":3399086,"avatar_url":"https://avatars.githubusercontent.com/u/3399086?v=2","gravatar_id":"","url":"https://api.github.com/users/RoosterDragon","html_url":"https://github.com/RoosterDragon","followers_url":"https://api.github.com/users/RoosterDragon/followers","following_url":"https://api.github.com/users/RoosterDragon/following{/other_user}","gists_url":"https://api.github.com/users/RoosterDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/RoosterDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoosterDragon/subscriptions","organizations_url":"https://api.github.com/users/RoosterDragon/orgs","repos_url":"https://api.github.com/users/RoosterDragon/repos","events_url":"https://api.github.com/users/RoosterDragon/events{/privacy}","received_events_url":"https://api.github.com/users/RoosterDragon/received_events","type":"User","site_admin":false},"repo":{"id":20080394,"name":"OpenRA","full_name":"RoosterDragon/OpenRA","owner":{"login":"RoosterDragon","id":3399086,"avatar_url":"https://avatars.githubusercontent.com/u/3399086?v=2","gravatar_id":"","url":"https://api.github.com/users/RoosterDragon","html_url":"https://github.com/RoosterDragon","followers_url":"https://api.github.com/users/RoosterDragon/followers","following_url":"https://api.github.com/users/RoosterDragon/following{/other_user}","gists_url":"https://api.github.com/users/RoosterDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/RoosterDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoosterDragon/subscriptions","organizations_url":"https://api.github.com/users/RoosterDragon/orgs","repos_url":"https://api.github.com/users/RoosterDragon/repos","events_url":"https://api.github.com/users/RoosterDragon/events{/privacy}","received_events_url":"https://api.github.com/users/RoosterDragon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RoosterDragon/OpenRA","description":"An open-source implementation of the Red Alert engine using .NET/mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":true,"url":"https://api.github.com/repos/RoosterDragon/OpenRA","forks_url":"https://api.github.com/repos/RoosterDragon/OpenRA/forks","keys_url":"https://api.github.com/repos/RoosterDragon/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RoosterDragon/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RoosterDragon/OpenRA/teams","hooks_url":"https://api.github.com/repos/RoosterDragon/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/RoosterDragon/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/RoosterDragon/OpenRA/events","assignees_url":"https://api.github.com/repos/RoosterDragon/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/RoosterDragon/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/RoosterDragon/OpenRA/tags","blobs_url":"https://api.github.com/repos/RoosterDragon/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RoosterDragon/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RoosterDragon/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/RoosterDragon/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RoosterDragon/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/RoosterDragon/OpenRA/languages","stargazers_url":"https://api.github.com/repos/RoosterDragon/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/RoosterDragon/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/RoosterDragon/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/RoosterDragon/OpenRA/subscription","commits_url":"https://api.github.com/repos/RoosterDragon/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/RoosterDragon/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/RoosterDragon/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/RoosterDragon/OpenRA/issues/comments/{number}","contents_url":"https://api.github.com/repos/RoosterDragon/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/RoosterDragon/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RoosterDragon/OpenRA/merges","archive_url":"https://api.github.com/repos/RoosterDragon/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RoosterDragon/OpenRA/downloads","issues_url":"https://api.github.com/repos/RoosterDragon/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/RoosterDragon/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/RoosterDragon/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/RoosterDragon/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RoosterDragon/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/RoosterDragon/OpenRA/releases{/id}","created_at":"2014-05-22T23:21:53Z","updated_at":"2014-06-25T18:22:20Z","pushed_at":"2014-10-09T19:04:01Z","git_url":"git://github.com/RoosterDragon/OpenRA.git","ssh_url":"git@github.com:RoosterDragon/OpenRA.git","clone_url":"https://github.com/RoosterDragon/OpenRA.git","svn_url":"https://github.com/RoosterDragon/OpenRA","homepage":"http://open-ra.org","size":72710,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"268c63f7df50be400a68a082d97db3da8fc34d04","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=2","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=2","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"An open-source implementation of the Command & Conquer: Red Alert engine using .NET/Mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments/{number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2014-10-09T16:43:15Z","pushed_at":"2014-10-09T16:02:48Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":175238,"stargazers_count":1392,"watchers_count":1392,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":461,"mirror_url":null,"open_issues_count":770,"forks":461,"open_issues":770,"watchers":1392,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6698"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/6698"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/6698"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/6698/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6698/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6698/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/31a096dcf18bdab047cb59f0e3a4c96bab59cb41"}}}}