GitHub PullRequestReviewCommentEvent at 2014-08-13 21:27:06
Repository: symfony
Actor: stof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/16207337","id":16207337,"diff_hunk":"@@ -11,7 +11,7 @@\n \n namespace Symfony\\Bundle\\WebProfilerBundle\\Tests\\Controller;\n \n-use Symfony\\Bundle\\FrameworkBundle\\Tests\\TestCase;\n+use Symfony\\Bundle\\WebProfilerBundle\\Tests\\TestCase;","path":"src/Symfony/Bundle/WebProfilerBundle/Tests/Controller/ProfilerControllerTest.php","position":5,"original_position":5,"commit_id":"635f897fb582fed58e037e4a004093200b521fba","original_commit_id":"635f897fb582fed58e037e4a004093200b521fba","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=2","gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"This would skip the tests in case TwigBundle is not available because of the code in ``Symfony\\Bundle\\WebProfilerBundle\\Tests\\TestCase`` while it was not the case previously. Is it expected ? If no, you should extend ``PHPUnit_Framework_TestCase`` directly","created_at":"2014-08-13T21:27:06Z","updated_at":"2014-08-13T21:27:06Z","html_url":"https://github.com/symfony/symfony/pull/11340#discussion_r16207337","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/11340","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/16207337"},"html":{"href":"https://github.com/symfony/symfony/pull/11340#discussion_r16207337"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11340"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/11340","id":18021171,"html_url":"https://github.com/symfony/symfony/pull/11340","diff_url":"https://github.com/symfony/symfony/pull/11340.diff","patch_url":"https://github.com/symfony/symfony/pull/11340.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/11340","number":11340,"state":"open","locked":false,"title":"[2.3] Add missing development dependencies","user":{"login":"romainneutron","id":137574,"avatar_url":"https://avatars.githubusercontent.com/u/137574?v=2","gravatar_id":"ce776a5e957c937a56c721b7d6701960","url":"https://api.github.com/users/romainneutron","html_url":"https://github.com/romainneutron","followers_url":"https://api.github.com/users/romainneutron/followers","following_url":"https://api.github.com/users/romainneutron/following{/other_user}","gists_url":"https://api.github.com/users/romainneutron/gists{/gist_id}","starred_url":"https://api.github.com/users/romainneutron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romainneutron/subscriptions","organizations_url":"https://api.github.com/users/romainneutron/orgs","repos_url":"https://api.github.com/users/romainneutron/repos","events_url":"https://api.github.com/users/romainneutron/events{/privacy}","received_events_url":"https://api.github.com/users/romainneutron/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | n/a\r\n| License       | MIT\r\n\r\nI've also added a run of the test suite in every component scope.","created_at":"2014-07-06T19:58:45Z","updated_at":"2014-08-13T21:27:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d95edb928b317c395f1ab377c8bd16f87a7a4b5b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/11340/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/11340/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/11340/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/635f897fb582fed58e037e4a004093200b521fba","head":{"label":"romainneutron:dev-dependencies","ref":"dev-dependencies","sha":"635f897fb582fed58e037e4a004093200b521fba","user":{"login":"romainneutron","id":137574,"avatar_url":"https://avatars.githubusercontent.com/u/137574?v=2","gravatar_id":"ce776a5e957c937a56c721b7d6701960","url":"https://api.github.com/users/romainneutron","html_url":"https://github.com/romainneutron","followers_url":"https://api.github.com/users/romainneutron/followers","following_url":"https://api.github.com/users/romainneutron/following{/other_user}","gists_url":"https://api.github.com/users/romainneutron/gists{/gist_id}","starred_url":"https://api.github.com/users/romainneutron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romainneutron/subscriptions","organizations_url":"https://api.github.com/users/romainneutron/orgs","repos_url":"https://api.github.com/users/romainneutron/repos","events_url":"https://api.github.com/users/romainneutron/events{/privacy}","received_events_url":"https://api.github.com/users/romainneutron/received_events","type":"User","site_admin":false},"repo":{"id":4369387,"name":"symfony","full_name":"romainneutron/symfony","owner":{"login":"romainneutron","id":137574,"avatar_url":"https://avatars.githubusercontent.com/u/137574?v=2","gravatar_id":"ce776a5e957c937a56c721b7d6701960","url":"https://api.github.com/users/romainneutron","html_url":"https://github.com/romainneutron","followers_url":"https://api.github.com/users/romainneutron/followers","following_url":"https://api.github.com/users/romainneutron/following{/other_user}","gists_url":"https://api.github.com/users/romainneutron/gists{/gist_id}","starred_url":"https://api.github.com/users/romainneutron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romainneutron/subscriptions","organizations_url":"https://api.github.com/users/romainneutron/orgs","repos_url":"https://api.github.com/users/romainneutron/repos","events_url":"https://api.github.com/users/romainneutron/events{/privacy}","received_events_url":"https://api.github.com/users/romainneutron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romainneutron/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/romainneutron/symfony","forks_url":"https://api.github.com/repos/romainneutron/symfony/forks","keys_url":"https://api.github.com/repos/romainneutron/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romainneutron/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romainneutron/symfony/teams","hooks_url":"https://api.github.com/repos/romainneutron/symfony/hooks","issue_events_url":"https://api.github.com/repos/romainneutron/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/romainneutron/symfony/events","assignees_url":"https://api.github.com/repos/romainneutron/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/romainneutron/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/romainneutron/symfony/tags","blobs_url":"https://api.github.com/repos/romainneutron/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romainneutron/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romainneutron/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/romainneutron/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romainneutron/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/romainneutron/symfony/languages","stargazers_url":"https://api.github.com/repos/romainneutron/symfony/stargazers","contributors_url":"https://api.github.com/repos/romainneutron/symfony/contributors","subscribers_url":"https://api.github.com/repos/romainneutron/symfony/subscribers","subscription_url":"https://api.github.com/repos/romainneutron/symfony/subscription","commits_url":"https://api.github.com/repos/romainneutron/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/romainneutron/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/romainneutron/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/romainneutron/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/romainneutron/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/romainneutron/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romainneutron/symfony/merges","archive_url":"https://api.github.com/repos/romainneutron/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romainneutron/symfony/downloads","issues_url":"https://api.github.com/repos/romainneutron/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/romainneutron/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/romainneutron/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/romainneutron/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romainneutron/symfony/labels{/name}","releases_url":"https://api.github.com/repos/romainneutron/symfony/releases{/id}","created_at":"2012-05-18T13:11:05Z","updated_at":"2014-06-17T20:02:24Z","pushed_at":"2014-07-25T07:46:58Z","git_url":"git://github.com/romainneutron/symfony.git","ssh_url":"git@github.com:romainneutron/symfony.git","clone_url":"https://github.com/romainneutron/symfony.git","svn_url":"https://github.com/romainneutron/symfony","homepage":"symfony.com","size":43018,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"ace5a29867c218cb0bc4dc379a7aa549e7e1aea5","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2014-08-13T17:05:08Z","pushed_at":"2014-08-13T19:40:24Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":166812,"stargazers_count":8751,"watchers_count":8751,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":3357,"mirror_url":null,"open_issues_count":857,"forks":3357,"open_issues":857,"watchers":8751,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11340"},"html":{"href":"https://github.com/symfony/symfony/pull/11340"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/11340"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/11340/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11340/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11340/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/635f897fb582fed58e037e4a004093200b521fba"}}}}