GitHub PullRequestReviewCommentEvent at 2014-04-15 12:43:02
Repository: mf-geoadmin3
Actor: oterral
Payload: {"comment":{"url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/comments/11631766","id":11631766,"diff_hunk":"@@ -236,10 +291,64 @@\n                     },\n                     replace: function(url, searchText) {\n                       var queryText = '&searchText=' + searchText;\n+                      var lang = '&lang=' + $translate.uses();\n+                      url = options.applyTopicToUrl(url,\n+                                                   currentTopic);\n+                      url += queryText + lang;\n+                      return url;\n+                    },\n+                    filter: function(response) {\n+                      var results = response.results;\n+                      return $.map(results, function(val) {\n+                        val.inputVal = val.attrs.label\n+                            .replace('<b>', '').replace('</b>', '');\n+                        return val;\n+                      });\n+                    }\n+                  }\n+                },\n+                {\n+                  header: featureSearchHeaderTemplate,\n+                  name: 'featuresearch',\n+                  timeout: 20,\n+                  valueKey: 'inputVal',\n+                  limit: 30,\n+                  template: function(context) {\n+                    var attrs = context.attrs;\n+                    var label = getLocationLabel(attrs);\n+                    var template = '<div class=\"tt-search\" ' +\n+                        'ng-mouseover=\"addPreviewFeature(\\'' +\n+                        attrs.layer + '##' + attrs.feature_id + '\\')\"' +\n+                        'ng-mouseout=\"removePreviewFeature()\"' +\n+                        'ng-click=\"selectFeature(\\'' +\n+                        attrs.layer + '##' + attrs.feature_id + '\\')\" >' +\n+                        label + '</div>';\n+                    return template;\n+                  },\n+                  remote: {\n+                    url: gaUrlUtils.append(options.searchUrl,\n+                        'type=featuresearch'),\n+                    beforeSend: function(jqXhr, settings) {\n+                      scope.$apply(function() {\n+                        scope.layers = map.getLayers().getArray();\n+                      });\n+                      if (!gaGetCoordinate(\n+                          map.getView().getProjection().getExtent(),\n+                          scope.query) &&\n+                              scope.searchableLayers.length) {\n+                        highlightedFeatures = {};\n+                        return true;\n+                      } else {\n+                        // Do not perform a query\n+                        return false;\n+                      }\n+                    },\n+                    replace: function(url, searchText) {\n+                      var queryText = '&searchText=' + searchText;\n                       var bbox = '&bbox=' + getBBoxParameters(map);\n                       var lang = '&lang=' + $translate.uses();\n                       var searchableLayers = '&features=' +\n-                          scope.searchableLayers.join(',');\n+                           scope.searchableLayers.join(',');","path":"src/components/search/SearchDirective.js","position":187,"original_position":190,"commit_id":"ce87ad549f2d35c031232a89f52629c47595f739","original_commit_id":"34dd9c4173ffaf2e8fbbf178e3fbd5cd1f313454","user":{"login":"oterral","id":621420,"avatar_url":"https://avatars.githubusercontent.com/u/621420?","gravatar_id":"f42230151d95e440df21166893d44aaa","url":"https://api.github.com/users/oterral","html_url":"https://github.com/oterral","followers_url":"https://api.github.com/users/oterral/followers","following_url":"https://api.github.com/users/oterral/following{/other_user}","gists_url":"https://api.github.com/users/oterral/gists{/gist_id}","starred_url":"https://api.github.com/users/oterral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oterral/subscriptions","organizations_url":"https://api.github.com/users/oterral/orgs","repos_url":"https://api.github.com/users/oterral/repos","events_url":"https://api.github.com/users/oterral/events{/privacy}","received_events_url":"https://api.github.com/users/oterral/received_events","type":"User","site_admin":false},"body":"hmm no there was 4 : 3 letters (var) + one space","created_at":"2014-04-15T12:43:02Z","updated_at":"2014-04-15T12:43:02Z","html_url":"https://github.com/geoadmin/mf-geoadmin3/pull/1345#discussion_r11631766","pull_request_url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/1345","_links":{"self":{"href":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/comments/11631766"},"html":{"href":"https://github.com/geoadmin/mf-geoadmin3/pull/1345#discussion_r11631766"},"pull_request":{"href":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/1345"}}}}