GitHub PullRequestEvent at 2014-09-25 10:34:56
Repository: jStyleParser
Actor: chetankothari
Payload: {"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/radkovo/jStyleParser/pulls/4","id":21773990,"html_url":"https://github.com/radkovo/jStyleParser/pull/4","diff_url":"https://github.com/radkovo/jStyleParser/pull/4.diff","patch_url":"https://github.com/radkovo/jStyleParser/pull/4.patch","issue_url":"https://api.github.com/repos/radkovo/jStyleParser/issues/4","number":4,"state":"open","locked":false,"title":"Fix/line height","user":{"login":"chetankothari","id":2863191,"avatar_url":"https://avatars.githubusercontent.com/u/2863191?v=2","gravatar_id":"","url":"https://api.github.com/users/chetankothari","html_url":"https://github.com/chetankothari","followers_url":"https://api.github.com/users/chetankothari/followers","following_url":"https://api.github.com/users/chetankothari/following{/other_user}","gists_url":"https://api.github.com/users/chetankothari/gists{/gist_id}","starred_url":"https://api.github.com/users/chetankothari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chetankothari/subscriptions","organizations_url":"https://api.github.com/users/chetankothari/orgs","repos_url":"https://api.github.com/users/chetankothari/repos","events_url":"https://api.github.com/users/chetankothari/events{/privacy}","received_events_url":"https://api.github.com/users/chetankothari/received_events","type":"User","site_admin":false},"body":"`NodeData's` `push()` method when called from `DirectAnalyzer's` `getElementStyle()` method was mutating the original `Term` values from the `StyleSheet` which was passed to the `DirectAnalyzer` while constructing it. \r\nTo avoid this, Term now implements `Cloneable` interface, so wherever we want to mutate the term, we can get a clone of it and then mutate it. This will keep the original values intact. \r\n\r\nThis problem was being initially encountered for the following test case :- \r\n\r\n    <p style=\"font: 400 italic 40px/2 serif;\">test</p>\r\n\r\nwhere the operator of the `line-height` was being set to `null`, the second time when we were calling the `getElementStyle()` the operator `SLASH(/)` was missing, which was required for it to match a variant in `processFont()` method in `DeclarationTransformer`'s. `processFont()` was called from `parseDeclaration()` method in the same class. Since the `operator` was missing, the `font` property would have been invalid.","created_at":"2014-09-25T10:34:56Z","updated_at":"2014-09-25T10:34:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/radkovo/jStyleParser/pulls/4/commits","review_comments_url":"https://api.github.com/repos/radkovo/jStyleParser/pulls/4/comments","review_comment_url":"https://api.github.com/repos/radkovo/jStyleParser/pulls/comments/{number}","comments_url":"https://api.github.com/repos/radkovo/jStyleParser/issues/4/comments","statuses_url":"https://api.github.com/repos/radkovo/jStyleParser/statuses/e45264680a3e3bb560af899a87972141a6e8d1b7","head":{"label":"UprootLabs:fix/line-height","ref":"fix/line-height","sha":"e45264680a3e3bb560af899a87972141a6e8d1b7","user":{"login":"UprootLabs","id":4996734,"avatar_url":"https://avatars.githubusercontent.com/u/4996734?v=2","gravatar_id":"","url":"https://api.github.com/users/UprootLabs","html_url":"https://github.com/UprootLabs","followers_url":"https://api.github.com/users/UprootLabs/followers","following_url":"https://api.github.com/users/UprootLabs/following{/other_user}","gists_url":"https://api.github.com/users/UprootLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/UprootLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UprootLabs/subscriptions","organizations_url":"https://api.github.com/users/UprootLabs/orgs","repos_url":"https://api.github.com/users/UprootLabs/repos","events_url":"https://api.github.com/users/UprootLabs/events{/privacy}","received_events_url":"https://api.github.com/users/UprootLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":24147322,"name":"jStyleParser","full_name":"UprootLabs/jStyleParser","owner":{"login":"UprootLabs","id":4996734,"avatar_url":"https://avatars.githubusercontent.com/u/4996734?v=2","gravatar_id":"","url":"https://api.github.com/users/UprootLabs","html_url":"https://github.com/UprootLabs","followers_url":"https://api.github.com/users/UprootLabs/followers","following_url":"https://api.github.com/users/UprootLabs/following{/other_user}","gists_url":"https://api.github.com/users/UprootLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/UprootLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UprootLabs/subscriptions","organizations_url":"https://api.github.com/users/UprootLabs/orgs","repos_url":"https://api.github.com/users/UprootLabs/repos","events_url":"https://api.github.com/users/UprootLabs/events{/privacy}","received_events_url":"https://api.github.com/users/UprootLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UprootLabs/jStyleParser","description":"jStyleParser is a CSS parser written in Java. It has its own application interface that is designed to allow an efficient CSS processing in Java and mapping the values to the Java data types. It parses CSS 2.1 style sheets into structures that can be efficiently assigned to DOM elements. It is intended be the primary CSS parser for the CSSBox library. While handling errors, it is user agent conforming according to the CSS specification.","fork":true,"url":"https://api.github.com/repos/UprootLabs/jStyleParser","forks_url":"https://api.github.com/repos/UprootLabs/jStyleParser/forks","keys_url":"https://api.github.com/repos/UprootLabs/jStyleParser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UprootLabs/jStyleParser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UprootLabs/jStyleParser/teams","hooks_url":"https://api.github.com/repos/UprootLabs/jStyleParser/hooks","issue_events_url":"https://api.github.com/repos/UprootLabs/jStyleParser/issues/events{/number}","events_url":"https://api.github.com/repos/UprootLabs/jStyleParser/events","assignees_url":"https://api.github.com/repos/UprootLabs/jStyleParser/assignees{/user}","branches_url":"https://api.github.com/repos/UprootLabs/jStyleParser/branches{/branch}","tags_url":"https://api.github.com/repos/UprootLabs/jStyleParser/tags","blobs_url":"https://api.github.com/repos/UprootLabs/jStyleParser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UprootLabs/jStyleParser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UprootLabs/jStyleParser/git/refs{/sha}","trees_url":"https://api.github.com/repos/UprootLabs/jStyleParser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UprootLabs/jStyleParser/statuses/{sha}","languages_url":"https://api.github.com/repos/UprootLabs/jStyleParser/languages","stargazers_url":"https://api.github.com/repos/UprootLabs/jStyleParser/stargazers","contributors_url":"https://api.github.com/repos/UprootLabs/jStyleParser/contributors","subscribers_url":"https://api.github.com/repos/UprootLabs/jStyleParser/subscribers","subscription_url":"https://api.github.com/repos/UprootLabs/jStyleParser/subscription","commits_url":"https://api.github.com/repos/UprootLabs/jStyleParser/commits{/sha}","git_commits_url":"https://api.github.com/repos/UprootLabs/jStyleParser/git/commits{/sha}","comments_url":"https://api.github.com/repos/UprootLabs/jStyleParser/comments{/number}","issue_comment_url":"https://api.github.com/repos/UprootLabs/jStyleParser/issues/comments/{number}","contents_url":"https://api.github.com/repos/UprootLabs/jStyleParser/contents/{+path}","compare_url":"https://api.github.com/repos/UprootLabs/jStyleParser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UprootLabs/jStyleParser/merges","archive_url":"https://api.github.com/repos/UprootLabs/jStyleParser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UprootLabs/jStyleParser/downloads","issues_url":"https://api.github.com/repos/UprootLabs/jStyleParser/issues{/number}","pulls_url":"https://api.github.com/repos/UprootLabs/jStyleParser/pulls{/number}","milestones_url":"https://api.github.com/repos/UprootLabs/jStyleParser/milestones{/number}","notifications_url":"https://api.github.com/repos/UprootLabs/jStyleParser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UprootLabs/jStyleParser/labels{/name}","releases_url":"https://api.github.com/repos/UprootLabs/jStyleParser/releases{/id}","created_at":"2014-09-17T14:10:31Z","updated_at":"2014-09-18T16:29:23Z","pushed_at":"2014-09-25T10:30:52Z","git_url":"git://github.com/UprootLabs/jStyleParser.git","ssh_url":"git@github.com:UprootLabs/jStyleParser.git","clone_url":"https://github.com/UprootLabs/jStyleParser.git","svn_url":"https://github.com/UprootLabs/jStyleParser","homepage":"http://cssbox.sourceforge.net/jstyleparser/","size":5083,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"radkovo:master","ref":"master","sha":"c55bc6f54bd41c572712aeb11f055837e89a2a78","user":{"login":"radkovo","id":550349,"avatar_url":"https://avatars.githubusercontent.com/u/550349?v=2","gravatar_id":"","url":"https://api.github.com/users/radkovo","html_url":"https://github.com/radkovo","followers_url":"https://api.github.com/users/radkovo/followers","following_url":"https://api.github.com/users/radkovo/following{/other_user}","gists_url":"https://api.github.com/users/radkovo/gists{/gist_id}","starred_url":"https://api.github.com/users/radkovo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radkovo/subscriptions","organizations_url":"https://api.github.com/users/radkovo/orgs","repos_url":"https://api.github.com/users/radkovo/repos","events_url":"https://api.github.com/users/radkovo/events{/privacy}","received_events_url":"https://api.github.com/users/radkovo/received_events","type":"User","site_admin":false},"repo":{"id":15593915,"name":"jStyleParser","full_name":"radkovo/jStyleParser","owner":{"login":"radkovo","id":550349,"avatar_url":"https://avatars.githubusercontent.com/u/550349?v=2","gravatar_id":"","url":"https://api.github.com/users/radkovo","html_url":"https://github.com/radkovo","followers_url":"https://api.github.com/users/radkovo/followers","following_url":"https://api.github.com/users/radkovo/following{/other_user}","gists_url":"https://api.github.com/users/radkovo/gists{/gist_id}","starred_url":"https://api.github.com/users/radkovo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radkovo/subscriptions","organizations_url":"https://api.github.com/users/radkovo/orgs","repos_url":"https://api.github.com/users/radkovo/repos","events_url":"https://api.github.com/users/radkovo/events{/privacy}","received_events_url":"https://api.github.com/users/radkovo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radkovo/jStyleParser","description":"jStyleParser is a CSS parser written in Java. It has its own application interface that is designed to allow an efficient CSS processing in Java and mapping the values to the Java data types. It parses CSS 2.1 style sheets into structures that can be efficiently assigned to DOM elements. It is intended be the primary CSS parser for the CSSBox library. While handling errors, it is user agent conforming according to the CSS specification.","fork":false,"url":"https://api.github.com/repos/radkovo/jStyleParser","forks_url":"https://api.github.com/repos/radkovo/jStyleParser/forks","keys_url":"https://api.github.com/repos/radkovo/jStyleParser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radkovo/jStyleParser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radkovo/jStyleParser/teams","hooks_url":"https://api.github.com/repos/radkovo/jStyleParser/hooks","issue_events_url":"https://api.github.com/repos/radkovo/jStyleParser/issues/events{/number}","events_url":"https://api.github.com/repos/radkovo/jStyleParser/events","assignees_url":"https://api.github.com/repos/radkovo/jStyleParser/assignees{/user}","branches_url":"https://api.github.com/repos/radkovo/jStyleParser/branches{/branch}","tags_url":"https://api.github.com/repos/radkovo/jStyleParser/tags","blobs_url":"https://api.github.com/repos/radkovo/jStyleParser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radkovo/jStyleParser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radkovo/jStyleParser/git/refs{/sha}","trees_url":"https://api.github.com/repos/radkovo/jStyleParser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radkovo/jStyleParser/statuses/{sha}","languages_url":"https://api.github.com/repos/radkovo/jStyleParser/languages","stargazers_url":"https://api.github.com/repos/radkovo/jStyleParser/stargazers","contributors_url":"https://api.github.com/repos/radkovo/jStyleParser/contributors","subscribers_url":"https://api.github.com/repos/radkovo/jStyleParser/subscribers","subscription_url":"https://api.github.com/repos/radkovo/jStyleParser/subscription","commits_url":"https://api.github.com/repos/radkovo/jStyleParser/commits{/sha}","git_commits_url":"https://api.github.com/repos/radkovo/jStyleParser/git/commits{/sha}","comments_url":"https://api.github.com/repos/radkovo/jStyleParser/comments{/number}","issue_comment_url":"https://api.github.com/repos/radkovo/jStyleParser/issues/comments/{number}","contents_url":"https://api.github.com/repos/radkovo/jStyleParser/contents/{+path}","compare_url":"https://api.github.com/repos/radkovo/jStyleParser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radkovo/jStyleParser/merges","archive_url":"https://api.github.com/repos/radkovo/jStyleParser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radkovo/jStyleParser/downloads","issues_url":"https://api.github.com/repos/radkovo/jStyleParser/issues{/number}","pulls_url":"https://api.github.com/repos/radkovo/jStyleParser/pulls{/number}","milestones_url":"https://api.github.com/repos/radkovo/jStyleParser/milestones{/number}","notifications_url":"https://api.github.com/repos/radkovo/jStyleParser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radkovo/jStyleParser/labels{/name}","releases_url":"https://api.github.com/repos/radkovo/jStyleParser/releases{/id}","created_at":"2014-01-02T21:12:24Z","updated_at":"2014-09-09T09:46:19Z","pushed_at":"2014-08-28T11:45:08Z","git_url":"git://github.com/radkovo/jStyleParser.git","ssh_url":"git@github.com:radkovo/jStyleParser.git","clone_url":"https://github.com/radkovo/jStyleParser.git","svn_url":"https://github.com/radkovo/jStyleParser","homepage":"http://cssbox.sourceforge.net/jstyleparser/","size":5083,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radkovo/jStyleParser/pulls/4"},"html":{"href":"https://github.com/radkovo/jStyleParser/pull/4"},"issue":{"href":"https://api.github.com/repos/radkovo/jStyleParser/issues/4"},"comments":{"href":"https://api.github.com/repos/radkovo/jStyleParser/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/radkovo/jStyleParser/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/radkovo/jStyleParser/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/radkovo/jStyleParser/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/radkovo/jStyleParser/statuses/e45264680a3e3bb560af899a87972141a6e8d1b7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":23,"deletions":6,"changed_files":4}}