GitHub PullRequestReviewCommentEvent at 2014-07-04 07:00:07
Repository: whitehall
Actor: vinayvinay
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/whitehall/pulls/comments/14549020","id":14549020,"diff_hunk":"@@ -0,0 +1,23 @@\n+desc \"Generates and emails CSV reports of all public documents containing broken links.\"\n+task :generate_broken_link_reports, [:reports_dir, :email_address] => [:environment] do |_, args|\n+  reports_dir     = args[:reports_dir]\n+  email_address   = args[:email_address]\n+  report_zip_name = 'broken_link_reports.zip'","path":"lib/tasks/broken_link_reporting.rake","position":5,"original_position":5,"commit_id":"9324f19b9c0dfa4349af9a439734e3a25c1b07de","original_commit_id":"9324f19b9c0dfa4349af9a439734e3a25c1b07de","user":{"login":"vinayvinay","id":230074,"avatar_url":"https://avatars.githubusercontent.com/u/230074?","gravatar_id":"3178e805eaaa2705c941a4d5f1a03e91","url":"https://api.github.com/users/vinayvinay","html_url":"https://github.com/vinayvinay","followers_url":"https://api.github.com/users/vinayvinay/followers","following_url":"https://api.github.com/users/vinayvinay/following{/other_user}","gists_url":"https://api.github.com/users/vinayvinay/gists{/gist_id}","starred_url":"https://api.github.com/users/vinayvinay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinayvinay/subscriptions","organizations_url":"https://api.github.com/users/vinayvinay/orgs","repos_url":"https://api.github.com/users/vinayvinay/repos","events_url":"https://api.github.com/users/vinayvinay/events{/privacy}","received_events_url":"https://api.github.com/users/vinayvinay/received_events","type":"User","site_admin":false},"body":"all looks good ! i've also tested this against a small subset of documents, works well.\r\njust a small suggestion: i'm not sure how frequently we run this checker, but if we add a timestamp to the report zip name, it'll be useful for someone downloading and unzipping these reports.","created_at":"2014-07-04T07:00:07Z","updated_at":"2014-07-04T07:00:07Z","html_url":"https://github.com/alphagov/whitehall/pull/1587#discussion_r14549020","pull_request_url":"https://api.github.com/repos/alphagov/whitehall/pulls/1587","_links":{"self":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/comments/14549020"},"html":{"href":"https://github.com/alphagov/whitehall/pull/1587#discussion_r14549020"},"pull_request":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/1587"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/whitehall/pulls/1587","id":17945349,"html_url":"https://github.com/alphagov/whitehall/pull/1587","diff_url":"https://github.com/alphagov/whitehall/pull/1587.diff","patch_url":"https://github.com/alphagov/whitehall/pull/1587.patch","issue_url":"https://api.github.com/repos/alphagov/whitehall/issues/1587","number":1587,"state":"open","title":"Rework broken link reporter","user":{"login":"tekin","id":3687,"avatar_url":"https://avatars.githubusercontent.com/u/3687?","gravatar_id":"73f812133e01dac8eb9b67746fe27393","url":"https://api.github.com/users/tekin","html_url":"https://github.com/tekin","followers_url":"https://api.github.com/users/tekin/followers","following_url":"https://api.github.com/users/tekin/following{/other_user}","gists_url":"https://api.github.com/users/tekin/gists{/gist_id}","starred_url":"https://api.github.com/users/tekin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tekin/subscriptions","organizations_url":"https://api.github.com/users/tekin/orgs","repos_url":"https://api.github.com/users/tekin/repos","events_url":"https://api.github.com/users/tekin/events{/privacy}","received_events_url":"https://api.github.com/users/tekin/received_events","type":"User","site_admin":false},"body":"This rewrites the broken link reporting to use the new granular link reporting code. Instead of spidering through a mirror of the whole of gov.uk, the new reporting code runs a `LinksReport` for every publicly visible edition and generates CSV reports based on the results. The reports are a series of CSV files, one for each department, listing the documents that contain broken links. The reports can be generated, zipped together and emailed to a supplied address using the rake task.\r\n\r\nStory: https://www.agileplannerapp.com/boards/173808/cards/3344","created_at":"2014-07-03T13:55:27Z","updated_at":"2014-07-04T07:00:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70cb1ea5f1e44907f77cd2de9287b86e765ab597","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/whitehall/pulls/1587/commits","review_comments_url":"https://api.github.com/repos/alphagov/whitehall/pulls/1587/comments","review_comment_url":"https://api.github.com/repos/alphagov/whitehall/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/whitehall/issues/1587/comments","statuses_url":"https://api.github.com/repos/alphagov/whitehall/statuses/9324f19b9c0dfa4349af9a439734e3a25c1b07de","head":{"label":"alphagov:rework-broken-link-reporter","ref":"rework-broken-link-reporter","sha":"9324f19b9c0dfa4349af9a439734e3a25c1b07de","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2416064,"name":"whitehall","full_name":"alphagov/whitehall","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/whitehall","description":"Inside Government: how the UK Government works, what it's doing, and how you can get involved.","fork":false,"url":"https://api.github.com/repos/alphagov/whitehall","forks_url":"https://api.github.com/repos/alphagov/whitehall/forks","keys_url":"https://api.github.com/repos/alphagov/whitehall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/whitehall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/whitehall/teams","hooks_url":"https://api.github.com/repos/alphagov/whitehall/hooks","issue_events_url":"https://api.github.com/repos/alphagov/whitehall/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/whitehall/events","assignees_url":"https://api.github.com/repos/alphagov/whitehall/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/whitehall/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/whitehall/tags","blobs_url":"https://api.github.com/repos/alphagov/whitehall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/whitehall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/whitehall/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/whitehall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/whitehall/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/whitehall/languages","stargazers_url":"https://api.github.com/repos/alphagov/whitehall/stargazers","contributors_url":"https://api.github.com/repos/alphagov/whitehall/contributors","subscribers_url":"https://api.github.com/repos/alphagov/whitehall/subscribers","subscription_url":"https://api.github.com/repos/alphagov/whitehall/subscription","commits_url":"https://api.github.com/repos/alphagov/whitehall/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/whitehall/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/whitehall/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/whitehall/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/whitehall/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/whitehall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/whitehall/merges","archive_url":"https://api.github.com/repos/alphagov/whitehall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/whitehall/downloads","issues_url":"https://api.github.com/repos/alphagov/whitehall/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/whitehall/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/whitehall/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/whitehall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/whitehall/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/whitehall/releases{/id}","created_at":"2011-09-19T15:10:49Z","updated_at":"2014-07-02T22:02:40Z","pushed_at":"2014-07-03T16:24:01Z","git_url":"git://github.com/alphagov/whitehall.git","ssh_url":"git@github.com:alphagov/whitehall.git","clone_url":"https://github.com/alphagov/whitehall.git","svn_url":"https://github.com/alphagov/whitehall","homepage":"https://www.gov.uk/government/","size":185467,"stargazers_count":189,"watchers_count":189,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":49,"mirror_url":null,"open_issues_count":4,"forks":49,"open_issues":4,"watchers":189,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"240bae67cd2d5dc79a38cb76f149b0622c682b0e","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2416064,"name":"whitehall","full_name":"alphagov/whitehall","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?","gravatar_id":"5618b843830194a2475a6e48823f7455","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/whitehall","description":"Inside Government: how the UK Government works, what it's doing, and how you can get involved.","fork":false,"url":"https://api.github.com/repos/alphagov/whitehall","forks_url":"https://api.github.com/repos/alphagov/whitehall/forks","keys_url":"https://api.github.com/repos/alphagov/whitehall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/whitehall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/whitehall/teams","hooks_url":"https://api.github.com/repos/alphagov/whitehall/hooks","issue_events_url":"https://api.github.com/repos/alphagov/whitehall/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/whitehall/events","assignees_url":"https://api.github.com/repos/alphagov/whitehall/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/whitehall/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/whitehall/tags","blobs_url":"https://api.github.com/repos/alphagov/whitehall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/whitehall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/whitehall/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/whitehall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/whitehall/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/whitehall/languages","stargazers_url":"https://api.github.com/repos/alphagov/whitehall/stargazers","contributors_url":"https://api.github.com/repos/alphagov/whitehall/contributors","subscribers_url":"https://api.github.com/repos/alphagov/whitehall/subscribers","subscription_url":"https://api.github.com/repos/alphagov/whitehall/subscription","commits_url":"https://api.github.com/repos/alphagov/whitehall/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/whitehall/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/whitehall/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/whitehall/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/whitehall/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/whitehall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/whitehall/merges","archive_url":"https://api.github.com/repos/alphagov/whitehall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/whitehall/downloads","issues_url":"https://api.github.com/repos/alphagov/whitehall/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/whitehall/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/whitehall/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/whitehall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/whitehall/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/whitehall/releases{/id}","created_at":"2011-09-19T15:10:49Z","updated_at":"2014-07-02T22:02:40Z","pushed_at":"2014-07-03T16:24:01Z","git_url":"git://github.com/alphagov/whitehall.git","ssh_url":"git@github.com:alphagov/whitehall.git","clone_url":"https://github.com/alphagov/whitehall.git","svn_url":"https://github.com/alphagov/whitehall","homepage":"https://www.gov.uk/government/","size":185467,"stargazers_count":189,"watchers_count":189,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":49,"mirror_url":null,"open_issues_count":4,"forks":49,"open_issues":4,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/1587"},"html":{"href":"https://github.com/alphagov/whitehall/pull/1587"},"issue":{"href":"https://api.github.com/repos/alphagov/whitehall/issues/1587"},"comments":{"href":"https://api.github.com/repos/alphagov/whitehall/issues/1587/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/1587/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/1587/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/whitehall/statuses/9324f19b9c0dfa4349af9a439734e3a25c1b07de"}}}}