GitHub PullRequestReviewCommentEvent at 2014-07-01 14:53:50
Repository: vagrant
Actor: sneal
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mitchellh/vagrant/pulls/comments/14408426","id":14408426,"diff_hunk":"@@ -185,7 +185,11 @@ def import(ovf)\n               disk_params << \"--unit\"\n               disk_params << unit_num\n               disk_params << \"--disk\"\n-              disk_params << path.sub(\"/#{suggested_name}/\", \"/#{specified_name}/\")\n+              if Gem.win_platform?","path":"plugins/providers/virtualbox/driver/version_4_2.rb","position":5,"original_position":5,"commit_id":"c60653d230b5987a41f558da49ab034fa96e9569","original_commit_id":"c60653d230b5987a41f558da49ab034fa96e9569","user":{"login":"sneal","id":197023,"avatar_url":"https://avatars.githubusercontent.com/u/197023?","gravatar_id":"ffe64eaead3a365bac8afa0272177526","url":"https://api.github.com/users/sneal","html_url":"https://github.com/sneal","followers_url":"https://api.github.com/users/sneal/followers","following_url":"https://api.github.com/users/sneal/following{/other_user}","gists_url":"https://api.github.com/users/sneal/gists{/gist_id}","starred_url":"https://api.github.com/users/sneal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sneal/subscriptions","organizations_url":"https://api.github.com/users/sneal/orgs","repos_url":"https://api.github.com/users/sneal/repos","events_url":"https://api.github.com/users/sneal/events{/privacy}","received_events_url":"https://api.github.com/users/sneal/received_events","type":"User","site_admin":false},"body":"I think this should be `Vagrant::Util::Platform.windows?`","created_at":"2014-07-01T14:53:50Z","updated_at":"2014-07-01T14:53:50Z","html_url":"https://github.com/mitchellh/vagrant/pull/4133#discussion_r14408426","pull_request_url":"https://api.github.com/repos/mitchellh/vagrant/pulls/4133","_links":{"self":{"href":"https://api.github.com/repos/mitchellh/vagrant/pulls/comments/14408426"},"html":{"href":"https://github.com/mitchellh/vagrant/pull/4133#discussion_r14408426"},"pull_request":{"href":"https://api.github.com/repos/mitchellh/vagrant/pulls/4133"}}},"pull_request":{"url":"https://api.github.com/repos/mitchellh/vagrant/pulls/4133","id":17829064,"html_url":"https://github.com/mitchellh/vagrant/pull/4133","diff_url":"https://github.com/mitchellh/vagrant/pull/4133.diff","patch_url":"https://github.com/mitchellh/vagrant/pull/4133.patch","issue_url":"https://api.github.com/repos/mitchellh/vagrant/issues/4133","number":4133,"state":"open","title":"Ensure VirtualBox virtual disks are stored in the correct directory on Windows hosts","user":{"login":"keiths-osc","id":3358621,"avatar_url":"https://avatars.githubusercontent.com/u/3358621?","gravatar_id":"3b58af478bc062261e1c299730047d78","url":"https://api.github.com/users/keiths-osc","html_url":"https://github.com/keiths-osc","followers_url":"https://api.github.com/users/keiths-osc/followers","following_url":"https://api.github.com/users/keiths-osc/following{/other_user}","gists_url":"https://api.github.com/users/keiths-osc/gists{/gist_id}","starred_url":"https://api.github.com/users/keiths-osc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keiths-osc/subscriptions","organizations_url":"https://api.github.com/users/keiths-osc/orgs","repos_url":"https://api.github.com/users/keiths-osc/repos","events_url":"https://api.github.com/users/keiths-osc/events{/privacy}","received_events_url":"https://api.github.com/users/keiths-osc/received_events","type":"User","site_admin":false},"body":"This change is a fix for https://github.com/mitchellh/vagrant/issues/3584.","created_at":"2014-07-01T13:11:07Z","updated_at":"2014-07-01T14:53:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b981f1d39ad72dc329fb83c0acfc1d52033d910d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mitchellh/vagrant/pulls/4133/commits","review_comments_url":"https://api.github.com/repos/mitchellh/vagrant/pulls/4133/comments","review_comment_url":"https://api.github.com/repos/mitchellh/vagrant/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mitchellh/vagrant/issues/4133/comments","statuses_url":"https://api.github.com/repos/mitchellh/vagrant/statuses/c60653d230b5987a41f558da49ab034fa96e9569","head":{"label":"keiths-osc:windows_virtualbox_vmdk_path_fix","ref":"windows_virtualbox_vmdk_path_fix","sha":"c60653d230b5987a41f558da49ab034fa96e9569","user":{"login":"keiths-osc","id":3358621,"avatar_url":"https://avatars.githubusercontent.com/u/3358621?","gravatar_id":"3b58af478bc062261e1c299730047d78","url":"https://api.github.com/users/keiths-osc","html_url":"https://github.com/keiths-osc","followers_url":"https://api.github.com/users/keiths-osc/followers","following_url":"https://api.github.com/users/keiths-osc/following{/other_user}","gists_url":"https://api.github.com/users/keiths-osc/gists{/gist_id}","starred_url":"https://api.github.com/users/keiths-osc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keiths-osc/subscriptions","organizations_url":"https://api.github.com/users/keiths-osc/orgs","repos_url":"https://api.github.com/users/keiths-osc/repos","events_url":"https://api.github.com/users/keiths-osc/events{/privacy}","received_events_url":"https://api.github.com/users/keiths-osc/received_events","type":"User","site_admin":false},"repo":{"id":21363025,"name":"vagrant","full_name":"keiths-osc/vagrant","owner":{"login":"keiths-osc","id":3358621,"avatar_url":"https://avatars.githubusercontent.com/u/3358621?","gravatar_id":"3b58af478bc062261e1c299730047d78","url":"https://api.github.com/users/keiths-osc","html_url":"https://github.com/keiths-osc","followers_url":"https://api.github.com/users/keiths-osc/followers","following_url":"https://api.github.com/users/keiths-osc/following{/other_user}","gists_url":"https://api.github.com/users/keiths-osc/gists{/gist_id}","starred_url":"https://api.github.com/users/keiths-osc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keiths-osc/subscriptions","organizations_url":"https://api.github.com/users/keiths-osc/orgs","repos_url":"https://api.github.com/users/keiths-osc/repos","events_url":"https://api.github.com/users/keiths-osc/events{/privacy}","received_events_url":"https://api.github.com/users/keiths-osc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keiths-osc/vagrant","description":"Vagrant is a tool for building and distributing development environments.","fork":true,"url":"https://api.github.com/repos/keiths-osc/vagrant","forks_url":"https://api.github.com/repos/keiths-osc/vagrant/forks","keys_url":"https://api.github.com/repos/keiths-osc/vagrant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keiths-osc/vagrant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keiths-osc/vagrant/teams","hooks_url":"https://api.github.com/repos/keiths-osc/vagrant/hooks","issue_events_url":"https://api.github.com/repos/keiths-osc/vagrant/issues/events{/number}","events_url":"https://api.github.com/repos/keiths-osc/vagrant/events","assignees_url":"https://api.github.com/repos/keiths-osc/vagrant/assignees{/user}","branches_url":"https://api.github.com/repos/keiths-osc/vagrant/branches{/branch}","tags_url":"https://api.github.com/repos/keiths-osc/vagrant/tags","blobs_url":"https://api.github.com/repos/keiths-osc/vagrant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keiths-osc/vagrant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keiths-osc/vagrant/git/refs{/sha}","trees_url":"https://api.github.com/repos/keiths-osc/vagrant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keiths-osc/vagrant/statuses/{sha}","languages_url":"https://api.github.com/repos/keiths-osc/vagrant/languages","stargazers_url":"https://api.github.com/repos/keiths-osc/vagrant/stargazers","contributors_url":"https://api.github.com/repos/keiths-osc/vagrant/contributors","subscribers_url":"https://api.github.com/repos/keiths-osc/vagrant/subscribers","subscription_url":"https://api.github.com/repos/keiths-osc/vagrant/subscription","commits_url":"https://api.github.com/repos/keiths-osc/vagrant/commits{/sha}","git_commits_url":"https://api.github.com/repos/keiths-osc/vagrant/git/commits{/sha}","comments_url":"https://api.github.com/repos/keiths-osc/vagrant/comments{/number}","issue_comment_url":"https://api.github.com/repos/keiths-osc/vagrant/issues/comments/{number}","contents_url":"https://api.github.com/repos/keiths-osc/vagrant/contents/{+path}","compare_url":"https://api.github.com/repos/keiths-osc/vagrant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keiths-osc/vagrant/merges","archive_url":"https://api.github.com/repos/keiths-osc/vagrant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keiths-osc/vagrant/downloads","issues_url":"https://api.github.com/repos/keiths-osc/vagrant/issues{/number}","pulls_url":"https://api.github.com/repos/keiths-osc/vagrant/pulls{/number}","milestones_url":"https://api.github.com/repos/keiths-osc/vagrant/milestones{/number}","notifications_url":"https://api.github.com/repos/keiths-osc/vagrant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keiths-osc/vagrant/labels{/name}","releases_url":"https://api.github.com/repos/keiths-osc/vagrant/releases{/id}","created_at":"2014-06-30T19:21:58Z","updated_at":"2014-06-30T18:18:48Z","pushed_at":"2014-07-01T13:03:51Z","git_url":"git://github.com/keiths-osc/vagrant.git","ssh_url":"git@github.com:keiths-osc/vagrant.git","clone_url":"https://github.com/keiths-osc/vagrant.git","svn_url":"https://github.com/keiths-osc/vagrant","homepage":"http://www.vagrantup.com","size":44533,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mitchellh:master","ref":"master","sha":"5530f32922a912c4c6a8b13e5d480a80ae5f051e","user":{"login":"mitchellh","id":1299,"avatar_url":"https://avatars.githubusercontent.com/u/1299?","gravatar_id":"2828f28fb012308a7786eee83b8293c5","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},"repo":{"id":481872,"name":"vagrant","full_name":"mitchellh/vagrant","owner":{"login":"mitchellh","id":1299,"avatar_url":"https://avatars.githubusercontent.com/u/1299?","gravatar_id":"2828f28fb012308a7786eee83b8293c5","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchellh/vagrant","description":"Vagrant is a tool for building and distributing development environments.","fork":false,"url":"https://api.github.com/repos/mitchellh/vagrant","forks_url":"https://api.github.com/repos/mitchellh/vagrant/forks","keys_url":"https://api.github.com/repos/mitchellh/vagrant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchellh/vagrant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchellh/vagrant/teams","hooks_url":"https://api.github.com/repos/mitchellh/vagrant/hooks","issue_events_url":"https://api.github.com/repos/mitchellh/vagrant/issues/events{/number}","events_url":"https://api.github.com/repos/mitchellh/vagrant/events","assignees_url":"https://api.github.com/repos/mitchellh/vagrant/assignees{/user}","branches_url":"https://api.github.com/repos/mitchellh/vagrant/branches{/branch}","tags_url":"https://api.github.com/repos/mitchellh/vagrant/tags","blobs_url":"https://api.github.com/repos/mitchellh/vagrant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchellh/vagrant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchellh/vagrant/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchellh/vagrant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchellh/vagrant/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchellh/vagrant/languages","stargazers_url":"https://api.github.com/repos/mitchellh/vagrant/stargazers","contributors_url":"https://api.github.com/repos/mitchellh/vagrant/contributors","subscribers_url":"https://api.github.com/repos/mitchellh/vagrant/subscribers","subscription_url":"https://api.github.com/repos/mitchellh/vagrant/subscription","commits_url":"https://api.github.com/repos/mitchellh/vagrant/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchellh/vagrant/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchellh/vagrant/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchellh/vagrant/issues/comments/{number}","contents_url":"https://api.github.com/repos/mitchellh/vagrant/contents/{+path}","compare_url":"https://api.github.com/repos/mitchellh/vagrant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchellh/vagrant/merges","archive_url":"https://api.github.com/repos/mitchellh/vagrant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchellh/vagrant/downloads","issues_url":"https://api.github.com/repos/mitchellh/vagrant/issues{/number}","pulls_url":"https://api.github.com/repos/mitchellh/vagrant/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchellh/vagrant/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchellh/vagrant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchellh/vagrant/labels{/name}","releases_url":"https://api.github.com/repos/mitchellh/vagrant/releases{/id}","created_at":"2010-01-21T08:34:27Z","updated_at":"2014-07-01T12:21:27Z","pushed_at":"2014-06-30T00:58:07Z","git_url":"git://github.com/mitchellh/vagrant.git","ssh_url":"git@github.com:mitchellh/vagrant.git","clone_url":"https://github.com/mitchellh/vagrant.git","svn_url":"https://github.com/mitchellh/vagrant","homepage":"http://www.vagrantup.com","size":44533,"stargazers_count":6968,"watchers_count":6968,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1556,"mirror_url":null,"open_issues_count":201,"forks":1556,"open_issues":201,"watchers":6968,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitchellh/vagrant/pulls/4133"},"html":{"href":"https://github.com/mitchellh/vagrant/pull/4133"},"issue":{"href":"https://api.github.com/repos/mitchellh/vagrant/issues/4133"},"comments":{"href":"https://api.github.com/repos/mitchellh/vagrant/issues/4133/comments"},"review_comments":{"href":"https://api.github.com/repos/mitchellh/vagrant/pulls/4133/comments"},"review_comment":{"href":"https://api.github.com/repos/mitchellh/vagrant/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mitchellh/vagrant/pulls/4133/commits"},"statuses":{"href":"https://api.github.com/repos/mitchellh/vagrant/statuses/c60653d230b5987a41f558da49ab034fa96e9569"}}}}