GitHub PullRequestReviewCommentEvent at 2014-03-08 17:25:30
Repository: nengo
Actor: tbekolay
Payload: {"comment":{"url":"https://api.github.com/repos/ctn-waterloo/nengo/pulls/comments/10409927","id":10409927,"diff_hunk":"@@ -0,0 +1,46 @@\n+\"\"\"A customizable configuration system for setting backend-specific info.\n+\n+The idea here is that a backend can subclass Config and ConfigItem to\n+define the set of parameters that their backend supports.  Parameters\n+are done as Python descriptors, so backends can also specify\n+error checking on those parameters.\n+\"\"\"\n+\n+\n+class Parameter(object):\n+    def __init__(self, default):\n+        self.default = default\n+        self.data = {}","path":"nengo/config.py","position":13,"original_position":13,"commit_id":"df5b20604794fd1d0e9e7cd66e3d0e05c0f094df","original_commit_id":"df5b20604794fd1d0e9e7cd66e3d0e05c0f094df","user":{"login":"tbekolay","id":203709,"avatar_url":"https://gravatar.com/avatar/2f367fe214d05649020bd3ef281184f0?d=https%3A%2F%2Fidenticons.github.com%2F31ce9e49ba14c098756dfe33798abc01.png&r=x","gravatar_id":"2f367fe214d05649020bd3ef281184f0","url":"https://api.github.com/users/tbekolay","html_url":"https://github.com/tbekolay","followers_url":"https://api.github.com/users/tbekolay/followers","following_url":"https://api.github.com/users/tbekolay/following{/other_user}","gists_url":"https://api.github.com/users/tbekolay/gists{/gist_id}","starred_url":"https://api.github.com/users/tbekolay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbekolay/subscriptions","organizations_url":"https://api.github.com/users/tbekolay/orgs","repos_url":"https://api.github.com/users/tbekolay/repos","events_url":"https://api.github.com/users/tbekolay/events{/privacy}","received_events_url":"https://api.github.com/users/tbekolay/received_events","type":"User","site_admin":false},"body":"This dictionary should be a `WeakKeyDictionary` to prevent memory leaks from objects that don't get garbage collected just because they've been configured (from [this notebook](http://nbviewer.ipython.org/urls/gist.github.com/ChrisBeaumont/5758381/raw/descriptor_writeup.ipynb)).","created_at":"2014-03-08T17:25:30Z","updated_at":"2014-03-08T17:25:30Z","html_url":"https://github.com/ctn-waterloo/nengo/pull/273#discussion_r10409927","pull_request_url":"https://api.github.com/repos/ctn-waterloo/nengo/pulls/273","_links":{"self":{"href":"https://api.github.com/repos/ctn-waterloo/nengo/pulls/comments/10409927"},"html":{"href":"https://github.com/ctn-waterloo/nengo/pull/273#discussion_r10409927"},"pull_request":{"href":"https://api.github.com/repos/ctn-waterloo/nengo/pulls/273"}}}}