GitHub PullRequestReviewCommentEvent at 2014-08-20 22:21:15
Repository: juju
Actor: howbazaar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/16509880","id":16509880,"diff_hunk":"@@ -44,11 +46,13 @@ type Upgrader struct {\n // an upgrade is needed, the worker will exit with an UpgradeReadyError\n // holding details of the requested upgrade. The tools will have been\n // downloaded and unpacked.\n-func NewUpgrader(st *upgrader.State, agentConfig agent.Config) *Upgrader {\n+func NewUpgrader(st *upgrader.State, agentConfig agent.Config, isUpgradeRunning func() bool) *Upgrader {\n \tu := &Upgrader{\n-\t\tst:      st,\n-\t\tdataDir: agentConfig.DataDir(),\n-\t\ttag:     agentConfig.Tag(),\n+\t\tst:               st,\n+\t\tdataDir:          agentConfig.DataDir(),\n+\t\ttag:              agentConfig.Tag(),\n+\t\torigAgentVersion: agentConfig.UpgradedToVersion(),","path":"worker/upgrader/upgrader.go","position":30,"original_position":30,"commit_id":"b56439816c7625e460a0d1dd9f14b04ac108e045","original_commit_id":"b56439816c7625e460a0d1dd9f14b04ac108e045","user":{"login":"howbazaar","id":1744247,"avatar_url":"https://avatars.githubusercontent.com/u/1744247?v=2","gravatar_id":"ec6cce6fd3bee2a0fa99be8e1960bb44","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"body":"This seems a bit weird.  Why is it not version.Current?","created_at":"2014-08-20T22:21:15Z","updated_at":"2014-08-20T22:21:15Z","html_url":"https://github.com/juju/juju/pull/555#discussion_r16509880","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/555","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/16509880"},"html":{"href":"https://github.com/juju/juju/pull/555#discussion_r16509880"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/555"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/555","id":20025414,"html_url":"https://github.com/juju/juju/pull/555","diff_url":"https://github.com/juju/juju/pull/555.diff","patch_url":"https://github.com/juju/juju/pull/555.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/555","number":555,"state":"open","locked":false,"title":"Support downgrades to previous version in the case of aborted upgrades","user":{"login":"mjs","id":14993,"avatar_url":"https://avatars.githubusercontent.com/u/14993?v=2","gravatar_id":"286ea349060105e596aec349da029a00","url":"https://api.github.com/users/mjs","html_url":"https://github.com/mjs","followers_url":"https://api.github.com/users/mjs/followers","following_url":"https://api.github.com/users/mjs/following{/other_user}","gists_url":"https://api.github.com/users/mjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjs/subscriptions","organizations_url":"https://api.github.com/users/mjs/orgs","repos_url":"https://api.github.com/users/mjs/repos","events_url":"https://api.github.com/users/mjs/events{/privacy}","received_events_url":"https://api.github.com/users/mjs/received_events","type":"User","site_admin":false},"body":"In some cases upgrades will need to be aborted and the best course of action will be to restart to the previous agent version. This PR modifies the upgrader worker and machine agent so that it will allow downgrades\r\nto the pre-upgrade tools version, but only if an upgrade is still in progress. This allows the upgrade-steps worker to trigger a downgrade to the previous agent version by changing the environment's agent-version.","created_at":"2014-08-20T05:16:45Z","updated_at":"2014-08-20T22:21:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e12f7dfab78c8652cdfb6606f7cf95a9a40e730","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/555/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/555/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju/issues/555/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/b56439816c7625e460a0d1dd9f14b04ac108e045","head":{"label":"mjs:upgrader-allow-limited-downgrade","ref":"upgrader-allow-limited-downgrade","sha":"b56439816c7625e460a0d1dd9f14b04ac108e045","user":{"login":"mjs","id":14993,"avatar_url":"https://avatars.githubusercontent.com/u/14993?v=2","gravatar_id":"286ea349060105e596aec349da029a00","url":"https://api.github.com/users/mjs","html_url":"https://github.com/mjs","followers_url":"https://api.github.com/users/mjs/followers","following_url":"https://api.github.com/users/mjs/following{/other_user}","gists_url":"https://api.github.com/users/mjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjs/subscriptions","organizations_url":"https://api.github.com/users/mjs/orgs","repos_url":"https://api.github.com/users/mjs/repos","events_url":"https://api.github.com/users/mjs/events{/privacy}","received_events_url":"https://api.github.com/users/mjs/received_events","type":"User","site_admin":false},"repo":{"id":20458097,"name":"juju","full_name":"mjs/juju","owner":{"login":"mjs","id":14993,"avatar_url":"https://avatars.githubusercontent.com/u/14993?v=2","gravatar_id":"286ea349060105e596aec349da029a00","url":"https://api.github.com/users/mjs","html_url":"https://github.com/mjs","followers_url":"https://api.github.com/users/mjs/followers","following_url":"https://api.github.com/users/mjs/following{/other_user}","gists_url":"https://api.github.com/users/mjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjs/subscriptions","organizations_url":"https://api.github.com/users/mjs/orgs","repos_url":"https://api.github.com/users/mjs/repos","events_url":"https://api.github.com/users/mjs/events{/privacy}","received_events_url":"https://api.github.com/users/mjs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjs/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/mjs/juju","forks_url":"https://api.github.com/repos/mjs/juju/forks","keys_url":"https://api.github.com/repos/mjs/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjs/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjs/juju/teams","hooks_url":"https://api.github.com/repos/mjs/juju/hooks","issue_events_url":"https://api.github.com/repos/mjs/juju/issues/events{/number}","events_url":"https://api.github.com/repos/mjs/juju/events","assignees_url":"https://api.github.com/repos/mjs/juju/assignees{/user}","branches_url":"https://api.github.com/repos/mjs/juju/branches{/branch}","tags_url":"https://api.github.com/repos/mjs/juju/tags","blobs_url":"https://api.github.com/repos/mjs/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjs/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjs/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjs/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjs/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/mjs/juju/languages","stargazers_url":"https://api.github.com/repos/mjs/juju/stargazers","contributors_url":"https://api.github.com/repos/mjs/juju/contributors","subscribers_url":"https://api.github.com/repos/mjs/juju/subscribers","subscription_url":"https://api.github.com/repos/mjs/juju/subscription","commits_url":"https://api.github.com/repos/mjs/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjs/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjs/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjs/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/mjs/juju/contents/{+path}","compare_url":"https://api.github.com/repos/mjs/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjs/juju/merges","archive_url":"https://api.github.com/repos/mjs/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjs/juju/downloads","issues_url":"https://api.github.com/repos/mjs/juju/issues{/number}","pulls_url":"https://api.github.com/repos/mjs/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/mjs/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/mjs/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjs/juju/labels{/name}","releases_url":"https://api.github.com/repos/mjs/juju/releases{/id}","created_at":"2014-06-03T20:21:02Z","updated_at":"2014-07-01T23:34:49Z","pushed_at":"2014-08-20T05:14:02Z","git_url":"git://github.com/mjs/juju.git","ssh_url":"git@github.com:mjs/juju.git","clone_url":"https://github.com/mjs/juju.git","svn_url":"https://github.com/mjs/juju","homepage":null,"size":27661,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"0f96d48e45887375cb2a5809f501ec015a986c47","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2014-08-19T04:47:51Z","pushed_at":"2014-08-20T18:29:42Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":39625,"stargazers_count":194,"watchers_count":194,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":49,"mirror_url":null,"open_issues_count":44,"forks":49,"open_issues":44,"watchers":194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/555"},"html":{"href":"https://github.com/juju/juju/pull/555"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/555"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/555/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/555/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/555/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/b56439816c7625e460a0d1dd9f14b04ac108e045"}}}}