GitHub PullRequestReviewCommentEvent at 2014-12-03 22:55:47
Repository: jellyfish
Actor: nicolashery
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/tidepool-org/jellyfish/pulls/comments/21272498","id":21272498,"diff_hunk":"@@ -72,7 +72,13 @@ function go(config) {\n         fail('Just another error', err);\n       }\n       process.send({path:files.location});\n-      process.exit(0);\n+\n+      if (err) {\n+        process.exit(1);\n+      } else {\n+        process.exit(0);\n+      }","path":"lib/children/carelinkLoad.js","position":10,"original_position":10,"commit_id":"bc675ac4a68f20f72d3347c78470ba39cc3dbae6","original_commit_id":"bc675ac4a68f20f72d3347c78470ba39cc3dbae6","user":{"login":"nicolashery","id":1306536,"avatar_url":"https://avatars.githubusercontent.com/u/1306536?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolashery","html_url":"https://github.com/nicolashery","followers_url":"https://api.github.com/users/nicolashery/followers","following_url":"https://api.github.com/users/nicolashery/following{/other_user}","gists_url":"https://api.github.com/users/nicolashery/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolashery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolashery/subscriptions","organizations_url":"https://api.github.com/users/nicolashery/orgs","repos_url":"https://api.github.com/users/nicolashery/repos","events_url":"https://api.github.com/users/nicolashery/events{/privacy}","received_events_url":"https://api.github.com/users/nicolashery/received_events","type":"User","site_admin":false},"body":"`fail()` already calls `process.exit(255)`, so you don't need this here (the `if (err)` branch will never get called). My bad, I think I pointed you to this last time we talked, but I hadn't looked closely at `fail()`.","created_at":"2014-12-03T22:55:47Z","updated_at":"2014-12-03T22:55:47Z","html_url":"https://github.com/tidepool-org/jellyfish/pull/37#discussion_r21272498","pull_request_url":"https://api.github.com/repos/tidepool-org/jellyfish/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/tidepool-org/jellyfish/pulls/comments/21272498"},"html":{"href":"https://github.com/tidepool-org/jellyfish/pull/37#discussion_r21272498"},"pull_request":{"href":"https://api.github.com/repos/tidepool-org/jellyfish/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/tidepool-org/jellyfish/pulls/37","id":25414404,"html_url":"https://github.com/tidepool-org/jellyfish/pull/37","diff_url":"https://github.com/tidepool-org/jellyfish/pull/37.diff","patch_url":"https://github.com/tidepool-org/jellyfish/pull/37.patch","issue_url":"https://api.github.com/repos/tidepool-org/jellyfish/issues/37","number":37,"state":"open","locked":false,"title":"pass error from sync task to client","user":{"login":"ianjorgensen","id":25203,"avatar_url":"https://avatars.githubusercontent.com/u/25203?v=3","gravatar_id":"","url":"https://api.github.com/users/ianjorgensen","html_url":"https://github.com/ianjorgensen","followers_url":"https://api.github.com/users/ianjorgensen/followers","following_url":"https://api.github.com/users/ianjorgensen/following{/other_user}","gists_url":"https://api.github.com/users/ianjorgensen/gists{/gist_id}","starred_url":"https://api.github.com/users/ianjorgensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianjorgensen/subscriptions","organizations_url":"https://api.github.com/users/ianjorgensen/orgs","repos_url":"https://api.github.com/users/ianjorgensen/repos","events_url":"https://api.github.com/users/ianjorgensen/events{/privacy}","received_events_url":"https://api.github.com/users/ianjorgensen/received_events","type":"User","site_admin":false},"body":"Added passing of error from sync task to client. @jh-bate ready for review, with https://github.com/tidepool-org/in-d-gestion/pull/36","created_at":"2014-12-03T12:13:56Z","updated_at":"2014-12-03T22:55:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6b96a4585fc10c17f4898dbdde1420649d3b879","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tidepool-org/jellyfish/pulls/37/commits","review_comments_url":"https://api.github.com/repos/tidepool-org/jellyfish/pulls/37/comments","review_comment_url":"https://api.github.com/repos/tidepool-org/jellyfish/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tidepool-org/jellyfish/issues/37/comments","statuses_url":"https://api.github.com/repos/tidepool-org/jellyfish/statuses/bc675ac4a68f20f72d3347c78470ba39cc3dbae6","head":{"label":"tidepool-org:ian/error","ref":"ian/error","sha":"bc675ac4a68f20f72d3347c78470ba39cc3dbae6","user":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"repo":{"id":16853872,"name":"jellyfish","full_name":"tidepool-org/jellyfish","owner":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tidepool-org/jellyfish","description":"The GUI for uploads.","fork":false,"url":"https://api.github.com/repos/tidepool-org/jellyfish","forks_url":"https://api.github.com/repos/tidepool-org/jellyfish/forks","keys_url":"https://api.github.com/repos/tidepool-org/jellyfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidepool-org/jellyfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidepool-org/jellyfish/teams","hooks_url":"https://api.github.com/repos/tidepool-org/jellyfish/hooks","issue_events_url":"https://api.github.com/repos/tidepool-org/jellyfish/issues/events{/number}","events_url":"https://api.github.com/repos/tidepool-org/jellyfish/events","assignees_url":"https://api.github.com/repos/tidepool-org/jellyfish/assignees{/user}","branches_url":"https://api.github.com/repos/tidepool-org/jellyfish/branches{/branch}","tags_url":"https://api.github.com/repos/tidepool-org/jellyfish/tags","blobs_url":"https://api.github.com/repos/tidepool-org/jellyfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidepool-org/jellyfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidepool-org/jellyfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidepool-org/jellyfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidepool-org/jellyfish/statuses/{sha}","languages_url":"https://api.github.com/repos/tidepool-org/jellyfish/languages","stargazers_url":"https://api.github.com/repos/tidepool-org/jellyfish/stargazers","contributors_url":"https://api.github.com/repos/tidepool-org/jellyfish/contributors","subscribers_url":"https://api.github.com/repos/tidepool-org/jellyfish/subscribers","subscription_url":"https://api.github.com/repos/tidepool-org/jellyfish/subscription","commits_url":"https://api.github.com/repos/tidepool-org/jellyfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidepool-org/jellyfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidepool-org/jellyfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidepool-org/jellyfish/issues/comments/{number}","contents_url":"https://api.github.com/repos/tidepool-org/jellyfish/contents/{+path}","compare_url":"https://api.github.com/repos/tidepool-org/jellyfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidepool-org/jellyfish/merges","archive_url":"https://api.github.com/repos/tidepool-org/jellyfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidepool-org/jellyfish/downloads","issues_url":"https://api.github.com/repos/tidepool-org/jellyfish/issues{/number}","pulls_url":"https://api.github.com/repos/tidepool-org/jellyfish/pulls{/number}","milestones_url":"https://api.github.com/repos/tidepool-org/jellyfish/milestones{/number}","notifications_url":"https://api.github.com/repos/tidepool-org/jellyfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidepool-org/jellyfish/labels{/name}","releases_url":"https://api.github.com/repos/tidepool-org/jellyfish/releases{/id}","created_at":"2014-02-15T01:07:02Z","updated_at":"2014-11-18T21:19:01Z","pushed_at":"2014-12-03T12:12:31Z","git_url":"git://github.com/tidepool-org/jellyfish.git","ssh_url":"git@github.com:tidepool-org/jellyfish.git","clone_url":"https://github.com/tidepool-org/jellyfish.git","svn_url":"https://github.com/tidepool-org/jellyfish","homepage":null,"size":2532,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tidepool-org:jhbate/uploader","ref":"jhbate/uploader","sha":"e971dc708cb0463c9976baafc13886f3a19958c5","user":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"repo":{"id":16853872,"name":"jellyfish","full_name":"tidepool-org/jellyfish","owner":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tidepool-org/jellyfish","description":"The GUI for uploads.","fork":false,"url":"https://api.github.com/repos/tidepool-org/jellyfish","forks_url":"https://api.github.com/repos/tidepool-org/jellyfish/forks","keys_url":"https://api.github.com/repos/tidepool-org/jellyfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidepool-org/jellyfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidepool-org/jellyfish/teams","hooks_url":"https://api.github.com/repos/tidepool-org/jellyfish/hooks","issue_events_url":"https://api.github.com/repos/tidepool-org/jellyfish/issues/events{/number}","events_url":"https://api.github.com/repos/tidepool-org/jellyfish/events","assignees_url":"https://api.github.com/repos/tidepool-org/jellyfish/assignees{/user}","branches_url":"https://api.github.com/repos/tidepool-org/jellyfish/branches{/branch}","tags_url":"https://api.github.com/repos/tidepool-org/jellyfish/tags","blobs_url":"https://api.github.com/repos/tidepool-org/jellyfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidepool-org/jellyfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidepool-org/jellyfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidepool-org/jellyfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidepool-org/jellyfish/statuses/{sha}","languages_url":"https://api.github.com/repos/tidepool-org/jellyfish/languages","stargazers_url":"https://api.github.com/repos/tidepool-org/jellyfish/stargazers","contributors_url":"https://api.github.com/repos/tidepool-org/jellyfish/contributors","subscribers_url":"https://api.github.com/repos/tidepool-org/jellyfish/subscribers","subscription_url":"https://api.github.com/repos/tidepool-org/jellyfish/subscription","commits_url":"https://api.github.com/repos/tidepool-org/jellyfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidepool-org/jellyfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidepool-org/jellyfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidepool-org/jellyfish/issues/comments/{number}","contents_url":"https://api.github.com/repos/tidepool-org/jellyfish/contents/{+path}","compare_url":"https://api.github.com/repos/tidepool-org/jellyfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidepool-org/jellyfish/merges","archive_url":"https://api.github.com/repos/tidepool-org/jellyfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidepool-org/jellyfish/downloads","issues_url":"https://api.github.com/repos/tidepool-org/jellyfish/issues{/number}","pulls_url":"https://api.github.com/repos/tidepool-org/jellyfish/pulls{/number}","milestones_url":"https://api.github.com/repos/tidepool-org/jellyfish/milestones{/number}","notifications_url":"https://api.github.com/repos/tidepool-org/jellyfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidepool-org/jellyfish/labels{/name}","releases_url":"https://api.github.com/repos/tidepool-org/jellyfish/releases{/id}","created_at":"2014-02-15T01:07:02Z","updated_at":"2014-11-18T21:19:01Z","pushed_at":"2014-12-03T12:12:31Z","git_url":"git://github.com/tidepool-org/jellyfish.git","ssh_url":"git@github.com:tidepool-org/jellyfish.git","clone_url":"https://github.com/tidepool-org/jellyfish.git","svn_url":"https://github.com/tidepool-org/jellyfish","homepage":null,"size":2532,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tidepool-org/jellyfish/pulls/37"},"html":{"href":"https://github.com/tidepool-org/jellyfish/pull/37"},"issue":{"href":"https://api.github.com/repos/tidepool-org/jellyfish/issues/37"},"comments":{"href":"https://api.github.com/repos/tidepool-org/jellyfish/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/tidepool-org/jellyfish/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/tidepool-org/jellyfish/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tidepool-org/jellyfish/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/tidepool-org/jellyfish/statuses/bc675ac4a68f20f72d3347c78470ba39cc3dbae6"}}}}