GitHub PullRequestReviewCommentEvent at 2014-11-27 06:26:21
Repository: direct-app
Actor: deedee
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cloudspokes/direct-app/pulls/comments/20980747","id":20980747,"diff_hunk":"@@ -2856,7 +2863,14 @@ public static boolean isSecurityGroupsUIAvailable() throws UserServiceException\n         WebApplicationContext applicationContext = WebApplicationContextUtils.getWebApplicationContext(ctx);\r\n         SecurityGroupsAccessInterceptor securityGroupsAccessInterceptor\r\n             = (SecurityGroupsAccessInterceptor) applicationContext.getBean(\"securityGroupsAccessInterceptor\");\r\n-        return securityGroupsAccessInterceptor.isSecurityGroupsUIAvailable();\r\n+        if (securityGroupsAccessInterceptor.isSecurityGroupsUIAvailable()){\r\n+            SecurityGroupsTcStaffOnlyInterceptor securityGroupsTcStaffOnlyInterceptor = (SecurityGroupsTcStaffOnlyInterceptor)\r","path":"src/java/main/com/topcoder/direct/services/view/util/DirectUtils.java","position":31,"original_position":31,"commit_id":"204a1b21cd67c9277dc9688d661f5fd13f38a0d3","original_commit_id":"204a1b21cd67c9277dc9688d661f5fd13f38a0d3","user":{"login":"deedee","id":2527455,"avatar_url":"https://avatars.githubusercontent.com/u/2527455?v=3","gravatar_id":"","url":"https://api.github.com/users/deedee","html_url":"https://github.com/deedee","followers_url":"https://api.github.com/users/deedee/followers","following_url":"https://api.github.com/users/deedee/following{/other_user}","gists_url":"https://api.github.com/users/deedee/gists{/gist_id}","starred_url":"https://api.github.com/users/deedee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deedee/subscriptions","organizations_url":"https://api.github.com/users/deedee/orgs","repos_url":"https://api.github.com/users/deedee/repos","events_url":"https://api.github.com/users/deedee/events{/privacy}","received_events_url":"https://api.github.com/users/deedee/received_events","type":"User","site_admin":false},"body":"For 'group' menu, it evaluate by custom tag 'isSecurityGroupsUIAccessible' on every page, while SecurityGroupsTcStaffOnlyInterceptor only execute under /group namespace","created_at":"2014-11-27T06:26:21Z","updated_at":"2014-11-27T06:26:21Z","html_url":"https://github.com/cloudspokes/direct-app/pull/74#discussion_r20980747","pull_request_url":"https://api.github.com/repos/cloudspokes/direct-app/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/cloudspokes/direct-app/pulls/comments/20980747"},"html":{"href":"https://github.com/cloudspokes/direct-app/pull/74#discussion_r20980747"},"pull_request":{"href":"https://api.github.com/repos/cloudspokes/direct-app/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/cloudspokes/direct-app/pulls/74","id":24791706,"html_url":"https://github.com/cloudspokes/direct-app/pull/74","diff_url":"https://github.com/cloudspokes/direct-app/pull/74.diff","patch_url":"https://github.com/cloudspokes/direct-app/pull/74.patch","issue_url":"https://api.github.com/repos/cloudspokes/direct-app/issues/74","number":74,"state":"open","locked":false,"title":"Fix issue #16 Hide 'Groups' if the user does not have permission","user":{"login":"deedee","id":2527455,"avatar_url":"https://avatars.githubusercontent.com/u/2527455?v=3","gravatar_id":"","url":"https://api.github.com/users/deedee","html_url":"https://github.com/deedee","followers_url":"https://api.github.com/users/deedee/followers","following_url":"https://api.github.com/users/deedee/following{/other_user}","gists_url":"https://api.github.com/users/deedee/gists{/gist_id}","starred_url":"https://api.github.com/users/deedee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deedee/subscriptions","organizations_url":"https://api.github.com/users/deedee/orgs","repos_url":"https://api.github.com/users/deedee/repos","events_url":"https://api.github.com/users/deedee/events{/privacy}","received_events_url":"https://api.github.com/users/deedee/received_events","type":"User","site_admin":false},"body":"Fix https://github.com/cloudspokes/direct-app/issues/16\r\n-add TCStaff check","created_at":"2014-11-20T19:40:14Z","updated_at":"2014-11-27T06:26:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"deca636050d46a8541587455ed57974526056d73","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudspokes/direct-app/pulls/74/commits","review_comments_url":"https://api.github.com/repos/cloudspokes/direct-app/pulls/74/comments","review_comment_url":"https://api.github.com/repos/cloudspokes/direct-app/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cloudspokes/direct-app/issues/74/comments","statuses_url":"https://api.github.com/repos/cloudspokes/direct-app/statuses/204a1b21cd67c9277dc9688d661f5fd13f38a0d3","head":{"label":"deedee:issue-16-Hide_Groups_if_user_does_not_have_permission","ref":"issue-16-Hide_Groups_if_user_does_not_have_permission","sha":"204a1b21cd67c9277dc9688d661f5fd13f38a0d3","user":{"login":"deedee","id":2527455,"avatar_url":"https://avatars.githubusercontent.com/u/2527455?v=3","gravatar_id":"","url":"https://api.github.com/users/deedee","html_url":"https://github.com/deedee","followers_url":"https://api.github.com/users/deedee/followers","following_url":"https://api.github.com/users/deedee/following{/other_user}","gists_url":"https://api.github.com/users/deedee/gists{/gist_id}","starred_url":"https://api.github.com/users/deedee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deedee/subscriptions","organizations_url":"https://api.github.com/users/deedee/orgs","repos_url":"https://api.github.com/users/deedee/repos","events_url":"https://api.github.com/users/deedee/events{/privacy}","received_events_url":"https://api.github.com/users/deedee/received_events","type":"User","site_admin":false},"repo":{"id":26701933,"name":"direct-app","full_name":"deedee/direct-app","owner":{"login":"deedee","id":2527455,"avatar_url":"https://avatars.githubusercontent.com/u/2527455?v=3","gravatar_id":"","url":"https://api.github.com/users/deedee","html_url":"https://github.com/deedee","followers_url":"https://api.github.com/users/deedee/followers","following_url":"https://api.github.com/users/deedee/following{/other_user}","gists_url":"https://api.github.com/users/deedee/gists{/gist_id}","starred_url":"https://api.github.com/users/deedee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deedee/subscriptions","organizations_url":"https://api.github.com/users/deedee/orgs","repos_url":"https://api.github.com/users/deedee/repos","events_url":"https://api.github.com/users/deedee/events{/privacy}","received_events_url":"https://api.github.com/users/deedee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deedee/direct-app","description":"","fork":true,"url":"https://api.github.com/repos/deedee/direct-app","forks_url":"https://api.github.com/repos/deedee/direct-app/forks","keys_url":"https://api.github.com/repos/deedee/direct-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deedee/direct-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deedee/direct-app/teams","hooks_url":"https://api.github.com/repos/deedee/direct-app/hooks","issue_events_url":"https://api.github.com/repos/deedee/direct-app/issues/events{/number}","events_url":"https://api.github.com/repos/deedee/direct-app/events","assignees_url":"https://api.github.com/repos/deedee/direct-app/assignees{/user}","branches_url":"https://api.github.com/repos/deedee/direct-app/branches{/branch}","tags_url":"https://api.github.com/repos/deedee/direct-app/tags","blobs_url":"https://api.github.com/repos/deedee/direct-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deedee/direct-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deedee/direct-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/deedee/direct-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deedee/direct-app/statuses/{sha}","languages_url":"https://api.github.com/repos/deedee/direct-app/languages","stargazers_url":"https://api.github.com/repos/deedee/direct-app/stargazers","contributors_url":"https://api.github.com/repos/deedee/direct-app/contributors","subscribers_url":"https://api.github.com/repos/deedee/direct-app/subscribers","subscription_url":"https://api.github.com/repos/deedee/direct-app/subscription","commits_url":"https://api.github.com/repos/deedee/direct-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/deedee/direct-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/deedee/direct-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/deedee/direct-app/issues/comments/{number}","contents_url":"https://api.github.com/repos/deedee/direct-app/contents/{+path}","compare_url":"https://api.github.com/repos/deedee/direct-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deedee/direct-app/merges","archive_url":"https://api.github.com/repos/deedee/direct-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deedee/direct-app/downloads","issues_url":"https://api.github.com/repos/deedee/direct-app/issues{/number}","pulls_url":"https://api.github.com/repos/deedee/direct-app/pulls{/number}","milestones_url":"https://api.github.com/repos/deedee/direct-app/milestones{/number}","notifications_url":"https://api.github.com/repos/deedee/direct-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deedee/direct-app/labels{/name}","releases_url":"https://api.github.com/repos/deedee/direct-app/releases{/id}","created_at":"2014-11-16T03:03:57Z","updated_at":"2014-11-16T03:04:15Z","pushed_at":"2014-11-21T08:46:16Z","git_url":"git://github.com/deedee/direct-app.git","ssh_url":"git@github.com:deedee/direct-app.git","clone_url":"https://github.com/deedee/direct-app.git","svn_url":"https://github.com/deedee/direct-app","homepage":null,"size":234329,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudspokes:dev","ref":"dev","sha":"b51efdc359d4f4c29a7217b48db3b38717878210","user":{"login":"cloudspokes","id":684980,"avatar_url":"https://avatars.githubusercontent.com/u/684980?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudspokes","html_url":"https://github.com/cloudspokes","followers_url":"https://api.github.com/users/cloudspokes/followers","following_url":"https://api.github.com/users/cloudspokes/following{/other_user}","gists_url":"https://api.github.com/users/cloudspokes/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudspokes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudspokes/subscriptions","organizations_url":"https://api.github.com/users/cloudspokes/orgs","repos_url":"https://api.github.com/users/cloudspokes/repos","events_url":"https://api.github.com/users/cloudspokes/events{/privacy}","received_events_url":"https://api.github.com/users/cloudspokes/received_events","type":"Organization","site_admin":false},"repo":{"id":23885120,"name":"direct-app","full_name":"cloudspokes/direct-app","owner":{"login":"cloudspokes","id":684980,"avatar_url":"https://avatars.githubusercontent.com/u/684980?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudspokes","html_url":"https://github.com/cloudspokes","followers_url":"https://api.github.com/users/cloudspokes/followers","following_url":"https://api.github.com/users/cloudspokes/following{/other_user}","gists_url":"https://api.github.com/users/cloudspokes/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudspokes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudspokes/subscriptions","organizations_url":"https://api.github.com/users/cloudspokes/orgs","repos_url":"https://api.github.com/users/cloudspokes/repos","events_url":"https://api.github.com/users/cloudspokes/events{/privacy}","received_events_url":"https://api.github.com/users/cloudspokes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudspokes/direct-app","description":"TopCoder Direct","fork":false,"url":"https://api.github.com/repos/cloudspokes/direct-app","forks_url":"https://api.github.com/repos/cloudspokes/direct-app/forks","keys_url":"https://api.github.com/repos/cloudspokes/direct-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudspokes/direct-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudspokes/direct-app/teams","hooks_url":"https://api.github.com/repos/cloudspokes/direct-app/hooks","issue_events_url":"https://api.github.com/repos/cloudspokes/direct-app/issues/events{/number}","events_url":"https://api.github.com/repos/cloudspokes/direct-app/events","assignees_url":"https://api.github.com/repos/cloudspokes/direct-app/assignees{/user}","branches_url":"https://api.github.com/repos/cloudspokes/direct-app/branches{/branch}","tags_url":"https://api.github.com/repos/cloudspokes/direct-app/tags","blobs_url":"https://api.github.com/repos/cloudspokes/direct-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudspokes/direct-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudspokes/direct-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudspokes/direct-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudspokes/direct-app/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudspokes/direct-app/languages","stargazers_url":"https://api.github.com/repos/cloudspokes/direct-app/stargazers","contributors_url":"https://api.github.com/repos/cloudspokes/direct-app/contributors","subscribers_url":"https://api.github.com/repos/cloudspokes/direct-app/subscribers","subscription_url":"https://api.github.com/repos/cloudspokes/direct-app/subscription","commits_url":"https://api.github.com/repos/cloudspokes/direct-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudspokes/direct-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudspokes/direct-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudspokes/direct-app/issues/comments/{number}","contents_url":"https://api.github.com/repos/cloudspokes/direct-app/contents/{+path}","compare_url":"https://api.github.com/repos/cloudspokes/direct-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudspokes/direct-app/merges","archive_url":"https://api.github.com/repos/cloudspokes/direct-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudspokes/direct-app/downloads","issues_url":"https://api.github.com/repos/cloudspokes/direct-app/issues{/number}","pulls_url":"https://api.github.com/repos/cloudspokes/direct-app/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudspokes/direct-app/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudspokes/direct-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudspokes/direct-app/labels{/name}","releases_url":"https://api.github.com/repos/cloudspokes/direct-app/releases{/id}","created_at":"2014-09-10T17:49:11Z","updated_at":"2014-11-27T05:44:53Z","pushed_at":"2014-11-27T05:44:53Z","git_url":"git://github.com/cloudspokes/direct-app.git","ssh_url":"git@github.com:cloudspokes/direct-app.git","clone_url":"https://github.com/cloudspokes/direct-app.git","svn_url":"https://github.com/cloudspokes/direct-app","homepage":"https://www.topcoder.com/direct/","size":256492,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":20,"forks":66,"open_issues":20,"watchers":7,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudspokes/direct-app/pulls/74"},"html":{"href":"https://github.com/cloudspokes/direct-app/pull/74"},"issue":{"href":"https://api.github.com/repos/cloudspokes/direct-app/issues/74"},"comments":{"href":"https://api.github.com/repos/cloudspokes/direct-app/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudspokes/direct-app/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudspokes/direct-app/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cloudspokes/direct-app/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/cloudspokes/direct-app/statuses/204a1b21cd67c9277dc9688d661f5fd13f38a0d3"}}}}