GitHub PullRequestEvent at 2014-02-15 15:29:50
Repository: Mantle
Actor: zats
Payload: {"action":"opened","number":242,"pull_request":{"url":"https://api.github.com/repos/MantleFramework/Mantle/pulls/242","id":12584027,"html_url":"https://github.com/MantleFramework/Mantle/pull/242","diff_url":"https://github.com/MantleFramework/Mantle/pull/242.diff","patch_url":"https://github.com/MantleFramework/Mantle/pull/242.patch","issue_url":"https://api.github.com/repos/MantleFramework/Mantle/issues/242","number":242,"state":"open","title":"Property types validation","user":{"login":"zats","id":2688806,"avatar_url":"https://gravatar.com/avatar/ad517694a3a4a6c179ad5586f7466f8e?d=https%3A%2F%2Fidenticons.github.com%2F6fd762f6f551ea1e13e01bf9ca285618.png&r=x","gravatar_id":"ad517694a3a4a6c179ad5586f7466f8e","url":"https://api.github.com/users/zats","html_url":"https://github.com/zats","followers_url":"https://api.github.com/users/zats/followers","following_url":"https://api.github.com/users/zats/following{/other_user}","gists_url":"https://api.github.com/users/zats/gists{/gist_id}","starred_url":"https://api.github.com/users/zats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zats/subscriptions","organizations_url":"https://api.github.com/users/zats/orgs","repos_url":"https://api.github.com/users/zats/repos","events_url":"https://api.github.com/users/zats/events{/privacy}","received_events_url":"https://api.github.com/users/zats/received_events","type":"User","site_admin":false},"body":"When parsing model and you get an incorrect value type, you want to fail immediately rather than crashing at some random point during runtime with \"does not respond to a selector\".\r\nIf general idea seems valid, I'd like to hear opinions on several questions:\r\n* Being able to specify `MTLParsingOptions` to be able to adjust behavior when validation fails: i.e. desired behavior might include failing immediately and returning `nil` as a result of parsing or just skipping the property in continue parsing.\r\n* Adding api for `MTLValueTransformer` allowing to return a validation error if needed (I think I saw something similar in one of the branches)\r\n\r\nLooking forward for a feedback!","created_at":"2014-02-15T15:29:50Z","updated_at":"2014-02-15T15:29:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MantleFramework/Mantle/pulls/242/commits","review_comments_url":"https://api.github.com/repos/MantleFramework/Mantle/pulls/242/comments","review_comment_url":"https://api.github.com/repos/MantleFramework/Mantle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MantleFramework/Mantle/issues/242/comments","statuses_url":"https://api.github.com/repos/MantleFramework/Mantle/statuses/e6969c4e59e12dfff5545668dda4df760d79069f","head":{"label":"zats:property-types-validation","ref":"property-types-validation","sha":"e6969c4e59e12dfff5545668dda4df760d79069f","user":{"login":"zats","id":2688806,"avatar_url":"https://gravatar.com/avatar/ad517694a3a4a6c179ad5586f7466f8e?d=https%3A%2F%2Fidenticons.github.com%2F6fd762f6f551ea1e13e01bf9ca285618.png&r=x","gravatar_id":"ad517694a3a4a6c179ad5586f7466f8e","url":"https://api.github.com/users/zats","html_url":"https://github.com/zats","followers_url":"https://api.github.com/users/zats/followers","following_url":"https://api.github.com/users/zats/following{/other_user}","gists_url":"https://api.github.com/users/zats/gists{/gist_id}","starred_url":"https://api.github.com/users/zats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zats/subscriptions","organizations_url":"https://api.github.com/users/zats/orgs","repos_url":"https://api.github.com/users/zats/repos","events_url":"https://api.github.com/users/zats/events{/privacy}","received_events_url":"https://api.github.com/users/zats/received_events","type":"User","site_admin":false},"repo":{"id":16842294,"name":"Mantle","full_name":"zats/Mantle","owner":{"login":"zats","id":2688806,"avatar_url":"https://gravatar.com/avatar/ad517694a3a4a6c179ad5586f7466f8e?d=https%3A%2F%2Fidenticons.github.com%2F6fd762f6f551ea1e13e01bf9ca285618.png&r=x","gravatar_id":"ad517694a3a4a6c179ad5586f7466f8e","url":"https://api.github.com/users/zats","html_url":"https://github.com/zats","followers_url":"https://api.github.com/users/zats/followers","following_url":"https://api.github.com/users/zats/following{/other_user}","gists_url":"https://api.github.com/users/zats/gists{/gist_id}","starred_url":"https://api.github.com/users/zats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zats/subscriptions","organizations_url":"https://api.github.com/users/zats/orgs","repos_url":"https://api.github.com/users/zats/repos","events_url":"https://api.github.com/users/zats/events{/privacy}","received_events_url":"https://api.github.com/users/zats/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zats/Mantle","description":"Model framework for Cocoa and Cocoa Touch","fork":true,"url":"https://api.github.com/repos/zats/Mantle","forks_url":"https://api.github.com/repos/zats/Mantle/forks","keys_url":"https://api.github.com/repos/zats/Mantle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zats/Mantle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zats/Mantle/teams","hooks_url":"https://api.github.com/repos/zats/Mantle/hooks","issue_events_url":"https://api.github.com/repos/zats/Mantle/issues/events{/number}","events_url":"https://api.github.com/repos/zats/Mantle/events","assignees_url":"https://api.github.com/repos/zats/Mantle/assignees{/user}","branches_url":"https://api.github.com/repos/zats/Mantle/branches{/branch}","tags_url":"https://api.github.com/repos/zats/Mantle/tags","blobs_url":"https://api.github.com/repos/zats/Mantle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zats/Mantle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zats/Mantle/git/refs{/sha}","trees_url":"https://api.github.com/repos/zats/Mantle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zats/Mantle/statuses/{sha}","languages_url":"https://api.github.com/repos/zats/Mantle/languages","stargazers_url":"https://api.github.com/repos/zats/Mantle/stargazers","contributors_url":"https://api.github.com/repos/zats/Mantle/contributors","subscribers_url":"https://api.github.com/repos/zats/Mantle/subscribers","subscription_url":"https://api.github.com/repos/zats/Mantle/subscription","commits_url":"https://api.github.com/repos/zats/Mantle/commits{/sha}","git_commits_url":"https://api.github.com/repos/zats/Mantle/git/commits{/sha}","comments_url":"https://api.github.com/repos/zats/Mantle/comments{/number}","issue_comment_url":"https://api.github.com/repos/zats/Mantle/issues/comments/{number}","contents_url":"https://api.github.com/repos/zats/Mantle/contents/{+path}","compare_url":"https://api.github.com/repos/zats/Mantle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zats/Mantle/merges","archive_url":"https://api.github.com/repos/zats/Mantle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zats/Mantle/downloads","issues_url":"https://api.github.com/repos/zats/Mantle/issues{/number}","pulls_url":"https://api.github.com/repos/zats/Mantle/pulls{/number}","milestones_url":"https://api.github.com/repos/zats/Mantle/milestones{/number}","notifications_url":"https://api.github.com/repos/zats/Mantle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zats/Mantle/labels{/name}","releases_url":"https://api.github.com/repos/zats/Mantle/releases{/id}","created_at":"2014-02-14T16:12:51Z","updated_at":"2014-02-15T15:29:50Z","pushed_at":"2014-02-15T14:05:26Z","git_url":"git://github.com/zats/Mantle.git","ssh_url":"git@github.com:zats/Mantle.git","clone_url":"https://github.com/zats/Mantle.git","svn_url":"https://github.com/zats/Mantle","homepage":"","size":2890,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"MantleFramework:master","ref":"master","sha":"c70543576b3d2d1bd9d534df9e6e16d462b38cc6","user":{"login":"MantleFramework","id":6173471,"avatar_url":"https://gravatar.com/avatar/8a086ba07c250613883db47b0a4b6113?d=https%3A%2F%2Fidenticons.github.com%2Fb70bf8a5b52eed1b12085d5a5e02694c.png&r=x","gravatar_id":"8a086ba07c250613883db47b0a4b6113","url":"https://api.github.com/users/MantleFramework","html_url":"https://github.com/MantleFramework","followers_url":"https://api.github.com/users/MantleFramework/followers","following_url":"https://api.github.com/users/MantleFramework/following{/other_user}","gists_url":"https://api.github.com/users/MantleFramework/gists{/gist_id}","starred_url":"https://api.github.com/users/MantleFramework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MantleFramework/subscriptions","organizations_url":"https://api.github.com/users/MantleFramework/orgs","repos_url":"https://api.github.com/users/MantleFramework/repos","events_url":"https://api.github.com/users/MantleFramework/events{/privacy}","received_events_url":"https://api.github.com/users/MantleFramework/received_events","type":"Organization","site_admin":false},"repo":{"id":5683364,"name":"Mantle","full_name":"MantleFramework/Mantle","owner":{"login":"MantleFramework","id":6173471,"avatar_url":"https://gravatar.com/avatar/8a086ba07c250613883db47b0a4b6113?d=https%3A%2F%2Fidenticons.github.com%2Fb70bf8a5b52eed1b12085d5a5e02694c.png&r=x","gravatar_id":"8a086ba07c250613883db47b0a4b6113","url":"https://api.github.com/users/MantleFramework","html_url":"https://github.com/MantleFramework","followers_url":"https://api.github.com/users/MantleFramework/followers","following_url":"https://api.github.com/users/MantleFramework/following{/other_user}","gists_url":"https://api.github.com/users/MantleFramework/gists{/gist_id}","starred_url":"https://api.github.com/users/MantleFramework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MantleFramework/subscriptions","organizations_url":"https://api.github.com/users/MantleFramework/orgs","repos_url":"https://api.github.com/users/MantleFramework/repos","events_url":"https://api.github.com/users/MantleFramework/events{/privacy}","received_events_url":"https://api.github.com/users/MantleFramework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MantleFramework/Mantle","description":"Model framework for Cocoa and Cocoa Touch","fork":false,"url":"https://api.github.com/repos/MantleFramework/Mantle","forks_url":"https://api.github.com/repos/MantleFramework/Mantle/forks","keys_url":"https://api.github.com/repos/MantleFramework/Mantle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MantleFramework/Mantle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MantleFramework/Mantle/teams","hooks_url":"https://api.github.com/repos/MantleFramework/Mantle/hooks","issue_events_url":"https://api.github.com/repos/MantleFramework/Mantle/issues/events{/number}","events_url":"https://api.github.com/repos/MantleFramework/Mantle/events","assignees_url":"https://api.github.com/repos/MantleFramework/Mantle/assignees{/user}","branches_url":"https://api.github.com/repos/MantleFramework/Mantle/branches{/branch}","tags_url":"https://api.github.com/repos/MantleFramework/Mantle/tags","blobs_url":"https://api.github.com/repos/MantleFramework/Mantle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MantleFramework/Mantle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MantleFramework/Mantle/git/refs{/sha}","trees_url":"https://api.github.com/repos/MantleFramework/Mantle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MantleFramework/Mantle/statuses/{sha}","languages_url":"https://api.github.com/repos/MantleFramework/Mantle/languages","stargazers_url":"https://api.github.com/repos/MantleFramework/Mantle/stargazers","contributors_url":"https://api.github.com/repos/MantleFramework/Mantle/contributors","subscribers_url":"https://api.github.com/repos/MantleFramework/Mantle/subscribers","subscription_url":"https://api.github.com/repos/MantleFramework/Mantle/subscription","commits_url":"https://api.github.com/repos/MantleFramework/Mantle/commits{/sha}","git_commits_url":"https://api.github.com/repos/MantleFramework/Mantle/git/commits{/sha}","comments_url":"https://api.github.com/repos/MantleFramework/Mantle/comments{/number}","issue_comment_url":"https://api.github.com/repos/MantleFramework/Mantle/issues/comments/{number}","contents_url":"https://api.github.com/repos/MantleFramework/Mantle/contents/{+path}","compare_url":"https://api.github.com/repos/MantleFramework/Mantle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MantleFramework/Mantle/merges","archive_url":"https://api.github.com/repos/MantleFramework/Mantle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MantleFramework/Mantle/downloads","issues_url":"https://api.github.com/repos/MantleFramework/Mantle/issues{/number}","pulls_url":"https://api.github.com/repos/MantleFramework/Mantle/pulls{/number}","milestones_url":"https://api.github.com/repos/MantleFramework/Mantle/milestones{/number}","notifications_url":"https://api.github.com/repos/MantleFramework/Mantle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MantleFramework/Mantle/labels{/name}","releases_url":"https://api.github.com/repos/MantleFramework/Mantle/releases{/id}","created_at":"2012-09-05T06:24:59Z","updated_at":"2014-02-14T20:26:33Z","pushed_at":"2014-02-14T20:26:31Z","git_url":"git://github.com/MantleFramework/Mantle.git","ssh_url":"git@github.com:MantleFramework/Mantle.git","clone_url":"https://github.com/MantleFramework/Mantle.git","svn_url":"https://github.com/MantleFramework/Mantle","homepage":"","size":2890,"stargazers_count":2600,"watchers_count":2600,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":211,"mirror_url":null,"open_issues_count":16,"forks":211,"open_issues":16,"watchers":2600,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MantleFramework/Mantle/pulls/242"},"html":{"href":"https://github.com/MantleFramework/Mantle/pull/242"},"issue":{"href":"https://api.github.com/repos/MantleFramework/Mantle/issues/242"},"comments":{"href":"https://api.github.com/repos/MantleFramework/Mantle/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/MantleFramework/Mantle/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/MantleFramework/Mantle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MantleFramework/Mantle/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/MantleFramework/Mantle/statuses/e6969c4e59e12dfff5545668dda4df760d79069f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":296,"deletions":10,"changed_files":9}}