GitHub PullRequestEvent at 2014-05-02 14:35:52
Repository: vim-slime
Actor: jpalardy
Payload: {"action":"closed","number":53,"pull_request":{"url":"https://api.github.com/repos/jpalardy/vim-slime/pulls/53","id":15432059,"html_url":"https://github.com/jpalardy/vim-slime/pull/53","diff_url":"https://github.com/jpalardy/vim-slime/pull/53.diff","patch_url":"https://github.com/jpalardy/vim-slime/pull/53.patch","issue_url":"https://api.github.com/repos/jpalardy/vim-slime/issues/53","number":53,"state":"closed","title":"Haskell fixes","user":{"login":"jdiez17","id":251900,"avatar_url":"https://avatars.githubusercontent.com/u/251900?","gravatar_id":"565b53be39a3bcdb07c2018318817dee","url":"https://api.github.com/users/jdiez17","html_url":"https://github.com/jdiez17","followers_url":"https://api.github.com/users/jdiez17/followers","following_url":"https://api.github.com/users/jdiez17/following{/other_user}","gists_url":"https://api.github.com/users/jdiez17/gists{/gist_id}","starred_url":"https://api.github.com/users/jdiez17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdiez17/subscriptions","organizations_url":"https://api.github.com/users/jdiez17/orgs","repos_url":"https://api.github.com/users/jdiez17/repos","events_url":"https://api.github.com/users/jdiez17/events{/privacy}","received_events_url":"https://api.github.com/users/jdiez17/received_events","type":"User","site_admin":false},"body":"Added support for function guards and `where` clauses. \r\n\r\nThe following code: \r\n\r\n    initials :: String -> String -> String\r\n    initials first last = \"Mr. \" ++ [f, l]\r\n        where (f:_) = first\r\n              (l:_) = last\r\n\r\n    maximum' :: (Ord a) => [a] -> a\r\n    maximum' []       = error \"Empty list\"\r\n    maximum' (x:[])   = x\r\n    maximum' (x:xs)  \r\n        | x > y     = x\r\n        | otherwise = y\r\n        where y = maximum' xs\r\n\r\nProduced these commands, before the fix:\r\n\r\n    :{\r\n    let initials :: String -> String -> String\r\n        initials first last = \"Mr. \" ++ [f, l]\r\n        where (f:_) = first\r\n              (l:_) = last\r\n        \r\n        maximum' :: (Ord a) => [a] -> a\r\n        maximum' []       = error \"Empty list\"\r\n        maximum' (x:[])   = x\r\n        maximum' (x:xs)  \r\n        | x > y     = x\r\n        | otherwise = y\r\n        where y = maximum' xs\r\n    :}\r\n\r\nAnd after the fix:\r\n\r\n    :{\r\n    let initials :: String -> String -> String\r\n        initials first last = \"Mr. \" ++ [f, l]\r\n            where (f:_) = first\r\n                  (l:_) = last\r\n        \r\n        maximum' :: (Ord a) => [a] -> a\r\n        maximum' []       = error \"Empty list\"\r\n        maximum' (x:[])   = x\r\n        maximum' (x:xs)  \r\n            | x > y     = x\r\n            | otherwise = y\r\n            where y = maximum' xs\r\n    :}\r\n","created_at":"2014-05-02T13:54:11Z","updated_at":"2014-05-02T14:35:51Z","closed_at":"2014-05-02T14:35:51Z","merged_at":"2014-05-02T14:35:51Z","merge_commit_sha":"53346bbda377c0dd259949c9dc2bd18fa18db535","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jpalardy/vim-slime/pulls/53/commits","review_comments_url":"https://api.github.com/repos/jpalardy/vim-slime/pulls/53/comments","review_comment_url":"https://api.github.com/repos/jpalardy/vim-slime/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jpalardy/vim-slime/issues/53/comments","statuses_url":"https://api.github.com/repos/jpalardy/vim-slime/statuses/a851249f529613e93eb3676584c287f798a1b686","head":{"label":"jdiez17:haskell_fixes","ref":"haskell_fixes","sha":"a851249f529613e93eb3676584c287f798a1b686","user":{"login":"jdiez17","id":251900,"avatar_url":"https://avatars.githubusercontent.com/u/251900?","gravatar_id":"565b53be39a3bcdb07c2018318817dee","url":"https://api.github.com/users/jdiez17","html_url":"https://github.com/jdiez17","followers_url":"https://api.github.com/users/jdiez17/followers","following_url":"https://api.github.com/users/jdiez17/following{/other_user}","gists_url":"https://api.github.com/users/jdiez17/gists{/gist_id}","starred_url":"https://api.github.com/users/jdiez17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdiez17/subscriptions","organizations_url":"https://api.github.com/users/jdiez17/orgs","repos_url":"https://api.github.com/users/jdiez17/repos","events_url":"https://api.github.com/users/jdiez17/events{/privacy}","received_events_url":"https://api.github.com/users/jdiez17/received_events","type":"User","site_admin":false},"repo":{"id":19375875,"name":"vim-slime","full_name":"jdiez17/vim-slime","owner":{"login":"jdiez17","id":251900,"avatar_url":"https://avatars.githubusercontent.com/u/251900?","gravatar_id":"565b53be39a3bcdb07c2018318817dee","url":"https://api.github.com/users/jdiez17","html_url":"https://github.com/jdiez17","followers_url":"https://api.github.com/users/jdiez17/followers","following_url":"https://api.github.com/users/jdiez17/following{/other_user}","gists_url":"https://api.github.com/users/jdiez17/gists{/gist_id}","starred_url":"https://api.github.com/users/jdiez17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdiez17/subscriptions","organizations_url":"https://api.github.com/users/jdiez17/orgs","repos_url":"https://api.github.com/users/jdiez17/repos","events_url":"https://api.github.com/users/jdiez17/events{/privacy}","received_events_url":"https://api.github.com/users/jdiez17/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdiez17/vim-slime","description":"A vim plugin to give you some slime. (Emacs)","fork":true,"url":"https://api.github.com/repos/jdiez17/vim-slime","forks_url":"https://api.github.com/repos/jdiez17/vim-slime/forks","keys_url":"https://api.github.com/repos/jdiez17/vim-slime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdiez17/vim-slime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdiez17/vim-slime/teams","hooks_url":"https://api.github.com/repos/jdiez17/vim-slime/hooks","issue_events_url":"https://api.github.com/repos/jdiez17/vim-slime/issues/events{/number}","events_url":"https://api.github.com/repos/jdiez17/vim-slime/events","assignees_url":"https://api.github.com/repos/jdiez17/vim-slime/assignees{/user}","branches_url":"https://api.github.com/repos/jdiez17/vim-slime/branches{/branch}","tags_url":"https://api.github.com/repos/jdiez17/vim-slime/tags","blobs_url":"https://api.github.com/repos/jdiez17/vim-slime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdiez17/vim-slime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdiez17/vim-slime/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdiez17/vim-slime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdiez17/vim-slime/statuses/{sha}","languages_url":"https://api.github.com/repos/jdiez17/vim-slime/languages","stargazers_url":"https://api.github.com/repos/jdiez17/vim-slime/stargazers","contributors_url":"https://api.github.com/repos/jdiez17/vim-slime/contributors","subscribers_url":"https://api.github.com/repos/jdiez17/vim-slime/subscribers","subscription_url":"https://api.github.com/repos/jdiez17/vim-slime/subscription","commits_url":"https://api.github.com/repos/jdiez17/vim-slime/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdiez17/vim-slime/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdiez17/vim-slime/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdiez17/vim-slime/issues/comments/{number}","contents_url":"https://api.github.com/repos/jdiez17/vim-slime/contents/{+path}","compare_url":"https://api.github.com/repos/jdiez17/vim-slime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdiez17/vim-slime/merges","archive_url":"https://api.github.com/repos/jdiez17/vim-slime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdiez17/vim-slime/downloads","issues_url":"https://api.github.com/repos/jdiez17/vim-slime/issues{/number}","pulls_url":"https://api.github.com/repos/jdiez17/vim-slime/pulls{/number}","milestones_url":"https://api.github.com/repos/jdiez17/vim-slime/milestones{/number}","notifications_url":"https://api.github.com/repos/jdiez17/vim-slime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdiez17/vim-slime/labels{/name}","releases_url":"https://api.github.com/repos/jdiez17/vim-slime/releases{/id}","created_at":"2014-05-02T13:20:07Z","updated_at":"2014-05-02T14:35:51Z","pushed_at":"2014-05-02T13:29:43Z","git_url":"git://github.com/jdiez17/vim-slime.git","ssh_url":"git@github.com:jdiez17/vim-slime.git","clone_url":"https://github.com/jdiez17/vim-slime.git","svn_url":"https://github.com/jdiez17/vim-slime","homepage":"http://technotales.wordpress.com/2007/10/03/like-slime-for-vim/","size":147,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jpalardy:master","ref":"master","sha":"dc614e65eb86cadbf49b4f2f04998ceb9d21d890","user":{"login":"jpalardy","id":18142,"avatar_url":"https://avatars.githubusercontent.com/u/18142?","gravatar_id":"ecfd1bdc5d3aab1e40f25658817712ba","url":"https://api.github.com/users/jpalardy","html_url":"https://github.com/jpalardy","followers_url":"https://api.github.com/users/jpalardy/followers","following_url":"https://api.github.com/users/jpalardy/following{/other_user}","gists_url":"https://api.github.com/users/jpalardy/gists{/gist_id}","starred_url":"https://api.github.com/users/jpalardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpalardy/subscriptions","organizations_url":"https://api.github.com/users/jpalardy/orgs","repos_url":"https://api.github.com/users/jpalardy/repos","events_url":"https://api.github.com/users/jpalardy/events{/privacy}","received_events_url":"https://api.github.com/users/jpalardy/received_events","type":"User","site_admin":false},"repo":{"id":1326806,"name":"vim-slime","full_name":"jpalardy/vim-slime","owner":{"login":"jpalardy","id":18142,"avatar_url":"https://avatars.githubusercontent.com/u/18142?","gravatar_id":"ecfd1bdc5d3aab1e40f25658817712ba","url":"https://api.github.com/users/jpalardy","html_url":"https://github.com/jpalardy","followers_url":"https://api.github.com/users/jpalardy/followers","following_url":"https://api.github.com/users/jpalardy/following{/other_user}","gists_url":"https://api.github.com/users/jpalardy/gists{/gist_id}","starred_url":"https://api.github.com/users/jpalardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpalardy/subscriptions","organizations_url":"https://api.github.com/users/jpalardy/orgs","repos_url":"https://api.github.com/users/jpalardy/repos","events_url":"https://api.github.com/users/jpalardy/events{/privacy}","received_events_url":"https://api.github.com/users/jpalardy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpalardy/vim-slime","description":"A vim plugin to give you some slime. (Emacs)","fork":false,"url":"https://api.github.com/repos/jpalardy/vim-slime","forks_url":"https://api.github.com/repos/jpalardy/vim-slime/forks","keys_url":"https://api.github.com/repos/jpalardy/vim-slime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpalardy/vim-slime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpalardy/vim-slime/teams","hooks_url":"https://api.github.com/repos/jpalardy/vim-slime/hooks","issue_events_url":"https://api.github.com/repos/jpalardy/vim-slime/issues/events{/number}","events_url":"https://api.github.com/repos/jpalardy/vim-slime/events","assignees_url":"https://api.github.com/repos/jpalardy/vim-slime/assignees{/user}","branches_url":"https://api.github.com/repos/jpalardy/vim-slime/branches{/branch}","tags_url":"https://api.github.com/repos/jpalardy/vim-slime/tags","blobs_url":"https://api.github.com/repos/jpalardy/vim-slime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpalardy/vim-slime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpalardy/vim-slime/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpalardy/vim-slime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpalardy/vim-slime/statuses/{sha}","languages_url":"https://api.github.com/repos/jpalardy/vim-slime/languages","stargazers_url":"https://api.github.com/repos/jpalardy/vim-slime/stargazers","contributors_url":"https://api.github.com/repos/jpalardy/vim-slime/contributors","subscribers_url":"https://api.github.com/repos/jpalardy/vim-slime/subscribers","subscription_url":"https://api.github.com/repos/jpalardy/vim-slime/subscription","commits_url":"https://api.github.com/repos/jpalardy/vim-slime/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpalardy/vim-slime/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpalardy/vim-slime/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpalardy/vim-slime/issues/comments/{number}","contents_url":"https://api.github.com/repos/jpalardy/vim-slime/contents/{+path}","compare_url":"https://api.github.com/repos/jpalardy/vim-slime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpalardy/vim-slime/merges","archive_url":"https://api.github.com/repos/jpalardy/vim-slime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpalardy/vim-slime/downloads","issues_url":"https://api.github.com/repos/jpalardy/vim-slime/issues{/number}","pulls_url":"https://api.github.com/repos/jpalardy/vim-slime/pulls{/number}","milestones_url":"https://api.github.com/repos/jpalardy/vim-slime/milestones{/number}","notifications_url":"https://api.github.com/repos/jpalardy/vim-slime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpalardy/vim-slime/labels{/name}","releases_url":"https://api.github.com/repos/jpalardy/vim-slime/releases{/id}","created_at":"2011-02-04T03:42:59Z","updated_at":"2014-05-02T14:35:51Z","pushed_at":"2014-05-02T14:35:51Z","git_url":"git://github.com/jpalardy/vim-slime.git","ssh_url":"git@github.com:jpalardy/vim-slime.git","clone_url":"https://github.com/jpalardy/vim-slime.git","svn_url":"https://github.com/jpalardy/vim-slime","homepage":"http://technotales.wordpress.com/2007/10/03/like-slime-for-vim/","size":253,"stargazers_count":322,"watchers_count":322,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":45,"mirror_url":null,"open_issues_count":2,"forks":45,"open_issues":2,"watchers":322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jpalardy/vim-slime/pulls/53"},"html":{"href":"https://github.com/jpalardy/vim-slime/pull/53"},"issue":{"href":"https://api.github.com/repos/jpalardy/vim-slime/issues/53"},"comments":{"href":"https://api.github.com/repos/jpalardy/vim-slime/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/jpalardy/vim-slime/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/jpalardy/vim-slime/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jpalardy/vim-slime/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/jpalardy/vim-slime/statuses/a851249f529613e93eb3676584c287f798a1b686"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jpalardy","id":18142,"avatar_url":"https://avatars.githubusercontent.com/u/18142?","gravatar_id":"ecfd1bdc5d3aab1e40f25658817712ba","url":"https://api.github.com/users/jpalardy","html_url":"https://github.com/jpalardy","followers_url":"https://api.github.com/users/jpalardy/followers","following_url":"https://api.github.com/users/jpalardy/following{/other_user}","gists_url":"https://api.github.com/users/jpalardy/gists{/gist_id}","starred_url":"https://api.github.com/users/jpalardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpalardy/subscriptions","organizations_url":"https://api.github.com/users/jpalardy/orgs","repos_url":"https://api.github.com/users/jpalardy/repos","events_url":"https://api.github.com/users/jpalardy/events{/privacy}","received_events_url":"https://api.github.com/users/jpalardy/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":6,"deletions":1,"changed_files":1}}