GitHub PullRequestReviewCommentEvent at 2014-10-23 09:04:27
Repository: frontend
Actor: austinh7
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/19266071","id":19266071,"diff_hunk":"@@ -1,42 +1,63 @@\n-@(items: Seq[model.Content])(implicit request: RequestHeader)\n+@(items: Seq[model.Content], optLogo: Option[String], optCapiTitle: Option[String], optCapiLink: Option[String], optCapiAbout: Option[String])(implicit request: RequestHeader)\n \n @defining((\"1_0\", \"2014-08-14\")) { case (version, date) =>\n-    <div class=\"commercial commercial--low commercial--capi\">\n+    <section class=\"container container--special container--merchandising container--advertisement-feature container--commercial-capi\">\n         <div class=\"facia-container__inner\">\n-            <div class=\"container__title commercial__head\">\n-                <h3 class=\"commercial__title\">\n-                    The Guardian\n+        <div class=\"container__border tone-news tone-accent-border\"></div>\n+            <div class=\"container__header\">\n+                <h2 class=\"container__title tone-news\">\n+                    <span class=\"container__title__label u-text-hyphenate\">@for(titleText <- optCapiTitle) {@titleText}</span>\n                 </h3>\n             </div>\n-            <div class=\"container__body commercial__body\">\n-                <ul class=\"lineitems\">\n-                    @for(item <- items) {\n-                        <li class=\"lineitem\">\n-                            <a class=\"lineitem__link\" href=\"@AdLink{@item.webUrl}\" data-link-name=\"merchandising-capi-v@{version}_@{date}-@item.webTitle\">\n-                                @item.mainPicture.map{ picture =>\n-                                    @Item300.bestFor(picture).map{ url => <img src=\"@url\" alt=\"\" class=\"lineitem__image\" /> }\n-                                }\n-                                <div class=\"lineitem__offer\">\n-                                    <h4 class=\"lineitem__title\">@item.webTitle</h4>\n-                                    <div class=\"item__meta\">\n-                                        <time\n-                                            class=\"item__timestamp js-item__timestamp\"\n-                                            datetime=\"@item.webPublicationDate.toString(\"yyyy-MM-dd'T'HH:mm:ssZ\")\"\n-                                            data-timestamp=\"@item.webPublicationDate.getMillis\"\n-                                            data-relativeformat=\"short\">\n-                                            <i class=\"i i-clock-light-grey\"></i>\n-                                            <span class=\"timestamp__text\">\n-                                                <span class=\"u-h\">Published: </span>\n-                                                @Format(item.webPublicationDate, \"d MMM y\")\n-                                            </span>\n-                                        </time>\n+            <div class=\"ad-slot--adbadge ad-slot--paid-for-badge ad-slot--paid-for-badge--front\">\n+                <div class=\"ad-slot--paid-for-badge__inner\">","path":"commercial/app/views/contentapi/items.scala.html","position":40,"original_position":40,"commit_id":"b0104bc4e2f6577aece578cfaf6db1d8cadf0a47","original_commit_id":"b0104bc4e2f6577aece578cfaf6db1d8cadf0a47","user":{"login":"austinh7","id":1303616,"avatar_url":"https://avatars.githubusercontent.com/u/1303616?v=2","gravatar_id":"","url":"https://api.github.com/users/austinh7","html_url":"https://github.com/austinh7","followers_url":"https://api.github.com/users/austinh7/followers","following_url":"https://api.github.com/users/austinh7/following{/other_user}","gists_url":"https://api.github.com/users/austinh7/gists{/gist_id}","starred_url":"https://api.github.com/users/austinh7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinh7/subscriptions","organizations_url":"https://api.github.com/users/austinh7/orgs","repos_url":"https://api.github.com/users/austinh7/repos","events_url":"https://api.github.com/users/austinh7/events{/privacy}","received_events_url":"https://api.github.com/users/austinh7/received_events","type":"User","site_admin":false},"body":"This is a direct copy of a component that already exists, I'll get this one out and then look at updating them both at the same time.","created_at":"2014-10-23T09:04:27Z","updated_at":"2014-10-23T09:04:27Z","html_url":"https://github.com/guardian/frontend/pull/6648#discussion_r19266071","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/6648","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/19266071"},"html":{"href":"https://github.com/guardian/frontend/pull/6648#discussion_r19266071"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6648"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/6648","id":23096827,"html_url":"https://github.com/guardian/frontend/pull/6648","diff_url":"https://github.com/guardian/frontend/pull/6648.diff","patch_url":"https://github.com/guardian/frontend/pull/6648.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/6648","number":6648,"state":"open","locked":false,"title":"Commercial component, from DFP using capi and image","user":{"login":"austinh7","id":1303616,"avatar_url":"https://avatars.githubusercontent.com/u/1303616?v=2","gravatar_id":"","url":"https://api.github.com/users/austinh7","html_url":"https://github.com/austinh7","followers_url":"https://api.github.com/users/austinh7/followers","following_url":"https://api.github.com/users/austinh7/following{/other_user}","gists_url":"https://api.github.com/users/austinh7/gists{/gist_id}","starred_url":"https://api.github.com/users/austinh7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinh7/subscriptions","organizations_url":"https://api.github.com/users/austinh7/orgs","repos_url":"https://api.github.com/users/austinh7/repos","events_url":"https://api.github.com/users/austinh7/events{/privacy}","received_events_url":"https://api.github.com/users/austinh7/received_events","type":"User","site_admin":false},"body":"This creates a commercial component that is created in DFP via a template and then uses the CAPI to pull in the articles. The compoennt title, \"bought to you by\" logo, logo link and \"about this content\" link are also passed through from DFP.\r\n\r\nUses code from special container and so has lovely flex-box stuff going on.\r\n\r\ncc @kenlim for the Scala stuff.\r\n\r\n![screen shot 2014-10-21 at 16 56 09](https://cloud.githubusercontent.com/assets/1303616/4721831/401ed8b2-593b-11e4-8458-24b22942c332.png)\r\n","created_at":"2014-10-21T16:00:23Z","updated_at":"2014-10-23T09:04:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0aea26830c43d2de498879d09e33a5b467d3ca4a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/6648/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/6648/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/6648/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/b0104bc4e2f6577aece578cfaf6db1d8cadf0a47","head":{"label":"guardian:commercial-capi-image","ref":"commercial-capi-image","sha":"b0104bc4e2f6577aece578cfaf6db1d8cadf0a47","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-10-22T21:09:40Z","pushed_at":"2014-10-23T09:01:24Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":498166,"stargazers_count":2377,"watchers_count":2377,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":96,"forks":202,"open_issues":96,"watchers":2377,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"adcde10e40c208d213b67bc36d657c59960ca686","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-10-22T21:09:40Z","pushed_at":"2014-10-23T09:01:24Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":498166,"stargazers_count":2377,"watchers_count":2377,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":96,"forks":202,"open_issues":96,"watchers":2377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6648"},"html":{"href":"https://github.com/guardian/frontend/pull/6648"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/6648"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/6648/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6648/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6648/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/b0104bc4e2f6577aece578cfaf6db1d8cadf0a47"}}}}