GitHub PullRequestEvent at 2014-03-26 13:06:16
Repository: barclamp-cinder
Actor: vuntz
Payload: {"action":"closed","number":160,"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/160","id":13880444,"html_url":"https://github.com/crowbar/barclamp-cinder/pull/160","diff_url":"https://github.com/crowbar/barclamp-cinder/pull/160.diff","patch_url":"https://github.com/crowbar/barclamp-cinder/pull/160.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-cinder/issues/160","number":160,"state":"closed","title":"Update db password migration script to remove node attributes","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?","gravatar_id":"d7cc6451b64c4351e27db322d114d4aa","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"On update, we want to use the db password from the proposal / role, and\r\nnot the one that might have been generated on the node (through the\r\ncookbook). As the password is a \"normal\" attribute on the node, but a\r\n\"default\" attribute on the role, the old one from the node is used.\r\nWhich means we really need to remove it to get the new one used.\r\n\r\nTo minimize config changes, we actually import the password from one\r\nnode (which should be good enough in most cases as we allow only one\r\ncinder proposal, so only one node should have the password).","created_at":"2014-03-23T19:23:49Z","updated_at":"2014-03-26T13:06:16Z","closed_at":"2014-03-26T13:06:16Z","merged_at":"2014-03-26T13:06:16Z","merge_commit_sha":"f0fc08b98a9ffe1e9184a4f98cc477a7815e87d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/160/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/160/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-cinder/issues/160/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-cinder/statuses/326567539cfff5522bd09d5def5806353d92ac94","head":{"label":"vuntz:drop-db-node","ref":"drop-db-node","sha":"326567539cfff5522bd09d5def5806353d92ac94","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?","gravatar_id":"d7cc6451b64c4351e27db322d114d4aa","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"repo":{"id":10479489,"name":"barclamp-cinder","full_name":"vuntz/barclamp-cinder","owner":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?","gravatar_id":"d7cc6451b64c4351e27db322d114d4aa","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vuntz/barclamp-cinder","description":"","fork":true,"url":"https://api.github.com/repos/vuntz/barclamp-cinder","forks_url":"https://api.github.com/repos/vuntz/barclamp-cinder/forks","keys_url":"https://api.github.com/repos/vuntz/barclamp-cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuntz/barclamp-cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuntz/barclamp-cinder/teams","hooks_url":"https://api.github.com/repos/vuntz/barclamp-cinder/hooks","issue_events_url":"https://api.github.com/repos/vuntz/barclamp-cinder/issues/events{/number}","events_url":"https://api.github.com/repos/vuntz/barclamp-cinder/events","assignees_url":"https://api.github.com/repos/vuntz/barclamp-cinder/assignees{/user}","branches_url":"https://api.github.com/repos/vuntz/barclamp-cinder/branches{/branch}","tags_url":"https://api.github.com/repos/vuntz/barclamp-cinder/tags","blobs_url":"https://api.github.com/repos/vuntz/barclamp-cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuntz/barclamp-cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuntz/barclamp-cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuntz/barclamp-cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuntz/barclamp-cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/vuntz/barclamp-cinder/languages","stargazers_url":"https://api.github.com/repos/vuntz/barclamp-cinder/stargazers","contributors_url":"https://api.github.com/repos/vuntz/barclamp-cinder/contributors","subscribers_url":"https://api.github.com/repos/vuntz/barclamp-cinder/subscribers","subscription_url":"https://api.github.com/repos/vuntz/barclamp-cinder/subscription","commits_url":"https://api.github.com/repos/vuntz/barclamp-cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuntz/barclamp-cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuntz/barclamp-cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuntz/barclamp-cinder/issues/comments/{number}","contents_url":"https://api.github.com/repos/vuntz/barclamp-cinder/contents/{+path}","compare_url":"https://api.github.com/repos/vuntz/barclamp-cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuntz/barclamp-cinder/merges","archive_url":"https://api.github.com/repos/vuntz/barclamp-cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuntz/barclamp-cinder/downloads","issues_url":"https://api.github.com/repos/vuntz/barclamp-cinder/issues{/number}","pulls_url":"https://api.github.com/repos/vuntz/barclamp-cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/vuntz/barclamp-cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/vuntz/barclamp-cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuntz/barclamp-cinder/labels{/name}","releases_url":"https://api.github.com/repos/vuntz/barclamp-cinder/releases{/id}","created_at":"2013-06-04T13:41:30Z","updated_at":"2014-03-26T13:06:16Z","pushed_at":"2014-03-25T13:07:44Z","git_url":"git://github.com/vuntz/barclamp-cinder.git","ssh_url":"git@github.com:vuntz/barclamp-cinder.git","clone_url":"https://github.com/vuntz/barclamp-cinder.git","svn_url":"https://github.com/vuntz/barclamp-cinder","homepage":null,"size":1047,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"crowbar:release/roxy/master","ref":"release/roxy/master","sha":"d90457e5f6bd54cc67de9eff21a7e7fa3904e46a","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?","gravatar_id":"36825f9798aaf5d8795156f057fcf4a4","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":6161327,"name":"barclamp-cinder","full_name":"crowbar/barclamp-cinder","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?","gravatar_id":"36825f9798aaf5d8795156f057fcf4a4","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-cinder","description":"OpenStack Cinder: Block Storage component","fork":true,"url":"https://api.github.com/repos/crowbar/barclamp-cinder","forks_url":"https://api.github.com/repos/crowbar/barclamp-cinder/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-cinder/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-cinder/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-cinder/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-cinder/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-cinder/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-cinder/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-cinder/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-cinder/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-cinder/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-cinder/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-cinder/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-cinder/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-cinder/issues/comments/{number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-cinder/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-cinder/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-cinder/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-cinder/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-cinder/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-cinder/releases{/id}","created_at":"2012-10-10T17:32:14Z","updated_at":"2014-03-26T13:06:16Z","pushed_at":"2014-03-26T13:06:16Z","git_url":"git://github.com/crowbar/barclamp-cinder.git","ssh_url":"git@github.com:crowbar/barclamp-cinder.git","clone_url":"https://github.com/crowbar/barclamp-cinder.git","svn_url":"https://github.com/crowbar/barclamp-cinder","homepage":"https://github.com/crowbar/crowbar","size":2502,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":141,"mirror_url":null,"open_issues_count":9,"forks":141,"open_issues":9,"watchers":0,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/160"},"html":{"href":"https://github.com/crowbar/barclamp-cinder/pull/160"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/issues/160"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-cinder/statuses/326567539cfff5522bd09d5def5806353d92ac94"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?","gravatar_id":"d7cc6451b64c4351e27db322d114d4aa","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":20,"deletions":3,"changed_files":1}}