GitHub PullRequestReviewCommentEvent at 2014-11-21 15:26:40
Repository: spring-xd
Actor: ericbottard
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/20720591","id":20720591,"diff_hunk":"@@ -14,7 +14,7 @@\n \t<bean id=\"moduleRegistry\" class=\"org.springframework.xd.dirt.module.DelegatingModuleRegistry\">\n \t\t<constructor-arg>\n \t\t\t<list>\n-\t\t\t\t<bean class=\"org.springframework.xd.dirt.module.ResourceModuleRegistry\">\n+\t\t\t\t<bean class=\"org.springframework.xd.dirt.module.WriteCapableArchiveModuleRegistry\">\n \t\t\t\t\t<constructor-arg value=\"${xd.module.home}/\" />","path":"spring-xd-dirt/src/main/resources/META-INF/spring-xd/internal/repositories.xml","position":6,"original_position":6,"commit_id":"1ab4113fd7683cd0b6a0d6143dc7147d0ae0f22f","original_commit_id":"1ab4113fd7683cd0b6a0d6143dc7147d0ae0f22f","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"body":"Note that it is still used 6 lines below.","created_at":"2014-11-21T15:26:40Z","updated_at":"2014-11-21T15:26:40Z","html_url":"https://github.com/spring-projects/spring-xd/pull/1295#discussion_r20720591","pull_request_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1295","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/20720591"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1295#discussion_r20720591"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1295"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1295","id":24610541,"html_url":"https://github.com/spring-projects/spring-xd/pull/1295","diff_url":"https://github.com/spring-projects/spring-xd/pull/1295.diff","patch_url":"https://github.com/spring-projects/spring-xd/pull/1295.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1295","number":1295,"state":"open","locked":false,"title":"XD-2306: Ability to upload modules","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"body":"A new type of ModuleRegistry that supports saving uploaded modules.\r\nThe current behavior is for that registry to not allow deletion of modules which are in exploded form, which is a nice way of not allowing OOTB modules at the moment.\r\n\r\nAn alternative will be to use a different root folder for uploaded modules","created_at":"2014-11-18T13:24:09Z","updated_at":"2014-11-21T15:26:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab02ef0f636a9cc6653a8d36cecd70aa1af41664","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1295/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1295/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1295/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/1ab4113fd7683cd0b6a0d6143dc7147d0ae0f22f","head":{"label":"ericbottard:XD-2306","ref":"XD-2306","sha":"1ab4113fd7683cd0b6a0d6143dc7147d0ae0f22f","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"repo":{"id":10668513,"name":"spring-xd","full_name":"ericbottard/spring-xd","owner":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericbottard/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":true,"url":"https://api.github.com/repos/ericbottard/spring-xd","forks_url":"https://api.github.com/repos/ericbottard/spring-xd/forks","keys_url":"https://api.github.com/repos/ericbottard/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericbottard/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericbottard/spring-xd/teams","hooks_url":"https://api.github.com/repos/ericbottard/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/ericbottard/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/ericbottard/spring-xd/events","assignees_url":"https://api.github.com/repos/ericbottard/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/ericbottard/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/ericbottard/spring-xd/tags","blobs_url":"https://api.github.com/repos/ericbottard/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericbottard/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericbottard/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericbottard/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericbottard/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/ericbottard/spring-xd/languages","stargazers_url":"https://api.github.com/repos/ericbottard/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/ericbottard/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/ericbottard/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/ericbottard/spring-xd/subscription","commits_url":"https://api.github.com/repos/ericbottard/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericbottard/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericbottard/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericbottard/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/ericbottard/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/ericbottard/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericbottard/spring-xd/merges","archive_url":"https://api.github.com/repos/ericbottard/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericbottard/spring-xd/downloads","issues_url":"https://api.github.com/repos/ericbottard/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/ericbottard/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/ericbottard/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/ericbottard/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericbottard/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/ericbottard/spring-xd/releases{/id}","created_at":"2013-06-13T14:55:49Z","updated_at":"2014-10-09T13:33:28Z","pushed_at":"2014-11-20T13:39:00Z","git_url":"git://github.com/ericbottard/spring-xd.git","ssh_url":"git@github.com:ericbottard/spring-xd.git","clone_url":"https://github.com/ericbottard/spring-xd.git","svn_url":"https://github.com/ericbottard/spring-xd","homepage":null,"size":26760,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"5dd939d0c516b85f3354883dcb18e406d2a0a790","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":9349347,"name":"spring-xd","full_name":"spring-projects/spring-xd","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-xd","forks_url":"https://api.github.com/repos/spring-projects/spring-xd/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-xd/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-xd/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-xd/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-xd/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-xd/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/spring-projects/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-xd/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-xd/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-xd/releases{/id}","created_at":"2013-04-10T15:31:44Z","updated_at":"2014-11-21T05:23:48Z","pushed_at":"2014-11-20T15:04:12Z","git_url":"git://github.com/spring-projects/spring-xd.git","ssh_url":"git@github.com:spring-projects/spring-xd.git","clone_url":"https://github.com/spring-projects/spring-xd.git","svn_url":"https://github.com/spring-projects/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":82206,"stargazers_count":193,"watchers_count":193,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":163,"mirror_url":null,"open_issues_count":24,"forks":163,"open_issues":24,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1295"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1295"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1295"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1295/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1295/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1295/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-xd/statuses/1ab4113fd7683cd0b6a0d6143dc7147d0ae0f22f"}}}}