GitHub PullRequestEvent at 2014-02-03 20:48:09
Repository: missionhub
Actor: tavon
Payload: {"action":"opened","number":289,"pull_request":{"url":"https://api.github.com/repos/CruGlobal/missionhub/pulls/289","id":12150866,"html_url":"https://github.com/CruGlobal/missionhub/pull/289","diff_url":"https://github.com/CruGlobal/missionhub/pull/289.diff","patch_url":"https://github.com/CruGlobal/missionhub/pull/289.patch","issue_url":"https://api.github.com/repos/CruGlobal/missionhub/issues/289","number":289,"state":"open","title":"Redesign login page","user":{"login":"tavon","id":3383,"avatar_url":"https://gravatar.com/avatar/e968ae080b791ecadbb326ac04494193?d=https%3A%2F%2Fidenticons.github.com%2F0668e20b3c9e9185b04b3d2a9dc8fa2d.png&r=x","gravatar_id":"e968ae080b791ecadbb326ac04494193","url":"https://api.github.com/users/tavon","html_url":"https://github.com/tavon","followers_url":"https://api.github.com/users/tavon/followers","following_url":"https://api.github.com/users/tavon/following{/other_user}","gists_url":"https://api.github.com/users/tavon/gists{/gist_id}","starred_url":"https://api.github.com/users/tavon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavon/subscriptions","organizations_url":"https://api.github.com/users/tavon/orgs","repos_url":"https://api.github.com/users/tavon/repos","events_url":"https://api.github.com/users/tavon/events{/privacy}","received_events_url":"https://api.github.com/users/tavon/received_events","type":"User","site_admin":false},"body":"Resigned responsive login page.\r\n\r\nI am a little bit concerned regarding the survey related code.  The ```if mhub?``` and ```if @survey``` clauses make it difficult to refactor but also I'm not sure how to test this.  Seems like too much business logic in the view layer...  Would someone test if this works?\r\n\r\n![login-mobile](https://f.cloud.github.com/assets/3383/2069248/1342624e-8d14-11e3-82de-7b6d13d54a9d.png)\r\n![login-tablet](https://f.cloud.github.com/assets/3383/2069246/133d365c-8d14-11e3-8832-a3ef80ff3689.png)\r\n![login-widescreen](https://f.cloud.github.com/assets/3383/2069247/133e1342-8d14-11e3-9de3-c319c566d576.png)\r\n","created_at":"2014-02-03T20:48:09Z","updated_at":"2014-02-03T20:48:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CruGlobal/missionhub/pulls/289/commits","review_comments_url":"https://api.github.com/repos/CruGlobal/missionhub/pulls/289/comments","review_comment_url":"https://api.github.com/repos/CruGlobal/missionhub/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CruGlobal/missionhub/issues/289/comments","statuses_url":"https://api.github.com/repos/CruGlobal/missionhub/statuses/57c6b7cf38c69fc4f9b64a27a964094f598de234","head":{"label":"Lanio:login_redesign","ref":"login_redesign","sha":"57c6b7cf38c69fc4f9b64a27a964094f598de234","user":{"login":"Lanio","id":1161650,"avatar_url":"https://gravatar.com/avatar/c7b484409964fd7b2fc38d7c614f1c17?d=https%3A%2F%2Fidenticons.github.com%2Fdbf54893c9e452a084b7380e860fed1b.png&r=x","gravatar_id":"c7b484409964fd7b2fc38d7c614f1c17","url":"https://api.github.com/users/Lanio","html_url":"https://github.com/Lanio","followers_url":"https://api.github.com/users/Lanio/followers","following_url":"https://api.github.com/users/Lanio/following{/other_user}","gists_url":"https://api.github.com/users/Lanio/gists{/gist_id}","starred_url":"https://api.github.com/users/Lanio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lanio/subscriptions","organizations_url":"https://api.github.com/users/Lanio/orgs","repos_url":"https://api.github.com/users/Lanio/repos","events_url":"https://api.github.com/users/Lanio/events{/privacy}","received_events_url":"https://api.github.com/users/Lanio/received_events","type":"Organization","site_admin":false},"repo":{"id":15518972,"name":"missionhub","full_name":"Lanio/missionhub","owner":{"login":"Lanio","id":1161650,"avatar_url":"https://gravatar.com/avatar/c7b484409964fd7b2fc38d7c614f1c17?d=https%3A%2F%2Fidenticons.github.com%2Fdbf54893c9e452a084b7380e860fed1b.png&r=x","gravatar_id":"c7b484409964fd7b2fc38d7c614f1c17","url":"https://api.github.com/users/Lanio","html_url":"https://github.com/Lanio","followers_url":"https://api.github.com/users/Lanio/followers","following_url":"https://api.github.com/users/Lanio/following{/other_user}","gists_url":"https://api.github.com/users/Lanio/gists{/gist_id}","starred_url":"https://api.github.com/users/Lanio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lanio/subscriptions","organizations_url":"https://api.github.com/users/Lanio/orgs","repos_url":"https://api.github.com/users/Lanio/repos","events_url":"https://api.github.com/users/Lanio/events{/privacy}","received_events_url":"https://api.github.com/users/Lanio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lanio/missionhub","description":"","fork":true,"url":"https://api.github.com/repos/Lanio/missionhub","forks_url":"https://api.github.com/repos/Lanio/missionhub/forks","keys_url":"https://api.github.com/repos/Lanio/missionhub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lanio/missionhub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lanio/missionhub/teams","hooks_url":"https://api.github.com/repos/Lanio/missionhub/hooks","issue_events_url":"https://api.github.com/repos/Lanio/missionhub/issues/events{/number}","events_url":"https://api.github.com/repos/Lanio/missionhub/events","assignees_url":"https://api.github.com/repos/Lanio/missionhub/assignees{/user}","branches_url":"https://api.github.com/repos/Lanio/missionhub/branches{/branch}","tags_url":"https://api.github.com/repos/Lanio/missionhub/tags","blobs_url":"https://api.github.com/repos/Lanio/missionhub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lanio/missionhub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lanio/missionhub/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lanio/missionhub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lanio/missionhub/statuses/{sha}","languages_url":"https://api.github.com/repos/Lanio/missionhub/languages","stargazers_url":"https://api.github.com/repos/Lanio/missionhub/stargazers","contributors_url":"https://api.github.com/repos/Lanio/missionhub/contributors","subscribers_url":"https://api.github.com/repos/Lanio/missionhub/subscribers","subscription_url":"https://api.github.com/repos/Lanio/missionhub/subscription","commits_url":"https://api.github.com/repos/Lanio/missionhub/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lanio/missionhub/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lanio/missionhub/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lanio/missionhub/issues/comments/{number}","contents_url":"https://api.github.com/repos/Lanio/missionhub/contents/{+path}","compare_url":"https://api.github.com/repos/Lanio/missionhub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lanio/missionhub/merges","archive_url":"https://api.github.com/repos/Lanio/missionhub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lanio/missionhub/downloads","issues_url":"https://api.github.com/repos/Lanio/missionhub/issues{/number}","pulls_url":"https://api.github.com/repos/Lanio/missionhub/pulls{/number}","milestones_url":"https://api.github.com/repos/Lanio/missionhub/milestones{/number}","notifications_url":"https://api.github.com/repos/Lanio/missionhub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lanio/missionhub/labels{/name}","releases_url":"https://api.github.com/repos/Lanio/missionhub/releases{/id}","created_at":"2013-12-30T02:38:04Z","updated_at":"2014-02-03T20:48:09Z","pushed_at":"2014-02-03T20:44:22Z","git_url":"git://github.com/Lanio/missionhub.git","ssh_url":"git@github.com:Lanio/missionhub.git","clone_url":"https://github.com/Lanio/missionhub.git","svn_url":"https://github.com/Lanio/missionhub","homepage":null,"size":292154,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"CruGlobal:master","ref":"master","sha":"e6e9d2d0eb5b5e70c57c96b643ebc9ea7d311c3b","user":{"login":"CruGlobal","id":1785912,"avatar_url":"https://gravatar.com/avatar/fff0e4838db6e8e33d895977195fa2ce?d=https%3A%2F%2Fidenticons.github.com%2F8c6d1fef12573d3311f0b27fa20b1d38.png&r=x","gravatar_id":"fff0e4838db6e8e33d895977195fa2ce","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"repo":{"id":4740957,"name":"missionhub","full_name":"CruGlobal/missionhub","owner":{"login":"CruGlobal","id":1785912,"avatar_url":"https://gravatar.com/avatar/fff0e4838db6e8e33d895977195fa2ce?d=https%3A%2F%2Fidenticons.github.com%2F8c6d1fef12573d3311f0b27fa20b1d38.png&r=x","gravatar_id":"fff0e4838db6e8e33d895977195fa2ce","url":"https://api.github.com/users/CruGlobal","html_url":"https://github.com/CruGlobal","followers_url":"https://api.github.com/users/CruGlobal/followers","following_url":"https://api.github.com/users/CruGlobal/following{/other_user}","gists_url":"https://api.github.com/users/CruGlobal/gists{/gist_id}","starred_url":"https://api.github.com/users/CruGlobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CruGlobal/subscriptions","organizations_url":"https://api.github.com/users/CruGlobal/orgs","repos_url":"https://api.github.com/users/CruGlobal/repos","events_url":"https://api.github.com/users/CruGlobal/events{/privacy}","received_events_url":"https://api.github.com/users/CruGlobal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CruGlobal/missionhub","description":"","fork":false,"url":"https://api.github.com/repos/CruGlobal/missionhub","forks_url":"https://api.github.com/repos/CruGlobal/missionhub/forks","keys_url":"https://api.github.com/repos/CruGlobal/missionhub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CruGlobal/missionhub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CruGlobal/missionhub/teams","hooks_url":"https://api.github.com/repos/CruGlobal/missionhub/hooks","issue_events_url":"https://api.github.com/repos/CruGlobal/missionhub/issues/events{/number}","events_url":"https://api.github.com/repos/CruGlobal/missionhub/events","assignees_url":"https://api.github.com/repos/CruGlobal/missionhub/assignees{/user}","branches_url":"https://api.github.com/repos/CruGlobal/missionhub/branches{/branch}","tags_url":"https://api.github.com/repos/CruGlobal/missionhub/tags","blobs_url":"https://api.github.com/repos/CruGlobal/missionhub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CruGlobal/missionhub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CruGlobal/missionhub/git/refs{/sha}","trees_url":"https://api.github.com/repos/CruGlobal/missionhub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CruGlobal/missionhub/statuses/{sha}","languages_url":"https://api.github.com/repos/CruGlobal/missionhub/languages","stargazers_url":"https://api.github.com/repos/CruGlobal/missionhub/stargazers","contributors_url":"https://api.github.com/repos/CruGlobal/missionhub/contributors","subscribers_url":"https://api.github.com/repos/CruGlobal/missionhub/subscribers","subscription_url":"https://api.github.com/repos/CruGlobal/missionhub/subscription","commits_url":"https://api.github.com/repos/CruGlobal/missionhub/commits{/sha}","git_commits_url":"https://api.github.com/repos/CruGlobal/missionhub/git/commits{/sha}","comments_url":"https://api.github.com/repos/CruGlobal/missionhub/comments{/number}","issue_comment_url":"https://api.github.com/repos/CruGlobal/missionhub/issues/comments/{number}","contents_url":"https://api.github.com/repos/CruGlobal/missionhub/contents/{+path}","compare_url":"https://api.github.com/repos/CruGlobal/missionhub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CruGlobal/missionhub/merges","archive_url":"https://api.github.com/repos/CruGlobal/missionhub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CruGlobal/missionhub/downloads","issues_url":"https://api.github.com/repos/CruGlobal/missionhub/issues{/number}","pulls_url":"https://api.github.com/repos/CruGlobal/missionhub/pulls{/number}","milestones_url":"https://api.github.com/repos/CruGlobal/missionhub/milestones{/number}","notifications_url":"https://api.github.com/repos/CruGlobal/missionhub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CruGlobal/missionhub/labels{/name}","releases_url":"https://api.github.com/repos/CruGlobal/missionhub/releases{/id}","created_at":"2012-06-21T15:40:33Z","updated_at":"2014-02-03T15:46:58Z","pushed_at":"2014-02-03T15:46:56Z","git_url":"git://github.com/CruGlobal/missionhub.git","ssh_url":"git@github.com:CruGlobal/missionhub.git","clone_url":"https://github.com/CruGlobal/missionhub.git","svn_url":"https://github.com/CruGlobal/missionhub","homepage":null,"size":301540,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":3,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CruGlobal/missionhub/pulls/289"},"html":{"href":"https://github.com/CruGlobal/missionhub/pull/289"},"issue":{"href":"https://api.github.com/repos/CruGlobal/missionhub/issues/289"},"comments":{"href":"https://api.github.com/repos/CruGlobal/missionhub/issues/289/comments"},"review_comments":{"href":"https://api.github.com/repos/CruGlobal/missionhub/pulls/289/comments"},"review_comment":{"href":"https://api.github.com/repos/CruGlobal/missionhub/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CruGlobal/missionhub/pulls/289/commits"},"statuses":{"href":"https://api.github.com/repos/CruGlobal/missionhub/statuses/57c6b7cf38c69fc4f9b64a27a964094f598de234"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":72,"deletions":20,"changed_files":6}}