GitHub PullRequestReviewCommentEvent at 2014-12-23 22:00:20
Repository: nvm
Actor: ljharb
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/creationix/nvm/pulls/comments/22237943","id":22237943,"diff_hunk":"@@ -0,0 +1,58 @@\n+#!/usr/bin/env bats\n+\n+load test_helper\n+\n+NVM_SRC_DIR=\"${BATS_TEST_DIRNAME}/../..\"\n+\n+setup() {\n+    echo 'setup' >&2\n+    NVM_DIR=\"${BATS_TMPDIR}\"\n+    cd \"${NVM_DIR}\"\n+    rm -Rf src alias v*\n+    mkdir src alias\n+\n+    echo loopback > alias/loopback\n+    echo two > alias/one\n+    echo three > alias/two\n+    echo one > alias/three\n+\n+    echo two > alias/four\n+}\n+\n+teardown() {\n+    echo 'teardown' >&2\n+    NVM_DIR=\"${BATS_TMPDIR}\"\n+    cd \"${NVM_DIR}\"\n+    rm -Rf src alias v*\n+}\n+\n+@test './Aliases/circular/nvm_resolve_alias' {","path":"test/bats/aliases-circular.bats","position":29,"original_position":29,"commit_id":"edebb311194eef8e762da1c6f21d66bc6f65fabe","original_commit_id":"edebb311194eef8e762da1c6f21d66bc6f65fabe","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"Does this string matter, or is it just the description?","created_at":"2014-12-23T22:00:20Z","updated_at":"2014-12-23T22:00:20Z","html_url":"https://github.com/creationix/nvm/pull/601#discussion_r22237943","pull_request_url":"https://api.github.com/repos/creationix/nvm/pulls/601","_links":{"self":{"href":"https://api.github.com/repos/creationix/nvm/pulls/comments/22237943"},"html":{"href":"https://github.com/creationix/nvm/pull/601#discussion_r22237943"},"pull_request":{"href":"https://api.github.com/repos/creationix/nvm/pulls/601"}}},"pull_request":{"url":"https://api.github.com/repos/creationix/nvm/pulls/601","id":26533965,"html_url":"https://github.com/creationix/nvm/pull/601","diff_url":"https://github.com/creationix/nvm/pull/601.diff","patch_url":"https://github.com/creationix/nvm/pull/601.patch","issue_url":"https://api.github.com/repos/creationix/nvm/issues/601","number":601,"state":"open","locked":false,"title":"429 - use \"Bats\" for tests","user":{"login":"smikes","id":5124609,"avatar_url":"https://avatars.githubusercontent.com/u/5124609?v=3","gravatar_id":"","url":"https://api.github.com/users/smikes","html_url":"https://github.com/smikes","followers_url":"https://api.github.com/users/smikes/followers","following_url":"https://api.github.com/users/smikes/following{/other_user}","gists_url":"https://api.github.com/users/smikes/gists{/gist_id}","starred_url":"https://api.github.com/users/smikes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smikes/subscriptions","organizations_url":"https://api.github.com/users/smikes/orgs","repos_url":"https://api.github.com/users/smikes/repos","events_url":"https://api.github.com/users/smikes/events{/privacy}","received_events_url":"https://api.github.com/users/smikes/received_events","type":"User","site_admin":false},"body":"Opening this PR now because I would like some review and discussion (though obv. this can wait since lots of people are taking time off over the next week or two).\r\n\r\nSo far I have ported the tests in `test/fast` to bats.\r\n\r\n#### Pros\r\n\r\n* simpler syntax using helper functions\r\n* can have multiple tests per file\r\n\r\n#### Cons\r\n\r\n* bats tests seem to run slower \r\n* cross-shell testing - how to do with `bats`?\r\n","created_at":"2014-12-23T21:45:50Z","updated_at":"2014-12-23T22:00:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1151cd2451406f96b3fd0405a26203236c9c0c23","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/creationix/nvm/pulls/601/commits","review_comments_url":"https://api.github.com/repos/creationix/nvm/pulls/601/comments","review_comment_url":"https://api.github.com/repos/creationix/nvm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/creationix/nvm/issues/601/comments","statuses_url":"https://api.github.com/repos/creationix/nvm/statuses/edebb311194eef8e762da1c6f21d66bc6f65fabe","head":{"label":"smikes:bats","ref":"bats","sha":"edebb311194eef8e762da1c6f21d66bc6f65fabe","user":{"login":"smikes","id":5124609,"avatar_url":"https://avatars.githubusercontent.com/u/5124609?v=3","gravatar_id":"","url":"https://api.github.com/users/smikes","html_url":"https://github.com/smikes","followers_url":"https://api.github.com/users/smikes/followers","following_url":"https://api.github.com/users/smikes/following{/other_user}","gists_url":"https://api.github.com/users/smikes/gists{/gist_id}","starred_url":"https://api.github.com/users/smikes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smikes/subscriptions","organizations_url":"https://api.github.com/users/smikes/orgs","repos_url":"https://api.github.com/users/smikes/repos","events_url":"https://api.github.com/users/smikes/events{/privacy}","received_events_url":"https://api.github.com/users/smikes/received_events","type":"User","site_admin":false},"repo":{"id":27504979,"name":"nvm","full_name":"smikes/nvm","owner":{"login":"smikes","id":5124609,"avatar_url":"https://avatars.githubusercontent.com/u/5124609?v=3","gravatar_id":"","url":"https://api.github.com/users/smikes","html_url":"https://github.com/smikes","followers_url":"https://api.github.com/users/smikes/followers","following_url":"https://api.github.com/users/smikes/following{/other_user}","gists_url":"https://api.github.com/users/smikes/gists{/gist_id}","starred_url":"https://api.github.com/users/smikes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smikes/subscriptions","organizations_url":"https://api.github.com/users/smikes/orgs","repos_url":"https://api.github.com/users/smikes/repos","events_url":"https://api.github.com/users/smikes/events{/privacy}","received_events_url":"https://api.github.com/users/smikes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smikes/nvm","description":"Node Version Manager - Simple bash script to manage multiple active node.js versions","fork":true,"url":"https://api.github.com/repos/smikes/nvm","forks_url":"https://api.github.com/repos/smikes/nvm/forks","keys_url":"https://api.github.com/repos/smikes/nvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smikes/nvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smikes/nvm/teams","hooks_url":"https://api.github.com/repos/smikes/nvm/hooks","issue_events_url":"https://api.github.com/repos/smikes/nvm/issues/events{/number}","events_url":"https://api.github.com/repos/smikes/nvm/events","assignees_url":"https://api.github.com/repos/smikes/nvm/assignees{/user}","branches_url":"https://api.github.com/repos/smikes/nvm/branches{/branch}","tags_url":"https://api.github.com/repos/smikes/nvm/tags","blobs_url":"https://api.github.com/repos/smikes/nvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smikes/nvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smikes/nvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/smikes/nvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smikes/nvm/statuses/{sha}","languages_url":"https://api.github.com/repos/smikes/nvm/languages","stargazers_url":"https://api.github.com/repos/smikes/nvm/stargazers","contributors_url":"https://api.github.com/repos/smikes/nvm/contributors","subscribers_url":"https://api.github.com/repos/smikes/nvm/subscribers","subscription_url":"https://api.github.com/repos/smikes/nvm/subscription","commits_url":"https://api.github.com/repos/smikes/nvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/smikes/nvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/smikes/nvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/smikes/nvm/issues/comments/{number}","contents_url":"https://api.github.com/repos/smikes/nvm/contents/{+path}","compare_url":"https://api.github.com/repos/smikes/nvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smikes/nvm/merges","archive_url":"https://api.github.com/repos/smikes/nvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smikes/nvm/downloads","issues_url":"https://api.github.com/repos/smikes/nvm/issues{/number}","pulls_url":"https://api.github.com/repos/smikes/nvm/pulls{/number}","milestones_url":"https://api.github.com/repos/smikes/nvm/milestones{/number}","notifications_url":"https://api.github.com/repos/smikes/nvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smikes/nvm/labels{/name}","releases_url":"https://api.github.com/repos/smikes/nvm/releases{/id}","created_at":"2014-12-03T19:56:50Z","updated_at":"2014-12-03T19:56:51Z","pushed_at":"2014-12-23T21:41:58Z","git_url":"git://github.com/smikes/nvm.git","ssh_url":"git@github.com:smikes/nvm.git","clone_url":"https://github.com/smikes/nvm.git","svn_url":"https://github.com/smikes/nvm","homepage":"","size":607,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"creationix:master","ref":"master","sha":"bef3a5ce3a19f1f63b7ace27ff790df3cdb7df71","user":{"login":"creationix","id":89353,"avatar_url":"https://avatars.githubusercontent.com/u/89353?v=3","gravatar_id":"","url":"https://api.github.com/users/creationix","html_url":"https://github.com/creationix","followers_url":"https://api.github.com/users/creationix/followers","following_url":"https://api.github.com/users/creationix/following{/other_user}","gists_url":"https://api.github.com/users/creationix/gists{/gist_id}","starred_url":"https://api.github.com/users/creationix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creationix/subscriptions","organizations_url":"https://api.github.com/users/creationix/orgs","repos_url":"https://api.github.com/users/creationix/repos","events_url":"https://api.github.com/users/creationix/events{/privacy}","received_events_url":"https://api.github.com/users/creationix/received_events","type":"User","site_admin":false},"repo":{"id":612230,"name":"nvm","full_name":"creationix/nvm","owner":{"login":"creationix","id":89353,"avatar_url":"https://avatars.githubusercontent.com/u/89353?v=3","gravatar_id":"","url":"https://api.github.com/users/creationix","html_url":"https://github.com/creationix","followers_url":"https://api.github.com/users/creationix/followers","following_url":"https://api.github.com/users/creationix/following{/other_user}","gists_url":"https://api.github.com/users/creationix/gists{/gist_id}","starred_url":"https://api.github.com/users/creationix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creationix/subscriptions","organizations_url":"https://api.github.com/users/creationix/orgs","repos_url":"https://api.github.com/users/creationix/repos","events_url":"https://api.github.com/users/creationix/events{/privacy}","received_events_url":"https://api.github.com/users/creationix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/creationix/nvm","description":"Node Version Manager - Simple bash script to manage multiple active node.js versions","fork":false,"url":"https://api.github.com/repos/creationix/nvm","forks_url":"https://api.github.com/repos/creationix/nvm/forks","keys_url":"https://api.github.com/repos/creationix/nvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/creationix/nvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/creationix/nvm/teams","hooks_url":"https://api.github.com/repos/creationix/nvm/hooks","issue_events_url":"https://api.github.com/repos/creationix/nvm/issues/events{/number}","events_url":"https://api.github.com/repos/creationix/nvm/events","assignees_url":"https://api.github.com/repos/creationix/nvm/assignees{/user}","branches_url":"https://api.github.com/repos/creationix/nvm/branches{/branch}","tags_url":"https://api.github.com/repos/creationix/nvm/tags","blobs_url":"https://api.github.com/repos/creationix/nvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/creationix/nvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/creationix/nvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/creationix/nvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/creationix/nvm/statuses/{sha}","languages_url":"https://api.github.com/repos/creationix/nvm/languages","stargazers_url":"https://api.github.com/repos/creationix/nvm/stargazers","contributors_url":"https://api.github.com/repos/creationix/nvm/contributors","subscribers_url":"https://api.github.com/repos/creationix/nvm/subscribers","subscription_url":"https://api.github.com/repos/creationix/nvm/subscription","commits_url":"https://api.github.com/repos/creationix/nvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/creationix/nvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/creationix/nvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/creationix/nvm/issues/comments/{number}","contents_url":"https://api.github.com/repos/creationix/nvm/contents/{+path}","compare_url":"https://api.github.com/repos/creationix/nvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/creationix/nvm/merges","archive_url":"https://api.github.com/repos/creationix/nvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/creationix/nvm/downloads","issues_url":"https://api.github.com/repos/creationix/nvm/issues{/number}","pulls_url":"https://api.github.com/repos/creationix/nvm/pulls{/number}","milestones_url":"https://api.github.com/repos/creationix/nvm/milestones{/number}","notifications_url":"https://api.github.com/repos/creationix/nvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/creationix/nvm/labels{/name}","releases_url":"https://api.github.com/repos/creationix/nvm/releases{/id}","created_at":"2010-04-15T17:47:47Z","updated_at":"2014-12-23T20:53:04Z","pushed_at":"2014-12-23T07:05:45Z","git_url":"git://github.com/creationix/nvm.git","ssh_url":"git@github.com:creationix/nvm.git","clone_url":"https://github.com/creationix/nvm.git","svn_url":"https://github.com/creationix/nvm","homepage":"","size":3482,"stargazers_count":4968,"watchers_count":4968,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":538,"mirror_url":null,"open_issues_count":39,"forks":538,"open_issues":39,"watchers":4968,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/creationix/nvm/pulls/601"},"html":{"href":"https://github.com/creationix/nvm/pull/601"},"issue":{"href":"https://api.github.com/repos/creationix/nvm/issues/601"},"comments":{"href":"https://api.github.com/repos/creationix/nvm/issues/601/comments"},"review_comments":{"href":"https://api.github.com/repos/creationix/nvm/pulls/601/comments"},"review_comment":{"href":"https://api.github.com/repos/creationix/nvm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/creationix/nvm/pulls/601/commits"},"statuses":{"href":"https://api.github.com/repos/creationix/nvm/statuses/edebb311194eef8e762da1c6f21d66bc6f65fabe"}}}}