GitHub PullRequestReviewCommentEvent at 2014-10-05 14:18:46
Repository: oasis
Actor: madroach
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/oasis/pulls/comments/18435416","id":18435416,"diff_hunk":"@@ -730,11 +754,11 @@ let add_ocamlbuild_files ctxt pkg =\n                    let ext =\n                      match bs.bs_compiled_object with\n                        | Best ->\n-                           \"{cma,cmxa}\"\n+                           \"{cmo,cma,cmx,cmxa}\"","path":"src/plugins/ocamlbuild/OCamlbuildPlugin.ml","position":38,"original_position":38,"commit_id":"e9814f31b5756273c3ee31b323c18e035f4da6f2","original_commit_id":"e9814f31b5756273c3ee31b323c18e035f4da6f2","user":{"login":"madroach","id":1804658,"avatar_url":"https://avatars.githubusercontent.com/u/1804658?v=2","gravatar_id":"","url":"https://api.github.com/users/madroach","html_url":"https://github.com/madroach","followers_url":"https://api.github.com/users/madroach/followers","following_url":"https://api.github.com/users/madroach/following{/other_user}","gists_url":"https://api.github.com/users/madroach/gists{/gist_id}","starred_url":"https://api.github.com/users/madroach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madroach/subscriptions","organizations_url":"https://api.github.com/users/madroach/orgs","repos_url":"https://api.github.com/users/madroach/repos","events_url":"https://api.github.com/users/madroach/events{/privacy}","received_events_url":"https://api.github.com/users/madroach/received_events","type":"User","site_admin":false},"body":"ocamlc -bin-annot will dump .cmt(i) files in the following cases:\r\n* when -c compiling (produces .cmo/.cmi from .ml(i))\r\n* when -pack packing (produces .cmo from .cmo !!)\r\nas far as my experiments went, it won't produce .cmt(i) when linking libraries (.cma from .cmo)\r\n\r\nthe cmo and cmx will go in the _tags file to tag the packing step with the annotate tag.","created_at":"2014-10-05T14:18:46Z","updated_at":"2014-10-05T14:18:46Z","html_url":"https://github.com/ocaml/oasis/pull/54#discussion_r18435416","pull_request_url":"https://api.github.com/repos/ocaml/oasis/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/ocaml/oasis/pulls/comments/18435416"},"html":{"href":"https://github.com/ocaml/oasis/pull/54#discussion_r18435416"},"pull_request":{"href":"https://api.github.com/repos/ocaml/oasis/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/oasis/pulls/54","id":22243599,"html_url":"https://github.com/ocaml/oasis/pull/54","diff_url":"https://github.com/ocaml/oasis/pull/54.diff","patch_url":"https://github.com/ocaml/oasis/pull/54.patch","issue_url":"https://api.github.com/repos/ocaml/oasis/issues/54","number":54,"state":"open","locked":false,"title":"build and install annotation files","user":{"login":"madroach","id":1804658,"avatar_url":"https://avatars.githubusercontent.com/u/1804658?v=2","gravatar_id":"","url":"https://api.github.com/users/madroach","html_url":"https://github.com/madroach","followers_url":"https://api.github.com/users/madroach/followers","following_url":"https://api.github.com/users/madroach/following{/other_user}","gists_url":"https://api.github.com/users/madroach/gists{/gist_id}","starred_url":"https://api.github.com/users/madroach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madroach/subscriptions","organizations_url":"https://api.github.com/users/madroach/orgs","repos_url":"https://api.github.com/users/madroach/repos","events_url":"https://api.github.com/users/madroach/events{/privacy}","received_events_url":"https://api.github.com/users/madroach/received_events","type":"User","site_admin":false},"body":"Hi,\r\nit would be nice if oasis was able to build and install annotation files.\r\nIs this sensible default behaviour? Do we need a knob to turn it off?","created_at":"2014-10-04T13:42:54Z","updated_at":"2014-10-05T14:18:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd3d6d2842a55192052b47b4bf213a3bc00de305","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/oasis/pulls/54/commits","review_comments_url":"https://api.github.com/repos/ocaml/oasis/pulls/54/comments","review_comment_url":"https://api.github.com/repos/ocaml/oasis/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ocaml/oasis/issues/54/comments","statuses_url":"https://api.github.com/repos/ocaml/oasis/statuses/e9814f31b5756273c3ee31b323c18e035f4da6f2","head":{"label":"madroach:master","ref":"master","sha":"e9814f31b5756273c3ee31b323c18e035f4da6f2","user":{"login":"madroach","id":1804658,"avatar_url":"https://avatars.githubusercontent.com/u/1804658?v=2","gravatar_id":"","url":"https://api.github.com/users/madroach","html_url":"https://github.com/madroach","followers_url":"https://api.github.com/users/madroach/followers","following_url":"https://api.github.com/users/madroach/following{/other_user}","gists_url":"https://api.github.com/users/madroach/gists{/gist_id}","starred_url":"https://api.github.com/users/madroach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madroach/subscriptions","organizations_url":"https://api.github.com/users/madroach/orgs","repos_url":"https://api.github.com/users/madroach/repos","events_url":"https://api.github.com/users/madroach/events{/privacy}","received_events_url":"https://api.github.com/users/madroach/received_events","type":"User","site_admin":false},"repo":{"id":24790473,"name":"oasis","full_name":"madroach/oasis","owner":{"login":"madroach","id":1804658,"avatar_url":"https://avatars.githubusercontent.com/u/1804658?v=2","gravatar_id":"","url":"https://api.github.com/users/madroach","html_url":"https://github.com/madroach","followers_url":"https://api.github.com/users/madroach/followers","following_url":"https://api.github.com/users/madroach/following{/other_user}","gists_url":"https://api.github.com/users/madroach/gists{/gist_id}","starred_url":"https://api.github.com/users/madroach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madroach/subscriptions","organizations_url":"https://api.github.com/users/madroach/orgs","repos_url":"https://api.github.com/users/madroach/repos","events_url":"https://api.github.com/users/madroach/events{/privacy}","received_events_url":"https://api.github.com/users/madroach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madroach/oasis","description":"Cabal like system for OCaml","fork":true,"url":"https://api.github.com/repos/madroach/oasis","forks_url":"https://api.github.com/repos/madroach/oasis/forks","keys_url":"https://api.github.com/repos/madroach/oasis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madroach/oasis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madroach/oasis/teams","hooks_url":"https://api.github.com/repos/madroach/oasis/hooks","issue_events_url":"https://api.github.com/repos/madroach/oasis/issues/events{/number}","events_url":"https://api.github.com/repos/madroach/oasis/events","assignees_url":"https://api.github.com/repos/madroach/oasis/assignees{/user}","branches_url":"https://api.github.com/repos/madroach/oasis/branches{/branch}","tags_url":"https://api.github.com/repos/madroach/oasis/tags","blobs_url":"https://api.github.com/repos/madroach/oasis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madroach/oasis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madroach/oasis/git/refs{/sha}","trees_url":"https://api.github.com/repos/madroach/oasis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madroach/oasis/statuses/{sha}","languages_url":"https://api.github.com/repos/madroach/oasis/languages","stargazers_url":"https://api.github.com/repos/madroach/oasis/stargazers","contributors_url":"https://api.github.com/repos/madroach/oasis/contributors","subscribers_url":"https://api.github.com/repos/madroach/oasis/subscribers","subscription_url":"https://api.github.com/repos/madroach/oasis/subscription","commits_url":"https://api.github.com/repos/madroach/oasis/commits{/sha}","git_commits_url":"https://api.github.com/repos/madroach/oasis/git/commits{/sha}","comments_url":"https://api.github.com/repos/madroach/oasis/comments{/number}","issue_comment_url":"https://api.github.com/repos/madroach/oasis/issues/comments/{number}","contents_url":"https://api.github.com/repos/madroach/oasis/contents/{+path}","compare_url":"https://api.github.com/repos/madroach/oasis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madroach/oasis/merges","archive_url":"https://api.github.com/repos/madroach/oasis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madroach/oasis/downloads","issues_url":"https://api.github.com/repos/madroach/oasis/issues{/number}","pulls_url":"https://api.github.com/repos/madroach/oasis/pulls{/number}","milestones_url":"https://api.github.com/repos/madroach/oasis/milestones{/number}","notifications_url":"https://api.github.com/repos/madroach/oasis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madroach/oasis/labels{/name}","releases_url":"https://api.github.com/repos/madroach/oasis/releases{/id}","created_at":"2014-10-04T13:36:29Z","updated_at":"2014-10-04T13:38:10Z","pushed_at":"2014-10-04T13:38:07Z","git_url":"git://github.com/madroach/oasis.git","ssh_url":"git@github.com:madroach/oasis.git","clone_url":"https://github.com/madroach/oasis.git","svn_url":"https://github.com/madroach/oasis","homepage":null,"size":4611,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocaml:master","ref":"master","sha":"47d80665cf63793b14cffa51f51c5e1c8190aed5","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=2","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":5724770,"name":"oasis","full_name":"ocaml/oasis","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=2","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/oasis","description":"Cabal like system for OCaml","fork":false,"url":"https://api.github.com/repos/ocaml/oasis","forks_url":"https://api.github.com/repos/ocaml/oasis/forks","keys_url":"https://api.github.com/repos/ocaml/oasis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/oasis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/oasis/teams","hooks_url":"https://api.github.com/repos/ocaml/oasis/hooks","issue_events_url":"https://api.github.com/repos/ocaml/oasis/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/oasis/events","assignees_url":"https://api.github.com/repos/ocaml/oasis/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/oasis/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/oasis/tags","blobs_url":"https://api.github.com/repos/ocaml/oasis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/oasis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/oasis/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/oasis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/oasis/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/oasis/languages","stargazers_url":"https://api.github.com/repos/ocaml/oasis/stargazers","contributors_url":"https://api.github.com/repos/ocaml/oasis/contributors","subscribers_url":"https://api.github.com/repos/ocaml/oasis/subscribers","subscription_url":"https://api.github.com/repos/ocaml/oasis/subscription","commits_url":"https://api.github.com/repos/ocaml/oasis/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/oasis/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/oasis/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/oasis/issues/comments/{number}","contents_url":"https://api.github.com/repos/ocaml/oasis/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/oasis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/oasis/merges","archive_url":"https://api.github.com/repos/ocaml/oasis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/oasis/downloads","issues_url":"https://api.github.com/repos/ocaml/oasis/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/oasis/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/oasis/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/oasis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/oasis/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/oasis/releases{/id}","created_at":"2012-09-08T02:21:36Z","updated_at":"2014-10-04T10:11:55Z","pushed_at":"2014-09-02T13:10:04Z","git_url":"git://github.com/ocaml/oasis.git","ssh_url":"git@github.com:ocaml/oasis.git","clone_url":"https://github.com/ocaml/oasis.git","svn_url":"https://github.com/ocaml/oasis","homepage":null,"size":6024,"stargazers_count":30,"watchers_count":30,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":4,"forks":20,"open_issues":4,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/oasis/pulls/54"},"html":{"href":"https://github.com/ocaml/oasis/pull/54"},"issue":{"href":"https://api.github.com/repos/ocaml/oasis/issues/54"},"comments":{"href":"https://api.github.com/repos/ocaml/oasis/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/oasis/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/oasis/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ocaml/oasis/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/oasis/statuses/e9814f31b5756273c3ee31b323c18e035f4da6f2"}}}}