GitHub PullRequestReviewCommentEvent at 2014-07-02 15:22:31
Repository: edx-platform
Actor: lduarte1991
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/14463183","id":14463183,"diff_hunk":"@@ -327,21 +328,14 @@ Annotator.Plugin.Share = (function(_super) {\n \t\t\t\t\t\t\t\t\t});\n \t\t\t\t\t\t\t\t}\n \t\t\t\t\t\t\t}\n-\t\t\t\t\t\t}else if(self._isVideo(an)){//It is a OpenSeaDragon Annotation\n-\t\t\t\t\t\t\tif (typeof mplayer[an.target.container]!='undefined'){\n-\t\t\t\t\t\t\t\tvar player = mplayer[an.target.container];\n-\t\t\t\t\t\t\t\tif (player.id_ == an.target.container){\n-\t\t\t\t\t\t\t\t\tvar anFound = an;\n-\t\t\t\t\t\t\t\t\tvideojs(player.id_).ready(function(){\n-\t\t\t\t\t\t\t\t\t\tif (player.techName != 'Youtube'){\n-\t\t\t\t\t\t\t\t\t\t\tplayer.preload('auto');\n-\t\t\t\t\t\t\t\t\t\t}\n-\t\t\t\t\t\t\t\t\t\tplayer.autoPlayAPI = anFound;\n-\t\t\t\t\t\t\t\t\t\tplayer.play();\n-\t\t\t\t\t\t\t\t\t});\n-\t\t\t\t\t\t\t\t}\n-\t\t\t\t\t\t\t}\n+\t\t\t\t\t\t}else if(self._isImage(an)){//It is a OpenSeaDragon Annotation\n+\t\t\t\t\t\t\tvar bounds = new OpenSeadragon.Rect(an.bounds.x, an.bounds.y, an.bounds.width, an.bounds.height);\n+\t\t\t\t\t\t\tsetTimeout(function(){\n+\t\t\t\t\t\t\t\tosda.viewer.viewport.fitBounds(bounds, false);\n+\t\t\t\t\t\t\t\t$('html,body').animate({scrollTop: $(\"#\"+an.target.container).offset().top},'slow');},250\n+\t\t\t\t\t\t\t);\n \t\t\t\t\t\t}else{//It is a text\n+\t\t\t\t\t\t    self._isImage(an);","path":"common/static/js/vendor/ova/share-annotator.js","position":86,"original_position":86,"commit_id":"1a3f12b9ec4c4c70f935d3eb034b4fdd66680caa","original_commit_id":"1a3f12b9ec4c4c70f935d3eb034b4fdd66680caa","user":{"login":"lduarte1991","id":6320787,"avatar_url":"https://avatars.githubusercontent.com/u/6320787?","gravatar_id":"bc37d92e816ed0434fbc44dcbdb2fc41","url":"https://api.github.com/users/lduarte1991","html_url":"https://github.com/lduarte1991","followers_url":"https://api.github.com/users/lduarte1991/followers","following_url":"https://api.github.com/users/lduarte1991/following{/other_user}","gists_url":"https://api.github.com/users/lduarte1991/gists{/gist_id}","starred_url":"https://api.github.com/users/lduarte1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lduarte1991/subscriptions","organizations_url":"https://api.github.com/users/lduarte1991/orgs","repos_url":"https://api.github.com/users/lduarte1991/repos","events_url":"https://api.github.com/users/lduarte1991/events{/privacy}","received_events_url":"https://api.github.com/users/lduarte1991/received_events","type":"User","site_admin":false},"body":"Yep sorry I'll remove that line. It's not even supposed to be there, it was only a test. ","created_at":"2014-07-02T15:22:31Z","updated_at":"2014-07-02T15:22:31Z","html_url":"https://github.com/edx/edx-platform/pull/4166#discussion_r14463183","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/4166","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/14463183"},"html":{"href":"https://github.com/edx/edx-platform/pull/4166#discussion_r14463183"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4166"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/4166","id":17360383,"html_url":"https://github.com/edx/edx-platform/pull/4166","diff_url":"https://github.com/edx/edx-platform/pull/4166.diff","patch_url":"https://github.com/edx/edx-platform/pull/4166.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/4166","number":4166,"state":"open","title":"Annotations Tools: Sharing Plugin Fixed with Proper URI","user":{"login":"lduarte1991","id":6320787,"avatar_url":"https://avatars.githubusercontent.com/u/6320787?","gravatar_id":"bc37d92e816ed0434fbc44dcbdb2fc41","url":"https://api.github.com/users/lduarte1991","html_url":"https://github.com/lduarte1991","followers_url":"https://api.github.com/users/lduarte1991/followers","following_url":"https://api.github.com/users/lduarte1991/following{/other_user}","gists_url":"https://api.github.com/users/lduarte1991/gists{/gist_id}","starred_url":"https://api.github.com/users/lduarte1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lduarte1991/subscriptions","organizations_url":"https://api.github.com/users/lduarte1991/orgs","repos_url":"https://api.github.com/users/lduarte1991/repos","events_url":"https://api.github.com/users/lduarte1991/events{/privacy}","received_events_url":"https://api.github.com/users/lduarte1991/received_events","type":"User","site_admin":false},"body":"**Priority is HIGH for this PR since the course is currently live and the share functionality is not working properly.**\r\n\r\n**Background:** This is a bug fix for ChinaX course (currently happening!!). There was a bug originally with how the URI was formed for the sharing mechanism when you had multiple annotation tools in a single subsection under different Units. \r\n\r\n**CMS Updates:** None.\r\n\r\n**LMS Updates:** Minimal, the way the URL was created to bring you back to the correct annotation was fixed, also Daniel did not implement the one for images, but I used the fix from catch.js to fix it.\r\n\r\n**Testing: ** Create an annotation (text, image, and/or video) and hover over it. A hover pop-up should display the annotation text along with a Sharing button. When that button is clicked the lightbox appears with links to facebook, twitter, etc. The only thing that has changed is that the url below should now contain an extra URL parameter to designate the Unit where the Tool is present. Activating that link in a new window should have one of the following results:\r\n1. Text highlight will turn green and the page will scroll down to that line.\r\n2. Image should zoom/pan to display the annotation\r\n3. Video should start playing based on where the annotation's start and end times are. ","created_at":"2014-06-19T16:17:22Z","updated_at":"2014-07-02T15:22:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ce35e5f7ec743b9d0474071591a5a5301ca05df","assignee":{"login":"adampalay","id":2748698,"avatar_url":"https://avatars.githubusercontent.com/u/2748698?","gravatar_id":"4c6c33ba34805ad702799c529d0cdce4","url":"https://api.github.com/users/adampalay","html_url":"https://github.com/adampalay","followers_url":"https://api.github.com/users/adampalay/followers","following_url":"https://api.github.com/users/adampalay/following{/other_user}","gists_url":"https://api.github.com/users/adampalay/gists{/gist_id}","starred_url":"https://api.github.com/users/adampalay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adampalay/subscriptions","organizations_url":"https://api.github.com/users/adampalay/orgs","repos_url":"https://api.github.com/users/adampalay/repos","events_url":"https://api.github.com/users/adampalay/events{/privacy}","received_events_url":"https://api.github.com/users/adampalay/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/4166/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/4166/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/4166/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/1a3f12b9ec4c4c70f935d3eb034b4fdd66680caa","head":{"label":"lduarte1991:lduarte-harvardx-pr5","ref":"lduarte-harvardx-pr5","sha":"1a3f12b9ec4c4c70f935d3eb034b4fdd66680caa","user":{"login":"lduarte1991","id":6320787,"avatar_url":"https://avatars.githubusercontent.com/u/6320787?","gravatar_id":"bc37d92e816ed0434fbc44dcbdb2fc41","url":"https://api.github.com/users/lduarte1991","html_url":"https://github.com/lduarte1991","followers_url":"https://api.github.com/users/lduarte1991/followers","following_url":"https://api.github.com/users/lduarte1991/following{/other_user}","gists_url":"https://api.github.com/users/lduarte1991/gists{/gist_id}","starred_url":"https://api.github.com/users/lduarte1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lduarte1991/subscriptions","organizations_url":"https://api.github.com/users/lduarte1991/orgs","repos_url":"https://api.github.com/users/lduarte1991/repos","events_url":"https://api.github.com/users/lduarte1991/events{/privacy}","received_events_url":"https://api.github.com/users/lduarte1991/received_events","type":"User","site_admin":false},"repo":{"id":19076508,"name":"edx-platform","full_name":"lduarte1991/edx-platform","owner":{"login":"lduarte1991","id":6320787,"avatar_url":"https://avatars.githubusercontent.com/u/6320787?","gravatar_id":"bc37d92e816ed0434fbc44dcbdb2fc41","url":"https://api.github.com/users/lduarte1991","html_url":"https://github.com/lduarte1991","followers_url":"https://api.github.com/users/lduarte1991/followers","following_url":"https://api.github.com/users/lduarte1991/following{/other_user}","gists_url":"https://api.github.com/users/lduarte1991/gists{/gist_id}","starred_url":"https://api.github.com/users/lduarte1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lduarte1991/subscriptions","organizations_url":"https://api.github.com/users/lduarte1991/orgs","repos_url":"https://api.github.com/users/lduarte1991/repos","events_url":"https://api.github.com/users/lduarte1991/events{/privacy}","received_events_url":"https://api.github.com/users/lduarte1991/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lduarte1991/edx-platform","description":"the edX learning management system (LMS) and course authoring tool, Studio","fork":true,"url":"https://api.github.com/repos/lduarte1991/edx-platform","forks_url":"https://api.github.com/repos/lduarte1991/edx-platform/forks","keys_url":"https://api.github.com/repos/lduarte1991/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lduarte1991/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lduarte1991/edx-platform/teams","hooks_url":"https://api.github.com/repos/lduarte1991/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/lduarte1991/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/lduarte1991/edx-platform/events","assignees_url":"https://api.github.com/repos/lduarte1991/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/lduarte1991/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/lduarte1991/edx-platform/tags","blobs_url":"https://api.github.com/repos/lduarte1991/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lduarte1991/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lduarte1991/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/lduarte1991/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lduarte1991/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/lduarte1991/edx-platform/languages","stargazers_url":"https://api.github.com/repos/lduarte1991/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/lduarte1991/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/lduarte1991/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/lduarte1991/edx-platform/subscription","commits_url":"https://api.github.com/repos/lduarte1991/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/lduarte1991/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/lduarte1991/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/lduarte1991/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/lduarte1991/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/lduarte1991/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lduarte1991/edx-platform/merges","archive_url":"https://api.github.com/repos/lduarte1991/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lduarte1991/edx-platform/downloads","issues_url":"https://api.github.com/repos/lduarte1991/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/lduarte1991/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/lduarte1991/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/lduarte1991/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lduarte1991/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/lduarte1991/edx-platform/releases{/id}","created_at":"2014-04-23T16:14:10Z","updated_at":"2014-06-23T14:24:53Z","pushed_at":"2014-07-01T17:15:25Z","git_url":"git://github.com/lduarte1991/edx-platform.git","ssh_url":"git@github.com:lduarte1991/edx-platform.git","clone_url":"https://github.com/lduarte1991/edx-platform.git","svn_url":"https://github.com/lduarte1991/edx-platform","homepage":"http://code.edx.org/","size":300864,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"d18d078e4e03b0b59e148426ef60dc205820e5ef","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://www.edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-07-02T08:19:22Z","pushed_at":"2014-07-02T15:18:19Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://code.edx.org/","size":1139984,"stargazers_count":1286,"watchers_count":1286,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":683,"mirror_url":null,"open_issues_count":140,"forks":683,"open_issues":140,"watchers":1286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4166"},"html":{"href":"https://github.com/edx/edx-platform/pull/4166"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/4166"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/4166/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4166/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4166/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/1a3f12b9ec4c4c70f935d3eb034b4fdd66680caa"}}}}