GitHub PullRequestEvent at 2014-07-24 22:15:01
Repository: vinyl-map
Actor: martinraison
Payload: {"action":"opened","number":6,"pull_request":{"url":"https://api.github.com/repos/hughsk/vinyl-map/pulls/6","id":18867798,"html_url":"https://github.com/hughsk/vinyl-map/pull/6","diff_url":"https://github.com/hughsk/vinyl-map/pull/6.diff","patch_url":"https://github.com/hughsk/vinyl-map/pull/6.patch","issue_url":"https://api.github.com/repos/hughsk/vinyl-map/issues/6","number":6,"state":"open","title":"check uses callback provided to flush instead of sending 'end' signal","user":{"login":"martinraison","id":2560662,"avatar_url":"https://avatars.githubusercontent.com/u/2560662?","gravatar_id":"3fe91c1519ebe040212894af76a7b084","url":"https://api.github.com/users/martinraison","html_url":"https://github.com/martinraison","followers_url":"https://api.github.com/users/martinraison/followers","following_url":"https://api.github.com/users/martinraison/following{/other_user}","gists_url":"https://api.github.com/users/martinraison/gists{/gist_id}","starred_url":"https://api.github.com/users/martinraison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinraison/subscriptions","organizations_url":"https://api.github.com/users/martinraison/orgs","repos_url":"https://api.github.com/users/martinraison/repos","events_url":"https://api.github.com/users/martinraison/events{/privacy}","received_events_url":"https://api.github.com/users/martinraison/received_events","type":"User","site_admin":false},"body":"I had an issue when using vinyl-map with gulp where the stream would end prematurely (i.e. only some of the files where being processed). I think I've found a fix: according to the [node.js stream doc](http://nodejs.org/docs/latest/api/stream.html#stream_transform_flush_callback, the flush), the `flush` function should not be sending the `end` signal directly, instead it should call the provided callback after the flush operation is complete (I guess the callback function eventually triggers the `end` signal, but not necessarily right away).\r\n\r\nThanks for the nice work!\r\n","created_at":"2014-07-24T22:15:00Z","updated_at":"2014-07-24T22:15:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hughsk/vinyl-map/pulls/6/commits","review_comments_url":"https://api.github.com/repos/hughsk/vinyl-map/pulls/6/comments","review_comment_url":"https://api.github.com/repos/hughsk/vinyl-map/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hughsk/vinyl-map/issues/6/comments","statuses_url":"https://api.github.com/repos/hughsk/vinyl-map/statuses/4171258696800b8151bfe0cfec7650aca0a78985","head":{"label":"martinraison:fix_check","ref":"fix_check","sha":"4171258696800b8151bfe0cfec7650aca0a78985","user":{"login":"martinraison","id":2560662,"avatar_url":"https://avatars.githubusercontent.com/u/2560662?","gravatar_id":"3fe91c1519ebe040212894af76a7b084","url":"https://api.github.com/users/martinraison","html_url":"https://github.com/martinraison","followers_url":"https://api.github.com/users/martinraison/followers","following_url":"https://api.github.com/users/martinraison/following{/other_user}","gists_url":"https://api.github.com/users/martinraison/gists{/gist_id}","starred_url":"https://api.github.com/users/martinraison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinraison/subscriptions","organizations_url":"https://api.github.com/users/martinraison/orgs","repos_url":"https://api.github.com/users/martinraison/repos","events_url":"https://api.github.com/users/martinraison/events{/privacy}","received_events_url":"https://api.github.com/users/martinraison/received_events","type":"User","site_admin":false},"repo":{"id":22233033,"name":"vinyl-map","full_name":"martinraison/vinyl-map","owner":{"login":"martinraison","id":2560662,"avatar_url":"https://avatars.githubusercontent.com/u/2560662?","gravatar_id":"3fe91c1519ebe040212894af76a7b084","url":"https://api.github.com/users/martinraison","html_url":"https://github.com/martinraison","followers_url":"https://api.github.com/users/martinraison/followers","following_url":"https://api.github.com/users/martinraison/following{/other_user}","gists_url":"https://api.github.com/users/martinraison/gists{/gist_id}","starred_url":"https://api.github.com/users/martinraison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinraison/subscriptions","organizations_url":"https://api.github.com/users/martinraison/orgs","repos_url":"https://api.github.com/users/martinraison/repos","events_url":"https://api.github.com/users/martinraison/events{/privacy}","received_events_url":"https://api.github.com/users/martinraison/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinraison/vinyl-map","description":"Map vinyl files' contents as strings","fork":true,"url":"https://api.github.com/repos/martinraison/vinyl-map","forks_url":"https://api.github.com/repos/martinraison/vinyl-map/forks","keys_url":"https://api.github.com/repos/martinraison/vinyl-map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinraison/vinyl-map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinraison/vinyl-map/teams","hooks_url":"https://api.github.com/repos/martinraison/vinyl-map/hooks","issue_events_url":"https://api.github.com/repos/martinraison/vinyl-map/issues/events{/number}","events_url":"https://api.github.com/repos/martinraison/vinyl-map/events","assignees_url":"https://api.github.com/repos/martinraison/vinyl-map/assignees{/user}","branches_url":"https://api.github.com/repos/martinraison/vinyl-map/branches{/branch}","tags_url":"https://api.github.com/repos/martinraison/vinyl-map/tags","blobs_url":"https://api.github.com/repos/martinraison/vinyl-map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinraison/vinyl-map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinraison/vinyl-map/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinraison/vinyl-map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinraison/vinyl-map/statuses/{sha}","languages_url":"https://api.github.com/repos/martinraison/vinyl-map/languages","stargazers_url":"https://api.github.com/repos/martinraison/vinyl-map/stargazers","contributors_url":"https://api.github.com/repos/martinraison/vinyl-map/contributors","subscribers_url":"https://api.github.com/repos/martinraison/vinyl-map/subscribers","subscription_url":"https://api.github.com/repos/martinraison/vinyl-map/subscription","commits_url":"https://api.github.com/repos/martinraison/vinyl-map/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinraison/vinyl-map/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinraison/vinyl-map/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinraison/vinyl-map/issues/comments/{number}","contents_url":"https://api.github.com/repos/martinraison/vinyl-map/contents/{+path}","compare_url":"https://api.github.com/repos/martinraison/vinyl-map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinraison/vinyl-map/merges","archive_url":"https://api.github.com/repos/martinraison/vinyl-map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinraison/vinyl-map/downloads","issues_url":"https://api.github.com/repos/martinraison/vinyl-map/issues{/number}","pulls_url":"https://api.github.com/repos/martinraison/vinyl-map/pulls{/number}","milestones_url":"https://api.github.com/repos/martinraison/vinyl-map/milestones{/number}","notifications_url":"https://api.github.com/repos/martinraison/vinyl-map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinraison/vinyl-map/labels{/name}","releases_url":"https://api.github.com/repos/martinraison/vinyl-map/releases{/id}","created_at":"2014-07-24T21:57:15Z","updated_at":"2014-06-29T11:02:47Z","pushed_at":"2014-07-24T22:05:37Z","git_url":"git://github.com/martinraison/vinyl-map.git","ssh_url":"git@github.com:martinraison/vinyl-map.git","clone_url":"https://github.com/martinraison/vinyl-map.git","svn_url":"https://github.com/martinraison/vinyl-map","homepage":null,"size":125,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hughsk:master","ref":"master","sha":"e157cae9dd9edf1b503a68f39f503a6f55e99e80","user":{"login":"hughsk","id":569817,"avatar_url":"https://avatars.githubusercontent.com/u/569817?","gravatar_id":"133cd05eb39521d55fb7a08c787925e2","url":"https://api.github.com/users/hughsk","html_url":"https://github.com/hughsk","followers_url":"https://api.github.com/users/hughsk/followers","following_url":"https://api.github.com/users/hughsk/following{/other_user}","gists_url":"https://api.github.com/users/hughsk/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsk/subscriptions","organizations_url":"https://api.github.com/users/hughsk/orgs","repos_url":"https://api.github.com/users/hughsk/repos","events_url":"https://api.github.com/users/hughsk/events{/privacy}","received_events_url":"https://api.github.com/users/hughsk/received_events","type":"User","site_admin":false},"repo":{"id":15815748,"name":"vinyl-map","full_name":"hughsk/vinyl-map","owner":{"login":"hughsk","id":569817,"avatar_url":"https://avatars.githubusercontent.com/u/569817?","gravatar_id":"133cd05eb39521d55fb7a08c787925e2","url":"https://api.github.com/users/hughsk","html_url":"https://github.com/hughsk","followers_url":"https://api.github.com/users/hughsk/followers","following_url":"https://api.github.com/users/hughsk/following{/other_user}","gists_url":"https://api.github.com/users/hughsk/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsk/subscriptions","organizations_url":"https://api.github.com/users/hughsk/orgs","repos_url":"https://api.github.com/users/hughsk/repos","events_url":"https://api.github.com/users/hughsk/events{/privacy}","received_events_url":"https://api.github.com/users/hughsk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughsk/vinyl-map","description":"Map vinyl files' contents as strings","fork":false,"url":"https://api.github.com/repos/hughsk/vinyl-map","forks_url":"https://api.github.com/repos/hughsk/vinyl-map/forks","keys_url":"https://api.github.com/repos/hughsk/vinyl-map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughsk/vinyl-map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughsk/vinyl-map/teams","hooks_url":"https://api.github.com/repos/hughsk/vinyl-map/hooks","issue_events_url":"https://api.github.com/repos/hughsk/vinyl-map/issues/events{/number}","events_url":"https://api.github.com/repos/hughsk/vinyl-map/events","assignees_url":"https://api.github.com/repos/hughsk/vinyl-map/assignees{/user}","branches_url":"https://api.github.com/repos/hughsk/vinyl-map/branches{/branch}","tags_url":"https://api.github.com/repos/hughsk/vinyl-map/tags","blobs_url":"https://api.github.com/repos/hughsk/vinyl-map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughsk/vinyl-map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughsk/vinyl-map/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughsk/vinyl-map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughsk/vinyl-map/statuses/{sha}","languages_url":"https://api.github.com/repos/hughsk/vinyl-map/languages","stargazers_url":"https://api.github.com/repos/hughsk/vinyl-map/stargazers","contributors_url":"https://api.github.com/repos/hughsk/vinyl-map/contributors","subscribers_url":"https://api.github.com/repos/hughsk/vinyl-map/subscribers","subscription_url":"https://api.github.com/repos/hughsk/vinyl-map/subscription","commits_url":"https://api.github.com/repos/hughsk/vinyl-map/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughsk/vinyl-map/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughsk/vinyl-map/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughsk/vinyl-map/issues/comments/{number}","contents_url":"https://api.github.com/repos/hughsk/vinyl-map/contents/{+path}","compare_url":"https://api.github.com/repos/hughsk/vinyl-map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughsk/vinyl-map/merges","archive_url":"https://api.github.com/repos/hughsk/vinyl-map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughsk/vinyl-map/downloads","issues_url":"https://api.github.com/repos/hughsk/vinyl-map/issues{/number}","pulls_url":"https://api.github.com/repos/hughsk/vinyl-map/pulls{/number}","milestones_url":"https://api.github.com/repos/hughsk/vinyl-map/milestones{/number}","notifications_url":"https://api.github.com/repos/hughsk/vinyl-map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughsk/vinyl-map/labels{/name}","releases_url":"https://api.github.com/repos/hughsk/vinyl-map/releases{/id}","created_at":"2014-01-11T02:58:55Z","updated_at":"2014-06-29T11:02:47Z","pushed_at":"2014-02-17T01:30:32Z","git_url":"git://github.com/hughsk/vinyl-map.git","ssh_url":"git@github.com:hughsk/vinyl-map.git","clone_url":"https://github.com/hughsk/vinyl-map.git","svn_url":"https://github.com/hughsk/vinyl-map","homepage":null,"size":199,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hughsk/vinyl-map/pulls/6"},"html":{"href":"https://github.com/hughsk/vinyl-map/pull/6"},"issue":{"href":"https://api.github.com/repos/hughsk/vinyl-map/issues/6"},"comments":{"href":"https://api.github.com/repos/hughsk/vinyl-map/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/hughsk/vinyl-map/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/hughsk/vinyl-map/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hughsk/vinyl-map/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/hughsk/vinyl-map/statuses/4171258696800b8151bfe0cfec7650aca0a78985"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":9,"changed_files":1}}