GitHub PullRequestReviewCommentEvent at 2014-07-11 15:44:59
Repository: Hilary
Actor: nicolaasmatthijs
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/oaeproject/Hilary/pulls/comments/14827714","id":14827714,"diff_hunk":"@@ -47,3 +62,20 @@ OAE.tenantRouter.on('post', '/api/mediacore/encodingCallback', function(req, res\n         return res.send(200);\n     });\n });\n+\n+// Add the REST models for MediaCore","path":"node_modules/oae-mediacore/lib/rest.js","position":40,"original_position":40,"commit_id":"732fecfd526789b5de562699b40509cf79230fc9","original_commit_id":"732fecfd526789b5de562699b40509cf79230fc9","user":{"login":"nicolaasmatthijs","id":109850,"avatar_url":"https://avatars.githubusercontent.com/u/109850?","gravatar_id":"8d128e44d86f7ea45534291c2c36599a","url":"https://api.github.com/users/nicolaasmatthijs","html_url":"https://github.com/nicolaasmatthijs","followers_url":"https://api.github.com/users/nicolaasmatthijs/followers","following_url":"https://api.github.com/users/nicolaasmatthijs/following{/other_user}","gists_url":"https://api.github.com/users/nicolaasmatthijs/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaasmatthijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaasmatthijs/subscriptions","organizations_url":"https://api.github.com/users/nicolaasmatthijs/orgs","repos_url":"https://api.github.com/users/nicolaasmatthijs/repos","events_url":"https://api.github.com/users/nicolaasmatthijs/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaasmatthijs/received_events","type":"User","site_admin":false},"body":"Having the models that are re-used in multiple places in a stub `rest.js` in `oae-util` doesn't seem great either. In that case, I'd be in favour of pulling things out into a `restmodel.js` file per module, and then requiring the models from the other modules that are being used by your `rest.js` file","created_at":"2014-07-11T15:44:59Z","updated_at":"2014-07-11T15:44:59Z","html_url":"https://github.com/oaeproject/Hilary/pull/922#discussion_r14827714","pull_request_url":"https://api.github.com/repos/oaeproject/Hilary/pulls/922","_links":{"self":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/comments/14827714"},"html":{"href":"https://github.com/oaeproject/Hilary/pull/922#discussion_r14827714"},"pull_request":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/922"}}},"pull_request":{"url":"https://api.github.com/repos/oaeproject/Hilary/pulls/922","id":16426126,"html_url":"https://github.com/oaeproject/Hilary/pull/922","diff_url":"https://github.com/oaeproject/Hilary/pull/922.diff","patch_url":"https://github.com/oaeproject/Hilary/pull/922.patch","issue_url":"https://api.github.com/repos/oaeproject/Hilary/issues/922","number":922,"state":"open","title":"add REST documentation for mediacore module","user":{"login":"sathomas","id":1731910,"avatar_url":"https://avatars.githubusercontent.com/u/1731910?","gravatar_id":"a5b424d4146905962a24acd6815aeb84","url":"https://api.github.com/users/sathomas","html_url":"https://github.com/sathomas","followers_url":"https://api.github.com/users/sathomas/followers","following_url":"https://api.github.com/users/sathomas/following{/other_user}","gists_url":"https://api.github.com/users/sathomas/gists{/gist_id}","starred_url":"https://api.github.com/users/sathomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathomas/subscriptions","organizations_url":"https://api.github.com/users/sathomas/orgs","repos_url":"https://api.github.com/users/sathomas/repos","events_url":"https://api.github.com/users/sathomas/events{/privacy}","received_events_url":"https://api.github.com/users/sathomas/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-05-28T13:15:56Z","updated_at":"2014-07-11T15:44:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"096b57d3acf0833d4a2b443e87f26f877c9e84ad","assignee":{"login":"sathomas","id":1731910,"avatar_url":"https://avatars.githubusercontent.com/u/1731910?","gravatar_id":"a5b424d4146905962a24acd6815aeb84","url":"https://api.github.com/users/sathomas","html_url":"https://github.com/sathomas","followers_url":"https://api.github.com/users/sathomas/followers","following_url":"https://api.github.com/users/sathomas/following{/other_user}","gists_url":"https://api.github.com/users/sathomas/gists{/gist_id}","starred_url":"https://api.github.com/users/sathomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathomas/subscriptions","organizations_url":"https://api.github.com/users/sathomas/orgs","repos_url":"https://api.github.com/users/sathomas/repos","events_url":"https://api.github.com/users/sathomas/events{/privacy}","received_events_url":"https://api.github.com/users/sathomas/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/oaeproject/Hilary/pulls/922/commits","review_comments_url":"https://api.github.com/repos/oaeproject/Hilary/pulls/922/comments","review_comment_url":"https://api.github.com/repos/oaeproject/Hilary/pulls/comments/{number}","comments_url":"https://api.github.com/repos/oaeproject/Hilary/issues/922/comments","statuses_url":"https://api.github.com/repos/oaeproject/Hilary/statuses/732fecfd526789b5de562699b40509cf79230fc9","head":{"label":"sathomas:restdoc-mediacore","ref":"restdoc-mediacore","sha":"732fecfd526789b5de562699b40509cf79230fc9","user":{"login":"sathomas","id":1731910,"avatar_url":"https://avatars.githubusercontent.com/u/1731910?","gravatar_id":"a5b424d4146905962a24acd6815aeb84","url":"https://api.github.com/users/sathomas","html_url":"https://github.com/sathomas","followers_url":"https://api.github.com/users/sathomas/followers","following_url":"https://api.github.com/users/sathomas/following{/other_user}","gists_url":"https://api.github.com/users/sathomas/gists{/gist_id}","starred_url":"https://api.github.com/users/sathomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathomas/subscriptions","organizations_url":"https://api.github.com/users/sathomas/orgs","repos_url":"https://api.github.com/users/sathomas/repos","events_url":"https://api.github.com/users/sathomas/events{/privacy}","received_events_url":"https://api.github.com/users/sathomas/received_events","type":"User","site_admin":false},"repo":{"id":14304173,"name":"Hilary","full_name":"sathomas/Hilary","owner":{"login":"sathomas","id":1731910,"avatar_url":"https://avatars.githubusercontent.com/u/1731910?","gravatar_id":"a5b424d4146905962a24acd6815aeb84","url":"https://api.github.com/users/sathomas","html_url":"https://github.com/sathomas","followers_url":"https://api.github.com/users/sathomas/followers","following_url":"https://api.github.com/users/sathomas/following{/other_user}","gists_url":"https://api.github.com/users/sathomas/gists{/gist_id}","starred_url":"https://api.github.com/users/sathomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathomas/subscriptions","organizations_url":"https://api.github.com/users/sathomas/orgs","repos_url":"https://api.github.com/users/sathomas/repos","events_url":"https://api.github.com/users/sathomas/events{/privacy}","received_events_url":"https://api.github.com/users/sathomas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sathomas/Hilary","description":"Open Academic Environment (OAE) Back-End","fork":true,"url":"https://api.github.com/repos/sathomas/Hilary","forks_url":"https://api.github.com/repos/sathomas/Hilary/forks","keys_url":"https://api.github.com/repos/sathomas/Hilary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sathomas/Hilary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sathomas/Hilary/teams","hooks_url":"https://api.github.com/repos/sathomas/Hilary/hooks","issue_events_url":"https://api.github.com/repos/sathomas/Hilary/issues/events{/number}","events_url":"https://api.github.com/repos/sathomas/Hilary/events","assignees_url":"https://api.github.com/repos/sathomas/Hilary/assignees{/user}","branches_url":"https://api.github.com/repos/sathomas/Hilary/branches{/branch}","tags_url":"https://api.github.com/repos/sathomas/Hilary/tags","blobs_url":"https://api.github.com/repos/sathomas/Hilary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sathomas/Hilary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sathomas/Hilary/git/refs{/sha}","trees_url":"https://api.github.com/repos/sathomas/Hilary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sathomas/Hilary/statuses/{sha}","languages_url":"https://api.github.com/repos/sathomas/Hilary/languages","stargazers_url":"https://api.github.com/repos/sathomas/Hilary/stargazers","contributors_url":"https://api.github.com/repos/sathomas/Hilary/contributors","subscribers_url":"https://api.github.com/repos/sathomas/Hilary/subscribers","subscription_url":"https://api.github.com/repos/sathomas/Hilary/subscription","commits_url":"https://api.github.com/repos/sathomas/Hilary/commits{/sha}","git_commits_url":"https://api.github.com/repos/sathomas/Hilary/git/commits{/sha}","comments_url":"https://api.github.com/repos/sathomas/Hilary/comments{/number}","issue_comment_url":"https://api.github.com/repos/sathomas/Hilary/issues/comments/{number}","contents_url":"https://api.github.com/repos/sathomas/Hilary/contents/{+path}","compare_url":"https://api.github.com/repos/sathomas/Hilary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sathomas/Hilary/merges","archive_url":"https://api.github.com/repos/sathomas/Hilary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sathomas/Hilary/downloads","issues_url":"https://api.github.com/repos/sathomas/Hilary/issues{/number}","pulls_url":"https://api.github.com/repos/sathomas/Hilary/pulls{/number}","milestones_url":"https://api.github.com/repos/sathomas/Hilary/milestones{/number}","notifications_url":"https://api.github.com/repos/sathomas/Hilary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sathomas/Hilary/labels{/name}","releases_url":"https://api.github.com/repos/sathomas/Hilary/releases{/id}","created_at":"2013-11-11T15:11:13Z","updated_at":"2014-06-20T14:54:54Z","pushed_at":"2014-06-20T14:54:22Z","git_url":"git://github.com/sathomas/Hilary.git","ssh_url":"git@github.com:sathomas/Hilary.git","clone_url":"https://github.com/sathomas/Hilary.git","svn_url":"https://github.com/sathomas/Hilary","homepage":"http://www.oaeproject.org","size":16193,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oaeproject:master","ref":"master","sha":"a31ed4fa7a4a82b42368d6000b92dd41f05c88dc","user":{"login":"oaeproject","id":4659912,"avatar_url":"https://avatars.githubusercontent.com/u/4659912?","gravatar_id":"759cc05cff60f49168451eefcf3d51eb","url":"https://api.github.com/users/oaeproject","html_url":"https://github.com/oaeproject","followers_url":"https://api.github.com/users/oaeproject/followers","following_url":"https://api.github.com/users/oaeproject/following{/other_user}","gists_url":"https://api.github.com/users/oaeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/oaeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaeproject/subscriptions","organizations_url":"https://api.github.com/users/oaeproject/orgs","repos_url":"https://api.github.com/users/oaeproject/repos","events_url":"https://api.github.com/users/oaeproject/events{/privacy}","received_events_url":"https://api.github.com/users/oaeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":5638565,"name":"Hilary","full_name":"oaeproject/Hilary","owner":{"login":"oaeproject","id":4659912,"avatar_url":"https://avatars.githubusercontent.com/u/4659912?","gravatar_id":"759cc05cff60f49168451eefcf3d51eb","url":"https://api.github.com/users/oaeproject","html_url":"https://github.com/oaeproject","followers_url":"https://api.github.com/users/oaeproject/followers","following_url":"https://api.github.com/users/oaeproject/following{/other_user}","gists_url":"https://api.github.com/users/oaeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/oaeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaeproject/subscriptions","organizations_url":"https://api.github.com/users/oaeproject/orgs","repos_url":"https://api.github.com/users/oaeproject/repos","events_url":"https://api.github.com/users/oaeproject/events{/privacy}","received_events_url":"https://api.github.com/users/oaeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oaeproject/Hilary","description":"Open Academic Environment (OAE) Back-End","fork":false,"url":"https://api.github.com/repos/oaeproject/Hilary","forks_url":"https://api.github.com/repos/oaeproject/Hilary/forks","keys_url":"https://api.github.com/repos/oaeproject/Hilary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oaeproject/Hilary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oaeproject/Hilary/teams","hooks_url":"https://api.github.com/repos/oaeproject/Hilary/hooks","issue_events_url":"https://api.github.com/repos/oaeproject/Hilary/issues/events{/number}","events_url":"https://api.github.com/repos/oaeproject/Hilary/events","assignees_url":"https://api.github.com/repos/oaeproject/Hilary/assignees{/user}","branches_url":"https://api.github.com/repos/oaeproject/Hilary/branches{/branch}","tags_url":"https://api.github.com/repos/oaeproject/Hilary/tags","blobs_url":"https://api.github.com/repos/oaeproject/Hilary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oaeproject/Hilary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oaeproject/Hilary/git/refs{/sha}","trees_url":"https://api.github.com/repos/oaeproject/Hilary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oaeproject/Hilary/statuses/{sha}","languages_url":"https://api.github.com/repos/oaeproject/Hilary/languages","stargazers_url":"https://api.github.com/repos/oaeproject/Hilary/stargazers","contributors_url":"https://api.github.com/repos/oaeproject/Hilary/contributors","subscribers_url":"https://api.github.com/repos/oaeproject/Hilary/subscribers","subscription_url":"https://api.github.com/repos/oaeproject/Hilary/subscription","commits_url":"https://api.github.com/repos/oaeproject/Hilary/commits{/sha}","git_commits_url":"https://api.github.com/repos/oaeproject/Hilary/git/commits{/sha}","comments_url":"https://api.github.com/repos/oaeproject/Hilary/comments{/number}","issue_comment_url":"https://api.github.com/repos/oaeproject/Hilary/issues/comments/{number}","contents_url":"https://api.github.com/repos/oaeproject/Hilary/contents/{+path}","compare_url":"https://api.github.com/repos/oaeproject/Hilary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oaeproject/Hilary/merges","archive_url":"https://api.github.com/repos/oaeproject/Hilary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oaeproject/Hilary/downloads","issues_url":"https://api.github.com/repos/oaeproject/Hilary/issues{/number}","pulls_url":"https://api.github.com/repos/oaeproject/Hilary/pulls{/number}","milestones_url":"https://api.github.com/repos/oaeproject/Hilary/milestones{/number}","notifications_url":"https://api.github.com/repos/oaeproject/Hilary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oaeproject/Hilary/labels{/name}","releases_url":"https://api.github.com/repos/oaeproject/Hilary/releases{/id}","created_at":"2012-09-01T10:05:13Z","updated_at":"2014-07-10T23:04:09Z","pushed_at":"2014-07-11T09:28:57Z","git_url":"git://github.com/oaeproject/Hilary.git","ssh_url":"git@github.com:oaeproject/Hilary.git","clone_url":"https://github.com/oaeproject/Hilary.git","svn_url":"https://github.com/oaeproject/Hilary","homepage":"http://www.oaeproject.org","size":28650,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":60,"mirror_url":null,"open_issues_count":38,"forks":60,"open_issues":38,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/922"},"html":{"href":"https://github.com/oaeproject/Hilary/pull/922"},"issue":{"href":"https://api.github.com/repos/oaeproject/Hilary/issues/922"},"comments":{"href":"https://api.github.com/repos/oaeproject/Hilary/issues/922/comments"},"review_comments":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/922/comments"},"review_comment":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/922/commits"},"statuses":{"href":"https://api.github.com/repos/oaeproject/Hilary/statuses/732fecfd526789b5de562699b40509cf79230fc9"}}}}