GitHub PullRequestEvent at 2014-09-03 22:38:12
Repository: incubator-parquet-mr
Actor: asfgit
Payload: {"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/28","id":19240303,"html_url":"https://github.com/apache/incubator-parquet-mr/pull/28","diff_url":"https://github.com/apache/incubator-parquet-mr/pull/28.diff","patch_url":"https://github.com/apache/incubator-parquet-mr/pull/28.patch","issue_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/28","number":28,"state":"closed","locked":false,"title":"do ProtocolEvents fixing only when there is required fields missing in the requested schema","user":{"login":"tsdeng","id":169678,"avatar_url":"https://avatars.githubusercontent.com/u/169678?v=2","gravatar_id":"ca620c72bbf1e166fee392bc2a483f7f","url":"https://api.github.com/users/tsdeng","html_url":"https://github.com/tsdeng","followers_url":"https://api.github.com/users/tsdeng/followers","following_url":"https://api.github.com/users/tsdeng/following{/other_user}","gists_url":"https://api.github.com/users/tsdeng/gists{/gist_id}","starred_url":"https://api.github.com/users/tsdeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsdeng/subscriptions","organizations_url":"https://api.github.com/users/tsdeng/orgs","repos_url":"https://api.github.com/users/tsdeng/repos","events_url":"https://api.github.com/users/tsdeng/events{/privacy}","received_events_url":"https://api.github.com/users/tsdeng/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/PARQUET-61\r\nThis PR is trying to redo the https://github.com/apache/incubator-parquet-mr/pull/7\r\n\r\nIn this PR, it fixes the protocol event in a more precise condition:\r\nOnly when the requested schema missing some required fields that are present in the full schema\r\n\r\nSo even if there a projection, as long as the projection is not getting rid of the required field, the protocol events amender will not be called.\r\n\r\nCould you take a look at this ? @dvryaboy @yan-qi","created_at":"2014-08-02T00:07:02Z","updated_at":"2014-09-03T22:38:12Z","closed_at":"2014-09-03T22:38:12Z","merged_at":null,"merge_commit_sha":"5e8e3d8274c4c4438d11ab2f28ad88e96b85e235","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/28/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/28/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/28/comments","statuses_url":"https://api.github.com/repos/apache/incubator-parquet-mr/statuses/ba778b9ace0a0b6c8e43259180eb1dcfb8a4dba6","head":{"label":"tsdeng:fix_protocol_when_required_field_missing","ref":"fix_protocol_when_required_field_missing","sha":"ba778b9ace0a0b6c8e43259180eb1dcfb8a4dba6","user":{"login":"tsdeng","id":169678,"avatar_url":"https://avatars.githubusercontent.com/u/169678?v=2","gravatar_id":"ca620c72bbf1e166fee392bc2a483f7f","url":"https://api.github.com/users/tsdeng","html_url":"https://github.com/tsdeng","followers_url":"https://api.github.com/users/tsdeng/followers","following_url":"https://api.github.com/users/tsdeng/following{/other_user}","gists_url":"https://api.github.com/users/tsdeng/gists{/gist_id}","starred_url":"https://api.github.com/users/tsdeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsdeng/subscriptions","organizations_url":"https://api.github.com/users/tsdeng/orgs","repos_url":"https://api.github.com/users/tsdeng/repos","events_url":"https://api.github.com/users/tsdeng/events{/privacy}","received_events_url":"https://api.github.com/users/tsdeng/received_events","type":"User","site_admin":false},"repo":{"id":21713497,"name":"incubator-parquet-mr","full_name":"tsdeng/incubator-parquet-mr","owner":{"login":"tsdeng","id":169678,"avatar_url":"https://avatars.githubusercontent.com/u/169678?v=2","gravatar_id":"ca620c72bbf1e166fee392bc2a483f7f","url":"https://api.github.com/users/tsdeng","html_url":"https://github.com/tsdeng","followers_url":"https://api.github.com/users/tsdeng/followers","following_url":"https://api.github.com/users/tsdeng/following{/other_user}","gists_url":"https://api.github.com/users/tsdeng/gists{/gist_id}","starred_url":"https://api.github.com/users/tsdeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsdeng/subscriptions","organizations_url":"https://api.github.com/users/tsdeng/orgs","repos_url":"https://api.github.com/users/tsdeng/repos","events_url":"https://api.github.com/users/tsdeng/events{/privacy}","received_events_url":"https://api.github.com/users/tsdeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsdeng/incubator-parquet-mr","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr","forks_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/forks","keys_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/teams","hooks_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/events","assignees_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/tags","blobs_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/languages","stargazers_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/subscription","commits_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/issues/comments/{number}","contents_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/merges","archive_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/downloads","issues_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/tsdeng/incubator-parquet-mr/releases{/id}","created_at":"2014-07-10T23:11:24Z","updated_at":"2014-07-09T23:12:16Z","pushed_at":"2014-09-02T02:08:26Z","git_url":"git://github.com/tsdeng/incubator-parquet-mr.git","ssh_url":"git@github.com:tsdeng/incubator-parquet-mr.git","clone_url":"https://github.com/tsdeng/incubator-parquet-mr.git","svn_url":"https://github.com/tsdeng/incubator-parquet-mr","homepage":null,"size":11376,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0793e49b85d34135fee9f55030997d95f62af97b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675636,"name":"incubator-parquet-mr","full_name":"apache/incubator-parquet-mr","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=2","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-parquet-mr","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/incubator-parquet-mr","forks_url":"https://api.github.com/repos/apache/incubator-parquet-mr/forks","keys_url":"https://api.github.com/repos/apache/incubator-parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-parquet-mr/teams","hooks_url":"https://api.github.com/repos/apache/incubator-parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-parquet-mr/events","assignees_url":"https://api.github.com/repos/apache/incubator-parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-parquet-mr/tags","blobs_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-parquet-mr/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-parquet-mr/subscription","commits_url":"https://api.github.com/repos/apache/incubator-parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/incubator-parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-parquet-mr/merges","archive_url":"https://api.github.com/repos/apache/incubator-parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-parquet-mr/downloads","issues_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-parquet-mr/releases{/id}","created_at":"2014-06-10T07:00:07Z","updated_at":"2014-09-03T09:40:36Z","pushed_at":"2014-09-03T22:38:11Z","git_url":"git://github.com/apache/incubator-parquet-mr.git","ssh_url":"git@github.com:apache/incubator-parquet-mr.git","clone_url":"https://github.com/apache/incubator-parquet-mr.git","svn_url":"https://github.com/apache/incubator-parquet-mr","homepage":null,"size":218243,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":40,"mirror_url":"git://git.apache.org/incubator-parquet-mr.git","open_issues_count":14,"forks":40,"open_issues":14,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/28"},"html":{"href":"https://github.com/apache/incubator-parquet-mr/pull/28"},"issue":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/28"},"comments":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/statuses/ba778b9ace0a0b6c8e43259180eb1dcfb8a4dba6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":7,"review_comments":6,"commits":7,"additions":35,"deletions":2,"changed_files":1}}