GitHub PullRequestReviewCommentEvent at 2014-07-30 22:41:12
Repository: alloy
Actor: pinnamur
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/appcelerator/alloy/pulls/comments/15617431","id":15617431,"diff_hunk":"@@ -22,7 +22,7 @@ exports.init = function (logger, config, cli, appc) {\n \t\t\tprocess.env.sdk = cli.sdk.name;\n \t\t}\n \n-\tfunction run(deviceFamily, deployType, target, finished) {\n+\tfunction run(deviceFamily, deployType, target, finished, analyze) {","path":"hooks/alloy.js","position":5,"original_position":5,"commit_id":"4c3f435f75d0f3388cff0ee070d42187e025b133","original_commit_id":"4c3f435f75d0f3388cff0ee070d42187e025b133","user":{"login":"pinnamur","id":2413570,"avatar_url":"https://avatars.githubusercontent.com/u/2413570?v=1","gravatar_id":"485ab8835c0bd2317f30a229bcd02ced","url":"https://api.github.com/users/pinnamur","html_url":"https://github.com/pinnamur","followers_url":"https://api.github.com/users/pinnamur/followers","following_url":"https://api.github.com/users/pinnamur/following{/other_user}","gists_url":"https://api.github.com/users/pinnamur/gists{/gist_id}","starred_url":"https://api.github.com/users/pinnamur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinnamur/subscriptions","organizations_url":"https://api.github.com/users/pinnamur/orgs","repos_url":"https://api.github.com/users/pinnamur/repos","events_url":"https://api.github.com/users/pinnamur/events{/privacy}","received_events_url":"https://api.github.com/users/pinnamur/received_events","type":"User","site_admin":false},"body":"It might be good to call this argument more generic. Instead of making the argument specific to 'analyze', might be generic to call it as 'logging' ? and then pass false from the codeprocessor.pre.run event.","created_at":"2014-07-30T22:41:12Z","updated_at":"2014-07-30T22:41:12Z","html_url":"https://github.com/appcelerator/alloy/pull/495#discussion_r15617431","pull_request_url":"https://api.github.com/repos/appcelerator/alloy/pulls/495","_links":{"self":{"href":"https://api.github.com/repos/appcelerator/alloy/pulls/comments/15617431"},"html":{"href":"https://github.com/appcelerator/alloy/pull/495#discussion_r15617431"},"pull_request":{"href":"https://api.github.com/repos/appcelerator/alloy/pulls/495"}}},"pull_request":{"url":"https://api.github.com/repos/appcelerator/alloy/pulls/495","id":19098543,"html_url":"https://github.com/appcelerator/alloy/pull/495","diff_url":"https://github.com/appcelerator/alloy/pull/495.diff","patch_url":"https://github.com/appcelerator/alloy/pull/495.patch","issue_url":"https://api.github.com/repos/appcelerator/alloy/issues/495","number":495,"state":"open","title":"[ALOY-1099] Code analysis fails on Windows","user":{"login":"skypanther","id":507996,"avatar_url":"https://avatars.githubusercontent.com/u/507996?v=1","gravatar_id":"dd86787a6081fff59a8c290b076aef2f","url":"https://api.github.com/users/skypanther","html_url":"https://github.com/skypanther","followers_url":"https://api.github.com/users/skypanther/followers","following_url":"https://api.github.com/users/skypanther/following{/other_user}","gists_url":"https://api.github.com/users/skypanther/gists{/gist_id}","starred_url":"https://api.github.com/users/skypanther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skypanther/subscriptions","organizations_url":"https://api.github.com/users/skypanther/orgs","repos_url":"https://api.github.com/users/skypanther/repos","events_url":"https://api.github.com/users/skypanther/events{/privacy}","received_events_url":"https://api.github.com/users/skypanther/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-30T15:55:33Z","updated_at":"2014-07-30T22:41:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3038f651b0c96477efa178990b5d3184c0a5f5ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appcelerator/alloy/pulls/495/commits","review_comments_url":"https://api.github.com/repos/appcelerator/alloy/pulls/495/comments","review_comment_url":"https://api.github.com/repos/appcelerator/alloy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/appcelerator/alloy/issues/495/comments","statuses_url":"https://api.github.com/repos/appcelerator/alloy/statuses/4c3f435f75d0f3388cff0ee070d42187e025b133","head":{"label":"skypanther:ALOY-1099","ref":"ALOY-1099","sha":"4c3f435f75d0f3388cff0ee070d42187e025b133","user":{"login":"skypanther","id":507996,"avatar_url":"https://avatars.githubusercontent.com/u/507996?v=1","gravatar_id":"dd86787a6081fff59a8c290b076aef2f","url":"https://api.github.com/users/skypanther","html_url":"https://github.com/skypanther","followers_url":"https://api.github.com/users/skypanther/followers","following_url":"https://api.github.com/users/skypanther/following{/other_user}","gists_url":"https://api.github.com/users/skypanther/gists{/gist_id}","starred_url":"https://api.github.com/users/skypanther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skypanther/subscriptions","organizations_url":"https://api.github.com/users/skypanther/orgs","repos_url":"https://api.github.com/users/skypanther/repos","events_url":"https://api.github.com/users/skypanther/events{/privacy}","received_events_url":"https://api.github.com/users/skypanther/received_events","type":"User","site_admin":false},"repo":{"id":15877955,"name":"alloy","full_name":"skypanther/alloy","owner":{"login":"skypanther","id":507996,"avatar_url":"https://avatars.githubusercontent.com/u/507996?v=1","gravatar_id":"dd86787a6081fff59a8c290b076aef2f","url":"https://api.github.com/users/skypanther","html_url":"https://github.com/skypanther","followers_url":"https://api.github.com/users/skypanther/followers","following_url":"https://api.github.com/users/skypanther/following{/other_user}","gists_url":"https://api.github.com/users/skypanther/gists{/gist_id}","starred_url":"https://api.github.com/users/skypanther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skypanther/subscriptions","organizations_url":"https://api.github.com/users/skypanther/orgs","repos_url":"https://api.github.com/users/skypanther/repos","events_url":"https://api.github.com/users/skypanther/events{/privacy}","received_events_url":"https://api.github.com/users/skypanther/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skypanther/alloy","description":"Alloy is an MVC framework for Titanium which is developed by Appcelerator.","fork":true,"url":"https://api.github.com/repos/skypanther/alloy","forks_url":"https://api.github.com/repos/skypanther/alloy/forks","keys_url":"https://api.github.com/repos/skypanther/alloy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skypanther/alloy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skypanther/alloy/teams","hooks_url":"https://api.github.com/repos/skypanther/alloy/hooks","issue_events_url":"https://api.github.com/repos/skypanther/alloy/issues/events{/number}","events_url":"https://api.github.com/repos/skypanther/alloy/events","assignees_url":"https://api.github.com/repos/skypanther/alloy/assignees{/user}","branches_url":"https://api.github.com/repos/skypanther/alloy/branches{/branch}","tags_url":"https://api.github.com/repos/skypanther/alloy/tags","blobs_url":"https://api.github.com/repos/skypanther/alloy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skypanther/alloy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skypanther/alloy/git/refs{/sha}","trees_url":"https://api.github.com/repos/skypanther/alloy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skypanther/alloy/statuses/{sha}","languages_url":"https://api.github.com/repos/skypanther/alloy/languages","stargazers_url":"https://api.github.com/repos/skypanther/alloy/stargazers","contributors_url":"https://api.github.com/repos/skypanther/alloy/contributors","subscribers_url":"https://api.github.com/repos/skypanther/alloy/subscribers","subscription_url":"https://api.github.com/repos/skypanther/alloy/subscription","commits_url":"https://api.github.com/repos/skypanther/alloy/commits{/sha}","git_commits_url":"https://api.github.com/repos/skypanther/alloy/git/commits{/sha}","comments_url":"https://api.github.com/repos/skypanther/alloy/comments{/number}","issue_comment_url":"https://api.github.com/repos/skypanther/alloy/issues/comments/{number}","contents_url":"https://api.github.com/repos/skypanther/alloy/contents/{+path}","compare_url":"https://api.github.com/repos/skypanther/alloy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skypanther/alloy/merges","archive_url":"https://api.github.com/repos/skypanther/alloy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skypanther/alloy/downloads","issues_url":"https://api.github.com/repos/skypanther/alloy/issues{/number}","pulls_url":"https://api.github.com/repos/skypanther/alloy/pulls{/number}","milestones_url":"https://api.github.com/repos/skypanther/alloy/milestones{/number}","notifications_url":"https://api.github.com/repos/skypanther/alloy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skypanther/alloy/labels{/name}","releases_url":"https://api.github.com/repos/skypanther/alloy/releases{/id}","created_at":"2014-01-13T18:51:12Z","updated_at":"2014-06-26T17:41:51Z","pushed_at":"2014-07-30T20:38:41Z","git_url":"git://github.com/skypanther/alloy.git","ssh_url":"git@github.com:skypanther/alloy.git","clone_url":"https://github.com/skypanther/alloy.git","svn_url":"https://github.com/skypanther/alloy","homepage":"","size":24627,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appcelerator:master","ref":"master","sha":"e82a390becc2da0a43323a2710edb1b5c25cd04c","user":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=1","gravatar_id":"01d8a2b8546d6479cf4323d72cbed363","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"repo":{"id":4611433,"name":"alloy","full_name":"appcelerator/alloy","owner":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=1","gravatar_id":"01d8a2b8546d6479cf4323d72cbed363","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator/alloy","description":"Alloy is an MVC framework for Titanium which is developed by Appcelerator.","fork":false,"url":"https://api.github.com/repos/appcelerator/alloy","forks_url":"https://api.github.com/repos/appcelerator/alloy/forks","keys_url":"https://api.github.com/repos/appcelerator/alloy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator/alloy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator/alloy/teams","hooks_url":"https://api.github.com/repos/appcelerator/alloy/hooks","issue_events_url":"https://api.github.com/repos/appcelerator/alloy/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator/alloy/events","assignees_url":"https://api.github.com/repos/appcelerator/alloy/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator/alloy/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator/alloy/tags","blobs_url":"https://api.github.com/repos/appcelerator/alloy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator/alloy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator/alloy/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator/alloy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator/alloy/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator/alloy/languages","stargazers_url":"https://api.github.com/repos/appcelerator/alloy/stargazers","contributors_url":"https://api.github.com/repos/appcelerator/alloy/contributors","subscribers_url":"https://api.github.com/repos/appcelerator/alloy/subscribers","subscription_url":"https://api.github.com/repos/appcelerator/alloy/subscription","commits_url":"https://api.github.com/repos/appcelerator/alloy/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator/alloy/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator/alloy/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator/alloy/issues/comments/{number}","contents_url":"https://api.github.com/repos/appcelerator/alloy/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator/alloy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator/alloy/merges","archive_url":"https://api.github.com/repos/appcelerator/alloy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator/alloy/downloads","issues_url":"https://api.github.com/repos/appcelerator/alloy/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator/alloy/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator/alloy/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator/alloy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator/alloy/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator/alloy/releases{/id}","created_at":"2012-06-09T23:45:27Z","updated_at":"2014-07-28T00:27:37Z","pushed_at":"2014-07-30T20:37:14Z","git_url":"git://github.com/appcelerator/alloy.git","ssh_url":"git@github.com:appcelerator/alloy.git","clone_url":"https://github.com/appcelerator/alloy.git","svn_url":"https://github.com/appcelerator/alloy","homepage":"","size":42077,"stargazers_count":783,"watchers_count":783,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":782,"mirror_url":null,"open_issues_count":5,"forks":782,"open_issues":5,"watchers":783,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appcelerator/alloy/pulls/495"},"html":{"href":"https://github.com/appcelerator/alloy/pull/495"},"issue":{"href":"https://api.github.com/repos/appcelerator/alloy/issues/495"},"comments":{"href":"https://api.github.com/repos/appcelerator/alloy/issues/495/comments"},"review_comments":{"href":"https://api.github.com/repos/appcelerator/alloy/pulls/495/comments"},"review_comment":{"href":"https://api.github.com/repos/appcelerator/alloy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/appcelerator/alloy/pulls/495/commits"},"statuses":{"href":"https://api.github.com/repos/appcelerator/alloy/statuses/4c3f435f75d0f3388cff0ee070d42187e025b133"}}}}