GitHub PullRequestReviewCommentEvent at 2014-07-05 23:31:52
Repository: rust-by-example
Actor: japaric
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/japaric/rust-by-example/pulls/comments/14573137","id":14573137,"diff_hunk":"@@ -5,6 +5,10 @@ for example in $(find examples -type d -name \"*\"); do\n   if [[ -f ${html} ]]; then\n     echo ${html}\n \n-    sed -i s:${example#examples/}.md:${example}/input.md: ${html}\n+    if [[ `uname` == \"Darwin\" ]]; then","path":"fix-edit-button.sh","position":5,"original_position":5,"commit_id":"1fbd89a083f581e0926e8ae40178aa8ecdbeabe9","original_commit_id":"1fbd89a083f581e0926e8ae40178aa8ecdbeabe9","user":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?","gravatar_id":"7108576302fc097a6affdff3b34610ce","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"body":"> my initial fix on my machine was to update sed\r\n\r\nIs this particularly hard for a developer that uses mac?\r\n\r\nAnd more importantly, was it obvious that the sed program had to be updated/changed?\r\n\r\nIf the answers are yes and no, then we should modify that sed script.","created_at":"2014-07-05T23:31:52Z","updated_at":"2014-07-05T23:31:52Z","html_url":"https://github.com/japaric/rust-by-example/pull/158#discussion_r14573137","pull_request_url":"https://api.github.com/repos/japaric/rust-by-example/pulls/158","_links":{"self":{"href":"https://api.github.com/repos/japaric/rust-by-example/pulls/comments/14573137"},"html":{"href":"https://github.com/japaric/rust-by-example/pull/158#discussion_r14573137"},"pull_request":{"href":"https://api.github.com/repos/japaric/rust-by-example/pulls/158"}}},"pull_request":{"url":"https://api.github.com/repos/japaric/rust-by-example/pulls/158","id":17970776,"html_url":"https://github.com/japaric/rust-by-example/pull/158","diff_url":"https://github.com/japaric/rust-by-example/pull/158.diff","patch_url":"https://github.com/japaric/rust-by-example/pull/158.patch","issue_url":"https://api.github.com/repos/japaric/rust-by-example/issues/158","number":158,"state":"open","title":"Fix `make book` on Mac","user":{"login":"alxgnon","id":4480082,"avatar_url":"https://avatars.githubusercontent.com/u/4480082?","gravatar_id":"c42b2dfeb9e4ad18b2c34fef8efb1d76","url":"https://api.github.com/users/alxgnon","html_url":"https://github.com/alxgnon","followers_url":"https://api.github.com/users/alxgnon/followers","following_url":"https://api.github.com/users/alxgnon/following{/other_user}","gists_url":"https://api.github.com/users/alxgnon/gists{/gist_id}","starred_url":"https://api.github.com/users/alxgnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxgnon/subscriptions","organizations_url":"https://api.github.com/users/alxgnon/orgs","repos_url":"https://api.github.com/users/alxgnon/repos","events_url":"https://api.github.com/users/alxgnon/events{/privacy}","received_events_url":"https://api.github.com/users/alxgnon/received_events","type":"User","site_admin":false},"body":"The BSD version of sed included on Mac OSX has very primitive argument parsing. When running `make book`, `fix-edit-button.sh`'s sed call fails because the `-i` flag tries to associate with the sed script. My fix checks if `--version` succeeds to decide if it should use the BSD or GNU syntax.","created_at":"2014-07-03T21:58:26Z","updated_at":"2014-07-05T23:31:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a17aa4ae2d4e33116c120e321ec1d38d499bfb2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/japaric/rust-by-example/pulls/158/commits","review_comments_url":"https://api.github.com/repos/japaric/rust-by-example/pulls/158/comments","review_comment_url":"https://api.github.com/repos/japaric/rust-by-example/pulls/comments/{number}","comments_url":"https://api.github.com/repos/japaric/rust-by-example/issues/158/comments","statuses_url":"https://api.github.com/repos/japaric/rust-by-example/statuses/1fbd89a083f581e0926e8ae40178aa8ecdbeabe9","head":{"label":"alxgnon:sed-fix","ref":"sed-fix","sha":"1fbd89a083f581e0926e8ae40178aa8ecdbeabe9","user":{"login":"alxgnon","id":4480082,"avatar_url":"https://avatars.githubusercontent.com/u/4480082?","gravatar_id":"c42b2dfeb9e4ad18b2c34fef8efb1d76","url":"https://api.github.com/users/alxgnon","html_url":"https://github.com/alxgnon","followers_url":"https://api.github.com/users/alxgnon/followers","following_url":"https://api.github.com/users/alxgnon/following{/other_user}","gists_url":"https://api.github.com/users/alxgnon/gists{/gist_id}","starred_url":"https://api.github.com/users/alxgnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxgnon/subscriptions","organizations_url":"https://api.github.com/users/alxgnon/orgs","repos_url":"https://api.github.com/users/alxgnon/repos","events_url":"https://api.github.com/users/alxgnon/events{/privacy}","received_events_url":"https://api.github.com/users/alxgnon/received_events","type":"User","site_admin":false},"repo":{"id":21411998,"name":"rust-by-example","full_name":"alxgnon/rust-by-example","owner":{"login":"alxgnon","id":4480082,"avatar_url":"https://avatars.githubusercontent.com/u/4480082?","gravatar_id":"c42b2dfeb9e4ad18b2c34fef8efb1d76","url":"https://api.github.com/users/alxgnon","html_url":"https://github.com/alxgnon","followers_url":"https://api.github.com/users/alxgnon/followers","following_url":"https://api.github.com/users/alxgnon/following{/other_user}","gists_url":"https://api.github.com/users/alxgnon/gists{/gist_id}","starred_url":"https://api.github.com/users/alxgnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxgnon/subscriptions","organizations_url":"https://api.github.com/users/alxgnon/orgs","repos_url":"https://api.github.com/users/alxgnon/repos","events_url":"https://api.github.com/users/alxgnon/events{/privacy}","received_events_url":"https://api.github.com/users/alxgnon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alxgnon/rust-by-example","description":"Learn Rust with practical examples","fork":true,"url":"https://api.github.com/repos/alxgnon/rust-by-example","forks_url":"https://api.github.com/repos/alxgnon/rust-by-example/forks","keys_url":"https://api.github.com/repos/alxgnon/rust-by-example/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alxgnon/rust-by-example/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alxgnon/rust-by-example/teams","hooks_url":"https://api.github.com/repos/alxgnon/rust-by-example/hooks","issue_events_url":"https://api.github.com/repos/alxgnon/rust-by-example/issues/events{/number}","events_url":"https://api.github.com/repos/alxgnon/rust-by-example/events","assignees_url":"https://api.github.com/repos/alxgnon/rust-by-example/assignees{/user}","branches_url":"https://api.github.com/repos/alxgnon/rust-by-example/branches{/branch}","tags_url":"https://api.github.com/repos/alxgnon/rust-by-example/tags","blobs_url":"https://api.github.com/repos/alxgnon/rust-by-example/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alxgnon/rust-by-example/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alxgnon/rust-by-example/git/refs{/sha}","trees_url":"https://api.github.com/repos/alxgnon/rust-by-example/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alxgnon/rust-by-example/statuses/{sha}","languages_url":"https://api.github.com/repos/alxgnon/rust-by-example/languages","stargazers_url":"https://api.github.com/repos/alxgnon/rust-by-example/stargazers","contributors_url":"https://api.github.com/repos/alxgnon/rust-by-example/contributors","subscribers_url":"https://api.github.com/repos/alxgnon/rust-by-example/subscribers","subscription_url":"https://api.github.com/repos/alxgnon/rust-by-example/subscription","commits_url":"https://api.github.com/repos/alxgnon/rust-by-example/commits{/sha}","git_commits_url":"https://api.github.com/repos/alxgnon/rust-by-example/git/commits{/sha}","comments_url":"https://api.github.com/repos/alxgnon/rust-by-example/comments{/number}","issue_comment_url":"https://api.github.com/repos/alxgnon/rust-by-example/issues/comments/{number}","contents_url":"https://api.github.com/repos/alxgnon/rust-by-example/contents/{+path}","compare_url":"https://api.github.com/repos/alxgnon/rust-by-example/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alxgnon/rust-by-example/merges","archive_url":"https://api.github.com/repos/alxgnon/rust-by-example/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alxgnon/rust-by-example/downloads","issues_url":"https://api.github.com/repos/alxgnon/rust-by-example/issues{/number}","pulls_url":"https://api.github.com/repos/alxgnon/rust-by-example/pulls{/number}","milestones_url":"https://api.github.com/repos/alxgnon/rust-by-example/milestones{/number}","notifications_url":"https://api.github.com/repos/alxgnon/rust-by-example/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alxgnon/rust-by-example/labels{/name}","releases_url":"https://api.github.com/repos/alxgnon/rust-by-example/releases{/id}","created_at":"2014-07-02T04:59:05Z","updated_at":"2014-07-03T01:52:24Z","pushed_at":"2014-07-05T18:36:44Z","git_url":"git://github.com/alxgnon/rust-by-example.git","ssh_url":"git@github.com:alxgnon/rust-by-example.git","clone_url":"https://github.com/alxgnon/rust-by-example.git","svn_url":"https://github.com/alxgnon/rust-by-example","homepage":"http://rustbyexample.com","size":1500,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"japaric:master","ref":"master","sha":"08e5d7f336a6d6c1d9c4395566c5cc0afde43a58","user":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?","gravatar_id":"7108576302fc097a6affdff3b34610ce","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"repo":{"id":19126114,"name":"rust-by-example","full_name":"japaric/rust-by-example","owner":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?","gravatar_id":"7108576302fc097a6affdff3b34610ce","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/japaric/rust-by-example","description":"Learn Rust with practical examples","fork":false,"url":"https://api.github.com/repos/japaric/rust-by-example","forks_url":"https://api.github.com/repos/japaric/rust-by-example/forks","keys_url":"https://api.github.com/repos/japaric/rust-by-example/keys{/key_id}","collaborators_url":"https://api.github.com/repos/japaric/rust-by-example/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/japaric/rust-by-example/teams","hooks_url":"https://api.github.com/repos/japaric/rust-by-example/hooks","issue_events_url":"https://api.github.com/repos/japaric/rust-by-example/issues/events{/number}","events_url":"https://api.github.com/repos/japaric/rust-by-example/events","assignees_url":"https://api.github.com/repos/japaric/rust-by-example/assignees{/user}","branches_url":"https://api.github.com/repos/japaric/rust-by-example/branches{/branch}","tags_url":"https://api.github.com/repos/japaric/rust-by-example/tags","blobs_url":"https://api.github.com/repos/japaric/rust-by-example/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/japaric/rust-by-example/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/japaric/rust-by-example/git/refs{/sha}","trees_url":"https://api.github.com/repos/japaric/rust-by-example/git/trees{/sha}","statuses_url":"https://api.github.com/repos/japaric/rust-by-example/statuses/{sha}","languages_url":"https://api.github.com/repos/japaric/rust-by-example/languages","stargazers_url":"https://api.github.com/repos/japaric/rust-by-example/stargazers","contributors_url":"https://api.github.com/repos/japaric/rust-by-example/contributors","subscribers_url":"https://api.github.com/repos/japaric/rust-by-example/subscribers","subscription_url":"https://api.github.com/repos/japaric/rust-by-example/subscription","commits_url":"https://api.github.com/repos/japaric/rust-by-example/commits{/sha}","git_commits_url":"https://api.github.com/repos/japaric/rust-by-example/git/commits{/sha}","comments_url":"https://api.github.com/repos/japaric/rust-by-example/comments{/number}","issue_comment_url":"https://api.github.com/repos/japaric/rust-by-example/issues/comments/{number}","contents_url":"https://api.github.com/repos/japaric/rust-by-example/contents/{+path}","compare_url":"https://api.github.com/repos/japaric/rust-by-example/compare/{base}...{head}","merges_url":"https://api.github.com/repos/japaric/rust-by-example/merges","archive_url":"https://api.github.com/repos/japaric/rust-by-example/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/japaric/rust-by-example/downloads","issues_url":"https://api.github.com/repos/japaric/rust-by-example/issues{/number}","pulls_url":"https://api.github.com/repos/japaric/rust-by-example/pulls{/number}","milestones_url":"https://api.github.com/repos/japaric/rust-by-example/milestones{/number}","notifications_url":"https://api.github.com/repos/japaric/rust-by-example/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/japaric/rust-by-example/labels{/name}","releases_url":"https://api.github.com/repos/japaric/rust-by-example/releases{/id}","created_at":"2014-04-24T22:22:40Z","updated_at":"2014-07-05T21:15:37Z","pushed_at":"2014-07-05T16:43:18Z","git_url":"git://github.com/japaric/rust-by-example.git","ssh_url":"git@github.com:japaric/rust-by-example.git","clone_url":"https://github.com/japaric/rust-by-example.git","svn_url":"https://github.com/japaric/rust-by-example","homepage":"http://rustbyexample.com","size":7986,"stargazers_count":929,"watchers_count":929,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":54,"mirror_url":null,"open_issues_count":53,"forks":54,"open_issues":53,"watchers":929,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/japaric/rust-by-example/pulls/158"},"html":{"href":"https://github.com/japaric/rust-by-example/pull/158"},"issue":{"href":"https://api.github.com/repos/japaric/rust-by-example/issues/158"},"comments":{"href":"https://api.github.com/repos/japaric/rust-by-example/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/japaric/rust-by-example/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/japaric/rust-by-example/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/japaric/rust-by-example/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/japaric/rust-by-example/statuses/1fbd89a083f581e0926e8ae40178aa8ecdbeabe9"}}}}