GitHub PullRequestReviewCommentEvent at 2014-11-10 16:16:57
Repository: manageiq
Actor: Fryguy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/20091290","id":20091290,"diff_hunk":"@@ -1551,12 +1551,13 @@ def create_method\n       get_method_form_vars\n       add_aemethod = MiqAeMethod.new\n       set_method_record_vars(add_aemethod)                        # Set the record variables, but don't save\n+      fields = set_input_vars\n       begin\n         MiqAeMethod.transaction do\n           add_aemethod.save!\n           ae_method = MiqAeMethod.find_by_name_and_class_id(add_aemethod.name, from_cid(@edit[:ae_class_id]))\n-          @edit[:new][:fields].each do |fld|\n-            fld.method_id = ae_method.id\n+          fields.each do |fld|\n+            fld['method_id'] = ae_method.id\n             fld.save!","path":"vmdb/app/controllers/miq_ae_class_controller.rb","position":13,"original_position":13,"commit_id":"3e23f0f9f95b47f3349fc5fa6b071517dd6638dc","original_commit_id":"3e23f0f9f95b47f3349fc5fa6b071517dd6638dc","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"Why are we changing to update the attribute via `[]=`?  Can this just be `fld.update_attributes!(:method_id => ae_method.id)`","created_at":"2014-11-10T16:16:57Z","updated_at":"2014-11-10T16:16:57Z","html_url":"https://github.com/ManageIQ/manageiq/pull/1028#discussion_r20091290","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1028","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/20091290"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1028#discussion_r20091290"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1028"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1028","id":24083029,"html_url":"https://github.com/ManageIQ/manageiq/pull/1028","diff_url":"https://github.com/ManageIQ/manageiq/pull/1028.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/1028.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1028","number":1028,"state":"open","locked":false,"title":"Fixed saving on Input Parameters for Automate Method.","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"body":"- Fixed to set/save default value for datatype of an Automate Method Input field to be 'string'.\r\n- Fixed saving of input parameters when adding a new Method.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1161761\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1161701\r\n\r\n@dclarizio please review/test.","created_at":"2014-11-07T21:19:38Z","updated_at":"2014-11-10T16:16:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2755761e0dd159dc91cd59be4804095ea13625f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1028/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1028/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1028/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/3e23f0f9f95b47f3349fc5fa6b071517dd6638dc","head":{"label":"h-kataria:automate_method_editor_fix","ref":"automate_method_editor_fix","sha":"3e23f0f9f95b47f3349fc5fa6b071517dd6638dc","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"repo":{"id":20811753,"name":"manageiq","full_name":"h-kataria/manageiq","owner":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/h-kataria/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/h-kataria/manageiq","forks_url":"https://api.github.com/repos/h-kataria/manageiq/forks","keys_url":"https://api.github.com/repos/h-kataria/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h-kataria/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h-kataria/manageiq/teams","hooks_url":"https://api.github.com/repos/h-kataria/manageiq/hooks","issue_events_url":"https://api.github.com/repos/h-kataria/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/h-kataria/manageiq/events","assignees_url":"https://api.github.com/repos/h-kataria/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/h-kataria/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/h-kataria/manageiq/tags","blobs_url":"https://api.github.com/repos/h-kataria/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h-kataria/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h-kataria/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/h-kataria/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h-kataria/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/h-kataria/manageiq/languages","stargazers_url":"https://api.github.com/repos/h-kataria/manageiq/stargazers","contributors_url":"https://api.github.com/repos/h-kataria/manageiq/contributors","subscribers_url":"https://api.github.com/repos/h-kataria/manageiq/subscribers","subscription_url":"https://api.github.com/repos/h-kataria/manageiq/subscription","commits_url":"https://api.github.com/repos/h-kataria/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/h-kataria/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/h-kataria/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/h-kataria/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/h-kataria/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/h-kataria/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h-kataria/manageiq/merges","archive_url":"https://api.github.com/repos/h-kataria/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h-kataria/manageiq/downloads","issues_url":"https://api.github.com/repos/h-kataria/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/h-kataria/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/h-kataria/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/h-kataria/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h-kataria/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/h-kataria/manageiq/releases{/id}","created_at":"2014-06-13T17:15:09Z","updated_at":"2014-06-24T23:08:03Z","pushed_at":"2014-11-07T21:52:59Z","git_url":"git://github.com/h-kataria/manageiq.git","ssh_url":"git@github.com:h-kataria/manageiq.git","clone_url":"https://github.com/h-kataria/manageiq.git","svn_url":"https://github.com/h-kataria/manageiq","homepage":null,"size":60673,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"f284d015f58213063d7a0cfec5fd8fd926e3dd13","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2014-11-10T09:06:58Z","pushed_at":"2014-11-10T11:50:34Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":88699,"stargazers_count":65,"watchers_count":65,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":176,"forks":68,"open_issues":176,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1028"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1028"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1028"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1028/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1028/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1028/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/3e23f0f9f95b47f3349fc5fa6b071517dd6638dc"}}}}