GitHub PullRequestEvent at 2014-10-21 15:30:24
Repository: jsdom
Actor: Sebmaster
Payload: {"action":"opened","number":920,"pull_request":{"url":"https://api.github.com/repos/tmpvar/jsdom/pulls/920","id":23094398,"html_url":"https://github.com/tmpvar/jsdom/pull/920","diff_url":"https://github.com/tmpvar/jsdom/pull/920.diff","patch_url":"https://github.com/tmpvar/jsdom/pull/920.patch","issue_url":"https://api.github.com/repos/tmpvar/jsdom/issues/920","number":920,"state":"open","locked":false,"title":"Refactor DOMWindow","user":{"login":"Sebmaster","id":347870,"avatar_url":"https://avatars.githubusercontent.com/u/347870?v=2","gravatar_id":"","url":"https://api.github.com/users/Sebmaster","html_url":"https://github.com/Sebmaster","followers_url":"https://api.github.com/users/Sebmaster/followers","following_url":"https://api.github.com/users/Sebmaster/following{/other_user}","gists_url":"https://api.github.com/users/Sebmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/Sebmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sebmaster/subscriptions","organizations_url":"https://api.github.com/users/Sebmaster/orgs","repos_url":"https://api.github.com/users/Sebmaster/repos","events_url":"https://api.github.com/users/Sebmaster/events{/privacy}","received_events_url":"https://api.github.com/users/Sebmaster/received_events","type":"User","site_admin":false},"body":"This should only be a very basic starting point to demonstrate where I'm going with this.\r\n\r\nIn this first step we should get ```DOMWindow``` out of the clutter and give it its own file. The modifications done in the ```browserAugmentation``` method should be up next. We could just move the function patches to the window too.\r\n\r\nI'd also rename ```DOMWindow``` to just ```Window``` to align with the browser ```Window``` constructor.\r\n\r\nNote that this already breaks backwards compat since the level option won't have any effect on the level chosen anymore (always living).\r\n\r\nIn further steps we could then slowly migrate stuff which is currently buried in the levels files into the ```Window``` file; in the best case also factor them out into their own npm modules.","created_at":"2014-10-21T15:30:23Z","updated_at":"2014-10-21T15:30:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3206ea09a1959f927f08d03a00bb12173c5d7576","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/920/commits","review_comments_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/920/comments","review_comment_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/issues/920/comments","statuses_url":"https://api.github.com/repos/tmpvar/jsdom/statuses/34fee972a0c19cbe75034642ec3cfa591ad7ff8b","head":{"label":"Sebmaster:refactor/cleanup","ref":"refactor/cleanup","sha":"34fee972a0c19cbe75034642ec3cfa591ad7ff8b","user":{"login":"Sebmaster","id":347870,"avatar_url":"https://avatars.githubusercontent.com/u/347870?v=2","gravatar_id":"","url":"https://api.github.com/users/Sebmaster","html_url":"https://github.com/Sebmaster","followers_url":"https://api.github.com/users/Sebmaster/followers","following_url":"https://api.github.com/users/Sebmaster/following{/other_user}","gists_url":"https://api.github.com/users/Sebmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/Sebmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sebmaster/subscriptions","organizations_url":"https://api.github.com/users/Sebmaster/orgs","repos_url":"https://api.github.com/users/Sebmaster/repos","events_url":"https://api.github.com/users/Sebmaster/events{/privacy}","received_events_url":"https://api.github.com/users/Sebmaster/received_events","type":"User","site_admin":false},"repo":{"id":21370523,"name":"jsdom","full_name":"Sebmaster/jsdom","owner":{"login":"Sebmaster","id":347870,"avatar_url":"https://avatars.githubusercontent.com/u/347870?v=2","gravatar_id":"","url":"https://api.github.com/users/Sebmaster","html_url":"https://github.com/Sebmaster","followers_url":"https://api.github.com/users/Sebmaster/followers","following_url":"https://api.github.com/users/Sebmaster/following{/other_user}","gists_url":"https://api.github.com/users/Sebmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/Sebmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sebmaster/subscriptions","organizations_url":"https://api.github.com/users/Sebmaster/orgs","repos_url":"https://api.github.com/users/Sebmaster/repos","events_url":"https://api.github.com/users/Sebmaster/events{/privacy}","received_events_url":"https://api.github.com/users/Sebmaster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sebmaster/jsdom","description":"A javascript implementation of the DOM, for use with node.js.","fork":true,"url":"https://api.github.com/repos/Sebmaster/jsdom","forks_url":"https://api.github.com/repos/Sebmaster/jsdom/forks","keys_url":"https://api.github.com/repos/Sebmaster/jsdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sebmaster/jsdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sebmaster/jsdom/teams","hooks_url":"https://api.github.com/repos/Sebmaster/jsdom/hooks","issue_events_url":"https://api.github.com/repos/Sebmaster/jsdom/issues/events{/number}","events_url":"https://api.github.com/repos/Sebmaster/jsdom/events","assignees_url":"https://api.github.com/repos/Sebmaster/jsdom/assignees{/user}","branches_url":"https://api.github.com/repos/Sebmaster/jsdom/branches{/branch}","tags_url":"https://api.github.com/repos/Sebmaster/jsdom/tags","blobs_url":"https://api.github.com/repos/Sebmaster/jsdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sebmaster/jsdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sebmaster/jsdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sebmaster/jsdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sebmaster/jsdom/statuses/{sha}","languages_url":"https://api.github.com/repos/Sebmaster/jsdom/languages","stargazers_url":"https://api.github.com/repos/Sebmaster/jsdom/stargazers","contributors_url":"https://api.github.com/repos/Sebmaster/jsdom/contributors","subscribers_url":"https://api.github.com/repos/Sebmaster/jsdom/subscribers","subscription_url":"https://api.github.com/repos/Sebmaster/jsdom/subscription","commits_url":"https://api.github.com/repos/Sebmaster/jsdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sebmaster/jsdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sebmaster/jsdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sebmaster/jsdom/issues/comments/{number}","contents_url":"https://api.github.com/repos/Sebmaster/jsdom/contents/{+path}","compare_url":"https://api.github.com/repos/Sebmaster/jsdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sebmaster/jsdom/merges","archive_url":"https://api.github.com/repos/Sebmaster/jsdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sebmaster/jsdom/downloads","issues_url":"https://api.github.com/repos/Sebmaster/jsdom/issues{/number}","pulls_url":"https://api.github.com/repos/Sebmaster/jsdom/pulls{/number}","milestones_url":"https://api.github.com/repos/Sebmaster/jsdom/milestones{/number}","notifications_url":"https://api.github.com/repos/Sebmaster/jsdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sebmaster/jsdom/labels{/name}","releases_url":"https://api.github.com/repos/Sebmaster/jsdom/releases{/id}","created_at":"2014-07-01T00:42:08Z","updated_at":"2014-06-30T20:38:05Z","pushed_at":"2014-10-21T15:24:42Z","git_url":"git://github.com/Sebmaster/jsdom.git","ssh_url":"git@github.com:Sebmaster/jsdom.git","clone_url":"https://github.com/Sebmaster/jsdom.git","svn_url":"https://github.com/Sebmaster/jsdom","homepage":"","size":9399,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tmpvar:v2.0.0","ref":"v2.0.0","sha":"ab06ac56e7ef7869066fe97c8b5848159f7461c2","user":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=2","gravatar_id":"","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"repo":{"id":478584,"name":"jsdom","full_name":"tmpvar/jsdom","owner":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=2","gravatar_id":"","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmpvar/jsdom","description":"A javascript implementation of the DOM, for use with node.js.","fork":false,"url":"https://api.github.com/repos/tmpvar/jsdom","forks_url":"https://api.github.com/repos/tmpvar/jsdom/forks","keys_url":"https://api.github.com/repos/tmpvar/jsdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmpvar/jsdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmpvar/jsdom/teams","hooks_url":"https://api.github.com/repos/tmpvar/jsdom/hooks","issue_events_url":"https://api.github.com/repos/tmpvar/jsdom/issues/events{/number}","events_url":"https://api.github.com/repos/tmpvar/jsdom/events","assignees_url":"https://api.github.com/repos/tmpvar/jsdom/assignees{/user}","branches_url":"https://api.github.com/repos/tmpvar/jsdom/branches{/branch}","tags_url":"https://api.github.com/repos/tmpvar/jsdom/tags","blobs_url":"https://api.github.com/repos/tmpvar/jsdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmpvar/jsdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmpvar/jsdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmpvar/jsdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmpvar/jsdom/statuses/{sha}","languages_url":"https://api.github.com/repos/tmpvar/jsdom/languages","stargazers_url":"https://api.github.com/repos/tmpvar/jsdom/stargazers","contributors_url":"https://api.github.com/repos/tmpvar/jsdom/contributors","subscribers_url":"https://api.github.com/repos/tmpvar/jsdom/subscribers","subscription_url":"https://api.github.com/repos/tmpvar/jsdom/subscription","commits_url":"https://api.github.com/repos/tmpvar/jsdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmpvar/jsdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmpvar/jsdom/issues/comments/{number}","contents_url":"https://api.github.com/repos/tmpvar/jsdom/contents/{+path}","compare_url":"https://api.github.com/repos/tmpvar/jsdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmpvar/jsdom/merges","archive_url":"https://api.github.com/repos/tmpvar/jsdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmpvar/jsdom/downloads","issues_url":"https://api.github.com/repos/tmpvar/jsdom/issues{/number}","pulls_url":"https://api.github.com/repos/tmpvar/jsdom/pulls{/number}","milestones_url":"https://api.github.com/repos/tmpvar/jsdom/milestones{/number}","notifications_url":"https://api.github.com/repos/tmpvar/jsdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmpvar/jsdom/labels{/name}","releases_url":"https://api.github.com/repos/tmpvar/jsdom/releases{/id}","created_at":"2010-01-19T06:55:19Z","updated_at":"2014-10-21T05:21:42Z","pushed_at":"2014-10-21T15:24:32Z","git_url":"git://github.com/tmpvar/jsdom.git","ssh_url":"git@github.com:tmpvar/jsdom.git","clone_url":"https://github.com/tmpvar/jsdom.git","svn_url":"https://github.com/tmpvar/jsdom","homepage":"","size":15647,"stargazers_count":3400,"watchers_count":3400,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":409,"mirror_url":null,"open_issues_count":94,"forks":409,"open_issues":94,"watchers":3400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/920"},"html":{"href":"https://github.com/tmpvar/jsdom/pull/920"},"issue":{"href":"https://api.github.com/repos/tmpvar/jsdom/issues/920"},"comments":{"href":"https://api.github.com/repos/tmpvar/jsdom/issues/920/comments"},"review_comments":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/920/comments"},"review_comment":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/920/commits"},"statuses":{"href":"https://api.github.com/repos/tmpvar/jsdom/statuses/34fee972a0c19cbe75034642ec3cfa591ad7ff8b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":269,"deletions":268,"changed_files":3}}