GitHub PullRequestReviewCommentEvent at 2014-11-19 14:21:19
Repository: geb
Actor: erdi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/geb/geb/pulls/comments/20576762","id":20576762,"diff_hunk":"@@ -131,6 +132,55 @@ interface Navigator extends Iterable<Navigator> {\n \tNavigator find(String selector, Range<Integer> range)\n \n \t/**\n+\t * Selects elements by both CSS selector and attributes. For example find(\"input\", name: \"firstName\") will select\n+\t * all input elements with the name \"firstName\".\n+\t * @param bySelector a selenium By selector\n+\t * @param predicates a Map with keys representing attributes and values representing required values or patterns\n+\t * @return a new Navigator instance containing the matched elements\n+\t */\n+\tNavigator find(Map<String, Object> predicates, By bySelector)\n+\n+\t/**\n+\t * Shorthand for <code>find(predicates, selector, index..index)</code>","path":"module/geb-core/src/main/groovy/geb/navigator/Navigator.groovy","position":21,"original_position":21,"commit_id":"c092bde771f67654c853c3d5366f98d21f2c4fa4","original_commit_id":"c092bde771f67654c853c3d5366f98d21f2c4fa4","user":{"login":"erdi","id":205451,"avatar_url":"https://avatars.githubusercontent.com/u/205451?v=3","gravatar_id":"","url":"https://api.github.com/users/erdi","html_url":"https://github.com/erdi","followers_url":"https://api.github.com/users/erdi/followers","following_url":"https://api.github.com/users/erdi/following{/other_user}","gists_url":"https://api.github.com/users/erdi/gists{/gist_id}","starred_url":"https://api.github.com/users/erdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdi/subscriptions","organizations_url":"https://api.github.com/users/erdi/orgs","repos_url":"https://api.github.com/users/erdi/repos","events_url":"https://api.github.com/users/erdi/events{/privacy}","received_events_url":"https://api.github.com/users/erdi/received_events","type":"User","site_admin":false},"body":"`bySelector` instead of selector","created_at":"2014-11-19T14:21:19Z","updated_at":"2014-11-19T14:21:19Z","html_url":"https://github.com/geb/geb/pull/82#discussion_r20576762","pull_request_url":"https://api.github.com/repos/geb/geb/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/geb/geb/pulls/comments/20576762"},"html":{"href":"https://github.com/geb/geb/pull/82#discussion_r20576762"},"pull_request":{"href":"https://api.github.com/repos/geb/geb/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/geb/geb/pulls/82","id":24669214,"html_url":"https://github.com/geb/geb/pull/82","diff_url":"https://github.com/geb/geb/pull/82.diff","patch_url":"https://github.com/geb/geb/pull/82.patch","issue_url":"https://api.github.com/repos/geb/geb/issues/82","number":82,"state":"open","locked":false,"title":"Selenium By locator support in Geb","user":{"login":"menonvarun","id":1027015,"avatar_url":"https://avatars.githubusercontent.com/u/1027015?v=3","gravatar_id":"","url":"https://api.github.com/users/menonvarun","html_url":"https://github.com/menonvarun","followers_url":"https://api.github.com/users/menonvarun/followers","following_url":"https://api.github.com/users/menonvarun/following{/other_user}","gists_url":"https://api.github.com/users/menonvarun/gists{/gist_id}","starred_url":"https://api.github.com/users/menonvarun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menonvarun/subscriptions","organizations_url":"https://api.github.com/users/menonvarun/orgs","repos_url":"https://api.github.com/users/menonvarun/repos","events_url":"https://api.github.com/users/menonvarun/events{/privacy}","received_events_url":"https://api.github.com/users/menonvarun/received_events","type":"User","site_admin":false},"body":"The following pull request adds support of using Selenium By class locating strategy in Geb.\r\n\r\nThis is based on the following geb-users discussion:\r\n\r\nhttp://markmail.org/thread/qx3yjz4hwcce5oy2","created_at":"2014-11-19T06:56:06Z","updated_at":"2014-11-19T14:21:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a37a38e0158c42135860b2299094a9ffec80468e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geb/geb/pulls/82/commits","review_comments_url":"https://api.github.com/repos/geb/geb/pulls/82/comments","review_comment_url":"https://api.github.com/repos/geb/geb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/geb/geb/issues/82/comments","statuses_url":"https://api.github.com/repos/geb/geb/statuses/c092bde771f67654c853c3d5366f98d21f2c4fa4","head":{"label":"menonvarun:by_locator_support","ref":"by_locator_support","sha":"c092bde771f67654c853c3d5366f98d21f2c4fa4","user":{"login":"menonvarun","id":1027015,"avatar_url":"https://avatars.githubusercontent.com/u/1027015?v=3","gravatar_id":"","url":"https://api.github.com/users/menonvarun","html_url":"https://github.com/menonvarun","followers_url":"https://api.github.com/users/menonvarun/followers","following_url":"https://api.github.com/users/menonvarun/following{/other_user}","gists_url":"https://api.github.com/users/menonvarun/gists{/gist_id}","starred_url":"https://api.github.com/users/menonvarun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menonvarun/subscriptions","organizations_url":"https://api.github.com/users/menonvarun/orgs","repos_url":"https://api.github.com/users/menonvarun/repos","events_url":"https://api.github.com/users/menonvarun/events{/privacy}","received_events_url":"https://api.github.com/users/menonvarun/received_events","type":"User","site_admin":false},"repo":{"id":21294896,"name":"geb","full_name":"menonvarun/geb","owner":{"login":"menonvarun","id":1027015,"avatar_url":"https://avatars.githubusercontent.com/u/1027015?v=3","gravatar_id":"","url":"https://api.github.com/users/menonvarun","html_url":"https://github.com/menonvarun","followers_url":"https://api.github.com/users/menonvarun/followers","following_url":"https://api.github.com/users/menonvarun/following{/other_user}","gists_url":"https://api.github.com/users/menonvarun/gists{/gist_id}","starred_url":"https://api.github.com/users/menonvarun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menonvarun/subscriptions","organizations_url":"https://api.github.com/users/menonvarun/orgs","repos_url":"https://api.github.com/users/menonvarun/repos","events_url":"https://api.github.com/users/menonvarun/events{/privacy}","received_events_url":"https://api.github.com/users/menonvarun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/menonvarun/geb","description":"Very Groovy Browser Automation","fork":true,"url":"https://api.github.com/repos/menonvarun/geb","forks_url":"https://api.github.com/repos/menonvarun/geb/forks","keys_url":"https://api.github.com/repos/menonvarun/geb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/menonvarun/geb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/menonvarun/geb/teams","hooks_url":"https://api.github.com/repos/menonvarun/geb/hooks","issue_events_url":"https://api.github.com/repos/menonvarun/geb/issues/events{/number}","events_url":"https://api.github.com/repos/menonvarun/geb/events","assignees_url":"https://api.github.com/repos/menonvarun/geb/assignees{/user}","branches_url":"https://api.github.com/repos/menonvarun/geb/branches{/branch}","tags_url":"https://api.github.com/repos/menonvarun/geb/tags","blobs_url":"https://api.github.com/repos/menonvarun/geb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/menonvarun/geb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/menonvarun/geb/git/refs{/sha}","trees_url":"https://api.github.com/repos/menonvarun/geb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/menonvarun/geb/statuses/{sha}","languages_url":"https://api.github.com/repos/menonvarun/geb/languages","stargazers_url":"https://api.github.com/repos/menonvarun/geb/stargazers","contributors_url":"https://api.github.com/repos/menonvarun/geb/contributors","subscribers_url":"https://api.github.com/repos/menonvarun/geb/subscribers","subscription_url":"https://api.github.com/repos/menonvarun/geb/subscription","commits_url":"https://api.github.com/repos/menonvarun/geb/commits{/sha}","git_commits_url":"https://api.github.com/repos/menonvarun/geb/git/commits{/sha}","comments_url":"https://api.github.com/repos/menonvarun/geb/comments{/number}","issue_comment_url":"https://api.github.com/repos/menonvarun/geb/issues/comments/{number}","contents_url":"https://api.github.com/repos/menonvarun/geb/contents/{+path}","compare_url":"https://api.github.com/repos/menonvarun/geb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/menonvarun/geb/merges","archive_url":"https://api.github.com/repos/menonvarun/geb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/menonvarun/geb/downloads","issues_url":"https://api.github.com/repos/menonvarun/geb/issues{/number}","pulls_url":"https://api.github.com/repos/menonvarun/geb/pulls{/number}","milestones_url":"https://api.github.com/repos/menonvarun/geb/milestones{/number}","notifications_url":"https://api.github.com/repos/menonvarun/geb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/menonvarun/geb/labels{/name}","releases_url":"https://api.github.com/repos/menonvarun/geb/releases{/id}","created_at":"2014-06-28T03:02:26Z","updated_at":"2014-11-19T07:12:10Z","pushed_at":"2014-11-19T07:12:10Z","git_url":"git://github.com/menonvarun/geb.git","ssh_url":"git@github.com:menonvarun/geb.git","clone_url":"https://github.com/menonvarun/geb.git","svn_url":"https://github.com/menonvarun/geb","homepage":"http://www.gebish.org","size":3993,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geb:master","ref":"master","sha":"099e9f4f842a7117ec671586d2c8c8bede65ea9e","user":{"login":"geb","id":352388,"avatar_url":"https://avatars.githubusercontent.com/u/352388?v=3","gravatar_id":"","url":"https://api.github.com/users/geb","html_url":"https://github.com/geb","followers_url":"https://api.github.com/users/geb/followers","following_url":"https://api.github.com/users/geb/following{/other_user}","gists_url":"https://api.github.com/users/geb/gists{/gist_id}","starred_url":"https://api.github.com/users/geb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geb/subscriptions","organizations_url":"https://api.github.com/users/geb/orgs","repos_url":"https://api.github.com/users/geb/repos","events_url":"https://api.github.com/users/geb/events{/privacy}","received_events_url":"https://api.github.com/users/geb/received_events","type":"Organization","site_admin":false},"repo":{"id":813783,"name":"geb","full_name":"geb/geb","owner":{"login":"geb","id":352388,"avatar_url":"https://avatars.githubusercontent.com/u/352388?v=3","gravatar_id":"","url":"https://api.github.com/users/geb","html_url":"https://github.com/geb","followers_url":"https://api.github.com/users/geb/followers","following_url":"https://api.github.com/users/geb/following{/other_user}","gists_url":"https://api.github.com/users/geb/gists{/gist_id}","starred_url":"https://api.github.com/users/geb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geb/subscriptions","organizations_url":"https://api.github.com/users/geb/orgs","repos_url":"https://api.github.com/users/geb/repos","events_url":"https://api.github.com/users/geb/events{/privacy}","received_events_url":"https://api.github.com/users/geb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geb/geb","description":"Very Groovy Browser Automation","fork":false,"url":"https://api.github.com/repos/geb/geb","forks_url":"https://api.github.com/repos/geb/geb/forks","keys_url":"https://api.github.com/repos/geb/geb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geb/geb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geb/geb/teams","hooks_url":"https://api.github.com/repos/geb/geb/hooks","issue_events_url":"https://api.github.com/repos/geb/geb/issues/events{/number}","events_url":"https://api.github.com/repos/geb/geb/events","assignees_url":"https://api.github.com/repos/geb/geb/assignees{/user}","branches_url":"https://api.github.com/repos/geb/geb/branches{/branch}","tags_url":"https://api.github.com/repos/geb/geb/tags","blobs_url":"https://api.github.com/repos/geb/geb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geb/geb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geb/geb/git/refs{/sha}","trees_url":"https://api.github.com/repos/geb/geb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geb/geb/statuses/{sha}","languages_url":"https://api.github.com/repos/geb/geb/languages","stargazers_url":"https://api.github.com/repos/geb/geb/stargazers","contributors_url":"https://api.github.com/repos/geb/geb/contributors","subscribers_url":"https://api.github.com/repos/geb/geb/subscribers","subscription_url":"https://api.github.com/repos/geb/geb/subscription","commits_url":"https://api.github.com/repos/geb/geb/commits{/sha}","git_commits_url":"https://api.github.com/repos/geb/geb/git/commits{/sha}","comments_url":"https://api.github.com/repos/geb/geb/comments{/number}","issue_comment_url":"https://api.github.com/repos/geb/geb/issues/comments/{number}","contents_url":"https://api.github.com/repos/geb/geb/contents/{+path}","compare_url":"https://api.github.com/repos/geb/geb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geb/geb/merges","archive_url":"https://api.github.com/repos/geb/geb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geb/geb/downloads","issues_url":"https://api.github.com/repos/geb/geb/issues{/number}","pulls_url":"https://api.github.com/repos/geb/geb/pulls{/number}","milestones_url":"https://api.github.com/repos/geb/geb/milestones{/number}","notifications_url":"https://api.github.com/repos/geb/geb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geb/geb/labels{/name}","releases_url":"https://api.github.com/repos/geb/geb/releases{/id}","created_at":"2010-08-03T03:58:46Z","updated_at":"2014-11-18T07:27:49Z","pushed_at":"2014-10-21T19:30:00Z","git_url":"git://github.com/geb/geb.git","ssh_url":"git@github.com:geb/geb.git","clone_url":"https://github.com/geb/geb.git","svn_url":"https://github.com/geb/geb","homepage":"http://www.gebish.org","size":6784,"stargazers_count":369,"watchers_count":369,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":1,"forks":106,"open_issues":1,"watchers":369,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geb/geb/pulls/82"},"html":{"href":"https://github.com/geb/geb/pull/82"},"issue":{"href":"https://api.github.com/repos/geb/geb/issues/82"},"comments":{"href":"https://api.github.com/repos/geb/geb/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/geb/geb/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/geb/geb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/geb/geb/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/geb/geb/statuses/c092bde771f67654c853c3d5366f98d21f2c4fa4"}}}}