GitHub PullRequestEvent at 2014-10-24 23:07:43
Repository: jPushMenu
Actor: juliangut
Payload: {"action":"opened","number":17,"pull_request":{"url":"https://api.github.com/repos/takien/jPushMenu/pulls/17","id":23330386,"html_url":"https://github.com/takien/jPushMenu/pull/17","diff_url":"https://github.com/takien/jPushMenu/pull/17.diff","patch_url":"https://github.com/takien/jPushMenu/pull/17.patch","issue_url":"https://api.github.com/repos/takien/jPushMenu/issues/17","number":17,"state":"open","locked":false,"title":"Handle undefined/wrong menu types and properly remove classes on close","user":{"login":"juliangut","id":1104131,"avatar_url":"https://avatars.githubusercontent.com/u/1104131?v=2","gravatar_id":"","url":"https://api.github.com/users/juliangut","html_url":"https://github.com/juliangut","followers_url":"https://api.github.com/users/juliangut/followers","following_url":"https://api.github.com/users/juliangut/following{/other_user}","gists_url":"https://api.github.com/users/juliangut/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangut/subscriptions","organizations_url":"https://api.github.com/users/juliangut/orgs","repos_url":"https://api.github.com/users/juliangut/repos","events_url":"https://api.github.com/users/juliangut/events{/privacy}","received_events_url":"https://api.github.com/users/juliangut/received_events","type":"User","site_admin":false},"body":"Basically:\r\n\r\n* Handle undefined/wrong menu types (line 40)\r\n* Properly assign classes to elements (line 47-48)\r\n* and remove classes on close (line 60)\r\n\r\nAdditionally remove closeOnClickInside as it was a carbon copy of closeOnClickOutside\r\n\r\nIt also would be nice to make the package available through bower by:\r\n\r\n```sh\r\nbower register jPushMenu git://github.com/takien/jPushMenu.git\r\n```\r\n\r\nbecause now if you look for it or try to install it through bower raises an error\r\n\r\nbtw sorry for the reformatting, my editor is configured to do so automatically","created_at":"2014-10-24T23:07:43Z","updated_at":"2014-10-24T23:07:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/takien/jPushMenu/pulls/17/commits","review_comments_url":"https://api.github.com/repos/takien/jPushMenu/pulls/17/comments","review_comment_url":"https://api.github.com/repos/takien/jPushMenu/pulls/comments/{number}","comments_url":"https://api.github.com/repos/takien/jPushMenu/issues/17/comments","statuses_url":"https://api.github.com/repos/takien/jPushMenu/statuses/9c2b7e4cfb2d33ed43b5af1876af91117d1ad60b","head":{"label":"juliangut:master","ref":"master","sha":"9c2b7e4cfb2d33ed43b5af1876af91117d1ad60b","user":{"login":"juliangut","id":1104131,"avatar_url":"https://avatars.githubusercontent.com/u/1104131?v=2","gravatar_id":"","url":"https://api.github.com/users/juliangut","html_url":"https://github.com/juliangut","followers_url":"https://api.github.com/users/juliangut/followers","following_url":"https://api.github.com/users/juliangut/following{/other_user}","gists_url":"https://api.github.com/users/juliangut/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangut/subscriptions","organizations_url":"https://api.github.com/users/juliangut/orgs","repos_url":"https://api.github.com/users/juliangut/repos","events_url":"https://api.github.com/users/juliangut/events{/privacy}","received_events_url":"https://api.github.com/users/juliangut/received_events","type":"User","site_admin":false},"repo":{"id":25708906,"name":"jPushMenu","full_name":"juliangut/jPushMenu","owner":{"login":"juliangut","id":1104131,"avatar_url":"https://avatars.githubusercontent.com/u/1104131?v=2","gravatar_id":"","url":"https://api.github.com/users/juliangut","html_url":"https://github.com/juliangut","followers_url":"https://api.github.com/users/juliangut/followers","following_url":"https://api.github.com/users/juliangut/following{/other_user}","gists_url":"https://api.github.com/users/juliangut/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangut/subscriptions","organizations_url":"https://api.github.com/users/juliangut/orgs","repos_url":"https://api.github.com/users/juliangut/repos","events_url":"https://api.github.com/users/juliangut/events{/privacy}","received_events_url":"https://api.github.com/users/juliangut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juliangut/jPushMenu","description":"Various slide menu","fork":true,"url":"https://api.github.com/repos/juliangut/jPushMenu","forks_url":"https://api.github.com/repos/juliangut/jPushMenu/forks","keys_url":"https://api.github.com/repos/juliangut/jPushMenu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juliangut/jPushMenu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juliangut/jPushMenu/teams","hooks_url":"https://api.github.com/repos/juliangut/jPushMenu/hooks","issue_events_url":"https://api.github.com/repos/juliangut/jPushMenu/issues/events{/number}","events_url":"https://api.github.com/repos/juliangut/jPushMenu/events","assignees_url":"https://api.github.com/repos/juliangut/jPushMenu/assignees{/user}","branches_url":"https://api.github.com/repos/juliangut/jPushMenu/branches{/branch}","tags_url":"https://api.github.com/repos/juliangut/jPushMenu/tags","blobs_url":"https://api.github.com/repos/juliangut/jPushMenu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juliangut/jPushMenu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juliangut/jPushMenu/git/refs{/sha}","trees_url":"https://api.github.com/repos/juliangut/jPushMenu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juliangut/jPushMenu/statuses/{sha}","languages_url":"https://api.github.com/repos/juliangut/jPushMenu/languages","stargazers_url":"https://api.github.com/repos/juliangut/jPushMenu/stargazers","contributors_url":"https://api.github.com/repos/juliangut/jPushMenu/contributors","subscribers_url":"https://api.github.com/repos/juliangut/jPushMenu/subscribers","subscription_url":"https://api.github.com/repos/juliangut/jPushMenu/subscription","commits_url":"https://api.github.com/repos/juliangut/jPushMenu/commits{/sha}","git_commits_url":"https://api.github.com/repos/juliangut/jPushMenu/git/commits{/sha}","comments_url":"https://api.github.com/repos/juliangut/jPushMenu/comments{/number}","issue_comment_url":"https://api.github.com/repos/juliangut/jPushMenu/issues/comments/{number}","contents_url":"https://api.github.com/repos/juliangut/jPushMenu/contents/{+path}","compare_url":"https://api.github.com/repos/juliangut/jPushMenu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juliangut/jPushMenu/merges","archive_url":"https://api.github.com/repos/juliangut/jPushMenu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juliangut/jPushMenu/downloads","issues_url":"https://api.github.com/repos/juliangut/jPushMenu/issues{/number}","pulls_url":"https://api.github.com/repos/juliangut/jPushMenu/pulls{/number}","milestones_url":"https://api.github.com/repos/juliangut/jPushMenu/milestones{/number}","notifications_url":"https://api.github.com/repos/juliangut/jPushMenu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juliangut/jPushMenu/labels{/name}","releases_url":"https://api.github.com/repos/juliangut/jPushMenu/releases{/id}","created_at":"2014-10-24T21:25:20Z","updated_at":"2014-10-24T22:49:09Z","pushed_at":"2014-10-24T23:04:55Z","git_url":"git://github.com/juliangut/jPushMenu.git","ssh_url":"git@github.com:juliangut/jPushMenu.git","clone_url":"https://github.com/juliangut/jPushMenu.git","svn_url":"https://github.com/juliangut/jPushMenu","homepage":null,"size":233,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"takien:master","ref":"master","sha":"4db20895a6c4615f54ef2d51c99c520bb6fe6413","user":{"login":"takien","id":173207,"avatar_url":"https://avatars.githubusercontent.com/u/173207?v=2","gravatar_id":"","url":"https://api.github.com/users/takien","html_url":"https://github.com/takien","followers_url":"https://api.github.com/users/takien/followers","following_url":"https://api.github.com/users/takien/following{/other_user}","gists_url":"https://api.github.com/users/takien/gists{/gist_id}","starred_url":"https://api.github.com/users/takien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takien/subscriptions","organizations_url":"https://api.github.com/users/takien/orgs","repos_url":"https://api.github.com/users/takien/repos","events_url":"https://api.github.com/users/takien/events{/privacy}","received_events_url":"https://api.github.com/users/takien/received_events","type":"User","site_admin":false},"repo":{"id":9604457,"name":"jPushMenu","full_name":"takien/jPushMenu","owner":{"login":"takien","id":173207,"avatar_url":"https://avatars.githubusercontent.com/u/173207?v=2","gravatar_id":"","url":"https://api.github.com/users/takien","html_url":"https://github.com/takien","followers_url":"https://api.github.com/users/takien/followers","following_url":"https://api.github.com/users/takien/following{/other_user}","gists_url":"https://api.github.com/users/takien/gists{/gist_id}","starred_url":"https://api.github.com/users/takien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takien/subscriptions","organizations_url":"https://api.github.com/users/takien/orgs","repos_url":"https://api.github.com/users/takien/repos","events_url":"https://api.github.com/users/takien/events{/privacy}","received_events_url":"https://api.github.com/users/takien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/takien/jPushMenu","description":"Various slide menu","fork":false,"url":"https://api.github.com/repos/takien/jPushMenu","forks_url":"https://api.github.com/repos/takien/jPushMenu/forks","keys_url":"https://api.github.com/repos/takien/jPushMenu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takien/jPushMenu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takien/jPushMenu/teams","hooks_url":"https://api.github.com/repos/takien/jPushMenu/hooks","issue_events_url":"https://api.github.com/repos/takien/jPushMenu/issues/events{/number}","events_url":"https://api.github.com/repos/takien/jPushMenu/events","assignees_url":"https://api.github.com/repos/takien/jPushMenu/assignees{/user}","branches_url":"https://api.github.com/repos/takien/jPushMenu/branches{/branch}","tags_url":"https://api.github.com/repos/takien/jPushMenu/tags","blobs_url":"https://api.github.com/repos/takien/jPushMenu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takien/jPushMenu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takien/jPushMenu/git/refs{/sha}","trees_url":"https://api.github.com/repos/takien/jPushMenu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takien/jPushMenu/statuses/{sha}","languages_url":"https://api.github.com/repos/takien/jPushMenu/languages","stargazers_url":"https://api.github.com/repos/takien/jPushMenu/stargazers","contributors_url":"https://api.github.com/repos/takien/jPushMenu/contributors","subscribers_url":"https://api.github.com/repos/takien/jPushMenu/subscribers","subscription_url":"https://api.github.com/repos/takien/jPushMenu/subscription","commits_url":"https://api.github.com/repos/takien/jPushMenu/commits{/sha}","git_commits_url":"https://api.github.com/repos/takien/jPushMenu/git/commits{/sha}","comments_url":"https://api.github.com/repos/takien/jPushMenu/comments{/number}","issue_comment_url":"https://api.github.com/repos/takien/jPushMenu/issues/comments/{number}","contents_url":"https://api.github.com/repos/takien/jPushMenu/contents/{+path}","compare_url":"https://api.github.com/repos/takien/jPushMenu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takien/jPushMenu/merges","archive_url":"https://api.github.com/repos/takien/jPushMenu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takien/jPushMenu/downloads","issues_url":"https://api.github.com/repos/takien/jPushMenu/issues{/number}","pulls_url":"https://api.github.com/repos/takien/jPushMenu/pulls{/number}","milestones_url":"https://api.github.com/repos/takien/jPushMenu/milestones{/number}","notifications_url":"https://api.github.com/repos/takien/jPushMenu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takien/jPushMenu/labels{/name}","releases_url":"https://api.github.com/repos/takien/jPushMenu/releases{/id}","created_at":"2013-04-22T17:16:32Z","updated_at":"2014-10-24T20:22:28Z","pushed_at":"2014-10-21T13:41:48Z","git_url":"git://github.com/takien/jPushMenu.git","ssh_url":"git@github.com:takien/jPushMenu.git","clone_url":"https://github.com/takien/jPushMenu.git","svn_url":"https://github.com/takien/jPushMenu","homepage":null,"size":233,"stargazers_count":82,"watchers_count":82,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"open_issues_count":9,"forks":35,"open_issues":9,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/takien/jPushMenu/pulls/17"},"html":{"href":"https://github.com/takien/jPushMenu/pull/17"},"issue":{"href":"https://api.github.com/repos/takien/jPushMenu/issues/17"},"comments":{"href":"https://api.github.com/repos/takien/jPushMenu/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/takien/jPushMenu/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/takien/jPushMenu/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/takien/jPushMenu/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/takien/jPushMenu/statuses/9c2b7e4cfb2d33ed43b5af1876af91117d1ad60b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":172,"deletions":184,"changed_files":3}}