GitHub IssueCommentEvent at 2015-01-01 21:25:02
Repository: jeffh/sniffer
Actor: jeffh
Payload: {"action":"created","issue":{"url":"https://api.github.com/repos/jeffh/sniffer/issues/20","labels_url":"https://api.github.com/repos/jeffh/sniffer/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/jeffh/sniffer/issues/20/comments","events_url":"https://api.github.com/repos/jeffh/sniffer/issues/20/events","html_url":"https://github.com/jeffh/sniffer/pull/20","id":53226673,"number":20,"title":"Recover from emitter errors","user":{"login":"mrgriffin","id":838573,"avatar_url":"https://avatars.githubusercontent.com/u/838573?v=3","gravatar_id":"","url":"https://api.github.com/users/mrgriffin","html_url":"https://github.com/mrgriffin","followers_url":"https://api.github.com/users/mrgriffin/followers","following_url":"https://api.github.com/users/mrgriffin/following{/other_user}","gists_url":"https://api.github.com/users/mrgriffin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrgriffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrgriffin/subscriptions","organizations_url":"https://api.github.com/users/mrgriffin/orgs","repos_url":"https://api.github.com/users/mrgriffin/repos","events_url":"https://api.github.com/users/mrgriffin/events{/privacy}","received_events_url":"https://api.github.com/users/mrgriffin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-01T19:30:15Z","updated_at":"2015-01-01T21:25:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jeffh/sniffer/pulls/20","html_url":"https://github.com/jeffh/sniffer/pull/20","diff_url":"https://github.com/jeffh/sniffer/pull/20.diff","patch_url":"https://github.com/jeffh/sniffer/pull/20.patch"},"body":"PyNotify raises an error when showing a message if no service is available.  Instead of dying when an emitter raises, that emitter is removed.  If the last emitter is removed an exception is raised (because there would be no way to monitor test results).\r\n\r\nThis solution might be worse than checking that a libnotify service exists and using a NullEmitter if not.  A quick google didn't turn up any documentation for pynotify so I didn't look into this.\r\n\r\nA third possibility for my use-case is adding a --no-libnotify argument."},"comment":{"url":"https://api.github.com/repos/jeffh/sniffer/issues/comments/68498768","html_url":"https://github.com/jeffh/sniffer/pull/20#issuecomment-68498768","issue_url":"https://api.github.com/repos/jeffh/sniffer/issues/20","id":68498768,"user":{"login":"jeffh","id":68616,"avatar_url":"https://avatars.githubusercontent.com/u/68616?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffh","html_url":"https://github.com/jeffh","followers_url":"https://api.github.com/users/jeffh/followers","following_url":"https://api.github.com/users/jeffh/following{/other_user}","gists_url":"https://api.github.com/users/jeffh/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffh/subscriptions","organizations_url":"https://api.github.com/users/jeffh/orgs","repos_url":"https://api.github.com/users/jeffh/repos","events_url":"https://api.github.com/users/jeffh/events{/privacy}","received_events_url":"https://api.github.com/users/jeffh/received_events","type":"User","site_admin":false},"created_at":"2015-01-01T21:25:02Z","updated_at":"2015-01-01T21:25:02Z","body":"Hey @mrgriffin, I'm going to try and reexplain what you said to make sure I understand it correctly: Pyinotify raises an exception when the OS doesn't support inotify. So it would be better if sniffer would still fallback to the naive file system watching method it uses when no file system libraries are installed.\r\n\r\nAlso, I don't think it's safe to remove an item from a list while iterating over it. But other than that, I don't have any other problems about the PR."}}