GitHub PullRequestEvent at 2014-01-11 21:48:33
Repository: inspircd
Actor: grawity
Payload: {"action":"opened","number":732,"pull_request":{"url":"https://api.github.com/repos/inspircd/inspircd/pulls/732","id":11430447,"html_url":"https://github.com/inspircd/inspircd/pull/732","diff_url":"https://github.com/inspircd/inspircd/pull/732.diff","patch_url":"https://github.com/inspircd/inspircd/pull/732.patch","issue_url":"https://github.com/inspircd/inspircd/pull/732","number":732,"state":"open","title":"m_sasl – properly handle bad-mechanism failures","user":{"login":"grawity","id":31021,"avatar_url":"https://gravatar.com/avatar/7003e967f47003bae82966aa373de8ef?d=https%3A%2F%2Fidenticons.github.com%2F7c019f69abfc6be1b8a91b27e41d2f77.png&r=x","gravatar_id":"7003e967f47003bae82966aa373de8ef","url":"https://api.github.com/users/grawity","html_url":"https://github.com/grawity","followers_url":"https://api.github.com/users/grawity/followers","following_url":"https://api.github.com/users/grawity/following{/other_user}","gists_url":"https://api.github.com/users/grawity/gists{/gist_id}","starred_url":"https://api.github.com/users/grawity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grawity/subscriptions","organizations_url":"https://api.github.com/users/grawity/orgs","repos_url":"https://api.github.com/users/grawity/repos","events_url":"https://api.github.com/users/grawity/events{/privacy}","received_events_url":"https://api.github.com/users/grawity/received_events","type":"User","site_admin":false},"body":"When the client requested a bad SASL mechanism, with Anope the ircd would send the services reply raw instead of sending the apropriate numeric. With Atheme, it *accidentally* worked because the extra \"known mechanisms\" reply would move to the apropriate state.\r\n\r\nThis e-note makes message handling the same in both SASL_INIT and SASL_COMM states and adds the \"available SASL mechanisms\" numeric.","created_at":"2014-01-11T21:48:32Z","updated_at":"2014-01-11T21:48:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://github.com/inspircd/inspircd/pull/732/commits","review_comments_url":"https://github.com/inspircd/inspircd/pull/732/comments","review_comment_url":"/repos/inspircd/inspircd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inspircd/inspircd/issues/732/comments","statuses_url":"https://api.github.com/repos/inspircd/inspircd/statuses/3dd642898f35b567aa74abb8a9608b22c10d1bfe","head":{"label":"grawity:saslfix","ref":"saslfix","sha":"3dd642898f35b567aa74abb8a9608b22c10d1bfe","user":{"login":"grawity","id":31021,"avatar_url":"https://gravatar.com/avatar/7003e967f47003bae82966aa373de8ef?d=https%3A%2F%2Fidenticons.github.com%2F7c019f69abfc6be1b8a91b27e41d2f77.png&r=x","gravatar_id":"7003e967f47003bae82966aa373de8ef","url":"https://api.github.com/users/grawity","html_url":"https://github.com/grawity","followers_url":"https://api.github.com/users/grawity/followers","following_url":"https://api.github.com/users/grawity/following{/other_user}","gists_url":"https://api.github.com/users/grawity/gists{/gist_id}","starred_url":"https://api.github.com/users/grawity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grawity/subscriptions","organizations_url":"https://api.github.com/users/grawity/orgs","repos_url":"https://api.github.com/users/grawity/repos","events_url":"https://api.github.com/users/grawity/events{/privacy}","received_events_url":"https://api.github.com/users/grawity/received_events","type":"User","site_admin":false},"repo":{"id":15585892,"name":"inspircd","full_name":"grawity/inspircd","owner":{"login":"grawity","id":31021,"avatar_url":"https://gravatar.com/avatar/7003e967f47003bae82966aa373de8ef?d=https%3A%2F%2Fidenticons.github.com%2F7c019f69abfc6be1b8a91b27e41d2f77.png&r=x","gravatar_id":"7003e967f47003bae82966aa373de8ef","url":"https://api.github.com/users/grawity","html_url":"https://github.com/grawity","followers_url":"https://api.github.com/users/grawity/followers","following_url":"https://api.github.com/users/grawity/following{/other_user}","gists_url":"https://api.github.com/users/grawity/gists{/gist_id}","starred_url":"https://api.github.com/users/grawity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grawity/subscriptions","organizations_url":"https://api.github.com/users/grawity/orgs","repos_url":"https://api.github.com/users/grawity/repos","events_url":"https://api.github.com/users/grawity/events{/privacy}","received_events_url":"https://api.github.com/users/grawity/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grawity/inspircd","description":"Main inspircd repository.","fork":true,"url":"https://api.github.com/repos/grawity/inspircd","forks_url":"https://api.github.com/repos/grawity/inspircd/forks","keys_url":"https://api.github.com/repos/grawity/inspircd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grawity/inspircd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grawity/inspircd/teams","hooks_url":"https://api.github.com/repos/grawity/inspircd/hooks","issue_events_url":"https://api.github.com/repos/grawity/inspircd/issues/events{/number}","events_url":"https://api.github.com/repos/grawity/inspircd/events","assignees_url":"https://api.github.com/repos/grawity/inspircd/assignees{/user}","branches_url":"https://api.github.com/repos/grawity/inspircd/branches{/branch}","tags_url":"https://api.github.com/repos/grawity/inspircd/tags","blobs_url":"https://api.github.com/repos/grawity/inspircd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grawity/inspircd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grawity/inspircd/git/refs{/sha}","trees_url":"https://api.github.com/repos/grawity/inspircd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grawity/inspircd/statuses/{sha}","languages_url":"https://api.github.com/repos/grawity/inspircd/languages","stargazers_url":"https://api.github.com/repos/grawity/inspircd/stargazers","contributors_url":"https://api.github.com/repos/grawity/inspircd/contributors","subscribers_url":"https://api.github.com/repos/grawity/inspircd/subscribers","subscription_url":"https://api.github.com/repos/grawity/inspircd/subscription","commits_url":"https://api.github.com/repos/grawity/inspircd/commits{/sha}","git_commits_url":"https://api.github.com/repos/grawity/inspircd/git/commits{/sha}","comments_url":"https://api.github.com/repos/grawity/inspircd/comments{/number}","issue_comment_url":"https://api.github.com/repos/grawity/inspircd/issues/comments/{number}","contents_url":"https://api.github.com/repos/grawity/inspircd/contents/{+path}","compare_url":"https://api.github.com/repos/grawity/inspircd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grawity/inspircd/merges","archive_url":"https://api.github.com/repos/grawity/inspircd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grawity/inspircd/downloads","issues_url":"https://api.github.com/repos/grawity/inspircd/issues{/number}","pulls_url":"https://api.github.com/repos/grawity/inspircd/pulls{/number}","milestones_url":"https://api.github.com/repos/grawity/inspircd/milestones{/number}","notifications_url":"https://api.github.com/repos/grawity/inspircd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grawity/inspircd/labels{/name}","releases_url":"https://api.github.com/repos/grawity/inspircd/releases{/id}","created_at":"2014-01-02T14:47:56Z","updated_at":"2014-01-11T21:48:32Z","pushed_at":"2014-01-11T21:43:53Z","git_url":"git://github.com/grawity/inspircd.git","ssh_url":"git@github.com:grawity/inspircd.git","clone_url":"https://github.com/grawity/inspircd.git","svn_url":"https://github.com/grawity/inspircd","homepage":"http://inspircd.org","size":24450,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"inspircd:insp20","ref":"insp20","sha":"7ce26772d93115e7c0a2644007351b57030710e6","user":{"login":"inspircd","id":1560750,"avatar_url":"https://gravatar.com/avatar/3e2995ddeeb49155df25935d04532f09?d=https%3A%2F%2Fidenticons.github.com%2F589ff7fdf26466bd97fb525aadb90e11.png&r=x","gravatar_id":"3e2995ddeeb49155df25935d04532f09","url":"https://api.github.com/users/inspircd","html_url":"https://github.com/inspircd","followers_url":"https://api.github.com/users/inspircd/followers","following_url":"https://api.github.com/users/inspircd/following{/other_user}","gists_url":"https://api.github.com/users/inspircd/gists{/gist_id}","starred_url":"https://api.github.com/users/inspircd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspircd/subscriptions","organizations_url":"https://api.github.com/users/inspircd/orgs","repos_url":"https://api.github.com/users/inspircd/repos","events_url":"https://api.github.com/users/inspircd/events{/privacy}","received_events_url":"https://api.github.com/users/inspircd/received_events","type":"Organization","site_admin":false},"repo":{"id":3786218,"name":"inspircd","full_name":"inspircd/inspircd","owner":{"login":"inspircd","id":1560750,"avatar_url":"https://gravatar.com/avatar/3e2995ddeeb49155df25935d04532f09?d=https%3A%2F%2Fidenticons.github.com%2F589ff7fdf26466bd97fb525aadb90e11.png&r=x","gravatar_id":"3e2995ddeeb49155df25935d04532f09","url":"https://api.github.com/users/inspircd","html_url":"https://github.com/inspircd","followers_url":"https://api.github.com/users/inspircd/followers","following_url":"https://api.github.com/users/inspircd/following{/other_user}","gists_url":"https://api.github.com/users/inspircd/gists{/gist_id}","starred_url":"https://api.github.com/users/inspircd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspircd/subscriptions","organizations_url":"https://api.github.com/users/inspircd/orgs","repos_url":"https://api.github.com/users/inspircd/repos","events_url":"https://api.github.com/users/inspircd/events{/privacy}","received_events_url":"https://api.github.com/users/inspircd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inspircd/inspircd","description":"Main inspircd repository.","fork":false,"url":"https://api.github.com/repos/inspircd/inspircd","forks_url":"https://api.github.com/repos/inspircd/inspircd/forks","keys_url":"https://api.github.com/repos/inspircd/inspircd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspircd/inspircd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspircd/inspircd/teams","hooks_url":"https://api.github.com/repos/inspircd/inspircd/hooks","issue_events_url":"https://api.github.com/repos/inspircd/inspircd/issues/events{/number}","events_url":"https://api.github.com/repos/inspircd/inspircd/events","assignees_url":"https://api.github.com/repos/inspircd/inspircd/assignees{/user}","branches_url":"https://api.github.com/repos/inspircd/inspircd/branches{/branch}","tags_url":"https://api.github.com/repos/inspircd/inspircd/tags","blobs_url":"https://api.github.com/repos/inspircd/inspircd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspircd/inspircd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspircd/inspircd/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspircd/inspircd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspircd/inspircd/statuses/{sha}","languages_url":"https://api.github.com/repos/inspircd/inspircd/languages","stargazers_url":"https://api.github.com/repos/inspircd/inspircd/stargazers","contributors_url":"https://api.github.com/repos/inspircd/inspircd/contributors","subscribers_url":"https://api.github.com/repos/inspircd/inspircd/subscribers","subscription_url":"https://api.github.com/repos/inspircd/inspircd/subscription","commits_url":"https://api.github.com/repos/inspircd/inspircd/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspircd/inspircd/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspircd/inspircd/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspircd/inspircd/issues/comments/{number}","contents_url":"https://api.github.com/repos/inspircd/inspircd/contents/{+path}","compare_url":"https://api.github.com/repos/inspircd/inspircd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspircd/inspircd/merges","archive_url":"https://api.github.com/repos/inspircd/inspircd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspircd/inspircd/downloads","issues_url":"https://api.github.com/repos/inspircd/inspircd/issues{/number}","pulls_url":"https://api.github.com/repos/inspircd/inspircd/pulls{/number}","milestones_url":"https://api.github.com/repos/inspircd/inspircd/milestones{/number}","notifications_url":"https://api.github.com/repos/inspircd/inspircd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspircd/inspircd/labels{/name}","releases_url":"https://api.github.com/repos/inspircd/inspircd/releases{/id}","created_at":"2012-03-21T12:22:32Z","updated_at":"2014-01-10T22:52:12Z","pushed_at":"2014-01-10T14:34:29Z","git_url":"git://github.com/inspircd/inspircd.git","ssh_url":"git@github.com:inspircd/inspircd.git","clone_url":"https://github.com/inspircd/inspircd.git","svn_url":"https://github.com/inspircd/inspircd","homepage":"http://inspircd.org","size":29907,"stargazers_count":213,"watchers_count":213,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":82,"mirror_url":null,"open_issues_count":115,"forks":82,"open_issues":115,"watchers":213,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspircd/inspircd/pulls/732"},"html":{"href":"https://github.com/inspircd/inspircd/pull/732"},"issue":{"href":"https://api.github.com/repos/inspircd/inspircd/issues/732"},"comments":{"href":"https://api.github.com/repos/inspircd/inspircd/issues/732/comments"},"review_comments":{"href":"https://api.github.com/repos/inspircd/inspircd/pulls/732/comments"},"statuses":{"href":"https://api.github.com/repos/inspircd/inspircd/statuses/3dd642898f35b567aa74abb8a9608b22c10d1bfe"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":7,"deletions":4,"changed_files":1}}