GitHub PullRequestReviewCommentEvent at 2014-09-01 13:03:31
Repository: grunt-contrib-sass
Actor: radkodinev
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls/comments/16953184","id":16953184,"diff_hunk":"@@ -61,8 +64,21 @@ module.exports = function (grunt) {\n         grunt.log.warn('Source file \"' + src + '\" not found.');\n         return next();\n       }\n-\n       if (path.basename(src)[0] === '_') {\n+        if (options.compileDependencies) {\n+          var dependencies = dependsOn(src);\n+          var addToAsyncArray;\n+          dependencies.forEach(function (cur, index, dependencies) {\n+            var ext = path.extname(cur);\n+            var dest = path.normalize(file.orig.dest, file.orig.cwd) + \"/\" + path.basename(cur, ext) + \".css\";\n+            addToAsyncArray = {\n+              src: [cur],\n+              dest: dest,\n+              orig: file.orig\n+            };\n+            asyncArray.push(addToAsyncArray);","path":"tasks/sass.js","position":48,"original_position":48,"commit_id":"efbc2e441ab4fd46338ed640b28c8f270973dad6","original_commit_id":"efbc2e441ab4fd46338ed640b28c8f270973dad6","user":{"login":"radkodinev","id":1845454,"avatar_url":"https://avatars.githubusercontent.com/u/1845454?v=2","gravatar_id":"ddf8573eb6875113d75aa75feefb2b5c","url":"https://api.github.com/users/radkodinev","html_url":"https://github.com/radkodinev","followers_url":"https://api.github.com/users/radkodinev/followers","following_url":"https://api.github.com/users/radkodinev/following{/other_user}","gists_url":"https://api.github.com/users/radkodinev/gists{/gist_id}","starred_url":"https://api.github.com/users/radkodinev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radkodinev/subscriptions","organizations_url":"https://api.github.com/users/radkodinev/orgs","repos_url":"https://api.github.com/users/radkodinev/repos","events_url":"https://api.github.com/users/radkodinev/events{/privacy}","received_events_url":"https://api.github.com/users/radkodinev/received_events","type":"User","site_admin":false},"body":"What if you have 5 partials all included in another file, e.g. `main.scss`? You'll have `main.scss` added 5 times.\r\nOr `main.scss` that includes a partial `_a.scss` which includes partials `_b1.scss` and `_b2.scss`? `main.scss` will be added 3 times.\r\n\r\n\r\n","created_at":"2014-09-01T13:03:31Z","updated_at":"2014-09-01T13:03:31Z","html_url":"https://github.com/gruntjs/grunt-contrib-sass/pull/156#discussion_r16953184","pull_request_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls/156","_links":{"self":{"href":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls/comments/16953184"},"html":{"href":"https://github.com/gruntjs/grunt-contrib-sass/pull/156#discussion_r16953184"},"pull_request":{"href":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls/156","id":20556582,"html_url":"https://github.com/gruntjs/grunt-contrib-sass/pull/156","diff_url":"https://github.com/gruntjs/grunt-contrib-sass/pull/156.diff","patch_url":"https://github.com/gruntjs/grunt-contrib-sass/pull/156.patch","issue_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/issues/156","number":156,"state":"open","locked":false,"title":"Add compileDependencies option","user":{"login":"tbremer","id":2998575,"avatar_url":"https://avatars.githubusercontent.com/u/2998575?v=2","gravatar_id":"fd55ad29790456152fd66ac448fc3972","url":"https://api.github.com/users/tbremer","html_url":"https://github.com/tbremer","followers_url":"https://api.github.com/users/tbremer/followers","following_url":"https://api.github.com/users/tbremer/following{/other_user}","gists_url":"https://api.github.com/users/tbremer/gists{/gist_id}","starred_url":"https://api.github.com/users/tbremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbremer/subscriptions","organizations_url":"https://api.github.com/users/tbremer/orgs","repos_url":"https://api.github.com/users/tbremer/repos","events_url":"https://api.github.com/users/tbremer/events{/privacy}","received_events_url":"https://api.github.com/users/tbremer/received_events","type":"User","site_admin":false},"body":"Redux of last week. This is the same operations, but runs faster and is moved to an outside resource.\r\n\r\nI have added the option `compileDepedencies`, when true this adds a partial's dependent files to the current async process. I have added sass-get-dependencies as a dependency on the package.json. Written tests and updated the documentation / Readme file.","created_at":"2014-09-01T06:34:17Z","updated_at":"2014-09-01T13:03:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7455787b33fc2124ed7868f56115a16bde1a111","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls/156/commits","review_comments_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls/156/comments","review_comment_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/issues/156/comments","statuses_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/statuses/efbc2e441ab4fd46338ed640b28c8f270973dad6","head":{"label":"tbremer:dependent-files","ref":"dependent-files","sha":"efbc2e441ab4fd46338ed640b28c8f270973dad6","user":{"login":"tbremer","id":2998575,"avatar_url":"https://avatars.githubusercontent.com/u/2998575?v=2","gravatar_id":"fd55ad29790456152fd66ac448fc3972","url":"https://api.github.com/users/tbremer","html_url":"https://github.com/tbremer","followers_url":"https://api.github.com/users/tbremer/followers","following_url":"https://api.github.com/users/tbremer/following{/other_user}","gists_url":"https://api.github.com/users/tbremer/gists{/gist_id}","starred_url":"https://api.github.com/users/tbremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbremer/subscriptions","organizations_url":"https://api.github.com/users/tbremer/orgs","repos_url":"https://api.github.com/users/tbremer/repos","events_url":"https://api.github.com/users/tbremer/events{/privacy}","received_events_url":"https://api.github.com/users/tbremer/received_events","type":"User","site_admin":false},"repo":{"id":23127750,"name":"grunt-contrib-sass","full_name":"tbremer/grunt-contrib-sass","owner":{"login":"tbremer","id":2998575,"avatar_url":"https://avatars.githubusercontent.com/u/2998575?v=2","gravatar_id":"fd55ad29790456152fd66ac448fc3972","url":"https://api.github.com/users/tbremer","html_url":"https://github.com/tbremer","followers_url":"https://api.github.com/users/tbremer/followers","following_url":"https://api.github.com/users/tbremer/following{/other_user}","gists_url":"https://api.github.com/users/tbremer/gists{/gist_id}","starred_url":"https://api.github.com/users/tbremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbremer/subscriptions","organizations_url":"https://api.github.com/users/tbremer/orgs","repos_url":"https://api.github.com/users/tbremer/repos","events_url":"https://api.github.com/users/tbremer/events{/privacy}","received_events_url":"https://api.github.com/users/tbremer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbremer/grunt-contrib-sass","description":"Compile Sass to CSS.","fork":true,"url":"https://api.github.com/repos/tbremer/grunt-contrib-sass","forks_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/forks","keys_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/teams","hooks_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/hooks","issue_events_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/issues/events{/number}","events_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/events","assignees_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/assignees{/user}","branches_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/branches{/branch}","tags_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/tags","blobs_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/statuses/{sha}","languages_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/languages","stargazers_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/stargazers","contributors_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/contributors","subscribers_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/subscribers","subscription_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/subscription","commits_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/issues/comments/{number}","contents_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/contents/{+path}","compare_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/merges","archive_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/downloads","issues_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/issues{/number}","pulls_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/pulls{/number}","milestones_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/milestones{/number}","notifications_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/labels{/name}","releases_url":"https://api.github.com/repos/tbremer/grunt-contrib-sass/releases{/id}","created_at":"2014-08-19T22:24:35Z","updated_at":"2014-08-21T15:49:26Z","pushed_at":"2014-09-01T06:31:53Z","git_url":"git://github.com/tbremer/grunt-contrib-sass.git","ssh_url":"git@github.com:tbremer/grunt-contrib-sass.git","clone_url":"https://github.com/tbremer/grunt-contrib-sass.git","svn_url":"https://github.com/tbremer/grunt-contrib-sass","homepage":"http://gruntjs.com/","size":519,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gruntjs:master","ref":"master","sha":"fa9ab0654bfbe7561091193b5e2f41631027dd15","user":{"login":"gruntjs","id":1630826,"avatar_url":"https://avatars.githubusercontent.com/u/1630826?v=2","gravatar_id":"801a04ad77406f5ba958a607f2b27880","url":"https://api.github.com/users/gruntjs","html_url":"https://github.com/gruntjs","followers_url":"https://api.github.com/users/gruntjs/followers","following_url":"https://api.github.com/users/gruntjs/following{/other_user}","gists_url":"https://api.github.com/users/gruntjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gruntjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gruntjs/subscriptions","organizations_url":"https://api.github.com/users/gruntjs/orgs","repos_url":"https://api.github.com/users/gruntjs/repos","events_url":"https://api.github.com/users/gruntjs/events{/privacy}","received_events_url":"https://api.github.com/users/gruntjs/received_events","type":"Organization","site_admin":false},"repo":{"id":5845768,"name":"grunt-contrib-sass","full_name":"gruntjs/grunt-contrib-sass","owner":{"login":"gruntjs","id":1630826,"avatar_url":"https://avatars.githubusercontent.com/u/1630826?v=2","gravatar_id":"801a04ad77406f5ba958a607f2b27880","url":"https://api.github.com/users/gruntjs","html_url":"https://github.com/gruntjs","followers_url":"https://api.github.com/users/gruntjs/followers","following_url":"https://api.github.com/users/gruntjs/following{/other_user}","gists_url":"https://api.github.com/users/gruntjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gruntjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gruntjs/subscriptions","organizations_url":"https://api.github.com/users/gruntjs/orgs","repos_url":"https://api.github.com/users/gruntjs/repos","events_url":"https://api.github.com/users/gruntjs/events{/privacy}","received_events_url":"https://api.github.com/users/gruntjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gruntjs/grunt-contrib-sass","description":"Compile Sass to CSS.","fork":false,"url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass","forks_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/forks","keys_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/teams","hooks_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/hooks","issue_events_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/issues/events{/number}","events_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/events","assignees_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/assignees{/user}","branches_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/branches{/branch}","tags_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/tags","blobs_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/git/refs{/sha}","trees_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/statuses/{sha}","languages_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/languages","stargazers_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/stargazers","contributors_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/contributors","subscribers_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/subscribers","subscription_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/subscription","commits_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/commits{/sha}","git_commits_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/git/commits{/sha}","comments_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/comments{/number}","issue_comment_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/issues/comments/{number}","contents_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/contents/{+path}","compare_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/merges","archive_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/downloads","issues_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/issues{/number}","pulls_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls{/number}","milestones_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/milestones{/number}","notifications_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/labels{/name}","releases_url":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/releases{/id}","created_at":"2012-09-17T19:06:15Z","updated_at":"2014-08-31T21:17:25Z","pushed_at":"2014-08-30T20:14:19Z","git_url":"git://github.com/gruntjs/grunt-contrib-sass.git","ssh_url":"git@github.com:gruntjs/grunt-contrib-sass.git","clone_url":"https://github.com/gruntjs/grunt-contrib-sass.git","svn_url":"https://github.com/gruntjs/grunt-contrib-sass","homepage":"http://gruntjs.com/","size":1167,"stargazers_count":401,"watchers_count":401,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":92,"mirror_url":null,"open_issues_count":1,"forks":92,"open_issues":1,"watchers":401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls/156"},"html":{"href":"https://github.com/gruntjs/grunt-contrib-sass/pull/156"},"issue":{"href":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/issues/156"},"comments":{"href":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/gruntjs/grunt-contrib-sass/statuses/efbc2e441ab4fd46338ed640b28c8f270973dad6"}}}}