GitHub PullRequestReviewCommentEvent at 2014-11-24 13:54:49
Repository: forkcms
Actor: jeroendesloovere
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/20790402","id":20790402,"diff_hunk":"@@ -174,9 +194,11 @@ public function addJS($file, $minify = true, $addTimestamp = null)\n             $file = $this->minifyJS($file);\n         }\n \n+        $jsFile = array('file' => $file, 'add_timestamp' => $addTimestamp, 'priority_group' => $priorityGroup);","path":"src/Frontend/Core/Engine/Header.php","position":57,"original_position":57,"commit_id":"37f12973482a7d3f57d3ae5bd02facf28bbc0f35","original_commit_id":"37f12973482a7d3f57d3ae5bd02facf28bbc0f35","user":{"login":"jeroendesloovere","id":588616,"avatar_url":"https://avatars.githubusercontent.com/u/588616?v=3","gravatar_id":"","url":"https://api.github.com/users/jeroendesloovere","html_url":"https://github.com/jeroendesloovere","followers_url":"https://api.github.com/users/jeroendesloovere/followers","following_url":"https://api.github.com/users/jeroendesloovere/following{/other_user}","gists_url":"https://api.github.com/users/jeroendesloovere/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroendesloovere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroendesloovere/subscriptions","organizations_url":"https://api.github.com/users/jeroendesloovere/orgs","repos_url":"https://api.github.com/users/jeroendesloovere/repos","events_url":"https://api.github.com/users/jeroendesloovere/events{/privacy}","received_events_url":"https://api.github.com/users/jeroendesloovere/received_events","type":"User","site_admin":false},"body":"Can you place on separate rules?\r\n```\r\n$jsFile = array(\r\n    'file' => xxx,\r\n    'add_timestamp' => xxx,\r\n    ...\r\n);","created_at":"2014-11-24T13:54:49Z","updated_at":"2014-11-24T13:54:49Z","html_url":"https://github.com/forkcms/forkcms/pull/904#discussion_r20790402","pull_request_url":"https://api.github.com/repos/forkcms/forkcms/pulls/904","_links":{"self":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/20790402"},"html":{"href":"https://github.com/forkcms/forkcms/pull/904#discussion_r20790402"},"pull_request":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/904"}}},"pull_request":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/904","id":22919225,"html_url":"https://github.com/forkcms/forkcms/pull/904","diff_url":"https://github.com/forkcms/forkcms/pull/904.diff","patch_url":"https://github.com/forkcms/forkcms/pull/904.patch","issue_url":"https://api.github.com/repos/forkcms/forkcms/issues/904","number":904,"state":"open","locked":false,"title":"Feature/Bug: JS files loading order #893","user":{"login":"vytenizs","id":3973894,"avatar_url":"https://avatars.githubusercontent.com/u/3973894?v=3","gravatar_id":"","url":"https://api.github.com/users/vytenizs","html_url":"https://github.com/vytenizs","followers_url":"https://api.github.com/users/vytenizs/followers","following_url":"https://api.github.com/users/vytenizs/following{/other_user}","gists_url":"https://api.github.com/users/vytenizs/gists{/gist_id}","starred_url":"https://api.github.com/users/vytenizs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vytenizs/subscriptions","organizations_url":"https://api.github.com/users/vytenizs/orgs","repos_url":"https://api.github.com/users/vytenizs/repos","events_url":"https://api.github.com/users/vytenizs/events{/privacy}","received_events_url":"https://api.github.com/users/vytenizs/received_events","type":"User","site_admin":false},"body":"Separates JS files into several priority groups. Then loads them in such order:\r\n1. Global JS files (jQuery, jQuery UI, Fork CMS JS files and so on)\r\n2. Default index is for custom module files added with $this->addJS inside module or widget\r\n3. Modules JS files (Blog.js, Faq.js and module action files)\r\n4. Widget JS files (CategoriesTree.js and so on)\r\nThis feature fixes IE9 and some other browsers loading order issue.","created_at":"2014-10-17T11:46:01Z","updated_at":"2014-11-24T13:54:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8140f361ae1d7b086ac33bfaa556f09cba145102","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/forkcms/forkcms/pulls/904/commits","review_comments_url":"https://api.github.com/repos/forkcms/forkcms/pulls/904/comments","review_comment_url":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/{number}","comments_url":"https://api.github.com/repos/forkcms/forkcms/issues/904/comments","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/37f12973482a7d3f57d3ae5bd02facf28bbc0f35","head":{"label":"vytenizs:issue-893","ref":"issue-893","sha":"37f12973482a7d3f57d3ae5bd02facf28bbc0f35","user":{"login":"vytenizs","id":3973894,"avatar_url":"https://avatars.githubusercontent.com/u/3973894?v=3","gravatar_id":"","url":"https://api.github.com/users/vytenizs","html_url":"https://github.com/vytenizs","followers_url":"https://api.github.com/users/vytenizs/followers","following_url":"https://api.github.com/users/vytenizs/following{/other_user}","gists_url":"https://api.github.com/users/vytenizs/gists{/gist_id}","starred_url":"https://api.github.com/users/vytenizs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vytenizs/subscriptions","organizations_url":"https://api.github.com/users/vytenizs/orgs","repos_url":"https://api.github.com/users/vytenizs/repos","events_url":"https://api.github.com/users/vytenizs/events{/privacy}","received_events_url":"https://api.github.com/users/vytenizs/received_events","type":"User","site_admin":false},"repo":{"id":23862067,"name":"forkcms","full_name":"vytenizs/forkcms","owner":{"login":"vytenizs","id":3973894,"avatar_url":"https://avatars.githubusercontent.com/u/3973894?v=3","gravatar_id":"","url":"https://api.github.com/users/vytenizs","html_url":"https://github.com/vytenizs","followers_url":"https://api.github.com/users/vytenizs/followers","following_url":"https://api.github.com/users/vytenizs/following{/other_user}","gists_url":"https://api.github.com/users/vytenizs/gists{/gist_id}","starred_url":"https://api.github.com/users/vytenizs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vytenizs/subscriptions","organizations_url":"https://api.github.com/users/vytenizs/orgs","repos_url":"https://api.github.com/users/vytenizs/repos","events_url":"https://api.github.com/users/vytenizs/events{/privacy}","received_events_url":"https://api.github.com/users/vytenizs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vytenizs/forkcms","description":"Fork is an open source CMS.","fork":true,"url":"https://api.github.com/repos/vytenizs/forkcms","forks_url":"https://api.github.com/repos/vytenizs/forkcms/forks","keys_url":"https://api.github.com/repos/vytenizs/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vytenizs/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vytenizs/forkcms/teams","hooks_url":"https://api.github.com/repos/vytenizs/forkcms/hooks","issue_events_url":"https://api.github.com/repos/vytenizs/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/vytenizs/forkcms/events","assignees_url":"https://api.github.com/repos/vytenizs/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/vytenizs/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/vytenizs/forkcms/tags","blobs_url":"https://api.github.com/repos/vytenizs/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vytenizs/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vytenizs/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/vytenizs/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vytenizs/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/vytenizs/forkcms/languages","stargazers_url":"https://api.github.com/repos/vytenizs/forkcms/stargazers","contributors_url":"https://api.github.com/repos/vytenizs/forkcms/contributors","subscribers_url":"https://api.github.com/repos/vytenizs/forkcms/subscribers","subscription_url":"https://api.github.com/repos/vytenizs/forkcms/subscription","commits_url":"https://api.github.com/repos/vytenizs/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/vytenizs/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/vytenizs/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/vytenizs/forkcms/issues/comments/{number}","contents_url":"https://api.github.com/repos/vytenizs/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/vytenizs/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vytenizs/forkcms/merges","archive_url":"https://api.github.com/repos/vytenizs/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vytenizs/forkcms/downloads","issues_url":"https://api.github.com/repos/vytenizs/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/vytenizs/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/vytenizs/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/vytenizs/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vytenizs/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/vytenizs/forkcms/releases{/id}","created_at":"2014-09-10T05:33:57Z","updated_at":"2014-11-12T09:40:02Z","pushed_at":"2014-11-12T09:40:00Z","git_url":"git://github.com/vytenizs/forkcms.git","ssh_url":"git@github.com:vytenizs/forkcms.git","clone_url":"https://github.com/vytenizs/forkcms.git","svn_url":"https://github.com/vytenizs/forkcms","homepage":"http://www.fork-cms.com","size":31422,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forkcms:master","ref":"master","sha":"baaae9a739906cce34198ac8d2cc18628359f7cf","user":{"login":"forkcms","id":312505,"avatar_url":"https://avatars.githubusercontent.com/u/312505?v=3","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"repo":{"id":1138583,"name":"forkcms","full_name":"forkcms/forkcms","owner":{"login":"forkcms","id":312505,"avatar_url":"https://avatars.githubusercontent.com/u/312505?v=3","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forkcms/forkcms","description":"Fork is an open source CMS.","fork":false,"url":"https://api.github.com/repos/forkcms/forkcms","forks_url":"https://api.github.com/repos/forkcms/forkcms/forks","keys_url":"https://api.github.com/repos/forkcms/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forkcms/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forkcms/forkcms/teams","hooks_url":"https://api.github.com/repos/forkcms/forkcms/hooks","issue_events_url":"https://api.github.com/repos/forkcms/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/forkcms/forkcms/events","assignees_url":"https://api.github.com/repos/forkcms/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/forkcms/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/forkcms/forkcms/tags","blobs_url":"https://api.github.com/repos/forkcms/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forkcms/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forkcms/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/forkcms/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/forkcms/forkcms/languages","stargazers_url":"https://api.github.com/repos/forkcms/forkcms/stargazers","contributors_url":"https://api.github.com/repos/forkcms/forkcms/contributors","subscribers_url":"https://api.github.com/repos/forkcms/forkcms/subscribers","subscription_url":"https://api.github.com/repos/forkcms/forkcms/subscription","commits_url":"https://api.github.com/repos/forkcms/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/forkcms/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/forkcms/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/forkcms/forkcms/issues/comments/{number}","contents_url":"https://api.github.com/repos/forkcms/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/forkcms/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forkcms/forkcms/merges","archive_url":"https://api.github.com/repos/forkcms/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forkcms/forkcms/downloads","issues_url":"https://api.github.com/repos/forkcms/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/forkcms/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/forkcms/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/forkcms/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forkcms/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/forkcms/forkcms/releases{/id}","created_at":"2010-12-04T18:06:15Z","updated_at":"2014-11-20T14:42:55Z","pushed_at":"2014-11-21T12:55:49Z","git_url":"git://github.com/forkcms/forkcms.git","ssh_url":"git@github.com:forkcms/forkcms.git","clone_url":"https://github.com/forkcms/forkcms.git","svn_url":"https://github.com/forkcms/forkcms","homepage":"http://www.fork-cms.com","size":64137,"stargazers_count":812,"watchers_count":812,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":232,"mirror_url":null,"open_issues_count":114,"forks":232,"open_issues":114,"watchers":812,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/904"},"html":{"href":"https://github.com/forkcms/forkcms/pull/904"},"issue":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/904"},"comments":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/904/comments"},"review_comments":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/904/comments"},"review_comment":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/904/commits"},"statuses":{"href":"https://api.github.com/repos/forkcms/forkcms/statuses/37f12973482a7d3f57d3ae5bd02facf28bbc0f35"}}}}