GitHub PullRequestReviewCommentEvent at 2014-08-27 19:06:21
Repository: suspenders
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments/16797397","id":16797397,"diff_hunk":"@@ -1,10 +1,10 @@\n if Rails.env.staging? || Rails.env.production?\n   SMTP_SETTINGS = {\n-    address: ENV.fetch('SMTP_ADDRESS'), # example: 'smtp.sendgrid.net'\n+    address: ENV.fetch('smtp.sendgrid.net'),\n     authentication: :plain,\n     domain: ENV.fetch('SMTP_DOMAIN'), # example: 'this-app.com'\n-    password: ENV.fetch('SMTP_PASSWORD'),\n+    password: ENV.fetch('SENDGRID_PASSWORD'),","path":"templates/smtp.rb","position":8,"original_position":8,"commit_id":"1f8e0097d958106a238a61a8ef54ec0691bdf606","original_commit_id":"1f8e0097d958106a238a61a8ef54ec0691bdf606","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=2","gravatar_id":"38d9cefd9971a05bf447f07c6cd332cc","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2014-08-27T19:06:21Z","updated_at":"2014-08-27T19:06:21Z","html_url":"https://github.com/thoughtbot/suspenders/pull/398#discussion_r16797397","pull_request_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/398","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments/16797397"},"html":{"href":"https://github.com/thoughtbot/suspenders/pull/398#discussion_r16797397"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/398"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/398","id":20394845,"html_url":"https://github.com/thoughtbot/suspenders/pull/398","diff_url":"https://github.com/thoughtbot/suspenders/pull/398.diff","patch_url":"https://github.com/thoughtbot/suspenders/pull/398.patch","issue_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/398","number":398,"state":"open","locked":false,"title":"Use Sendgrid for SMTP mail delivery by default","user":{"login":"masonforest","id":229473,"avatar_url":"https://avatars.githubusercontent.com/u/229473?v=2","gravatar_id":"f7a52a516043eacbc86885c0f6c68bda","url":"https://api.github.com/users/masonforest","html_url":"https://github.com/masonforest","followers_url":"https://api.github.com/users/masonforest/followers","following_url":"https://api.github.com/users/masonforest/following{/other_user}","gists_url":"https://api.github.com/users/masonforest/gists{/gist_id}","starred_url":"https://api.github.com/users/masonforest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masonforest/subscriptions","organizations_url":"https://api.github.com/users/masonforest/orgs","repos_url":"https://api.github.com/users/masonforest/repos","events_url":"https://api.github.com/users/masonforest/events{/privacy}","received_events_url":"https://api.github.com/users/masonforest/received_events","type":"User","site_admin":false},"body":"When deploying to Heroku I was getting\r\n\r\n`KeyError: key not found`\r\n\r\nwhich wasn't immediately clear.\r\n\r\n\r\nDo we use anything other than sendgrid for mail delivery in production?","created_at":"2014-08-27T19:06:18Z","updated_at":"2014-08-27T19:06:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/398/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/398/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments/{number}","comments_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/398/comments","statuses_url":"https://api.github.com/repos/thoughtbot/suspenders/statuses/1f8e0097d958106a238a61a8ef54ec0691bdf606","head":{"label":"thoughtbot:mf-use-sendgrid","ref":"mf-use-sendgrid","sha":"1f8e0097d958106a238a61a8ef54ec0691bdf606","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=2","gravatar_id":"a95a04df2dae60397c38c9bd04492c53","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":666566,"name":"suspenders","full_name":"thoughtbot/suspenders","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=2","gravatar_id":"a95a04df2dae60397c38c9bd04492c53","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/suspenders","description":"A Rails template with our standard defaults, ready to deploy to Heroku.","fork":false,"url":"https://api.github.com/repos/thoughtbot/suspenders","forks_url":"https://api.github.com/repos/thoughtbot/suspenders/forks","keys_url":"https://api.github.com/repos/thoughtbot/suspenders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/suspenders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/suspenders/teams","hooks_url":"https://api.github.com/repos/thoughtbot/suspenders/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/suspenders/events","assignees_url":"https://api.github.com/repos/thoughtbot/suspenders/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/suspenders/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/suspenders/tags","blobs_url":"https://api.github.com/repos/thoughtbot/suspenders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/suspenders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/suspenders/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/suspenders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/suspenders/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/suspenders/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/suspenders/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/suspenders/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/suspenders/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/suspenders/subscription","commits_url":"https://api.github.com/repos/thoughtbot/suspenders/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/suspenders/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/suspenders/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/comments/{number}","contents_url":"https://api.github.com/repos/thoughtbot/suspenders/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/suspenders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/suspenders/merges","archive_url":"https://api.github.com/repos/thoughtbot/suspenders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/suspenders/downloads","issues_url":"https://api.github.com/repos/thoughtbot/suspenders/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/suspenders/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/suspenders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/suspenders/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/suspenders/releases{/id}","created_at":"2010-05-14T14:34:46Z","updated_at":"2014-08-27T17:57:11Z","pushed_at":"2014-08-27T19:03:24Z","git_url":"git://github.com/thoughtbot/suspenders.git","ssh_url":"git@github.com:thoughtbot/suspenders.git","clone_url":"https://github.com/thoughtbot/suspenders.git","svn_url":"https://github.com/thoughtbot/suspenders","homepage":"","size":7373,"stargazers_count":1262,"watchers_count":1262,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":201,"mirror_url":null,"open_issues_count":10,"forks":201,"open_issues":10,"watchers":1262,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"6d4c89ebd0e5d11a087094bd69848e5c5359fe92","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=2","gravatar_id":"a95a04df2dae60397c38c9bd04492c53","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":666566,"name":"suspenders","full_name":"thoughtbot/suspenders","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=2","gravatar_id":"a95a04df2dae60397c38c9bd04492c53","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/suspenders","description":"A Rails template with our standard defaults, ready to deploy to Heroku.","fork":false,"url":"https://api.github.com/repos/thoughtbot/suspenders","forks_url":"https://api.github.com/repos/thoughtbot/suspenders/forks","keys_url":"https://api.github.com/repos/thoughtbot/suspenders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/suspenders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/suspenders/teams","hooks_url":"https://api.github.com/repos/thoughtbot/suspenders/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/suspenders/events","assignees_url":"https://api.github.com/repos/thoughtbot/suspenders/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/suspenders/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/suspenders/tags","blobs_url":"https://api.github.com/repos/thoughtbot/suspenders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/suspenders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/suspenders/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/suspenders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/suspenders/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/suspenders/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/suspenders/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/suspenders/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/suspenders/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/suspenders/subscription","commits_url":"https://api.github.com/repos/thoughtbot/suspenders/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/suspenders/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/suspenders/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/comments/{number}","contents_url":"https://api.github.com/repos/thoughtbot/suspenders/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/suspenders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/suspenders/merges","archive_url":"https://api.github.com/repos/thoughtbot/suspenders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/suspenders/downloads","issues_url":"https://api.github.com/repos/thoughtbot/suspenders/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/suspenders/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/suspenders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/suspenders/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/suspenders/releases{/id}","created_at":"2010-05-14T14:34:46Z","updated_at":"2014-08-27T17:57:11Z","pushed_at":"2014-08-27T19:03:24Z","git_url":"git://github.com/thoughtbot/suspenders.git","ssh_url":"git@github.com:thoughtbot/suspenders.git","clone_url":"https://github.com/thoughtbot/suspenders.git","svn_url":"https://github.com/thoughtbot/suspenders","homepage":"","size":7373,"stargazers_count":1262,"watchers_count":1262,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":201,"mirror_url":null,"open_issues_count":10,"forks":201,"open_issues":10,"watchers":1262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/398"},"html":{"href":"https://github.com/thoughtbot/suspenders/pull/398"},"issue":{"href":"https://api.github.com/repos/thoughtbot/suspenders/issues/398"},"comments":{"href":"https://api.github.com/repos/thoughtbot/suspenders/issues/398/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/398/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/398/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/suspenders/statuses/1f8e0097d958106a238a61a8ef54ec0691bdf606"}}}}