GitHub PullRequestReviewCommentEvent at 2014-07-20 23:43:31
Repository: phobos
Actor: klickverbot
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/15152794","id":15152794,"diff_hunk":"@@ -2804,20 +2828,47 @@ C1[] translate(C1, S, C2 = immutable char)(C1[] str,\n                                wchar[], const(wchar)[], immutable(wchar)[],\n                                dchar[], const(dchar)[], immutable(dchar)[]))\n         {\n-            assert(translate(to!S(\"hello world\"), ['h' : \"yellow\", 'l' : \"42\"], to!T(\"r\")) ==\n+\n+            string[dchar] tt = ['h' : \"yellow\", 'l' : \"42\"];\n+            const string[dchar] ttc = ['h' : \"yellow\", 'l' : \"42\"];","path":"std/string.d","position":89,"original_position":89,"commit_id":"7b2506a87f987399ef686c0d58e2226286d67757","original_commit_id":"7b2506a87f987399ef686c0d58e2226286d67757","user":{"login":"klickverbot","id":19335,"avatar_url":"https://avatars.githubusercontent.com/u/19335?","gravatar_id":"ec8654cc0cd6b800b995aa47ed24a297","url":"https://api.github.com/users/klickverbot","html_url":"https://github.com/klickverbot","followers_url":"https://api.github.com/users/klickverbot/followers","following_url":"https://api.github.com/users/klickverbot/following{/other_user}","gists_url":"https://api.github.com/users/klickverbot/gists{/gist_id}","starred_url":"https://api.github.com/users/klickverbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klickverbot/subscriptions","organizations_url":"https://api.github.com/users/klickverbot/orgs","repos_url":"https://api.github.com/users/klickverbot/repos","events_url":"https://api.github.com/users/klickverbot/events{/privacy}","received_events_url":"https://api.github.com/users/klickverbot/received_events","type":"User","site_admin":false},"body":"Same here.","created_at":"2014-07-20T23:43:31Z","updated_at":"2014-07-20T23:43:31Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/2312#discussion_r15152794","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2312","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/15152794"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2312#discussion_r15152794"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2312"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2312","id":18101055,"html_url":"https://github.com/D-Programming-Language/phobos/pull/2312","diff_url":"https://github.com/D-Programming-Language/phobos/pull/2312.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/2312.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2312","number":2312,"state":"open","title":"issue 13018: translate does not accept immutable or const AAs","user":{"login":"burner","id":13327,"avatar_url":"https://avatars.githubusercontent.com/u/13327?","gravatar_id":"22561f2dc8e4f8456d3675f8bdd0b89e","url":"https://api.github.com/users/burner","html_url":"https://github.com/burner","followers_url":"https://api.github.com/users/burner/followers","following_url":"https://api.github.com/users/burner/following{/other_user}","gists_url":"https://api.github.com/users/burner/gists{/gist_id}","starred_url":"https://api.github.com/users/burner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burner/subscriptions","organizations_url":"https://api.github.com/users/burner/orgs","repos_url":"https://api.github.com/users/burner/repos","events_url":"https://api.github.com/users/burner/events{/privacy}","received_events_url":"https://api.github.com/users/burner/received_events","type":"User","site_admin":false},"body":"https://issues.dlang.org/show_bug.cgi?id=13018","created_at":"2014-07-08T13:17:30Z","updated_at":"2014-07-20T23:43:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9b1d6f0f2d3ea33eafe5ac50ce9f0d8012f2495","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2312/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2312/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2312/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/7b2506a87f987399ef686c0d58e2226286d67757","head":{"label":"burner:issue13018","ref":"issue13018","sha":"7b2506a87f987399ef686c0d58e2226286d67757","user":{"login":"burner","id":13327,"avatar_url":"https://avatars.githubusercontent.com/u/13327?","gravatar_id":"22561f2dc8e4f8456d3675f8bdd0b89e","url":"https://api.github.com/users/burner","html_url":"https://github.com/burner","followers_url":"https://api.github.com/users/burner/followers","following_url":"https://api.github.com/users/burner/following{/other_user}","gists_url":"https://api.github.com/users/burner/gists{/gist_id}","starred_url":"https://api.github.com/users/burner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burner/subscriptions","organizations_url":"https://api.github.com/users/burner/orgs","repos_url":"https://api.github.com/users/burner/repos","events_url":"https://api.github.com/users/burner/events{/privacy}","received_events_url":"https://api.github.com/users/burner/received_events","type":"User","site_admin":false},"repo":{"id":7882025,"name":"phobos","full_name":"burner/phobos","owner":{"login":"burner","id":13327,"avatar_url":"https://avatars.githubusercontent.com/u/13327?","gravatar_id":"22561f2dc8e4f8456d3675f8bdd0b89e","url":"https://api.github.com/users/burner","html_url":"https://github.com/burner","followers_url":"https://api.github.com/users/burner/followers","following_url":"https://api.github.com/users/burner/following{/other_user}","gists_url":"https://api.github.com/users/burner/gists{/gist_id}","starred_url":"https://api.github.com/users/burner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burner/subscriptions","organizations_url":"https://api.github.com/users/burner/orgs","repos_url":"https://api.github.com/users/burner/repos","events_url":"https://api.github.com/users/burner/events{/privacy}","received_events_url":"https://api.github.com/users/burner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/burner/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/burner/phobos","forks_url":"https://api.github.com/repos/burner/phobos/forks","keys_url":"https://api.github.com/repos/burner/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burner/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burner/phobos/teams","hooks_url":"https://api.github.com/repos/burner/phobos/hooks","issue_events_url":"https://api.github.com/repos/burner/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/burner/phobos/events","assignees_url":"https://api.github.com/repos/burner/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/burner/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/burner/phobos/tags","blobs_url":"https://api.github.com/repos/burner/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burner/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burner/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/burner/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burner/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/burner/phobos/languages","stargazers_url":"https://api.github.com/repos/burner/phobos/stargazers","contributors_url":"https://api.github.com/repos/burner/phobos/contributors","subscribers_url":"https://api.github.com/repos/burner/phobos/subscribers","subscription_url":"https://api.github.com/repos/burner/phobos/subscription","commits_url":"https://api.github.com/repos/burner/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/burner/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/burner/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/burner/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/burner/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/burner/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burner/phobos/merges","archive_url":"https://api.github.com/repos/burner/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burner/phobos/downloads","issues_url":"https://api.github.com/repos/burner/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/burner/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/burner/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/burner/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burner/phobos/labels{/name}","releases_url":"https://api.github.com/repos/burner/phobos/releases{/id}","created_at":"2013-01-29T00:26:08Z","updated_at":"2014-06-23T21:43:30Z","pushed_at":"2014-07-20T23:32:30Z","git_url":"git://github.com/burner/phobos.git","ssh_url":"git@github.com:burner/phobos.git","clone_url":"https://github.com/burner/phobos.git","svn_url":"https://github.com/burner/phobos","homepage":"dlang.org/phobos","size":27785,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"82dc45e886621cabb7d00e528c22bf6eb8869f89","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?","gravatar_id":"1fe90c0586802aee103ff9ac0b8f3fbe","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?","gravatar_id":"1fe90c0586802aee103ff9ac0b8f3fbe","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","created_at":"2011-01-15T07:00:06Z","updated_at":"2014-07-18T17:14:25Z","pushed_at":"2014-07-20T19:32:14Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":55425,"stargazers_count":498,"watchers_count":498,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":339,"mirror_url":null,"open_issues_count":68,"forks":339,"open_issues":68,"watchers":498,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2312"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2312"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2312"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2312/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2312/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2312/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/7b2506a87f987399ef686c0d58e2226286d67757"}}}}