GitHub PullRequestReviewCommentEvent at 2014-09-04 17:19:39
Repository: funcunit-as-promised
Actor: imorrison
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/yola/funcunit-as-promised/pulls/comments/17128326","id":17128326,"diff_hunk":"@@ -38,11 +38,11 @@\n     \"jshint\": \"2.5.x\",\n     \"jsgreat\": \"0.1.1\",\n     \"q\": \"1.0.1\",\n-    \"jquery\": \"1.11.x\"\n+    \"jquery\": \"1.11.x\",\n+    \"browserify\": \"4.1.x\",\n+    \"browserify-shim\": \"3.5.x\"","path":"package.json","position":7,"original_position":7,"commit_id":"8465d71ddb177b4cf6258278420ba389aee24964","original_commit_id":"8465d71ddb177b4cf6258278420ba389aee24964","user":{"login":"imorrison","id":1871228,"avatar_url":"https://avatars.githubusercontent.com/u/1871228?v=2","gravatar_id":"ba740cf4d0ad9904fc5d1b53e77a7b5b","url":"https://api.github.com/users/imorrison","html_url":"https://github.com/imorrison","followers_url":"https://api.github.com/users/imorrison/followers","following_url":"https://api.github.com/users/imorrison/following{/other_user}","gists_url":"https://api.github.com/users/imorrison/gists{/gist_id}","starred_url":"https://api.github.com/users/imorrison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imorrison/subscriptions","organizations_url":"https://api.github.com/users/imorrison/orgs","repos_url":"https://api.github.com/users/imorrison/repos","events_url":"https://api.github.com/users/imorrison/events{/privacy}","received_events_url":"https://api.github.com/users/imorrison/received_events","type":"User","site_admin":false},"body":"It means that a consumer of the client can do a transform of jquery, which is a dependency. Otherwise the consumer will throw an error, if browserify-shim is not already installed. ","created_at":"2014-09-04T17:19:39Z","updated_at":"2014-09-04T17:19:39Z","html_url":"https://github.com/yola/funcunit-as-promised/pull/3#discussion_r17128326","pull_request_url":"https://api.github.com/repos/yola/funcunit-as-promised/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/yola/funcunit-as-promised/pulls/comments/17128326"},"html":{"href":"https://github.com/yola/funcunit-as-promised/pull/3#discussion_r17128326"},"pull_request":{"href":"https://api.github.com/repos/yola/funcunit-as-promised/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/yola/funcunit-as-promised/pulls/3","id":20712208,"html_url":"https://github.com/yola/funcunit-as-promised/pull/3","diff_url":"https://github.com/yola/funcunit-as-promised/pull/3.diff","patch_url":"https://github.com/yola/funcunit-as-promised/pull/3.patch","issue_url":"https://api.github.com/repos/yola/funcunit-as-promised/issues/3","number":3,"state":"open","locked":false,"title":"Add browserify and browserify-shim to dependences","user":{"login":"imorrison","id":1871228,"avatar_url":"https://avatars.githubusercontent.com/u/1871228?v=2","gravatar_id":"ba740cf4d0ad9904fc5d1b53e77a7b5b","url":"https://api.github.com/users/imorrison","html_url":"https://github.com/imorrison","followers_url":"https://api.github.com/users/imorrison/followers","following_url":"https://api.github.com/users/imorrison/following{/other_user}","gists_url":"https://api.github.com/users/imorrison/gists{/gist_id}","starred_url":"https://api.github.com/users/imorrison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imorrison/subscriptions","organizations_url":"https://api.github.com/users/imorrison/orgs","repos_url":"https://api.github.com/users/imorrison/repos","events_url":"https://api.github.com/users/imorrison/events{/privacy}","received_events_url":"https://api.github.com/users/imorrison/received_events","type":"User","site_admin":false},"body":"We cannot expect that a project that is using funct-unit is already shiming libraries.","created_at":"2014-09-03T22:58:31Z","updated_at":"2014-09-04T17:19:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42ea75dc72cc1a04e2724375f06511a37da930e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yola/funcunit-as-promised/pulls/3/commits","review_comments_url":"https://api.github.com/repos/yola/funcunit-as-promised/pulls/3/comments","review_comment_url":"https://api.github.com/repos/yola/funcunit-as-promised/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yola/funcunit-as-promised/issues/3/comments","statuses_url":"https://api.github.com/repos/yola/funcunit-as-promised/statuses/8465d71ddb177b4cf6258278420ba389aee24964","head":{"label":"yola:shim","ref":"shim","sha":"8465d71ddb177b4cf6258278420ba389aee24964","user":{"login":"yola","id":861497,"avatar_url":"https://avatars.githubusercontent.com/u/861497?v=2","gravatar_id":"57ec86222accfedd0cfc006b9e1b594a","url":"https://api.github.com/users/yola","html_url":"https://github.com/yola","followers_url":"https://api.github.com/users/yola/followers","following_url":"https://api.github.com/users/yola/following{/other_user}","gists_url":"https://api.github.com/users/yola/gists{/gist_id}","starred_url":"https://api.github.com/users/yola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yola/subscriptions","organizations_url":"https://api.github.com/users/yola/orgs","repos_url":"https://api.github.com/users/yola/repos","events_url":"https://api.github.com/users/yola/events{/privacy}","received_events_url":"https://api.github.com/users/yola/received_events","type":"Organization","site_admin":false},"repo":{"id":20694044,"name":"funcunit-as-promised","full_name":"yola/funcunit-as-promised","owner":{"login":"yola","id":861497,"avatar_url":"https://avatars.githubusercontent.com/u/861497?v=2","gravatar_id":"57ec86222accfedd0cfc006b9e1b594a","url":"https://api.github.com/users/yola","html_url":"https://github.com/yola","followers_url":"https://api.github.com/users/yola/followers","following_url":"https://api.github.com/users/yola/following{/other_user}","gists_url":"https://api.github.com/users/yola/gists{/gist_id}","starred_url":"https://api.github.com/users/yola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yola/subscriptions","organizations_url":"https://api.github.com/users/yola/orgs","repos_url":"https://api.github.com/users/yola/repos","events_url":"https://api.github.com/users/yola/events{/privacy}","received_events_url":"https://api.github.com/users/yola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yola/funcunit-as-promised","description":"","fork":false,"url":"https://api.github.com/repos/yola/funcunit-as-promised","forks_url":"https://api.github.com/repos/yola/funcunit-as-promised/forks","keys_url":"https://api.github.com/repos/yola/funcunit-as-promised/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yola/funcunit-as-promised/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yola/funcunit-as-promised/teams","hooks_url":"https://api.github.com/repos/yola/funcunit-as-promised/hooks","issue_events_url":"https://api.github.com/repos/yola/funcunit-as-promised/issues/events{/number}","events_url":"https://api.github.com/repos/yola/funcunit-as-promised/events","assignees_url":"https://api.github.com/repos/yola/funcunit-as-promised/assignees{/user}","branches_url":"https://api.github.com/repos/yola/funcunit-as-promised/branches{/branch}","tags_url":"https://api.github.com/repos/yola/funcunit-as-promised/tags","blobs_url":"https://api.github.com/repos/yola/funcunit-as-promised/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yola/funcunit-as-promised/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yola/funcunit-as-promised/git/refs{/sha}","trees_url":"https://api.github.com/repos/yola/funcunit-as-promised/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yola/funcunit-as-promised/statuses/{sha}","languages_url":"https://api.github.com/repos/yola/funcunit-as-promised/languages","stargazers_url":"https://api.github.com/repos/yola/funcunit-as-promised/stargazers","contributors_url":"https://api.github.com/repos/yola/funcunit-as-promised/contributors","subscribers_url":"https://api.github.com/repos/yola/funcunit-as-promised/subscribers","subscription_url":"https://api.github.com/repos/yola/funcunit-as-promised/subscription","commits_url":"https://api.github.com/repos/yola/funcunit-as-promised/commits{/sha}","git_commits_url":"https://api.github.com/repos/yola/funcunit-as-promised/git/commits{/sha}","comments_url":"https://api.github.com/repos/yola/funcunit-as-promised/comments{/number}","issue_comment_url":"https://api.github.com/repos/yola/funcunit-as-promised/issues/comments/{number}","contents_url":"https://api.github.com/repos/yola/funcunit-as-promised/contents/{+path}","compare_url":"https://api.github.com/repos/yola/funcunit-as-promised/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yola/funcunit-as-promised/merges","archive_url":"https://api.github.com/repos/yola/funcunit-as-promised/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yola/funcunit-as-promised/downloads","issues_url":"https://api.github.com/repos/yola/funcunit-as-promised/issues{/number}","pulls_url":"https://api.github.com/repos/yola/funcunit-as-promised/pulls{/number}","milestones_url":"https://api.github.com/repos/yola/funcunit-as-promised/milestones{/number}","notifications_url":"https://api.github.com/repos/yola/funcunit-as-promised/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yola/funcunit-as-promised/labels{/name}","releases_url":"https://api.github.com/repos/yola/funcunit-as-promised/releases{/id}","created_at":"2014-06-10T17:10:16Z","updated_at":"2014-06-17T16:15:48Z","pushed_at":"2014-09-03T22:58:24Z","git_url":"git://github.com/yola/funcunit-as-promised.git","ssh_url":"git@github.com:yola/funcunit-as-promised.git","clone_url":"https://github.com/yola/funcunit-as-promised.git","svn_url":"https://github.com/yola/funcunit-as-promised","homepage":null,"size":400,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"yola:master","ref":"master","sha":"24b461a6eb736e5b71beedd7507c871aa3ab7087","user":{"login":"yola","id":861497,"avatar_url":"https://avatars.githubusercontent.com/u/861497?v=2","gravatar_id":"57ec86222accfedd0cfc006b9e1b594a","url":"https://api.github.com/users/yola","html_url":"https://github.com/yola","followers_url":"https://api.github.com/users/yola/followers","following_url":"https://api.github.com/users/yola/following{/other_user}","gists_url":"https://api.github.com/users/yola/gists{/gist_id}","starred_url":"https://api.github.com/users/yola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yola/subscriptions","organizations_url":"https://api.github.com/users/yola/orgs","repos_url":"https://api.github.com/users/yola/repos","events_url":"https://api.github.com/users/yola/events{/privacy}","received_events_url":"https://api.github.com/users/yola/received_events","type":"Organization","site_admin":false},"repo":{"id":20694044,"name":"funcunit-as-promised","full_name":"yola/funcunit-as-promised","owner":{"login":"yola","id":861497,"avatar_url":"https://avatars.githubusercontent.com/u/861497?v=2","gravatar_id":"57ec86222accfedd0cfc006b9e1b594a","url":"https://api.github.com/users/yola","html_url":"https://github.com/yola","followers_url":"https://api.github.com/users/yola/followers","following_url":"https://api.github.com/users/yola/following{/other_user}","gists_url":"https://api.github.com/users/yola/gists{/gist_id}","starred_url":"https://api.github.com/users/yola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yola/subscriptions","organizations_url":"https://api.github.com/users/yola/orgs","repos_url":"https://api.github.com/users/yola/repos","events_url":"https://api.github.com/users/yola/events{/privacy}","received_events_url":"https://api.github.com/users/yola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yola/funcunit-as-promised","description":"","fork":false,"url":"https://api.github.com/repos/yola/funcunit-as-promised","forks_url":"https://api.github.com/repos/yola/funcunit-as-promised/forks","keys_url":"https://api.github.com/repos/yola/funcunit-as-promised/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yola/funcunit-as-promised/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yola/funcunit-as-promised/teams","hooks_url":"https://api.github.com/repos/yola/funcunit-as-promised/hooks","issue_events_url":"https://api.github.com/repos/yola/funcunit-as-promised/issues/events{/number}","events_url":"https://api.github.com/repos/yola/funcunit-as-promised/events","assignees_url":"https://api.github.com/repos/yola/funcunit-as-promised/assignees{/user}","branches_url":"https://api.github.com/repos/yola/funcunit-as-promised/branches{/branch}","tags_url":"https://api.github.com/repos/yola/funcunit-as-promised/tags","blobs_url":"https://api.github.com/repos/yola/funcunit-as-promised/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yola/funcunit-as-promised/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yola/funcunit-as-promised/git/refs{/sha}","trees_url":"https://api.github.com/repos/yola/funcunit-as-promised/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yola/funcunit-as-promised/statuses/{sha}","languages_url":"https://api.github.com/repos/yola/funcunit-as-promised/languages","stargazers_url":"https://api.github.com/repos/yola/funcunit-as-promised/stargazers","contributors_url":"https://api.github.com/repos/yola/funcunit-as-promised/contributors","subscribers_url":"https://api.github.com/repos/yola/funcunit-as-promised/subscribers","subscription_url":"https://api.github.com/repos/yola/funcunit-as-promised/subscription","commits_url":"https://api.github.com/repos/yola/funcunit-as-promised/commits{/sha}","git_commits_url":"https://api.github.com/repos/yola/funcunit-as-promised/git/commits{/sha}","comments_url":"https://api.github.com/repos/yola/funcunit-as-promised/comments{/number}","issue_comment_url":"https://api.github.com/repos/yola/funcunit-as-promised/issues/comments/{number}","contents_url":"https://api.github.com/repos/yola/funcunit-as-promised/contents/{+path}","compare_url":"https://api.github.com/repos/yola/funcunit-as-promised/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yola/funcunit-as-promised/merges","archive_url":"https://api.github.com/repos/yola/funcunit-as-promised/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yola/funcunit-as-promised/downloads","issues_url":"https://api.github.com/repos/yola/funcunit-as-promised/issues{/number}","pulls_url":"https://api.github.com/repos/yola/funcunit-as-promised/pulls{/number}","milestones_url":"https://api.github.com/repos/yola/funcunit-as-promised/milestones{/number}","notifications_url":"https://api.github.com/repos/yola/funcunit-as-promised/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yola/funcunit-as-promised/labels{/name}","releases_url":"https://api.github.com/repos/yola/funcunit-as-promised/releases{/id}","created_at":"2014-06-10T17:10:16Z","updated_at":"2014-06-17T16:15:48Z","pushed_at":"2014-09-03T22:58:24Z","git_url":"git://github.com/yola/funcunit-as-promised.git","ssh_url":"git@github.com:yola/funcunit-as-promised.git","clone_url":"https://github.com/yola/funcunit-as-promised.git","svn_url":"https://github.com/yola/funcunit-as-promised","homepage":null,"size":400,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yola/funcunit-as-promised/pulls/3"},"html":{"href":"https://github.com/yola/funcunit-as-promised/pull/3"},"issue":{"href":"https://api.github.com/repos/yola/funcunit-as-promised/issues/3"},"comments":{"href":"https://api.github.com/repos/yola/funcunit-as-promised/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/yola/funcunit-as-promised/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/yola/funcunit-as-promised/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yola/funcunit-as-promised/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/yola/funcunit-as-promised/statuses/8465d71ddb177b4cf6258278420ba389aee24964"}}}}