GitHub PullRequestReviewCommentEvent at 2014-03-02 18:03:19
Repository: WebODF
Actor: kossebau
Payload: {"comment":{"url":"https://api.github.com/repos/kogmbh/WebODF/pulls/comments/10196516","id":10196516,"diff_hunk":"@@ -1490,14 +1490,13 @@\n          * @return {undefined}\n          */\n         this.setZoomLevel = function (zoom) {\n-            zoomLevel = zoom;\n-            fixContainerSize();\n+            zoomHelper.setZoomLevel(zoom);\n         };\n         /**\n          * @return {!number}\n          */\n         this.getZoomLevel = function () {\n-            return zoomLevel;\n+            return zoomHelper.getZoomLevel();","path":"webodf/lib/odf/OdfCanvas.js","position":111,"original_position":111,"commit_id":"94530eb089acc63b379fe5f3b5b4aedbfce35a2c","original_commit_id":"94530eb089acc63b379fe5f3b5b4aedbfce35a2c","user":{"login":"kossebau","id":4068037,"avatar_url":"https://avatars.githubusercontent.com/u/4068037","gravatar_id":"6ec9d5b4b917b38c571b568766c59bf4","url":"https://api.github.com/users/kossebau","html_url":"https://github.com/kossebau","followers_url":"https://api.github.com/users/kossebau/followers","following_url":"https://api.github.com/users/kossebau/following{/other_user}","gists_url":"https://api.github.com/users/kossebau/gists{/gist_id}","starred_url":"https://api.github.com/users/kossebau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kossebau/subscriptions","organizations_url":"https://api.github.com/users/kossebau/orgs","repos_url":"https://api.github.com/users/kossebau/repos","events_url":"https://api.github.com/users/kossebau/events{/privacy}","received_events_url":"https://api.github.com/users/kossebau/received_events","type":"User","site_admin":false},"body":"zoomHelper only exists once handleContent() is called. so check before using it. Possibly there should be some internal helper method\r\n```\r\nfunction getZoomLevel() {\r\n    return zoomHelper ? zoomHelper.getZoomLevel() : 1;\r\n}\r\n```\r\nwhich would be used in all places that want the current zoomlevel.","created_at":"2014-03-02T18:03:19Z","updated_at":"2014-03-02T18:03:19Z","html_url":"https://github.com/kogmbh/WebODF/pull/433#discussion_r10196516","pull_request_url":"https://api.github.com/repos/kogmbh/WebODF/pulls/433","_links":{"self":{"href":"https://api.github.com/repos/kogmbh/WebODF/pulls/comments/10196516"},"html":{"href":"https://github.com/kogmbh/WebODF/pull/433#discussion_r10196516"},"pull_request":{"href":"https://api.github.com/repos/kogmbh/WebODF/pulls/433"}}}}