GitHub PullRequestEvent at 2014-09-24 03:06:26
Repository: persistent
Actor: reem
Payload: {"action":"closed","number":27,"pull_request":{"url":"https://api.github.com/repos/iron/persistent/pulls/27","id":21688596,"html_url":"https://github.com/iron/persistent/pull/27","diff_url":"https://github.com/iron/persistent/pull/27.diff","patch_url":"https://github.com/iron/persistent/pull/27.patch","issue_url":"https://api.github.com/repos/iron/persistent/issues/27","number":27,"state":"closed","locked":false,"title":"(fix) add explicit 'static lifetimes to val types","user":{"login":"duelinmarkers","id":9761,"avatar_url":"https://avatars.githubusercontent.com/u/9761?v=2","gravatar_id":"","url":"https://api.github.com/users/duelinmarkers","html_url":"https://github.com/duelinmarkers","followers_url":"https://api.github.com/users/duelinmarkers/followers","following_url":"https://api.github.com/users/duelinmarkers/following{/other_user}","gists_url":"https://api.github.com/users/duelinmarkers/gists{/gist_id}","starred_url":"https://api.github.com/users/duelinmarkers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duelinmarkers/subscriptions","organizations_url":"https://api.github.com/users/duelinmarkers/orgs","repos_url":"https://api.github.com/users/duelinmarkers/repos","events_url":"https://api.github.com/users/duelinmarkers/events{/privacy}","received_events_url":"https://api.github.com/users/duelinmarkers/received_events","type":"User","site_admin":false},"body":"Fixing #26. This works in my example app, and it seems like `'static` is right for the \"normal\" way to use Persistent, but I'm not sure if something else could work and not impose the limitation that the val be valid for the lifetime of the process.","created_at":"2014-09-24T02:15:20Z","updated_at":"2014-09-24T03:06:25Z","closed_at":"2014-09-24T03:06:25Z","merged_at":"2014-09-24T03:06:25Z","merge_commit_sha":"7f6306ee75e8e8f77f2a6c44bd259534e82e1d59","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iron/persistent/pulls/27/commits","review_comments_url":"https://api.github.com/repos/iron/persistent/pulls/27/comments","review_comment_url":"https://api.github.com/repos/iron/persistent/pulls/comments/{number}","comments_url":"https://api.github.com/repos/iron/persistent/issues/27/comments","statuses_url":"https://api.github.com/repos/iron/persistent/statuses/d76c5190e359d7530f376ce29411f2afabfefe1e","head":{"label":"duelinmarkers:bug/explicit-lifetimes-needed","ref":"bug/explicit-lifetimes-needed","sha":"d76c5190e359d7530f376ce29411f2afabfefe1e","user":{"login":"duelinmarkers","id":9761,"avatar_url":"https://avatars.githubusercontent.com/u/9761?v=2","gravatar_id":"","url":"https://api.github.com/users/duelinmarkers","html_url":"https://github.com/duelinmarkers","followers_url":"https://api.github.com/users/duelinmarkers/followers","following_url":"https://api.github.com/users/duelinmarkers/following{/other_user}","gists_url":"https://api.github.com/users/duelinmarkers/gists{/gist_id}","starred_url":"https://api.github.com/users/duelinmarkers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duelinmarkers/subscriptions","organizations_url":"https://api.github.com/users/duelinmarkers/orgs","repos_url":"https://api.github.com/users/duelinmarkers/repos","events_url":"https://api.github.com/users/duelinmarkers/events{/privacy}","received_events_url":"https://api.github.com/users/duelinmarkers/received_events","type":"User","site_admin":false},"repo":{"id":23059627,"name":"persistent","full_name":"duelinmarkers/persistent","owner":{"login":"duelinmarkers","id":9761,"avatar_url":"https://avatars.githubusercontent.com/u/9761?v=2","gravatar_id":"","url":"https://api.github.com/users/duelinmarkers","html_url":"https://github.com/duelinmarkers","followers_url":"https://api.github.com/users/duelinmarkers/followers","following_url":"https://api.github.com/users/duelinmarkers/following{/other_user}","gists_url":"https://api.github.com/users/duelinmarkers/gists{/gist_id}","starred_url":"https://api.github.com/users/duelinmarkers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duelinmarkers/subscriptions","organizations_url":"https://api.github.com/users/duelinmarkers/orgs","repos_url":"https://api.github.com/users/duelinmarkers/repos","events_url":"https://api.github.com/users/duelinmarkers/events{/privacy}","received_events_url":"https://api.github.com/users/duelinmarkers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duelinmarkers/persistent","description":"Middleware for sharing data between requests","fork":true,"url":"https://api.github.com/repos/duelinmarkers/persistent","forks_url":"https://api.github.com/repos/duelinmarkers/persistent/forks","keys_url":"https://api.github.com/repos/duelinmarkers/persistent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duelinmarkers/persistent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duelinmarkers/persistent/teams","hooks_url":"https://api.github.com/repos/duelinmarkers/persistent/hooks","issue_events_url":"https://api.github.com/repos/duelinmarkers/persistent/issues/events{/number}","events_url":"https://api.github.com/repos/duelinmarkers/persistent/events","assignees_url":"https://api.github.com/repos/duelinmarkers/persistent/assignees{/user}","branches_url":"https://api.github.com/repos/duelinmarkers/persistent/branches{/branch}","tags_url":"https://api.github.com/repos/duelinmarkers/persistent/tags","blobs_url":"https://api.github.com/repos/duelinmarkers/persistent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duelinmarkers/persistent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duelinmarkers/persistent/git/refs{/sha}","trees_url":"https://api.github.com/repos/duelinmarkers/persistent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duelinmarkers/persistent/statuses/{sha}","languages_url":"https://api.github.com/repos/duelinmarkers/persistent/languages","stargazers_url":"https://api.github.com/repos/duelinmarkers/persistent/stargazers","contributors_url":"https://api.github.com/repos/duelinmarkers/persistent/contributors","subscribers_url":"https://api.github.com/repos/duelinmarkers/persistent/subscribers","subscription_url":"https://api.github.com/repos/duelinmarkers/persistent/subscription","commits_url":"https://api.github.com/repos/duelinmarkers/persistent/commits{/sha}","git_commits_url":"https://api.github.com/repos/duelinmarkers/persistent/git/commits{/sha}","comments_url":"https://api.github.com/repos/duelinmarkers/persistent/comments{/number}","issue_comment_url":"https://api.github.com/repos/duelinmarkers/persistent/issues/comments/{number}","contents_url":"https://api.github.com/repos/duelinmarkers/persistent/contents/{+path}","compare_url":"https://api.github.com/repos/duelinmarkers/persistent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duelinmarkers/persistent/merges","archive_url":"https://api.github.com/repos/duelinmarkers/persistent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duelinmarkers/persistent/downloads","issues_url":"https://api.github.com/repos/duelinmarkers/persistent/issues{/number}","pulls_url":"https://api.github.com/repos/duelinmarkers/persistent/pulls{/number}","milestones_url":"https://api.github.com/repos/duelinmarkers/persistent/milestones{/number}","notifications_url":"https://api.github.com/repos/duelinmarkers/persistent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duelinmarkers/persistent/labels{/name}","releases_url":"https://api.github.com/repos/duelinmarkers/persistent/releases{/id}","created_at":"2014-08-18T05:22:28Z","updated_at":"2014-06-26T01:04:29Z","pushed_at":"2014-09-24T02:09:56Z","git_url":"git://github.com/duelinmarkers/persistent.git","ssh_url":"git@github.com:duelinmarkers/persistent.git","clone_url":"https://github.com/duelinmarkers/persistent.git","svn_url":"https://github.com/duelinmarkers/persistent","homepage":null,"size":161,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iron:master","ref":"master","sha":"c8e75f5bb3cd858bf25bed2b8d1c7b927ec782fe","user":{"login":"iron","id":7853871,"avatar_url":"https://avatars.githubusercontent.com/u/7853871?v=2","gravatar_id":"","url":"https://api.github.com/users/iron","html_url":"https://github.com/iron","followers_url":"https://api.github.com/users/iron/followers","following_url":"https://api.github.com/users/iron/following{/other_user}","gists_url":"https://api.github.com/users/iron/gists{/gist_id}","starred_url":"https://api.github.com/users/iron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iron/subscriptions","organizations_url":"https://api.github.com/users/iron/orgs","repos_url":"https://api.github.com/users/iron/repos","events_url":"https://api.github.com/users/iron/events{/privacy}","received_events_url":"https://api.github.com/users/iron/received_events","type":"Organization","site_admin":false},"repo":{"id":21138962,"name":"persistent","full_name":"iron/persistent","owner":{"login":"iron","id":7853871,"avatar_url":"https://avatars.githubusercontent.com/u/7853871?v=2","gravatar_id":"","url":"https://api.github.com/users/iron","html_url":"https://github.com/iron","followers_url":"https://api.github.com/users/iron/followers","following_url":"https://api.github.com/users/iron/following{/other_user}","gists_url":"https://api.github.com/users/iron/gists{/gist_id}","starred_url":"https://api.github.com/users/iron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iron/subscriptions","organizations_url":"https://api.github.com/users/iron/orgs","repos_url":"https://api.github.com/users/iron/repos","events_url":"https://api.github.com/users/iron/events{/privacy}","received_events_url":"https://api.github.com/users/iron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iron/persistent","description":"Middleware for sharing data between requests","fork":false,"url":"https://api.github.com/repos/iron/persistent","forks_url":"https://api.github.com/repos/iron/persistent/forks","keys_url":"https://api.github.com/repos/iron/persistent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iron/persistent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iron/persistent/teams","hooks_url":"https://api.github.com/repos/iron/persistent/hooks","issue_events_url":"https://api.github.com/repos/iron/persistent/issues/events{/number}","events_url":"https://api.github.com/repos/iron/persistent/events","assignees_url":"https://api.github.com/repos/iron/persistent/assignees{/user}","branches_url":"https://api.github.com/repos/iron/persistent/branches{/branch}","tags_url":"https://api.github.com/repos/iron/persistent/tags","blobs_url":"https://api.github.com/repos/iron/persistent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iron/persistent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iron/persistent/git/refs{/sha}","trees_url":"https://api.github.com/repos/iron/persistent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iron/persistent/statuses/{sha}","languages_url":"https://api.github.com/repos/iron/persistent/languages","stargazers_url":"https://api.github.com/repos/iron/persistent/stargazers","contributors_url":"https://api.github.com/repos/iron/persistent/contributors","subscribers_url":"https://api.github.com/repos/iron/persistent/subscribers","subscription_url":"https://api.github.com/repos/iron/persistent/subscription","commits_url":"https://api.github.com/repos/iron/persistent/commits{/sha}","git_commits_url":"https://api.github.com/repos/iron/persistent/git/commits{/sha}","comments_url":"https://api.github.com/repos/iron/persistent/comments{/number}","issue_comment_url":"https://api.github.com/repos/iron/persistent/issues/comments/{number}","contents_url":"https://api.github.com/repos/iron/persistent/contents/{+path}","compare_url":"https://api.github.com/repos/iron/persistent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iron/persistent/merges","archive_url":"https://api.github.com/repos/iron/persistent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iron/persistent/downloads","issues_url":"https://api.github.com/repos/iron/persistent/issues{/number}","pulls_url":"https://api.github.com/repos/iron/persistent/pulls{/number}","milestones_url":"https://api.github.com/repos/iron/persistent/milestones{/number}","notifications_url":"https://api.github.com/repos/iron/persistent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iron/persistent/labels{/name}","releases_url":"https://api.github.com/repos/iron/persistent/releases{/id}","created_at":"2014-06-23T19:17:04Z","updated_at":"2014-09-08T05:47:55Z","pushed_at":"2014-09-24T03:06:25Z","git_url":"git://github.com/iron/persistent.git","ssh_url":"git@github.com:iron/persistent.git","clone_url":"https://github.com/iron/persistent.git","svn_url":"https://github.com/iron/persistent","homepage":null,"size":706,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iron/persistent/pulls/27"},"html":{"href":"https://github.com/iron/persistent/pull/27"},"issue":{"href":"https://api.github.com/repos/iron/persistent/issues/27"},"comments":{"href":"https://api.github.com/repos/iron/persistent/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/iron/persistent/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/iron/persistent/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/iron/persistent/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/iron/persistent/statuses/d76c5190e359d7530f376ce29411f2afabfefe1e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"reem","id":4745181,"avatar_url":"https://avatars.githubusercontent.com/u/4745181?v=2","gravatar_id":"","url":"https://api.github.com/users/reem","html_url":"https://github.com/reem","followers_url":"https://api.github.com/users/reem/followers","following_url":"https://api.github.com/users/reem/following{/other_user}","gists_url":"https://api.github.com/users/reem/gists{/gist_id}","starred_url":"https://api.github.com/users/reem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reem/subscriptions","organizations_url":"https://api.github.com/users/reem/orgs","repos_url":"https://api.github.com/users/reem/repos","events_url":"https://api.github.com/users/reem/events{/privacy}","received_events_url":"https://api.github.com/users/reem/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":4,"changed_files":1}}