GitHub PullRequestReviewCommentEvent at 2014-08-07 00:40:51
Repository: university-ios-assignment-6
Actor: Maxim-38RUS-Zabelin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls/comments/15912990","id":15912990,"diff_hunk":"@@ -35,4 +35,10 @@\n  */\n @property (nonatomic, weak) id<NewRecordViewControllerDelegate> delegate;\n \n+\n+/**\n+ *  Designated initializer.\n+ */\n+- (instancetype) initWithRecord:(NSDictionary *)record;","path":"PasswordManager/PasswordManager/Classes/NewRecordViewController.h","position":8,"original_position":8,"commit_id":"6e0159511b69087109120a635c0c0a5da8d6403a","original_commit_id":"6e0159511b69087109120a635c0c0a5da8d6403a","user":{"login":"Maxim-38RUS-Zabelin","id":6905856,"avatar_url":"https://avatars.githubusercontent.com/u/6905856?v=2","gravatar_id":null,"url":"https://api.github.com/users/Maxim-38RUS-Zabelin","html_url":"https://github.com/Maxim-38RUS-Zabelin","followers_url":"https://api.github.com/users/Maxim-38RUS-Zabelin/followers","following_url":"https://api.github.com/users/Maxim-38RUS-Zabelin/following{/other_user}","gists_url":"https://api.github.com/users/Maxim-38RUS-Zabelin/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxim-38RUS-Zabelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxim-38RUS-Zabelin/subscriptions","organizations_url":"https://api.github.com/users/Maxim-38RUS-Zabelin/orgs","repos_url":"https://api.github.com/users/Maxim-38RUS-Zabelin/repos","events_url":"https://api.github.com/users/Maxim-38RUS-Zabelin/events{/privacy}","received_events_url":"https://api.github.com/users/Maxim-38RUS-Zabelin/received_events","type":"User","site_admin":false},"body":"In fact you should avoid creating custom designated initialisers for the view controllers. Considering this particular case, a NewRecordViewController may exist even if no record is provided from the outside; that means such an initialiser is not required, you'd better introduce a public property.","created_at":"2014-08-07T00:40:51Z","updated_at":"2014-08-07T00:40:51Z","html_url":"https://github.com/noveogroup/university-ios-assignment-6/pull/3#discussion_r15912990","pull_request_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls/comments/15912990"},"html":{"href":"https://github.com/noveogroup/university-ios-assignment-6/pull/3#discussion_r15912990"},"pull_request":{"href":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls/3","id":19343001,"html_url":"https://github.com/noveogroup/university-ios-assignment-6/pull/3","diff_url":"https://github.com/noveogroup/university-ios-assignment-6/pull/3.diff","patch_url":"https://github.com/noveogroup/university-ios-assignment-6/pull/3.patch","issue_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/issues/3","number":3,"state":"open","title":"Smirnov Vadim - Noveo Homework 6","user":{"login":"vadimsmirnovnsk","id":8159640,"avatar_url":"https://avatars.githubusercontent.com/u/8159640?v=2","gravatar_id":"66cc88ec01b2502e8408426e9a0dc65a","url":"https://api.github.com/users/vadimsmirnovnsk","html_url":"https://github.com/vadimsmirnovnsk","followers_url":"https://api.github.com/users/vadimsmirnovnsk/followers","following_url":"https://api.github.com/users/vadimsmirnovnsk/following{/other_user}","gists_url":"https://api.github.com/users/vadimsmirnovnsk/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimsmirnovnsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimsmirnovnsk/subscriptions","organizations_url":"https://api.github.com/users/vadimsmirnovnsk/orgs","repos_url":"https://api.github.com/users/vadimsmirnovnsk/repos","events_url":"https://api.github.com/users/vadimsmirnovnsk/events{/privacy}","received_events_url":"https://api.github.com/users/vadimsmirnovnsk/received_events","type":"User","site_admin":false},"body":"Deleting and Editing passwords.\r\nSaving passwords to Plist and with NSKeyedArchiever.\r\nOptions menu with a User Preferences.\r\nPreferences in the Phone-options for applications.\r\n","created_at":"2014-08-05T13:54:59Z","updated_at":"2014-08-07T00:40:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4a40e3c710be74aff2bcb37e0bbee1ece43460b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls/3/commits","review_comments_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls/3/comments","review_comment_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls/comments/{number}","comments_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/issues/3/comments","statuses_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/statuses/6e0159511b69087109120a635c0c0a5da8d6403a","head":{"label":"vadimsmirnovnsk:master","ref":"master","sha":"6e0159511b69087109120a635c0c0a5da8d6403a","user":{"login":"vadimsmirnovnsk","id":8159640,"avatar_url":"https://avatars.githubusercontent.com/u/8159640?v=2","gravatar_id":"66cc88ec01b2502e8408426e9a0dc65a","url":"https://api.github.com/users/vadimsmirnovnsk","html_url":"https://github.com/vadimsmirnovnsk","followers_url":"https://api.github.com/users/vadimsmirnovnsk/followers","following_url":"https://api.github.com/users/vadimsmirnovnsk/following{/other_user}","gists_url":"https://api.github.com/users/vadimsmirnovnsk/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimsmirnovnsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimsmirnovnsk/subscriptions","organizations_url":"https://api.github.com/users/vadimsmirnovnsk/orgs","repos_url":"https://api.github.com/users/vadimsmirnovnsk/repos","events_url":"https://api.github.com/users/vadimsmirnovnsk/events{/privacy}","received_events_url":"https://api.github.com/users/vadimsmirnovnsk/received_events","type":"User","site_admin":false},"repo":{"id":22576728,"name":"university-ios-assignment-6","full_name":"vadimsmirnovnsk/university-ios-assignment-6","owner":{"login":"vadimsmirnovnsk","id":8159640,"avatar_url":"https://avatars.githubusercontent.com/u/8159640?v=2","gravatar_id":"66cc88ec01b2502e8408426e9a0dc65a","url":"https://api.github.com/users/vadimsmirnovnsk","html_url":"https://github.com/vadimsmirnovnsk","followers_url":"https://api.github.com/users/vadimsmirnovnsk/followers","following_url":"https://api.github.com/users/vadimsmirnovnsk/following{/other_user}","gists_url":"https://api.github.com/users/vadimsmirnovnsk/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimsmirnovnsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimsmirnovnsk/subscriptions","organizations_url":"https://api.github.com/users/vadimsmirnovnsk/orgs","repos_url":"https://api.github.com/users/vadimsmirnovnsk/repos","events_url":"https://api.github.com/users/vadimsmirnovnsk/events{/privacy}","received_events_url":"https://api.github.com/users/vadimsmirnovnsk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vadimsmirnovnsk/university-ios-assignment-6","description":"Persistence","fork":true,"url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6","forks_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/forks","keys_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/teams","hooks_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/hooks","issue_events_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/issues/events{/number}","events_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/events","assignees_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/assignees{/user}","branches_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/branches{/branch}","tags_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/tags","blobs_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/git/refs{/sha}","trees_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/statuses/{sha}","languages_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/languages","stargazers_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/stargazers","contributors_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/contributors","subscribers_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/subscribers","subscription_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/subscription","commits_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/commits{/sha}","git_commits_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/git/commits{/sha}","comments_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/comments{/number}","issue_comment_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/issues/comments/{number}","contents_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/contents/{+path}","compare_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/merges","archive_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/downloads","issues_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/issues{/number}","pulls_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/pulls{/number}","milestones_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/milestones{/number}","notifications_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/labels{/name}","releases_url":"https://api.github.com/repos/vadimsmirnovnsk/university-ios-assignment-6/releases{/id}","created_at":"2014-08-03T14:41:51Z","updated_at":"2014-08-03T17:01:20Z","pushed_at":"2014-08-06T09:12:05Z","git_url":"git://github.com/vadimsmirnovnsk/university-ios-assignment-6.git","ssh_url":"git@github.com:vadimsmirnovnsk/university-ios-assignment-6.git","clone_url":"https://github.com/vadimsmirnovnsk/university-ios-assignment-6.git","svn_url":"https://github.com/vadimsmirnovnsk/university-ios-assignment-6","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"noveogroup:master","ref":"master","sha":"d777bb36c2d65a398af03809cdf72d309dfd6a38","user":{"login":"noveogroup","id":3395790,"avatar_url":"https://avatars.githubusercontent.com/u/3395790?v=2","gravatar_id":"f40c16d871f85820bc5a813c5ea750e0","url":"https://api.github.com/users/noveogroup","html_url":"https://github.com/noveogroup","followers_url":"https://api.github.com/users/noveogroup/followers","following_url":"https://api.github.com/users/noveogroup/following{/other_user}","gists_url":"https://api.github.com/users/noveogroup/gists{/gist_id}","starred_url":"https://api.github.com/users/noveogroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noveogroup/subscriptions","organizations_url":"https://api.github.com/users/noveogroup/orgs","repos_url":"https://api.github.com/users/noveogroup/repos","events_url":"https://api.github.com/users/noveogroup/events{/privacy}","received_events_url":"https://api.github.com/users/noveogroup/received_events","type":"Organization","site_admin":false},"repo":{"id":22460785,"name":"university-ios-assignment-6","full_name":"noveogroup/university-ios-assignment-6","owner":{"login":"noveogroup","id":3395790,"avatar_url":"https://avatars.githubusercontent.com/u/3395790?v=2","gravatar_id":"f40c16d871f85820bc5a813c5ea750e0","url":"https://api.github.com/users/noveogroup","html_url":"https://github.com/noveogroup","followers_url":"https://api.github.com/users/noveogroup/followers","following_url":"https://api.github.com/users/noveogroup/following{/other_user}","gists_url":"https://api.github.com/users/noveogroup/gists{/gist_id}","starred_url":"https://api.github.com/users/noveogroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noveogroup/subscriptions","organizations_url":"https://api.github.com/users/noveogroup/orgs","repos_url":"https://api.github.com/users/noveogroup/repos","events_url":"https://api.github.com/users/noveogroup/events{/privacy}","received_events_url":"https://api.github.com/users/noveogroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/noveogroup/university-ios-assignment-6","description":"Persistence","fork":false,"url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6","forks_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/forks","keys_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/teams","hooks_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/hooks","issue_events_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/issues/events{/number}","events_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/events","assignees_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/assignees{/user}","branches_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/branches{/branch}","tags_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/tags","blobs_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/git/refs{/sha}","trees_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/statuses/{sha}","languages_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/languages","stargazers_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/stargazers","contributors_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/contributors","subscribers_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/subscribers","subscription_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/subscription","commits_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/commits{/sha}","git_commits_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/git/commits{/sha}","comments_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/comments{/number}","issue_comment_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/issues/comments/{number}","contents_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/contents/{+path}","compare_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/merges","archive_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/downloads","issues_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/issues{/number}","pulls_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls{/number}","milestones_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/milestones{/number}","notifications_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/labels{/name}","releases_url":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/releases{/id}","created_at":"2014-07-31T07:38:53Z","updated_at":"2014-07-31T07:53:47Z","pushed_at":"2014-07-31T07:53:47Z","git_url":"git://github.com/noveogroup/university-ios-assignment-6.git","ssh_url":"git@github.com:noveogroup/university-ios-assignment-6.git","clone_url":"https://github.com/noveogroup/university-ios-assignment-6.git","svn_url":"https://github.com/noveogroup/university-ios-assignment-6","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls/3"},"html":{"href":"https://github.com/noveogroup/university-ios-assignment-6/pull/3"},"issue":{"href":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/issues/3"},"comments":{"href":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/noveogroup/university-ios-assignment-6/statuses/6e0159511b69087109120a635c0c0a5da8d6403a"}}}}