GitHub PullRequestEvent at 2014-07-29 00:01:36
Repository: aodn-portal
Actor: pmbohm
Payload: {"action":"closed","number":1323,"pull_request":{"url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1323","id":19000725,"html_url":"https://github.com/aodn/aodn-portal/pull/1323","diff_url":"https://github.com/aodn/aodn-portal/pull/1323.diff","patch_url":"https://github.com/aodn/aodn-portal/pull/1323.patch","issue_url":"https://api.github.com/repos/aodn/aodn-portal/issues/1323","number":1323,"state":"closed","title":"Use an Ext label (instead of plain Container) so that there is no need t...","user":{"login":"jkburges","id":1849176,"avatar_url":"https://avatars.githubusercontent.com/u/1849176?","gravatar_id":"c6022ce776b5415ea90bddd94355fffa","url":"https://api.github.com/users/jkburges","html_url":"https://github.com/jkburges","followers_url":"https://api.github.com/users/jkburges/followers","following_url":"https://api.github.com/users/jkburges/following{/other_user}","gists_url":"https://api.github.com/users/jkburges/gists{/gist_id}","starred_url":"https://api.github.com/users/jkburges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkburges/subscriptions","organizations_url":"https://api.github.com/users/jkburges/orgs","repos_url":"https://api.github.com/users/jkburges/repos","events_url":"https://api.github.com/users/jkburges/events{/privacy}","received_events_url":"https://api.github.com/users/jkburges/received_events","type":"User","site_admin":false},"body":"...o handle/check for rendered status.\r\n\r\n@pmbohm I have had a fiddle and made a couple of small changes... see below.\r\n\r\nIt seems that using an `Ext.form.Label`, as opposed to `Container`, and calling `setText` instead of `update`, handles both the rendered and non-rendered situation for us.\r\n\r\nAs you probably already found out, the problem before was that for the SRS layer, the code was trying to update the component before it was rendered.\r\n","created_at":"2014-07-28T23:36:51Z","updated_at":"2014-07-29T00:01:36Z","closed_at":"2014-07-29T00:01:36Z","merged_at":"2014-07-29T00:01:36Z","merge_commit_sha":"89b55a2dfb7d86fee8e0a87954f1d691dd25591b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1323/commits","review_comments_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1323/comments","review_comment_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/issues/1323/comments","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/f2c1031aef3867268740886fefd8550689e56649","head":{"label":"aodn:issue-1301-using-label","ref":"issue-1301-using-label","sha":"f2c1031aef3867268740886fefd8550689e56649","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?","gravatar_id":"12505730e34fd65cc3c855cac1bc6159","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":6806252,"name":"aodn-portal","full_name":"aodn/aodn-portal","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?","gravatar_id":"12505730e34fd65cc3c855cac1bc6159","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/aodn-portal","description":"AODN Open Geospatial Portal","fork":false,"url":"https://api.github.com/repos/aodn/aodn-portal","forks_url":"https://api.github.com/repos/aodn/aodn-portal/forks","keys_url":"https://api.github.com/repos/aodn/aodn-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/aodn-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/aodn-portal/teams","hooks_url":"https://api.github.com/repos/aodn/aodn-portal/hooks","issue_events_url":"https://api.github.com/repos/aodn/aodn-portal/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/aodn-portal/events","assignees_url":"https://api.github.com/repos/aodn/aodn-portal/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/aodn-portal/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/aodn-portal/tags","blobs_url":"https://api.github.com/repos/aodn/aodn-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/aodn-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/aodn-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/aodn-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/aodn-portal/languages","stargazers_url":"https://api.github.com/repos/aodn/aodn-portal/stargazers","contributors_url":"https://api.github.com/repos/aodn/aodn-portal/contributors","subscribers_url":"https://api.github.com/repos/aodn/aodn-portal/subscribers","subscription_url":"https://api.github.com/repos/aodn/aodn-portal/subscription","commits_url":"https://api.github.com/repos/aodn/aodn-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/aodn-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/aodn-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/aodn/aodn-portal/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/aodn-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/aodn-portal/merges","archive_url":"https://api.github.com/repos/aodn/aodn-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/aodn-portal/downloads","issues_url":"https://api.github.com/repos/aodn/aodn-portal/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/aodn-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/aodn-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/aodn-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/aodn-portal/labels{/name}","releases_url":"https://api.github.com/repos/aodn/aodn-portal/releases{/id}","created_at":"2012-11-22T01:42:50Z","updated_at":"2014-06-30T00:59:44Z","pushed_at":"2014-07-29T00:01:36Z","git_url":"git://github.com/aodn/aodn-portal.git","ssh_url":"git@github.com:aodn/aodn-portal.git","clone_url":"https://github.com/aodn/aodn-portal.git","svn_url":"https://github.com/aodn/aodn-portal","homepage":"","size":74162,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":109,"forks":8,"open_issues":109,"watchers":3,"default_branch":"master"}},"base":{"label":"aodn:issue-1301","ref":"issue-1301","sha":"edf710dd724021ec09bbbbdde06dc3c655426423","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?","gravatar_id":"12505730e34fd65cc3c855cac1bc6159","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":6806252,"name":"aodn-portal","full_name":"aodn/aodn-portal","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?","gravatar_id":"12505730e34fd65cc3c855cac1bc6159","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/aodn-portal","description":"AODN Open Geospatial Portal","fork":false,"url":"https://api.github.com/repos/aodn/aodn-portal","forks_url":"https://api.github.com/repos/aodn/aodn-portal/forks","keys_url":"https://api.github.com/repos/aodn/aodn-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/aodn-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/aodn-portal/teams","hooks_url":"https://api.github.com/repos/aodn/aodn-portal/hooks","issue_events_url":"https://api.github.com/repos/aodn/aodn-portal/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/aodn-portal/events","assignees_url":"https://api.github.com/repos/aodn/aodn-portal/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/aodn-portal/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/aodn-portal/tags","blobs_url":"https://api.github.com/repos/aodn/aodn-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/aodn-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/aodn-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/aodn-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/aodn-portal/languages","stargazers_url":"https://api.github.com/repos/aodn/aodn-portal/stargazers","contributors_url":"https://api.github.com/repos/aodn/aodn-portal/contributors","subscribers_url":"https://api.github.com/repos/aodn/aodn-portal/subscribers","subscription_url":"https://api.github.com/repos/aodn/aodn-portal/subscription","commits_url":"https://api.github.com/repos/aodn/aodn-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/aodn-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/aodn-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/aodn/aodn-portal/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/aodn-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/aodn-portal/merges","archive_url":"https://api.github.com/repos/aodn/aodn-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/aodn-portal/downloads","issues_url":"https://api.github.com/repos/aodn/aodn-portal/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/aodn-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/aodn-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/aodn-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/aodn-portal/labels{/name}","releases_url":"https://api.github.com/repos/aodn/aodn-portal/releases{/id}","created_at":"2012-11-22T01:42:50Z","updated_at":"2014-06-30T00:59:44Z","pushed_at":"2014-07-29T00:01:36Z","git_url":"git://github.com/aodn/aodn-portal.git","ssh_url":"git@github.com:aodn/aodn-portal.git","clone_url":"https://github.com/aodn/aodn-portal.git","svn_url":"https://github.com/aodn/aodn-portal","homepage":"","size":74162,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":109,"forks":8,"open_issues":109,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1323"},"html":{"href":"https://github.com/aodn/aodn-portal/pull/1323"},"issue":{"href":"https://api.github.com/repos/aodn/aodn-portal/issues/1323"},"comments":{"href":"https://api.github.com/repos/aodn/aodn-portal/issues/1323/comments"},"review_comments":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1323/comments"},"review_comment":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1323/commits"},"statuses":{"href":"https://api.github.com/repos/aodn/aodn-portal/statuses/f2c1031aef3867268740886fefd8550689e56649"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pmbohm","id":1066981,"avatar_url":"https://avatars.githubusercontent.com/u/1066981?","gravatar_id":"3e57eccdcd74e15ce1b7f0b28c2e3865","url":"https://api.github.com/users/pmbohm","html_url":"https://github.com/pmbohm","followers_url":"https://api.github.com/users/pmbohm/followers","following_url":"https://api.github.com/users/pmbohm/following{/other_user}","gists_url":"https://api.github.com/users/pmbohm/gists{/gist_id}","starred_url":"https://api.github.com/users/pmbohm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmbohm/subscriptions","organizations_url":"https://api.github.com/users/pmbohm/orgs","repos_url":"https://api.github.com/users/pmbohm/repos","events_url":"https://api.github.com/users/pmbohm/events{/privacy}","received_events_url":"https://api.github.com/users/pmbohm/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":8,"deletions":27,"changed_files":3}}