GitHub PullRequestReviewCommentEvent at 2014-01-27 11:10:23
Repository: enstaller
Actor: rkern
Payload: {"comment":{"url":"https://api.github.com/repos/enthought/enstaller/pulls/comments/9185470","id":9185470,"diff_hunk":"@@ -11,22 +11,29 @@\n import sys\n import re\n import json\n+import shutil\n import warnings\n import zipfile\n from uuid import uuid4\n from os.path import abspath, basename, dirname, join, isdir, isfile, sep\n \n-from utils import (on_win, bin_dir_name, rel_site_packages, human_bytes,\n-                   rm_empty_dir, rm_rf, get_executable, makedirs, is_zipinfo_symlink)\n+import eggmeta\n import scripts\n \n-from .eggmeta import APPINST_PATH\n-\n+from utils import (on_win, bin_dir_name, rel_site_packages, human_bytes, ensure_dir,\n+                   rm_empty_dir, rm_rf, get_executable, makedirs, is_zipinfo_symlink)\n \n NS_PKG_PAT = re.compile(\n     r'\\s*__import__\\([\\'\"]pkg_resources[\\'\"]\\)\\.declare_namespace'\n     r'\\(__name__\\)\\s*$')\n \n+EGG_INFO = \"EGG-INFO\"\n+\n+R_EGG_INFO = re.compile(\"^{0}\".format(EGG_INFO))\n+R_EGG_INFO_BLACK_LIST = re.compile(\n+        \"^{0}/(usr|spec|PKG-INFO.bak|prefix|.gitignore|\"\n+        \"inst|scripts|post_egginst.py|pre_egguninst.py)\".format(EGG_INFO))","path":"egginst/main.py","position":29,"original_position":29,"commit_id":"43aebbc1e7dd65fb43ce3021589f532a709c5fd1","original_commit_id":"43aebbc1e7dd65fb43ce3021589f532a709c5fd1","user":{"login":"rkern","id":46135,"avatar_url":"https://gravatar.com/avatar/764323a14e554c97ab74177e0bce51d4?d=https%3A%2F%2Fidenticons.github.com%2Fc91d5eb1b3f05dc2e98aab23a7945181.png&r=x","gravatar_id":"764323a14e554c97ab74177e0bce51d4","url":"https://api.github.com/users/rkern","html_url":"https://github.com/rkern","followers_url":"https://api.github.com/users/rkern/followers","following_url":"https://api.github.com/users/rkern/following{/other_user}","gists_url":"https://api.github.com/users/rkern/gists{/gist_id}","starred_url":"https://api.github.com/users/rkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkern/subscriptions","organizations_url":"https://api.github.com/users/rkern/orgs","repos_url":"https://api.github.com/users/rkern/repos","events_url":"https://api.github.com/users/rkern/events{/privacy}","received_events_url":"https://api.github.com/users/rkern/received_events","type":"User","site_admin":false},"body":"`scripts` should not be blacklisted. It's a standard setuptools feature.","created_at":"2014-01-27T11:10:23Z","updated_at":"2014-01-27T11:10:23Z","html_url":"https://github.com/enthought/enstaller/pull/136#discussion_r9185470","pull_request_url":"https://api.github.com/repos/enthought/enstaller/pulls/136","_links":{"self":{"href":"https://api.github.com/repos/enthought/enstaller/pulls/comments/9185470"},"html":{"href":"https://github.com/enthought/enstaller/pull/136#discussion_r9185470"},"pull_request":{"href":"https://api.github.com/repos/enthought/enstaller/pulls/136"}}}}