GitHub PullRequestReviewCommentEvent at 2014-11-09 00:40:52
Repository: opensim-core
Actor: sherm1
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/20055708","id":20055708,"diff_hunk":"@@ -31,12 +31,14 @@ namespace OpenSim {\n //=============================================================================\n //=============================================================================\n /**\n- * A class implementing an Gimbal joint.  The underlying implementation \n- * in Simbody is a MobilizedBody::Gimbal.\n- *\n- * @author Tim Dorn\n- * @author Ajay Seth\n- */\n+A class implementing a Gimbal joint. The underlying implementation is a Simbody\n+<a href=\"https://simtk.org/api_docs/simbody/api_docs/Simbody/html/classSimTK_1_1MobilizedBody_1_1Gimbal.html#details\">Mobilized::Gimbal</a>. The opensim Gimbal joint implementation uses a fixed 1-2-3 body fixed Euler sequence for generalized coordinates calcualtion. Gimbal joints have a singularity when Y is near \\f$\\frac{\\pi}{2}\\f$. Generalized speeds are equal to the Eular angle derivatives  (\\f$\\vec{u} = \\dot{\\vec{q}}\\f$)","path":"OpenSim/Simulation/SimbodyEngine/GimbalJoint.h","position":11,"original_position":11,"commit_id":"f0ff04e4a7547315cc4713d55aa81b40e94799d6","original_commit_id":"f0ff04e4a7547315cc4713d55aa81b40e94799d6","user":{"login":"sherm1","id":4088016,"avatar_url":"https://avatars.githubusercontent.com/u/4088016?v=3","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},"body":"The clickable tag should be `MobilizedBody::Gimbal` rather than `Mobilized::Gimbal`","created_at":"2014-11-09T00:40:52Z","updated_at":"2014-11-09T00:40:52Z","html_url":"https://github.com/opensim-org/opensim-core/pull/241#discussion_r20055708","pull_request_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/241","_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/20055708"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/241#discussion_r20055708"},"pull_request":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/241","id":24104790,"html_url":"https://github.com/opensim-org/opensim-core/pull/241","diff_url":"https://github.com/opensim-org/opensim-core/pull/241.diff","patch_url":"https://github.com/opensim-org/opensim-core/pull/241.patch","issue_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/241","number":241,"state":"open","locked":false,"title":"Doxygen joint class edits, adding Gifs","user":{"login":"jimmyDunne","id":5296507,"avatar_url":"https://avatars.githubusercontent.com/u/5296507?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmyDunne","html_url":"https://github.com/jimmyDunne","followers_url":"https://api.github.com/users/jimmyDunne/followers","following_url":"https://api.github.com/users/jimmyDunne/following{/other_user}","gists_url":"https://api.github.com/users/jimmyDunne/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmyDunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmyDunne/subscriptions","organizations_url":"https://api.github.com/users/jimmyDunne/orgs","repos_url":"https://api.github.com/users/jimmyDunne/repos","events_url":"https://api.github.com/users/jimmyDunne/events{/privacy}","received_events_url":"https://api.github.com/users/jimmyDunne/received_events","type":"User","site_admin":false},"body":"Added gifs and edited the opensim joint descriptions. ","created_at":"2014-11-08T18:58:25Z","updated_at":"2014-11-09T00:40:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec55113a67609ca6ce34a3637e9f21c766bb225d","assignee":null,"milestone":{"url":"https://api.github.com/repos/opensim-org/opensim-core/milestones/1","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones/1/labels","id":725618,"number":1,"title":"OpenSim 4.0","description":"","creator":{"login":"jenhicks","id":4510959,"avatar_url":"https://avatars.githubusercontent.com/u/4510959?v=3","gravatar_id":"","url":"https://api.github.com/users/jenhicks","html_url":"https://github.com/jenhicks","followers_url":"https://api.github.com/users/jenhicks/followers","following_url":"https://api.github.com/users/jenhicks/following{/other_user}","gists_url":"https://api.github.com/users/jenhicks/gists{/gist_id}","starred_url":"https://api.github.com/users/jenhicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenhicks/subscriptions","organizations_url":"https://api.github.com/users/jenhicks/orgs","repos_url":"https://api.github.com/users/jenhicks/repos","events_url":"https://api.github.com/users/jenhicks/events{/privacy}","received_events_url":"https://api.github.com/users/jenhicks/received_events","type":"User","site_admin":false},"open_issues":60,"closed_issues":120,"state":"open","created_at":"2014-07-18T21:08:06Z","updated_at":"2014-11-08T18:58:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/241/commits","review_comments_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/241/comments","review_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/241/comments","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/f0ff04e4a7547315cc4713d55aa81b40e94799d6","head":{"label":"opensim-org:joint_upgraded_documentation","ref":"joint_upgraded_documentation","sha":"f0ff04e4a7547315cc4713d55aa81b40e94799d6","user":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=3","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"name":"opensim-core","full_name":"opensim-org/opensim-core","owner":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=3","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim C++ libraries and comand-line applications and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","created_at":"2014-06-12T16:57:56Z","updated_at":"2014-10-20T01:00:48Z","pushed_at":"2014-11-09T00:06:43Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"git@github.com:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"opensim.stanford.edu","size":113094,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":96,"forks":4,"open_issues":96,"watchers":6,"default_branch":"master"}},"base":{"label":"opensim-org:master","ref":"master","sha":"95921ef014df9a72e17d68ddebcd9b38c6d29b78","user":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=3","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"name":"opensim-core","full_name":"opensim-org/opensim-core","owner":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=3","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim C++ libraries and comand-line applications and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","created_at":"2014-06-12T16:57:56Z","updated_at":"2014-10-20T01:00:48Z","pushed_at":"2014-11-09T00:06:43Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"git@github.com:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"opensim.stanford.edu","size":113094,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":96,"forks":4,"open_issues":96,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/241"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/241"},"issue":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/241"},"comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/opensim-org/opensim-core/statuses/f0ff04e4a7547315cc4713d55aa81b40e94799d6"}}}}