GitHub PullRequestReviewCommentEvent at 2014-02-14 19:13:26
Repository: underscore
Actor: davidchambers
Payload: {"comment":{"url":"https://api.github.com/repos/jashkenas/underscore/pulls/comments/9759891","id":9759891,"diff_hunk":"@@ -1135,7 +1135,7 @@\n   };\n \n   // A (possibly faster) way to get the current timestamp as an integer.\n-  _.now = Date.now || function() { return new Date().getTime(); };\n+  _.now = function () { return Date.now(); } || function() { return new Date().getTime(); };","path":"underscore.js","position":5,"original_position":5,"commit_id":"e33cfd1d7cbc4f241da1b8a1537af513d2569811","original_commit_id":"e33cfd1d7cbc4f241da1b8a1537af513d2569811","user":{"login":"davidchambers","id":210406,"avatar_url":"https://gravatar.com/avatar/5f41fa18e9774f1a2ea7c519f476c348?d=https%3A%2F%2Fidenticons.github.com%2F08279130e2d6c07bdb62ed95f3ebfadb.png&r=x","gravatar_id":"5f41fa18e9774f1a2ea7c519f476c348","url":"https://api.github.com/users/davidchambers","html_url":"https://github.com/davidchambers","followers_url":"https://api.github.com/users/davidchambers/followers","following_url":"https://api.github.com/users/davidchambers/following{/other_user}","gists_url":"https://api.github.com/users/davidchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchambers/subscriptions","organizations_url":"https://api.github.com/users/davidchambers/orgs","repos_url":"https://api.github.com/users/davidchambers/repos","events_url":"https://api.github.com/users/davidchambers/events{/privacy}","received_events_url":"https://api.github.com/users/davidchambers/received_events","type":"User","site_admin":false},"body":"This isn't quite right, since the LHS `||` operand will now always evaluate true. We'd lose the feature detection, in other words. We'd need something like this, instead:\r\n\r\n```javascript\r\n_.now = Date.now ? function() { return Date.now(); } :\r\n                   function() { return new Date().getTime(); };\r\n```\r\n","created_at":"2014-02-14T19:13:26Z","updated_at":"2014-02-14T19:13:26Z","html_url":"https://github.com/jashkenas/underscore/pull/1478#discussion_r9759891","pull_request_url":"https://api.github.com/repos/jashkenas/underscore/pulls/1478","_links":{"self":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/comments/9759891"},"html":{"href":"https://github.com/jashkenas/underscore/pull/1478#discussion_r9759891"},"pull_request":{"href":"https://api.github.com/repos/jashkenas/underscore/pulls/1478"}}}}