GitHub PullRequestReviewCommentEvent at 2014-08-17 20:05:21
Repository: HAL
Actor: nimski
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/arpg/HAL/pulls/comments/16331769","id":16331769,"diff_hunk":"@@ -232,15 +233,23 @@ void ExtractLog() {\n \n   pb::Logger logger;\n   logger.LogToFile(FLAGS_out);\n+  const uint32_t max_buffer_size = 5000; // This is the default in logger.\n+  logger.SetMaxBufferSize(max_buffer_size);\n   while ((frame_max == kNoRange ||\n           idx <= frame_max) &&\n          (msg = reader.ReadMessage())) {\n     if (msg->has_camera()) {\n-      if (!logger.LogMessage(*msg)) {\n-        break;\n-      }\n       ++idx;\n     }\n+\n+    if (logger.buffer_size() == max_buffer_size) {","path":"Applications/logtool/logtool.cpp","position":null,"original_position":24,"commit_id":"0fe89ca2889c70550e6071c13991a85ae31bde47","original_commit_id":"9584c4f4d6833dd3d90b70558ca1ccc1b900c01c","user":{"login":"nimski","id":354810,"avatar_url":"https://avatars.githubusercontent.com/u/354810?v=2","gravatar_id":"6c49f3d8dd4d22f719862cbfdee0d400","url":"https://api.github.com/users/nimski","html_url":"https://github.com/nimski","followers_url":"https://api.github.com/users/nimski/followers","following_url":"https://api.github.com/users/nimski/following{/other_user}","gists_url":"https://api.github.com/users/nimski/gists{/gist_id}","starred_url":"https://api.github.com/users/nimski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimski/subscriptions","organizations_url":"https://api.github.com/users/nimski/orgs","repos_url":"https://api.github.com/users/nimski/repos","events_url":"https://api.github.com/users/nimski/events{/privacy}","received_events_url":"https://api.github.com/users/nimski/received_events","type":"User","site_admin":false},"body":"Good suggestion.","created_at":"2014-08-17T20:05:21Z","updated_at":"2014-08-17T20:05:21Z","html_url":"https://github.com/arpg/HAL/pull/27#discussion_r16331769","pull_request_url":"https://api.github.com/repos/arpg/HAL/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/arpg/HAL/pulls/comments/16331769"},"html":{"href":"https://github.com/arpg/HAL/pull/27#discussion_r16331769"},"pull_request":{"href":"https://api.github.com/repos/arpg/HAL/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/arpg/HAL/pulls/27","id":19873445,"html_url":"https://github.com/arpg/HAL/pull/27","diff_url":"https://github.com/arpg/HAL/pull/27.diff","patch_url":"https://github.com/arpg/HAL/pull/27.patch","issue_url":"https://api.github.com/repos/arpg/HAL/issues/27","number":27,"state":"open","locked":false,"title":"Fix/logtool msg types","user":{"login":"nimski","id":354810,"avatar_url":"https://avatars.githubusercontent.com/u/354810?v=2","gravatar_id":"6c49f3d8dd4d22f719862cbfdee0d400","url":"https://api.github.com/users/nimski","html_url":"https://github.com/nimski","followers_url":"https://api.github.com/users/nimski/followers","following_url":"https://api.github.com/users/nimski/following{/other_user}","gists_url":"https://api.github.com/users/nimski/gists{/gist_id}","starred_url":"https://api.github.com/users/nimski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimski/subscriptions","organizations_url":"https://api.github.com/users/nimski/orgs","repos_url":"https://api.github.com/users/nimski/repos","events_url":"https://api.github.com/users/nimski/events{/privacy}","received_events_url":"https://api.github.com/users/nimski/received_events","type":"User","site_admin":false},"body":"Adds some printouts to sensorviewer for encoder and posys messages.\r\nLogtool can now handle all message types, not just camera. In this case, the logger message buffer can fill up if the write doesn't happen fast enough. This is now handled.","created_at":"2014-08-15T23:43:03Z","updated_at":"2014-08-17T20:05:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4e1538de0e551e80dbcb50f47cadaf5cc303c0d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/arpg/HAL/pulls/27/commits","review_comments_url":"https://api.github.com/repos/arpg/HAL/pulls/27/comments","review_comment_url":"https://api.github.com/repos/arpg/HAL/pulls/comments/{number}","comments_url":"https://api.github.com/repos/arpg/HAL/issues/27/comments","statuses_url":"https://api.github.com/repos/arpg/HAL/statuses/0fe89ca2889c70550e6071c13991a85ae31bde47","head":{"label":"arpg:fix/logtool-msg-types","ref":"fix/logtool-msg-types","sha":"0fe89ca2889c70550e6071c13991a85ae31bde47","user":{"login":"arpg","id":5082551,"avatar_url":"https://avatars.githubusercontent.com/u/5082551?v=2","gravatar_id":"0026c76d96b8175f58d2af2492978367","url":"https://api.github.com/users/arpg","html_url":"https://github.com/arpg","followers_url":"https://api.github.com/users/arpg/followers","following_url":"https://api.github.com/users/arpg/following{/other_user}","gists_url":"https://api.github.com/users/arpg/gists{/gist_id}","starred_url":"https://api.github.com/users/arpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arpg/subscriptions","organizations_url":"https://api.github.com/users/arpg/orgs","repos_url":"https://api.github.com/users/arpg/repos","events_url":"https://api.github.com/users/arpg/events{/privacy}","received_events_url":"https://api.github.com/users/arpg/received_events","type":"Organization","site_admin":false},"repo":{"id":11642578,"name":"HAL","full_name":"arpg/HAL","owner":{"login":"arpg","id":5082551,"avatar_url":"https://avatars.githubusercontent.com/u/5082551?v=2","gravatar_id":"0026c76d96b8175f58d2af2492978367","url":"https://api.github.com/users/arpg","html_url":"https://github.com/arpg","followers_url":"https://api.github.com/users/arpg/followers","following_url":"https://api.github.com/users/arpg/following{/other_user}","gists_url":"https://api.github.com/users/arpg/gists{/gist_id}","starred_url":"https://api.github.com/users/arpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arpg/subscriptions","organizations_url":"https://api.github.com/users/arpg/orgs","repos_url":"https://api.github.com/users/arpg/repos","events_url":"https://api.github.com/users/arpg/events{/privacy}","received_events_url":"https://api.github.com/users/arpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arpg/HAL","description":"Hardware Abstraction Layer library.","fork":false,"url":"https://api.github.com/repos/arpg/HAL","forks_url":"https://api.github.com/repos/arpg/HAL/forks","keys_url":"https://api.github.com/repos/arpg/HAL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arpg/HAL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arpg/HAL/teams","hooks_url":"https://api.github.com/repos/arpg/HAL/hooks","issue_events_url":"https://api.github.com/repos/arpg/HAL/issues/events{/number}","events_url":"https://api.github.com/repos/arpg/HAL/events","assignees_url":"https://api.github.com/repos/arpg/HAL/assignees{/user}","branches_url":"https://api.github.com/repos/arpg/HAL/branches{/branch}","tags_url":"https://api.github.com/repos/arpg/HAL/tags","blobs_url":"https://api.github.com/repos/arpg/HAL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arpg/HAL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arpg/HAL/git/refs{/sha}","trees_url":"https://api.github.com/repos/arpg/HAL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arpg/HAL/statuses/{sha}","languages_url":"https://api.github.com/repos/arpg/HAL/languages","stargazers_url":"https://api.github.com/repos/arpg/HAL/stargazers","contributors_url":"https://api.github.com/repos/arpg/HAL/contributors","subscribers_url":"https://api.github.com/repos/arpg/HAL/subscribers","subscription_url":"https://api.github.com/repos/arpg/HAL/subscription","commits_url":"https://api.github.com/repos/arpg/HAL/commits{/sha}","git_commits_url":"https://api.github.com/repos/arpg/HAL/git/commits{/sha}","comments_url":"https://api.github.com/repos/arpg/HAL/comments{/number}","issue_comment_url":"https://api.github.com/repos/arpg/HAL/issues/comments/{number}","contents_url":"https://api.github.com/repos/arpg/HAL/contents/{+path}","compare_url":"https://api.github.com/repos/arpg/HAL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arpg/HAL/merges","archive_url":"https://api.github.com/repos/arpg/HAL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arpg/HAL/downloads","issues_url":"https://api.github.com/repos/arpg/HAL/issues{/number}","pulls_url":"https://api.github.com/repos/arpg/HAL/pulls{/number}","milestones_url":"https://api.github.com/repos/arpg/HAL/milestones{/number}","notifications_url":"https://api.github.com/repos/arpg/HAL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arpg/HAL/labels{/name}","releases_url":"https://api.github.com/repos/arpg/HAL/releases{/id}","created_at":"2013-07-24T18:53:43Z","updated_at":"2014-07-01T00:04:54Z","pushed_at":"2014-08-17T20:04:50Z","git_url":"git://github.com/arpg/HAL.git","ssh_url":"git@github.com:arpg/HAL.git","clone_url":"https://github.com/arpg/HAL.git","svn_url":"https://github.com/arpg/HAL","homepage":null,"size":40509,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"arpg:master","ref":"master","sha":"388b04965c89b57369975c2b090e8e05f37c4526","user":{"login":"arpg","id":5082551,"avatar_url":"https://avatars.githubusercontent.com/u/5082551?v=2","gravatar_id":"0026c76d96b8175f58d2af2492978367","url":"https://api.github.com/users/arpg","html_url":"https://github.com/arpg","followers_url":"https://api.github.com/users/arpg/followers","following_url":"https://api.github.com/users/arpg/following{/other_user}","gists_url":"https://api.github.com/users/arpg/gists{/gist_id}","starred_url":"https://api.github.com/users/arpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arpg/subscriptions","organizations_url":"https://api.github.com/users/arpg/orgs","repos_url":"https://api.github.com/users/arpg/repos","events_url":"https://api.github.com/users/arpg/events{/privacy}","received_events_url":"https://api.github.com/users/arpg/received_events","type":"Organization","site_admin":false},"repo":{"id":11642578,"name":"HAL","full_name":"arpg/HAL","owner":{"login":"arpg","id":5082551,"avatar_url":"https://avatars.githubusercontent.com/u/5082551?v=2","gravatar_id":"0026c76d96b8175f58d2af2492978367","url":"https://api.github.com/users/arpg","html_url":"https://github.com/arpg","followers_url":"https://api.github.com/users/arpg/followers","following_url":"https://api.github.com/users/arpg/following{/other_user}","gists_url":"https://api.github.com/users/arpg/gists{/gist_id}","starred_url":"https://api.github.com/users/arpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arpg/subscriptions","organizations_url":"https://api.github.com/users/arpg/orgs","repos_url":"https://api.github.com/users/arpg/repos","events_url":"https://api.github.com/users/arpg/events{/privacy}","received_events_url":"https://api.github.com/users/arpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arpg/HAL","description":"Hardware Abstraction Layer library.","fork":false,"url":"https://api.github.com/repos/arpg/HAL","forks_url":"https://api.github.com/repos/arpg/HAL/forks","keys_url":"https://api.github.com/repos/arpg/HAL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arpg/HAL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arpg/HAL/teams","hooks_url":"https://api.github.com/repos/arpg/HAL/hooks","issue_events_url":"https://api.github.com/repos/arpg/HAL/issues/events{/number}","events_url":"https://api.github.com/repos/arpg/HAL/events","assignees_url":"https://api.github.com/repos/arpg/HAL/assignees{/user}","branches_url":"https://api.github.com/repos/arpg/HAL/branches{/branch}","tags_url":"https://api.github.com/repos/arpg/HAL/tags","blobs_url":"https://api.github.com/repos/arpg/HAL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arpg/HAL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arpg/HAL/git/refs{/sha}","trees_url":"https://api.github.com/repos/arpg/HAL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arpg/HAL/statuses/{sha}","languages_url":"https://api.github.com/repos/arpg/HAL/languages","stargazers_url":"https://api.github.com/repos/arpg/HAL/stargazers","contributors_url":"https://api.github.com/repos/arpg/HAL/contributors","subscribers_url":"https://api.github.com/repos/arpg/HAL/subscribers","subscription_url":"https://api.github.com/repos/arpg/HAL/subscription","commits_url":"https://api.github.com/repos/arpg/HAL/commits{/sha}","git_commits_url":"https://api.github.com/repos/arpg/HAL/git/commits{/sha}","comments_url":"https://api.github.com/repos/arpg/HAL/comments{/number}","issue_comment_url":"https://api.github.com/repos/arpg/HAL/issues/comments/{number}","contents_url":"https://api.github.com/repos/arpg/HAL/contents/{+path}","compare_url":"https://api.github.com/repos/arpg/HAL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arpg/HAL/merges","archive_url":"https://api.github.com/repos/arpg/HAL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arpg/HAL/downloads","issues_url":"https://api.github.com/repos/arpg/HAL/issues{/number}","pulls_url":"https://api.github.com/repos/arpg/HAL/pulls{/number}","milestones_url":"https://api.github.com/repos/arpg/HAL/milestones{/number}","notifications_url":"https://api.github.com/repos/arpg/HAL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arpg/HAL/labels{/name}","releases_url":"https://api.github.com/repos/arpg/HAL/releases{/id}","created_at":"2013-07-24T18:53:43Z","updated_at":"2014-07-01T00:04:54Z","pushed_at":"2014-08-17T20:04:50Z","git_url":"git://github.com/arpg/HAL.git","ssh_url":"git@github.com:arpg/HAL.git","clone_url":"https://github.com/arpg/HAL.git","svn_url":"https://github.com/arpg/HAL","homepage":null,"size":40509,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arpg/HAL/pulls/27"},"html":{"href":"https://github.com/arpg/HAL/pull/27"},"issue":{"href":"https://api.github.com/repos/arpg/HAL/issues/27"},"comments":{"href":"https://api.github.com/repos/arpg/HAL/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/arpg/HAL/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/arpg/HAL/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/arpg/HAL/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/arpg/HAL/statuses/0fe89ca2889c70550e6071c13991a85ae31bde47"}}}}