GitHub PullRequestReviewCommentEvent at 2014-01-23 10:11:31
Repository: rust-sdl2
Actor: AngryLawyer
Payload: {"comment":{"url":"https://api.github.com/repos/AngryLawyer/rust-sdl2/pulls/comments/9107741","id":9107741,"diff_hunk":"@@ -685,8 +685,10 @@ fn wrap_event(raw: ll::SDL_Event) -> Event {\n                     Ok(window) => window,\n                 };\n \n-                let text = str::from_utf8_owned(event.text.iter().take_while(|b| (**b) != 0i8).map(|b| b.to_u8().unwrap()).collect::<~[u8]>());\n-\n+                let text = match str::from_utf8_owned(event.text.iter().take_while(|b| (**b) != 0i8).map(|b| b.to_u8().unwrap()).collect::<~[u8]>()) {\n+                    Some(t) => t,\n+                    None => ~\"\"","path":"src/sdl2/event.rs","position":8,"original_position":8,"commit_id":"2672ba14f6d91529cf7c461116c6ebe2d570719f","original_commit_id":"2672ba14f6d91529cf7c461116c6ebe2d570719f","user":{"login":"AngryLawyer","id":1378607,"avatar_url":"https://gravatar.com/avatar/cc77841a4f1d20b643b5e31c97b0005e?d=https%3A%2F%2Fidenticons.github.com%2Fd70d9753d3c0da0a29b6335b9923bf80.png&r=x","gravatar_id":"cc77841a4f1d20b643b5e31c97b0005e","url":"https://api.github.com/users/AngryLawyer","html_url":"https://github.com/AngryLawyer","followers_url":"https://api.github.com/users/AngryLawyer/followers","following_url":"https://api.github.com/users/AngryLawyer/following{/other_user}","gists_url":"https://api.github.com/users/AngryLawyer/gists{/gist_id}","starred_url":"https://api.github.com/users/AngryLawyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngryLawyer/subscriptions","organizations_url":"https://api.github.com/users/AngryLawyer/orgs","repos_url":"https://api.github.com/users/AngryLawyer/repos","events_url":"https://api.github.com/users/AngryLawyer/events{/privacy}","received_events_url":"https://api.github.com/users/AngryLawyer/received_events","type":"User","site_admin":false},"body":"We could return NoEvent, but that seems odd. Or change the signature of TextInputEvent to have an option type in the text slot, but that might be a pain in the bum.\r\n\r\nYour call, I'm happy with it staying too.","created_at":"2014-01-23T10:11:31Z","updated_at":"2014-01-23T10:11:31Z","html_url":"https://github.com/AngryLawyer/rust-sdl2/pull/40#discussion_r9107741","pull_request_url":"https://api.github.com/repos/AngryLawyer/rust-sdl2/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/AngryLawyer/rust-sdl2/pulls/comments/9107741"},"html":{"href":"https://github.com/AngryLawyer/rust-sdl2/pull/40#discussion_r9107741"},"pull_request":{"href":"https://api.github.com/repos/AngryLawyer/rust-sdl2/pulls/40"}}}}