GitHub PullRequestEvent at 2014-08-04 04:04:50
Repository: SublimeLinter-html-tidy
Actor: Remos
Payload: {"action":"opened","number":16,"pull_request":{"url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/pulls/16","id":19264317,"html_url":"https://github.com/SublimeLinter/SublimeLinter-html-tidy/pull/16","diff_url":"https://github.com/SublimeLinter/SublimeLinter-html-tidy/pull/16.diff","patch_url":"https://github.com/SublimeLinter/SublimeLinter-html-tidy/pull/16.patch","issue_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/issues/16","number":16,"state":"open","title":"Added tab_width to linter.py","user":{"login":"Remos","id":2154617,"avatar_url":"https://avatars.githubusercontent.com/u/2154617?v=1","gravatar_id":"e2d8d576a3bb44cef2d4e071a0c2f9e3","url":"https://api.github.com/users/Remos","html_url":"https://github.com/Remos","followers_url":"https://api.github.com/users/Remos/followers","following_url":"https://api.github.com/users/Remos/following{/other_user}","gists_url":"https://api.github.com/users/Remos/gists{/gist_id}","starred_url":"https://api.github.com/users/Remos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remos/subscriptions","organizations_url":"https://api.github.com/users/Remos/orgs","repos_url":"https://api.github.com/users/Remos/repos","events_url":"https://api.github.com/users/Remos/events{/privacy}","received_events_url":"https://api.github.com/users/Remos/received_events","type":"User","site_admin":false},"body":"I think tab_width should be specified as the default for more linters.\r\nIs there a reason tab_width isn't specified more often?\r\n\r\nConsidering that SublimeLinter already parses the reported visual column number to a character column number, it makes sense to me to set the tab_width to the default of the linter itself.\r\nThis way, regardless of a person's tab settings the regions should be in the same position. (Only if they change the linter's tab_size setting would it misalign)\r\n\r\nHere's an example of it without tab_width where the regions should only be marking the '<'s:\r\n![Example of mis-aligned regions](http://i.imgur.com/OZxy7rb.png)\r\n\r\nAfter setting tab_width it works fine.","created_at":"2014-08-04T04:04:49Z","updated_at":"2014-08-04T04:04:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/pulls/16/commits","review_comments_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/pulls/16/comments","review_comment_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/issues/16/comments","statuses_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/statuses/ffd6dc60074e65539186843a54ff8a72530c2104","head":{"label":"Remos:master","ref":"master","sha":"ffd6dc60074e65539186843a54ff8a72530c2104","user":{"login":"Remos","id":2154617,"avatar_url":"https://avatars.githubusercontent.com/u/2154617?v=1","gravatar_id":"e2d8d576a3bb44cef2d4e071a0c2f9e3","url":"https://api.github.com/users/Remos","html_url":"https://github.com/Remos","followers_url":"https://api.github.com/users/Remos/followers","following_url":"https://api.github.com/users/Remos/following{/other_user}","gists_url":"https://api.github.com/users/Remos/gists{/gist_id}","starred_url":"https://api.github.com/users/Remos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remos/subscriptions","organizations_url":"https://api.github.com/users/Remos/orgs","repos_url":"https://api.github.com/users/Remos/repos","events_url":"https://api.github.com/users/Remos/events{/privacy}","received_events_url":"https://api.github.com/users/Remos/received_events","type":"User","site_admin":false},"repo":{"id":22590471,"name":"SublimeLinter-html-tidy","full_name":"Remos/SublimeLinter-html-tidy","owner":{"login":"Remos","id":2154617,"avatar_url":"https://avatars.githubusercontent.com/u/2154617?v=1","gravatar_id":"e2d8d576a3bb44cef2d4e071a0c2f9e3","url":"https://api.github.com/users/Remos","html_url":"https://github.com/Remos","followers_url":"https://api.github.com/users/Remos/followers","following_url":"https://api.github.com/users/Remos/following{/other_user}","gists_url":"https://api.github.com/users/Remos/gists{/gist_id}","starred_url":"https://api.github.com/users/Remos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remos/subscriptions","organizations_url":"https://api.github.com/users/Remos/orgs","repos_url":"https://api.github.com/users/Remos/repos","events_url":"https://api.github.com/users/Remos/events{/privacy}","received_events_url":"https://api.github.com/users/Remos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Remos/SublimeLinter-html-tidy","description":"SublimeLinter 3 plugin for html tidy.","fork":true,"url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy","forks_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/forks","keys_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/teams","hooks_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/hooks","issue_events_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/issues/events{/number}","events_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/events","assignees_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/assignees{/user}","branches_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/branches{/branch}","tags_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/tags","blobs_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/statuses/{sha}","languages_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/languages","stargazers_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/stargazers","contributors_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/contributors","subscribers_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/subscribers","subscription_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/subscription","commits_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/issues/comments/{number}","contents_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/contents/{+path}","compare_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/merges","archive_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/downloads","issues_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/issues{/number}","pulls_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/pulls{/number}","milestones_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/milestones{/number}","notifications_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/labels{/name}","releases_url":"https://api.github.com/repos/Remos/SublimeLinter-html-tidy/releases{/id}","created_at":"2014-08-04T03:11:19Z","updated_at":"2014-08-04T03:28:06Z","pushed_at":"2014-08-04T03:28:06Z","git_url":"git://github.com/Remos/SublimeLinter-html-tidy.git","ssh_url":"git@github.com:Remos/SublimeLinter-html-tidy.git","clone_url":"https://github.com/Remos/SublimeLinter-html-tidy.git","svn_url":"https://github.com/Remos/SublimeLinter-html-tidy","homepage":null,"size":334,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SublimeLinter:master","ref":"master","sha":"d7c71070f0cdf903117122f9dc0ad050c92e7099","user":{"login":"SublimeLinter","id":1755200,"avatar_url":"https://avatars.githubusercontent.com/u/1755200?v=1","gravatar_id":"ff7e9a0a41196f42a8695234d1976c8b","url":"https://api.github.com/users/SublimeLinter","html_url":"https://github.com/SublimeLinter","followers_url":"https://api.github.com/users/SublimeLinter/followers","following_url":"https://api.github.com/users/SublimeLinter/following{/other_user}","gists_url":"https://api.github.com/users/SublimeLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/SublimeLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SublimeLinter/subscriptions","organizations_url":"https://api.github.com/users/SublimeLinter/orgs","repos_url":"https://api.github.com/users/SublimeLinter/repos","events_url":"https://api.github.com/users/SublimeLinter/events{/privacy}","received_events_url":"https://api.github.com/users/SublimeLinter/received_events","type":"Organization","site_admin":false},"repo":{"id":15224686,"name":"SublimeLinter-html-tidy","full_name":"SublimeLinter/SublimeLinter-html-tidy","owner":{"login":"SublimeLinter","id":1755200,"avatar_url":"https://avatars.githubusercontent.com/u/1755200?v=1","gravatar_id":"ff7e9a0a41196f42a8695234d1976c8b","url":"https://api.github.com/users/SublimeLinter","html_url":"https://github.com/SublimeLinter","followers_url":"https://api.github.com/users/SublimeLinter/followers","following_url":"https://api.github.com/users/SublimeLinter/following{/other_user}","gists_url":"https://api.github.com/users/SublimeLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/SublimeLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SublimeLinter/subscriptions","organizations_url":"https://api.github.com/users/SublimeLinter/orgs","repos_url":"https://api.github.com/users/SublimeLinter/repos","events_url":"https://api.github.com/users/SublimeLinter/events{/privacy}","received_events_url":"https://api.github.com/users/SublimeLinter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SublimeLinter/SublimeLinter-html-tidy","description":"SublimeLinter 3 plugin for html tidy.","fork":false,"url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy","forks_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/forks","keys_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/teams","hooks_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/hooks","issue_events_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/issues/events{/number}","events_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/events","assignees_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/assignees{/user}","branches_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/branches{/branch}","tags_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/tags","blobs_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/git/refs{/sha}","trees_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/statuses/{sha}","languages_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/languages","stargazers_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/stargazers","contributors_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/contributors","subscribers_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/subscribers","subscription_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/subscription","commits_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/commits{/sha}","git_commits_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/git/commits{/sha}","comments_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/comments{/number}","issue_comment_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/issues/comments/{number}","contents_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/contents/{+path}","compare_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/merges","archive_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/downloads","issues_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/issues{/number}","pulls_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/pulls{/number}","milestones_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/milestones{/number}","notifications_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/labels{/name}","releases_url":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/releases{/id}","created_at":"2013-12-16T12:00:37Z","updated_at":"2014-07-31T21:43:41Z","pushed_at":"2014-07-31T14:34:25Z","git_url":"git://github.com/SublimeLinter/SublimeLinter-html-tidy.git","ssh_url":"git@github.com:SublimeLinter/SublimeLinter-html-tidy.git","clone_url":"https://github.com/SublimeLinter/SublimeLinter-html-tidy.git","svn_url":"https://github.com/SublimeLinter/SublimeLinter-html-tidy","homepage":null,"size":334,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/pulls/16"},"html":{"href":"https://github.com/SublimeLinter/SublimeLinter-html-tidy/pull/16"},"issue":{"href":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/issues/16"},"comments":{"href":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/SublimeLinter/SublimeLinter-html-tidy/statuses/ffd6dc60074e65539186843a54ff8a72530c2104"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}