GitHub PullRequestReviewCommentEvent at 2014-11-30 05:48:52
Repository: jekyll
Actor: parkr
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/21058324","id":21058324,"diff_hunk":"@@ -63,6 +64,22 @@ def conflicting_urls(site)\n           conflicting_urls\n         end\n \n+        def urls_only_differ_by_case(site)\n+          urls_only_differ_by_case = false\n+          urls = {}\n+          urls = collect_urls_case_insensitive(urls, site.pages, site.dest)\n+          urls = collect_urls_case_insensitive(urls, site.posts, site.dest)\n+          urls.each do |case_insensitive_url, real_urls|\n+            if real_urls.uniq.size > 1\n+              urls_only_differ_by_case = true\n+              Jekyll.logger.warn \"Warning:\", \"The following URLs only differ\" +\n+                \" by case. On a case-insensitive file system one of the URLs\" +\n+                \" will be overwritten by the other: #{real_urls.join(\", \")}\"","path":"lib/jekyll/commands/doctor.rb","position":24,"original_position":24,"commit_id":"98405edf61a02b4a8697a05ec2320c9337d844c2","original_commit_id":"98405edf61a02b4a8697a05ec2320c9337d844c2","user":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":false},"body":"Is there a way to detect whether the current filesystem is case-sensitive and only check if so?","created_at":"2014-11-30T05:48:52Z","updated_at":"2014-11-30T05:48:52Z","html_url":"https://github.com/jekyll/jekyll/pull/3171#discussion_r21058324","pull_request_url":"https://api.github.com/repos/jekyll/jekyll/pulls/3171","_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/21058324"},"html":{"href":"https://github.com/jekyll/jekyll/pull/3171#discussion_r21058324"},"pull_request":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3171"}}},"pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/3171","id":25223363,"html_url":"https://github.com/jekyll/jekyll/pull/3171","diff_url":"https://github.com/jekyll/jekyll/pull/3171.diff","patch_url":"https://github.com/jekyll/jekyll/pull/3171.patch","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/3171","number":3171,"state":"open","locked":false,"title":"Add a Jekyll doctor warning for URLs that only differ by case","user":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars.githubusercontent.com/u/1376924?v=3","gravatar_id":"","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"body":"Those URLs are problematic on case-insensitive file systems because one of the URLs is overwritten by the other. Fixes #3035.\r\n\r\nNote: I can't seem to find tests for doctor, I'm assuming there are none?","created_at":"2014-11-29T14:16:06Z","updated_at":"2014-11-30T05:48:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8fc41a31f5e7952e5e18487acf9a6d8f7e39a5b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jekyll/jekyll/pulls/3171/commits","review_comments_url":"https://api.github.com/repos/jekyll/jekyll/pulls/3171/comments","review_comment_url":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/3171/comments","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/98405edf61a02b4a8697a05ec2320c9337d844c2","head":{"label":"akoeplinger:doctor-permalink-same-case-warning","ref":"doctor-permalink-same-case-warning","sha":"98405edf61a02b4a8697a05ec2320c9337d844c2","user":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars.githubusercontent.com/u/1376924?v=3","gravatar_id":"","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"repo":{"id":27303953,"name":"jekyll","full_name":"akoeplinger/jekyll","owner":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars.githubusercontent.com/u/1376924?v=3","gravatar_id":"","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akoeplinger/jekyll","description":"Jekyll is a blog-aware, static site generator in Ruby","fork":true,"url":"https://api.github.com/repos/akoeplinger/jekyll","forks_url":"https://api.github.com/repos/akoeplinger/jekyll/forks","keys_url":"https://api.github.com/repos/akoeplinger/jekyll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akoeplinger/jekyll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akoeplinger/jekyll/teams","hooks_url":"https://api.github.com/repos/akoeplinger/jekyll/hooks","issue_events_url":"https://api.github.com/repos/akoeplinger/jekyll/issues/events{/number}","events_url":"https://api.github.com/repos/akoeplinger/jekyll/events","assignees_url":"https://api.github.com/repos/akoeplinger/jekyll/assignees{/user}","branches_url":"https://api.github.com/repos/akoeplinger/jekyll/branches{/branch}","tags_url":"https://api.github.com/repos/akoeplinger/jekyll/tags","blobs_url":"https://api.github.com/repos/akoeplinger/jekyll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akoeplinger/jekyll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akoeplinger/jekyll/git/refs{/sha}","trees_url":"https://api.github.com/repos/akoeplinger/jekyll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akoeplinger/jekyll/statuses/{sha}","languages_url":"https://api.github.com/repos/akoeplinger/jekyll/languages","stargazers_url":"https://api.github.com/repos/akoeplinger/jekyll/stargazers","contributors_url":"https://api.github.com/repos/akoeplinger/jekyll/contributors","subscribers_url":"https://api.github.com/repos/akoeplinger/jekyll/subscribers","subscription_url":"https://api.github.com/repos/akoeplinger/jekyll/subscription","commits_url":"https://api.github.com/repos/akoeplinger/jekyll/commits{/sha}","git_commits_url":"https://api.github.com/repos/akoeplinger/jekyll/git/commits{/sha}","comments_url":"https://api.github.com/repos/akoeplinger/jekyll/comments{/number}","issue_comment_url":"https://api.github.com/repos/akoeplinger/jekyll/issues/comments/{number}","contents_url":"https://api.github.com/repos/akoeplinger/jekyll/contents/{+path}","compare_url":"https://api.github.com/repos/akoeplinger/jekyll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akoeplinger/jekyll/merges","archive_url":"https://api.github.com/repos/akoeplinger/jekyll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akoeplinger/jekyll/downloads","issues_url":"https://api.github.com/repos/akoeplinger/jekyll/issues{/number}","pulls_url":"https://api.github.com/repos/akoeplinger/jekyll/pulls{/number}","milestones_url":"https://api.github.com/repos/akoeplinger/jekyll/milestones{/number}","notifications_url":"https://api.github.com/repos/akoeplinger/jekyll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akoeplinger/jekyll/labels{/name}","releases_url":"https://api.github.com/repos/akoeplinger/jekyll/releases{/id}","created_at":"2014-11-29T14:10:41Z","updated_at":"2014-11-29T14:10:44Z","pushed_at":"2014-11-29T14:14:54Z","git_url":"git://github.com/akoeplinger/jekyll.git","ssh_url":"git@github.com:akoeplinger/jekyll.git","clone_url":"https://github.com/akoeplinger/jekyll.git","svn_url":"https://github.com/akoeplinger/jekyll","homepage":"http://jekyllrb.com","size":95225,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jekyll:master","ref":"master","sha":"bfab00a65ad76ff0fb3652724e81c59845a77c43","user":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"repo":{"id":65252,"name":"jekyll","full_name":"jekyll/jekyll","owner":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jekyll/jekyll","description":"Jekyll is a blog-aware, static site generator in Ruby","fork":false,"url":"https://api.github.com/repos/jekyll/jekyll","forks_url":"https://api.github.com/repos/jekyll/jekyll/forks","keys_url":"https://api.github.com/repos/jekyll/jekyll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jekyll/jekyll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jekyll/jekyll/teams","hooks_url":"https://api.github.com/repos/jekyll/jekyll/hooks","issue_events_url":"https://api.github.com/repos/jekyll/jekyll/issues/events{/number}","events_url":"https://api.github.com/repos/jekyll/jekyll/events","assignees_url":"https://api.github.com/repos/jekyll/jekyll/assignees{/user}","branches_url":"https://api.github.com/repos/jekyll/jekyll/branches{/branch}","tags_url":"https://api.github.com/repos/jekyll/jekyll/tags","blobs_url":"https://api.github.com/repos/jekyll/jekyll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jekyll/jekyll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jekyll/jekyll/git/refs{/sha}","trees_url":"https://api.github.com/repos/jekyll/jekyll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/{sha}","languages_url":"https://api.github.com/repos/jekyll/jekyll/languages","stargazers_url":"https://api.github.com/repos/jekyll/jekyll/stargazers","contributors_url":"https://api.github.com/repos/jekyll/jekyll/contributors","subscribers_url":"https://api.github.com/repos/jekyll/jekyll/subscribers","subscription_url":"https://api.github.com/repos/jekyll/jekyll/subscription","commits_url":"https://api.github.com/repos/jekyll/jekyll/commits{/sha}","git_commits_url":"https://api.github.com/repos/jekyll/jekyll/git/commits{/sha}","comments_url":"https://api.github.com/repos/jekyll/jekyll/comments{/number}","issue_comment_url":"https://api.github.com/repos/jekyll/jekyll/issues/comments/{number}","contents_url":"https://api.github.com/repos/jekyll/jekyll/contents/{+path}","compare_url":"https://api.github.com/repos/jekyll/jekyll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jekyll/jekyll/merges","archive_url":"https://api.github.com/repos/jekyll/jekyll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jekyll/jekyll/downloads","issues_url":"https://api.github.com/repos/jekyll/jekyll/issues{/number}","pulls_url":"https://api.github.com/repos/jekyll/jekyll/pulls{/number}","milestones_url":"https://api.github.com/repos/jekyll/jekyll/milestones{/number}","notifications_url":"https://api.github.com/repos/jekyll/jekyll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jekyll/jekyll/labels{/name}","releases_url":"https://api.github.com/repos/jekyll/jekyll/releases{/id}","created_at":"2008-10-20T06:29:03Z","updated_at":"2014-11-30T01:38:48Z","pushed_at":"2014-11-29T10:07:20Z","git_url":"git://github.com/jekyll/jekyll.git","ssh_url":"git@github.com:jekyll/jekyll.git","clone_url":"https://github.com/jekyll/jekyll.git","svn_url":"https://github.com/jekyll/jekyll","homepage":"http://jekyllrb.com","size":95225,"stargazers_count":17518,"watchers_count":17518,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3653,"mirror_url":null,"open_issues_count":81,"forks":3653,"open_issues":81,"watchers":17518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3171"},"html":{"href":"https://github.com/jekyll/jekyll/pull/3171"},"issue":{"href":"https://api.github.com/repos/jekyll/jekyll/issues/3171"},"comments":{"href":"https://api.github.com/repos/jekyll/jekyll/issues/3171/comments"},"review_comments":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3171/comments"},"review_comment":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3171/commits"},"statuses":{"href":"https://api.github.com/repos/jekyll/jekyll/statuses/98405edf61a02b4a8697a05ec2320c9337d844c2"}}}}