GitHub PullRequestReviewCommentEvent at 2014-06-12 20:24:24
Repository: edx-platform
Actor: cahrens
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/13724166","id":13724166,"diff_hunk":"@@ -477,79 +477,60 @@ def test_update_from_json(self):\n         test_model = CourseMetadata.update_from_json(\n             fresh,\n             {\n-                \"advertised_start\": \"start B\",\n-                \"display_name\": \"jolly roger\",\n+                \"advertised_start\": {\"value\": \"start B\"},\n+                \"display_name\": {\"value\": \"jolly roger\"},\n             },\n             user=self.user\n         )\n         self.assertIn('display_name', test_model, 'Missing editable metadata field')\n-        self.assertEqual(test_model['display_name'], 'jolly roger', \"not expected value\")\n+        self.assertEqual(test_model['display_name']['value'], 'jolly roger', \"not expected value\")\n         self.assertIn('advertised_start', test_model, 'Missing revised advertised_start metadata field')\n-        self.assertEqual(test_model['advertised_start'], 'start B', \"advertised_start not expected value\")\n+        self.assertEqual(test_model['advertised_start']['value'], 'start B', \"advertised_start not expected value\")\n \n     def update_check(self, test_model):\n         self.assertIn('display_name', test_model, 'Missing editable metadata field')\n-        self.assertEqual(test_model['display_name'], 'Robot Super Course', \"not expected value\")\n+        self.assertEqual(test_model['display_name']['value'], 'Robot Super Course', \"not expected value\")\n         self.assertIn('advertised_start', test_model, 'Missing new advertised_start metadata field')\n-        self.assertEqual(test_model['advertised_start'], 'start A', \"advertised_start not expected value\")\n+        self.assertEqual(test_model['advertised_start']['value'], 'start A', \"advertised_start not expected value\")\n         self.assertIn('days_early_for_beta', test_model, 'Missing days_early_for_beta metadata field')\n-        self.assertEqual(test_model['days_early_for_beta'], 2, \"days_early_for_beta not expected value\")\n-\n-    def test_delete_key(self):","path":"cms/djangoapps/contentstore/tests/test_course_settings.py","position":54,"original_position":54,"commit_id":"e91f396c6da9af5a236d184cfa857fe06f070da3","original_commit_id":"e91f396c6da9af5a236d184cfa857fe06f070da3","user":{"login":"cahrens","id":484484,"avatar_url":"https://avatars.githubusercontent.com/u/484484?","gravatar_id":"c61f992b89d30875e4626db835a07b77","url":"https://api.github.com/users/cahrens","html_url":"https://github.com/cahrens","followers_url":"https://api.github.com/users/cahrens/followers","following_url":"https://api.github.com/users/cahrens/following{/other_user}","gists_url":"https://api.github.com/users/cahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/cahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahrens/subscriptions","organizations_url":"https://api.github.com/users/cahrens/orgs","repos_url":"https://api.github.com/users/cahrens/repos","events_url":"https://api.github.com/users/cahrens/events{/privacy}","received_events_url":"https://api.github.com/users/cahrens/received_events","type":"User","site_admin":false},"body":"Note to reviewer: unsetKeys was not used (besides this test), so I deleted it.","created_at":"2014-06-12T20:24:24Z","updated_at":"2014-06-12T20:24:24Z","html_url":"https://github.com/edx/edx-platform/pull/4073#discussion_r13724166","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/4073","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/13724166"},"html":{"href":"https://github.com/edx/edx-platform/pull/4073#discussion_r13724166"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4073"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/4073","id":17060310,"html_url":"https://github.com/edx/edx-platform/pull/4073","diff_url":"https://github.com/edx/edx-platform/pull/4073.diff","patch_url":"https://github.com/edx/edx-platform/pull/4073.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/4073","number":4073,"state":"open","title":"WIP: Display names, help text, and \"deprecated\" for Advanced Settings.","user":{"login":"cahrens","id":484484,"avatar_url":"https://avatars.githubusercontent.com/u/484484?","gravatar_id":"c61f992b89d30875e4626db835a07b77","url":"https://api.github.com/users/cahrens","html_url":"https://github.com/cahrens","followers_url":"https://api.github.com/users/cahrens/followers","following_url":"https://api.github.com/users/cahrens/following{/other_user}","gists_url":"https://api.github.com/users/cahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/cahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahrens/subscriptions","organizations_url":"https://api.github.com/users/cahrens/orgs","repos_url":"https://api.github.com/users/cahrens/repos","events_url":"https://api.github.com/users/cahrens/events{/privacy}","received_events_url":"https://api.github.com/users/cahrens/received_events","type":"User","site_admin":false},"body":"Hackathon with @frrrances and @mhoeber \r\n\r\nThe last entry (\"XQA Key\") is deprecated.\r\n\r\nDepends on https://github.com/edx/XBlock/pull/223","created_at":"2014-06-12T15:09:35Z","updated_at":"2014-06-12T20:24:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd81a83e550a0d3871efa1b57ae2133dd467e543","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/4073/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/4073/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/4073/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/e91f396c6da9af5a236d184cfa857fe06f070da3","head":{"label":"edx:christina/advanced-settings-hack","ref":"christina/advanced-settings-hack","sha":"e91f396c6da9af5a236d184cfa857fe06f070da3","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://www.edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-06-12T20:19:07Z","pushed_at":"2014-06-12T20:19:06Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://code.edx.org/","size":1151388,"stargazers_count":1250,"watchers_count":1250,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":651,"mirror_url":null,"open_issues_count":121,"forks":651,"open_issues":121,"watchers":1250,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"ed2358ab040e0102b10ef3695bb534746df52514","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://www.edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-06-12T20:19:07Z","pushed_at":"2014-06-12T20:19:06Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://code.edx.org/","size":1151388,"stargazers_count":1250,"watchers_count":1250,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":651,"mirror_url":null,"open_issues_count":121,"forks":651,"open_issues":121,"watchers":1250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4073"},"html":{"href":"https://github.com/edx/edx-platform/pull/4073"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/4073"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/4073/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4073/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4073/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/e91f396c6da9af5a236d184cfa857fe06f070da3"}}}}