GitHub PullRequestReviewCommentEvent at 2014-11-19 22:51:49
Repository: Faker
Actor: TimWolla
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fzaninotto/Faker/pulls/comments/20614498","id":20614498,"diff_hunk":"@@ -280,4 +280,15 @@ protected static function addBankCodeChecksum($iban, $countryCode = '')\n     {\n         return $iban;\n     }\n+\n+    /**\n+    +     * Return the String of a SWIFT/BIC number","path":"src/Faker/Provider/Payment.php","position":6,"original_position":6,"commit_id":"647e78ab353582c68e019483840195039b392f42","original_commit_id":"647e78ab353582c68e019483840195039b392f42","user":{"login":"TimWolla","id":209270,"avatar_url":"https://avatars.githubusercontent.com/u/209270?v=3","gravatar_id":"","url":"https://api.github.com/users/TimWolla","html_url":"https://github.com/TimWolla","followers_url":"https://api.github.com/users/TimWolla/followers","following_url":"https://api.github.com/users/TimWolla/following{/other_user}","gists_url":"https://api.github.com/users/TimWolla/gists{/gist_id}","starred_url":"https://api.github.com/users/TimWolla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimWolla/subscriptions","organizations_url":"https://api.github.com/users/TimWolla/orgs","repos_url":"https://api.github.com/users/TimWolla/repos","events_url":"https://api.github.com/users/TimWolla/events{/privacy}","received_events_url":"https://api.github.com/users/TimWolla/received_events","type":"User","site_admin":false},"body":"Typo (the plus sign)","created_at":"2014-11-19T22:51:49Z","updated_at":"2014-11-19T22:51:49Z","html_url":"https://github.com/fzaninotto/Faker/pull/465#discussion_r20614498","pull_request_url":"https://api.github.com/repos/fzaninotto/Faker/pulls/465","_links":{"self":{"href":"https://api.github.com/repos/fzaninotto/Faker/pulls/comments/20614498"},"html":{"href":"https://github.com/fzaninotto/Faker/pull/465#discussion_r20614498"},"pull_request":{"href":"https://api.github.com/repos/fzaninotto/Faker/pulls/465"}}},"pull_request":{"url":"https://api.github.com/repos/fzaninotto/Faker/pulls/465","id":24727531,"html_url":"https://github.com/fzaninotto/Faker/pull/465","diff_url":"https://github.com/fzaninotto/Faker/pull/465.diff","patch_url":"https://github.com/fzaninotto/Faker/pull/465.patch","issue_url":"https://api.github.com/repos/fzaninotto/Faker/issues/465","number":465,"state":"open","locked":false,"title":"+1 SWIFT/BIC payment type","user":{"login":"ronanguilloux","id":313677,"avatar_url":"https://avatars.githubusercontent.com/u/313677?v=3","gravatar_id":"","url":"https://api.github.com/users/ronanguilloux","html_url":"https://github.com/ronanguilloux","followers_url":"https://api.github.com/users/ronanguilloux/followers","following_url":"https://api.github.com/users/ronanguilloux/following{/other_user}","gists_url":"https://api.github.com/users/ronanguilloux/gists{/gist_id}","starred_url":"https://api.github.com/users/ronanguilloux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronanguilloux/subscriptions","organizations_url":"https://api.github.com/users/ronanguilloux/orgs","repos_url":"https://api.github.com/users/ronanguilloux/repos","events_url":"https://api.github.com/users/ronanguilloux/events{/privacy}","received_events_url":"https://api.github.com/users/ronanguilloux/received_events","type":"User","site_admin":false},"body":"Uppercasing Swift/Bic values seems to be common practice, even though [ISO-9362 specification](http://www.swift.com/assets/swift_com/documents/products_services/BIC2014_white_paper_57047_june2014.pdf) & the related [Wikipedia Page](http://en.wikipedia.org/wiki/ISO_9362) both avoid giving particular indications on that matter.\r\n\r\nI used the new Faker's Regex-based generator, and I presume any unit test may be useless here, since `BaseProvider::regexify()` is already test-covered.","created_at":"2014-11-19T22:37:22Z","updated_at":"2014-11-19T22:51:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"337c12c05fd09306d9343d4fed01a597c11beaab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fzaninotto/Faker/pulls/465/commits","review_comments_url":"https://api.github.com/repos/fzaninotto/Faker/pulls/465/comments","review_comment_url":"https://api.github.com/repos/fzaninotto/Faker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fzaninotto/Faker/issues/465/comments","statuses_url":"https://api.github.com/repos/fzaninotto/Faker/statuses/647e78ab353582c68e019483840195039b392f42","head":{"label":"ronanguilloux:ronan","ref":"ronan","sha":"647e78ab353582c68e019483840195039b392f42","user":{"login":"ronanguilloux","id":313677,"avatar_url":"https://avatars.githubusercontent.com/u/313677?v=3","gravatar_id":"","url":"https://api.github.com/users/ronanguilloux","html_url":"https://github.com/ronanguilloux","followers_url":"https://api.github.com/users/ronanguilloux/followers","following_url":"https://api.github.com/users/ronanguilloux/following{/other_user}","gists_url":"https://api.github.com/users/ronanguilloux/gists{/gist_id}","starred_url":"https://api.github.com/users/ronanguilloux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronanguilloux/subscriptions","organizations_url":"https://api.github.com/users/ronanguilloux/orgs","repos_url":"https://api.github.com/users/ronanguilloux/repos","events_url":"https://api.github.com/users/ronanguilloux/events{/privacy}","received_events_url":"https://api.github.com/users/ronanguilloux/received_events","type":"User","site_admin":false},"repo":{"id":26882751,"name":"Faker","full_name":"ronanguilloux/Faker","owner":{"login":"ronanguilloux","id":313677,"avatar_url":"https://avatars.githubusercontent.com/u/313677?v=3","gravatar_id":"","url":"https://api.github.com/users/ronanguilloux","html_url":"https://github.com/ronanguilloux","followers_url":"https://api.github.com/users/ronanguilloux/followers","following_url":"https://api.github.com/users/ronanguilloux/following{/other_user}","gists_url":"https://api.github.com/users/ronanguilloux/gists{/gist_id}","starred_url":"https://api.github.com/users/ronanguilloux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronanguilloux/subscriptions","organizations_url":"https://api.github.com/users/ronanguilloux/orgs","repos_url":"https://api.github.com/users/ronanguilloux/repos","events_url":"https://api.github.com/users/ronanguilloux/events{/privacy}","received_events_url":"https://api.github.com/users/ronanguilloux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ronanguilloux/Faker","description":"Faker is a PHP library that generates fake data for you","fork":true,"url":"https://api.github.com/repos/ronanguilloux/Faker","forks_url":"https://api.github.com/repos/ronanguilloux/Faker/forks","keys_url":"https://api.github.com/repos/ronanguilloux/Faker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ronanguilloux/Faker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ronanguilloux/Faker/teams","hooks_url":"https://api.github.com/repos/ronanguilloux/Faker/hooks","issue_events_url":"https://api.github.com/repos/ronanguilloux/Faker/issues/events{/number}","events_url":"https://api.github.com/repos/ronanguilloux/Faker/events","assignees_url":"https://api.github.com/repos/ronanguilloux/Faker/assignees{/user}","branches_url":"https://api.github.com/repos/ronanguilloux/Faker/branches{/branch}","tags_url":"https://api.github.com/repos/ronanguilloux/Faker/tags","blobs_url":"https://api.github.com/repos/ronanguilloux/Faker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ronanguilloux/Faker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ronanguilloux/Faker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ronanguilloux/Faker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ronanguilloux/Faker/statuses/{sha}","languages_url":"https://api.github.com/repos/ronanguilloux/Faker/languages","stargazers_url":"https://api.github.com/repos/ronanguilloux/Faker/stargazers","contributors_url":"https://api.github.com/repos/ronanguilloux/Faker/contributors","subscribers_url":"https://api.github.com/repos/ronanguilloux/Faker/subscribers","subscription_url":"https://api.github.com/repos/ronanguilloux/Faker/subscription","commits_url":"https://api.github.com/repos/ronanguilloux/Faker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ronanguilloux/Faker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ronanguilloux/Faker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ronanguilloux/Faker/issues/comments/{number}","contents_url":"https://api.github.com/repos/ronanguilloux/Faker/contents/{+path}","compare_url":"https://api.github.com/repos/ronanguilloux/Faker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ronanguilloux/Faker/merges","archive_url":"https://api.github.com/repos/ronanguilloux/Faker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ronanguilloux/Faker/downloads","issues_url":"https://api.github.com/repos/ronanguilloux/Faker/issues{/number}","pulls_url":"https://api.github.com/repos/ronanguilloux/Faker/pulls{/number}","milestones_url":"https://api.github.com/repos/ronanguilloux/Faker/milestones{/number}","notifications_url":"https://api.github.com/repos/ronanguilloux/Faker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ronanguilloux/Faker/labels{/name}","releases_url":"https://api.github.com/repos/ronanguilloux/Faker/releases{/id}","created_at":"2014-11-19T21:35:31Z","updated_at":"2014-11-19T21:35:32Z","pushed_at":"2014-11-19T22:27:35Z","git_url":"git://github.com/ronanguilloux/Faker.git","ssh_url":"git@github.com:ronanguilloux/Faker.git","clone_url":"https://github.com/ronanguilloux/Faker.git","svn_url":"https://github.com/ronanguilloux/Faker","homepage":"","size":10096,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fzaninotto:master","ref":"master","sha":"44eae4deeb065454e68b3c9911181285f01003c6","user":{"login":"fzaninotto","id":99944,"avatar_url":"https://avatars.githubusercontent.com/u/99944?v=3","gravatar_id":"","url":"https://api.github.com/users/fzaninotto","html_url":"https://github.com/fzaninotto","followers_url":"https://api.github.com/users/fzaninotto/followers","following_url":"https://api.github.com/users/fzaninotto/following{/other_user}","gists_url":"https://api.github.com/users/fzaninotto/gists{/gist_id}","starred_url":"https://api.github.com/users/fzaninotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzaninotto/subscriptions","organizations_url":"https://api.github.com/users/fzaninotto/orgs","repos_url":"https://api.github.com/users/fzaninotto/repos","events_url":"https://api.github.com/users/fzaninotto/events{/privacy}","received_events_url":"https://api.github.com/users/fzaninotto/received_events","type":"User","site_admin":false},"repo":{"id":2579314,"name":"Faker","full_name":"fzaninotto/Faker","owner":{"login":"fzaninotto","id":99944,"avatar_url":"https://avatars.githubusercontent.com/u/99944?v=3","gravatar_id":"","url":"https://api.github.com/users/fzaninotto","html_url":"https://github.com/fzaninotto","followers_url":"https://api.github.com/users/fzaninotto/followers","following_url":"https://api.github.com/users/fzaninotto/following{/other_user}","gists_url":"https://api.github.com/users/fzaninotto/gists{/gist_id}","starred_url":"https://api.github.com/users/fzaninotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzaninotto/subscriptions","organizations_url":"https://api.github.com/users/fzaninotto/orgs","repos_url":"https://api.github.com/users/fzaninotto/repos","events_url":"https://api.github.com/users/fzaninotto/events{/privacy}","received_events_url":"https://api.github.com/users/fzaninotto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fzaninotto/Faker","description":"Faker is a PHP library that generates fake data for you","fork":false,"url":"https://api.github.com/repos/fzaninotto/Faker","forks_url":"https://api.github.com/repos/fzaninotto/Faker/forks","keys_url":"https://api.github.com/repos/fzaninotto/Faker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fzaninotto/Faker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fzaninotto/Faker/teams","hooks_url":"https://api.github.com/repos/fzaninotto/Faker/hooks","issue_events_url":"https://api.github.com/repos/fzaninotto/Faker/issues/events{/number}","events_url":"https://api.github.com/repos/fzaninotto/Faker/events","assignees_url":"https://api.github.com/repos/fzaninotto/Faker/assignees{/user}","branches_url":"https://api.github.com/repos/fzaninotto/Faker/branches{/branch}","tags_url":"https://api.github.com/repos/fzaninotto/Faker/tags","blobs_url":"https://api.github.com/repos/fzaninotto/Faker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fzaninotto/Faker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fzaninotto/Faker/git/refs{/sha}","trees_url":"https://api.github.com/repos/fzaninotto/Faker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fzaninotto/Faker/statuses/{sha}","languages_url":"https://api.github.com/repos/fzaninotto/Faker/languages","stargazers_url":"https://api.github.com/repos/fzaninotto/Faker/stargazers","contributors_url":"https://api.github.com/repos/fzaninotto/Faker/contributors","subscribers_url":"https://api.github.com/repos/fzaninotto/Faker/subscribers","subscription_url":"https://api.github.com/repos/fzaninotto/Faker/subscription","commits_url":"https://api.github.com/repos/fzaninotto/Faker/commits{/sha}","git_commits_url":"https://api.github.com/repos/fzaninotto/Faker/git/commits{/sha}","comments_url":"https://api.github.com/repos/fzaninotto/Faker/comments{/number}","issue_comment_url":"https://api.github.com/repos/fzaninotto/Faker/issues/comments/{number}","contents_url":"https://api.github.com/repos/fzaninotto/Faker/contents/{+path}","compare_url":"https://api.github.com/repos/fzaninotto/Faker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fzaninotto/Faker/merges","archive_url":"https://api.github.com/repos/fzaninotto/Faker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fzaninotto/Faker/downloads","issues_url":"https://api.github.com/repos/fzaninotto/Faker/issues{/number}","pulls_url":"https://api.github.com/repos/fzaninotto/Faker/pulls{/number}","milestones_url":"https://api.github.com/repos/fzaninotto/Faker/milestones{/number}","notifications_url":"https://api.github.com/repos/fzaninotto/Faker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fzaninotto/Faker/labels{/name}","releases_url":"https://api.github.com/repos/fzaninotto/Faker/releases{/id}","created_at":"2011-10-14T22:49:02Z","updated_at":"2014-11-19T21:04:15Z","pushed_at":"2014-11-12T17:27:49Z","git_url":"git://github.com/fzaninotto/Faker.git","ssh_url":"git@github.com:fzaninotto/Faker.git","clone_url":"https://github.com/fzaninotto/Faker.git","svn_url":"https://github.com/fzaninotto/Faker","homepage":"","size":10096,"stargazers_count":4658,"watchers_count":4658,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":654,"mirror_url":null,"open_issues_count":38,"forks":654,"open_issues":38,"watchers":4658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fzaninotto/Faker/pulls/465"},"html":{"href":"https://github.com/fzaninotto/Faker/pull/465"},"issue":{"href":"https://api.github.com/repos/fzaninotto/Faker/issues/465"},"comments":{"href":"https://api.github.com/repos/fzaninotto/Faker/issues/465/comments"},"review_comments":{"href":"https://api.github.com/repos/fzaninotto/Faker/pulls/465/comments"},"review_comment":{"href":"https://api.github.com/repos/fzaninotto/Faker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fzaninotto/Faker/pulls/465/commits"},"statuses":{"href":"https://api.github.com/repos/fzaninotto/Faker/statuses/647e78ab353582c68e019483840195039b392f42"}}}}