GitHub PullRequestEvent at 2014-09-30 02:12:00
Repository: remotestorage.js
Actor: silverbucket
Payload: {"action":"opened","number":775,"pull_request":{"url":"https://api.github.com/repos/remotestorage/remotestorage.js/pulls/775","id":21977702,"html_url":"https://github.com/remotestorage/remotestorage.js/pull/775","diff_url":"https://github.com/remotestorage/remotestorage.js/pull/775.diff","patch_url":"https://github.com/remotestorage/remotestorage.js/pull/775.patch","issue_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/775","number":775,"state":"open","locked":false,"title":"Use webfinger.js","user":{"login":"silverbucket","id":317571,"avatar_url":"https://avatars.githubusercontent.com/u/317571?v=2","gravatar_id":"","url":"https://api.github.com/users/silverbucket","html_url":"https://github.com/silverbucket","followers_url":"https://api.github.com/users/silverbucket/followers","following_url":"https://api.github.com/users/silverbucket/following{/other_user}","gists_url":"https://api.github.com/users/silverbucket/gists{/gist_id}","starred_url":"https://api.github.com/users/silverbucket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverbucket/subscriptions","organizations_url":"https://api.github.com/users/silverbucket/orgs","repos_url":"https://api.github.com/users/silverbucket/repos","events_url":"https://api.github.com/users/silverbucket/events{/privacy}","received_events_url":"https://api.github.com/users/silverbucket/received_events","type":"User","site_admin":false},"body":"I split out the webfinger logic from remotestorage.js and replaced it with using the `webfinger.js` library. All of the functionality works fine, the one issue I have is I can't get the tests to pass. They are doing some `XMLHttpRequest` hijacking it seems, but for some reason it's not finding anything. \r\n\r\nIf you compare how `webfinger.js` makes the HTTP calls [1] and how the old implementation in `remotestorage.js` did [2], they are almost exactly the same, so I'm not sure what's going on. Anyone have any ideas here / experience with writting http request stubbing? If anyone want's to take a look I'd appreciate a second pair of eyes on it.\r\n\r\n[1] https://github.com/silverbucket/webfinger.js/blob/2cedc3c1b3923b43f40532753a091736278a64d7/src/webfinger.js#L89-L126\r\n[2] https://github.com/remotestorage/remotestorage.js/blob/ebb1d6c16705b1ee21d910a74fbe04b7f3dd11f6/src/discover.js#L38-L49","created_at":"2014-09-30T02:11:59Z","updated_at":"2014-09-30T02:12:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/remotestorage/remotestorage.js/pulls/775/commits","review_comments_url":"https://api.github.com/repos/remotestorage/remotestorage.js/pulls/775/comments","review_comment_url":"https://api.github.com/repos/remotestorage/remotestorage.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/775/comments","statuses_url":"https://api.github.com/repos/remotestorage/remotestorage.js/statuses/9910e2865e170138bae7b12343d282c66ac970a5","head":{"label":"silverbucket:use_webfingerjs","ref":"use_webfingerjs","sha":"9910e2865e170138bae7b12343d282c66ac970a5","user":{"login":"silverbucket","id":317571,"avatar_url":"https://avatars.githubusercontent.com/u/317571?v=2","gravatar_id":"","url":"https://api.github.com/users/silverbucket","html_url":"https://github.com/silverbucket","followers_url":"https://api.github.com/users/silverbucket/followers","following_url":"https://api.github.com/users/silverbucket/following{/other_user}","gists_url":"https://api.github.com/users/silverbucket/gists{/gist_id}","starred_url":"https://api.github.com/users/silverbucket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverbucket/subscriptions","organizations_url":"https://api.github.com/users/silverbucket/orgs","repos_url":"https://api.github.com/users/silverbucket/repos","events_url":"https://api.github.com/users/silverbucket/events{/privacy}","received_events_url":"https://api.github.com/users/silverbucket/received_events","type":"User","site_admin":false},"repo":{"id":14409515,"name":"remotestorage.js","full_name":"silverbucket/remotestorage.js","owner":{"login":"silverbucket","id":317571,"avatar_url":"https://avatars.githubusercontent.com/u/317571?v=2","gravatar_id":"","url":"https://api.github.com/users/silverbucket","html_url":"https://github.com/silverbucket","followers_url":"https://api.github.com/users/silverbucket/followers","following_url":"https://api.github.com/users/silverbucket/following{/other_user}","gists_url":"https://api.github.com/users/silverbucket/gists{/gist_id}","starred_url":"https://api.github.com/users/silverbucket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverbucket/subscriptions","organizations_url":"https://api.github.com/users/silverbucket/orgs","repos_url":"https://api.github.com/users/silverbucket/repos","events_url":"https://api.github.com/users/silverbucket/events{/privacy}","received_events_url":"https://api.github.com/users/silverbucket/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/silverbucket/remotestorage.js","description":"JavaScript client library for integrating remoteStorage","fork":true,"url":"https://api.github.com/repos/silverbucket/remotestorage.js","forks_url":"https://api.github.com/repos/silverbucket/remotestorage.js/forks","keys_url":"https://api.github.com/repos/silverbucket/remotestorage.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverbucket/remotestorage.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverbucket/remotestorage.js/teams","hooks_url":"https://api.github.com/repos/silverbucket/remotestorage.js/hooks","issue_events_url":"https://api.github.com/repos/silverbucket/remotestorage.js/issues/events{/number}","events_url":"https://api.github.com/repos/silverbucket/remotestorage.js/events","assignees_url":"https://api.github.com/repos/silverbucket/remotestorage.js/assignees{/user}","branches_url":"https://api.github.com/repos/silverbucket/remotestorage.js/branches{/branch}","tags_url":"https://api.github.com/repos/silverbucket/remotestorage.js/tags","blobs_url":"https://api.github.com/repos/silverbucket/remotestorage.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverbucket/remotestorage.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverbucket/remotestorage.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverbucket/remotestorage.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverbucket/remotestorage.js/statuses/{sha}","languages_url":"https://api.github.com/repos/silverbucket/remotestorage.js/languages","stargazers_url":"https://api.github.com/repos/silverbucket/remotestorage.js/stargazers","contributors_url":"https://api.github.com/repos/silverbucket/remotestorage.js/contributors","subscribers_url":"https://api.github.com/repos/silverbucket/remotestorage.js/subscribers","subscription_url":"https://api.github.com/repos/silverbucket/remotestorage.js/subscription","commits_url":"https://api.github.com/repos/silverbucket/remotestorage.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverbucket/remotestorage.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverbucket/remotestorage.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverbucket/remotestorage.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/silverbucket/remotestorage.js/contents/{+path}","compare_url":"https://api.github.com/repos/silverbucket/remotestorage.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverbucket/remotestorage.js/merges","archive_url":"https://api.github.com/repos/silverbucket/remotestorage.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverbucket/remotestorage.js/downloads","issues_url":"https://api.github.com/repos/silverbucket/remotestorage.js/issues{/number}","pulls_url":"https://api.github.com/repos/silverbucket/remotestorage.js/pulls{/number}","milestones_url":"https://api.github.com/repos/silverbucket/remotestorage.js/milestones{/number}","notifications_url":"https://api.github.com/repos/silverbucket/remotestorage.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverbucket/remotestorage.js/labels{/name}","releases_url":"https://api.github.com/repos/silverbucket/remotestorage.js/releases{/id}","created_at":"2013-11-14T23:03:00Z","updated_at":"2014-09-12T16:22:58Z","pushed_at":"2014-09-30T02:06:05Z","git_url":"git://github.com/silverbucket/remotestorage.js.git","ssh_url":"git@github.com:silverbucket/remotestorage.js.git","clone_url":"https://github.com/silverbucket/remotestorage.js.git","svn_url":"https://github.com/silverbucket/remotestorage.js","homepage":"http://remotestorage.io","size":12349,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"remotestorage:master","ref":"master","sha":"ebb1d6c16705b1ee21d910a74fbe04b7f3dd11f6","user":{"login":"remotestorage","id":2323242,"avatar_url":"https://avatars.githubusercontent.com/u/2323242?v=2","gravatar_id":"","url":"https://api.github.com/users/remotestorage","html_url":"https://github.com/remotestorage","followers_url":"https://api.github.com/users/remotestorage/followers","following_url":"https://api.github.com/users/remotestorage/following{/other_user}","gists_url":"https://api.github.com/users/remotestorage/gists{/gist_id}","starred_url":"https://api.github.com/users/remotestorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remotestorage/subscriptions","organizations_url":"https://api.github.com/users/remotestorage/orgs","repos_url":"https://api.github.com/users/remotestorage/repos","events_url":"https://api.github.com/users/remotestorage/events{/privacy}","received_events_url":"https://api.github.com/users/remotestorage/received_events","type":"Organization","site_admin":false},"repo":{"id":1052694,"name":"remotestorage.js","full_name":"remotestorage/remotestorage.js","owner":{"login":"remotestorage","id":2323242,"avatar_url":"https://avatars.githubusercontent.com/u/2323242?v=2","gravatar_id":"","url":"https://api.github.com/users/remotestorage","html_url":"https://github.com/remotestorage","followers_url":"https://api.github.com/users/remotestorage/followers","following_url":"https://api.github.com/users/remotestorage/following{/other_user}","gists_url":"https://api.github.com/users/remotestorage/gists{/gist_id}","starred_url":"https://api.github.com/users/remotestorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remotestorage/subscriptions","organizations_url":"https://api.github.com/users/remotestorage/orgs","repos_url":"https://api.github.com/users/remotestorage/repos","events_url":"https://api.github.com/users/remotestorage/events{/privacy}","received_events_url":"https://api.github.com/users/remotestorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/remotestorage/remotestorage.js","description":"JavaScript client library for integrating remoteStorage","fork":false,"url":"https://api.github.com/repos/remotestorage/remotestorage.js","forks_url":"https://api.github.com/repos/remotestorage/remotestorage.js/forks","keys_url":"https://api.github.com/repos/remotestorage/remotestorage.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remotestorage/remotestorage.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remotestorage/remotestorage.js/teams","hooks_url":"https://api.github.com/repos/remotestorage/remotestorage.js/hooks","issue_events_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/events{/number}","events_url":"https://api.github.com/repos/remotestorage/remotestorage.js/events","assignees_url":"https://api.github.com/repos/remotestorage/remotestorage.js/assignees{/user}","branches_url":"https://api.github.com/repos/remotestorage/remotestorage.js/branches{/branch}","tags_url":"https://api.github.com/repos/remotestorage/remotestorage.js/tags","blobs_url":"https://api.github.com/repos/remotestorage/remotestorage.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remotestorage/remotestorage.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remotestorage/remotestorage.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/remotestorage/remotestorage.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remotestorage/remotestorage.js/statuses/{sha}","languages_url":"https://api.github.com/repos/remotestorage/remotestorage.js/languages","stargazers_url":"https://api.github.com/repos/remotestorage/remotestorage.js/stargazers","contributors_url":"https://api.github.com/repos/remotestorage/remotestorage.js/contributors","subscribers_url":"https://api.github.com/repos/remotestorage/remotestorage.js/subscribers","subscription_url":"https://api.github.com/repos/remotestorage/remotestorage.js/subscription","commits_url":"https://api.github.com/repos/remotestorage/remotestorage.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/remotestorage/remotestorage.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/remotestorage/remotestorage.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/remotestorage/remotestorage.js/contents/{+path}","compare_url":"https://api.github.com/repos/remotestorage/remotestorage.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remotestorage/remotestorage.js/merges","archive_url":"https://api.github.com/repos/remotestorage/remotestorage.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remotestorage/remotestorage.js/downloads","issues_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues{/number}","pulls_url":"https://api.github.com/repos/remotestorage/remotestorage.js/pulls{/number}","milestones_url":"https://api.github.com/repos/remotestorage/remotestorage.js/milestones{/number}","notifications_url":"https://api.github.com/repos/remotestorage/remotestorage.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remotestorage/remotestorage.js/labels{/name}","releases_url":"https://api.github.com/repos/remotestorage/remotestorage.js/releases{/id}","created_at":"2010-11-04T23:09:23Z","updated_at":"2014-09-28T00:22:02Z","pushed_at":"2014-09-29T08:57:38Z","git_url":"git://github.com/remotestorage/remotestorage.js.git","ssh_url":"git@github.com:remotestorage/remotestorage.js.git","clone_url":"https://github.com/remotestorage/remotestorage.js.git","svn_url":"https://github.com/remotestorage/remotestorage.js","homepage":"http://remotestorage.io","size":128619,"stargazers_count":563,"watchers_count":563,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":67,"forks":60,"open_issues":67,"watchers":563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/remotestorage/remotestorage.js/pulls/775"},"html":{"href":"https://github.com/remotestorage/remotestorage.js/pull/775"},"issue":{"href":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/775"},"comments":{"href":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/775/comments"},"review_comments":{"href":"https://api.github.com/repos/remotestorage/remotestorage.js/pulls/775/comments"},"review_comment":{"href":"https://api.github.com/repos/remotestorage/remotestorage.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/remotestorage/remotestorage.js/pulls/775/commits"},"statuses":{"href":"https://api.github.com/repos/remotestorage/remotestorage.js/statuses/9910e2865e170138bae7b12343d282c66ac970a5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":31,"deletions":65,"changed_files":5}}