GitHub PullRequestEvent at 2014-12-09 22:55:38
Repository: stellar-client
Actor: deckar01
Payload: {"action":"closed","number":1105,"pull_request":{"url":"https://api.github.com/repos/stellar/stellar-client/pulls/1105","id":25316477,"html_url":"https://github.com/stellar/stellar-client/pull/1105","diff_url":"https://github.com/stellar/stellar-client/pull/1105.diff","patch_url":"https://github.com/stellar/stellar-client/pull/1105.patch","issue_url":"https://api.github.com/repos/stellar/stellar-client/issues/1105","number":1105,"state":"closed","locked":false,"title":"Show amount errors, unify errors and updatePaths()","user":{"login":"deckar01","id":3108007,"avatar_url":"https://avatars.githubusercontent.com/u/3108007?v=3","gravatar_id":"","url":"https://api.github.com/users/deckar01","html_url":"https://github.com/deckar01","followers_url":"https://api.github.com/users/deckar01/followers","following_url":"https://api.github.com/users/deckar01/following{/other_user}","gists_url":"https://api.github.com/users/deckar01/gists{/gist_id}","starred_url":"https://api.github.com/users/deckar01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deckar01/subscriptions","organizations_url":"https://api.github.com/users/deckar01/orgs","repos_url":"https://api.github.com/users/deckar01/repos","events_url":"https://api.github.com/users/deckar01/events{/privacy}","received_events_url":"https://api.github.com/users/deckar01/received_events","type":"User","site_admin":false},"body":"Change the amount input type to text to bypass angular's silent validation.\r\nReject invalid amounts and show an error poptip the same way the destination is handled.\r\nProperly reset the path status when the input is invalid.\r\n\r\n![screen shot 2014-12-01 at 7 09 31 pm](https://cloud.githubusercontent.com/assets/3108007/5257454/b35b75a2-798d-11e4-8029-5e310c4f818c.png)\r\n![screen shot 2014-12-01 at 7 09 58 pm](https://cloud.githubusercontent.com/assets/3108007/5257455/b35fbb94-798d-11e4-95b6-a2a77ac18d6d.png)\r\n","created_at":"2014-12-02T03:10:55Z","updated_at":"2014-12-09T22:55:38Z","closed_at":"2014-12-09T22:55:38Z","merged_at":"2014-12-09T22:55:38Z","merge_commit_sha":"d37178e132665242c3b376ec650d0f716ddec0cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stellar/stellar-client/pulls/1105/commits","review_comments_url":"https://api.github.com/repos/stellar/stellar-client/pulls/1105/comments","review_comment_url":"https://api.github.com/repos/stellar/stellar-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/stellar/stellar-client/issues/1105/comments","statuses_url":"https://api.github.com/repos/stellar/stellar-client/statuses/4616bdd3c06c0f3f9a4135f43751c7cb6e8d7dd8","head":{"label":"stellar:send-amount-errors","ref":"send-amount-errors","sha":"4616bdd3c06c0f3f9a4135f43751c7cb6e8d7dd8","user":{"login":"stellar","id":7386716,"avatar_url":"https://avatars.githubusercontent.com/u/7386716?v=3","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"repo":{"id":19084480,"name":"stellar-client","full_name":"stellar/stellar-client","owner":{"login":"stellar","id":7386716,"avatar_url":"https://avatars.githubusercontent.com/u/7386716?v=3","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stellar/stellar-client","description":"Browser based client for stellard.","fork":false,"url":"https://api.github.com/repos/stellar/stellar-client","forks_url":"https://api.github.com/repos/stellar/stellar-client/forks","keys_url":"https://api.github.com/repos/stellar/stellar-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellar/stellar-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellar/stellar-client/teams","hooks_url":"https://api.github.com/repos/stellar/stellar-client/hooks","issue_events_url":"https://api.github.com/repos/stellar/stellar-client/issues/events{/number}","events_url":"https://api.github.com/repos/stellar/stellar-client/events","assignees_url":"https://api.github.com/repos/stellar/stellar-client/assignees{/user}","branches_url":"https://api.github.com/repos/stellar/stellar-client/branches{/branch}","tags_url":"https://api.github.com/repos/stellar/stellar-client/tags","blobs_url":"https://api.github.com/repos/stellar/stellar-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellar/stellar-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellar/stellar-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellar/stellar-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellar/stellar-client/statuses/{sha}","languages_url":"https://api.github.com/repos/stellar/stellar-client/languages","stargazers_url":"https://api.github.com/repos/stellar/stellar-client/stargazers","contributors_url":"https://api.github.com/repos/stellar/stellar-client/contributors","subscribers_url":"https://api.github.com/repos/stellar/stellar-client/subscribers","subscription_url":"https://api.github.com/repos/stellar/stellar-client/subscription","commits_url":"https://api.github.com/repos/stellar/stellar-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellar/stellar-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellar/stellar-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellar/stellar-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/stellar/stellar-client/contents/{+path}","compare_url":"https://api.github.com/repos/stellar/stellar-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellar/stellar-client/merges","archive_url":"https://api.github.com/repos/stellar/stellar-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellar/stellar-client/downloads","issues_url":"https://api.github.com/repos/stellar/stellar-client/issues{/number}","pulls_url":"https://api.github.com/repos/stellar/stellar-client/pulls{/number}","milestones_url":"https://api.github.com/repos/stellar/stellar-client/milestones{/number}","notifications_url":"https://api.github.com/repos/stellar/stellar-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellar/stellar-client/labels{/name}","releases_url":"https://api.github.com/repos/stellar/stellar-client/releases{/id}","created_at":"2014-04-23T20:29:36Z","updated_at":"2014-12-08T19:07:10Z","pushed_at":"2014-12-09T22:55:38Z","git_url":"git://github.com/stellar/stellar-client.git","ssh_url":"git@github.com:stellar/stellar-client.git","clone_url":"https://github.com/stellar/stellar-client.git","svn_url":"https://github.com/stellar/stellar-client","homepage":"","size":9745,"stargazers_count":307,"watchers_count":307,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":94,"forks":69,"open_issues":94,"watchers":307,"default_branch":"master"}},"base":{"label":"stellar:master","ref":"master","sha":"cfde4f36ea2f98b886dd9e4800d6353c2d94765a","user":{"login":"stellar","id":7386716,"avatar_url":"https://avatars.githubusercontent.com/u/7386716?v=3","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"repo":{"id":19084480,"name":"stellar-client","full_name":"stellar/stellar-client","owner":{"login":"stellar","id":7386716,"avatar_url":"https://avatars.githubusercontent.com/u/7386716?v=3","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stellar/stellar-client","description":"Browser based client for stellard.","fork":false,"url":"https://api.github.com/repos/stellar/stellar-client","forks_url":"https://api.github.com/repos/stellar/stellar-client/forks","keys_url":"https://api.github.com/repos/stellar/stellar-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellar/stellar-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellar/stellar-client/teams","hooks_url":"https://api.github.com/repos/stellar/stellar-client/hooks","issue_events_url":"https://api.github.com/repos/stellar/stellar-client/issues/events{/number}","events_url":"https://api.github.com/repos/stellar/stellar-client/events","assignees_url":"https://api.github.com/repos/stellar/stellar-client/assignees{/user}","branches_url":"https://api.github.com/repos/stellar/stellar-client/branches{/branch}","tags_url":"https://api.github.com/repos/stellar/stellar-client/tags","blobs_url":"https://api.github.com/repos/stellar/stellar-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellar/stellar-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellar/stellar-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellar/stellar-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellar/stellar-client/statuses/{sha}","languages_url":"https://api.github.com/repos/stellar/stellar-client/languages","stargazers_url":"https://api.github.com/repos/stellar/stellar-client/stargazers","contributors_url":"https://api.github.com/repos/stellar/stellar-client/contributors","subscribers_url":"https://api.github.com/repos/stellar/stellar-client/subscribers","subscription_url":"https://api.github.com/repos/stellar/stellar-client/subscription","commits_url":"https://api.github.com/repos/stellar/stellar-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellar/stellar-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellar/stellar-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellar/stellar-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/stellar/stellar-client/contents/{+path}","compare_url":"https://api.github.com/repos/stellar/stellar-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellar/stellar-client/merges","archive_url":"https://api.github.com/repos/stellar/stellar-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellar/stellar-client/downloads","issues_url":"https://api.github.com/repos/stellar/stellar-client/issues{/number}","pulls_url":"https://api.github.com/repos/stellar/stellar-client/pulls{/number}","milestones_url":"https://api.github.com/repos/stellar/stellar-client/milestones{/number}","notifications_url":"https://api.github.com/repos/stellar/stellar-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellar/stellar-client/labels{/name}","releases_url":"https://api.github.com/repos/stellar/stellar-client/releases{/id}","created_at":"2014-04-23T20:29:36Z","updated_at":"2014-12-08T19:07:10Z","pushed_at":"2014-12-09T22:55:38Z","git_url":"git://github.com/stellar/stellar-client.git","ssh_url":"git@github.com:stellar/stellar-client.git","clone_url":"https://github.com/stellar/stellar-client.git","svn_url":"https://github.com/stellar/stellar-client","homepage":"","size":9745,"stargazers_count":307,"watchers_count":307,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":94,"forks":69,"open_issues":94,"watchers":307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stellar/stellar-client/pulls/1105"},"html":{"href":"https://github.com/stellar/stellar-client/pull/1105"},"issue":{"href":"https://api.github.com/repos/stellar/stellar-client/issues/1105"},"comments":{"href":"https://api.github.com/repos/stellar/stellar-client/issues/1105/comments"},"review_comments":{"href":"https://api.github.com/repos/stellar/stellar-client/pulls/1105/comments"},"review_comment":{"href":"https://api.github.com/repos/stellar/stellar-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/stellar/stellar-client/pulls/1105/commits"},"statuses":{"href":"https://api.github.com/repos/stellar/stellar-client/statuses/4616bdd3c06c0f3f9a4135f43751c7cb6e8d7dd8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"deckar01","id":3108007,"avatar_url":"https://avatars.githubusercontent.com/u/3108007?v=3","gravatar_id":"","url":"https://api.github.com/users/deckar01","html_url":"https://github.com/deckar01","followers_url":"https://api.github.com/users/deckar01/followers","following_url":"https://api.github.com/users/deckar01/following{/other_user}","gists_url":"https://api.github.com/users/deckar01/gists{/gist_id}","starred_url":"https://api.github.com/users/deckar01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deckar01/subscriptions","organizations_url":"https://api.github.com/users/deckar01/orgs","repos_url":"https://api.github.com/users/deckar01/repos","events_url":"https://api.github.com/users/deckar01/events{/privacy}","received_events_url":"https://api.github.com/users/deckar01/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":61,"deletions":20,"changed_files":3}}