GitHub PullRequestReviewCommentEvent at 2014-07-31 03:35:38
Repository: OpenRA
Actor: atlimit8
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/15625103","id":15625103,"diff_hunk":"@@ -87,6 +98,34 @@ public Manifest(string mod)\n \t\t\tif (yaml.ContainsKey(\"TileShape\"))\n \t\t\t\tTileShape = FieldLoader.GetValue<TileShape>(\"TileShape\", yaml[\"TileShape\"].Value);\n \n+\t\t\t// Read subcell information\n+\t\t\t// sub-cell index 0 is the full cell\n+\t\t\tif (yaml.ContainsKey(\"SubCells\"))\n+\t\t\t{\n+\t\t\t\tvar subcells = yaml[\"SubCells\"].ToDictionary();\n+\n+\t\t\t\t// Read (x,y,z) offset (relative to cell center) pairs for positioning subcells\n+\t\t\t\tif (subcells.ContainsKey(\"Offsets\"))\n+\t\t\t\t{\n+\t\t\t\t\tSubCellOffsets = FieldLoader.GetValue<WVec[]>(\"Offsets\", subcells[\"Offsets\"].Value);\n+\n+\t\t\t\t\tforeach (var i in SubCellOffsets)","path":"OpenRA.Game/Manifest.cs","position":33,"original_position":33,"commit_id":"be02fe6608dcaa1a547df914c4635b0810c64c27","original_commit_id":"be02fe6608dcaa1a547df914c4635b0810c64c27","user":{"login":"atlimit8","id":4957137,"avatar_url":"https://avatars.githubusercontent.com/u/4957137?v=1","gravatar_id":"f939670ea3ed90212a1aa9fce5a52f2d","url":"https://api.github.com/users/atlimit8","html_url":"https://github.com/atlimit8","followers_url":"https://api.github.com/users/atlimit8/followers","following_url":"https://api.github.com/users/atlimit8/following{/other_user}","gists_url":"https://api.github.com/users/atlimit8/gists{/gist_id}","starred_url":"https://api.github.com/users/atlimit8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlimit8/subscriptions","organizations_url":"https://api.github.com/users/atlimit8/orgs","repos_url":"https://api.github.com/users/atlimit8/repos","events_url":"https://api.github.com/users/atlimit8/events{/privacy}","received_events_url":"https://api.github.com/users/atlimit8/received_events","type":"User","site_admin":false},"body":"What about the effect of large offsets around map borders?","created_at":"2014-07-31T03:35:38Z","updated_at":"2014-07-31T03:35:38Z","html_url":"https://github.com/OpenRA/OpenRA/pull/6113#discussion_r15625103","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6113","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/15625103"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/6113#discussion_r15625103"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6113"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6113","id":19109701,"html_url":"https://github.com/OpenRA/OpenRA/pull/6113","diff_url":"https://github.com/OpenRA/OpenRA/pull/6113.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/6113.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/6113","number":6113,"state":"open","title":"Load WVec[] from MiniYaml","user":{"login":"atlimit8","id":4957137,"avatar_url":"https://avatars.githubusercontent.com/u/4957137?v=1","gravatar_id":"f939670ea3ed90212a1aa9fce5a52f2d","url":"https://api.github.com/users/atlimit8","html_url":"https://github.com/atlimit8","followers_url":"https://api.github.com/users/atlimit8/followers","following_url":"https://api.github.com/users/atlimit8/following{/other_user}","gists_url":"https://api.github.com/users/atlimit8/gists{/gist_id}","starred_url":"https://api.github.com/users/atlimit8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlimit8/subscriptions","organizations_url":"https://api.github.com/users/atlimit8/orgs","repos_url":"https://api.github.com/users/atlimit8/repos","events_url":"https://api.github.com/users/atlimit8/events{/privacy}","received_events_url":"https://api.github.com/users/atlimit8/received_events","type":"User","site_admin":false},"body":"Will be used by #6100 for loading sub-cell info from mod.yaml\r\nThis includes a few test cases (in one commit) to be removed before merging.","created_at":"2014-07-30T18:58:00Z","updated_at":"2014-07-31T03:35:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2cf35632adc9eaf2b81a7510475c6af8947cdd5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6113/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6113/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/6113/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/be02fe6608dcaa1a547df914c4635b0810c64c27","head":{"label":"atlimit8:FieldLoadWVecArray","ref":"FieldLoadWVecArray","sha":"be02fe6608dcaa1a547df914c4635b0810c64c27","user":{"login":"atlimit8","id":4957137,"avatar_url":"https://avatars.githubusercontent.com/u/4957137?v=1","gravatar_id":"f939670ea3ed90212a1aa9fce5a52f2d","url":"https://api.github.com/users/atlimit8","html_url":"https://github.com/atlimit8","followers_url":"https://api.github.com/users/atlimit8/followers","following_url":"https://api.github.com/users/atlimit8/following{/other_user}","gists_url":"https://api.github.com/users/atlimit8/gists{/gist_id}","starred_url":"https://api.github.com/users/atlimit8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlimit8/subscriptions","organizations_url":"https://api.github.com/users/atlimit8/orgs","repos_url":"https://api.github.com/users/atlimit8/repos","events_url":"https://api.github.com/users/atlimit8/events{/privacy}","received_events_url":"https://api.github.com/users/atlimit8/received_events","type":"User","site_admin":false},"repo":{"id":20511242,"name":"OpenRA","full_name":"atlimit8/OpenRA","owner":{"login":"atlimit8","id":4957137,"avatar_url":"https://avatars.githubusercontent.com/u/4957137?v=1","gravatar_id":"f939670ea3ed90212a1aa9fce5a52f2d","url":"https://api.github.com/users/atlimit8","html_url":"https://github.com/atlimit8","followers_url":"https://api.github.com/users/atlimit8/followers","following_url":"https://api.github.com/users/atlimit8/following{/other_user}","gists_url":"https://api.github.com/users/atlimit8/gists{/gist_id}","starred_url":"https://api.github.com/users/atlimit8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlimit8/subscriptions","organizations_url":"https://api.github.com/users/atlimit8/orgs","repos_url":"https://api.github.com/users/atlimit8/repos","events_url":"https://api.github.com/users/atlimit8/events{/privacy}","received_events_url":"https://api.github.com/users/atlimit8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atlimit8/OpenRA","description":"An open-source implementation of the Command & Conquer: Red Alert engine using .NET/Mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":true,"url":"https://api.github.com/repos/atlimit8/OpenRA","forks_url":"https://api.github.com/repos/atlimit8/OpenRA/forks","keys_url":"https://api.github.com/repos/atlimit8/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atlimit8/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atlimit8/OpenRA/teams","hooks_url":"https://api.github.com/repos/atlimit8/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/atlimit8/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/atlimit8/OpenRA/events","assignees_url":"https://api.github.com/repos/atlimit8/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/atlimit8/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/atlimit8/OpenRA/tags","blobs_url":"https://api.github.com/repos/atlimit8/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atlimit8/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atlimit8/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/atlimit8/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atlimit8/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/atlimit8/OpenRA/languages","stargazers_url":"https://api.github.com/repos/atlimit8/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/atlimit8/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/atlimit8/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/atlimit8/OpenRA/subscription","commits_url":"https://api.github.com/repos/atlimit8/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/atlimit8/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/atlimit8/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/atlimit8/OpenRA/issues/comments/{number}","contents_url":"https://api.github.com/repos/atlimit8/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/atlimit8/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atlimit8/OpenRA/merges","archive_url":"https://api.github.com/repos/atlimit8/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atlimit8/OpenRA/downloads","issues_url":"https://api.github.com/repos/atlimit8/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/atlimit8/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/atlimit8/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/atlimit8/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atlimit8/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/atlimit8/OpenRA/releases{/id}","created_at":"2014-06-05T04:01:26Z","updated_at":"2014-07-02T01:49:46Z","pushed_at":"2014-07-30T21:15:32Z","git_url":"git://github.com/atlimit8/OpenRA.git","ssh_url":"git@github.com:atlimit8/OpenRA.git","clone_url":"https://github.com/atlimit8/OpenRA.git","svn_url":"https://github.com/atlimit8/OpenRA","homepage":"http://www.openra.net","size":68986,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"de1c80af889d48e90874a56077ec3cf14c4f2a5b","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=1","gravatar_id":"130440af3b498592b1903ffdef874aa2","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=1","gravatar_id":"130440af3b498592b1903ffdef874aa2","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"An open-source implementation of the Command & Conquer: Red Alert engine using .NET/Mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments/{number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2014-07-31T02:26:35Z","pushed_at":"2014-07-30T02:33:46Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":180754,"stargazers_count":1173,"watchers_count":1173,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":387,"mirror_url":null,"open_issues_count":716,"forks":387,"open_issues":716,"watchers":1173,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6113"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/6113"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/6113"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/6113/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6113/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/6113/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/be02fe6608dcaa1a547df914c4635b0810c64c27"}}}}