GitHub PullRequestReviewCommentEvent at 2014-01-30 17:14:46
Repository: nilearn
Actor: GaelVaroquaux
Payload: {"comment":{"url":"https://api.github.com/repos/nilearn/nilearn/pulls/comments/9313591","id":9313591,"diff_hunk":"@@ -0,0 +1,344 @@\n+\"\"\"\n+Massively Univariate Linear Model estimated with OLS and permutation test.\n+Separate module from the main routine since joblib requires parallelized\n+functions to be in a different file.","path":"nilearn/group_analysis/permuted_least_squares_aux.py","position":4,"original_position":4,"commit_id":"9450a0ccb32603c643d36c13a860c6715238dd0c","original_commit_id":"9450a0ccb32603c643d36c13a860c6715238dd0c","user":{"login":"GaelVaroquaux","id":208217,"avatar_url":"https://gravatar.com/avatar/5c9fb379c4e97b58960d74dcbfc5dee5?d=https%3A%2F%2Fidenticons.github.com%2F0f015294465b35bf1108f310bb85ef0c.png&r=x","gravatar_id":"5c9fb379c4e97b58960d74dcbfc5dee5","url":"https://api.github.com/users/GaelVaroquaux","html_url":"https://github.com/GaelVaroquaux","followers_url":"https://api.github.com/users/GaelVaroquaux/followers","following_url":"https://api.github.com/users/GaelVaroquaux/following{/other_user}","gists_url":"https://api.github.com/users/GaelVaroquaux/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelVaroquaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelVaroquaux/subscriptions","organizations_url":"https://api.github.com/users/GaelVaroquaux/orgs","repos_url":"https://api.github.com/users/GaelVaroquaux/repos","events_url":"https://api.github.com/users/GaelVaroquaux/events{/privacy}","received_events_url":"https://api.github.com/users/GaelVaroquaux/received_events","type":"User","site_admin":false},"body":"Joblib doesn't requires parallelized functions to be in a different files, it requires them not to be in the __main__ module.\r\n\r\nThus you can merge the content of this file with the other, and I think that you should.","created_at":"2014-01-30T17:14:46Z","updated_at":"2014-01-30T17:14:46Z","html_url":"https://github.com/nilearn/nilearn/pull/157#discussion_r9313591","pull_request_url":"https://api.github.com/repos/nilearn/nilearn/pulls/157","_links":{"self":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/comments/9313591"},"html":{"href":"https://github.com/nilearn/nilearn/pull/157#discussion_r9313591"},"pull_request":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/157"}}}}