GitHub PullRequestReviewCommentEvent at 2014-09-04 21:20:59
Repository: s3test
Actor: michaeltandy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/michaeltandy/s3test/pulls/comments/17143217","id":17143217,"diff_hunk":"@@ -8,13 +8,22 @@\n import static org.junit.Assert.assertEquals;\n import static org.junit.Assert.assertNotNull;\n import static org.junit.Assert.fail;\n+\n+import org.junit.Before;\n import org.junit.Test;\n \n public class RejectBadKeyNamesTest extends BasicTestSuperclass {\n     \n     public RejectBadKeyNamesTest() {\n     }\n-    \n+\n+    @Override\n+    @Before\n+    public void setUp() throws Exception {\n+        super.setUp();\n+        createDefaultBucket();","path":"src/test/java/uk/me/mjt/s3test/RejectBadKeyNamesTest.java","position":18,"original_position":18,"commit_id":"266ef53133b817fb9a6cee8b08d0dfefda70c462","original_commit_id":"266ef53133b817fb9a6cee8b08d0dfefda70c462","user":{"login":"michaeltandy","id":2449410,"avatar_url":"https://avatars.githubusercontent.com/u/2449410?v=2","gravatar_id":"7167d2302007163407c44fdbb67e7358","url":"https://api.github.com/users/michaeltandy","html_url":"https://github.com/michaeltandy","followers_url":"https://api.github.com/users/michaeltandy/followers","following_url":"https://api.github.com/users/michaeltandy/following{/other_user}","gists_url":"https://api.github.com/users/michaeltandy/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltandy/subscriptions","organizations_url":"https://api.github.com/users/michaeltandy/orgs","repos_url":"https://api.github.com/users/michaeltandy/repos","events_url":"https://api.github.com/users/michaeltandy/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltandy/received_events","type":"User","site_admin":false},"body":"I delete the bucket before the test in ListBucketsTest.","created_at":"2014-09-04T21:20:59Z","updated_at":"2014-09-04T21:20:59Z","html_url":"https://github.com/michaeltandy/s3test/pull/1#discussion_r17143217","pull_request_url":"https://api.github.com/repos/michaeltandy/s3test/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/michaeltandy/s3test/pulls/comments/17143217"},"html":{"href":"https://github.com/michaeltandy/s3test/pull/1#discussion_r17143217"},"pull_request":{"href":"https://api.github.com/repos/michaeltandy/s3test/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/michaeltandy/s3test/pulls/1","id":20670389,"html_url":"https://github.com/michaeltandy/s3test/pull/1","diff_url":"https://github.com/michaeltandy/s3test/pull/1.diff","patch_url":"https://github.com/michaeltandy/s3test/pull/1.patch","issue_url":"https://api.github.com/repos/michaeltandy/s3test/issues/1","number":1,"state":"closed","locked":false,"title":"Error handling","user":{"login":"matthewhubble","id":7779758,"avatar_url":"https://avatars.githubusercontent.com/u/7779758?v=2","gravatar_id":"1c9123872806a3daaa42e6b7eddb5c1d","url":"https://api.github.com/users/matthewhubble","html_url":"https://github.com/matthewhubble","followers_url":"https://api.github.com/users/matthewhubble/followers","following_url":"https://api.github.com/users/matthewhubble/following{/other_user}","gists_url":"https://api.github.com/users/matthewhubble/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewhubble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewhubble/subscriptions","organizations_url":"https://api.github.com/users/matthewhubble/orgs","repos_url":"https://api.github.com/users/matthewhubble/repos","events_url":"https://api.github.com/users/matthewhubble/events{/privacy}","received_events_url":"https://api.github.com/users/matthewhubble/received_events","type":"User","site_admin":false},"body":" - Added more error handling and an error response helper class following the guidelines here: http://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html\r\n - Added list buckets and list objects functionality along with corresponding tests\r\n - Stopped S3Server from creating a default bucket all the time\r\n - Added .gitignore file\r\n - Added creation date to buckets\r\n - Added constants for HTTP methods and HTTP headers\r\n - Sped up the tests by removing unnecessary calls to Thread.sleep","created_at":"2014-09-03T11:26:03Z","updated_at":"2014-09-04T21:20:59Z","closed_at":"2014-09-03T21:29:31Z","merged_at":"2014-09-03T21:29:31Z","merge_commit_sha":"483e507b6d576adc3ed887bf2580bd19b5b3f1dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/michaeltandy/s3test/pulls/1/commits","review_comments_url":"https://api.github.com/repos/michaeltandy/s3test/pulls/1/comments","review_comment_url":"https://api.github.com/repos/michaeltandy/s3test/pulls/comments/{number}","comments_url":"https://api.github.com/repos/michaeltandy/s3test/issues/1/comments","statuses_url":"https://api.github.com/repos/michaeltandy/s3test/statuses/266ef53133b817fb9a6cee8b08d0dfefda70c462","head":{"label":"matthewhubble:error-handling","ref":"error-handling","sha":"266ef53133b817fb9a6cee8b08d0dfefda70c462","user":{"login":"matthewhubble","id":7779758,"avatar_url":"https://avatars.githubusercontent.com/u/7779758?v=2","gravatar_id":"1c9123872806a3daaa42e6b7eddb5c1d","url":"https://api.github.com/users/matthewhubble","html_url":"https://github.com/matthewhubble","followers_url":"https://api.github.com/users/matthewhubble/followers","following_url":"https://api.github.com/users/matthewhubble/following{/other_user}","gists_url":"https://api.github.com/users/matthewhubble/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewhubble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewhubble/subscriptions","organizations_url":"https://api.github.com/users/matthewhubble/orgs","repos_url":"https://api.github.com/users/matthewhubble/repos","events_url":"https://api.github.com/users/matthewhubble/events{/privacy}","received_events_url":"https://api.github.com/users/matthewhubble/received_events","type":"User","site_admin":false},"repo":{"id":23617488,"name":"s3test","full_name":"matthewhubble/s3test","owner":{"login":"matthewhubble","id":7779758,"avatar_url":"https://avatars.githubusercontent.com/u/7779758?v=2","gravatar_id":"1c9123872806a3daaa42e6b7eddb5c1d","url":"https://api.github.com/users/matthewhubble","html_url":"https://github.com/matthewhubble","followers_url":"https://api.github.com/users/matthewhubble/followers","following_url":"https://api.github.com/users/matthewhubble/following{/other_user}","gists_url":"https://api.github.com/users/matthewhubble/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewhubble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewhubble/subscriptions","organizations_url":"https://api.github.com/users/matthewhubble/orgs","repos_url":"https://api.github.com/users/matthewhubble/repos","events_url":"https://api.github.com/users/matthewhubble/events{/privacy}","received_events_url":"https://api.github.com/users/matthewhubble/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewhubble/s3test","description":"In memory S3 emulation, such as for unit testing.","fork":true,"url":"https://api.github.com/repos/matthewhubble/s3test","forks_url":"https://api.github.com/repos/matthewhubble/s3test/forks","keys_url":"https://api.github.com/repos/matthewhubble/s3test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewhubble/s3test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewhubble/s3test/teams","hooks_url":"https://api.github.com/repos/matthewhubble/s3test/hooks","issue_events_url":"https://api.github.com/repos/matthewhubble/s3test/issues/events{/number}","events_url":"https://api.github.com/repos/matthewhubble/s3test/events","assignees_url":"https://api.github.com/repos/matthewhubble/s3test/assignees{/user}","branches_url":"https://api.github.com/repos/matthewhubble/s3test/branches{/branch}","tags_url":"https://api.github.com/repos/matthewhubble/s3test/tags","blobs_url":"https://api.github.com/repos/matthewhubble/s3test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewhubble/s3test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewhubble/s3test/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewhubble/s3test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewhubble/s3test/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewhubble/s3test/languages","stargazers_url":"https://api.github.com/repos/matthewhubble/s3test/stargazers","contributors_url":"https://api.github.com/repos/matthewhubble/s3test/contributors","subscribers_url":"https://api.github.com/repos/matthewhubble/s3test/subscribers","subscription_url":"https://api.github.com/repos/matthewhubble/s3test/subscription","commits_url":"https://api.github.com/repos/matthewhubble/s3test/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewhubble/s3test/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewhubble/s3test/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewhubble/s3test/issues/comments/{number}","contents_url":"https://api.github.com/repos/matthewhubble/s3test/contents/{+path}","compare_url":"https://api.github.com/repos/matthewhubble/s3test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewhubble/s3test/merges","archive_url":"https://api.github.com/repos/matthewhubble/s3test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewhubble/s3test/downloads","issues_url":"https://api.github.com/repos/matthewhubble/s3test/issues{/number}","pulls_url":"https://api.github.com/repos/matthewhubble/s3test/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewhubble/s3test/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewhubble/s3test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewhubble/s3test/labels{/name}","releases_url":"https://api.github.com/repos/matthewhubble/s3test/releases{/id}","created_at":"2014-09-03T11:19:46Z","updated_at":"2014-09-03T11:19:13Z","pushed_at":"2014-09-04T21:19:05Z","git_url":"git://github.com/matthewhubble/s3test.git","ssh_url":"git@github.com:matthewhubble/s3test.git","clone_url":"https://github.com/matthewhubble/s3test.git","svn_url":"https://github.com/matthewhubble/s3test","homepage":"","size":111,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"michaeltandy:master","ref":"master","sha":"4827ada1f74c6f9d069af9a8fe2276c0d41be1b5","user":{"login":"michaeltandy","id":2449410,"avatar_url":"https://avatars.githubusercontent.com/u/2449410?v=2","gravatar_id":"7167d2302007163407c44fdbb67e7358","url":"https://api.github.com/users/michaeltandy","html_url":"https://github.com/michaeltandy","followers_url":"https://api.github.com/users/michaeltandy/followers","following_url":"https://api.github.com/users/michaeltandy/following{/other_user}","gists_url":"https://api.github.com/users/michaeltandy/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltandy/subscriptions","organizations_url":"https://api.github.com/users/michaeltandy/orgs","repos_url":"https://api.github.com/users/michaeltandy/repos","events_url":"https://api.github.com/users/michaeltandy/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltandy/received_events","type":"User","site_admin":false},"repo":{"id":22932893,"name":"s3test","full_name":"michaeltandy/s3test","owner":{"login":"michaeltandy","id":2449410,"avatar_url":"https://avatars.githubusercontent.com/u/2449410?v=2","gravatar_id":"7167d2302007163407c44fdbb67e7358","url":"https://api.github.com/users/michaeltandy","html_url":"https://github.com/michaeltandy","followers_url":"https://api.github.com/users/michaeltandy/followers","following_url":"https://api.github.com/users/michaeltandy/following{/other_user}","gists_url":"https://api.github.com/users/michaeltandy/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltandy/subscriptions","organizations_url":"https://api.github.com/users/michaeltandy/orgs","repos_url":"https://api.github.com/users/michaeltandy/repos","events_url":"https://api.github.com/users/michaeltandy/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltandy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaeltandy/s3test","description":"In memory S3 emulation, such as for unit testing.","fork":false,"url":"https://api.github.com/repos/michaeltandy/s3test","forks_url":"https://api.github.com/repos/michaeltandy/s3test/forks","keys_url":"https://api.github.com/repos/michaeltandy/s3test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaeltandy/s3test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaeltandy/s3test/teams","hooks_url":"https://api.github.com/repos/michaeltandy/s3test/hooks","issue_events_url":"https://api.github.com/repos/michaeltandy/s3test/issues/events{/number}","events_url":"https://api.github.com/repos/michaeltandy/s3test/events","assignees_url":"https://api.github.com/repos/michaeltandy/s3test/assignees{/user}","branches_url":"https://api.github.com/repos/michaeltandy/s3test/branches{/branch}","tags_url":"https://api.github.com/repos/michaeltandy/s3test/tags","blobs_url":"https://api.github.com/repos/michaeltandy/s3test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaeltandy/s3test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaeltandy/s3test/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaeltandy/s3test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaeltandy/s3test/statuses/{sha}","languages_url":"https://api.github.com/repos/michaeltandy/s3test/languages","stargazers_url":"https://api.github.com/repos/michaeltandy/s3test/stargazers","contributors_url":"https://api.github.com/repos/michaeltandy/s3test/contributors","subscribers_url":"https://api.github.com/repos/michaeltandy/s3test/subscribers","subscription_url":"https://api.github.com/repos/michaeltandy/s3test/subscription","commits_url":"https://api.github.com/repos/michaeltandy/s3test/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaeltandy/s3test/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaeltandy/s3test/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaeltandy/s3test/issues/comments/{number}","contents_url":"https://api.github.com/repos/michaeltandy/s3test/contents/{+path}","compare_url":"https://api.github.com/repos/michaeltandy/s3test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaeltandy/s3test/merges","archive_url":"https://api.github.com/repos/michaeltandy/s3test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaeltandy/s3test/downloads","issues_url":"https://api.github.com/repos/michaeltandy/s3test/issues{/number}","pulls_url":"https://api.github.com/repos/michaeltandy/s3test/pulls{/number}","milestones_url":"https://api.github.com/repos/michaeltandy/s3test/milestones{/number}","notifications_url":"https://api.github.com/repos/michaeltandy/s3test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaeltandy/s3test/labels{/name}","releases_url":"https://api.github.com/repos/michaeltandy/s3test/releases{/id}","created_at":"2014-08-13T22:09:10Z","updated_at":"2014-09-03T11:19:13Z","pushed_at":"2014-09-03T23:08:29Z","git_url":"git://github.com/michaeltandy/s3test.git","ssh_url":"git@github.com:michaeltandy/s3test.git","clone_url":"https://github.com/michaeltandy/s3test.git","svn_url":"https://github.com/michaeltandy/s3test","homepage":"","size":136,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/michaeltandy/s3test/pulls/1"},"html":{"href":"https://github.com/michaeltandy/s3test/pull/1"},"issue":{"href":"https://api.github.com/repos/michaeltandy/s3test/issues/1"},"comments":{"href":"https://api.github.com/repos/michaeltandy/s3test/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/michaeltandy/s3test/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/michaeltandy/s3test/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/michaeltandy/s3test/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/michaeltandy/s3test/statuses/266ef53133b817fb9a6cee8b08d0dfefda70c462"}}}}