GitHub PullRequestEvent at 2014-02-19 00:31:31
Repository: graphite
Actor: webframp
Payload: {"action":"closed","number":130,"pull_request":{"url":"https://api.github.com/repos/hw-cookbooks/graphite/pulls/130","id":11920719,"html_url":"https://github.com/hw-cookbooks/graphite/pull/130","diff_url":"https://github.com/hw-cookbooks/graphite/pull/130.diff","patch_url":"https://github.com/hw-cookbooks/graphite/pull/130.patch","issue_url":"https://api.github.com/repos/hw-cookbooks/graphite/issues/130","number":130,"state":"closed","title":"Added runit support for running multiple carbon-cache daemons","user":{"login":"nickryand","id":1466214,"avatar_url":"https://gravatar.com/avatar/dcc1ad428a5d5debf78d434013e32aa0?d=https%3A%2F%2Fidenticons.github.com%2Fc24ff7e779c5c6e3567ea89f70e21c61.png&r=x","gravatar_id":"dcc1ad428a5d5debf78d434013e32aa0","url":"https://api.github.com/users/nickryand","html_url":"https://github.com/nickryand","followers_url":"https://api.github.com/users/nickryand/followers","following_url":"https://api.github.com/users/nickryand/following{/other_user}","gists_url":"https://api.github.com/users/nickryand/gists{/gist_id}","starred_url":"https://api.github.com/users/nickryand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickryand/subscriptions","organizations_url":"https://api.github.com/users/nickryand/orgs","repos_url":"https://api.github.com/users/nickryand/repos","events_url":"https://api.github.com/users/nickryand/events{/privacy}","received_events_url":"https://api.github.com/users/nickryand/received_events","type":"User","site_admin":false},"body":"This allows runit to manage multiple carbon-cache daemons. I have included tests with this pull request to make it easier to verify. \r\n\r\nIt looks like some of the integration tests on master don't actually work. I could not get the CentOS-64 and Ubuntu 10.04 tests to work at all. I tested against the default-ubuntu-1204 and the carbon-cache-ubuntu-1204 tests. I did not clean up the other tests here because I did not want to muddy this pull request. \r\n\r\nI would love some feedback and a code review if someone has time.","created_at":"2014-01-27T21:16:48Z","updated_at":"2014-02-19T00:31:30Z","closed_at":"2014-02-19T00:31:30Z","merged_at":"2014-02-19T00:31:30Z","merge_commit_sha":"3181bbf956541c71a33b5f40bf47893d1ae06677","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hw-cookbooks/graphite/pulls/130/commits","review_comments_url":"https://api.github.com/repos/hw-cookbooks/graphite/pulls/130/comments","review_comment_url":"https://api.github.com/repos/hw-cookbooks/graphite/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hw-cookbooks/graphite/issues/130/comments","statuses_url":"https://api.github.com/repos/hw-cookbooks/graphite/statuses/f0efa340a4cc9aedcb6ea4158b76d98edc910f22","head":{"label":"nickryand:runit-multi-cache","ref":"runit-multi-cache","sha":"f0efa340a4cc9aedcb6ea4158b76d98edc910f22","user":{"login":"nickryand","id":1466214,"avatar_url":"https://gravatar.com/avatar/dcc1ad428a5d5debf78d434013e32aa0?d=https%3A%2F%2Fidenticons.github.com%2Fc24ff7e779c5c6e3567ea89f70e21c61.png&r=x","gravatar_id":"dcc1ad428a5d5debf78d434013e32aa0","url":"https://api.github.com/users/nickryand","html_url":"https://github.com/nickryand","followers_url":"https://api.github.com/users/nickryand/followers","following_url":"https://api.github.com/users/nickryand/following{/other_user}","gists_url":"https://api.github.com/users/nickryand/gists{/gist_id}","starred_url":"https://api.github.com/users/nickryand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickryand/subscriptions","organizations_url":"https://api.github.com/users/nickryand/orgs","repos_url":"https://api.github.com/users/nickryand/repos","events_url":"https://api.github.com/users/nickryand/events{/privacy}","received_events_url":"https://api.github.com/users/nickryand/received_events","type":"User","site_admin":false},"repo":{"id":16189795,"name":"graphite","full_name":"nickryand/graphite","owner":{"login":"nickryand","id":1466214,"avatar_url":"https://gravatar.com/avatar/dcc1ad428a5d5debf78d434013e32aa0?d=https%3A%2F%2Fidenticons.github.com%2Fc24ff7e779c5c6e3567ea89f70e21c61.png&r=x","gravatar_id":"dcc1ad428a5d5debf78d434013e32aa0","url":"https://api.github.com/users/nickryand","html_url":"https://github.com/nickryand","followers_url":"https://api.github.com/users/nickryand/followers","following_url":"https://api.github.com/users/nickryand/following{/other_user}","gists_url":"https://api.github.com/users/nickryand/gists{/gist_id}","starred_url":"https://api.github.com/users/nickryand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickryand/subscriptions","organizations_url":"https://api.github.com/users/nickryand/orgs","repos_url":"https://api.github.com/users/nickryand/repos","events_url":"https://api.github.com/users/nickryand/events{/privacy}","received_events_url":"https://api.github.com/users/nickryand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickryand/graphite","description":"Heavy Water Graphite Cookbook for Chef","fork":true,"url":"https://api.github.com/repos/nickryand/graphite","forks_url":"https://api.github.com/repos/nickryand/graphite/forks","keys_url":"https://api.github.com/repos/nickryand/graphite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickryand/graphite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickryand/graphite/teams","hooks_url":"https://api.github.com/repos/nickryand/graphite/hooks","issue_events_url":"https://api.github.com/repos/nickryand/graphite/issues/events{/number}","events_url":"https://api.github.com/repos/nickryand/graphite/events","assignees_url":"https://api.github.com/repos/nickryand/graphite/assignees{/user}","branches_url":"https://api.github.com/repos/nickryand/graphite/branches{/branch}","tags_url":"https://api.github.com/repos/nickryand/graphite/tags","blobs_url":"https://api.github.com/repos/nickryand/graphite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickryand/graphite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickryand/graphite/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickryand/graphite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickryand/graphite/statuses/{sha}","languages_url":"https://api.github.com/repos/nickryand/graphite/languages","stargazers_url":"https://api.github.com/repos/nickryand/graphite/stargazers","contributors_url":"https://api.github.com/repos/nickryand/graphite/contributors","subscribers_url":"https://api.github.com/repos/nickryand/graphite/subscribers","subscription_url":"https://api.github.com/repos/nickryand/graphite/subscription","commits_url":"https://api.github.com/repos/nickryand/graphite/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickryand/graphite/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickryand/graphite/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickryand/graphite/issues/comments/{number}","contents_url":"https://api.github.com/repos/nickryand/graphite/contents/{+path}","compare_url":"https://api.github.com/repos/nickryand/graphite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickryand/graphite/merges","archive_url":"https://api.github.com/repos/nickryand/graphite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickryand/graphite/downloads","issues_url":"https://api.github.com/repos/nickryand/graphite/issues{/number}","pulls_url":"https://api.github.com/repos/nickryand/graphite/pulls{/number}","milestones_url":"https://api.github.com/repos/nickryand/graphite/milestones{/number}","notifications_url":"https://api.github.com/repos/nickryand/graphite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickryand/graphite/labels{/name}","releases_url":"https://api.github.com/repos/nickryand/graphite/releases{/id}","created_at":"2014-01-23T23:52:59Z","updated_at":"2014-02-19T00:31:30Z","pushed_at":"2014-01-27T21:06:46Z","git_url":"git://github.com/nickryand/graphite.git","ssh_url":"git@github.com:nickryand/graphite.git","clone_url":"https://github.com/nickryand/graphite.git","svn_url":"https://github.com/nickryand/graphite","homepage":"","size":469,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"hw-cookbooks:master","ref":"master","sha":"111933a62c9d82c04987091d98bd347e1c6225a4","user":{"login":"hw-cookbooks","id":2170362,"avatar_url":"https://gravatar.com/avatar/66aefb7d37e3c4fae552c89d7cb56104?d=https%3A%2F%2Fidenticons.github.com%2F3d1dedd2c1f9844ef1235766be9b7059.png&r=x","gravatar_id":"66aefb7d37e3c4fae552c89d7cb56104","url":"https://api.github.com/users/hw-cookbooks","html_url":"https://github.com/hw-cookbooks","followers_url":"https://api.github.com/users/hw-cookbooks/followers","following_url":"https://api.github.com/users/hw-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/hw-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/hw-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hw-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/hw-cookbooks/orgs","repos_url":"https://api.github.com/users/hw-cookbooks/repos","events_url":"https://api.github.com/users/hw-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/hw-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":6119081,"name":"graphite","full_name":"hw-cookbooks/graphite","owner":{"login":"hw-cookbooks","id":2170362,"avatar_url":"https://gravatar.com/avatar/66aefb7d37e3c4fae552c89d7cb56104?d=https%3A%2F%2Fidenticons.github.com%2F3d1dedd2c1f9844ef1235766be9b7059.png&r=x","gravatar_id":"66aefb7d37e3c4fae552c89d7cb56104","url":"https://api.github.com/users/hw-cookbooks","html_url":"https://github.com/hw-cookbooks","followers_url":"https://api.github.com/users/hw-cookbooks/followers","following_url":"https://api.github.com/users/hw-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/hw-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/hw-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hw-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/hw-cookbooks/orgs","repos_url":"https://api.github.com/users/hw-cookbooks/repos","events_url":"https://api.github.com/users/hw-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/hw-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hw-cookbooks/graphite","description":"Heavy Water Graphite Cookbook for Chef","fork":false,"url":"https://api.github.com/repos/hw-cookbooks/graphite","forks_url":"https://api.github.com/repos/hw-cookbooks/graphite/forks","keys_url":"https://api.github.com/repos/hw-cookbooks/graphite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hw-cookbooks/graphite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hw-cookbooks/graphite/teams","hooks_url":"https://api.github.com/repos/hw-cookbooks/graphite/hooks","issue_events_url":"https://api.github.com/repos/hw-cookbooks/graphite/issues/events{/number}","events_url":"https://api.github.com/repos/hw-cookbooks/graphite/events","assignees_url":"https://api.github.com/repos/hw-cookbooks/graphite/assignees{/user}","branches_url":"https://api.github.com/repos/hw-cookbooks/graphite/branches{/branch}","tags_url":"https://api.github.com/repos/hw-cookbooks/graphite/tags","blobs_url":"https://api.github.com/repos/hw-cookbooks/graphite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hw-cookbooks/graphite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hw-cookbooks/graphite/git/refs{/sha}","trees_url":"https://api.github.com/repos/hw-cookbooks/graphite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hw-cookbooks/graphite/statuses/{sha}","languages_url":"https://api.github.com/repos/hw-cookbooks/graphite/languages","stargazers_url":"https://api.github.com/repos/hw-cookbooks/graphite/stargazers","contributors_url":"https://api.github.com/repos/hw-cookbooks/graphite/contributors","subscribers_url":"https://api.github.com/repos/hw-cookbooks/graphite/subscribers","subscription_url":"https://api.github.com/repos/hw-cookbooks/graphite/subscription","commits_url":"https://api.github.com/repos/hw-cookbooks/graphite/commits{/sha}","git_commits_url":"https://api.github.com/repos/hw-cookbooks/graphite/git/commits{/sha}","comments_url":"https://api.github.com/repos/hw-cookbooks/graphite/comments{/number}","issue_comment_url":"https://api.github.com/repos/hw-cookbooks/graphite/issues/comments/{number}","contents_url":"https://api.github.com/repos/hw-cookbooks/graphite/contents/{+path}","compare_url":"https://api.github.com/repos/hw-cookbooks/graphite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hw-cookbooks/graphite/merges","archive_url":"https://api.github.com/repos/hw-cookbooks/graphite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hw-cookbooks/graphite/downloads","issues_url":"https://api.github.com/repos/hw-cookbooks/graphite/issues{/number}","pulls_url":"https://api.github.com/repos/hw-cookbooks/graphite/pulls{/number}","milestones_url":"https://api.github.com/repos/hw-cookbooks/graphite/milestones{/number}","notifications_url":"https://api.github.com/repos/hw-cookbooks/graphite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hw-cookbooks/graphite/labels{/name}","releases_url":"https://api.github.com/repos/hw-cookbooks/graphite/releases{/id}","created_at":"2012-10-08T03:26:46Z","updated_at":"2014-02-19T00:31:30Z","pushed_at":"2014-02-19T00:31:31Z","git_url":"git://github.com/hw-cookbooks/graphite.git","ssh_url":"git@github.com:hw-cookbooks/graphite.git","clone_url":"https://github.com/hw-cookbooks/graphite.git","svn_url":"https://github.com/hw-cookbooks/graphite","homepage":"","size":1450,"stargazers_count":83,"watchers_count":83,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":136,"mirror_url":null,"open_issues_count":17,"forks":136,"open_issues":17,"watchers":83,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hw-cookbooks/graphite/pulls/130"},"html":{"href":"https://github.com/hw-cookbooks/graphite/pull/130"},"issue":{"href":"https://api.github.com/repos/hw-cookbooks/graphite/issues/130"},"comments":{"href":"https://api.github.com/repos/hw-cookbooks/graphite/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/hw-cookbooks/graphite/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/hw-cookbooks/graphite/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hw-cookbooks/graphite/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/hw-cookbooks/graphite/statuses/f0efa340a4cc9aedcb6ea4158b76d98edc910f22"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"webframp","id":774378,"avatar_url":"https://gravatar.com/avatar/e0c4440e6f2306778e385a35d9347f25?d=https%3A%2F%2Fidenticons.github.com%2F599ea6f1409faa3663077cb1a3e9e70b.png&r=x","gravatar_id":"e0c4440e6f2306778e385a35d9347f25","url":"https://api.github.com/users/webframp","html_url":"https://github.com/webframp","followers_url":"https://api.github.com/users/webframp/followers","following_url":"https://api.github.com/users/webframp/following{/other_user}","gists_url":"https://api.github.com/users/webframp/gists{/gist_id}","starred_url":"https://api.github.com/users/webframp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webframp/subscriptions","organizations_url":"https://api.github.com/users/webframp/orgs","repos_url":"https://api.github.com/users/webframp/repos","events_url":"https://api.github.com/users/webframp/events{/privacy}","received_events_url":"https://api.github.com/users/webframp/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":293,"deletions":19,"changed_files":12}}