GitHub PullRequestReviewCommentEvent at 2014-08-02 17:59:51
Repository: community
Actor: davidbalbert
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hackerschool/community/pulls/comments/15730349","id":15730349,"diff_hunk":"@@ -0,0 +1,13 @@\n+module SecureEquals\n+  def self.secure_equals(first, second)\n+    return false if first.nil? || second.nil? || first.size != second.size","path":"app/services/secure_equals.rb","position":3,"original_position":3,"commit_id":"984abe825210ee3fd2cb1e6c49ece1da724452ce","original_commit_id":"984abe825210ee3fd2cb1e6c49ece1da724452ce","user":{"login":"davidbalbert","id":123350,"avatar_url":"https://avatars.githubusercontent.com/u/123350?v=1","gravatar_id":"378ba200016630f4a3335c8c1707502a","url":"https://api.github.com/users/davidbalbert","html_url":"https://github.com/davidbalbert","followers_url":"https://api.github.com/users/davidbalbert/followers","following_url":"https://api.github.com/users/davidbalbert/following{/other_user}","gists_url":"https://api.github.com/users/davidbalbert/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbalbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbalbert/subscriptions","organizations_url":"https://api.github.com/users/davidbalbert/orgs","repos_url":"https://api.github.com/users/davidbalbert/repos","events_url":"https://api.github.com/users/davidbalbert/events{/privacy}","received_events_url":"https://api.github.com/users/davidbalbert/received_events","type":"User","site_admin":false},"body":"My mistake here, but `size` should be `bytesize`","created_at":"2014-08-02T17:59:51Z","updated_at":"2014-08-02T17:59:51Z","html_url":"https://github.com/hackerschool/community/pull/116#discussion_r15730349","pull_request_url":"https://api.github.com/repos/hackerschool/community/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/hackerschool/community/pulls/comments/15730349"},"html":{"href":"https://github.com/hackerschool/community/pull/116#discussion_r15730349"},"pull_request":{"href":"https://api.github.com/repos/hackerschool/community/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/hackerschool/community/pulls/116","id":19241325,"html_url":"https://github.com/hackerschool/community/pull/116","diff_url":"https://github.com/hackerschool/community/pull/116.diff","patch_url":"https://github.com/hackerschool/community/pull/116.patch","issue_url":"https://api.github.com/repos/hackerschool/community/issues/116","number":116,"state":"open","title":"Fix email replies","user":{"login":"zachallaun","id":503938,"avatar_url":"https://avatars.githubusercontent.com/u/503938?v=1","gravatar_id":"06625cbad0c69f5c2e673a4312e9fd7e","url":"https://api.github.com/users/zachallaun","html_url":"https://github.com/zachallaun","followers_url":"https://api.github.com/users/zachallaun/followers","following_url":"https://api.github.com/users/zachallaun/following{/other_user}","gists_url":"https://api.github.com/users/zachallaun/gists{/gist_id}","starred_url":"https://api.github.com/users/zachallaun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachallaun/subscriptions","organizations_url":"https://api.github.com/users/zachallaun/orgs","repos_url":"https://api.github.com/users/zachallaun/repos","events_url":"https://api.github.com/users/zachallaun/events{/privacy}","received_events_url":"https://api.github.com/users/zachallaun/received_events","type":"User","site_admin":false},"body":"This fixes two bugs:\r\n\r\n1. Mailgun recipient variables weren't matching up with the To fields because the recipient keys were email addresses and the To fields included display names (`zach@hackerschool.com` vs. `Zach <zach@hackerschool.com>`). The fix for this (for now) was to go back to just email addresses in the To fields.\r\n\r\n2. Replying didn't work depending on your email client because `reply_info` was case-sensitive (base 64 encoded), but email addresses are not. Gmail would keep the case, but Airmail downcased everything, meaning I couldn't reply. The fix for this is to switch to a case-insensitive `ReplyInfoVerifier` that doesn't base 64 encode the serialized data.","created_at":"2014-08-02T01:07:10Z","updated_at":"2014-08-02T17:59:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d4c2fc510c63c06bcd1f04f56a88a7952124e6d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hackerschool/community/pulls/116/commits","review_comments_url":"https://api.github.com/repos/hackerschool/community/pulls/116/comments","review_comment_url":"https://api.github.com/repos/hackerschool/community/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hackerschool/community/issues/116/comments","statuses_url":"https://api.github.com/repos/hackerschool/community/statuses/984abe825210ee3fd2cb1e6c49ece1da724452ce","head":{"label":"hackerschool:fix-email-replies","ref":"fix-email-replies","sha":"984abe825210ee3fd2cb1e6c49ece1da724452ce","user":{"login":"hackerschool","id":1085202,"avatar_url":"https://avatars.githubusercontent.com/u/1085202?v=1","gravatar_id":"588308d511de92d8e642da998cdc5d06","url":"https://api.github.com/users/hackerschool","html_url":"https://github.com/hackerschool","followers_url":"https://api.github.com/users/hackerschool/followers","following_url":"https://api.github.com/users/hackerschool/following{/other_user}","gists_url":"https://api.github.com/users/hackerschool/gists{/gist_id}","starred_url":"https://api.github.com/users/hackerschool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackerschool/subscriptions","organizations_url":"https://api.github.com/users/hackerschool/orgs","repos_url":"https://api.github.com/users/hackerschool/repos","events_url":"https://api.github.com/users/hackerschool/events{/privacy}","received_events_url":"https://api.github.com/users/hackerschool/received_events","type":"Organization","site_admin":false},"repo":{"id":19648077,"name":"community","full_name":"hackerschool/community","owner":{"login":"hackerschool","id":1085202,"avatar_url":"https://avatars.githubusercontent.com/u/1085202?v=1","gravatar_id":"588308d511de92d8e642da998cdc5d06","url":"https://api.github.com/users/hackerschool","html_url":"https://github.com/hackerschool","followers_url":"https://api.github.com/users/hackerschool/followers","following_url":"https://api.github.com/users/hackerschool/following{/other_user}","gists_url":"https://api.github.com/users/hackerschool/gists{/gist_id}","starred_url":"https://api.github.com/users/hackerschool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackerschool/subscriptions","organizations_url":"https://api.github.com/users/hackerschool/orgs","repos_url":"https://api.github.com/users/hackerschool/repos","events_url":"https://api.github.com/users/hackerschool/events{/privacy}","received_events_url":"https://api.github.com/users/hackerschool/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hackerschool/community","description":"community.hackerschool.com","fork":false,"url":"https://api.github.com/repos/hackerschool/community","forks_url":"https://api.github.com/repos/hackerschool/community/forks","keys_url":"https://api.github.com/repos/hackerschool/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hackerschool/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hackerschool/community/teams","hooks_url":"https://api.github.com/repos/hackerschool/community/hooks","issue_events_url":"https://api.github.com/repos/hackerschool/community/issues/events{/number}","events_url":"https://api.github.com/repos/hackerschool/community/events","assignees_url":"https://api.github.com/repos/hackerschool/community/assignees{/user}","branches_url":"https://api.github.com/repos/hackerschool/community/branches{/branch}","tags_url":"https://api.github.com/repos/hackerschool/community/tags","blobs_url":"https://api.github.com/repos/hackerschool/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hackerschool/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hackerschool/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/hackerschool/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hackerschool/community/statuses/{sha}","languages_url":"https://api.github.com/repos/hackerschool/community/languages","stargazers_url":"https://api.github.com/repos/hackerschool/community/stargazers","contributors_url":"https://api.github.com/repos/hackerschool/community/contributors","subscribers_url":"https://api.github.com/repos/hackerschool/community/subscribers","subscription_url":"https://api.github.com/repos/hackerschool/community/subscription","commits_url":"https://api.github.com/repos/hackerschool/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/hackerschool/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/hackerschool/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/hackerschool/community/issues/comments/{number}","contents_url":"https://api.github.com/repos/hackerschool/community/contents/{+path}","compare_url":"https://api.github.com/repos/hackerschool/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hackerschool/community/merges","archive_url":"https://api.github.com/repos/hackerschool/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hackerschool/community/downloads","issues_url":"https://api.github.com/repos/hackerschool/community/issues{/number}","pulls_url":"https://api.github.com/repos/hackerschool/community/pulls{/number}","milestones_url":"https://api.github.com/repos/hackerschool/community/milestones{/number}","notifications_url":"https://api.github.com/repos/hackerschool/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hackerschool/community/labels{/name}","releases_url":"https://api.github.com/repos/hackerschool/community/releases{/id}","created_at":"2014-05-10T17:51:10Z","updated_at":"2014-08-01T04:22:15Z","pushed_at":"2014-08-02T01:03:21Z","git_url":"git://github.com/hackerschool/community.git","ssh_url":"git@github.com:hackerschool/community.git","clone_url":"https://github.com/hackerschool/community.git","svn_url":"https://github.com/hackerschool/community","homepage":null,"size":9997,"stargazers_count":19,"watchers_count":19,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":59,"forks":7,"open_issues":59,"watchers":19,"default_branch":"master"}},"base":{"label":"hackerschool:master","ref":"master","sha":"6fb479b95b8f64e5e12dcfde9f00f1da8800ba03","user":{"login":"hackerschool","id":1085202,"avatar_url":"https://avatars.githubusercontent.com/u/1085202?v=1","gravatar_id":"588308d511de92d8e642da998cdc5d06","url":"https://api.github.com/users/hackerschool","html_url":"https://github.com/hackerschool","followers_url":"https://api.github.com/users/hackerschool/followers","following_url":"https://api.github.com/users/hackerschool/following{/other_user}","gists_url":"https://api.github.com/users/hackerschool/gists{/gist_id}","starred_url":"https://api.github.com/users/hackerschool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackerschool/subscriptions","organizations_url":"https://api.github.com/users/hackerschool/orgs","repos_url":"https://api.github.com/users/hackerschool/repos","events_url":"https://api.github.com/users/hackerschool/events{/privacy}","received_events_url":"https://api.github.com/users/hackerschool/received_events","type":"Organization","site_admin":false},"repo":{"id":19648077,"name":"community","full_name":"hackerschool/community","owner":{"login":"hackerschool","id":1085202,"avatar_url":"https://avatars.githubusercontent.com/u/1085202?v=1","gravatar_id":"588308d511de92d8e642da998cdc5d06","url":"https://api.github.com/users/hackerschool","html_url":"https://github.com/hackerschool","followers_url":"https://api.github.com/users/hackerschool/followers","following_url":"https://api.github.com/users/hackerschool/following{/other_user}","gists_url":"https://api.github.com/users/hackerschool/gists{/gist_id}","starred_url":"https://api.github.com/users/hackerschool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackerschool/subscriptions","organizations_url":"https://api.github.com/users/hackerschool/orgs","repos_url":"https://api.github.com/users/hackerschool/repos","events_url":"https://api.github.com/users/hackerschool/events{/privacy}","received_events_url":"https://api.github.com/users/hackerschool/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hackerschool/community","description":"community.hackerschool.com","fork":false,"url":"https://api.github.com/repos/hackerschool/community","forks_url":"https://api.github.com/repos/hackerschool/community/forks","keys_url":"https://api.github.com/repos/hackerschool/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hackerschool/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hackerschool/community/teams","hooks_url":"https://api.github.com/repos/hackerschool/community/hooks","issue_events_url":"https://api.github.com/repos/hackerschool/community/issues/events{/number}","events_url":"https://api.github.com/repos/hackerschool/community/events","assignees_url":"https://api.github.com/repos/hackerschool/community/assignees{/user}","branches_url":"https://api.github.com/repos/hackerschool/community/branches{/branch}","tags_url":"https://api.github.com/repos/hackerschool/community/tags","blobs_url":"https://api.github.com/repos/hackerschool/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hackerschool/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hackerschool/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/hackerschool/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hackerschool/community/statuses/{sha}","languages_url":"https://api.github.com/repos/hackerschool/community/languages","stargazers_url":"https://api.github.com/repos/hackerschool/community/stargazers","contributors_url":"https://api.github.com/repos/hackerschool/community/contributors","subscribers_url":"https://api.github.com/repos/hackerschool/community/subscribers","subscription_url":"https://api.github.com/repos/hackerschool/community/subscription","commits_url":"https://api.github.com/repos/hackerschool/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/hackerschool/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/hackerschool/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/hackerschool/community/issues/comments/{number}","contents_url":"https://api.github.com/repos/hackerschool/community/contents/{+path}","compare_url":"https://api.github.com/repos/hackerschool/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hackerschool/community/merges","archive_url":"https://api.github.com/repos/hackerschool/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hackerschool/community/downloads","issues_url":"https://api.github.com/repos/hackerschool/community/issues{/number}","pulls_url":"https://api.github.com/repos/hackerschool/community/pulls{/number}","milestones_url":"https://api.github.com/repos/hackerschool/community/milestones{/number}","notifications_url":"https://api.github.com/repos/hackerschool/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hackerschool/community/labels{/name}","releases_url":"https://api.github.com/repos/hackerschool/community/releases{/id}","created_at":"2014-05-10T17:51:10Z","updated_at":"2014-08-01T04:22:15Z","pushed_at":"2014-08-02T01:03:21Z","git_url":"git://github.com/hackerschool/community.git","ssh_url":"git@github.com:hackerschool/community.git","clone_url":"https://github.com/hackerschool/community.git","svn_url":"https://github.com/hackerschool/community","homepage":null,"size":9997,"stargazers_count":19,"watchers_count":19,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":59,"forks":7,"open_issues":59,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hackerschool/community/pulls/116"},"html":{"href":"https://github.com/hackerschool/community/pull/116"},"issue":{"href":"https://api.github.com/repos/hackerschool/community/issues/116"},"comments":{"href":"https://api.github.com/repos/hackerschool/community/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/hackerschool/community/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/hackerschool/community/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hackerschool/community/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/hackerschool/community/statuses/984abe825210ee3fd2cb1e6c49ece1da724452ce"}}}}