GitHub PullRequestReviewCommentEvent at 2014-11-08 23:37:55
Repository: ramda
Actor: CrossEye
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ramda/ramda/pulls/comments/20055349","id":20055349,"diff_hunk":"@@ -3563,15 +3563,64 @@\n      * @memberOf R\n      * @see R.prop\n      * @category Object\n-     * @sig {s: a} -> s -> a\n+     * @sig {k: v} -> k -> v\n      * @param {Object} obj The object to query\n-     * @param {String} prop The property name\n+     * @param {String} p The property name\n      * @return {*} The value at obj.p\n      * @example\n      *\n-     *      R.props({x: 100}, 'x'); //=> 100\n+     *      R.propOf({x: 100}, 'x'); //=> 100\n      */\n-    R.props = flip(R.prop);\n+    R.propOf = flip(R.prop);\n+\n+\n+    /**\n+     * @func\n+     * @memberOf R\n+     * @category Object\n+     * @see R.propOf\n+     */\n+    R.getOf = R.propOf;\n+\n+\n+    /**\n+     * Acts as multiple `get`: array of keys in, array of values out. Preserves order.\n+     *\n+     * @func\n+     * @memberOf R\n+     * @category Object\n+     * @sig [k] -> {k: v} -> [v]\n+     * @param {String[]} props The property names to fetch\n+     * @param {Object} obj The object to query\n+     * @return {*[]|Function} The corresponding values or partially applied function\n+     * @example\n+     *\n+     *      R.prop('x', {x: 100}); //=> 100\n+     *      R.prop('x', {}); //=> undefined\n+     *\n+     *      var fifth = R.prop(4); // indexed from 0, remember\n+     *      fifth(['Bashful', 'Doc', 'Dopey', 'Grumpy', 'Happy', 'Sleepy', 'Sneezy']);\n+     *      //=> 'Happy'\n+     */\n+    R.props = function(props, obj) {\n+        function _props(obj) {\n+            var out = [],\n+                idx, len;\n+\n+            for (idx = 0, len = props.length; idx < len; idx++) {","path":"ramda.js","position":52,"original_position":52,"commit_id":"fa7c329f1421b554e0e0323ccf8e72d911af53dd","original_commit_id":"fa7c329f1421b554e0e0323ccf8e72d911af53dd","user":{"login":"CrossEye","id":151263,"avatar_url":"https://avatars.githubusercontent.com/u/151263?v=3","gravatar_id":"","url":"https://api.github.com/users/CrossEye","html_url":"https://github.com/CrossEye","followers_url":"https://api.github.com/users/CrossEye/followers","following_url":"https://api.github.com/users/CrossEye/following{/other_user}","gists_url":"https://api.github.com/users/CrossEye/gists{/gist_id}","starred_url":"https://api.github.com/users/CrossEye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CrossEye/subscriptions","organizations_url":"https://api.github.com/users/CrossEye/orgs","repos_url":"https://api.github.com/users/CrossEye/repos","events_url":"https://api.github.com/users/CrossEye/events{/privacy}","received_events_url":"https://api.github.com/users/CrossEye/received_events","type":"User","site_admin":false},"body":"I think it's necessary to change it.  I don't think I hate them as much as you do, but I was the one who stared using `while`, and it's become the house style.  I see no reason to start mixing and matching.","created_at":"2014-11-08T23:37:55Z","updated_at":"2014-11-08T23:37:55Z","html_url":"https://github.com/ramda/ramda/pull/501#discussion_r20055349","pull_request_url":"https://api.github.com/repos/ramda/ramda/pulls/501","_links":{"self":{"href":"https://api.github.com/repos/ramda/ramda/pulls/comments/20055349"},"html":{"href":"https://github.com/ramda/ramda/pull/501#discussion_r20055349"},"pull_request":{"href":"https://api.github.com/repos/ramda/ramda/pulls/501"}}},"pull_request":{"url":"https://api.github.com/repos/ramda/ramda/pulls/501","id":24105332,"html_url":"https://github.com/ramda/ramda/pull/501","diff_url":"https://github.com/ramda/ramda/pull/501.diff","patch_url":"https://github.com/ramda/ramda/pull/501.patch","issue_url":"https://api.github.com/repos/ramda/ramda/issues/501","number":501,"state":"open","locked":false,"title":"Renamed `props` to `propOf`, reimplemented `props` as multiple `prop`","user":{"login":"anton-rudeshko","id":1444210,"avatar_url":"https://avatars.githubusercontent.com/u/1444210?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-rudeshko","html_url":"https://github.com/anton-rudeshko","followers_url":"https://api.github.com/users/anton-rudeshko/followers","following_url":"https://api.github.com/users/anton-rudeshko/following{/other_user}","gists_url":"https://api.github.com/users/anton-rudeshko/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-rudeshko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-rudeshko/subscriptions","organizations_url":"https://api.github.com/users/anton-rudeshko/orgs","repos_url":"https://api.github.com/users/anton-rudeshko/repos","events_url":"https://api.github.com/users/anton-rudeshko/events{/privacy}","received_events_url":"https://api.github.com/users/anton-rudeshko/received_events","type":"User","site_admin":false},"body":"Closes #499.","created_at":"2014-11-08T19:47:56Z","updated_at":"2014-11-08T23:37:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e32eb94f18d457d0486fc6774cf2c73e8ebdabb8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ramda/ramda/pulls/501/commits","review_comments_url":"https://api.github.com/repos/ramda/ramda/pulls/501/comments","review_comment_url":"https://api.github.com/repos/ramda/ramda/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ramda/ramda/issues/501/comments","statuses_url":"https://api.github.com/repos/ramda/ramda/statuses/fa7c329f1421b554e0e0323ccf8e72d911af53dd","head":{"label":"anton-rudeshko:props","ref":"props","sha":"fa7c329f1421b554e0e0323ccf8e72d911af53dd","user":{"login":"anton-rudeshko","id":1444210,"avatar_url":"https://avatars.githubusercontent.com/u/1444210?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-rudeshko","html_url":"https://github.com/anton-rudeshko","followers_url":"https://api.github.com/users/anton-rudeshko/followers","following_url":"https://api.github.com/users/anton-rudeshko/following{/other_user}","gists_url":"https://api.github.com/users/anton-rudeshko/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-rudeshko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-rudeshko/subscriptions","organizations_url":"https://api.github.com/users/anton-rudeshko/orgs","repos_url":"https://api.github.com/users/anton-rudeshko/repos","events_url":"https://api.github.com/users/anton-rudeshko/events{/privacy}","received_events_url":"https://api.github.com/users/anton-rudeshko/received_events","type":"User","site_admin":false},"repo":{"id":24235294,"name":"ramda","full_name":"anton-rudeshko/ramda","owner":{"login":"anton-rudeshko","id":1444210,"avatar_url":"https://avatars.githubusercontent.com/u/1444210?v=3","gravatar_id":"","url":"https://api.github.com/users/anton-rudeshko","html_url":"https://github.com/anton-rudeshko","followers_url":"https://api.github.com/users/anton-rudeshko/followers","following_url":"https://api.github.com/users/anton-rudeshko/following{/other_user}","gists_url":"https://api.github.com/users/anton-rudeshko/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-rudeshko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-rudeshko/subscriptions","organizations_url":"https://api.github.com/users/anton-rudeshko/orgs","repos_url":"https://api.github.com/users/anton-rudeshko/repos","events_url":"https://api.github.com/users/anton-rudeshko/events{/privacy}","received_events_url":"https://api.github.com/users/anton-rudeshko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anton-rudeshko/ramda","description":"","fork":true,"url":"https://api.github.com/repos/anton-rudeshko/ramda","forks_url":"https://api.github.com/repos/anton-rudeshko/ramda/forks","keys_url":"https://api.github.com/repos/anton-rudeshko/ramda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anton-rudeshko/ramda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anton-rudeshko/ramda/teams","hooks_url":"https://api.github.com/repos/anton-rudeshko/ramda/hooks","issue_events_url":"https://api.github.com/repos/anton-rudeshko/ramda/issues/events{/number}","events_url":"https://api.github.com/repos/anton-rudeshko/ramda/events","assignees_url":"https://api.github.com/repos/anton-rudeshko/ramda/assignees{/user}","branches_url":"https://api.github.com/repos/anton-rudeshko/ramda/branches{/branch}","tags_url":"https://api.github.com/repos/anton-rudeshko/ramda/tags","blobs_url":"https://api.github.com/repos/anton-rudeshko/ramda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anton-rudeshko/ramda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anton-rudeshko/ramda/git/refs{/sha}","trees_url":"https://api.github.com/repos/anton-rudeshko/ramda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anton-rudeshko/ramda/statuses/{sha}","languages_url":"https://api.github.com/repos/anton-rudeshko/ramda/languages","stargazers_url":"https://api.github.com/repos/anton-rudeshko/ramda/stargazers","contributors_url":"https://api.github.com/repos/anton-rudeshko/ramda/contributors","subscribers_url":"https://api.github.com/repos/anton-rudeshko/ramda/subscribers","subscription_url":"https://api.github.com/repos/anton-rudeshko/ramda/subscription","commits_url":"https://api.github.com/repos/anton-rudeshko/ramda/commits{/sha}","git_commits_url":"https://api.github.com/repos/anton-rudeshko/ramda/git/commits{/sha}","comments_url":"https://api.github.com/repos/anton-rudeshko/ramda/comments{/number}","issue_comment_url":"https://api.github.com/repos/anton-rudeshko/ramda/issues/comments/{number}","contents_url":"https://api.github.com/repos/anton-rudeshko/ramda/contents/{+path}","compare_url":"https://api.github.com/repos/anton-rudeshko/ramda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anton-rudeshko/ramda/merges","archive_url":"https://api.github.com/repos/anton-rudeshko/ramda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anton-rudeshko/ramda/downloads","issues_url":"https://api.github.com/repos/anton-rudeshko/ramda/issues{/number}","pulls_url":"https://api.github.com/repos/anton-rudeshko/ramda/pulls{/number}","milestones_url":"https://api.github.com/repos/anton-rudeshko/ramda/milestones{/number}","notifications_url":"https://api.github.com/repos/anton-rudeshko/ramda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anton-rudeshko/ramda/labels{/name}","releases_url":"https://api.github.com/repos/anton-rudeshko/ramda/releases{/id}","created_at":"2014-09-19T15:36:00Z","updated_at":"2014-09-27T13:51:16Z","pushed_at":"2014-11-08T19:47:31Z","git_url":"git://github.com/anton-rudeshko/ramda.git","ssh_url":"git@github.com:anton-rudeshko/ramda.git","clone_url":"https://github.com/anton-rudeshko/ramda.git","svn_url":"https://github.com/anton-rudeshko/ramda","homepage":null,"size":2834,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ramda:master","ref":"master","sha":"e4937800d3489a890468e713bef30b7c7ac6ae1e","user":{"login":"ramda","id":5298359,"avatar_url":"https://avatars.githubusercontent.com/u/5298359?v=3","gravatar_id":"","url":"https://api.github.com/users/ramda","html_url":"https://github.com/ramda","followers_url":"https://api.github.com/users/ramda/followers","following_url":"https://api.github.com/users/ramda/following{/other_user}","gists_url":"https://api.github.com/users/ramda/gists{/gist_id}","starred_url":"https://api.github.com/users/ramda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramda/subscriptions","organizations_url":"https://api.github.com/users/ramda/orgs","repos_url":"https://api.github.com/users/ramda/repos","events_url":"https://api.github.com/users/ramda/events{/privacy}","received_events_url":"https://api.github.com/users/ramda/received_events","type":"Organization","site_admin":false},"repo":{"id":10851820,"name":"ramda","full_name":"ramda/ramda","owner":{"login":"ramda","id":5298359,"avatar_url":"https://avatars.githubusercontent.com/u/5298359?v=3","gravatar_id":"","url":"https://api.github.com/users/ramda","html_url":"https://github.com/ramda","followers_url":"https://api.github.com/users/ramda/followers","following_url":"https://api.github.com/users/ramda/following{/other_user}","gists_url":"https://api.github.com/users/ramda/gists{/gist_id}","starred_url":"https://api.github.com/users/ramda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramda/subscriptions","organizations_url":"https://api.github.com/users/ramda/orgs","repos_url":"https://api.github.com/users/ramda/repos","events_url":"https://api.github.com/users/ramda/events{/privacy}","received_events_url":"https://api.github.com/users/ramda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ramda/ramda","description":"Practical functional Javascript","fork":false,"url":"https://api.github.com/repos/ramda/ramda","forks_url":"https://api.github.com/repos/ramda/ramda/forks","keys_url":"https://api.github.com/repos/ramda/ramda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramda/ramda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramda/ramda/teams","hooks_url":"https://api.github.com/repos/ramda/ramda/hooks","issue_events_url":"https://api.github.com/repos/ramda/ramda/issues/events{/number}","events_url":"https://api.github.com/repos/ramda/ramda/events","assignees_url":"https://api.github.com/repos/ramda/ramda/assignees{/user}","branches_url":"https://api.github.com/repos/ramda/ramda/branches{/branch}","tags_url":"https://api.github.com/repos/ramda/ramda/tags","blobs_url":"https://api.github.com/repos/ramda/ramda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramda/ramda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramda/ramda/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramda/ramda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramda/ramda/statuses/{sha}","languages_url":"https://api.github.com/repos/ramda/ramda/languages","stargazers_url":"https://api.github.com/repos/ramda/ramda/stargazers","contributors_url":"https://api.github.com/repos/ramda/ramda/contributors","subscribers_url":"https://api.github.com/repos/ramda/ramda/subscribers","subscription_url":"https://api.github.com/repos/ramda/ramda/subscription","commits_url":"https://api.github.com/repos/ramda/ramda/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramda/ramda/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramda/ramda/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramda/ramda/issues/comments/{number}","contents_url":"https://api.github.com/repos/ramda/ramda/contents/{+path}","compare_url":"https://api.github.com/repos/ramda/ramda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramda/ramda/merges","archive_url":"https://api.github.com/repos/ramda/ramda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramda/ramda/downloads","issues_url":"https://api.github.com/repos/ramda/ramda/issues{/number}","pulls_url":"https://api.github.com/repos/ramda/ramda/pulls{/number}","milestones_url":"https://api.github.com/repos/ramda/ramda/milestones{/number}","notifications_url":"https://api.github.com/repos/ramda/ramda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramda/ramda/labels{/name}","releases_url":"https://api.github.com/repos/ramda/ramda/releases{/id}","created_at":"2013-06-21T20:32:35Z","updated_at":"2014-11-08T22:48:36Z","pushed_at":"2014-11-06T01:20:23Z","git_url":"git://github.com/ramda/ramda.git","ssh_url":"git@github.com:ramda/ramda.git","clone_url":"https://github.com/ramda/ramda.git","svn_url":"https://github.com/ramda/ramda","homepage":"http://ramdajs.com","size":9704,"stargazers_count":962,"watchers_count":962,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":22,"forks":68,"open_issues":22,"watchers":962,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ramda/ramda/pulls/501"},"html":{"href":"https://github.com/ramda/ramda/pull/501"},"issue":{"href":"https://api.github.com/repos/ramda/ramda/issues/501"},"comments":{"href":"https://api.github.com/repos/ramda/ramda/issues/501/comments"},"review_comments":{"href":"https://api.github.com/repos/ramda/ramda/pulls/501/comments"},"review_comment":{"href":"https://api.github.com/repos/ramda/ramda/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ramda/ramda/pulls/501/commits"},"statuses":{"href":"https://api.github.com/repos/ramda/ramda/statuses/fa7c329f1421b554e0e0323ccf8e72d911af53dd"}}}}