GitHub PullRequestReviewCommentEvent at 2014-08-20 18:15:56
Repository: chef-splunk
Actor: igarrison
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls/comments/16493937","id":16493937,"diff_hunk":"@@ -0,0 +1,17 @@\n+require 'spec_helper'\n+\n+describe 'chef-splunk::server should run as \"splunk\" user' do\n+  describe command('ps aux | grep \"splunkd -p\" | head -1 | awk \\'{print $1}\\'') do\n+    it { should return_stdout 'splunk' }\n+  end\n+\n+  #describe file('/opt/splunk/var/log') do\n+  #  it { should be_owned_by 'splunk' }\n+  #end","path":"test/integration/server/serverspec/server_spec.rb","position":10,"original_position":10,"commit_id":"08018b78be71ec9cd724d115138f8e2ee4e766e9","original_commit_id":"08018b78be71ec9cd724d115138f8e2ee4e766e9","user":{"login":"igarrison","id":1414169,"avatar_url":"https://avatars.githubusercontent.com/u/1414169?v=2","gravatar_id":"9305860bcc93a967d3a0fbb6cf7bbbb7","url":"https://api.github.com/users/igarrison","html_url":"https://github.com/igarrison","followers_url":"https://api.github.com/users/igarrison/followers","following_url":"https://api.github.com/users/igarrison/following{/other_user}","gists_url":"https://api.github.com/users/igarrison/gists{/gist_id}","starred_url":"https://api.github.com/users/igarrison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igarrison/subscriptions","organizations_url":"https://api.github.com/users/igarrison/orgs","repos_url":"https://api.github.com/users/igarrison/repos","events_url":"https://api.github.com/users/igarrison/events{/privacy}","received_events_url":"https://api.github.com/users/igarrison/received_events","type":"User","site_admin":false},"body":"Deleted this test, sorry.  Initially I was thinking we would check file permissions on something, but if a splunk process is running as the expected user (another test) then likely that couldn't happen unless splunk file/dir permissions are healthy enough for the service to start.","created_at":"2014-08-20T18:15:56Z","updated_at":"2014-08-20T18:15:56Z","html_url":"https://github.com/opscode-cookbooks/chef-splunk/pull/14#discussion_r16493937","pull_request_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls/comments/16493937"},"html":{"href":"https://github.com/opscode-cookbooks/chef-splunk/pull/14#discussion_r16493937"},"pull_request":{"href":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls/14","id":18724357,"html_url":"https://github.com/opscode-cookbooks/chef-splunk/pull/14","diff_url":"https://github.com/opscode-cookbooks/chef-splunk/pull/14.diff","patch_url":"https://github.com/opscode-cookbooks/chef-splunk/pull/14.patch","issue_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/issues/14","number":14,"state":"open","locked":false,"title":"splunk running as non-root user","user":{"login":"igarrison","id":1414169,"avatar_url":"https://avatars.githubusercontent.com/u/1414169?v=2","gravatar_id":"9305860bcc93a967d3a0fbb6cf7bbbb7","url":"https://api.github.com/users/igarrison","html_url":"https://github.com/igarrison","followers_url":"https://api.github.com/users/igarrison/followers","following_url":"https://api.github.com/users/igarrison/following{/other_user}","gists_url":"https://api.github.com/users/igarrison/gists{/gist_id}","starred_url":"https://api.github.com/users/igarrison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igarrison/subscriptions","organizations_url":"https://api.github.com/users/igarrison/orgs","repos_url":"https://api.github.com/users/igarrison/repos","events_url":"https://api.github.com/users/igarrison/events{/privacy}","received_events_url":"https://api.github.com/users/igarrison/received_events","type":"User","site_admin":false},"body":"new splunk installations can run as a non-root user if desired (this cookbook does not support switching between root and non-root, should it?)\r\n\r\nThere is a really ugly ruby_block which I tried pushing to a definition, spent 2+ days trying to get it to work, and then giving up.  We may even be able to skip this recursive chown if we can determine which of the Execute resources is spraying root owned files into $SPLUNK_HOME.\r\n\r\nThere are no tests for this change.  Should there be?","created_at":"2014-07-22T16:20:01Z","updated_at":"2014-08-20T18:15:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae46958afb61c90da734af94f65eca97dc5871fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls/14/commits","review_comments_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls/14/comments","review_comment_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/issues/14/comments","statuses_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/statuses/08018b78be71ec9cd724d115138f8e2ee4e766e9","head":{"label":"opscode-cookbooks:server-runs-as-non-root-user","ref":"server-runs-as-non-root-user","sha":"08018b78be71ec9cd724d115138f8e2ee4e766e9","user":{"login":"opscode-cookbooks","id":1537126,"avatar_url":"https://avatars.githubusercontent.com/u/1537126?v=2","gravatar_id":"d325d33d2ed66c370c0d031e45cf608d","url":"https://api.github.com/users/opscode-cookbooks","html_url":"https://github.com/opscode-cookbooks","followers_url":"https://api.github.com/users/opscode-cookbooks/followers","following_url":"https://api.github.com/users/opscode-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/opscode-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/opscode-cookbooks/orgs","repos_url":"https://api.github.com/users/opscode-cookbooks/repos","events_url":"https://api.github.com/users/opscode-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/opscode-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":15814426,"name":"chef-splunk","full_name":"opscode-cookbooks/chef-splunk","owner":{"login":"opscode-cookbooks","id":1537126,"avatar_url":"https://avatars.githubusercontent.com/u/1537126?v=2","gravatar_id":"d325d33d2ed66c370c0d031e45cf608d","url":"https://api.github.com/users/opscode-cookbooks","html_url":"https://github.com/opscode-cookbooks","followers_url":"https://api.github.com/users/opscode-cookbooks/followers","following_url":"https://api.github.com/users/opscode-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/opscode-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/opscode-cookbooks/orgs","repos_url":"https://api.github.com/users/opscode-cookbooks/repos","events_url":"https://api.github.com/users/opscode-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/opscode-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode-cookbooks/chef-splunk","description":"Development repository for Chef's Splunk cookbook","fork":false,"url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk","forks_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/forks","keys_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/teams","hooks_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/hooks","issue_events_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/issues/events{/number}","events_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/events","assignees_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/assignees{/user}","branches_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/branches{/branch}","tags_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/tags","blobs_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/languages","stargazers_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/stargazers","contributors_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/contributors","subscribers_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/subscribers","subscription_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/subscription","commits_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/contents/{+path}","compare_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/merges","archive_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/downloads","issues_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/issues{/number}","pulls_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/labels{/name}","releases_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/releases{/id}","created_at":"2014-01-11T01:14:21Z","updated_at":"2014-08-20T15:54:38Z","pushed_at":"2014-08-19T23:52:04Z","git_url":"git://github.com/opscode-cookbooks/chef-splunk.git","ssh_url":"git@github.com:opscode-cookbooks/chef-splunk.git","clone_url":"https://github.com/opscode-cookbooks/chef-splunk.git","svn_url":"https://github.com/opscode-cookbooks/chef-splunk","homepage":"http://community.opscode.com/cookbooks/chef-splunk","size":1091,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":11,"mirror_url":null,"open_issues_count":7,"forks":11,"open_issues":7,"watchers":10,"default_branch":"master"}},"base":{"label":"opscode-cookbooks:master","ref":"master","sha":"84aeb5a857af764e1bc4b67dd185c23775c40fea","user":{"login":"opscode-cookbooks","id":1537126,"avatar_url":"https://avatars.githubusercontent.com/u/1537126?v=2","gravatar_id":"d325d33d2ed66c370c0d031e45cf608d","url":"https://api.github.com/users/opscode-cookbooks","html_url":"https://github.com/opscode-cookbooks","followers_url":"https://api.github.com/users/opscode-cookbooks/followers","following_url":"https://api.github.com/users/opscode-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/opscode-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/opscode-cookbooks/orgs","repos_url":"https://api.github.com/users/opscode-cookbooks/repos","events_url":"https://api.github.com/users/opscode-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/opscode-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":15814426,"name":"chef-splunk","full_name":"opscode-cookbooks/chef-splunk","owner":{"login":"opscode-cookbooks","id":1537126,"avatar_url":"https://avatars.githubusercontent.com/u/1537126?v=2","gravatar_id":"d325d33d2ed66c370c0d031e45cf608d","url":"https://api.github.com/users/opscode-cookbooks","html_url":"https://github.com/opscode-cookbooks","followers_url":"https://api.github.com/users/opscode-cookbooks/followers","following_url":"https://api.github.com/users/opscode-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/opscode-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/opscode-cookbooks/orgs","repos_url":"https://api.github.com/users/opscode-cookbooks/repos","events_url":"https://api.github.com/users/opscode-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/opscode-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode-cookbooks/chef-splunk","description":"Development repository for Chef's Splunk cookbook","fork":false,"url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk","forks_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/forks","keys_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/teams","hooks_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/hooks","issue_events_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/issues/events{/number}","events_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/events","assignees_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/assignees{/user}","branches_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/branches{/branch}","tags_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/tags","blobs_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/languages","stargazers_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/stargazers","contributors_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/contributors","subscribers_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/subscribers","subscription_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/subscription","commits_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/contents/{+path}","compare_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/merges","archive_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/downloads","issues_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/issues{/number}","pulls_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/labels{/name}","releases_url":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/releases{/id}","created_at":"2014-01-11T01:14:21Z","updated_at":"2014-08-20T15:54:38Z","pushed_at":"2014-08-19T23:52:04Z","git_url":"git://github.com/opscode-cookbooks/chef-splunk.git","ssh_url":"git@github.com:opscode-cookbooks/chef-splunk.git","clone_url":"https://github.com/opscode-cookbooks/chef-splunk.git","svn_url":"https://github.com/opscode-cookbooks/chef-splunk","homepage":"http://community.opscode.com/cookbooks/chef-splunk","size":1091,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":11,"mirror_url":null,"open_issues_count":7,"forks":11,"open_issues":7,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls/14"},"html":{"href":"https://github.com/opscode-cookbooks/chef-splunk/pull/14"},"issue":{"href":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/issues/14"},"comments":{"href":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/opscode-cookbooks/chef-splunk/statuses/08018b78be71ec9cd724d115138f8e2ee4e766e9"}}}}