GitHub PullRequestEvent at 2014-08-23 20:45:41
Repository: shader-school
Actor: mikolalysenko
Payload: {"action":"closed","number":91,"pull_request":{"url":"https://api.github.com/repos/stackgl/shader-school/pulls/91","id":20211178,"html_url":"https://github.com/stackgl/shader-school/pull/91","diff_url":"https://github.com/stackgl/shader-school/pull/91.diff","patch_url":"https://github.com/stackgl/shader-school/pull/91.patch","issue_url":"https://api.github.com/repos/stackgl/shader-school/issues/91","number":91,"state":"closed","locked":false,"title":"#11-vert-2 : Without a little clarification, this involves wild guessing...","user":{"login":"mdda","id":362532,"avatar_url":"https://avatars.githubusercontent.com/u/362532?v=2","gravatar_id":"485c3a33992291f6250575a3d4c02c12","url":"https://api.github.com/users/mdda","html_url":"https://github.com/mdda","followers_url":"https://api.github.com/users/mdda/followers","following_url":"https://api.github.com/users/mdda/following{/other_user}","gists_url":"https://api.github.com/users/mdda/gists{/gist_id}","starred_url":"https://api.github.com/users/mdda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdda/subscriptions","organizations_url":"https://api.github.com/users/mdda/orgs","repos_url":"https://api.github.com/users/mdda/repos","events_url":"https://api.github.com/users/mdda/events{/privacy}","received_events_url":"https://api.github.com/users/mdda/received_events","type":"User","site_admin":false},"body":"This pull request is points out that 'triangle' shape doesn't have sneaky extra vertices - unless that's part of the question, you're really asking people to either (i) guess and cross-fingers; or (ii) visually match potentially infinitely complex functions...\r\n\r\nPerhaps the hint is too generous, but unless you state that there are only 3 vertices to deal with (and not one at the 'origin' in the middle of the base of the triangle, for instance), the problem is insanely hard.\r\n\r\nHTH\r\nMartin\r\n:-)\r\n\r\nPS: If you'd like me to fix up some of the outstanding 'issues' too, could you make me a 'contributor', since I can't currently close someone else's issue.\r\n","created_at":"2014-08-23T16:12:00Z","updated_at":"2014-08-23T20:45:39Z","closed_at":"2014-08-23T20:45:39Z","merged_at":"2014-08-23T20:45:39Z","merge_commit_sha":"75dbceb9e0756e6492c7e04285323c0ef285ee43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stackgl/shader-school/pulls/91/commits","review_comments_url":"https://api.github.com/repos/stackgl/shader-school/pulls/91/comments","review_comment_url":"https://api.github.com/repos/stackgl/shader-school/pulls/comments/{number}","comments_url":"https://api.github.com/repos/stackgl/shader-school/issues/91/comments","statuses_url":"https://api.github.com/repos/stackgl/shader-school/statuses/d6b754aad4bb3935b69786bb59ec980b2a4f5fda","head":{"label":"mdda:11-vert-2","ref":"11-vert-2","sha":"d6b754aad4bb3935b69786bb59ec980b2a4f5fda","user":{"login":"mdda","id":362532,"avatar_url":"https://avatars.githubusercontent.com/u/362532?v=2","gravatar_id":"485c3a33992291f6250575a3d4c02c12","url":"https://api.github.com/users/mdda","html_url":"https://github.com/mdda","followers_url":"https://api.github.com/users/mdda/followers","following_url":"https://api.github.com/users/mdda/following{/other_user}","gists_url":"https://api.github.com/users/mdda/gists{/gist_id}","starred_url":"https://api.github.com/users/mdda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdda/subscriptions","organizations_url":"https://api.github.com/users/mdda/orgs","repos_url":"https://api.github.com/users/mdda/repos","events_url":"https://api.github.com/users/mdda/events{/privacy}","received_events_url":"https://api.github.com/users/mdda/received_events","type":"User","site_admin":false},"repo":{"id":22926550,"name":"shader-school","full_name":"mdda/shader-school","owner":{"login":"mdda","id":362532,"avatar_url":"https://avatars.githubusercontent.com/u/362532?v=2","gravatar_id":"485c3a33992291f6250575a3d4c02c12","url":"https://api.github.com/users/mdda","html_url":"https://github.com/mdda","followers_url":"https://api.github.com/users/mdda/followers","following_url":"https://api.github.com/users/mdda/following{/other_user}","gists_url":"https://api.github.com/users/mdda/gists{/gist_id}","starred_url":"https://api.github.com/users/mdda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdda/subscriptions","organizations_url":"https://api.github.com/users/mdda/orgs","repos_url":"https://api.github.com/users/mdda/repos","events_url":"https://api.github.com/users/mdda/events{/privacy}","received_events_url":"https://api.github.com/users/mdda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdda/shader-school","description":"A workshopper for GLSL shaders and graphics programming","fork":true,"url":"https://api.github.com/repos/mdda/shader-school","forks_url":"https://api.github.com/repos/mdda/shader-school/forks","keys_url":"https://api.github.com/repos/mdda/shader-school/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdda/shader-school/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdda/shader-school/teams","hooks_url":"https://api.github.com/repos/mdda/shader-school/hooks","issue_events_url":"https://api.github.com/repos/mdda/shader-school/issues/events{/number}","events_url":"https://api.github.com/repos/mdda/shader-school/events","assignees_url":"https://api.github.com/repos/mdda/shader-school/assignees{/user}","branches_url":"https://api.github.com/repos/mdda/shader-school/branches{/branch}","tags_url":"https://api.github.com/repos/mdda/shader-school/tags","blobs_url":"https://api.github.com/repos/mdda/shader-school/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdda/shader-school/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdda/shader-school/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdda/shader-school/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdda/shader-school/statuses/{sha}","languages_url":"https://api.github.com/repos/mdda/shader-school/languages","stargazers_url":"https://api.github.com/repos/mdda/shader-school/stargazers","contributors_url":"https://api.github.com/repos/mdda/shader-school/contributors","subscribers_url":"https://api.github.com/repos/mdda/shader-school/subscribers","subscription_url":"https://api.github.com/repos/mdda/shader-school/subscription","commits_url":"https://api.github.com/repos/mdda/shader-school/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdda/shader-school/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdda/shader-school/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdda/shader-school/issues/comments/{number}","contents_url":"https://api.github.com/repos/mdda/shader-school/contents/{+path}","compare_url":"https://api.github.com/repos/mdda/shader-school/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdda/shader-school/merges","archive_url":"https://api.github.com/repos/mdda/shader-school/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdda/shader-school/downloads","issues_url":"https://api.github.com/repos/mdda/shader-school/issues{/number}","pulls_url":"https://api.github.com/repos/mdda/shader-school/pulls{/number}","milestones_url":"https://api.github.com/repos/mdda/shader-school/milestones{/number}","notifications_url":"https://api.github.com/repos/mdda/shader-school/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdda/shader-school/labels{/name}","releases_url":"https://api.github.com/repos/mdda/shader-school/releases{/id}","created_at":"2014-08-13T18:30:14Z","updated_at":"2014-08-20T17:51:04Z","pushed_at":"2014-08-23T16:03:27Z","git_url":"git://github.com/mdda/shader-school.git","ssh_url":"git@github.com:mdda/shader-school.git","clone_url":"https://github.com/mdda/shader-school.git","svn_url":"https://github.com/mdda/shader-school","homepage":"","size":394,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"stackgl:master","ref":"master","sha":"d7f7aedda469eec97adf10cca86f22b4db8139e0","user":{"login":"stackgl","id":6663448,"avatar_url":"https://avatars.githubusercontent.com/u/6663448?v=2","gravatar_id":null,"url":"https://api.github.com/users/stackgl","html_url":"https://github.com/stackgl","followers_url":"https://api.github.com/users/stackgl/followers","following_url":"https://api.github.com/users/stackgl/following{/other_user}","gists_url":"https://api.github.com/users/stackgl/gists{/gist_id}","starred_url":"https://api.github.com/users/stackgl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackgl/subscriptions","organizations_url":"https://api.github.com/users/stackgl/orgs","repos_url":"https://api.github.com/users/stackgl/repos","events_url":"https://api.github.com/users/stackgl/events{/privacy}","received_events_url":"https://api.github.com/users/stackgl/received_events","type":"Organization","site_admin":false},"repo":{"id":17576966,"name":"shader-school","full_name":"stackgl/shader-school","owner":{"login":"stackgl","id":6663448,"avatar_url":"https://avatars.githubusercontent.com/u/6663448?v=2","gravatar_id":null,"url":"https://api.github.com/users/stackgl","html_url":"https://github.com/stackgl","followers_url":"https://api.github.com/users/stackgl/followers","following_url":"https://api.github.com/users/stackgl/following{/other_user}","gists_url":"https://api.github.com/users/stackgl/gists{/gist_id}","starred_url":"https://api.github.com/users/stackgl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackgl/subscriptions","organizations_url":"https://api.github.com/users/stackgl/orgs","repos_url":"https://api.github.com/users/stackgl/repos","events_url":"https://api.github.com/users/stackgl/events{/privacy}","received_events_url":"https://api.github.com/users/stackgl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stackgl/shader-school","description":"A workshopper for GLSL shaders and graphics programming","fork":false,"url":"https://api.github.com/repos/stackgl/shader-school","forks_url":"https://api.github.com/repos/stackgl/shader-school/forks","keys_url":"https://api.github.com/repos/stackgl/shader-school/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stackgl/shader-school/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stackgl/shader-school/teams","hooks_url":"https://api.github.com/repos/stackgl/shader-school/hooks","issue_events_url":"https://api.github.com/repos/stackgl/shader-school/issues/events{/number}","events_url":"https://api.github.com/repos/stackgl/shader-school/events","assignees_url":"https://api.github.com/repos/stackgl/shader-school/assignees{/user}","branches_url":"https://api.github.com/repos/stackgl/shader-school/branches{/branch}","tags_url":"https://api.github.com/repos/stackgl/shader-school/tags","blobs_url":"https://api.github.com/repos/stackgl/shader-school/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stackgl/shader-school/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stackgl/shader-school/git/refs{/sha}","trees_url":"https://api.github.com/repos/stackgl/shader-school/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stackgl/shader-school/statuses/{sha}","languages_url":"https://api.github.com/repos/stackgl/shader-school/languages","stargazers_url":"https://api.github.com/repos/stackgl/shader-school/stargazers","contributors_url":"https://api.github.com/repos/stackgl/shader-school/contributors","subscribers_url":"https://api.github.com/repos/stackgl/shader-school/subscribers","subscription_url":"https://api.github.com/repos/stackgl/shader-school/subscription","commits_url":"https://api.github.com/repos/stackgl/shader-school/commits{/sha}","git_commits_url":"https://api.github.com/repos/stackgl/shader-school/git/commits{/sha}","comments_url":"https://api.github.com/repos/stackgl/shader-school/comments{/number}","issue_comment_url":"https://api.github.com/repos/stackgl/shader-school/issues/comments/{number}","contents_url":"https://api.github.com/repos/stackgl/shader-school/contents/{+path}","compare_url":"https://api.github.com/repos/stackgl/shader-school/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stackgl/shader-school/merges","archive_url":"https://api.github.com/repos/stackgl/shader-school/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stackgl/shader-school/downloads","issues_url":"https://api.github.com/repos/stackgl/shader-school/issues{/number}","pulls_url":"https://api.github.com/repos/stackgl/shader-school/pulls{/number}","milestones_url":"https://api.github.com/repos/stackgl/shader-school/milestones{/number}","notifications_url":"https://api.github.com/repos/stackgl/shader-school/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stackgl/shader-school/labels{/name}","releases_url":"https://api.github.com/repos/stackgl/shader-school/releases{/id}","created_at":"2014-03-10T00:04:05Z","updated_at":"2014-08-22T10:07:28Z","pushed_at":"2014-08-23T20:45:40Z","git_url":"git://github.com/stackgl/shader-school.git","ssh_url":"git@github.com:stackgl/shader-school.git","clone_url":"https://github.com/stackgl/shader-school.git","svn_url":"https://github.com/stackgl/shader-school","homepage":"","size":1579,"stargazers_count":246,"watchers_count":246,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":16,"mirror_url":null,"open_issues_count":26,"forks":16,"open_issues":26,"watchers":246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stackgl/shader-school/pulls/91"},"html":{"href":"https://github.com/stackgl/shader-school/pull/91"},"issue":{"href":"https://api.github.com/repos/stackgl/shader-school/issues/91"},"comments":{"href":"https://api.github.com/repos/stackgl/shader-school/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/stackgl/shader-school/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/stackgl/shader-school/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/stackgl/shader-school/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/stackgl/shader-school/statuses/d6b754aad4bb3935b69786bb59ec980b2a4f5fda"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mikolalysenko","id":231686,"avatar_url":"https://avatars.githubusercontent.com/u/231686?v=2","gravatar_id":"3ca049389a932a8c3fa70db5fb86b878","url":"https://api.github.com/users/mikolalysenko","html_url":"https://github.com/mikolalysenko","followers_url":"https://api.github.com/users/mikolalysenko/followers","following_url":"https://api.github.com/users/mikolalysenko/following{/other_user}","gists_url":"https://api.github.com/users/mikolalysenko/gists{/gist_id}","starred_url":"https://api.github.com/users/mikolalysenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikolalysenko/subscriptions","organizations_url":"https://api.github.com/users/mikolalysenko/orgs","repos_url":"https://api.github.com/users/mikolalysenko/repos","events_url":"https://api.github.com/users/mikolalysenko/events{/privacy}","received_events_url":"https://api.github.com/users/mikolalysenko/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":1}}