GitHub PullRequestReviewCommentEvent at 2014-02-07 22:23:57
Repository: neutron
Actor: sukhdevkapur
Payload: {"comment":{"url":"https://api.github.com/repos/openstack/neutron/pulls/comments/9557717","id":9557717,"diff_hunk":"@@ -177,23 +185,25 @@ def create_network(self, tenant_id, network_id, network_name, seg_id):\n         :param seg_id: Segment ID of the network\n         \"\"\"\n         cmds = ['tenant %s' % tenant_id]\n-        if network_name:\n-            cmds.append('network id %s name \"%s\"' %\n-                        (network_id, network_name))\n-        else:\n-            cmds.append('network id %s' % network_id)\n-        cmds.append('segment 1 type vlan id %d' % seg_id)\n-        cmds.append('exit')\n-        cmds.append('exit')\n-        cmds.append('exit')\n+        # Create a reference to function to avoid name lookups in the loop","path":"neutron/plugins/ml2/drivers/mech_arista/mechanism_arista.py","position":74,"original_position":74,"commit_id":"48373954ca80942bd9b7da5f3addd774bb7207c7","original_commit_id":"48373954ca80942bd9b7da5f3addd774bb7207c7","user":{"login":"sukhdevkapur","id":3019263,"avatar_url":"https://gravatar.com/avatar/c33cf3fbb8e214c5784598dd28724aa4?d=https%3A%2F%2Fidenticons.github.com%2F47178ede975a8f89b7fb55796c10c73b.png&r=x","gravatar_id":"c33cf3fbb8e214c5784598dd28724aa4","url":"https://api.github.com/users/sukhdevkapur","html_url":"https://github.com/sukhdevkapur","followers_url":"https://api.github.com/users/sukhdevkapur/followers","following_url":"https://api.github.com/users/sukhdevkapur/following{/other_user}","gists_url":"https://api.github.com/users/sukhdevkapur/gists{/gist_id}","starred_url":"https://api.github.com/users/sukhdevkapur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sukhdevkapur/subscriptions","organizations_url":"https://api.github.com/users/sukhdevkapur/orgs","repos_url":"https://api.github.com/users/sukhdevkapur/repos","events_url":"https://api.github.com/users/sukhdevkapur/events{/privacy}","received_events_url":"https://api.github.com/users/sukhdevkapur/received_events","type":"User","site_admin":false},"body":"check number of exits - may be missing one ----just confirm it","created_at":"2014-02-07T22:23:57Z","updated_at":"2014-02-07T22:23:57Z","html_url":"https://github.com/openstack/neutron/pull/12#discussion_r9557717","pull_request_url":"https://api.github.com/repos/openstack/neutron/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/openstack/neutron/pulls/comments/9557717"},"html":{"href":"https://github.com/openstack/neutron/pull/12#discussion_r9557717"},"pull_request":{"href":"https://api.github.com/repos/openstack/neutron/pulls/12"}}}}