GitHub PullRequestReviewCommentEvent at 2014-11-23 18:02:36
Repository: cockroach
Actor: embark
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/20766405","id":20766405,"diff_hunk":"@@ -459,6 +461,49 @@ type Response interface {\n \tVerify(req Request) error\n }\n \n+// Combinable is implemented by responses types whose corresponding\n+// requests may cross range boundaries, such as Scan or DeleteRange.\n+// Combine() allows responses from individual ranges to be glued\n+// together into a single one.\n+// Combinable is also implemented by ResponseHeader to properly\n+// propagate the timestamp and transaction when joining responses.\n+// It is not expected that Combine() perform any error checking; this\n+// should be done by the caller instead.\n+type Combinable interface {\n+\tCombine(interface{})\n+}\n+\n+// Combine implements the Combinable interface for ResponseHeader.\n+func (rh *ResponseHeader) Combine(c interface{}) {\n+\totherRH := c.(*ResponseHeader)\n+\tif rh != nil {\n+\t\tif ts := otherRH.GetTimestamp(); rh.Timestamp.Less(ts) {\n+\t\t\trh.Timestamp = ts\n+\t\t}\n+\t\tif rh.Txn != nil && otherRH.GetTxn() == nil {\n+\t\t\trh.Txn = nil\n+\t\t}\n+\t}\n+}\n+\n+// Combine implements the Combinable interface for ScanResponse.\n+func (sr *ScanResponse) Combine(c interface{}) {\n+\totherSR := c.(*ScanResponse)\n+\tif sr != nil {","path":"proto/api.go","position":47,"original_position":47,"commit_id":"0b360a1fa3adbcfd1ef74ceb0e6e9acb10456455","original_commit_id":"0b360a1fa3adbcfd1ef74ceb0e6e9acb10456455","user":{"login":"embark","id":2575512,"avatar_url":"https://avatars.githubusercontent.com/u/2575512?v=3","gravatar_id":"","url":"https://api.github.com/users/embark","html_url":"https://github.com/embark","followers_url":"https://api.github.com/users/embark/followers","following_url":"https://api.github.com/users/embark/following{/other_user}","gists_url":"https://api.github.com/users/embark/gists{/gist_id}","starred_url":"https://api.github.com/users/embark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embark/subscriptions","organizations_url":"https://api.github.com/users/embark/orgs","repos_url":"https://api.github.com/users/embark/repos","events_url":"https://api.github.com/users/embark/events{/privacy}","received_events_url":"https://api.github.com/users/embark/received_events","type":"User","site_admin":false},"body":"Same question as for response header, and for delete range below. I might be missing something, though!","created_at":"2014-11-23T18:02:36Z","updated_at":"2014-11-23T18:02:36Z","html_url":"https://github.com/cockroachdb/cockroach/pull/183#discussion_r20766405","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/183","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/20766405"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/183#discussion_r20766405"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/183"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/183","id":24901563,"html_url":"https://github.com/cockroachdb/cockroach/pull/183","diff_url":"https://github.com/cockroachdb/cockroach/pull/183.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/183.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/183","number":183,"state":"open","locked":false,"title":"Allow operations to cross range boundaries","user":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"body":" * add proto.Combinable interface\r\n\r\nCombinable is implemented by responses whose requests may access multiple ranges,\r\nsuch as {Scan,DeleteRange}Response and allows multiple responses to be merged\r\ninto a single one transparently.\r\n\r\n* allow multi-range Scan and DeleteRange\r\n\r\nadapted the distributed sender to split such requests up\r\nand adress them to the individual ranges.\r\nThe Combinable interface is used to create a single response\r\nfrom those parts which is returned with the client.Call.\r\n","created_at":"2014-11-23T13:52:22Z","updated_at":"2014-11-23T18:02:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52a486d367224ef063769796281cb66147137666","assignee":{"login":"spencerkimball","id":6147149,"avatar_url":"https://avatars.githubusercontent.com/u/6147149?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/183/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/183/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/183/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/0b360a1fa3adbcfd1ef74ceb0e6e9acb10456455","head":{"label":"tschottdorf:opsacrossranges","ref":"opsacrossranges","sha":"0b360a1fa3adbcfd1ef74ceb0e6e9acb10456455","user":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"repo":{"id":23832429,"name":"cockroach","full_name":"tschottdorf/cockroach","owner":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tschottdorf/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/tschottdorf/cockroach","forks_url":"https://api.github.com/repos/tschottdorf/cockroach/forks","keys_url":"https://api.github.com/repos/tschottdorf/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tschottdorf/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tschottdorf/cockroach/teams","hooks_url":"https://api.github.com/repos/tschottdorf/cockroach/hooks","issue_events_url":"https://api.github.com/repos/tschottdorf/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/tschottdorf/cockroach/events","assignees_url":"https://api.github.com/repos/tschottdorf/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/tschottdorf/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/tschottdorf/cockroach/tags","blobs_url":"https://api.github.com/repos/tschottdorf/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tschottdorf/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tschottdorf/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/tschottdorf/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tschottdorf/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/tschottdorf/cockroach/languages","stargazers_url":"https://api.github.com/repos/tschottdorf/cockroach/stargazers","contributors_url":"https://api.github.com/repos/tschottdorf/cockroach/contributors","subscribers_url":"https://api.github.com/repos/tschottdorf/cockroach/subscribers","subscription_url":"https://api.github.com/repos/tschottdorf/cockroach/subscription","commits_url":"https://api.github.com/repos/tschottdorf/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/tschottdorf/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/tschottdorf/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/tschottdorf/cockroach/issues/comments/{number}","contents_url":"https://api.github.com/repos/tschottdorf/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/tschottdorf/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tschottdorf/cockroach/merges","archive_url":"https://api.github.com/repos/tschottdorf/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tschottdorf/cockroach/downloads","issues_url":"https://api.github.com/repos/tschottdorf/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/tschottdorf/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/tschottdorf/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/tschottdorf/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tschottdorf/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/tschottdorf/cockroach/releases{/id}","created_at":"2014-09-09T12:26:29Z","updated_at":"2014-11-22T09:59:04Z","pushed_at":"2014-11-23T13:48:46Z","git_url":"git://github.com/tschottdorf/cockroach.git","ssh_url":"git@github.com:tschottdorf/cockroach.git","clone_url":"https://github.com/tschottdorf/cockroach.git","svn_url":"https://github.com/tschottdorf/cockroach","homepage":null,"size":9097,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"823af288e64223fae31a1ad1bf62a6d5ab2a197b","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/{number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","created_at":"2014-02-06T00:18:47Z","updated_at":"2014-11-23T09:24:07Z","pushed_at":"2014-11-23T09:24:07Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":null,"size":14608,"stargazers_count":2454,"watchers_count":2454,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"open_issues_count":19,"forks":158,"open_issues":19,"watchers":2454,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/183"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/183"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/183"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/0b360a1fa3adbcfd1ef74ceb0e6e9acb10456455"}}}}