GitHub PullRequestReviewCommentEvent at 2014-08-19 11:05:25
Repository: Smoothieware
Actor: wolfmanjm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/comments/16407965","id":16407965,"diff_hunk":"@@ -8,6 +8,8 @@ class DigipotBase {\n \n         virtual void set_current( int channel, float current )= 0;\n         virtual float get_current(int channel)= 0;\n+\t\tvirtual void set_MCP4726_adress( int value )= 0;","path":"src/modules/utils/currentcontrol/DigipotBase.h","position":4,"original_position":4,"commit_id":"480200fe3cab703b8249d41b56470f10b18d5712","original_commit_id":"480200fe3cab703b8249d41b56470f10b18d5712","user":{"login":"wolfmanjm","id":22263,"avatar_url":"https://avatars.githubusercontent.com/u/22263?v=2","gravatar_id":"c31c7255fa4488dfc5d766403b497a36","url":"https://api.github.com/users/wolfmanjm","html_url":"https://github.com/wolfmanjm","followers_url":"https://api.github.com/users/wolfmanjm/followers","following_url":"https://api.github.com/users/wolfmanjm/following{/other_user}","gists_url":"https://api.github.com/users/wolfmanjm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfmanjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfmanjm/subscriptions","organizations_url":"https://api.github.com/users/wolfmanjm/orgs","repos_url":"https://api.github.com/users/wolfmanjm/repos","events_url":"https://api.github.com/users/wolfmanjm/events{/privacy}","received_events_url":"https://api.github.com/users/wolfmanjm/received_events","type":"User","site_admin":false},"body":"These do not belong in a base class, please refactor out","created_at":"2014-08-19T11:05:25Z","updated_at":"2014-08-19T11:05:25Z","html_url":"https://github.com/Smoothieware/Smoothieware/pull/488#discussion_r16407965","pull_request_url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/488","_links":{"self":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/comments/16407965"},"html":{"href":"https://github.com/Smoothieware/Smoothieware/pull/488#discussion_r16407965"},"pull_request":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/488"}}},"pull_request":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/488","id":19970022,"html_url":"https://github.com/Smoothieware/Smoothieware/pull/488","diff_url":"https://github.com/Smoothieware/Smoothieware/pull/488.diff","patch_url":"https://github.com/Smoothieware/Smoothieware/pull/488.patch","issue_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/488","number":488,"state":"open","locked":false,"title":"Add mcp4728 support","user":{"login":"wuflnor","id":1582903,"avatar_url":"https://avatars.githubusercontent.com/u/1582903?v=2","gravatar_id":"fa80e93f8673219714bbe45003d5e30f","url":"https://api.github.com/users/wuflnor","html_url":"https://github.com/wuflnor","followers_url":"https://api.github.com/users/wuflnor/followers","following_url":"https://api.github.com/users/wuflnor/following{/other_user}","gists_url":"https://api.github.com/users/wuflnor/gists{/gist_id}","starred_url":"https://api.github.com/users/wuflnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuflnor/subscriptions","organizations_url":"https://api.github.com/users/wuflnor/orgs","repos_url":"https://api.github.com/users/wuflnor/repos","events_url":"https://api.github.com/users/wuflnor/events{/privacy}","received_events_url":"https://api.github.com/users/wuflnor/received_events","type":"User","site_admin":false},"body":"for current controll with dac","created_at":"2014-08-19T09:48:06Z","updated_at":"2014-08-19T11:05:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fa61ad681cfc5f688621b71cb474265757ca73b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/488/commits","review_comments_url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/488/comments","review_comment_url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/488/comments","statuses_url":"https://api.github.com/repos/Smoothieware/Smoothieware/statuses/480200fe3cab703b8249d41b56470f10b18d5712","head":{"label":"wuflnor:edge","ref":"edge","sha":"480200fe3cab703b8249d41b56470f10b18d5712","user":{"login":"wuflnor","id":1582903,"avatar_url":"https://avatars.githubusercontent.com/u/1582903?v=2","gravatar_id":"fa80e93f8673219714bbe45003d5e30f","url":"https://api.github.com/users/wuflnor","html_url":"https://github.com/wuflnor","followers_url":"https://api.github.com/users/wuflnor/followers","following_url":"https://api.github.com/users/wuflnor/following{/other_user}","gists_url":"https://api.github.com/users/wuflnor/gists{/gist_id}","starred_url":"https://api.github.com/users/wuflnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuflnor/subscriptions","organizations_url":"https://api.github.com/users/wuflnor/orgs","repos_url":"https://api.github.com/users/wuflnor/repos","events_url":"https://api.github.com/users/wuflnor/events{/privacy}","received_events_url":"https://api.github.com/users/wuflnor/received_events","type":"User","site_admin":false},"repo":{"id":23103964,"name":"Smoothieware","full_name":"wuflnor/Smoothieware","owner":{"login":"wuflnor","id":1582903,"avatar_url":"https://avatars.githubusercontent.com/u/1582903?v=2","gravatar_id":"fa80e93f8673219714bbe45003d5e30f","url":"https://api.github.com/users/wuflnor","html_url":"https://github.com/wuflnor","followers_url":"https://api.github.com/users/wuflnor/followers","following_url":"https://api.github.com/users/wuflnor/following{/other_user}","gists_url":"https://api.github.com/users/wuflnor/gists{/gist_id}","starred_url":"https://api.github.com/users/wuflnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuflnor/subscriptions","organizations_url":"https://api.github.com/users/wuflnor/orgs","repos_url":"https://api.github.com/users/wuflnor/repos","events_url":"https://api.github.com/users/wuflnor/events{/privacy}","received_events_url":"https://api.github.com/users/wuflnor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wuflnor/Smoothieware","description":"Modular, opensource, high performance G-code interpreter and CNC controller written in Object-Oriented C++","fork":true,"url":"https://api.github.com/repos/wuflnor/Smoothieware","forks_url":"https://api.github.com/repos/wuflnor/Smoothieware/forks","keys_url":"https://api.github.com/repos/wuflnor/Smoothieware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wuflnor/Smoothieware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wuflnor/Smoothieware/teams","hooks_url":"https://api.github.com/repos/wuflnor/Smoothieware/hooks","issue_events_url":"https://api.github.com/repos/wuflnor/Smoothieware/issues/events{/number}","events_url":"https://api.github.com/repos/wuflnor/Smoothieware/events","assignees_url":"https://api.github.com/repos/wuflnor/Smoothieware/assignees{/user}","branches_url":"https://api.github.com/repos/wuflnor/Smoothieware/branches{/branch}","tags_url":"https://api.github.com/repos/wuflnor/Smoothieware/tags","blobs_url":"https://api.github.com/repos/wuflnor/Smoothieware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wuflnor/Smoothieware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wuflnor/Smoothieware/git/refs{/sha}","trees_url":"https://api.github.com/repos/wuflnor/Smoothieware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wuflnor/Smoothieware/statuses/{sha}","languages_url":"https://api.github.com/repos/wuflnor/Smoothieware/languages","stargazers_url":"https://api.github.com/repos/wuflnor/Smoothieware/stargazers","contributors_url":"https://api.github.com/repos/wuflnor/Smoothieware/contributors","subscribers_url":"https://api.github.com/repos/wuflnor/Smoothieware/subscribers","subscription_url":"https://api.github.com/repos/wuflnor/Smoothieware/subscription","commits_url":"https://api.github.com/repos/wuflnor/Smoothieware/commits{/sha}","git_commits_url":"https://api.github.com/repos/wuflnor/Smoothieware/git/commits{/sha}","comments_url":"https://api.github.com/repos/wuflnor/Smoothieware/comments{/number}","issue_comment_url":"https://api.github.com/repos/wuflnor/Smoothieware/issues/comments/{number}","contents_url":"https://api.github.com/repos/wuflnor/Smoothieware/contents/{+path}","compare_url":"https://api.github.com/repos/wuflnor/Smoothieware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wuflnor/Smoothieware/merges","archive_url":"https://api.github.com/repos/wuflnor/Smoothieware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wuflnor/Smoothieware/downloads","issues_url":"https://api.github.com/repos/wuflnor/Smoothieware/issues{/number}","pulls_url":"https://api.github.com/repos/wuflnor/Smoothieware/pulls{/number}","milestones_url":"https://api.github.com/repos/wuflnor/Smoothieware/milestones{/number}","notifications_url":"https://api.github.com/repos/wuflnor/Smoothieware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wuflnor/Smoothieware/labels{/name}","releases_url":"https://api.github.com/repos/wuflnor/Smoothieware/releases{/id}","created_at":"2014-08-19T09:11:50Z","updated_at":"2014-08-19T09:45:32Z","pushed_at":"2014-08-19T09:45:29Z","git_url":"git://github.com/wuflnor/Smoothieware.git","ssh_url":"git@github.com:wuflnor/Smoothieware.git","clone_url":"https://github.com/wuflnor/Smoothieware.git","svn_url":"https://github.com/wuflnor/Smoothieware","homepage":"http://smoothieware.org/","size":31336,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"edge"}},"base":{"label":"Smoothieware:edge","ref":"edge","sha":"e9d8534b5419967e368415c94304ddf1aef9295a","user":{"login":"Smoothieware","id":4834224,"avatar_url":"https://avatars.githubusercontent.com/u/4834224?v=2","gravatar_id":null,"url":"https://api.github.com/users/Smoothieware","html_url":"https://github.com/Smoothieware","followers_url":"https://api.github.com/users/Smoothieware/followers","following_url":"https://api.github.com/users/Smoothieware/following{/other_user}","gists_url":"https://api.github.com/users/Smoothieware/gists{/gist_id}","starred_url":"https://api.github.com/users/Smoothieware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smoothieware/subscriptions","organizations_url":"https://api.github.com/users/Smoothieware/orgs","repos_url":"https://api.github.com/users/Smoothieware/repos","events_url":"https://api.github.com/users/Smoothieware/events{/privacy}","received_events_url":"https://api.github.com/users/Smoothieware/received_events","type":"Organization","site_admin":false},"repo":{"id":2418744,"name":"Smoothieware","full_name":"Smoothieware/Smoothieware","owner":{"login":"Smoothieware","id":4834224,"avatar_url":"https://avatars.githubusercontent.com/u/4834224?v=2","gravatar_id":null,"url":"https://api.github.com/users/Smoothieware","html_url":"https://github.com/Smoothieware","followers_url":"https://api.github.com/users/Smoothieware/followers","following_url":"https://api.github.com/users/Smoothieware/following{/other_user}","gists_url":"https://api.github.com/users/Smoothieware/gists{/gist_id}","starred_url":"https://api.github.com/users/Smoothieware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smoothieware/subscriptions","organizations_url":"https://api.github.com/users/Smoothieware/orgs","repos_url":"https://api.github.com/users/Smoothieware/repos","events_url":"https://api.github.com/users/Smoothieware/events{/privacy}","received_events_url":"https://api.github.com/users/Smoothieware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Smoothieware/Smoothieware","description":"Modular, opensource, high performance G-code interpreter and CNC controller written in Object-Oriented C++","fork":false,"url":"https://api.github.com/repos/Smoothieware/Smoothieware","forks_url":"https://api.github.com/repos/Smoothieware/Smoothieware/forks","keys_url":"https://api.github.com/repos/Smoothieware/Smoothieware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Smoothieware/Smoothieware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Smoothieware/Smoothieware/teams","hooks_url":"https://api.github.com/repos/Smoothieware/Smoothieware/hooks","issue_events_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/events{/number}","events_url":"https://api.github.com/repos/Smoothieware/Smoothieware/events","assignees_url":"https://api.github.com/repos/Smoothieware/Smoothieware/assignees{/user}","branches_url":"https://api.github.com/repos/Smoothieware/Smoothieware/branches{/branch}","tags_url":"https://api.github.com/repos/Smoothieware/Smoothieware/tags","blobs_url":"https://api.github.com/repos/Smoothieware/Smoothieware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Smoothieware/Smoothieware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Smoothieware/Smoothieware/git/refs{/sha}","trees_url":"https://api.github.com/repos/Smoothieware/Smoothieware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Smoothieware/Smoothieware/statuses/{sha}","languages_url":"https://api.github.com/repos/Smoothieware/Smoothieware/languages","stargazers_url":"https://api.github.com/repos/Smoothieware/Smoothieware/stargazers","contributors_url":"https://api.github.com/repos/Smoothieware/Smoothieware/contributors","subscribers_url":"https://api.github.com/repos/Smoothieware/Smoothieware/subscribers","subscription_url":"https://api.github.com/repos/Smoothieware/Smoothieware/subscription","commits_url":"https://api.github.com/repos/Smoothieware/Smoothieware/commits{/sha}","git_commits_url":"https://api.github.com/repos/Smoothieware/Smoothieware/git/commits{/sha}","comments_url":"https://api.github.com/repos/Smoothieware/Smoothieware/comments{/number}","issue_comment_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/comments/{number}","contents_url":"https://api.github.com/repos/Smoothieware/Smoothieware/contents/{+path}","compare_url":"https://api.github.com/repos/Smoothieware/Smoothieware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Smoothieware/Smoothieware/merges","archive_url":"https://api.github.com/repos/Smoothieware/Smoothieware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Smoothieware/Smoothieware/downloads","issues_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues{/number}","pulls_url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls{/number}","milestones_url":"https://api.github.com/repos/Smoothieware/Smoothieware/milestones{/number}","notifications_url":"https://api.github.com/repos/Smoothieware/Smoothieware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Smoothieware/Smoothieware/labels{/name}","releases_url":"https://api.github.com/repos/Smoothieware/Smoothieware/releases{/id}","created_at":"2011-09-19T22:21:05Z","updated_at":"2014-08-13T20:23:48Z","pushed_at":"2014-08-14T01:01:24Z","git_url":"git://github.com/Smoothieware/Smoothieware.git","ssh_url":"git@github.com:Smoothieware/Smoothieware.git","clone_url":"https://github.com/Smoothieware/Smoothieware.git","svn_url":"https://github.com/Smoothieware/Smoothieware","homepage":"http://smoothieware.org/","size":31336,"stargazers_count":148,"watchers_count":148,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":134,"mirror_url":null,"open_issues_count":33,"forks":134,"open_issues":33,"watchers":148,"default_branch":"edge"}},"_links":{"self":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/488"},"html":{"href":"https://github.com/Smoothieware/Smoothieware/pull/488"},"issue":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/488"},"comments":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/488/comments"},"review_comments":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/488/comments"},"review_comment":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/488/commits"},"statuses":{"href":"https://api.github.com/repos/Smoothieware/Smoothieware/statuses/480200fe3cab703b8249d41b56470f10b18d5712"}}}}