GitHub PullRequestEvent at 2014-03-25 12:12:13
Repository: rails-footnotes
Actor: joshuapaling
Payload: {"action":"opened","number":106,"pull_request":{"url":"https://api.github.com/repos/josevalim/rails-footnotes/pulls/106","id":13948652,"html_url":"https://github.com/josevalim/rails-footnotes/pull/106","diff_url":"https://github.com/josevalim/rails-footnotes/pull/106.diff","patch_url":"https://github.com/josevalim/rails-footnotes/pull/106.patch","issue_url":"https://api.github.com/repos/josevalim/rails-footnotes/issues/106","number":106,"state":"open","title":"Feature: configurable position & font size","user":{"login":"joshuapaling","id":145042,"avatar_url":"https://avatars.githubusercontent.com/u/145042?","gravatar_id":"bca7defe7b8087d8e261d32b29cf425e","url":"https://api.github.com/users/joshuapaling","html_url":"https://github.com/joshuapaling","followers_url":"https://api.github.com/users/joshuapaling/followers","following_url":"https://api.github.com/users/joshuapaling/following{/other_user}","gists_url":"https://api.github.com/users/joshuapaling/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuapaling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuapaling/subscriptions","organizations_url":"https://api.github.com/users/joshuapaling/orgs","repos_url":"https://api.github.com/users/joshuapaling/repos","events_url":"https://api.github.com/users/joshuapaling/events{/privacy}","received_events_url":"https://api.github.com/users/joshuapaling/received_events","type":"User","site_admin":false},"body":"Implemented suggestion from https://github.com/josevalim/rails-footnotes/issues/105\r\n\r\nIt should be pretty self explanatory based on what I've added to the readme:\r\n\r\nYou can also lock the footnotes to the top of the window, hidden by default, and accessible\r\nvia a small button fixed to the top-right of your browser:\r\n\r\n    f.lock_top_right = true\r\n\r\nTo set the font-size for the footnotes:\r\n\r\n    f.font_size = '13px'\r\n\r\n--\r\n\r\nAlso, I've changed the font to a monospace font, which I think is better for readability (rather than inheriting the default body font). I was going to make font_family a configurable option but decided against it - let me know if you'd like me to add that to this PR.\r\n\r\nLastly, I haven't added any tests... I noticed other simple features like `@@no_style` aren't tested. If you want tests, please give some indication of what you think I should test for - I'm newish to ruby / rails.","created_at":"2014-03-25T12:12:13Z","updated_at":"2014-03-25T12:12:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/josevalim/rails-footnotes/pulls/106/commits","review_comments_url":"https://api.github.com/repos/josevalim/rails-footnotes/pulls/106/comments","review_comment_url":"https://api.github.com/repos/josevalim/rails-footnotes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/josevalim/rails-footnotes/issues/106/comments","statuses_url":"https://api.github.com/repos/josevalim/rails-footnotes/statuses/669d3f7afa19aba48e5ea627161e409dae3323f6","head":{"label":"joshuapaling:feature-configurable-position","ref":"feature-configurable-position","sha":"669d3f7afa19aba48e5ea627161e409dae3323f6","user":{"login":"joshuapaling","id":145042,"avatar_url":"https://avatars.githubusercontent.com/u/145042?","gravatar_id":"bca7defe7b8087d8e261d32b29cf425e","url":"https://api.github.com/users/joshuapaling","html_url":"https://github.com/joshuapaling","followers_url":"https://api.github.com/users/joshuapaling/followers","following_url":"https://api.github.com/users/joshuapaling/following{/other_user}","gists_url":"https://api.github.com/users/joshuapaling/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuapaling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuapaling/subscriptions","organizations_url":"https://api.github.com/users/joshuapaling/orgs","repos_url":"https://api.github.com/users/joshuapaling/repos","events_url":"https://api.github.com/users/joshuapaling/events{/privacy}","received_events_url":"https://api.github.com/users/joshuapaling/received_events","type":"User","site_admin":false},"repo":{"id":18003570,"name":"rails-footnotes","full_name":"joshuapaling/rails-footnotes","owner":{"login":"joshuapaling","id":145042,"avatar_url":"https://avatars.githubusercontent.com/u/145042?","gravatar_id":"bca7defe7b8087d8e261d32b29cf425e","url":"https://api.github.com/users/joshuapaling","html_url":"https://github.com/joshuapaling","followers_url":"https://api.github.com/users/joshuapaling/followers","following_url":"https://api.github.com/users/joshuapaling/following{/other_user}","gists_url":"https://api.github.com/users/joshuapaling/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuapaling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuapaling/subscriptions","organizations_url":"https://api.github.com/users/joshuapaling/orgs","repos_url":"https://api.github.com/users/joshuapaling/repos","events_url":"https://api.github.com/users/joshuapaling/events{/privacy}","received_events_url":"https://api.github.com/users/joshuapaling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshuapaling/rails-footnotes","description":"Every Rails page has footnotes that gives information about your application and links back to your editor","fork":true,"url":"https://api.github.com/repos/joshuapaling/rails-footnotes","forks_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/forks","keys_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/teams","hooks_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/hooks","issue_events_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/issues/events{/number}","events_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/events","assignees_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/assignees{/user}","branches_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/branches{/branch}","tags_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/tags","blobs_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/statuses/{sha}","languages_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/languages","stargazers_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/stargazers","contributors_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/contributors","subscribers_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/subscribers","subscription_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/subscription","commits_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/issues/comments/{number}","contents_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/contents/{+path}","compare_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/merges","archive_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/downloads","issues_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/issues{/number}","pulls_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/pulls{/number}","milestones_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/milestones{/number}","notifications_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/labels{/name}","releases_url":"https://api.github.com/repos/joshuapaling/rails-footnotes/releases{/id}","created_at":"2014-03-22T06:24:56Z","updated_at":"2014-03-25T12:12:13Z","pushed_at":"2014-03-25T12:02:27Z","git_url":"git://github.com/joshuapaling/rails-footnotes.git","ssh_url":"git@github.com:joshuapaling/rails-footnotes.git","clone_url":"https://github.com/joshuapaling/rails-footnotes.git","svn_url":"https://github.com/joshuapaling/rails-footnotes","homepage":"http://blog.plataformatec.com.br/","size":419,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"josevalim:master","ref":"master","sha":"a21cff4212001f6c62988c3b5d7350b66820b509","user":{"login":"josevalim","id":9582,"avatar_url":"https://avatars.githubusercontent.com/u/9582?","gravatar_id":"e837f6b7fd146ab16ed3d663476c063e","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"repo":{"id":92826,"name":"rails-footnotes","full_name":"josevalim/rails-footnotes","owner":{"login":"josevalim","id":9582,"avatar_url":"https://avatars.githubusercontent.com/u/9582?","gravatar_id":"e837f6b7fd146ab16ed3d663476c063e","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josevalim/rails-footnotes","description":"Every Rails page has footnotes that gives information about your application and links back to your editor","fork":false,"url":"https://api.github.com/repos/josevalim/rails-footnotes","forks_url":"https://api.github.com/repos/josevalim/rails-footnotes/forks","keys_url":"https://api.github.com/repos/josevalim/rails-footnotes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josevalim/rails-footnotes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josevalim/rails-footnotes/teams","hooks_url":"https://api.github.com/repos/josevalim/rails-footnotes/hooks","issue_events_url":"https://api.github.com/repos/josevalim/rails-footnotes/issues/events{/number}","events_url":"https://api.github.com/repos/josevalim/rails-footnotes/events","assignees_url":"https://api.github.com/repos/josevalim/rails-footnotes/assignees{/user}","branches_url":"https://api.github.com/repos/josevalim/rails-footnotes/branches{/branch}","tags_url":"https://api.github.com/repos/josevalim/rails-footnotes/tags","blobs_url":"https://api.github.com/repos/josevalim/rails-footnotes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josevalim/rails-footnotes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josevalim/rails-footnotes/git/refs{/sha}","trees_url":"https://api.github.com/repos/josevalim/rails-footnotes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josevalim/rails-footnotes/statuses/{sha}","languages_url":"https://api.github.com/repos/josevalim/rails-footnotes/languages","stargazers_url":"https://api.github.com/repos/josevalim/rails-footnotes/stargazers","contributors_url":"https://api.github.com/repos/josevalim/rails-footnotes/contributors","subscribers_url":"https://api.github.com/repos/josevalim/rails-footnotes/subscribers","subscription_url":"https://api.github.com/repos/josevalim/rails-footnotes/subscription","commits_url":"https://api.github.com/repos/josevalim/rails-footnotes/commits{/sha}","git_commits_url":"https://api.github.com/repos/josevalim/rails-footnotes/git/commits{/sha}","comments_url":"https://api.github.com/repos/josevalim/rails-footnotes/comments{/number}","issue_comment_url":"https://api.github.com/repos/josevalim/rails-footnotes/issues/comments/{number}","contents_url":"https://api.github.com/repos/josevalim/rails-footnotes/contents/{+path}","compare_url":"https://api.github.com/repos/josevalim/rails-footnotes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josevalim/rails-footnotes/merges","archive_url":"https://api.github.com/repos/josevalim/rails-footnotes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josevalim/rails-footnotes/downloads","issues_url":"https://api.github.com/repos/josevalim/rails-footnotes/issues{/number}","pulls_url":"https://api.github.com/repos/josevalim/rails-footnotes/pulls{/number}","milestones_url":"https://api.github.com/repos/josevalim/rails-footnotes/milestones{/number}","notifications_url":"https://api.github.com/repos/josevalim/rails-footnotes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josevalim/rails-footnotes/labels{/name}","releases_url":"https://api.github.com/repos/josevalim/rails-footnotes/releases{/id}","created_at":"2008-12-18T13:21:16Z","updated_at":"2014-03-23T12:10:41Z","pushed_at":"2014-03-23T12:10:41Z","git_url":"git://github.com/josevalim/rails-footnotes.git","ssh_url":"git@github.com:josevalim/rails-footnotes.git","clone_url":"https://github.com/josevalim/rails-footnotes.git","svn_url":"https://github.com/josevalim/rails-footnotes","homepage":"http://blog.plataformatec.com.br/","size":1323,"stargazers_count":1177,"watchers_count":1177,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":108,"mirror_url":null,"open_issues_count":13,"forks":108,"open_issues":13,"watchers":1177,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/josevalim/rails-footnotes/pulls/106"},"html":{"href":"https://github.com/josevalim/rails-footnotes/pull/106"},"issue":{"href":"https://api.github.com/repos/josevalim/rails-footnotes/issues/106"},"comments":{"href":"https://api.github.com/repos/josevalim/rails-footnotes/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/josevalim/rails-footnotes/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/josevalim/rails-footnotes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/josevalim/rails-footnotes/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/josevalim/rails-footnotes/statuses/669d3f7afa19aba48e5ea627161e409dae3323f6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":44,"deletions":5,"changed_files":3}}