GitHub PullRequestReviewCommentEvent at 2014-06-26 15:27:18
Repository: dough
Actor: ourmaninamsterdam
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/moneyadviceservice/dough/pulls/comments/14247155","id":14247155,"diff_hunk":"@@ -5,41 +5,23 @@\n  * @return {[type]}           [description]\n  * @private\n  */\n-define(['jquery', 'MASModule', 'featureDetect'], function ($, MASModule, featureDetect) {\n+define(['jquery', 'MASModule', 'featureDetect', 'eventsWithPromises'], function ($, MASModule, featureDetect, eventsWithPromises) {\n   'use strict';\n \n-  /**\n+  var defaultConfig = {\n+      keepSynced: true\n+    },\n+\n+    /**\n    * Call base constructor\n    * @constructor\n    */\n-  var RangeInput = function () {\n+  RangeInput = function ($el, config) {","path":"js/components/RangeInput.js","position":18,"original_position":18,"commit_id":"2dc94148ccab2b228e55c8210e8421db3dafaaef","original_commit_id":"2dc94148ccab2b228e55c8210e8421db3dafaaef","user":{"login":"ourmaninamsterdam","id":1579511,"avatar_url":"https://avatars.githubusercontent.com/u/1579511?","gravatar_id":"5e4c7060b86bd0f53f4c83beb6e8792d","url":"https://api.github.com/users/ourmaninamsterdam","html_url":"https://github.com/ourmaninamsterdam","followers_url":"https://api.github.com/users/ourmaninamsterdam/followers","following_url":"https://api.github.com/users/ourmaninamsterdam/following{/other_user}","gists_url":"https://api.github.com/users/ourmaninamsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/ourmaninamsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ourmaninamsterdam/subscriptions","organizations_url":"https://api.github.com/users/ourmaninamsterdam/orgs","repos_url":"https://api.github.com/users/ourmaninamsterdam/repos","events_url":"https://api.github.com/users/ourmaninamsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/ourmaninamsterdam/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2014-06-26T15:27:18Z","updated_at":"2014-06-26T15:27:18Z","html_url":"https://github.com/moneyadviceservice/dough/pull/76#discussion_r14247155","pull_request_url":"https://api.github.com/repos/moneyadviceservice/dough/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/dough/pulls/comments/14247155"},"html":{"href":"https://github.com/moneyadviceservice/dough/pull/76#discussion_r14247155"},"pull_request":{"href":"https://api.github.com/repos/moneyadviceservice/dough/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/dough/pulls/76","id":17597290,"html_url":"https://github.com/moneyadviceservice/dough/pull/76","diff_url":"https://github.com/moneyadviceservice/dough/pull/76.diff","patch_url":"https://github.com/moneyadviceservice/dough/pull/76.patch","issue_url":"https://api.github.com/repos/moneyadviceservice/dough/issues/76","number":76,"state":"open","title":"Range input - refactor","user":{"login":"jonwyatt-mas","id":6770569,"avatar_url":"https://avatars.githubusercontent.com/u/6770569?","gravatar_id":"9237e6103f9eb930bf178acb009776e9","url":"https://api.github.com/users/jonwyatt-mas","html_url":"https://github.com/jonwyatt-mas","followers_url":"https://api.github.com/users/jonwyatt-mas/followers","following_url":"https://api.github.com/users/jonwyatt-mas/following{/other_user}","gists_url":"https://api.github.com/users/jonwyatt-mas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonwyatt-mas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonwyatt-mas/subscriptions","organizations_url":"https://api.github.com/users/jonwyatt-mas/orgs","repos_url":"https://api.github.com/users/jonwyatt-mas/repos","events_url":"https://api.github.com/users/jonwyatt-mas/events{/privacy}","received_events_url":"https://api.github.com/users/jonwyatt-mas/received_events","type":"User","site_admin":false},"body":"- don't assume rivets bindings\r\n- sync both inputs on change and fire an event\r\n- rename class (not a variant of form__input).","created_at":"2014-06-25T15:25:13Z","updated_at":"2014-06-26T15:27:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"509f0505824486ff8981f6b18e158a4c0dadb233","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moneyadviceservice/dough/pulls/76/commits","review_comments_url":"https://api.github.com/repos/moneyadviceservice/dough/pulls/76/comments","review_comment_url":"https://api.github.com/repos/moneyadviceservice/dough/pulls/comments/{number}","comments_url":"https://api.github.com/repos/moneyadviceservice/dough/issues/76/comments","statuses_url":"https://api.github.com/repos/moneyadviceservice/dough/statuses/2dc94148ccab2b228e55c8210e8421db3dafaaef","head":{"label":"moneyadviceservice:js-range-refactor","ref":"js-range-refactor","sha":"2dc94148ccab2b228e55c8210e8421db3dafaaef","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?","gravatar_id":"6c3f1060f901222015e8af3abd5f707b","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":18567017,"name":"dough","full_name":"moneyadviceservice/dough","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?","gravatar_id":"6c3f1060f901222015e8af3abd5f707b","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/dough","description":"Repository for the shared frontend assets for the Money Advice Service Website and associated tools","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/dough","forks_url":"https://api.github.com/repos/moneyadviceservice/dough/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/dough/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/dough/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/dough/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/dough/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/dough/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/dough/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/dough/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/dough/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/dough/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/dough/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/dough/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/dough/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/dough/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/dough/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/dough/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/dough/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/dough/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/dough/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/dough/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/dough/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/dough/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/dough/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/dough/issues/comments/{number}","contents_url":"https://api.github.com/repos/moneyadviceservice/dough/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/dough/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/dough/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/dough/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/dough/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/dough/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/dough/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/dough/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/dough/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/dough/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/dough/releases{/id}","created_at":"2014-04-08T17:02:46Z","updated_at":"2014-06-26T10:23:25Z","pushed_at":"2014-06-26T15:24:29Z","git_url":"git://github.com/moneyadviceservice/dough.git","ssh_url":"git@github.com:moneyadviceservice/dough.git","clone_url":"https://github.com/moneyadviceservice/dough.git","svn_url":"https://github.com/moneyadviceservice/dough","homepage":"","size":3933,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"moneyadviceservice:master","ref":"master","sha":"de4764b24b3022d770eeb7d9d5807ad651958334","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?","gravatar_id":"6c3f1060f901222015e8af3abd5f707b","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":18567017,"name":"dough","full_name":"moneyadviceservice/dough","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?","gravatar_id":"6c3f1060f901222015e8af3abd5f707b","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/dough","description":"Repository for the shared frontend assets for the Money Advice Service Website and associated tools","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/dough","forks_url":"https://api.github.com/repos/moneyadviceservice/dough/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/dough/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/dough/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/dough/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/dough/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/dough/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/dough/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/dough/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/dough/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/dough/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/dough/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/dough/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/dough/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/dough/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/dough/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/dough/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/dough/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/dough/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/dough/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/dough/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/dough/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/dough/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/dough/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/dough/issues/comments/{number}","contents_url":"https://api.github.com/repos/moneyadviceservice/dough/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/dough/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/dough/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/dough/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/dough/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/dough/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/dough/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/dough/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/dough/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/dough/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/dough/releases{/id}","created_at":"2014-04-08T17:02:46Z","updated_at":"2014-06-26T10:23:25Z","pushed_at":"2014-06-26T15:24:29Z","git_url":"git://github.com/moneyadviceservice/dough.git","ssh_url":"git@github.com:moneyadviceservice/dough.git","clone_url":"https://github.com/moneyadviceservice/dough.git","svn_url":"https://github.com/moneyadviceservice/dough","homepage":"","size":3933,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/dough/pulls/76"},"html":{"href":"https://github.com/moneyadviceservice/dough/pull/76"},"issue":{"href":"https://api.github.com/repos/moneyadviceservice/dough/issues/76"},"comments":{"href":"https://api.github.com/repos/moneyadviceservice/dough/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/moneyadviceservice/dough/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/moneyadviceservice/dough/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/moneyadviceservice/dough/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/moneyadviceservice/dough/statuses/2dc94148ccab2b228e55c8210e8421db3dafaaef"}}}}