GitHub PullRequestReviewCommentEvent at 2014-06-05 13:38:07
Repository: marine-integrations
Actor: wfrench
Payload: {"comment":{"url":"https://api.github.com/repos/ooici/marine-integrations/pulls/comments/13439398","id":13439398,"diff_hunk":"@@ -221,7 +184,7 @@ def _build_parsed_values(self):\n \n         dom = parseString(self.raw_data)\n         root = dom.documentElement\n-        log.debug(\"root.tagName = %s\" %root.tagName)\n+        log.debug(\"root.tagName = %s\" % root.tagName)","path":"mi/instrument/seabird/sbe16plus_v2/ctdbp_no/driver.py","position":147,"original_position":147,"commit_id":"3a1ff274a03cf1b733c4b40a7cd3fc1c0d779ae1","original_commit_id":"3a1ff274a03cf1b733c4b40a7cd3fc1c0d779ae1","user":{"login":"wfrench","id":1341144,"avatar_url":"https://avatars.githubusercontent.com/u/1341144?","gravatar_id":"b7eed9ff0c039729f79f1ec61df9e904","url":"https://api.github.com/users/wfrench","html_url":"https://github.com/wfrench","followers_url":"https://api.github.com/users/wfrench/followers","following_url":"https://api.github.com/users/wfrench/following{/other_user}","gists_url":"https://api.github.com/users/wfrench/gists{/gist_id}","starred_url":"https://api.github.com/users/wfrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfrench/subscriptions","organizations_url":"https://api.github.com/users/wfrench/orgs","repos_url":"https://api.github.com/users/wfrench/repos","events_url":"https://api.github.com/users/wfrench/events{/privacy}","received_events_url":"https://api.github.com/users/wfrench/received_events","type":"User","site_admin":false},"body":"No need for a change here, but for future reference you may want to pass parameters to the debug method instead of composing the string as the single parameter.  The benefit is if the log level isn't sufficient to display the method the parameters will not be evaluated and the string won't be formatted.  \r\n\r\npreferred:\r\n\r\nlog.debug(\"root.tagName = %s\", root.tagName)\r\n\r\n","created_at":"2014-06-05T13:38:07Z","updated_at":"2014-06-05T13:38:07Z","html_url":"https://github.com/ooici/marine-integrations/pull/222#discussion_r13439398","pull_request_url":"https://api.github.com/repos/ooici/marine-integrations/pulls/222","_links":{"self":{"href":"https://api.github.com/repos/ooici/marine-integrations/pulls/comments/13439398"},"html":{"href":"https://github.com/ooici/marine-integrations/pull/222#discussion_r13439398"},"pull_request":{"href":"https://api.github.com/repos/ooici/marine-integrations/pulls/222"}}}}