GitHub PullRequestEvent at 2014-05-08 20:24:51
Repository: shoes4
Actor: PragTob
Payload: {"action":"opened","number":694,"pull_request":{"url":"https://api.github.com/repos/shoes/shoes4/pulls/694","id":15671661,"html_url":"https://github.com/shoes/shoes4/pull/694","diff_url":"https://github.com/shoes/shoes4/pull/694.diff","patch_url":"https://github.com/shoes/shoes4/pull/694.patch","issue_url":"https://api.github.com/repos/shoes/shoes4/issues/694","number":694,"state":"open","title":"start being able to be positioned relative to parent extent","user":{"login":"PragTob","id":606517,"avatar_url":"https://avatars.githubusercontent.com/u/606517?","gravatar_id":"8480daec7137f28565bc2d2e666b915a","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"body":"* fixes #690\r\n* I introduced the constraint of the value being smaller than 1\r\n  because it should be rare for elements to be positioned outside\r\n  of their parent container and if so not relative to it. I'm\r\n  scared about cases where people do calculations ending up in\r\n  floats and suddenly 100.3 is interpreted as 100 times the\r\n  width of the parent. Would be weird.\r\n* I'm a bit unhappy with the code have a quick look please @wasnotrice @jasonrclark","created_at":"2014-05-08T20:24:50Z","updated_at":"2014-05-08T20:24:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shoes/shoes4/pulls/694/commits","review_comments_url":"https://api.github.com/repos/shoes/shoes4/pulls/694/comments","review_comment_url":"https://api.github.com/repos/shoes/shoes4/pulls/comments/{number}","comments_url":"https://api.github.com/repos/shoes/shoes4/issues/694/comments","statuses_url":"https://api.github.com/repos/shoes/shoes4/statuses/c6bb538d7fbff6b54de01c2769a17b3b00db8f39","head":{"label":"PragTob:relative_position","ref":"relative_position","sha":"c6bb538d7fbff6b54de01c2769a17b3b00db8f39","user":{"login":"PragTob","id":606517,"avatar_url":"https://avatars.githubusercontent.com/u/606517?","gravatar_id":"8480daec7137f28565bc2d2e666b915a","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"repo":{"id":4599307,"name":"shoes4","full_name":"PragTob/shoes4","owner":{"login":"PragTob","id":606517,"avatar_url":"https://avatars.githubusercontent.com/u/606517?","gravatar_id":"8480daec7137f28565bc2d2e666b915a","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PragTob/shoes4","description":"Shoes 4 : the next version of Shoes","fork":true,"url":"https://api.github.com/repos/PragTob/shoes4","forks_url":"https://api.github.com/repos/PragTob/shoes4/forks","keys_url":"https://api.github.com/repos/PragTob/shoes4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PragTob/shoes4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PragTob/shoes4/teams","hooks_url":"https://api.github.com/repos/PragTob/shoes4/hooks","issue_events_url":"https://api.github.com/repos/PragTob/shoes4/issues/events{/number}","events_url":"https://api.github.com/repos/PragTob/shoes4/events","assignees_url":"https://api.github.com/repos/PragTob/shoes4/assignees{/user}","branches_url":"https://api.github.com/repos/PragTob/shoes4/branches{/branch}","tags_url":"https://api.github.com/repos/PragTob/shoes4/tags","blobs_url":"https://api.github.com/repos/PragTob/shoes4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PragTob/shoes4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PragTob/shoes4/git/refs{/sha}","trees_url":"https://api.github.com/repos/PragTob/shoes4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PragTob/shoes4/statuses/{sha}","languages_url":"https://api.github.com/repos/PragTob/shoes4/languages","stargazers_url":"https://api.github.com/repos/PragTob/shoes4/stargazers","contributors_url":"https://api.github.com/repos/PragTob/shoes4/contributors","subscribers_url":"https://api.github.com/repos/PragTob/shoes4/subscribers","subscription_url":"https://api.github.com/repos/PragTob/shoes4/subscription","commits_url":"https://api.github.com/repos/PragTob/shoes4/commits{/sha}","git_commits_url":"https://api.github.com/repos/PragTob/shoes4/git/commits{/sha}","comments_url":"https://api.github.com/repos/PragTob/shoes4/comments{/number}","issue_comment_url":"https://api.github.com/repos/PragTob/shoes4/issues/comments/{number}","contents_url":"https://api.github.com/repos/PragTob/shoes4/contents/{+path}","compare_url":"https://api.github.com/repos/PragTob/shoes4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PragTob/shoes4/merges","archive_url":"https://api.github.com/repos/PragTob/shoes4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PragTob/shoes4/downloads","issues_url":"https://api.github.com/repos/PragTob/shoes4/issues{/number}","pulls_url":"https://api.github.com/repos/PragTob/shoes4/pulls{/number}","milestones_url":"https://api.github.com/repos/PragTob/shoes4/milestones{/number}","notifications_url":"https://api.github.com/repos/PragTob/shoes4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PragTob/shoes4/labels{/name}","releases_url":"https://api.github.com/repos/PragTob/shoes4/releases{/id}","created_at":"2012-06-08T16:04:31Z","updated_at":"2014-05-08T20:24:50Z","pushed_at":"2014-05-08T20:23:19Z","git_url":"git://github.com/PragTob/shoes4.git","ssh_url":"git@github.com:PragTob/shoes4.git","clone_url":"https://github.com/PragTob/shoes4.git","svn_url":"https://github.com/PragTob/shoes4","homepage":"","size":59327,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"shoes:master","ref":"master","sha":"9676a29b31287f266e01a9358cf176cf32ec86dc","user":{"login":"shoes","id":119935,"avatar_url":"https://avatars.githubusercontent.com/u/119935?","gravatar_id":"9391c058f48d0d0be732502d4825783b","url":"https://api.github.com/users/shoes","html_url":"https://github.com/shoes","followers_url":"https://api.github.com/users/shoes/followers","following_url":"https://api.github.com/users/shoes/following{/other_user}","gists_url":"https://api.github.com/users/shoes/gists{/gist_id}","starred_url":"https://api.github.com/users/shoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoes/subscriptions","organizations_url":"https://api.github.com/users/shoes/orgs","repos_url":"https://api.github.com/users/shoes/repos","events_url":"https://api.github.com/users/shoes/events{/privacy}","received_events_url":"https://api.github.com/users/shoes/received_events","type":"Organization","site_admin":false},"repo":{"id":4434126,"name":"shoes4","full_name":"shoes/shoes4","owner":{"login":"shoes","id":119935,"avatar_url":"https://avatars.githubusercontent.com/u/119935?","gravatar_id":"9391c058f48d0d0be732502d4825783b","url":"https://api.github.com/users/shoes","html_url":"https://github.com/shoes","followers_url":"https://api.github.com/users/shoes/followers","following_url":"https://api.github.com/users/shoes/following{/other_user}","gists_url":"https://api.github.com/users/shoes/gists{/gist_id}","starred_url":"https://api.github.com/users/shoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoes/subscriptions","organizations_url":"https://api.github.com/users/shoes/orgs","repos_url":"https://api.github.com/users/shoes/repos","events_url":"https://api.github.com/users/shoes/events{/privacy}","received_events_url":"https://api.github.com/users/shoes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shoes/shoes4","description":"Shoes 4 : the next version of Shoes","fork":false,"url":"https://api.github.com/repos/shoes/shoes4","forks_url":"https://api.github.com/repos/shoes/shoes4/forks","keys_url":"https://api.github.com/repos/shoes/shoes4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shoes/shoes4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shoes/shoes4/teams","hooks_url":"https://api.github.com/repos/shoes/shoes4/hooks","issue_events_url":"https://api.github.com/repos/shoes/shoes4/issues/events{/number}","events_url":"https://api.github.com/repos/shoes/shoes4/events","assignees_url":"https://api.github.com/repos/shoes/shoes4/assignees{/user}","branches_url":"https://api.github.com/repos/shoes/shoes4/branches{/branch}","tags_url":"https://api.github.com/repos/shoes/shoes4/tags","blobs_url":"https://api.github.com/repos/shoes/shoes4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shoes/shoes4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shoes/shoes4/git/refs{/sha}","trees_url":"https://api.github.com/repos/shoes/shoes4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shoes/shoes4/statuses/{sha}","languages_url":"https://api.github.com/repos/shoes/shoes4/languages","stargazers_url":"https://api.github.com/repos/shoes/shoes4/stargazers","contributors_url":"https://api.github.com/repos/shoes/shoes4/contributors","subscribers_url":"https://api.github.com/repos/shoes/shoes4/subscribers","subscription_url":"https://api.github.com/repos/shoes/shoes4/subscription","commits_url":"https://api.github.com/repos/shoes/shoes4/commits{/sha}","git_commits_url":"https://api.github.com/repos/shoes/shoes4/git/commits{/sha}","comments_url":"https://api.github.com/repos/shoes/shoes4/comments{/number}","issue_comment_url":"https://api.github.com/repos/shoes/shoes4/issues/comments/{number}","contents_url":"https://api.github.com/repos/shoes/shoes4/contents/{+path}","compare_url":"https://api.github.com/repos/shoes/shoes4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shoes/shoes4/merges","archive_url":"https://api.github.com/repos/shoes/shoes4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shoes/shoes4/downloads","issues_url":"https://api.github.com/repos/shoes/shoes4/issues{/number}","pulls_url":"https://api.github.com/repos/shoes/shoes4/pulls{/number}","milestones_url":"https://api.github.com/repos/shoes/shoes4/milestones{/number}","notifications_url":"https://api.github.com/repos/shoes/shoes4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shoes/shoes4/labels{/name}","releases_url":"https://api.github.com/repos/shoes/shoes4/releases{/id}","created_at":"2012-05-24T14:57:59Z","updated_at":"2014-05-08T19:10:25Z","pushed_at":"2014-05-08T18:58:29Z","git_url":"git://github.com/shoes/shoes4.git","ssh_url":"git@github.com:shoes/shoes4.git","clone_url":"https://github.com/shoes/shoes4.git","svn_url":"https://github.com/shoes/shoes4","homepage":"","size":65376,"stargazers_count":505,"watchers_count":505,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":114,"mirror_url":null,"open_issues_count":108,"forks":114,"open_issues":108,"watchers":505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shoes/shoes4/pulls/694"},"html":{"href":"https://github.com/shoes/shoes4/pull/694"},"issue":{"href":"https://api.github.com/repos/shoes/shoes4/issues/694"},"comments":{"href":"https://api.github.com/repos/shoes/shoes4/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/shoes/shoes4/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/shoes/shoes4/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/shoes/shoes4/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/shoes/shoes4/statuses/c6bb538d7fbff6b54de01c2769a17b3b00db8f39"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":35,"deletions":14,"changed_files":2}}