GitHub PullRequestReviewCommentEvent at 2014-10-19 18:40:26
Repository: jquery-ui
Actor: scottgonzalez
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery-ui/pulls/comments/19062350","id":19062350,"diff_hunk":"@@ -100,6 +100,10 @@ $.widget( \"ui.droppable\", {\n \t\tthis._splice( drop );\n \n \t\tthis.element.removeClass( \"ui-droppable ui-droppable-disabled\" );\n+\n+        if($.ui.ddmanager.current && ($.ui.ddmanager.current.element === this.element)) {","path":"ui/droppable.js","position":5,"original_position":5,"commit_id":"90ea864d85fd500afe3aeb8826ddbc97d305801b","original_commit_id":"90ea864d85fd500afe3aeb8826ddbc97d305801b","user":{"login":"scottgonzalez","id":141167,"avatar_url":"https://avatars.githubusercontent.com/u/141167?v=2","gravatar_id":"","url":"https://api.github.com/users/scottgonzalez","html_url":"https://github.com/scottgonzalez","followers_url":"https://api.github.com/users/scottgonzalez/followers","following_url":"https://api.github.com/users/scottgonzalez/following{/other_user}","gists_url":"https://api.github.com/users/scottgonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/scottgonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottgonzalez/subscriptions","organizations_url":"https://api.github.com/users/scottgonzalez/orgs","repos_url":"https://api.github.com/users/scottgonzalez/repos","events_url":"https://api.github.com/users/scottgonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/scottgonzalez/received_events","type":"User","site_admin":false},"body":"Comparing jQuery objects for equality is never a good idea. Check the underlying element.","created_at":"2014-10-19T18:40:26Z","updated_at":"2014-10-19T18:40:26Z","html_url":"https://github.com/jquery/jquery-ui/pull/1360#discussion_r19062350","pull_request_url":"https://api.github.com/repos/jquery/jquery-ui/pulls/1360","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/comments/19062350"},"html":{"href":"https://github.com/jquery/jquery-ui/pull/1360#discussion_r19062350"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/1360"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery-ui/pulls/1360","id":22977266,"html_url":"https://github.com/jquery/jquery-ui/pull/1360","diff_url":"https://github.com/jquery/jquery-ui/pull/1360.diff","patch_url":"https://github.com/jquery/jquery-ui/pull/1360.patch","issue_url":"https://api.github.com/repos/jquery/jquery-ui/issues/1360","number":1360,"state":"open","locked":false,"title":"Droppable: $.ui.ddmanager.current released when droppable destroys","user":{"login":"eshcharc","id":670483,"avatar_url":"https://avatars.githubusercontent.com/u/670483?v=2","gravatar_id":"","url":"https://api.github.com/users/eshcharc","html_url":"https://github.com/eshcharc","followers_url":"https://api.github.com/users/eshcharc/followers","following_url":"https://api.github.com/users/eshcharc/following{/other_user}","gists_url":"https://api.github.com/users/eshcharc/gists{/gist_id}","starred_url":"https://api.github.com/users/eshcharc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshcharc/subscriptions","organizations_url":"https://api.github.com/users/eshcharc/orgs","repos_url":"https://api.github.com/users/eshcharc/repos","events_url":"https://api.github.com/users/eshcharc/events{/privacy}","received_events_url":"https://api.github.com/users/eshcharc/received_events","type":"User","site_admin":false},"body":"Fixes #10666","created_at":"2014-10-19T06:10:22Z","updated_at":"2014-10-19T18:40:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9688e934df250461dcd3c1dcf2e76565a5e5afe9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/jquery-ui/pulls/1360/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery-ui/pulls/1360/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery-ui/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jquery/jquery-ui/issues/1360/comments","statuses_url":"https://api.github.com/repos/jquery/jquery-ui/statuses/90ea864d85fd500afe3aeb8826ddbc97d305801b","head":{"label":"eshcharc:droppable","ref":"droppable","sha":"90ea864d85fd500afe3aeb8826ddbc97d305801b","user":{"login":"eshcharc","id":670483,"avatar_url":"https://avatars.githubusercontent.com/u/670483?v=2","gravatar_id":"","url":"https://api.github.com/users/eshcharc","html_url":"https://github.com/eshcharc","followers_url":"https://api.github.com/users/eshcharc/followers","following_url":"https://api.github.com/users/eshcharc/following{/other_user}","gists_url":"https://api.github.com/users/eshcharc/gists{/gist_id}","starred_url":"https://api.github.com/users/eshcharc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshcharc/subscriptions","organizations_url":"https://api.github.com/users/eshcharc/orgs","repos_url":"https://api.github.com/users/eshcharc/repos","events_url":"https://api.github.com/users/eshcharc/events{/privacy}","received_events_url":"https://api.github.com/users/eshcharc/received_events","type":"User","site_admin":false},"repo":{"id":25419016,"name":"jquery-ui","full_name":"eshcharc/jquery-ui","owner":{"login":"eshcharc","id":670483,"avatar_url":"https://avatars.githubusercontent.com/u/670483?v=2","gravatar_id":"","url":"https://api.github.com/users/eshcharc","html_url":"https://github.com/eshcharc","followers_url":"https://api.github.com/users/eshcharc/followers","following_url":"https://api.github.com/users/eshcharc/following{/other_user}","gists_url":"https://api.github.com/users/eshcharc/gists{/gist_id}","starred_url":"https://api.github.com/users/eshcharc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshcharc/subscriptions","organizations_url":"https://api.github.com/users/eshcharc/orgs","repos_url":"https://api.github.com/users/eshcharc/repos","events_url":"https://api.github.com/users/eshcharc/events{/privacy}","received_events_url":"https://api.github.com/users/eshcharc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eshcharc/jquery-ui","description":"The official jQuery user interface library.","fork":true,"url":"https://api.github.com/repos/eshcharc/jquery-ui","forks_url":"https://api.github.com/repos/eshcharc/jquery-ui/forks","keys_url":"https://api.github.com/repos/eshcharc/jquery-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eshcharc/jquery-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eshcharc/jquery-ui/teams","hooks_url":"https://api.github.com/repos/eshcharc/jquery-ui/hooks","issue_events_url":"https://api.github.com/repos/eshcharc/jquery-ui/issues/events{/number}","events_url":"https://api.github.com/repos/eshcharc/jquery-ui/events","assignees_url":"https://api.github.com/repos/eshcharc/jquery-ui/assignees{/user}","branches_url":"https://api.github.com/repos/eshcharc/jquery-ui/branches{/branch}","tags_url":"https://api.github.com/repos/eshcharc/jquery-ui/tags","blobs_url":"https://api.github.com/repos/eshcharc/jquery-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eshcharc/jquery-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eshcharc/jquery-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/eshcharc/jquery-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eshcharc/jquery-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/eshcharc/jquery-ui/languages","stargazers_url":"https://api.github.com/repos/eshcharc/jquery-ui/stargazers","contributors_url":"https://api.github.com/repos/eshcharc/jquery-ui/contributors","subscribers_url":"https://api.github.com/repos/eshcharc/jquery-ui/subscribers","subscription_url":"https://api.github.com/repos/eshcharc/jquery-ui/subscription","commits_url":"https://api.github.com/repos/eshcharc/jquery-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/eshcharc/jquery-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/eshcharc/jquery-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/eshcharc/jquery-ui/issues/comments/{number}","contents_url":"https://api.github.com/repos/eshcharc/jquery-ui/contents/{+path}","compare_url":"https://api.github.com/repos/eshcharc/jquery-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eshcharc/jquery-ui/merges","archive_url":"https://api.github.com/repos/eshcharc/jquery-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eshcharc/jquery-ui/downloads","issues_url":"https://api.github.com/repos/eshcharc/jquery-ui/issues{/number}","pulls_url":"https://api.github.com/repos/eshcharc/jquery-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/eshcharc/jquery-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/eshcharc/jquery-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eshcharc/jquery-ui/labels{/name}","releases_url":"https://api.github.com/repos/eshcharc/jquery-ui/releases{/id}","created_at":"2014-10-19T05:45:24Z","updated_at":"2014-10-19T04:56:48Z","pushed_at":"2014-10-19T06:37:34Z","git_url":"git://github.com/eshcharc/jquery-ui.git","ssh_url":"git@github.com:eshcharc/jquery-ui.git","clone_url":"https://github.com/eshcharc/jquery-ui.git","svn_url":"https://github.com/eshcharc/jquery-ui","homepage":"http://jqueryui.com/","size":48621,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"c0df7b01385f0c3eb100a3f841625cae1b180185","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=2","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":478996,"name":"jquery-ui","full_name":"jquery/jquery-ui","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=2","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery-ui","description":"The official jQuery user interface library.","fork":false,"url":"https://api.github.com/repos/jquery/jquery-ui","forks_url":"https://api.github.com/repos/jquery/jquery-ui/forks","keys_url":"https://api.github.com/repos/jquery/jquery-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery-ui/teams","hooks_url":"https://api.github.com/repos/jquery/jquery-ui/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery-ui/events","assignees_url":"https://api.github.com/repos/jquery/jquery-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery-ui/tags","blobs_url":"https://api.github.com/repos/jquery/jquery-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery-ui/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery-ui/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery-ui/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery-ui/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery-ui/subscription","commits_url":"https://api.github.com/repos/jquery/jquery-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery-ui/issues/comments/{number}","contents_url":"https://api.github.com/repos/jquery/jquery-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery-ui/merges","archive_url":"https://api.github.com/repos/jquery/jquery-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery-ui/downloads","issues_url":"https://api.github.com/repos/jquery/jquery-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery-ui/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery-ui/releases{/id}","created_at":"2010-01-19T14:40:34Z","updated_at":"2014-10-19T18:30:16Z","pushed_at":"2014-10-17T15:30:27Z","git_url":"git://github.com/jquery/jquery-ui.git","ssh_url":"git@github.com:jquery/jquery-ui.git","clone_url":"https://github.com/jquery/jquery-ui.git","svn_url":"https://github.com/jquery/jquery-ui","homepage":"http://jqueryui.com/","size":48621,"stargazers_count":8590,"watchers_count":8590,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3208,"mirror_url":null,"open_issues_count":43,"forks":3208,"open_issues":43,"watchers":8590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/1360"},"html":{"href":"https://github.com/jquery/jquery-ui/pull/1360"},"issue":{"href":"https://api.github.com/repos/jquery/jquery-ui/issues/1360"},"comments":{"href":"https://api.github.com/repos/jquery/jquery-ui/issues/1360/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/1360/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/1360/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery-ui/statuses/90ea864d85fd500afe3aeb8826ddbc97d305801b"}}}}