GitHub PullRequestEvent at 2014-11-03 07:42:08
Repository: vimium
Actor: smblott-github
Payload: {"action":"opened","number":1222,"pull_request":{"url":"https://api.github.com/repos/philc/vimium/pulls/1222","id":23746066,"html_url":"https://github.com/philc/vimium/pull/1222","diff_url":"https://github.com/philc/vimium/pull/1222.diff","patch_url":"https://github.com/philc/vimium/pull/1222.patch","issue_url":"https://api.github.com/repos/philc/vimium/issues/1222","number":1222,"state":"open","locked":false,"title":"Control-Enter in page popup to save and close","user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=2","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"body":"For me, *by far* the most common page popup use case is to add or remove a couple of pass keys.  This PR:\r\n- Focuses the pass keys text input when the popup is opened.\r\n- Activates both text inputs such that `Control-Enter` saves changes and closes the popup.\r\n\r\nFor other use cases (such as removing a rule), no extra keystrokes/clicks are required.\r\n\r\nWith this change, you can add or remove pass keys without touching the mouse.*\r\n\r\n<sub>(* Assuming you have a chrome shortcut to open the vimium popup.)</sub>","created_at":"2014-11-03T07:42:07Z","updated_at":"2014-11-03T07:42:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44e98a4fd2b9c43a38619a9a90abfe41f3c605c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/philc/vimium/pulls/1222/commits","review_comments_url":"https://api.github.com/repos/philc/vimium/pulls/1222/comments","review_comment_url":"https://api.github.com/repos/philc/vimium/pulls/comments/{number}","comments_url":"https://api.github.com/repos/philc/vimium/issues/1222/comments","statuses_url":"https://api.github.com/repos/philc/vimium/statuses/0c590003ed6c0ee465dc8f84efc5cfc54774a94e","head":{"label":"smblott-github:popup-control-enter-to-save-and-close","ref":"popup-control-enter-to-save-and-close","sha":"0c590003ed6c0ee465dc8f84efc5cfc54774a94e","user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=2","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"repo":{"id":18924701,"name":"vimium","full_name":"smblott-github/vimium","owner":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=2","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smblott-github/vimium","description":"The hacker's browser.","fork":true,"url":"https://api.github.com/repos/smblott-github/vimium","forks_url":"https://api.github.com/repos/smblott-github/vimium/forks","keys_url":"https://api.github.com/repos/smblott-github/vimium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smblott-github/vimium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smblott-github/vimium/teams","hooks_url":"https://api.github.com/repos/smblott-github/vimium/hooks","issue_events_url":"https://api.github.com/repos/smblott-github/vimium/issues/events{/number}","events_url":"https://api.github.com/repos/smblott-github/vimium/events","assignees_url":"https://api.github.com/repos/smblott-github/vimium/assignees{/user}","branches_url":"https://api.github.com/repos/smblott-github/vimium/branches{/branch}","tags_url":"https://api.github.com/repos/smblott-github/vimium/tags","blobs_url":"https://api.github.com/repos/smblott-github/vimium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smblott-github/vimium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smblott-github/vimium/git/refs{/sha}","trees_url":"https://api.github.com/repos/smblott-github/vimium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smblott-github/vimium/statuses/{sha}","languages_url":"https://api.github.com/repos/smblott-github/vimium/languages","stargazers_url":"https://api.github.com/repos/smblott-github/vimium/stargazers","contributors_url":"https://api.github.com/repos/smblott-github/vimium/contributors","subscribers_url":"https://api.github.com/repos/smblott-github/vimium/subscribers","subscription_url":"https://api.github.com/repos/smblott-github/vimium/subscription","commits_url":"https://api.github.com/repos/smblott-github/vimium/commits{/sha}","git_commits_url":"https://api.github.com/repos/smblott-github/vimium/git/commits{/sha}","comments_url":"https://api.github.com/repos/smblott-github/vimium/comments{/number}","issue_comment_url":"https://api.github.com/repos/smblott-github/vimium/issues/comments/{number}","contents_url":"https://api.github.com/repos/smblott-github/vimium/contents/{+path}","compare_url":"https://api.github.com/repos/smblott-github/vimium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smblott-github/vimium/merges","archive_url":"https://api.github.com/repos/smblott-github/vimium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smblott-github/vimium/downloads","issues_url":"https://api.github.com/repos/smblott-github/vimium/issues{/number}","pulls_url":"https://api.github.com/repos/smblott-github/vimium/pulls{/number}","milestones_url":"https://api.github.com/repos/smblott-github/vimium/milestones{/number}","notifications_url":"https://api.github.com/repos/smblott-github/vimium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smblott-github/vimium/labels{/name}","releases_url":"https://api.github.com/repos/smblott-github/vimium/releases{/id}","created_at":"2014-04-18T20:29:25Z","updated_at":"2014-10-18T12:22:10Z","pushed_at":"2014-11-03T07:33:35Z","git_url":"git://github.com/smblott-github/vimium.git","ssh_url":"git@github.com:smblott-github/vimium.git","clone_url":"https://github.com/smblott-github/vimium.git","svn_url":"https://github.com/smblott-github/vimium","homepage":"","size":3454,"stargazers_count":1,"watchers_count":1,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"philc:master","ref":"master","sha":"01608ce7047e3ff0e53c44842697dded489a60f0","user":{"login":"philc","id":8598,"avatar_url":"https://avatars.githubusercontent.com/u/8598?v=2","gravatar_id":"","url":"https://api.github.com/users/philc","html_url":"https://github.com/philc","followers_url":"https://api.github.com/users/philc/followers","following_url":"https://api.github.com/users/philc/following{/other_user}","gists_url":"https://api.github.com/users/philc/gists{/gist_id}","starred_url":"https://api.github.com/users/philc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philc/subscriptions","organizations_url":"https://api.github.com/users/philc/orgs","repos_url":"https://api.github.com/users/philc/repos","events_url":"https://api.github.com/users/philc/events{/privacy}","received_events_url":"https://api.github.com/users/philc/received_events","type":"User","site_admin":false},"repo":{"id":312262,"name":"vimium","full_name":"philc/vimium","owner":{"login":"philc","id":8598,"avatar_url":"https://avatars.githubusercontent.com/u/8598?v=2","gravatar_id":"","url":"https://api.github.com/users/philc","html_url":"https://github.com/philc","followers_url":"https://api.github.com/users/philc/followers","following_url":"https://api.github.com/users/philc/following{/other_user}","gists_url":"https://api.github.com/users/philc/gists{/gist_id}","starred_url":"https://api.github.com/users/philc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philc/subscriptions","organizations_url":"https://api.github.com/users/philc/orgs","repos_url":"https://api.github.com/users/philc/repos","events_url":"https://api.github.com/users/philc/events{/privacy}","received_events_url":"https://api.github.com/users/philc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philc/vimium","description":"The hacker's browser.","fork":false,"url":"https://api.github.com/repos/philc/vimium","forks_url":"https://api.github.com/repos/philc/vimium/forks","keys_url":"https://api.github.com/repos/philc/vimium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philc/vimium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philc/vimium/teams","hooks_url":"https://api.github.com/repos/philc/vimium/hooks","issue_events_url":"https://api.github.com/repos/philc/vimium/issues/events{/number}","events_url":"https://api.github.com/repos/philc/vimium/events","assignees_url":"https://api.github.com/repos/philc/vimium/assignees{/user}","branches_url":"https://api.github.com/repos/philc/vimium/branches{/branch}","tags_url":"https://api.github.com/repos/philc/vimium/tags","blobs_url":"https://api.github.com/repos/philc/vimium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philc/vimium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philc/vimium/git/refs{/sha}","trees_url":"https://api.github.com/repos/philc/vimium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philc/vimium/statuses/{sha}","languages_url":"https://api.github.com/repos/philc/vimium/languages","stargazers_url":"https://api.github.com/repos/philc/vimium/stargazers","contributors_url":"https://api.github.com/repos/philc/vimium/contributors","subscribers_url":"https://api.github.com/repos/philc/vimium/subscribers","subscription_url":"https://api.github.com/repos/philc/vimium/subscription","commits_url":"https://api.github.com/repos/philc/vimium/commits{/sha}","git_commits_url":"https://api.github.com/repos/philc/vimium/git/commits{/sha}","comments_url":"https://api.github.com/repos/philc/vimium/comments{/number}","issue_comment_url":"https://api.github.com/repos/philc/vimium/issues/comments/{number}","contents_url":"https://api.github.com/repos/philc/vimium/contents/{+path}","compare_url":"https://api.github.com/repos/philc/vimium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philc/vimium/merges","archive_url":"https://api.github.com/repos/philc/vimium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philc/vimium/downloads","issues_url":"https://api.github.com/repos/philc/vimium/issues{/number}","pulls_url":"https://api.github.com/repos/philc/vimium/pulls{/number}","milestones_url":"https://api.github.com/repos/philc/vimium/milestones{/number}","notifications_url":"https://api.github.com/repos/philc/vimium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philc/vimium/labels{/name}","releases_url":"https://api.github.com/repos/philc/vimium/releases{/id}","created_at":"2009-09-20T07:08:19Z","updated_at":"2014-11-03T07:21:38Z","pushed_at":"2014-11-02T13:28:36Z","git_url":"git://github.com/philc/vimium.git","ssh_url":"git@github.com:philc/vimium.git","clone_url":"https://github.com/philc/vimium.git","svn_url":"https://github.com/philc/vimium","homepage":"","size":9437,"stargazers_count":2379,"watchers_count":2379,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":388,"mirror_url":null,"open_issues_count":249,"forks":388,"open_issues":249,"watchers":2379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/philc/vimium/pulls/1222"},"html":{"href":"https://github.com/philc/vimium/pull/1222"},"issue":{"href":"https://api.github.com/repos/philc/vimium/issues/1222"},"comments":{"href":"https://api.github.com/repos/philc/vimium/issues/1222/comments"},"review_comments":{"href":"https://api.github.com/repos/philc/vimium/pulls/1222/comments"},"review_comment":{"href":"https://api.github.com/repos/philc/vimium/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/philc/vimium/pulls/1222/commits"},"statuses":{"href":"https://api.github.com/repos/philc/vimium/statuses/0c590003ed6c0ee465dc8f84efc5cfc54774a94e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":34,"deletions":9,"changed_files":2}}