GitHub PullRequestEvent at 2014-08-19 13:16:11
Repository: nan
Actor: kkoopa
Payload: {"action":"opened","number":183,"pull_request":{"url":"https://api.github.com/repos/rvagg/nan/pulls/183","id":19979314,"html_url":"https://github.com/rvagg/nan/pull/183","diff_url":"https://github.com/rvagg/nan/pull/183.diff","patch_url":"https://github.com/rvagg/nan/pull/183.patch","issue_url":"https://api.github.com/repos/rvagg/nan/issues/183","number":183,"state":"open","locked":false,"title":"Removed unnecessary local handle creation.","user":{"login":"kkoopa","id":4103081,"avatar_url":"https://avatars.githubusercontent.com/u/4103081?v=2","gravatar_id":"d222baae199cbe19e7566bca50c2afdb","url":"https://api.github.com/users/kkoopa","html_url":"https://github.com/kkoopa","followers_url":"https://api.github.com/users/kkoopa/followers","following_url":"https://api.github.com/users/kkoopa/following{/other_user}","gists_url":"https://api.github.com/users/kkoopa/gists{/gist_id}","starred_url":"https://api.github.com/users/kkoopa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkoopa/subscriptions","organizations_url":"https://api.github.com/users/kkoopa/orgs","repos_url":"https://api.github.com/users/kkoopa/repos","events_url":"https://api.github.com/users/kkoopa/events{/privacy}","received_events_url":"https://api.github.com/users/kkoopa/received_events","type":"User","site_admin":false},"body":"This should speed up handle creation on old Node.\r\n\r\nOn another note: Would it be worthwhile to make `NanNew<T>(v8::Persistent<T>)` check for possible weakness and just do a typecast if the handle is not weak? Only reason I don't like it is because it then would not return a *new* handle, which the name implies it should. Is there any performance to gain here in the first place?","created_at":"2014-08-19T13:16:11Z","updated_at":"2014-08-19T13:16:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rvagg/nan/pulls/183/commits","review_comments_url":"https://api.github.com/repos/rvagg/nan/pulls/183/comments","review_comment_url":"https://api.github.com/repos/rvagg/nan/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rvagg/nan/issues/183/comments","statuses_url":"https://api.github.com/repos/rvagg/nan/statuses/18a7243863dcb393fcb6de9af9e2f33e505a8a9c","head":{"label":"rvagg:performance","ref":"performance","sha":"18a7243863dcb393fcb6de9af9e2f33e505a8a9c","user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=2","gravatar_id":"026f5af604a336a38301639027757f29","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"repo":{"id":11545928,"name":"nan","full_name":"rvagg/nan","owner":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=2","gravatar_id":"026f5af604a336a38301639027757f29","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rvagg/nan","description":"Native Abstractions for Node.js","fork":false,"url":"https://api.github.com/repos/rvagg/nan","forks_url":"https://api.github.com/repos/rvagg/nan/forks","keys_url":"https://api.github.com/repos/rvagg/nan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rvagg/nan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rvagg/nan/teams","hooks_url":"https://api.github.com/repos/rvagg/nan/hooks","issue_events_url":"https://api.github.com/repos/rvagg/nan/issues/events{/number}","events_url":"https://api.github.com/repos/rvagg/nan/events","assignees_url":"https://api.github.com/repos/rvagg/nan/assignees{/user}","branches_url":"https://api.github.com/repos/rvagg/nan/branches{/branch}","tags_url":"https://api.github.com/repos/rvagg/nan/tags","blobs_url":"https://api.github.com/repos/rvagg/nan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rvagg/nan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rvagg/nan/git/refs{/sha}","trees_url":"https://api.github.com/repos/rvagg/nan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rvagg/nan/statuses/{sha}","languages_url":"https://api.github.com/repos/rvagg/nan/languages","stargazers_url":"https://api.github.com/repos/rvagg/nan/stargazers","contributors_url":"https://api.github.com/repos/rvagg/nan/contributors","subscribers_url":"https://api.github.com/repos/rvagg/nan/subscribers","subscription_url":"https://api.github.com/repos/rvagg/nan/subscription","commits_url":"https://api.github.com/repos/rvagg/nan/commits{/sha}","git_commits_url":"https://api.github.com/repos/rvagg/nan/git/commits{/sha}","comments_url":"https://api.github.com/repos/rvagg/nan/comments{/number}","issue_comment_url":"https://api.github.com/repos/rvagg/nan/issues/comments/{number}","contents_url":"https://api.github.com/repos/rvagg/nan/contents/{+path}","compare_url":"https://api.github.com/repos/rvagg/nan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rvagg/nan/merges","archive_url":"https://api.github.com/repos/rvagg/nan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rvagg/nan/downloads","issues_url":"https://api.github.com/repos/rvagg/nan/issues{/number}","pulls_url":"https://api.github.com/repos/rvagg/nan/pulls{/number}","milestones_url":"https://api.github.com/repos/rvagg/nan/milestones{/number}","notifications_url":"https://api.github.com/repos/rvagg/nan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rvagg/nan/labels{/name}","releases_url":"https://api.github.com/repos/rvagg/nan/releases{/id}","created_at":"2013-07-20T11:12:03Z","updated_at":"2014-08-18T20:27:41Z","pushed_at":"2014-08-19T13:11:51Z","git_url":"git://github.com/rvagg/nan.git","ssh_url":"git@github.com:rvagg/nan.git","clone_url":"https://github.com/rvagg/nan.git","svn_url":"https://github.com/rvagg/nan","homepage":"","size":4686,"stargazers_count":293,"watchers_count":293,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":45,"mirror_url":null,"open_issues_count":13,"forks":45,"open_issues":13,"watchers":293,"default_branch":"master"}},"base":{"label":"rvagg:master","ref":"master","sha":"4b10d566655c65d25c6cbbf304462e64c8942561","user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=2","gravatar_id":"026f5af604a336a38301639027757f29","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"repo":{"id":11545928,"name":"nan","full_name":"rvagg/nan","owner":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=2","gravatar_id":"026f5af604a336a38301639027757f29","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rvagg/nan","description":"Native Abstractions for Node.js","fork":false,"url":"https://api.github.com/repos/rvagg/nan","forks_url":"https://api.github.com/repos/rvagg/nan/forks","keys_url":"https://api.github.com/repos/rvagg/nan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rvagg/nan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rvagg/nan/teams","hooks_url":"https://api.github.com/repos/rvagg/nan/hooks","issue_events_url":"https://api.github.com/repos/rvagg/nan/issues/events{/number}","events_url":"https://api.github.com/repos/rvagg/nan/events","assignees_url":"https://api.github.com/repos/rvagg/nan/assignees{/user}","branches_url":"https://api.github.com/repos/rvagg/nan/branches{/branch}","tags_url":"https://api.github.com/repos/rvagg/nan/tags","blobs_url":"https://api.github.com/repos/rvagg/nan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rvagg/nan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rvagg/nan/git/refs{/sha}","trees_url":"https://api.github.com/repos/rvagg/nan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rvagg/nan/statuses/{sha}","languages_url":"https://api.github.com/repos/rvagg/nan/languages","stargazers_url":"https://api.github.com/repos/rvagg/nan/stargazers","contributors_url":"https://api.github.com/repos/rvagg/nan/contributors","subscribers_url":"https://api.github.com/repos/rvagg/nan/subscribers","subscription_url":"https://api.github.com/repos/rvagg/nan/subscription","commits_url":"https://api.github.com/repos/rvagg/nan/commits{/sha}","git_commits_url":"https://api.github.com/repos/rvagg/nan/git/commits{/sha}","comments_url":"https://api.github.com/repos/rvagg/nan/comments{/number}","issue_comment_url":"https://api.github.com/repos/rvagg/nan/issues/comments/{number}","contents_url":"https://api.github.com/repos/rvagg/nan/contents/{+path}","compare_url":"https://api.github.com/repos/rvagg/nan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rvagg/nan/merges","archive_url":"https://api.github.com/repos/rvagg/nan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rvagg/nan/downloads","issues_url":"https://api.github.com/repos/rvagg/nan/issues{/number}","pulls_url":"https://api.github.com/repos/rvagg/nan/pulls{/number}","milestones_url":"https://api.github.com/repos/rvagg/nan/milestones{/number}","notifications_url":"https://api.github.com/repos/rvagg/nan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rvagg/nan/labels{/name}","releases_url":"https://api.github.com/repos/rvagg/nan/releases{/id}","created_at":"2013-07-20T11:12:03Z","updated_at":"2014-08-18T20:27:41Z","pushed_at":"2014-08-19T13:11:51Z","git_url":"git://github.com/rvagg/nan.git","ssh_url":"git@github.com:rvagg/nan.git","clone_url":"https://github.com/rvagg/nan.git","svn_url":"https://github.com/rvagg/nan","homepage":"","size":4686,"stargazers_count":293,"watchers_count":293,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":45,"mirror_url":null,"open_issues_count":13,"forks":45,"open_issues":13,"watchers":293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rvagg/nan/pulls/183"},"html":{"href":"https://github.com/rvagg/nan/pull/183"},"issue":{"href":"https://api.github.com/repos/rvagg/nan/issues/183"},"comments":{"href":"https://api.github.com/repos/rvagg/nan/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/rvagg/nan/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/rvagg/nan/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rvagg/nan/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/rvagg/nan/statuses/18a7243863dcb393fcb6de9af9e2f33e505a8a9c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":20,"deletions":4,"changed_files":3}}