GitHub PullRequestEvent at 2014-10-14 15:19:12
Repository: wesnoth
Actor: gfgtdf
Payload: {"action":"closed","number":296,"pull_request":{"url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/296","id":22606927,"html_url":"https://github.com/wesnoth/wesnoth/pull/296","diff_url":"https://github.com/wesnoth/wesnoth/pull/296.diff","patch_url":"https://github.com/wesnoth/wesnoth/pull/296.patch","issue_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/296","number":296,"state":"closed","locked":false,"title":"Ai boost filesystem part 1 strict refactor","user":{"login":"gfgtdf","id":4893136,"avatar_url":"https://avatars.githubusercontent.com/u/4893136?v=2","gravatar_id":"","url":"https://api.github.com/users/gfgtdf","html_url":"https://github.com/gfgtdf","followers_url":"https://api.github.com/users/gfgtdf/followers","following_url":"https://api.github.com/users/gfgtdf/following{/other_user}","gists_url":"https://api.github.com/users/gfgtdf/gists{/gist_id}","starred_url":"https://api.github.com/users/gfgtdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfgtdf/subscriptions","organizations_url":"https://api.github.com/users/gfgtdf/orgs","repos_url":"https://api.github.com/users/gfgtdf/repos","events_url":"https://api.github.com/users/gfgtdf/events{/privacy}","received_events_url":"https://api.github.com/users/gfgtdf/received_events","type":"User","site_admin":false},"body":"this is part 1 of AIs boost filesystem branch it is (except 65431971482b055d39f222e6c65318494729b66d) a strict refactor (renaming, moving of functions). Even though it does nothing (nothing that the user would notice) it causes the most merging conflicts so in order to not have to resolve them again, i think it's best to pull this into master now.\r\n\r\nI had to rebase a lot of these commits in order to make every commit compilable then i merged the corresponding commits from AIs branch whith \"merge -s ours\" to make git know that it can treat those commits as merged. Since im not that much of a git expert i'd be happy if someone could rewiew it.","created_at":"2014-10-11T18:44:48Z","updated_at":"2014-10-14T15:19:12Z","closed_at":"2014-10-14T15:19:12Z","merged_at":"2014-10-14T15:19:12Z","merge_commit_sha":"2b68cf86e10ab8909fb52d8039a4522c347091ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/296/commits","review_comments_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/296/comments","review_comment_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/296/comments","statuses_url":"https://api.github.com/repos/wesnoth/wesnoth/statuses/fbfad1f48dfb512b46c28f73ab8fe152d08c1e77","head":{"label":"gfgtdf:AI-boost_filesystem","ref":"AI-boost_filesystem","sha":"fbfad1f48dfb512b46c28f73ab8fe152d08c1e77","user":{"login":"gfgtdf","id":4893136,"avatar_url":"https://avatars.githubusercontent.com/u/4893136?v=2","gravatar_id":"","url":"https://api.github.com/users/gfgtdf","html_url":"https://github.com/gfgtdf","followers_url":"https://api.github.com/users/gfgtdf/followers","following_url":"https://api.github.com/users/gfgtdf/following{/other_user}","gists_url":"https://api.github.com/users/gfgtdf/gists{/gist_id}","starred_url":"https://api.github.com/users/gfgtdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfgtdf/subscriptions","organizations_url":"https://api.github.com/users/gfgtdf/orgs","repos_url":"https://api.github.com/users/gfgtdf/repos","events_url":"https://api.github.com/users/gfgtdf/events{/privacy}","received_events_url":"https://api.github.com/users/gfgtdf/received_events","type":"User","site_admin":false},"repo":{"id":11527186,"name":"wesnoth-old","full_name":"gfgtdf/wesnoth-old","owner":{"login":"gfgtdf","id":4893136,"avatar_url":"https://avatars.githubusercontent.com/u/4893136?v=2","gravatar_id":"","url":"https://api.github.com/users/gfgtdf","html_url":"https://github.com/gfgtdf","followers_url":"https://api.github.com/users/gfgtdf/followers","following_url":"https://api.github.com/users/gfgtdf/following{/other_user}","gists_url":"https://api.github.com/users/gfgtdf/gists{/gist_id}","starred_url":"https://api.github.com/users/gfgtdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfgtdf/subscriptions","organizations_url":"https://api.github.com/users/gfgtdf/orgs","repos_url":"https://api.github.com/users/gfgtdf/repos","events_url":"https://api.github.com/users/gfgtdf/events{/privacy}","received_events_url":"https://api.github.com/users/gfgtdf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gfgtdf/wesnoth-old","description":"Pre-reconversion repository. Matches the one on sourceforge.","fork":true,"url":"https://api.github.com/repos/gfgtdf/wesnoth-old","forks_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/forks","keys_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/teams","hooks_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/hooks","issue_events_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/issues/events{/number}","events_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/events","assignees_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/assignees{/user}","branches_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/branches{/branch}","tags_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/tags","blobs_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/statuses/{sha}","languages_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/languages","stargazers_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/stargazers","contributors_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/contributors","subscribers_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/subscribers","subscription_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/subscription","commits_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/issues/comments/{number}","contents_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/contents/{+path}","compare_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/merges","archive_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/downloads","issues_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/issues{/number}","pulls_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/pulls{/number}","milestones_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/milestones{/number}","notifications_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/labels{/name}","releases_url":"https://api.github.com/repos/gfgtdf/wesnoth-old/releases{/id}","created_at":"2013-07-19T12:10:48Z","updated_at":"2014-09-27T16:42:11Z","pushed_at":"2014-10-13T16:33:41Z","git_url":"git://github.com/gfgtdf/wesnoth-old.git","ssh_url":"git@github.com:gfgtdf/wesnoth-old.git","clone_url":"https://github.com/gfgtdf/wesnoth-old.git","svn_url":"https://github.com/gfgtdf/wesnoth-old","homepage":"","size":1947809,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wesnoth:master","ref":"master","sha":"5cfef2eee5862d90732611470393bf8af4fb7bc1","user":{"login":"wesnoth","id":4024232,"avatar_url":"https://avatars.githubusercontent.com/u/4024232?v=2","gravatar_id":"","url":"https://api.github.com/users/wesnoth","html_url":"https://github.com/wesnoth","followers_url":"https://api.github.com/users/wesnoth/followers","following_url":"https://api.github.com/users/wesnoth/following{/other_user}","gists_url":"https://api.github.com/users/wesnoth/gists{/gist_id}","starred_url":"https://api.github.com/users/wesnoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesnoth/subscriptions","organizations_url":"https://api.github.com/users/wesnoth/orgs","repos_url":"https://api.github.com/users/wesnoth/repos","events_url":"https://api.github.com/users/wesnoth/events{/privacy}","received_events_url":"https://api.github.com/users/wesnoth/received_events","type":"Organization","site_admin":false},"repo":{"id":9432220,"name":"wesnoth","full_name":"wesnoth/wesnoth","owner":{"login":"wesnoth","id":4024232,"avatar_url":"https://avatars.githubusercontent.com/u/4024232?v=2","gravatar_id":"","url":"https://api.github.com/users/wesnoth","html_url":"https://github.com/wesnoth","followers_url":"https://api.github.com/users/wesnoth/followers","following_url":"https://api.github.com/users/wesnoth/following{/other_user}","gists_url":"https://api.github.com/users/wesnoth/gists{/gist_id}","starred_url":"https://api.github.com/users/wesnoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesnoth/subscriptions","organizations_url":"https://api.github.com/users/wesnoth/orgs","repos_url":"https://api.github.com/users/wesnoth/repos","events_url":"https://api.github.com/users/wesnoth/events{/privacy}","received_events_url":"https://api.github.com/users/wesnoth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wesnoth/wesnoth","description":"Free, turn-based strategy game with a high fantasy theme, featuring both single-player, and online/hotseat multiplayer combat.","fork":false,"url":"https://api.github.com/repos/wesnoth/wesnoth","forks_url":"https://api.github.com/repos/wesnoth/wesnoth/forks","keys_url":"https://api.github.com/repos/wesnoth/wesnoth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesnoth/wesnoth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesnoth/wesnoth/teams","hooks_url":"https://api.github.com/repos/wesnoth/wesnoth/hooks","issue_events_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/events{/number}","events_url":"https://api.github.com/repos/wesnoth/wesnoth/events","assignees_url":"https://api.github.com/repos/wesnoth/wesnoth/assignees{/user}","branches_url":"https://api.github.com/repos/wesnoth/wesnoth/branches{/branch}","tags_url":"https://api.github.com/repos/wesnoth/wesnoth/tags","blobs_url":"https://api.github.com/repos/wesnoth/wesnoth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesnoth/wesnoth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesnoth/wesnoth/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesnoth/wesnoth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesnoth/wesnoth/statuses/{sha}","languages_url":"https://api.github.com/repos/wesnoth/wesnoth/languages","stargazers_url":"https://api.github.com/repos/wesnoth/wesnoth/stargazers","contributors_url":"https://api.github.com/repos/wesnoth/wesnoth/contributors","subscribers_url":"https://api.github.com/repos/wesnoth/wesnoth/subscribers","subscription_url":"https://api.github.com/repos/wesnoth/wesnoth/subscription","commits_url":"https://api.github.com/repos/wesnoth/wesnoth/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesnoth/wesnoth/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesnoth/wesnoth/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/comments/{number}","contents_url":"https://api.github.com/repos/wesnoth/wesnoth/contents/{+path}","compare_url":"https://api.github.com/repos/wesnoth/wesnoth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesnoth/wesnoth/merges","archive_url":"https://api.github.com/repos/wesnoth/wesnoth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesnoth/wesnoth/downloads","issues_url":"https://api.github.com/repos/wesnoth/wesnoth/issues{/number}","pulls_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls{/number}","milestones_url":"https://api.github.com/repos/wesnoth/wesnoth/milestones{/number}","notifications_url":"https://api.github.com/repos/wesnoth/wesnoth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesnoth/wesnoth/labels{/name}","releases_url":"https://api.github.com/repos/wesnoth/wesnoth/releases{/id}","created_at":"2013-04-14T17:13:06Z","updated_at":"2014-10-14T05:34:29Z","pushed_at":"2014-10-14T15:19:12Z","git_url":"git://github.com/wesnoth/wesnoth.git","ssh_url":"git@github.com:wesnoth/wesnoth.git","clone_url":"https://github.com/wesnoth/wesnoth.git","svn_url":"https://github.com/wesnoth/wesnoth","homepage":"http://www.wesnoth.org/","size":2115529,"stargazers_count":359,"watchers_count":359,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":21,"forks":112,"open_issues":21,"watchers":359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/296"},"html":{"href":"https://github.com/wesnoth/wesnoth/pull/296"},"issue":{"href":"https://api.github.com/repos/wesnoth/wesnoth/issues/296"},"comments":{"href":"https://api.github.com/repos/wesnoth/wesnoth/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/wesnoth/wesnoth/statuses/fbfad1f48dfb512b46c28f73ab8fe152d08c1e77"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gfgtdf","id":4893136,"avatar_url":"https://avatars.githubusercontent.com/u/4893136?v=2","gravatar_id":"","url":"https://api.github.com/users/gfgtdf","html_url":"https://github.com/gfgtdf","followers_url":"https://api.github.com/users/gfgtdf/followers","following_url":"https://api.github.com/users/gfgtdf/following{/other_user}","gists_url":"https://api.github.com/users/gfgtdf/gists{/gist_id}","starred_url":"https://api.github.com/users/gfgtdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfgtdf/subscriptions","organizations_url":"https://api.github.com/users/gfgtdf/orgs","repos_url":"https://api.github.com/users/gfgtdf/repos","events_url":"https://api.github.com/users/gfgtdf/events{/privacy}","received_events_url":"https://api.github.com/users/gfgtdf/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":19,"additions":577,"deletions":549,"changed_files":73}}