GitHub PullRequestReviewCommentEvent at 2014-12-01 11:31:17
Repository: tornado-pyuv
Actor: schlamar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/saghul/tornado-pyuv/pulls/comments/21083334","id":21083334,"diff_hunk":"@@ -205,7 +227,14 @@ def _handle_poll_events(self, handle, poll_events, error):\n                 events |= IOLoop.WRITE\n         fd = handle.fileno()\n         try:\n-            self._handlers[fd].handler(fd, events)\n+            obj, poll = self._handlers[fd]\n+            callback_fd = fd\n+            if obj is not None and hasattr(obj, 'fileno'):","path":"tornado_pyuv/__init__.py","position":119,"original_position":119,"commit_id":"0e26e2a7609235abcbbec973bad8290acc41594b","original_commit_id":"0e26e2a7609235abcbbec973bad8290acc41594b","user":{"login":"schlamar","id":238652,"avatar_url":"https://avatars.githubusercontent.com/u/238652?v=3","gravatar_id":"","url":"https://api.github.com/users/schlamar","html_url":"https://github.com/schlamar","followers_url":"https://api.github.com/users/schlamar/followers","following_url":"https://api.github.com/users/schlamar/following{/other_user}","gists_url":"https://api.github.com/users/schlamar/gists{/gist_id}","starred_url":"https://api.github.com/users/schlamar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlamar/subscriptions","organizations_url":"https://api.github.com/users/schlamar/orgs","repos_url":"https://api.github.com/users/schlamar/repos","events_url":"https://api.github.com/users/schlamar/events{/privacy}","received_events_url":"https://api.github.com/users/schlamar/received_events","type":"User","site_admin":false},"body":"Plus, feature checks are more pythonic and an isinstance check would not work for the test case mentioned above.","created_at":"2014-12-01T11:31:17Z","updated_at":"2014-12-01T11:31:17Z","html_url":"https://github.com/saghul/tornado-pyuv/pull/11#discussion_r21083334","pull_request_url":"https://api.github.com/repos/saghul/tornado-pyuv/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/saghul/tornado-pyuv/pulls/comments/21083334"},"html":{"href":"https://github.com/saghul/tornado-pyuv/pull/11#discussion_r21083334"},"pull_request":{"href":"https://api.github.com/repos/saghul/tornado-pyuv/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/saghul/tornado-pyuv/pulls/11","id":25223274,"html_url":"https://github.com/saghul/tornado-pyuv/pull/11","diff_url":"https://github.com/saghul/tornado-pyuv/pull/11.diff","patch_url":"https://github.com/saghul/tornado-pyuv/pull/11.patch","issue_url":"https://api.github.com/repos/saghul/tornado-pyuv/issues/11","number":11,"state":"open","locked":false,"title":"Run tests on Travis and fix some compatibility issues","user":{"login":"schlamar","id":238652,"avatar_url":"https://avatars.githubusercontent.com/u/238652?v=3","gravatar_id":"","url":"https://api.github.com/users/schlamar","html_url":"https://github.com/schlamar","followers_url":"https://api.github.com/users/schlamar/followers","following_url":"https://api.github.com/users/schlamar/following{/other_user}","gists_url":"https://api.github.com/users/schlamar/gists{/gist_id}","starred_url":"https://api.github.com/users/schlamar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlamar/subscriptions","organizations_url":"https://api.github.com/users/schlamar/orgs","repos_url":"https://api.github.com/users/schlamar/repos","events_url":"https://api.github.com/users/schlamar/events{/privacy}","received_events_url":"https://api.github.com/users/schlamar/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-29T14:06:30Z","updated_at":"2014-12-01T11:31:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f9d8feef84169e015dd22fd1367ecf869f14db1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saghul/tornado-pyuv/pulls/11/commits","review_comments_url":"https://api.github.com/repos/saghul/tornado-pyuv/pulls/11/comments","review_comment_url":"https://api.github.com/repos/saghul/tornado-pyuv/pulls/comments/{number}","comments_url":"https://api.github.com/repos/saghul/tornado-pyuv/issues/11/comments","statuses_url":"https://api.github.com/repos/saghul/tornado-pyuv/statuses/0e26e2a7609235abcbbec973bad8290acc41594b","head":{"label":"schlamar:ci","ref":"ci","sha":"0e26e2a7609235abcbbec973bad8290acc41594b","user":{"login":"schlamar","id":238652,"avatar_url":"https://avatars.githubusercontent.com/u/238652?v=3","gravatar_id":"","url":"https://api.github.com/users/schlamar","html_url":"https://github.com/schlamar","followers_url":"https://api.github.com/users/schlamar/followers","following_url":"https://api.github.com/users/schlamar/following{/other_user}","gists_url":"https://api.github.com/users/schlamar/gists{/gist_id}","starred_url":"https://api.github.com/users/schlamar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlamar/subscriptions","organizations_url":"https://api.github.com/users/schlamar/orgs","repos_url":"https://api.github.com/users/schlamar/repos","events_url":"https://api.github.com/users/schlamar/events{/privacy}","received_events_url":"https://api.github.com/users/schlamar/received_events","type":"User","site_admin":false},"repo":{"id":27227445,"name":"tornado-pyuv","full_name":"schlamar/tornado-pyuv","owner":{"login":"schlamar","id":238652,"avatar_url":"https://avatars.githubusercontent.com/u/238652?v=3","gravatar_id":"","url":"https://api.github.com/users/schlamar","html_url":"https://github.com/schlamar","followers_url":"https://api.github.com/users/schlamar/followers","following_url":"https://api.github.com/users/schlamar/following{/other_user}","gists_url":"https://api.github.com/users/schlamar/gists{/gist_id}","starred_url":"https://api.github.com/users/schlamar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlamar/subscriptions","organizations_url":"https://api.github.com/users/schlamar/orgs","repos_url":"https://api.github.com/users/schlamar/repos","events_url":"https://api.github.com/users/schlamar/events{/privacy}","received_events_url":"https://api.github.com/users/schlamar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schlamar/tornado-pyuv","description":"Tornado IOLoop implemented with pyuv","fork":true,"url":"https://api.github.com/repos/schlamar/tornado-pyuv","forks_url":"https://api.github.com/repos/schlamar/tornado-pyuv/forks","keys_url":"https://api.github.com/repos/schlamar/tornado-pyuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schlamar/tornado-pyuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schlamar/tornado-pyuv/teams","hooks_url":"https://api.github.com/repos/schlamar/tornado-pyuv/hooks","issue_events_url":"https://api.github.com/repos/schlamar/tornado-pyuv/issues/events{/number}","events_url":"https://api.github.com/repos/schlamar/tornado-pyuv/events","assignees_url":"https://api.github.com/repos/schlamar/tornado-pyuv/assignees{/user}","branches_url":"https://api.github.com/repos/schlamar/tornado-pyuv/branches{/branch}","tags_url":"https://api.github.com/repos/schlamar/tornado-pyuv/tags","blobs_url":"https://api.github.com/repos/schlamar/tornado-pyuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schlamar/tornado-pyuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schlamar/tornado-pyuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/schlamar/tornado-pyuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schlamar/tornado-pyuv/statuses/{sha}","languages_url":"https://api.github.com/repos/schlamar/tornado-pyuv/languages","stargazers_url":"https://api.github.com/repos/schlamar/tornado-pyuv/stargazers","contributors_url":"https://api.github.com/repos/schlamar/tornado-pyuv/contributors","subscribers_url":"https://api.github.com/repos/schlamar/tornado-pyuv/subscribers","subscription_url":"https://api.github.com/repos/schlamar/tornado-pyuv/subscription","commits_url":"https://api.github.com/repos/schlamar/tornado-pyuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/schlamar/tornado-pyuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/schlamar/tornado-pyuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/schlamar/tornado-pyuv/issues/comments/{number}","contents_url":"https://api.github.com/repos/schlamar/tornado-pyuv/contents/{+path}","compare_url":"https://api.github.com/repos/schlamar/tornado-pyuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schlamar/tornado-pyuv/merges","archive_url":"https://api.github.com/repos/schlamar/tornado-pyuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schlamar/tornado-pyuv/downloads","issues_url":"https://api.github.com/repos/schlamar/tornado-pyuv/issues{/number}","pulls_url":"https://api.github.com/repos/schlamar/tornado-pyuv/pulls{/number}","milestones_url":"https://api.github.com/repos/schlamar/tornado-pyuv/milestones{/number}","notifications_url":"https://api.github.com/repos/schlamar/tornado-pyuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schlamar/tornado-pyuv/labels{/name}","releases_url":"https://api.github.com/repos/schlamar/tornado-pyuv/releases{/id}","created_at":"2014-11-27T13:55:46Z","updated_at":"2014-11-29T12:36:59Z","pushed_at":"2014-11-30T12:52:04Z","git_url":"git://github.com/schlamar/tornado-pyuv.git","ssh_url":"git@github.com:schlamar/tornado-pyuv.git","clone_url":"https://github.com/schlamar/tornado-pyuv.git","svn_url":"https://github.com/schlamar/tornado-pyuv","homepage":null,"size":156,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saghul:master","ref":"master","sha":"07e2cd429f10206dea79f231f24fd3b324cb080d","user":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"repo":{"id":4528910,"name":"tornado-pyuv","full_name":"saghul/tornado-pyuv","owner":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saghul/tornado-pyuv","description":"Tornado IOLoop implemented with pyuv","fork":false,"url":"https://api.github.com/repos/saghul/tornado-pyuv","forks_url":"https://api.github.com/repos/saghul/tornado-pyuv/forks","keys_url":"https://api.github.com/repos/saghul/tornado-pyuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saghul/tornado-pyuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saghul/tornado-pyuv/teams","hooks_url":"https://api.github.com/repos/saghul/tornado-pyuv/hooks","issue_events_url":"https://api.github.com/repos/saghul/tornado-pyuv/issues/events{/number}","events_url":"https://api.github.com/repos/saghul/tornado-pyuv/events","assignees_url":"https://api.github.com/repos/saghul/tornado-pyuv/assignees{/user}","branches_url":"https://api.github.com/repos/saghul/tornado-pyuv/branches{/branch}","tags_url":"https://api.github.com/repos/saghul/tornado-pyuv/tags","blobs_url":"https://api.github.com/repos/saghul/tornado-pyuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saghul/tornado-pyuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saghul/tornado-pyuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/saghul/tornado-pyuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saghul/tornado-pyuv/statuses/{sha}","languages_url":"https://api.github.com/repos/saghul/tornado-pyuv/languages","stargazers_url":"https://api.github.com/repos/saghul/tornado-pyuv/stargazers","contributors_url":"https://api.github.com/repos/saghul/tornado-pyuv/contributors","subscribers_url":"https://api.github.com/repos/saghul/tornado-pyuv/subscribers","subscription_url":"https://api.github.com/repos/saghul/tornado-pyuv/subscription","commits_url":"https://api.github.com/repos/saghul/tornado-pyuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/saghul/tornado-pyuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/saghul/tornado-pyuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/saghul/tornado-pyuv/issues/comments/{number}","contents_url":"https://api.github.com/repos/saghul/tornado-pyuv/contents/{+path}","compare_url":"https://api.github.com/repos/saghul/tornado-pyuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saghul/tornado-pyuv/merges","archive_url":"https://api.github.com/repos/saghul/tornado-pyuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saghul/tornado-pyuv/downloads","issues_url":"https://api.github.com/repos/saghul/tornado-pyuv/issues{/number}","pulls_url":"https://api.github.com/repos/saghul/tornado-pyuv/pulls{/number}","milestones_url":"https://api.github.com/repos/saghul/tornado-pyuv/milestones{/number}","notifications_url":"https://api.github.com/repos/saghul/tornado-pyuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saghul/tornado-pyuv/labels{/name}","releases_url":"https://api.github.com/repos/saghul/tornado-pyuv/releases{/id}","created_at":"2012-06-02T12:01:12Z","updated_at":"2014-12-01T06:36:10Z","pushed_at":"2014-11-28T14:34:18Z","git_url":"git://github.com/saghul/tornado-pyuv.git","ssh_url":"git@github.com:saghul/tornado-pyuv.git","clone_url":"https://github.com/saghul/tornado-pyuv.git","svn_url":"https://github.com/saghul/tornado-pyuv","homepage":null,"size":240,"stargazers_count":39,"watchers_count":39,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saghul/tornado-pyuv/pulls/11"},"html":{"href":"https://github.com/saghul/tornado-pyuv/pull/11"},"issue":{"href":"https://api.github.com/repos/saghul/tornado-pyuv/issues/11"},"comments":{"href":"https://api.github.com/repos/saghul/tornado-pyuv/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/saghul/tornado-pyuv/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/saghul/tornado-pyuv/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/saghul/tornado-pyuv/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/saghul/tornado-pyuv/statuses/0e26e2a7609235abcbbec973bad8290acc41594b"}}}}