GitHub PullRequestReviewCommentEvent at 2014-06-23 20:35:20
Repository: hbc
Actor: bkhau
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/twitter/hbc/pulls/comments/14098408","id":14098408,"diff_hunk":"@@ -56,14 +59,20 @@ public RawEndpoint(String uri, String httpMethod, Map<String, String> postParams\n    * These don't do anything\n    */\n   @Override\n-  public void setBackfillCount(int count) {}\n+  public void setBackfillCount(int count) {\n+  }\n \n   @Override\n-  public void setApiVersion(String apiVersion) {}\n+  public void setApiVersion(String apiVersion) {\n+  }","path":"hbc-core/src/main/java/com/twitter/hbc/core/endpoint/RawEndpoint.java","position":35,"original_position":35,"commit_id":"621cc668e992da2a6784b45eea85e165fbc2bfb1","original_commit_id":"621cc668e992da2a6784b45eea85e165fbc2bfb1","user":{"login":"bkhau","id":2125130,"avatar_url":"https://avatars.githubusercontent.com/u/2125130?","gravatar_id":"0c472dd959477686e50b94296b82baab","url":"https://api.github.com/users/bkhau","html_url":"https://github.com/bkhau","followers_url":"https://api.github.com/users/bkhau/followers","following_url":"https://api.github.com/users/bkhau/following{/other_user}","gists_url":"https://api.github.com/users/bkhau/gists{/gist_id}","starred_url":"https://api.github.com/users/bkhau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkhau/subscriptions","organizations_url":"https://api.github.com/users/bkhau/orgs","repos_url":"https://api.github.com/users/bkhau/repos","events_url":"https://api.github.com/users/bkhau/events{/privacy}","received_events_url":"https://api.github.com/users/bkhau/received_events","type":"User","site_admin":false},"body":"I think I prefer the more-concise empty method where it's just on one line, but take it or leave it.","created_at":"2014-06-23T20:35:20Z","updated_at":"2014-06-23T20:35:20Z","html_url":"https://github.com/twitter/hbc/pull/121#discussion_r14098408","pull_request_url":"https://api.github.com/repos/twitter/hbc/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/twitter/hbc/pulls/comments/14098408"},"html":{"href":"https://github.com/twitter/hbc/pull/121#discussion_r14098408"},"pull_request":{"href":"https://api.github.com/repos/twitter/hbc/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/hbc/pulls/121","id":17262431,"html_url":"https://github.com/twitter/hbc/pull/121","diff_url":"https://github.com/twitter/hbc/pull/121.diff","patch_url":"https://github.com/twitter/hbc/pull/121.patch","issue_url":"https://api.github.com/repos/twitter/hbc/issues/121","number":121,"state":"open","title":"Powertrack support","user":{"login":"nicky-isaacs","id":1903329,"avatar_url":"https://avatars.githubusercontent.com/u/1903329?","gravatar_id":"eaa6ddbd94198083bab4c602f1507005","url":"https://api.github.com/users/nicky-isaacs","html_url":"https://github.com/nicky-isaacs","followers_url":"https://api.github.com/users/nicky-isaacs/followers","following_url":"https://api.github.com/users/nicky-isaacs/following{/other_user}","gists_url":"https://api.github.com/users/nicky-isaacs/gists{/gist_id}","starred_url":"https://api.github.com/users/nicky-isaacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicky-isaacs/subscriptions","organizations_url":"https://api.github.com/users/nicky-isaacs/orgs","repos_url":"https://api.github.com/users/nicky-isaacs/repos","events_url":"https://api.github.com/users/nicky-isaacs/events{/privacy}","received_events_url":"https://api.github.com/users/nicky-isaacs/received_events","type":"User","site_admin":false},"body":"Added support for the GNIP streaming API's. More refactoring work to come before publish.","created_at":"2014-06-17T21:24:13Z","updated_at":"2014-06-23T20:35:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"833a8d4ca12a0d250453cef46bd483b1da940e3d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/hbc/pulls/121/commits","review_comments_url":"https://api.github.com/repos/twitter/hbc/pulls/121/comments","review_comment_url":"https://api.github.com/repos/twitter/hbc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twitter/hbc/issues/121/comments","statuses_url":"https://api.github.com/repos/twitter/hbc/statuses/621cc668e992da2a6784b45eea85e165fbc2bfb1","head":{"label":"twitter:powertrack-support","ref":"powertrack-support","sha":"621cc668e992da2a6784b45eea85e165fbc2bfb1","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":8064341,"name":"hbc","full_name":"twitter/hbc","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/hbc","description":"A Java HTTP client for consuming Twitter's Streaming API","fork":false,"url":"https://api.github.com/repos/twitter/hbc","forks_url":"https://api.github.com/repos/twitter/hbc/forks","keys_url":"https://api.github.com/repos/twitter/hbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/hbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/hbc/teams","hooks_url":"https://api.github.com/repos/twitter/hbc/hooks","issue_events_url":"https://api.github.com/repos/twitter/hbc/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/hbc/events","assignees_url":"https://api.github.com/repos/twitter/hbc/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/hbc/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/hbc/tags","blobs_url":"https://api.github.com/repos/twitter/hbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/hbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/hbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/hbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/hbc/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/hbc/languages","stargazers_url":"https://api.github.com/repos/twitter/hbc/stargazers","contributors_url":"https://api.github.com/repos/twitter/hbc/contributors","subscribers_url":"https://api.github.com/repos/twitter/hbc/subscribers","subscription_url":"https://api.github.com/repos/twitter/hbc/subscription","commits_url":"https://api.github.com/repos/twitter/hbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/hbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/hbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/hbc/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/hbc/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/hbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/hbc/merges","archive_url":"https://api.github.com/repos/twitter/hbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/hbc/downloads","issues_url":"https://api.github.com/repos/twitter/hbc/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/hbc/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/hbc/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/hbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/hbc/labels{/name}","releases_url":"https://api.github.com/repos/twitter/hbc/releases{/id}","created_at":"2013-02-07T01:40:57Z","updated_at":"2014-06-23T17:15:10Z","pushed_at":"2014-06-19T23:12:38Z","git_url":"git://github.com/twitter/hbc.git","ssh_url":"git@github.com:twitter/hbc.git","clone_url":"https://github.com/twitter/hbc.git","svn_url":"https://github.com/twitter/hbc","homepage":null,"size":1596,"stargazers_count":341,"watchers_count":341,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":98,"mirror_url":null,"open_issues_count":3,"forks":98,"open_issues":3,"watchers":341,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"33dde671179559d275bb070cabc8f7aede2ed7e0","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":8064341,"name":"hbc","full_name":"twitter/hbc","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/hbc","description":"A Java HTTP client for consuming Twitter's Streaming API","fork":false,"url":"https://api.github.com/repos/twitter/hbc","forks_url":"https://api.github.com/repos/twitter/hbc/forks","keys_url":"https://api.github.com/repos/twitter/hbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/hbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/hbc/teams","hooks_url":"https://api.github.com/repos/twitter/hbc/hooks","issue_events_url":"https://api.github.com/repos/twitter/hbc/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/hbc/events","assignees_url":"https://api.github.com/repos/twitter/hbc/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/hbc/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/hbc/tags","blobs_url":"https://api.github.com/repos/twitter/hbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/hbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/hbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/hbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/hbc/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/hbc/languages","stargazers_url":"https://api.github.com/repos/twitter/hbc/stargazers","contributors_url":"https://api.github.com/repos/twitter/hbc/contributors","subscribers_url":"https://api.github.com/repos/twitter/hbc/subscribers","subscription_url":"https://api.github.com/repos/twitter/hbc/subscription","commits_url":"https://api.github.com/repos/twitter/hbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/hbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/hbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/hbc/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/hbc/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/hbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/hbc/merges","archive_url":"https://api.github.com/repos/twitter/hbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/hbc/downloads","issues_url":"https://api.github.com/repos/twitter/hbc/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/hbc/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/hbc/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/hbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/hbc/labels{/name}","releases_url":"https://api.github.com/repos/twitter/hbc/releases{/id}","created_at":"2013-02-07T01:40:57Z","updated_at":"2014-06-23T17:15:10Z","pushed_at":"2014-06-19T23:12:38Z","git_url":"git://github.com/twitter/hbc.git","ssh_url":"git@github.com:twitter/hbc.git","clone_url":"https://github.com/twitter/hbc.git","svn_url":"https://github.com/twitter/hbc","homepage":null,"size":1596,"stargazers_count":341,"watchers_count":341,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":98,"mirror_url":null,"open_issues_count":3,"forks":98,"open_issues":3,"watchers":341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/hbc/pulls/121"},"html":{"href":"https://github.com/twitter/hbc/pull/121"},"issue":{"href":"https://api.github.com/repos/twitter/hbc/issues/121"},"comments":{"href":"https://api.github.com/repos/twitter/hbc/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/hbc/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/hbc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twitter/hbc/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/hbc/statuses/621cc668e992da2a6784b45eea85e165fbc2bfb1"}}}}