GitHub PullRequestReviewCommentEvent at 2014-01-10 01:29:43
Repository: finatra
Actor: yuzeh
Payload: {"comment":{"url":"https://api.github.com/repos/twitter/finatra/pulls/comments/8778073","id":8778073,"diff_hunk":"@@ -62,7 +62,7 @@ class ResponseBuilder {\n       case Some(j) =>\n         resp.headers.set(\"Content-Type\", \"application/json\")\n         val jsonString = jsonMapper.writeValueAsString(j)\n-        resp.headers.set(\"Content-Length\", jsonString.length)\n+        resp.headers.set(\"Content-Length\", jsonString.getBytes.length)","path":"src/main/scala/com/twitter/finatra/ResponseBuilder.scala","position":5,"original_position":5,"commit_id":"cd14caa4fe79a4ff0264b6fd3ae54959a3017d1f","original_commit_id":"cd14caa4fe79a4ff0264b6fd3ae54959a3017d1f","user":{"login":"yuzeh","id":351023,"avatar_url":"https://gravatar.com/avatar/40cbe8d8da1a80694fd410a9c6473956?d=https%3A%2F%2Fidenticons.github.com%2Fb463535c71f8d005eb90937c67e090bb.png&r=x","gravatar_id":"40cbe8d8da1a80694fd410a9c6473956","url":"https://api.github.com/users/yuzeh","html_url":"https://github.com/yuzeh","followers_url":"https://api.github.com/users/yuzeh/followers","following_url":"https://api.github.com/users/yuzeh/following{/other_user}","gists_url":"https://api.github.com/users/yuzeh/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzeh/subscriptions","organizations_url":"https://api.github.com/users/yuzeh/orgs","repos_url":"https://api.github.com/users/yuzeh/repos","events_url":"https://api.github.com/users/yuzeh/events{/privacy}","received_events_url":"https://api.github.com/users/yuzeh/received_events","type":"User","site_admin":false},"body":"Should I be doing this instead?\r\n```scala\r\nval jsonString = jsonMapper.writeValueAsString(j).getBytes(\"utf-8\")\r\nresp.headers.set(\"Content-Length\", jsonString.length)\r\nresp.setContent(copiedBuffer(jsonString))\r\n```","created_at":"2014-01-10T01:29:43Z","updated_at":"2014-01-10T01:29:43Z","html_url":"https://github.com/twitter/finatra/pull/97#discussion_r8778073","pull_request_url":"https://api.github.com/repos/twitter/finatra/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/twitter/finatra/pulls/comments/8778073"},"html":{"href":"https://github.com/twitter/finatra/pull/97#discussion_r8778073"},"pull_request":{"href":"https://api.github.com/repos/twitter/finatra/pulls/97"}}}}