GitHub PullRequestReviewCommentEvent at 2014-05-12 13:54:39
Repository: openmrs-core
Actor: wluyima
Payload: {"comment":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/12529657","id":12529657,"diff_hunk":"@@ -642,4 +643,26 @@ public Order discontinueOrder(Order orderToDiscontinue, String reasonNonCoded, D\n \t */\r\n \t@Authorized(PrivilegeConstants.VIEW_CONCEPTS)\r\n \tpublic List<Concept> getDrugRoutes();\r\n+\t\r\n+\t/**\r\n+\t * Gets the possible drug dosing units, i.e the set members for the concept that matches the uuid\r\n+\t * specified as the value for the global property {@link OpenmrsConstants#GP_DRUG_DOSING_UNITS_CONCEPT_UUID}\r\n+\t * \r\n+\t * @return concept list of drug dosing units\r\n+\t * @since 1.10\r\n+\t * @Should return an empty list if nothing is configured\r","path":"api/src/main/java/org/openmrs/api/OrderService.java","position":28,"original_position":28,"commit_id":"5ae0fef3975693ee53ae5c648c3785110645db9b","original_commit_id":"5ae0fef3975693ee53ae5c648c3785110645db9b","user":{"login":"wluyima","id":1395907,"avatar_url":"https://avatars.githubusercontent.com/u/1395907?","gravatar_id":"5cd6c4175104cf104a7a9911d434c4cd","url":"https://api.github.com/users/wluyima","html_url":"https://github.com/wluyima","followers_url":"https://api.github.com/users/wluyima/followers","following_url":"https://api.github.com/users/wluyima/following{/other_user}","gists_url":"https://api.github.com/users/wluyima/gists{/gist_id}","starred_url":"https://api.github.com/users/wluyima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wluyima/subscriptions","organizations_url":"https://api.github.com/users/wluyima/orgs","repos_url":"https://api.github.com/users/wluyima/repos","events_url":"https://api.github.com/users/wluyima/events{/privacy}","received_events_url":"https://api.github.com/users/wluyima/received_events","type":"User","site_admin":false},"body":"I think you are missing an @should here for returning the execpeted list if the GP is set","created_at":"2014-05-12T13:54:39Z","updated_at":"2014-05-12T13:54:39Z","html_url":"https://github.com/openmrs/openmrs-core/pull/902#discussion_r12529657","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/902","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/12529657"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/902#discussion_r12529657"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/902"}}}}