GitHub PullRequestEvent at 2014-02-25 10:41:43
Repository: voxellancer
Actor: gersseba
Payload: {"action":"closed","number":429,"pull_request":{"url":"https://api.github.com/repos/voxelinc/voxellancer/pulls/429","id":12833596,"html_url":"https://github.com/voxelinc/voxellancer/pull/429","diff_url":"https://github.com/voxelinc/voxellancer/pull/429.diff","patch_url":"https://github.com/voxelinc/voxellancer/pull/429.patch","issue_url":"https://api.github.com/repos/voxelinc/voxellancer/issues/429","number":429,"state":"closed","title":"Inputhandler applies updates only once","user":{"login":"psieg","id":5766601,"avatar_url":"https://gravatar.com/avatar/a27b6f49ca78f5db6f3dee11691b4cfd?d=https%3A%2F%2Fidenticons.github.com%2F3b707f4de52b1d5f066756792d41ac28.png&r=x","gravatar_id":"a27b6f49ca78f5db6f3dee11691b4cfd","url":"https://api.github.com/users/psieg","html_url":"https://github.com/psieg","followers_url":"https://api.github.com/users/psieg/followers","following_url":"https://api.github.com/users/psieg/following{/other_user}","gists_url":"https://api.github.com/users/psieg/gists{/gist_id}","starred_url":"https://api.github.com/users/psieg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psieg/subscriptions","organizations_url":"https://api.github.com/users/psieg/orgs","repos_url":"https://api.github.com/users/psieg/repos","events_url":"https://api.github.com/users/psieg/events{/privacy}","received_events_url":"https://api.github.com/users/psieg/received_events","type":"User","site_admin":false},"body":"Using keyboard and mouse at the same time didn't work because the InputHandler called player->rotate twice, overriding the Q/E rotation with the mouse rotation.\r\nIt now collects all updates and applies them at once.\r\n\r\nNote the move was not normalized before, not sure whether intentional or not, or whether any of them ever is >1 (@gersseba should judge this)","created_at":"2014-02-23T17:20:49Z","updated_at":"2014-02-25T10:41:43Z","closed_at":"2014-02-25T10:41:43Z","merged_at":"2014-02-25T10:41:43Z","merge_commit_sha":"b966f6df884323c692728072971e2c103a9f6c9c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/voxelinc/voxellancer/pulls/429/commits","review_comments_url":"https://api.github.com/repos/voxelinc/voxellancer/pulls/429/comments","review_comment_url":"https://api.github.com/repos/voxelinc/voxellancer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/voxelinc/voxellancer/issues/429/comments","statuses_url":"https://api.github.com/repos/voxelinc/voxellancer/statuses/090031e83839dd8976916c13e5de3a5c154ac469","head":{"label":"voxelinc:fix_qe","ref":"fix_qe","sha":"090031e83839dd8976916c13e5de3a5c154ac469","user":{"login":"voxelinc","id":5766966,"avatar_url":"https://identicons.github.com/b44b9571e3a5b6bc8cc4c9d43395b019.png","gravatar_id":null,"url":"https://api.github.com/users/voxelinc","html_url":"https://github.com/voxelinc","followers_url":"https://api.github.com/users/voxelinc/followers","following_url":"https://api.github.com/users/voxelinc/following{/other_user}","gists_url":"https://api.github.com/users/voxelinc/gists{/gist_id}","starred_url":"https://api.github.com/users/voxelinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxelinc/subscriptions","organizations_url":"https://api.github.com/users/voxelinc/orgs","repos_url":"https://api.github.com/users/voxelinc/repos","events_url":"https://api.github.com/users/voxelinc/events{/privacy}","received_events_url":"https://api.github.com/users/voxelinc/received_events","type":"Organization","site_admin":false},"repo":{"id":13836849,"name":"voxellancer","full_name":"voxelinc/voxellancer","owner":{"login":"voxelinc","id":5766966,"avatar_url":"https://identicons.github.com/b44b9571e3a5b6bc8cc4c9d43395b019.png","gravatar_id":null,"url":"https://api.github.com/users/voxelinc","html_url":"https://github.com/voxelinc","followers_url":"https://api.github.com/users/voxelinc/followers","following_url":"https://api.github.com/users/voxelinc/following{/other_user}","gists_url":"https://api.github.com/users/voxelinc/gists{/gist_id}","starred_url":"https://api.github.com/users/voxelinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxelinc/subscriptions","organizations_url":"https://api.github.com/users/voxelinc/orgs","repos_url":"https://api.github.com/users/voxelinc/repos","events_url":"https://api.github.com/users/voxelinc/events{/privacy}","received_events_url":"https://api.github.com/users/voxelinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxelinc/voxellancer","description":"","fork":false,"url":"https://api.github.com/repos/voxelinc/voxellancer","forks_url":"https://api.github.com/repos/voxelinc/voxellancer/forks","keys_url":"https://api.github.com/repos/voxelinc/voxellancer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxelinc/voxellancer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxelinc/voxellancer/teams","hooks_url":"https://api.github.com/repos/voxelinc/voxellancer/hooks","issue_events_url":"https://api.github.com/repos/voxelinc/voxellancer/issues/events{/number}","events_url":"https://api.github.com/repos/voxelinc/voxellancer/events","assignees_url":"https://api.github.com/repos/voxelinc/voxellancer/assignees{/user}","branches_url":"https://api.github.com/repos/voxelinc/voxellancer/branches{/branch}","tags_url":"https://api.github.com/repos/voxelinc/voxellancer/tags","blobs_url":"https://api.github.com/repos/voxelinc/voxellancer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxelinc/voxellancer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxelinc/voxellancer/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxelinc/voxellancer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxelinc/voxellancer/statuses/{sha}","languages_url":"https://api.github.com/repos/voxelinc/voxellancer/languages","stargazers_url":"https://api.github.com/repos/voxelinc/voxellancer/stargazers","contributors_url":"https://api.github.com/repos/voxelinc/voxellancer/contributors","subscribers_url":"https://api.github.com/repos/voxelinc/voxellancer/subscribers","subscription_url":"https://api.github.com/repos/voxelinc/voxellancer/subscription","commits_url":"https://api.github.com/repos/voxelinc/voxellancer/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxelinc/voxellancer/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxelinc/voxellancer/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxelinc/voxellancer/issues/comments/{number}","contents_url":"https://api.github.com/repos/voxelinc/voxellancer/contents/{+path}","compare_url":"https://api.github.com/repos/voxelinc/voxellancer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxelinc/voxellancer/merges","archive_url":"https://api.github.com/repos/voxelinc/voxellancer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxelinc/voxellancer/downloads","issues_url":"https://api.github.com/repos/voxelinc/voxellancer/issues{/number}","pulls_url":"https://api.github.com/repos/voxelinc/voxellancer/pulls{/number}","milestones_url":"https://api.github.com/repos/voxelinc/voxellancer/milestones{/number}","notifications_url":"https://api.github.com/repos/voxelinc/voxellancer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxelinc/voxellancer/labels{/name}","releases_url":"https://api.github.com/repos/voxelinc/voxellancer/releases{/id}","created_at":"2013-10-24T15:58:28Z","updated_at":"2014-02-25T10:41:43Z","pushed_at":"2014-02-25T10:41:43Z","git_url":"git://github.com/voxelinc/voxellancer.git","ssh_url":"git@github.com:voxelinc/voxellancer.git","clone_url":"https://github.com/voxelinc/voxellancer.git","svn_url":"https://github.com/voxelinc/voxellancer","homepage":null,"size":40284,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":68,"forks":0,"open_issues":68,"watchers":7,"default_branch":"master","master_branch":"master"}},"base":{"label":"voxelinc:master","ref":"master","sha":"793de56a56cc796b7dc98e65ba9cca3460a3b0ec","user":{"login":"voxelinc","id":5766966,"avatar_url":"https://identicons.github.com/b44b9571e3a5b6bc8cc4c9d43395b019.png","gravatar_id":null,"url":"https://api.github.com/users/voxelinc","html_url":"https://github.com/voxelinc","followers_url":"https://api.github.com/users/voxelinc/followers","following_url":"https://api.github.com/users/voxelinc/following{/other_user}","gists_url":"https://api.github.com/users/voxelinc/gists{/gist_id}","starred_url":"https://api.github.com/users/voxelinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxelinc/subscriptions","organizations_url":"https://api.github.com/users/voxelinc/orgs","repos_url":"https://api.github.com/users/voxelinc/repos","events_url":"https://api.github.com/users/voxelinc/events{/privacy}","received_events_url":"https://api.github.com/users/voxelinc/received_events","type":"Organization","site_admin":false},"repo":{"id":13836849,"name":"voxellancer","full_name":"voxelinc/voxellancer","owner":{"login":"voxelinc","id":5766966,"avatar_url":"https://identicons.github.com/b44b9571e3a5b6bc8cc4c9d43395b019.png","gravatar_id":null,"url":"https://api.github.com/users/voxelinc","html_url":"https://github.com/voxelinc","followers_url":"https://api.github.com/users/voxelinc/followers","following_url":"https://api.github.com/users/voxelinc/following{/other_user}","gists_url":"https://api.github.com/users/voxelinc/gists{/gist_id}","starred_url":"https://api.github.com/users/voxelinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxelinc/subscriptions","organizations_url":"https://api.github.com/users/voxelinc/orgs","repos_url":"https://api.github.com/users/voxelinc/repos","events_url":"https://api.github.com/users/voxelinc/events{/privacy}","received_events_url":"https://api.github.com/users/voxelinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxelinc/voxellancer","description":"","fork":false,"url":"https://api.github.com/repos/voxelinc/voxellancer","forks_url":"https://api.github.com/repos/voxelinc/voxellancer/forks","keys_url":"https://api.github.com/repos/voxelinc/voxellancer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxelinc/voxellancer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxelinc/voxellancer/teams","hooks_url":"https://api.github.com/repos/voxelinc/voxellancer/hooks","issue_events_url":"https://api.github.com/repos/voxelinc/voxellancer/issues/events{/number}","events_url":"https://api.github.com/repos/voxelinc/voxellancer/events","assignees_url":"https://api.github.com/repos/voxelinc/voxellancer/assignees{/user}","branches_url":"https://api.github.com/repos/voxelinc/voxellancer/branches{/branch}","tags_url":"https://api.github.com/repos/voxelinc/voxellancer/tags","blobs_url":"https://api.github.com/repos/voxelinc/voxellancer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxelinc/voxellancer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxelinc/voxellancer/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxelinc/voxellancer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxelinc/voxellancer/statuses/{sha}","languages_url":"https://api.github.com/repos/voxelinc/voxellancer/languages","stargazers_url":"https://api.github.com/repos/voxelinc/voxellancer/stargazers","contributors_url":"https://api.github.com/repos/voxelinc/voxellancer/contributors","subscribers_url":"https://api.github.com/repos/voxelinc/voxellancer/subscribers","subscription_url":"https://api.github.com/repos/voxelinc/voxellancer/subscription","commits_url":"https://api.github.com/repos/voxelinc/voxellancer/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxelinc/voxellancer/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxelinc/voxellancer/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxelinc/voxellancer/issues/comments/{number}","contents_url":"https://api.github.com/repos/voxelinc/voxellancer/contents/{+path}","compare_url":"https://api.github.com/repos/voxelinc/voxellancer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxelinc/voxellancer/merges","archive_url":"https://api.github.com/repos/voxelinc/voxellancer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxelinc/voxellancer/downloads","issues_url":"https://api.github.com/repos/voxelinc/voxellancer/issues{/number}","pulls_url":"https://api.github.com/repos/voxelinc/voxellancer/pulls{/number}","milestones_url":"https://api.github.com/repos/voxelinc/voxellancer/milestones{/number}","notifications_url":"https://api.github.com/repos/voxelinc/voxellancer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxelinc/voxellancer/labels{/name}","releases_url":"https://api.github.com/repos/voxelinc/voxellancer/releases{/id}","created_at":"2013-10-24T15:58:28Z","updated_at":"2014-02-25T10:41:43Z","pushed_at":"2014-02-25T10:41:43Z","git_url":"git://github.com/voxelinc/voxellancer.git","ssh_url":"git@github.com:voxelinc/voxellancer.git","clone_url":"https://github.com/voxelinc/voxellancer.git","svn_url":"https://github.com/voxelinc/voxellancer","homepage":null,"size":40284,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":68,"forks":0,"open_issues":68,"watchers":7,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxelinc/voxellancer/pulls/429"},"html":{"href":"https://github.com/voxelinc/voxellancer/pull/429"},"issue":{"href":"https://api.github.com/repos/voxelinc/voxellancer/issues/429"},"comments":{"href":"https://api.github.com/repos/voxelinc/voxellancer/issues/429/comments"},"review_comments":{"href":"https://api.github.com/repos/voxelinc/voxellancer/pulls/429/comments"},"review_comment":{"href":"https://api.github.com/repos/voxelinc/voxellancer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/voxelinc/voxellancer/pulls/429/commits"},"statuses":{"href":"https://api.github.com/repos/voxelinc/voxellancer/statuses/090031e83839dd8976916c13e5de3a5c154ac469"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gersseba","id":5768547,"avatar_url":"https://gravatar.com/avatar/ebe54f380e464d4b62ec4f5f23f54336?d=https%3A%2F%2Fidenticons.github.com%2F1d0e69fdfd8ba551b7dd9bd131a8c11d.png&r=x","gravatar_id":"ebe54f380e464d4b62ec4f5f23f54336","url":"https://api.github.com/users/gersseba","html_url":"https://github.com/gersseba","followers_url":"https://api.github.com/users/gersseba/followers","following_url":"https://api.github.com/users/gersseba/following{/other_user}","gists_url":"https://api.github.com/users/gersseba/gists{/gist_id}","starred_url":"https://api.github.com/users/gersseba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gersseba/subscriptions","organizations_url":"https://api.github.com/users/gersseba/orgs","repos_url":"https://api.github.com/users/gersseba/repos","events_url":"https://api.github.com/users/gersseba/events{/privacy}","received_events_url":"https://api.github.com/users/gersseba/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"commits":2,"additions":50,"deletions":21,"changed_files":3}}