GitHub PullRequestReviewCommentEvent at 2014-05-06 19:56:49
Repository: rails
Actor: robin850
Payload: {"comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/12344833","id":12344833,"diff_hunk":"@@ -1,3 +1,8 @@\n+*   Make the `apply_inflections` method case-sensitive when checking","path":"activesupport/CHANGELOG.md","position":1,"original_position":1,"commit_id":"073daf8aa01a306605a072f57a00b4ef90e01ea6","original_commit_id":"073daf8aa01a306605a072f57a00b4ef90e01ea6","user":{"login":"robin850","id":354185,"avatar_url":"https://avatars.githubusercontent.com/u/354185?","gravatar_id":"2d27b53e2eeb6a053552332020628029","url":"https://api.github.com/users/robin850","html_url":"https://github.com/robin850","followers_url":"https://api.github.com/users/robin850/followers","following_url":"https://api.github.com/users/robin850/following{/other_user}","gists_url":"https://api.github.com/users/robin850/gists{/gist_id}","starred_url":"https://api.github.com/users/robin850/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robin850/subscriptions","organizations_url":"https://api.github.com/users/robin850/orgs","repos_url":"https://api.github.com/users/robin850/repos","events_url":"https://api.github.com/users/robin850/events{/privacy}","received_events_url":"https://api.github.com/users/robin850/received_events","type":"User","site_admin":false},"body":"I may be wrong but I think \"case-sensitive\" is right. At the moment, if we want to make the `\"HTTP\"` string uncountable, we'd have to write `inflections.uncountable \"http\"` (that would apply to \"Http\", \"HtTp\", etc. too) so I'd say that this is case-*insensitive* currently. \r\n\r\nWith this patch, half the problem is resolved. Actually if we write `inflections.uncountable \"HTTP\"`, \"HTTP\" is defined as an uncountable but \"http\", \"Http\", etc. too. There is no easy way to fix this as people may except `\"Information\".pluralize` to return \"Information\" if we have the `inflections.uncountable \"information` rule.","created_at":"2014-05-06T19:56:49Z","updated_at":"2014-05-06T19:56:49Z","html_url":"https://github.com/rails/rails/pull/14247#discussion_r12344833","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/14247","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/12344833"},"html":{"href":"https://github.com/rails/rails/pull/14247#discussion_r12344833"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/14247"}}}}