GitHub PullRequestReviewCommentEvent at 2014-08-20 18:02:42
Repository: fleet
Actor: bcwaldon
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/fleet/pulls/comments/16492950","id":16492950,"diff_hunk":"@@ -120,6 +124,15 @@ func New(cfg config.Config) (*Server, error) {\n \treturn &srv, nil\n }\n \n+func newUnitStatePublisherFromConfig(mgr unit.UnitManager, mach machine.Machine, reg registry.Registry, cfg config.Config) (*agent.UnitStatePublisher, error) {\n+\tttl, err := time.ParseDuration(cfg.AgentTTL)","path":"server/server.go","position":18,"original_position":18,"commit_id":"edac73354062f26d54f1f181ec4ba5a68753f25a","original_commit_id":"158c60f030a0089fb853be45ff430b23fda2d17c","user":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=2","gravatar_id":"3fa4bd3403b1a81ac43f4769c8f74b66","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"body":"OH, by New() you don't mean agent.NewUnitStatePublisher(). Yeah, can do.","created_at":"2014-08-20T18:02:42Z","updated_at":"2014-08-20T18:02:42Z","html_url":"https://github.com/coreos/fleet/pull/788#discussion_r16492950","pull_request_url":"https://api.github.com/repos/coreos/fleet/pulls/788","_links":{"self":{"href":"https://api.github.com/repos/coreos/fleet/pulls/comments/16492950"},"html":{"href":"https://github.com/coreos/fleet/pull/788#discussion_r16492950"},"pull_request":{"href":"https://api.github.com/repos/coreos/fleet/pulls/788"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/fleet/pulls/788","id":20020410,"html_url":"https://github.com/coreos/fleet/pull/788","diff_url":"https://github.com/coreos/fleet/pull/788.diff","patch_url":"https://github.com/coreos/fleet/pull/788.patch","issue_url":"https://api.github.com/repos/coreos/fleet/issues/788","number":788,"state":"open","locked":false,"title":"registry: publish UnitState with TTL","user":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=2","gravatar_id":"3fa4bd3403b1a81ac43f4769c8f74b66","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"body":"Fix #783","created_at":"2014-08-20T01:30:49Z","updated_at":"2014-08-20T18:02:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c23ce459a9f428b40dc9b6fd9145dbdb9f91a27","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/fleet/pulls/788/commits","review_comments_url":"https://api.github.com/repos/coreos/fleet/pulls/788/comments","review_comment_url":"https://api.github.com/repos/coreos/fleet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/coreos/fleet/issues/788/comments","statuses_url":"https://api.github.com/repos/coreos/fleet/statuses/edac73354062f26d54f1f181ec4ba5a68753f25a","head":{"label":"bcwaldon:783","ref":"783","sha":"edac73354062f26d54f1f181ec4ba5a68753f25a","user":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=2","gravatar_id":"3fa4bd3403b1a81ac43f4769c8f74b66","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"repo":{"id":14316614,"name":"fleet","full_name":"bcwaldon/fleet","owner":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=2","gravatar_id":"3fa4bd3403b1a81ac43f4769c8f74b66","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcwaldon/fleet","description":"","fork":true,"url":"https://api.github.com/repos/bcwaldon/fleet","forks_url":"https://api.github.com/repos/bcwaldon/fleet/forks","keys_url":"https://api.github.com/repos/bcwaldon/fleet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcwaldon/fleet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcwaldon/fleet/teams","hooks_url":"https://api.github.com/repos/bcwaldon/fleet/hooks","issue_events_url":"https://api.github.com/repos/bcwaldon/fleet/issues/events{/number}","events_url":"https://api.github.com/repos/bcwaldon/fleet/events","assignees_url":"https://api.github.com/repos/bcwaldon/fleet/assignees{/user}","branches_url":"https://api.github.com/repos/bcwaldon/fleet/branches{/branch}","tags_url":"https://api.github.com/repos/bcwaldon/fleet/tags","blobs_url":"https://api.github.com/repos/bcwaldon/fleet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcwaldon/fleet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcwaldon/fleet/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcwaldon/fleet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcwaldon/fleet/statuses/{sha}","languages_url":"https://api.github.com/repos/bcwaldon/fleet/languages","stargazers_url":"https://api.github.com/repos/bcwaldon/fleet/stargazers","contributors_url":"https://api.github.com/repos/bcwaldon/fleet/contributors","subscribers_url":"https://api.github.com/repos/bcwaldon/fleet/subscribers","subscription_url":"https://api.github.com/repos/bcwaldon/fleet/subscription","commits_url":"https://api.github.com/repos/bcwaldon/fleet/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcwaldon/fleet/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcwaldon/fleet/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcwaldon/fleet/issues/comments/{number}","contents_url":"https://api.github.com/repos/bcwaldon/fleet/contents/{+path}","compare_url":"https://api.github.com/repos/bcwaldon/fleet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcwaldon/fleet/merges","archive_url":"https://api.github.com/repos/bcwaldon/fleet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcwaldon/fleet/downloads","issues_url":"https://api.github.com/repos/bcwaldon/fleet/issues{/number}","pulls_url":"https://api.github.com/repos/bcwaldon/fleet/pulls{/number}","milestones_url":"https://api.github.com/repos/bcwaldon/fleet/milestones{/number}","notifications_url":"https://api.github.com/repos/bcwaldon/fleet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcwaldon/fleet/labels{/name}","releases_url":"https://api.github.com/repos/bcwaldon/fleet/releases{/id}","created_at":"2013-11-11T23:26:02Z","updated_at":"2014-07-25T23:50:43Z","pushed_at":"2014-08-20T17:58:49Z","git_url":"git://github.com/bcwaldon/fleet.git","ssh_url":"git@github.com:bcwaldon/fleet.git","clone_url":"https://github.com/bcwaldon/fleet.git","svn_url":"https://github.com/bcwaldon/fleet","homepage":null,"size":12592,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"61e93344ad906c71e45fb25a6c0b0fa9f25b4bc3","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=2","gravatar_id":"f477564b23efc2dd243407e926976125","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":13512328,"name":"fleet","full_name":"coreos/fleet","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=2","gravatar_id":"f477564b23efc2dd243407e926976125","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/fleet","description":"A Distributed init System","fork":false,"url":"https://api.github.com/repos/coreos/fleet","forks_url":"https://api.github.com/repos/coreos/fleet/forks","keys_url":"https://api.github.com/repos/coreos/fleet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/fleet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/fleet/teams","hooks_url":"https://api.github.com/repos/coreos/fleet/hooks","issue_events_url":"https://api.github.com/repos/coreos/fleet/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/fleet/events","assignees_url":"https://api.github.com/repos/coreos/fleet/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/fleet/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/fleet/tags","blobs_url":"https://api.github.com/repos/coreos/fleet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/fleet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/fleet/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/fleet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/fleet/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/fleet/languages","stargazers_url":"https://api.github.com/repos/coreos/fleet/stargazers","contributors_url":"https://api.github.com/repos/coreos/fleet/contributors","subscribers_url":"https://api.github.com/repos/coreos/fleet/subscribers","subscription_url":"https://api.github.com/repos/coreos/fleet/subscription","commits_url":"https://api.github.com/repos/coreos/fleet/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/fleet/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/fleet/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/fleet/issues/comments/{number}","contents_url":"https://api.github.com/repos/coreos/fleet/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/fleet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/fleet/merges","archive_url":"https://api.github.com/repos/coreos/fleet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/fleet/downloads","issues_url":"https://api.github.com/repos/coreos/fleet/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/fleet/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/fleet/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/fleet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/fleet/labels{/name}","releases_url":"https://api.github.com/repos/coreos/fleet/releases{/id}","created_at":"2013-10-11T23:56:38Z","updated_at":"2014-08-20T14:57:30Z","pushed_at":"2014-08-20T01:48:35Z","git_url":"git://github.com/coreos/fleet.git","ssh_url":"git@github.com:coreos/fleet.git","clone_url":"https://github.com/coreos/fleet.git","svn_url":"https://github.com/coreos/fleet","homepage":"","size":17663,"stargazers_count":989,"watchers_count":989,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":83,"mirror_url":null,"open_issues_count":60,"forks":83,"open_issues":60,"watchers":989,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/fleet/pulls/788"},"html":{"href":"https://github.com/coreos/fleet/pull/788"},"issue":{"href":"https://api.github.com/repos/coreos/fleet/issues/788"},"comments":{"href":"https://api.github.com/repos/coreos/fleet/issues/788/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/fleet/pulls/788/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/fleet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/coreos/fleet/pulls/788/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/fleet/statuses/edac73354062f26d54f1f181ec4ba5a68753f25a"}}}}