GitHub PullRequestReviewCommentEvent at 2014-03-11 20:50:44
Repository: manifest
Actor: marcoscaceres
Payload: {"comment":{"url":"https://api.github.com/repos/w3c/manifest/pulls/comments/10495408","id":10495408,"diff_hunk":"@@ -800,6 +840,58 @@\n           </li>\n         </ol>\n       </section>\n+      <section>\n+        <h3>\n+          <code title=\"\">csp</code> member\n+        </h3>\n+        <p>\n+          The <dfn id=\"member-csp\"><code>csp</code></dfn> member is a <a title=\n+          \"json-string\">string</a> that represents a <dfn>supplemental <a href=\n+          \"http://w3c.github.io/webappsec/specs/content-security-policy/csp-specification.dev.html#dfn-security-policy\">\n+          security policy</a></dfn>. The string is a <dfn>valid supplemental\n+          security policy</dfn> if it matches the <a href=\n+          \"http://w3c.github.io/webappsec/specs/content-security-policy/csp-specification.dev.html#policies\">\n+          <code>policy</code> production</a> defined in [[!CSP11]].\n+        </p>\n+        <div class=\"note\">\n+          <p>\n+            The <code>csp</code> member supplements the <a href=\n+            \"http://w3c.github.io/webappsec/specs/content-security-policy/csp-specification.dev.html#policy-delivery\">\n+            policy delivery</a> mechanisms defined in [[!CSP11]], and allows\n+            the author to indicate that the user agent is to enforce a\n+            <a>supplemental security policy</a> (according to the rules of\n+            <a href=\n+            \"http://w3c.github.io/webappsec/specs/content-security-policy/csp-specification.dev.html#enforcing-multiple-policies.x\">\n+            enforcing multiple policies</a> [[!CSP11]]) for a resource\n+            <a>associated with a manifest</a>.\n+          </p>\n+        </div>\n+        <p>\n+          The <dfn>steps for processing the csp member</dfn> is given by the\n+          following algorithm. The algorithm takes a <var>manifest</var> as\n+          argument. This algorithm returns a <a>valid supplemental security\n+          policy</a> or <code>undefined</code>.\n+        </p>\n+        <ol>\n+          <li>Let <var>policy</var> be the result of calling the\n+          <a>[[\\GetOwnProperty]]</a> internal method of <var>manifest</var>\n+          with argument \"csp\".\n+          </li>\n+          <li>If <a>Type</a>(<var>policy</var>) is not \"string\", return <code>\n+            undefined</code>.","path":"index.html","position":124,"original_position":124,"commit_id":"e54f9c76bdf89ab7378d009b11fb76c7c79cf4e6","original_commit_id":"e54f9c76bdf89ab7378d009b11fb76c7c79cf4e6","user":{"login":"marcoscaceres","id":870154,"avatar_url":"https://gravatar.com/avatar/6ad0fc0ed3dd7dc144c557a225a78dbc?d=https%3A%2F%2Fidenticons.github.com%2F1df347c4b51aedcd15ae8c66729bc4cf.png&r=x","gravatar_id":"6ad0fc0ed3dd7dc144c557a225a78dbc","url":"https://api.github.com/users/marcoscaceres","html_url":"https://github.com/marcoscaceres","followers_url":"https://api.github.com/users/marcoscaceres/followers","following_url":"https://api.github.com/users/marcoscaceres/following{/other_user}","gists_url":"https://api.github.com/users/marcoscaceres/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoscaceres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoscaceres/subscriptions","organizations_url":"https://api.github.com/users/marcoscaceres/orgs","repos_url":"https://api.github.com/users/marcoscaceres/repos","events_url":"https://api.github.com/users/marcoscaceres/events{/privacy}","received_events_url":"https://api.github.com/users/marcoscaceres/received_events","type":"User","site_admin":false},"body":"You need to check if it's not undefined and not a string here, and issue a developer warning. It would be bad not to warn the developer they have screwed up the policy. ","created_at":"2014-03-11T20:50:44Z","updated_at":"2014-03-11T20:50:44Z","html_url":"https://github.com/w3c/manifest/pull/162#discussion_r10495408","pull_request_url":"https://api.github.com/repos/w3c/manifest/pulls/162","_links":{"self":{"href":"https://api.github.com/repos/w3c/manifest/pulls/comments/10495408"},"html":{"href":"https://github.com/w3c/manifest/pull/162#discussion_r10495408"},"pull_request":{"href":"https://api.github.com/repos/w3c/manifest/pulls/162"}}}}