GitHub PullRequestEvent at 2014-09-03 09:29:51
Repository: Samples
Actor: sfarmar
Payload: {"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/sfarmar/Samples/pulls/2","id":20651504,"html_url":"https://github.com/sfarmar/Samples/pull/2","diff_url":"https://github.com/sfarmar/Samples/pull/2.diff","patch_url":"https://github.com/sfarmar/Samples/pull/2.patch","issue_url":"https://api.github.com/repos/sfarmar/Samples/issues/2","number":2,"state":"closed","locked":false,"title":"caching HttpClient to avoid pool exhaustion","user":{"login":"SeanFeldman","id":1309622,"avatar_url":"https://avatars.githubusercontent.com/u/1309622?v=2","gravatar_id":"0470d91615bbd75e864b509a4bc5e395","url":"https://api.github.com/users/SeanFeldman","html_url":"https://github.com/SeanFeldman","followers_url":"https://api.github.com/users/SeanFeldman/followers","following_url":"https://api.github.com/users/SeanFeldman/following{/other_user}","gists_url":"https://api.github.com/users/SeanFeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanFeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanFeldman/subscriptions","organizations_url":"https://api.github.com/users/SeanFeldman/orgs","repos_url":"https://api.github.com/users/SeanFeldman/repos","events_url":"https://api.github.com/users/SeanFeldman/events{/privacy}","received_events_url":"https://api.github.com/users/SeanFeldman/received_events","type":"User","site_admin":false},"body":" From HttpClient [MSDN](http://msdn.microsoft.com/en-us/library/system.net.http.httpclient(v=vs.110).aspx):\r\n\r\nThe HttpClient class instance acts as a session to send HTTP requests. An HttpClient instance is a collection of settings applied to all requests executed by that instance. In addition, every HttpClient instance uses its own connection pool, isolating its requests from requests executed by other HttpClient instances.\r\n\r\nUsing IDisposable defeats connection pooling. Since you are implicitly creating an new connection pool on every post. The fix is to share the “HttpClient” object and not create a new instance of that object on every request.","created_at":"2014-09-03T01:41:00Z","updated_at":"2014-09-03T09:29:50Z","closed_at":"2014-09-03T09:29:50Z","merged_at":"2014-09-03T09:29:50Z","merge_commit_sha":"a7ac46f5bc834af0e1f571b9e812508dbc7cf7d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sfarmar/Samples/pulls/2/commits","review_comments_url":"https://api.github.com/repos/sfarmar/Samples/pulls/2/comments","review_comment_url":"https://api.github.com/repos/sfarmar/Samples/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sfarmar/Samples/issues/2/comments","statuses_url":"https://api.github.com/repos/sfarmar/Samples/statuses/ee16187ca5c0683b5dcf0c80d02e5d7aed89b772","head":{"label":"SeanFeldman:master","ref":"master","sha":"ee16187ca5c0683b5dcf0c80d02e5d7aed89b772","user":{"login":"SeanFeldman","id":1309622,"avatar_url":"https://avatars.githubusercontent.com/u/1309622?v=2","gravatar_id":"0470d91615bbd75e864b509a4bc5e395","url":"https://api.github.com/users/SeanFeldman","html_url":"https://github.com/SeanFeldman","followers_url":"https://api.github.com/users/SeanFeldman/followers","following_url":"https://api.github.com/users/SeanFeldman/following{/other_user}","gists_url":"https://api.github.com/users/SeanFeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanFeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanFeldman/subscriptions","organizations_url":"https://api.github.com/users/SeanFeldman/orgs","repos_url":"https://api.github.com/users/SeanFeldman/repos","events_url":"https://api.github.com/users/SeanFeldman/events{/privacy}","received_events_url":"https://api.github.com/users/SeanFeldman/received_events","type":"User","site_admin":false},"repo":{"id":23601826,"name":"Samples","full_name":"SeanFeldman/Samples","owner":{"login":"SeanFeldman","id":1309622,"avatar_url":"https://avatars.githubusercontent.com/u/1309622?v=2","gravatar_id":"0470d91615bbd75e864b509a4bc5e395","url":"https://api.github.com/users/SeanFeldman","html_url":"https://github.com/SeanFeldman","followers_url":"https://api.github.com/users/SeanFeldman/followers","following_url":"https://api.github.com/users/SeanFeldman/following{/other_user}","gists_url":"https://api.github.com/users/SeanFeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanFeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanFeldman/subscriptions","organizations_url":"https://api.github.com/users/SeanFeldman/orgs","repos_url":"https://api.github.com/users/SeanFeldman/repos","events_url":"https://api.github.com/users/SeanFeldman/events{/privacy}","received_events_url":"https://api.github.com/users/SeanFeldman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SeanFeldman/Samples","description":"","fork":true,"url":"https://api.github.com/repos/SeanFeldman/Samples","forks_url":"https://api.github.com/repos/SeanFeldman/Samples/forks","keys_url":"https://api.github.com/repos/SeanFeldman/Samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeanFeldman/Samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeanFeldman/Samples/teams","hooks_url":"https://api.github.com/repos/SeanFeldman/Samples/hooks","issue_events_url":"https://api.github.com/repos/SeanFeldman/Samples/issues/events{/number}","events_url":"https://api.github.com/repos/SeanFeldman/Samples/events","assignees_url":"https://api.github.com/repos/SeanFeldman/Samples/assignees{/user}","branches_url":"https://api.github.com/repos/SeanFeldman/Samples/branches{/branch}","tags_url":"https://api.github.com/repos/SeanFeldman/Samples/tags","blobs_url":"https://api.github.com/repos/SeanFeldman/Samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeanFeldman/Samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeanFeldman/Samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeanFeldman/Samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeanFeldman/Samples/statuses/{sha}","languages_url":"https://api.github.com/repos/SeanFeldman/Samples/languages","stargazers_url":"https://api.github.com/repos/SeanFeldman/Samples/stargazers","contributors_url":"https://api.github.com/repos/SeanFeldman/Samples/contributors","subscribers_url":"https://api.github.com/repos/SeanFeldman/Samples/subscribers","subscription_url":"https://api.github.com/repos/SeanFeldman/Samples/subscription","commits_url":"https://api.github.com/repos/SeanFeldman/Samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeanFeldman/Samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeanFeldman/Samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeanFeldman/Samples/issues/comments/{number}","contents_url":"https://api.github.com/repos/SeanFeldman/Samples/contents/{+path}","compare_url":"https://api.github.com/repos/SeanFeldman/Samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeanFeldman/Samples/merges","archive_url":"https://api.github.com/repos/SeanFeldman/Samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeanFeldman/Samples/downloads","issues_url":"https://api.github.com/repos/SeanFeldman/Samples/issues{/number}","pulls_url":"https://api.github.com/repos/SeanFeldman/Samples/pulls{/number}","milestones_url":"https://api.github.com/repos/SeanFeldman/Samples/milestones{/number}","notifications_url":"https://api.github.com/repos/SeanFeldman/Samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeanFeldman/Samples/labels{/name}","releases_url":"https://api.github.com/repos/SeanFeldman/Samples/releases{/id}","created_at":"2014-09-03T01:21:57Z","updated_at":"2014-09-03T01:37:12Z","pushed_at":"2014-09-03T01:37:11Z","git_url":"git://github.com/SeanFeldman/Samples.git","ssh_url":"git@github.com:SeanFeldman/Samples.git","clone_url":"https://github.com/SeanFeldman/Samples.git","svn_url":"https://github.com/SeanFeldman/Samples","homepage":"","size":12088,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sfarmar:master","ref":"master","sha":"738ece37bdbf92d8e1eac07ae5c8e0224f89b099","user":{"login":"sfarmar","id":125256,"avatar_url":"https://avatars.githubusercontent.com/u/125256?v=2","gravatar_id":"9a7cc5428cf85260083b765f2616146c","url":"https://api.github.com/users/sfarmar","html_url":"https://github.com/sfarmar","followers_url":"https://api.github.com/users/sfarmar/followers","following_url":"https://api.github.com/users/sfarmar/following{/other_user}","gists_url":"https://api.github.com/users/sfarmar/gists{/gist_id}","starred_url":"https://api.github.com/users/sfarmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfarmar/subscriptions","organizations_url":"https://api.github.com/users/sfarmar/orgs","repos_url":"https://api.github.com/users/sfarmar/repos","events_url":"https://api.github.com/users/sfarmar/events{/privacy}","received_events_url":"https://api.github.com/users/sfarmar/received_events","type":"User","site_admin":false},"repo":{"id":11587254,"name":"Samples","full_name":"sfarmar/Samples","owner":{"login":"sfarmar","id":125256,"avatar_url":"https://avatars.githubusercontent.com/u/125256?v=2","gravatar_id":"9a7cc5428cf85260083b765f2616146c","url":"https://api.github.com/users/sfarmar","html_url":"https://github.com/sfarmar","followers_url":"https://api.github.com/users/sfarmar/followers","following_url":"https://api.github.com/users/sfarmar/following{/other_user}","gists_url":"https://api.github.com/users/sfarmar/gists{/gist_id}","starred_url":"https://api.github.com/users/sfarmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfarmar/subscriptions","organizations_url":"https://api.github.com/users/sfarmar/orgs","repos_url":"https://api.github.com/users/sfarmar/repos","events_url":"https://api.github.com/users/sfarmar/events{/privacy}","received_events_url":"https://api.github.com/users/sfarmar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfarmar/Samples","description":"","fork":false,"url":"https://api.github.com/repos/sfarmar/Samples","forks_url":"https://api.github.com/repos/sfarmar/Samples/forks","keys_url":"https://api.github.com/repos/sfarmar/Samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfarmar/Samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfarmar/Samples/teams","hooks_url":"https://api.github.com/repos/sfarmar/Samples/hooks","issue_events_url":"https://api.github.com/repos/sfarmar/Samples/issues/events{/number}","events_url":"https://api.github.com/repos/sfarmar/Samples/events","assignees_url":"https://api.github.com/repos/sfarmar/Samples/assignees{/user}","branches_url":"https://api.github.com/repos/sfarmar/Samples/branches{/branch}","tags_url":"https://api.github.com/repos/sfarmar/Samples/tags","blobs_url":"https://api.github.com/repos/sfarmar/Samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfarmar/Samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfarmar/Samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfarmar/Samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfarmar/Samples/statuses/{sha}","languages_url":"https://api.github.com/repos/sfarmar/Samples/languages","stargazers_url":"https://api.github.com/repos/sfarmar/Samples/stargazers","contributors_url":"https://api.github.com/repos/sfarmar/Samples/contributors","subscribers_url":"https://api.github.com/repos/sfarmar/Samples/subscribers","subscription_url":"https://api.github.com/repos/sfarmar/Samples/subscription","commits_url":"https://api.github.com/repos/sfarmar/Samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfarmar/Samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfarmar/Samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfarmar/Samples/issues/comments/{number}","contents_url":"https://api.github.com/repos/sfarmar/Samples/contents/{+path}","compare_url":"https://api.github.com/repos/sfarmar/Samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfarmar/Samples/merges","archive_url":"https://api.github.com/repos/sfarmar/Samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfarmar/Samples/downloads","issues_url":"https://api.github.com/repos/sfarmar/Samples/issues{/number}","pulls_url":"https://api.github.com/repos/sfarmar/Samples/pulls{/number}","milestones_url":"https://api.github.com/repos/sfarmar/Samples/milestones{/number}","notifications_url":"https://api.github.com/repos/sfarmar/Samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfarmar/Samples/labels{/name}","releases_url":"https://api.github.com/repos/sfarmar/Samples/releases{/id}","created_at":"2013-07-22T17:13:42Z","updated_at":"2014-07-07T17:12:46Z","pushed_at":"2014-09-03T09:29:51Z","git_url":"git://github.com/sfarmar/Samples.git","ssh_url":"git@github.com:sfarmar/Samples.git","clone_url":"https://github.com/sfarmar/Samples.git","svn_url":"https://github.com/sfarmar/Samples","homepage":"","size":12582,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":16,"mirror_url":null,"open_issues_count":0,"forks":16,"open_issues":0,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sfarmar/Samples/pulls/2"},"html":{"href":"https://github.com/sfarmar/Samples/pull/2"},"issue":{"href":"https://api.github.com/repos/sfarmar/Samples/issues/2"},"comments":{"href":"https://api.github.com/repos/sfarmar/Samples/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/sfarmar/Samples/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/sfarmar/Samples/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sfarmar/Samples/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/sfarmar/Samples/statuses/ee16187ca5c0683b5dcf0c80d02e5d7aed89b772"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sfarmar","id":125256,"avatar_url":"https://avatars.githubusercontent.com/u/125256?v=2","gravatar_id":"9a7cc5428cf85260083b765f2616146c","url":"https://api.github.com/users/sfarmar","html_url":"https://github.com/sfarmar","followers_url":"https://api.github.com/users/sfarmar/followers","following_url":"https://api.github.com/users/sfarmar/following{/other_user}","gists_url":"https://api.github.com/users/sfarmar/gists{/gist_id}","starred_url":"https://api.github.com/users/sfarmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfarmar/subscriptions","organizations_url":"https://api.github.com/users/sfarmar/orgs","repos_url":"https://api.github.com/users/sfarmar/repos","events_url":"https://api.github.com/users/sfarmar/events{/privacy}","received_events_url":"https://api.github.com/users/sfarmar/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":14,"deletions":14,"changed_files":1}}