GitHub PullRequestReviewCommentEvent at 2014-04-28 15:11:52
Repository: spark
Actor: devoncarew
Payload: {"comment":{"url":"https://api.github.com/repos/dart-lang/spark/pulls/comments/12050653","id":12050653,"diff_hunk":"@@ -31,15 +47,27 @@ class BowerFetcher {\n \n   BowerFetcher(this._packagesDir, this._packageSpecFileName);\n \n-  Future fetchDependencies(chrome.ChromeFileEntry specFile) {\n-    return _gatherAllDeps(_readLocalSpecFile(specFile)).then((_) {\n-      return _fetchAllDeps();\n+  Future fetchDependencies(chrome.ChromeFileEntry specFile, FetchMode mode) {\n+    return _gatherAllDeps(\n+        _readLocalSpecFile(specFile), specFile.fullPath\n+    ).catchError((e) {\n+      return e;","path":"ide/app/lib/package_mgmt/bower_fetcher.dart","position":38,"original_position":38,"commit_id":"27c11d0a0e406bc95c5c86ba8a58816a81d8fd22","original_commit_id":"27c11d0a0e406bc95c5c86ba8a58816a81d8fd22","user":{"login":"devoncarew","id":1269969,"avatar_url":"https://avatars.githubusercontent.com/u/1269969?","gravatar_id":"a4184620e2a180ff0e315e1e0f1eb8d5","url":"https://api.github.com/users/devoncarew","html_url":"https://github.com/devoncarew","followers_url":"https://api.github.com/users/devoncarew/followers","following_url":"https://api.github.com/users/devoncarew/following{/other_user}","gists_url":"https://api.github.com/users/devoncarew/gists{/gist_id}","starred_url":"https://api.github.com/users/devoncarew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devoncarew/subscriptions","organizations_url":"https://api.github.com/users/devoncarew/orgs","repos_url":"https://api.github.com/users/devoncarew/repos","events_url":"https://api.github.com/users/devoncarew/events{/privacy}","received_events_url":"https://api.github.com/users/devoncarew/received_events","type":"User","site_admin":false},"body":"This will return the exception via the Future's `then` clause, rather then `catchError`. I'd remove the catchError and `return e` and just let the exception propagate up through the Future normally.","created_at":"2014-04-28T15:11:52Z","updated_at":"2014-04-28T15:11:52Z","html_url":"https://github.com/dart-lang/spark/pull/1724#discussion_r12050653","pull_request_url":"https://api.github.com/repos/dart-lang/spark/pulls/1724","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/spark/pulls/comments/12050653"},"html":{"href":"https://github.com/dart-lang/spark/pull/1724#discussion_r12050653"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/spark/pulls/1724"}}}}