GitHub PullRequestReviewCommentEvent at 2014-09-23 16:16:21
Repository: query
Actor: rDr4g0n
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zenoss/query/pulls/comments/17919183","id":17919183,"diff_hunk":"@@ -87,6 +87,9 @@\n             throw new utils.Error('SelectorError', 'unknown selector specified, \"' + this.name + '\"');\n         }\n \n+        // base should be something like 1000 or 1024\n+        this.base = config.base || 1000;","path":"src/main/js/visualization/src/Chart.js","position":5,"original_position":5,"commit_id":"7b5e8d8127e8bd6aa0c7de910f67945d73dafddb","original_commit_id":"7b5e8d8127e8bd6aa0c7de910f67945d73dafddb","user":{"login":"rDr4g0n","id":1927558,"avatar_url":"https://avatars.githubusercontent.com/u/1927558?v=2","gravatar_id":"","url":"https://api.github.com/users/rDr4g0n","html_url":"https://github.com/rDr4g0n","followers_url":"https://api.github.com/users/rDr4g0n/followers","following_url":"https://api.github.com/users/rDr4g0n/following{/other_user}","gists_url":"https://api.github.com/users/rDr4g0n/gists{/gist_id}","starred_url":"https://api.github.com/users/rDr4g0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rDr4g0n/subscriptions","organizations_url":"https://api.github.com/users/rDr4g0n/orgs","repos_url":"https://api.github.com/users/rDr4g0n/repos","events_url":"https://api.github.com/users/rDr4g0n/events{/privacy}","received_events_url":"https://api.github.com/users/rDr4g0n/received_events","type":"User","site_admin":false},"body":"right now the base value is being set on a per-graph level, not on per series. Should this not be the case? Does it makes sense to have series' with different bases?","created_at":"2014-09-23T16:16:21Z","updated_at":"2014-09-23T16:16:21Z","html_url":"https://github.com/zenoss/query/pull/114#discussion_r17919183","pull_request_url":"https://api.github.com/repos/zenoss/query/pulls/114","_links":{"self":{"href":"https://api.github.com/repos/zenoss/query/pulls/comments/17919183"},"html":{"href":"https://github.com/zenoss/query/pull/114#discussion_r17919183"},"pull_request":{"href":"https://api.github.com/repos/zenoss/query/pulls/114"}}},"pull_request":{"url":"https://api.github.com/repos/zenoss/query/pulls/114","id":21651764,"html_url":"https://github.com/zenoss/query/pull/114","diff_url":"https://github.com/zenoss/query/pull/114.diff","patch_url":"https://github.com/zenoss/query/pull/114.patch","issue_url":"https://api.github.com/repos/zenoss/query/issues/114","number":114,"state":"open","locked":false,"title":"add configurable base option","user":{"login":"rDr4g0n","id":1927558,"avatar_url":"https://avatars.githubusercontent.com/u/1927558?v=2","gravatar_id":"","url":"https://api.github.com/users/rDr4g0n","html_url":"https://github.com/rDr4g0n","followers_url":"https://api.github.com/users/rDr4g0n/followers","following_url":"https://api.github.com/users/rDr4g0n/following{/other_user}","gists_url":"https://api.github.com/users/rDr4g0n/gists{/gist_id}","starred_url":"https://api.github.com/users/rDr4g0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rDr4g0n/subscriptions","organizations_url":"https://api.github.com/users/rDr4g0n/orgs","repos_url":"https://api.github.com/users/rDr4g0n/repos","events_url":"https://api.github.com/users/rDr4g0n/events{/privacy}","received_events_url":"https://api.github.com/users/rDr4g0n/received_events","type":"User","site_admin":false},"body":"allow graph defs to specify their base unit. specifically this lets graph defs which work with bytes specify that they should be calculated using 1024 instead of 1000","created_at":"2014-09-23T15:03:34Z","updated_at":"2014-09-23T16:16:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3974762fd2991ef3f76a16528db836e47e49000","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zenoss/query/pulls/114/commits","review_comments_url":"https://api.github.com/repos/zenoss/query/pulls/114/comments","review_comment_url":"https://api.github.com/repos/zenoss/query/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zenoss/query/issues/114/comments","statuses_url":"https://api.github.com/repos/zenoss/query/statuses/7b5e8d8127e8bd6aa0c7de910f67945d73dafddb","head":{"label":"zenoss:feature/ZEN-14429","ref":"feature/ZEN-14429","sha":"7b5e8d8127e8bd6aa0c7de910f67945d73dafddb","user":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=2","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"repo":{"id":10741477,"name":"query","full_name":"zenoss/query","owner":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=2","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenoss/query","description":"Repository to provide a query interface for the centralized storage","fork":false,"url":"https://api.github.com/repos/zenoss/query","forks_url":"https://api.github.com/repos/zenoss/query/forks","keys_url":"https://api.github.com/repos/zenoss/query/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenoss/query/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenoss/query/teams","hooks_url":"https://api.github.com/repos/zenoss/query/hooks","issue_events_url":"https://api.github.com/repos/zenoss/query/issues/events{/number}","events_url":"https://api.github.com/repos/zenoss/query/events","assignees_url":"https://api.github.com/repos/zenoss/query/assignees{/user}","branches_url":"https://api.github.com/repos/zenoss/query/branches{/branch}","tags_url":"https://api.github.com/repos/zenoss/query/tags","blobs_url":"https://api.github.com/repos/zenoss/query/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenoss/query/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenoss/query/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenoss/query/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenoss/query/statuses/{sha}","languages_url":"https://api.github.com/repos/zenoss/query/languages","stargazers_url":"https://api.github.com/repos/zenoss/query/stargazers","contributors_url":"https://api.github.com/repos/zenoss/query/contributors","subscribers_url":"https://api.github.com/repos/zenoss/query/subscribers","subscription_url":"https://api.github.com/repos/zenoss/query/subscription","commits_url":"https://api.github.com/repos/zenoss/query/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenoss/query/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenoss/query/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenoss/query/issues/comments/{number}","contents_url":"https://api.github.com/repos/zenoss/query/contents/{+path}","compare_url":"https://api.github.com/repos/zenoss/query/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenoss/query/merges","archive_url":"https://api.github.com/repos/zenoss/query/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenoss/query/downloads","issues_url":"https://api.github.com/repos/zenoss/query/issues{/number}","pulls_url":"https://api.github.com/repos/zenoss/query/pulls{/number}","milestones_url":"https://api.github.com/repos/zenoss/query/milestones{/number}","notifications_url":"https://api.github.com/repos/zenoss/query/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenoss/query/labels{/name}","releases_url":"https://api.github.com/repos/zenoss/query/releases{/id}","created_at":"2013-06-17T16:13:20Z","updated_at":"2014-09-02T14:13:42Z","pushed_at":"2014-09-23T15:02:16Z","git_url":"git://github.com/zenoss/query.git","ssh_url":"git@github.com:zenoss/query.git","clone_url":"https://github.com/zenoss/query.git","svn_url":"https://github.com/zenoss/query","homepage":null,"size":4892,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"zenoss:develop","ref":"develop","sha":"5438d7f1d56d5337cdb80e3a466d49863a8156f4","user":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=2","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"repo":{"id":10741477,"name":"query","full_name":"zenoss/query","owner":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=2","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenoss/query","description":"Repository to provide a query interface for the centralized storage","fork":false,"url":"https://api.github.com/repos/zenoss/query","forks_url":"https://api.github.com/repos/zenoss/query/forks","keys_url":"https://api.github.com/repos/zenoss/query/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenoss/query/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenoss/query/teams","hooks_url":"https://api.github.com/repos/zenoss/query/hooks","issue_events_url":"https://api.github.com/repos/zenoss/query/issues/events{/number}","events_url":"https://api.github.com/repos/zenoss/query/events","assignees_url":"https://api.github.com/repos/zenoss/query/assignees{/user}","branches_url":"https://api.github.com/repos/zenoss/query/branches{/branch}","tags_url":"https://api.github.com/repos/zenoss/query/tags","blobs_url":"https://api.github.com/repos/zenoss/query/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenoss/query/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenoss/query/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenoss/query/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenoss/query/statuses/{sha}","languages_url":"https://api.github.com/repos/zenoss/query/languages","stargazers_url":"https://api.github.com/repos/zenoss/query/stargazers","contributors_url":"https://api.github.com/repos/zenoss/query/contributors","subscribers_url":"https://api.github.com/repos/zenoss/query/subscribers","subscription_url":"https://api.github.com/repos/zenoss/query/subscription","commits_url":"https://api.github.com/repos/zenoss/query/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenoss/query/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenoss/query/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenoss/query/issues/comments/{number}","contents_url":"https://api.github.com/repos/zenoss/query/contents/{+path}","compare_url":"https://api.github.com/repos/zenoss/query/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenoss/query/merges","archive_url":"https://api.github.com/repos/zenoss/query/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenoss/query/downloads","issues_url":"https://api.github.com/repos/zenoss/query/issues{/number}","pulls_url":"https://api.github.com/repos/zenoss/query/pulls{/number}","milestones_url":"https://api.github.com/repos/zenoss/query/milestones{/number}","notifications_url":"https://api.github.com/repos/zenoss/query/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenoss/query/labels{/name}","releases_url":"https://api.github.com/repos/zenoss/query/releases{/id}","created_at":"2013-06-17T16:13:20Z","updated_at":"2014-09-02T14:13:42Z","pushed_at":"2014-09-23T15:02:16Z","git_url":"git://github.com/zenoss/query.git","ssh_url":"git@github.com:zenoss/query.git","clone_url":"https://github.com/zenoss/query.git","svn_url":"https://github.com/zenoss/query","homepage":null,"size":4892,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zenoss/query/pulls/114"},"html":{"href":"https://github.com/zenoss/query/pull/114"},"issue":{"href":"https://api.github.com/repos/zenoss/query/issues/114"},"comments":{"href":"https://api.github.com/repos/zenoss/query/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/zenoss/query/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/zenoss/query/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zenoss/query/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/zenoss/query/statuses/7b5e8d8127e8bd6aa0c7de910f67945d73dafddb"}}}}