GitHub PullRequestReviewCommentEvent at 2014-10-17 09:59:09
Repository: barclamp-nova
Actor: dirkmueller
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/19009849","id":19009849,"diff_hunk":"@@ -3129,7 +3129,7 @@ vif_driver=nova.virt.libvirt.vif.LibvirtGenericVIFDriver\n #\n \n # Whether the V3 API is enabled or not (boolean value)\n-enabled=<%= @enable_nova_v3_api ? 'True' : 'False' %>\n+#enabled=false","path":"chef/cookbooks/nova/templates/default/nova.conf.erb","position":5,"original_position":5,"commit_id":"4db97ba2d903736529e0d3f5805146a9d1be9764","original_commit_id":"9d9d76cf460905b04f8dd5caa484f9accddcd440","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=2","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"body":"no, \"false\" is the correct value. This is openstack, not ruby. ","created_at":"2014-10-17T09:59:09Z","updated_at":"2014-10-17T09:59:09Z","html_url":"https://github.com/crowbar/barclamp-nova/pull/397#discussion_r19009849","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/397","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/19009849"},"html":{"href":"https://github.com/crowbar/barclamp-nova/pull/397#discussion_r19009849"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/397"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/397","id":22484722,"html_url":"https://github.com/crowbar/barclamp-nova/pull/397","diff_url":"https://github.com/crowbar/barclamp-nova/pull/397.diff","patch_url":"https://github.com/crowbar/barclamp-nova/pull/397.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues/397","number":397,"state":"open","locked":false,"title":"Implement support for Nova V2.1 API","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=2","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"body":"Nova V3 API was deprecated in favor for Nova V2.1 API. since\r\nwe had it offered only optionally and disabled by default, and\r\nsince it is currently completely broken, lets just remove it\r\nalltogether and enable V2.1 API instead, which is going to be\r\nstable going forward.","created_at":"2014-10-09T10:46:53Z","updated_at":"2014-10-17T09:59:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b112a4f9d212eecee6fcb72bb5b7382bb07ceba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/397/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/397/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues/397/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-nova/statuses/4db97ba2d903736529e0d3f5805146a9d1be9764","head":{"label":"dirkmueller:master","ref":"master","sha":"4db97ba2d903736529e0d3f5805146a9d1be9764","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=2","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"repo":{"id":10646687,"name":"barclamp-nova","full_name":"dirkmueller/barclamp-nova","owner":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=2","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dirkmueller/barclamp-nova","description":"OpenStack Compute","fork":true,"url":"https://api.github.com/repos/dirkmueller/barclamp-nova","forks_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/forks","keys_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/teams","hooks_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/hooks","issue_events_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/issues/events{/number}","events_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/events","assignees_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/assignees{/user}","branches_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/branches{/branch}","tags_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/tags","blobs_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/git/refs{/sha}","trees_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/statuses/{sha}","languages_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/languages","stargazers_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/stargazers","contributors_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/contributors","subscribers_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/subscribers","subscription_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/subscription","commits_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/commits{/sha}","git_commits_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/git/commits{/sha}","comments_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/comments{/number}","issue_comment_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/issues/comments/{number}","contents_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/contents/{+path}","compare_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/merges","archive_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/downloads","issues_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/issues{/number}","pulls_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/pulls{/number}","milestones_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/milestones{/number}","notifications_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/labels{/name}","releases_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/releases{/id}","created_at":"2013-06-12T16:13:55Z","updated_at":"2014-07-04T11:47:27Z","pushed_at":"2014-10-17T09:58:07Z","git_url":"git://github.com/dirkmueller/barclamp-nova.git","ssh_url":"git@github.com:dirkmueller/barclamp-nova.git","clone_url":"https://github.com/dirkmueller/barclamp-nova.git","svn_url":"https://github.com/dirkmueller/barclamp-nova","homepage":"https://github.com/dellcloudedge/crowbar","size":2555,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"c821a8b842f86aeb8e77e3708c66a9b8e989b957","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=2","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":2351631,"name":"barclamp-nova","full_name":"crowbar/barclamp-nova","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=2","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-nova","description":"OpenStack Nova: Compute component","fork":false,"url":"https://api.github.com/repos/crowbar/barclamp-nova","forks_url":"https://api.github.com/repos/crowbar/barclamp-nova/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-nova/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-nova/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-nova/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-nova/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-nova/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-nova/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-nova/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-nova/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-nova/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-nova/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-nova/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-nova/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-nova/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-nova/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-nova/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-nova/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues/comments/{number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-nova/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-nova/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-nova/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-nova/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-nova/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-nova/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-nova/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-nova/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-nova/releases{/id}","created_at":"2011-09-08T21:23:08Z","updated_at":"2014-10-10T15:38:52Z","pushed_at":"2014-10-08T14:50:48Z","git_url":"git://github.com/crowbar/barclamp-nova.git","ssh_url":"git@github.com:crowbar/barclamp-nova.git","clone_url":"https://github.com/crowbar/barclamp-nova.git","svn_url":"https://github.com/crowbar/barclamp-nova","homepage":"https://github.com/crowbar/crowbar","size":5734,"stargazers_count":64,"watchers_count":64,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":197,"mirror_url":null,"open_issues_count":8,"forks":197,"open_issues":8,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/397"},"html":{"href":"https://github.com/crowbar/barclamp-nova/pull/397"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/issues/397"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/issues/397/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/397/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/397/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/statuses/4db97ba2d903736529e0d3f5805146a9d1be9764"}}}}