GitHub PullRequestReviewCommentEvent at 2014-09-25 20:27:34
Repository: frontend
Actor: phamann
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/18057516","id":18057516,"diff_hunk":"@@ -376,6 +376,13 @@ class Article(content: ApiContentWithMeta) extends Content(content) {\n   lazy val hasVideoAtTop: Boolean = Jsoup.parseBodyFragment(body).body().children().headOption\n     .exists(e => e.hasClass(\"gu-video\") && e.tagName() == \"video\")\n \n+  lazy val hasSupportingAtBottom: Boolean =\n+    Jsoup.parseBodyFragment(body).select(\"> *:nth-last-child(-n+5)\")\n+      .select(\".element--showcase, .element--supporting, .element--thumbnail\").length > 0\n+\n+  lazy val tooSmallForBottomSocialButtons: Boolean =","path":"common/app/model/content.scala","position":8,"original_position":8,"commit_id":"099ff24f9cca3a0e08d73e667d72295ddc8331ce","original_commit_id":"099ff24f9cca3a0e08d73e667d72295ddc8331ce","user":{"login":"phamann","id":80089,"avatar_url":"https://avatars.githubusercontent.com/u/80089?v=2","gravatar_id":"","url":"https://api.github.com/users/phamann","html_url":"https://github.com/phamann","followers_url":"https://api.github.com/users/phamann/followers","following_url":"https://api.github.com/users/phamann/following{/other_user}","gists_url":"https://api.github.com/users/phamann/gists{/gist_id}","starred_url":"https://api.github.com/users/phamann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phamann/subscriptions","organizations_url":"https://api.github.com/users/phamann/orgs","repos_url":"https://api.github.com/users/phamann/repos","events_url":"https://api.github.com/users/phamann/events{/privacy}","received_events_url":"https://api.github.com/users/phamann/received_events","type":"User","site_admin":false},"body":"Something inside me feels like this shouldn't live directly inside the `Content` model. Could it not be a view support helper method inside [`package.scala`](https://github.com/guardian/frontend/blob/master/common/app/views/support/package.scala) instead?","created_at":"2014-09-25T20:27:34Z","updated_at":"2014-09-25T20:27:34Z","html_url":"https://github.com/guardian/frontend/pull/6139#discussion_r18057516","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/6139","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/18057516"},"html":{"href":"https://github.com/guardian/frontend/pull/6139#discussion_r18057516"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6139"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/6139","id":21795200,"html_url":"https://github.com/guardian/frontend/pull/6139","diff_url":"https://github.com/guardian/frontend/pull/6139.diff","patch_url":"https://github.com/guardian/frontend/pull/6139.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/6139","number":6139,"state":"open","locked":false,"title":"Clashfixes","user":{"login":"mattosborn","id":960919,"avatar_url":"https://avatars.githubusercontent.com/u/960919?v=2","gravatar_id":"","url":"https://api.github.com/users/mattosborn","html_url":"https://github.com/mattosborn","followers_url":"https://api.github.com/users/mattosborn/followers","following_url":"https://api.github.com/users/mattosborn/following{/other_user}","gists_url":"https://api.github.com/users/mattosborn/gists{/gist_id}","starred_url":"https://api.github.com/users/mattosborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattosborn/subscriptions","organizations_url":"https://api.github.com/users/mattosborn/orgs","repos_url":"https://api.github.com/users/mattosborn/repos","events_url":"https://api.github.com/users/mattosborn/events{/privacy}","received_events_url":"https://api.github.com/users/mattosborn/received_events","type":"User","site_admin":false},"body":"- Update JSoup\r\n- Change social button de-duping to a server-side solution\r\n- Rough server-side fix for tags overlapping supporting content towards the end of an article\r\n\r\n![image](https://cloud.githubusercontent.com/assets/960919/4408247/8fa6edc6-44d1-11e4-9841-cde48cb6c886.png)\r\n","created_at":"2014-09-25T16:33:16Z","updated_at":"2014-09-25T20:27:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01158b48012972aa7a88e46d816e4158edb00417","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/6139/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/6139/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/6139/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/099ff24f9cca3a0e08d73e667d72295ddc8331ce","head":{"label":"guardian:clashfix","ref":"clashfix","sha":"099ff24f9cca3a0e08d73e667d72295ddc8331ce","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-09-25T11:38:17Z","pushed_at":"2014-09-25T18:03:45Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":475918,"stargazers_count":2325,"watchers_count":2325,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":198,"mirror_url":null,"open_issues_count":79,"forks":198,"open_issues":79,"watchers":2325,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"3c5fcaf900326576eff0bb15ae695b4f1f4721a0","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-09-25T11:38:17Z","pushed_at":"2014-09-25T18:03:45Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":475918,"stargazers_count":2325,"watchers_count":2325,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":198,"mirror_url":null,"open_issues_count":79,"forks":198,"open_issues":79,"watchers":2325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6139"},"html":{"href":"https://github.com/guardian/frontend/pull/6139"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/6139"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/6139/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6139/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6139/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/099ff24f9cca3a0e08d73e667d72295ddc8331ce"}}}}