GitHub PullRequestEvent at 2014-11-04 17:18:32
Repository: Dynamo
Actor: vmoyseenko
Payload: {"action":"opened","number":176,"pull_request":{"url":"https://api.github.com/repos/Benglin/Dynamo/pulls/176","id":23847468,"html_url":"https://github.com/Benglin/Dynamo/pull/176","diff_url":"https://github.com/Benglin/Dynamo/pull/176.diff","patch_url":"https://github.com/Benglin/Dynamo/pull/176.patch","issue_url":"https://api.github.com/repos/Benglin/Dynamo/issues/176","number":176,"state":"open","locked":false,"title":"Rewrite unit tests for categories manipulation","user":{"login":"vmoyseenko","id":8158551,"avatar_url":"https://avatars.githubusercontent.com/u/8158551?v=2","gravatar_id":"","url":"https://api.github.com/users/vmoyseenko","html_url":"https://github.com/vmoyseenko","followers_url":"https://api.github.com/users/vmoyseenko/followers","following_url":"https://api.github.com/users/vmoyseenko/following{/other_user}","gists_url":"https://api.github.com/users/vmoyseenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vmoyseenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmoyseenko/subscriptions","organizations_url":"https://api.github.com/users/vmoyseenko/orgs","repos_url":"https://api.github.com/users/vmoyseenko/repos","events_url":"https://api.github.com/users/vmoyseenko/events{/privacy}","received_events_url":"https://api.github.com/users/vmoyseenko/received_events","type":"User","site_admin":false},"body":"#### Purpose\r\n\r\nEarlier in this PR https://github.com/Benglin/Dynamo/pull/132 was made separation code to `SearchModel` and new class `CategoryBuilder`. Tests which are use some functions of `SearchModel` were skipped. This PR adapts `SearchModelTests` to new reality.\r\n\r\n#### Modifications\r\n\r\n`SearchModel.browserCategoriesBuilder` and `SearchModel.addonCategoriesBuilder` are made as internal to have access from `DynamoCoreTests` project. In `SearcModelTests` used `search.addonCategoriesBuilder` instead of direct `SearchModel` functions. For all cases except one is used addons `CategoryBuilder`.\r\n\r\n#### Unit tests\r\n![image](https://cloud.githubusercontent.com/assets/8158551/4904201/5d713188-6446-11e4-9daf-a55e91f9c163.png)\r\n\r\n#### Additional references \r\n\r\n[MAGN-5157](http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-5157).\r\n\r\nNext planned is adding tests to test differences in work of `CategoryBuilder` for regular nodes and addons. Task:  [MAGN-53604](http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-5304).\r\n\r\n#### Reviewers\r\n\r\n@aosyatnik, @Benglin, please, take a look.","created_at":"2014-11-04T17:18:31Z","updated_at":"2014-11-04T17:18:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Benglin/Dynamo/pulls/176/commits","review_comments_url":"https://api.github.com/repos/Benglin/Dynamo/pulls/176/comments","review_comment_url":"https://api.github.com/repos/Benglin/Dynamo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Benglin/Dynamo/issues/176/comments","statuses_url":"https://api.github.com/repos/Benglin/Dynamo/statuses/f068455b7b80dae530d3044c4ea85c941604dbd0","head":{"label":"vmoyseenko:DUI-CategoryBuilderTests","ref":"DUI-CategoryBuilderTests","sha":"f068455b7b80dae530d3044c4ea85c941604dbd0","user":{"login":"vmoyseenko","id":8158551,"avatar_url":"https://avatars.githubusercontent.com/u/8158551?v=2","gravatar_id":"","url":"https://api.github.com/users/vmoyseenko","html_url":"https://github.com/vmoyseenko","followers_url":"https://api.github.com/users/vmoyseenko/followers","following_url":"https://api.github.com/users/vmoyseenko/following{/other_user}","gists_url":"https://api.github.com/users/vmoyseenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vmoyseenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmoyseenko/subscriptions","organizations_url":"https://api.github.com/users/vmoyseenko/orgs","repos_url":"https://api.github.com/users/vmoyseenko/repos","events_url":"https://api.github.com/users/vmoyseenko/events{/privacy}","received_events_url":"https://api.github.com/users/vmoyseenko/received_events","type":"User","site_admin":false},"repo":{"id":21822485,"name":"Dynamo","full_name":"vmoyseenko/Dynamo","owner":{"login":"vmoyseenko","id":8158551,"avatar_url":"https://avatars.githubusercontent.com/u/8158551?v=2","gravatar_id":"","url":"https://api.github.com/users/vmoyseenko","html_url":"https://github.com/vmoyseenko","followers_url":"https://api.github.com/users/vmoyseenko/followers","following_url":"https://api.github.com/users/vmoyseenko/following{/other_user}","gists_url":"https://api.github.com/users/vmoyseenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vmoyseenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmoyseenko/subscriptions","organizations_url":"https://api.github.com/users/vmoyseenko/orgs","repos_url":"https://api.github.com/users/vmoyseenko/repos","events_url":"https://api.github.com/users/vmoyseenko/events{/privacy}","received_events_url":"https://api.github.com/users/vmoyseenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vmoyseenko/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/vmoyseenko/Dynamo","forks_url":"https://api.github.com/repos/vmoyseenko/Dynamo/forks","keys_url":"https://api.github.com/repos/vmoyseenko/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmoyseenko/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmoyseenko/Dynamo/teams","hooks_url":"https://api.github.com/repos/vmoyseenko/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/vmoyseenko/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/vmoyseenko/Dynamo/events","assignees_url":"https://api.github.com/repos/vmoyseenko/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/vmoyseenko/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/vmoyseenko/Dynamo/tags","blobs_url":"https://api.github.com/repos/vmoyseenko/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmoyseenko/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmoyseenko/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmoyseenko/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmoyseenko/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/vmoyseenko/Dynamo/languages","stargazers_url":"https://api.github.com/repos/vmoyseenko/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/vmoyseenko/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/vmoyseenko/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/vmoyseenko/Dynamo/subscription","commits_url":"https://api.github.com/repos/vmoyseenko/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmoyseenko/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmoyseenko/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmoyseenko/Dynamo/issues/comments/{number}","contents_url":"https://api.github.com/repos/vmoyseenko/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/vmoyseenko/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmoyseenko/Dynamo/merges","archive_url":"https://api.github.com/repos/vmoyseenko/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmoyseenko/Dynamo/downloads","issues_url":"https://api.github.com/repos/vmoyseenko/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/vmoyseenko/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/vmoyseenko/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/vmoyseenko/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmoyseenko/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/vmoyseenko/Dynamo/releases{/id}","created_at":"2014-07-14T14:27:39Z","updated_at":"2014-07-29T14:57:09Z","pushed_at":"2014-11-04T16:30:29Z","git_url":"git://github.com/vmoyseenko/Dynamo.git","ssh_url":"git@github.com:vmoyseenko/Dynamo.git","clone_url":"https://github.com/vmoyseenko/Dynamo.git","svn_url":"https://github.com/vmoyseenko/Dynamo","homepage":"http://dynamobim.org","size":592999,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"Sitrus2"}},"base":{"label":"Benglin:Sitrus","ref":"Sitrus","sha":"41dd1227adfc2f7e1feed05a8a22c6671d609346","user":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=2","gravatar_id":"","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"repo":{"id":11675425,"name":"Dynamo","full_name":"Benglin/Dynamo","owner":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=2","gravatar_id":"","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Benglin/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/Benglin/Dynamo","forks_url":"https://api.github.com/repos/Benglin/Dynamo/forks","keys_url":"https://api.github.com/repos/Benglin/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Benglin/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Benglin/Dynamo/teams","hooks_url":"https://api.github.com/repos/Benglin/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/Benglin/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/Benglin/Dynamo/events","assignees_url":"https://api.github.com/repos/Benglin/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/Benglin/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/Benglin/Dynamo/tags","blobs_url":"https://api.github.com/repos/Benglin/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Benglin/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Benglin/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Benglin/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Benglin/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/Benglin/Dynamo/languages","stargazers_url":"https://api.github.com/repos/Benglin/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/Benglin/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/Benglin/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/Benglin/Dynamo/subscription","commits_url":"https://api.github.com/repos/Benglin/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Benglin/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Benglin/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Benglin/Dynamo/issues/comments/{number}","contents_url":"https://api.github.com/repos/Benglin/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/Benglin/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Benglin/Dynamo/merges","archive_url":"https://api.github.com/repos/Benglin/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Benglin/Dynamo/downloads","issues_url":"https://api.github.com/repos/Benglin/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/Benglin/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/Benglin/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/Benglin/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Benglin/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/Benglin/Dynamo/releases{/id}","created_at":"2013-07-26T01:54:49Z","updated_at":"2014-07-07T09:12:11Z","pushed_at":"2014-11-04T09:13:20Z","git_url":"git://github.com/Benglin/Dynamo.git","ssh_url":"git@github.com:Benglin/Dynamo.git","clone_url":"https://github.com/Benglin/Dynamo.git","svn_url":"https://github.com/Benglin/Dynamo","homepage":"http://dynamobim.org","size":724779,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Benglin/Dynamo/pulls/176"},"html":{"href":"https://github.com/Benglin/Dynamo/pull/176"},"issue":{"href":"https://api.github.com/repos/Benglin/Dynamo/issues/176"},"comments":{"href":"https://api.github.com/repos/Benglin/Dynamo/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/Benglin/Dynamo/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/Benglin/Dynamo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Benglin/Dynamo/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/Benglin/Dynamo/statuses/f068455b7b80dae530d3044c4ea85c941604dbd0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":71,"deletions":80,"changed_files":2}}