GitHub PullRequestReviewCommentEvent at 2014-12-14 13:12:01
Repository: mne-python
Actor: dengemann
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dengemann/mne-python/pulls/comments/21796268","id":21796268,"diff_hunk":"@@ -66,13 +66,22 @@ def test_generalization_across_time():\n \n     # Test default running\n     gat = GeneralizationAcrossTime()\n+    print(gat)  # check __repr__\n     gat.fit(epochs)\n+    print(gat)  # check __repr__\n     gat.predict(epochs)\n+    print(gat)  # check __repr__\n     gat.score(epochs)\n+    print(gat)  # check __repr__\n     gat.fit(epochs, y=epochs.events[:, 2])\n     gat.score(epochs, y=epochs.events[:, 2])\n+    assert_true(\"accuracy_score\" in gat.scorer_.__repr__())    \n     epochs2 = epochs.copy()\n \n+    # check DecodingTime class\n+    print(gat.train_times)\n+    print(gat.test_times_)","path":"mne/decoding/tests/test_time_gen.py","position":18,"original_position":18,"commit_id":"2bf99c988a2792554e672b169ea7b229192c15b5","original_commit_id":"2bf99c988a2792554e672b169ea7b229192c15b5","user":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2014-12-14T13:12:01Z","updated_at":"2014-12-14T13:12:01Z","html_url":"https://github.com/dengemann/mne-python/pull/17#discussion_r21796268","pull_request_url":"https://api.github.com/repos/dengemann/mne-python/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/dengemann/mne-python/pulls/comments/21796268"},"html":{"href":"https://github.com/dengemann/mne-python/pull/17#discussion_r21796268"},"pull_request":{"href":"https://api.github.com/repos/dengemann/mne-python/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/dengemann/mne-python/pulls/17","id":25837180,"html_url":"https://github.com/dengemann/mne-python/pull/17","diff_url":"https://github.com/dengemann/mne-python/pull/17.diff","patch_url":"https://github.com/dengemann/mne-python/pull/17.patch","issue_url":"https://api.github.com/repos/dengemann/mne-python/issues/17","number":17,"state":"open","locked":false,"title":"New time gen","user":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"body":"Finalize and address Alex's comments, trial 2.","created_at":"2014-12-10T16:57:59Z","updated_at":"2014-12-14T13:12:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d5b0c20e474489752bf1f3622617bd74f044eaa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dengemann/mne-python/pulls/17/commits","review_comments_url":"https://api.github.com/repos/dengemann/mne-python/pulls/17/comments","review_comment_url":"https://api.github.com/repos/dengemann/mne-python/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dengemann/mne-python/issues/17/comments","statuses_url":"https://api.github.com/repos/dengemann/mne-python/statuses/2bf99c988a2792554e672b169ea7b229192c15b5","head":{"label":"kingjr:new_time_gen","ref":"new_time_gen","sha":"2bf99c988a2792554e672b169ea7b229192c15b5","user":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"repo":{"id":19731468,"name":"mne-python","full_name":"kingjr/mne-python","owner":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kingjr/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/kingjr/mne-python","forks_url":"https://api.github.com/repos/kingjr/mne-python/forks","keys_url":"https://api.github.com/repos/kingjr/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingjr/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingjr/mne-python/teams","hooks_url":"https://api.github.com/repos/kingjr/mne-python/hooks","issue_events_url":"https://api.github.com/repos/kingjr/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/kingjr/mne-python/events","assignees_url":"https://api.github.com/repos/kingjr/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/kingjr/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/kingjr/mne-python/tags","blobs_url":"https://api.github.com/repos/kingjr/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingjr/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingjr/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingjr/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingjr/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/kingjr/mne-python/languages","stargazers_url":"https://api.github.com/repos/kingjr/mne-python/stargazers","contributors_url":"https://api.github.com/repos/kingjr/mne-python/contributors","subscribers_url":"https://api.github.com/repos/kingjr/mne-python/subscribers","subscription_url":"https://api.github.com/repos/kingjr/mne-python/subscription","commits_url":"https://api.github.com/repos/kingjr/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingjr/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingjr/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingjr/mne-python/issues/comments/{number}","contents_url":"https://api.github.com/repos/kingjr/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/kingjr/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingjr/mne-python/merges","archive_url":"https://api.github.com/repos/kingjr/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingjr/mne-python/downloads","issues_url":"https://api.github.com/repos/kingjr/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/kingjr/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/kingjr/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/kingjr/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingjr/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/kingjr/mne-python/releases{/id}","created_at":"2014-05-13T08:28:44Z","updated_at":"2014-06-02T12:58:51Z","pushed_at":"2014-12-14T11:48:17Z","git_url":"git://github.com/kingjr/mne-python.git","ssh_url":"git@github.com:kingjr/mne-python.git","clone_url":"https://github.com/kingjr/mne-python.git","svn_url":"https://github.com/kingjr/mne-python","homepage":"http://martinos.org/mne/","size":72822,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dengemann:new_time_gen","ref":"new_time_gen","sha":"d37a8fe23fd5a9eee37e78717ff981d0e0e9180d","user":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"repo":{"id":5578745,"name":"mne-python","full_name":"dengemann/mne-python","owner":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dengemann/mne-python","description":"MNE scripting with Python","fork":true,"url":"https://api.github.com/repos/dengemann/mne-python","forks_url":"https://api.github.com/repos/dengemann/mne-python/forks","keys_url":"https://api.github.com/repos/dengemann/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dengemann/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dengemann/mne-python/teams","hooks_url":"https://api.github.com/repos/dengemann/mne-python/hooks","issue_events_url":"https://api.github.com/repos/dengemann/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/dengemann/mne-python/events","assignees_url":"https://api.github.com/repos/dengemann/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/dengemann/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/dengemann/mne-python/tags","blobs_url":"https://api.github.com/repos/dengemann/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dengemann/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dengemann/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dengemann/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dengemann/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dengemann/mne-python/languages","stargazers_url":"https://api.github.com/repos/dengemann/mne-python/stargazers","contributors_url":"https://api.github.com/repos/dengemann/mne-python/contributors","subscribers_url":"https://api.github.com/repos/dengemann/mne-python/subscribers","subscription_url":"https://api.github.com/repos/dengemann/mne-python/subscription","commits_url":"https://api.github.com/repos/dengemann/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dengemann/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dengemann/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dengemann/mne-python/issues/comments/{number}","contents_url":"https://api.github.com/repos/dengemann/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/dengemann/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dengemann/mne-python/merges","archive_url":"https://api.github.com/repos/dengemann/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dengemann/mne-python/downloads","issues_url":"https://api.github.com/repos/dengemann/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/dengemann/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dengemann/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dengemann/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dengemann/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/dengemann/mne-python/releases{/id}","created_at":"2012-08-28T00:07:46Z","updated_at":"2014-09-16T13:18:12Z","pushed_at":"2014-12-13T10:46:36Z","git_url":"git://github.com/dengemann/mne-python.git","ssh_url":"git@github.com:dengemann/mne-python.git","clone_url":"https://github.com/dengemann/mne-python.git","svn_url":"https://github.com/dengemann/mne-python","homepage":"http://martinos.org/mne/","size":105113,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dengemann/mne-python/pulls/17"},"html":{"href":"https://github.com/dengemann/mne-python/pull/17"},"issue":{"href":"https://api.github.com/repos/dengemann/mne-python/issues/17"},"comments":{"href":"https://api.github.com/repos/dengemann/mne-python/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/dengemann/mne-python/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/dengemann/mne-python/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dengemann/mne-python/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/dengemann/mne-python/statuses/2bf99c988a2792554e672b169ea7b229192c15b5"}}}}