GitHub PullRequestReviewCommentEvent at 2014-02-06 18:00:48
Repository: factorie
Actor: CaitlinCell
Payload: {"comment":{"url":"https://api.github.com/repos/factorie/factorie/pulls/comments/9510564","id":9510564,"diff_hunk":"@@ -1,28 +1,28 @@\n package cc.factorie.app.nlp.phrase\n \n-import cc.factorie._\n import cc.factorie.app.nlp._\n import cc.factorie.variable.{EnumDomain, CategoricalVariable}\n+import cc.factorie.app.nlp.coref.mention.{Mention, MentionList}\n+import scala.reflect.ClassTag\n \n-object NounPhraseGenderDomain extends EnumDomain {\n+object GenderDomain extends EnumDomain {\n   val UNKNOWN,     // uncertain \n   NEUTER,          // known to be non-person\n   PERSON,          // person, but uncertain about gender\n   MALE,            // male person\n   FEMALE = Value   // female person\n }\n-class NounPhraseGenderLabel(val phrase:NounPhrase, initialCategory:String) extends CategoricalVariable(initialCategory) {\n-  def this(m:NounPhrase, initialIntValue:Int) = this(m, NounPhraseGenderDomain(initialIntValue).category.asInstanceOf[String])\n-  def domain = NounPhraseGenderDomain\n+class GenderLabel[P <: Phrase](val phrase: P, initialCategory:String) extends CategoricalVariable(initialCategory) {","path":"src/main/scala/cc/factorie/app/nlp/phrase/NounPhraseGender.scala","position":20,"original_position":20,"commit_id":"7b59dddc4afc11b33ffcdca65c366d956bc0df01","original_commit_id":"7b59dddc4afc11b33ffcdca65c366d956bc0df01","user":{"login":"CaitlinCell","id":2693724,"avatar_url":"https://gravatar.com/avatar/d670514c0dcd4f46e78acf9c6c504baa?d=https%3A%2F%2Fidenticons.github.com%2Ff74461099d396d3334e6ad33d0f72698.png&r=x","gravatar_id":"d670514c0dcd4f46e78acf9c6c504baa","url":"https://api.github.com/users/CaitlinCell","html_url":"https://github.com/CaitlinCell","followers_url":"https://api.github.com/users/CaitlinCell/followers","following_url":"https://api.github.com/users/CaitlinCell/following{/other_user}","gists_url":"https://api.github.com/users/CaitlinCell/gists{/gist_id}","starred_url":"https://api.github.com/users/CaitlinCell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaitlinCell/subscriptions","organizations_url":"https://api.github.com/users/CaitlinCell/orgs","repos_url":"https://api.github.com/users/CaitlinCell/repos","events_url":"https://api.github.com/users/CaitlinCell/events{/privacy}","received_events_url":"https://api.github.com/users/CaitlinCell/received_events","type":"User","site_admin":false},"body":"That would definitely be better.  Thanks for pointing it out, I don't know how I missed it! I've make the change.","created_at":"2014-02-06T18:00:48Z","updated_at":"2014-02-06T18:00:48Z","html_url":"https://github.com/factorie/factorie/pull/118#discussion_r9510564","pull_request_url":"https://api.github.com/repos/factorie/factorie/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/factorie/factorie/pulls/comments/9510564"},"html":{"href":"https://github.com/factorie/factorie/pull/118#discussion_r9510564"},"pull_request":{"href":"https://api.github.com/repos/factorie/factorie/pulls/118"}}}}