GitHub PullRequestReviewCommentEvent at 2014-11-26 09:45:56
Repository: akka
Actor: bantonsson
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/20924599","id":20924599,"diff_hunk":"@@ -0,0 +1,76 @@\n+package akka.stream.scaladsl\n+\n+import akka.stream.FlowMaterializer\n+import akka.stream.impl.Ast.AstAttributes._\n+import akka.stream.testkit.AkkaSpec\n+import akka.actor.ActorRef\n+import akka.testkit.TestProbe\n+\n+object FlowHasSpec {\n+  val config = \"my-dispatcher = ${akka.test.stream-dispatcher}\"\n+}\n+\n+class FlowHasSpec extends AkkaSpec(FlowHasSpec.config) {\n+\n+  implicit val mat = FlowMaterializer()\n+\n+  \"A flow\" can {\n+    \"have an op with a name\" in {\n+      val n = \"Converter to Int\"\n+      val f = Flow[Int].nextOpHas(name(n)).map(_.toInt)\n+      f.toString should include(n)\n+    }\n+\n+    \"have an op with a different dispatcher\" in {\n+      val flow = Flow[Int].nextOpHas(dispatcher(\"my-dispatcher\")).map(sendThreadNameTo(testActor))\n+\n+      Source.singleton(1).via(flow).to(Sink.ignore).run()\n+\n+      receiveN(1).foreach {\n+        case s: String ⇒ s should include(\"my-dispatcher\")\n+      }\n+    }\n+\n+    \"have an op chain with a name\" in {\n+      val n = \"Uppercase reverser\"\n+      val f = Flow[String].\n+        map(_.toLowerCase()).\n+        opChainHas(name(n)) {","path":"akka-stream-tests/src/test/scala/akka/stream/scaladsl/FlowHasSpec.scala","position":38,"original_position":38,"commit_id":"c02ad1d486edbdd6d8e1a0e86e551391d047a7e4","original_commit_id":"c02ad1d486edbdd6d8e1a0e86e551391d047a7e4","user":{"login":"bantonsson","id":805830,"avatar_url":"https://avatars.githubusercontent.com/u/805830?v=3","gravatar_id":"","url":"https://api.github.com/users/bantonsson","html_url":"https://github.com/bantonsson","followers_url":"https://api.github.com/users/bantonsson/followers","following_url":"https://api.github.com/users/bantonsson/following{/other_user}","gists_url":"https://api.github.com/users/bantonsson/gists{/gist_id}","starred_url":"https://api.github.com/users/bantonsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bantonsson/subscriptions","organizations_url":"https://api.github.com/users/bantonsson/orgs","repos_url":"https://api.github.com/users/bantonsson/repos","events_url":"https://api.github.com/users/bantonsson/events{/privacy}","received_events_url":"https://api.github.com/users/bantonsson/received_events","type":"User","site_admin":false},"body":"I think that we should go with only `section` and not mix before and after things. Would it be possible to have a `Source.section(..., source)` or something like that to avoid having the `withAttributes` on the `Source` trait?","created_at":"2014-11-26T09:45:56Z","updated_at":"2014-11-26T09:45:56Z","html_url":"https://github.com/akka/akka/pull/16357#discussion_r20924599","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/16357","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/20924599"},"html":{"href":"https://github.com/akka/akka/pull/16357#discussion_r20924599"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/16357"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/16357","id":24825315,"html_url":"https://github.com/akka/akka/pull/16357","diff_url":"https://github.com/akka/akka/pull/16357.diff","patch_url":"https://github.com/akka/akka/pull/16357.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/16357","number":16357,"state":"open","locked":false,"title":"=str #15152 ast transformations","user":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=3","gravatar_id":"","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"body":"* for feedback\r\n* only supports Flow map operation","created_at":"2014-11-21T08:29:19Z","updated_at":"2014-11-26T09:45:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"775eae81beb57ef1605d7c06511e8ac9e8780fda","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/16357/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/16357/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments/{number}","comments_url":"https://api.github.com/repos/akka/akka/issues/16357/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/c02ad1d486edbdd6d8e1a0e86e551391d047a7e4","head":{"label":"2m:wip-15152-ast-transformations","ref":"wip-15152-ast-transformations","sha":"c02ad1d486edbdd6d8e1a0e86e551391d047a7e4","user":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=3","gravatar_id":"","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"repo":{"id":18794399,"name":"akka","full_name":"2m/akka","owner":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=3","gravatar_id":"","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/2m/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/2m/akka","forks_url":"https://api.github.com/repos/2m/akka/forks","keys_url":"https://api.github.com/repos/2m/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2m/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2m/akka/teams","hooks_url":"https://api.github.com/repos/2m/akka/hooks","issue_events_url":"https://api.github.com/repos/2m/akka/issues/events{/number}","events_url":"https://api.github.com/repos/2m/akka/events","assignees_url":"https://api.github.com/repos/2m/akka/assignees{/user}","branches_url":"https://api.github.com/repos/2m/akka/branches{/branch}","tags_url":"https://api.github.com/repos/2m/akka/tags","blobs_url":"https://api.github.com/repos/2m/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2m/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2m/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/2m/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2m/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/2m/akka/languages","stargazers_url":"https://api.github.com/repos/2m/akka/stargazers","contributors_url":"https://api.github.com/repos/2m/akka/contributors","subscribers_url":"https://api.github.com/repos/2m/akka/subscribers","subscription_url":"https://api.github.com/repos/2m/akka/subscription","commits_url":"https://api.github.com/repos/2m/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/2m/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/2m/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/2m/akka/issues/comments/{number}","contents_url":"https://api.github.com/repos/2m/akka/contents/{+path}","compare_url":"https://api.github.com/repos/2m/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2m/akka/merges","archive_url":"https://api.github.com/repos/2m/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2m/akka/downloads","issues_url":"https://api.github.com/repos/2m/akka/issues{/number}","pulls_url":"https://api.github.com/repos/2m/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/2m/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/2m/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2m/akka/labels{/name}","releases_url":"https://api.github.com/repos/2m/akka/releases{/id}","created_at":"2014-04-15T09:23:35Z","updated_at":"2014-08-18T08:15:42Z","pushed_at":"2014-11-24T16:30:14Z","git_url":"git://github.com/2m/akka.git","ssh_url":"git@github.com:2m/akka.git","clone_url":"https://github.com/2m/akka.git","svn_url":"https://github.com/2m/akka","homepage":"http://akka.io","size":157442,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:release-2.3-dev","ref":"release-2.3-dev","sha":"abb9e88c6588e4971738ab2d7a6d9f4434dd0ea4","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments/{number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2014-11-26T07:42:52Z","pushed_at":"2014-11-25T23:21:44Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":244766,"stargazers_count":3224,"watchers_count":3224,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":906,"mirror_url":null,"open_issues_count":495,"forks":906,"open_issues":495,"watchers":3224,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/16357"},"html":{"href":"https://github.com/akka/akka/pull/16357"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/16357"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/16357/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/16357/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/16357/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/c02ad1d486edbdd6d8e1a0e86e551391d047a7e4"}}}}