GitHub PushEvent at 2014-12-29 02:28:27
Repository: inbox
Actor: kav-ya
Payload: {"shas":[["c96772cf4932c3bdd75013bba422cafebdbb745c","47de38fbdece0d484472919c37c107cfadb2ad00@inboxapp.com","Ignore ValueError on loading JSON columns with invalid utf-8, instead log and return None.\nAdapt the search indexer code to treat None values correctly.\n\nFixes T692.\n\nSummary:\nPython's native json loads(), dumps() fns. (wrapped by the bson.json_util library\nwe use) differ in how they treat invalid utf-8 - loads() is strict about invalid\nutf-8 whereas dumps() is not. This can result in ValueErrors during decoding\nJSON columns; merely log them for now.\n\nWe also adapt the search indexer code to treat the None values that can\nnow occur due to this change, correctly - we choose not to index objects\nthat could not be decoded rather than index incompletely/ incorrectly.\n\nNote: An alternate, longer-term solution is to convert these problem values\ninto valid values and re-store in the database, but this should fix the\nissue for now.\n\nTest Plan:\nTested on prod - fixes the issue we were seeing on trying to start\nthe search-index-service.\n\nReviewers: emfree\n\nReviewed By: emfree\n\nDifferential Revision: https://review.inboxapp.com/D929","Kavya Joshi",true]],"size":1,"ref":"refs/heads/master","head":"c96772cf4932c3bdd75013bba422cafebdbb745c"}