GitHub PullRequestEvent at 2014-03-04 03:09:25
Repository: phppgadmin
Actor: xzilla
Payload: {"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/phppgadmin/phppgadmin/pulls/10","id":3512004,"html_url":"https://github.com/phppgadmin/phppgadmin/pull/10","diff_url":"https://github.com/phppgadmin/phppgadmin/pull/10.diff","patch_url":"https://github.com/phppgadmin/phppgadmin/pull/10.patch","issue_url":"https://api.github.com/repos/phppgadmin/phppgadmin/issues/10","number":10,"state":"closed","title":"Fix broken buttons if used multiple times","user":{"login":"osteenbergen","id":1105741,"avatar_url":"https://avatars.githubusercontent.com/u/1105741","gravatar_id":"80fa41b9a453273d58d22353379cd9ea","url":"https://api.github.com/users/osteenbergen","html_url":"https://github.com/osteenbergen","followers_url":"https://api.github.com/users/osteenbergen/followers","following_url":"https://api.github.com/users/osteenbergen/following{/other_user}","gists_url":"https://api.github.com/users/osteenbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/osteenbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osteenbergen/subscriptions","organizations_url":"https://api.github.com/users/osteenbergen/orgs","repos_url":"https://api.github.com/users/osteenbergen/repos","events_url":"https://api.github.com/users/osteenbergen/events{/privacy}","received_events_url":"https://api.github.com/users/osteenbergen/received_events","type":"User","site_admin":false},"body":"The bug:\r\n- User browses a table\r\n- Clicks on any 'edit' button\r\n- Clicks on 'Cancel' button\r\n- Clicks on any 'edit' button\r\n- User is unable to edit the row (no edit screen, just the browse screen)\r\n\r\nThe Cause:\r\nThe buttons include the state information in 'urlvars'. This was done via a merge of two arrays, the first with the button information and the second contains the page state variables. Merge will override values in the first array if they are also in the second array.\r\nAlso after the buttons are defined a for-loop merges the urlvars for a second time.","created_at":"2012-12-31T11:50:09Z","updated_at":"2014-03-04T03:09:25Z","closed_at":"2014-03-04T03:09:25Z","merged_at":null,"merge_commit_sha":"da4da8b36e667ee6445792cf2c644aec58e7dda0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phppgadmin/phppgadmin/pulls/10/commits","review_comments_url":"https://api.github.com/repos/phppgadmin/phppgadmin/pulls/10/comments","review_comment_url":"https://api.github.com/repos/phppgadmin/phppgadmin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/phppgadmin/phppgadmin/issues/10/comments","statuses_url":"https://api.github.com/repos/phppgadmin/phppgadmin/statuses/a6da823eadca7b61fedb52261f795e512f0d0683","head":{"label":"osteenbergen:patch-1","ref":"patch-1","sha":"a6da823eadca7b61fedb52261f795e512f0d0683","user":{"login":"osteenbergen","id":1105741,"avatar_url":"https://avatars.githubusercontent.com/u/1105741","gravatar_id":"80fa41b9a453273d58d22353379cd9ea","url":"https://api.github.com/users/osteenbergen","html_url":"https://github.com/osteenbergen","followers_url":"https://api.github.com/users/osteenbergen/followers","following_url":"https://api.github.com/users/osteenbergen/following{/other_user}","gists_url":"https://api.github.com/users/osteenbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/osteenbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osteenbergen/subscriptions","organizations_url":"https://api.github.com/users/osteenbergen/orgs","repos_url":"https://api.github.com/users/osteenbergen/repos","events_url":"https://api.github.com/users/osteenbergen/events{/privacy}","received_events_url":"https://api.github.com/users/osteenbergen/received_events","type":"User","site_admin":false},"repo":{"id":7386459,"name":"phppgadmin","full_name":"osteenbergen/phppgadmin","owner":{"login":"osteenbergen","id":1105741,"avatar_url":"https://avatars.githubusercontent.com/u/1105741","gravatar_id":"80fa41b9a453273d58d22353379cd9ea","url":"https://api.github.com/users/osteenbergen","html_url":"https://github.com/osteenbergen","followers_url":"https://api.github.com/users/osteenbergen/followers","following_url":"https://api.github.com/users/osteenbergen/following{/other_user}","gists_url":"https://api.github.com/users/osteenbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/osteenbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osteenbergen/subscriptions","organizations_url":"https://api.github.com/users/osteenbergen/orgs","repos_url":"https://api.github.com/users/osteenbergen/repos","events_url":"https://api.github.com/users/osteenbergen/events{/privacy}","received_events_url":"https://api.github.com/users/osteenbergen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/osteenbergen/phppgadmin","description":"the premier web-based administration tool for postgresql","fork":true,"url":"https://api.github.com/repos/osteenbergen/phppgadmin","forks_url":"https://api.github.com/repos/osteenbergen/phppgadmin/forks","keys_url":"https://api.github.com/repos/osteenbergen/phppgadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osteenbergen/phppgadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osteenbergen/phppgadmin/teams","hooks_url":"https://api.github.com/repos/osteenbergen/phppgadmin/hooks","issue_events_url":"https://api.github.com/repos/osteenbergen/phppgadmin/issues/events{/number}","events_url":"https://api.github.com/repos/osteenbergen/phppgadmin/events","assignees_url":"https://api.github.com/repos/osteenbergen/phppgadmin/assignees{/user}","branches_url":"https://api.github.com/repos/osteenbergen/phppgadmin/branches{/branch}","tags_url":"https://api.github.com/repos/osteenbergen/phppgadmin/tags","blobs_url":"https://api.github.com/repos/osteenbergen/phppgadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osteenbergen/phppgadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osteenbergen/phppgadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/osteenbergen/phppgadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osteenbergen/phppgadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/osteenbergen/phppgadmin/languages","stargazers_url":"https://api.github.com/repos/osteenbergen/phppgadmin/stargazers","contributors_url":"https://api.github.com/repos/osteenbergen/phppgadmin/contributors","subscribers_url":"https://api.github.com/repos/osteenbergen/phppgadmin/subscribers","subscription_url":"https://api.github.com/repos/osteenbergen/phppgadmin/subscription","commits_url":"https://api.github.com/repos/osteenbergen/phppgadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/osteenbergen/phppgadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/osteenbergen/phppgadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/osteenbergen/phppgadmin/issues/comments/{number}","contents_url":"https://api.github.com/repos/osteenbergen/phppgadmin/contents/{+path}","compare_url":"https://api.github.com/repos/osteenbergen/phppgadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osteenbergen/phppgadmin/merges","archive_url":"https://api.github.com/repos/osteenbergen/phppgadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osteenbergen/phppgadmin/downloads","issues_url":"https://api.github.com/repos/osteenbergen/phppgadmin/issues{/number}","pulls_url":"https://api.github.com/repos/osteenbergen/phppgadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/osteenbergen/phppgadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/osteenbergen/phppgadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osteenbergen/phppgadmin/labels{/name}","releases_url":"https://api.github.com/repos/osteenbergen/phppgadmin/releases{/id}","created_at":"2012-12-31T11:31:22Z","updated_at":"2013-11-11T19:11:59Z","pushed_at":"2012-12-31T11:47:29Z","git_url":"git://github.com/osteenbergen/phppgadmin.git","ssh_url":"git@github.com:osteenbergen/phppgadmin.git","clone_url":"https://github.com/osteenbergen/phppgadmin.git","svn_url":"https://github.com/osteenbergen/phppgadmin","homepage":"http://phppgadmin.sourceforge.net/","size":14931,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"phppgadmin:master","ref":"master","sha":"3f212d646ee7c94efbd2b6b7b7d18450d531e33d","user":{"login":"phppgadmin","id":538340,"avatar_url":"https://avatars.githubusercontent.com/u/538340","gravatar_id":"6d267d38555298fe3229006969db2cce","url":"https://api.github.com/users/phppgadmin","html_url":"https://github.com/phppgadmin","followers_url":"https://api.github.com/users/phppgadmin/followers","following_url":"https://api.github.com/users/phppgadmin/following{/other_user}","gists_url":"https://api.github.com/users/phppgadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/phppgadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phppgadmin/subscriptions","organizations_url":"https://api.github.com/users/phppgadmin/orgs","repos_url":"https://api.github.com/users/phppgadmin/repos","events_url":"https://api.github.com/users/phppgadmin/events{/privacy}","received_events_url":"https://api.github.com/users/phppgadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":1359920,"name":"phppgadmin","full_name":"phppgadmin/phppgadmin","owner":{"login":"phppgadmin","id":538340,"avatar_url":"https://avatars.githubusercontent.com/u/538340","gravatar_id":"6d267d38555298fe3229006969db2cce","url":"https://api.github.com/users/phppgadmin","html_url":"https://github.com/phppgadmin","followers_url":"https://api.github.com/users/phppgadmin/followers","following_url":"https://api.github.com/users/phppgadmin/following{/other_user}","gists_url":"https://api.github.com/users/phppgadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/phppgadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phppgadmin/subscriptions","organizations_url":"https://api.github.com/users/phppgadmin/orgs","repos_url":"https://api.github.com/users/phppgadmin/repos","events_url":"https://api.github.com/users/phppgadmin/events{/privacy}","received_events_url":"https://api.github.com/users/phppgadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phppgadmin/phppgadmin","description":"the premier web-based administration tool for postgresql","fork":true,"url":"https://api.github.com/repos/phppgadmin/phppgadmin","forks_url":"https://api.github.com/repos/phppgadmin/phppgadmin/forks","keys_url":"https://api.github.com/repos/phppgadmin/phppgadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phppgadmin/phppgadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phppgadmin/phppgadmin/teams","hooks_url":"https://api.github.com/repos/phppgadmin/phppgadmin/hooks","issue_events_url":"https://api.github.com/repos/phppgadmin/phppgadmin/issues/events{/number}","events_url":"https://api.github.com/repos/phppgadmin/phppgadmin/events","assignees_url":"https://api.github.com/repos/phppgadmin/phppgadmin/assignees{/user}","branches_url":"https://api.github.com/repos/phppgadmin/phppgadmin/branches{/branch}","tags_url":"https://api.github.com/repos/phppgadmin/phppgadmin/tags","blobs_url":"https://api.github.com/repos/phppgadmin/phppgadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phppgadmin/phppgadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phppgadmin/phppgadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/phppgadmin/phppgadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phppgadmin/phppgadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/phppgadmin/phppgadmin/languages","stargazers_url":"https://api.github.com/repos/phppgadmin/phppgadmin/stargazers","contributors_url":"https://api.github.com/repos/phppgadmin/phppgadmin/contributors","subscribers_url":"https://api.github.com/repos/phppgadmin/phppgadmin/subscribers","subscription_url":"https://api.github.com/repos/phppgadmin/phppgadmin/subscription","commits_url":"https://api.github.com/repos/phppgadmin/phppgadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/phppgadmin/phppgadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/phppgadmin/phppgadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/phppgadmin/phppgadmin/issues/comments/{number}","contents_url":"https://api.github.com/repos/phppgadmin/phppgadmin/contents/{+path}","compare_url":"https://api.github.com/repos/phppgadmin/phppgadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phppgadmin/phppgadmin/merges","archive_url":"https://api.github.com/repos/phppgadmin/phppgadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phppgadmin/phppgadmin/downloads","issues_url":"https://api.github.com/repos/phppgadmin/phppgadmin/issues{/number}","pulls_url":"https://api.github.com/repos/phppgadmin/phppgadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/phppgadmin/phppgadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/phppgadmin/phppgadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phppgadmin/phppgadmin/labels{/name}","releases_url":"https://api.github.com/repos/phppgadmin/phppgadmin/releases{/id}","created_at":"2011-02-12T21:22:31Z","updated_at":"2014-03-04T02:53:36Z","pushed_at":"2014-03-04T02:53:37Z","git_url":"git://github.com/phppgadmin/phppgadmin.git","ssh_url":"git@github.com:phppgadmin/phppgadmin.git","clone_url":"https://github.com/phppgadmin/phppgadmin.git","svn_url":"https://github.com/phppgadmin/phppgadmin","homepage":"http://phppgadmin.sourceforge.net/","size":16291,"stargazers_count":59,"watchers_count":59,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":26,"mirror_url":null,"open_issues_count":2,"forks":26,"open_issues":2,"watchers":59,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phppgadmin/phppgadmin/pulls/10"},"html":{"href":"https://github.com/phppgadmin/phppgadmin/pull/10"},"issue":{"href":"https://api.github.com/repos/phppgadmin/phppgadmin/issues/10"},"comments":{"href":"https://api.github.com/repos/phppgadmin/phppgadmin/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/phppgadmin/phppgadmin/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/phppgadmin/phppgadmin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/phppgadmin/phppgadmin/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/phppgadmin/phppgadmin/statuses/a6da823eadca7b61fedb52261f795e512f0d0683"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":16,"deletions":17,"changed_files":1}}