GitHub PullRequestReviewCommentEvent at 2014-07-03 08:57:33
Repository: xbmc
Actor: Montellese
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jmarshallnz/xbmc/pulls/comments/14503367","id":14503367,"diff_hunk":"@@ -74,8 +74,29 @@ foreach(binding ${bindings})\n   file(COPY ${XBMCROOT}/${header} DESTINATION ${XBMC_INCLUDE_DIR})\n endforeach()\n \n+# parse version.txt to get the version info\n+if (EXISTS \"${XBMCROOT}/version.txt\")\n+  file(STRINGS \"${XBMCROOT}/version.txt\" versions)\n+  foreach (version ${versions})\n+    string(REGEX MATCH \"^[^ ]+\" version_name ${version})\n+    string(REPLACE \"${version_name} \" \"\" version_value ${version})\n+    set(APP_${version_name} \"${version_value}\")\n+    message(\"APP_${version_name}: ${APP_${version_name}} (${version_value})\")\n+  endforeach()\n+endif()\n+\n+# set dummy default values for APP_VERSION_MAJOR/MINOR if not defined\n+if (NOT DEFINED APP_VERSION_MAJOR)\n+  set(APP_VERSION_MAJOR \"??\")","path":"project/cmake/addons/CMakeLists.txt","position":17,"original_position":17,"commit_id":"fb8d7c852f62451734d2c594d412952704899283","original_commit_id":"fb8d7c852f62451734d2c594d412952704899283","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?","gravatar_id":"4d6e5dc659667cacb0405ee88515e687","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"body":"Should we abort if APP_VERSION_MAJOR and/or APP_VERSION_MINOR don't exist? If not there might be a saner default value. I just added these but they aren't really used on win32 anyway so I wasn't sure what a sane default value would be.","created_at":"2014-07-03T08:57:33Z","updated_at":"2014-07-03T08:57:33Z","html_url":"https://github.com/jmarshallnz/xbmc/pull/18#discussion_r14503367","pull_request_url":"https://api.github.com/repos/jmarshallnz/xbmc/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/jmarshallnz/xbmc/pulls/comments/14503367"},"html":{"href":"https://github.com/jmarshallnz/xbmc/pull/18#discussion_r14503367"},"pull_request":{"href":"https://api.github.com/repos/jmarshallnz/xbmc/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/jmarshallnz/xbmc/pulls/18","id":17929284,"html_url":"https://github.com/jmarshallnz/xbmc/pull/18","diff_url":"https://github.com/jmarshallnz/xbmc/pull/18.diff","patch_url":"https://github.com/jmarshallnz/xbmc/pull/18.patch","issue_url":"https://api.github.com/repos/jmarshallnz/xbmc/issues/18","number":18,"state":"open","title":"cleanup and minor fixes","user":{"login":"wsnipex","id":909455,"avatar_url":"https://avatars.githubusercontent.com/u/909455?","gravatar_id":"5bed488f66f4834fbae3955e1c4ebe4d","url":"https://api.github.com/users/wsnipex","html_url":"https://github.com/wsnipex","followers_url":"https://api.github.com/users/wsnipex/followers","following_url":"https://api.github.com/users/wsnipex/following{/other_user}","gists_url":"https://api.github.com/users/wsnipex/gists{/gist_id}","starred_url":"https://api.github.com/users/wsnipex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsnipex/subscriptions","organizations_url":"https://api.github.com/users/wsnipex/orgs","repos_url":"https://api.github.com/users/wsnipex/repos","events_url":"https://api.github.com/users/wsnipex/events{/privacy}","received_events_url":"https://api.github.com/users/wsnipex/received_events","type":"User","site_admin":false},"body":"cleanup configure, fix xbmc-addon-bindings version parsing and make addons build on linux with cmake.\r\nPREFIX stuff is not touched here.\r\n@Montellese ping","created_at":"2014-07-03T07:24:10Z","updated_at":"2014-07-03T08:57:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d8cd119daedf1f5ae052b274813fac4fa6519e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmarshallnz/xbmc/pulls/18/commits","review_comments_url":"https://api.github.com/repos/jmarshallnz/xbmc/pulls/18/comments","review_comment_url":"https://api.github.com/repos/jmarshallnz/xbmc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jmarshallnz/xbmc/issues/18/comments","statuses_url":"https://api.github.com/repos/jmarshallnz/xbmc/statuses/fb8d7c852f62451734d2c594d412952704899283","head":{"label":"wsnipex:audio_encoders_newapi","ref":"audio_encoders_newapi","sha":"fb8d7c852f62451734d2c594d412952704899283","user":{"login":"wsnipex","id":909455,"avatar_url":"https://avatars.githubusercontent.com/u/909455?","gravatar_id":"5bed488f66f4834fbae3955e1c4ebe4d","url":"https://api.github.com/users/wsnipex","html_url":"https://github.com/wsnipex","followers_url":"https://api.github.com/users/wsnipex/followers","following_url":"https://api.github.com/users/wsnipex/following{/other_user}","gists_url":"https://api.github.com/users/wsnipex/gists{/gist_id}","starred_url":"https://api.github.com/users/wsnipex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsnipex/subscriptions","organizations_url":"https://api.github.com/users/wsnipex/orgs","repos_url":"https://api.github.com/users/wsnipex/repos","events_url":"https://api.github.com/users/wsnipex/events{/privacy}","received_events_url":"https://api.github.com/users/wsnipex/received_events","type":"User","site_admin":false},"repo":{"id":5497511,"name":"xbmc","full_name":"wsnipex/xbmc","owner":{"login":"wsnipex","id":909455,"avatar_url":"https://avatars.githubusercontent.com/u/909455?","gravatar_id":"5bed488f66f4834fbae3955e1c4ebe4d","url":"https://api.github.com/users/wsnipex","html_url":"https://github.com/wsnipex","followers_url":"https://api.github.com/users/wsnipex/followers","following_url":"https://api.github.com/users/wsnipex/following{/other_user}","gists_url":"https://api.github.com/users/wsnipex/gists{/gist_id}","starred_url":"https://api.github.com/users/wsnipex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsnipex/subscriptions","organizations_url":"https://api.github.com/users/wsnipex/orgs","repos_url":"https://api.github.com/users/wsnipex/repos","events_url":"https://api.github.com/users/wsnipex/events{/privacy}","received_events_url":"https://api.github.com/users/wsnipex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wsnipex/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/wsnipex/xbmc","forks_url":"https://api.github.com/repos/wsnipex/xbmc/forks","keys_url":"https://api.github.com/repos/wsnipex/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wsnipex/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wsnipex/xbmc/teams","hooks_url":"https://api.github.com/repos/wsnipex/xbmc/hooks","issue_events_url":"https://api.github.com/repos/wsnipex/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/wsnipex/xbmc/events","assignees_url":"https://api.github.com/repos/wsnipex/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/wsnipex/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/wsnipex/xbmc/tags","blobs_url":"https://api.github.com/repos/wsnipex/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wsnipex/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wsnipex/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/wsnipex/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wsnipex/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/wsnipex/xbmc/languages","stargazers_url":"https://api.github.com/repos/wsnipex/xbmc/stargazers","contributors_url":"https://api.github.com/repos/wsnipex/xbmc/contributors","subscribers_url":"https://api.github.com/repos/wsnipex/xbmc/subscribers","subscription_url":"https://api.github.com/repos/wsnipex/xbmc/subscription","commits_url":"https://api.github.com/repos/wsnipex/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/wsnipex/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/wsnipex/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/wsnipex/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/wsnipex/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/wsnipex/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wsnipex/xbmc/merges","archive_url":"https://api.github.com/repos/wsnipex/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wsnipex/xbmc/downloads","issues_url":"https://api.github.com/repos/wsnipex/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/wsnipex/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/wsnipex/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/wsnipex/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wsnipex/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/wsnipex/xbmc/releases{/id}","created_at":"2012-08-21T16:09:47Z","updated_at":"2014-06-24T07:31:37Z","pushed_at":"2014-07-03T08:55:41Z","git_url":"git://github.com/wsnipex/xbmc.git","ssh_url":"git@github.com:wsnipex/xbmc.git","clone_url":"https://github.com/wsnipex/xbmc.git","svn_url":"https://github.com/wsnipex/xbmc","homepage":"http://xbmc.org","size":462935,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmarshallnz:audio_encoders_newapi","ref":"audio_encoders_newapi","sha":"5fef1e5334c0b3c78582814eb0cf6d7519b63f41","user":{"login":"jmarshallnz","id":406571,"avatar_url":"https://avatars.githubusercontent.com/u/406571?","gravatar_id":"f2f465d1d46f3f4436a7658f9817fa95","url":"https://api.github.com/users/jmarshallnz","html_url":"https://github.com/jmarshallnz","followers_url":"https://api.github.com/users/jmarshallnz/followers","following_url":"https://api.github.com/users/jmarshallnz/following{/other_user}","gists_url":"https://api.github.com/users/jmarshallnz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarshallnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarshallnz/subscriptions","organizations_url":"https://api.github.com/users/jmarshallnz/orgs","repos_url":"https://api.github.com/users/jmarshallnz/repos","events_url":"https://api.github.com/users/jmarshallnz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarshallnz/received_events","type":"User","site_admin":false},"repo":{"id":1286966,"name":"xbmc","full_name":"jmarshallnz/xbmc","owner":{"login":"jmarshallnz","id":406571,"avatar_url":"https://avatars.githubusercontent.com/u/406571?","gravatar_id":"f2f465d1d46f3f4436a7658f9817fa95","url":"https://api.github.com/users/jmarshallnz","html_url":"https://github.com/jmarshallnz","followers_url":"https://api.github.com/users/jmarshallnz/followers","following_url":"https://api.github.com/users/jmarshallnz/following{/other_user}","gists_url":"https://api.github.com/users/jmarshallnz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarshallnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarshallnz/subscriptions","organizations_url":"https://api.github.com/users/jmarshallnz/orgs","repos_url":"https://api.github.com/users/jmarshallnz/repos","events_url":"https://api.github.com/users/jmarshallnz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarshallnz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmarshallnz/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/jmarshallnz/xbmc","forks_url":"https://api.github.com/repos/jmarshallnz/xbmc/forks","keys_url":"https://api.github.com/repos/jmarshallnz/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmarshallnz/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmarshallnz/xbmc/teams","hooks_url":"https://api.github.com/repos/jmarshallnz/xbmc/hooks","issue_events_url":"https://api.github.com/repos/jmarshallnz/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/jmarshallnz/xbmc/events","assignees_url":"https://api.github.com/repos/jmarshallnz/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/jmarshallnz/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/jmarshallnz/xbmc/tags","blobs_url":"https://api.github.com/repos/jmarshallnz/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmarshallnz/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmarshallnz/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmarshallnz/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmarshallnz/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/jmarshallnz/xbmc/languages","stargazers_url":"https://api.github.com/repos/jmarshallnz/xbmc/stargazers","contributors_url":"https://api.github.com/repos/jmarshallnz/xbmc/contributors","subscribers_url":"https://api.github.com/repos/jmarshallnz/xbmc/subscribers","subscription_url":"https://api.github.com/repos/jmarshallnz/xbmc/subscription","commits_url":"https://api.github.com/repos/jmarshallnz/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmarshallnz/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmarshallnz/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmarshallnz/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmarshallnz/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/jmarshallnz/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmarshallnz/xbmc/merges","archive_url":"https://api.github.com/repos/jmarshallnz/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmarshallnz/xbmc/downloads","issues_url":"https://api.github.com/repos/jmarshallnz/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/jmarshallnz/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/jmarshallnz/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/jmarshallnz/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmarshallnz/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/jmarshallnz/xbmc/releases{/id}","created_at":"2011-01-24T08:05:39Z","updated_at":"2014-06-21T22:00:50Z","pushed_at":"2014-07-03T07:25:46Z","git_url":"git://github.com/jmarshallnz/xbmc.git","ssh_url":"git@github.com:jmarshallnz/xbmc.git","clone_url":"https://github.com/jmarshallnz/xbmc.git","svn_url":"https://github.com/jmarshallnz/xbmc","homepage":"http://xbmc.org","size":474517,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmarshallnz/xbmc/pulls/18"},"html":{"href":"https://github.com/jmarshallnz/xbmc/pull/18"},"issue":{"href":"https://api.github.com/repos/jmarshallnz/xbmc/issues/18"},"comments":{"href":"https://api.github.com/repos/jmarshallnz/xbmc/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/jmarshallnz/xbmc/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/jmarshallnz/xbmc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jmarshallnz/xbmc/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/jmarshallnz/xbmc/statuses/fb8d7c852f62451734d2c594d412952704899283"}}}}