GitHub PullRequestReviewCommentEvent at 2014-12-24 16:22:28
Repository: gaia
Actor: julienw
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/22259345","id":22259345,"diff_hunk":"@@ -220,8 +220,7 @@ var ActivityHandler = {\n       return;\n     }\n \n-    var request = navigator.mozMobileMessage.getMessage(message.id);\n-    request.onsuccess = function onsuccess() {\n+    MessageManager.getMessage(message.id).then((message) => {","path":"apps/sms/js/activity_handler.js","position":6,"original_position":6,"commit_id":"c68ed868023c898ddfcb650c68ec09172b1d5811","original_commit_id":"c68ed868023c898ddfcb650c68ec09172b1d5811","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"This adds a dependency on MessageManager very early here, I don't know if that's something we want, especially that getMessage is just a wrapper on top of mozMobileMessage.getMessage (which is also returning a \"then\" nowadays).\r\n\r\nThat said that would make it easier to adapt for v2.1 in case a partner asks for it.\r\n\r\nI don't really mind right now, especially that activity handling is not the main use case we're concerned about performance-wise.","created_at":"2014-12-24T16:22:28Z","updated_at":"2014-12-24T16:22:28Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/26919#discussion_r22259345","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26919","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/22259345"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/26919#discussion_r22259345"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26919"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26919","id":26390538,"html_url":"https://github.com/mozilla-b2g/gaia/pull/26919","diff_url":"https://github.com/mozilla-b2g/gaia/pull/26919.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/26919.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26919","number":26919,"state":"open","locked":false,"title":" Bug 1112135 - [Messages] When starting as an activity/notification/, delay threads rendering until the right panel is open. r=julien","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-19T18:43:37Z","updated_at":"2014-12-24T16:22:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31cbc348fd7960ff85cb3790c65bc3b958c9f374","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26919/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26919/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26919/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/c68ed868023c898ddfcb650c68ec09172b1d5811","head":{"label":"azasypkin:bug-1112135-delay-thread-rendering","ref":"bug-1112135-delay-thread-rendering","sha":"c68ed868023c898ddfcb650c68ec09172b1d5811","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"repo":{"id":17702910,"name":"gaia","full_name":"azasypkin/gaia","owner":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/azasypkin/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/azasypkin/gaia","forks_url":"https://api.github.com/repos/azasypkin/gaia/forks","keys_url":"https://api.github.com/repos/azasypkin/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azasypkin/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azasypkin/gaia/teams","hooks_url":"https://api.github.com/repos/azasypkin/gaia/hooks","issue_events_url":"https://api.github.com/repos/azasypkin/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/azasypkin/gaia/events","assignees_url":"https://api.github.com/repos/azasypkin/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/azasypkin/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/azasypkin/gaia/tags","blobs_url":"https://api.github.com/repos/azasypkin/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azasypkin/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azasypkin/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/azasypkin/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azasypkin/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/azasypkin/gaia/languages","stargazers_url":"https://api.github.com/repos/azasypkin/gaia/stargazers","contributors_url":"https://api.github.com/repos/azasypkin/gaia/contributors","subscribers_url":"https://api.github.com/repos/azasypkin/gaia/subscribers","subscription_url":"https://api.github.com/repos/azasypkin/gaia/subscription","commits_url":"https://api.github.com/repos/azasypkin/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/azasypkin/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/azasypkin/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/azasypkin/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/azasypkin/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/azasypkin/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azasypkin/gaia/merges","archive_url":"https://api.github.com/repos/azasypkin/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azasypkin/gaia/downloads","issues_url":"https://api.github.com/repos/azasypkin/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/azasypkin/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/azasypkin/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/azasypkin/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azasypkin/gaia/labels{/name}","releases_url":"https://api.github.com/repos/azasypkin/gaia/releases{/id}","created_at":"2014-03-13T08:22:23Z","updated_at":"2014-12-22T08:52:18Z","pushed_at":"2014-12-23T21:45:58Z","git_url":"git://github.com/azasypkin/gaia.git","ssh_url":"git@github.com:azasypkin/gaia.git","clone_url":"https://github.com/azasypkin/gaia.git","svn_url":"https://github.com/azasypkin/gaia","homepage":"https://wiki.mozilla.org/B2G","size":874898,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"cb1dad4881533bff9f06d47e34983c7b10c04a8c","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-12-24T13:36:13Z","pushed_at":"2014-12-24T13:36:13Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1355706,"stargazers_count":1830,"watchers_count":1830,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2129,"mirror_url":null,"open_issues_count":756,"forks":2129,"open_issues":756,"watchers":1830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26919"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/26919"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26919"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26919/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26919/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26919/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/c68ed868023c898ddfcb650c68ec09172b1d5811"}}}}