GitHub PullRequestReviewCommentEvent at 2014-08-06 21:41:54
Repository: backbone.marionette
Actor: jfairbank
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/15905658","id":15905658,"diff_hunk":"@@ -62,6 +62,13 @@\n   function iterateEvents(target, entity, bindings, functionCallback, stringCallback) {\n     if (!entity || !bindings) { return; }\n \n+    // type-check bindings\n+    if (!_.isFunction(bindings) && !_.isObject(bindings)) {\n+      throwError('Bindings must be an object or function. Please refer to ' +\n+        'http://marionettejs.com/docs/current/marionette.functions.html' +","path":"src/marionette.bindEntityEvents.js","position":7,"original_position":7,"commit_id":"d0015dfa292f5b4fe17f61d96ff84ebea0a86bc6","original_commit_id":"d0015dfa292f5b4fe17f61d96ff84ebea0a86bc6","user":{"login":"jfairbank","id":195580,"avatar_url":"https://avatars.githubusercontent.com/u/195580?v=2","gravatar_id":"94bd558238b69c45d3d3e15797ae94f7","url":"https://api.github.com/users/jfairbank","html_url":"https://github.com/jfairbank","followers_url":"https://api.github.com/users/jfairbank/followers","following_url":"https://api.github.com/users/jfairbank/following{/other_user}","gists_url":"https://api.github.com/users/jfairbank/gists{/gist_id}","starred_url":"https://api.github.com/users/jfairbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfairbank/subscriptions","organizations_url":"https://api.github.com/users/jfairbank/orgs","repos_url":"https://api.github.com/users/jfairbank/repos","events_url":"https://api.github.com/users/jfairbank/events{/privacy}","received_events_url":"https://api.github.com/users/jfairbank/received_events","type":"User","site_admin":false},"body":"I like that idea if the build does insert it.  Would it insert it into the spec too?","created_at":"2014-08-06T21:41:54Z","updated_at":"2014-08-06T21:41:54Z","html_url":"https://github.com/marionettejs/backbone.marionette/pull/1680#discussion_r15905658","pull_request_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/1680","_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/15905658"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/1680#discussion_r15905658"},"pull_request":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/1680"}}},"pull_request":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/1680","id":18634454,"html_url":"https://github.com/marionettejs/backbone.marionette/pull/1680","diff_url":"https://github.com/marionettejs/backbone.marionette/pull/1680.diff","patch_url":"https://github.com/marionettejs/backbone.marionette/pull/1680.patch","issue_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/1680","number":1680,"state":"open","title":"Throw an error when bindings aren't an obj or func","user":{"login":"sarenji","id":167743,"avatar_url":"https://avatars.githubusercontent.com/u/167743?v=2","gravatar_id":"7d378db2f99b9c09f241125fb4829ecf","url":"https://api.github.com/users/sarenji","html_url":"https://github.com/sarenji","followers_url":"https://api.github.com/users/sarenji/followers","following_url":"https://api.github.com/users/sarenji/following{/other_user}","gists_url":"https://api.github.com/users/sarenji/gists{/gist_id}","starred_url":"https://api.github.com/users/sarenji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarenji/subscriptions","organizations_url":"https://api.github.com/users/sarenji/orgs","repos_url":"https://api.github.com/users/sarenji/repos","events_url":"https://api.github.com/users/sarenji/events{/privacy}","received_events_url":"https://api.github.com/users/sarenji/received_events","type":"User","site_admin":false},"body":"My attempt at solving issue #1679. Let me know if this has any problems!","created_at":"2014-07-20T22:46:50Z","updated_at":"2014-08-06T21:41:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a22185b261f1e15589f1f6a26b707faeae763cf4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/1680/commits","review_comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/1680/comments","review_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/{number}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/1680/comments","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/d0015dfa292f5b4fe17f61d96ff84ebea0a86bc6","head":{"label":"sarenji:minor","ref":"minor","sha":"d0015dfa292f5b4fe17f61d96ff84ebea0a86bc6","user":{"login":"sarenji","id":167743,"avatar_url":"https://avatars.githubusercontent.com/u/167743?v=2","gravatar_id":"7d378db2f99b9c09f241125fb4829ecf","url":"https://api.github.com/users/sarenji","html_url":"https://github.com/sarenji","followers_url":"https://api.github.com/users/sarenji/followers","following_url":"https://api.github.com/users/sarenji/following{/other_user}","gists_url":"https://api.github.com/users/sarenji/gists{/gist_id}","starred_url":"https://api.github.com/users/sarenji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarenji/subscriptions","organizations_url":"https://api.github.com/users/sarenji/orgs","repos_url":"https://api.github.com/users/sarenji/repos","events_url":"https://api.github.com/users/sarenji/events{/privacy}","received_events_url":"https://api.github.com/users/sarenji/received_events","type":"User","site_admin":false},"repo":{"id":22045128,"name":"backbone.marionette","full_name":"sarenji/backbone.marionette","owner":{"login":"sarenji","id":167743,"avatar_url":"https://avatars.githubusercontent.com/u/167743?v=2","gravatar_id":"7d378db2f99b9c09f241125fb4829ecf","url":"https://api.github.com/users/sarenji","html_url":"https://github.com/sarenji","followers_url":"https://api.github.com/users/sarenji/followers","following_url":"https://api.github.com/users/sarenji/following{/other_user}","gists_url":"https://api.github.com/users/sarenji/gists{/gist_id}","starred_url":"https://api.github.com/users/sarenji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarenji/subscriptions","organizations_url":"https://api.github.com/users/sarenji/orgs","repos_url":"https://api.github.com/users/sarenji/repos","events_url":"https://api.github.com/users/sarenji/events{/privacy}","received_events_url":"https://api.github.com/users/sarenji/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarenji/backbone.marionette","description":"Make your Backbone.js applications dance!","fork":true,"url":"https://api.github.com/repos/sarenji/backbone.marionette","forks_url":"https://api.github.com/repos/sarenji/backbone.marionette/forks","keys_url":"https://api.github.com/repos/sarenji/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarenji/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarenji/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/sarenji/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/sarenji/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/sarenji/backbone.marionette/events","assignees_url":"https://api.github.com/repos/sarenji/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/sarenji/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/sarenji/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/sarenji/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarenji/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarenji/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarenji/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarenji/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/sarenji/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/sarenji/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/sarenji/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/sarenji/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/sarenji/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/sarenji/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarenji/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarenji/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarenji/backbone.marionette/issues/comments/{number}","contents_url":"https://api.github.com/repos/sarenji/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/sarenji/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarenji/backbone.marionette/merges","archive_url":"https://api.github.com/repos/sarenji/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarenji/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/sarenji/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/sarenji/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/sarenji/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/sarenji/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarenji/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/sarenji/backbone.marionette/releases{/id}","created_at":"2014-07-20T22:39:04Z","updated_at":"2014-07-20T22:39:46Z","pushed_at":"2014-08-06T00:11:26Z","git_url":"git://github.com/sarenji/backbone.marionette.git","ssh_url":"git@github.com:sarenji/backbone.marionette.git","clone_url":"https://github.com/sarenji/backbone.marionette.git","svn_url":"https://github.com/sarenji/backbone.marionette","homepage":"http://marionettejs.com","size":8784,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"marionettejs:minor","ref":"minor","sha":"61447c4742953e5ed8ee1a2de996b864158ec73a","user":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=2","gravatar_id":"eaafc91086a3bab1c84014247bb008a0","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"repo":{"id":2965621,"name":"backbone.marionette","full_name":"marionettejs/backbone.marionette","owner":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=2","gravatar_id":"eaafc91086a3bab1c84014247bb008a0","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marionettejs/backbone.marionette","description":"Make your Backbone.js applications dance!","fork":false,"url":"https://api.github.com/repos/marionettejs/backbone.marionette","forks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/forks","keys_url":"https://api.github.com/repos/marionettejs/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marionettejs/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marionettejs/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/events","assignees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/marionettejs/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/marionettejs/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/comments/{number}","contents_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/marionettejs/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marionettejs/backbone.marionette/merges","archive_url":"https://api.github.com/repos/marionettejs/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marionettejs/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/marionettejs/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/marionettejs/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marionettejs/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/marionettejs/backbone.marionette/releases{/id}","created_at":"2011-12-12T16:36:09Z","updated_at":"2014-08-06T20:14:34Z","pushed_at":"2014-08-06T14:58:32Z","git_url":"git://github.com/marionettejs/backbone.marionette.git","ssh_url":"git@github.com:marionettejs/backbone.marionette.git","clone_url":"https://github.com/marionettejs/backbone.marionette.git","svn_url":"https://github.com/marionettejs/backbone.marionette","homepage":"http://marionettejs.com","size":29937,"stargazers_count":5250,"watchers_count":5250,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":983,"mirror_url":null,"open_issues_count":94,"forks":983,"open_issues":94,"watchers":5250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/1680"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/1680"},"issue":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/1680"},"comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/1680/comments"},"review_comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/1680/comments"},"review_comment":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/1680/commits"},"statuses":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/d0015dfa292f5b4fe17f61d96ff84ebea0a86bc6"}}}}