GitHub PullRequestReviewCommentEvent at 2014-02-12 02:16:15
Repository: requests
Actor: sigmavirus24
Payload: {"comment":{"url":"https://api.github.com/repos/kennethreitz/requests/pulls/comments/9653534","id":9653534,"diff_hunk":"@@ -275,6 +286,9 @@ def __init__(self):\n         self.body = None\n         #: dictionary of callback hooks, for internal usage.\n         self.hooks = default_hooks()\n+        # A dictionary of arguments to the protocol adapter will be stored here\n+        # after Session.send() is called.\n+        self._send_params = {}","path":"requests/models.py","position":24,"original_position":24,"commit_id":"8456164c4ac23284e819c89d40fc84ce80040432","original_commit_id":"e83225bf2083f9d91b481a3fc88be1840d5d22b0","user":{"login":"sigmavirus24","id":240830,"avatar_url":"https://gravatar.com/avatar/c148356d89f925e692178bee1d93acf7?d=https%3A%2F%2Fidenticons.github.com%2F4a71764034cdae877484be72718ba526.png&r=x","gravatar_id":"c148356d89f925e692178bee1d93acf7","url":"https://api.github.com/users/sigmavirus24","html_url":"https://github.com/sigmavirus24","followers_url":"https://api.github.com/users/sigmavirus24/followers","following_url":"https://api.github.com/users/sigmavirus24/following{/other_user}","gists_url":"https://api.github.com/users/sigmavirus24/gists{/gist_id}","starred_url":"https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigmavirus24/subscriptions","organizations_url":"https://api.github.com/users/sigmavirus24/orgs","repos_url":"https://api.github.com/users/sigmavirus24/repos","events_url":"https://api.github.com/users/sigmavirus24/events{/privacy}","received_events_url":"https://api.github.com/users/sigmavirus24/received_events","type":"User","site_admin":false},"body":"I'm not advocating this at all, but it would make more sense for us to create an AdapterSettings object that gets passed around rather than trying to attach it to an object. The connection settings are just that, settings on the connection and the socket opened. They are not request parameters or the URL. Those specifically relate to the request, the connection settings (whether to verify the SSL cert, whether to stream, etc.) are related to either creating or handling the connection. Perhaps if that isn't clear then I can draw a diagram and upload it to try to explain it better (or if you have a better suggestion as to how to make this clearer to you).","created_at":"2014-02-12T02:16:15Z","updated_at":"2014-02-12T02:16:15Z","html_url":"https://github.com/kennethreitz/requests/pull/1913#discussion_r9653534","pull_request_url":"https://api.github.com/repos/kennethreitz/requests/pulls/1913","_links":{"self":{"href":"https://api.github.com/repos/kennethreitz/requests/pulls/comments/9653534"},"html":{"href":"https://github.com/kennethreitz/requests/pull/1913#discussion_r9653534"},"pull_request":{"href":"https://api.github.com/repos/kennethreitz/requests/pulls/1913"}}}}