GitHub PullRequestReviewCommentEvent at 2014-01-23 15:02:28
Repository: scala-ide
Actor: dragos
Payload: {"comment":{"url":"https://api.github.com/repos/scala-ide/scala-ide/pulls/comments/9114950","id":9114950,"diff_hunk":"@@ -50,7 +60,7 @@ trait SuperTypeSupport {\n   type TypeName\n   type Parameters\n \n-  type SuperType = Triple[PackageName, TypeName, Parameters]\n+  case class SuperType(packageName: PackageName, typeName: TypeName, params: Parameters)","path":"org.scala-ide.sdt.core/src/scala/tools/eclipse/wizards/support.scala","position":41,"original_position":41,"commit_id":"94c6461624c9fca75cf482265dfdf76ad4735d39","original_commit_id":"94c6461624c9fca75cf482265dfdf76ad4735d39","user":{"login":"dragos","id":133742,"avatar_url":"https://gravatar.com/avatar/fbd384e9626d28d1648f023a5e22672f?d=https%3A%2F%2Fidenticons.github.com%2F6b660454242c937e501b88fd136132f8.png&r=x","gravatar_id":"fbd384e9626d28d1648f023a5e22672f","url":"https://api.github.com/users/dragos","html_url":"https://github.com/dragos","followers_url":"https://api.github.com/users/dragos/followers","following_url":"https://api.github.com/users/dragos/following{/other_user}","gists_url":"https://api.github.com/users/dragos/gists{/gist_id}","starred_url":"https://api.github.com/users/dragos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragos/subscriptions","organizations_url":"https://api.github.com/users/dragos/orgs","repos_url":"https://api.github.com/users/dragos/repos","events_url":"https://api.github.com/users/dragos/events{/privacy}","received_events_url":"https://api.github.com/users/dragos/received_events","type":"User","site_admin":false},"body":"In this case I find a case class is more idiomatic Scala than adding public fields. I don't think there's much gain in rewriting it.","created_at":"2014-01-23T15:02:28Z","updated_at":"2014-01-23T15:02:28Z","html_url":"https://github.com/scala-ide/scala-ide/pull/630#discussion_r9114950","pull_request_url":"https://api.github.com/repos/scala-ide/scala-ide/pulls/630","_links":{"self":{"href":"https://api.github.com/repos/scala-ide/scala-ide/pulls/comments/9114950"},"html":{"href":"https://github.com/scala-ide/scala-ide/pull/630#discussion_r9114950"},"pull_request":{"href":"https://api.github.com/repos/scala-ide/scala-ide/pulls/630"}}}}