GitHub PullRequestReviewCommentEvent at 2014-04-10 18:21:05
Repository: cesium
Actor: shunter
Payload: {"comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/11498848","id":11498848,"diff_hunk":"@@ -296,9 +313,11 @@ Either specify options.imageryProvider instead or set options.baseLayerPicker to\n         //BaseLayerPicker\n         var baseLayerPicker;\n         if (createBaseLayerPicker) {\n-            var providerViewModels = defaultValue(options.imageryProviderViewModels, createDefaultBaseLayers());\n-            baseLayerPicker = new BaseLayerPicker(toolbar, cesiumWidget.centralBody.imageryLayers, providerViewModels);\n-            baseLayerPicker.viewModel.selectedItem = defaultValue(options.selectedImageryProviderViewModel, providerViewModels[0]);\n+            var imageryProviderViewModels = defaultValue(options.imageryProviderViewModels, createDefaultImageryProviderViewModels());\n+            var terrainProviderViewModels = defaultValue(options.terrainProviderViewModels, createDefaultTerrainProviderViewModels());\n+            baseLayerPicker = new BaseLayerPicker(toolbar, cesiumWidget.centralBody, imageryProviderViewModels, terrainProviderViewModels);","path":"Source/Widgets/Viewer/Viewer.js","position":79,"original_position":79,"commit_id":"f26c88f6cca4188921a7dbec3e7f41807db16237","original_commit_id":"f26c88f6cca4188921a7dbec3e7f41807db16237","user":{"login":"shunter","id":32828,"avatar_url":"https://avatars.githubusercontent.com/u/32828?","gravatar_id":"1b815e2898bb8a901365475077eb575b","url":"https://api.github.com/users/shunter","html_url":"https://github.com/shunter","followers_url":"https://api.github.com/users/shunter/followers","following_url":"https://api.github.com/users/shunter/following{/other_user}","gists_url":"https://api.github.com/users/shunter/gists{/gist_id}","starred_url":"https://api.github.com/users/shunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shunter/subscriptions","organizations_url":"https://api.github.com/users/shunter/orgs","repos_url":"https://api.github.com/users/shunter/repos","events_url":"https://api.github.com/users/shunter/events{/privacy}","received_events_url":"https://api.github.com/users/shunter/received_events","type":"User","site_admin":false},"body":"Should we add a constructor parameter to allow setting the selected providers at construction time, rather than afterwards?","created_at":"2014-04-10T18:21:05Z","updated_at":"2014-04-10T18:21:05Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/1607#discussion_r11498848","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/1607","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/11498848"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/1607#discussion_r11498848"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/1607"}}}}