GitHub PullRequestReviewCommentEvent at 2014-11-22 17:31:28
Repository: druntime
Actor: rainers
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/comments/20758493","id":20758493,"diff_hunk":"@@ -0,0 +1,1759 @@\n+/**\n+ * Written in the D programming language.\n+ * This module provides an back-end implementation of associative array\n+ *\n+ * Copyright: Copyright Igor Stepanov 2013-2014.\n+ * License:   <a href=\"http://www.boost.org/LICENSE_1_0.txt\">Boost License 1.0</a>.\n+ * Authors:   Igor Stepanov\n+ * Source: $(DRUNTIMESRC core/internal/_aa.d)\n+ */\n+module core.internal.aa;\n+\n+import core.internal.traits;\n+import core.exception;\n+import core.memory;\n+\n+enum Mutability\n+{\n+    Mutable,\n+    Const,\n+    Immutable,\n+    //Shared,\n+    //ConstShared\n+}\n+\n+struct AssociativeArray(Key, Value)\n+{\n+    private enum isLvlValueConst = lvlOpEqualsArgModififer!Value == OpEqualsArg.Const;\n+    private enum isRvlValueConst = rvlOpEqualsArgModififer!Value == OpEqualsArg.Const;","path":"src/core/internal/aa.d","position":28,"original_position":28,"commit_id":"5a083ff1fb4a3eaa9a9bbf8ae5ade7d147e35ca6","original_commit_id":"5a083ff1fb4a3eaa9a9bbf8ae5ade7d147e35ca6","user":{"login":"rainers","id":702284,"avatar_url":"https://avatars.githubusercontent.com/u/702284?v=3","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"body":"Ah, ok. I missed the reversed comparisons in lvlOpEqualsArgModififer and rvlOpEqualsArgModififer. A comment there would be nice.\r\nBTW: Modififer -> Modifier?","created_at":"2014-11-22T17:31:28Z","updated_at":"2014-11-22T17:31:28Z","html_url":"https://github.com/D-Programming-Language/druntime/pull/934#discussion_r20758493","pull_request_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/934","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/comments/20758493"},"html":{"href":"https://github.com/D-Programming-Language/druntime/pull/934#discussion_r20758493"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/934"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/934","id":20195379,"html_url":"https://github.com/D-Programming-Language/druntime/pull/934","diff_url":"https://github.com/D-Programming-Language/druntime/pull/934.diff","patch_url":"https://github.com/D-Programming-Language/druntime/pull/934.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/934","number":934,"state":"open","locked":false,"title":"[new AA] implement core.internal.aa","user":{"login":"IgorStepanov","id":1143799,"avatar_url":"https://avatars.githubusercontent.com/u/1143799?v=3","gravatar_id":"","url":"https://api.github.com/users/IgorStepanov","html_url":"https://github.com/IgorStepanov","followers_url":"https://api.github.com/users/IgorStepanov/followers","following_url":"https://api.github.com/users/IgorStepanov/following{/other_user}","gists_url":"https://api.github.com/users/IgorStepanov/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorStepanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorStepanov/subscriptions","organizations_url":"https://api.github.com/users/IgorStepanov/orgs","repos_url":"https://api.github.com/users/IgorStepanov/repos","events_url":"https://api.github.com/users/IgorStepanov/events{/privacy}","received_events_url":"https://api.github.com/users/IgorStepanov/received_events","type":"User","site_admin":false},"body":"This PR introduces new AA implementation. At the first stage, compiler will not know about `core.internal.aa.AssociativeArray` and will use only object.aaNew and object.aaLiteral methods.\r\nThus, this AA implenetation should replace rt.aaA implemetation.\r\nWhen first stage will be finished, we will start work to endowing `core.internal.aa.AssociativeArray` with all the abilities of language's AA. For example:\r\n```\r\nint[string][string] table;\r\ntable[\"foo\"][\"bar\"] = 3;\r\n\r\nAssociativeArray!(string, AssociativeArray!(string, int)) table2;\r\ntable2[\"foo\"][\"bar\"] = 3; //exeption, because \"foo\" doesn't exist in table2\r\n```\r\nHowever, now I dont's talk about second stage. I want to finish first stage, wait one release cycle (to catching all possible troubles), and start to work under second stage when the next D version (after first stage finish) will be released.","created_at":"2014-08-22T20:31:59Z","updated_at":"2014-11-22T17:31:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"741a45a80ad68588a5958c55d8916c349afc84a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/934/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/934/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/934/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/druntime/statuses/5a083ff1fb4a3eaa9a9bbf8ae5ade7d147e35ca6","head":{"label":"IgorStepanov:newaa-internal-aa","ref":"newaa-internal-aa","sha":"5a083ff1fb4a3eaa9a9bbf8ae5ade7d147e35ca6","user":{"login":"IgorStepanov","id":1143799,"avatar_url":"https://avatars.githubusercontent.com/u/1143799?v=3","gravatar_id":"","url":"https://api.github.com/users/IgorStepanov","html_url":"https://github.com/IgorStepanov","followers_url":"https://api.github.com/users/IgorStepanov/followers","following_url":"https://api.github.com/users/IgorStepanov/following{/other_user}","gists_url":"https://api.github.com/users/IgorStepanov/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorStepanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorStepanov/subscriptions","organizations_url":"https://api.github.com/users/IgorStepanov/orgs","repos_url":"https://api.github.com/users/IgorStepanov/repos","events_url":"https://api.github.com/users/IgorStepanov/events{/privacy}","received_events_url":"https://api.github.com/users/IgorStepanov/received_events","type":"User","site_admin":false},"repo":{"id":5319300,"name":"druntime","full_name":"IgorStepanov/druntime","owner":{"login":"IgorStepanov","id":1143799,"avatar_url":"https://avatars.githubusercontent.com/u/1143799?v=3","gravatar_id":"","url":"https://api.github.com/users/IgorStepanov","html_url":"https://github.com/IgorStepanov","followers_url":"https://api.github.com/users/IgorStepanov/followers","following_url":"https://api.github.com/users/IgorStepanov/following{/other_user}","gists_url":"https://api.github.com/users/IgorStepanov/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorStepanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorStepanov/subscriptions","organizations_url":"https://api.github.com/users/IgorStepanov/orgs","repos_url":"https://api.github.com/users/IgorStepanov/repos","events_url":"https://api.github.com/users/IgorStepanov/events{/privacy}","received_events_url":"https://api.github.com/users/IgorStepanov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IgorStepanov/druntime","description":"Low level runtime library for the D programming language","fork":true,"url":"https://api.github.com/repos/IgorStepanov/druntime","forks_url":"https://api.github.com/repos/IgorStepanov/druntime/forks","keys_url":"https://api.github.com/repos/IgorStepanov/druntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IgorStepanov/druntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IgorStepanov/druntime/teams","hooks_url":"https://api.github.com/repos/IgorStepanov/druntime/hooks","issue_events_url":"https://api.github.com/repos/IgorStepanov/druntime/issues/events{/number}","events_url":"https://api.github.com/repos/IgorStepanov/druntime/events","assignees_url":"https://api.github.com/repos/IgorStepanov/druntime/assignees{/user}","branches_url":"https://api.github.com/repos/IgorStepanov/druntime/branches{/branch}","tags_url":"https://api.github.com/repos/IgorStepanov/druntime/tags","blobs_url":"https://api.github.com/repos/IgorStepanov/druntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IgorStepanov/druntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IgorStepanov/druntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/IgorStepanov/druntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IgorStepanov/druntime/statuses/{sha}","languages_url":"https://api.github.com/repos/IgorStepanov/druntime/languages","stargazers_url":"https://api.github.com/repos/IgorStepanov/druntime/stargazers","contributors_url":"https://api.github.com/repos/IgorStepanov/druntime/contributors","subscribers_url":"https://api.github.com/repos/IgorStepanov/druntime/subscribers","subscription_url":"https://api.github.com/repos/IgorStepanov/druntime/subscription","commits_url":"https://api.github.com/repos/IgorStepanov/druntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/IgorStepanov/druntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/IgorStepanov/druntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/IgorStepanov/druntime/issues/comments/{number}","contents_url":"https://api.github.com/repos/IgorStepanov/druntime/contents/{+path}","compare_url":"https://api.github.com/repos/IgorStepanov/druntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IgorStepanov/druntime/merges","archive_url":"https://api.github.com/repos/IgorStepanov/druntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IgorStepanov/druntime/downloads","issues_url":"https://api.github.com/repos/IgorStepanov/druntime/issues{/number}","pulls_url":"https://api.github.com/repos/IgorStepanov/druntime/pulls{/number}","milestones_url":"https://api.github.com/repos/IgorStepanov/druntime/milestones{/number}","notifications_url":"https://api.github.com/repos/IgorStepanov/druntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IgorStepanov/druntime/labels{/name}","releases_url":"https://api.github.com/repos/IgorStepanov/druntime/releases{/id}","created_at":"2012-08-06T20:37:21Z","updated_at":"2014-08-22T18:49:03Z","pushed_at":"2014-11-09T13:14:48Z","git_url":"git://github.com/IgorStepanov/druntime.git","ssh_url":"git@github.com:IgorStepanov/druntime.git","clone_url":"https://github.com/IgorStepanov/druntime.git","svn_url":"https://github.com/IgorStepanov/druntime","homepage":"d-programming-language.org","size":8010,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"b9473662b12766178a24f25da9573e886df4f8b5","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257087,"name":"druntime","full_name":"D-Programming-Language/druntime","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/druntime","description":"Low level runtime library for the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/druntime","forks_url":"https://api.github.com/repos/D-Programming-Language/druntime/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/druntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/druntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/druntime/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/druntime/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/druntime/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/druntime/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/druntime/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/druntime/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/druntime/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/druntime/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/druntime/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/druntime/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/druntime/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/druntime/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/druntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/druntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/druntime/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/druntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/druntime/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/druntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/druntime/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/druntime/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/druntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/druntime/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/druntime/releases{/id}","created_at":"2011-01-15T07:01:38Z","updated_at":"2014-11-22T15:19:03Z","pushed_at":"2014-11-22T15:19:01Z","git_url":"git://github.com/D-Programming-Language/druntime.git","ssh_url":"git@github.com:D-Programming-Language/druntime.git","clone_url":"https://github.com/D-Programming-Language/druntime.git","svn_url":"https://github.com/D-Programming-Language/druntime","homepage":"dlang.org","size":18851,"stargazers_count":327,"watchers_count":327,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":218,"mirror_url":null,"open_issues_count":32,"forks":218,"open_issues":32,"watchers":327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/934"},"html":{"href":"https://github.com/D-Programming-Language/druntime/pull/934"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/issues/934"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/issues/934/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/934/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/934/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/statuses/5a083ff1fb4a3eaa9a9bbf8ae5ade7d147e35ca6"}}}}