GitHub PullRequestEvent at 2014-02-28 12:49:38
Repository: netaddr
Actor: snordhausen
Payload: {"action":"closed","number":55,"pull_request":{"url":"https://api.github.com/repos/drkjam/netaddr/pulls/55","id":6939667,"html_url":"https://github.com/drkjam/netaddr/pull/55","diff_url":"https://github.com/drkjam/netaddr/pull/55.diff","patch_url":"https://github.com/drkjam/netaddr/pull/55.patch","issue_url":"https://api.github.com/repos/drkjam/netaddr/issues/55","number":55,"state":"closed","title":"Fix smallest_matching_cidr and all_matching_cidrs","user":{"login":"akgood","id":140475,"avatar_url":"https://avatars.githubusercontent.com/u/140475","gravatar_id":"c9b3e4fbd4482621d4c5c0b90d50f345","url":"https://api.github.com/users/akgood","html_url":"https://github.com/akgood","followers_url":"https://api.github.com/users/akgood/followers","following_url":"https://api.github.com/users/akgood/following{/other_user}","gists_url":"https://api.github.com/users/akgood/gists{/gist_id}","starred_url":"https://api.github.com/users/akgood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akgood/subscriptions","organizations_url":"https://api.github.com/users/akgood/orgs","repos_url":"https://api.github.com/users/akgood/repos","events_url":"https://api.github.com/users/akgood/events{/privacy}","received_events_url":"https://api.github.com/users/akgood/received_events","type":"User","site_admin":false},"body":"`smallest_matching_cidr()` and `all_matching_cidrs()` will not always produce the correct result. Say you have a list:                            \r\n\r\n     nets = ['0.0.0.0/0', '10.0.0.0/8', '192.168.0.0/16']\r\n\r\nthen, if you call                                               \r\n\r\n     netaddr.smallest_matching_cidr('192.168.0.1', nets)         \r\n\r\nyou will get back '0.0.0.0/0', rather than '192.168.0.0/16'. Once `smallest_matching_cidr()` and `all_matching_cidrs()` find *any* match, they will abort their loops and return a value as soon as they find any subsequent non-matching IP range.\r\n\r\nInstead, we need to ensure that no further matches can possibly exist in the list; we should be able to do this by checking to see if the non-matching range we're testing is *outside* the smallest range we've found so far.","created_at":"2013-07-15T22:15:47Z","updated_at":"2014-02-28T12:49:38Z","closed_at":"2014-02-28T12:49:38Z","merged_at":"2014-02-28T12:49:38Z","merge_commit_sha":"dd7c626c78d7479a8881aa4d85bde033803a5779","assignee":null,"milestone":{"url":"https://api.github.com/repos/drkjam/netaddr/milestones/1","labels_url":"https://api.github.com/repos/drkjam/netaddr/milestones/1/labels","id":580968,"number":1,"title":"0.7.11","description":null,"creator":{"login":"snordhausen","id":1327310,"avatar_url":"https://avatars.githubusercontent.com/u/1327310","gravatar_id":"a3cd09215f5bd3010a899517a1788185","url":"https://api.github.com/users/snordhausen","html_url":"https://github.com/snordhausen","followers_url":"https://api.github.com/users/snordhausen/followers","following_url":"https://api.github.com/users/snordhausen/following{/other_user}","gists_url":"https://api.github.com/users/snordhausen/gists{/gist_id}","starred_url":"https://api.github.com/users/snordhausen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snordhausen/subscriptions","organizations_url":"https://api.github.com/users/snordhausen/orgs","repos_url":"https://api.github.com/users/snordhausen/repos","events_url":"https://api.github.com/users/snordhausen/events{/privacy}","received_events_url":"https://api.github.com/users/snordhausen/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":21,"state":"open","created_at":"2014-02-26T12:30:14Z","updated_at":"2014-02-28T12:49:38Z","due_on":null},"commits_url":"https://api.github.com/repos/drkjam/netaddr/pulls/55/commits","review_comments_url":"https://api.github.com/repos/drkjam/netaddr/pulls/55/comments","review_comment_url":"https://api.github.com/repos/drkjam/netaddr/pulls/comments/{number}","comments_url":"https://api.github.com/repos/drkjam/netaddr/issues/55/comments","statuses_url":"https://api.github.com/repos/drkjam/netaddr/statuses/51a4f6b440625f1747ea1e7b5a428778a61c46ce","head":{"label":"akgood:rel-0.7.x","ref":"rel-0.7.x","sha":"51a4f6b440625f1747ea1e7b5a428778a61c46ce","user":{"login":"akgood","id":140475,"avatar_url":"https://avatars.githubusercontent.com/u/140475","gravatar_id":"c9b3e4fbd4482621d4c5c0b90d50f345","url":"https://api.github.com/users/akgood","html_url":"https://github.com/akgood","followers_url":"https://api.github.com/users/akgood/followers","following_url":"https://api.github.com/users/akgood/following{/other_user}","gists_url":"https://api.github.com/users/akgood/gists{/gist_id}","starred_url":"https://api.github.com/users/akgood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akgood/subscriptions","organizations_url":"https://api.github.com/users/akgood/orgs","repos_url":"https://api.github.com/users/akgood/repos","events_url":"https://api.github.com/users/akgood/events{/privacy}","received_events_url":"https://api.github.com/users/akgood/received_events","type":"User","site_admin":false},"repo":{"id":11434502,"name":"netaddr","full_name":"akgood/netaddr","owner":{"login":"akgood","id":140475,"avatar_url":"https://avatars.githubusercontent.com/u/140475","gravatar_id":"c9b3e4fbd4482621d4c5c0b90d50f345","url":"https://api.github.com/users/akgood","html_url":"https://github.com/akgood","followers_url":"https://api.github.com/users/akgood/followers","following_url":"https://api.github.com/users/akgood/following{/other_user}","gists_url":"https://api.github.com/users/akgood/gists{/gist_id}","starred_url":"https://api.github.com/users/akgood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akgood/subscriptions","organizations_url":"https://api.github.com/users/akgood/orgs","repos_url":"https://api.github.com/users/akgood/repos","events_url":"https://api.github.com/users/akgood/events{/privacy}","received_events_url":"https://api.github.com/users/akgood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akgood/netaddr","description":"A network address manipulation library for Python","fork":true,"url":"https://api.github.com/repos/akgood/netaddr","forks_url":"https://api.github.com/repos/akgood/netaddr/forks","keys_url":"https://api.github.com/repos/akgood/netaddr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akgood/netaddr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akgood/netaddr/teams","hooks_url":"https://api.github.com/repos/akgood/netaddr/hooks","issue_events_url":"https://api.github.com/repos/akgood/netaddr/issues/events{/number}","events_url":"https://api.github.com/repos/akgood/netaddr/events","assignees_url":"https://api.github.com/repos/akgood/netaddr/assignees{/user}","branches_url":"https://api.github.com/repos/akgood/netaddr/branches{/branch}","tags_url":"https://api.github.com/repos/akgood/netaddr/tags","blobs_url":"https://api.github.com/repos/akgood/netaddr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akgood/netaddr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akgood/netaddr/git/refs{/sha}","trees_url":"https://api.github.com/repos/akgood/netaddr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akgood/netaddr/statuses/{sha}","languages_url":"https://api.github.com/repos/akgood/netaddr/languages","stargazers_url":"https://api.github.com/repos/akgood/netaddr/stargazers","contributors_url":"https://api.github.com/repos/akgood/netaddr/contributors","subscribers_url":"https://api.github.com/repos/akgood/netaddr/subscribers","subscription_url":"https://api.github.com/repos/akgood/netaddr/subscription","commits_url":"https://api.github.com/repos/akgood/netaddr/commits{/sha}","git_commits_url":"https://api.github.com/repos/akgood/netaddr/git/commits{/sha}","comments_url":"https://api.github.com/repos/akgood/netaddr/comments{/number}","issue_comment_url":"https://api.github.com/repos/akgood/netaddr/issues/comments/{number}","contents_url":"https://api.github.com/repos/akgood/netaddr/contents/{+path}","compare_url":"https://api.github.com/repos/akgood/netaddr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akgood/netaddr/merges","archive_url":"https://api.github.com/repos/akgood/netaddr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akgood/netaddr/downloads","issues_url":"https://api.github.com/repos/akgood/netaddr/issues{/number}","pulls_url":"https://api.github.com/repos/akgood/netaddr/pulls{/number}","milestones_url":"https://api.github.com/repos/akgood/netaddr/milestones{/number}","notifications_url":"https://api.github.com/repos/akgood/netaddr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akgood/netaddr/labels{/name}","releases_url":"https://api.github.com/repos/akgood/netaddr/releases{/id}","created_at":"2013-07-15T21:42:28Z","updated_at":"2014-02-28T12:49:38Z","pushed_at":"2013-07-18T15:36:59Z","git_url":"git://github.com/akgood/netaddr.git","ssh_url":"git@github.com:akgood/netaddr.git","clone_url":"https://github.com/akgood/netaddr.git","svn_url":"https://github.com/akgood/netaddr","homepage":"﻿https://netaddr.readthedocs.org/en/latest/introduction.html","size":6920,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"rel-0.7.x","master_branch":"rel-0.7.x"}},"base":{"label":"drkjam:rel-0.7.x","ref":"rel-0.7.x","sha":"f64ae19e533ffa5522dcba1fc833975cb2ee88a5","user":{"login":"drkjam","id":93508,"avatar_url":"https://avatars.githubusercontent.com/u/93508","gravatar_id":"84e1726eb25c2397ca82ce5791f4ed9f","url":"https://api.github.com/users/drkjam","html_url":"https://github.com/drkjam","followers_url":"https://api.github.com/users/drkjam/followers","following_url":"https://api.github.com/users/drkjam/following{/other_user}","gists_url":"https://api.github.com/users/drkjam/gists{/gist_id}","starred_url":"https://api.github.com/users/drkjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drkjam/subscriptions","organizations_url":"https://api.github.com/users/drkjam/orgs","repos_url":"https://api.github.com/users/drkjam/repos","events_url":"https://api.github.com/users/drkjam/events{/privacy}","received_events_url":"https://api.github.com/users/drkjam/received_events","type":"User","site_admin":false},"repo":{"id":684215,"name":"netaddr","full_name":"drkjam/netaddr","owner":{"login":"drkjam","id":93508,"avatar_url":"https://avatars.githubusercontent.com/u/93508","gravatar_id":"84e1726eb25c2397ca82ce5791f4ed9f","url":"https://api.github.com/users/drkjam","html_url":"https://github.com/drkjam","followers_url":"https://api.github.com/users/drkjam/followers","following_url":"https://api.github.com/users/drkjam/following{/other_user}","gists_url":"https://api.github.com/users/drkjam/gists{/gist_id}","starred_url":"https://api.github.com/users/drkjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drkjam/subscriptions","organizations_url":"https://api.github.com/users/drkjam/orgs","repos_url":"https://api.github.com/users/drkjam/repos","events_url":"https://api.github.com/users/drkjam/events{/privacy}","received_events_url":"https://api.github.com/users/drkjam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drkjam/netaddr","description":"A network address manipulation library for Python","fork":false,"url":"https://api.github.com/repos/drkjam/netaddr","forks_url":"https://api.github.com/repos/drkjam/netaddr/forks","keys_url":"https://api.github.com/repos/drkjam/netaddr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drkjam/netaddr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drkjam/netaddr/teams","hooks_url":"https://api.github.com/repos/drkjam/netaddr/hooks","issue_events_url":"https://api.github.com/repos/drkjam/netaddr/issues/events{/number}","events_url":"https://api.github.com/repos/drkjam/netaddr/events","assignees_url":"https://api.github.com/repos/drkjam/netaddr/assignees{/user}","branches_url":"https://api.github.com/repos/drkjam/netaddr/branches{/branch}","tags_url":"https://api.github.com/repos/drkjam/netaddr/tags","blobs_url":"https://api.github.com/repos/drkjam/netaddr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drkjam/netaddr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drkjam/netaddr/git/refs{/sha}","trees_url":"https://api.github.com/repos/drkjam/netaddr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drkjam/netaddr/statuses/{sha}","languages_url":"https://api.github.com/repos/drkjam/netaddr/languages","stargazers_url":"https://api.github.com/repos/drkjam/netaddr/stargazers","contributors_url":"https://api.github.com/repos/drkjam/netaddr/contributors","subscribers_url":"https://api.github.com/repos/drkjam/netaddr/subscribers","subscription_url":"https://api.github.com/repos/drkjam/netaddr/subscription","commits_url":"https://api.github.com/repos/drkjam/netaddr/commits{/sha}","git_commits_url":"https://api.github.com/repos/drkjam/netaddr/git/commits{/sha}","comments_url":"https://api.github.com/repos/drkjam/netaddr/comments{/number}","issue_comment_url":"https://api.github.com/repos/drkjam/netaddr/issues/comments/{number}","contents_url":"https://api.github.com/repos/drkjam/netaddr/contents/{+path}","compare_url":"https://api.github.com/repos/drkjam/netaddr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drkjam/netaddr/merges","archive_url":"https://api.github.com/repos/drkjam/netaddr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drkjam/netaddr/downloads","issues_url":"https://api.github.com/repos/drkjam/netaddr/issues{/number}","pulls_url":"https://api.github.com/repos/drkjam/netaddr/pulls{/number}","milestones_url":"https://api.github.com/repos/drkjam/netaddr/milestones{/number}","notifications_url":"https://api.github.com/repos/drkjam/netaddr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drkjam/netaddr/labels{/name}","releases_url":"https://api.github.com/repos/drkjam/netaddr/releases{/id}","created_at":"2010-05-24T23:14:56Z","updated_at":"2014-02-28T12:49:38Z","pushed_at":"2014-02-28T12:49:38Z","git_url":"git://github.com/drkjam/netaddr.git","ssh_url":"git@github.com:drkjam/netaddr.git","clone_url":"https://github.com/drkjam/netaddr.git","svn_url":"https://github.com/drkjam/netaddr","homepage":"﻿https://netaddr.readthedocs.org/en/latest/introduction.html","size":8569,"stargazers_count":115,"watchers_count":115,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":22,"mirror_url":null,"open_issues_count":13,"forks":22,"open_issues":13,"watchers":115,"default_branch":"rel-0.7.x","master_branch":"rel-0.7.x"}},"_links":{"self":{"href":"https://api.github.com/repos/drkjam/netaddr/pulls/55"},"html":{"href":"https://github.com/drkjam/netaddr/pull/55"},"issue":{"href":"https://api.github.com/repos/drkjam/netaddr/issues/55"},"comments":{"href":"https://api.github.com/repos/drkjam/netaddr/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/drkjam/netaddr/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/drkjam/netaddr/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/drkjam/netaddr/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/drkjam/netaddr/statuses/51a4f6b440625f1747ea1e7b5a428778a61c46ce"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"snordhausen","id":1327310,"avatar_url":"https://avatars.githubusercontent.com/u/1327310","gravatar_id":"a3cd09215f5bd3010a899517a1788185","url":"https://api.github.com/users/snordhausen","html_url":"https://github.com/snordhausen","followers_url":"https://api.github.com/users/snordhausen/followers","following_url":"https://api.github.com/users/snordhausen/following{/other_user}","gists_url":"https://api.github.com/users/snordhausen/gists{/gist_id}","starred_url":"https://api.github.com/users/snordhausen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snordhausen/subscriptions","organizations_url":"https://api.github.com/users/snordhausen/orgs","repos_url":"https://api.github.com/users/snordhausen/repos","events_url":"https://api.github.com/users/snordhausen/events{/privacy}","received_events_url":"https://api.github.com/users/snordhausen/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":14,"deletions":2,"changed_files":3}}