GitHub PullRequestReviewCommentEvent at 2014-11-01 02:13:52
Repository: zf2
Actor: malukenho
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/zf2/pulls/comments/19701122","id":19701122,"diff_hunk":"@@ -0,0 +1,50 @@\n+<?php\n+/**\n+ * Zend Framework (http://framework.zend.com/)\n+ *\n+ * @link      http://github.com/zendframework/zf2 for the canonical source repository\n+ * @copyright Copyright (c) 2005-2014 Zend Technologies USA Inc. (http://www.zend.com)\n+ * @license   http://framework.zend.com/license/new-bsd New BSD License\n+ */\n+\n+namespace ZendTest\\Navigation\\TestAsset;\n+\n+class RecursiveIteratorIterator extends \\RecursiveIteratorIterator\n+{\n+    /**\n+     *\n+     * @var \\ArrayObject\n+     */\n+    protected $logger;\n+\n+    public function setLogger($logger)","path":"tests/ZendTest/Navigation/TestAsset/RecursiveIteratorIterator.php","position":20,"original_position":20,"commit_id":"4e0c05805d4e62571d45d8384a26a3be4683e77d","original_commit_id":"4e0c05805d4e62571d45d8384a26a3be4683e77d","user":{"login":"malukenho","id":3275172,"avatar_url":"https://avatars.githubusercontent.com/u/3275172?v=2","gravatar_id":"","url":"https://api.github.com/users/malukenho","html_url":"https://github.com/malukenho","followers_url":"https://api.github.com/users/malukenho/followers","following_url":"https://api.github.com/users/malukenho/following{/other_user}","gists_url":"https://api.github.com/users/malukenho/gists{/gist_id}","starred_url":"https://api.github.com/users/malukenho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malukenho/subscriptions","organizations_url":"https://api.github.com/users/malukenho/orgs","repos_url":"https://api.github.com/users/malukenho/repos","events_url":"https://api.github.com/users/malukenho/events{/privacy}","received_events_url":"https://api.github.com/users/malukenho/received_events","type":"User","site_admin":false},"body":"You can use Type hiting here `setLogger(ArrayObject  $logger)`","created_at":"2014-11-01T02:13:52Z","updated_at":"2014-11-01T02:13:52Z","html_url":"https://github.com/zendframework/zf2/pull/6825#discussion_r19701122","pull_request_url":"https://api.github.com/repos/zendframework/zf2/pulls/6825","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/comments/19701122"},"html":{"href":"https://github.com/zendframework/zf2/pull/6825#discussion_r19701122"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/6825"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/zf2/pulls/6825","id":23714734,"html_url":"https://github.com/zendframework/zf2/pull/6825","diff_url":"https://github.com/zendframework/zf2/pull/6825.diff","patch_url":"https://github.com/zendframework/zf2/pull/6825.patch","issue_url":"https://api.github.com/repos/zendframework/zf2/issues/6825","number":6825,"state":"open","locked":false,"title":"Incompatible with RecursiveIterator","user":{"login":"noopable","id":75342,"avatar_url":"https://avatars.githubusercontent.com/u/75342?v=2","gravatar_id":"","url":"https://api.github.com/users/noopable","html_url":"https://github.com/noopable","followers_url":"https://api.github.com/users/noopable/followers","following_url":"https://api.github.com/users/noopable/following{/other_user}","gists_url":"https://api.github.com/users/noopable/gists{/gist_id}","starred_url":"https://api.github.com/users/noopable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noopable/subscriptions","organizations_url":"https://api.github.com/users/noopable/orgs","repos_url":"https://api.github.com/users/noopable/repos","events_url":"https://api.github.com/users/noopable/events{/privacy}","received_events_url":"https://api.github.com/users/noopable/received_events","type":"User","site_admin":false},"body":"#4517\r\n\r\nhttp://php.net/manual/en/recursiveiterator.haschildren.php\r\n> Returns TRUE if the current entry can be iterated over, otherwise returns FALSE. ","created_at":"2014-11-01T02:09:43Z","updated_at":"2014-11-01T02:13:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dc66c5df9d4fa429f6e2f9de96cf3b58f6a115d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendframework/zf2/pulls/6825/commits","review_comments_url":"https://api.github.com/repos/zendframework/zf2/pulls/6825/comments","review_comment_url":"https://api.github.com/repos/zendframework/zf2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zendframework/zf2/issues/6825/comments","statuses_url":"https://api.github.com/repos/zendframework/zf2/statuses/4e0c05805d4e62571d45d8384a26a3be4683e77d","head":{"label":"noopable:issue/4517/Incompatible_with_RecursiveIterator","ref":"issue/4517/Incompatible_with_RecursiveIterator","sha":"4e0c05805d4e62571d45d8384a26a3be4683e77d","user":{"login":"noopable","id":75342,"avatar_url":"https://avatars.githubusercontent.com/u/75342?v=2","gravatar_id":"","url":"https://api.github.com/users/noopable","html_url":"https://github.com/noopable","followers_url":"https://api.github.com/users/noopable/followers","following_url":"https://api.github.com/users/noopable/following{/other_user}","gists_url":"https://api.github.com/users/noopable/gists{/gist_id}","starred_url":"https://api.github.com/users/noopable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noopable/subscriptions","organizations_url":"https://api.github.com/users/noopable/orgs","repos_url":"https://api.github.com/users/noopable/repos","events_url":"https://api.github.com/users/noopable/events{/privacy}","received_events_url":"https://api.github.com/users/noopable/received_events","type":"User","site_admin":false},"repo":{"id":5612019,"name":"zf2","full_name":"noopable/zf2","owner":{"login":"noopable","id":75342,"avatar_url":"https://avatars.githubusercontent.com/u/75342?v=2","gravatar_id":"","url":"https://api.github.com/users/noopable","html_url":"https://github.com/noopable","followers_url":"https://api.github.com/users/noopable/followers","following_url":"https://api.github.com/users/noopable/following{/other_user}","gists_url":"https://api.github.com/users/noopable/gists{/gist_id}","starred_url":"https://api.github.com/users/noopable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noopable/subscriptions","organizations_url":"https://api.github.com/users/noopable/orgs","repos_url":"https://api.github.com/users/noopable/repos","events_url":"https://api.github.com/users/noopable/events{/privacy}","received_events_url":"https://api.github.com/users/noopable/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noopable/zf2","description":"Clone of Zend Framework 2.0 git repository - with minor modify ","fork":true,"url":"https://api.github.com/repos/noopable/zf2","forks_url":"https://api.github.com/repos/noopable/zf2/forks","keys_url":"https://api.github.com/repos/noopable/zf2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noopable/zf2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noopable/zf2/teams","hooks_url":"https://api.github.com/repos/noopable/zf2/hooks","issue_events_url":"https://api.github.com/repos/noopable/zf2/issues/events{/number}","events_url":"https://api.github.com/repos/noopable/zf2/events","assignees_url":"https://api.github.com/repos/noopable/zf2/assignees{/user}","branches_url":"https://api.github.com/repos/noopable/zf2/branches{/branch}","tags_url":"https://api.github.com/repos/noopable/zf2/tags","blobs_url":"https://api.github.com/repos/noopable/zf2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noopable/zf2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noopable/zf2/git/refs{/sha}","trees_url":"https://api.github.com/repos/noopable/zf2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noopable/zf2/statuses/{sha}","languages_url":"https://api.github.com/repos/noopable/zf2/languages","stargazers_url":"https://api.github.com/repos/noopable/zf2/stargazers","contributors_url":"https://api.github.com/repos/noopable/zf2/contributors","subscribers_url":"https://api.github.com/repos/noopable/zf2/subscribers","subscription_url":"https://api.github.com/repos/noopable/zf2/subscription","commits_url":"https://api.github.com/repos/noopable/zf2/commits{/sha}","git_commits_url":"https://api.github.com/repos/noopable/zf2/git/commits{/sha}","comments_url":"https://api.github.com/repos/noopable/zf2/comments{/number}","issue_comment_url":"https://api.github.com/repos/noopable/zf2/issues/comments/{number}","contents_url":"https://api.github.com/repos/noopable/zf2/contents/{+path}","compare_url":"https://api.github.com/repos/noopable/zf2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noopable/zf2/merges","archive_url":"https://api.github.com/repos/noopable/zf2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noopable/zf2/downloads","issues_url":"https://api.github.com/repos/noopable/zf2/issues{/number}","pulls_url":"https://api.github.com/repos/noopable/zf2/pulls{/number}","milestones_url":"https://api.github.com/repos/noopable/zf2/milestones{/number}","notifications_url":"https://api.github.com/repos/noopable/zf2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noopable/zf2/labels{/name}","releases_url":"https://api.github.com/repos/noopable/zf2/releases{/id}","created_at":"2012-08-30T07:53:34Z","updated_at":"2014-10-31T10:17:18Z","pushed_at":"2014-11-01T01:50:34Z","git_url":"git://github.com/noopable/zf2.git","ssh_url":"git@github.com:noopable/zf2.git","clone_url":"https://github.com/noopable/zf2.git","svn_url":"https://github.com/noopable/zf2","homepage":"","size":90164,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"3e6936d75c7fcb4220a9a547d78c6c217a746060","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=2","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":702550,"name":"zf2","full_name":"zendframework/zf2","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=2","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zf2","description":"Official Zend Framework 2 git repository","fork":false,"url":"https://api.github.com/repos/zendframework/zf2","forks_url":"https://api.github.com/repos/zendframework/zf2/forks","keys_url":"https://api.github.com/repos/zendframework/zf2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zf2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zf2/teams","hooks_url":"https://api.github.com/repos/zendframework/zf2/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zf2/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zf2/events","assignees_url":"https://api.github.com/repos/zendframework/zf2/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zf2/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zf2/tags","blobs_url":"https://api.github.com/repos/zendframework/zf2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zf2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zf2/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zf2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zf2/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zf2/languages","stargazers_url":"https://api.github.com/repos/zendframework/zf2/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zf2/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zf2/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zf2/subscription","commits_url":"https://api.github.com/repos/zendframework/zf2/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zf2/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zf2/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zf2/issues/comments/{number}","contents_url":"https://api.github.com/repos/zendframework/zf2/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zf2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zf2/merges","archive_url":"https://api.github.com/repos/zendframework/zf2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zf2/downloads","issues_url":"https://api.github.com/repos/zendframework/zf2/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zf2/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zf2/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zf2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zf2/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zf2/releases{/id}","created_at":"2010-06-04T02:42:05Z","updated_at":"2014-10-31T11:34:18Z","pushed_at":"2014-10-13T11:10:59Z","git_url":"git://github.com/zendframework/zf2.git","ssh_url":"git@github.com:zendframework/zf2.git","clone_url":"https://github.com/zendframework/zf2.git","svn_url":"https://github.com/zendframework/zf2","homepage":"http://framework.zend.com/","size":217523,"stargazers_count":4899,"watchers_count":4899,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2947,"mirror_url":null,"open_issues_count":711,"forks":2947,"open_issues":711,"watchers":4899,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/6825"},"html":{"href":"https://github.com/zendframework/zf2/pull/6825"},"issue":{"href":"https://api.github.com/repos/zendframework/zf2/issues/6825"},"comments":{"href":"https://api.github.com/repos/zendframework/zf2/issues/6825/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/6825/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/6825/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zf2/statuses/4e0c05805d4e62571d45d8384a26a3be4683e77d"}}}}