GitHub PullRequestReviewCommentEvent at 2014-11-24 20:06:56
Repository: crop
Actor: marcingy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/drupal-media/crop/pulls/comments/20817850","id":20817850,"diff_hunk":"@@ -0,0 +1,105 @@\n+<?php\n+\n+/**\n+ * @file\n+ * Contains \\Drupal\\crop\\Tests\\CropUnitTestBase.\n+ */\n+\n+namespace Drupal\\crop\\Tests;\n+\n+use Drupal\\Core\\StreamWrapper\\PublicStream;\n+use Drupal\\simpletest\\KernelTestBase;\n+\n+/**\n+ * Tests the crop entity CRUD operations.\n+ */\n+abstract class CropUnitTestBase extends KernelTestBase {\n+\n+  /**\n+   * The crop storage.\n+   *\n+   * @var \\Drupal\\crop\\CropStorageInterface.\n+   */\n+  protected $cropStorage;\n+\n+  /**\n+   * The crop storage.\n+   *\n+   * @var \\Drupal\\Core\\Config\\Entity\\ConfigEntityStorageInterface.\n+   */\n+  protected $cropTypeStorage;\n+\n+  /**\n+   * The image style storage.\n+   *\n+   * @var \\Drupal\\Core\\Config\\Entity\\ConfigEntityStorageInterface.\n+   */\n+  protected $imageStyleStorage;\n+\n+  /**\n+   * Test image style.\n+   *\n+   * @var \\Drupal\\image\\ImageStyleInterface\n+   */\n+  protected $testStyle;\n+\n+  /**\n+   * Test crop type.\n+   *\n+   * @var \\Drupal\\crop\\CropInterface\n+   */\n+  protected $cropType;\n+\n+  protected function setUp() {\n+    parent::setUp();\n+\n+    /** @var \\Drupal\\Core\\Entity\\EntityManagerInterface $entity_manager */\n+    $entity_manager = $this->container->get('entity.manager');\n+    $this->cropStorage = $entity_manager->getStorage('crop');\n+    $this->cropTypeStorage = $entity_manager->getStorage('crop_type');\n+    $this->imageStyleStorage = $entity_manager->getStorage('image_style');\n+\n+    // Create DB schemas.\n+    $entity_manager->onEntityTypeCreate($entity_manager->getDefinition('user'));\n+    $entity_manager->onEntityTypeCreate($entity_manager->getDefinition('image_style'));\n+    $entity_manager->onEntityTypeCreate($entity_manager->getDefinition('crop'));\n+\n+    // Create test image style\n+    $this->testStyle = $this->imageStyleStorage->create([\n+      'name' => 'test',\n+      'label' => 'Test image style',\n+      'effects' => [\n+        '69ad20fb-13b0-4e84-acaf-ddd91e7e15ac' => [","path":"src/Tests/CropUnitTestBase.php","position":72,"original_position":72,"commit_id":"bd806be0efc8256fe1504fd819a75aa20ed26650","original_commit_id":"bd806be0efc8256fe1504fd819a75aa20ed26650","user":{"login":"marcingy","id":192095,"avatar_url":"https://avatars.githubusercontent.com/u/192095?v=3","gravatar_id":"","url":"https://api.github.com/users/marcingy","html_url":"https://github.com/marcingy","followers_url":"https://api.github.com/users/marcingy/followers","following_url":"https://api.github.com/users/marcingy/following{/other_user}","gists_url":"https://api.github.com/users/marcingy/gists{/gist_id}","starred_url":"https://api.github.com/users/marcingy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcingy/subscriptions","organizations_url":"https://api.github.com/users/marcingy/orgs","repos_url":"https://api.github.com/users/marcingy/repos","events_url":"https://api.github.com/users/marcingy/events{/privacy}","received_events_url":"https://api.github.com/users/marcingy/received_events","type":"User","site_admin":false},"body":"Should we be providing UUIDS? Both here and below","created_at":"2014-11-24T20:06:56Z","updated_at":"2014-11-24T20:06:56Z","html_url":"https://github.com/drupal-media/crop/pull/2#discussion_r20817850","pull_request_url":"https://api.github.com/repos/drupal-media/crop/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/drupal-media/crop/pulls/comments/20817850"},"html":{"href":"https://github.com/drupal-media/crop/pull/2#discussion_r20817850"},"pull_request":{"href":"https://api.github.com/repos/drupal-media/crop/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/drupal-media/crop/pulls/2","id":24867800,"html_url":"https://github.com/drupal-media/crop/pull/2","diff_url":"https://github.com/drupal-media/crop/pull/2.diff","patch_url":"https://github.com/drupal-media/crop/pull/2.patch","issue_url":"https://api.github.com/repos/drupal-media/crop/issues/2","number":2,"state":"open","locked":false,"title":"Crop image effect","user":{"login":"slashrsm","id":376889,"avatar_url":"https://avatars.githubusercontent.com/u/376889?v=3","gravatar_id":"","url":"https://api.github.com/users/slashrsm","html_url":"https://github.com/slashrsm","followers_url":"https://api.github.com/users/slashrsm/followers","following_url":"https://api.github.com/users/slashrsm/following{/other_user}","gists_url":"https://api.github.com/users/slashrsm/gists{/gist_id}","starred_url":"https://api.github.com/users/slashrsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashrsm/subscriptions","organizations_url":"https://api.github.com/users/slashrsm/orgs","repos_url":"https://api.github.com/users/slashrsm/repos","events_url":"https://api.github.com/users/slashrsm/events{/privacy}","received_events_url":"https://api.github.com/users/slashrsm/received_events","type":"User","site_admin":false},"body":"https://www.drupal.org/node/2376691","created_at":"2014-11-21T20:43:33Z","updated_at":"2014-11-24T20:06:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc153313c2320fa2b149b1718605110dbce033bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/drupal-media/crop/pulls/2/commits","review_comments_url":"https://api.github.com/repos/drupal-media/crop/pulls/2/comments","review_comment_url":"https://api.github.com/repos/drupal-media/crop/pulls/comments/{number}","comments_url":"https://api.github.com/repos/drupal-media/crop/issues/2/comments","statuses_url":"https://api.github.com/repos/drupal-media/crop/statuses/bd806be0efc8256fe1504fd819a75aa20ed26650","head":{"label":"slashrsm:2376691","ref":"2376691","sha":"bd806be0efc8256fe1504fd819a75aa20ed26650","user":{"login":"slashrsm","id":376889,"avatar_url":"https://avatars.githubusercontent.com/u/376889?v=3","gravatar_id":"","url":"https://api.github.com/users/slashrsm","html_url":"https://github.com/slashrsm","followers_url":"https://api.github.com/users/slashrsm/followers","following_url":"https://api.github.com/users/slashrsm/following{/other_user}","gists_url":"https://api.github.com/users/slashrsm/gists{/gist_id}","starred_url":"https://api.github.com/users/slashrsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashrsm/subscriptions","organizations_url":"https://api.github.com/users/slashrsm/orgs","repos_url":"https://api.github.com/users/slashrsm/repos","events_url":"https://api.github.com/users/slashrsm/events{/privacy}","received_events_url":"https://api.github.com/users/slashrsm/received_events","type":"User","site_admin":false},"repo":{"id":26761877,"name":"crop","full_name":"slashrsm/crop","owner":{"login":"slashrsm","id":376889,"avatar_url":"https://avatars.githubusercontent.com/u/376889?v=3","gravatar_id":"","url":"https://api.github.com/users/slashrsm","html_url":"https://github.com/slashrsm","followers_url":"https://api.github.com/users/slashrsm/followers","following_url":"https://api.github.com/users/slashrsm/following{/other_user}","gists_url":"https://api.github.com/users/slashrsm/gists{/gist_id}","starred_url":"https://api.github.com/users/slashrsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashrsm/subscriptions","organizations_url":"https://api.github.com/users/slashrsm/orgs","repos_url":"https://api.github.com/users/slashrsm/repos","events_url":"https://api.github.com/users/slashrsm/events{/privacy}","received_events_url":"https://api.github.com/users/slashrsm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slashrsm/crop","description":"Base crop API for Drupal 8.","fork":true,"url":"https://api.github.com/repos/slashrsm/crop","forks_url":"https://api.github.com/repos/slashrsm/crop/forks","keys_url":"https://api.github.com/repos/slashrsm/crop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slashrsm/crop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slashrsm/crop/teams","hooks_url":"https://api.github.com/repos/slashrsm/crop/hooks","issue_events_url":"https://api.github.com/repos/slashrsm/crop/issues/events{/number}","events_url":"https://api.github.com/repos/slashrsm/crop/events","assignees_url":"https://api.github.com/repos/slashrsm/crop/assignees{/user}","branches_url":"https://api.github.com/repos/slashrsm/crop/branches{/branch}","tags_url":"https://api.github.com/repos/slashrsm/crop/tags","blobs_url":"https://api.github.com/repos/slashrsm/crop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slashrsm/crop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slashrsm/crop/git/refs{/sha}","trees_url":"https://api.github.com/repos/slashrsm/crop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slashrsm/crop/statuses/{sha}","languages_url":"https://api.github.com/repos/slashrsm/crop/languages","stargazers_url":"https://api.github.com/repos/slashrsm/crop/stargazers","contributors_url":"https://api.github.com/repos/slashrsm/crop/contributors","subscribers_url":"https://api.github.com/repos/slashrsm/crop/subscribers","subscription_url":"https://api.github.com/repos/slashrsm/crop/subscription","commits_url":"https://api.github.com/repos/slashrsm/crop/commits{/sha}","git_commits_url":"https://api.github.com/repos/slashrsm/crop/git/commits{/sha}","comments_url":"https://api.github.com/repos/slashrsm/crop/comments{/number}","issue_comment_url":"https://api.github.com/repos/slashrsm/crop/issues/comments/{number}","contents_url":"https://api.github.com/repos/slashrsm/crop/contents/{+path}","compare_url":"https://api.github.com/repos/slashrsm/crop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slashrsm/crop/merges","archive_url":"https://api.github.com/repos/slashrsm/crop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slashrsm/crop/downloads","issues_url":"https://api.github.com/repos/slashrsm/crop/issues{/number}","pulls_url":"https://api.github.com/repos/slashrsm/crop/pulls{/number}","milestones_url":"https://api.github.com/repos/slashrsm/crop/milestones{/number}","notifications_url":"https://api.github.com/repos/slashrsm/crop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slashrsm/crop/labels{/name}","releases_url":"https://api.github.com/repos/slashrsm/crop/releases{/id}","created_at":"2014-11-17T15:05:12Z","updated_at":"2014-11-17T14:57:23Z","pushed_at":"2014-11-24T14:17:04Z","git_url":"git://github.com/slashrsm/crop.git","ssh_url":"git@github.com:slashrsm/crop.git","clone_url":"https://github.com/slashrsm/crop.git","svn_url":"https://github.com/slashrsm/crop","homepage":null,"size":274,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x-1.x"}},"base":{"label":"drupal-media:8.x-1.x","ref":"8.x-1.x","sha":"0d796e9360f4ba885432a4daad21ab609109f7f4","user":{"login":"drupal-media","id":7276699,"avatar_url":"https://avatars.githubusercontent.com/u/7276699?v=3","gravatar_id":"","url":"https://api.github.com/users/drupal-media","html_url":"https://github.com/drupal-media","followers_url":"https://api.github.com/users/drupal-media/followers","following_url":"https://api.github.com/users/drupal-media/following{/other_user}","gists_url":"https://api.github.com/users/drupal-media/gists{/gist_id}","starred_url":"https://api.github.com/users/drupal-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupal-media/subscriptions","organizations_url":"https://api.github.com/users/drupal-media/orgs","repos_url":"https://api.github.com/users/drupal-media/repos","events_url":"https://api.github.com/users/drupal-media/events{/privacy}","received_events_url":"https://api.github.com/users/drupal-media/received_events","type":"Organization","site_admin":false},"repo":{"id":26761516,"name":"crop","full_name":"drupal-media/crop","owner":{"login":"drupal-media","id":7276699,"avatar_url":"https://avatars.githubusercontent.com/u/7276699?v=3","gravatar_id":"","url":"https://api.github.com/users/drupal-media","html_url":"https://github.com/drupal-media","followers_url":"https://api.github.com/users/drupal-media/followers","following_url":"https://api.github.com/users/drupal-media/following{/other_user}","gists_url":"https://api.github.com/users/drupal-media/gists{/gist_id}","starred_url":"https://api.github.com/users/drupal-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupal-media/subscriptions","organizations_url":"https://api.github.com/users/drupal-media/orgs","repos_url":"https://api.github.com/users/drupal-media/repos","events_url":"https://api.github.com/users/drupal-media/events{/privacy}","received_events_url":"https://api.github.com/users/drupal-media/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drupal-media/crop","description":"Base crop API for Drupal 8.","fork":false,"url":"https://api.github.com/repos/drupal-media/crop","forks_url":"https://api.github.com/repos/drupal-media/crop/forks","keys_url":"https://api.github.com/repos/drupal-media/crop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drupal-media/crop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drupal-media/crop/teams","hooks_url":"https://api.github.com/repos/drupal-media/crop/hooks","issue_events_url":"https://api.github.com/repos/drupal-media/crop/issues/events{/number}","events_url":"https://api.github.com/repos/drupal-media/crop/events","assignees_url":"https://api.github.com/repos/drupal-media/crop/assignees{/user}","branches_url":"https://api.github.com/repos/drupal-media/crop/branches{/branch}","tags_url":"https://api.github.com/repos/drupal-media/crop/tags","blobs_url":"https://api.github.com/repos/drupal-media/crop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drupal-media/crop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drupal-media/crop/git/refs{/sha}","trees_url":"https://api.github.com/repos/drupal-media/crop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drupal-media/crop/statuses/{sha}","languages_url":"https://api.github.com/repos/drupal-media/crop/languages","stargazers_url":"https://api.github.com/repos/drupal-media/crop/stargazers","contributors_url":"https://api.github.com/repos/drupal-media/crop/contributors","subscribers_url":"https://api.github.com/repos/drupal-media/crop/subscribers","subscription_url":"https://api.github.com/repos/drupal-media/crop/subscription","commits_url":"https://api.github.com/repos/drupal-media/crop/commits{/sha}","git_commits_url":"https://api.github.com/repos/drupal-media/crop/git/commits{/sha}","comments_url":"https://api.github.com/repos/drupal-media/crop/comments{/number}","issue_comment_url":"https://api.github.com/repos/drupal-media/crop/issues/comments/{number}","contents_url":"https://api.github.com/repos/drupal-media/crop/contents/{+path}","compare_url":"https://api.github.com/repos/drupal-media/crop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drupal-media/crop/merges","archive_url":"https://api.github.com/repos/drupal-media/crop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drupal-media/crop/downloads","issues_url":"https://api.github.com/repos/drupal-media/crop/issues{/number}","pulls_url":"https://api.github.com/repos/drupal-media/crop/pulls{/number}","milestones_url":"https://api.github.com/repos/drupal-media/crop/milestones{/number}","notifications_url":"https://api.github.com/repos/drupal-media/crop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drupal-media/crop/labels{/name}","releases_url":"https://api.github.com/repos/drupal-media/crop/releases{/id}","created_at":"2014-11-17T14:57:23Z","updated_at":"2014-11-21T16:55:08Z","pushed_at":"2014-11-21T16:55:08Z","git_url":"git://github.com/drupal-media/crop.git","ssh_url":"git@github.com:drupal-media/crop.git","clone_url":"https://github.com/drupal-media/crop.git","svn_url":"https://github.com/drupal-media/crop","homepage":null,"size":269,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"8.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/drupal-media/crop/pulls/2"},"html":{"href":"https://github.com/drupal-media/crop/pull/2"},"issue":{"href":"https://api.github.com/repos/drupal-media/crop/issues/2"},"comments":{"href":"https://api.github.com/repos/drupal-media/crop/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/drupal-media/crop/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/drupal-media/crop/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/drupal-media/crop/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/drupal-media/crop/statuses/bd806be0efc8256fe1504fd819a75aa20ed26650"}}}}