GitHub PullRequestReviewCommentEvent at 2014-09-25 16:31:40
Repository: hifi
Actor: ZappoMan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/18042818","id":18042818,"diff_hunk":"@@ -47,6 +47,8 @@\n \n static const int NUM_AUDIO_CHANNELS = 2;\n \n+static const int MAX_16_BIT_AUDIO_SAMPLE = 32767;","path":"interface/src/Audio.h","position":4,"original_position":4,"commit_id":"fcc5eb9d0af9ffa31c1d76af2bcf0d53e7fad282","original_commit_id":"fcc5eb9d0af9ffa31c1d76af2bcf0d53e7fad282","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=2","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"this would be a preferable value to use...\r\n\r\n```\r\n#include <limits>\r\nstatic const int MAX_16_BIT_AUDIO_SAMPLE = std::numeric_limits<int16_t>::max();\r\n```","created_at":"2014-09-25T16:31:40Z","updated_at":"2014-09-25T16:31:40Z","html_url":"https://github.com/highfidelity/hifi/pull/3479#discussion_r18042818","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/3479","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/18042818"},"html":{"href":"https://github.com/highfidelity/hifi/pull/3479#discussion_r18042818"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/3479"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/3479","id":21752961,"html_url":"https://github.com/highfidelity/hifi/pull/3479","diff_url":"https://github.com/highfidelity/hifi/pull/3479.diff","patch_url":"https://github.com/highfidelity/hifi/pull/3479.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/3479","number":3479,"state":"open","locked":false,"title":"Improved eye contact, audio driven mouth and brows, linear audio scope","user":{"login":"PhilipRosedale","id":1746324,"avatar_url":"https://avatars.githubusercontent.com/u/1746324?v=2","gravatar_id":"","url":"https://api.github.com/users/PhilipRosedale","html_url":"https://github.com/PhilipRosedale","followers_url":"https://api.github.com/users/PhilipRosedale/followers","following_url":"https://api.github.com/users/PhilipRosedale/following{/other_user}","gists_url":"https://api.github.com/users/PhilipRosedale/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilipRosedale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilipRosedale/subscriptions","organizations_url":"https://api.github.com/users/PhilipRosedale/orgs","repos_url":"https://api.github.com/users/PhilipRosedale/repos","events_url":"https://api.github.com/users/PhilipRosedale/events{/privacy}","received_events_url":"https://api.github.com/users/PhilipRosedale/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-24T23:40:44Z","updated_at":"2014-09-25T16:31:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b093d660ff688ab61db52a6cd110e4698ba9097f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/3479/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/3479/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/{number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/3479/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/fcc5eb9d0af9ffa31c1d76af2bcf0d53e7fad282","head":{"label":"PhilipRosedale:master","ref":"master","sha":"fcc5eb9d0af9ffa31c1d76af2bcf0d53e7fad282","user":{"login":"PhilipRosedale","id":1746324,"avatar_url":"https://avatars.githubusercontent.com/u/1746324?v=2","gravatar_id":"","url":"https://api.github.com/users/PhilipRosedale","html_url":"https://github.com/PhilipRosedale","followers_url":"https://api.github.com/users/PhilipRosedale/followers","following_url":"https://api.github.com/users/PhilipRosedale/following{/other_user}","gists_url":"https://api.github.com/users/PhilipRosedale/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilipRosedale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilipRosedale/subscriptions","organizations_url":"https://api.github.com/users/PhilipRosedale/orgs","repos_url":"https://api.github.com/users/PhilipRosedale/repos","events_url":"https://api.github.com/users/PhilipRosedale/events{/privacy}","received_events_url":"https://api.github.com/users/PhilipRosedale/received_events","type":"User","site_admin":false},"repo":{"id":9383131,"name":"hifi","full_name":"PhilipRosedale/hifi","owner":{"login":"PhilipRosedale","id":1746324,"avatar_url":"https://avatars.githubusercontent.com/u/1746324?v=2","gravatar_id":"","url":"https://api.github.com/users/PhilipRosedale","html_url":"https://github.com/PhilipRosedale","followers_url":"https://api.github.com/users/PhilipRosedale/followers","following_url":"https://api.github.com/users/PhilipRosedale/following{/other_user}","gists_url":"https://api.github.com/users/PhilipRosedale/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilipRosedale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilipRosedale/subscriptions","organizations_url":"https://api.github.com/users/PhilipRosedale/orgs","repos_url":"https://api.github.com/users/PhilipRosedale/repos","events_url":"https://api.github.com/users/PhilipRosedale/events{/privacy}","received_events_url":"https://api.github.com/users/PhilipRosedale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PhilipRosedale/hifi","description":"What is the Matrix?","fork":true,"url":"https://api.github.com/repos/PhilipRosedale/hifi","forks_url":"https://api.github.com/repos/PhilipRosedale/hifi/forks","keys_url":"https://api.github.com/repos/PhilipRosedale/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PhilipRosedale/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PhilipRosedale/hifi/teams","hooks_url":"https://api.github.com/repos/PhilipRosedale/hifi/hooks","issue_events_url":"https://api.github.com/repos/PhilipRosedale/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/PhilipRosedale/hifi/events","assignees_url":"https://api.github.com/repos/PhilipRosedale/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/PhilipRosedale/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/PhilipRosedale/hifi/tags","blobs_url":"https://api.github.com/repos/PhilipRosedale/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PhilipRosedale/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PhilipRosedale/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/PhilipRosedale/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PhilipRosedale/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/PhilipRosedale/hifi/languages","stargazers_url":"https://api.github.com/repos/PhilipRosedale/hifi/stargazers","contributors_url":"https://api.github.com/repos/PhilipRosedale/hifi/contributors","subscribers_url":"https://api.github.com/repos/PhilipRosedale/hifi/subscribers","subscription_url":"https://api.github.com/repos/PhilipRosedale/hifi/subscription","commits_url":"https://api.github.com/repos/PhilipRosedale/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/PhilipRosedale/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/PhilipRosedale/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/PhilipRosedale/hifi/issues/comments/{number}","contents_url":"https://api.github.com/repos/PhilipRosedale/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/PhilipRosedale/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PhilipRosedale/hifi/merges","archive_url":"https://api.github.com/repos/PhilipRosedale/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PhilipRosedale/hifi/downloads","issues_url":"https://api.github.com/repos/PhilipRosedale/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/PhilipRosedale/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/PhilipRosedale/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/PhilipRosedale/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PhilipRosedale/hifi/labels{/name}","releases_url":"https://api.github.com/repos/PhilipRosedale/hifi/releases{/id}","created_at":"2013-04-12T00:23:00Z","updated_at":"2014-06-25T22:20:11Z","pushed_at":"2014-09-24T23:38:04Z","git_url":"git://github.com/PhilipRosedale/hifi.git","ssh_url":"git@github.com:PhilipRosedale/hifi.git","clone_url":"https://github.com/PhilipRosedale/hifi.git","svn_url":"https://github.com/PhilipRosedale/hifi","homepage":"","size":118368,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"e485b278ef513b26a28e8ea31a08d7e9d00e2130","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=2","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=2","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open, decentralized virtual worlds using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.io/jobs  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/{number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2014-09-25T13:24:36Z","pushed_at":"2014-09-25T16:26:02Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":178055,"stargazers_count":200,"watchers_count":200,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":119,"mirror_url":null,"open_issues_count":53,"forks":119,"open_issues":53,"watchers":200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/3479"},"html":{"href":"https://github.com/highfidelity/hifi/pull/3479"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/3479"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/3479/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/3479/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/3479/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/fcc5eb9d0af9ffa31c1d76af2bcf0d53e7fad282"}}}}