GitHub PullRequestReviewCommentEvent at 2014-10-10 21:44:34
Repository: puppet
Actor: ferventcoder
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/18732769","id":18732769,"diff_hunk":"@@ -289,6 +329,14 @@ def get(name)\n       end\n     end\n \n+    # @!macro loader_get_or_fail\n+    def get!(name)\n+      if !environment = get(name)\n+        raise EnvironmentNotFound, name\n+      end\n+      environment\n+    end\n+","path":"lib/puppet/environments.rb","position":86,"original_position":86,"commit_id":"19832b23f18216cfd557ac9b26a3fbc886b94147","original_commit_id":"19832b23f18216cfd557ac9b26a3fbc886b94147","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=2","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"body":"@jpartlow It appears that the Combined#get! just calls over to get, so it works nicely.","created_at":"2014-10-10T21:44:34Z","updated_at":"2014-10-10T21:44:34Z","html_url":"https://github.com/puppetlabs/puppet/pull/3146#discussion_r18732769","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3146","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/18732769"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3146#discussion_r18732769"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3146"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3146","id":22085440,"html_url":"https://github.com/puppetlabs/puppet/pull/3146","diff_url":"https://github.com/puppetlabs/puppet/pull/3146.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3146.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3146","number":3146,"state":"closed","locked":false,"title":"(PUP-3244) ENC ignores missing directory environments","user":{"login":"demophoon","id":1445303,"avatar_url":"https://avatars.githubusercontent.com/u/1445303?v=2","gravatar_id":"","url":"https://api.github.com/users/demophoon","html_url":"https://github.com/demophoon","followers_url":"https://api.github.com/users/demophoon/followers","following_url":"https://api.github.com/users/demophoon/following{/other_user}","gists_url":"https://api.github.com/users/demophoon/gists{/gist_id}","starred_url":"https://api.github.com/users/demophoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demophoon/subscriptions","organizations_url":"https://api.github.com/users/demophoon/orgs","repos_url":"https://api.github.com/users/demophoon/repos","events_url":"https://api.github.com/users/demophoon/events{/privacy}","received_events_url":"https://api.github.com/users/demophoon/received_events","type":"User","site_admin":false},"body":"When using an ENC, if an environment that didn't exist was defined for a\r\nnode puppet would place the node into the production environment instead\r\nof raising an error to alert the user that the environment that had been\r\nrequested did not exist.\r\n\r\nThis commit changes the behavior when an environment is defined in an\r\nENC but does not actually exist. Instead of placing the node into the\r\nproduction environment a Puppet::Environments::EnvironmentNotFound error\r\nis raised.","created_at":"2014-10-01T16:29:06Z","updated_at":"2014-10-10T21:44:34Z","closed_at":"2014-10-10T18:37:26Z","merged_at":"2014-10-10T18:37:26Z","merge_commit_sha":"8adccb224642f20d0a2be6ed703031c78cc5add3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3146/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3146/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3146/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/19832b23f18216cfd557ac9b26a3fbc886b94147","head":{"label":"demophoon:fix/stable/pup-3244-enc-missing-directory-environment","ref":"fix/stable/pup-3244-enc-missing-directory-environment","sha":"19832b23f18216cfd557ac9b26a3fbc886b94147","user":{"login":"demophoon","id":1445303,"avatar_url":"https://avatars.githubusercontent.com/u/1445303?v=2","gravatar_id":"","url":"https://api.github.com/users/demophoon","html_url":"https://github.com/demophoon","followers_url":"https://api.github.com/users/demophoon/followers","following_url":"https://api.github.com/users/demophoon/following{/other_user}","gists_url":"https://api.github.com/users/demophoon/gists{/gist_id}","starred_url":"https://api.github.com/users/demophoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demophoon/subscriptions","organizations_url":"https://api.github.com/users/demophoon/orgs","repos_url":"https://api.github.com/users/demophoon/repos","events_url":"https://api.github.com/users/demophoon/events{/privacy}","received_events_url":"https://api.github.com/users/demophoon/received_events","type":"User","site_admin":false},"repo":{"id":22936820,"name":"puppet","full_name":"demophoon/puppet","owner":{"login":"demophoon","id":1445303,"avatar_url":"https://avatars.githubusercontent.com/u/1445303?v=2","gravatar_id":"","url":"https://api.github.com/users/demophoon","html_url":"https://github.com/demophoon","followers_url":"https://api.github.com/users/demophoon/followers","following_url":"https://api.github.com/users/demophoon/following{/other_user}","gists_url":"https://api.github.com/users/demophoon/gists{/gist_id}","starred_url":"https://api.github.com/users/demophoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demophoon/subscriptions","organizations_url":"https://api.github.com/users/demophoon/orgs","repos_url":"https://api.github.com/users/demophoon/repos","events_url":"https://api.github.com/users/demophoon/events{/privacy}","received_events_url":"https://api.github.com/users/demophoon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/demophoon/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/demophoon/puppet","forks_url":"https://api.github.com/repos/demophoon/puppet/forks","keys_url":"https://api.github.com/repos/demophoon/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/demophoon/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/demophoon/puppet/teams","hooks_url":"https://api.github.com/repos/demophoon/puppet/hooks","issue_events_url":"https://api.github.com/repos/demophoon/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/demophoon/puppet/events","assignees_url":"https://api.github.com/repos/demophoon/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/demophoon/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/demophoon/puppet/tags","blobs_url":"https://api.github.com/repos/demophoon/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/demophoon/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/demophoon/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/demophoon/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/demophoon/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/demophoon/puppet/languages","stargazers_url":"https://api.github.com/repos/demophoon/puppet/stargazers","contributors_url":"https://api.github.com/repos/demophoon/puppet/contributors","subscribers_url":"https://api.github.com/repos/demophoon/puppet/subscribers","subscription_url":"https://api.github.com/repos/demophoon/puppet/subscription","commits_url":"https://api.github.com/repos/demophoon/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/demophoon/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/demophoon/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/demophoon/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/demophoon/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/demophoon/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/demophoon/puppet/merges","archive_url":"https://api.github.com/repos/demophoon/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/demophoon/puppet/downloads","issues_url":"https://api.github.com/repos/demophoon/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/demophoon/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/demophoon/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/demophoon/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/demophoon/puppet/labels{/name}","releases_url":"https://api.github.com/repos/demophoon/puppet/releases{/id}","created_at":"2014-08-14T01:15:41Z","updated_at":"2014-08-15T20:43:38Z","pushed_at":"2014-10-08T23:50:04Z","git_url":"git://github.com/demophoon/puppet.git","ssh_url":"git@github.com:demophoon/puppet.git","clone_url":"https://github.com/demophoon/puppet.git","svn_url":"https://github.com/demophoon/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":42255,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"71add0db9fb0583589c52fdfc15f3937ebf493ff","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2014-10-10T15:16:44Z","pushed_at":"2014-10-10T21:23:33Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":112123,"stargazers_count":2637,"watchers_count":2637,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1177,"mirror_url":null,"open_issues_count":55,"forks":1177,"open_issues":55,"watchers":2637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3146"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3146"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3146"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3146/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3146/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3146/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/19832b23f18216cfd557ac9b26a3fbc886b94147"}}}}