GitHub PullRequestEvent at 2014-06-02 03:19:32
Repository: WebODF
Actor: peitschie
Payload: {"action":"opened","number":620,"pull_request":{"url":"https://api.github.com/repos/kogmbh/WebODF/pulls/620","id":16582621,"html_url":"https://github.com/kogmbh/WebODF/pull/620","diff_url":"https://github.com/kogmbh/WebODF/pull/620.diff","patch_url":"https://github.com/kogmbh/WebODF/pull/620.patch","issue_url":"https://api.github.com/repos/kogmbh/WebODF/issues/620","number":620,"state":"open","title":"Ensure a caret doesn't receive any new events after destroy is invoked","user":{"login":"peitschie","id":1052079,"avatar_url":"https://avatars.githubusercontent.com/u/1052079?","gravatar_id":"70426f4264cf967a2b2215b73a625717","url":"https://api.github.com/users/peitschie","html_url":"https://github.com/peitschie","followers_url":"https://api.github.com/users/peitschie/followers","following_url":"https://api.github.com/users/peitschie/following{/other_user}","gists_url":"https://api.github.com/users/peitschie/gists{/gist_id}","starred_url":"https://api.github.com/users/peitschie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peitschie/subscriptions","organizations_url":"https://api.github.com/users/peitschie/orgs","repos_url":"https://api.github.com/users/peitschie/repos","events_url":"https://api.github.com/users/peitschie/events{/privacy}","received_events_url":"https://api.github.com/users/peitschie/received_events","type":"User","site_admin":false},"body":"Deleting the caret before calling ensures there is no way for any external sources to get access to the soon-to-be destroyed caret.\r\n\r\nAs part of tracking this down, scheduled tasks will now throw an error if an attempt is made to trigger the task (either delayed or immediate) after the particular instance has been destroyed.\r\n\r\nThis then showed that functions bound to browser events swallow errors quietly, so additional logging was added to the EventManager delegation code to ensure errors generated when processing an event are logged.","created_at":"2014-06-02T03:19:31Z","updated_at":"2014-06-02T03:19:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kogmbh/WebODF/pulls/620/commits","review_comments_url":"https://api.github.com/repos/kogmbh/WebODF/pulls/620/comments","review_comment_url":"https://api.github.com/repos/kogmbh/WebODF/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kogmbh/WebODF/issues/620/comments","statuses_url":"https://api.github.com/repos/kogmbh/WebODF/statuses/c18534744dbf12f1bcf54b861bd0e9135cbae961","head":{"label":"peitschie:caret-destroy-fixup","ref":"caret-destroy-fixup","sha":"c18534744dbf12f1bcf54b861bd0e9135cbae961","user":{"login":"peitschie","id":1052079,"avatar_url":"https://avatars.githubusercontent.com/u/1052079?","gravatar_id":"70426f4264cf967a2b2215b73a625717","url":"https://api.github.com/users/peitschie","html_url":"https://github.com/peitschie","followers_url":"https://api.github.com/users/peitschie/followers","following_url":"https://api.github.com/users/peitschie/following{/other_user}","gists_url":"https://api.github.com/users/peitschie/gists{/gist_id}","starred_url":"https://api.github.com/users/peitschie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peitschie/subscriptions","organizations_url":"https://api.github.com/users/peitschie/orgs","repos_url":"https://api.github.com/users/peitschie/repos","events_url":"https://api.github.com/users/peitschie/events{/privacy}","received_events_url":"https://api.github.com/users/peitschie/received_events","type":"User","site_admin":false},"repo":{"id":13050247,"name":"WebODF","full_name":"peitschie/WebODF","owner":{"login":"peitschie","id":1052079,"avatar_url":"https://avatars.githubusercontent.com/u/1052079?","gravatar_id":"70426f4264cf967a2b2215b73a625717","url":"https://api.github.com/users/peitschie","html_url":"https://github.com/peitschie","followers_url":"https://api.github.com/users/peitschie/followers","following_url":"https://api.github.com/users/peitschie/following{/other_user}","gists_url":"https://api.github.com/users/peitschie/gists{/gist_id}","starred_url":"https://api.github.com/users/peitschie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peitschie/subscriptions","organizations_url":"https://api.github.com/users/peitschie/orgs","repos_url":"https://api.github.com/users/peitschie/repos","events_url":"https://api.github.com/users/peitschie/events{/privacy}","received_events_url":"https://api.github.com/users/peitschie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peitschie/WebODF","description":"WebODF - JavaScript Document Engine","fork":true,"url":"https://api.github.com/repos/peitschie/WebODF","forks_url":"https://api.github.com/repos/peitschie/WebODF/forks","keys_url":"https://api.github.com/repos/peitschie/WebODF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peitschie/WebODF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peitschie/WebODF/teams","hooks_url":"https://api.github.com/repos/peitschie/WebODF/hooks","issue_events_url":"https://api.github.com/repos/peitschie/WebODF/issues/events{/number}","events_url":"https://api.github.com/repos/peitschie/WebODF/events","assignees_url":"https://api.github.com/repos/peitschie/WebODF/assignees{/user}","branches_url":"https://api.github.com/repos/peitschie/WebODF/branches{/branch}","tags_url":"https://api.github.com/repos/peitschie/WebODF/tags","blobs_url":"https://api.github.com/repos/peitschie/WebODF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peitschie/WebODF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peitschie/WebODF/git/refs{/sha}","trees_url":"https://api.github.com/repos/peitschie/WebODF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peitschie/WebODF/statuses/{sha}","languages_url":"https://api.github.com/repos/peitschie/WebODF/languages","stargazers_url":"https://api.github.com/repos/peitschie/WebODF/stargazers","contributors_url":"https://api.github.com/repos/peitschie/WebODF/contributors","subscribers_url":"https://api.github.com/repos/peitschie/WebODF/subscribers","subscription_url":"https://api.github.com/repos/peitschie/WebODF/subscription","commits_url":"https://api.github.com/repos/peitschie/WebODF/commits{/sha}","git_commits_url":"https://api.github.com/repos/peitschie/WebODF/git/commits{/sha}","comments_url":"https://api.github.com/repos/peitschie/WebODF/comments{/number}","issue_comment_url":"https://api.github.com/repos/peitschie/WebODF/issues/comments/{number}","contents_url":"https://api.github.com/repos/peitschie/WebODF/contents/{+path}","compare_url":"https://api.github.com/repos/peitschie/WebODF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peitschie/WebODF/merges","archive_url":"https://api.github.com/repos/peitschie/WebODF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peitschie/WebODF/downloads","issues_url":"https://api.github.com/repos/peitschie/WebODF/issues{/number}","pulls_url":"https://api.github.com/repos/peitschie/WebODF/pulls{/number}","milestones_url":"https://api.github.com/repos/peitschie/WebODF/milestones{/number}","notifications_url":"https://api.github.com/repos/peitschie/WebODF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peitschie/WebODF/labels{/name}","releases_url":"https://api.github.com/repos/peitschie/WebODF/releases{/id}","created_at":"2013-09-23T23:58:04Z","updated_at":"2014-06-02T03:19:31Z","pushed_at":"2014-06-02T03:11:25Z","git_url":"git://github.com/peitschie/WebODF.git","ssh_url":"git@github.com:peitschie/WebODF.git","clone_url":"https://github.com/peitschie/WebODF.git","svn_url":"https://github.com/peitschie/WebODF","homepage":"http://webodf.org/","size":19923,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","permissions":{"admin":false,"push":false,"pull":true}}},"base":{"label":"kogmbh:master","ref":"master","sha":"7cf87ec7e49619b7dbc095c62b043ae806713aca","user":{"login":"kogmbh","id":5339633,"avatar_url":"https://avatars.githubusercontent.com/u/5339633?","gravatar_id":"810370be3827ed25626c4b574a90a1dd","url":"https://api.github.com/users/kogmbh","html_url":"https://github.com/kogmbh","followers_url":"https://api.github.com/users/kogmbh/followers","following_url":"https://api.github.com/users/kogmbh/following{/other_user}","gists_url":"https://api.github.com/users/kogmbh/gists{/gist_id}","starred_url":"https://api.github.com/users/kogmbh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kogmbh/subscriptions","organizations_url":"https://api.github.com/users/kogmbh/orgs","repos_url":"https://api.github.com/users/kogmbh/repos","events_url":"https://api.github.com/users/kogmbh/events{/privacy}","received_events_url":"https://api.github.com/users/kogmbh/received_events","type":"Organization","site_admin":false},"repo":{"id":12957983,"name":"WebODF","full_name":"kogmbh/WebODF","owner":{"login":"kogmbh","id":5339633,"avatar_url":"https://avatars.githubusercontent.com/u/5339633?","gravatar_id":"810370be3827ed25626c4b574a90a1dd","url":"https://api.github.com/users/kogmbh","html_url":"https://github.com/kogmbh","followers_url":"https://api.github.com/users/kogmbh/followers","following_url":"https://api.github.com/users/kogmbh/following{/other_user}","gists_url":"https://api.github.com/users/kogmbh/gists{/gist_id}","starred_url":"https://api.github.com/users/kogmbh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kogmbh/subscriptions","organizations_url":"https://api.github.com/users/kogmbh/orgs","repos_url":"https://api.github.com/users/kogmbh/repos","events_url":"https://api.github.com/users/kogmbh/events{/privacy}","received_events_url":"https://api.github.com/users/kogmbh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kogmbh/WebODF","description":"WebODF - JavaScript Document Engine","fork":false,"url":"https://api.github.com/repos/kogmbh/WebODF","forks_url":"https://api.github.com/repos/kogmbh/WebODF/forks","keys_url":"https://api.github.com/repos/kogmbh/WebODF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kogmbh/WebODF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kogmbh/WebODF/teams","hooks_url":"https://api.github.com/repos/kogmbh/WebODF/hooks","issue_events_url":"https://api.github.com/repos/kogmbh/WebODF/issues/events{/number}","events_url":"https://api.github.com/repos/kogmbh/WebODF/events","assignees_url":"https://api.github.com/repos/kogmbh/WebODF/assignees{/user}","branches_url":"https://api.github.com/repos/kogmbh/WebODF/branches{/branch}","tags_url":"https://api.github.com/repos/kogmbh/WebODF/tags","blobs_url":"https://api.github.com/repos/kogmbh/WebODF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kogmbh/WebODF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kogmbh/WebODF/git/refs{/sha}","trees_url":"https://api.github.com/repos/kogmbh/WebODF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kogmbh/WebODF/statuses/{sha}","languages_url":"https://api.github.com/repos/kogmbh/WebODF/languages","stargazers_url":"https://api.github.com/repos/kogmbh/WebODF/stargazers","contributors_url":"https://api.github.com/repos/kogmbh/WebODF/contributors","subscribers_url":"https://api.github.com/repos/kogmbh/WebODF/subscribers","subscription_url":"https://api.github.com/repos/kogmbh/WebODF/subscription","commits_url":"https://api.github.com/repos/kogmbh/WebODF/commits{/sha}","git_commits_url":"https://api.github.com/repos/kogmbh/WebODF/git/commits{/sha}","comments_url":"https://api.github.com/repos/kogmbh/WebODF/comments{/number}","issue_comment_url":"https://api.github.com/repos/kogmbh/WebODF/issues/comments/{number}","contents_url":"https://api.github.com/repos/kogmbh/WebODF/contents/{+path}","compare_url":"https://api.github.com/repos/kogmbh/WebODF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kogmbh/WebODF/merges","archive_url":"https://api.github.com/repos/kogmbh/WebODF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kogmbh/WebODF/downloads","issues_url":"https://api.github.com/repos/kogmbh/WebODF/issues{/number}","pulls_url":"https://api.github.com/repos/kogmbh/WebODF/pulls{/number}","milestones_url":"https://api.github.com/repos/kogmbh/WebODF/milestones{/number}","notifications_url":"https://api.github.com/repos/kogmbh/WebODF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kogmbh/WebODF/labels{/name}","releases_url":"https://api.github.com/repos/kogmbh/WebODF/releases{/id}","created_at":"2013-09-19T19:57:49Z","updated_at":"2014-05-28T13:27:20Z","pushed_at":"2014-05-28T13:27:20Z","git_url":"git://github.com/kogmbh/WebODF.git","ssh_url":"git@github.com:kogmbh/WebODF.git","clone_url":"https://github.com/kogmbh/WebODF.git","svn_url":"https://github.com/kogmbh/WebODF","homepage":"http://webodf.org/","size":21326,"stargazers_count":174,"watchers_count":174,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":34,"mirror_url":null,"open_issues_count":163,"forks":34,"open_issues":163,"watchers":174,"default_branch":"master","permissions":{"admin":false,"push":false,"pull":true}}},"_links":{"self":{"href":"https://api.github.com/repos/kogmbh/WebODF/pulls/620"},"html":{"href":"https://github.com/kogmbh/WebODF/pull/620"},"issue":{"href":"https://api.github.com/repos/kogmbh/WebODF/issues/620"},"comments":{"href":"https://api.github.com/repos/kogmbh/WebODF/issues/620/comments"},"review_comments":{"href":"https://api.github.com/repos/kogmbh/WebODF/pulls/620/comments"},"review_comment":{"href":"https://api.github.com/repos/kogmbh/WebODF/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kogmbh/WebODF/pulls/620/commits"},"statuses":{"href":"https://api.github.com/repos/kogmbh/WebODF/statuses/c18534744dbf12f1bcf54b861bd0e9135cbae961"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":25,"deletions":5,"changed_files":3}}