GitHub PullRequestReviewCommentEvent at 2014-09-17 17:48:41
Repository: scielo-manager
Actor: jamilatta
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/scieloorg/scielo-manager/pulls/comments/17680856","id":17680856,"diff_hunk":"@@ -63,6 +81,134 @@ def edit_journal(request, journal_id):\n \n \n @permission_required('journalmanager.list_editor_journal', login_url=settings.AUTHZ_REDIRECT_URL)\n-def board(request):\n-    return render_to_response('board/board_list.html', {},\n+def board(request, journal_id):\n+    journal = get_object_or_404(Journal.userobjects.active(), id=journal_id)\n+    issues = journal.issue_set.all().order_by('-publication_year', '-volume', '-number')\n+    latest_issue = issues[0]","path":"scielomanager/editorialmanager/views.py","position":69,"original_position":69,"commit_id":"b6ffa3549f42d5efc1d849877c93801b632eb351","original_commit_id":"b6ffa3549f42d5efc1d849877c93801b632eb351","user":{"login":"jamilatta","id":373745,"avatar_url":"https://avatars.githubusercontent.com/u/373745?v=2","gravatar_id":"74ccef328abd9bcfd9035aa179510a24","url":"https://api.github.com/users/jamilatta","html_url":"https://github.com/jamilatta","followers_url":"https://api.github.com/users/jamilatta/followers","following_url":"https://api.github.com/users/jamilatta/following{/other_user}","gists_url":"https://api.github.com/users/jamilatta/gists{/gist_id}","starred_url":"https://api.github.com/users/jamilatta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamilatta/subscriptions","organizations_url":"https://api.github.com/users/jamilatta/orgs","repos_url":"https://api.github.com/users/jamilatta/repos","events_url":"https://api.github.com/users/jamilatta/events{/privacy}","received_events_url":"https://api.github.com/users/jamilatta/received_events","type":"User","site_admin":false},"body":"Na linha 86 estamos assumindo que sempre existe fascículos para a revista em questão, porém devemos garantir que não aconteça uma exceção caso contrário. Talvez poderíamos substituir pelo método adicionado no PR: https://github.com/scieloorg/scielo-manager/pull/972 (get_last_issue) que retorna o último fascículo ou None (caso não exista).\r\n\r\nNa linha 85 devemos garantir que seja retornado somente revistas que esta relacionado com o usuário (Talvez essa mudança deva acontecer após aprovação do PR: https://github.com/scieloorg/scielo-manager/pull/963), que cria a relação com o \"editor chefe\" da revista.\r\n\r\nSugiro também a remoção dos comentários.\r\n","created_at":"2014-09-17T17:48:41Z","updated_at":"2014-09-17T17:48:41Z","html_url":"https://github.com/scieloorg/scielo-manager/pull/973#discussion_r17680856","pull_request_url":"https://api.github.com/repos/scieloorg/scielo-manager/pulls/973","_links":{"self":{"href":"https://api.github.com/repos/scieloorg/scielo-manager/pulls/comments/17680856"},"html":{"href":"https://github.com/scieloorg/scielo-manager/pull/973#discussion_r17680856"},"pull_request":{"href":"https://api.github.com/repos/scieloorg/scielo-manager/pulls/973"}}},"pull_request":{"url":"https://api.github.com/repos/scieloorg/scielo-manager/pulls/973","id":21334871,"html_url":"https://github.com/scieloorg/scielo-manager/pull/973","diff_url":"https://github.com/scieloorg/scielo-manager/pull/973.diff","patch_url":"https://github.com/scieloorg/scielo-manager/pull/973.patch","issue_url":"https://api.github.com/repos/scieloorg/scielo-manager/issues/973","number":973,"state":"open","locked":false,"title":"961 crud board members","user":{"login":"jfunez","id":805749,"avatar_url":"https://avatars.githubusercontent.com/u/805749?v=2","gravatar_id":"358c518b80791fb26d015706554eb340","url":"https://api.github.com/users/jfunez","html_url":"https://github.com/jfunez","followers_url":"https://api.github.com/users/jfunez/followers","following_url":"https://api.github.com/users/jfunez/following{/other_user}","gists_url":"https://api.github.com/users/jfunez/gists{/gist_id}","starred_url":"https://api.github.com/users/jfunez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfunez/subscriptions","organizations_url":"https://api.github.com/users/jfunez/orgs","repos_url":"https://api.github.com/users/jfunez/repos","events_url":"https://api.github.com/users/jfunez/events{/privacy}","received_events_url":"https://api.github.com/users/jfunez/received_events","type":"User","site_admin":false},"body":"Fixes: #961:\r\n\r\n- listado dinamico de issue/board/members\r\n- formulario de edição de members\r\n- formualrio de criação\r\n- ajustes no modal para suportar forms\r\n- novas views para editar/adicionar membros do board, caso que o issue não tenha membros, cria um novo.\r\n- bootstrap modal com botão para aumentar/desminuir tamanho\r\n- adiciono mensagens de erro no inclusion tag: show_field (field.html)\r\n- adiciono campo ``wieght`` para ordenação de RoleType no listado.\r\n- merge para atualizar o novo em **scielo-manager/beta**\r\n- arquivo de migração 2, renomeado\r\n- listado de membros do corpo editorial, agora usando a relação OneToOne\r\n- fix, modal resize button\r\n- [views.py] agora consulta o board, utiilza a relação OneToOne\r\n- adiciono funcionalidade de Delete, para apagar membros do board.\r\n","created_at":"2014-09-16T22:56:18Z","updated_at":"2014-09-17T17:48:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0fb58afb9962c9f8030bd27ba1749e8680c4917","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scieloorg/scielo-manager/pulls/973/commits","review_comments_url":"https://api.github.com/repos/scieloorg/scielo-manager/pulls/973/comments","review_comment_url":"https://api.github.com/repos/scieloorg/scielo-manager/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scieloorg/scielo-manager/issues/973/comments","statuses_url":"https://api.github.com/repos/scieloorg/scielo-manager/statuses/b6ffa3549f42d5efc1d849877c93801b632eb351","head":{"label":"jfunez:961_crud_board_members","ref":"961_crud_board_members","sha":"b6ffa3549f42d5efc1d849877c93801b632eb351","user":{"login":"jfunez","id":805749,"avatar_url":"https://avatars.githubusercontent.com/u/805749?v=2","gravatar_id":"358c518b80791fb26d015706554eb340","url":"https://api.github.com/users/jfunez","html_url":"https://github.com/jfunez","followers_url":"https://api.github.com/users/jfunez/followers","following_url":"https://api.github.com/users/jfunez/following{/other_user}","gists_url":"https://api.github.com/users/jfunez/gists{/gist_id}","starred_url":"https://api.github.com/users/jfunez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfunez/subscriptions","organizations_url":"https://api.github.com/users/jfunez/orgs","repos_url":"https://api.github.com/users/jfunez/repos","events_url":"https://api.github.com/users/jfunez/events{/privacy}","received_events_url":"https://api.github.com/users/jfunez/received_events","type":"User","site_admin":false},"repo":{"id":16479824,"name":"scielo-manager","full_name":"jfunez/scielo-manager","owner":{"login":"jfunez","id":805749,"avatar_url":"https://avatars.githubusercontent.com/u/805749?v=2","gravatar_id":"358c518b80791fb26d015706554eb340","url":"https://api.github.com/users/jfunez","html_url":"https://github.com/jfunez","followers_url":"https://api.github.com/users/jfunez/followers","following_url":"https://api.github.com/users/jfunez/following{/other_user}","gists_url":"https://api.github.com/users/jfunez/gists{/gist_id}","starred_url":"https://api.github.com/users/jfunez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfunez/subscriptions","organizations_url":"https://api.github.com/users/jfunez/orgs","repos_url":"https://api.github.com/users/jfunez/repos","events_url":"https://api.github.com/users/jfunez/events{/privacy}","received_events_url":"https://api.github.com/users/jfunez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jfunez/scielo-manager","description":"Web version of PC-Programs","fork":true,"url":"https://api.github.com/repos/jfunez/scielo-manager","forks_url":"https://api.github.com/repos/jfunez/scielo-manager/forks","keys_url":"https://api.github.com/repos/jfunez/scielo-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jfunez/scielo-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jfunez/scielo-manager/teams","hooks_url":"https://api.github.com/repos/jfunez/scielo-manager/hooks","issue_events_url":"https://api.github.com/repos/jfunez/scielo-manager/issues/events{/number}","events_url":"https://api.github.com/repos/jfunez/scielo-manager/events","assignees_url":"https://api.github.com/repos/jfunez/scielo-manager/assignees{/user}","branches_url":"https://api.github.com/repos/jfunez/scielo-manager/branches{/branch}","tags_url":"https://api.github.com/repos/jfunez/scielo-manager/tags","blobs_url":"https://api.github.com/repos/jfunez/scielo-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jfunez/scielo-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jfunez/scielo-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/jfunez/scielo-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jfunez/scielo-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/jfunez/scielo-manager/languages","stargazers_url":"https://api.github.com/repos/jfunez/scielo-manager/stargazers","contributors_url":"https://api.github.com/repos/jfunez/scielo-manager/contributors","subscribers_url":"https://api.github.com/repos/jfunez/scielo-manager/subscribers","subscription_url":"https://api.github.com/repos/jfunez/scielo-manager/subscription","commits_url":"https://api.github.com/repos/jfunez/scielo-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/jfunez/scielo-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/jfunez/scielo-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/jfunez/scielo-manager/issues/comments/{number}","contents_url":"https://api.github.com/repos/jfunez/scielo-manager/contents/{+path}","compare_url":"https://api.github.com/repos/jfunez/scielo-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jfunez/scielo-manager/merges","archive_url":"https://api.github.com/repos/jfunez/scielo-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jfunez/scielo-manager/downloads","issues_url":"https://api.github.com/repos/jfunez/scielo-manager/issues{/number}","pulls_url":"https://api.github.com/repos/jfunez/scielo-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/jfunez/scielo-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/jfunez/scielo-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jfunez/scielo-manager/labels{/name}","releases_url":"https://api.github.com/repos/jfunez/scielo-manager/releases{/id}","created_at":"2014-02-03T13:13:52Z","updated_at":"2014-08-06T20:06:58Z","pushed_at":"2014-09-17T00:57:17Z","git_url":"git://github.com/jfunez/scielo-manager.git","ssh_url":"git@github.com:jfunez/scielo-manager.git","clone_url":"https://github.com/jfunez/scielo-manager.git","svn_url":"https://github.com/jfunez/scielo-manager","homepage":"","size":15193,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"scieloorg:beta","ref":"beta","sha":"4c38595fecc1e5af91a7893f05c9e4f56c96c98d","user":{"login":"scieloorg","id":505032,"avatar_url":"https://avatars.githubusercontent.com/u/505032?v=2","gravatar_id":"5720ed377fbe2f84cfe8d6973cfbea01","url":"https://api.github.com/users/scieloorg","html_url":"https://github.com/scieloorg","followers_url":"https://api.github.com/users/scieloorg/followers","following_url":"https://api.github.com/users/scieloorg/following{/other_user}","gists_url":"https://api.github.com/users/scieloorg/gists{/gist_id}","starred_url":"https://api.github.com/users/scieloorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scieloorg/subscriptions","organizations_url":"https://api.github.com/users/scieloorg/orgs","repos_url":"https://api.github.com/users/scieloorg/repos","events_url":"https://api.github.com/users/scieloorg/events{/privacy}","received_events_url":"https://api.github.com/users/scieloorg/received_events","type":"Organization","site_admin":false},"repo":{"id":1778118,"name":"scielo-manager","full_name":"scieloorg/scielo-manager","owner":{"login":"scieloorg","id":505032,"avatar_url":"https://avatars.githubusercontent.com/u/505032?v=2","gravatar_id":"5720ed377fbe2f84cfe8d6973cfbea01","url":"https://api.github.com/users/scieloorg","html_url":"https://github.com/scieloorg","followers_url":"https://api.github.com/users/scieloorg/followers","following_url":"https://api.github.com/users/scieloorg/following{/other_user}","gists_url":"https://api.github.com/users/scieloorg/gists{/gist_id}","starred_url":"https://api.github.com/users/scieloorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scieloorg/subscriptions","organizations_url":"https://api.github.com/users/scieloorg/orgs","repos_url":"https://api.github.com/users/scieloorg/repos","events_url":"https://api.github.com/users/scieloorg/events{/privacy}","received_events_url":"https://api.github.com/users/scieloorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scieloorg/scielo-manager","description":"Management tool for cataloging journals and articles, available in a SaaS model. It acts as a central metadata backbone for all the systems and services of SciELO.","fork":false,"url":"https://api.github.com/repos/scieloorg/scielo-manager","forks_url":"https://api.github.com/repos/scieloorg/scielo-manager/forks","keys_url":"https://api.github.com/repos/scieloorg/scielo-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scieloorg/scielo-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scieloorg/scielo-manager/teams","hooks_url":"https://api.github.com/repos/scieloorg/scielo-manager/hooks","issue_events_url":"https://api.github.com/repos/scieloorg/scielo-manager/issues/events{/number}","events_url":"https://api.github.com/repos/scieloorg/scielo-manager/events","assignees_url":"https://api.github.com/repos/scieloorg/scielo-manager/assignees{/user}","branches_url":"https://api.github.com/repos/scieloorg/scielo-manager/branches{/branch}","tags_url":"https://api.github.com/repos/scieloorg/scielo-manager/tags","blobs_url":"https://api.github.com/repos/scieloorg/scielo-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scieloorg/scielo-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scieloorg/scielo-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/scieloorg/scielo-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scieloorg/scielo-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/scieloorg/scielo-manager/languages","stargazers_url":"https://api.github.com/repos/scieloorg/scielo-manager/stargazers","contributors_url":"https://api.github.com/repos/scieloorg/scielo-manager/contributors","subscribers_url":"https://api.github.com/repos/scieloorg/scielo-manager/subscribers","subscription_url":"https://api.github.com/repos/scieloorg/scielo-manager/subscription","commits_url":"https://api.github.com/repos/scieloorg/scielo-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/scieloorg/scielo-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/scieloorg/scielo-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/scieloorg/scielo-manager/issues/comments/{number}","contents_url":"https://api.github.com/repos/scieloorg/scielo-manager/contents/{+path}","compare_url":"https://api.github.com/repos/scieloorg/scielo-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scieloorg/scielo-manager/merges","archive_url":"https://api.github.com/repos/scieloorg/scielo-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scieloorg/scielo-manager/downloads","issues_url":"https://api.github.com/repos/scieloorg/scielo-manager/issues{/number}","pulls_url":"https://api.github.com/repos/scieloorg/scielo-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/scieloorg/scielo-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/scieloorg/scielo-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scieloorg/scielo-manager/labels{/name}","releases_url":"https://api.github.com/repos/scieloorg/scielo-manager/releases{/id}","created_at":"2011-05-20T19:41:53Z","updated_at":"2014-09-08T19:43:00Z","pushed_at":"2014-09-15T21:03:51Z","git_url":"git://github.com/scieloorg/scielo-manager.git","ssh_url":"git@github.com:scieloorg/scielo-manager.git","clone_url":"https://github.com/scieloorg/scielo-manager.git","svn_url":"https://github.com/scieloorg/scielo-manager","homepage":"http://docs.scielo.org/projects/scielo-manager/en/latest/","size":20506,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":55,"forks":7,"open_issues":55,"watchers":8,"default_branch":"beta"}},"_links":{"self":{"href":"https://api.github.com/repos/scieloorg/scielo-manager/pulls/973"},"html":{"href":"https://github.com/scieloorg/scielo-manager/pull/973"},"issue":{"href":"https://api.github.com/repos/scieloorg/scielo-manager/issues/973"},"comments":{"href":"https://api.github.com/repos/scieloorg/scielo-manager/issues/973/comments"},"review_comments":{"href":"https://api.github.com/repos/scieloorg/scielo-manager/pulls/973/comments"},"review_comment":{"href":"https://api.github.com/repos/scieloorg/scielo-manager/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scieloorg/scielo-manager/pulls/973/commits"},"statuses":{"href":"https://api.github.com/repos/scieloorg/scielo-manager/statuses/b6ffa3549f42d5efc1d849877c93801b632eb351"}}}}