GitHub PullRequestReviewCommentEvent at 2014-11-12 18:59:07
Repository: fusion
Actor: ldionne
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/boostorg/fusion/pulls/comments/20241179","id":20241179,"diff_hunk":"@@ -127,7 +127,9 @@ namespace boost { namespace fusion\n         {}\n \n #if !defined(BOOST_NO_CXX11_RVALUE_REFERENCES)\n-        template <typename Head_, typename ...Tail_>\n+        template <typename Head_, typename ...Tail_, typename =\n+            typename enable_if<is_convertible<Head_, Head> >::type\n+        >\n         BOOST_FUSION_GPU_ENABLED\n         explicit deque(Head_&& head, Tail_&&... tail)","path":"include/boost/fusion/container/deque/deque.hpp","position":9,"original_position":9,"commit_id":"4c03f7579b82b449d96ec518b05e9f7e7005e7a6","original_commit_id":"4c03f7579b82b449d96ec518b05e9f7e7005e7a6","user":{"login":"ldionne","id":700834,"avatar_url":"https://avatars.githubusercontent.com/u/700834?v=3","gravatar_id":"","url":"https://api.github.com/users/ldionne","html_url":"https://github.com/ldionne","followers_url":"https://api.github.com/users/ldionne/followers","following_url":"https://api.github.com/users/ldionne/following{/other_user}","gists_url":"https://api.github.com/users/ldionne/gists{/gist_id}","starred_url":"https://api.github.com/users/ldionne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldionne/subscriptions","organizations_url":"https://api.github.com/users/ldionne/orgs","repos_url":"https://api.github.com/users/ldionne/repos","events_url":"https://api.github.com/users/ldionne/events{/privacy}","received_events_url":"https://api.github.com/users/ldionne/received_events","type":"User","site_admin":false},"body":"Actually, I think this fix might be just the correct one; if more than one argument is passed to the constructor, the `Sequence const&` constructor below will be ignored anyway. So checking for convertibility of the `Head_` type only should be enough. Thoughts?","created_at":"2014-11-12T18:59:07Z","updated_at":"2014-11-12T18:59:07Z","html_url":"https://github.com/boostorg/fusion/pull/38#discussion_r20241179","pull_request_url":"https://api.github.com/repos/boostorg/fusion/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/boostorg/fusion/pulls/comments/20241179"},"html":{"href":"https://github.com/boostorg/fusion/pull/38#discussion_r20241179"},"pull_request":{"href":"https://api.github.com/repos/boostorg/fusion/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/boostorg/fusion/pulls/38","id":24315116,"html_url":"https://github.com/boostorg/fusion/pull/38","diff_url":"https://github.com/boostorg/fusion/pull/38.diff","patch_url":"https://github.com/boostorg/fusion/pull/38.patch","issue_url":"https://api.github.com/repos/boostorg/fusion/issues/38","number":38,"state":"open","locked":false,"title":"Fix compilation error with as_deque in C++11.","user":{"login":"ldionne","id":700834,"avatar_url":"https://avatars.githubusercontent.com/u/700834?v=3","gravatar_id":"","url":"https://api.github.com/users/ldionne","html_url":"https://github.com/ldionne","followers_url":"https://api.github.com/users/ldionne/followers","following_url":"https://api.github.com/users/ldionne/following{/other_user}","gists_url":"https://api.github.com/users/ldionne/gists{/gist_id}","starred_url":"https://api.github.com/users/ldionne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldionne/subscriptions","organizations_url":"https://api.github.com/users/ldionne/orgs","repos_url":"https://api.github.com/users/ldionne/repos","events_url":"https://api.github.com/users/ldionne/events{/privacy}","received_events_url":"https://api.github.com/users/ldionne/received_events","type":"User","site_admin":false},"body":"In C++11, `as_deque` did not compile for even simple use cases. I added a unit test and a fix (which is not 100% clean, see inline comments). With the patch applied, all the unit tests are passing on develop with Apple's Clang and -std=c++1y.","created_at":"2014-11-12T18:49:47Z","updated_at":"2014-11-12T18:59:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5f8fbcf38c2787597a78eea6137ccf2abcbf9e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boostorg/fusion/pulls/38/commits","review_comments_url":"https://api.github.com/repos/boostorg/fusion/pulls/38/comments","review_comment_url":"https://api.github.com/repos/boostorg/fusion/pulls/comments/{number}","comments_url":"https://api.github.com/repos/boostorg/fusion/issues/38/comments","statuses_url":"https://api.github.com/repos/boostorg/fusion/statuses/4c03f7579b82b449d96ec518b05e9f7e7005e7a6","head":{"label":"ldionne:develop","ref":"develop","sha":"4c03f7579b82b449d96ec518b05e9f7e7005e7a6","user":{"login":"ldionne","id":700834,"avatar_url":"https://avatars.githubusercontent.com/u/700834?v=3","gravatar_id":"","url":"https://api.github.com/users/ldionne","html_url":"https://github.com/ldionne","followers_url":"https://api.github.com/users/ldionne/followers","following_url":"https://api.github.com/users/ldionne/following{/other_user}","gists_url":"https://api.github.com/users/ldionne/gists{/gist_id}","starred_url":"https://api.github.com/users/ldionne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldionne/subscriptions","organizations_url":"https://api.github.com/users/ldionne/orgs","repos_url":"https://api.github.com/users/ldionne/repos","events_url":"https://api.github.com/users/ldionne/events{/privacy}","received_events_url":"https://api.github.com/users/ldionne/received_events","type":"User","site_admin":false},"repo":{"id":26490459,"name":"fusion","full_name":"ldionne/fusion","owner":{"login":"ldionne","id":700834,"avatar_url":"https://avatars.githubusercontent.com/u/700834?v=3","gravatar_id":"","url":"https://api.github.com/users/ldionne","html_url":"https://github.com/ldionne","followers_url":"https://api.github.com/users/ldionne/followers","following_url":"https://api.github.com/users/ldionne/following{/other_user}","gists_url":"https://api.github.com/users/ldionne/gists{/gist_id}","starred_url":"https://api.github.com/users/ldionne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldionne/subscriptions","organizations_url":"https://api.github.com/users/ldionne/orgs","repos_url":"https://api.github.com/users/ldionne/repos","events_url":"https://api.github.com/users/ldionne/events{/privacy}","received_events_url":"https://api.github.com/users/ldionne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ldionne/fusion","description":"Boost.org fusion module","fork":true,"url":"https://api.github.com/repos/ldionne/fusion","forks_url":"https://api.github.com/repos/ldionne/fusion/forks","keys_url":"https://api.github.com/repos/ldionne/fusion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldionne/fusion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldionne/fusion/teams","hooks_url":"https://api.github.com/repos/ldionne/fusion/hooks","issue_events_url":"https://api.github.com/repos/ldionne/fusion/issues/events{/number}","events_url":"https://api.github.com/repos/ldionne/fusion/events","assignees_url":"https://api.github.com/repos/ldionne/fusion/assignees{/user}","branches_url":"https://api.github.com/repos/ldionne/fusion/branches{/branch}","tags_url":"https://api.github.com/repos/ldionne/fusion/tags","blobs_url":"https://api.github.com/repos/ldionne/fusion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldionne/fusion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldionne/fusion/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldionne/fusion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldionne/fusion/statuses/{sha}","languages_url":"https://api.github.com/repos/ldionne/fusion/languages","stargazers_url":"https://api.github.com/repos/ldionne/fusion/stargazers","contributors_url":"https://api.github.com/repos/ldionne/fusion/contributors","subscribers_url":"https://api.github.com/repos/ldionne/fusion/subscribers","subscription_url":"https://api.github.com/repos/ldionne/fusion/subscription","commits_url":"https://api.github.com/repos/ldionne/fusion/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldionne/fusion/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldionne/fusion/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldionne/fusion/issues/comments/{number}","contents_url":"https://api.github.com/repos/ldionne/fusion/contents/{+path}","compare_url":"https://api.github.com/repos/ldionne/fusion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldionne/fusion/merges","archive_url":"https://api.github.com/repos/ldionne/fusion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldionne/fusion/downloads","issues_url":"https://api.github.com/repos/ldionne/fusion/issues{/number}","pulls_url":"https://api.github.com/repos/ldionne/fusion/pulls{/number}","milestones_url":"https://api.github.com/repos/ldionne/fusion/milestones{/number}","notifications_url":"https://api.github.com/repos/ldionne/fusion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldionne/fusion/labels{/name}","releases_url":"https://api.github.com/repos/ldionne/fusion/releases{/id}","created_at":"2014-11-11T15:17:17Z","updated_at":"2014-11-11T15:21:25Z","pushed_at":"2014-11-12T18:45:31Z","git_url":"git://github.com/ldionne/fusion.git","ssh_url":"git@github.com:ldionne/fusion.git","clone_url":"https://github.com/ldionne/fusion.git","svn_url":"https://github.com/ldionne/fusion","homepage":"http://boost.org/libs/fusion","size":14199,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boostorg:develop","ref":"develop","sha":"15dd9c9d976190f1e61007d93fb78a3af4946597","user":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"repo":{"id":7589969,"name":"fusion","full_name":"boostorg/fusion","owner":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boostorg/fusion","description":"Boost.org fusion module","fork":false,"url":"https://api.github.com/repos/boostorg/fusion","forks_url":"https://api.github.com/repos/boostorg/fusion/forks","keys_url":"https://api.github.com/repos/boostorg/fusion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boostorg/fusion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boostorg/fusion/teams","hooks_url":"https://api.github.com/repos/boostorg/fusion/hooks","issue_events_url":"https://api.github.com/repos/boostorg/fusion/issues/events{/number}","events_url":"https://api.github.com/repos/boostorg/fusion/events","assignees_url":"https://api.github.com/repos/boostorg/fusion/assignees{/user}","branches_url":"https://api.github.com/repos/boostorg/fusion/branches{/branch}","tags_url":"https://api.github.com/repos/boostorg/fusion/tags","blobs_url":"https://api.github.com/repos/boostorg/fusion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boostorg/fusion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boostorg/fusion/git/refs{/sha}","trees_url":"https://api.github.com/repos/boostorg/fusion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boostorg/fusion/statuses/{sha}","languages_url":"https://api.github.com/repos/boostorg/fusion/languages","stargazers_url":"https://api.github.com/repos/boostorg/fusion/stargazers","contributors_url":"https://api.github.com/repos/boostorg/fusion/contributors","subscribers_url":"https://api.github.com/repos/boostorg/fusion/subscribers","subscription_url":"https://api.github.com/repos/boostorg/fusion/subscription","commits_url":"https://api.github.com/repos/boostorg/fusion/commits{/sha}","git_commits_url":"https://api.github.com/repos/boostorg/fusion/git/commits{/sha}","comments_url":"https://api.github.com/repos/boostorg/fusion/comments{/number}","issue_comment_url":"https://api.github.com/repos/boostorg/fusion/issues/comments/{number}","contents_url":"https://api.github.com/repos/boostorg/fusion/contents/{+path}","compare_url":"https://api.github.com/repos/boostorg/fusion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boostorg/fusion/merges","archive_url":"https://api.github.com/repos/boostorg/fusion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boostorg/fusion/downloads","issues_url":"https://api.github.com/repos/boostorg/fusion/issues{/number}","pulls_url":"https://api.github.com/repos/boostorg/fusion/pulls{/number}","milestones_url":"https://api.github.com/repos/boostorg/fusion/milestones{/number}","notifications_url":"https://api.github.com/repos/boostorg/fusion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boostorg/fusion/labels{/name}","releases_url":"https://api.github.com/repos/boostorg/fusion/releases{/id}","created_at":"2013-01-13T15:59:07Z","updated_at":"2014-11-03T23:32:16Z","pushed_at":"2014-11-12T03:13:40Z","git_url":"git://github.com/boostorg/fusion.git","ssh_url":"git@github.com:boostorg/fusion.git","clone_url":"https://github.com/boostorg/fusion.git","svn_url":"https://github.com/boostorg/fusion","homepage":"http://boost.org/libs/fusion","size":21430,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":1,"forks":18,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boostorg/fusion/pulls/38"},"html":{"href":"https://github.com/boostorg/fusion/pull/38"},"issue":{"href":"https://api.github.com/repos/boostorg/fusion/issues/38"},"comments":{"href":"https://api.github.com/repos/boostorg/fusion/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/boostorg/fusion/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/boostorg/fusion/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/boostorg/fusion/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/boostorg/fusion/statuses/4c03f7579b82b449d96ec518b05e9f7e7005e7a6"}}}}