GitHub PullRequestReviewCommentEvent at 2014-08-02 09:55:05
Repository: dolphin
Actor: neobrain
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/15728395","id":15728395,"diff_hunk":"@@ -0,0 +1,110 @@\n+#include <set>\n+\n+#include \"Common/Common.h\"\n+#include \"VideoCommon/DataReader.h\"\n+#include \"VideoCommon/VertexLoader.h\"\n+\n+// Needs to be included later because it defines a TEST macro that conflicts\n+// with a TEST method definition in x64Emitter.h.\n+#include <gtest/gtest.h>  // NOLINT\n+\n+TEST(VertexLoaderUID, UniqueEnough)\n+{\n+\tstd::set<VertexLoaderUID> uids;","path":"Source/UnitTests/VideoCommon/VertexLoaderTest.cpp","position":13,"original_position":13,"commit_id":"56fa907c02a5ff106a63b12b297b68f9c6cc0e89","original_commit_id":"56fa907c02a5ff106a63b12b297b68f9c6cc0e89","user":{"login":"neobrain","id":4840017,"avatar_url":"https://avatars.githubusercontent.com/u/4840017?v=1","gravatar_id":"0e2ad4f720c57b96ab4bc6a24c2b59fd","url":"https://api.github.com/users/neobrain","html_url":"https://github.com/neobrain","followers_url":"https://api.github.com/users/neobrain/followers","following_url":"https://api.github.com/users/neobrain/following{/other_user}","gists_url":"https://api.github.com/users/neobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/neobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neobrain/subscriptions","organizations_url":"https://api.github.com/users/neobrain/orgs","repos_url":"https://api.github.com/users/neobrain/repos","events_url":"https://api.github.com/users/neobrain/events{/privacy}","received_events_url":"https://api.github.com/users/neobrain/received_events","type":"User","site_admin":false},"body":"Being unfamiliar with GoogleTest, what is the point of this `set`? I only see two tests happening in this function, and the `set` seems mostly irrelevant to them.","created_at":"2014-08-02T09:55:05Z","updated_at":"2014-08-02T09:55:05Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/716#discussion_r15728395","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/716","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/15728395"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/716#discussion_r15728395"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/716"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/716","id":19243649,"html_url":"https://github.com/dolphin-emu/dolphin/pull/716","diff_url":"https://github.com/dolphin-emu/dolphin/pull/716.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/716.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/716","number":716,"state":"open","title":"Make vertex loader testable","user":{"login":"delroth","id":202798,"avatar_url":"https://avatars.githubusercontent.com/u/202798?v=1","gravatar_id":"a7c333ee5d59519be7b757f917a950ba","url":"https://api.github.com/users/delroth","html_url":"https://github.com/delroth","followers_url":"https://api.github.com/users/delroth/followers","following_url":"https://api.github.com/users/delroth/following{/other_user}","gists_url":"https://api.github.com/users/delroth/gists{/gist_id}","starred_url":"https://api.github.com/users/delroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delroth/subscriptions","organizations_url":"https://api.github.com/users/delroth/orgs","repos_url":"https://api.github.com/users/delroth/repos","events_url":"https://api.github.com/users/delroth/events{/privacy}","received_events_url":"https://api.github.com/users/delroth/received_events","type":"User","site_admin":false},"body":"This branch contains some core refactorings and global dependencies removal to make VertexLoader testable. A sample unit test has been included, and while it does not test much (a simple position conversion test) it works fine, even testing JIT :)","created_at":"2014-08-02T06:44:18Z","updated_at":"2014-08-02T09:55:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7ba4cc0406cdc4911f02e4c17c86b823e3957e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/716/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/716/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/716/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/56fa907c02a5ff106a63b12b297b68f9c6cc0e89","head":{"label":"delroth:vertex-loader","ref":"vertex-loader","sha":"56fa907c02a5ff106a63b12b297b68f9c6cc0e89","user":{"login":"delroth","id":202798,"avatar_url":"https://avatars.githubusercontent.com/u/202798?v=1","gravatar_id":"a7c333ee5d59519be7b757f917a950ba","url":"https://api.github.com/users/delroth","html_url":"https://github.com/delroth","followers_url":"https://api.github.com/users/delroth/followers","following_url":"https://api.github.com/users/delroth/following{/other_user}","gists_url":"https://api.github.com/users/delroth/gists{/gist_id}","starred_url":"https://api.github.com/users/delroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delroth/subscriptions","organizations_url":"https://api.github.com/users/delroth/orgs","repos_url":"https://api.github.com/users/delroth/repos","events_url":"https://api.github.com/users/delroth/events{/privacy}","received_events_url":"https://api.github.com/users/delroth/received_events","type":"User","site_admin":false},"repo":{"id":11672060,"name":"dolphin","full_name":"delroth/dolphin","owner":{"login":"delroth","id":202798,"avatar_url":"https://avatars.githubusercontent.com/u/202798?v=1","gravatar_id":"a7c333ee5d59519be7b757f917a950ba","url":"https://api.github.com/users/delroth","html_url":"https://github.com/delroth","followers_url":"https://api.github.com/users/delroth/followers","following_url":"https://api.github.com/users/delroth/following{/other_user}","gists_url":"https://api.github.com/users/delroth/gists{/gist_id}","starred_url":"https://api.github.com/users/delroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delroth/subscriptions","organizations_url":"https://api.github.com/users/delroth/orgs","repos_url":"https://api.github.com/users/delroth/repos","events_url":"https://api.github.com/users/delroth/events{/privacy}","received_events_url":"https://api.github.com/users/delroth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/delroth/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/delroth/dolphin","forks_url":"https://api.github.com/repos/delroth/dolphin/forks","keys_url":"https://api.github.com/repos/delroth/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/delroth/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/delroth/dolphin/teams","hooks_url":"https://api.github.com/repos/delroth/dolphin/hooks","issue_events_url":"https://api.github.com/repos/delroth/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/delroth/dolphin/events","assignees_url":"https://api.github.com/repos/delroth/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/delroth/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/delroth/dolphin/tags","blobs_url":"https://api.github.com/repos/delroth/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/delroth/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/delroth/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/delroth/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/delroth/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/delroth/dolphin/languages","stargazers_url":"https://api.github.com/repos/delroth/dolphin/stargazers","contributors_url":"https://api.github.com/repos/delroth/dolphin/contributors","subscribers_url":"https://api.github.com/repos/delroth/dolphin/subscribers","subscription_url":"https://api.github.com/repos/delroth/dolphin/subscription","commits_url":"https://api.github.com/repos/delroth/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/delroth/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/delroth/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/delroth/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/delroth/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/delroth/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/delroth/dolphin/merges","archive_url":"https://api.github.com/repos/delroth/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/delroth/dolphin/downloads","issues_url":"https://api.github.com/repos/delroth/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/delroth/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/delroth/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/delroth/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/delroth/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/delroth/dolphin/releases{/id}","created_at":"2013-07-25T22:01:07Z","updated_at":"2014-07-10T00:54:47Z","pushed_at":"2014-08-02T07:27:26Z","git_url":"git://github.com/delroth/dolphin.git","ssh_url":"git@github.com:delroth/dolphin.git","clone_url":"https://github.com/delroth/dolphin.git","svn_url":"https://github.com/delroth/dolphin","homepage":null,"size":184198,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"7e83a0ea9be49abee3a4c8a2e953ca0905271434","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=1","gravatar_id":"889eb5c76644c10900f277bef9b7b516","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=1","gravatar_id":"889eb5c76644c10900f277bef9b7b516","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2014-08-02T01:35:54Z","pushed_at":"2014-08-02T03:57:44Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":null,"size":233302,"stargazers_count":405,"watchers_count":405,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":144,"mirror_url":null,"open_issues_count":39,"forks":144,"open_issues":39,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/716"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/716"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/716"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/716/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/716/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/716/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/56fa907c02a5ff106a63b12b297b68f9c6cc0e89"}}}}