GitHub PullRequestReviewCommentEvent at 2014-01-03 09:50:47
Repository: crosswalk
Actor: pozdnyakov
Payload: {"comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/8631387","id":8631387,"diff_hunk":"@@ -215,41 +218,43 @@ class ApplicationProtocolHandler\n       net::NetworkDelegate* network_delegate) const OVERRIDE;\n \n  private:\n-  const ApplicationData* application_;\n+  ApplicationService* service_;\n   DISALLOW_COPY_AND_ASSIGN(ApplicationProtocolHandler);\n };\n \n net::URLRequestJob*\n ApplicationProtocolHandler::MaybeCreateJob(\n     net::URLRequest* request, net::NetworkDelegate* network_delegate) const {\n-  std::string application_id = request->url().host();\n+  const std::string& application_id = request->url().host();","path":"application/browser/application_protocols.cc","position":68,"original_position":68,"commit_id":"00cea6a4b0026b7cafef15d7cc6584f60f51fc48","original_commit_id":"00cea6a4b0026b7cafef15d7cc6584f60f51fc48","user":{"login":"pozdnyakov","id":998253,"avatar_url":"https://gravatar.com/avatar/4ffb512f7312fbe30369fb8b78de59af?d=https%3A%2F%2Fidenticons.github.com%2F8e231c4fb7821d5ecb7d9114e4a4a204.png&r=x","gravatar_id":"4ffb512f7312fbe30369fb8b78de59af","url":"https://api.github.com/users/pozdnyakov","html_url":"https://github.com/pozdnyakov","followers_url":"https://api.github.com/users/pozdnyakov/followers","following_url":"https://api.github.com/users/pozdnyakov/following{/other_user}","gists_url":"https://api.github.com/users/pozdnyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/pozdnyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pozdnyakov/subscriptions","organizations_url":"https://api.github.com/users/pozdnyakov/orgs","repos_url":"https://api.github.com/users/pozdnyakov/repos","events_url":"https://api.github.com/users/pozdnyakov/events{/privacy}","received_events_url":"https://api.github.com/users/pozdnyakov/received_events","type":"User","site_admin":false},"body":"This logic is not affected with the proposed patch","created_at":"2014-01-03T09:50:47Z","updated_at":"2014-01-03T09:50:47Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/1426#discussion_r8631387","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/1426","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/8631387"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/1426#discussion_r8631387"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/1426"}}}}