GitHub PullRequestReviewCommentEvent at 2014-09-16 20:28:16
Repository: broadway
Actor: wjzijderveld
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/qandidate-labs/broadway/pulls/comments/17628204","id":17628204,"diff_hunk":"@@ -17,8 +17,25 @@\n class RegisterBusSubscribersCompilerPassTest extends TestCase\n {\n     /**\n+     * @var \\PHPUnit_Framework_MockObject_MockObject\n+     */\n+    private $builder;\n+\n+    /**\n+     * @var \\PHPUnit_Framework_MockObject_MockObject\n+     */\n+    private $commandBus;\n+\n+    public function setUp()\n+    {\n+        $this->builder = $this->getMock('Symfony\\Component\\DependencyInjection\\ContainerBuilder');","path":"test/Broadway/Bundle/BroadwayBundle/DependencyInjection/RegisterBusSubscribersCompilerPassTest.php","position":null,"original_position":15,"commit_id":"5d162b8e38a8cd7e326b9663572e0cebde9f3cba","original_commit_id":"c986fc8fd7ffd0bf4758d1f18f6eb50e8a2e7cc3","user":{"login":"wjzijderveld","id":450201,"avatar_url":"https://avatars.githubusercontent.com/u/450201?v=2","gravatar_id":"c347affc11bc313dc3da2398936d305a","url":"https://api.github.com/users/wjzijderveld","html_url":"https://github.com/wjzijderveld","followers_url":"https://api.github.com/users/wjzijderveld/followers","following_url":"https://api.github.com/users/wjzijderveld/following{/other_user}","gists_url":"https://api.github.com/users/wjzijderveld/gists{/gist_id}","starred_url":"https://api.github.com/users/wjzijderveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjzijderveld/subscriptions","organizations_url":"https://api.github.com/users/wjzijderveld/orgs","repos_url":"https://api.github.com/users/wjzijderveld/repos","events_url":"https://api.github.com/users/wjzijderveld/events{/privacy}","received_events_url":"https://api.github.com/users/wjzijderveld/received_events","type":"User","site_admin":false},"body":"I have a shortcut in vim for it as well :)","created_at":"2014-09-16T20:28:16Z","updated_at":"2014-09-16T20:28:16Z","html_url":"https://github.com/qandidate-labs/broadway/pull/48#discussion_r17628204","pull_request_url":"https://api.github.com/repos/qandidate-labs/broadway/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/qandidate-labs/broadway/pulls/comments/17628204"},"html":{"href":"https://github.com/qandidate-labs/broadway/pull/48#discussion_r17628204"},"pull_request":{"href":"https://api.github.com/repos/qandidate-labs/broadway/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/qandidate-labs/broadway/pulls/48","id":21135322,"html_url":"https://github.com/qandidate-labs/broadway/pull/48","diff_url":"https://github.com/qandidate-labs/broadway/pull/48.diff","patch_url":"https://github.com/qandidate-labs/broadway/pull/48.patch","issue_url":"https://api.github.com/repos/qandidate-labs/broadway/issues/48","number":48,"state":"open","locked":false,"title":"RegisterBusSubscribersCompilerPass: Add support for parameter return values","user":{"login":"Miliooo","id":3365006,"avatar_url":"https://avatars.githubusercontent.com/u/3365006?v=2","gravatar_id":"f53cf7d61cb45294c98a9f9ec8851946","url":"https://api.github.com/users/Miliooo","html_url":"https://github.com/Miliooo","followers_url":"https://api.github.com/users/Miliooo/followers","following_url":"https://api.github.com/users/Miliooo/following{/other_user}","gists_url":"https://api.github.com/users/Miliooo/gists{/gist_id}","starred_url":"https://api.github.com/users/Miliooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miliooo/subscriptions","organizations_url":"https://api.github.com/users/Miliooo/orgs","repos_url":"https://api.github.com/users/Miliooo/repos","events_url":"https://api.github.com/users/Miliooo/events{/privacy}","received_events_url":"https://api.github.com/users/Miliooo/received_events","type":"User","site_admin":false},"body":"When using a parameter for my projector classes I received this exception:\r\n```\r\nReflectionException: Class %my_parameter% does not exist\r\n```\r\nThis PR solves this by asking for the parameter first before doing the reflection.\r\n\r\nEdit: When looking if this was a known symfony bug http://stackoverflow.com/questions/19266204/after-tagging-a-service-in-services-yml-symfony-starts-throwing-reflectionexcept\r\n\r\nEdit2: https://github.com/richsage/RMSPushNotificationsBundle/blob/master/DependencyInjection/Compiler/AddHandlerPass.php","created_at":"2014-09-12T06:39:30Z","updated_at":"2014-09-16T20:28:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"204efab8ca68f1dfcd1cddf4168c1419ca4bbe6d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qandidate-labs/broadway/pulls/48/commits","review_comments_url":"https://api.github.com/repos/qandidate-labs/broadway/pulls/48/comments","review_comment_url":"https://api.github.com/repos/qandidate-labs/broadway/pulls/comments/{number}","comments_url":"https://api.github.com/repos/qandidate-labs/broadway/issues/48/comments","statuses_url":"https://api.github.com/repos/qandidate-labs/broadway/statuses/5d162b8e38a8cd7e326b9663572e0cebde9f3cba","head":{"label":"Miliooo:compiler","ref":"compiler","sha":"5d162b8e38a8cd7e326b9663572e0cebde9f3cba","user":{"login":"Miliooo","id":3365006,"avatar_url":"https://avatars.githubusercontent.com/u/3365006?v=2","gravatar_id":"f53cf7d61cb45294c98a9f9ec8851946","url":"https://api.github.com/users/Miliooo","html_url":"https://github.com/Miliooo","followers_url":"https://api.github.com/users/Miliooo/followers","following_url":"https://api.github.com/users/Miliooo/following{/other_user}","gists_url":"https://api.github.com/users/Miliooo/gists{/gist_id}","starred_url":"https://api.github.com/users/Miliooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miliooo/subscriptions","organizations_url":"https://api.github.com/users/Miliooo/orgs","repos_url":"https://api.github.com/users/Miliooo/repos","events_url":"https://api.github.com/users/Miliooo/events{/privacy}","received_events_url":"https://api.github.com/users/Miliooo/received_events","type":"User","site_admin":false},"repo":{"id":23627876,"name":"broadway","full_name":"Miliooo/broadway","owner":{"login":"Miliooo","id":3365006,"avatar_url":"https://avatars.githubusercontent.com/u/3365006?v=2","gravatar_id":"f53cf7d61cb45294c98a9f9ec8851946","url":"https://api.github.com/users/Miliooo","html_url":"https://github.com/Miliooo","followers_url":"https://api.github.com/users/Miliooo/followers","following_url":"https://api.github.com/users/Miliooo/following{/other_user}","gists_url":"https://api.github.com/users/Miliooo/gists{/gist_id}","starred_url":"https://api.github.com/users/Miliooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miliooo/subscriptions","organizations_url":"https://api.github.com/users/Miliooo/orgs","repos_url":"https://api.github.com/users/Miliooo/repos","events_url":"https://api.github.com/users/Miliooo/events{/privacy}","received_events_url":"https://api.github.com/users/Miliooo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Miliooo/broadway","description":"Infrastructure and testing helpers for creating CQRS and event sourced applications.","fork":true,"url":"https://api.github.com/repos/Miliooo/broadway","forks_url":"https://api.github.com/repos/Miliooo/broadway/forks","keys_url":"https://api.github.com/repos/Miliooo/broadway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Miliooo/broadway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Miliooo/broadway/teams","hooks_url":"https://api.github.com/repos/Miliooo/broadway/hooks","issue_events_url":"https://api.github.com/repos/Miliooo/broadway/issues/events{/number}","events_url":"https://api.github.com/repos/Miliooo/broadway/events","assignees_url":"https://api.github.com/repos/Miliooo/broadway/assignees{/user}","branches_url":"https://api.github.com/repos/Miliooo/broadway/branches{/branch}","tags_url":"https://api.github.com/repos/Miliooo/broadway/tags","blobs_url":"https://api.github.com/repos/Miliooo/broadway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Miliooo/broadway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Miliooo/broadway/git/refs{/sha}","trees_url":"https://api.github.com/repos/Miliooo/broadway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Miliooo/broadway/statuses/{sha}","languages_url":"https://api.github.com/repos/Miliooo/broadway/languages","stargazers_url":"https://api.github.com/repos/Miliooo/broadway/stargazers","contributors_url":"https://api.github.com/repos/Miliooo/broadway/contributors","subscribers_url":"https://api.github.com/repos/Miliooo/broadway/subscribers","subscription_url":"https://api.github.com/repos/Miliooo/broadway/subscription","commits_url":"https://api.github.com/repos/Miliooo/broadway/commits{/sha}","git_commits_url":"https://api.github.com/repos/Miliooo/broadway/git/commits{/sha}","comments_url":"https://api.github.com/repos/Miliooo/broadway/comments{/number}","issue_comment_url":"https://api.github.com/repos/Miliooo/broadway/issues/comments/{number}","contents_url":"https://api.github.com/repos/Miliooo/broadway/contents/{+path}","compare_url":"https://api.github.com/repos/Miliooo/broadway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Miliooo/broadway/merges","archive_url":"https://api.github.com/repos/Miliooo/broadway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Miliooo/broadway/downloads","issues_url":"https://api.github.com/repos/Miliooo/broadway/issues{/number}","pulls_url":"https://api.github.com/repos/Miliooo/broadway/pulls{/number}","milestones_url":"https://api.github.com/repos/Miliooo/broadway/milestones{/number}","notifications_url":"https://api.github.com/repos/Miliooo/broadway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Miliooo/broadway/labels{/name}","releases_url":"https://api.github.com/repos/Miliooo/broadway/releases{/id}","created_at":"2014-09-03T16:19:57Z","updated_at":"2014-09-03T07:50:45Z","pushed_at":"2014-09-16T20:27:51Z","git_url":"git://github.com/Miliooo/broadway.git","ssh_url":"git@github.com:Miliooo/broadway.git","clone_url":"https://github.com/Miliooo/broadway.git","svn_url":"https://github.com/Miliooo/broadway","homepage":"http://labs.qandidate.com/blog/2014/08/26/broadway-our-cqrs-es-framework-open-sourced/","size":389,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qandidate-labs:master","ref":"master","sha":"e0f5c7e3ecac2e41dd26923c5633e5d22832397f","user":{"login":"qandidate-labs","id":4686531,"avatar_url":"https://avatars.githubusercontent.com/u/4686531?v=2","gravatar_id":null,"url":"https://api.github.com/users/qandidate-labs","html_url":"https://github.com/qandidate-labs","followers_url":"https://api.github.com/users/qandidate-labs/followers","following_url":"https://api.github.com/users/qandidate-labs/following{/other_user}","gists_url":"https://api.github.com/users/qandidate-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/qandidate-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qandidate-labs/subscriptions","organizations_url":"https://api.github.com/users/qandidate-labs/orgs","repos_url":"https://api.github.com/users/qandidate-labs/repos","events_url":"https://api.github.com/users/qandidate-labs/events{/privacy}","received_events_url":"https://api.github.com/users/qandidate-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":23352973,"name":"broadway","full_name":"qandidate-labs/broadway","owner":{"login":"qandidate-labs","id":4686531,"avatar_url":"https://avatars.githubusercontent.com/u/4686531?v=2","gravatar_id":null,"url":"https://api.github.com/users/qandidate-labs","html_url":"https://github.com/qandidate-labs","followers_url":"https://api.github.com/users/qandidate-labs/followers","following_url":"https://api.github.com/users/qandidate-labs/following{/other_user}","gists_url":"https://api.github.com/users/qandidate-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/qandidate-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qandidate-labs/subscriptions","organizations_url":"https://api.github.com/users/qandidate-labs/orgs","repos_url":"https://api.github.com/users/qandidate-labs/repos","events_url":"https://api.github.com/users/qandidate-labs/events{/privacy}","received_events_url":"https://api.github.com/users/qandidate-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qandidate-labs/broadway","description":"Infrastructure and testing helpers for creating CQRS and event sourced applications.","fork":false,"url":"https://api.github.com/repos/qandidate-labs/broadway","forks_url":"https://api.github.com/repos/qandidate-labs/broadway/forks","keys_url":"https://api.github.com/repos/qandidate-labs/broadway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qandidate-labs/broadway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qandidate-labs/broadway/teams","hooks_url":"https://api.github.com/repos/qandidate-labs/broadway/hooks","issue_events_url":"https://api.github.com/repos/qandidate-labs/broadway/issues/events{/number}","events_url":"https://api.github.com/repos/qandidate-labs/broadway/events","assignees_url":"https://api.github.com/repos/qandidate-labs/broadway/assignees{/user}","branches_url":"https://api.github.com/repos/qandidate-labs/broadway/branches{/branch}","tags_url":"https://api.github.com/repos/qandidate-labs/broadway/tags","blobs_url":"https://api.github.com/repos/qandidate-labs/broadway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qandidate-labs/broadway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qandidate-labs/broadway/git/refs{/sha}","trees_url":"https://api.github.com/repos/qandidate-labs/broadway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qandidate-labs/broadway/statuses/{sha}","languages_url":"https://api.github.com/repos/qandidate-labs/broadway/languages","stargazers_url":"https://api.github.com/repos/qandidate-labs/broadway/stargazers","contributors_url":"https://api.github.com/repos/qandidate-labs/broadway/contributors","subscribers_url":"https://api.github.com/repos/qandidate-labs/broadway/subscribers","subscription_url":"https://api.github.com/repos/qandidate-labs/broadway/subscription","commits_url":"https://api.github.com/repos/qandidate-labs/broadway/commits{/sha}","git_commits_url":"https://api.github.com/repos/qandidate-labs/broadway/git/commits{/sha}","comments_url":"https://api.github.com/repos/qandidate-labs/broadway/comments{/number}","issue_comment_url":"https://api.github.com/repos/qandidate-labs/broadway/issues/comments/{number}","contents_url":"https://api.github.com/repos/qandidate-labs/broadway/contents/{+path}","compare_url":"https://api.github.com/repos/qandidate-labs/broadway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qandidate-labs/broadway/merges","archive_url":"https://api.github.com/repos/qandidate-labs/broadway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qandidate-labs/broadway/downloads","issues_url":"https://api.github.com/repos/qandidate-labs/broadway/issues{/number}","pulls_url":"https://api.github.com/repos/qandidate-labs/broadway/pulls{/number}","milestones_url":"https://api.github.com/repos/qandidate-labs/broadway/milestones{/number}","notifications_url":"https://api.github.com/repos/qandidate-labs/broadway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qandidate-labs/broadway/labels{/name}","releases_url":"https://api.github.com/repos/qandidate-labs/broadway/releases{/id}","created_at":"2014-08-26T13:40:55Z","updated_at":"2014-09-16T09:10:47Z","pushed_at":"2014-09-15T13:18:31Z","git_url":"git://github.com/qandidate-labs/broadway.git","ssh_url":"git@github.com:qandidate-labs/broadway.git","clone_url":"https://github.com/qandidate-labs/broadway.git","svn_url":"https://github.com/qandidate-labs/broadway","homepage":"http://labs.qandidate.com/blog/2014/08/26/broadway-our-cqrs-es-framework-open-sourced/","size":671,"stargazers_count":105,"watchers_count":105,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":19,"forks":15,"open_issues":19,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qandidate-labs/broadway/pulls/48"},"html":{"href":"https://github.com/qandidate-labs/broadway/pull/48"},"issue":{"href":"https://api.github.com/repos/qandidate-labs/broadway/issues/48"},"comments":{"href":"https://api.github.com/repos/qandidate-labs/broadway/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/qandidate-labs/broadway/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/qandidate-labs/broadway/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/qandidate-labs/broadway/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/qandidate-labs/broadway/statuses/5d162b8e38a8cd7e326b9663572e0cebde9f3cba"}}}}