GitHub PullRequestReviewCommentEvent at 2014-05-25 07:34:28
Repository: rust
Actor: huonw
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla/rust/pulls/comments/13029640","id":13029640,"diff_hunk":"@@ -237,11 +237,27 @@ pub struct Tm {\n     /// for U.S. Pacific Daylight Time, the value is -7*60*60 = -25200.\n     pub tm_gmtoff: i32,\n \n+    /// Abbreviated name for the time zone that was used to compute this broken-down time value.\n+    /// For example, U.S. Pacific Daylight Time is \"PDT\".\n+    pub tm_zone: StrBuf,\n+\n     /// Nanoseconds after the second – [0, 10<sup>9</sup> - 1]\n     pub tm_nsec: i32,\n }\n \n+impl Tm {\n+    pub fn tm_zone<'a>(&'a self) -> &'a str {\n+        self.tm_zone.as_slice()\n+    }\n+}\n+\n pub fn empty_tm() -> Tm {\n+    // 64 is the max size of the timezone buffer allocated on windows\n+    // in rust_localtime. In glibc the max timezone size is supposedly 3.\n+    let mut zone = StrBuf::new();\n+    for _ in range(0, 64) {\n+        zone.push_char(' ')\n+    }","path":"src/libtime/lib.rs","position":30,"original_position":30,"commit_id":"32dedfb7b8fe3230675a3bbb7fde969a1c42a536","original_commit_id":"32dedfb7b8fe3230675a3bbb7fde969a1c42a536","user":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?","gravatar_id":"365f3c2704e4744e237651f3c2a7c411","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"body":"This could be `\" \".repeat(64)` btw, or [`String::from_char`](http://doc.rust-lang.org/master/std/strbuf/struct.StrBuf.html#method.from_char).","created_at":"2014-05-25T07:34:28Z","updated_at":"2014-05-25T07:34:28Z","html_url":"https://github.com/mozilla/rust/pull/14397#discussion_r13029640","pull_request_url":"https://api.github.com/repos/mozilla/rust/pulls/14397","_links":{"self":{"href":"https://api.github.com/repos/mozilla/rust/pulls/comments/13029640"},"html":{"href":"https://github.com/mozilla/rust/pull/14397#discussion_r13029640"},"pull_request":{"href":"https://api.github.com/repos/mozilla/rust/pulls/14397"}}}}