GitHub PullRequestReviewCommentEvent at 2014-12-23 01:42:18
Repository: dotenv
Actor: apm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/motdotla/dotenv/pulls/comments/22200723","id":22200723,"diff_hunk":"@@ -65,8 +80,15 @@ function dotenv() {\n       } catch (e) {\n         return false;\n       }\n-      \n+\n       keys_and_values = dotenv.parse( data );\n+\n+      // pre-populate the list before variable replacement so that recursive\n+      // substitutions are possible.\n+      for (var i in keys_and_values) {\n+        dotenv.keys_and_values[i] = keys_and_values[i];","path":"lib/main.js","position":47,"original_position":47,"commit_id":"0fc74c061fabfb436300d2eaeca9ddd2b85e7465","original_commit_id":"0fc74c061fabfb436300d2eaeca9ddd2b85e7465","user":{"login":"apm","id":38468,"avatar_url":"https://avatars.githubusercontent.com/u/38468?v=3","gravatar_id":"","url":"https://api.github.com/users/apm","html_url":"https://github.com/apm","followers_url":"https://api.github.com/users/apm/followers","following_url":"https://api.github.com/users/apm/following{/other_user}","gists_url":"https://api.github.com/users/apm/gists{/gist_id}","starred_url":"https://api.github.com/users/apm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apm/subscriptions","organizations_url":"https://api.github.com/users/apm/orgs","repos_url":"https://api.github.com/users/apm/repos","events_url":"https://api.github.com/users/apm/events{/privacy}","received_events_url":"https://api.github.com/users/apm/received_events","type":"User","site_admin":false},"body":"Yes, this makes it so order doesn't matter, and let's replacement values also have resolvable variables.  The unit test exercises this, but doesn't covey the value very well.","created_at":"2014-12-23T01:42:18Z","updated_at":"2014-12-23T01:42:18Z","html_url":"https://github.com/motdotla/dotenv/pull/42#discussion_r22200723","pull_request_url":"https://api.github.com/repos/motdotla/dotenv/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/motdotla/dotenv/pulls/comments/22200723"},"html":{"href":"https://github.com/motdotla/dotenv/pull/42#discussion_r22200723"},"pull_request":{"href":"https://api.github.com/repos/motdotla/dotenv/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/motdotla/dotenv/pulls/42","id":26490873,"html_url":"https://github.com/motdotla/dotenv/pull/42","diff_url":"https://github.com/motdotla/dotenv/pull/42.diff","patch_url":"https://github.com/motdotla/dotenv/pull/42.patch","issue_url":"https://api.github.com/repos/motdotla/dotenv/issues/42","number":42,"state":"open","locked":false,"title":"recursively expands ${VARIABLES} within the value (w/o refactor)","user":{"login":"apm","id":38468,"avatar_url":"https://avatars.githubusercontent.com/u/38468?v=3","gravatar_id":"","url":"https://api.github.com/users/apm","html_url":"https://github.com/apm","followers_url":"https://api.github.com/users/apm/followers","following_url":"https://api.github.com/users/apm/following{/other_user}","gists_url":"https://api.github.com/users/apm/gists{/gist_id}","starred_url":"https://api.github.com/users/apm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apm/subscriptions","organizations_url":"https://api.github.com/users/apm/orgs","repos_url":"https://api.github.com/users/apm/repos","events_url":"https://api.github.com/users/apm/events{/privacy}","received_events_url":"https://api.github.com/users/apm/received_events","type":"User","site_admin":false},"body":"My editor ate trailing spaces, but it should be clean enough.  Fixes #39.","created_at":"2014-12-23T01:01:37Z","updated_at":"2014-12-23T01:42:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"532df1315748b6defd33394f5e94a24b2e3dfb30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/motdotla/dotenv/pulls/42/commits","review_comments_url":"https://api.github.com/repos/motdotla/dotenv/pulls/42/comments","review_comment_url":"https://api.github.com/repos/motdotla/dotenv/pulls/comments/{number}","comments_url":"https://api.github.com/repos/motdotla/dotenv/issues/42/comments","statuses_url":"https://api.github.com/repos/motdotla/dotenv/statuses/0fc74c061fabfb436300d2eaeca9ddd2b85e7465","head":{"label":"apm:in-value-variables-clean","ref":"in-value-variables-clean","sha":"0fc74c061fabfb436300d2eaeca9ddd2b85e7465","user":{"login":"apm","id":38468,"avatar_url":"https://avatars.githubusercontent.com/u/38468?v=3","gravatar_id":"","url":"https://api.github.com/users/apm","html_url":"https://github.com/apm","followers_url":"https://api.github.com/users/apm/followers","following_url":"https://api.github.com/users/apm/following{/other_user}","gists_url":"https://api.github.com/users/apm/gists{/gist_id}","starred_url":"https://api.github.com/users/apm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apm/subscriptions","organizations_url":"https://api.github.com/users/apm/orgs","repos_url":"https://api.github.com/users/apm/repos","events_url":"https://api.github.com/users/apm/events{/privacy}","received_events_url":"https://api.github.com/users/apm/received_events","type":"User","site_admin":false},"repo":{"id":28309170,"name":"dotenv","full_name":"apm/dotenv","owner":{"login":"apm","id":38468,"avatar_url":"https://avatars.githubusercontent.com/u/38468?v=3","gravatar_id":"","url":"https://api.github.com/users/apm","html_url":"https://github.com/apm","followers_url":"https://api.github.com/users/apm/followers","following_url":"https://api.github.com/users/apm/following{/other_user}","gists_url":"https://api.github.com/users/apm/gists{/gist_id}","starred_url":"https://api.github.com/users/apm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apm/subscriptions","organizations_url":"https://api.github.com/users/apm/orgs","repos_url":"https://api.github.com/users/apm/repos","events_url":"https://api.github.com/users/apm/events{/privacy}","received_events_url":"https://api.github.com/users/apm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apm/dotenv","description":"Loads environment variables from .env for nodejs projects.","fork":true,"url":"https://api.github.com/repos/apm/dotenv","forks_url":"https://api.github.com/repos/apm/dotenv/forks","keys_url":"https://api.github.com/repos/apm/dotenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apm/dotenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apm/dotenv/teams","hooks_url":"https://api.github.com/repos/apm/dotenv/hooks","issue_events_url":"https://api.github.com/repos/apm/dotenv/issues/events{/number}","events_url":"https://api.github.com/repos/apm/dotenv/events","assignees_url":"https://api.github.com/repos/apm/dotenv/assignees{/user}","branches_url":"https://api.github.com/repos/apm/dotenv/branches{/branch}","tags_url":"https://api.github.com/repos/apm/dotenv/tags","blobs_url":"https://api.github.com/repos/apm/dotenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apm/dotenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apm/dotenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/apm/dotenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apm/dotenv/statuses/{sha}","languages_url":"https://api.github.com/repos/apm/dotenv/languages","stargazers_url":"https://api.github.com/repos/apm/dotenv/stargazers","contributors_url":"https://api.github.com/repos/apm/dotenv/contributors","subscribers_url":"https://api.github.com/repos/apm/dotenv/subscribers","subscription_url":"https://api.github.com/repos/apm/dotenv/subscription","commits_url":"https://api.github.com/repos/apm/dotenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/apm/dotenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/apm/dotenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/apm/dotenv/issues/comments/{number}","contents_url":"https://api.github.com/repos/apm/dotenv/contents/{+path}","compare_url":"https://api.github.com/repos/apm/dotenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apm/dotenv/merges","archive_url":"https://api.github.com/repos/apm/dotenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apm/dotenv/downloads","issues_url":"https://api.github.com/repos/apm/dotenv/issues{/number}","pulls_url":"https://api.github.com/repos/apm/dotenv/pulls{/number}","milestones_url":"https://api.github.com/repos/apm/dotenv/milestones{/number}","notifications_url":"https://api.github.com/repos/apm/dotenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apm/dotenv/labels{/name}","releases_url":"https://api.github.com/repos/apm/dotenv/releases{/id}","created_at":"2014-12-21T18:47:04Z","updated_at":"2014-12-21T18:47:05Z","pushed_at":"2014-12-23T00:59:22Z","git_url":"git://github.com/apm/dotenv.git","ssh_url":"git@github.com:apm/dotenv.git","clone_url":"https://github.com/apm/dotenv.git","svn_url":"https://github.com/apm/dotenv","homepage":"","size":158,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"motdotla:master","ref":"master","sha":"6b98ef7dbc005efeb57fee8367840228ca2e5461","user":{"login":"motdotla","id":3848,"avatar_url":"https://avatars.githubusercontent.com/u/3848?v=3","gravatar_id":"","url":"https://api.github.com/users/motdotla","html_url":"https://github.com/motdotla","followers_url":"https://api.github.com/users/motdotla/followers","following_url":"https://api.github.com/users/motdotla/following{/other_user}","gists_url":"https://api.github.com/users/motdotla/gists{/gist_id}","starred_url":"https://api.github.com/users/motdotla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/motdotla/subscriptions","organizations_url":"https://api.github.com/users/motdotla/orgs","repos_url":"https://api.github.com/users/motdotla/repos","events_url":"https://api.github.com/users/motdotla/events{/privacy}","received_events_url":"https://api.github.com/users/motdotla/received_events","type":"User","site_admin":false},"repo":{"id":11205780,"name":"dotenv","full_name":"motdotla/dotenv","owner":{"login":"motdotla","id":3848,"avatar_url":"https://avatars.githubusercontent.com/u/3848?v=3","gravatar_id":"","url":"https://api.github.com/users/motdotla","html_url":"https://github.com/motdotla","followers_url":"https://api.github.com/users/motdotla/followers","following_url":"https://api.github.com/users/motdotla/following{/other_user}","gists_url":"https://api.github.com/users/motdotla/gists{/gist_id}","starred_url":"https://api.github.com/users/motdotla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/motdotla/subscriptions","organizations_url":"https://api.github.com/users/motdotla/orgs","repos_url":"https://api.github.com/users/motdotla/repos","events_url":"https://api.github.com/users/motdotla/events{/privacy}","received_events_url":"https://api.github.com/users/motdotla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/motdotla/dotenv","description":"Loads environment variables from .env for nodejs projects.","fork":false,"url":"https://api.github.com/repos/motdotla/dotenv","forks_url":"https://api.github.com/repos/motdotla/dotenv/forks","keys_url":"https://api.github.com/repos/motdotla/dotenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/motdotla/dotenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/motdotla/dotenv/teams","hooks_url":"https://api.github.com/repos/motdotla/dotenv/hooks","issue_events_url":"https://api.github.com/repos/motdotla/dotenv/issues/events{/number}","events_url":"https://api.github.com/repos/motdotla/dotenv/events","assignees_url":"https://api.github.com/repos/motdotla/dotenv/assignees{/user}","branches_url":"https://api.github.com/repos/motdotla/dotenv/branches{/branch}","tags_url":"https://api.github.com/repos/motdotla/dotenv/tags","blobs_url":"https://api.github.com/repos/motdotla/dotenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/motdotla/dotenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/motdotla/dotenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/motdotla/dotenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/motdotla/dotenv/statuses/{sha}","languages_url":"https://api.github.com/repos/motdotla/dotenv/languages","stargazers_url":"https://api.github.com/repos/motdotla/dotenv/stargazers","contributors_url":"https://api.github.com/repos/motdotla/dotenv/contributors","subscribers_url":"https://api.github.com/repos/motdotla/dotenv/subscribers","subscription_url":"https://api.github.com/repos/motdotla/dotenv/subscription","commits_url":"https://api.github.com/repos/motdotla/dotenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/motdotla/dotenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/motdotla/dotenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/motdotla/dotenv/issues/comments/{number}","contents_url":"https://api.github.com/repos/motdotla/dotenv/contents/{+path}","compare_url":"https://api.github.com/repos/motdotla/dotenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/motdotla/dotenv/merges","archive_url":"https://api.github.com/repos/motdotla/dotenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/motdotla/dotenv/downloads","issues_url":"https://api.github.com/repos/motdotla/dotenv/issues{/number}","pulls_url":"https://api.github.com/repos/motdotla/dotenv/pulls{/number}","milestones_url":"https://api.github.com/repos/motdotla/dotenv/milestones{/number}","notifications_url":"https://api.github.com/repos/motdotla/dotenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/motdotla/dotenv/labels{/name}","releases_url":"https://api.github.com/repos/motdotla/dotenv/releases{/id}","created_at":"2013-07-05T18:25:05Z","updated_at":"2014-12-23T00:12:49Z","pushed_at":"2014-12-23T00:12:49Z","git_url":"git://github.com/motdotla/dotenv.git","ssh_url":"git@github.com:motdotla/dotenv.git","clone_url":"https://github.com/motdotla/dotenv.git","svn_url":"https://github.com/motdotla/dotenv","homepage":"","size":861,"stargazers_count":222,"watchers_count":222,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":3,"forks":20,"open_issues":3,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/motdotla/dotenv/pulls/42"},"html":{"href":"https://github.com/motdotla/dotenv/pull/42"},"issue":{"href":"https://api.github.com/repos/motdotla/dotenv/issues/42"},"comments":{"href":"https://api.github.com/repos/motdotla/dotenv/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/motdotla/dotenv/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/motdotla/dotenv/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/motdotla/dotenv/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/motdotla/dotenv/statuses/0fc74c061fabfb436300d2eaeca9ddd2b85e7465"}}}}