GitHub PullRequestEvent at 2014-07-20 22:40:24
Repository: juju
Actor: jujubot
Payload: {"action":"closed","number":341,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/341","id":18634177,"html_url":"https://github.com/juju/juju/pull/341","diff_url":"https://github.com/juju/juju/pull/341.diff","patch_url":"https://github.com/juju/juju/pull/341.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/341","number":341,"state":"closed","title":"Agent config mutators can now return errors","user":{"login":"mjs","id":14993,"avatar_url":"https://avatars.githubusercontent.com/u/14993?","gravatar_id":"286ea349060105e596aec349da029a00","url":"https://api.github.com/users/mjs","html_url":"https://github.com/mjs","followers_url":"https://api.github.com/users/mjs/followers","following_url":"https://api.github.com/users/mjs/following{/other_user}","gists_url":"https://api.github.com/users/mjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjs/subscriptions","organizations_url":"https://api.github.com/users/mjs/orgs","repos_url":"https://api.github.com/users/mjs/repos","events_url":"https://api.github.com/users/mjs/events{/privacy}","received_events_url":"https://api.github.com/users/mjs/received_events","type":"User","site_admin":false},"body":"Previously, functions that modify agent config could not return errors, requiring some gynamastics to get errors out of these functions. By requiring that errors are returned some areas that call ChangeConfig are now cleaner.","created_at":"2014-07-20T22:12:03Z","updated_at":"2014-07-20T22:40:24Z","closed_at":"2014-07-20T22:40:24Z","merged_at":"2014-07-20T22:40:24Z","merge_commit_sha":"6a8e250be56de17544830256939f759507e73ca2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/341/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/341/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju/issues/341/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/64735bdf1f6c5bb5044488df7bc05a6cb3531157","head":{"label":"mjs:improve-agent-change-config-error-reporting","ref":"improve-agent-change-config-error-reporting","sha":"64735bdf1f6c5bb5044488df7bc05a6cb3531157","user":{"login":"mjs","id":14993,"avatar_url":"https://avatars.githubusercontent.com/u/14993?","gravatar_id":"286ea349060105e596aec349da029a00","url":"https://api.github.com/users/mjs","html_url":"https://github.com/mjs","followers_url":"https://api.github.com/users/mjs/followers","following_url":"https://api.github.com/users/mjs/following{/other_user}","gists_url":"https://api.github.com/users/mjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjs/subscriptions","organizations_url":"https://api.github.com/users/mjs/orgs","repos_url":"https://api.github.com/users/mjs/repos","events_url":"https://api.github.com/users/mjs/events{/privacy}","received_events_url":"https://api.github.com/users/mjs/received_events","type":"User","site_admin":false},"repo":{"id":20458097,"name":"juju","full_name":"mjs/juju","owner":{"login":"mjs","id":14993,"avatar_url":"https://avatars.githubusercontent.com/u/14993?","gravatar_id":"286ea349060105e596aec349da029a00","url":"https://api.github.com/users/mjs","html_url":"https://github.com/mjs","followers_url":"https://api.github.com/users/mjs/followers","following_url":"https://api.github.com/users/mjs/following{/other_user}","gists_url":"https://api.github.com/users/mjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjs/subscriptions","organizations_url":"https://api.github.com/users/mjs/orgs","repos_url":"https://api.github.com/users/mjs/repos","events_url":"https://api.github.com/users/mjs/events{/privacy}","received_events_url":"https://api.github.com/users/mjs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjs/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/mjs/juju","forks_url":"https://api.github.com/repos/mjs/juju/forks","keys_url":"https://api.github.com/repos/mjs/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjs/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjs/juju/teams","hooks_url":"https://api.github.com/repos/mjs/juju/hooks","issue_events_url":"https://api.github.com/repos/mjs/juju/issues/events{/number}","events_url":"https://api.github.com/repos/mjs/juju/events","assignees_url":"https://api.github.com/repos/mjs/juju/assignees{/user}","branches_url":"https://api.github.com/repos/mjs/juju/branches{/branch}","tags_url":"https://api.github.com/repos/mjs/juju/tags","blobs_url":"https://api.github.com/repos/mjs/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjs/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjs/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjs/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjs/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/mjs/juju/languages","stargazers_url":"https://api.github.com/repos/mjs/juju/stargazers","contributors_url":"https://api.github.com/repos/mjs/juju/contributors","subscribers_url":"https://api.github.com/repos/mjs/juju/subscribers","subscription_url":"https://api.github.com/repos/mjs/juju/subscription","commits_url":"https://api.github.com/repos/mjs/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjs/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjs/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjs/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/mjs/juju/contents/{+path}","compare_url":"https://api.github.com/repos/mjs/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjs/juju/merges","archive_url":"https://api.github.com/repos/mjs/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjs/juju/downloads","issues_url":"https://api.github.com/repos/mjs/juju/issues{/number}","pulls_url":"https://api.github.com/repos/mjs/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/mjs/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/mjs/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjs/juju/labels{/name}","releases_url":"https://api.github.com/repos/mjs/juju/releases{/id}","created_at":"2014-06-03T20:21:02Z","updated_at":"2014-07-01T23:34:49Z","pushed_at":"2014-07-20T22:18:27Z","git_url":"git://github.com/mjs/juju.git","ssh_url":"git@github.com:mjs/juju.git","clone_url":"https://github.com/mjs/juju.git","svn_url":"https://github.com/mjs/juju","homepage":null,"size":24673,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"0570615416f6df2fb3190f0e91ec2885a93b70a9","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2014-07-20T17:20:40Z","pushed_at":"2014-07-20T22:40:24Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":33139,"stargazers_count":183,"watchers_count":183,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":43,"mirror_url":null,"open_issues_count":39,"forks":43,"open_issues":39,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/341"},"html":{"href":"https://github.com/juju/juju/pull/341"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/341"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/64735bdf1f6c5bb5044488df7bc05a6cb3531157"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jujubot","id":7779494,"avatar_url":"https://avatars.githubusercontent.com/u/7779494?","gravatar_id":"9593b1cf0cffc7073089b169cb4321cf","url":"https://api.github.com/users/jujubot","html_url":"https://github.com/jujubot","followers_url":"https://api.github.com/users/jujubot/followers","following_url":"https://api.github.com/users/jujubot/following{/other_user}","gists_url":"https://api.github.com/users/jujubot/gists{/gist_id}","starred_url":"https://api.github.com/users/jujubot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jujubot/subscriptions","organizations_url":"https://api.github.com/users/jujubot/orgs","repos_url":"https://api.github.com/users/jujubot/repos","events_url":"https://api.github.com/users/jujubot/events{/privacy}","received_events_url":"https://api.github.com/users/jujubot/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":120,"deletions":28,"changed_files":6}}