GitHub PullRequestReviewCommentEvent at 2014-12-18 18:14:34
Repository: modules-activitystream
Actor: lsvx
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/natgeo/modules-activitystream/pulls/comments/22059565","id":22059565,"diff_hunk":"@@ -29,3 +29,12 @@ define [\n             obj.verb = @models.verb.attributes\n             return obj\n \n+        #Override sync method\n+        sync: (method, collection, options) ->\n+            if method is \"create\"\n+                #If the method is create, prevent unnecessary POST call","path":"app/scripts/models/activity.coffee","position":7,"original_position":7,"commit_id":"7f4c90bbefc8beb437c463ba81b78db2a29250ca","original_commit_id":"7f4c90bbefc8beb437c463ba81b78db2a29250ca","user":{"login":"lsvx","id":1369275,"avatar_url":"https://avatars.githubusercontent.com/u/1369275?v=3","gravatar_id":"","url":"https://api.github.com/users/lsvx","html_url":"https://github.com/lsvx","followers_url":"https://api.github.com/users/lsvx/followers","following_url":"https://api.github.com/users/lsvx/following{/other_user}","gists_url":"https://api.github.com/users/lsvx/gists{/gist_id}","starred_url":"https://api.github.com/users/lsvx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsvx/subscriptions","organizations_url":"https://api.github.com/users/lsvx/orgs","repos_url":"https://api.github.com/users/lsvx/repos","events_url":"https://api.github.com/users/lsvx/events{/privacy}","received_events_url":"https://api.github.com/users/lsvx/received_events","type":"User","site_admin":false},"body":"You have a funny empty clause here; either do `return false` here or change the `if` to `if method isnt 'create'`.","created_at":"2014-12-18T18:14:34Z","updated_at":"2014-12-18T18:14:34Z","html_url":"https://github.com/natgeo/modules-activitystream/pull/37#discussion_r22059565","pull_request_url":"https://api.github.com/repos/natgeo/modules-activitystream/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/natgeo/modules-activitystream/pulls/comments/22059565"},"html":{"href":"https://github.com/natgeo/modules-activitystream/pull/37#discussion_r22059565"},"pull_request":{"href":"https://api.github.com/repos/natgeo/modules-activitystream/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/natgeo/modules-activitystream/pulls/37","id":26319612,"html_url":"https://github.com/natgeo/modules-activitystream/pull/37","diff_url":"https://github.com/natgeo/modules-activitystream/pull/37.diff","patch_url":"https://github.com/natgeo/modules-activitystream/pull/37.patch","issue_url":"https://api.github.com/repos/natgeo/modules-activitystream/issues/37","number":37,"state":"open","locked":false,"title":"MIE-1702: Prevent 404 error code from Activity Streams inside member center","user":{"login":"pasche","id":9483970,"avatar_url":"https://avatars.githubusercontent.com/u/9483970?v=3","gravatar_id":"","url":"https://api.github.com/users/pasche","html_url":"https://github.com/pasche","followers_url":"https://api.github.com/users/pasche/followers","following_url":"https://api.github.com/users/pasche/following{/other_user}","gists_url":"https://api.github.com/users/pasche/gists{/gist_id}","starred_url":"https://api.github.com/users/pasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasche/subscriptions","organizations_url":"https://api.github.com/users/pasche/orgs","repos_url":"https://api.github.com/users/pasche/repos","events_url":"https://api.github.com/users/pasche/events{/privacy}","received_events_url":"https://api.github.com/users/pasche/received_events","type":"User","site_admin":false},"body":"Override backbone sync function to prevent  unnecessary post call when the method is create","created_at":"2014-12-18T18:04:15Z","updated_at":"2014-12-18T18:14:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49f7861c6ca03b1a04201ca5ba00acf53cf5c213","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/natgeo/modules-activitystream/pulls/37/commits","review_comments_url":"https://api.github.com/repos/natgeo/modules-activitystream/pulls/37/comments","review_comment_url":"https://api.github.com/repos/natgeo/modules-activitystream/pulls/comments/{number}","comments_url":"https://api.github.com/repos/natgeo/modules-activitystream/issues/37/comments","statuses_url":"https://api.github.com/repos/natgeo/modules-activitystream/statuses/7f4c90bbefc8beb437c463ba81b78db2a29250ca","head":{"label":"natgeo:feature/MIE-1702","ref":"feature/MIE-1702","sha":"7f4c90bbefc8beb437c463ba81b78db2a29250ca","user":{"login":"natgeo","id":343010,"avatar_url":"https://avatars.githubusercontent.com/u/343010?v=3","gravatar_id":"","url":"https://api.github.com/users/natgeo","html_url":"https://github.com/natgeo","followers_url":"https://api.github.com/users/natgeo/followers","following_url":"https://api.github.com/users/natgeo/following{/other_user}","gists_url":"https://api.github.com/users/natgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/natgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natgeo/subscriptions","organizations_url":"https://api.github.com/users/natgeo/orgs","repos_url":"https://api.github.com/users/natgeo/repos","events_url":"https://api.github.com/users/natgeo/events{/privacy}","received_events_url":"https://api.github.com/users/natgeo/received_events","type":"Organization","site_admin":false},"repo":{"id":15456504,"name":"modules-activitystream","full_name":"natgeo/modules-activitystream","owner":{"login":"natgeo","id":343010,"avatar_url":"https://avatars.githubusercontent.com/u/343010?v=3","gravatar_id":"","url":"https://api.github.com/users/natgeo","html_url":"https://github.com/natgeo","followers_url":"https://api.github.com/users/natgeo/followers","following_url":"https://api.github.com/users/natgeo/following{/other_user}","gists_url":"https://api.github.com/users/natgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/natgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natgeo/subscriptions","organizations_url":"https://api.github.com/users/natgeo/orgs","repos_url":"https://api.github.com/users/natgeo/repos","events_url":"https://api.github.com/users/natgeo/events{/privacy}","received_events_url":"https://api.github.com/users/natgeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/natgeo/modules-activitystream","description":"Activity Stream front-end module","fork":false,"url":"https://api.github.com/repos/natgeo/modules-activitystream","forks_url":"https://api.github.com/repos/natgeo/modules-activitystream/forks","keys_url":"https://api.github.com/repos/natgeo/modules-activitystream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natgeo/modules-activitystream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natgeo/modules-activitystream/teams","hooks_url":"https://api.github.com/repos/natgeo/modules-activitystream/hooks","issue_events_url":"https://api.github.com/repos/natgeo/modules-activitystream/issues/events{/number}","events_url":"https://api.github.com/repos/natgeo/modules-activitystream/events","assignees_url":"https://api.github.com/repos/natgeo/modules-activitystream/assignees{/user}","branches_url":"https://api.github.com/repos/natgeo/modules-activitystream/branches{/branch}","tags_url":"https://api.github.com/repos/natgeo/modules-activitystream/tags","blobs_url":"https://api.github.com/repos/natgeo/modules-activitystream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natgeo/modules-activitystream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natgeo/modules-activitystream/git/refs{/sha}","trees_url":"https://api.github.com/repos/natgeo/modules-activitystream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natgeo/modules-activitystream/statuses/{sha}","languages_url":"https://api.github.com/repos/natgeo/modules-activitystream/languages","stargazers_url":"https://api.github.com/repos/natgeo/modules-activitystream/stargazers","contributors_url":"https://api.github.com/repos/natgeo/modules-activitystream/contributors","subscribers_url":"https://api.github.com/repos/natgeo/modules-activitystream/subscribers","subscription_url":"https://api.github.com/repos/natgeo/modules-activitystream/subscription","commits_url":"https://api.github.com/repos/natgeo/modules-activitystream/commits{/sha}","git_commits_url":"https://api.github.com/repos/natgeo/modules-activitystream/git/commits{/sha}","comments_url":"https://api.github.com/repos/natgeo/modules-activitystream/comments{/number}","issue_comment_url":"https://api.github.com/repos/natgeo/modules-activitystream/issues/comments/{number}","contents_url":"https://api.github.com/repos/natgeo/modules-activitystream/contents/{+path}","compare_url":"https://api.github.com/repos/natgeo/modules-activitystream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natgeo/modules-activitystream/merges","archive_url":"https://api.github.com/repos/natgeo/modules-activitystream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natgeo/modules-activitystream/downloads","issues_url":"https://api.github.com/repos/natgeo/modules-activitystream/issues{/number}","pulls_url":"https://api.github.com/repos/natgeo/modules-activitystream/pulls{/number}","milestones_url":"https://api.github.com/repos/natgeo/modules-activitystream/milestones{/number}","notifications_url":"https://api.github.com/repos/natgeo/modules-activitystream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natgeo/modules-activitystream/labels{/name}","releases_url":"https://api.github.com/repos/natgeo/modules-activitystream/releases{/id}","created_at":"2013-12-26T16:52:07Z","updated_at":"2014-12-18T14:37:47Z","pushed_at":"2014-12-18T17:56:52Z","git_url":"git://github.com/natgeo/modules-activitystream.git","ssh_url":"git@github.com:natgeo/modules-activitystream.git","clone_url":"https://github.com/natgeo/modules-activitystream.git","svn_url":"https://github.com/natgeo/modules-activitystream","homepage":null,"size":6480,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"natgeo:develop","ref":"develop","sha":"eea78c388fbc034c4d7cb61d76cb5e9d1244834b","user":{"login":"natgeo","id":343010,"avatar_url":"https://avatars.githubusercontent.com/u/343010?v=3","gravatar_id":"","url":"https://api.github.com/users/natgeo","html_url":"https://github.com/natgeo","followers_url":"https://api.github.com/users/natgeo/followers","following_url":"https://api.github.com/users/natgeo/following{/other_user}","gists_url":"https://api.github.com/users/natgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/natgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natgeo/subscriptions","organizations_url":"https://api.github.com/users/natgeo/orgs","repos_url":"https://api.github.com/users/natgeo/repos","events_url":"https://api.github.com/users/natgeo/events{/privacy}","received_events_url":"https://api.github.com/users/natgeo/received_events","type":"Organization","site_admin":false},"repo":{"id":15456504,"name":"modules-activitystream","full_name":"natgeo/modules-activitystream","owner":{"login":"natgeo","id":343010,"avatar_url":"https://avatars.githubusercontent.com/u/343010?v=3","gravatar_id":"","url":"https://api.github.com/users/natgeo","html_url":"https://github.com/natgeo","followers_url":"https://api.github.com/users/natgeo/followers","following_url":"https://api.github.com/users/natgeo/following{/other_user}","gists_url":"https://api.github.com/users/natgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/natgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natgeo/subscriptions","organizations_url":"https://api.github.com/users/natgeo/orgs","repos_url":"https://api.github.com/users/natgeo/repos","events_url":"https://api.github.com/users/natgeo/events{/privacy}","received_events_url":"https://api.github.com/users/natgeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/natgeo/modules-activitystream","description":"Activity Stream front-end module","fork":false,"url":"https://api.github.com/repos/natgeo/modules-activitystream","forks_url":"https://api.github.com/repos/natgeo/modules-activitystream/forks","keys_url":"https://api.github.com/repos/natgeo/modules-activitystream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natgeo/modules-activitystream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natgeo/modules-activitystream/teams","hooks_url":"https://api.github.com/repos/natgeo/modules-activitystream/hooks","issue_events_url":"https://api.github.com/repos/natgeo/modules-activitystream/issues/events{/number}","events_url":"https://api.github.com/repos/natgeo/modules-activitystream/events","assignees_url":"https://api.github.com/repos/natgeo/modules-activitystream/assignees{/user}","branches_url":"https://api.github.com/repos/natgeo/modules-activitystream/branches{/branch}","tags_url":"https://api.github.com/repos/natgeo/modules-activitystream/tags","blobs_url":"https://api.github.com/repos/natgeo/modules-activitystream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natgeo/modules-activitystream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natgeo/modules-activitystream/git/refs{/sha}","trees_url":"https://api.github.com/repos/natgeo/modules-activitystream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natgeo/modules-activitystream/statuses/{sha}","languages_url":"https://api.github.com/repos/natgeo/modules-activitystream/languages","stargazers_url":"https://api.github.com/repos/natgeo/modules-activitystream/stargazers","contributors_url":"https://api.github.com/repos/natgeo/modules-activitystream/contributors","subscribers_url":"https://api.github.com/repos/natgeo/modules-activitystream/subscribers","subscription_url":"https://api.github.com/repos/natgeo/modules-activitystream/subscription","commits_url":"https://api.github.com/repos/natgeo/modules-activitystream/commits{/sha}","git_commits_url":"https://api.github.com/repos/natgeo/modules-activitystream/git/commits{/sha}","comments_url":"https://api.github.com/repos/natgeo/modules-activitystream/comments{/number}","issue_comment_url":"https://api.github.com/repos/natgeo/modules-activitystream/issues/comments/{number}","contents_url":"https://api.github.com/repos/natgeo/modules-activitystream/contents/{+path}","compare_url":"https://api.github.com/repos/natgeo/modules-activitystream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natgeo/modules-activitystream/merges","archive_url":"https://api.github.com/repos/natgeo/modules-activitystream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natgeo/modules-activitystream/downloads","issues_url":"https://api.github.com/repos/natgeo/modules-activitystream/issues{/number}","pulls_url":"https://api.github.com/repos/natgeo/modules-activitystream/pulls{/number}","milestones_url":"https://api.github.com/repos/natgeo/modules-activitystream/milestones{/number}","notifications_url":"https://api.github.com/repos/natgeo/modules-activitystream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natgeo/modules-activitystream/labels{/name}","releases_url":"https://api.github.com/repos/natgeo/modules-activitystream/releases{/id}","created_at":"2013-12-26T16:52:07Z","updated_at":"2014-12-18T14:37:47Z","pushed_at":"2014-12-18T17:56:52Z","git_url":"git://github.com/natgeo/modules-activitystream.git","ssh_url":"git@github.com:natgeo/modules-activitystream.git","clone_url":"https://github.com/natgeo/modules-activitystream.git","svn_url":"https://github.com/natgeo/modules-activitystream","homepage":null,"size":6480,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/natgeo/modules-activitystream/pulls/37"},"html":{"href":"https://github.com/natgeo/modules-activitystream/pull/37"},"issue":{"href":"https://api.github.com/repos/natgeo/modules-activitystream/issues/37"},"comments":{"href":"https://api.github.com/repos/natgeo/modules-activitystream/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/natgeo/modules-activitystream/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/natgeo/modules-activitystream/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/natgeo/modules-activitystream/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/natgeo/modules-activitystream/statuses/7f4c90bbefc8beb437c463ba81b78db2a29250ca"}}}}