GitHub PullRequestReviewCommentEvent at 2014-11-06 04:18:07
Repository: gaia
Actor: crh0716
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/19925775","id":19925775,"diff_hunk":"@@ -28,6 +29,48 @@\n     downloadsCache = {};\n   }\n \n+  function _getTypeFromOperation(operation) {\n+    var TYPES = { added: 'added' };\n+    return TYPES[operation] || 'unknown';\n+  }\n+\n+  function _updateDownloadsCacheWithDataStoreDownload(dsChange) {\n+    var getReq = DownloadStore.get(dsChange.id);\n+    getReq.onsuccess = function(event) {\n+      var entries = Object.keys(downloadsCache);\n+      var download = event.target.result;\n+\n+      var cachedDownload = null;\n+      for (var i = 0; i < entries.length; i++) {\n+        var downloadCacheEntry = downloadsCache[entries[i]];\n+        if (downloadCacheEntry.storageName == download.storageName &&\n+            downloadCacheEntry.storagePath == download.storagePath) {\n+          cachedDownload = downloadCacheEntry;\n+          break;\n+        }\n+      }\n+\n+      var changeEvent = {\n+        type: _getTypeFromOperation(dsChange.operation),\n+        download: download\n+      };\n+\n+      if (cachedDownload) {","path":"apps/settings/js/downloads/download_api_manager.js","position":38,"original_position":38,"commit_id":"bca3ee3cbc50f763b87710084ce2d80232fd7f62","original_commit_id":"bca3ee3cbc50f763b87710084ce2d80232fd7f62","user":{"login":"crh0716","id":2899280,"avatar_url":"https://avatars.githubusercontent.com/u/2899280?v=2","gravatar_id":"","url":"https://api.github.com/users/crh0716","html_url":"https://github.com/crh0716","followers_url":"https://api.github.com/users/crh0716/followers","following_url":"https://api.github.com/users/crh0716/following{/other_user}","gists_url":"https://api.github.com/users/crh0716/gists{/gist_id}","starred_url":"https://api.github.com/users/crh0716/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crh0716/subscriptions","organizations_url":"https://api.github.com/users/crh0716/orgs","repos_url":"https://api.github.com/users/crh0716/repos","events_url":"https://api.github.com/users/crh0716/events{/privacy}","received_events_url":"https://api.github.com/users/crh0716/received_events","type":"User","site_admin":false},"body":"If the `cachedDownload` is not available, then `downloadApiId` will be null. However, the case is not handled in `_downloadApiManagerListener`.","created_at":"2014-11-06T04:18:07Z","updated_at":"2014-11-06T04:18:07Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/25589#discussion_r19925775","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25589","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/19925775"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/25589#discussion_r19925775"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25589"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25589","id":23498823,"html_url":"https://github.com/mozilla-b2g/gaia/pull/25589","diff_url":"https://github.com/mozilla-b2g/gaia/pull/25589.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/25589.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/25589","number":25589,"state":"open","locked":false,"title":"bug 1077595 - Use DataStoreChangeEvents to update Download API Manager c...","user":{"login":"nullaus","id":1350717,"avatar_url":"https://avatars.githubusercontent.com/u/1350717?v=2","gravatar_id":"","url":"https://api.github.com/users/nullaus","html_url":"https://github.com/nullaus","followers_url":"https://api.github.com/users/nullaus/followers","following_url":"https://api.github.com/users/nullaus/following{/other_user}","gists_url":"https://api.github.com/users/nullaus/gists{/gist_id}","starred_url":"https://api.github.com/users/nullaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullaus/subscriptions","organizations_url":"https://api.github.com/users/nullaus/orgs","repos_url":"https://api.github.com/users/nullaus/repos","events_url":"https://api.github.com/users/nullaus/events{/privacy}","received_events_url":"https://api.github.com/users/nullaus/received_events","type":"User","site_admin":false},"body":"...ache up to date. Move tracking of active downloads into StatusBar instead of DownloadNotifications. r=crdlc,mhenretty","created_at":"2014-10-28T23:28:52Z","updated_at":"2014-11-06T04:18:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7810c953b69c952cda6755b5acf5e3a2f2ce5cfd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25589/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25589/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/25589/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/bca3ee3cbc50f763b87710084ce2d80232fd7f62","head":{"label":"nullaus:bug1077595","ref":"bug1077595","sha":"bca3ee3cbc50f763b87710084ce2d80232fd7f62","user":{"login":"nullaus","id":1350717,"avatar_url":"https://avatars.githubusercontent.com/u/1350717?v=2","gravatar_id":"","url":"https://api.github.com/users/nullaus","html_url":"https://github.com/nullaus","followers_url":"https://api.github.com/users/nullaus/followers","following_url":"https://api.github.com/users/nullaus/following{/other_user}","gists_url":"https://api.github.com/users/nullaus/gists{/gist_id}","starred_url":"https://api.github.com/users/nullaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullaus/subscriptions","organizations_url":"https://api.github.com/users/nullaus/orgs","repos_url":"https://api.github.com/users/nullaus/repos","events_url":"https://api.github.com/users/nullaus/events{/privacy}","received_events_url":"https://api.github.com/users/nullaus/received_events","type":"User","site_admin":false},"repo":{"id":20957242,"name":"gaia","full_name":"nullaus/gaia","owner":{"login":"nullaus","id":1350717,"avatar_url":"https://avatars.githubusercontent.com/u/1350717?v=2","gravatar_id":"","url":"https://api.github.com/users/nullaus","html_url":"https://github.com/nullaus","followers_url":"https://api.github.com/users/nullaus/followers","following_url":"https://api.github.com/users/nullaus/following{/other_user}","gists_url":"https://api.github.com/users/nullaus/gists{/gist_id}","starred_url":"https://api.github.com/users/nullaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullaus/subscriptions","organizations_url":"https://api.github.com/users/nullaus/orgs","repos_url":"https://api.github.com/users/nullaus/repos","events_url":"https://api.github.com/users/nullaus/events{/privacy}","received_events_url":"https://api.github.com/users/nullaus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nullaus/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/nullaus/gaia","forks_url":"https://api.github.com/repos/nullaus/gaia/forks","keys_url":"https://api.github.com/repos/nullaus/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nullaus/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nullaus/gaia/teams","hooks_url":"https://api.github.com/repos/nullaus/gaia/hooks","issue_events_url":"https://api.github.com/repos/nullaus/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/nullaus/gaia/events","assignees_url":"https://api.github.com/repos/nullaus/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/nullaus/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/nullaus/gaia/tags","blobs_url":"https://api.github.com/repos/nullaus/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nullaus/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nullaus/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/nullaus/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nullaus/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/nullaus/gaia/languages","stargazers_url":"https://api.github.com/repos/nullaus/gaia/stargazers","contributors_url":"https://api.github.com/repos/nullaus/gaia/contributors","subscribers_url":"https://api.github.com/repos/nullaus/gaia/subscribers","subscription_url":"https://api.github.com/repos/nullaus/gaia/subscription","commits_url":"https://api.github.com/repos/nullaus/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/nullaus/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/nullaus/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/nullaus/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/nullaus/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/nullaus/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nullaus/gaia/merges","archive_url":"https://api.github.com/repos/nullaus/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nullaus/gaia/downloads","issues_url":"https://api.github.com/repos/nullaus/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/nullaus/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/nullaus/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/nullaus/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nullaus/gaia/labels{/name}","releases_url":"https://api.github.com/repos/nullaus/gaia/releases{/id}","created_at":"2014-06-18T09:44:59Z","updated_at":"2014-06-25T21:46:00Z","pushed_at":"2014-11-06T00:24:26Z","git_url":"git://github.com/nullaus/gaia.git","ssh_url":"git@github.com:nullaus/gaia.git","clone_url":"https://github.com/nullaus/gaia.git","svn_url":"https://github.com/nullaus/gaia","homepage":"https://wiki.mozilla.org/B2G","size":869439,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"e92c982c75cfb9800e26f8a6672678b5b35f097e","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-11-06T02:33:09Z","pushed_at":"2014-11-06T04:05:39Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1526808,"stargazers_count":1784,"watchers_count":1784,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2037,"mirror_url":null,"open_issues_count":612,"forks":2037,"open_issues":612,"watchers":1784,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25589"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/25589"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/25589"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/25589/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25589/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/25589/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/bca3ee3cbc50f763b87710084ce2d80232fd7f62"}}}}