GitHub PullRequestReviewCommentEvent at 2014-11-20 17:12:57
Repository: traceur-compiler
Actor: arv
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/google/traceur-compiler/pulls/comments/20661238","id":20661238,"diff_hunk":"@@ -100,6 +130,29 @@\n           ex.loadedBy(this.url);\n           throw ex;\n         }\n+        if (ex.stack) {\n+          // Assume V8 stack format\n+          var lined = this.func.toString().split('\\n')","path":"src/runtime/ModuleStore.js","position":43,"original_position":43,"commit_id":"fe5bc1585dc012e8bab566af354ef70e4a9a9c4d","original_commit_id":"fe5bc1585dc012e8bab566af354ef70e4a9a9c4d","user":{"login":"arv","id":45845,"avatar_url":"https://avatars.githubusercontent.com/u/45845?v=3","gravatar_id":"","url":"https://api.github.com/users/arv","html_url":"https://github.com/arv","followers_url":"https://api.github.com/users/arv/followers","following_url":"https://api.github.com/users/arv/following{/other_user}","gists_url":"https://api.github.com/users/arv/gists{/gist_id}","starred_url":"https://api.github.com/users/arv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arv/subscriptions","organizations_url":"https://api.github.com/users/arv/orgs","repos_url":"https://api.github.com/users/arv/repos","events_url":"https://api.github.com/users/arv/events{/privacy}","received_events_url":"https://api.github.com/users/arv/received_events","type":"User","site_admin":false},"body":"lined -> lines","created_at":"2014-11-20T17:12:57Z","updated_at":"2014-11-20T17:12:57Z","html_url":"https://github.com/google/traceur-compiler/pull/1520#discussion_r20661238","pull_request_url":"https://api.github.com/repos/google/traceur-compiler/pulls/1520","_links":{"self":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/comments/20661238"},"html":{"href":"https://github.com/google/traceur-compiler/pull/1520#discussion_r20661238"},"pull_request":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/1520"}}},"pull_request":{"url":"https://api.github.com/repos/google/traceur-compiler/pulls/1520","id":24737721,"html_url":"https://github.com/google/traceur-compiler/pull/1520","diff_url":"https://github.com/google/traceur-compiler/pull/1520.diff","patch_url":"https://github.com/google/traceur-compiler/pull/1520.patch","issue_url":"https://api.github.com/repos/google/traceur-compiler/issues/1520","number":1520,"state":"open","locked":false,"title":"Format ModuleEvaluationError stacks as source.","user":{"login":"johnjbarton","id":205570,"avatar_url":"https://avatars.githubusercontent.com/u/205570?v=3","gravatar_id":"","url":"https://api.github.com/users/johnjbarton","html_url":"https://github.com/johnjbarton","followers_url":"https://api.github.com/users/johnjbarton/followers","following_url":"https://api.github.com/users/johnjbarton/following{/other_user}","gists_url":"https://api.github.com/users/johnjbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjbarton/subscriptions","organizations_url":"https://api.github.com/users/johnjbarton/orgs","repos_url":"https://api.github.com/users/johnjbarton/repos","events_url":"https://api.github.com/users/johnjbarton/events{/privacy}","received_events_url":"https://api.github.com/users/johnjbarton/received_events","type":"User","site_admin":false},"body":"Module evalution errors have stacks with line number in to functions bodies not files.\r\nPrint the source and indicate the errors by markers in the output.","created_at":"2014-11-20T02:01:38Z","updated_at":"2014-11-20T17:12:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd85bfb14c50a48ba4aebd9593478a92ac7ba315","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/traceur-compiler/pulls/1520/commits","review_comments_url":"https://api.github.com/repos/google/traceur-compiler/pulls/1520/comments","review_comment_url":"https://api.github.com/repos/google/traceur-compiler/pulls/comments/{number}","comments_url":"https://api.github.com/repos/google/traceur-compiler/issues/1520/comments","statuses_url":"https://api.github.com/repos/google/traceur-compiler/statuses/fe5bc1585dc012e8bab566af354ef70e4a9a9c4d","head":{"label":"johnjbarton:format-module-eval-stack","ref":"format-module-eval-stack","sha":"fe5bc1585dc012e8bab566af354ef70e4a9a9c4d","user":{"login":"johnjbarton","id":205570,"avatar_url":"https://avatars.githubusercontent.com/u/205570?v=3","gravatar_id":"","url":"https://api.github.com/users/johnjbarton","html_url":"https://github.com/johnjbarton","followers_url":"https://api.github.com/users/johnjbarton/followers","following_url":"https://api.github.com/users/johnjbarton/following{/other_user}","gists_url":"https://api.github.com/users/johnjbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjbarton/subscriptions","organizations_url":"https://api.github.com/users/johnjbarton/orgs","repos_url":"https://api.github.com/users/johnjbarton/repos","events_url":"https://api.github.com/users/johnjbarton/events{/privacy}","received_events_url":"https://api.github.com/users/johnjbarton/received_events","type":"User","site_admin":false},"repo":{"id":9091623,"name":"traceur-compiler","full_name":"johnjbarton/traceur-compiler","owner":{"login":"johnjbarton","id":205570,"avatar_url":"https://avatars.githubusercontent.com/u/205570?v=3","gravatar_id":"","url":"https://api.github.com/users/johnjbarton","html_url":"https://github.com/johnjbarton","followers_url":"https://api.github.com/users/johnjbarton/followers","following_url":"https://api.github.com/users/johnjbarton/following{/other_user}","gists_url":"https://api.github.com/users/johnjbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjbarton/subscriptions","organizations_url":"https://api.github.com/users/johnjbarton/orgs","repos_url":"https://api.github.com/users/johnjbarton/repos","events_url":"https://api.github.com/users/johnjbarton/events{/privacy}","received_events_url":"https://api.github.com/users/johnjbarton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnjbarton/traceur-compiler","description":"Traceur is a JavaScript.next-to-JavaScript-of-today compiler","fork":true,"url":"https://api.github.com/repos/johnjbarton/traceur-compiler","forks_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/forks","keys_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/teams","hooks_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/hooks","issue_events_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/events","assignees_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/tags","blobs_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/languages","stargazers_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/stargazers","contributors_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/contributors","subscribers_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/subscribers","subscription_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/subscription","commits_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/issues/comments/{number}","contents_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/merges","archive_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/downloads","issues_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/labels{/name}","releases_url":"https://api.github.com/repos/johnjbarton/traceur-compiler/releases{/id}","created_at":"2013-03-29T03:35:05Z","updated_at":"2014-11-20T16:54:39Z","pushed_at":"2014-11-20T16:54:38Z","git_url":"git://github.com/johnjbarton/traceur-compiler.git","ssh_url":"git@github.com:johnjbarton/traceur-compiler.git","clone_url":"https://github.com/johnjbarton/traceur-compiler.git","svn_url":"https://github.com/johnjbarton/traceur-compiler","homepage":"","size":26447,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"48513511dc342a1191659e21deae3e3fcf81115c","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9060347,"name":"traceur-compiler","full_name":"google/traceur-compiler","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/traceur-compiler","description":"Traceur is a JavaScript.next-to-JavaScript-of-today compiler","fork":false,"url":"https://api.github.com/repos/google/traceur-compiler","forks_url":"https://api.github.com/repos/google/traceur-compiler/forks","keys_url":"https://api.github.com/repos/google/traceur-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/traceur-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/traceur-compiler/teams","hooks_url":"https://api.github.com/repos/google/traceur-compiler/hooks","issue_events_url":"https://api.github.com/repos/google/traceur-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/google/traceur-compiler/events","assignees_url":"https://api.github.com/repos/google/traceur-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/google/traceur-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/google/traceur-compiler/tags","blobs_url":"https://api.github.com/repos/google/traceur-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/traceur-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/traceur-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/traceur-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/traceur-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/google/traceur-compiler/languages","stargazers_url":"https://api.github.com/repos/google/traceur-compiler/stargazers","contributors_url":"https://api.github.com/repos/google/traceur-compiler/contributors","subscribers_url":"https://api.github.com/repos/google/traceur-compiler/subscribers","subscription_url":"https://api.github.com/repos/google/traceur-compiler/subscription","commits_url":"https://api.github.com/repos/google/traceur-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/traceur-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/traceur-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/traceur-compiler/issues/comments/{number}","contents_url":"https://api.github.com/repos/google/traceur-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/google/traceur-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/traceur-compiler/merges","archive_url":"https://api.github.com/repos/google/traceur-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/traceur-compiler/downloads","issues_url":"https://api.github.com/repos/google/traceur-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/google/traceur-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/google/traceur-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/google/traceur-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/traceur-compiler/labels{/name}","releases_url":"https://api.github.com/repos/google/traceur-compiler/releases{/id}","created_at":"2013-03-27T18:05:40Z","updated_at":"2014-11-20T15:34:48Z","pushed_at":"2014-11-19T17:46:34Z","git_url":"git://github.com/google/traceur-compiler.git","ssh_url":"git@github.com:google/traceur-compiler.git","clone_url":"https://github.com/google/traceur-compiler.git","svn_url":"https://github.com/google/traceur-compiler","homepage":"","size":43971,"stargazers_count":3713,"watchers_count":3713,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":223,"mirror_url":null,"open_issues_count":221,"forks":223,"open_issues":221,"watchers":3713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/1520"},"html":{"href":"https://github.com/google/traceur-compiler/pull/1520"},"issue":{"href":"https://api.github.com/repos/google/traceur-compiler/issues/1520"},"comments":{"href":"https://api.github.com/repos/google/traceur-compiler/issues/1520/comments"},"review_comments":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/1520/comments"},"review_comment":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/1520/commits"},"statuses":{"href":"https://api.github.com/repos/google/traceur-compiler/statuses/fe5bc1585dc012e8bab566af354ef70e4a9a9c4d"}}}}