GitHub PullRequestReviewCommentEvent at 2014-06-23 17:04:12
Repository: distarray
Actor: cowlicks
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/enthought/distarray/pulls/comments/14086495","id":14086495,"diff_hunk":"@@ -139,6 +139,9 @@ def make_grid_shape(shape, dist, comm_size):\n         # Trivial case: all processes used for the one distributed dimension.\n         if comm_size >= shape[distdims[0]]:\n             dist_grid_shape = (shape[distdims[0]],)\n+        elif (('b' == shape[distdims[0]]) and","path":"distarray/metadata_utils.py","position":4,"original_position":4,"commit_id":"0f367388250bc453f817233ff5d0d01192f02800","original_commit_id":"0f367388250bc453f817233ff5d0d01192f02800","user":{"login":"cowlicks","id":598099,"avatar_url":"https://avatars.githubusercontent.com/u/598099?","gravatar_id":"97760e811af951a6b383a18865affefa","url":"https://api.github.com/users/cowlicks","html_url":"https://github.com/cowlicks","followers_url":"https://api.github.com/users/cowlicks/followers","following_url":"https://api.github.com/users/cowlicks/following{/other_user}","gists_url":"https://api.github.com/users/cowlicks/gists{/gist_id}","starred_url":"https://api.github.com/users/cowlicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowlicks/subscriptions","organizations_url":"https://api.github.com/users/cowlicks/orgs","repos_url":"https://api.github.com/users/cowlicks/repos","events_url":"https://api.github.com/users/cowlicks/events{/privacy}","received_events_url":"https://api.github.com/users/cowlicks/received_events","type":"User","site_admin":false},"body":"Yes this needs to be done on a per dimension basis.","created_at":"2014-06-23T17:04:12Z","updated_at":"2014-06-23T17:04:12Z","html_url":"https://github.com/enthought/distarray/pull/444#discussion_r14086495","pull_request_url":"https://api.github.com/repos/enthought/distarray/pulls/444","_links":{"self":{"href":"https://api.github.com/repos/enthought/distarray/pulls/comments/14086495"},"html":{"href":"https://github.com/enthought/distarray/pull/444#discussion_r14086495"},"pull_request":{"href":"https://api.github.com/repos/enthought/distarray/pulls/444"}}},"pull_request":{"url":"https://api.github.com/repos/enthought/distarray/pulls/444","id":17205684,"html_url":"https://github.com/enthought/distarray/pull/444","diff_url":"https://github.com/enthought/distarray/pull/444.diff","patch_url":"https://github.com/enthought/distarray/pull/444.patch","issue_url":"https://api.github.com/repos/enthought/distarray/issues/444","number":444,"state":"open","title":"Check for block shape/grid_shapes that would make empty localarrays.","user":{"login":"cowlicks","id":598099,"avatar_url":"https://avatars.githubusercontent.com/u/598099?","gravatar_id":"97760e811af951a6b383a18865affefa","url":"https://api.github.com/users/cowlicks","html_url":"https://github.com/cowlicks","followers_url":"https://api.github.com/users/cowlicks/followers","following_url":"https://api.github.com/users/cowlicks/following{/other_user}","gists_url":"https://api.github.com/users/cowlicks/gists{/gist_id}","starred_url":"https://api.github.com/users/cowlicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowlicks/subscriptions","organizations_url":"https://api.github.com/users/cowlicks/orgs","repos_url":"https://api.github.com/users/cowlicks/repos","events_url":"https://api.github.com/users/cowlicks/events{/privacy}","received_events_url":"https://api.github.com/users/cowlicks/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-16T22:02:23Z","updated_at":"2014-06-23T17:04:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1efacfc52022d1a9717fc32f297d0d80a6aadac4","assignee":null,"milestone":{"url":"https://api.github.com/repos/enthought/distarray/milestones/11","labels_url":"https://api.github.com/repos/enthought/distarray/milestones/11/labels","id":665302,"number":11,"title":"0.4","description":"Key milestones:\r\n* Distributed Slicing\r\n* Basic redistribution support\r\n* Interoperability with Trilinos via the DA protocol","creator":{"login":"kwmsmith","id":288771,"avatar_url":"https://avatars.githubusercontent.com/u/288771?","gravatar_id":"7cce33474c488e5a770c9cd39c691843","url":"https://api.github.com/users/kwmsmith","html_url":"https://github.com/kwmsmith","followers_url":"https://api.github.com/users/kwmsmith/followers","following_url":"https://api.github.com/users/kwmsmith/following{/other_user}","gists_url":"https://api.github.com/users/kwmsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/kwmsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwmsmith/subscriptions","organizations_url":"https://api.github.com/users/kwmsmith/orgs","repos_url":"https://api.github.com/users/kwmsmith/repos","events_url":"https://api.github.com/users/kwmsmith/events{/privacy}","received_events_url":"https://api.github.com/users/kwmsmith/received_events","type":"User","site_admin":false},"open_issues":51,"closed_issues":17,"state":"open","created_at":"2014-05-21T04:59:22Z","updated_at":"2014-06-21T19:17:06Z","due_on":"2014-06-30T07:00:00Z"},"commits_url":"https://api.github.com/repos/enthought/distarray/pulls/444/commits","review_comments_url":"https://api.github.com/repos/enthought/distarray/pulls/444/comments","review_comment_url":"https://api.github.com/repos/enthought/distarray/pulls/comments/{number}","comments_url":"https://api.github.com/repos/enthought/distarray/issues/444/comments","statuses_url":"https://api.github.com/repos/enthought/distarray/statuses/0f367388250bc453f817233ff5d0d01192f02800","head":{"label":"cowlicks:some-weird-shapes","ref":"some-weird-shapes","sha":"0f367388250bc453f817233ff5d0d01192f02800","user":{"login":"cowlicks","id":598099,"avatar_url":"https://avatars.githubusercontent.com/u/598099?","gravatar_id":"97760e811af951a6b383a18865affefa","url":"https://api.github.com/users/cowlicks","html_url":"https://github.com/cowlicks","followers_url":"https://api.github.com/users/cowlicks/followers","following_url":"https://api.github.com/users/cowlicks/following{/other_user}","gists_url":"https://api.github.com/users/cowlicks/gists{/gist_id}","starred_url":"https://api.github.com/users/cowlicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowlicks/subscriptions","organizations_url":"https://api.github.com/users/cowlicks/orgs","repos_url":"https://api.github.com/users/cowlicks/repos","events_url":"https://api.github.com/users/cowlicks/events{/privacy}","received_events_url":"https://api.github.com/users/cowlicks/received_events","type":"User","site_admin":false},"repo":{"id":16082902,"name":"distarray","full_name":"cowlicks/distarray","owner":{"login":"cowlicks","id":598099,"avatar_url":"https://avatars.githubusercontent.com/u/598099?","gravatar_id":"97760e811af951a6b383a18865affefa","url":"https://api.github.com/users/cowlicks","html_url":"https://github.com/cowlicks","followers_url":"https://api.github.com/users/cowlicks/followers","following_url":"https://api.github.com/users/cowlicks/following{/other_user}","gists_url":"https://api.github.com/users/cowlicks/gists{/gist_id}","starred_url":"https://api.github.com/users/cowlicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowlicks/subscriptions","organizations_url":"https://api.github.com/users/cowlicks/orgs","repos_url":"https://api.github.com/users/cowlicks/repos","events_url":"https://api.github.com/users/cowlicks/events{/privacy}","received_events_url":"https://api.github.com/users/cowlicks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cowlicks/distarray","description":"Distributed numpy array, based on IPython distributed array project from 2007ish.","fork":true,"url":"https://api.github.com/repos/cowlicks/distarray","forks_url":"https://api.github.com/repos/cowlicks/distarray/forks","keys_url":"https://api.github.com/repos/cowlicks/distarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cowlicks/distarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cowlicks/distarray/teams","hooks_url":"https://api.github.com/repos/cowlicks/distarray/hooks","issue_events_url":"https://api.github.com/repos/cowlicks/distarray/issues/events{/number}","events_url":"https://api.github.com/repos/cowlicks/distarray/events","assignees_url":"https://api.github.com/repos/cowlicks/distarray/assignees{/user}","branches_url":"https://api.github.com/repos/cowlicks/distarray/branches{/branch}","tags_url":"https://api.github.com/repos/cowlicks/distarray/tags","blobs_url":"https://api.github.com/repos/cowlicks/distarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cowlicks/distarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cowlicks/distarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/cowlicks/distarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cowlicks/distarray/statuses/{sha}","languages_url":"https://api.github.com/repos/cowlicks/distarray/languages","stargazers_url":"https://api.github.com/repos/cowlicks/distarray/stargazers","contributors_url":"https://api.github.com/repos/cowlicks/distarray/contributors","subscribers_url":"https://api.github.com/repos/cowlicks/distarray/subscribers","subscription_url":"https://api.github.com/repos/cowlicks/distarray/subscription","commits_url":"https://api.github.com/repos/cowlicks/distarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/cowlicks/distarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/cowlicks/distarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/cowlicks/distarray/issues/comments/{number}","contents_url":"https://api.github.com/repos/cowlicks/distarray/contents/{+path}","compare_url":"https://api.github.com/repos/cowlicks/distarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cowlicks/distarray/merges","archive_url":"https://api.github.com/repos/cowlicks/distarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cowlicks/distarray/downloads","issues_url":"https://api.github.com/repos/cowlicks/distarray/issues{/number}","pulls_url":"https://api.github.com/repos/cowlicks/distarray/pulls{/number}","milestones_url":"https://api.github.com/repos/cowlicks/distarray/milestones{/number}","notifications_url":"https://api.github.com/repos/cowlicks/distarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cowlicks/distarray/labels{/name}","releases_url":"https://api.github.com/repos/cowlicks/distarray/releases{/id}","created_at":"2014-01-20T20:45:40Z","updated_at":"2014-06-17T17:12:49Z","pushed_at":"2014-06-17T17:12:49Z","git_url":"git://github.com/cowlicks/distarray.git","ssh_url":"git@github.com:cowlicks/distarray.git","clone_url":"https://github.com/cowlicks/distarray.git","svn_url":"https://github.com/cowlicks/distarray","homepage":null,"size":8445,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"enthought:master","ref":"master","sha":"4405136092045ead22ac135a2c97a71144053881","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?","gravatar_id":"75fa7fb6cbe4892834aa36de4720282a","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":11927499,"name":"distarray","full_name":"enthought/distarray","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?","gravatar_id":"75fa7fb6cbe4892834aa36de4720282a","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/distarray","description":"NumPy-like distributed arrays, ufuncs, and more.  Think globally, act locally.","fork":false,"url":"https://api.github.com/repos/enthought/distarray","forks_url":"https://api.github.com/repos/enthought/distarray/forks","keys_url":"https://api.github.com/repos/enthought/distarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/distarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/distarray/teams","hooks_url":"https://api.github.com/repos/enthought/distarray/hooks","issue_events_url":"https://api.github.com/repos/enthought/distarray/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/distarray/events","assignees_url":"https://api.github.com/repos/enthought/distarray/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/distarray/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/distarray/tags","blobs_url":"https://api.github.com/repos/enthought/distarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/distarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/distarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/distarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/distarray/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/distarray/languages","stargazers_url":"https://api.github.com/repos/enthought/distarray/stargazers","contributors_url":"https://api.github.com/repos/enthought/distarray/contributors","subscribers_url":"https://api.github.com/repos/enthought/distarray/subscribers","subscription_url":"https://api.github.com/repos/enthought/distarray/subscription","commits_url":"https://api.github.com/repos/enthought/distarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/distarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/distarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/distarray/issues/comments/{number}","contents_url":"https://api.github.com/repos/enthought/distarray/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/distarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/distarray/merges","archive_url":"https://api.github.com/repos/enthought/distarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/distarray/downloads","issues_url":"https://api.github.com/repos/enthought/distarray/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/distarray/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/distarray/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/distarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/distarray/labels{/name}","releases_url":"https://api.github.com/repos/enthought/distarray/releases{/id}","created_at":"2013-08-06T15:28:35Z","updated_at":"2014-06-23T15:15:15Z","pushed_at":"2014-06-23T15:15:15Z","git_url":"git://github.com/enthought/distarray.git","ssh_url":"git@github.com:enthought/distarray.git","clone_url":"https://github.com/enthought/distarray.git","svn_url":"https://github.com/enthought/distarray","homepage":"distarray.readthedocs.org","size":15094,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":7,"mirror_url":null,"open_issues_count":72,"forks":7,"open_issues":72,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enthought/distarray/pulls/444"},"html":{"href":"https://github.com/enthought/distarray/pull/444"},"issue":{"href":"https://api.github.com/repos/enthought/distarray/issues/444"},"comments":{"href":"https://api.github.com/repos/enthought/distarray/issues/444/comments"},"review_comments":{"href":"https://api.github.com/repos/enthought/distarray/pulls/444/comments"},"review_comment":{"href":"https://api.github.com/repos/enthought/distarray/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/enthought/distarray/pulls/444/commits"},"statuses":{"href":"https://api.github.com/repos/enthought/distarray/statuses/0f367388250bc453f817233ff5d0d01192f02800"}}}}