GitHub PullRequestReviewCommentEvent at 2014-06-25 15:29:19
Repository: HPCC-Platform
Actor: jakesmith
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/14193019","id":14193019,"diff_hunk":"@@ -122,7 +124,7 @@ void WUiterate(ISashaCommand *cmd, const char *mask)\n             getLdsPath(\"Archive/WorkUnits\",path);\n         Owned<IFile> dir = createIFile(path.str());\n         StringBuffer masktmp;\n-        if (((mask==NULL)||(strcmp(mask,\"*\")==0))&&after.length()&&before.length()) {\n+        if (isWild&&after.length()&&before.length()) {","path":"dali/sasha/saarch.cpp","position":19,"original_position":19,"commit_id":"08b6fb5ac624671baedab2909e7442135b0144f9","original_commit_id":"08b6fb5ac624671baedab2909e7442135b0144f9","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?","gravatar_id":"8eff4f840b1605e58ce34b0c3b5eea5a","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"body":"Yes, well spotted.","created_at":"2014-06-25T15:29:19Z","updated_at":"2014-06-25T15:29:19Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6126#discussion_r14193019","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6126","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/14193019"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/6126#discussion_r14193019"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6126"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6126","id":17544014,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6126","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6126.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6126.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6126","number":6126,"state":"open","title":"HPCC-11775 Improve efficiency of WUiterate in Sasha","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?","gravatar_id":"8eff4f840b1605e58ce34b0c3b5eea5a","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"body":"WUiterate which scans and filters archives and online workunits,\r\naccessed Dali in an inefficient way, especially in the case of\r\nrequesting a single workunit.\r\n\r\nSigned-off-by: Jake Smith <jake.smith@lexisnexis.com>","created_at":"2014-06-24T16:58:31Z","updated_at":"2014-06-25T15:29:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f248e4840ee97c69b024da6ab5e7084353207aa3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6126/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6126/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6126/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/08b6fb5ac624671baedab2909e7442135b0144f9","head":{"label":"jakesmith:hpcc-11775","ref":"hpcc-11775","sha":"08b6fb5ac624671baedab2909e7442135b0144f9","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?","gravatar_id":"8eff4f840b1605e58ce34b0c3b5eea5a","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"repo":{"id":2041370,"name":"HPCC-Platform","full_name":"jakesmith/HPCC-Platform","owner":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?","gravatar_id":"8eff4f840b1605e58ce34b0c3b5eea5a","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakesmith/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/jakesmith/HPCC-Platform","forks_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/releases{/id}","created_at":"2011-07-13T10:47:52Z","updated_at":"2014-06-24T16:58:31Z","pushed_at":"2014-06-25T12:59:08Z","git_url":"git://github.com/jakesmith/HPCC-Platform.git","ssh_url":"git@github.com:jakesmith/HPCC-Platform.git","clone_url":"https://github.com/jakesmith/HPCC-Platform.git","svn_url":"https://github.com/jakesmith/HPCC-Platform","homepage":"www.hpccsystems.com","size":114188,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-4.2.6","ref":"candidate-4.2.6","sha":"efeea383e417d6ba0d461f11fb7871258bed3e01","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?","gravatar_id":"d982932571a14695b971d1b3b9dede2b","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?","gravatar_id":"d982932571a14695b971d1b3b9dede2b","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2014-06-25T12:26:08Z","pushed_at":"2014-06-25T15:19:55Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":242416,"stargazers_count":227,"watchers_count":227,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":82,"mirror_url":null,"open_issues_count":434,"forks":82,"open_issues":434,"watchers":227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6126"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/6126"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6126"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6126/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6126/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6126/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/08b6fb5ac624671baedab2909e7442135b0144f9"}}}}