GitHub PullRequestReviewCommentEvent at 2014-12-29 15:42:40
Repository: level_up_exercises
Actor: djkotowski
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/22315449","id":22315449,"diff_hunk":"@@ -0,0 +1,75 @@\n+Feature: Apply coupon/promotion\n+\n+\tAs a shopper\n+\tI want to be able to claim coupons and promotions on items I have in my cart\n+\tSo that I can save money on the items I want to purchase\n+\n+\tScenario: Cannot enter promotion when cart is empty\n+\t\tGiven a cart with no items\n+\t\tWhen I am on the cart checkout page\n+\t\tThen I should not be able to enter a promotion/coupon code\n+\n+\tScenario: Entering a coupon/promotion code\n+\t\tGiven a non-empty cart\n+\t\tWhen I am on the cart checkout page\n+\t\tThen I should be able to enter a code for a coupon or promotion\n+\n+\tScenario: Applying a valid coupon/promotion code\n+\t\tGiven a non-empty cart\n+\t\tWhen I am on the cart checkout page\n+\t\tAnd I enter a valid code for a coupon or promotion\n+\t\tThen I should see the relevant discout applied to my subtotal\n+\n+\tScenario: Applying an invalid coupon/promotion code\n+\t\tGiven a non-empty cart\n+\t\tWhen I am on the cart checkout page\n+\t\tAnd I enter an invalid code for a coupon or promotion\n+\t\tThen I should see a warning that code is invalid\n+\n+\tScenario: Applying an expired coupon/promotion code\n+\t\tGiven a non-empty cart\n+\t\tWhen I am on the cart checkout page\n+\t\tAnd I enter an expired code for a coupon or promotion\n+\t\tThen I should see a warning that code is expired\n+\n+\n+#============================================================================\n+# How specific do you need to be at the capybara level?\n+# Would the above suffice? If so, should the below (checking all the input \n+# possibilities) be done at a lower level (like rspec unit tests or within\n+# the capybara matchers themselves?)\n+#============================================================================\n+\n+Feature: Apply coupon/promotion\n+\n+\tAs a shopper\n+\tI want to be able to claim coupons and promotions on items I have in my cart\n+\tSo that I can save money on the items I want to purchase\n+    \n+    Background:\n+    \tGiven I have a cart with \"item_1\" at priced at \"price_1\"\n+\t\tAnd I add \"item_2\" at priced at \"price_2\"\n+\t\tAnd I have a subotal of \"(price_1 + price_2)\" # Can u do arithmetic here?\n+\n+    Scenario Outline:\n+        When I apply coupon #\"<coupon_code>\" for \"<$amount>\" off","path":"shopping_cart/features/coupons.feature","position":55,"original_position":55,"commit_id":"23933bf2773f0117cbf87db2d56608688a953520","original_commit_id":"23933bf2773f0117cbf87db2d56608688a953520","user":{"login":"djkotowski","id":2326295,"avatar_url":"https://avatars.githubusercontent.com/u/2326295?v=3","gravatar_id":"","url":"https://api.github.com/users/djkotowski","html_url":"https://github.com/djkotowski","followers_url":"https://api.github.com/users/djkotowski/followers","following_url":"https://api.github.com/users/djkotowski/following{/other_user}","gists_url":"https://api.github.com/users/djkotowski/gists{/gist_id}","starred_url":"https://api.github.com/users/djkotowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djkotowski/subscriptions","organizations_url":"https://api.github.com/users/djkotowski/orgs","repos_url":"https://api.github.com/users/djkotowski/repos","events_url":"https://api.github.com/users/djkotowski/events{/privacy}","received_events_url":"https://api.github.com/users/djkotowski/received_events","type":"User","site_admin":false},"body":"I would avoid using `$` in your column header.","created_at":"2014-12-29T15:42:40Z","updated_at":"2014-12-29T15:42:40Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/372#discussion_r22315449","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/372","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/22315449"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/372#discussion_r22315449"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/372"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/372","id":26473529,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/372","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/372.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/372.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/372","number":372,"state":"open","locked":false,"title":"Shopping cart/mabdeljalil","user":{"login":"msabdeljalil","id":5350720,"avatar_url":"https://avatars.githubusercontent.com/u/5350720?v=3","gravatar_id":"","url":"https://api.github.com/users/msabdeljalil","html_url":"https://github.com/msabdeljalil","followers_url":"https://api.github.com/users/msabdeljalil/followers","following_url":"https://api.github.com/users/msabdeljalil/following{/other_user}","gists_url":"https://api.github.com/users/msabdeljalil/gists{/gist_id}","starred_url":"https://api.github.com/users/msabdeljalil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabdeljalil/subscriptions","organizations_url":"https://api.github.com/users/msabdeljalil/orgs","repos_url":"https://api.github.com/users/msabdeljalil/repos","events_url":"https://api.github.com/users/msabdeljalil/events{/privacy}","received_events_url":"https://api.github.com/users/msabdeljalil/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-22T18:50:52Z","updated_at":"2014-12-29T15:42:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"faac8f79144f311ec23dec7987380132a32320b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/372/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/372/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/372/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/23933bf2773f0117cbf87db2d56608688a953520","head":{"label":"msabdeljalil:shopping-cart/mabdeljalil","ref":"shopping-cart/mabdeljalil","sha":"23933bf2773f0117cbf87db2d56608688a953520","user":{"login":"msabdeljalil","id":5350720,"avatar_url":"https://avatars.githubusercontent.com/u/5350720?v=3","gravatar_id":"","url":"https://api.github.com/users/msabdeljalil","html_url":"https://github.com/msabdeljalil","followers_url":"https://api.github.com/users/msabdeljalil/followers","following_url":"https://api.github.com/users/msabdeljalil/following{/other_user}","gists_url":"https://api.github.com/users/msabdeljalil/gists{/gist_id}","starred_url":"https://api.github.com/users/msabdeljalil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabdeljalil/subscriptions","organizations_url":"https://api.github.com/users/msabdeljalil/orgs","repos_url":"https://api.github.com/users/msabdeljalil/repos","events_url":"https://api.github.com/users/msabdeljalil/events{/privacy}","received_events_url":"https://api.github.com/users/msabdeljalil/received_events","type":"User","site_admin":false},"repo":{"id":25488411,"name":"level_up_exercises","full_name":"msabdeljalil/level_up_exercises","owner":{"login":"msabdeljalil","id":5350720,"avatar_url":"https://avatars.githubusercontent.com/u/5350720?v=3","gravatar_id":"","url":"https://api.github.com/users/msabdeljalil","html_url":"https://github.com/msabdeljalil","followers_url":"https://api.github.com/users/msabdeljalil/followers","following_url":"https://api.github.com/users/msabdeljalil/following{/other_user}","gists_url":"https://api.github.com/users/msabdeljalil/gists{/gist_id}","starred_url":"https://api.github.com/users/msabdeljalil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabdeljalil/subscriptions","organizations_url":"https://api.github.com/users/msabdeljalil/orgs","repos_url":"https://api.github.com/users/msabdeljalil/repos","events_url":"https://api.github.com/users/msabdeljalil/events{/privacy}","received_events_url":"https://api.github.com/users/msabdeljalil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msabdeljalil/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/msabdeljalil/level_up_exercises","forks_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/forks","keys_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/events","assignees_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/merges","archive_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/msabdeljalil/level_up_exercises/releases{/id}","created_at":"2014-10-20T21:57:02Z","updated_at":"2014-10-09T06:13:13Z","pushed_at":"2014-12-22T18:50:36Z","git_url":"git://github.com/msabdeljalil/level_up_exercises.git","ssh_url":"git@github.com:msabdeljalil/level_up_exercises.git","clone_url":"https://github.com/msabdeljalil/level_up_exercises.git","svn_url":"https://github.com/msabdeljalil/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":505,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"d6fb3782079429bc5629858bbd6c76ee3d4906b0","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2014-12-23T16:31:14Z","pushed_at":"2014-12-23T16:31:14Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":39009,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":4,"forks":52,"open_issues":4,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/372"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/372"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/372"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/372/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/372/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/372/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/23933bf2773f0117cbf87db2d56608688a953520"}}}}