GitHub PullRequestReviewCommentEvent at 2014-10-13 07:45:22
Repository: xbmc
Actor: wsnipex
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/18756536","id":18756536,"diff_hunk":"@@ -93,7 +94,7 @@ std::vector<androidPackage> CXBMCApp::m_applications;\n \n CXBMCApp::CXBMCApp(ANativeActivity* nativeActivity)\n   : CJNIContext(nativeActivity)\n-  , CJNIBroadcastReceiver(\"org/xbmc/xbmc/XBMCBroadcastReceiver\")\n+  , CJNIBroadcastReceiver(\"org.xbmc.kodi/XBMCBroadcastReceiver\")","path":"xbmc/android/activity/XBMCApp.cpp","position":13,"original_position":13,"commit_id":"276f85f9388e59279441594e610492e4a4c11b7a","original_commit_id":"276f85f9388e59279441594e610492e4a4c11b7a","user":{"login":"wsnipex","id":909455,"avatar_url":"https://avatars.githubusercontent.com/u/909455?v=2","gravatar_id":"","url":"https://api.github.com/users/wsnipex","html_url":"https://github.com/wsnipex","followers_url":"https://api.github.com/users/wsnipex/followers","following_url":"https://api.github.com/users/wsnipex/following{/other_user}","gists_url":"https://api.github.com/users/wsnipex/gists{/gist_id}","starred_url":"https://api.github.com/users/wsnipex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsnipex/subscriptions","organizations_url":"https://api.github.com/users/wsnipex/orgs","repos_url":"https://api.github.com/users/wsnipex/repos","events_url":"https://api.github.com/users/wsnipex/events{/privacy}","received_events_url":"https://api.github.com/users/wsnipex/received_events","type":"User","site_admin":false},"body":"no lol, koying already found this replace error, we/I just forgot about it again :) Will fix.","created_at":"2014-10-13T07:45:22Z","updated_at":"2014-10-13T07:45:22Z","html_url":"https://github.com/xbmc/xbmc/pull/5216#discussion_r18756536","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5216","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/18756536"},"html":{"href":"https://github.com/xbmc/xbmc/pull/5216#discussion_r18756536"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5216"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/5216","id":19787406,"html_url":"https://github.com/xbmc/xbmc/pull/5216","diff_url":"https://github.com/xbmc/xbmc/pull/5216.diff","patch_url":"https://github.com/xbmc/xbmc/pull/5216.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/5216","number":5216,"state":"open","locked":false,"title":"[darwin] - rebrand packages and binaries to Kodi","user":{"login":"Memphiz","id":701326,"avatar_url":"https://avatars.githubusercontent.com/u/701326?v=2","gravatar_id":"","url":"https://api.github.com/users/Memphiz","html_url":"https://github.com/Memphiz","followers_url":"https://api.github.com/users/Memphiz/followers","following_url":"https://api.github.com/users/Memphiz/following{/other_user}","gists_url":"https://api.github.com/users/Memphiz/gists{/gist_id}","starred_url":"https://api.github.com/users/Memphiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Memphiz/subscriptions","organizations_url":"https://api.github.com/users/Memphiz/orgs","repos_url":"https://api.github.com/users/Memphiz/repos","events_url":"https://api.github.com/users/Memphiz/events{/privacy}","received_events_url":"https://api.github.com/users/Memphiz/received_events","type":"User","site_admin":false},"body":"This PR is not complete yet - but i want it to be open as a placeholder (and so that nobody doubles my work here). In general i used the @APP_NAME@ and CCompilerInfo::GetAppName where i could.\r\n\r\nWhat is already done:\r\n\r\n1. iOS rebrand is complete\r\n a. app id is changed to org.xbmc.kodi-ios (xbmc foundation, kodi product, ios platform)\r\n b. The postinstallation script of the debian package detects a side by side situation and copys the complete XBMC folder over to the Kodi folder. It also informs the user that this task my last some minutes.\r\n c. XBMC can live side by side with Kodi with complete seperated settings...\r\n d. All Binaries and Folders are either renamed to Kodi or to project agnostic strings (like XBMCHome -> AppHome)\r\n\r\n2. OSX rebrand nearly complete\r\n a. The migration from XBMC data to Kodi data is implemented in the g_application.preflight (which runs a perl script) - though there is no visual feedback for the user yet (our window is not even up at that point) - and on a 4GB XBMC folder it lasts a couple of minutes on HDD. Anybody has an idea how to popup a messagebox during the copy from perl? (maybe some apple script or so?) - any input @amet or @jmarshallnz\r\n\r\n3. ATV2 rebrand - this one is a bitch:\r\n a. app id is changed to org.xbmc.kodi-atv2 (xbmc foundation, kodi product, atv2 platform)\r\n b. The postinstallation script of the debian package detects a side by side situation and copys the complete XBMC folder over to the Kodi folder. It also informs the user that this task my last some minutes.\r\n c. All Binaries and Folders are either renamed to Kodi or to project agnostic strings (like XBMCHome -> AppHome)\r\n d. At the moment i didn't get the rebranded version to run. The problem is that all apps on ATV2 are plugins. It complains about a lot of classes which are already presented by our XBMC dylib (behaviour is undefined) - also it doesn't pick up the right principal class (so it just crashes in a loop)\r\ne. I have no clue if we find a real solution for allowing side by side installation of XBMC and Kodi\r\n\r\n@davilla feel free to jump in. \r\n\r\nAlso as you can see this is not ment to be reviewed yet (needs a heap of squashing).\r\n\r\n@topfs2 fyi ping","created_at":"2014-08-14T13:35:35Z","updated_at":"2014-10-13T07:45:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a581e22567eb4a37b4f48ac62cb552eae1577e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5216/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5216/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/5216/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/276f85f9388e59279441594e610492e4a4c11b7a","head":{"label":"Memphiz:osxrebrand","ref":"osxrebrand","sha":"276f85f9388e59279441594e610492e4a4c11b7a","user":{"login":"Memphiz","id":701326,"avatar_url":"https://avatars.githubusercontent.com/u/701326?v=2","gravatar_id":"","url":"https://api.github.com/users/Memphiz","html_url":"https://github.com/Memphiz","followers_url":"https://api.github.com/users/Memphiz/followers","following_url":"https://api.github.com/users/Memphiz/following{/other_user}","gists_url":"https://api.github.com/users/Memphiz/gists{/gist_id}","starred_url":"https://api.github.com/users/Memphiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Memphiz/subscriptions","organizations_url":"https://api.github.com/users/Memphiz/orgs","repos_url":"https://api.github.com/users/Memphiz/repos","events_url":"https://api.github.com/users/Memphiz/events{/privacy}","received_events_url":"https://api.github.com/users/Memphiz/received_events","type":"User","site_admin":false},"repo":{"id":1550525,"name":"xbmc","full_name":"Memphiz/xbmc","owner":{"login":"Memphiz","id":701326,"avatar_url":"https://avatars.githubusercontent.com/u/701326?v=2","gravatar_id":"","url":"https://api.github.com/users/Memphiz","html_url":"https://github.com/Memphiz","followers_url":"https://api.github.com/users/Memphiz/followers","following_url":"https://api.github.com/users/Memphiz/following{/other_user}","gists_url":"https://api.github.com/users/Memphiz/gists{/gist_id}","starred_url":"https://api.github.com/users/Memphiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Memphiz/subscriptions","organizations_url":"https://api.github.com/users/Memphiz/orgs","repos_url":"https://api.github.com/users/Memphiz/repos","events_url":"https://api.github.com/users/Memphiz/events{/privacy}","received_events_url":"https://api.github.com/users/Memphiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Memphiz/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/Memphiz/xbmc","forks_url":"https://api.github.com/repos/Memphiz/xbmc/forks","keys_url":"https://api.github.com/repos/Memphiz/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Memphiz/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Memphiz/xbmc/teams","hooks_url":"https://api.github.com/repos/Memphiz/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Memphiz/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Memphiz/xbmc/events","assignees_url":"https://api.github.com/repos/Memphiz/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Memphiz/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Memphiz/xbmc/tags","blobs_url":"https://api.github.com/repos/Memphiz/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Memphiz/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Memphiz/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Memphiz/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Memphiz/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Memphiz/xbmc/languages","stargazers_url":"https://api.github.com/repos/Memphiz/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Memphiz/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Memphiz/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Memphiz/xbmc/subscription","commits_url":"https://api.github.com/repos/Memphiz/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Memphiz/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Memphiz/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Memphiz/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/Memphiz/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Memphiz/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Memphiz/xbmc/merges","archive_url":"https://api.github.com/repos/Memphiz/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Memphiz/xbmc/downloads","issues_url":"https://api.github.com/repos/Memphiz/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Memphiz/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Memphiz/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Memphiz/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Memphiz/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Memphiz/xbmc/releases{/id}","created_at":"2011-03-31T11:10:34Z","updated_at":"2014-06-25T22:19:29Z","pushed_at":"2014-10-13T05:37:54Z","git_url":"git://github.com/Memphiz/xbmc.git","ssh_url":"git@github.com:Memphiz/xbmc.git","clone_url":"https://github.com/Memphiz/xbmc.git","svn_url":"https://github.com/Memphiz/xbmc","homepage":"http://xbmc.org","size":655890,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":5,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"5b03274f2adffcd6b848690457be696f13d2c70a","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=2","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=2","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"XBMC Main Repository","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2014-10-12T18:19:38Z","pushed_at":"2014-10-12T09:44:42Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://xbmc.org","size":1784446,"stargazers_count":3400,"watchers_count":3400,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2404,"mirror_url":null,"open_issues_count":187,"forks":2404,"open_issues":187,"watchers":3400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5216"},"html":{"href":"https://github.com/xbmc/xbmc/pull/5216"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/5216"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/5216/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5216/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5216/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/276f85f9388e59279441594e610492e4a4c11b7a"}}}}