GitHub PullRequestReviewCommentEvent at 2014-08-30 10:20:28
Repository: citra
Actor: neobrain
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/16929139","id":16929139,"diff_hunk":"@@ -96,6 +96,7 @@ public:\n     void MakeCurrent();\n     void DoneCurrent();\n     void PollEvents();\n+    void GetFramebufferSize(int& fbWidth, int& fbHeight);","path":"src/citra_qt/bootmanager.hxx","position":4,"original_position":4,"commit_id":"a1c0227d05b0575776efa51520f50eaffc29152f","original_commit_id":"a1c0227d05b0575776efa51520f50eaffc29152f","user":{"login":"neobrain","id":4840017,"avatar_url":"https://avatars.githubusercontent.com/u/4840017?v=2","gravatar_id":"0e2ad4f720c57b96ab4bc6a24c2b59fd","url":"https://api.github.com/users/neobrain","html_url":"https://github.com/neobrain","followers_url":"https://api.github.com/users/neobrain/followers","following_url":"https://api.github.com/users/neobrain/following{/other_user}","gists_url":"https://api.github.com/users/neobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/neobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neobrain/subscriptions","organizations_url":"https://api.github.com/users/neobrain/orgs","repos_url":"https://api.github.com/users/neobrain/repos","events_url":"https://api.github.com/users/neobrain/events{/privacy}","received_events_url":"https://api.github.com/users/neobrain/received_events","type":"User","site_admin":false},"body":"@bunnei what does our coding style say about this?\r\n\r\nAlternatives are:\r\n\r\n* pass by pointer\r\n* return `std::pair<u32,u32>`\r\n","created_at":"2014-08-30T10:20:28Z","updated_at":"2014-08-30T10:20:28Z","html_url":"https://github.com/citra-emu/citra/pull/85#discussion_r16929139","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/16929139"},"html":{"href":"https://github.com/citra-emu/citra/pull/85#discussion_r16929139"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/85","id":20533525,"html_url":"https://github.com/citra-emu/citra/pull/85","diff_url":"https://github.com/citra-emu/citra/pull/85.diff","patch_url":"https://github.com/citra-emu/citra/pull/85.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/85","number":85,"state":"open","locked":false,"title":"Viewport scaling and display density independence","user":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars.githubusercontent.com/u/1374024?v=2","gravatar_id":"0f418291150bf97d1b5cf2dfd5cc051c","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"body":"<b>Viewport Scaling</b>\r\nThe view is scaled to be as large as possible, without changing the aspect, within the bounds of the window.\r\n\r\n<b>Display Density Independence</b>\r\nOn \"retina\" displays, or other displays where window units != pixels, the view should no longer draw incorrectly.\r\n\r\n<b>Notes:</b>\r\n* I couldn't test with Qt (on a Mac and not getting the right GL context). I suspect it might not be fixed on high density displays. See in-line comment.\r\n* I originally made these changes on top of #83, so it should be good to go before or after that PR.","created_at":"2014-08-30T07:55:26Z","updated_at":"2014-08-30T10:20:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91af318c3de715c9a8c33afad39c6fa4691482b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/85/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/85/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/85/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/a1c0227d05b0575776efa51520f50eaffc29152f","head":{"label":"kevinhartman:viewport-scaling","ref":"viewport-scaling","sha":"a1c0227d05b0575776efa51520f50eaffc29152f","user":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars.githubusercontent.com/u/1374024?v=2","gravatar_id":"0f418291150bf97d1b5cf2dfd5cc051c","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"repo":{"id":22826744,"name":"citra","full_name":"kevinhartman/citra","owner":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars.githubusercontent.com/u/1374024?v=2","gravatar_id":"0f418291150bf97d1b5cf2dfd5cc051c","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevinhartman/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/kevinhartman/citra","forks_url":"https://api.github.com/repos/kevinhartman/citra/forks","keys_url":"https://api.github.com/repos/kevinhartman/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevinhartman/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevinhartman/citra/teams","hooks_url":"https://api.github.com/repos/kevinhartman/citra/hooks","issue_events_url":"https://api.github.com/repos/kevinhartman/citra/issues/events{/number}","events_url":"https://api.github.com/repos/kevinhartman/citra/events","assignees_url":"https://api.github.com/repos/kevinhartman/citra/assignees{/user}","branches_url":"https://api.github.com/repos/kevinhartman/citra/branches{/branch}","tags_url":"https://api.github.com/repos/kevinhartman/citra/tags","blobs_url":"https://api.github.com/repos/kevinhartman/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevinhartman/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevinhartman/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevinhartman/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevinhartman/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/kevinhartman/citra/languages","stargazers_url":"https://api.github.com/repos/kevinhartman/citra/stargazers","contributors_url":"https://api.github.com/repos/kevinhartman/citra/contributors","subscribers_url":"https://api.github.com/repos/kevinhartman/citra/subscribers","subscription_url":"https://api.github.com/repos/kevinhartman/citra/subscription","commits_url":"https://api.github.com/repos/kevinhartman/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevinhartman/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevinhartman/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevinhartman/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/kevinhartman/citra/contents/{+path}","compare_url":"https://api.github.com/repos/kevinhartman/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevinhartman/citra/merges","archive_url":"https://api.github.com/repos/kevinhartman/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevinhartman/citra/downloads","issues_url":"https://api.github.com/repos/kevinhartman/citra/issues{/number}","pulls_url":"https://api.github.com/repos/kevinhartman/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/kevinhartman/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/kevinhartman/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevinhartman/citra/labels{/name}","releases_url":"https://api.github.com/repos/kevinhartman/citra/releases{/id}","created_at":"2014-08-11T04:25:22Z","updated_at":"2014-08-24T03:41:52Z","pushed_at":"2014-08-30T07:34:40Z","git_url":"git://github.com/kevinhartman/citra.git","ssh_url":"git@github.com:kevinhartman/citra.git","clone_url":"https://github.com/kevinhartman/citra.git","svn_url":"https://github.com/kevinhartman/citra","homepage":null,"size":4119,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"06864c93fdf41ed383aadc3a76c40cb4725051b0","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=2","gravatar_id":null,"url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=2","gravatar_id":null,"url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2014-08-30T08:38:21Z","pushed_at":"2014-08-28T22:18:21Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":7584,"stargazers_count":168,"watchers_count":168,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":48,"mirror_url":null,"open_issues_count":10,"forks":48,"open_issues":10,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/85"},"html":{"href":"https://github.com/citra-emu/citra/pull/85"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/85"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/a1c0227d05b0575776efa51520f50eaffc29152f"}}}}