GitHub PullRequestReviewCommentEvent at 2014-10-24 20:24:14
Repository: puppetlabs-concat
Actor: jhoblitt
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls/comments/19362128","id":19362128,"diff_hunk":"@@ -24,6 +24,21 @@\n   c.before :suite do\n     # Install module and dependencies\n     hosts.each do |host|\n+      if fact_on(host, 'osfamily') == 'windows'\n+        require 'fixtures/certs.rb'\n+\n+        #Install certs to let PMT work on windows agents\n+        #Installing Geotrust CA cert\n+        create_remote_file(host, \"geotrustglobal.pem\", GEOTRUST_GLOBAL_CA)\n+        on(host, \"chmod 644 geotrustglobal.pem\")\n+        on(host, \"cmd /c certutil -v -addstore Root `cygpath -w geotrustglobal.pem`\")","path":"spec/spec_helper_acceptance.rb","position":11,"original_position":11,"commit_id":"12446c983e18ee56bd7e89c0672e1e64652a5557","original_commit_id":"12446c983e18ee56bd7e89c0672e1e64652a5557","user":{"login":"jhoblitt","id":948901,"avatar_url":"https://avatars.githubusercontent.com/u/948901?v=2","gravatar_id":"","url":"https://api.github.com/users/jhoblitt","html_url":"https://github.com/jhoblitt","followers_url":"https://api.github.com/users/jhoblitt/followers","following_url":"https://api.github.com/users/jhoblitt/following{/other_user}","gists_url":"https://api.github.com/users/jhoblitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jhoblitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhoblitt/subscriptions","organizations_url":"https://api.github.com/users/jhoblitt/orgs","repos_url":"https://api.github.com/users/jhoblitt/repos","events_url":"https://api.github.com/users/jhoblitt/events{/privacy}","received_events_url":"https://api.github.com/users/jhoblitt/received_events","type":"User","site_admin":false},"body":"Ugh - this is unfortunate.  Is there a way to disable PMT's cert validation?  If not, I think downloading the cert is slightly more desireable than baking it into the repo.","created_at":"2014-10-24T20:24:14Z","updated_at":"2014-10-24T20:24:14Z","html_url":"https://github.com/puppetlabs/puppetlabs-concat/pull/238#discussion_r19362128","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls/238","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls/comments/19362128"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-concat/pull/238#discussion_r19362128"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls/238"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls/238","id":23317904,"html_url":"https://github.com/puppetlabs/puppetlabs-concat/pull/238","diff_url":"https://github.com/puppetlabs/puppetlabs-concat/pull/238.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-concat/pull/238.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/issues/238","number":238,"state":"open","locked":false,"title":"Install certs on windows","user":{"login":"mhaskel","id":553464,"avatar_url":"https://avatars.githubusercontent.com/u/553464?v=2","gravatar_id":"","url":"https://api.github.com/users/mhaskel","html_url":"https://github.com/mhaskel","followers_url":"https://api.github.com/users/mhaskel/followers","following_url":"https://api.github.com/users/mhaskel/following{/other_user}","gists_url":"https://api.github.com/users/mhaskel/gists{/gist_id}","starred_url":"https://api.github.com/users/mhaskel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhaskel/subscriptions","organizations_url":"https://api.github.com/users/mhaskel/orgs","repos_url":"https://api.github.com/users/mhaskel/repos","events_url":"https://api.github.com/users/mhaskel/events{/privacy}","received_events_url":"https://api.github.com/users/mhaskel/received_events","type":"User","site_admin":false},"body":"This should allow the install of stdlib to succeed.","created_at":"2014-10-24T19:10:49Z","updated_at":"2014-10-24T20:24:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d2c5a078eb5dbf574ed93ff0e14b8119ebe556b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls/238/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls/238/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/issues/238/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/statuses/12446c983e18ee56bd7e89c0672e1e64652a5557","head":{"label":"mhaskel:windows_cert_fix","ref":"windows_cert_fix","sha":"12446c983e18ee56bd7e89c0672e1e64652a5557","user":{"login":"mhaskel","id":553464,"avatar_url":"https://avatars.githubusercontent.com/u/553464?v=2","gravatar_id":"","url":"https://api.github.com/users/mhaskel","html_url":"https://github.com/mhaskel","followers_url":"https://api.github.com/users/mhaskel/followers","following_url":"https://api.github.com/users/mhaskel/following{/other_user}","gists_url":"https://api.github.com/users/mhaskel/gists{/gist_id}","starred_url":"https://api.github.com/users/mhaskel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhaskel/subscriptions","organizations_url":"https://api.github.com/users/mhaskel/orgs","repos_url":"https://api.github.com/users/mhaskel/repos","events_url":"https://api.github.com/users/mhaskel/events{/privacy}","received_events_url":"https://api.github.com/users/mhaskel/received_events","type":"User","site_admin":false},"repo":{"id":19475411,"name":"puppetlabs-concat","full_name":"mhaskel/puppetlabs-concat","owner":{"login":"mhaskel","id":553464,"avatar_url":"https://avatars.githubusercontent.com/u/553464?v=2","gravatar_id":"","url":"https://api.github.com/users/mhaskel","html_url":"https://github.com/mhaskel","followers_url":"https://api.github.com/users/mhaskel/followers","following_url":"https://api.github.com/users/mhaskel/following{/other_user}","gists_url":"https://api.github.com/users/mhaskel/gists{/gist_id}","starred_url":"https://api.github.com/users/mhaskel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhaskel/subscriptions","organizations_url":"https://api.github.com/users/mhaskel/orgs","repos_url":"https://api.github.com/users/mhaskel/repos","events_url":"https://api.github.com/users/mhaskel/events{/privacy}","received_events_url":"https://api.github.com/users/mhaskel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhaskel/puppetlabs-concat","description":"File concatenation system for Puppet","fork":true,"url":"https://api.github.com/repos/mhaskel/puppetlabs-concat","forks_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/forks","keys_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/teams","hooks_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/hooks","issue_events_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/issues/events{/number}","events_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/events","assignees_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/assignees{/user}","branches_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/branches{/branch}","tags_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/tags","blobs_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/statuses/{sha}","languages_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/languages","stargazers_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/stargazers","contributors_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/contributors","subscribers_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/subscribers","subscription_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/subscription","commits_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/issues/comments/{number}","contents_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/contents/{+path}","compare_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/merges","archive_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/downloads","issues_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/issues{/number}","pulls_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/pulls{/number}","milestones_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/milestones{/number}","notifications_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/labels{/name}","releases_url":"https://api.github.com/repos/mhaskel/puppetlabs-concat/releases{/id}","created_at":"2014-05-06T00:12:00Z","updated_at":"2014-07-29T21:02:07Z","pushed_at":"2014-10-24T19:22:49Z","git_url":"git://github.com/mhaskel/puppetlabs-concat.git","ssh_url":"git@github.com:mhaskel/puppetlabs-concat.git","clone_url":"https://github.com/mhaskel/puppetlabs-concat.git","svn_url":"https://github.com/mhaskel/puppetlabs-concat","homepage":"http://www.devco.net/","size":830,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"644fb1b6dc8b64accc4d1208d6127b79a08a38b7","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":652130,"name":"puppetlabs-concat","full_name":"puppetlabs/puppetlabs-concat","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=2","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-concat","description":"File concatenation system for Puppet","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/releases{/id}","created_at":"2010-05-06T21:49:50Z","updated_at":"2014-10-16T15:14:42Z","pushed_at":"2014-10-08T22:18:09Z","git_url":"git://github.com/puppetlabs/puppetlabs-concat.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-concat.git","clone_url":"https://github.com/puppetlabs/puppetlabs-concat.git","svn_url":"https://github.com/puppetlabs/puppetlabs-concat","homepage":"http://www.devco.net/","size":2701,"stargazers_count":154,"watchers_count":154,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":232,"mirror_url":null,"open_issues_count":11,"forks":232,"open_issues":11,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls/238"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-concat/pull/238"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/issues/238"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-concat/statuses/12446c983e18ee56bd7e89c0672e1e64652a5557"}}}}