GitHub PullRequestReviewCommentEvent at 2014-11-06 17:00:42
Repository: flood
Actor: pboyer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pboyer/flood/pulls/comments/19957700","id":19957700,"diff_hunk":"@@ -405,17 +408,26 @@ define(['backbone', 'FLOOD', 'staticHelpers'], function (Backbone, FLOOD, static\n         // if we have line strips\n         if (graphicData.lineStripVertices && graphicData.lineStripVertices.length\n             && graphicData.lineStripCounts && graphicData.lineStripCounts.length) {\n-            var curve, count, oneVertex;\n+            var curve, count, oneVertex, pos = 0;\n+\n             for (var k = 0; k < graphicData.lineStripCounts.length; k++) {\n                 curve = { linestrip: []};\n                 count = graphicData.lineStripCounts[k];\n \n-                while (count > 0 && graphicData.lineStripVertices.length >= graphicData.numberOfCoordinates) {\n-                    oneVertex = graphicData.lineStripVertices.splice(0, graphicData.numberOfCoordinates);\n+                if(!count){\n+                    continue;\n+                }\n+\n+                for(var i = pos; i < pos + count; i++){","path":"app/scripts/models/nodes/Node.js","position":34,"original_position":34,"commit_id":"4bfdeba2cdd196736a6f087979d462e42fd49972","original_commit_id":"4bfdeba2cdd196736a6f087979d462e42fd49972","user":{"login":"pboyer","id":916345,"avatar_url":"https://avatars.githubusercontent.com/u/916345?v=2","gravatar_id":"","url":"https://api.github.com/users/pboyer","html_url":"https://github.com/pboyer","followers_url":"https://api.github.com/users/pboyer/followers","following_url":"https://api.github.com/users/pboyer/following{/other_user}","gists_url":"https://api.github.com/users/pboyer/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyer/subscriptions","organizations_url":"https://api.github.com/users/pboyer/orgs","repos_url":"https://api.github.com/users/pboyer/repos","events_url":"https://api.github.com/users/pboyer/events{/privacy}","received_events_url":"https://api.github.com/users/pboyer/received_events","type":"User","site_admin":false},"body":"Again, remove the math in the second statement.","created_at":"2014-11-06T17:00:42Z","updated_at":"2014-11-06T17:00:42Z","html_url":"https://github.com/pboyer/flood/pull/51#discussion_r19957700","pull_request_url":"https://api.github.com/repos/pboyer/flood/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/pboyer/flood/pulls/comments/19957700"},"html":{"href":"https://github.com/pboyer/flood/pull/51#discussion_r19957700"},"pull_request":{"href":"https://api.github.com/repos/pboyer/flood/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/pboyer/flood/pulls/51","id":23898056,"html_url":"https://github.com/pboyer/flood/pull/51","diff_url":"https://github.com/pboyer/flood/pull/51.diff","patch_url":"https://github.com/pboyer/flood/pull/51.patch","issue_url":"https://api.github.com/repos/pboyer/flood/issues/51","number":51,"state":"open","locked":false,"title":"Geometry parsing and \"Running\" icon fix.","user":{"login":"pbidenko","id":2545968,"avatar_url":"https://avatars.githubusercontent.com/u/2545968?v=2","gravatar_id":"","url":"https://api.github.com/users/pbidenko","html_url":"https://github.com/pbidenko","followers_url":"https://api.github.com/users/pbidenko/followers","following_url":"https://api.github.com/users/pbidenko/following{/other_user}","gists_url":"https://api.github.com/users/pbidenko/gists{/gist_id}","starred_url":"https://api.github.com/users/pbidenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbidenko/subscriptions","organizations_url":"https://api.github.com/users/pbidenko/orgs","repos_url":"https://api.github.com/users/pbidenko/repos","events_url":"https://api.github.com/users/pbidenko/events{/privacy}","received_events_url":"https://api.github.com/users/pbidenko/received_events","type":"User","site_admin":false},"body":"In this PR I fixed a couple of issues:\r\n\r\nREACH-80 \"Running\" icon never seems to disappear.\r\nOptimization of geometry parsing.","created_at":"2014-11-05T11:00:43Z","updated_at":"2014-11-06T17:00:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"feca1c8d408d91d252d41546e8edb558cfb6292d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pboyer/flood/pulls/51/commits","review_comments_url":"https://api.github.com/repos/pboyer/flood/pulls/51/comments","review_comment_url":"https://api.github.com/repos/pboyer/flood/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pboyer/flood/issues/51/comments","statuses_url":"https://api.github.com/repos/pboyer/flood/statuses/4bfdeba2cdd196736a6f087979d462e42fd49972","head":{"label":"pbidenko:Geometry","ref":"Geometry","sha":"4bfdeba2cdd196736a6f087979d462e42fd49972","user":{"login":"pbidenko","id":2545968,"avatar_url":"https://avatars.githubusercontent.com/u/2545968?v=2","gravatar_id":"","url":"https://api.github.com/users/pbidenko","html_url":"https://github.com/pbidenko","followers_url":"https://api.github.com/users/pbidenko/followers","following_url":"https://api.github.com/users/pbidenko/following{/other_user}","gists_url":"https://api.github.com/users/pbidenko/gists{/gist_id}","starred_url":"https://api.github.com/users/pbidenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbidenko/subscriptions","organizations_url":"https://api.github.com/users/pbidenko/orgs","repos_url":"https://api.github.com/users/pbidenko/repos","events_url":"https://api.github.com/users/pbidenko/events{/privacy}","received_events_url":"https://api.github.com/users/pbidenko/received_events","type":"User","site_admin":false},"repo":{"id":21495246,"name":"flood","full_name":"pbidenko/flood","owner":{"login":"pbidenko","id":2545968,"avatar_url":"https://avatars.githubusercontent.com/u/2545968?v=2","gravatar_id":"","url":"https://api.github.com/users/pbidenko","html_url":"https://github.com/pbidenko","followers_url":"https://api.github.com/users/pbidenko/followers","following_url":"https://api.github.com/users/pbidenko/following{/other_user}","gists_url":"https://api.github.com/users/pbidenko/gists{/gist_id}","starred_url":"https://api.github.com/users/pbidenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbidenko/subscriptions","organizations_url":"https://api.github.com/users/pbidenko/orgs","repos_url":"https://api.github.com/users/pbidenko/repos","events_url":"https://api.github.com/users/pbidenko/events{/privacy}","received_events_url":"https://api.github.com/users/pbidenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pbidenko/flood","description":"A visual programming environment for the browser","fork":true,"url":"https://api.github.com/repos/pbidenko/flood","forks_url":"https://api.github.com/repos/pbidenko/flood/forks","keys_url":"https://api.github.com/repos/pbidenko/flood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbidenko/flood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbidenko/flood/teams","hooks_url":"https://api.github.com/repos/pbidenko/flood/hooks","issue_events_url":"https://api.github.com/repos/pbidenko/flood/issues/events{/number}","events_url":"https://api.github.com/repos/pbidenko/flood/events","assignees_url":"https://api.github.com/repos/pbidenko/flood/assignees{/user}","branches_url":"https://api.github.com/repos/pbidenko/flood/branches{/branch}","tags_url":"https://api.github.com/repos/pbidenko/flood/tags","blobs_url":"https://api.github.com/repos/pbidenko/flood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbidenko/flood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbidenko/flood/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbidenko/flood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbidenko/flood/statuses/{sha}","languages_url":"https://api.github.com/repos/pbidenko/flood/languages","stargazers_url":"https://api.github.com/repos/pbidenko/flood/stargazers","contributors_url":"https://api.github.com/repos/pbidenko/flood/contributors","subscribers_url":"https://api.github.com/repos/pbidenko/flood/subscribers","subscription_url":"https://api.github.com/repos/pbidenko/flood/subscription","commits_url":"https://api.github.com/repos/pbidenko/flood/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbidenko/flood/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbidenko/flood/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbidenko/flood/issues/comments/{number}","contents_url":"https://api.github.com/repos/pbidenko/flood/contents/{+path}","compare_url":"https://api.github.com/repos/pbidenko/flood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbidenko/flood/merges","archive_url":"https://api.github.com/repos/pbidenko/flood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbidenko/flood/downloads","issues_url":"https://api.github.com/repos/pbidenko/flood/issues{/number}","pulls_url":"https://api.github.com/repos/pbidenko/flood/pulls{/number}","milestones_url":"https://api.github.com/repos/pbidenko/flood/milestones{/number}","notifications_url":"https://api.github.com/repos/pbidenko/flood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbidenko/flood/labels{/name}","releases_url":"https://api.github.com/repos/pbidenko/flood/releases{/id}","created_at":"2014-07-04T11:29:46Z","updated_at":"2014-07-04T14:53:01Z","pushed_at":"2014-11-06T11:44:58Z","git_url":"git://github.com/pbidenko/flood.git","ssh_url":"git@github.com:pbidenko/flood.git","clone_url":"https://github.com/pbidenko/flood.git","svn_url":"https://github.com/pbidenko/flood","homepage":"","size":46101,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pboyer:Reach","ref":"Reach","sha":"8bd9b20d38035cab21e07737158dc79689b2f71d","user":{"login":"pboyer","id":916345,"avatar_url":"https://avatars.githubusercontent.com/u/916345?v=2","gravatar_id":"","url":"https://api.github.com/users/pboyer","html_url":"https://github.com/pboyer","followers_url":"https://api.github.com/users/pboyer/followers","following_url":"https://api.github.com/users/pboyer/following{/other_user}","gists_url":"https://api.github.com/users/pboyer/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyer/subscriptions","organizations_url":"https://api.github.com/users/pboyer/orgs","repos_url":"https://api.github.com/users/pboyer/repos","events_url":"https://api.github.com/users/pboyer/events{/privacy}","received_events_url":"https://api.github.com/users/pboyer/received_events","type":"User","site_admin":false},"repo":{"id":10161776,"name":"flood","full_name":"pboyer/flood","owner":{"login":"pboyer","id":916345,"avatar_url":"https://avatars.githubusercontent.com/u/916345?v=2","gravatar_id":"","url":"https://api.github.com/users/pboyer","html_url":"https://github.com/pboyer","followers_url":"https://api.github.com/users/pboyer/followers","following_url":"https://api.github.com/users/pboyer/following{/other_user}","gists_url":"https://api.github.com/users/pboyer/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyer/subscriptions","organizations_url":"https://api.github.com/users/pboyer/orgs","repos_url":"https://api.github.com/users/pboyer/repos","events_url":"https://api.github.com/users/pboyer/events{/privacy}","received_events_url":"https://api.github.com/users/pboyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pboyer/flood","description":"A visual programming environment for the browser","fork":false,"url":"https://api.github.com/repos/pboyer/flood","forks_url":"https://api.github.com/repos/pboyer/flood/forks","keys_url":"https://api.github.com/repos/pboyer/flood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pboyer/flood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pboyer/flood/teams","hooks_url":"https://api.github.com/repos/pboyer/flood/hooks","issue_events_url":"https://api.github.com/repos/pboyer/flood/issues/events{/number}","events_url":"https://api.github.com/repos/pboyer/flood/events","assignees_url":"https://api.github.com/repos/pboyer/flood/assignees{/user}","branches_url":"https://api.github.com/repos/pboyer/flood/branches{/branch}","tags_url":"https://api.github.com/repos/pboyer/flood/tags","blobs_url":"https://api.github.com/repos/pboyer/flood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pboyer/flood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pboyer/flood/git/refs{/sha}","trees_url":"https://api.github.com/repos/pboyer/flood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pboyer/flood/statuses/{sha}","languages_url":"https://api.github.com/repos/pboyer/flood/languages","stargazers_url":"https://api.github.com/repos/pboyer/flood/stargazers","contributors_url":"https://api.github.com/repos/pboyer/flood/contributors","subscribers_url":"https://api.github.com/repos/pboyer/flood/subscribers","subscription_url":"https://api.github.com/repos/pboyer/flood/subscription","commits_url":"https://api.github.com/repos/pboyer/flood/commits{/sha}","git_commits_url":"https://api.github.com/repos/pboyer/flood/git/commits{/sha}","comments_url":"https://api.github.com/repos/pboyer/flood/comments{/number}","issue_comment_url":"https://api.github.com/repos/pboyer/flood/issues/comments/{number}","contents_url":"https://api.github.com/repos/pboyer/flood/contents/{+path}","compare_url":"https://api.github.com/repos/pboyer/flood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pboyer/flood/merges","archive_url":"https://api.github.com/repos/pboyer/flood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pboyer/flood/downloads","issues_url":"https://api.github.com/repos/pboyer/flood/issues{/number}","pulls_url":"https://api.github.com/repos/pboyer/flood/pulls{/number}","milestones_url":"https://api.github.com/repos/pboyer/flood/milestones{/number}","notifications_url":"https://api.github.com/repos/pboyer/flood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pboyer/flood/labels{/name}","releases_url":"https://api.github.com/repos/pboyer/flood/releases{/id}","created_at":"2013-05-19T21:45:23Z","updated_at":"2014-11-03T17:16:22Z","pushed_at":"2014-11-06T16:51:57Z","git_url":"git://github.com/pboyer/flood.git","ssh_url":"git@github.com:pboyer/flood.git","clone_url":"https://github.com/pboyer/flood.git","svn_url":"https://github.com/pboyer/flood","homepage":"http://www.floodeditor.com","size":47929,"stargazers_count":109,"watchers_count":109,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pboyer/flood/pulls/51"},"html":{"href":"https://github.com/pboyer/flood/pull/51"},"issue":{"href":"https://api.github.com/repos/pboyer/flood/issues/51"},"comments":{"href":"https://api.github.com/repos/pboyer/flood/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/pboyer/flood/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/pboyer/flood/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pboyer/flood/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/pboyer/flood/statuses/4bfdeba2cdd196736a6f087979d462e42fd49972"}}}}