GitHub PullRequestReviewCommentEvent at 2014-09-02 19:03:49
Repository: osTicket-1.8
Actor: greezybacon
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/comments/17007929","id":17007929,"diff_hunk":"@@ -767,7 +767,10 @@ function setTicketStatus($tid, $state) {\n         if (!($status= TicketStatus::lookup($_REQUEST['status_id'])))\n             $errors['status_id'] = sprintf('%s %s',\n                     __('Unknown or invalid'), __('status'));\n-        elseif (!$errors) {\n+        elseif ($status->getId() == $ticket->getStatusId())\n+            $errors['err'] = sprintf(__('Ticket already set to  %s\n+                        status'), __($status->getName()));","path":"include/ajax.tickets.php","position":7,"original_position":7,"commit_id":"7a1aa69d67c6d722403225b087db1cebc3cfb8ce","original_commit_id":"7a1aa69d67c6d722403225b087db1cebc3cfb8ce","user":{"login":"greezybacon","id":672074,"avatar_url":"https://avatars.githubusercontent.com/u/672074?v=2","gravatar_id":"9c3620f41b41a013dfc20fbc90eb19ed","url":"https://api.github.com/users/greezybacon","html_url":"https://github.com/greezybacon","followers_url":"https://api.github.com/users/greezybacon/followers","following_url":"https://api.github.com/users/greezybacon/following{/other_user}","gists_url":"https://api.github.com/users/greezybacon/gists{/gist_id}","starred_url":"https://api.github.com/users/greezybacon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greezybacon/subscriptions","organizations_url":"https://api.github.com/users/greezybacon/orgs","repos_url":"https://api.github.com/users/greezybacon/repos","events_url":"https://api.github.com/users/greezybacon/events{/privacy}","received_events_url":"https://api.github.com/users/greezybacon/received_events","type":"User","site_admin":false},"body":"Don't break in the quotes","created_at":"2014-09-02T19:03:49Z","updated_at":"2014-09-02T19:03:49Z","html_url":"https://github.com/osTicket/osTicket-1.8/pull/1213#discussion_r17007929","pull_request_url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/1213","_links":{"self":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/comments/17007929"},"html":{"href":"https://github.com/osTicket/osTicket-1.8/pull/1213#discussion_r17007929"},"pull_request":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/1213"}}},"pull_request":{"url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/1213","id":20619467,"html_url":"https://github.com/osTicket/osTicket-1.8/pull/1213","diff_url":"https://github.com/osTicket/osTicket-1.8/pull/1213.diff","patch_url":"https://github.com/osTicket/osTicket-1.8/pull/1213.patch","issue_url":"https://api.github.com/repos/osTicket/osTicket-1.8/issues/1213","number":1213,"state":"open","locked":false,"title":"Handle cases where status change fails","user":{"login":"protich","id":31067,"avatar_url":"https://avatars.githubusercontent.com/u/31067?v=2","gravatar_id":"558f621e86ca927d44f75ef56c6bd2dd","url":"https://api.github.com/users/protich","html_url":"https://github.com/protich","followers_url":"https://api.github.com/users/protich/followers","following_url":"https://api.github.com/users/protich/following{/other_user}","gists_url":"https://api.github.com/users/protich/gists{/gist_id}","starred_url":"https://api.github.com/users/protich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/protich/subscriptions","organizations_url":"https://api.github.com/users/protich/orgs","repos_url":"https://api.github.com/users/protich/repos","events_url":"https://api.github.com/users/protich/events{/privacy}","received_events_url":"https://api.github.com/users/protich/received_events","type":"User","site_admin":false},"body":"Set the correct error message and maintain user selection & input","created_at":"2014-09-02T15:19:19Z","updated_at":"2014-09-02T19:03:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"136fc0dab23258fafbd0064af1a48e5dde69d9a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/1213/commits","review_comments_url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/1213/comments","review_comment_url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/comments/{number}","comments_url":"https://api.github.com/repos/osTicket/osTicket-1.8/issues/1213/comments","statuses_url":"https://api.github.com/repos/osTicket/osTicket-1.8/statuses/7a1aa69d67c6d722403225b087db1cebc3cfb8ce","head":{"label":"protich:issue/change-ticket-status","ref":"issue/change-ticket-status","sha":"7a1aa69d67c6d722403225b087db1cebc3cfb8ce","user":{"login":"protich","id":31067,"avatar_url":"https://avatars.githubusercontent.com/u/31067?v=2","gravatar_id":"558f621e86ca927d44f75ef56c6bd2dd","url":"https://api.github.com/users/protich","html_url":"https://github.com/protich","followers_url":"https://api.github.com/users/protich/followers","following_url":"https://api.github.com/users/protich/following{/other_user}","gists_url":"https://api.github.com/users/protich/gists{/gist_id}","starred_url":"https://api.github.com/users/protich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/protich/subscriptions","organizations_url":"https://api.github.com/users/protich/orgs","repos_url":"https://api.github.com/users/protich/repos","events_url":"https://api.github.com/users/protich/events{/privacy}","received_events_url":"https://api.github.com/users/protich/received_events","type":"User","site_admin":false},"repo":{"id":13451396,"name":"osTicket-1.8","full_name":"protich/osTicket-1.8","owner":{"login":"protich","id":31067,"avatar_url":"https://avatars.githubusercontent.com/u/31067?v=2","gravatar_id":"558f621e86ca927d44f75ef56c6bd2dd","url":"https://api.github.com/users/protich","html_url":"https://github.com/protich","followers_url":"https://api.github.com/users/protich/followers","following_url":"https://api.github.com/users/protich/following{/other_user}","gists_url":"https://api.github.com/users/protich/gists{/gist_id}","starred_url":"https://api.github.com/users/protich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/protich/subscriptions","organizations_url":"https://api.github.com/users/protich/orgs","repos_url":"https://api.github.com/users/protich/repos","events_url":"https://api.github.com/users/protich/events{/privacy}","received_events_url":"https://api.github.com/users/protich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/protich/osTicket-1.8","description":"Codename: Rumors","fork":true,"url":"https://api.github.com/repos/protich/osTicket-1.8","forks_url":"https://api.github.com/repos/protich/osTicket-1.8/forks","keys_url":"https://api.github.com/repos/protich/osTicket-1.8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/protich/osTicket-1.8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/protich/osTicket-1.8/teams","hooks_url":"https://api.github.com/repos/protich/osTicket-1.8/hooks","issue_events_url":"https://api.github.com/repos/protich/osTicket-1.8/issues/events{/number}","events_url":"https://api.github.com/repos/protich/osTicket-1.8/events","assignees_url":"https://api.github.com/repos/protich/osTicket-1.8/assignees{/user}","branches_url":"https://api.github.com/repos/protich/osTicket-1.8/branches{/branch}","tags_url":"https://api.github.com/repos/protich/osTicket-1.8/tags","blobs_url":"https://api.github.com/repos/protich/osTicket-1.8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/protich/osTicket-1.8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/protich/osTicket-1.8/git/refs{/sha}","trees_url":"https://api.github.com/repos/protich/osTicket-1.8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/protich/osTicket-1.8/statuses/{sha}","languages_url":"https://api.github.com/repos/protich/osTicket-1.8/languages","stargazers_url":"https://api.github.com/repos/protich/osTicket-1.8/stargazers","contributors_url":"https://api.github.com/repos/protich/osTicket-1.8/contributors","subscribers_url":"https://api.github.com/repos/protich/osTicket-1.8/subscribers","subscription_url":"https://api.github.com/repos/protich/osTicket-1.8/subscription","commits_url":"https://api.github.com/repos/protich/osTicket-1.8/commits{/sha}","git_commits_url":"https://api.github.com/repos/protich/osTicket-1.8/git/commits{/sha}","comments_url":"https://api.github.com/repos/protich/osTicket-1.8/comments{/number}","issue_comment_url":"https://api.github.com/repos/protich/osTicket-1.8/issues/comments/{number}","contents_url":"https://api.github.com/repos/protich/osTicket-1.8/contents/{+path}","compare_url":"https://api.github.com/repos/protich/osTicket-1.8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/protich/osTicket-1.8/merges","archive_url":"https://api.github.com/repos/protich/osTicket-1.8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/protich/osTicket-1.8/downloads","issues_url":"https://api.github.com/repos/protich/osTicket-1.8/issues{/number}","pulls_url":"https://api.github.com/repos/protich/osTicket-1.8/pulls{/number}","milestones_url":"https://api.github.com/repos/protich/osTicket-1.8/milestones{/number}","notifications_url":"https://api.github.com/repos/protich/osTicket-1.8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/protich/osTicket-1.8/labels{/name}","releases_url":"https://api.github.com/repos/protich/osTicket-1.8/releases{/id}","created_at":"2013-10-09T19:10:04Z","updated_at":"2014-08-27T19:20:31Z","pushed_at":"2014-09-02T15:17:51Z","git_url":"git://github.com/protich/osTicket-1.8.git","ssh_url":"git@github.com:protich/osTicket-1.8.git","clone_url":"https://github.com/protich/osTicket-1.8.git","svn_url":"https://github.com/protich/osTicket-1.8","homepage":null,"size":17685,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"osTicket:develop-next","ref":"develop-next","sha":"0fa667078a4e91bb646fdb1af93c6a3df7939328","user":{"login":"osTicket","id":371413,"avatar_url":"https://avatars.githubusercontent.com/u/371413?v=2","gravatar_id":"b09d4d61892d9ab0f63d29650a4ad9a6","url":"https://api.github.com/users/osTicket","html_url":"https://github.com/osTicket","followers_url":"https://api.github.com/users/osTicket/followers","following_url":"https://api.github.com/users/osTicket/following{/other_user}","gists_url":"https://api.github.com/users/osTicket/gists{/gist_id}","starred_url":"https://api.github.com/users/osTicket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osTicket/subscriptions","organizations_url":"https://api.github.com/users/osTicket/orgs","repos_url":"https://api.github.com/users/osTicket/repos","events_url":"https://api.github.com/users/osTicket/events{/privacy}","received_events_url":"https://api.github.com/users/osTicket/received_events","type":"Organization","site_admin":false},"repo":{"id":12063996,"name":"osTicket-1.8","full_name":"osTicket/osTicket-1.8","owner":{"login":"osTicket","id":371413,"avatar_url":"https://avatars.githubusercontent.com/u/371413?v=2","gravatar_id":"b09d4d61892d9ab0f63d29650a4ad9a6","url":"https://api.github.com/users/osTicket","html_url":"https://github.com/osTicket","followers_url":"https://api.github.com/users/osTicket/followers","following_url":"https://api.github.com/users/osTicket/following{/other_user}","gists_url":"https://api.github.com/users/osTicket/gists{/gist_id}","starred_url":"https://api.github.com/users/osTicket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osTicket/subscriptions","organizations_url":"https://api.github.com/users/osTicket/orgs","repos_url":"https://api.github.com/users/osTicket/repos","events_url":"https://api.github.com/users/osTicket/events{/privacy}","received_events_url":"https://api.github.com/users/osTicket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osTicket/osTicket-1.8","description":"Codename: Rumors","fork":false,"url":"https://api.github.com/repos/osTicket/osTicket-1.8","forks_url":"https://api.github.com/repos/osTicket/osTicket-1.8/forks","keys_url":"https://api.github.com/repos/osTicket/osTicket-1.8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osTicket/osTicket-1.8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osTicket/osTicket-1.8/teams","hooks_url":"https://api.github.com/repos/osTicket/osTicket-1.8/hooks","issue_events_url":"https://api.github.com/repos/osTicket/osTicket-1.8/issues/events{/number}","events_url":"https://api.github.com/repos/osTicket/osTicket-1.8/events","assignees_url":"https://api.github.com/repos/osTicket/osTicket-1.8/assignees{/user}","branches_url":"https://api.github.com/repos/osTicket/osTicket-1.8/branches{/branch}","tags_url":"https://api.github.com/repos/osTicket/osTicket-1.8/tags","blobs_url":"https://api.github.com/repos/osTicket/osTicket-1.8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osTicket/osTicket-1.8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osTicket/osTicket-1.8/git/refs{/sha}","trees_url":"https://api.github.com/repos/osTicket/osTicket-1.8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osTicket/osTicket-1.8/statuses/{sha}","languages_url":"https://api.github.com/repos/osTicket/osTicket-1.8/languages","stargazers_url":"https://api.github.com/repos/osTicket/osTicket-1.8/stargazers","contributors_url":"https://api.github.com/repos/osTicket/osTicket-1.8/contributors","subscribers_url":"https://api.github.com/repos/osTicket/osTicket-1.8/subscribers","subscription_url":"https://api.github.com/repos/osTicket/osTicket-1.8/subscription","commits_url":"https://api.github.com/repos/osTicket/osTicket-1.8/commits{/sha}","git_commits_url":"https://api.github.com/repos/osTicket/osTicket-1.8/git/commits{/sha}","comments_url":"https://api.github.com/repos/osTicket/osTicket-1.8/comments{/number}","issue_comment_url":"https://api.github.com/repos/osTicket/osTicket-1.8/issues/comments/{number}","contents_url":"https://api.github.com/repos/osTicket/osTicket-1.8/contents/{+path}","compare_url":"https://api.github.com/repos/osTicket/osTicket-1.8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osTicket/osTicket-1.8/merges","archive_url":"https://api.github.com/repos/osTicket/osTicket-1.8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osTicket/osTicket-1.8/downloads","issues_url":"https://api.github.com/repos/osTicket/osTicket-1.8/issues{/number}","pulls_url":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls{/number}","milestones_url":"https://api.github.com/repos/osTicket/osTicket-1.8/milestones{/number}","notifications_url":"https://api.github.com/repos/osTicket/osTicket-1.8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osTicket/osTicket-1.8/labels{/name}","releases_url":"https://api.github.com/repos/osTicket/osTicket-1.8/releases{/id}","created_at":"2013-08-12T19:10:14Z","updated_at":"2014-08-25T23:09:52Z","pushed_at":"2014-09-01T22:43:16Z","git_url":"git://github.com/osTicket/osTicket-1.8.git","ssh_url":"git@github.com:osTicket/osTicket-1.8.git","clone_url":"https://github.com/osTicket/osTicket-1.8.git","svn_url":"https://github.com/osTicket/osTicket-1.8","homepage":null,"size":27647,"stargazers_count":173,"watchers_count":173,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":200,"mirror_url":null,"open_issues_count":437,"forks":200,"open_issues":437,"watchers":173,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/1213"},"html":{"href":"https://github.com/osTicket/osTicket-1.8/pull/1213"},"issue":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/issues/1213"},"comments":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/issues/1213/comments"},"review_comments":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/1213/comments"},"review_comment":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/pulls/1213/commits"},"statuses":{"href":"https://api.github.com/repos/osTicket/osTicket-1.8/statuses/7a1aa69d67c6d722403225b087db1cebc3cfb8ce"}}}}