GitHub PullRequestReviewCommentEvent at 2014-10-19 16:01:50
Repository: symfony-docs
Actor: xabbuh
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/19061080","id":19061080,"diff_hunk":"@@ -19,162 +19,645 @@ There may also be tags in bundles you use that aren't listed here.\n Functions\n ---------\n \n+.. _reference_twig.function.render:\n+\n+render\n+~~~~~~\n+\n+.. versionadded:: 2.2\n+    The ``render()`` function was introduced in Symfony 2.2. Prior, the\n+    ``{% render %}`` tag was used and had a different signature.\n+\n+.. code-block:: jinja\n+\n+    {{ render(uri, options) }}\n+\n+uri","path":"reference/twig_reference.rst","position":17,"original_position":17,"commit_id":"b7d8bc049b439531299009a8161515a3bbf1eba9","original_commit_id":"b7d8bc049b439531299009a8161515a3bbf1eba9","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=2","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"Wouldn't it be better to put ``uri`` into literals?","created_at":"2014-10-19T16:01:50Z","updated_at":"2014-10-19T16:01:50Z","html_url":"https://github.com/symfony/symfony-docs/pull/4313#discussion_r19061080","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4313","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/19061080"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4313#discussion_r19061080"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4313"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4313","id":22593450,"html_url":"https://github.com/symfony/symfony-docs/pull/4313","diff_url":"https://github.com/symfony/symfony-docs/pull/4313.diff","patch_url":"https://github.com/symfony/symfony-docs/pull/4313.patch","issue_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4313","number":4313,"state":"open","locked":false,"title":"Improved and fixed twig reference","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=2","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"| Q   | A\r\n| --- | ---\r\n| Doc fix? | yes\r\n| New docs? | yes\r\n| Applies to | 2.3+\r\n| Ficket tickets | #4301 \r\n\r\nRemoved the ugly looking tables and added some more details.","created_at":"2014-10-10T22:48:45Z","updated_at":"2014-10-19T16:01:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18abd844949227c60cfc780aa82340ce19d7aae5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4313/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4313/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4313/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/b7d8bc049b439531299009a8161515a3bbf1eba9","head":{"label":"WouterJ:improve_twig_reference","ref":"improve_twig_reference","sha":"b7d8bc049b439531299009a8161515a3bbf1eba9","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=2","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"repo":{"id":4110264,"name":"symfony-docs","full_name":"WouterJ/symfony-docs","owner":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=2","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WouterJ/symfony-docs","description":"The Symfony2 documentation","fork":true,"url":"https://api.github.com/repos/WouterJ/symfony-docs","forks_url":"https://api.github.com/repos/WouterJ/symfony-docs/forks","keys_url":"https://api.github.com/repos/WouterJ/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WouterJ/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WouterJ/symfony-docs/teams","hooks_url":"https://api.github.com/repos/WouterJ/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/WouterJ/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/WouterJ/symfony-docs/events","assignees_url":"https://api.github.com/repos/WouterJ/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/WouterJ/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/WouterJ/symfony-docs/tags","blobs_url":"https://api.github.com/repos/WouterJ/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WouterJ/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WouterJ/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/WouterJ/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WouterJ/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/WouterJ/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/WouterJ/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/WouterJ/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/WouterJ/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/WouterJ/symfony-docs/subscription","commits_url":"https://api.github.com/repos/WouterJ/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/WouterJ/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/WouterJ/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/WouterJ/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/WouterJ/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/WouterJ/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WouterJ/symfony-docs/merges","archive_url":"https://api.github.com/repos/WouterJ/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WouterJ/symfony-docs/downloads","issues_url":"https://api.github.com/repos/WouterJ/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/WouterJ/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/WouterJ/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/WouterJ/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WouterJ/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/WouterJ/symfony-docs/releases{/id}","created_at":"2012-04-23T06:36:17Z","updated_at":"2014-06-14T16:16:46Z","pushed_at":"2014-10-19T15:45:28Z","git_url":"git://github.com/WouterJ/symfony-docs.git","ssh_url":"git@github.com:WouterJ/symfony-docs.git","clone_url":"https://github.com/WouterJ/symfony-docs.git","svn_url":"https://github.com/WouterJ/symfony-docs","homepage":"http://symfony.com/doc/2.0/","size":22194,"stargazers_count":0,"watchers_count":0,"language":"Lasso","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"16034633f498c23af8abce8edce266f8af36a010","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":521583,"name":"symfony-docs","full_name":"symfony/symfony-docs","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-docs","description":"The Symfony2 documentation","fork":false,"url":"https://api.github.com/repos/symfony/symfony-docs","forks_url":"https://api.github.com/repos/symfony/symfony-docs/forks","keys_url":"https://api.github.com/repos/symfony/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-docs/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-docs/events","assignees_url":"https://api.github.com/repos/symfony/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-docs/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-docs/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-docs/merges","archive_url":"https://api.github.com/repos/symfony/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-docs/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-docs/releases{/id}","created_at":"2010-02-17T08:43:51Z","updated_at":"2014-10-19T11:06:42Z","pushed_at":"2014-10-19T15:44:18Z","git_url":"git://github.com/symfony/symfony-docs.git","ssh_url":"git@github.com:symfony/symfony-docs.git","clone_url":"https://github.com/symfony/symfony-docs.git","svn_url":"https://github.com/symfony/symfony-docs","homepage":"http://symfony.com/doc/current/","size":54594,"stargazers_count":927,"watchers_count":927,"language":"Assembly","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1483,"mirror_url":null,"open_issues_count":212,"forks":1483,"open_issues":212,"watchers":927,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4313"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4313"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4313"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4313/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4313/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4313/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-docs/statuses/b7d8bc049b439531299009a8161515a3bbf1eba9"}}}}