GitHub PullRequestReviewCommentEvent at 2014-07-21 20:10:21
Repository: kafka
Actor: wvanbergen
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/wvanbergen/kafka/pulls/comments/15192642","id":15192642,"diff_hunk":"@@ -30,7 +31,7 @@ func NewZK(servers []string, recvTimeout time.Duration) (*ZK, error) {\n  *******************************************************************/\n \n func (z *ZK) Brokers() ([]string, error) {\n-\troot := \"/brokers/ids\"\n+\troot := fmt.Sprintf(\"%s/brokers/ids\", z.chroot)","path":"consumergroup/zk.go","position":24,"original_position":24,"commit_id":"fedf3a2d202c0a29aeaaf4e6c5c73c2c3a7410b6","original_commit_id":"fedf3a2d202c0a29aeaaf4e6c5c73c2c3a7410b6","user":{"login":"wvanbergen","id":15870,"avatar_url":"https://avatars.githubusercontent.com/u/15870?","gravatar_id":"ed5d98f3a41d99feee05c758ae751739","url":"https://api.github.com/users/wvanbergen","html_url":"https://github.com/wvanbergen","followers_url":"https://api.github.com/users/wvanbergen/followers","following_url":"https://api.github.com/users/wvanbergen/following{/other_user}","gists_url":"https://api.github.com/users/wvanbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/wvanbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvanbergen/subscriptions","organizations_url":"https://api.github.com/users/wvanbergen/orgs","repos_url":"https://api.github.com/users/wvanbergen/repos","events_url":"https://api.github.com/users/wvanbergen/events{/privacy}","received_events_url":"https://api.github.com/users/wvanbergen/received_events","type":"User","site_admin":false},"body":"Yeah, so you have to set chroot to `/blah` if you want to use it.","created_at":"2014-07-21T20:10:21Z","updated_at":"2014-07-21T20:10:21Z","html_url":"https://github.com/wvanbergen/kafka/pull/16#discussion_r15192642","pull_request_url":"https://api.github.com/repos/wvanbergen/kafka/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/wvanbergen/kafka/pulls/comments/15192642"},"html":{"href":"https://github.com/wvanbergen/kafka/pull/16#discussion_r15192642"},"pull_request":{"href":"https://api.github.com/repos/wvanbergen/kafka/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/wvanbergen/kafka/pulls/16","id":18675815,"html_url":"https://github.com/wvanbergen/kafka/pull/16","diff_url":"https://github.com/wvanbergen/kafka/pull/16.diff","patch_url":"https://github.com/wvanbergen/kafka/pull/16.patch","issue_url":"https://api.github.com/repos/wvanbergen/kafka/issues/16","number":16,"state":"open","title":"Add Zookeeper chroot support","user":{"login":"wvanbergen","id":15870,"avatar_url":"https://avatars.githubusercontent.com/u/15870?","gravatar_id":"ed5d98f3a41d99feee05c758ae751739","url":"https://api.github.com/users/wvanbergen","html_url":"https://github.com/wvanbergen","followers_url":"https://api.github.com/users/wvanbergen/followers","following_url":"https://api.github.com/users/wvanbergen/following{/other_user}","gists_url":"https://api.github.com/users/wvanbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/wvanbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvanbergen/subscriptions","organizations_url":"https://api.github.com/users/wvanbergen/orgs","repos_url":"https://api.github.com/users/wvanbergen/repos","events_url":"https://api.github.com/users/wvanbergen/events{/privacy}","received_events_url":"https://api.github.com/users/wvanbergen/received_events","type":"User","site_admin":false},"body":"Allows you to set a chroot for Zookeeper. Fixes #15. \r\n\r\n@manygrams @eapache @mmcgrana","created_at":"2014-07-21T19:54:59Z","updated_at":"2014-07-21T20:10:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3baeefb0f1aa33c739863ad4081c9d7ee45a6ea2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wvanbergen/kafka/pulls/16/commits","review_comments_url":"https://api.github.com/repos/wvanbergen/kafka/pulls/16/comments","review_comment_url":"https://api.github.com/repos/wvanbergen/kafka/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wvanbergen/kafka/issues/16/comments","statuses_url":"https://api.github.com/repos/wvanbergen/kafka/statuses/fedf3a2d202c0a29aeaaf4e6c5c73c2c3a7410b6","head":{"label":"wvanbergen:chroot","ref":"chroot","sha":"fedf3a2d202c0a29aeaaf4e6c5c73c2c3a7410b6","user":{"login":"wvanbergen","id":15870,"avatar_url":"https://avatars.githubusercontent.com/u/15870?","gravatar_id":"ed5d98f3a41d99feee05c758ae751739","url":"https://api.github.com/users/wvanbergen","html_url":"https://github.com/wvanbergen","followers_url":"https://api.github.com/users/wvanbergen/followers","following_url":"https://api.github.com/users/wvanbergen/following{/other_user}","gists_url":"https://api.github.com/users/wvanbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/wvanbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvanbergen/subscriptions","organizations_url":"https://api.github.com/users/wvanbergen/orgs","repos_url":"https://api.github.com/users/wvanbergen/repos","events_url":"https://api.github.com/users/wvanbergen/events{/privacy}","received_events_url":"https://api.github.com/users/wvanbergen/received_events","type":"User","site_admin":false},"repo":{"id":19999011,"name":"kafka","full_name":"wvanbergen/kafka","owner":{"login":"wvanbergen","id":15870,"avatar_url":"https://avatars.githubusercontent.com/u/15870?","gravatar_id":"ed5d98f3a41d99feee05c758ae751739","url":"https://api.github.com/users/wvanbergen","html_url":"https://github.com/wvanbergen","followers_url":"https://api.github.com/users/wvanbergen/followers","following_url":"https://api.github.com/users/wvanbergen/following{/other_user}","gists_url":"https://api.github.com/users/wvanbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/wvanbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvanbergen/subscriptions","organizations_url":"https://api.github.com/users/wvanbergen/orgs","repos_url":"https://api.github.com/users/wvanbergen/repos","events_url":"https://api.github.com/users/wvanbergen/events{/privacy}","received_events_url":"https://api.github.com/users/wvanbergen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wvanbergen/kafka","description":"Load-balancing, resuming Kafka consumer, backed by Zookeeper.","fork":false,"url":"https://api.github.com/repos/wvanbergen/kafka","forks_url":"https://api.github.com/repos/wvanbergen/kafka/forks","keys_url":"https://api.github.com/repos/wvanbergen/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wvanbergen/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wvanbergen/kafka/teams","hooks_url":"https://api.github.com/repos/wvanbergen/kafka/hooks","issue_events_url":"https://api.github.com/repos/wvanbergen/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/wvanbergen/kafka/events","assignees_url":"https://api.github.com/repos/wvanbergen/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/wvanbergen/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/wvanbergen/kafka/tags","blobs_url":"https://api.github.com/repos/wvanbergen/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wvanbergen/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wvanbergen/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/wvanbergen/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wvanbergen/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/wvanbergen/kafka/languages","stargazers_url":"https://api.github.com/repos/wvanbergen/kafka/stargazers","contributors_url":"https://api.github.com/repos/wvanbergen/kafka/contributors","subscribers_url":"https://api.github.com/repos/wvanbergen/kafka/subscribers","subscription_url":"https://api.github.com/repos/wvanbergen/kafka/subscription","commits_url":"https://api.github.com/repos/wvanbergen/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/wvanbergen/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/wvanbergen/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/wvanbergen/kafka/issues/comments/{number}","contents_url":"https://api.github.com/repos/wvanbergen/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/wvanbergen/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wvanbergen/kafka/merges","archive_url":"https://api.github.com/repos/wvanbergen/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wvanbergen/kafka/downloads","issues_url":"https://api.github.com/repos/wvanbergen/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/wvanbergen/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/wvanbergen/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/wvanbergen/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wvanbergen/kafka/labels{/name}","releases_url":"https://api.github.com/repos/wvanbergen/kafka/releases{/id}","created_at":"2014-05-20T21:55:17Z","updated_at":"2014-07-07T20:20:50Z","pushed_at":"2014-07-21T19:53:39Z","git_url":"git://github.com/wvanbergen/kafka.git","ssh_url":"git@github.com:wvanbergen/kafka.git","clone_url":"https://github.com/wvanbergen/kafka.git","svn_url":"https://github.com/wvanbergen/kafka","homepage":null,"size":536,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"wvanbergen:master","ref":"master","sha":"c0ad9a8db3f24fec2025c93d8c76d757de1f7d98","user":{"login":"wvanbergen","id":15870,"avatar_url":"https://avatars.githubusercontent.com/u/15870?","gravatar_id":"ed5d98f3a41d99feee05c758ae751739","url":"https://api.github.com/users/wvanbergen","html_url":"https://github.com/wvanbergen","followers_url":"https://api.github.com/users/wvanbergen/followers","following_url":"https://api.github.com/users/wvanbergen/following{/other_user}","gists_url":"https://api.github.com/users/wvanbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/wvanbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvanbergen/subscriptions","organizations_url":"https://api.github.com/users/wvanbergen/orgs","repos_url":"https://api.github.com/users/wvanbergen/repos","events_url":"https://api.github.com/users/wvanbergen/events{/privacy}","received_events_url":"https://api.github.com/users/wvanbergen/received_events","type":"User","site_admin":false},"repo":{"id":19999011,"name":"kafka","full_name":"wvanbergen/kafka","owner":{"login":"wvanbergen","id":15870,"avatar_url":"https://avatars.githubusercontent.com/u/15870?","gravatar_id":"ed5d98f3a41d99feee05c758ae751739","url":"https://api.github.com/users/wvanbergen","html_url":"https://github.com/wvanbergen","followers_url":"https://api.github.com/users/wvanbergen/followers","following_url":"https://api.github.com/users/wvanbergen/following{/other_user}","gists_url":"https://api.github.com/users/wvanbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/wvanbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvanbergen/subscriptions","organizations_url":"https://api.github.com/users/wvanbergen/orgs","repos_url":"https://api.github.com/users/wvanbergen/repos","events_url":"https://api.github.com/users/wvanbergen/events{/privacy}","received_events_url":"https://api.github.com/users/wvanbergen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wvanbergen/kafka","description":"Load-balancing, resuming Kafka consumer, backed by Zookeeper.","fork":false,"url":"https://api.github.com/repos/wvanbergen/kafka","forks_url":"https://api.github.com/repos/wvanbergen/kafka/forks","keys_url":"https://api.github.com/repos/wvanbergen/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wvanbergen/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wvanbergen/kafka/teams","hooks_url":"https://api.github.com/repos/wvanbergen/kafka/hooks","issue_events_url":"https://api.github.com/repos/wvanbergen/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/wvanbergen/kafka/events","assignees_url":"https://api.github.com/repos/wvanbergen/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/wvanbergen/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/wvanbergen/kafka/tags","blobs_url":"https://api.github.com/repos/wvanbergen/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wvanbergen/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wvanbergen/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/wvanbergen/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wvanbergen/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/wvanbergen/kafka/languages","stargazers_url":"https://api.github.com/repos/wvanbergen/kafka/stargazers","contributors_url":"https://api.github.com/repos/wvanbergen/kafka/contributors","subscribers_url":"https://api.github.com/repos/wvanbergen/kafka/subscribers","subscription_url":"https://api.github.com/repos/wvanbergen/kafka/subscription","commits_url":"https://api.github.com/repos/wvanbergen/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/wvanbergen/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/wvanbergen/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/wvanbergen/kafka/issues/comments/{number}","contents_url":"https://api.github.com/repos/wvanbergen/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/wvanbergen/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wvanbergen/kafka/merges","archive_url":"https://api.github.com/repos/wvanbergen/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wvanbergen/kafka/downloads","issues_url":"https://api.github.com/repos/wvanbergen/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/wvanbergen/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/wvanbergen/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/wvanbergen/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wvanbergen/kafka/labels{/name}","releases_url":"https://api.github.com/repos/wvanbergen/kafka/releases{/id}","created_at":"2014-05-20T21:55:17Z","updated_at":"2014-07-07T20:20:50Z","pushed_at":"2014-07-21T19:53:39Z","git_url":"git://github.com/wvanbergen/kafka.git","ssh_url":"git@github.com:wvanbergen/kafka.git","clone_url":"https://github.com/wvanbergen/kafka.git","svn_url":"https://github.com/wvanbergen/kafka","homepage":null,"size":536,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wvanbergen/kafka/pulls/16"},"html":{"href":"https://github.com/wvanbergen/kafka/pull/16"},"issue":{"href":"https://api.github.com/repos/wvanbergen/kafka/issues/16"},"comments":{"href":"https://api.github.com/repos/wvanbergen/kafka/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/wvanbergen/kafka/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/wvanbergen/kafka/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wvanbergen/kafka/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/wvanbergen/kafka/statuses/fedf3a2d202c0a29aeaaf4e6c5c73c2c3a7410b6"}}}}