GitHub PullRequestReviewCommentEvent at 2014-02-12 06:21:48
Repository: buteo-syncml
Actor: kavuri
Payload: {"comment":{"url":"https://api.github.com/repos/nemomobile/buteo-syncml/pulls/comments/9657320","id":9657320,"diff_hunk":"@@ -400,7 +402,19 @@ bool SyncAgentConfig::parseConfFile( const QByteArray& aData )\n                 reader.readNext();\n                 QString dbPath = reader.text().toString();\n                 LOG_DEBUG( \"Found critical property\" << DBPATH <<\":\" << dbPath );\n-                setDatabaseFilePath( dbPath );\n+\n+                QFileInfo dbPathInfo(dbPath);\n+                if (dbPathInfo.isAbsolute()) {\n+                    setDatabaseFilePath( dbPath );\n+                } else {\n+                    if (QDir().mkpath(Sync::syncCacheDir())) {\n+                        QString fullDbPath = Sync::syncCacheDir() + QDir::separator() + dbPathInfo.fileName();\n+                        LOG_WARNING(\"Using database at path:\" << fullDbPath);","path":"src/SyncAgentConfig.cpp","position":24,"original_position":24,"commit_id":"68146f224317af54a777df7adf483ce8f8145cb1","original_commit_id":"68146f224317af54a777df7adf483ce8f8145cb1","user":{"login":"kavuri","id":2538487,"avatar_url":"https://gravatar.com/avatar/20a2b6d42f590613d110b2d44f0b8339?d=https%3A%2F%2Fidenticons.github.com%2F8695d42711553412e241a63c1b234fbf.png&r=x","gravatar_id":"20a2b6d42f590613d110b2d44f0b8339","url":"https://api.github.com/users/kavuri","html_url":"https://github.com/kavuri","followers_url":"https://api.github.com/users/kavuri/followers","following_url":"https://api.github.com/users/kavuri/following{/other_user}","gists_url":"https://api.github.com/users/kavuri/gists{/gist_id}","starred_url":"https://api.github.com/users/kavuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kavuri/subscriptions","organizations_url":"https://api.github.com/users/kavuri/orgs","repos_url":"https://api.github.com/users/kavuri/repos","events_url":"https://api.github.com/users/kavuri/events{/privacy}","received_events_url":"https://api.github.com/users/kavuri/received_events","type":"User","site_admin":false},"body":"Dont think this warning message is required here","created_at":"2014-02-12T06:21:48Z","updated_at":"2014-02-12T06:21:48Z","html_url":"https://github.com/nemomobile/buteo-syncml/pull/9#discussion_r9657320","pull_request_url":"https://api.github.com/repos/nemomobile/buteo-syncml/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/nemomobile/buteo-syncml/pulls/comments/9657320"},"html":{"href":"https://github.com/nemomobile/buteo-syncml/pull/9#discussion_r9657320"},"pull_request":{"href":"https://api.github.com/repos/nemomobile/buteo-syncml/pulls/9"}}}}