GitHub PullRequestReviewCommentEvent at 2014-10-13 16:07:19
Repository: dasein-cloud-aws
Actor: clstokes
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls/comments/18778066","id":18778066,"diff_hunk":"@@ -259,29 +259,34 @@ public String createLaunchConfiguration(@Nonnull LaunchConfigurationCreateOption\n           int z = 1;\n           for( VolumeAttachment va : options.getVolumeAttachment() ) {\n             parameters.put(\"BlockDeviceMappings.member.\" + z + \".DeviceName\", va.deviceId);\n-            EBSVolume ebsv = new EBSVolume( provider );\n-            String volType = null;\n-            try {\n-              VolumeProduct prd = ebsv.getVolumeProduct( va.volumeToCreate.getVolumeProductId() );\n-              volType = prd.getProviderProductId();\n-            } catch ( Exception e ) {\n-              // toss it\n-            }\n-            if( volType == null ) {\n-              if( options.getIOOptimized() && va.volumeToCreate.getIops() > 0 ) {\n-                parameters.put(\"BlockDeviceMappings.member.\" + z + \".Ebs.VolumeType\", \"io1\");\n-              }\n+            if (va.volumeToCreate.getVolumeProductId() != null && va.volumeToCreate.getVolumeProductId().equalsIgnoreCase(EphemeralVolume.VOLUME_PRODUCT_EPHEMERAL)) {\n+              int index = z - 1;\n+              parameters.put(\"BlockDeviceMappings.member.\" + z + \".VirtualName\", EphemeralVolume.VOLUME_PRODUCT_EPHEMERAL + index);\n             } else {\n-              parameters.put(\"BlockDeviceMappings.member.\" + z + \".Ebs.VolumeType\", volType);\n-            }\n-            if(va.volumeToCreate.getIops() > 0) {\n-              parameters.put(\"BlockDeviceMappings.member.\" + z + \".Ebs.Iops\", String.valueOf(va.volumeToCreate.getIops()));\n-            }\n-            if(va.volumeToCreate.getSnapshotId() != null) {\n-              parameters.put(\"BlockDeviceMappings.member.\" + z + \".Ebs.SnapshotId\", va.volumeToCreate.getSnapshotId());\n-            }\n-            if(va.volumeToCreate.getVolumeSize().getQuantity().intValue() > 0) {\n-              parameters.put(\"BlockDeviceMappings.member.\" + z + \".Ebs.VolumeSize\", String.valueOf(va.volumeToCreate.getVolumeSize().getQuantity().intValue()));\n+              EBSVolume ebsv = new EBSVolume(provider);\n+              String volType = null;\n+              try {\n+                VolumeProduct prd = ebsv.getVolumeProduct(va.volumeToCreate.getVolumeProductId());\n+                volType = prd.getProviderProductId();\n+              } catch (Exception e) {\n+                // toss it\n+              }\n+              if (volType == null) {\n+                if (options.getIOOptimized() && va.volumeToCreate.getIops() > 0) {","path":"src/main/java/org/dasein/cloud/aws/compute/AutoScaling.java","position":39,"original_position":39,"commit_id":"ccf08c6b364154263667c65ea05f8bd534680f3a","original_commit_id":"ccf08c6b364154263667c65ea05f8bd534680f3a","user":{"login":"clstokes","id":293763,"avatar_url":"https://avatars.githubusercontent.com/u/293763?v=2","gravatar_id":"","url":"https://api.github.com/users/clstokes","html_url":"https://github.com/clstokes","followers_url":"https://api.github.com/users/clstokes/followers","following_url":"https://api.github.com/users/clstokes/following{/other_user}","gists_url":"https://api.github.com/users/clstokes/gists{/gist_id}","starred_url":"https://api.github.com/users/clstokes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clstokes/subscriptions","organizations_url":"https://api.github.com/users/clstokes/orgs","repos_url":"https://api.github.com/users/clstokes/repos","events_url":"https://api.github.com/users/clstokes/events{/privacy}","received_events_url":"https://api.github.com/users/clstokes/received_events","type":"User","site_admin":false},"body":"You're right, I see that now. You can leave it as is then.","created_at":"2014-10-13T16:07:19Z","updated_at":"2014-10-13T16:07:19Z","html_url":"https://github.com/TheWeatherCompany/dasein-cloud-aws/pull/135#discussion_r18778066","pull_request_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls/comments/18778066"},"html":{"href":"https://github.com/TheWeatherCompany/dasein-cloud-aws/pull/135#discussion_r18778066"},"pull_request":{"href":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls/135","id":22561162,"html_url":"https://github.com/TheWeatherCompany/dasein-cloud-aws/pull/135","diff_url":"https://github.com/TheWeatherCompany/dasein-cloud-aws/pull/135.diff","patch_url":"https://github.com/TheWeatherCompany/dasein-cloud-aws/pull/135.patch","issue_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/issues/135","number":135,"state":"open","locked":false,"title":"TheWeatherCompany/grid-api#1212 Add support for instance-store/ephemeral drives.","user":{"login":"ebakaev","id":6085191,"avatar_url":"https://avatars.githubusercontent.com/u/6085191?v=2","gravatar_id":"","url":"https://api.github.com/users/ebakaev","html_url":"https://github.com/ebakaev","followers_url":"https://api.github.com/users/ebakaev/followers","following_url":"https://api.github.com/users/ebakaev/following{/other_user}","gists_url":"https://api.github.com/users/ebakaev/gists{/gist_id}","starred_url":"https://api.github.com/users/ebakaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebakaev/subscriptions","organizations_url":"https://api.github.com/users/ebakaev/orgs","repos_url":"https://api.github.com/users/ebakaev/repos","events_url":"https://api.github.com/users/ebakaev/events{/privacy}","received_events_url":"https://api.github.com/users/ebakaev/received_events","type":"User","site_admin":false},"body":"PR for TheWeatherCompany/grid-api#1212","created_at":"2014-10-10T13:46:30Z","updated_at":"2014-10-13T16:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f51a717b8051d57bb1e88e3e9805d876718966e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls/135/commits","review_comments_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls/135/comments","review_comment_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/issues/135/comments","statuses_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/statuses/ccf08c6b364154263667c65ea05f8bd534680f3a","head":{"label":"TheWeatherCompany:issue-1212","ref":"issue-1212","sha":"ccf08c6b364154263667c65ea05f8bd534680f3a","user":{"login":"TheWeatherCompany","id":2650031,"avatar_url":"https://avatars.githubusercontent.com/u/2650031?v=2","gravatar_id":"","url":"https://api.github.com/users/TheWeatherCompany","html_url":"https://github.com/TheWeatherCompany","followers_url":"https://api.github.com/users/TheWeatherCompany/followers","following_url":"https://api.github.com/users/TheWeatherCompany/following{/other_user}","gists_url":"https://api.github.com/users/TheWeatherCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/TheWeatherCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheWeatherCompany/subscriptions","organizations_url":"https://api.github.com/users/TheWeatherCompany/orgs","repos_url":"https://api.github.com/users/TheWeatherCompany/repos","events_url":"https://api.github.com/users/TheWeatherCompany/events{/privacy}","received_events_url":"https://api.github.com/users/TheWeatherCompany/received_events","type":"Organization","site_admin":false},"repo":{"id":8527301,"name":"dasein-cloud-aws","full_name":"TheWeatherCompany/dasein-cloud-aws","owner":{"login":"TheWeatherCompany","id":2650031,"avatar_url":"https://avatars.githubusercontent.com/u/2650031?v=2","gravatar_id":"","url":"https://api.github.com/users/TheWeatherCompany","html_url":"https://github.com/TheWeatherCompany","followers_url":"https://api.github.com/users/TheWeatherCompany/followers","following_url":"https://api.github.com/users/TheWeatherCompany/following{/other_user}","gists_url":"https://api.github.com/users/TheWeatherCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/TheWeatherCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheWeatherCompany/subscriptions","organizations_url":"https://api.github.com/users/TheWeatherCompany/orgs","repos_url":"https://api.github.com/users/TheWeatherCompany/repos","events_url":"https://api.github.com/users/TheWeatherCompany/events{/privacy}","received_events_url":"https://api.github.com/users/TheWeatherCompany/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheWeatherCompany/dasein-cloud-aws","description":"Dasein Cloud implementation for Amazon Web Services and clouds and platforms that support the AWS APIs. For more information, see the Dasein Cloud home page at https://github.com/greese/dasein-cloud.","fork":true,"url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws","forks_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/forks","keys_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/teams","hooks_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/hooks","issue_events_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/issues/events{/number}","events_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/events","assignees_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/assignees{/user}","branches_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/branches{/branch}","tags_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/tags","blobs_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/languages","stargazers_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/stargazers","contributors_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/contributors","subscribers_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/subscribers","subscription_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/subscription","commits_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/issues/comments/{number}","contents_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/contents/{+path}","compare_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/merges","archive_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/downloads","issues_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/issues{/number}","pulls_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/labels{/name}","releases_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/releases{/id}","created_at":"2013-03-02T21:28:45Z","updated_at":"2014-07-02T22:55:58Z","pushed_at":"2014-10-13T09:41:29Z","git_url":"git://github.com/TheWeatherCompany/dasein-cloud-aws.git","ssh_url":"git@github.com:TheWeatherCompany/dasein-cloud-aws.git","clone_url":"https://github.com/TheWeatherCompany/dasein-cloud-aws.git","svn_url":"https://github.com/TheWeatherCompany/dasein-cloud-aws","homepage":"https://github.com/greese/dasein-cloud","size":6790,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"develop"}},"base":{"label":"TheWeatherCompany:develop","ref":"develop","sha":"ccd16662e7ac31dec46c81e58865525c24a172c9","user":{"login":"TheWeatherCompany","id":2650031,"avatar_url":"https://avatars.githubusercontent.com/u/2650031?v=2","gravatar_id":"","url":"https://api.github.com/users/TheWeatherCompany","html_url":"https://github.com/TheWeatherCompany","followers_url":"https://api.github.com/users/TheWeatherCompany/followers","following_url":"https://api.github.com/users/TheWeatherCompany/following{/other_user}","gists_url":"https://api.github.com/users/TheWeatherCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/TheWeatherCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheWeatherCompany/subscriptions","organizations_url":"https://api.github.com/users/TheWeatherCompany/orgs","repos_url":"https://api.github.com/users/TheWeatherCompany/repos","events_url":"https://api.github.com/users/TheWeatherCompany/events{/privacy}","received_events_url":"https://api.github.com/users/TheWeatherCompany/received_events","type":"Organization","site_admin":false},"repo":{"id":8527301,"name":"dasein-cloud-aws","full_name":"TheWeatherCompany/dasein-cloud-aws","owner":{"login":"TheWeatherCompany","id":2650031,"avatar_url":"https://avatars.githubusercontent.com/u/2650031?v=2","gravatar_id":"","url":"https://api.github.com/users/TheWeatherCompany","html_url":"https://github.com/TheWeatherCompany","followers_url":"https://api.github.com/users/TheWeatherCompany/followers","following_url":"https://api.github.com/users/TheWeatherCompany/following{/other_user}","gists_url":"https://api.github.com/users/TheWeatherCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/TheWeatherCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheWeatherCompany/subscriptions","organizations_url":"https://api.github.com/users/TheWeatherCompany/orgs","repos_url":"https://api.github.com/users/TheWeatherCompany/repos","events_url":"https://api.github.com/users/TheWeatherCompany/events{/privacy}","received_events_url":"https://api.github.com/users/TheWeatherCompany/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheWeatherCompany/dasein-cloud-aws","description":"Dasein Cloud implementation for Amazon Web Services and clouds and platforms that support the AWS APIs. For more information, see the Dasein Cloud home page at https://github.com/greese/dasein-cloud.","fork":true,"url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws","forks_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/forks","keys_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/teams","hooks_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/hooks","issue_events_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/issues/events{/number}","events_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/events","assignees_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/assignees{/user}","branches_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/branches{/branch}","tags_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/tags","blobs_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/languages","stargazers_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/stargazers","contributors_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/contributors","subscribers_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/subscribers","subscription_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/subscription","commits_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/issues/comments/{number}","contents_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/contents/{+path}","compare_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/merges","archive_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/downloads","issues_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/issues{/number}","pulls_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/labels{/name}","releases_url":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/releases{/id}","created_at":"2013-03-02T21:28:45Z","updated_at":"2014-07-02T22:55:58Z","pushed_at":"2014-10-13T09:41:29Z","git_url":"git://github.com/TheWeatherCompany/dasein-cloud-aws.git","ssh_url":"git@github.com:TheWeatherCompany/dasein-cloud-aws.git","clone_url":"https://github.com/TheWeatherCompany/dasein-cloud-aws.git","svn_url":"https://github.com/TheWeatherCompany/dasein-cloud-aws","homepage":"https://github.com/greese/dasein-cloud","size":6790,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls/135"},"html":{"href":"https://github.com/TheWeatherCompany/dasein-cloud-aws/pull/135"},"issue":{"href":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/issues/135"},"comments":{"href":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/TheWeatherCompany/dasein-cloud-aws/statuses/ccf08c6b364154263667c65ea05f8bd534680f3a"}}}}