GitHub PullRequestReviewCommentEvent at 2014-07-29 02:39:57
Repository: radix-extra
Actor: mediocregopher
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mediocregopher/radix-extra/pulls/comments/15503587","id":15503587,"diff_hunk":"@@ -0,0 +1,121 @@\n+package pubsub\n+\n+import (\n+\t\"errors\"\n+\n+\t\"github.com/fzzy/radix/redis\"\n+)\n+\n+type SubReplyType uint8\n+\n+const (\n+\tErrorReply SubReplyType = iota\n+\tSubscribeType\n+\tUnsubscribeType\n+\tMessageType\n+)\n+\n+// SubClient wraps a Redis client to provide convenience methods for Pub/Sub functionality.\n+type SubClient struct {\n+\tClient *redis.Client\n+}\n+\n+// SubReply wraps a Redis reply and provides convienient access to Pub/Sub info.\n+type SubReply struct {","path":"pubsub/sub.go","position":24,"original_position":24,"commit_id":"ed295ddf3a1c8e6546cce3473dde32fb9939c259","original_commit_id":"ed295ddf3a1c8e6546cce3473dde32fb9939c259","user":{"login":"mediocregopher","id":933154,"avatar_url":"https://avatars.githubusercontent.com/u/933154?","gravatar_id":"8f5dc7f41dfb74103abd27127a7f4c61","url":"https://api.github.com/users/mediocregopher","html_url":"https://github.com/mediocregopher","followers_url":"https://api.github.com/users/mediocregopher/followers","following_url":"https://api.github.com/users/mediocregopher/following{/other_user}","gists_url":"https://api.github.com/users/mediocregopher/gists{/gist_id}","starred_url":"https://api.github.com/users/mediocregopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mediocregopher/subscriptions","organizations_url":"https://api.github.com/users/mediocregopher/orgs","repos_url":"https://api.github.com/users/mediocregopher/repos","events_url":"https://api.github.com/users/mediocregopher/events{/privacy}","received_events_url":"https://api.github.com/users/mediocregopher/received_events","type":"User","site_admin":false},"body":"I think `SubReply` needs a quick way to determine if the reply is a network timeout or not (and then a mention of that in the comment for `Receive`, so people know they'll need to use it). A method on the struct which basically does the check on `Err` and returns a bool would work.","created_at":"2014-07-29T02:39:57Z","updated_at":"2014-07-29T02:39:57Z","html_url":"https://github.com/mediocregopher/radix-extra/pull/1#discussion_r15503587","pull_request_url":"https://api.github.com/repos/mediocregopher/radix-extra/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/mediocregopher/radix-extra/pulls/comments/15503587"},"html":{"href":"https://github.com/mediocregopher/radix-extra/pull/1#discussion_r15503587"},"pull_request":{"href":"https://api.github.com/repos/mediocregopher/radix-extra/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/mediocregopher/radix-extra/pulls/1","id":18996346,"html_url":"https://github.com/mediocregopher/radix-extra/pull/1","diff_url":"https://github.com/mediocregopher/radix-extra/pull/1.diff","patch_url":"https://github.com/mediocregopher/radix-extra/pull/1.patch","issue_url":"https://api.github.com/repos/mediocregopher/radix-extra/issues/1","number":1,"state":"open","title":"added pub/sub wrapper package","user":{"login":"betamike","id":170381,"avatar_url":"https://avatars.githubusercontent.com/u/170381?","gravatar_id":"f989d9554347a1769f11adca4ee9c119","url":"https://api.github.com/users/betamike","html_url":"https://github.com/betamike","followers_url":"https://api.github.com/users/betamike/followers","following_url":"https://api.github.com/users/betamike/following{/other_user}","gists_url":"https://api.github.com/users/betamike/gists{/gist_id}","starred_url":"https://api.github.com/users/betamike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betamike/subscriptions","organizations_url":"https://api.github.com/users/betamike/orgs","repos_url":"https://api.github.com/users/betamike/repos","events_url":"https://api.github.com/users/betamike/events{/privacy}","received_events_url":"https://api.github.com/users/betamike/received_events","type":"User","site_admin":false},"body":"Added support for Redis Pub/Sub connections by wrapping the `redis.Client` instance and providing convenience methods and types.","created_at":"2014-07-28T21:54:00Z","updated_at":"2014-07-29T02:39:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35ad58014c9de8b85102e8554ec69e6295686e41","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mediocregopher/radix-extra/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mediocregopher/radix-extra/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mediocregopher/radix-extra/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mediocregopher/radix-extra/issues/1/comments","statuses_url":"https://api.github.com/repos/mediocregopher/radix-extra/statuses/ed295ddf3a1c8e6546cce3473dde32fb9939c259","head":{"label":"betamike:pubsub","ref":"pubsub","sha":"ed295ddf3a1c8e6546cce3473dde32fb9939c259","user":{"login":"betamike","id":170381,"avatar_url":"https://avatars.githubusercontent.com/u/170381?","gravatar_id":"f989d9554347a1769f11adca4ee9c119","url":"https://api.github.com/users/betamike","html_url":"https://github.com/betamike","followers_url":"https://api.github.com/users/betamike/followers","following_url":"https://api.github.com/users/betamike/following{/other_user}","gists_url":"https://api.github.com/users/betamike/gists{/gist_id}","starred_url":"https://api.github.com/users/betamike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betamike/subscriptions","organizations_url":"https://api.github.com/users/betamike/orgs","repos_url":"https://api.github.com/users/betamike/repos","events_url":"https://api.github.com/users/betamike/events{/privacy}","received_events_url":"https://api.github.com/users/betamike/received_events","type":"User","site_admin":false},"repo":{"id":22355180,"name":"radix-extra","full_name":"betamike/radix-extra","owner":{"login":"betamike","id":170381,"avatar_url":"https://avatars.githubusercontent.com/u/170381?","gravatar_id":"f989d9554347a1769f11adca4ee9c119","url":"https://api.github.com/users/betamike","html_url":"https://github.com/betamike","followers_url":"https://api.github.com/users/betamike/followers","following_url":"https://api.github.com/users/betamike/following{/other_user}","gists_url":"https://api.github.com/users/betamike/gists{/gist_id}","starred_url":"https://api.github.com/users/betamike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betamike/subscriptions","organizations_url":"https://api.github.com/users/betamike/orgs","repos_url":"https://api.github.com/users/betamike/repos","events_url":"https://api.github.com/users/betamike/events{/privacy}","received_events_url":"https://api.github.com/users/betamike/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/betamike/radix-extra","description":"Extra functionality built around the radix redis client","fork":true,"url":"https://api.github.com/repos/betamike/radix-extra","forks_url":"https://api.github.com/repos/betamike/radix-extra/forks","keys_url":"https://api.github.com/repos/betamike/radix-extra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betamike/radix-extra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betamike/radix-extra/teams","hooks_url":"https://api.github.com/repos/betamike/radix-extra/hooks","issue_events_url":"https://api.github.com/repos/betamike/radix-extra/issues/events{/number}","events_url":"https://api.github.com/repos/betamike/radix-extra/events","assignees_url":"https://api.github.com/repos/betamike/radix-extra/assignees{/user}","branches_url":"https://api.github.com/repos/betamike/radix-extra/branches{/branch}","tags_url":"https://api.github.com/repos/betamike/radix-extra/tags","blobs_url":"https://api.github.com/repos/betamike/radix-extra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betamike/radix-extra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betamike/radix-extra/git/refs{/sha}","trees_url":"https://api.github.com/repos/betamike/radix-extra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betamike/radix-extra/statuses/{sha}","languages_url":"https://api.github.com/repos/betamike/radix-extra/languages","stargazers_url":"https://api.github.com/repos/betamike/radix-extra/stargazers","contributors_url":"https://api.github.com/repos/betamike/radix-extra/contributors","subscribers_url":"https://api.github.com/repos/betamike/radix-extra/subscribers","subscription_url":"https://api.github.com/repos/betamike/radix-extra/subscription","commits_url":"https://api.github.com/repos/betamike/radix-extra/commits{/sha}","git_commits_url":"https://api.github.com/repos/betamike/radix-extra/git/commits{/sha}","comments_url":"https://api.github.com/repos/betamike/radix-extra/comments{/number}","issue_comment_url":"https://api.github.com/repos/betamike/radix-extra/issues/comments/{number}","contents_url":"https://api.github.com/repos/betamike/radix-extra/contents/{+path}","compare_url":"https://api.github.com/repos/betamike/radix-extra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betamike/radix-extra/merges","archive_url":"https://api.github.com/repos/betamike/radix-extra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betamike/radix-extra/downloads","issues_url":"https://api.github.com/repos/betamike/radix-extra/issues{/number}","pulls_url":"https://api.github.com/repos/betamike/radix-extra/pulls{/number}","milestones_url":"https://api.github.com/repos/betamike/radix-extra/milestones{/number}","notifications_url":"https://api.github.com/repos/betamike/radix-extra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betamike/radix-extra/labels{/name}","releases_url":"https://api.github.com/repos/betamike/radix-extra/releases{/id}","created_at":"2014-07-28T19:33:59Z","updated_at":"2014-07-28T21:51:43Z","pushed_at":"2014-07-28T21:53:15Z","git_url":"git://github.com/betamike/radix-extra.git","ssh_url":"git@github.com:betamike/radix-extra.git","clone_url":"https://github.com/betamike/radix-extra.git","svn_url":"https://github.com/betamike/radix-extra","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mediocregopher:master","ref":"master","sha":"d1ff4c9ee0939c5786882ab90b46dfa3965f1a07","user":{"login":"mediocregopher","id":933154,"avatar_url":"https://avatars.githubusercontent.com/u/933154?","gravatar_id":"8f5dc7f41dfb74103abd27127a7f4c61","url":"https://api.github.com/users/mediocregopher","html_url":"https://github.com/mediocregopher","followers_url":"https://api.github.com/users/mediocregopher/followers","following_url":"https://api.github.com/users/mediocregopher/following{/other_user}","gists_url":"https://api.github.com/users/mediocregopher/gists{/gist_id}","starred_url":"https://api.github.com/users/mediocregopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mediocregopher/subscriptions","organizations_url":"https://api.github.com/users/mediocregopher/orgs","repos_url":"https://api.github.com/users/mediocregopher/repos","events_url":"https://api.github.com/users/mediocregopher/events{/privacy}","received_events_url":"https://api.github.com/users/mediocregopher/received_events","type":"User","site_admin":false},"repo":{"id":22221731,"name":"radix-extra","full_name":"mediocregopher/radix-extra","owner":{"login":"mediocregopher","id":933154,"avatar_url":"https://avatars.githubusercontent.com/u/933154?","gravatar_id":"8f5dc7f41dfb74103abd27127a7f4c61","url":"https://api.github.com/users/mediocregopher","html_url":"https://github.com/mediocregopher","followers_url":"https://api.github.com/users/mediocregopher/followers","following_url":"https://api.github.com/users/mediocregopher/following{/other_user}","gists_url":"https://api.github.com/users/mediocregopher/gists{/gist_id}","starred_url":"https://api.github.com/users/mediocregopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mediocregopher/subscriptions","organizations_url":"https://api.github.com/users/mediocregopher/orgs","repos_url":"https://api.github.com/users/mediocregopher/repos","events_url":"https://api.github.com/users/mediocregopher/events{/privacy}","received_events_url":"https://api.github.com/users/mediocregopher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mediocregopher/radix-extra","description":"Extra functionality built around the radix redis client","fork":false,"url":"https://api.github.com/repos/mediocregopher/radix-extra","forks_url":"https://api.github.com/repos/mediocregopher/radix-extra/forks","keys_url":"https://api.github.com/repos/mediocregopher/radix-extra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mediocregopher/radix-extra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mediocregopher/radix-extra/teams","hooks_url":"https://api.github.com/repos/mediocregopher/radix-extra/hooks","issue_events_url":"https://api.github.com/repos/mediocregopher/radix-extra/issues/events{/number}","events_url":"https://api.github.com/repos/mediocregopher/radix-extra/events","assignees_url":"https://api.github.com/repos/mediocregopher/radix-extra/assignees{/user}","branches_url":"https://api.github.com/repos/mediocregopher/radix-extra/branches{/branch}","tags_url":"https://api.github.com/repos/mediocregopher/radix-extra/tags","blobs_url":"https://api.github.com/repos/mediocregopher/radix-extra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mediocregopher/radix-extra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mediocregopher/radix-extra/git/refs{/sha}","trees_url":"https://api.github.com/repos/mediocregopher/radix-extra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mediocregopher/radix-extra/statuses/{sha}","languages_url":"https://api.github.com/repos/mediocregopher/radix-extra/languages","stargazers_url":"https://api.github.com/repos/mediocregopher/radix-extra/stargazers","contributors_url":"https://api.github.com/repos/mediocregopher/radix-extra/contributors","subscribers_url":"https://api.github.com/repos/mediocregopher/radix-extra/subscribers","subscription_url":"https://api.github.com/repos/mediocregopher/radix-extra/subscription","commits_url":"https://api.github.com/repos/mediocregopher/radix-extra/commits{/sha}","git_commits_url":"https://api.github.com/repos/mediocregopher/radix-extra/git/commits{/sha}","comments_url":"https://api.github.com/repos/mediocregopher/radix-extra/comments{/number}","issue_comment_url":"https://api.github.com/repos/mediocregopher/radix-extra/issues/comments/{number}","contents_url":"https://api.github.com/repos/mediocregopher/radix-extra/contents/{+path}","compare_url":"https://api.github.com/repos/mediocregopher/radix-extra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mediocregopher/radix-extra/merges","archive_url":"https://api.github.com/repos/mediocregopher/radix-extra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mediocregopher/radix-extra/downloads","issues_url":"https://api.github.com/repos/mediocregopher/radix-extra/issues{/number}","pulls_url":"https://api.github.com/repos/mediocregopher/radix-extra/pulls{/number}","milestones_url":"https://api.github.com/repos/mediocregopher/radix-extra/milestones{/number}","notifications_url":"https://api.github.com/repos/mediocregopher/radix-extra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mediocregopher/radix-extra/labels{/name}","releases_url":"https://api.github.com/repos/mediocregopher/radix-extra/releases{/id}","created_at":"2014-07-24T16:57:56Z","updated_at":"2014-07-28T22:16:46Z","pushed_at":"2014-07-25T23:26:16Z","git_url":"git://github.com/mediocregopher/radix-extra.git","ssh_url":"git@github.com:mediocregopher/radix-extra.git","clone_url":"https://github.com/mediocregopher/radix-extra.git","svn_url":"https://github.com/mediocregopher/radix-extra","homepage":null,"size":0,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mediocregopher/radix-extra/pulls/1"},"html":{"href":"https://github.com/mediocregopher/radix-extra/pull/1"},"issue":{"href":"https://api.github.com/repos/mediocregopher/radix-extra/issues/1"},"comments":{"href":"https://api.github.com/repos/mediocregopher/radix-extra/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mediocregopher/radix-extra/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mediocregopher/radix-extra/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mediocregopher/radix-extra/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mediocregopher/radix-extra/statuses/ed295ddf3a1c8e6546cce3473dde32fb9939c259"}}}}