GitHub PullRequestEvent at 2014-09-25 19:13:08
Repository: KDSoap
Actor: mbroadst
Payload: {"action":"opened","number":50,"pull_request":{"url":"https://api.github.com/repos/KDAB/KDSoap/pulls/50","id":21805499,"html_url":"https://github.com/KDAB/KDSoap/pull/50","diff_url":"https://github.com/KDAB/KDSoap/pull/50.diff","patch_url":"https://github.com/KDAB/KDSoap/pull/50.patch","issue_url":"https://api.github.com/repos/KDAB/KDSoap/issues/50","number":50,"state":"open","locked":false,"title":"noop log calls if LogLevel is LogNothing","user":{"login":"mbroadst","id":312966,"avatar_url":"https://avatars.githubusercontent.com/u/312966?v=2","gravatar_id":"","url":"https://api.github.com/users/mbroadst","html_url":"https://github.com/mbroadst","followers_url":"https://api.github.com/users/mbroadst/followers","following_url":"https://api.github.com/users/mbroadst/following{/other_user}","gists_url":"https://api.github.com/users/mbroadst/gists{/gist_id}","starred_url":"https://api.github.com/users/mbroadst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbroadst/subscriptions","organizations_url":"https://api.github.com/users/mbroadst/orgs","repos_url":"https://api.github.com/users/mbroadst/repos","events_url":"https://api.github.com/users/mbroadst/events{/privacy}","received_events_url":"https://api.github.com/users/mbroadst/received_events","type":"User","site_admin":false},"body":"I've only experienced this on qt5 builds, but for some reason with\r\nthe default log level of LogNothing, calls to KDSoapServer::log\r\nresult in continuous warning about the QIODevice not being open\r\nfor writing\r\n\r\nFor completeness I've added some checks for flushing and closing the log file as well","created_at":"2014-09-25T19:13:08Z","updated_at":"2014-09-25T19:13:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KDAB/KDSoap/pulls/50/commits","review_comments_url":"https://api.github.com/repos/KDAB/KDSoap/pulls/50/comments","review_comment_url":"https://api.github.com/repos/KDAB/KDSoap/pulls/comments/{number}","comments_url":"https://api.github.com/repos/KDAB/KDSoap/issues/50/comments","statuses_url":"https://api.github.com/repos/KDAB/KDSoap/statuses/966d1b8450300ee4bde6ed0b0ac21ade062cf851","head":{"label":"mbroadst:log-bug","ref":"log-bug","sha":"966d1b8450300ee4bde6ed0b0ac21ade062cf851","user":{"login":"mbroadst","id":312966,"avatar_url":"https://avatars.githubusercontent.com/u/312966?v=2","gravatar_id":"","url":"https://api.github.com/users/mbroadst","html_url":"https://github.com/mbroadst","followers_url":"https://api.github.com/users/mbroadst/followers","following_url":"https://api.github.com/users/mbroadst/following{/other_user}","gists_url":"https://api.github.com/users/mbroadst/gists{/gist_id}","starred_url":"https://api.github.com/users/mbroadst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbroadst/subscriptions","organizations_url":"https://api.github.com/users/mbroadst/orgs","repos_url":"https://api.github.com/users/mbroadst/repos","events_url":"https://api.github.com/users/mbroadst/events{/privacy}","received_events_url":"https://api.github.com/users/mbroadst/received_events","type":"User","site_admin":false},"repo":{"id":24471411,"name":"KDSoap","full_name":"mbroadst/KDSoap","owner":{"login":"mbroadst","id":312966,"avatar_url":"https://avatars.githubusercontent.com/u/312966?v=2","gravatar_id":"","url":"https://api.github.com/users/mbroadst","html_url":"https://github.com/mbroadst","followers_url":"https://api.github.com/users/mbroadst/followers","following_url":"https://api.github.com/users/mbroadst/following{/other_user}","gists_url":"https://api.github.com/users/mbroadst/gists{/gist_id}","starred_url":"https://api.github.com/users/mbroadst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbroadst/subscriptions","organizations_url":"https://api.github.com/users/mbroadst/orgs","repos_url":"https://api.github.com/users/mbroadst/repos","events_url":"https://api.github.com/users/mbroadst/events{/privacy}","received_events_url":"https://api.github.com/users/mbroadst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbroadst/KDSoap","description":"KD Soap","fork":true,"url":"https://api.github.com/repos/mbroadst/KDSoap","forks_url":"https://api.github.com/repos/mbroadst/KDSoap/forks","keys_url":"https://api.github.com/repos/mbroadst/KDSoap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbroadst/KDSoap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbroadst/KDSoap/teams","hooks_url":"https://api.github.com/repos/mbroadst/KDSoap/hooks","issue_events_url":"https://api.github.com/repos/mbroadst/KDSoap/issues/events{/number}","events_url":"https://api.github.com/repos/mbroadst/KDSoap/events","assignees_url":"https://api.github.com/repos/mbroadst/KDSoap/assignees{/user}","branches_url":"https://api.github.com/repos/mbroadst/KDSoap/branches{/branch}","tags_url":"https://api.github.com/repos/mbroadst/KDSoap/tags","blobs_url":"https://api.github.com/repos/mbroadst/KDSoap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbroadst/KDSoap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbroadst/KDSoap/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbroadst/KDSoap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbroadst/KDSoap/statuses/{sha}","languages_url":"https://api.github.com/repos/mbroadst/KDSoap/languages","stargazers_url":"https://api.github.com/repos/mbroadst/KDSoap/stargazers","contributors_url":"https://api.github.com/repos/mbroadst/KDSoap/contributors","subscribers_url":"https://api.github.com/repos/mbroadst/KDSoap/subscribers","subscription_url":"https://api.github.com/repos/mbroadst/KDSoap/subscription","commits_url":"https://api.github.com/repos/mbroadst/KDSoap/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbroadst/KDSoap/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbroadst/KDSoap/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbroadst/KDSoap/issues/comments/{number}","contents_url":"https://api.github.com/repos/mbroadst/KDSoap/contents/{+path}","compare_url":"https://api.github.com/repos/mbroadst/KDSoap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbroadst/KDSoap/merges","archive_url":"https://api.github.com/repos/mbroadst/KDSoap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbroadst/KDSoap/downloads","issues_url":"https://api.github.com/repos/mbroadst/KDSoap/issues{/number}","pulls_url":"https://api.github.com/repos/mbroadst/KDSoap/pulls{/number}","milestones_url":"https://api.github.com/repos/mbroadst/KDSoap/milestones{/number}","notifications_url":"https://api.github.com/repos/mbroadst/KDSoap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbroadst/KDSoap/labels{/name}","releases_url":"https://api.github.com/repos/mbroadst/KDSoap/releases{/id}","created_at":"2014-09-25T19:06:18Z","updated_at":"2014-09-20T19:58:30Z","pushed_at":"2014-09-25T19:12:24Z","git_url":"git://github.com/mbroadst/KDSoap.git","ssh_url":"git@github.com:mbroadst/KDSoap.git","clone_url":"https://github.com/mbroadst/KDSoap.git","svn_url":"https://github.com/mbroadst/KDSoap","homepage":null,"size":14157,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KDAB:master","ref":"master","sha":"583ae39eeec54685912a691f6999d1adf59213f2","user":{"login":"KDAB","id":402842,"avatar_url":"https://avatars.githubusercontent.com/u/402842?v=2","gravatar_id":"","url":"https://api.github.com/users/KDAB","html_url":"https://github.com/KDAB","followers_url":"https://api.github.com/users/KDAB/followers","following_url":"https://api.github.com/users/KDAB/following{/other_user}","gists_url":"https://api.github.com/users/KDAB/gists{/gist_id}","starred_url":"https://api.github.com/users/KDAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KDAB/subscriptions","organizations_url":"https://api.github.com/users/KDAB/orgs","repos_url":"https://api.github.com/users/KDAB/repos","events_url":"https://api.github.com/users/KDAB/events{/privacy}","received_events_url":"https://api.github.com/users/KDAB/received_events","type":"Organization","site_admin":false},"repo":{"id":5067171,"name":"KDSoap","full_name":"KDAB/KDSoap","owner":{"login":"KDAB","id":402842,"avatar_url":"https://avatars.githubusercontent.com/u/402842?v=2","gravatar_id":"","url":"https://api.github.com/users/KDAB","html_url":"https://github.com/KDAB","followers_url":"https://api.github.com/users/KDAB/followers","following_url":"https://api.github.com/users/KDAB/following{/other_user}","gists_url":"https://api.github.com/users/KDAB/gists{/gist_id}","starred_url":"https://api.github.com/users/KDAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KDAB/subscriptions","organizations_url":"https://api.github.com/users/KDAB/orgs","repos_url":"https://api.github.com/users/KDAB/repos","events_url":"https://api.github.com/users/KDAB/events{/privacy}","received_events_url":"https://api.github.com/users/KDAB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KDAB/KDSoap","description":"KD Soap","fork":false,"url":"https://api.github.com/repos/KDAB/KDSoap","forks_url":"https://api.github.com/repos/KDAB/KDSoap/forks","keys_url":"https://api.github.com/repos/KDAB/KDSoap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KDAB/KDSoap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KDAB/KDSoap/teams","hooks_url":"https://api.github.com/repos/KDAB/KDSoap/hooks","issue_events_url":"https://api.github.com/repos/KDAB/KDSoap/issues/events{/number}","events_url":"https://api.github.com/repos/KDAB/KDSoap/events","assignees_url":"https://api.github.com/repos/KDAB/KDSoap/assignees{/user}","branches_url":"https://api.github.com/repos/KDAB/KDSoap/branches{/branch}","tags_url":"https://api.github.com/repos/KDAB/KDSoap/tags","blobs_url":"https://api.github.com/repos/KDAB/KDSoap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KDAB/KDSoap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KDAB/KDSoap/git/refs{/sha}","trees_url":"https://api.github.com/repos/KDAB/KDSoap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KDAB/KDSoap/statuses/{sha}","languages_url":"https://api.github.com/repos/KDAB/KDSoap/languages","stargazers_url":"https://api.github.com/repos/KDAB/KDSoap/stargazers","contributors_url":"https://api.github.com/repos/KDAB/KDSoap/contributors","subscribers_url":"https://api.github.com/repos/KDAB/KDSoap/subscribers","subscription_url":"https://api.github.com/repos/KDAB/KDSoap/subscription","commits_url":"https://api.github.com/repos/KDAB/KDSoap/commits{/sha}","git_commits_url":"https://api.github.com/repos/KDAB/KDSoap/git/commits{/sha}","comments_url":"https://api.github.com/repos/KDAB/KDSoap/comments{/number}","issue_comment_url":"https://api.github.com/repos/KDAB/KDSoap/issues/comments/{number}","contents_url":"https://api.github.com/repos/KDAB/KDSoap/contents/{+path}","compare_url":"https://api.github.com/repos/KDAB/KDSoap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KDAB/KDSoap/merges","archive_url":"https://api.github.com/repos/KDAB/KDSoap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KDAB/KDSoap/downloads","issues_url":"https://api.github.com/repos/KDAB/KDSoap/issues{/number}","pulls_url":"https://api.github.com/repos/KDAB/KDSoap/pulls{/number}","milestones_url":"https://api.github.com/repos/KDAB/KDSoap/milestones{/number}","notifications_url":"https://api.github.com/repos/KDAB/KDSoap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KDAB/KDSoap/labels{/name}","releases_url":"https://api.github.com/repos/KDAB/KDSoap/releases{/id}","created_at":"2012-07-16T12:35:43Z","updated_at":"2014-09-20T19:58:30Z","pushed_at":"2014-09-20T19:58:30Z","git_url":"git://github.com/KDAB/KDSoap.git","ssh_url":"git@github.com:KDAB/KDSoap.git","clone_url":"https://github.com/KDAB/KDSoap.git","svn_url":"https://github.com/KDAB/KDSoap","homepage":null,"size":14157,"stargazers_count":23,"watchers_count":23,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":13,"forks":15,"open_issues":13,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KDAB/KDSoap/pulls/50"},"html":{"href":"https://github.com/KDAB/KDSoap/pull/50"},"issue":{"href":"https://api.github.com/repos/KDAB/KDSoap/issues/50"},"comments":{"href":"https://api.github.com/repos/KDAB/KDSoap/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/KDAB/KDSoap/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/KDAB/KDSoap/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/KDAB/KDSoap/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/KDAB/KDSoap/statuses/966d1b8450300ee4bde6ed0b0ac21ade062cf851"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}