GitHub PushEvent at 2014-01-30 23:54:58
Repository: ganeti
Actor: badp
Payload: {"shas":[["a87a017b023e2979b73f11dcf9012602bfa4b13c","9d19625f8ee825a2c398462ed335cbcf98f79c32@google.com","Remove FromString in favor of Error from standard libraries\n\nThey have the very same functionality, and using our own FromString only\ncauses unnecessary code duplication.\n\nSigned-off-by: Petr Pudlak <pudlak@google.com>\nReviewed-by: Klaus Aehlig <aehlig@google.com>","Petr Pudlak",true],["d20293646a4691e7fcff8797ae9439beeed76efb","9d19625f8ee825a2c398462ed335cbcf98f79c32@google.com","Add instance MonadLog for ResultT\n\nThis allows to log in monad stacks containing ResultT.\n\nSigned-off-by: Petr Pudlak <pudlak@google.com>\nReviewed-by: Klaus Aehlig <aehlig@google.com>","Petr Pudlak",true],["861ddf80b07a2ae64cc1901390a44197f7a181e7","9d19625f8ee825a2c398462ed335cbcf98f79c32@google.com","Refactor instance MonadLog (ReaderT r m) to unify style\n\n.. with MonadLog (ResultT e m) to be more point-free.\n\nSigned-off-by: Petr Pudlak <pudlak@google.com>\nReviewed-by: Klaus Aehlig <aehlig@google.com>","Petr Pudlak",true],["565821d1804f8734bdd2959e367449937706fb60","9d19625f8ee825a2c398462ed335cbcf98f79c32@google.com","Add functions for manipulating errors in Result(T)\n\nThere is often need to manipulate these errors, for example to convert a String\nfrom Result into an exception. These functions make this easier.\n\nFunction 'toErrorStr' lifts 'Result' to any 'MonadError'. This is useful\nfor converting 'Result' into 'ResultT' or any other similar monad stack.\n\nFunctions 'catchErrorT' and 'handleErrorT' catch errors just as 'catchError'\ndoes, but also allow to change the error type.\n\nFunctions `withError` and `withErrorT` allow to modify an error within\nGenericResult or ResultT. This is convenient when combining functions\nwith different error types, for example to convert between strings and\nexceptions.\n\nFurthemore, 'failError' generalize 'Bad'. It can be used anywhere 'Bad' is, and\nin any 'MonadError' instance.\n\nSigned-off-by: Petr Pudlak <pudlak@google.com>\nReviewed-by: Klaus Aehlig <aehlig@google.com>","Petr Pudlak",true],["426f0900733029f1617b5162c25e94918bbf3a5d","9d19625f8ee825a2c398462ed335cbcf98f79c32@google.com","Add withErrorLogAt which annotates and logs errors\n\n.. and rethrows them within a MonadError. This allows to just log errors\nand let them be handled elsewhere.\n\nSigned-off-by: Petr Pudlak <pudlak@google.com>\nReviewed-by: Klaus Aehlig <aehlig@google.com>","Petr Pudlak",true],["87f1593409b1b5bf19f973d5904233e4924bdf22","9d19625f8ee825a2c398462ed335cbcf98f79c32@google.com","Generalize type signatures of functions that produce Result\n\nThis allows them to be used in any 'MonadError', in particular in monad stacks\ncomposed using ResultT, without explicit lifting.\n\nSigned-off-by: Petr Pudlak <pudlak@google.com>\nReviewed-by: Klaus Aehlig <aehlig@google.com>","Petr Pudlak",true],["f59cefcb2af6dc108cb99eef340a7d009217680d","9d19625f8ee825a2c398462ed335cbcf98f79c32@google.com","Rename 'resultT' to 'toError'\n\n.. to better correspond to its generalized type.\n\nSigned-off-by: Petr Pudlak <pudlak@google.com>\nReviewed-by: Klaus Aehlig <aehlig@google.com>","Petr Pudlak",true],["fb54b24a7a64f7636434a07f57ed5a8fec34ac27","9d19625f8ee825a2c398462ed335cbcf98f79c32@google.com","Improve liftIO of ResultT to catch IOErrors\n\nAny IOErrors are now captured in ResultT's liftIO using try and converted into\n'Bad'. This prevents IO exceptions from leaking into ResultT code and allows\nthem to be handled in a pure way inside ResultT's sum type.\n\nIt is still possible to avoid 'try' by using 'lift' or 'ResultT' directly,\ntherefore it's recommended to use 'liftIO' only.\n\nNote that other, non-IO exceptions, such as PatternMatchFail, aren't handled.\nThis might be revised in future, if desired.\n\nSigned-off-by: Petr Pudlak <pudlak@google.com>\nReviewed-by: Klaus Aehlig <aehlig@google.com>","Petr Pudlak",true],["ea7032dae4e7ce0f40fb79b57d0a2ca9b1010f07","9d19625f8ee825a2c398462ed335cbcf98f79c32@google.com","Update getDirJobIDs to use ResultT\n\nAlso simplify code and remove unused functions.\n\nSigned-off-by: Petr Pudlak <pudlak@google.com>\nReviewed-by: Klaus Aehlig <aehlig@google.com>","Petr Pudlak",true],["38e4d732fc05f5c9842191c114c2af8e44f41ae8","9d19625f8ee825a2c398462ed335cbcf98f79c32@google.com","Use new error handling functions for querying jobs\n\nSince we already touched getJobIDs, and this function is already based\non ResultT, use new error functions here as well.\n\nSigned-off-by: Petr Pudlak <pudlak@google.com>\nReviewed-by: Klaus Aehlig <aehlig@google.com>","Petr Pudlak",true],["8383b3b6e8324b8ac7379cdf233f6f76694cece8","9d19625f8ee825a2c398462ed335cbcf98f79c32@google.com","Use new error functions when querying locks\n\nThis helps to handle errors coming from the Luxi client.\n\nSigned-off-by: Petr Pudlak <pudlak@google.com>\nReviewed-by: Klaus Aehlig <aehlig@google.com>","Petr Pudlak",true],["f9666f00742f6a96e18e701fe9b79be44898d607","9d19625f8ee825a2c398462ed335cbcf98f79c32@google.com","User new error handling functions in SubmitJobToDrainedQueue\n\nThis somewhat shortens and simplifies the code.\n\nSigned-off-by: Petr Pudlak <pudlak@google.com>\nReviewed-by: Klaus Aehlig <aehlig@google.com>","Petr Pudlak",true],["b13fa4c4324ad44ee6fefb0ef973be0ecd0952c5","0fb9c4f8511df4ec2ae28af879e9d462f6218a2c@google.com","Add script that checks the copyrights of a dirty local repo\n\nScript to check whether the local dirty commits are changing files\nwhich do not have an updated copyright.\n\nThe script will determine your current remote branch and local branch,\nfrom which it will extract the commits to analyze.  Afterwards, for\neach commit, it will see which files are being modified and, for each\nfile, it will check the copyright.\n\nJust call the script before pushing your changes and before\ndevel/review.\n\nSigned-off-by: Jose A. Lopes <jabolopes@google.com>\nReviewed-by: Hrvoje Ribicic <riba@google.com>","Jose A. Lopes",true],["dd3ac0524ce9f70939615cf9c3d96ab5f2c01578","6a214b96de92f36f05379f829a80c82d50682e4c@google.com","rpcs: fix docstrings for instance_os_add","Santi Raffa",true],["a1cf8c4a72a52a0309b259390beecf0405ddd8dd","6a214b96de92f36f05379f829a80c82d50682e4c@google.com","OpCodes test: fix argument order (expected/but got)","Santi Raffa",true],["0bbc7083a1071e0c99250cba35c1c299cbe09890","6a214b96de92f36f05379f829a80c82d50682e4c@google.com","algo: add GetRepeatedKeys\n\nWe do not want public, private and secret parameters to have\noverlapping keys. This function implements this check.","Santi Raffa",true],["d98d4900bcc85cfe3486ad49635d0b24e781905a","6a214b96de92f36f05379f829a80c82d50682e4c@google.com","constants: add visibility levels","Santi Raffa",true],["9edb180bbb1f5d85932e35ae305dd605912e69f9","6a214b96de92f36f05379f829a80c82d50682e4c@google.com","Add Private types to Python, Haskell","Santi Raffa",true],["6de1d2cf9abbede04689ff621a05f9d7eaedf387","6a214b96de92f36f05379f829a80c82d50682e4c@google.com","serializer.py: emit and encode Private values\n\nFor inbound data the simplest, safest thing to do is to traverse all\nJSON right after encoding and search for private parameters by key.\n\nThis ensures that all consumers of this data get Private values\ntransparently and consistently; the serializing methods don't have to\nworry about trying to understand what kind of JSON it is receiving.\nIt also minimizes the surface area of codebase that is exposed to the\nvalues directly.\n\nThe downside is it adds a ~5% time overhead to all JSON decoding as\nmeasured through:\n\n$ time make hs-test-py_compat_types\n\nAs far as encoding to JSON is concerned, the serializer will redact\nPrivate values unless told to do so explicitly (e.g., for tests).","Santi Raffa",true],["6d2e4ac9a4c0ccdb7461d6253cc4e9927da4fb4a","6a214b96de92f36f05379f829a80c82d50682e4c@google.com","Config: add private OS parameters to the configuration\n\nThis updates objects, constructors and mocks for Instance and Cluster\nobjects in Python and Haskell.","Santi Raffa",true]],"size":33,"ref":"refs/heads/wip-secret-parms","head":"5096e3bf3cff2b7c2e9054d9a2392c9298e992c6"}