GitHub PullRequestReviewCommentEvent at 2014-09-26 17:49:05
Repository: summingbird
Actor: jcoveney
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/twitter/summingbird/pulls/comments/18103381","id":18103381,"diff_hunk":"@@ -0,0 +1,98 @@\n+/*\n+ Copyright 2014 Twitter, Inc.\n+\n+ Licensed under the Apache License, Version 2.0 (the \"License\");\n+ you may not use this file except in compliance with the License.\n+ You may obtain a copy of the License at\n+\n+ http://www.apache.org/licenses/LICENSE-2.0\n+\n+ Unless required by applicable law or agreed to in writing, software\n+ distributed under the License is distributed on an \"AS IS\" BASIS,\n+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ See the License for the specific language governing permissions and\n+ limitations under the License.\n+ */\n+\n+package com.twitter.summingbird.memory\n+\n+import com.twitter.summingbird._\n+import com.twitter.summingbird.option.JobId\n+import java.util.concurrent.ConcurrentHashMap\n+import java.util.concurrent.atomic.AtomicLong\n+\n+/**\n+ * Mutable counter for the Memory platform\n+ */\n+class MemoryCounter {\n+\n+  private var count: AtomicLong = new AtomicLong()\n+\n+  /**\n+   * Increment the counter\n+   * @param by - the amount to increment the counter by\n+   */\n+  def incr(by: Long): Unit = {\n+    val c = count.addAndGet(by)","path":"summingbird-core/src/main/scala/com/twitter/summingbird/memory/MemoryStatProvider.scala","position":36,"original_position":36,"commit_id":"6dd19ed8470858bb90754f3837ff5c26a6bd5f79","original_commit_id":"6dd19ed8470858bb90754f3837ff5c26a6bd5f79","user":{"login":"jcoveney","id":830087,"avatar_url":"https://avatars.githubusercontent.com/u/830087?v=2","gravatar_id":"","url":"https://api.github.com/users/jcoveney","html_url":"https://github.com/jcoveney","followers_url":"https://api.github.com/users/jcoveney/followers","following_url":"https://api.github.com/users/jcoveney/following{/other_user}","gists_url":"https://api.github.com/users/jcoveney/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoveney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoveney/subscriptions","organizations_url":"https://api.github.com/users/jcoveney/orgs","repos_url":"https://api.github.com/users/jcoveney/repos","events_url":"https://api.github.com/users/jcoveney/events{/privacy}","received_events_url":"https://api.github.com/users/jcoveney/received_events","type":"User","site_admin":false},"body":"why do you bother with the val c allocation?","created_at":"2014-09-26T17:49:05Z","updated_at":"2014-09-26T17:49:05Z","html_url":"https://github.com/twitter/summingbird/pull/548#discussion_r18103381","pull_request_url":"https://api.github.com/repos/twitter/summingbird/pulls/548","_links":{"self":{"href":"https://api.github.com/repos/twitter/summingbird/pulls/comments/18103381"},"html":{"href":"https://github.com/twitter/summingbird/pull/548#discussion_r18103381"},"pull_request":{"href":"https://api.github.com/repos/twitter/summingbird/pulls/548"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/summingbird/pulls/548","id":21730169,"html_url":"https://github.com/twitter/summingbird/pull/548","diff_url":"https://github.com/twitter/summingbird/pull/548.diff","patch_url":"https://github.com/twitter/summingbird/pull/548.patch","issue_url":"https://api.github.com/repos/twitter/summingbird/issues/548","number":548,"state":"open","locked":false,"title":"Memory platform counters","user":{"login":"egonina","id":3441503,"avatar_url":"https://avatars.githubusercontent.com/u/3441503?v=2","gravatar_id":"","url":"https://api.github.com/users/egonina","html_url":"https://github.com/egonina","followers_url":"https://api.github.com/users/egonina/followers","following_url":"https://api.github.com/users/egonina/following{/other_user}","gists_url":"https://api.github.com/users/egonina/gists{/gist_id}","starred_url":"https://api.github.com/users/egonina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egonina/subscriptions","organizations_url":"https://api.github.com/users/egonina/orgs","repos_url":"https://api.github.com/users/egonina/repos","events_url":"https://api.github.com/users/egonina/events{/privacy}","received_events_url":"https://api.github.com/users/egonina/received_events","type":"User","site_admin":false},"body":"Adding summingbird counter support for the Memory platform.","created_at":"2014-09-24T17:23:51Z","updated_at":"2014-09-26T17:49:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cc669702a520ed7eee7c506f89037a2580de19b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/summingbird/pulls/548/commits","review_comments_url":"https://api.github.com/repos/twitter/summingbird/pulls/548/comments","review_comment_url":"https://api.github.com/repos/twitter/summingbird/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twitter/summingbird/issues/548/comments","statuses_url":"https://api.github.com/repos/twitter/summingbird/statuses/6dd19ed8470858bb90754f3837ff5c26a6bd5f79","head":{"label":"twitter:memory_platform_counters","ref":"memory_platform_counters","sha":"6dd19ed8470858bb90754f3837ff5c26a6bd5f79","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":5957708,"name":"summingbird","full_name":"twitter/summingbird","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/summingbird","description":"Streaming MapReduce with Scalding and Storm","fork":false,"url":"https://api.github.com/repos/twitter/summingbird","forks_url":"https://api.github.com/repos/twitter/summingbird/forks","keys_url":"https://api.github.com/repos/twitter/summingbird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/summingbird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/summingbird/teams","hooks_url":"https://api.github.com/repos/twitter/summingbird/hooks","issue_events_url":"https://api.github.com/repos/twitter/summingbird/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/summingbird/events","assignees_url":"https://api.github.com/repos/twitter/summingbird/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/summingbird/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/summingbird/tags","blobs_url":"https://api.github.com/repos/twitter/summingbird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/summingbird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/summingbird/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/summingbird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/summingbird/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/summingbird/languages","stargazers_url":"https://api.github.com/repos/twitter/summingbird/stargazers","contributors_url":"https://api.github.com/repos/twitter/summingbird/contributors","subscribers_url":"https://api.github.com/repos/twitter/summingbird/subscribers","subscription_url":"https://api.github.com/repos/twitter/summingbird/subscription","commits_url":"https://api.github.com/repos/twitter/summingbird/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/summingbird/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/summingbird/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/summingbird/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/summingbird/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/summingbird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/summingbird/merges","archive_url":"https://api.github.com/repos/twitter/summingbird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/summingbird/downloads","issues_url":"https://api.github.com/repos/twitter/summingbird/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/summingbird/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/summingbird/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/summingbird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/summingbird/labels{/name}","releases_url":"https://api.github.com/repos/twitter/summingbird/releases{/id}","created_at":"2012-09-25T22:38:35Z","updated_at":"2014-09-25T14:38:33Z","pushed_at":"2014-09-25T23:58:25Z","git_url":"git://github.com/twitter/summingbird.git","ssh_url":"git@github.com:twitter/summingbird.git","clone_url":"https://github.com/twitter/summingbird.git","svn_url":"https://github.com/twitter/summingbird","homepage":"https://twitter.com/summingbird","size":14364,"stargazers_count":1286,"watchers_count":1286,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":167,"mirror_url":null,"open_issues_count":124,"forks":167,"open_issues":124,"watchers":1286,"default_branch":"develop"}},"base":{"label":"twitter:develop","ref":"develop","sha":"0e955e166b828514f9e616b2acbf4c87cb471f22","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":5957708,"name":"summingbird","full_name":"twitter/summingbird","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/summingbird","description":"Streaming MapReduce with Scalding and Storm","fork":false,"url":"https://api.github.com/repos/twitter/summingbird","forks_url":"https://api.github.com/repos/twitter/summingbird/forks","keys_url":"https://api.github.com/repos/twitter/summingbird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/summingbird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/summingbird/teams","hooks_url":"https://api.github.com/repos/twitter/summingbird/hooks","issue_events_url":"https://api.github.com/repos/twitter/summingbird/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/summingbird/events","assignees_url":"https://api.github.com/repos/twitter/summingbird/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/summingbird/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/summingbird/tags","blobs_url":"https://api.github.com/repos/twitter/summingbird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/summingbird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/summingbird/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/summingbird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/summingbird/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/summingbird/languages","stargazers_url":"https://api.github.com/repos/twitter/summingbird/stargazers","contributors_url":"https://api.github.com/repos/twitter/summingbird/contributors","subscribers_url":"https://api.github.com/repos/twitter/summingbird/subscribers","subscription_url":"https://api.github.com/repos/twitter/summingbird/subscription","commits_url":"https://api.github.com/repos/twitter/summingbird/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/summingbird/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/summingbird/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/summingbird/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/summingbird/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/summingbird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/summingbird/merges","archive_url":"https://api.github.com/repos/twitter/summingbird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/summingbird/downloads","issues_url":"https://api.github.com/repos/twitter/summingbird/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/summingbird/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/summingbird/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/summingbird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/summingbird/labels{/name}","releases_url":"https://api.github.com/repos/twitter/summingbird/releases{/id}","created_at":"2012-09-25T22:38:35Z","updated_at":"2014-09-25T14:38:33Z","pushed_at":"2014-09-25T23:58:25Z","git_url":"git://github.com/twitter/summingbird.git","ssh_url":"git@github.com:twitter/summingbird.git","clone_url":"https://github.com/twitter/summingbird.git","svn_url":"https://github.com/twitter/summingbird","homepage":"https://twitter.com/summingbird","size":14364,"stargazers_count":1286,"watchers_count":1286,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":167,"mirror_url":null,"open_issues_count":124,"forks":167,"open_issues":124,"watchers":1286,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/summingbird/pulls/548"},"html":{"href":"https://github.com/twitter/summingbird/pull/548"},"issue":{"href":"https://api.github.com/repos/twitter/summingbird/issues/548"},"comments":{"href":"https://api.github.com/repos/twitter/summingbird/issues/548/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/summingbird/pulls/548/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/summingbird/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twitter/summingbird/pulls/548/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/summingbird/statuses/6dd19ed8470858bb90754f3837ff5c26a6bd5f79"}}}}