GitHub PullRequestEvent at 2014-12-21 12:11:56
Repository: pfsense
Actor: phil-davis
Payload: {"action":"closed","number":1399,"pull_request":{"url":"https://api.github.com/repos/pfsense/pfsense/pulls/1399","id":26425239,"html_url":"https://github.com/pfsense/pfsense/pull/1399","diff_url":"https://github.com/pfsense/pfsense/pull/1399.diff","patch_url":"https://github.com/pfsense/pfsense/pull/1399.patch","issue_url":"https://api.github.com/repos/pfsense/pfsense/issues/1399","number":1399,"state":"closed","locked":false,"title":"Improve Firewall Log widget","user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"body":"1) New firewall log data that is queried by the AJAX each 30 seconds did not have the \"Reverse Resolve with DNS\" link attached to it - do that.\r\n2) Some Java string generation of the HTML was using \"\\/\" sequence, apparently to get a literal \"/\" into the string. That is not necessary, as \"/\" is not a char that needs escaping in Java strings. Actually I am not sure what the \"\\/\" sequence would have done - maybe Jave harmlessly puts a literal \"/\" for this.\r\n3) Original rows that had no destination port still had a \":\" at the end of the IP address (e.g. when the block was for a ping) like \"1.2.3.4:\". Do not put the colon on the end if there is no destination port.\r\n4) An extra hidden blank row had been put at the end of the table. That was making the table size query from JavaScript get 1 bigger than the really displayed rows. This was causing the calculation errors that resulted in rows gradually disappearing from the table on the dashboard (as reported at forum: https://forum.pfsense.org/index.php?topic=85635.0 )\r\n\r\nThere were similar issues when the logs were in reverse mode, skipping table rows rather than losing them. The same fix removing the \"bonus\" table row seems to have fixed the row counting and updating for the time-reversed list also.","created_at":"2014-12-21T07:27:10Z","updated_at":"2014-12-21T12:11:56Z","closed_at":"2014-12-21T12:11:56Z","merged_at":null,"merge_commit_sha":"ece0ccfbb017eecc12fc490713bd6f4d85b607e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pfsense/pfsense/pulls/1399/commits","review_comments_url":"https://api.github.com/repos/pfsense/pfsense/pulls/1399/comments","review_comment_url":"https://api.github.com/repos/pfsense/pfsense/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pfsense/pfsense/issues/1399/comments","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/70bb942e0eaaedfac29c3d4d27f44e151be6669f","head":{"label":"phil-davis:patch-16","ref":"patch-16","sha":"70bb942e0eaaedfac29c3d4d27f44e151be6669f","user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"repo":{"id":27484209,"name":"pfsense","full_name":"phil-davis/pfsense","owner":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phil-davis/pfsense","description":"Main repository for pfSense","fork":true,"url":"https://api.github.com/repos/phil-davis/pfsense","forks_url":"https://api.github.com/repos/phil-davis/pfsense/forks","keys_url":"https://api.github.com/repos/phil-davis/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phil-davis/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phil-davis/pfsense/teams","hooks_url":"https://api.github.com/repos/phil-davis/pfsense/hooks","issue_events_url":"https://api.github.com/repos/phil-davis/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/phil-davis/pfsense/events","assignees_url":"https://api.github.com/repos/phil-davis/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/phil-davis/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/phil-davis/pfsense/tags","blobs_url":"https://api.github.com/repos/phil-davis/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phil-davis/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phil-davis/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/phil-davis/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phil-davis/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/phil-davis/pfsense/languages","stargazers_url":"https://api.github.com/repos/phil-davis/pfsense/stargazers","contributors_url":"https://api.github.com/repos/phil-davis/pfsense/contributors","subscribers_url":"https://api.github.com/repos/phil-davis/pfsense/subscribers","subscription_url":"https://api.github.com/repos/phil-davis/pfsense/subscription","commits_url":"https://api.github.com/repos/phil-davis/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/phil-davis/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/phil-davis/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/phil-davis/pfsense/issues/comments/{number}","contents_url":"https://api.github.com/repos/phil-davis/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/phil-davis/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phil-davis/pfsense/merges","archive_url":"https://api.github.com/repos/phil-davis/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phil-davis/pfsense/downloads","issues_url":"https://api.github.com/repos/phil-davis/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/phil-davis/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/phil-davis/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/phil-davis/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phil-davis/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/phil-davis/pfsense/releases{/id}","created_at":"2014-12-03T11:38:33Z","updated_at":"2014-12-03T11:38:39Z","pushed_at":"2014-12-21T12:03:36Z","git_url":"git://github.com/phil-davis/pfsense.git","ssh_url":"git@github.com:phil-davis/pfsense.git","clone_url":"https://github.com/phil-davis/pfsense.git","svn_url":"https://github.com/phil-davis/pfsense","homepage":"http://www.pfsense.org","size":52114,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pfsense:master","ref":"master","sha":"5b4ed0e1dbef72c42c0760e9c2bc02575b4d57ad","user":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"repo":{"id":1740040,"name":"pfsense","full_name":"pfsense/pfsense","owner":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pfsense/pfsense","description":"Main repository for pfSense","fork":false,"url":"https://api.github.com/repos/pfsense/pfsense","forks_url":"https://api.github.com/repos/pfsense/pfsense/forks","keys_url":"https://api.github.com/repos/pfsense/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfsense/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfsense/pfsense/teams","hooks_url":"https://api.github.com/repos/pfsense/pfsense/hooks","issue_events_url":"https://api.github.com/repos/pfsense/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/pfsense/pfsense/events","assignees_url":"https://api.github.com/repos/pfsense/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/pfsense/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/pfsense/pfsense/tags","blobs_url":"https://api.github.com/repos/pfsense/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfsense/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfsense/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfsense/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/pfsense/pfsense/languages","stargazers_url":"https://api.github.com/repos/pfsense/pfsense/stargazers","contributors_url":"https://api.github.com/repos/pfsense/pfsense/contributors","subscribers_url":"https://api.github.com/repos/pfsense/pfsense/subscribers","subscription_url":"https://api.github.com/repos/pfsense/pfsense/subscription","commits_url":"https://api.github.com/repos/pfsense/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfsense/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfsense/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfsense/pfsense/issues/comments/{number}","contents_url":"https://api.github.com/repos/pfsense/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/pfsense/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfsense/pfsense/merges","archive_url":"https://api.github.com/repos/pfsense/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfsense/pfsense/downloads","issues_url":"https://api.github.com/repos/pfsense/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/pfsense/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/pfsense/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/pfsense/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfsense/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/pfsense/pfsense/releases{/id}","created_at":"2011-05-12T19:44:21Z","updated_at":"2014-12-20T02:01:58Z","pushed_at":"2014-12-20T02:01:58Z","git_url":"git://github.com/pfsense/pfsense.git","ssh_url":"git@github.com:pfsense/pfsense.git","clone_url":"https://github.com/pfsense/pfsense.git","svn_url":"https://github.com/pfsense/pfsense","homepage":"http://www.pfsense.org","size":79087,"stargazers_count":460,"watchers_count":460,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":296,"mirror_url":null,"open_issues_count":38,"forks":296,"open_issues":38,"watchers":460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1399"},"html":{"href":"https://github.com/pfsense/pfsense/pull/1399"},"issue":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/1399"},"comments":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/1399/comments"},"review_comments":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1399/comments"},"review_comment":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1399/commits"},"statuses":{"href":"https://api.github.com/repos/pfsense/pfsense/statuses/70bb942e0eaaedfac29c3d4d27f44e151be6669f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":13,"deletions":7,"changed_files":1}}