GitHub PullRequestReviewCommentEvent at 2014-08-13 21:06:06
Repository: core
Actor: LukasReschke
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/16205795","id":16205795,"diff_hunk":"@@ -5,35 +5,38 @@\n  * See the COPYING-README file.\n  */\n \n+use OC\\Log\\Owncloud;\n+\n OC_Util::checkAdminUser();\n \n-OC_Util::addStyle( \"settings\", \"settings\" );\n-OC_Util::addScript( \"settings\", \"admin\" );\n-OC_Util::addScript( \"settings\", \"log\" );\n-OC_Util::addScript( 'core', 'multiselect' );\n-OC_App::setActiveNavigationEntry( \"admin\" );\n+OC_Util::addStyle(\"settings\", \"settings\");\n+OC_Util::addScript(\"settings\", \"admin\");\n+OC_Util::addScript(\"settings\", \"log\");\n+OC_Util::addScript('core', 'multiselect');\n+OC_App::setActiveNavigationEntry(\"admin\");\n \n-$tmpl = new OC_Template( 'settings', 'admin', 'user');\n-$forms=OC_App::getForms('admin');\n-$htaccessworking=OC_Util::isHtaccessWorking();\n+$tmpl = new OC_Template('settings', 'admin', 'user');\n+$forms = OC_App::getForms('admin');\n+$htaccessworking = OC_Util::isHtaccessWorking();\n \n-$entries=OC_Log_Owncloud::getEntries(3);\n-$entriesremain = count(OC_Log_Owncloud::getEntries(4)) > 3;\n+$log = new Owncloud();\n+$entries = $log->getEntries(3);\n+$entriesremain = count($log->getEntries(4)) > 3;\n \n // Should we display sendmail as an option?\n-$tmpl->assign('sendmail_is_available', (bool) findBinaryPath('sendmail'));\n+$tmpl->assign('sendmail_is_available', (bool)findBinaryPath('sendmail'));\n \n-$tmpl->assign('loglevel', OC_Config::getValue( \"loglevel\", 2 ));\n-$tmpl->assign('mail_domain', OC_Config::getValue( \"mail_domain\", '' ));\n-$tmpl->assign('mail_from_address', OC_Config::getValue( \"mail_from_address\", '' ));\n-$tmpl->assign('mail_smtpmode', OC_Config::getValue( \"mail_smtpmode\", '' ));\n-$tmpl->assign('mail_smtpsecure', OC_Config::getValue( \"mail_smtpsecure\", '' ));\n-$tmpl->assign('mail_smtphost', OC_Config::getValue( \"mail_smtphost\", '' ));\n-$tmpl->assign('mail_smtpport', OC_Config::getValue( \"mail_smtpport\", '' ));\n-$tmpl->assign('mail_smtpauthtype', OC_Config::getValue( \"mail_smtpauthtype\", '' ));\n-$tmpl->assign('mail_smtpauth', OC_Config::getValue( \"mail_smtpauth\", false ));\n-$tmpl->assign('mail_smtpname', OC_Config::getValue( \"mail_smtpname\", '' ));\n-$tmpl->assign('mail_smtppassword', OC_Config::getValue( \"mail_smtppassword\", '' ));\n+$tmpl->assign('loglevel', OC_Config::getValue(\"loglevel\", 2));","path":"settings/admin.php","position":47,"original_position":47,"commit_id":"2faf770bccb7cd2fab2eeac53905594a9b298295","original_commit_id":"2faf770bccb7cd2fab2eeac53905594a9b298295","user":{"login":"LukasReschke","id":878997,"avatar_url":"https://avatars.githubusercontent.com/u/878997?v=2","gravatar_id":"f080e75d370a4d8e550983a4898bcf3b","url":"https://api.github.com/users/LukasReschke","html_url":"https://github.com/LukasReschke","followers_url":"https://api.github.com/users/LukasReschke/followers","following_url":"https://api.github.com/users/LukasReschke/following{/other_user}","gists_url":"https://api.github.com/users/LukasReschke/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasReschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasReschke/subscriptions","organizations_url":"https://api.github.com/users/LukasReschke/orgs","repos_url":"https://api.github.com/users/LukasReschke/repos","events_url":"https://api.github.com/users/LukasReschke/events{/privacy}","received_events_url":"https://api.github.com/users/LukasReschke/received_events","type":"User","site_admin":false},"body":"If we change the loglevels this won't work. If we won't change it: fine.","created_at":"2014-08-13T21:06:06Z","updated_at":"2014-08-13T21:06:06Z","html_url":"https://github.com/owncloud/core/pull/10405#discussion_r16205795","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/10405","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/16205795"},"html":{"href":"https://github.com/owncloud/core/pull/10405#discussion_r16205795"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/10405"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/10405","id":19749987,"html_url":"https://github.com/owncloud/core/pull/10405","diff_url":"https://github.com/owncloud/core/pull/10405.diff","patch_url":"https://github.com/owncloud/core/pull/10405.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/10405","number":10405,"state":"open","locked":false,"title":"Adding monolog","user":{"login":"th3fallen","id":291859,"avatar_url":"https://avatars.githubusercontent.com/u/291859?v=2","gravatar_id":"5f077a7fb353970890ace872c8377fbe","url":"https://api.github.com/users/th3fallen","html_url":"https://github.com/th3fallen","followers_url":"https://api.github.com/users/th3fallen/followers","following_url":"https://api.github.com/users/th3fallen/following{/other_user}","gists_url":"https://api.github.com/users/th3fallen/gists{/gist_id}","starred_url":"https://api.github.com/users/th3fallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/th3fallen/subscriptions","organizations_url":"https://api.github.com/users/th3fallen/orgs","repos_url":"https://api.github.com/users/th3fallen/repos","events_url":"https://api.github.com/users/th3fallen/events{/privacy}","received_events_url":"https://api.github.com/users/th3fallen/received_events","type":"User","site_admin":false},"body":"Fixes:\r\nhttps://github.com/owncloud/core/issues/8956\r\nhttps://github.com/owncloud/core/issues/9083\r\n\r\nAdding Monolog to replace exisiting logging methods which adds much more robust functionality with very little alterations to current work flow\r\n\r\nChanges to current workflow:\r\nLogLevels have changed by 100\r\nFormat of log has slightly changed.\r\n\r\n\r\nAlso see https://github.com/owncloud/3rdparty/pull/114","created_at":"2014-08-13T20:17:37Z","updated_at":"2014-08-13T21:06:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a4bbd86bf230cc19dd6ce9703a4aa5c5e7fa688","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/core/pulls/10405/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/10405/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/10405/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/2faf770bccb7cd2fab2eeac53905594a9b298295","head":{"label":"owncloud:adding-monolog","ref":"adding-monolog","sha":"2faf770bccb7cd2fab2eeac53905594a9b298295","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=2","gravatar_id":"021e207e86fe81a7d81c67ef1ff38a0c","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=2","gravatar_id":"021e207e86fe81a7d81c67ef1ff38a0c","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments/{number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2014-08-13T17:28:10Z","pushed_at":"2014-08-13T20:59:40Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":null,"size":639028,"stargazers_count":2442,"watchers_count":2442,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":810,"mirror_url":null,"open_issues_count":1276,"forks":810,"open_issues":1276,"watchers":2442,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"2c8aa3751c6e0dab2439fee98cd173d579caed76","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=2","gravatar_id":"021e207e86fe81a7d81c67ef1ff38a0c","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=2","gravatar_id":"021e207e86fe81a7d81c67ef1ff38a0c","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments/{number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2014-08-13T17:28:10Z","pushed_at":"2014-08-13T20:59:40Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":null,"size":639028,"stargazers_count":2442,"watchers_count":2442,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":810,"mirror_url":null,"open_issues_count":1276,"forks":810,"open_issues":1276,"watchers":2442,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/10405"},"html":{"href":"https://github.com/owncloud/core/pull/10405"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/10405"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/10405/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/10405/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/10405/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/2faf770bccb7cd2fab2eeac53905594a9b298295"}}}}