GitHub PullRequestReviewCommentEvent at 2014-11-04 18:32:53
Repository: bootstrap
Actor: chrisirhc
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/19824155","id":19824155,"diff_hunk":"@@ -106,22 +106,22 @@ angular.module('ui.bootstrap.carousel', ['ui.bootstrap.transition'])\n   function restartTimer() {\n     resetTimer();\n     var interval = +$scope.interval;\n-    if (!isNaN(interval) && interval>=0) {\n-      currentTimeout = $timeout(timerFn, interval);\n+    if (!isNaN(interval) && interval>=0)  {","path":"src/carousel/carousel.js","position":20,"original_position":20,"commit_id":"683e48848928a8aa2f2e14e52842a48bf51b2cc6","original_commit_id":"683e48848928a8aa2f2e14e52842a48bf51b2cc6","user":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=2","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"body":"Firstly, there's an extra space on the right, right before the opening brace.\r\n\r\nSecondly, this also needs to do `interval > 0` now since $interval(fn, 0) creates an infinite loop.","created_at":"2014-11-04T18:32:53Z","updated_at":"2014-11-04T18:32:53Z","html_url":"https://github.com/angular-ui/bootstrap/pull/2776#discussion_r19824155","pull_request_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2776","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/19824155"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/2776#discussion_r19824155"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2776"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2776","id":22164146,"html_url":"https://github.com/angular-ui/bootstrap/pull/2776","diff_url":"https://github.com/angular-ui/bootstrap/pull/2776.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/2776.patch","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/2776","number":2776,"state":"open","locked":false,"title":"fix(carousel): replaced $timeout with $interval when it was wrong","user":{"login":"Gahen","id":1663320,"avatar_url":"https://avatars.githubusercontent.com/u/1663320?v=2","gravatar_id":"","url":"https://api.github.com/users/Gahen","html_url":"https://github.com/Gahen","followers_url":"https://api.github.com/users/Gahen/followers","following_url":"https://api.github.com/users/Gahen/following{/other_user}","gists_url":"https://api.github.com/users/Gahen/gists{/gist_id}","starred_url":"https://api.github.com/users/Gahen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gahen/subscriptions","organizations_url":"https://api.github.com/users/Gahen/orgs","repos_url":"https://api.github.com/users/Gahen/repos","events_url":"https://api.github.com/users/Gahen/events{/privacy}","received_events_url":"https://api.github.com/users/Gahen/received_events","type":"User","site_admin":false},"body":"I had a to tweak a bit two tests since $interval never throws an exception after flushing, hope I did it OK. \r\n\r\nThis addresses #2454","created_at":"2014-10-02T19:30:37Z","updated_at":"2014-11-04T18:32:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dd14085bce4eec544e8b72165887fd3d5f68c0d","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/13","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/13/labels","id":651502,"number":13,"title":"0.12","description":"Milestone for release 0.12","creator":{"login":"Foxandxss","id":1087957,"avatar_url":"https://avatars.githubusercontent.com/u/1087957?v=2","gravatar_id":"","url":"https://api.github.com/users/Foxandxss","html_url":"https://github.com/Foxandxss","followers_url":"https://api.github.com/users/Foxandxss/followers","following_url":"https://api.github.com/users/Foxandxss/following{/other_user}","gists_url":"https://api.github.com/users/Foxandxss/gists{/gist_id}","starred_url":"https://api.github.com/users/Foxandxss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foxandxss/subscriptions","organizations_url":"https://api.github.com/users/Foxandxss/orgs","repos_url":"https://api.github.com/users/Foxandxss/repos","events_url":"https://api.github.com/users/Foxandxss/events{/privacy}","received_events_url":"https://api.github.com/users/Foxandxss/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":2,"state":"open","created_at":"2014-05-07T10:33:17Z","updated_at":"2014-11-03T10:25:15Z","due_on":"2014-11-16T08:00:00Z"},"commits_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2776/commits","review_comments_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2776/comments","review_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/2776/comments","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/683e48848928a8aa2f2e14e52842a48bf51b2cc6","head":{"label":"Gahen:master","ref":"master","sha":"683e48848928a8aa2f2e14e52842a48bf51b2cc6","user":{"login":"Gahen","id":1663320,"avatar_url":"https://avatars.githubusercontent.com/u/1663320?v=2","gravatar_id":"","url":"https://api.github.com/users/Gahen","html_url":"https://github.com/Gahen","followers_url":"https://api.github.com/users/Gahen/followers","following_url":"https://api.github.com/users/Gahen/following{/other_user}","gists_url":"https://api.github.com/users/Gahen/gists{/gist_id}","starred_url":"https://api.github.com/users/Gahen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gahen/subscriptions","organizations_url":"https://api.github.com/users/Gahen/orgs","repos_url":"https://api.github.com/users/Gahen/repos","events_url":"https://api.github.com/users/Gahen/events{/privacy}","received_events_url":"https://api.github.com/users/Gahen/received_events","type":"User","site_admin":false},"repo":{"id":24696100,"name":"bootstrap","full_name":"Gahen/bootstrap","owner":{"login":"Gahen","id":1663320,"avatar_url":"https://avatars.githubusercontent.com/u/1663320?v=2","gravatar_id":"","url":"https://api.github.com/users/Gahen","html_url":"https://github.com/Gahen","followers_url":"https://api.github.com/users/Gahen/followers","following_url":"https://api.github.com/users/Gahen/following{/other_user}","gists_url":"https://api.github.com/users/Gahen/gists{/gist_id}","starred_url":"https://api.github.com/users/Gahen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gahen/subscriptions","organizations_url":"https://api.github.com/users/Gahen/orgs","repos_url":"https://api.github.com/users/Gahen/repos","events_url":"https://api.github.com/users/Gahen/events{/privacy}","received_events_url":"https://api.github.com/users/Gahen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gahen/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Small footprint (5kB gzipped!), no 3rd party JS dependencies (jQuery, bootstrap JS) required!","fork":true,"url":"https://api.github.com/repos/Gahen/bootstrap","forks_url":"https://api.github.com/repos/Gahen/bootstrap/forks","keys_url":"https://api.github.com/repos/Gahen/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gahen/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gahen/bootstrap/teams","hooks_url":"https://api.github.com/repos/Gahen/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/Gahen/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/Gahen/bootstrap/events","assignees_url":"https://api.github.com/repos/Gahen/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/Gahen/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/Gahen/bootstrap/tags","blobs_url":"https://api.github.com/repos/Gahen/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gahen/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gahen/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gahen/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gahen/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/Gahen/bootstrap/languages","stargazers_url":"https://api.github.com/repos/Gahen/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/Gahen/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/Gahen/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/Gahen/bootstrap/subscription","commits_url":"https://api.github.com/repos/Gahen/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gahen/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gahen/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gahen/bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/Gahen/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/Gahen/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gahen/bootstrap/merges","archive_url":"https://api.github.com/repos/Gahen/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gahen/bootstrap/downloads","issues_url":"https://api.github.com/repos/Gahen/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/Gahen/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/Gahen/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/Gahen/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gahen/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/Gahen/bootstrap/releases{/id}","created_at":"2014-10-01T21:27:34Z","updated_at":"2014-10-02T19:26:56Z","pushed_at":"2014-11-04T14:43:54Z","git_url":"git://github.com/Gahen/bootstrap.git","ssh_url":"git@github.com:Gahen/bootstrap.git","clone_url":"https://github.com/Gahen/bootstrap.git","svn_url":"https://github.com/Gahen/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":3418,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"5df524b77114bccdc9a49540e1eb52a564ee5dfd","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=2","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6094683,"name":"bootstrap","full_name":"angular-ui/bootstrap","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=2","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Small footprint (5kB gzipped!), no 3rd party JS dependencies (jQuery, bootstrap JS) required!","fork":false,"url":"https://api.github.com/repos/angular-ui/bootstrap","forks_url":"https://api.github.com/repos/angular-ui/bootstrap/forks","keys_url":"https://api.github.com/repos/angular-ui/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/bootstrap/teams","hooks_url":"https://api.github.com/repos/angular-ui/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/bootstrap/events","assignees_url":"https://api.github.com/repos/angular-ui/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/bootstrap/tags","blobs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/bootstrap/languages","stargazers_url":"https://api.github.com/repos/angular-ui/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/bootstrap/subscription","commits_url":"https://api.github.com/repos/angular-ui/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular-ui/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/bootstrap/merges","archive_url":"https://api.github.com/repos/angular-ui/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/bootstrap/downloads","issues_url":"https://api.github.com/repos/angular-ui/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/bootstrap/releases{/id}","created_at":"2012-10-05T18:27:01Z","updated_at":"2014-11-04T17:20:42Z","pushed_at":"2014-11-03T10:24:52Z","git_url":"git://github.com/angular-ui/bootstrap.git","ssh_url":"git@github.com:angular-ui/bootstrap.git","clone_url":"https://github.com/angular-ui/bootstrap.git","svn_url":"https://github.com/angular-ui/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":20261,"stargazers_count":6747,"watchers_count":6747,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3684,"mirror_url":null,"open_issues_count":523,"forks":3684,"open_issues":523,"watchers":6747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2776"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/2776"},"issue":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/2776"},"comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/2776/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2776/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2776/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/bootstrap/statuses/683e48848928a8aa2f2e14e52842a48bf51b2cc6"}}}}