GitHub PullRequestReviewCommentEvent at 2014-06-12 22:41:31
Repository: druid-api
Actor: gianm
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid-api/pulls/comments/13731047","id":13731047,"diff_hunk":"@@ -101,25 +105,22 @@ public StringInputRowParser withParseSpec(ParseSpec parseSpec)\n         chars.clear();\n       }\n     } else {\n-      throw new FormattedException.Builder()\n-          .withErrorCode(FormattedException.ErrorCode.UNPARSABLE_ROW)\n-          .withMessage(String.format(\"Failed with CoderResult[%s]\", coderResult))\n-          .build();\n+      throw new IAE(\"Failed with CoderResult[%s]\", coderResult);","path":"src/main/java/io/druid/data/input/impl/StringInputRowParser.java","position":74,"original_position":74,"commit_id":"b73f893dffdd629d3a07970d7c6a262836f6df50","original_commit_id":"b73f893dffdd629d3a07970d7c6a262836f6df50","user":{"login":"gianm","id":1214075,"avatar_url":"https://avatars.githubusercontent.com/u/1214075?","gravatar_id":"1913a548e9db93a970aef9faca37b339","url":"https://api.github.com/users/gianm","html_url":"https://github.com/gianm","followers_url":"https://api.github.com/users/gianm/followers","following_url":"https://api.github.com/users/gianm/following{/other_user}","gists_url":"https://api.github.com/users/gianm/gists{/gist_id}","starred_url":"https://api.github.com/users/gianm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianm/subscriptions","organizations_url":"https://api.github.com/users/gianm/orgs","repos_url":"https://api.github.com/users/gianm/repos","events_url":"https://api.github.com/users/gianm/events{/privacy}","received_events_url":"https://api.github.com/users/gianm/received_events","type":"User","site_admin":false},"body":"Should be ParseException I think, since this comes from bad UTF-8 encoding","created_at":"2014-06-12T22:41:31Z","updated_at":"2014-06-12T22:41:31Z","html_url":"https://github.com/druid-io/druid-api/pull/13#discussion_r13731047","pull_request_url":"https://api.github.com/repos/druid-io/druid-api/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid-api/pulls/comments/13731047"},"html":{"href":"https://github.com/druid-io/druid-api/pull/13#discussion_r13731047"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid-api/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid-api/pulls/13","id":16630669,"html_url":"https://github.com/druid-io/druid-api/pull/13","diff_url":"https://github.com/druid-io/druid-api/pull/13.diff","patch_url":"https://github.com/druid-io/druid-api/pull/13.patch","issue_url":"https://api.github.com/repos/druid-io/druid-api/issues/13","number":13,"state":"open","title":"Support new java util","user":{"login":"fjy","id":428325,"avatar_url":"https://avatars.githubusercontent.com/u/428325?","gravatar_id":"c3699a7fcecac4d30dc875e20355da69","url":"https://api.github.com/users/fjy","html_url":"https://github.com/fjy","followers_url":"https://api.github.com/users/fjy/followers","following_url":"https://api.github.com/users/fjy/following{/other_user}","gists_url":"https://api.github.com/users/fjy/gists{/gist_id}","starred_url":"https://api.github.com/users/fjy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjy/subscriptions","organizations_url":"https://api.github.com/users/fjy/orgs","repos_url":"https://api.github.com/users/fjy/repos","events_url":"https://api.github.com/users/fjy/events{/privacy}","received_events_url":"https://api.github.com/users/fjy/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-03T00:50:19Z","updated_at":"2014-06-12T22:41:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a774a15715cee723145ed30c024551538b5f57a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid-api/pulls/13/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid-api/pulls/13/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid-api/pulls/comments/{number}","comments_url":"https://api.github.com/repos/druid-io/druid-api/issues/13/comments","statuses_url":"https://api.github.com/repos/druid-io/druid-api/statuses/b73f893dffdd629d3a07970d7c6a262836f6df50","head":{"label":"druid-io:new-java-util","ref":"new-java-util","sha":"b73f893dffdd629d3a07970d7c6a262836f6df50","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?","gravatar_id":null,"url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":12418525,"name":"druid-api","full_name":"druid-io/druid-api","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?","gravatar_id":null,"url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid-api","description":"A repository for the Druid API.  This is a separate library that defines the APIs for Druid extensibility ","fork":false,"url":"https://api.github.com/repos/druid-io/druid-api","forks_url":"https://api.github.com/repos/druid-io/druid-api/forks","keys_url":"https://api.github.com/repos/druid-io/druid-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid-api/teams","hooks_url":"https://api.github.com/repos/druid-io/druid-api/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid-api/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid-api/events","assignees_url":"https://api.github.com/repos/druid-io/druid-api/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid-api/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid-api/tags","blobs_url":"https://api.github.com/repos/druid-io/druid-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid-api/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid-api/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid-api/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid-api/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid-api/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid-api/subscription","commits_url":"https://api.github.com/repos/druid-io/druid-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid-api/issues/comments/{number}","contents_url":"https://api.github.com/repos/druid-io/druid-api/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid-api/merges","archive_url":"https://api.github.com/repos/druid-io/druid-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid-api/downloads","issues_url":"https://api.github.com/repos/druid-io/druid-api/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid-api/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid-api/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid-api/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid-api/releases{/id}","created_at":"2013-08-27T21:58:45Z","updated_at":"2014-06-12T21:53:04Z","pushed_at":"2014-06-12T21:53:04Z","git_url":"git://github.com/druid-io/druid-api.git","ssh_url":"git@github.com:druid-io/druid-api.git","clone_url":"https://github.com/druid-io/druid-api.git","svn_url":"https://github.com/druid-io/druid-api","homepage":null,"size":961,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"87391e9959f11fda18c1816097604a61e5614a66","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?","gravatar_id":null,"url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":12418525,"name":"druid-api","full_name":"druid-io/druid-api","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?","gravatar_id":null,"url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid-api","description":"A repository for the Druid API.  This is a separate library that defines the APIs for Druid extensibility ","fork":false,"url":"https://api.github.com/repos/druid-io/druid-api","forks_url":"https://api.github.com/repos/druid-io/druid-api/forks","keys_url":"https://api.github.com/repos/druid-io/druid-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid-api/teams","hooks_url":"https://api.github.com/repos/druid-io/druid-api/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid-api/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid-api/events","assignees_url":"https://api.github.com/repos/druid-io/druid-api/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid-api/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid-api/tags","blobs_url":"https://api.github.com/repos/druid-io/druid-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid-api/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid-api/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid-api/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid-api/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid-api/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid-api/subscription","commits_url":"https://api.github.com/repos/druid-io/druid-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid-api/issues/comments/{number}","contents_url":"https://api.github.com/repos/druid-io/druid-api/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid-api/merges","archive_url":"https://api.github.com/repos/druid-io/druid-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid-api/downloads","issues_url":"https://api.github.com/repos/druid-io/druid-api/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid-api/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid-api/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid-api/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid-api/releases{/id}","created_at":"2013-08-27T21:58:45Z","updated_at":"2014-06-12T21:53:04Z","pushed_at":"2014-06-12T21:53:04Z","git_url":"git://github.com/druid-io/druid-api.git","ssh_url":"git@github.com:druid-io/druid-api.git","clone_url":"https://github.com/druid-io/druid-api.git","svn_url":"https://github.com/druid-io/druid-api","homepage":null,"size":961,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid-api/pulls/13"},"html":{"href":"https://github.com/druid-io/druid-api/pull/13"},"issue":{"href":"https://api.github.com/repos/druid-io/druid-api/issues/13"},"comments":{"href":"https://api.github.com/repos/druid-io/druid-api/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid-api/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid-api/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid-api/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid-api/statuses/b73f893dffdd629d3a07970d7c6a262836f6df50"}}}}