GitHub PullRequestEvent at 2014-06-11 02:22:36
Repository: decrypt-windows-ec2-passwd
Actor: tomrittervg
Payload: {"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/pulls/6","id":16921290,"html_url":"https://github.com/tomrittervg/decrypt-windows-ec2-passwd/pull/6","diff_url":"https://github.com/tomrittervg/decrypt-windows-ec2-passwd/pull/6.diff","patch_url":"https://github.com/tomrittervg/decrypt-windows-ec2-passwd/pull/6.patch","issue_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/issues/6","number":6,"state":"closed","title":"Don't swallow the underlying decrypt error","user":{"login":"ringerc","id":274337,"avatar_url":"https://avatars.githubusercontent.com/u/274337?","gravatar_id":"85f50c23bb5e9dfb061af5032bfe8e65","url":"https://api.github.com/users/ringerc","html_url":"https://github.com/ringerc","followers_url":"https://api.github.com/users/ringerc/followers","following_url":"https://api.github.com/users/ringerc/following{/other_user}","gists_url":"https://api.github.com/users/ringerc/gists{/gist_id}","starred_url":"https://api.github.com/users/ringerc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringerc/subscriptions","organizations_url":"https://api.github.com/users/ringerc/orgs","repos_url":"https://api.github.com/users/ringerc/repos","events_url":"https://api.github.com/users/ringerc/events{/privacy}","received_events_url":"https://api.github.com/users/ringerc/received_events","type":"User","site_admin":false},"body":"If key decryption fails, an error like:\r\n\r\n    Could not import SSH Key (Is it an RSA key? Is it password protected?)\r\n\r\nis produced. It doesn't contain any info about what actually went wrong in decryption; the exception is swallowed.\r\n\r\nInstead, report the real exception afterwards:\r\n\r\n    Could not import SSH Key (Is it an RSA key? Is it password protected?): Unsupport PEM encryption algorithm.","created_at":"2014-06-10T04:06:03Z","updated_at":"2014-06-11T02:22:36Z","closed_at":"2014-06-11T02:22:36Z","merged_at":"2014-06-11T02:22:36Z","merge_commit_sha":"16bbea0337ae87005d834bf09bfbf5be7e8a4b0f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/pulls/6/commits","review_comments_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/pulls/6/comments","review_comment_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/issues/6/comments","statuses_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/statuses/18d66a1325e9c8825c4b33ea5438fe0ec8fcab33","head":{"label":"ringerc:patch-1","ref":"patch-1","sha":"18d66a1325e9c8825c4b33ea5438fe0ec8fcab33","user":{"login":"ringerc","id":274337,"avatar_url":"https://avatars.githubusercontent.com/u/274337?","gravatar_id":"85f50c23bb5e9dfb061af5032bfe8e65","url":"https://api.github.com/users/ringerc","html_url":"https://github.com/ringerc","followers_url":"https://api.github.com/users/ringerc/followers","following_url":"https://api.github.com/users/ringerc/following{/other_user}","gists_url":"https://api.github.com/users/ringerc/gists{/gist_id}","starred_url":"https://api.github.com/users/ringerc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringerc/subscriptions","organizations_url":"https://api.github.com/users/ringerc/orgs","repos_url":"https://api.github.com/users/ringerc/repos","events_url":"https://api.github.com/users/ringerc/events{/privacy}","received_events_url":"https://api.github.com/users/ringerc/received_events","type":"User","site_admin":false},"repo":{"id":20671905,"name":"decrypt-windows-ec2-passwd","full_name":"ringerc/decrypt-windows-ec2-passwd","owner":{"login":"ringerc","id":274337,"avatar_url":"https://avatars.githubusercontent.com/u/274337?","gravatar_id":"85f50c23bb5e9dfb061af5032bfe8e65","url":"https://api.github.com/users/ringerc","html_url":"https://github.com/ringerc","followers_url":"https://api.github.com/users/ringerc/followers","following_url":"https://api.github.com/users/ringerc/following{/other_user}","gists_url":"https://api.github.com/users/ringerc/gists{/gist_id}","starred_url":"https://api.github.com/users/ringerc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringerc/subscriptions","organizations_url":"https://api.github.com/users/ringerc/orgs","repos_url":"https://api.github.com/users/ringerc/repos","events_url":"https://api.github.com/users/ringerc/events{/privacy}","received_events_url":"https://api.github.com/users/ringerc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ringerc/decrypt-windows-ec2-passwd","description":"Amazon EC2 Windows Instances require you to paste in your SSH private key to decrypt the password to the instance. Although they do the decryption locally, in Javascript, I'd still prevent to do it locally... not trusting Amazon.","fork":true,"url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd","forks_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/forks","keys_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/teams","hooks_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/hooks","issue_events_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/issues/events{/number}","events_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/events","assignees_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/assignees{/user}","branches_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/branches{/branch}","tags_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/tags","blobs_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/statuses/{sha}","languages_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/languages","stargazers_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/stargazers","contributors_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/contributors","subscribers_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/subscribers","subscription_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/subscription","commits_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/issues/comments/{number}","contents_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/contents/{+path}","compare_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/merges","archive_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/downloads","issues_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/issues{/number}","pulls_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/pulls{/number}","milestones_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/milestones{/number}","notifications_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/labels{/name}","releases_url":"https://api.github.com/repos/ringerc/decrypt-windows-ec2-passwd/releases{/id}","created_at":"2014-06-10T04:04:07Z","updated_at":"2014-06-11T02:22:36Z","pushed_at":"2014-06-10T04:05:25Z","git_url":"git://github.com/ringerc/decrypt-windows-ec2-passwd.git","ssh_url":"git@github.com:ringerc/decrypt-windows-ec2-passwd.git","clone_url":"https://github.com/ringerc/decrypt-windows-ec2-passwd.git","svn_url":"https://github.com/ringerc/decrypt-windows-ec2-passwd","homepage":null,"size":120,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tomrittervg:master","ref":"master","sha":"6f2451758451587e6e5b5c9c7738e14557e0ed14","user":{"login":"tomrittervg","id":163497,"avatar_url":"https://avatars.githubusercontent.com/u/163497?","gravatar_id":"31e32ecb7309ad47e1ecdd34f4c26529","url":"https://api.github.com/users/tomrittervg","html_url":"https://github.com/tomrittervg","followers_url":"https://api.github.com/users/tomrittervg/followers","following_url":"https://api.github.com/users/tomrittervg/following{/other_user}","gists_url":"https://api.github.com/users/tomrittervg/gists{/gist_id}","starred_url":"https://api.github.com/users/tomrittervg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomrittervg/subscriptions","organizations_url":"https://api.github.com/users/tomrittervg/orgs","repos_url":"https://api.github.com/users/tomrittervg/repos","events_url":"https://api.github.com/users/tomrittervg/events{/privacy}","received_events_url":"https://api.github.com/users/tomrittervg/received_events","type":"User","site_admin":false},"repo":{"id":8544558,"name":"decrypt-windows-ec2-passwd","full_name":"tomrittervg/decrypt-windows-ec2-passwd","owner":{"login":"tomrittervg","id":163497,"avatar_url":"https://avatars.githubusercontent.com/u/163497?","gravatar_id":"31e32ecb7309ad47e1ecdd34f4c26529","url":"https://api.github.com/users/tomrittervg","html_url":"https://github.com/tomrittervg","followers_url":"https://api.github.com/users/tomrittervg/followers","following_url":"https://api.github.com/users/tomrittervg/following{/other_user}","gists_url":"https://api.github.com/users/tomrittervg/gists{/gist_id}","starred_url":"https://api.github.com/users/tomrittervg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomrittervg/subscriptions","organizations_url":"https://api.github.com/users/tomrittervg/orgs","repos_url":"https://api.github.com/users/tomrittervg/repos","events_url":"https://api.github.com/users/tomrittervg/events{/privacy}","received_events_url":"https://api.github.com/users/tomrittervg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomrittervg/decrypt-windows-ec2-passwd","description":"Amazon EC2 Windows Instances require you to paste in your SSH private key to decrypt the password to the instance. Although they do the decryption locally, in Javascript, I'd still prevent to do it locally... not trusting Amazon.","fork":false,"url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd","forks_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/forks","keys_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/teams","hooks_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/hooks","issue_events_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/issues/events{/number}","events_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/events","assignees_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/assignees{/user}","branches_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/branches{/branch}","tags_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/tags","blobs_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/statuses/{sha}","languages_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/languages","stargazers_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/stargazers","contributors_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/contributors","subscribers_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/subscribers","subscription_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/subscription","commits_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/issues/comments/{number}","contents_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/contents/{+path}","compare_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/merges","archive_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/downloads","issues_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/issues{/number}","pulls_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/pulls{/number}","milestones_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/milestones{/number}","notifications_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/labels{/name}","releases_url":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/releases{/id}","created_at":"2013-03-03T23:38:49Z","updated_at":"2014-06-11T02:22:36Z","pushed_at":"2014-06-11T02:22:36Z","git_url":"git://github.com/tomrittervg/decrypt-windows-ec2-passwd.git","ssh_url":"git@github.com:tomrittervg/decrypt-windows-ec2-passwd.git","clone_url":"https://github.com/tomrittervg/decrypt-windows-ec2-passwd.git","svn_url":"https://github.com/tomrittervg/decrypt-windows-ec2-passwd","homepage":null,"size":122,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":10,"mirror_url":null,"open_issues_count":0,"forks":10,"open_issues":0,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/pulls/6"},"html":{"href":"https://github.com/tomrittervg/decrypt-windows-ec2-passwd/pull/6"},"issue":{"href":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/issues/6"},"comments":{"href":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/tomrittervg/decrypt-windows-ec2-passwd/statuses/18d66a1325e9c8825c4b33ea5438fe0ec8fcab33"}},"merged":true,"mergeable":true,"mergeable_state":"clean","merged_by":{"login":"tomrittervg","id":163497,"avatar_url":"https://avatars.githubusercontent.com/u/163497?","gravatar_id":"31e32ecb7309ad47e1ecdd34f4c26529","url":"https://api.github.com/users/tomrittervg","html_url":"https://github.com/tomrittervg","followers_url":"https://api.github.com/users/tomrittervg/followers","following_url":"https://api.github.com/users/tomrittervg/following{/other_user}","gists_url":"https://api.github.com/users/tomrittervg/gists{/gist_id}","starred_url":"https://api.github.com/users/tomrittervg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomrittervg/subscriptions","organizations_url":"https://api.github.com/users/tomrittervg/orgs","repos_url":"https://api.github.com/users/tomrittervg/repos","events_url":"https://api.github.com/users/tomrittervg/events{/privacy}","received_events_url":"https://api.github.com/users/tomrittervg/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}