GitHub PullRequestReviewCommentEvent at 2014-07-07 21:43:39
Repository: boto
Actor: danielgtaylor
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/boto/boto/pulls/comments/14624620","id":14624620,"diff_hunk":"@@ -78,7 +78,7 @@ def _get_all_objects(self, resource, tags, result_set_class=None,\n         rs_kwargs = result_set_kwargs or dict()\n         rs = rs_class(tags, **rs_kwargs)\n         h = handler.XmlHandler(rs, self)\n-        xml.sax.parseString(body, h)\n+        xml.sax.parseString(body.encode('utf-8'), h)","path":"boto/cloudfront/__init__.py","position":5,"original_position":5,"commit_id":"f929e0c97df03685d8d02181f9df7b693592efaa","original_commit_id":"f929e0c97df03685d8d02181f9df7b693592efaa","user":{"login":"danielgtaylor","id":106826,"avatar_url":"https://avatars.githubusercontent.com/u/106826?","gravatar_id":"bb0a0764f087f1d035e569d00600576c","url":"https://api.github.com/users/danielgtaylor","html_url":"https://github.com/danielgtaylor","followers_url":"https://api.github.com/users/danielgtaylor/followers","following_url":"https://api.github.com/users/danielgtaylor/following{/other_user}","gists_url":"https://api.github.com/users/danielgtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgtaylor/subscriptions","organizations_url":"https://api.github.com/users/danielgtaylor/orgs","repos_url":"https://api.github.com/users/danielgtaylor/repos","events_url":"https://api.github.com/users/danielgtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/danielgtaylor/received_events","type":"User","site_admin":false},"body":"This actually fails in Python 3 because `body` is already an instance of `bytes`.","created_at":"2014-07-07T21:43:39Z","updated_at":"2014-07-07T21:43:39Z","html_url":"https://github.com/boto/boto/pull/2355#discussion_r14624620","pull_request_url":"https://api.github.com/repos/boto/boto/pulls/2355","_links":{"self":{"href":"https://api.github.com/repos/boto/boto/pulls/comments/14624620"},"html":{"href":"https://github.com/boto/boto/pull/2355#discussion_r14624620"},"pull_request":{"href":"https://api.github.com/repos/boto/boto/pulls/2355"}}},"pull_request":{"url":"https://api.github.com/repos/boto/boto/pulls/2355","id":17928973,"html_url":"https://github.com/boto/boto/pull/2355","diff_url":"https://github.com/boto/boto/pull/2355.diff","patch_url":"https://github.com/boto/boto/pull/2355.patch","issue_url":"https://api.github.com/repos/boto/boto/issues/2355","number":2355,"state":"open","title":"cloudfront module: add backward-compatible support for Python 3.3+","user":{"login":"felixonmars","id":1006477,"avatar_url":"https://avatars.githubusercontent.com/u/1006477?","gravatar_id":"48b2061f9e9a00023417bc1174532e81","url":"https://api.github.com/users/felixonmars","html_url":"https://github.com/felixonmars","followers_url":"https://api.github.com/users/felixonmars/followers","following_url":"https://api.github.com/users/felixonmars/following{/other_user}","gists_url":"https://api.github.com/users/felixonmars/gists{/gist_id}","starred_url":"https://api.github.com/users/felixonmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixonmars/subscriptions","organizations_url":"https://api.github.com/users/felixonmars/orgs","repos_url":"https://api.github.com/users/felixonmars/repos","events_url":"https://api.github.com/users/felixonmars/events{/privacy}","received_events_url":"https://api.github.com/users/felixonmars/received_events","type":"User","site_admin":false},"body":"Unit tests passed.\r\n\r\nNo integration tests to test with, I managed to run some of my current code with the ported version, and it works.","created_at":"2014-07-03T07:13:19Z","updated_at":"2014-07-07T21:43:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f387916bb0367b5fd040b8b59c4bccc33b11eb3b","assignee":{"login":"danielgtaylor","id":106826,"avatar_url":"https://avatars.githubusercontent.com/u/106826?","gravatar_id":"bb0a0764f087f1d035e569d00600576c","url":"https://api.github.com/users/danielgtaylor","html_url":"https://github.com/danielgtaylor","followers_url":"https://api.github.com/users/danielgtaylor/followers","following_url":"https://api.github.com/users/danielgtaylor/following{/other_user}","gists_url":"https://api.github.com/users/danielgtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgtaylor/subscriptions","organizations_url":"https://api.github.com/users/danielgtaylor/orgs","repos_url":"https://api.github.com/users/danielgtaylor/repos","events_url":"https://api.github.com/users/danielgtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/danielgtaylor/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/boto/boto/pulls/2355/commits","review_comments_url":"https://api.github.com/repos/boto/boto/pulls/2355/comments","review_comment_url":"https://api.github.com/repos/boto/boto/pulls/comments/{number}","comments_url":"https://api.github.com/repos/boto/boto/issues/2355/comments","statuses_url":"https://api.github.com/repos/boto/boto/statuses/f929e0c97df03685d8d02181f9df7b693592efaa","head":{"label":"felixonmars:cloudfront-py3","ref":"cloudfront-py3","sha":"f929e0c97df03685d8d02181f9df7b693592efaa","user":{"login":"felixonmars","id":1006477,"avatar_url":"https://avatars.githubusercontent.com/u/1006477?","gravatar_id":"48b2061f9e9a00023417bc1174532e81","url":"https://api.github.com/users/felixonmars","html_url":"https://github.com/felixonmars","followers_url":"https://api.github.com/users/felixonmars/followers","following_url":"https://api.github.com/users/felixonmars/following{/other_user}","gists_url":"https://api.github.com/users/felixonmars/gists{/gist_id}","starred_url":"https://api.github.com/users/felixonmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixonmars/subscriptions","organizations_url":"https://api.github.com/users/felixonmars/orgs","repos_url":"https://api.github.com/users/felixonmars/repos","events_url":"https://api.github.com/users/felixonmars/events{/privacy}","received_events_url":"https://api.github.com/users/felixonmars/received_events","type":"User","site_admin":false},"repo":{"id":21451222,"name":"boto","full_name":"felixonmars/boto","owner":{"login":"felixonmars","id":1006477,"avatar_url":"https://avatars.githubusercontent.com/u/1006477?","gravatar_id":"48b2061f9e9a00023417bc1174532e81","url":"https://api.github.com/users/felixonmars","html_url":"https://github.com/felixonmars","followers_url":"https://api.github.com/users/felixonmars/followers","following_url":"https://api.github.com/users/felixonmars/following{/other_user}","gists_url":"https://api.github.com/users/felixonmars/gists{/gist_id}","starred_url":"https://api.github.com/users/felixonmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixonmars/subscriptions","organizations_url":"https://api.github.com/users/felixonmars/orgs","repos_url":"https://api.github.com/users/felixonmars/repos","events_url":"https://api.github.com/users/felixonmars/events{/privacy}","received_events_url":"https://api.github.com/users/felixonmars/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felixonmars/boto","description":"Python interface to Amazon Web Services","fork":true,"url":"https://api.github.com/repos/felixonmars/boto","forks_url":"https://api.github.com/repos/felixonmars/boto/forks","keys_url":"https://api.github.com/repos/felixonmars/boto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felixonmars/boto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felixonmars/boto/teams","hooks_url":"https://api.github.com/repos/felixonmars/boto/hooks","issue_events_url":"https://api.github.com/repos/felixonmars/boto/issues/events{/number}","events_url":"https://api.github.com/repos/felixonmars/boto/events","assignees_url":"https://api.github.com/repos/felixonmars/boto/assignees{/user}","branches_url":"https://api.github.com/repos/felixonmars/boto/branches{/branch}","tags_url":"https://api.github.com/repos/felixonmars/boto/tags","blobs_url":"https://api.github.com/repos/felixonmars/boto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felixonmars/boto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felixonmars/boto/git/refs{/sha}","trees_url":"https://api.github.com/repos/felixonmars/boto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felixonmars/boto/statuses/{sha}","languages_url":"https://api.github.com/repos/felixonmars/boto/languages","stargazers_url":"https://api.github.com/repos/felixonmars/boto/stargazers","contributors_url":"https://api.github.com/repos/felixonmars/boto/contributors","subscribers_url":"https://api.github.com/repos/felixonmars/boto/subscribers","subscription_url":"https://api.github.com/repos/felixonmars/boto/subscription","commits_url":"https://api.github.com/repos/felixonmars/boto/commits{/sha}","git_commits_url":"https://api.github.com/repos/felixonmars/boto/git/commits{/sha}","comments_url":"https://api.github.com/repos/felixonmars/boto/comments{/number}","issue_comment_url":"https://api.github.com/repos/felixonmars/boto/issues/comments/{number}","contents_url":"https://api.github.com/repos/felixonmars/boto/contents/{+path}","compare_url":"https://api.github.com/repos/felixonmars/boto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felixonmars/boto/merges","archive_url":"https://api.github.com/repos/felixonmars/boto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felixonmars/boto/downloads","issues_url":"https://api.github.com/repos/felixonmars/boto/issues{/number}","pulls_url":"https://api.github.com/repos/felixonmars/boto/pulls{/number}","milestones_url":"https://api.github.com/repos/felixonmars/boto/milestones{/number}","notifications_url":"https://api.github.com/repos/felixonmars/boto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felixonmars/boto/labels{/name}","releases_url":"https://api.github.com/repos/felixonmars/boto/releases{/id}","created_at":"2014-07-03T05:47:23Z","updated_at":"2014-07-02T23:56:50Z","pushed_at":"2014-07-04T12:56:05Z","git_url":"git://github.com/felixonmars/boto.git","ssh_url":"git@github.com:felixonmars/boto.git","clone_url":"https://github.com/felixonmars/boto.git","svn_url":"https://github.com/felixonmars/boto","homepage":"http://docs.pythonboto.org/","size":17588,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"boto:develop","ref":"develop","sha":"1ac79d0c984bfd83f26e7c3af4877a731a63ecc2","user":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?","gravatar_id":"9062d6f913c867ce042928d6637abd05","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"repo":{"id":771016,"name":"boto","full_name":"boto/boto","owner":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?","gravatar_id":"9062d6f913c867ce042928d6637abd05","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boto/boto","description":"Python interface to Amazon Web Services","fork":false,"url":"https://api.github.com/repos/boto/boto","forks_url":"https://api.github.com/repos/boto/boto/forks","keys_url":"https://api.github.com/repos/boto/boto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boto/boto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boto/boto/teams","hooks_url":"https://api.github.com/repos/boto/boto/hooks","issue_events_url":"https://api.github.com/repos/boto/boto/issues/events{/number}","events_url":"https://api.github.com/repos/boto/boto/events","assignees_url":"https://api.github.com/repos/boto/boto/assignees{/user}","branches_url":"https://api.github.com/repos/boto/boto/branches{/branch}","tags_url":"https://api.github.com/repos/boto/boto/tags","blobs_url":"https://api.github.com/repos/boto/boto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boto/boto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boto/boto/git/refs{/sha}","trees_url":"https://api.github.com/repos/boto/boto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boto/boto/statuses/{sha}","languages_url":"https://api.github.com/repos/boto/boto/languages","stargazers_url":"https://api.github.com/repos/boto/boto/stargazers","contributors_url":"https://api.github.com/repos/boto/boto/contributors","subscribers_url":"https://api.github.com/repos/boto/boto/subscribers","subscription_url":"https://api.github.com/repos/boto/boto/subscription","commits_url":"https://api.github.com/repos/boto/boto/commits{/sha}","git_commits_url":"https://api.github.com/repos/boto/boto/git/commits{/sha}","comments_url":"https://api.github.com/repos/boto/boto/comments{/number}","issue_comment_url":"https://api.github.com/repos/boto/boto/issues/comments/{number}","contents_url":"https://api.github.com/repos/boto/boto/contents/{+path}","compare_url":"https://api.github.com/repos/boto/boto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boto/boto/merges","archive_url":"https://api.github.com/repos/boto/boto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boto/boto/downloads","issues_url":"https://api.github.com/repos/boto/boto/issues{/number}","pulls_url":"https://api.github.com/repos/boto/boto/pulls{/number}","milestones_url":"https://api.github.com/repos/boto/boto/milestones{/number}","notifications_url":"https://api.github.com/repos/boto/boto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boto/boto/labels{/name}","releases_url":"https://api.github.com/repos/boto/boto/releases{/id}","created_at":"2010-07-12T19:15:33Z","updated_at":"2014-07-07T16:58:54Z","pushed_at":"2014-07-07T20:34:59Z","git_url":"git://github.com/boto/boto.git","ssh_url":"git@github.com:boto/boto.git","clone_url":"https://github.com/boto/boto.git","svn_url":"https://github.com/boto/boto","homepage":"http://docs.pythonboto.org/","size":34814,"stargazers_count":3920,"watchers_count":3920,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":1331,"mirror_url":null,"open_issues_count":439,"forks":1331,"open_issues":439,"watchers":3920,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/boto/boto/pulls/2355"},"html":{"href":"https://github.com/boto/boto/pull/2355"},"issue":{"href":"https://api.github.com/repos/boto/boto/issues/2355"},"comments":{"href":"https://api.github.com/repos/boto/boto/issues/2355/comments"},"review_comments":{"href":"https://api.github.com/repos/boto/boto/pulls/2355/comments"},"review_comment":{"href":"https://api.github.com/repos/boto/boto/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/boto/boto/pulls/2355/commits"},"statuses":{"href":"https://api.github.com/repos/boto/boto/statuses/f929e0c97df03685d8d02181f9df7b693592efaa"}}}}