GitHub PullRequestReviewCommentEvent at 2014-12-01 21:58:55
Repository: kubernetes
Actor: smarterclayton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/21123105","id":21123105,"diff_hunk":"@@ -107,23 +107,26 @@ Find more information at https://github.com/GoogleCloudPlatform/kubernetes.`,\n \t}\n }\n \n-func checkErr(err error) {\n+func CheckErr(err error) {\n \tif err != nil {\n \t\tglog.FatalDepth(1, err)\n \t}\n }\n \n-func usageError(cmd *cobra.Command, format string, args ...interface{}) {\n+func UsageError(cmd *cobra.Command, format string, args ...interface{}) {\n \tglog.Errorf(format, args...)\n \tglog.Errorf(\"See '%s -h' for help.\", cmd.CommandPath())\n \tos.Exit(1)\n }\n \n-func runHelp(cmd *cobra.Command, args []string) {\n+func RunHelp(cmd *cobra.Command, args []string) {","path":"pkg/kubectl/cmd/cmd.go","position":28,"original_position":28,"commit_id":"f0ee1c76b518d6cfd3a3c5b6d2563d09b78bc7e0","original_commit_id":"f0ee1c76b518d6cfd3a3c5b6d2563d09b78bc7e0","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"Also, it's likely to vary based on the context, or it's trivial.","created_at":"2014-12-01T21:58:55Z","updated_at":"2014-12-01T21:58:55Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2682#discussion_r21123105","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2682","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/21123105"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2682#discussion_r21123105"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2682"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2682","id":25260911,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2682","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2682.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2682.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2682","number":2682,"state":"open","locked":false,"title":"Export kubectl/cmd methods","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"These commands are useful when build a CLI client based on kubectl to avoid code duplication and be consistent with eg. error reporting from upstream.\r\n\r\n@smarterclayton fyi.","created_at":"2014-12-01T11:07:35Z","updated_at":"2014-12-01T21:58:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdb0d164a191fb39e1c87ec59296bc5489c60cdc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2682/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2682/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2682/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/f0ee1c76b518d6cfd3a3c5b6d2563d09b78bc7e0","head":{"label":"mfojtik:cmd_public","ref":"cmd_public","sha":"f0ee1c76b518d6cfd3a3c5b6d2563d09b78bc7e0","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"repo":{"id":22151842,"name":"kubernetes","full_name":"mfojtik/kubernetes","owner":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfojtik/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/mfojtik/kubernetes","forks_url":"https://api.github.com/repos/mfojtik/kubernetes/forks","keys_url":"https://api.github.com/repos/mfojtik/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfojtik/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfojtik/kubernetes/teams","hooks_url":"https://api.github.com/repos/mfojtik/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mfojtik/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mfojtik/kubernetes/events","assignees_url":"https://api.github.com/repos/mfojtik/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mfojtik/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mfojtik/kubernetes/tags","blobs_url":"https://api.github.com/repos/mfojtik/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfojtik/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfojtik/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfojtik/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfojtik/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mfojtik/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mfojtik/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mfojtik/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mfojtik/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mfojtik/kubernetes/subscription","commits_url":"https://api.github.com/repos/mfojtik/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfojtik/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfojtik/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfojtik/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/mfojtik/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mfojtik/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfojtik/kubernetes/merges","archive_url":"https://api.github.com/repos/mfojtik/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfojtik/kubernetes/downloads","issues_url":"https://api.github.com/repos/mfojtik/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mfojtik/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mfojtik/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mfojtik/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfojtik/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mfojtik/kubernetes/releases{/id}","created_at":"2014-07-23T14:06:52Z","updated_at":"2014-12-01T10:50:11Z","pushed_at":"2014-12-01T11:29:04Z","git_url":"git://github.com/mfojtik/kubernetes.git","ssh_url":"git@github.com:mfojtik/kubernetes.git","clone_url":"https://github.com/mfojtik/kubernetes.git","svn_url":"https://github.com/mfojtik/kubernetes","homepage":null,"size":19868,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6aabd9804fb75764b70e9172774002d4febcae34","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2014-12-01T21:41:04Z","pushed_at":"2014-12-01T21:41:04Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":null,"size":63896,"stargazers_count":5113,"watchers_count":5113,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":781,"mirror_url":null,"open_issues_count":497,"forks":781,"open_issues":497,"watchers":5113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2682"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2682"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2682"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2682/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2682/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2682/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/f0ee1c76b518d6cfd3a3c5b6d2563d09b78bc7e0"}}}}