GitHub PullRequestReviewCommentEvent at 2014-01-05 01:03:59
Repository: node
Actor: trevnorris
Payload: {"comment":{"url":"https://api.github.com/repos/joyent/node/pulls/comments/8653885","id":8653885,"diff_hunk":"@@ -6364,6 +6364,28 @@ static inline uintptr_t AsciiRangeMask(uintptr_t w, char m, char n) {\n   return (tmp1 & tmp2 & (kOneInEveryByte * 0x80));\n }\n \n+#ifdef DEBUG\n+static bool CheckFastAsciiConvert(char* dst,\n+                                  char* src,\n+                                  int length,\n+                                  bool changed,\n+                                  bool is_to_lower) {\n+  bool expected_changed = false;\n+  for (int i = 0; i < length; i++) {\n+    if (dst[i] == src[i]) continue;\n+    expected_changed = true;\n+    if (is_to_lower) {\n+      ASSERT('A' <= src[i] && src[i] <= 'Z');\n+      ASSERT(dst[i] == src[i] + ('a' - 'A'));\n+    } else {\n+      ASSERT('a' <= src[i] && src[i] <= 'z');\n+      ASSERT(dst[i] == src[i] - ('a' - 'A'));\n+    }\n+  }\n+  return (expected_changed == changed);\n+}\n+#endif\n+","path":"deps/v8/src/runtime.cc","position":25,"original_position":25,"commit_id":"da34095d8bd6b71577926496c32ecbbf8bbb6f47","original_commit_id":"da34095d8bd6b71577926496c32ecbbf8bbb6f47","user":{"login":"trevnorris","id":289174,"avatar_url":"https://gravatar.com/avatar/3e440ff4686867b1929ce68684591885?d=https%3A%2F%2Fidenticons.github.com%2F14a7cf7e7b5c20d8a06f08449491b96d.png&r=x","gravatar_id":"3e440ff4686867b1929ce68684591885","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"I'm confused how this change to `deps/v8` made it int this PR.","created_at":"2014-01-05T01:03:59Z","updated_at":"2014-01-05T01:03:59Z","html_url":"https://github.com/joyent/node/pull/6703#discussion_r8653885","pull_request_url":"https://api.github.com/repos/joyent/node/pulls/6703","_links":{"self":{"href":"https://api.github.com/repos/joyent/node/pulls/comments/8653885"},"html":{"href":"https://github.com/joyent/node/pull/6703#discussion_r8653885"},"pull_request":{"href":"https://api.github.com/repos/joyent/node/pulls/6703"}}}}