GitHub PullRequestReviewCommentEvent at 2014-12-23 16:16:17
Repository: frontend
Actor: neoeno
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments/22221273","id":22221273,"diff_hunk":"@@ -0,0 +1,11 @@\n+module Core\n+  class ArticleLink","path":"lib/core/entity/article_link.rb","position":2,"original_position":2,"commit_id":"cd9f53b1a3c0d8d869bcbee6caed56b801cef64f","original_commit_id":"cd9f53b1a3c0d8d869bcbee6caed56b801cef64f","user":{"login":"neoeno","id":1007202,"avatar_url":"https://avatars.githubusercontent.com/u/1007202?v=3","gravatar_id":"","url":"https://api.github.com/users/neoeno","html_url":"https://github.com/neoeno","followers_url":"https://api.github.com/users/neoeno/followers","following_url":"https://api.github.com/users/neoeno/following{/other_user}","gists_url":"https://api.github.com/users/neoeno/gists{/gist_id}","starred_url":"https://api.github.com/users/neoeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neoeno/subscriptions","organizations_url":"https://api.github.com/users/neoeno/orgs","repos_url":"https://api.github.com/users/neoeno/repos","events_url":"https://api.github.com/users/neoeno/events{/privacy}","received_events_url":"https://api.github.com/users/neoeno/received_events","type":"User","site_admin":false},"body":"@benlovell Having looked into this, I'm not sure I can figure out how this saves us much. Since `@article.popular_links` is an array of `ArticleLinks`, the only way I can see of using this is to create a partial with this in:\r\n\r\n```erb\r\n<li class=\"related-links__link\">\r\n  <%= link_to popular_link.title, popular_link.path %>\r\n</li>\r\n```\r\n\r\nAnd pointing `to_partial_path` to that, which doesn't seem to save us much. Am I missing something?","created_at":"2014-12-23T16:16:17Z","updated_at":"2014-12-23T16:16:17Z","html_url":"https://github.com/moneyadviceservice/frontend/pull/845#discussion_r22221273","pull_request_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/845","_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments/22221273"},"html":{"href":"https://github.com/moneyadviceservice/frontend/pull/845#discussion_r22221273"},"pull_request":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/845"}}},"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/845","id":26373343,"html_url":"https://github.com/moneyadviceservice/frontend/pull/845","diff_url":"https://github.com/moneyadviceservice/frontend/pull/845.diff","patch_url":"https://github.com/moneyadviceservice/frontend/pull/845.patch","issue_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/845","number":845,"state":"open","locked":false,"title":"Introduce Popular links","user":{"login":"JiggyPete","id":67151,"avatar_url":"https://avatars.githubusercontent.com/u/67151?v=3","gravatar_id":"","url":"https://api.github.com/users/JiggyPete","html_url":"https://github.com/JiggyPete","followers_url":"https://api.github.com/users/JiggyPete/followers","following_url":"https://api.github.com/users/JiggyPete/following{/other_user}","gists_url":"https://api.github.com/users/JiggyPete/gists{/gist_id}","starred_url":"https://api.github.com/users/JiggyPete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiggyPete/subscriptions","organizations_url":"https://api.github.com/users/JiggyPete/orgs","repos_url":"https://api.github.com/users/JiggyPete/repos","events_url":"https://api.github.com/users/JiggyPete/events{/privacy}","received_events_url":"https://api.github.com/users/JiggyPete/received_events","type":"User","site_admin":false},"body":"This PR is to introduce the Popular Links part of the Related Content work, which is a panel on the right hand side of articles.\r\n\r\nChanges in this PR will probably want a quick review by frontend devs (cc: @benbarnett/@alexwllms ) as we've modified the main layout for all articles.\r\n\r\nWork related to bringing in the popular links is behind a feature flag: 'popular_links'. The related for popular links can be found in the following PR https://github.com/moneyadviceservice/cms/pull/116","created_at":"2014-12-19T14:08:28Z","updated_at":"2014-12-23T16:16:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca72848ee4419ae103fe71850347f47fdd6163c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/845/commits","review_comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/845/comments","review_comment_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/845/comments","statuses_url":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/cd9f53b1a3c0d8d869bcbee6caed56b801cef64f","head":{"label":"moneyadviceservice:link_recirculation","ref":"link_recirculation","sha":"cd9f53b1a3c0d8d869bcbee6caed56b801cef64f","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":15315123,"name":"frontend","full_name":"moneyadviceservice/frontend","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/frontend","description":"The Money Advice Service's improved website.","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/frontend","forks_url":"https://api.github.com/repos/moneyadviceservice/frontend/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/frontend/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/frontend/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/frontend/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/frontend/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/frontend/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/frontend/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/moneyadviceservice/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/frontend/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/frontend/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/frontend/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/frontend/releases{/id}","created_at":"2013-12-19T15:25:21Z","updated_at":"2014-12-23T14:19:49Z","pushed_at":"2014-12-23T15:25:04Z","git_url":"git://github.com/moneyadviceservice/frontend.git","ssh_url":"git@github.com:moneyadviceservice/frontend.git","clone_url":"https://github.com/moneyadviceservice/frontend.git","svn_url":"https://github.com/moneyadviceservice/frontend","homepage":"https://www.moneyadviceservice.org.uk  ","size":28704,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":3,"default_branch":"master"}},"base":{"label":"moneyadviceservice:master","ref":"master","sha":"868f16c9be7f5313e27864c7eefc49befa5c41de","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":15315123,"name":"frontend","full_name":"moneyadviceservice/frontend","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/frontend","description":"The Money Advice Service's improved website.","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/frontend","forks_url":"https://api.github.com/repos/moneyadviceservice/frontend/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/frontend/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/frontend/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/frontend/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/frontend/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/frontend/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/frontend/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/moneyadviceservice/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/frontend/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/frontend/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/frontend/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/frontend/releases{/id}","created_at":"2013-12-19T15:25:21Z","updated_at":"2014-12-23T14:19:49Z","pushed_at":"2014-12-23T15:25:04Z","git_url":"git://github.com/moneyadviceservice/frontend.git","ssh_url":"git@github.com:moneyadviceservice/frontend.git","clone_url":"https://github.com/moneyadviceservice/frontend.git","svn_url":"https://github.com/moneyadviceservice/frontend","homepage":"https://www.moneyadviceservice.org.uk  ","size":28704,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/845"},"html":{"href":"https://github.com/moneyadviceservice/frontend/pull/845"},"issue":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/issues/845"},"comments":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/issues/845/comments"},"review_comments":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/845/comments"},"review_comment":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/845/commits"},"statuses":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/cd9f53b1a3c0d8d869bcbee6caed56b801cef64f"}}}}