GitHub PullRequestReviewCommentEvent at 2014-12-04 22:03:13
Repository: digest
Actor: eddelbuettel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/eddelbuettel/digest/pulls/comments/21340205","id":21340205,"diff_hunk":"@@ -45,7 +45,8 @@\n                      sha1=2,\n                      crc32=3,\n                      sha256=4,\n-\t\t\t\t\t sha512=5)\n+                     sha512=5,\n+                     xxHash=6)","path":"R/digest.R","position":15,"original_position":15,"commit_id":"d4e30b257b1254d2c4514bc5090b0556821e350e","original_commit_id":"d4e30b257b1254d2c4514bc5090b0556821e350e","user":{"login":"eddelbuettel","id":673121,"avatar_url":"https://avatars.githubusercontent.com/u/673121?v=3","gravatar_id":"","url":"https://api.github.com/users/eddelbuettel","html_url":"https://github.com/eddelbuettel","followers_url":"https://api.github.com/users/eddelbuettel/followers","following_url":"https://api.github.com/users/eddelbuettel/following{/other_user}","gists_url":"https://api.github.com/users/eddelbuettel/gists{/gist_id}","starred_url":"https://api.github.com/users/eddelbuettel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddelbuettel/subscriptions","organizations_url":"https://api.github.com/users/eddelbuettel/orgs","repos_url":"https://api.github.com/users/eddelbuettel/repos","events_url":"https://api.github.com/users/eddelbuettel/events{/privacy}","received_events_url":"https://api.github.com/users/eddelbuettel/received_events","type":"User","site_admin":false},"body":"and obviously here too.\r\n\r\nLooks pretty good otherwise.  Could you also adapt man/digest.Rd accordingly so that R CMD check is happy?","created_at":"2014-12-04T22:03:13Z","updated_at":"2014-12-04T22:03:13Z","html_url":"https://github.com/eddelbuettel/digest/pull/3#discussion_r21340205","pull_request_url":"https://api.github.com/repos/eddelbuettel/digest/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/eddelbuettel/digest/pulls/comments/21340205"},"html":{"href":"https://github.com/eddelbuettel/digest/pull/3#discussion_r21340205"},"pull_request":{"href":"https://api.github.com/repos/eddelbuettel/digest/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/eddelbuettel/digest/pulls/3","id":25510721,"html_url":"https://github.com/eddelbuettel/digest/pull/3","diff_url":"https://github.com/eddelbuettel/digest/pull/3.diff","patch_url":"https://github.com/eddelbuettel/digest/pull/3.patch","issue_url":"https://api.github.com/repos/eddelbuettel/digest/issues/3","number":3,"state":"open","locked":false,"title":"Initial implementation of xxhash support.","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"body":"This pull request provides support for [xxHash](https://github.com/Cyan4973/xxHash) hash function.  It is a non-cryptographic hash function whose main feature is that it is extremely fast.\r\n\r\nThis pull request currently contains a simple initial implementation.  I wanted to make sure it looks ok and that you would be willing to accept it before fleshing out the documentation/etc.  Also there are a few more features I could add if you thought they would be worthwhile.\r\n\r\n1. xxHash has two flavors, `XXH64` which returns a 64 bit unsigned long long, and `XXH32` which returns a 32bit unsigned long.  The 64 bit version is very fast on 64 bit architectures, but a fair amount slower on 32 bit.  Likewise the 32bit version is fast on 32 bit architectures and slower on 64bit.  The current implementation is only the 64 bit version, however it would not be hard to add the 32 bit as well following the `SHA1, SHA256` model you have established.\r\n2. xxHash lets you input a seed to the hash, so it would be nice to allow this to be user configurable from `digest()` (so they could generate longer hashes from the same input for instance).  Right now the seed is hardcoded to be `0`.\r\n\r\nI apologize for all the extraneous whitespace changes in the pull,  my editor automatically fixes trailing whitespace.\r\n\r\nAlso if you are curious about the real world speed I calculated a hash of the human reference genome `Hg18` with xxHash and sha1, as you can see it is very fast!\r\n```r\r\nsystem.time(digest('~/Hg18.fa', 'sha1', file = TRUE))\r\n#>   user  system elapsed\r\n#> 10.523   0.762  11.286\r\n\r\nsystem.time(digest('~/Hg18.fa', 'xxHash', file = TRUE))\r\n#>   user  system elapsed\r\n#>  0.585   0.690   1.275\r\n```\r\n","created_at":"2014-12-04T16:55:31Z","updated_at":"2014-12-04T22:03:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aff2a9035676f30628ade4504beeaf3e7b59cf2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eddelbuettel/digest/pulls/3/commits","review_comments_url":"https://api.github.com/repos/eddelbuettel/digest/pulls/3/comments","review_comment_url":"https://api.github.com/repos/eddelbuettel/digest/pulls/comments/{number}","comments_url":"https://api.github.com/repos/eddelbuettel/digest/issues/3/comments","statuses_url":"https://api.github.com/repos/eddelbuettel/digest/statuses/d4e30b257b1254d2c4514bc5090b0556821e350e","head":{"label":"jimhester:xxHash","ref":"xxHash","sha":"d4e30b257b1254d2c4514bc5090b0556821e350e","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"repo":{"id":27545697,"name":"digest","full_name":"jimhester/digest","owner":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimhester/digest","description":"R package to create cryptographic hash digests of R objects","fork":true,"url":"https://api.github.com/repos/jimhester/digest","forks_url":"https://api.github.com/repos/jimhester/digest/forks","keys_url":"https://api.github.com/repos/jimhester/digest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimhester/digest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimhester/digest/teams","hooks_url":"https://api.github.com/repos/jimhester/digest/hooks","issue_events_url":"https://api.github.com/repos/jimhester/digest/issues/events{/number}","events_url":"https://api.github.com/repos/jimhester/digest/events","assignees_url":"https://api.github.com/repos/jimhester/digest/assignees{/user}","branches_url":"https://api.github.com/repos/jimhester/digest/branches{/branch}","tags_url":"https://api.github.com/repos/jimhester/digest/tags","blobs_url":"https://api.github.com/repos/jimhester/digest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimhester/digest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimhester/digest/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimhester/digest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimhester/digest/statuses/{sha}","languages_url":"https://api.github.com/repos/jimhester/digest/languages","stargazers_url":"https://api.github.com/repos/jimhester/digest/stargazers","contributors_url":"https://api.github.com/repos/jimhester/digest/contributors","subscribers_url":"https://api.github.com/repos/jimhester/digest/subscribers","subscription_url":"https://api.github.com/repos/jimhester/digest/subscription","commits_url":"https://api.github.com/repos/jimhester/digest/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimhester/digest/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimhester/digest/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimhester/digest/issues/comments/{number}","contents_url":"https://api.github.com/repos/jimhester/digest/contents/{+path}","compare_url":"https://api.github.com/repos/jimhester/digest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimhester/digest/merges","archive_url":"https://api.github.com/repos/jimhester/digest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimhester/digest/downloads","issues_url":"https://api.github.com/repos/jimhester/digest/issues{/number}","pulls_url":"https://api.github.com/repos/jimhester/digest/pulls{/number}","milestones_url":"https://api.github.com/repos/jimhester/digest/milestones{/number}","notifications_url":"https://api.github.com/repos/jimhester/digest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimhester/digest/labels{/name}","releases_url":"https://api.github.com/repos/jimhester/digest/releases{/id}","created_at":"2014-12-04T15:06:51Z","updated_at":"2014-12-04T15:06:52Z","pushed_at":"2014-12-04T16:31:17Z","git_url":"git://github.com/jimhester/digest.git","ssh_url":"git@github.com:jimhester/digest.git","clone_url":"https://github.com/jimhester/digest.git","svn_url":"https://github.com/jimhester/digest","homepage":null,"size":228,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eddelbuettel:master","ref":"master","sha":"3c4488e028d747cf0b2260bd4d80851981b6f2d9","user":{"login":"eddelbuettel","id":673121,"avatar_url":"https://avatars.githubusercontent.com/u/673121?v=3","gravatar_id":"","url":"https://api.github.com/users/eddelbuettel","html_url":"https://github.com/eddelbuettel","followers_url":"https://api.github.com/users/eddelbuettel/followers","following_url":"https://api.github.com/users/eddelbuettel/following{/other_user}","gists_url":"https://api.github.com/users/eddelbuettel/gists{/gist_id}","starred_url":"https://api.github.com/users/eddelbuettel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddelbuettel/subscriptions","organizations_url":"https://api.github.com/users/eddelbuettel/orgs","repos_url":"https://api.github.com/users/eddelbuettel/repos","events_url":"https://api.github.com/users/eddelbuettel/events{/privacy}","received_events_url":"https://api.github.com/users/eddelbuettel/received_events","type":"User","site_admin":false},"repo":{"id":14911222,"name":"digest","full_name":"eddelbuettel/digest","owner":{"login":"eddelbuettel","id":673121,"avatar_url":"https://avatars.githubusercontent.com/u/673121?v=3","gravatar_id":"","url":"https://api.github.com/users/eddelbuettel","html_url":"https://github.com/eddelbuettel","followers_url":"https://api.github.com/users/eddelbuettel/followers","following_url":"https://api.github.com/users/eddelbuettel/following{/other_user}","gists_url":"https://api.github.com/users/eddelbuettel/gists{/gist_id}","starred_url":"https://api.github.com/users/eddelbuettel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddelbuettel/subscriptions","organizations_url":"https://api.github.com/users/eddelbuettel/orgs","repos_url":"https://api.github.com/users/eddelbuettel/repos","events_url":"https://api.github.com/users/eddelbuettel/events{/privacy}","received_events_url":"https://api.github.com/users/eddelbuettel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eddelbuettel/digest","description":"R package to create cryptographic hash digests of R objects","fork":false,"url":"https://api.github.com/repos/eddelbuettel/digest","forks_url":"https://api.github.com/repos/eddelbuettel/digest/forks","keys_url":"https://api.github.com/repos/eddelbuettel/digest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eddelbuettel/digest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eddelbuettel/digest/teams","hooks_url":"https://api.github.com/repos/eddelbuettel/digest/hooks","issue_events_url":"https://api.github.com/repos/eddelbuettel/digest/issues/events{/number}","events_url":"https://api.github.com/repos/eddelbuettel/digest/events","assignees_url":"https://api.github.com/repos/eddelbuettel/digest/assignees{/user}","branches_url":"https://api.github.com/repos/eddelbuettel/digest/branches{/branch}","tags_url":"https://api.github.com/repos/eddelbuettel/digest/tags","blobs_url":"https://api.github.com/repos/eddelbuettel/digest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eddelbuettel/digest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eddelbuettel/digest/git/refs{/sha}","trees_url":"https://api.github.com/repos/eddelbuettel/digest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eddelbuettel/digest/statuses/{sha}","languages_url":"https://api.github.com/repos/eddelbuettel/digest/languages","stargazers_url":"https://api.github.com/repos/eddelbuettel/digest/stargazers","contributors_url":"https://api.github.com/repos/eddelbuettel/digest/contributors","subscribers_url":"https://api.github.com/repos/eddelbuettel/digest/subscribers","subscription_url":"https://api.github.com/repos/eddelbuettel/digest/subscription","commits_url":"https://api.github.com/repos/eddelbuettel/digest/commits{/sha}","git_commits_url":"https://api.github.com/repos/eddelbuettel/digest/git/commits{/sha}","comments_url":"https://api.github.com/repos/eddelbuettel/digest/comments{/number}","issue_comment_url":"https://api.github.com/repos/eddelbuettel/digest/issues/comments/{number}","contents_url":"https://api.github.com/repos/eddelbuettel/digest/contents/{+path}","compare_url":"https://api.github.com/repos/eddelbuettel/digest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eddelbuettel/digest/merges","archive_url":"https://api.github.com/repos/eddelbuettel/digest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eddelbuettel/digest/downloads","issues_url":"https://api.github.com/repos/eddelbuettel/digest/issues{/number}","pulls_url":"https://api.github.com/repos/eddelbuettel/digest/pulls{/number}","milestones_url":"https://api.github.com/repos/eddelbuettel/digest/milestones{/number}","notifications_url":"https://api.github.com/repos/eddelbuettel/digest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eddelbuettel/digest/labels{/name}","releases_url":"https://api.github.com/repos/eddelbuettel/digest/releases{/id}","created_at":"2013-12-04T01:48:12Z","updated_at":"2014-08-15T20:33:17Z","pushed_at":"2014-08-15T20:33:16Z","git_url":"git://github.com/eddelbuettel/digest.git","ssh_url":"git@github.com:eddelbuettel/digest.git","clone_url":"https://github.com/eddelbuettel/digest.git","svn_url":"https://github.com/eddelbuettel/digest","homepage":null,"size":344,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eddelbuettel/digest/pulls/3"},"html":{"href":"https://github.com/eddelbuettel/digest/pull/3"},"issue":{"href":"https://api.github.com/repos/eddelbuettel/digest/issues/3"},"comments":{"href":"https://api.github.com/repos/eddelbuettel/digest/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/eddelbuettel/digest/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/eddelbuettel/digest/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/eddelbuettel/digest/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/eddelbuettel/digest/statuses/d4e30b257b1254d2c4514bc5090b0556821e350e"}}}}