GitHub PullRequestReviewCommentEvent at 2014-02-25 16:34:23
Repository: numpy
Actor: charris
Payload: {"comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/10043025","id":10043025,"diff_hunk":"@@ -271,8 +271,19 @@ static NPY_INLINE int PyInt_Check(PyObject *op) {\n \n #else\n \n-#define npy_PyFile_Dup(file, mode, orig_pos_p) PyFile_AsFile(file)\n-#define npy_PyFile_DupClose(file, handle, orig_pos) (0)\n+static NPY_INLINE FILE *\n+npy_PyFile_Dup(PyObject *file,\n+               char *NPY_UNUSED(mode), npy_off_t *NPY_UNUSED(orig_pos))\n+{\n+    return PyFile_AsFile(file);\n+}\n+\n+static NPY_INLINE int\n+npy_PyFile_DupClose(PyObject *file, FILE* handle, npy_off_t orig_pos)","path":"numpy/core/include/numpy/npy_3kcompat.h","position":14,"original_position":14,"commit_id":"0f410325e22d2fe1dd9589a349fa297c727babb2","original_commit_id":"0f410325e22d2fe1dd9589a349fa297c727babb2","user":{"login":"charris","id":77272,"avatar_url":"https://gravatar.com/avatar/96dd777e397ab128fedab46af97a3a4a?d=https%3A%2F%2Fidenticons.github.com%2Fcd403a05fbbc1997842a6028a1032608.png&r=x","gravatar_id":"96dd777e397ab128fedab46af97a3a4a","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"body":"Wait, this doesn't have any unused variables?","created_at":"2014-02-25T16:34:23Z","updated_at":"2014-02-25T16:34:23Z","html_url":"https://github.com/numpy/numpy/pull/4365#discussion_r10043025","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/4365","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/10043025"},"html":{"href":"https://github.com/numpy/numpy/pull/4365#discussion_r10043025"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/4365"}}}}