GitHub PullRequestReviewCommentEvent at 2014-12-06 19:03:55
Repository: django
Actor: andrewgodwin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/21418347","id":21418347,"diff_hunk":"@@ -990,6 +993,20 @@ def generate_altered_order_with_respect_to(self):\n                     dependencies=dependencies,\n                 )\n \n+    def generate_altered_managers(self):\n+        for app_label, model_name in sorted(self.kept_model_keys):\n+            old_model_name = self.renamed_models.get((app_label, model_name), model_name)\n+            old_model_state = self.from_state.models[app_label, old_model_name]\n+            new_model_state = self.to_state.models[app_label, model_name]\n+            if old_model_state.managers != new_model_state.managers:\n+                self.add_operation(\n+                    app_label,\n+                    operations.AlterModelManagers(\n+                        name=model_name,\n+                        managers=new_model_state.managers\n+                    )","path":"django/db/migrations/autodetector.py","position":39,"original_position":39,"commit_id":"c631190fad63a90ecfadbd33387d47a258afa924","original_commit_id":"b713d191b9c239f407eb6020c3e739c7c4a37c64","user":{"login":"andrewgodwin","id":36182,"avatar_url":"https://avatars.githubusercontent.com/u/36182?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewgodwin","html_url":"https://github.com/andrewgodwin","followers_url":"https://api.github.com/users/andrewgodwin/followers","following_url":"https://api.github.com/users/andrewgodwin/following{/other_user}","gists_url":"https://api.github.com/users/andrewgodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewgodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewgodwin/subscriptions","organizations_url":"https://api.github.com/users/andrewgodwin/orgs","repos_url":"https://api.github.com/users/andrewgodwin/repos","events_url":"https://api.github.com/users/andrewgodwin/events{/privacy}","received_events_url":"https://api.github.com/users/andrewgodwin/received_events","type":"User","site_admin":false},"body":"Ah, sorry, you're rolling it into the create/delete operations rather than optimising it in, my bad. It's fine then!","created_at":"2014-12-06T19:03:55Z","updated_at":"2014-12-06T19:03:55Z","html_url":"https://github.com/django/django/pull/3687#discussion_r21418347","pull_request_url":"https://api.github.com/repos/django/django/pulls/3687","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/21418347"},"html":{"href":"https://github.com/django/django/pull/3687#discussion_r21418347"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/3687"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/3687","id":25547063,"html_url":"https://github.com/django/django/pull/3687","diff_url":"https://github.com/django/django/pull/3687.diff","patch_url":"https://github.com/django/django/pull/3687.patch","issue_url":"https://api.github.com/repos/django/django/issues/3687","number":3687,"state":"open","locked":false,"title":"Fixed #23822 -- Added support for serializing model managers in migration","user":{"login":"MarkusH","id":475613,"avatar_url":"https://avatars.githubusercontent.com/u/475613?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkusH","html_url":"https://github.com/MarkusH","followers_url":"https://api.github.com/users/MarkusH/followers","following_url":"https://api.github.com/users/MarkusH/following{/other_user}","gists_url":"https://api.github.com/users/MarkusH/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkusH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkusH/subscriptions","organizations_url":"https://api.github.com/users/MarkusH/orgs","repos_url":"https://api.github.com/users/MarkusH/repos","events_url":"https://api.github.com/users/MarkusH/events{/privacy}","received_events_url":"https://api.github.com/users/MarkusH/received_events","type":"User","site_admin":false},"body":"Ticket: https://code.djangoproject.com/ticket/23822\r\n\r\n- [x] Implementation\r\n- [x] User documentation\r\n- [x] Reference documentation\r\n- [x] Tests","created_at":"2014-12-05T03:11:53Z","updated_at":"2014-12-06T19:03:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"565b5bb6c798c9be9fa0b0f8a0399d4ad1844ca7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/3687/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/3687/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments/{number}","comments_url":"https://api.github.com/repos/django/django/issues/3687/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/c631190fad63a90ecfadbd33387d47a258afa924","head":{"label":"MarkusH:migration-managers","ref":"migration-managers","sha":"c631190fad63a90ecfadbd33387d47a258afa924","user":{"login":"MarkusH","id":475613,"avatar_url":"https://avatars.githubusercontent.com/u/475613?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkusH","html_url":"https://github.com/MarkusH","followers_url":"https://api.github.com/users/MarkusH/followers","following_url":"https://api.github.com/users/MarkusH/following{/other_user}","gists_url":"https://api.github.com/users/MarkusH/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkusH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkusH/subscriptions","organizations_url":"https://api.github.com/users/MarkusH/orgs","repos_url":"https://api.github.com/users/MarkusH/repos","events_url":"https://api.github.com/users/MarkusH/events{/privacy}","received_events_url":"https://api.github.com/users/MarkusH/received_events","type":"User","site_admin":false},"repo":{"id":8968526,"name":"django","full_name":"MarkusH/django","owner":{"login":"MarkusH","id":475613,"avatar_url":"https://avatars.githubusercontent.com/u/475613?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkusH","html_url":"https://github.com/MarkusH","followers_url":"https://api.github.com/users/MarkusH/followers","following_url":"https://api.github.com/users/MarkusH/following{/other_user}","gists_url":"https://api.github.com/users/MarkusH/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkusH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkusH/subscriptions","organizations_url":"https://api.github.com/users/MarkusH/orgs","repos_url":"https://api.github.com/users/MarkusH/repos","events_url":"https://api.github.com/users/MarkusH/events{/privacy}","received_events_url":"https://api.github.com/users/MarkusH/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarkusH/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/MarkusH/django","forks_url":"https://api.github.com/repos/MarkusH/django/forks","keys_url":"https://api.github.com/repos/MarkusH/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkusH/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkusH/django/teams","hooks_url":"https://api.github.com/repos/MarkusH/django/hooks","issue_events_url":"https://api.github.com/repos/MarkusH/django/issues/events{/number}","events_url":"https://api.github.com/repos/MarkusH/django/events","assignees_url":"https://api.github.com/repos/MarkusH/django/assignees{/user}","branches_url":"https://api.github.com/repos/MarkusH/django/branches{/branch}","tags_url":"https://api.github.com/repos/MarkusH/django/tags","blobs_url":"https://api.github.com/repos/MarkusH/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkusH/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkusH/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkusH/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkusH/django/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkusH/django/languages","stargazers_url":"https://api.github.com/repos/MarkusH/django/stargazers","contributors_url":"https://api.github.com/repos/MarkusH/django/contributors","subscribers_url":"https://api.github.com/repos/MarkusH/django/subscribers","subscription_url":"https://api.github.com/repos/MarkusH/django/subscription","commits_url":"https://api.github.com/repos/MarkusH/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkusH/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkusH/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkusH/django/issues/comments/{number}","contents_url":"https://api.github.com/repos/MarkusH/django/contents/{+path}","compare_url":"https://api.github.com/repos/MarkusH/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkusH/django/merges","archive_url":"https://api.github.com/repos/MarkusH/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkusH/django/downloads","issues_url":"https://api.github.com/repos/MarkusH/django/issues{/number}","pulls_url":"https://api.github.com/repos/MarkusH/django/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkusH/django/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkusH/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkusH/django/labels{/name}","releases_url":"https://api.github.com/repos/MarkusH/django/releases{/id}","created_at":"2013-03-23T10:08:17Z","updated_at":"2014-11-24T12:41:39Z","pushed_at":"2014-12-06T15:27:22Z","git_url":"git://github.com/MarkusH/django.git","ssh_url":"git@github.com:MarkusH/django.git","clone_url":"https://github.com/MarkusH/django.git","svn_url":"https://github.com/MarkusH/django","homepage":"http://www.djangoproject.com/","size":109820,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"34a06d99e0fc96a0f0648bfde141d342e963e971","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments/{number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","created_at":"2012-04-28T02:47:18Z","updated_at":"2014-12-06T18:00:55Z","pushed_at":"2014-12-06T18:00:54Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":230345,"stargazers_count":12114,"watchers_count":12114,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4780,"mirror_url":null,"open_issues_count":89,"forks":4780,"open_issues":89,"watchers":12114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/3687"},"html":{"href":"https://github.com/django/django/pull/3687"},"issue":{"href":"https://api.github.com/repos/django/django/issues/3687"},"comments":{"href":"https://api.github.com/repos/django/django/issues/3687/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/3687/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/3687/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/c631190fad63a90ecfadbd33387d47a258afa924"}}}}