GitHub PullRequestReviewCommentEvent at 2014-09-19 09:59:37
Repository: frontend
Actor: sndrs
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/17777278","id":17777278,"diff_hunk":"@@ -1,95 +1,221 @@\n-.container--facia-cards {\n+$fc-item-gutter: $gs-gutter / 3;\n \n-    $item-gutter: $gs-gutter / 3;\n+@import 'item-layouts/fc-item--standard';\n+@import 'item-layouts/fc-item--list';\n+@import 'item-layouts/fc-item--list-media';\n \n-    .facia-slice__item {\n-        @include flex-display;\n-        padding-bottom: 0;\n+.facia-slice__item {\n+    @include flex-display;\n+    padding-bottom: 0;\n+\n+    @if not $browser-supports-flexbox {\n+        width: 25%;\n+    }\n+}\n \n-        @if not $browser-supports-flexbox {\n-            width: 25%;\n+.fc-item {\n+    @include flex(1);\n+    padding-bottom: $gs-baseline * 2.5;\n+    margin-left: $gs-gutter * .5;\n+    margin-right: $gs-gutter * .5;\n+    background-color: #ffffff;\n+    display: block;\n+    position: relative;\n+\n+    .stars {\n+        margin-top: $gs-baseline * .25;\n+\n+        @include mq(tablet) {\n+            margin-bottom: $gs-baseline * 1.25;\n         }\n     }\n+}\n \n-    .item__header,\n-    .item__standfirst,\n-    .item__meta,\n-    .item__byline {\n-        padding-left: $item-gutter;\n-        padding-right: $item-gutter;\n+.fc-item__image-container {\n+    .js-off & {\n+        display: none;\n     }\n+}\n \n-    .item {\n-        @include flex(1);\n+.fc-item__media-wrapper,\n+.fc-item__image-container {\n+    display: none;\n \n-        padding-left: 0;\n-        padding-right: 0;\n-        padding-bottom: $gs-baseline * 2.5;\n-        margin-left: $gs-gutter * .5;\n-        margin-right: $gs-gutter * .5;\n-        margin-bottom: 0;\n-        background-color: #ffffff;\n+    .fc-item--has-image & {\n+        display: block;\n+\n+        .js-off & {\n+            display: none !important;\n+        }\n+    }\n+}\n+\n+.fc-item__media-wrapper {\n+    position: relative;\n+}\n+\n+.fc-item__header,\n+.fc-item__standfirst,\n+.fc-item__meta {\n+    padding-left: $fc-item-gutter;\n+    padding-right: $fc-item-gutter;\n+}\n+\n+.fc-item__live-indicator {\n+    background-color: #ffffff;\n+    color: $c-live;\n+    font: inherit;\n+    line-height: 1;\n+    text-transform: capitalize;\n+    padding: .1em .2em .05em;\n+}\n+\n+.fc-item__title {\n+    padding-top: $gs-baseline / 3;\n+    padding-bottom: 0;\n+    @include fs-headline(2);\n+    word-wrap: break-word;\n+}\n+\n+.fc-item__byline {\n+    margin-bottom: 0;\n+}\n+\n+.fc-item__standfirst {\n+    @include fs-bodyCopy(1);\n+    display: none;\n+}\n+\n+.fc-item__meta {\n+    position: absolute;\n+    bottom: 0;\n+    padding-top: $gs-baseline / 3;\n+    padding-bottom: $gs-baseline / 3;\n+    @include fs-textSans(1);\n+}\n+\n+.fc-item__timestamp,\n+.fc-trail__count {\n+    position: relative;\n+    float: left;\n+}\n+\n+.fc-item__timestamp {\n+    // this looks weird, commenting out before removing later\n+    // min-width: 50px - $gs-gutter / 2 - 14px;\n+    display: none;\n+}\n+\n+.fc-trail__count {\n+    &--inline-template {","path":"common/app/assets/stylesheets/module/facia-cards/_items.scss","position":132,"original_position":132,"commit_id":"6e22a9ec4d77f325e012ac1895e94219ec44b530","original_commit_id":"6e22a9ec4d77f325e012ac1895e94219ec44b530","user":{"login":"sndrs","id":867233,"avatar_url":"https://avatars.githubusercontent.com/u/867233?v=2","gravatar_id":"c711567c6f417313d32fef1aada043a0","url":"https://api.github.com/users/sndrs","html_url":"https://github.com/sndrs","followers_url":"https://api.github.com/users/sndrs/followers","following_url":"https://api.github.com/users/sndrs/following{/other_user}","gists_url":"https://api.github.com/users/sndrs/gists{/gist_id}","starred_url":"https://api.github.com/users/sndrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sndrs/subscriptions","organizations_url":"https://api.github.com/users/sndrs/orgs","repos_url":"https://api.github.com/users/sndrs/repos","events_url":"https://api.github.com/users/sndrs/events{/privacy}","received_events_url":"https://api.github.com/users/sndrs/received_events","type":"User","site_admin":false},"body":"yeah it’s nifty - but in retrospect it makes the modifier selector very hard to find in a search of the code base. I’m going to ditch it...","created_at":"2014-09-19T09:59:37Z","updated_at":"2014-09-19T09:59:37Z","html_url":"https://github.com/guardian/frontend/pull/6024#discussion_r17777278","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/6024","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/17777278"},"html":{"href":"https://github.com/guardian/frontend/pull/6024#discussion_r17777278"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6024"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/6024","id":21451375,"html_url":"https://github.com/guardian/frontend/pull/6024","diff_url":"https://github.com/guardian/frontend/pull/6024.diff","patch_url":"https://github.com/guardian/frontend/pull/6024.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/6024","number":6024,"state":"open","locked":false,"title":"Facia cards 2.0","user":{"login":"sndrs","id":867233,"avatar_url":"https://avatars.githubusercontent.com/u/867233?v=2","gravatar_id":"c711567c6f417313d32fef1aada043a0","url":"https://api.github.com/users/sndrs","html_url":"https://github.com/sndrs","followers_url":"https://api.github.com/users/sndrs/followers","following_url":"https://api.github.com/users/sndrs/following{/other_user}","gists_url":"https://api.github.com/users/sndrs/gists{/gist_id}","starred_url":"https://api.github.com/users/sndrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sndrs/subscriptions","organizations_url":"https://api.github.com/users/sndrs/orgs","repos_url":"https://api.github.com/users/sndrs/repos","events_url":"https://api.github.com/users/sndrs/events{/privacy}","received_events_url":"https://api.github.com/users/sndrs/received_events","type":"User","site_admin":false},"body":"First container under new container regime:\r\n\r\n1. `fc-` prefix keeps new code separate from incumbent containers. adds temporary bloat but means the old stuff can be safely retired at a later date\r\n2. presentation logic has been moved from templates/css into new slice scala modelling \r\n\r\ntodo:\r\n- remove old `standard`/`list` templates into single `item` template\r\n- large media list (50% image width)","created_at":"2014-09-18T18:04:16Z","updated_at":"2014-09-19T09:59:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c187f8a7b7c7ad66d61ff883fb9c764f0c7405f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/6024/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/6024/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/6024/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/6e22a9ec4d77f325e012ac1895e94219ec44b530","head":{"label":"guardian:facia-cards-2.0","ref":"facia-cards-2.0","sha":"6e22a9ec4d77f325e012ac1895e94219ec44b530","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-09-18T22:26:39Z","pushed_at":"2014-09-19T09:43:56Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":471556,"stargazers_count":2315,"watchers_count":2315,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":196,"mirror_url":null,"open_issues_count":74,"forks":196,"open_issues":74,"watchers":2315,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"de3452bebd986a7e1bac93c5d9d101f5f07e5b71","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"2ddf2e74b78084fcf451b3cdeb075e73","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-09-18T22:26:39Z","pushed_at":"2014-09-19T09:43:56Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":471556,"stargazers_count":2315,"watchers_count":2315,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":196,"mirror_url":null,"open_issues_count":74,"forks":196,"open_issues":74,"watchers":2315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6024"},"html":{"href":"https://github.com/guardian/frontend/pull/6024"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/6024"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/6024/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6024/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6024/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/6e22a9ec4d77f325e012ac1895e94219ec44b530"}}}}