GitHub PullRequestReviewCommentEvent at 2014-09-03 17:09:26
Repository: docker-consul
Actor: binocarlos
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/progrium/docker-consul/pulls/comments/17063828","id":17063828,"diff_hunk":"@@ -112,7 +112,7 @@ That's it! Once this last node connects, it will bootstrap into a cluster. You n\n \n #### Runner command\n \n-Since the `docker run` command to start in production is so long, a command is available to generate this for you. Running with `cmd:run <advertise-ip>[::<join-ip>] [docker-run-args...]` will output an opinionated, but customizable `docker run` command you can run in a subshell. For example:\n+Since the `docker run` command to start in production is so long, a command is available to generate this for you. Running with `cmd:run <advertise-ip>[::<join-ip>[::<client-flag>]] [docker-run-args...]` will output an opinionated, but customizable `docker run` command you can run in a subshell. For example:","path":"README.md","position":5,"original_position":5,"commit_id":"4991702155c272ecbff5be0e58b403935dacad1e","original_commit_id":"4991702155c272ecbff5be0e58b403935dacad1e","user":{"login":"binocarlos","id":1676629,"avatar_url":"https://avatars.githubusercontent.com/u/1676629?v=2","gravatar_id":"296076a892f3a89a1d3142fc8fdcd232","url":"https://api.github.com/users/binocarlos","html_url":"https://github.com/binocarlos","followers_url":"https://api.github.com/users/binocarlos/followers","following_url":"https://api.github.com/users/binocarlos/following{/other_user}","gists_url":"https://api.github.com/users/binocarlos/gists{/gist_id}","starred_url":"https://api.github.com/users/binocarlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binocarlos/subscriptions","organizations_url":"https://api.github.com/users/binocarlos/orgs","repos_url":"https://api.github.com/users/binocarlos/repos","events_url":"https://api.github.com/users/binocarlos/events{/privacy}","received_events_url":"https://api.github.com/users/binocarlos/received_events","type":"User","site_admin":false},"body":"Right - that makes a lot of sense - I will make a small PR just now and thank you for my learn a thing each day item :)\r\n\r\n\r\n\r\n\r\n","created_at":"2014-09-03T17:09:26Z","updated_at":"2014-09-03T17:09:26Z","html_url":"https://github.com/progrium/docker-consul/pull/15#discussion_r17063828","pull_request_url":"https://api.github.com/repos/progrium/docker-consul/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/progrium/docker-consul/pulls/comments/17063828"},"html":{"href":"https://github.com/progrium/docker-consul/pull/15#discussion_r17063828"},"pull_request":{"href":"https://api.github.com/repos/progrium/docker-consul/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/progrium/docker-consul/pulls/15","id":20670289,"html_url":"https://github.com/progrium/docker-consul/pull/15","diff_url":"https://github.com/progrium/docker-consul/pull/15.diff","patch_url":"https://github.com/progrium/docker-consul/pull/15.patch","issue_url":"https://api.github.com/repos/progrium/docker-consul/issues/15","number":15,"state":"closed","locked":false,"title":"client flag for cmd::run","user":{"login":"binocarlos","id":1676629,"avatar_url":"https://avatars.githubusercontent.com/u/1676629?v=2","gravatar_id":"296076a892f3a89a1d3142fc8fdcd232","url":"https://api.github.com/users/binocarlos","html_url":"https://github.com/binocarlos","followers_url":"https://api.github.com/users/binocarlos/followers","following_url":"https://api.github.com/users/binocarlos/following{/other_user}","gists_url":"https://api.github.com/users/binocarlos/gists{/gist_id}","starred_url":"https://api.github.com/users/binocarlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binocarlos/subscriptions","organizations_url":"https://api.github.com/users/binocarlos/orgs","repos_url":"https://api.github.com/users/binocarlos/repos","events_url":"https://api.github.com/users/binocarlos/events{/privacy}","received_events_url":"https://api.github.com/users/binocarlos/received_events","type":"User","site_admin":false},"body":"This introduces a ::client flag for when booting nodes in client mode.\r\n\r\nI've added a note in the Readme about how to use it - let me know if you want that changed to different wording etc.\r\n\r\ncloses #14 ","created_at":"2014-09-03T11:23:41Z","updated_at":"2014-09-03T17:09:26Z","closed_at":"2014-09-03T16:45:41Z","merged_at":"2014-09-03T16:45:41Z","merge_commit_sha":"91de7a3ff6f4ae85fd6de0249126bde63a26dc7f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/progrium/docker-consul/pulls/15/commits","review_comments_url":"https://api.github.com/repos/progrium/docker-consul/pulls/15/comments","review_comment_url":"https://api.github.com/repos/progrium/docker-consul/pulls/comments/{number}","comments_url":"https://api.github.com/repos/progrium/docker-consul/issues/15/comments","statuses_url":"https://api.github.com/repos/progrium/docker-consul/statuses/4991702155c272ecbff5be0e58b403935dacad1e","head":{"label":"binocarlos:master","ref":"master","sha":"4991702155c272ecbff5be0e58b403935dacad1e","user":{"login":"binocarlos","id":1676629,"avatar_url":"https://avatars.githubusercontent.com/u/1676629?v=2","gravatar_id":"296076a892f3a89a1d3142fc8fdcd232","url":"https://api.github.com/users/binocarlos","html_url":"https://github.com/binocarlos","followers_url":"https://api.github.com/users/binocarlos/followers","following_url":"https://api.github.com/users/binocarlos/following{/other_user}","gists_url":"https://api.github.com/users/binocarlos/gists{/gist_id}","starred_url":"https://api.github.com/users/binocarlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binocarlos/subscriptions","organizations_url":"https://api.github.com/users/binocarlos/orgs","repos_url":"https://api.github.com/users/binocarlos/repos","events_url":"https://api.github.com/users/binocarlos/events{/privacy}","received_events_url":"https://api.github.com/users/binocarlos/received_events","type":"User","site_admin":false},"repo":{"id":23595471,"name":"docker-consul","full_name":"binocarlos/docker-consul","owner":{"login":"binocarlos","id":1676629,"avatar_url":"https://avatars.githubusercontent.com/u/1676629?v=2","gravatar_id":"296076a892f3a89a1d3142fc8fdcd232","url":"https://api.github.com/users/binocarlos","html_url":"https://github.com/binocarlos","followers_url":"https://api.github.com/users/binocarlos/followers","following_url":"https://api.github.com/users/binocarlos/following{/other_user}","gists_url":"https://api.github.com/users/binocarlos/gists{/gist_id}","starred_url":"https://api.github.com/users/binocarlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binocarlos/subscriptions","organizations_url":"https://api.github.com/users/binocarlos/orgs","repos_url":"https://api.github.com/users/binocarlos/repos","events_url":"https://api.github.com/users/binocarlos/events{/privacy}","received_events_url":"https://api.github.com/users/binocarlos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/binocarlos/docker-consul","description":"Dockerized Consul Agent","fork":true,"url":"https://api.github.com/repos/binocarlos/docker-consul","forks_url":"https://api.github.com/repos/binocarlos/docker-consul/forks","keys_url":"https://api.github.com/repos/binocarlos/docker-consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binocarlos/docker-consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binocarlos/docker-consul/teams","hooks_url":"https://api.github.com/repos/binocarlos/docker-consul/hooks","issue_events_url":"https://api.github.com/repos/binocarlos/docker-consul/issues/events{/number}","events_url":"https://api.github.com/repos/binocarlos/docker-consul/events","assignees_url":"https://api.github.com/repos/binocarlos/docker-consul/assignees{/user}","branches_url":"https://api.github.com/repos/binocarlos/docker-consul/branches{/branch}","tags_url":"https://api.github.com/repos/binocarlos/docker-consul/tags","blobs_url":"https://api.github.com/repos/binocarlos/docker-consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binocarlos/docker-consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binocarlos/docker-consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/binocarlos/docker-consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binocarlos/docker-consul/statuses/{sha}","languages_url":"https://api.github.com/repos/binocarlos/docker-consul/languages","stargazers_url":"https://api.github.com/repos/binocarlos/docker-consul/stargazers","contributors_url":"https://api.github.com/repos/binocarlos/docker-consul/contributors","subscribers_url":"https://api.github.com/repos/binocarlos/docker-consul/subscribers","subscription_url":"https://api.github.com/repos/binocarlos/docker-consul/subscription","commits_url":"https://api.github.com/repos/binocarlos/docker-consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/binocarlos/docker-consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/binocarlos/docker-consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/binocarlos/docker-consul/issues/comments/{number}","contents_url":"https://api.github.com/repos/binocarlos/docker-consul/contents/{+path}","compare_url":"https://api.github.com/repos/binocarlos/docker-consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binocarlos/docker-consul/merges","archive_url":"https://api.github.com/repos/binocarlos/docker-consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binocarlos/docker-consul/downloads","issues_url":"https://api.github.com/repos/binocarlos/docker-consul/issues{/number}","pulls_url":"https://api.github.com/repos/binocarlos/docker-consul/pulls{/number}","milestones_url":"https://api.github.com/repos/binocarlos/docker-consul/milestones{/number}","notifications_url":"https://api.github.com/repos/binocarlos/docker-consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binocarlos/docker-consul/labels{/name}","releases_url":"https://api.github.com/repos/binocarlos/docker-consul/releases{/id}","created_at":"2014-09-02T21:03:08Z","updated_at":"2014-09-03T11:16:52Z","pushed_at":"2014-09-03T11:16:51Z","git_url":"git://github.com/binocarlos/docker-consul.git","ssh_url":"git@github.com:binocarlos/docker-consul.git","clone_url":"https://github.com/binocarlos/docker-consul.git","svn_url":"https://github.com/binocarlos/docker-consul","homepage":"","size":376,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"progrium:master","ref":"master","sha":"1e81d39cbe75d7678f1b8a890a17c6e0037edc96","user":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=2","gravatar_id":"bb46488d2c90d51f366cafc776e2b3ad","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"repo":{"id":20207362,"name":"docker-consul","full_name":"progrium/docker-consul","owner":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=2","gravatar_id":"bb46488d2c90d51f366cafc776e2b3ad","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/progrium/docker-consul","description":"Dockerized Consul Agent","fork":false,"url":"https://api.github.com/repos/progrium/docker-consul","forks_url":"https://api.github.com/repos/progrium/docker-consul/forks","keys_url":"https://api.github.com/repos/progrium/docker-consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/progrium/docker-consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/progrium/docker-consul/teams","hooks_url":"https://api.github.com/repos/progrium/docker-consul/hooks","issue_events_url":"https://api.github.com/repos/progrium/docker-consul/issues/events{/number}","events_url":"https://api.github.com/repos/progrium/docker-consul/events","assignees_url":"https://api.github.com/repos/progrium/docker-consul/assignees{/user}","branches_url":"https://api.github.com/repos/progrium/docker-consul/branches{/branch}","tags_url":"https://api.github.com/repos/progrium/docker-consul/tags","blobs_url":"https://api.github.com/repos/progrium/docker-consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/progrium/docker-consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/progrium/docker-consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/progrium/docker-consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/progrium/docker-consul/statuses/{sha}","languages_url":"https://api.github.com/repos/progrium/docker-consul/languages","stargazers_url":"https://api.github.com/repos/progrium/docker-consul/stargazers","contributors_url":"https://api.github.com/repos/progrium/docker-consul/contributors","subscribers_url":"https://api.github.com/repos/progrium/docker-consul/subscribers","subscription_url":"https://api.github.com/repos/progrium/docker-consul/subscription","commits_url":"https://api.github.com/repos/progrium/docker-consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/progrium/docker-consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/progrium/docker-consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/progrium/docker-consul/issues/comments/{number}","contents_url":"https://api.github.com/repos/progrium/docker-consul/contents/{+path}","compare_url":"https://api.github.com/repos/progrium/docker-consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/progrium/docker-consul/merges","archive_url":"https://api.github.com/repos/progrium/docker-consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/progrium/docker-consul/downloads","issues_url":"https://api.github.com/repos/progrium/docker-consul/issues{/number}","pulls_url":"https://api.github.com/repos/progrium/docker-consul/pulls{/number}","milestones_url":"https://api.github.com/repos/progrium/docker-consul/milestones{/number}","notifications_url":"https://api.github.com/repos/progrium/docker-consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/progrium/docker-consul/labels{/name}","releases_url":"https://api.github.com/repos/progrium/docker-consul/releases{/id}","created_at":"2014-05-27T04:48:58Z","updated_at":"2014-09-02T07:43:46Z","pushed_at":"2014-09-03T16:45:41Z","git_url":"git://github.com/progrium/docker-consul.git","ssh_url":"git@github.com:progrium/docker-consul.git","clone_url":"https://github.com/progrium/docker-consul.git","svn_url":"https://github.com/progrium/docker-consul","homepage":"","size":376,"stargazers_count":234,"watchers_count":234,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":17,"mirror_url":null,"open_issues_count":2,"forks":17,"open_issues":2,"watchers":234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/progrium/docker-consul/pulls/15"},"html":{"href":"https://github.com/progrium/docker-consul/pull/15"},"issue":{"href":"https://api.github.com/repos/progrium/docker-consul/issues/15"},"comments":{"href":"https://api.github.com/repos/progrium/docker-consul/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/progrium/docker-consul/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/progrium/docker-consul/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/progrium/docker-consul/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/progrium/docker-consul/statuses/4991702155c272ecbff5be0e58b403935dacad1e"}}}}