GitHub PullRequestReviewCommentEvent at 2014-11-06 21:31:02
Repository: tailf
Actor: thomaso-mirodin
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/aybabtme/tailf/pulls/comments/19976850","id":19976850,"diff_hunk":"@@ -108,7 +103,8 @@ func (f *follower) Close() error {\n \n func (f *follower) Read(b []byte) (int, error) {\n \tf.mu.Lock()\n-\treadable := f.maxSize - f.offset\n+\t_, _ = f.reader.Peek(1) // Force a buffer fill if need be, success or failure doesn't mater","path":"tailf.go","position":71,"original_position":71,"commit_id":"903e8bf8a8cdc423accfba4616b325a62701a2b5","original_commit_id":"4bc0d6fd46f859af29c4de0bddd2c3c52ce224cb","user":{"login":"thomaso-mirodin","id":681004,"avatar_url":"https://avatars.githubusercontent.com/u/681004?v=2","gravatar_id":"","url":"https://api.github.com/users/thomaso-mirodin","html_url":"https://github.com/thomaso-mirodin","followers_url":"https://api.github.com/users/thomaso-mirodin/followers","following_url":"https://api.github.com/users/thomaso-mirodin/following{/other_user}","gists_url":"https://api.github.com/users/thomaso-mirodin/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaso-mirodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaso-mirodin/subscriptions","organizations_url":"https://api.github.com/users/thomaso-mirodin/orgs","repos_url":"https://api.github.com/users/thomaso-mirodin/repos","events_url":"https://api.github.com/users/thomaso-mirodin/events{/privacy}","received_events_url":"https://api.github.com/users/thomaso-mirodin/received_events","type":"User","site_admin":false},"body":"That... is a good point, fix incoming","created_at":"2014-11-06T21:31:02Z","updated_at":"2014-11-06T21:31:02Z","html_url":"https://github.com/aybabtme/tailf/pull/2#discussion_r19976850","pull_request_url":"https://api.github.com/repos/aybabtme/tailf/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/aybabtme/tailf/pulls/comments/19976850"},"html":{"href":"https://github.com/aybabtme/tailf/pull/2#discussion_r19976850"},"pull_request":{"href":"https://api.github.com/repos/aybabtme/tailf/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/aybabtme/tailf/pulls/2","id":23965291,"html_url":"https://github.com/aybabtme/tailf/pull/2","diff_url":"https://github.com/aybabtme/tailf/pull/2.diff","patch_url":"https://github.com/aybabtme/tailf/pull/2.patch","issue_url":"https://api.github.com/repos/aybabtme/tailf/issues/2","number":2,"state":"open","locked":false,"title":"Fix for timing issue in follower.Read","user":{"login":"thomaso-mirodin","id":681004,"avatar_url":"https://avatars.githubusercontent.com/u/681004?v=2","gravatar_id":"","url":"https://api.github.com/users/thomaso-mirodin","html_url":"https://github.com/thomaso-mirodin","followers_url":"https://api.github.com/users/thomaso-mirodin/followers","following_url":"https://api.github.com/users/thomaso-mirodin/following{/other_user}","gists_url":"https://api.github.com/users/thomaso-mirodin/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaso-mirodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaso-mirodin/subscriptions","organizations_url":"https://api.github.com/users/thomaso-mirodin/orgs","repos_url":"https://api.github.com/users/thomaso-mirodin/repos","events_url":"https://api.github.com/users/thomaso-mirodin/events{/privacy}","received_events_url":"https://api.github.com/users/thomaso-mirodin/received_events","type":"User","site_admin":false},"body":"In the Read method, a file could be truncated or move in between when it was os.Stat'd for its maxSize and when it is actually read. This was causing errors when the file would shrink before it was read, because unexpected EOFs were occurring :D\r\n\r\nTo avoid that problem, I thought it would be safer make the reads occur on a bufio.Reader so its operating on a known amount of data in memory, rather than an unknown quantity on disk. ","created_at":"2014-11-06T08:28:37Z","updated_at":"2014-11-06T21:31:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"372ad26b2a384c8981808ed5dd4b75e0ee9d868e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aybabtme/tailf/pulls/2/commits","review_comments_url":"https://api.github.com/repos/aybabtme/tailf/pulls/2/comments","review_comment_url":"https://api.github.com/repos/aybabtme/tailf/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aybabtme/tailf/issues/2/comments","statuses_url":"https://api.github.com/repos/aybabtme/tailf/statuses/903e8bf8a8cdc423accfba4616b325a62701a2b5","head":{"label":"thomaso-mirodin:bufio_rewrite","ref":"bufio_rewrite","sha":"903e8bf8a8cdc423accfba4616b325a62701a2b5","user":{"login":"thomaso-mirodin","id":681004,"avatar_url":"https://avatars.githubusercontent.com/u/681004?v=2","gravatar_id":"","url":"https://api.github.com/users/thomaso-mirodin","html_url":"https://github.com/thomaso-mirodin","followers_url":"https://api.github.com/users/thomaso-mirodin/followers","following_url":"https://api.github.com/users/thomaso-mirodin/following{/other_user}","gists_url":"https://api.github.com/users/thomaso-mirodin/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaso-mirodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaso-mirodin/subscriptions","organizations_url":"https://api.github.com/users/thomaso-mirodin/orgs","repos_url":"https://api.github.com/users/thomaso-mirodin/repos","events_url":"https://api.github.com/users/thomaso-mirodin/events{/privacy}","received_events_url":"https://api.github.com/users/thomaso-mirodin/received_events","type":"User","site_admin":false},"repo":{"id":26247490,"name":"tailf","full_name":"thomaso-mirodin/tailf","owner":{"login":"thomaso-mirodin","id":681004,"avatar_url":"https://avatars.githubusercontent.com/u/681004?v=2","gravatar_id":"","url":"https://api.github.com/users/thomaso-mirodin","html_url":"https://github.com/thomaso-mirodin","followers_url":"https://api.github.com/users/thomaso-mirodin/followers","following_url":"https://api.github.com/users/thomaso-mirodin/following{/other_user}","gists_url":"https://api.github.com/users/thomaso-mirodin/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaso-mirodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaso-mirodin/subscriptions","organizations_url":"https://api.github.com/users/thomaso-mirodin/orgs","repos_url":"https://api.github.com/users/thomaso-mirodin/repos","events_url":"https://api.github.com/users/thomaso-mirodin/events{/privacy}","received_events_url":"https://api.github.com/users/thomaso-mirodin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomaso-mirodin/tailf","description":"Read and follow subsequent writes to a file. Like tailf.","fork":true,"url":"https://api.github.com/repos/thomaso-mirodin/tailf","forks_url":"https://api.github.com/repos/thomaso-mirodin/tailf/forks","keys_url":"https://api.github.com/repos/thomaso-mirodin/tailf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomaso-mirodin/tailf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomaso-mirodin/tailf/teams","hooks_url":"https://api.github.com/repos/thomaso-mirodin/tailf/hooks","issue_events_url":"https://api.github.com/repos/thomaso-mirodin/tailf/issues/events{/number}","events_url":"https://api.github.com/repos/thomaso-mirodin/tailf/events","assignees_url":"https://api.github.com/repos/thomaso-mirodin/tailf/assignees{/user}","branches_url":"https://api.github.com/repos/thomaso-mirodin/tailf/branches{/branch}","tags_url":"https://api.github.com/repos/thomaso-mirodin/tailf/tags","blobs_url":"https://api.github.com/repos/thomaso-mirodin/tailf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomaso-mirodin/tailf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomaso-mirodin/tailf/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomaso-mirodin/tailf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomaso-mirodin/tailf/statuses/{sha}","languages_url":"https://api.github.com/repos/thomaso-mirodin/tailf/languages","stargazers_url":"https://api.github.com/repos/thomaso-mirodin/tailf/stargazers","contributors_url":"https://api.github.com/repos/thomaso-mirodin/tailf/contributors","subscribers_url":"https://api.github.com/repos/thomaso-mirodin/tailf/subscribers","subscription_url":"https://api.github.com/repos/thomaso-mirodin/tailf/subscription","commits_url":"https://api.github.com/repos/thomaso-mirodin/tailf/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomaso-mirodin/tailf/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomaso-mirodin/tailf/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomaso-mirodin/tailf/issues/comments/{number}","contents_url":"https://api.github.com/repos/thomaso-mirodin/tailf/contents/{+path}","compare_url":"https://api.github.com/repos/thomaso-mirodin/tailf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomaso-mirodin/tailf/merges","archive_url":"https://api.github.com/repos/thomaso-mirodin/tailf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomaso-mirodin/tailf/downloads","issues_url":"https://api.github.com/repos/thomaso-mirodin/tailf/issues{/number}","pulls_url":"https://api.github.com/repos/thomaso-mirodin/tailf/pulls{/number}","milestones_url":"https://api.github.com/repos/thomaso-mirodin/tailf/milestones{/number}","notifications_url":"https://api.github.com/repos/thomaso-mirodin/tailf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomaso-mirodin/tailf/labels{/name}","releases_url":"https://api.github.com/repos/thomaso-mirodin/tailf/releases{/id}","created_at":"2014-11-06T01:07:59Z","updated_at":"2014-11-06T09:18:34Z","pushed_at":"2014-11-06T21:24:22Z","git_url":"git://github.com/thomaso-mirodin/tailf.git","ssh_url":"git@github.com:thomaso-mirodin/tailf.git","clone_url":"https://github.com/thomaso-mirodin/tailf.git","svn_url":"https://github.com/thomaso-mirodin/tailf","homepage":"","size":156,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"aybabtme:master","ref":"master","sha":"85cc246d140aa668ddd9094c82c432880b31573b","user":{"login":"aybabtme","id":1189716,"avatar_url":"https://avatars.githubusercontent.com/u/1189716?v=2","gravatar_id":"","url":"https://api.github.com/users/aybabtme","html_url":"https://github.com/aybabtme","followers_url":"https://api.github.com/users/aybabtme/followers","following_url":"https://api.github.com/users/aybabtme/following{/other_user}","gists_url":"https://api.github.com/users/aybabtme/gists{/gist_id}","starred_url":"https://api.github.com/users/aybabtme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aybabtme/subscriptions","organizations_url":"https://api.github.com/users/aybabtme/orgs","repos_url":"https://api.github.com/users/aybabtme/repos","events_url":"https://api.github.com/users/aybabtme/events{/privacy}","received_events_url":"https://api.github.com/users/aybabtme/received_events","type":"User","site_admin":false},"repo":{"id":25442122,"name":"tailf","full_name":"aybabtme/tailf","owner":{"login":"aybabtme","id":1189716,"avatar_url":"https://avatars.githubusercontent.com/u/1189716?v=2","gravatar_id":"","url":"https://api.github.com/users/aybabtme","html_url":"https://github.com/aybabtme","followers_url":"https://api.github.com/users/aybabtme/followers","following_url":"https://api.github.com/users/aybabtme/following{/other_user}","gists_url":"https://api.github.com/users/aybabtme/gists{/gist_id}","starred_url":"https://api.github.com/users/aybabtme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aybabtme/subscriptions","organizations_url":"https://api.github.com/users/aybabtme/orgs","repos_url":"https://api.github.com/users/aybabtme/repos","events_url":"https://api.github.com/users/aybabtme/events{/privacy}","received_events_url":"https://api.github.com/users/aybabtme/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aybabtme/tailf","description":"Read and follow subsequent writes to a file. Like tailf.","fork":false,"url":"https://api.github.com/repos/aybabtme/tailf","forks_url":"https://api.github.com/repos/aybabtme/tailf/forks","keys_url":"https://api.github.com/repos/aybabtme/tailf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aybabtme/tailf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aybabtme/tailf/teams","hooks_url":"https://api.github.com/repos/aybabtme/tailf/hooks","issue_events_url":"https://api.github.com/repos/aybabtme/tailf/issues/events{/number}","events_url":"https://api.github.com/repos/aybabtme/tailf/events","assignees_url":"https://api.github.com/repos/aybabtme/tailf/assignees{/user}","branches_url":"https://api.github.com/repos/aybabtme/tailf/branches{/branch}","tags_url":"https://api.github.com/repos/aybabtme/tailf/tags","blobs_url":"https://api.github.com/repos/aybabtme/tailf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aybabtme/tailf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aybabtme/tailf/git/refs{/sha}","trees_url":"https://api.github.com/repos/aybabtme/tailf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aybabtme/tailf/statuses/{sha}","languages_url":"https://api.github.com/repos/aybabtme/tailf/languages","stargazers_url":"https://api.github.com/repos/aybabtme/tailf/stargazers","contributors_url":"https://api.github.com/repos/aybabtme/tailf/contributors","subscribers_url":"https://api.github.com/repos/aybabtme/tailf/subscribers","subscription_url":"https://api.github.com/repos/aybabtme/tailf/subscription","commits_url":"https://api.github.com/repos/aybabtme/tailf/commits{/sha}","git_commits_url":"https://api.github.com/repos/aybabtme/tailf/git/commits{/sha}","comments_url":"https://api.github.com/repos/aybabtme/tailf/comments{/number}","issue_comment_url":"https://api.github.com/repos/aybabtme/tailf/issues/comments/{number}","contents_url":"https://api.github.com/repos/aybabtme/tailf/contents/{+path}","compare_url":"https://api.github.com/repos/aybabtme/tailf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aybabtme/tailf/merges","archive_url":"https://api.github.com/repos/aybabtme/tailf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aybabtme/tailf/downloads","issues_url":"https://api.github.com/repos/aybabtme/tailf/issues{/number}","pulls_url":"https://api.github.com/repos/aybabtme/tailf/pulls{/number}","milestones_url":"https://api.github.com/repos/aybabtme/tailf/milestones{/number}","notifications_url":"https://api.github.com/repos/aybabtme/tailf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aybabtme/tailf/labels{/name}","releases_url":"https://api.github.com/repos/aybabtme/tailf/releases{/id}","created_at":"2014-10-19T22:26:14Z","updated_at":"2014-11-06T13:28:34Z","pushed_at":"2014-11-06T16:21:55Z","git_url":"git://github.com/aybabtme/tailf.git","ssh_url":"git@github.com:aybabtme/tailf.git","clone_url":"https://github.com/aybabtme/tailf.git","svn_url":"https://github.com/aybabtme/tailf","homepage":"","size":156,"stargazers_count":19,"watchers_count":19,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aybabtme/tailf/pulls/2"},"html":{"href":"https://github.com/aybabtme/tailf/pull/2"},"issue":{"href":"https://api.github.com/repos/aybabtme/tailf/issues/2"},"comments":{"href":"https://api.github.com/repos/aybabtme/tailf/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/aybabtme/tailf/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/aybabtme/tailf/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aybabtme/tailf/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/aybabtme/tailf/statuses/903e8bf8a8cdc423accfba4616b325a62701a2b5"}}}}