GitHub PushEvent at 2014-01-07 16:31:44
Repository: Koha
Actor: fredericd
Payload: {"shas":[["95d96afb54eca86cae327e0a05da05de5a4c7f62","ec70b30b7f2646a69ad76ef1c8908ce7ae37e284@esilibrary.com","Bug 11384: rename the collections_tracking.ctId column\n\n'ctId' as a column name conflicts with one of the system\ncolumns that PostgreSQL uses for each table, and consequently\nneeds to be renamed to enable deploying the schema to a Pg\ndatabase.  This patch makes this change.\n\nTo test:\n\n[1] Apply the patch and run the SQL specified in the database\n    updated.\n[2] Verify that the collections_tracking table no longer has\n    a ctId column, but now has collections_tracking_id.\n[3] Verify that prove -v t/db_dependent/RotatingCollections.t\n    passes.\n[4] Verify that installer/data/mysql/kohastructure.sql runs\n    cleanly in an empty database.\n\nThis patch does not affect user-visible behavior given the fact\nthat the rotating collections feature is currently disabled.\n\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\nSigned-off-by: Jonathan Druart <jonathan.druart@biblibre.com>\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit 5f015d050281a676670b592831f5b1bd11c81f47)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>\n\nConflicts:\n\tinstaller/data/mysql/updatedatabase.pl","Galen Charlton",true],["afc546d9a92a7159bd29f6615a3d48dcc42c3dfb","ec70b30b7f2646a69ad76ef1c8908ce7ae37e284@esilibrary.com","Bug 11384: (follow-up) update DBIC schema classes\n\nThis patch updates the DBIC schema class for CollectionTracking\nto reflect the new name of its primary key column.\n\nTo test:\n\nThe CollectionTracking class is not currently used, but\nif you *really* want to test this, take a look at the following\nbranch: http://git.librarypolice.com/?p=koha-galen.git;a=shortlog;h=refs/heads/pg\n\nThen, set up a PostgreSQL database, update koha-conf.xml to point to it,\nthen run pg/deploy and verify that the collections_tracking table is created\nin the Pg database.\n\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\nSigned-off-by: Jonathan Druart <jonathan.druart@biblibre.com>\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit 7a52759b0f1f48661d357a0738cb68f6cb17edae)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Galen Charlton",true],["808e0f46f2b87036812788b6d32835244607e329","028c9373aaf61b41f9c30e69951b05554a2bb781@biblibre.com","Bug 11384: DBRev 3.14.01.002\n\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Fridolin SOMERS",true],["d69c1a367b79a8f62192994a39c3528e6783b0f9","ec70b30b7f2646a69ad76ef1c8908ce7ae37e284@esilibrary.com","Bug 11391: drop default value on suggestions.suggesteddate column\n\nThe 'default 0' clause got translated as an invalid constant\ndefault of '0000-00-00' when DBIx::Schema is used to deploy\nthe suggestions table into a Pg database.  This patch drops\nthe default.\n\nTo test:\n\n[1] Apply the patch and run the SQL specified in the database\n    updated.\n[2] Verify that the suggestions table no longer has an\n    explicit default value for the suggesteddate column.\n[3] Verify that prove -v t/db_dependent/Suggestions.t\n    passes.\n[4] Verify that installer/data/mysql/kohastructure.sql runs\n    cleanly in an empty database.\n[5] Verify that there are no visible regressions of the\n    purchase suggestions functionality.\n\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\n\nHaving a default of 0 on a date seems like a mad thing to do anyway,\nso good to get rid of it\n\nSigned-off-by: Jonathan Druart <jonathan.druart@biblibre.com>\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit a6b2f6a16175229ba603ed65cfeaf4e0c0a525ce)","Galen Charlton",true],["fa3844440bcd5b2a723de54a19b9392fc0d3051c","ec70b30b7f2646a69ad76ef1c8908ce7ae37e284@esilibrary.com","Bug 11391: (follow-up) update DBIC schema classes\n\nThis patch updates the DBIC schema class for Suggestion\nto reflect the dropped default value for the suggesteddate\ncolumn.\n\nTo test:\n\n[1] Create an empty Pg database and use the deployment script\n    being worked in in bug 11390.  The deployment shoudl\n    succeed without reporting any errors regarding the\n    suggestions table.\n\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\nSigned-off-by: Jonathan Druart <jonathan.druart@biblibre.com>\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit d540016b19bc35e56733e3d2bb36a04bc038e420)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Galen Charlton",true],["a933169ae1188bf259cf95fd8f494f6ae80ab5c3","028c9373aaf61b41f9c30e69951b05554a2bb781@biblibre.com","Bug 11391: DBRev 3.14.01.003\n\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Fridolin SOMERS",true],["e55b3900c7427f28596b70a91ba037e1213e1bf8","c17fae6efc65f6a65b2fa5a19aeea10e9c7067b0@biblibre.com","Bug 6331: remove obsolete column deleteditems.marc\n\nThere is a difference between \"items\" and \"deleteditems\" tables\nin \"kohastructure.sql\"\n\"deleteditems\" has a field \"marc\" not existing in \"items\".\n\nThis patch removes this obsolete column.\n\nTest :\n- after deleting an item, check that the deleted item is properly\n  stored in deleteditems table\n- check that the column marc has been deleted from deleteditems table\n\nSigned-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit e1fb1a658c89ef1356d3b42e264efed71cf81f9f)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Fridolyn SOMERS",true],["574dc07e0dbed1d397d6a6439baee5737a4b127a","8932333a7e2efbb77f7b46533ef60517bbea1420@ptfs-europe.com","Bug 6331: (follow-up) do not populate deleteditems.marc\n\nThis is supplementary to the main patch for\nbug 6331. Having removed the attribute marc from\nitems DelItem, we should not try to populate it.\n\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit 2249ee1216ed004e61a34bc821d216f3471ef87b)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Colin Campbell",true],["d2c9c8837bcf4e1159ee75bdcdc8386d1f394ad7","c17fae6efc65f6a65b2fa5a19aeea10e9c7067b0@biblibre.com","Bug 6331: (follow-up) update timestamp when deleting items\n\nWhen item is transfered from items table to deleted items, all fields\nmust be copies but \"timestamp\".\n\nThis value must be updated to know when the item was deleted.\n\nTest plan:\n- Look a an item timestamp :\nmysql> select timestamp from items where itemnumber = 2690;\n+---------------------+\n| timestamp           |\n+---------------------+\n| 2011-09-09 15:30:21 |\n+---------------------+\n1 row in set (0.00 sec)\n- Delete this item in cataloguing module\n- Check it is not in items table anymore :\nmysql> select timestamp from items where itemnumber = 2690;\nEmpty set (0.00 sec)\n- Look in deleteditems table :\nmysql> select timestamp from deleteditems where itemnumber = 2690;\n+---------------------+\n| timestamp           |\n+---------------------+\n| 2013-12-05 15:33:20 |\n+---------------------+\n1 row in set (0.00 sec)\n=> timestamp as been set to actual date/time\n\nSigned-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\nPatch set passes koha-qa.pl, works as advertised!\n\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit cada676ef3439d2567fa21da415d939f0fc22ee6)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Fridolyn SOMERS",true],["bec64c8274d79fd8add9540d134201cd104fc322","ec70b30b7f2646a69ad76ef1c8908ce7ae37e284@esilibrary.com","Bug 6331: (follow-up) update DBIC schema classes\n\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit e4f846a866d24779ff18634bd1da2e0c00086fe4)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>\n\nConflicts:\n\tKoha/Schema/Result/Deleteditem.pm","Galen Charlton",true],["b19bd4f2a92e7023428cb31d764b133ba4301e44","028c9373aaf61b41f9c30e69951b05554a2bb781@biblibre.com","Bug 6331: DBRev 3.14.01.004\n\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Fridolin SOMERS",true],["fdcf8ab5729edc249019e5593e9d453885bfe36d","495d9e105bca5dd197fea8fdc43290fe27ee1d77@univ-rennes2.fr","Bug 9940: Add a new index for the original language of a document\n\nIt could be useful to index the original language of a document (i.e.\n\"fre\" for the English translation of a French novel).\n\nThis patch renames the Bib-1 use attribute 1095 from\nCode-language-original to language-original and uses it to index:\n\n- MARC21 041$h subfield\n- UNIMARC 101$c subfield\n\nIt adds \"language-original\" in the list of index in Search.pm.\n\nTest plan :\nA. in a MARC21 GRS1 environment\n1. Copy Zebra config files (zebradb/biblios/etc/bib1.att,\n   zebradb/ccl.properties, marc_defs/marc21/biblios/record.abs) from\n   your source etc/ directory to your main koha etc/ directory\n2. Reindex zebra\n3. Make some searches, like \"language-original:fre\"\nB. in a MARC21 DOM environment\n4. Copy Zebra config files (zebradb/biblios/etc/bib1.att, zebradb/ccl.properties,\n   marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl) from your source etc/\n   directory to your main koha etc/ directory\n5. Reindex zebra\n6. Make some searches, like \"language-original:fre\"\nC. in a UNIMARC GRS1 environment\n7. Copy Zebra config files (zebradb/biblios/etc/bib1.att,\n   zebradb/ccl.properties, marc_defs/unimarc/biblios/record.abs) from\n   your source etc/ directory to your main koha etc/ directory\n8. Reindex zebra\n9. Make some searches, like \"language-original:fre\"\nA. in a UNIMARC DOM environment\n10. Copy Zebra config files (zebradb/biblios/etc/bib1.att,\n    zebradb/ccl.properties, marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl)\n    from your source etc/ directory to your main koha etc/ directory\n11. Reindex zebra\n12. Make some searches, like \"language-original:fre\"\n\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\nSigned-off-by: Jonathan Druart <jonathan.druart@biblibre.com>\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit 451f67c05593461d2756a161032c39113d282c25)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Mathieu Saby",true],["e209d4576f821f50e53e1522f765b94df540e15d","90effa772b5c8a7a3420e6b7ea56e265888c5743@biblibre.com","Bug 9940: (follow-up) FIX comment: language-original is 101$c, not $h\n\nSigned-off-by: Jonathan Druart <jonathan.druart@biblibre.com>\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit a573ac1fa8edd13535e2f785750fc5b5f61686aa)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Jonathan Druart",true],["8bd71415f136bfc41cbceaabf3dc066ad8275fc3","ec70b30b7f2646a69ad76ef1c8908ce7ae37e284@esilibrary.com","Bug 9940: (follow-up) add language-original to QP search field list\n\nThis patch adds language-original to the list of search fields\nrecognized by QueryParser.\n\nTo test:\n\n[1] After doing the tests in the main patch, copy the configuration\n    file etc/searchengine/queryparser.yaml into place, turn on the\n    UseQueryParser system preference, and verify that searching on\n    language-original still works.\n\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit e4912a20f9b6f59fb57955777abd1e62d785a1fd)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Galen Charlton",true],["25cbbcff34ae049137ed7a302ebf7b76cd0cf8ab","3c25b01657254677d3e1a8fd1f0742c5d489bd39@bywatersolutions.com","Bug 10834 - Add Sort 1 and Sort 2 to list of searchable patron fields\n\nSome libraries would like to be able to search on the sort1 and sort2\nfields of patron records.\n\nTest Plan:\n1) Apply this patch\n2) Add various values for sort1 and sort2 some patrons\n3) Browse to members-home.pl\n4) Run searches on sort1 and sort2\n\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\nSigned-off-by: Jonathan Druart <jonathan.druart@biblibre.com>\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit 53c4129027f7d996c763da31303173c8b134a67a)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Kyle M Hall",true],["71b9096034cbc68e28d2db7c389ae341bd96e323","9f4ca770b638615ac5c3e0d2da16b77c80c2f2c6@enger.priv.no","Bug 11004: Make xmlControlfield.js use the marcflavour syspref to look for XML files\n\nCurrently, xmlControlfield.js is hard coded to look for XML files for\nMARC21:\n\n  url: this.themelang + \"/data/marc21_field_\" + this.tagfield + \".xml\",\n\nThis patch makes this code use the value from the marcflavour syspref,\nas a preparation for making the NORMARC value builders use the XML\ntechnique employed by the MARC21 value builders for 006 and 008.\n\nTo test:\n- Make sure you have a MARC21 installation\n- Set marcflavour = NORMARC\n- Go to Cataloguing and start a new record with the default framework\n- Open the value builders for 006 and 008 and observe that they still work, showing\n  the coded values for MARC21\n- Apply this patch\n- Check the value builders for 006 and 008 and observe that you get a truncated view\n  with an empty \"Select a type of material\" dropdown\n- Use e.g. the Net console in Firebug to observe requests to\n  http://localhost/intranet-tmpl/prog/en/data/normarc_field_008.xml\n  that result in a 404 status\n- Set marcflavour = MARC21\n- Observe that the value builders for 006 and 008 are now fully working\n- 006 and 008 should be the only value builders affected by this change, since\n  they are the only ones using xmlControlfield.js, but please also verify that\n  other value builders are still working as expected\n\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\nSigned-off-by: Jonathan Druart <jonathan.druart@biblibre.com>\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit 3ec4a02418a9c3372c590b8eb614e8c6466ff45e)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Magnus Enger",true],["c65a5d73a7678cb4757566181d566e903a264aee","ec70b30b7f2646a69ad76ef1c8908ce7ae37e284@esilibrary.com","Bug 11338: add unit tests for DelItemCheck\n\nThis patch adds unit tests for two parts of DelItemCheck: checking\nif the item is on loan, and checking if it is waiting on the hold\nshelf.\n\nTo test:\n\n[1] Verify that prove -v t/db_dependent/Circulation/IsItemIssued.t\n    is successful.\n[2] Verify that prove -v t/db_dependent/Reserves.t is *not*\n    successful -- as it turns out, there was a latent bug where items\n    waiting on the hold shelf or in transit to fill a hold could still\n    be deleted without any warning.\n\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit 18888359b6744a1e65e34649c927e7c146f628f8)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Galen Charlton",true],["87cd69d35158869e27cfa310cf41d2f2f144f214","c17fae6efc65f6a65b2fa5a19aeea10e9c7067b0@biblibre.com","Bug 11338: prevent deletion of items that are captured for holds\n\nIn C4::Items::DelItemCheck, there are two SQL queries: one to check\nif item is on loan, the other if item is reserved.\n\nThose two queries use \"SELECT * FROM table\", fetch the data with\n\"$var = $sth->fetchrow\", and use \"$var\" as a boolean condition.\n\nThis is not correct, SQL query should be \"SELECT COUNT(*) FROM table\".\n\nAs a consequence, it was possible to delete an item without warning to\nthe operator even if it was waiting on the hold shelf or in transit to\nfill a hold.\n\nThis patch corrects the SQL queries and sets my ($var) to show that\nfetchrow returns an array.\n\nTest plan :\n- Set an item A onloan\n- Set an item B reserved and the reserve waiting\n- Go to items cataloguing : cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXX\n- Try to delete item A\n=> You get an alert and item is not deleted\n- Try to delete item B\n=> You get an alert and item is not deleted\n\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\n\nWorks, and has the added bonus of being a tiny bit faster.\n\nSigned-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>\nPasses t, xt and QA script tests.\nAlso tried deleting via batch delete - correct warnings are displayed.\n\nSigned-off-by: Galen Charlton <gmc@esilibrary.com>\n(cherry picked from commit d000a716352fb61dc0dae7715eda15896b53b4e7)\nSigned-off-by: Fridolin SOMERS <fridolin.somers@biblibre.com>","Fridolyn SOMERS",true]],"size":18,"ref":"refs/heads/3.14.x","head":"87cd69d35158869e27cfa310cf41d2f2f144f214"}