GitHub PullRequestReviewCommentEvent at 2014-09-25 16:06:36
Repository: symfony
Actor: jeremy-derusse
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/18041345","id":18041345,"diff_hunk":"@@ -0,0 +1,23 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony package.\n+ *\n+ * (c) Fabien Potencier <fabien@symfony.com>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Component\\Console\\Helper\\Formatter;\n+\n+/**\n+ * @author Kevin Bond <kevinbond@gmail.com>\n+ */\n+interface FormatterInterface\n+{\n+    /**\n+     * @return array|string","path":"src/Symfony/Component/Console/Helper/Formatter/FormatterInterface.php","position":20,"original_position":20,"commit_id":"57cc112c91971b581645736b5fbcf81c355fc268","original_commit_id":"57cc112c91971b581645736b5fbcf81c355fc268","user":{"login":"jeremy-derusse","id":578547,"avatar_url":"https://avatars.githubusercontent.com/u/578547?v=2","gravatar_id":"","url":"https://api.github.com/users/jeremy-derusse","html_url":"https://github.com/jeremy-derusse","followers_url":"https://api.github.com/users/jeremy-derusse/followers","following_url":"https://api.github.com/users/jeremy-derusse/following{/other_user}","gists_url":"https://api.github.com/users/jeremy-derusse/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremy-derusse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremy-derusse/subscriptions","organizations_url":"https://api.github.com/users/jeremy-derusse/orgs","repos_url":"https://api.github.com/users/jeremy-derusse/repos","events_url":"https://api.github.com/users/jeremy-derusse/events{/privacy}","received_events_url":"https://api.github.com/users/jeremy-derusse/received_events","type":"User","site_admin":false},"body":"Why? It would be easier if the method always works with array or string instead of both","created_at":"2014-09-25T16:06:36Z","updated_at":"2014-09-25T16:06:36Z","html_url":"https://github.com/symfony/symfony/pull/12035#discussion_r18041345","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/12035","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/18041345"},"html":{"href":"https://github.com/symfony/symfony/pull/12035#discussion_r18041345"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12035"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/12035","id":21777060,"html_url":"https://github.com/symfony/symfony/pull/12035","diff_url":"https://github.com/symfony/symfony/pull/12035.diff","patch_url":"https://github.com/symfony/symfony/pull/12035.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/12035","number":12035,"state":"open","locked":false,"title":"[RFC][Console] Added console style guide helpers","user":{"login":"kbond","id":127811,"avatar_url":"https://avatars.githubusercontent.com/u/127811?v=2","gravatar_id":"","url":"https://api.github.com/users/kbond","html_url":"https://github.com/kbond","followers_url":"https://api.github.com/users/kbond/followers","following_url":"https://api.github.com/users/kbond/following{/other_user}","gists_url":"https://api.github.com/users/kbond/gists{/gist_id}","starred_url":"https://api.github.com/users/kbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbond/subscriptions","organizations_url":"https://api.github.com/users/kbond/orgs","repos_url":"https://api.github.com/users/kbond/repos","events_url":"https://api.github.com/users/kbond/events{/privacy}","received_events_url":"https://api.github.com/users/kbond/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | todo\r\n| Fixed tickets | #12014\r\n| License       | MIT\r\n| Doc PR        | todo\r\n\r\n## Proposed API\r\n\r\nCode:\r\n\r\n```php\r\n// Symfony command\r\nprotected function execute(InputInterface $input, OutputInterface $output)\r\n{\r\n    $output = new OutputDecorator($output);\r\n\r\n    $output->title('Lorem Ipsum Dolor Sit Amet');\r\n    $output->text(array(\r\n        'Duis aute irure dolor in reprehenderit in voluptate velit esse',\r\n        'cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat'\r\n    ));\r\n    $output->ln();\r\n\r\n    // TODO table\r\n\r\n    $output->caution('Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris.');\r\n    $output->subtitle('Consectetur Adipisicing Elit Sed Do Eiusmod');\r\n    $output->listing(array(\r\n        'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod, tempor incididunt ut labore et dolore magna aliqua.',\r\n        'Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo.',\r\n        'Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'\r\n    ));\r\n\r\n    // TODO questions\r\n\r\n    $output->note('Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat.');\r\n    $output->success('Lorem ipsum dolor sit amet, consectetur adipisicing elit');\r\n    $output->error('Duis aute irure dolor in reprehenderit in voluptate velit esse.');\r\n    $output->warning('Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi.');\r\n}\r\n```\r\n\r\nOutput:\r\n\r\n```\r\n$ php app/console command\r\n\r\nLorem Ipsum Dolor Sit Amet\r\n==========================\r\n\r\n // Duis aute irure dolor in reprehenderit in voluptate velit esse\r\n // cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat\r\n\r\n Name               Method  Scheme  Host  Path\r\n -----------------  ------  ------  ----  ---------------------\r\n admin_post_new     ANY     ANY     ANY   /admin/post/new\r\n admin_post_show    GET     ANY     ANY   /admin/post/{id}\r\n admin_post_edit    ANY     ANY     ANY   /admin/post/{id}/edit\r\n admin_post_delete  DELETE  ANY     ANY   /admin/post/{id}\r\n -----------------  ------  ------  ----  ---------------------\r\n\r\n ! [CAUTION] Lorem ipsum dolor sit amet, consectetur adipisicing elit,\r\n ! sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\r\n ! Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris.\r\n\r\nConsectetur Adipisicing Elit Sed Do Eiusmod\r\n-------------------------------------------\r\n\r\n * Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod\r\n   tempor incididunt ut labore et dolore magna aliqua.\r\n\r\n * Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut\r\n   aliquip ex ea commodo.\r\n\r\n * Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt\r\n   mollit anim id est laborum.\r\n\r\n Bundle namespace:\r\n > AppBundle <Enter>\r\n\r\n Bundle name [AcmeAppBundle]:\r\n > <Enter>\r\n\r\n Configuration format (yml, xml, php, annotation) [annotation]:\r\n > <Enter>\r\n\r\n Do you want to enable the bundle? (yes/no) [yes]:\r\n > <Enter>\r\n\r\n Configuration format (select one) [annotation]:\r\n > yml\r\n > xml\r\n > php\r\n > annotation\r\n\r\n ! [NOTE] Duis aute irure dolor in reprehenderit in voluptate velit esse\r\n ! cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat.\r\n\r\n [OK] Lorem ipsum dolor sit amet, consectetur adipisicing elit\r\n\r\n [ERROR] Duis aute irure dolor in reprehenderit in voluptate velit esse.\r\n\r\n [WARNING] Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi.\r\n```","created_at":"2014-09-25T11:42:33Z","updated_at":"2014-09-25T16:06:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9315e7267379764c30f5d1c73c0844420c7281dc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/12035/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/12035/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/12035/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/57cc112c91971b581645736b5fbcf81c355fc268","head":{"label":"kbond:format-helpers","ref":"format-helpers","sha":"57cc112c91971b581645736b5fbcf81c355fc268","user":{"login":"kbond","id":127811,"avatar_url":"https://avatars.githubusercontent.com/u/127811?v=2","gravatar_id":"","url":"https://api.github.com/users/kbond","html_url":"https://github.com/kbond","followers_url":"https://api.github.com/users/kbond/followers","following_url":"https://api.github.com/users/kbond/following{/other_user}","gists_url":"https://api.github.com/users/kbond/gists{/gist_id}","starred_url":"https://api.github.com/users/kbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbond/subscriptions","organizations_url":"https://api.github.com/users/kbond/orgs","repos_url":"https://api.github.com/users/kbond/repos","events_url":"https://api.github.com/users/kbond/events{/privacy}","received_events_url":"https://api.github.com/users/kbond/received_events","type":"User","site_admin":false},"repo":{"id":1780594,"name":"symfony","full_name":"kbond/symfony","owner":{"login":"kbond","id":127811,"avatar_url":"https://avatars.githubusercontent.com/u/127811?v=2","gravatar_id":"","url":"https://api.github.com/users/kbond","html_url":"https://github.com/kbond","followers_url":"https://api.github.com/users/kbond/followers","following_url":"https://api.github.com/users/kbond/following{/other_user}","gists_url":"https://api.github.com/users/kbond/gists{/gist_id}","starred_url":"https://api.github.com/users/kbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbond/subscriptions","organizations_url":"https://api.github.com/users/kbond/orgs","repos_url":"https://api.github.com/users/kbond/repos","events_url":"https://api.github.com/users/kbond/events{/privacy}","received_events_url":"https://api.github.com/users/kbond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbond/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/kbond/symfony","forks_url":"https://api.github.com/repos/kbond/symfony/forks","keys_url":"https://api.github.com/repos/kbond/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbond/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbond/symfony/teams","hooks_url":"https://api.github.com/repos/kbond/symfony/hooks","issue_events_url":"https://api.github.com/repos/kbond/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/kbond/symfony/events","assignees_url":"https://api.github.com/repos/kbond/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/kbond/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/kbond/symfony/tags","blobs_url":"https://api.github.com/repos/kbond/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbond/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbond/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbond/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbond/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/kbond/symfony/languages","stargazers_url":"https://api.github.com/repos/kbond/symfony/stargazers","contributors_url":"https://api.github.com/repos/kbond/symfony/contributors","subscribers_url":"https://api.github.com/repos/kbond/symfony/subscribers","subscription_url":"https://api.github.com/repos/kbond/symfony/subscription","commits_url":"https://api.github.com/repos/kbond/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbond/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbond/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbond/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/kbond/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/kbond/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbond/symfony/merges","archive_url":"https://api.github.com/repos/kbond/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbond/symfony/downloads","issues_url":"https://api.github.com/repos/kbond/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/kbond/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/kbond/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/kbond/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbond/symfony/labels{/name}","releases_url":"https://api.github.com/repos/kbond/symfony/releases{/id}","created_at":"2011-05-21T14:07:08Z","updated_at":"2014-07-07T17:05:27Z","pushed_at":"2014-09-25T15:39:58Z","git_url":"git://github.com/kbond/symfony.git","ssh_url":"git@github.com:kbond/symfony.git","clone_url":"https://github.com/kbond/symfony.git","svn_url":"https://github.com/kbond/symfony","homepage":"symfony.com","size":43002,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"af0aa501e88937ab1511b0e8ec532548f7e505da","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2014-09-25T15:42:49Z","pushed_at":"2014-09-25T15:51:28Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":181592,"stargazers_count":8932,"watchers_count":8932,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3451,"mirror_url":null,"open_issues_count":770,"forks":3451,"open_issues":770,"watchers":8932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12035"},"html":{"href":"https://github.com/symfony/symfony/pull/12035"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/12035"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/12035/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12035/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12035/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/57cc112c91971b581645736b5fbcf81c355fc268"}}}}