GitHub PullRequestReviewCommentEvent at 2014-04-21 02:46:23
Repository: crosswalk
Actor: wuhengzhi
Payload: {"comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/11800812","id":11800812,"diff_hunk":"@@ -432,6 +469,7 @@ def CustomizeAll(app_versionCode, description, icon_dict, permissions, app_url,\n \n \n def main():\n+  from make_apk import ParseParameterForCompressor","path":"app/tools/android/customize.py","position":82,"original_position":82,"commit_id":"9e8779b389629d16566923b6e38f4c3b8eac2537","original_commit_id":"9e8779b389629d16566923b6e38f4c3b8eac2537","user":{"login":"wuhengzhi","id":1527639,"avatar_url":"https://avatars.githubusercontent.com/u/1527639?","gravatar_id":"d0f8a6ad6f6952d3269e18ff6e8bc071","url":"https://api.github.com/users/wuhengzhi","html_url":"https://github.com/wuhengzhi","followers_url":"https://api.github.com/users/wuhengzhi/followers","following_url":"https://api.github.com/users/wuhengzhi/following{/other_user}","gists_url":"https://api.github.com/users/wuhengzhi/gists{/gist_id}","starred_url":"https://api.github.com/users/wuhengzhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuhengzhi/subscriptions","organizations_url":"https://api.github.com/users/wuhengzhi/orgs","repos_url":"https://api.github.com/users/wuhengzhi/repos","events_url":"https://api.github.com/users/wuhengzhi/events{/privacy}","received_events_url":"https://api.github.com/users/wuhengzhi/received_events","type":"User","site_admin":false},"body":"@yongsheng In make_apk.py, we \"import customize\" and in customize.py, we \"import make_apk.py\" at the beginning, it will not generate the above error. We will call the function like as \"customize.CustomizeAll()\", \"customize.ReplaceInvalidChars()\", Do you mind this usage? thanks.","created_at":"2014-04-21T02:46:23Z","updated_at":"2014-04-21T02:46:23Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/1695#discussion_r11800812","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/1695","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/11800812"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/1695#discussion_r11800812"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/1695"}}}}