GitHub PullRequestReviewCommentEvent at 2014-09-22 20:14:29
Repository: nexpose-client
Actor: mdaines-r7
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/comments/17874928","id":17874928,"diff_hunk":"@@ -510,9 +513,10 @@ class SiteSummary\n \n     # Constructor\n     # SiteSummary(id, name, description, riskfactor = 1)\n-    def initialize(id, name, description = nil, risk_factor = 1.0, risk_score = 0.0)\n+    def initialize(id, name, description = nil, scan_template = nil, risk_factor = 1.0, risk_score = 0.0)\n       @id = id\n       @name = name\n+      @name = scan_template","path":"lib/nexpose/site.rb","position":25,"original_position":25,"commit_id":"b1457a0b1d0da55c930837af98fd0acdfadccab2","original_commit_id":"b1457a0b1d0da55c930837af98fd0acdfadccab2","user":{"login":"mdaines-r7","id":1699657,"avatar_url":"https://avatars.githubusercontent.com/u/1699657?v=2","gravatar_id":"","url":"https://api.github.com/users/mdaines-r7","html_url":"https://github.com/mdaines-r7","followers_url":"https://api.github.com/users/mdaines-r7/followers","following_url":"https://api.github.com/users/mdaines-r7/following{/other_user}","gists_url":"https://api.github.com/users/mdaines-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaines-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaines-r7/subscriptions","organizations_url":"https://api.github.com/users/mdaines-r7/orgs","repos_url":"https://api.github.com/users/mdaines-r7/repos","events_url":"https://api.github.com/users/mdaines-r7/events{/privacy}","received_events_url":"https://api.github.com/users/mdaines-r7/received_events","type":"User","site_admin":false},"body":"Should be \"scan_template\" not \"name\" ... it overwrites the name of the Site as currently written.","created_at":"2014-09-22T20:14:29Z","updated_at":"2014-09-22T20:14:29Z","html_url":"https://github.com/rapid7/nexpose-client/pull/79#discussion_r17874928","pull_request_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/comments/17874928"},"html":{"href":"https://github.com/rapid7/nexpose-client/pull/79#discussion_r17874928"},"pull_request":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/79","id":21370494,"html_url":"https://github.com/rapid7/nexpose-client/pull/79","diff_url":"https://github.com/rapid7/nexpose-client/pull/79.diff","patch_url":"https://github.com/rapid7/nexpose-client/pull/79.patch","issue_url":"https://api.github.com/repos/rapid7/nexpose-client/issues/79","number":79,"state":"open","locked":false,"title":"add scan_template to summary","user":{"login":"b4ldr","id":1110206,"avatar_url":"https://avatars.githubusercontent.com/u/1110206?v=2","gravatar_id":"","url":"https://api.github.com/users/b4ldr","html_url":"https://github.com/b4ldr","followers_url":"https://api.github.com/users/b4ldr/followers","following_url":"https://api.github.com/users/b4ldr/following{/other_user}","gists_url":"https://api.github.com/users/b4ldr/gists{/gist_id}","starred_url":"https://api.github.com/users/b4ldr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4ldr/subscriptions","organizations_url":"https://api.github.com/users/b4ldr/orgs","repos_url":"https://api.github.com/users/b4ldr/repos","events_url":"https://api.github.com/users/b4ldr/events{/privacy}","received_events_url":"https://api.github.com/users/b4ldr/received_events","type":"User","site_admin":false},"body":"I have created a puppet module[1] which adds modifies and removes sites to the nexpose console.  Adding the scan template to the SiteSummary would make this code a little simpler.  \r\n\r\n[1]https://github.com/b4ldr/puppet-nexpose/","created_at":"2014-09-17T14:38:36Z","updated_at":"2014-09-22T20:14:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb06e0593765cd98b595586e126aeb305acc6975","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/79/commits","review_comments_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/79/comments","review_comment_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rapid7/nexpose-client/issues/79/comments","statuses_url":"https://api.github.com/repos/rapid7/nexpose-client/statuses/b1457a0b1d0da55c930837af98fd0acdfadccab2","head":{"label":"b4ldr:add_scan_template_to_summery","ref":"add_scan_template_to_summery","sha":"b1457a0b1d0da55c930837af98fd0acdfadccab2","user":{"login":"b4ldr","id":1110206,"avatar_url":"https://avatars.githubusercontent.com/u/1110206?v=2","gravatar_id":"","url":"https://api.github.com/users/b4ldr","html_url":"https://github.com/b4ldr","followers_url":"https://api.github.com/users/b4ldr/followers","following_url":"https://api.github.com/users/b4ldr/following{/other_user}","gists_url":"https://api.github.com/users/b4ldr/gists{/gist_id}","starred_url":"https://api.github.com/users/b4ldr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4ldr/subscriptions","organizations_url":"https://api.github.com/users/b4ldr/orgs","repos_url":"https://api.github.com/users/b4ldr/repos","events_url":"https://api.github.com/users/b4ldr/events{/privacy}","received_events_url":"https://api.github.com/users/b4ldr/received_events","type":"User","site_admin":false},"repo":{"id":24148145,"name":"nexpose-client","full_name":"b4ldr/nexpose-client","owner":{"login":"b4ldr","id":1110206,"avatar_url":"https://avatars.githubusercontent.com/u/1110206?v=2","gravatar_id":"","url":"https://api.github.com/users/b4ldr","html_url":"https://github.com/b4ldr","followers_url":"https://api.github.com/users/b4ldr/followers","following_url":"https://api.github.com/users/b4ldr/following{/other_user}","gists_url":"https://api.github.com/users/b4ldr/gists{/gist_id}","starred_url":"https://api.github.com/users/b4ldr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4ldr/subscriptions","organizations_url":"https://api.github.com/users/b4ldr/orgs","repos_url":"https://api.github.com/users/b4ldr/repos","events_url":"https://api.github.com/users/b4ldr/events{/privacy}","received_events_url":"https://api.github.com/users/b4ldr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/b4ldr/nexpose-client","description":"Rapid7 Nexpose API client library written in Ruby","fork":true,"url":"https://api.github.com/repos/b4ldr/nexpose-client","forks_url":"https://api.github.com/repos/b4ldr/nexpose-client/forks","keys_url":"https://api.github.com/repos/b4ldr/nexpose-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/b4ldr/nexpose-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/b4ldr/nexpose-client/teams","hooks_url":"https://api.github.com/repos/b4ldr/nexpose-client/hooks","issue_events_url":"https://api.github.com/repos/b4ldr/nexpose-client/issues/events{/number}","events_url":"https://api.github.com/repos/b4ldr/nexpose-client/events","assignees_url":"https://api.github.com/repos/b4ldr/nexpose-client/assignees{/user}","branches_url":"https://api.github.com/repos/b4ldr/nexpose-client/branches{/branch}","tags_url":"https://api.github.com/repos/b4ldr/nexpose-client/tags","blobs_url":"https://api.github.com/repos/b4ldr/nexpose-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/b4ldr/nexpose-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/b4ldr/nexpose-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/b4ldr/nexpose-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/b4ldr/nexpose-client/statuses/{sha}","languages_url":"https://api.github.com/repos/b4ldr/nexpose-client/languages","stargazers_url":"https://api.github.com/repos/b4ldr/nexpose-client/stargazers","contributors_url":"https://api.github.com/repos/b4ldr/nexpose-client/contributors","subscribers_url":"https://api.github.com/repos/b4ldr/nexpose-client/subscribers","subscription_url":"https://api.github.com/repos/b4ldr/nexpose-client/subscription","commits_url":"https://api.github.com/repos/b4ldr/nexpose-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/b4ldr/nexpose-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/b4ldr/nexpose-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/b4ldr/nexpose-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/b4ldr/nexpose-client/contents/{+path}","compare_url":"https://api.github.com/repos/b4ldr/nexpose-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/b4ldr/nexpose-client/merges","archive_url":"https://api.github.com/repos/b4ldr/nexpose-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/b4ldr/nexpose-client/downloads","issues_url":"https://api.github.com/repos/b4ldr/nexpose-client/issues{/number}","pulls_url":"https://api.github.com/repos/b4ldr/nexpose-client/pulls{/number}","milestones_url":"https://api.github.com/repos/b4ldr/nexpose-client/milestones{/number}","notifications_url":"https://api.github.com/repos/b4ldr/nexpose-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/b4ldr/nexpose-client/labels{/name}","releases_url":"https://api.github.com/repos/b4ldr/nexpose-client/releases{/id}","created_at":"2014-09-17T14:30:23Z","updated_at":"2014-09-10T14:12:32Z","pushed_at":"2014-09-17T15:30:58Z","git_url":"git://github.com/b4ldr/nexpose-client.git","ssh_url":"git@github.com:b4ldr/nexpose-client.git","clone_url":"https://github.com/b4ldr/nexpose-client.git","svn_url":"https://github.com/b4ldr/nexpose-client","homepage":"http://www.rapid7.com/","size":687,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"613949705a9bb7314a19bcafdb303c361f592b39","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=2","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":2622467,"name":"nexpose-client","full_name":"rapid7/nexpose-client","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=2","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/nexpose-client","description":"Rapid7 Nexpose API client library written in Ruby","fork":false,"url":"https://api.github.com/repos/rapid7/nexpose-client","forks_url":"https://api.github.com/repos/rapid7/nexpose-client/forks","keys_url":"https://api.github.com/repos/rapid7/nexpose-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/nexpose-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/nexpose-client/teams","hooks_url":"https://api.github.com/repos/rapid7/nexpose-client/hooks","issue_events_url":"https://api.github.com/repos/rapid7/nexpose-client/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/nexpose-client/events","assignees_url":"https://api.github.com/repos/rapid7/nexpose-client/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/nexpose-client/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/nexpose-client/tags","blobs_url":"https://api.github.com/repos/rapid7/nexpose-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/nexpose-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/nexpose-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/nexpose-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/nexpose-client/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/nexpose-client/languages","stargazers_url":"https://api.github.com/repos/rapid7/nexpose-client/stargazers","contributors_url":"https://api.github.com/repos/rapid7/nexpose-client/contributors","subscribers_url":"https://api.github.com/repos/rapid7/nexpose-client/subscribers","subscription_url":"https://api.github.com/repos/rapid7/nexpose-client/subscription","commits_url":"https://api.github.com/repos/rapid7/nexpose-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/nexpose-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/nexpose-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/nexpose-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/rapid7/nexpose-client/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/nexpose-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/nexpose-client/merges","archive_url":"https://api.github.com/repos/rapid7/nexpose-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/nexpose-client/downloads","issues_url":"https://api.github.com/repos/rapid7/nexpose-client/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/nexpose-client/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/nexpose-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/nexpose-client/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/nexpose-client/releases{/id}","created_at":"2011-10-21T19:04:49Z","updated_at":"2014-09-18T09:55:51Z","pushed_at":"2014-08-08T18:14:22Z","git_url":"git://github.com/rapid7/nexpose-client.git","ssh_url":"git@github.com:rapid7/nexpose-client.git","clone_url":"https://github.com/rapid7/nexpose-client.git","svn_url":"https://github.com/rapid7/nexpose-client","homepage":"http://www.rapid7.com/","size":4997,"stargazers_count":60,"watchers_count":60,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":7,"forks":43,"open_issues":7,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/79"},"html":{"href":"https://github.com/rapid7/nexpose-client/pull/79"},"issue":{"href":"https://api.github.com/repos/rapid7/nexpose-client/issues/79"},"comments":{"href":"https://api.github.com/repos/rapid7/nexpose-client/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/nexpose-client/statuses/b1457a0b1d0da55c930837af98fd0acdfadccab2"}}}}