GitHub PullRequestReviewCommentEvent at 2014-08-31 06:24:30
Repository: symfony
Actor: fabpot
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/16933253","id":16933253,"diff_hunk":"@@ -35,6 +41,10 @@ public function getStopwatch()\n \n     public function getTokenParsers()\n     {\n+        if (!$this->enabled) {\n+            return array();","path":"src/Symfony/Bridge/Twig/Extension/StopwatchExtension.php","position":22,"original_position":22,"commit_id":"4ca19d4388b7d787a342a1e450c93971e5d9a5e7","original_commit_id":"4ca19d4388b7d787a342a1e450c93971e5d9a5e7","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=2","gravatar_id":"f1a2c5905e121d09feba5ad73898ffca","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"body":"`new StopwatchTokenParser($this->enabled)`","created_at":"2014-08-31T06:24:30Z","updated_at":"2014-08-31T06:24:30Z","html_url":"https://github.com/symfony/symfony/pull/11549#discussion_r16933253","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/11549","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/16933253"},"html":{"href":"https://github.com/symfony/symfony/pull/11549#discussion_r16933253"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11549"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/11549","id":19244904,"html_url":"https://github.com/symfony/symfony/pull/11549","diff_url":"https://github.com/symfony/symfony/pull/11549.diff","patch_url":"https://github.com/symfony/symfony/pull/11549.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/11549","number":11549,"state":"open","locked":false,"title":"[Bundle][FrameworkBundle] make the stopwatch service always available","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=2","gravatar_id":"b5fe043ff5cd47b3b35d95e78fce5539","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #11347\r\n| License       | MIT\r\n| Doc PR        | \r\n\r\nPreviously, one had to be careful to check if the ``debug.stopwatch`` service was available before using it. Otherwise, the application would break in the prod environment.","created_at":"2014-08-02T10:11:00Z","updated_at":"2014-08-31T06:24:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87e57b045104c0b7cc28b1fe90c6f5a764d465d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/11549/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/11549/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/11549/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/4ca19d4388b7d787a342a1e450c93971e5d9a5e7","head":{"label":"xabbuh:issue-11347","ref":"issue-11347","sha":"4ca19d4388b7d787a342a1e450c93971e5d9a5e7","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=2","gravatar_id":"b5fe043ff5cd47b3b35d95e78fce5539","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"repo":{"id":9551743,"name":"symfony","full_name":"xabbuh/symfony","owner":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=2","gravatar_id":"b5fe043ff5cd47b3b35d95e78fce5539","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xabbuh/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/xabbuh/symfony","forks_url":"https://api.github.com/repos/xabbuh/symfony/forks","keys_url":"https://api.github.com/repos/xabbuh/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xabbuh/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xabbuh/symfony/teams","hooks_url":"https://api.github.com/repos/xabbuh/symfony/hooks","issue_events_url":"https://api.github.com/repos/xabbuh/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/xabbuh/symfony/events","assignees_url":"https://api.github.com/repos/xabbuh/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/xabbuh/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/xabbuh/symfony/tags","blobs_url":"https://api.github.com/repos/xabbuh/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xabbuh/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xabbuh/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/xabbuh/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xabbuh/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/xabbuh/symfony/languages","stargazers_url":"https://api.github.com/repos/xabbuh/symfony/stargazers","contributors_url":"https://api.github.com/repos/xabbuh/symfony/contributors","subscribers_url":"https://api.github.com/repos/xabbuh/symfony/subscribers","subscription_url":"https://api.github.com/repos/xabbuh/symfony/subscription","commits_url":"https://api.github.com/repos/xabbuh/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/xabbuh/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/xabbuh/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/xabbuh/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/xabbuh/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/xabbuh/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xabbuh/symfony/merges","archive_url":"https://api.github.com/repos/xabbuh/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xabbuh/symfony/downloads","issues_url":"https://api.github.com/repos/xabbuh/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/xabbuh/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/xabbuh/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/xabbuh/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xabbuh/symfony/labels{/name}","releases_url":"https://api.github.com/repos/xabbuh/symfony/releases{/id}","created_at":"2013-04-19T18:23:15Z","updated_at":"2014-07-05T08:26:55Z","pushed_at":"2014-08-31T06:08:41Z","git_url":"git://github.com/xabbuh/symfony.git","ssh_url":"git@github.com:xabbuh/symfony.git","clone_url":"https://github.com/xabbuh/symfony.git","svn_url":"https://github.com/xabbuh/symfony","homepage":"symfony.com","size":42260,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"c51f3f36abea5829df261568b836aa85290a30fc","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2014-08-30T20:11:06Z","pushed_at":"2014-08-31T04:20:48Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":175710,"stargazers_count":8849,"watchers_count":8849,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":3404,"mirror_url":null,"open_issues_count":846,"forks":3404,"open_issues":846,"watchers":8849,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11549"},"html":{"href":"https://github.com/symfony/symfony/pull/11549"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/11549"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/11549/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11549/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11549/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/4ca19d4388b7d787a342a1e450c93971e5d9a5e7"}}}}