GitHub PullRequestEvent at 2014-02-13 21:25:50
Repository: cryptography
Actor: dreid
Payload: {"action":"closed","number":610,"pull_request":{"url":"https://api.github.com/repos/pyca/cryptography/pulls/610","id":12528694,"html_url":"https://github.com/pyca/cryptography/pull/610","diff_url":"https://github.com/pyca/cryptography/pull/610.diff","patch_url":"https://github.com/pyca/cryptography/pull/610.patch","issue_url":"https://api.github.com/repos/pyca/cryptography/issues/610","number":610,"state":"closed","title":"Fix comments in padding.py to be accurate","user":{"login":"alex","id":772,"avatar_url":"https://gravatar.com/avatar/edcdfd5affb524e0f88ec1a00ed3fe5d?d=https%3A%2F%2Fidenticons.github.com%2Fe57c6b956a6521b28495f2886ca0977a.png&r=x","gravatar_id":"edcdfd5affb524e0f88ec1a00ed3fe5d","url":"https://api.github.com/users/alex","html_url":"https://github.com/alex","followers_url":"https://api.github.com/users/alex/followers","following_url":"https://api.github.com/users/alex/following{/other_user}","gists_url":"https://api.github.com/users/alex/gists{/gist_id}","starred_url":"https://api.github.com/users/alex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex/subscriptions","organizations_url":"https://api.github.com/users/alex/orgs","repos_url":"https://api.github.com/users/alex/repos","events_url":"https://api.github.com/users/alex/events{/privacy}","received_events_url":"https://api.github.com/users/alex/received_events","type":"User","site_admin":false},"body":"This is not in fact O(n ** 2) because ``len(self._buffer)`` is bounded by ``self.block_size``. This means that each ``self._buffer += x`` only copies O(len(x)) bytes, meaning the whole thing is linear.","created_at":"2014-02-13T20:50:17Z","updated_at":"2014-02-13T21:25:50Z","closed_at":"2014-02-13T21:25:50Z","merged_at":"2014-02-13T21:25:50Z","merge_commit_sha":"7961a20e5f67f85d06dbe4ba096ea6aeded87654","assignee":null,"milestone":{"url":"https://api.github.com/repos/pyca/cryptography/milestones/2","labels_url":"https://api.github.com/repos/pyca/cryptography/milestones/2/labels","id":524450,"number":2,"title":"Second Release","description":"","creator":{"login":"reaperhulk","id":161495,"avatar_url":"https://gravatar.com/avatar/81f310942fe5989105a6b474cda4c843?d=https%3A%2F%2Fidenticons.github.com%2F472b5d9f2faf67614e39fc24c2aeca99.png&r=x","gravatar_id":"81f310942fe5989105a6b474cda4c843","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":84,"state":"open","created_at":"2014-01-01T16:05:29Z","updated_at":"2014-02-13T21:25:50Z","due_on":null},"commits_url":"https://api.github.com/repos/pyca/cryptography/pulls/610/commits","review_comments_url":"https://api.github.com/repos/pyca/cryptography/pulls/610/comments","review_comment_url":"https://api.github.com/repos/pyca/cryptography/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pyca/cryptography/issues/610/comments","statuses_url":"https://api.github.com/repos/pyca/cryptography/statuses/86dc3ab8e849498471f8f5b65470c7a53d4023e7","head":{"label":"alex:padding-comments","ref":"padding-comments","sha":"86dc3ab8e849498471f8f5b65470c7a53d4023e7","user":{"login":"alex","id":772,"avatar_url":"https://gravatar.com/avatar/edcdfd5affb524e0f88ec1a00ed3fe5d?d=https%3A%2F%2Fidenticons.github.com%2Fe57c6b956a6521b28495f2886ca0977a.png&r=x","gravatar_id":"edcdfd5affb524e0f88ec1a00ed3fe5d","url":"https://api.github.com/users/alex","html_url":"https://github.com/alex","followers_url":"https://api.github.com/users/alex/followers","following_url":"https://api.github.com/users/alex/following{/other_user}","gists_url":"https://api.github.com/users/alex/gists{/gist_id}","starred_url":"https://api.github.com/users/alex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex/subscriptions","organizations_url":"https://api.github.com/users/alex/orgs","repos_url":"https://api.github.com/users/alex/repos","events_url":"https://api.github.com/users/alex/events{/privacy}","received_events_url":"https://api.github.com/users/alex/received_events","type":"User","site_admin":false},"repo":{"id":13339837,"name":"cryptography","full_name":"alex/cryptography","owner":{"login":"alex","id":772,"avatar_url":"https://gravatar.com/avatar/edcdfd5affb524e0f88ec1a00ed3fe5d?d=https%3A%2F%2Fidenticons.github.com%2Fe57c6b956a6521b28495f2886ca0977a.png&r=x","gravatar_id":"edcdfd5affb524e0f88ec1a00ed3fe5d","url":"https://api.github.com/users/alex","html_url":"https://github.com/alex","followers_url":"https://api.github.com/users/alex/followers","following_url":"https://api.github.com/users/alex/following{/other_user}","gists_url":"https://api.github.com/users/alex/gists{/gist_id}","starred_url":"https://api.github.com/users/alex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex/subscriptions","organizations_url":"https://api.github.com/users/alex/orgs","repos_url":"https://api.github.com/users/alex/repos","events_url":"https://api.github.com/users/alex/events{/privacy}","received_events_url":"https://api.github.com/users/alex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alex/cryptography","description":"cryptography is a package designed to expose cryptographic primitives and recipes to Python developers.","fork":true,"url":"https://api.github.com/repos/alex/cryptography","forks_url":"https://api.github.com/repos/alex/cryptography/forks","keys_url":"https://api.github.com/repos/alex/cryptography/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alex/cryptography/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alex/cryptography/teams","hooks_url":"https://api.github.com/repos/alex/cryptography/hooks","issue_events_url":"https://api.github.com/repos/alex/cryptography/issues/events{/number}","events_url":"https://api.github.com/repos/alex/cryptography/events","assignees_url":"https://api.github.com/repos/alex/cryptography/assignees{/user}","branches_url":"https://api.github.com/repos/alex/cryptography/branches{/branch}","tags_url":"https://api.github.com/repos/alex/cryptography/tags","blobs_url":"https://api.github.com/repos/alex/cryptography/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alex/cryptography/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alex/cryptography/git/refs{/sha}","trees_url":"https://api.github.com/repos/alex/cryptography/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alex/cryptography/statuses/{sha}","languages_url":"https://api.github.com/repos/alex/cryptography/languages","stargazers_url":"https://api.github.com/repos/alex/cryptography/stargazers","contributors_url":"https://api.github.com/repos/alex/cryptography/contributors","subscribers_url":"https://api.github.com/repos/alex/cryptography/subscribers","subscription_url":"https://api.github.com/repos/alex/cryptography/subscription","commits_url":"https://api.github.com/repos/alex/cryptography/commits{/sha}","git_commits_url":"https://api.github.com/repos/alex/cryptography/git/commits{/sha}","comments_url":"https://api.github.com/repos/alex/cryptography/comments{/number}","issue_comment_url":"https://api.github.com/repos/alex/cryptography/issues/comments/{number}","contents_url":"https://api.github.com/repos/alex/cryptography/contents/{+path}","compare_url":"https://api.github.com/repos/alex/cryptography/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alex/cryptography/merges","archive_url":"https://api.github.com/repos/alex/cryptography/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alex/cryptography/downloads","issues_url":"https://api.github.com/repos/alex/cryptography/issues{/number}","pulls_url":"https://api.github.com/repos/alex/cryptography/pulls{/number}","milestones_url":"https://api.github.com/repos/alex/cryptography/milestones{/number}","notifications_url":"https://api.github.com/repos/alex/cryptography/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alex/cryptography/labels{/name}","releases_url":"https://api.github.com/repos/alex/cryptography/releases{/id}","created_at":"2013-10-05T03:59:39Z","updated_at":"2014-02-13T21:25:50Z","pushed_at":"2014-02-13T20:58:01Z","git_url":"git://github.com/alex/cryptography.git","ssh_url":"git@github.com:alex/cryptography.git","clone_url":"https://github.com/alex/cryptography.git","svn_url":"https://github.com/alex/cryptography","homepage":"https://cryptography.readthedocs.org/","size":16329,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"pyca:master","ref":"master","sha":"811163e609c2df4f785473376f914d224d896f07","user":{"login":"pyca","id":5615737,"avatar_url":"https://identicons.github.com/cbd8c7535a0578fcfc8ddf0f20fc3741.png","gravatar_id":null,"url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"repo":{"id":11939484,"name":"cryptography","full_name":"pyca/cryptography","owner":{"login":"pyca","id":5615737,"avatar_url":"https://identicons.github.com/cbd8c7535a0578fcfc8ddf0f20fc3741.png","gravatar_id":null,"url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyca/cryptography","description":"cryptography is a package designed to expose cryptographic primitives and recipes to Python developers.","fork":false,"url":"https://api.github.com/repos/pyca/cryptography","forks_url":"https://api.github.com/repos/pyca/cryptography/forks","keys_url":"https://api.github.com/repos/pyca/cryptography/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyca/cryptography/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyca/cryptography/teams","hooks_url":"https://api.github.com/repos/pyca/cryptography/hooks","issue_events_url":"https://api.github.com/repos/pyca/cryptography/issues/events{/number}","events_url":"https://api.github.com/repos/pyca/cryptography/events","assignees_url":"https://api.github.com/repos/pyca/cryptography/assignees{/user}","branches_url":"https://api.github.com/repos/pyca/cryptography/branches{/branch}","tags_url":"https://api.github.com/repos/pyca/cryptography/tags","blobs_url":"https://api.github.com/repos/pyca/cryptography/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyca/cryptography/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyca/cryptography/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyca/cryptography/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyca/cryptography/statuses/{sha}","languages_url":"https://api.github.com/repos/pyca/cryptography/languages","stargazers_url":"https://api.github.com/repos/pyca/cryptography/stargazers","contributors_url":"https://api.github.com/repos/pyca/cryptography/contributors","subscribers_url":"https://api.github.com/repos/pyca/cryptography/subscribers","subscription_url":"https://api.github.com/repos/pyca/cryptography/subscription","commits_url":"https://api.github.com/repos/pyca/cryptography/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyca/cryptography/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyca/cryptography/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyca/cryptography/issues/comments/{number}","contents_url":"https://api.github.com/repos/pyca/cryptography/contents/{+path}","compare_url":"https://api.github.com/repos/pyca/cryptography/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyca/cryptography/merges","archive_url":"https://api.github.com/repos/pyca/cryptography/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyca/cryptography/downloads","issues_url":"https://api.github.com/repos/pyca/cryptography/issues{/number}","pulls_url":"https://api.github.com/repos/pyca/cryptography/pulls{/number}","milestones_url":"https://api.github.com/repos/pyca/cryptography/milestones{/number}","notifications_url":"https://api.github.com/repos/pyca/cryptography/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyca/cryptography/labels{/name}","releases_url":"https://api.github.com/repos/pyca/cryptography/releases{/id}","created_at":"2013-08-07T02:23:38Z","updated_at":"2014-02-13T21:25:50Z","pushed_at":"2014-02-13T21:25:50Z","git_url":"git://github.com/pyca/cryptography.git","ssh_url":"git@github.com:pyca/cryptography.git","clone_url":"https://github.com/pyca/cryptography.git","svn_url":"https://github.com/pyca/cryptography","homepage":"https://cryptography.io/","size":21922,"stargazers_count":212,"watchers_count":212,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":37,"mirror_url":null,"open_issues_count":39,"forks":37,"open_issues":39,"watchers":212,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/610"},"html":{"href":"https://github.com/pyca/cryptography/pull/610"},"issue":{"href":"https://api.github.com/repos/pyca/cryptography/issues/610"},"comments":{"href":"https://api.github.com/repos/pyca/cryptography/issues/610/comments"},"review_comments":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/610/comments"},"review_comment":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/610/commits"},"statuses":{"href":"https://api.github.com/repos/pyca/cryptography/statuses/86dc3ab8e849498471f8f5b65470c7a53d4023e7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dreid","id":48695,"avatar_url":"https://gravatar.com/avatar/fba4b1ec2535b55189d1de44e4b5121a?d=https%3A%2F%2Fidenticons.github.com%2F107dd95cbdbd492c7f55e7128eaebce5.png&r=x","gravatar_id":"fba4b1ec2535b55189d1de44e4b5121a","url":"https://api.github.com/users/dreid","html_url":"https://github.com/dreid","followers_url":"https://api.github.com/users/dreid/followers","following_url":"https://api.github.com/users/dreid/following{/other_user}","gists_url":"https://api.github.com/users/dreid/gists{/gist_id}","starred_url":"https://api.github.com/users/dreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreid/subscriptions","organizations_url":"https://api.github.com/users/dreid/orgs","repos_url":"https://api.github.com/users/dreid/repos","events_url":"https://api.github.com/users/dreid/events{/privacy}","received_events_url":"https://api.github.com/users/dreid/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":4,"changed_files":1}}