GitHub PullRequestReviewCommentEvent at 2014-10-06 16:58:36
Repository: mongo-php-driver
Actor: bjori
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/18469163","id":18469163,"diff_hunk":"@@ -918,73 +1007,31 @@ static int have_error_flags(mongo_cursor *cursor)\n  */\n PHP_METHOD(MongoCursor, next)\n {\n-\tzval has_next;\n-\tmongo_cursor *cursor;\n+\tmongo_cursor *cursor = (mongo_cursor*)zend_object_store_get_object(getThis() TSRMLS_CC);\n \n-\tPHP_MONGO_GET_CURSOR(getThis());\n+\tMONGO_CHECK_INITIALIZED(cursor->zmongoclient, MongoCursor);\n \tMONGO_CURSOR_CHECK_DEAD;\n \n+\t/* Ideally, next() shouldn't be doing this. Instead users should use\n+\t * doQuery() themselves. But, BC */\n \tif (!cursor->started_iterating) {\n-\t\tMONGO_METHOD(MongoCursor, doQuery, return_value, getThis());\n+\t\tphp_mongo_runquery(cursor TSRMLS_CC);","path":"cursor.c","position":414,"original_position":408,"commit_id":"e44518c8dc887c92bbe63b8a896b2c129a27c095","original_commit_id":"59d5fc4577c6c7bdf15df3b94d12f48f98b54a91","user":{"login":"bjori","id":72407,"avatar_url":"https://avatars.githubusercontent.com/u/72407?v=2","gravatar_id":"","url":"https://api.github.com/users/bjori","html_url":"https://github.com/bjori","followers_url":"https://api.github.com/users/bjori/followers","following_url":"https://api.github.com/users/bjori/following{/other_user}","gists_url":"https://api.github.com/users/bjori/gists{/gist_id}","starred_url":"https://api.github.com/users/bjori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjori/subscriptions","organizations_url":"https://api.github.com/users/bjori/orgs","repos_url":"https://api.github.com/users/bjori/repos","events_url":"https://api.github.com/users/bjori/events{/privacy}","received_events_url":"https://api.github.com/users/bjori/received_events","type":"User","site_admin":false},"body":"That needs to be mentioned somewhere then","created_at":"2014-10-06T16:58:36Z","updated_at":"2014-10-06T16:58:36Z","html_url":"https://github.com/mongodb/mongo-php-driver/pull/737#discussion_r18469163","pull_request_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/737","_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/18469163"},"html":{"href":"https://github.com/mongodb/mongo-php-driver/pull/737#discussion_r18469163"},"pull_request":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/737"}}},"pull_request":{"url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/737","id":21853726,"html_url":"https://github.com/mongodb/mongo-php-driver/pull/737","diff_url":"https://github.com/mongodb/mongo-php-driver/pull/737.diff","patch_url":"https://github.com/mongodb/mongo-php-driver/pull/737.patch","issue_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/737","number":737,"state":"open","locked":false,"title":"PHP-1063: Refactor cursor logic to follow MongoCommandCursor","user":{"login":"derickr","id":208074,"avatar_url":"https://avatars.githubusercontent.com/u/208074?v=2","gravatar_id":"","url":"https://api.github.com/users/derickr","html_url":"https://github.com/derickr","followers_url":"https://api.github.com/users/derickr/followers","following_url":"https://api.github.com/users/derickr/following{/other_user}","gists_url":"https://api.github.com/users/derickr/gists{/gist_id}","starred_url":"https://api.github.com/users/derickr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derickr/subscriptions","organizations_url":"https://api.github.com/users/derickr/orgs","repos_url":"https://api.github.com/users/derickr/repos","events_url":"https://api.github.com/users/derickr/events{/privacy}","received_events_url":"https://api.github.com/users/derickr/received_events","type":"User","site_admin":false},"body":"https://jira.mongodb.org/browse/PHP-1063","created_at":"2014-09-26T14:57:42Z","updated_at":"2014-10-06T16:58:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a210715ed16690827a400e3765730af04077266","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/737/commits","review_comments_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/737/comments","review_comment_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/737/comments","statuses_url":"https://api.github.com/repos/mongodb/mongo-php-driver/statuses/e44518c8dc887c92bbe63b8a896b2c129a27c095","head":{"label":"derickr:PHP-1093-refactor-cursor-logic","ref":"PHP-1093-refactor-cursor-logic","sha":"e44518c8dc887c92bbe63b8a896b2c129a27c095","user":{"login":"derickr","id":208074,"avatar_url":"https://avatars.githubusercontent.com/u/208074?v=2","gravatar_id":"","url":"https://api.github.com/users/derickr","html_url":"https://github.com/derickr","followers_url":"https://api.github.com/users/derickr/followers","following_url":"https://api.github.com/users/derickr/following{/other_user}","gists_url":"https://api.github.com/users/derickr/gists{/gist_id}","starred_url":"https://api.github.com/users/derickr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derickr/subscriptions","organizations_url":"https://api.github.com/users/derickr/orgs","repos_url":"https://api.github.com/users/derickr/repos","events_url":"https://api.github.com/users/derickr/events{/privacy}","received_events_url":"https://api.github.com/users/derickr/received_events","type":"User","site_admin":false},"repo":{"id":2708237,"name":"mongo-php-driver","full_name":"derickr/mongo-php-driver","owner":{"login":"derickr","id":208074,"avatar_url":"https://avatars.githubusercontent.com/u/208074?v=2","gravatar_id":"","url":"https://api.github.com/users/derickr","html_url":"https://github.com/derickr","followers_url":"https://api.github.com/users/derickr/followers","following_url":"https://api.github.com/users/derickr/following{/other_user}","gists_url":"https://api.github.com/users/derickr/gists{/gist_id}","starred_url":"https://api.github.com/users/derickr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derickr/subscriptions","organizations_url":"https://api.github.com/users/derickr/orgs","repos_url":"https://api.github.com/users/derickr/repos","events_url":"https://api.github.com/users/derickr/events{/privacy}","received_events_url":"https://api.github.com/users/derickr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derickr/mongo-php-driver","description":"Officially supported PHP driver for MongoDB","fork":true,"url":"https://api.github.com/repos/derickr/mongo-php-driver","forks_url":"https://api.github.com/repos/derickr/mongo-php-driver/forks","keys_url":"https://api.github.com/repos/derickr/mongo-php-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derickr/mongo-php-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derickr/mongo-php-driver/teams","hooks_url":"https://api.github.com/repos/derickr/mongo-php-driver/hooks","issue_events_url":"https://api.github.com/repos/derickr/mongo-php-driver/issues/events{/number}","events_url":"https://api.github.com/repos/derickr/mongo-php-driver/events","assignees_url":"https://api.github.com/repos/derickr/mongo-php-driver/assignees{/user}","branches_url":"https://api.github.com/repos/derickr/mongo-php-driver/branches{/branch}","tags_url":"https://api.github.com/repos/derickr/mongo-php-driver/tags","blobs_url":"https://api.github.com/repos/derickr/mongo-php-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derickr/mongo-php-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derickr/mongo-php-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/derickr/mongo-php-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derickr/mongo-php-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/derickr/mongo-php-driver/languages","stargazers_url":"https://api.github.com/repos/derickr/mongo-php-driver/stargazers","contributors_url":"https://api.github.com/repos/derickr/mongo-php-driver/contributors","subscribers_url":"https://api.github.com/repos/derickr/mongo-php-driver/subscribers","subscription_url":"https://api.github.com/repos/derickr/mongo-php-driver/subscription","commits_url":"https://api.github.com/repos/derickr/mongo-php-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/derickr/mongo-php-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/derickr/mongo-php-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/derickr/mongo-php-driver/issues/comments/{number}","contents_url":"https://api.github.com/repos/derickr/mongo-php-driver/contents/{+path}","compare_url":"https://api.github.com/repos/derickr/mongo-php-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derickr/mongo-php-driver/merges","archive_url":"https://api.github.com/repos/derickr/mongo-php-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derickr/mongo-php-driver/downloads","issues_url":"https://api.github.com/repos/derickr/mongo-php-driver/issues{/number}","pulls_url":"https://api.github.com/repos/derickr/mongo-php-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/derickr/mongo-php-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/derickr/mongo-php-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derickr/mongo-php-driver/labels{/name}","releases_url":"https://api.github.com/repos/derickr/mongo-php-driver/releases{/id}","created_at":"2011-11-04T09:42:57Z","updated_at":"2014-07-16T09:39:14Z","pushed_at":"2014-10-06T16:35:38Z","git_url":"git://github.com/derickr/mongo-php-driver.git","ssh_url":"git@github.com:derickr/mongo-php-driver.git","clone_url":"https://github.com/derickr/mongo-php-driver.git","svn_url":"https://github.com/derickr/mongo-php-driver","homepage":"http://www.mongodb.org/display/DOCS/PHP+Language+Center","size":12274,"stargazers_count":12,"watchers_count":12,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":12,"default_branch":"master"}},"base":{"label":"mongodb:master","ref":"master","sha":"51c2443470d151e6317afd2d7da4940861916484","user":{"login":"mongodb","id":45120,"avatar_url":"https://avatars.githubusercontent.com/u/45120?v=2","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":121842,"name":"mongo-php-driver","full_name":"mongodb/mongo-php-driver","owner":{"login":"mongodb","id":45120,"avatar_url":"https://avatars.githubusercontent.com/u/45120?v=2","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mongodb/mongo-php-driver","description":"Officially supported PHP driver for MongoDB","fork":false,"url":"https://api.github.com/repos/mongodb/mongo-php-driver","forks_url":"https://api.github.com/repos/mongodb/mongo-php-driver/forks","keys_url":"https://api.github.com/repos/mongodb/mongo-php-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/mongo-php-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/mongo-php-driver/teams","hooks_url":"https://api.github.com/repos/mongodb/mongo-php-driver/hooks","issue_events_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/mongo-php-driver/events","assignees_url":"https://api.github.com/repos/mongodb/mongo-php-driver/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/mongo-php-driver/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/mongo-php-driver/tags","blobs_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/mongo-php-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/mongo-php-driver/languages","stargazers_url":"https://api.github.com/repos/mongodb/mongo-php-driver/stargazers","contributors_url":"https://api.github.com/repos/mongodb/mongo-php-driver/contributors","subscribers_url":"https://api.github.com/repos/mongodb/mongo-php-driver/subscribers","subscription_url":"https://api.github.com/repos/mongodb/mongo-php-driver/subscription","commits_url":"https://api.github.com/repos/mongodb/mongo-php-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/mongo-php-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/comments/{number}","contents_url":"https://api.github.com/repos/mongodb/mongo-php-driver/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/mongo-php-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/mongo-php-driver/merges","archive_url":"https://api.github.com/repos/mongodb/mongo-php-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/mongo-php-driver/downloads","issues_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/mongo-php-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/mongo-php-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/mongo-php-driver/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/mongo-php-driver/releases{/id}","created_at":"2009-02-04T21:30:35Z","updated_at":"2014-09-28T15:39:17Z","pushed_at":"2014-09-16T12:05:13Z","git_url":"git://github.com/mongodb/mongo-php-driver.git","ssh_url":"git@github.com:mongodb/mongo-php-driver.git","clone_url":"https://github.com/mongodb/mongo-php-driver.git","svn_url":"https://github.com/mongodb/mongo-php-driver","homepage":"http://docs.mongodb.org/ecosystem/drivers/php/","size":18364,"stargazers_count":935,"watchers_count":935,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":262,"mirror_url":null,"open_issues_count":2,"forks":262,"open_issues":2,"watchers":935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/737"},"html":{"href":"https://github.com/mongodb/mongo-php-driver/pull/737"},"issue":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/737"},"comments":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/737/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/737/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/737/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/statuses/e44518c8dc887c92bbe63b8a896b2c129a27c095"}}}}