GitHub PullRequestReviewCommentEvent at 2014-11-14 15:24:28
Repository: structured-blocks
Actor: jeresig
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Khan/structured-blocks/pulls/comments/20364419","id":20364419,"diff_hunk":"@@ -128,7 +128,7 @@ JSRules.addRule(JSRule.extend({\n         }\n \n         this.match.vars.value = val;\n-        event.target.size = Math.max(newVal.length, 2);\n+        event.target.size = Math.max(newVal.length, 0);","path":"js/js-rules.js","position":5,"original_position":5,"commit_id":"1ae9467af12c7db83482979e4986718d9d505f28","original_commit_id":"1ae9467af12c7db83482979e4986718d9d505f28","user":{"login":"jeresig","id":1615,"avatar_url":"https://avatars.githubusercontent.com/u/1615?v=3","gravatar_id":"","url":"https://api.github.com/users/jeresig","html_url":"https://github.com/jeresig","followers_url":"https://api.github.com/users/jeresig/followers","following_url":"https://api.github.com/users/jeresig/following{/other_user}","gists_url":"https://api.github.com/users/jeresig/gists{/gist_id}","starred_url":"https://api.github.com/users/jeresig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeresig/subscriptions","organizations_url":"https://api.github.com/users/jeresig/orgs","repos_url":"https://api.github.com/users/jeresig/repos","events_url":"https://api.github.com/users/jeresig/events{/privacy}","received_events_url":"https://api.github.com/users/jeresig/received_events","type":"User","site_admin":false},"body":"Woah, that's weird - it still displays something with a size of 0?","created_at":"2014-11-14T15:24:28Z","updated_at":"2014-11-14T15:24:28Z","html_url":"https://github.com/Khan/structured-blocks/pull/22#discussion_r20364419","pull_request_url":"https://api.github.com/repos/Khan/structured-blocks/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/Khan/structured-blocks/pulls/comments/20364419"},"html":{"href":"https://github.com/Khan/structured-blocks/pull/22#discussion_r20364419"},"pull_request":{"href":"https://api.github.com/repos/Khan/structured-blocks/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/Khan/structured-blocks/pulls/22","id":24395743,"html_url":"https://github.com/Khan/structured-blocks/pull/22","diff_url":"https://github.com/Khan/structured-blocks/pull/22.diff","patch_url":"https://github.com/Khan/structured-blocks/pull/22.patch","issue_url":"https://api.github.com/repos/Khan/structured-blocks/issues/22","number":22,"state":"open","locked":false,"title":"Update the typography a bit.","user":{"login":"jbrennan","id":131923,"avatar_url":"https://avatars.githubusercontent.com/u/131923?v=3","gravatar_id":"","url":"https://api.github.com/users/jbrennan","html_url":"https://github.com/jbrennan","followers_url":"https://api.github.com/users/jbrennan/followers","following_url":"https://api.github.com/users/jbrennan/following{/other_user}","gists_url":"https://api.github.com/users/jbrennan/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrennan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrennan/subscriptions","organizations_url":"https://api.github.com/users/jbrennan/orgs","repos_url":"https://api.github.com/users/jbrennan/repos","events_url":"https://api.github.com/users/jbrennan/events{/privacy}","received_events_url":"https://api.github.com/users/jbrennan/received_events","type":"User","site_admin":false},"body":"Addresses #20 so the environment uses Proxima Nova Semibold (if it’s available, which it is on KA) for blocks in the editor and toolbox. This is more consistent with the Khan Academy visual style.","created_at":"2014-11-13T19:59:50Z","updated_at":"2014-11-14T15:24:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4526ef04e61162b5edcc0c504575e96732f6b2fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Khan/structured-blocks/pulls/22/commits","review_comments_url":"https://api.github.com/repos/Khan/structured-blocks/pulls/22/comments","review_comment_url":"https://api.github.com/repos/Khan/structured-blocks/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Khan/structured-blocks/issues/22/comments","statuses_url":"https://api.github.com/repos/Khan/structured-blocks/statuses/1ae9467af12c7db83482979e4986718d9d505f28","head":{"label":"Khan:typography","ref":"typography","sha":"1ae9467af12c7db83482979e4986718d9d505f28","user":{"login":"Khan","id":15455,"avatar_url":"https://avatars.githubusercontent.com/u/15455?v=3","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"repo":{"id":25311936,"name":"structured-blocks","full_name":"Khan/structured-blocks","owner":{"login":"Khan","id":15455,"avatar_url":"https://avatars.githubusercontent.com/u/15455?v=3","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Khan/structured-blocks","description":"","fork":false,"url":"https://api.github.com/repos/Khan/structured-blocks","forks_url":"https://api.github.com/repos/Khan/structured-blocks/forks","keys_url":"https://api.github.com/repos/Khan/structured-blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Khan/structured-blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Khan/structured-blocks/teams","hooks_url":"https://api.github.com/repos/Khan/structured-blocks/hooks","issue_events_url":"https://api.github.com/repos/Khan/structured-blocks/issues/events{/number}","events_url":"https://api.github.com/repos/Khan/structured-blocks/events","assignees_url":"https://api.github.com/repos/Khan/structured-blocks/assignees{/user}","branches_url":"https://api.github.com/repos/Khan/structured-blocks/branches{/branch}","tags_url":"https://api.github.com/repos/Khan/structured-blocks/tags","blobs_url":"https://api.github.com/repos/Khan/structured-blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Khan/structured-blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Khan/structured-blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Khan/structured-blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Khan/structured-blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/Khan/structured-blocks/languages","stargazers_url":"https://api.github.com/repos/Khan/structured-blocks/stargazers","contributors_url":"https://api.github.com/repos/Khan/structured-blocks/contributors","subscribers_url":"https://api.github.com/repos/Khan/structured-blocks/subscribers","subscription_url":"https://api.github.com/repos/Khan/structured-blocks/subscription","commits_url":"https://api.github.com/repos/Khan/structured-blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Khan/structured-blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Khan/structured-blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Khan/structured-blocks/issues/comments/{number}","contents_url":"https://api.github.com/repos/Khan/structured-blocks/contents/{+path}","compare_url":"https://api.github.com/repos/Khan/structured-blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Khan/structured-blocks/merges","archive_url":"https://api.github.com/repos/Khan/structured-blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Khan/structured-blocks/downloads","issues_url":"https://api.github.com/repos/Khan/structured-blocks/issues{/number}","pulls_url":"https://api.github.com/repos/Khan/structured-blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/Khan/structured-blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/Khan/structured-blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Khan/structured-blocks/labels{/name}","releases_url":"https://api.github.com/repos/Khan/structured-blocks/releases{/id}","created_at":"2014-10-16T16:50:15Z","updated_at":"2014-10-22T18:07:35Z","pushed_at":"2014-11-14T15:05:09Z","git_url":"git://github.com/Khan/structured-blocks.git","ssh_url":"git@github.com:Khan/structured-blocks.git","clone_url":"https://github.com/Khan/structured-blocks.git","svn_url":"https://github.com/Khan/structured-blocks","homepage":null,"size":876,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":1,"default_branch":"master"}},"base":{"label":"Khan:master","ref":"master","sha":"d3f9f38a0b8f1f932bb75f9e090c9e1960ae618f","user":{"login":"Khan","id":15455,"avatar_url":"https://avatars.githubusercontent.com/u/15455?v=3","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"repo":{"id":25311936,"name":"structured-blocks","full_name":"Khan/structured-blocks","owner":{"login":"Khan","id":15455,"avatar_url":"https://avatars.githubusercontent.com/u/15455?v=3","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Khan/structured-blocks","description":"","fork":false,"url":"https://api.github.com/repos/Khan/structured-blocks","forks_url":"https://api.github.com/repos/Khan/structured-blocks/forks","keys_url":"https://api.github.com/repos/Khan/structured-blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Khan/structured-blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Khan/structured-blocks/teams","hooks_url":"https://api.github.com/repos/Khan/structured-blocks/hooks","issue_events_url":"https://api.github.com/repos/Khan/structured-blocks/issues/events{/number}","events_url":"https://api.github.com/repos/Khan/structured-blocks/events","assignees_url":"https://api.github.com/repos/Khan/structured-blocks/assignees{/user}","branches_url":"https://api.github.com/repos/Khan/structured-blocks/branches{/branch}","tags_url":"https://api.github.com/repos/Khan/structured-blocks/tags","blobs_url":"https://api.github.com/repos/Khan/structured-blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Khan/structured-blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Khan/structured-blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Khan/structured-blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Khan/structured-blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/Khan/structured-blocks/languages","stargazers_url":"https://api.github.com/repos/Khan/structured-blocks/stargazers","contributors_url":"https://api.github.com/repos/Khan/structured-blocks/contributors","subscribers_url":"https://api.github.com/repos/Khan/structured-blocks/subscribers","subscription_url":"https://api.github.com/repos/Khan/structured-blocks/subscription","commits_url":"https://api.github.com/repos/Khan/structured-blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Khan/structured-blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Khan/structured-blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Khan/structured-blocks/issues/comments/{number}","contents_url":"https://api.github.com/repos/Khan/structured-blocks/contents/{+path}","compare_url":"https://api.github.com/repos/Khan/structured-blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Khan/structured-blocks/merges","archive_url":"https://api.github.com/repos/Khan/structured-blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Khan/structured-blocks/downloads","issues_url":"https://api.github.com/repos/Khan/structured-blocks/issues{/number}","pulls_url":"https://api.github.com/repos/Khan/structured-blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/Khan/structured-blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/Khan/structured-blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Khan/structured-blocks/labels{/name}","releases_url":"https://api.github.com/repos/Khan/structured-blocks/releases{/id}","created_at":"2014-10-16T16:50:15Z","updated_at":"2014-10-22T18:07:35Z","pushed_at":"2014-11-14T15:05:09Z","git_url":"git://github.com/Khan/structured-blocks.git","ssh_url":"git@github.com:Khan/structured-blocks.git","clone_url":"https://github.com/Khan/structured-blocks.git","svn_url":"https://github.com/Khan/structured-blocks","homepage":null,"size":876,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Khan/structured-blocks/pulls/22"},"html":{"href":"https://github.com/Khan/structured-blocks/pull/22"},"issue":{"href":"https://api.github.com/repos/Khan/structured-blocks/issues/22"},"comments":{"href":"https://api.github.com/repos/Khan/structured-blocks/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/Khan/structured-blocks/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/Khan/structured-blocks/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Khan/structured-blocks/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/Khan/structured-blocks/statuses/1ae9467af12c7db83482979e4986718d9d505f28"}}}}