GitHub PullRequestReviewCommentEvent at 2014-11-22 00:44:53
Repository: moonstone
Actor: clinuz
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/20752029","id":20752029,"diff_hunk":"@@ -416,6 +414,21 @@\n \t\t/**\n \t\t* @private\n \t\t*/\n+\t\tshowPercentageChanged: function(was) {\n+\t\t\tif (enyo.exists(ilib)) {","path":"source/Slider.js","position":16,"original_position":16,"commit_id":"557505d04e2aea794e99d93944d05c99f3d104d0","original_commit_id":"557505d04e2aea794e99d93944d05c99f3d104d0","user":{"login":"clinuz","id":639723,"avatar_url":"https://avatars.githubusercontent.com/u/639723?v=3","gravatar_id":"","url":"https://api.github.com/users/clinuz","html_url":"https://github.com/clinuz","followers_url":"https://api.github.com/users/clinuz/followers","following_url":"https://api.github.com/users/clinuz/following{/other_user}","gists_url":"https://api.github.com/users/clinuz/gists{/gist_id}","starred_url":"https://api.github.com/users/clinuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clinuz/subscriptions","organizations_url":"https://api.github.com/users/clinuz/orgs","repos_url":"https://api.github.com/users/clinuz/repos","events_url":"https://api.github.com/users/clinuz/events{/privacy}","received_events_url":"https://api.github.com/users/clinuz/received_events","type":"User","site_admin":false},"body":"Yes.","created_at":"2014-11-22T00:44:53Z","updated_at":"2014-11-22T00:44:53Z","html_url":"https://github.com/enyojs/moonstone/pull/1795#discussion_r20752029","pull_request_url":"https://api.github.com/repos/enyojs/moonstone/pulls/1795","_links":{"self":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/20752029"},"html":{"href":"https://github.com/enyojs/moonstone/pull/1795#discussion_r20752029"},"pull_request":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1795"}}},"pull_request":{"url":"https://api.github.com/repos/enyojs/moonstone/pulls/1795","id":24879024,"html_url":"https://github.com/enyojs/moonstone/pull/1795","diff_url":"https://github.com/enyojs/moonstone/pull/1795.diff","patch_url":"https://github.com/enyojs/moonstone/pull/1795.patch","issue_url":"https://api.github.com/repos/enyojs/moonstone/issues/1795","number":1795,"state":"open","locked":false,"title":"BHV-18024: Display negative sign properly for locale","user":{"login":"graynorton","id":32065,"avatar_url":"https://avatars.githubusercontent.com/u/32065?v=3","gravatar_id":"","url":"https://api.github.com/users/graynorton","html_url":"https://github.com/graynorton","followers_url":"https://api.github.com/users/graynorton/followers","following_url":"https://api.github.com/users/graynorton/following{/other_user}","gists_url":"https://api.github.com/users/graynorton/gists{/gist_id}","starred_url":"https://api.github.com/users/graynorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graynorton/subscriptions","organizations_url":"https://api.github.com/users/graynorton/orgs","repos_url":"https://api.github.com/users/graynorton/repos","events_url":"https://api.github.com/users/graynorton/events{/privacy}","received_events_url":"https://api.github.com/users/graynorton/received_events","type":"User","site_admin":false},"body":"moon.Slider was only applying locale-specific formatting to its\r\nvalue when showPercentage was true. Consequently, the placement\r\nof the negative sign for negative numbers (when showPercentage was\r\nfalse, as it normally would be for a slider supporting negative\r\nvalues) was not locale-sensitive. This caused problems because\r\nthe text direction of the slider's value popup was properly set\r\nper locale, but the value string was not, resulting in the negative\r\nsign being displayed on the wrong side for some locales.\r\n\r\nTo address this issue, we now apply locale-specific formatting of\r\nthe popup value in all cases.\r\n\r\nAlso modifying the Slider sample to include a slider with a\r\nnegative range, making this type of issue easier to test going\r\nforward. (Credit to Aaron Tam.)\r\n\r\nEnyo-DCO-1.1-Signed-Off-By: Gray Norton (gray.norton@lge.com)","created_at":"2014-11-22T00:11:59Z","updated_at":"2014-11-22T00:44:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d242484e28476ff64e4723a458dabff808ccb74","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enyojs/moonstone/pulls/1795/commits","review_comments_url":"https://api.github.com/repos/enyojs/moonstone/pulls/1795/comments","review_comment_url":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/{number}","comments_url":"https://api.github.com/repos/enyojs/moonstone/issues/1795/comments","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/557505d04e2aea794e99d93944d05c99f3d104d0","head":{"label":"enyojs:BHV-18024-graynorton","ref":"BHV-18024-graynorton","sha":"557505d04e2aea794e99d93944d05c99f3d104d0","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":7251076,"name":"moonstone","full_name":"enyojs/moonstone","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/moonstone","description":"Moonstone UI library for TV user interfaces.","fork":false,"url":"https://api.github.com/repos/enyojs/moonstone","forks_url":"https://api.github.com/repos/enyojs/moonstone/forks","keys_url":"https://api.github.com/repos/enyojs/moonstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/moonstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/moonstone/teams","hooks_url":"https://api.github.com/repos/enyojs/moonstone/hooks","issue_events_url":"https://api.github.com/repos/enyojs/moonstone/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/moonstone/events","assignees_url":"https://api.github.com/repos/enyojs/moonstone/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/moonstone/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/moonstone/tags","blobs_url":"https://api.github.com/repos/enyojs/moonstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/moonstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/moonstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/moonstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/moonstone/languages","stargazers_url":"https://api.github.com/repos/enyojs/moonstone/stargazers","contributors_url":"https://api.github.com/repos/enyojs/moonstone/contributors","subscribers_url":"https://api.github.com/repos/enyojs/moonstone/subscribers","subscription_url":"https://api.github.com/repos/enyojs/moonstone/subscription","commits_url":"https://api.github.com/repos/enyojs/moonstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/moonstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/moonstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/moonstone/issues/comments/{number}","contents_url":"https://api.github.com/repos/enyojs/moonstone/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/moonstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/moonstone/merges","archive_url":"https://api.github.com/repos/enyojs/moonstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/moonstone/downloads","issues_url":"https://api.github.com/repos/enyojs/moonstone/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/moonstone/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/moonstone/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/moonstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/moonstone/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/moonstone/releases{/id}","created_at":"2012-12-20T02:41:05Z","updated_at":"2014-11-21T23:45:31Z","pushed_at":"2014-11-22T00:13:28Z","git_url":"git://github.com/enyojs/moonstone.git","ssh_url":"git@github.com:enyojs/moonstone.git","clone_url":"https://github.com/enyojs/moonstone.git","svn_url":"https://github.com/enyojs/moonstone","homepage":"","size":101815,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":30,"forks":7,"open_issues":30,"watchers":29,"default_branch":"master"}},"base":{"label":"enyojs:master","ref":"master","sha":"f85c77584e3712a671d5fbd409c7d2142a62cc7f","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":7251076,"name":"moonstone","full_name":"enyojs/moonstone","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/moonstone","description":"Moonstone UI library for TV user interfaces.","fork":false,"url":"https://api.github.com/repos/enyojs/moonstone","forks_url":"https://api.github.com/repos/enyojs/moonstone/forks","keys_url":"https://api.github.com/repos/enyojs/moonstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/moonstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/moonstone/teams","hooks_url":"https://api.github.com/repos/enyojs/moonstone/hooks","issue_events_url":"https://api.github.com/repos/enyojs/moonstone/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/moonstone/events","assignees_url":"https://api.github.com/repos/enyojs/moonstone/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/moonstone/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/moonstone/tags","blobs_url":"https://api.github.com/repos/enyojs/moonstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/moonstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/moonstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/moonstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/moonstone/languages","stargazers_url":"https://api.github.com/repos/enyojs/moonstone/stargazers","contributors_url":"https://api.github.com/repos/enyojs/moonstone/contributors","subscribers_url":"https://api.github.com/repos/enyojs/moonstone/subscribers","subscription_url":"https://api.github.com/repos/enyojs/moonstone/subscription","commits_url":"https://api.github.com/repos/enyojs/moonstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/moonstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/moonstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/moonstone/issues/comments/{number}","contents_url":"https://api.github.com/repos/enyojs/moonstone/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/moonstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/moonstone/merges","archive_url":"https://api.github.com/repos/enyojs/moonstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/moonstone/downloads","issues_url":"https://api.github.com/repos/enyojs/moonstone/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/moonstone/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/moonstone/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/moonstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/moonstone/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/moonstone/releases{/id}","created_at":"2012-12-20T02:41:05Z","updated_at":"2014-11-21T23:45:31Z","pushed_at":"2014-11-22T00:13:28Z","git_url":"git://github.com/enyojs/moonstone.git","ssh_url":"git@github.com:enyojs/moonstone.git","clone_url":"https://github.com/enyojs/moonstone.git","svn_url":"https://github.com/enyojs/moonstone","homepage":"","size":101815,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":30,"forks":7,"open_issues":30,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1795"},"html":{"href":"https://github.com/enyojs/moonstone/pull/1795"},"issue":{"href":"https://api.github.com/repos/enyojs/moonstone/issues/1795"},"comments":{"href":"https://api.github.com/repos/enyojs/moonstone/issues/1795/comments"},"review_comments":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1795/comments"},"review_comment":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1795/commits"},"statuses":{"href":"https://api.github.com/repos/enyojs/moonstone/statuses/557505d04e2aea794e99d93944d05c99f3d104d0"}}}}