GitHub PullRequestEvent at 2014-12-02 03:20:04
Repository: modella
Actor: MatthewMueller
Payload: {"action":"closed","number":45,"pull_request":{"url":"https://api.github.com/repos/modella/modella/pulls/45","id":25179467,"html_url":"https://github.com/modella/modella/pull/45","diff_url":"https://github.com/modella/modella/pull/45.diff","patch_url":"https://github.com/modella/modella/pull/45.patch","issue_url":"https://api.github.com/repos/modella/modella/issues/45","number":45,"state":"closed","locked":false,"title":"Expose a base constructor for instanceof","user":{"login":"lvivier","id":679312,"avatar_url":"https://avatars.githubusercontent.com/u/679312?v=3","gravatar_id":"","url":"https://api.github.com/users/lvivier","html_url":"https://github.com/lvivier","followers_url":"https://api.github.com/users/lvivier/followers","following_url":"https://api.github.com/users/lvivier/following{/other_user}","gists_url":"https://api.github.com/users/lvivier/gists{/gist_id}","starred_url":"https://api.github.com/users/lvivier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvivier/subscriptions","organizations_url":"https://api.github.com/users/lvivier/orgs","repos_url":"https://api.github.com/users/lvivier/repos","events_url":"https://api.github.com/users/lvivier/events{/privacy}","received_events_url":"https://api.github.com/users/lvivier/received_events","type":"User","site_admin":false},"body":"For #37. It'd be useful to have a public \"base class\" to unequivocally identify a modella model:\r\n\r\n```js\r\nvar model = require('modella')\r\nvar Shark = model('Shark')\r\nvar s = new Shark()\r\n\r\ns instanceof Shark\r\ns instanceof model.Model\r\n```\r\n\r\nIn this PR the constructor does nothing but lend its name to the proud lineage of all models, but we could move stuff in there if we care about that.","created_at":"2014-11-28T06:31:12Z","updated_at":"2014-12-02T03:20:02Z","closed_at":"2014-12-02T03:20:02Z","merged_at":"2014-12-02T03:20:02Z","merge_commit_sha":"2170d81ff495a7b9bfd145fd5837df03d93e0c8e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/modella/modella/pulls/45/commits","review_comments_url":"https://api.github.com/repos/modella/modella/pulls/45/comments","review_comment_url":"https://api.github.com/repos/modella/modella/pulls/comments/{number}","comments_url":"https://api.github.com/repos/modella/modella/issues/45/comments","statuses_url":"https://api.github.com/repos/modella/modella/statuses/288960d0cb455b7ca8c12416523f1f50d6306bf2","head":{"label":"lvivier:instanceof","ref":"instanceof","sha":"288960d0cb455b7ca8c12416523f1f50d6306bf2","user":{"login":"lvivier","id":679312,"avatar_url":"https://avatars.githubusercontent.com/u/679312?v=3","gravatar_id":"","url":"https://api.github.com/users/lvivier","html_url":"https://github.com/lvivier","followers_url":"https://api.github.com/users/lvivier/followers","following_url":"https://api.github.com/users/lvivier/following{/other_user}","gists_url":"https://api.github.com/users/lvivier/gists{/gist_id}","starred_url":"https://api.github.com/users/lvivier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvivier/subscriptions","organizations_url":"https://api.github.com/users/lvivier/orgs","repos_url":"https://api.github.com/users/lvivier/repos","events_url":"https://api.github.com/users/lvivier/events{/privacy}","received_events_url":"https://api.github.com/users/lvivier/received_events","type":"User","site_admin":false},"repo":{"id":18661122,"name":"modella","full_name":"lvivier/modella","owner":{"login":"lvivier","id":679312,"avatar_url":"https://avatars.githubusercontent.com/u/679312?v=3","gravatar_id":"","url":"https://api.github.com/users/lvivier","html_url":"https://github.com/lvivier","followers_url":"https://api.github.com/users/lvivier/followers","following_url":"https://api.github.com/users/lvivier/following{/other_user}","gists_url":"https://api.github.com/users/lvivier/gists{/gist_id}","starred_url":"https://api.github.com/users/lvivier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvivier/subscriptions","organizations_url":"https://api.github.com/users/lvivier/orgs","repos_url":"https://api.github.com/users/lvivier/repos","events_url":"https://api.github.com/users/lvivier/events{/privacy}","received_events_url":"https://api.github.com/users/lvivier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lvivier/modella","description":"simpler models for both client & server","fork":true,"url":"https://api.github.com/repos/lvivier/modella","forks_url":"https://api.github.com/repos/lvivier/modella/forks","keys_url":"https://api.github.com/repos/lvivier/modella/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lvivier/modella/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lvivier/modella/teams","hooks_url":"https://api.github.com/repos/lvivier/modella/hooks","issue_events_url":"https://api.github.com/repos/lvivier/modella/issues/events{/number}","events_url":"https://api.github.com/repos/lvivier/modella/events","assignees_url":"https://api.github.com/repos/lvivier/modella/assignees{/user}","branches_url":"https://api.github.com/repos/lvivier/modella/branches{/branch}","tags_url":"https://api.github.com/repos/lvivier/modella/tags","blobs_url":"https://api.github.com/repos/lvivier/modella/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lvivier/modella/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lvivier/modella/git/refs{/sha}","trees_url":"https://api.github.com/repos/lvivier/modella/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lvivier/modella/statuses/{sha}","languages_url":"https://api.github.com/repos/lvivier/modella/languages","stargazers_url":"https://api.github.com/repos/lvivier/modella/stargazers","contributors_url":"https://api.github.com/repos/lvivier/modella/contributors","subscribers_url":"https://api.github.com/repos/lvivier/modella/subscribers","subscription_url":"https://api.github.com/repos/lvivier/modella/subscription","commits_url":"https://api.github.com/repos/lvivier/modella/commits{/sha}","git_commits_url":"https://api.github.com/repos/lvivier/modella/git/commits{/sha}","comments_url":"https://api.github.com/repos/lvivier/modella/comments{/number}","issue_comment_url":"https://api.github.com/repos/lvivier/modella/issues/comments/{number}","contents_url":"https://api.github.com/repos/lvivier/modella/contents/{+path}","compare_url":"https://api.github.com/repos/lvivier/modella/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lvivier/modella/merges","archive_url":"https://api.github.com/repos/lvivier/modella/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lvivier/modella/downloads","issues_url":"https://api.github.com/repos/lvivier/modella/issues{/number}","pulls_url":"https://api.github.com/repos/lvivier/modella/pulls{/number}","milestones_url":"https://api.github.com/repos/lvivier/modella/milestones{/number}","notifications_url":"https://api.github.com/repos/lvivier/modella/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lvivier/modella/labels{/name}","releases_url":"https://api.github.com/repos/lvivier/modella/releases{/id}","created_at":"2014-04-11T03:30:27Z","updated_at":"2014-11-28T06:11:55Z","pushed_at":"2014-11-28T06:53:50Z","git_url":"git://github.com/lvivier/modella.git","ssh_url":"git@github.com:lvivier/modella.git","clone_url":"https://github.com/lvivier/modella.git","svn_url":"https://github.com/lvivier/modella","homepage":"","size":632,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"modella:master","ref":"master","sha":"5daba4a3ebc8bc199f101d68a01b6acb42fa2eb0","user":{"login":"modella","id":3781667,"avatar_url":"https://avatars.githubusercontent.com/u/3781667?v=3","gravatar_id":"","url":"https://api.github.com/users/modella","html_url":"https://github.com/modella","followers_url":"https://api.github.com/users/modella/followers","following_url":"https://api.github.com/users/modella/following{/other_user}","gists_url":"https://api.github.com/users/modella/gists{/gist_id}","starred_url":"https://api.github.com/users/modella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modella/subscriptions","organizations_url":"https://api.github.com/users/modella/orgs","repos_url":"https://api.github.com/users/modella/repos","events_url":"https://api.github.com/users/modella/events{/privacy}","received_events_url":"https://api.github.com/users/modella/received_events","type":"Organization","site_admin":false},"repo":{"id":7337389,"name":"modella","full_name":"modella/modella","owner":{"login":"modella","id":3781667,"avatar_url":"https://avatars.githubusercontent.com/u/3781667?v=3","gravatar_id":"","url":"https://api.github.com/users/modella","html_url":"https://github.com/modella","followers_url":"https://api.github.com/users/modella/followers","following_url":"https://api.github.com/users/modella/following{/other_user}","gists_url":"https://api.github.com/users/modella/gists{/gist_id}","starred_url":"https://api.github.com/users/modella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modella/subscriptions","organizations_url":"https://api.github.com/users/modella/orgs","repos_url":"https://api.github.com/users/modella/repos","events_url":"https://api.github.com/users/modella/events{/privacy}","received_events_url":"https://api.github.com/users/modella/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modella/modella","description":"simpler models for both client & server","fork":false,"url":"https://api.github.com/repos/modella/modella","forks_url":"https://api.github.com/repos/modella/modella/forks","keys_url":"https://api.github.com/repos/modella/modella/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modella/modella/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modella/modella/teams","hooks_url":"https://api.github.com/repos/modella/modella/hooks","issue_events_url":"https://api.github.com/repos/modella/modella/issues/events{/number}","events_url":"https://api.github.com/repos/modella/modella/events","assignees_url":"https://api.github.com/repos/modella/modella/assignees{/user}","branches_url":"https://api.github.com/repos/modella/modella/branches{/branch}","tags_url":"https://api.github.com/repos/modella/modella/tags","blobs_url":"https://api.github.com/repos/modella/modella/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modella/modella/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modella/modella/git/refs{/sha}","trees_url":"https://api.github.com/repos/modella/modella/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modella/modella/statuses/{sha}","languages_url":"https://api.github.com/repos/modella/modella/languages","stargazers_url":"https://api.github.com/repos/modella/modella/stargazers","contributors_url":"https://api.github.com/repos/modella/modella/contributors","subscribers_url":"https://api.github.com/repos/modella/modella/subscribers","subscription_url":"https://api.github.com/repos/modella/modella/subscription","commits_url":"https://api.github.com/repos/modella/modella/commits{/sha}","git_commits_url":"https://api.github.com/repos/modella/modella/git/commits{/sha}","comments_url":"https://api.github.com/repos/modella/modella/comments{/number}","issue_comment_url":"https://api.github.com/repos/modella/modella/issues/comments/{number}","contents_url":"https://api.github.com/repos/modella/modella/contents/{+path}","compare_url":"https://api.github.com/repos/modella/modella/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modella/modella/merges","archive_url":"https://api.github.com/repos/modella/modella/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modella/modella/downloads","issues_url":"https://api.github.com/repos/modella/modella/issues{/number}","pulls_url":"https://api.github.com/repos/modella/modella/pulls{/number}","milestones_url":"https://api.github.com/repos/modella/modella/milestones{/number}","notifications_url":"https://api.github.com/repos/modella/modella/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modella/modella/labels{/name}","releases_url":"https://api.github.com/repos/modella/modella/releases{/id}","created_at":"2012-12-27T07:44:23Z","updated_at":"2014-12-02T03:20:03Z","pushed_at":"2014-12-02T03:20:03Z","git_url":"git://github.com/modella/modella.git","ssh_url":"git@github.com:modella/modella.git","clone_url":"https://github.com/modella/modella.git","svn_url":"https://github.com/modella/modella","homepage":"","size":1591,"stargazers_count":208,"watchers_count":208,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":7,"forks":13,"open_issues":7,"watchers":208,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/modella/modella/pulls/45"},"html":{"href":"https://github.com/modella/modella/pull/45"},"issue":{"href":"https://api.github.com/repos/modella/modella/issues/45"},"comments":{"href":"https://api.github.com/repos/modella/modella/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/modella/modella/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/modella/modella/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/modella/modella/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/modella/modella/statuses/288960d0cb455b7ca8c12416523f1f50d6306bf2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MatthewMueller","id":170299,"avatar_url":"https://avatars.githubusercontent.com/u/170299?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewMueller","html_url":"https://github.com/MatthewMueller","followers_url":"https://api.github.com/users/MatthewMueller/followers","following_url":"https://api.github.com/users/MatthewMueller/following{/other_user}","gists_url":"https://api.github.com/users/MatthewMueller/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewMueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewMueller/subscriptions","organizations_url":"https://api.github.com/users/MatthewMueller/orgs","repos_url":"https://api.github.com/users/MatthewMueller/repos","events_url":"https://api.github.com/users/MatthewMueller/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewMueller/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":2,"changed_files":2}}