GitHub PullRequestReviewCommentEvent at 2014-06-28 22:42:14
Repository: zds-site
Actor: SpaceFox
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments/14326652","id":14326652,"diff_hunk":"@@ -24,9 +24,10 @@\n         Annuler la réservation\n     </a>\n     {# TODO_CSRF : passer en post #}\n-    <form action=\"{% url \"zds.tutorial.views.reservation\" validation.pk %}\" mathod=\"get\" class=\"modal modal-small\" id=\"unreservation\">\n+    <form action=\"{{ reservation_url }}\" mathod=\"get\" class=\"modal modal-small\" id=\"unreservation\">","path":"templates/misc/validation.part.html","position":null,"original_position":14,"commit_id":"5ad93bae6d15f0d84f9699d85cd3e1f74bab543b","original_commit_id":"e493e4fdcb81defaade8cf46dd3bf7af06b73953","user":{"login":"SpaceFox","id":5786268,"avatar_url":"https://avatars.githubusercontent.com/u/5786268?","gravatar_id":"92d3276347d34933b5dd417e13f44fbd","url":"https://api.github.com/users/SpaceFox","html_url":"https://github.com/SpaceFox","followers_url":"https://api.github.com/users/SpaceFox/followers","following_url":"https://api.github.com/users/SpaceFox/following{/other_user}","gists_url":"https://api.github.com/users/SpaceFox/gists{/gist_id}","starred_url":"https://api.github.com/users/SpaceFox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpaceFox/subscriptions","organizations_url":"https://api.github.com/users/SpaceFox/orgs","repos_url":"https://api.github.com/users/SpaceFox/repos","events_url":"https://api.github.com/users/SpaceFox/events{/privacy}","received_events_url":"https://api.github.com/users/SpaceFox/received_events","type":"User","site_admin":false},"body":"Ca fonctionne uniquement parce que je n'ai pas encore interdit autre chose\r\nque le POST sur les méthodes en question...\r\n\r\nBref, laissez-le parce que ça va partir avec ma modif (et ça me simplifie\r\nle test).\r\n\r\n\r\nLe 29 juin 2014 00:40, Alexandre Demode <notifications@github.com> a écrit :\r\n\r\n> In templates/misc/validation.part.html:\r\n>\r\n> > @@ -24,9 +24,10 @@\r\n> >          Annuler la réservation\r\n> >      </a>\r\n> >      {# TODO_CSRF : passer en post #}\r\n> > -    <form action=\"{% url \"zds.tutorial.views.reservation\" validation.pk %}\" mathod=\"get\" class=\"modal modal-small\" id=\"unreservation\">\r\n> > +    <form action=\"{{ reservation_url }}\" mathod=\"get\" class=\"modal modal-small\" id=\"unreservation\">\r\n>\r\n> Le pire c'est que ça fonctionne... vu que c'est méthode par défaut ><\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/zestedesavoir/zds-site/pull/1015/files#r14326640>.\r\n>","created_at":"2014-06-28T22:42:14Z","updated_at":"2014-06-28T22:42:14Z","html_url":"https://github.com/zestedesavoir/zds-site/pull/1015#discussion_r14326652","pull_request_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1015","_links":{"self":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments/14326652"},"html":{"href":"https://github.com/zestedesavoir/zds-site/pull/1015#discussion_r14326652"},"pull_request":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1015"}}},"pull_request":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1015","id":17742118,"html_url":"https://github.com/zestedesavoir/zds-site/pull/1015","diff_url":"https://github.com/zestedesavoir/zds-site/pull/1015.diff","patch_url":"https://github.com/zestedesavoir/zds-site/pull/1015.patch","issue_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/1015","number":1015,"state":"open","title":"Factorisation de la validation articles/tutoriels","user":{"login":"Alex-D","id":426843,"avatar_url":"https://avatars.githubusercontent.com/u/426843?","gravatar_id":"9f56c461a84e03b256246a4957aabeda","url":"https://api.github.com/users/Alex-D","html_url":"https://github.com/Alex-D","followers_url":"https://api.github.com/users/Alex-D/followers","following_url":"https://api.github.com/users/Alex-D/following{/other_user}","gists_url":"https://api.github.com/users/Alex-D/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex-D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex-D/subscriptions","organizations_url":"https://api.github.com/users/Alex-D/orgs","repos_url":"https://api.github.com/users/Alex-D/repos","events_url":"https://api.github.com/users/Alex-D/events{/privacy}","received_events_url":"https://api.github.com/users/Alex-D/received_events","type":"User","site_admin":false},"body":"| Q                         | R\r\n| ------------------------- | -------------------------------------------\r\n| Correction de bugs ?      | Non\r\n| Nouvelle Fonctionnalité ? | \"Oui\"\r\n| Tickets concernés         | #497\r\n\r\nLa factorisation permet d'avoir le même formulaire sur la validation des tutoriels et articles, permettant ainsi la gestion des CSRF des deux côtés.","created_at":"2014-06-28T22:19:16Z","updated_at":"2014-06-28T22:42:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bec20ac5ca32b11cbaa560ada54f95dea7629b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1015/commits","review_comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1015/comments","review_comment_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/1015/comments","statuses_url":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/5ad93bae6d15f0d84f9699d85cd3e1f74bab543b","head":{"label":"Alex-D:csrf_articles","ref":"csrf_articles","sha":"5ad93bae6d15f0d84f9699d85cd3e1f74bab543b","user":{"login":"Alex-D","id":426843,"avatar_url":"https://avatars.githubusercontent.com/u/426843?","gravatar_id":"9f56c461a84e03b256246a4957aabeda","url":"https://api.github.com/users/Alex-D","html_url":"https://github.com/Alex-D","followers_url":"https://api.github.com/users/Alex-D/followers","following_url":"https://api.github.com/users/Alex-D/following{/other_user}","gists_url":"https://api.github.com/users/Alex-D/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex-D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex-D/subscriptions","organizations_url":"https://api.github.com/users/Alex-D/orgs","repos_url":"https://api.github.com/users/Alex-D/repos","events_url":"https://api.github.com/users/Alex-D/events{/privacy}","received_events_url":"https://api.github.com/users/Alex-D/received_events","type":"User","site_admin":false},"repo":{"id":20327847,"name":"zds-site","full_name":"Alex-D/zds-site","owner":{"login":"Alex-D","id":426843,"avatar_url":"https://avatars.githubusercontent.com/u/426843?","gravatar_id":"9f56c461a84e03b256246a4957aabeda","url":"https://api.github.com/users/Alex-D","html_url":"https://github.com/Alex-D","followers_url":"https://api.github.com/users/Alex-D/followers","following_url":"https://api.github.com/users/Alex-D/following{/other_user}","gists_url":"https://api.github.com/users/Alex-D/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex-D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex-D/subscriptions","organizations_url":"https://api.github.com/users/Alex-D/orgs","repos_url":"https://api.github.com/users/Alex-D/repos","events_url":"https://api.github.com/users/Alex-D/events{/privacy}","received_events_url":"https://api.github.com/users/Alex-D/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Alex-D/zds-site","description":"Dépot ZDS","fork":true,"url":"https://api.github.com/repos/Alex-D/zds-site","forks_url":"https://api.github.com/repos/Alex-D/zds-site/forks","keys_url":"https://api.github.com/repos/Alex-D/zds-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alex-D/zds-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alex-D/zds-site/teams","hooks_url":"https://api.github.com/repos/Alex-D/zds-site/hooks","issue_events_url":"https://api.github.com/repos/Alex-D/zds-site/issues/events{/number}","events_url":"https://api.github.com/repos/Alex-D/zds-site/events","assignees_url":"https://api.github.com/repos/Alex-D/zds-site/assignees{/user}","branches_url":"https://api.github.com/repos/Alex-D/zds-site/branches{/branch}","tags_url":"https://api.github.com/repos/Alex-D/zds-site/tags","blobs_url":"https://api.github.com/repos/Alex-D/zds-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alex-D/zds-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alex-D/zds-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alex-D/zds-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alex-D/zds-site/statuses/{sha}","languages_url":"https://api.github.com/repos/Alex-D/zds-site/languages","stargazers_url":"https://api.github.com/repos/Alex-D/zds-site/stargazers","contributors_url":"https://api.github.com/repos/Alex-D/zds-site/contributors","subscribers_url":"https://api.github.com/repos/Alex-D/zds-site/subscribers","subscription_url":"https://api.github.com/repos/Alex-D/zds-site/subscription","commits_url":"https://api.github.com/repos/Alex-D/zds-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alex-D/zds-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alex-D/zds-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alex-D/zds-site/issues/comments/{number}","contents_url":"https://api.github.com/repos/Alex-D/zds-site/contents/{+path}","compare_url":"https://api.github.com/repos/Alex-D/zds-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alex-D/zds-site/merges","archive_url":"https://api.github.com/repos/Alex-D/zds-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alex-D/zds-site/downloads","issues_url":"https://api.github.com/repos/Alex-D/zds-site/issues{/number}","pulls_url":"https://api.github.com/repos/Alex-D/zds-site/pulls{/number}","milestones_url":"https://api.github.com/repos/Alex-D/zds-site/milestones{/number}","notifications_url":"https://api.github.com/repos/Alex-D/zds-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alex-D/zds-site/labels{/name}","releases_url":"https://api.github.com/repos/Alex-D/zds-site/releases{/id}","created_at":"2014-05-30T11:58:38Z","updated_at":"2014-06-24T23:12:55Z","pushed_at":"2014-06-28T22:41:34Z","git_url":"git://github.com/Alex-D/zds-site.git","ssh_url":"git@github.com:Alex-D/zds-site.git","clone_url":"https://github.com/Alex-D/zds-site.git","svn_url":"https://github.com/Alex-D/zds-site","homepage":null,"size":41092,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"integration"}},"base":{"label":"zestedesavoir:beta-0.2","ref":"beta-0.2","sha":"82d644326fed97dcc5d131026eed9922295508ea","user":{"login":"zestedesavoir","id":7406239,"avatar_url":"https://avatars.githubusercontent.com/u/7406239?","gravatar_id":null,"url":"https://api.github.com/users/zestedesavoir","html_url":"https://github.com/zestedesavoir","followers_url":"https://api.github.com/users/zestedesavoir/followers","following_url":"https://api.github.com/users/zestedesavoir/following{/other_user}","gists_url":"https://api.github.com/users/zestedesavoir/gists{/gist_id}","starred_url":"https://api.github.com/users/zestedesavoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zestedesavoir/subscriptions","organizations_url":"https://api.github.com/users/zestedesavoir/orgs","repos_url":"https://api.github.com/users/zestedesavoir/repos","events_url":"https://api.github.com/users/zestedesavoir/events{/privacy}","received_events_url":"https://api.github.com/users/zestedesavoir/received_events","type":"Organization","site_admin":false},"repo":{"id":14778920,"name":"zds-site","full_name":"zestedesavoir/zds-site","owner":{"login":"zestedesavoir","id":7406239,"avatar_url":"https://avatars.githubusercontent.com/u/7406239?","gravatar_id":null,"url":"https://api.github.com/users/zestedesavoir","html_url":"https://github.com/zestedesavoir","followers_url":"https://api.github.com/users/zestedesavoir/followers","following_url":"https://api.github.com/users/zestedesavoir/following{/other_user}","gists_url":"https://api.github.com/users/zestedesavoir/gists{/gist_id}","starred_url":"https://api.github.com/users/zestedesavoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zestedesavoir/subscriptions","organizations_url":"https://api.github.com/users/zestedesavoir/orgs","repos_url":"https://api.github.com/users/zestedesavoir/repos","events_url":"https://api.github.com/users/zestedesavoir/events{/privacy}","received_events_url":"https://api.github.com/users/zestedesavoir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zestedesavoir/zds-site","description":"Dépot ZDS","fork":false,"url":"https://api.github.com/repos/zestedesavoir/zds-site","forks_url":"https://api.github.com/repos/zestedesavoir/zds-site/forks","keys_url":"https://api.github.com/repos/zestedesavoir/zds-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zestedesavoir/zds-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zestedesavoir/zds-site/teams","hooks_url":"https://api.github.com/repos/zestedesavoir/zds-site/hooks","issue_events_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/events{/number}","events_url":"https://api.github.com/repos/zestedesavoir/zds-site/events","assignees_url":"https://api.github.com/repos/zestedesavoir/zds-site/assignees{/user}","branches_url":"https://api.github.com/repos/zestedesavoir/zds-site/branches{/branch}","tags_url":"https://api.github.com/repos/zestedesavoir/zds-site/tags","blobs_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/{sha}","languages_url":"https://api.github.com/repos/zestedesavoir/zds-site/languages","stargazers_url":"https://api.github.com/repos/zestedesavoir/zds-site/stargazers","contributors_url":"https://api.github.com/repos/zestedesavoir/zds-site/contributors","subscribers_url":"https://api.github.com/repos/zestedesavoir/zds-site/subscribers","subscription_url":"https://api.github.com/repos/zestedesavoir/zds-site/subscription","commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/comments/{number}","contents_url":"https://api.github.com/repos/zestedesavoir/zds-site/contents/{+path}","compare_url":"https://api.github.com/repos/zestedesavoir/zds-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zestedesavoir/zds-site/merges","archive_url":"https://api.github.com/repos/zestedesavoir/zds-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zestedesavoir/zds-site/downloads","issues_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues{/number}","pulls_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls{/number}","milestones_url":"https://api.github.com/repos/zestedesavoir/zds-site/milestones{/number}","notifications_url":"https://api.github.com/repos/zestedesavoir/zds-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zestedesavoir/zds-site/labels{/name}","releases_url":"https://api.github.com/repos/zestedesavoir/zds-site/releases{/id}","created_at":"2013-11-28T14:23:48Z","updated_at":"2014-06-25T20:47:52Z","pushed_at":"2014-06-28T21:36:21Z","git_url":"git://github.com/zestedesavoir/zds-site.git","ssh_url":"git@github.com:zestedesavoir/zds-site.git","clone_url":"https://github.com/zestedesavoir/zds-site.git","svn_url":"https://github.com/zestedesavoir/zds-site","homepage":null,"size":120138,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":25,"mirror_url":null,"open_issues_count":118,"forks":25,"open_issues":118,"watchers":31,"default_branch":"beta-0.2"}},"_links":{"self":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1015"},"html":{"href":"https://github.com/zestedesavoir/zds-site/pull/1015"},"issue":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/issues/1015"},"comments":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/issues/1015/comments"},"review_comments":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1015/comments"},"review_comment":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/1015/commits"},"statuses":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/5ad93bae6d15f0d84f9699d85cd3e1f74bab543b"}}}}