GitHub PullRequestReviewCommentEvent at 2014-11-20 07:12:22
Repository: LocalSupport
Actor: johnnymo87
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls/comments/20630509","id":20630509,"diff_hunk":"@@ -73,6 +73,24 @@ def org_owner?\n \n   end\n \n+  def build_markers(organisations)\n+    Gmaps4rails.build_markers(organisations) do |org, marker|\n+      marker.lat org.latitude","path":"app/controllers/volunteer_ops_controller.rb","position":null,"original_position":32,"commit_id":"1620689a08d7fb93341f565d142eba3603e10293","original_commit_id":"aee51f1f80f75dc6382f5a20f2086c26bd893a2e","user":{"login":"johnnymo87","id":3466499,"avatar_url":"https://avatars.githubusercontent.com/u/3466499?v=3","gravatar_id":"","url":"https://api.github.com/users/johnnymo87","html_url":"https://github.com/johnnymo87","followers_url":"https://api.github.com/users/johnnymo87/followers","following_url":"https://api.github.com/users/johnnymo87/following{/other_user}","gists_url":"https://api.github.com/users/johnnymo87/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnymo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnymo87/subscriptions","organizations_url":"https://api.github.com/users/johnnymo87/orgs","repos_url":"https://api.github.com/users/johnnymo87/repos","events_url":"https://api.github.com/users/johnnymo87/events{/privacy}","received_events_url":"https://api.github.com/users/johnnymo87/received_events","type":"User","site_admin":false},"body":"OK, i just extracted the shared logic to `MapMarkerJson`.","created_at":"2014-11-20T07:12:22Z","updated_at":"2014-11-20T07:12:22Z","html_url":"https://github.com/AgileVentures/LocalSupport/pull/115#discussion_r20630509","pull_request_url":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls/comments/20630509"},"html":{"href":"https://github.com/AgileVentures/LocalSupport/pull/115#discussion_r20630509"},"pull_request":{"href":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls/115","id":24497086,"html_url":"https://github.com/AgileVentures/LocalSupport/pull/115","diff_url":"https://github.com/AgileVentures/LocalSupport/pull/115.diff","patch_url":"https://github.com/AgileVentures/LocalSupport/pull/115.patch","issue_url":"https://api.github.com/repos/AgileVentures/LocalSupport/issues/115","number":115,"state":"open","locked":false,"title":"[RFC] Upgrades Gmaps4rails","user":{"login":"johnnymo87","id":3466499,"avatar_url":"https://avatars.githubusercontent.com/u/3466499?v=3","gravatar_id":"","url":"https://api.github.com/users/johnnymo87","html_url":"https://github.com/johnnymo87","followers_url":"https://api.github.com/users/johnnymo87/followers","following_url":"https://api.github.com/users/johnnymo87/following{/other_user}","gists_url":"https://api.github.com/users/johnnymo87/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnymo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnymo87/subscriptions","organizations_url":"https://api.github.com/users/johnnymo87/orgs","repos_url":"https://api.github.com/users/johnnymo87/repos","events_url":"https://api.github.com/users/johnnymo87/events{/privacy}","received_events_url":"https://api.github.com/users/johnnymo87/received_events","type":"User","site_admin":false},"body":"We're blocked on our rails 4.1 branches with failing jasmine test suites. In this past, we relied on a hack to get jasmine working with version 1.5.6 of gem `gmaps4rails`([commit](https://github.com/AgileVentures/LocalSupport/commit/99fc4bf7239806b7864dcedab5a9cd8198b0661b)), but this no longer seems to work with rails 4.1. Rather than extend the hack, let's just upgrade our `gmaps4rails` gem.\r\n\r\n[Staged here](https://gmaps-upgrade.herokuapp.com/).\r\n\r\nTODO:\r\n- [x] get new maps working\r\n- [x] configure map options (center, infowindow)\r\n- [x] update rspec\r\n- [x] update cucumber\r\n- [x] DELETE JASMINE RAKE TASK!","created_at":"2014-11-16T02:27:51Z","updated_at":"2014-11-20T07:12:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c17baebfd742623f7f634941edbefb7b5ace3005","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls/115/commits","review_comments_url":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls/115/comments","review_comment_url":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls/comments/{number}","comments_url":"https://api.github.com/repos/AgileVentures/LocalSupport/issues/115/comments","statuses_url":"https://api.github.com/repos/AgileVentures/LocalSupport/statuses/1620689a08d7fb93341f565d142eba3603e10293","head":{"label":"johnnymo87:gmaps4rails","ref":"gmaps4rails","sha":"1620689a08d7fb93341f565d142eba3603e10293","user":{"login":"johnnymo87","id":3466499,"avatar_url":"https://avatars.githubusercontent.com/u/3466499?v=3","gravatar_id":"","url":"https://api.github.com/users/johnnymo87","html_url":"https://github.com/johnnymo87","followers_url":"https://api.github.com/users/johnnymo87/followers","following_url":"https://api.github.com/users/johnnymo87/following{/other_user}","gists_url":"https://api.github.com/users/johnnymo87/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnymo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnymo87/subscriptions","organizations_url":"https://api.github.com/users/johnnymo87/orgs","repos_url":"https://api.github.com/users/johnnymo87/repos","events_url":"https://api.github.com/users/johnnymo87/events{/privacy}","received_events_url":"https://api.github.com/users/johnnymo87/received_events","type":"User","site_admin":false},"repo":{"id":12708183,"name":"LocalSupport","full_name":"johnnymo87/LocalSupport","owner":{"login":"johnnymo87","id":3466499,"avatar_url":"https://avatars.githubusercontent.com/u/3466499?v=3","gravatar_id":"","url":"https://api.github.com/users/johnnymo87","html_url":"https://github.com/johnnymo87","followers_url":"https://api.github.com/users/johnnymo87/followers","following_url":"https://api.github.com/users/johnnymo87/following{/other_user}","gists_url":"https://api.github.com/users/johnnymo87/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnymo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnymo87/subscriptions","organizations_url":"https://api.github.com/users/johnnymo87/orgs","repos_url":"https://api.github.com/users/johnnymo87/repos","events_url":"https://api.github.com/users/johnnymo87/events{/privacy}","received_events_url":"https://api.github.com/users/johnnymo87/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnnymo87/LocalSupport","description":"A directory of local support services","fork":true,"url":"https://api.github.com/repos/johnnymo87/LocalSupport","forks_url":"https://api.github.com/repos/johnnymo87/LocalSupport/forks","keys_url":"https://api.github.com/repos/johnnymo87/LocalSupport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnnymo87/LocalSupport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnnymo87/LocalSupport/teams","hooks_url":"https://api.github.com/repos/johnnymo87/LocalSupport/hooks","issue_events_url":"https://api.github.com/repos/johnnymo87/LocalSupport/issues/events{/number}","events_url":"https://api.github.com/repos/johnnymo87/LocalSupport/events","assignees_url":"https://api.github.com/repos/johnnymo87/LocalSupport/assignees{/user}","branches_url":"https://api.github.com/repos/johnnymo87/LocalSupport/branches{/branch}","tags_url":"https://api.github.com/repos/johnnymo87/LocalSupport/tags","blobs_url":"https://api.github.com/repos/johnnymo87/LocalSupport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnnymo87/LocalSupport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnnymo87/LocalSupport/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnnymo87/LocalSupport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnnymo87/LocalSupport/statuses/{sha}","languages_url":"https://api.github.com/repos/johnnymo87/LocalSupport/languages","stargazers_url":"https://api.github.com/repos/johnnymo87/LocalSupport/stargazers","contributors_url":"https://api.github.com/repos/johnnymo87/LocalSupport/contributors","subscribers_url":"https://api.github.com/repos/johnnymo87/LocalSupport/subscribers","subscription_url":"https://api.github.com/repos/johnnymo87/LocalSupport/subscription","commits_url":"https://api.github.com/repos/johnnymo87/LocalSupport/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnnymo87/LocalSupport/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnnymo87/LocalSupport/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnnymo87/LocalSupport/issues/comments/{number}","contents_url":"https://api.github.com/repos/johnnymo87/LocalSupport/contents/{+path}","compare_url":"https://api.github.com/repos/johnnymo87/LocalSupport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnnymo87/LocalSupport/merges","archive_url":"https://api.github.com/repos/johnnymo87/LocalSupport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnnymo87/LocalSupport/downloads","issues_url":"https://api.github.com/repos/johnnymo87/LocalSupport/issues{/number}","pulls_url":"https://api.github.com/repos/johnnymo87/LocalSupport/pulls{/number}","milestones_url":"https://api.github.com/repos/johnnymo87/LocalSupport/milestones{/number}","notifications_url":"https://api.github.com/repos/johnnymo87/LocalSupport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnnymo87/LocalSupport/labels{/name}","releases_url":"https://api.github.com/repos/johnnymo87/LocalSupport/releases{/id}","created_at":"2013-09-09T17:47:26Z","updated_at":"2014-06-20T18:53:01Z","pushed_at":"2014-11-20T06:55:59Z","git_url":"git://github.com/johnnymo87/LocalSupport.git","ssh_url":"git@github.com:johnnymo87/LocalSupport.git","clone_url":"https://github.com/johnnymo87/LocalSupport.git","svn_url":"https://github.com/johnnymo87/LocalSupport","homepage":null,"size":9004,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"develop"}},"base":{"label":"AgileVentures:develop","ref":"develop","sha":"40b57d9f8c84a5a33f9c5d28095aad7d96f868dc","user":{"login":"AgileVentures","id":5116968,"avatar_url":"https://avatars.githubusercontent.com/u/5116968?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"repo":{"id":14499588,"name":"LocalSupport","full_name":"AgileVentures/LocalSupport","owner":{"login":"AgileVentures","id":5116968,"avatar_url":"https://avatars.githubusercontent.com/u/5116968?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AgileVentures/LocalSupport","description":"A directory of local support services and volunteer opportunities","fork":true,"url":"https://api.github.com/repos/AgileVentures/LocalSupport","forks_url":"https://api.github.com/repos/AgileVentures/LocalSupport/forks","keys_url":"https://api.github.com/repos/AgileVentures/LocalSupport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AgileVentures/LocalSupport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AgileVentures/LocalSupport/teams","hooks_url":"https://api.github.com/repos/AgileVentures/LocalSupport/hooks","issue_events_url":"https://api.github.com/repos/AgileVentures/LocalSupport/issues/events{/number}","events_url":"https://api.github.com/repos/AgileVentures/LocalSupport/events","assignees_url":"https://api.github.com/repos/AgileVentures/LocalSupport/assignees{/user}","branches_url":"https://api.github.com/repos/AgileVentures/LocalSupport/branches{/branch}","tags_url":"https://api.github.com/repos/AgileVentures/LocalSupport/tags","blobs_url":"https://api.github.com/repos/AgileVentures/LocalSupport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AgileVentures/LocalSupport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AgileVentures/LocalSupport/git/refs{/sha}","trees_url":"https://api.github.com/repos/AgileVentures/LocalSupport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AgileVentures/LocalSupport/statuses/{sha}","languages_url":"https://api.github.com/repos/AgileVentures/LocalSupport/languages","stargazers_url":"https://api.github.com/repos/AgileVentures/LocalSupport/stargazers","contributors_url":"https://api.github.com/repos/AgileVentures/LocalSupport/contributors","subscribers_url":"https://api.github.com/repos/AgileVentures/LocalSupport/subscribers","subscription_url":"https://api.github.com/repos/AgileVentures/LocalSupport/subscription","commits_url":"https://api.github.com/repos/AgileVentures/LocalSupport/commits{/sha}","git_commits_url":"https://api.github.com/repos/AgileVentures/LocalSupport/git/commits{/sha}","comments_url":"https://api.github.com/repos/AgileVentures/LocalSupport/comments{/number}","issue_comment_url":"https://api.github.com/repos/AgileVentures/LocalSupport/issues/comments/{number}","contents_url":"https://api.github.com/repos/AgileVentures/LocalSupport/contents/{+path}","compare_url":"https://api.github.com/repos/AgileVentures/LocalSupport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AgileVentures/LocalSupport/merges","archive_url":"https://api.github.com/repos/AgileVentures/LocalSupport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AgileVentures/LocalSupport/downloads","issues_url":"https://api.github.com/repos/AgileVentures/LocalSupport/issues{/number}","pulls_url":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls{/number}","milestones_url":"https://api.github.com/repos/AgileVentures/LocalSupport/milestones{/number}","notifications_url":"https://api.github.com/repos/AgileVentures/LocalSupport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AgileVentures/LocalSupport/labels{/name}","releases_url":"https://api.github.com/repos/AgileVentures/LocalSupport/releases{/id}","created_at":"2013-11-18T17:24:59Z","updated_at":"2014-11-04T17:16:45Z","pushed_at":"2014-11-14T15:18:56Z","git_url":"git://github.com/AgileVentures/LocalSupport.git","ssh_url":"git@github.com:AgileVentures/LocalSupport.git","clone_url":"https://github.com/AgileVentures/LocalSupport.git","svn_url":"https://github.com/AgileVentures/LocalSupport","homepage":"http://www.harrowcn.org.uk","size":11821,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":10,"forks":36,"open_issues":10,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls/115"},"html":{"href":"https://github.com/AgileVentures/LocalSupport/pull/115"},"issue":{"href":"https://api.github.com/repos/AgileVentures/LocalSupport/issues/115"},"comments":{"href":"https://api.github.com/repos/AgileVentures/LocalSupport/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/AgileVentures/LocalSupport/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/AgileVentures/LocalSupport/statuses/1620689a08d7fb93341f565d142eba3603e10293"}}}}