GitHub PullRequestReviewCommentEvent at 2014-03-31 22:17:37
Repository: voxellancer
Actor: xchrdw
Payload: {"comment":{"url":"https://api.github.com/repos/voxelinc/voxellancer/pulls/comments/11139918","id":11139918,"diff_hunk":"@@ -0,0 +1,14 @@\n+#version 330\n+\n+layout (location = 0) out vec4 fragColor;\n+layout (location = 1) out vec4 normalz;\n+layout (location = 2) out vec4 emissiveness;\n+\n+void main() {\n+\tvec4 color = vec4(0.3, 1.0, 0.3, 1.0);\n+\n+    fragColor = color;\n+    normalz = vec4(0.0, 0.0, 1.0, 1.0);","path":"data/shader/utils/aabb.frag","position":11,"original_position":11,"commit_id":"316813dc91af598bfcd7c45a53a04ca6ccdbc27f","original_commit_id":"316813dc91af598bfcd7c45a53a04ca6ccdbc27f","user":{"login":"xchrdw","id":1078427,"avatar_url":"https://avatars.githubusercontent.com/u/1078427?","gravatar_id":"7208cb9fe86a7456ef340054c0411b30","url":"https://api.github.com/users/xchrdw","html_url":"https://github.com/xchrdw","followers_url":"https://api.github.com/users/xchrdw/followers","following_url":"https://api.github.com/users/xchrdw/following{/other_user}","gists_url":"https://api.github.com/users/xchrdw/gists{/gist_id}","starred_url":"https://api.github.com/users/xchrdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xchrdw/subscriptions","organizations_url":"https://api.github.com/users/xchrdw/orgs","repos_url":"https://api.github.com/users/xchrdw/repos","events_url":"https://api.github.com/users/xchrdw/events{/privacy}","received_events_url":"https://api.github.com/users/xchrdw/received_events","type":"User","site_admin":false},"body":"fix indentation for color and use gl_FragCoord.z for the normalz buffer. I think there should either be valid data or it should not be written to it.","created_at":"2014-03-31T22:17:37Z","updated_at":"2014-03-31T22:17:37Z","html_url":"https://github.com/voxelinc/voxellancer/pull/538#discussion_r11139918","pull_request_url":"https://api.github.com/repos/voxelinc/voxellancer/pulls/538","_links":{"self":{"href":"https://api.github.com/repos/voxelinc/voxellancer/pulls/comments/11139918"},"html":{"href":"https://github.com/voxelinc/voxellancer/pull/538#discussion_r11139918"},"pull_request":{"href":"https://api.github.com/repos/voxelinc/voxellancer/pulls/538"}}}}