GitHub PullRequestReviewCommentEvent at 2014-12-12 20:56:23
Repository: experience-sampling
Actor: adrifelt
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls/comments/21772543","id":21772543,"diff_hunk":"@@ -104,6 +104,73 @@ function setupState(details) {\n }\n \n /**\n+ * Previously, we were storing all values locally. Now that they are being\n+ * synced, some users will need to be transitioned from local to sync storage.\n+ * We need to make sure to not lose the CONSENT value in the process.\n+ * @returns {Promise} A promise that resolves when the CONSENT value is migrated\n+ */\n+// TODO: Remove this when migration is no longer needed.\n+function migrateLocalConsent() {\n+  return new Promise(function(resolve, reject) {","path":"extension/background.js","position":47,"original_position":47,"commit_id":"614bd19d989d041e102dcdca8e4f5747e29900f4","original_commit_id":"614bd19d989d041e102dcdca8e4f5747e29900f4","user":{"login":"adrifelt","id":4962198,"avatar_url":"https://avatars.githubusercontent.com/u/4962198?v=3","gravatar_id":"","url":"https://api.github.com/users/adrifelt","html_url":"https://github.com/adrifelt","followers_url":"https://api.github.com/users/adrifelt/followers","following_url":"https://api.github.com/users/adrifelt/following{/other_user}","gists_url":"https://api.github.com/users/adrifelt/gists{/gist_id}","starred_url":"https://api.github.com/users/adrifelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrifelt/subscriptions","organizations_url":"https://api.github.com/users/adrifelt/orgs","repos_url":"https://api.github.com/users/adrifelt/repos","events_url":"https://api.github.com/users/adrifelt/events{/privacy}","received_events_url":"https://api.github.com/users/adrifelt/received_events","type":"User","site_admin":false},"body":"I tried to make this clearer, PTAL.","created_at":"2014-12-12T20:56:23Z","updated_at":"2014-12-12T20:56:23Z","html_url":"https://github.com/GoogleChrome/experience-sampling/pull/150#discussion_r21772543","pull_request_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls/150","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls/comments/21772543"},"html":{"href":"https://github.com/GoogleChrome/experience-sampling/pull/150#discussion_r21772543"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls/150"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls/150","id":25943815,"html_url":"https://github.com/GoogleChrome/experience-sampling/pull/150","diff_url":"https://github.com/GoogleChrome/experience-sampling/pull/150.diff","patch_url":"https://github.com/GoogleChrome/experience-sampling/pull/150.patch","issue_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/issues/150","number":150,"state":"open","locked":false,"title":"Use sync, not local, storage for values","user":{"login":"adrifelt","id":4962198,"avatar_url":"https://avatars.githubusercontent.com/u/4962198?v=3","gravatar_id":"","url":"https://api.github.com/users/adrifelt","html_url":"https://github.com/adrifelt","followers_url":"https://api.github.com/users/adrifelt/followers","following_url":"https://api.github.com/users/adrifelt/following{/other_user}","gists_url":"https://api.github.com/users/adrifelt/gists{/gist_id}","starred_url":"https://api.github.com/users/adrifelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrifelt/subscriptions","organizations_url":"https://api.github.com/users/adrifelt/orgs","repos_url":"https://api.github.com/users/adrifelt/repos","events_url":"https://api.github.com/users/adrifelt/events{/privacy}","received_events_url":"https://api.github.com/users/adrifelt/received_events","type":"User","site_admin":false},"body":"Dogfooders were complaining about two related things:\r\n1) Consent survey popping up on all computers\r\n2) Consent/setup values not propagated between computers\r\n[ See #129 ]\r\n\r\nThis tries to fix that by doing the following things:\r\n* All storage is now sync, not local.\r\n* For existing users who are getting an update, migrate the important values from local to sync storage.\r\n* When consent/setup happens on one device, it will close the consent form/setup survey on other devices.","created_at":"2014-12-12T00:22:54Z","updated_at":"2014-12-12T20:56:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6b53363b0dcf74afa3ba92f6c77b6b11e7a372c","assignee":{"login":"meacer","id":1571579,"avatar_url":"https://avatars.githubusercontent.com/u/1571579?v=3","gravatar_id":"","url":"https://api.github.com/users/meacer","html_url":"https://github.com/meacer","followers_url":"https://api.github.com/users/meacer/followers","following_url":"https://api.github.com/users/meacer/following{/other_user}","gists_url":"https://api.github.com/users/meacer/gists{/gist_id}","starred_url":"https://api.github.com/users/meacer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meacer/subscriptions","organizations_url":"https://api.github.com/users/meacer/orgs","repos_url":"https://api.github.com/users/meacer/repos","events_url":"https://api.github.com/users/meacer/events{/privacy}","received_events_url":"https://api.github.com/users/meacer/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls/150/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls/150/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/issues/150/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/statuses/614bd19d989d041e102dcdca8e4f5747e29900f4","head":{"label":"adrifelt:sync","ref":"sync","sha":"614bd19d989d041e102dcdca8e4f5747e29900f4","user":{"login":"adrifelt","id":4962198,"avatar_url":"https://avatars.githubusercontent.com/u/4962198?v=3","gravatar_id":"","url":"https://api.github.com/users/adrifelt","html_url":"https://github.com/adrifelt","followers_url":"https://api.github.com/users/adrifelt/followers","following_url":"https://api.github.com/users/adrifelt/following{/other_user}","gists_url":"https://api.github.com/users/adrifelt/gists{/gist_id}","starred_url":"https://api.github.com/users/adrifelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrifelt/subscriptions","organizations_url":"https://api.github.com/users/adrifelt/orgs","repos_url":"https://api.github.com/users/adrifelt/repos","events_url":"https://api.github.com/users/adrifelt/events{/privacy}","received_events_url":"https://api.github.com/users/adrifelt/received_events","type":"User","site_admin":false},"repo":{"id":25012428,"name":"experience-sampling","full_name":"adrifelt/experience-sampling","owner":{"login":"adrifelt","id":4962198,"avatar_url":"https://avatars.githubusercontent.com/u/4962198?v=3","gravatar_id":"","url":"https://api.github.com/users/adrifelt","html_url":"https://github.com/adrifelt","followers_url":"https://api.github.com/users/adrifelt/followers","following_url":"https://api.github.com/users/adrifelt/following{/other_user}","gists_url":"https://api.github.com/users/adrifelt/gists{/gist_id}","starred_url":"https://api.github.com/users/adrifelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrifelt/subscriptions","organizations_url":"https://api.github.com/users/adrifelt/orgs","repos_url":"https://api.github.com/users/adrifelt/repos","events_url":"https://api.github.com/users/adrifelt/events{/privacy}","received_events_url":"https://api.github.com/users/adrifelt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrifelt/experience-sampling","description":"","fork":true,"url":"https://api.github.com/repos/adrifelt/experience-sampling","forks_url":"https://api.github.com/repos/adrifelt/experience-sampling/forks","keys_url":"https://api.github.com/repos/adrifelt/experience-sampling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrifelt/experience-sampling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrifelt/experience-sampling/teams","hooks_url":"https://api.github.com/repos/adrifelt/experience-sampling/hooks","issue_events_url":"https://api.github.com/repos/adrifelt/experience-sampling/issues/events{/number}","events_url":"https://api.github.com/repos/adrifelt/experience-sampling/events","assignees_url":"https://api.github.com/repos/adrifelt/experience-sampling/assignees{/user}","branches_url":"https://api.github.com/repos/adrifelt/experience-sampling/branches{/branch}","tags_url":"https://api.github.com/repos/adrifelt/experience-sampling/tags","blobs_url":"https://api.github.com/repos/adrifelt/experience-sampling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrifelt/experience-sampling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrifelt/experience-sampling/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrifelt/experience-sampling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrifelt/experience-sampling/statuses/{sha}","languages_url":"https://api.github.com/repos/adrifelt/experience-sampling/languages","stargazers_url":"https://api.github.com/repos/adrifelt/experience-sampling/stargazers","contributors_url":"https://api.github.com/repos/adrifelt/experience-sampling/contributors","subscribers_url":"https://api.github.com/repos/adrifelt/experience-sampling/subscribers","subscription_url":"https://api.github.com/repos/adrifelt/experience-sampling/subscription","commits_url":"https://api.github.com/repos/adrifelt/experience-sampling/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrifelt/experience-sampling/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrifelt/experience-sampling/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrifelt/experience-sampling/issues/comments/{number}","contents_url":"https://api.github.com/repos/adrifelt/experience-sampling/contents/{+path}","compare_url":"https://api.github.com/repos/adrifelt/experience-sampling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrifelt/experience-sampling/merges","archive_url":"https://api.github.com/repos/adrifelt/experience-sampling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrifelt/experience-sampling/downloads","issues_url":"https://api.github.com/repos/adrifelt/experience-sampling/issues{/number}","pulls_url":"https://api.github.com/repos/adrifelt/experience-sampling/pulls{/number}","milestones_url":"https://api.github.com/repos/adrifelt/experience-sampling/milestones{/number}","notifications_url":"https://api.github.com/repos/adrifelt/experience-sampling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrifelt/experience-sampling/labels{/name}","releases_url":"https://api.github.com/repos/adrifelt/experience-sampling/releases{/id}","created_at":"2014-10-09T23:17:52Z","updated_at":"2014-12-11T07:15:04Z","pushed_at":"2014-12-12T16:52:03Z","git_url":"git://github.com/adrifelt/experience-sampling.git","ssh_url":"git@github.com:adrifelt/experience-sampling.git","clone_url":"https://github.com/adrifelt/experience-sampling.git","svn_url":"https://github.com/adrifelt/experience-sampling","homepage":null,"size":6163,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"06be68721dbb80e74618fe3de42f15879a1e32a8","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":22887014,"name":"experience-sampling","full_name":"GoogleChrome/experience-sampling","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/experience-sampling","description":"","fork":false,"url":"https://api.github.com/repos/GoogleChrome/experience-sampling","forks_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/forks","keys_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/events","assignees_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/merges","archive_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/experience-sampling/releases{/id}","created_at":"2014-08-12T18:02:09Z","updated_at":"2014-12-12T19:10:55Z","pushed_at":"2014-12-12T19:10:55Z","git_url":"git://github.com/GoogleChrome/experience-sampling.git","ssh_url":"git@github.com:GoogleChrome/experience-sampling.git","clone_url":"https://github.com/GoogleChrome/experience-sampling.git","svn_url":"https://github.com/GoogleChrome/experience-sampling","homepage":null,"size":4976,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":26,"forks":3,"open_issues":26,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls/150"},"html":{"href":"https://github.com/GoogleChrome/experience-sampling/pull/150"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/experience-sampling/issues/150"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/experience-sampling/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/experience-sampling/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/experience-sampling/statuses/614bd19d989d041e102dcdca8e4f5747e29900f4"}}}}