GitHub PullRequestReviewCommentEvent at 2014-04-02 14:03:31
Repository: cryptography
Actor: reaperhulk
Payload: {"comment":{"url":"https://api.github.com/repos/pyca/cryptography/pulls/comments/11206168","id":11206168,"diff_hunk":"@@ -409,6 +409,46 @@ def create_rsa_verification_ctx(self, public_key, signature, padding,\n         return _RSAVerificationContext(self, public_key, signature, padding,\n                                        algorithm)\n \n+    def generate_dsa_parameters(self, key_size):","path":"cryptography/hazmat/backends/openssl/backend.py","position":13,"original_position":13,"commit_id":"4b62e42f012ff6e956037c58d2788f496576f4d4","original_commit_id":"1d4014dba9366f87f1bd8fae16977a4ad548111e","user":{"login":"reaperhulk","id":161495,"avatar_url":"https://avatars.githubusercontent.com/u/161495?","gravatar_id":"81f310942fe5989105a6b474cda4c843","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"body":"This needs to handle OpenSSL < 1.0.0 properly. At the moment it appears you can pass >1024 bit key sizes to this and it will accept it, but then fail mysteriously (in my test I got back a ValueError from _check_dsa_parameters).","created_at":"2014-04-02T14:03:31Z","updated_at":"2014-04-02T14:03:31Z","html_url":"https://github.com/pyca/cryptography/pull/739#discussion_r11206168","pull_request_url":"https://api.github.com/repos/pyca/cryptography/pulls/739","_links":{"self":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/comments/11206168"},"html":{"href":"https://github.com/pyca/cryptography/pull/739#discussion_r11206168"},"pull_request":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/739"}}}}