GitHub PullRequestReviewCommentEvent at 2014-05-23 00:50:33
Repository: strong-remoting
Actor: ritch
Payload: {"comment":{"url":"https://api.github.com/repos/strongloop/strong-remoting/pulls/comments/12982283","id":12982283,"diff_hunk":"@@ -271,7 +270,7 @@ RestAdapter.prototype._createPrototypeMethodHandler = function(sharedMethod) {\n     var ctx = new Context(req, res, sharedMethod);\n \n     // invoke the shared constructor to get an instance\n-    ctx.invoke(sharedMethod, sharedMethod.sharedCtor, function(err, inst) {\n+    ctx.invoke(sharedMethod.ctor, sharedMethod.sharedCtor, function(err, inst) {","path":"lib/rest-adapter.js","position":35,"original_position":35,"commit_id":"f724efb8f77abc83323d550617fb51f905a56e0c","original_commit_id":"f724efb8f77abc83323d550617fb51f905a56e0c","user":{"login":"ritch","id":462228,"avatar_url":"https://avatars.githubusercontent.com/u/462228?","gravatar_id":"9c9b14104d3df09372c22605441a40da","url":"https://api.github.com/users/ritch","html_url":"https://github.com/ritch","followers_url":"https://api.github.com/users/ritch/followers","following_url":"https://api.github.com/users/ritch/following{/other_user}","gists_url":"https://api.github.com/users/ritch/gists{/gist_id}","starred_url":"https://api.github.com/users/ritch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritch/subscriptions","organizations_url":"https://api.github.com/users/ritch/orgs","repos_url":"https://api.github.com/users/ritch/repos","events_url":"https://api.github.com/users/ritch/events{/privacy}","received_events_url":"https://api.github.com/users/ritch/received_events","type":"User","site_admin":false},"body":"This was a bug fix. `sharedMethod` is never the scope to `invoke()` the method on. In the case of the static method `sharedCtor` it is the `ctor` that it is defined on. ","created_at":"2014-05-23T00:50:33Z","updated_at":"2014-05-23T00:50:33Z","html_url":"https://github.com/strongloop/strong-remoting/pull/62#discussion_r12982283","pull_request_url":"https://api.github.com/repos/strongloop/strong-remoting/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/strongloop/strong-remoting/pulls/comments/12982283"},"html":{"href":"https://github.com/strongloop/strong-remoting/pull/62#discussion_r12982283"},"pull_request":{"href":"https://api.github.com/repos/strongloop/strong-remoting/pulls/62"}}}}