GitHub PullRequestReviewCommentEvent at 2014-06-12 09:52:00
Repository: elasticsearch
Actor: s1monw
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/13694206","id":13694206,"diff_hunk":"@@ -139,6 +141,13 @@ public FacetExecutor parse(String facetName, XContentParser parser, SearchContex\n                     factor = parser.floatValue();\n                 } else if (\"value_script\".equals(fieldName) || \"valueScript\".equals(fieldName)) {\n                     valueScript = parser.text();\n+                    valueScriptType = ScriptService.ScriptType.INLINE;\n+                } else if (\"value_script_id\".equals(fieldName) || \"valueScriptId\".equals(fieldName)) {","path":"src/main/java/org/elasticsearch/search/facet/datehistogram/DateHistogramFacetParser.java","position":21,"original_position":21,"commit_id":"a787c81d8505e7510e7d74e76e14fc3df8e11847","original_commit_id":"a787c81d8505e7510e7d74e76e14fc3df8e11847","user":{"login":"s1monw","id":973334,"avatar_url":"https://avatars.githubusercontent.com/u/973334?","gravatar_id":"8c12b7030c2431ff54d71891a722ff9a","url":"https://api.github.com/users/s1monw","html_url":"https://github.com/s1monw","followers_url":"https://api.github.com/users/s1monw/followers","following_url":"https://api.github.com/users/s1monw/following{/other_user}","gists_url":"https://api.github.com/users/s1monw/gists{/gist_id}","starred_url":"https://api.github.com/users/s1monw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1monw/subscriptions","organizations_url":"https://api.github.com/users/s1monw/orgs","repos_url":"https://api.github.com/users/s1monw/repos","events_url":"https://api.github.com/users/s1monw/events{/privacy}","received_events_url":"https://api.github.com/users/s1monw/received_events","type":"User","site_admin":false},"body":"please take a look at the `ParseField` class  IMO we should add a \r\n\r\n```Java\r\npublic static final ParseField VALUE_SCRIPT_FILE = new ParseField(\"value_script_file\");\r\npublic static final ParseField VALUE_SCRIPT_ID = new ParseField(\"value_script_id\");\r\n```\r\nto ScriptService and use them in all places?","created_at":"2014-06-12T09:52:00Z","updated_at":"2014-06-12T09:52:00Z","html_url":"https://github.com/elasticsearch/elasticsearch/pull/5921#discussion_r13694206","pull_request_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5921","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/13694206"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/5921#discussion_r13694206"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5921"}}},"pull_request":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5921","id":15068875,"html_url":"https://github.com/elasticsearch/elasticsearch/pull/5921","diff_url":"https://github.com/elasticsearch/elasticsearch/pull/5921.diff","patch_url":"https://github.com/elasticsearch/elasticsearch/pull/5921.patch","issue_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/5921","number":5921,"state":"open","title":"Allow search templates stored in an index to be retrieved and used at se...","user":{"login":"GaelTadh","id":5190064,"avatar_url":"https://avatars.githubusercontent.com/u/5190064?","gravatar_id":"14054642cc92ff924d902c6bc3647d38","url":"https://api.github.com/users/GaelTadh","html_url":"https://github.com/GaelTadh","followers_url":"https://api.github.com/users/GaelTadh/followers","following_url":"https://api.github.com/users/GaelTadh/following{/other_user}","gists_url":"https://api.github.com/users/GaelTadh/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelTadh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelTadh/subscriptions","organizations_url":"https://api.github.com/users/GaelTadh/orgs","repos_url":"https://api.github.com/users/GaelTadh/repos","events_url":"https://api.github.com/users/GaelTadh/events{/privacy}","received_events_url":"https://api.github.com/users/GaelTadh/received_events","type":"User","site_admin":false},"body":"Allow running search templates stored in an index at search time\r\n\r\nThis change allows search templates stored in an index to be used at search time.\r\nYou can run an indexed template by\r\n```\r\nGET /_search/template\r\n{\r\n    'templatename' : '/index/language/id',\r\n    'params' : {\r\n        'param1' : 'foo'\r\n    }\r\n}\r\n```\r\nRunning the template will fail if the template cannot be found, if the templatename\r\nstarts with a '/' but does not conform to the /index/type/id triple\r\nIf the named template cannot be found an error will be raised. Currently the\r\ntemplates are NOT cached. We also use TransportGetAction directly instead of using\r\nClient to avoid a circular dependency between Client and ScriptService\r\n\r\nSee #5637","created_at":"2014-04-23T14:34:06Z","updated_at":"2014-06-12T09:52:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4894745af506446e7d3283411a97a709067faf93","assignee":{"login":"GaelTadh","id":5190064,"avatar_url":"https://avatars.githubusercontent.com/u/5190064?","gravatar_id":"14054642cc92ff924d902c6bc3647d38","url":"https://api.github.com/users/GaelTadh","html_url":"https://github.com/GaelTadh","followers_url":"https://api.github.com/users/GaelTadh/followers","following_url":"https://api.github.com/users/GaelTadh/following{/other_user}","gists_url":"https://api.github.com/users/GaelTadh/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelTadh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelTadh/subscriptions","organizations_url":"https://api.github.com/users/GaelTadh/orgs","repos_url":"https://api.github.com/users/GaelTadh/repos","events_url":"https://api.github.com/users/GaelTadh/events{/privacy}","received_events_url":"https://api.github.com/users/GaelTadh/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5921/commits","review_comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5921/comments","review_comment_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/5921/comments","statuses_url":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/a787c81d8505e7510e7d74e76e14fc3df8e11847","head":{"label":"GaelTadh:feature/indexsearchtemplates","ref":"feature/indexsearchtemplates","sha":"a787c81d8505e7510e7d74e76e14fc3df8e11847","user":{"login":"GaelTadh","id":5190064,"avatar_url":"https://avatars.githubusercontent.com/u/5190064?","gravatar_id":"14054642cc92ff924d902c6bc3647d38","url":"https://api.github.com/users/GaelTadh","html_url":"https://github.com/GaelTadh","followers_url":"https://api.github.com/users/GaelTadh/followers","following_url":"https://api.github.com/users/GaelTadh/following{/other_user}","gists_url":"https://api.github.com/users/GaelTadh/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelTadh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelTadh/subscriptions","organizations_url":"https://api.github.com/users/GaelTadh/orgs","repos_url":"https://api.github.com/users/GaelTadh/repos","events_url":"https://api.github.com/users/GaelTadh/events{/privacy}","received_events_url":"https://api.github.com/users/GaelTadh/received_events","type":"User","site_admin":false},"repo":{"id":19072863,"name":"elasticsearch","full_name":"GaelTadh/elasticsearch","owner":{"login":"GaelTadh","id":5190064,"avatar_url":"https://avatars.githubusercontent.com/u/5190064?","gravatar_id":"14054642cc92ff924d902c6bc3647d38","url":"https://api.github.com/users/GaelTadh","html_url":"https://github.com/GaelTadh","followers_url":"https://api.github.com/users/GaelTadh/followers","following_url":"https://api.github.com/users/GaelTadh/following{/other_user}","gists_url":"https://api.github.com/users/GaelTadh/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelTadh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelTadh/subscriptions","organizations_url":"https://api.github.com/users/GaelTadh/orgs","repos_url":"https://api.github.com/users/GaelTadh/repos","events_url":"https://api.github.com/users/GaelTadh/events{/privacy}","received_events_url":"https://api.github.com/users/GaelTadh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GaelTadh/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/GaelTadh/elasticsearch","forks_url":"https://api.github.com/repos/GaelTadh/elasticsearch/forks","keys_url":"https://api.github.com/repos/GaelTadh/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GaelTadh/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GaelTadh/elasticsearch/teams","hooks_url":"https://api.github.com/repos/GaelTadh/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/GaelTadh/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/GaelTadh/elasticsearch/events","assignees_url":"https://api.github.com/repos/GaelTadh/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/GaelTadh/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/GaelTadh/elasticsearch/tags","blobs_url":"https://api.github.com/repos/GaelTadh/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GaelTadh/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GaelTadh/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/GaelTadh/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GaelTadh/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/GaelTadh/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/GaelTadh/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/GaelTadh/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/GaelTadh/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/GaelTadh/elasticsearch/subscription","commits_url":"https://api.github.com/repos/GaelTadh/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/GaelTadh/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/GaelTadh/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/GaelTadh/elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/GaelTadh/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/GaelTadh/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GaelTadh/elasticsearch/merges","archive_url":"https://api.github.com/repos/GaelTadh/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GaelTadh/elasticsearch/downloads","issues_url":"https://api.github.com/repos/GaelTadh/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/GaelTadh/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/GaelTadh/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/GaelTadh/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GaelTadh/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/GaelTadh/elasticsearch/releases{/id}","created_at":"2014-04-23T14:32:55Z","updated_at":"2014-06-12T09:26:37Z","pushed_at":"2014-06-12T09:26:37Z","git_url":"git://github.com/GaelTadh/elasticsearch.git","ssh_url":"git@github.com:GaelTadh/elasticsearch.git","clone_url":"https://github.com/GaelTadh/elasticsearch.git","svn_url":"https://github.com/GaelTadh/elasticsearch","homepage":"http://elasticsearch.org","size":55709,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elasticsearch:master","ref":"master","sha":"56a264cf6d808eb850ecf05ebbebec8cbd60ca7a","user":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?","gravatar_id":"1aecf795625bbc7251068cfbc39800ab","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elasticsearch/elasticsearch","owner":{"login":"elasticsearch","id":141304,"avatar_url":"https://avatars.githubusercontent.com/u/141304?","gravatar_id":"1aecf795625bbc7251068cfbc39800ab","url":"https://api.github.com/users/elasticsearch","html_url":"https://github.com/elasticsearch","followers_url":"https://api.github.com/users/elasticsearch/followers","following_url":"https://api.github.com/users/elasticsearch/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch/orgs","repos_url":"https://api.github.com/users/elasticsearch/repos","events_url":"https://api.github.com/users/elasticsearch/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elasticsearch/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elasticsearch/elasticsearch","forks_url":"https://api.github.com/repos/elasticsearch/elasticsearch/forks","keys_url":"https://api.github.com/repos/elasticsearch/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elasticsearch/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elasticsearch/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elasticsearch/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/events","assignees_url":"https://api.github.com/repos/elasticsearch/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elasticsearch/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elasticsearch/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elasticsearch/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elasticsearch/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elasticsearch/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elasticsearch/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elasticsearch/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elasticsearch/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/comments/{number}","contents_url":"https://api.github.com/repos/elasticsearch/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elasticsearch/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elasticsearch/elasticsearch/merges","archive_url":"https://api.github.com/repos/elasticsearch/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elasticsearch/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elasticsearch/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elasticsearch/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elasticsearch/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elasticsearch/elasticsearch/releases{/id}","created_at":"2010-02-08T13:20:56Z","updated_at":"2014-06-12T09:31:20Z","pushed_at":"2014-06-12T09:31:20Z","git_url":"git://github.com/elasticsearch/elasticsearch.git","ssh_url":"git@github.com:elasticsearch/elasticsearch.git","clone_url":"https://github.com/elasticsearch/elasticsearch.git","svn_url":"https://github.com/elasticsearch/elasticsearch","homepage":"http://elasticsearch.org","size":196989,"stargazers_count":7272,"watchers_count":7272,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":2035,"mirror_url":null,"open_issues_count":1042,"forks":2035,"open_issues":1042,"watchers":7272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5921"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/5921"},"issue":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/5921"},"comments":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/5921/comments"},"review_comments":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5921/comments"},"review_comment":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/5921/commits"},"statuses":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/statuses/a787c81d8505e7510e7d74e76e14fc3df8e11847"}}}}