GitHub PullRequestReviewCommentEvent at 2014-09-18 14:43:54
Repository: tizen-extensions-crosswalk
Actor: halton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/17730828","id":17730828,"diff_hunk":"@@ -0,0 +1,318 @@\n+// Copyright (c) 2014 Samsung Electronics Co., Ltd All Rights Reserved\n+// Use of this source code is governed by a BSD-style license that can be\n+// found in the LICENSE file.\n+\n+#include \"datasync/datasync_instance.h\"\n+\n+#include <exception>","path":"datasync/datasync_instance.cc","position":7,"original_position":7,"commit_id":"7d9c061dac1e90addf657eded164edaaff116810","original_commit_id":"7d9c061dac1e90addf657eded164edaaff116810","user":{"login":"halton","id":433218,"avatar_url":"https://avatars.githubusercontent.com/u/433218?v=2","gravatar_id":"12aa489648dd89d591d6514602d705be","url":"https://api.github.com/users/halton","html_url":"https://github.com/halton","followers_url":"https://api.github.com/users/halton/followers","following_url":"https://api.github.com/users/halton/following{/other_user}","gists_url":"https://api.github.com/users/halton/gists{/gist_id}","starred_url":"https://api.github.com/users/halton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halton/subscriptions","organizations_url":"https://api.github.com/users/halton/orgs","repos_url":"https://api.github.com/users/halton/repos","events_url":"https://api.github.com/users/halton/events{/privacy}","received_events_url":"https://api.github.com/users/halton/received_events","type":"User","site_admin":false},"body":"Again, you're using C++ exception.","created_at":"2014-09-18T14:43:54Z","updated_at":"2014-09-18T14:43:54Z","html_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/375#discussion_r17730828","pull_request_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/375","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/17730828"},"html":{"href":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/375#discussion_r17730828"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/375"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/375","id":21418235,"html_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/375","diff_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/375.diff","patch_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/375.patch","issue_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/375","number":375,"state":"open","locked":false,"title":"DataSync tizen plugin implementation","user":{"login":"tiwanek","id":5700502,"avatar_url":"https://avatars.githubusercontent.com/u/5700502?v=2","gravatar_id":"312dd0d8273e5dcfcbc5b229fd3009e6","url":"https://api.github.com/users/tiwanek","html_url":"https://github.com/tiwanek","followers_url":"https://api.github.com/users/tiwanek/followers","following_url":"https://api.github.com/users/tiwanek/following{/other_user}","gists_url":"https://api.github.com/users/tiwanek/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanek/subscriptions","organizations_url":"https://api.github.com/users/tiwanek/orgs","repos_url":"https://api.github.com/users/tiwanek/repos","events_url":"https://api.github.com/users/tiwanek/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanek/received_events","type":"User","site_admin":false},"body":"SPEC=https://developer.tizen.org/dev-guide/2.2.1/org.tizen.web.device.apireference/tizen/datasync.html\r\n\r\nBUG=XWALK-1061\r\n\r\n----------------------------------------------------\r\n\r\nRunning TCT:\r\n - install rpms on device:\r\n     - libwbxml2,\r\n     - sync-agent,\r\n     - oma-ds-agent (and start: systemctl start oma-ds-agent.service),\r\n - copy 'tct-datasync-tizen-tests.wgt' to device,\r\n - install and run application,\r\n\r\nCurrent TCT datasync passrate: 63/63\r\n\r\n--------------------------------------------------","created_at":"2014-09-18T08:22:55Z","updated_at":"2014-09-18T14:43:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49954a3f34b35fd673da49ed1a1b674b49cba4e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/375/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/375/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/375/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/statuses/7d9c061dac1e90addf657eded164edaaff116810","head":{"label":"tiwanek:XWALK-1061","ref":"XWALK-1061","sha":"7d9c061dac1e90addf657eded164edaaff116810","user":{"login":"tiwanek","id":5700502,"avatar_url":"https://avatars.githubusercontent.com/u/5700502?v=2","gravatar_id":"312dd0d8273e5dcfcbc5b229fd3009e6","url":"https://api.github.com/users/tiwanek","html_url":"https://github.com/tiwanek","followers_url":"https://api.github.com/users/tiwanek/followers","following_url":"https://api.github.com/users/tiwanek/following{/other_user}","gists_url":"https://api.github.com/users/tiwanek/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanek/subscriptions","organizations_url":"https://api.github.com/users/tiwanek/orgs","repos_url":"https://api.github.com/users/tiwanek/repos","events_url":"https://api.github.com/users/tiwanek/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanek/received_events","type":"User","site_admin":false},"repo":{"id":24179990,"name":"tizen-extensions-crosswalk","full_name":"tiwanek/tizen-extensions-crosswalk","owner":{"login":"tiwanek","id":5700502,"avatar_url":"https://avatars.githubusercontent.com/u/5700502?v=2","gravatar_id":"312dd0d8273e5dcfcbc5b229fd3009e6","url":"https://api.github.com/users/tiwanek","html_url":"https://github.com/tiwanek","followers_url":"https://api.github.com/users/tiwanek/followers","following_url":"https://api.github.com/users/tiwanek/following{/other_user}","gists_url":"https://api.github.com/users/tiwanek/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwanek/subscriptions","organizations_url":"https://api.github.com/users/tiwanek/orgs","repos_url":"https://api.github.com/users/tiwanek/repos","events_url":"https://api.github.com/users/tiwanek/events{/privacy}","received_events_url":"https://api.github.com/users/tiwanek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiwanek/tizen-extensions-crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk","forks_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/forks","keys_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/teams","hooks_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/hooks","issue_events_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/events","assignees_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/tags","blobs_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/languages","stargazers_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/stargazers","contributors_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/contributors","subscribers_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/subscribers","subscription_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/subscription","commits_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/merges","archive_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/downloads","issues_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/tiwanek/tizen-extensions-crosswalk/releases{/id}","created_at":"2014-09-18T08:21:31Z","updated_at":"2014-09-05T05:54:24Z","pushed_at":"2014-09-18T10:26:38Z","git_url":"git://github.com/tiwanek/tizen-extensions-crosswalk.git","ssh_url":"git@github.com:tiwanek/tizen-extensions-crosswalk.git","clone_url":"https://github.com/tiwanek/tizen-extensions-crosswalk.git","svn_url":"https://github.com/tiwanek/tizen-extensions-crosswalk","homepage":null,"size":9387,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"32c094912160e4f396b5471e470d494137eabcb4","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=2","gravatar_id":"92669bf554412548daa0c4b8d74b861e","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":11259856,"name":"tizen-extensions-crosswalk","full_name":"crosswalk-project/tizen-extensions-crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=2","gravatar_id":"92669bf554412548daa0c4b8d74b861e","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/releases{/id}","created_at":"2013-07-08T16:54:26Z","updated_at":"2014-09-05T05:54:24Z","pushed_at":"2014-09-16T22:06:02Z","git_url":"git://github.com/crosswalk-project/tizen-extensions-crosswalk.git","ssh_url":"git@github.com:crosswalk-project/tizen-extensions-crosswalk.git","clone_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk.git","svn_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk","homepage":null,"size":9387,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":6,"forks":49,"open_issues":6,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/375"},"html":{"href":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/375"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/375"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/statuses/7d9c061dac1e90addf657eded164edaaff116810"}}}}