GitHub PullRequestReviewCommentEvent at 2014-10-17 08:12:42
Repository: reload-pro
Actor: Arachnid
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls/comments/19006206","id":19006206,"diff_hunk":"@@ -125,8 +125,17 @@ const menudata main_menu = {\n \r\n #define STATE_MAIN_MENU {menu, &main_menu, 0}\r\n \r\n+ui_event event = {.type = UI_EVENT_BUTTONPRESS, .when = 0, .int_arg = 1};\r\n+\r\n+void check_long_press() {\r\n+    static ui_event long_press_event = {.type = UI_EVENT_LONG_BUTTONPRESS, .when = 0};\r","path":"firmware/Reload Pro.cydsn/ui.c","position":7,"original_position":7,"commit_id":"f3ad38c7a295c833ae6e7f480ab8ab363a72bd42","original_commit_id":"f3ad38c7a295c833ae6e7f480ab8ab363a72bd42","user":{"login":"Arachnid","id":17865,"avatar_url":"https://avatars.githubusercontent.com/u/17865?v=2","gravatar_id":"","url":"https://api.github.com/users/Arachnid","html_url":"https://github.com/Arachnid","followers_url":"https://api.github.com/users/Arachnid/followers","following_url":"https://api.github.com/users/Arachnid/following{/other_user}","gists_url":"https://api.github.com/users/Arachnid/gists{/gist_id}","starred_url":"https://api.github.com/users/Arachnid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arachnid/subscriptions","organizations_url":"https://api.github.com/users/Arachnid/orgs","repos_url":"https://api.github.com/users/Arachnid/repos","events_url":"https://api.github.com/users/Arachnid/events{/privacy}","received_events_url":"https://api.github.com/users/Arachnid/received_events","type":"User","site_admin":false},"body":"This doesn't need to be static. It should either be a const defined at block level, or just a regular local. I'm inclined to go with the latter, so .when could be set correctly for the event.","created_at":"2014-10-17T08:12:42Z","updated_at":"2014-10-17T08:12:42Z","html_url":"https://github.com/arachnidlabs/reload-pro/pull/56#discussion_r19006206","pull_request_url":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls/comments/19006206"},"html":{"href":"https://github.com/arachnidlabs/reload-pro/pull/56#discussion_r19006206"},"pull_request":{"href":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls/56","id":22795267,"html_url":"https://github.com/arachnidlabs/reload-pro/pull/56","diff_url":"https://github.com/arachnidlabs/reload-pro/pull/56.diff","patch_url":"https://github.com/arachnidlabs/reload-pro/pull/56.patch","issue_url":"https://api.github.com/repos/arachnidlabs/reload-pro/issues/56","number":56,"state":"open","locked":false,"title":"Toggle load by a short button press, enter menu with a long button press when in CC mode","user":{"login":"zardam","id":1298609,"avatar_url":"https://avatars.githubusercontent.com/u/1298609?v=2","gravatar_id":"","url":"https://api.github.com/users/zardam","html_url":"https://github.com/zardam","followers_url":"https://api.github.com/users/zardam/followers","following_url":"https://api.github.com/users/zardam/following{/other_user}","gists_url":"https://api.github.com/users/zardam/gists{/gist_id}","starred_url":"https://api.github.com/users/zardam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zardam/subscriptions","organizations_url":"https://api.github.com/users/zardam/orgs","repos_url":"https://api.github.com/users/zardam/repos","events_url":"https://api.github.com/users/zardam/events{/privacy}","received_events_url":"https://api.github.com/users/zardam/received_events","type":"User","site_admin":false},"body":"Possible solution for issue #30","created_at":"2014-10-15T16:14:21Z","updated_at":"2014-10-17T08:12:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e17560df9723bd167028c3db2cb09e9562a7e0b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls/56/commits","review_comments_url":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls/56/comments","review_comment_url":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls/comments/{number}","comments_url":"https://api.github.com/repos/arachnidlabs/reload-pro/issues/56/comments","statuses_url":"https://api.github.com/repos/arachnidlabs/reload-pro/statuses/f3ad38c7a295c833ae6e7f480ab8ab363a72bd42","head":{"label":"zardam:loadtoggle","ref":"loadtoggle","sha":"f3ad38c7a295c833ae6e7f480ab8ab363a72bd42","user":{"login":"zardam","id":1298609,"avatar_url":"https://avatars.githubusercontent.com/u/1298609?v=2","gravatar_id":"","url":"https://api.github.com/users/zardam","html_url":"https://github.com/zardam","followers_url":"https://api.github.com/users/zardam/followers","following_url":"https://api.github.com/users/zardam/following{/other_user}","gists_url":"https://api.github.com/users/zardam/gists{/gist_id}","starred_url":"https://api.github.com/users/zardam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zardam/subscriptions","organizations_url":"https://api.github.com/users/zardam/orgs","repos_url":"https://api.github.com/users/zardam/repos","events_url":"https://api.github.com/users/zardam/events{/privacy}","received_events_url":"https://api.github.com/users/zardam/received_events","type":"User","site_admin":false},"repo":{"id":25048040,"name":"reload-pro","full_name":"zardam/reload-pro","owner":{"login":"zardam","id":1298609,"avatar_url":"https://avatars.githubusercontent.com/u/1298609?v=2","gravatar_id":"","url":"https://api.github.com/users/zardam","html_url":"https://github.com/zardam","followers_url":"https://api.github.com/users/zardam/followers","following_url":"https://api.github.com/users/zardam/following{/other_user}","gists_url":"https://api.github.com/users/zardam/gists{/gist_id}","starred_url":"https://api.github.com/users/zardam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zardam/subscriptions","organizations_url":"https://api.github.com/users/zardam/orgs","repos_url":"https://api.github.com/users/zardam/repos","events_url":"https://api.github.com/users/zardam/events{/privacy}","received_events_url":"https://api.github.com/users/zardam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zardam/reload-pro","description":"Schematics and code for the Re:load Pro","fork":true,"url":"https://api.github.com/repos/zardam/reload-pro","forks_url":"https://api.github.com/repos/zardam/reload-pro/forks","keys_url":"https://api.github.com/repos/zardam/reload-pro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zardam/reload-pro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zardam/reload-pro/teams","hooks_url":"https://api.github.com/repos/zardam/reload-pro/hooks","issue_events_url":"https://api.github.com/repos/zardam/reload-pro/issues/events{/number}","events_url":"https://api.github.com/repos/zardam/reload-pro/events","assignees_url":"https://api.github.com/repos/zardam/reload-pro/assignees{/user}","branches_url":"https://api.github.com/repos/zardam/reload-pro/branches{/branch}","tags_url":"https://api.github.com/repos/zardam/reload-pro/tags","blobs_url":"https://api.github.com/repos/zardam/reload-pro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zardam/reload-pro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zardam/reload-pro/git/refs{/sha}","trees_url":"https://api.github.com/repos/zardam/reload-pro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zardam/reload-pro/statuses/{sha}","languages_url":"https://api.github.com/repos/zardam/reload-pro/languages","stargazers_url":"https://api.github.com/repos/zardam/reload-pro/stargazers","contributors_url":"https://api.github.com/repos/zardam/reload-pro/contributors","subscribers_url":"https://api.github.com/repos/zardam/reload-pro/subscribers","subscription_url":"https://api.github.com/repos/zardam/reload-pro/subscription","commits_url":"https://api.github.com/repos/zardam/reload-pro/commits{/sha}","git_commits_url":"https://api.github.com/repos/zardam/reload-pro/git/commits{/sha}","comments_url":"https://api.github.com/repos/zardam/reload-pro/comments{/number}","issue_comment_url":"https://api.github.com/repos/zardam/reload-pro/issues/comments/{number}","contents_url":"https://api.github.com/repos/zardam/reload-pro/contents/{+path}","compare_url":"https://api.github.com/repos/zardam/reload-pro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zardam/reload-pro/merges","archive_url":"https://api.github.com/repos/zardam/reload-pro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zardam/reload-pro/downloads","issues_url":"https://api.github.com/repos/zardam/reload-pro/issues{/number}","pulls_url":"https://api.github.com/repos/zardam/reload-pro/pulls{/number}","milestones_url":"https://api.github.com/repos/zardam/reload-pro/milestones{/number}","notifications_url":"https://api.github.com/repos/zardam/reload-pro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zardam/reload-pro/labels{/name}","releases_url":"https://api.github.com/repos/zardam/reload-pro/releases{/id}","created_at":"2014-10-10T18:31:30Z","updated_at":"2014-10-16T22:17:49Z","pushed_at":"2014-10-16T22:32:04Z","git_url":"git://github.com/zardam/reload-pro.git","ssh_url":"git@github.com:zardam/reload-pro.git","clone_url":"https://github.com/zardam/reload-pro.git","svn_url":"https://github.com/zardam/reload-pro","homepage":"http://www.arachnidlabs.com/reload-pro/","size":10364,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arachnidlabs:master","ref":"master","sha":"c0c55da92072ccefa3fac8c5e11452a79953e76d","user":{"login":"arachnidlabs","id":3321726,"avatar_url":"https://avatars.githubusercontent.com/u/3321726?v=2","gravatar_id":"","url":"https://api.github.com/users/arachnidlabs","html_url":"https://github.com/arachnidlabs","followers_url":"https://api.github.com/users/arachnidlabs/followers","following_url":"https://api.github.com/users/arachnidlabs/following{/other_user}","gists_url":"https://api.github.com/users/arachnidlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/arachnidlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arachnidlabs/subscriptions","organizations_url":"https://api.github.com/users/arachnidlabs/orgs","repos_url":"https://api.github.com/users/arachnidlabs/repos","events_url":"https://api.github.com/users/arachnidlabs/events{/privacy}","received_events_url":"https://api.github.com/users/arachnidlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":15425905,"name":"reload-pro","full_name":"arachnidlabs/reload-pro","owner":{"login":"arachnidlabs","id":3321726,"avatar_url":"https://avatars.githubusercontent.com/u/3321726?v=2","gravatar_id":"","url":"https://api.github.com/users/arachnidlabs","html_url":"https://github.com/arachnidlabs","followers_url":"https://api.github.com/users/arachnidlabs/followers","following_url":"https://api.github.com/users/arachnidlabs/following{/other_user}","gists_url":"https://api.github.com/users/arachnidlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/arachnidlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arachnidlabs/subscriptions","organizations_url":"https://api.github.com/users/arachnidlabs/orgs","repos_url":"https://api.github.com/users/arachnidlabs/repos","events_url":"https://api.github.com/users/arachnidlabs/events{/privacy}","received_events_url":"https://api.github.com/users/arachnidlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arachnidlabs/reload-pro","description":"Schematics and code for the Re:load Pro","fork":false,"url":"https://api.github.com/repos/arachnidlabs/reload-pro","forks_url":"https://api.github.com/repos/arachnidlabs/reload-pro/forks","keys_url":"https://api.github.com/repos/arachnidlabs/reload-pro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arachnidlabs/reload-pro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arachnidlabs/reload-pro/teams","hooks_url":"https://api.github.com/repos/arachnidlabs/reload-pro/hooks","issue_events_url":"https://api.github.com/repos/arachnidlabs/reload-pro/issues/events{/number}","events_url":"https://api.github.com/repos/arachnidlabs/reload-pro/events","assignees_url":"https://api.github.com/repos/arachnidlabs/reload-pro/assignees{/user}","branches_url":"https://api.github.com/repos/arachnidlabs/reload-pro/branches{/branch}","tags_url":"https://api.github.com/repos/arachnidlabs/reload-pro/tags","blobs_url":"https://api.github.com/repos/arachnidlabs/reload-pro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arachnidlabs/reload-pro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arachnidlabs/reload-pro/git/refs{/sha}","trees_url":"https://api.github.com/repos/arachnidlabs/reload-pro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arachnidlabs/reload-pro/statuses/{sha}","languages_url":"https://api.github.com/repos/arachnidlabs/reload-pro/languages","stargazers_url":"https://api.github.com/repos/arachnidlabs/reload-pro/stargazers","contributors_url":"https://api.github.com/repos/arachnidlabs/reload-pro/contributors","subscribers_url":"https://api.github.com/repos/arachnidlabs/reload-pro/subscribers","subscription_url":"https://api.github.com/repos/arachnidlabs/reload-pro/subscription","commits_url":"https://api.github.com/repos/arachnidlabs/reload-pro/commits{/sha}","git_commits_url":"https://api.github.com/repos/arachnidlabs/reload-pro/git/commits{/sha}","comments_url":"https://api.github.com/repos/arachnidlabs/reload-pro/comments{/number}","issue_comment_url":"https://api.github.com/repos/arachnidlabs/reload-pro/issues/comments/{number}","contents_url":"https://api.github.com/repos/arachnidlabs/reload-pro/contents/{+path}","compare_url":"https://api.github.com/repos/arachnidlabs/reload-pro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arachnidlabs/reload-pro/merges","archive_url":"https://api.github.com/repos/arachnidlabs/reload-pro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arachnidlabs/reload-pro/downloads","issues_url":"https://api.github.com/repos/arachnidlabs/reload-pro/issues{/number}","pulls_url":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls{/number}","milestones_url":"https://api.github.com/repos/arachnidlabs/reload-pro/milestones{/number}","notifications_url":"https://api.github.com/repos/arachnidlabs/reload-pro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arachnidlabs/reload-pro/labels{/name}","releases_url":"https://api.github.com/repos/arachnidlabs/reload-pro/releases{/id}","created_at":"2013-12-24T22:08:51Z","updated_at":"2014-10-14T11:19:49Z","pushed_at":"2014-10-14T06:15:01Z","git_url":"git://github.com/arachnidlabs/reload-pro.git","ssh_url":"git@github.com:arachnidlabs/reload-pro.git","clone_url":"https://github.com/arachnidlabs/reload-pro.git","svn_url":"https://github.com/arachnidlabs/reload-pro","homepage":"http://www.arachnidlabs.com/reload-pro/","size":11111,"stargazers_count":31,"watchers_count":31,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":17,"forks":11,"open_issues":17,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls/56"},"html":{"href":"https://github.com/arachnidlabs/reload-pro/pull/56"},"issue":{"href":"https://api.github.com/repos/arachnidlabs/reload-pro/issues/56"},"comments":{"href":"https://api.github.com/repos/arachnidlabs/reload-pro/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/arachnidlabs/reload-pro/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/arachnidlabs/reload-pro/statuses/f3ad38c7a295c833ae6e7f480ab8ab363a72bd42"}}}}