GitHub PullRequestReviewCommentEvent at 2014-05-21 22:32:30
Repository: oauth2-client
Actor: philsturgeon
Payload: {"comment":{"url":"https://api.github.com/repos/thephpleague/oauth2-client/pulls/comments/12927140","id":12927140,"diff_hunk":"@@ -32,9 +32,14 @@ public function userDetails($response, \\League\\OAuth2\\Client\\Token\\AccessToken $\n         $info = $request->getInfo();\n         $imageUrl = $info['url'];\n \n+        $client->setBaseUrl('http://graph.facebook.com/' . $response->id);\n+        $request = $client->get()->send();\n+        $info = $request->json();\n+        $username = $info['username'];","path":"src/Provider/Facebook.php","position":7,"original_position":7,"commit_id":"5d9d5e1c53a94d158cc727dd44e7586f595e5c1f","original_commit_id":"5d9d5e1c53a94d158cc727dd44e7586f595e5c1f","user":{"login":"philsturgeon","id":67381,"avatar_url":"https://avatars.githubusercontent.com/u/67381?","gravatar_id":"14df293d6c5cd6f05996dfc606a6a951","url":"https://api.github.com/users/philsturgeon","html_url":"https://github.com/philsturgeon","followers_url":"https://api.github.com/users/philsturgeon/followers","following_url":"https://api.github.com/users/philsturgeon/following{/other_user}","gists_url":"https://api.github.com/users/philsturgeon/gists{/gist_id}","starred_url":"https://api.github.com/users/philsturgeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsturgeon/subscriptions","organizations_url":"https://api.github.com/users/philsturgeon/orgs","repos_url":"https://api.github.com/users/philsturgeon/repos","events_url":"https://api.github.com/users/philsturgeon/events{/privacy}","received_events_url":"https://api.github.com/users/philsturgeon/received_events","type":"User","site_admin":false},"body":"We used to assume everyone had a username. Then people complained, so we put in some code that would default to null if they didn’t. Unless something has changed, this is probably a “your experience” vrs “their experience” thing, and to play it safe we might as well just smash in an islet() check right?","created_at":"2014-05-21T22:32:30Z","updated_at":"2014-05-21T22:32:30Z","html_url":"https://github.com/thephpleague/oauth2-client/pull/98#discussion_r12927140","pull_request_url":"https://api.github.com/repos/thephpleague/oauth2-client/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/thephpleague/oauth2-client/pulls/comments/12927140"},"html":{"href":"https://github.com/thephpleague/oauth2-client/pull/98#discussion_r12927140"},"pull_request":{"href":"https://api.github.com/repos/thephpleague/oauth2-client/pulls/98"}}}}