GitHub PullRequestEvent at 2014-12-15 14:57:12
Repository: Ghost
Actor: sebgie
Payload: {"action":"closed","number":4602,"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/4602","id":25640452,"html_url":"https://github.com/TryGhost/Ghost/pull/4602","diff_url":"https://github.com/TryGhost/Ghost/pull/4602.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/4602.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/4602","number":4602,"state":"closed","locked":false,"title":"Allow re-authentication in editor after 401 response","user":{"login":"jaswilli","id":214142,"avatar_url":"https://avatars.githubusercontent.com/u/214142?v=3","gravatar_id":"","url":"https://api.github.com/users/jaswilli","html_url":"https://github.com/jaswilli","followers_url":"https://api.github.com/users/jaswilli/followers","following_url":"https://api.github.com/users/jaswilli/following{/other_user}","gists_url":"https://api.github.com/users/jaswilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jaswilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaswilli/subscriptions","organizations_url":"https://api.github.com/users/jaswilli/orgs","repos_url":"https://api.github.com/users/jaswilli/repos","events_url":"https://api.github.com/users/jaswilli/events{/privacy}","received_events_url":"https://api.github.com/users/jaswilli/received_events","type":"User","site_admin":false},"body":"This PR supersedes #3492.  The commit from #3492 has been rebased and is now working.  There are some UX and other minor details that need to be sorted out:\r\n\r\nA couple things I noticed right away (there are likely others as well):\r\n* There's currently no feedback after the re-authentication succeeds or fails.\r\n* Credentials need to be cleared from the controller after the re-auth attempt.\r\n* The modal needs to be styled.","created_at":"2014-12-08T00:39:45Z","updated_at":"2014-12-15T14:57:11Z","closed_at":"2014-12-15T14:57:11Z","merged_at":"2014-12-15T14:57:11Z","merge_commit_sha":"86ce32d3ab2419e8dcd4823875a1a091cbf824a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/4602/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/4602/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/4602/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/1541b92ccf379fedb60098564f90954884f7f202","head":{"label":"jaswilli:better-auth-retry","ref":"better-auth-retry","sha":"1541b92ccf379fedb60098564f90954884f7f202","user":{"login":"jaswilli","id":214142,"avatar_url":"https://avatars.githubusercontent.com/u/214142?v=3","gravatar_id":"","url":"https://api.github.com/users/jaswilli","html_url":"https://github.com/jaswilli","followers_url":"https://api.github.com/users/jaswilli/followers","following_url":"https://api.github.com/users/jaswilli/following{/other_user}","gists_url":"https://api.github.com/users/jaswilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jaswilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaswilli/subscriptions","organizations_url":"https://api.github.com/users/jaswilli/orgs","repos_url":"https://api.github.com/users/jaswilli/repos","events_url":"https://api.github.com/users/jaswilli/events{/privacy}","received_events_url":"https://api.github.com/users/jaswilli/received_events","type":"User","site_admin":false},"repo":{"id":17843863,"name":"Ghost","full_name":"jaswilli/Ghost","owner":{"login":"jaswilli","id":214142,"avatar_url":"https://avatars.githubusercontent.com/u/214142?v=3","gravatar_id":"","url":"https://api.github.com/users/jaswilli","html_url":"https://github.com/jaswilli","followers_url":"https://api.github.com/users/jaswilli/followers","following_url":"https://api.github.com/users/jaswilli/following{/other_user}","gists_url":"https://api.github.com/users/jaswilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jaswilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaswilli/subscriptions","organizations_url":"https://api.github.com/users/jaswilli/orgs","repos_url":"https://api.github.com/users/jaswilli/repos","events_url":"https://api.github.com/users/jaswilli/events{/privacy}","received_events_url":"https://api.github.com/users/jaswilli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaswilli/Ghost","description":"Just a blogging platform","fork":true,"url":"https://api.github.com/repos/jaswilli/Ghost","forks_url":"https://api.github.com/repos/jaswilli/Ghost/forks","keys_url":"https://api.github.com/repos/jaswilli/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaswilli/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaswilli/Ghost/teams","hooks_url":"https://api.github.com/repos/jaswilli/Ghost/hooks","issue_events_url":"https://api.github.com/repos/jaswilli/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/jaswilli/Ghost/events","assignees_url":"https://api.github.com/repos/jaswilli/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/jaswilli/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/jaswilli/Ghost/tags","blobs_url":"https://api.github.com/repos/jaswilli/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaswilli/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaswilli/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaswilli/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaswilli/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/jaswilli/Ghost/languages","stargazers_url":"https://api.github.com/repos/jaswilli/Ghost/stargazers","contributors_url":"https://api.github.com/repos/jaswilli/Ghost/contributors","subscribers_url":"https://api.github.com/repos/jaswilli/Ghost/subscribers","subscription_url":"https://api.github.com/repos/jaswilli/Ghost/subscription","commits_url":"https://api.github.com/repos/jaswilli/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaswilli/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaswilli/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaswilli/Ghost/issues/comments/{number}","contents_url":"https://api.github.com/repos/jaswilli/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/jaswilli/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaswilli/Ghost/merges","archive_url":"https://api.github.com/repos/jaswilli/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaswilli/Ghost/downloads","issues_url":"https://api.github.com/repos/jaswilli/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/jaswilli/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/jaswilli/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/jaswilli/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaswilli/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/jaswilli/Ghost/releases{/id}","created_at":"2014-03-17T21:23:46Z","updated_at":"2014-10-13T15:45:53Z","pushed_at":"2014-12-15T14:42:33Z","git_url":"git://github.com/jaswilli/Ghost.git","ssh_url":"git@github.com:jaswilli/Ghost.git","clone_url":"https://github.com/jaswilli/Ghost.git","svn_url":"https://github.com/jaswilli/Ghost","homepage":"https://ghost.org","size":15731,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"a0db21d3ec80bfa46f0f2bf1ec1a92795b5d32cd","user":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"name":"Ghost","full_name":"TryGhost/Ghost","owner":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TryGhost/Ghost","description":"Just a blogging platform","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments/{number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","created_at":"2013-05-04T11:09:13Z","updated_at":"2014-12-15T13:28:48Z","pushed_at":"2014-12-15T14:57:11Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":51351,"stargazers_count":13311,"watchers_count":13311,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2968,"mirror_url":null,"open_issues_count":214,"forks":2968,"open_issues":214,"watchers":13311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/4602"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/4602"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/4602"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/4602/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/4602/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/4602/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/1541b92ccf379fedb60098564f90954884f7f202"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sebgie","id":539213,"avatar_url":"https://avatars.githubusercontent.com/u/539213?v=3","gravatar_id":"","url":"https://api.github.com/users/sebgie","html_url":"https://github.com/sebgie","followers_url":"https://api.github.com/users/sebgie/followers","following_url":"https://api.github.com/users/sebgie/following{/other_user}","gists_url":"https://api.github.com/users/sebgie/gists{/gist_id}","starred_url":"https://api.github.com/users/sebgie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebgie/subscriptions","organizations_url":"https://api.github.com/users/sebgie/orgs","repos_url":"https://api.github.com/users/sebgie/repos","events_url":"https://api.github.com/users/sebgie/events{/privacy}","received_events_url":"https://api.github.com/users/sebgie/received_events","type":"User","site_admin":false},"comments":22,"review_comments":2,"commits":2,"additions":94,"deletions":21,"changed_files":7}}