GitHub PullRequestReviewCommentEvent at 2014-05-21 08:36:57
Repository: sql.js
Actor: lovasoa
Payload: {"comment":{"url":"https://api.github.com/repos/kripken/sql.js/pulls/comments/12885746","id":12885746,"diff_hunk":"@@ -1,20 +1,35 @@\n # Need $(EMSCRIPTEN), for example run with        emmake make\n \n-EMCC=$(EMSCRIPTEN)/emcc -s RESERVED_FUNCTION_POINTERS=2 -O2 --closure 1 -s ASM_JS=0\n-# -s INLINING_LIMIT=0\n-CFLAGS=-DSQLITE_DISABLE_LFS -DLONGDOUBLE_TYPE=double -DSQLITE_INT64_TYPE=\"long long int\" -DSQLITE_THREADSAFE=0\n+EMSCRIPTEN?=/usr/bin\n+EMCC=$(EMSCRIPTEN)/emcc -s RESERVED_FUNCTION_POINTERS=2  --closure 1 -O3 -s INLINING_LIMIT=10","path":"Makefile","position":7,"original_position":7,"commit_id":"0aa2f983547eca242f85ffde5d3486b117723867","original_commit_id":"0aa2f983547eca242f85ffde5d3486b117723867","user":{"login":"lovasoa","id":552629,"avatar_url":"https://avatars.githubusercontent.com/u/552629?","gravatar_id":"03a00fb1b519eb64384a1362cd30b9b8","url":"https://api.github.com/users/lovasoa","html_url":"https://github.com/lovasoa","followers_url":"https://api.github.com/users/lovasoa/followers","following_url":"https://api.github.com/users/lovasoa/following{/other_user}","gists_url":"https://api.github.com/users/lovasoa/gists{/gist_id}","starred_url":"https://api.github.com/users/lovasoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovasoa/subscriptions","organizations_url":"https://api.github.com/users/lovasoa/orgs","repos_url":"https://api.github.com/users/lovasoa/repos","events_url":"https://api.github.com/users/lovasoa/events{/privacy}","received_events_url":"https://api.github.com/users/lovasoa/received_events","type":"User","site_admin":false},"body":"I did that in order to completely disable inlining, and reduce asm.js compile time. I tweaked this parameter a bit before choosing 10, and the performances are correct. What value would you advice? ","created_at":"2014-05-21T08:36:57Z","updated_at":"2014-05-21T08:36:57Z","html_url":"https://github.com/kripken/sql.js/pull/45#discussion_r12885746","pull_request_url":"https://api.github.com/repos/kripken/sql.js/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/kripken/sql.js/pulls/comments/12885746"},"html":{"href":"https://github.com/kripken/sql.js/pull/45#discussion_r12885746"},"pull_request":{"href":"https://api.github.com/repos/kripken/sql.js/pulls/45"}}}}