GitHub PullRequestEvent at 2014-10-13 11:16:50
Repository: nidm
Actor: nicholst
Payload: {"action":"closed","number":186,"pull_request":{"url":"https://api.github.com/repos/incf-nidash/nidm/pulls/186","id":21848222,"html_url":"https://github.com/incf-nidash/nidm/pull/186","diff_url":"https://github.com/incf-nidash/nidm/pull/186.diff","patch_url":"https://github.com/incf-nidash/nidm/pull/186.patch","issue_url":"https://api.github.com/repos/incf-nidash/nidm/issues/186","number":186,"state":"closed","locked":false,"title":"Peak and cluster definition criteria","user":{"login":"cmaumet","id":5374264,"avatar_url":"https://avatars.githubusercontent.com/u/5374264?v=2","gravatar_id":"","url":"https://api.github.com/users/cmaumet","html_url":"https://github.com/cmaumet","followers_url":"https://api.github.com/users/cmaumet/followers","following_url":"https://api.github.com/users/cmaumet/following{/other_user}","gists_url":"https://api.github.com/users/cmaumet/gists{/gist_id}","starred_url":"https://api.github.com/users/cmaumet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmaumet/subscriptions","organizations_url":"https://api.github.com/users/cmaumet/orgs","repos_url":"https://api.github.com/users/cmaumet/repos","events_url":"https://api.github.com/users/cmaumet/events{/privacy}","received_events_url":"https://api.github.com/users/cmaumet/received_events","type":"User","site_admin":false},"body":" - Create an entity `PeakDefinitionCriteria` to store attributes: `maxNumberOfPeaksPerCluster` and `minDistanceBetweenPeaks`;\r\n - Create an entity `ClusterConnectivityCriterion` (definition provided by @nicholst in [#157](https://github.com/incf-nidash/nidm/pull/157#issuecomment-56537026)) to store the connectivity-criterion used to build the clusters.\r\n - Both `PeakDefinitionCriteria` and `ClusterConnectivityCriterion` are `used` by `Inference`.\r\n\r\nI have a couple of questions:\r\n- How do you feel about those names: `PeakDefinitionCriteria`, `ClusterConnectivityCriterion`?\r\n- Would you prefer to have a single entity storing both cluster- and peak- related parameters? If so, how could we name it?\r\n\r\nThanks for your feedback.\r\n\r\n(This pull request follows discussions in NIDASH call on September 22nd ([Minutes](https://docs.google.com/document/d/1VmHvlXFYuFwaZwdou0zhSdtoj1vQjxAGICyeoAKvl8Q/edit?usp=sharing)) and at #157).","created_at":"2014-09-26T13:27:39Z","updated_at":"2014-10-13T11:16:49Z","closed_at":"2014-10-13T11:16:49Z","merged_at":"2014-10-13T11:16:49Z","merge_commit_sha":"4315880c3b77d7af3e0705885b858c5aa3cb51e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/incf-nidash/nidm/pulls/186/commits","review_comments_url":"https://api.github.com/repos/incf-nidash/nidm/pulls/186/comments","review_comment_url":"https://api.github.com/repos/incf-nidash/nidm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/incf-nidash/nidm/issues/186/comments","statuses_url":"https://api.github.com/repos/incf-nidash/nidm/statuses/cae005752fe95881a024b283d9319542e1445fa2","head":{"label":"cmaumet:PeakAndClusterDefinitionParameters","ref":"PeakAndClusterDefinitionParameters","sha":"cae005752fe95881a024b283d9319542e1445fa2","user":{"login":"cmaumet","id":5374264,"avatar_url":"https://avatars.githubusercontent.com/u/5374264?v=2","gravatar_id":"","url":"https://api.github.com/users/cmaumet","html_url":"https://github.com/cmaumet","followers_url":"https://api.github.com/users/cmaumet/followers","following_url":"https://api.github.com/users/cmaumet/following{/other_user}","gists_url":"https://api.github.com/users/cmaumet/gists{/gist_id}","starred_url":"https://api.github.com/users/cmaumet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmaumet/subscriptions","organizations_url":"https://api.github.com/users/cmaumet/orgs","repos_url":"https://api.github.com/users/cmaumet/repos","events_url":"https://api.github.com/users/cmaumet/events{/privacy}","received_events_url":"https://api.github.com/users/cmaumet/received_events","type":"User","site_admin":false},"repo":{"id":14391464,"name":"nidm","full_name":"cmaumet/nidm","owner":{"login":"cmaumet","id":5374264,"avatar_url":"https://avatars.githubusercontent.com/u/5374264?v=2","gravatar_id":"","url":"https://api.github.com/users/cmaumet","html_url":"https://github.com/cmaumet","followers_url":"https://api.github.com/users/cmaumet/followers","following_url":"https://api.github.com/users/cmaumet/following{/other_user}","gists_url":"https://api.github.com/users/cmaumet/gists{/gist_id}","starred_url":"https://api.github.com/users/cmaumet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmaumet/subscriptions","organizations_url":"https://api.github.com/users/cmaumet/orgs","repos_url":"https://api.github.com/users/cmaumet/repos","events_url":"https://api.github.com/users/cmaumet/events{/privacy}","received_events_url":"https://api.github.com/users/cmaumet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmaumet/nidm","description":"Neuroimaging Data Model (NIDM): describing neuroimaging data and provenance","fork":true,"url":"https://api.github.com/repos/cmaumet/nidm","forks_url":"https://api.github.com/repos/cmaumet/nidm/forks","keys_url":"https://api.github.com/repos/cmaumet/nidm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmaumet/nidm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmaumet/nidm/teams","hooks_url":"https://api.github.com/repos/cmaumet/nidm/hooks","issue_events_url":"https://api.github.com/repos/cmaumet/nidm/issues/events{/number}","events_url":"https://api.github.com/repos/cmaumet/nidm/events","assignees_url":"https://api.github.com/repos/cmaumet/nidm/assignees{/user}","branches_url":"https://api.github.com/repos/cmaumet/nidm/branches{/branch}","tags_url":"https://api.github.com/repos/cmaumet/nidm/tags","blobs_url":"https://api.github.com/repos/cmaumet/nidm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmaumet/nidm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmaumet/nidm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmaumet/nidm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmaumet/nidm/statuses/{sha}","languages_url":"https://api.github.com/repos/cmaumet/nidm/languages","stargazers_url":"https://api.github.com/repos/cmaumet/nidm/stargazers","contributors_url":"https://api.github.com/repos/cmaumet/nidm/contributors","subscribers_url":"https://api.github.com/repos/cmaumet/nidm/subscribers","subscription_url":"https://api.github.com/repos/cmaumet/nidm/subscription","commits_url":"https://api.github.com/repos/cmaumet/nidm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmaumet/nidm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmaumet/nidm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmaumet/nidm/issues/comments/{number}","contents_url":"https://api.github.com/repos/cmaumet/nidm/contents/{+path}","compare_url":"https://api.github.com/repos/cmaumet/nidm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmaumet/nidm/merges","archive_url":"https://api.github.com/repos/cmaumet/nidm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmaumet/nidm/downloads","issues_url":"https://api.github.com/repos/cmaumet/nidm/issues{/number}","pulls_url":"https://api.github.com/repos/cmaumet/nidm/pulls{/number}","milestones_url":"https://api.github.com/repos/cmaumet/nidm/milestones{/number}","notifications_url":"https://api.github.com/repos/cmaumet/nidm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmaumet/nidm/labels{/name}","releases_url":"https://api.github.com/repos/cmaumet/nidm/releases{/id}","created_at":"2013-11-14T10:12:05Z","updated_at":"2014-09-17T14:28:10Z","pushed_at":"2014-10-13T11:01:44Z","git_url":"git://github.com/cmaumet/nidm.git","ssh_url":"git@github.com:cmaumet/nidm.git","clone_url":"https://github.com/cmaumet/nidm.git","svn_url":"https://github.com/cmaumet/nidm","homepage":"http://nidm.nidash.org","size":78585,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"incf-nidash:master","ref":"master","sha":"6b87a56efa0e6660528522bdb4db3341b1f3bd89","user":{"login":"incf-nidash","id":3944799,"avatar_url":"https://avatars.githubusercontent.com/u/3944799?v=2","gravatar_id":"","url":"https://api.github.com/users/incf-nidash","html_url":"https://github.com/incf-nidash","followers_url":"https://api.github.com/users/incf-nidash/followers","following_url":"https://api.github.com/users/incf-nidash/following{/other_user}","gists_url":"https://api.github.com/users/incf-nidash/gists{/gist_id}","starred_url":"https://api.github.com/users/incf-nidash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incf-nidash/subscriptions","organizations_url":"https://api.github.com/users/incf-nidash/orgs","repos_url":"https://api.github.com/users/incf-nidash/repos","events_url":"https://api.github.com/users/incf-nidash/events{/privacy}","received_events_url":"https://api.github.com/users/incf-nidash/received_events","type":"Organization","site_admin":false},"repo":{"id":8960650,"name":"nidm","full_name":"incf-nidash/nidm","owner":{"login":"incf-nidash","id":3944799,"avatar_url":"https://avatars.githubusercontent.com/u/3944799?v=2","gravatar_id":"","url":"https://api.github.com/users/incf-nidash","html_url":"https://github.com/incf-nidash","followers_url":"https://api.github.com/users/incf-nidash/followers","following_url":"https://api.github.com/users/incf-nidash/following{/other_user}","gists_url":"https://api.github.com/users/incf-nidash/gists{/gist_id}","starred_url":"https://api.github.com/users/incf-nidash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incf-nidash/subscriptions","organizations_url":"https://api.github.com/users/incf-nidash/orgs","repos_url":"https://api.github.com/users/incf-nidash/repos","events_url":"https://api.github.com/users/incf-nidash/events{/privacy}","received_events_url":"https://api.github.com/users/incf-nidash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/incf-nidash/nidm","description":"Neuroimaging Data Model (NIDM): describing neuroimaging data and provenance","fork":false,"url":"https://api.github.com/repos/incf-nidash/nidm","forks_url":"https://api.github.com/repos/incf-nidash/nidm/forks","keys_url":"https://api.github.com/repos/incf-nidash/nidm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/incf-nidash/nidm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/incf-nidash/nidm/teams","hooks_url":"https://api.github.com/repos/incf-nidash/nidm/hooks","issue_events_url":"https://api.github.com/repos/incf-nidash/nidm/issues/events{/number}","events_url":"https://api.github.com/repos/incf-nidash/nidm/events","assignees_url":"https://api.github.com/repos/incf-nidash/nidm/assignees{/user}","branches_url":"https://api.github.com/repos/incf-nidash/nidm/branches{/branch}","tags_url":"https://api.github.com/repos/incf-nidash/nidm/tags","blobs_url":"https://api.github.com/repos/incf-nidash/nidm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/incf-nidash/nidm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/incf-nidash/nidm/git/refs{/sha}","trees_url":"https://api.github.com/repos/incf-nidash/nidm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/incf-nidash/nidm/statuses/{sha}","languages_url":"https://api.github.com/repos/incf-nidash/nidm/languages","stargazers_url":"https://api.github.com/repos/incf-nidash/nidm/stargazers","contributors_url":"https://api.github.com/repos/incf-nidash/nidm/contributors","subscribers_url":"https://api.github.com/repos/incf-nidash/nidm/subscribers","subscription_url":"https://api.github.com/repos/incf-nidash/nidm/subscription","commits_url":"https://api.github.com/repos/incf-nidash/nidm/commits{/sha}","git_commits_url":"https://api.github.com/repos/incf-nidash/nidm/git/commits{/sha}","comments_url":"https://api.github.com/repos/incf-nidash/nidm/comments{/number}","issue_comment_url":"https://api.github.com/repos/incf-nidash/nidm/issues/comments/{number}","contents_url":"https://api.github.com/repos/incf-nidash/nidm/contents/{+path}","compare_url":"https://api.github.com/repos/incf-nidash/nidm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/incf-nidash/nidm/merges","archive_url":"https://api.github.com/repos/incf-nidash/nidm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/incf-nidash/nidm/downloads","issues_url":"https://api.github.com/repos/incf-nidash/nidm/issues{/number}","pulls_url":"https://api.github.com/repos/incf-nidash/nidm/pulls{/number}","milestones_url":"https://api.github.com/repos/incf-nidash/nidm/milestones{/number}","notifications_url":"https://api.github.com/repos/incf-nidash/nidm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/incf-nidash/nidm/labels{/name}","releases_url":"https://api.github.com/repos/incf-nidash/nidm/releases{/id}","created_at":"2013-03-22T20:47:55Z","updated_at":"2014-09-03T22:51:44Z","pushed_at":"2014-10-13T11:16:49Z","git_url":"git://github.com/incf-nidash/nidm.git","ssh_url":"git@github.com:incf-nidash/nidm.git","clone_url":"https://github.com/incf-nidash/nidm.git","svn_url":"https://github.com/incf-nidash/nidm","homepage":"nidm.nidash.org","size":82483,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":28,"forks":15,"open_issues":28,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/incf-nidash/nidm/pulls/186"},"html":{"href":"https://github.com/incf-nidash/nidm/pull/186"},"issue":{"href":"https://api.github.com/repos/incf-nidash/nidm/issues/186"},"comments":{"href":"https://api.github.com/repos/incf-nidash/nidm/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/incf-nidash/nidm/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/incf-nidash/nidm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/incf-nidash/nidm/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/incf-nidash/nidm/statuses/cae005752fe95881a024b283d9319542e1445fa2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nicholst","id":5155907,"avatar_url":"https://avatars.githubusercontent.com/u/5155907?v=2","gravatar_id":"","url":"https://api.github.com/users/nicholst","html_url":"https://github.com/nicholst","followers_url":"https://api.github.com/users/nicholst/followers","following_url":"https://api.github.com/users/nicholst/following{/other_user}","gists_url":"https://api.github.com/users/nicholst/gists{/gist_id}","starred_url":"https://api.github.com/users/nicholst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicholst/subscriptions","organizations_url":"https://api.github.com/users/nicholst/orgs","repos_url":"https://api.github.com/users/nicholst/repos","events_url":"https://api.github.com/users/nicholst/events{/privacy}","received_events_url":"https://api.github.com/users/nicholst/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"commits":6,"additions":267,"deletions":27,"changed_files":14}}