GitHub PullRequestReviewCommentEvent at 2014-07-25 13:21:42
Repository: go-api-toolkit
Actor: jerith
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls/comments/15399866","id":15399866,"diff_hunk":"@@ -722,6 +726,16 @@ def uncallable_collection_factory(self, *args, **kw):\n         \"\"\"\n         raise Exception(\"This collection_factory should never be called\")\n \n+    @inlineCallbacks\n+    def test_fake_auth_server_rejects_post(self):\n+        auth_server = yield self.start_fake_auth_server()\n+        # Accepts GET\n+        resp = yield treq.get(auth_server.url, persistent=False)\n+        self.assertEqual(resp.code, 200)\n+        # Rejects POST\n+        resp = yield treq.post(auth_server.url, persistent=False)\n+        self.assertEqual(resp.code, 405)","path":"go_api/cyclone/tests/test_handlers.py","position":29,"original_position":29,"commit_id":"5fbd8988d022102514f52ce02095d3644d813284","original_commit_id":"5fbd8988d022102514f52ce02095d3644d813284","user":{"login":"jerith","id":43731,"avatar_url":"https://avatars.githubusercontent.com/u/43731?","gravatar_id":"b7842ee0df3b024a6cad55bbe09c0d08","url":"https://api.github.com/users/jerith","html_url":"https://github.com/jerith","followers_url":"https://api.github.com/users/jerith/followers","following_url":"https://api.github.com/users/jerith/following{/other_user}","gists_url":"https://api.github.com/users/jerith/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith/subscriptions","organizations_url":"https://api.github.com/users/jerith/orgs","repos_url":"https://api.github.com/users/jerith/repos","events_url":"https://api.github.com/users/jerith/events{/privacy}","received_events_url":"https://api.github.com/users/jerith/received_events","type":"User","site_admin":false},"body":"I'll add a comment.","created_at":"2014-07-25T13:21:42Z","updated_at":"2014-07-25T13:21:42Z","html_url":"https://github.com/praekelt/go-api-toolkit/pull/17#discussion_r15399866","pull_request_url":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls/comments/15399866"},"html":{"href":"https://github.com/praekelt/go-api-toolkit/pull/17#discussion_r15399866"},"pull_request":{"href":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls/17","id":18894105,"html_url":"https://github.com/praekelt/go-api-toolkit/pull/17","diff_url":"https://github.com/praekelt/go-api-toolkit/pull/17.diff","patch_url":"https://github.com/praekelt/go-api-toolkit/pull/17.patch","issue_url":"https://api.github.com/repos/praekelt/go-api-toolkit/issues/17","number":17,"state":"open","title":"Fix auth bouncer requests","user":{"login":"jerith","id":43731,"avatar_url":"https://avatars.githubusercontent.com/u/43731?","gravatar_id":"b7842ee0df3b024a6cad55bbe09c0d08","url":"https://api.github.com/users/jerith","html_url":"https://github.com/jerith","followers_url":"https://api.github.com/users/jerith/followers","following_url":"https://api.github.com/users/jerith/following{/other_user}","gists_url":"https://api.github.com/users/jerith/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith/subscriptions","organizations_url":"https://api.github.com/users/jerith/orgs","repos_url":"https://api.github.com/users/jerith/repos","events_url":"https://api.github.com/users/jerith/events{/privacy}","received_events_url":"https://api.github.com/users/jerith/received_events","type":"User","site_admin":false},"body":"They should always be `GET` (for now, at least) and should exclude extraneous headers.","created_at":"2014-07-25T13:02:48Z","updated_at":"2014-07-25T13:21:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"873b432619dc86bee39152e2e3a753ba170d2693","assignee":{"login":"jerith","id":43731,"avatar_url":"https://avatars.githubusercontent.com/u/43731?","gravatar_id":"b7842ee0df3b024a6cad55bbe09c0d08","url":"https://api.github.com/users/jerith","html_url":"https://github.com/jerith","followers_url":"https://api.github.com/users/jerith/followers","following_url":"https://api.github.com/users/jerith/following{/other_user}","gists_url":"https://api.github.com/users/jerith/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith/subscriptions","organizations_url":"https://api.github.com/users/jerith/orgs","repos_url":"https://api.github.com/users/jerith/repos","events_url":"https://api.github.com/users/jerith/events{/privacy}","received_events_url":"https://api.github.com/users/jerith/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls/17/commits","review_comments_url":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls/17/comments","review_comment_url":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/praekelt/go-api-toolkit/issues/17/comments","statuses_url":"https://api.github.com/repos/praekelt/go-api-toolkit/statuses/5fbd8988d022102514f52ce02095d3644d813284","head":{"label":"praekelt:feature/issue-17-fix-auth-bouncer-requests","ref":"feature/issue-17-fix-auth-bouncer-requests","sha":"5fbd8988d022102514f52ce02095d3644d813284","user":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?","gravatar_id":"47edf894fc0eb65da3ac49bba7086967","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"repo":{"id":21817849,"name":"go-api-toolkit","full_name":"praekelt/go-api-toolkit","owner":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?","gravatar_id":"47edf894fc0eb65da3ac49bba7086967","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekelt/go-api-toolkit","description":"A toolkit of utilities for building Vumi Go APIs.","fork":false,"url":"https://api.github.com/repos/praekelt/go-api-toolkit","forks_url":"https://api.github.com/repos/praekelt/go-api-toolkit/forks","keys_url":"https://api.github.com/repos/praekelt/go-api-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekelt/go-api-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekelt/go-api-toolkit/teams","hooks_url":"https://api.github.com/repos/praekelt/go-api-toolkit/hooks","issue_events_url":"https://api.github.com/repos/praekelt/go-api-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/praekelt/go-api-toolkit/events","assignees_url":"https://api.github.com/repos/praekelt/go-api-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/praekelt/go-api-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/praekelt/go-api-toolkit/tags","blobs_url":"https://api.github.com/repos/praekelt/go-api-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekelt/go-api-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekelt/go-api-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekelt/go-api-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekelt/go-api-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/praekelt/go-api-toolkit/languages","stargazers_url":"https://api.github.com/repos/praekelt/go-api-toolkit/stargazers","contributors_url":"https://api.github.com/repos/praekelt/go-api-toolkit/contributors","subscribers_url":"https://api.github.com/repos/praekelt/go-api-toolkit/subscribers","subscription_url":"https://api.github.com/repos/praekelt/go-api-toolkit/subscription","commits_url":"https://api.github.com/repos/praekelt/go-api-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekelt/go-api-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekelt/go-api-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekelt/go-api-toolkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/praekelt/go-api-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/praekelt/go-api-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekelt/go-api-toolkit/merges","archive_url":"https://api.github.com/repos/praekelt/go-api-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekelt/go-api-toolkit/downloads","issues_url":"https://api.github.com/repos/praekelt/go-api-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/praekelt/go-api-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/praekelt/go-api-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekelt/go-api-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/praekelt/go-api-toolkit/releases{/id}","created_at":"2014-07-14T11:51:49Z","updated_at":"2014-07-14T12:00:57Z","pushed_at":"2014-07-25T13:15:18Z","git_url":"git://github.com/praekelt/go-api-toolkit.git","ssh_url":"git@github.com:praekelt/go-api-toolkit.git","clone_url":"https://github.com/praekelt/go-api-toolkit.git","svn_url":"https://github.com/praekelt/go-api-toolkit","homepage":null,"size":832,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"praekelt:develop","ref":"develop","sha":"099d655dd1789045d1d9fb7780190d5071a17507","user":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?","gravatar_id":"47edf894fc0eb65da3ac49bba7086967","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"repo":{"id":21817849,"name":"go-api-toolkit","full_name":"praekelt/go-api-toolkit","owner":{"login":"praekelt","id":81810,"avatar_url":"https://avatars.githubusercontent.com/u/81810?","gravatar_id":"47edf894fc0eb65da3ac49bba7086967","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekelt/go-api-toolkit","description":"A toolkit of utilities for building Vumi Go APIs.","fork":false,"url":"https://api.github.com/repos/praekelt/go-api-toolkit","forks_url":"https://api.github.com/repos/praekelt/go-api-toolkit/forks","keys_url":"https://api.github.com/repos/praekelt/go-api-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekelt/go-api-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekelt/go-api-toolkit/teams","hooks_url":"https://api.github.com/repos/praekelt/go-api-toolkit/hooks","issue_events_url":"https://api.github.com/repos/praekelt/go-api-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/praekelt/go-api-toolkit/events","assignees_url":"https://api.github.com/repos/praekelt/go-api-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/praekelt/go-api-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/praekelt/go-api-toolkit/tags","blobs_url":"https://api.github.com/repos/praekelt/go-api-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekelt/go-api-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekelt/go-api-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekelt/go-api-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekelt/go-api-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/praekelt/go-api-toolkit/languages","stargazers_url":"https://api.github.com/repos/praekelt/go-api-toolkit/stargazers","contributors_url":"https://api.github.com/repos/praekelt/go-api-toolkit/contributors","subscribers_url":"https://api.github.com/repos/praekelt/go-api-toolkit/subscribers","subscription_url":"https://api.github.com/repos/praekelt/go-api-toolkit/subscription","commits_url":"https://api.github.com/repos/praekelt/go-api-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekelt/go-api-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekelt/go-api-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekelt/go-api-toolkit/issues/comments/{number}","contents_url":"https://api.github.com/repos/praekelt/go-api-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/praekelt/go-api-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekelt/go-api-toolkit/merges","archive_url":"https://api.github.com/repos/praekelt/go-api-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekelt/go-api-toolkit/downloads","issues_url":"https://api.github.com/repos/praekelt/go-api-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/praekelt/go-api-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/praekelt/go-api-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekelt/go-api-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/praekelt/go-api-toolkit/releases{/id}","created_at":"2014-07-14T11:51:49Z","updated_at":"2014-07-14T12:00:57Z","pushed_at":"2014-07-25T13:15:18Z","git_url":"git://github.com/praekelt/go-api-toolkit.git","ssh_url":"git@github.com:praekelt/go-api-toolkit.git","clone_url":"https://github.com/praekelt/go-api-toolkit.git","svn_url":"https://github.com/praekelt/go-api-toolkit","homepage":null,"size":832,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls/17"},"html":{"href":"https://github.com/praekelt/go-api-toolkit/pull/17"},"issue":{"href":"https://api.github.com/repos/praekelt/go-api-toolkit/issues/17"},"comments":{"href":"https://api.github.com/repos/praekelt/go-api-toolkit/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/praekelt/go-api-toolkit/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/praekelt/go-api-toolkit/statuses/5fbd8988d022102514f52ce02095d3644d813284"}}}}