GitHub PullRequestEvent at 2014-08-21 21:26:44
Repository: context-config-node
Actor: inexplicable
Payload: {"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/cubejs/context-config-node/pulls/16","id":20138132,"html_url":"https://github.com/cubejs/context-config-node/pull/16","diff_url":"https://github.com/cubejs/context-config-node/pull/16.diff","patch_url":"https://github.com/cubejs/context-config-node/pull/16.patch","issue_url":"https://api.github.com/repos/cubejs/context-config-node/issues/16","number":16,"state":"closed","locked":false,"title":"fixing the usecase of getting false boolean value","user":{"login":"skoranga","id":664770,"avatar_url":"https://avatars.githubusercontent.com/u/664770?v=2","gravatar_id":"ec1f6d948b1f2ba215f6083202be4570","url":"https://api.github.com/users/skoranga","html_url":"https://github.com/skoranga","followers_url":"https://api.github.com/users/skoranga/followers","following_url":"https://api.github.com/users/skoranga/following{/other_user}","gists_url":"https://api.github.com/users/skoranga/gists{/gist_id}","starred_url":"https://api.github.com/users/skoranga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skoranga/subscriptions","organizations_url":"https://api.github.com/users/skoranga/orgs","repos_url":"https://api.github.com/users/skoranga/repos","events_url":"https://api.github.com/users/skoranga/events{/privacy}","received_events_url":"https://api.github.com/users/skoranga/received_events","type":"User","site_admin":false},"body":"This is to fix the use case of boolean config value. Earlier `config.get('key_for_boolean_value')` was returning defined if the value was `false`.","created_at":"2014-08-21T21:10:47Z","updated_at":"2014-08-21T21:26:44Z","closed_at":"2014-08-21T21:26:44Z","merged_at":"2014-08-21T21:26:44Z","merge_commit_sha":"19eb2f72690c1994f42f5680a657eb95c8594eab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cubejs/context-config-node/pulls/16/commits","review_comments_url":"https://api.github.com/repos/cubejs/context-config-node/pulls/16/comments","review_comment_url":"https://api.github.com/repos/cubejs/context-config-node/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cubejs/context-config-node/issues/16/comments","statuses_url":"https://api.github.com/repos/cubejs/context-config-node/statuses/eae165e9f0d753d1c211bba2ea610e20df42920a","head":{"label":"skoranga:release-0.3.x","ref":"release-0.3.x","sha":"eae165e9f0d753d1c211bba2ea610e20df42920a","user":{"login":"skoranga","id":664770,"avatar_url":"https://avatars.githubusercontent.com/u/664770?v=2","gravatar_id":"ec1f6d948b1f2ba215f6083202be4570","url":"https://api.github.com/users/skoranga","html_url":"https://github.com/skoranga","followers_url":"https://api.github.com/users/skoranga/followers","following_url":"https://api.github.com/users/skoranga/following{/other_user}","gists_url":"https://api.github.com/users/skoranga/gists{/gist_id}","starred_url":"https://api.github.com/users/skoranga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skoranga/subscriptions","organizations_url":"https://api.github.com/users/skoranga/orgs","repos_url":"https://api.github.com/users/skoranga/repos","events_url":"https://api.github.com/users/skoranga/events{/privacy}","received_events_url":"https://api.github.com/users/skoranga/received_events","type":"User","site_admin":false},"repo":{"id":23199754,"name":"context-config-node","full_name":"skoranga/context-config-node","owner":{"login":"skoranga","id":664770,"avatar_url":"https://avatars.githubusercontent.com/u/664770?v=2","gravatar_id":"ec1f6d948b1f2ba215f6083202be4570","url":"https://api.github.com/users/skoranga","html_url":"https://github.com/skoranga","followers_url":"https://api.github.com/users/skoranga/followers","following_url":"https://api.github.com/users/skoranga/following{/other_user}","gists_url":"https://api.github.com/users/skoranga/gists{/gist_id}","starred_url":"https://api.github.com/users/skoranga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skoranga/subscriptions","organizations_url":"https://api.github.com/users/skoranga/orgs","repos_url":"https://api.github.com/users/skoranga/repos","events_url":"https://api.github.com/users/skoranga/events{/privacy}","received_events_url":"https://api.github.com/users/skoranga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skoranga/context-config-node","description":"An advanced configuration lookup utility","fork":true,"url":"https://api.github.com/repos/skoranga/context-config-node","forks_url":"https://api.github.com/repos/skoranga/context-config-node/forks","keys_url":"https://api.github.com/repos/skoranga/context-config-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skoranga/context-config-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skoranga/context-config-node/teams","hooks_url":"https://api.github.com/repos/skoranga/context-config-node/hooks","issue_events_url":"https://api.github.com/repos/skoranga/context-config-node/issues/events{/number}","events_url":"https://api.github.com/repos/skoranga/context-config-node/events","assignees_url":"https://api.github.com/repos/skoranga/context-config-node/assignees{/user}","branches_url":"https://api.github.com/repos/skoranga/context-config-node/branches{/branch}","tags_url":"https://api.github.com/repos/skoranga/context-config-node/tags","blobs_url":"https://api.github.com/repos/skoranga/context-config-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skoranga/context-config-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skoranga/context-config-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/skoranga/context-config-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skoranga/context-config-node/statuses/{sha}","languages_url":"https://api.github.com/repos/skoranga/context-config-node/languages","stargazers_url":"https://api.github.com/repos/skoranga/context-config-node/stargazers","contributors_url":"https://api.github.com/repos/skoranga/context-config-node/contributors","subscribers_url":"https://api.github.com/repos/skoranga/context-config-node/subscribers","subscription_url":"https://api.github.com/repos/skoranga/context-config-node/subscription","commits_url":"https://api.github.com/repos/skoranga/context-config-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/skoranga/context-config-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/skoranga/context-config-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/skoranga/context-config-node/issues/comments/{number}","contents_url":"https://api.github.com/repos/skoranga/context-config-node/contents/{+path}","compare_url":"https://api.github.com/repos/skoranga/context-config-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skoranga/context-config-node/merges","archive_url":"https://api.github.com/repos/skoranga/context-config-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skoranga/context-config-node/downloads","issues_url":"https://api.github.com/repos/skoranga/context-config-node/issues{/number}","pulls_url":"https://api.github.com/repos/skoranga/context-config-node/pulls{/number}","milestones_url":"https://api.github.com/repos/skoranga/context-config-node/milestones{/number}","notifications_url":"https://api.github.com/repos/skoranga/context-config-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skoranga/context-config-node/labels{/name}","releases_url":"https://api.github.com/repos/skoranga/context-config-node/releases{/id}","created_at":"2014-08-21T19:15:40Z","updated_at":"2014-02-12T00:24:55Z","pushed_at":"2014-08-21T21:08:52Z","git_url":"git://github.com/skoranga/context-config-node.git","ssh_url":"git@github.com:skoranga/context-config-node.git","clone_url":"https://github.com/skoranga/context-config-node.git","svn_url":"https://github.com/skoranga/context-config-node","homepage":null,"size":213,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cubejs:release-0.3.x","ref":"release-0.3.x","sha":"82f6633698249c30ed2ea5f12cfdb66ee948eed1","user":{"login":"cubejs","id":4461669,"avatar_url":"https://avatars.githubusercontent.com/u/4461669?v=2","gravatar_id":"f426bb78cf924b060fc913e003abb36a","url":"https://api.github.com/users/cubejs","html_url":"https://github.com/cubejs","followers_url":"https://api.github.com/users/cubejs/followers","following_url":"https://api.github.com/users/cubejs/following{/other_user}","gists_url":"https://api.github.com/users/cubejs/gists{/gist_id}","starred_url":"https://api.github.com/users/cubejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cubejs/subscriptions","organizations_url":"https://api.github.com/users/cubejs/orgs","repos_url":"https://api.github.com/users/cubejs/repos","events_url":"https://api.github.com/users/cubejs/events{/privacy}","received_events_url":"https://api.github.com/users/cubejs/received_events","type":"Organization","site_admin":false},"repo":{"id":10176234,"name":"context-config-node","full_name":"cubejs/context-config-node","owner":{"login":"cubejs","id":4461669,"avatar_url":"https://avatars.githubusercontent.com/u/4461669?v=2","gravatar_id":"f426bb78cf924b060fc913e003abb36a","url":"https://api.github.com/users/cubejs","html_url":"https://github.com/cubejs","followers_url":"https://api.github.com/users/cubejs/followers","following_url":"https://api.github.com/users/cubejs/following{/other_user}","gists_url":"https://api.github.com/users/cubejs/gists{/gist_id}","starred_url":"https://api.github.com/users/cubejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cubejs/subscriptions","organizations_url":"https://api.github.com/users/cubejs/orgs","repos_url":"https://api.github.com/users/cubejs/repos","events_url":"https://api.github.com/users/cubejs/events{/privacy}","received_events_url":"https://api.github.com/users/cubejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cubejs/context-config-node","description":"An advanced configuration lookup utility","fork":false,"url":"https://api.github.com/repos/cubejs/context-config-node","forks_url":"https://api.github.com/repos/cubejs/context-config-node/forks","keys_url":"https://api.github.com/repos/cubejs/context-config-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cubejs/context-config-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cubejs/context-config-node/teams","hooks_url":"https://api.github.com/repos/cubejs/context-config-node/hooks","issue_events_url":"https://api.github.com/repos/cubejs/context-config-node/issues/events{/number}","events_url":"https://api.github.com/repos/cubejs/context-config-node/events","assignees_url":"https://api.github.com/repos/cubejs/context-config-node/assignees{/user}","branches_url":"https://api.github.com/repos/cubejs/context-config-node/branches{/branch}","tags_url":"https://api.github.com/repos/cubejs/context-config-node/tags","blobs_url":"https://api.github.com/repos/cubejs/context-config-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cubejs/context-config-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cubejs/context-config-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/cubejs/context-config-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cubejs/context-config-node/statuses/{sha}","languages_url":"https://api.github.com/repos/cubejs/context-config-node/languages","stargazers_url":"https://api.github.com/repos/cubejs/context-config-node/stargazers","contributors_url":"https://api.github.com/repos/cubejs/context-config-node/contributors","subscribers_url":"https://api.github.com/repos/cubejs/context-config-node/subscribers","subscription_url":"https://api.github.com/repos/cubejs/context-config-node/subscription","commits_url":"https://api.github.com/repos/cubejs/context-config-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/cubejs/context-config-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/cubejs/context-config-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/cubejs/context-config-node/issues/comments/{number}","contents_url":"https://api.github.com/repos/cubejs/context-config-node/contents/{+path}","compare_url":"https://api.github.com/repos/cubejs/context-config-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cubejs/context-config-node/merges","archive_url":"https://api.github.com/repos/cubejs/context-config-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cubejs/context-config-node/downloads","issues_url":"https://api.github.com/repos/cubejs/context-config-node/issues{/number}","pulls_url":"https://api.github.com/repos/cubejs/context-config-node/pulls{/number}","milestones_url":"https://api.github.com/repos/cubejs/context-config-node/milestones{/number}","notifications_url":"https://api.github.com/repos/cubejs/context-config-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cubejs/context-config-node/labels{/name}","releases_url":"https://api.github.com/repos/cubejs/context-config-node/releases{/id}","created_at":"2013-05-20T15:52:41Z","updated_at":"2014-02-12T00:24:55Z","pushed_at":"2014-08-21T21:26:44Z","git_url":"git://github.com/cubejs/context-config-node.git","ssh_url":"git@github.com:cubejs/context-config-node.git","clone_url":"https://github.com/cubejs/context-config-node.git","svn_url":"https://github.com/cubejs/context-config-node","homepage":null,"size":337,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cubejs/context-config-node/pulls/16"},"html":{"href":"https://github.com/cubejs/context-config-node/pull/16"},"issue":{"href":"https://api.github.com/repos/cubejs/context-config-node/issues/16"},"comments":{"href":"https://api.github.com/repos/cubejs/context-config-node/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/cubejs/context-config-node/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/cubejs/context-config-node/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cubejs/context-config-node/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/cubejs/context-config-node/statuses/eae165e9f0d753d1c211bba2ea610e20df42920a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"inexplicable","id":466921,"avatar_url":"https://avatars.githubusercontent.com/u/466921?v=2","gravatar_id":"fec323f287ab56225cf00ab62c77587d","url":"https://api.github.com/users/inexplicable","html_url":"https://github.com/inexplicable","followers_url":"https://api.github.com/users/inexplicable/followers","following_url":"https://api.github.com/users/inexplicable/following{/other_user}","gists_url":"https://api.github.com/users/inexplicable/gists{/gist_id}","starred_url":"https://api.github.com/users/inexplicable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inexplicable/subscriptions","organizations_url":"https://api.github.com/users/inexplicable/orgs","repos_url":"https://api.github.com/users/inexplicable/repos","events_url":"https://api.github.com/users/inexplicable/events{/privacy}","received_events_url":"https://api.github.com/users/inexplicable/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":122,"deletions":46,"changed_files":6}}