GitHub PullRequestReviewCommentEvent at 2014-10-01 15:03:29
Repository: pushgo
Actor: kitcambridge
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/comments/18284282","id":18284282,"diff_hunk":"@@ -248,8 +255,14 @@ func (self *Handler) UpdateHandler(resp http.ResponseWriter, req *http.Request)\n \t\treturn\n \t}\n \n+\t// wait to get the data (if present)\n+\tdata := req.FormValue(\"data\")","path":"src/github.com/mozilla-services/pushgo/simplepush/handlers.go","position":74,"original_position":74,"commit_id":"ab6b55381da02111566df891e819b0be9b5255ee","original_commit_id":"ab6b55381da02111566df891e819b0be9b5255ee","user":{"login":"kitcambridge","id":243830,"avatar_url":"https://avatars.githubusercontent.com/u/243830?v=2","gravatar_id":"","url":"https://api.github.com/users/kitcambridge","html_url":"https://github.com/kitcambridge","followers_url":"https://api.github.com/users/kitcambridge/followers","following_url":"https://api.github.com/users/kitcambridge/following{/other_user}","gists_url":"https://api.github.com/users/kitcambridge/gists{/gist_id}","starred_url":"https://api.github.com/users/kitcambridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitcambridge/subscriptions","organizations_url":"https://api.github.com/users/kitcambridge/orgs","repos_url":"https://api.github.com/users/kitcambridge/repos","events_url":"https://api.github.com/users/kitcambridge/events{/privacy}","received_events_url":"https://api.github.com/users/kitcambridge/received_events","type":"User","site_admin":false},"body":"D'oh, apologies for the blatantly wrong comment; I conflated passing with modification. Thanks, @rafrombrc!","created_at":"2014-10-01T15:03:29Z","updated_at":"2014-10-01T15:03:29Z","html_url":"https://github.com/mozilla-services/pushgo/pull/88#discussion_r18284282","pull_request_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/comments/18284282"},"html":{"href":"https://github.com/mozilla-services/pushgo/pull/88#discussion_r18284282"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/88","id":22044322,"html_url":"https://github.com/mozilla-services/pushgo/pull/88","diff_url":"https://github.com/mozilla-services/pushgo/pull/88.diff","patch_url":"https://github.com/mozilla-services/pushgo/pull/88.patch","issue_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/88","number":88,"state":"open","locked":false,"title":"LOW PRIORITY: FEATURE: Add data handling to SimplePush","user":{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=2","gravatar_id":"","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false},"body":"Allow \"data\" to be send to actively connected clients. This does NOT store the data, so if a client isn't connected, the data WILL BE discarded.\r\n\r\nAlso: \r\n\r\n* add unit tests for Update handler\r\n* refactor code to provide framework for adding unit tests for handlers\r\n* removed some extraneous classes that were causing data duplication.","created_at":"2014-10-01T00:02:29Z","updated_at":"2014-10-01T15:03:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdfe2a0532514d5e6a1eede95ca2bf3a2ade3d0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/88/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/88/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/88/comments","statuses_url":"https://api.github.com/repos/mozilla-services/pushgo/statuses/ab6b55381da02111566df891e819b0be9b5255ee","head":{"label":"jrconlin:feature/data","ref":"feature/data","sha":"ab6b55381da02111566df891e819b0be9b5255ee","user":{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=2","gravatar_id":"","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false},"repo":{"id":9796726,"name":"pushgo","full_name":"jrconlin/pushgo","owner":{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=2","gravatar_id":"","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrconlin/pushgo","description":"Go based SimplePush server","fork":false,"url":"https://api.github.com/repos/jrconlin/pushgo","forks_url":"https://api.github.com/repos/jrconlin/pushgo/forks","keys_url":"https://api.github.com/repos/jrconlin/pushgo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrconlin/pushgo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrconlin/pushgo/teams","hooks_url":"https://api.github.com/repos/jrconlin/pushgo/hooks","issue_events_url":"https://api.github.com/repos/jrconlin/pushgo/issues/events{/number}","events_url":"https://api.github.com/repos/jrconlin/pushgo/events","assignees_url":"https://api.github.com/repos/jrconlin/pushgo/assignees{/user}","branches_url":"https://api.github.com/repos/jrconlin/pushgo/branches{/branch}","tags_url":"https://api.github.com/repos/jrconlin/pushgo/tags","blobs_url":"https://api.github.com/repos/jrconlin/pushgo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrconlin/pushgo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrconlin/pushgo/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrconlin/pushgo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrconlin/pushgo/statuses/{sha}","languages_url":"https://api.github.com/repos/jrconlin/pushgo/languages","stargazers_url":"https://api.github.com/repos/jrconlin/pushgo/stargazers","contributors_url":"https://api.github.com/repos/jrconlin/pushgo/contributors","subscribers_url":"https://api.github.com/repos/jrconlin/pushgo/subscribers","subscription_url":"https://api.github.com/repos/jrconlin/pushgo/subscription","commits_url":"https://api.github.com/repos/jrconlin/pushgo/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrconlin/pushgo/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrconlin/pushgo/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrconlin/pushgo/issues/comments/{number}","contents_url":"https://api.github.com/repos/jrconlin/pushgo/contents/{+path}","compare_url":"https://api.github.com/repos/jrconlin/pushgo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrconlin/pushgo/merges","archive_url":"https://api.github.com/repos/jrconlin/pushgo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrconlin/pushgo/downloads","issues_url":"https://api.github.com/repos/jrconlin/pushgo/issues{/number}","pulls_url":"https://api.github.com/repos/jrconlin/pushgo/pulls{/number}","milestones_url":"https://api.github.com/repos/jrconlin/pushgo/milestones{/number}","notifications_url":"https://api.github.com/repos/jrconlin/pushgo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrconlin/pushgo/labels{/name}","releases_url":"https://api.github.com/repos/jrconlin/pushgo/releases{/id}","created_at":"2013-05-01T17:59:14Z","updated_at":"2014-07-08T04:42:39Z","pushed_at":"2014-10-01T00:07:01Z","git_url":"git://github.com/jrconlin/pushgo.git","ssh_url":"git@github.com:jrconlin/pushgo.git","clone_url":"https://github.com/jrconlin/pushgo.git","svn_url":"https://github.com/jrconlin/pushgo","homepage":null,"size":2729,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":15,"default_branch":"master"}},"base":{"label":"mozilla-services:dev","ref":"dev","sha":"2b287f815b2406c2619def39ed135f3080b84e64","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":11289838,"name":"pushgo","full_name":"mozilla-services/pushgo","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=2","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/pushgo","description":"Go based SimplePush server","fork":true,"url":"https://api.github.com/repos/mozilla-services/pushgo","forks_url":"https://api.github.com/repos/mozilla-services/pushgo/forks","keys_url":"https://api.github.com/repos/mozilla-services/pushgo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/pushgo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/pushgo/teams","hooks_url":"https://api.github.com/repos/mozilla-services/pushgo/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/pushgo/events","assignees_url":"https://api.github.com/repos/mozilla-services/pushgo/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/pushgo/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/pushgo/tags","blobs_url":"https://api.github.com/repos/mozilla-services/pushgo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/pushgo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/pushgo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/pushgo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/pushgo/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/pushgo/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/pushgo/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/pushgo/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/pushgo/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/pushgo/subscription","commits_url":"https://api.github.com/repos/mozilla-services/pushgo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/pushgo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/pushgo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/pushgo/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-services/pushgo/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/pushgo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/pushgo/merges","archive_url":"https://api.github.com/repos/mozilla-services/pushgo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/pushgo/downloads","issues_url":"https://api.github.com/repos/mozilla-services/pushgo/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/pushgo/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/pushgo/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/pushgo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/pushgo/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/pushgo/releases{/id}","created_at":"2013-07-09T18:06:52Z","updated_at":"2014-09-02T01:25:50Z","pushed_at":"2014-09-25T00:26:15Z","git_url":"git://github.com/mozilla-services/pushgo.git","ssh_url":"git@github.com:mozilla-services/pushgo.git","clone_url":"https://github.com/mozilla-services/pushgo.git","svn_url":"https://github.com/mozilla-services/pushgo","homepage":null,"size":2763,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":12,"forks":2,"open_issues":12,"watchers":12,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/88"},"html":{"href":"https://github.com/mozilla-services/pushgo/pull/88"},"issue":{"href":"https://api.github.com/repos/mozilla-services/pushgo/issues/88"},"comments":{"href":"https://api.github.com/repos/mozilla-services/pushgo/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/pushgo/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/pushgo/statuses/ab6b55381da02111566df891e819b0be9b5255ee"}}}}