GitHub PullRequestReviewCommentEvent at 2014-10-06 04:39:36
Repository: rust
Actor: P1start
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/18441361","id":18441361,"diff_hunk":"@@ -1803,35 +1803,35 @@ bitflags! {\n     #[doc = \"A set of permissions for a file or directory is represented\"]\n     #[doc = \"by a set of flags which are or'd together.\"]\n     flags FilePermission: u32 {\n-        static UserRead     = 0o400,\n-        static UserWrite    = 0o200,\n-        static UserExecute  = 0o100,\n-        static GroupRead    = 0o040,\n-        static GroupWrite   = 0o020,\n-        static GroupExecute = 0o010,\n-        static OtherRead    = 0o004,\n-        static OtherWrite   = 0o002,\n-        static OtherExecute = 0o001,\n-\n-        static UserRWX  = UserRead.bits | UserWrite.bits | UserExecute.bits,\n-        static GroupRWX = GroupRead.bits | GroupWrite.bits | GroupExecute.bits,\n-        static OtherRWX = OtherRead.bits | OtherWrite.bits | OtherExecute.bits,\n+        static USER_READ     = 0o400,\n+        static USER_WRITE    = 0o200,\n+        static USER_EXECUTE  = 0o100,\n+        static GROUP_READ    = 0o040,\n+        static GROUP_WRITE   = 0o020,\n+        static GROUP_EXECUTE = 0o010,\n+        static OTHER_READ    = 0o004,\n+        static OTHER_WRITE   = 0o002,\n+        static OTHER_EXECUTE = 0o001,\n+\n+        static USER_RWX  = USER_READ.bits | USER_WRITE.bits | USER_EXECUTE.bits,\n+        static GROUP_RWX = GROUP_READ.bits | GROUP_WRITE.bits | GROUP_EXECUTE.bits,\n+        static OTHER_RWX = OTHER_READ.bits | OTHER_WRITE.bits | OTHER_EXECUTE.bits,\n \n         #[doc = \"Permissions for user owned files, equivalent to 0644 on\"]\n         #[doc = \"unix-like systems.\"]\n-        static UserFile = UserRead.bits | UserWrite.bits | GroupRead.bits | OtherRead.bits,\n+        static USER_FILE = USER_READ.bits | USER_WRITE.bits | GROUP_READ.bits | OTHER_READ.bits,\n \n         #[doc = \"Permissions for user owned directories, equivalent to 0755 on\"]\n         #[doc = \"unix-like systems.\"]\n-        static UserDir  = UserRWX.bits | GroupRead.bits | GroupExecute.bits |\n-                   OtherRead.bits | OtherExecute.bits,\n+        static USER_DIR  = USER_RWX.bits | GROUP_READ.bits | GROUP_EXECUTE.bits |\n+                   OTHER_READ.bits | OTHER_EXECUTE.bits,\n \n         #[doc = \"Permissions for user owned executables, equivalent to 0755\"]\n         #[doc = \"on unix-like systems.\"]\n-        static UserExec = UserDir.bits,\n+        static USER_EXEC = USER_DIR.bits,\n \n         #[doc = \"All possible permissions enabled.\"]\n-        static AllPermissions = UserRWX.bits | GroupRWX.bits | OtherRWX.bits,\n+        static ALL_PERMISSIONS = USER_RWX.bits | GROUP_RWX.bits | OTHER_RWX.bits,","path":"src/libstd/io/mod.rs","position":50,"original_position":50,"commit_id":"8e58771965d677da2c39dbfeee1055db851a2e30","original_commit_id":"9663398bd05f8045e6aceef7ee1b3b4c8c22aa70","user":{"login":"P1start","id":2055302,"avatar_url":"https://avatars.githubusercontent.com/u/2055302?v=2","gravatar_id":"","url":"https://api.github.com/users/P1start","html_url":"https://github.com/P1start","followers_url":"https://api.github.com/users/P1start/followers","following_url":"https://api.github.com/users/P1start/following{/other_user}","gists_url":"https://api.github.com/users/P1start/gists{/gist_id}","starred_url":"https://api.github.com/users/P1start/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/P1start/subscriptions","organizations_url":"https://api.github.com/users/P1start/orgs","repos_url":"https://api.github.com/users/P1start/repos","events_url":"https://api.github.com/users/P1start/events{/privacy}","received_events_url":"https://api.github.com/users/P1start/received_events","type":"User","site_admin":false},"body":"OK, done.","created_at":"2014-10-06T04:39:36Z","updated_at":"2014-10-06T04:39:36Z","html_url":"https://github.com/rust-lang/rust/pull/17781#discussion_r18441361","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/17781","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/18441361"},"html":{"href":"https://github.com/rust-lang/rust/pull/17781#discussion_r18441361"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17781"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/17781","id":22248495,"html_url":"https://github.com/rust-lang/rust/pull/17781","diff_url":"https://github.com/rust-lang/rust/pull/17781.diff","patch_url":"https://github.com/rust-lang/rust/pull/17781.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/17781","number":17781,"state":"open","locked":false,"title":"Remove the #[allow(non_uppercase_statics)] attribute from inside bitflags!","user":{"login":"P1start","id":2055302,"avatar_url":"https://avatars.githubusercontent.com/u/2055302?v=2","gravatar_id":"","url":"https://api.github.com/users/P1start","html_url":"https://github.com/P1start","followers_url":"https://api.github.com/users/P1start/followers","following_url":"https://api.github.com/users/P1start/following{/other_user}","gists_url":"https://api.github.com/users/P1start/gists{/gist_id}","starred_url":"https://api.github.com/users/P1start/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/P1start/subscriptions","organizations_url":"https://api.github.com/users/P1start/orgs","repos_url":"https://api.github.com/users/P1start/repos","events_url":"https://api.github.com/users/P1start/events{/privacy}","received_events_url":"https://api.github.com/users/P1start/received_events","type":"User","site_admin":false},"body":"Closes #17773.","created_at":"2014-10-04T21:54:17Z","updated_at":"2014-10-06T04:39:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a73fa6cbf9ab329bbbd61b31336c8bf39fa18d50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/17781/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/17781/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/17781/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/8e58771965d677da2c39dbfeee1055db851a2e30","head":{"label":"P1start:bitflags-lints","ref":"bitflags-lints","sha":"8e58771965d677da2c39dbfeee1055db851a2e30","user":{"login":"P1start","id":2055302,"avatar_url":"https://avatars.githubusercontent.com/u/2055302?v=2","gravatar_id":"","url":"https://api.github.com/users/P1start","html_url":"https://github.com/P1start","followers_url":"https://api.github.com/users/P1start/followers","following_url":"https://api.github.com/users/P1start/following{/other_user}","gists_url":"https://api.github.com/users/P1start/gists{/gist_id}","starred_url":"https://api.github.com/users/P1start/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/P1start/subscriptions","organizations_url":"https://api.github.com/users/P1start/orgs","repos_url":"https://api.github.com/users/P1start/repos","events_url":"https://api.github.com/users/P1start/events{/privacy}","received_events_url":"https://api.github.com/users/P1start/received_events","type":"User","site_admin":false},"repo":{"id":19906676,"name":"rust","full_name":"P1start/rust","owner":{"login":"P1start","id":2055302,"avatar_url":"https://avatars.githubusercontent.com/u/2055302?v=2","gravatar_id":"","url":"https://api.github.com/users/P1start","html_url":"https://github.com/P1start","followers_url":"https://api.github.com/users/P1start/followers","following_url":"https://api.github.com/users/P1start/following{/other_user}","gists_url":"https://api.github.com/users/P1start/gists{/gist_id}","starred_url":"https://api.github.com/users/P1start/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/P1start/subscriptions","organizations_url":"https://api.github.com/users/P1start/orgs","repos_url":"https://api.github.com/users/P1start/repos","events_url":"https://api.github.com/users/P1start/events{/privacy}","received_events_url":"https://api.github.com/users/P1start/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/P1start/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/P1start/rust","forks_url":"https://api.github.com/repos/P1start/rust/forks","keys_url":"https://api.github.com/repos/P1start/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/P1start/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/P1start/rust/teams","hooks_url":"https://api.github.com/repos/P1start/rust/hooks","issue_events_url":"https://api.github.com/repos/P1start/rust/issues/events{/number}","events_url":"https://api.github.com/repos/P1start/rust/events","assignees_url":"https://api.github.com/repos/P1start/rust/assignees{/user}","branches_url":"https://api.github.com/repos/P1start/rust/branches{/branch}","tags_url":"https://api.github.com/repos/P1start/rust/tags","blobs_url":"https://api.github.com/repos/P1start/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/P1start/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/P1start/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/P1start/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/P1start/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/P1start/rust/languages","stargazers_url":"https://api.github.com/repos/P1start/rust/stargazers","contributors_url":"https://api.github.com/repos/P1start/rust/contributors","subscribers_url":"https://api.github.com/repos/P1start/rust/subscribers","subscription_url":"https://api.github.com/repos/P1start/rust/subscription","commits_url":"https://api.github.com/repos/P1start/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/P1start/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/P1start/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/P1start/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/P1start/rust/contents/{+path}","compare_url":"https://api.github.com/repos/P1start/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/P1start/rust/merges","archive_url":"https://api.github.com/repos/P1start/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/P1start/rust/downloads","issues_url":"https://api.github.com/repos/P1start/rust/issues{/number}","pulls_url":"https://api.github.com/repos/P1start/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/P1start/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/P1start/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/P1start/rust/labels{/name}","releases_url":"https://api.github.com/repos/P1start/rust/releases{/id}","created_at":"2014-05-18T08:56:15Z","updated_at":"2014-06-27T11:13:57Z","pushed_at":"2014-10-06T03:43:53Z","git_url":"git://github.com/P1start/rust.git","ssh_url":"git@github.com:P1start/rust.git","clone_url":"https://github.com/P1start/rust.git","svn_url":"https://github.com/P1start/rust","homepage":"http://www.rust-lang.org","size":168619,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"6d15f28986e00e1a1b290b0f0fcf76c3f4e6e261","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=2","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=2","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2014-10-06T03:34:37Z","pushed_at":"2014-10-06T02:52:22Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":481875,"stargazers_count":6748,"watchers_count":6748,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1327,"mirror_url":null,"open_issues_count":1925,"forks":1327,"open_issues":1925,"watchers":6748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17781"},"html":{"href":"https://github.com/rust-lang/rust/pull/17781"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/17781"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/17781/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17781/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17781/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/8e58771965d677da2c39dbfeee1055db851a2e30"}}}}