GitHub PullRequestReviewCommentEvent at 2014-08-13 22:35:10
Repository: doby-grid
Actor: globexdesigns
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/globexdesigns/doby-grid/pulls/comments/16211204","id":16211204,"diff_hunk":"@@ -4880,22 +4961,9 @@\n \t\tgetColumnContentWidth = function (column_index) {\n \t\t\tif (!self.options.showHeader) return;\n \n-\t\t\tvar columnElements = $headers.children(),\n-\t\t\t\t$column = $(columnElements[column_index]),\n-\t\t\t\tcurrentWidth = $column.width(),\n-\t\t\t\theaderPadding = parseInt($column.css('paddingLeft'), 10) + parseInt($column.css('paddingRight'), 10),\n-\t\t\t\tcellWidths = [];\n+\t\t\tvar cellWidths = [];\n \n-\t\t\t// Determine the width of the column name text","path":"src/doby-grid.js","position":172,"original_position":172,"commit_id":"f4ff64609b0a5603b0dfbd9c0ce0d21584771993","original_commit_id":"f4ff64609b0a5603b0dfbd9c0ce0d21584771993","user":{"login":"globexdesigns","id":226640,"avatar_url":"https://avatars.githubusercontent.com/u/226640?v=2","gravatar_id":"4f3adf4879bbb57c97d76614f0c7787d","url":"https://api.github.com/users/globexdesigns","html_url":"https://github.com/globexdesigns","followers_url":"https://api.github.com/users/globexdesigns/followers","following_url":"https://api.github.com/users/globexdesigns/following{/other_user}","gists_url":"https://api.github.com/users/globexdesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/globexdesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globexdesigns/subscriptions","organizations_url":"https://api.github.com/users/globexdesigns/orgs","repos_url":"https://api.github.com/users/globexdesigns/repos","events_url":"https://api.github.com/users/globexdesigns/events{/privacy}","received_events_url":"https://api.github.com/users/globexdesigns/received_events","type":"User","site_admin":false},"body":"Can you please this comment there so that it's clear that the header width is accounted for in the getColumnContentWidth?","created_at":"2014-08-13T22:35:10Z","updated_at":"2014-08-13T22:35:10Z","html_url":"https://github.com/globexdesigns/doby-grid/pull/104#discussion_r16211204","pull_request_url":"https://api.github.com/repos/globexdesigns/doby-grid/pulls/104","_links":{"self":{"href":"https://api.github.com/repos/globexdesigns/doby-grid/pulls/comments/16211204"},"html":{"href":"https://github.com/globexdesigns/doby-grid/pull/104#discussion_r16211204"},"pull_request":{"href":"https://api.github.com/repos/globexdesigns/doby-grid/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/globexdesigns/doby-grid/pulls/104","id":19282337,"html_url":"https://github.com/globexdesigns/doby-grid/pull/104","diff_url":"https://github.com/globexdesigns/doby-grid/pull/104.diff","patch_url":"https://github.com/globexdesigns/doby-grid/pull/104.patch","issue_url":"https://api.github.com/repos/globexdesigns/doby-grid/issues/104","number":104,"state":"open","locked":false,"title":"Feature columnautowidth","user":{"login":"ckosmowski","id":2411084,"avatar_url":"https://avatars.githubusercontent.com/u/2411084?v=2","gravatar_id":"b335c649c5cc0f71f2eaa1927b2127fd","url":"https://api.github.com/users/ckosmowski","html_url":"https://github.com/ckosmowski","followers_url":"https://api.github.com/users/ckosmowski/followers","following_url":"https://api.github.com/users/ckosmowski/following{/other_user}","gists_url":"https://api.github.com/users/ckosmowski/gists{/gist_id}","starred_url":"https://api.github.com/users/ckosmowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckosmowski/subscriptions","organizations_url":"https://api.github.com/users/ckosmowski/orgs","repos_url":"https://api.github.com/users/ckosmowski/repos","events_url":"https://api.github.com/users/ckosmowski/events{/privacy}","received_events_url":"https://api.github.com/users/ckosmowski/received_events","type":"User","site_admin":false},"body":"As described in https://github.com/globexdesigns/doby-grid/issues/98 i added an option \"fitColumnsToHeader\". If activated:\r\n\r\n1.) All Columns will be resized so that the complete content of theire headers is visible\r\n2.) The minWidth of all columns will be set to whatever is larger the initial minWidth or the size of the content in the header.\r\n\r\nThe result is, that columns cannot be resized to be smaller than their headers content.","created_at":"2014-08-04T13:38:24Z","updated_at":"2014-08-13T22:35:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efc94bd5bf823e884e0c584c391fae25c882b8b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/globexdesigns/doby-grid/pulls/104/commits","review_comments_url":"https://api.github.com/repos/globexdesigns/doby-grid/pulls/104/comments","review_comment_url":"https://api.github.com/repos/globexdesigns/doby-grid/pulls/comments/{number}","comments_url":"https://api.github.com/repos/globexdesigns/doby-grid/issues/104/comments","statuses_url":"https://api.github.com/repos/globexdesigns/doby-grid/statuses/f4ff64609b0a5603b0dfbd9c0ce0d21584771993","head":{"label":"ckosmowski:feature-columnautowidth","ref":"feature-columnautowidth","sha":"f4ff64609b0a5603b0dfbd9c0ce0d21584771993","user":{"login":"ckosmowski","id":2411084,"avatar_url":"https://avatars.githubusercontent.com/u/2411084?v=2","gravatar_id":"b335c649c5cc0f71f2eaa1927b2127fd","url":"https://api.github.com/users/ckosmowski","html_url":"https://github.com/ckosmowski","followers_url":"https://api.github.com/users/ckosmowski/followers","following_url":"https://api.github.com/users/ckosmowski/following{/other_user}","gists_url":"https://api.github.com/users/ckosmowski/gists{/gist_id}","starred_url":"https://api.github.com/users/ckosmowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckosmowski/subscriptions","organizations_url":"https://api.github.com/users/ckosmowski/orgs","repos_url":"https://api.github.com/users/ckosmowski/repos","events_url":"https://api.github.com/users/ckosmowski/events{/privacy}","received_events_url":"https://api.github.com/users/ckosmowski/received_events","type":"User","site_admin":false},"repo":{"id":21934314,"name":"doby-grid","full_name":"ckosmowski/doby-grid","owner":{"login":"ckosmowski","id":2411084,"avatar_url":"https://avatars.githubusercontent.com/u/2411084?v=2","gravatar_id":"b335c649c5cc0f71f2eaa1927b2127fd","url":"https://api.github.com/users/ckosmowski","html_url":"https://github.com/ckosmowski","followers_url":"https://api.github.com/users/ckosmowski/followers","following_url":"https://api.github.com/users/ckosmowski/following{/other_user}","gists_url":"https://api.github.com/users/ckosmowski/gists{/gist_id}","starred_url":"https://api.github.com/users/ckosmowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckosmowski/subscriptions","organizations_url":"https://api.github.com/users/ckosmowski/orgs","repos_url":"https://api.github.com/users/ckosmowski/repos","events_url":"https://api.github.com/users/ckosmowski/events{/privacy}","received_events_url":"https://api.github.com/users/ckosmowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ckosmowski/doby-grid","description":"An HTML table element on steroids.","fork":true,"url":"https://api.github.com/repos/ckosmowski/doby-grid","forks_url":"https://api.github.com/repos/ckosmowski/doby-grid/forks","keys_url":"https://api.github.com/repos/ckosmowski/doby-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckosmowski/doby-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckosmowski/doby-grid/teams","hooks_url":"https://api.github.com/repos/ckosmowski/doby-grid/hooks","issue_events_url":"https://api.github.com/repos/ckosmowski/doby-grid/issues/events{/number}","events_url":"https://api.github.com/repos/ckosmowski/doby-grid/events","assignees_url":"https://api.github.com/repos/ckosmowski/doby-grid/assignees{/user}","branches_url":"https://api.github.com/repos/ckosmowski/doby-grid/branches{/branch}","tags_url":"https://api.github.com/repos/ckosmowski/doby-grid/tags","blobs_url":"https://api.github.com/repos/ckosmowski/doby-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckosmowski/doby-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckosmowski/doby-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckosmowski/doby-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckosmowski/doby-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/ckosmowski/doby-grid/languages","stargazers_url":"https://api.github.com/repos/ckosmowski/doby-grid/stargazers","contributors_url":"https://api.github.com/repos/ckosmowski/doby-grid/contributors","subscribers_url":"https://api.github.com/repos/ckosmowski/doby-grid/subscribers","subscription_url":"https://api.github.com/repos/ckosmowski/doby-grid/subscription","commits_url":"https://api.github.com/repos/ckosmowski/doby-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckosmowski/doby-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckosmowski/doby-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckosmowski/doby-grid/issues/comments/{number}","contents_url":"https://api.github.com/repos/ckosmowski/doby-grid/contents/{+path}","compare_url":"https://api.github.com/repos/ckosmowski/doby-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckosmowski/doby-grid/merges","archive_url":"https://api.github.com/repos/ckosmowski/doby-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckosmowski/doby-grid/downloads","issues_url":"https://api.github.com/repos/ckosmowski/doby-grid/issues{/number}","pulls_url":"https://api.github.com/repos/ckosmowski/doby-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/ckosmowski/doby-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/ckosmowski/doby-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckosmowski/doby-grid/labels{/name}","releases_url":"https://api.github.com/repos/ckosmowski/doby-grid/releases{/id}","created_at":"2014-07-17T08:26:52Z","updated_at":"2014-07-17T08:35:36Z","pushed_at":"2014-08-13T13:22:50Z","git_url":"git://github.com/ckosmowski/doby-grid.git","ssh_url":"git@github.com:ckosmowski/doby-grid.git","clone_url":"https://github.com/ckosmowski/doby-grid.git","svn_url":"https://github.com/ckosmowski/doby-grid","homepage":"https://github.com/globexdesigns/doby-grid/wiki","size":3473,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"globexdesigns:master","ref":"master","sha":"89b21be1134376d0965032f3f92c9a5809fb317e","user":{"login":"globexdesigns","id":226640,"avatar_url":"https://avatars.githubusercontent.com/u/226640?v=2","gravatar_id":"4f3adf4879bbb57c97d76614f0c7787d","url":"https://api.github.com/users/globexdesigns","html_url":"https://github.com/globexdesigns","followers_url":"https://api.github.com/users/globexdesigns/followers","following_url":"https://api.github.com/users/globexdesigns/following{/other_user}","gists_url":"https://api.github.com/users/globexdesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/globexdesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globexdesigns/subscriptions","organizations_url":"https://api.github.com/users/globexdesigns/orgs","repos_url":"https://api.github.com/users/globexdesigns/repos","events_url":"https://api.github.com/users/globexdesigns/events{/privacy}","received_events_url":"https://api.github.com/users/globexdesigns/received_events","type":"User","site_admin":false},"repo":{"id":12719735,"name":"doby-grid","full_name":"globexdesigns/doby-grid","owner":{"login":"globexdesigns","id":226640,"avatar_url":"https://avatars.githubusercontent.com/u/226640?v=2","gravatar_id":"4f3adf4879bbb57c97d76614f0c7787d","url":"https://api.github.com/users/globexdesigns","html_url":"https://github.com/globexdesigns","followers_url":"https://api.github.com/users/globexdesigns/followers","following_url":"https://api.github.com/users/globexdesigns/following{/other_user}","gists_url":"https://api.github.com/users/globexdesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/globexdesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globexdesigns/subscriptions","organizations_url":"https://api.github.com/users/globexdesigns/orgs","repos_url":"https://api.github.com/users/globexdesigns/repos","events_url":"https://api.github.com/users/globexdesigns/events{/privacy}","received_events_url":"https://api.github.com/users/globexdesigns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/globexdesigns/doby-grid","description":"An HTML table element on steroids.","fork":false,"url":"https://api.github.com/repos/globexdesigns/doby-grid","forks_url":"https://api.github.com/repos/globexdesigns/doby-grid/forks","keys_url":"https://api.github.com/repos/globexdesigns/doby-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/globexdesigns/doby-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/globexdesigns/doby-grid/teams","hooks_url":"https://api.github.com/repos/globexdesigns/doby-grid/hooks","issue_events_url":"https://api.github.com/repos/globexdesigns/doby-grid/issues/events{/number}","events_url":"https://api.github.com/repos/globexdesigns/doby-grid/events","assignees_url":"https://api.github.com/repos/globexdesigns/doby-grid/assignees{/user}","branches_url":"https://api.github.com/repos/globexdesigns/doby-grid/branches{/branch}","tags_url":"https://api.github.com/repos/globexdesigns/doby-grid/tags","blobs_url":"https://api.github.com/repos/globexdesigns/doby-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/globexdesigns/doby-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/globexdesigns/doby-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/globexdesigns/doby-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/globexdesigns/doby-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/globexdesigns/doby-grid/languages","stargazers_url":"https://api.github.com/repos/globexdesigns/doby-grid/stargazers","contributors_url":"https://api.github.com/repos/globexdesigns/doby-grid/contributors","subscribers_url":"https://api.github.com/repos/globexdesigns/doby-grid/subscribers","subscription_url":"https://api.github.com/repos/globexdesigns/doby-grid/subscription","commits_url":"https://api.github.com/repos/globexdesigns/doby-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/globexdesigns/doby-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/globexdesigns/doby-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/globexdesigns/doby-grid/issues/comments/{number}","contents_url":"https://api.github.com/repos/globexdesigns/doby-grid/contents/{+path}","compare_url":"https://api.github.com/repos/globexdesigns/doby-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/globexdesigns/doby-grid/merges","archive_url":"https://api.github.com/repos/globexdesigns/doby-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/globexdesigns/doby-grid/downloads","issues_url":"https://api.github.com/repos/globexdesigns/doby-grid/issues{/number}","pulls_url":"https://api.github.com/repos/globexdesigns/doby-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/globexdesigns/doby-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/globexdesigns/doby-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/globexdesigns/doby-grid/labels{/name}","releases_url":"https://api.github.com/repos/globexdesigns/doby-grid/releases{/id}","created_at":"2013-09-10T03:48:57Z","updated_at":"2014-07-26T17:59:01Z","pushed_at":"2014-08-13T21:29:18Z","git_url":"git://github.com/globexdesigns/doby-grid.git","ssh_url":"git@github.com:globexdesigns/doby-grid.git","clone_url":"https://github.com/globexdesigns/doby-grid.git","svn_url":"https://github.com/globexdesigns/doby-grid","homepage":"https://github.com/globexdesigns/doby-grid/wiki","size":11579,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":53,"forks":4,"open_issues":53,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/globexdesigns/doby-grid/pulls/104"},"html":{"href":"https://github.com/globexdesigns/doby-grid/pull/104"},"issue":{"href":"https://api.github.com/repos/globexdesigns/doby-grid/issues/104"},"comments":{"href":"https://api.github.com/repos/globexdesigns/doby-grid/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/globexdesigns/doby-grid/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/globexdesigns/doby-grid/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/globexdesigns/doby-grid/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/globexdesigns/doby-grid/statuses/f4ff64609b0a5603b0dfbd9c0ce0d21584771993"}}}}