GitHub PullRequestEvent at 2014-03-24 14:39:16
Repository: ansible
Actor: jimi-c
Payload: {"action":"closed","number":6593,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/6593","id":13780292,"html_url":"https://github.com/ansible/ansible/pull/6593","diff_url":"https://github.com/ansible/ansible/pull/6593.diff","patch_url":"https://github.com/ansible/ansible/pull/6593.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/6593","number":6593,"state":"closed","title":"Atomic move restore owner group rebase","user":{"login":"tyll","id":197720,"avatar_url":"https://avatars.githubusercontent.com/u/197720?","gravatar_id":"ec5df2882cefc8f9554c4e87a092df47","url":"https://api.github.com/users/tyll","html_url":"https://github.com/tyll","followers_url":"https://api.github.com/users/tyll/followers","following_url":"https://api.github.com/users/tyll/following{/other_user}","gists_url":"https://api.github.com/users/tyll/gists{/gist_id}","starred_url":"https://api.github.com/users/tyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyll/subscriptions","organizations_url":"https://api.github.com/users/tyll/orgs","repos_url":"https://api.github.com/users/tyll/repos","events_url":"https://api.github.com/users/tyll/events{/privacy}","received_events_url":"https://api.github.com/users/tyll/received_events","type":"User","site_admin":false},"body":"If src and dest in atomic_move() are not on the same file system, the owner/group of dest are not restored. This can be tested with the lineinffile module:\r\n\r\n    touch /root/lineinfile-test.txt\r\n    chown nobody:  /root/lineinfile-test.txt\r\n    ansible --sudo host -m lineinfile -a \"dest=/root/lineinfile-test.txt regexp=^test line=test state=present\"\r\n\r\nAfterwards the /root/lineinfile-test.txt does not belong to nobody anymore. For this happen /tmp needs to be on a separate filesystem.\r\n\r\nAlso note that the tempfile in atomic_move() is created insecurely, this is fixed by using the tempfile module.","created_at":"2014-03-20T10:17:14Z","updated_at":"2014-03-24T14:39:16Z","closed_at":"2014-03-24T14:39:16Z","merged_at":"2014-03-24T14:39:16Z","merge_commit_sha":"ca8ab930c57aa0533213952d9335654e13d06464","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/6593/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/6593/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/6593/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/898a38b074f2561d19059315030b2b5da68a4f34","head":{"label":"tyll:atomic_move_restore_owner_group_rebase","ref":"atomic_move_restore_owner_group_rebase","sha":"898a38b074f2561d19059315030b2b5da68a4f34","user":{"login":"tyll","id":197720,"avatar_url":"https://avatars.githubusercontent.com/u/197720?","gravatar_id":"ec5df2882cefc8f9554c4e87a092df47","url":"https://api.github.com/users/tyll","html_url":"https://github.com/tyll","followers_url":"https://api.github.com/users/tyll/followers","following_url":"https://api.github.com/users/tyll/following{/other_user}","gists_url":"https://api.github.com/users/tyll/gists{/gist_id}","starred_url":"https://api.github.com/users/tyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyll/subscriptions","organizations_url":"https://api.github.com/users/tyll/orgs","repos_url":"https://api.github.com/users/tyll/repos","events_url":"https://api.github.com/users/tyll/events{/privacy}","received_events_url":"https://api.github.com/users/tyll/received_events","type":"User","site_admin":false},"repo":{"id":8806320,"name":"ansible","full_name":"tyll/ansible","owner":{"login":"tyll","id":197720,"avatar_url":"https://avatars.githubusercontent.com/u/197720?","gravatar_id":"ec5df2882cefc8f9554c4e87a092df47","url":"https://api.github.com/users/tyll","html_url":"https://github.com/tyll","followers_url":"https://api.github.com/users/tyll/followers","following_url":"https://api.github.com/users/tyll/following{/other_user}","gists_url":"https://api.github.com/users/tyll/gists{/gist_id}","starred_url":"https://api.github.com/users/tyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyll/subscriptions","organizations_url":"https://api.github.com/users/tyll/orgs","repos_url":"https://api.github.com/users/tyll/repos","events_url":"https://api.github.com/users/tyll/events{/privacy}","received_events_url":"https://api.github.com/users/tyll/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tyll/ansible","description":"Model-driven configuration management, multi-node deployment/orchestration, and remote task execution system.   Uses SSH by default, so there is no special software has to be installed on the nodes you manage.  Ansible can be extended in any language.  Note: The default branch is the development branch which many people run directly from checkout, if you need a stable version, see the release-XX branches, tags, or ansible.cc/releases. ","fork":true,"url":"https://api.github.com/repos/tyll/ansible","forks_url":"https://api.github.com/repos/tyll/ansible/forks","keys_url":"https://api.github.com/repos/tyll/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tyll/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tyll/ansible/teams","hooks_url":"https://api.github.com/repos/tyll/ansible/hooks","issue_events_url":"https://api.github.com/repos/tyll/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/tyll/ansible/events","assignees_url":"https://api.github.com/repos/tyll/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/tyll/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/tyll/ansible/tags","blobs_url":"https://api.github.com/repos/tyll/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tyll/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tyll/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/tyll/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tyll/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/tyll/ansible/languages","stargazers_url":"https://api.github.com/repos/tyll/ansible/stargazers","contributors_url":"https://api.github.com/repos/tyll/ansible/contributors","subscribers_url":"https://api.github.com/repos/tyll/ansible/subscribers","subscription_url":"https://api.github.com/repos/tyll/ansible/subscription","commits_url":"https://api.github.com/repos/tyll/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/tyll/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/tyll/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/tyll/ansible/issues/comments/{number}","contents_url":"https://api.github.com/repos/tyll/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/tyll/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tyll/ansible/merges","archive_url":"https://api.github.com/repos/tyll/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tyll/ansible/downloads","issues_url":"https://api.github.com/repos/tyll/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/tyll/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/tyll/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/tyll/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tyll/ansible/labels{/name}","releases_url":"https://api.github.com/repos/tyll/ansible/releases{/id}","created_at":"2013-03-15T18:36:53Z","updated_at":"2014-03-24T14:39:16Z","pushed_at":"2014-03-20T11:35:16Z","git_url":"git://github.com/tyll/ansible.git","ssh_url":"git@github.com:tyll/ansible.git","clone_url":"https://github.com/tyll/ansible.git","svn_url":"https://github.com/tyll/ansible","homepage":"http://ansible.cc","size":17734,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel","master_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"991399edf0e4b1609eb8c9d1608c90e22d50b753","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?","gravatar_id":"f9759b728f6026571043dc66cd36edf2","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?","gravatar_id":"f9759b728f6026571043dc66cd36edf2","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments/{number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","created_at":"2012-03-06T14:58:02Z","updated_at":"2014-03-24T14:39:02Z","pushed_at":"2014-03-24T14:39:03Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":100104,"stargazers_count":5221,"watchers_count":5221,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":1548,"mirror_url":null,"open_issues_count":329,"forks":1548,"open_issues":329,"watchers":5221,"default_branch":"devel","master_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/6593"},"html":{"href":"https://github.com/ansible/ansible/pull/6593"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/6593"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/6593/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/6593/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/6593/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/898a38b074f2561d19059315030b2b5da68a4f34"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jimi-c","id":26403,"avatar_url":"https://avatars.githubusercontent.com/u/26403?","gravatar_id":"033e03e7fdcfc5aaa660e83231f31f80","url":"https://api.github.com/users/jimi-c","html_url":"https://github.com/jimi-c","followers_url":"https://api.github.com/users/jimi-c/followers","following_url":"https://api.github.com/users/jimi-c/following{/other_user}","gists_url":"https://api.github.com/users/jimi-c/gists{/gist_id}","starred_url":"https://api.github.com/users/jimi-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimi-c/subscriptions","organizations_url":"https://api.github.com/users/jimi-c/orgs","repos_url":"https://api.github.com/users/jimi-c/repos","events_url":"https://api.github.com/users/jimi-c/events{/privacy}","received_events_url":"https://api.github.com/users/jimi-c/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":2,"additions":13,"deletions":6,"changed_files":1}}