GitHub PullRequestReviewCommentEvent at 2014-02-10 11:35:30
Repository: opencv
Actor: alalek
Payload: {"comment":{"url":"https://api.github.com/repos/Itseez/opencv/pulls/comments/9580806","id":9580806,"diff_hunk":"@@ -1137,17 +1167,24 @@ class CV_EXPORTS UMat\n public:\n     //! default constructor\n     UMat();\n+    UMat(UMatUsageFlags usageFlags);\n     //! constructs 2D matrix of the specified size and type\n     // (_type is CV_8UC1, CV_64FC3, CV_32SC(12) etc.)\n     UMat(int rows, int cols, int type);\n     UMat(Size size, int type);\n+    UMat(UMatUsageFlags usageFlags, int rows, int cols, int type);\n+    UMat(UMatUsageFlags usageFlags, Size size, int type);","path":"modules/core/include/opencv2/core/mat.hpp","position":72,"original_position":72,"commit_id":"3f1f17b78d4dd240bc7a176a0bfe1d2f490ba9a9","original_commit_id":"3f1f17b78d4dd240bc7a176a0bfe1d2f490ba9a9","user":{"login":"alalek","id":4981219,"avatar_url":"https://gravatar.com/avatar/8f374d0f74f3fdc04d9213b6b2d56781?d=https%3A%2F%2Fidenticons.github.com%2F3b6325b66c3db84194ec02d4f86810a6.png&r=x","gravatar_id":"8f374d0f74f3fdc04d9213b6b2d56781","url":"https://api.github.com/users/alalek","html_url":"https://github.com/alalek","followers_url":"https://api.github.com/users/alalek/followers","following_url":"https://api.github.com/users/alalek/following{/other_user}","gists_url":"https://api.github.com/users/alalek/gists{/gist_id}","starred_url":"https://api.github.com/users/alalek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alalek/subscriptions","organizations_url":"https://api.github.com/users/alalek/orgs","repos_url":"https://api.github.com/users/alalek/repos","events_url":"https://api.github.com/users/alalek/events{/privacy}","received_events_url":"https://api.github.com/users/alalek/received_events","type":"User","site_admin":false},"body":"Separate calls were done in assumption that actual usage rate of these flags is very low and we should minimize any overhead to \"normal\" work (code execution optimization).\r\n\r\nWhat should be done if some \"creation\" function is already have optional other argument?\r\nLike this: `UMat(int rows, int cols, int type, const Scalar& s = noScalar());`\r\nIf usage flag is a last optional argument, then user must specify all optional arguments before this. Is it a really comfortable way?","created_at":"2014-02-10T11:35:30Z","updated_at":"2014-02-10T11:35:30Z","html_url":"https://github.com/Itseez/opencv/pull/2195#discussion_r9580806","pull_request_url":"https://api.github.com/repos/Itseez/opencv/pulls/2195","_links":{"self":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/comments/9580806"},"html":{"href":"https://github.com/Itseez/opencv/pull/2195#discussion_r9580806"},"pull_request":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/2195"}}}}