GitHub PullRequestReviewCommentEvent at 2014-04-10 23:41:52
Repository: numpy
Actor: juliantaylor
Payload: {"comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/11511993","id":11511993,"diff_hunk":"@@ -55,65 +55,66 @@ cdef extern from \"randomkit.h\":\n     void rk_seed(unsigned long seed, rk_state *state)\n     rk_error rk_randomseed(rk_state *state)\n     unsigned long rk_random(rk_state *state)\n-    long rk_long(rk_state *state)\n+    long rk_long(rk_state *state) nogil","path":"numpy/random/mtrand/mtrand.pyx","position":5,"original_position":5,"commit_id":"e5c54f0948f5833d00d049681db1d3615832588b","original_commit_id":"e5c54f0948f5833d00d049681db1d3615832588b","user":{"login":"juliantaylor","id":542663,"avatar_url":"https://avatars.githubusercontent.com/u/542663?","gravatar_id":"bfe1a4e8db228cb9b7c023c8928ac0e2","url":"https://api.github.com/users/juliantaylor","html_url":"https://github.com/juliantaylor","followers_url":"https://api.github.com/users/juliantaylor/followers","following_url":"https://api.github.com/users/juliantaylor/following{/other_user}","gists_url":"https://api.github.com/users/juliantaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/juliantaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliantaylor/subscriptions","organizations_url":"https://api.github.com/users/juliantaylor/orgs","repos_url":"https://api.github.com/users/juliantaylor/repos","events_url":"https://api.github.com/users/juliantaylor/events{/privacy}","received_events_url":"https://api.github.com/users/juliantaylor/received_events","type":"User","site_admin":false},"body":"relies on nogil in a declaration only indicates the gil can be released, it does not release it when it is called.\r\ncython documentation says it behaves that way.","created_at":"2014-04-10T23:41:52Z","updated_at":"2014-04-10T23:41:52Z","html_url":"https://github.com/numpy/numpy/pull/4609#discussion_r11511993","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/4609","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/11511993"},"html":{"href":"https://github.com/numpy/numpy/pull/4609#discussion_r11511993"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/4609"}}}}