GitHub PullRequestReviewCommentEvent at 2014-12-23 23:00:51
Repository: esperanto
Actor: leebyron
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Rich-Harris/esperanto/pulls/comments/22239911","id":22239911,"diff_hunk":"@@ -1,10 +1,10 @@\n-define(['external'], function (external) {","path":"test/bundle/output/amdDefaults/3.js","position":1,"original_position":1,"commit_id":"b403dff3ba82091bbc71701a37995df0e868471f","original_commit_id":"b403dff3ba82091bbc71701a37995df0e868471f","user":{"login":"leebyron","id":50130,"avatar_url":"https://avatars.githubusercontent.com/u/50130?v=3","gravatar_id":"","url":"https://api.github.com/users/leebyron","html_url":"https://github.com/leebyron","followers_url":"https://api.github.com/users/leebyron/followers","following_url":"https://api.github.com/users/leebyron/following{/other_user}","gists_url":"https://api.github.com/users/leebyron/gists{/gist_id}","starred_url":"https://api.github.com/users/leebyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leebyron/subscriptions","organizations_url":"https://api.github.com/users/leebyron/orgs","repos_url":"https://api.github.com/users/leebyron/repos","events_url":"https://api.github.com/users/leebyron/events{/privacy}","received_events_url":"https://api.github.com/users/leebyron/received_events","type":"User","site_admin":false},"body":"Example of that bug. `external` is imported, but it's used as `external_default`","created_at":"2014-12-23T23:00:51Z","updated_at":"2014-12-23T23:00:51Z","html_url":"https://github.com/Rich-Harris/esperanto/pull/24#discussion_r22239911","pull_request_url":"https://api.github.com/repos/Rich-Harris/esperanto/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/Rich-Harris/esperanto/pulls/comments/22239911"},"html":{"href":"https://github.com/Rich-Harris/esperanto/pull/24#discussion_r22239911"},"pull_request":{"href":"https://api.github.com/repos/Rich-Harris/esperanto/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/Rich-Harris/esperanto/pulls/24","id":26536872,"html_url":"https://github.com/Rich-Harris/esperanto/pull/24","diff_url":"https://github.com/Rich-Harris/esperanto/pull/24.diff","patch_url":"https://github.com/Rich-Harris/esperanto/pull/24.patch","issue_url":"https://api.github.com/repos/Rich-Harris/esperanto/issues/24","number":24,"state":"open","locked":false,"title":"[RFC] Only alter Identifiers to avoid conflict.","user":{"login":"leebyron","id":50130,"avatar_url":"https://avatars.githubusercontent.com/u/50130?v=3","gravatar_id":"","url":"https://api.github.com/users/leebyron","html_url":"https://github.com/leebyron","followers_url":"https://api.github.com/users/leebyron/followers","following_url":"https://api.github.com/users/leebyron/following{/other_user}","gists_url":"https://api.github.com/users/leebyron/gists{/gist_id}","starred_url":"https://api.github.com/users/leebyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leebyron/subscriptions","organizations_url":"https://api.github.com/users/leebyron/orgs","repos_url":"https://api.github.com/users/leebyron/repos","events_url":"https://api.github.com/users/leebyron/events{/privacy}","received_events_url":"https://api.github.com/users/leebyron/received_events","type":"User","site_admin":false},"body":"This is just a request for consideration, so treat it as such. All tests pass, but that doesn't mean I haven't missed something important. Lookin' for feedback!\r\n\r\nThe concept here is to do as little modification as possible to the original source, only doing so to avoid conflicts within a scope.\r\n\r\nThis also fixes an issue where all of the top-level scope is accessible, regardless of being exported. It patches this issue by modifying the names of non-exported top-level Identifiers within a module. See added test which fails before this diff.","created_at":"2014-12-23T22:57:18Z","updated_at":"2014-12-23T23:00:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"505dd886457bfcaca20ab6ed9bbcd851f05748ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Rich-Harris/esperanto/pulls/24/commits","review_comments_url":"https://api.github.com/repos/Rich-Harris/esperanto/pulls/24/comments","review_comment_url":"https://api.github.com/repos/Rich-Harris/esperanto/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Rich-Harris/esperanto/issues/24/comments","statuses_url":"https://api.github.com/repos/Rich-Harris/esperanto/statuses/b403dff3ba82091bbc71701a37995df0e868471f","head":{"label":"leebyron:terse","ref":"terse","sha":"b403dff3ba82091bbc71701a37995df0e868471f","user":{"login":"leebyron","id":50130,"avatar_url":"https://avatars.githubusercontent.com/u/50130?v=3","gravatar_id":"","url":"https://api.github.com/users/leebyron","html_url":"https://github.com/leebyron","followers_url":"https://api.github.com/users/leebyron/followers","following_url":"https://api.github.com/users/leebyron/following{/other_user}","gists_url":"https://api.github.com/users/leebyron/gists{/gist_id}","starred_url":"https://api.github.com/users/leebyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leebyron/subscriptions","organizations_url":"https://api.github.com/users/leebyron/orgs","repos_url":"https://api.github.com/users/leebyron/repos","events_url":"https://api.github.com/users/leebyron/events{/privacy}","received_events_url":"https://api.github.com/users/leebyron/received_events","type":"User","site_admin":false},"repo":{"id":28376629,"name":"esperanto","full_name":"leebyron/esperanto","owner":{"login":"leebyron","id":50130,"avatar_url":"https://avatars.githubusercontent.com/u/50130?v=3","gravatar_id":"","url":"https://api.github.com/users/leebyron","html_url":"https://github.com/leebyron","followers_url":"https://api.github.com/users/leebyron/followers","following_url":"https://api.github.com/users/leebyron/following{/other_user}","gists_url":"https://api.github.com/users/leebyron/gists{/gist_id}","starred_url":"https://api.github.com/users/leebyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leebyron/subscriptions","organizations_url":"https://api.github.com/users/leebyron/orgs","repos_url":"https://api.github.com/users/leebyron/repos","events_url":"https://api.github.com/users/leebyron/events{/privacy}","received_events_url":"https://api.github.com/users/leebyron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leebyron/esperanto","description":"An easier way to convert ES6 modules to AMD and CommonJS","fork":true,"url":"https://api.github.com/repos/leebyron/esperanto","forks_url":"https://api.github.com/repos/leebyron/esperanto/forks","keys_url":"https://api.github.com/repos/leebyron/esperanto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leebyron/esperanto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leebyron/esperanto/teams","hooks_url":"https://api.github.com/repos/leebyron/esperanto/hooks","issue_events_url":"https://api.github.com/repos/leebyron/esperanto/issues/events{/number}","events_url":"https://api.github.com/repos/leebyron/esperanto/events","assignees_url":"https://api.github.com/repos/leebyron/esperanto/assignees{/user}","branches_url":"https://api.github.com/repos/leebyron/esperanto/branches{/branch}","tags_url":"https://api.github.com/repos/leebyron/esperanto/tags","blobs_url":"https://api.github.com/repos/leebyron/esperanto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leebyron/esperanto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leebyron/esperanto/git/refs{/sha}","trees_url":"https://api.github.com/repos/leebyron/esperanto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leebyron/esperanto/statuses/{sha}","languages_url":"https://api.github.com/repos/leebyron/esperanto/languages","stargazers_url":"https://api.github.com/repos/leebyron/esperanto/stargazers","contributors_url":"https://api.github.com/repos/leebyron/esperanto/contributors","subscribers_url":"https://api.github.com/repos/leebyron/esperanto/subscribers","subscription_url":"https://api.github.com/repos/leebyron/esperanto/subscription","commits_url":"https://api.github.com/repos/leebyron/esperanto/commits{/sha}","git_commits_url":"https://api.github.com/repos/leebyron/esperanto/git/commits{/sha}","comments_url":"https://api.github.com/repos/leebyron/esperanto/comments{/number}","issue_comment_url":"https://api.github.com/repos/leebyron/esperanto/issues/comments/{number}","contents_url":"https://api.github.com/repos/leebyron/esperanto/contents/{+path}","compare_url":"https://api.github.com/repos/leebyron/esperanto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leebyron/esperanto/merges","archive_url":"https://api.github.com/repos/leebyron/esperanto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leebyron/esperanto/downloads","issues_url":"https://api.github.com/repos/leebyron/esperanto/issues{/number}","pulls_url":"https://api.github.com/repos/leebyron/esperanto/pulls{/number}","milestones_url":"https://api.github.com/repos/leebyron/esperanto/milestones{/number}","notifications_url":"https://api.github.com/repos/leebyron/esperanto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leebyron/esperanto/labels{/name}","releases_url":"https://api.github.com/repos/leebyron/esperanto/releases{/id}","created_at":"2014-12-23T04:12:29Z","updated_at":"2014-12-23T22:50:31Z","pushed_at":"2014-12-23T22:56:08Z","git_url":"git://github.com/leebyron/esperanto.git","ssh_url":"git@github.com:leebyron/esperanto.git","clone_url":"https://github.com/leebyron/esperanto.git","svn_url":"https://github.com/leebyron/esperanto","homepage":"http://rich-harris.co.uk/esperanto","size":4603,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Rich-Harris:master","ref":"master","sha":"94b02684622af8ccec5fa5a9b94b1910ba2d1569","user":{"login":"Rich-Harris","id":1162160,"avatar_url":"https://avatars.githubusercontent.com/u/1162160?v=3","gravatar_id":"","url":"https://api.github.com/users/Rich-Harris","html_url":"https://github.com/Rich-Harris","followers_url":"https://api.github.com/users/Rich-Harris/followers","following_url":"https://api.github.com/users/Rich-Harris/following{/other_user}","gists_url":"https://api.github.com/users/Rich-Harris/gists{/gist_id}","starred_url":"https://api.github.com/users/Rich-Harris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rich-Harris/subscriptions","organizations_url":"https://api.github.com/users/Rich-Harris/orgs","repos_url":"https://api.github.com/users/Rich-Harris/repos","events_url":"https://api.github.com/users/Rich-Harris/events{/privacy}","received_events_url":"https://api.github.com/users/Rich-Harris/received_events","type":"User","site_admin":false},"repo":{"id":23025348,"name":"esperanto","full_name":"Rich-Harris/esperanto","owner":{"login":"Rich-Harris","id":1162160,"avatar_url":"https://avatars.githubusercontent.com/u/1162160?v=3","gravatar_id":"","url":"https://api.github.com/users/Rich-Harris","html_url":"https://github.com/Rich-Harris","followers_url":"https://api.github.com/users/Rich-Harris/followers","following_url":"https://api.github.com/users/Rich-Harris/following{/other_user}","gists_url":"https://api.github.com/users/Rich-Harris/gists{/gist_id}","starred_url":"https://api.github.com/users/Rich-Harris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rich-Harris/subscriptions","organizations_url":"https://api.github.com/users/Rich-Harris/orgs","repos_url":"https://api.github.com/users/Rich-Harris/repos","events_url":"https://api.github.com/users/Rich-Harris/events{/privacy}","received_events_url":"https://api.github.com/users/Rich-Harris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rich-Harris/esperanto","description":"An easier way to convert ES6 modules to AMD and CommonJS","fork":false,"url":"https://api.github.com/repos/Rich-Harris/esperanto","forks_url":"https://api.github.com/repos/Rich-Harris/esperanto/forks","keys_url":"https://api.github.com/repos/Rich-Harris/esperanto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rich-Harris/esperanto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rich-Harris/esperanto/teams","hooks_url":"https://api.github.com/repos/Rich-Harris/esperanto/hooks","issue_events_url":"https://api.github.com/repos/Rich-Harris/esperanto/issues/events{/number}","events_url":"https://api.github.com/repos/Rich-Harris/esperanto/events","assignees_url":"https://api.github.com/repos/Rich-Harris/esperanto/assignees{/user}","branches_url":"https://api.github.com/repos/Rich-Harris/esperanto/branches{/branch}","tags_url":"https://api.github.com/repos/Rich-Harris/esperanto/tags","blobs_url":"https://api.github.com/repos/Rich-Harris/esperanto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rich-Harris/esperanto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rich-Harris/esperanto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rich-Harris/esperanto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rich-Harris/esperanto/statuses/{sha}","languages_url":"https://api.github.com/repos/Rich-Harris/esperanto/languages","stargazers_url":"https://api.github.com/repos/Rich-Harris/esperanto/stargazers","contributors_url":"https://api.github.com/repos/Rich-Harris/esperanto/contributors","subscribers_url":"https://api.github.com/repos/Rich-Harris/esperanto/subscribers","subscription_url":"https://api.github.com/repos/Rich-Harris/esperanto/subscription","commits_url":"https://api.github.com/repos/Rich-Harris/esperanto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rich-Harris/esperanto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rich-Harris/esperanto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rich-Harris/esperanto/issues/comments/{number}","contents_url":"https://api.github.com/repos/Rich-Harris/esperanto/contents/{+path}","compare_url":"https://api.github.com/repos/Rich-Harris/esperanto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rich-Harris/esperanto/merges","archive_url":"https://api.github.com/repos/Rich-Harris/esperanto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rich-Harris/esperanto/downloads","issues_url":"https://api.github.com/repos/Rich-Harris/esperanto/issues{/number}","pulls_url":"https://api.github.com/repos/Rich-Harris/esperanto/pulls{/number}","milestones_url":"https://api.github.com/repos/Rich-Harris/esperanto/milestones{/number}","notifications_url":"https://api.github.com/repos/Rich-Harris/esperanto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rich-Harris/esperanto/labels{/name}","releases_url":"https://api.github.com/repos/Rich-Harris/esperanto/releases{/id}","created_at":"2014-08-16T19:24:21Z","updated_at":"2014-12-23T21:38:13Z","pushed_at":"2014-12-23T21:38:29Z","git_url":"git://github.com/Rich-Harris/esperanto.git","ssh_url":"git@github.com:Rich-Harris/esperanto.git","clone_url":"https://github.com/Rich-Harris/esperanto.git","svn_url":"https://github.com/Rich-Harris/esperanto","homepage":"http://rich-harris.co.uk/esperanto","size":4603,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rich-Harris/esperanto/pulls/24"},"html":{"href":"https://github.com/Rich-Harris/esperanto/pull/24"},"issue":{"href":"https://api.github.com/repos/Rich-Harris/esperanto/issues/24"},"comments":{"href":"https://api.github.com/repos/Rich-Harris/esperanto/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/Rich-Harris/esperanto/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/Rich-Harris/esperanto/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Rich-Harris/esperanto/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/Rich-Harris/esperanto/statuses/b403dff3ba82091bbc71701a37995df0e868471f"}}}}