GitHub PullRequestReviewCommentEvent at 2014-11-25 08:23:10
Repository: xbmc
Actor: ulion
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/20848464","id":20848464,"diff_hunk":"@@ -327,17 +328,26 @@ int64_t CDoubleCache::WaitForData(unsigned int iMinAvail, unsigned int iMillis)\n \n int64_t CDoubleCache::Seek(int64_t iFilePosition)\n {\n-  return m_pCache->Seek(iFilePosition);\n+  /* Check whether position is NOT in our current cache but IS in our old cache.\n+   * This is faster/more efficient than having to possibly wait for data in the\n+   * Seek() call below\n+   */\n+  if (!m_pCache->IsCachedPosition(iFilePosition) &&\n+       m_pCacheOld && m_pCacheOld->IsCachedPosition(iFilePosition))\n+  {\n+    return false; // Request seek event, so caches are swapped","path":"xbmc/filesystem/CacheStrategy.cpp","position":33,"original_position":33,"commit_id":"daaa7490e360c3539e252cf7f54b7628255cb253","original_commit_id":"daaa7490e360c3539e252cf7f54b7628255cb253","user":{"login":"ulion","id":175133,"avatar_url":"https://avatars.githubusercontent.com/u/175133?v=3","gravatar_id":"","url":"https://api.github.com/users/ulion","html_url":"https://github.com/ulion","followers_url":"https://api.github.com/users/ulion/followers","following_url":"https://api.github.com/users/ulion/following{/other_user}","gists_url":"https://api.github.com/users/ulion/gists{/gist_id}","starred_url":"https://api.github.com/users/ulion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulion/subscriptions","organizations_url":"https://api.github.com/users/ulion/orgs","repos_url":"https://api.github.com/users/ulion/repos","events_url":"https://api.github.com/users/ulion/events{/privacy}","received_events_url":"https://api.github.com/users/ulion/received_events","type":"User","site_admin":false},"body":"return CACHE_RC_ERROR","created_at":"2014-11-25T08:23:10Z","updated_at":"2014-11-25T08:23:10Z","html_url":"https://github.com/xbmc/xbmc/pull/5808#discussion_r20848464","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5808","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/20848464"},"html":{"href":"https://github.com/xbmc/xbmc/pull/5808#discussion_r20848464"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5808"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/5808","id":24987032,"html_url":"https://github.com/xbmc/xbmc/pull/5808","diff_url":"https://github.com/xbmc/xbmc/pull/5808.diff","patch_url":"https://github.com/xbmc/xbmc/pull/5808.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/5808","number":5808,"state":"open","locked":false,"title":"More double cache fixes","user":{"login":"arnova","id":544531,"avatar_url":"https://avatars.githubusercontent.com/u/544531?v=3","gravatar_id":"","url":"https://api.github.com/users/arnova","html_url":"https://github.com/arnova","followers_url":"https://api.github.com/users/arnova/followers","following_url":"https://api.github.com/users/arnova/following{/other_user}","gists_url":"https://api.github.com/users/arnova/gists{/gist_id}","starred_url":"https://api.github.com/users/arnova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnova/subscriptions","organizations_url":"https://api.github.com/users/arnova/orgs","repos_url":"https://api.github.com/users/arnova/repos","events_url":"https://api.github.com/users/arnova/events{/privacy}","received_events_url":"https://api.github.com/users/arnova/received_events","type":"User","site_admin":false},"body":"This PR fixes 2 remaining issues in our double cache implementation:\r\n1) Average calculation with heavy seeking/cache swapping doesn't work properly when the \"other\" cache is already (almost) full;\r\n2) We would wait for data although the position was already available in our other cache.","created_at":"2014-11-25T06:17:26Z","updated_at":"2014-11-25T08:23:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b38a8a54f6c48730111602ce91b1568f5b55fad3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5808/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5808/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/5808/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/daaa7490e360c3539e252cf7f54b7628255cb253","head":{"label":"arnova:average_fix","ref":"average_fix","sha":"daaa7490e360c3539e252cf7f54b7628255cb253","user":{"login":"arnova","id":544531,"avatar_url":"https://avatars.githubusercontent.com/u/544531?v=3","gravatar_id":"","url":"https://api.github.com/users/arnova","html_url":"https://github.com/arnova","followers_url":"https://api.github.com/users/arnova/followers","following_url":"https://api.github.com/users/arnova/following{/other_user}","gists_url":"https://api.github.com/users/arnova/gists{/gist_id}","starred_url":"https://api.github.com/users/arnova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnova/subscriptions","organizations_url":"https://api.github.com/users/arnova/orgs","repos_url":"https://api.github.com/users/arnova/repos","events_url":"https://api.github.com/users/arnova/events{/privacy}","received_events_url":"https://api.github.com/users/arnova/received_events","type":"User","site_admin":false},"repo":{"id":1396979,"name":"xbmc","full_name":"arnova/xbmc","owner":{"login":"arnova","id":544531,"avatar_url":"https://avatars.githubusercontent.com/u/544531?v=3","gravatar_id":"","url":"https://api.github.com/users/arnova","html_url":"https://github.com/arnova","followers_url":"https://api.github.com/users/arnova/followers","following_url":"https://api.github.com/users/arnova/following{/other_user}","gists_url":"https://api.github.com/users/arnova/gists{/gist_id}","starred_url":"https://api.github.com/users/arnova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnova/subscriptions","organizations_url":"https://api.github.com/users/arnova/orgs","repos_url":"https://api.github.com/users/arnova/repos","events_url":"https://api.github.com/users/arnova/events{/privacy}","received_events_url":"https://api.github.com/users/arnova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arnova/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/arnova/xbmc","forks_url":"https://api.github.com/repos/arnova/xbmc/forks","keys_url":"https://api.github.com/repos/arnova/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arnova/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arnova/xbmc/teams","hooks_url":"https://api.github.com/repos/arnova/xbmc/hooks","issue_events_url":"https://api.github.com/repos/arnova/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/arnova/xbmc/events","assignees_url":"https://api.github.com/repos/arnova/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/arnova/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/arnova/xbmc/tags","blobs_url":"https://api.github.com/repos/arnova/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arnova/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arnova/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/arnova/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arnova/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/arnova/xbmc/languages","stargazers_url":"https://api.github.com/repos/arnova/xbmc/stargazers","contributors_url":"https://api.github.com/repos/arnova/xbmc/contributors","subscribers_url":"https://api.github.com/repos/arnova/xbmc/subscribers","subscription_url":"https://api.github.com/repos/arnova/xbmc/subscription","commits_url":"https://api.github.com/repos/arnova/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/arnova/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/arnova/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/arnova/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/arnova/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/arnova/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arnova/xbmc/merges","archive_url":"https://api.github.com/repos/arnova/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arnova/xbmc/downloads","issues_url":"https://api.github.com/repos/arnova/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/arnova/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/arnova/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/arnova/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arnova/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/arnova/xbmc/releases{/id}","created_at":"2011-02-22T09:32:06Z","updated_at":"2014-11-23T20:36:16Z","pushed_at":"2014-11-24T06:40:39Z","git_url":"git://github.com/arnova/xbmc.git","ssh_url":"git@github.com:arnova/xbmc.git","clone_url":"https://github.com/arnova/xbmc.git","svn_url":"https://github.com/arnova/xbmc","homepage":"http://xbmc.org","size":478860,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"968c62470b4d947c72341a170ca4bb2865781d8b","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2014-11-24T20:44:31Z","pushed_at":"2014-11-24T20:44:30Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1803343,"stargazers_count":3473,"watchers_count":3473,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2479,"mirror_url":null,"open_issues_count":209,"forks":2479,"open_issues":209,"watchers":3473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5808"},"html":{"href":"https://github.com/xbmc/xbmc/pull/5808"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/5808"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/5808/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5808/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5808/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/daaa7490e360c3539e252cf7f54b7628255cb253"}}}}