GitHub PullRequestReviewCommentEvent at 2014-05-14 21:47:19
Repository: autotest-docker
Actor: cevich
Payload: {"comment":{"url":"https://api.github.com/repos/autotest/autotest-docker/pulls/comments/12663608","id":12663608,"diff_hunk":"@@ -261,25 +308,32 @@ def get(self, idx=None):\n                         except ValueError:\n                             pass\n                     else:\n-                        msg = (\"Check line not in docker output, signal \"\n-                               \"was probably not passed/handled properly.\"\n-                               \"\\nmissing: %s\\nstopped_log: %s\\n\"\n-                               \"docker_output: %s\"\n-                               % (line, stopped_log, container_out.get(_idx)))\n+                        msg = (\"Not all signals were handled inside container \"\n+                               \"after SIGCONT execution.\\nExpected output \"\n+                               \"(unordered):\\n  %s\\nActual container output:\\n\"\n+                               \"  %s\\nFirst missing line:\\n  %s\"\n+                               % (\"\\n  \".join([_check % sig\n+                                               for sig in stopped_log]),\n+                                  \"\\n  \".join(container_out.get(_idx)), line))","path":"subtests/docker_cli/kill/kill.py","position":206,"original_position":206,"commit_id":"23714a145144ae5f2846631da76d71b74d2ae236","original_commit_id":"23714a145144ae5f2846631da76d71b74d2ae236","user":{"login":"cevich","id":1183438,"avatar_url":"https://avatars.githubusercontent.com/u/1183438?","gravatar_id":"bf3380f4ce6270b075a9564bcd93006f","url":"https://api.github.com/users/cevich","html_url":"https://github.com/cevich","followers_url":"https://api.github.com/users/cevich/followers","following_url":"https://api.github.com/users/cevich/following{/other_user}","gists_url":"https://api.github.com/users/cevich/gists{/gist_id}","starred_url":"https://api.github.com/users/cevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cevich/subscriptions","organizations_url":"https://api.github.com/users/cevich/orgs","repos_url":"https://api.github.com/users/cevich/repos","events_url":"https://api.github.com/users/cevich/events{/privacy}","received_events_url":"https://api.github.com/users/cevich/received_events","type":"User","site_admin":false},"body":"I'll have to see what this actually renders like, but in general it looks much more verbose which is normally a good thing :smile: ","created_at":"2014-05-14T21:47:19Z","updated_at":"2014-05-14T21:47:19Z","html_url":"https://github.com/autotest/autotest-docker/pull/65#discussion_r12663608","pull_request_url":"https://api.github.com/repos/autotest/autotest-docker/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/comments/12663608"},"html":{"href":"https://github.com/autotest/autotest-docker/pull/65#discussion_r12663608"},"pull_request":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/65"}}}}