GitHub PullRequestReviewCommentEvent at 2014-01-24 15:01:21
Repository: fatfree
Actor: ikkez
Payload: {"comment":{"url":"https://api.github.com/repos/bcosca/fatfree/pulls/comments/9150313","id":9150313,"diff_hunk":"@@ -188,8 +188,10 @@ function($var) use($fw) {\n \t\t\t\treturn '$'.preg_replace_callback(\n \t\t\t\t\t'/\\.(\\w+)|\\[((?:[^\\[\\]]*|(?R))*)\\]/',\n \t\t\t\t\tfunction($expr) use($fw) {\n-\t\t\t\t\t\treturn '['.var_export($expr[1]?:","path":"lib/base.php","position":4,"original_position":4,"commit_id":"4e6a2c928adadfa325acb89747a28d9e55948e3d","original_commit_id":"4e6a2c928adadfa325acb89747a28d9e55948e3d","user":{"login":"ikkez","id":1177647,"avatar_url":"https://gravatar.com/avatar/e367a56e42ba13e5972e0d66a7c2b821?d=https%3A%2F%2Fidenticons.github.com%2Fb86918a57d95a2f783409f7b6c156841.png&r=x","gravatar_id":"e367a56e42ba13e5972e0d66a7c2b821","url":"https://api.github.com/users/ikkez","html_url":"https://github.com/ikkez","followers_url":"https://api.github.com/users/ikkez/followers","following_url":"https://api.github.com/users/ikkez/following{/other_user}","gists_url":"https://api.github.com/users/ikkez/gists{/gist_id}","starred_url":"https://api.github.com/users/ikkez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikkez/subscriptions","organizations_url":"https://api.github.com/users/ikkez/orgs","repos_url":"https://api.github.com/users/ikkez/repos","events_url":"https://api.github.com/users/ikkez/events{/privacy}","received_events_url":"https://api.github.com/users/ikkez/received_events","type":"User","site_admin":false},"body":"the problem was that this ternary `$expr[1]?:` evalutated a `0` char as false.","created_at":"2014-01-24T15:01:21Z","updated_at":"2014-01-24T15:01:21Z","html_url":"https://github.com/bcosca/fatfree/pull/537#discussion_r9150313","pull_request_url":"https://api.github.com/repos/bcosca/fatfree/pulls/537","_links":{"self":{"href":"https://api.github.com/repos/bcosca/fatfree/pulls/comments/9150313"},"html":{"href":"https://github.com/bcosca/fatfree/pull/537#discussion_r9150313"},"pull_request":{"href":"https://api.github.com/repos/bcosca/fatfree/pulls/537"}}}}