GitHub PullRequestReviewCommentEvent at 2014-07-01 21:41:20
Repository: incubator-parquet-mr
Actor: jcoveney
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/comments/14430562","id":14430562,"diff_hunk":"@@ -0,0 +1,70 @@\n+package parquet.hadoop.util;\n+\n+import java.io.ByteArrayInputStream;\n+import java.io.ByteArrayOutputStream;\n+import java.io.IOException;\n+import java.io.ObjectInputStream;\n+import java.io.ObjectOutputStream;\n+\n+import org.apache.commons.codec.binary.Base64;\n+import org.apache.hadoop.conf.Configuration;\n+\n+import parquet.Log;\n+\n+/**\n+ * Serialization utils copied from:\n+ * https://github.com/kevinweil/elephant-bird/blob/master/core/src/main/java/com/twitter/elephantbird/util/HadoopUtils.java\n+ *\n+ * TODO(alexlevenson): Should we depend on elephant-bird or just copy here?","path":"parquet-hadoop/src/main/java/parquet/hadoop/util/SerializationUtil.java","position":18,"original_position":18,"commit_id":"fd6f44d6b788c9525973460c215c3f342aef3729","original_commit_id":"2fdd3049b32cb1ff0f038696c6870d3fdec3f9c4","user":{"login":"jcoveney","id":830087,"avatar_url":"https://avatars.githubusercontent.com/u/830087?","gravatar_id":"c31517bb2497ca20710a294d3f8d1144","url":"https://api.github.com/users/jcoveney","html_url":"https://github.com/jcoveney","followers_url":"https://api.github.com/users/jcoveney/followers","following_url":"https://api.github.com/users/jcoveney/following{/other_user}","gists_url":"https://api.github.com/users/jcoveney/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoveney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoveney/subscriptions","organizations_url":"https://api.github.com/users/jcoveney/orgs","repos_url":"https://api.github.com/users/jcoveney/repos","events_url":"https://api.github.com/users/jcoveney/events{/privacy}","received_events_url":"https://api.github.com/users/jcoveney/received_events","type":"User","site_admin":false},"body":"Also we are due for a 4.6 release of EB so this would be the time to do it...\r\n\r\nbut I'm fine copying it in just to have on less dep.","created_at":"2014-07-01T21:41:20Z","updated_at":"2014-07-01T21:41:20Z","html_url":"https://github.com/apache/incubator-parquet-mr/pull/4#discussion_r14430562","pull_request_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/comments/14430562"},"html":{"href":"https://github.com/apache/incubator-parquet-mr/pull/4#discussion_r14430562"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/4","id":17369471,"html_url":"https://github.com/apache/incubator-parquet-mr/pull/4","diff_url":"https://github.com/apache/incubator-parquet-mr/pull/4.diff","patch_url":"https://github.com/apache/incubator-parquet-mr/pull/4.patch","issue_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/4","number":4,"state":"open","title":"Add a unified and optionally more constrained API for expressing filters on columns","user":{"login":"isnotinvain","id":372969,"avatar_url":"https://avatars.githubusercontent.com/u/372969?","gravatar_id":"ce1901ee007b8cd46c0a03bd87f29b56","url":"https://api.github.com/users/isnotinvain","html_url":"https://github.com/isnotinvain","followers_url":"https://api.github.com/users/isnotinvain/followers","following_url":"https://api.github.com/users/isnotinvain/following{/other_user}","gists_url":"https://api.github.com/users/isnotinvain/gists{/gist_id}","starred_url":"https://api.github.com/users/isnotinvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnotinvain/subscriptions","organizations_url":"https://api.github.com/users/isnotinvain/orgs","repos_url":"https://api.github.com/users/isnotinvain/repos","events_url":"https://api.github.com/users/isnotinvain/events{/privacy}","received_events_url":"https://api.github.com/users/isnotinvain/received_events","type":"User","site_admin":false},"body":"This is a re-opened version of:\r\nhttps://github.com/Parquet/parquet-mr/pull/412\r\n\r\nThe idea behind this pull request is to add a way to express filters on columns using DSL that allows parquet visibility into what is being filtered and how. This visibility will allow us to make optimizations at read time, the biggest one being filtering entire row groups or pages of records without even reading them based on the statistics / metadata that is stored along with each row group or page.\r\n\r\nIncluded in this api are interfaces for user defined predicates, which must operate at the value level by may opt in to operating at the row group / page level as well. This should make this new API a superset of the `parquet.filter` package. This new api will need to be reconciled with the column filters currently in the `parquet.filter` package, but I wanted to get feedback on this first.\r\n\r\nA limitation in both this api and the old one is that you can't do cross-column filters, eg: columX > columnY.","created_at":"2014-06-19T19:01:50Z","updated_at":"2014-07-01T21:41:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"530daddfb4216e21d354ac56f064f90f544ff122","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/4/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/4/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/4/comments","statuses_url":"https://api.github.com/repos/apache/incubator-parquet-mr/statuses/fd6f44d6b788c9525973460c215c3f342aef3729","head":{"label":"isnotinvain:alexlevenson/filter-api","ref":"alexlevenson/filter-api","sha":"fd6f44d6b788c9525973460c215c3f342aef3729","user":{"login":"isnotinvain","id":372969,"avatar_url":"https://avatars.githubusercontent.com/u/372969?","gravatar_id":"ce1901ee007b8cd46c0a03bd87f29b56","url":"https://api.github.com/users/isnotinvain","html_url":"https://github.com/isnotinvain","followers_url":"https://api.github.com/users/isnotinvain/followers","following_url":"https://api.github.com/users/isnotinvain/following{/other_user}","gists_url":"https://api.github.com/users/isnotinvain/gists{/gist_id}","starred_url":"https://api.github.com/users/isnotinvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnotinvain/subscriptions","organizations_url":"https://api.github.com/users/isnotinvain/orgs","repos_url":"https://api.github.com/users/isnotinvain/repos","events_url":"https://api.github.com/users/isnotinvain/events{/privacy}","received_events_url":"https://api.github.com/users/isnotinvain/received_events","type":"User","site_admin":false},"repo":{"id":21011791,"name":"incubator-parquet-mr","full_name":"isnotinvain/incubator-parquet-mr","owner":{"login":"isnotinvain","id":372969,"avatar_url":"https://avatars.githubusercontent.com/u/372969?","gravatar_id":"ce1901ee007b8cd46c0a03bd87f29b56","url":"https://api.github.com/users/isnotinvain","html_url":"https://github.com/isnotinvain","followers_url":"https://api.github.com/users/isnotinvain/followers","following_url":"https://api.github.com/users/isnotinvain/following{/other_user}","gists_url":"https://api.github.com/users/isnotinvain/gists{/gist_id}","starred_url":"https://api.github.com/users/isnotinvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnotinvain/subscriptions","organizations_url":"https://api.github.com/users/isnotinvain/orgs","repos_url":"https://api.github.com/users/isnotinvain/repos","events_url":"https://api.github.com/users/isnotinvain/events{/privacy}","received_events_url":"https://api.github.com/users/isnotinvain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isnotinvain/incubator-parquet-mr","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr","forks_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/forks","keys_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/teams","hooks_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/events","assignees_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/tags","blobs_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/languages","stargazers_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/subscription","commits_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/issues/comments/{number}","contents_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/merges","archive_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/downloads","issues_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/releases{/id}","created_at":"2014-06-19T18:55:45Z","updated_at":"2014-06-27T21:26:05Z","pushed_at":"2014-07-01T19:18:45Z","git_url":"git://github.com/isnotinvain/incubator-parquet-mr.git","ssh_url":"git@github.com:isnotinvain/incubator-parquet-mr.git","clone_url":"https://github.com/isnotinvain/incubator-parquet-mr.git","svn_url":"https://github.com/isnotinvain/incubator-parquet-mr","homepage":null,"size":11411,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9ad5485c3310a8c51510ea50e24834b6cf98c45c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675636,"name":"incubator-parquet-mr","full_name":"apache/incubator-parquet-mr","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-parquet-mr","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/incubator-parquet-mr","forks_url":"https://api.github.com/repos/apache/incubator-parquet-mr/forks","keys_url":"https://api.github.com/repos/apache/incubator-parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-parquet-mr/teams","hooks_url":"https://api.github.com/repos/apache/incubator-parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-parquet-mr/events","assignees_url":"https://api.github.com/repos/apache/incubator-parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-parquet-mr/tags","blobs_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-parquet-mr/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-parquet-mr/subscription","commits_url":"https://api.github.com/repos/apache/incubator-parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/incubator-parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-parquet-mr/merges","archive_url":"https://api.github.com/repos/apache/incubator-parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-parquet-mr/downloads","issues_url":"https://api.github.com/repos/apache/incubator-parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-parquet-mr/releases{/id}","created_at":"2014-06-10T07:00:07Z","updated_at":"2014-06-26T13:19:07Z","pushed_at":"2014-06-24T17:20:07Z","git_url":"git://github.com/apache/incubator-parquet-mr.git","ssh_url":"git@github.com:apache/incubator-parquet-mr.git","clone_url":"https://github.com/apache/incubator-parquet-mr.git","svn_url":"https://github.com/apache/incubator-parquet-mr","homepage":null,"size":61866,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":11,"mirror_url":"git://git.apache.org/incubator-parquet-mr.git","open_issues_count":7,"forks":11,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/4"},"html":{"href":"https://github.com/apache/incubator-parquet-mr/pull/4"},"issue":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/4"},"comments":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-parquet-mr/statuses/fd6f44d6b788c9525973460c215c3f342aef3729"}}}}