GitHub PullRequestEvent at 2014-02-12 16:10:25
Repository: kuma
Actor: darkwing
Payload: {"action":"closed","number":1884,"pull_request":{"url":"https://api.github.com/repos/mozilla/kuma/pulls/1884","id":11549268,"html_url":"https://github.com/mozilla/kuma/pull/1884","diff_url":"https://github.com/mozilla/kuma/pull/1884.diff","patch_url":"https://github.com/mozilla/kuma/pull/1884.patch","issue_url":"https://api.github.com/repos/mozilla/kuma/issues/1884","number":1884,"state":"closed","title":"Fix bug 949988 - Close button for navigation submenus on Mobile devices","user":{"login":"iakshay","id":1104602,"avatar_url":"https://gravatar.com/avatar/82cf9a87a747f31d266859823a2e5b71?d=https%3A%2F%2Fidenticons.github.com%2Fc6c7b2b4e784511c4ccca98481e9ba6f.png&r=x","gravatar_id":"82cf9a87a747f31d266859823a2e5b71","url":"https://api.github.com/users/iakshay","html_url":"https://github.com/iakshay","followers_url":"https://api.github.com/users/iakshay/followers","following_url":"https://api.github.com/users/iakshay/following{/other_user}","gists_url":"https://api.github.com/users/iakshay/gists{/gist_id}","starred_url":"https://api.github.com/users/iakshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iakshay/subscriptions","organizations_url":"https://api.github.com/users/iakshay/orgs","repos_url":"https://api.github.com/users/iakshay/repos","events_url":"https://api.github.com/users/iakshay/events{/privacy}","received_events_url":"https://api.github.com/users/iakshay/received_events","type":"User","site_admin":false},"body":"Adding close button on submenus for mobile devices.\r\n\r\nI tried to implement click outside (.submenu) for closing submenu, but that would prevent event propagation to close button. So couldn't get both working together. Any suggestions to improve this would be great!","created_at":"2014-01-15T19:33:58Z","updated_at":"2014-02-12T16:10:24Z","closed_at":"2014-02-12T16:10:24Z","merged_at":"2014-02-12T16:10:24Z","merge_commit_sha":"0c84c11a73b3e1ab826cf12c9720420a258b7989","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/kuma/pulls/1884/commits","review_comments_url":"https://api.github.com/repos/mozilla/kuma/pulls/1884/comments","review_comment_url":"https://api.github.com/repos/mozilla/kuma/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/kuma/issues/1884/comments","statuses_url":"https://api.github.com/repos/mozilla/kuma/statuses/35bf67f5be10348623f7751a087e61154e4514d5","head":{"label":"iakshay:bug-949988","ref":"bug-949988","sha":"35bf67f5be10348623f7751a087e61154e4514d5","user":{"login":"iakshay","id":1104602,"avatar_url":"https://gravatar.com/avatar/82cf9a87a747f31d266859823a2e5b71?d=https%3A%2F%2Fidenticons.github.com%2Fc6c7b2b4e784511c4ccca98481e9ba6f.png&r=x","gravatar_id":"82cf9a87a747f31d266859823a2e5b71","url":"https://api.github.com/users/iakshay","html_url":"https://github.com/iakshay","followers_url":"https://api.github.com/users/iakshay/followers","following_url":"https://api.github.com/users/iakshay/following{/other_user}","gists_url":"https://api.github.com/users/iakshay/gists{/gist_id}","starred_url":"https://api.github.com/users/iakshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iakshay/subscriptions","organizations_url":"https://api.github.com/users/iakshay/orgs","repos_url":"https://api.github.com/users/iakshay/repos","events_url":"https://api.github.com/users/iakshay/events{/privacy}","received_events_url":"https://api.github.com/users/iakshay/received_events","type":"User","site_admin":false},"repo":{"id":8940556,"name":"kuma","full_name":"iakshay/kuma","owner":{"login":"iakshay","id":1104602,"avatar_url":"https://gravatar.com/avatar/82cf9a87a747f31d266859823a2e5b71?d=https%3A%2F%2Fidenticons.github.com%2Fc6c7b2b4e784511c4ccca98481e9ba6f.png&r=x","gravatar_id":"82cf9a87a747f31d266859823a2e5b71","url":"https://api.github.com/users/iakshay","html_url":"https://github.com/iakshay","followers_url":"https://api.github.com/users/iakshay/followers","following_url":"https://api.github.com/users/iakshay/following{/other_user}","gists_url":"https://api.github.com/users/iakshay/gists{/gist_id}","starred_url":"https://api.github.com/users/iakshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iakshay/subscriptions","organizations_url":"https://api.github.com/users/iakshay/orgs","repos_url":"https://api.github.com/users/iakshay/repos","events_url":"https://api.github.com/users/iakshay/events{/privacy}","received_events_url":"https://api.github.com/users/iakshay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iakshay/kuma","description":"The django code that powers MDN.","fork":true,"url":"https://api.github.com/repos/iakshay/kuma","forks_url":"https://api.github.com/repos/iakshay/kuma/forks","keys_url":"https://api.github.com/repos/iakshay/kuma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iakshay/kuma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iakshay/kuma/teams","hooks_url":"https://api.github.com/repos/iakshay/kuma/hooks","issue_events_url":"https://api.github.com/repos/iakshay/kuma/issues/events{/number}","events_url":"https://api.github.com/repos/iakshay/kuma/events","assignees_url":"https://api.github.com/repos/iakshay/kuma/assignees{/user}","branches_url":"https://api.github.com/repos/iakshay/kuma/branches{/branch}","tags_url":"https://api.github.com/repos/iakshay/kuma/tags","blobs_url":"https://api.github.com/repos/iakshay/kuma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iakshay/kuma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iakshay/kuma/git/refs{/sha}","trees_url":"https://api.github.com/repos/iakshay/kuma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iakshay/kuma/statuses/{sha}","languages_url":"https://api.github.com/repos/iakshay/kuma/languages","stargazers_url":"https://api.github.com/repos/iakshay/kuma/stargazers","contributors_url":"https://api.github.com/repos/iakshay/kuma/contributors","subscribers_url":"https://api.github.com/repos/iakshay/kuma/subscribers","subscription_url":"https://api.github.com/repos/iakshay/kuma/subscription","commits_url":"https://api.github.com/repos/iakshay/kuma/commits{/sha}","git_commits_url":"https://api.github.com/repos/iakshay/kuma/git/commits{/sha}","comments_url":"https://api.github.com/repos/iakshay/kuma/comments{/number}","issue_comment_url":"https://api.github.com/repos/iakshay/kuma/issues/comments/{number}","contents_url":"https://api.github.com/repos/iakshay/kuma/contents/{+path}","compare_url":"https://api.github.com/repos/iakshay/kuma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iakshay/kuma/merges","archive_url":"https://api.github.com/repos/iakshay/kuma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iakshay/kuma/downloads","issues_url":"https://api.github.com/repos/iakshay/kuma/issues{/number}","pulls_url":"https://api.github.com/repos/iakshay/kuma/pulls{/number}","milestones_url":"https://api.github.com/repos/iakshay/kuma/milestones{/number}","notifications_url":"https://api.github.com/repos/iakshay/kuma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iakshay/kuma/labels{/name}","releases_url":"https://api.github.com/repos/iakshay/kuma/releases{/id}","created_at":"2013-03-21T23:02:18Z","updated_at":"2014-02-12T16:10:24Z","pushed_at":"2014-02-12T08:12:02Z","git_url":"git://github.com/iakshay/kuma.git","ssh_url":"git@github.com:iakshay/kuma.git","clone_url":"https://github.com/iakshay/kuma.git","svn_url":"https://github.com/iakshay/kuma","homepage":"https://developer.mozilla.org","size":30047,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"8b3a32bd57b1b1fa6db6ebe065cf657b04264529","user":{"login":"mozilla","id":131524,"avatar_url":"https://gravatar.com/avatar/9ba739c8f3288e256b13553e4d257b5e?d=https%3A%2F%2Fidenticons.github.com%2Fe19b38694c8cd24cb8a5ff704c8d9ae1.png&r=x","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1352520,"name":"kuma","full_name":"mozilla/kuma","owner":{"login":"mozilla","id":131524,"avatar_url":"https://gravatar.com/avatar/9ba739c8f3288e256b13553e4d257b5e?d=https%3A%2F%2Fidenticons.github.com%2Fe19b38694c8cd24cb8a5ff704c8d9ae1.png&r=x","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/kuma","description":"The Django project that powers MDN.","fork":false,"url":"https://api.github.com/repos/mozilla/kuma","forks_url":"https://api.github.com/repos/mozilla/kuma/forks","keys_url":"https://api.github.com/repos/mozilla/kuma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/kuma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/kuma/teams","hooks_url":"https://api.github.com/repos/mozilla/kuma/hooks","issue_events_url":"https://api.github.com/repos/mozilla/kuma/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/kuma/events","assignees_url":"https://api.github.com/repos/mozilla/kuma/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/kuma/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/kuma/tags","blobs_url":"https://api.github.com/repos/mozilla/kuma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/kuma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/kuma/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/kuma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/kuma/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/kuma/languages","stargazers_url":"https://api.github.com/repos/mozilla/kuma/stargazers","contributors_url":"https://api.github.com/repos/mozilla/kuma/contributors","subscribers_url":"https://api.github.com/repos/mozilla/kuma/subscribers","subscription_url":"https://api.github.com/repos/mozilla/kuma/subscription","commits_url":"https://api.github.com/repos/mozilla/kuma/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/kuma/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/kuma/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/kuma/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/kuma/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/kuma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/kuma/merges","archive_url":"https://api.github.com/repos/mozilla/kuma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/kuma/downloads","issues_url":"https://api.github.com/repos/mozilla/kuma/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/kuma/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/kuma/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/kuma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/kuma/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/kuma/releases{/id}","created_at":"2011-02-10T21:48:06Z","updated_at":"2014-02-12T16:10:24Z","pushed_at":"2014-02-12T16:10:24Z","git_url":"git://github.com/mozilla/kuma.git","ssh_url":"git@github.com:mozilla/kuma.git","clone_url":"https://github.com/mozilla/kuma.git","svn_url":"https://github.com/mozilla/kuma","homepage":"https://developer.mozilla.org","size":40610,"stargazers_count":361,"watchers_count":361,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":197,"mirror_url":null,"open_issues_count":58,"forks":197,"open_issues":58,"watchers":361,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/kuma/pulls/1884"},"html":{"href":"https://github.com/mozilla/kuma/pull/1884"},"issue":{"href":"https://api.github.com/repos/mozilla/kuma/issues/1884"},"comments":{"href":"https://api.github.com/repos/mozilla/kuma/issues/1884/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/kuma/pulls/1884/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/kuma/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/kuma/pulls/1884/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/kuma/statuses/35bf67f5be10348623f7751a087e61154e4514d5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"darkwing","id":46655,"avatar_url":"https://gravatar.com/avatar/e15d8725aa42ce94ff509dd9136284d8?d=https%3A%2F%2Fidenticons.github.com%2Fb5c4def0db8bdcb481f749eea434371c.png&r=x","gravatar_id":"e15d8725aa42ce94ff509dd9136284d8","url":"https://api.github.com/users/darkwing","html_url":"https://github.com/darkwing","followers_url":"https://api.github.com/users/darkwing/followers","following_url":"https://api.github.com/users/darkwing/following{/other_user}","gists_url":"https://api.github.com/users/darkwing/gists{/gist_id}","starred_url":"https://api.github.com/users/darkwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkwing/subscriptions","organizations_url":"https://api.github.com/users/darkwing/orgs","repos_url":"https://api.github.com/users/darkwing/repos","events_url":"https://api.github.com/users/darkwing/events{/privacy}","received_events_url":"https://api.github.com/users/darkwing/received_events","type":"User","site_admin":false},"comments":22,"review_comments":3,"commits":1,"additions":29,"deletions":4,"changed_files":4}}