GitHub PullRequestEvent at 2014-08-12 02:30:16
Repository: 24pullrequests
Actor: andrew
Payload: {"action":"closed","number":574,"pull_request":{"url":"https://api.github.com/repos/24pullrequests/24pullrequests/pulls/574","id":10956438,"html_url":"https://github.com/24pullrequests/24pullrequests/pull/574","diff_url":"https://github.com/24pullrequests/24pullrequests/pull/574.diff","patch_url":"https://github.com/24pullrequests/24pullrequests/pull/574.patch","issue_url":"https://api.github.com/repos/24pullrequests/24pullrequests/issues/574","number":574,"state":"closed","title":"Update gift dropdown after pull requests sync","user":{"login":"rowanhill","id":2607287,"avatar_url":"https://avatars.githubusercontent.com/u/2607287?v=2","gravatar_id":"1f45e4b3f6dd09649623b3c732090c3c","url":"https://api.github.com/users/rowanhill","html_url":"https://github.com/rowanhill","followers_url":"https://api.github.com/users/rowanhill/followers","following_url":"https://api.github.com/users/rowanhill/following{/other_user}","gists_url":"https://api.github.com/users/rowanhill/gists{/gist_id}","starred_url":"https://api.github.com/users/rowanhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowanhill/subscriptions","organizations_url":"https://api.github.com/users/rowanhill/orgs","repos_url":"https://api.github.com/users/rowanhill/repos","events_url":"https://api.github.com/users/rowanhill/events{/privacy}","received_events_url":"https://api.github.com/users/rowanhill/received_events","type":"User","site_admin":false},"body":"This is a fix for issue #567 (by adding some data-attributes to the .pull_request elements and using that data to populate the dropdown after a sync) - but I'm not happy with it!\r\n\r\nThe big problem with it is the #TODO in the dashboard_spec.rb: there's a sleep in there, because I can't seem to convince Capybara to wait for the spinner to disappear. I'm pretty rusty with Rails, though, so I'm sure I'm just missing something obvious - can anyone point me in the right direction? I'll very happily update this PR if so.\r\n\r\nAs the comment says, I've tried `page.find('#spinner', visible: false)`, but that doesn't appear to introduce a wait at all. I thought this might be because the find was executing before the spinner had been shown, but searching for visible:true followed by visible:false didn't seem to wait, either. I've tried various other things (e.g. `page.should have_selector('#spinner', visible:false)`, `page.find('#spinner').should_not be_visible`) but all without success.\r\n\r\nAs I say, any pointers gratefully received!\r\n\r\nThanks,\r\nRowan","created_at":"2013-12-18T23:18:39Z","updated_at":"2014-08-12T02:30:15Z","closed_at":"2014-08-12T02:30:15Z","merged_at":null,"merge_commit_sha":"d4e0581402f727e7b41fb193b2092dde838eb2dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/24pullrequests/24pullrequests/pulls/574/commits","review_comments_url":"https://api.github.com/repos/24pullrequests/24pullrequests/pulls/574/comments","review_comment_url":"https://api.github.com/repos/24pullrequests/24pullrequests/pulls/comments/{number}","comments_url":"https://api.github.com/repos/24pullrequests/24pullrequests/issues/574/comments","statuses_url":"https://api.github.com/repos/24pullrequests/24pullrequests/statuses/2f30a7bbf51457ece0228e30507817fde241d6b4","head":{"label":"rowanhill:update-gift-dropdown-on-sync","ref":"update-gift-dropdown-on-sync","sha":"2f30a7bbf51457ece0228e30507817fde241d6b4","user":{"login":"rowanhill","id":2607287,"avatar_url":"https://avatars.githubusercontent.com/u/2607287?v=2","gravatar_id":"1f45e4b3f6dd09649623b3c732090c3c","url":"https://api.github.com/users/rowanhill","html_url":"https://github.com/rowanhill","followers_url":"https://api.github.com/users/rowanhill/followers","following_url":"https://api.github.com/users/rowanhill/following{/other_user}","gists_url":"https://api.github.com/users/rowanhill/gists{/gist_id}","starred_url":"https://api.github.com/users/rowanhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowanhill/subscriptions","organizations_url":"https://api.github.com/users/rowanhill/orgs","repos_url":"https://api.github.com/users/rowanhill/repos","events_url":"https://api.github.com/users/rowanhill/events{/privacy}","received_events_url":"https://api.github.com/users/rowanhill/received_events","type":"User","site_admin":false},"repo":{"id":15296321,"name":"24pullrequests","full_name":"rowanhill/24pullrequests","owner":{"login":"rowanhill","id":2607287,"avatar_url":"https://avatars.githubusercontent.com/u/2607287?v=2","gravatar_id":"1f45e4b3f6dd09649623b3c732090c3c","url":"https://api.github.com/users/rowanhill","html_url":"https://github.com/rowanhill","followers_url":"https://api.github.com/users/rowanhill/followers","following_url":"https://api.github.com/users/rowanhill/following{/other_user}","gists_url":"https://api.github.com/users/rowanhill/gists{/gist_id}","starred_url":"https://api.github.com/users/rowanhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowanhill/subscriptions","organizations_url":"https://api.github.com/users/rowanhill/orgs","repos_url":"https://api.github.com/users/rowanhill/repos","events_url":"https://api.github.com/users/rowanhill/events{/privacy}","received_events_url":"https://api.github.com/users/rowanhill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rowanhill/24pullrequests","description":"Giving back little gifts of code for Christmas","fork":true,"url":"https://api.github.com/repos/rowanhill/24pullrequests","forks_url":"https://api.github.com/repos/rowanhill/24pullrequests/forks","keys_url":"https://api.github.com/repos/rowanhill/24pullrequests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rowanhill/24pullrequests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rowanhill/24pullrequests/teams","hooks_url":"https://api.github.com/repos/rowanhill/24pullrequests/hooks","issue_events_url":"https://api.github.com/repos/rowanhill/24pullrequests/issues/events{/number}","events_url":"https://api.github.com/repos/rowanhill/24pullrequests/events","assignees_url":"https://api.github.com/repos/rowanhill/24pullrequests/assignees{/user}","branches_url":"https://api.github.com/repos/rowanhill/24pullrequests/branches{/branch}","tags_url":"https://api.github.com/repos/rowanhill/24pullrequests/tags","blobs_url":"https://api.github.com/repos/rowanhill/24pullrequests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rowanhill/24pullrequests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rowanhill/24pullrequests/git/refs{/sha}","trees_url":"https://api.github.com/repos/rowanhill/24pullrequests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rowanhill/24pullrequests/statuses/{sha}","languages_url":"https://api.github.com/repos/rowanhill/24pullrequests/languages","stargazers_url":"https://api.github.com/repos/rowanhill/24pullrequests/stargazers","contributors_url":"https://api.github.com/repos/rowanhill/24pullrequests/contributors","subscribers_url":"https://api.github.com/repos/rowanhill/24pullrequests/subscribers","subscription_url":"https://api.github.com/repos/rowanhill/24pullrequests/subscription","commits_url":"https://api.github.com/repos/rowanhill/24pullrequests/commits{/sha}","git_commits_url":"https://api.github.com/repos/rowanhill/24pullrequests/git/commits{/sha}","comments_url":"https://api.github.com/repos/rowanhill/24pullrequests/comments{/number}","issue_comment_url":"https://api.github.com/repos/rowanhill/24pullrequests/issues/comments/{number}","contents_url":"https://api.github.com/repos/rowanhill/24pullrequests/contents/{+path}","compare_url":"https://api.github.com/repos/rowanhill/24pullrequests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rowanhill/24pullrequests/merges","archive_url":"https://api.github.com/repos/rowanhill/24pullrequests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rowanhill/24pullrequests/downloads","issues_url":"https://api.github.com/repos/rowanhill/24pullrequests/issues{/number}","pulls_url":"https://api.github.com/repos/rowanhill/24pullrequests/pulls{/number}","milestones_url":"https://api.github.com/repos/rowanhill/24pullrequests/milestones{/number}","notifications_url":"https://api.github.com/repos/rowanhill/24pullrequests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rowanhill/24pullrequests/labels{/name}","releases_url":"https://api.github.com/repos/rowanhill/24pullrequests/releases{/id}","created_at":"2013-12-18T22:56:46Z","updated_at":"2014-06-28T09:40:21Z","pushed_at":"2013-12-26T10:29:05Z","git_url":"git://github.com/rowanhill/24pullrequests.git","ssh_url":"git@github.com:rowanhill/24pullrequests.git","clone_url":"https://github.com/rowanhill/24pullrequests.git","svn_url":"https://github.com/rowanhill/24pullrequests","homepage":"http://24pullrequests.com/","size":5687,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"24pullrequests:master","ref":"master","sha":"dc9832df118ce2fa11b83c930e70d9b63b6be0c1","user":{"login":"24pullrequests","id":7920922,"avatar_url":"https://avatars.githubusercontent.com/u/7920922?v=2","gravatar_id":null,"url":"https://api.github.com/users/24pullrequests","html_url":"https://github.com/24pullrequests","followers_url":"https://api.github.com/users/24pullrequests/followers","following_url":"https://api.github.com/users/24pullrequests/following{/other_user}","gists_url":"https://api.github.com/users/24pullrequests/gists{/gist_id}","starred_url":"https://api.github.com/users/24pullrequests/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/24pullrequests/subscriptions","organizations_url":"https://api.github.com/users/24pullrequests/orgs","repos_url":"https://api.github.com/users/24pullrequests/repos","events_url":"https://api.github.com/users/24pullrequests/events{/privacy}","received_events_url":"https://api.github.com/users/24pullrequests/received_events","type":"Organization","site_admin":false},"repo":{"id":6673802,"name":"24pullrequests","full_name":"24pullrequests/24pullrequests","owner":{"login":"24pullrequests","id":7920922,"avatar_url":"https://avatars.githubusercontent.com/u/7920922?v=2","gravatar_id":null,"url":"https://api.github.com/users/24pullrequests","html_url":"https://github.com/24pullrequests","followers_url":"https://api.github.com/users/24pullrequests/followers","following_url":"https://api.github.com/users/24pullrequests/following{/other_user}","gists_url":"https://api.github.com/users/24pullrequests/gists{/gist_id}","starred_url":"https://api.github.com/users/24pullrequests/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/24pullrequests/subscriptions","organizations_url":"https://api.github.com/users/24pullrequests/orgs","repos_url":"https://api.github.com/users/24pullrequests/repos","events_url":"https://api.github.com/users/24pullrequests/events{/privacy}","received_events_url":"https://api.github.com/users/24pullrequests/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/24pullrequests/24pullrequests","description":"Giving back little gifts of code for Christmas","fork":false,"url":"https://api.github.com/repos/24pullrequests/24pullrequests","forks_url":"https://api.github.com/repos/24pullrequests/24pullrequests/forks","keys_url":"https://api.github.com/repos/24pullrequests/24pullrequests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/24pullrequests/24pullrequests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/24pullrequests/24pullrequests/teams","hooks_url":"https://api.github.com/repos/24pullrequests/24pullrequests/hooks","issue_events_url":"https://api.github.com/repos/24pullrequests/24pullrequests/issues/events{/number}","events_url":"https://api.github.com/repos/24pullrequests/24pullrequests/events","assignees_url":"https://api.github.com/repos/24pullrequests/24pullrequests/assignees{/user}","branches_url":"https://api.github.com/repos/24pullrequests/24pullrequests/branches{/branch}","tags_url":"https://api.github.com/repos/24pullrequests/24pullrequests/tags","blobs_url":"https://api.github.com/repos/24pullrequests/24pullrequests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/24pullrequests/24pullrequests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/24pullrequests/24pullrequests/git/refs{/sha}","trees_url":"https://api.github.com/repos/24pullrequests/24pullrequests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/24pullrequests/24pullrequests/statuses/{sha}","languages_url":"https://api.github.com/repos/24pullrequests/24pullrequests/languages","stargazers_url":"https://api.github.com/repos/24pullrequests/24pullrequests/stargazers","contributors_url":"https://api.github.com/repos/24pullrequests/24pullrequests/contributors","subscribers_url":"https://api.github.com/repos/24pullrequests/24pullrequests/subscribers","subscription_url":"https://api.github.com/repos/24pullrequests/24pullrequests/subscription","commits_url":"https://api.github.com/repos/24pullrequests/24pullrequests/commits{/sha}","git_commits_url":"https://api.github.com/repos/24pullrequests/24pullrequests/git/commits{/sha}","comments_url":"https://api.github.com/repos/24pullrequests/24pullrequests/comments{/number}","issue_comment_url":"https://api.github.com/repos/24pullrequests/24pullrequests/issues/comments/{number}","contents_url":"https://api.github.com/repos/24pullrequests/24pullrequests/contents/{+path}","compare_url":"https://api.github.com/repos/24pullrequests/24pullrequests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/24pullrequests/24pullrequests/merges","archive_url":"https://api.github.com/repos/24pullrequests/24pullrequests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/24pullrequests/24pullrequests/downloads","issues_url":"https://api.github.com/repos/24pullrequests/24pullrequests/issues{/number}","pulls_url":"https://api.github.com/repos/24pullrequests/24pullrequests/pulls{/number}","milestones_url":"https://api.github.com/repos/24pullrequests/24pullrequests/milestones{/number}","notifications_url":"https://api.github.com/repos/24pullrequests/24pullrequests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/24pullrequests/24pullrequests/labels{/name}","releases_url":"https://api.github.com/repos/24pullrequests/24pullrequests/releases{/id}","created_at":"2012-11-13T16:32:05Z","updated_at":"2014-07-31T11:21:20Z","pushed_at":"2014-08-12T02:29:21Z","git_url":"git://github.com/24pullrequests/24pullrequests.git","ssh_url":"git@github.com:24pullrequests/24pullrequests.git","clone_url":"https://github.com/24pullrequests/24pullrequests.git","svn_url":"https://github.com/24pullrequests/24pullrequests","homepage":"http://24pullrequests.com/","size":9659,"stargazers_count":580,"watchers_count":580,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":240,"mirror_url":null,"open_issues_count":12,"forks":240,"open_issues":12,"watchers":580,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/24pullrequests/24pullrequests/pulls/574"},"html":{"href":"https://github.com/24pullrequests/24pullrequests/pull/574"},"issue":{"href":"https://api.github.com/repos/24pullrequests/24pullrequests/issues/574"},"comments":{"href":"https://api.github.com/repos/24pullrequests/24pullrequests/issues/574/comments"},"review_comments":{"href":"https://api.github.com/repos/24pullrequests/24pullrequests/pulls/574/comments"},"review_comment":{"href":"https://api.github.com/repos/24pullrequests/24pullrequests/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/24pullrequests/24pullrequests/pulls/574/commits"},"statuses":{"href":"https://api.github.com/repos/24pullrequests/24pullrequests/statuses/2f30a7bbf51457ece0228e30507817fde241d6b4"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":58,"deletions":2,"changed_files":5}}