GitHub PullRequestReviewCommentEvent at 2014-09-05 12:24:05
Repository: vsc-base
Actor: boegel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments/17169407","id":17169407,"diff_hunk":"@@ -374,6 +375,55 @@ def test_loglevel(self):\n         topt = TestOption1(go_args=['--ext-optional=REALVALUE'], go_nosystemexit=True,)\n         self.assertEqual(topt.log.getEffectiveLevel(), fancylogger.getLevelInt(topt.DEFAULT_LOGLEVEL.upper()))\n \n+        topt = TestOption1(go_args=['--debug'], go_nosystemexit=True,)\n+        self.assertEqual(topt.log.getEffectiveLevel(), logging.DEBUG)\n+\n+        topt = TestOption1(go_args=['--info'], go_nosystemexit=True,)\n+        self.assertEqual(topt.log.getEffectiveLevel(), logging.INFO)\n+\n+        topt = TestOption1(go_args=['--quiet'], go_nosystemexit=True,)\n+        self.assertEqual(topt.log.getEffectiveLevel(), logging.WARNING)\n+\n+        # last one wins\n+        topt = TestOption1(go_args=['--debug', '--info', '--quiet'], go_nosystemexit=True,)\n+        self.assertEqual(topt.log.getEffectiveLevel(), logging.WARNING)\n+\n+        CONFIGFILE1 = \"\"\"\n+[base]\n+debug=1\n+\"\"\"\n+        tmp1 = NamedTemporaryFile()\n+        tmp1.write(CONFIGFILE1)\n+        tmp1.flush()  # flush, otherwise empty","path":"test/generaloption.py","position":31,"original_position":31,"commit_id":"3916b0d09b3bf39d3d7069b70c81cd0732bba54b","original_commit_id":"3916b0d09b3bf39d3d7069b70c81cd0732bba54b","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=2","gravatar_id":"93efe8c67147791f743923763ff6197d","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"ah, no, nvm, that would remove it","created_at":"2014-09-05T12:24:05Z","updated_at":"2014-09-05T12:24:05Z","html_url":"https://github.com/hpcugent/vsc-base/pull/131#discussion_r17169407","pull_request_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments/17169407"},"html":{"href":"https://github.com/hpcugent/vsc-base/pull/131#discussion_r17169407"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/131","id":19084178,"html_url":"https://github.com/hpcugent/vsc-base/pull/131","diff_url":"https://github.com/hpcugent/vsc-base/pull/131.diff","patch_url":"https://github.com/hpcugent/vsc-base/pull/131.patch","issue_url":"https://api.github.com/repos/hpcugent/vsc-base/issues/131","number":131,"state":"open","locked":false,"title":"Fix log action order in generaloption","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=2","gravatar_id":"ab38b1cdcb5cd98bce610ecbe480c0ba","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-30T11:51:47Z","updated_at":"2014-09-05T12:24:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8b76bdb381b54386f92dbbf4f4170d60a7e1ac1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/131/commits","review_comments_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/131/comments","review_comment_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hpcugent/vsc-base/issues/131/comments","statuses_url":"https://api.github.com/repos/hpcugent/vsc-base/statuses/3916b0d09b3bf39d3d7069b70c81cd0732bba54b","head":{"label":"stdweird:fix_log_action_order_in_generaloption","ref":"fix_log_action_order_in_generaloption","sha":"3916b0d09b3bf39d3d7069b70c81cd0732bba54b","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=2","gravatar_id":"ab38b1cdcb5cd98bce610ecbe480c0ba","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"repo":{"id":7770974,"name":"vsc-base","full_name":"stdweird/vsc-base","owner":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=2","gravatar_id":"ab38b1cdcb5cd98bce610ecbe480c0ba","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stdweird/vsc-base","description":"Basic Python libraries used by UGent's HPC group","fork":true,"url":"https://api.github.com/repos/stdweird/vsc-base","forks_url":"https://api.github.com/repos/stdweird/vsc-base/forks","keys_url":"https://api.github.com/repos/stdweird/vsc-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stdweird/vsc-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stdweird/vsc-base/teams","hooks_url":"https://api.github.com/repos/stdweird/vsc-base/hooks","issue_events_url":"https://api.github.com/repos/stdweird/vsc-base/issues/events{/number}","events_url":"https://api.github.com/repos/stdweird/vsc-base/events","assignees_url":"https://api.github.com/repos/stdweird/vsc-base/assignees{/user}","branches_url":"https://api.github.com/repos/stdweird/vsc-base/branches{/branch}","tags_url":"https://api.github.com/repos/stdweird/vsc-base/tags","blobs_url":"https://api.github.com/repos/stdweird/vsc-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stdweird/vsc-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stdweird/vsc-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/stdweird/vsc-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stdweird/vsc-base/statuses/{sha}","languages_url":"https://api.github.com/repos/stdweird/vsc-base/languages","stargazers_url":"https://api.github.com/repos/stdweird/vsc-base/stargazers","contributors_url":"https://api.github.com/repos/stdweird/vsc-base/contributors","subscribers_url":"https://api.github.com/repos/stdweird/vsc-base/subscribers","subscription_url":"https://api.github.com/repos/stdweird/vsc-base/subscription","commits_url":"https://api.github.com/repos/stdweird/vsc-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/stdweird/vsc-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/stdweird/vsc-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/stdweird/vsc-base/issues/comments/{number}","contents_url":"https://api.github.com/repos/stdweird/vsc-base/contents/{+path}","compare_url":"https://api.github.com/repos/stdweird/vsc-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stdweird/vsc-base/merges","archive_url":"https://api.github.com/repos/stdweird/vsc-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stdweird/vsc-base/downloads","issues_url":"https://api.github.com/repos/stdweird/vsc-base/issues{/number}","pulls_url":"https://api.github.com/repos/stdweird/vsc-base/pulls{/number}","milestones_url":"https://api.github.com/repos/stdweird/vsc-base/milestones{/number}","notifications_url":"https://api.github.com/repos/stdweird/vsc-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stdweird/vsc-base/labels{/name}","releases_url":"https://api.github.com/repos/stdweird/vsc-base/releases{/id}","created_at":"2013-01-23T08:46:49Z","updated_at":"2014-09-05T07:09:08Z","pushed_at":"2014-09-05T10:49:50Z","git_url":"git://github.com/stdweird/vsc-base.git","ssh_url":"git@github.com:stdweird/vsc-base.git","clone_url":"https://github.com/stdweird/vsc-base.git","svn_url":"https://github.com/stdweird/vsc-base","homepage":null,"size":1465,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcugent:master","ref":"master","sha":"cc856f32eaa7a0097663c5433e2966efeffd3061","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=2","gravatar_id":"b12f36a4d0f123b4b185272bf876c728","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":7765704,"name":"vsc-base","full_name":"hpcugent/vsc-base","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=2","gravatar_id":"b12f36a4d0f123b4b185272bf876c728","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/vsc-base","description":"Basic Python libraries used by UGent's HPC group","fork":false,"url":"https://api.github.com/repos/hpcugent/vsc-base","forks_url":"https://api.github.com/repos/hpcugent/vsc-base/forks","keys_url":"https://api.github.com/repos/hpcugent/vsc-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/vsc-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/vsc-base/teams","hooks_url":"https://api.github.com/repos/hpcugent/vsc-base/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/vsc-base/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/vsc-base/events","assignees_url":"https://api.github.com/repos/hpcugent/vsc-base/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/vsc-base/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/vsc-base/tags","blobs_url":"https://api.github.com/repos/hpcugent/vsc-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/vsc-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/vsc-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/vsc-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/vsc-base/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/vsc-base/languages","stargazers_url":"https://api.github.com/repos/hpcugent/vsc-base/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/vsc-base/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/vsc-base/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/vsc-base/subscription","commits_url":"https://api.github.com/repos/hpcugent/vsc-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/vsc-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/vsc-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/vsc-base/issues/comments/{number}","contents_url":"https://api.github.com/repos/hpcugent/vsc-base/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/vsc-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/vsc-base/merges","archive_url":"https://api.github.com/repos/hpcugent/vsc-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/vsc-base/downloads","issues_url":"https://api.github.com/repos/hpcugent/vsc-base/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/vsc-base/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/vsc-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/vsc-base/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/vsc-base/releases{/id}","created_at":"2013-01-23T01:51:31Z","updated_at":"2014-07-03T15:29:33Z","pushed_at":"2014-08-13T09:27:18Z","git_url":"git://github.com/hpcugent/vsc-base.git","ssh_url":"git@github.com:hpcugent/vsc-base.git","clone_url":"https://github.com/hpcugent/vsc-base.git","svn_url":"https://github.com/hpcugent/vsc-base","homepage":null,"size":1848,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":13,"mirror_url":null,"open_issues_count":11,"forks":13,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/131"},"html":{"href":"https://github.com/hpcugent/vsc-base/pull/131"},"issue":{"href":"https://api.github.com/repos/hpcugent/vsc-base/issues/131"},"comments":{"href":"https://api.github.com/repos/hpcugent/vsc-base/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/vsc-base/statuses/3916b0d09b3bf39d3d7069b70c81cd0732bba54b"}}}}