GitHub PullRequestReviewCommentEvent at 2014-08-27 00:11:59
Repository: mail
Actor: jeremy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mikel/mail/pulls/comments/16751356","id":16751356,"diff_hunk":"@@ -114,31 +114,19 @@ def Encodings.decode_encode(str, output_type)\n     # String has to be of the format =?<encoding>?[QB]?<string>?=\n     def Encodings.value_decode(str)\n       # Optimization: If there's no encoded-words in the string, just return it\n-      return str unless str =~ /\\=\\?[^?]+\\?[QB]\\?[^?]*?\\?\\=/xmi\n+      quoted = /\\=\\?[^?]+\\?([QB])\\?[^?]*?\\?\\=/mi\n+      return str unless str =~ quoted\n \n       lines = collapse_adjacent_encodings(str)\n \n       # Split on white-space boundaries with capture, so we capture the white-space as well\n-      lines.map do |line|\n-        line.split(/([ \\t])/).map do |text|\n-          if text.index('=?').nil?\n-            text\n-          else\n-            # Search for occurences of quoted strings or plain strings\n-            text.scan(/(                                 # Group around entire regex to include it in matches\n-                        \\=\\?[^?]+\\?([QB])\\?[^?]*?\\?\\=    # Quoted String with subgroup for encoding method\n-                        |                                # or\n-                        .+?(?=\\=\\?|$)                    # Plain String","path":"lib/mail/encodings.rb","position":20,"original_position":20,"commit_id":"14b9a52dd6fd1550a240666165df8fe373c5e68e","original_commit_id":"14b9a52dd6fd1550a240666165df8fe373c5e68e","user":{"login":"jeremy","id":199,"avatar_url":"https://avatars.githubusercontent.com/u/199?v=2","gravatar_id":"24d2f8804e6bb4b7ea6bd11e0a586470","url":"https://api.github.com/users/jeremy","html_url":"https://github.com/jeremy","followers_url":"https://api.github.com/users/jeremy/followers","following_url":"https://api.github.com/users/jeremy/following{/other_user}","gists_url":"https://api.github.com/users/jeremy/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremy/subscriptions","organizations_url":"https://api.github.com/users/jeremy/orgs","repos_url":"https://api.github.com/users/jeremy/repos","events_url":"https://api.github.com/users/jeremy/events{/privacy}","received_events_url":"https://api.github.com/users/jeremy/received_events","type":"User","site_admin":false},"body":"Looks like it's because the `gsub!` is limited to matching encoded values.","created_at":"2014-08-27T00:11:59Z","updated_at":"2014-08-27T00:11:59Z","html_url":"https://github.com/mikel/mail/pull/776#discussion_r16751356","pull_request_url":"https://api.github.com/repos/mikel/mail/pulls/776","_links":{"self":{"href":"https://api.github.com/repos/mikel/mail/pulls/comments/16751356"},"html":{"href":"https://github.com/mikel/mail/pull/776#discussion_r16751356"},"pull_request":{"href":"https://api.github.com/repos/mikel/mail/pulls/776"}}},"pull_request":{"url":"https://api.github.com/repos/mikel/mail/pulls/776","id":19440159,"html_url":"https://github.com/mikel/mail/pull/776","diff_url":"https://github.com/mikel/mail/pull/776.diff","patch_url":"https://github.com/mikel/mail/pull/776.patch","issue_url":"https://api.github.com/repos/mikel/mail/issues/776","number":776,"state":"open","locked":false,"title":"simplify encoding splitter and support whitespace inside encoded","user":{"login":"grosser","id":11367,"avatar_url":"https://avatars.githubusercontent.com/u/11367?v=2","gravatar_id":"59436ecd4fe6ad7c34f67654d839f05f","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"body":"@bf4 @jeremy @mikel \r\n\r\nalso some performance/GC improvements","created_at":"2014-08-07T00:00:54Z","updated_at":"2014-08-27T00:11:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73d3f0853d4d108540e2c2a75bb9d9b06dc0c9f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mikel/mail/pulls/776/commits","review_comments_url":"https://api.github.com/repos/mikel/mail/pulls/776/comments","review_comment_url":"https://api.github.com/repos/mikel/mail/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mikel/mail/issues/776/comments","statuses_url":"https://api.github.com/repos/mikel/mail/statuses/14b9a52dd6fd1550a240666165df8fe373c5e68e","head":{"label":"zendesk:grosser/double-strip","ref":"grosser/double-strip","sha":"14b9a52dd6fd1550a240666165df8fe373c5e68e","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=2","gravatar_id":"1e7ebb09678c1def6181efcefcfe0d59","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":21284460,"name":"mail","full_name":"zendesk/mail","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=2","gravatar_id":"1e7ebb09678c1def6181efcefcfe0d59","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/mail","description":"A Really Ruby Mail Library","fork":true,"url":"https://api.github.com/repos/zendesk/mail","forks_url":"https://api.github.com/repos/zendesk/mail/forks","keys_url":"https://api.github.com/repos/zendesk/mail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/mail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/mail/teams","hooks_url":"https://api.github.com/repos/zendesk/mail/hooks","issue_events_url":"https://api.github.com/repos/zendesk/mail/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/mail/events","assignees_url":"https://api.github.com/repos/zendesk/mail/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/mail/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/mail/tags","blobs_url":"https://api.github.com/repos/zendesk/mail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/mail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/mail/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/mail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/mail/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/mail/languages","stargazers_url":"https://api.github.com/repos/zendesk/mail/stargazers","contributors_url":"https://api.github.com/repos/zendesk/mail/contributors","subscribers_url":"https://api.github.com/repos/zendesk/mail/subscribers","subscription_url":"https://api.github.com/repos/zendesk/mail/subscription","commits_url":"https://api.github.com/repos/zendesk/mail/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/mail/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/mail/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/mail/issues/comments/{number}","contents_url":"https://api.github.com/repos/zendesk/mail/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/mail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/mail/merges","archive_url":"https://api.github.com/repos/zendesk/mail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/mail/downloads","issues_url":"https://api.github.com/repos/zendesk/mail/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/mail/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/mail/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/mail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/mail/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/mail/releases{/id}","created_at":"2014-06-27T18:02:33Z","updated_at":"2014-06-27T03:40:15Z","pushed_at":"2014-08-14T14:51:03Z","git_url":"git://github.com/zendesk/mail.git","ssh_url":"git@github.com:zendesk/mail.git","clone_url":"https://github.com/zendesk/mail.git","svn_url":"https://github.com/zendesk/mail","homepage":"","size":5722,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mikel:master","ref":"master","sha":"d19b11180f9df44b1132c4a1b0a8d248b806240b","user":{"login":"mikel","id":3366,"avatar_url":"https://avatars.githubusercontent.com/u/3366?v=2","gravatar_id":"fb1a6916e06f221b5b53a6665f9858eb","url":"https://api.github.com/users/mikel","html_url":"https://github.com/mikel","followers_url":"https://api.github.com/users/mikel/followers","following_url":"https://api.github.com/users/mikel/following{/other_user}","gists_url":"https://api.github.com/users/mikel/gists{/gist_id}","starred_url":"https://api.github.com/users/mikel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikel/subscriptions","organizations_url":"https://api.github.com/users/mikel/orgs","repos_url":"https://api.github.com/users/mikel/repos","events_url":"https://api.github.com/users/mikel/events{/privacy}","received_events_url":"https://api.github.com/users/mikel/received_events","type":"User","site_admin":false},"repo":{"id":79352,"name":"mail","full_name":"mikel/mail","owner":{"login":"mikel","id":3366,"avatar_url":"https://avatars.githubusercontent.com/u/3366?v=2","gravatar_id":"fb1a6916e06f221b5b53a6665f9858eb","url":"https://api.github.com/users/mikel","html_url":"https://github.com/mikel","followers_url":"https://api.github.com/users/mikel/followers","following_url":"https://api.github.com/users/mikel/following{/other_user}","gists_url":"https://api.github.com/users/mikel/gists{/gist_id}","starred_url":"https://api.github.com/users/mikel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikel/subscriptions","organizations_url":"https://api.github.com/users/mikel/orgs","repos_url":"https://api.github.com/users/mikel/repos","events_url":"https://api.github.com/users/mikel/events{/privacy}","received_events_url":"https://api.github.com/users/mikel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikel/mail","description":"A Really Ruby Mail Library","fork":false,"url":"https://api.github.com/repos/mikel/mail","forks_url":"https://api.github.com/repos/mikel/mail/forks","keys_url":"https://api.github.com/repos/mikel/mail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikel/mail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikel/mail/teams","hooks_url":"https://api.github.com/repos/mikel/mail/hooks","issue_events_url":"https://api.github.com/repos/mikel/mail/issues/events{/number}","events_url":"https://api.github.com/repos/mikel/mail/events","assignees_url":"https://api.github.com/repos/mikel/mail/assignees{/user}","branches_url":"https://api.github.com/repos/mikel/mail/branches{/branch}","tags_url":"https://api.github.com/repos/mikel/mail/tags","blobs_url":"https://api.github.com/repos/mikel/mail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikel/mail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikel/mail/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikel/mail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikel/mail/statuses/{sha}","languages_url":"https://api.github.com/repos/mikel/mail/languages","stargazers_url":"https://api.github.com/repos/mikel/mail/stargazers","contributors_url":"https://api.github.com/repos/mikel/mail/contributors","subscribers_url":"https://api.github.com/repos/mikel/mail/subscribers","subscription_url":"https://api.github.com/repos/mikel/mail/subscription","commits_url":"https://api.github.com/repos/mikel/mail/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikel/mail/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikel/mail/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikel/mail/issues/comments/{number}","contents_url":"https://api.github.com/repos/mikel/mail/contents/{+path}","compare_url":"https://api.github.com/repos/mikel/mail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikel/mail/merges","archive_url":"https://api.github.com/repos/mikel/mail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikel/mail/downloads","issues_url":"https://api.github.com/repos/mikel/mail/issues{/number}","pulls_url":"https://api.github.com/repos/mikel/mail/pulls{/number}","milestones_url":"https://api.github.com/repos/mikel/mail/milestones{/number}","notifications_url":"https://api.github.com/repos/mikel/mail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikel/mail/labels{/name}","releases_url":"https://api.github.com/repos/mikel/mail/releases{/id}","created_at":"2008-11-22T03:16:54Z","updated_at":"2014-08-26T12:52:46Z","pushed_at":"2014-08-26T22:50:47Z","git_url":"git://github.com/mikel/mail.git","ssh_url":"git@github.com:mikel/mail.git","clone_url":"https://github.com/mikel/mail.git","svn_url":"https://github.com/mikel/mail","homepage":"","size":9427,"stargazers_count":1869,"watchers_count":1869,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":471,"mirror_url":null,"open_issues_count":138,"forks":471,"open_issues":138,"watchers":1869,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mikel/mail/pulls/776"},"html":{"href":"https://github.com/mikel/mail/pull/776"},"issue":{"href":"https://api.github.com/repos/mikel/mail/issues/776"},"comments":{"href":"https://api.github.com/repos/mikel/mail/issues/776/comments"},"review_comments":{"href":"https://api.github.com/repos/mikel/mail/pulls/776/comments"},"review_comment":{"href":"https://api.github.com/repos/mikel/mail/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mikel/mail/pulls/776/commits"},"statuses":{"href":"https://api.github.com/repos/mikel/mail/statuses/14b9a52dd6fd1550a240666165df8fe373c5e68e"}}}}