GitHub PullRequestEvent at 2014-04-14 11:08:00
Repository: node-sass
Actor: andrew
Payload: {"action":"closed","number":281,"pull_request":{"url":"https://api.github.com/repos/andrew/node-sass/pulls/281","id":14573912,"html_url":"https://github.com/andrew/node-sass/pull/281","diff_url":"https://github.com/andrew/node-sass/pull/281.diff","patch_url":"https://github.com/andrew/node-sass/pull/281.patch","issue_url":"https://api.github.com/repos/andrew/node-sass/issues/281","number":281,"state":"closed","title":"Cleaner detection of bindings with better error handling.","user":{"login":"djanowski","id":2268,"avatar_url":"https://avatars.githubusercontent.com/u/2268?","gravatar_id":"ffd012d72e7f61639724878825ed25a3","url":"https://api.github.com/users/djanowski","html_url":"https://github.com/djanowski","followers_url":"https://api.github.com/users/djanowski/followers","following_url":"https://api.github.com/users/djanowski/following{/other_user}","gists_url":"https://api.github.com/users/djanowski/gists{/gist_id}","starred_url":"https://api.github.com/users/djanowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djanowski/subscriptions","organizations_url":"https://api.github.com/users/djanowski/orgs","repos_url":"https://api.github.com/users/djanowski/repos","events_url":"https://api.github.com/users/djanowski/events{/privacy}","received_events_url":"https://api.github.com/users/djanowski/received_events","type":"User","site_admin":false},"body":"I found this issue while debugging why `node-sass` wouldn't work on my 32-bit Debian 6 install. The current implementation caught all exceptions and reported the same error whether or not the file was actually there. The proposed change makes the file's existence check explicit and then calls `require`. Exceptions with `require` are intentionally not handled.\r\n\r\nBefore the patch:\r\n\r\n```\r\n$ npm test\r\n\r\n[...]\r\n\r\n/root/jano/node-sass/sass.js:18\r\n    throw new Error('`'+ modPath + '.node` is missing. Try reinstalling `node-\r\n          ^\r\nError: `/root/jano/node-sass/bin/linux-ia32-v8-3.22/binding.node` is missing. Try reinstalling `node-sass`?\r\n```\r\n\r\nAfter the patch:\r\n\r\n```\r\n$ npm test\r\n\r\n[...]\r\n\r\nmodule.js:349\r\n  Module._extensions[extension](this, filename);\r\n                               ^\r\nError: /root/jano/node-sass/build/Release/obj.target/binding.node: undefined symbol: _ZN2v84NullEv\r\n```","created_at":"2014-04-09T20:53:55Z","updated_at":"2014-04-14T11:08:00Z","closed_at":"2014-04-14T11:07:59Z","merged_at":"2014-04-14T11:07:59Z","merge_commit_sha":"8b070ce4d5a1afa8f3555b41a5c768125301cf2b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/andrew/node-sass/pulls/281/commits","review_comments_url":"https://api.github.com/repos/andrew/node-sass/pulls/281/comments","review_comment_url":"https://api.github.com/repos/andrew/node-sass/pulls/comments/{number}","comments_url":"https://api.github.com/repos/andrew/node-sass/issues/281/comments","statuses_url":"https://api.github.com/repos/andrew/node-sass/statuses/978e11d20b13e45e28df2bfacfe584493d9fdfb7","head":{"label":"djanowski:cleaner-binding-detection","ref":"cleaner-binding-detection","sha":"978e11d20b13e45e28df2bfacfe584493d9fdfb7","user":{"login":"djanowski","id":2268,"avatar_url":"https://avatars.githubusercontent.com/u/2268?","gravatar_id":"ffd012d72e7f61639724878825ed25a3","url":"https://api.github.com/users/djanowski","html_url":"https://github.com/djanowski","followers_url":"https://api.github.com/users/djanowski/followers","following_url":"https://api.github.com/users/djanowski/following{/other_user}","gists_url":"https://api.github.com/users/djanowski/gists{/gist_id}","starred_url":"https://api.github.com/users/djanowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djanowski/subscriptions","organizations_url":"https://api.github.com/users/djanowski/orgs","repos_url":"https://api.github.com/users/djanowski/repos","events_url":"https://api.github.com/users/djanowski/events{/privacy}","received_events_url":"https://api.github.com/users/djanowski/received_events","type":"User","site_admin":false},"repo":{"id":18606710,"name":"node-sass","full_name":"djanowski/node-sass","owner":{"login":"djanowski","id":2268,"avatar_url":"https://avatars.githubusercontent.com/u/2268?","gravatar_id":"ffd012d72e7f61639724878825ed25a3","url":"https://api.github.com/users/djanowski","html_url":"https://github.com/djanowski","followers_url":"https://api.github.com/users/djanowski/followers","following_url":"https://api.github.com/users/djanowski/following{/other_user}","gists_url":"https://api.github.com/users/djanowski/gists{/gist_id}","starred_url":"https://api.github.com/users/djanowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djanowski/subscriptions","organizations_url":"https://api.github.com/users/djanowski/orgs","repos_url":"https://api.github.com/users/djanowski/repos","events_url":"https://api.github.com/users/djanowski/events{/privacy}","received_events_url":"https://api.github.com/users/djanowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djanowski/node-sass","description":"Node.js bindings to libsass","fork":true,"url":"https://api.github.com/repos/djanowski/node-sass","forks_url":"https://api.github.com/repos/djanowski/node-sass/forks","keys_url":"https://api.github.com/repos/djanowski/node-sass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djanowski/node-sass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djanowski/node-sass/teams","hooks_url":"https://api.github.com/repos/djanowski/node-sass/hooks","issue_events_url":"https://api.github.com/repos/djanowski/node-sass/issues/events{/number}","events_url":"https://api.github.com/repos/djanowski/node-sass/events","assignees_url":"https://api.github.com/repos/djanowski/node-sass/assignees{/user}","branches_url":"https://api.github.com/repos/djanowski/node-sass/branches{/branch}","tags_url":"https://api.github.com/repos/djanowski/node-sass/tags","blobs_url":"https://api.github.com/repos/djanowski/node-sass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djanowski/node-sass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djanowski/node-sass/git/refs{/sha}","trees_url":"https://api.github.com/repos/djanowski/node-sass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djanowski/node-sass/statuses/{sha}","languages_url":"https://api.github.com/repos/djanowski/node-sass/languages","stargazers_url":"https://api.github.com/repos/djanowski/node-sass/stargazers","contributors_url":"https://api.github.com/repos/djanowski/node-sass/contributors","subscribers_url":"https://api.github.com/repos/djanowski/node-sass/subscribers","subscription_url":"https://api.github.com/repos/djanowski/node-sass/subscription","commits_url":"https://api.github.com/repos/djanowski/node-sass/commits{/sha}","git_commits_url":"https://api.github.com/repos/djanowski/node-sass/git/commits{/sha}","comments_url":"https://api.github.com/repos/djanowski/node-sass/comments{/number}","issue_comment_url":"https://api.github.com/repos/djanowski/node-sass/issues/comments/{number}","contents_url":"https://api.github.com/repos/djanowski/node-sass/contents/{+path}","compare_url":"https://api.github.com/repos/djanowski/node-sass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djanowski/node-sass/merges","archive_url":"https://api.github.com/repos/djanowski/node-sass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djanowski/node-sass/downloads","issues_url":"https://api.github.com/repos/djanowski/node-sass/issues{/number}","pulls_url":"https://api.github.com/repos/djanowski/node-sass/pulls{/number}","milestones_url":"https://api.github.com/repos/djanowski/node-sass/milestones{/number}","notifications_url":"https://api.github.com/repos/djanowski/node-sass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djanowski/node-sass/labels{/name}","releases_url":"https://api.github.com/repos/djanowski/node-sass/releases{/id}","created_at":"2014-04-09T17:41:10Z","updated_at":"2014-04-14T11:07:59Z","pushed_at":"2014-04-09T20:53:34Z","git_url":"git://github.com/djanowski/node-sass.git","ssh_url":"git@github.com:djanowski/node-sass.git","clone_url":"https://github.com/djanowski/node-sass.git","svn_url":"https://github.com/djanowski/node-sass","homepage":"https://npmjs.org/package/node-sass","size":16171,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"andrew:master","ref":"master","sha":"4180123ca2f4949c336eda8bda2cd3e5536c8902","user":{"login":"andrew","id":1060,"avatar_url":"https://avatars.githubusercontent.com/u/1060?","gravatar_id":"8ddbf811da78bb0daeeb3cacd7cf743f","url":"https://api.github.com/users/andrew","html_url":"https://github.com/andrew","followers_url":"https://api.github.com/users/andrew/followers","following_url":"https://api.github.com/users/andrew/following{/other_user}","gists_url":"https://api.github.com/users/andrew/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew/subscriptions","organizations_url":"https://api.github.com/users/andrew/orgs","repos_url":"https://api.github.com/users/andrew/repos","events_url":"https://api.github.com/users/andrew/events{/privacy}","received_events_url":"https://api.github.com/users/andrew/received_events","type":"User","site_admin":true},"repo":{"id":4128353,"name":"node-sass","full_name":"andrew/node-sass","owner":{"login":"andrew","id":1060,"avatar_url":"https://avatars.githubusercontent.com/u/1060?","gravatar_id":"8ddbf811da78bb0daeeb3cacd7cf743f","url":"https://api.github.com/users/andrew","html_url":"https://github.com/andrew","followers_url":"https://api.github.com/users/andrew/followers","following_url":"https://api.github.com/users/andrew/following{/other_user}","gists_url":"https://api.github.com/users/andrew/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew/subscriptions","organizations_url":"https://api.github.com/users/andrew/orgs","repos_url":"https://api.github.com/users/andrew/repos","events_url":"https://api.github.com/users/andrew/events{/privacy}","received_events_url":"https://api.github.com/users/andrew/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/andrew/node-sass","description":"Node.js bindings to libsass","fork":false,"url":"https://api.github.com/repos/andrew/node-sass","forks_url":"https://api.github.com/repos/andrew/node-sass/forks","keys_url":"https://api.github.com/repos/andrew/node-sass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrew/node-sass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrew/node-sass/teams","hooks_url":"https://api.github.com/repos/andrew/node-sass/hooks","issue_events_url":"https://api.github.com/repos/andrew/node-sass/issues/events{/number}","events_url":"https://api.github.com/repos/andrew/node-sass/events","assignees_url":"https://api.github.com/repos/andrew/node-sass/assignees{/user}","branches_url":"https://api.github.com/repos/andrew/node-sass/branches{/branch}","tags_url":"https://api.github.com/repos/andrew/node-sass/tags","blobs_url":"https://api.github.com/repos/andrew/node-sass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrew/node-sass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrew/node-sass/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrew/node-sass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrew/node-sass/statuses/{sha}","languages_url":"https://api.github.com/repos/andrew/node-sass/languages","stargazers_url":"https://api.github.com/repos/andrew/node-sass/stargazers","contributors_url":"https://api.github.com/repos/andrew/node-sass/contributors","subscribers_url":"https://api.github.com/repos/andrew/node-sass/subscribers","subscription_url":"https://api.github.com/repos/andrew/node-sass/subscription","commits_url":"https://api.github.com/repos/andrew/node-sass/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrew/node-sass/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrew/node-sass/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrew/node-sass/issues/comments/{number}","contents_url":"https://api.github.com/repos/andrew/node-sass/contents/{+path}","compare_url":"https://api.github.com/repos/andrew/node-sass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrew/node-sass/merges","archive_url":"https://api.github.com/repos/andrew/node-sass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrew/node-sass/downloads","issues_url":"https://api.github.com/repos/andrew/node-sass/issues{/number}","pulls_url":"https://api.github.com/repos/andrew/node-sass/pulls{/number}","milestones_url":"https://api.github.com/repos/andrew/node-sass/milestones{/number}","notifications_url":"https://api.github.com/repos/andrew/node-sass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrew/node-sass/labels{/name}","releases_url":"https://api.github.com/repos/andrew/node-sass/releases{/id}","created_at":"2012-04-24T18:46:30Z","updated_at":"2014-04-14T11:07:59Z","pushed_at":"2014-04-14T11:07:59Z","git_url":"git://github.com/andrew/node-sass.git","ssh_url":"git@github.com:andrew/node-sass.git","clone_url":"https://github.com/andrew/node-sass.git","svn_url":"https://github.com/andrew/node-sass","homepage":"https://npmjs.org/package/node-sass","size":16171,"stargazers_count":742,"watchers_count":742,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":105,"mirror_url":null,"open_issues_count":20,"forks":105,"open_issues":20,"watchers":742,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andrew/node-sass/pulls/281"},"html":{"href":"https://github.com/andrew/node-sass/pull/281"},"issue":{"href":"https://api.github.com/repos/andrew/node-sass/issues/281"},"comments":{"href":"https://api.github.com/repos/andrew/node-sass/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/andrew/node-sass/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/andrew/node-sass/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/andrew/node-sass/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/andrew/node-sass/statuses/978e11d20b13e45e28df2bfacfe584493d9fdfb7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andrew","id":1060,"avatar_url":"https://avatars.githubusercontent.com/u/1060?","gravatar_id":"8ddbf811da78bb0daeeb3cacd7cf743f","url":"https://api.github.com/users/andrew","html_url":"https://github.com/andrew","followers_url":"https://api.github.com/users/andrew/followers","following_url":"https://api.github.com/users/andrew/following{/other_user}","gists_url":"https://api.github.com/users/andrew/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew/subscriptions","organizations_url":"https://api.github.com/users/andrew/orgs","repos_url":"https://api.github.com/users/andrew/repos","events_url":"https://api.github.com/users/andrew/events{/privacy}","received_events_url":"https://api.github.com/users/andrew/received_events","type":"User","site_admin":true},"comments":3,"review_comments":0,"commits":1,"additions":19,"deletions":16,"changed_files":1}}