GitHub PushEvent at 2014-02-21 00:56:52
Repository: rust
Actor: bors
Payload: {"shas":[["7bb498bd7a09f024fe46fc58ea17fe44cbc68df0","60c6d277a8bd81de7fdde19201bf9c58a3df08f4@alexcrichton.com","Mass rename if_ok! to try!\n\nThis \"bubble up an error\" macro was originally named if_ok! in order to get it\nlanded, but after the fact it was discovered that this name is not exactly\ndesirable.\n\nThe name `if_ok!` isn't immediately clear that is has much to do with error\nhandling, and it doesn't look fantastic in all contexts (if if_ok!(...) {}). In\ngeneral, the agreed opinion about `if_ok!` is that is came in as subpar.\n\nThe name `try!` is more invocative of error handling, it's shorter by 2 letters,\nand it looks fitting in almost all circumstances. One concern about the word\n`try!` is that it's too invocative of exceptions, but the belief is that this\nwill be overcome with documentation and examples.\n\nClose #12037","Alex Crichton",true],["7e9bcc545631f2e0a5c248206ae25831242affdf","3a2c29237f73c7cf88424b80e427b1884f346b35@rust-lang.org","auto merge of #12401 : alexcrichton/rust/if-ok-2-try, r=brson\n\nThis \"bubble up an error\" macro was originally named if_ok! in order to get it\r\nlanded, but after the fact it was discovered that this name is not exactly\r\ndesirable.\r\n\r\nThe name `if_ok!` isn't immediately clear that is has much to do with error\r\nhandling, and it doesn't look fantastic in all contexts (if if_ok!(...) {}). In\r\ngeneral, the agreed opinion about `if_ok!` is that is came in as subpar.\r\n\r\nThe name `try!` is more invocative of error handling, it's shorter by 2 letters,\r\nand it looks fitting in almost all circumstances. One concern about the word\r\n`try!` is that it's too invocative of exceptions, but the belief is that this\r\nwill be overcome with documentation and examples.\r\n\r\nClose #12037","bors",true]],"size":2,"ref":"refs/heads/auto","head":"7e9bcc545631f2e0a5c248206ae25831242affdf"}