GitHub PullRequestEvent at 2015-01-01 06:34:29
Repository: thephpleague/oauth2-server
Actor: sarciszewski
Payload: {"action":"opened","number":290,"pull_request":{"url":"https://api.github.com/repos/thephpleague/oauth2-server/pulls/290","id":26740968,"html_url":"https://github.com/thephpleague/oauth2-server/pull/290","diff_url":"https://github.com/thephpleague/oauth2-server/pull/290.diff","patch_url":"https://github.com/thephpleague/oauth2-server/pull/290.patch","issue_url":"https://api.github.com/repos/thephpleague/oauth2-server/issues/290","number":290,"state":"open","locked":false,"title":"Remove side-effects in hash_equals()","user":{"login":"sarciszewski","id":3710836,"avatar_url":"https://avatars.githubusercontent.com/u/3710836?v=3","gravatar_id":"","url":"https://api.github.com/users/sarciszewski","html_url":"https://github.com/sarciszewski","followers_url":"https://api.github.com/users/sarciszewski/followers","following_url":"https://api.github.com/users/sarciszewski/following{/other_user}","gists_url":"https://api.github.com/users/sarciszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/sarciszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarciszewski/subscriptions","organizations_url":"https://api.github.com/users/sarciszewski/orgs","repos_url":"https://api.github.com/users/sarciszewski/repos","events_url":"https://api.github.com/users/sarciszewski/events{/privacy}","received_events_url":"https://api.github.com/users/sarciszewski/received_events","type":"User","site_admin":false},"body":"This is functionally identical, but without the side-effect of defining a function in the current namespace.\r\n\r\nAlso, it uses absolute function reference (`\\hash_equals` instead of `hash_equals`) because if someone defined `League\\OAuth2\\Server\\TokenType\\hash_equals()` elsewhere, it would try that first.\r\n\r\nKudos for using `hash_equals()` in your original design for this feature. Many OAuth2 implementations neglect this nuance :)","created_at":"2015-01-01T06:34:29Z","updated_at":"2015-01-01T06:34:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thephpleague/oauth2-server/pulls/290/commits","review_comments_url":"https://api.github.com/repos/thephpleague/oauth2-server/pulls/290/comments","review_comment_url":"https://api.github.com/repos/thephpleague/oauth2-server/pulls/comments/{number}","comments_url":"https://api.github.com/repos/thephpleague/oauth2-server/issues/290/comments","statuses_url":"https://api.github.com/repos/thephpleague/oauth2-server/statuses/612775466c2077d134da639646658d3776efbf4d","head":{"label":"sarciszewski:patch-1","ref":"patch-1","sha":"612775466c2077d134da639646658d3776efbf4d","user":{"login":"sarciszewski","id":3710836,"avatar_url":"https://avatars.githubusercontent.com/u/3710836?v=3","gravatar_id":"","url":"https://api.github.com/users/sarciszewski","html_url":"https://github.com/sarciszewski","followers_url":"https://api.github.com/users/sarciszewski/followers","following_url":"https://api.github.com/users/sarciszewski/following{/other_user}","gists_url":"https://api.github.com/users/sarciszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/sarciszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarciszewski/subscriptions","organizations_url":"https://api.github.com/users/sarciszewski/orgs","repos_url":"https://api.github.com/users/sarciszewski/repos","events_url":"https://api.github.com/users/sarciszewski/events{/privacy}","received_events_url":"https://api.github.com/users/sarciszewski/received_events","type":"User","site_admin":false},"repo":{"id":27740585,"name":"oauth2-server","full_name":"sarciszewski/oauth2-server","owner":{"login":"sarciszewski","id":3710836,"avatar_url":"https://avatars.githubusercontent.com/u/3710836?v=3","gravatar_id":"","url":"https://api.github.com/users/sarciszewski","html_url":"https://github.com/sarciszewski","followers_url":"https://api.github.com/users/sarciszewski/followers","following_url":"https://api.github.com/users/sarciszewski/following{/other_user}","gists_url":"https://api.github.com/users/sarciszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/sarciszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarciszewski/subscriptions","organizations_url":"https://api.github.com/users/sarciszewski/orgs","repos_url":"https://api.github.com/users/sarciszewski/repos","events_url":"https://api.github.com/users/sarciszewski/events{/privacy}","received_events_url":"https://api.github.com/users/sarciszewski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarciszewski/oauth2-server","description":"A 100% spec compliant, secure by default PHP OAuth 2.0 Server","fork":true,"url":"https://api.github.com/repos/sarciszewski/oauth2-server","forks_url":"https://api.github.com/repos/sarciszewski/oauth2-server/forks","keys_url":"https://api.github.com/repos/sarciszewski/oauth2-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarciszewski/oauth2-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarciszewski/oauth2-server/teams","hooks_url":"https://api.github.com/repos/sarciszewski/oauth2-server/hooks","issue_events_url":"https://api.github.com/repos/sarciszewski/oauth2-server/issues/events{/number}","events_url":"https://api.github.com/repos/sarciszewski/oauth2-server/events","assignees_url":"https://api.github.com/repos/sarciszewski/oauth2-server/assignees{/user}","branches_url":"https://api.github.com/repos/sarciszewski/oauth2-server/branches{/branch}","tags_url":"https://api.github.com/repos/sarciszewski/oauth2-server/tags","blobs_url":"https://api.github.com/repos/sarciszewski/oauth2-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarciszewski/oauth2-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarciszewski/oauth2-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarciszewski/oauth2-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarciszewski/oauth2-server/statuses/{sha}","languages_url":"https://api.github.com/repos/sarciszewski/oauth2-server/languages","stargazers_url":"https://api.github.com/repos/sarciszewski/oauth2-server/stargazers","contributors_url":"https://api.github.com/repos/sarciszewski/oauth2-server/contributors","subscribers_url":"https://api.github.com/repos/sarciszewski/oauth2-server/subscribers","subscription_url":"https://api.github.com/repos/sarciszewski/oauth2-server/subscription","commits_url":"https://api.github.com/repos/sarciszewski/oauth2-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarciszewski/oauth2-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarciszewski/oauth2-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarciszewski/oauth2-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/sarciszewski/oauth2-server/contents/{+path}","compare_url":"https://api.github.com/repos/sarciszewski/oauth2-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarciszewski/oauth2-server/merges","archive_url":"https://api.github.com/repos/sarciszewski/oauth2-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarciszewski/oauth2-server/downloads","issues_url":"https://api.github.com/repos/sarciszewski/oauth2-server/issues{/number}","pulls_url":"https://api.github.com/repos/sarciszewski/oauth2-server/pulls{/number}","milestones_url":"https://api.github.com/repos/sarciszewski/oauth2-server/milestones{/number}","notifications_url":"https://api.github.com/repos/sarciszewski/oauth2-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarciszewski/oauth2-server/labels{/name}","releases_url":"https://api.github.com/repos/sarciszewski/oauth2-server/releases{/id}","created_at":"2014-12-08T23:36:41Z","updated_at":"2014-12-08T23:36:43Z","pushed_at":"2015-01-01T06:34:22Z","git_url":"git://github.com/sarciszewski/oauth2-server.git","ssh_url":"git@github.com:sarciszewski/oauth2-server.git","clone_url":"https://github.com/sarciszewski/oauth2-server.git","svn_url":"https://github.com/sarciszewski/oauth2-server","homepage":"oauth2.thephpleague.com","size":1363,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thephpleague:master","ref":"master","sha":"740ea24e088f9662f9d8877687ec8fe783ebe733","user":{"login":"thephpleague","id":527621,"avatar_url":"https://avatars.githubusercontent.com/u/527621?v=3","gravatar_id":"","url":"https://api.github.com/users/thephpleague","html_url":"https://github.com/thephpleague","followers_url":"https://api.github.com/users/thephpleague/followers","following_url":"https://api.github.com/users/thephpleague/following{/other_user}","gists_url":"https://api.github.com/users/thephpleague/gists{/gist_id}","starred_url":"https://api.github.com/users/thephpleague/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thephpleague/subscriptions","organizations_url":"https://api.github.com/users/thephpleague/orgs","repos_url":"https://api.github.com/users/thephpleague/repos","events_url":"https://api.github.com/users/thephpleague/events{/privacy}","received_events_url":"https://api.github.com/users/thephpleague/received_events","type":"Organization","site_admin":false},"repo":{"id":4551765,"name":"oauth2-server","full_name":"thephpleague/oauth2-server","owner":{"login":"thephpleague","id":527621,"avatar_url":"https://avatars.githubusercontent.com/u/527621?v=3","gravatar_id":"","url":"https://api.github.com/users/thephpleague","html_url":"https://github.com/thephpleague","followers_url":"https://api.github.com/users/thephpleague/followers","following_url":"https://api.github.com/users/thephpleague/following{/other_user}","gists_url":"https://api.github.com/users/thephpleague/gists{/gist_id}","starred_url":"https://api.github.com/users/thephpleague/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thephpleague/subscriptions","organizations_url":"https://api.github.com/users/thephpleague/orgs","repos_url":"https://api.github.com/users/thephpleague/repos","events_url":"https://api.github.com/users/thephpleague/events{/privacy}","received_events_url":"https://api.github.com/users/thephpleague/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thephpleague/oauth2-server","description":"A 100% spec compliant, secure by default PHP OAuth 2.0 Server","fork":false,"url":"https://api.github.com/repos/thephpleague/oauth2-server","forks_url":"https://api.github.com/repos/thephpleague/oauth2-server/forks","keys_url":"https://api.github.com/repos/thephpleague/oauth2-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thephpleague/oauth2-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thephpleague/oauth2-server/teams","hooks_url":"https://api.github.com/repos/thephpleague/oauth2-server/hooks","issue_events_url":"https://api.github.com/repos/thephpleague/oauth2-server/issues/events{/number}","events_url":"https://api.github.com/repos/thephpleague/oauth2-server/events","assignees_url":"https://api.github.com/repos/thephpleague/oauth2-server/assignees{/user}","branches_url":"https://api.github.com/repos/thephpleague/oauth2-server/branches{/branch}","tags_url":"https://api.github.com/repos/thephpleague/oauth2-server/tags","blobs_url":"https://api.github.com/repos/thephpleague/oauth2-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thephpleague/oauth2-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thephpleague/oauth2-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/thephpleague/oauth2-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thephpleague/oauth2-server/statuses/{sha}","languages_url":"https://api.github.com/repos/thephpleague/oauth2-server/languages","stargazers_url":"https://api.github.com/repos/thephpleague/oauth2-server/stargazers","contributors_url":"https://api.github.com/repos/thephpleague/oauth2-server/contributors","subscribers_url":"https://api.github.com/repos/thephpleague/oauth2-server/subscribers","subscription_url":"https://api.github.com/repos/thephpleague/oauth2-server/subscription","commits_url":"https://api.github.com/repos/thephpleague/oauth2-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/thephpleague/oauth2-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/thephpleague/oauth2-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/thephpleague/oauth2-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/thephpleague/oauth2-server/contents/{+path}","compare_url":"https://api.github.com/repos/thephpleague/oauth2-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thephpleague/oauth2-server/merges","archive_url":"https://api.github.com/repos/thephpleague/oauth2-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thephpleague/oauth2-server/downloads","issues_url":"https://api.github.com/repos/thephpleague/oauth2-server/issues{/number}","pulls_url":"https://api.github.com/repos/thephpleague/oauth2-server/pulls{/number}","milestones_url":"https://api.github.com/repos/thephpleague/oauth2-server/milestones{/number}","notifications_url":"https://api.github.com/repos/thephpleague/oauth2-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thephpleague/oauth2-server/labels{/name}","releases_url":"https://api.github.com/repos/thephpleague/oauth2-server/releases{/id}","created_at":"2012-06-04T20:00:52Z","updated_at":"2015-01-01T00:05:31Z","pushed_at":"2014-12-31T16:07:46Z","git_url":"git://github.com/thephpleague/oauth2-server.git","ssh_url":"git@github.com:thephpleague/oauth2-server.git","clone_url":"https://github.com/thephpleague/oauth2-server.git","svn_url":"https://github.com/thephpleague/oauth2-server","homepage":"oauth2.thephpleague.com","size":7218,"stargazers_count":1287,"watchers_count":1287,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":270,"mirror_url":null,"open_issues_count":8,"forks":270,"open_issues":8,"watchers":1287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thephpleague/oauth2-server/pulls/290"},"html":{"href":"https://github.com/thephpleague/oauth2-server/pull/290"},"issue":{"href":"https://api.github.com/repos/thephpleague/oauth2-server/issues/290"},"comments":{"href":"https://api.github.com/repos/thephpleague/oauth2-server/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/thephpleague/oauth2-server/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/thephpleague/oauth2-server/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/thephpleague/oauth2-server/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/thephpleague/oauth2-server/statuses/612775466c2077d134da639646658d3776efbf4d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":16,"changed_files":1}}