GitHub PullRequestReviewCommentEvent at 2014-06-09 23:18:28
Repository: ceph
Actor: athanatos
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/13570374","id":13570374,"diff_hunk":"@@ -466,6 +466,8 @@ OPTION(osd_op_pq_min_cost, OPT_U64, 65536)\n OPTION(osd_disk_threads, OPT_INT, 1)\n OPTION(osd_recovery_threads, OPT_INT, 1)\n OPTION(osd_recover_clone_overlap, OPT_BOOL, true)   // preserve clone_overlap during recovery/migration\n+OPTION(osd_op_num_sharded_pool_threads, OPT_INT, 10)\n+OPTION(osd_op_num_shards, OPT_INT, 5)","path":"src/common/config_opts.h","position":5,"original_position":5,"commit_id":"2dbd85c94cf27a1ff0419c5ea9359af7fe30e9b6","original_commit_id":"2dbd85c94cf27a1ff0419c5ea9359af7fe30e9b6","user":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?","gravatar_id":null,"url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"body":"I don't think 11 threads and 5 shards makes sense.  The configs should be:\r\n\r\nOPTION(osd_op_num_shards, OPT_INT, 5)\r\nOPTION(osd_op_num_threads_per_shard, OPT_INT, 2)\r\n\r\n","created_at":"2014-06-09T23:18:28Z","updated_at":"2014-06-09T23:18:28Z","html_url":"https://github.com/ceph/ceph/pull/1897#discussion_r13570374","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/1897","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/13570374"},"html":{"href":"https://github.com/ceph/ceph/pull/1897#discussion_r13570374"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/1897"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/1897","id":16562733,"html_url":"https://github.com/ceph/ceph/pull/1897","diff_url":"https://github.com/ceph/ceph/pull/1897.diff","patch_url":"https://github.com/ceph/ceph/pull/1897.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/1897","number":1897,"state":"open","title":"Wip sharded threadpool","user":{"login":"somnathr","id":5751779,"avatar_url":"https://avatars.githubusercontent.com/u/5751779?","gravatar_id":"707d3198538121dce3a2fc4e8dab0707","url":"https://api.github.com/users/somnathr","html_url":"https://github.com/somnathr","followers_url":"https://api.github.com/users/somnathr/followers","following_url":"https://api.github.com/users/somnathr/following{/other_user}","gists_url":"https://api.github.com/users/somnathr/gists{/gist_id}","starred_url":"https://api.github.com/users/somnathr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somnathr/subscriptions","organizations_url":"https://api.github.com/users/somnathr/orgs","repos_url":"https://api.github.com/users/somnathr/repos","events_url":"https://api.github.com/users/somnathr/events{/privacy}","received_events_url":"https://api.github.com/users/somnathr/received_events","type":"User","site_admin":false},"body":"This is a pull request for sharded thread-pool.","created_at":"2014-05-31T02:16:34Z","updated_at":"2014-06-09T23:18:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d39d3c433e5063845ee5f131821cd3061efb293","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/1897/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/1897/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/1897/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/2dbd85c94cf27a1ff0419c5ea9359af7fe30e9b6","head":{"label":"somnathr:wip-sharded-threadpool","ref":"wip-sharded-threadpool","sha":"2dbd85c94cf27a1ff0419c5ea9359af7fe30e9b6","user":{"login":"somnathr","id":5751779,"avatar_url":"https://avatars.githubusercontent.com/u/5751779?","gravatar_id":"707d3198538121dce3a2fc4e8dab0707","url":"https://api.github.com/users/somnathr","html_url":"https://github.com/somnathr","followers_url":"https://api.github.com/users/somnathr/followers","following_url":"https://api.github.com/users/somnathr/following{/other_user}","gists_url":"https://api.github.com/users/somnathr/gists{/gist_id}","starred_url":"https://api.github.com/users/somnathr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somnathr/subscriptions","organizations_url":"https://api.github.com/users/somnathr/orgs","repos_url":"https://api.github.com/users/somnathr/repos","events_url":"https://api.github.com/users/somnathr/events{/privacy}","received_events_url":"https://api.github.com/users/somnathr/received_events","type":"User","site_admin":false},"repo":{"id":13789305,"name":"ceph","full_name":"somnathr/ceph","owner":{"login":"somnathr","id":5751779,"avatar_url":"https://avatars.githubusercontent.com/u/5751779?","gravatar_id":"707d3198538121dce3a2fc4e8dab0707","url":"https://api.github.com/users/somnathr","html_url":"https://github.com/somnathr","followers_url":"https://api.github.com/users/somnathr/followers","following_url":"https://api.github.com/users/somnathr/following{/other_user}","gists_url":"https://api.github.com/users/somnathr/gists{/gist_id}","starred_url":"https://api.github.com/users/somnathr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somnathr/subscriptions","organizations_url":"https://api.github.com/users/somnathr/orgs","repos_url":"https://api.github.com/users/somnathr/repos","events_url":"https://api.github.com/users/somnathr/events{/privacy}","received_events_url":"https://api.github.com/users/somnathr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/somnathr/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/somnathr/ceph","forks_url":"https://api.github.com/repos/somnathr/ceph/forks","keys_url":"https://api.github.com/repos/somnathr/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/somnathr/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/somnathr/ceph/teams","hooks_url":"https://api.github.com/repos/somnathr/ceph/hooks","issue_events_url":"https://api.github.com/repos/somnathr/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/somnathr/ceph/events","assignees_url":"https://api.github.com/repos/somnathr/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/somnathr/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/somnathr/ceph/tags","blobs_url":"https://api.github.com/repos/somnathr/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/somnathr/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/somnathr/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/somnathr/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/somnathr/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/somnathr/ceph/languages","stargazers_url":"https://api.github.com/repos/somnathr/ceph/stargazers","contributors_url":"https://api.github.com/repos/somnathr/ceph/contributors","subscribers_url":"https://api.github.com/repos/somnathr/ceph/subscribers","subscription_url":"https://api.github.com/repos/somnathr/ceph/subscription","commits_url":"https://api.github.com/repos/somnathr/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/somnathr/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/somnathr/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/somnathr/ceph/issues/comments/{number}","contents_url":"https://api.github.com/repos/somnathr/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/somnathr/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/somnathr/ceph/merges","archive_url":"https://api.github.com/repos/somnathr/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/somnathr/ceph/downloads","issues_url":"https://api.github.com/repos/somnathr/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/somnathr/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/somnathr/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/somnathr/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/somnathr/ceph/labels{/name}","releases_url":"https://api.github.com/repos/somnathr/ceph/releases{/id}","created_at":"2013-10-23T00:06:19Z","updated_at":"2014-06-07T00:23:40Z","pushed_at":"2014-06-07T00:23:40Z","git_url":"git://github.com/somnathr/ceph.git","ssh_url":"git@github.com:somnathr/ceph.git","clone_url":"https://github.com/somnathr/ceph.git","svn_url":"https://github.com/somnathr/ceph","homepage":"http://ceph.com","size":75053,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"3b884becca32fb5fb9091a80e4603c3de262bdee","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?","gravatar_id":"05461e7575b7a9bb4499cec987f9da6d","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?","gravatar_id":"05461e7575b7a9bb4499cec987f9da6d","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments/{number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2014-06-09T23:07:32Z","pushed_at":"2014-06-09T23:07:32Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":227306,"stargazers_count":766,"watchers_count":766,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":339,"mirror_url":null,"open_issues_count":35,"forks":339,"open_issues":35,"watchers":766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/1897"},"html":{"href":"https://github.com/ceph/ceph/pull/1897"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/1897"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/1897/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/1897/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/1897/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/2dbd85c94cf27a1ff0419c5ea9359af7fe30e9b6"}}}}