GitHub PullRequestReviewCommentEvent at 2014-04-29 13:57:53
Repository: backbone
Actor: caseywebdev
Payload: {"comment":{"url":"https://api.github.com/repos/jashkenas/backbone/pulls/comments/12093707","id":12093707,"diff_hunk":"@@ -664,7 +664,8 @@\n       for (var i = 0, length = models.length; i < length; i++) {\n         var model = models[i] = this.get(models[i]);\n         if (!model) continue;\n-        delete this._byId[model.id];\n+        var id = this.generateId(model.attributes);\n+        if (id != null) delete this._byId[id];","path":"backbone.js","position":6,"original_position":6,"commit_id":"da98d446cb7a4d3643bec40720233d462fe958ff","original_commit_id":"da98d446cb7a4d3643bec40720233d462fe958ff","user":{"login":"caseywebdev","id":1181237,"avatar_url":"https://avatars.githubusercontent.com/u/1181237?","gravatar_id":"ca34681a45aff25c58c7c5ce9a8b0a32","url":"https://api.github.com/users/caseywebdev","html_url":"https://github.com/caseywebdev","followers_url":"https://api.github.com/users/caseywebdev/followers","following_url":"https://api.github.com/users/caseywebdev/following{/other_user}","gists_url":"https://api.github.com/users/caseywebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/caseywebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseywebdev/subscriptions","organizations_url":"https://api.github.com/users/caseywebdev/orgs","repos_url":"https://api.github.com/users/caseywebdev/repos","events_url":"https://api.github.com/users/caseywebdev/events{/privacy}","received_events_url":"https://api.github.com/users/caseywebdev/received_events","type":"User","site_admin":false},"body":"Added a guard here for consistency with the `delete`s in `Collection#_onModelEvent`. If we want to remove this guard (I'm indifferent as using `null` or `undefined` as an `id` seems strange to me), we should do it in `_onModelEvent` as well.","created_at":"2014-04-29T13:57:53Z","updated_at":"2014-04-29T13:57:53Z","html_url":"https://github.com/jashkenas/backbone/pull/3133#discussion_r12093707","pull_request_url":"https://api.github.com/repos/jashkenas/backbone/pulls/3133","_links":{"self":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/comments/12093707"},"html":{"href":"https://github.com/jashkenas/backbone/pull/3133#discussion_r12093707"},"pull_request":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/3133"}}}}