GitHub PullRequestReviewCommentEvent at 2014-10-09 19:07:30
Repository: geomesa
Actor: dmcwhorter
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/locationtech/geomesa/pulls/comments/18666879","id":18666879,"diff_hunk":"@@ -106,25 +101,26 @@ object StatWriter extends Runnable with Logging {\n    * Writes the stats.\n    *\n    * @param statsToWrite\n-   * @param connector\n    */\n-  def write(statsToWrite: Iterable[StatToWrite], connector: Connector): Unit =\n-    statsToWrite.groupBy(_.stat.getClass).foreach { case (clas, statsForClass) =>\n-      // get the appropriate transform for this type of stat\n-      val transform = clas match {\n-        case c if c == classOf[QueryStat] => QueryStatTransform.asInstanceOf[StatTransform[Stat]]\n-        case _ => throw new RuntimeException(\"Not implemented\")\n-      }\n+  def write(statsToWrite: Iterable[StatToWrite]): Unit =\n+    statsToWrite.groupBy(_.connector).foreach { case (connector, statsForConnector) =>","path":"geomesa-core/src/main/scala/org/locationtech/geomesa/core/stats/StatWriter.scala","position":94,"original_position":94,"commit_id":"e5cacae275bdeb94301c1e043bdfd8bfbd9ca253","original_commit_id":"e5cacae275bdeb94301c1e043bdfd8bfbd9ca253","user":{"login":"dmcwhorter","id":1111095,"avatar_url":"https://avatars.githubusercontent.com/u/1111095?v=2","gravatar_id":"","url":"https://api.github.com/users/dmcwhorter","html_url":"https://github.com/dmcwhorter","followers_url":"https://api.github.com/users/dmcwhorter/followers","following_url":"https://api.github.com/users/dmcwhorter/following{/other_user}","gists_url":"https://api.github.com/users/dmcwhorter/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcwhorter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcwhorter/subscriptions","organizations_url":"https://api.github.com/users/dmcwhorter/orgs","repos_url":"https://api.github.com/users/dmcwhorter/repos","events_url":"https://api.github.com/users/dmcwhorter/events{/privacy}","received_events_url":"https://api.github.com/users/dmcwhorter/received_events","type":"User","site_admin":false},"body":"might not be though, each groupBy seems to have a purpose","created_at":"2014-10-09T19:07:30Z","updated_at":"2014-10-09T19:07:30Z","html_url":"https://github.com/locationtech/geomesa/pull/322#discussion_r18666879","pull_request_url":"https://api.github.com/repos/locationtech/geomesa/pulls/322","_links":{"self":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/comments/18666879"},"html":{"href":"https://github.com/locationtech/geomesa/pull/322#discussion_r18666879"},"pull_request":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/322"}}},"pull_request":{"url":"https://api.github.com/repos/locationtech/geomesa/pulls/322","id":22492369,"html_url":"https://github.com/locationtech/geomesa/pull/322","diff_url":"https://github.com/locationtech/geomesa/pull/322.diff","patch_url":"https://github.com/locationtech/geomesa/pull/322.patch","issue_url":"https://api.github.com/repos/locationtech/geomesa/issues/322","number":322,"state":"open","locked":false,"title":"GEOMESA-423 fixing shared connectors across stat writers","user":{"login":"elahrvivaz","id":7715322,"avatar_url":"https://avatars.githubusercontent.com/u/7715322?v=2","gravatar_id":"","url":"https://api.github.com/users/elahrvivaz","html_url":"https://github.com/elahrvivaz","followers_url":"https://api.github.com/users/elahrvivaz/followers","following_url":"https://api.github.com/users/elahrvivaz/following{/other_user}","gists_url":"https://api.github.com/users/elahrvivaz/gists{/gist_id}","starred_url":"https://api.github.com/users/elahrvivaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elahrvivaz/subscriptions","organizations_url":"https://api.github.com/users/elahrvivaz/orgs","repos_url":"https://api.github.com/users/elahrvivaz/repos","events_url":"https://api.github.com/users/elahrvivaz/events{/privacy}","received_events_url":"https://api.github.com/users/elahrvivaz/received_events","type":"User","site_admin":false},"body":"* keeping connector with each stat\r\n* propagating errors in stat writer thread so that executor service will stop","created_at":"2014-10-09T13:20:37Z","updated_at":"2014-10-09T19:07:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66c9e65a2255c67636c97b890fceda1cfb1bf48b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/locationtech/geomesa/pulls/322/commits","review_comments_url":"https://api.github.com/repos/locationtech/geomesa/pulls/322/comments","review_comment_url":"https://api.github.com/repos/locationtech/geomesa/pulls/comments/{number}","comments_url":"https://api.github.com/repos/locationtech/geomesa/issues/322/comments","statuses_url":"https://api.github.com/repos/locationtech/geomesa/statuses/e5cacae275bdeb94301c1e043bdfd8bfbd9ca253","head":{"label":"elahrvivaz:f_stat_connector","ref":"f_stat_connector","sha":"e5cacae275bdeb94301c1e043bdfd8bfbd9ca253","user":{"login":"elahrvivaz","id":7715322,"avatar_url":"https://avatars.githubusercontent.com/u/7715322?v=2","gravatar_id":"","url":"https://api.github.com/users/elahrvivaz","html_url":"https://github.com/elahrvivaz","followers_url":"https://api.github.com/users/elahrvivaz/followers","following_url":"https://api.github.com/users/elahrvivaz/following{/other_user}","gists_url":"https://api.github.com/users/elahrvivaz/gists{/gist_id}","starred_url":"https://api.github.com/users/elahrvivaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elahrvivaz/subscriptions","organizations_url":"https://api.github.com/users/elahrvivaz/orgs","repos_url":"https://api.github.com/users/elahrvivaz/repos","events_url":"https://api.github.com/users/elahrvivaz/events{/privacy}","received_events_url":"https://api.github.com/users/elahrvivaz/received_events","type":"User","site_admin":false},"repo":{"id":20541167,"name":"geomesa","full_name":"elahrvivaz/geomesa","owner":{"login":"elahrvivaz","id":7715322,"avatar_url":"https://avatars.githubusercontent.com/u/7715322?v=2","gravatar_id":"","url":"https://api.github.com/users/elahrvivaz","html_url":"https://github.com/elahrvivaz","followers_url":"https://api.github.com/users/elahrvivaz/followers","following_url":"https://api.github.com/users/elahrvivaz/following{/other_user}","gists_url":"https://api.github.com/users/elahrvivaz/gists{/gist_id}","starred_url":"https://api.github.com/users/elahrvivaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elahrvivaz/subscriptions","organizations_url":"https://api.github.com/users/elahrvivaz/orgs","repos_url":"https://api.github.com/users/elahrvivaz/repos","events_url":"https://api.github.com/users/elahrvivaz/events{/privacy}","received_events_url":"https://api.github.com/users/elahrvivaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elahrvivaz/geomesa","description":"","fork":true,"url":"https://api.github.com/repos/elahrvivaz/geomesa","forks_url":"https://api.github.com/repos/elahrvivaz/geomesa/forks","keys_url":"https://api.github.com/repos/elahrvivaz/geomesa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elahrvivaz/geomesa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elahrvivaz/geomesa/teams","hooks_url":"https://api.github.com/repos/elahrvivaz/geomesa/hooks","issue_events_url":"https://api.github.com/repos/elahrvivaz/geomesa/issues/events{/number}","events_url":"https://api.github.com/repos/elahrvivaz/geomesa/events","assignees_url":"https://api.github.com/repos/elahrvivaz/geomesa/assignees{/user}","branches_url":"https://api.github.com/repos/elahrvivaz/geomesa/branches{/branch}","tags_url":"https://api.github.com/repos/elahrvivaz/geomesa/tags","blobs_url":"https://api.github.com/repos/elahrvivaz/geomesa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elahrvivaz/geomesa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elahrvivaz/geomesa/git/refs{/sha}","trees_url":"https://api.github.com/repos/elahrvivaz/geomesa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elahrvivaz/geomesa/statuses/{sha}","languages_url":"https://api.github.com/repos/elahrvivaz/geomesa/languages","stargazers_url":"https://api.github.com/repos/elahrvivaz/geomesa/stargazers","contributors_url":"https://api.github.com/repos/elahrvivaz/geomesa/contributors","subscribers_url":"https://api.github.com/repos/elahrvivaz/geomesa/subscribers","subscription_url":"https://api.github.com/repos/elahrvivaz/geomesa/subscription","commits_url":"https://api.github.com/repos/elahrvivaz/geomesa/commits{/sha}","git_commits_url":"https://api.github.com/repos/elahrvivaz/geomesa/git/commits{/sha}","comments_url":"https://api.github.com/repos/elahrvivaz/geomesa/comments{/number}","issue_comment_url":"https://api.github.com/repos/elahrvivaz/geomesa/issues/comments/{number}","contents_url":"https://api.github.com/repos/elahrvivaz/geomesa/contents/{+path}","compare_url":"https://api.github.com/repos/elahrvivaz/geomesa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elahrvivaz/geomesa/merges","archive_url":"https://api.github.com/repos/elahrvivaz/geomesa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elahrvivaz/geomesa/downloads","issues_url":"https://api.github.com/repos/elahrvivaz/geomesa/issues{/number}","pulls_url":"https://api.github.com/repos/elahrvivaz/geomesa/pulls{/number}","milestones_url":"https://api.github.com/repos/elahrvivaz/geomesa/milestones{/number}","notifications_url":"https://api.github.com/repos/elahrvivaz/geomesa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elahrvivaz/geomesa/labels{/name}","releases_url":"https://api.github.com/repos/elahrvivaz/geomesa/releases{/id}","created_at":"2014-06-05T20:51:54Z","updated_at":"2014-06-25T16:58:17Z","pushed_at":"2014-10-09T13:19:54Z","git_url":"git://github.com/elahrvivaz/geomesa.git","ssh_url":"git@github.com:elahrvivaz/geomesa.git","clone_url":"https://github.com/elahrvivaz/geomesa.git","svn_url":"https://github.com/elahrvivaz/geomesa","homepage":null,"size":6544,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"accumulo1.5.x/1.x"}},"base":{"label":"locationtech:accumulo1.5.x/1.x","ref":"accumulo1.5.x/1.x","sha":"87c74108c042260138130fb3fdbf38fdd10f133e","user":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars.githubusercontent.com/u/1991411?v=2","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"repo":{"id":13226069,"name":"geomesa","full_name":"locationtech/geomesa","owner":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars.githubusercontent.com/u/1991411?v=2","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/locationtech/geomesa","description":"","fork":false,"url":"https://api.github.com/repos/locationtech/geomesa","forks_url":"https://api.github.com/repos/locationtech/geomesa/forks","keys_url":"https://api.github.com/repos/locationtech/geomesa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/locationtech/geomesa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/locationtech/geomesa/teams","hooks_url":"https://api.github.com/repos/locationtech/geomesa/hooks","issue_events_url":"https://api.github.com/repos/locationtech/geomesa/issues/events{/number}","events_url":"https://api.github.com/repos/locationtech/geomesa/events","assignees_url":"https://api.github.com/repos/locationtech/geomesa/assignees{/user}","branches_url":"https://api.github.com/repos/locationtech/geomesa/branches{/branch}","tags_url":"https://api.github.com/repos/locationtech/geomesa/tags","blobs_url":"https://api.github.com/repos/locationtech/geomesa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/locationtech/geomesa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/locationtech/geomesa/git/refs{/sha}","trees_url":"https://api.github.com/repos/locationtech/geomesa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/locationtech/geomesa/statuses/{sha}","languages_url":"https://api.github.com/repos/locationtech/geomesa/languages","stargazers_url":"https://api.github.com/repos/locationtech/geomesa/stargazers","contributors_url":"https://api.github.com/repos/locationtech/geomesa/contributors","subscribers_url":"https://api.github.com/repos/locationtech/geomesa/subscribers","subscription_url":"https://api.github.com/repos/locationtech/geomesa/subscription","commits_url":"https://api.github.com/repos/locationtech/geomesa/commits{/sha}","git_commits_url":"https://api.github.com/repos/locationtech/geomesa/git/commits{/sha}","comments_url":"https://api.github.com/repos/locationtech/geomesa/comments{/number}","issue_comment_url":"https://api.github.com/repos/locationtech/geomesa/issues/comments/{number}","contents_url":"https://api.github.com/repos/locationtech/geomesa/contents/{+path}","compare_url":"https://api.github.com/repos/locationtech/geomesa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/locationtech/geomesa/merges","archive_url":"https://api.github.com/repos/locationtech/geomesa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/locationtech/geomesa/downloads","issues_url":"https://api.github.com/repos/locationtech/geomesa/issues{/number}","pulls_url":"https://api.github.com/repos/locationtech/geomesa/pulls{/number}","milestones_url":"https://api.github.com/repos/locationtech/geomesa/milestones{/number}","notifications_url":"https://api.github.com/repos/locationtech/geomesa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/locationtech/geomesa/labels{/name}","releases_url":"https://api.github.com/repos/locationtech/geomesa/releases{/id}","created_at":"2013-09-30T20:13:46Z","updated_at":"2014-10-06T07:27:27Z","pushed_at":"2014-10-08T19:37:13Z","git_url":"git://github.com/locationtech/geomesa.git","ssh_url":"git@github.com:locationtech/geomesa.git","clone_url":"https://github.com/locationtech/geomesa.git","svn_url":"https://github.com/locationtech/geomesa","homepage":null,"size":17365,"stargazers_count":29,"watchers_count":29,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":6,"forks":24,"open_issues":6,"watchers":29,"default_branch":"accumulo1.5.x/1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/322"},"html":{"href":"https://github.com/locationtech/geomesa/pull/322"},"issue":{"href":"https://api.github.com/repos/locationtech/geomesa/issues/322"},"comments":{"href":"https://api.github.com/repos/locationtech/geomesa/issues/322/comments"},"review_comments":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/322/comments"},"review_comment":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/322/commits"},"statuses":{"href":"https://api.github.com/repos/locationtech/geomesa/statuses/e5cacae275bdeb94301c1e043bdfd8bfbd9ca253"}}}}