GitHub PullRequestEvent at 2014-10-16 14:46:17
Repository: snowcrash
Actor: zdne
Payload: {"action":"closed","number":240,"pull_request":{"url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/240","id":22826904,"html_url":"https://github.com/apiaryio/snowcrash/pull/240","diff_url":"https://github.com/apiaryio/snowcrash/pull/240.diff","patch_url":"https://github.com/apiaryio/snowcrash/pull/240.patch","issue_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/240","number":240,"state":"closed","locked":false,"title":"Klokane/issue230 header names case insensitivity","user":{"login":"klokane","id":489973,"avatar_url":"https://avatars.githubusercontent.com/u/489973?v=2","gravatar_id":"","url":"https://api.github.com/users/klokane","html_url":"https://github.com/klokane","followers_url":"https://api.github.com/users/klokane/followers","following_url":"https://api.github.com/users/klokane/following{/other_user}","gists_url":"https://api.github.com/users/klokane/gists{/gist_id}","starred_url":"https://api.github.com/users/klokane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klokane/subscriptions","organizations_url":"https://api.github.com/users/klokane/orgs","repos_url":"https://api.github.com/users/klokane/repos","events_url":"https://api.github.com/users/klokane/events{/privacy}","received_events_url":"https://api.github.com/users/klokane/received_events","type":"User","site_admin":false},"body":"fix issue #230 - bug with header names case insensitivity.\r\nThere are 2 possible ways to fix problem\r\n - convert all headers to lower/upper case, but there is problem with backward compatibility\r\n - compare header names in case insensitive way\r\n\r\nSecond way is used in this solution to be backward compatible\r\n\r\nMain changes are in HeaderParser.h file, in methods findHeader() and isAllowedMultipleDefinition()\r\n\r\nDue to limitation of C++ 98 - missing function<>/bind<> functionality i slightly modify functors MatchFirsts and MatchFirstWith to allow inject comparable Predicate.\r\n\r\nTo be backward compatible - default compare method is used std::equal_to.<>\r\n\r\nThere is one more possible improvement into future functor IsIEqual<> should use locales via facets while std::to_lower is invoked.\r\n\r\nIt is open to discusion","created_at":"2014-10-16T01:12:27Z","updated_at":"2014-10-16T14:46:17Z","closed_at":"2014-10-16T14:46:17Z","merged_at":"2014-10-16T14:46:17Z","merge_commit_sha":"036a379ca36119a50e1a30fa810be39489ed0193","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/240/commits","review_comments_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/240/comments","review_comment_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/240/comments","statuses_url":"https://api.github.com/repos/apiaryio/snowcrash/statuses/ee242a5c9c6b43b8139651228a4eeeb5b325254a","head":{"label":"klokane:klokane/issue230-header-names-case-insensitivity","ref":"klokane/issue230-header-names-case-insensitivity","sha":"ee242a5c9c6b43b8139651228a4eeeb5b325254a","user":{"login":"klokane","id":489973,"avatar_url":"https://avatars.githubusercontent.com/u/489973?v=2","gravatar_id":"","url":"https://api.github.com/users/klokane","html_url":"https://github.com/klokane","followers_url":"https://api.github.com/users/klokane/followers","following_url":"https://api.github.com/users/klokane/following{/other_user}","gists_url":"https://api.github.com/users/klokane/gists{/gist_id}","starred_url":"https://api.github.com/users/klokane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klokane/subscriptions","organizations_url":"https://api.github.com/users/klokane/orgs","repos_url":"https://api.github.com/users/klokane/repos","events_url":"https://api.github.com/users/klokane/events{/privacy}","received_events_url":"https://api.github.com/users/klokane/received_events","type":"User","site_admin":false},"repo":{"id":24884051,"name":"snowcrash","full_name":"klokane/snowcrash","owner":{"login":"klokane","id":489973,"avatar_url":"https://avatars.githubusercontent.com/u/489973?v=2","gravatar_id":"","url":"https://api.github.com/users/klokane","html_url":"https://github.com/klokane","followers_url":"https://api.github.com/users/klokane/followers","following_url":"https://api.github.com/users/klokane/following{/other_user}","gists_url":"https://api.github.com/users/klokane/gists{/gist_id}","starred_url":"https://api.github.com/users/klokane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klokane/subscriptions","organizations_url":"https://api.github.com/users/klokane/orgs","repos_url":"https://api.github.com/users/klokane/repos","events_url":"https://api.github.com/users/klokane/events{/privacy}","received_events_url":"https://api.github.com/users/klokane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klokane/snowcrash","description":"API Blueprint Parser","fork":true,"url":"https://api.github.com/repos/klokane/snowcrash","forks_url":"https://api.github.com/repos/klokane/snowcrash/forks","keys_url":"https://api.github.com/repos/klokane/snowcrash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klokane/snowcrash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klokane/snowcrash/teams","hooks_url":"https://api.github.com/repos/klokane/snowcrash/hooks","issue_events_url":"https://api.github.com/repos/klokane/snowcrash/issues/events{/number}","events_url":"https://api.github.com/repos/klokane/snowcrash/events","assignees_url":"https://api.github.com/repos/klokane/snowcrash/assignees{/user}","branches_url":"https://api.github.com/repos/klokane/snowcrash/branches{/branch}","tags_url":"https://api.github.com/repos/klokane/snowcrash/tags","blobs_url":"https://api.github.com/repos/klokane/snowcrash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klokane/snowcrash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klokane/snowcrash/git/refs{/sha}","trees_url":"https://api.github.com/repos/klokane/snowcrash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klokane/snowcrash/statuses/{sha}","languages_url":"https://api.github.com/repos/klokane/snowcrash/languages","stargazers_url":"https://api.github.com/repos/klokane/snowcrash/stargazers","contributors_url":"https://api.github.com/repos/klokane/snowcrash/contributors","subscribers_url":"https://api.github.com/repos/klokane/snowcrash/subscribers","subscription_url":"https://api.github.com/repos/klokane/snowcrash/subscription","commits_url":"https://api.github.com/repos/klokane/snowcrash/commits{/sha}","git_commits_url":"https://api.github.com/repos/klokane/snowcrash/git/commits{/sha}","comments_url":"https://api.github.com/repos/klokane/snowcrash/comments{/number}","issue_comment_url":"https://api.github.com/repos/klokane/snowcrash/issues/comments/{number}","contents_url":"https://api.github.com/repos/klokane/snowcrash/contents/{+path}","compare_url":"https://api.github.com/repos/klokane/snowcrash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klokane/snowcrash/merges","archive_url":"https://api.github.com/repos/klokane/snowcrash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klokane/snowcrash/downloads","issues_url":"https://api.github.com/repos/klokane/snowcrash/issues{/number}","pulls_url":"https://api.github.com/repos/klokane/snowcrash/pulls{/number}","milestones_url":"https://api.github.com/repos/klokane/snowcrash/milestones{/number}","notifications_url":"https://api.github.com/repos/klokane/snowcrash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klokane/snowcrash/labels{/name}","releases_url":"https://api.github.com/repos/klokane/snowcrash/releases{/id}","created_at":"2014-10-07T09:22:04Z","updated_at":"2014-10-16T01:35:11Z","pushed_at":"2014-10-16T13:36:20Z","git_url":"git://github.com/klokane/snowcrash.git","ssh_url":"git@github.com:klokane/snowcrash.git","clone_url":"https://github.com/klokane/snowcrash.git","svn_url":"https://github.com/klokane/snowcrash","homepage":null,"size":2340,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apiaryio:master","ref":"master","sha":"c099026d1a15d934f9467d36156cdddfd33b58a3","user":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=2","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"repo":{"id":9173280,"name":"snowcrash","full_name":"apiaryio/snowcrash","owner":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=2","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apiaryio/snowcrash","description":"API Blueprint Parser","fork":false,"url":"https://api.github.com/repos/apiaryio/snowcrash","forks_url":"https://api.github.com/repos/apiaryio/snowcrash/forks","keys_url":"https://api.github.com/repos/apiaryio/snowcrash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apiaryio/snowcrash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apiaryio/snowcrash/teams","hooks_url":"https://api.github.com/repos/apiaryio/snowcrash/hooks","issue_events_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/events{/number}","events_url":"https://api.github.com/repos/apiaryio/snowcrash/events","assignees_url":"https://api.github.com/repos/apiaryio/snowcrash/assignees{/user}","branches_url":"https://api.github.com/repos/apiaryio/snowcrash/branches{/branch}","tags_url":"https://api.github.com/repos/apiaryio/snowcrash/tags","blobs_url":"https://api.github.com/repos/apiaryio/snowcrash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apiaryio/snowcrash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apiaryio/snowcrash/git/refs{/sha}","trees_url":"https://api.github.com/repos/apiaryio/snowcrash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apiaryio/snowcrash/statuses/{sha}","languages_url":"https://api.github.com/repos/apiaryio/snowcrash/languages","stargazers_url":"https://api.github.com/repos/apiaryio/snowcrash/stargazers","contributors_url":"https://api.github.com/repos/apiaryio/snowcrash/contributors","subscribers_url":"https://api.github.com/repos/apiaryio/snowcrash/subscribers","subscription_url":"https://api.github.com/repos/apiaryio/snowcrash/subscription","commits_url":"https://api.github.com/repos/apiaryio/snowcrash/commits{/sha}","git_commits_url":"https://api.github.com/repos/apiaryio/snowcrash/git/commits{/sha}","comments_url":"https://api.github.com/repos/apiaryio/snowcrash/comments{/number}","issue_comment_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/comments/{number}","contents_url":"https://api.github.com/repos/apiaryio/snowcrash/contents/{+path}","compare_url":"https://api.github.com/repos/apiaryio/snowcrash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apiaryio/snowcrash/merges","archive_url":"https://api.github.com/repos/apiaryio/snowcrash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apiaryio/snowcrash/downloads","issues_url":"https://api.github.com/repos/apiaryio/snowcrash/issues{/number}","pulls_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls{/number}","milestones_url":"https://api.github.com/repos/apiaryio/snowcrash/milestones{/number}","notifications_url":"https://api.github.com/repos/apiaryio/snowcrash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apiaryio/snowcrash/labels{/name}","releases_url":"https://api.github.com/repos/apiaryio/snowcrash/releases{/id}","created_at":"2013-04-02T15:23:04Z","updated_at":"2014-10-14T14:11:37Z","pushed_at":"2014-10-16T14:46:17Z","git_url":"git://github.com/apiaryio/snowcrash.git","ssh_url":"git@github.com:apiaryio/snowcrash.git","clone_url":"https://github.com/apiaryio/snowcrash.git","svn_url":"https://github.com/apiaryio/snowcrash","homepage":null,"size":10227,"stargazers_count":177,"watchers_count":177,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":24,"forks":30,"open_issues":24,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/240"},"html":{"href":"https://github.com/apiaryio/snowcrash/pull/240"},"issue":{"href":"https://api.github.com/repos/apiaryio/snowcrash/issues/240"},"comments":{"href":"https://api.github.com/repos/apiaryio/snowcrash/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/apiaryio/snowcrash/statuses/ee242a5c9c6b43b8139651228a4eeeb5b325254a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"zdne","id":613617,"avatar_url":"https://avatars.githubusercontent.com/u/613617?v=2","gravatar_id":"","url":"https://api.github.com/users/zdne","html_url":"https://github.com/zdne","followers_url":"https://api.github.com/users/zdne/followers","following_url":"https://api.github.com/users/zdne/following{/other_user}","gists_url":"https://api.github.com/users/zdne/gists{/gist_id}","starred_url":"https://api.github.com/users/zdne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdne/subscriptions","organizations_url":"https://api.github.com/users/zdne/orgs","repos_url":"https://api.github.com/users/zdne/repos","events_url":"https://api.github.com/users/zdne/events{/privacy}","received_events_url":"https://api.github.com/users/zdne/received_events","type":"User","site_admin":false},"comments":1,"review_comments":8,"commits":5,"additions":175,"deletions":6,"changed_files":5}}