GitHub PullRequestReviewCommentEvent at 2014-01-18 07:30:05
Repository: presto
Actor: electrum
Payload: {"comment":{"url":"https://api.github.com/repos/facebook/presto/pulls/comments/8986820","id":8986820,"diff_hunk":"@@ -167,8 +169,16 @@ public FunctionRegistry()\n                 .scalar(ColorFunctions.class)\n                 .build();\n \n-        functionsByName = Multimaps.index(functions, FunctionInfo.nameGetter());\n-        functionsByHandle = Maps.uniqueIndex(functions, FunctionInfo.handleGetter());\n+        functionsByName = ArrayListMultimap.create();\n+        functionsByHandle = new HashMap<>();\n+\n+        addFunctions(functions);\n+    }\n+\n+    public void addFunctions(List<FunctionInfo> functions)\n+    {\n+        functionsByName.putAll(Multimaps.index(functions, FunctionInfo.nameGetter()));","path":"presto-main/src/main/java/com/facebook/presto/metadata/FunctionRegistry.java","position":30,"original_position":30,"commit_id":"c439e4f43b2096381dbb66efbe355414abfe0934","original_commit_id":"c439e4f43b2096381dbb66efbe355414abfe0934","user":{"login":"electrum","id":9230,"avatar_url":"https://gravatar.com/avatar/47f6d7fe374642282d0095f502bd882b?d=https%3A%2F%2Fidenticons.github.com%2Fc879ec4dfeaa4d0f14f8f395a09941c2.png&r=x","gravatar_id":"47f6d7fe374642282d0095f502bd882b","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"body":"Good catch, I'll submit another pull request to fix this.","created_at":"2014-01-18T07:30:05Z","updated_at":"2014-01-18T07:30:05Z","html_url":"https://github.com/facebook/presto/pull/961#discussion_r8986820","pull_request_url":"https://api.github.com/repos/facebook/presto/pulls/961","_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments/8986820"},"html":{"href":"https://github.com/facebook/presto/pull/961#discussion_r8986820"},"pull_request":{"href":"https://api.github.com/repos/facebook/presto/pulls/961"}}}}