GitHub PullRequestEvent at 2014-03-04 15:52:22
Repository: zf2-documentation
Actor: weierophinney
Payload: {"action":"closed","number":1187,"pull_request":{"url":"https://api.github.com/repos/zendframework/zf2-documentation/pulls/1187","id":11546727,"html_url":"https://github.com/zendframework/zf2-documentation/pull/1187","diff_url":"https://github.com/zendframework/zf2-documentation/pull/1187.diff","patch_url":"https://github.com/zendframework/zf2-documentation/pull/1187.patch","issue_url":"https://api.github.com/repos/zendframework/zf2-documentation/issues/1187","number":1187,"state":"closed","title":"Correct conf topic","user":{"login":"gsc-frank","id":2673403,"avatar_url":"https://gravatar.com/avatar/9bee1ac5bf0a2b610a17a7231dfe9e08?d=https%3A%2F%2Fidenticons.github.com%2F2c55df84b7a7b7105d936936d03e597c.png&r=x","gravatar_id":"9bee1ac5bf0a2b610a17a7231dfe9e08","url":"https://api.github.com/users/gsc-frank","html_url":"https://github.com/gsc-frank","followers_url":"https://api.github.com/users/gsc-frank/followers","following_url":"https://api.github.com/users/gsc-frank/following{/other_user}","gists_url":"https://api.github.com/users/gsc-frank/gists{/gist_id}","starred_url":"https://api.github.com/users/gsc-frank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsc-frank/subscriptions","organizations_url":"https://api.github.com/users/gsc-frank/orgs","repos_url":"https://api.github.com/users/gsc-frank/repos","events_url":"https://api.github.com/users/gsc-frank/events{/privacy}","received_events_url":"https://api.github.com/users/gsc-frank/received_events","type":"User","site_admin":false},"body":"Right now the configuration is applied not applied in the way is described in the doc. Key lines are:\r\n\r\n- `$this->serviceManagers[$key]['configuration']['merged_config'] = $config[$sm['config_key']];` where the merged config is added to the  config array.\r\n- `foreach ($this->serviceManagers[$key]['configuration'] as $configs) {` where the config is actually merged.","created_at":"2014-01-15T18:31:59Z","updated_at":"2014-03-04T15:52:22Z","closed_at":"2014-03-04T15:52:22Z","merged_at":"2014-03-04T15:52:22Z","merge_commit_sha":"d4eaeb90538ea5ef43055bd75989b12d80467cf5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendframework/zf2-documentation/pulls/1187/commits","review_comments_url":"https://api.github.com/repos/zendframework/zf2-documentation/pulls/1187/comments","review_comment_url":"https://api.github.com/repos/zendframework/zf2-documentation/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zendframework/zf2-documentation/issues/1187/comments","statuses_url":"https://api.github.com/repos/zendframework/zf2-documentation/statuses/3e449b5762f06ecaf2f54024b0e738e311ca8767","head":{"label":"gsc-frank:correct-conf-topic","ref":"correct-conf-topic","sha":"3e449b5762f06ecaf2f54024b0e738e311ca8767","user":{"login":"gsc-frank","id":2673403,"avatar_url":"https://gravatar.com/avatar/9bee1ac5bf0a2b610a17a7231dfe9e08?d=https%3A%2F%2Fidenticons.github.com%2F2c55df84b7a7b7105d936936d03e597c.png&r=x","gravatar_id":"9bee1ac5bf0a2b610a17a7231dfe9e08","url":"https://api.github.com/users/gsc-frank","html_url":"https://github.com/gsc-frank","followers_url":"https://api.github.com/users/gsc-frank/followers","following_url":"https://api.github.com/users/gsc-frank/following{/other_user}","gists_url":"https://api.github.com/users/gsc-frank/gists{/gist_id}","starred_url":"https://api.github.com/users/gsc-frank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsc-frank/subscriptions","organizations_url":"https://api.github.com/users/gsc-frank/orgs","repos_url":"https://api.github.com/users/gsc-frank/repos","events_url":"https://api.github.com/users/gsc-frank/events{/privacy}","received_events_url":"https://api.github.com/users/gsc-frank/received_events","type":"User","site_admin":false},"repo":{"id":15938282,"name":"zf2-documentation","full_name":"gsc-frank/zf2-documentation","owner":{"login":"gsc-frank","id":2673403,"avatar_url":"https://gravatar.com/avatar/9bee1ac5bf0a2b610a17a7231dfe9e08?d=https%3A%2F%2Fidenticons.github.com%2F2c55df84b7a7b7105d936936d03e597c.png&r=x","gravatar_id":"9bee1ac5bf0a2b610a17a7231dfe9e08","url":"https://api.github.com/users/gsc-frank","html_url":"https://github.com/gsc-frank","followers_url":"https://api.github.com/users/gsc-frank/followers","following_url":"https://api.github.com/users/gsc-frank/following{/other_user}","gists_url":"https://api.github.com/users/gsc-frank/gists{/gist_id}","starred_url":"https://api.github.com/users/gsc-frank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsc-frank/subscriptions","organizations_url":"https://api.github.com/users/gsc-frank/orgs","repos_url":"https://api.github.com/users/gsc-frank/repos","events_url":"https://api.github.com/users/gsc-frank/events{/privacy}","received_events_url":"https://api.github.com/users/gsc-frank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gsc-frank/zf2-documentation","description":"Zend Framework 2 documentation sources","fork":true,"url":"https://api.github.com/repos/gsc-frank/zf2-documentation","forks_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/forks","keys_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/teams","hooks_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/hooks","issue_events_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/issues/events{/number}","events_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/events","assignees_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/assignees{/user}","branches_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/branches{/branch}","tags_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/tags","blobs_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/languages","stargazers_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/stargazers","contributors_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/contributors","subscribers_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/subscribers","subscription_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/subscription","commits_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/issues/comments/{number}","contents_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/contents/{+path}","compare_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/merges","archive_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/downloads","issues_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/issues{/number}","pulls_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/labels{/name}","releases_url":"https://api.github.com/repos/gsc-frank/zf2-documentation/releases{/id}","created_at":"2014-01-15T15:00:08Z","updated_at":"2014-03-04T15:52:22Z","pushed_at":"2014-01-15T18:30:26Z","git_url":"git://github.com/gsc-frank/zf2-documentation.git","ssh_url":"git@github.com:gsc-frank/zf2-documentation.git","clone_url":"https://github.com/gsc-frank/zf2-documentation.git","svn_url":"https://github.com/gsc-frank/zf2-documentation","homepage":null,"size":18070,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"zendframework:develop","ref":"develop","sha":"cf1962fc067ac4a3ccf625ce0a5875f5e40c38da","user":{"login":"zendframework","id":296074,"avatar_url":"https://gravatar.com/avatar/460576a0866d93fdacb597da4b90f233?d=https%3A%2F%2Fidenticons.github.com%2F292b7433472e2946c926bdca195cec8c.png&r=x","gravatar_id":"460576a0866d93fdacb597da4b90f233","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":4959563,"name":"zf2-documentation","full_name":"zendframework/zf2-documentation","owner":{"login":"zendframework","id":296074,"avatar_url":"https://gravatar.com/avatar/460576a0866d93fdacb597da4b90f233?d=https%3A%2F%2Fidenticons.github.com%2F292b7433472e2946c926bdca195cec8c.png&r=x","gravatar_id":"460576a0866d93fdacb597da4b90f233","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zf2-documentation","description":"Zend Framework 2 documentation sources","fork":false,"url":"https://api.github.com/repos/zendframework/zf2-documentation","forks_url":"https://api.github.com/repos/zendframework/zf2-documentation/forks","keys_url":"https://api.github.com/repos/zendframework/zf2-documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zf2-documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zf2-documentation/teams","hooks_url":"https://api.github.com/repos/zendframework/zf2-documentation/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zf2-documentation/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zf2-documentation/events","assignees_url":"https://api.github.com/repos/zendframework/zf2-documentation/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zf2-documentation/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zf2-documentation/tags","blobs_url":"https://api.github.com/repos/zendframework/zf2-documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zf2-documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zf2-documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zf2-documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zf2-documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zf2-documentation/languages","stargazers_url":"https://api.github.com/repos/zendframework/zf2-documentation/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zf2-documentation/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zf2-documentation/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zf2-documentation/subscription","commits_url":"https://api.github.com/repos/zendframework/zf2-documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zf2-documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zf2-documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zf2-documentation/issues/comments/{number}","contents_url":"https://api.github.com/repos/zendframework/zf2-documentation/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zf2-documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zf2-documentation/merges","archive_url":"https://api.github.com/repos/zendframework/zf2-documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zf2-documentation/downloads","issues_url":"https://api.github.com/repos/zendframework/zf2-documentation/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zf2-documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zf2-documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zf2-documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zf2-documentation/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zf2-documentation/releases{/id}","created_at":"2012-07-09T14:48:47Z","updated_at":"2014-03-04T15:51:05Z","pushed_at":"2014-03-04T15:52:22Z","git_url":"git://github.com/zendframework/zf2-documentation.git","ssh_url":"git@github.com:zendframework/zf2-documentation.git","clone_url":"https://github.com/zendframework/zf2-documentation.git","svn_url":"https://github.com/zendframework/zf2-documentation","homepage":null,"size":31136,"stargazers_count":177,"watchers_count":177,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":573,"mirror_url":null,"open_issues_count":59,"forks":573,"open_issues":59,"watchers":177,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zf2-documentation/pulls/1187"},"html":{"href":"https://github.com/zendframework/zf2-documentation/pull/1187"},"issue":{"href":"https://api.github.com/repos/zendframework/zf2-documentation/issues/1187"},"comments":{"href":"https://api.github.com/repos/zendframework/zf2-documentation/issues/1187/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zf2-documentation/pulls/1187/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zf2-documentation/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zf2-documentation/pulls/1187/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zf2-documentation/statuses/3e449b5762f06ecaf2f54024b0e738e311ca8767"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"weierophinney","id":25943,"avatar_url":"https://gravatar.com/avatar/bda768a042bd034f3f8090401aa77935?d=https%3A%2F%2Fidenticons.github.com%2Fbe5dfeb671c12d7520445b9292e10d13.png&r=x","gravatar_id":"bda768a042bd034f3f8090401aa77935","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":6,"changed_files":1}}