GitHub PullRequestEvent at 2014-02-25 23:59:08
Repository: czmq
Actor: hintjens
Payload: {"action":"closed","number":380,"pull_request":{"url":"https://api.github.com/repos/zeromq/czmq/pulls/380","id":12883768,"html_url":"https://github.com/zeromq/czmq/pull/380","diff_url":"https://github.com/zeromq/czmq/pull/380.diff","patch_url":"https://github.com/zeromq/czmq/pull/380.patch","issue_url":"https://api.github.com/repos/zeromq/czmq/issues/380","number":380,"state":"closed","title":"created working cmake build for czmq","user":{"login":"guruofquality","id":184117,"avatar_url":"https://gravatar.com/avatar/141689c528c5212754cbead4acd52b46?d=https%3A%2F%2Fidenticons.github.com%2F1481b74dbf0e060931408a85e0db9d50.png&r=x","gravatar_id":"141689c528c5212754cbead4acd52b46","url":"https://api.github.com/users/guruofquality","html_url":"https://github.com/guruofquality","followers_url":"https://api.github.com/users/guruofquality/followers","following_url":"https://api.github.com/users/guruofquality/following{/other_user}","gists_url":"https://api.github.com/users/guruofquality/gists{/gist_id}","starred_url":"https://api.github.com/users/guruofquality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guruofquality/subscriptions","organizations_url":"https://api.github.com/users/guruofquality/orgs","repos_url":"https://api.github.com/users/guruofquality/repos","events_url":"https://api.github.com/users/guruofquality/events{/privacy}","received_events_url":"https://api.github.com/users/guruofquality/received_events","type":"User","site_admin":false},"body":"I'm not sure of the history of the current CMake build for czmq, but it seems to be safe to say that it was broken (not building and missing some essentials). I rewrote the CMakeLists.txt to handle platform.h checks, pkgconfig stuff, library build, selftest... And tested the new CMakeLists.txt on an Ubuntu system with both libzmq and czmq installed to non-standard directories, and was able to build client applications against both libraries. So this pull should be fully functional.\r\n","created_at":"2014-02-25T01:07:28Z","updated_at":"2014-02-25T23:59:08Z","closed_at":"2014-02-25T23:59:07Z","merged_at":"2014-02-25T23:59:07Z","merge_commit_sha":"160e25e977c9523dc4a989382707cc722a3d19fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zeromq/czmq/pulls/380/commits","review_comments_url":"https://api.github.com/repos/zeromq/czmq/pulls/380/comments","review_comment_url":"https://api.github.com/repos/zeromq/czmq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zeromq/czmq/issues/380/comments","statuses_url":"https://api.github.com/repos/zeromq/czmq/statuses/433db897fc8049ac8ef1b84de27c04589f10c943","head":{"label":"guruofquality:cmake_work","ref":"cmake_work","sha":"433db897fc8049ac8ef1b84de27c04589f10c943","user":{"login":"guruofquality","id":184117,"avatar_url":"https://gravatar.com/avatar/141689c528c5212754cbead4acd52b46?d=https%3A%2F%2Fidenticons.github.com%2F1481b74dbf0e060931408a85e0db9d50.png&r=x","gravatar_id":"141689c528c5212754cbead4acd52b46","url":"https://api.github.com/users/guruofquality","html_url":"https://github.com/guruofquality","followers_url":"https://api.github.com/users/guruofquality/followers","following_url":"https://api.github.com/users/guruofquality/following{/other_user}","gists_url":"https://api.github.com/users/guruofquality/gists{/gist_id}","starred_url":"https://api.github.com/users/guruofquality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guruofquality/subscriptions","organizations_url":"https://api.github.com/users/guruofquality/orgs","repos_url":"https://api.github.com/users/guruofquality/repos","events_url":"https://api.github.com/users/guruofquality/events{/privacy}","received_events_url":"https://api.github.com/users/guruofquality/received_events","type":"User","site_admin":false},"repo":{"id":17156295,"name":"czmq","full_name":"guruofquality/czmq","owner":{"login":"guruofquality","id":184117,"avatar_url":"https://gravatar.com/avatar/141689c528c5212754cbead4acd52b46?d=https%3A%2F%2Fidenticons.github.com%2F1481b74dbf0e060931408a85e0db9d50.png&r=x","gravatar_id":"141689c528c5212754cbead4acd52b46","url":"https://api.github.com/users/guruofquality","html_url":"https://github.com/guruofquality","followers_url":"https://api.github.com/users/guruofquality/followers","following_url":"https://api.github.com/users/guruofquality/following{/other_user}","gists_url":"https://api.github.com/users/guruofquality/gists{/gist_id}","starred_url":"https://api.github.com/users/guruofquality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guruofquality/subscriptions","organizations_url":"https://api.github.com/users/guruofquality/orgs","repos_url":"https://api.github.com/users/guruofquality/repos","events_url":"https://api.github.com/users/guruofquality/events{/privacy}","received_events_url":"https://api.github.com/users/guruofquality/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guruofquality/czmq","description":"High-level C binding for ØMQ","fork":true,"url":"https://api.github.com/repos/guruofquality/czmq","forks_url":"https://api.github.com/repos/guruofquality/czmq/forks","keys_url":"https://api.github.com/repos/guruofquality/czmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guruofquality/czmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guruofquality/czmq/teams","hooks_url":"https://api.github.com/repos/guruofquality/czmq/hooks","issue_events_url":"https://api.github.com/repos/guruofquality/czmq/issues/events{/number}","events_url":"https://api.github.com/repos/guruofquality/czmq/events","assignees_url":"https://api.github.com/repos/guruofquality/czmq/assignees{/user}","branches_url":"https://api.github.com/repos/guruofquality/czmq/branches{/branch}","tags_url":"https://api.github.com/repos/guruofquality/czmq/tags","blobs_url":"https://api.github.com/repos/guruofquality/czmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guruofquality/czmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guruofquality/czmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/guruofquality/czmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guruofquality/czmq/statuses/{sha}","languages_url":"https://api.github.com/repos/guruofquality/czmq/languages","stargazers_url":"https://api.github.com/repos/guruofquality/czmq/stargazers","contributors_url":"https://api.github.com/repos/guruofquality/czmq/contributors","subscribers_url":"https://api.github.com/repos/guruofquality/czmq/subscribers","subscription_url":"https://api.github.com/repos/guruofquality/czmq/subscription","commits_url":"https://api.github.com/repos/guruofquality/czmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/guruofquality/czmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/guruofquality/czmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/guruofquality/czmq/issues/comments/{number}","contents_url":"https://api.github.com/repos/guruofquality/czmq/contents/{+path}","compare_url":"https://api.github.com/repos/guruofquality/czmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guruofquality/czmq/merges","archive_url":"https://api.github.com/repos/guruofquality/czmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guruofquality/czmq/downloads","issues_url":"https://api.github.com/repos/guruofquality/czmq/issues{/number}","pulls_url":"https://api.github.com/repos/guruofquality/czmq/pulls{/number}","milestones_url":"https://api.github.com/repos/guruofquality/czmq/milestones{/number}","notifications_url":"https://api.github.com/repos/guruofquality/czmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guruofquality/czmq/labels{/name}","releases_url":"https://api.github.com/repos/guruofquality/czmq/releases{/id}","created_at":"2014-02-25T00:46:30Z","updated_at":"2014-02-25T23:59:07Z","pushed_at":"2014-02-25T22:42:00Z","git_url":"git://github.com/guruofquality/czmq.git","ssh_url":"git@github.com:guruofquality/czmq.git","clone_url":"https://github.com/guruofquality/czmq.git","svn_url":"https://github.com/guruofquality/czmq","homepage":"czmq.zeromq.org","size":4066,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"zeromq:master","ref":"master","sha":"e831fffe502bcfd6a8607fe1819a5d16bfd4129d","user":{"login":"zeromq","id":109777,"avatar_url":"https://gravatar.com/avatar/94e1f7ce3031fbe9283be94b4465366e?d=https%3A%2F%2Fidenticons.github.com%2Fb836e7f63675ddf280b239c770ab9712.png&r=x","gravatar_id":"94e1f7ce3031fbe9283be94b4465366e","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"repo":{"id":1510809,"name":"czmq","full_name":"zeromq/czmq","owner":{"login":"zeromq","id":109777,"avatar_url":"https://gravatar.com/avatar/94e1f7ce3031fbe9283be94b4465366e?d=https%3A%2F%2Fidenticons.github.com%2Fb836e7f63675ddf280b239c770ab9712.png&r=x","gravatar_id":"94e1f7ce3031fbe9283be94b4465366e","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zeromq/czmq","description":"High-level C binding for ØMQ","fork":false,"url":"https://api.github.com/repos/zeromq/czmq","forks_url":"https://api.github.com/repos/zeromq/czmq/forks","keys_url":"https://api.github.com/repos/zeromq/czmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeromq/czmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeromq/czmq/teams","hooks_url":"https://api.github.com/repos/zeromq/czmq/hooks","issue_events_url":"https://api.github.com/repos/zeromq/czmq/issues/events{/number}","events_url":"https://api.github.com/repos/zeromq/czmq/events","assignees_url":"https://api.github.com/repos/zeromq/czmq/assignees{/user}","branches_url":"https://api.github.com/repos/zeromq/czmq/branches{/branch}","tags_url":"https://api.github.com/repos/zeromq/czmq/tags","blobs_url":"https://api.github.com/repos/zeromq/czmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeromq/czmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeromq/czmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeromq/czmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeromq/czmq/statuses/{sha}","languages_url":"https://api.github.com/repos/zeromq/czmq/languages","stargazers_url":"https://api.github.com/repos/zeromq/czmq/stargazers","contributors_url":"https://api.github.com/repos/zeromq/czmq/contributors","subscribers_url":"https://api.github.com/repos/zeromq/czmq/subscribers","subscription_url":"https://api.github.com/repos/zeromq/czmq/subscription","commits_url":"https://api.github.com/repos/zeromq/czmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeromq/czmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeromq/czmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeromq/czmq/issues/comments/{number}","contents_url":"https://api.github.com/repos/zeromq/czmq/contents/{+path}","compare_url":"https://api.github.com/repos/zeromq/czmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeromq/czmq/merges","archive_url":"https://api.github.com/repos/zeromq/czmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeromq/czmq/downloads","issues_url":"https://api.github.com/repos/zeromq/czmq/issues{/number}","pulls_url":"https://api.github.com/repos/zeromq/czmq/pulls{/number}","milestones_url":"https://api.github.com/repos/zeromq/czmq/milestones{/number}","notifications_url":"https://api.github.com/repos/zeromq/czmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeromq/czmq/labels{/name}","releases_url":"https://api.github.com/repos/zeromq/czmq/releases{/id}","created_at":"2011-03-22T10:42:27Z","updated_at":"2014-02-25T23:59:07Z","pushed_at":"2014-02-25T23:59:07Z","git_url":"git://github.com/zeromq/czmq.git","ssh_url":"git@github.com:zeromq/czmq.git","clone_url":"https://github.com/zeromq/czmq.git","svn_url":"https://github.com/zeromq/czmq","homepage":"czmq.zeromq.org","size":4066,"stargazers_count":216,"watchers_count":216,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":104,"mirror_url":null,"open_issues_count":6,"forks":104,"open_issues":6,"watchers":216,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/380"},"html":{"href":"https://github.com/zeromq/czmq/pull/380"},"issue":{"href":"https://api.github.com/repos/zeromq/czmq/issues/380"},"comments":{"href":"https://api.github.com/repos/zeromq/czmq/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/zeromq/czmq/statuses/433db897fc8049ac8ef1b84de27c04589f10c943"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hintjens","id":307976,"avatar_url":"https://gravatar.com/avatar/c1df3a0f97a9daac66cb6f35adb03368?d=https%3A%2F%2Fidenticons.github.com%2Fc12c417333f3ed8ae30c9f559688c2b5.png&r=x","gravatar_id":"c1df3a0f97a9daac66cb6f35adb03368","url":"https://api.github.com/users/hintjens","html_url":"https://github.com/hintjens","followers_url":"https://api.github.com/users/hintjens/followers","following_url":"https://api.github.com/users/hintjens/following{/other_user}","gists_url":"https://api.github.com/users/hintjens/gists{/gist_id}","starred_url":"https://api.github.com/users/hintjens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hintjens/subscriptions","organizations_url":"https://api.github.com/users/hintjens/orgs","repos_url":"https://api.github.com/users/hintjens/repos","events_url":"https://api.github.com/users/hintjens/events{/privacy}","received_events_url":"https://api.github.com/users/hintjens/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":5,"additions":264,"deletions":124,"changed_files":6}}