GitHub PullRequestEvent at 2014-11-08 17:30:10
Repository: BadFruit
Actor: IllegalCactus
Payload: {"action":"opened","number":17,"pull_request":{"url":"https://api.github.com/repos/brianmichel/BadFruit/pulls/17","id":24103691,"html_url":"https://github.com/brianmichel/BadFruit/pull/17","diff_url":"https://github.com/brianmichel/BadFruit/pull/17.diff","patch_url":"https://github.com/brianmichel/BadFruit/pull/17.patch","issue_url":"https://api.github.com/repos/brianmichel/BadFruit/issues/17","number":17,"state":"open","locked":false,"title":"Fix Rotten Tomatoes missing director","user":{"login":"IllegalCactus","id":2632211,"avatar_url":"https://avatars.githubusercontent.com/u/2632211?v=3","gravatar_id":"","url":"https://api.github.com/users/IllegalCactus","html_url":"https://github.com/IllegalCactus","followers_url":"https://api.github.com/users/IllegalCactus/followers","following_url":"https://api.github.com/users/IllegalCactus/following{/other_user}","gists_url":"https://api.github.com/users/IllegalCactus/gists{/gist_id}","starred_url":"https://api.github.com/users/IllegalCactus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IllegalCactus/subscriptions","organizations_url":"https://api.github.com/users/IllegalCactus/orgs","repos_url":"https://api.github.com/users/IllegalCactus/repos","events_url":"https://api.github.com/users/IllegalCactus/events{/privacy}","received_events_url":"https://api.github.com/users/IllegalCactus/received_events","type":"User","site_admin":false},"body":"When using Rotten Tomato's API to search for movies by name, the returned JSON list of films does not contain an `\"abridged_directors\"` attribute which is what BadFruit looks for.\r\n\r\nHowever, this attribute does appear when requesting details for a specific movie via ID.\r\n\r\nSee these two URL's for a demonstration:\r\n\r\n* http://api.rottentomatoes.com/api/public/v1.0/movies.json?apikey=YOURAPIKEY&q=avengers&page_limit=10&page=1\r\n\r\n* http://api.rottentomatoes.com/api/public/v1.0/movies/770672122?apikey=YOURAPIKEY\r\n\r\nThe BadFruit Movie class uses the first link to gather details for the movie. This results in `Movie.director` being nil. These changes add a new method in the Movie class for getting the director, using a call to the existing `Base.get_movie_info` method.\r\n\r\n","created_at":"2014-11-08T17:30:09Z","updated_at":"2014-11-08T17:30:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brianmichel/BadFruit/pulls/17/commits","review_comments_url":"https://api.github.com/repos/brianmichel/BadFruit/pulls/17/comments","review_comment_url":"https://api.github.com/repos/brianmichel/BadFruit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/brianmichel/BadFruit/issues/17/comments","statuses_url":"https://api.github.com/repos/brianmichel/BadFruit/statuses/a3d217bfb885998b563b79eebd0a54182a75f3d2","head":{"label":"IllegalCactus:master","ref":"master","sha":"a3d217bfb885998b563b79eebd0a54182a75f3d2","user":{"login":"IllegalCactus","id":2632211,"avatar_url":"https://avatars.githubusercontent.com/u/2632211?v=3","gravatar_id":"","url":"https://api.github.com/users/IllegalCactus","html_url":"https://github.com/IllegalCactus","followers_url":"https://api.github.com/users/IllegalCactus/followers","following_url":"https://api.github.com/users/IllegalCactus/following{/other_user}","gists_url":"https://api.github.com/users/IllegalCactus/gists{/gist_id}","starred_url":"https://api.github.com/users/IllegalCactus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IllegalCactus/subscriptions","organizations_url":"https://api.github.com/users/IllegalCactus/orgs","repos_url":"https://api.github.com/users/IllegalCactus/repos","events_url":"https://api.github.com/users/IllegalCactus/events{/privacy}","received_events_url":"https://api.github.com/users/IllegalCactus/received_events","type":"User","site_admin":false},"repo":{"id":26364454,"name":"BadFruit","full_name":"IllegalCactus/BadFruit","owner":{"login":"IllegalCactus","id":2632211,"avatar_url":"https://avatars.githubusercontent.com/u/2632211?v=3","gravatar_id":"","url":"https://api.github.com/users/IllegalCactus","html_url":"https://github.com/IllegalCactus","followers_url":"https://api.github.com/users/IllegalCactus/followers","following_url":"https://api.github.com/users/IllegalCactus/following{/other_user}","gists_url":"https://api.github.com/users/IllegalCactus/gists{/gist_id}","starred_url":"https://api.github.com/users/IllegalCactus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IllegalCactus/subscriptions","organizations_url":"https://api.github.com/users/IllegalCactus/orgs","repos_url":"https://api.github.com/users/IllegalCactus/repos","events_url":"https://api.github.com/users/IllegalCactus/events{/privacy}","received_events_url":"https://api.github.com/users/IllegalCactus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IllegalCactus/BadFruit","description":"Ruby Gem for Rotten Tomatoes","fork":true,"url":"https://api.github.com/repos/IllegalCactus/BadFruit","forks_url":"https://api.github.com/repos/IllegalCactus/BadFruit/forks","keys_url":"https://api.github.com/repos/IllegalCactus/BadFruit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IllegalCactus/BadFruit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IllegalCactus/BadFruit/teams","hooks_url":"https://api.github.com/repos/IllegalCactus/BadFruit/hooks","issue_events_url":"https://api.github.com/repos/IllegalCactus/BadFruit/issues/events{/number}","events_url":"https://api.github.com/repos/IllegalCactus/BadFruit/events","assignees_url":"https://api.github.com/repos/IllegalCactus/BadFruit/assignees{/user}","branches_url":"https://api.github.com/repos/IllegalCactus/BadFruit/branches{/branch}","tags_url":"https://api.github.com/repos/IllegalCactus/BadFruit/tags","blobs_url":"https://api.github.com/repos/IllegalCactus/BadFruit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IllegalCactus/BadFruit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IllegalCactus/BadFruit/git/refs{/sha}","trees_url":"https://api.github.com/repos/IllegalCactus/BadFruit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IllegalCactus/BadFruit/statuses/{sha}","languages_url":"https://api.github.com/repos/IllegalCactus/BadFruit/languages","stargazers_url":"https://api.github.com/repos/IllegalCactus/BadFruit/stargazers","contributors_url":"https://api.github.com/repos/IllegalCactus/BadFruit/contributors","subscribers_url":"https://api.github.com/repos/IllegalCactus/BadFruit/subscribers","subscription_url":"https://api.github.com/repos/IllegalCactus/BadFruit/subscription","commits_url":"https://api.github.com/repos/IllegalCactus/BadFruit/commits{/sha}","git_commits_url":"https://api.github.com/repos/IllegalCactus/BadFruit/git/commits{/sha}","comments_url":"https://api.github.com/repos/IllegalCactus/BadFruit/comments{/number}","issue_comment_url":"https://api.github.com/repos/IllegalCactus/BadFruit/issues/comments/{number}","contents_url":"https://api.github.com/repos/IllegalCactus/BadFruit/contents/{+path}","compare_url":"https://api.github.com/repos/IllegalCactus/BadFruit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IllegalCactus/BadFruit/merges","archive_url":"https://api.github.com/repos/IllegalCactus/BadFruit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IllegalCactus/BadFruit/downloads","issues_url":"https://api.github.com/repos/IllegalCactus/BadFruit/issues{/number}","pulls_url":"https://api.github.com/repos/IllegalCactus/BadFruit/pulls{/number}","milestones_url":"https://api.github.com/repos/IllegalCactus/BadFruit/milestones{/number}","notifications_url":"https://api.github.com/repos/IllegalCactus/BadFruit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IllegalCactus/BadFruit/labels{/name}","releases_url":"https://api.github.com/repos/IllegalCactus/BadFruit/releases{/id}","created_at":"2014-11-08T15:20:27Z","updated_at":"2014-11-08T16:04:43Z","pushed_at":"2014-11-08T17:17:32Z","git_url":"git://github.com/IllegalCactus/BadFruit.git","ssh_url":"git@github.com:IllegalCactus/BadFruit.git","clone_url":"https://github.com/IllegalCactus/BadFruit.git","svn_url":"https://github.com/IllegalCactus/BadFruit","homepage":"","size":113,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brianmichel:master","ref":"master","sha":"230c1520820f4491b7d080a9e570a4038b1f45b6","user":{"login":"brianmichel","id":63919,"avatar_url":"https://avatars.githubusercontent.com/u/63919?v=3","gravatar_id":"","url":"https://api.github.com/users/brianmichel","html_url":"https://github.com/brianmichel","followers_url":"https://api.github.com/users/brianmichel/followers","following_url":"https://api.github.com/users/brianmichel/following{/other_user}","gists_url":"https://api.github.com/users/brianmichel/gists{/gist_id}","starred_url":"https://api.github.com/users/brianmichel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianmichel/subscriptions","organizations_url":"https://api.github.com/users/brianmichel/orgs","repos_url":"https://api.github.com/users/brianmichel/repos","events_url":"https://api.github.com/users/brianmichel/events{/privacy}","received_events_url":"https://api.github.com/users/brianmichel/received_events","type":"User","site_admin":false},"repo":{"id":1617476,"name":"BadFruit","full_name":"brianmichel/BadFruit","owner":{"login":"brianmichel","id":63919,"avatar_url":"https://avatars.githubusercontent.com/u/63919?v=3","gravatar_id":"","url":"https://api.github.com/users/brianmichel","html_url":"https://github.com/brianmichel","followers_url":"https://api.github.com/users/brianmichel/followers","following_url":"https://api.github.com/users/brianmichel/following{/other_user}","gists_url":"https://api.github.com/users/brianmichel/gists{/gist_id}","starred_url":"https://api.github.com/users/brianmichel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianmichel/subscriptions","organizations_url":"https://api.github.com/users/brianmichel/orgs","repos_url":"https://api.github.com/users/brianmichel/repos","events_url":"https://api.github.com/users/brianmichel/events{/privacy}","received_events_url":"https://api.github.com/users/brianmichel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianmichel/BadFruit","description":"Ruby Gem for Rotten Tomatoes","fork":false,"url":"https://api.github.com/repos/brianmichel/BadFruit","forks_url":"https://api.github.com/repos/brianmichel/BadFruit/forks","keys_url":"https://api.github.com/repos/brianmichel/BadFruit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianmichel/BadFruit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianmichel/BadFruit/teams","hooks_url":"https://api.github.com/repos/brianmichel/BadFruit/hooks","issue_events_url":"https://api.github.com/repos/brianmichel/BadFruit/issues/events{/number}","events_url":"https://api.github.com/repos/brianmichel/BadFruit/events","assignees_url":"https://api.github.com/repos/brianmichel/BadFruit/assignees{/user}","branches_url":"https://api.github.com/repos/brianmichel/BadFruit/branches{/branch}","tags_url":"https://api.github.com/repos/brianmichel/BadFruit/tags","blobs_url":"https://api.github.com/repos/brianmichel/BadFruit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianmichel/BadFruit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianmichel/BadFruit/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianmichel/BadFruit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianmichel/BadFruit/statuses/{sha}","languages_url":"https://api.github.com/repos/brianmichel/BadFruit/languages","stargazers_url":"https://api.github.com/repos/brianmichel/BadFruit/stargazers","contributors_url":"https://api.github.com/repos/brianmichel/BadFruit/contributors","subscribers_url":"https://api.github.com/repos/brianmichel/BadFruit/subscribers","subscription_url":"https://api.github.com/repos/brianmichel/BadFruit/subscription","commits_url":"https://api.github.com/repos/brianmichel/BadFruit/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianmichel/BadFruit/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianmichel/BadFruit/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianmichel/BadFruit/issues/comments/{number}","contents_url":"https://api.github.com/repos/brianmichel/BadFruit/contents/{+path}","compare_url":"https://api.github.com/repos/brianmichel/BadFruit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianmichel/BadFruit/merges","archive_url":"https://api.github.com/repos/brianmichel/BadFruit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianmichel/BadFruit/downloads","issues_url":"https://api.github.com/repos/brianmichel/BadFruit/issues{/number}","pulls_url":"https://api.github.com/repos/brianmichel/BadFruit/pulls{/number}","milestones_url":"https://api.github.com/repos/brianmichel/BadFruit/milestones{/number}","notifications_url":"https://api.github.com/repos/brianmichel/BadFruit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianmichel/BadFruit/labels{/name}","releases_url":"https://api.github.com/repos/brianmichel/BadFruit/releases{/id}","created_at":"2011-04-15T04:12:56Z","updated_at":"2014-10-28T10:56:30Z","pushed_at":"2012-04-21T21:57:37Z","git_url":"git://github.com/brianmichel/BadFruit.git","ssh_url":"git@github.com:brianmichel/BadFruit.git","clone_url":"https://github.com/brianmichel/BadFruit.git","svn_url":"https://github.com/brianmichel/BadFruit","homepage":"","size":1182,"stargazers_count":40,"watchers_count":40,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":8,"forks":18,"open_issues":8,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brianmichel/BadFruit/pulls/17"},"html":{"href":"https://github.com/brianmichel/BadFruit/pull/17"},"issue":{"href":"https://api.github.com/repos/brianmichel/BadFruit/issues/17"},"comments":{"href":"https://api.github.com/repos/brianmichel/BadFruit/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/brianmichel/BadFruit/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/brianmichel/BadFruit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/brianmichel/BadFruit/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/brianmichel/BadFruit/statuses/a3d217bfb885998b563b79eebd0a54182a75f3d2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":14,"deletions":1,"changed_files":3}}