GitHub PullRequestReviewCommentEvent at 2014-10-19 15:15:43
Repository: symfony-docs
Actor: weaverryan
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/19060778","id":19060778,"diff_hunk":"@@ -472,6 +472,14 @@ you will trigger the ``kernel.terminate`` event where you can perform certain\n actions that you may have delayed in order to return the response as quickly\n as possible to the client (e.g. sending emails).\n \n+.. caution::\n+\n+    Internally, the HttpKernel makes use of the :phpfunction:`fastcgi_finish_request`\n+    PHP function. This means that at the moment only the `PHP FPM`_ server\n+    API is able to send a response to the client while the server's PHP process\n+    still performs some tasks. With all other server APIs, executing the ``kernel.terminate``\n+    event listeners works, but exetung them will block the connection.","path":"components/http_kernel/introduction.rst","position":10,"original_position":10,"commit_id":"5c3f6f5876d93871faac216a8f511c0278fdce8a","original_commit_id":"5c3f6f5876d93871faac216a8f511c0278fdce8a","user":{"login":"weaverryan","id":121003,"avatar_url":"https://avatars.githubusercontent.com/u/121003?v=2","gravatar_id":"","url":"https://api.github.com/users/weaverryan","html_url":"https://github.com/weaverryan","followers_url":"https://api.github.com/users/weaverryan/followers","following_url":"https://api.github.com/users/weaverryan/following{/other_user}","gists_url":"https://api.github.com/users/weaverryan/gists{/gist_id}","starred_url":"https://api.github.com/users/weaverryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaverryan/subscriptions","organizations_url":"https://api.github.com/users/weaverryan/orgs","repos_url":"https://api.github.com/users/weaverryan/repos","events_url":"https://api.github.com/users/weaverryan/events{/privacy}","received_events_url":"https://api.github.com/users/weaverryan/received_events","type":"User","site_admin":false},"body":"How about:\r\n\r\n>\r\nWith all other server API's, listeners to ``kernel.terminate`` are still executed, but\r\nthe response is not sent to the client until they are all completed.\r\n","created_at":"2014-10-19T15:15:43Z","updated_at":"2014-10-19T15:15:43Z","html_url":"https://github.com/symfony/symfony-docs/pull/4224#discussion_r19060778","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4224","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/19060778"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4224#discussion_r19060778"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4224"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4224","id":21192027,"html_url":"https://github.com/symfony/symfony-docs/pull/4224","diff_url":"https://github.com/symfony/symfony-docs/pull/4224.diff","patch_url":"https://github.com/symfony/symfony-docs/pull/4224.patch","issue_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4224","number":4224,"state":"open","locked":false,"title":"[Components][HttpKernel] outline implications of the kernel.terminate event","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=2","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Doc fix?      | yes\r\n| New docs?     | no\r\n| Applies to    | all\r\n| Fixed tickets | #4198","created_at":"2014-09-13T11:22:56Z","updated_at":"2014-10-19T15:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"215363a489ac1827e54b00262822088d55b8e038","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4224/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4224/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4224/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/5c3f6f5876d93871faac216a8f511c0278fdce8a","head":{"label":"xabbuh:issue-4198","ref":"issue-4198","sha":"5c3f6f5876d93871faac216a8f511c0278fdce8a","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=2","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"repo":{"id":8409924,"name":"symfony-docs","full_name":"xabbuh/symfony-docs","owner":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=2","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xabbuh/symfony-docs","description":"The Symfony2 documentation","fork":true,"url":"https://api.github.com/repos/xabbuh/symfony-docs","forks_url":"https://api.github.com/repos/xabbuh/symfony-docs/forks","keys_url":"https://api.github.com/repos/xabbuh/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xabbuh/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xabbuh/symfony-docs/teams","hooks_url":"https://api.github.com/repos/xabbuh/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/xabbuh/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/xabbuh/symfony-docs/events","assignees_url":"https://api.github.com/repos/xabbuh/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/xabbuh/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/xabbuh/symfony-docs/tags","blobs_url":"https://api.github.com/repos/xabbuh/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xabbuh/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xabbuh/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/xabbuh/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xabbuh/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/xabbuh/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/xabbuh/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/xabbuh/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/xabbuh/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/xabbuh/symfony-docs/subscription","commits_url":"https://api.github.com/repos/xabbuh/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/xabbuh/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/xabbuh/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/xabbuh/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/xabbuh/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/xabbuh/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xabbuh/symfony-docs/merges","archive_url":"https://api.github.com/repos/xabbuh/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xabbuh/symfony-docs/downloads","issues_url":"https://api.github.com/repos/xabbuh/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/xabbuh/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/xabbuh/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/xabbuh/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xabbuh/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/xabbuh/symfony-docs/releases{/id}","created_at":"2013-02-25T13:48:02Z","updated_at":"2014-06-20T15:05:27Z","pushed_at":"2014-10-19T13:17:27Z","git_url":"git://github.com/xabbuh/symfony-docs.git","ssh_url":"git@github.com:xabbuh/symfony-docs.git","clone_url":"https://github.com/xabbuh/symfony-docs.git","svn_url":"https://github.com/xabbuh/symfony-docs","homepage":"http://symfony.com/doc/current/","size":25017,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"e8964f4952d783b6b69ad2120eeefdc86960f4f7","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":521583,"name":"symfony-docs","full_name":"symfony/symfony-docs","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-docs","description":"The Symfony2 documentation","fork":false,"url":"https://api.github.com/repos/symfony/symfony-docs","forks_url":"https://api.github.com/repos/symfony/symfony-docs/forks","keys_url":"https://api.github.com/repos/symfony/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-docs/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-docs/events","assignees_url":"https://api.github.com/repos/symfony/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-docs/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-docs/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-docs/merges","archive_url":"https://api.github.com/repos/symfony/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-docs/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-docs/releases{/id}","created_at":"2010-02-17T08:43:51Z","updated_at":"2014-10-19T11:06:42Z","pushed_at":"2014-10-18T20:01:42Z","git_url":"git://github.com/symfony/symfony-docs.git","ssh_url":"git@github.com:symfony/symfony-docs.git","clone_url":"https://github.com/symfony/symfony-docs.git","svn_url":"https://github.com/symfony/symfony-docs","homepage":"http://symfony.com/doc/current/","size":54594,"stargazers_count":927,"watchers_count":927,"language":"Assembly","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1483,"mirror_url":null,"open_issues_count":217,"forks":1483,"open_issues":217,"watchers":927,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4224"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4224"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4224"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4224/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4224/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4224/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-docs/statuses/5c3f6f5876d93871faac216a8f511c0278fdce8a"}}}}