GitHub PullRequestEvent at 2014-12-01 11:10:01
Repository: certificate-transparency
Actor: laiqu
Payload: {"action":"opened","number":294,"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/294","id":25261054,"html_url":"https://github.com/google/certificate-transparency/pull/294","diff_url":"https://github.com/google/certificate-transparency/pull/294.diff","patch_url":"https://github.com/google/certificate-transparency/pull/294.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency/issues/294","number":294,"state":"open","locked":false,"title":"TLD checks for common names and dnsnames.","user":{"login":"laiqu","id":4343322,"avatar_url":"https://avatars.githubusercontent.com/u/4343322?v=3","gravatar_id":"","url":"https://api.github.com/users/laiqu","html_url":"https://github.com/laiqu","followers_url":"https://api.github.com/users/laiqu/followers","following_url":"https://api.github.com/users/laiqu/following{/other_user}","gists_url":"https://api.github.com/users/laiqu/gists{/gist_id}","starred_url":"https://api.github.com/users/laiqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laiqu/subscriptions","organizations_url":"https://api.github.com/users/laiqu/orgs","repos_url":"https://api.github.com/users/laiqu/repos","events_url":"https://api.github.com/users/laiqu/events{/privacy}","received_events_url":"https://api.github.com/users/laiqu/received_events","type":"User","site_admin":false},"body":"As in title. There is small ugly part that TLD check for common name and dnsname looks pretty much the same, but I wasn't sure where I could extract it. I'm also not sure if my approach to checking whether a name is probably an address or not is correct (I'm converting name to idna and checking whether it contains [a-z0-9-.*] characters). I could add this python package: https://pypi.python.org/pypi/rfc3987, so it will be more advanced.   ","created_at":"2014-12-01T11:10:01Z","updated_at":"2014-12-01T11:10:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency/pulls/294/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency/pulls/294/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/{number}","comments_url":"https://api.github.com/repos/google/certificate-transparency/issues/294/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/853355b2e9d99f72e27c82498276b392f2020bdc","head":{"label":"laiqu:tld_actual_checks","ref":"tld_actual_checks","sha":"853355b2e9d99f72e27c82498276b392f2020bdc","user":{"login":"laiqu","id":4343322,"avatar_url":"https://avatars.githubusercontent.com/u/4343322?v=3","gravatar_id":"","url":"https://api.github.com/users/laiqu","html_url":"https://github.com/laiqu","followers_url":"https://api.github.com/users/laiqu/followers","following_url":"https://api.github.com/users/laiqu/following{/other_user}","gists_url":"https://api.github.com/users/laiqu/gists{/gist_id}","starred_url":"https://api.github.com/users/laiqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laiqu/subscriptions","organizations_url":"https://api.github.com/users/laiqu/orgs","repos_url":"https://api.github.com/users/laiqu/repos","events_url":"https://api.github.com/users/laiqu/events{/privacy}","received_events_url":"https://api.github.com/users/laiqu/received_events","type":"User","site_admin":false},"repo":{"id":25521294,"name":"certificate-transparency","full_name":"laiqu/certificate-transparency","owner":{"login":"laiqu","id":4343322,"avatar_url":"https://avatars.githubusercontent.com/u/4343322?v=3","gravatar_id":"","url":"https://api.github.com/users/laiqu","html_url":"https://github.com/laiqu","followers_url":"https://api.github.com/users/laiqu/followers","following_url":"https://api.github.com/users/laiqu/following{/other_user}","gists_url":"https://api.github.com/users/laiqu/gists{/gist_id}","starred_url":"https://api.github.com/users/laiqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laiqu/subscriptions","organizations_url":"https://api.github.com/users/laiqu/orgs","repos_url":"https://api.github.com/users/laiqu/repos","events_url":"https://api.github.com/users/laiqu/events{/privacy}","received_events_url":"https://api.github.com/users/laiqu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laiqu/certificate-transparency","description":"Auditing for TLS certificates.","fork":true,"url":"https://api.github.com/repos/laiqu/certificate-transparency","forks_url":"https://api.github.com/repos/laiqu/certificate-transparency/forks","keys_url":"https://api.github.com/repos/laiqu/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laiqu/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laiqu/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/laiqu/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/laiqu/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/laiqu/certificate-transparency/events","assignees_url":"https://api.github.com/repos/laiqu/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/laiqu/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/laiqu/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/laiqu/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laiqu/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laiqu/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/laiqu/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laiqu/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/laiqu/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/laiqu/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/laiqu/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/laiqu/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/laiqu/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/laiqu/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/laiqu/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/laiqu/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/laiqu/certificate-transparency/issues/comments/{number}","contents_url":"https://api.github.com/repos/laiqu/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/laiqu/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laiqu/certificate-transparency/merges","archive_url":"https://api.github.com/repos/laiqu/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laiqu/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/laiqu/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/laiqu/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/laiqu/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/laiqu/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laiqu/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/laiqu/certificate-transparency/releases{/id}","created_at":"2014-10-21T12:35:50Z","updated_at":"2014-11-28T15:10:29Z","pushed_at":"2014-12-01T11:07:18Z","git_url":"git://github.com/laiqu/certificate-transparency.git","ssh_url":"git@github.com:laiqu/certificate-transparency.git","clone_url":"https://github.com/laiqu/certificate-transparency.git","svn_url":"https://github.com/laiqu/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":17651,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"79bdae2f2f3e95b70e1a80efb575078080f46296","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":19989605,"name":"certificate-transparency","full_name":"google/certificate-transparency","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/certificate-transparency","description":"Auditing for TLS certificates.","fork":false,"url":"https://api.github.com/repos/google/certificate-transparency","forks_url":"https://api.github.com/repos/google/certificate-transparency/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency/issues/comments/{number}","contents_url":"https://api.github.com/repos/google/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency/releases{/id}","created_at":"2014-05-20T17:03:47Z","updated_at":"2014-11-28T19:16:24Z","pushed_at":"2014-11-30T20:30:54Z","git_url":"git://github.com/google/certificate-transparency.git","ssh_url":"git@github.com:google/certificate-transparency.git","clone_url":"https://github.com/google/certificate-transparency.git","svn_url":"https://github.com/google/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":22445,"stargazers_count":72,"watchers_count":72,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":24,"forks":27,"open_issues":24,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/294"},"html":{"href":"https://github.com/google/certificate-transparency/pull/294"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/294"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency/statuses/853355b2e9d99f72e27c82498276b392f2020bdc"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":284,"deletions":5,"changed_files":6}}