GitHub PullRequestReviewCommentEvent at 2014-07-07 20:44:10
Repository: baking
Actor: kofarrell
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/h2r/baking/pulls/comments/14621030","id":14621030,"diff_hunk":"@@ -16,7 +19,83 @@ public AllowMoving(String name, Domain domain, IngredientRecipe ingredient) {\n \t@Override\n \t// Default true, since only logic needed is in moveAction's isApplicableInState().\n \tpublic boolean isTrue(State s, String[] params) {\n-\t\treturn true;\n+\t\tObjectInstance space = s.getObject(params[2]);\n+\t\tObjectInstance container = s.getObject(params[1]);\n+\t\tObjectInstance current_space = s.getObject(ContainerFactory.getSpaceName(container));\n+\t\t\n+\t\tSet<String> contents = ContainerFactory.getContentNames(container);\n+\t\t\n+\t\t/*if (ContainerFactory.isEmptyContainer(container)) {","path":"src/edu/brown/cs/h2r/baking/PropositionalFunctions/AllowMoving.java","position":23,"original_position":23,"commit_id":"6932c9aaa67a5f9198749fbd5be32ede5543c7c5","original_commit_id":"6932c9aaa67a5f9198749fbd5be32ede5543c7c5","user":{"login":"kofarrell","id":6979802,"avatar_url":"https://avatars.githubusercontent.com/u/6979802?","gravatar_id":"cbf549b7e587312ae9fcbb11f9a6ca24","url":"https://api.github.com/users/kofarrell","html_url":"https://github.com/kofarrell","followers_url":"https://api.github.com/users/kofarrell/followers","following_url":"https://api.github.com/users/kofarrell/following{/other_user}","gists_url":"https://api.github.com/users/kofarrell/gists{/gist_id}","starred_url":"https://api.github.com/users/kofarrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofarrell/subscriptions","organizations_url":"https://api.github.com/users/kofarrell/orgs","repos_url":"https://api.github.com/users/kofarrell/repos","events_url":"https://api.github.com/users/kofarrell/events{/privacy}","received_events_url":"https://api.github.com/users/kofarrell/received_events","type":"User","site_admin":false},"body":"removed","created_at":"2014-07-07T20:44:10Z","updated_at":"2014-07-07T20:44:10Z","html_url":"https://github.com/h2r/baking/pull/32#discussion_r14621030","pull_request_url":"https://api.github.com/repos/h2r/baking/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/h2r/baking/pulls/comments/14621030"},"html":{"href":"https://github.com/h2r/baking/pull/32#discussion_r14621030"},"pull_request":{"href":"https://api.github.com/repos/h2r/baking/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/h2r/baking/pulls/32","id":18058009,"html_url":"https://github.com/h2r/baking/pull/32","diff_url":"https://github.com/h2r/baking/pull/32.diff","patch_url":"https://github.com/h2r/baking/pull/32.patch","issue_url":"https://api.github.com/repos/h2r/baking/issues/32","number":32,"state":"open","title":"Full planning integration into master","user":{"login":"kofarrell","id":6979802,"avatar_url":"https://avatars.githubusercontent.com/u/6979802?","gravatar_id":"cbf549b7e587312ae9fcbb11f9a6ca24","url":"https://api.github.com/users/kofarrell","html_url":"https://github.com/kofarrell","followers_url":"https://api.github.com/users/kofarrell/followers","following_url":"https://api.github.com/users/kofarrell/following{/other_user}","gists_url":"https://api.github.com/users/kofarrell/gists{/gist_id}","starred_url":"https://api.github.com/users/kofarrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofarrell/subscriptions","organizations_url":"https://api.github.com/users/kofarrell/orgs","repos_url":"https://api.github.com/users/kofarrell/repos","events_url":"https://api.github.com/users/kofarrell/events{/privacy}","received_events_url":"https://api.github.com/users/kofarrell/received_events","type":"User","site_admin":false},"body":"Knowledgebase phase of project is complete!","created_at":"2014-07-07T17:41:45Z","updated_at":"2014-07-07T20:44:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8b203ce68efcc99fdb442980331b155ad51d976","assignee":{"login":"brawner","id":1044986,"avatar_url":"https://avatars.githubusercontent.com/u/1044986?","gravatar_id":"68ef29dce5cc8f01a4d01c17a97226bd","url":"https://api.github.com/users/brawner","html_url":"https://github.com/brawner","followers_url":"https://api.github.com/users/brawner/followers","following_url":"https://api.github.com/users/brawner/following{/other_user}","gists_url":"https://api.github.com/users/brawner/gists{/gist_id}","starred_url":"https://api.github.com/users/brawner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brawner/subscriptions","organizations_url":"https://api.github.com/users/brawner/orgs","repos_url":"https://api.github.com/users/brawner/repos","events_url":"https://api.github.com/users/brawner/events{/privacy}","received_events_url":"https://api.github.com/users/brawner/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/h2r/baking/pulls/32/commits","review_comments_url":"https://api.github.com/repos/h2r/baking/pulls/32/comments","review_comment_url":"https://api.github.com/repos/h2r/baking/pulls/comments/{number}","comments_url":"https://api.github.com/repos/h2r/baking/issues/32/comments","statuses_url":"https://api.github.com/repos/h2r/baking/statuses/6932c9aaa67a5f9198749fbd5be32ede5543c7c5","head":{"label":"h2r:Knowledgebase","ref":"Knowledgebase","sha":"6932c9aaa67a5f9198749fbd5be32ede5543c7c5","user":{"login":"h2r","id":5818805,"avatar_url":"https://avatars.githubusercontent.com/u/5818805?","gravatar_id":null,"url":"https://api.github.com/users/h2r","html_url":"https://github.com/h2r","followers_url":"https://api.github.com/users/h2r/followers","following_url":"https://api.github.com/users/h2r/following{/other_user}","gists_url":"https://api.github.com/users/h2r/gists{/gist_id}","starred_url":"https://api.github.com/users/h2r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2r/subscriptions","organizations_url":"https://api.github.com/users/h2r/orgs","repos_url":"https://api.github.com/users/h2r/repos","events_url":"https://api.github.com/users/h2r/events{/privacy}","received_events_url":"https://api.github.com/users/h2r/received_events","type":"Organization","site_admin":false},"repo":{"id":14219828,"name":"baking","full_name":"h2r/baking","owner":{"login":"h2r","id":5818805,"avatar_url":"https://avatars.githubusercontent.com/u/5818805?","gravatar_id":null,"url":"https://api.github.com/users/h2r","html_url":"https://github.com/h2r","followers_url":"https://api.github.com/users/h2r/followers","following_url":"https://api.github.com/users/h2r/following{/other_user}","gists_url":"https://api.github.com/users/h2r/gists{/gist_id}","starred_url":"https://api.github.com/users/h2r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2r/subscriptions","organizations_url":"https://api.github.com/users/h2r/orgs","repos_url":"https://api.github.com/users/h2r/repos","events_url":"https://api.github.com/users/h2r/events{/privacy}","received_events_url":"https://api.github.com/users/h2r/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/h2r/baking","description":"For learning and planning in baking shared autonomy","fork":false,"url":"https://api.github.com/repos/h2r/baking","forks_url":"https://api.github.com/repos/h2r/baking/forks","keys_url":"https://api.github.com/repos/h2r/baking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2r/baking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2r/baking/teams","hooks_url":"https://api.github.com/repos/h2r/baking/hooks","issue_events_url":"https://api.github.com/repos/h2r/baking/issues/events{/number}","events_url":"https://api.github.com/repos/h2r/baking/events","assignees_url":"https://api.github.com/repos/h2r/baking/assignees{/user}","branches_url":"https://api.github.com/repos/h2r/baking/branches{/branch}","tags_url":"https://api.github.com/repos/h2r/baking/tags","blobs_url":"https://api.github.com/repos/h2r/baking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2r/baking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2r/baking/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2r/baking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2r/baking/statuses/{sha}","languages_url":"https://api.github.com/repos/h2r/baking/languages","stargazers_url":"https://api.github.com/repos/h2r/baking/stargazers","contributors_url":"https://api.github.com/repos/h2r/baking/contributors","subscribers_url":"https://api.github.com/repos/h2r/baking/subscribers","subscription_url":"https://api.github.com/repos/h2r/baking/subscription","commits_url":"https://api.github.com/repos/h2r/baking/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2r/baking/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2r/baking/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2r/baking/issues/comments/{number}","contents_url":"https://api.github.com/repos/h2r/baking/contents/{+path}","compare_url":"https://api.github.com/repos/h2r/baking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2r/baking/merges","archive_url":"https://api.github.com/repos/h2r/baking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2r/baking/downloads","issues_url":"https://api.github.com/repos/h2r/baking/issues{/number}","pulls_url":"https://api.github.com/repos/h2r/baking/pulls{/number}","milestones_url":"https://api.github.com/repos/h2r/baking/milestones{/number}","notifications_url":"https://api.github.com/repos/h2r/baking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2r/baking/labels{/name}","releases_url":"https://api.github.com/repos/h2r/baking/releases{/id}","created_at":"2013-11-08T00:13:08Z","updated_at":"2014-06-25T19:04:19Z","pushed_at":"2014-07-07T19:05:08Z","git_url":"git://github.com/h2r/baking.git","ssh_url":"git@github.com:h2r/baking.git","clone_url":"https://github.com/h2r/baking.git","svn_url":"https://github.com/h2r/baking","homepage":null,"size":5114,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"h2r:master","ref":"master","sha":"3ec6155b975bacf047ec6b4eb253101f44e71b3a","user":{"login":"h2r","id":5818805,"avatar_url":"https://avatars.githubusercontent.com/u/5818805?","gravatar_id":null,"url":"https://api.github.com/users/h2r","html_url":"https://github.com/h2r","followers_url":"https://api.github.com/users/h2r/followers","following_url":"https://api.github.com/users/h2r/following{/other_user}","gists_url":"https://api.github.com/users/h2r/gists{/gist_id}","starred_url":"https://api.github.com/users/h2r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2r/subscriptions","organizations_url":"https://api.github.com/users/h2r/orgs","repos_url":"https://api.github.com/users/h2r/repos","events_url":"https://api.github.com/users/h2r/events{/privacy}","received_events_url":"https://api.github.com/users/h2r/received_events","type":"Organization","site_admin":false},"repo":{"id":14219828,"name":"baking","full_name":"h2r/baking","owner":{"login":"h2r","id":5818805,"avatar_url":"https://avatars.githubusercontent.com/u/5818805?","gravatar_id":null,"url":"https://api.github.com/users/h2r","html_url":"https://github.com/h2r","followers_url":"https://api.github.com/users/h2r/followers","following_url":"https://api.github.com/users/h2r/following{/other_user}","gists_url":"https://api.github.com/users/h2r/gists{/gist_id}","starred_url":"https://api.github.com/users/h2r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2r/subscriptions","organizations_url":"https://api.github.com/users/h2r/orgs","repos_url":"https://api.github.com/users/h2r/repos","events_url":"https://api.github.com/users/h2r/events{/privacy}","received_events_url":"https://api.github.com/users/h2r/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/h2r/baking","description":"For learning and planning in baking shared autonomy","fork":false,"url":"https://api.github.com/repos/h2r/baking","forks_url":"https://api.github.com/repos/h2r/baking/forks","keys_url":"https://api.github.com/repos/h2r/baking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2r/baking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2r/baking/teams","hooks_url":"https://api.github.com/repos/h2r/baking/hooks","issue_events_url":"https://api.github.com/repos/h2r/baking/issues/events{/number}","events_url":"https://api.github.com/repos/h2r/baking/events","assignees_url":"https://api.github.com/repos/h2r/baking/assignees{/user}","branches_url":"https://api.github.com/repos/h2r/baking/branches{/branch}","tags_url":"https://api.github.com/repos/h2r/baking/tags","blobs_url":"https://api.github.com/repos/h2r/baking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2r/baking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2r/baking/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2r/baking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2r/baking/statuses/{sha}","languages_url":"https://api.github.com/repos/h2r/baking/languages","stargazers_url":"https://api.github.com/repos/h2r/baking/stargazers","contributors_url":"https://api.github.com/repos/h2r/baking/contributors","subscribers_url":"https://api.github.com/repos/h2r/baking/subscribers","subscription_url":"https://api.github.com/repos/h2r/baking/subscription","commits_url":"https://api.github.com/repos/h2r/baking/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2r/baking/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2r/baking/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2r/baking/issues/comments/{number}","contents_url":"https://api.github.com/repos/h2r/baking/contents/{+path}","compare_url":"https://api.github.com/repos/h2r/baking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2r/baking/merges","archive_url":"https://api.github.com/repos/h2r/baking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2r/baking/downloads","issues_url":"https://api.github.com/repos/h2r/baking/issues{/number}","pulls_url":"https://api.github.com/repos/h2r/baking/pulls{/number}","milestones_url":"https://api.github.com/repos/h2r/baking/milestones{/number}","notifications_url":"https://api.github.com/repos/h2r/baking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2r/baking/labels{/name}","releases_url":"https://api.github.com/repos/h2r/baking/releases{/id}","created_at":"2013-11-08T00:13:08Z","updated_at":"2014-06-25T19:04:19Z","pushed_at":"2014-07-07T19:05:08Z","git_url":"git://github.com/h2r/baking.git","ssh_url":"git@github.com:h2r/baking.git","clone_url":"https://github.com/h2r/baking.git","svn_url":"https://github.com/h2r/baking","homepage":null,"size":5114,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/h2r/baking/pulls/32"},"html":{"href":"https://github.com/h2r/baking/pull/32"},"issue":{"href":"https://api.github.com/repos/h2r/baking/issues/32"},"comments":{"href":"https://api.github.com/repos/h2r/baking/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/h2r/baking/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/h2r/baking/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/h2r/baking/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/h2r/baking/statuses/6932c9aaa67a5f9198749fbd5be32ede5543c7c5"}}}}