GitHub PullRequestEvent at 2014-04-25 07:26:27
Repository: qml2048
Actor: raandoom
Payload: {"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/raandoom/qml2048/pulls/7","id":15154681,"html_url":"https://github.com/raandoom/qml2048/pull/7","diff_url":"https://github.com/raandoom/qml2048/pull/7.diff","patch_url":"https://github.com/raandoom/qml2048/pull/7.patch","issue_url":"https://api.github.com/repos/raandoom/qml2048/issues/7","number":7,"state":"closed","title":"Fix highscore saving","user":{"login":"dicksonleong","id":2051511,"avatar_url":"https://avatars.githubusercontent.com/u/2051511?","gravatar_id":"a1b51ec64a9cde6c909b2711065125ea","url":"https://api.github.com/users/dicksonleong","html_url":"https://github.com/dicksonleong","followers_url":"https://api.github.com/users/dicksonleong/followers","following_url":"https://api.github.com/users/dicksonleong/following{/other_user}","gists_url":"https://api.github.com/users/dicksonleong/gists{/gist_id}","starred_url":"https://api.github.com/users/dicksonleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dicksonleong/subscriptions","organizations_url":"https://api.github.com/users/dicksonleong/orgs","repos_url":"https://api.github.com/users/dicksonleong/repos","events_url":"https://api.github.com/users/dicksonleong/events{/privacy}","received_events_url":"https://api.github.com/users/dicksonleong/received_events","type":"User","site_admin":false},"body":"* **Prevent saving of 0 highscore to database at startup**\r\n\r\nScoreArea.reset() is called on startup causing saving 0 highscore to database\r\n\r\n* **connect slider.valueChanged to newGameRequest after component completed**\r\n\r\nslider.valueChanged will called even *before* component is completed and the slider is not moved. This will cause newGameRequest called twice (one when slider valueChanged, one when component completed)","created_at":"2014-04-25T05:05:54Z","updated_at":"2014-04-25T07:26:26Z","closed_at":"2014-04-25T07:26:26Z","merged_at":null,"merge_commit_sha":"fed97e4cbaf95eafb62c766b2318c688fa7da22c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/raandoom/qml2048/pulls/7/commits","review_comments_url":"https://api.github.com/repos/raandoom/qml2048/pulls/7/comments","review_comment_url":"https://api.github.com/repos/raandoom/qml2048/pulls/comments/{number}","comments_url":"https://api.github.com/repos/raandoom/qml2048/issues/7/comments","statuses_url":"https://api.github.com/repos/raandoom/qml2048/statuses/4b16257bde4f21a8d554a4f3a972f3eab4965235","head":{"label":"dicksonleong:fix-highscore","ref":"fix-highscore","sha":"4b16257bde4f21a8d554a4f3a972f3eab4965235","user":{"login":"dicksonleong","id":2051511,"avatar_url":"https://avatars.githubusercontent.com/u/2051511?","gravatar_id":"a1b51ec64a9cde6c909b2711065125ea","url":"https://api.github.com/users/dicksonleong","html_url":"https://github.com/dicksonleong","followers_url":"https://api.github.com/users/dicksonleong/followers","following_url":"https://api.github.com/users/dicksonleong/following{/other_user}","gists_url":"https://api.github.com/users/dicksonleong/gists{/gist_id}","starred_url":"https://api.github.com/users/dicksonleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dicksonleong/subscriptions","organizations_url":"https://api.github.com/users/dicksonleong/orgs","repos_url":"https://api.github.com/users/dicksonleong/repos","events_url":"https://api.github.com/users/dicksonleong/events{/privacy}","received_events_url":"https://api.github.com/users/dicksonleong/received_events","type":"User","site_admin":false},"repo":{"id":18873590,"name":"qml2048","full_name":"dicksonleong/qml2048","owner":{"login":"dicksonleong","id":2051511,"avatar_url":"https://avatars.githubusercontent.com/u/2051511?","gravatar_id":"a1b51ec64a9cde6c909b2711065125ea","url":"https://api.github.com/users/dicksonleong","html_url":"https://github.com/dicksonleong","followers_url":"https://api.github.com/users/dicksonleong/followers","following_url":"https://api.github.com/users/dicksonleong/following{/other_user}","gists_url":"https://api.github.com/users/dicksonleong/gists{/gist_id}","starred_url":"https://api.github.com/users/dicksonleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dicksonleong/subscriptions","organizations_url":"https://api.github.com/users/dicksonleong/orgs","repos_url":"https://api.github.com/users/dicksonleong/repos","events_url":"https://api.github.com/users/dicksonleong/events{/privacy}","received_events_url":"https://api.github.com/users/dicksonleong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dicksonleong/qml2048","description":"2048 game port for Harmattan","fork":true,"url":"https://api.github.com/repos/dicksonleong/qml2048","forks_url":"https://api.github.com/repos/dicksonleong/qml2048/forks","keys_url":"https://api.github.com/repos/dicksonleong/qml2048/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dicksonleong/qml2048/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dicksonleong/qml2048/teams","hooks_url":"https://api.github.com/repos/dicksonleong/qml2048/hooks","issue_events_url":"https://api.github.com/repos/dicksonleong/qml2048/issues/events{/number}","events_url":"https://api.github.com/repos/dicksonleong/qml2048/events","assignees_url":"https://api.github.com/repos/dicksonleong/qml2048/assignees{/user}","branches_url":"https://api.github.com/repos/dicksonleong/qml2048/branches{/branch}","tags_url":"https://api.github.com/repos/dicksonleong/qml2048/tags","blobs_url":"https://api.github.com/repos/dicksonleong/qml2048/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dicksonleong/qml2048/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dicksonleong/qml2048/git/refs{/sha}","trees_url":"https://api.github.com/repos/dicksonleong/qml2048/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dicksonleong/qml2048/statuses/{sha}","languages_url":"https://api.github.com/repos/dicksonleong/qml2048/languages","stargazers_url":"https://api.github.com/repos/dicksonleong/qml2048/stargazers","contributors_url":"https://api.github.com/repos/dicksonleong/qml2048/contributors","subscribers_url":"https://api.github.com/repos/dicksonleong/qml2048/subscribers","subscription_url":"https://api.github.com/repos/dicksonleong/qml2048/subscription","commits_url":"https://api.github.com/repos/dicksonleong/qml2048/commits{/sha}","git_commits_url":"https://api.github.com/repos/dicksonleong/qml2048/git/commits{/sha}","comments_url":"https://api.github.com/repos/dicksonleong/qml2048/comments{/number}","issue_comment_url":"https://api.github.com/repos/dicksonleong/qml2048/issues/comments/{number}","contents_url":"https://api.github.com/repos/dicksonleong/qml2048/contents/{+path}","compare_url":"https://api.github.com/repos/dicksonleong/qml2048/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dicksonleong/qml2048/merges","archive_url":"https://api.github.com/repos/dicksonleong/qml2048/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dicksonleong/qml2048/downloads","issues_url":"https://api.github.com/repos/dicksonleong/qml2048/issues{/number}","pulls_url":"https://api.github.com/repos/dicksonleong/qml2048/pulls{/number}","milestones_url":"https://api.github.com/repos/dicksonleong/qml2048/milestones{/number}","notifications_url":"https://api.github.com/repos/dicksonleong/qml2048/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dicksonleong/qml2048/labels{/name}","releases_url":"https://api.github.com/repos/dicksonleong/qml2048/releases{/id}","created_at":"2014-04-17T09:39:45Z","updated_at":"2014-04-25T07:26:26Z","pushed_at":"2014-04-25T05:01:33Z","git_url":"git://github.com/dicksonleong/qml2048.git","ssh_url":"git@github.com:dicksonleong/qml2048.git","clone_url":"https://github.com/dicksonleong/qml2048.git","svn_url":"https://github.com/dicksonleong/qml2048","homepage":null,"size":128,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"raandoom:master","ref":"master","sha":"b39b8c4a33ae75d22cb62b3f2a2a50b5351c5e49","user":{"login":"raandoom","id":2365174,"avatar_url":"https://avatars.githubusercontent.com/u/2365174?","gravatar_id":"ac452dbabbc1c3484e2b44fd36002525","url":"https://api.github.com/users/raandoom","html_url":"https://github.com/raandoom","followers_url":"https://api.github.com/users/raandoom/followers","following_url":"https://api.github.com/users/raandoom/following{/other_user}","gists_url":"https://api.github.com/users/raandoom/gists{/gist_id}","starred_url":"https://api.github.com/users/raandoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raandoom/subscriptions","organizations_url":"https://api.github.com/users/raandoom/orgs","repos_url":"https://api.github.com/users/raandoom/repos","events_url":"https://api.github.com/users/raandoom/events{/privacy}","received_events_url":"https://api.github.com/users/raandoom/received_events","type":"User","site_admin":false},"repo":{"id":18711962,"name":"qml2048","full_name":"raandoom/qml2048","owner":{"login":"raandoom","id":2365174,"avatar_url":"https://avatars.githubusercontent.com/u/2365174?","gravatar_id":"ac452dbabbc1c3484e2b44fd36002525","url":"https://api.github.com/users/raandoom","html_url":"https://github.com/raandoom","followers_url":"https://api.github.com/users/raandoom/followers","following_url":"https://api.github.com/users/raandoom/following{/other_user}","gists_url":"https://api.github.com/users/raandoom/gists{/gist_id}","starred_url":"https://api.github.com/users/raandoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raandoom/subscriptions","organizations_url":"https://api.github.com/users/raandoom/orgs","repos_url":"https://api.github.com/users/raandoom/repos","events_url":"https://api.github.com/users/raandoom/events{/privacy}","received_events_url":"https://api.github.com/users/raandoom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raandoom/qml2048","description":"2048 game port for Harmattan","fork":false,"url":"https://api.github.com/repos/raandoom/qml2048","forks_url":"https://api.github.com/repos/raandoom/qml2048/forks","keys_url":"https://api.github.com/repos/raandoom/qml2048/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raandoom/qml2048/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raandoom/qml2048/teams","hooks_url":"https://api.github.com/repos/raandoom/qml2048/hooks","issue_events_url":"https://api.github.com/repos/raandoom/qml2048/issues/events{/number}","events_url":"https://api.github.com/repos/raandoom/qml2048/events","assignees_url":"https://api.github.com/repos/raandoom/qml2048/assignees{/user}","branches_url":"https://api.github.com/repos/raandoom/qml2048/branches{/branch}","tags_url":"https://api.github.com/repos/raandoom/qml2048/tags","blobs_url":"https://api.github.com/repos/raandoom/qml2048/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raandoom/qml2048/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raandoom/qml2048/git/refs{/sha}","trees_url":"https://api.github.com/repos/raandoom/qml2048/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raandoom/qml2048/statuses/{sha}","languages_url":"https://api.github.com/repos/raandoom/qml2048/languages","stargazers_url":"https://api.github.com/repos/raandoom/qml2048/stargazers","contributors_url":"https://api.github.com/repos/raandoom/qml2048/contributors","subscribers_url":"https://api.github.com/repos/raandoom/qml2048/subscribers","subscription_url":"https://api.github.com/repos/raandoom/qml2048/subscription","commits_url":"https://api.github.com/repos/raandoom/qml2048/commits{/sha}","git_commits_url":"https://api.github.com/repos/raandoom/qml2048/git/commits{/sha}","comments_url":"https://api.github.com/repos/raandoom/qml2048/comments{/number}","issue_comment_url":"https://api.github.com/repos/raandoom/qml2048/issues/comments/{number}","contents_url":"https://api.github.com/repos/raandoom/qml2048/contents/{+path}","compare_url":"https://api.github.com/repos/raandoom/qml2048/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raandoom/qml2048/merges","archive_url":"https://api.github.com/repos/raandoom/qml2048/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raandoom/qml2048/downloads","issues_url":"https://api.github.com/repos/raandoom/qml2048/issues{/number}","pulls_url":"https://api.github.com/repos/raandoom/qml2048/pulls{/number}","milestones_url":"https://api.github.com/repos/raandoom/qml2048/milestones{/number}","notifications_url":"https://api.github.com/repos/raandoom/qml2048/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raandoom/qml2048/labels{/name}","releases_url":"https://api.github.com/repos/raandoom/qml2048/releases{/id}","created_at":"2014-04-12T18:55:14Z","updated_at":"2014-04-24T07:00:11Z","pushed_at":"2014-04-23T22:44:55Z","git_url":"git://github.com/raandoom/qml2048.git","ssh_url":"git@github.com:raandoom/qml2048.git","clone_url":"https://github.com/raandoom/qml2048.git","svn_url":"https://github.com/raandoom/qml2048","homepage":null,"size":303,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raandoom/qml2048/pulls/7"},"html":{"href":"https://github.com/raandoom/qml2048/pull/7"},"issue":{"href":"https://api.github.com/repos/raandoom/qml2048/issues/7"},"comments":{"href":"https://api.github.com/repos/raandoom/qml2048/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/raandoom/qml2048/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/raandoom/qml2048/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/raandoom/qml2048/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/raandoom/qml2048/statuses/4b16257bde4f21a8d554a4f3a972f3eab4965235"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":3,"changed_files":2}}