GitHub PullRequestEvent at 2014-04-28 17:50:56
Repository: language-go
Actor: kevinsawicki
Payload: {"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/atom/language-go/pulls/17","id":15248837,"html_url":"https://github.com/atom/language-go/pull/17","diff_url":"https://github.com/atom/language-go/pull/17.diff","patch_url":"https://github.com/atom/language-go/pull/17.patch","issue_url":"https://api.github.com/repos/atom/language-go/issues/17","number":17,"state":"closed","title":":lipstick: Default To Line-Comments Style - Fixes #16","user":{"login":"joefitzgerald","id":744740,"avatar_url":"https://avatars.githubusercontent.com/u/744740?","gravatar_id":"8d73b2c968b779ff042e480c557d3d0b","url":"https://api.github.com/users/joefitzgerald","html_url":"https://github.com/joefitzgerald","followers_url":"https://api.github.com/users/joefitzgerald/followers","following_url":"https://api.github.com/users/joefitzgerald/following{/other_user}","gists_url":"https://api.github.com/users/joefitzgerald/gists{/gist_id}","starred_url":"https://api.github.com/users/joefitzgerald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joefitzgerald/subscriptions","organizations_url":"https://api.github.com/users/joefitzgerald/orgs","repos_url":"https://api.github.com/users/joefitzgerald/repos","events_url":"https://api.github.com/users/joefitzgerald/events{/privacy}","received_events_url":"https://api.github.com/users/joefitzgerald/received_events","type":"User","site_admin":false},"body":"See #16. References supporting the desire to prefer // over /* ... */:\r\n\r\nhttp://blog.golang.org/godoc-documenting-go-code\r\nhttps://code.google.com/p/go-wiki/wiki/CodeReviewComments\r\nhttp://golang.org/doc/effective_go.html#commentary\r\nIn summary, it the vast majority of your comments are likely to be line-style. Block-style comments may occasionally be seen in package comments, but even then only in non-trivial packages (likely with examples).\r\n\r\nConsequently, // would be preferable as it is most commonly used, and it would be nice if we had another keyboard shortcut for /* ... */?","created_at":"2014-04-28T17:19:13Z","updated_at":"2014-04-28T17:50:56Z","closed_at":"2014-04-28T17:50:56Z","merged_at":"2014-04-28T17:50:56Z","merge_commit_sha":"491464c472c09a370cc9a5b0580e033f557fbee2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/language-go/pulls/17/commits","review_comments_url":"https://api.github.com/repos/atom/language-go/pulls/17/comments","review_comment_url":"https://api.github.com/repos/atom/language-go/pulls/comments/{number}","comments_url":"https://api.github.com/repos/atom/language-go/issues/17/comments","statuses_url":"https://api.github.com/repos/atom/language-go/statuses/7bf215d0be0af498cb445d608bb9d7a037c771f9","head":{"label":"joefitzgerald:default-to-line-comments","ref":"default-to-line-comments","sha":"7bf215d0be0af498cb445d608bb9d7a037c771f9","user":{"login":"joefitzgerald","id":744740,"avatar_url":"https://avatars.githubusercontent.com/u/744740?","gravatar_id":"8d73b2c968b779ff042e480c557d3d0b","url":"https://api.github.com/users/joefitzgerald","html_url":"https://github.com/joefitzgerald","followers_url":"https://api.github.com/users/joefitzgerald/followers","following_url":"https://api.github.com/users/joefitzgerald/following{/other_user}","gists_url":"https://api.github.com/users/joefitzgerald/gists{/gist_id}","starred_url":"https://api.github.com/users/joefitzgerald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joefitzgerald/subscriptions","organizations_url":"https://api.github.com/users/joefitzgerald/orgs","repos_url":"https://api.github.com/users/joefitzgerald/repos","events_url":"https://api.github.com/users/joefitzgerald/events{/privacy}","received_events_url":"https://api.github.com/users/joefitzgerald/received_events","type":"User","site_admin":false},"repo":{"id":17465469,"name":"language-go","full_name":"joefitzgerald/language-go","owner":{"login":"joefitzgerald","id":744740,"avatar_url":"https://avatars.githubusercontent.com/u/744740?","gravatar_id":"8d73b2c968b779ff042e480c557d3d0b","url":"https://api.github.com/users/joefitzgerald","html_url":"https://github.com/joefitzgerald","followers_url":"https://api.github.com/users/joefitzgerald/followers","following_url":"https://api.github.com/users/joefitzgerald/following{/other_user}","gists_url":"https://api.github.com/users/joefitzgerald/gists{/gist_id}","starred_url":"https://api.github.com/users/joefitzgerald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joefitzgerald/subscriptions","organizations_url":"https://api.github.com/users/joefitzgerald/orgs","repos_url":"https://api.github.com/users/joefitzgerald/repos","events_url":"https://api.github.com/users/joefitzgerald/events{/privacy}","received_events_url":"https://api.github.com/users/joefitzgerald/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joefitzgerald/language-go","description":"Go language package for Atom","fork":true,"url":"https://api.github.com/repos/joefitzgerald/language-go","forks_url":"https://api.github.com/repos/joefitzgerald/language-go/forks","keys_url":"https://api.github.com/repos/joefitzgerald/language-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joefitzgerald/language-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joefitzgerald/language-go/teams","hooks_url":"https://api.github.com/repos/joefitzgerald/language-go/hooks","issue_events_url":"https://api.github.com/repos/joefitzgerald/language-go/issues/events{/number}","events_url":"https://api.github.com/repos/joefitzgerald/language-go/events","assignees_url":"https://api.github.com/repos/joefitzgerald/language-go/assignees{/user}","branches_url":"https://api.github.com/repos/joefitzgerald/language-go/branches{/branch}","tags_url":"https://api.github.com/repos/joefitzgerald/language-go/tags","blobs_url":"https://api.github.com/repos/joefitzgerald/language-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joefitzgerald/language-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joefitzgerald/language-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/joefitzgerald/language-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joefitzgerald/language-go/statuses/{sha}","languages_url":"https://api.github.com/repos/joefitzgerald/language-go/languages","stargazers_url":"https://api.github.com/repos/joefitzgerald/language-go/stargazers","contributors_url":"https://api.github.com/repos/joefitzgerald/language-go/contributors","subscribers_url":"https://api.github.com/repos/joefitzgerald/language-go/subscribers","subscription_url":"https://api.github.com/repos/joefitzgerald/language-go/subscription","commits_url":"https://api.github.com/repos/joefitzgerald/language-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/joefitzgerald/language-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/joefitzgerald/language-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/joefitzgerald/language-go/issues/comments/{number}","contents_url":"https://api.github.com/repos/joefitzgerald/language-go/contents/{+path}","compare_url":"https://api.github.com/repos/joefitzgerald/language-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joefitzgerald/language-go/merges","archive_url":"https://api.github.com/repos/joefitzgerald/language-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joefitzgerald/language-go/downloads","issues_url":"https://api.github.com/repos/joefitzgerald/language-go/issues{/number}","pulls_url":"https://api.github.com/repos/joefitzgerald/language-go/pulls{/number}","milestones_url":"https://api.github.com/repos/joefitzgerald/language-go/milestones{/number}","notifications_url":"https://api.github.com/repos/joefitzgerald/language-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joefitzgerald/language-go/labels{/name}","releases_url":"https://api.github.com/repos/joefitzgerald/language-go/releases{/id}","created_at":"2014-03-06T03:57:41Z","updated_at":"2014-04-28T17:50:56Z","pushed_at":"2014-04-28T17:19:00Z","git_url":"git://github.com/joefitzgerald/language-go.git","ssh_url":"git@github.com:joefitzgerald/language-go.git","clone_url":"https://github.com/joefitzgerald/language-go.git","svn_url":"https://github.com/joefitzgerald/language-go","homepage":null,"size":321,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"d4ad1918b88c5e0a26d65ceeabb3732af23d4267","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?","gravatar_id":"c3e589b1d091e50d6d9daf5d41287b17","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":13711887,"name":"language-go","full_name":"atom/language-go","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?","gravatar_id":"c3e589b1d091e50d6d9daf5d41287b17","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/language-go","description":"Go language package for Atom","fork":false,"url":"https://api.github.com/repos/atom/language-go","forks_url":"https://api.github.com/repos/atom/language-go/forks","keys_url":"https://api.github.com/repos/atom/language-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/language-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/language-go/teams","hooks_url":"https://api.github.com/repos/atom/language-go/hooks","issue_events_url":"https://api.github.com/repos/atom/language-go/issues/events{/number}","events_url":"https://api.github.com/repos/atom/language-go/events","assignees_url":"https://api.github.com/repos/atom/language-go/assignees{/user}","branches_url":"https://api.github.com/repos/atom/language-go/branches{/branch}","tags_url":"https://api.github.com/repos/atom/language-go/tags","blobs_url":"https://api.github.com/repos/atom/language-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/language-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/language-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/language-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/language-go/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/language-go/languages","stargazers_url":"https://api.github.com/repos/atom/language-go/stargazers","contributors_url":"https://api.github.com/repos/atom/language-go/contributors","subscribers_url":"https://api.github.com/repos/atom/language-go/subscribers","subscription_url":"https://api.github.com/repos/atom/language-go/subscription","commits_url":"https://api.github.com/repos/atom/language-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/language-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/language-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/language-go/issues/comments/{number}","contents_url":"https://api.github.com/repos/atom/language-go/contents/{+path}","compare_url":"https://api.github.com/repos/atom/language-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/language-go/merges","archive_url":"https://api.github.com/repos/atom/language-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/language-go/downloads","issues_url":"https://api.github.com/repos/atom/language-go/issues{/number}","pulls_url":"https://api.github.com/repos/atom/language-go/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/language-go/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/language-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/language-go/labels{/name}","releases_url":"https://api.github.com/repos/atom/language-go/releases{/id}","created_at":"2013-10-20T01:39:44Z","updated_at":"2014-04-28T17:50:55Z","pushed_at":"2014-04-28T17:50:56Z","git_url":"git://github.com/atom/language-go.git","ssh_url":"git@github.com:atom/language-go.git","clone_url":"https://github.com/atom/language-go.git","svn_url":"https://github.com/atom/language-go","homepage":null,"size":538,"stargazers_count":43,"watchers_count":43,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/language-go/pulls/17"},"html":{"href":"https://github.com/atom/language-go/pull/17"},"issue":{"href":"https://api.github.com/repos/atom/language-go/issues/17"},"comments":{"href":"https://api.github.com/repos/atom/language-go/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/language-go/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/language-go/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/atom/language-go/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/atom/language-go/statuses/7bf215d0be0af498cb445d608bb9d7a037c771f9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kevinsawicki","id":671378,"avatar_url":"https://avatars.githubusercontent.com/u/671378?","gravatar_id":"4e3f068bcac207404306e790c0d662ed","url":"https://api.github.com/users/kevinsawicki","html_url":"https://github.com/kevinsawicki","followers_url":"https://api.github.com/users/kevinsawicki/followers","following_url":"https://api.github.com/users/kevinsawicki/following{/other_user}","gists_url":"https://api.github.com/users/kevinsawicki/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinsawicki/subscriptions","organizations_url":"https://api.github.com/users/kevinsawicki/orgs","repos_url":"https://api.github.com/users/kevinsawicki/repos","events_url":"https://api.github.com/users/kevinsawicki/events{/privacy}","received_events_url":"https://api.github.com/users/kevinsawicki/received_events","type":"User","site_admin":true},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":0,"changed_files":1}}