GitHub PullRequestReviewCommentEvent at 2014-06-26 19:24:07
Repository: chef-pedant
Actor: jamesc
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opscode/chef-pedant/pulls/comments/14260997","id":14260997,"diff_hunk":"@@ -131,6 +131,14 @@ def self.should_create_with_metadata(_attribute, _value)\n           end\n         end\n \n+        context \"with metadata.dependencies\", :focus do\n+          should_create_with_metadata 'dependencies', {\"chef-client\" => \"> 2.0.0\",\"apt\" => \"> 1.0.0\"}\n+          should_fail_to_create_metadata(\n+            'dependencies',\n+            {\"chef-client\" => \"> 2.0.0\",\"apt\" => \"> 1\"}, \n+            400, \"Invalid value '> 1' for metadata.dependencies\")","path":"spec/api/cookbooks/create_spec.rb","position":9,"original_position":9,"commit_id":"8f83b72557d5106ff2f9f70a714ba3c49cfcdc4c","original_commit_id":"8f83b72557d5106ff2f9f70a714ba3c49cfcdc4c","user":{"login":"jamesc","id":276490,"avatar_url":"https://avatars.githubusercontent.com/u/276490?","gravatar_id":"5cc83e3d1a650e33ef8daabd0717dddb","url":"https://api.github.com/users/jamesc","html_url":"https://github.com/jamesc","followers_url":"https://api.github.com/users/jamesc/followers","following_url":"https://api.github.com/users/jamesc/following{/other_user}","gists_url":"https://api.github.com/users/jamesc/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesc/subscriptions","organizations_url":"https://api.github.com/users/jamesc/orgs","repos_url":"https://api.github.com/users/jamesc/repos","events_url":"https://api.github.com/users/jamesc/events{/privacy}","received_events_url":"https://api.github.com/users/jamesc/received_events","type":"User","site_admin":false},"body":"Just for completeness, let's check for `\"apt\" => \"1\"` as well. i.e. that exact match without a comparator is also disallowed","created_at":"2014-06-26T19:24:07Z","updated_at":"2014-06-26T19:24:07Z","html_url":"https://github.com/opscode/chef-pedant/pull/74#discussion_r14260997","pull_request_url":"https://api.github.com/repos/opscode/chef-pedant/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/opscode/chef-pedant/pulls/comments/14260997"},"html":{"href":"https://github.com/opscode/chef-pedant/pull/74#discussion_r14260997"},"pull_request":{"href":"https://api.github.com/repos/opscode/chef-pedant/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/opscode/chef-pedant/pulls/74","id":17664842,"html_url":"https://github.com/opscode/chef-pedant/pull/74","diff_url":"https://github.com/opscode/chef-pedant/pull/74.diff","patch_url":"https://github.com/opscode/chef-pedant/pull/74.patch","issue_url":"https://api.github.com/repos/opscode/chef-pedant/issues/74","number":74,"state":"open","title":"Fix for OC-11422","user":{"login":"joedevivo","id":55951,"avatar_url":"https://avatars.githubusercontent.com/u/55951?","gravatar_id":"4cc53ac6da2d152ba123265fbb3d1304","url":"https://api.github.com/users/joedevivo","html_url":"https://github.com/joedevivo","followers_url":"https://api.github.com/users/joedevivo/followers","following_url":"https://api.github.com/users/joedevivo/following{/other_user}","gists_url":"https://api.github.com/users/joedevivo/gists{/gist_id}","starred_url":"https://api.github.com/users/joedevivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joedevivo/subscriptions","organizations_url":"https://api.github.com/users/joedevivo/orgs","repos_url":"https://api.github.com/users/joedevivo/repos","events_url":"https://api.github.com/users/joedevivo/events{/privacy}","received_events_url":"https://api.github.com/users/joedevivo/received_events","type":"User","site_admin":false},"body":"No longer allow single integer version numbers for dependencies on the server side.\n\nPlease see [OC-11422](https://tickets.corp.opscode.com/browse/OC-11422) for more information.\n","created_at":"2014-06-26T18:38:16Z","updated_at":"2014-06-26T19:24:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad4594a3e6939ddedce2424c4decbb48a2df1915","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode/chef-pedant/pulls/74/commits","review_comments_url":"https://api.github.com/repos/opscode/chef-pedant/pulls/74/comments","review_comment_url":"https://api.github.com/repos/opscode/chef-pedant/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode/chef-pedant/issues/74/comments","statuses_url":"https://api.github.com/repos/opscode/chef-pedant/statuses/8f83b72557d5106ff2f9f70a714ba3c49cfcdc4c","head":{"label":"opscode:jd/OC-11422","ref":"jd/OC-11422","sha":"8f83b72557d5106ff2f9f70a714ba3c49cfcdc4c","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":5695390,"name":"chef-pedant","full_name":"opscode/chef-pedant","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/chef-pedant","description":"","fork":false,"url":"https://api.github.com/repos/opscode/chef-pedant","forks_url":"https://api.github.com/repos/opscode/chef-pedant/forks","keys_url":"https://api.github.com/repos/opscode/chef-pedant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/chef-pedant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/chef-pedant/teams","hooks_url":"https://api.github.com/repos/opscode/chef-pedant/hooks","issue_events_url":"https://api.github.com/repos/opscode/chef-pedant/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/chef-pedant/events","assignees_url":"https://api.github.com/repos/opscode/chef-pedant/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/chef-pedant/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/chef-pedant/tags","blobs_url":"https://api.github.com/repos/opscode/chef-pedant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/chef-pedant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/chef-pedant/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/chef-pedant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/chef-pedant/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/chef-pedant/languages","stargazers_url":"https://api.github.com/repos/opscode/chef-pedant/stargazers","contributors_url":"https://api.github.com/repos/opscode/chef-pedant/contributors","subscribers_url":"https://api.github.com/repos/opscode/chef-pedant/subscribers","subscription_url":"https://api.github.com/repos/opscode/chef-pedant/subscription","commits_url":"https://api.github.com/repos/opscode/chef-pedant/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/chef-pedant/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/chef-pedant/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/chef-pedant/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/chef-pedant/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/chef-pedant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/chef-pedant/merges","archive_url":"https://api.github.com/repos/opscode/chef-pedant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/chef-pedant/downloads","issues_url":"https://api.github.com/repos/opscode/chef-pedant/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/chef-pedant/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/chef-pedant/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/chef-pedant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/chef-pedant/labels{/name}","releases_url":"https://api.github.com/repos/opscode/chef-pedant/releases{/id}","created_at":"2012-09-06T00:19:54Z","updated_at":"2014-06-16T21:14:49Z","pushed_at":"2014-06-26T18:31:23Z","git_url":"git://github.com/opscode/chef-pedant.git","ssh_url":"git@github.com:opscode/chef-pedant.git","clone_url":"https://github.com/opscode/chef-pedant.git","svn_url":"https://github.com/opscode/chef-pedant","homepage":null,"size":2147,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":11,"default_branch":"master"}},"base":{"label":"opscode:master","ref":"master","sha":"c8f9eb3be13ecb246d01eb427bde7c5c85134782","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":5695390,"name":"chef-pedant","full_name":"opscode/chef-pedant","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/chef-pedant","description":"","fork":false,"url":"https://api.github.com/repos/opscode/chef-pedant","forks_url":"https://api.github.com/repos/opscode/chef-pedant/forks","keys_url":"https://api.github.com/repos/opscode/chef-pedant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/chef-pedant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/chef-pedant/teams","hooks_url":"https://api.github.com/repos/opscode/chef-pedant/hooks","issue_events_url":"https://api.github.com/repos/opscode/chef-pedant/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/chef-pedant/events","assignees_url":"https://api.github.com/repos/opscode/chef-pedant/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/chef-pedant/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/chef-pedant/tags","blobs_url":"https://api.github.com/repos/opscode/chef-pedant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/chef-pedant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/chef-pedant/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/chef-pedant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/chef-pedant/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/chef-pedant/languages","stargazers_url":"https://api.github.com/repos/opscode/chef-pedant/stargazers","contributors_url":"https://api.github.com/repos/opscode/chef-pedant/contributors","subscribers_url":"https://api.github.com/repos/opscode/chef-pedant/subscribers","subscription_url":"https://api.github.com/repos/opscode/chef-pedant/subscription","commits_url":"https://api.github.com/repos/opscode/chef-pedant/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/chef-pedant/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/chef-pedant/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/chef-pedant/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/chef-pedant/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/chef-pedant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/chef-pedant/merges","archive_url":"https://api.github.com/repos/opscode/chef-pedant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/chef-pedant/downloads","issues_url":"https://api.github.com/repos/opscode/chef-pedant/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/chef-pedant/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/chef-pedant/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/chef-pedant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/chef-pedant/labels{/name}","releases_url":"https://api.github.com/repos/opscode/chef-pedant/releases{/id}","created_at":"2012-09-06T00:19:54Z","updated_at":"2014-06-16T21:14:49Z","pushed_at":"2014-06-26T18:31:23Z","git_url":"git://github.com/opscode/chef-pedant.git","ssh_url":"git@github.com:opscode/chef-pedant.git","clone_url":"https://github.com/opscode/chef-pedant.git","svn_url":"https://github.com/opscode/chef-pedant","homepage":null,"size":2147,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode/chef-pedant/pulls/74"},"html":{"href":"https://github.com/opscode/chef-pedant/pull/74"},"issue":{"href":"https://api.github.com/repos/opscode/chef-pedant/issues/74"},"comments":{"href":"https://api.github.com/repos/opscode/chef-pedant/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode/chef-pedant/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode/chef-pedant/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode/chef-pedant/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/opscode/chef-pedant/statuses/8f83b72557d5106ff2f9f70a714ba3c49cfcdc4c"}}}}