GitHub PullRequestEvent at 2014-04-28 15:20:07
Repository: Ghost
Actor: ErisDS
Payload: {"action":"closed","number":2238,"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/2238","id":12819411,"html_url":"https://github.com/TryGhost/Ghost/pull/2238","diff_url":"https://github.com/TryGhost/Ghost/pull/2238.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/2238.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/2238","number":2238,"state":"closed","title":"Support for urlSSL config option and forceAdminSSL 403 response","user":{"login":"gimelfarb","id":6202109,"avatar_url":"https://avatars.githubusercontent.com/u/6202109?","gravatar_id":"31495996750ea65cc36530dcbed42501","url":"https://api.github.com/users/gimelfarb","html_url":"https://github.com/gimelfarb","followers_url":"https://api.github.com/users/gimelfarb/followers","following_url":"https://api.github.com/users/gimelfarb/following{/other_user}","gists_url":"https://api.github.com/users/gimelfarb/gists{/gist_id}","starred_url":"https://api.github.com/users/gimelfarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gimelfarb/subscriptions","organizations_url":"https://api.github.com/users/gimelfarb/orgs","repos_url":"https://api.github.com/users/gimelfarb/repos","events_url":"https://api.github.com/users/gimelfarb/events{/privacy}","received_events_url":"https://api.github.com/users/gimelfarb/received_events","type":"User","site_admin":false},"body":"closes #1838\r\n- adding `forceAdminSSL: {redirect: true/false}` option to allow 403 over non-SSL rather than redirect\r\n- adding `urlSSL` option to specify SSL variant of `url`\r\n- using `urlSSL` when redirecting to SSL (forceAdminSSL), if specified\r\n- dynamically patching `.url` property for view engine templates to use SSL variant over HTTPS connections (pass `.secure` property as view engine data)\r\n- using `urlSSL` in a \"reset password\" email, if specified\r\n- adding unit tests to test `forceAdminSSL` and `urlSSL` options\r\n- created a unit test utility function to dynamically fork a new instance of Ghost during the test, with different configuration options","created_at":"2014-02-22T03:03:16Z","updated_at":"2014-04-28T15:20:06Z","closed_at":"2014-04-28T15:20:06Z","merged_at":"2014-04-28T15:20:06Z","merge_commit_sha":"38e47f72a05e4cc54d64d061549e9a7b77d44477","assignee":{"login":"sebgie","id":539213,"avatar_url":"https://avatars.githubusercontent.com/u/539213?","gravatar_id":"4a6e8e2f484f0fb3da340aa1cb1f54ac","url":"https://api.github.com/users/sebgie","html_url":"https://github.com/sebgie","followers_url":"https://api.github.com/users/sebgie/followers","following_url":"https://api.github.com/users/sebgie/following{/other_user}","gists_url":"https://api.github.com/users/sebgie/gists{/gist_id}","starred_url":"https://api.github.com/users/sebgie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebgie/subscriptions","organizations_url":"https://api.github.com/users/sebgie/orgs","repos_url":"https://api.github.com/users/sebgie/repos","events_url":"https://api.github.com/users/sebgie/events{/privacy}","received_events_url":"https://api.github.com/users/sebgie/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/2238/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/2238/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/2238/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/a01384050392f5d39bee4e2809a469ededc24af5","head":{"label":"gimelfarb:fix-1838-admin-ssl","ref":"fix-1838-admin-ssl","sha":"a01384050392f5d39bee4e2809a469ededc24af5","user":{"login":"gimelfarb","id":6202109,"avatar_url":"https://avatars.githubusercontent.com/u/6202109?","gravatar_id":"31495996750ea65cc36530dcbed42501","url":"https://api.github.com/users/gimelfarb","html_url":"https://github.com/gimelfarb","followers_url":"https://api.github.com/users/gimelfarb/followers","following_url":"https://api.github.com/users/gimelfarb/following{/other_user}","gists_url":"https://api.github.com/users/gimelfarb/gists{/gist_id}","starred_url":"https://api.github.com/users/gimelfarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gimelfarb/subscriptions","organizations_url":"https://api.github.com/users/gimelfarb/orgs","repos_url":"https://api.github.com/users/gimelfarb/repos","events_url":"https://api.github.com/users/gimelfarb/events{/privacy}","received_events_url":"https://api.github.com/users/gimelfarb/received_events","type":"User","site_admin":false},"repo":{"id":15559350,"name":"Ghost","full_name":"gimelfarb/Ghost","owner":{"login":"gimelfarb","id":6202109,"avatar_url":"https://avatars.githubusercontent.com/u/6202109?","gravatar_id":"31495996750ea65cc36530dcbed42501","url":"https://api.github.com/users/gimelfarb","html_url":"https://github.com/gimelfarb","followers_url":"https://api.github.com/users/gimelfarb/followers","following_url":"https://api.github.com/users/gimelfarb/following{/other_user}","gists_url":"https://api.github.com/users/gimelfarb/gists{/gist_id}","starred_url":"https://api.github.com/users/gimelfarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gimelfarb/subscriptions","organizations_url":"https://api.github.com/users/gimelfarb/orgs","repos_url":"https://api.github.com/users/gimelfarb/repos","events_url":"https://api.github.com/users/gimelfarb/events{/privacy}","received_events_url":"https://api.github.com/users/gimelfarb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gimelfarb/Ghost","description":"Just a blogging platform","fork":true,"url":"https://api.github.com/repos/gimelfarb/Ghost","forks_url":"https://api.github.com/repos/gimelfarb/Ghost/forks","keys_url":"https://api.github.com/repos/gimelfarb/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gimelfarb/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gimelfarb/Ghost/teams","hooks_url":"https://api.github.com/repos/gimelfarb/Ghost/hooks","issue_events_url":"https://api.github.com/repos/gimelfarb/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/gimelfarb/Ghost/events","assignees_url":"https://api.github.com/repos/gimelfarb/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/gimelfarb/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/gimelfarb/Ghost/tags","blobs_url":"https://api.github.com/repos/gimelfarb/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gimelfarb/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gimelfarb/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/gimelfarb/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gimelfarb/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/gimelfarb/Ghost/languages","stargazers_url":"https://api.github.com/repos/gimelfarb/Ghost/stargazers","contributors_url":"https://api.github.com/repos/gimelfarb/Ghost/contributors","subscribers_url":"https://api.github.com/repos/gimelfarb/Ghost/subscribers","subscription_url":"https://api.github.com/repos/gimelfarb/Ghost/subscription","commits_url":"https://api.github.com/repos/gimelfarb/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/gimelfarb/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/gimelfarb/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/gimelfarb/Ghost/issues/comments/{number}","contents_url":"https://api.github.com/repos/gimelfarb/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/gimelfarb/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gimelfarb/Ghost/merges","archive_url":"https://api.github.com/repos/gimelfarb/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gimelfarb/Ghost/downloads","issues_url":"https://api.github.com/repos/gimelfarb/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/gimelfarb/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/gimelfarb/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/gimelfarb/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gimelfarb/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/gimelfarb/Ghost/releases{/id}","created_at":"2014-01-01T01:56:25Z","updated_at":"2014-04-28T15:20:06Z","pushed_at":"2014-04-27T21:53:25Z","git_url":"git://github.com/gimelfarb/Ghost.git","ssh_url":"git@github.com:gimelfarb/Ghost.git","clone_url":"https://github.com/gimelfarb/Ghost.git","svn_url":"https://github.com/gimelfarb/Ghost","homepage":"http://ghost.org","size":8444,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"33884e760a36d693956a45629f9951844bf09455","user":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?","gravatar_id":"238913f75ec6bb96e5a02f96ac50c9d8","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"name":"Ghost","full_name":"TryGhost/Ghost","owner":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?","gravatar_id":"238913f75ec6bb96e5a02f96ac50c9d8","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TryGhost/Ghost","description":"Just a blogging platform","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments/{number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","created_at":"2013-05-04T11:09:13Z","updated_at":"2014-04-28T15:20:06Z","pushed_at":"2014-04-28T15:20:06Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":36643,"stargazers_count":10242,"watchers_count":10242,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2018,"mirror_url":null,"open_issues_count":295,"forks":2018,"open_issues":295,"watchers":10242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/2238"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/2238"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/2238"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/2238/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/2238/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/2238/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/a01384050392f5d39bee4e2809a469ededc24af5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ErisDS","id":101513,"avatar_url":"https://avatars.githubusercontent.com/u/101513?","gravatar_id":"cb82ccb3c72846f4e111348b8d5a01e5","url":"https://api.github.com/users/ErisDS","html_url":"https://github.com/ErisDS","followers_url":"https://api.github.com/users/ErisDS/followers","following_url":"https://api.github.com/users/ErisDS/following{/other_user}","gists_url":"https://api.github.com/users/ErisDS/gists{/gist_id}","starred_url":"https://api.github.com/users/ErisDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErisDS/subscriptions","organizations_url":"https://api.github.com/users/ErisDS/orgs","repos_url":"https://api.github.com/users/ErisDS/repos","events_url":"https://api.github.com/users/ErisDS/events{/privacy}","received_events_url":"https://api.github.com/users/ErisDS/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":312,"deletions":12,"changed_files":8}}