GitHub PullRequestReviewCommentEvent at 2014-06-22 16:02:49
Repository: btcrpcclient
Actor: davecgh
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/conformal/btcrpcclient/pulls/comments/14055222","id":14055222,"diff_hunk":"@@ -1983,6 +1983,91 @@ func (c *Client) ImportPrivKey(privKeyWIF *btcutil.WIF) error {\n \treturn c.ImportPrivKeyAsync(privKeyWIF).Receive()\n }\n \n+// FutureImportPrivKeyLabelResult is a future promise to deliver the result of an\n+// ImportPrivKeyAsync RPC invocation (or an applicable error).\n+type FutureImportPrivKeyLabelResult chan *futureResult","path":"wallet.go","position":6,"original_position":6,"commit_id":"fc33f7e8ab4c463da70a949080b28b3e4d3451ff","original_commit_id":"fc33f7e8ab4c463da70a949080b28b3e4d3451ff","user":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars.githubusercontent.com/u/2115102?","gravatar_id":"725ef19c5803fc0c472dcecd95b44882","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"body":"There is no need for a new type here.  You can just reuse FutureImportPrivKeyResult since the result is the same for the different variants.","created_at":"2014-06-22T16:02:49Z","updated_at":"2014-06-22T16:02:49Z","html_url":"https://github.com/conformal/btcrpcclient/pull/8#discussion_r14055222","pull_request_url":"https://api.github.com/repos/conformal/btcrpcclient/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/conformal/btcrpcclient/pulls/comments/14055222"},"html":{"href":"https://github.com/conformal/btcrpcclient/pull/8#discussion_r14055222"},"pull_request":{"href":"https://api.github.com/repos/conformal/btcrpcclient/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/conformal/btcrpcclient/pulls/8","id":17447088,"html_url":"https://github.com/conformal/btcrpcclient/pull/8","diff_url":"https://github.com/conformal/btcrpcclient/pull/8.diff","patch_url":"https://github.com/conformal/btcrpcclient/pull/8.patch","issue_url":"https://api.github.com/repos/conformal/btcrpcclient/issues/8","number":8,"state":"open","title":"Add ImportPrivKeyLabel and ImportPrivKeyRescan (and async friends).","user":{"login":"GeertJohan","id":564501,"avatar_url":"https://avatars.githubusercontent.com/u/564501?","gravatar_id":"2e07b48977440f01f2e6e19f73b70ca1","url":"https://api.github.com/users/GeertJohan","html_url":"https://github.com/GeertJohan","followers_url":"https://api.github.com/users/GeertJohan/followers","following_url":"https://api.github.com/users/GeertJohan/following{/other_user}","gists_url":"https://api.github.com/users/GeertJohan/gists{/gist_id}","starred_url":"https://api.github.com/users/GeertJohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeertJohan/subscriptions","organizations_url":"https://api.github.com/users/GeertJohan/orgs","repos_url":"https://api.github.com/users/GeertJohan/repos","events_url":"https://api.github.com/users/GeertJohan/events{/privacy}","received_events_url":"https://api.github.com/users/GeertJohan/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-22T09:55:57Z","updated_at":"2014-06-22T16:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/conformal/btcrpcclient/pulls/8/commits","review_comments_url":"https://api.github.com/repos/conformal/btcrpcclient/pulls/8/comments","review_comment_url":"https://api.github.com/repos/conformal/btcrpcclient/pulls/comments/{number}","comments_url":"https://api.github.com/repos/conformal/btcrpcclient/issues/8/comments","statuses_url":"https://api.github.com/repos/conformal/btcrpcclient/statuses/fc33f7e8ab4c463da70a949080b28b3e4d3451ff","head":{"label":"GeertJohan:import-priv-key-with-label","ref":"import-priv-key-with-label","sha":"fc33f7e8ab4c463da70a949080b28b3e4d3451ff","user":{"login":"GeertJohan","id":564501,"avatar_url":"https://avatars.githubusercontent.com/u/564501?","gravatar_id":"2e07b48977440f01f2e6e19f73b70ca1","url":"https://api.github.com/users/GeertJohan","html_url":"https://github.com/GeertJohan","followers_url":"https://api.github.com/users/GeertJohan/followers","following_url":"https://api.github.com/users/GeertJohan/following{/other_user}","gists_url":"https://api.github.com/users/GeertJohan/gists{/gist_id}","starred_url":"https://api.github.com/users/GeertJohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeertJohan/subscriptions","organizations_url":"https://api.github.com/users/GeertJohan/orgs","repos_url":"https://api.github.com/users/GeertJohan/repos","events_url":"https://api.github.com/users/GeertJohan/events{/privacy}","received_events_url":"https://api.github.com/users/GeertJohan/received_events","type":"User","site_admin":false},"repo":{"id":20690518,"name":"btcrpcclient","full_name":"GeertJohan/btcrpcclient","owner":{"login":"GeertJohan","id":564501,"avatar_url":"https://avatars.githubusercontent.com/u/564501?","gravatar_id":"2e07b48977440f01f2e6e19f73b70ca1","url":"https://api.github.com/users/GeertJohan","html_url":"https://github.com/GeertJohan","followers_url":"https://api.github.com/users/GeertJohan/followers","following_url":"https://api.github.com/users/GeertJohan/following{/other_user}","gists_url":"https://api.github.com/users/GeertJohan/gists{/gist_id}","starred_url":"https://api.github.com/users/GeertJohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeertJohan/subscriptions","organizations_url":"https://api.github.com/users/GeertJohan/orgs","repos_url":"https://api.github.com/users/GeertJohan/repos","events_url":"https://api.github.com/users/GeertJohan/events{/privacy}","received_events_url":"https://api.github.com/users/GeertJohan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GeertJohan/btcrpcclient","description":"  Implements a robust and easy to use websocket-enabled Bitcoin JSON-RPC client.","fork":true,"url":"https://api.github.com/repos/GeertJohan/btcrpcclient","forks_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/forks","keys_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/teams","hooks_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/hooks","issue_events_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/issues/events{/number}","events_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/events","assignees_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/assignees{/user}","branches_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/branches{/branch}","tags_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/tags","blobs_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/statuses/{sha}","languages_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/languages","stargazers_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/stargazers","contributors_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/contributors","subscribers_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/subscribers","subscription_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/subscription","commits_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/issues/comments/{number}","contents_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/contents/{+path}","compare_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/merges","archive_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/downloads","issues_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/issues{/number}","pulls_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/pulls{/number}","milestones_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/milestones{/number}","notifications_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/labels{/name}","releases_url":"https://api.github.com/repos/GeertJohan/btcrpcclient/releases{/id}","created_at":"2014-06-10T15:25:15Z","updated_at":"2014-06-22T09:55:57Z","pushed_at":"2014-06-22T09:55:23Z","git_url":"git://github.com/GeertJohan/btcrpcclient.git","ssh_url":"git@github.com:GeertJohan/btcrpcclient.git","clone_url":"https://github.com/GeertJohan/btcrpcclient.git","svn_url":"https://github.com/GeertJohan/btcrpcclient","homepage":null,"size":174,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"conformal:master","ref":"master","sha":"22b6af14000cb451983297cfab3d0e2061b6a69d","user":{"login":"conformal","id":1123608,"avatar_url":"https://avatars.githubusercontent.com/u/1123608?","gravatar_id":"0ebd0ed08ef19fe7d2dd08f671a8efeb","url":"https://api.github.com/users/conformal","html_url":"https://github.com/conformal","followers_url":"https://api.github.com/users/conformal/followers","following_url":"https://api.github.com/users/conformal/following{/other_user}","gists_url":"https://api.github.com/users/conformal/gists{/gist_id}","starred_url":"https://api.github.com/users/conformal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conformal/subscriptions","organizations_url":"https://api.github.com/users/conformal/orgs","repos_url":"https://api.github.com/users/conformal/repos","events_url":"https://api.github.com/users/conformal/events{/privacy}","received_events_url":"https://api.github.com/users/conformal/received_events","type":"Organization","site_admin":false},"repo":{"id":19540982,"name":"btcrpcclient","full_name":"conformal/btcrpcclient","owner":{"login":"conformal","id":1123608,"avatar_url":"https://avatars.githubusercontent.com/u/1123608?","gravatar_id":"0ebd0ed08ef19fe7d2dd08f671a8efeb","url":"https://api.github.com/users/conformal","html_url":"https://github.com/conformal","followers_url":"https://api.github.com/users/conformal/followers","following_url":"https://api.github.com/users/conformal/following{/other_user}","gists_url":"https://api.github.com/users/conformal/gists{/gist_id}","starred_url":"https://api.github.com/users/conformal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conformal/subscriptions","organizations_url":"https://api.github.com/users/conformal/orgs","repos_url":"https://api.github.com/users/conformal/repos","events_url":"https://api.github.com/users/conformal/events{/privacy}","received_events_url":"https://api.github.com/users/conformal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conformal/btcrpcclient","description":"  Implements a robust and easy to use websocket-enabled Bitcoin JSON-RPC client.","fork":false,"url":"https://api.github.com/repos/conformal/btcrpcclient","forks_url":"https://api.github.com/repos/conformal/btcrpcclient/forks","keys_url":"https://api.github.com/repos/conformal/btcrpcclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conformal/btcrpcclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conformal/btcrpcclient/teams","hooks_url":"https://api.github.com/repos/conformal/btcrpcclient/hooks","issue_events_url":"https://api.github.com/repos/conformal/btcrpcclient/issues/events{/number}","events_url":"https://api.github.com/repos/conformal/btcrpcclient/events","assignees_url":"https://api.github.com/repos/conformal/btcrpcclient/assignees{/user}","branches_url":"https://api.github.com/repos/conformal/btcrpcclient/branches{/branch}","tags_url":"https://api.github.com/repos/conformal/btcrpcclient/tags","blobs_url":"https://api.github.com/repos/conformal/btcrpcclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conformal/btcrpcclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conformal/btcrpcclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/conformal/btcrpcclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conformal/btcrpcclient/statuses/{sha}","languages_url":"https://api.github.com/repos/conformal/btcrpcclient/languages","stargazers_url":"https://api.github.com/repos/conformal/btcrpcclient/stargazers","contributors_url":"https://api.github.com/repos/conformal/btcrpcclient/contributors","subscribers_url":"https://api.github.com/repos/conformal/btcrpcclient/subscribers","subscription_url":"https://api.github.com/repos/conformal/btcrpcclient/subscription","commits_url":"https://api.github.com/repos/conformal/btcrpcclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/conformal/btcrpcclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/conformal/btcrpcclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/conformal/btcrpcclient/issues/comments/{number}","contents_url":"https://api.github.com/repos/conformal/btcrpcclient/contents/{+path}","compare_url":"https://api.github.com/repos/conformal/btcrpcclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conformal/btcrpcclient/merges","archive_url":"https://api.github.com/repos/conformal/btcrpcclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conformal/btcrpcclient/downloads","issues_url":"https://api.github.com/repos/conformal/btcrpcclient/issues{/number}","pulls_url":"https://api.github.com/repos/conformal/btcrpcclient/pulls{/number}","milestones_url":"https://api.github.com/repos/conformal/btcrpcclient/milestones{/number}","notifications_url":"https://api.github.com/repos/conformal/btcrpcclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conformal/btcrpcclient/labels{/name}","releases_url":"https://api.github.com/repos/conformal/btcrpcclient/releases{/id}","created_at":"2014-05-07T16:01:31Z","updated_at":"2014-06-21T09:42:53Z","pushed_at":"2014-06-18T15:22:09Z","git_url":"git://github.com/conformal/btcrpcclient.git","ssh_url":"git@github.com:conformal/btcrpcclient.git","clone_url":"https://github.com/conformal/btcrpcclient.git","svn_url":"https://github.com/conformal/btcrpcclient","homepage":null,"size":703,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conformal/btcrpcclient/pulls/8"},"html":{"href":"https://github.com/conformal/btcrpcclient/pull/8"},"issue":{"href":"https://api.github.com/repos/conformal/btcrpcclient/issues/8"},"comments":{"href":"https://api.github.com/repos/conformal/btcrpcclient/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/conformal/btcrpcclient/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/conformal/btcrpcclient/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/conformal/btcrpcclient/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/conformal/btcrpcclient/statuses/fc33f7e8ab4c463da70a949080b28b3e4d3451ff"}}}}