GitHub PullRequestReviewCommentEvent at 2014-11-27 17:52:21
Repository: rudder-techniques
Actor: peckpeck
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Normation/rudder-techniques/pulls/comments/21006907","id":21006907,"diff_hunk":"@@ -75,13 +89,13 @@ bundle agent check_nfs_server_configuration\n       \"any\" usebundle => rudder_common_report(\"nfsServer\", \"result_error\", \"${nfs_server_uuid[${nfs_server_index}]}\", \"NFS server settings\", \"${nfs_server_path[${nfs_server_index}]}\", \"The export ${nfs_server_path[${nfs_server_index}]} could not be added\"),\n         ifvarclass => canonify(\"nfs_server_${nfs_server_index}_failed\");\n \n-    pass3.((debian|redhat|SuSE))::\n+    pass3.(service_restart_nfs_kernel_server_ok|service_restart_nfs_ok|service_restart_nfslock_ok|service_restart_nfsserver_ok)::\n+\n+      \"any\" usebundle => rudder_common_report(\"nfsServer\", \"log_repaired\", \"${nfs_server_uuid[${nfs_server_index}]}\", \"NFS server settings\", \"${nfs_server_path[${nfs_server_index}]}\", \"Restarted the NFS server because of the export ${nfs_server_path[${nfs_server_index}]}\");\n \n-      \"any\" usebundle => rudder_common_report(\"nfsServer\", \"log_repaired\", \"${nfs_server_uuid[${nfs_server_index}]}\", \"NFS server settings\", \"${nfs_server_path[${nfs_server_index}]}\", \"Restarted the NFS server because of the export ${nfs_server_path[${nfs_server_index}]}\"),\n-        ifvarclass => canonify(\"nfs_server_${nfs_server_index}_restarted\");\n+    pass3.(service_restart_nfs_kernel_server_not_ok|service_restart_nfs_not_ok|service_restart_nfslock_not_ok|service_restart_nfsserver_not_ok)::\n \n-      \"any\" usebundle => rudder_common_report(\"nfsServer\", \"result_error\", \"${nfs_server_uuid[${nfs_server_index}]}\", \"NFS server settings\", \"${nfs_server_path[${nfs_server_index}]}\", \"Could not restart the NFS server because of the export ${nfs_server_path[${nfs_server_index}]}\"),\n-        ifvarclass => canonify(\"nfs_server_${nfs_server_index}_not_restarted\");\n+      \"any\" usebundle => rudder_common_report(\"nfsServer\", \"result_error\", \"${nfs_server_uuid[${nfs_server_index}]}\", \"NFS server settings\", \"${nfs_server_path[${nfs_server_index}]}\", \"Could not restart the NFS server because of the export ${nfs_server_path[${nfs_server_index}]}\");\n \n   commands:\n ","path":"techniques/systemSettings/networking/nfsServer/3.0/nfsServerConfigure.st","position":66,"original_position":66,"commit_id":"35c2b39d5c978ad6c6e448ed156fbcca8aec48f2","original_commit_id":"35c2b39d5c978ad6c6e448ed156fbcca8aec48f2","user":{"login":"peckpeck","id":7976666,"avatar_url":"https://avatars.githubusercontent.com/u/7976666?v=3","gravatar_id":"","url":"https://api.github.com/users/peckpeck","html_url":"https://github.com/peckpeck","followers_url":"https://api.github.com/users/peckpeck/followers","following_url":"https://api.github.com/users/peckpeck/following{/other_user}","gists_url":"https://api.github.com/users/peckpeck/gists{/gist_id}","starred_url":"https://api.github.com/users/peckpeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peckpeck/subscriptions","organizations_url":"https://api.github.com/users/peckpeck/orgs","repos_url":"https://api.github.com/users/peckpeck/repos","events_url":"https://api.github.com/users/peckpeck/events{/privacy}","received_events_url":"https://api.github.com/users/peckpeck/received_events","type":"User","site_admin":false},"body":"Didn't you forget to remove the commands ?","created_at":"2014-11-27T17:52:21Z","updated_at":"2014-11-27T17:52:21Z","html_url":"https://github.com/Normation/rudder-techniques/pull/574#discussion_r21006907","pull_request_url":"https://api.github.com/repos/Normation/rudder-techniques/pulls/574","_links":{"self":{"href":"https://api.github.com/repos/Normation/rudder-techniques/pulls/comments/21006907"},"html":{"href":"https://github.com/Normation/rudder-techniques/pull/574#discussion_r21006907"},"pull_request":{"href":"https://api.github.com/repos/Normation/rudder-techniques/pulls/574"}}},"pull_request":{"url":"https://api.github.com/repos/Normation/rudder-techniques/pulls/574","id":25163959,"html_url":"https://github.com/Normation/rudder-techniques/pull/574","diff_url":"https://github.com/Normation/rudder-techniques/pull/574.diff","patch_url":"https://github.com/Normation/rudder-techniques/pull/574.patch","issue_url":"https://api.github.com/repos/Normation/rudder-techniques/issues/574","number":574,"state":"open","locked":false,"title":"Fixes #5845: Add portable init services handling in the Techniques","user":{"login":"Kegeruneku","id":917886,"avatar_url":"https://avatars.githubusercontent.com/u/917886?v=3","gravatar_id":"","url":"https://api.github.com/users/Kegeruneku","html_url":"https://github.com/Kegeruneku","followers_url":"https://api.github.com/users/Kegeruneku/followers","following_url":"https://api.github.com/users/Kegeruneku/following{/other_user}","gists_url":"https://api.github.com/users/Kegeruneku/gists{/gist_id}","starred_url":"https://api.github.com/users/Kegeruneku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kegeruneku/subscriptions","organizations_url":"https://api.github.com/users/Kegeruneku/orgs","repos_url":"https://api.github.com/users/Kegeruneku/repos","events_url":"https://api.github.com/users/Kegeruneku/events{/privacy}","received_events_url":"https://api.github.com/users/Kegeruneku/received_events","type":"User","site_admin":false},"body":"Ticket: http://www.rudder-project.org/redmine/issues/5845\r\n\r\nTo be merged in 3.0","created_at":"2014-11-27T17:31:01Z","updated_at":"2014-11-27T17:52:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"972c4a99612b745456d9be5ab5975ac1c97e662b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Normation/rudder-techniques/pulls/574/commits","review_comments_url":"https://api.github.com/repos/Normation/rudder-techniques/pulls/574/comments","review_comment_url":"https://api.github.com/repos/Normation/rudder-techniques/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Normation/rudder-techniques/issues/574/comments","statuses_url":"https://api.github.com/repos/Normation/rudder-techniques/statuses/35c2b39d5c978ad6c6e448ed156fbcca8aec48f2","head":{"label":"Kegeruneku:bug_5451/dev/5451_add_systemd_support_to_techniques","ref":"bug_5451/dev/5451_add_systemd_support_to_techniques","sha":"35c2b39d5c978ad6c6e448ed156fbcca8aec48f2","user":{"login":"Kegeruneku","id":917886,"avatar_url":"https://avatars.githubusercontent.com/u/917886?v=3","gravatar_id":"","url":"https://api.github.com/users/Kegeruneku","html_url":"https://github.com/Kegeruneku","followers_url":"https://api.github.com/users/Kegeruneku/followers","following_url":"https://api.github.com/users/Kegeruneku/following{/other_user}","gists_url":"https://api.github.com/users/Kegeruneku/gists{/gist_id}","starred_url":"https://api.github.com/users/Kegeruneku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kegeruneku/subscriptions","organizations_url":"https://api.github.com/users/Kegeruneku/orgs","repos_url":"https://api.github.com/users/Kegeruneku/repos","events_url":"https://api.github.com/users/Kegeruneku/events{/privacy}","received_events_url":"https://api.github.com/users/Kegeruneku/received_events","type":"User","site_admin":false},"repo":{"id":6687237,"name":"rudder-techniques","full_name":"Kegeruneku/rudder-techniques","owner":{"login":"Kegeruneku","id":917886,"avatar_url":"https://avatars.githubusercontent.com/u/917886?v=3","gravatar_id":"","url":"https://api.github.com/users/Kegeruneku","html_url":"https://github.com/Kegeruneku","followers_url":"https://api.github.com/users/Kegeruneku/followers","following_url":"https://api.github.com/users/Kegeruneku/following{/other_user}","gists_url":"https://api.github.com/users/Kegeruneku/gists{/gist_id}","starred_url":"https://api.github.com/users/Kegeruneku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kegeruneku/subscriptions","organizations_url":"https://api.github.com/users/Kegeruneku/orgs","repos_url":"https://api.github.com/users/Kegeruneku/repos","events_url":"https://api.github.com/users/Kegeruneku/events{/privacy}","received_events_url":"https://api.github.com/users/Kegeruneku/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kegeruneku/rudder-techniques","description":"","fork":true,"url":"https://api.github.com/repos/Kegeruneku/rudder-techniques","forks_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/forks","keys_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/teams","hooks_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/hooks","issue_events_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/issues/events{/number}","events_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/events","assignees_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/assignees{/user}","branches_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/branches{/branch}","tags_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/tags","blobs_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/statuses/{sha}","languages_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/languages","stargazers_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/stargazers","contributors_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/contributors","subscribers_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/subscribers","subscription_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/subscription","commits_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/issues/comments/{number}","contents_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/contents/{+path}","compare_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/merges","archive_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/downloads","issues_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/issues{/number}","pulls_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/pulls{/number}","milestones_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/milestones{/number}","notifications_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/labels{/name}","releases_url":"https://api.github.com/repos/Kegeruneku/rudder-techniques/releases{/id}","created_at":"2012-11-14T12:10:23Z","updated_at":"2014-08-12T09:52:48Z","pushed_at":"2014-11-27T17:38:55Z","git_url":"git://github.com/Kegeruneku/rudder-techniques.git","ssh_url":"git@github.com:Kegeruneku/rudder-techniques.git","clone_url":"https://github.com/Kegeruneku/rudder-techniques.git","svn_url":"https://github.com/Kegeruneku/rudder-techniques","homepage":"http://www.rudder-project.org/","size":42640,"stargazers_count":0,"watchers_count":0,"language":"Smalltalk","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Normation:branches/rudder/3.0","ref":"branches/rudder/3.0","sha":"ebbb674856e58e7210377deaf8b0c2e1d606c884","user":{"login":"Normation","id":695105,"avatar_url":"https://avatars.githubusercontent.com/u/695105?v=3","gravatar_id":"","url":"https://api.github.com/users/Normation","html_url":"https://github.com/Normation","followers_url":"https://api.github.com/users/Normation/followers","following_url":"https://api.github.com/users/Normation/following{/other_user}","gists_url":"https://api.github.com/users/Normation/gists{/gist_id}","starred_url":"https://api.github.com/users/Normation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Normation/subscriptions","organizations_url":"https://api.github.com/users/Normation/orgs","repos_url":"https://api.github.com/users/Normation/repos","events_url":"https://api.github.com/users/Normation/events{/privacy}","received_events_url":"https://api.github.com/users/Normation/received_events","type":"Organization","site_admin":false},"repo":{"id":2528259,"name":"rudder-techniques","full_name":"Normation/rudder-techniques","owner":{"login":"Normation","id":695105,"avatar_url":"https://avatars.githubusercontent.com/u/695105?v=3","gravatar_id":"","url":"https://api.github.com/users/Normation","html_url":"https://github.com/Normation","followers_url":"https://api.github.com/users/Normation/followers","following_url":"https://api.github.com/users/Normation/following{/other_user}","gists_url":"https://api.github.com/users/Normation/gists{/gist_id}","starred_url":"https://api.github.com/users/Normation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Normation/subscriptions","organizations_url":"https://api.github.com/users/Normation/orgs","repos_url":"https://api.github.com/users/Normation/repos","events_url":"https://api.github.com/users/Normation/events{/privacy}","received_events_url":"https://api.github.com/users/Normation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Normation/rudder-techniques","description":"","fork":false,"url":"https://api.github.com/repos/Normation/rudder-techniques","forks_url":"https://api.github.com/repos/Normation/rudder-techniques/forks","keys_url":"https://api.github.com/repos/Normation/rudder-techniques/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Normation/rudder-techniques/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Normation/rudder-techniques/teams","hooks_url":"https://api.github.com/repos/Normation/rudder-techniques/hooks","issue_events_url":"https://api.github.com/repos/Normation/rudder-techniques/issues/events{/number}","events_url":"https://api.github.com/repos/Normation/rudder-techniques/events","assignees_url":"https://api.github.com/repos/Normation/rudder-techniques/assignees{/user}","branches_url":"https://api.github.com/repos/Normation/rudder-techniques/branches{/branch}","tags_url":"https://api.github.com/repos/Normation/rudder-techniques/tags","blobs_url":"https://api.github.com/repos/Normation/rudder-techniques/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Normation/rudder-techniques/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Normation/rudder-techniques/git/refs{/sha}","trees_url":"https://api.github.com/repos/Normation/rudder-techniques/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Normation/rudder-techniques/statuses/{sha}","languages_url":"https://api.github.com/repos/Normation/rudder-techniques/languages","stargazers_url":"https://api.github.com/repos/Normation/rudder-techniques/stargazers","contributors_url":"https://api.github.com/repos/Normation/rudder-techniques/contributors","subscribers_url":"https://api.github.com/repos/Normation/rudder-techniques/subscribers","subscription_url":"https://api.github.com/repos/Normation/rudder-techniques/subscription","commits_url":"https://api.github.com/repos/Normation/rudder-techniques/commits{/sha}","git_commits_url":"https://api.github.com/repos/Normation/rudder-techniques/git/commits{/sha}","comments_url":"https://api.github.com/repos/Normation/rudder-techniques/comments{/number}","issue_comment_url":"https://api.github.com/repos/Normation/rudder-techniques/issues/comments/{number}","contents_url":"https://api.github.com/repos/Normation/rudder-techniques/contents/{+path}","compare_url":"https://api.github.com/repos/Normation/rudder-techniques/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Normation/rudder-techniques/merges","archive_url":"https://api.github.com/repos/Normation/rudder-techniques/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Normation/rudder-techniques/downloads","issues_url":"https://api.github.com/repos/Normation/rudder-techniques/issues{/number}","pulls_url":"https://api.github.com/repos/Normation/rudder-techniques/pulls{/number}","milestones_url":"https://api.github.com/repos/Normation/rudder-techniques/milestones{/number}","notifications_url":"https://api.github.com/repos/Normation/rudder-techniques/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Normation/rudder-techniques/labels{/name}","releases_url":"https://api.github.com/repos/Normation/rudder-techniques/releases{/id}","created_at":"2011-10-06T19:28:53Z","updated_at":"2014-11-26T16:00:54Z","pushed_at":"2014-11-27T17:08:01Z","git_url":"git://github.com/Normation/rudder-techniques.git","ssh_url":"git@github.com:Normation/rudder-techniques.git","clone_url":"https://github.com/Normation/rudder-techniques.git","svn_url":"https://github.com/Normation/rudder-techniques","homepage":"http://www.rudder-project.org/","size":48130,"stargazers_count":5,"watchers_count":5,"language":"Smalltalk","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":23,"forks":11,"open_issues":23,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Normation/rudder-techniques/pulls/574"},"html":{"href":"https://github.com/Normation/rudder-techniques/pull/574"},"issue":{"href":"https://api.github.com/repos/Normation/rudder-techniques/issues/574"},"comments":{"href":"https://api.github.com/repos/Normation/rudder-techniques/issues/574/comments"},"review_comments":{"href":"https://api.github.com/repos/Normation/rudder-techniques/pulls/574/comments"},"review_comment":{"href":"https://api.github.com/repos/Normation/rudder-techniques/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Normation/rudder-techniques/pulls/574/commits"},"statuses":{"href":"https://api.github.com/repos/Normation/rudder-techniques/statuses/35c2b39d5c978ad6c6e448ed156fbcca8aec48f2"}}}}