GitHub PullRequestReviewCommentEvent at 2014-12-17 16:08:14
Repository: engine
Actor: daredevildave
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/playcanvas/engine/pulls/comments/21981665","id":21981665,"diff_hunk":"@@ -92,6 +92,21 @@ pc.extend(pc.asset, function () {\n                 prefix = this.prefix;\n             }\n             return pc.path.join(prefix, url);\n+        },\n+\n+        /**\n+        * @name pc.asset.Asset#set\n+        * @function\n+        * @description Sets an asset property and fires a 'change' event if the property has changed\n+        * @example\n+        * asset.set('name', 'new_name');\n+        */\n+        set: function (name, value) {","path":"src/asset/asset_asset.js","position":13,"original_position":13,"commit_id":"748331f39cdce76e547c25379b59d0af83dc74c1","original_commit_id":"748331f39cdce76e547c25379b59d0af83dc74c1","user":{"login":"daredevildave","id":504980,"avatar_url":"https://avatars.githubusercontent.com/u/504980?v=3","gravatar_id":"","url":"https://api.github.com/users/daredevildave","html_url":"https://github.com/daredevildave","followers_url":"https://api.github.com/users/daredevildave/followers","following_url":"https://api.github.com/users/daredevildave/following{/other_user}","gists_url":"https://api.github.com/users/daredevildave/gists{/gist_id}","starred_url":"https://api.github.com/users/daredevildave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daredevildave/subscriptions","organizations_url":"https://api.github.com/users/daredevildave/orgs","repos_url":"https://api.github.com/users/daredevildave/repos","events_url":"https://api.github.com/users/daredevildave/events{/privacy}","received_events_url":"https://api.github.com/users/daredevildave/received_events","type":"User","site_admin":false},"body":"Can we do this with Object.defineProperty()? Nicer looking and less prone to someone doing it wrong.","created_at":"2014-12-17T16:08:14Z","updated_at":"2014-12-17T16:08:14Z","html_url":"https://github.com/playcanvas/engine/pull/120#discussion_r21981665","pull_request_url":"https://api.github.com/repos/playcanvas/engine/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/playcanvas/engine/pulls/comments/21981665"},"html":{"href":"https://github.com/playcanvas/engine/pull/120#discussion_r21981665"},"pull_request":{"href":"https://api.github.com/repos/playcanvas/engine/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/playcanvas/engine/pulls/120","id":26233926,"html_url":"https://github.com/playcanvas/engine/pull/120","diff_url":"https://github.com/playcanvas/engine/pull/120.diff","patch_url":"https://github.com/playcanvas/engine/pull/120.patch","issue_url":"https://api.github.com/repos/playcanvas/engine/issues/120","number":120,"state":"open","locked":false,"title":"Dynamically reload asset files when they change","user":{"login":"vkalpias","id":850969,"avatar_url":"https://avatars.githubusercontent.com/u/850969?v=3","gravatar_id":"","url":"https://api.github.com/users/vkalpias","html_url":"https://github.com/vkalpias","followers_url":"https://api.github.com/users/vkalpias/followers","following_url":"https://api.github.com/users/vkalpias/following{/other_user}","gists_url":"https://api.github.com/users/vkalpias/gists{/gist_id}","starred_url":"https://api.github.com/users/vkalpias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkalpias/subscriptions","organizations_url":"https://api.github.com/users/vkalpias/orgs","repos_url":"https://api.github.com/users/vkalpias/repos","events_url":"https://api.github.com/users/vkalpias/events{/privacy}","received_events_url":"https://api.github.com/users/vkalpias/received_events","type":"User","site_admin":false},"body":"All examples work.\r\nAlso tested Swooop, and a couple of other games and they all work.","created_at":"2014-12-17T15:55:15Z","updated_at":"2014-12-17T16:08:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59570cd73e5c464aa17964271315915d643ac389","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/playcanvas/engine/pulls/120/commits","review_comments_url":"https://api.github.com/repos/playcanvas/engine/pulls/120/comments","review_comment_url":"https://api.github.com/repos/playcanvas/engine/pulls/comments/{number}","comments_url":"https://api.github.com/repos/playcanvas/engine/issues/120/comments","statuses_url":"https://api.github.com/repos/playcanvas/engine/statuses/748331f39cdce76e547c25379b59d0af83dc74c1","head":{"label":"playcanvas:feature/reload-asset-files","ref":"feature/reload-asset-files","sha":"748331f39cdce76e547c25379b59d0af83dc74c1","user":{"login":"playcanvas","id":1030579,"avatar_url":"https://avatars.githubusercontent.com/u/1030579?v=3","gravatar_id":"","url":"https://api.github.com/users/playcanvas","html_url":"https://github.com/playcanvas","followers_url":"https://api.github.com/users/playcanvas/followers","following_url":"https://api.github.com/users/playcanvas/following{/other_user}","gists_url":"https://api.github.com/users/playcanvas/gists{/gist_id}","starred_url":"https://api.github.com/users/playcanvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playcanvas/subscriptions","organizations_url":"https://api.github.com/users/playcanvas/orgs","repos_url":"https://api.github.com/users/playcanvas/repos","events_url":"https://api.github.com/users/playcanvas/events{/privacy}","received_events_url":"https://api.github.com/users/playcanvas/received_events","type":"Organization","site_admin":false},"repo":{"id":19696006,"name":"engine","full_name":"playcanvas/engine","owner":{"login":"playcanvas","id":1030579,"avatar_url":"https://avatars.githubusercontent.com/u/1030579?v=3","gravatar_id":"","url":"https://api.github.com/users/playcanvas","html_url":"https://github.com/playcanvas","followers_url":"https://api.github.com/users/playcanvas/followers","following_url":"https://api.github.com/users/playcanvas/following{/other_user}","gists_url":"https://api.github.com/users/playcanvas/gists{/gist_id}","starred_url":"https://api.github.com/users/playcanvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playcanvas/subscriptions","organizations_url":"https://api.github.com/users/playcanvas/orgs","repos_url":"https://api.github.com/users/playcanvas/repos","events_url":"https://api.github.com/users/playcanvas/events{/privacy}","received_events_url":"https://api.github.com/users/playcanvas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playcanvas/engine","description":"3D WebGL game engine with online toolset.","fork":false,"url":"https://api.github.com/repos/playcanvas/engine","forks_url":"https://api.github.com/repos/playcanvas/engine/forks","keys_url":"https://api.github.com/repos/playcanvas/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playcanvas/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playcanvas/engine/teams","hooks_url":"https://api.github.com/repos/playcanvas/engine/hooks","issue_events_url":"https://api.github.com/repos/playcanvas/engine/issues/events{/number}","events_url":"https://api.github.com/repos/playcanvas/engine/events","assignees_url":"https://api.github.com/repos/playcanvas/engine/assignees{/user}","branches_url":"https://api.github.com/repos/playcanvas/engine/branches{/branch}","tags_url":"https://api.github.com/repos/playcanvas/engine/tags","blobs_url":"https://api.github.com/repos/playcanvas/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playcanvas/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playcanvas/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/playcanvas/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playcanvas/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/playcanvas/engine/languages","stargazers_url":"https://api.github.com/repos/playcanvas/engine/stargazers","contributors_url":"https://api.github.com/repos/playcanvas/engine/contributors","subscribers_url":"https://api.github.com/repos/playcanvas/engine/subscribers","subscription_url":"https://api.github.com/repos/playcanvas/engine/subscription","commits_url":"https://api.github.com/repos/playcanvas/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/playcanvas/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/playcanvas/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/playcanvas/engine/issues/comments/{number}","contents_url":"https://api.github.com/repos/playcanvas/engine/contents/{+path}","compare_url":"https://api.github.com/repos/playcanvas/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playcanvas/engine/merges","archive_url":"https://api.github.com/repos/playcanvas/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playcanvas/engine/downloads","issues_url":"https://api.github.com/repos/playcanvas/engine/issues{/number}","pulls_url":"https://api.github.com/repos/playcanvas/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/playcanvas/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/playcanvas/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playcanvas/engine/labels{/name}","releases_url":"https://api.github.com/repos/playcanvas/engine/releases{/id}","created_at":"2014-05-12T11:24:30Z","updated_at":"2014-12-16T18:51:08Z","pushed_at":"2014-12-17T15:53:22Z","git_url":"git://github.com/playcanvas/engine.git","ssh_url":"git@github.com:playcanvas/engine.git","clone_url":"https://github.com/playcanvas/engine.git","svn_url":"https://github.com/playcanvas/engine","homepage":"https://playcanvas.com/","size":55724,"stargazers_count":926,"watchers_count":926,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":26,"forks":151,"open_issues":26,"watchers":926,"default_branch":"master"}},"base":{"label":"playcanvas:master","ref":"master","sha":"8f5cfd943959816c1a46a57681801be0bc582189","user":{"login":"playcanvas","id":1030579,"avatar_url":"https://avatars.githubusercontent.com/u/1030579?v=3","gravatar_id":"","url":"https://api.github.com/users/playcanvas","html_url":"https://github.com/playcanvas","followers_url":"https://api.github.com/users/playcanvas/followers","following_url":"https://api.github.com/users/playcanvas/following{/other_user}","gists_url":"https://api.github.com/users/playcanvas/gists{/gist_id}","starred_url":"https://api.github.com/users/playcanvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playcanvas/subscriptions","organizations_url":"https://api.github.com/users/playcanvas/orgs","repos_url":"https://api.github.com/users/playcanvas/repos","events_url":"https://api.github.com/users/playcanvas/events{/privacy}","received_events_url":"https://api.github.com/users/playcanvas/received_events","type":"Organization","site_admin":false},"repo":{"id":19696006,"name":"engine","full_name":"playcanvas/engine","owner":{"login":"playcanvas","id":1030579,"avatar_url":"https://avatars.githubusercontent.com/u/1030579?v=3","gravatar_id":"","url":"https://api.github.com/users/playcanvas","html_url":"https://github.com/playcanvas","followers_url":"https://api.github.com/users/playcanvas/followers","following_url":"https://api.github.com/users/playcanvas/following{/other_user}","gists_url":"https://api.github.com/users/playcanvas/gists{/gist_id}","starred_url":"https://api.github.com/users/playcanvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playcanvas/subscriptions","organizations_url":"https://api.github.com/users/playcanvas/orgs","repos_url":"https://api.github.com/users/playcanvas/repos","events_url":"https://api.github.com/users/playcanvas/events{/privacy}","received_events_url":"https://api.github.com/users/playcanvas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playcanvas/engine","description":"3D WebGL game engine with online toolset.","fork":false,"url":"https://api.github.com/repos/playcanvas/engine","forks_url":"https://api.github.com/repos/playcanvas/engine/forks","keys_url":"https://api.github.com/repos/playcanvas/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playcanvas/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playcanvas/engine/teams","hooks_url":"https://api.github.com/repos/playcanvas/engine/hooks","issue_events_url":"https://api.github.com/repos/playcanvas/engine/issues/events{/number}","events_url":"https://api.github.com/repos/playcanvas/engine/events","assignees_url":"https://api.github.com/repos/playcanvas/engine/assignees{/user}","branches_url":"https://api.github.com/repos/playcanvas/engine/branches{/branch}","tags_url":"https://api.github.com/repos/playcanvas/engine/tags","blobs_url":"https://api.github.com/repos/playcanvas/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playcanvas/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playcanvas/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/playcanvas/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playcanvas/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/playcanvas/engine/languages","stargazers_url":"https://api.github.com/repos/playcanvas/engine/stargazers","contributors_url":"https://api.github.com/repos/playcanvas/engine/contributors","subscribers_url":"https://api.github.com/repos/playcanvas/engine/subscribers","subscription_url":"https://api.github.com/repos/playcanvas/engine/subscription","commits_url":"https://api.github.com/repos/playcanvas/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/playcanvas/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/playcanvas/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/playcanvas/engine/issues/comments/{number}","contents_url":"https://api.github.com/repos/playcanvas/engine/contents/{+path}","compare_url":"https://api.github.com/repos/playcanvas/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playcanvas/engine/merges","archive_url":"https://api.github.com/repos/playcanvas/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playcanvas/engine/downloads","issues_url":"https://api.github.com/repos/playcanvas/engine/issues{/number}","pulls_url":"https://api.github.com/repos/playcanvas/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/playcanvas/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/playcanvas/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playcanvas/engine/labels{/name}","releases_url":"https://api.github.com/repos/playcanvas/engine/releases{/id}","created_at":"2014-05-12T11:24:30Z","updated_at":"2014-12-16T18:51:08Z","pushed_at":"2014-12-17T15:53:22Z","git_url":"git://github.com/playcanvas/engine.git","ssh_url":"git@github.com:playcanvas/engine.git","clone_url":"https://github.com/playcanvas/engine.git","svn_url":"https://github.com/playcanvas/engine","homepage":"https://playcanvas.com/","size":55724,"stargazers_count":926,"watchers_count":926,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":26,"forks":151,"open_issues":26,"watchers":926,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playcanvas/engine/pulls/120"},"html":{"href":"https://github.com/playcanvas/engine/pull/120"},"issue":{"href":"https://api.github.com/repos/playcanvas/engine/issues/120"},"comments":{"href":"https://api.github.com/repos/playcanvas/engine/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/playcanvas/engine/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/playcanvas/engine/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/playcanvas/engine/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/playcanvas/engine/statuses/748331f39cdce76e547c25379b59d0af83dc74c1"}}}}