GitHub PullRequestReviewCommentEvent at 2014-12-09 16:39:59
Repository: MyJobs
Actor: tdphillips
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/comments/21541084","id":21541084,"diff_hunk":"@@ -632,14 +632,14 @@ def read_new_logs(solr_location=None):\n \n @task(name='tasks.expire_jobs', ignore_result=True)\n def expire_jobs():\n-    jobs = Job.objects.filter(date_expired=date.today(),\n+    jobs = Job.objects.filter(date_expired__lt=date.today(),","path":"tasks.py","position":5,"original_position":5,"commit_id":"2f41d45f88e1feb283d7535a2ef96e1d6af55d75","original_commit_id":"2f41d45f88e1feb283d7535a2ef96e1d6af55d75","user":{"login":"tdphillips","id":3379265,"avatar_url":"https://avatars.githubusercontent.com/u/3379265?v=3","gravatar_id":"","url":"https://api.github.com/users/tdphillips","html_url":"https://github.com/tdphillips","followers_url":"https://api.github.com/users/tdphillips/followers","following_url":"https://api.github.com/users/tdphillips/following{/other_user}","gists_url":"https://api.github.com/users/tdphillips/gists{/gist_id}","starred_url":"https://api.github.com/users/tdphillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdphillips/subscriptions","organizations_url":"https://api.github.com/users/tdphillips/orgs","repos_url":"https://api.github.com/users/tdphillips/repos","events_url":"https://api.github.com/users/tdphillips/events{/privacy}","received_events_url":"https://api.github.com/users/tdphillips/received_events","type":"User","site_admin":false},"body":"I assume this was the response to your discussion with @JLMcLaugh RE expiring today at 00:01 vs today at 23:59?","created_at":"2014-12-09T16:39:59Z","updated_at":"2014-12-09T16:39:59Z","html_url":"https://github.com/DirectEmployers/MyJobs/pull/1073#discussion_r21541084","pull_request_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/1073","_links":{"self":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/comments/21541084"},"html":{"href":"https://github.com/DirectEmployers/MyJobs/pull/1073#discussion_r21541084"},"pull_request":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/1073"}}},"pull_request":{"url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/1073","id":25756812,"html_url":"https://github.com/DirectEmployers/MyJobs/pull/1073","diff_url":"https://github.com/DirectEmployers/MyJobs/pull/1073.diff","patch_url":"https://github.com/DirectEmployers/MyJobs/pull/1073.patch","issue_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/1073","number":1073,"state":"open","locked":false,"title":"Force expiration task to pick up any unexpired jobs that should have been expired rather than just jobs that should expire today [PD-691]","user":{"login":"almathew","id":2728248,"avatar_url":"https://avatars.githubusercontent.com/u/2728248?v=3","gravatar_id":"","url":"https://api.github.com/users/almathew","html_url":"https://github.com/almathew","followers_url":"https://api.github.com/users/almathew/followers","following_url":"https://api.github.com/users/almathew/following{/other_user}","gists_url":"https://api.github.com/users/almathew/gists{/gist_id}","starred_url":"https://api.github.com/users/almathew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almathew/subscriptions","organizations_url":"https://api.github.com/users/almathew/orgs","repos_url":"https://api.github.com/users/almathew/repos","events_url":"https://api.github.com/users/almathew/events{/privacy}","received_events_url":"https://api.github.com/users/almathew/received_events","type":"User","site_admin":false},"body":"I've been unable to actually replicate this. My best theory is that the task failed on the day the job was actually set to expire, so it was never actually picked up for expiration. I've updated the task so that a job will expire the next time the task runs if for some reason it doesn't expire the exact day it's supposed to.\r\n\r\nAll tests pass.\r\n\r\n","created_at":"2014-12-09T16:37:30Z","updated_at":"2014-12-09T16:39:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46ef4c480751f21004a33a5fa9531083cbd3936e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/1073/commits","review_comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/1073/comments","review_comment_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/1073/comments","statuses_url":"https://api.github.com/repos/DirectEmployers/MyJobs/statuses/2f41d45f88e1feb283d7535a2ef96e1d6af55d75","head":{"label":"DirectEmployers:job-expiration","ref":"job-expiration","sha":"2f41d45f88e1feb283d7535a2ef96e1d6af55d75","user":{"login":"DirectEmployers","id":381171,"avatar_url":"https://avatars.githubusercontent.com/u/381171?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectEmployers","html_url":"https://github.com/DirectEmployers","followers_url":"https://api.github.com/users/DirectEmployers/followers","following_url":"https://api.github.com/users/DirectEmployers/following{/other_user}","gists_url":"https://api.github.com/users/DirectEmployers/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectEmployers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectEmployers/subscriptions","organizations_url":"https://api.github.com/users/DirectEmployers/orgs","repos_url":"https://api.github.com/users/DirectEmployers/repos","events_url":"https://api.github.com/users/DirectEmployers/events{/privacy}","received_events_url":"https://api.github.com/users/DirectEmployers/received_events","type":"Organization","site_admin":false},"repo":{"id":2867982,"name":"MyJobs","full_name":"DirectEmployers/MyJobs","owner":{"login":"DirectEmployers","id":381171,"avatar_url":"https://avatars.githubusercontent.com/u/381171?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectEmployers","html_url":"https://github.com/DirectEmployers","followers_url":"https://api.github.com/users/DirectEmployers/followers","following_url":"https://api.github.com/users/DirectEmployers/following{/other_user}","gists_url":"https://api.github.com/users/DirectEmployers/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectEmployers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectEmployers/subscriptions","organizations_url":"https://api.github.com/users/DirectEmployers/orgs","repos_url":"https://api.github.com/users/DirectEmployers/repos","events_url":"https://api.github.com/users/DirectEmployers/events{/privacy}","received_events_url":"https://api.github.com/users/DirectEmployers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DirectEmployers/MyJobs","description":"Multi-user website designed to assist job seekers in their search for employment","fork":false,"url":"https://api.github.com/repos/DirectEmployers/MyJobs","forks_url":"https://api.github.com/repos/DirectEmployers/MyJobs/forks","keys_url":"https://api.github.com/repos/DirectEmployers/MyJobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DirectEmployers/MyJobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DirectEmployers/MyJobs/teams","hooks_url":"https://api.github.com/repos/DirectEmployers/MyJobs/hooks","issue_events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/events{/number}","events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/events","assignees_url":"https://api.github.com/repos/DirectEmployers/MyJobs/assignees{/user}","branches_url":"https://api.github.com/repos/DirectEmployers/MyJobs/branches{/branch}","tags_url":"https://api.github.com/repos/DirectEmployers/MyJobs/tags","blobs_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DirectEmployers/MyJobs/statuses/{sha}","languages_url":"https://api.github.com/repos/DirectEmployers/MyJobs/languages","stargazers_url":"https://api.github.com/repos/DirectEmployers/MyJobs/stargazers","contributors_url":"https://api.github.com/repos/DirectEmployers/MyJobs/contributors","subscribers_url":"https://api.github.com/repos/DirectEmployers/MyJobs/subscribers","subscription_url":"https://api.github.com/repos/DirectEmployers/MyJobs/subscription","commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/comments/{number}","contents_url":"https://api.github.com/repos/DirectEmployers/MyJobs/contents/{+path}","compare_url":"https://api.github.com/repos/DirectEmployers/MyJobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DirectEmployers/MyJobs/merges","archive_url":"https://api.github.com/repos/DirectEmployers/MyJobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DirectEmployers/MyJobs/downloads","issues_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues{/number}","pulls_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls{/number}","milestones_url":"https://api.github.com/repos/DirectEmployers/MyJobs/milestones{/number}","notifications_url":"https://api.github.com/repos/DirectEmployers/MyJobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DirectEmployers/MyJobs/labels{/name}","releases_url":"https://api.github.com/repos/DirectEmployers/MyJobs/releases{/id}","created_at":"2011-11-28T15:22:36Z","updated_at":"2014-12-09T15:22:16Z","pushed_at":"2014-12-09T16:34:37Z","git_url":"git://github.com/DirectEmployers/MyJobs.git","ssh_url":"git@github.com:DirectEmployers/MyJobs.git","clone_url":"https://github.com/DirectEmployers/MyJobs.git","svn_url":"https://github.com/DirectEmployers/MyJobs","homepage":"http://my.jobs","size":21865,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"DirectEmployers:master","ref":"master","sha":"c27110227d69ccfbd707ea19f5429a37571f62c3","user":{"login":"DirectEmployers","id":381171,"avatar_url":"https://avatars.githubusercontent.com/u/381171?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectEmployers","html_url":"https://github.com/DirectEmployers","followers_url":"https://api.github.com/users/DirectEmployers/followers","following_url":"https://api.github.com/users/DirectEmployers/following{/other_user}","gists_url":"https://api.github.com/users/DirectEmployers/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectEmployers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectEmployers/subscriptions","organizations_url":"https://api.github.com/users/DirectEmployers/orgs","repos_url":"https://api.github.com/users/DirectEmployers/repos","events_url":"https://api.github.com/users/DirectEmployers/events{/privacy}","received_events_url":"https://api.github.com/users/DirectEmployers/received_events","type":"Organization","site_admin":false},"repo":{"id":2867982,"name":"MyJobs","full_name":"DirectEmployers/MyJobs","owner":{"login":"DirectEmployers","id":381171,"avatar_url":"https://avatars.githubusercontent.com/u/381171?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectEmployers","html_url":"https://github.com/DirectEmployers","followers_url":"https://api.github.com/users/DirectEmployers/followers","following_url":"https://api.github.com/users/DirectEmployers/following{/other_user}","gists_url":"https://api.github.com/users/DirectEmployers/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectEmployers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectEmployers/subscriptions","organizations_url":"https://api.github.com/users/DirectEmployers/orgs","repos_url":"https://api.github.com/users/DirectEmployers/repos","events_url":"https://api.github.com/users/DirectEmployers/events{/privacy}","received_events_url":"https://api.github.com/users/DirectEmployers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DirectEmployers/MyJobs","description":"Multi-user website designed to assist job seekers in their search for employment","fork":false,"url":"https://api.github.com/repos/DirectEmployers/MyJobs","forks_url":"https://api.github.com/repos/DirectEmployers/MyJobs/forks","keys_url":"https://api.github.com/repos/DirectEmployers/MyJobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DirectEmployers/MyJobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DirectEmployers/MyJobs/teams","hooks_url":"https://api.github.com/repos/DirectEmployers/MyJobs/hooks","issue_events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/events{/number}","events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/events","assignees_url":"https://api.github.com/repos/DirectEmployers/MyJobs/assignees{/user}","branches_url":"https://api.github.com/repos/DirectEmployers/MyJobs/branches{/branch}","tags_url":"https://api.github.com/repos/DirectEmployers/MyJobs/tags","blobs_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DirectEmployers/MyJobs/statuses/{sha}","languages_url":"https://api.github.com/repos/DirectEmployers/MyJobs/languages","stargazers_url":"https://api.github.com/repos/DirectEmployers/MyJobs/stargazers","contributors_url":"https://api.github.com/repos/DirectEmployers/MyJobs/contributors","subscribers_url":"https://api.github.com/repos/DirectEmployers/MyJobs/subscribers","subscription_url":"https://api.github.com/repos/DirectEmployers/MyJobs/subscription","commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/comments/{number}","contents_url":"https://api.github.com/repos/DirectEmployers/MyJobs/contents/{+path}","compare_url":"https://api.github.com/repos/DirectEmployers/MyJobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DirectEmployers/MyJobs/merges","archive_url":"https://api.github.com/repos/DirectEmployers/MyJobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DirectEmployers/MyJobs/downloads","issues_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues{/number}","pulls_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls{/number}","milestones_url":"https://api.github.com/repos/DirectEmployers/MyJobs/milestones{/number}","notifications_url":"https://api.github.com/repos/DirectEmployers/MyJobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DirectEmployers/MyJobs/labels{/name}","releases_url":"https://api.github.com/repos/DirectEmployers/MyJobs/releases{/id}","created_at":"2011-11-28T15:22:36Z","updated_at":"2014-12-09T15:22:16Z","pushed_at":"2014-12-09T16:34:37Z","git_url":"git://github.com/DirectEmployers/MyJobs.git","ssh_url":"git@github.com:DirectEmployers/MyJobs.git","clone_url":"https://github.com/DirectEmployers/MyJobs.git","svn_url":"https://github.com/DirectEmployers/MyJobs","homepage":"http://my.jobs","size":21865,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/1073"},"html":{"href":"https://github.com/DirectEmployers/MyJobs/pull/1073"},"issue":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/1073"},"comments":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/1073/comments"},"review_comments":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/1073/comments"},"review_comment":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/1073/commits"},"statuses":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/statuses/2f41d45f88e1feb283d7535a2ef96e1d6af55d75"}}}}