GitHub PullRequestReviewCommentEvent at 2014-05-13 11:15:44
Repository: phpbb
Actor: lucifer4o
Payload: {"comment":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/12577881","id":12577881,"diff_hunk":"@@ -115,6 +115,52 @@ public function generate_field($profile_row, $preview_options = false)\n \t/**\n \t* {@inheritDoc}\n \t*/\n+\tpublic function generate_search_field($profile_row, $preview_options = false)\n+\t{\n+\t\t$profile_row['field_ident'] = (isset($profile_row['var_name'])) ? $profile_row['var_name'] : 'pf_' . $profile_row['field_ident'];\n+\t\t$field_ident = $profile_row['field_ident'];\n+\t\t$default_value = $profile_row['lang_default_value'];\n+\t\t$profile_row['field_value'] = $this->request->variable($field_ident, $default_value, true);\n+\n+\t\t$this->template->assign_block_vars($this->get_name_short(), array_change_key_case($profile_row, CASE_UPPER));\n+\t}\n+\n+\t/**\n+\t* {@inheritDoc}\n+\t*/\n+\tpublic function get_search_array($profile_row)\n+\t{\n+\t\t$output = array(\n+\t\t\t'field_ident'\t=> 'pf_' . $profile_row['field_ident'],\n+\t\t\t'field_novalue'\t=> $profile_row['field_novalue'],\n+\t\t\t'field_multibyte'\t=> true,\n+\t\t);\n+\t\treturn $output;\n+\t}\n+\n+\t/**\n+\t* {@inheritDoc}\n+\t*/\n+\tpublic function make_sql_where($profile_row, $db_object, $table_prefix = 'pd')\n+\t{\n+\t\t// Let's check if the value is set ... and is it diferent from novalue\n+\t\t$profile_row['field_ident'] = 'pf_' . $profile_row['field_ident'];\n+\t\t$field_ident = $profile_row['field_ident'];","path":"phpBB/phpbb/profilefields/type/type_string.php","position":34,"original_position":34,"commit_id":"fe3533d8cb15041302b4766f1b8564a6b34abc85","original_commit_id":"fe3533d8cb15041302b4766f1b8564a6b34abc85","user":{"login":"lucifer4o","id":1131662,"avatar_url":"https://avatars.githubusercontent.com/u/1131662?","gravatar_id":"32368b11819397d60d3e2f91d616b409","url":"https://api.github.com/users/lucifer4o","html_url":"https://github.com/lucifer4o","followers_url":"https://api.github.com/users/lucifer4o/followers","following_url":"https://api.github.com/users/lucifer4o/following{/other_user}","gists_url":"https://api.github.com/users/lucifer4o/gists{/gist_id}","starred_url":"https://api.github.com/users/lucifer4o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucifer4o/subscriptions","organizations_url":"https://api.github.com/users/lucifer4o/orgs","repos_url":"https://api.github.com/users/lucifer4o/repos","events_url":"https://api.github.com/users/lucifer4o/events{/privacy}","received_events_url":"https://api.github.com/users/lucifer4o/received_events","type":"User","site_admin":false},"body":"Done for all type classes","created_at":"2014-05-13T11:15:44Z","updated_at":"2014-05-13T11:15:44Z","html_url":"https://github.com/phpbb/phpbb/pull/2344#discussion_r12577881","pull_request_url":"https://api.github.com/repos/phpbb/phpbb/pulls/2344","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/12577881"},"html":{"href":"https://github.com/phpbb/phpbb/pull/2344#discussion_r12577881"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/2344"}}}}