GitHub PullRequestReviewCommentEvent at 2014-07-17 16:33:04
Repository: ucam-smt
Actor: aurelienwaite
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls/comments/15068130","id":15068130,"diff_hunk":"@@ -213,37 +193,26 @@ public Rule(int sourceStartIndex, int sourceEndIndex, int minTargetIndex,\n \t\t\tint minTargetIndexX, int maxTargetIndexX, SentencePair sp,\n \t\t\tAlignment a) {\n \t\tthis.leftHandSide = 0;\n-\t\tthis.nbNonTerminal = 1;\n \t\tsource = new ArrayList<Integer>();\n-\t\tnumberUnalignedSourceWords = 0;\n-\t\tnumberUnalignedTargetWords = 0;\n \t\tfor (int sourceIndex = sourceStartIndex; sourceIndex < sourceStartIndexX; sourceIndex++) {","path":"java/ruleXtract/src/main/java/uk/ac/cam/eng/extraction/datatypes/Rule.java","position":122,"original_position":122,"commit_id":"a1bf59b8215aad926ea5750ff64bfd35ef923671","original_commit_id":"a1bf59b8215aad926ea5750ff64bfd35ef923671","user":{"login":"aurelienwaite","id":7770232,"avatar_url":"https://avatars.githubusercontent.com/u/7770232?","gravatar_id":"39e1042822f5f1b568eae7c135b00335","url":"https://api.github.com/users/aurelienwaite","html_url":"https://github.com/aurelienwaite","followers_url":"https://api.github.com/users/aurelienwaite/followers","following_url":"https://api.github.com/users/aurelienwaite/following{/other_user}","gists_url":"https://api.github.com/users/aurelienwaite/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelienwaite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelienwaite/subscriptions","organizations_url":"https://api.github.com/users/aurelienwaite/orgs","repos_url":"https://api.github.com/users/aurelienwaite/repos","events_url":"https://api.github.com/users/aurelienwaite/events{/privacy}","received_events_url":"https://api.github.com/users/aurelienwaite/received_events","type":"User","site_admin":false},"body":"Again it feels to be that this code should be building the alignment object, rather than delegating it.","created_at":"2014-07-17T16:33:04Z","updated_at":"2014-07-17T16:33:04Z","html_url":"https://github.com/ucam-smt/ucam-smt/pull/12#discussion_r15068130","pull_request_url":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls/comments/15068130"},"html":{"href":"https://github.com/ucam-smt/ucam-smt/pull/12#discussion_r15068130"},"pull_request":{"href":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls/12","id":18533587,"html_url":"https://github.com/ucam-smt/ucam-smt/pull/12","diff_url":"https://github.com/ucam-smt/ucam-smt/pull/12.diff","patch_url":"https://github.com/ucam-smt/ucam-smt/pull/12.patch","issue_url":"https://api.github.com/repos/ucam-smt/ucam-smt/issues/12","number":12,"state":"open","title":"Added word alignment information for extracted rules.","user":{"login":"jmp84","id":1144053,"avatar_url":"https://avatars.githubusercontent.com/u/1144053?","gravatar_id":"05e0ad93d9c8c7e572c6f73feb649aeb","url":"https://api.github.com/users/jmp84","html_url":"https://github.com/jmp84","followers_url":"https://api.github.com/users/jmp84/followers","following_url":"https://api.github.com/users/jmp84/following{/other_user}","gists_url":"https://api.github.com/users/jmp84/gists{/gist_id}","starred_url":"https://api.github.com/users/jmp84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmp84/subscriptions","organizations_url":"https://api.github.com/users/jmp84/orgs","repos_url":"https://api.github.com/users/jmp84/repos","events_url":"https://api.github.com/users/jmp84/events{/privacy}","received_events_url":"https://api.github.com/users/jmp84/received_events","type":"User","site_admin":false},"body":"In the extraction phase, word alignment info is written\r\nto an output value together with provenance counts.\r\nThe word alignment is kept until the merge phase and written\r\nto the HFiles. For extraction, feature computation and merging,\r\nthe alignment info is always kept as a MapReduce value rather than\r\nkey to preserve the structure of RuleWritable (3 fields: lhs, src and trg).\r\nAll alignments and counts are in the HFile. At retrieval time, any local\r\nfeature that takes into account these alignments can be computed.\r\nFor example, it's possible to keep the most frequent alignment or\r\nall of them with their frequency.","created_at":"2014-07-17T15:02:53Z","updated_at":"2014-07-17T16:33:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"431dd5dc47e2f61debbaa1de66acd01dac5aa828","assignee":{"login":"aurelienwaite","id":7770232,"avatar_url":"https://avatars.githubusercontent.com/u/7770232?","gravatar_id":"39e1042822f5f1b568eae7c135b00335","url":"https://api.github.com/users/aurelienwaite","html_url":"https://github.com/aurelienwaite","followers_url":"https://api.github.com/users/aurelienwaite/followers","following_url":"https://api.github.com/users/aurelienwaite/following{/other_user}","gists_url":"https://api.github.com/users/aurelienwaite/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelienwaite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelienwaite/subscriptions","organizations_url":"https://api.github.com/users/aurelienwaite/orgs","repos_url":"https://api.github.com/users/aurelienwaite/repos","events_url":"https://api.github.com/users/aurelienwaite/events{/privacy}","received_events_url":"https://api.github.com/users/aurelienwaite/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls/12/commits","review_comments_url":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls/12/comments","review_comment_url":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ucam-smt/ucam-smt/issues/12/comments","statuses_url":"https://api.github.com/repos/ucam-smt/ucam-smt/statuses/a1bf59b8215aad926ea5750ff64bfd35ef923671","head":{"label":"ucam-smt:rulextract-alignment","ref":"rulextract-alignment","sha":"a1bf59b8215aad926ea5750ff64bfd35ef923671","user":{"login":"ucam-smt","id":7556739,"avatar_url":"https://avatars.githubusercontent.com/u/7556739?","gravatar_id":null,"url":"https://api.github.com/users/ucam-smt","html_url":"https://github.com/ucam-smt","followers_url":"https://api.github.com/users/ucam-smt/followers","following_url":"https://api.github.com/users/ucam-smt/following{/other_user}","gists_url":"https://api.github.com/users/ucam-smt/gists{/gist_id}","starred_url":"https://api.github.com/users/ucam-smt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucam-smt/subscriptions","organizations_url":"https://api.github.com/users/ucam-smt/orgs","repos_url":"https://api.github.com/users/ucam-smt/repos","events_url":"https://api.github.com/users/ucam-smt/events{/privacy}","received_events_url":"https://api.github.com/users/ucam-smt/received_events","type":"Organization","site_admin":false},"repo":{"id":19546856,"name":"ucam-smt","full_name":"ucam-smt/ucam-smt","owner":{"login":"ucam-smt","id":7556739,"avatar_url":"https://avatars.githubusercontent.com/u/7556739?","gravatar_id":null,"url":"https://api.github.com/users/ucam-smt","html_url":"https://github.com/ucam-smt","followers_url":"https://api.github.com/users/ucam-smt/followers","following_url":"https://api.github.com/users/ucam-smt/following{/other_user}","gists_url":"https://api.github.com/users/ucam-smt/gists{/gist_id}","starred_url":"https://api.github.com/users/ucam-smt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucam-smt/subscriptions","organizations_url":"https://api.github.com/users/ucam-smt/orgs","repos_url":"https://api.github.com/users/ucam-smt/repos","events_url":"https://api.github.com/users/ucam-smt/events{/privacy}","received_events_url":"https://api.github.com/users/ucam-smt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucam-smt/ucam-smt","description":"Cambridge SMT System","fork":false,"url":"https://api.github.com/repos/ucam-smt/ucam-smt","forks_url":"https://api.github.com/repos/ucam-smt/ucam-smt/forks","keys_url":"https://api.github.com/repos/ucam-smt/ucam-smt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucam-smt/ucam-smt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucam-smt/ucam-smt/teams","hooks_url":"https://api.github.com/repos/ucam-smt/ucam-smt/hooks","issue_events_url":"https://api.github.com/repos/ucam-smt/ucam-smt/issues/events{/number}","events_url":"https://api.github.com/repos/ucam-smt/ucam-smt/events","assignees_url":"https://api.github.com/repos/ucam-smt/ucam-smt/assignees{/user}","branches_url":"https://api.github.com/repos/ucam-smt/ucam-smt/branches{/branch}","tags_url":"https://api.github.com/repos/ucam-smt/ucam-smt/tags","blobs_url":"https://api.github.com/repos/ucam-smt/ucam-smt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucam-smt/ucam-smt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucam-smt/ucam-smt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucam-smt/ucam-smt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucam-smt/ucam-smt/statuses/{sha}","languages_url":"https://api.github.com/repos/ucam-smt/ucam-smt/languages","stargazers_url":"https://api.github.com/repos/ucam-smt/ucam-smt/stargazers","contributors_url":"https://api.github.com/repos/ucam-smt/ucam-smt/contributors","subscribers_url":"https://api.github.com/repos/ucam-smt/ucam-smt/subscribers","subscription_url":"https://api.github.com/repos/ucam-smt/ucam-smt/subscription","commits_url":"https://api.github.com/repos/ucam-smt/ucam-smt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucam-smt/ucam-smt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucam-smt/ucam-smt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucam-smt/ucam-smt/issues/comments/{number}","contents_url":"https://api.github.com/repos/ucam-smt/ucam-smt/contents/{+path}","compare_url":"https://api.github.com/repos/ucam-smt/ucam-smt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucam-smt/ucam-smt/merges","archive_url":"https://api.github.com/repos/ucam-smt/ucam-smt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucam-smt/ucam-smt/downloads","issues_url":"https://api.github.com/repos/ucam-smt/ucam-smt/issues{/number}","pulls_url":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls{/number}","milestones_url":"https://api.github.com/repos/ucam-smt/ucam-smt/milestones{/number}","notifications_url":"https://api.github.com/repos/ucam-smt/ucam-smt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucam-smt/ucam-smt/labels{/name}","releases_url":"https://api.github.com/repos/ucam-smt/ucam-smt/releases{/id}","created_at":"2014-05-07T19:12:14Z","updated_at":"2014-07-02T06:39:23Z","pushed_at":"2014-07-17T15:01:32Z","git_url":"git://github.com/ucam-smt/ucam-smt.git","ssh_url":"git@github.com:ucam-smt/ucam-smt.git","clone_url":"https://github.com/ucam-smt/ucam-smt.git","svn_url":"https://github.com/ucam-smt/ucam-smt","homepage":"http://ucam-smt.github.io/","size":6350,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":9,"default_branch":"master"}},"base":{"label":"ucam-smt:rulextract","ref":"rulextract","sha":"8ca1291d877898e044bf26a5b2c71fef0b6158fe","user":{"login":"ucam-smt","id":7556739,"avatar_url":"https://avatars.githubusercontent.com/u/7556739?","gravatar_id":null,"url":"https://api.github.com/users/ucam-smt","html_url":"https://github.com/ucam-smt","followers_url":"https://api.github.com/users/ucam-smt/followers","following_url":"https://api.github.com/users/ucam-smt/following{/other_user}","gists_url":"https://api.github.com/users/ucam-smt/gists{/gist_id}","starred_url":"https://api.github.com/users/ucam-smt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucam-smt/subscriptions","organizations_url":"https://api.github.com/users/ucam-smt/orgs","repos_url":"https://api.github.com/users/ucam-smt/repos","events_url":"https://api.github.com/users/ucam-smt/events{/privacy}","received_events_url":"https://api.github.com/users/ucam-smt/received_events","type":"Organization","site_admin":false},"repo":{"id":19546856,"name":"ucam-smt","full_name":"ucam-smt/ucam-smt","owner":{"login":"ucam-smt","id":7556739,"avatar_url":"https://avatars.githubusercontent.com/u/7556739?","gravatar_id":null,"url":"https://api.github.com/users/ucam-smt","html_url":"https://github.com/ucam-smt","followers_url":"https://api.github.com/users/ucam-smt/followers","following_url":"https://api.github.com/users/ucam-smt/following{/other_user}","gists_url":"https://api.github.com/users/ucam-smt/gists{/gist_id}","starred_url":"https://api.github.com/users/ucam-smt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucam-smt/subscriptions","organizations_url":"https://api.github.com/users/ucam-smt/orgs","repos_url":"https://api.github.com/users/ucam-smt/repos","events_url":"https://api.github.com/users/ucam-smt/events{/privacy}","received_events_url":"https://api.github.com/users/ucam-smt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucam-smt/ucam-smt","description":"Cambridge SMT System","fork":false,"url":"https://api.github.com/repos/ucam-smt/ucam-smt","forks_url":"https://api.github.com/repos/ucam-smt/ucam-smt/forks","keys_url":"https://api.github.com/repos/ucam-smt/ucam-smt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucam-smt/ucam-smt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucam-smt/ucam-smt/teams","hooks_url":"https://api.github.com/repos/ucam-smt/ucam-smt/hooks","issue_events_url":"https://api.github.com/repos/ucam-smt/ucam-smt/issues/events{/number}","events_url":"https://api.github.com/repos/ucam-smt/ucam-smt/events","assignees_url":"https://api.github.com/repos/ucam-smt/ucam-smt/assignees{/user}","branches_url":"https://api.github.com/repos/ucam-smt/ucam-smt/branches{/branch}","tags_url":"https://api.github.com/repos/ucam-smt/ucam-smt/tags","blobs_url":"https://api.github.com/repos/ucam-smt/ucam-smt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucam-smt/ucam-smt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucam-smt/ucam-smt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucam-smt/ucam-smt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucam-smt/ucam-smt/statuses/{sha}","languages_url":"https://api.github.com/repos/ucam-smt/ucam-smt/languages","stargazers_url":"https://api.github.com/repos/ucam-smt/ucam-smt/stargazers","contributors_url":"https://api.github.com/repos/ucam-smt/ucam-smt/contributors","subscribers_url":"https://api.github.com/repos/ucam-smt/ucam-smt/subscribers","subscription_url":"https://api.github.com/repos/ucam-smt/ucam-smt/subscription","commits_url":"https://api.github.com/repos/ucam-smt/ucam-smt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucam-smt/ucam-smt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucam-smt/ucam-smt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucam-smt/ucam-smt/issues/comments/{number}","contents_url":"https://api.github.com/repos/ucam-smt/ucam-smt/contents/{+path}","compare_url":"https://api.github.com/repos/ucam-smt/ucam-smt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucam-smt/ucam-smt/merges","archive_url":"https://api.github.com/repos/ucam-smt/ucam-smt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucam-smt/ucam-smt/downloads","issues_url":"https://api.github.com/repos/ucam-smt/ucam-smt/issues{/number}","pulls_url":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls{/number}","milestones_url":"https://api.github.com/repos/ucam-smt/ucam-smt/milestones{/number}","notifications_url":"https://api.github.com/repos/ucam-smt/ucam-smt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucam-smt/ucam-smt/labels{/name}","releases_url":"https://api.github.com/repos/ucam-smt/ucam-smt/releases{/id}","created_at":"2014-05-07T19:12:14Z","updated_at":"2014-07-02T06:39:23Z","pushed_at":"2014-07-17T15:01:32Z","git_url":"git://github.com/ucam-smt/ucam-smt.git","ssh_url":"git@github.com:ucam-smt/ucam-smt.git","clone_url":"https://github.com/ucam-smt/ucam-smt.git","svn_url":"https://github.com/ucam-smt/ucam-smt","homepage":"http://ucam-smt.github.io/","size":6350,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls/12"},"html":{"href":"https://github.com/ucam-smt/ucam-smt/pull/12"},"issue":{"href":"https://api.github.com/repos/ucam-smt/ucam-smt/issues/12"},"comments":{"href":"https://api.github.com/repos/ucam-smt/ucam-smt/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ucam-smt/ucam-smt/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/ucam-smt/ucam-smt/statuses/a1bf59b8215aad926ea5750ff64bfd35ef923671"}}}}