GitHub PullRequestEvent at 2014-10-10 22:14:12
Repository: gaffer
Actor: andrewkaufman
Payload: {"action":"closed","number":1035,"pull_request":{"url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1035","id":22565981,"html_url":"https://github.com/ImageEngine/gaffer/pull/1035","diff_url":"https://github.com/ImageEngine/gaffer/pull/1035.diff","patch_url":"https://github.com/ImageEngine/gaffer/pull/1035.patch","issue_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1035","number":1035,"state":"closed","locked":false,"title":"Better management of different shader types","user":{"login":"johnhaddon","id":1133871,"avatar_url":"https://avatars.githubusercontent.com/u/1133871?v=2","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"body":"This pull request does two things :\r\n\r\n- Maintains renderer prefixes (e.g \"ri:\", \"ai:\") for shaders when they're connected in a network. This is critical to avoiding warnings from IECoreGL when given non-prefixed shaders it doesn't understand. The number of such warnings for some production assets was enough to slow Maya to a crawl.\r\n- Changes the attribute used to store shader assignments from \"surface\" to \"rendererPrefix:shaderType\" (e.g. \"ri:surface\"). This allows shaders for different renderers to coexist peacefully in the same data stream.\r\n\r\nIt's pretty critical that we get the former commit deployed, so if anyone feels that the latter needs further discussion I'd suggest cherry-picking the first one in the meantime.","created_at":"2014-10-10T14:58:04Z","updated_at":"2014-10-10T22:14:12Z","closed_at":"2014-10-10T22:14:12Z","merged_at":"2014-10-10T22:14:12Z","merge_commit_sha":"8fc632e42eccddeb18869ead1015091e33416bf7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1035/commits","review_comments_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1035/comments","review_comment_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1035/comments","statuses_url":"https://api.github.com/repos/ImageEngine/gaffer/statuses/768bd3198876917eeb0f23fa0d663697e2ad5392","head":{"label":"johnhaddon:shaderTypes","ref":"shaderTypes","sha":"768bd3198876917eeb0f23fa0d663697e2ad5392","user":{"login":"johnhaddon","id":1133871,"avatar_url":"https://avatars.githubusercontent.com/u/1133871?v=2","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"repo":{"id":9043150,"name":"gaffer","full_name":"johnhaddon/gaffer","owner":{"login":"johnhaddon","id":1133871,"avatar_url":"https://avatars.githubusercontent.com/u/1133871?v=2","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnhaddon/gaffer","description":"My day-to-day development","fork":true,"url":"https://api.github.com/repos/johnhaddon/gaffer","forks_url":"https://api.github.com/repos/johnhaddon/gaffer/forks","keys_url":"https://api.github.com/repos/johnhaddon/gaffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnhaddon/gaffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnhaddon/gaffer/teams","hooks_url":"https://api.github.com/repos/johnhaddon/gaffer/hooks","issue_events_url":"https://api.github.com/repos/johnhaddon/gaffer/issues/events{/number}","events_url":"https://api.github.com/repos/johnhaddon/gaffer/events","assignees_url":"https://api.github.com/repos/johnhaddon/gaffer/assignees{/user}","branches_url":"https://api.github.com/repos/johnhaddon/gaffer/branches{/branch}","tags_url":"https://api.github.com/repos/johnhaddon/gaffer/tags","blobs_url":"https://api.github.com/repos/johnhaddon/gaffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnhaddon/gaffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnhaddon/gaffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnhaddon/gaffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnhaddon/gaffer/statuses/{sha}","languages_url":"https://api.github.com/repos/johnhaddon/gaffer/languages","stargazers_url":"https://api.github.com/repos/johnhaddon/gaffer/stargazers","contributors_url":"https://api.github.com/repos/johnhaddon/gaffer/contributors","subscribers_url":"https://api.github.com/repos/johnhaddon/gaffer/subscribers","subscription_url":"https://api.github.com/repos/johnhaddon/gaffer/subscription","commits_url":"https://api.github.com/repos/johnhaddon/gaffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnhaddon/gaffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnhaddon/gaffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnhaddon/gaffer/issues/comments/{number}","contents_url":"https://api.github.com/repos/johnhaddon/gaffer/contents/{+path}","compare_url":"https://api.github.com/repos/johnhaddon/gaffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnhaddon/gaffer/merges","archive_url":"https://api.github.com/repos/johnhaddon/gaffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnhaddon/gaffer/downloads","issues_url":"https://api.github.com/repos/johnhaddon/gaffer/issues{/number}","pulls_url":"https://api.github.com/repos/johnhaddon/gaffer/pulls{/number}","milestones_url":"https://api.github.com/repos/johnhaddon/gaffer/milestones{/number}","notifications_url":"https://api.github.com/repos/johnhaddon/gaffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnhaddon/gaffer/labels{/name}","releases_url":"https://api.github.com/repos/johnhaddon/gaffer/releases{/id}","created_at":"2013-03-27T00:06:40Z","updated_at":"2014-06-26T08:41:59Z","pushed_at":"2014-10-10T14:31:11Z","git_url":"git://github.com/johnhaddon/gaffer.git","ssh_url":"git@github.com:johnhaddon/gaffer.git","clone_url":"https://github.com/johnhaddon/gaffer.git","svn_url":"https://github.com/johnhaddon/gaffer","homepage":"","size":21357,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ImageEngine:master","ref":"master","sha":"8e2daf2123b6b9a7295cd3e5c4c5e8514671d77e","user":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars.githubusercontent.com/u/3976662?v=2","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":9043124,"name":"gaffer","full_name":"ImageEngine/gaffer","owner":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars.githubusercontent.com/u/3976662?v=2","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ImageEngine/gaffer","description":"Gaffer is an open source application framework designed specifically for creating tools for use in visual effects production.","fork":false,"url":"https://api.github.com/repos/ImageEngine/gaffer","forks_url":"https://api.github.com/repos/ImageEngine/gaffer/forks","keys_url":"https://api.github.com/repos/ImageEngine/gaffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ImageEngine/gaffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ImageEngine/gaffer/teams","hooks_url":"https://api.github.com/repos/ImageEngine/gaffer/hooks","issue_events_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/events{/number}","events_url":"https://api.github.com/repos/ImageEngine/gaffer/events","assignees_url":"https://api.github.com/repos/ImageEngine/gaffer/assignees{/user}","branches_url":"https://api.github.com/repos/ImageEngine/gaffer/branches{/branch}","tags_url":"https://api.github.com/repos/ImageEngine/gaffer/tags","blobs_url":"https://api.github.com/repos/ImageEngine/gaffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ImageEngine/gaffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ImageEngine/gaffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ImageEngine/gaffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ImageEngine/gaffer/statuses/{sha}","languages_url":"https://api.github.com/repos/ImageEngine/gaffer/languages","stargazers_url":"https://api.github.com/repos/ImageEngine/gaffer/stargazers","contributors_url":"https://api.github.com/repos/ImageEngine/gaffer/contributors","subscribers_url":"https://api.github.com/repos/ImageEngine/gaffer/subscribers","subscription_url":"https://api.github.com/repos/ImageEngine/gaffer/subscription","commits_url":"https://api.github.com/repos/ImageEngine/gaffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ImageEngine/gaffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ImageEngine/gaffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/comments/{number}","contents_url":"https://api.github.com/repos/ImageEngine/gaffer/contents/{+path}","compare_url":"https://api.github.com/repos/ImageEngine/gaffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ImageEngine/gaffer/merges","archive_url":"https://api.github.com/repos/ImageEngine/gaffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ImageEngine/gaffer/downloads","issues_url":"https://api.github.com/repos/ImageEngine/gaffer/issues{/number}","pulls_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls{/number}","milestones_url":"https://api.github.com/repos/ImageEngine/gaffer/milestones{/number}","notifications_url":"https://api.github.com/repos/ImageEngine/gaffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ImageEngine/gaffer/labels{/name}","releases_url":"https://api.github.com/repos/ImageEngine/gaffer/releases{/id}","created_at":"2013-03-27T00:04:53Z","updated_at":"2014-10-08T17:36:20Z","pushed_at":"2014-10-10T22:14:12Z","git_url":"git://github.com/ImageEngine/gaffer.git","ssh_url":"git@github.com:ImageEngine/gaffer.git","clone_url":"https://github.com/ImageEngine/gaffer.git","svn_url":"https://github.com/ImageEngine/gaffer","homepage":"http://imageengine.github.io/gaffer/","size":119627,"stargazers_count":120,"watchers_count":120,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":206,"forks":44,"open_issues":206,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1035"},"html":{"href":"https://github.com/ImageEngine/gaffer/pull/1035"},"issue":{"href":"https://api.github.com/repos/ImageEngine/gaffer/issues/1035"},"comments":{"href":"https://api.github.com/repos/ImageEngine/gaffer/issues/1035/comments"},"review_comments":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1035/comments"},"review_comment":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1035/commits"},"statuses":{"href":"https://api.github.com/repos/ImageEngine/gaffer/statuses/768bd3198876917eeb0f23fa0d663697e2ad5392"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andrewkaufman","id":3979682,"avatar_url":"https://avatars.githubusercontent.com/u/3979682?v=2","gravatar_id":"","url":"https://api.github.com/users/andrewkaufman","html_url":"https://github.com/andrewkaufman","followers_url":"https://api.github.com/users/andrewkaufman/followers","following_url":"https://api.github.com/users/andrewkaufman/following{/other_user}","gists_url":"https://api.github.com/users/andrewkaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkaufman/subscriptions","organizations_url":"https://api.github.com/users/andrewkaufman/orgs","repos_url":"https://api.github.com/users/andrewkaufman/repos","events_url":"https://api.github.com/users/andrewkaufman/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkaufman/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":115,"deletions":21,"changed_files":8}}