GitHub PullRequestReviewCommentEvent at 2014-09-13 17:49:43
Repository: twitter-cldr-js
Actor: radzinzki
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/comments/17513373","id":17513373,"diff_hunk":"@@ -0,0 +1,59 @@\n+# Copyright 2012 Twitter, Inc","path":"lib/twitter_cldr/js/mustache/parsers/unicode_regex/character_class.coffee","position":1,"original_position":1,"commit_id":"29b9a8b7b86074e28d35a6a7e738de029b8e912a","original_commit_id":"fb6abe2c97d309b9209d3acc7eb47f759af8efde","user":{"login":"radzinzki","id":3008045,"avatar_url":"https://avatars.githubusercontent.com/u/3008045?v=2","gravatar_id":"5f46e852ec14b35bde17a0e7c7422120","url":"https://api.github.com/users/radzinzki","html_url":"https://github.com/radzinzki","followers_url":"https://api.github.com/users/radzinzki/followers","following_url":"https://api.github.com/users/radzinzki/following{/other_user}","gists_url":"https://api.github.com/users/radzinzki/gists{/gist_id}","starred_url":"https://api.github.com/users/radzinzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radzinzki/subscriptions","organizations_url":"https://api.github.com/users/radzinzki/orgs","repos_url":"https://api.github.com/users/radzinzki/repos","events_url":"https://api.github.com/users/radzinzki/events{/privacy}","received_events_url":"https://api.github.com/users/radzinzki/received_events","type":"User","site_admin":false},"body":"fixed :)","created_at":"2014-09-13T17:49:43Z","updated_at":"2014-09-13T17:49:43Z","html_url":"https://github.com/twitter/twitter-cldr-js/pull/47#discussion_r17513373","pull_request_url":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/comments/17513373"},"html":{"href":"https://github.com/twitter/twitter-cldr-js/pull/47#discussion_r17513373"},"pull_request":{"href":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/47","id":19992560,"html_url":"https://github.com/twitter/twitter-cldr-js/pull/47","diff_url":"https://github.com/twitter/twitter-cldr-js/pull/47.diff","patch_url":"https://github.com/twitter/twitter-cldr-js/pull/47.patch","issue_url":"https://api.github.com/repos/twitter/twitter-cldr-js/issues/47","number":47,"state":"open","locked":false,"title":"Ported Text Segmentation and Unicode Regex Parser","user":{"login":"radzinzki","id":3008045,"avatar_url":"https://avatars.githubusercontent.com/u/3008045?v=2","gravatar_id":"5f46e852ec14b35bde17a0e7c7422120","url":"https://api.github.com/users/radzinzki","html_url":"https://github.com/radzinzki","followers_url":"https://api.github.com/users/radzinzki/followers","following_url":"https://api.github.com/users/radzinzki/following{/other_user}","gists_url":"https://api.github.com/users/radzinzki/gists{/gist_id}","starred_url":"https://api.github.com/users/radzinzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radzinzki/subscriptions","organizations_url":"https://api.github.com/users/radzinzki/orgs","repos_url":"https://api.github.com/users/radzinzki/repos","events_url":"https://api.github.com/users/radzinzki/events{/privacy}","received_events_url":"https://api.github.com/users/radzinzki/received_events","type":"User","site_admin":false},"body":"Note:\r\n- Separating CodePoint data is still WIP. I'm sending in a PR before completing it so that the review process can start while I figure it out.\r\n- All the tests are based on their counterparts in twitter-cldr-rb.\r\n- Since Range is not a data type in JavaScript (yet), I made a light implementation of Range in TwitterCldr.Range. Is this the best way?\r\n\r\nSpecial Note:\r\n- Before this gets merged into the master, the data separation for CodePoint needs to be completed as injecting the CodePoint resources here makes the total bundle size ~3.4MB, which is too much. @KL-7 and I discussed this over email and agreed that Text Segmentation should be an opt-in feature that requires a spearate file (with all the CodePoint resources ~2.5MB).","created_at":"2014-08-19T16:37:46Z","updated_at":"2014-09-13T17:49:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb9b7a4b365ffa636d4fe602516e409fafdcb278","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/47/commits","review_comments_url":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/47/comments","review_comment_url":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twitter/twitter-cldr-js/issues/47/comments","statuses_url":"https://api.github.com/repos/twitter/twitter-cldr-js/statuses/29b9a8b7b86074e28d35a6a7e738de029b8e912a","head":{"label":"radzinzki:master","ref":"master","sha":"29b9a8b7b86074e28d35a6a7e738de029b8e912a","user":{"login":"radzinzki","id":3008045,"avatar_url":"https://avatars.githubusercontent.com/u/3008045?v=2","gravatar_id":"5f46e852ec14b35bde17a0e7c7422120","url":"https://api.github.com/users/radzinzki","html_url":"https://github.com/radzinzki","followers_url":"https://api.github.com/users/radzinzki/followers","following_url":"https://api.github.com/users/radzinzki/following{/other_user}","gists_url":"https://api.github.com/users/radzinzki/gists{/gist_id}","starred_url":"https://api.github.com/users/radzinzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radzinzki/subscriptions","organizations_url":"https://api.github.com/users/radzinzki/orgs","repos_url":"https://api.github.com/users/radzinzki/repos","events_url":"https://api.github.com/users/radzinzki/events{/privacy}","received_events_url":"https://api.github.com/users/radzinzki/received_events","type":"User","site_admin":false},"repo":{"id":17902068,"name":"twitter-cldr-js","full_name":"radzinzki/twitter-cldr-js","owner":{"login":"radzinzki","id":3008045,"avatar_url":"https://avatars.githubusercontent.com/u/3008045?v=2","gravatar_id":"5f46e852ec14b35bde17a0e7c7422120","url":"https://api.github.com/users/radzinzki","html_url":"https://github.com/radzinzki","followers_url":"https://api.github.com/users/radzinzki/followers","following_url":"https://api.github.com/users/radzinzki/following{/other_user}","gists_url":"https://api.github.com/users/radzinzki/gists{/gist_id}","starred_url":"https://api.github.com/users/radzinzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radzinzki/subscriptions","organizations_url":"https://api.github.com/users/radzinzki/orgs","repos_url":"https://api.github.com/users/radzinzki/repos","events_url":"https://api.github.com/users/radzinzki/events{/privacy}","received_events_url":"https://api.github.com/users/radzinzki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radzinzki/twitter-cldr-js","description":"JavaScript implementation of the ICU (International Components for Unicode) that uses the Common Locale Data Repository to format dates, plurals, and more.  Based on twitter-cldr-rb.","fork":true,"url":"https://api.github.com/repos/radzinzki/twitter-cldr-js","forks_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/forks","keys_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/teams","hooks_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/hooks","issue_events_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/issues/events{/number}","events_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/events","assignees_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/assignees{/user}","branches_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/branches{/branch}","tags_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/tags","blobs_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/statuses/{sha}","languages_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/languages","stargazers_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/stargazers","contributors_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/contributors","subscribers_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/subscribers","subscription_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/subscription","commits_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/issues/comments/{number}","contents_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/contents/{+path}","compare_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/merges","archive_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/downloads","issues_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/issues{/number}","pulls_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/pulls{/number}","milestones_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/milestones{/number}","notifications_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/labels{/name}","releases_url":"https://api.github.com/repos/radzinzki/twitter-cldr-js/releases{/id}","created_at":"2014-03-19T11:38:49Z","updated_at":"2014-08-18T17:45:49Z","pushed_at":"2014-09-13T17:32:41Z","git_url":"git://github.com/radzinzki/twitter-cldr-js.git","ssh_url":"git@github.com:radzinzki/twitter-cldr-js.git","clone_url":"https://github.com/radzinzki/twitter-cldr-js.git","svn_url":"https://github.com/radzinzki/twitter-cldr-js","homepage":"","size":9004,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"9cf80fcc71e658d95718b9fdc41da925d1f1d6ba","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":5181699,"name":"twitter-cldr-js","full_name":"twitter/twitter-cldr-js","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=2","gravatar_id":"2f4a8254d032a8ec5e4c48d461e54fcc","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/twitter-cldr-js","description":"JavaScript implementation of the ICU (International Components for Unicode) that uses the Common Locale Data Repository to format dates, plurals, and more.  Based on twitter-cldr-rb.","fork":false,"url":"https://api.github.com/repos/twitter/twitter-cldr-js","forks_url":"https://api.github.com/repos/twitter/twitter-cldr-js/forks","keys_url":"https://api.github.com/repos/twitter/twitter-cldr-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/twitter-cldr-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/twitter-cldr-js/teams","hooks_url":"https://api.github.com/repos/twitter/twitter-cldr-js/hooks","issue_events_url":"https://api.github.com/repos/twitter/twitter-cldr-js/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/twitter-cldr-js/events","assignees_url":"https://api.github.com/repos/twitter/twitter-cldr-js/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/twitter-cldr-js/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/twitter-cldr-js/tags","blobs_url":"https://api.github.com/repos/twitter/twitter-cldr-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/twitter-cldr-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/twitter-cldr-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/twitter-cldr-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/twitter-cldr-js/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/twitter-cldr-js/languages","stargazers_url":"https://api.github.com/repos/twitter/twitter-cldr-js/stargazers","contributors_url":"https://api.github.com/repos/twitter/twitter-cldr-js/contributors","subscribers_url":"https://api.github.com/repos/twitter/twitter-cldr-js/subscribers","subscription_url":"https://api.github.com/repos/twitter/twitter-cldr-js/subscription","commits_url":"https://api.github.com/repos/twitter/twitter-cldr-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/twitter-cldr-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/twitter-cldr-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/twitter-cldr-js/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/twitter-cldr-js/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/twitter-cldr-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/twitter-cldr-js/merges","archive_url":"https://api.github.com/repos/twitter/twitter-cldr-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/twitter-cldr-js/downloads","issues_url":"https://api.github.com/repos/twitter/twitter-cldr-js/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/twitter-cldr-js/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/twitter-cldr-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/twitter-cldr-js/labels{/name}","releases_url":"https://api.github.com/repos/twitter/twitter-cldr-js/releases{/id}","created_at":"2012-07-25T16:38:15Z","updated_at":"2014-09-13T02:03:07Z","pushed_at":"2014-09-11T16:58:46Z","git_url":"git://github.com/twitter/twitter-cldr-js.git","ssh_url":"git@github.com:twitter/twitter-cldr-js.git","clone_url":"https://github.com/twitter/twitter-cldr-js.git","svn_url":"https://github.com/twitter/twitter-cldr-js","homepage":"","size":8062,"stargazers_count":161,"watchers_count":161,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":26,"mirror_url":null,"open_issues_count":11,"forks":26,"open_issues":11,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/47"},"html":{"href":"https://github.com/twitter/twitter-cldr-js/pull/47"},"issue":{"href":"https://api.github.com/repos/twitter/twitter-cldr-js/issues/47"},"comments":{"href":"https://api.github.com/repos/twitter/twitter-cldr-js/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/twitter-cldr-js/statuses/29b9a8b7b86074e28d35a6a7e738de029b8e912a"}}}}