GitHub PullRequestReviewCommentEvent at 2014-08-31 20:33:36
Repository: vispy
Actor: Eric89GXL
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/vispy/vispy/pulls/comments/16936850","id":16936850,"diff_hunk":"@@ -11,3 +11,4 @@\n \n from ._color_dict import get_color_names  # noqa\n from ._color import Color, ColorArray, LinearGradient  # noqa\n+from ._color import get_colormap, colormaps  # noqa","path":"vispy/color/__init__.py","position":4,"original_position":4,"commit_id":"01b9c21709808e45def96f338938d59f923baa40","original_commit_id":"ddc55a9babb4a51c2c7f177dcd53a8bf922a6d55","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=2","gravatar_id":"bfd1a4884c9621f28ee42e38f652db99","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"if it's too long, we have a convention of putting the imports in parentheses and wrapping like\r\n```\r\nfrom ._color import (Color, ColorArray, LinearGradient,  # noqa\r\n                     get_colormap, colormaps)  # noqa\r\n```","created_at":"2014-08-31T20:33:36Z","updated_at":"2014-08-31T20:33:36Z","html_url":"https://github.com/vispy/vispy/pull/500#discussion_r16936850","pull_request_url":"https://api.github.com/repos/vispy/vispy/pulls/500","_links":{"self":{"href":"https://api.github.com/repos/vispy/vispy/pulls/comments/16936850"},"html":{"href":"https://github.com/vispy/vispy/pull/500#discussion_r16936850"},"pull_request":{"href":"https://api.github.com/repos/vispy/vispy/pulls/500"}}},"pull_request":{"url":"https://api.github.com/repos/vispy/vispy/pulls/500","id":20544399,"html_url":"https://github.com/vispy/vispy/pull/500","diff_url":"https://github.com/vispy/vispy/pull/500.diff","patch_url":"https://github.com/vispy/vispy/pull/500.patch","issue_url":"https://api.github.com/repos/vispy/vispy/issues/500","number":500,"state":"open","locked":false,"title":"Colormaps","user":{"login":"izaid","id":482179,"avatar_url":"https://avatars.githubusercontent.com/u/482179?v=2","gravatar_id":"209f54f0b8edd93e50c7bf9870037ac5","url":"https://api.github.com/users/izaid","html_url":"https://github.com/izaid","followers_url":"https://api.github.com/users/izaid/followers","following_url":"https://api.github.com/users/izaid/following{/other_user}","gists_url":"https://api.github.com/users/izaid/gists{/gist_id}","starred_url":"https://api.github.com/users/izaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izaid/subscriptions","organizations_url":"https://api.github.com/users/izaid/orgs","repos_url":"https://api.github.com/users/izaid/repos","events_url":"https://api.github.com/users/izaid/events{/privacy}","received_events_url":"https://api.github.com/users/izaid/received_events","type":"User","site_admin":false},"body":"This implements colormaps as per https://github.com/vispy/vispy/issues/414 . It is a first pass that uses OpenGL functions. Visuals will need to integrate this, but it has already been done for the Line visual. It includes a new example 'colored_line.py' that cycles through all the colormaps.","created_at":"2014-08-31T11:19:32Z","updated_at":"2014-08-31T20:33:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab62ef5f316f0737f67a5f5a3a44bba5be1ce73f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vispy/vispy/pulls/500/commits","review_comments_url":"https://api.github.com/repos/vispy/vispy/pulls/500/comments","review_comment_url":"https://api.github.com/repos/vispy/vispy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/vispy/vispy/issues/500/comments","statuses_url":"https://api.github.com/repos/vispy/vispy/statuses/01b9c21709808e45def96f338938d59f923baa40","head":{"label":"izaid:colormaps","ref":"colormaps","sha":"01b9c21709808e45def96f338938d59f923baa40","user":{"login":"izaid","id":482179,"avatar_url":"https://avatars.githubusercontent.com/u/482179?v=2","gravatar_id":"209f54f0b8edd93e50c7bf9870037ac5","url":"https://api.github.com/users/izaid","html_url":"https://github.com/izaid","followers_url":"https://api.github.com/users/izaid/followers","following_url":"https://api.github.com/users/izaid/following{/other_user}","gists_url":"https://api.github.com/users/izaid/gists{/gist_id}","starred_url":"https://api.github.com/users/izaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izaid/subscriptions","organizations_url":"https://api.github.com/users/izaid/orgs","repos_url":"https://api.github.com/users/izaid/repos","events_url":"https://api.github.com/users/izaid/events{/privacy}","received_events_url":"https://api.github.com/users/izaid/received_events","type":"User","site_admin":false},"repo":{"id":22811902,"name":"vispy","full_name":"izaid/vispy","owner":{"login":"izaid","id":482179,"avatar_url":"https://avatars.githubusercontent.com/u/482179?v=2","gravatar_id":"209f54f0b8edd93e50c7bf9870037ac5","url":"https://api.github.com/users/izaid","html_url":"https://github.com/izaid","followers_url":"https://api.github.com/users/izaid/followers","following_url":"https://api.github.com/users/izaid/following{/other_user}","gists_url":"https://api.github.com/users/izaid/gists{/gist_id}","starred_url":"https://api.github.com/users/izaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izaid/subscriptions","organizations_url":"https://api.github.com/users/izaid/orgs","repos_url":"https://api.github.com/users/izaid/repos","events_url":"https://api.github.com/users/izaid/events{/privacy}","received_events_url":"https://api.github.com/users/izaid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/izaid/vispy","description":"Main repository for Vispy","fork":true,"url":"https://api.github.com/repos/izaid/vispy","forks_url":"https://api.github.com/repos/izaid/vispy/forks","keys_url":"https://api.github.com/repos/izaid/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/izaid/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/izaid/vispy/teams","hooks_url":"https://api.github.com/repos/izaid/vispy/hooks","issue_events_url":"https://api.github.com/repos/izaid/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/izaid/vispy/events","assignees_url":"https://api.github.com/repos/izaid/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/izaid/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/izaid/vispy/tags","blobs_url":"https://api.github.com/repos/izaid/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/izaid/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/izaid/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/izaid/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/izaid/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/izaid/vispy/languages","stargazers_url":"https://api.github.com/repos/izaid/vispy/stargazers","contributors_url":"https://api.github.com/repos/izaid/vispy/contributors","subscribers_url":"https://api.github.com/repos/izaid/vispy/subscribers","subscription_url":"https://api.github.com/repos/izaid/vispy/subscription","commits_url":"https://api.github.com/repos/izaid/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/izaid/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/izaid/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/izaid/vispy/issues/comments/{number}","contents_url":"https://api.github.com/repos/izaid/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/izaid/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/izaid/vispy/merges","archive_url":"https://api.github.com/repos/izaid/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/izaid/vispy/downloads","issues_url":"https://api.github.com/repos/izaid/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/izaid/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/izaid/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/izaid/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/izaid/vispy/labels{/name}","releases_url":"https://api.github.com/repos/izaid/vispy/releases{/id}","created_at":"2014-08-10T15:27:29Z","updated_at":"2014-08-23T22:34:00Z","pushed_at":"2014-08-31T13:42:10Z","git_url":"git://github.com/izaid/vispy.git","ssh_url":"git@github.com:izaid/vispy.git","clone_url":"https://github.com/izaid/vispy.git","svn_url":"https://github.com/izaid/vispy","homepage":"","size":5851,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vispy:master","ref":"master","sha":"5b4c614d954df17167bc8ec2705a01caa79cb28d","user":{"login":"vispy","id":3934254,"avatar_url":"https://avatars.githubusercontent.com/u/3934254?v=2","gravatar_id":"47bf7b9218948408c9b197107b484b1f","url":"https://api.github.com/users/vispy","html_url":"https://github.com/vispy","followers_url":"https://api.github.com/users/vispy/followers","following_url":"https://api.github.com/users/vispy/following{/other_user}","gists_url":"https://api.github.com/users/vispy/gists{/gist_id}","starred_url":"https://api.github.com/users/vispy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vispy/subscriptions","organizations_url":"https://api.github.com/users/vispy/orgs","repos_url":"https://api.github.com/users/vispy/repos","events_url":"https://api.github.com/users/vispy/events{/privacy}","received_events_url":"https://api.github.com/users/vispy/received_events","type":"Organization","site_admin":false},"repo":{"id":8935948,"name":"vispy","full_name":"vispy/vispy","owner":{"login":"vispy","id":3934254,"avatar_url":"https://avatars.githubusercontent.com/u/3934254?v=2","gravatar_id":"47bf7b9218948408c9b197107b484b1f","url":"https://api.github.com/users/vispy","html_url":"https://github.com/vispy","followers_url":"https://api.github.com/users/vispy/followers","following_url":"https://api.github.com/users/vispy/following{/other_user}","gists_url":"https://api.github.com/users/vispy/gists{/gist_id}","starred_url":"https://api.github.com/users/vispy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vispy/subscriptions","organizations_url":"https://api.github.com/users/vispy/orgs","repos_url":"https://api.github.com/users/vispy/repos","events_url":"https://api.github.com/users/vispy/events{/privacy}","received_events_url":"https://api.github.com/users/vispy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vispy/vispy","description":"Main repository for Vispy","fork":false,"url":"https://api.github.com/repos/vispy/vispy","forks_url":"https://api.github.com/repos/vispy/vispy/forks","keys_url":"https://api.github.com/repos/vispy/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vispy/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vispy/vispy/teams","hooks_url":"https://api.github.com/repos/vispy/vispy/hooks","issue_events_url":"https://api.github.com/repos/vispy/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/vispy/vispy/events","assignees_url":"https://api.github.com/repos/vispy/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/vispy/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/vispy/vispy/tags","blobs_url":"https://api.github.com/repos/vispy/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vispy/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vispy/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/vispy/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vispy/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/vispy/vispy/languages","stargazers_url":"https://api.github.com/repos/vispy/vispy/stargazers","contributors_url":"https://api.github.com/repos/vispy/vispy/contributors","subscribers_url":"https://api.github.com/repos/vispy/vispy/subscribers","subscription_url":"https://api.github.com/repos/vispy/vispy/subscription","commits_url":"https://api.github.com/repos/vispy/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/vispy/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/vispy/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/vispy/vispy/issues/comments/{number}","contents_url":"https://api.github.com/repos/vispy/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/vispy/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vispy/vispy/merges","archive_url":"https://api.github.com/repos/vispy/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vispy/vispy/downloads","issues_url":"https://api.github.com/repos/vispy/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/vispy/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/vispy/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/vispy/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vispy/vispy/labels{/name}","releases_url":"https://api.github.com/repos/vispy/vispy/releases{/id}","created_at":"2013-03-21T18:43:22Z","updated_at":"2014-08-31T19:01:09Z","pushed_at":"2014-08-31T15:24:31Z","git_url":"git://github.com/vispy/vispy.git","ssh_url":"git@github.com:vispy/vispy.git","clone_url":"https://github.com/vispy/vispy.git","svn_url":"https://github.com/vispy/vispy","homepage":"http://vispy.org","size":21497,"stargazers_count":215,"watchers_count":215,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":37,"mirror_url":null,"open_issues_count":98,"forks":37,"open_issues":98,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vispy/vispy/pulls/500"},"html":{"href":"https://github.com/vispy/vispy/pull/500"},"issue":{"href":"https://api.github.com/repos/vispy/vispy/issues/500"},"comments":{"href":"https://api.github.com/repos/vispy/vispy/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/vispy/vispy/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/vispy/vispy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/vispy/vispy/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/vispy/vispy/statuses/01b9c21709808e45def96f338938d59f923baa40"}}}}