GitHub PullRequestEvent at 2014-01-31 18:16:17
Repository: mongoose
Actor: xant
Payload: {"action":"opened","number":313,"pull_request":{"url":"https://api.github.com/repos/cesanta/mongoose/pulls/313","id":12088707,"html_url":"https://github.com/cesanta/mongoose/pull/313","diff_url":"https://github.com/cesanta/mongoose/pull/313.diff","patch_url":"https://github.com/cesanta/mongoose/pull/313.patch","issue_url":"https://api.github.com/repos/cesanta/mongoose/issues/313","number":313,"state":"open","title":"bugfix: set the correct status if we still have pending data","user":{"login":"xant","id":150933,"avatar_url":"https://identicons.github.com/f0a7ef3ad3337279dcd1edb7b80cbaed.png","gravatar_id":null,"url":"https://api.github.com/users/xant","html_url":"https://github.com/xant","followers_url":"https://api.github.com/users/xant/followers","following_url":"https://api.github.com/users/xant/following{/other_user}","gists_url":"https://api.github.com/users/xant/gists{/gist_id}","starred_url":"https://api.github.com/users/xant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xant/subscriptions","organizations_url":"https://api.github.com/users/xant/orgs","repos_url":"https://api.github.com/users/xant/repos","events_url":"https://api.github.com/users/xant/events{/privacy}","received_events_url":"https://api.github.com/users/xant/received_events","type":"User","site_admin":false},"body":"A request handler can return MG_REQUEST_PROCESSED after writing some data \r\nwhich might be still pending so 'close' should be postponed until the buffer has been emptied\r\n(later in write_to_socket()).\r\n\r\nThis happens especially with long running connections (CONN_LONG_RUNNING) which \r\ncan queue multiple chunks of data (using either mg_write() or mg_send_data()) when providing a big response.\r\nReturning MG_REQUEST_PROCESSED once done shouldn't immediately close the connection\r\nif there is still data queued in the internal io buffer.\r\n","created_at":"2014-01-31T18:16:17Z","updated_at":"2014-01-31T18:16:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cesanta/mongoose/pulls/313/commits","review_comments_url":"https://api.github.com/repos/cesanta/mongoose/pulls/313/comments","review_comment_url":"https://api.github.com/repos/cesanta/mongoose/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cesanta/mongoose/issues/313/comments","statuses_url":"https://api.github.com/repos/cesanta/mongoose/statuses/9e118c8a31d0192ae794812fd344b49e5c0c86ff","head":{"label":"xant:upstream","ref":"upstream","sha":"9e118c8a31d0192ae794812fd344b49e5c0c86ff","user":{"login":"xant","id":150933,"avatar_url":"https://identicons.github.com/f0a7ef3ad3337279dcd1edb7b80cbaed.png","gravatar_id":null,"url":"https://api.github.com/users/xant","html_url":"https://github.com/xant","followers_url":"https://api.github.com/users/xant/followers","following_url":"https://api.github.com/users/xant/following{/other_user}","gists_url":"https://api.github.com/users/xant/gists{/gist_id}","starred_url":"https://api.github.com/users/xant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xant/subscriptions","organizations_url":"https://api.github.com/users/xant/orgs","repos_url":"https://api.github.com/users/xant/repos","events_url":"https://api.github.com/users/xant/events{/privacy}","received_events_url":"https://api.github.com/users/xant/received_events","type":"User","site_admin":false},"repo":{"id":16205078,"name":"mongoose","full_name":"xant/mongoose","owner":{"login":"xant","id":150933,"avatar_url":"https://identicons.github.com/f0a7ef3ad3337279dcd1edb7b80cbaed.png","gravatar_id":null,"url":"https://api.github.com/users/xant","html_url":"https://github.com/xant","followers_url":"https://api.github.com/users/xant/followers","following_url":"https://api.github.com/users/xant/following{/other_user}","gists_url":"https://api.github.com/users/xant/gists{/gist_id}","starred_url":"https://api.github.com/users/xant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xant/subscriptions","organizations_url":"https://api.github.com/users/xant/orgs","repos_url":"https://api.github.com/users/xant/repos","events_url":"https://api.github.com/users/xant/events{/privacy}","received_events_url":"https://api.github.com/users/xant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xant/mongoose","description":"Mongoose web server","fork":true,"url":"https://api.github.com/repos/xant/mongoose","forks_url":"https://api.github.com/repos/xant/mongoose/forks","keys_url":"https://api.github.com/repos/xant/mongoose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xant/mongoose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xant/mongoose/teams","hooks_url":"https://api.github.com/repos/xant/mongoose/hooks","issue_events_url":"https://api.github.com/repos/xant/mongoose/issues/events{/number}","events_url":"https://api.github.com/repos/xant/mongoose/events","assignees_url":"https://api.github.com/repos/xant/mongoose/assignees{/user}","branches_url":"https://api.github.com/repos/xant/mongoose/branches{/branch}","tags_url":"https://api.github.com/repos/xant/mongoose/tags","blobs_url":"https://api.github.com/repos/xant/mongoose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xant/mongoose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xant/mongoose/git/refs{/sha}","trees_url":"https://api.github.com/repos/xant/mongoose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xant/mongoose/statuses/{sha}","languages_url":"https://api.github.com/repos/xant/mongoose/languages","stargazers_url":"https://api.github.com/repos/xant/mongoose/stargazers","contributors_url":"https://api.github.com/repos/xant/mongoose/contributors","subscribers_url":"https://api.github.com/repos/xant/mongoose/subscribers","subscription_url":"https://api.github.com/repos/xant/mongoose/subscription","commits_url":"https://api.github.com/repos/xant/mongoose/commits{/sha}","git_commits_url":"https://api.github.com/repos/xant/mongoose/git/commits{/sha}","comments_url":"https://api.github.com/repos/xant/mongoose/comments{/number}","issue_comment_url":"https://api.github.com/repos/xant/mongoose/issues/comments/{number}","contents_url":"https://api.github.com/repos/xant/mongoose/contents/{+path}","compare_url":"https://api.github.com/repos/xant/mongoose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xant/mongoose/merges","archive_url":"https://api.github.com/repos/xant/mongoose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xant/mongoose/downloads","issues_url":"https://api.github.com/repos/xant/mongoose/issues{/number}","pulls_url":"https://api.github.com/repos/xant/mongoose/pulls{/number}","milestones_url":"https://api.github.com/repos/xant/mongoose/milestones{/number}","notifications_url":"https://api.github.com/repos/xant/mongoose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xant/mongoose/labels{/name}","releases_url":"https://api.github.com/repos/xant/mongoose/releases{/id}","created_at":"2014-01-24T13:23:21Z","updated_at":"2014-01-31T18:16:17Z","pushed_at":"2014-01-31T18:09:24Z","git_url":"git://github.com/xant/mongoose.git","ssh_url":"git@github.com:xant/mongoose.git","clone_url":"https://github.com/xant/mongoose.git","svn_url":"https://github.com/xant/mongoose","homepage":null,"size":7228,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"cesanta:master","ref":"master","sha":"2fc654ac359e50c96665a70c53944f8ce395c430","user":{"login":"cesanta","id":5111322,"avatar_url":"https://gravatar.com/avatar/86c61c0800dbfb68e072cbdd709d3682?d=https%3A%2F%2Fidenticons.github.com%2Fab3c79c16f9f6504c30b9e29c63964d2.png&r=x","gravatar_id":"86c61c0800dbfb68e072cbdd709d3682","url":"https://api.github.com/users/cesanta","html_url":"https://github.com/cesanta","followers_url":"https://api.github.com/users/cesanta/followers","following_url":"https://api.github.com/users/cesanta/following{/other_user}","gists_url":"https://api.github.com/users/cesanta/gists{/gist_id}","starred_url":"https://api.github.com/users/cesanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesanta/subscriptions","organizations_url":"https://api.github.com/users/cesanta/orgs","repos_url":"https://api.github.com/users/cesanta/repos","events_url":"https://api.github.com/users/cesanta/events{/privacy}","received_events_url":"https://api.github.com/users/cesanta/received_events","type":"Organization","site_admin":false},"repo":{"id":5414488,"name":"mongoose","full_name":"cesanta/mongoose","owner":{"login":"cesanta","id":5111322,"avatar_url":"https://gravatar.com/avatar/86c61c0800dbfb68e072cbdd709d3682?d=https%3A%2F%2Fidenticons.github.com%2Fab3c79c16f9f6504c30b9e29c63964d2.png&r=x","gravatar_id":"86c61c0800dbfb68e072cbdd709d3682","url":"https://api.github.com/users/cesanta","html_url":"https://github.com/cesanta","followers_url":"https://api.github.com/users/cesanta/followers","following_url":"https://api.github.com/users/cesanta/following{/other_user}","gists_url":"https://api.github.com/users/cesanta/gists{/gist_id}","starred_url":"https://api.github.com/users/cesanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesanta/subscriptions","organizations_url":"https://api.github.com/users/cesanta/orgs","repos_url":"https://api.github.com/users/cesanta/repos","events_url":"https://api.github.com/users/cesanta/events{/privacy}","received_events_url":"https://api.github.com/users/cesanta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cesanta/mongoose","description":"Mongoose web server","fork":false,"url":"https://api.github.com/repos/cesanta/mongoose","forks_url":"https://api.github.com/repos/cesanta/mongoose/forks","keys_url":"https://api.github.com/repos/cesanta/mongoose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cesanta/mongoose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cesanta/mongoose/teams","hooks_url":"https://api.github.com/repos/cesanta/mongoose/hooks","issue_events_url":"https://api.github.com/repos/cesanta/mongoose/issues/events{/number}","events_url":"https://api.github.com/repos/cesanta/mongoose/events","assignees_url":"https://api.github.com/repos/cesanta/mongoose/assignees{/user}","branches_url":"https://api.github.com/repos/cesanta/mongoose/branches{/branch}","tags_url":"https://api.github.com/repos/cesanta/mongoose/tags","blobs_url":"https://api.github.com/repos/cesanta/mongoose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cesanta/mongoose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cesanta/mongoose/git/refs{/sha}","trees_url":"https://api.github.com/repos/cesanta/mongoose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cesanta/mongoose/statuses/{sha}","languages_url":"https://api.github.com/repos/cesanta/mongoose/languages","stargazers_url":"https://api.github.com/repos/cesanta/mongoose/stargazers","contributors_url":"https://api.github.com/repos/cesanta/mongoose/contributors","subscribers_url":"https://api.github.com/repos/cesanta/mongoose/subscribers","subscription_url":"https://api.github.com/repos/cesanta/mongoose/subscription","commits_url":"https://api.github.com/repos/cesanta/mongoose/commits{/sha}","git_commits_url":"https://api.github.com/repos/cesanta/mongoose/git/commits{/sha}","comments_url":"https://api.github.com/repos/cesanta/mongoose/comments{/number}","issue_comment_url":"https://api.github.com/repos/cesanta/mongoose/issues/comments/{number}","contents_url":"https://api.github.com/repos/cesanta/mongoose/contents/{+path}","compare_url":"https://api.github.com/repos/cesanta/mongoose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cesanta/mongoose/merges","archive_url":"https://api.github.com/repos/cesanta/mongoose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cesanta/mongoose/downloads","issues_url":"https://api.github.com/repos/cesanta/mongoose/issues{/number}","pulls_url":"https://api.github.com/repos/cesanta/mongoose/pulls{/number}","milestones_url":"https://api.github.com/repos/cesanta/mongoose/milestones{/number}","notifications_url":"https://api.github.com/repos/cesanta/mongoose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cesanta/mongoose/labels{/name}","releases_url":"https://api.github.com/repos/cesanta/mongoose/releases{/id}","created_at":"2012-08-14T15:09:51Z","updated_at":"2014-01-30T17:49:44Z","pushed_at":"2014-01-30T17:49:44Z","git_url":"git://github.com/cesanta/mongoose.git","ssh_url":"git@github.com:cesanta/mongoose.git","clone_url":"https://github.com/cesanta/mongoose.git","svn_url":"https://github.com/cesanta/mongoose","homepage":null,"size":11937,"stargazers_count":1025,"watchers_count":1025,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":320,"mirror_url":null,"open_issues_count":8,"forks":320,"open_issues":8,"watchers":1025,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cesanta/mongoose/pulls/313"},"html":{"href":"https://github.com/cesanta/mongoose/pull/313"},"issue":{"href":"https://api.github.com/repos/cesanta/mongoose/issues/313"},"comments":{"href":"https://api.github.com/repos/cesanta/mongoose/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/cesanta/mongoose/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/cesanta/mongoose/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cesanta/mongoose/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/cesanta/mongoose/statuses/9e118c8a31d0192ae794812fd344b49e5c0c86ff"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}