GitHub PullRequestReviewCommentEvent at 2014-07-10 15:55:35
Repository: bitcoin
Actor: luke-jr
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/14774724","id":14774724,"diff_hunk":"@@ -0,0 +1,51 @@\n+AccessModifierOffset: -4\n+AlignEscapedNewlinesLeft: true\n+AlignTrailingComments: true\n+AllowAllParametersOfDeclarationOnNextLine: false\n+AllowShortBlocksOnASingleLine: false\n+AllowShortFunctionsOnASingleLine: All\n+AllowShortIfStatementsOnASingleLine: false\n+AllowShortLoopsOnASingleLine: false\n+AlwaysBreakBeforeMultilineStrings: false\n+AlwaysBreakTemplateDeclarations: true\n+BinPackParameters: false\n+BreakBeforeBinaryOperators: false\n+BreakBeforeBraces: Linux\n+BreakBeforeTernaryOperators: false\n+BreakConstructorInitializersBeforeComma: false\n+ColumnLimit:     0\n+CommentPragmas:  '^ IWYU pragma:'\n+ConstructorInitializerAllOnOneLineOrOnePerLine: false\n+ConstructorInitializerIndentWidth: 4\n+ContinuationIndentWidth: 4\n+Cpp11BracedListStyle: true\n+DerivePointerAlignment: false\n+DisableFormat:   false\n+ForEachMacros:   [ foreach, Q_FOREACH, BOOST_FOREACH ]\n+IndentCaseLabels: false\n+IndentFunctionDeclarationAfterType: false\n+IndentWidth:     4\n+KeepEmptyLinesAtTheStartOfBlocks: false\n+Language:        Cpp\n+MaxEmptyLinesToKeep: 2\n+NamespaceIndentation: None\n+ObjCSpaceAfterProperty: false\n+ObjCSpaceBeforeProtocolList: false\n+PenaltyBreakBeforeFirstCallParameter: 1\n+PenaltyBreakComment: 300\n+PenaltyBreakFirstLessLess: 120\n+PenaltyBreakString: 1000\n+PenaltyExcessCharacter: 1000000\n+PenaltyReturnTypeOnItsOwnLine: 200\n+PointerAlignment: Left","path":"src/.clang-format","position":40,"original_position":40,"commit_id":"24f4aa15b4dc5973276a766fed8c9d750ec3c26f","original_commit_id":"24f4aa15b4dc5973276a766fed8c9d750ec3c26f","user":{"login":"luke-jr","id":1095675,"avatar_url":"https://avatars.githubusercontent.com/u/1095675?","gravatar_id":"30aa55ee8573680ee4bbb556dae3160c","url":"https://api.github.com/users/luke-jr","html_url":"https://github.com/luke-jr","followers_url":"https://api.github.com/users/luke-jr/followers","following_url":"https://api.github.com/users/luke-jr/following{/other_user}","gists_url":"https://api.github.com/users/luke-jr/gists{/gist_id}","starred_url":"https://api.github.com/users/luke-jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luke-jr/subscriptions","organizations_url":"https://api.github.com/users/luke-jr/orgs","repos_url":"https://api.github.com/users/luke-jr/repos","events_url":"https://api.github.com/users/luke-jr/events{/privacy}","received_events_url":"https://api.github.com/users/luke-jr/received_events","type":"User","site_admin":false},"body":"As much as I wish PointerAlignment Left made sense, C/C++ sadly are designed with it Right.","created_at":"2014-07-10T15:55:35Z","updated_at":"2014-07-10T15:55:35Z","html_url":"https://github.com/bitcoin/bitcoin/pull/4498#discussion_r14774724","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4498","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/14774724"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/4498#discussion_r14774724"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4498"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4498","id":18170729,"html_url":"https://github.com/bitcoin/bitcoin/pull/4498","diff_url":"https://github.com/bitcoin/bitcoin/pull/4498.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/4498.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/4498","number":4498,"state":"open","title":"Preview: clang-format result","user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?","gravatar_id":"369687cc5d256fe269c9fac0216be2a7","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"body":"This pull request just to show what the effect of running a recent clang-format-3.5 (from clang's PPA; the version in the Trusty repository misses some features still) would be on our source code.\r\n\r\nFor now, I've set the column limit to 0, which means it should respect existing line breaking decisions, but as you can see the result is still fairly arbitrary (it breaks and unbreaks in several place).\r\n\r\nI would prefer using the normal mode where an actual column limit is specified (it breaks quite intelligently, with different penalty scores for breaking in several places), but that deals very badly with the IMPLEMENT_SERIALIZE macros.\r\n\r\nThis is not intended for merging. If we decide to adopt this policy and its effects, I'd rerun it just before release candidates, and then hopefully afterwards more frequently, but now it would obviously break every pull request in existence, with 0 benefit.","created_at":"2014-07-09T16:25:47Z","updated_at":"2014-07-10T15:55:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"148eafe06bc1867a3f95ab2ae111c9be0dbeee4a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4498/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4498/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/4498/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/24f4aa15b4dc5973276a766fed8c9d750ec3c26f","head":{"label":"sipa:clangformat","ref":"clangformat","sha":"24f4aa15b4dc5973276a766fed8c9d750ec3c26f","user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?","gravatar_id":"369687cc5d256fe269c9fac0216be2a7","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"repo":{"id":1458655,"name":"bitcoin","full_name":"sipa/bitcoin","owner":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?","gravatar_id":"369687cc5d256fe269c9fac0216be2a7","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sipa/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/sipa/bitcoin","forks_url":"https://api.github.com/repos/sipa/bitcoin/forks","keys_url":"https://api.github.com/repos/sipa/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sipa/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sipa/bitcoin/teams","hooks_url":"https://api.github.com/repos/sipa/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/sipa/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/sipa/bitcoin/events","assignees_url":"https://api.github.com/repos/sipa/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/sipa/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/sipa/bitcoin/tags","blobs_url":"https://api.github.com/repos/sipa/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sipa/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sipa/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/sipa/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sipa/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/sipa/bitcoin/languages","stargazers_url":"https://api.github.com/repos/sipa/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/sipa/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/sipa/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/sipa/bitcoin/subscription","commits_url":"https://api.github.com/repos/sipa/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/sipa/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/sipa/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/sipa/bitcoin/issues/comments/{number}","contents_url":"https://api.github.com/repos/sipa/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/sipa/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sipa/bitcoin/merges","archive_url":"https://api.github.com/repos/sipa/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sipa/bitcoin/downloads","issues_url":"https://api.github.com/repos/sipa/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/sipa/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/sipa/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/sipa/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sipa/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/sipa/bitcoin/releases{/id}","created_at":"2011-03-09T10:46:59Z","updated_at":"2014-06-25T01:28:50Z","pushed_at":"2014-07-10T15:39:45Z","git_url":"git://github.com/sipa/bitcoin.git","ssh_url":"git@github.com:sipa/bitcoin.git","clone_url":"https://github.com/sipa/bitcoin.git","svn_url":"https://github.com/sipa/bitcoin","homepage":"http://www.bitcoin.org","size":34836,"stargazers_count":25,"watchers_count":25,"language":"TypeScript","has_issues":false,"has_downloads":false,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":25,"default_branch":"lows"}},"base":{"label":"bitcoin:master","ref":"master","sha":"f3330b40a599615f15f585166ef08f00d06e9616","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?","gravatar_id":"26e4cc7164bdfe71d0daf3764fbc4b33","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?","gravatar_id":"26e4cc7164bdfe71d0daf3764fbc4b33","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2014-07-10T08:03:06Z","pushed_at":"2014-07-10T06:05:01Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":89614,"stargazers_count":5575,"watchers_count":5575,"language":"TypeScript","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":3989,"mirror_url":null,"open_issues_count":382,"forks":3989,"open_issues":382,"watchers":5575,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4498"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/4498"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/4498"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/4498/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4498/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/4498/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/24f4aa15b4dc5973276a766fed8c9d750ec3c26f"}}}}