GitHub PullRequestReviewCommentEvent at 2014-07-04 02:37:57
Repository: vraptor4
Actor: lucascs
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/14545692","id":14545692,"diff_hunk":"@@ -75,6 +76,13 @@ public VRaptorInstantiator(Converters converters, DependencyProvider provider,\n \n \t@PostConstruct\n \tpublic void createInstantiator() {\n+\t\t\n+\t\tInstantiator<Object> objectInstantiator = new ObjectInstantiator(this, provider, parameterNameProvider);\n+\t\t\n+\t\tif (!instantiateNullParameters()) {\n+\t\t\tobjectInstantiator = new NullDecorator(objectInstantiator);","path":"vraptor-core/src/main/java/br/com/caelum/vraptor/http/iogi/VRaptorInstantiator.java","position":25,"original_position":25,"commit_id":"879233434ad425ca4802edce9cf660ff3d42e24d","original_commit_id":"879233434ad425ca4802edce9cf660ff3d42e24d","user":{"login":"lucascs","id":46113,"avatar_url":"https://avatars.githubusercontent.com/u/46113?","gravatar_id":"a5931e7c09def8699cb1d870a2737ab5","url":"https://api.github.com/users/lucascs","html_url":"https://github.com/lucascs","followers_url":"https://api.github.com/users/lucascs/followers","following_url":"https://api.github.com/users/lucascs/following{/other_user}","gists_url":"https://api.github.com/users/lucascs/gists{/gist_id}","starred_url":"https://api.github.com/users/lucascs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucascs/subscriptions","organizations_url":"https://api.github.com/users/lucascs/orgs","repos_url":"https://api.github.com/users/lucascs/repos","events_url":"https://api.github.com/users/lucascs/events{/privacy}","received_events_url":"https://api.github.com/users/lucascs/received_events","type":"User","site_admin":false},"body":"NullDecorator keeps nulls? If so, you shouldn't have the `!` on the if. ","created_at":"2014-07-04T02:37:57Z","updated_at":"2014-07-04T02:37:57Z","html_url":"https://github.com/caelum/vraptor4/pull/660#discussion_r14545692","pull_request_url":"https://api.github.com/repos/caelum/vraptor4/pulls/660","_links":{"self":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/14545692"},"html":{"href":"https://github.com/caelum/vraptor4/pull/660#discussion_r14545692"},"pull_request":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/660"}}},"pull_request":{"url":"https://api.github.com/repos/caelum/vraptor4/pulls/660","id":17952580,"html_url":"https://github.com/caelum/vraptor4/pull/660","diff_url":"https://github.com/caelum/vraptor4/pull/660.diff","patch_url":"https://github.com/caelum/vraptor4/pull/660.patch","issue_url":"https://api.github.com/repos/caelum/vraptor4/issues/660","number":660,"state":"open","title":"adding method to allow choosing when to instantiate null params","user":{"login":"Turini","id":1529021,"avatar_url":"https://avatars.githubusercontent.com/u/1529021?","gravatar_id":"8757ffa706118c797421d81fdf2603e8","url":"https://api.github.com/users/Turini","html_url":"https://github.com/Turini","followers_url":"https://api.github.com/users/Turini/followers","following_url":"https://api.github.com/users/Turini/following{/other_user}","gists_url":"https://api.github.com/users/Turini/gists{/gist_id}","starred_url":"https://api.github.com/users/Turini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turini/subscriptions","organizations_url":"https://api.github.com/users/Turini/orgs","repos_url":"https://api.github.com/users/Turini/repos","events_url":"https://api.github.com/users/Turini/events{/privacy}","received_events_url":"https://api.github.com/users/Turini/received_events","type":"User","site_admin":false},"body":"Fixes #532\r\n\r\n","created_at":"2014-07-03T15:55:38Z","updated_at":"2014-07-04T02:37:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e71efdc103881f44e2fc252bfae6da8406dde39","assignee":{"login":"Turini","id":1529021,"avatar_url":"https://avatars.githubusercontent.com/u/1529021?","gravatar_id":"8757ffa706118c797421d81fdf2603e8","url":"https://api.github.com/users/Turini","html_url":"https://github.com/Turini","followers_url":"https://api.github.com/users/Turini/followers","following_url":"https://api.github.com/users/Turini/following{/other_user}","gists_url":"https://api.github.com/users/Turini/gists{/gist_id}","starred_url":"https://api.github.com/users/Turini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turini/subscriptions","organizations_url":"https://api.github.com/users/Turini/orgs","repos_url":"https://api.github.com/users/Turini/repos","events_url":"https://api.github.com/users/Turini/events{/privacy}","received_events_url":"https://api.github.com/users/Turini/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/caelum/vraptor4/pulls/660/commits","review_comments_url":"https://api.github.com/repos/caelum/vraptor4/pulls/660/comments","review_comment_url":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/{number}","comments_url":"https://api.github.com/repos/caelum/vraptor4/issues/660/comments","statuses_url":"https://api.github.com/repos/caelum/vraptor4/statuses/879233434ad425ca4802edce9cf660ff3d42e24d","head":{"label":"caelum:nullOrNotNullThisIsTheQuestion","ref":"nullOrNotNullThisIsTheQuestion","sha":"879233434ad425ca4802edce9cf660ff3d42e24d","user":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?","gravatar_id":"89f2c16e318c3b2068c9d37c46a83989","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"repo":{"id":9821876,"name":"vraptor4","full_name":"caelum/vraptor4","owner":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?","gravatar_id":"89f2c16e318c3b2068c9d37c46a83989","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caelum/vraptor4","description":"A Java web MVC action-based framework","fork":false,"url":"https://api.github.com/repos/caelum/vraptor4","forks_url":"https://api.github.com/repos/caelum/vraptor4/forks","keys_url":"https://api.github.com/repos/caelum/vraptor4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caelum/vraptor4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caelum/vraptor4/teams","hooks_url":"https://api.github.com/repos/caelum/vraptor4/hooks","issue_events_url":"https://api.github.com/repos/caelum/vraptor4/issues/events{/number}","events_url":"https://api.github.com/repos/caelum/vraptor4/events","assignees_url":"https://api.github.com/repos/caelum/vraptor4/assignees{/user}","branches_url":"https://api.github.com/repos/caelum/vraptor4/branches{/branch}","tags_url":"https://api.github.com/repos/caelum/vraptor4/tags","blobs_url":"https://api.github.com/repos/caelum/vraptor4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caelum/vraptor4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caelum/vraptor4/git/refs{/sha}","trees_url":"https://api.github.com/repos/caelum/vraptor4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caelum/vraptor4/statuses/{sha}","languages_url":"https://api.github.com/repos/caelum/vraptor4/languages","stargazers_url":"https://api.github.com/repos/caelum/vraptor4/stargazers","contributors_url":"https://api.github.com/repos/caelum/vraptor4/contributors","subscribers_url":"https://api.github.com/repos/caelum/vraptor4/subscribers","subscription_url":"https://api.github.com/repos/caelum/vraptor4/subscription","commits_url":"https://api.github.com/repos/caelum/vraptor4/commits{/sha}","git_commits_url":"https://api.github.com/repos/caelum/vraptor4/git/commits{/sha}","comments_url":"https://api.github.com/repos/caelum/vraptor4/comments{/number}","issue_comment_url":"https://api.github.com/repos/caelum/vraptor4/issues/comments/{number}","contents_url":"https://api.github.com/repos/caelum/vraptor4/contents/{+path}","compare_url":"https://api.github.com/repos/caelum/vraptor4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caelum/vraptor4/merges","archive_url":"https://api.github.com/repos/caelum/vraptor4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caelum/vraptor4/downloads","issues_url":"https://api.github.com/repos/caelum/vraptor4/issues{/number}","pulls_url":"https://api.github.com/repos/caelum/vraptor4/pulls{/number}","milestones_url":"https://api.github.com/repos/caelum/vraptor4/milestones{/number}","notifications_url":"https://api.github.com/repos/caelum/vraptor4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caelum/vraptor4/labels{/name}","releases_url":"https://api.github.com/repos/caelum/vraptor4/releases{/id}","created_at":"2013-05-02T20:22:14Z","updated_at":"2014-07-03T13:53:07Z","pushed_at":"2014-07-04T00:00:24Z","git_url":"git://github.com/caelum/vraptor4.git","ssh_url":"git@github.com:caelum/vraptor4.git","clone_url":"https://github.com/caelum/vraptor4.git","svn_url":"https://github.com/caelum/vraptor4","homepage":"vraptor.org","size":29088,"stargazers_count":77,"watchers_count":77,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":55,"mirror_url":null,"open_issues_count":20,"forks":55,"open_issues":20,"watchers":77,"default_branch":"master"}},"base":{"label":"caelum:master","ref":"master","sha":"d33f075989364fcf83b5ea6ab51a017bdd140118","user":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?","gravatar_id":"89f2c16e318c3b2068c9d37c46a83989","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"repo":{"id":9821876,"name":"vraptor4","full_name":"caelum/vraptor4","owner":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?","gravatar_id":"89f2c16e318c3b2068c9d37c46a83989","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caelum/vraptor4","description":"A Java web MVC action-based framework","fork":false,"url":"https://api.github.com/repos/caelum/vraptor4","forks_url":"https://api.github.com/repos/caelum/vraptor4/forks","keys_url":"https://api.github.com/repos/caelum/vraptor4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caelum/vraptor4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caelum/vraptor4/teams","hooks_url":"https://api.github.com/repos/caelum/vraptor4/hooks","issue_events_url":"https://api.github.com/repos/caelum/vraptor4/issues/events{/number}","events_url":"https://api.github.com/repos/caelum/vraptor4/events","assignees_url":"https://api.github.com/repos/caelum/vraptor4/assignees{/user}","branches_url":"https://api.github.com/repos/caelum/vraptor4/branches{/branch}","tags_url":"https://api.github.com/repos/caelum/vraptor4/tags","blobs_url":"https://api.github.com/repos/caelum/vraptor4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caelum/vraptor4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caelum/vraptor4/git/refs{/sha}","trees_url":"https://api.github.com/repos/caelum/vraptor4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caelum/vraptor4/statuses/{sha}","languages_url":"https://api.github.com/repos/caelum/vraptor4/languages","stargazers_url":"https://api.github.com/repos/caelum/vraptor4/stargazers","contributors_url":"https://api.github.com/repos/caelum/vraptor4/contributors","subscribers_url":"https://api.github.com/repos/caelum/vraptor4/subscribers","subscription_url":"https://api.github.com/repos/caelum/vraptor4/subscription","commits_url":"https://api.github.com/repos/caelum/vraptor4/commits{/sha}","git_commits_url":"https://api.github.com/repos/caelum/vraptor4/git/commits{/sha}","comments_url":"https://api.github.com/repos/caelum/vraptor4/comments{/number}","issue_comment_url":"https://api.github.com/repos/caelum/vraptor4/issues/comments/{number}","contents_url":"https://api.github.com/repos/caelum/vraptor4/contents/{+path}","compare_url":"https://api.github.com/repos/caelum/vraptor4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caelum/vraptor4/merges","archive_url":"https://api.github.com/repos/caelum/vraptor4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caelum/vraptor4/downloads","issues_url":"https://api.github.com/repos/caelum/vraptor4/issues{/number}","pulls_url":"https://api.github.com/repos/caelum/vraptor4/pulls{/number}","milestones_url":"https://api.github.com/repos/caelum/vraptor4/milestones{/number}","notifications_url":"https://api.github.com/repos/caelum/vraptor4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caelum/vraptor4/labels{/name}","releases_url":"https://api.github.com/repos/caelum/vraptor4/releases{/id}","created_at":"2013-05-02T20:22:14Z","updated_at":"2014-07-03T13:53:07Z","pushed_at":"2014-07-04T00:00:24Z","git_url":"git://github.com/caelum/vraptor4.git","ssh_url":"git@github.com:caelum/vraptor4.git","clone_url":"https://github.com/caelum/vraptor4.git","svn_url":"https://github.com/caelum/vraptor4","homepage":"vraptor.org","size":29088,"stargazers_count":77,"watchers_count":77,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":55,"mirror_url":null,"open_issues_count":20,"forks":55,"open_issues":20,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/660"},"html":{"href":"https://github.com/caelum/vraptor4/pull/660"},"issue":{"href":"https://api.github.com/repos/caelum/vraptor4/issues/660"},"comments":{"href":"https://api.github.com/repos/caelum/vraptor4/issues/660/comments"},"review_comments":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/660/comments"},"review_comment":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/660/commits"},"statuses":{"href":"https://api.github.com/repos/caelum/vraptor4/statuses/879233434ad425ca4802edce9cf660ff3d42e24d"}}}}