GitHub PullRequestEvent at 2014-10-07 03:10:12
Repository: trillek-client-core
Actor: adam4813
Payload: {"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/catageek/trillek-client-core/pulls/4","id":22328626,"html_url":"https://github.com/catageek/trillek-client-core/pull/4","diff_url":"https://github.com/catageek/trillek-client-core/pull/4.diff","patch_url":"https://github.com/catageek/trillek-client-core/pull/4.patch","issue_url":"https://api.github.com/repos/catageek/trillek-client-core/issues/4","number":4,"state":"open","locked":false,"title":"Some minor typos and Visual C++ oddities","user":{"login":"adam4813","id":3011917,"avatar_url":"https://avatars.githubusercontent.com/u/3011917?v=2","gravatar_id":"","url":"https://api.github.com/users/adam4813","html_url":"https://github.com/adam4813","followers_url":"https://api.github.com/users/adam4813/followers","following_url":"https://api.github.com/users/adam4813/following{/other_user}","gists_url":"https://api.github.com/users/adam4813/gists{/gist_id}","starred_url":"https://api.github.com/users/adam4813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam4813/subscriptions","organizations_url":"https://api.github.com/users/adam4813/orgs","repos_url":"https://api.github.com/users/adam4813/repos","events_url":"https://api.github.com/users/adam4813/events{/privacy}","received_events_url":"https://api.github.com/users/adam4813/received_events","type":"User","site_admin":false},"body":"This is the first slew of bandaging. There is still some other issues such as the vcomputer uses MOD_NONE which is already defined in windows and as such needs to be prefixed differently, and crypto++ needs to be removed to fix some linker errors.\r\n\r\nTypos:\r\n-frame_tp_tp instead of just frame_tp\r\n- A malformed target name in CMakeLists (tests build section)\r\n\r\nThe oddities include:\r\n-std::min must be surrounded in () to enforce\r\nthe std function instead of the min macro.\r\n-Removing the last references of constexpr\r\n-Visual C++ declares std::make_unique and so we must complement\r\nthe ifdef for non msvc with a using directive.\r\n-__popcnt64 isn't available unless doing a 64bit build\r\n-std::vector initialization lists in construction initializer lists isn't allowed\r\n\r\nErrors that need resolving:\r\n-transform.cpp glm::eualarAnglers conversion issues\r\n-Visual C++ friend template methods with fully qualified\r\nnamespaces causes an internal compiler error, so removing\r\nthe friend reference requires make several classes private\r\ndata public for access level reasons.\r\n-Registering a Shared component in registration fails with\r\ninternal compiler?!?!\r\n-Custom allocator can't align 16 for VelocityStruct when using\r\nbtVector3","created_at":"2014-10-07T03:10:11Z","updated_at":"2014-10-07T03:10:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/catageek/trillek-client-core/pulls/4/commits","review_comments_url":"https://api.github.com/repos/catageek/trillek-client-core/pulls/4/comments","review_comment_url":"https://api.github.com/repos/catageek/trillek-client-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/catageek/trillek-client-core/issues/4/comments","statuses_url":"https://api.github.com/repos/catageek/trillek-client-core/statuses/583ada3e21a82d82e42f505a0268a52e6a02c281","head":{"label":"adam4813:feature-component-framework","ref":"feature-component-framework","sha":"583ada3e21a82d82e42f505a0268a52e6a02c281","user":{"login":"adam4813","id":3011917,"avatar_url":"https://avatars.githubusercontent.com/u/3011917?v=2","gravatar_id":"","url":"https://api.github.com/users/adam4813","html_url":"https://github.com/adam4813","followers_url":"https://api.github.com/users/adam4813/followers","following_url":"https://api.github.com/users/adam4813/following{/other_user}","gists_url":"https://api.github.com/users/adam4813/gists{/gist_id}","starred_url":"https://api.github.com/users/adam4813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam4813/subscriptions","organizations_url":"https://api.github.com/users/adam4813/orgs","repos_url":"https://api.github.com/users/adam4813/repos","events_url":"https://api.github.com/users/adam4813/events{/privacy}","received_events_url":"https://api.github.com/users/adam4813/received_events","type":"User","site_admin":false},"repo":{"id":18149452,"name":"trillek-client-core","full_name":"adam4813/trillek-client-core","owner":{"login":"adam4813","id":3011917,"avatar_url":"https://avatars.githubusercontent.com/u/3011917?v=2","gravatar_id":"","url":"https://api.github.com/users/adam4813","html_url":"https://github.com/adam4813","followers_url":"https://api.github.com/users/adam4813/followers","following_url":"https://api.github.com/users/adam4813/following{/other_user}","gists_url":"https://api.github.com/users/adam4813/gists{/gist_id}","starred_url":"https://api.github.com/users/adam4813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam4813/subscriptions","organizations_url":"https://api.github.com/users/adam4813/orgs","repos_url":"https://api.github.com/users/adam4813/repos","events_url":"https://api.github.com/users/adam4813/events{/privacy}","received_events_url":"https://api.github.com/users/adam4813/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adam4813/trillek-client-core","description":"","fork":true,"url":"https://api.github.com/repos/adam4813/trillek-client-core","forks_url":"https://api.github.com/repos/adam4813/trillek-client-core/forks","keys_url":"https://api.github.com/repos/adam4813/trillek-client-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adam4813/trillek-client-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adam4813/trillek-client-core/teams","hooks_url":"https://api.github.com/repos/adam4813/trillek-client-core/hooks","issue_events_url":"https://api.github.com/repos/adam4813/trillek-client-core/issues/events{/number}","events_url":"https://api.github.com/repos/adam4813/trillek-client-core/events","assignees_url":"https://api.github.com/repos/adam4813/trillek-client-core/assignees{/user}","branches_url":"https://api.github.com/repos/adam4813/trillek-client-core/branches{/branch}","tags_url":"https://api.github.com/repos/adam4813/trillek-client-core/tags","blobs_url":"https://api.github.com/repos/adam4813/trillek-client-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adam4813/trillek-client-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adam4813/trillek-client-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/adam4813/trillek-client-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adam4813/trillek-client-core/statuses/{sha}","languages_url":"https://api.github.com/repos/adam4813/trillek-client-core/languages","stargazers_url":"https://api.github.com/repos/adam4813/trillek-client-core/stargazers","contributors_url":"https://api.github.com/repos/adam4813/trillek-client-core/contributors","subscribers_url":"https://api.github.com/repos/adam4813/trillek-client-core/subscribers","subscription_url":"https://api.github.com/repos/adam4813/trillek-client-core/subscription","commits_url":"https://api.github.com/repos/adam4813/trillek-client-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/adam4813/trillek-client-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/adam4813/trillek-client-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/adam4813/trillek-client-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/adam4813/trillek-client-core/contents/{+path}","compare_url":"https://api.github.com/repos/adam4813/trillek-client-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adam4813/trillek-client-core/merges","archive_url":"https://api.github.com/repos/adam4813/trillek-client-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adam4813/trillek-client-core/downloads","issues_url":"https://api.github.com/repos/adam4813/trillek-client-core/issues{/number}","pulls_url":"https://api.github.com/repos/adam4813/trillek-client-core/pulls{/number}","milestones_url":"https://api.github.com/repos/adam4813/trillek-client-core/milestones{/number}","notifications_url":"https://api.github.com/repos/adam4813/trillek-client-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adam4813/trillek-client-core/labels{/name}","releases_url":"https://api.github.com/repos/adam4813/trillek-client-core/releases{/id}","created_at":"2014-03-26T18:41:08Z","updated_at":"2014-06-29T22:22:14Z","pushed_at":"2014-10-07T03:08:22Z","git_url":"git://github.com/adam4813/trillek-client-core.git","ssh_url":"git@github.com:adam4813/trillek-client-core.git","clone_url":"https://github.com/adam4813/trillek-client-core.git","svn_url":"https://github.com/adam4813/trillek-client-core","homepage":null,"size":2349,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"develop"}},"base":{"label":"catageek:feature-component-framework","ref":"feature-component-framework","sha":"e6274269041f425eb420f59e700d2f714dd4877c","user":{"login":"catageek","id":1443839,"avatar_url":"https://avatars.githubusercontent.com/u/1443839?v=2","gravatar_id":"","url":"https://api.github.com/users/catageek","html_url":"https://github.com/catageek","followers_url":"https://api.github.com/users/catageek/followers","following_url":"https://api.github.com/users/catageek/following{/other_user}","gists_url":"https://api.github.com/users/catageek/gists{/gist_id}","starred_url":"https://api.github.com/users/catageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catageek/subscriptions","organizations_url":"https://api.github.com/users/catageek/orgs","repos_url":"https://api.github.com/users/catageek/repos","events_url":"https://api.github.com/users/catageek/events{/privacy}","received_events_url":"https://api.github.com/users/catageek/received_events","type":"User","site_admin":false},"repo":{"id":18773674,"name":"trillek-client-core","full_name":"catageek/trillek-client-core","owner":{"login":"catageek","id":1443839,"avatar_url":"https://avatars.githubusercontent.com/u/1443839?v=2","gravatar_id":"","url":"https://api.github.com/users/catageek","html_url":"https://github.com/catageek","followers_url":"https://api.github.com/users/catageek/followers","following_url":"https://api.github.com/users/catageek/following{/other_user}","gists_url":"https://api.github.com/users/catageek/gists{/gist_id}","starred_url":"https://api.github.com/users/catageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catageek/subscriptions","organizations_url":"https://api.github.com/users/catageek/orgs","repos_url":"https://api.github.com/users/catageek/repos","events_url":"https://api.github.com/users/catageek/events{/privacy}","received_events_url":"https://api.github.com/users/catageek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/catageek/trillek-client-core","description":"","fork":true,"url":"https://api.github.com/repos/catageek/trillek-client-core","forks_url":"https://api.github.com/repos/catageek/trillek-client-core/forks","keys_url":"https://api.github.com/repos/catageek/trillek-client-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catageek/trillek-client-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catageek/trillek-client-core/teams","hooks_url":"https://api.github.com/repos/catageek/trillek-client-core/hooks","issue_events_url":"https://api.github.com/repos/catageek/trillek-client-core/issues/events{/number}","events_url":"https://api.github.com/repos/catageek/trillek-client-core/events","assignees_url":"https://api.github.com/repos/catageek/trillek-client-core/assignees{/user}","branches_url":"https://api.github.com/repos/catageek/trillek-client-core/branches{/branch}","tags_url":"https://api.github.com/repos/catageek/trillek-client-core/tags","blobs_url":"https://api.github.com/repos/catageek/trillek-client-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catageek/trillek-client-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catageek/trillek-client-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/catageek/trillek-client-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catageek/trillek-client-core/statuses/{sha}","languages_url":"https://api.github.com/repos/catageek/trillek-client-core/languages","stargazers_url":"https://api.github.com/repos/catageek/trillek-client-core/stargazers","contributors_url":"https://api.github.com/repos/catageek/trillek-client-core/contributors","subscribers_url":"https://api.github.com/repos/catageek/trillek-client-core/subscribers","subscription_url":"https://api.github.com/repos/catageek/trillek-client-core/subscription","commits_url":"https://api.github.com/repos/catageek/trillek-client-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/catageek/trillek-client-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/catageek/trillek-client-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/catageek/trillek-client-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/catageek/trillek-client-core/contents/{+path}","compare_url":"https://api.github.com/repos/catageek/trillek-client-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catageek/trillek-client-core/merges","archive_url":"https://api.github.com/repos/catageek/trillek-client-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catageek/trillek-client-core/downloads","issues_url":"https://api.github.com/repos/catageek/trillek-client-core/issues{/number}","pulls_url":"https://api.github.com/repos/catageek/trillek-client-core/pulls{/number}","milestones_url":"https://api.github.com/repos/catageek/trillek-client-core/milestones{/number}","notifications_url":"https://api.github.com/repos/catageek/trillek-client-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catageek/trillek-client-core/labels{/name}","releases_url":"https://api.github.com/repos/catageek/trillek-client-core/releases{/id}","created_at":"2014-04-14T19:33:22Z","updated_at":"2014-06-22T10:01:58Z","pushed_at":"2014-10-04T21:56:41Z","git_url":"git://github.com/catageek/trillek-client-core.git","ssh_url":"git@github.com:catageek/trillek-client-core.git","clone_url":"https://github.com/catageek/trillek-client-core.git","svn_url":"https://github.com/catageek/trillek-client-core","homepage":null,"size":2313,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/catageek/trillek-client-core/pulls/4"},"html":{"href":"https://github.com/catageek/trillek-client-core/pull/4"},"issue":{"href":"https://api.github.com/repos/catageek/trillek-client-core/issues/4"},"comments":{"href":"https://api.github.com/repos/catageek/trillek-client-core/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/catageek/trillek-client-core/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/catageek/trillek-client-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/catageek/trillek-client-core/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/catageek/trillek-client-core/statuses/583ada3e21a82d82e42f505a0268a52e6a02c281"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":52,"deletions":41,"changed_files":20}}