GitHub PullRequestReviewCommentEvent at 2014-11-10 14:37:30
Repository: barclamp-nova
Actor: dirkmueller
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/20084591","id":20084591,"diff_hunk":"@@ -91,10 +108,14 @@ def set_boot_kernel_and_trigger_reboot(flavor='default')\n     supports :status => true, :start => true, :stop => true, :restart => true\n     action [:enable, :start]\n     if node.platform == \"suse\"\n-      # Workaround broken open-iscsi init scripts that return a failed code\n-      # but start the service anyway. run a status command afterwards to\n-      # see what the real status is (bnc#885834)\n-      start_command \"/etc/init.d/open-iscsi start; /etc/init.d/open-iscsi status\"\n+      if node[\"platform_version\"].to_f <= 11.3","path":"chef/cookbooks/nova/recipes/compute.rb","position":67,"original_position":67,"commit_id":"c525b602b71dba165515848dfb30b60c161e7c04","original_commit_id":"c525b602b71dba165515848dfb30b60c161e7c04","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"body":"  < 12","created_at":"2014-11-10T14:37:30Z","updated_at":"2014-11-10T14:37:30Z","html_url":"https://github.com/crowbar/barclamp-nova/pull/400#discussion_r20084591","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/400","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/20084591"},"html":{"href":"https://github.com/crowbar/barclamp-nova/pull/400#discussion_r20084591"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/400"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/400","id":23607967,"html_url":"https://github.com/crowbar/barclamp-nova/pull/400","diff_url":"https://github.com/crowbar/barclamp-nova/pull/400.diff","patch_url":"https://github.com/crowbar/barclamp-nova/pull/400.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues/400","number":400,"state":"open","locked":false,"title":"Make nova compute deployable on SLE12","user":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"body":"This change makes Nova Compute deployable on SLES 12 and Chef 11","created_at":"2014-10-30T14:26:38Z","updated_at":"2014-11-10T14:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c34b3f9a849f504b81368eaf8b942e508c4097d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/400/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/400/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues/400/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-nova/statuses/c525b602b71dba165515848dfb30b60c161e7c04","head":{"label":"mjura:sles12-deployment","ref":"sles12-deployment","sha":"c525b602b71dba165515848dfb30b60c161e7c04","user":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"repo":{"id":10122741,"name":"barclamp-nova","full_name":"mjura/barclamp-nova","owner":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjura/barclamp-nova","description":"OpenStack Compute","fork":true,"url":"https://api.github.com/repos/mjura/barclamp-nova","forks_url":"https://api.github.com/repos/mjura/barclamp-nova/forks","keys_url":"https://api.github.com/repos/mjura/barclamp-nova/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjura/barclamp-nova/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjura/barclamp-nova/teams","hooks_url":"https://api.github.com/repos/mjura/barclamp-nova/hooks","issue_events_url":"https://api.github.com/repos/mjura/barclamp-nova/issues/events{/number}","events_url":"https://api.github.com/repos/mjura/barclamp-nova/events","assignees_url":"https://api.github.com/repos/mjura/barclamp-nova/assignees{/user}","branches_url":"https://api.github.com/repos/mjura/barclamp-nova/branches{/branch}","tags_url":"https://api.github.com/repos/mjura/barclamp-nova/tags","blobs_url":"https://api.github.com/repos/mjura/barclamp-nova/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjura/barclamp-nova/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjura/barclamp-nova/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjura/barclamp-nova/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjura/barclamp-nova/statuses/{sha}","languages_url":"https://api.github.com/repos/mjura/barclamp-nova/languages","stargazers_url":"https://api.github.com/repos/mjura/barclamp-nova/stargazers","contributors_url":"https://api.github.com/repos/mjura/barclamp-nova/contributors","subscribers_url":"https://api.github.com/repos/mjura/barclamp-nova/subscribers","subscription_url":"https://api.github.com/repos/mjura/barclamp-nova/subscription","commits_url":"https://api.github.com/repos/mjura/barclamp-nova/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjura/barclamp-nova/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjura/barclamp-nova/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjura/barclamp-nova/issues/comments/{number}","contents_url":"https://api.github.com/repos/mjura/barclamp-nova/contents/{+path}","compare_url":"https://api.github.com/repos/mjura/barclamp-nova/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjura/barclamp-nova/merges","archive_url":"https://api.github.com/repos/mjura/barclamp-nova/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjura/barclamp-nova/downloads","issues_url":"https://api.github.com/repos/mjura/barclamp-nova/issues{/number}","pulls_url":"https://api.github.com/repos/mjura/barclamp-nova/pulls{/number}","milestones_url":"https://api.github.com/repos/mjura/barclamp-nova/milestones{/number}","notifications_url":"https://api.github.com/repos/mjura/barclamp-nova/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjura/barclamp-nova/labels{/name}","releases_url":"https://api.github.com/repos/mjura/barclamp-nova/releases{/id}","created_at":"2013-05-17T12:24:39Z","updated_at":"2014-02-12T08:05:18Z","pushed_at":"2014-10-30T14:25:36Z","git_url":"git://github.com/mjura/barclamp-nova.git","ssh_url":"git@github.com:mjura/barclamp-nova.git","clone_url":"https://github.com/mjura/barclamp-nova.git","svn_url":"https://github.com/mjura/barclamp-nova","homepage":"https://github.com/dellcloudedge/crowbar","size":2525,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"c821a8b842f86aeb8e77e3708c66a9b8e989b957","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":2351631,"name":"barclamp-nova","full_name":"crowbar/barclamp-nova","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-nova","description":"OpenStack Nova: Compute component","fork":false,"url":"https://api.github.com/repos/crowbar/barclamp-nova","forks_url":"https://api.github.com/repos/crowbar/barclamp-nova/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-nova/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-nova/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-nova/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-nova/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-nova/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-nova/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-nova/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-nova/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-nova/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-nova/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-nova/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-nova/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-nova/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-nova/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-nova/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-nova/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues/comments/{number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-nova/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-nova/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-nova/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-nova/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-nova/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-nova/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-nova/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-nova/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-nova/releases{/id}","created_at":"2011-09-08T21:23:08Z","updated_at":"2014-10-10T15:38:52Z","pushed_at":"2014-11-10T14:34:55Z","git_url":"git://github.com/crowbar/barclamp-nova.git","ssh_url":"git@github.com:crowbar/barclamp-nova.git","clone_url":"https://github.com/crowbar/barclamp-nova.git","svn_url":"https://github.com/crowbar/barclamp-nova","homepage":"https://github.com/crowbar/crowbar","size":5784,"stargazers_count":64,"watchers_count":64,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":196,"mirror_url":null,"open_issues_count":9,"forks":196,"open_issues":9,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/400"},"html":{"href":"https://github.com/crowbar/barclamp-nova/pull/400"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/issues/400"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/statuses/c525b602b71dba165515848dfb30b60c161e7c04"}}}}