GitHub PullRequestEvent at 2014-02-28 17:28:55
Repository: mruby
Actor: take-cheeze
Payload: {"action":"opened","number":1769,"pull_request":{"url":"https://api.github.com/repos/mruby/mruby/pulls/1769","id":13060848,"html_url":"https://github.com/mruby/mruby/pull/1769","diff_url":"https://github.com/mruby/mruby/pull/1769.diff","patch_url":"https://github.com/mruby/mruby/pull/1769.patch","issue_url":"https://api.github.com/repos/mruby/mruby/issues/1769","number":1769,"state":"open","title":"build_mrbconf.h","user":{"login":"take-cheeze","id":162074,"avatar_url":"https://avatars.githubusercontent.com/u/162074","gravatar_id":"45dc52d638066d63276ec07ef806bf82","url":"https://api.github.com/users/take-cheeze","html_url":"https://github.com/take-cheeze","followers_url":"https://api.github.com/users/take-cheeze/followers","following_url":"https://api.github.com/users/take-cheeze/following{/other_user}","gists_url":"https://api.github.com/users/take-cheeze/gists{/gist_id}","starred_url":"https://api.github.com/users/take-cheeze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/take-cheeze/subscriptions","organizations_url":"https://api.github.com/users/take-cheeze/orgs","repos_url":"https://api.github.com/users/take-cheeze/repos","events_url":"https://api.github.com/users/take-cheeze/events{/privacy}","received_events_url":"https://api.github.com/users/take-cheeze/received_events","type":"User","site_admin":false},"body":"With this patch mruby build system can separate `mrbconf.h` macro and compiler flag macro.\r\nTo use `mrbconf.h` macro use `MRuby::Build#enable_mrbconf` method to enable specific macro easily instead of appending to `defines` property.\r\n(if you need to enable `MRB_GC_FIXED_ARENA` call `enable_mrbconf :gc_fixed_arena`)\r\n\r\nAdditionally when you change **mrbconf** in **build_config.rb** the whole code would be recompiled with new **mrbconf** so that it's safer.\r\n\r\nThough it has some limitation:\r\n* it can't specify macro with value\r\n* it can't disable mrbconf\r\n* it can't detect conflict of mrbconfs\r\n","created_at":"2014-02-28T17:28:55Z","updated_at":"2014-02-28T17:28:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mruby/mruby/pulls/1769/commits","review_comments_url":"https://api.github.com/repos/mruby/mruby/pulls/1769/comments","review_comment_url":"https://api.github.com/repos/mruby/mruby/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mruby/mruby/issues/1769/comments","statuses_url":"https://api.github.com/repos/mruby/mruby/statuses/89155de2f2572242b6750d0baa6934e251ca1d01","head":{"label":"take-cheeze:build_mrbconf_h","ref":"build_mrbconf_h","sha":"89155de2f2572242b6750d0baa6934e251ca1d01","user":{"login":"take-cheeze","id":162074,"avatar_url":"https://avatars.githubusercontent.com/u/162074","gravatar_id":"45dc52d638066d63276ec07ef806bf82","url":"https://api.github.com/users/take-cheeze","html_url":"https://github.com/take-cheeze","followers_url":"https://api.github.com/users/take-cheeze/followers","following_url":"https://api.github.com/users/take-cheeze/following{/other_user}","gists_url":"https://api.github.com/users/take-cheeze/gists{/gist_id}","starred_url":"https://api.github.com/users/take-cheeze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/take-cheeze/subscriptions","organizations_url":"https://api.github.com/users/take-cheeze/orgs","repos_url":"https://api.github.com/users/take-cheeze/repos","events_url":"https://api.github.com/users/take-cheeze/events{/privacy}","received_events_url":"https://api.github.com/users/take-cheeze/received_events","type":"User","site_admin":false},"repo":{"id":5638386,"name":"mruby","full_name":"take-cheeze/mruby","owner":{"login":"take-cheeze","id":162074,"avatar_url":"https://avatars.githubusercontent.com/u/162074","gravatar_id":"45dc52d638066d63276ec07ef806bf82","url":"https://api.github.com/users/take-cheeze","html_url":"https://github.com/take-cheeze","followers_url":"https://api.github.com/users/take-cheeze/followers","following_url":"https://api.github.com/users/take-cheeze/following{/other_user}","gists_url":"https://api.github.com/users/take-cheeze/gists{/gist_id}","starred_url":"https://api.github.com/users/take-cheeze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/take-cheeze/subscriptions","organizations_url":"https://api.github.com/users/take-cheeze/orgs","repos_url":"https://api.github.com/users/take-cheeze/repos","events_url":"https://api.github.com/users/take-cheeze/events{/privacy}","received_events_url":"https://api.github.com/users/take-cheeze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/take-cheeze/mruby","description":"Lightweight Ruby","fork":true,"url":"https://api.github.com/repos/take-cheeze/mruby","forks_url":"https://api.github.com/repos/take-cheeze/mruby/forks","keys_url":"https://api.github.com/repos/take-cheeze/mruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/take-cheeze/mruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/take-cheeze/mruby/teams","hooks_url":"https://api.github.com/repos/take-cheeze/mruby/hooks","issue_events_url":"https://api.github.com/repos/take-cheeze/mruby/issues/events{/number}","events_url":"https://api.github.com/repos/take-cheeze/mruby/events","assignees_url":"https://api.github.com/repos/take-cheeze/mruby/assignees{/user}","branches_url":"https://api.github.com/repos/take-cheeze/mruby/branches{/branch}","tags_url":"https://api.github.com/repos/take-cheeze/mruby/tags","blobs_url":"https://api.github.com/repos/take-cheeze/mruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/take-cheeze/mruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/take-cheeze/mruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/take-cheeze/mruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/take-cheeze/mruby/statuses/{sha}","languages_url":"https://api.github.com/repos/take-cheeze/mruby/languages","stargazers_url":"https://api.github.com/repos/take-cheeze/mruby/stargazers","contributors_url":"https://api.github.com/repos/take-cheeze/mruby/contributors","subscribers_url":"https://api.github.com/repos/take-cheeze/mruby/subscribers","subscription_url":"https://api.github.com/repos/take-cheeze/mruby/subscription","commits_url":"https://api.github.com/repos/take-cheeze/mruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/take-cheeze/mruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/take-cheeze/mruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/take-cheeze/mruby/issues/comments/{number}","contents_url":"https://api.github.com/repos/take-cheeze/mruby/contents/{+path}","compare_url":"https://api.github.com/repos/take-cheeze/mruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/take-cheeze/mruby/merges","archive_url":"https://api.github.com/repos/take-cheeze/mruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/take-cheeze/mruby/downloads","issues_url":"https://api.github.com/repos/take-cheeze/mruby/issues{/number}","pulls_url":"https://api.github.com/repos/take-cheeze/mruby/pulls{/number}","milestones_url":"https://api.github.com/repos/take-cheeze/mruby/milestones{/number}","notifications_url":"https://api.github.com/repos/take-cheeze/mruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/take-cheeze/mruby/labels{/name}","releases_url":"https://api.github.com/repos/take-cheeze/mruby/releases{/id}","created_at":"2012-09-01T09:29:46Z","updated_at":"2014-02-28T17:28:55Z","pushed_at":"2014-02-28T17:08:34Z","git_url":"git://github.com/take-cheeze/mruby.git","ssh_url":"git@github.com:take-cheeze/mruby.git","clone_url":"https://github.com/take-cheeze/mruby.git","svn_url":"https://github.com/take-cheeze/mruby","homepage":null,"size":6219,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"mruby:master","ref":"master","sha":"2c7204fc937dc2ae6a8c2de75f508791c30f1de9","user":{"login":"mruby","id":1796512,"avatar_url":"https://avatars.githubusercontent.com/u/1796512","gravatar_id":null,"url":"https://api.github.com/users/mruby","html_url":"https://github.com/mruby","followers_url":"https://api.github.com/users/mruby/followers","following_url":"https://api.github.com/users/mruby/following{/other_user}","gists_url":"https://api.github.com/users/mruby/gists{/gist_id}","starred_url":"https://api.github.com/users/mruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruby/subscriptions","organizations_url":"https://api.github.com/users/mruby/orgs","repos_url":"https://api.github.com/users/mruby/repos","events_url":"https://api.github.com/users/mruby/events{/privacy}","received_events_url":"https://api.github.com/users/mruby/received_events","type":"Organization","site_admin":false},"repo":{"id":4073516,"name":"mruby","full_name":"mruby/mruby","owner":{"login":"mruby","id":1796512,"avatar_url":"https://avatars.githubusercontent.com/u/1796512","gravatar_id":null,"url":"https://api.github.com/users/mruby","html_url":"https://github.com/mruby","followers_url":"https://api.github.com/users/mruby/followers","following_url":"https://api.github.com/users/mruby/following{/other_user}","gists_url":"https://api.github.com/users/mruby/gists{/gist_id}","starred_url":"https://api.github.com/users/mruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruby/subscriptions","organizations_url":"https://api.github.com/users/mruby/orgs","repos_url":"https://api.github.com/users/mruby/repos","events_url":"https://api.github.com/users/mruby/events{/privacy}","received_events_url":"https://api.github.com/users/mruby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mruby/mruby","description":"Lightweight Ruby","fork":false,"url":"https://api.github.com/repos/mruby/mruby","forks_url":"https://api.github.com/repos/mruby/mruby/forks","keys_url":"https://api.github.com/repos/mruby/mruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mruby/mruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mruby/mruby/teams","hooks_url":"https://api.github.com/repos/mruby/mruby/hooks","issue_events_url":"https://api.github.com/repos/mruby/mruby/issues/events{/number}","events_url":"https://api.github.com/repos/mruby/mruby/events","assignees_url":"https://api.github.com/repos/mruby/mruby/assignees{/user}","branches_url":"https://api.github.com/repos/mruby/mruby/branches{/branch}","tags_url":"https://api.github.com/repos/mruby/mruby/tags","blobs_url":"https://api.github.com/repos/mruby/mruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mruby/mruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mruby/mruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/mruby/mruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mruby/mruby/statuses/{sha}","languages_url":"https://api.github.com/repos/mruby/mruby/languages","stargazers_url":"https://api.github.com/repos/mruby/mruby/stargazers","contributors_url":"https://api.github.com/repos/mruby/mruby/contributors","subscribers_url":"https://api.github.com/repos/mruby/mruby/subscribers","subscription_url":"https://api.github.com/repos/mruby/mruby/subscription","commits_url":"https://api.github.com/repos/mruby/mruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/mruby/mruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/mruby/mruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/mruby/mruby/issues/comments/{number}","contents_url":"https://api.github.com/repos/mruby/mruby/contents/{+path}","compare_url":"https://api.github.com/repos/mruby/mruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mruby/mruby/merges","archive_url":"https://api.github.com/repos/mruby/mruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mruby/mruby/downloads","issues_url":"https://api.github.com/repos/mruby/mruby/issues{/number}","pulls_url":"https://api.github.com/repos/mruby/mruby/pulls{/number}","milestones_url":"https://api.github.com/repos/mruby/mruby/milestones{/number}","notifications_url":"https://api.github.com/repos/mruby/mruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mruby/mruby/labels{/name}","releases_url":"https://api.github.com/repos/mruby/mruby/releases{/id}","created_at":"2012-04-19T09:11:15Z","updated_at":"2014-02-28T15:49:36Z","pushed_at":"2014-02-28T15:49:36Z","git_url":"git://github.com/mruby/mruby.git","ssh_url":"git@github.com:mruby/mruby.git","clone_url":"https://github.com/mruby/mruby.git","svn_url":"https://github.com/mruby/mruby","homepage":null,"size":17098,"stargazers_count":2433,"watchers_count":2433,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":369,"mirror_url":null,"open_issues_count":70,"forks":369,"open_issues":70,"watchers":2433,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mruby/mruby/pulls/1769"},"html":{"href":"https://github.com/mruby/mruby/pull/1769"},"issue":{"href":"https://api.github.com/repos/mruby/mruby/issues/1769"},"comments":{"href":"https://api.github.com/repos/mruby/mruby/issues/1769/comments"},"review_comments":{"href":"https://api.github.com/repos/mruby/mruby/pulls/1769/comments"},"review_comment":{"href":"https://api.github.com/repos/mruby/mruby/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mruby/mruby/pulls/1769/commits"},"statuses":{"href":"https://api.github.com/repos/mruby/mruby/statuses/89155de2f2572242b6750d0baa6934e251ca1d01"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":43,"deletions":4,"changed_files":5}}