GitHub PullRequestEvent at 2014-09-09 09:36:06
Repository: Mink
Actor: aik099
Payload: {"action":"opened","number":603,"pull_request":{"url":"https://api.github.com/repos/Behat/Mink/pulls/603","id":20943513,"html_url":"https://github.com/Behat/Mink/pull/603","diff_url":"https://github.com/Behat/Mink/pull/603.diff","patch_url":"https://github.com/Behat/Mink/pull/603.patch","issue_url":"https://api.github.com/repos/Behat/Mink/issues/603","number":603,"state":"open","locked":false,"title":"Change timeout of \"ElementInterface::waitFor\" to be in seconds","user":{"login":"aik099","id":1277526,"avatar_url":"https://avatars.githubusercontent.com/u/1277526?v=2","gravatar_id":"027e03406c7dfd1dd54dc944b0745d2f","url":"https://api.github.com/users/aik099","html_url":"https://github.com/aik099","followers_url":"https://api.github.com/users/aik099/followers","following_url":"https://api.github.com/users/aik099/following{/other_user}","gists_url":"https://api.github.com/users/aik099/gists{/gist_id}","starred_url":"https://api.github.com/users/aik099/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aik099/subscriptions","organizations_url":"https://api.github.com/users/aik099/orgs","repos_url":"https://api.github.com/users/aik099/repos","events_url":"https://api.github.com/users/aik099/events{/privacy}","received_events_url":"https://api.github.com/users/aik099/received_events","type":"User","site_admin":false},"body":"Having timeout for element waiting in seconds makes more sense, because method is designed to wait for elements to appear from AJAX requests, which usually doesn't take milliseconds to run. In any case having `0.1` as wait timeout seems more readable, then `100`.","created_at":"2014-09-09T09:36:05Z","updated_at":"2014-09-09T09:36:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Behat/Mink/pulls/603/commits","review_comments_url":"https://api.github.com/repos/Behat/Mink/pulls/603/comments","review_comment_url":"https://api.github.com/repos/Behat/Mink/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Behat/Mink/issues/603/comments","statuses_url":"https://api.github.com/repos/Behat/Mink/statuses/790b79361a583e598444bac72bcbc380699fb8ac","head":{"label":"aik099:wait-for-in-seconds","ref":"wait-for-in-seconds","sha":"790b79361a583e598444bac72bcbc380699fb8ac","user":{"login":"aik099","id":1277526,"avatar_url":"https://avatars.githubusercontent.com/u/1277526?v=2","gravatar_id":"027e03406c7dfd1dd54dc944b0745d2f","url":"https://api.github.com/users/aik099","html_url":"https://github.com/aik099","followers_url":"https://api.github.com/users/aik099/followers","following_url":"https://api.github.com/users/aik099/following{/other_user}","gists_url":"https://api.github.com/users/aik099/gists{/gist_id}","starred_url":"https://api.github.com/users/aik099/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aik099/subscriptions","organizations_url":"https://api.github.com/users/aik099/orgs","repos_url":"https://api.github.com/users/aik099/repos","events_url":"https://api.github.com/users/aik099/events{/privacy}","received_events_url":"https://api.github.com/users/aik099/received_events","type":"User","site_admin":false},"repo":{"id":10142642,"name":"Mink","full_name":"aik099/Mink","owner":{"login":"aik099","id":1277526,"avatar_url":"https://avatars.githubusercontent.com/u/1277526?v=2","gravatar_id":"027e03406c7dfd1dd54dc944b0745d2f","url":"https://api.github.com/users/aik099","html_url":"https://github.com/aik099","followers_url":"https://api.github.com/users/aik099/followers","following_url":"https://api.github.com/users/aik099/following{/other_user}","gists_url":"https://api.github.com/users/aik099/gists{/gist_id}","starred_url":"https://api.github.com/users/aik099/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aik099/subscriptions","organizations_url":"https://api.github.com/users/aik099/orgs","repos_url":"https://api.github.com/users/aik099/repos","events_url":"https://api.github.com/users/aik099/events{/privacy}","received_events_url":"https://api.github.com/users/aik099/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aik099/Mink","description":"PHP 5.3+ acceptance test framework for web applications","fork":true,"url":"https://api.github.com/repos/aik099/Mink","forks_url":"https://api.github.com/repos/aik099/Mink/forks","keys_url":"https://api.github.com/repos/aik099/Mink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aik099/Mink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aik099/Mink/teams","hooks_url":"https://api.github.com/repos/aik099/Mink/hooks","issue_events_url":"https://api.github.com/repos/aik099/Mink/issues/events{/number}","events_url":"https://api.github.com/repos/aik099/Mink/events","assignees_url":"https://api.github.com/repos/aik099/Mink/assignees{/user}","branches_url":"https://api.github.com/repos/aik099/Mink/branches{/branch}","tags_url":"https://api.github.com/repos/aik099/Mink/tags","blobs_url":"https://api.github.com/repos/aik099/Mink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aik099/Mink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aik099/Mink/git/refs{/sha}","trees_url":"https://api.github.com/repos/aik099/Mink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aik099/Mink/statuses/{sha}","languages_url":"https://api.github.com/repos/aik099/Mink/languages","stargazers_url":"https://api.github.com/repos/aik099/Mink/stargazers","contributors_url":"https://api.github.com/repos/aik099/Mink/contributors","subscribers_url":"https://api.github.com/repos/aik099/Mink/subscribers","subscription_url":"https://api.github.com/repos/aik099/Mink/subscription","commits_url":"https://api.github.com/repos/aik099/Mink/commits{/sha}","git_commits_url":"https://api.github.com/repos/aik099/Mink/git/commits{/sha}","comments_url":"https://api.github.com/repos/aik099/Mink/comments{/number}","issue_comment_url":"https://api.github.com/repos/aik099/Mink/issues/comments/{number}","contents_url":"https://api.github.com/repos/aik099/Mink/contents/{+path}","compare_url":"https://api.github.com/repos/aik099/Mink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aik099/Mink/merges","archive_url":"https://api.github.com/repos/aik099/Mink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aik099/Mink/downloads","issues_url":"https://api.github.com/repos/aik099/Mink/issues{/number}","pulls_url":"https://api.github.com/repos/aik099/Mink/pulls{/number}","milestones_url":"https://api.github.com/repos/aik099/Mink/milestones{/number}","notifications_url":"https://api.github.com/repos/aik099/Mink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aik099/Mink/labels{/name}","releases_url":"https://api.github.com/repos/aik099/Mink/releases{/id}","created_at":"2013-05-18T14:50:19Z","updated_at":"2014-06-18T19:10:06Z","pushed_at":"2014-09-09T09:33:57Z","git_url":"git://github.com/aik099/Mink.git","ssh_url":"git@github.com:aik099/Mink.git","clone_url":"https://github.com/aik099/Mink.git","svn_url":"https://github.com/aik099/Mink","homepage":"http://mink.behat.org/","size":2565,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Behat:master","ref":"master","sha":"63b8b26ff2aea40c0e7b6e15ea7ae7c09f623712","user":{"login":"Behat","id":547869,"avatar_url":"https://avatars.githubusercontent.com/u/547869?v=2","gravatar_id":"19bcb18e3b02d994c5c2fad3198fe537","url":"https://api.github.com/users/Behat","html_url":"https://github.com/Behat","followers_url":"https://api.github.com/users/Behat/followers","following_url":"https://api.github.com/users/Behat/following{/other_user}","gists_url":"https://api.github.com/users/Behat/gists{/gist_id}","starred_url":"https://api.github.com/users/Behat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Behat/subscriptions","organizations_url":"https://api.github.com/users/Behat/orgs","repos_url":"https://api.github.com/users/Behat/repos","events_url":"https://api.github.com/users/Behat/events{/privacy}","received_events_url":"https://api.github.com/users/Behat/received_events","type":"Organization","site_admin":false},"repo":{"id":1567795,"name":"Mink","full_name":"Behat/Mink","owner":{"login":"Behat","id":547869,"avatar_url":"https://avatars.githubusercontent.com/u/547869?v=2","gravatar_id":"19bcb18e3b02d994c5c2fad3198fe537","url":"https://api.github.com/users/Behat","html_url":"https://github.com/Behat","followers_url":"https://api.github.com/users/Behat/followers","following_url":"https://api.github.com/users/Behat/following{/other_user}","gists_url":"https://api.github.com/users/Behat/gists{/gist_id}","starred_url":"https://api.github.com/users/Behat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Behat/subscriptions","organizations_url":"https://api.github.com/users/Behat/orgs","repos_url":"https://api.github.com/users/Behat/repos","events_url":"https://api.github.com/users/Behat/events{/privacy}","received_events_url":"https://api.github.com/users/Behat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Behat/Mink","description":"PHP 5.3+ web browser emulator abstraction","fork":false,"url":"https://api.github.com/repos/Behat/Mink","forks_url":"https://api.github.com/repos/Behat/Mink/forks","keys_url":"https://api.github.com/repos/Behat/Mink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Behat/Mink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Behat/Mink/teams","hooks_url":"https://api.github.com/repos/Behat/Mink/hooks","issue_events_url":"https://api.github.com/repos/Behat/Mink/issues/events{/number}","events_url":"https://api.github.com/repos/Behat/Mink/events","assignees_url":"https://api.github.com/repos/Behat/Mink/assignees{/user}","branches_url":"https://api.github.com/repos/Behat/Mink/branches{/branch}","tags_url":"https://api.github.com/repos/Behat/Mink/tags","blobs_url":"https://api.github.com/repos/Behat/Mink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Behat/Mink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Behat/Mink/git/refs{/sha}","trees_url":"https://api.github.com/repos/Behat/Mink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Behat/Mink/statuses/{sha}","languages_url":"https://api.github.com/repos/Behat/Mink/languages","stargazers_url":"https://api.github.com/repos/Behat/Mink/stargazers","contributors_url":"https://api.github.com/repos/Behat/Mink/contributors","subscribers_url":"https://api.github.com/repos/Behat/Mink/subscribers","subscription_url":"https://api.github.com/repos/Behat/Mink/subscription","commits_url":"https://api.github.com/repos/Behat/Mink/commits{/sha}","git_commits_url":"https://api.github.com/repos/Behat/Mink/git/commits{/sha}","comments_url":"https://api.github.com/repos/Behat/Mink/comments{/number}","issue_comment_url":"https://api.github.com/repos/Behat/Mink/issues/comments/{number}","contents_url":"https://api.github.com/repos/Behat/Mink/contents/{+path}","compare_url":"https://api.github.com/repos/Behat/Mink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Behat/Mink/merges","archive_url":"https://api.github.com/repos/Behat/Mink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Behat/Mink/downloads","issues_url":"https://api.github.com/repos/Behat/Mink/issues{/number}","pulls_url":"https://api.github.com/repos/Behat/Mink/pulls{/number}","milestones_url":"https://api.github.com/repos/Behat/Mink/milestones{/number}","notifications_url":"https://api.github.com/repos/Behat/Mink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Behat/Mink/labels{/name}","releases_url":"https://api.github.com/repos/Behat/Mink/releases{/id}","created_at":"2011-04-04T16:11:16Z","updated_at":"2014-09-05T03:43:45Z","pushed_at":"2014-08-19T12:42:01Z","git_url":"git://github.com/Behat/Mink.git","ssh_url":"git@github.com:Behat/Mink.git","clone_url":"https://github.com/Behat/Mink.git","svn_url":"https://github.com/Behat/Mink","homepage":"http://mink.behat.org/","size":4733,"stargazers_count":574,"watchers_count":574,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":172,"mirror_url":null,"open_issues_count":50,"forks":172,"open_issues":50,"watchers":574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Behat/Mink/pulls/603"},"html":{"href":"https://github.com/Behat/Mink/pull/603"},"issue":{"href":"https://api.github.com/repos/Behat/Mink/issues/603"},"comments":{"href":"https://api.github.com/repos/Behat/Mink/issues/603/comments"},"review_comments":{"href":"https://api.github.com/repos/Behat/Mink/pulls/603/comments"},"review_comment":{"href":"https://api.github.com/repos/Behat/Mink/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Behat/Mink/pulls/603/commits"},"statuses":{"href":"https://api.github.com/repos/Behat/Mink/statuses/790b79361a583e598444bac72bcbc380699fb8ac"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":5,"changed_files":3}}