GitHub PushEvent at 2014-09-04 22:58:52
Repository: ovs
Actor: shettyg
Payload: {"shas":[["2252cbea780f0981911ea0998a1e4d6ec8bbbf78","c4089df073b4e0e1342dd7f47682381cc38caa5c@nicira.com","AUTHORS: Add Ariel Tubaltsev to AUTHORS.\n\nI missed it while adding commit 6ee1400bbff(vtep: additions to BFD\nconfiguration and status reporting)\n\nSigned-off-by: Gurucharan Shetty <gshetty@nicira.com>","Gurucharan Shetty",true],["ec2d2b5f03913f262a11c23f3e9b2a9e30157139","c4089df073b4e0e1342dd7f47682381cc38caa5c@nicira.com","ovs-atomics: Add atomic support Windows.\n\nBefore this change (i.e., with pthread locks for atomics on Windows),\nthe benchmark for cmap and hmap was as follows:\n\n$ ./tests/ovstest.exe test-cmap benchmark 10000000 3 1\nBenchmarking with n=10000000, 3 threads, 1.00% mutations:\ncmap insert:  61070 ms\ncmap iterate:  2750 ms\ncmap search:  14238 ms\ncmap destroy:  8354 ms\n\nhmap insert:   1701 ms\nhmap iterate:   985 ms\nhmap search:   3755 ms\nhmap destroy:  1052 ms\n\nAfter this change, the benchmark is as follows:\n$ ./tests/ovstest.exe test-cmap benchmark 10000000 3 1\nBenchmarking with n=10000000, 3 threads, 1.00% mutations:\ncmap insert:   3666 ms\ncmap iterate:   365 ms\ncmap search:   2016 ms\ncmap destroy:  1331 ms\n\nhmap insert:   1495 ms\nhmap iterate:  1026 ms\nhmap search:   4167 ms\nhmap destroy:  1046 ms\n\nSo there is clearly a big improvement for cmap.\n\nBut the correspondig test on Linux (with gcc 4.6) yeilds the following:\n\n./tests/ovstest test-cmap benchmark 10000000 3 1\nBenchmarking with n=10000000, 3 threads, 1.00% mutations:\ncmap insert:   3917 ms\ncmap iterate:   355 ms\ncmap search:    871 ms\ncmap destroy:  1158 ms\n\nhmap insert:   1988 ms\nhmap iterate:  1005 ms\nhmap search:   5428 ms\nhmap destroy:   980 ms\n\nSo for this particular test, except for \"cmap search\", Windows and\nLinux have similar performance. Windows is around 2.5x slower in \"cmap search\"\ncompared to Linux. This has to be investigated.\n\nSigned-off-by: Gurucharan Shetty <gshetty@nicira.com>\n[With a lot of inputs and help from Jarno]\nSigned-off-by: Jarno Rajahalme <jrajahalme@nicira.com>","Gurucharan Shetty",true]],"size":2,"ref":"refs/heads/master","head":"ec2d2b5f03913f262a11c23f3e9b2a9e30157139"}