GitHub PullRequestReviewCommentEvent at 2014-10-19 07:34:18
Repository: repo
Actor: damithc
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/repo/pulls/comments/19058419","id":19058419,"diff_hunk":"@@ -36,7 +37,92 @@ public void testIsMatching() {\n         assertEquals(true, StringHelper.isMatching(\"\\u0061\\u0300\", \"à\"));\n         assertEquals(false, StringHelper.isMatching(\"Héllo\", \"Hello\"));\n     }\n+    \n+    @Test \n+    public void testIsAnyMatching(){\n+        //this method is used in header row processing in StudentAttributesFactory: locateColumnIndexes\n+        //so use this to test the various header field regex expressions here\n+        \n+        \n+        String[] regexArray = FieldValidator.REGEX_COLUMN_NAME;\n+        \n+        assertEquals(true, StringHelper.isAnyMatching(\"names\", regexArray));","path":"src/test/java/teammates/test/cases/common/StringHelperTest.java","position":21,"original_position":21,"commit_id":"ce0d7127e500d1b73392f98b32289bac967bc9cc","original_commit_id":"ce0d7127e500d1b73392f98b32289bac967bc9cc","user":{"login":"damithc","id":1673303,"avatar_url":"https://avatars.githubusercontent.com/u/1673303?v=2","gravatar_id":"","url":"https://api.github.com/users/damithc","html_url":"https://github.com/damithc","followers_url":"https://api.github.com/users/damithc/followers","following_url":"https://api.github.com/users/damithc/following{/other_user}","gists_url":"https://api.github.com/users/damithc/gists{/gist_id}","starred_url":"https://api.github.com/users/damithc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damithc/subscriptions","organizations_url":"https://api.github.com/users/damithc/orgs","repos_url":"https://api.github.com/users/damithc/repos","events_url":"https://api.github.com/users/damithc/events{/privacy}","received_events_url":"https://api.github.com/users/damithc/received_events","type":"User","site_admin":false},"body":"Perhaps you can use a helper method here to reduce the amount of code? e.g.\r\n`void verifyRegexMatch(String[] stringsToMatch, String[] regexArray, boolean expectedResult)`\r\nThe method will go through the strings in the array and assert the result for each?","created_at":"2014-10-19T07:34:18Z","updated_at":"2014-10-19T07:34:18Z","html_url":"https://github.com/TEAMMATES/repo/pull/2665#discussion_r19058419","pull_request_url":"https://api.github.com/repos/TEAMMATES/repo/pulls/2665","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/comments/19058419"},"html":{"href":"https://github.com/TEAMMATES/repo/pull/2665#discussion_r19058419"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/2665"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/repo/pulls/2665","id":22970347,"html_url":"https://github.com/TEAMMATES/repo/pull/2665","diff_url":"https://github.com/TEAMMATES/repo/pull/2665.diff","patch_url":"https://github.com/TEAMMATES/repo/pull/2665.patch","issue_url":"https://api.github.com/repos/TEAMMATES/repo/issues/2665","number":2665,"state":"open","locked":false,"title":"instructorCourseEnrol: accept variant column headers #2637","user":{"login":"ymoctavia","id":7552558,"avatar_url":"https://avatars.githubusercontent.com/u/7552558?v=2","gravatar_id":"","url":"https://api.github.com/users/ymoctavia","html_url":"https://github.com/ymoctavia","followers_url":"https://api.github.com/users/ymoctavia/followers","following_url":"https://api.github.com/users/ymoctavia/following{/other_user}","gists_url":"https://api.github.com/users/ymoctavia/gists{/gist_id}","starred_url":"https://api.github.com/users/ymoctavia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymoctavia/subscriptions","organizations_url":"https://api.github.com/users/ymoctavia/orgs","repos_url":"https://api.github.com/users/ymoctavia/repos","events_url":"https://api.github.com/users/ymoctavia/events{/privacy}","received_events_url":"https://api.github.com/users/ymoctavia/received_events","type":"User","site_admin":false},"body":"for #2637 ","created_at":"2014-10-18T17:22:37Z","updated_at":"2014-10-19T07:34:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b158e878744fd772b0a0cb53bd2349acd51ec375","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/repo/pulls/2665/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/repo/pulls/2665/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/repo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TEAMMATES/repo/issues/2665/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/repo/statuses/ce0d7127e500d1b73392f98b32289bac967bc9cc","head":{"label":"TEAMMATES:Issue2637","ref":"Issue2637","sha":"ce0d7127e500d1b73392f98b32289bac967bc9cc","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=2","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"repo","full_name":"TEAMMATES/repo","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=2","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/repo","description":"","fork":false,"url":"https://api.github.com/repos/TEAMMATES/repo","forks_url":"https://api.github.com/repos/TEAMMATES/repo/forks","keys_url":"https://api.github.com/repos/TEAMMATES/repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/repo/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/repo/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/repo/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/repo/events","assignees_url":"https://api.github.com/repos/TEAMMATES/repo/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/repo/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/repo/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/repo/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/repo/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/repo/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/repo/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/repo/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/repo/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/repo/issues/comments/{number}","contents_url":"https://api.github.com/repos/TEAMMATES/repo/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/repo/merges","archive_url":"https://api.github.com/repos/TEAMMATES/repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/repo/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/repo/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/repo/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/repo/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/repo/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/repo/releases{/id}","created_at":"2014-05-02T07:43:00Z","updated_at":"2014-10-10T14:56:12Z","pushed_at":"2014-10-19T07:22:33Z","git_url":"git://github.com/TEAMMATES/repo.git","ssh_url":"git@github.com:TEAMMATES/repo.git","clone_url":"https://github.com/TEAMMATES/repo.git","svn_url":"https://github.com/TEAMMATES/repo","homepage":"","size":125746,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":465,"forks":17,"open_issues":465,"watchers":18,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"26fafd85fa20340d018be502b0d149f6bd948d50","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=2","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"repo","full_name":"TEAMMATES/repo","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=2","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/repo","description":"","fork":false,"url":"https://api.github.com/repos/TEAMMATES/repo","forks_url":"https://api.github.com/repos/TEAMMATES/repo/forks","keys_url":"https://api.github.com/repos/TEAMMATES/repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/repo/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/repo/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/repo/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/repo/events","assignees_url":"https://api.github.com/repos/TEAMMATES/repo/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/repo/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/repo/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/repo/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/repo/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/repo/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/repo/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/repo/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/repo/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/repo/issues/comments/{number}","contents_url":"https://api.github.com/repos/TEAMMATES/repo/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/repo/merges","archive_url":"https://api.github.com/repos/TEAMMATES/repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/repo/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/repo/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/repo/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/repo/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/repo/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/repo/releases{/id}","created_at":"2014-05-02T07:43:00Z","updated_at":"2014-10-10T14:56:12Z","pushed_at":"2014-10-19T07:22:33Z","git_url":"git://github.com/TEAMMATES/repo.git","ssh_url":"git@github.com:TEAMMATES/repo.git","clone_url":"https://github.com/TEAMMATES/repo.git","svn_url":"https://github.com/TEAMMATES/repo","homepage":"","size":125746,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":465,"forks":17,"open_issues":465,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/2665"},"html":{"href":"https://github.com/TEAMMATES/repo/pull/2665"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/repo/issues/2665"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/repo/issues/2665/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/2665/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/repo/pulls/2665/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/repo/statuses/ce0d7127e500d1b73392f98b32289bac967bc9cc"}}}}