GitHub PullRequestReviewCommentEvent at 2014-12-14 18:59:05
Repository: scikit-image
Actor: stefanv
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments/21798241","id":21798241,"diff_hunk":"@@ -0,0 +1,244 @@\n+\n+# -*- coding: utf-8 -*-\n+\"\"\"\n+Port of Manuel Guizar's code from:\n+http://www.mathworks.com/matlabcentral/fileexchange/18401-efficient-subpixel-image-registration-by-cross-correlation\n+\"\"\"\n+\n+import numpy as np\n+\n+\n+def _dftups(data, upsampled_region_size=None,","path":"skimage/feature/phase_correlate.py","position":11,"original_position":11,"commit_id":"fe9efc7825e65bed19a2980add27cf18ab11e93f","original_commit_id":"fe9efc7825e65bed19a2980add27cf18ab11e93f","user":{"login":"stefanv","id":45071,"avatar_url":"https://avatars.githubusercontent.com/u/45071?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanv","html_url":"https://github.com/stefanv","followers_url":"https://api.github.com/users/stefanv/followers","following_url":"https://api.github.com/users/stefanv/following{/other_user}","gists_url":"https://api.github.com/users/stefanv/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanv/subscriptions","organizations_url":"https://api.github.com/users/stefanv/orgs","repos_url":"https://api.github.com/users/stefanv/repos","events_url":"https://api.github.com/users/stefanv/events{/privacy}","received_events_url":"https://api.github.com/users/stefanv/received_events","type":"User","site_admin":false},"body":"I read my code top down, and my internal Python interpreter breaks whenever I meet an undefined function.","created_at":"2014-12-14T18:59:05Z","updated_at":"2014-12-14T18:59:05Z","html_url":"https://github.com/scikit-image/scikit-image/pull/1066#discussion_r21798241","pull_request_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1066","_links":{"self":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments/21798241"},"html":{"href":"https://github.com/scikit-image/scikit-image/pull/1066#discussion_r21798241"},"pull_request":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1066"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1066","id":18320158,"html_url":"https://github.com/scikit-image/scikit-image/pull/1066","diff_url":"https://github.com/scikit-image/scikit-image/pull/1066.diff","patch_url":"https://github.com/scikit-image/scikit-image/pull/1066.patch","issue_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/1066","number":1066,"state":"open","locked":false,"title":"subpixel shift registration addition","user":{"login":"msarahan","id":38393,"avatar_url":"https://avatars.githubusercontent.com/u/38393?v=3","gravatar_id":"","url":"https://api.github.com/users/msarahan","html_url":"https://github.com/msarahan","followers_url":"https://api.github.com/users/msarahan/followers","following_url":"https://api.github.com/users/msarahan/following{/other_user}","gists_url":"https://api.github.com/users/msarahan/gists{/gist_id}","starred_url":"https://api.github.com/users/msarahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msarahan/subscriptions","organizations_url":"https://api.github.com/users/msarahan/orgs","repos_url":"https://api.github.com/users/msarahan/repos","events_url":"https://api.github.com/users/msarahan/events{/privacy}","received_events_url":"https://api.github.com/users/msarahan/received_events","type":"User","site_admin":false},"body":"For the sake of keeping a more readily accessibly reference to this controversial addition, here's a PR.\r\n\r\nDiscussion has thus far been at:\r\nhttps://groups.google.com/forum/#!topic/scikit-image/fDbdOgHgolI\r\n\r\nThis PR should not be merged until licensing issues discussed in that email thread have been addressed.","created_at":"2014-07-13T03:43:11Z","updated_at":"2014-12-14T18:59:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c67630c0b5bd836e4e33e15fd52df429c9a02e95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1066/commits","review_comments_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1066/comments","review_comment_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/1066/comments","statuses_url":"https://api.github.com/repos/scikit-image/scikit-image/statuses/fe9efc7825e65bed19a2980add27cf18ab11e93f","head":{"label":"msarahan:PhaseCorrelation","ref":"PhaseCorrelation","sha":"fe9efc7825e65bed19a2980add27cf18ab11e93f","user":{"login":"msarahan","id":38393,"avatar_url":"https://avatars.githubusercontent.com/u/38393?v=3","gravatar_id":"","url":"https://api.github.com/users/msarahan","html_url":"https://github.com/msarahan","followers_url":"https://api.github.com/users/msarahan/followers","following_url":"https://api.github.com/users/msarahan/following{/other_user}","gists_url":"https://api.github.com/users/msarahan/gists{/gist_id}","starred_url":"https://api.github.com/users/msarahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msarahan/subscriptions","organizations_url":"https://api.github.com/users/msarahan/orgs","repos_url":"https://api.github.com/users/msarahan/repos","events_url":"https://api.github.com/users/msarahan/events{/privacy}","received_events_url":"https://api.github.com/users/msarahan/received_events","type":"User","site_admin":false},"repo":{"id":19188651,"name":"scikit-image","full_name":"msarahan/scikit-image","owner":{"login":"msarahan","id":38393,"avatar_url":"https://avatars.githubusercontent.com/u/38393?v=3","gravatar_id":"","url":"https://api.github.com/users/msarahan","html_url":"https://github.com/msarahan","followers_url":"https://api.github.com/users/msarahan/followers","following_url":"https://api.github.com/users/msarahan/following{/other_user}","gists_url":"https://api.github.com/users/msarahan/gists{/gist_id}","starred_url":"https://api.github.com/users/msarahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msarahan/subscriptions","organizations_url":"https://api.github.com/users/msarahan/orgs","repos_url":"https://api.github.com/users/msarahan/repos","events_url":"https://api.github.com/users/msarahan/events{/privacy}","received_events_url":"https://api.github.com/users/msarahan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msarahan/scikit-image","description":"Image Processing SciKit (Toolbox for SciPy)","fork":true,"url":"https://api.github.com/repos/msarahan/scikit-image","forks_url":"https://api.github.com/repos/msarahan/scikit-image/forks","keys_url":"https://api.github.com/repos/msarahan/scikit-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msarahan/scikit-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msarahan/scikit-image/teams","hooks_url":"https://api.github.com/repos/msarahan/scikit-image/hooks","issue_events_url":"https://api.github.com/repos/msarahan/scikit-image/issues/events{/number}","events_url":"https://api.github.com/repos/msarahan/scikit-image/events","assignees_url":"https://api.github.com/repos/msarahan/scikit-image/assignees{/user}","branches_url":"https://api.github.com/repos/msarahan/scikit-image/branches{/branch}","tags_url":"https://api.github.com/repos/msarahan/scikit-image/tags","blobs_url":"https://api.github.com/repos/msarahan/scikit-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msarahan/scikit-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msarahan/scikit-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/msarahan/scikit-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msarahan/scikit-image/statuses/{sha}","languages_url":"https://api.github.com/repos/msarahan/scikit-image/languages","stargazers_url":"https://api.github.com/repos/msarahan/scikit-image/stargazers","contributors_url":"https://api.github.com/repos/msarahan/scikit-image/contributors","subscribers_url":"https://api.github.com/repos/msarahan/scikit-image/subscribers","subscription_url":"https://api.github.com/repos/msarahan/scikit-image/subscription","commits_url":"https://api.github.com/repos/msarahan/scikit-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/msarahan/scikit-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/msarahan/scikit-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/msarahan/scikit-image/issues/comments/{number}","contents_url":"https://api.github.com/repos/msarahan/scikit-image/contents/{+path}","compare_url":"https://api.github.com/repos/msarahan/scikit-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msarahan/scikit-image/merges","archive_url":"https://api.github.com/repos/msarahan/scikit-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msarahan/scikit-image/downloads","issues_url":"https://api.github.com/repos/msarahan/scikit-image/issues{/number}","pulls_url":"https://api.github.com/repos/msarahan/scikit-image/pulls{/number}","milestones_url":"https://api.github.com/repos/msarahan/scikit-image/milestones{/number}","notifications_url":"https://api.github.com/repos/msarahan/scikit-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msarahan/scikit-image/labels{/name}","releases_url":"https://api.github.com/repos/msarahan/scikit-image/releases{/id}","created_at":"2014-04-26T21:07:37Z","updated_at":"2014-05-05T04:08:30Z","pushed_at":"2014-12-13T05:53:55Z","git_url":"git://github.com/msarahan/scikit-image.git","ssh_url":"git@github.com:msarahan/scikit-image.git","clone_url":"https://github.com/msarahan/scikit-image.git","svn_url":"https://github.com/msarahan/scikit-image","homepage":"http://scikit-image.org","size":36258,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-image:master","ref":"master","sha":"fc667d98d4a025936d1eb7bd252fcb5a6b83ad1e","user":{"login":"scikit-image","id":897180,"avatar_url":"https://avatars.githubusercontent.com/u/897180?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-image","html_url":"https://github.com/scikit-image","followers_url":"https://api.github.com/users/scikit-image/followers","following_url":"https://api.github.com/users/scikit-image/following{/other_user}","gists_url":"https://api.github.com/users/scikit-image/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-image/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-image/subscriptions","organizations_url":"https://api.github.com/users/scikit-image/orgs","repos_url":"https://api.github.com/users/scikit-image/repos","events_url":"https://api.github.com/users/scikit-image/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-image/received_events","type":"Organization","site_admin":false},"repo":{"id":2014929,"name":"scikit-image","full_name":"scikit-image/scikit-image","owner":{"login":"scikit-image","id":897180,"avatar_url":"https://avatars.githubusercontent.com/u/897180?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-image","html_url":"https://github.com/scikit-image","followers_url":"https://api.github.com/users/scikit-image/followers","following_url":"https://api.github.com/users/scikit-image/following{/other_user}","gists_url":"https://api.github.com/users/scikit-image/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-image/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-image/subscriptions","organizations_url":"https://api.github.com/users/scikit-image/orgs","repos_url":"https://api.github.com/users/scikit-image/repos","events_url":"https://api.github.com/users/scikit-image/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-image/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-image/scikit-image","description":"Image Processing SciKit (Toolbox for SciPy)","fork":false,"url":"https://api.github.com/repos/scikit-image/scikit-image","forks_url":"https://api.github.com/repos/scikit-image/scikit-image/forks","keys_url":"https://api.github.com/repos/scikit-image/scikit-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-image/scikit-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-image/scikit-image/teams","hooks_url":"https://api.github.com/repos/scikit-image/scikit-image/hooks","issue_events_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-image/scikit-image/events","assignees_url":"https://api.github.com/repos/scikit-image/scikit-image/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-image/scikit-image/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-image/scikit-image/tags","blobs_url":"https://api.github.com/repos/scikit-image/scikit-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-image/scikit-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-image/scikit-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-image/scikit-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-image/scikit-image/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-image/scikit-image/languages","stargazers_url":"https://api.github.com/repos/scikit-image/scikit-image/stargazers","contributors_url":"https://api.github.com/repos/scikit-image/scikit-image/contributors","subscribers_url":"https://api.github.com/repos/scikit-image/scikit-image/subscribers","subscription_url":"https://api.github.com/repos/scikit-image/scikit-image/subscription","commits_url":"https://api.github.com/repos/scikit-image/scikit-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-image/scikit-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/comments/{number}","contents_url":"https://api.github.com/repos/scikit-image/scikit-image/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-image/scikit-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-image/scikit-image/merges","archive_url":"https://api.github.com/repos/scikit-image/scikit-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-image/scikit-image/downloads","issues_url":"https://api.github.com/repos/scikit-image/scikit-image/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-image/scikit-image/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-image/scikit-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-image/scikit-image/labels{/name}","releases_url":"https://api.github.com/repos/scikit-image/scikit-image/releases{/id}","created_at":"2011-07-07T22:07:20Z","updated_at":"2014-12-14T17:49:12Z","pushed_at":"2014-12-14T17:49:12Z","git_url":"git://github.com/scikit-image/scikit-image.git","ssh_url":"git@github.com:scikit-image/scikit-image.git","clone_url":"https://github.com/scikit-image/scikit-image.git","svn_url":"https://github.com/scikit-image/scikit-image","homepage":"http://scikit-image.org","size":63723,"stargazers_count":538,"watchers_count":538,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":283,"mirror_url":null,"open_issues_count":140,"forks":283,"open_issues":140,"watchers":538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1066"},"html":{"href":"https://github.com/scikit-image/scikit-image/pull/1066"},"issue":{"href":"https://api.github.com/repos/scikit-image/scikit-image/issues/1066"},"comments":{"href":"https://api.github.com/repos/scikit-image/scikit-image/issues/1066/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1066/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1066/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-image/scikit-image/statuses/fe9efc7825e65bed19a2980add27cf18ab11e93f"}}}}