GitHub PullRequestEvent at 2014-05-07 12:45:47
Repository: concurrent-ruby
Actor: jdantonio
Payload: {"action":"closed","number":65,"pull_request":{"url":"https://api.github.com/repos/jdantonio/concurrent-ruby/pulls/65","id":15493197,"html_url":"https://github.com/jdantonio/concurrent-ruby/pull/65","diff_url":"https://github.com/jdantonio/concurrent-ruby/pull/65.diff","patch_url":"https://github.com/jdantonio/concurrent-ruby/pull/65.patch","issue_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/issues/65","number":65,"state":"closed","title":"Do not block Agent#value when updating && other improvements","user":{"login":"pitr-ch","id":204460,"avatar_url":"https://avatars.githubusercontent.com/u/204460?","gravatar_id":"1390a7fcbc3337885de95bb9b1bcecfd","url":"https://api.github.com/users/pitr-ch","html_url":"https://github.com/pitr-ch","followers_url":"https://api.github.com/users/pitr-ch/followers","following_url":"https://api.github.com/users/pitr-ch/following{/other_user}","gists_url":"https://api.github.com/users/pitr-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/pitr-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitr-ch/subscriptions","organizations_url":"https://api.github.com/users/pitr-ch/orgs","repos_url":"https://api.github.com/users/pitr-ch/repos","events_url":"https://api.github.com/users/pitr-ch/events{/privacy}","received_events_url":"https://api.github.com/users/pitr-ch/received_events","type":"User","site_admin":false},"body":"see https://github.com/jdantonio/concurrent-ruby/blob/master/lib/concurrent/agent.rb#L163\r\n\r\nI'll submit PR later. What is the schedule for 0.6 release? how much time do I have If I would like to get this fix in?\r\n\r\n- [x] do not block reading when updating\r\n- [x] does not allow to execute two updates at the same time\r\n\r\nOther:\r\n- [x] add await as in Clojure\r\n- [ ] creates another thread for each post call see https://github.com/jdantonio/concurrent-ruby/blob/master/lib/concurrent/agent.rb#L164\r\n- [ ] do not send subsequent posts on failure, clojure agent doc: _\"If any exceptions are thrown by an action function, no nested dispatches will occur, and the exception will be cached in the Agent itself.\"_\r\n- [ ] support `send` and `send-off`for blocking IO functions\r\n","created_at":"2014-05-05T14:00:37Z","updated_at":"2014-05-07T12:45:46Z","closed_at":"2014-05-07T12:45:46Z","merged_at":"2014-05-07T12:45:46Z","merge_commit_sha":"8f56cc378ca6c3ee6be762827bbee81dd1f160c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/pulls/65/commits","review_comments_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/pulls/65/comments","review_comment_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/issues/65/comments","statuses_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/statuses/026641c1d2aa13d6e2b9cbba7e83e433d703b00d","head":{"label":"pitr-ch:agent","ref":"agent","sha":"026641c1d2aa13d6e2b9cbba7e83e433d703b00d","user":{"login":"pitr-ch","id":204460,"avatar_url":"https://avatars.githubusercontent.com/u/204460?","gravatar_id":"1390a7fcbc3337885de95bb9b1bcecfd","url":"https://api.github.com/users/pitr-ch","html_url":"https://github.com/pitr-ch","followers_url":"https://api.github.com/users/pitr-ch/followers","following_url":"https://api.github.com/users/pitr-ch/following{/other_user}","gists_url":"https://api.github.com/users/pitr-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/pitr-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitr-ch/subscriptions","organizations_url":"https://api.github.com/users/pitr-ch/orgs","repos_url":"https://api.github.com/users/pitr-ch/repos","events_url":"https://api.github.com/users/pitr-ch/events{/privacy}","received_events_url":"https://api.github.com/users/pitr-ch/received_events","type":"User","site_admin":false},"repo":{"id":19456802,"name":"concurrent-ruby","full_name":"pitr-ch/concurrent-ruby","owner":{"login":"pitr-ch","id":204460,"avatar_url":"https://avatars.githubusercontent.com/u/204460?","gravatar_id":"1390a7fcbc3337885de95bb9b1bcecfd","url":"https://api.github.com/users/pitr-ch","html_url":"https://github.com/pitr-ch","followers_url":"https://api.github.com/users/pitr-ch/followers","following_url":"https://api.github.com/users/pitr-ch/following{/other_user}","gists_url":"https://api.github.com/users/pitr-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/pitr-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitr-ch/subscriptions","organizations_url":"https://api.github.com/users/pitr-ch/orgs","repos_url":"https://api.github.com/users/pitr-ch/repos","events_url":"https://api.github.com/users/pitr-ch/events{/privacy}","received_events_url":"https://api.github.com/users/pitr-ch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pitr-ch/concurrent-ruby","description":"Modern concurrency tools including agents, futures, promises, thread pools, supervisors, and more. Inspired by Erlang, Clojure, Scala, Go, Java, JavaScript, and classic concurrency patterns.","fork":true,"url":"https://api.github.com/repos/pitr-ch/concurrent-ruby","forks_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/forks","keys_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/teams","hooks_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/hooks","issue_events_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/events","assignees_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/tags","blobs_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/languages","stargazers_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/stargazers","contributors_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/contributors","subscribers_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/subscribers","subscription_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/subscription","commits_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/issues/comments/{number}","contents_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/merges","archive_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/downloads","issues_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/labels{/name}","releases_url":"https://api.github.com/repos/pitr-ch/concurrent-ruby/releases{/id}","created_at":"2014-05-05T13:34:05Z","updated_at":"2014-05-07T12:45:47Z","pushed_at":"2014-05-07T08:25:28Z","git_url":"git://github.com/pitr-ch/concurrent-ruby.git","ssh_url":"git@github.com:pitr-ch/concurrent-ruby.git","clone_url":"https://github.com/pitr-ch/concurrent-ruby.git","svn_url":"https://github.com/pitr-ch/concurrent-ruby","homepage":"http://www.concurrent-ruby.com","size":13198,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jdantonio:master","ref":"master","sha":"b6d7506299624b598603e2769285d25ac957814d","user":{"login":"jdantonio","id":173910,"avatar_url":"https://avatars.githubusercontent.com/u/173910?","gravatar_id":"afc40875bec6a95232a5d779336bc695","url":"https://api.github.com/users/jdantonio","html_url":"https://github.com/jdantonio","followers_url":"https://api.github.com/users/jdantonio/followers","following_url":"https://api.github.com/users/jdantonio/following{/other_user}","gists_url":"https://api.github.com/users/jdantonio/gists{/gist_id}","starred_url":"https://api.github.com/users/jdantonio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdantonio/subscriptions","organizations_url":"https://api.github.com/users/jdantonio/orgs","repos_url":"https://api.github.com/users/jdantonio/repos","events_url":"https://api.github.com/users/jdantonio/events{/privacy}","received_events_url":"https://api.github.com/users/jdantonio/received_events","type":"User","site_admin":false},"repo":{"id":11607598,"name":"concurrent-ruby","full_name":"jdantonio/concurrent-ruby","owner":{"login":"jdantonio","id":173910,"avatar_url":"https://avatars.githubusercontent.com/u/173910?","gravatar_id":"afc40875bec6a95232a5d779336bc695","url":"https://api.github.com/users/jdantonio","html_url":"https://github.com/jdantonio","followers_url":"https://api.github.com/users/jdantonio/followers","following_url":"https://api.github.com/users/jdantonio/following{/other_user}","gists_url":"https://api.github.com/users/jdantonio/gists{/gist_id}","starred_url":"https://api.github.com/users/jdantonio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdantonio/subscriptions","organizations_url":"https://api.github.com/users/jdantonio/orgs","repos_url":"https://api.github.com/users/jdantonio/repos","events_url":"https://api.github.com/users/jdantonio/events{/privacy}","received_events_url":"https://api.github.com/users/jdantonio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdantonio/concurrent-ruby","description":"Modern concurrency tools including agents, futures, promises, thread pools, supervisors, and more. Inspired by Erlang, Clojure, Scala, Go, Java, JavaScript, and classic concurrency patterns.","fork":false,"url":"https://api.github.com/repos/jdantonio/concurrent-ruby","forks_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/forks","keys_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/teams","hooks_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/hooks","issue_events_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/events","assignees_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/tags","blobs_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/languages","stargazers_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/stargazers","contributors_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/contributors","subscribers_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/subscribers","subscription_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/subscription","commits_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/issues/comments/{number}","contents_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/merges","archive_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/downloads","issues_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/labels{/name}","releases_url":"https://api.github.com/repos/jdantonio/concurrent-ruby/releases{/id}","created_at":"2013-07-23T12:19:51Z","updated_at":"2014-05-07T12:45:46Z","pushed_at":"2014-05-07T12:45:46Z","git_url":"git://github.com/jdantonio/concurrent-ruby.git","ssh_url":"git@github.com:jdantonio/concurrent-ruby.git","clone_url":"https://github.com/jdantonio/concurrent-ruby.git","svn_url":"https://github.com/jdantonio/concurrent-ruby","homepage":"http://www.concurrent-ruby.com","size":13198,"stargazers_count":550,"watchers_count":550,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":25,"mirror_url":null,"open_issues_count":3,"forks":25,"open_issues":3,"watchers":550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jdantonio/concurrent-ruby/pulls/65"},"html":{"href":"https://github.com/jdantonio/concurrent-ruby/pull/65"},"issue":{"href":"https://api.github.com/repos/jdantonio/concurrent-ruby/issues/65"},"comments":{"href":"https://api.github.com/repos/jdantonio/concurrent-ruby/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/jdantonio/concurrent-ruby/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/jdantonio/concurrent-ruby/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jdantonio/concurrent-ruby/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/jdantonio/concurrent-ruby/statuses/026641c1d2aa13d6e2b9cbba7e83e433d703b00d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jdantonio","id":173910,"avatar_url":"https://avatars.githubusercontent.com/u/173910?","gravatar_id":"afc40875bec6a95232a5d779336bc695","url":"https://api.github.com/users/jdantonio","html_url":"https://github.com/jdantonio","followers_url":"https://api.github.com/users/jdantonio/followers","following_url":"https://api.github.com/users/jdantonio/following{/other_user}","gists_url":"https://api.github.com/users/jdantonio/gists{/gist_id}","starred_url":"https://api.github.com/users/jdantonio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdantonio/subscriptions","organizations_url":"https://api.github.com/users/jdantonio/orgs","repos_url":"https://api.github.com/users/jdantonio/repos","events_url":"https://api.github.com/users/jdantonio/events{/privacy}","received_events_url":"https://api.github.com/users/jdantonio/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":5,"additions":254,"deletions":89,"changed_files":4}}