GitHub PullRequestEvent at 2014-05-25 14:33:02
Repository: ngInfiniteScroll
Actor: reyramos
Payload: {"action":"opened","number":88,"pull_request":{"url":"https://api.github.com/repos/sroze/ngInfiniteScroll/pulls/88","id":16314623,"html_url":"https://github.com/sroze/ngInfiniteScroll/pull/88","diff_url":"https://github.com/sroze/ngInfiniteScroll/pull/88.diff","patch_url":"https://github.com/sroze/ngInfiniteScroll/pull/88.patch","issue_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/issues/88","number":88,"state":"open","title":"Update ng-infinite-scroll.js","user":{"login":"reyramos","id":278664,"avatar_url":"https://avatars.githubusercontent.com/u/278664?","gravatar_id":"70cc00cde3fbec978d5b2642cd3ae818","url":"https://api.github.com/users/reyramos","html_url":"https://github.com/reyramos","followers_url":"https://api.github.com/users/reyramos/followers","following_url":"https://api.github.com/users/reyramos/following{/other_user}","gists_url":"https://api.github.com/users/reyramos/gists{/gist_id}","starred_url":"https://api.github.com/users/reyramos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reyramos/subscriptions","organizations_url":"https://api.github.com/users/reyramos/orgs","repos_url":"https://api.github.com/users/reyramos/repos","events_url":"https://api.github.com/users/reyramos/events{/privacy}","received_events_url":"https://api.github.com/users/reyramos/received_events","type":"User","site_admin":false},"body":"Change $window and elem, into JQuery elements because within the handler() function you are referencing them with JQuery functions. AngularJs Elements does not have heigth(), offset().top functionality.\r\n\r\nIf they are not reference, you will get a TypeOffError undefined for the following.","created_at":"2014-05-25T14:33:02Z","updated_at":"2014-05-25T14:33:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/pulls/88/commits","review_comments_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/pulls/88/comments","review_comment_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/issues/88/comments","statuses_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/statuses/99fbe8a7d4a2d350efc1c2cab05e8b696df472f5","head":{"label":"reyramos:patch-1","ref":"patch-1","sha":"99fbe8a7d4a2d350efc1c2cab05e8b696df472f5","user":{"login":"reyramos","id":278664,"avatar_url":"https://avatars.githubusercontent.com/u/278664?","gravatar_id":"70cc00cde3fbec978d5b2642cd3ae818","url":"https://api.github.com/users/reyramos","html_url":"https://github.com/reyramos","followers_url":"https://api.github.com/users/reyramos/followers","following_url":"https://api.github.com/users/reyramos/following{/other_user}","gists_url":"https://api.github.com/users/reyramos/gists{/gist_id}","starred_url":"https://api.github.com/users/reyramos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reyramos/subscriptions","organizations_url":"https://api.github.com/users/reyramos/orgs","repos_url":"https://api.github.com/users/reyramos/repos","events_url":"https://api.github.com/users/reyramos/events{/privacy}","received_events_url":"https://api.github.com/users/reyramos/received_events","type":"User","site_admin":false},"repo":{"id":20156415,"name":"ngInfiniteScroll","full_name":"reyramos/ngInfiniteScroll","owner":{"login":"reyramos","id":278664,"avatar_url":"https://avatars.githubusercontent.com/u/278664?","gravatar_id":"70cc00cde3fbec978d5b2642cd3ae818","url":"https://api.github.com/users/reyramos","html_url":"https://github.com/reyramos","followers_url":"https://api.github.com/users/reyramos/followers","following_url":"https://api.github.com/users/reyramos/following{/other_user}","gists_url":"https://api.github.com/users/reyramos/gists{/gist_id}","starred_url":"https://api.github.com/users/reyramos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reyramos/subscriptions","organizations_url":"https://api.github.com/users/reyramos/orgs","repos_url":"https://api.github.com/users/reyramos/repos","events_url":"https://api.github.com/users/reyramos/events{/privacy}","received_events_url":"https://api.github.com/users/reyramos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reyramos/ngInfiniteScroll","description":"Infinite Scrolling for AngularJS","fork":true,"url":"https://api.github.com/repos/reyramos/ngInfiniteScroll","forks_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/forks","keys_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/teams","hooks_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/hooks","issue_events_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/issues/events{/number}","events_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/events","assignees_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/assignees{/user}","branches_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/branches{/branch}","tags_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/tags","blobs_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/git/refs{/sha}","trees_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/statuses/{sha}","languages_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/languages","stargazers_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/stargazers","contributors_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/contributors","subscribers_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/subscribers","subscription_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/subscription","commits_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/commits{/sha}","git_commits_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/git/commits{/sha}","comments_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/comments{/number}","issue_comment_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/issues/comments/{number}","contents_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/contents/{+path}","compare_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/merges","archive_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/downloads","issues_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/issues{/number}","pulls_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/pulls{/number}","milestones_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/milestones{/number}","notifications_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/labels{/name}","releases_url":"https://api.github.com/repos/reyramos/ngInfiniteScroll/releases{/id}","created_at":"2014-05-25T14:27:33Z","updated_at":"2014-05-25T14:33:02Z","pushed_at":"2014-05-25T14:32:47Z","git_url":"git://github.com/reyramos/ngInfiniteScroll.git","ssh_url":"git@github.com:reyramos/ngInfiniteScroll.git","clone_url":"https://github.com/reyramos/ngInfiniteScroll.git","svn_url":"https://github.com/reyramos/ngInfiniteScroll","homepage":"http://sroze.github.com/ngInfiniteScroll/","size":1602,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sroze:master","ref":"master","sha":"5ee6c882fd6a4d1cf2bae54e2f4fdaec19769697","user":{"login":"sroze","id":804625,"avatar_url":"https://avatars.githubusercontent.com/u/804625?","gravatar_id":"3397cc9d55eb953351c84ed40e9425a7","url":"https://api.github.com/users/sroze","html_url":"https://github.com/sroze","followers_url":"https://api.github.com/users/sroze/followers","following_url":"https://api.github.com/users/sroze/following{/other_user}","gists_url":"https://api.github.com/users/sroze/gists{/gist_id}","starred_url":"https://api.github.com/users/sroze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sroze/subscriptions","organizations_url":"https://api.github.com/users/sroze/orgs","repos_url":"https://api.github.com/users/sroze/repos","events_url":"https://api.github.com/users/sroze/events{/privacy}","received_events_url":"https://api.github.com/users/sroze/received_events","type":"User","site_admin":false},"repo":{"id":7076763,"name":"ngInfiniteScroll","full_name":"sroze/ngInfiniteScroll","owner":{"login":"sroze","id":804625,"avatar_url":"https://avatars.githubusercontent.com/u/804625?","gravatar_id":"3397cc9d55eb953351c84ed40e9425a7","url":"https://api.github.com/users/sroze","html_url":"https://github.com/sroze","followers_url":"https://api.github.com/users/sroze/followers","following_url":"https://api.github.com/users/sroze/following{/other_user}","gists_url":"https://api.github.com/users/sroze/gists{/gist_id}","starred_url":"https://api.github.com/users/sroze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sroze/subscriptions","organizations_url":"https://api.github.com/users/sroze/orgs","repos_url":"https://api.github.com/users/sroze/repos","events_url":"https://api.github.com/users/sroze/events{/privacy}","received_events_url":"https://api.github.com/users/sroze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sroze/ngInfiniteScroll","description":"Infinite Scrolling for AngularJS","fork":false,"url":"https://api.github.com/repos/sroze/ngInfiniteScroll","forks_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/forks","keys_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/teams","hooks_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/hooks","issue_events_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/issues/events{/number}","events_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/events","assignees_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/assignees{/user}","branches_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/branches{/branch}","tags_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/tags","blobs_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/git/refs{/sha}","trees_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/statuses/{sha}","languages_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/languages","stargazers_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/stargazers","contributors_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/contributors","subscribers_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/subscribers","subscription_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/subscription","commits_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/commits{/sha}","git_commits_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/git/commits{/sha}","comments_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/comments{/number}","issue_comment_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/issues/comments/{number}","contents_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/contents/{+path}","compare_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/merges","archive_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/downloads","issues_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/issues{/number}","pulls_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/pulls{/number}","milestones_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/milestones{/number}","notifications_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/labels{/name}","releases_url":"https://api.github.com/repos/sroze/ngInfiniteScroll/releases{/id}","created_at":"2012-12-09T07:55:44Z","updated_at":"2014-05-25T06:22:07Z","pushed_at":"2014-05-22T16:23:27Z","git_url":"git://github.com/sroze/ngInfiniteScroll.git","ssh_url":"git@github.com:sroze/ngInfiniteScroll.git","clone_url":"https://github.com/sroze/ngInfiniteScroll.git","svn_url":"https://github.com/sroze/ngInfiniteScroll","homepage":"http://sroze.github.com/ngInfiniteScroll/","size":1602,"stargazers_count":966,"watchers_count":966,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":209,"mirror_url":null,"open_issues_count":7,"forks":209,"open_issues":7,"watchers":966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sroze/ngInfiniteScroll/pulls/88"},"html":{"href":"https://github.com/sroze/ngInfiniteScroll/pull/88"},"issue":{"href":"https://api.github.com/repos/sroze/ngInfiniteScroll/issues/88"},"comments":{"href":"https://api.github.com/repos/sroze/ngInfiniteScroll/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/sroze/ngInfiniteScroll/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/sroze/ngInfiniteScroll/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sroze/ngInfiniteScroll/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/sroze/ngInfiniteScroll/statuses/99fbe8a7d4a2d350efc1c2cab05e8b696df472f5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":1}}