GitHub PullRequestReviewCommentEvent at 2014-03-27 22:26:31
Repository: assembler
Actor: kerinin
Payload: {"comment":{"url":"https://api.github.com/repos/benhamill/assembler/pulls/comments/11048090","id":11048090,"diff_hunk":"@@ -0,0 +1,73 @@\n+module Assembler\n+  class Parameter\n+    attr_reader :name\n+\n+    def initialize(name, options = {})\n+      @name         = name.to_sym\n+      @options      = options\n+    end\n+\n+    def name_and_aliases\n+      @name_and_aliases ||= [name] + aliases.map(&:to_sym)\n+    end\n+\n+    def value_from(options, &if_required_and_missing)\n+      @memoized_value_from ||= {}\n+      memoization_key = [options, if_required_and_missing]","path":"lib/assembler/parameter.rb","position":16,"original_position":16,"commit_id":"a3cba1bdfa9f966d8225b7edee904eb88b1ec76c","original_commit_id":"a3cba1bdfa9f966d8225b7edee904eb88b1ec76c","user":{"login":"kerinin","id":161938,"avatar_url":"https://avatars.githubusercontent.com/u/161938?","gravatar_id":"011ea216e784b9b22380e1e60e62caaf","url":"https://api.github.com/users/kerinin","html_url":"https://github.com/kerinin","followers_url":"https://api.github.com/users/kerinin/followers","following_url":"https://api.github.com/users/kerinin/following{/other_user}","gists_url":"https://api.github.com/users/kerinin/gists{/gist_id}","starred_url":"https://api.github.com/users/kerinin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerinin/subscriptions","organizations_url":"https://api.github.com/users/kerinin/orgs","repos_url":"https://api.github.com/users/kerinin/repos","events_url":"https://api.github.com/users/kerinin/events{/privacy}","received_events_url":"https://api.github.com/users/kerinin/received_events","type":"User","site_admin":false},"body":"They are in clojure ;). Idk\n\nOn Thursday, March 27, 2014, Ben Hamill <notifications@github.com> wrote:\n\n> In lib/assembler/parameter.rb:\n>\n> > +module Assembler\n> > +  class Parameter\n> > +    attr_reader :name\n> > +\n> > +    def initialize(name, options = {})\n> > +      @name         = name.to_sym\n> > +      @options      = options\n> > +    end\n> > +\n> > +    def name_and_aliases\n> > +      @name_and_aliases ||= [name] + aliases.map(&:to_sym)\n> > +    end\n> > +\n> > +    def value_from(options, &if_required_and_missing)\n> > +      @memoized_value_from ||= {}\n> > +      memoization_key = [options, if_required_and_missing]\n>\n> I mean--Are two semantically identical blocks the same after hashing?\n>\n> --\n> Reply to this email directly or view it on GitHub<https://github.com/benhamill/assembler/pull/13/files#r11048046>\n> .\n>","created_at":"2014-03-27T22:26:31Z","updated_at":"2014-03-27T22:26:31Z","html_url":"https://github.com/benhamill/assembler/pull/13#discussion_r11048090","pull_request_url":"https://api.github.com/repos/benhamill/assembler/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/benhamill/assembler/pulls/comments/11048090"},"html":{"href":"https://github.com/benhamill/assembler/pull/13#discussion_r11048090"},"pull_request":{"href":"https://api.github.com/repos/benhamill/assembler/pulls/13"}}}}