GitHub PullRequestReviewCommentEvent at 2014-11-19 13:03:38
Repository: KogoAdmin
Actor: HedonSoftware
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls/comments/20573095","id":20573095,"diff_hunk":"@@ -56,7 +56,7 @@ passport.use(new LocalStrategy(\n           return done(null, false, { message: 'Insufficient privileges' });\n         }\n \n-        var secret = 'opk23423asd!!$%^&*$#@';\n+        var secret = '12446533!!$%^&*$#@';","path":"lib/authentication/passport.js","position":5,"original_position":5,"commit_id":"8924037ca1ad28061c67ccb3f3988f9ccabf90f6","original_commit_id":"8924037ca1ad28061c67ccb3f3988f9ccabf90f6","user":{"login":"HedonSoftware","id":8095504,"avatar_url":"https://avatars.githubusercontent.com/u/8095504?v=3","gravatar_id":"","url":"https://api.github.com/users/HedonSoftware","html_url":"https://github.com/HedonSoftware","followers_url":"https://api.github.com/users/HedonSoftware/followers","following_url":"https://api.github.com/users/HedonSoftware/following{/other_user}","gists_url":"https://api.github.com/users/HedonSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/HedonSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HedonSoftware/subscriptions","organizations_url":"https://api.github.com/users/HedonSoftware/orgs","repos_url":"https://api.github.com/users/HedonSoftware/repos","events_url":"https://api.github.com/users/HedonSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/HedonSoftware/received_events","type":"User","site_admin":false},"body":"This was done for purpose - it's a security measurement that even if you have access to database you cannot compare passwords and figure out somebody's password. All the users in both systems have default password of 'abc'.\r\n\r\nPS. We will add that point to README.md","created_at":"2014-11-19T13:03:38Z","updated_at":"2014-11-19T13:03:38Z","html_url":"https://github.com/HedonSoftware/KogoAdmin/pull/2#discussion_r20573095","pull_request_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls/comments/20573095"},"html":{"href":"https://github.com/HedonSoftware/KogoAdmin/pull/2#discussion_r20573095"},"pull_request":{"href":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls/2","id":24659680,"html_url":"https://github.com/HedonSoftware/KogoAdmin/pull/2","diff_url":"https://github.com/HedonSoftware/KogoAdmin/pull/2.diff","patch_url":"https://github.com/HedonSoftware/KogoAdmin/pull/2.patch","issue_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/issues/2","number":2,"state":"open","locked":false,"title":"Develop","user":{"login":"nojhamster","id":3006025,"avatar_url":"https://avatars.githubusercontent.com/u/3006025?v=3","gravatar_id":"","url":"https://api.github.com/users/nojhamster","html_url":"https://github.com/nojhamster","followers_url":"https://api.github.com/users/nojhamster/followers","following_url":"https://api.github.com/users/nojhamster/following{/other_user}","gists_url":"https://api.github.com/users/nojhamster/gists{/gist_id}","starred_url":"https://api.github.com/users/nojhamster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojhamster/subscriptions","organizations_url":"https://api.github.com/users/nojhamster/orgs","repos_url":"https://api.github.com/users/nojhamster/repos","events_url":"https://api.github.com/users/nojhamster/events{/privacy}","received_events_url":"https://api.github.com/users/nojhamster/received_events","type":"User","site_admin":false},"body":"Played a bit in the users section and fixed some bugs :)\r\n* Angular crashing when saving a user due to an undefined variable (tempUser)\r\n* Avatars failing to be moved due to ENOENT caused by a duplicated '/' in path (a good practice would be to always use the **path** module to join/resolve/normalize paths)\r\n* The admin cannot log in both Kogo and KogoAdmin due to different salts for password encryption\r\n* Angular starting a bootstrap loop on logout due to empty templateUrl in the route options (i replaced templateUrl by template)","created_at":"2014-11-19T01:29:28Z","updated_at":"2014-11-19T13:03:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75a5e6000c40721378d590a690782e341109c6ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls/2/commits","review_comments_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls/2/comments","review_comment_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/issues/2/comments","statuses_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/statuses/8924037ca1ad28061c67ccb3f3988f9ccabf90f6","head":{"label":"nojhamster:develop","ref":"develop","sha":"8924037ca1ad28061c67ccb3f3988f9ccabf90f6","user":{"login":"nojhamster","id":3006025,"avatar_url":"https://avatars.githubusercontent.com/u/3006025?v=3","gravatar_id":"","url":"https://api.github.com/users/nojhamster","html_url":"https://github.com/nojhamster","followers_url":"https://api.github.com/users/nojhamster/followers","following_url":"https://api.github.com/users/nojhamster/following{/other_user}","gists_url":"https://api.github.com/users/nojhamster/gists{/gist_id}","starred_url":"https://api.github.com/users/nojhamster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojhamster/subscriptions","organizations_url":"https://api.github.com/users/nojhamster/orgs","repos_url":"https://api.github.com/users/nojhamster/repos","events_url":"https://api.github.com/users/nojhamster/events{/privacy}","received_events_url":"https://api.github.com/users/nojhamster/received_events","type":"User","site_admin":false},"repo":{"id":26836909,"name":"KogoAdmin","full_name":"nojhamster/KogoAdmin","owner":{"login":"nojhamster","id":3006025,"avatar_url":"https://avatars.githubusercontent.com/u/3006025?v=3","gravatar_id":"","url":"https://api.github.com/users/nojhamster","html_url":"https://github.com/nojhamster","followers_url":"https://api.github.com/users/nojhamster/followers","following_url":"https://api.github.com/users/nojhamster/following{/other_user}","gists_url":"https://api.github.com/users/nojhamster/gists{/gist_id}","starred_url":"https://api.github.com/users/nojhamster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojhamster/subscriptions","organizations_url":"https://api.github.com/users/nojhamster/orgs","repos_url":"https://api.github.com/users/nojhamster/repos","events_url":"https://api.github.com/users/nojhamster/events{/privacy}","received_events_url":"https://api.github.com/users/nojhamster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nojhamster/KogoAdmin","description":"Admin Dashboard for Kogo Agile Project Management Tool","fork":true,"url":"https://api.github.com/repos/nojhamster/KogoAdmin","forks_url":"https://api.github.com/repos/nojhamster/KogoAdmin/forks","keys_url":"https://api.github.com/repos/nojhamster/KogoAdmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nojhamster/KogoAdmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nojhamster/KogoAdmin/teams","hooks_url":"https://api.github.com/repos/nojhamster/KogoAdmin/hooks","issue_events_url":"https://api.github.com/repos/nojhamster/KogoAdmin/issues/events{/number}","events_url":"https://api.github.com/repos/nojhamster/KogoAdmin/events","assignees_url":"https://api.github.com/repos/nojhamster/KogoAdmin/assignees{/user}","branches_url":"https://api.github.com/repos/nojhamster/KogoAdmin/branches{/branch}","tags_url":"https://api.github.com/repos/nojhamster/KogoAdmin/tags","blobs_url":"https://api.github.com/repos/nojhamster/KogoAdmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nojhamster/KogoAdmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nojhamster/KogoAdmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/nojhamster/KogoAdmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nojhamster/KogoAdmin/statuses/{sha}","languages_url":"https://api.github.com/repos/nojhamster/KogoAdmin/languages","stargazers_url":"https://api.github.com/repos/nojhamster/KogoAdmin/stargazers","contributors_url":"https://api.github.com/repos/nojhamster/KogoAdmin/contributors","subscribers_url":"https://api.github.com/repos/nojhamster/KogoAdmin/subscribers","subscription_url":"https://api.github.com/repos/nojhamster/KogoAdmin/subscription","commits_url":"https://api.github.com/repos/nojhamster/KogoAdmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/nojhamster/KogoAdmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/nojhamster/KogoAdmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/nojhamster/KogoAdmin/issues/comments/{number}","contents_url":"https://api.github.com/repos/nojhamster/KogoAdmin/contents/{+path}","compare_url":"https://api.github.com/repos/nojhamster/KogoAdmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nojhamster/KogoAdmin/merges","archive_url":"https://api.github.com/repos/nojhamster/KogoAdmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nojhamster/KogoAdmin/downloads","issues_url":"https://api.github.com/repos/nojhamster/KogoAdmin/issues{/number}","pulls_url":"https://api.github.com/repos/nojhamster/KogoAdmin/pulls{/number}","milestones_url":"https://api.github.com/repos/nojhamster/KogoAdmin/milestones{/number}","notifications_url":"https://api.github.com/repos/nojhamster/KogoAdmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nojhamster/KogoAdmin/labels{/name}","releases_url":"https://api.github.com/repos/nojhamster/KogoAdmin/releases{/id}","created_at":"2014-11-19T00:31:24Z","updated_at":"2014-11-19T00:31:26Z","pushed_at":"2014-11-19T03:07:15Z","git_url":"git://github.com/nojhamster/KogoAdmin.git","ssh_url":"git@github.com:nojhamster/KogoAdmin.git","clone_url":"https://github.com/nojhamster/KogoAdmin.git","svn_url":"https://github.com/nojhamster/KogoAdmin","homepage":"","size":4584,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HedonSoftware:develop","ref":"develop","sha":"d70a0f6d64316050191f2bc6affc0f887e0beb3c","user":{"login":"HedonSoftware","id":8095504,"avatar_url":"https://avatars.githubusercontent.com/u/8095504?v=3","gravatar_id":"","url":"https://api.github.com/users/HedonSoftware","html_url":"https://github.com/HedonSoftware","followers_url":"https://api.github.com/users/HedonSoftware/followers","following_url":"https://api.github.com/users/HedonSoftware/following{/other_user}","gists_url":"https://api.github.com/users/HedonSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/HedonSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HedonSoftware/subscriptions","organizations_url":"https://api.github.com/users/HedonSoftware/orgs","repos_url":"https://api.github.com/users/HedonSoftware/repos","events_url":"https://api.github.com/users/HedonSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/HedonSoftware/received_events","type":"User","site_admin":false},"repo":{"id":23935361,"name":"KogoAdmin","full_name":"HedonSoftware/KogoAdmin","owner":{"login":"HedonSoftware","id":8095504,"avatar_url":"https://avatars.githubusercontent.com/u/8095504?v=3","gravatar_id":"","url":"https://api.github.com/users/HedonSoftware","html_url":"https://github.com/HedonSoftware","followers_url":"https://api.github.com/users/HedonSoftware/followers","following_url":"https://api.github.com/users/HedonSoftware/following{/other_user}","gists_url":"https://api.github.com/users/HedonSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/HedonSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HedonSoftware/subscriptions","organizations_url":"https://api.github.com/users/HedonSoftware/orgs","repos_url":"https://api.github.com/users/HedonSoftware/repos","events_url":"https://api.github.com/users/HedonSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/HedonSoftware/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HedonSoftware/KogoAdmin","description":"Admin Dashboard for Kogo Agile Project Management Tool","fork":false,"url":"https://api.github.com/repos/HedonSoftware/KogoAdmin","forks_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/forks","keys_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/teams","hooks_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/hooks","issue_events_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/issues/events{/number}","events_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/events","assignees_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/assignees{/user}","branches_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/branches{/branch}","tags_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/tags","blobs_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/statuses/{sha}","languages_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/languages","stargazers_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/stargazers","contributors_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/contributors","subscribers_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/subscribers","subscription_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/subscription","commits_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/issues/comments/{number}","contents_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/contents/{+path}","compare_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/merges","archive_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/downloads","issues_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/issues{/number}","pulls_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls{/number}","milestones_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/milestones{/number}","notifications_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/labels{/name}","releases_url":"https://api.github.com/repos/HedonSoftware/KogoAdmin/releases{/id}","created_at":"2014-09-11T20:54:21Z","updated_at":"2014-11-16T23:39:30Z","pushed_at":"2014-11-19T00:32:41Z","git_url":"git://github.com/HedonSoftware/KogoAdmin.git","ssh_url":"git@github.com:HedonSoftware/KogoAdmin.git","clone_url":"https://github.com/HedonSoftware/KogoAdmin.git","svn_url":"https://github.com/HedonSoftware/KogoAdmin","homepage":"","size":4584,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls/2"},"html":{"href":"https://github.com/HedonSoftware/KogoAdmin/pull/2"},"issue":{"href":"https://api.github.com/repos/HedonSoftware/KogoAdmin/issues/2"},"comments":{"href":"https://api.github.com/repos/HedonSoftware/KogoAdmin/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/HedonSoftware/KogoAdmin/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/HedonSoftware/KogoAdmin/statuses/8924037ca1ad28061c67ccb3f3988f9ccabf90f6"}}}}