GitHub PullRequestReviewCommentEvent at 2014-04-09 15:39:09
Repository: fxa-content-server
Actor: shane-tomlinson
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/11441847","id":11441847,"diff_hunk":"@@ -75,10 +107,34 @@ function (_, p, BaseView, FormView, SignInTemplate, Constants, Session, Password\n       return this.fxaClient.signIn(email, password)\n         .then(function (accountData) {\n           if (accountData.verified) {\n+            // If this is oauth then create an assertion and pass it along to the oauth server\n+            if (self.isOAuth) {\n+              assertion(Session.config.oauthUrl).then(function(ass) {\n+                /* jshint camelcase: false */\n+                self.oAuthClient.getCode({","path":"app/scripts/views/sign_in.js","position":68,"original_position":68,"commit_id":"2d2c5ff4447bc6c185f823a654a26f4ed79d3397","original_commit_id":"2d2c5ff4447bc6c185f823a654a26f4ed79d3397","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?","gravatar_id":"b7581393f6d1960ea7721789cbbe5c36","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"body":"Should there be a `return` in front of this?","created_at":"2014-04-09T15:39:09Z","updated_at":"2014-04-09T15:39:09Z","html_url":"https://github.com/mozilla/fxa-content-server/pull/888#discussion_r11441847","pull_request_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/888","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/11441847"},"html":{"href":"https://github.com/mozilla/fxa-content-server/pull/888#discussion_r11441847"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/888"}}}}