GitHub PushEvent at 2014-11-07 09:48:34
Repository: core
Actor: nthiebaud
Payload: {"shas":[["6419c745e5e9802da264250d5e131fb9a3b6e4de","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Do not check a reference\n\nChange-Id: I5baac12f97ea7fa36293844331ca548b7bc2cdfd","Zolnai Tamás",true],["fe272a757b60fdf267539102b0a9927f68e1526a","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Always call ImplAfterDataChange() when data is changed\n\nCall it inside ImplAssignGraphicData() which assign\nGraphicObject members using Graphic's data. With that\nImplAfterDataChange() method also called in constructors.\n\nIt's important to call ImplAfterDataChange(), because this\nwill trigger the auto swaping mechanism.\n\nChange-Id: I45af91f8df2fb5b0143fcc5eb05e82e4d408d0bc","Zolnai Tamás",true],["29413c3ae9dfe99048580710f0b1d95c9663d508","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Avoid using null pointer as a special indicator\n\nWhen ImpGraphic::ImplSwapOut() is called with null\npointer it was assumed that it is becase the graphic is\na link and so we don't need to swap out it actually (we can\nload it anytime using the link), only clear the graphic's\ninternal data.\n\nThe problem with that it can happen that ImplSwapOut()\nis called with null pointer accidentally on a non-link\ngraphic object which leads to that we loose the graphic.\nSeems more robust to use an explicit indicator\n(GRFMGR_AUTOSWAPSTREAM_LINK) for links swapout.\nindicator\n\nChange-Id: Icf31524a192c7866278ba6a13eb85648aa69f554","Zolnai Tamás",true],["b2503f187341f9a37737f34c7fc6a02d03c2e84e","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Remove manual SwapOut() call in ODF export\n\nWe have a good auto swapout mechanism which will\nprevent excessive memory use.\n\nChange-Id: I362f51c724ac31704561abe8b961910f5d490f04","Zolnai Tamás",true],["f05615df9410cadacfef6843f9c7b6966840d963","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","MS export: don't need to manually swapout images after swapin them\n\nWe have some good auto mechanisms for that.\n\nChange-Id: I487dbf4a5fc69c7563dfbc5c21f9ebdb05ba6b9e","Zolnai Tamás",true],["da612badf7897ab41aa99437e5df874934596fd9","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","DOC import: avoid manual swapout call.\n\nNo reason to swapout the image directly after the import\nbecause it will be used for rendering just a second later.\n\nChange-Id: I78c8ef9225c55f306182dc5efd7bcaf0e88521c0","Zolnai Tamás",true],["17475638138c92162be1c0f34cf1f9cc95c63579","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Make SetSwapState() an internal method\n\nSo we can be sure it is always called when user data changed.\n\nChange-Id: If107907afffb85a7a57817f5807847a5c028416c","Zolnai Tamás",true],["6e0761ec54c12f1d8fd4391e9e87f805d39cce30","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Test for swapped out image loss during Impress export\n\nRelated to the bug fdo#52226.\nThe problem was that the images were somehow swapped out but\nwere not swapped in during export.\nTest the main Impress formats: ODP, PPT, PPTX\n\nChange-Id: I97ba98d0eb05ef2c1de3fbeaa527bc9f6f54d742","Zolnai Tamás",true],["8070b12454718d33d4452bb090f40ce8c629ca2c","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Test for swapped out image loss during Writer export\n\nRelated to the bug fdo#52226. The fix in *.rtf and *.docx\nexport was this commit:\n9dd5caac62083f7162d83319284df68ee83e3777\nThe problem was that the images were somehow swapped out but\nwere not swapped in during export.\nTest the main Writer formats: ODT, RTF, DOC, DOCX.","Zolnai Tamás",true],["a6d96c808d76ff0b45466902150929e339d19406","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Test for swapped out image loss during Calc export\n\nRelated to the bug fdo#52226.\nThe problem was that the images were somehow swapped out but\nwere not swapped in during export.\nTest the main Calc formats: ODS, XLS, XLSX, HTML.\n\nConflicts:\n\tsc/qa/unit/subsequent_export-test.cxx\n\nChange-Id: I4835ff2960fbd11cc9750ed3da20df26cd6cbaba","Zolnai Tamás",true],["ccdf558157b7e1b31d8bfd7cce45468f5013fb6d","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Swap in graphic by SwGrfNode and not manually\n\nIt's a Writer specific problem, that images lost during export\nbecause of not swapped in graphic data.\nOther components (Impress, Calc...) use SdrGrafObj to get the\ngraphic and SdrGrafObj calls swap in before retrun with the\ngraphic.\n\nChange-Id: I7398d8e3f6535199b10de048acd58543bdb42531","Zolnai Tamás",true],["5c2ec558ac5bbe76a0070cee90c3ff9ce0544a87","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Avoid an image loss situation of auto swapping\n\nBefore an image data is used GraphicObject should be swapped in.\nWhen a GraphicObject is swapped in auto swapping mechanism\nis triggered which can swap out some of the images.\nWe should avoid to swap out the same image on which the swap\nin method was called before because the caller code assumes that\nthe image data is there.\n\nChange-Id: Ia4addc370742aea5fbf185cf87e3c062a5ebf5be","Zolnai Tamás",true],["ccd93fc33843b1349b67797fc5a26713e6b186e6","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Assign graphic data also during auto swap in\n\nChange-Id: I09b8d11027f4a1e8470b81677388d4a573b372a6","Zolnai Tamás",true],["70dff8d4bb97a5b9b59f91f3cc168be84b473873","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Ignore the swapped in graphic, but use its size\n\nChange-Id: I75f17ab5e55119965fcede2b220979cefc1e26ab","Zolnai Tamás",true],["d4653a95896698f7dbaaeae253c5c06d78a4fe32","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Remove these useless static bool variables.\n\nChange-Id: I7a8ad7814231f129d5d1146ceb36eb2c22b2aff1","Zolnai Tamás",true],["2cfce42e0b2b68f045431e572b521fbe5a9f90ab","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","More useless static bool variables.\n\nChange-Id: If09aa23768f73bbf659966e4e5aac82dca83d1b6","Zolnai Tamás",true],["2b8352eb44310fca3802a843e2c2674256b3e08c","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Paint background images always via drawinglayer\n\nPainting via GraphicObject is obsolete.\nSee fdo#68927 where the problem was the quality of svg\ngraphics, it seems a good idea to extend this improvement\nto all graphic type.\n\nChange-Id: I57a26d4fcfea8e4f666504a90281365e8a9a7e1d","Zolnai Tamás",true],["4415af54b4f7d2ce4d3b10f789801adc082d5afa","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Remove unused IsInSwap() method\n\nChange-Id: Ib295bd71b5cf16fd75d04818dfd415ff24cb2655","Zolnai Tamás",true],["6598a61ff42d9754949dde7ffeaff476183e06bd","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","Printing: remove an other manual swap out call\n\nChange-Id: I2b6d6eaa072d9948eb5734e978d68d3bc37701b2","Zolnai Tamás",true],["cf78f9c05aaef427c3907ebb7a2ce7247ed27273","5c8f48ae53ae43524920a2f57cae0cecb1544f58@collabora.com","SvxGraphicObject: remove more manual swap out calls\n\nTested with importing large *.rtf and *.docx test documents\nwith lots of images -> auto swapp out works.\n\nChange-Id: Ib040edaa89c9bcb966c58b75f0392e6d9f7a165e","Zolnai Tamás",true]],"size":35,"ref":"refs/heads/master","head":"250bd093509fb99afa59d8d4290b8a996a0962c6"}