GitHub PullRequestEvent at 2014-08-23 22:19:06
Repository: neovim
Actor: jszakmeister
Payload: {"action":"closed","number":1110,"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/1110","id":20213641,"html_url":"https://github.com/neovim/neovim/pull/1110","diff_url":"https://github.com/neovim/neovim/pull/1110.diff","patch_url":"https://github.com/neovim/neovim/pull/1110.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/1110","number":1110,"state":"closed","locked":false,"title":"[RFC] CMake: Use DESTDIR for helptags generation.","user":{"login":"fwalch","id":339435,"avatar_url":"https://avatars.githubusercontent.com/u/339435?v=2","gravatar_id":null,"url":"https://api.github.com/users/fwalch","html_url":"https://github.com/fwalch","followers_url":"https://api.github.com/users/fwalch/followers","following_url":"https://api.github.com/users/fwalch/following{/other_user}","gists_url":"https://api.github.com/users/fwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/fwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwalch/subscriptions","organizations_url":"https://api.github.com/users/fwalch/orgs","repos_url":"https://api.github.com/users/fwalch/repos","events_url":"https://api.github.com/users/fwalch/events{/privacy}","received_events_url":"https://api.github.com/users/fwalch/received_events","type":"User","site_admin":false},"body":"When `DESTDIR` is used (`make DESTDIR=... install`), it is [ignored by the helptags generation](https://aur.archlinux.org/packages/neovim-git) (#1106), so during package building, instead of running the command in e.g. `/home/user/neovim-package/build/usr/local/share/nvim/...` it tries to execute in `/usr/local/share/nvim/...`, which is not what it's supposed to do. Adding `DESTDIR` to the working directory should fix that.\r\n\r\nPing @jszakmeister. Sorry about that :-(","created_at":"2014-08-23T20:48:02Z","updated_at":"2014-08-23T22:19:06Z","closed_at":"2014-08-23T22:19:06Z","merged_at":null,"merge_commit_sha":"b7efce66c1230aeba4591eff720f3501ca6791c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/1110/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/1110/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/1110/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/3076ed909566ce1faec3d0d4a1d5e7e2e43f02c6","head":{"label":"fwalch:fix-helptags","ref":"fix-helptags","sha":"3076ed909566ce1faec3d0d4a1d5e7e2e43f02c6","user":{"login":"fwalch","id":339435,"avatar_url":"https://avatars.githubusercontent.com/u/339435?v=2","gravatar_id":null,"url":"https://api.github.com/users/fwalch","html_url":"https://github.com/fwalch","followers_url":"https://api.github.com/users/fwalch/followers","following_url":"https://api.github.com/users/fwalch/following{/other_user}","gists_url":"https://api.github.com/users/fwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/fwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwalch/subscriptions","organizations_url":"https://api.github.com/users/fwalch/orgs","repos_url":"https://api.github.com/users/fwalch/repos","events_url":"https://api.github.com/users/fwalch/events{/privacy}","received_events_url":"https://api.github.com/users/fwalch/received_events","type":"User","site_admin":false},"repo":{"id":20288605,"name":"neovim","full_name":"fwalch/neovim","owner":{"login":"fwalch","id":339435,"avatar_url":"https://avatars.githubusercontent.com/u/339435?v=2","gravatar_id":null,"url":"https://api.github.com/users/fwalch","html_url":"https://github.com/fwalch","followers_url":"https://api.github.com/users/fwalch/followers","following_url":"https://api.github.com/users/fwalch/following{/other_user}","gists_url":"https://api.github.com/users/fwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/fwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwalch/subscriptions","organizations_url":"https://api.github.com/users/fwalch/orgs","repos_url":"https://api.github.com/users/fwalch/repos","events_url":"https://api.github.com/users/fwalch/events{/privacy}","received_events_url":"https://api.github.com/users/fwalch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fwalch/neovim","description":"vim's rebirth for the 21st century","fork":true,"url":"https://api.github.com/repos/fwalch/neovim","forks_url":"https://api.github.com/repos/fwalch/neovim/forks","keys_url":"https://api.github.com/repos/fwalch/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fwalch/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fwalch/neovim/teams","hooks_url":"https://api.github.com/repos/fwalch/neovim/hooks","issue_events_url":"https://api.github.com/repos/fwalch/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/fwalch/neovim/events","assignees_url":"https://api.github.com/repos/fwalch/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/fwalch/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/fwalch/neovim/tags","blobs_url":"https://api.github.com/repos/fwalch/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fwalch/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fwalch/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/fwalch/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fwalch/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/fwalch/neovim/languages","stargazers_url":"https://api.github.com/repos/fwalch/neovim/stargazers","contributors_url":"https://api.github.com/repos/fwalch/neovim/contributors","subscribers_url":"https://api.github.com/repos/fwalch/neovim/subscribers","subscription_url":"https://api.github.com/repos/fwalch/neovim/subscription","commits_url":"https://api.github.com/repos/fwalch/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/fwalch/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/fwalch/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/fwalch/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/fwalch/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/fwalch/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fwalch/neovim/merges","archive_url":"https://api.github.com/repos/fwalch/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fwalch/neovim/downloads","issues_url":"https://api.github.com/repos/fwalch/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/fwalch/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/fwalch/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/fwalch/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fwalch/neovim/labels{/name}","releases_url":"https://api.github.com/repos/fwalch/neovim/releases{/id}","created_at":"2014-05-29T09:18:20Z","updated_at":"2014-07-29T17:54:17Z","pushed_at":"2014-08-23T20:49:30Z","git_url":"git://github.com/fwalch/neovim.git","ssh_url":"git@github.com:fwalch/neovim.git","clone_url":"https://github.com/fwalch/neovim.git","svn_url":"https://github.com/fwalch/neovim","homepage":"http://neovim.org/","size":21860,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"866d547cfccf8b3f3d5029ede78fab86fdaa6f74","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=2","gravatar_id":"294926ca6818f582b716e868d6c6f985","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=2","gravatar_id":"294926ca6818f582b716e868d6c6f985","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"vim for the 21st century","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2014-08-23T21:24:04Z","pushed_at":"2014-08-23T22:18:54Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.org/","size":55076,"stargazers_count":9355,"watchers_count":9355,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":614,"mirror_url":null,"open_issues_count":190,"forks":614,"open_issues":190,"watchers":9355,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1110"},"html":{"href":"https://github.com/neovim/neovim/pull/1110"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/1110"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/1110/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1110/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1110/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/3076ed909566ce1faec3d0d4a1d5e7e2e43f02c6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}