GitHub PullRequestReviewCommentEvent at 2014-09-08 22:42:11
Repository: rust
Actor: huonw
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/17272358","id":17272358,"diff_hunk":"@@ -726,6 +727,27 @@ impl String {\n     pub unsafe fn as_mut_vec<'a>(&'a mut self) -> &'a mut Vec<u8> {\n         &mut self.vec\n     }\n+\n+    /// The format function takes a precompiled format string and a list of\n+    /// arguments, to return the resulting formatted string.\n+    ///\n+    /// # Arguments\n+    ///\n+    ///   * args - a structure of arguments generated via the `format_args!` macro.\n+    ///            Because this structure can only be safely generated at\n+    ///            compile-time, this function is safe.\n+    ///\n+    /// # Example\n+    ///\n+    /// ```rust\n+    /// let s = format_args!(String::format, \"Hello, {}!\", \"world\");\n+    /// assert_eq!(s, \"Hello, world!\".to_string());\n+    /// ```\n+    pub fn format(args: &fmt::Arguments) -> String {\n+        let mut output = vec!();\n+        let _ = write!(&mut output, \"{}\", args);\n+        String::from_utf8(output).unwrap()","path":"src/libcollections/string.rs","position":31,"original_position":31,"commit_id":"2cfff747bd2dcefce6c1825ec986b2d13c66d7d3","original_commit_id":"2cfff747bd2dcefce6c1825ec986b2d13c66d7d3","user":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=2","gravatar_id":"365f3c2704e4744e237651f3c2a7c411","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"body":"I'm not sure about this unwrap... (it's going to have a horrible error message, since it will just be dumping the `Vec<u8>` directly, and it's also 'implicitly' failing.)","created_at":"2014-09-08T22:42:11Z","updated_at":"2014-09-08T22:42:11Z","html_url":"https://github.com/rust-lang/rust/pull/17100#discussion_r17272358","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/17100","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/17272358"},"html":{"href":"https://github.com/rust-lang/rust/pull/17100#discussion_r17272358"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17100"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/17100","id":20905646,"html_url":"https://github.com/rust-lang/rust/pull/17100","diff_url":"https://github.com/rust-lang/rust/pull/17100.diff","patch_url":"https://github.com/rust-lang/rust/pull/17100.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/17100","number":17100,"state":"open","locked":false,"title":"Improve the experience of using syntax extensions with #![no_std]","user":{"login":"kmcallister","id":444997,"avatar_url":"https://avatars.githubusercontent.com/u/444997?v=2","gravatar_id":"ac0ed9efe05910cd536b5022b005c80a","url":"https://api.github.com/users/kmcallister","html_url":"https://github.com/kmcallister","followers_url":"https://api.github.com/users/kmcallister/followers","following_url":"https://api.github.com/users/kmcallister/following{/other_user}","gists_url":"https://api.github.com/users/kmcallister/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcallister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcallister/subscriptions","organizations_url":"https://api.github.com/users/kmcallister/orgs","repos_url":"https://api.github.com/users/kmcallister/repos","events_url":"https://api.github.com/users/kmcallister/events{/privacy}","received_events_url":"https://api.github.com/users/kmcallister/received_events","type":"User","site_admin":false},"body":"This isn't as exciting as crate capture for macros, but it removes a number of immediate pain points.","created_at":"2014-09-08T17:51:11Z","updated_at":"2014-09-08T22:42:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"610ddb9bbded9532308b082a3f5a0d13d6851562","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/17100/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/17100/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/17100/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/2cfff747bd2dcefce6c1825ec986b2d13c66d7d3","head":{"label":"kmcallister:ext-no-std","ref":"ext-no-std","sha":"2cfff747bd2dcefce6c1825ec986b2d13c66d7d3","user":{"login":"kmcallister","id":444997,"avatar_url":"https://avatars.githubusercontent.com/u/444997?v=2","gravatar_id":"ac0ed9efe05910cd536b5022b005c80a","url":"https://api.github.com/users/kmcallister","html_url":"https://github.com/kmcallister","followers_url":"https://api.github.com/users/kmcallister/followers","following_url":"https://api.github.com/users/kmcallister/following{/other_user}","gists_url":"https://api.github.com/users/kmcallister/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcallister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcallister/subscriptions","organizations_url":"https://api.github.com/users/kmcallister/orgs","repos_url":"https://api.github.com/users/kmcallister/repos","events_url":"https://api.github.com/users/kmcallister/events{/privacy}","received_events_url":"https://api.github.com/users/kmcallister/received_events","type":"User","site_admin":false},"repo":{"id":11487393,"name":"rust","full_name":"kmcallister/rust","owner":{"login":"kmcallister","id":444997,"avatar_url":"https://avatars.githubusercontent.com/u/444997?v=2","gravatar_id":"ac0ed9efe05910cd536b5022b005c80a","url":"https://api.github.com/users/kmcallister","html_url":"https://github.com/kmcallister","followers_url":"https://api.github.com/users/kmcallister/followers","following_url":"https://api.github.com/users/kmcallister/following{/other_user}","gists_url":"https://api.github.com/users/kmcallister/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcallister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcallister/subscriptions","organizations_url":"https://api.github.com/users/kmcallister/orgs","repos_url":"https://api.github.com/users/kmcallister/repos","events_url":"https://api.github.com/users/kmcallister/events{/privacy}","received_events_url":"https://api.github.com/users/kmcallister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmcallister/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/kmcallister/rust","forks_url":"https://api.github.com/repos/kmcallister/rust/forks","keys_url":"https://api.github.com/repos/kmcallister/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmcallister/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmcallister/rust/teams","hooks_url":"https://api.github.com/repos/kmcallister/rust/hooks","issue_events_url":"https://api.github.com/repos/kmcallister/rust/issues/events{/number}","events_url":"https://api.github.com/repos/kmcallister/rust/events","assignees_url":"https://api.github.com/repos/kmcallister/rust/assignees{/user}","branches_url":"https://api.github.com/repos/kmcallister/rust/branches{/branch}","tags_url":"https://api.github.com/repos/kmcallister/rust/tags","blobs_url":"https://api.github.com/repos/kmcallister/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmcallister/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmcallister/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmcallister/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmcallister/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/kmcallister/rust/languages","stargazers_url":"https://api.github.com/repos/kmcallister/rust/stargazers","contributors_url":"https://api.github.com/repos/kmcallister/rust/contributors","subscribers_url":"https://api.github.com/repos/kmcallister/rust/subscribers","subscription_url":"https://api.github.com/repos/kmcallister/rust/subscription","commits_url":"https://api.github.com/repos/kmcallister/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmcallister/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmcallister/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmcallister/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/kmcallister/rust/contents/{+path}","compare_url":"https://api.github.com/repos/kmcallister/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmcallister/rust/merges","archive_url":"https://api.github.com/repos/kmcallister/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmcallister/rust/downloads","issues_url":"https://api.github.com/repos/kmcallister/rust/issues{/number}","pulls_url":"https://api.github.com/repos/kmcallister/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/kmcallister/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/kmcallister/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmcallister/rust/labels{/name}","releases_url":"https://api.github.com/repos/kmcallister/rust/releases{/id}","created_at":"2013-07-17T20:58:11Z","updated_at":"2014-06-25T03:42:03Z","pushed_at":"2014-09-08T19:02:47Z","git_url":"git://github.com/kmcallister/rust.git","ssh_url":"git@github.com:kmcallister/rust.git","clone_url":"https://github.com/kmcallister/rust.git","svn_url":"https://github.com/kmcallister/rust","homepage":"http://www.rust-lang.org","size":157474,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"6f34760e4173dda94162502153fe4c5a2a96fc9d","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=2","gravatar_id":"a4268b59e433144466a0f67cbcfd8cdc","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=2","gravatar_id":"a4268b59e433144466a0f67cbcfd8cdc","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2014-09-08T20:09:32Z","pushed_at":"2014-09-08T20:53:52Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":455657,"stargazers_count":6295,"watchers_count":6295,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1254,"mirror_url":null,"open_issues_count":1973,"forks":1254,"open_issues":1973,"watchers":6295,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17100"},"html":{"href":"https://github.com/rust-lang/rust/pull/17100"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/17100"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/17100/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17100/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/17100/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/2cfff747bd2dcefce6c1825ec986b2d13c66d7d3"}}}}