GitHub PullRequestReviewCommentEvent at 2014-09-09 06:29:47
Repository: lantern
Actor: myleshorton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/getlantern/lantern/pulls/comments/17284093","id":17284093,"diff_hunk":"@@ -164,11 +165,18 @@ public void run() {\n             if (externallyAccessible) {\n                 LOGGER.debug(\"Confirmed able to proxy for external clients!\");\n                 hidePortMappingWarning();\n-                needPortMappingWarning.set(true);\n+                \n+                // We set this to false here because this indicates the port\n+                // mapping has succeeded at least once. If our check fails in \n+                // the future, it is unlikely to be because of the port\n+                // mapping itself. The user certainly could have moved networks\n+                // with a laptop or something, but in that case they're also\n+                // unlikely to have moved to a second location where they\n+                // have permissions to configure the router.\n+                needPortMappingWarning.set(false);","path":"src/main/java/org/lantern/proxy/pt/FlashlightServerManager.java","position":30,"original_position":30,"commit_id":"147d90d9d0978b4a10f6b956a8d42f3dc1b35737","original_commit_id":"147d90d9d0978b4a10f6b956a8d42f3dc1b35737","user":{"login":"myleshorton","id":1143966,"avatar_url":"https://avatars.githubusercontent.com/u/1143966?v=2","gravatar_id":"3022bdbccd7ac257dea4e5330a08930b","url":"https://api.github.com/users/myleshorton","html_url":"https://github.com/myleshorton","followers_url":"https://api.github.com/users/myleshorton/followers","following_url":"https://api.github.com/users/myleshorton/following{/other_user}","gists_url":"https://api.github.com/users/myleshorton/gists{/gist_id}","starred_url":"https://api.github.com/users/myleshorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myleshorton/subscriptions","organizations_url":"https://api.github.com/users/myleshorton/orgs","repos_url":"https://api.github.com/users/myleshorton/repos","events_url":"https://api.github.com/users/myleshorton/events{/privacy}","received_events_url":"https://api.github.com/users/myleshorton/received_events","type":"User","site_admin":false},"body":"That certainly could happen. It's just hard to tell the difference between the various potential failure cases, and I'm reluctant to potentially misinform the user.","created_at":"2014-09-09T06:29:47Z","updated_at":"2014-09-09T06:29:47Z","html_url":"https://github.com/getlantern/lantern/pull/1794#discussion_r17284093","pull_request_url":"https://api.github.com/repos/getlantern/lantern/pulls/1794","_links":{"self":{"href":"https://api.github.com/repos/getlantern/lantern/pulls/comments/17284093"},"html":{"href":"https://github.com/getlantern/lantern/pull/1794#discussion_r17284093"},"pull_request":{"href":"https://api.github.com/repos/getlantern/lantern/pulls/1794"}}},"pull_request":{"url":"https://api.github.com/repos/getlantern/lantern/pulls/1794","id":20920222,"html_url":"https://github.com/getlantern/lantern/pull/1794","diff_url":"https://github.com/getlantern/lantern/pull/1794.diff","patch_url":"https://github.com/getlantern/lantern/pull/1794.patch","issue_url":"https://api.github.com/repos/getlantern/lantern/issues/1794","number":1794,"state":"open","locked":false,"title":"1749","user":{"login":"myleshorton","id":1143966,"avatar_url":"https://avatars.githubusercontent.com/u/1143966?v=2","gravatar_id":"3022bdbccd7ac257dea4e5330a08930b","url":"https://api.github.com/users/myleshorton","html_url":"https://github.com/myleshorton","followers_url":"https://api.github.com/users/myleshorton/followers","following_url":"https://api.github.com/users/myleshorton/following{/other_user}","gists_url":"https://api.github.com/users/myleshorton/gists{/gist_id}","starred_url":"https://api.github.com/users/myleshorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myleshorton/subscriptions","organizations_url":"https://api.github.com/users/myleshorton/orgs","repos_url":"https://api.github.com/users/myleshorton/repos","events_url":"https://api.github.com/users/myleshorton/events{/privacy}","received_events_url":"https://api.github.com/users/myleshorton/received_events","type":"User","site_admin":false},"body":"147d90d is the only relevant commit here. What do you think @oxtoacart?","created_at":"2014-09-08T21:45:31Z","updated_at":"2014-09-09T06:29:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b862711f0c4a55b0df094fb6177795d9adc071a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/getlantern/lantern/pulls/1794/commits","review_comments_url":"https://api.github.com/repos/getlantern/lantern/pulls/1794/comments","review_comment_url":"https://api.github.com/repos/getlantern/lantern/pulls/comments/{number}","comments_url":"https://api.github.com/repos/getlantern/lantern/issues/1794/comments","statuses_url":"https://api.github.com/repos/getlantern/lantern/statuses/147d90d9d0978b4a10f6b956a8d42f3dc1b35737","head":{"label":"getlantern:1749","ref":"1749","sha":"147d90d9d0978b4a10f6b956a8d42f3dc1b35737","user":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=2","gravatar_id":"37baf1adaf44a84fd1c73634354d8547","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"repo":{"id":1380117,"name":"lantern","full_name":"getlantern/lantern","owner":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=2","gravatar_id":"37baf1adaf44a84fd1c73634354d8547","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getlantern/lantern","description":"Defeat censorship. Share access to the open internet with people around the world through your social network.","fork":false,"url":"https://api.github.com/repos/getlantern/lantern","forks_url":"https://api.github.com/repos/getlantern/lantern/forks","keys_url":"https://api.github.com/repos/getlantern/lantern/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getlantern/lantern/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getlantern/lantern/teams","hooks_url":"https://api.github.com/repos/getlantern/lantern/hooks","issue_events_url":"https://api.github.com/repos/getlantern/lantern/issues/events{/number}","events_url":"https://api.github.com/repos/getlantern/lantern/events","assignees_url":"https://api.github.com/repos/getlantern/lantern/assignees{/user}","branches_url":"https://api.github.com/repos/getlantern/lantern/branches{/branch}","tags_url":"https://api.github.com/repos/getlantern/lantern/tags","blobs_url":"https://api.github.com/repos/getlantern/lantern/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getlantern/lantern/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getlantern/lantern/git/refs{/sha}","trees_url":"https://api.github.com/repos/getlantern/lantern/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getlantern/lantern/statuses/{sha}","languages_url":"https://api.github.com/repos/getlantern/lantern/languages","stargazers_url":"https://api.github.com/repos/getlantern/lantern/stargazers","contributors_url":"https://api.github.com/repos/getlantern/lantern/contributors","subscribers_url":"https://api.github.com/repos/getlantern/lantern/subscribers","subscription_url":"https://api.github.com/repos/getlantern/lantern/subscription","commits_url":"https://api.github.com/repos/getlantern/lantern/commits{/sha}","git_commits_url":"https://api.github.com/repos/getlantern/lantern/git/commits{/sha}","comments_url":"https://api.github.com/repos/getlantern/lantern/comments{/number}","issue_comment_url":"https://api.github.com/repos/getlantern/lantern/issues/comments/{number}","contents_url":"https://api.github.com/repos/getlantern/lantern/contents/{+path}","compare_url":"https://api.github.com/repos/getlantern/lantern/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getlantern/lantern/merges","archive_url":"https://api.github.com/repos/getlantern/lantern/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getlantern/lantern/downloads","issues_url":"https://api.github.com/repos/getlantern/lantern/issues{/number}","pulls_url":"https://api.github.com/repos/getlantern/lantern/pulls{/number}","milestones_url":"https://api.github.com/repos/getlantern/lantern/milestones{/number}","notifications_url":"https://api.github.com/repos/getlantern/lantern/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getlantern/lantern/labels{/name}","releases_url":"https://api.github.com/repos/getlantern/lantern/releases{/id}","created_at":"2011-02-17T22:12:29Z","updated_at":"2014-09-08T08:08:26Z","pushed_at":"2014-09-09T02:18:22Z","git_url":"git://github.com/getlantern/lantern.git","ssh_url":"git@github.com:getlantern/lantern.git","clone_url":"https://github.com/getlantern/lantern.git","svn_url":"https://github.com/getlantern/lantern","homepage":"https://getlantern.org","size":486952,"stargazers_count":772,"watchers_count":772,"language":"IDL","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":155,"mirror_url":null,"open_issues_count":285,"forks":155,"open_issues":285,"watchers":772,"default_branch":"devel"}},"base":{"label":"getlantern:devel","ref":"devel","sha":"54b12f8976a8d3a1fd8add52e8ea9c40d1041fe2","user":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=2","gravatar_id":"37baf1adaf44a84fd1c73634354d8547","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"repo":{"id":1380117,"name":"lantern","full_name":"getlantern/lantern","owner":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=2","gravatar_id":"37baf1adaf44a84fd1c73634354d8547","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getlantern/lantern","description":"Defeat censorship. Share access to the open internet with people around the world through your social network.","fork":false,"url":"https://api.github.com/repos/getlantern/lantern","forks_url":"https://api.github.com/repos/getlantern/lantern/forks","keys_url":"https://api.github.com/repos/getlantern/lantern/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getlantern/lantern/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getlantern/lantern/teams","hooks_url":"https://api.github.com/repos/getlantern/lantern/hooks","issue_events_url":"https://api.github.com/repos/getlantern/lantern/issues/events{/number}","events_url":"https://api.github.com/repos/getlantern/lantern/events","assignees_url":"https://api.github.com/repos/getlantern/lantern/assignees{/user}","branches_url":"https://api.github.com/repos/getlantern/lantern/branches{/branch}","tags_url":"https://api.github.com/repos/getlantern/lantern/tags","blobs_url":"https://api.github.com/repos/getlantern/lantern/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getlantern/lantern/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getlantern/lantern/git/refs{/sha}","trees_url":"https://api.github.com/repos/getlantern/lantern/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getlantern/lantern/statuses/{sha}","languages_url":"https://api.github.com/repos/getlantern/lantern/languages","stargazers_url":"https://api.github.com/repos/getlantern/lantern/stargazers","contributors_url":"https://api.github.com/repos/getlantern/lantern/contributors","subscribers_url":"https://api.github.com/repos/getlantern/lantern/subscribers","subscription_url":"https://api.github.com/repos/getlantern/lantern/subscription","commits_url":"https://api.github.com/repos/getlantern/lantern/commits{/sha}","git_commits_url":"https://api.github.com/repos/getlantern/lantern/git/commits{/sha}","comments_url":"https://api.github.com/repos/getlantern/lantern/comments{/number}","issue_comment_url":"https://api.github.com/repos/getlantern/lantern/issues/comments/{number}","contents_url":"https://api.github.com/repos/getlantern/lantern/contents/{+path}","compare_url":"https://api.github.com/repos/getlantern/lantern/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getlantern/lantern/merges","archive_url":"https://api.github.com/repos/getlantern/lantern/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getlantern/lantern/downloads","issues_url":"https://api.github.com/repos/getlantern/lantern/issues{/number}","pulls_url":"https://api.github.com/repos/getlantern/lantern/pulls{/number}","milestones_url":"https://api.github.com/repos/getlantern/lantern/milestones{/number}","notifications_url":"https://api.github.com/repos/getlantern/lantern/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getlantern/lantern/labels{/name}","releases_url":"https://api.github.com/repos/getlantern/lantern/releases{/id}","created_at":"2011-02-17T22:12:29Z","updated_at":"2014-09-08T08:08:26Z","pushed_at":"2014-09-09T02:18:22Z","git_url":"git://github.com/getlantern/lantern.git","ssh_url":"git@github.com:getlantern/lantern.git","clone_url":"https://github.com/getlantern/lantern.git","svn_url":"https://github.com/getlantern/lantern","homepage":"https://getlantern.org","size":486952,"stargazers_count":772,"watchers_count":772,"language":"IDL","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":155,"mirror_url":null,"open_issues_count":285,"forks":155,"open_issues":285,"watchers":772,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/getlantern/lantern/pulls/1794"},"html":{"href":"https://github.com/getlantern/lantern/pull/1794"},"issue":{"href":"https://api.github.com/repos/getlantern/lantern/issues/1794"},"comments":{"href":"https://api.github.com/repos/getlantern/lantern/issues/1794/comments"},"review_comments":{"href":"https://api.github.com/repos/getlantern/lantern/pulls/1794/comments"},"review_comment":{"href":"https://api.github.com/repos/getlantern/lantern/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/getlantern/lantern/pulls/1794/commits"},"statuses":{"href":"https://api.github.com/repos/getlantern/lantern/statuses/147d90d9d0978b4a10f6b956a8d42f3dc1b35737"}}}}