GitHub PullRequestReviewCommentEvent at 2014-10-03 20:55:14
Repository: gcloud-python
Actor: dhermes
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/comments/18419078","id":18419078,"diff_hunk":"@@ -28,3 +28,14 @@ commands =\n     sphinx-build -b html -d docs/_build/doctrees docs docs/_build/html\n deps =\n     Sphinx\n+\n+[pep8]\n+exclude = gcloud/datastore/datastore_v1_pb2.py,.*/,docs/conf.py\n+\n+[testenv:lint]\n+basepython =\n+    python2.7\n+commands =\n+    pep8","path":"tox.ini","position":21,"original_position":20,"commit_id":"33e086faa6c8ae6c5b4245412e66a8610a1bdec0","original_commit_id":"ff06973322b47fcdf89cebc7e9ef75d035a3ab61","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=2","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"body":"Ah shoot! The only `egg` file on my machine is the `protobuf` egg and it is a zip.\r\n\r\nA few things\r\n- What causes the eggs to be created outside of `.tox`?\r\n- The most important place for `tox -e lint` to succeed is on Travis with a clean install, which it does?\r\n- I have two ways I'd like to deal with this\r\n  - Change the exclude line to  `exclude = gcloud/datastore/datastore_v1_pb2.py,docs/conf.py,*.egg/,.*/`\r\n  - Change `pep8` to explicitly only work on checked in files: ``pep8 `git ls-files | grep \".py$\"` ``\r\n\r\n@tseaver WDYT?","created_at":"2014-10-03T20:55:14Z","updated_at":"2014-10-03T20:55:14Z","html_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/217#discussion_r18419078","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/comments/18419078"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/217#discussion_r18419078"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/217","id":22209579,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/217","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/217.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/217.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/217","number":217,"state":"open","locked":false,"title":"Adding PEP8 only lint rule to tox and Travis.","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=2","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-03T15:18:30Z","updated_at":"2014-10-03T20:55:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d356b2baabd79762579e7cfa6df4a977469750e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/217/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/217/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/217/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/statuses/33e086faa6c8ae6c5b4245412e66a8610a1bdec0","head":{"label":"dhermes:add-tox-lint","ref":"add-tox-lint","sha":"33e086faa6c8ae6c5b4245412e66a8610a1bdec0","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=2","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"repo":{"id":23001795,"name":"gcloud-python","full_name":"dhermes/gcloud-python","owner":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=2","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhermes/gcloud-python","description":"Google Cloud Python Client Library","fork":true,"url":"https://api.github.com/repos/dhermes/gcloud-python","forks_url":"https://api.github.com/repos/dhermes/gcloud-python/forks","keys_url":"https://api.github.com/repos/dhermes/gcloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhermes/gcloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhermes/gcloud-python/teams","hooks_url":"https://api.github.com/repos/dhermes/gcloud-python/hooks","issue_events_url":"https://api.github.com/repos/dhermes/gcloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/dhermes/gcloud-python/events","assignees_url":"https://api.github.com/repos/dhermes/gcloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/dhermes/gcloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/dhermes/gcloud-python/tags","blobs_url":"https://api.github.com/repos/dhermes/gcloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhermes/gcloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhermes/gcloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhermes/gcloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhermes/gcloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dhermes/gcloud-python/languages","stargazers_url":"https://api.github.com/repos/dhermes/gcloud-python/stargazers","contributors_url":"https://api.github.com/repos/dhermes/gcloud-python/contributors","subscribers_url":"https://api.github.com/repos/dhermes/gcloud-python/subscribers","subscription_url":"https://api.github.com/repos/dhermes/gcloud-python/subscription","commits_url":"https://api.github.com/repos/dhermes/gcloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhermes/gcloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhermes/gcloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhermes/gcloud-python/issues/comments/{number}","contents_url":"https://api.github.com/repos/dhermes/gcloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/dhermes/gcloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhermes/gcloud-python/merges","archive_url":"https://api.github.com/repos/dhermes/gcloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhermes/gcloud-python/downloads","issues_url":"https://api.github.com/repos/dhermes/gcloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/dhermes/gcloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dhermes/gcloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dhermes/gcloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhermes/gcloud-python/labels{/name}","releases_url":"https://api.github.com/repos/dhermes/gcloud-python/releases{/id}","created_at":"2014-08-15T20:18:30Z","updated_at":"2014-09-22T03:09:47Z","pushed_at":"2014-10-03T17:57:26Z","git_url":"git://github.com/dhermes/gcloud-python.git","ssh_url":"git@github.com:dhermes/gcloud-python.git","clone_url":"https://github.com/dhermes/gcloud-python.git","svn_url":"https://github.com/dhermes/gcloud-python","homepage":"http://googlecloudplatform.github.io/gcloud-python/","size":6064,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"1779aeccdea1f2557e5e2cf80e448d0b64f48527","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=2","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"name":"gcloud-python","full_name":"GoogleCloudPlatform/gcloud-python","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=2","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-python","description":"Google Cloud Python Client Library","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/releases{/id}","created_at":"2014-01-28T15:51:47Z","updated_at":"2014-10-03T16:50:46Z","pushed_at":"2014-10-03T13:05:25Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-python.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-python.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-python.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-python","homepage":"http://googlecloudplatform.github.io/gcloud-python/","size":3299,"stargazers_count":48,"watchers_count":48,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":97,"forks":19,"open_issues":97,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/217"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/217"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/217"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/statuses/33e086faa6c8ae6c5b4245412e66a8610a1bdec0"}}}}