GitHub PullRequestReviewCommentEvent at 2014-11-03 22:19:17
Repository: waysome
Actor: matthiasbeyer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/waysome/waysome/pulls/comments/19771309","id":19771309,"diff_hunk":"@@ -0,0 +1,68 @@\n+/*\n+ * waysome - wayland based window manager\n+ *\n+ * Copyright in alphabetical order:\n+ *\n+ * Copyright (C) 2014-2015 Julian Ganz\n+ * Copyright (C) 2014-2015 Manuel Messner\n+ * Copyright (C) 2014-2015 Marcel Müller\n+ * Copyright (C) 2014-2015 Matthias Beyer\n+ * Copyright (C) 2014-2015 Nadja Sommerfeld\n+ *\n+ * This file is part of waysome.\n+ *\n+ * waysome is free software: you can redistribute it and/or modify it under the\n+ * terms of the GNU Lesser General Public License as published by the Free\n+ * Software Foundation, either version 2.1 of the License, or (at your option)\n+ * any later version.\n+ *\n+ * waysome is distributed in the hope that it will be useful, but WITHOUT ANY\n+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR\n+ * A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more\n+ * details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public License\n+ * along with waysome. If not, see <http://www.gnu.org/licenses/>.\n+ */\n+\n+#ifndef __WS_INPUT_HOTKEY_EVENT_H__\n+#define __WS_INPUT_HOTKEY_EVENT_H__\n+\n+#include <stdint.h>\n+\n+#include \"objects/object.h\"\n+#include \"objects/string.h\"\n+#include \"util/attributes.h\"\n+\n+\n+/**\n+ * A hotkey event\n+ */\n+struct ws_hotkey_event {\n+    struct ws_object obj; //!< @public supertype\n+    struct ws_string name; //!< @public supertype ","path":"src/input/hotkey_event.h","position":43,"original_position":43,"commit_id":"35b5ed6c9a74946d584f0c608abe6d72276cdcaf","original_commit_id":"bac64833ee9756d10c4f1d29fb0f719feb315fd2","user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=2","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"body":"Doubled supertype here. If this is intended, you should add a verbose documentation why.","created_at":"2014-11-03T22:19:17Z","updated_at":"2014-11-03T22:19:17Z","html_url":"https://github.com/waysome/waysome/pull/340#discussion_r19771309","pull_request_url":"https://api.github.com/repos/waysome/waysome/pulls/340","_links":{"self":{"href":"https://api.github.com/repos/waysome/waysome/pulls/comments/19771309"},"html":{"href":"https://github.com/waysome/waysome/pull/340#discussion_r19771309"},"pull_request":{"href":"https://api.github.com/repos/waysome/waysome/pulls/340"}}},"pull_request":{"url":"https://api.github.com/repos/waysome/waysome/pulls/340","id":23530266,"html_url":"https://github.com/waysome/waysome/pull/340","diff_url":"https://github.com/waysome/waysome/pull/340.diff","patch_url":"https://github.com/waysome/waysome/pull/340.patch","issue_url":"https://api.github.com/repos/waysome/waysome/issues/340","number":340,"state":"open","locked":false,"title":"Add input event DAG","user":{"login":"neithernut","id":6747556,"avatar_url":"https://avatars.githubusercontent.com/u/6747556?v=2","gravatar_id":"","url":"https://api.github.com/users/neithernut","html_url":"https://github.com/neithernut","followers_url":"https://api.github.com/users/neithernut/followers","following_url":"https://api.github.com/users/neithernut/following{/other_user}","gists_url":"https://api.github.com/users/neithernut/gists{/gist_id}","starred_url":"https://api.github.com/users/neithernut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neithernut/subscriptions","organizations_url":"https://api.github.com/users/neithernut/orgs","repos_url":"https://api.github.com/users/neithernut/repos","events_url":"https://api.github.com/users/neithernut/events{/privacy}","received_events_url":"https://api.github.com/users/neithernut/received_events","type":"User","site_admin":false},"body":"This PR adds code for hotkey recognition and event emission.\r\nStill WIP, but you can review the code that is present now.\r\nTargets #321.","created_at":"2014-10-29T13:36:50Z","updated_at":"2014-11-03T22:19:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d02f8a7bdbbe0fea3b576098ac6c70d0209b6cc6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/waysome/waysome/pulls/340/commits","review_comments_url":"https://api.github.com/repos/waysome/waysome/pulls/340/comments","review_comment_url":"https://api.github.com/repos/waysome/waysome/pulls/comments/{number}","comments_url":"https://api.github.com/repos/waysome/waysome/issues/340/comments","statuses_url":"https://api.github.com/repos/waysome/waysome/statuses/35b5ed6c9a74946d584f0c608abe6d72276cdcaf","head":{"label":"neithernut:add-input_event_dag","ref":"add-input_event_dag","sha":"35b5ed6c9a74946d584f0c608abe6d72276cdcaf","user":{"login":"neithernut","id":6747556,"avatar_url":"https://avatars.githubusercontent.com/u/6747556?v=2","gravatar_id":"","url":"https://api.github.com/users/neithernut","html_url":"https://github.com/neithernut","followers_url":"https://api.github.com/users/neithernut/followers","following_url":"https://api.github.com/users/neithernut/following{/other_user}","gists_url":"https://api.github.com/users/neithernut/gists{/gist_id}","starred_url":"https://api.github.com/users/neithernut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neithernut/subscriptions","organizations_url":"https://api.github.com/users/neithernut/orgs","repos_url":"https://api.github.com/users/neithernut/repos","events_url":"https://api.github.com/users/neithernut/events{/privacy}","received_events_url":"https://api.github.com/users/neithernut/received_events","type":"User","site_admin":false},"repo":{"id":24571973,"name":"waysome","full_name":"neithernut/waysome","owner":{"login":"neithernut","id":6747556,"avatar_url":"https://avatars.githubusercontent.com/u/6747556?v=2","gravatar_id":"","url":"https://api.github.com/users/neithernut","html_url":"https://github.com/neithernut","followers_url":"https://api.github.com/users/neithernut/followers","following_url":"https://api.github.com/users/neithernut/following{/other_user}","gists_url":"https://api.github.com/users/neithernut/gists{/gist_id}","starred_url":"https://api.github.com/users/neithernut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neithernut/subscriptions","organizations_url":"https://api.github.com/users/neithernut/orgs","repos_url":"https://api.github.com/users/neithernut/repos","events_url":"https://api.github.com/users/neithernut/events{/privacy}","received_events_url":"https://api.github.com/users/neithernut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neithernut/waysome","description":"Windowmanager for wayland","fork":true,"url":"https://api.github.com/repos/neithernut/waysome","forks_url":"https://api.github.com/repos/neithernut/waysome/forks","keys_url":"https://api.github.com/repos/neithernut/waysome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neithernut/waysome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neithernut/waysome/teams","hooks_url":"https://api.github.com/repos/neithernut/waysome/hooks","issue_events_url":"https://api.github.com/repos/neithernut/waysome/issues/events{/number}","events_url":"https://api.github.com/repos/neithernut/waysome/events","assignees_url":"https://api.github.com/repos/neithernut/waysome/assignees{/user}","branches_url":"https://api.github.com/repos/neithernut/waysome/branches{/branch}","tags_url":"https://api.github.com/repos/neithernut/waysome/tags","blobs_url":"https://api.github.com/repos/neithernut/waysome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neithernut/waysome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neithernut/waysome/git/refs{/sha}","trees_url":"https://api.github.com/repos/neithernut/waysome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neithernut/waysome/statuses/{sha}","languages_url":"https://api.github.com/repos/neithernut/waysome/languages","stargazers_url":"https://api.github.com/repos/neithernut/waysome/stargazers","contributors_url":"https://api.github.com/repos/neithernut/waysome/contributors","subscribers_url":"https://api.github.com/repos/neithernut/waysome/subscribers","subscription_url":"https://api.github.com/repos/neithernut/waysome/subscription","commits_url":"https://api.github.com/repos/neithernut/waysome/commits{/sha}","git_commits_url":"https://api.github.com/repos/neithernut/waysome/git/commits{/sha}","comments_url":"https://api.github.com/repos/neithernut/waysome/comments{/number}","issue_comment_url":"https://api.github.com/repos/neithernut/waysome/issues/comments/{number}","contents_url":"https://api.github.com/repos/neithernut/waysome/contents/{+path}","compare_url":"https://api.github.com/repos/neithernut/waysome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neithernut/waysome/merges","archive_url":"https://api.github.com/repos/neithernut/waysome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neithernut/waysome/downloads","issues_url":"https://api.github.com/repos/neithernut/waysome/issues{/number}","pulls_url":"https://api.github.com/repos/neithernut/waysome/pulls{/number}","milestones_url":"https://api.github.com/repos/neithernut/waysome/milestones{/number}","notifications_url":"https://api.github.com/repos/neithernut/waysome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neithernut/waysome/labels{/name}","releases_url":"https://api.github.com/repos/neithernut/waysome/releases{/id}","created_at":"2014-09-28T22:26:23Z","updated_at":"2014-09-29T11:33:55Z","pushed_at":"2014-11-03T22:17:56Z","git_url":"git://github.com/neithernut/waysome.git","ssh_url":"git@github.com:neithernut/waysome.git","clone_url":"https://github.com/neithernut/waysome.git","svn_url":"https://github.com/neithernut/waysome","homepage":null,"size":2322,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"waysome:develop","ref":"develop","sha":"498aedb320722a6e6f2064281b11c7839a3c5da9","user":{"login":"waysome","id":8951090,"avatar_url":"https://avatars.githubusercontent.com/u/8951090?v=2","gravatar_id":"","url":"https://api.github.com/users/waysome","html_url":"https://github.com/waysome","followers_url":"https://api.github.com/users/waysome/followers","following_url":"https://api.github.com/users/waysome/following{/other_user}","gists_url":"https://api.github.com/users/waysome/gists{/gist_id}","starred_url":"https://api.github.com/users/waysome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waysome/subscriptions","organizations_url":"https://api.github.com/users/waysome/orgs","repos_url":"https://api.github.com/users/waysome/repos","events_url":"https://api.github.com/users/waysome/events{/privacy}","received_events_url":"https://api.github.com/users/waysome/received_events","type":"Organization","site_admin":false},"repo":{"id":24571650,"name":"waysome","full_name":"waysome/waysome","owner":{"login":"waysome","id":8951090,"avatar_url":"https://avatars.githubusercontent.com/u/8951090?v=2","gravatar_id":"","url":"https://api.github.com/users/waysome","html_url":"https://github.com/waysome","followers_url":"https://api.github.com/users/waysome/followers","following_url":"https://api.github.com/users/waysome/following{/other_user}","gists_url":"https://api.github.com/users/waysome/gists{/gist_id}","starred_url":"https://api.github.com/users/waysome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waysome/subscriptions","organizations_url":"https://api.github.com/users/waysome/orgs","repos_url":"https://api.github.com/users/waysome/repos","events_url":"https://api.github.com/users/waysome/events{/privacy}","received_events_url":"https://api.github.com/users/waysome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/waysome/waysome","description":"Windowmanager for wayland","fork":false,"url":"https://api.github.com/repos/waysome/waysome","forks_url":"https://api.github.com/repos/waysome/waysome/forks","keys_url":"https://api.github.com/repos/waysome/waysome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waysome/waysome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waysome/waysome/teams","hooks_url":"https://api.github.com/repos/waysome/waysome/hooks","issue_events_url":"https://api.github.com/repos/waysome/waysome/issues/events{/number}","events_url":"https://api.github.com/repos/waysome/waysome/events","assignees_url":"https://api.github.com/repos/waysome/waysome/assignees{/user}","branches_url":"https://api.github.com/repos/waysome/waysome/branches{/branch}","tags_url":"https://api.github.com/repos/waysome/waysome/tags","blobs_url":"https://api.github.com/repos/waysome/waysome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waysome/waysome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waysome/waysome/git/refs{/sha}","trees_url":"https://api.github.com/repos/waysome/waysome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waysome/waysome/statuses/{sha}","languages_url":"https://api.github.com/repos/waysome/waysome/languages","stargazers_url":"https://api.github.com/repos/waysome/waysome/stargazers","contributors_url":"https://api.github.com/repos/waysome/waysome/contributors","subscribers_url":"https://api.github.com/repos/waysome/waysome/subscribers","subscription_url":"https://api.github.com/repos/waysome/waysome/subscription","commits_url":"https://api.github.com/repos/waysome/waysome/commits{/sha}","git_commits_url":"https://api.github.com/repos/waysome/waysome/git/commits{/sha}","comments_url":"https://api.github.com/repos/waysome/waysome/comments{/number}","issue_comment_url":"https://api.github.com/repos/waysome/waysome/issues/comments/{number}","contents_url":"https://api.github.com/repos/waysome/waysome/contents/{+path}","compare_url":"https://api.github.com/repos/waysome/waysome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waysome/waysome/merges","archive_url":"https://api.github.com/repos/waysome/waysome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waysome/waysome/downloads","issues_url":"https://api.github.com/repos/waysome/waysome/issues{/number}","pulls_url":"https://api.github.com/repos/waysome/waysome/pulls{/number}","milestones_url":"https://api.github.com/repos/waysome/waysome/milestones{/number}","notifications_url":"https://api.github.com/repos/waysome/waysome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waysome/waysome/labels{/name}","releases_url":"https://api.github.com/repos/waysome/waysome/releases{/id}","created_at":"2014-09-28T22:08:58Z","updated_at":"2014-10-10T00:04:46Z","pushed_at":"2014-11-03T16:28:39Z","git_url":"git://github.com/waysome/waysome.git","ssh_url":"git@github.com:waysome/waysome.git","clone_url":"https://github.com/waysome/waysome.git","svn_url":"https://github.com/waysome/waysome","homepage":null,"size":4943,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":31,"forks":5,"open_issues":31,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/waysome/waysome/pulls/340"},"html":{"href":"https://github.com/waysome/waysome/pull/340"},"issue":{"href":"https://api.github.com/repos/waysome/waysome/issues/340"},"comments":{"href":"https://api.github.com/repos/waysome/waysome/issues/340/comments"},"review_comments":{"href":"https://api.github.com/repos/waysome/waysome/pulls/340/comments"},"review_comment":{"href":"https://api.github.com/repos/waysome/waysome/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/waysome/waysome/pulls/340/commits"},"statuses":{"href":"https://api.github.com/repos/waysome/waysome/statuses/35b5ed6c9a74946d584f0c608abe6d72276cdcaf"}}}}