GitHub PullRequestReviewCommentEvent at 2014-12-05 20:16:58
Repository: OIPA
Actor: ngaranko
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/openaid-IATI/OIPA/pulls/comments/21397225","id":21397225,"diff_hunk":"@@ -146,3 +146,23 @@ def test_ActivityDateSerializer(self):\n             activity.end_actual should be serialized to a field called\n             end_actual by the ActivityDateSerializer\n             \"\"\"\n+\n+    def test_ActivitySerializerDynamicFields(self):\n+        activity = iati_factory.ActivityFactory.build(\n+            id='identifier',\n+            iati_identifier='iati-identifier'\n+        )\n+        fields = [\"id\"]","path":"OIPA/api/activity/tests/test_serializers.py","position":10,"original_position":10,"commit_id":"ad513db5f3904deaada463f206e4b9e225b5fd46","original_commit_id":"ad513db5f3904deaada463f206e4b9e225b5fd46","user":{"login":"ngaranko","id":370607,"avatar_url":"https://avatars.githubusercontent.com/u/370607?v=3","gravatar_id":"","url":"https://api.github.com/users/ngaranko","html_url":"https://github.com/ngaranko","followers_url":"https://api.github.com/users/ngaranko/followers","following_url":"https://api.github.com/users/ngaranko/following{/other_user}","gists_url":"https://api.github.com/users/ngaranko/gists{/gist_id}","starred_url":"https://api.github.com/users/ngaranko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngaranko/subscriptions","organizations_url":"https://api.github.com/users/ngaranko/orgs","repos_url":"https://api.github.com/users/ngaranko/repos","events_url":"https://api.github.com/users/ngaranko/events{/privacy}","received_events_url":"https://api.github.com/users/ngaranko/received_events","type":"User","site_admin":false},"body":"Please don't mix quotes, use either single or double.","created_at":"2014-12-05T20:16:58Z","updated_at":"2014-12-05T20:16:58Z","html_url":"https://github.com/openaid-IATI/OIPA/pull/61#discussion_r21397225","pull_request_url":"https://api.github.com/repos/openaid-IATI/OIPA/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/openaid-IATI/OIPA/pulls/comments/21397225"},"html":{"href":"https://github.com/openaid-IATI/OIPA/pull/61#discussion_r21397225"},"pull_request":{"href":"https://api.github.com/repos/openaid-IATI/OIPA/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/openaid-IATI/OIPA/pulls/61","id":25573364,"html_url":"https://github.com/openaid-IATI/OIPA/pull/61","diff_url":"https://github.com/openaid-IATI/OIPA/pull/61.diff","patch_url":"https://github.com/openaid-IATI/OIPA/pull/61.patch","issue_url":"https://api.github.com/repos/openaid-IATI/OIPA/issues/61","number":61,"state":"open","locked":false,"title":"Generic functionality to use to use serializers and views with 'fields=' parameter","user":{"login":"Murrx","id":1957070,"avatar_url":"https://avatars.githubusercontent.com/u/1957070?v=3","gravatar_id":"","url":"https://api.github.com/users/Murrx","html_url":"https://github.com/Murrx","followers_url":"https://api.github.com/users/Murrx/followers","following_url":"https://api.github.com/users/Murrx/following{/other_user}","gists_url":"https://api.github.com/users/Murrx/gists{/gist_id}","starred_url":"https://api.github.com/users/Murrx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Murrx/subscriptions","organizations_url":"https://api.github.com/users/Murrx/orgs","repos_url":"https://api.github.com/users/Murrx/repos","events_url":"https://api.github.com/users/Murrx/events{/privacy}","received_events_url":"https://api.github.com/users/Murrx/received_events","type":"User","site_admin":false},"body":"closes #35","created_at":"2014-12-05T14:20:26Z","updated_at":"2014-12-05T20:16:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4df1ef4d6bbe080edf9845843febf3373ae7c2be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openaid-IATI/OIPA/pulls/61/commits","review_comments_url":"https://api.github.com/repos/openaid-IATI/OIPA/pulls/61/comments","review_comment_url":"https://api.github.com/repos/openaid-IATI/OIPA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openaid-IATI/OIPA/issues/61/comments","statuses_url":"https://api.github.com/repos/openaid-IATI/OIPA/statuses/ad513db5f3904deaada463f206e4b9e225b5fd46","head":{"label":"vplme:activity-serializer","ref":"activity-serializer","sha":"ad513db5f3904deaada463f206e4b9e225b5fd46","user":{"login":"vplme","id":1703598,"avatar_url":"https://avatars.githubusercontent.com/u/1703598?v=3","gravatar_id":"","url":"https://api.github.com/users/vplme","html_url":"https://github.com/vplme","followers_url":"https://api.github.com/users/vplme/followers","following_url":"https://api.github.com/users/vplme/following{/other_user}","gists_url":"https://api.github.com/users/vplme/gists{/gist_id}","starred_url":"https://api.github.com/users/vplme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vplme/subscriptions","organizations_url":"https://api.github.com/users/vplme/orgs","repos_url":"https://api.github.com/users/vplme/repos","events_url":"https://api.github.com/users/vplme/events{/privacy}","received_events_url":"https://api.github.com/users/vplme/received_events","type":"User","site_admin":false},"repo":{"id":26974757,"name":"OIPA","full_name":"vplme/OIPA","owner":{"login":"vplme","id":1703598,"avatar_url":"https://avatars.githubusercontent.com/u/1703598?v=3","gravatar_id":"","url":"https://api.github.com/users/vplme","html_url":"https://github.com/vplme","followers_url":"https://api.github.com/users/vplme/followers","following_url":"https://api.github.com/users/vplme/following{/other_user}","gists_url":"https://api.github.com/users/vplme/gists{/gist_id}","starred_url":"https://api.github.com/users/vplme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vplme/subscriptions","organizations_url":"https://api.github.com/users/vplme/orgs","repos_url":"https://api.github.com/users/vplme/repos","events_url":"https://api.github.com/users/vplme/events{/privacy}","received_events_url":"https://api.github.com/users/vplme/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vplme/OIPA","description":"OIPA is an open-source framework that renders IATI compliant XML and related indicator #opendata into the OIPA datamodel for storage. This ETL approach provides I/O using the OIPA Tastypie RESTless API providing you with direct XML or JSON output. Does Django and MySQL. Codebase maintained by Zimmerman & Zimmerman in Amsterdam.","fork":true,"url":"https://api.github.com/repos/vplme/OIPA","forks_url":"https://api.github.com/repos/vplme/OIPA/forks","keys_url":"https://api.github.com/repos/vplme/OIPA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vplme/OIPA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vplme/OIPA/teams","hooks_url":"https://api.github.com/repos/vplme/OIPA/hooks","issue_events_url":"https://api.github.com/repos/vplme/OIPA/issues/events{/number}","events_url":"https://api.github.com/repos/vplme/OIPA/events","assignees_url":"https://api.github.com/repos/vplme/OIPA/assignees{/user}","branches_url":"https://api.github.com/repos/vplme/OIPA/branches{/branch}","tags_url":"https://api.github.com/repos/vplme/OIPA/tags","blobs_url":"https://api.github.com/repos/vplme/OIPA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vplme/OIPA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vplme/OIPA/git/refs{/sha}","trees_url":"https://api.github.com/repos/vplme/OIPA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vplme/OIPA/statuses/{sha}","languages_url":"https://api.github.com/repos/vplme/OIPA/languages","stargazers_url":"https://api.github.com/repos/vplme/OIPA/stargazers","contributors_url":"https://api.github.com/repos/vplme/OIPA/contributors","subscribers_url":"https://api.github.com/repos/vplme/OIPA/subscribers","subscription_url":"https://api.github.com/repos/vplme/OIPA/subscription","commits_url":"https://api.github.com/repos/vplme/OIPA/commits{/sha}","git_commits_url":"https://api.github.com/repos/vplme/OIPA/git/commits{/sha}","comments_url":"https://api.github.com/repos/vplme/OIPA/comments{/number}","issue_comment_url":"https://api.github.com/repos/vplme/OIPA/issues/comments/{number}","contents_url":"https://api.github.com/repos/vplme/OIPA/contents/{+path}","compare_url":"https://api.github.com/repos/vplme/OIPA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vplme/OIPA/merges","archive_url":"https://api.github.com/repos/vplme/OIPA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vplme/OIPA/downloads","issues_url":"https://api.github.com/repos/vplme/OIPA/issues{/number}","pulls_url":"https://api.github.com/repos/vplme/OIPA/pulls{/number}","milestones_url":"https://api.github.com/repos/vplme/OIPA/milestones{/number}","notifications_url":"https://api.github.com/repos/vplme/OIPA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vplme/OIPA/labels{/name}","releases_url":"https://api.github.com/repos/vplme/OIPA/releases{/id}","created_at":"2014-11-21T19:33:13Z","updated_at":"2014-11-21T19:33:14Z","pushed_at":"2014-12-05T14:13:47Z","git_url":"git://github.com/vplme/OIPA.git","ssh_url":"git@github.com:vplme/OIPA.git","clone_url":"https://github.com/vplme/OIPA.git","svn_url":"https://github.com/vplme/OIPA","homepage":"http://www.oipa.nl/","size":28372,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"openaid-IATI:develop","ref":"develop","sha":"f01c3340cccbdfa7d67bd9b58261833842c10e0c","user":{"login":"openaid-IATI","id":1477970,"avatar_url":"https://avatars.githubusercontent.com/u/1477970?v=3","gravatar_id":"","url":"https://api.github.com/users/openaid-IATI","html_url":"https://github.com/openaid-IATI","followers_url":"https://api.github.com/users/openaid-IATI/followers","following_url":"https://api.github.com/users/openaid-IATI/following{/other_user}","gists_url":"https://api.github.com/users/openaid-IATI/gists{/gist_id}","starred_url":"https://api.github.com/users/openaid-IATI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openaid-IATI/subscriptions","organizations_url":"https://api.github.com/users/openaid-IATI/orgs","repos_url":"https://api.github.com/users/openaid-IATI/repos","events_url":"https://api.github.com/users/openaid-IATI/events{/privacy}","received_events_url":"https://api.github.com/users/openaid-IATI/received_events","type":"Organization","site_admin":false},"repo":{"id":12760899,"name":"OIPA","full_name":"openaid-IATI/OIPA","owner":{"login":"openaid-IATI","id":1477970,"avatar_url":"https://avatars.githubusercontent.com/u/1477970?v=3","gravatar_id":"","url":"https://api.github.com/users/openaid-IATI","html_url":"https://github.com/openaid-IATI","followers_url":"https://api.github.com/users/openaid-IATI/followers","following_url":"https://api.github.com/users/openaid-IATI/following{/other_user}","gists_url":"https://api.github.com/users/openaid-IATI/gists{/gist_id}","starred_url":"https://api.github.com/users/openaid-IATI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openaid-IATI/subscriptions","organizations_url":"https://api.github.com/users/openaid-IATI/orgs","repos_url":"https://api.github.com/users/openaid-IATI/repos","events_url":"https://api.github.com/users/openaid-IATI/events{/privacy}","received_events_url":"https://api.github.com/users/openaid-IATI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openaid-IATI/OIPA","description":"OIPA is an open-source framework that renders IATI compliant XML and related indicator #opendata into the OIPA datamodel for storage. This ETL approach provides I/O using the OIPA Tastypie RESTless API providing you with direct XML or JSON output. Does Django and MySQL. Codebase maintained by Zimmerman & Zimmerman in Amsterdam.","fork":false,"url":"https://api.github.com/repos/openaid-IATI/OIPA","forks_url":"https://api.github.com/repos/openaid-IATI/OIPA/forks","keys_url":"https://api.github.com/repos/openaid-IATI/OIPA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openaid-IATI/OIPA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openaid-IATI/OIPA/teams","hooks_url":"https://api.github.com/repos/openaid-IATI/OIPA/hooks","issue_events_url":"https://api.github.com/repos/openaid-IATI/OIPA/issues/events{/number}","events_url":"https://api.github.com/repos/openaid-IATI/OIPA/events","assignees_url":"https://api.github.com/repos/openaid-IATI/OIPA/assignees{/user}","branches_url":"https://api.github.com/repos/openaid-IATI/OIPA/branches{/branch}","tags_url":"https://api.github.com/repos/openaid-IATI/OIPA/tags","blobs_url":"https://api.github.com/repos/openaid-IATI/OIPA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openaid-IATI/OIPA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openaid-IATI/OIPA/git/refs{/sha}","trees_url":"https://api.github.com/repos/openaid-IATI/OIPA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openaid-IATI/OIPA/statuses/{sha}","languages_url":"https://api.github.com/repos/openaid-IATI/OIPA/languages","stargazers_url":"https://api.github.com/repos/openaid-IATI/OIPA/stargazers","contributors_url":"https://api.github.com/repos/openaid-IATI/OIPA/contributors","subscribers_url":"https://api.github.com/repos/openaid-IATI/OIPA/subscribers","subscription_url":"https://api.github.com/repos/openaid-IATI/OIPA/subscription","commits_url":"https://api.github.com/repos/openaid-IATI/OIPA/commits{/sha}","git_commits_url":"https://api.github.com/repos/openaid-IATI/OIPA/git/commits{/sha}","comments_url":"https://api.github.com/repos/openaid-IATI/OIPA/comments{/number}","issue_comment_url":"https://api.github.com/repos/openaid-IATI/OIPA/issues/comments/{number}","contents_url":"https://api.github.com/repos/openaid-IATI/OIPA/contents/{+path}","compare_url":"https://api.github.com/repos/openaid-IATI/OIPA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openaid-IATI/OIPA/merges","archive_url":"https://api.github.com/repos/openaid-IATI/OIPA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openaid-IATI/OIPA/downloads","issues_url":"https://api.github.com/repos/openaid-IATI/OIPA/issues{/number}","pulls_url":"https://api.github.com/repos/openaid-IATI/OIPA/pulls{/number}","milestones_url":"https://api.github.com/repos/openaid-IATI/OIPA/milestones{/number}","notifications_url":"https://api.github.com/repos/openaid-IATI/OIPA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openaid-IATI/OIPA/labels{/name}","releases_url":"https://api.github.com/repos/openaid-IATI/OIPA/releases{/id}","created_at":"2013-09-11T16:06:24Z","updated_at":"2014-12-03T11:35:59Z","pushed_at":"2014-12-03T11:35:58Z","git_url":"git://github.com/openaid-IATI/OIPA.git","ssh_url":"git@github.com:openaid-IATI/OIPA.git","clone_url":"https://github.com/openaid-IATI/OIPA.git","svn_url":"https://github.com/openaid-IATI/OIPA","homepage":"http://www.oipa.nl/","size":34742,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":11,"forks":11,"open_issues":11,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/openaid-IATI/OIPA/pulls/61"},"html":{"href":"https://github.com/openaid-IATI/OIPA/pull/61"},"issue":{"href":"https://api.github.com/repos/openaid-IATI/OIPA/issues/61"},"comments":{"href":"https://api.github.com/repos/openaid-IATI/OIPA/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/openaid-IATI/OIPA/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/openaid-IATI/OIPA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openaid-IATI/OIPA/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/openaid-IATI/OIPA/statuses/ad513db5f3904deaada463f206e4b9e225b5fd46"}}}}