GitHub PullRequestEvent at 2014-06-22 15:06:30
Repository: accidentalbot
Actor: kylecronin
Payload: {"action":"opened","number":11,"pull_request":{"url":"https://api.github.com/repos/cliss/accidentalbot/pulls/11","id":17449066,"html_url":"https://github.com/cliss/accidentalbot/pull/11","diff_url":"https://github.com/cliss/accidentalbot/pull/11.diff","patch_url":"https://github.com/cliss/accidentalbot/pull/11.patch","issue_url":"https://api.github.com/repos/cliss/accidentalbot/issues/11","number":11,"state":"open","title":"making the bot work without a x-forwarded-for","user":{"login":"kylecronin","id":9188,"avatar_url":"https://avatars.githubusercontent.com/u/9188?","gravatar_id":"325e29323813381fff4f0ed5c986c98b","url":"https://api.github.com/users/kylecronin","html_url":"https://github.com/kylecronin","followers_url":"https://api.github.com/users/kylecronin/followers","following_url":"https://api.github.com/users/kylecronin/following{/other_user}","gists_url":"https://api.github.com/users/kylecronin/gists{/gist_id}","starred_url":"https://api.github.com/users/kylecronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylecronin/subscriptions","organizations_url":"https://api.github.com/users/kylecronin/orgs","repos_url":"https://api.github.com/users/kylecronin/repos","events_url":"https://api.github.com/users/kylecronin/events{/privacy}","received_events_url":"https://api.github.com/users/kylecronin/received_events","type":"User","site_admin":false},"body":"If the `PROXIED` environment variable doesn't exist, as it won't on systems that don't have it set, it naturally won't be equal to `false`, so `proxied` will be set to true. This causes an error later because the `x-fowarded-for` header won't exist, so calling split on it causes\r\n\r\n    TypeError: Cannot call method 'split' of undefined\r\n\r\nThis commit removes the environment variable and checks for the existence of `x-forwarded-for` in `request.headers` to determine whether or not the request is proxied.","created_at":"2014-06-22T15:06:29Z","updated_at":"2014-06-22T15:06:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9367dc5e124146e696bcf4b580626869b7261d23","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cliss/accidentalbot/pulls/11/commits","review_comments_url":"https://api.github.com/repos/cliss/accidentalbot/pulls/11/comments","review_comment_url":"https://api.github.com/repos/cliss/accidentalbot/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cliss/accidentalbot/issues/11/comments","statuses_url":"https://api.github.com/repos/cliss/accidentalbot/statuses/894d59d32390deb160e2d42a68c6974dca14a7f8","head":{"label":"kylecronin:no-proxy","ref":"no-proxy","sha":"894d59d32390deb160e2d42a68c6974dca14a7f8","user":{"login":"kylecronin","id":9188,"avatar_url":"https://avatars.githubusercontent.com/u/9188?","gravatar_id":"325e29323813381fff4f0ed5c986c98b","url":"https://api.github.com/users/kylecronin","html_url":"https://github.com/kylecronin","followers_url":"https://api.github.com/users/kylecronin/followers","following_url":"https://api.github.com/users/kylecronin/following{/other_user}","gists_url":"https://api.github.com/users/kylecronin/gists{/gist_id}","starred_url":"https://api.github.com/users/kylecronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylecronin/subscriptions","organizations_url":"https://api.github.com/users/kylecronin/orgs","repos_url":"https://api.github.com/users/kylecronin/repos","events_url":"https://api.github.com/users/kylecronin/events{/privacy}","received_events_url":"https://api.github.com/users/kylecronin/received_events","type":"User","site_admin":false},"repo":{"id":21087317,"name":"accidentalbot","full_name":"kylecronin/accidentalbot","owner":{"login":"kylecronin","id":9188,"avatar_url":"https://avatars.githubusercontent.com/u/9188?","gravatar_id":"325e29323813381fff4f0ed5c986c98b","url":"https://api.github.com/users/kylecronin","html_url":"https://github.com/kylecronin","followers_url":"https://api.github.com/users/kylecronin/followers","following_url":"https://api.github.com/users/kylecronin/following{/other_user}","gists_url":"https://api.github.com/users/kylecronin/gists{/gist_id}","starred_url":"https://api.github.com/users/kylecronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylecronin/subscriptions","organizations_url":"https://api.github.com/users/kylecronin/orgs","repos_url":"https://api.github.com/users/kylecronin/repos","events_url":"https://api.github.com/users/kylecronin/events{/privacy}","received_events_url":"https://api.github.com/users/kylecronin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kylecronin/accidentalbot","description":"Node/websockets based IRC bot","fork":true,"url":"https://api.github.com/repos/kylecronin/accidentalbot","forks_url":"https://api.github.com/repos/kylecronin/accidentalbot/forks","keys_url":"https://api.github.com/repos/kylecronin/accidentalbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kylecronin/accidentalbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kylecronin/accidentalbot/teams","hooks_url":"https://api.github.com/repos/kylecronin/accidentalbot/hooks","issue_events_url":"https://api.github.com/repos/kylecronin/accidentalbot/issues/events{/number}","events_url":"https://api.github.com/repos/kylecronin/accidentalbot/events","assignees_url":"https://api.github.com/repos/kylecronin/accidentalbot/assignees{/user}","branches_url":"https://api.github.com/repos/kylecronin/accidentalbot/branches{/branch}","tags_url":"https://api.github.com/repos/kylecronin/accidentalbot/tags","blobs_url":"https://api.github.com/repos/kylecronin/accidentalbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kylecronin/accidentalbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kylecronin/accidentalbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/kylecronin/accidentalbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kylecronin/accidentalbot/statuses/{sha}","languages_url":"https://api.github.com/repos/kylecronin/accidentalbot/languages","stargazers_url":"https://api.github.com/repos/kylecronin/accidentalbot/stargazers","contributors_url":"https://api.github.com/repos/kylecronin/accidentalbot/contributors","subscribers_url":"https://api.github.com/repos/kylecronin/accidentalbot/subscribers","subscription_url":"https://api.github.com/repos/kylecronin/accidentalbot/subscription","commits_url":"https://api.github.com/repos/kylecronin/accidentalbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/kylecronin/accidentalbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/kylecronin/accidentalbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/kylecronin/accidentalbot/issues/comments/{number}","contents_url":"https://api.github.com/repos/kylecronin/accidentalbot/contents/{+path}","compare_url":"https://api.github.com/repos/kylecronin/accidentalbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kylecronin/accidentalbot/merges","archive_url":"https://api.github.com/repos/kylecronin/accidentalbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kylecronin/accidentalbot/downloads","issues_url":"https://api.github.com/repos/kylecronin/accidentalbot/issues{/number}","pulls_url":"https://api.github.com/repos/kylecronin/accidentalbot/pulls{/number}","milestones_url":"https://api.github.com/repos/kylecronin/accidentalbot/milestones{/number}","notifications_url":"https://api.github.com/repos/kylecronin/accidentalbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kylecronin/accidentalbot/labels{/name}","releases_url":"https://api.github.com/repos/kylecronin/accidentalbot/releases{/id}","created_at":"2014-06-22T06:33:13Z","updated_at":"2014-06-22T15:06:29Z","pushed_at":"2014-06-22T15:00:25Z","git_url":"git://github.com/kylecronin/accidentalbot.git","ssh_url":"git@github.com:kylecronin/accidentalbot.git","clone_url":"https://github.com/kylecronin/accidentalbot.git","svn_url":"https://github.com/kylecronin/accidentalbot","homepage":null,"size":164,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cliss:master","ref":"master","sha":"bc330e8ce91022f26fac01118b0e59b9b05f7826","user":{"login":"cliss","id":282460,"avatar_url":"https://avatars.githubusercontent.com/u/282460?","gravatar_id":"f47a8e9dbec50eae57ecc99f8c089cde","url":"https://api.github.com/users/cliss","html_url":"https://github.com/cliss","followers_url":"https://api.github.com/users/cliss/followers","following_url":"https://api.github.com/users/cliss/following{/other_user}","gists_url":"https://api.github.com/users/cliss/gists{/gist_id}","starred_url":"https://api.github.com/users/cliss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliss/subscriptions","organizations_url":"https://api.github.com/users/cliss/orgs","repos_url":"https://api.github.com/users/cliss/repos","events_url":"https://api.github.com/users/cliss/events{/privacy}","received_events_url":"https://api.github.com/users/cliss/received_events","type":"User","site_admin":false},"repo":{"id":20111448,"name":"accidentalbot","full_name":"cliss/accidentalbot","owner":{"login":"cliss","id":282460,"avatar_url":"https://avatars.githubusercontent.com/u/282460?","gravatar_id":"f47a8e9dbec50eae57ecc99f8c089cde","url":"https://api.github.com/users/cliss","html_url":"https://github.com/cliss","followers_url":"https://api.github.com/users/cliss/followers","following_url":"https://api.github.com/users/cliss/following{/other_user}","gists_url":"https://api.github.com/users/cliss/gists{/gist_id}","starred_url":"https://api.github.com/users/cliss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliss/subscriptions","organizations_url":"https://api.github.com/users/cliss/orgs","repos_url":"https://api.github.com/users/cliss/repos","events_url":"https://api.github.com/users/cliss/events{/privacy}","received_events_url":"https://api.github.com/users/cliss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cliss/accidentalbot","description":"Node/websockets based IRC bot","fork":false,"url":"https://api.github.com/repos/cliss/accidentalbot","forks_url":"https://api.github.com/repos/cliss/accidentalbot/forks","keys_url":"https://api.github.com/repos/cliss/accidentalbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cliss/accidentalbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cliss/accidentalbot/teams","hooks_url":"https://api.github.com/repos/cliss/accidentalbot/hooks","issue_events_url":"https://api.github.com/repos/cliss/accidentalbot/issues/events{/number}","events_url":"https://api.github.com/repos/cliss/accidentalbot/events","assignees_url":"https://api.github.com/repos/cliss/accidentalbot/assignees{/user}","branches_url":"https://api.github.com/repos/cliss/accidentalbot/branches{/branch}","tags_url":"https://api.github.com/repos/cliss/accidentalbot/tags","blobs_url":"https://api.github.com/repos/cliss/accidentalbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cliss/accidentalbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cliss/accidentalbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/cliss/accidentalbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cliss/accidentalbot/statuses/{sha}","languages_url":"https://api.github.com/repos/cliss/accidentalbot/languages","stargazers_url":"https://api.github.com/repos/cliss/accidentalbot/stargazers","contributors_url":"https://api.github.com/repos/cliss/accidentalbot/contributors","subscribers_url":"https://api.github.com/repos/cliss/accidentalbot/subscribers","subscription_url":"https://api.github.com/repos/cliss/accidentalbot/subscription","commits_url":"https://api.github.com/repos/cliss/accidentalbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/cliss/accidentalbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/cliss/accidentalbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/cliss/accidentalbot/issues/comments/{number}","contents_url":"https://api.github.com/repos/cliss/accidentalbot/contents/{+path}","compare_url":"https://api.github.com/repos/cliss/accidentalbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cliss/accidentalbot/merges","archive_url":"https://api.github.com/repos/cliss/accidentalbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cliss/accidentalbot/downloads","issues_url":"https://api.github.com/repos/cliss/accidentalbot/issues{/number}","pulls_url":"https://api.github.com/repos/cliss/accidentalbot/pulls{/number}","milestones_url":"https://api.github.com/repos/cliss/accidentalbot/milestones{/number}","notifications_url":"https://api.github.com/repos/cliss/accidentalbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cliss/accidentalbot/labels{/name}","releases_url":"https://api.github.com/repos/cliss/accidentalbot/releases{/id}","created_at":"2014-05-23T19:23:20Z","updated_at":"2014-06-22T14:00:00Z","pushed_at":"2014-06-22T14:00:00Z","git_url":"git://github.com/cliss/accidentalbot.git","ssh_url":"git@github.com:cliss/accidentalbot.git","clone_url":"https://github.com/cliss/accidentalbot.git","svn_url":"https://github.com/cliss/accidentalbot","homepage":null,"size":164,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":9,"mirror_url":null,"open_issues_count":5,"forks":9,"open_issues":5,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cliss/accidentalbot/pulls/11"},"html":{"href":"https://github.com/cliss/accidentalbot/pull/11"},"issue":{"href":"https://api.github.com/repos/cliss/accidentalbot/issues/11"},"comments":{"href":"https://api.github.com/repos/cliss/accidentalbot/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/cliss/accidentalbot/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/cliss/accidentalbot/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cliss/accidentalbot/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/cliss/accidentalbot/statuses/894d59d32390deb160e2d42a68c6974dca14a7f8"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":2,"changed_files":1}}