GitHub PullRequestReviewCommentEvent at 2014-11-17 11:55:14
Repository: smartdown
Actor: camilleldn
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/smartdown/pulls/comments/20430842","id":20430842,"diff_hunk":"@@ -2,5 +2,30 @@\n   let(:text_string) { \"United Kingdom\" }\n   subject(:instance) { described_class.new(text_string) }\n \n-  specify { expect(instance.to_s).to eql(\"United Kingdom\") }\n+\n+  let(:answer_string) { \"country\" }\n+  subject(:answer) { described_class.new(answer_string, multiple_choice_question) }\n+  let(:multiple_choice_question) {\n+    Smartdown::Model::Element::Question::Country.new(\"question\",\n+                                                     {\"country\" => \"Lovely country\"}\n+    )\n+  }\n+\n+  describe \"#humanize\" do\n+    it \"returns the humanized answer\" do\n+      expect(answer.humanize).to eq \"Lovely country\"\n+    end\n+  end\n+\n+  describe \"errors\" do\n+    context \"format is incorrect\" do\n+      let(:answer_string) { \"kasjdf\" }\n+      specify { expect(answer.error).to eql \"Invalid country\" }\n+    end\n+","path":"spec/model/answer/country_spec.rb","position":25,"original_position":25,"commit_id":"a9393a88cb06f0615d65349124a542b0b8c64fc2","original_commit_id":"a9393a88cb06f0615d65349124a542b0b8c64fc2","user":{"login":"camilleldn","id":5455804,"avatar_url":"https://avatars.githubusercontent.com/u/5455804?v=3","gravatar_id":"","url":"https://api.github.com/users/camilleldn","html_url":"https://github.com/camilleldn","followers_url":"https://api.github.com/users/camilleldn/followers","following_url":"https://api.github.com/users/camilleldn/following{/other_user}","gists_url":"https://api.github.com/users/camilleldn/gists{/gist_id}","starred_url":"https://api.github.com/users/camilleldn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camilleldn/subscriptions","organizations_url":"https://api.github.com/users/camilleldn/orgs","repos_url":"https://api.github.com/users/camilleldn/repos","events_url":"https://api.github.com/users/camilleldn/events{/privacy}","received_events_url":"https://api.github.com/users/camilleldn/received_events","type":"User","site_admin":false},"body":":+1: thanks!","created_at":"2014-11-17T11:55:14Z","updated_at":"2014-11-17T11:55:14Z","html_url":"https://github.com/alphagov/smartdown/pull/95#discussion_r20430842","pull_request_url":"https://api.github.com/repos/alphagov/smartdown/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/alphagov/smartdown/pulls/comments/20430842"},"html":{"href":"https://github.com/alphagov/smartdown/pull/95#discussion_r20430842"},"pull_request":{"href":"https://api.github.com/repos/alphagov/smartdown/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/smartdown/pulls/95","id":24527941,"html_url":"https://github.com/alphagov/smartdown/pull/95","diff_url":"https://github.com/alphagov/smartdown/pull/95.diff","patch_url":"https://github.com/alphagov/smartdown/pull/95.patch","issue_url":"https://api.github.com/repos/alphagov/smartdown/issues/95","number":95,"state":"open","locked":false,"title":"Country questions [MERGE SECOND]","user":{"login":"FriedSock","id":823643,"avatar_url":"https://avatars.githubusercontent.com/u/823643?v=3","gravatar_id":"","url":"https://api.github.com/users/FriedSock","html_url":"https://github.com/FriedSock","followers_url":"https://api.github.com/users/FriedSock/followers","following_url":"https://api.github.com/users/FriedSock/following{/other_user}","gists_url":"https://api.github.com/users/FriedSock/gists{/gist_id}","starred_url":"https://api.github.com/users/FriedSock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriedSock/subscriptions","organizations_url":"https://api.github.com/users/FriedSock/orgs","repos_url":"https://api.github.com/users/FriedSock/repos","events_url":"https://api.github.com/users/FriedSock/events{/privacy}","received_events_url":"https://api.github.com/users/FriedSock/received_events","type":"User","site_admin":false},"body":"The second half of the original country question PR\r\n\r\nplease un-revert the premature merge of this branch first https://github.com/alphagov/smartdown/pull/94\r\n\r\nThe original branch is here, for context: https://github.com/alphagov/smartdown/pull/92\r\n\r\n","created_at":"2014-11-17T11:00:17Z","updated_at":"2014-11-17T11:55:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8043da666414303b37546cf2fe5ad9a5f1c80a1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/smartdown/pulls/95/commits","review_comments_url":"https://api.github.com/repos/alphagov/smartdown/pulls/95/comments","review_comment_url":"https://api.github.com/repos/alphagov/smartdown/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/smartdown/issues/95/comments","statuses_url":"https://api.github.com/repos/alphagov/smartdown/statuses/a9393a88cb06f0615d65349124a542b0b8c64fc2","head":{"label":"alphagov:country_questions","ref":"country_questions","sha":"a9393a88cb06f0615d65349124a542b0b8c64fc2","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":20447918,"name":"smartdown","full_name":"alphagov/smartdown","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/smartdown","description":"Experimental new smart answers framework with markdown-like external DSL","fork":false,"url":"https://api.github.com/repos/alphagov/smartdown","forks_url":"https://api.github.com/repos/alphagov/smartdown/forks","keys_url":"https://api.github.com/repos/alphagov/smartdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/smartdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/smartdown/teams","hooks_url":"https://api.github.com/repos/alphagov/smartdown/hooks","issue_events_url":"https://api.github.com/repos/alphagov/smartdown/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/smartdown/events","assignees_url":"https://api.github.com/repos/alphagov/smartdown/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/smartdown/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/smartdown/tags","blobs_url":"https://api.github.com/repos/alphagov/smartdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/smartdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/smartdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/smartdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/smartdown/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/smartdown/languages","stargazers_url":"https://api.github.com/repos/alphagov/smartdown/stargazers","contributors_url":"https://api.github.com/repos/alphagov/smartdown/contributors","subscribers_url":"https://api.github.com/repos/alphagov/smartdown/subscribers","subscription_url":"https://api.github.com/repos/alphagov/smartdown/subscription","commits_url":"https://api.github.com/repos/alphagov/smartdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/smartdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/smartdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/smartdown/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/smartdown/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/smartdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/smartdown/merges","archive_url":"https://api.github.com/repos/alphagov/smartdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/smartdown/downloads","issues_url":"https://api.github.com/repos/alphagov/smartdown/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/smartdown/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/smartdown/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/smartdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/smartdown/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/smartdown/releases{/id}","created_at":"2014-06-03T15:19:41Z","updated_at":"2014-11-06T15:52:40Z","pushed_at":"2014-11-17T11:54:18Z","git_url":"git://github.com/alphagov/smartdown.git","ssh_url":"git@github.com:alphagov/smartdown.git","clone_url":"https://github.com/alphagov/smartdown.git","svn_url":"https://github.com/alphagov/smartdown","homepage":null,"size":3259,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":10,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"d2a1d8fed9413c8d365227b8bd1df47b9586754c","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":20447918,"name":"smartdown","full_name":"alphagov/smartdown","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/smartdown","description":"Experimental new smart answers framework with markdown-like external DSL","fork":false,"url":"https://api.github.com/repos/alphagov/smartdown","forks_url":"https://api.github.com/repos/alphagov/smartdown/forks","keys_url":"https://api.github.com/repos/alphagov/smartdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/smartdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/smartdown/teams","hooks_url":"https://api.github.com/repos/alphagov/smartdown/hooks","issue_events_url":"https://api.github.com/repos/alphagov/smartdown/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/smartdown/events","assignees_url":"https://api.github.com/repos/alphagov/smartdown/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/smartdown/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/smartdown/tags","blobs_url":"https://api.github.com/repos/alphagov/smartdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/smartdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/smartdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/smartdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/smartdown/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/smartdown/languages","stargazers_url":"https://api.github.com/repos/alphagov/smartdown/stargazers","contributors_url":"https://api.github.com/repos/alphagov/smartdown/contributors","subscribers_url":"https://api.github.com/repos/alphagov/smartdown/subscribers","subscription_url":"https://api.github.com/repos/alphagov/smartdown/subscription","commits_url":"https://api.github.com/repos/alphagov/smartdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/smartdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/smartdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/smartdown/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/smartdown/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/smartdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/smartdown/merges","archive_url":"https://api.github.com/repos/alphagov/smartdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/smartdown/downloads","issues_url":"https://api.github.com/repos/alphagov/smartdown/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/smartdown/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/smartdown/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/smartdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/smartdown/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/smartdown/releases{/id}","created_at":"2014-06-03T15:19:41Z","updated_at":"2014-11-06T15:52:40Z","pushed_at":"2014-11-17T11:54:18Z","git_url":"git://github.com/alphagov/smartdown.git","ssh_url":"git@github.com:alphagov/smartdown.git","clone_url":"https://github.com/alphagov/smartdown.git","svn_url":"https://github.com/alphagov/smartdown","homepage":null,"size":3259,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/smartdown/pulls/95"},"html":{"href":"https://github.com/alphagov/smartdown/pull/95"},"issue":{"href":"https://api.github.com/repos/alphagov/smartdown/issues/95"},"comments":{"href":"https://api.github.com/repos/alphagov/smartdown/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/smartdown/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/smartdown/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/smartdown/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/smartdown/statuses/a9393a88cb06f0615d65349124a542b0b8c64fc2"}}}}