GitHub PushEvent at 2014-09-29 19:51:27
Repository: chapel
Actor: bradcray
Payload: {"shas":[["a5d04fef8e38fcf1000563ad4df3f1dca930c8da","76b11d3d92bad7a642f7c1b15d8a810ff35b7019@users.noreply.github.com","Found and fixed a bug in the glob() routine\n\nIt turns out that when I moved Tim's glob() routine into the\nFilerator.chpl module, I changed a c_int return type of\nchpl_glob_num() to a size_t to better reflect the C interface.\nHowever, in doing so, I also introduced an error because we iterated\nover the range:\n\n     0..chpl_glob_num(...)-1\n\nwhich, for a glob() call with no matches, resulted in:\n\n     0..0:uint(64)-1\n\nor:\n\n     0..max(uint(64))\n\nwhich is a range that we generate overflow warnings for.  In Tim's\noriginal code, this just resulted in 0..-1 which wasn't an issue.\n\nThis commit fixes the bug by checking against '0' before entering the\nloop over the range.  It also files a few test cases that exercised\nthe bug and updates the output of the globberator.good file to\nreflect the new tests.","Brad Chamberlain",true],["54ae25000de818123e19a820c285836266fab3f5","76b11d3d92bad7a642f7c1b15d8a810ff35b7019@users.noreply.github.com","Merge pull request #580 from bradcray/glob-fixes\n\nFound and fixed a bug in the glob() routine\r\n\r\nIt turns out that when I moved Tim's glob() routine into the\r\nFilerator.chpl module, I changed a c_int return type of\r\nchpl_glob_num() to a size_t to better reflect the C interface.\r\nHowever, in doing so, I also introduced an error because we iterated\r\nover the range:\r\n\r\n     0..chpl_glob_num(...)-1\r\n\r\nwhich, for a glob() call with no matches, resulted in:\r\n\r\n     0..0:uint(64)-1\r\n\r\nor:\r\n\r\n     0..max(uint(64))\r\n\r\nwhich is a range that we generate overflow warnings for.  In Tim's\r\noriginal code, this just resulted in 0..-1 which wasn't an issue.\r\n\r\nThis commit fixes the bug by checking against '0' before entering the\r\nloop over the range.  It also files a few test cases that exercised\r\nthe bug and updates the output of the globberator.good file to\r\nreflect the new tests.","Brad Chamberlain",true]],"size":2,"ref":"refs/heads/master","head":"54ae25000de818123e19a820c285836266fab3f5"}