GitHub PullRequestReviewCommentEvent at 2014-07-29 21:49:27
Repository: plotly
Actor: xsaintmleux
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ropensci/plotly/pulls/comments/15554887","id":15554887,"diff_hunk":"@@ -125,10 +125,15 @@ For more help, see https://plot.ly/R or contact <chris@plot.ly>.\")\n       stop(\"gg must be a ggplot\")\n     }\n     pargs <- gg2list(gg)\n+    if (!length(kwargs$auto_open)) {","path":"R/plotly.R","position":4,"original_position":4,"commit_id":"6a46ae6290cbab515d8ceb243d44549741825281","original_commit_id":"6a46ae6290cbab515d8ceb243d44549741825281","user":{"login":"xsaintmleux","id":7672485,"avatar_url":"https://avatars.githubusercontent.com/u/7672485?","gravatar_id":"b953cc0ec5bdb2e9920b7958bb2ad544","url":"https://api.github.com/users/xsaintmleux","html_url":"https://github.com/xsaintmleux","followers_url":"https://api.github.com/users/xsaintmleux/followers","following_url":"https://api.github.com/users/xsaintmleux/following{/other_user}","gists_url":"https://api.github.com/users/xsaintmleux/gists{/gist_id}","starred_url":"https://api.github.com/users/xsaintmleux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsaintmleux/subscriptions","organizations_url":"https://api.github.com/users/xsaintmleux/orgs","repos_url":"https://api.github.com/users/xsaintmleux/repos","events_url":"https://api.github.com/users/xsaintmleux/events{/privacy}","received_events_url":"https://api.github.com/users/xsaintmleux/received_events","type":"User","site_admin":false},"body":"Why not check for \r\n```R\r\n!\"auto_open\" %in% names(kwargs)\r\n```?  \r\nThere are many values other than NULL that have zero-length.  Also, `$` does partial matching which can be a problem especially when testing for the existence of an element.  E.g: \r\n```R\r\n> zz <- list(item=1:3)\r\n> length(zz$i)\r\n[1] 3\r\n```\r\n\r\n\r\n\r\n","created_at":"2014-07-29T21:49:27Z","updated_at":"2014-07-29T21:49:27Z","html_url":"https://github.com/ropensci/plotly/pull/67#discussion_r15554887","pull_request_url":"https://api.github.com/repos/ropensci/plotly/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/ropensci/plotly/pulls/comments/15554887"},"html":{"href":"https://github.com/ropensci/plotly/pull/67#discussion_r15554887"},"pull_request":{"href":"https://api.github.com/repos/ropensci/plotly/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/ropensci/plotly/pulls/67","id":19047222,"html_url":"https://github.com/ropensci/plotly/pull/67","diff_url":"https://github.com/ropensci/plotly/pull/67.diff","patch_url":"https://github.com/ropensci/plotly/pull/67.patch","issue_url":"https://api.github.com/repos/ropensci/plotly/issues/67","number":67,"state":"open","title":"Let auto_open=FALSE work if interactive()","user":{"login":"mkcor","id":2227806,"avatar_url":"https://avatars.githubusercontent.com/u/2227806?","gravatar_id":null,"url":"https://api.github.com/users/mkcor","html_url":"https://github.com/mkcor","followers_url":"https://api.github.com/users/mkcor/followers","following_url":"https://api.github.com/users/mkcor/following{/other_user}","gists_url":"https://api.github.com/users/mkcor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkcor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkcor/subscriptions","organizations_url":"https://api.github.com/users/mkcor/orgs","repos_url":"https://api.github.com/users/mkcor/repos","events_url":"https://api.github.com/users/mkcor/events{/privacy}","received_events_url":"https://api.github.com/users/mkcor/received_events","type":"User","site_admin":false},"body":"`auto_open=TRUE` being the default.","created_at":"2014-07-29T19:02:14Z","updated_at":"2014-07-29T21:49:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dea2ead7329a59f1248cfd271507a65e271f61f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ropensci/plotly/pulls/67/commits","review_comments_url":"https://api.github.com/repos/ropensci/plotly/pulls/67/comments","review_comment_url":"https://api.github.com/repos/ropensci/plotly/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ropensci/plotly/issues/67/comments","statuses_url":"https://api.github.com/repos/ropensci/plotly/statuses/6a46ae6290cbab515d8ceb243d44549741825281","head":{"label":"ropensci:marianne-privacy-option","ref":"marianne-privacy-option","sha":"6a46ae6290cbab515d8ceb243d44549741825281","user":{"login":"ropensci","id":1200269,"avatar_url":"https://avatars.githubusercontent.com/u/1200269?","gravatar_id":"4ddbcde2b063a929b73ddbea7b3a2ffd","url":"https://api.github.com/users/ropensci","html_url":"https://github.com/ropensci","followers_url":"https://api.github.com/users/ropensci/followers","following_url":"https://api.github.com/users/ropensci/following{/other_user}","gists_url":"https://api.github.com/users/ropensci/gists{/gist_id}","starred_url":"https://api.github.com/users/ropensci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropensci/subscriptions","organizations_url":"https://api.github.com/users/ropensci/orgs","repos_url":"https://api.github.com/users/ropensci/repos","events_url":"https://api.github.com/users/ropensci/events{/privacy}","received_events_url":"https://api.github.com/users/ropensci/received_events","type":"Organization","site_admin":false},"repo":{"id":14579179,"name":"plotly","full_name":"ropensci/plotly","owner":{"login":"ropensci","id":1200269,"avatar_url":"https://avatars.githubusercontent.com/u/1200269?","gravatar_id":"4ddbcde2b063a929b73ddbea7b3a2ffd","url":"https://api.github.com/users/ropensci","html_url":"https://github.com/ropensci","followers_url":"https://api.github.com/users/ropensci/followers","following_url":"https://api.github.com/users/ropensci/following{/other_user}","gists_url":"https://api.github.com/users/ropensci/gists{/gist_id}","starred_url":"https://api.github.com/users/ropensci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropensci/subscriptions","organizations_url":"https://api.github.com/users/ropensci/orgs","repos_url":"https://api.github.com/users/ropensci/repos","events_url":"https://api.github.com/users/ropensci/events{/privacy}","received_events_url":"https://api.github.com/users/ropensci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ropensci/plotly","description":"R-API for beautiful, interactive, & shareable graphs ","fork":false,"url":"https://api.github.com/repos/ropensci/plotly","forks_url":"https://api.github.com/repos/ropensci/plotly/forks","keys_url":"https://api.github.com/repos/ropensci/plotly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ropensci/plotly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ropensci/plotly/teams","hooks_url":"https://api.github.com/repos/ropensci/plotly/hooks","issue_events_url":"https://api.github.com/repos/ropensci/plotly/issues/events{/number}","events_url":"https://api.github.com/repos/ropensci/plotly/events","assignees_url":"https://api.github.com/repos/ropensci/plotly/assignees{/user}","branches_url":"https://api.github.com/repos/ropensci/plotly/branches{/branch}","tags_url":"https://api.github.com/repos/ropensci/plotly/tags","blobs_url":"https://api.github.com/repos/ropensci/plotly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ropensci/plotly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ropensci/plotly/git/refs{/sha}","trees_url":"https://api.github.com/repos/ropensci/plotly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ropensci/plotly/statuses/{sha}","languages_url":"https://api.github.com/repos/ropensci/plotly/languages","stargazers_url":"https://api.github.com/repos/ropensci/plotly/stargazers","contributors_url":"https://api.github.com/repos/ropensci/plotly/contributors","subscribers_url":"https://api.github.com/repos/ropensci/plotly/subscribers","subscription_url":"https://api.github.com/repos/ropensci/plotly/subscription","commits_url":"https://api.github.com/repos/ropensci/plotly/commits{/sha}","git_commits_url":"https://api.github.com/repos/ropensci/plotly/git/commits{/sha}","comments_url":"https://api.github.com/repos/ropensci/plotly/comments{/number}","issue_comment_url":"https://api.github.com/repos/ropensci/plotly/issues/comments/{number}","contents_url":"https://api.github.com/repos/ropensci/plotly/contents/{+path}","compare_url":"https://api.github.com/repos/ropensci/plotly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ropensci/plotly/merges","archive_url":"https://api.github.com/repos/ropensci/plotly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ropensci/plotly/downloads","issues_url":"https://api.github.com/repos/ropensci/plotly/issues{/number}","pulls_url":"https://api.github.com/repos/ropensci/plotly/pulls{/number}","milestones_url":"https://api.github.com/repos/ropensci/plotly/milestones{/number}","notifications_url":"https://api.github.com/repos/ropensci/plotly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ropensci/plotly/labels{/name}","releases_url":"https://api.github.com/repos/ropensci/plotly/releases{/id}","created_at":"2013-11-21T05:56:51Z","updated_at":"2014-07-25T19:56:15Z","pushed_at":"2014-07-29T19:01:34Z","git_url":"git://github.com/ropensci/plotly.git","ssh_url":"git@github.com:ropensci/plotly.git","clone_url":"https://github.com/ropensci/plotly.git","svn_url":"https://github.com/ropensci/plotly","homepage":"https://plot.ly/api/r","size":4327,"stargazers_count":72,"watchers_count":72,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":13,"mirror_url":null,"open_issues_count":29,"forks":13,"open_issues":29,"watchers":72,"default_branch":"master"}},"base":{"label":"ropensci:master","ref":"master","sha":"974eff2f72615e3dd5ea4615e581faa6556a957f","user":{"login":"ropensci","id":1200269,"avatar_url":"https://avatars.githubusercontent.com/u/1200269?","gravatar_id":"4ddbcde2b063a929b73ddbea7b3a2ffd","url":"https://api.github.com/users/ropensci","html_url":"https://github.com/ropensci","followers_url":"https://api.github.com/users/ropensci/followers","following_url":"https://api.github.com/users/ropensci/following{/other_user}","gists_url":"https://api.github.com/users/ropensci/gists{/gist_id}","starred_url":"https://api.github.com/users/ropensci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropensci/subscriptions","organizations_url":"https://api.github.com/users/ropensci/orgs","repos_url":"https://api.github.com/users/ropensci/repos","events_url":"https://api.github.com/users/ropensci/events{/privacy}","received_events_url":"https://api.github.com/users/ropensci/received_events","type":"Organization","site_admin":false},"repo":{"id":14579179,"name":"plotly","full_name":"ropensci/plotly","owner":{"login":"ropensci","id":1200269,"avatar_url":"https://avatars.githubusercontent.com/u/1200269?","gravatar_id":"4ddbcde2b063a929b73ddbea7b3a2ffd","url":"https://api.github.com/users/ropensci","html_url":"https://github.com/ropensci","followers_url":"https://api.github.com/users/ropensci/followers","following_url":"https://api.github.com/users/ropensci/following{/other_user}","gists_url":"https://api.github.com/users/ropensci/gists{/gist_id}","starred_url":"https://api.github.com/users/ropensci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropensci/subscriptions","organizations_url":"https://api.github.com/users/ropensci/orgs","repos_url":"https://api.github.com/users/ropensci/repos","events_url":"https://api.github.com/users/ropensci/events{/privacy}","received_events_url":"https://api.github.com/users/ropensci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ropensci/plotly","description":"R-API for beautiful, interactive, & shareable graphs ","fork":false,"url":"https://api.github.com/repos/ropensci/plotly","forks_url":"https://api.github.com/repos/ropensci/plotly/forks","keys_url":"https://api.github.com/repos/ropensci/plotly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ropensci/plotly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ropensci/plotly/teams","hooks_url":"https://api.github.com/repos/ropensci/plotly/hooks","issue_events_url":"https://api.github.com/repos/ropensci/plotly/issues/events{/number}","events_url":"https://api.github.com/repos/ropensci/plotly/events","assignees_url":"https://api.github.com/repos/ropensci/plotly/assignees{/user}","branches_url":"https://api.github.com/repos/ropensci/plotly/branches{/branch}","tags_url":"https://api.github.com/repos/ropensci/plotly/tags","blobs_url":"https://api.github.com/repos/ropensci/plotly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ropensci/plotly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ropensci/plotly/git/refs{/sha}","trees_url":"https://api.github.com/repos/ropensci/plotly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ropensci/plotly/statuses/{sha}","languages_url":"https://api.github.com/repos/ropensci/plotly/languages","stargazers_url":"https://api.github.com/repos/ropensci/plotly/stargazers","contributors_url":"https://api.github.com/repos/ropensci/plotly/contributors","subscribers_url":"https://api.github.com/repos/ropensci/plotly/subscribers","subscription_url":"https://api.github.com/repos/ropensci/plotly/subscription","commits_url":"https://api.github.com/repos/ropensci/plotly/commits{/sha}","git_commits_url":"https://api.github.com/repos/ropensci/plotly/git/commits{/sha}","comments_url":"https://api.github.com/repos/ropensci/plotly/comments{/number}","issue_comment_url":"https://api.github.com/repos/ropensci/plotly/issues/comments/{number}","contents_url":"https://api.github.com/repos/ropensci/plotly/contents/{+path}","compare_url":"https://api.github.com/repos/ropensci/plotly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ropensci/plotly/merges","archive_url":"https://api.github.com/repos/ropensci/plotly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ropensci/plotly/downloads","issues_url":"https://api.github.com/repos/ropensci/plotly/issues{/number}","pulls_url":"https://api.github.com/repos/ropensci/plotly/pulls{/number}","milestones_url":"https://api.github.com/repos/ropensci/plotly/milestones{/number}","notifications_url":"https://api.github.com/repos/ropensci/plotly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ropensci/plotly/labels{/name}","releases_url":"https://api.github.com/repos/ropensci/plotly/releases{/id}","created_at":"2013-11-21T05:56:51Z","updated_at":"2014-07-25T19:56:15Z","pushed_at":"2014-07-29T19:01:34Z","git_url":"git://github.com/ropensci/plotly.git","ssh_url":"git@github.com:ropensci/plotly.git","clone_url":"https://github.com/ropensci/plotly.git","svn_url":"https://github.com/ropensci/plotly","homepage":"https://plot.ly/api/r","size":4327,"stargazers_count":72,"watchers_count":72,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":13,"mirror_url":null,"open_issues_count":29,"forks":13,"open_issues":29,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ropensci/plotly/pulls/67"},"html":{"href":"https://github.com/ropensci/plotly/pull/67"},"issue":{"href":"https://api.github.com/repos/ropensci/plotly/issues/67"},"comments":{"href":"https://api.github.com/repos/ropensci/plotly/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/ropensci/plotly/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/ropensci/plotly/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ropensci/plotly/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/ropensci/plotly/statuses/6a46ae6290cbab515d8ceb243d44549741825281"}}}}