GitHub PullRequestReviewCommentEvent at 2014-06-09 05:26:00
Repository: tizen-extensions-crosswalk
Actor: deqing
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/13529712","id":13529712,"diff_hunk":"@@ -0,0 +1,93 @@\n+// Copyright (c) 2014 Intel Corporation. All rights reserved.\n+// Use of this source code is governed by a BSD-style license that can be\n+// found in the LICENSE file.\n+\n+#ifndef PHONE_PHONE_INSTANCE_H_\n+#define PHONE_PHONE_INSTANCE_H_\n+\n+#include <gio/gio.h>\n+#include <string>\n+#include <thread>            // NOLINT\n+#include \"common/extension.h\"\n+#include \"common/picojson.h\"\n+#include \"tizen/tizen.h\"\n+\n+namespace std {\n+  class thread;","path":"phone/phone_instance.h","position":16,"original_position":16,"commit_id":"472fb7f21d7fa717a6e1ca4e25261c730c9b09d8","original_commit_id":"472fb7f21d7fa717a6e1ca4e25261c730c9b09d8","user":{"login":"deqing","id":1152174,"avatar_url":"https://avatars.githubusercontent.com/u/1152174?","gravatar_id":"8028a6a5008b0f8ccea391fb276a4000","url":"https://api.github.com/users/deqing","html_url":"https://github.com/deqing","followers_url":"https://api.github.com/users/deqing/followers","following_url":"https://api.github.com/users/deqing/following{/other_user}","gists_url":"https://api.github.com/users/deqing/gists{/gist_id}","starred_url":"https://api.github.com/users/deqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deqing/subscriptions","organizations_url":"https://api.github.com/users/deqing/orgs","repos_url":"https://api.github.com/users/deqing/repos","events_url":"https://api.github.com/users/deqing/events{/privacy}","received_events_url":"https://api.github.com/users/deqing/received_events","type":"User","site_admin":false},"body":"Is it necessary to add declaration `thread` to `std`?\r\nI think it is already in `std`.","created_at":"2014-06-09T05:26:00Z","updated_at":"2014-06-09T05:26:00Z","html_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/319#discussion_r13529712","pull_request_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/319","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/13529712"},"html":{"href":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/319#discussion_r13529712"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/319"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/319","id":16554988,"html_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/319","diff_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/319.diff","patch_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/319.patch","issue_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/319","number":319,"state":"open","title":"[Phone] Added IVI Phone support","user":{"login":"jimmy-huang","id":1037247,"avatar_url":"https://avatars.githubusercontent.com/u/1037247?","gravatar_id":"a8b57e18899907d7d738d276bcf4016d","url":"https://api.github.com/users/jimmy-huang","html_url":"https://github.com/jimmy-huang","followers_url":"https://api.github.com/users/jimmy-huang/followers","following_url":"https://api.github.com/users/jimmy-huang/following{/other_user}","gists_url":"https://api.github.com/users/jimmy-huang/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmy-huang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmy-huang/subscriptions","organizations_url":"https://api.github.com/users/jimmy-huang/orgs","repos_url":"https://api.github.com/users/jimmy-huang/repos","events_url":"https://api.github.com/users/jimmy-huang/events{/privacy}","received_events_url":"https://api.github.com/users/jimmy-huang/received_events","type":"User","site_admin":false},"body":"This extension implements the phone interfaces for IVI using phoned.\r\nIt replaces the existing wrt-plugins-ivi-hfp used by Modello home screen.\r\n\r\nIt implements the following api:\r\n\r\n- selectRemoteDevice()\r\n- unselectRemoteDevice()\r\n- getSelectedRemoteDevice()\r\n- invokeCall()\r\n- answerCall()\r\n- hangupCall()\r\n- activeCall()\r\n- muteCall()\r\n- getContacts()\r\n- getCallHistory()\r\n- addRemoteDeviceSelectedListener()\r\n- removeRemoteDeviceSelectedListener()\r\n- addCallChangedListener()\r\n- removeCallChangedListener()\r\n- addCallHistoryEntryAddedListener()\r\n- removeCallHistoryEntryAddedListener()\r\n- addCallHistoryChangedListener()\r\n- removeCallHistoryChangedListener()\r\n- addContactsChangedListener()\r\n- removeContactsChangedListener()\r\n\r\nSigned-off-by: Jimmy Huang <jimmy.huang@intel.com>","created_at":"2014-05-30T21:05:12Z","updated_at":"2014-06-09T05:26:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca5d26b12dff5f99deb1f00ef605a91193376ad0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/319/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/319/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/319/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/statuses/472fb7f21d7fa717a6e1ca4e25261c730c9b09d8","head":{"label":"jimmy-huang:master","ref":"master","sha":"472fb7f21d7fa717a6e1ca4e25261c730c9b09d8","user":{"login":"jimmy-huang","id":1037247,"avatar_url":"https://avatars.githubusercontent.com/u/1037247?","gravatar_id":"a8b57e18899907d7d738d276bcf4016d","url":"https://api.github.com/users/jimmy-huang","html_url":"https://github.com/jimmy-huang","followers_url":"https://api.github.com/users/jimmy-huang/followers","following_url":"https://api.github.com/users/jimmy-huang/following{/other_user}","gists_url":"https://api.github.com/users/jimmy-huang/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmy-huang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmy-huang/subscriptions","organizations_url":"https://api.github.com/users/jimmy-huang/orgs","repos_url":"https://api.github.com/users/jimmy-huang/repos","events_url":"https://api.github.com/users/jimmy-huang/events{/privacy}","received_events_url":"https://api.github.com/users/jimmy-huang/received_events","type":"User","site_admin":false},"repo":{"id":19503097,"name":"tizen-extensions-crosswalk","full_name":"jimmy-huang/tizen-extensions-crosswalk","owner":{"login":"jimmy-huang","id":1037247,"avatar_url":"https://avatars.githubusercontent.com/u/1037247?","gravatar_id":"a8b57e18899907d7d738d276bcf4016d","url":"https://api.github.com/users/jimmy-huang","html_url":"https://github.com/jimmy-huang","followers_url":"https://api.github.com/users/jimmy-huang/followers","following_url":"https://api.github.com/users/jimmy-huang/following{/other_user}","gists_url":"https://api.github.com/users/jimmy-huang/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmy-huang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmy-huang/subscriptions","organizations_url":"https://api.github.com/users/jimmy-huang/orgs","repos_url":"https://api.github.com/users/jimmy-huang/repos","events_url":"https://api.github.com/users/jimmy-huang/events{/privacy}","received_events_url":"https://api.github.com/users/jimmy-huang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimmy-huang/tizen-extensions-crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk","forks_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/forks","keys_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/teams","hooks_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/hooks","issue_events_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/events","assignees_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/tags","blobs_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/languages","stargazers_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/stargazers","contributors_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/contributors","subscribers_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/subscribers","subscription_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/subscription","commits_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/merges","archive_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/downloads","issues_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/jimmy-huang/tizen-extensions-crosswalk/releases{/id}","created_at":"2014-05-06T17:07:10Z","updated_at":"2014-06-06T18:43:51Z","pushed_at":"2014-06-06T18:43:51Z","git_url":"git://github.com/jimmy-huang/tizen-extensions-crosswalk.git","ssh_url":"git@github.com:jimmy-huang/tizen-extensions-crosswalk.git","clone_url":"https://github.com/jimmy-huang/tizen-extensions-crosswalk.git","svn_url":"https://github.com/jimmy-huang/tizen-extensions-crosswalk","homepage":null,"size":1942,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"4d019f798eb8d3ad606152b83f7a71476e911b0b","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?","gravatar_id":"92669bf554412548daa0c4b8d74b861e","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":11259856,"name":"tizen-extensions-crosswalk","full_name":"crosswalk-project/tizen-extensions-crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?","gravatar_id":"92669bf554412548daa0c4b8d74b861e","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/comments/{number}","contents_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/releases{/id}","created_at":"2013-07-08T16:54:26Z","updated_at":"2014-06-06T22:03:52Z","pushed_at":"2014-06-06T22:03:52Z","git_url":"git://github.com/crosswalk-project/tizen-extensions-crosswalk.git","ssh_url":"git@github.com:crosswalk-project/tizen-extensions-crosswalk.git","clone_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk.git","svn_url":"https://github.com/crosswalk-project/tizen-extensions-crosswalk","homepage":null,"size":7404,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":37,"mirror_url":null,"open_issues_count":10,"forks":37,"open_issues":10,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/319"},"html":{"href":"https://github.com/crosswalk-project/tizen-extensions-crosswalk/pull/319"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/319"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/issues/319/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/319/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/pulls/319/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/tizen-extensions-crosswalk/statuses/472fb7f21d7fa717a6e1ca4e25261c730c9b09d8"}}}}