GitHub PullRequestReviewCommentEvent at 2014-03-18 10:43:13
Repository: HPCC-Platform
Actor: ghalliday
Payload: {"comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/10697334","id":10697334,"diff_hunk":"@@ -48,13 +48,14 @@ class CWorkUnitWriteMasterBase : public CMasterActivity\n         flushThreshold = -1;\n         workunitWriteLimit = 0;\n         mpTag = container.queryJob().allocateMPTag(); // used by local too\n+        activityMaxSize = 0;\n     }\n     virtual void init()\n     {\n         CMasterActivity::init();\n-        workunitWriteLimit = getOptInt(THOROPT_OUTPUTLIMIT, DEFAULT_WUIDWRITE_LIMIT);\n+        workunitWriteLimit = activityMaxSize ? activityMaxSize : getOptInt(THOROPT_OUTPUTLIMIT, DEFAULT_WUIDWRITE_LIMIT);\n         if (workunitWriteLimit>DALI_RESULT_OUTPUTMAX)\n-            throw MakeActivityException(this, 0, \"Dali result outputs are restricted to a maximum of %d MB, the default limit is %d MB. A huge dali result usually indicates the ECL needs altering.\", DALI_RESULT_OUTPUTMAX, DEFAULT_WUIDWRITE_LIMIT);\n+            throw MakeActivityException(this, 0, \"Dali result outputs are restricted to a maximum of %d MB, the current limit is %d MB. A huge dali result usually indicates the ECL needs altering.\", DALI_RESULT_OUTPUTMAX, DEFAULT_WUIDWRITE_LIMIT);","path":"thorlcr/activities/wuidwrite/thwuidwrite.cpp","position":22,"original_position":22,"commit_id":"5f181cae97d73094a04875276dcb01e70fa3c190","original_commit_id":"5f181cae97d73094a04875276dcb01e70fa3c190","user":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?","gravatar_id":"402dddc31c0e131326457e9ffd436352","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"body":"Second parameter should really be workunitWriteLimit","created_at":"2014-03-18T10:43:13Z","updated_at":"2014-03-18T10:43:13Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/5502#discussion_r10697334","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/5502","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/10697334"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/5502#discussion_r10697334"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/5502"}}}}