GitHub PullRequestReviewCommentEvent at 2014-10-23 17:07:43
Repository: nupic.rogue
Actor: scottpurdy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/numenta/nupic.rogue/pulls/comments/19291314","id":19291314,"diff_hunk":"@@ -16,11 +16,28 @@\n from agent import AvogadroAgent\n import psutil\n \n+from model_params import getModelParams\n+\n \n \n class AvogadroCPUTimesAgent(AvogadroAgent):\n   name = \"CPUPercent\"\n-  max = 100\n+  minVal = 0.0\n+  maxVal = 100.0\n+  numBuckets = 284.0","path":"avogadro/cpu_agent.py","position":13,"original_position":13,"commit_id":"c57f4c9f1ebc8a7be3a4e03ab24d53d5c425d832","original_commit_id":"c57f4c9f1ebc8a7be3a4e03ab24d53d5c425d832","user":{"login":"scottpurdy","id":239726,"avatar_url":"https://avatars.githubusercontent.com/u/239726?v=2","gravatar_id":"","url":"https://api.github.com/users/scottpurdy","html_url":"https://github.com/scottpurdy","followers_url":"https://api.github.com/users/scottpurdy/followers","following_url":"https://api.github.com/users/scottpurdy/following{/other_user}","gists_url":"https://api.github.com/users/scottpurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/scottpurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottpurdy/subscriptions","organizations_url":"https://api.github.com/users/scottpurdy/orgs","repos_url":"https://api.github.com/users/scottpurdy/repos","events_url":"https://api.github.com/users/scottpurdy/events{/privacy}","received_events_url":"https://api.github.com/users/scottpurdy/received_events","type":"User","site_admin":false},"body":"`numBuckets` should be an int since you can't have a half a bucket. My comment was just for symmetry between min/max","created_at":"2014-10-23T17:07:43Z","updated_at":"2014-10-23T17:07:43Z","html_url":"https://github.com/numenta/nupic.rogue/pull/1#discussion_r19291314","pull_request_url":"https://api.github.com/repos/numenta/nupic.rogue/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/numenta/nupic.rogue/pulls/comments/19291314"},"html":{"href":"https://github.com/numenta/nupic.rogue/pull/1#discussion_r19291314"},"pull_request":{"href":"https://api.github.com/repos/numenta/nupic.rogue/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/numenta/nupic.rogue/pulls/1","id":23200931,"html_url":"https://github.com/numenta/nupic.rogue/pull/1","diff_url":"https://github.com/numenta/nupic.rogue/pull/1.diff","patch_url":"https://github.com/numenta/nupic.rogue/pull/1.patch","issue_url":"https://api.github.com/repos/numenta/nupic.rogue/issues/1","number":1,"state":"open","locked":false,"title":"Add the ability to run the output directly through NuPIC rather than requiring a Grok instance","user":{"login":"jcasner","id":2521177,"avatar_url":"https://avatars.githubusercontent.com/u/2521177?v=2","gravatar_id":"","url":"https://api.github.com/users/jcasner","html_url":"https://github.com/jcasner","followers_url":"https://api.github.com/users/jcasner/followers","following_url":"https://api.github.com/users/jcasner/following{/other_user}","gists_url":"https://api.github.com/users/jcasner/gists{/gist_id}","starred_url":"https://api.github.com/users/jcasner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcasner/subscriptions","organizations_url":"https://api.github.com/users/jcasner/orgs","repos_url":"https://api.github.com/users/jcasner/repos","events_url":"https://api.github.com/users/jcasner/events{/privacy}","received_events_url":"https://api.github.com/users/jcasner/received_events","type":"User","site_admin":false},"body":"@oxtopus @scottpurdy @rhyolight Please review this change","created_at":"2014-10-23T00:58:05Z","updated_at":"2014-10-23T17:07:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f78aca24260c128f075026ccf5baeca3da9f603","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/numenta/nupic.rogue/pulls/1/commits","review_comments_url":"https://api.github.com/repos/numenta/nupic.rogue/pulls/1/comments","review_comment_url":"https://api.github.com/repos/numenta/nupic.rogue/pulls/comments/{number}","comments_url":"https://api.github.com/repos/numenta/nupic.rogue/issues/1/comments","statuses_url":"https://api.github.com/repos/numenta/nupic.rogue/statuses/c57f4c9f1ebc8a7be3a4e03ab24d53d5c425d832","head":{"label":"jcasner:master","ref":"master","sha":"c57f4c9f1ebc8a7be3a4e03ab24d53d5c425d832","user":{"login":"jcasner","id":2521177,"avatar_url":"https://avatars.githubusercontent.com/u/2521177?v=2","gravatar_id":"","url":"https://api.github.com/users/jcasner","html_url":"https://github.com/jcasner","followers_url":"https://api.github.com/users/jcasner/followers","following_url":"https://api.github.com/users/jcasner/following{/other_user}","gists_url":"https://api.github.com/users/jcasner/gists{/gist_id}","starred_url":"https://api.github.com/users/jcasner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcasner/subscriptions","organizations_url":"https://api.github.com/users/jcasner/orgs","repos_url":"https://api.github.com/users/jcasner/repos","events_url":"https://api.github.com/users/jcasner/events{/privacy}","received_events_url":"https://api.github.com/users/jcasner/received_events","type":"User","site_admin":false},"repo":{"id":25376397,"name":"nupic.rogue","full_name":"jcasner/nupic.rogue","owner":{"login":"jcasner","id":2521177,"avatar_url":"https://avatars.githubusercontent.com/u/2521177?v=2","gravatar_id":"","url":"https://api.github.com/users/jcasner","html_url":"https://github.com/jcasner","followers_url":"https://api.github.com/users/jcasner/followers","following_url":"https://api.github.com/users/jcasner/following{/other_user}","gists_url":"https://api.github.com/users/jcasner/gists{/gist_id}","starred_url":"https://api.github.com/users/jcasner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcasner/subscriptions","organizations_url":"https://api.github.com/users/jcasner/orgs","repos_url":"https://api.github.com/users/jcasner/repos","events_url":"https://api.github.com/users/jcasner/events{/privacy}","received_events_url":"https://api.github.com/users/jcasner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcasner/nupic.rogue","description":"","fork":true,"url":"https://api.github.com/repos/jcasner/nupic.rogue","forks_url":"https://api.github.com/repos/jcasner/nupic.rogue/forks","keys_url":"https://api.github.com/repos/jcasner/nupic.rogue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcasner/nupic.rogue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcasner/nupic.rogue/teams","hooks_url":"https://api.github.com/repos/jcasner/nupic.rogue/hooks","issue_events_url":"https://api.github.com/repos/jcasner/nupic.rogue/issues/events{/number}","events_url":"https://api.github.com/repos/jcasner/nupic.rogue/events","assignees_url":"https://api.github.com/repos/jcasner/nupic.rogue/assignees{/user}","branches_url":"https://api.github.com/repos/jcasner/nupic.rogue/branches{/branch}","tags_url":"https://api.github.com/repos/jcasner/nupic.rogue/tags","blobs_url":"https://api.github.com/repos/jcasner/nupic.rogue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcasner/nupic.rogue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcasner/nupic.rogue/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcasner/nupic.rogue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcasner/nupic.rogue/statuses/{sha}","languages_url":"https://api.github.com/repos/jcasner/nupic.rogue/languages","stargazers_url":"https://api.github.com/repos/jcasner/nupic.rogue/stargazers","contributors_url":"https://api.github.com/repos/jcasner/nupic.rogue/contributors","subscribers_url":"https://api.github.com/repos/jcasner/nupic.rogue/subscribers","subscription_url":"https://api.github.com/repos/jcasner/nupic.rogue/subscription","commits_url":"https://api.github.com/repos/jcasner/nupic.rogue/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcasner/nupic.rogue/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcasner/nupic.rogue/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcasner/nupic.rogue/issues/comments/{number}","contents_url":"https://api.github.com/repos/jcasner/nupic.rogue/contents/{+path}","compare_url":"https://api.github.com/repos/jcasner/nupic.rogue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcasner/nupic.rogue/merges","archive_url":"https://api.github.com/repos/jcasner/nupic.rogue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcasner/nupic.rogue/downloads","issues_url":"https://api.github.com/repos/jcasner/nupic.rogue/issues{/number}","pulls_url":"https://api.github.com/repos/jcasner/nupic.rogue/pulls{/number}","milestones_url":"https://api.github.com/repos/jcasner/nupic.rogue/milestones{/number}","notifications_url":"https://api.github.com/repos/jcasner/nupic.rogue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcasner/nupic.rogue/labels{/name}","releases_url":"https://api.github.com/repos/jcasner/nupic.rogue/releases{/id}","created_at":"2014-10-17T20:44:06Z","updated_at":"2014-10-23T00:56:44Z","pushed_at":"2014-10-23T16:23:54Z","git_url":"git://github.com/jcasner/nupic.rogue.git","ssh_url":"git@github.com:jcasner/nupic.rogue.git","clone_url":"https://github.com/jcasner/nupic.rogue.git","svn_url":"https://github.com/jcasner/nupic.rogue","homepage":null,"size":107,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numenta:master","ref":"master","sha":"7fa3281b6b44bcf9445f3c0446e0c6d2cd3c246b","user":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=2","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"repo":{"id":22776572,"name":"nupic.rogue","full_name":"numenta/nupic.rogue","owner":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=2","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numenta/nupic.rogue","description":"","fork":false,"url":"https://api.github.com/repos/numenta/nupic.rogue","forks_url":"https://api.github.com/repos/numenta/nupic.rogue/forks","keys_url":"https://api.github.com/repos/numenta/nupic.rogue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numenta/nupic.rogue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numenta/nupic.rogue/teams","hooks_url":"https://api.github.com/repos/numenta/nupic.rogue/hooks","issue_events_url":"https://api.github.com/repos/numenta/nupic.rogue/issues/events{/number}","events_url":"https://api.github.com/repos/numenta/nupic.rogue/events","assignees_url":"https://api.github.com/repos/numenta/nupic.rogue/assignees{/user}","branches_url":"https://api.github.com/repos/numenta/nupic.rogue/branches{/branch}","tags_url":"https://api.github.com/repos/numenta/nupic.rogue/tags","blobs_url":"https://api.github.com/repos/numenta/nupic.rogue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numenta/nupic.rogue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numenta/nupic.rogue/git/refs{/sha}","trees_url":"https://api.github.com/repos/numenta/nupic.rogue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numenta/nupic.rogue/statuses/{sha}","languages_url":"https://api.github.com/repos/numenta/nupic.rogue/languages","stargazers_url":"https://api.github.com/repos/numenta/nupic.rogue/stargazers","contributors_url":"https://api.github.com/repos/numenta/nupic.rogue/contributors","subscribers_url":"https://api.github.com/repos/numenta/nupic.rogue/subscribers","subscription_url":"https://api.github.com/repos/numenta/nupic.rogue/subscription","commits_url":"https://api.github.com/repos/numenta/nupic.rogue/commits{/sha}","git_commits_url":"https://api.github.com/repos/numenta/nupic.rogue/git/commits{/sha}","comments_url":"https://api.github.com/repos/numenta/nupic.rogue/comments{/number}","issue_comment_url":"https://api.github.com/repos/numenta/nupic.rogue/issues/comments/{number}","contents_url":"https://api.github.com/repos/numenta/nupic.rogue/contents/{+path}","compare_url":"https://api.github.com/repos/numenta/nupic.rogue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numenta/nupic.rogue/merges","archive_url":"https://api.github.com/repos/numenta/nupic.rogue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numenta/nupic.rogue/downloads","issues_url":"https://api.github.com/repos/numenta/nupic.rogue/issues{/number}","pulls_url":"https://api.github.com/repos/numenta/nupic.rogue/pulls{/number}","milestones_url":"https://api.github.com/repos/numenta/nupic.rogue/milestones{/number}","notifications_url":"https://api.github.com/repos/numenta/nupic.rogue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numenta/nupic.rogue/labels{/name}","releases_url":"https://api.github.com/repos/numenta/nupic.rogue/releases{/id}","created_at":"2014-08-09T01:59:52Z","updated_at":"2014-10-03T17:40:28Z","pushed_at":"2014-08-22T05:05:36Z","git_url":"git://github.com/numenta/nupic.rogue.git","ssh_url":"git@github.com:numenta/nupic.rogue.git","clone_url":"https://github.com/numenta/nupic.rogue.git","svn_url":"https://github.com/numenta/nupic.rogue","homepage":null,"size":160,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numenta/nupic.rogue/pulls/1"},"html":{"href":"https://github.com/numenta/nupic.rogue/pull/1"},"issue":{"href":"https://api.github.com/repos/numenta/nupic.rogue/issues/1"},"comments":{"href":"https://api.github.com/repos/numenta/nupic.rogue/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/numenta/nupic.rogue/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/numenta/nupic.rogue/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/numenta/nupic.rogue/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/numenta/nupic.rogue/statuses/c57f4c9f1ebc8a7be3a4e03ab24d53d5c425d832"}}}}