GitHub PullRequestReviewCommentEvent at 2014-02-05 13:35:37
Repository: elasticsearch
Actor: bleskes
Payload: {"comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/9460442","id":9460442,"diff_hunk":"@@ -98,15 +98,15 @@ public Result prepare(UpdateRequest request, IndexShard indexShard) {\n                     .refresh(request.refresh())\n                     .replicationType(request.replicationType()).consistencyLevel(request.consistencyLevel());\n             indexRequest.operationThreaded(false);\n-            if (request.versionType() == VersionType.EXTERNAL) {\n-                // in external versioning mode, we want to create the new document using the given version.\n-                indexRequest.version(request.version()).versionType(VersionType.EXTERNAL);\n+            if (request.versionType() != VersionType.INTERNAL) {\n+                // in all but the internal versioning mode, we want to create the new document using the given version.\n+                indexRequest.version(request.version()).versionType(request.versionType());\n             }\n             return new Result(indexRequest, Operation.UPSERT, null, null);\n         }\n \n         long updateVersion = getResult.getVersion();\n-        if (request.versionType() == VersionType.EXTERNAL) {\n+        if (request.versionType() != VersionType.INTERNAL) {","path":"src/main/java/org/elasticsearch/action/update/UpdateHelper.java","position":16,"original_position":16,"commit_id":"a5e66761625e5c4702a5122cc326943695993376","original_commit_id":"a5e66761625e5c4702a5122cc326943695993376","user":{"login":"bleskes","id":1006375,"avatar_url":"https://gravatar.com/avatar/f6e99c3552a2fa1f7b883d75e01289dc?d=https%3A%2F%2Fidenticons.github.com%2F10454a07cdcf3e4e650628a086f96f5b.png&r=x","gravatar_id":"f6e99c3552a2fa1f7b883d75e01289dc","url":"https://api.github.com/users/bleskes","html_url":"https://github.com/bleskes","followers_url":"https://api.github.com/users/bleskes/followers","following_url":"https://api.github.com/users/bleskes/following{/other_user}","gists_url":"https://api.github.com/users/bleskes/gists{/gist_id}","starred_url":"https://api.github.com/users/bleskes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleskes/subscriptions","organizations_url":"https://api.github.com/users/bleskes/orgs","repos_url":"https://api.github.com/users/bleskes/repos","events_url":"https://api.github.com/users/bleskes/events{/privacy}","received_events_url":"https://api.github.com/users/bleskes/received_events","type":"User","site_admin":false},"body":"@tallpsmith not at all! I was just referring to the update API. There is no problem what so ever with normal/bulk indexing calls.","created_at":"2014-02-05T13:35:37Z","updated_at":"2014-02-05T13:35:37Z","html_url":"https://github.com/elasticsearch/elasticsearch/pull/4993#discussion_r9460442","pull_request_url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/4993","_links":{"self":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/comments/9460442"},"html":{"href":"https://github.com/elasticsearch/elasticsearch/pull/4993#discussion_r9460442"},"pull_request":{"href":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/4993"}}}}