GitHub PullRequestEvent at 2014-09-21 15:40:10
Repository: Overpass-API
Actor: drolbr
Payload: {"action":"closed","number":131,"pull_request":{"url":"https://api.github.com/repos/drolbr/Overpass-API/pulls/131","id":21207719,"html_url":"https://github.com/drolbr/Overpass-API/pull/131","diff_url":"https://github.com/drolbr/Overpass-API/pull/131.diff","patch_url":"https://github.com/drolbr/Overpass-API/pull/131.patch","issue_url":"https://api.github.com/repos/drolbr/Overpass-API/issues/131","number":131,"state":"closed","locked":false,"title":"Output global bbox to JSON","user":{"login":"mmd-osm","id":5842757,"avatar_url":"https://avatars.githubusercontent.com/u/5842757?v=2","gravatar_id":"e4a5857a7adbbb803fa489852a69f3ba","url":"https://api.github.com/users/mmd-osm","html_url":"https://github.com/mmd-osm","followers_url":"https://api.github.com/users/mmd-osm/followers","following_url":"https://api.github.com/users/mmd-osm/following{/other_user}","gists_url":"https://api.github.com/users/mmd-osm/gists{/gist_id}","starred_url":"https://api.github.com/users/mmd-osm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmd-osm/subscriptions","organizations_url":"https://api.github.com/users/mmd-osm/orgs","repos_url":"https://api.github.com/users/mmd-osm/repos","events_url":"https://api.github.com/users/mmd-osm/events{/privacy}","received_events_url":"https://api.github.com/users/mmd-osm/received_events","type":"User","site_admin":false},"body":"First attempt to address issue #74.\r\n\r\n **There's one thing which deserves closer attention**: Printing out the initial \"elements\" tag moved from write_json_header to print_elements_header in frontend/print_target.cc.\r\n\r\nI did a number of tests with osm-script/ql and json and they looked good so far. But I'm not 100% sure if there's some use case where write_json_header is called, but not the new method print_elements_header. This would result in invalid json, as Web_Output::write_footer would assume an opening \"elements\" tag in any case, which is then missing.\r\n\r\nIn any case this patch might need some rework... feedback welcome!\r\n\r\nFixes #74 ","created_at":"2014-09-14T20:09:15Z","updated_at":"2014-09-21T15:40:10Z","closed_at":"2014-09-21T15:40:10Z","merged_at":null,"merge_commit_sha":"cc3bbed130299930867702aee68ac1c7bba27e57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/drolbr/Overpass-API/pulls/131/commits","review_comments_url":"https://api.github.com/repos/drolbr/Overpass-API/pulls/131/comments","review_comment_url":"https://api.github.com/repos/drolbr/Overpass-API/pulls/comments/{number}","comments_url":"https://api.github.com/repos/drolbr/Overpass-API/issues/131/comments","statuses_url":"https://api.github.com/repos/drolbr/Overpass-API/statuses/8a1272bff7192a488e016cd322309eb8ee49a731","head":{"label":"mmd-osm:patch_issue_74","ref":"patch_issue_74","sha":"8a1272bff7192a488e016cd322309eb8ee49a731","user":{"login":"mmd-osm","id":5842757,"avatar_url":"https://avatars.githubusercontent.com/u/5842757?v=2","gravatar_id":"e4a5857a7adbbb803fa489852a69f3ba","url":"https://api.github.com/users/mmd-osm","html_url":"https://github.com/mmd-osm","followers_url":"https://api.github.com/users/mmd-osm/followers","following_url":"https://api.github.com/users/mmd-osm/following{/other_user}","gists_url":"https://api.github.com/users/mmd-osm/gists{/gist_id}","starred_url":"https://api.github.com/users/mmd-osm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmd-osm/subscriptions","organizations_url":"https://api.github.com/users/mmd-osm/orgs","repos_url":"https://api.github.com/users/mmd-osm/repos","events_url":"https://api.github.com/users/mmd-osm/events{/privacy}","received_events_url":"https://api.github.com/users/mmd-osm/received_events","type":"User","site_admin":false},"repo":{"id":21002407,"name":"Overpass-API","full_name":"mmd-osm/Overpass-API","owner":{"login":"mmd-osm","id":5842757,"avatar_url":"https://avatars.githubusercontent.com/u/5842757?v=2","gravatar_id":"e4a5857a7adbbb803fa489852a69f3ba","url":"https://api.github.com/users/mmd-osm","html_url":"https://github.com/mmd-osm","followers_url":"https://api.github.com/users/mmd-osm/followers","following_url":"https://api.github.com/users/mmd-osm/following{/other_user}","gists_url":"https://api.github.com/users/mmd-osm/gists{/gist_id}","starred_url":"https://api.github.com/users/mmd-osm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmd-osm/subscriptions","organizations_url":"https://api.github.com/users/mmd-osm/orgs","repos_url":"https://api.github.com/users/mmd-osm/repos","events_url":"https://api.github.com/users/mmd-osm/events{/privacy}","received_events_url":"https://api.github.com/users/mmd-osm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmd-osm/Overpass-API","description":"","fork":true,"url":"https://api.github.com/repos/mmd-osm/Overpass-API","forks_url":"https://api.github.com/repos/mmd-osm/Overpass-API/forks","keys_url":"https://api.github.com/repos/mmd-osm/Overpass-API/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmd-osm/Overpass-API/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmd-osm/Overpass-API/teams","hooks_url":"https://api.github.com/repos/mmd-osm/Overpass-API/hooks","issue_events_url":"https://api.github.com/repos/mmd-osm/Overpass-API/issues/events{/number}","events_url":"https://api.github.com/repos/mmd-osm/Overpass-API/events","assignees_url":"https://api.github.com/repos/mmd-osm/Overpass-API/assignees{/user}","branches_url":"https://api.github.com/repos/mmd-osm/Overpass-API/branches{/branch}","tags_url":"https://api.github.com/repos/mmd-osm/Overpass-API/tags","blobs_url":"https://api.github.com/repos/mmd-osm/Overpass-API/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmd-osm/Overpass-API/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmd-osm/Overpass-API/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmd-osm/Overpass-API/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmd-osm/Overpass-API/statuses/{sha}","languages_url":"https://api.github.com/repos/mmd-osm/Overpass-API/languages","stargazers_url":"https://api.github.com/repos/mmd-osm/Overpass-API/stargazers","contributors_url":"https://api.github.com/repos/mmd-osm/Overpass-API/contributors","subscribers_url":"https://api.github.com/repos/mmd-osm/Overpass-API/subscribers","subscription_url":"https://api.github.com/repos/mmd-osm/Overpass-API/subscription","commits_url":"https://api.github.com/repos/mmd-osm/Overpass-API/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmd-osm/Overpass-API/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmd-osm/Overpass-API/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmd-osm/Overpass-API/issues/comments/{number}","contents_url":"https://api.github.com/repos/mmd-osm/Overpass-API/contents/{+path}","compare_url":"https://api.github.com/repos/mmd-osm/Overpass-API/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmd-osm/Overpass-API/merges","archive_url":"https://api.github.com/repos/mmd-osm/Overpass-API/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmd-osm/Overpass-API/downloads","issues_url":"https://api.github.com/repos/mmd-osm/Overpass-API/issues{/number}","pulls_url":"https://api.github.com/repos/mmd-osm/Overpass-API/pulls{/number}","milestones_url":"https://api.github.com/repos/mmd-osm/Overpass-API/milestones{/number}","notifications_url":"https://api.github.com/repos/mmd-osm/Overpass-API/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmd-osm/Overpass-API/labels{/name}","releases_url":"https://api.github.com/repos/mmd-osm/Overpass-API/releases{/id}","created_at":"2014-06-19T14:04:20Z","updated_at":"2014-08-10T10:49:26Z","pushed_at":"2014-09-19T21:18:50Z","git_url":"git://github.com/mmd-osm/Overpass-API.git","ssh_url":"git@github.com:mmd-osm/Overpass-API.git","clone_url":"https://github.com/mmd-osm/Overpass-API.git","svn_url":"https://github.com/mmd-osm/Overpass-API","homepage":"","size":9408,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"drolbr:master","ref":"master","sha":"c3c7684ca1c6b0fba81323900fa721837a39be9d","user":{"login":"drolbr","id":1475442,"avatar_url":"https://avatars.githubusercontent.com/u/1475442?v=2","gravatar_id":"fcfdb0825826fd13d2ff0d83d58819c6","url":"https://api.github.com/users/drolbr","html_url":"https://github.com/drolbr","followers_url":"https://api.github.com/users/drolbr/followers","following_url":"https://api.github.com/users/drolbr/following{/other_user}","gists_url":"https://api.github.com/users/drolbr/gists{/gist_id}","starred_url":"https://api.github.com/users/drolbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drolbr/subscriptions","organizations_url":"https://api.github.com/users/drolbr/orgs","repos_url":"https://api.github.com/users/drolbr/repos","events_url":"https://api.github.com/users/drolbr/events{/privacy}","received_events_url":"https://api.github.com/users/drolbr/received_events","type":"User","site_admin":false},"repo":{"id":3551227,"name":"Overpass-API","full_name":"drolbr/Overpass-API","owner":{"login":"drolbr","id":1475442,"avatar_url":"https://avatars.githubusercontent.com/u/1475442?v=2","gravatar_id":"fcfdb0825826fd13d2ff0d83d58819c6","url":"https://api.github.com/users/drolbr","html_url":"https://github.com/drolbr","followers_url":"https://api.github.com/users/drolbr/followers","following_url":"https://api.github.com/users/drolbr/following{/other_user}","gists_url":"https://api.github.com/users/drolbr/gists{/gist_id}","starred_url":"https://api.github.com/users/drolbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drolbr/subscriptions","organizations_url":"https://api.github.com/users/drolbr/orgs","repos_url":"https://api.github.com/users/drolbr/repos","events_url":"https://api.github.com/users/drolbr/events{/privacy}","received_events_url":"https://api.github.com/users/drolbr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drolbr/Overpass-API","description":"A database engine to query the OpenStreetMap data.","fork":false,"url":"https://api.github.com/repos/drolbr/Overpass-API","forks_url":"https://api.github.com/repos/drolbr/Overpass-API/forks","keys_url":"https://api.github.com/repos/drolbr/Overpass-API/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drolbr/Overpass-API/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drolbr/Overpass-API/teams","hooks_url":"https://api.github.com/repos/drolbr/Overpass-API/hooks","issue_events_url":"https://api.github.com/repos/drolbr/Overpass-API/issues/events{/number}","events_url":"https://api.github.com/repos/drolbr/Overpass-API/events","assignees_url":"https://api.github.com/repos/drolbr/Overpass-API/assignees{/user}","branches_url":"https://api.github.com/repos/drolbr/Overpass-API/branches{/branch}","tags_url":"https://api.github.com/repos/drolbr/Overpass-API/tags","blobs_url":"https://api.github.com/repos/drolbr/Overpass-API/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drolbr/Overpass-API/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drolbr/Overpass-API/git/refs{/sha}","trees_url":"https://api.github.com/repos/drolbr/Overpass-API/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drolbr/Overpass-API/statuses/{sha}","languages_url":"https://api.github.com/repos/drolbr/Overpass-API/languages","stargazers_url":"https://api.github.com/repos/drolbr/Overpass-API/stargazers","contributors_url":"https://api.github.com/repos/drolbr/Overpass-API/contributors","subscribers_url":"https://api.github.com/repos/drolbr/Overpass-API/subscribers","subscription_url":"https://api.github.com/repos/drolbr/Overpass-API/subscription","commits_url":"https://api.github.com/repos/drolbr/Overpass-API/commits{/sha}","git_commits_url":"https://api.github.com/repos/drolbr/Overpass-API/git/commits{/sha}","comments_url":"https://api.github.com/repos/drolbr/Overpass-API/comments{/number}","issue_comment_url":"https://api.github.com/repos/drolbr/Overpass-API/issues/comments/{number}","contents_url":"https://api.github.com/repos/drolbr/Overpass-API/contents/{+path}","compare_url":"https://api.github.com/repos/drolbr/Overpass-API/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drolbr/Overpass-API/merges","archive_url":"https://api.github.com/repos/drolbr/Overpass-API/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drolbr/Overpass-API/downloads","issues_url":"https://api.github.com/repos/drolbr/Overpass-API/issues{/number}","pulls_url":"https://api.github.com/repos/drolbr/Overpass-API/pulls{/number}","milestones_url":"https://api.github.com/repos/drolbr/Overpass-API/milestones{/number}","notifications_url":"https://api.github.com/repos/drolbr/Overpass-API/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drolbr/Overpass-API/labels{/name}","releases_url":"https://api.github.com/repos/drolbr/Overpass-API/releases{/id}","created_at":"2012-02-26T10:18:48Z","updated_at":"2014-09-06T12:08:45Z","pushed_at":"2014-09-21T15:37:11Z","git_url":"git://github.com/drolbr/Overpass-API.git","ssh_url":"git@github.com:drolbr/Overpass-API.git","clone_url":"https://github.com/drolbr/Overpass-API.git","svn_url":"https://github.com/drolbr/Overpass-API","homepage":"http://overpass-api.de","size":12505,"stargazers_count":67,"watchers_count":67,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":47,"forks":14,"open_issues":47,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drolbr/Overpass-API/pulls/131"},"html":{"href":"https://github.com/drolbr/Overpass-API/pull/131"},"issue":{"href":"https://api.github.com/repos/drolbr/Overpass-API/issues/131"},"comments":{"href":"https://api.github.com/repos/drolbr/Overpass-API/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/drolbr/Overpass-API/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/drolbr/Overpass-API/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/drolbr/Overpass-API/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/drolbr/Overpass-API/statuses/8a1272bff7192a488e016cd322309eb8ee49a731"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":18,"deletions":2,"changed_files":4}}