GitHub PullRequestEvent at 2014-11-25 20:52:34
Repository: ansible-modules-extras
Actor: swimlappy
Payload: {"action":"opened","number":119,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/119","id":25039452,"html_url":"https://github.com/ansible/ansible-modules-extras/pull/119","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/119.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/119.patch","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/119","number":119,"state":"open","locked":false,"title":"Fix some logical issues with enabling/disabling a server on the A10.","user":{"login":"swimlappy","id":3445492,"avatar_url":"https://avatars.githubusercontent.com/u/3445492?v=3","gravatar_id":"","url":"https://api.github.com/users/swimlappy","html_url":"https://github.com/swimlappy","followers_url":"https://api.github.com/users/swimlappy/followers","following_url":"https://api.github.com/users/swimlappy/following{/other_user}","gists_url":"https://api.github.com/users/swimlappy/gists{/gist_id}","starred_url":"https://api.github.com/users/swimlappy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swimlappy/subscriptions","organizations_url":"https://api.github.com/users/swimlappy/orgs","repos_url":"https://api.github.com/users/swimlappy/repos","events_url":"https://api.github.com/users/swimlappy/events{/privacy}","received_events_url":"https://api.github.com/users/swimlappy/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nI tried testing the A10 module and ran into a few issues.  I'm hoping perhaps these changes will get accepted.  Specifically the problems I ran into were\r\n\r\n* When trying to enable/disable a server on the A10, both the server name and IP address had to be specified.  If the IP address was not specified in the playbook, the code would fail thinking you were trying to \"create a server\" and this was required. If you only want to enable/disable a server, which is a pretty simple thing that happens a LOT, this code will make it easier to do that.  See lines 198-200.\r\n* Add a new function to determine if the status of a server needs to be updated.  See additional lines 237-246.\r\n* Only add optional parameters to the json_post array if they were specified in the module as parameters.  My AXAPI calls were including a ports parameter when they didn't need one.  See additional lines 190-199.\r\n* The a10_server.py code is looking for a module parameter called \"write_config\", but the documentation doesn't mention that.  Make that an optional parameter, or perhaps just update the documentation.  Either way, this code allows you to be more flexible.  See lines 254-255.\r\n\r\nHope this helps others!\r\n\r\nJason","created_at":"2014-11-25T20:52:33Z","updated_at":"2014-11-25T20:52:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/119/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/119/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/119/comments","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/ac250d6e9b97db99c1e4c63475ac7139ce08619f","head":{"label":"swimlappy:devel","ref":"devel","sha":"ac250d6e9b97db99c1e4c63475ac7139ce08619f","user":{"login":"swimlappy","id":3445492,"avatar_url":"https://avatars.githubusercontent.com/u/3445492?v=3","gravatar_id":"","url":"https://api.github.com/users/swimlappy","html_url":"https://github.com/swimlappy","followers_url":"https://api.github.com/users/swimlappy/followers","following_url":"https://api.github.com/users/swimlappy/following{/other_user}","gists_url":"https://api.github.com/users/swimlappy/gists{/gist_id}","starred_url":"https://api.github.com/users/swimlappy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swimlappy/subscriptions","organizations_url":"https://api.github.com/users/swimlappy/orgs","repos_url":"https://api.github.com/users/swimlappy/repos","events_url":"https://api.github.com/users/swimlappy/events{/privacy}","received_events_url":"https://api.github.com/users/swimlappy/received_events","type":"User","site_admin":false},"repo":{"id":27143443,"name":"ansible-modules-extras","full_name":"swimlappy/ansible-modules-extras","owner":{"login":"swimlappy","id":3445492,"avatar_url":"https://avatars.githubusercontent.com/u/3445492?v=3","gravatar_id":"","url":"https://api.github.com/users/swimlappy","html_url":"https://github.com/swimlappy","followers_url":"https://api.github.com/users/swimlappy/followers","following_url":"https://api.github.com/users/swimlappy/following{/other_user}","gists_url":"https://api.github.com/users/swimlappy/gists{/gist_id}","starred_url":"https://api.github.com/users/swimlappy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swimlappy/subscriptions","organizations_url":"https://api.github.com/users/swimlappy/orgs","repos_url":"https://api.github.com/users/swimlappy/repos","events_url":"https://api.github.com/users/swimlappy/events{/privacy}","received_events_url":"https://api.github.com/users/swimlappy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swimlappy/ansible-modules-extras","description":"Ansible extra modules - these modules ship with ansible","fork":true,"url":"https://api.github.com/repos/swimlappy/ansible-modules-extras","forks_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/forks","keys_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/teams","hooks_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/hooks","issue_events_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/issues/events{/number}","events_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/events","assignees_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/assignees{/user}","branches_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/branches{/branch}","tags_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/tags","blobs_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/languages","stargazers_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/stargazers","contributors_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/contributors","subscribers_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/subscribers","subscription_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/subscription","commits_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/issues/comments/{number}","contents_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/contents/{+path}","compare_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/merges","archive_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/downloads","issues_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/issues{/number}","pulls_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/labels{/name}","releases_url":"https://api.github.com/repos/swimlappy/ansible-modules-extras/releases{/id}","created_at":"2014-11-25T19:58:01Z","updated_at":"2014-11-25T20:44:14Z","pushed_at":"2014-11-25T20:44:14Z","git_url":"git://github.com/swimlappy/ansible-modules-extras.git","ssh_url":"git@github.com:swimlappy/ansible-modules-extras.git","clone_url":"https://github.com/swimlappy/ansible-modules-extras.git","svn_url":"https://github.com/swimlappy/ansible-modules-extras","homepage":"","size":8168,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"317654dba5cae905b5d6eed78f5c6c6984cc2f02","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":24474138,"name":"ansible-modules-extras","full_name":"ansible/ansible-modules-extras","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible-modules-extras","description":"Ansible extra modules - these modules ship with ansible","fork":false,"url":"https://api.github.com/repos/ansible/ansible-modules-extras","forks_url":"https://api.github.com/repos/ansible/ansible-modules-extras/forks","keys_url":"https://api.github.com/repos/ansible/ansible-modules-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible-modules-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible-modules-extras/teams","hooks_url":"https://api.github.com/repos/ansible/ansible-modules-extras/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/events","assignees_url":"https://api.github.com/repos/ansible/ansible-modules-extras/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible-modules-extras/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible-modules-extras/tags","blobs_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible-modules-extras/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible-modules-extras/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible-modules-extras/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible-modules-extras/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible-modules-extras/subscription","commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments/{number}","contents_url":"https://api.github.com/repos/ansible/ansible-modules-extras/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible-modules-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible-modules-extras/merges","archive_url":"https://api.github.com/repos/ansible/ansible-modules-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible-modules-extras/downloads","issues_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible-modules-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible-modules-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible-modules-extras/releases{/id}","created_at":"2014-09-25T20:28:42Z","updated_at":"2014-11-25T09:56:45Z","pushed_at":"2014-11-25T09:34:48Z","git_url":"git://github.com/ansible/ansible-modules-extras.git","ssh_url":"git@github.com:ansible/ansible-modules-extras.git","clone_url":"https://github.com/ansible/ansible-modules-extras.git","svn_url":"https://github.com/ansible/ansible-modules-extras","homepage":"","size":8168,"stargazers_count":60,"watchers_count":60,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":79,"forks":159,"open_issues":79,"watchers":60,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/119"},"html":{"href":"https://github.com/ansible/ansible-modules-extras/pull/119"},"issue":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/119"},"comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/ac250d6e9b97db99c1e4c63475ac7139ce08619f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":36,"deletions":15,"changed_files":1}}