GitHub PullRequestReviewCommentEvent at 2014-12-03 21:21:12
Repository: FOSHttpCacheBundle
Actor: dbu
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/comments/21265955","id":21265955,"diff_hunk":"@@ -11,9 +11,13 @@\n \n namespace FOS\\HttpCacheBundle;","path":"HttpCache.php","position":2,"original_position":2,"commit_id":"e07d591798b297c9a947844a624d727d68a74bde","original_commit_id":"d964fdbe5f4e63c4090b4520b49d03354a4eb817","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars.githubusercontent.com/u/76576?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2014-12-03T21:21:12Z","updated_at":"2014-12-03T21:21:12Z","html_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/177#discussion_r21265955","pull_request_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/177","_links":{"self":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/comments/21265955"},"html":{"href":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/177#discussion_r21265955"},"pull_request":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/177"}}},"pull_request":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/177","id":25263598,"html_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/177","diff_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/177.diff","patch_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/177.patch","issue_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/177","number":177,"state":"open","locked":false,"title":"Moving the user context logic out of the kernel inheritance hierarchy.","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars.githubusercontent.com/u/76576?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"fix #170\r\n\r\nThis adds an event handler to the cache kernel. The setup is:\r\n\r\n```\r\n$kernel = new HttpCache($kernel);\r\n$kernel->addSubscriber(new UserContextSubscriber());\r\n$kernel->addSubscriber(new PurgeSubscriber());\r\n$kernel->registerSubscriber(new BanSubscriber());\r\n```\r\n\r\n**TODO**\r\n* [ ] Adjust documentation (see also #178 and particularly the last comment, things changed since the description was done)\r\n* [x] #178 for default behaviour","created_at":"2014-12-01T12:01:52Z","updated_at":"2014-12-03T21:21:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe46f5e9e70d14f31620518f5b61e8dc56636720","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/177/commits","review_comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/177/comments","review_comment_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/177/comments","statuses_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/statuses/e07d591798b297c9a947844a624d727d68a74bde","head":{"label":"FriendsOfSymfony:refactor-symfony-cache","ref":"refactor-symfony-cache","sha":"e07d591798b297c9a947844a624d727d68a74bde","user":{"login":"FriendsOfSymfony","id":529709,"avatar_url":"https://avatars.githubusercontent.com/u/529709?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"repo":{"id":15187542,"name":"FOSHttpCacheBundle","full_name":"FriendsOfSymfony/FOSHttpCacheBundle","owner":{"login":"FriendsOfSymfony","id":529709,"avatar_url":"https://avatars.githubusercontent.com/u/529709?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle","description":"Use the FOSHttpCache library in your Symfony2 projects","fork":false,"url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle","forks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/forks","keys_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/teams","hooks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/events","assignees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/tags","blobs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/languages","stargazers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/subscription","commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/merges","archive_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/downloads","issues_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/releases{/id}","created_at":"2013-12-14T15:13:42Z","updated_at":"2014-12-02T16:33:09Z","pushed_at":"2014-12-03T21:20:46Z","git_url":"git://github.com/FriendsOfSymfony/FOSHttpCacheBundle.git","ssh_url":"git@github.com:FriendsOfSymfony/FOSHttpCacheBundle.git","clone_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle.git","svn_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle","homepage":"http://foshttpcachebundle.readthedocs.org/","size":5272,"stargazers_count":94,"watchers_count":94,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":21,"forks":15,"open_issues":21,"watchers":94,"default_branch":"master"}},"base":{"label":"FriendsOfSymfony:master","ref":"master","sha":"385ba079832a667d287cacdf3a3a121170ff256d","user":{"login":"FriendsOfSymfony","id":529709,"avatar_url":"https://avatars.githubusercontent.com/u/529709?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"repo":{"id":15187542,"name":"FOSHttpCacheBundle","full_name":"FriendsOfSymfony/FOSHttpCacheBundle","owner":{"login":"FriendsOfSymfony","id":529709,"avatar_url":"https://avatars.githubusercontent.com/u/529709?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle","description":"Use the FOSHttpCache library in your Symfony2 projects","fork":false,"url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle","forks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/forks","keys_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/teams","hooks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/events","assignees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/tags","blobs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/languages","stargazers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/subscription","commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/merges","archive_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/downloads","issues_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/releases{/id}","created_at":"2013-12-14T15:13:42Z","updated_at":"2014-12-02T16:33:09Z","pushed_at":"2014-12-03T21:20:46Z","git_url":"git://github.com/FriendsOfSymfony/FOSHttpCacheBundle.git","ssh_url":"git@github.com:FriendsOfSymfony/FOSHttpCacheBundle.git","clone_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle.git","svn_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle","homepage":"http://foshttpcachebundle.readthedocs.org/","size":5272,"stargazers_count":94,"watchers_count":94,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":21,"forks":15,"open_issues":21,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/177"},"html":{"href":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/177"},"issue":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/177"},"comments":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/statuses/e07d591798b297c9a947844a624d727d68a74bde"}}}}