GitHub PullRequestReviewCommentEvent at 2014-09-30 10:48:54
Repository: laravel_training
Actor: fr-sasaki
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/fr-itaya/laravel_training/pulls/comments/18209776","id":18209776,"diff_hunk":"@@ -0,0 +1,40 @@\n+<?php\n+\n+class ApplyInfo extends Eloquent {\n+\n+    protected $table = 'user';","path":"app/models/ApplyInfo.php","position":5,"original_position":5,"commit_id":"06990b9172a51a1a1ea3e23ce14ed2f3d4687320","original_commit_id":"06990b9172a51a1a1ea3e23ce14ed2f3d4687320","user":{"login":"fr-sasaki","id":4498464,"avatar_url":"https://avatars.githubusercontent.com/u/4498464?v=2","gravatar_id":"","url":"https://api.github.com/users/fr-sasaki","html_url":"https://github.com/fr-sasaki","followers_url":"https://api.github.com/users/fr-sasaki/followers","following_url":"https://api.github.com/users/fr-sasaki/following{/other_user}","gists_url":"https://api.github.com/users/fr-sasaki/gists{/gist_id}","starred_url":"https://api.github.com/users/fr-sasaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fr-sasaki/subscriptions","organizations_url":"https://api.github.com/users/fr-sasaki/orgs","repos_url":"https://api.github.com/users/fr-sasaki/repos","events_url":"https://api.github.com/users/fr-sasaki/events{/privacy}","received_events_url":"https://api.github.com/users/fr-sasaki/received_events","type":"User","site_admin":false},"body":"ここはusers？\r\nこのクラスはDBとの接続が無いので、Eloquent の継承と$tableの設定は削除しても問題ないです","created_at":"2014-09-30T10:48:54Z","updated_at":"2014-09-30T10:48:54Z","html_url":"https://github.com/fr-itaya/laravel_training/pull/7#discussion_r18209776","pull_request_url":"https://api.github.com/repos/fr-itaya/laravel_training/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/fr-itaya/laravel_training/pulls/comments/18209776"},"html":{"href":"https://github.com/fr-itaya/laravel_training/pull/7#discussion_r18209776"},"pull_request":{"href":"https://api.github.com/repos/fr-itaya/laravel_training/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/fr-itaya/laravel_training/pulls/7","id":21132234,"html_url":"https://github.com/fr-itaya/laravel_training/pull/7","diff_url":"https://github.com/fr-itaya/laravel_training/pull/7.diff","patch_url":"https://github.com/fr-itaya/laravel_training/pull/7.patch","issue_url":"https://api.github.com/repos/fr-itaya/laravel_training/issues/7","number":7,"state":"open","locked":false,"title":"[WIP] #75 Laravel製フォームのテスト - Routing/Controller - Logic","user":{"login":"fr-itaya","id":7111591,"avatar_url":"https://avatars.githubusercontent.com/u/7111591?v=2","gravatar_id":"","url":"https://api.github.com/users/fr-itaya","html_url":"https://github.com/fr-itaya","followers_url":"https://api.github.com/users/fr-itaya/followers","following_url":"https://api.github.com/users/fr-itaya/following{/other_user}","gists_url":"https://api.github.com/users/fr-itaya/gists{/gist_id}","starred_url":"https://api.github.com/users/fr-itaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fr-itaya/subscriptions","organizations_url":"https://api.github.com/users/fr-itaya/orgs","repos_url":"https://api.github.com/users/fr-itaya/repos","events_url":"https://api.github.com/users/fr-itaya/events{/privacy}","received_events_url":"https://api.github.com/users/fr-itaya/received_events","type":"User","site_admin":false},"body":"# WIP!\r\n\r\nLaravel4で作成したフォームをPHPUnitでテストします。\r\n[旧PR](https://github.com/fr-itaya/laravel_training/pull/6)からの残タスクは以下の通りです。\r\n※Routingのテストが終わっていた為、Controllerのロジック部分もこのPRで対応します。\r\n\r\n## Routing(リクエストに対するテスト)\r\n  - [x] TOP画面・フォーム画面へのリクエストがGETであるか？\r\n  - [x] 確認画面・完了画面へのリクエストがPOSTであるか？\r\n\r\n### Controller(ロジックやフォームバリデートなどに対するテスト)\r\n###### Logic\r\n  - [ ] 一部の入力データを確認画面表示用に加工しているか？\r\n    - [ ] 趣味欄(入力値を全て結合し1つの文字列にする)\r\n    - [ ] 都道府県\r\n  - [ ] Viewに上記の値を渡せているか？\r\n  - [ ] TOP画面遷移時Sessionが空になっているか？\r\n  - [ ] リダイレクト時、レスポンスがリダイレクトであるか？\r\n  - [ ] リダイレクト時、セッションがエラーを持っているか\r\n  - [ ] リダイレクト時、セッションが直前の入力値を持っているか？\r\n  - [ ] 確認画面→フォーム画面への時にエラーメッセージがある場合、表示出来るようにする処理\r\n  - [ ] 趣味欄：チェックボックスへの自動入力\r\n  - [ ] バリデート下準備\r\n    - ※対象=`$form_data_trimmed`(配列。POSTデータから前後の空白を除いた入力値が入っている)\r\n    - [ ] 上記配列に値が入っているか？\r\n    - [x] 入力値の空白トリム","created_at":"2014-09-12T04:19:10Z","updated_at":"2014-09-30T10:48:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b67fb7a34a2453c5a535cf45bc0240f3983df270","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fr-itaya/laravel_training/pulls/7/commits","review_comments_url":"https://api.github.com/repos/fr-itaya/laravel_training/pulls/7/comments","review_comment_url":"https://api.github.com/repos/fr-itaya/laravel_training/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fr-itaya/laravel_training/issues/7/comments","statuses_url":"https://api.github.com/repos/fr-itaya/laravel_training/statuses/06990b9172a51a1a1ea3e23ce14ed2f3d4687320","head":{"label":"fr-itaya:feature/44_laravel_with_PHPUnit","ref":"feature/44_laravel_with_PHPUnit","sha":"06990b9172a51a1a1ea3e23ce14ed2f3d4687320","user":{"login":"fr-itaya","id":7111591,"avatar_url":"https://avatars.githubusercontent.com/u/7111591?v=2","gravatar_id":"","url":"https://api.github.com/users/fr-itaya","html_url":"https://github.com/fr-itaya","followers_url":"https://api.github.com/users/fr-itaya/followers","following_url":"https://api.github.com/users/fr-itaya/following{/other_user}","gists_url":"https://api.github.com/users/fr-itaya/gists{/gist_id}","starred_url":"https://api.github.com/users/fr-itaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fr-itaya/subscriptions","organizations_url":"https://api.github.com/users/fr-itaya/orgs","repos_url":"https://api.github.com/users/fr-itaya/repos","events_url":"https://api.github.com/users/fr-itaya/events{/privacy}","received_events_url":"https://api.github.com/users/fr-itaya/received_events","type":"User","site_admin":false},"repo":{"id":21406889,"name":"laravel_training","full_name":"fr-itaya/laravel_training","owner":{"login":"fr-itaya","id":7111591,"avatar_url":"https://avatars.githubusercontent.com/u/7111591?v=2","gravatar_id":"","url":"https://api.github.com/users/fr-itaya","html_url":"https://github.com/fr-itaya","followers_url":"https://api.github.com/users/fr-itaya/followers","following_url":"https://api.github.com/users/fr-itaya/following{/other_user}","gists_url":"https://api.github.com/users/fr-itaya/gists{/gist_id}","starred_url":"https://api.github.com/users/fr-itaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fr-itaya/subscriptions","organizations_url":"https://api.github.com/users/fr-itaya/orgs","repos_url":"https://api.github.com/users/fr-itaya/repos","events_url":"https://api.github.com/users/fr-itaya/events{/privacy}","received_events_url":"https://api.github.com/users/fr-itaya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fr-itaya/laravel_training","description":"","fork":false,"url":"https://api.github.com/repos/fr-itaya/laravel_training","forks_url":"https://api.github.com/repos/fr-itaya/laravel_training/forks","keys_url":"https://api.github.com/repos/fr-itaya/laravel_training/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fr-itaya/laravel_training/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fr-itaya/laravel_training/teams","hooks_url":"https://api.github.com/repos/fr-itaya/laravel_training/hooks","issue_events_url":"https://api.github.com/repos/fr-itaya/laravel_training/issues/events{/number}","events_url":"https://api.github.com/repos/fr-itaya/laravel_training/events","assignees_url":"https://api.github.com/repos/fr-itaya/laravel_training/assignees{/user}","branches_url":"https://api.github.com/repos/fr-itaya/laravel_training/branches{/branch}","tags_url":"https://api.github.com/repos/fr-itaya/laravel_training/tags","blobs_url":"https://api.github.com/repos/fr-itaya/laravel_training/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fr-itaya/laravel_training/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fr-itaya/laravel_training/git/refs{/sha}","trees_url":"https://api.github.com/repos/fr-itaya/laravel_training/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fr-itaya/laravel_training/statuses/{sha}","languages_url":"https://api.github.com/repos/fr-itaya/laravel_training/languages","stargazers_url":"https://api.github.com/repos/fr-itaya/laravel_training/stargazers","contributors_url":"https://api.github.com/repos/fr-itaya/laravel_training/contributors","subscribers_url":"https://api.github.com/repos/fr-itaya/laravel_training/subscribers","subscription_url":"https://api.github.com/repos/fr-itaya/laravel_training/subscription","commits_url":"https://api.github.com/repos/fr-itaya/laravel_training/commits{/sha}","git_commits_url":"https://api.github.com/repos/fr-itaya/laravel_training/git/commits{/sha}","comments_url":"https://api.github.com/repos/fr-itaya/laravel_training/comments{/number}","issue_comment_url":"https://api.github.com/repos/fr-itaya/laravel_training/issues/comments/{number}","contents_url":"https://api.github.com/repos/fr-itaya/laravel_training/contents/{+path}","compare_url":"https://api.github.com/repos/fr-itaya/laravel_training/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fr-itaya/laravel_training/merges","archive_url":"https://api.github.com/repos/fr-itaya/laravel_training/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fr-itaya/laravel_training/downloads","issues_url":"https://api.github.com/repos/fr-itaya/laravel_training/issues{/number}","pulls_url":"https://api.github.com/repos/fr-itaya/laravel_training/pulls{/number}","milestones_url":"https://api.github.com/repos/fr-itaya/laravel_training/milestones{/number}","notifications_url":"https://api.github.com/repos/fr-itaya/laravel_training/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fr-itaya/laravel_training/labels{/name}","releases_url":"https://api.github.com/repos/fr-itaya/laravel_training/releases{/id}","created_at":"2014-07-02T00:57:46Z","updated_at":"2014-07-02T01:13:02Z","pushed_at":"2014-09-30T09:58:57Z","git_url":"git://github.com/fr-itaya/laravel_training.git","ssh_url":"git@github.com:fr-itaya/laravel_training.git","clone_url":"https://github.com/fr-itaya/laravel_training.git","svn_url":"https://github.com/fr-itaya/laravel_training","homepage":null,"size":968,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"fr-itaya:master","ref":"master","sha":"ee6b5ea331c21e3c53bd1ab7f768ff3852b4751f","user":{"login":"fr-itaya","id":7111591,"avatar_url":"https://avatars.githubusercontent.com/u/7111591?v=2","gravatar_id":"","url":"https://api.github.com/users/fr-itaya","html_url":"https://github.com/fr-itaya","followers_url":"https://api.github.com/users/fr-itaya/followers","following_url":"https://api.github.com/users/fr-itaya/following{/other_user}","gists_url":"https://api.github.com/users/fr-itaya/gists{/gist_id}","starred_url":"https://api.github.com/users/fr-itaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fr-itaya/subscriptions","organizations_url":"https://api.github.com/users/fr-itaya/orgs","repos_url":"https://api.github.com/users/fr-itaya/repos","events_url":"https://api.github.com/users/fr-itaya/events{/privacy}","received_events_url":"https://api.github.com/users/fr-itaya/received_events","type":"User","site_admin":false},"repo":{"id":21406889,"name":"laravel_training","full_name":"fr-itaya/laravel_training","owner":{"login":"fr-itaya","id":7111591,"avatar_url":"https://avatars.githubusercontent.com/u/7111591?v=2","gravatar_id":"","url":"https://api.github.com/users/fr-itaya","html_url":"https://github.com/fr-itaya","followers_url":"https://api.github.com/users/fr-itaya/followers","following_url":"https://api.github.com/users/fr-itaya/following{/other_user}","gists_url":"https://api.github.com/users/fr-itaya/gists{/gist_id}","starred_url":"https://api.github.com/users/fr-itaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fr-itaya/subscriptions","organizations_url":"https://api.github.com/users/fr-itaya/orgs","repos_url":"https://api.github.com/users/fr-itaya/repos","events_url":"https://api.github.com/users/fr-itaya/events{/privacy}","received_events_url":"https://api.github.com/users/fr-itaya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fr-itaya/laravel_training","description":"","fork":false,"url":"https://api.github.com/repos/fr-itaya/laravel_training","forks_url":"https://api.github.com/repos/fr-itaya/laravel_training/forks","keys_url":"https://api.github.com/repos/fr-itaya/laravel_training/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fr-itaya/laravel_training/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fr-itaya/laravel_training/teams","hooks_url":"https://api.github.com/repos/fr-itaya/laravel_training/hooks","issue_events_url":"https://api.github.com/repos/fr-itaya/laravel_training/issues/events{/number}","events_url":"https://api.github.com/repos/fr-itaya/laravel_training/events","assignees_url":"https://api.github.com/repos/fr-itaya/laravel_training/assignees{/user}","branches_url":"https://api.github.com/repos/fr-itaya/laravel_training/branches{/branch}","tags_url":"https://api.github.com/repos/fr-itaya/laravel_training/tags","blobs_url":"https://api.github.com/repos/fr-itaya/laravel_training/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fr-itaya/laravel_training/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fr-itaya/laravel_training/git/refs{/sha}","trees_url":"https://api.github.com/repos/fr-itaya/laravel_training/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fr-itaya/laravel_training/statuses/{sha}","languages_url":"https://api.github.com/repos/fr-itaya/laravel_training/languages","stargazers_url":"https://api.github.com/repos/fr-itaya/laravel_training/stargazers","contributors_url":"https://api.github.com/repos/fr-itaya/laravel_training/contributors","subscribers_url":"https://api.github.com/repos/fr-itaya/laravel_training/subscribers","subscription_url":"https://api.github.com/repos/fr-itaya/laravel_training/subscription","commits_url":"https://api.github.com/repos/fr-itaya/laravel_training/commits{/sha}","git_commits_url":"https://api.github.com/repos/fr-itaya/laravel_training/git/commits{/sha}","comments_url":"https://api.github.com/repos/fr-itaya/laravel_training/comments{/number}","issue_comment_url":"https://api.github.com/repos/fr-itaya/laravel_training/issues/comments/{number}","contents_url":"https://api.github.com/repos/fr-itaya/laravel_training/contents/{+path}","compare_url":"https://api.github.com/repos/fr-itaya/laravel_training/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fr-itaya/laravel_training/merges","archive_url":"https://api.github.com/repos/fr-itaya/laravel_training/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fr-itaya/laravel_training/downloads","issues_url":"https://api.github.com/repos/fr-itaya/laravel_training/issues{/number}","pulls_url":"https://api.github.com/repos/fr-itaya/laravel_training/pulls{/number}","milestones_url":"https://api.github.com/repos/fr-itaya/laravel_training/milestones{/number}","notifications_url":"https://api.github.com/repos/fr-itaya/laravel_training/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fr-itaya/laravel_training/labels{/name}","releases_url":"https://api.github.com/repos/fr-itaya/laravel_training/releases{/id}","created_at":"2014-07-02T00:57:46Z","updated_at":"2014-07-02T01:13:02Z","pushed_at":"2014-09-30T09:58:57Z","git_url":"git://github.com/fr-itaya/laravel_training.git","ssh_url":"git@github.com:fr-itaya/laravel_training.git","clone_url":"https://github.com/fr-itaya/laravel_training.git","svn_url":"https://github.com/fr-itaya/laravel_training","homepage":null,"size":968,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fr-itaya/laravel_training/pulls/7"},"html":{"href":"https://github.com/fr-itaya/laravel_training/pull/7"},"issue":{"href":"https://api.github.com/repos/fr-itaya/laravel_training/issues/7"},"comments":{"href":"https://api.github.com/repos/fr-itaya/laravel_training/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/fr-itaya/laravel_training/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/fr-itaya/laravel_training/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fr-itaya/laravel_training/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/fr-itaya/laravel_training/statuses/06990b9172a51a1a1ea3e23ce14ed2f3d4687320"}}}}