GitHub PullRequestEvent at 2014-03-30 21:49:23
Repository: aws-toolkit-eclipse
Actor: ximon18
Payload: {"action":"opened","number":12,"pull_request":{"url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/pulls/12","id":14155941,"html_url":"https://github.com/aws/aws-toolkit-eclipse/pull/12","diff_url":"https://github.com/aws/aws-toolkit-eclipse/pull/12.diff","patch_url":"https://github.com/aws/aws-toolkit-eclipse/pull/12.patch","issue_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/issues/12","number":12,"state":"open","title":"Enable hyperlinking","user":{"login":"ximon18","id":3304436,"avatar_url":"https://avatars.githubusercontent.com/u/3304436?","gravatar_id":"48ffc962fb9bb82536ff3d55758bed7a","url":"https://api.github.com/users/ximon18","html_url":"https://github.com/ximon18","followers_url":"https://api.github.com/users/ximon18/followers","following_url":"https://api.github.com/users/ximon18/following{/other_user}","gists_url":"https://api.github.com/users/ximon18/gists{/gist_id}","starred_url":"https://api.github.com/users/ximon18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximon18/subscriptions","organizations_url":"https://api.github.com/users/ximon18/orgs","repos_url":"https://api.github.com/users/ximon18/repos","events_url":"https://api.github.com/users/ximon18/events{/privacy}","received_events_url":"https://api.github.com/users/ximon18/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThis change makes it possible to hold the CTRL key and see hyperlinks in the CloudFormation template editor. Links will appear on { \"Ref\": \"NamedNode\" } or { \"DependsOn\": \"NamedNode\" } or even \"Type\": \"AWS::xxx\" text. Clicking a NamedNode will move the editor focus to the named node, just like the outline view does when double clicking a tree item. Clicking an AWS::xxx type will cause the Eclipse browser to open the AWS reference page, as found by the Google feeling lucky search.\r\n\r\nI'm not expecting this to be merged into the main plugin code at this point as I feel it should have tests and be reviewed and I'm fairly new to writing Eclipse plugins so I feel that the greater the size of the code change the greater the risk at this point of merging it.\r\n\r\nHowever, I and my colleagues are already finding this change valuable, so I'd like to start on the path toward making this added value available to others \"out there\".\r\n\r\nAll comments greatfully received.\r\n\r\nNote: this branch contains a couple of changes that are not related to implementing hyperlinking:\r\n* 'contributorClass=\"org.eclipse.ui.texteditor.BasicTextEditorActionContributor\"' - this is already contained in  previously accepted pull request\r\n* a typo correction of getIntrinsicFuntions to getIntrinsicFunctions\r\n\r\nXimon","created_at":"2014-03-30T21:49:23Z","updated_at":"2014-03-30T21:49:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/pulls/12/commits","review_comments_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/pulls/12/comments","review_comment_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/issues/12/comments","statuses_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/statuses/655aa674dc6ab7a9d838f8adca076af7c3e0e7ee","head":{"label":"ximon18:enable-hyperlinking","ref":"enable-hyperlinking","sha":"655aa674dc6ab7a9d838f8adca076af7c3e0e7ee","user":{"login":"ximon18","id":3304436,"avatar_url":"https://avatars.githubusercontent.com/u/3304436?","gravatar_id":"48ffc962fb9bb82536ff3d55758bed7a","url":"https://api.github.com/users/ximon18","html_url":"https://github.com/ximon18","followers_url":"https://api.github.com/users/ximon18/followers","following_url":"https://api.github.com/users/ximon18/following{/other_user}","gists_url":"https://api.github.com/users/ximon18/gists{/gist_id}","starred_url":"https://api.github.com/users/ximon18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximon18/subscriptions","organizations_url":"https://api.github.com/users/ximon18/orgs","repos_url":"https://api.github.com/users/ximon18/repos","events_url":"https://api.github.com/users/ximon18/events{/privacy}","received_events_url":"https://api.github.com/users/ximon18/received_events","type":"User","site_admin":false},"repo":{"id":17395527,"name":"aws-toolkit-eclipse","full_name":"ximon18/aws-toolkit-eclipse","owner":{"login":"ximon18","id":3304436,"avatar_url":"https://avatars.githubusercontent.com/u/3304436?","gravatar_id":"48ffc962fb9bb82536ff3d55758bed7a","url":"https://api.github.com/users/ximon18","html_url":"https://github.com/ximon18","followers_url":"https://api.github.com/users/ximon18/followers","following_url":"https://api.github.com/users/ximon18/following{/other_user}","gists_url":"https://api.github.com/users/ximon18/gists{/gist_id}","starred_url":"https://api.github.com/users/ximon18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximon18/subscriptions","organizations_url":"https://api.github.com/users/ximon18/orgs","repos_url":"https://api.github.com/users/ximon18/repos","events_url":"https://api.github.com/users/ximon18/events{/privacy}","received_events_url":"https://api.github.com/users/ximon18/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ximon18/aws-toolkit-eclipse","description":"Fork of the official mirror of the AWS Toolkit for Eclipse.  For the original GitHub project see:","fork":true,"url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse","forks_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/forks","keys_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/teams","hooks_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/hooks","issue_events_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/issues/events{/number}","events_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/events","assignees_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/assignees{/user}","branches_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/branches{/branch}","tags_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/tags","blobs_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/git/refs{/sha}","trees_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/statuses/{sha}","languages_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/languages","stargazers_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/stargazers","contributors_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/contributors","subscribers_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/subscribers","subscription_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/subscription","commits_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/commits{/sha}","git_commits_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/git/commits{/sha}","comments_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/comments{/number}","issue_comment_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/issues/comments/{number}","contents_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/contents/{+path}","compare_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/merges","archive_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/downloads","issues_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/issues{/number}","pulls_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/pulls{/number}","milestones_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/milestones{/number}","notifications_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/labels{/name}","releases_url":"https://api.github.com/repos/ximon18/aws-toolkit-eclipse/releases{/id}","created_at":"2014-03-04T08:38:06Z","updated_at":"2014-03-30T21:49:23Z","pushed_at":"2014-03-30T21:41:21Z","git_url":"git://github.com/ximon18/aws-toolkit-eclipse.git","ssh_url":"git@github.com:ximon18/aws-toolkit-eclipse.git","clone_url":"https://github.com/ximon18/aws-toolkit-eclipse.git","svn_url":"https://github.com/ximon18/aws-toolkit-eclipse","homepage":"https://github.com/aws/aws-toolkit-eclipse","size":82512,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"9f982f7e5de7e1112330ab5bc68f7d901074f95c","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars.githubusercontent.com/u/2232217?","gravatar_id":"b66042c7e9e8ae1a0fe1c0c3245d3d91","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":1176081,"name":"aws-toolkit-eclipse","full_name":"aws/aws-toolkit-eclipse","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars.githubusercontent.com/u/2232217?","gravatar_id":"b66042c7e9e8ae1a0fe1c0c3245d3d91","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/aws-toolkit-eclipse","description":"Official mirror of the AWS Toolkit for Eclipse.  For more information on the toolkit, see our web site:  ","fork":false,"url":"https://api.github.com/repos/aws/aws-toolkit-eclipse","forks_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/forks","keys_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/teams","hooks_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/events","assignees_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/tags","blobs_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/languages","stargazers_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/subscription","commits_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/issues/comments/{number}","contents_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/merges","archive_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/downloads","issues_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-toolkit-eclipse/releases{/id}","created_at":"2010-12-17T02:12:00Z","updated_at":"2014-03-19T22:03:04Z","pushed_at":"2014-03-19T22:03:04Z","git_url":"git://github.com/aws/aws-toolkit-eclipse.git","ssh_url":"git@github.com:aws/aws-toolkit-eclipse.git","clone_url":"https://github.com/aws/aws-toolkit-eclipse.git","svn_url":"https://github.com/aws/aws-toolkit-eclipse","homepage":"http://aws.amazon.com/eclipse","size":83404,"stargazers_count":100,"watchers_count":100,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":39,"mirror_url":null,"open_issues_count":6,"forks":39,"open_issues":6,"watchers":100,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-toolkit-eclipse/pulls/12"},"html":{"href":"https://github.com/aws/aws-toolkit-eclipse/pull/12"},"issue":{"href":"https://api.github.com/repos/aws/aws-toolkit-eclipse/issues/12"},"comments":{"href":"https://api.github.com/repos/aws/aws-toolkit-eclipse/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-toolkit-eclipse/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-toolkit-eclipse/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-toolkit-eclipse/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-toolkit-eclipse/statuses/655aa674dc6ab7a9d838f8adca076af7c3e0e7ee"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":12,"additions":301,"deletions":27,"changed_files":13}}