GitHub PullRequestReviewCommentEvent at 2014-11-29 14:40:05
Repository: diaspora
Actor: svbergerem
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/21054273","id":21054273,"diff_hunk":"@@ -9,3 +9,14 @@ input::-ms-input-placeholder,\n textarea::-ms-input-placeholder {\n   color: #999999;\n }\n+\n+// A temporary fix for mention modal #5329\n+\n+#new_status_message_pane .modal {\n+  position: absolute;\n+  z-index: 1000;","path":"app/assets/stylesheets/bootstrap-fix.css.scss","position":9,"original_position":9,"commit_id":"c543002b7cffc99e79176bf184ca8753c011f2ed","original_commit_id":"c543002b7cffc99e79176bf184ca8753c011f2ed","user":{"login":"svbergerem","id":3798614,"avatar_url":"https://avatars.githubusercontent.com/u/3798614?v=3","gravatar_id":"","url":"https://api.github.com/users/svbergerem","html_url":"https://github.com/svbergerem","followers_url":"https://api.github.com/users/svbergerem/followers","following_url":"https://api.github.com/users/svbergerem/following{/other_user}","gists_url":"https://api.github.com/users/svbergerem/gists{/gist_id}","starred_url":"https://api.github.com/users/svbergerem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svbergerem/subscriptions","organizations_url":"https://api.github.com/users/svbergerem/orgs","repos_url":"https://api.github.com/users/svbergerem/repos","events_url":"https://api.github.com/users/svbergerem/events{/privacy}","received_events_url":"https://api.github.com/users/svbergerem/received_events","type":"User","site_admin":false},"body":"Right now (on develop) the header is behind the backdrop which is ok for me so I think you don't have to put the modal behind the header. If you want to do it you'd also have to put the backdrop behind the header.","created_at":"2014-11-29T14:40:05Z","updated_at":"2014-11-29T14:40:05Z","html_url":"https://github.com/diaspora/diaspora/pull/5435#discussion_r21054273","pull_request_url":"https://api.github.com/repos/diaspora/diaspora/pulls/5435","_links":{"self":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/21054273"},"html":{"href":"https://github.com/diaspora/diaspora/pull/5435#discussion_r21054273"},"pull_request":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/5435"}}},"pull_request":{"url":"https://api.github.com/repos/diaspora/diaspora/pulls/5435","id":25202178,"html_url":"https://github.com/diaspora/diaspora/pull/5435","diff_url":"https://github.com/diaspora/diaspora/pull/5435.diff","patch_url":"https://github.com/diaspora/diaspora/pull/5435.patch","issue_url":"https://api.github.com/repos/diaspora/diaspora/issues/5435","number":5435,"state":"open","locked":false,"title":"A temporary fix for mention modal #5329","user":{"login":"SansPseudoFix","id":6507951,"avatar_url":"https://avatars.githubusercontent.com/u/6507951?v=3","gravatar_id":"","url":"https://api.github.com/users/SansPseudoFix","html_url":"https://github.com/SansPseudoFix","followers_url":"https://api.github.com/users/SansPseudoFix/followers","following_url":"https://api.github.com/users/SansPseudoFix/following{/other_user}","gists_url":"https://api.github.com/users/SansPseudoFix/gists{/gist_id}","starred_url":"https://api.github.com/users/SansPseudoFix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SansPseudoFix/subscriptions","organizations_url":"https://api.github.com/users/SansPseudoFix/orgs","repos_url":"https://api.github.com/users/SansPseudoFix/repos","events_url":"https://api.github.com/users/SansPseudoFix/events{/privacy}","received_events_url":"https://api.github.com/users/SansPseudoFix/received_events","type":"User","site_admin":false},"body":"Results : \r\n\r\n![modal_mention](https://cloud.githubusercontent.com/assets/6507951/5229554/8fce6ce6-7719-11e4-9088-5815a4414df7.png)\r\n![modal_mention2](https://cloud.githubusercontent.com/assets/6507951/5229556/92582e8e-7719-11e4-94b3-5d50c35fdcf4.png)\r\n\r\nI wanted to add \r\n````\r\n#new_status_message_pane .modal {\r\n  padding-bottom: 35px; /* or something else */\r\n}\r\n````\r\n\r\nBut I wasn't sure (little bit ugly).","created_at":"2014-11-28T15:17:40Z","updated_at":"2014-11-29T14:40:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c7e06bbf92d88665620bd80af5c8d2ac0c4a633","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/diaspora/diaspora/pulls/5435/commits","review_comments_url":"https://api.github.com/repos/diaspora/diaspora/pulls/5435/comments","review_comment_url":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/{number}","comments_url":"https://api.github.com/repos/diaspora/diaspora/issues/5435/comments","statuses_url":"https://api.github.com/repos/diaspora/diaspora/statuses/c543002b7cffc99e79176bf184ca8753c011f2ed","head":{"label":"SansPseudoFix:5329-fix-mention-popup-hidden","ref":"5329-fix-mention-popup-hidden","sha":"c543002b7cffc99e79176bf184ca8753c011f2ed","user":{"login":"SansPseudoFix","id":6507951,"avatar_url":"https://avatars.githubusercontent.com/u/6507951?v=3","gravatar_id":"","url":"https://api.github.com/users/SansPseudoFix","html_url":"https://github.com/SansPseudoFix","followers_url":"https://api.github.com/users/SansPseudoFix/followers","following_url":"https://api.github.com/users/SansPseudoFix/following{/other_user}","gists_url":"https://api.github.com/users/SansPseudoFix/gists{/gist_id}","starred_url":"https://api.github.com/users/SansPseudoFix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SansPseudoFix/subscriptions","organizations_url":"https://api.github.com/users/SansPseudoFix/orgs","repos_url":"https://api.github.com/users/SansPseudoFix/repos","events_url":"https://api.github.com/users/SansPseudoFix/events{/privacy}","received_events_url":"https://api.github.com/users/SansPseudoFix/received_events","type":"User","site_admin":false},"repo":{"id":16258299,"name":"diaspora","full_name":"SansPseudoFix/diaspora","owner":{"login":"SansPseudoFix","id":6507951,"avatar_url":"https://avatars.githubusercontent.com/u/6507951?v=3","gravatar_id":"","url":"https://api.github.com/users/SansPseudoFix","html_url":"https://github.com/SansPseudoFix","followers_url":"https://api.github.com/users/SansPseudoFix/followers","following_url":"https://api.github.com/users/SansPseudoFix/following{/other_user}","gists_url":"https://api.github.com/users/SansPseudoFix/gists{/gist_id}","starred_url":"https://api.github.com/users/SansPseudoFix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SansPseudoFix/subscriptions","organizations_url":"https://api.github.com/users/SansPseudoFix/orgs","repos_url":"https://api.github.com/users/SansPseudoFix/repos","events_url":"https://api.github.com/users/SansPseudoFix/events{/privacy}","received_events_url":"https://api.github.com/users/SansPseudoFix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SansPseudoFix/diaspora","description":"Distributed and contextual social networking","fork":true,"url":"https://api.github.com/repos/SansPseudoFix/diaspora","forks_url":"https://api.github.com/repos/SansPseudoFix/diaspora/forks","keys_url":"https://api.github.com/repos/SansPseudoFix/diaspora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SansPseudoFix/diaspora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SansPseudoFix/diaspora/teams","hooks_url":"https://api.github.com/repos/SansPseudoFix/diaspora/hooks","issue_events_url":"https://api.github.com/repos/SansPseudoFix/diaspora/issues/events{/number}","events_url":"https://api.github.com/repos/SansPseudoFix/diaspora/events","assignees_url":"https://api.github.com/repos/SansPseudoFix/diaspora/assignees{/user}","branches_url":"https://api.github.com/repos/SansPseudoFix/diaspora/branches{/branch}","tags_url":"https://api.github.com/repos/SansPseudoFix/diaspora/tags","blobs_url":"https://api.github.com/repos/SansPseudoFix/diaspora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SansPseudoFix/diaspora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SansPseudoFix/diaspora/git/refs{/sha}","trees_url":"https://api.github.com/repos/SansPseudoFix/diaspora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SansPseudoFix/diaspora/statuses/{sha}","languages_url":"https://api.github.com/repos/SansPseudoFix/diaspora/languages","stargazers_url":"https://api.github.com/repos/SansPseudoFix/diaspora/stargazers","contributors_url":"https://api.github.com/repos/SansPseudoFix/diaspora/contributors","subscribers_url":"https://api.github.com/repos/SansPseudoFix/diaspora/subscribers","subscription_url":"https://api.github.com/repos/SansPseudoFix/diaspora/subscription","commits_url":"https://api.github.com/repos/SansPseudoFix/diaspora/commits{/sha}","git_commits_url":"https://api.github.com/repos/SansPseudoFix/diaspora/git/commits{/sha}","comments_url":"https://api.github.com/repos/SansPseudoFix/diaspora/comments{/number}","issue_comment_url":"https://api.github.com/repos/SansPseudoFix/diaspora/issues/comments/{number}","contents_url":"https://api.github.com/repos/SansPseudoFix/diaspora/contents/{+path}","compare_url":"https://api.github.com/repos/SansPseudoFix/diaspora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SansPseudoFix/diaspora/merges","archive_url":"https://api.github.com/repos/SansPseudoFix/diaspora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SansPseudoFix/diaspora/downloads","issues_url":"https://api.github.com/repos/SansPseudoFix/diaspora/issues{/number}","pulls_url":"https://api.github.com/repos/SansPseudoFix/diaspora/pulls{/number}","milestones_url":"https://api.github.com/repos/SansPseudoFix/diaspora/milestones{/number}","notifications_url":"https://api.github.com/repos/SansPseudoFix/diaspora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SansPseudoFix/diaspora/labels{/name}","releases_url":"https://api.github.com/repos/SansPseudoFix/diaspora/releases{/id}","created_at":"2014-01-26T18:05:11Z","updated_at":"2014-11-21T16:31:24Z","pushed_at":"2014-11-28T15:11:54Z","git_url":"git://github.com/SansPseudoFix/diaspora.git","ssh_url":"git@github.com:SansPseudoFix/diaspora.git","clone_url":"https://github.com/SansPseudoFix/diaspora.git","svn_url":"https://github.com/SansPseudoFix/diaspora","homepage":"https://diasporafoundation.org/","size":96894,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"diaspora:develop","ref":"develop","sha":"5126283666962fbb90ccec0f4cf2344fcc1e3d15","user":{"login":"diaspora","id":293207,"avatar_url":"https://avatars.githubusercontent.com/u/293207?v=3","gravatar_id":"","url":"https://api.github.com/users/diaspora","html_url":"https://github.com/diaspora","followers_url":"https://api.github.com/users/diaspora/followers","following_url":"https://api.github.com/users/diaspora/following{/other_user}","gists_url":"https://api.github.com/users/diaspora/gists{/gist_id}","starred_url":"https://api.github.com/users/diaspora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diaspora/subscriptions","organizations_url":"https://api.github.com/users/diaspora/orgs","repos_url":"https://api.github.com/users/diaspora/repos","events_url":"https://api.github.com/users/diaspora/events{/privacy}","received_events_url":"https://api.github.com/users/diaspora/received_events","type":"Organization","site_admin":false},"repo":{"id":911765,"name":"diaspora","full_name":"diaspora/diaspora","owner":{"login":"diaspora","id":293207,"avatar_url":"https://avatars.githubusercontent.com/u/293207?v=3","gravatar_id":"","url":"https://api.github.com/users/diaspora","html_url":"https://github.com/diaspora","followers_url":"https://api.github.com/users/diaspora/followers","following_url":"https://api.github.com/users/diaspora/following{/other_user}","gists_url":"https://api.github.com/users/diaspora/gists{/gist_id}","starred_url":"https://api.github.com/users/diaspora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diaspora/subscriptions","organizations_url":"https://api.github.com/users/diaspora/orgs","repos_url":"https://api.github.com/users/diaspora/repos","events_url":"https://api.github.com/users/diaspora/events{/privacy}","received_events_url":"https://api.github.com/users/diaspora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diaspora/diaspora","description":"Distributed and contextual social networking","fork":false,"url":"https://api.github.com/repos/diaspora/diaspora","forks_url":"https://api.github.com/repos/diaspora/diaspora/forks","keys_url":"https://api.github.com/repos/diaspora/diaspora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diaspora/diaspora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diaspora/diaspora/teams","hooks_url":"https://api.github.com/repos/diaspora/diaspora/hooks","issue_events_url":"https://api.github.com/repos/diaspora/diaspora/issues/events{/number}","events_url":"https://api.github.com/repos/diaspora/diaspora/events","assignees_url":"https://api.github.com/repos/diaspora/diaspora/assignees{/user}","branches_url":"https://api.github.com/repos/diaspora/diaspora/branches{/branch}","tags_url":"https://api.github.com/repos/diaspora/diaspora/tags","blobs_url":"https://api.github.com/repos/diaspora/diaspora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diaspora/diaspora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diaspora/diaspora/git/refs{/sha}","trees_url":"https://api.github.com/repos/diaspora/diaspora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diaspora/diaspora/statuses/{sha}","languages_url":"https://api.github.com/repos/diaspora/diaspora/languages","stargazers_url":"https://api.github.com/repos/diaspora/diaspora/stargazers","contributors_url":"https://api.github.com/repos/diaspora/diaspora/contributors","subscribers_url":"https://api.github.com/repos/diaspora/diaspora/subscribers","subscription_url":"https://api.github.com/repos/diaspora/diaspora/subscription","commits_url":"https://api.github.com/repos/diaspora/diaspora/commits{/sha}","git_commits_url":"https://api.github.com/repos/diaspora/diaspora/git/commits{/sha}","comments_url":"https://api.github.com/repos/diaspora/diaspora/comments{/number}","issue_comment_url":"https://api.github.com/repos/diaspora/diaspora/issues/comments/{number}","contents_url":"https://api.github.com/repos/diaspora/diaspora/contents/{+path}","compare_url":"https://api.github.com/repos/diaspora/diaspora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diaspora/diaspora/merges","archive_url":"https://api.github.com/repos/diaspora/diaspora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diaspora/diaspora/downloads","issues_url":"https://api.github.com/repos/diaspora/diaspora/issues{/number}","pulls_url":"https://api.github.com/repos/diaspora/diaspora/pulls{/number}","milestones_url":"https://api.github.com/repos/diaspora/diaspora/milestones{/number}","notifications_url":"https://api.github.com/repos/diaspora/diaspora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diaspora/diaspora/labels{/name}","releases_url":"https://api.github.com/repos/diaspora/diaspora/releases{/id}","created_at":"2010-09-15T05:20:04Z","updated_at":"2014-11-29T14:33:20Z","pushed_at":"2014-11-29T14:33:19Z","git_url":"git://github.com/diaspora/diaspora.git","ssh_url":"git@github.com:diaspora/diaspora.git","clone_url":"https://github.com/diaspora/diaspora.git","svn_url":"https://github.com/diaspora/diaspora","homepage":"https://diasporafoundation.org/","size":320190,"stargazers_count":9643,"watchers_count":9643,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2449,"mirror_url":null,"open_issues_count":431,"forks":2449,"open_issues":431,"watchers":9643,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/5435"},"html":{"href":"https://github.com/diaspora/diaspora/pull/5435"},"issue":{"href":"https://api.github.com/repos/diaspora/diaspora/issues/5435"},"comments":{"href":"https://api.github.com/repos/diaspora/diaspora/issues/5435/comments"},"review_comments":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/5435/comments"},"review_comment":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/5435/commits"},"statuses":{"href":"https://api.github.com/repos/diaspora/diaspora/statuses/c543002b7cffc99e79176bf184ca8753c011f2ed"}}}}