GitHub PullRequestReviewCommentEvent at 2014-12-02 23:35:35
Repository: Ghost
Actor: Gargol
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/21201770","id":21201770,"diff_hunk":"@@ -34,15 +49,49 @@ var TagsController = Ember.ArrayController.extend(PaginationMixin, {\n                 self.notifications.showAPIError(error);\n             });\n         },\n-        saveTag: function (tag) {\n-            var name = tag.get('name'),\n-                self = this;\n \n-            tag.save().then(function () {\n-                self.notifications.showSuccess('Saved ' + name);\n-            }).catch(function (error) {\n-                self.notifications.showAPIError(error);\n+        saveActiveTagName: function (name) {\n+            var activeTag = this.get('activeTag'),\n+                currentName = this.get('activeTag.name') || '';\n+\n+            if (!name || name === currentName) {","path":"core/client/controllers/settings/tags.js","position":64,"original_position":64,"commit_id":"d54b812f3419f294886442abae06b972b94dad2e","original_commit_id":"d54b812f3419f294886442abae06b972b94dad2e","user":{"login":"Gargol","id":675397,"avatar_url":"https://avatars.githubusercontent.com/u/675397?v=3","gravatar_id":"","url":"https://api.github.com/users/Gargol","html_url":"https://github.com/Gargol","followers_url":"https://api.github.com/users/Gargol/followers","following_url":"https://api.github.com/users/Gargol/following{/other_user}","gists_url":"https://api.github.com/users/Gargol/gists{/gist_id}","starred_url":"https://api.github.com/users/Gargol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gargol/subscriptions","organizations_url":"https://api.github.com/users/Gargol/orgs","repos_url":"https://api.github.com/users/Gargol/repos","events_url":"https://api.github.com/users/Gargol/events{/privacy}","received_events_url":"https://api.github.com/users/Gargol/received_events","type":"User","site_admin":false},"body":"I guess adding `.trim()` to slug/description instead of defaulting them to `''` would be a good idea as well ?","created_at":"2014-12-02T23:35:35Z","updated_at":"2014-12-02T23:35:35Z","html_url":"https://github.com/TryGhost/Ghost/pull/4564#discussion_r21201770","pull_request_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/4564","_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/21201770"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/4564#discussion_r21201770"},"pull_request":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/4564"}}},"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/4564","id":25305656,"html_url":"https://github.com/TryGhost/Ghost/pull/4564","diff_url":"https://github.com/TryGhost/Ghost/pull/4564.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/4564.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/4564","number":4564,"state":"open","locked":false,"title":"Tag Settings Menu Autosave","user":{"login":"Gargol","id":675397,"avatar_url":"https://avatars.githubusercontent.com/u/675397?v=3","gravatar_id":"","url":"https://api.github.com/users/Gargol","html_url":"https://github.com/Gargol","followers_url":"https://api.github.com/users/Gargol/followers","following_url":"https://api.github.com/users/Gargol/following{/other_user}","gists_url":"https://api.github.com/users/Gargol/gists{/gist_id}","starred_url":"https://api.github.com/users/Gargol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gargol/subscriptions","organizations_url":"https://api.github.com/users/Gargol/orgs","repos_url":"https://api.github.com/users/Gargol/repos","events_url":"https://api.github.com/users/Gargol/events{/privacy}","received_events_url":"https://api.github.com/users/Gargol/received_events","type":"User","site_admin":false},"body":"closes #4517\r\n\r\n- adds autosave to name/slug/description fields in TSM\r\n- adds nprogress indicator when saving","created_at":"2014-12-01T22:52:42Z","updated_at":"2014-12-02T23:35:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c2321c6e2642b1f1018ab51f80ed63e99c6ff21","assignee":{"login":"novaugust","id":1207005,"avatar_url":"https://avatars.githubusercontent.com/u/1207005?v=3","gravatar_id":"","url":"https://api.github.com/users/novaugust","html_url":"https://github.com/novaugust","followers_url":"https://api.github.com/users/novaugust/followers","following_url":"https://api.github.com/users/novaugust/following{/other_user}","gists_url":"https://api.github.com/users/novaugust/gists{/gist_id}","starred_url":"https://api.github.com/users/novaugust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novaugust/subscriptions","organizations_url":"https://api.github.com/users/novaugust/orgs","repos_url":"https://api.github.com/users/novaugust/repos","events_url":"https://api.github.com/users/novaugust/events{/privacy}","received_events_url":"https://api.github.com/users/novaugust/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/4564/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/4564/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/4564/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/d54b812f3419f294886442abae06b972b94dad2e","head":{"label":"Gargol:issue-4517","ref":"issue-4517","sha":"d54b812f3419f294886442abae06b972b94dad2e","user":{"login":"Gargol","id":675397,"avatar_url":"https://avatars.githubusercontent.com/u/675397?v=3","gravatar_id":"","url":"https://api.github.com/users/Gargol","html_url":"https://github.com/Gargol","followers_url":"https://api.github.com/users/Gargol/followers","following_url":"https://api.github.com/users/Gargol/following{/other_user}","gists_url":"https://api.github.com/users/Gargol/gists{/gist_id}","starred_url":"https://api.github.com/users/Gargol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gargol/subscriptions","organizations_url":"https://api.github.com/users/Gargol/orgs","repos_url":"https://api.github.com/users/Gargol/repos","events_url":"https://api.github.com/users/Gargol/events{/privacy}","received_events_url":"https://api.github.com/users/Gargol/received_events","type":"User","site_admin":false},"repo":{"id":22947893,"name":"Ghost","full_name":"Gargol/Ghost","owner":{"login":"Gargol","id":675397,"avatar_url":"https://avatars.githubusercontent.com/u/675397?v=3","gravatar_id":"","url":"https://api.github.com/users/Gargol","html_url":"https://github.com/Gargol","followers_url":"https://api.github.com/users/Gargol/followers","following_url":"https://api.github.com/users/Gargol/following{/other_user}","gists_url":"https://api.github.com/users/Gargol/gists{/gist_id}","starred_url":"https://api.github.com/users/Gargol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gargol/subscriptions","organizations_url":"https://api.github.com/users/Gargol/orgs","repos_url":"https://api.github.com/users/Gargol/repos","events_url":"https://api.github.com/users/Gargol/events{/privacy}","received_events_url":"https://api.github.com/users/Gargol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gargol/Ghost","description":"Just a blogging platform","fork":true,"url":"https://api.github.com/repos/Gargol/Ghost","forks_url":"https://api.github.com/repos/Gargol/Ghost/forks","keys_url":"https://api.github.com/repos/Gargol/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gargol/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gargol/Ghost/teams","hooks_url":"https://api.github.com/repos/Gargol/Ghost/hooks","issue_events_url":"https://api.github.com/repos/Gargol/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/Gargol/Ghost/events","assignees_url":"https://api.github.com/repos/Gargol/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/Gargol/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/Gargol/Ghost/tags","blobs_url":"https://api.github.com/repos/Gargol/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gargol/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gargol/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gargol/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gargol/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/Gargol/Ghost/languages","stargazers_url":"https://api.github.com/repos/Gargol/Ghost/stargazers","contributors_url":"https://api.github.com/repos/Gargol/Ghost/contributors","subscribers_url":"https://api.github.com/repos/Gargol/Ghost/subscribers","subscription_url":"https://api.github.com/repos/Gargol/Ghost/subscription","commits_url":"https://api.github.com/repos/Gargol/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gargol/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gargol/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gargol/Ghost/issues/comments/{number}","contents_url":"https://api.github.com/repos/Gargol/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/Gargol/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gargol/Ghost/merges","archive_url":"https://api.github.com/repos/Gargol/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gargol/Ghost/downloads","issues_url":"https://api.github.com/repos/Gargol/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/Gargol/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/Gargol/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/Gargol/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gargol/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/Gargol/Ghost/releases{/id}","created_at":"2014-08-14T09:07:42Z","updated_at":"2014-12-02T21:43:57Z","pushed_at":"2014-12-02T23:23:08Z","git_url":"git://github.com/Gargol/Ghost.git","ssh_url":"git@github.com:Gargol/Ghost.git","clone_url":"https://github.com/Gargol/Ghost.git","svn_url":"https://github.com/Gargol/Ghost","homepage":"https://ghost.org","size":14798,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"9b8141bb08a3f102f83615cb785fc2969fec35a7","user":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"name":"Ghost","full_name":"TryGhost/Ghost","owner":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars.githubusercontent.com/u/2178663?v=3","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TryGhost/Ghost","description":"Just a blogging platform","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments/{number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","created_at":"2013-05-04T11:09:13Z","updated_at":"2014-12-02T22:10:27Z","pushed_at":"2014-12-02T19:49:47Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":69381,"stargazers_count":13143,"watchers_count":13143,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2919,"mirror_url":null,"open_issues_count":222,"forks":2919,"open_issues":222,"watchers":13143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/4564"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/4564"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/4564"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/4564/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/4564/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/4564/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/d54b812f3419f294886442abae06b972b94dad2e"}}}}