GitHub PullRequestReviewCommentEvent at 2014-10-20 23:37:24
Repository: pathauto
Actor: Berdir
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/md-systems/pathauto/pulls/comments/19121788","id":19121788,"diff_hunk":"@@ -0,0 +1,153 @@\n+<?php\n+\n+/**\n+ * @file\n+ * Contains Drupal\\pathauto\\Plugin\\AliasType\\NodeAliasType\n+ */\n+\n+namespace Drupal\\pathauto\\Plugin\\pathauto\\AliasType;\n+\n+use Drupal\\Core\\Extension\\ModuleHandlerInterface;\n+use Drupal\\Core\\Form\\FormStateInterface;\n+use Drupal\\Core\\Language\\LanguageInterface;\n+use Drupal\\Core\\Language\\LanguageManagerInterface;\n+use Drupal\\Core\\Plugin\\ContainerFactoryPluginInterface;\n+use Symfony\\Component\\DependencyInjection\\ContainerInterface;\n+\n+/**\n+ * A pathauto alias type plugin for content entities.\n+ *\n+ * @AliasType(\n+ *   id = \"content_entity_alias_type\",\n+ *   label = @Translation(\"Pathauto alias for nodes.\"),","path":"src/Plugin/pathauto/AliasType/NodeAliasType.php","position":22,"original_position":22,"commit_id":"a2db9a41dce5b16efb2519c62864ddd99d01752c","original_commit_id":"a2db9a41dce5b16efb2519c62864ddd99d01752c","user":{"login":"Berdir","id":40826,"avatar_url":"https://avatars.githubusercontent.com/u/40826?v=2","gravatar_id":"","url":"https://api.github.com/users/Berdir","html_url":"https://github.com/Berdir","followers_url":"https://api.github.com/users/Berdir/followers","following_url":"https://api.github.com/users/Berdir/following{/other_user}","gists_url":"https://api.github.com/users/Berdir/gists{/gist_id}","starred_url":"https://api.github.com/users/Berdir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Berdir/subscriptions","organizations_url":"https://api.github.com/users/Berdir/orgs","repos_url":"https://api.github.com/users/Berdir/repos","events_url":"https://api.github.com/users/Berdir/events{/privacy}","received_events_url":"https://api.github.com/users/Berdir/received_events","type":"User","site_admin":false},"body":"the id should be just node IMHO. No need to repeat the plugin type.\r\n\r\nWhen/if we switch to entities, the derivate id will become entity:node, but for now, node is IMHO fine.","created_at":"2014-10-20T23:37:24Z","updated_at":"2014-10-20T23:37:24Z","html_url":"https://github.com/md-systems/pathauto/pull/15#discussion_r19121788","pull_request_url":"https://api.github.com/repos/md-systems/pathauto/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/md-systems/pathauto/pulls/comments/19121788"},"html":{"href":"https://github.com/md-systems/pathauto/pull/15#discussion_r19121788"},"pull_request":{"href":"https://api.github.com/repos/md-systems/pathauto/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/md-systems/pathauto/pulls/15","id":20600956,"html_url":"https://github.com/md-systems/pathauto/pull/15","diff_url":"https://github.com/md-systems/pathauto/pull/15.diff","patch_url":"https://github.com/md-systems/pathauto/pull/15.patch","issue_url":"https://api.github.com/repos/md-systems/pathauto/issues/15","number":15,"state":"open","locked":false,"title":"AliasType plugins","user":{"login":"kimpepper","id":6132,"avatar_url":"https://avatars.githubusercontent.com/u/6132?v=2","gravatar_id":"","url":"https://api.github.com/users/kimpepper","html_url":"https://github.com/kimpepper","followers_url":"https://api.github.com/users/kimpepper/followers","following_url":"https://api.github.com/users/kimpepper/following{/other_user}","gists_url":"https://api.github.com/users/kimpepper/gists{/gist_id}","starred_url":"https://api.github.com/users/kimpepper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimpepper/subscriptions","organizations_url":"https://api.github.com/users/kimpepper/orgs","repos_url":"https://api.github.com/users/kimpepper/repos","events_url":"https://api.github.com/users/kimpepper/events{/privacy}","received_events_url":"https://api.github.com/users/kimpepper/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-09-02T09:30:28Z","updated_at":"2014-10-20T23:37:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f414a21bf67a39a3ca74a7944550afd220fb723","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/md-systems/pathauto/pulls/15/commits","review_comments_url":"https://api.github.com/repos/md-systems/pathauto/pulls/15/comments","review_comment_url":"https://api.github.com/repos/md-systems/pathauto/pulls/comments/{number}","comments_url":"https://api.github.com/repos/md-systems/pathauto/issues/15/comments","statuses_url":"https://api.github.com/repos/md-systems/pathauto/statuses/a2db9a41dce5b16efb2519c62864ddd99d01752c","head":{"label":"kimpepper:alias-type-plugins","ref":"alias-type-plugins","sha":"a2db9a41dce5b16efb2519c62864ddd99d01752c","user":{"login":"kimpepper","id":6132,"avatar_url":"https://avatars.githubusercontent.com/u/6132?v=2","gravatar_id":"","url":"https://api.github.com/users/kimpepper","html_url":"https://github.com/kimpepper","followers_url":"https://api.github.com/users/kimpepper/followers","following_url":"https://api.github.com/users/kimpepper/following{/other_user}","gists_url":"https://api.github.com/users/kimpepper/gists{/gist_id}","starred_url":"https://api.github.com/users/kimpepper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimpepper/subscriptions","organizations_url":"https://api.github.com/users/kimpepper/orgs","repos_url":"https://api.github.com/users/kimpepper/repos","events_url":"https://api.github.com/users/kimpepper/events{/privacy}","received_events_url":"https://api.github.com/users/kimpepper/received_events","type":"User","site_admin":false},"repo":{"id":21814878,"name":"pathauto","full_name":"kimpepper/pathauto","owner":{"login":"kimpepper","id":6132,"avatar_url":"https://avatars.githubusercontent.com/u/6132?v=2","gravatar_id":"","url":"https://api.github.com/users/kimpepper","html_url":"https://github.com/kimpepper","followers_url":"https://api.github.com/users/kimpepper/followers","following_url":"https://api.github.com/users/kimpepper/following{/other_user}","gists_url":"https://api.github.com/users/kimpepper/gists{/gist_id}","starred_url":"https://api.github.com/users/kimpepper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimpepper/subscriptions","organizations_url":"https://api.github.com/users/kimpepper/orgs","repos_url":"https://api.github.com/users/kimpepper/repos","events_url":"https://api.github.com/users/kimpepper/events{/privacy}","received_events_url":"https://api.github.com/users/kimpepper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kimpepper/pathauto","description":"Sandbox for D8 port of pathauto","fork":true,"url":"https://api.github.com/repos/kimpepper/pathauto","forks_url":"https://api.github.com/repos/kimpepper/pathauto/forks","keys_url":"https://api.github.com/repos/kimpepper/pathauto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kimpepper/pathauto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kimpepper/pathauto/teams","hooks_url":"https://api.github.com/repos/kimpepper/pathauto/hooks","issue_events_url":"https://api.github.com/repos/kimpepper/pathauto/issues/events{/number}","events_url":"https://api.github.com/repos/kimpepper/pathauto/events","assignees_url":"https://api.github.com/repos/kimpepper/pathauto/assignees{/user}","branches_url":"https://api.github.com/repos/kimpepper/pathauto/branches{/branch}","tags_url":"https://api.github.com/repos/kimpepper/pathauto/tags","blobs_url":"https://api.github.com/repos/kimpepper/pathauto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kimpepper/pathauto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kimpepper/pathauto/git/refs{/sha}","trees_url":"https://api.github.com/repos/kimpepper/pathauto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kimpepper/pathauto/statuses/{sha}","languages_url":"https://api.github.com/repos/kimpepper/pathauto/languages","stargazers_url":"https://api.github.com/repos/kimpepper/pathauto/stargazers","contributors_url":"https://api.github.com/repos/kimpepper/pathauto/contributors","subscribers_url":"https://api.github.com/repos/kimpepper/pathauto/subscribers","subscription_url":"https://api.github.com/repos/kimpepper/pathauto/subscription","commits_url":"https://api.github.com/repos/kimpepper/pathauto/commits{/sha}","git_commits_url":"https://api.github.com/repos/kimpepper/pathauto/git/commits{/sha}","comments_url":"https://api.github.com/repos/kimpepper/pathauto/comments{/number}","issue_comment_url":"https://api.github.com/repos/kimpepper/pathauto/issues/comments/{number}","contents_url":"https://api.github.com/repos/kimpepper/pathauto/contents/{+path}","compare_url":"https://api.github.com/repos/kimpepper/pathauto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kimpepper/pathauto/merges","archive_url":"https://api.github.com/repos/kimpepper/pathauto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kimpepper/pathauto/downloads","issues_url":"https://api.github.com/repos/kimpepper/pathauto/issues{/number}","pulls_url":"https://api.github.com/repos/kimpepper/pathauto/pulls{/number}","milestones_url":"https://api.github.com/repos/kimpepper/pathauto/milestones{/number}","notifications_url":"https://api.github.com/repos/kimpepper/pathauto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kimpepper/pathauto/labels{/name}","releases_url":"https://api.github.com/repos/kimpepper/pathauto/releases{/id}","created_at":"2014-07-14T09:51:23Z","updated_at":"2014-07-15T10:28:14Z","pushed_at":"2014-10-02T08:02:22Z","git_url":"git://github.com/kimpepper/pathauto.git","ssh_url":"git@github.com:kimpepper/pathauto.git","clone_url":"https://github.com/kimpepper/pathauto.git","svn_url":"https://github.com/kimpepper/pathauto","homepage":null,"size":1974,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x-1.x"}},"base":{"label":"md-systems:8.x-1.x","ref":"8.x-1.x","sha":"0ef014cdffc7412ac898df231eb1be21a1497b0b","user":{"login":"md-systems","id":4949412,"avatar_url":"https://avatars.githubusercontent.com/u/4949412?v=2","gravatar_id":"","url":"https://api.github.com/users/md-systems","html_url":"https://github.com/md-systems","followers_url":"https://api.github.com/users/md-systems/followers","following_url":"https://api.github.com/users/md-systems/following{/other_user}","gists_url":"https://api.github.com/users/md-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/md-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/md-systems/subscriptions","organizations_url":"https://api.github.com/users/md-systems/orgs","repos_url":"https://api.github.com/users/md-systems/repos","events_url":"https://api.github.com/users/md-systems/events{/privacy}","received_events_url":"https://api.github.com/users/md-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":17961698,"name":"pathauto","full_name":"md-systems/pathauto","owner":{"login":"md-systems","id":4949412,"avatar_url":"https://avatars.githubusercontent.com/u/4949412?v=2","gravatar_id":"","url":"https://api.github.com/users/md-systems","html_url":"https://github.com/md-systems","followers_url":"https://api.github.com/users/md-systems/followers","following_url":"https://api.github.com/users/md-systems/following{/other_user}","gists_url":"https://api.github.com/users/md-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/md-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/md-systems/subscriptions","organizations_url":"https://api.github.com/users/md-systems/orgs","repos_url":"https://api.github.com/users/md-systems/repos","events_url":"https://api.github.com/users/md-systems/events{/privacy}","received_events_url":"https://api.github.com/users/md-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/md-systems/pathauto","description":"Sandbox for D8 port of pathauto","fork":true,"url":"https://api.github.com/repos/md-systems/pathauto","forks_url":"https://api.github.com/repos/md-systems/pathauto/forks","keys_url":"https://api.github.com/repos/md-systems/pathauto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/md-systems/pathauto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/md-systems/pathauto/teams","hooks_url":"https://api.github.com/repos/md-systems/pathauto/hooks","issue_events_url":"https://api.github.com/repos/md-systems/pathauto/issues/events{/number}","events_url":"https://api.github.com/repos/md-systems/pathauto/events","assignees_url":"https://api.github.com/repos/md-systems/pathauto/assignees{/user}","branches_url":"https://api.github.com/repos/md-systems/pathauto/branches{/branch}","tags_url":"https://api.github.com/repos/md-systems/pathauto/tags","blobs_url":"https://api.github.com/repos/md-systems/pathauto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/md-systems/pathauto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/md-systems/pathauto/git/refs{/sha}","trees_url":"https://api.github.com/repos/md-systems/pathauto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/md-systems/pathauto/statuses/{sha}","languages_url":"https://api.github.com/repos/md-systems/pathauto/languages","stargazers_url":"https://api.github.com/repos/md-systems/pathauto/stargazers","contributors_url":"https://api.github.com/repos/md-systems/pathauto/contributors","subscribers_url":"https://api.github.com/repos/md-systems/pathauto/subscribers","subscription_url":"https://api.github.com/repos/md-systems/pathauto/subscription","commits_url":"https://api.github.com/repos/md-systems/pathauto/commits{/sha}","git_commits_url":"https://api.github.com/repos/md-systems/pathauto/git/commits{/sha}","comments_url":"https://api.github.com/repos/md-systems/pathauto/comments{/number}","issue_comment_url":"https://api.github.com/repos/md-systems/pathauto/issues/comments/{number}","contents_url":"https://api.github.com/repos/md-systems/pathauto/contents/{+path}","compare_url":"https://api.github.com/repos/md-systems/pathauto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/md-systems/pathauto/merges","archive_url":"https://api.github.com/repos/md-systems/pathauto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/md-systems/pathauto/downloads","issues_url":"https://api.github.com/repos/md-systems/pathauto/issues{/number}","pulls_url":"https://api.github.com/repos/md-systems/pathauto/pulls{/number}","milestones_url":"https://api.github.com/repos/md-systems/pathauto/milestones{/number}","notifications_url":"https://api.github.com/repos/md-systems/pathauto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/md-systems/pathauto/labels{/name}","releases_url":"https://api.github.com/repos/md-systems/pathauto/releases{/id}","created_at":"2014-03-20T23:08:36Z","updated_at":"2014-10-14T16:51:49Z","pushed_at":"2014-10-20T23:27:23Z","git_url":"git://github.com/md-systems/pathauto.git","ssh_url":"git@github.com:md-systems/pathauto.git","clone_url":"https://github.com/md-systems/pathauto.git","svn_url":"https://github.com/md-systems/pathauto","homepage":null,"size":2802,"stargazers_count":10,"watchers_count":10,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":10,"default_branch":"8.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/md-systems/pathauto/pulls/15"},"html":{"href":"https://github.com/md-systems/pathauto/pull/15"},"issue":{"href":"https://api.github.com/repos/md-systems/pathauto/issues/15"},"comments":{"href":"https://api.github.com/repos/md-systems/pathauto/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/md-systems/pathauto/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/md-systems/pathauto/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/md-systems/pathauto/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/md-systems/pathauto/statuses/a2db9a41dce5b16efb2519c62864ddd99d01752c"}}}}