GitHub PullRequestReviewCommentEvent at 2014-07-09 08:07:27
Repository: fs2open.github.com
Actor: asarium
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/asarium/fs2open.github.com/pulls/comments/14697692","id":14697692,"diff_hunk":"@@ -100,6 +100,8 @@ OPTION(FSO_CMAKE_DEBUG \"Enable cmake debugging in while generating build files\"\n \n OPTION(COTIRE_ENABLE \"Enable cotire, disabling may be useful for cmake files development\" ON)\n \n+OPTION(CEF_PATH \"Path to the CEF files\" OFF)","path":"CMakeLists.txt","position":4,"original_position":4,"commit_id":"c1a22ce2336fe5fcd4aa95bb5ccc7e0313bc8e66","original_commit_id":"c1a22ce2336fe5fcd4aa95bb5ccc7e0313bc8e66","user":{"login":"asarium","id":1013983,"avatar_url":"https://avatars.githubusercontent.com/u/1013983?","gravatar_id":"c445b2e3372a28c927d1c27c1f1fa5d4","url":"https://api.github.com/users/asarium","html_url":"https://github.com/asarium","followers_url":"https://api.github.com/users/asarium/followers","following_url":"https://api.github.com/users/asarium/following{/other_user}","gists_url":"https://api.github.com/users/asarium/gists{/gist_id}","starred_url":"https://api.github.com/users/asarium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asarium/subscriptions","organizations_url":"https://api.github.com/users/asarium/orgs","repos_url":"https://api.github.com/users/asarium/repos","events_url":"https://api.github.com/users/asarium/events{/privacy}","received_events_url":"https://api.github.com/users/asarium/received_events","type":"User","site_admin":false},"body":"The name `CEF_PATH` implies that this should be a path variable but instead you use the `OPTION` command. You might want to change that to a cache variable.","created_at":"2014-07-09T08:07:27Z","updated_at":"2014-07-09T08:07:27Z","html_url":"https://github.com/asarium/fs2open.github.com/pull/1#discussion_r14697692","pull_request_url":"https://api.github.com/repos/asarium/fs2open.github.com/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/asarium/fs2open.github.com/pulls/comments/14697692"},"html":{"href":"https://github.com/asarium/fs2open.github.com/pull/1#discussion_r14697692"},"pull_request":{"href":"https://api.github.com/repos/asarium/fs2open.github.com/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/asarium/fs2open.github.com/pulls/1","id":18048397,"html_url":"https://github.com/asarium/fs2open.github.com/pull/1","diff_url":"https://github.com/asarium/fs2open.github.com/pull/1.diff","patch_url":"https://github.com/asarium/fs2open.github.com/pull/1.patch","issue_url":"https://api.github.com/repos/asarium/fs2open.github.com/issues/1","number":1,"state":"open","title":"Make it possible to compile this on Linux","user":{"login":"ngld","id":5465775,"avatar_url":"https://avatars.githubusercontent.com/u/5465775?","gravatar_id":"a35d45df853d11a5db477404ce67b9eb","url":"https://api.github.com/users/ngld","html_url":"https://github.com/ngld","followers_url":"https://api.github.com/users/ngld/followers","following_url":"https://api.github.com/users/ngld/following{/other_user}","gists_url":"https://api.github.com/users/ngld/gists{/gist_id}","starred_url":"https://api.github.com/users/ngld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngld/subscriptions","organizations_url":"https://api.github.com/users/ngld/orgs","repos_url":"https://api.github.com/users/ngld/repos","events_url":"https://api.github.com/users/ngld/events{/privacy}","received_events_url":"https://api.github.com/users/ngld/received_events","type":"User","site_admin":false},"body":"The changes to cmake/util.cmake aren't mine, I simply copied the file from the cmake branch.\r\nI added GTK as a dependency for the CEF headers and made some small changes to make gcc happy.\r\n\r\nThis isn't finished yet, right now [Boost fails to compile](https://gist.github.com/ngld/25248cab5411214df7f0) since it doesn't like SCP's ```strcat_s()``` and ```strcpy_s()```.","created_at":"2014-07-07T14:51:05Z","updated_at":"2014-07-09T08:07:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01792418793020c2dce85d0c613713050fb14625","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/asarium/fs2open.github.com/pulls/1/commits","review_comments_url":"https://api.github.com/repos/asarium/fs2open.github.com/pulls/1/comments","review_comment_url":"https://api.github.com/repos/asarium/fs2open.github.com/pulls/comments/{number}","comments_url":"https://api.github.com/repos/asarium/fs2open.github.com/issues/1/comments","statuses_url":"https://api.github.com/repos/asarium/fs2open.github.com/statuses/c1a22ce2336fe5fcd4aa95bb5ccc7e0313bc8e66","head":{"label":"ngld:feature/chromiumInput","ref":"feature/chromiumInput","sha":"c1a22ce2336fe5fcd4aa95bb5ccc7e0313bc8e66","user":{"login":"ngld","id":5465775,"avatar_url":"https://avatars.githubusercontent.com/u/5465775?","gravatar_id":"a35d45df853d11a5db477404ce67b9eb","url":"https://api.github.com/users/ngld","html_url":"https://github.com/ngld","followers_url":"https://api.github.com/users/ngld/followers","following_url":"https://api.github.com/users/ngld/following{/other_user}","gists_url":"https://api.github.com/users/ngld/gists{/gist_id}","starred_url":"https://api.github.com/users/ngld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngld/subscriptions","organizations_url":"https://api.github.com/users/ngld/orgs","repos_url":"https://api.github.com/users/ngld/repos","events_url":"https://api.github.com/users/ngld/events{/privacy}","received_events_url":"https://api.github.com/users/ngld/received_events","type":"User","site_admin":false},"repo":{"id":17677411,"name":"fs2open","full_name":"ngld/fs2open","owner":{"login":"ngld","id":5465775,"avatar_url":"https://avatars.githubusercontent.com/u/5465775?","gravatar_id":"a35d45df853d11a5db477404ce67b9eb","url":"https://api.github.com/users/ngld","html_url":"https://github.com/ngld","followers_url":"https://api.github.com/users/ngld/followers","following_url":"https://api.github.com/users/ngld/following{/other_user}","gists_url":"https://api.github.com/users/ngld/gists{/gist_id}","starred_url":"https://api.github.com/users/ngld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngld/subscriptions","organizations_url":"https://api.github.com/users/ngld/orgs","repos_url":"https://api.github.com/users/ngld/repos","events_url":"https://api.github.com/users/ngld/events{/privacy}","received_events_url":"https://api.github.com/users/ngld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngld/fs2open","description":"Origin Repository for SCP FreeSpace 2 Open","fork":true,"url":"https://api.github.com/repos/ngld/fs2open","forks_url":"https://api.github.com/repos/ngld/fs2open/forks","keys_url":"https://api.github.com/repos/ngld/fs2open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngld/fs2open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngld/fs2open/teams","hooks_url":"https://api.github.com/repos/ngld/fs2open/hooks","issue_events_url":"https://api.github.com/repos/ngld/fs2open/issues/events{/number}","events_url":"https://api.github.com/repos/ngld/fs2open/events","assignees_url":"https://api.github.com/repos/ngld/fs2open/assignees{/user}","branches_url":"https://api.github.com/repos/ngld/fs2open/branches{/branch}","tags_url":"https://api.github.com/repos/ngld/fs2open/tags","blobs_url":"https://api.github.com/repos/ngld/fs2open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngld/fs2open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngld/fs2open/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngld/fs2open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngld/fs2open/statuses/{sha}","languages_url":"https://api.github.com/repos/ngld/fs2open/languages","stargazers_url":"https://api.github.com/repos/ngld/fs2open/stargazers","contributors_url":"https://api.github.com/repos/ngld/fs2open/contributors","subscribers_url":"https://api.github.com/repos/ngld/fs2open/subscribers","subscription_url":"https://api.github.com/repos/ngld/fs2open/subscription","commits_url":"https://api.github.com/repos/ngld/fs2open/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngld/fs2open/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngld/fs2open/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngld/fs2open/issues/comments/{number}","contents_url":"https://api.github.com/repos/ngld/fs2open/contents/{+path}","compare_url":"https://api.github.com/repos/ngld/fs2open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngld/fs2open/merges","archive_url":"https://api.github.com/repos/ngld/fs2open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngld/fs2open/downloads","issues_url":"https://api.github.com/repos/ngld/fs2open/issues{/number}","pulls_url":"https://api.github.com/repos/ngld/fs2open/pulls{/number}","milestones_url":"https://api.github.com/repos/ngld/fs2open/milestones{/number}","notifications_url":"https://api.github.com/repos/ngld/fs2open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngld/fs2open/labels{/name}","releases_url":"https://api.github.com/repos/ngld/fs2open/releases{/id}","created_at":"2014-03-12T18:10:56Z","updated_at":"2014-06-27T13:47:29Z","pushed_at":"2014-07-09T07:00:06Z","git_url":"git://github.com/ngld/fs2open.git","ssh_url":"git@github.com:ngld/fs2open.git","clone_url":"https://github.com/ngld/fs2open.git","svn_url":"https://github.com/ngld/fs2open","homepage":null,"size":79239,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"asarium:feature/chromiumInput","ref":"feature/chromiumInput","sha":"ecc362e95a3ebb12c61bacf9b91c5f865b2dfa57","user":{"login":"asarium","id":1013983,"avatar_url":"https://avatars.githubusercontent.com/u/1013983?","gravatar_id":"c445b2e3372a28c927d1c27c1f1fa5d4","url":"https://api.github.com/users/asarium","html_url":"https://github.com/asarium","followers_url":"https://api.github.com/users/asarium/followers","following_url":"https://api.github.com/users/asarium/following{/other_user}","gists_url":"https://api.github.com/users/asarium/gists{/gist_id}","starred_url":"https://api.github.com/users/asarium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asarium/subscriptions","organizations_url":"https://api.github.com/users/asarium/orgs","repos_url":"https://api.github.com/users/asarium/repos","events_url":"https://api.github.com/users/asarium/events{/privacy}","received_events_url":"https://api.github.com/users/asarium/received_events","type":"User","site_admin":false},"repo":{"id":9516399,"name":"fs2open.github.com","full_name":"asarium/fs2open.github.com","owner":{"login":"asarium","id":1013983,"avatar_url":"https://avatars.githubusercontent.com/u/1013983?","gravatar_id":"c445b2e3372a28c927d1c27c1f1fa5d4","url":"https://api.github.com/users/asarium","html_url":"https://github.com/asarium","followers_url":"https://api.github.com/users/asarium/followers","following_url":"https://api.github.com/users/asarium/following{/other_user}","gists_url":"https://api.github.com/users/asarium/gists{/gist_id}","starred_url":"https://api.github.com/users/asarium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asarium/subscriptions","organizations_url":"https://api.github.com/users/asarium/orgs","repos_url":"https://api.github.com/users/asarium/repos","events_url":"https://api.github.com/users/asarium/events{/privacy}","received_events_url":"https://api.github.com/users/asarium/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asarium/fs2open.github.com","description":"Origin Repository for SCP FreeSpace 2 Open","fork":true,"url":"https://api.github.com/repos/asarium/fs2open.github.com","forks_url":"https://api.github.com/repos/asarium/fs2open.github.com/forks","keys_url":"https://api.github.com/repos/asarium/fs2open.github.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asarium/fs2open.github.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asarium/fs2open.github.com/teams","hooks_url":"https://api.github.com/repos/asarium/fs2open.github.com/hooks","issue_events_url":"https://api.github.com/repos/asarium/fs2open.github.com/issues/events{/number}","events_url":"https://api.github.com/repos/asarium/fs2open.github.com/events","assignees_url":"https://api.github.com/repos/asarium/fs2open.github.com/assignees{/user}","branches_url":"https://api.github.com/repos/asarium/fs2open.github.com/branches{/branch}","tags_url":"https://api.github.com/repos/asarium/fs2open.github.com/tags","blobs_url":"https://api.github.com/repos/asarium/fs2open.github.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asarium/fs2open.github.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asarium/fs2open.github.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/asarium/fs2open.github.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asarium/fs2open.github.com/statuses/{sha}","languages_url":"https://api.github.com/repos/asarium/fs2open.github.com/languages","stargazers_url":"https://api.github.com/repos/asarium/fs2open.github.com/stargazers","contributors_url":"https://api.github.com/repos/asarium/fs2open.github.com/contributors","subscribers_url":"https://api.github.com/repos/asarium/fs2open.github.com/subscribers","subscription_url":"https://api.github.com/repos/asarium/fs2open.github.com/subscription","commits_url":"https://api.github.com/repos/asarium/fs2open.github.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/asarium/fs2open.github.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/asarium/fs2open.github.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/asarium/fs2open.github.com/issues/comments/{number}","contents_url":"https://api.github.com/repos/asarium/fs2open.github.com/contents/{+path}","compare_url":"https://api.github.com/repos/asarium/fs2open.github.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asarium/fs2open.github.com/merges","archive_url":"https://api.github.com/repos/asarium/fs2open.github.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asarium/fs2open.github.com/downloads","issues_url":"https://api.github.com/repos/asarium/fs2open.github.com/issues{/number}","pulls_url":"https://api.github.com/repos/asarium/fs2open.github.com/pulls{/number}","milestones_url":"https://api.github.com/repos/asarium/fs2open.github.com/milestones{/number}","notifications_url":"https://api.github.com/repos/asarium/fs2open.github.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asarium/fs2open.github.com/labels{/name}","releases_url":"https://api.github.com/repos/asarium/fs2open.github.com/releases{/id}","created_at":"2013-04-18T07:56:53Z","updated_at":"2014-07-07T00:55:25Z","pushed_at":"2014-07-04T09:49:35Z","git_url":"git://github.com/asarium/fs2open.github.com.git","ssh_url":"git@github.com:asarium/fs2open.github.com.git","clone_url":"https://github.com/asarium/fs2open.github.com.git","svn_url":"https://github.com/asarium/fs2open.github.com","homepage":null,"size":92178,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asarium/fs2open.github.com/pulls/1"},"html":{"href":"https://github.com/asarium/fs2open.github.com/pull/1"},"issue":{"href":"https://api.github.com/repos/asarium/fs2open.github.com/issues/1"},"comments":{"href":"https://api.github.com/repos/asarium/fs2open.github.com/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/asarium/fs2open.github.com/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/asarium/fs2open.github.com/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/asarium/fs2open.github.com/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/asarium/fs2open.github.com/statuses/c1a22ce2336fe5fcd4aa95bb5ccc7e0313bc8e66"}}}}