GitHub PullRequestReviewCommentEvent at 2014-07-15 07:45:44
Repository: scala.github.com
Actor: folone
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/scala/scala.github.com/pulls/comments/14920853","id":14920853,"diff_hunk":"@@ -147,28 +149,18 @@ But\n \n ### Shapeless\n \n-The whole approach that shapeless currently uses for managing singleton types (which it calls witnesses) can be rewritten using this feature instead of macros. Specifically, [these invocations](https://github.com/milessabin/shapeless/blob/e3399e35a7bb17b286141f53827619a3dc98efe8/core/src/main/scala/shapeless/singletons.scala#L31-L38) of macros can be rewritten in the following way:\n-\n-    object Witness {\n-      type Aux[T0] = Witness { type T = T0 }\n-      type Lt[Lub] = Witness { type T <: Lub }\n-\n-      implicit def apply[U : SingleInhabitant]: Witness.Aux[U] =\n-        new Witness {\n-          type T = U\n-          val value = inhabitant[T]\n-        }\n-\n-      implicit def apply[U](t: U): Witness.Lt[U] =\n-        new Witness {\n-          type T = t.type\n-          val value: T = t\n-        }\n-    }\n-\n-This feature is then heavily used to implement [records](https://github.com/milessabin/shapeless/blob/master/examples/src/main/scala/shapeless/examples/records.scala), [labeled generics](https://github.com/milessabin/shapeless/blob/master/examples/src/main/scala/shapeless/examples/labelledgeneric.scala), etc.\n+[Shapeless](https://github.com/milessabin/shapeless/) is a project that makes heavy use of singleton types already. It has all the machinery in place to make working with them nicer. Hence, it is a source of inspiration for working on this SIP. This change does not bring much to the table for shapeless though. One of the useful cases would be an ability to explicitly specify types for e.g. records in a more convenient way than possible with the current version of scala:","path":"sips/pending/_posts/2014-06-27-42.type.md","position":44,"original_position":44,"commit_id":"ed990cc0391d86d9722bd5cdccd2f9e43b20af5a","original_commit_id":"ed990cc0391d86d9722bd5cdccd2f9e43b20af5a","user":{"login":"folone","id":366132,"avatar_url":"https://avatars.githubusercontent.com/u/366132?","gravatar_id":"50e7e3f60b3507383d2b327857b66a62","url":"https://api.github.com/users/folone","html_url":"https://github.com/folone","followers_url":"https://api.github.com/users/folone/followers","following_url":"https://api.github.com/users/folone/following{/other_user}","gists_url":"https://api.github.com/users/folone/gists{/gist_id}","starred_url":"https://api.github.com/users/folone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folone/subscriptions","organizations_url":"https://api.github.com/users/folone/orgs","repos_url":"https://api.github.com/users/folone/repos","events_url":"https://api.github.com/users/folone/events{/privacy}","received_events_url":"https://api.github.com/users/folone/received_events","type":"User","site_admin":false},"body":"@milessabin Do you think this updated section is a more fair description of why this can be useful for shapeless?","created_at":"2014-07-15T07:45:44Z","updated_at":"2014-07-15T07:45:44Z","html_url":"https://github.com/scala/scala.github.com/pull/360#discussion_r14920853","pull_request_url":"https://api.github.com/repos/scala/scala.github.com/pulls/360","_links":{"self":{"href":"https://api.github.com/repos/scala/scala.github.com/pulls/comments/14920853"},"html":{"href":"https://github.com/scala/scala.github.com/pull/360#discussion_r14920853"},"pull_request":{"href":"https://api.github.com/repos/scala/scala.github.com/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/scala/scala.github.com/pulls/360","id":18392845,"html_url":"https://github.com/scala/scala.github.com/pull/360","diff_url":"https://github.com/scala/scala.github.com/pull/360.diff","patch_url":"https://github.com/scala/scala.github.com/pull/360.patch","issue_url":"https://api.github.com/repos/scala/scala.github.com/issues/360","number":360,"state":"open","title":"Update SIP-23 with received feedback.","user":{"login":"folone","id":366132,"avatar_url":"https://avatars.githubusercontent.com/u/366132?","gravatar_id":"50e7e3f60b3507383d2b327857b66a62","url":"https://api.github.com/users/folone","html_url":"https://github.com/folone","followers_url":"https://api.github.com/users/folone/followers","following_url":"https://api.github.com/users/folone/following{/other_user}","gists_url":"https://api.github.com/users/folone/gists{/gist_id}","starred_url":"https://api.github.com/users/folone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folone/subscriptions","organizations_url":"https://api.github.com/users/folone/orgs","repos_url":"https://api.github.com/users/folone/repos","events_url":"https://api.github.com/users/folone/events{/privacy}","received_events_url":"https://api.github.com/users/folone/received_events","type":"User","site_admin":false},"body":"I've updated some sections of SIP that needed updates.","created_at":"2014-07-15T07:44:46Z","updated_at":"2014-07-15T07:45:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f8135d8daf8fd8b97d7f22b0e90639cc8752461","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scala/scala.github.com/pulls/360/commits","review_comments_url":"https://api.github.com/repos/scala/scala.github.com/pulls/360/comments","review_comment_url":"https://api.github.com/repos/scala/scala.github.com/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scala/scala.github.com/issues/360/comments","statuses_url":"https://api.github.com/repos/scala/scala.github.com/statuses/ed990cc0391d86d9722bd5cdccd2f9e43b20af5a","head":{"label":"folone:master","ref":"master","sha":"ed990cc0391d86d9722bd5cdccd2f9e43b20af5a","user":{"login":"folone","id":366132,"avatar_url":"https://avatars.githubusercontent.com/u/366132?","gravatar_id":"50e7e3f60b3507383d2b327857b66a62","url":"https://api.github.com/users/folone","html_url":"https://github.com/folone","followers_url":"https://api.github.com/users/folone/followers","following_url":"https://api.github.com/users/folone/following{/other_user}","gists_url":"https://api.github.com/users/folone/gists{/gist_id}","starred_url":"https://api.github.com/users/folone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folone/subscriptions","organizations_url":"https://api.github.com/users/folone/orgs","repos_url":"https://api.github.com/users/folone/repos","events_url":"https://api.github.com/users/folone/events{/privacy}","received_events_url":"https://api.github.com/users/folone/received_events","type":"User","site_admin":false},"repo":{"id":21274480,"name":"scala.github.com","full_name":"folone/scala.github.com","owner":{"login":"folone","id":366132,"avatar_url":"https://avatars.githubusercontent.com/u/366132?","gravatar_id":"50e7e3f60b3507383d2b327857b66a62","url":"https://api.github.com/users/folone","html_url":"https://github.com/folone","followers_url":"https://api.github.com/users/folone/followers","following_url":"https://api.github.com/users/folone/following{/other_user}","gists_url":"https://api.github.com/users/folone/gists{/gist_id}","starred_url":"https://api.github.com/users/folone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folone/subscriptions","organizations_url":"https://api.github.com/users/folone/orgs","repos_url":"https://api.github.com/users/folone/repos","events_url":"https://api.github.com/users/folone/events{/privacy}","received_events_url":"https://api.github.com/users/folone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/folone/scala.github.com","description":"The Scala Documentation website","fork":true,"url":"https://api.github.com/repos/folone/scala.github.com","forks_url":"https://api.github.com/repos/folone/scala.github.com/forks","keys_url":"https://api.github.com/repos/folone/scala.github.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folone/scala.github.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folone/scala.github.com/teams","hooks_url":"https://api.github.com/repos/folone/scala.github.com/hooks","issue_events_url":"https://api.github.com/repos/folone/scala.github.com/issues/events{/number}","events_url":"https://api.github.com/repos/folone/scala.github.com/events","assignees_url":"https://api.github.com/repos/folone/scala.github.com/assignees{/user}","branches_url":"https://api.github.com/repos/folone/scala.github.com/branches{/branch}","tags_url":"https://api.github.com/repos/folone/scala.github.com/tags","blobs_url":"https://api.github.com/repos/folone/scala.github.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folone/scala.github.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folone/scala.github.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/folone/scala.github.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folone/scala.github.com/statuses/{sha}","languages_url":"https://api.github.com/repos/folone/scala.github.com/languages","stargazers_url":"https://api.github.com/repos/folone/scala.github.com/stargazers","contributors_url":"https://api.github.com/repos/folone/scala.github.com/contributors","subscribers_url":"https://api.github.com/repos/folone/scala.github.com/subscribers","subscription_url":"https://api.github.com/repos/folone/scala.github.com/subscription","commits_url":"https://api.github.com/repos/folone/scala.github.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/folone/scala.github.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/folone/scala.github.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/folone/scala.github.com/issues/comments/{number}","contents_url":"https://api.github.com/repos/folone/scala.github.com/contents/{+path}","compare_url":"https://api.github.com/repos/folone/scala.github.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folone/scala.github.com/merges","archive_url":"https://api.github.com/repos/folone/scala.github.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folone/scala.github.com/downloads","issues_url":"https://api.github.com/repos/folone/scala.github.com/issues{/number}","pulls_url":"https://api.github.com/repos/folone/scala.github.com/pulls{/number}","milestones_url":"https://api.github.com/repos/folone/scala.github.com/milestones{/number}","notifications_url":"https://api.github.com/repos/folone/scala.github.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folone/scala.github.com/labels{/name}","releases_url":"https://api.github.com/repos/folone/scala.github.com/releases{/id}","created_at":"2014-06-27T12:13:21Z","updated_at":"2014-06-25T07:41:05Z","pushed_at":"2014-07-15T07:43:32Z","git_url":"git://github.com/folone/scala.github.com.git","ssh_url":"git@github.com:folone/scala.github.com.git","clone_url":"https://github.com/folone/scala.github.com.git","svn_url":"https://github.com/folone/scala.github.com","homepage":"http://docs.scala-lang.org","size":3710,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scala:master","ref":"master","sha":"937cef5df138134713712df900e00ef3b38a0011","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?","gravatar_id":"034ea19230dbc7c67b487e6ba64127f0","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2577071,"name":"scala.github.com","full_name":"scala/scala.github.com","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?","gravatar_id":"034ea19230dbc7c67b487e6ba64127f0","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/scala.github.com","description":"The Scala Documentation website","fork":false,"url":"https://api.github.com/repos/scala/scala.github.com","forks_url":"https://api.github.com/repos/scala/scala.github.com/forks","keys_url":"https://api.github.com/repos/scala/scala.github.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala.github.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala.github.com/teams","hooks_url":"https://api.github.com/repos/scala/scala.github.com/hooks","issue_events_url":"https://api.github.com/repos/scala/scala.github.com/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala.github.com/events","assignees_url":"https://api.github.com/repos/scala/scala.github.com/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala.github.com/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala.github.com/tags","blobs_url":"https://api.github.com/repos/scala/scala.github.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala.github.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala.github.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala.github.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala.github.com/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala.github.com/languages","stargazers_url":"https://api.github.com/repos/scala/scala.github.com/stargazers","contributors_url":"https://api.github.com/repos/scala/scala.github.com/contributors","subscribers_url":"https://api.github.com/repos/scala/scala.github.com/subscribers","subscription_url":"https://api.github.com/repos/scala/scala.github.com/subscription","commits_url":"https://api.github.com/repos/scala/scala.github.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala.github.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala.github.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala.github.com/issues/comments/{number}","contents_url":"https://api.github.com/repos/scala/scala.github.com/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala.github.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala.github.com/merges","archive_url":"https://api.github.com/repos/scala/scala.github.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala.github.com/downloads","issues_url":"https://api.github.com/repos/scala/scala.github.com/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala.github.com/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala.github.com/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala.github.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala.github.com/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala.github.com/releases{/id}","created_at":"2011-10-14T15:37:14Z","updated_at":"2014-07-08T09:20:02Z","pushed_at":"2014-07-14T10:12:26Z","git_url":"git://github.com/scala/scala.github.com.git","ssh_url":"git@github.com:scala/scala.github.com.git","clone_url":"https://github.com/scala/scala.github.com.git","svn_url":"https://github.com/scala/scala.github.com","homepage":"http://docs.scala-lang.org","size":6758,"stargazers_count":159,"watchers_count":159,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":155,"mirror_url":null,"open_issues_count":51,"forks":155,"open_issues":51,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala.github.com/pulls/360"},"html":{"href":"https://github.com/scala/scala.github.com/pull/360"},"issue":{"href":"https://api.github.com/repos/scala/scala.github.com/issues/360"},"comments":{"href":"https://api.github.com/repos/scala/scala.github.com/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala.github.com/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala.github.com/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scala/scala.github.com/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala.github.com/statuses/ed990cc0391d86d9722bd5cdccd2f9e43b20af5a"}}}}