GitHub PullRequestReviewCommentEvent at 2014-12-10 17:15:02
Repository: aspect
Actor: bangerth
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/21618689","id":21618689,"diff_hunk":"@@ -92,7 +96,9 @@ namespace aspect\n                          + density * gravity * delta_z;\n           temperatures[i] = temperatures[i-1] * (1 +\n                                                  alpha * gravity * delta_z / cp);\n+          densities[i-1] = density;","path":"source/adiabatic_conditions/initial_profile.cc","position":26,"original_position":26,"commit_id":"c78fa6f63fecce90b3d963a09aafc5d29ddc7ca3","original_commit_id":"c78fa6f63fecce90b3d963a09aafc5d29ddc7ca3","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"What is the reason you update the previous density, not the current density in integrating down here?","created_at":"2014-12-10T17:15:02Z","updated_at":"2014-12-10T17:15:02Z","html_url":"https://github.com/geodynamics/aspect/pull/212#discussion_r21618689","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/212","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/21618689"},"html":{"href":"https://github.com/geodynamics/aspect/pull/212#discussion_r21618689"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/212","id":21071889,"html_url":"https://github.com/geodynamics/aspect/pull/212","diff_url":"https://github.com/geodynamics/aspect/pull/212.diff","patch_url":"https://github.com/geodynamics/aspect/pull/212.patch","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/212","number":212,"state":"open","locked":false,"title":"[WIP] Reference density state","user":{"login":"gassmoeller","id":7582930,"avatar_url":"https://avatars.githubusercontent.com/u/7582930?v=3","gravatar_id":"","url":"https://api.github.com/users/gassmoeller","html_url":"https://github.com/gassmoeller","followers_url":"https://api.github.com/users/gassmoeller/followers","following_url":"https://api.github.com/users/gassmoeller/following{/other_user}","gists_url":"https://api.github.com/users/gassmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/gassmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gassmoeller/subscriptions","organizations_url":"https://api.github.com/users/gassmoeller/orgs","repos_url":"https://api.github.com/users/gassmoeller/repos","events_url":"https://api.github.com/users/gassmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/gassmoeller/received_events","type":"User","site_admin":false},"body":"This is a first idea of how a reference density implementation for different approximations could work.","created_at":"2014-09-11T08:00:39Z","updated_at":"2014-12-10T17:15:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7691d0e61ef08f054d2e3cb863c100b2d46f849","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geodynamics/aspect/pulls/212/commits","review_comments_url":"https://api.github.com/repos/geodynamics/aspect/pulls/212/comments","review_comment_url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/{number}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/212/comments","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/c78fa6f63fecce90b3d963a09aafc5d29ddc7ca3","head":{"label":"gassmoeller:reference_density_state","ref":"reference_density_state","sha":"c78fa6f63fecce90b3d963a09aafc5d29ddc7ca3","user":{"login":"gassmoeller","id":7582930,"avatar_url":"https://avatars.githubusercontent.com/u/7582930?v=3","gravatar_id":"","url":"https://api.github.com/users/gassmoeller","html_url":"https://github.com/gassmoeller","followers_url":"https://api.github.com/users/gassmoeller/followers","following_url":"https://api.github.com/users/gassmoeller/following{/other_user}","gists_url":"https://api.github.com/users/gassmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/gassmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gassmoeller/subscriptions","organizations_url":"https://api.github.com/users/gassmoeller/orgs","repos_url":"https://api.github.com/users/gassmoeller/repos","events_url":"https://api.github.com/users/gassmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/gassmoeller/received_events","type":"User","site_admin":false},"repo":{"id":19785507,"name":"aspect","full_name":"gassmoeller/aspect","owner":{"login":"gassmoeller","id":7582930,"avatar_url":"https://avatars.githubusercontent.com/u/7582930?v=3","gravatar_id":"","url":"https://api.github.com/users/gassmoeller","html_url":"https://github.com/gassmoeller","followers_url":"https://api.github.com/users/gassmoeller/followers","following_url":"https://api.github.com/users/gassmoeller/following{/other_user}","gists_url":"https://api.github.com/users/gassmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/gassmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gassmoeller/subscriptions","organizations_url":"https://api.github.com/users/gassmoeller/orgs","repos_url":"https://api.github.com/users/gassmoeller/repos","events_url":"https://api.github.com/users/gassmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/gassmoeller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gassmoeller/aspect","description":"Finite element parallel code to simulate problems in thermal convection in both 2D and 3D models.","fork":true,"url":"https://api.github.com/repos/gassmoeller/aspect","forks_url":"https://api.github.com/repos/gassmoeller/aspect/forks","keys_url":"https://api.github.com/repos/gassmoeller/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gassmoeller/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gassmoeller/aspect/teams","hooks_url":"https://api.github.com/repos/gassmoeller/aspect/hooks","issue_events_url":"https://api.github.com/repos/gassmoeller/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/gassmoeller/aspect/events","assignees_url":"https://api.github.com/repos/gassmoeller/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/gassmoeller/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/gassmoeller/aspect/tags","blobs_url":"https://api.github.com/repos/gassmoeller/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gassmoeller/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gassmoeller/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/gassmoeller/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gassmoeller/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/gassmoeller/aspect/languages","stargazers_url":"https://api.github.com/repos/gassmoeller/aspect/stargazers","contributors_url":"https://api.github.com/repos/gassmoeller/aspect/contributors","subscribers_url":"https://api.github.com/repos/gassmoeller/aspect/subscribers","subscription_url":"https://api.github.com/repos/gassmoeller/aspect/subscription","commits_url":"https://api.github.com/repos/gassmoeller/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/gassmoeller/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/gassmoeller/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/gassmoeller/aspect/issues/comments/{number}","contents_url":"https://api.github.com/repos/gassmoeller/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/gassmoeller/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gassmoeller/aspect/merges","archive_url":"https://api.github.com/repos/gassmoeller/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gassmoeller/aspect/downloads","issues_url":"https://api.github.com/repos/gassmoeller/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/gassmoeller/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/gassmoeller/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/gassmoeller/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gassmoeller/aspect/labels{/name}","releases_url":"https://api.github.com/repos/gassmoeller/aspect/releases{/id}","created_at":"2014-05-14T15:40:43Z","updated_at":"2014-12-08T15:26:10Z","pushed_at":"2014-12-08T15:26:05Z","git_url":"git://github.com/gassmoeller/aspect.git","ssh_url":"git@github.com:gassmoeller/aspect.git","clone_url":"https://github.com/gassmoeller/aspect.git","svn_url":"https://github.com/gassmoeller/aspect","homepage":null,"size":96831,"stargazers_count":1,"watchers_count":1,"language":"Gnuplot","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"geodynamics:master","ref":"master","sha":"d6cb37df5cdcac509136f55e118aabc0cb3569b9","user":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":19502452,"name":"aspect","full_name":"geodynamics/aspect","owner":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geodynamics/aspect","description":"A parallel, extendible finite element code to simulate thermal convection in both 2D and 3D models.","fork":false,"url":"https://api.github.com/repos/geodynamics/aspect","forks_url":"https://api.github.com/repos/geodynamics/aspect/forks","keys_url":"https://api.github.com/repos/geodynamics/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodynamics/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodynamics/aspect/teams","hooks_url":"https://api.github.com/repos/geodynamics/aspect/hooks","issue_events_url":"https://api.github.com/repos/geodynamics/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/geodynamics/aspect/events","assignees_url":"https://api.github.com/repos/geodynamics/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/geodynamics/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/geodynamics/aspect/tags","blobs_url":"https://api.github.com/repos/geodynamics/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodynamics/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodynamics/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodynamics/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/geodynamics/aspect/languages","stargazers_url":"https://api.github.com/repos/geodynamics/aspect/stargazers","contributors_url":"https://api.github.com/repos/geodynamics/aspect/contributors","subscribers_url":"https://api.github.com/repos/geodynamics/aspect/subscribers","subscription_url":"https://api.github.com/repos/geodynamics/aspect/subscription","commits_url":"https://api.github.com/repos/geodynamics/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodynamics/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodynamics/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodynamics/aspect/issues/comments/{number}","contents_url":"https://api.github.com/repos/geodynamics/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/geodynamics/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodynamics/aspect/merges","archive_url":"https://api.github.com/repos/geodynamics/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodynamics/aspect/downloads","issues_url":"https://api.github.com/repos/geodynamics/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/geodynamics/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/geodynamics/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/geodynamics/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodynamics/aspect/labels{/name}","releases_url":"https://api.github.com/repos/geodynamics/aspect/releases{/id}","created_at":"2014-05-06T16:47:18Z","updated_at":"2014-12-04T17:05:01Z","pushed_at":"2014-12-04T17:04:55Z","git_url":"git://github.com/geodynamics/aspect.git","ssh_url":"git@github.com:geodynamics/aspect.git","clone_url":"https://github.com/geodynamics/aspect.git","svn_url":"https://github.com/geodynamics/aspect","homepage":"http://aspect.dealii.org/","size":106568,"stargazers_count":8,"watchers_count":8,"language":"Gnuplot","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":25,"forks":24,"open_issues":25,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/212"},"html":{"href":"https://github.com/geodynamics/aspect/pull/212"},"issue":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/212"},"comments":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/geodynamics/aspect/statuses/c78fa6f63fecce90b3d963a09aafc5d29ddc7ca3"}}}}