GitHub PullRequestReviewCommentEvent at 2014-06-27 16:23:45
Repository: symfony
Actor: stof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/14301404","id":14301404,"diff_hunk":"@@ -0,0 +1,62 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony package.\n+ *\n+ * (c) Fabien Potencier <fabien@symfony.com>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Bridge\\ProxyManager\\LazyProxy\\Instantiator;\n+\n+use ProxyManager\\Configuration;\n+use ProxyManager\\Factory\\LazyLoadingValueHolderFactory;\n+use ProxyManager\\FileLocator\\FileLocator;\n+use ProxyManager\\GeneratorStrategy\\FileWriterGeneratorStrategy;\n+use ProxyManager\\Proxy\\LazyLoadingInterface;\n+use Symfony\\Component\\DependencyInjection\\ContainerInterface;\n+use Symfony\\Component\\DependencyInjection\\Definition;\n+use Symfony\\Component\\DependencyInjection\\LazyProxy\\Instantiator\\InstantiatorInterface;\n+\n+/**\n+ * Lazy loading proxy generator (Using cached Proxy to improve performance).\n+ */\n+class CachedInstantiator implements InstantiatorInterface\n+{\n+    /**\n+     * @var \\ProxyManager\\Factory\\LazyLoadingValueHolderFactory\n+     */\n+    private $factory;\n+\n+    /**\n+     * Constructor","path":"src/Symfony/Bridge/ProxyManager/LazyProxy/Instantiator/CachedInstantiator.php","position":34,"original_position":34,"commit_id":"9911e07bf62a9559a09043fcc9bb72e0233e3626","original_commit_id":"9911e07bf62a9559a09043fcc9bb72e0233e3626","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?","gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"missing ``@param`` documentation","created_at":"2014-06-27T16:23:45Z","updated_at":"2014-06-27T16:23:45Z","html_url":"https://github.com/symfony/symfony/pull/11245#discussion_r14301404","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/11245","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/14301404"},"html":{"href":"https://github.com/symfony/symfony/pull/11245#discussion_r14301404"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11245"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/11245","id":17706276,"html_url":"https://github.com/symfony/symfony/pull/11245","diff_url":"https://github.com/symfony/symfony/pull/11245.diff","patch_url":"https://github.com/symfony/symfony/pull/11245.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/11245","number":11245,"state":"open","title":"Added cached Instantiator to be used in production instead of the Runtime version","user":{"login":"alex-moreno","id":2079182,"avatar_url":"https://avatars.githubusercontent.com/u/2079182?","gravatar_id":"b2183c05b941cc19d5c891b440b7f83f","url":"https://api.github.com/users/alex-moreno","html_url":"https://github.com/alex-moreno","followers_url":"https://api.github.com/users/alex-moreno/followers","following_url":"https://api.github.com/users/alex-moreno/following{/other_user}","gists_url":"https://api.github.com/users/alex-moreno/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-moreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-moreno/subscriptions","organizations_url":"https://api.github.com/users/alex-moreno/orgs","repos_url":"https://api.github.com/users/alex-moreno/repos","events_url":"https://api.github.com/users/alex-moreno/events{/privacy}","received_events_url":"https://api.github.com/users/alex-moreno/received_events","type":"User","site_admin":false},"body":"Runtime Instantiator is dangerous to be used in Production, and you probably should not need to code your own implementation of a cached one everytime you need to use Lazy Loading. Solution, use this one instead.\r\n\r\nOriginal solution by Dries Vanlerberghe.\r\nCode sponsored by Capgemini.","created_at":"2014-06-27T14:41:18Z","updated_at":"2014-06-27T16:23:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9de54d8fbc20267973aa08e35fc329b709b8be6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/11245/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/11245/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/11245/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/9911e07bf62a9559a09043fcc9bb72e0233e3626","head":{"label":"alex-moreno:cached-instantiator","ref":"cached-instantiator","sha":"9911e07bf62a9559a09043fcc9bb72e0233e3626","user":{"login":"alex-moreno","id":2079182,"avatar_url":"https://avatars.githubusercontent.com/u/2079182?","gravatar_id":"b2183c05b941cc19d5c891b440b7f83f","url":"https://api.github.com/users/alex-moreno","html_url":"https://github.com/alex-moreno","followers_url":"https://api.github.com/users/alex-moreno/followers","following_url":"https://api.github.com/users/alex-moreno/following{/other_user}","gists_url":"https://api.github.com/users/alex-moreno/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-moreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-moreno/subscriptions","organizations_url":"https://api.github.com/users/alex-moreno/orgs","repos_url":"https://api.github.com/users/alex-moreno/repos","events_url":"https://api.github.com/users/alex-moreno/events{/privacy}","received_events_url":"https://api.github.com/users/alex-moreno/received_events","type":"User","site_admin":false},"repo":{"id":21278492,"name":"symfony","full_name":"alex-moreno/symfony","owner":{"login":"alex-moreno","id":2079182,"avatar_url":"https://avatars.githubusercontent.com/u/2079182?","gravatar_id":"b2183c05b941cc19d5c891b440b7f83f","url":"https://api.github.com/users/alex-moreno","html_url":"https://github.com/alex-moreno","followers_url":"https://api.github.com/users/alex-moreno/followers","following_url":"https://api.github.com/users/alex-moreno/following{/other_user}","gists_url":"https://api.github.com/users/alex-moreno/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-moreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-moreno/subscriptions","organizations_url":"https://api.github.com/users/alex-moreno/orgs","repos_url":"https://api.github.com/users/alex-moreno/repos","events_url":"https://api.github.com/users/alex-moreno/events{/privacy}","received_events_url":"https://api.github.com/users/alex-moreno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alex-moreno/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/alex-moreno/symfony","forks_url":"https://api.github.com/repos/alex-moreno/symfony/forks","keys_url":"https://api.github.com/repos/alex-moreno/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alex-moreno/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alex-moreno/symfony/teams","hooks_url":"https://api.github.com/repos/alex-moreno/symfony/hooks","issue_events_url":"https://api.github.com/repos/alex-moreno/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/alex-moreno/symfony/events","assignees_url":"https://api.github.com/repos/alex-moreno/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/alex-moreno/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/alex-moreno/symfony/tags","blobs_url":"https://api.github.com/repos/alex-moreno/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alex-moreno/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alex-moreno/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/alex-moreno/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alex-moreno/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/alex-moreno/symfony/languages","stargazers_url":"https://api.github.com/repos/alex-moreno/symfony/stargazers","contributors_url":"https://api.github.com/repos/alex-moreno/symfony/contributors","subscribers_url":"https://api.github.com/repos/alex-moreno/symfony/subscribers","subscription_url":"https://api.github.com/repos/alex-moreno/symfony/subscription","commits_url":"https://api.github.com/repos/alex-moreno/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/alex-moreno/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/alex-moreno/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/alex-moreno/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/alex-moreno/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/alex-moreno/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alex-moreno/symfony/merges","archive_url":"https://api.github.com/repos/alex-moreno/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alex-moreno/symfony/downloads","issues_url":"https://api.github.com/repos/alex-moreno/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/alex-moreno/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/alex-moreno/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/alex-moreno/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alex-moreno/symfony/labels{/name}","releases_url":"https://api.github.com/repos/alex-moreno/symfony/releases{/id}","created_at":"2014-06-27T14:28:47Z","updated_at":"2014-06-27T15:49:48Z","pushed_at":"2014-06-27T16:11:52Z","git_url":"git://github.com/alex-moreno/symfony.git","ssh_url":"git@github.com:alex-moreno/symfony.git","clone_url":"https://github.com/alex-moreno/symfony.git","svn_url":"https://github.com/alex-moreno/symfony","homepage":"symfony.com","size":155248,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"c6b751cd1069c97ccb28024c737e51490aa55b76","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2014-06-27T12:21:56Z","pushed_at":"2014-06-27T11:00:17Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":155248,"stargazers_count":8536,"watchers_count":8536,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":3249,"mirror_url":null,"open_issues_count":750,"forks":3249,"open_issues":750,"watchers":8536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11245"},"html":{"href":"https://github.com/symfony/symfony/pull/11245"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/11245"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/11245/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11245/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/11245/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/9911e07bf62a9559a09043fcc9bb72e0233e3626"}}}}