GitHub PullRequestReviewCommentEvent at 2014-12-16 08:19:20
Repository: artifactory_ssh_proxy
Actor: stoneliyi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls/comments/21882996","id":21882996,"diff_hunk":"@@ -53,13 +53,34 @@\n public class SshdProxySettings implements SshdSettingsInterface {\n     private static final Logger LOGGER = LoggerFactory.getLogger(SshdProxySettings.class);\n \n+    /**\n+     * The port the ssh server listens on.\n+     */\n     protected final int port;\n+\n+    /**\n+     * The port the optional jetty service listens on.\n+     */\n     protected final int httpPort;\n+\n+    /**\n+     * The path to the host key the server uses\n+     */\n     protected final String hostKeyPath;\n+\n+    /**\n+     * An odd hackery to allow the CommandFactories to be changed while doing development TODO: remove/refactor out.\n+     */\n     protected final List<DelegatingCommandFactory> cfInstances;\n \n+    /**\n+     * Information required to connect to artifactory\n+     */\n     protected final ArtifactoryInformation artifactoryInfo;\n \n+    /**\n+     * An array of external services that are running. TODO: clean shutdown when we exit.","path":"src/main/java/com/yahoo/sshd/server/settings/SshdProxySettings.java","position":30,"original_position":30,"commit_id":"d78e54ee2d779028069c835ab162cc21ded3f51d","original_commit_id":"d78e54ee2d779028069c835ab162cc21ded3f51d","user":{"login":"stoneliyi","id":3410393,"avatar_url":"https://avatars.githubusercontent.com/u/3410393?v=3","gravatar_id":"","url":"https://api.github.com/users/stoneliyi","html_url":"https://github.com/stoneliyi","followers_url":"https://api.github.com/users/stoneliyi/followers","following_url":"https://api.github.com/users/stoneliyi/following{/other_user}","gists_url":"https://api.github.com/users/stoneliyi/gists{/gist_id}","starred_url":"https://api.github.com/users/stoneliyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stoneliyi/subscriptions","organizations_url":"https://api.github.com/users/stoneliyi/orgs","repos_url":"https://api.github.com/users/stoneliyi/repos","events_url":"https://api.github.com/users/stoneliyi/events{/privacy}","received_events_url":"https://api.github.com/users/stoneliyi/received_events","type":"User","site_admin":false},"body":"it seems that all external services have already been stopped https://github.com/areese/artifactory_ssh_proxy/blob/cleanup_tests/src/main/java/com/yahoo/sshd/server/Sshd.java#L269-L271. Is \"TODO\" here still valid? ","created_at":"2014-12-16T08:19:20Z","updated_at":"2014-12-16T08:19:20Z","html_url":"https://github.com/yahoo/artifactory_ssh_proxy/pull/10#discussion_r21882996","pull_request_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls/comments/21882996"},"html":{"href":"https://github.com/yahoo/artifactory_ssh_proxy/pull/10#discussion_r21882996"},"pull_request":{"href":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls/10","id":26121411,"html_url":"https://github.com/yahoo/artifactory_ssh_proxy/pull/10","diff_url":"https://github.com/yahoo/artifactory_ssh_proxy/pull/10.diff","patch_url":"https://github.com/yahoo/artifactory_ssh_proxy/pull/10.patch","issue_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/issues/10","number":10,"state":"open","locked":false,"title":"Cleanup tests","user":{"login":"areese","id":4701703,"avatar_url":"https://avatars.githubusercontent.com/u/4701703?v=3","gravatar_id":"","url":"https://api.github.com/users/areese","html_url":"https://github.com/areese","followers_url":"https://api.github.com/users/areese/followers","following_url":"https://api.github.com/users/areese/following{/other_user}","gists_url":"https://api.github.com/users/areese/gists{/gist_id}","starred_url":"https://api.github.com/users/areese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/areese/subscriptions","organizations_url":"https://api.github.com/users/areese/orgs","repos_url":"https://api.github.com/users/areese/repos","events_url":"https://api.github.com/users/areese/events{/privacy}","received_events_url":"https://api.github.com/users/areese/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-16T03:50:57Z","updated_at":"2014-12-16T08:19:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1df58be4f83c6b5b005d982372eea77d27986baf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls/10/commits","review_comments_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls/10/comments","review_comment_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/issues/10/comments","statuses_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/statuses/d78e54ee2d779028069c835ab162cc21ded3f51d","head":{"label":"areese:cleanup_tests","ref":"cleanup_tests","sha":"d78e54ee2d779028069c835ab162cc21ded3f51d","user":{"login":"areese","id":4701703,"avatar_url":"https://avatars.githubusercontent.com/u/4701703?v=3","gravatar_id":"","url":"https://api.github.com/users/areese","html_url":"https://github.com/areese","followers_url":"https://api.github.com/users/areese/followers","following_url":"https://api.github.com/users/areese/following{/other_user}","gists_url":"https://api.github.com/users/areese/gists{/gist_id}","starred_url":"https://api.github.com/users/areese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/areese/subscriptions","organizations_url":"https://api.github.com/users/areese/orgs","repos_url":"https://api.github.com/users/areese/repos","events_url":"https://api.github.com/users/areese/events{/privacy}","received_events_url":"https://api.github.com/users/areese/received_events","type":"User","site_admin":false},"repo":{"id":27931404,"name":"artifactory_ssh_proxy","full_name":"areese/artifactory_ssh_proxy","owner":{"login":"areese","id":4701703,"avatar_url":"https://avatars.githubusercontent.com/u/4701703?v=3","gravatar_id":"","url":"https://api.github.com/users/areese","html_url":"https://github.com/areese","followers_url":"https://api.github.com/users/areese/followers","following_url":"https://api.github.com/users/areese/following{/other_user}","gists_url":"https://api.github.com/users/areese/gists{/gist_id}","starred_url":"https://api.github.com/users/areese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/areese/subscriptions","organizations_url":"https://api.github.com/users/areese/orgs","repos_url":"https://api.github.com/users/areese/repos","events_url":"https://api.github.com/users/areese/events{/privacy}","received_events_url":"https://api.github.com/users/areese/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/areese/artifactory_ssh_proxy","description":"An ssh proxy for Artifactory","fork":true,"url":"https://api.github.com/repos/areese/artifactory_ssh_proxy","forks_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/forks","keys_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/teams","hooks_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/hooks","issue_events_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/issues/events{/number}","events_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/events","assignees_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/assignees{/user}","branches_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/branches{/branch}","tags_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/tags","blobs_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/languages","stargazers_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/stargazers","contributors_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/contributors","subscribers_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/subscribers","subscription_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/subscription","commits_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/issues/comments/{number}","contents_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/contents/{+path}","compare_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/merges","archive_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/downloads","issues_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/issues{/number}","pulls_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/labels{/name}","releases_url":"https://api.github.com/repos/areese/artifactory_ssh_proxy/releases{/id}","created_at":"2014-12-12T17:51:37Z","updated_at":"2014-12-15T22:47:25Z","pushed_at":"2014-12-16T03:50:22Z","git_url":"git://github.com/areese/artifactory_ssh_proxy.git","ssh_url":"git@github.com:areese/artifactory_ssh_proxy.git","clone_url":"https://github.com/areese/artifactory_ssh_proxy.git","svn_url":"https://github.com/areese/artifactory_ssh_proxy","homepage":"","size":290,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"6d317c00303b68465009a7ac52ab18cd0a447a32","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":25608016,"name":"artifactory_ssh_proxy","full_name":"yahoo/artifactory_ssh_proxy","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/artifactory_ssh_proxy","description":"An ssh proxy for Artifactory","fork":false,"url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy","forks_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/forks","keys_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/teams","hooks_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/hooks","issue_events_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/events","assignees_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/tags","blobs_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/languages","stargazers_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/stargazers","contributors_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/contributors","subscribers_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/subscribers","subscription_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/subscription","commits_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/issues/comments/{number}","contents_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/merges","archive_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/downloads","issues_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/releases{/id}","created_at":"2014-10-22T22:42:56Z","updated_at":"2014-12-15T22:44:48Z","pushed_at":"2014-12-15T22:44:48Z","git_url":"git://github.com/yahoo/artifactory_ssh_proxy.git","ssh_url":"git@github.com:yahoo/artifactory_ssh_proxy.git","clone_url":"https://github.com/yahoo/artifactory_ssh_proxy.git","svn_url":"https://github.com/yahoo/artifactory_ssh_proxy","homepage":"","size":390,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls/10"},"html":{"href":"https://github.com/yahoo/artifactory_ssh_proxy/pull/10"},"issue":{"href":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/issues/10"},"comments":{"href":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/artifactory_ssh_proxy/statuses/d78e54ee2d779028069c835ab162cc21ded3f51d"}}}}