GitHub PullRequestReviewCommentEvent at 2014-12-27 19:43:34
Repository: bem-bl
Actor: narqo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/bem/bem-bl/pulls/comments/22294227","id":22294227,"diff_hunk":"@@ -22,40 +19,96 @@ var DOM = require('dom-js'),\n         return type === 'string' || type === 'number';\n     };\n \n-var parseXml = exports.parseXml = function(xml, cb) {\n \n-        isSimple(xml) || (xml = JSON.stringify(xml));\n+/**\n+ * @param {String} xml\n+ * @returns {Nodes[]}\n+ */\n+function syncParser(el, cb){\n+    try {\n+        new DOM.DomJS().parse('<root>' + el + '</root>', function (err, dom) {\n+            if (err) {","path":"blocks-common/i-bem/__i18n/lib/tanker.js","position":38,"original_position":38,"commit_id":"19c66c4aeae9127e936206db7403c18bf49b89a9","original_commit_id":"19c66c4aeae9127e936206db7403c18bf49b89a9","user":{"login":"narqo","id":88045,"avatar_url":"https://avatars.githubusercontent.com/u/88045?v=3","gravatar_id":"","url":"https://api.github.com/users/narqo","html_url":"https://github.com/narqo","followers_url":"https://api.github.com/users/narqo/followers","following_url":"https://api.github.com/users/narqo/following{/other_user}","gists_url":"https://api.github.com/users/narqo/gists{/gist_id}","starred_url":"https://api.github.com/users/narqo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narqo/subscriptions","organizations_url":"https://api.github.com/users/narqo/orgs","repos_url":"https://api.github.com/users/narqo/repos","events_url":"https://api.github.com/users/narqo/events{/privacy}","received_events_url":"https://api.github.com/users/narqo/received_events","type":"User","site_admin":false},"body":"codestyle","created_at":"2014-12-27T19:43:34Z","updated_at":"2014-12-27T19:43:34Z","html_url":"https://github.com/bem/bem-bl/pull/593#discussion_r22294227","pull_request_url":"https://api.github.com/repos/bem/bem-bl/pulls/593","_links":{"self":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/comments/22294227"},"html":{"href":"https://github.com/bem/bem-bl/pull/593#discussion_r22294227"},"pull_request":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/593"}}},"pull_request":{"url":"https://api.github.com/repos/bem/bem-bl/pulls/593","id":26585699,"html_url":"https://github.com/bem/bem-bl/pull/593","diff_url":"https://github.com/bem/bem-bl/pull/593.diff","patch_url":"https://github.com/bem/bem-bl/pull/593.patch","issue_url":"https://api.github.com/repos/bem/bem-bl/issues/593","number":593,"state":"open","locked":false,"title":"BEM-2059 — BEM.I18N: Добавить поддержку параметризованных склоняемых ключей","user":{"login":"restrry","id":3198181,"avatar_url":"https://avatars.githubusercontent.com/u/3198181?v=3","gravatar_id":"","url":"https://api.github.com/users/restrry","html_url":"https://github.com/restrry","followers_url":"https://api.github.com/users/restrry/followers","following_url":"https://api.github.com/users/restrry/following{/other_user}","gists_url":"https://api.github.com/users/restrry/gists{/gist_id}","starred_url":"https://api.github.com/users/restrry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restrry/subscriptions","organizations_url":"https://api.github.com/users/restrry/orgs","repos_url":"https://api.github.com/users/restrry/repos","events_url":"https://api.github.com/users/restrry/events{/privacy}","received_events_url":"https://api.github.com/users/restrry/received_events","type":"User","site_admin":false},"body":"здесь же и тесты\r\n\r\nминимальные изменения для обратной совместимости. теперь будут обрабатываться ключи\r\n```javascript\r\n[\"Одно новое письмо\",\r\n \"<i18n:param>count</i18n:param> новых письма\",\r\n \"<i18n:param>count</i18n:param> новых писем\",\r\n \"Нет новых писем\"]\r\n```\r\nключи \r\n```javascript\r\n\"<!--- comment -->['One', 'Two', 'Five', 'None']\"\r\n\"You have ['One', 'Two', 'Five', 'No']\"\r\n```\r\nбудут обрабатываться по старому","created_at":"2014-12-25T19:14:53Z","updated_at":"2014-12-27T19:43:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75346b7fa371c1f6a86b2f66948540f2772b02cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bem/bem-bl/pulls/593/commits","review_comments_url":"https://api.github.com/repos/bem/bem-bl/pulls/593/comments","review_comment_url":"https://api.github.com/repos/bem/bem-bl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bem/bem-bl/issues/593/comments","statuses_url":"https://api.github.com/repos/bem/bem-bl/statuses/19c66c4aeae9127e936206db7403c18bf49b89a9","head":{"label":"restrry:restrry.ISL-1104.i18n-tests","ref":"restrry.ISL-1104.i18n-tests","sha":"19c66c4aeae9127e936206db7403c18bf49b89a9","user":{"login":"restrry","id":3198181,"avatar_url":"https://avatars.githubusercontent.com/u/3198181?v=3","gravatar_id":"","url":"https://api.github.com/users/restrry","html_url":"https://github.com/restrry","followers_url":"https://api.github.com/users/restrry/followers","following_url":"https://api.github.com/users/restrry/following{/other_user}","gists_url":"https://api.github.com/users/restrry/gists{/gist_id}","starred_url":"https://api.github.com/users/restrry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restrry/subscriptions","organizations_url":"https://api.github.com/users/restrry/orgs","repos_url":"https://api.github.com/users/restrry/repos","events_url":"https://api.github.com/users/restrry/events{/privacy}","received_events_url":"https://api.github.com/users/restrry/received_events","type":"User","site_admin":false},"repo":{"id":22498673,"name":"bem-bl","full_name":"restrry/bem-bl","owner":{"login":"restrry","id":3198181,"avatar_url":"https://avatars.githubusercontent.com/u/3198181?v=3","gravatar_id":"","url":"https://api.github.com/users/restrry","html_url":"https://github.com/restrry","followers_url":"https://api.github.com/users/restrry/followers","following_url":"https://api.github.com/users/restrry/following{/other_user}","gists_url":"https://api.github.com/users/restrry/gists{/gist_id}","starred_url":"https://api.github.com/users/restrry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restrry/subscriptions","organizations_url":"https://api.github.com/users/restrry/orgs","repos_url":"https://api.github.com/users/restrry/repos","events_url":"https://api.github.com/users/restrry/events{/privacy}","received_events_url":"https://api.github.com/users/restrry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/restrry/bem-bl","description":"Base BEM library","fork":true,"url":"https://api.github.com/repos/restrry/bem-bl","forks_url":"https://api.github.com/repos/restrry/bem-bl/forks","keys_url":"https://api.github.com/repos/restrry/bem-bl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/restrry/bem-bl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/restrry/bem-bl/teams","hooks_url":"https://api.github.com/repos/restrry/bem-bl/hooks","issue_events_url":"https://api.github.com/repos/restrry/bem-bl/issues/events{/number}","events_url":"https://api.github.com/repos/restrry/bem-bl/events","assignees_url":"https://api.github.com/repos/restrry/bem-bl/assignees{/user}","branches_url":"https://api.github.com/repos/restrry/bem-bl/branches{/branch}","tags_url":"https://api.github.com/repos/restrry/bem-bl/tags","blobs_url":"https://api.github.com/repos/restrry/bem-bl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/restrry/bem-bl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/restrry/bem-bl/git/refs{/sha}","trees_url":"https://api.github.com/repos/restrry/bem-bl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/restrry/bem-bl/statuses/{sha}","languages_url":"https://api.github.com/repos/restrry/bem-bl/languages","stargazers_url":"https://api.github.com/repos/restrry/bem-bl/stargazers","contributors_url":"https://api.github.com/repos/restrry/bem-bl/contributors","subscribers_url":"https://api.github.com/repos/restrry/bem-bl/subscribers","subscription_url":"https://api.github.com/repos/restrry/bem-bl/subscription","commits_url":"https://api.github.com/repos/restrry/bem-bl/commits{/sha}","git_commits_url":"https://api.github.com/repos/restrry/bem-bl/git/commits{/sha}","comments_url":"https://api.github.com/repos/restrry/bem-bl/comments{/number}","issue_comment_url":"https://api.github.com/repos/restrry/bem-bl/issues/comments/{number}","contents_url":"https://api.github.com/repos/restrry/bem-bl/contents/{+path}","compare_url":"https://api.github.com/repos/restrry/bem-bl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/restrry/bem-bl/merges","archive_url":"https://api.github.com/repos/restrry/bem-bl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/restrry/bem-bl/downloads","issues_url":"https://api.github.com/repos/restrry/bem-bl/issues{/number}","pulls_url":"https://api.github.com/repos/restrry/bem-bl/pulls{/number}","milestones_url":"https://api.github.com/repos/restrry/bem-bl/milestones{/number}","notifications_url":"https://api.github.com/repos/restrry/bem-bl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/restrry/bem-bl/labels{/name}","releases_url":"https://api.github.com/repos/restrry/bem-bl/releases{/id}","created_at":"2014-08-01T06:57:22Z","updated_at":"2014-07-29T16:47:22Z","pushed_at":"2014-12-26T17:29:44Z","git_url":"git://github.com/restrry/bem-bl.git","ssh_url":"git@github.com:restrry/bem-bl.git","clone_url":"https://github.com/restrry/bem-bl.git","svn_url":"https://github.com/restrry/bem-bl","homepage":"http://bem.github.com/bem-bl/","size":4260,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"bem:dev","ref":"dev","sha":"31c4d4aa674c0644442f8a2665895b55eca560fd","user":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=3","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"repo":{"id":610292,"name":"bem-bl","full_name":"bem/bem-bl","owner":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=3","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bem/bem-bl","description":"Base BEM library","fork":false,"url":"https://api.github.com/repos/bem/bem-bl","forks_url":"https://api.github.com/repos/bem/bem-bl/forks","keys_url":"https://api.github.com/repos/bem/bem-bl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bem/bem-bl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bem/bem-bl/teams","hooks_url":"https://api.github.com/repos/bem/bem-bl/hooks","issue_events_url":"https://api.github.com/repos/bem/bem-bl/issues/events{/number}","events_url":"https://api.github.com/repos/bem/bem-bl/events","assignees_url":"https://api.github.com/repos/bem/bem-bl/assignees{/user}","branches_url":"https://api.github.com/repos/bem/bem-bl/branches{/branch}","tags_url":"https://api.github.com/repos/bem/bem-bl/tags","blobs_url":"https://api.github.com/repos/bem/bem-bl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bem/bem-bl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bem/bem-bl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bem/bem-bl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bem/bem-bl/statuses/{sha}","languages_url":"https://api.github.com/repos/bem/bem-bl/languages","stargazers_url":"https://api.github.com/repos/bem/bem-bl/stargazers","contributors_url":"https://api.github.com/repos/bem/bem-bl/contributors","subscribers_url":"https://api.github.com/repos/bem/bem-bl/subscribers","subscription_url":"https://api.github.com/repos/bem/bem-bl/subscription","commits_url":"https://api.github.com/repos/bem/bem-bl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bem/bem-bl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bem/bem-bl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bem/bem-bl/issues/comments/{number}","contents_url":"https://api.github.com/repos/bem/bem-bl/contents/{+path}","compare_url":"https://api.github.com/repos/bem/bem-bl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bem/bem-bl/merges","archive_url":"https://api.github.com/repos/bem/bem-bl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bem/bem-bl/downloads","issues_url":"https://api.github.com/repos/bem/bem-bl/issues{/number}","pulls_url":"https://api.github.com/repos/bem/bem-bl/pulls{/number}","milestones_url":"https://api.github.com/repos/bem/bem-bl/milestones{/number}","notifications_url":"https://api.github.com/repos/bem/bem-bl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bem/bem-bl/labels{/name}","releases_url":"https://api.github.com/repos/bem/bem-bl/releases{/id}","created_at":"2010-04-14T15:28:16Z","updated_at":"2014-12-25T14:22:01Z","pushed_at":"2014-12-25T14:31:07Z","git_url":"git://github.com/bem/bem-bl.git","ssh_url":"git@github.com:bem/bem-bl.git","clone_url":"https://github.com/bem/bem-bl.git","svn_url":"https://github.com/bem/bem-bl","homepage":"http://bem.github.com/bem-bl/","size":11056,"stargazers_count":189,"watchers_count":189,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":88,"mirror_url":null,"open_issues_count":74,"forks":88,"open_issues":74,"watchers":189,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/593"},"html":{"href":"https://github.com/bem/bem-bl/pull/593"},"issue":{"href":"https://api.github.com/repos/bem/bem-bl/issues/593"},"comments":{"href":"https://api.github.com/repos/bem/bem-bl/issues/593/comments"},"review_comments":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/593/comments"},"review_comment":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bem/bem-bl/pulls/593/commits"},"statuses":{"href":"https://api.github.com/repos/bem/bem-bl/statuses/19c66c4aeae9127e936206db7403c18bf49b89a9"}}}}