GitHub PullRequestReviewCommentEvent at 2014-03-07 10:25:06
Repository: taskcluster-queue
Actor: lightsofapollo
Payload: {"comment":{"url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/comments/10378669","id":10378669,"diff_hunk":"@@ -37,14 +37,24 @@ var schema = function(options) {\n       // defined, then we have to validate against it...\n       if(nconf.get('queue:validateOutgoing') &&\n          options.output !== undefined) {\n-        var errors = validate(json, options.output);\n-        if (errors) {\n+        try {\n+          var errors = validate(json, options.output);\n+          if (errors) {\n+            res.json(500, {","path":"routes/api/utils.js","position":9,"original_position":9,"commit_id":"5eaf24c570a547ad781b789cc1a72d2b2d0690a0","original_commit_id":"5eaf24c570a547ad781b789cc1a72d2b2d0690a0","user":{"login":"lightsofapollo","id":322957,"avatar_url":"https://gravatar.com/avatar/52c6593cac3e4b93da1714af0760146b?d=https%3A%2F%2Fidenticons.github.com%2F49b87f6bee7347fc8e9fd720b6b0d5c9.png&r=x","gravatar_id":"52c6593cac3e4b93da1714af0760146b","url":"https://api.github.com/users/lightsofapollo","html_url":"https://github.com/lightsofapollo","followers_url":"https://api.github.com/users/lightsofapollo/followers","following_url":"https://api.github.com/users/lightsofapollo/following{/other_user}","gists_url":"https://api.github.com/users/lightsofapollo/gists{/gist_id}","starred_url":"https://api.github.com/users/lightsofapollo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightsofapollo/subscriptions","organizations_url":"https://api.github.com/users/lightsofapollo/orgs","repos_url":"https://api.github.com/users/lightsofapollo/repos","events_url":"https://api.github.com/users/lightsofapollo/events{/privacy}","received_events_url":"https://api.github.com/users/lightsofapollo/received_events","type":"User","site_admin":false},"body":"we really should send the validation error in the reponse","created_at":"2014-03-07T10:25:06Z","updated_at":"2014-03-07T10:25:06Z","html_url":"https://github.com/taskcluster/taskcluster-queue/pull/7#discussion_r10378669","pull_request_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/comments/10378669"},"html":{"href":"https://github.com/taskcluster/taskcluster-queue/pull/7#discussion_r10378669"},"pull_request":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/7"}}}}