GitHub PullRequestReviewCommentEvent at 2014-09-23 14:43:20
Repository: insight
Actor: matthewdunsdon
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ScottLogic/insight/pulls/comments/17912720","id":17912720,"diff_hunk":"@@ -678,7 +677,7 @@\n          * The function used to compare the elements in this grouping if sorting is requested.\n          * @instance\n          * @memberof! insight.Grouping\n-         * @returns {Function} orderingFunction - The function used to compare two values when sort() is called on an array\n+         * @returns {Function} - The function used to compare two values when sort() is called on an array","path":"src/mda/Grouping.js","position":23,"original_position":23,"commit_id":"7077be345dc62ddd22270c2629609bc4d9f246ca","original_commit_id":"7077be345dc62ddd22270c2629609bc4d9f246ca","user":{"login":"matthewdunsdon","id":100268,"avatar_url":"https://avatars.githubusercontent.com/u/100268?v=2","gravatar_id":"","url":"https://api.github.com/users/matthewdunsdon","html_url":"https://github.com/matthewdunsdon","followers_url":"https://api.github.com/users/matthewdunsdon/followers","following_url":"https://api.github.com/users/matthewdunsdon/following{/other_user}","gists_url":"https://api.github.com/users/matthewdunsdon/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdunsdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdunsdon/subscriptions","organizations_url":"https://api.github.com/users/matthewdunsdon/orgs","repos_url":"https://api.github.com/users/matthewdunsdon/repos","events_url":"https://api.github.com/users/matthewdunsdon/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdunsdon/received_events","type":"User","site_admin":false},"body":"I'll look into that.","created_at":"2014-09-23T14:43:20Z","updated_at":"2014-09-23T14:43:20Z","html_url":"https://github.com/ScottLogic/insight/pull/214#discussion_r17912720","pull_request_url":"https://api.github.com/repos/ScottLogic/insight/pulls/214","_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/insight/pulls/comments/17912720"},"html":{"href":"https://github.com/ScottLogic/insight/pull/214#discussion_r17912720"},"pull_request":{"href":"https://api.github.com/repos/ScottLogic/insight/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/ScottLogic/insight/pulls/214","id":21643205,"html_url":"https://github.com/ScottLogic/insight/pull/214","diff_url":"https://github.com/ScottLogic/insight/pull/214.diff","patch_url":"https://github.com/ScottLogic/insight/pull/214.patch","issue_url":"https://api.github.com/repos/ScottLogic/insight/issues/214","number":214,"state":"open","locked":false,"title":"Fix documentation for insight.Grouping","user":{"login":"matthewdunsdon","id":100268,"avatar_url":"https://avatars.githubusercontent.com/u/100268?v=2","gravatar_id":"","url":"https://api.github.com/users/matthewdunsdon","html_url":"https://github.com/matthewdunsdon","followers_url":"https://api.github.com/users/matthewdunsdon/followers","following_url":"https://api.github.com/users/matthewdunsdon/following{/other_user}","gists_url":"https://api.github.com/users/matthewdunsdon/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdunsdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdunsdon/subscriptions","organizations_url":"https://api.github.com/users/matthewdunsdon/orgs","repos_url":"https://api.github.com/users/matthewdunsdon/repos","events_url":"https://api.github.com/users/matthewdunsdon/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdunsdon/received_events","type":"User","site_admin":false},"body":"Incorrect location of comments for class meant that the documentation\r\nfor this class was not been shown.\r\n\r\nAlso made minor change to the documentation of ````orderFunction````.","created_at":"2014-09-23T12:57:29Z","updated_at":"2014-09-23T14:43:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77afd55e2679602e78dfc4bc0d1b311d09bac055","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ScottLogic/insight/pulls/214/commits","review_comments_url":"https://api.github.com/repos/ScottLogic/insight/pulls/214/comments","review_comment_url":"https://api.github.com/repos/ScottLogic/insight/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ScottLogic/insight/issues/214/comments","statuses_url":"https://api.github.com/repos/ScottLogic/insight/statuses/7077be345dc62ddd22270c2629609bc4d9f246ca","head":{"label":"matthewdunsdon:feature/fix-grouping-documentation","ref":"feature/fix-grouping-documentation","sha":"7077be345dc62ddd22270c2629609bc4d9f246ca","user":{"login":"matthewdunsdon","id":100268,"avatar_url":"https://avatars.githubusercontent.com/u/100268?v=2","gravatar_id":"","url":"https://api.github.com/users/matthewdunsdon","html_url":"https://github.com/matthewdunsdon","followers_url":"https://api.github.com/users/matthewdunsdon/followers","following_url":"https://api.github.com/users/matthewdunsdon/following{/other_user}","gists_url":"https://api.github.com/users/matthewdunsdon/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdunsdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdunsdon/subscriptions","organizations_url":"https://api.github.com/users/matthewdunsdon/orgs","repos_url":"https://api.github.com/users/matthewdunsdon/repos","events_url":"https://api.github.com/users/matthewdunsdon/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdunsdon/received_events","type":"User","site_admin":false},"repo":{"id":21855762,"name":"insight","full_name":"matthewdunsdon/insight","owner":{"login":"matthewdunsdon","id":100268,"avatar_url":"https://avatars.githubusercontent.com/u/100268?v=2","gravatar_id":"","url":"https://api.github.com/users/matthewdunsdon","html_url":"https://github.com/matthewdunsdon","followers_url":"https://api.github.com/users/matthewdunsdon/followers","following_url":"https://api.github.com/users/matthewdunsdon/following{/other_user}","gists_url":"https://api.github.com/users/matthewdunsdon/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdunsdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdunsdon/subscriptions","organizations_url":"https://api.github.com/users/matthewdunsdon/orgs","repos_url":"https://api.github.com/users/matthewdunsdon/repos","events_url":"https://api.github.com/users/matthewdunsdon/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdunsdon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewdunsdon/insight","description":"A Javascript charting library","fork":true,"url":"https://api.github.com/repos/matthewdunsdon/insight","forks_url":"https://api.github.com/repos/matthewdunsdon/insight/forks","keys_url":"https://api.github.com/repos/matthewdunsdon/insight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewdunsdon/insight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewdunsdon/insight/teams","hooks_url":"https://api.github.com/repos/matthewdunsdon/insight/hooks","issue_events_url":"https://api.github.com/repos/matthewdunsdon/insight/issues/events{/number}","events_url":"https://api.github.com/repos/matthewdunsdon/insight/events","assignees_url":"https://api.github.com/repos/matthewdunsdon/insight/assignees{/user}","branches_url":"https://api.github.com/repos/matthewdunsdon/insight/branches{/branch}","tags_url":"https://api.github.com/repos/matthewdunsdon/insight/tags","blobs_url":"https://api.github.com/repos/matthewdunsdon/insight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewdunsdon/insight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewdunsdon/insight/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewdunsdon/insight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewdunsdon/insight/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewdunsdon/insight/languages","stargazers_url":"https://api.github.com/repos/matthewdunsdon/insight/stargazers","contributors_url":"https://api.github.com/repos/matthewdunsdon/insight/contributors","subscribers_url":"https://api.github.com/repos/matthewdunsdon/insight/subscribers","subscription_url":"https://api.github.com/repos/matthewdunsdon/insight/subscription","commits_url":"https://api.github.com/repos/matthewdunsdon/insight/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewdunsdon/insight/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewdunsdon/insight/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewdunsdon/insight/issues/comments/{number}","contents_url":"https://api.github.com/repos/matthewdunsdon/insight/contents/{+path}","compare_url":"https://api.github.com/repos/matthewdunsdon/insight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewdunsdon/insight/merges","archive_url":"https://api.github.com/repos/matthewdunsdon/insight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewdunsdon/insight/downloads","issues_url":"https://api.github.com/repos/matthewdunsdon/insight/issues{/number}","pulls_url":"https://api.github.com/repos/matthewdunsdon/insight/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewdunsdon/insight/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewdunsdon/insight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewdunsdon/insight/labels{/name}","releases_url":"https://api.github.com/repos/matthewdunsdon/insight/releases{/id}","created_at":"2014-07-15T10:34:36Z","updated_at":"2014-08-11T09:39:21Z","pushed_at":"2014-09-23T14:25:17Z","git_url":"git://github.com/matthewdunsdon/insight.git","ssh_url":"git@github.com:matthewdunsdon/insight.git","clone_url":"https://github.com/matthewdunsdon/insight.git","svn_url":"https://github.com/matthewdunsdon/insight","homepage":"","size":33613,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ScottLogic:develop","ref":"develop","sha":"1da96012119900004fb91b262f46625e36b1a45e","user":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=2","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":20251886,"name":"insight","full_name":"ScottLogic/insight","owner":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=2","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScottLogic/insight","description":"A Javascript charting library","fork":false,"url":"https://api.github.com/repos/ScottLogic/insight","forks_url":"https://api.github.com/repos/ScottLogic/insight/forks","keys_url":"https://api.github.com/repos/ScottLogic/insight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScottLogic/insight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScottLogic/insight/teams","hooks_url":"https://api.github.com/repos/ScottLogic/insight/hooks","issue_events_url":"https://api.github.com/repos/ScottLogic/insight/issues/events{/number}","events_url":"https://api.github.com/repos/ScottLogic/insight/events","assignees_url":"https://api.github.com/repos/ScottLogic/insight/assignees{/user}","branches_url":"https://api.github.com/repos/ScottLogic/insight/branches{/branch}","tags_url":"https://api.github.com/repos/ScottLogic/insight/tags","blobs_url":"https://api.github.com/repos/ScottLogic/insight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScottLogic/insight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScottLogic/insight/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScottLogic/insight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScottLogic/insight/statuses/{sha}","languages_url":"https://api.github.com/repos/ScottLogic/insight/languages","stargazers_url":"https://api.github.com/repos/ScottLogic/insight/stargazers","contributors_url":"https://api.github.com/repos/ScottLogic/insight/contributors","subscribers_url":"https://api.github.com/repos/ScottLogic/insight/subscribers","subscription_url":"https://api.github.com/repos/ScottLogic/insight/subscription","commits_url":"https://api.github.com/repos/ScottLogic/insight/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScottLogic/insight/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScottLogic/insight/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScottLogic/insight/issues/comments/{number}","contents_url":"https://api.github.com/repos/ScottLogic/insight/contents/{+path}","compare_url":"https://api.github.com/repos/ScottLogic/insight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScottLogic/insight/merges","archive_url":"https://api.github.com/repos/ScottLogic/insight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScottLogic/insight/downloads","issues_url":"https://api.github.com/repos/ScottLogic/insight/issues{/number}","pulls_url":"https://api.github.com/repos/ScottLogic/insight/pulls{/number}","milestones_url":"https://api.github.com/repos/ScottLogic/insight/milestones{/number}","notifications_url":"https://api.github.com/repos/ScottLogic/insight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScottLogic/insight/labels{/name}","releases_url":"https://api.github.com/repos/ScottLogic/insight/releases{/id}","created_at":"2014-05-28T09:22:15Z","updated_at":"2014-09-19T00:20:40Z","pushed_at":"2014-09-23T14:40:43Z","git_url":"git://github.com/ScottLogic/insight.git","ssh_url":"git@github.com:ScottLogic/insight.git","clone_url":"https://github.com/ScottLogic/insight.git","svn_url":"https://github.com/ScottLogic/insight","homepage":"scottlogic.github.io/insight/#/","size":39046,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/insight/pulls/214"},"html":{"href":"https://github.com/ScottLogic/insight/pull/214"},"issue":{"href":"https://api.github.com/repos/ScottLogic/insight/issues/214"},"comments":{"href":"https://api.github.com/repos/ScottLogic/insight/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/ScottLogic/insight/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/ScottLogic/insight/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ScottLogic/insight/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/ScottLogic/insight/statuses/7077be345dc62ddd22270c2629609bc4d9f246ca"}}}}