GitHub PullRequestReviewCommentEvent at 2014-08-21 13:38:08
Repository: chamilo-lms-utp
Actor: jmontoyaa
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls/comments/16538663","id":16538663,"diff_hunk":"@@ -2277,14 +2277,15 @@ public static function get_personal_session_course_list($user_id)\n         // Get the list of sessions where the user is subscribed\n         // This is divided into two different queries\n         $sessions = array();\n-        $sessions_sql = \"SELECT DISTINCT id, name, date_start, date_end\n-                        FROM $tbl_session_user, $tbl_session\n-                        WHERE (\n-                            id_session = id AND\n-                            id_user = $user_id AND\n-                            relation_type <> \".SESSION_RELATION_TYPE_RRHH.\"\n-                        )\n+        $sessions_sql = \"SELECT DISTINCT s.id, s.name, s.date_start, s.date_end\n+                        FROM $tbl_session s\n+                        INNER JOIN $tbl_session_user su\n+                        ON su.id_session = s.id\n+                        AND\n+                        (su.id_user = $user_id\n+                        AND relation_type != \".SESSION_RELATION_TYPE_RRHH.\"\n                         $coachCourseConditions\n+                        )","path":"main/inc/lib/usermanager.lib.php","position":19,"original_position":19,"commit_id":"5353073dd4e55248410fcdf2757ff1cac600b14d","original_commit_id":"5353073dd4e55248410fcdf2757ff1cac600b14d","user":{"login":"jmontoyaa","id":158935,"avatar_url":"https://avatars.githubusercontent.com/u/158935?v=2","gravatar_id":"35bac50f34dea0ea78259e7a0d23fa1e","url":"https://api.github.com/users/jmontoyaa","html_url":"https://github.com/jmontoyaa","followers_url":"https://api.github.com/users/jmontoyaa/followers","following_url":"https://api.github.com/users/jmontoyaa/following{/other_user}","gists_url":"https://api.github.com/users/jmontoyaa/gists{/gist_id}","starred_url":"https://api.github.com/users/jmontoyaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmontoyaa/subscriptions","organizations_url":"https://api.github.com/users/jmontoyaa/orgs","repos_url":"https://api.github.com/users/jmontoyaa/repos","events_url":"https://api.github.com/users/jmontoyaa/events{/privacy}","received_events_url":"https://api.github.com/users/jmontoyaa/received_events","type":"User","site_admin":false},"body":"El cambio me parece correcto aunque solo cambiaria un poco el query como esta aqui:\r\n\r\nhttps://github.com/beeznest/chamilo-lms-utp/commit/9033e8963ffa6dc2238fa6713f51bf15af7c0c4f","created_at":"2014-08-21T13:38:08Z","updated_at":"2014-08-21T13:38:08Z","html_url":"https://github.com/beeznest/chamilo-lms-utp/pull/75#discussion_r16538663","pull_request_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls/comments/16538663"},"html":{"href":"https://github.com/beeznest/chamilo-lms-utp/pull/75#discussion_r16538663"},"pull_request":{"href":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls/75","id":20016238,"html_url":"https://github.com/beeznest/chamilo-lms-utp/pull/75","diff_url":"https://github.com/beeznest/chamilo-lms-utp/pull/75.diff","patch_url":"https://github.com/beeznest/chamilo-lms-utp/pull/75.patch","issue_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/issues/75","number":75,"state":"open","locked":false,"title":"Fix bug - refs BT#8525","user":{"login":"danbarretodev","id":4552920,"avatar_url":"https://avatars.githubusercontent.com/u/4552920?v=2","gravatar_id":"fcb7e9de0fc5baf54c27f293d9b9735b","url":"https://api.github.com/users/danbarretodev","html_url":"https://github.com/danbarretodev","followers_url":"https://api.github.com/users/danbarretodev/followers","following_url":"https://api.github.com/users/danbarretodev/following{/other_user}","gists_url":"https://api.github.com/users/danbarretodev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbarretodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbarretodev/subscriptions","organizations_url":"https://api.github.com/users/danbarretodev/orgs","repos_url":"https://api.github.com/users/danbarretodev/repos","events_url":"https://api.github.com/users/danbarretodev/events{/privacy}","received_events_url":"https://api.github.com/users/danbarretodev/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-19T23:19:24Z","updated_at":"2014-08-21T13:38:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce89ab2fd0560409ec8084debeb64a626e0483c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls/75/commits","review_comments_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls/75/comments","review_comment_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/issues/75/comments","statuses_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/statuses/5353073dd4e55248410fcdf2757ff1cac600b14d","head":{"label":"DeEvo:8525","ref":"8525","sha":"5353073dd4e55248410fcdf2757ff1cac600b14d","user":{"login":"DeEvo","id":4561889,"avatar_url":"https://avatars.githubusercontent.com/u/4561889?v=2","gravatar_id":null,"url":"https://api.github.com/users/DeEvo","html_url":"https://github.com/DeEvo","followers_url":"https://api.github.com/users/DeEvo/followers","following_url":"https://api.github.com/users/DeEvo/following{/other_user}","gists_url":"https://api.github.com/users/DeEvo/gists{/gist_id}","starred_url":"https://api.github.com/users/DeEvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeEvo/subscriptions","organizations_url":"https://api.github.com/users/DeEvo/orgs","repos_url":"https://api.github.com/users/DeEvo/repos","events_url":"https://api.github.com/users/DeEvo/events{/privacy}","received_events_url":"https://api.github.com/users/DeEvo/received_events","type":"Organization","site_admin":false},"repo":{"id":16518889,"name":"chamilo-lms-utp","full_name":"DeEvo/chamilo-lms-utp","owner":{"login":"DeEvo","id":4561889,"avatar_url":"https://avatars.githubusercontent.com/u/4561889?v=2","gravatar_id":null,"url":"https://api.github.com/users/DeEvo","html_url":"https://github.com/DeEvo","followers_url":"https://api.github.com/users/DeEvo/followers","following_url":"https://api.github.com/users/DeEvo/following{/other_user}","gists_url":"https://api.github.com/users/DeEvo/gists{/gist_id}","starred_url":"https://api.github.com/users/DeEvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeEvo/subscriptions","organizations_url":"https://api.github.com/users/DeEvo/orgs","repos_url":"https://api.github.com/users/DeEvo/repos","events_url":"https://api.github.com/users/DeEvo/events{/privacy}","received_events_url":"https://api.github.com/users/DeEvo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DeEvo/chamilo-lms-utp","description":"Chamilo is a learning management system focusing on ease of use, re-usibality, collaboration and sharing.","fork":true,"url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp","forks_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/forks","keys_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/teams","hooks_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/hooks","issue_events_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/issues/events{/number}","events_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/events","assignees_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/assignees{/user}","branches_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/branches{/branch}","tags_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/tags","blobs_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/statuses/{sha}","languages_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/languages","stargazers_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/stargazers","contributors_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/contributors","subscribers_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/subscribers","subscription_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/subscription","commits_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/issues/comments/{number}","contents_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/contents/{+path}","compare_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/merges","archive_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/downloads","issues_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/issues{/number}","pulls_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/pulls{/number}","milestones_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/milestones{/number}","notifications_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/labels{/name}","releases_url":"https://api.github.com/repos/DeEvo/chamilo-lms-utp/releases{/id}","created_at":"2014-02-04T17:07:36Z","updated_at":"2014-06-30T13:11:12Z","pushed_at":"2014-08-19T23:17:01Z","git_url":"git://github.com/DeEvo/chamilo-lms-utp.git","ssh_url":"git@github.com:DeEvo/chamilo-lms-utp.git","clone_url":"https://github.com/DeEvo/chamilo-lms-utp.git","svn_url":"https://github.com/DeEvo/chamilo-lms-utp","homepage":"http://www.chamilo.org","size":691544,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.9.x"}},"base":{"label":"beeznest:1.9.x","ref":"1.9.x","sha":"271a6719afb31bd3e92ba2c39caba6db9ec74e23","user":{"login":"beeznest","id":4564017,"avatar_url":"https://avatars.githubusercontent.com/u/4564017?v=2","gravatar_id":null,"url":"https://api.github.com/users/beeznest","html_url":"https://github.com/beeznest","followers_url":"https://api.github.com/users/beeznest/followers","following_url":"https://api.github.com/users/beeznest/following{/other_user}","gists_url":"https://api.github.com/users/beeznest/gists{/gist_id}","starred_url":"https://api.github.com/users/beeznest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beeznest/subscriptions","organizations_url":"https://api.github.com/users/beeznest/orgs","repos_url":"https://api.github.com/users/beeznest/repos","events_url":"https://api.github.com/users/beeznest/events{/privacy}","received_events_url":"https://api.github.com/users/beeznest/received_events","type":"Organization","site_admin":false},"repo":{"id":14493281,"name":"chamilo-lms-utp","full_name":"beeznest/chamilo-lms-utp","owner":{"login":"beeznest","id":4564017,"avatar_url":"https://avatars.githubusercontent.com/u/4564017?v=2","gravatar_id":null,"url":"https://api.github.com/users/beeznest","html_url":"https://github.com/beeznest","followers_url":"https://api.github.com/users/beeznest/followers","following_url":"https://api.github.com/users/beeznest/following{/other_user}","gists_url":"https://api.github.com/users/beeznest/gists{/gist_id}","starred_url":"https://api.github.com/users/beeznest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beeznest/subscriptions","organizations_url":"https://api.github.com/users/beeznest/orgs","repos_url":"https://api.github.com/users/beeznest/repos","events_url":"https://api.github.com/users/beeznest/events{/privacy}","received_events_url":"https://api.github.com/users/beeznest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/beeznest/chamilo-lms-utp","description":"Chamilo is a learning management system focusing on ease of use, re-usibality, collaboration and sharing.","fork":true,"url":"https://api.github.com/repos/beeznest/chamilo-lms-utp","forks_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/forks","keys_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/teams","hooks_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/hooks","issue_events_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/issues/events{/number}","events_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/events","assignees_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/assignees{/user}","branches_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/branches{/branch}","tags_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/tags","blobs_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/git/refs{/sha}","trees_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/statuses/{sha}","languages_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/languages","stargazers_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/stargazers","contributors_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/contributors","subscribers_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/subscribers","subscription_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/subscription","commits_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/commits{/sha}","git_commits_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/git/commits{/sha}","comments_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/comments{/number}","issue_comment_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/issues/comments/{number}","contents_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/contents/{+path}","compare_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/merges","archive_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/downloads","issues_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/issues{/number}","pulls_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls{/number}","milestones_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/milestones{/number}","notifications_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/labels{/name}","releases_url":"https://api.github.com/repos/beeznest/chamilo-lms-utp/releases{/id}","created_at":"2013-11-18T13:36:29Z","updated_at":"2014-06-28T02:08:23Z","pushed_at":"2014-08-21T13:35:08Z","git_url":"git://github.com/beeznest/chamilo-lms-utp.git","ssh_url":"git@github.com:beeznest/chamilo-lms-utp.git","clone_url":"https://github.com/beeznest/chamilo-lms-utp.git","svn_url":"https://github.com/beeznest/chamilo-lms-utp","homepage":"http://www.chamilo.org","size":692056,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"1.9.x"}},"_links":{"self":{"href":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls/75"},"html":{"href":"https://github.com/beeznest/chamilo-lms-utp/pull/75"},"issue":{"href":"https://api.github.com/repos/beeznest/chamilo-lms-utp/issues/75"},"comments":{"href":"https://api.github.com/repos/beeznest/chamilo-lms-utp/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/beeznest/chamilo-lms-utp/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/beeznest/chamilo-lms-utp/statuses/5353073dd4e55248410fcdf2757ff1cac600b14d"}}}}