GitHub PullRequestReviewCommentEvent at 2014-03-05 06:58:53
Repository: galaxy
Actor: cvan
Payload: {"comment":{"url":"https://api.github.com/repos/cvan/galaxy/pulls/comments/10289373","id":10289373,"diff_hunk":"@@ -1,153 +1,192 @@\n {% macro gameForm(game) %}\n-\t<form class=\"game-form grid\" method=\"post\" data-required=\"{{ _('Required') }}\" data-formtype=\"{{'edit' if game else 'submit'}}\">\n-    <div class=\"unit two-of-three\">\n-      <div class=\"content form-field\">\n-        <label>\n-          <input type=\"text\" class=\"large\" name=\"name\" placeholder=\"{{ _('Enter game title here') }}\" value=\"{{ game.name|translate(game) }}\" required>\n-          <span class=\"l\">{{ _('Name') }}</span>\n-          <span class=\"req\" data-required=\"{{ _('Required') }}\"></span>\n-        </label>\n+\t<form class=\"game-form\" method=\"post\" data-required=\"{{ _('Required') }}\" data-formtype=\"{{'edit' if game else 'submit'}}\">\n+    <div class=\"grid content\">\n+      <div class=\"grid-cell grid-flex-grow-two\">\n+        <div class=\"form-field\">\n+          <label>\n+            <input type=\"text\" class=\"large\" name=\"name\" placeholder=\"{{ _('Enter game title here') }}\" value=\"{{ game.name|translate(game) }}\" required>\n+            <span class=\"l\">{{ _('Name') }}</span>\n+            <span class=\"req\" data-required=\"{{ _('Required') }}\"></span>\n+          </label>\n+        </div>\n       </div>\n-    </div>\n-    <div class=\"unit one-of-three\">\n-      <div class=\"content form-help\">\n-        {{ _('Your game&rsquo;s name, which is shown on all listings in Galaxy.') }}\n+      <div class=\"grid-cell\">\n+        <div class=\"form-help\">\n+          {{ _('Your game&rsquo;s name, which is shown on all listings in Galaxy.') }}\n+        </div>\n       </div>\n     </div>\n \n-    <div class=\"unit two-of-three\">\n-      <div class=\"content form-field\">\n-        <label>\n-          <span class=\"input-prepend\">https://galaxy.firefox.com/game/</span>\n-          <input type=\"text\" name=\"slug\" placeholder=\"{{ _('Enter game listing slug here') }}\" value=\"{{ game.slug }}\" required>\n-          <span class=\"l\">{{ _('Game slug') }}</span>\n-          <span class=\"req\" data-required=\"{{ _('Required') }}\"></span>\n-        </label>\n+    <div class=\"grid content\">\n+      <div class=\"grid-cell grid-flex-grow-two\">\n+        <div class=\"form-field\">\n+          <label>\n+            <span class=\"input-prepend\">https://galaxy.firefox.com/game/</span>\n+            <input type=\"text\" name=\"slug\" placeholder=\"{{ _('Enter game listing slug here') }}\" value=\"{{ game.slug }}\" required>\n+            <span class=\"l\">{{ _('Game slug') }}</span>\n+            <span class=\"req\" data-required=\"{{ _('Required') }}\"></span>\n+          </label>\n+        </div>\n       </div>\n-    </div>\n-    <div class=\"unit one-of-three\">\n-      <div class=\"content form-help\">\n-        {{ _('Select a unique URL for your game detail page. By default we generate this from your game title.') }}\n+      <div class=\"grid-cell\">\n+        <div class=\"form-help\">\n+          {{ _('Select a unique URL for your game detail page. By default we generate this from your game title.') }}\n+        </div>\n       </div>\n     </div>\n \n-    <div class=\"unit two-of-three\">\n-      <div class=\"content form-field\">\n-        <label>\n-          <input type=\"url\" name=\"app_url\" pattern=\"https?://.*\" placeholder=\"{{ _('Enter game URL here') }}\" value=\"{{ game.app_url }}\" required>\n-          <span class=\"l\">{{ _('Game URL') }}</span>\n-          <span class=\"req\" data-required=\"{{ _('Required') }}\"></span>\n-        </label>\n+    <div class=\"grid content\">\n+      <div class=\"grid-cell grid-flex-grow-two\">\n+        <div class=\"form-field\">\n+          <label>\n+            <input type=\"url\" name=\"app_url\" pattern=\"https?://.*\" placeholder=\"{{ _('Enter game URL here') }}\" value=\"{{ game.app_url }}\" required>\n+            <span class=\"l\">{{ _('Game URL') }}</span>\n+            <span class=\"req\" data-required=\"{{ _('Required') }}\"></span>\n+          </label>\n+        </div>\n       </div>\n-    </div>\n-    <div class=\"unit one-of-three\">\n-      <div class=\"content form-help\">\n-        {{ _('The URL to your game hosted on your servers.') }}\n+      <div class=\"grid-cell\">\n+        <div class=\"form-help\">\n+          {{ _('The URL to your game hosted on your servers.') }}\n+        </div>\n       </div>\n     </div>\n \n-    <div class=\"unit two-of-three\">\n-      <div class=\"content form-field\">\n-        <label>\n-          <textarea name=\"description\" placeholder=\"{{ _('Enter game description here') }}\" required>{{ game.description }}</textarea>\n-          <span class=\"l\">{{ _('Description') }}</span>\n-          <span class=\"req\" data-required=\"{{ _('Required') }}\"></span>\n-        </label>\n+    <div class=\"grid content\">\n+      <div class=\"grid-cell grid-flex-grow-two\">\n+        <div class=\"form-field\">\n+          <label>\n+            <textarea name=\"description\" placeholder=\"{{ _('Enter game description here') }}\" required>{{ game.description }}</textarea>\n+            <span class=\"l\">{{ _('Description') }}</span>\n+            <span class=\"req\" data-required=\"{{ _('Required') }}\"></span>\n+          </label>\n+        </div>\n       </div>\n-    </div>\n-    <div class=\"unit one-of-three\">\n-      <div class=\"content form-help\">\n-        {{ _('Your game&rsquo;s description should be concise and capture the essence of what it does. It will be shown on all listings, and on your Galaxy game detail page.') }}\n+      <div class=\"grid-cell\">\n+        <div class=\"form-help\">\n+          {{ _('Your game&rsquo;s description should be concise and capture the essence of what it does. It will be shown on all listings, and on your Galaxy game detail page.') }}\n+        </div>\n       </div>\n     </div>\n \n-    <div class=\"unit two-of-three\">\n-      <div class=\"content form-field\">\n-        <label>\n-          <input type=\"url\" name=\"privacy_policy_url\" pattern=\"https?://.*\" placeholder=\"{{ _('Enter privacy policy URL here') }}\" value=\"{{ game.privacy_policy_url }}\" class=\"optional\">\n-          <span class=\"l\">{{ _('Privacy Policy URL') }}</span>\n-          <span class=\"req opt\" data-required=\"{{ _('Optional') }}\"></span>\n-        </label>\n+    <div class=\"grid content\">\n+      <div class=\"grid-cell grid-flex-grow-two\">\n+        <div class=\"form-field\">\n+          <label>\n+            <input type=\"url\" name=\"privacy_policy_url\" pattern=\"https?://.*\" placeholder=\"{{ _('Enter privacy policy URL here') }}\" value=\"{{ game.privacy_policy_url }}\" class=\"optional\">\n+            <span class=\"l\">{{ _('Privacy Policy URL') }}</span>\n+            <span class=\"req opt\" data-required=\"{{ _('Optional') }}\"></span>\n+          </label>\n+        </div>\n       </div>\n-    </div>\n-    <div class=\"unit one-of-three\">\n-      <div class=\"content form-help\">\n-        {{ _('Provide a URL to your privacy policy explaining what data is transmitted from a user&rsquo;s computer and how it is used. You can generate one at <a href=\"{iubenda_url}\" target=\"_blank\">iubenda.com</a>.', iubenda_url='https://www.iubenda.com/') }}\n+      <div class=\"grid-cell\">\n+        <div class=\"form-help\">\n+          {{ _('Provide a URL to your privacy policy explaining what data is transmitted from a user&rsquo;s computer and how it is used. You can generate one at <a href=\"{iubenda_url}\" target=\"_blank\">iubenda.com</a>.', iubenda_url='https://www.iubenda.com/') }}\n+        </div>\n       </div>\n     </div>\n \n-    <div class=\"unit two-of-three\">\n-      <div class=\"content form-field\">\n+    <div class=\"grid content\">\n+      <div class=\"grid-cell grid-flex-grow-two\">\n         <div class=\"l\">{{ _('Genre') }}</div>\n-        {% for slug, name in settings.genres.items() %}\n-            <label class=\"choice\"><input type=\"radio\" name=\"genre\"{{ ' checked' if slug == game.genre }} required value=\"{{ slug }}\"> {{ name }}</label>\n-        {% endfor %}\n-        <span class=\"req\" data-required=\"{{ _('Required') }}\"></span>\n+        <div class=\"form-field\">\n+          {% for slug, name in settings.genres.items() %}\n+              <label class=\"choice\"><input type=\"radio\" name=\"genre\"{{ ' checked' if slug == game.genre }} required value=\"{{ slug }}\"> {{ name }}</label>\n+          {% endfor %}\n+          <span class=\"req\" data-required=\"{{ _('Required') }}\"></span>\n+        </div>\n       </div>\n-    </div>\n-    <div class=\"unit one-of-three\">\n-      <div class=\"content form-help\">\n-        {{ _('Genres are used to classify games in Galaxy. Choose the genre that best fits your game.') }}\n+      <div class=\"grid-cell\">\n+        <div class=\"form-help\">\n+          {{ _('Genres are used to classify games in Galaxy.Choose the genre that best fits your game.') }}\n+        </div>\n       </div>\n     </div>\n \n-    <div class=\"unit span-grid\">\n-      <div class=\"content\">\n-        <h2>{{ _('Media') }}</h2>\n-      </div>\n-    </div>\n-    <div class=\"unit one-of-three\">\n-      <div class=\"icon media content form-field\">\n-        <label>\n-          <div class=\"l\">{{ _('Icon') }}\n+    <div class=\"content\">\n+      <div class=\"grid\">\n+        <div class=\"grid-cell grid-flex-grow-two\">\n+          <div class=\"l\">{{ _('Icon') }}</div>\n             <span class=\"req\" data-required=\"{{ _('Required') }}\"></span>\n-            <p class=\"form-help\">\n-              {{ _(\"The icon will be shown on all listings in Galaxy. Allowed image formats: <code>PNG</code>, <code>JPG</code>\") }}\n-            </p>\n+        </div>\n+        <div class=\"grid-cell\"></div>\n+      </div>\n+      <div class=\"grid\">\n+        <div class=\"grid-cell grid-flex-grow-two\">\n+          <div class=\"icon media form-field\">\n+            <label>\n+              <div class=\"fallback\" data-placeholder=\"{{ _('Icon URL') }}\">\n+                <input type=\"url\" value=\"{{ game.icon }}\" placeholder=\"{{ _('Icon URL') }}\" pattern=\"https?://.*\">\n+              </div>\n+            </label>\n+            <div class=\"file-size\"></div><div class=\"file-preview\"></div>\n           </div>\n-          <div class=\"fallback\" data-placeholder=\"{{ _('Icon URL') }}\">\n-            <input type=\"url\" value=\"{{ game.icon }}\" placeholder=\"{{ _('Icon URL') }}\" pattern=\"https?://.*\">\n-          </div>\n-        </label>\n-        <div class=\"file-size\"></div><div class=\"file-preview\"></div>\n+        </div>\n+        <div class=\"grid-cell\">\n+          <p class=\"form-help\">\n+            {{ _(\"The icon will be shown on all listings in Galaxy.<br/>Allowed image formats: <code>PNG</code>, <code>JPG</code>\") }}\n+          </p>\n+        </div>\n       </div>\n     </div>\n-    <div class=\"unit one-of-three\">\n-      <div class=\"screenshots media content form-field\">\n-        <label>\n-          <div class=\"l\">{{ _('Screenshots') }}\n-            <span class=\"req\" data-required=\"{{ _('Required') }}\"></span>\n-            <p class=\"form-help\">\n-              {{ _(\"Screenshots will be shown on your game detail page. Allowed image formats: <code>PNG</code>, <code>JPG</code>\") }}\n-            </p>\n-          </div>\n-          <div class=\"fallback\" data-placeholder=\"{{ _('Image URL') }}\">\n-            {% for screenshot in game.screenshots %}\n-              <input type=\"url\" value=\"{{ screenshot }}\" placeholder=\"{{ _('Image URL') }}\" pattern=\"https?://.*\">\n-            {% endfor %}\n+\n+    <div class=\"content\">","path":"src/templates/_macros/game_form.html","position":230,"original_position":230,"commit_id":"66cb44db3ef60d9c4511ff1ccad94b8cffdb2084","original_commit_id":"66cb44db3ef60d9c4511ff1ccad94b8cffdb2084","user":{"login":"cvan","id":203725,"avatar_url":"https://gravatar.com/avatar/47de0e6948b289c9b4b4be0d6d66c0f4?d=https%3A%2F%2Fidenticons.github.com%2Fe8d88d4bdf0c8bb9968e62c64a9d8df1.png&r=x","gravatar_id":"47de0e6948b289c9b4b4be0d6d66c0f4","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User","site_admin":false},"body":"it's fine for now","created_at":"2014-03-05T06:58:53Z","updated_at":"2014-03-05T06:58:53Z","html_url":"https://github.com/cvan/galaxy/pull/101#discussion_r10289373","pull_request_url":"https://api.github.com/repos/cvan/galaxy/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/cvan/galaxy/pulls/comments/10289373"},"html":{"href":"https://github.com/cvan/galaxy/pull/101#discussion_r10289373"},"pull_request":{"href":"https://api.github.com/repos/cvan/galaxy/pulls/101"}}}}