GitHub PullRequestReviewCommentEvent at 2014-03-05 05:56:30
Repository: hazelcast
Actor: pveentjer
Payload: {"comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/10288509","id":10288509,"diff_hunk":"@@ -249,7 +258,9 @@ else if (operation instanceof GetOperation)\n         PutOperation operation = new PutOperation(name, key, value, getTimeInMillis(ttl, timeunit));\n         operation.setThreadId(ThreadUtil.getThreadId());\n         try {\n-            return nodeEngine.getOperationService().invokeOnPartition(SERVICE_NAME, operation, partitionId);\n+            ICompletableFuture<Data> future = nodeEngine.getOperationService().invokeOnPartition(SERVICE_NAME, operation, partitionId);","path":"hazelcast/src/main/java/com/hazelcast/map/proxy/MapProxySupport.java","position":40,"original_position":40,"commit_id":"3c81050708e92cdb281f571fce0a674900fcac8e","original_commit_id":"3c81050708e92cdb281f571fce0a674900fcac8e","user":{"login":"pveentjer","id":105243,"avatar_url":"https://gravatar.com/avatar/d8b5cf3679fa7a4f32994df31d6fb180?d=https%3A%2F%2Fidenticons.github.com%2F3f2a98e64b9abd9ae71c3cf2f96af482.png&r=x","gravatar_id":"d8b5cf3679fa7a4f32994df31d6fb180","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"body":"Can't you make use of the invokeOperation(key, operation) method?","created_at":"2014-03-05T05:56:30Z","updated_at":"2014-03-05T05:56:30Z","html_url":"https://github.com/hazelcast/hazelcast/pull/1922#discussion_r10288509","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/1922","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/10288509"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/1922#discussion_r10288509"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/1922"}}}}