GitHub PullRequestReviewCommentEvent at 2014-03-31 15:12:10
Repository: spring-integration
Actor: garyrussell
Payload: {"comment":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/11119842","id":11119842,"diff_hunk":"@@ -0,0 +1,91 @@\n+/*\n+ * Copyright 2014 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.springframework.integration.config;\n+\n+import java.util.Set;\n+\n+import org.springframework.beans.BeanMetadataElement;\n+import org.springframework.beans.BeansException;\n+import org.springframework.beans.factory.annotation.AnnotatedBeanDefinition;\n+import org.springframework.beans.factory.config.BeanDefinition;\n+import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;\n+import org.springframework.beans.factory.config.RuntimeBeanReference;\n+import org.springframework.beans.factory.support.BeanDefinitionBuilder;\n+import org.springframework.beans.factory.support.BeanDefinitionRegistry;\n+import org.springframework.beans.factory.support.ManagedSet;\n+import org.springframework.beans.factory.support.RootBeanDefinition;\n+import org.springframework.core.type.AnnotationMetadata;\n+import org.springframework.core.type.MethodMetadata;\n+import org.springframework.integration.context.IntegrationContextUtils;\n+\n+/**\n+ * @author Artem Bilan\n+ * @since 4.0\n+ */\n+public class IntegrationConverterInitializer implements IntegrationConfigurationInitializer {\n+\n+\tprivate static final String CONTEXT_PACKAGE = \"org.springframework.integration.context.\";\n+\n+\t@Override\n+\tpublic void initialize(ConfigurableListableBeanFactory beanFactory) throws BeansException {\n+\t\tBeanDefinitionRegistry registry = (BeanDefinitionRegistry) beanFactory;\n+\n+\t\tfor (String beanName : registry.getBeanDefinitionNames()) {","path":"spring-integration-core/src/main/java/org/springframework/integration/config/IntegrationConverterInitializer.java","position":47,"original_position":47,"commit_id":"d8c89e531580112b4d218dd17a1f4d37b2e87dda","original_commit_id":"d8c89e531580112b4d218dd17a1f4d37b2e87dda","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?","gravatar_id":"9f30ba7b0ff0c1b76b07010960dde60d","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"body":"Not important now, but I wonder if we should consider consolidating these core initializers into one so we only have to iterate over the beans once.","created_at":"2014-03-31T15:12:10Z","updated_at":"2014-03-31T15:12:10Z","html_url":"https://github.com/spring-projects/spring-integration/pull/1096#discussion_r11119842","pull_request_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1096","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/11119842"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/1096#discussion_r11119842"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1096"}}}}