GitHub PullRequestReviewCommentEvent at 2014-07-22 14:07:17
Repository: bookingsync-api-docs
Actor: wijet
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls/comments/15229242","id":15229242,"diff_hunk":"@@ -72,15 +72,15 @@\n       \"city\": \"Nevache\",\n       \"state\": null,\n       \"country\": \"France\",\n-      \"contact_name\": \"Contact Fullname\",\n+      \"contact_name\": \"Betty Reichert\",\n       \"reviews_count\": 5,\n       \"reviews_average_rating\": \"4.0\",\n       \"created_at\": \"CREATED_AT\",\n       \"updated_at\": \"UPDATED_AT\",\n       \"checkin_time\": 16,\n       \"checkout_time\": 10,\n-      \"initial_price\": null,\n-      \"final_price\": null\n+      \"initial_price\": 100,","path":"responses/rentals/public-scope.json","position":49,"original_position":49,"commit_id":"d883e6aae3e1920844774cb1a171237a06b16ff6","original_commit_id":"d883e6aae3e1920844774cb1a171237a06b16ff6","user":{"login":"wijet","id":427,"avatar_url":"https://avatars.githubusercontent.com/u/427?","gravatar_id":"2b1915c37067626813a2f04d4a6b0c92","url":"https://api.github.com/users/wijet","html_url":"https://github.com/wijet","followers_url":"https://api.github.com/users/wijet/followers","following_url":"https://api.github.com/users/wijet/following{/other_user}","gists_url":"https://api.github.com/users/wijet/gists{/gist_id}","starred_url":"https://api.github.com/users/wijet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wijet/subscriptions","organizations_url":"https://api.github.com/users/wijet/orgs","repos_url":"https://api.github.com/users/wijet/repos","events_url":"https://api.github.com/users/wijet/events{/privacy}","received_events_url":"https://api.github.com/users/wijet/received_events","type":"User","site_admin":false},"body":"yeah, so to explain, this price is only here when you pass start/end_at to /search, It should be never in the index as there is not computation. Shouldn't we remove it from the serialiser if it's not search?","created_at":"2014-07-22T14:07:17Z","updated_at":"2014-07-22T14:07:17Z","html_url":"https://github.com/BookingSync/bookingsync-api-docs/pull/38#discussion_r15229242","pull_request_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls/comments/15229242"},"html":{"href":"https://github.com/BookingSync/bookingsync-api-docs/pull/38#discussion_r15229242"},"pull_request":{"href":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls/38","id":18708447,"html_url":"https://github.com/BookingSync/bookingsync-api-docs/pull/38","diff_url":"https://github.com/BookingSync/bookingsync-api-docs/pull/38.diff","patch_url":"https://github.com/BookingSync/bookingsync-api-docs/pull/38.patch","issue_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/issues/38","number":38,"state":"open","title":"Finish rental docs","user":{"login":"Fredar","id":6557731,"avatar_url":"https://avatars.githubusercontent.com/u/6557731?","gravatar_id":"b49b329627600d6905ae32c8ce8178b7","url":"https://api.github.com/users/Fredar","html_url":"https://github.com/Fredar","followers_url":"https://api.github.com/users/Fredar/followers","following_url":"https://api.github.com/users/Fredar/following{/other_user}","gists_url":"https://api.github.com/users/Fredar/gists{/gist_id}","starred_url":"https://api.github.com/users/Fredar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fredar/subscriptions","organizations_url":"https://api.github.com/users/Fredar/orgs","repos_url":"https://api.github.com/users/Fredar/repos","events_url":"https://api.github.com/users/Fredar/events{/privacy}","received_events_url":"https://api.github.com/users/Fredar/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-07-22T11:34:13Z","updated_at":"2014-07-22T14:07:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"885e1eb05763be8780ab2c44e434a910f2fb7a3f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls/38/commits","review_comments_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls/38/comments","review_comment_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/issues/38/comments","statuses_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/statuses/d883e6aae3e1920844774cb1a171237a06b16ff6","head":{"label":"BookingSync:finish-rental-docs","ref":"finish-rental-docs","sha":"d883e6aae3e1920844774cb1a171237a06b16ff6","user":{"login":"BookingSync","id":552099,"avatar_url":"https://avatars.githubusercontent.com/u/552099?","gravatar_id":"cf5c5ec58cd8f7a9e4dc02155cc7ba93","url":"https://api.github.com/users/BookingSync","html_url":"https://github.com/BookingSync","followers_url":"https://api.github.com/users/BookingSync/followers","following_url":"https://api.github.com/users/BookingSync/following{/other_user}","gists_url":"https://api.github.com/users/BookingSync/gists{/gist_id}","starred_url":"https://api.github.com/users/BookingSync/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BookingSync/subscriptions","organizations_url":"https://api.github.com/users/BookingSync/orgs","repos_url":"https://api.github.com/users/BookingSync/repos","events_url":"https://api.github.com/users/BookingSync/events{/privacy}","received_events_url":"https://api.github.com/users/BookingSync/received_events","type":"Organization","site_admin":false},"repo":{"id":17672169,"name":"bookingsync-api-docs","full_name":"BookingSync/bookingsync-api-docs","owner":{"login":"BookingSync","id":552099,"avatar_url":"https://avatars.githubusercontent.com/u/552099?","gravatar_id":"cf5c5ec58cd8f7a9e4dc02155cc7ba93","url":"https://api.github.com/users/BookingSync","html_url":"https://github.com/BookingSync","followers_url":"https://api.github.com/users/BookingSync/followers","following_url":"https://api.github.com/users/BookingSync/following{/other_user}","gists_url":"https://api.github.com/users/BookingSync/gists{/gist_id}","starred_url":"https://api.github.com/users/BookingSync/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BookingSync/subscriptions","organizations_url":"https://api.github.com/users/BookingSync/orgs","repos_url":"https://api.github.com/users/BookingSync/repos","events_url":"https://api.github.com/users/BookingSync/events{/privacy}","received_events_url":"https://api.github.com/users/BookingSync/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BookingSync/bookingsync-api-docs","description":"BookingSync API Documentations","fork":false,"url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs","forks_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/forks","keys_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/teams","hooks_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/hooks","issue_events_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/issues/events{/number}","events_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/events","assignees_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/assignees{/user}","branches_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/branches{/branch}","tags_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/tags","blobs_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/languages","stargazers_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/stargazers","contributors_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/contributors","subscribers_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/subscribers","subscription_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/subscription","commits_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/contents/{+path}","compare_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/merges","archive_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/downloads","issues_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/issues{/number}","pulls_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/labels{/name}","releases_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/releases{/id}","created_at":"2014-03-12T15:37:10Z","updated_at":"2014-07-01T09:57:59Z","pushed_at":"2014-07-22T11:32:23Z","git_url":"git://github.com/BookingSync/bookingsync-api-docs.git","ssh_url":"git@github.com:BookingSync/bookingsync-api-docs.git","clone_url":"https://github.com/BookingSync/bookingsync-api-docs.git","svn_url":"https://github.com/BookingSync/bookingsync-api-docs","homepage":"http://docs.api.bookingsync.com/","size":3244,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"BookingSync:master","ref":"master","sha":"6107942915e22c33c5e3912753553334923fbfc2","user":{"login":"BookingSync","id":552099,"avatar_url":"https://avatars.githubusercontent.com/u/552099?","gravatar_id":"cf5c5ec58cd8f7a9e4dc02155cc7ba93","url":"https://api.github.com/users/BookingSync","html_url":"https://github.com/BookingSync","followers_url":"https://api.github.com/users/BookingSync/followers","following_url":"https://api.github.com/users/BookingSync/following{/other_user}","gists_url":"https://api.github.com/users/BookingSync/gists{/gist_id}","starred_url":"https://api.github.com/users/BookingSync/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BookingSync/subscriptions","organizations_url":"https://api.github.com/users/BookingSync/orgs","repos_url":"https://api.github.com/users/BookingSync/repos","events_url":"https://api.github.com/users/BookingSync/events{/privacy}","received_events_url":"https://api.github.com/users/BookingSync/received_events","type":"Organization","site_admin":false},"repo":{"id":17672169,"name":"bookingsync-api-docs","full_name":"BookingSync/bookingsync-api-docs","owner":{"login":"BookingSync","id":552099,"avatar_url":"https://avatars.githubusercontent.com/u/552099?","gravatar_id":"cf5c5ec58cd8f7a9e4dc02155cc7ba93","url":"https://api.github.com/users/BookingSync","html_url":"https://github.com/BookingSync","followers_url":"https://api.github.com/users/BookingSync/followers","following_url":"https://api.github.com/users/BookingSync/following{/other_user}","gists_url":"https://api.github.com/users/BookingSync/gists{/gist_id}","starred_url":"https://api.github.com/users/BookingSync/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BookingSync/subscriptions","organizations_url":"https://api.github.com/users/BookingSync/orgs","repos_url":"https://api.github.com/users/BookingSync/repos","events_url":"https://api.github.com/users/BookingSync/events{/privacy}","received_events_url":"https://api.github.com/users/BookingSync/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BookingSync/bookingsync-api-docs","description":"BookingSync API Documentations","fork":false,"url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs","forks_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/forks","keys_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/teams","hooks_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/hooks","issue_events_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/issues/events{/number}","events_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/events","assignees_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/assignees{/user}","branches_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/branches{/branch}","tags_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/tags","blobs_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/languages","stargazers_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/stargazers","contributors_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/contributors","subscribers_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/subscribers","subscription_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/subscription","commits_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/contents/{+path}","compare_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/merges","archive_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/downloads","issues_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/issues{/number}","pulls_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/labels{/name}","releases_url":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/releases{/id}","created_at":"2014-03-12T15:37:10Z","updated_at":"2014-07-01T09:57:59Z","pushed_at":"2014-07-22T11:32:23Z","git_url":"git://github.com/BookingSync/bookingsync-api-docs.git","ssh_url":"git@github.com:BookingSync/bookingsync-api-docs.git","clone_url":"https://github.com/BookingSync/bookingsync-api-docs.git","svn_url":"https://github.com/BookingSync/bookingsync-api-docs","homepage":"http://docs.api.bookingsync.com/","size":3244,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls/38"},"html":{"href":"https://github.com/BookingSync/bookingsync-api-docs/pull/38"},"issue":{"href":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/issues/38"},"comments":{"href":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/BookingSync/bookingsync-api-docs/statuses/d883e6aae3e1920844774cb1a171237a06b16ff6"}}}}