GitHub PullRequestReviewCommentEvent at 2014-04-25 12:11:31
Repository: datagrid-bundle
Actor: chives
Payload: {"comment":{"url":"https://api.github.com/repos/fsi-open/datagrid-bundle/pulls/comments/11993159","id":11993159,"diff_hunk":"@@ -78,8 +81,13 @@ protected function hasDataGridConfiguration($bundlePath, $dataGridName)\n      */\n     protected function getDataGridConfiguration($bundlePath, $dataGridName)\n     {\n-        $yamlParser = new Parser();\n-        return $yamlParser->parse(file_get_contents(sprintf($bundlePath . '/Resources/config/datagrid/%s.yml', $dataGridName)));\n+        $conf = Yaml::parse(sprintf($bundlePath . '/Resources/config/datagrid/%s.yml', $dataGridName));","path":"DataGrid/Extension/Configuration/EventSubscriber/ConfigurationBuilder.php","position":26,"original_position":26,"commit_id":"bdf17b3a17c0411a4ec207d8d15a06d21daf25cc","original_commit_id":"bdf17b3a17c0411a4ec207d8d15a06d21daf25cc","user":{"login":"chives","id":1170578,"avatar_url":"https://avatars.githubusercontent.com/u/1170578?","gravatar_id":"aa8434fbff1ccdedc7aa83f18d90324d","url":"https://api.github.com/users/chives","html_url":"https://github.com/chives","followers_url":"https://api.github.com/users/chives/followers","following_url":"https://api.github.com/users/chives/following{/other_user}","gists_url":"https://api.github.com/users/chives/gists{/gist_id}","starred_url":"https://api.github.com/users/chives/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chives/subscriptions","organizations_url":"https://api.github.com/users/chives/orgs","repos_url":"https://api.github.com/users/chives/repos","events_url":"https://api.github.com/users/chives/events{/privacy}","received_events_url":"https://api.github.com/users/chives/received_events","type":"User","site_admin":false},"body":"You can get rid of ``.`` and use ``sprintf`` for substitution of both ``$bundlePath`` and ``$dataGridName``","created_at":"2014-04-25T12:11:31Z","updated_at":"2014-04-25T12:11:31Z","html_url":"https://github.com/fsi-open/datagrid-bundle/pull/45#discussion_r11993159","pull_request_url":"https://api.github.com/repos/fsi-open/datagrid-bundle/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/fsi-open/datagrid-bundle/pulls/comments/11993159"},"html":{"href":"https://github.com/fsi-open/datagrid-bundle/pull/45#discussion_r11993159"},"pull_request":{"href":"https://api.github.com/repos/fsi-open/datagrid-bundle/pulls/45"}}}}