GitHub PullRequestReviewCommentEvent at 2014-03-17 20:28:35
Repository: GoodGamesServer
Actor: gltarsa
Payload: {"comment":{"url":"https://api.github.com/repos/gltarsa/GoodGamesServer/pulls/comments/10677160","id":10677160,"diff_hunk":"@@ -0,0 +1,69 @@\n+describe Player, \"Player communications\" do\n+  before (:each) do\n+    @player = Player.new(0, \"No Name\")\n+  end\n+\n+  it \".new creates an empty human player\" do\n+    @player.number.should eql 0\n+    @player.name.should eql \"No Name\"\n+    class Player","path":"spec/models/player_spec.rb","position":9,"original_position":9,"commit_id":"7fbe230adecf9c5b4d88aa11d3c1cc436a2240ff","original_commit_id":"7fbe230adecf9c5b4d88aa11d3c1cc436a2240ff","user":{"login":"gltarsa","id":4733453,"avatar_url":"https://gravatar.com/avatar/6a3175adf3fae0cc86873a8e970d9879?d=https%3A%2F%2Fidenticons.github.com%2Fa67903ed90589b94c3344922ca347561.png&r=x","gravatar_id":"6a3175adf3fae0cc86873a8e970d9879","url":"https://api.github.com/users/gltarsa","html_url":"https://github.com/gltarsa","followers_url":"https://api.github.com/users/gltarsa/followers","following_url":"https://api.github.com/users/gltarsa/following{/other_user}","gists_url":"https://api.github.com/users/gltarsa/gists{/gist_id}","starred_url":"https://api.github.com/users/gltarsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gltarsa/subscriptions","organizations_url":"https://api.github.com/users/gltarsa/orgs","repos_url":"https://api.github.com/users/gltarsa/repos","events_url":"https://api.github.com/users/gltarsa/events{/privacy}","received_events_url":"https://api.github.com/users/gltarsa/received_events","type":"User","site_admin":false},"body":"Changed to use the .robot? method.\r\nOn Mar 14, 2014, at 12:59 PM, Tim Irwin <notifications@github.com> wrote:\r\n\r\n> In spec/models/player_spec.rb:\r\n> \r\n> > @@ -0,0 +1,69 @@\r\n> > +describe Player, \"Player communications\" do\r\n> > +  before (:each) do\r\n> > +    @player = Player.new(0, \"No Name\")\r\n> > +  end\r\n> > +\r\n> > +  it \".new creates an empty human player\" do\r\n> > +    @player.number.should eql 0\r\n> > +    @player.name.should eql \"No Name\"\r\n> > +    class Player\r\n> Do you really care how it is stored internally? Or should you just be testing the .human? and .robot? methods?\r\n> \r\n> —\r\n> Reply to this email directly or view it on GitHub.\r\n> ","created_at":"2014-03-17T20:28:35Z","updated_at":"2014-03-17T20:28:35Z","html_url":"https://github.com/gltarsa/GoodGamesServer/pull/2#discussion_r10677160","pull_request_url":"https://api.github.com/repos/gltarsa/GoodGamesServer/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/gltarsa/GoodGamesServer/pulls/comments/10677160"},"html":{"href":"https://github.com/gltarsa/GoodGamesServer/pull/2#discussion_r10677160"},"pull_request":{"href":"https://api.github.com/repos/gltarsa/GoodGamesServer/pulls/2"}}}}