GitHub PullRequestEvent at 2014-02-09 20:10:40
Repository: puppet
Actor: zaphod42
Payload: {"action":"opened","number":2341,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2341","id":12353564,"html_url":"https://github.com/puppetlabs/puppet/pull/2341","diff_url":"https://github.com/puppetlabs/puppet/pull/2341.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/2341.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2341","number":2341,"state":"open","title":"(PUP-751) Benchmark and optimize loading of defined types","user":{"login":"zaphod42","id":295810,"avatar_url":"https://gravatar.com/avatar/36ccf398adbe1a4264d57b32917b990c?d=https%3A%2F%2Fidenticons.github.com%2Ff8dc72ae8e222c771273e2d9262581d7.png&r=x","gravatar_id":"36ccf398adbe1a4264d57b32917b990c","url":"https://api.github.com/users/zaphod42","html_url":"https://github.com/zaphod42","followers_url":"https://api.github.com/users/zaphod42/followers","following_url":"https://api.github.com/users/zaphod42/following{/other_user}","gists_url":"https://api.github.com/users/zaphod42/gists{/gist_id}","starred_url":"https://api.github.com/users/zaphod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaphod42/subscriptions","organizations_url":"https://api.github.com/users/zaphod42/orgs","repos_url":"https://api.github.com/users/zaphod42/repos","events_url":"https://api.github.com/users/zaphod42/events{/privacy}","received_events_url":"https://api.github.com/users/zaphod42/received_events","type":"User","site_admin":false},"body":"This adds a benchmark scenario for defined types. It also includes some\noptimizations that target this benchmark. Overall there is about a 19%\nimprovement for the benchmark.\n\nHere is the breakdown of the speedups to this point on my machine:\n\nInitial(bca4d4e):\n    > total:     7.520000   1.250000   8.770000 (  8.789636)\n    > avg:       0.752000   0.125000   0.877000 (  0.878964)\n\nPrefer defined types(2617d61):\n    > total:     7.150000   1.170000   8.320000 (  8.326319)\n    > avg:       0.715000   0.117000   0.832000 (  0.832632)\n\nPreserve environment(3f8e94c):\n    > total:     6.170000   0.860000   7.030000 (  7.057820)\n    > avg:       0.617000   0.086000   0.703000 (  0.705782)\n\nI also tried to change the order of loading in\nPuppet::Parser::Scope#find_resource_type to have it look for defined types\nfirst, but that resulted in an overall slowdown:\n\n    > total:     6.740000   0.730000   7.470000 (  7.476968)\n    > avg:       0.674000   0.073000   0.747000 (  0.747697)","created_at":"2014-02-09T20:10:39Z","updated_at":"2014-02-09T20:10:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25349bface956a34da091bde001bcd84657465d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2341/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2341/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2341/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/79d85535e2a9ce7683af5efbff4ba7bde3e3b137","head":{"label":"zaphod42:issue/master/pup-751-define-type-benchmarks","ref":"issue/master/pup-751-define-type-benchmarks","sha":"79d85535e2a9ce7683af5efbff4ba7bde3e3b137","user":{"login":"zaphod42","id":295810,"avatar_url":"https://gravatar.com/avatar/36ccf398adbe1a4264d57b32917b990c?d=https%3A%2F%2Fidenticons.github.com%2Ff8dc72ae8e222c771273e2d9262581d7.png&r=x","gravatar_id":"36ccf398adbe1a4264d57b32917b990c","url":"https://api.github.com/users/zaphod42","html_url":"https://github.com/zaphod42","followers_url":"https://api.github.com/users/zaphod42/followers","following_url":"https://api.github.com/users/zaphod42/following{/other_user}","gists_url":"https://api.github.com/users/zaphod42/gists{/gist_id}","starred_url":"https://api.github.com/users/zaphod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaphod42/subscriptions","organizations_url":"https://api.github.com/users/zaphod42/orgs","repos_url":"https://api.github.com/users/zaphod42/repos","events_url":"https://api.github.com/users/zaphod42/events{/privacy}","received_events_url":"https://api.github.com/users/zaphod42/received_events","type":"User","site_admin":false},"repo":{"id":3769776,"name":"puppet","full_name":"zaphod42/puppet","owner":{"login":"zaphod42","id":295810,"avatar_url":"https://gravatar.com/avatar/36ccf398adbe1a4264d57b32917b990c?d=https%3A%2F%2Fidenticons.github.com%2Ff8dc72ae8e222c771273e2d9262581d7.png&r=x","gravatar_id":"36ccf398adbe1a4264d57b32917b990c","url":"https://api.github.com/users/zaphod42","html_url":"https://github.com/zaphod42","followers_url":"https://api.github.com/users/zaphod42/followers","following_url":"https://api.github.com/users/zaphod42/following{/other_user}","gists_url":"https://api.github.com/users/zaphod42/gists{/gist_id}","starred_url":"https://api.github.com/users/zaphod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaphod42/subscriptions","organizations_url":"https://api.github.com/users/zaphod42/orgs","repos_url":"https://api.github.com/users/zaphod42/repos","events_url":"https://api.github.com/users/zaphod42/events{/privacy}","received_events_url":"https://api.github.com/users/zaphod42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zaphod42/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/zaphod42/puppet","forks_url":"https://api.github.com/repos/zaphod42/puppet/forks","keys_url":"https://api.github.com/repos/zaphod42/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaphod42/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaphod42/puppet/teams","hooks_url":"https://api.github.com/repos/zaphod42/puppet/hooks","issue_events_url":"https://api.github.com/repos/zaphod42/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/zaphod42/puppet/events","assignees_url":"https://api.github.com/repos/zaphod42/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/zaphod42/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/zaphod42/puppet/tags","blobs_url":"https://api.github.com/repos/zaphod42/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaphod42/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaphod42/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaphod42/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaphod42/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/zaphod42/puppet/languages","stargazers_url":"https://api.github.com/repos/zaphod42/puppet/stargazers","contributors_url":"https://api.github.com/repos/zaphod42/puppet/contributors","subscribers_url":"https://api.github.com/repos/zaphod42/puppet/subscribers","subscription_url":"https://api.github.com/repos/zaphod42/puppet/subscription","commits_url":"https://api.github.com/repos/zaphod42/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaphod42/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaphod42/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaphod42/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/zaphod42/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/zaphod42/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaphod42/puppet/merges","archive_url":"https://api.github.com/repos/zaphod42/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaphod42/puppet/downloads","issues_url":"https://api.github.com/repos/zaphod42/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/zaphod42/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/zaphod42/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/zaphod42/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaphod42/puppet/labels{/name}","releases_url":"https://api.github.com/repos/zaphod42/puppet/releases{/id}","created_at":"2012-03-19T23:17:16Z","updated_at":"2014-02-09T20:10:39Z","pushed_at":"2014-02-09T20:07:51Z","git_url":"git://github.com/zaphod42/puppet.git","ssh_url":"git@github.com:zaphod42/puppet.git","clone_url":"https://github.com/zaphod42/puppet.git","svn_url":"https://github.com/zaphod42/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":39911,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master","master_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"d65211e0c25d74f6dac385c750cf0b0ef4f21888","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://gravatar.com/avatar/eb454c2139c156db7c8266a875519a1f?d=https%3A%2F%2Fidenticons.github.com%2F0a07e64734f6d8027c78e7e98067cdfd.png&r=x","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://gravatar.com/avatar/eb454c2139c156db7c8266a875519a1f?d=https%3A%2F%2Fidenticons.github.com%2F0a07e64734f6d8027c78e7e98067cdfd.png&r=x","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2014-02-07T23:03:10Z","pushed_at":"2014-02-07T23:03:10Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":79123,"stargazers_count":1798,"watchers_count":1798,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":835,"mirror_url":null,"open_issues_count":46,"forks":835,"open_issues":46,"watchers":1798,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2341"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2341"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2341"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2341/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2341/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2341/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/79d85535e2a9ce7683af5efbff4ba7bde3e3b137"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":9,"additions":142,"deletions":110,"changed_files":15}}