GitHub PullRequestReviewCommentEvent at 2014-10-30 22:24:10
Repository: origin
Actor: smarterclayton
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/19640820","id":19640820,"diff_hunk":"@@ -82,6 +88,8 @@ type DeploymentConfig struct {\n \t// LatestVersion is used to determine whether the current deployment associated with a DeploymentConfig\n \t// is out of sync.\n \tLatestVersion int `json:\"latestVersion,omitempty\" yaml:\"latestVersion,omitempty\"`\n+\t// The trigger that fired and resulted in the update to this deployment config.\n+\tFiredTrigger DeploymentTriggerDetails `json:\"firedTrigger,omitempty\" yaml:\"firedTrigger,omitempty\"`","path":"pkg/deploy/api/types.go","position":25,"original_position":25,"commit_id":"fda3e6ce9f64cf7dfc399546165314b4c67eb916","original_commit_id":"fda3e6ce9f64cf7dfc399546165314b4c67eb916","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=2","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"This has to be a pointer, and I'm not sure I consider the trigger the important info here.  The thing we need to capture is the \"why\", and this is very heavily biased to triggers vs user driven changes.\r\n\r\nI'd like to see a field that represents both automatic or end user input.  The reason for a change needs to be human focused.  I'm not sure this shouldn't just be an annotation, but it's ok to explore a real struct.\r\n\r\nA user entered reason in addition to the trigger is relevant.  Also, multiple triggers can result in a change, so just one is not sufficient.","created_at":"2014-10-30T22:24:10Z","updated_at":"2014-10-30T22:24:10Z","html_url":"https://github.com/openshift/origin/pull/302#discussion_r19640820","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/302","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/19640820"},"html":{"href":"https://github.com/openshift/origin/pull/302#discussion_r19640820"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/302","id":23637349,"html_url":"https://github.com/openshift/origin/pull/302","diff_url":"https://github.com/openshift/origin/pull/302.diff","patch_url":"https://github.com/openshift/origin/pull/302.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/302","number":302,"state":"open","locked":false,"title":"Adding metadata for fired trigger to the deployment","user":{"login":"abhgupta","id":1211613,"avatar_url":"https://avatars.githubusercontent.com/u/1211613?v=2","gravatar_id":"","url":"https://api.github.com/users/abhgupta","html_url":"https://github.com/abhgupta","followers_url":"https://api.github.com/users/abhgupta/followers","following_url":"https://api.github.com/users/abhgupta/following{/other_user}","gists_url":"https://api.github.com/users/abhgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/abhgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhgupta/subscriptions","organizations_url":"https://api.github.com/users/abhgupta/orgs","repos_url":"https://api.github.com/users/abhgupta/repos","events_url":"https://api.github.com/users/abhgupta/events{/privacy}","received_events_url":"https://api.github.com/users/abhgupta/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-10-30T20:48:32Z","updated_at":"2014-10-30T22:24:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b99030c5158ea8bd92d4f0ec377295885c8a012","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/302/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/302/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/302/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/fda3e6ce9f64cf7dfc399546165314b4c67eb916","head":{"label":"abhgupta:abhgupta-dev","ref":"abhgupta-dev","sha":"fda3e6ce9f64cf7dfc399546165314b4c67eb916","user":{"login":"abhgupta","id":1211613,"avatar_url":"https://avatars.githubusercontent.com/u/1211613?v=2","gravatar_id":"","url":"https://api.github.com/users/abhgupta","html_url":"https://github.com/abhgupta","followers_url":"https://api.github.com/users/abhgupta/followers","following_url":"https://api.github.com/users/abhgupta/following{/other_user}","gists_url":"https://api.github.com/users/abhgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/abhgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhgupta/subscriptions","organizations_url":"https://api.github.com/users/abhgupta/orgs","repos_url":"https://api.github.com/users/abhgupta/repos","events_url":"https://api.github.com/users/abhgupta/events{/privacy}","received_events_url":"https://api.github.com/users/abhgupta/received_events","type":"User","site_admin":false},"repo":{"id":23977841,"name":"origin","full_name":"abhgupta/origin","owner":{"login":"abhgupta","id":1211613,"avatar_url":"https://avatars.githubusercontent.com/u/1211613?v=2","gravatar_id":"","url":"https://api.github.com/users/abhgupta","html_url":"https://github.com/abhgupta","followers_url":"https://api.github.com/users/abhgupta/followers","following_url":"https://api.github.com/users/abhgupta/following{/other_user}","gists_url":"https://api.github.com/users/abhgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/abhgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhgupta/subscriptions","organizations_url":"https://api.github.com/users/abhgupta/orgs","repos_url":"https://api.github.com/users/abhgupta/repos","events_url":"https://api.github.com/users/abhgupta/events{/privacy}","received_events_url":"https://api.github.com/users/abhgupta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhgupta/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/abhgupta/origin","forks_url":"https://api.github.com/repos/abhgupta/origin/forks","keys_url":"https://api.github.com/repos/abhgupta/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhgupta/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhgupta/origin/teams","hooks_url":"https://api.github.com/repos/abhgupta/origin/hooks","issue_events_url":"https://api.github.com/repos/abhgupta/origin/issues/events{/number}","events_url":"https://api.github.com/repos/abhgupta/origin/events","assignees_url":"https://api.github.com/repos/abhgupta/origin/assignees{/user}","branches_url":"https://api.github.com/repos/abhgupta/origin/branches{/branch}","tags_url":"https://api.github.com/repos/abhgupta/origin/tags","blobs_url":"https://api.github.com/repos/abhgupta/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhgupta/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhgupta/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhgupta/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhgupta/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/abhgupta/origin/languages","stargazers_url":"https://api.github.com/repos/abhgupta/origin/stargazers","contributors_url":"https://api.github.com/repos/abhgupta/origin/contributors","subscribers_url":"https://api.github.com/repos/abhgupta/origin/subscribers","subscription_url":"https://api.github.com/repos/abhgupta/origin/subscription","commits_url":"https://api.github.com/repos/abhgupta/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhgupta/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhgupta/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhgupta/origin/issues/comments/{number}","contents_url":"https://api.github.com/repos/abhgupta/origin/contents/{+path}","compare_url":"https://api.github.com/repos/abhgupta/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhgupta/origin/merges","archive_url":"https://api.github.com/repos/abhgupta/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhgupta/origin/downloads","issues_url":"https://api.github.com/repos/abhgupta/origin/issues{/number}","pulls_url":"https://api.github.com/repos/abhgupta/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/abhgupta/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/abhgupta/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhgupta/origin/labels{/name}","releases_url":"https://api.github.com/repos/abhgupta/origin/releases{/id}","created_at":"2014-09-12T21:38:33Z","updated_at":"2014-09-15T20:40:11Z","pushed_at":"2014-10-30T21:42:31Z","git_url":"git://github.com/abhgupta/origin.git","ssh_url":"git@github.com:abhgupta/origin.git","clone_url":"https://github.com/abhgupta/origin.git","svn_url":"https://github.com/abhgupta/origin","homepage":"https://openshift.github.io","size":11308,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"59df4c060d647d7f6bb227c33f0f0eef4783e527","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=2","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=2","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments/{number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2014-10-30T16:33:09Z","pushed_at":"2014-10-30T19:44:41Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"https://openshift.github.io","size":18900,"stargazers_count":133,"watchers_count":133,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":37,"forks":69,"open_issues":37,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/302"},"html":{"href":"https://github.com/openshift/origin/pull/302"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/302"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/fda3e6ce9f64cf7dfc399546165314b4c67eb916"}}}}