GitHub PullRequestReviewCommentEvent at 2014-04-08 14:18:35
Repository: openQA
Actor: lnussel
Payload: {"comment":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/11391489","id":11391489,"diff_hunk":"@@ -100,6 +100,7 @@ use FindBin;\n use Mojo::UserAgent;\n use Mojo::URL;\n use Carp;\n+use Sys::Hostname;","path":"script/worker","position":4,"original_position":4,"commit_id":"a1a958bb818828f3bc9c22816c8bf54d20d77480","original_commit_id":"a1a958bb818828f3bc9c22816c8bf54d20d77480","user":{"login":"lnussel","id":722232,"avatar_url":"https://avatars.githubusercontent.com/u/722232?","gravatar_id":"f9fb86af86ef66b34b610f49ebc61f39","url":"https://api.github.com/users/lnussel","html_url":"https://github.com/lnussel","followers_url":"https://api.github.com/users/lnussel/followers","following_url":"https://api.github.com/users/lnussel/following{/other_user}","gists_url":"https://api.github.com/users/lnussel/gists{/gist_id}","starred_url":"https://api.github.com/users/lnussel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnussel/subscriptions","organizations_url":"https://api.github.com/users/lnussel/orgs","repos_url":"https://api.github.com/users/lnussel/repos","events_url":"https://api.github.com/users/lnussel/events{/privacy}","received_events_url":"https://api.github.com/users/lnussel/received_events","type":"User","site_admin":false},"body":"I think this module is bad as it tries to call gethostbyname in some circumstances which is evil as it causes a dns lookup. we should use localhost if nothing is configured and not try to be smart","created_at":"2014-04-08T14:18:35Z","updated_at":"2014-04-08T14:18:35Z","html_url":"https://github.com/os-autoinst/openQA/pull/20#discussion_r11391489","pull_request_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/11391489"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/20#discussion_r11391489"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/20"}}}}