GitHub PullRequestReviewCommentEvent at 2014-02-10 18:44:15
Repository: picongpu
Actor: ax3l
Payload: {"comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/9596039","id":9596039,"diff_hunk":"@@ -385,11 +385,9 @@ class HDF5Writer : public ISimulationIO, public IPluginModule\n \n     void moduleUnload()\n     {\n-        if (mThreadParams.dataCollector != NULL)\n-        {\n-            delete mThreadParams.dataCollector;\n-            mThreadParams.dataCollector = NULL;\n-        }\n+        if (notifyFrequency > 0)\n+            if (mThreadParams.dataCollector != NULL)\n+                __delete(mThreadParams.dataCollector);","path":"src/picongpu/include/plugins/hdf5/HDF5Writer.hpp","position":35,"original_position":35,"commit_id":"f22b488d0098d858497c6309d183284725e1a1fe","original_commit_id":"f22b488d0098d858497c6309d183284725e1a1fe","user":{"login":"ax3l","id":1353258,"avatar_url":"https://gravatar.com/avatar/4e90f994fc8dcf8d280b6e104b07ec8d?d=https%3A%2F%2Fidenticons.github.com%2F8c363341cbd3c8b18bf75304b7ab1f4b.png&r=x","gravatar_id":"4e90f994fc8dcf8d280b6e104b07ec8d","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"expected that :)\r\n`if(ptr) ...`","created_at":"2014-02-10T18:44:15Z","updated_at":"2014-02-10T18:44:15Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/191#discussion_r9596039","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/9596039"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/191#discussion_r9596039"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/191"}}}}