GitHub PullRequestReviewCommentEvent at 2014-07-15 18:22:28
Repository: FloatingAction
Actor: eveliotc
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/telly/FloatingAction/pulls/comments/14953447","id":14953447,"diff_hunk":"@@ -153,7 +158,7 @@ public void reset() {\n     private int mTargetParentId = android.R.id.content;\n     private AbsListView mAbsListView;\n     private int mIconColor = 0xff139eff;\n-    private TimeInterpolator mInterpolator;\n+    private AccelerateDecelerateInterpolator mInterpolator;","path":"library/src/main/java/com/telly/floatingaction/FloatingAction.java","position":43,"original_position":43,"commit_id":"4fa6a041b1d5060a44edc1c0dfce38e9db307234","original_commit_id":"4fa6a041b1d5060a44edc1c0dfce38e9db307234","user":{"login":"eveliotc","id":400641,"avatar_url":"https://avatars.githubusercontent.com/u/400641?","gravatar_id":"d4f909e9619c6295cc268fe7ae3a2255","url":"https://api.github.com/users/eveliotc","html_url":"https://github.com/eveliotc","followers_url":"https://api.github.com/users/eveliotc/followers","following_url":"https://api.github.com/users/eveliotc/following{/other_user}","gists_url":"https://api.github.com/users/eveliotc/gists{/gist_id}","starred_url":"https://api.github.com/users/eveliotc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eveliotc/subscriptions","organizations_url":"https://api.github.com/users/eveliotc/orgs","repos_url":"https://api.github.com/users/eveliotc/repos","events_url":"https://api.github.com/users/eveliotc/events{/privacy}","received_events_url":"https://api.github.com/users/eveliotc/received_events","type":"User","site_admin":false},"body":"It would make more sense if it were `Interpolator` so not necessarily is just `AccelerateDecelerate`","created_at":"2014-07-15T18:22:28Z","updated_at":"2014-07-15T18:22:28Z","html_url":"https://github.com/telly/FloatingAction/pull/3#discussion_r14953447","pull_request_url":"https://api.github.com/repos/telly/FloatingAction/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/telly/FloatingAction/pulls/comments/14953447"},"html":{"href":"https://github.com/telly/FloatingAction/pull/3#discussion_r14953447"},"pull_request":{"href":"https://api.github.com/repos/telly/FloatingAction/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/telly/FloatingAction/pulls/3","id":18388844,"html_url":"https://github.com/telly/FloatingAction/pull/3","diff_url":"https://github.com/telly/FloatingAction/pull/3.diff","patch_url":"https://github.com/telly/FloatingAction/pull/3.patch","issue_url":"https://api.github.com/repos/telly/FloatingAction/issues/3","number":3,"state":"open","title":"Add nineoldandroids to support Android version 2.3.3(SDK 10) and above","user":{"login":"sHa92","id":772338,"avatar_url":"https://avatars.githubusercontent.com/u/772338?","gravatar_id":"be58cde47eecdf076b7503d4e7212a8d","url":"https://api.github.com/users/sHa92","html_url":"https://github.com/sHa92","followers_url":"https://api.github.com/users/sHa92/followers","following_url":"https://api.github.com/users/sHa92/following{/other_user}","gists_url":"https://api.github.com/users/sHa92/gists{/gist_id}","starred_url":"https://api.github.com/users/sHa92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sHa92/subscriptions","organizations_url":"https://api.github.com/users/sHa92/orgs","repos_url":"https://api.github.com/users/sHa92/repos","events_url":"https://api.github.com/users/sHa92/events{/privacy}","received_events_url":"https://api.github.com/users/sHa92/received_events","type":"User","site_admin":false},"body":"I am not sure you want to support android 2.3 versions or not but here is my PR. :smile:\r\n\r\nCheers,\r\nSH","created_at":"2014-07-15T05:00:30Z","updated_at":"2014-07-15T18:22:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f07717d7df334d06ab193c7a8c3aa83aca5deea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/telly/FloatingAction/pulls/3/commits","review_comments_url":"https://api.github.com/repos/telly/FloatingAction/pulls/3/comments","review_comment_url":"https://api.github.com/repos/telly/FloatingAction/pulls/comments/{number}","comments_url":"https://api.github.com/repos/telly/FloatingAction/issues/3/comments","statuses_url":"https://api.github.com/repos/telly/FloatingAction/statuses/4fa6a041b1d5060a44edc1c0dfce38e9db307234","head":{"label":"sHa92:master","ref":"master","sha":"4fa6a041b1d5060a44edc1c0dfce38e9db307234","user":{"login":"sHa92","id":772338,"avatar_url":"https://avatars.githubusercontent.com/u/772338?","gravatar_id":"be58cde47eecdf076b7503d4e7212a8d","url":"https://api.github.com/users/sHa92","html_url":"https://github.com/sHa92","followers_url":"https://api.github.com/users/sHa92/followers","following_url":"https://api.github.com/users/sHa92/following{/other_user}","gists_url":"https://api.github.com/users/sHa92/gists{/gist_id}","starred_url":"https://api.github.com/users/sHa92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sHa92/subscriptions","organizations_url":"https://api.github.com/users/sHa92/orgs","repos_url":"https://api.github.com/users/sHa92/repos","events_url":"https://api.github.com/users/sHa92/events{/privacy}","received_events_url":"https://api.github.com/users/sHa92/received_events","type":"User","site_admin":false},"repo":{"id":21845073,"name":"FloatingAction","full_name":"sHa92/FloatingAction","owner":{"login":"sHa92","id":772338,"avatar_url":"https://avatars.githubusercontent.com/u/772338?","gravatar_id":"be58cde47eecdf076b7503d4e7212a8d","url":"https://api.github.com/users/sHa92","html_url":"https://github.com/sHa92","followers_url":"https://api.github.com/users/sHa92/followers","following_url":"https://api.github.com/users/sHa92/following{/other_user}","gists_url":"https://api.github.com/users/sHa92/gists{/gist_id}","starred_url":"https://api.github.com/users/sHa92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sHa92/subscriptions","organizations_url":"https://api.github.com/users/sHa92/orgs","repos_url":"https://api.github.com/users/sHa92/repos","events_url":"https://api.github.com/users/sHa92/events{/privacy}","received_events_url":"https://api.github.com/users/sHa92/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sHa92/FloatingAction","description":"A basic implementation of Floating Action pattern","fork":true,"url":"https://api.github.com/repos/sHa92/FloatingAction","forks_url":"https://api.github.com/repos/sHa92/FloatingAction/forks","keys_url":"https://api.github.com/repos/sHa92/FloatingAction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sHa92/FloatingAction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sHa92/FloatingAction/teams","hooks_url":"https://api.github.com/repos/sHa92/FloatingAction/hooks","issue_events_url":"https://api.github.com/repos/sHa92/FloatingAction/issues/events{/number}","events_url":"https://api.github.com/repos/sHa92/FloatingAction/events","assignees_url":"https://api.github.com/repos/sHa92/FloatingAction/assignees{/user}","branches_url":"https://api.github.com/repos/sHa92/FloatingAction/branches{/branch}","tags_url":"https://api.github.com/repos/sHa92/FloatingAction/tags","blobs_url":"https://api.github.com/repos/sHa92/FloatingAction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sHa92/FloatingAction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sHa92/FloatingAction/git/refs{/sha}","trees_url":"https://api.github.com/repos/sHa92/FloatingAction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sHa92/FloatingAction/statuses/{sha}","languages_url":"https://api.github.com/repos/sHa92/FloatingAction/languages","stargazers_url":"https://api.github.com/repos/sHa92/FloatingAction/stargazers","contributors_url":"https://api.github.com/repos/sHa92/FloatingAction/contributors","subscribers_url":"https://api.github.com/repos/sHa92/FloatingAction/subscribers","subscription_url":"https://api.github.com/repos/sHa92/FloatingAction/subscription","commits_url":"https://api.github.com/repos/sHa92/FloatingAction/commits{/sha}","git_commits_url":"https://api.github.com/repos/sHa92/FloatingAction/git/commits{/sha}","comments_url":"https://api.github.com/repos/sHa92/FloatingAction/comments{/number}","issue_comment_url":"https://api.github.com/repos/sHa92/FloatingAction/issues/comments/{number}","contents_url":"https://api.github.com/repos/sHa92/FloatingAction/contents/{+path}","compare_url":"https://api.github.com/repos/sHa92/FloatingAction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sHa92/FloatingAction/merges","archive_url":"https://api.github.com/repos/sHa92/FloatingAction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sHa92/FloatingAction/downloads","issues_url":"https://api.github.com/repos/sHa92/FloatingAction/issues{/number}","pulls_url":"https://api.github.com/repos/sHa92/FloatingAction/pulls{/number}","milestones_url":"https://api.github.com/repos/sHa92/FloatingAction/milestones{/number}","notifications_url":"https://api.github.com/repos/sHa92/FloatingAction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sHa92/FloatingAction/labels{/name}","releases_url":"https://api.github.com/repos/sHa92/FloatingAction/releases{/id}","created_at":"2014-07-15T03:35:03Z","updated_at":"2014-07-15T04:57:41Z","pushed_at":"2014-07-15T04:57:41Z","git_url":"git://github.com/sHa92/FloatingAction.git","ssh_url":"git@github.com:sHa92/FloatingAction.git","clone_url":"https://github.com/sHa92/FloatingAction.git","svn_url":"https://github.com/sHa92/FloatingAction","homepage":"","size":374,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"telly:master","ref":"master","sha":"d3715a9d20264e98d5ee26df3ef6724c9380b135","user":{"login":"telly","id":3802095,"avatar_url":"https://avatars.githubusercontent.com/u/3802095?","gravatar_id":"b6a8038c401029bdf764c7686bdded8d","url":"https://api.github.com/users/telly","html_url":"https://github.com/telly","followers_url":"https://api.github.com/users/telly/followers","following_url":"https://api.github.com/users/telly/following{/other_user}","gists_url":"https://api.github.com/users/telly/gists{/gist_id}","starred_url":"https://api.github.com/users/telly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telly/subscriptions","organizations_url":"https://api.github.com/users/telly/orgs","repos_url":"https://api.github.com/users/telly/repos","events_url":"https://api.github.com/users/telly/events{/privacy}","received_events_url":"https://api.github.com/users/telly/received_events","type":"Organization","site_admin":false},"repo":{"id":21148162,"name":"FloatingAction","full_name":"telly/FloatingAction","owner":{"login":"telly","id":3802095,"avatar_url":"https://avatars.githubusercontent.com/u/3802095?","gravatar_id":"b6a8038c401029bdf764c7686bdded8d","url":"https://api.github.com/users/telly","html_url":"https://github.com/telly","followers_url":"https://api.github.com/users/telly/followers","following_url":"https://api.github.com/users/telly/following{/other_user}","gists_url":"https://api.github.com/users/telly/gists{/gist_id}","starred_url":"https://api.github.com/users/telly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telly/subscriptions","organizations_url":"https://api.github.com/users/telly/orgs","repos_url":"https://api.github.com/users/telly/repos","events_url":"https://api.github.com/users/telly/events{/privacy}","received_events_url":"https://api.github.com/users/telly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telly/FloatingAction","description":"A basic implementation of Floating Action pattern","fork":false,"url":"https://api.github.com/repos/telly/FloatingAction","forks_url":"https://api.github.com/repos/telly/FloatingAction/forks","keys_url":"https://api.github.com/repos/telly/FloatingAction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telly/FloatingAction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telly/FloatingAction/teams","hooks_url":"https://api.github.com/repos/telly/FloatingAction/hooks","issue_events_url":"https://api.github.com/repos/telly/FloatingAction/issues/events{/number}","events_url":"https://api.github.com/repos/telly/FloatingAction/events","assignees_url":"https://api.github.com/repos/telly/FloatingAction/assignees{/user}","branches_url":"https://api.github.com/repos/telly/FloatingAction/branches{/branch}","tags_url":"https://api.github.com/repos/telly/FloatingAction/tags","blobs_url":"https://api.github.com/repos/telly/FloatingAction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telly/FloatingAction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telly/FloatingAction/git/refs{/sha}","trees_url":"https://api.github.com/repos/telly/FloatingAction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telly/FloatingAction/statuses/{sha}","languages_url":"https://api.github.com/repos/telly/FloatingAction/languages","stargazers_url":"https://api.github.com/repos/telly/FloatingAction/stargazers","contributors_url":"https://api.github.com/repos/telly/FloatingAction/contributors","subscribers_url":"https://api.github.com/repos/telly/FloatingAction/subscribers","subscription_url":"https://api.github.com/repos/telly/FloatingAction/subscription","commits_url":"https://api.github.com/repos/telly/FloatingAction/commits{/sha}","git_commits_url":"https://api.github.com/repos/telly/FloatingAction/git/commits{/sha}","comments_url":"https://api.github.com/repos/telly/FloatingAction/comments{/number}","issue_comment_url":"https://api.github.com/repos/telly/FloatingAction/issues/comments/{number}","contents_url":"https://api.github.com/repos/telly/FloatingAction/contents/{+path}","compare_url":"https://api.github.com/repos/telly/FloatingAction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telly/FloatingAction/merges","archive_url":"https://api.github.com/repos/telly/FloatingAction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telly/FloatingAction/downloads","issues_url":"https://api.github.com/repos/telly/FloatingAction/issues{/number}","pulls_url":"https://api.github.com/repos/telly/FloatingAction/pulls{/number}","milestones_url":"https://api.github.com/repos/telly/FloatingAction/milestones{/number}","notifications_url":"https://api.github.com/repos/telly/FloatingAction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telly/FloatingAction/labels{/name}","releases_url":"https://api.github.com/repos/telly/FloatingAction/releases{/id}","created_at":"2014-06-24T01:27:10Z","updated_at":"2014-07-15T14:27:03Z","pushed_at":"2014-07-04T01:08:23Z","git_url":"git://github.com/telly/FloatingAction.git","ssh_url":"git@github.com:telly/FloatingAction.git","clone_url":"https://github.com/telly/FloatingAction.git","svn_url":"https://github.com/telly/FloatingAction","homepage":"","size":431,"stargazers_count":147,"watchers_count":147,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":11,"mirror_url":null,"open_issues_count":1,"forks":11,"open_issues":1,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/telly/FloatingAction/pulls/3"},"html":{"href":"https://github.com/telly/FloatingAction/pull/3"},"issue":{"href":"https://api.github.com/repos/telly/FloatingAction/issues/3"},"comments":{"href":"https://api.github.com/repos/telly/FloatingAction/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/telly/FloatingAction/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/telly/FloatingAction/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/telly/FloatingAction/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/telly/FloatingAction/statuses/4fa6a041b1d5060a44edc1c0dfce38e9db307234"}}}}