GitHub PullRequestReviewCommentEvent at 2014-12-03 12:48:27
Repository: perun
Actor: licehammer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/CESNET/perun/pulls/comments/21228873","id":21228873,"diff_hunk":"@@ -1753,8 +1753,23 @@ public void saveInformationAboutGroupSynchronization(PerunSession sess, Group gr\n \t\tAttribute lastSynchronizationState = new Attribute(((PerunBl) sess.getPerun()).getAttributesManagerBl().getAttributeDefinition(sess, AttributesManager.NS_GROUP_ATTR_DEF + \":lastSynchronizationState\"));\n \t\tlastSynchronizationTimestamp.setValue(currectTimestampString);\n \t\tlastSynchronizationState.setValue(exceptionMessage);\n-\t\t//setAttributes for group\n+\n+\t\t//attributes to set\n \t\tList<Attribute> attrsToSet = new ArrayList<>();\n+\n+\t\t//Set lastSuccessSynchronzationTimestamp if this one is success\n+\t\tif(exceptionMessage.equals(\"OK\")) {","path":"perun-core/src/main/java/cz/metacentrum/perun/core/blImpl/GroupsManagerBlImpl.java","position":10,"original_position":10,"commit_id":"b61c8ada72b541af722abc5ebc3f74c86ebc64d0","original_commit_id":"b61c8ada72b541af722abc5ebc3f74c86ebc64d0","user":{"login":"licehammer","id":3735955,"avatar_url":"https://avatars.githubusercontent.com/u/3735955?v=3","gravatar_id":"","url":"https://api.github.com/users/licehammer","html_url":"https://github.com/licehammer","followers_url":"https://api.github.com/users/licehammer/followers","following_url":"https://api.github.com/users/licehammer/following{/other_user}","gists_url":"https://api.github.com/users/licehammer/gists{/gist_id}","starred_url":"https://api.github.com/users/licehammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/licehammer/subscriptions","organizations_url":"https://api.github.com/users/licehammer/orgs","repos_url":"https://api.github.com/users/licehammer/repos","events_url":"https://api.github.com/users/licehammer/events{/privacy}","received_events_url":"https://api.github.com/users/licehammer/received_events","type":"User","site_admin":false},"body":"Communication based on fixed strings is evil. The same string hard-coded on multiple places is evil even more.","created_at":"2014-12-03T12:48:27Z","updated_at":"2014-12-03T12:48:27Z","html_url":"https://github.com/CESNET/perun/pull/603#discussion_r21228873","pull_request_url":"https://api.github.com/repos/CESNET/perun/pulls/603","_links":{"self":{"href":"https://api.github.com/repos/CESNET/perun/pulls/comments/21228873"},"html":{"href":"https://github.com/CESNET/perun/pull/603#discussion_r21228873"},"pull_request":{"href":"https://api.github.com/repos/CESNET/perun/pulls/603"}}},"pull_request":{"url":"https://api.github.com/repos/CESNET/perun/pulls/603","id":25408970,"html_url":"https://github.com/CESNET/perun/pull/603","diff_url":"https://github.com/CESNET/perun/pull/603.diff","patch_url":"https://github.com/CESNET/perun/pull/603.patch","issue_url":"https://api.github.com/repos/CESNET/perun/issues/603","number":603,"state":"open","locked":false,"title":"Set LastSuccessSynchronization timetamp when synchronize groups","user":{"login":"stavamichal","id":5602147,"avatar_url":"https://avatars.githubusercontent.com/u/5602147?v=3","gravatar_id":"","url":"https://api.github.com/users/stavamichal","html_url":"https://github.com/stavamichal","followers_url":"https://api.github.com/users/stavamichal/followers","following_url":"https://api.github.com/users/stavamichal/following{/other_user}","gists_url":"https://api.github.com/users/stavamichal/gists{/gist_id}","starred_url":"https://api.github.com/users/stavamichal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stavamichal/subscriptions","organizations_url":"https://api.github.com/users/stavamichal/orgs","repos_url":"https://api.github.com/users/stavamichal/repos","events_url":"https://api.github.com/users/stavamichal/events{/privacy}","received_events_url":"https://api.github.com/users/stavamichal/received_events","type":"User","site_admin":false},"body":" - new attribute group_def_lastSuccessSynchronizationTimestamp which is\r\n   set only when exception message is equal to \"OK\". OK means that no\r\n   exceptio was thrown in the middle of synchronization.\r\n - if this attribute definition is not exists, only log this to\r\n   log.error\r\n\r\n NEED TO BE DONE BEFORE MERGE:\r\n  - should create new attribute:\r\n   - String, group_def_lastSuccessSynchronizationTimestamp\r\n  - add information about new attribute to changelog","created_at":"2014-12-03T10:33:09Z","updated_at":"2014-12-03T12:48:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87494318681cb43524443ef45601f9bc3ad7545e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CESNET/perun/pulls/603/commits","review_comments_url":"https://api.github.com/repos/CESNET/perun/pulls/603/comments","review_comment_url":"https://api.github.com/repos/CESNET/perun/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CESNET/perun/issues/603/comments","statuses_url":"https://api.github.com/repos/CESNET/perun/statuses/b61c8ada72b541af722abc5ebc3f74c86ebc64d0","head":{"label":"stavamichal:setLastSuccessSynchronizationTimestamp","ref":"setLastSuccessSynchronizationTimestamp","sha":"b61c8ada72b541af722abc5ebc3f74c86ebc64d0","user":{"login":"stavamichal","id":5602147,"avatar_url":"https://avatars.githubusercontent.com/u/5602147?v=3","gravatar_id":"","url":"https://api.github.com/users/stavamichal","html_url":"https://github.com/stavamichal","followers_url":"https://api.github.com/users/stavamichal/followers","following_url":"https://api.github.com/users/stavamichal/following{/other_user}","gists_url":"https://api.github.com/users/stavamichal/gists{/gist_id}","starred_url":"https://api.github.com/users/stavamichal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stavamichal/subscriptions","organizations_url":"https://api.github.com/users/stavamichal/orgs","repos_url":"https://api.github.com/users/stavamichal/repos","events_url":"https://api.github.com/users/stavamichal/events{/privacy}","received_events_url":"https://api.github.com/users/stavamichal/received_events","type":"User","site_admin":false},"repo":{"id":13856179,"name":"perun","full_name":"stavamichal/perun","owner":{"login":"stavamichal","id":5602147,"avatar_url":"https://avatars.githubusercontent.com/u/5602147?v=3","gravatar_id":"","url":"https://api.github.com/users/stavamichal","html_url":"https://github.com/stavamichal","followers_url":"https://api.github.com/users/stavamichal/followers","following_url":"https://api.github.com/users/stavamichal/following{/other_user}","gists_url":"https://api.github.com/users/stavamichal/gists{/gist_id}","starred_url":"https://api.github.com/users/stavamichal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stavamichal/subscriptions","organizations_url":"https://api.github.com/users/stavamichal/orgs","repos_url":"https://api.github.com/users/stavamichal/repos","events_url":"https://api.github.com/users/stavamichal/events{/privacy}","received_events_url":"https://api.github.com/users/stavamichal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stavamichal/perun","description":"Users, Groups, Services and Resources Management System","fork":true,"url":"https://api.github.com/repos/stavamichal/perun","forks_url":"https://api.github.com/repos/stavamichal/perun/forks","keys_url":"https://api.github.com/repos/stavamichal/perun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stavamichal/perun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stavamichal/perun/teams","hooks_url":"https://api.github.com/repos/stavamichal/perun/hooks","issue_events_url":"https://api.github.com/repos/stavamichal/perun/issues/events{/number}","events_url":"https://api.github.com/repos/stavamichal/perun/events","assignees_url":"https://api.github.com/repos/stavamichal/perun/assignees{/user}","branches_url":"https://api.github.com/repos/stavamichal/perun/branches{/branch}","tags_url":"https://api.github.com/repos/stavamichal/perun/tags","blobs_url":"https://api.github.com/repos/stavamichal/perun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stavamichal/perun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stavamichal/perun/git/refs{/sha}","trees_url":"https://api.github.com/repos/stavamichal/perun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stavamichal/perun/statuses/{sha}","languages_url":"https://api.github.com/repos/stavamichal/perun/languages","stargazers_url":"https://api.github.com/repos/stavamichal/perun/stargazers","contributors_url":"https://api.github.com/repos/stavamichal/perun/contributors","subscribers_url":"https://api.github.com/repos/stavamichal/perun/subscribers","subscription_url":"https://api.github.com/repos/stavamichal/perun/subscription","commits_url":"https://api.github.com/repos/stavamichal/perun/commits{/sha}","git_commits_url":"https://api.github.com/repos/stavamichal/perun/git/commits{/sha}","comments_url":"https://api.github.com/repos/stavamichal/perun/comments{/number}","issue_comment_url":"https://api.github.com/repos/stavamichal/perun/issues/comments/{number}","contents_url":"https://api.github.com/repos/stavamichal/perun/contents/{+path}","compare_url":"https://api.github.com/repos/stavamichal/perun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stavamichal/perun/merges","archive_url":"https://api.github.com/repos/stavamichal/perun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stavamichal/perun/downloads","issues_url":"https://api.github.com/repos/stavamichal/perun/issues{/number}","pulls_url":"https://api.github.com/repos/stavamichal/perun/pulls{/number}","milestones_url":"https://api.github.com/repos/stavamichal/perun/milestones{/number}","notifications_url":"https://api.github.com/repos/stavamichal/perun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stavamichal/perun/labels{/name}","releases_url":"https://api.github.com/repos/stavamichal/perun/releases{/id}","created_at":"2013-10-25T09:05:49Z","updated_at":"2014-12-01T08:25:06Z","pushed_at":"2014-12-03T10:32:26Z","git_url":"git://github.com/stavamichal/perun.git","ssh_url":"git@github.com:stavamichal/perun.git","clone_url":"https://github.com/stavamichal/perun.git","svn_url":"https://github.com/stavamichal/perun","homepage":null,"size":24653,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CESNET:master","ref":"master","sha":"3e32582f9276c6233be485acea77de3ead8ee388","user":{"login":"CESNET","id":1116469,"avatar_url":"https://avatars.githubusercontent.com/u/1116469?v=3","gravatar_id":"","url":"https://api.github.com/users/CESNET","html_url":"https://github.com/CESNET","followers_url":"https://api.github.com/users/CESNET/followers","following_url":"https://api.github.com/users/CESNET/following{/other_user}","gists_url":"https://api.github.com/users/CESNET/gists{/gist_id}","starred_url":"https://api.github.com/users/CESNET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESNET/subscriptions","organizations_url":"https://api.github.com/users/CESNET/orgs","repos_url":"https://api.github.com/users/CESNET/repos","events_url":"https://api.github.com/users/CESNET/events{/privacy}","received_events_url":"https://api.github.com/users/CESNET/received_events","type":"Organization","site_admin":false},"repo":{"id":4085998,"name":"perun","full_name":"CESNET/perun","owner":{"login":"CESNET","id":1116469,"avatar_url":"https://avatars.githubusercontent.com/u/1116469?v=3","gravatar_id":"","url":"https://api.github.com/users/CESNET","html_url":"https://github.com/CESNET","followers_url":"https://api.github.com/users/CESNET/followers","following_url":"https://api.github.com/users/CESNET/following{/other_user}","gists_url":"https://api.github.com/users/CESNET/gists{/gist_id}","starred_url":"https://api.github.com/users/CESNET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESNET/subscriptions","organizations_url":"https://api.github.com/users/CESNET/orgs","repos_url":"https://api.github.com/users/CESNET/repos","events_url":"https://api.github.com/users/CESNET/events{/privacy}","received_events_url":"https://api.github.com/users/CESNET/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CESNET/perun","description":"Identity and Access Management System","fork":false,"url":"https://api.github.com/repos/CESNET/perun","forks_url":"https://api.github.com/repos/CESNET/perun/forks","keys_url":"https://api.github.com/repos/CESNET/perun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CESNET/perun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CESNET/perun/teams","hooks_url":"https://api.github.com/repos/CESNET/perun/hooks","issue_events_url":"https://api.github.com/repos/CESNET/perun/issues/events{/number}","events_url":"https://api.github.com/repos/CESNET/perun/events","assignees_url":"https://api.github.com/repos/CESNET/perun/assignees{/user}","branches_url":"https://api.github.com/repos/CESNET/perun/branches{/branch}","tags_url":"https://api.github.com/repos/CESNET/perun/tags","blobs_url":"https://api.github.com/repos/CESNET/perun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CESNET/perun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CESNET/perun/git/refs{/sha}","trees_url":"https://api.github.com/repos/CESNET/perun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CESNET/perun/statuses/{sha}","languages_url":"https://api.github.com/repos/CESNET/perun/languages","stargazers_url":"https://api.github.com/repos/CESNET/perun/stargazers","contributors_url":"https://api.github.com/repos/CESNET/perun/contributors","subscribers_url":"https://api.github.com/repos/CESNET/perun/subscribers","subscription_url":"https://api.github.com/repos/CESNET/perun/subscription","commits_url":"https://api.github.com/repos/CESNET/perun/commits{/sha}","git_commits_url":"https://api.github.com/repos/CESNET/perun/git/commits{/sha}","comments_url":"https://api.github.com/repos/CESNET/perun/comments{/number}","issue_comment_url":"https://api.github.com/repos/CESNET/perun/issues/comments/{number}","contents_url":"https://api.github.com/repos/CESNET/perun/contents/{+path}","compare_url":"https://api.github.com/repos/CESNET/perun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CESNET/perun/merges","archive_url":"https://api.github.com/repos/CESNET/perun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CESNET/perun/downloads","issues_url":"https://api.github.com/repos/CESNET/perun/issues{/number}","pulls_url":"https://api.github.com/repos/CESNET/perun/pulls{/number}","milestones_url":"https://api.github.com/repos/CESNET/perun/milestones{/number}","notifications_url":"https://api.github.com/repos/CESNET/perun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CESNET/perun/labels{/name}","releases_url":"https://api.github.com/repos/CESNET/perun/releases{/id}","created_at":"2012-04-20T11:55:38Z","updated_at":"2014-12-02T11:24:26Z","pushed_at":"2014-12-02T11:26:01Z","git_url":"git://github.com/CESNET/perun.git","ssh_url":"git@github.com:CESNET/perun.git","clone_url":"https://github.com/CESNET/perun.git","svn_url":"https://github.com/CESNET/perun","homepage":"http://perun.cesnet.cz","size":32116,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":11,"forks":18,"open_issues":11,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CESNET/perun/pulls/603"},"html":{"href":"https://github.com/CESNET/perun/pull/603"},"issue":{"href":"https://api.github.com/repos/CESNET/perun/issues/603"},"comments":{"href":"https://api.github.com/repos/CESNET/perun/issues/603/comments"},"review_comments":{"href":"https://api.github.com/repos/CESNET/perun/pulls/603/comments"},"review_comment":{"href":"https://api.github.com/repos/CESNET/perun/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CESNET/perun/pulls/603/commits"},"statuses":{"href":"https://api.github.com/repos/CESNET/perun/statuses/b61c8ada72b541af722abc5ebc3f74c86ebc64d0"}}}}