GitHub PullRequestReviewCommentEvent at 2014-08-27 06:44:33
Repository: tp-libvirt
Actor: rbian
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments/16759847","id":16759847,"diff_hunk":"@@ -122,9 +130,9 @@ def run(test, params, env):\n \n         # See comment above regarding Raw images\n         if image_format == \"raw\" and resize_value[-2] in \"kb\":\n-            if int(actual_size) > int(expected_size):\n-                raise error.TestFail(\"New raw blocksize set by blockresize is \"\n-                                     \"larger than the expected value\")\n+            if abs(int(actual_size) - int(expected_size)) > 512:\n+                raise error.TestFail(\"New raw blocksize set by blockresize do \"\n+                                     \"not match the expected value\")","path":"libvirt/tests/src/virsh_cmd/domain/virsh_blockresize.py","position":40,"original_position":40,"commit_id":"0a987cbb19d52b8a9a8d2109894b01a874b1e802","original_commit_id":"0a987cbb19d52b8a9a8d2109894b01a874b1e802","user":{"login":"rbian","id":7511534,"avatar_url":"https://avatars.githubusercontent.com/u/7511534?v=2","gravatar_id":"7484b9e8df12168b312b72d304a30d56","url":"https://api.github.com/users/rbian","html_url":"https://github.com/rbian","followers_url":"https://api.github.com/users/rbian/followers","following_url":"https://api.github.com/users/rbian/following{/other_user}","gists_url":"https://api.github.com/users/rbian/gists{/gist_id}","starred_url":"https://api.github.com/users/rbian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbian/subscriptions","organizations_url":"https://api.github.com/users/rbian/orgs","repos_url":"https://api.github.com/users/rbian/repos","events_url":"https://api.github.com/users/rbian/events{/privacy}","received_events_url":"https://api.github.com/users/rbian/received_events","type":"User","site_admin":false},"body":"Why do you use abs to check blocksize? Expected size should less than actual size, otherwise it will be fail for blockresize command.","created_at":"2014-08-27T06:44:33Z","updated_at":"2014-08-27T06:44:33Z","html_url":"https://github.com/autotest/tp-libvirt/pull/284#discussion_r16759847","pull_request_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/284","_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments/16759847"},"html":{"href":"https://github.com/autotest/tp-libvirt/pull/284#discussion_r16759847"},"pull_request":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/284","id":19591817,"html_url":"https://github.com/autotest/tp-libvirt/pull/284","diff_url":"https://github.com/autotest/tp-libvirt/pull/284.diff","patch_url":"https://github.com/autotest/tp-libvirt/pull/284.patch","issue_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/284","number":284,"state":"open","locked":false,"title":"blockresize: Skip the qed test if not supported.","user":{"login":"Hao-Liu","id":5862133,"avatar_url":"https://avatars.githubusercontent.com/u/5862133?v=2","gravatar_id":"4a0e4ad633a46390743a179433d2906b","url":"https://api.github.com/users/Hao-Liu","html_url":"https://github.com/Hao-Liu","followers_url":"https://api.github.com/users/Hao-Liu/followers","following_url":"https://api.github.com/users/Hao-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Hao-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Hao-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hao-Liu/subscriptions","organizations_url":"https://api.github.com/users/Hao-Liu/orgs","repos_url":"https://api.github.com/users/Hao-Liu/repos","events_url":"https://api.github.com/users/Hao-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Hao-Liu/received_events","type":"User","site_admin":false},"body":"1) Skip the qed test for newer libvirt who don't support this format.\r\n\r\n2) Fix raw checking math to fix an error.\r\n\r\nSigned-off-by: Hao Liu <hliu@redhat.com>","created_at":"2014-08-11T09:58:35Z","updated_at":"2014-08-27T06:44:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"337b63f83597c8f2c936b442b939f6f0e3d6b65c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/284/commits","review_comments_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/284/comments","review_comment_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments/{number}","comments_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/284/comments","statuses_url":"https://api.github.com/repos/autotest/tp-libvirt/statuses/0a987cbb19d52b8a9a8d2109894b01a874b1e802","head":{"label":"Hao-Liu:fix_blockresize","ref":"fix_blockresize","sha":"0a987cbb19d52b8a9a8d2109894b01a874b1e802","user":{"login":"Hao-Liu","id":5862133,"avatar_url":"https://avatars.githubusercontent.com/u/5862133?v=2","gravatar_id":"4a0e4ad633a46390743a179433d2906b","url":"https://api.github.com/users/Hao-Liu","html_url":"https://github.com/Hao-Liu","followers_url":"https://api.github.com/users/Hao-Liu/followers","following_url":"https://api.github.com/users/Hao-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Hao-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Hao-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hao-Liu/subscriptions","organizations_url":"https://api.github.com/users/Hao-Liu/orgs","repos_url":"https://api.github.com/users/Hao-Liu/repos","events_url":"https://api.github.com/users/Hao-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Hao-Liu/received_events","type":"User","site_admin":false},"repo":{"id":16938323,"name":"tp-libvirt","full_name":"Hao-Liu/tp-libvirt","owner":{"login":"Hao-Liu","id":5862133,"avatar_url":"https://avatars.githubusercontent.com/u/5862133?v=2","gravatar_id":"4a0e4ad633a46390743a179433d2906b","url":"https://api.github.com/users/Hao-Liu","html_url":"https://github.com/Hao-Liu","followers_url":"https://api.github.com/users/Hao-Liu/followers","following_url":"https://api.github.com/users/Hao-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Hao-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Hao-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hao-Liu/subscriptions","organizations_url":"https://api.github.com/users/Hao-Liu/orgs","repos_url":"https://api.github.com/users/Hao-Liu/repos","events_url":"https://api.github.com/users/Hao-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Hao-Liu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hao-Liu/tp-libvirt","description":"Test Provider for Libvirt and related virtualization backends","fork":true,"url":"https://api.github.com/repos/Hao-Liu/tp-libvirt","forks_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/forks","keys_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/teams","hooks_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/hooks","issue_events_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/issues/events{/number}","events_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/events","assignees_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/assignees{/user}","branches_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/branches{/branch}","tags_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/tags","blobs_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/statuses/{sha}","languages_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/languages","stargazers_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/stargazers","contributors_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/contributors","subscribers_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/subscribers","subscription_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/subscription","commits_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/issues/comments/{number}","contents_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/contents/{+path}","compare_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/merges","archive_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/downloads","issues_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/issues{/number}","pulls_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/pulls{/number}","milestones_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/milestones{/number}","notifications_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/labels{/name}","releases_url":"https://api.github.com/repos/Hao-Liu/tp-libvirt/releases{/id}","created_at":"2014-02-18T05:40:42Z","updated_at":"2014-06-09T11:21:14Z","pushed_at":"2014-08-27T06:08:52Z","git_url":"git://github.com/Hao-Liu/tp-libvirt.git","ssh_url":"git@github.com:Hao-Liu/tp-libvirt.git","clone_url":"https://github.com/Hao-Liu/tp-libvirt.git","svn_url":"https://github.com/Hao-Liu/tp-libvirt","homepage":null,"size":9198,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"3e51533c0751a25f5eb86892d4beed1f30bbd56d","user":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=2","gravatar_id":"276c864911264411989b6720fd80f611","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":16180517,"name":"tp-libvirt","full_name":"autotest/tp-libvirt","owner":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=2","gravatar_id":"276c864911264411989b6720fd80f611","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autotest/tp-libvirt","description":"Test Provider for Libvirt and related virtualization backends","fork":false,"url":"https://api.github.com/repos/autotest/tp-libvirt","forks_url":"https://api.github.com/repos/autotest/tp-libvirt/forks","keys_url":"https://api.github.com/repos/autotest/tp-libvirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/tp-libvirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/tp-libvirt/teams","hooks_url":"https://api.github.com/repos/autotest/tp-libvirt/hooks","issue_events_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/tp-libvirt/events","assignees_url":"https://api.github.com/repos/autotest/tp-libvirt/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/tp-libvirt/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/tp-libvirt/tags","blobs_url":"https://api.github.com/repos/autotest/tp-libvirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/tp-libvirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/tp-libvirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/tp-libvirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/tp-libvirt/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/tp-libvirt/languages","stargazers_url":"https://api.github.com/repos/autotest/tp-libvirt/stargazers","contributors_url":"https://api.github.com/repos/autotest/tp-libvirt/contributors","subscribers_url":"https://api.github.com/repos/autotest/tp-libvirt/subscribers","subscription_url":"https://api.github.com/repos/autotest/tp-libvirt/subscription","commits_url":"https://api.github.com/repos/autotest/tp-libvirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/tp-libvirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/tp-libvirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/comments/{number}","contents_url":"https://api.github.com/repos/autotest/tp-libvirt/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/tp-libvirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/tp-libvirt/merges","archive_url":"https://api.github.com/repos/autotest/tp-libvirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/tp-libvirt/downloads","issues_url":"https://api.github.com/repos/autotest/tp-libvirt/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/tp-libvirt/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/tp-libvirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/tp-libvirt/labels{/name}","releases_url":"https://api.github.com/repos/autotest/tp-libvirt/releases{/id}","created_at":"2014-01-23T17:58:18Z","updated_at":"2014-08-26T02:18:12Z","pushed_at":"2014-08-27T03:40:44Z","git_url":"git://github.com/autotest/tp-libvirt.git","ssh_url":"git@github.com:autotest/tp-libvirt.git","clone_url":"https://github.com/autotest/tp-libvirt.git","svn_url":"https://github.com/autotest/tp-libvirt","homepage":null,"size":15845,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":29,"mirror_url":null,"open_issues_count":35,"forks":29,"open_issues":35,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/284"},"html":{"href":"https://github.com/autotest/tp-libvirt/pull/284"},"issue":{"href":"https://api.github.com/repos/autotest/tp-libvirt/issues/284"},"comments":{"href":"https://api.github.com/repos/autotest/tp-libvirt/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/tp-libvirt/statuses/0a987cbb19d52b8a9a8d2109894b01a874b1e802"}}}}