GitHub PullRequestReviewCommentEvent at 2014-02-25 19:58:59
Repository: commcare-hq
Actor: czue
Payload: {"comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/10053039","id":10053039,"diff_hunk":"@@ -636,12 +636,20 @@ def get_subscribed_plan_by_domain(cls, domain):\n         \"\"\"\n         Returns SoftwarePlanVersion, Subscription for the given domain.\n         \"\"\"\n-        domain = assure_domain_instance(domain)\n+        domain_obj = assure_domain_instance(domain)\n+        if domain_obj is None:\n+            # need more info to troubleshoot this further\n+            logging.error(\"Tried to fetch a subscription for a domain that was not properly located. \"\n+                          \"Domain name is %s.\" % domain)","path":"corehq/apps/accounting/models.py","position":9,"original_position":9,"commit_id":"52c52cdc8b4757aec219c0e368bebddad34ce956","original_commit_id":"52c52cdc8b4757aec219c0e368bebddad34ce956","user":{"login":"czue","id":66555,"avatar_url":"https://gravatar.com/avatar/b379038e6658d2dc8b340c101299d7d6?d=https%3A%2F%2Fidenticons.github.com%2F209842984ab4a769e26da6d1ebbc3707.png&r=x","gravatar_id":"b379038e6658d2dc8b340c101299d7d6","url":"https://api.github.com/users/czue","html_url":"https://github.com/czue","followers_url":"https://api.github.com/users/czue/followers","following_url":"https://api.github.com/users/czue/following{/other_user}","gists_url":"https://api.github.com/users/czue/gists{/gist_id}","starred_url":"https://api.github.com/users/czue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czue/subscriptions","organizations_url":"https://api.github.com/users/czue/orgs","repos_url":"https://api.github.com/users/czue/repos","events_url":"https://api.github.com/users/czue/events{/privacy}","received_events_url":"https://api.github.com/users/czue/received_events","type":"User","site_admin":false},"body":"peanut gallery: might also be useful to include the user and url info in this","created_at":"2014-02-25T19:58:59Z","updated_at":"2014-02-25T19:58:59Z","html_url":"https://github.com/dimagi/commcare-hq/pull/2620#discussion_r10053039","pull_request_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/2620","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/10053039"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/2620#discussion_r10053039"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/2620"}}}}