GitHub PullRequestReviewCommentEvent at 2014-03-07 20:43:30
Repository: k
Actor: yilongli
Payload: {"comment":{"url":"https://api.github.com/repos/kframework/k/pulls/comments/10399060","id":10399060,"diff_hunk":"@@ -14,9 +14,16 @@ public KLabelIndex(KLabelConstant kLabel) {\n         this.kLabel = kLabel;\n     }\n \n+    public KLabelConstant kLabel() {\n+        return kLabel;\n+    }\n+    \n     @Override\n     public boolean isUnifiable(Index index) {\n-        return index instanceof TopIndex || equals(index);\n+        return index instanceof TopIndex\n+                || equals(index)\n+                || (index instanceof TokenIndex && \n+                        kLabel.sorts().contains(((TokenIndex) index).sort()));","path":"src/javasources/KTool/src/org/kframework/backend/java/indexing/KLabelIndex.java","position":14,"original_position":14,"commit_id":"d7378b33ccb4bf058dd50f270eb20c1fb736e534","original_commit_id":"d7378b33ccb4bf058dd50f270eb20c1fb736e534","user":{"login":"yilongli","id":4922997,"avatar_url":"https://gravatar.com/avatar/b154ba7baf95a7bbdd486d13d09c579c?d=https%3A%2F%2Fidenticons.github.com%2F5cb48135cbb53c38e9ea133cdda3daed.png&r=x","gravatar_id":"b154ba7baf95a7bbdd486d13d09c579c","url":"https://api.github.com/users/yilongli","html_url":"https://github.com/yilongli","followers_url":"https://api.github.com/users/yilongli/followers","following_url":"https://api.github.com/users/yilongli/following{/other_user}","gists_url":"https://api.github.com/users/yilongli/gists{/gist_id}","starred_url":"https://api.github.com/users/yilongli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yilongli/subscriptions","organizations_url":"https://api.github.com/users/yilongli/orgs","repos_url":"https://api.github.com/users/yilongli/repos","events_url":"https://api.github.com/users/yilongli/events{/privacy}","received_events_url":"https://api.github.com/users/yilongli/received_events","type":"User","site_admin":false},"body":"For now, it is just between TokenIndex and KLabelIndex. I am not sure what would be a better way to handle this but I will keep that in mind.\r\n\r\nI am afraid I cannot answer your second question. I would like to get rid of all these tricky cases and keep my code clean of course. @grosu","created_at":"2014-03-07T20:43:30Z","updated_at":"2014-03-07T20:43:30Z","html_url":"https://github.com/kframework/k/pull/270#discussion_r10399060","pull_request_url":"https://api.github.com/repos/kframework/k/pulls/270","_links":{"self":{"href":"https://api.github.com/repos/kframework/k/pulls/comments/10399060"},"html":{"href":"https://github.com/kframework/k/pull/270#discussion_r10399060"},"pull_request":{"href":"https://api.github.com/repos/kframework/k/pulls/270"}}}}