GitHub PullRequestReviewCommentEvent at 2014-08-14 13:52:19
Repository: symfony-docs
Actor: stof
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/16238595","id":16238595,"diff_hunk":"@@ -130,54 +221,319 @@ is set, then the ``ide`` option will be ignored.\n test\n ~~~~\n \n-**type**: ``Boolean``\n+**type**: ``boolean``\n \n If this configuration parameter is present (and not ``false``), then the\n services related to testing your application (e.g. ``test.client``) are loaded.\n This setting should be present in your ``test`` environment (usually via\n-``app/config/config_test.yml``). For more information, see :doc:`/book/testing`.\n+``app/config/config_test.yml``).\n \n-.. _reference-framework-trusted-proxies:\n+.. seealso::\n \n-trusted_proxies\n-~~~~~~~~~~~~~~~\n+   For more information, see :doc:`/book/testing`.\n \n-**type**: ``array``\n+default_locale\n+~~~~~~~~~~~~~~\n \n-Configures the IP addresses that should be trusted as proxies. For more details,\n-see :doc:`/cookbook/request/load_balancer_reverse_proxy`.\n+**type**: ``string`` **default**: ``'en'``\n \n-.. versionadded:: 2.3\n-    CIDR notation support was introduced in Symfony 2.3, so you can whitelist whole\n-    subnets (e.g. ``10.0.0.0/8``, ``fc00::/7``).\n+If the locale can't be determined from the Request or session, the default","path":"reference/configuration/framework.rst","position":206,"original_position":206,"commit_id":"43924f2a6e1bec8e02d1b5cc4b02922766133416","original_commit_id":"43924f2a6e1bec8e02d1b5cc4b02922766133416","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=2","gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"Symfony does not read the locale from the session anymore since 2.1","created_at":"2014-08-14T13:52:19Z","updated_at":"2014-08-14T13:52:19Z","html_url":"https://github.com/symfony/symfony-docs/pull/4121#discussion_r16238595","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4121","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/16238595"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4121#discussion_r16238595"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4121"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4121","id":19783239,"html_url":"https://github.com/symfony/symfony-docs/pull/4121","diff_url":"https://github.com/symfony/symfony-docs/pull/4121.diff","patch_url":"https://github.com/symfony/symfony-docs/pull/4121.patch","issue_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4121","number":4121,"state":"open","locked":false,"title":"[WIP] Documenting all options of the FrameworkBundle","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=2","gravatar_id":"331582449435f5efa35be870ab76f1a9","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"Let's give one of the most forgotten dark places of the documentation some love :)\n\nIt's quite a difficult job, since I have to document lots of things I'm normally not very interested in (and thus do not know much about). So I hope the core team can help me verify the documentation in this PR. (cc @stof @jakzal)\n\n| Q   | A\n| --- | ---\n| Doc fix? | yes\n| New docs? | yes\n| Applies to | 2.3+\n| Fixed tickets | not sure","created_at":"2014-08-14T12:08:31Z","updated_at":"2014-08-14T13:52:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96078dba2203ed9a2bbb6f91a8bb2e17706a97d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4121/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4121/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4121/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/43924f2a6e1bec8e02d1b5cc4b02922766133416","head":{"label":"WouterJ:config_ref_framework","ref":"config_ref_framework","sha":"43924f2a6e1bec8e02d1b5cc4b02922766133416","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=2","gravatar_id":"331582449435f5efa35be870ab76f1a9","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"repo":{"id":4110264,"name":"symfony-docs","full_name":"WouterJ/symfony-docs","owner":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=2","gravatar_id":"331582449435f5efa35be870ab76f1a9","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WouterJ/symfony-docs","description":"The Symfony2 documentation","fork":true,"url":"https://api.github.com/repos/WouterJ/symfony-docs","forks_url":"https://api.github.com/repos/WouterJ/symfony-docs/forks","keys_url":"https://api.github.com/repos/WouterJ/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WouterJ/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WouterJ/symfony-docs/teams","hooks_url":"https://api.github.com/repos/WouterJ/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/WouterJ/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/WouterJ/symfony-docs/events","assignees_url":"https://api.github.com/repos/WouterJ/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/WouterJ/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/WouterJ/symfony-docs/tags","blobs_url":"https://api.github.com/repos/WouterJ/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WouterJ/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WouterJ/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/WouterJ/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WouterJ/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/WouterJ/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/WouterJ/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/WouterJ/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/WouterJ/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/WouterJ/symfony-docs/subscription","commits_url":"https://api.github.com/repos/WouterJ/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/WouterJ/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/WouterJ/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/WouterJ/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/WouterJ/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/WouterJ/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WouterJ/symfony-docs/merges","archive_url":"https://api.github.com/repos/WouterJ/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WouterJ/symfony-docs/downloads","issues_url":"https://api.github.com/repos/WouterJ/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/WouterJ/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/WouterJ/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/WouterJ/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WouterJ/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/WouterJ/symfony-docs/releases{/id}","created_at":"2012-04-23T06:36:17Z","updated_at":"2014-06-14T16:16:46Z","pushed_at":"2014-08-14T12:04:21Z","git_url":"git://github.com/WouterJ/symfony-docs.git","ssh_url":"git@github.com:WouterJ/symfony-docs.git","clone_url":"https://github.com/WouterJ/symfony-docs.git","svn_url":"https://github.com/WouterJ/symfony-docs","homepage":"http://symfony.com/doc/2.0/","size":22543,"stargazers_count":0,"watchers_count":0,"language":"Lasso","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"7806aa7de543baf167d445dc5901121a2e460599","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":521583,"name":"symfony-docs","full_name":"symfony/symfony-docs","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=2","gravatar_id":"bc6312a5b583c4258c9fad11122c6e31","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-docs","description":"The Symfony2 documentation","fork":false,"url":"https://api.github.com/repos/symfony/symfony-docs","forks_url":"https://api.github.com/repos/symfony/symfony-docs/forks","keys_url":"https://api.github.com/repos/symfony/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-docs/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-docs/events","assignees_url":"https://api.github.com/repos/symfony/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-docs/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-docs/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-docs/merges","archive_url":"https://api.github.com/repos/symfony/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-docs/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-docs/releases{/id}","created_at":"2010-02-17T08:43:51Z","updated_at":"2014-08-09T21:26:51Z","pushed_at":"2014-08-13T19:41:29Z","git_url":"git://github.com/symfony/symfony-docs.git","ssh_url":"git@github.com:symfony/symfony-docs.git","clone_url":"https://github.com/symfony/symfony-docs.git","svn_url":"https://github.com/symfony/symfony-docs","homepage":"http://symfony.com/doc/current/","size":49479,"stargazers_count":912,"watchers_count":912,"language":"Assembly","has_issues":true,"has_downloads":false,"has_wiki":false,"forks_count":1419,"mirror_url":null,"open_issues_count":210,"forks":1419,"open_issues":210,"watchers":912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4121"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4121"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4121"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4121/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4121/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4121/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-docs/statuses/43924f2a6e1bec8e02d1b5cc4b02922766133416"}}}}