GitHub PullRequestReviewCommentEvent at 2014-11-06 10:01:19
Repository: crouton
Actor: dnschneid
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dnschneid/crouton/pulls/comments/19935256","id":19935256,"diff_hunk":"@@ -58,6 +58,12 @@ elif [ ! \"$TARGETS\" = 'check' ]; then\n         $SIMULATE installscript \"$src\" \"$BIN/\"\n         [ ! -h \"$src\" ] && $SIMULATE chmod 755 \"$BIN/$f\"\n     done\n+","path":"targets/common","position":4,"original_position":4,"commit_id":"ec449c0e51a29e6afc5bed2ebd4adeebd56c8ce3","original_commit_id":"ec449c0e51a29e6afc5bed2ebd4adeebd56c8ce3","user":{"login":"dnschneid","id":522200,"avatar_url":"https://avatars.githubusercontent.com/u/522200?v=2","gravatar_id":"","url":"https://api.github.com/users/dnschneid","html_url":"https://github.com/dnschneid","followers_url":"https://api.github.com/users/dnschneid/followers","following_url":"https://api.github.com/users/dnschneid/following{/other_user}","gists_url":"https://api.github.com/users/dnschneid/gists{/gist_id}","starred_url":"https://api.github.com/users/dnschneid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnschneid/subscriptions","organizations_url":"https://api.github.com/users/dnschneid/orgs","repos_url":"https://api.github.com/users/dnschneid/repos","events_url":"https://api.github.com/users/dnschneid/events{/privacy}","received_events_url":"https://api.github.com/users/dnschneid/received_events","type":"User","site_admin":false},"body":"If we change line 35 to use TARGETNOINSTALL (I think it's correct, but you should confirm), we should be able to get rid of the TARGETS=check hack entirely.","created_at":"2014-11-06T10:01:19Z","updated_at":"2014-11-06T10:01:19Z","html_url":"https://github.com/dnschneid/crouton/pull/1131#discussion_r19935256","pull_request_url":"https://api.github.com/repos/dnschneid/crouton/pulls/1131","_links":{"self":{"href":"https://api.github.com/repos/dnschneid/crouton/pulls/comments/19935256"},"html":{"href":"https://github.com/dnschneid/crouton/pull/1131#discussion_r19935256"},"pull_request":{"href":"https://api.github.com/repos/dnschneid/crouton/pulls/1131"}}},"pull_request":{"url":"https://api.github.com/repos/dnschneid/crouton/pulls/1131","id":23031173,"html_url":"https://github.com/dnschneid/crouton/pull/1131","diff_url":"https://github.com/dnschneid/crouton/pull/1131.diff","patch_url":"https://github.com/dnschneid/crouton/pull/1131.patch","issue_url":"https://api.github.com/repos/dnschneid/crouton/issues/1131","number":1131,"state":"open","locked":false,"title":"installer: Allow host-bin restoration only.","user":{"login":"drinkcat","id":3467596,"avatar_url":"https://avatars.githubusercontent.com/u/3467596?v=2","gravatar_id":"","url":"https://api.github.com/users/drinkcat","html_url":"https://github.com/drinkcat","followers_url":"https://api.github.com/users/drinkcat/followers","following_url":"https://api.github.com/users/drinkcat/following{/other_user}","gists_url":"https://api.github.com/users/drinkcat/gists{/gist_id}","starred_url":"https://api.github.com/users/drinkcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drinkcat/subscriptions","organizations_url":"https://api.github.com/users/drinkcat/orgs","repos_url":"https://api.github.com/users/drinkcat/repos","events_url":"https://api.github.com/users/drinkcat/events{/privacy}","received_events_url":"https://api.github.com/users/drinkcat/received_events","type":"User","site_admin":false},"body":"Add a  `-b` option to the installer that only restores host-bin scripts, based on the target files installed in all existing chroots. This happens to be a prerequisite for #706 .\r\n\r\nIncidentally, this fixes #1106 as crouton -f tarball now only restores host-bin (and not chroot-bin, which would mangle croutonversion output, see https://github.com/dnschneid/crouton/issues/1106#issuecomment-59576779).\r\n\r\nWe also provide a minimal test for `-b`: binaries are restored.\r\n\r\nI've read somewhere that you need to have a failing test before fixing issues. This confirms #1106:\r\n`2014-10-20_03-49-08_drinkcat_chroagh_splittest+edit-chroot-fix.testonly_12` (only e62f4b1)\r\n\r\nThen a full test:\r\n`2014-10-20_06-01-54_drinkcat_chroagh_splittest+edit-chroot-fix`\r\nanother one that tests all targets (`x0`):\r\n`2014-10-20_06-02-35_drinkcat_chroagh_splittest+edit-chroot-fix_x0` (mirrors are flaky, but overall it's ok)\r\nand a last one with the latest cosmetic changes:\r\n`2014-10-20_17-13-16_drinkcat_chroagh_splittest+edit-chroot-fix_12`","created_at":"2014-10-20T17:35:24Z","updated_at":"2014-11-06T10:01:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe16021c5a509b503f593776c59c71d77849df6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dnschneid/crouton/pulls/1131/commits","review_comments_url":"https://api.github.com/repos/dnschneid/crouton/pulls/1131/comments","review_comment_url":"https://api.github.com/repos/dnschneid/crouton/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dnschneid/crouton/issues/1131/comments","statuses_url":"https://api.github.com/repos/dnschneid/crouton/statuses/ec449c0e51a29e6afc5bed2ebd4adeebd56c8ce3","head":{"label":"drinkcat:splittest+edit-chroot-fix","ref":"splittest+edit-chroot-fix","sha":"ec449c0e51a29e6afc5bed2ebd4adeebd56c8ce3","user":{"login":"drinkcat","id":3467596,"avatar_url":"https://avatars.githubusercontent.com/u/3467596?v=2","gravatar_id":"","url":"https://api.github.com/users/drinkcat","html_url":"https://github.com/drinkcat","followers_url":"https://api.github.com/users/drinkcat/followers","following_url":"https://api.github.com/users/drinkcat/following{/other_user}","gists_url":"https://api.github.com/users/drinkcat/gists{/gist_id}","starred_url":"https://api.github.com/users/drinkcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drinkcat/subscriptions","organizations_url":"https://api.github.com/users/drinkcat/orgs","repos_url":"https://api.github.com/users/drinkcat/repos","events_url":"https://api.github.com/users/drinkcat/events{/privacy}","received_events_url":"https://api.github.com/users/drinkcat/received_events","type":"User","site_admin":false},"repo":{"id":9856262,"name":"chroagh","full_name":"drinkcat/chroagh","owner":{"login":"drinkcat","id":3467596,"avatar_url":"https://avatars.githubusercontent.com/u/3467596?v=2","gravatar_id":"","url":"https://api.github.com/users/drinkcat","html_url":"https://github.com/drinkcat","followers_url":"https://api.github.com/users/drinkcat/followers","following_url":"https://api.github.com/users/drinkcat/following{/other_user}","gists_url":"https://api.github.com/users/drinkcat/gists{/gist_id}","starred_url":"https://api.github.com/users/drinkcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drinkcat/subscriptions","organizations_url":"https://api.github.com/users/drinkcat/orgs","repos_url":"https://api.github.com/users/drinkcat/repos","events_url":"https://api.github.com/users/drinkcat/events{/privacy}","received_events_url":"https://api.github.com/users/drinkcat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drinkcat/chroagh","description":"Chromium OS Archlinux Chroot Environment","fork":true,"url":"https://api.github.com/repos/drinkcat/chroagh","forks_url":"https://api.github.com/repos/drinkcat/chroagh/forks","keys_url":"https://api.github.com/repos/drinkcat/chroagh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drinkcat/chroagh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drinkcat/chroagh/teams","hooks_url":"https://api.github.com/repos/drinkcat/chroagh/hooks","issue_events_url":"https://api.github.com/repos/drinkcat/chroagh/issues/events{/number}","events_url":"https://api.github.com/repos/drinkcat/chroagh/events","assignees_url":"https://api.github.com/repos/drinkcat/chroagh/assignees{/user}","branches_url":"https://api.github.com/repos/drinkcat/chroagh/branches{/branch}","tags_url":"https://api.github.com/repos/drinkcat/chroagh/tags","blobs_url":"https://api.github.com/repos/drinkcat/chroagh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drinkcat/chroagh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drinkcat/chroagh/git/refs{/sha}","trees_url":"https://api.github.com/repos/drinkcat/chroagh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drinkcat/chroagh/statuses/{sha}","languages_url":"https://api.github.com/repos/drinkcat/chroagh/languages","stargazers_url":"https://api.github.com/repos/drinkcat/chroagh/stargazers","contributors_url":"https://api.github.com/repos/drinkcat/chroagh/contributors","subscribers_url":"https://api.github.com/repos/drinkcat/chroagh/subscribers","subscription_url":"https://api.github.com/repos/drinkcat/chroagh/subscription","commits_url":"https://api.github.com/repos/drinkcat/chroagh/commits{/sha}","git_commits_url":"https://api.github.com/repos/drinkcat/chroagh/git/commits{/sha}","comments_url":"https://api.github.com/repos/drinkcat/chroagh/comments{/number}","issue_comment_url":"https://api.github.com/repos/drinkcat/chroagh/issues/comments/{number}","contents_url":"https://api.github.com/repos/drinkcat/chroagh/contents/{+path}","compare_url":"https://api.github.com/repos/drinkcat/chroagh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drinkcat/chroagh/merges","archive_url":"https://api.github.com/repos/drinkcat/chroagh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drinkcat/chroagh/downloads","issues_url":"https://api.github.com/repos/drinkcat/chroagh/issues{/number}","pulls_url":"https://api.github.com/repos/drinkcat/chroagh/pulls{/number}","milestones_url":"https://api.github.com/repos/drinkcat/chroagh/milestones{/number}","notifications_url":"https://api.github.com/repos/drinkcat/chroagh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drinkcat/chroagh/labels{/name}","releases_url":"https://api.github.com/repos/drinkcat/chroagh/releases{/id}","created_at":"2013-05-04T15:50:52Z","updated_at":"2014-10-29T22:05:11Z","pushed_at":"2014-11-06T06:50:21Z","git_url":"git://github.com/drinkcat/chroagh.git","ssh_url":"git@github.com:drinkcat/chroagh.git","clone_url":"https://github.com/drinkcat/chroagh.git","svn_url":"https://github.com/drinkcat/chroagh","homepage":"","size":10356,"stargazers_count":93,"watchers_count":93,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":6,"forks":9,"open_issues":6,"watchers":93,"default_branch":"master"}},"base":{"label":"dnschneid:master","ref":"master","sha":"a9cb6230f9b60b7c4cb45d588c30ffd914355af9","user":{"login":"dnschneid","id":522200,"avatar_url":"https://avatars.githubusercontent.com/u/522200?v=2","gravatar_id":"","url":"https://api.github.com/users/dnschneid","html_url":"https://github.com/dnschneid","followers_url":"https://api.github.com/users/dnschneid/followers","following_url":"https://api.github.com/users/dnschneid/following{/other_user}","gists_url":"https://api.github.com/users/dnschneid/gists{/gist_id}","starred_url":"https://api.github.com/users/dnschneid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnschneid/subscriptions","organizations_url":"https://api.github.com/users/dnschneid/orgs","repos_url":"https://api.github.com/users/dnschneid/repos","events_url":"https://api.github.com/users/dnschneid/events{/privacy}","received_events_url":"https://api.github.com/users/dnschneid/received_events","type":"User","site_admin":false},"repo":{"id":7229063,"name":"crouton","full_name":"dnschneid/crouton","owner":{"login":"dnschneid","id":522200,"avatar_url":"https://avatars.githubusercontent.com/u/522200?v=2","gravatar_id":"","url":"https://api.github.com/users/dnschneid","html_url":"https://github.com/dnschneid","followers_url":"https://api.github.com/users/dnschneid/followers","following_url":"https://api.github.com/users/dnschneid/following{/other_user}","gists_url":"https://api.github.com/users/dnschneid/gists{/gist_id}","starred_url":"https://api.github.com/users/dnschneid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnschneid/subscriptions","organizations_url":"https://api.github.com/users/dnschneid/orgs","repos_url":"https://api.github.com/users/dnschneid/repos","events_url":"https://api.github.com/users/dnschneid/events{/privacy}","received_events_url":"https://api.github.com/users/dnschneid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnschneid/crouton","description":"Chromium OS Universal Chroot Environment","fork":false,"url":"https://api.github.com/repos/dnschneid/crouton","forks_url":"https://api.github.com/repos/dnschneid/crouton/forks","keys_url":"https://api.github.com/repos/dnschneid/crouton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnschneid/crouton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnschneid/crouton/teams","hooks_url":"https://api.github.com/repos/dnschneid/crouton/hooks","issue_events_url":"https://api.github.com/repos/dnschneid/crouton/issues/events{/number}","events_url":"https://api.github.com/repos/dnschneid/crouton/events","assignees_url":"https://api.github.com/repos/dnschneid/crouton/assignees{/user}","branches_url":"https://api.github.com/repos/dnschneid/crouton/branches{/branch}","tags_url":"https://api.github.com/repos/dnschneid/crouton/tags","blobs_url":"https://api.github.com/repos/dnschneid/crouton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnschneid/crouton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnschneid/crouton/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnschneid/crouton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnschneid/crouton/statuses/{sha}","languages_url":"https://api.github.com/repos/dnschneid/crouton/languages","stargazers_url":"https://api.github.com/repos/dnschneid/crouton/stargazers","contributors_url":"https://api.github.com/repos/dnschneid/crouton/contributors","subscribers_url":"https://api.github.com/repos/dnschneid/crouton/subscribers","subscription_url":"https://api.github.com/repos/dnschneid/crouton/subscription","commits_url":"https://api.github.com/repos/dnschneid/crouton/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnschneid/crouton/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnschneid/crouton/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnschneid/crouton/issues/comments/{number}","contents_url":"https://api.github.com/repos/dnschneid/crouton/contents/{+path}","compare_url":"https://api.github.com/repos/dnschneid/crouton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnschneid/crouton/merges","archive_url":"https://api.github.com/repos/dnschneid/crouton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnschneid/crouton/downloads","issues_url":"https://api.github.com/repos/dnschneid/crouton/issues{/number}","pulls_url":"https://api.github.com/repos/dnschneid/crouton/pulls{/number}","milestones_url":"https://api.github.com/repos/dnschneid/crouton/milestones{/number}","notifications_url":"https://api.github.com/repos/dnschneid/crouton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnschneid/crouton/labels{/name}","releases_url":"https://api.github.com/repos/dnschneid/crouton/releases{/id}","created_at":"2012-12-18T19:31:14Z","updated_at":"2014-11-05T20:32:51Z","pushed_at":"2014-11-06T09:39:27Z","git_url":"git://github.com/dnschneid/crouton.git","ssh_url":"git@github.com:dnschneid/crouton.git","clone_url":"https://github.com/dnschneid/crouton.git","svn_url":"https://github.com/dnschneid/crouton","homepage":"https://goo.gl/fd3zc","size":14478,"stargazers_count":2103,"watchers_count":2103,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":228,"mirror_url":null,"open_issues_count":210,"forks":228,"open_issues":210,"watchers":2103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dnschneid/crouton/pulls/1131"},"html":{"href":"https://github.com/dnschneid/crouton/pull/1131"},"issue":{"href":"https://api.github.com/repos/dnschneid/crouton/issues/1131"},"comments":{"href":"https://api.github.com/repos/dnschneid/crouton/issues/1131/comments"},"review_comments":{"href":"https://api.github.com/repos/dnschneid/crouton/pulls/1131/comments"},"review_comment":{"href":"https://api.github.com/repos/dnschneid/crouton/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dnschneid/crouton/pulls/1131/commits"},"statuses":{"href":"https://api.github.com/repos/dnschneid/crouton/statuses/ec449c0e51a29e6afc5bed2ebd4adeebd56c8ce3"}}}}