GitHub PushEvent at 2014-04-07 09:24:49
Repository: whitehall
Actor: bishboria
Payload: {"shas":[["f3a9200b76cd68f15d9e0b97c108eb4f8f2a1dce","1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","Rewrite tests for clarity and honesty\n\nThe main thing I wanted to clarify is the special case for speeches.\nPreviously, the test was describing the mechanics without actually\nexplaining what the intent was. It was also making the code hard to\nchange because it was stubbing a protected method that actually no\nlonger does the right thing (we no longer set the public_timestamp on\nspeeches based on their delivered_on date).\n\nWithout rewriting the tests like this, the next commit would not have\nbeen possible.","Tekin Suleyman",false],["62a6b44814411e1ff1a7f1617ebcbb0118aa10ed","1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","Remove redundant special case\n\nIn the past, the public_timestamp for speeches was set based on their\ndelivered_on timestamp, so we had to have this special case code to\nensure that speeches published the day after they were delivered still\ngot notifications. As of https://github.com/alphagov/whitehall/pull/552\nhowever, we no longer do that and speeches get the same\npublic_timestamp as other edition classes, making this code both\ndangerously confusing and redundant.","Tekin Suleyman",false],["f9a0eabbc26e6b9e37d62d889f18c19a26f44860","1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","Don't nofity outdated speeches\n\nWith transition, we are importing many old speeches that we do not\nwant to generate gov delivery notifications for. This updates the\nnotifier code such that a speech delivered more than 72 hours ago will\nnot result in a gov delivery notification when it is first published.\nAny subsequent major updates will still result in a notification, as\nexpected.","Tekin Suleyman",false],["40572014ddbc39b966d1e694d55dbf0a74479c1f","1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","Reword test for clarity","Tekin Suleyman",false],["7a98c8dcf4c289dea75a93fa354f6037f346e0fd","fdf2294cd4cea58bbddaaf0b148fe05dcf67ad28@gmail.com","Merge pull request #1412 from alphagov/dont-alert-old-speeches\n\nDont alert old speeches","bishboria",true]],"size":5,"ref":"refs/heads/master","head":"7a98c8dcf4c289dea75a93fa354f6037f346e0fd"}