GitHub PullRequestReviewCommentEvent at 2014-03-31 08:43:29
Repository: puppet-nginx
Actor: raoulbhatia
Payload: {"comment":{"url":"https://api.github.com/repos/netmanagers/puppet-nginx/pulls/comments/11107438","id":11107438,"diff_hunk":"@@ -427,7 +432,7 @@\n \n   if $nginx::config_file_default_purge {\n     $default_site = $::operatingsystem ? {\n-      /(?i:Debian|Ubuntu|Mint)/              => [ \"${nginx::config_dir}/sites-enabled/default\", \"${nginx::config_dir}/sites-available/default\" ],\n+      /(?i:Debian|Ubuntu|Mint)/              => [ \"${nginx::vedir}/default\" ],","path":"manifests/init.pp","position":17,"original_position":17,"commit_id":"6958b8f683ce142047c0e31809dd0f1e641c6f6a","original_commit_id":"6958b8f683ce142047c0e31809dd0f1e641c6f6a","user":{"login":"raoulbhatia","id":727412,"avatar_url":"https://avatars.githubusercontent.com/u/727412?","gravatar_id":"b60ec6d7b601c9d961dd7c76ca82c222","url":"https://api.github.com/users/raoulbhatia","html_url":"https://github.com/raoulbhatia","followers_url":"https://api.github.com/users/raoulbhatia/followers","following_url":"https://api.github.com/users/raoulbhatia/following{/other_user}","gists_url":"https://api.github.com/users/raoulbhatia/gists{/gist_id}","starred_url":"https://api.github.com/users/raoulbhatia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raoulbhatia/subscriptions","organizations_url":"https://api.github.com/users/raoulbhatia/orgs","repos_url":"https://api.github.com/users/raoulbhatia/repos","events_url":"https://api.github.com/users/raoulbhatia/events{/privacy}","received_events_url":"https://api.github.com/users/raoulbhatia/received_events","type":"User","site_admin":false},"body":"As my changes will compile an ```nginx.conf``` file which includes ```[...]/conf.d/*conf``` and ```[...]/sites-enabled/*``` only, removing ```[...]/sites-enabled/default``` should be sufficient.\r\n\r\nAlso, as far as I have been using and have seen others use xyz-{available,enabled} directories: \r\n\r\n1) Store all possible configurations in xyz-available and \r\n2) enable only the ones you need via syz-enabled.\r\n\r\ne.g. if you run apache's a2dissite or a2dismod, only the {sites,mods}-enabled symlink is removed but not the whole configuration. The same applies to (newer) php, lighttpd, ... configuration (on Debian/Ubuntu).\r\n\r\nWhat are your thoughts on this?","created_at":"2014-03-31T08:43:29Z","updated_at":"2014-03-31T08:43:29Z","html_url":"https://github.com/netmanagers/puppet-nginx/pull/51#discussion_r11107438","pull_request_url":"https://api.github.com/repos/netmanagers/puppet-nginx/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/netmanagers/puppet-nginx/pulls/comments/11107438"},"html":{"href":"https://github.com/netmanagers/puppet-nginx/pull/51#discussion_r11107438"},"pull_request":{"href":"https://api.github.com/repos/netmanagers/puppet-nginx/pulls/51"}}}}