GitHub PullRequestEvent at 2014-10-23 11:07:29
Repository: ka-lite-installer-windows
Actor: cpauya
Payload: {"action":"opened","number":48,"pull_request":{"url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/pulls/48","id":23220772,"html_url":"https://github.com/learningequality/ka-lite-installer-windows/pull/48","diff_url":"https://github.com/learningequality/ka-lite-installer-windows/pull/48.diff","patch_url":"https://github.com/learningequality/ka-lite-installer-windows/pull/48.patch","issue_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/issues/48","number":48,"state":"open","locked":false,"title":"Fix for #45-Check validity of username during installation.","user":{"login":"cpauya","id":175580,"avatar_url":"https://avatars.githubusercontent.com/u/175580?v=2","gravatar_id":"","url":"https://api.github.com/users/cpauya","html_url":"https://github.com/cpauya","followers_url":"https://api.github.com/users/cpauya/followers","following_url":"https://api.github.com/users/cpauya/following{/other_user}","gists_url":"https://api.github.com/users/cpauya/gists{/gist_id}","starred_url":"https://api.github.com/users/cpauya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpauya/subscriptions","organizations_url":"https://api.github.com/users/cpauya/orgs","repos_url":"https://api.github.com/users/cpauya/repos","events_url":"https://api.github.com/users/cpauya/events{/privacy}","received_events_url":"https://api.github.com/users/cpauya/received_events","type":"User","site_admin":false},"body":"Hi @ruimalheiro \r\n\r\nThis fixes #46 - Check validity of username during installation.  \r\n\r\nWe now validate the following:\r\n\r\n* username length max of 75 characters\r\n* password length max of 128 characters\r\n* username allowed characters are \"letters, numbers and @/./+/-/_ characters\" based on `django.contrib.auth.models.AbstractUser`\r\n\r\nSee attached screenshot for an example.\r\n\r\n/cc @aronasorman \r\n\r\n![ka-lite-windows-installer-2014-10-23a](https://cloud.githubusercontent.com/assets/175580/4751952/8758ffa4-5aa4-11e4-870d-de7c62e84e18.png)\r\n","created_at":"2014-10-23T11:07:29Z","updated_at":"2014-10-23T11:07:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/pulls/48/commits","review_comments_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/pulls/48/comments","review_comment_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/pulls/comments/{number}","comments_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/issues/48/comments","statuses_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/statuses/b61ed2a7716d02941da7a02c6978b6639be17dd0","head":{"label":"mrpau:hotfix/46-check-validity-of-username-during-installation","ref":"hotfix/46-check-validity-of-username-during-installation","sha":"b61ed2a7716d02941da7a02c6978b6639be17dd0","user":{"login":"mrpau","id":8663898,"avatar_url":"https://avatars.githubusercontent.com/u/8663898?v=2","gravatar_id":"","url":"https://api.github.com/users/mrpau","html_url":"https://github.com/mrpau","followers_url":"https://api.github.com/users/mrpau/followers","following_url":"https://api.github.com/users/mrpau/following{/other_user}","gists_url":"https://api.github.com/users/mrpau/gists{/gist_id}","starred_url":"https://api.github.com/users/mrpau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrpau/subscriptions","organizations_url":"https://api.github.com/users/mrpau/orgs","repos_url":"https://api.github.com/users/mrpau/repos","events_url":"https://api.github.com/users/mrpau/events{/privacy}","received_events_url":"https://api.github.com/users/mrpau/received_events","type":"Organization","site_admin":false},"repo":{"id":25328190,"name":"ka-lite-installer-windows","full_name":"mrpau/ka-lite-installer-windows","owner":{"login":"mrpau","id":8663898,"avatar_url":"https://avatars.githubusercontent.com/u/8663898?v=2","gravatar_id":"","url":"https://api.github.com/users/mrpau","html_url":"https://github.com/mrpau","followers_url":"https://api.github.com/users/mrpau/followers","following_url":"https://api.github.com/users/mrpau/following{/other_user}","gists_url":"https://api.github.com/users/mrpau/gists{/gist_id}","starred_url":"https://api.github.com/users/mrpau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrpau/subscriptions","organizations_url":"https://api.github.com/users/mrpau/orgs","repos_url":"https://api.github.com/users/mrpau/repos","events_url":"https://api.github.com/users/mrpau/events{/privacy}","received_events_url":"https://api.github.com/users/mrpau/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mrpau/ka-lite-installer-windows","description":"Scripts for building a Windows installer with a GUI launcher","fork":true,"url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows","forks_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/forks","keys_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/teams","hooks_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/hooks","issue_events_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/issues/events{/number}","events_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/events","assignees_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/assignees{/user}","branches_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/branches{/branch}","tags_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/tags","blobs_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/languages","stargazers_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/stargazers","contributors_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/contributors","subscribers_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/subscribers","subscription_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/subscription","commits_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/issues/comments/{number}","contents_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/contents/{+path}","compare_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/merges","archive_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/downloads","issues_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/issues{/number}","pulls_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/labels{/name}","releases_url":"https://api.github.com/repos/mrpau/ka-lite-installer-windows/releases{/id}","created_at":"2014-10-16T23:56:15Z","updated_at":"2014-09-09T09:13:25Z","pushed_at":"2014-10-23T11:00:21Z","git_url":"git://github.com/mrpau/ka-lite-installer-windows.git","ssh_url":"git@github.com:mrpau/ka-lite-installer-windows.git","clone_url":"https://github.com/mrpau/ka-lite-installer-windows.git","svn_url":"https://github.com/mrpau/ka-lite-installer-windows","homepage":null,"size":26497,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"learningequality:master","ref":"master","sha":"89e14792e077256dbded89f63bd83322c1a58758","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=2","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":9017142,"name":"ka-lite-installer-windows","full_name":"learningequality/ka-lite-installer-windows","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars.githubusercontent.com/u/3926525?v=2","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/ka-lite-installer-windows","description":"Scripts for building a Windows installer with a GUI launcher","fork":false,"url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows","forks_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/forks","keys_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/teams","hooks_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/hooks","issue_events_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/events","assignees_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/tags","blobs_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/languages","stargazers_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/stargazers","contributors_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/contributors","subscribers_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/subscribers","subscription_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/subscription","commits_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/issues/comments/{number}","contents_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/merges","archive_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/downloads","issues_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/releases{/id}","created_at":"2013-03-25T22:07:06Z","updated_at":"2014-09-09T09:13:25Z","pushed_at":"2014-10-08T23:18:24Z","git_url":"git://github.com/learningequality/ka-lite-installer-windows.git","ssh_url":"git@github.com:learningequality/ka-lite-installer-windows.git","clone_url":"https://github.com/learningequality/ka-lite-installer-windows.git","svn_url":"https://github.com/learningequality/ka-lite-installer-windows","homepage":null,"size":26961,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":14,"forks":6,"open_issues":14,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/pulls/48"},"html":{"href":"https://github.com/learningequality/ka-lite-installer-windows/pull/48"},"issue":{"href":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/issues/48"},"comments":{"href":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/ka-lite-installer-windows/statuses/b61ed2a7716d02941da7a02c6978b6639be17dd0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":65,"deletions":15,"changed_files":1}}