GitHub PullRequestEvent at 2014-08-10 04:19:54
Repository: Cinder
Actor: richardeakin
Payload: {"action":"closed","number":480,"pull_request":{"url":"https://api.github.com/repos/cinder/Cinder/pulls/480","id":19560084,"html_url":"https://github.com/cinder/Cinder/pull/480","diff_url":"https://github.com/cinder/Cinder/pull/480.diff","patch_url":"https://github.com/cinder/Cinder/pull/480.patch","issue_url":"https://api.github.com/repos/cinder/Cinder/issues/480","number":480,"state":"closed","title":"avoid out of bounds access when windowless","user":{"login":"pizthewiz","id":648369,"avatar_url":"https://avatars.githubusercontent.com/u/648369?v=2","gravatar_id":"9005281d142d2e0b17b966c51f5f6818","url":"https://api.github.com/users/pizthewiz","html_url":"https://github.com/pizthewiz","followers_url":"https://api.github.com/users/pizthewiz/followers","following_url":"https://api.github.com/users/pizthewiz/following{/other_user}","gists_url":"https://api.github.com/users/pizthewiz/gists{/gist_id}","starred_url":"https://api.github.com/users/pizthewiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pizthewiz/subscriptions","organizations_url":"https://api.github.com/users/pizthewiz/orgs","repos_url":"https://api.github.com/users/pizthewiz/repos","events_url":"https://api.github.com/users/pizthewiz/events{/privacy}","received_events_url":"https://api.github.com/users/pizthewiz/received_events","type":"User","site_admin":false},"body":"(originally #479, now against the new `master` branch)\r\n\r\nA window-less Cinder application can be very useful and yet it isn't obvious how best it should be created. Options are not available on `Window::Format` or `Settings` to prevent the creation in `App::prepareSettings(Settings* settings)`, instead one must call `close()` on it. While `hide()` will conceal the window, the draw loop is still executed.\r\n\r\nIf `close()` is called during `App::setup()`, an error is logged to the console after it executes:\r\n```sh\r\n2014-08-06 11:37:58.747 Process[77904:996154] *** -[__NSArrayM objectAtIndex:]: index 0 beyond bounds for empty array\r\n```\r\n\r\nThe error originates from `-[AppImplCocoaBasic applicationDidFinishLaunching:]` [line 101](https://github.com/cinder/Cinder/blob/master/src/cinder/app/AppImplCocoaBasic.mm#L101):\r\n```Objective-C\r\n// make the first window the active window\r\n[self setActiveWindow:[mWindows objectAtIndex:0]];\r\n```\r\n\r\nWhen the window is closed, `mWindows` is empty. `-[NSArray firstObject]` will internally handle the empty case and return `nil`.","created_at":"2014-08-09T01:57:46Z","updated_at":"2014-08-10T04:19:53Z","closed_at":"2014-08-10T04:19:53Z","merged_at":"2014-08-10T04:19:53Z","merge_commit_sha":"c5778ab7e9b45f6eb88a268e0d4dfa97b25af8ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cinder/Cinder/pulls/480/commits","review_comments_url":"https://api.github.com/repos/cinder/Cinder/pulls/480/comments","review_comment_url":"https://api.github.com/repos/cinder/Cinder/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cinder/Cinder/issues/480/comments","statuses_url":"https://api.github.com/repos/cinder/Cinder/statuses/6e196dfafccd97e16fcb2061663c880f4b066322","head":{"label":"pizthewiz:range-exception-osx","ref":"range-exception-osx","sha":"6e196dfafccd97e16fcb2061663c880f4b066322","user":{"login":"pizthewiz","id":648369,"avatar_url":"https://avatars.githubusercontent.com/u/648369?v=2","gravatar_id":"9005281d142d2e0b17b966c51f5f6818","url":"https://api.github.com/users/pizthewiz","html_url":"https://github.com/pizthewiz","followers_url":"https://api.github.com/users/pizthewiz/followers","following_url":"https://api.github.com/users/pizthewiz/following{/other_user}","gists_url":"https://api.github.com/users/pizthewiz/gists{/gist_id}","starred_url":"https://api.github.com/users/pizthewiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pizthewiz/subscriptions","organizations_url":"https://api.github.com/users/pizthewiz/orgs","repos_url":"https://api.github.com/users/pizthewiz/repos","events_url":"https://api.github.com/users/pizthewiz/events{/privacy}","received_events_url":"https://api.github.com/users/pizthewiz/received_events","type":"User","site_admin":false},"repo":{"id":8085518,"name":"Cinder","full_name":"pizthewiz/Cinder","owner":{"login":"pizthewiz","id":648369,"avatar_url":"https://avatars.githubusercontent.com/u/648369?v=2","gravatar_id":"9005281d142d2e0b17b966c51f5f6818","url":"https://api.github.com/users/pizthewiz","html_url":"https://github.com/pizthewiz","followers_url":"https://api.github.com/users/pizthewiz/followers","following_url":"https://api.github.com/users/pizthewiz/following{/other_user}","gists_url":"https://api.github.com/users/pizthewiz/gists{/gist_id}","starred_url":"https://api.github.com/users/pizthewiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pizthewiz/subscriptions","organizations_url":"https://api.github.com/users/pizthewiz/orgs","repos_url":"https://api.github.com/users/pizthewiz/repos","events_url":"https://api.github.com/users/pizthewiz/events{/privacy}","received_events_url":"https://api.github.com/users/pizthewiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pizthewiz/Cinder","description":"Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.","fork":true,"url":"https://api.github.com/repos/pizthewiz/Cinder","forks_url":"https://api.github.com/repos/pizthewiz/Cinder/forks","keys_url":"https://api.github.com/repos/pizthewiz/Cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pizthewiz/Cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pizthewiz/Cinder/teams","hooks_url":"https://api.github.com/repos/pizthewiz/Cinder/hooks","issue_events_url":"https://api.github.com/repos/pizthewiz/Cinder/issues/events{/number}","events_url":"https://api.github.com/repos/pizthewiz/Cinder/events","assignees_url":"https://api.github.com/repos/pizthewiz/Cinder/assignees{/user}","branches_url":"https://api.github.com/repos/pizthewiz/Cinder/branches{/branch}","tags_url":"https://api.github.com/repos/pizthewiz/Cinder/tags","blobs_url":"https://api.github.com/repos/pizthewiz/Cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pizthewiz/Cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pizthewiz/Cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/pizthewiz/Cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pizthewiz/Cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/pizthewiz/Cinder/languages","stargazers_url":"https://api.github.com/repos/pizthewiz/Cinder/stargazers","contributors_url":"https://api.github.com/repos/pizthewiz/Cinder/contributors","subscribers_url":"https://api.github.com/repos/pizthewiz/Cinder/subscribers","subscription_url":"https://api.github.com/repos/pizthewiz/Cinder/subscription","commits_url":"https://api.github.com/repos/pizthewiz/Cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/pizthewiz/Cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/pizthewiz/Cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/pizthewiz/Cinder/issues/comments/{number}","contents_url":"https://api.github.com/repos/pizthewiz/Cinder/contents/{+path}","compare_url":"https://api.github.com/repos/pizthewiz/Cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pizthewiz/Cinder/merges","archive_url":"https://api.github.com/repos/pizthewiz/Cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pizthewiz/Cinder/downloads","issues_url":"https://api.github.com/repos/pizthewiz/Cinder/issues{/number}","pulls_url":"https://api.github.com/repos/pizthewiz/Cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/pizthewiz/Cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/pizthewiz/Cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pizthewiz/Cinder/labels{/name}","releases_url":"https://api.github.com/repos/pizthewiz/Cinder/releases{/id}","created_at":"2013-02-08T01:29:25Z","updated_at":"2014-08-09T01:50:03Z","pushed_at":"2014-08-09T02:03:48Z","git_url":"git://github.com/pizthewiz/Cinder.git","ssh_url":"git@github.com:pizthewiz/Cinder.git","clone_url":"https://github.com/pizthewiz/Cinder.git","svn_url":"https://github.com/pizthewiz/Cinder","homepage":"http://libcinder.org","size":200716,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cinder:master","ref":"master","sha":"771414b65517d21e46f9646eed8fdb0b4e94c4bd","user":{"login":"cinder","id":154586,"avatar_url":"https://avatars.githubusercontent.com/u/154586?v=2","gravatar_id":"c16d641d2ea099de276408af0c88e98e","url":"https://api.github.com/users/cinder","html_url":"https://github.com/cinder","followers_url":"https://api.github.com/users/cinder/followers","following_url":"https://api.github.com/users/cinder/following{/other_user}","gists_url":"https://api.github.com/users/cinder/gists{/gist_id}","starred_url":"https://api.github.com/users/cinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinder/subscriptions","organizations_url":"https://api.github.com/users/cinder/orgs","repos_url":"https://api.github.com/users/cinder/repos","events_url":"https://api.github.com/users/cinder/events{/privacy}","received_events_url":"https://api.github.com/users/cinder/received_events","type":"User","site_admin":false},"repo":{"id":622127,"name":"Cinder","full_name":"cinder/Cinder","owner":{"login":"cinder","id":154586,"avatar_url":"https://avatars.githubusercontent.com/u/154586?v=2","gravatar_id":"c16d641d2ea099de276408af0c88e98e","url":"https://api.github.com/users/cinder","html_url":"https://github.com/cinder","followers_url":"https://api.github.com/users/cinder/followers","following_url":"https://api.github.com/users/cinder/following{/other_user}","gists_url":"https://api.github.com/users/cinder/gists{/gist_id}","starred_url":"https://api.github.com/users/cinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinder/subscriptions","organizations_url":"https://api.github.com/users/cinder/orgs","repos_url":"https://api.github.com/users/cinder/repos","events_url":"https://api.github.com/users/cinder/events{/privacy}","received_events_url":"https://api.github.com/users/cinder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cinder/Cinder","description":"Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.","fork":false,"url":"https://api.github.com/repos/cinder/Cinder","forks_url":"https://api.github.com/repos/cinder/Cinder/forks","keys_url":"https://api.github.com/repos/cinder/Cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cinder/Cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cinder/Cinder/teams","hooks_url":"https://api.github.com/repos/cinder/Cinder/hooks","issue_events_url":"https://api.github.com/repos/cinder/Cinder/issues/events{/number}","events_url":"https://api.github.com/repos/cinder/Cinder/events","assignees_url":"https://api.github.com/repos/cinder/Cinder/assignees{/user}","branches_url":"https://api.github.com/repos/cinder/Cinder/branches{/branch}","tags_url":"https://api.github.com/repos/cinder/Cinder/tags","blobs_url":"https://api.github.com/repos/cinder/Cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cinder/Cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cinder/Cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/cinder/Cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cinder/Cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/cinder/Cinder/languages","stargazers_url":"https://api.github.com/repos/cinder/Cinder/stargazers","contributors_url":"https://api.github.com/repos/cinder/Cinder/contributors","subscribers_url":"https://api.github.com/repos/cinder/Cinder/subscribers","subscription_url":"https://api.github.com/repos/cinder/Cinder/subscription","commits_url":"https://api.github.com/repos/cinder/Cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/cinder/Cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/cinder/Cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/cinder/Cinder/issues/comments/{number}","contents_url":"https://api.github.com/repos/cinder/Cinder/contents/{+path}","compare_url":"https://api.github.com/repos/cinder/Cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cinder/Cinder/merges","archive_url":"https://api.github.com/repos/cinder/Cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cinder/Cinder/downloads","issues_url":"https://api.github.com/repos/cinder/Cinder/issues{/number}","pulls_url":"https://api.github.com/repos/cinder/Cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/cinder/Cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/cinder/Cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cinder/Cinder/labels{/name}","releases_url":"https://api.github.com/repos/cinder/Cinder/releases{/id}","created_at":"2010-04-21T19:03:10Z","updated_at":"2014-08-09T20:09:03Z","pushed_at":"2014-08-10T04:19:53Z","git_url":"git://github.com/cinder/Cinder.git","ssh_url":"git@github.com:cinder/Cinder.git","clone_url":"https://github.com/cinder/Cinder.git","svn_url":"https://github.com/cinder/Cinder","homepage":"http://libcinder.org","size":296231,"stargazers_count":1689,"watchers_count":1689,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":383,"mirror_url":null,"open_issues_count":78,"forks":383,"open_issues":78,"watchers":1689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/480"},"html":{"href":"https://github.com/cinder/Cinder/pull/480"},"issue":{"href":"https://api.github.com/repos/cinder/Cinder/issues/480"},"comments":{"href":"https://api.github.com/repos/cinder/Cinder/issues/480/comments"},"review_comments":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/480/comments"},"review_comment":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/480/commits"},"statuses":{"href":"https://api.github.com/repos/cinder/Cinder/statuses/6e196dfafccd97e16fcb2061663c880f4b066322"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"richardeakin","id":5132127,"avatar_url":"https://avatars.githubusercontent.com/u/5132127?v=2","gravatar_id":"ec95b52e26c06cd068b80cdfeb03525e","url":"https://api.github.com/users/richardeakin","html_url":"https://github.com/richardeakin","followers_url":"https://api.github.com/users/richardeakin/followers","following_url":"https://api.github.com/users/richardeakin/following{/other_user}","gists_url":"https://api.github.com/users/richardeakin/gists{/gist_id}","starred_url":"https://api.github.com/users/richardeakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardeakin/subscriptions","organizations_url":"https://api.github.com/users/richardeakin/orgs","repos_url":"https://api.github.com/users/richardeakin/repos","events_url":"https://api.github.com/users/richardeakin/events{/privacy}","received_events_url":"https://api.github.com/users/richardeakin/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}