GitHub PullRequestReviewCommentEvent at 2014-10-30 03:35:24
Repository: puppet-openstack-cloud
Actor: Spredzy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls/comments/19586431","id":19586431,"diff_hunk":"@@ -36,4 +36,10 @@\n     heat_watch_server_url         => \"${ks_heat_public_proto}://${ks_heat_public_host}:${ks_heat_cloudwatch_public_port}\"\n   }\n \n+  # to avoid bug https://bugs.launchpad.net/heat/+bug/1306665\n+  keystone_user_role { 'admin@admin':","path":"manifests/orchestration/engine.pp","position":5,"original_position":5,"commit_id":"2d2fb0a29e0aef1331d4d38a7bd3f98cba86b0c6","original_commit_id":"2d2fb0a29e0aef1331d4d38a7bd3f98cba86b0c6","user":{"login":"Spredzy","id":1191411,"avatar_url":"https://avatars.githubusercontent.com/u/1191411?v=2","gravatar_id":"","url":"https://api.github.com/users/Spredzy","html_url":"https://github.com/Spredzy","followers_url":"https://api.github.com/users/Spredzy/followers","following_url":"https://api.github.com/users/Spredzy/following{/other_user}","gists_url":"https://api.github.com/users/Spredzy/gists{/gist_id}","starred_url":"https://api.github.com/users/Spredzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spredzy/subscriptions","organizations_url":"https://api.github.com/users/Spredzy/orgs","repos_url":"https://api.github.com/users/Spredzy/repos","events_url":"https://api.github.com/users/Spredzy/events{/privacy}","received_events_url":"https://api.github.com/users/Spredzy/received_events","type":"User","site_admin":false},"body":"Shouldn't we parametrize this parameter. The admin tenant might be different from admin (https://github.com/enovance/openstack-yaml-infra/blob/master/example.yml#L107), if we set it to another value, we should be able to specify it here","created_at":"2014-10-30T03:35:24Z","updated_at":"2014-10-30T03:35:24Z","html_url":"https://github.com/enovance/puppet-openstack-cloud/pull/706#discussion_r19586431","pull_request_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls/706","_links":{"self":{"href":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls/comments/19586431"},"html":{"href":"https://github.com/enovance/puppet-openstack-cloud/pull/706#discussion_r19586431"},"pull_request":{"href":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls/706"}}},"pull_request":{"url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls/706","id":23578870,"html_url":"https://github.com/enovance/puppet-openstack-cloud/pull/706","diff_url":"https://github.com/enovance/puppet-openstack-cloud/pull/706.diff","patch_url":"https://github.com/enovance/puppet-openstack-cloud/pull/706.patch","issue_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/issues/706","number":706,"state":"open","locked":false,"title":"heat: ensure admin has heat_stack_owner role","user":{"login":"EmilienM","id":1688225,"avatar_url":"https://avatars.githubusercontent.com/u/1688225?v=2","gravatar_id":"","url":"https://api.github.com/users/EmilienM","html_url":"https://github.com/EmilienM","followers_url":"https://api.github.com/users/EmilienM/followers","following_url":"https://api.github.com/users/EmilienM/following{/other_user}","gists_url":"https://api.github.com/users/EmilienM/gists{/gist_id}","starred_url":"https://api.github.com/users/EmilienM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmilienM/subscriptions","organizations_url":"https://api.github.com/users/EmilienM/orgs","repos_url":"https://api.github.com/users/EmilienM/repos","events_url":"https://api.github.com/users/EmilienM/events{/privacy}","received_events_url":"https://api.github.com/users/EmilienM/received_events","type":"User","site_admin":false},"body":"To avoid a bug in Heat [1], ensure \"admin\" user from \"admin\" tenant has\r\n\"heat_stack_owner\" role.\r\n\r\n[1] https://bugs.launchpad.net/heat/+bug/1306665","created_at":"2014-10-30T02:17:34Z","updated_at":"2014-10-30T03:35:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a39c917031c4957318bf31033fb8e68656456ee4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls/706/commits","review_comments_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls/706/comments","review_comment_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls/comments/{number}","comments_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/issues/706/comments","statuses_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/statuses/2d2fb0a29e0aef1331d4d38a7bd3f98cba86b0c6","head":{"label":"enovance:heat_role","ref":"heat_role","sha":"2d2fb0a29e0aef1331d4d38a7bd3f98cba86b0c6","user":{"login":"enovance","id":1607795,"avatar_url":"https://avatars.githubusercontent.com/u/1607795?v=2","gravatar_id":"","url":"https://api.github.com/users/enovance","html_url":"https://github.com/enovance","followers_url":"https://api.github.com/users/enovance/followers","following_url":"https://api.github.com/users/enovance/following{/other_user}","gists_url":"https://api.github.com/users/enovance/gists{/gist_id}","starred_url":"https://api.github.com/users/enovance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enovance/subscriptions","organizations_url":"https://api.github.com/users/enovance/orgs","repos_url":"https://api.github.com/users/enovance/repos","events_url":"https://api.github.com/users/enovance/events{/privacy}","received_events_url":"https://api.github.com/users/enovance/received_events","type":"Organization","site_admin":false},"repo":{"id":15908021,"name":"puppet-openstack-cloud","full_name":"enovance/puppet-openstack-cloud","owner":{"login":"enovance","id":1607795,"avatar_url":"https://avatars.githubusercontent.com/u/1607795?v=2","gravatar_id":"","url":"https://api.github.com/users/enovance","html_url":"https://github.com/enovance","followers_url":"https://api.github.com/users/enovance/followers","following_url":"https://api.github.com/users/enovance/following{/other_user}","gists_url":"https://api.github.com/users/enovance/gists{/gist_id}","starred_url":"https://api.github.com/users/enovance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enovance/subscriptions","organizations_url":"https://api.github.com/users/enovance/orgs","repos_url":"https://api.github.com/users/enovance/repos","events_url":"https://api.github.com/users/enovance/events{/privacy}","received_events_url":"https://api.github.com/users/enovance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enovance/puppet-openstack-cloud","description":"Flexible Puppet implementation capable of configuring a scalable OpenStack Cloud.","fork":false,"url":"https://api.github.com/repos/enovance/puppet-openstack-cloud","forks_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/forks","keys_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/teams","hooks_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/hooks","issue_events_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/events","assignees_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/tags","blobs_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/languages","stargazers_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/stargazers","contributors_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/contributors","subscribers_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/subscribers","subscription_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/subscription","commits_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/issues/comments/{number}","contents_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/merges","archive_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/downloads","issues_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/labels{/name}","releases_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/releases{/id}","created_at":"2014-01-14T16:31:49Z","updated_at":"2014-10-01T20:40:06Z","pushed_at":"2014-10-30T02:17:09Z","git_url":"git://github.com/enovance/puppet-openstack-cloud.git","ssh_url":"git@github.com:enovance/puppet-openstack-cloud.git","clone_url":"https://github.com/enovance/puppet-openstack-cloud.git","svn_url":"https://github.com/enovance/puppet-openstack-cloud","homepage":"","size":16595,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":33,"forks":11,"open_issues":33,"watchers":15,"default_branch":"master"}},"base":{"label":"enovance:master","ref":"master","sha":"2e482d275e4543e513a52eeec1404c799d919e7a","user":{"login":"enovance","id":1607795,"avatar_url":"https://avatars.githubusercontent.com/u/1607795?v=2","gravatar_id":"","url":"https://api.github.com/users/enovance","html_url":"https://github.com/enovance","followers_url":"https://api.github.com/users/enovance/followers","following_url":"https://api.github.com/users/enovance/following{/other_user}","gists_url":"https://api.github.com/users/enovance/gists{/gist_id}","starred_url":"https://api.github.com/users/enovance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enovance/subscriptions","organizations_url":"https://api.github.com/users/enovance/orgs","repos_url":"https://api.github.com/users/enovance/repos","events_url":"https://api.github.com/users/enovance/events{/privacy}","received_events_url":"https://api.github.com/users/enovance/received_events","type":"Organization","site_admin":false},"repo":{"id":15908021,"name":"puppet-openstack-cloud","full_name":"enovance/puppet-openstack-cloud","owner":{"login":"enovance","id":1607795,"avatar_url":"https://avatars.githubusercontent.com/u/1607795?v=2","gravatar_id":"","url":"https://api.github.com/users/enovance","html_url":"https://github.com/enovance","followers_url":"https://api.github.com/users/enovance/followers","following_url":"https://api.github.com/users/enovance/following{/other_user}","gists_url":"https://api.github.com/users/enovance/gists{/gist_id}","starred_url":"https://api.github.com/users/enovance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enovance/subscriptions","organizations_url":"https://api.github.com/users/enovance/orgs","repos_url":"https://api.github.com/users/enovance/repos","events_url":"https://api.github.com/users/enovance/events{/privacy}","received_events_url":"https://api.github.com/users/enovance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enovance/puppet-openstack-cloud","description":"Flexible Puppet implementation capable of configuring a scalable OpenStack Cloud.","fork":false,"url":"https://api.github.com/repos/enovance/puppet-openstack-cloud","forks_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/forks","keys_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/teams","hooks_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/hooks","issue_events_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/events","assignees_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/tags","blobs_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/languages","stargazers_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/stargazers","contributors_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/contributors","subscribers_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/subscribers","subscription_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/subscription","commits_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/issues/comments/{number}","contents_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/merges","archive_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/downloads","issues_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/labels{/name}","releases_url":"https://api.github.com/repos/enovance/puppet-openstack-cloud/releases{/id}","created_at":"2014-01-14T16:31:49Z","updated_at":"2014-10-01T20:40:06Z","pushed_at":"2014-10-30T02:17:09Z","git_url":"git://github.com/enovance/puppet-openstack-cloud.git","ssh_url":"git@github.com:enovance/puppet-openstack-cloud.git","clone_url":"https://github.com/enovance/puppet-openstack-cloud.git","svn_url":"https://github.com/enovance/puppet-openstack-cloud","homepage":"","size":16595,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":33,"forks":11,"open_issues":33,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls/706"},"html":{"href":"https://github.com/enovance/puppet-openstack-cloud/pull/706"},"issue":{"href":"https://api.github.com/repos/enovance/puppet-openstack-cloud/issues/706"},"comments":{"href":"https://api.github.com/repos/enovance/puppet-openstack-cloud/issues/706/comments"},"review_comments":{"href":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls/706/comments"},"review_comment":{"href":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/enovance/puppet-openstack-cloud/pulls/706/commits"},"statuses":{"href":"https://api.github.com/repos/enovance/puppet-openstack-cloud/statuses/2d2fb0a29e0aef1331d4d38a7bd3f98cba86b0c6"}}}}