GitHub PullRequestEvent at 2014-12-08 21:23:19
Repository: quamash
Actor: harvimt
Payload: {"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/harvimt/quamash/pulls/9","id":25084505,"html_url":"https://github.com/harvimt/quamash/pull/9","diff_url":"https://github.com/harvimt/quamash/pull/9.diff","patch_url":"https://github.com/harvimt/quamash/pull/9.patch","issue_url":"https://api.github.com/repos/harvimt/quamash/issues/9","number":9,"state":"closed","locked":false,"title":"Disable QSocketNotifier during reader/writer callbacks + ignored finished Futures","user":{"login":"aknuds1","id":281303,"avatar_url":"https://avatars.githubusercontent.com/u/281303?v=3","gravatar_id":"","url":"https://api.github.com/users/aknuds1","html_url":"https://github.com/aknuds1","followers_url":"https://api.github.com/users/aknuds1/followers","following_url":"https://api.github.com/users/aknuds1/following{/other_user}","gists_url":"https://api.github.com/users/aknuds1/gists{/gist_id}","starred_url":"https://api.github.com/users/aknuds1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aknuds1/subscriptions","organizations_url":"https://api.github.com/users/aknuds1/orgs","repos_url":"https://api.github.com/users/aknuds1/repos","events_url":"https://api.github.com/users/aknuds1/events{/privacy}","received_events_url":"https://api.github.com/users/aknuds1/received_events","type":"User","site_admin":false},"body":"In order to integrate properly with ZeroMQ, I discovered I had to disable QSocketNotifier before polling a corresponding ZeroMQ socket. I decided to do this before calling reader/writer callbacks registered with add_reader/add_writer, since this is typically where you poll ZeroMQ. I hope this won't cause problems for any other scenarios, but I can't see why it should, really.\r\n\r\nIt also turned out Python 3.4.2 unearthed some issues due to mutating Futures that are in the finished state, which I've taken care of.","created_at":"2014-11-26T13:45:21Z","updated_at":"2014-12-08T21:23:19Z","closed_at":"2014-12-08T21:23:19Z","merged_at":"2014-12-08T21:23:19Z","merge_commit_sha":"425f9620ee0949ed4b9a191888df451cc0b3ab6a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/harvimt/quamash/pulls/9/commits","review_comments_url":"https://api.github.com/repos/harvimt/quamash/pulls/9/comments","review_comment_url":"https://api.github.com/repos/harvimt/quamash/pulls/comments/{number}","comments_url":"https://api.github.com/repos/harvimt/quamash/issues/9/comments","statuses_url":"https://api.github.com/repos/harvimt/quamash/statuses/43256c066434f62da23a8480c6919ac956e4f12d","head":{"label":"aknuds1:master","ref":"master","sha":"43256c066434f62da23a8480c6919ac956e4f12d","user":{"login":"aknuds1","id":281303,"avatar_url":"https://avatars.githubusercontent.com/u/281303?v=3","gravatar_id":"","url":"https://api.github.com/users/aknuds1","html_url":"https://github.com/aknuds1","followers_url":"https://api.github.com/users/aknuds1/followers","following_url":"https://api.github.com/users/aknuds1/following{/other_user}","gists_url":"https://api.github.com/users/aknuds1/gists{/gist_id}","starred_url":"https://api.github.com/users/aknuds1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aknuds1/subscriptions","organizations_url":"https://api.github.com/users/aknuds1/orgs","repos_url":"https://api.github.com/users/aknuds1/repos","events_url":"https://api.github.com/users/aknuds1/events{/privacy}","received_events_url":"https://api.github.com/users/aknuds1/received_events","type":"User","site_admin":false},"repo":{"id":21266562,"name":"quamash","full_name":"aknuds1/quamash","owner":{"login":"aknuds1","id":281303,"avatar_url":"https://avatars.githubusercontent.com/u/281303?v=3","gravatar_id":"","url":"https://api.github.com/users/aknuds1","html_url":"https://github.com/aknuds1","followers_url":"https://api.github.com/users/aknuds1/followers","following_url":"https://api.github.com/users/aknuds1/following{/other_user}","gists_url":"https://api.github.com/users/aknuds1/gists{/gist_id}","starred_url":"https://api.github.com/users/aknuds1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aknuds1/subscriptions","organizations_url":"https://api.github.com/users/aknuds1/orgs","repos_url":"https://api.github.com/users/aknuds1/repos","events_url":"https://api.github.com/users/aknuds1/events{/privacy}","received_events_url":"https://api.github.com/users/aknuds1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aknuds1/quamash","description":"Implementation of the Python asyncio event-loop api on top of Qt","fork":true,"url":"https://api.github.com/repos/aknuds1/quamash","forks_url":"https://api.github.com/repos/aknuds1/quamash/forks","keys_url":"https://api.github.com/repos/aknuds1/quamash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aknuds1/quamash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aknuds1/quamash/teams","hooks_url":"https://api.github.com/repos/aknuds1/quamash/hooks","issue_events_url":"https://api.github.com/repos/aknuds1/quamash/issues/events{/number}","events_url":"https://api.github.com/repos/aknuds1/quamash/events","assignees_url":"https://api.github.com/repos/aknuds1/quamash/assignees{/user}","branches_url":"https://api.github.com/repos/aknuds1/quamash/branches{/branch}","tags_url":"https://api.github.com/repos/aknuds1/quamash/tags","blobs_url":"https://api.github.com/repos/aknuds1/quamash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aknuds1/quamash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aknuds1/quamash/git/refs{/sha}","trees_url":"https://api.github.com/repos/aknuds1/quamash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aknuds1/quamash/statuses/{sha}","languages_url":"https://api.github.com/repos/aknuds1/quamash/languages","stargazers_url":"https://api.github.com/repos/aknuds1/quamash/stargazers","contributors_url":"https://api.github.com/repos/aknuds1/quamash/contributors","subscribers_url":"https://api.github.com/repos/aknuds1/quamash/subscribers","subscription_url":"https://api.github.com/repos/aknuds1/quamash/subscription","commits_url":"https://api.github.com/repos/aknuds1/quamash/commits{/sha}","git_commits_url":"https://api.github.com/repos/aknuds1/quamash/git/commits{/sha}","comments_url":"https://api.github.com/repos/aknuds1/quamash/comments{/number}","issue_comment_url":"https://api.github.com/repos/aknuds1/quamash/issues/comments/{number}","contents_url":"https://api.github.com/repos/aknuds1/quamash/contents/{+path}","compare_url":"https://api.github.com/repos/aknuds1/quamash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aknuds1/quamash/merges","archive_url":"https://api.github.com/repos/aknuds1/quamash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aknuds1/quamash/downloads","issues_url":"https://api.github.com/repos/aknuds1/quamash/issues{/number}","pulls_url":"https://api.github.com/repos/aknuds1/quamash/pulls{/number}","milestones_url":"https://api.github.com/repos/aknuds1/quamash/milestones{/number}","notifications_url":"https://api.github.com/repos/aknuds1/quamash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aknuds1/quamash/labels{/name}","releases_url":"https://api.github.com/repos/aknuds1/quamash/releases{/id}","created_at":"2014-06-27T06:42:19Z","updated_at":"2014-12-08T18:54:52Z","pushed_at":"2014-12-08T18:54:52Z","git_url":"git://github.com/aknuds1/quamash.git","ssh_url":"git@github.com:aknuds1/quamash.git","clone_url":"https://github.com/aknuds1/quamash.git","svn_url":"https://github.com/aknuds1/quamash","homepage":"","size":570,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"harvimt:master","ref":"master","sha":"a781e77c8a19b1d05e96b9a837c9f80c71e86d88","user":{"login":"harvimt","id":119106,"avatar_url":"https://avatars.githubusercontent.com/u/119106?v=3","gravatar_id":"","url":"https://api.github.com/users/harvimt","html_url":"https://github.com/harvimt","followers_url":"https://api.github.com/users/harvimt/followers","following_url":"https://api.github.com/users/harvimt/following{/other_user}","gists_url":"https://api.github.com/users/harvimt/gists{/gist_id}","starred_url":"https://api.github.com/users/harvimt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvimt/subscriptions","organizations_url":"https://api.github.com/users/harvimt/orgs","repos_url":"https://api.github.com/users/harvimt/repos","events_url":"https://api.github.com/users/harvimt/events{/privacy}","received_events_url":"https://api.github.com/users/harvimt/received_events","type":"User","site_admin":false},"repo":{"id":10632220,"name":"quamash","full_name":"harvimt/quamash","owner":{"login":"harvimt","id":119106,"avatar_url":"https://avatars.githubusercontent.com/u/119106?v=3","gravatar_id":"","url":"https://api.github.com/users/harvimt","html_url":"https://github.com/harvimt","followers_url":"https://api.github.com/users/harvimt/followers","following_url":"https://api.github.com/users/harvimt/following{/other_user}","gists_url":"https://api.github.com/users/harvimt/gists{/gist_id}","starred_url":"https://api.github.com/users/harvimt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvimt/subscriptions","organizations_url":"https://api.github.com/users/harvimt/orgs","repos_url":"https://api.github.com/users/harvimt/repos","events_url":"https://api.github.com/users/harvimt/events{/privacy}","received_events_url":"https://api.github.com/users/harvimt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harvimt/quamash","description":"Implementation of the PEP 3156 event-loop (tulip) api using the Qt Event-Loop","fork":false,"url":"https://api.github.com/repos/harvimt/quamash","forks_url":"https://api.github.com/repos/harvimt/quamash/forks","keys_url":"https://api.github.com/repos/harvimt/quamash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harvimt/quamash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harvimt/quamash/teams","hooks_url":"https://api.github.com/repos/harvimt/quamash/hooks","issue_events_url":"https://api.github.com/repos/harvimt/quamash/issues/events{/number}","events_url":"https://api.github.com/repos/harvimt/quamash/events","assignees_url":"https://api.github.com/repos/harvimt/quamash/assignees{/user}","branches_url":"https://api.github.com/repos/harvimt/quamash/branches{/branch}","tags_url":"https://api.github.com/repos/harvimt/quamash/tags","blobs_url":"https://api.github.com/repos/harvimt/quamash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harvimt/quamash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harvimt/quamash/git/refs{/sha}","trees_url":"https://api.github.com/repos/harvimt/quamash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harvimt/quamash/statuses/{sha}","languages_url":"https://api.github.com/repos/harvimt/quamash/languages","stargazers_url":"https://api.github.com/repos/harvimt/quamash/stargazers","contributors_url":"https://api.github.com/repos/harvimt/quamash/contributors","subscribers_url":"https://api.github.com/repos/harvimt/quamash/subscribers","subscription_url":"https://api.github.com/repos/harvimt/quamash/subscription","commits_url":"https://api.github.com/repos/harvimt/quamash/commits{/sha}","git_commits_url":"https://api.github.com/repos/harvimt/quamash/git/commits{/sha}","comments_url":"https://api.github.com/repos/harvimt/quamash/comments{/number}","issue_comment_url":"https://api.github.com/repos/harvimt/quamash/issues/comments/{number}","contents_url":"https://api.github.com/repos/harvimt/quamash/contents/{+path}","compare_url":"https://api.github.com/repos/harvimt/quamash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harvimt/quamash/merges","archive_url":"https://api.github.com/repos/harvimt/quamash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harvimt/quamash/downloads","issues_url":"https://api.github.com/repos/harvimt/quamash/issues{/number}","pulls_url":"https://api.github.com/repos/harvimt/quamash/pulls{/number}","milestones_url":"https://api.github.com/repos/harvimt/quamash/milestones{/number}","notifications_url":"https://api.github.com/repos/harvimt/quamash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harvimt/quamash/labels{/name}","releases_url":"https://api.github.com/repos/harvimt/quamash/releases{/id}","created_at":"2013-06-11T22:26:29Z","updated_at":"2014-12-08T21:23:19Z","pushed_at":"2014-12-08T21:23:19Z","git_url":"git://github.com/harvimt/quamash.git","ssh_url":"git@github.com:harvimt/quamash.git","clone_url":"https://github.com/harvimt/quamash.git","svn_url":"https://github.com/harvimt/quamash","homepage":"","size":13324,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/harvimt/quamash/pulls/9"},"html":{"href":"https://github.com/harvimt/quamash/pull/9"},"issue":{"href":"https://api.github.com/repos/harvimt/quamash/issues/9"},"comments":{"href":"https://api.github.com/repos/harvimt/quamash/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/harvimt/quamash/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/harvimt/quamash/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/harvimt/quamash/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/harvimt/quamash/statuses/43256c066434f62da23a8480c6919ac956e4f12d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"harvimt","id":119106,"avatar_url":"https://avatars.githubusercontent.com/u/119106?v=3","gravatar_id":"","url":"https://api.github.com/users/harvimt","html_url":"https://github.com/harvimt","followers_url":"https://api.github.com/users/harvimt/followers","following_url":"https://api.github.com/users/harvimt/following{/other_user}","gists_url":"https://api.github.com/users/harvimt/gists{/gist_id}","starred_url":"https://api.github.com/users/harvimt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvimt/subscriptions","organizations_url":"https://api.github.com/users/harvimt/orgs","repos_url":"https://api.github.com/users/harvimt/repos","events_url":"https://api.github.com/users/harvimt/events{/privacy}","received_events_url":"https://api.github.com/users/harvimt/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":17,"deletions":5,"changed_files":2}}