GitHub PullRequestReviewCommentEvent at 2014-05-02 12:11:42
Repository: turkserver-meteor
Actor: kcarnold
Payload: {"comment":{"url":"https://api.github.com/repos/HarvardEconCS/turkserver-meteor/pulls/comments/12226631","id":12226631,"diff_hunk":"@@ -27,6 +27,10 @@ TurkServer.isAdmin = ->\n TurkServer.treatment = ->\n   Experiments.findOne({}, fields: {treatment: 1})?.treatment\n \n+TurkServer.batch = ->","path":"client/ts_client.coffee","position":4,"original_position":4,"commit_id":"f7a36cc88343d9c68c296d8ce5dbf029a37cc103","original_commit_id":"f7a36cc88343d9c68c296d8ce5dbf029a37cc103","user":{"login":"kcarnold","id":21072,"avatar_url":"https://avatars.githubusercontent.com/u/21072?","gravatar_id":"76099ad85a686ffb8b116c361d7b0af4","url":"https://api.github.com/users/kcarnold","html_url":"https://github.com/kcarnold","followers_url":"https://api.github.com/users/kcarnold/followers","following_url":"https://api.github.com/users/kcarnold/following{/other_user}","gists_url":"https://api.github.com/users/kcarnold/gists{/gist_id}","starred_url":"https://api.github.com/users/kcarnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcarnold/subscriptions","organizations_url":"https://api.github.com/users/kcarnold/orgs","repos_url":"https://api.github.com/users/kcarnold/repos","events_url":"https://api.github.com/users/kcarnold/events{/privacy}","received_events_url":"https://api.github.com/users/kcarnold/received_events","type":"User","site_admin":false},"body":"Publishing all batches seemed the easiest way to make the testing login be\r\nable to show all of the batch options.\r\n\r\nThe client needs to know the current batch so that it can route to the\r\ncorrect place on startup. Using the batch object instead of just changing\r\nthe external question URL allows it to use structured data on the batch\r\nobject (which I currently just shove into the description field so it's\r\nvisible).\r\nOn May 2, 2014 2:06 AM, \"Andrew Mao\" <notifications@github.com> wrote:\r\n\r\n> In client/ts_client.coffee:\r\n>\r\n> > @@ -27,6 +27,10 @@ TurkServer.isAdmin = ->\r\n> >  TurkServer.treatment = ->\r\n> >    Experiments.findOne({}, fields: {treatment: 1})?.treatment\r\n> >\r\n> > +TurkServer.batch = ->\r\n>\r\n> Hmm - what if we just publish a single batch to each user instead of all\r\n> of them? Why do they even need to know about the batch at all?\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub<https://github.com/HarvardEconCS/turkserver-meteor/pull/8/files#r12220425>\r\n> .\r\n>","created_at":"2014-05-02T12:11:42Z","updated_at":"2014-05-02T12:11:42Z","html_url":"https://github.com/HarvardEconCS/turkserver-meteor/pull/8#discussion_r12226631","pull_request_url":"https://api.github.com/repos/HarvardEconCS/turkserver-meteor/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/HarvardEconCS/turkserver-meteor/pulls/comments/12226631"},"html":{"href":"https://github.com/HarvardEconCS/turkserver-meteor/pull/8#discussion_r12226631"},"pull_request":{"href":"https://api.github.com/repos/HarvardEconCS/turkserver-meteor/pulls/8"}}}}