GitHub PullRequestReviewCommentEvent at 2014-01-02 22:22:56
Repository: chefspec
Actor: geraud
Payload: {"comment":{"url":"https://api.github.com/repos/sethvargo/chefspec/pulls/comments/8625061","id":8625061,"diff_hunk":"@@ -69,6 +69,9 @@ def content_from_template(chef_run, template)\n             :node => chef_run.node,\n             :template_finder => template_finder(chef_run, cookbook_name),\n           }.merge(template.variables))\n+          template.helper_modules.each do |helper_module|","path":"lib/chefspec/renderer.rb","position":4,"original_position":4,"commit_id":"07c45e9102b6c00f90372e8aeeffbd99a04c8b01","original_commit_id":"9730a249bf14c057decf7dcd0852f1fb400a1a29","user":{"login":"geraud","id":36405,"avatar_url":"https://gravatar.com/avatar/5a6b820ebf96fb1964103a23e5a6e901?d=https%3A%2F%2Fidenticons.github.com%2F95d89f1aafa28ac92eb3963212571e04.png&r=x","gravatar_id":"5a6b820ebf96fb1964103a23e5a6e901","url":"https://api.github.com/users/geraud","html_url":"https://github.com/geraud","followers_url":"https://api.github.com/users/geraud/followers","following_url":"https://api.github.com/users/geraud/following{/other_user}","gists_url":"https://api.github.com/users/geraud/gists{/gist_id}","starred_url":"https://api.github.com/users/geraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geraud/subscriptions","organizations_url":"https://api.github.com/users/geraud/orgs","repos_url":"https://api.github.com/users/geraud/repos","events_url":"https://api.github.com/users/geraud/events{/privacy}","received_events_url":"https://api.github.com/users/geraud/received_events","type":"User","site_admin":false},"body":"I was looking for explicit guards in the code. I am changing the code and I\r\nwill send an updated PR\r\n\r\n\r\nOn Thu, Jan 2, 2014 at 2:13 PM, Seth Vargo <notifications@github.com> wrote:\r\n\r\n> In lib/chefspec/renderer.rb:\r\n>\r\n> > @@ -69,6 +69,9 @@ def content_from_template(chef_run, template)\r\n> >              :node => chef_run.node,\r\n> >              :template_finder => template_finder(chef_run, cookbook_name),\r\n> >            }.merge(template.variables))\r\n> > +          template.helper_modules.each do |helper_module|\r\n>\r\n> You'll need to surround this with something like:\r\n>\r\n> if template.respond_to?(:helper_modules)\r\n>   # ...end\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub<https://github.com/sethvargo/chefspec/pull/294/files#r8624784>\r\n> .\r\n>","created_at":"2014-01-02T22:22:56Z","updated_at":"2014-01-02T22:22:56Z","html_url":"https://github.com/sethvargo/chefspec/pull/294#discussion_r8625061","pull_request_url":"https://api.github.com/repos/sethvargo/chefspec/pulls/294","_links":{"self":{"href":"https://api.github.com/repos/sethvargo/chefspec/pulls/comments/8625061"},"html":{"href":"https://github.com/sethvargo/chefspec/pull/294#discussion_r8625061"},"pull_request":{"href":"https://api.github.com/repos/sethvargo/chefspec/pulls/294"}}}}