GitHub PullRequestEvent at 2014-10-15 01:02:46
Repository: _s
Actor: obenland
Payload: {"action":"closed","number":633,"pull_request":{"url":"https://api.github.com/repos/Automattic/_s/pulls/633","id":22754824,"html_url":"https://github.com/Automattic/_s/pull/633","diff_url":"https://github.com/Automattic/_s/pull/633.diff","patch_url":"https://github.com/Automattic/_s/pull/633.patch","issue_url":"https://api.github.com/repos/Automattic/_s/issues/633","number":633,"state":"closed","locked":false,"title":"remove unnecessary comparisons","user":{"login":"sdavis2702","id":2359131,"avatar_url":"https://avatars.githubusercontent.com/u/2359131?v=2","gravatar_id":"","url":"https://api.github.com/users/sdavis2702","html_url":"https://github.com/sdavis2702","followers_url":"https://api.github.com/users/sdavis2702/followers","following_url":"https://api.github.com/users/sdavis2702/following{/other_user}","gists_url":"https://api.github.com/users/sdavis2702/gists{/gist_id}","starred_url":"https://api.github.com/users/sdavis2702/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdavis2702/subscriptions","organizations_url":"https://api.github.com/users/sdavis2702/orgs","repos_url":"https://api.github.com/users/sdavis2702/repos","events_url":"https://api.github.com/users/sdavis2702/events{/privacy}","received_events_url":"https://api.github.com/users/sdavis2702/received_events","type":"User","site_admin":false},"body":"See: https://github.com/Automattic/_s/issues/632\r\n\r\nUpon changing these conditionals, I also noticed that it improves theme consistency because this is how it's written in another file already: https://github.com/Automattic/_s/blob/097b54dda282fcdbf23c951889d798e6424979dc/inc/template-tags.php#L116","created_at":"2014-10-15T01:01:13Z","updated_at":"2014-10-15T01:02:45Z","closed_at":"2014-10-15T01:02:44Z","merged_at":"2014-10-15T01:02:44Z","merge_commit_sha":"5ffb98249dd4e91ced7e74f9289c830cb67a72d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/_s/pulls/633/commits","review_comments_url":"https://api.github.com/repos/Automattic/_s/pulls/633/comments","review_comment_url":"https://api.github.com/repos/Automattic/_s/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Automattic/_s/issues/633/comments","statuses_url":"https://api.github.com/repos/Automattic/_s/statuses/5ab860c48b02e090823fa5724deddf714c1d9978","head":{"label":"sdavis2702:master","ref":"master","sha":"5ab860c48b02e090823fa5724deddf714c1d9978","user":{"login":"sdavis2702","id":2359131,"avatar_url":"https://avatars.githubusercontent.com/u/2359131?v=2","gravatar_id":"","url":"https://api.github.com/users/sdavis2702","html_url":"https://github.com/sdavis2702","followers_url":"https://api.github.com/users/sdavis2702/followers","following_url":"https://api.github.com/users/sdavis2702/following{/other_user}","gists_url":"https://api.github.com/users/sdavis2702/gists{/gist_id}","starred_url":"https://api.github.com/users/sdavis2702/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdavis2702/subscriptions","organizations_url":"https://api.github.com/users/sdavis2702/orgs","repos_url":"https://api.github.com/users/sdavis2702/repos","events_url":"https://api.github.com/users/sdavis2702/events{/privacy}","received_events_url":"https://api.github.com/users/sdavis2702/received_events","type":"User","site_admin":false},"repo":{"id":25232829,"name":"_s","full_name":"sdavis2702/_s","owner":{"login":"sdavis2702","id":2359131,"avatar_url":"https://avatars.githubusercontent.com/u/2359131?v=2","gravatar_id":"","url":"https://api.github.com/users/sdavis2702","html_url":"https://github.com/sdavis2702","followers_url":"https://api.github.com/users/sdavis2702/followers","following_url":"https://api.github.com/users/sdavis2702/following{/other_user}","gists_url":"https://api.github.com/users/sdavis2702/gists{/gist_id}","starred_url":"https://api.github.com/users/sdavis2702/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdavis2702/subscriptions","organizations_url":"https://api.github.com/users/sdavis2702/orgs","repos_url":"https://api.github.com/users/sdavis2702/repos","events_url":"https://api.github.com/users/sdavis2702/events{/privacy}","received_events_url":"https://api.github.com/users/sdavis2702/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdavis2702/_s","description":"Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.","fork":true,"url":"https://api.github.com/repos/sdavis2702/_s","forks_url":"https://api.github.com/repos/sdavis2702/_s/forks","keys_url":"https://api.github.com/repos/sdavis2702/_s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdavis2702/_s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdavis2702/_s/teams","hooks_url":"https://api.github.com/repos/sdavis2702/_s/hooks","issue_events_url":"https://api.github.com/repos/sdavis2702/_s/issues/events{/number}","events_url":"https://api.github.com/repos/sdavis2702/_s/events","assignees_url":"https://api.github.com/repos/sdavis2702/_s/assignees{/user}","branches_url":"https://api.github.com/repos/sdavis2702/_s/branches{/branch}","tags_url":"https://api.github.com/repos/sdavis2702/_s/tags","blobs_url":"https://api.github.com/repos/sdavis2702/_s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdavis2702/_s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdavis2702/_s/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdavis2702/_s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdavis2702/_s/statuses/{sha}","languages_url":"https://api.github.com/repos/sdavis2702/_s/languages","stargazers_url":"https://api.github.com/repos/sdavis2702/_s/stargazers","contributors_url":"https://api.github.com/repos/sdavis2702/_s/contributors","subscribers_url":"https://api.github.com/repos/sdavis2702/_s/subscribers","subscription_url":"https://api.github.com/repos/sdavis2702/_s/subscription","commits_url":"https://api.github.com/repos/sdavis2702/_s/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdavis2702/_s/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdavis2702/_s/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdavis2702/_s/issues/comments/{number}","contents_url":"https://api.github.com/repos/sdavis2702/_s/contents/{+path}","compare_url":"https://api.github.com/repos/sdavis2702/_s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdavis2702/_s/merges","archive_url":"https://api.github.com/repos/sdavis2702/_s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdavis2702/_s/downloads","issues_url":"https://api.github.com/repos/sdavis2702/_s/issues{/number}","pulls_url":"https://api.github.com/repos/sdavis2702/_s/pulls{/number}","milestones_url":"https://api.github.com/repos/sdavis2702/_s/milestones{/number}","notifications_url":"https://api.github.com/repos/sdavis2702/_s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdavis2702/_s/labels{/name}","releases_url":"https://api.github.com/repos/sdavis2702/_s/releases{/id}","created_at":"2014-10-15T00:54:45Z","updated_at":"2014-10-15T00:57:30Z","pushed_at":"2014-10-15T00:57:48Z","git_url":"git://github.com/sdavis2702/_s.git","ssh_url":"git@github.com:sdavis2702/_s.git","clone_url":"https://github.com/sdavis2702/_s.git","svn_url":"https://github.com/sdavis2702/_s","homepage":"http://underscores.me/","size":14210,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"348886e168f894cfb9e15b0e02b0c67876b6a667","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=2","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":3327382,"name":"_s","full_name":"Automattic/_s","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=2","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/_s","description":"Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.","fork":false,"url":"https://api.github.com/repos/Automattic/_s","forks_url":"https://api.github.com/repos/Automattic/_s/forks","keys_url":"https://api.github.com/repos/Automattic/_s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/_s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/_s/teams","hooks_url":"https://api.github.com/repos/Automattic/_s/hooks","issue_events_url":"https://api.github.com/repos/Automattic/_s/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/_s/events","assignees_url":"https://api.github.com/repos/Automattic/_s/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/_s/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/_s/tags","blobs_url":"https://api.github.com/repos/Automattic/_s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/_s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/_s/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/_s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/_s/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/_s/languages","stargazers_url":"https://api.github.com/repos/Automattic/_s/stargazers","contributors_url":"https://api.github.com/repos/Automattic/_s/contributors","subscribers_url":"https://api.github.com/repos/Automattic/_s/subscribers","subscription_url":"https://api.github.com/repos/Automattic/_s/subscription","commits_url":"https://api.github.com/repos/Automattic/_s/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/_s/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/_s/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/_s/issues/comments/{number}","contents_url":"https://api.github.com/repos/Automattic/_s/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/_s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/_s/merges","archive_url":"https://api.github.com/repos/Automattic/_s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/_s/downloads","issues_url":"https://api.github.com/repos/Automattic/_s/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/_s/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/_s/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/_s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/_s/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/_s/releases{/id}","created_at":"2012-02-01T17:59:49Z","updated_at":"2014-10-14T19:10:30Z","pushed_at":"2014-10-15T01:02:44Z","git_url":"git://github.com/Automattic/_s.git","ssh_url":"git@github.com:Automattic/_s.git","clone_url":"https://github.com/Automattic/_s.git","svn_url":"https://github.com/Automattic/_s","homepage":"http://underscores.me/","size":14210,"stargazers_count":3995,"watchers_count":3995,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1399,"mirror_url":null,"open_issues_count":25,"forks":1399,"open_issues":25,"watchers":3995,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/_s/pulls/633"},"html":{"href":"https://github.com/Automattic/_s/pull/633"},"issue":{"href":"https://api.github.com/repos/Automattic/_s/issues/633"},"comments":{"href":"https://api.github.com/repos/Automattic/_s/issues/633/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/_s/pulls/633/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/_s/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Automattic/_s/pulls/633/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/_s/statuses/5ab860c48b02e090823fa5724deddf714c1d9978"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"obenland","id":1398304,"avatar_url":"https://avatars.githubusercontent.com/u/1398304?v=2","gravatar_id":"","url":"https://api.github.com/users/obenland","html_url":"https://github.com/obenland","followers_url":"https://api.github.com/users/obenland/followers","following_url":"https://api.github.com/users/obenland/following{/other_user}","gists_url":"https://api.github.com/users/obenland/gists{/gist_id}","starred_url":"https://api.github.com/users/obenland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obenland/subscriptions","organizations_url":"https://api.github.com/users/obenland/orgs","repos_url":"https://api.github.com/users/obenland/repos","events_url":"https://api.github.com/users/obenland/events{/privacy}","received_events_url":"https://api.github.com/users/obenland/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":3,"deletions":3,"changed_files":2}}