GitHub PullRequestReviewCommentEvent at 2014-07-22 12:25:31
Repository: incubator-brooklyn
Actor: sjcorbett
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/15224246","id":15224246,"diff_hunk":"@@ -274,7 +274,7 @@ public String getJmxContext() {\n      */\n     protected boolean checkForAndInstallJava6or7() {\n         Optional<String> version = getCurrentJavaVersion();\n-        if (version.isPresent() && (version.get().startsWith(\"1.7\") || version.get().startsWith(\"1.6\"))) {\n+        if (version.isPresent() && (version.get().startsWith(\"1.8\") || version.get().startsWith(\"1.7\") || version.get().startsWith(\"1.6\"))) {","path":"software/base/src/main/java/brooklyn/entity/java/JavaSoftwareProcessSshDriver.java","position":5,"original_position":5,"commit_id":"a903b369c8e1c726de58947153ed40eb34caebd7","original_commit_id":"a903b369c8e1c726de58947153ed40eb34caebd7","user":{"login":"sjcorbett","id":837527,"avatar_url":"https://avatars.githubusercontent.com/u/837527?","gravatar_id":"910133e13f846257b487fedfbcfa7520","url":"https://api.github.com/users/sjcorbett","html_url":"https://github.com/sjcorbett","followers_url":"https://api.github.com/users/sjcorbett/followers","following_url":"https://api.github.com/users/sjcorbett/following{/other_user}","gists_url":"https://api.github.com/users/sjcorbett/gists{/gist_id}","starred_url":"https://api.github.com/users/sjcorbett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjcorbett/subscriptions","organizations_url":"https://api.github.com/users/sjcorbett/orgs","repos_url":"https://api.github.com/users/sjcorbett/repos","events_url":"https://api.github.com/users/sjcorbett/events{/privacy}","received_events_url":"https://api.github.com/users/sjcorbett/received_events","type":"User","site_admin":false},"body":".. and that my first comment was incorrect anyway.","created_at":"2014-07-22T12:25:31Z","updated_at":"2014-07-22T12:25:31Z","html_url":"https://github.com/apache/incubator-brooklyn/pull/84#discussion_r15224246","pull_request_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/15224246"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/84#discussion_r15224246"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/84","id":18708096,"html_url":"https://github.com/apache/incubator-brooklyn/pull/84","diff_url":"https://github.com/apache/incubator-brooklyn/pull/84.diff","patch_url":"https://github.com/apache/incubator-brooklyn/pull/84.patch","issue_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/84","number":84,"state":"open","title":"Docs/cassandra failing integration test notes","user":{"login":"Nakomis","id":1488244,"avatar_url":"https://avatars.githubusercontent.com/u/1488244?","gravatar_id":"6eae7db45849918d16926d020d51ff5a","url":"https://api.github.com/users/Nakomis","html_url":"https://github.com/Nakomis","followers_url":"https://api.github.com/users/Nakomis/followers","following_url":"https://api.github.com/users/Nakomis/following{/other_user}","gists_url":"https://api.github.com/users/Nakomis/gists{/gist_id}","starred_url":"https://api.github.com/users/Nakomis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nakomis/subscriptions","organizations_url":"https://api.github.com/users/Nakomis/orgs","repos_url":"https://api.github.com/users/Nakomis/repos","events_url":"https://api.github.com/users/Nakomis/events{/privacy}","received_events_url":"https://api.github.com/users/Nakomis/received_events","type":"User","site_admin":false},"body":"Adds javadoc note to CassandraDatacenterIntegrationTest, giving workaround for broadcast_address / listen_address issue\r\n\r\nDependent upon #81","created_at":"2014-07-22T11:26:38Z","updated_at":"2014-07-22T12:25:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f9c8083b437f86eab1f85f11c29e93498549ef0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/84/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/84/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/84/comments","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/a903b369c8e1c726de58947153ed40eb34caebd7","head":{"label":"Nakomis:docs/cassandra-failing-integration-test-notes","ref":"docs/cassandra-failing-integration-test-notes","sha":"a903b369c8e1c726de58947153ed40eb34caebd7","user":{"login":"Nakomis","id":1488244,"avatar_url":"https://avatars.githubusercontent.com/u/1488244?","gravatar_id":"6eae7db45849918d16926d020d51ff5a","url":"https://api.github.com/users/Nakomis","html_url":"https://github.com/Nakomis","followers_url":"https://api.github.com/users/Nakomis/followers","following_url":"https://api.github.com/users/Nakomis/following{/other_user}","gists_url":"https://api.github.com/users/Nakomis/gists{/gist_id}","starred_url":"https://api.github.com/users/Nakomis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nakomis/subscriptions","organizations_url":"https://api.github.com/users/Nakomis/orgs","repos_url":"https://api.github.com/users/Nakomis/repos","events_url":"https://api.github.com/users/Nakomis/events{/privacy}","received_events_url":"https://api.github.com/users/Nakomis/received_events","type":"User","site_admin":false},"repo":{"id":21001586,"name":"incubator-brooklyn","full_name":"Nakomis/incubator-brooklyn","owner":{"login":"Nakomis","id":1488244,"avatar_url":"https://avatars.githubusercontent.com/u/1488244?","gravatar_id":"6eae7db45849918d16926d020d51ff5a","url":"https://api.github.com/users/Nakomis","html_url":"https://github.com/Nakomis","followers_url":"https://api.github.com/users/Nakomis/followers","following_url":"https://api.github.com/users/Nakomis/following{/other_user}","gists_url":"https://api.github.com/users/Nakomis/gists{/gist_id}","starred_url":"https://api.github.com/users/Nakomis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nakomis/subscriptions","organizations_url":"https://api.github.com/users/Nakomis/orgs","repos_url":"https://api.github.com/users/Nakomis/repos","events_url":"https://api.github.com/users/Nakomis/events{/privacy}","received_events_url":"https://api.github.com/users/Nakomis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nakomis/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":true,"url":"https://api.github.com/repos/Nakomis/incubator-brooklyn","forks_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/Nakomis/incubator-brooklyn/releases{/id}","created_at":"2014-06-19T13:39:49Z","updated_at":"2014-06-26T16:50:43Z","pushed_at":"2014-07-22T11:28:33Z","git_url":"git://github.com/Nakomis/incubator-brooklyn.git","ssh_url":"git@github.com:Nakomis/incubator-brooklyn.git","clone_url":"https://github.com/Nakomis/incubator-brooklyn.git","svn_url":"https://github.com/Nakomis/incubator-brooklyn","homepage":null,"size":224724,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e315de33ed6ae4fb4f47d98f4d2140aab9948242","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":19368221,"name":"incubator-brooklyn","full_name":"apache/incubator-brooklyn","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?","gravatar_id":"a676c0bf448fcd49f588249ead719b4c","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":false,"url":"https://api.github.com/repos/apache/incubator-brooklyn","forks_url":"https://api.github.com/repos/apache/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/apache/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/apache/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/apache/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/apache/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-brooklyn/releases{/id}","created_at":"2014-05-02T07:00:07Z","updated_at":"2014-07-05T05:45:39Z","pushed_at":"2014-07-19T19:35:12Z","git_url":"git://github.com/apache/incubator-brooklyn.git","ssh_url":"git@github.com:apache/incubator-brooklyn.git","clone_url":"https://github.com/apache/incubator-brooklyn.git","svn_url":"https://github.com/apache/incubator-brooklyn","homepage":null,"size":229492,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":18,"mirror_url":"git://git.apache.org/incubator-brooklyn.git","open_issues_count":14,"forks":18,"open_issues":14,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/84"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/84"},"issue":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/84"},"comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/a903b369c8e1c726de58947153ed40eb34caebd7"}}}}