GitHub PullRequestEvent at 2014-06-25 06:12:10
Repository: cocos2d-x
Actor: minggo
Payload: {"action":"closed","number":7195,"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7195","id":17570657,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/7195","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/7195.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/7195.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/7195","number":7195,"state":"closed","title":"override addChild by name","user":{"login":"minggo","id":488203,"avatar_url":"https://avatars.githubusercontent.com/u/488203?","gravatar_id":"69efdc94ffdebdd556c3826b6f1afe8f","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"body":"`Node::addChild(Node* node, int localZOrder, const string& name)` is added, so its sub class that override `addChild(Node* node, int localZOrder, int tag)` should also override this function too.","created_at":"2014-06-25T03:48:27Z","updated_at":"2014-06-25T06:12:10Z","closed_at":"2014-06-25T06:12:10Z","merged_at":"2014-06-25T06:12:10Z","merge_commit_sha":"9848a21c55fb81908ebe6817789e67b4aea19e75","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7195/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7195/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/7195/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/66703addb2492b3278a88cd8c2c063bfc9dca1c8","head":{"label":"minggo:addChild-override","ref":"addChild-override","sha":"66703addb2492b3278a88cd8c2c063bfc9dca1c8","user":{"login":"minggo","id":488203,"avatar_url":"https://avatars.githubusercontent.com/u/488203?","gravatar_id":"69efdc94ffdebdd556c3826b6f1afe8f","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"repo":{"id":1485679,"name":"cocos2d-x","full_name":"minggo/cocos2d-x","owner":{"login":"minggo","id":488203,"avatar_url":"https://avatars.githubusercontent.com/u/488203?","gravatar_id":"69efdc94ffdebdd556c3826b6f1afe8f","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/minggo/cocos2d-x","description":"Port of cocos2d-iphone in C++","fork":true,"url":"https://api.github.com/repos/minggo/cocos2d-x","forks_url":"https://api.github.com/repos/minggo/cocos2d-x/forks","keys_url":"https://api.github.com/repos/minggo/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minggo/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minggo/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/minggo/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/minggo/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/minggo/cocos2d-x/events","assignees_url":"https://api.github.com/repos/minggo/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/minggo/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/minggo/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/minggo/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minggo/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minggo/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/minggo/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minggo/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/minggo/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/minggo/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/minggo/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/minggo/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/minggo/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/minggo/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/minggo/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/minggo/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/minggo/cocos2d-x/issues/comments/{number}","contents_url":"https://api.github.com/repos/minggo/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/minggo/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minggo/cocos2d-x/merges","archive_url":"https://api.github.com/repos/minggo/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minggo/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/minggo/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/minggo/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/minggo/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/minggo/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minggo/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/minggo/cocos2d-x/releases{/id}","created_at":"2011-03-16T02:46:22Z","updated_at":"2014-06-25T06:12:10Z","pushed_at":"2014-06-25T03:28:17Z","git_url":"git://github.com/minggo/cocos2d-x.git","ssh_url":"git@github.com:minggo/cocos2d-x.git","clone_url":"https://github.com/minggo/cocos2d-x.git","svn_url":"https://github.com/minggo/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":774140,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"4ce61b94b90e15330fd64df8079e7c101f7e12ca","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?","gravatar_id":"2c474191a9930625c01a6752b40ebf72","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?","gravatar_id":"2c474191a9930625c01a6752b40ebf72","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments/{number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","created_at":"2010-11-18T23:17:00Z","updated_at":"2014-06-25T06:12:10Z","pushed_at":"2014-06-25T06:12:10Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1126627,"stargazers_count":3773,"watchers_count":3773,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":2761,"mirror_url":null,"open_issues_count":149,"forks":2761,"open_issues":149,"watchers":3773,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7195"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/7195"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/7195"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/7195/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7195/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/7195/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/66703addb2492b3278a88cd8c2c063bfc9dca1c8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"minggo","id":488203,"avatar_url":"https://avatars.githubusercontent.com/u/488203?","gravatar_id":"69efdc94ffdebdd556c3826b6f1afe8f","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":255,"deletions":114,"changed_files":26}}