GitHub PullRequestReviewCommentEvent at 2014-10-09 00:08:06
Repository: angular
Actor: tbosch
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/18620720","id":18620720,"diff_hunk":"@@ -0,0 +1,46 @@\n+import {Injector} from \"di/di\";\n+\n+var count = 0;\n+\n+export default function () {\n+  var bindings = [A, B, C, D, E];\n+  var injector = new Injector(bindings);\n+  var childInjector = injector.createChild([]);\n+\n+  for (var i = 0; i < 1000; ++i) {\n+    injector.get(D);\n+    injector.get(E);\n+    childInjector.get(D);\n+    childInjector.get(E);\n+  }\n+}\n+\n+class A {\n+  constructor() {\n+    count++;\n+  }\n+}\n+\n+class B {\n+  constructor(a:A) {\n+    count++;\n+  }\n+}\n+\n+class C {\n+  constructor(b:B) {\n+    count++;\n+  }\n+}\n+\n+class D {\n+  constructor(c:C, b:B) {\n+    count++;\n+  }\n+}\n+\n+class E {\n+  constructor(d:D, c:C) {\n+    count++;\n+  }\n+}","path":"benchmarks/di/injector_benchmark.js","position":46,"original_position":46,"commit_id":"82f08f277c5f6521688781f968a9775baadba7b8","original_commit_id":"82f08f277c5f6521688781f968a9775baadba7b8","user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=2","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"body":"Newline","created_at":"2014-10-09T00:08:06Z","updated_at":"2014-10-09T00:08:06Z","html_url":"https://github.com/angular/angular/pull/71#discussion_r18620720","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/18620720"},"html":{"href":"https://github.com/angular/angular/pull/71#discussion_r18620720"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/71","id":22455910,"html_url":"https://github.com/angular/angular/pull/71","diff_url":"https://github.com/angular/angular/pull/71.diff","patch_url":"https://github.com/angular/angular/pull/71.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/71","number":71,"state":"open","locked":false,"title":"feat(benchmark): add a simple benchmark for the di module","user":{"login":"vsavkin","id":35996,"avatar_url":"https://avatars.githubusercontent.com/u/35996?v=2","gravatar_id":"","url":"https://api.github.com/users/vsavkin","html_url":"https://github.com/vsavkin","followers_url":"https://api.github.com/users/vsavkin/followers","following_url":"https://api.github.com/users/vsavkin/following{/other_user}","gists_url":"https://api.github.com/users/vsavkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vsavkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsavkin/subscriptions","organizations_url":"https://api.github.com/users/vsavkin/orgs","repos_url":"https://api.github.com/users/vsavkin/repos","events_url":"https://api.github.com/users/vsavkin/events{/privacy}","received_events_url":"https://api.github.com/users/vsavkin/received_events","type":"User","site_admin":false},"body":"It adds the following tasks to the gulpfile:\r\n\r\n1. `benchmarks/clean` // removes the compiled files\r\n2. `benchmarks/build` // compiles all the files in `benchmarks` and creates a benchpress build\r\n3. `benchmarks/run` // fires up a server\r\n\r\nIt also includes a very simple benchmark. It is not very useful and just serves as an example.\r\n\r\nExtra notes:\r\n1. Benchmarks run against the build folder. Right now everything is compiled with type checks enabled. We need to have another task (or maybe a flag) that compiles everything in production mode (without type checks).","created_at":"2014-10-08T21:23:25Z","updated_at":"2014-10-09T00:08:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7fc5e4acd5684fc260c38c73a33c95d47f4bda4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/71/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/71/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular/angular/issues/71/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/82f08f277c5f6521688781f968a9775baadba7b8","head":{"label":"vsavkin:add_di_benchmarks","ref":"add_di_benchmarks","sha":"82f08f277c5f6521688781f968a9775baadba7b8","user":{"login":"vsavkin","id":35996,"avatar_url":"https://avatars.githubusercontent.com/u/35996?v=2","gravatar_id":"","url":"https://api.github.com/users/vsavkin","html_url":"https://github.com/vsavkin","followers_url":"https://api.github.com/users/vsavkin/followers","following_url":"https://api.github.com/users/vsavkin/following{/other_user}","gists_url":"https://api.github.com/users/vsavkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vsavkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsavkin/subscriptions","organizations_url":"https://api.github.com/users/vsavkin/orgs","repos_url":"https://api.github.com/users/vsavkin/repos","events_url":"https://api.github.com/users/vsavkin/events{/privacy}","received_events_url":"https://api.github.com/users/vsavkin/received_events","type":"User","site_admin":false},"repo":{"id":24644769,"name":"angular","full_name":"vsavkin/angular","owner":{"login":"vsavkin","id":35996,"avatar_url":"https://avatars.githubusercontent.com/u/35996?v=2","gravatar_id":"","url":"https://api.github.com/users/vsavkin","html_url":"https://github.com/vsavkin","followers_url":"https://api.github.com/users/vsavkin/followers","following_url":"https://api.github.com/users/vsavkin/following{/other_user}","gists_url":"https://api.github.com/users/vsavkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vsavkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsavkin/subscriptions","organizations_url":"https://api.github.com/users/vsavkin/orgs","repos_url":"https://api.github.com/users/vsavkin/repos","events_url":"https://api.github.com/users/vsavkin/events{/privacy}","received_events_url":"https://api.github.com/users/vsavkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vsavkin/angular","description":"","fork":true,"url":"https://api.github.com/repos/vsavkin/angular","forks_url":"https://api.github.com/repos/vsavkin/angular/forks","keys_url":"https://api.github.com/repos/vsavkin/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vsavkin/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vsavkin/angular/teams","hooks_url":"https://api.github.com/repos/vsavkin/angular/hooks","issue_events_url":"https://api.github.com/repos/vsavkin/angular/issues/events{/number}","events_url":"https://api.github.com/repos/vsavkin/angular/events","assignees_url":"https://api.github.com/repos/vsavkin/angular/assignees{/user}","branches_url":"https://api.github.com/repos/vsavkin/angular/branches{/branch}","tags_url":"https://api.github.com/repos/vsavkin/angular/tags","blobs_url":"https://api.github.com/repos/vsavkin/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vsavkin/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vsavkin/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/vsavkin/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vsavkin/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/vsavkin/angular/languages","stargazers_url":"https://api.github.com/repos/vsavkin/angular/stargazers","contributors_url":"https://api.github.com/repos/vsavkin/angular/contributors","subscribers_url":"https://api.github.com/repos/vsavkin/angular/subscribers","subscription_url":"https://api.github.com/repos/vsavkin/angular/subscription","commits_url":"https://api.github.com/repos/vsavkin/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/vsavkin/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/vsavkin/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/vsavkin/angular/issues/comments/{number}","contents_url":"https://api.github.com/repos/vsavkin/angular/contents/{+path}","compare_url":"https://api.github.com/repos/vsavkin/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vsavkin/angular/merges","archive_url":"https://api.github.com/repos/vsavkin/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vsavkin/angular/downloads","issues_url":"https://api.github.com/repos/vsavkin/angular/issues{/number}","pulls_url":"https://api.github.com/repos/vsavkin/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/vsavkin/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/vsavkin/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vsavkin/angular/labels{/name}","releases_url":"https://api.github.com/repos/vsavkin/angular/releases{/id}","created_at":"2014-09-30T15:59:47Z","updated_at":"2014-10-02T21:29:21Z","pushed_at":"2014-10-08T21:29:20Z","git_url":"git://github.com/vsavkin/angular.git","ssh_url":"git@github.com:vsavkin/angular.git","clone_url":"https://github.com/vsavkin/angular.git","svn_url":"https://github.com/vsavkin/angular","homepage":null,"size":644,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"5818c3bf28d69d98d9eca9e0a8b8f14c0bf811c8","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=2","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=2","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2014-10-08T08:57:31Z","pushed_at":"2014-10-08T13:32:08Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":null,"size":1057,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":34,"forks":12,"open_issues":34,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/71"},"html":{"href":"https://github.com/angular/angular/pull/71"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/71"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/82f08f277c5f6521688781f968a9775baadba7b8"}}}}