GitHub PullRequestReviewCommentEvent at 2014-06-13 07:35:17
Repository: julia
Actor: shashi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/13740773","id":13740773,"diff_hunk":"@@ -264,7 +266,22 @@ function uuid4()\n     UUID(u)\n end\n \n-function Base.convert(::Type{Vector{Uint8}}, u::UUID)\n+function Base.convert(::Type{UUID}, s::String)\n+    s = lowercase(s)\n+    if match(r\"^[0-9a-f]{8}(-[0-9a-f]{4}){3}-[0-9a-f]{12}$\", s) == nothing","path":"base/random.jl","position":null,"original_position":16,"commit_id":"a8945d8d995564e8526c9f3e1316c0776935341d","original_commit_id":"b4997407425c4ebd834fcdc1601ae1ca745d8884","user":{"login":"shashi","id":25916,"avatar_url":"https://avatars.githubusercontent.com/u/25916?","gravatar_id":"0fad49c6aa6b527efa5cfd3e82082bf9","url":"https://api.github.com/users/shashi","html_url":"https://github.com/shashi","followers_url":"https://api.github.com/users/shashi/followers","following_url":"https://api.github.com/users/shashi/following{/other_user}","gists_url":"https://api.github.com/users/shashi/gists{/gist_id}","starred_url":"https://api.github.com/users/shashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashi/subscriptions","organizations_url":"https://api.github.com/users/shashi/orgs","repos_url":"https://api.github.com/users/shashi/repos","events_url":"https://api.github.com/users/shashi/events{/privacy}","received_events_url":"https://api.github.com/users/shashi/received_events","type":"User","site_admin":false},"body":"Didn't know about this. Thanks!","created_at":"2014-06-13T07:35:17Z","updated_at":"2014-06-13T07:35:17Z","html_url":"https://github.com/JuliaLang/julia/pull/7237#discussion_r13740773","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/7237","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/13740773"},"html":{"href":"https://github.com/JuliaLang/julia/pull/7237#discussion_r13740773"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/7237"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/7237","id":17084971,"html_url":"https://github.com/JuliaLang/julia/pull/7237","diff_url":"https://github.com/JuliaLang/julia/pull/7237.diff","patch_url":"https://github.com/JuliaLang/julia/pull/7237.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/7237","number":7237,"state":"open","title":"added convert(::Type{UUID}, ::ASCIIString)","user":{"login":"shashi","id":25916,"avatar_url":"https://avatars.githubusercontent.com/u/25916?","gravatar_id":"0fad49c6aa6b527efa5cfd3e82082bf9","url":"https://api.github.com/users/shashi","html_url":"https://github.com/shashi","followers_url":"https://api.github.com/users/shashi/followers","following_url":"https://api.github.com/users/shashi/following{/other_user}","gists_url":"https://api.github.com/users/shashi/gists{/gist_id}","starred_url":"https://api.github.com/users/shashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashi/subscriptions","organizations_url":"https://api.github.com/users/shashi/orgs","repos_url":"https://api.github.com/users/shashi/repos","events_url":"https://api.github.com/users/shashi/events{/privacy}","received_events_url":"https://api.github.com/users/shashi/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-12T22:58:36Z","updated_at":"2014-06-13T07:35:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"451ecec1f62502d3ea3c0b0c28913fc4ff041d25","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/7237/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/7237/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/7237/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/a8945d8d995564e8526c9f3e1316c0776935341d","head":{"label":"shashi:uuid_conversion","ref":"uuid_conversion","sha":"a8945d8d995564e8526c9f3e1316c0776935341d","user":{"login":"shashi","id":25916,"avatar_url":"https://avatars.githubusercontent.com/u/25916?","gravatar_id":"0fad49c6aa6b527efa5cfd3e82082bf9","url":"https://api.github.com/users/shashi","html_url":"https://github.com/shashi","followers_url":"https://api.github.com/users/shashi/followers","following_url":"https://api.github.com/users/shashi/following{/other_user}","gists_url":"https://api.github.com/users/shashi/gists{/gist_id}","starred_url":"https://api.github.com/users/shashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashi/subscriptions","organizations_url":"https://api.github.com/users/shashi/orgs","repos_url":"https://api.github.com/users/shashi/repos","events_url":"https://api.github.com/users/shashi/events{/privacy}","received_events_url":"https://api.github.com/users/shashi/received_events","type":"User","site_admin":false},"repo":{"id":20785534,"name":"julia","full_name":"shashi/julia","owner":{"login":"shashi","id":25916,"avatar_url":"https://avatars.githubusercontent.com/u/25916?","gravatar_id":"0fad49c6aa6b527efa5cfd3e82082bf9","url":"https://api.github.com/users/shashi","html_url":"https://github.com/shashi","followers_url":"https://api.github.com/users/shashi/followers","following_url":"https://api.github.com/users/shashi/following{/other_user}","gists_url":"https://api.github.com/users/shashi/gists{/gist_id}","starred_url":"https://api.github.com/users/shashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashi/subscriptions","organizations_url":"https://api.github.com/users/shashi/orgs","repos_url":"https://api.github.com/users/shashi/repos","events_url":"https://api.github.com/users/shashi/events{/privacy}","received_events_url":"https://api.github.com/users/shashi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shashi/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/shashi/julia","forks_url":"https://api.github.com/repos/shashi/julia/forks","keys_url":"https://api.github.com/repos/shashi/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shashi/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shashi/julia/teams","hooks_url":"https://api.github.com/repos/shashi/julia/hooks","issue_events_url":"https://api.github.com/repos/shashi/julia/issues/events{/number}","events_url":"https://api.github.com/repos/shashi/julia/events","assignees_url":"https://api.github.com/repos/shashi/julia/assignees{/user}","branches_url":"https://api.github.com/repos/shashi/julia/branches{/branch}","tags_url":"https://api.github.com/repos/shashi/julia/tags","blobs_url":"https://api.github.com/repos/shashi/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shashi/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shashi/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/shashi/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shashi/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/shashi/julia/languages","stargazers_url":"https://api.github.com/repos/shashi/julia/stargazers","contributors_url":"https://api.github.com/repos/shashi/julia/contributors","subscribers_url":"https://api.github.com/repos/shashi/julia/subscribers","subscription_url":"https://api.github.com/repos/shashi/julia/subscription","commits_url":"https://api.github.com/repos/shashi/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/shashi/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/shashi/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/shashi/julia/issues/comments/{number}","contents_url":"https://api.github.com/repos/shashi/julia/contents/{+path}","compare_url":"https://api.github.com/repos/shashi/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shashi/julia/merges","archive_url":"https://api.github.com/repos/shashi/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shashi/julia/downloads","issues_url":"https://api.github.com/repos/shashi/julia/issues{/number}","pulls_url":"https://api.github.com/repos/shashi/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/shashi/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/shashi/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shashi/julia/labels{/name}","releases_url":"https://api.github.com/repos/shashi/julia/releases{/id}","created_at":"2014-06-12T22:57:58Z","updated_at":"2014-06-13T07:35:11Z","pushed_at":"2014-06-13T07:35:11Z","git_url":"git://github.com/shashi/julia.git","ssh_url":"git@github.com:shashi/julia.git","clone_url":"https://github.com/shashi/julia.git","svn_url":"https://github.com/shashi/julia","homepage":"http://julialang.org/","size":131676,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"8293dc614cb34847389bf8efca9fc1d4c201c6d6","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?","gravatar_id":"d57c99557ab0dc0fa44b4c84447d0f15","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?","gravatar_id":"d57c99557ab0dc0fa44b4c84447d0f15","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/{number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2014-06-13T05:56:10Z","pushed_at":"2014-06-13T00:25:21Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":131676,"stargazers_count":3867,"watchers_count":3867,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":770,"mirror_url":null,"open_issues_count":775,"forks":770,"open_issues":775,"watchers":3867,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/7237"},"html":{"href":"https://github.com/JuliaLang/julia/pull/7237"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/7237"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/7237/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/7237/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/7237/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/a8945d8d995564e8526c9f3e1316c0776935341d"}}}}