GitHub PullRequestReviewCommentEvent at 2014-01-02 23:05:52
Repository: libcloud
Actor: Kami
Payload: {"comment":{"url":"https://api.github.com/repos/apache/libcloud/pulls/comments/8625942","id":8625942,"diff_hunk":"@@ -2435,6 +2595,136 @@ def ex_describe_addresses_for_node(self, node):\n         node_elastic_ips = self.ex_describe_addresses([node])\n         return node_elastic_ips[node.id]\n \n+    def ex_list_network_interfaces(self):\n+        \"\"\"\n+        Return all network interfaces\n+\n+        :return:    List of EC2NetworkInterface instances\n+        :rtype:     ``list`` of :class `EC2NetworkInterface`\n+        \"\"\"\n+        params = {'Action': 'DescribeNetworkInterfaces'}\n+\n+        return self._to_interfaces(\n+            self.connection.request(self.path, params=params).object\n+        )\n+\n+    def ex_create_network_interface(self, subnet, name=None,\n+                                    description=None,\n+                                    private_ip_address=None):\n+        \"\"\"\n+        Create a network interface within a VPC subnet.\n+\n+        :param      node: EC2NetworkSubnet instance\n+        :type       node: :class:`EC2NetworkSubnet`\n+\n+        :param      name:  Optional name of the interface\n+        :type       name:  ``str``\n+\n+        :param      description:  Optional description of the network interface\n+        :type       description:  ``str``\n+\n+        :param      private_ip_address:  Optional IP address assigned. If not","path":"libcloud/compute/drivers/ec2.py","position":206,"original_position":206,"commit_id":"c0008b0451f470d58d4e21c25ed67c659d0adcd7","original_commit_id":"c0008b0451f470d58d4e21c25ed67c659d0adcd7","user":{"login":"Kami","id":125088,"avatar_url":"https://gravatar.com/avatar/3e11eb4740f943ce8b8460e7fee1a8d0?d=https%3A%2F%2Fidenticons.github.com%2F4b34e3d7ecf7fd3a2c6835a1b90daac9.png&r=x","gravatar_id":"3e11eb4740f943ce8b8460e7fee1a8d0","url":"https://api.github.com/users/Kami","html_url":"https://github.com/Kami","followers_url":"https://api.github.com/users/Kami/followers","following_url":"https://api.github.com/users/Kami/following{/other_user}","gists_url":"https://api.github.com/users/Kami/gists{/gist_id}","starred_url":"https://api.github.com/users/Kami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kami/subscriptions","organizations_url":"https://api.github.com/users/Kami/orgs","repos_url":"https://api.github.com/users/Kami/repos","events_url":"https://api.github.com/users/Kami/events{/privacy}","received_events_url":"https://api.github.com/users/Kami/received_events","type":"User","site_admin":false},"body":"Looking at the docs (http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-CreateNetworkInterface.html), EC2 allows you to assign multiple private IP addresses to an interface, but only one primary address.\r\n\r\nIt would be good to clarify in the docstring that this is a primary private IP address.","created_at":"2014-01-02T23:05:52Z","updated_at":"2014-01-02T23:05:52Z","html_url":"https://github.com/apache/libcloud/pull/213#discussion_r8625942","pull_request_url":"https://api.github.com/repos/apache/libcloud/pulls/213","_links":{"self":{"href":"https://api.github.com/repos/apache/libcloud/pulls/comments/8625942"},"html":{"href":"https://github.com/apache/libcloud/pull/213#discussion_r8625942"},"pull_request":{"href":"https://api.github.com/repos/apache/libcloud/pulls/213"}}}}