GitHub PullRequestEvent at 2014-06-06 21:19:45
Repository: jquery-lang-js
Actor: lukaszewczak
Payload: {"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/pulls/26","id":16843401,"html_url":"https://github.com/coolbloke1324/jquery-lang-js/pull/26","diff_url":"https://github.com/coolbloke1324/jquery-lang-js/pull/26.diff","patch_url":"https://github.com/coolbloke1324/jquery-lang-js/pull/26.patch","issue_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/issues/26","number":26,"state":"open","title":"Update library to work under IE8","user":{"login":"lukaszewczak","id":7238770,"avatar_url":"https://avatars.githubusercontent.com/u/7238770?","gravatar_id":"585ce301abd0c89dad7c58db59fa2413","url":"https://api.github.com/users/lukaszewczak","html_url":"https://github.com/lukaszewczak","followers_url":"https://api.github.com/users/lukaszewczak/followers","following_url":"https://api.github.com/users/lukaszewczak/following{/other_user}","gists_url":"https://api.github.com/users/lukaszewczak/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszewczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszewczak/subscriptions","organizations_url":"https://api.github.com/users/lukaszewczak/orgs","repos_url":"https://api.github.com/users/lukaszewczak/repos","events_url":"https://api.github.com/users/lukaszewczak/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszewczak/received_events","type":"User","site_admin":false},"body":"Hi,\r\nI am currently work on project where we are using Your library for switching between languages, everything looks cool, except that someone forgot to test this on IE8 because IE8 is the target browser for this project. Unfortunately on **IE8** library does not work, because we got error **'Object does not support this property or method'** on line `this.langDefaultText = this.data` in **_getTestNodes** method. The problem occur because `langDefaultText ` was the custom property for Text Node, and it turns out that such an assignment is not possible in IE8. So I decided to make few changes to work on IE8. Please review.\r\n\r\n\r\n\r\n","created_at":"2014-06-06T21:19:45Z","updated_at":"2014-06-06T21:19:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/pulls/26/commits","review_comments_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/pulls/26/comments","review_comment_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/issues/26/comments","statuses_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/statuses/886c2eb1ac38e551709c5429254d3799abfaaeb2","head":{"label":"lukaszewczak:master","ref":"master","sha":"886c2eb1ac38e551709c5429254d3799abfaaeb2","user":{"login":"lukaszewczak","id":7238770,"avatar_url":"https://avatars.githubusercontent.com/u/7238770?","gravatar_id":"585ce301abd0c89dad7c58db59fa2413","url":"https://api.github.com/users/lukaszewczak","html_url":"https://github.com/lukaszewczak","followers_url":"https://api.github.com/users/lukaszewczak/followers","following_url":"https://api.github.com/users/lukaszewczak/following{/other_user}","gists_url":"https://api.github.com/users/lukaszewczak/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszewczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszewczak/subscriptions","organizations_url":"https://api.github.com/users/lukaszewczak/orgs","repos_url":"https://api.github.com/users/lukaszewczak/repos","events_url":"https://api.github.com/users/lukaszewczak/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszewczak/received_events","type":"User","site_admin":false},"repo":{"id":20576622,"name":"jquery-lang-js","full_name":"lukaszewczak/jquery-lang-js","owner":{"login":"lukaszewczak","id":7238770,"avatar_url":"https://avatars.githubusercontent.com/u/7238770?","gravatar_id":"585ce301abd0c89dad7c58db59fa2413","url":"https://api.github.com/users/lukaszewczak","html_url":"https://github.com/lukaszewczak","followers_url":"https://api.github.com/users/lukaszewczak/followers","following_url":"https://api.github.com/users/lukaszewczak/following{/other_user}","gists_url":"https://api.github.com/users/lukaszewczak/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszewczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszewczak/subscriptions","organizations_url":"https://api.github.com/users/lukaszewczak/orgs","repos_url":"https://api.github.com/users/lukaszewczak/repos","events_url":"https://api.github.com/users/lukaszewczak/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszewczak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukaszewczak/jquery-lang-js","description":"i18n Automatically deploy and switch multi-language HTML pages without reloading the page.","fork":true,"url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js","forks_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/forks","keys_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/teams","hooks_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/hooks","issue_events_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/issues/events{/number}","events_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/events","assignees_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/assignees{/user}","branches_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/branches{/branch}","tags_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/tags","blobs_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/statuses/{sha}","languages_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/languages","stargazers_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/stargazers","contributors_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/contributors","subscribers_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/subscribers","subscription_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/subscription","commits_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/issues/comments/{number}","contents_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/contents/{+path}","compare_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/merges","archive_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/downloads","issues_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/issues{/number}","pulls_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/pulls{/number}","milestones_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/milestones{/number}","notifications_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/labels{/name}","releases_url":"https://api.github.com/repos/lukaszewczak/jquery-lang-js/releases{/id}","created_at":"2014-06-06T20:08:58Z","updated_at":"2014-06-06T21:19:45Z","pushed_at":"2014-06-06T20:53:44Z","git_url":"git://github.com/lukaszewczak/jquery-lang-js.git","ssh_url":"git@github.com:lukaszewczak/jquery-lang-js.git","clone_url":"https://github.com/lukaszewczak/jquery-lang-js.git","svn_url":"https://github.com/lukaszewczak/jquery-lang-js","homepage":"http://www.irrelon.com","size":168,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coolbloke1324:master","ref":"master","sha":"0fd2ab7e138a82a9ae9cc49ad55115b0907bd44d","user":{"login":"coolbloke1324","id":492293,"avatar_url":"https://avatars.githubusercontent.com/u/492293?","gravatar_id":"597cc8834a382929bc8b6b4d6cfa6a94","url":"https://api.github.com/users/coolbloke1324","html_url":"https://github.com/coolbloke1324","followers_url":"https://api.github.com/users/coolbloke1324/followers","following_url":"https://api.github.com/users/coolbloke1324/following{/other_user}","gists_url":"https://api.github.com/users/coolbloke1324/gists{/gist_id}","starred_url":"https://api.github.com/users/coolbloke1324/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolbloke1324/subscriptions","organizations_url":"https://api.github.com/users/coolbloke1324/orgs","repos_url":"https://api.github.com/users/coolbloke1324/repos","events_url":"https://api.github.com/users/coolbloke1324/events{/privacy}","received_events_url":"https://api.github.com/users/coolbloke1324/received_events","type":"User","site_admin":false},"repo":{"id":2097020,"name":"jquery-lang-js","full_name":"coolbloke1324/jquery-lang-js","owner":{"login":"coolbloke1324","id":492293,"avatar_url":"https://avatars.githubusercontent.com/u/492293?","gravatar_id":"597cc8834a382929bc8b6b4d6cfa6a94","url":"https://api.github.com/users/coolbloke1324","html_url":"https://github.com/coolbloke1324","followers_url":"https://api.github.com/users/coolbloke1324/followers","following_url":"https://api.github.com/users/coolbloke1324/following{/other_user}","gists_url":"https://api.github.com/users/coolbloke1324/gists{/gist_id}","starred_url":"https://api.github.com/users/coolbloke1324/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolbloke1324/subscriptions","organizations_url":"https://api.github.com/users/coolbloke1324/orgs","repos_url":"https://api.github.com/users/coolbloke1324/repos","events_url":"https://api.github.com/users/coolbloke1324/events{/privacy}","received_events_url":"https://api.github.com/users/coolbloke1324/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coolbloke1324/jquery-lang-js","description":"i18n Automatically deploy and switch multi-language HTML pages without reloading the page.","fork":false,"url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js","forks_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/forks","keys_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/teams","hooks_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/hooks","issue_events_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/issues/events{/number}","events_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/events","assignees_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/assignees{/user}","branches_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/branches{/branch}","tags_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/tags","blobs_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/statuses/{sha}","languages_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/languages","stargazers_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/stargazers","contributors_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/contributors","subscribers_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/subscribers","subscription_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/subscription","commits_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/issues/comments/{number}","contents_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/contents/{+path}","compare_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/merges","archive_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/downloads","issues_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/issues{/number}","pulls_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/pulls{/number}","milestones_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/milestones{/number}","notifications_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/labels{/name}","releases_url":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/releases{/id}","created_at":"2011-07-24T15:37:26Z","updated_at":"2014-05-31T13:17:16Z","pushed_at":"2014-05-07T17:53:19Z","git_url":"git://github.com/coolbloke1324/jquery-lang-js.git","ssh_url":"git@github.com:coolbloke1324/jquery-lang-js.git","clone_url":"https://github.com/coolbloke1324/jquery-lang-js.git","svn_url":"https://github.com/coolbloke1324/jquery-lang-js","homepage":"http://www.irrelon.com","size":608,"stargazers_count":101,"watchers_count":101,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":37,"mirror_url":null,"open_issues_count":5,"forks":37,"open_issues":5,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/pulls/26"},"html":{"href":"https://github.com/coolbloke1324/jquery-lang-js/pull/26"},"issue":{"href":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/issues/26"},"comments":{"href":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/coolbloke1324/jquery-lang-js/statuses/886c2eb1ac38e551709c5429254d3799abfaaeb2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":27,"deletions":11,"changed_files":2}}