GitHub PullRequestReviewCommentEvent at 2014-08-18 21:55:46
Repository: cabal
Actor: 23Skidoo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/haskell/cabal/pulls/comments/16384864","id":16384864,"diff_hunk":"@@ -220,7 +221,7 @@ resolveWithFlags dom os arch impl constrs trees checkDeps =\n       Right r -> Right r\n       Left dbt -> Left $ findShortest dbt\n   where\n-    extraConstrs = toDepMap constrs\n+    extraConstrs = toDepMap (map (flip FullDependency defaultRenaming) constrs)","path":"Cabal/Distribution/PackageDescription/Configuration.hs","position":28,"original_position":28,"commit_id":"bd0a963544e66a486d7b72fbbb975b7f41c6e067","original_commit_id":"bd0a963544e66a486d7b72fbbb975b7f41c6e067","user":{"login":"23Skidoo","id":47439,"avatar_url":"https://avatars.githubusercontent.com/u/47439?v=2","gravatar_id":"55d9f8a76c1f96f930d25fdd1fcc1fb8","url":"https://api.github.com/users/23Skidoo","html_url":"https://github.com/23Skidoo","followers_url":"https://api.github.com/users/23Skidoo/followers","following_url":"https://api.github.com/users/23Skidoo/following{/other_user}","gists_url":"https://api.github.com/users/23Skidoo/gists{/gist_id}","starred_url":"https://api.github.com/users/23Skidoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/23Skidoo/subscriptions","organizations_url":"https://api.github.com/users/23Skidoo/orgs","repos_url":"https://api.github.com/users/23Skidoo/repos","events_url":"https://api.github.com/users/23Skidoo/events{/privacy}","received_events_url":"https://api.github.com/users/23Skidoo/received_events","type":"User","site_admin":false},"body":"Shouldn't this be `mempty` instead of `defaultRenaming`?","created_at":"2014-08-18T21:55:46Z","updated_at":"2014-08-18T21:55:46Z","html_url":"https://github.com/haskell/cabal/pull/2038#discussion_r16384864","pull_request_url":"https://api.github.com/repos/haskell/cabal/pulls/2038","_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments/16384864"},"html":{"href":"https://github.com/haskell/cabal/pull/2038#discussion_r16384864"},"pull_request":{"href":"https://api.github.com/repos/haskell/cabal/pulls/2038"}}},"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/2038","id":19615531,"html_url":"https://github.com/haskell/cabal/pull/2038","diff_url":"https://github.com/haskell/cabal/pull/2038.diff","patch_url":"https://github.com/haskell/cabal/pull/2038.patch","issue_url":"https://api.github.com/repos/haskell/cabal/issues/2038","number":2038,"state":"open","locked":false,"title":"Support module thinning and renaming Cabal-side.","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=2","gravatar_id":"434aee9ad675384a9e745c7217ac4abe","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"NB: unlike GHC, Cabal will still try to find a globally consistent choice for\r\nall package names, i.e. this does *not* implement private dependencies.\r\n\r\nSigned-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>","created_at":"2014-08-11T17:41:06Z","updated_at":"2014-08-18T21:55:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e25c57fba12ce9d7f41e03b42d9b11b2c01fea1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/haskell/cabal/pulls/2038/commits","review_comments_url":"https://api.github.com/repos/haskell/cabal/pulls/2038/comments","review_comment_url":"https://api.github.com/repos/haskell/cabal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/2038/comments","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/bd0a963544e66a486d7b72fbbb975b7f41c6e067","head":{"label":"ezyang:ezyang-renaming","ref":"ezyang-renaming","sha":"bd0a963544e66a486d7b72fbbb975b7f41c6e067","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=2","gravatar_id":"434aee9ad675384a9e745c7217ac4abe","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"repo":{"id":6343207,"name":"cabal","full_name":"ezyang/cabal","owner":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=2","gravatar_id":"434aee9ad675384a9e745c7217ac4abe","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ezyang/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":true,"url":"https://api.github.com/repos/ezyang/cabal","forks_url":"https://api.github.com/repos/ezyang/cabal/forks","keys_url":"https://api.github.com/repos/ezyang/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezyang/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezyang/cabal/teams","hooks_url":"https://api.github.com/repos/ezyang/cabal/hooks","issue_events_url":"https://api.github.com/repos/ezyang/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/ezyang/cabal/events","assignees_url":"https://api.github.com/repos/ezyang/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/ezyang/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/ezyang/cabal/tags","blobs_url":"https://api.github.com/repos/ezyang/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezyang/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezyang/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezyang/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezyang/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/ezyang/cabal/languages","stargazers_url":"https://api.github.com/repos/ezyang/cabal/stargazers","contributors_url":"https://api.github.com/repos/ezyang/cabal/contributors","subscribers_url":"https://api.github.com/repos/ezyang/cabal/subscribers","subscription_url":"https://api.github.com/repos/ezyang/cabal/subscription","commits_url":"https://api.github.com/repos/ezyang/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezyang/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezyang/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezyang/cabal/issues/comments/{number}","contents_url":"https://api.github.com/repos/ezyang/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/ezyang/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezyang/cabal/merges","archive_url":"https://api.github.com/repos/ezyang/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezyang/cabal/downloads","issues_url":"https://api.github.com/repos/ezyang/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/ezyang/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/ezyang/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/ezyang/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezyang/cabal/labels{/name}","releases_url":"https://api.github.com/repos/ezyang/cabal/releases{/id}","created_at":"2012-10-22T22:12:16Z","updated_at":"2014-07-13T17:24:43Z","pushed_at":"2014-08-18T17:31:41Z","git_url":"git://github.com/ezyang/cabal.git","ssh_url":"git@github.com:ezyang/cabal.git","clone_url":"https://github.com/ezyang/cabal.git","svn_url":"https://github.com/ezyang/cabal","homepage":"http://haskell.org/cabal","size":24086,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"cd89a6c625e01f1e99926fd2456a5f3c18d616f6","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=2","gravatar_id":"f92c0b083ed9db8211f9e58d7facbcc0","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":3728161,"name":"cabal","full_name":"haskell/cabal","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=2","gravatar_id":"f92c0b083ed9db8211f9e58d7facbcc0","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":false,"url":"https://api.github.com/repos/haskell/cabal","forks_url":"https://api.github.com/repos/haskell/cabal/forks","keys_url":"https://api.github.com/repos/haskell/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/cabal/teams","hooks_url":"https://api.github.com/repos/haskell/cabal/hooks","issue_events_url":"https://api.github.com/repos/haskell/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/cabal/events","assignees_url":"https://api.github.com/repos/haskell/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/cabal/tags","blobs_url":"https://api.github.com/repos/haskell/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/cabal/languages","stargazers_url":"https://api.github.com/repos/haskell/cabal/stargazers","contributors_url":"https://api.github.com/repos/haskell/cabal/contributors","subscribers_url":"https://api.github.com/repos/haskell/cabal/subscribers","subscription_url":"https://api.github.com/repos/haskell/cabal/subscription","commits_url":"https://api.github.com/repos/haskell/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/cabal/issues/comments/{number}","contents_url":"https://api.github.com/repos/haskell/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/cabal/merges","archive_url":"https://api.github.com/repos/haskell/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/cabal/downloads","issues_url":"https://api.github.com/repos/haskell/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/cabal/labels{/name}","releases_url":"https://api.github.com/repos/haskell/cabal/releases{/id}","created_at":"2012-03-15T12:53:38Z","updated_at":"2014-08-17T20:12:14Z","pushed_at":"2014-08-15T20:05:58Z","git_url":"git://github.com/haskell/cabal.git","ssh_url":"git@github.com:haskell/cabal.git","clone_url":"https://github.com/haskell/cabal.git","svn_url":"https://github.com/haskell/cabal","homepage":"http://haskell.org/cabal","size":33730,"stargazers_count":354,"watchers_count":354,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":189,"mirror_url":null,"open_issues_count":572,"forks":189,"open_issues":572,"watchers":354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/2038"},"html":{"href":"https://github.com/haskell/cabal/pull/2038"},"issue":{"href":"https://api.github.com/repos/haskell/cabal/issues/2038"},"comments":{"href":"https://api.github.com/repos/haskell/cabal/issues/2038/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/cabal/pulls/2038/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/haskell/cabal/pulls/2038/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/cabal/statuses/bd0a963544e66a486d7b72fbbb975b7f41c6e067"}}}}