GitHub PullRequestReviewCommentEvent at 2014-10-20 10:20:18
Repository: frontend
Actor: rich-nguyen
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/19077112","id":19077112,"diff_hunk":"@@ -292,3 +292,9 @@ object Tags {\n     \"tone/reviews\"\n   )\n }\n+\n+case class BlockLevelSharing(\n+  text: String,\n+  css: String,\n+  url: String\n+)","path":"common/app/model/meta.scala","position":9,"original_position":9,"commit_id":"304c564f0c62b88c0bb79bab67eca0ba99c013e7","original_commit_id":"304c564f0c62b88c0bb79bab67eca0ba99c013e7","user":{"login":"rich-nguyen","id":4549425,"avatar_url":"https://avatars.githubusercontent.com/u/4549425?v=2","gravatar_id":"","url":"https://api.github.com/users/rich-nguyen","html_url":"https://github.com/rich-nguyen","followers_url":"https://api.github.com/users/rich-nguyen/followers","following_url":"https://api.github.com/users/rich-nguyen/following{/other_user}","gists_url":"https://api.github.com/users/rich-nguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/rich-nguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rich-nguyen/subscriptions","organizations_url":"https://api.github.com/users/rich-nguyen/orgs","repos_url":"https://api.github.com/users/rich-nguyen/repos","events_url":"https://api.github.com/users/rich-nguyen/events{/privacy}","received_events_url":"https://api.github.com/users/rich-nguyen/received_events","type":"User","site_admin":false},"body":"Not necessarily, it could be here if `shareOptions` was added to `MetaData`, which isn't currently the case. Think it could just be it's own trait, it's quite different to the other traits.","created_at":"2014-10-20T10:20:18Z","updated_at":"2014-10-20T10:20:18Z","html_url":"https://github.com/guardian/frontend/pull/6581#discussion_r19077112","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/6581","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/19077112"},"html":{"href":"https://github.com/guardian/frontend/pull/6581#discussion_r19077112"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6581"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/6581","id":22929579,"html_url":"https://github.com/guardian/frontend/pull/6581","diff_url":"https://github.com/guardian/frontend/pull/6581.diff","patch_url":"https://github.com/guardian/frontend/pull/6581.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/6581","number":6581,"state":"open","locked":false,"title":"Block Level Sharing in Galleries","user":{"login":"Jholder112233","id":2236852,"avatar_url":"https://avatars.githubusercontent.com/u/2236852?v=2","gravatar_id":"","url":"https://api.github.com/users/Jholder112233","html_url":"https://github.com/Jholder112233","followers_url":"https://api.github.com/users/Jholder112233/followers","following_url":"https://api.github.com/users/Jholder112233/following{/other_user}","gists_url":"https://api.github.com/users/Jholder112233/gists{/gist_id}","starred_url":"https://api.github.com/users/Jholder112233/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jholder112233/subscriptions","organizations_url":"https://api.github.com/users/Jholder112233/orgs","repos_url":"https://api.github.com/users/Jholder112233/repos","events_url":"https://api.github.com/users/Jholder112233/events{/privacy}","received_events_url":"https://api.github.com/users/Jholder112233/received_events","type":"User","site_admin":false},"body":"![screen shot 2014-10-17 at 15 46 01](https://cloud.githubusercontent.com/assets/2236852/4680607/58efe2a0-560c-11e4-9c7e-233e8f4230e9.png)\r\n\r\n1. Refactored block level sharing to abstract code for use on galleries and other content types in the future\r\n2. Block level sharing is now available in galleries, including lightbox mode","created_at":"2014-10-17T14:49:52Z","updated_at":"2014-10-20T10:20:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d3b57480d85f50d8f0beb4dda58267001ccda7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/6581/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/6581/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/6581/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/304c564f0c62b88c0bb79bab67eca0ba99c013e7","head":{"label":"guardian:block-level-sharing","ref":"block-level-sharing","sha":"304c564f0c62b88c0bb79bab67eca0ba99c013e7","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-10-20T10:15:14Z","pushed_at":"2014-10-20T09:47:38Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":491319,"stargazers_count":2366,"watchers_count":2366,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":100,"forks":200,"open_issues":100,"watchers":2366,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"66eb1f26bbe86bd8b6c8d075f44ed5cb83635e2f","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=2","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2014-10-20T10:15:14Z","pushed_at":"2014-10-20T09:47:38Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com/uk?view=mobile","size":491319,"stargazers_count":2366,"watchers_count":2366,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":100,"forks":200,"open_issues":100,"watchers":2366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6581"},"html":{"href":"https://github.com/guardian/frontend/pull/6581"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/6581"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/6581/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6581/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/6581/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/304c564f0c62b88c0bb79bab67eca0ba99c013e7"}}}}