GitHub PullRequestEvent at 2014-06-30 17:18:01
Repository: active_remote
Actor: brianstien
Payload: {"action":"closed","number":24,"pull_request":{"url":"https://api.github.com/repos/liveh2o/active_remote/pulls/24","id":17725172,"html_url":"https://github.com/liveh2o/active_remote/pull/24","diff_url":"https://github.com/liveh2o/active_remote/pull/24.diff","patch_url":"https://github.com/liveh2o/active_remote/pull/24.patch","issue_url":"https://api.github.com/repos/liveh2o/active_remote/issues/24","number":24,"state":"closed","title":"Make protobuf adapter threadsafe","user":{"login":"brianstien","id":1568220,"avatar_url":"https://avatars.githubusercontent.com/u/1568220?","gravatar_id":"683cab4ed57d1c2d17e57742097301fb","url":"https://api.github.com/users/brianstien","html_url":"https://github.com/brianstien","followers_url":"https://api.github.com/users/brianstien/followers","following_url":"https://api.github.com/users/brianstien/following{/other_user}","gists_url":"https://api.github.com/users/brianstien/gists{/gist_id}","starred_url":"https://api.github.com/users/brianstien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianstien/subscriptions","organizations_url":"https://api.github.com/users/brianstien/orgs","repos_url":"https://api.github.com/users/brianstien/repos","events_url":"https://api.github.com/users/brianstien/events{/privacy}","received_events_url":"https://api.github.com/users/brianstien/received_events","type":"User","site_admin":false},"body":"Since there is only a single instance of the rpc adater at the class\r\nlevel that all service calls use, when working in a multithreaded\r\nenvironment, we end up in a case where multiple threads are sharing the\r\nsame instance of the rpc adater class and therefore sharing the same\r\ninstance variables.\r\n\r\nThe problem causes undetermined results from service calls.  By removing\r\nthe instance variables and using local variables, it is safe to use the\r\nsame instance of the rpc adater from multiple threads.\r\n\r\nAn alternative solution would be to use a new instance of the rpc adater\r\nfor each service call, if you want to keep the instance varaibles.","created_at":"2014-06-27T20:47:26Z","updated_at":"2014-06-30T17:18:01Z","closed_at":"2014-06-30T17:18:01Z","merged_at":null,"merge_commit_sha":"e0465dca1c99fd93c8822db4555634e0be709489","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/liveh2o/active_remote/pulls/24/commits","review_comments_url":"https://api.github.com/repos/liveh2o/active_remote/pulls/24/comments","review_comment_url":"https://api.github.com/repos/liveh2o/active_remote/pulls/comments/{number}","comments_url":"https://api.github.com/repos/liveh2o/active_remote/issues/24/comments","statuses_url":"https://api.github.com/repos/liveh2o/active_remote/statuses/70cf4ab5aceab84b660f55807f429b4456c18a84","head":{"label":"brianstien:make_protobuf_adapter_threadsafe","ref":"make_protobuf_adapter_threadsafe","sha":"70cf4ab5aceab84b660f55807f429b4456c18a84","user":{"login":"brianstien","id":1568220,"avatar_url":"https://avatars.githubusercontent.com/u/1568220?","gravatar_id":"683cab4ed57d1c2d17e57742097301fb","url":"https://api.github.com/users/brianstien","html_url":"https://github.com/brianstien","followers_url":"https://api.github.com/users/brianstien/followers","following_url":"https://api.github.com/users/brianstien/following{/other_user}","gists_url":"https://api.github.com/users/brianstien/gists{/gist_id}","starred_url":"https://api.github.com/users/brianstien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianstien/subscriptions","organizations_url":"https://api.github.com/users/brianstien/orgs","repos_url":"https://api.github.com/users/brianstien/repos","events_url":"https://api.github.com/users/brianstien/events{/privacy}","received_events_url":"https://api.github.com/users/brianstien/received_events","type":"User","site_admin":false},"repo":{"id":19707655,"name":"active_remote","full_name":"brianstien/active_remote","owner":{"login":"brianstien","id":1568220,"avatar_url":"https://avatars.githubusercontent.com/u/1568220?","gravatar_id":"683cab4ed57d1c2d17e57742097301fb","url":"https://api.github.com/users/brianstien","html_url":"https://github.com/brianstien","followers_url":"https://api.github.com/users/brianstien/followers","following_url":"https://api.github.com/users/brianstien/following{/other_user}","gists_url":"https://api.github.com/users/brianstien/gists{/gist_id}","starred_url":"https://api.github.com/users/brianstien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianstien/subscriptions","organizations_url":"https://api.github.com/users/brianstien/orgs","repos_url":"https://api.github.com/users/brianstien/repos","events_url":"https://api.github.com/users/brianstien/events{/privacy}","received_events_url":"https://api.github.com/users/brianstien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianstien/active_remote","description":"Active Remote provides Active Record-like object-relational mapping over RPC. It's Active Record for your platform.","fork":true,"url":"https://api.github.com/repos/brianstien/active_remote","forks_url":"https://api.github.com/repos/brianstien/active_remote/forks","keys_url":"https://api.github.com/repos/brianstien/active_remote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianstien/active_remote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianstien/active_remote/teams","hooks_url":"https://api.github.com/repos/brianstien/active_remote/hooks","issue_events_url":"https://api.github.com/repos/brianstien/active_remote/issues/events{/number}","events_url":"https://api.github.com/repos/brianstien/active_remote/events","assignees_url":"https://api.github.com/repos/brianstien/active_remote/assignees{/user}","branches_url":"https://api.github.com/repos/brianstien/active_remote/branches{/branch}","tags_url":"https://api.github.com/repos/brianstien/active_remote/tags","blobs_url":"https://api.github.com/repos/brianstien/active_remote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianstien/active_remote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianstien/active_remote/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianstien/active_remote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianstien/active_remote/statuses/{sha}","languages_url":"https://api.github.com/repos/brianstien/active_remote/languages","stargazers_url":"https://api.github.com/repos/brianstien/active_remote/stargazers","contributors_url":"https://api.github.com/repos/brianstien/active_remote/contributors","subscribers_url":"https://api.github.com/repos/brianstien/active_remote/subscribers","subscription_url":"https://api.github.com/repos/brianstien/active_remote/subscription","commits_url":"https://api.github.com/repos/brianstien/active_remote/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianstien/active_remote/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianstien/active_remote/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianstien/active_remote/issues/comments/{number}","contents_url":"https://api.github.com/repos/brianstien/active_remote/contents/{+path}","compare_url":"https://api.github.com/repos/brianstien/active_remote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianstien/active_remote/merges","archive_url":"https://api.github.com/repos/brianstien/active_remote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianstien/active_remote/downloads","issues_url":"https://api.github.com/repos/brianstien/active_remote/issues{/number}","pulls_url":"https://api.github.com/repos/brianstien/active_remote/pulls{/number}","milestones_url":"https://api.github.com/repos/brianstien/active_remote/milestones{/number}","notifications_url":"https://api.github.com/repos/brianstien/active_remote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianstien/active_remote/labels{/name}","releases_url":"https://api.github.com/repos/brianstien/active_remote/releases{/id}","created_at":"2014-05-12T17:09:16Z","updated_at":"2014-05-12T17:09:17Z","pushed_at":"2014-06-30T16:49:46Z","git_url":"git://github.com/brianstien/active_remote.git","ssh_url":"git@github.com:brianstien/active_remote.git","clone_url":"https://github.com/brianstien/active_remote.git","svn_url":"https://github.com/brianstien/active_remote","homepage":null,"size":460,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"liveh2o:master","ref":"master","sha":"137a7ebf0d32ae5984a99923ae476b97797db223","user":{"login":"liveh2o","id":207933,"avatar_url":"https://avatars.githubusercontent.com/u/207933?","gravatar_id":"b1da0d56744cc6b8db22bc2c3a7d6c4f","url":"https://api.github.com/users/liveh2o","html_url":"https://github.com/liveh2o","followers_url":"https://api.github.com/users/liveh2o/followers","following_url":"https://api.github.com/users/liveh2o/following{/other_user}","gists_url":"https://api.github.com/users/liveh2o/gists{/gist_id}","starred_url":"https://api.github.com/users/liveh2o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liveh2o/subscriptions","organizations_url":"https://api.github.com/users/liveh2o/orgs","repos_url":"https://api.github.com/users/liveh2o/repos","events_url":"https://api.github.com/users/liveh2o/events{/privacy}","received_events_url":"https://api.github.com/users/liveh2o/received_events","type":"User","site_admin":false},"repo":{"id":6716431,"name":"active_remote","full_name":"liveh2o/active_remote","owner":{"login":"liveh2o","id":207933,"avatar_url":"https://avatars.githubusercontent.com/u/207933?","gravatar_id":"b1da0d56744cc6b8db22bc2c3a7d6c4f","url":"https://api.github.com/users/liveh2o","html_url":"https://github.com/liveh2o","followers_url":"https://api.github.com/users/liveh2o/followers","following_url":"https://api.github.com/users/liveh2o/following{/other_user}","gists_url":"https://api.github.com/users/liveh2o/gists{/gist_id}","starred_url":"https://api.github.com/users/liveh2o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liveh2o/subscriptions","organizations_url":"https://api.github.com/users/liveh2o/orgs","repos_url":"https://api.github.com/users/liveh2o/repos","events_url":"https://api.github.com/users/liveh2o/events{/privacy}","received_events_url":"https://api.github.com/users/liveh2o/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liveh2o/active_remote","description":"Active Remote provides Active Record-like object-relational mapping over RPC. It's Active Record for your platform.","fork":false,"url":"https://api.github.com/repos/liveh2o/active_remote","forks_url":"https://api.github.com/repos/liveh2o/active_remote/forks","keys_url":"https://api.github.com/repos/liveh2o/active_remote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liveh2o/active_remote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liveh2o/active_remote/teams","hooks_url":"https://api.github.com/repos/liveh2o/active_remote/hooks","issue_events_url":"https://api.github.com/repos/liveh2o/active_remote/issues/events{/number}","events_url":"https://api.github.com/repos/liveh2o/active_remote/events","assignees_url":"https://api.github.com/repos/liveh2o/active_remote/assignees{/user}","branches_url":"https://api.github.com/repos/liveh2o/active_remote/branches{/branch}","tags_url":"https://api.github.com/repos/liveh2o/active_remote/tags","blobs_url":"https://api.github.com/repos/liveh2o/active_remote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liveh2o/active_remote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liveh2o/active_remote/git/refs{/sha}","trees_url":"https://api.github.com/repos/liveh2o/active_remote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liveh2o/active_remote/statuses/{sha}","languages_url":"https://api.github.com/repos/liveh2o/active_remote/languages","stargazers_url":"https://api.github.com/repos/liveh2o/active_remote/stargazers","contributors_url":"https://api.github.com/repos/liveh2o/active_remote/contributors","subscribers_url":"https://api.github.com/repos/liveh2o/active_remote/subscribers","subscription_url":"https://api.github.com/repos/liveh2o/active_remote/subscription","commits_url":"https://api.github.com/repos/liveh2o/active_remote/commits{/sha}","git_commits_url":"https://api.github.com/repos/liveh2o/active_remote/git/commits{/sha}","comments_url":"https://api.github.com/repos/liveh2o/active_remote/comments{/number}","issue_comment_url":"https://api.github.com/repos/liveh2o/active_remote/issues/comments/{number}","contents_url":"https://api.github.com/repos/liveh2o/active_remote/contents/{+path}","compare_url":"https://api.github.com/repos/liveh2o/active_remote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liveh2o/active_remote/merges","archive_url":"https://api.github.com/repos/liveh2o/active_remote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liveh2o/active_remote/downloads","issues_url":"https://api.github.com/repos/liveh2o/active_remote/issues{/number}","pulls_url":"https://api.github.com/repos/liveh2o/active_remote/pulls{/number}","milestones_url":"https://api.github.com/repos/liveh2o/active_remote/milestones{/number}","notifications_url":"https://api.github.com/repos/liveh2o/active_remote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liveh2o/active_remote/labels{/name}","releases_url":"https://api.github.com/repos/liveh2o/active_remote/releases{/id}","created_at":"2012-11-16T04:34:45Z","updated_at":"2014-06-13T05:59:34Z","pushed_at":"2014-04-03T17:11:49Z","git_url":"git://github.com/liveh2o/active_remote.git","ssh_url":"git@github.com:liveh2o/active_remote.git","clone_url":"https://github.com/liveh2o/active_remote.git","svn_url":"https://github.com/liveh2o/active_remote","homepage":null,"size":1499,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liveh2o/active_remote/pulls/24"},"html":{"href":"https://github.com/liveh2o/active_remote/pull/24"},"issue":{"href":"https://api.github.com/repos/liveh2o/active_remote/issues/24"},"comments":{"href":"https://api.github.com/repos/liveh2o/active_remote/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/liveh2o/active_remote/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/liveh2o/active_remote/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/liveh2o/active_remote/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/liveh2o/active_remote/statuses/70cf4ab5aceab84b660f55807f429b4456c18a84"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":8,"review_comments":0,"commits":1,"additions":6,"deletions":5,"changed_files":1}}