GitHub PullRequestReviewCommentEvent at 2014-05-06 13:02:47
Repository: sailfish-browser
Actor: rainemak
Payload: {"comment":{"url":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/comments/12322630","id":12322630,"diff_hunk":"@@ -125,19 +119,21 @@ Item {\n \n     Timer {\n         id: delayedSuspend\n+        property bool suspendIntention\n \n-        function startSuspendTimer() {\n-            if (!delayedSuspend.running && _suspendIntention) {\n-                delayedSuspend.running = true\n+        // 1000ms was not enough to always allow buffering start of next song via 3G\n+        interval: 5000\n+        onTriggered: {\n+            if (!videoActive && !audioActive && suspendIntention) {\n+                suspendView()\n+            } else {\n+                resumeView()\n             }\n         }\n \n-        interval: 1000\n-        onTriggered: {\n-            if (!videoActive && !audioActive && _suspendIntention) {\n-                _suspendable = true\n-            } else {\n-                _suspendable = false\n+        onSuspendIntentionChanged: {\n+            if (!running && suspendIntention) {\n+                restart()","path":"src/pages/components/ResourceController.qml","position":124,"original_position":124,"commit_id":"8089b4ce44617eaa9b3311293938db30a9c8ac78","original_commit_id":"8089b4ce44617eaa9b3311293938db30a9c8ac78","user":{"login":"rainemak","id":3470958,"avatar_url":"https://avatars.githubusercontent.com/u/3470958?","gravatar_id":"1f16b61fde287b0b5ce995ec469500db","url":"https://api.github.com/users/rainemak","html_url":"https://github.com/rainemak","followers_url":"https://api.github.com/users/rainemak/followers","following_url":"https://api.github.com/users/rainemak/following{/other_user}","gists_url":"https://api.github.com/users/rainemak/gists{/gist_id}","starred_url":"https://api.github.com/users/rainemak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainemak/subscriptions","organizations_url":"https://api.github.com/users/rainemak/orgs","repos_url":"https://api.github.com/users/rainemak/repos","events_url":"https://api.github.com/users/rainemak/events{/privacy}","received_events_url":"https://api.github.com/users/rainemak/received_events","type":"User","site_admin":false},"body":"Other than above LGTM","created_at":"2014-05-06T13:02:47Z","updated_at":"2014-05-06T13:02:47Z","html_url":"https://github.com/sailfishos/sailfish-browser/pull/126#discussion_r12322630","pull_request_url":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/comments/12322630"},"html":{"href":"https://github.com/sailfishos/sailfish-browser/pull/126#discussion_r12322630"},"pull_request":{"href":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/126"}}}}