GitHub PullRequestReviewCommentEvent at 2014-04-15 14:20:35
Repository: vcloud-walker
Actor: annashipman
Payload: {"comment":{"url":"https://api.github.com/repos/alphagov/vcloud-walker/pulls/comments/11635995","id":11635995,"diff_hunk":"@@ -118,5 +75,73 @@\n     end\n \n   end\n+\n+\n+  context 'populate summary vm model for 5.1 api on vcloud director 5.5' do\n+    before(:each) do\n+      fog_vm = assemble_sample_vm_data  Fog::ServiceLayerStub.vcloud_director_5_5_with_v5_1_api_ids\n+\n+      @metadata = {:name => 'web-app-1', :shutdown => true}\n+      Vcloud::Core::Vm.should_receive(:get_metadata).with(\"vm-aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee\").and_return(@metadata)\n+\n+      @vm_summary = Vcloud::Walker::Resource::Vm.new(fog_vm)\n+    end\n+\n+    it \"report disk info for 5.1 api on 5.5\" do\n+      @vm_summary.disks.count.should == 2\n+      @vm_summary.disks.first.should == {:name => \"Hard disk 1\", :size => 11265}\n+      @vm_summary.disks.last.should == {:name => \"Hard disk 2\", :size => 307200}\n+    end\n+\n+  end\n+\n+  def assemble_sample_vm_data api_version\n+    {\n+      :deployed                     => \"true\",\n+      :status                       => \"8\",\n+      :name                         => \"ubuntu-testing-template\",\n+      :id                           => \"urn:vcloud:vm:aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee\",\n+      :href                         => 'https://myvdc.carrenza.net/api/vApp/vm-aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee',\n+      :\"ovf:VirtualHardwareSection\" =>\n+        {:\"ovf:Info\"   => \"Virtual hardware requirements\",\n+         :\"ovf:System\" => {:\"vssd:ElementName\" => \"Virtual Hardware Family\", :\"vssd:VirtualSystemType\" => \"vmx-08\"},","path":"spec/walk/vm_spec.rb","position":88,"original_position":88,"commit_id":"db0c4da47e5e169b4f89c6a4782a112b3f2ce5f1","original_commit_id":"db0c4da47e5e169b4f89c6a4782a112b3f2ce5f1","user":{"login":"annashipman","id":719118,"avatar_url":"https://avatars.githubusercontent.com/u/719118?","gravatar_id":"02ee13bc758d7c64e177bcc4099c2976","url":"https://api.github.com/users/annashipman","html_url":"https://github.com/annashipman","followers_url":"https://api.github.com/users/annashipman/followers","following_url":"https://api.github.com/users/annashipman/following{/other_user}","gists_url":"https://api.github.com/users/annashipman/gists{/gist_id}","starred_url":"https://api.github.com/users/annashipman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annashipman/subscriptions","organizations_url":"https://api.github.com/users/annashipman/orgs","repos_url":"https://api.github.com/users/annashipman/repos","events_url":"https://api.github.com/users/annashipman/events{/privacy}","received_events_url":"https://api.github.com/users/annashipman/received_events","type":"User","site_admin":false},"body":"If you split this over two lines it won't scroll off","created_at":"2014-04-15T14:20:35Z","updated_at":"2014-04-15T14:20:35Z","html_url":"https://github.com/alphagov/vcloud-walker/pull/61#discussion_r11635995","pull_request_url":"https://api.github.com/repos/alphagov/vcloud-walker/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/alphagov/vcloud-walker/pulls/comments/11635995"},"html":{"href":"https://github.com/alphagov/vcloud-walker/pull/61#discussion_r11635995"},"pull_request":{"href":"https://api.github.com/repos/alphagov/vcloud-walker/pulls/61"}}}}