GitHub PullRequestReviewCommentEvent at 2014-07-20 00:13:05
Repository: baseflight
Actor: norem
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/multiwii/baseflight/pulls/comments/15146861","id":15146861,"diff_hunk":"@@ -940,68 +944,111 @@ static bool gpsNewFrameNMEA(char c)\n     uint8_t frameOK = 0;\r\n     static uint8_t param = 0, offset = 0, parity = 0;\r\n     static char string[15];\r\n-    static uint8_t checksum_param, frame = 0;\r\n-\r\n-    if (c == '$') {\r\n+    static uint8_t checksum_param, gps_frame = NO_FRAME;\r\n+    static int32_t GPS_temp[2];\r\n+    static uint8_t GPS_numSat_temp;\r\n+    static uint16_t GPS_altitude_temp, GPS_speed_temp;\r\n+    static uint16_t GPS_ground_course_temp;\r","path":"src/gps.c","position":29,"original_position":29,"commit_id":"f9c947d01a947089400ad1453dc77514efa674ca","original_commit_id":"f9c947d01a947089400ad1453dc77514efa674ca","user":{"login":"norem","id":2971635,"avatar_url":"https://avatars.githubusercontent.com/u/2971635?","gravatar_id":"d9de51748868f73fd2128e423e07ba89","url":"https://api.github.com/users/norem","html_url":"https://github.com/norem","followers_url":"https://api.github.com/users/norem/followers","following_url":"https://api.github.com/users/norem/following{/other_user}","gists_url":"https://api.github.com/users/norem/gists{/gist_id}","starred_url":"https://api.github.com/users/norem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norem/subscriptions","organizations_url":"https://api.github.com/users/norem/orgs","repos_url":"https://api.github.com/users/norem/repos","events_url":"https://api.github.com/users/norem/events{/privacy}","received_events_url":"https://api.github.com/users/norem/received_events","type":"User","site_admin":false},"body":"Made changes into structure looks way better... but I have not burned it to test yet, will do that when I can","created_at":"2014-07-20T00:13:05Z","updated_at":"2014-07-20T00:13:05Z","html_url":"https://github.com/multiwii/baseflight/pull/139#discussion_r15146861","pull_request_url":"https://api.github.com/repos/multiwii/baseflight/pulls/139","_links":{"self":{"href":"https://api.github.com/repos/multiwii/baseflight/pulls/comments/15146861"},"html":{"href":"https://github.com/multiwii/baseflight/pull/139#discussion_r15146861"},"pull_request":{"href":"https://api.github.com/repos/multiwii/baseflight/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/multiwii/baseflight/pulls/139","id":18506176,"html_url":"https://github.com/multiwii/baseflight/pull/139","diff_url":"https://github.com/multiwii/baseflight/pull/139.diff","patch_url":"https://github.com/multiwii/baseflight/pull/139.patch","issue_url":"https://api.github.com/repos/multiwii/baseflight/issues/139","number":139,"state":"open","title":"Update gps.c","user":{"login":"norem","id":2971635,"avatar_url":"https://avatars.githubusercontent.com/u/2971635?","gravatar_id":"d9de51748868f73fd2128e423e07ba89","url":"https://api.github.com/users/norem","html_url":"https://github.com/norem","followers_url":"https://api.github.com/users/norem/followers","following_url":"https://api.github.com/users/norem/following{/other_user}","gists_url":"https://api.github.com/users/norem/gists{/gist_id}","starred_url":"https://api.github.com/users/norem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norem/subscriptions","organizations_url":"https://api.github.com/users/norem/orgs","repos_url":"https://api.github.com/users/norem/repos","events_url":"https://api.github.com/users/norem/events{/privacy}","received_events_url":"https://api.github.com/users/norem/received_events","type":"User","site_admin":false},"body":"Now properly uses checksum before applying data in NMEA which corrects sign dropping in Latitude and Longitude","created_at":"2014-07-17T01:58:11Z","updated_at":"2014-07-20T00:13:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc01bb2193b3dc6aae10793cfb96526adb1130e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/multiwii/baseflight/pulls/139/commits","review_comments_url":"https://api.github.com/repos/multiwii/baseflight/pulls/139/comments","review_comment_url":"https://api.github.com/repos/multiwii/baseflight/pulls/comments/{number}","comments_url":"https://api.github.com/repos/multiwii/baseflight/issues/139/comments","statuses_url":"https://api.github.com/repos/multiwii/baseflight/statuses/f9c947d01a947089400ad1453dc77514efa674ca","head":{"label":"norem:master","ref":"master","sha":"f9c947d01a947089400ad1453dc77514efa674ca","user":{"login":"norem","id":2971635,"avatar_url":"https://avatars.githubusercontent.com/u/2971635?","gravatar_id":"d9de51748868f73fd2128e423e07ba89","url":"https://api.github.com/users/norem","html_url":"https://github.com/norem","followers_url":"https://api.github.com/users/norem/followers","following_url":"https://api.github.com/users/norem/following{/other_user}","gists_url":"https://api.github.com/users/norem/gists{/gist_id}","starred_url":"https://api.github.com/users/norem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norem/subscriptions","organizations_url":"https://api.github.com/users/norem/orgs","repos_url":"https://api.github.com/users/norem/repos","events_url":"https://api.github.com/users/norem/events{/privacy}","received_events_url":"https://api.github.com/users/norem/received_events","type":"User","site_admin":false},"repo":{"id":21923848,"name":"baseflight","full_name":"norem/baseflight","owner":{"login":"norem","id":2971635,"avatar_url":"https://avatars.githubusercontent.com/u/2971635?","gravatar_id":"d9de51748868f73fd2128e423e07ba89","url":"https://api.github.com/users/norem","html_url":"https://github.com/norem","followers_url":"https://api.github.com/users/norem/followers","following_url":"https://api.github.com/users/norem/following{/other_user}","gists_url":"https://api.github.com/users/norem/gists{/gist_id}","starred_url":"https://api.github.com/users/norem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norem/subscriptions","organizations_url":"https://api.github.com/users/norem/orgs","repos_url":"https://api.github.com/users/norem/repos","events_url":"https://api.github.com/users/norem/events{/privacy}","received_events_url":"https://api.github.com/users/norem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/norem/baseflight","description":"32 bit fork of the MultiWii RC flight controller firmware","fork":true,"url":"https://api.github.com/repos/norem/baseflight","forks_url":"https://api.github.com/repos/norem/baseflight/forks","keys_url":"https://api.github.com/repos/norem/baseflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/norem/baseflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/norem/baseflight/teams","hooks_url":"https://api.github.com/repos/norem/baseflight/hooks","issue_events_url":"https://api.github.com/repos/norem/baseflight/issues/events{/number}","events_url":"https://api.github.com/repos/norem/baseflight/events","assignees_url":"https://api.github.com/repos/norem/baseflight/assignees{/user}","branches_url":"https://api.github.com/repos/norem/baseflight/branches{/branch}","tags_url":"https://api.github.com/repos/norem/baseflight/tags","blobs_url":"https://api.github.com/repos/norem/baseflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/norem/baseflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/norem/baseflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/norem/baseflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/norem/baseflight/statuses/{sha}","languages_url":"https://api.github.com/repos/norem/baseflight/languages","stargazers_url":"https://api.github.com/repos/norem/baseflight/stargazers","contributors_url":"https://api.github.com/repos/norem/baseflight/contributors","subscribers_url":"https://api.github.com/repos/norem/baseflight/subscribers","subscription_url":"https://api.github.com/repos/norem/baseflight/subscription","commits_url":"https://api.github.com/repos/norem/baseflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/norem/baseflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/norem/baseflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/norem/baseflight/issues/comments/{number}","contents_url":"https://api.github.com/repos/norem/baseflight/contents/{+path}","compare_url":"https://api.github.com/repos/norem/baseflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/norem/baseflight/merges","archive_url":"https://api.github.com/repos/norem/baseflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/norem/baseflight/downloads","issues_url":"https://api.github.com/repos/norem/baseflight/issues{/number}","pulls_url":"https://api.github.com/repos/norem/baseflight/pulls{/number}","milestones_url":"https://api.github.com/repos/norem/baseflight/milestones{/number}","notifications_url":"https://api.github.com/repos/norem/baseflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/norem/baseflight/labels{/name}","releases_url":"https://api.github.com/repos/norem/baseflight/releases{/id}","created_at":"2014-07-17T01:08:57Z","updated_at":"2014-07-17T01:45:20Z","pushed_at":"2014-07-17T01:45:20Z","git_url":"git://github.com/norem/baseflight.git","ssh_url":"git@github.com:norem/baseflight.git","clone_url":"https://github.com/norem/baseflight.git","svn_url":"https://github.com/norem/baseflight","homepage":null,"size":18946,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"multiwii:master","ref":"master","sha":"75ba7385f4dc60d5f47ee902ff56322aa7cac33e","user":{"login":"multiwii","id":2006666,"avatar_url":"https://avatars.githubusercontent.com/u/2006666?","gravatar_id":"9fb58826e4f54ffaff4e03ddb8d51872","url":"https://api.github.com/users/multiwii","html_url":"https://github.com/multiwii","followers_url":"https://api.github.com/users/multiwii/followers","following_url":"https://api.github.com/users/multiwii/following{/other_user}","gists_url":"https://api.github.com/users/multiwii/gists{/gist_id}","starred_url":"https://api.github.com/users/multiwii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/multiwii/subscriptions","organizations_url":"https://api.github.com/users/multiwii/orgs","repos_url":"https://api.github.com/users/multiwii/repos","events_url":"https://api.github.com/users/multiwii/events{/privacy}","received_events_url":"https://api.github.com/users/multiwii/received_events","type":"Organization","site_admin":false},"repo":{"id":5689182,"name":"baseflight","full_name":"multiwii/baseflight","owner":{"login":"multiwii","id":2006666,"avatar_url":"https://avatars.githubusercontent.com/u/2006666?","gravatar_id":"9fb58826e4f54ffaff4e03ddb8d51872","url":"https://api.github.com/users/multiwii","html_url":"https://github.com/multiwii","followers_url":"https://api.github.com/users/multiwii/followers","following_url":"https://api.github.com/users/multiwii/following{/other_user}","gists_url":"https://api.github.com/users/multiwii/gists{/gist_id}","starred_url":"https://api.github.com/users/multiwii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/multiwii/subscriptions","organizations_url":"https://api.github.com/users/multiwii/orgs","repos_url":"https://api.github.com/users/multiwii/repos","events_url":"https://api.github.com/users/multiwii/events{/privacy}","received_events_url":"https://api.github.com/users/multiwii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/multiwii/baseflight","description":"32 bit fork of the MultiWii RC flight controller firmware","fork":false,"url":"https://api.github.com/repos/multiwii/baseflight","forks_url":"https://api.github.com/repos/multiwii/baseflight/forks","keys_url":"https://api.github.com/repos/multiwii/baseflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/multiwii/baseflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/multiwii/baseflight/teams","hooks_url":"https://api.github.com/repos/multiwii/baseflight/hooks","issue_events_url":"https://api.github.com/repos/multiwii/baseflight/issues/events{/number}","events_url":"https://api.github.com/repos/multiwii/baseflight/events","assignees_url":"https://api.github.com/repos/multiwii/baseflight/assignees{/user}","branches_url":"https://api.github.com/repos/multiwii/baseflight/branches{/branch}","tags_url":"https://api.github.com/repos/multiwii/baseflight/tags","blobs_url":"https://api.github.com/repos/multiwii/baseflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/multiwii/baseflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/multiwii/baseflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/multiwii/baseflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/multiwii/baseflight/statuses/{sha}","languages_url":"https://api.github.com/repos/multiwii/baseflight/languages","stargazers_url":"https://api.github.com/repos/multiwii/baseflight/stargazers","contributors_url":"https://api.github.com/repos/multiwii/baseflight/contributors","subscribers_url":"https://api.github.com/repos/multiwii/baseflight/subscribers","subscription_url":"https://api.github.com/repos/multiwii/baseflight/subscription","commits_url":"https://api.github.com/repos/multiwii/baseflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/multiwii/baseflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/multiwii/baseflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/multiwii/baseflight/issues/comments/{number}","contents_url":"https://api.github.com/repos/multiwii/baseflight/contents/{+path}","compare_url":"https://api.github.com/repos/multiwii/baseflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/multiwii/baseflight/merges","archive_url":"https://api.github.com/repos/multiwii/baseflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/multiwii/baseflight/downloads","issues_url":"https://api.github.com/repos/multiwii/baseflight/issues{/number}","pulls_url":"https://api.github.com/repos/multiwii/baseflight/pulls{/number}","milestones_url":"https://api.github.com/repos/multiwii/baseflight/milestones{/number}","notifications_url":"https://api.github.com/repos/multiwii/baseflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/multiwii/baseflight/labels{/name}","releases_url":"https://api.github.com/repos/multiwii/baseflight/releases{/id}","created_at":"2012-09-05T15:27:39Z","updated_at":"2014-07-16T15:48:17Z","pushed_at":"2014-07-15T23:46:35Z","git_url":"git://github.com/multiwii/baseflight.git","ssh_url":"git@github.com:multiwii/baseflight.git","clone_url":"https://github.com/multiwii/baseflight.git","svn_url":"https://github.com/multiwii/baseflight","homepage":null,"size":18946,"stargazers_count":77,"watchers_count":77,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":79,"mirror_url":null,"open_issues_count":20,"forks":79,"open_issues":20,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/multiwii/baseflight/pulls/139"},"html":{"href":"https://github.com/multiwii/baseflight/pull/139"},"issue":{"href":"https://api.github.com/repos/multiwii/baseflight/issues/139"},"comments":{"href":"https://api.github.com/repos/multiwii/baseflight/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/multiwii/baseflight/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/multiwii/baseflight/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/multiwii/baseflight/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/multiwii/baseflight/statuses/f9c947d01a947089400ad1453dc77514efa674ca"}}}}