GitHub PullRequestReviewCommentEvent at 2014-09-26 21:22:21
Repository: shiny
Actor: jcheng5
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rstudio/shiny/pulls/comments/18114643","id":18114643,"diff_hunk":"@@ -2778,13 +2817,18 @@\n       uploader.abort();\n \n     var files = evt.target.files;\n+    var IE8 = files === undefined;","path":"inst/www/shared/shiny.js","position":50,"original_position":50,"commit_id":"b206525f8e8a9e88f7a554c5345fc77c8cc78c5b","original_commit_id":"b206525f8e8a9e88f7a554c5345fc77c8cc78c5b","user":{"login":"jcheng5","id":129551,"avatar_url":"https://avatars.githubusercontent.com/u/129551?v=2","gravatar_id":"","url":"https://api.github.com/users/jcheng5","html_url":"https://github.com/jcheng5","followers_url":"https://api.github.com/users/jcheng5/followers","following_url":"https://api.github.com/users/jcheng5/following{/other_user}","gists_url":"https://api.github.com/users/jcheng5/gists{/gist_id}","starred_url":"https://api.github.com/users/jcheng5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcheng5/subscriptions","organizations_url":"https://api.github.com/users/jcheng5/orgs","repos_url":"https://api.github.com/users/jcheng5/repos","events_url":"https://api.github.com/users/jcheng5/events{/privacy}","received_events_url":"https://api.github.com/users/jcheng5/received_events","type":"User","site_admin":false},"body":"I think the generally accepted best practice here is `typeof(files) === \"undefined\"`, since undefined can actually be defined :)","created_at":"2014-09-26T21:22:21Z","updated_at":"2014-09-26T21:22:21Z","html_url":"https://github.com/rstudio/shiny/pull/598#discussion_r18114643","pull_request_url":"https://api.github.com/repos/rstudio/shiny/pulls/598","_links":{"self":{"href":"https://api.github.com/repos/rstudio/shiny/pulls/comments/18114643"},"html":{"href":"https://github.com/rstudio/shiny/pull/598#discussion_r18114643"},"pull_request":{"href":"https://api.github.com/repos/rstudio/shiny/pulls/598"}}},"pull_request":{"url":"https://api.github.com/repos/rstudio/shiny/pulls/598","id":21819382,"html_url":"https://github.com/rstudio/shiny/pull/598","diff_url":"https://github.com/rstudio/shiny/pull/598.diff","patch_url":"https://github.com/rstudio/shiny/pull/598.patch","issue_url":"https://api.github.com/repos/rstudio/shiny/issues/598","number":598,"state":"open","locked":false,"title":"IE8/9 file upload","user":{"login":"yihui","id":163582,"avatar_url":"https://avatars.githubusercontent.com/u/163582?v=2","gravatar_id":"","url":"https://api.github.com/users/yihui","html_url":"https://github.com/yihui","followers_url":"https://api.github.com/users/yihui/followers","following_url":"https://api.github.com/users/yihui/following{/other_user}","gists_url":"https://api.github.com/users/yihui/gists{/gist_id}","starred_url":"https://api.github.com/users/yihui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yihui/subscriptions","organizations_url":"https://api.github.com/users/yihui/orgs","repos_url":"https://api.github.com/users/yihui/repos","events_url":"https://api.github.com/users/yihui/events{/privacy}","received_events_url":"https://api.github.com/users/yihui/received_events","type":"User","site_admin":false},"body":"Demo: https://demo.shinyapps.io/09_upload/\r\n\r\nYou can use a sample CSV file, say `write.csv(iris, 'iris.csv', row.names = FALSE)`.\r\n\r\n![screen shot 2014-09-25 at 4 52 20 pm](https://cloud.githubusercontent.com/assets/163582/4413712/9f637652-4509-11e4-9abe-33d03979c3f0.png)\r\n","created_at":"2014-09-25T23:14:18Z","updated_at":"2014-09-26T21:22:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fd221136f1c2b22549601f76c7dbbba97c42565","assignee":null,"milestone":{"url":"https://api.github.com/repos/rstudio/shiny/milestones/4","labels_url":"https://api.github.com/repos/rstudio/shiny/milestones/4/labels","id":731394,"number":4,"title":"0.10.2","description":"","creator":{"login":"yihui","id":163582,"avatar_url":"https://avatars.githubusercontent.com/u/163582?v=2","gravatar_id":"","url":"https://api.github.com/users/yihui","html_url":"https://github.com/yihui","followers_url":"https://api.github.com/users/yihui/followers","following_url":"https://api.github.com/users/yihui/following{/other_user}","gists_url":"https://api.github.com/users/yihui/gists{/gist_id}","starred_url":"https://api.github.com/users/yihui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yihui/subscriptions","organizations_url":"https://api.github.com/users/yihui/orgs","repos_url":"https://api.github.com/users/yihui/repos","events_url":"https://api.github.com/users/yihui/events{/privacy}","received_events_url":"https://api.github.com/users/yihui/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":31,"state":"open","created_at":"2014-07-24T21:53:14Z","updated_at":"2014-09-25T23:14:22Z","due_on":null},"commits_url":"https://api.github.com/repos/rstudio/shiny/pulls/598/commits","review_comments_url":"https://api.github.com/repos/rstudio/shiny/pulls/598/comments","review_comment_url":"https://api.github.com/repos/rstudio/shiny/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rstudio/shiny/issues/598/comments","statuses_url":"https://api.github.com/repos/rstudio/shiny/statuses/b206525f8e8a9e88f7a554c5345fc77c8cc78c5b","head":{"label":"yihui:feature/ie8-uploads","ref":"feature/ie8-uploads","sha":"b206525f8e8a9e88f7a554c5345fc77c8cc78c5b","user":{"login":"yihui","id":163582,"avatar_url":"https://avatars.githubusercontent.com/u/163582?v=2","gravatar_id":"","url":"https://api.github.com/users/yihui","html_url":"https://github.com/yihui","followers_url":"https://api.github.com/users/yihui/followers","following_url":"https://api.github.com/users/yihui/following{/other_user}","gists_url":"https://api.github.com/users/yihui/gists{/gist_id}","starred_url":"https://api.github.com/users/yihui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yihui/subscriptions","organizations_url":"https://api.github.com/users/yihui/orgs","repos_url":"https://api.github.com/users/yihui/repos","events_url":"https://api.github.com/users/yihui/events{/privacy}","received_events_url":"https://api.github.com/users/yihui/received_events","type":"User","site_admin":false},"repo":{"id":13264325,"name":"shiny","full_name":"yihui/shiny","owner":{"login":"yihui","id":163582,"avatar_url":"https://avatars.githubusercontent.com/u/163582?v=2","gravatar_id":"","url":"https://api.github.com/users/yihui","html_url":"https://github.com/yihui","followers_url":"https://api.github.com/users/yihui/followers","following_url":"https://api.github.com/users/yihui/following{/other_user}","gists_url":"https://api.github.com/users/yihui/gists{/gist_id}","starred_url":"https://api.github.com/users/yihui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yihui/subscriptions","organizations_url":"https://api.github.com/users/yihui/orgs","repos_url":"https://api.github.com/users/yihui/repos","events_url":"https://api.github.com/users/yihui/events{/privacy}","received_events_url":"https://api.github.com/users/yihui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yihui/shiny","description":"Easy interactive web applications with R","fork":true,"url":"https://api.github.com/repos/yihui/shiny","forks_url":"https://api.github.com/repos/yihui/shiny/forks","keys_url":"https://api.github.com/repos/yihui/shiny/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yihui/shiny/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yihui/shiny/teams","hooks_url":"https://api.github.com/repos/yihui/shiny/hooks","issue_events_url":"https://api.github.com/repos/yihui/shiny/issues/events{/number}","events_url":"https://api.github.com/repos/yihui/shiny/events","assignees_url":"https://api.github.com/repos/yihui/shiny/assignees{/user}","branches_url":"https://api.github.com/repos/yihui/shiny/branches{/branch}","tags_url":"https://api.github.com/repos/yihui/shiny/tags","blobs_url":"https://api.github.com/repos/yihui/shiny/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yihui/shiny/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yihui/shiny/git/refs{/sha}","trees_url":"https://api.github.com/repos/yihui/shiny/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yihui/shiny/statuses/{sha}","languages_url":"https://api.github.com/repos/yihui/shiny/languages","stargazers_url":"https://api.github.com/repos/yihui/shiny/stargazers","contributors_url":"https://api.github.com/repos/yihui/shiny/contributors","subscribers_url":"https://api.github.com/repos/yihui/shiny/subscribers","subscription_url":"https://api.github.com/repos/yihui/shiny/subscription","commits_url":"https://api.github.com/repos/yihui/shiny/commits{/sha}","git_commits_url":"https://api.github.com/repos/yihui/shiny/git/commits{/sha}","comments_url":"https://api.github.com/repos/yihui/shiny/comments{/number}","issue_comment_url":"https://api.github.com/repos/yihui/shiny/issues/comments/{number}","contents_url":"https://api.github.com/repos/yihui/shiny/contents/{+path}","compare_url":"https://api.github.com/repos/yihui/shiny/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yihui/shiny/merges","archive_url":"https://api.github.com/repos/yihui/shiny/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yihui/shiny/downloads","issues_url":"https://api.github.com/repos/yihui/shiny/issues{/number}","pulls_url":"https://api.github.com/repos/yihui/shiny/pulls{/number}","milestones_url":"https://api.github.com/repos/yihui/shiny/milestones{/number}","notifications_url":"https://api.github.com/repos/yihui/shiny/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yihui/shiny/labels{/name}","releases_url":"https://api.github.com/repos/yihui/shiny/releases{/id}","created_at":"2013-10-02T06:38:49Z","updated_at":"2014-06-25T15:42:03Z","pushed_at":"2014-09-25T23:10:17Z","git_url":"git://github.com/yihui/shiny.git","ssh_url":"git@github.com:yihui/shiny.git","clone_url":"https://github.com/yihui/shiny.git","svn_url":"https://github.com/yihui/shiny","homepage":"http://rstudio.com/shiny/","size":8454,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rstudio:master","ref":"master","sha":"76535c1da55867266b46c14f56c7b8bb36e61de9","user":{"login":"rstudio","id":513560,"avatar_url":"https://avatars.githubusercontent.com/u/513560?v=2","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"repo":{"id":4729944,"name":"shiny","full_name":"rstudio/shiny","owner":{"login":"rstudio","id":513560,"avatar_url":"https://avatars.githubusercontent.com/u/513560?v=2","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rstudio/shiny","description":"Easy interactive web applications with R","fork":false,"url":"https://api.github.com/repos/rstudio/shiny","forks_url":"https://api.github.com/repos/rstudio/shiny/forks","keys_url":"https://api.github.com/repos/rstudio/shiny/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstudio/shiny/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstudio/shiny/teams","hooks_url":"https://api.github.com/repos/rstudio/shiny/hooks","issue_events_url":"https://api.github.com/repos/rstudio/shiny/issues/events{/number}","events_url":"https://api.github.com/repos/rstudio/shiny/events","assignees_url":"https://api.github.com/repos/rstudio/shiny/assignees{/user}","branches_url":"https://api.github.com/repos/rstudio/shiny/branches{/branch}","tags_url":"https://api.github.com/repos/rstudio/shiny/tags","blobs_url":"https://api.github.com/repos/rstudio/shiny/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstudio/shiny/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstudio/shiny/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstudio/shiny/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstudio/shiny/statuses/{sha}","languages_url":"https://api.github.com/repos/rstudio/shiny/languages","stargazers_url":"https://api.github.com/repos/rstudio/shiny/stargazers","contributors_url":"https://api.github.com/repos/rstudio/shiny/contributors","subscribers_url":"https://api.github.com/repos/rstudio/shiny/subscribers","subscription_url":"https://api.github.com/repos/rstudio/shiny/subscription","commits_url":"https://api.github.com/repos/rstudio/shiny/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstudio/shiny/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstudio/shiny/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstudio/shiny/issues/comments/{number}","contents_url":"https://api.github.com/repos/rstudio/shiny/contents/{+path}","compare_url":"https://api.github.com/repos/rstudio/shiny/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstudio/shiny/merges","archive_url":"https://api.github.com/repos/rstudio/shiny/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstudio/shiny/downloads","issues_url":"https://api.github.com/repos/rstudio/shiny/issues{/number}","pulls_url":"https://api.github.com/repos/rstudio/shiny/pulls{/number}","milestones_url":"https://api.github.com/repos/rstudio/shiny/milestones{/number}","notifications_url":"https://api.github.com/repos/rstudio/shiny/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstudio/shiny/labels{/name}","releases_url":"https://api.github.com/repos/rstudio/shiny/releases{/id}","created_at":"2012-06-20T18:45:11Z","updated_at":"2014-09-26T02:30:14Z","pushed_at":"2014-09-24T21:40:05Z","git_url":"git://github.com/rstudio/shiny.git","ssh_url":"git@github.com:rstudio/shiny.git","clone_url":"https://github.com/rstudio/shiny.git","svn_url":"https://github.com/rstudio/shiny","homepage":"http://shiny.rstudio.com","size":15600,"stargazers_count":810,"watchers_count":810,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":316,"mirror_url":null,"open_issues_count":99,"forks":316,"open_issues":99,"watchers":810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rstudio/shiny/pulls/598"},"html":{"href":"https://github.com/rstudio/shiny/pull/598"},"issue":{"href":"https://api.github.com/repos/rstudio/shiny/issues/598"},"comments":{"href":"https://api.github.com/repos/rstudio/shiny/issues/598/comments"},"review_comments":{"href":"https://api.github.com/repos/rstudio/shiny/pulls/598/comments"},"review_comment":{"href":"https://api.github.com/repos/rstudio/shiny/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rstudio/shiny/pulls/598/commits"},"statuses":{"href":"https://api.github.com/repos/rstudio/shiny/statuses/b206525f8e8a9e88f7a554c5345fc77c8cc78c5b"}}}}