GitHub PullRequestReviewCommentEvent at 2014-09-16 17:15:09
Repository: phobos
Actor: 9il
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/17615705","id":17615705,"diff_hunk":"@@ -2103,12 +2103,29 @@ unittest\n  *      $(TR $(TD $(PLUSMN)$(NAN)) $(TD $(PLUSMN)$(NAN)) $(TD int.min))\n  *      )\n  */\n+\n real frexp(real value, out int exp) @trusted pure nothrow @nogc\n+{ return frexpImpl(value, exp); }\n+\n+///ditto\n+double frexp(double value, out int exp) @trusted pure nothrow @nogc\n+{ return frexpImpl(value, exp); }\n+\n+///ditto\n+float frexp(float value, out int exp) @trusted pure nothrow @nogc\n+{ return frexpImpl(value, exp); }\n+\n+\n+private T frexpImpl(T)(T value, out int exp) @trusted pure nothrow @nogc\n+    if(isFloatingPoint!T)","path":"std/math.d","position":18,"original_position":18,"commit_id":"298942b7ed6722393e16bb8d52c934c29d268009","original_commit_id":"298942b7ed6722393e16bb8d52c934c29d268009","user":{"login":"9il","id":845083,"avatar_url":"https://avatars.githubusercontent.com/u/845083?v=2","gravatar_id":"680708ea782b686ba97bf0fde1c4dcd8","url":"https://api.github.com/users/9il","html_url":"https://github.com/9il","followers_url":"https://api.github.com/users/9il/followers","following_url":"https://api.github.com/users/9il/following{/other_user}","gists_url":"https://api.github.com/users/9il/gists{/gist_id}","starred_url":"https://api.github.com/users/9il/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9il/subscriptions","organizations_url":"https://api.github.com/users/9il/orgs","repos_url":"https://api.github.com/users/9il/repos","events_url":"https://api.github.com/users/9il/events{/privacy}","received_events_url":"https://api.github.com/users/9il/received_events","type":"User","site_admin":false},"body":"\r\nThis stuff:\r\n+///ditto\r\n+double frexp(double value, out int exp) @trusted pure nothrow @nogc\r\n+{ return frexpImpl(value, exp); }\r\n","created_at":"2014-09-16T17:15:09Z","updated_at":"2014-09-16T17:15:09Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/2508#discussion_r17615705","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2508","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/17615705"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2508#discussion_r17615705"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2508"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2508","id":21027090,"html_url":"https://github.com/D-Programming-Language/phobos/pull/2508","diff_url":"https://github.com/D-Programming-Language/phobos/pull/2508.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/2508.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2508","number":2508,"state":"open","locked":false,"title":"std.math: added frexp for double and float","user":{"login":"9il","id":845083,"avatar_url":"https://avatars.githubusercontent.com/u/845083?v=2","gravatar_id":"680708ea782b686ba97bf0fde1c4dcd8","url":"https://api.github.com/users/9il","html_url":"https://github.com/9il","followers_url":"https://api.github.com/users/9il/followers","following_url":"https://api.github.com/users/9il/following{/other_user}","gists_url":"https://api.github.com/users/9il/gists{/gist_id}","starred_url":"https://api.github.com/users/9il/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9il/subscriptions","organizations_url":"https://api.github.com/users/9il/orgs","repos_url":"https://api.github.com/users/9il/repos","events_url":"https://api.github.com/users/9il/events{/privacy}","received_events_url":"https://api.github.com/users/9il/received_events","type":"User","site_admin":false},"body":"For speed.","created_at":"2014-09-10T15:07:10Z","updated_at":"2014-09-16T17:15:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9901a6222b3d42ab58389880697206f88200b243","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2508/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2508/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2508/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/298942b7ed6722393e16bb8d52c934c29d268009","head":{"label":"9il:frexp-single-double","ref":"frexp-single-double","sha":"298942b7ed6722393e16bb8d52c934c29d268009","user":{"login":"9il","id":845083,"avatar_url":"https://avatars.githubusercontent.com/u/845083?v=2","gravatar_id":"680708ea782b686ba97bf0fde1c4dcd8","url":"https://api.github.com/users/9il","html_url":"https://github.com/9il","followers_url":"https://api.github.com/users/9il/followers","following_url":"https://api.github.com/users/9il/following{/other_user}","gists_url":"https://api.github.com/users/9il/gists{/gist_id}","starred_url":"https://api.github.com/users/9il/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9il/subscriptions","organizations_url":"https://api.github.com/users/9il/orgs","repos_url":"https://api.github.com/users/9il/repos","events_url":"https://api.github.com/users/9il/events{/privacy}","received_events_url":"https://api.github.com/users/9il/received_events","type":"User","site_admin":false},"repo":{"id":23829430,"name":"phobos","full_name":"9il/phobos","owner":{"login":"9il","id":845083,"avatar_url":"https://avatars.githubusercontent.com/u/845083?v=2","gravatar_id":"680708ea782b686ba97bf0fde1c4dcd8","url":"https://api.github.com/users/9il","html_url":"https://github.com/9il","followers_url":"https://api.github.com/users/9il/followers","following_url":"https://api.github.com/users/9il/following{/other_user}","gists_url":"https://api.github.com/users/9il/gists{/gist_id}","starred_url":"https://api.github.com/users/9il/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9il/subscriptions","organizations_url":"https://api.github.com/users/9il/orgs","repos_url":"https://api.github.com/users/9il/repos","events_url":"https://api.github.com/users/9il/events{/privacy}","received_events_url":"https://api.github.com/users/9il/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/9il/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/9il/phobos","forks_url":"https://api.github.com/repos/9il/phobos/forks","keys_url":"https://api.github.com/repos/9il/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/9il/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/9il/phobos/teams","hooks_url":"https://api.github.com/repos/9il/phobos/hooks","issue_events_url":"https://api.github.com/repos/9il/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/9il/phobos/events","assignees_url":"https://api.github.com/repos/9il/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/9il/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/9il/phobos/tags","blobs_url":"https://api.github.com/repos/9il/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/9il/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/9il/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/9il/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/9il/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/9il/phobos/languages","stargazers_url":"https://api.github.com/repos/9il/phobos/stargazers","contributors_url":"https://api.github.com/repos/9il/phobos/contributors","subscribers_url":"https://api.github.com/repos/9il/phobos/subscribers","subscription_url":"https://api.github.com/repos/9il/phobos/subscription","commits_url":"https://api.github.com/repos/9il/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/9il/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/9il/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/9il/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/9il/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/9il/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/9il/phobos/merges","archive_url":"https://api.github.com/repos/9il/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/9il/phobos/downloads","issues_url":"https://api.github.com/repos/9il/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/9il/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/9il/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/9il/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/9il/phobos/labels{/name}","releases_url":"https://api.github.com/repos/9il/phobos/releases{/id}","created_at":"2014-09-09T10:41:07Z","updated_at":"2014-09-14T10:15:29Z","pushed_at":"2014-09-16T17:10:46Z","git_url":"git://github.com/9il/phobos.git","ssh_url":"git@github.com:9il/phobos.git","clone_url":"https://github.com/9il/phobos.git","svn_url":"https://github.com/9il/phobos","homepage":"dlang.org/phobos","size":28591,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"a62bed4c888843a837372bef1c4d4e012d2d8309","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=2","gravatar_id":"1fe90c0586802aee103ff9ac0b8f3fbe","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=2","gravatar_id":"1fe90c0586802aee103ff9ac0b8f3fbe","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","created_at":"2011-01-15T07:00:06Z","updated_at":"2014-09-13T13:38:45Z","pushed_at":"2014-09-16T14:15:10Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":63081,"stargazers_count":523,"watchers_count":523,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":347,"mirror_url":null,"open_issues_count":35,"forks":347,"open_issues":35,"watchers":523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2508"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2508"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2508"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2508/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2508/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2508/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/298942b7ed6722393e16bb8d52c934c29d268009"}}}}