GitHub PullRequestReviewCommentEvent at 2014-11-12 14:21:19
Repository: spreed-webrtc
Actor: houndci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls/comments/20220791","id":20220791,"diff_hunk":"@@ -51,7 +51,7 @@ define([\"jquery\", \"underscore\", \"modernizr\", \"injectCSS\"], function($, _, Modern\n \n \t\tOnePeople.prototype.name = \"onepeople\";\n \n-\t\tOnePeople.prototype.render = function(container, size, scope, videos, peers) {\n+\t\tOnePeople.prototype.render = function(container, size, scope, videos, streams) {","path":"static/js/services/videolayout.js","position":22,"original_position":22,"commit_id":"fd8634a770602603f70e69b7b870530a9b9e7f9f","original_commit_id":"fd8634a770602603f70e69b7b870530a9b9e7f9f","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long.","created_at":"2014-11-12T14:21:19Z","updated_at":"2014-11-12T14:21:19Z","html_url":"https://github.com/strukturag/spreed-webrtc/pull/138#discussion_r20220791","pull_request_url":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls/138","_links":{"self":{"href":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls/comments/20220791"},"html":{"href":"https://github.com/strukturag/spreed-webrtc/pull/138#discussion_r20220791"},"pull_request":{"href":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls/138"}}},"pull_request":{"url":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls/138","id":23910130,"html_url":"https://github.com/strukturag/spreed-webrtc/pull/138","diff_url":"https://github.com/strukturag/spreed-webrtc/pull/138.diff","patch_url":"https://github.com/strukturag/spreed-webrtc/pull/138.patch","issue_url":"https://api.github.com/repos/strukturag/spreed-webrtc/issues/138","number":138,"state":"open","locked":false,"title":"Peer connection renegotiation","user":{"login":"longsleep","id":1667797,"avatar_url":"https://avatars.githubusercontent.com/u/1667797?v=3","gravatar_id":"","url":"https://api.github.com/users/longsleep","html_url":"https://github.com/longsleep","followers_url":"https://api.github.com/users/longsleep/followers","following_url":"https://api.github.com/users/longsleep/following{/other_user}","gists_url":"https://api.github.com/users/longsleep/gists{/gist_id}","starred_url":"https://api.github.com/users/longsleep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longsleep/subscriptions","organizations_url":"https://api.github.com/users/longsleep/orgs","repos_url":"https://api.github.com/users/longsleep/repos","events_url":"https://api.github.com/users/longsleep/events{/privacy}","received_events_url":"https://api.github.com/users/longsleep/received_events","type":"User","site_admin":false},"body":"This PR adds support to create offer/answers based on the need of renegotiation. This requires browser support of the onnegotiationneeded event. Only Chrome does have this in a somewhat functioning state at the time of writing. Workarounds for Firefox have been added. Though when doing renegotiation this breaks Chrome/Firefox interop. For this reason it is disabled by default. The PR should still be merged as these changes also bring plenty optimizations regarding stream handling and multi stream support.","created_at":"2014-11-05T14:45:46Z","updated_at":"2014-11-12T14:21:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f8335db37893e2bc6cfc76704f23ebeb87655f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls/138/commits","review_comments_url":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls/138/comments","review_comment_url":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/strukturag/spreed-webrtc/issues/138/comments","statuses_url":"https://api.github.com/repos/strukturag/spreed-webrtc/statuses/fd8634a770602603f70e69b7b870530a9b9e7f9f","head":{"label":"longsleep:renegotiation","ref":"renegotiation","sha":"fd8634a770602603f70e69b7b870530a9b9e7f9f","user":{"login":"longsleep","id":1667797,"avatar_url":"https://avatars.githubusercontent.com/u/1667797?v=3","gravatar_id":"","url":"https://api.github.com/users/longsleep","html_url":"https://github.com/longsleep","followers_url":"https://api.github.com/users/longsleep/followers","following_url":"https://api.github.com/users/longsleep/following{/other_user}","gists_url":"https://api.github.com/users/longsleep/gists{/gist_id}","starred_url":"https://api.github.com/users/longsleep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longsleep/subscriptions","organizations_url":"https://api.github.com/users/longsleep/orgs","repos_url":"https://api.github.com/users/longsleep/repos","events_url":"https://api.github.com/users/longsleep/events{/privacy}","received_events_url":"https://api.github.com/users/longsleep/received_events","type":"User","site_admin":false},"repo":{"id":21462473,"name":"spreed-webrtc","full_name":"longsleep/spreed-webrtc","owner":{"login":"longsleep","id":1667797,"avatar_url":"https://avatars.githubusercontent.com/u/1667797?v=3","gravatar_id":"","url":"https://api.github.com/users/longsleep","html_url":"https://github.com/longsleep","followers_url":"https://api.github.com/users/longsleep/followers","following_url":"https://api.github.com/users/longsleep/following{/other_user}","gists_url":"https://api.github.com/users/longsleep/gists{/gist_id}","starred_url":"https://api.github.com/users/longsleep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longsleep/subscriptions","organizations_url":"https://api.github.com/users/longsleep/orgs","repos_url":"https://api.github.com/users/longsleep/repos","events_url":"https://api.github.com/users/longsleep/events{/privacy}","received_events_url":"https://api.github.com/users/longsleep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/longsleep/spreed-webrtc","description":"WebRTC audio/video call and conferencing server.","fork":true,"url":"https://api.github.com/repos/longsleep/spreed-webrtc","forks_url":"https://api.github.com/repos/longsleep/spreed-webrtc/forks","keys_url":"https://api.github.com/repos/longsleep/spreed-webrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/longsleep/spreed-webrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/longsleep/spreed-webrtc/teams","hooks_url":"https://api.github.com/repos/longsleep/spreed-webrtc/hooks","issue_events_url":"https://api.github.com/repos/longsleep/spreed-webrtc/issues/events{/number}","events_url":"https://api.github.com/repos/longsleep/spreed-webrtc/events","assignees_url":"https://api.github.com/repos/longsleep/spreed-webrtc/assignees{/user}","branches_url":"https://api.github.com/repos/longsleep/spreed-webrtc/branches{/branch}","tags_url":"https://api.github.com/repos/longsleep/spreed-webrtc/tags","blobs_url":"https://api.github.com/repos/longsleep/spreed-webrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/longsleep/spreed-webrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/longsleep/spreed-webrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/longsleep/spreed-webrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/longsleep/spreed-webrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/longsleep/spreed-webrtc/languages","stargazers_url":"https://api.github.com/repos/longsleep/spreed-webrtc/stargazers","contributors_url":"https://api.github.com/repos/longsleep/spreed-webrtc/contributors","subscribers_url":"https://api.github.com/repos/longsleep/spreed-webrtc/subscribers","subscription_url":"https://api.github.com/repos/longsleep/spreed-webrtc/subscription","commits_url":"https://api.github.com/repos/longsleep/spreed-webrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/longsleep/spreed-webrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/longsleep/spreed-webrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/longsleep/spreed-webrtc/issues/comments/{number}","contents_url":"https://api.github.com/repos/longsleep/spreed-webrtc/contents/{+path}","compare_url":"https://api.github.com/repos/longsleep/spreed-webrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/longsleep/spreed-webrtc/merges","archive_url":"https://api.github.com/repos/longsleep/spreed-webrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/longsleep/spreed-webrtc/downloads","issues_url":"https://api.github.com/repos/longsleep/spreed-webrtc/issues{/number}","pulls_url":"https://api.github.com/repos/longsleep/spreed-webrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/longsleep/spreed-webrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/longsleep/spreed-webrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/longsleep/spreed-webrtc/labels{/name}","releases_url":"https://api.github.com/repos/longsleep/spreed-webrtc/releases{/id}","created_at":"2014-07-03T12:56:09Z","updated_at":"2014-07-04T22:10:37Z","pushed_at":"2014-11-12T14:21:05Z","git_url":"git://github.com/longsleep/spreed-webrtc.git","ssh_url":"git@github.com:longsleep/spreed-webrtc.git","clone_url":"https://github.com/longsleep/spreed-webrtc.git","svn_url":"https://github.com/longsleep/spreed-webrtc","homepage":"","size":9569,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"strukturag:master","ref":"master","sha":"05dd1d1ecfc477f53cab520548b95cdc426a1c04","user":{"login":"strukturag","id":5314589,"avatar_url":"https://avatars.githubusercontent.com/u/5314589?v=3","gravatar_id":"","url":"https://api.github.com/users/strukturag","html_url":"https://github.com/strukturag","followers_url":"https://api.github.com/users/strukturag/followers","following_url":"https://api.github.com/users/strukturag/following{/other_user}","gists_url":"https://api.github.com/users/strukturag/gists{/gist_id}","starred_url":"https://api.github.com/users/strukturag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strukturag/subscriptions","organizations_url":"https://api.github.com/users/strukturag/orgs","repos_url":"https://api.github.com/users/strukturag/repos","events_url":"https://api.github.com/users/strukturag/events{/privacy}","received_events_url":"https://api.github.com/users/strukturag/received_events","type":"Organization","site_admin":false},"repo":{"id":16809332,"name":"spreed-webrtc","full_name":"strukturag/spreed-webrtc","owner":{"login":"strukturag","id":5314589,"avatar_url":"https://avatars.githubusercontent.com/u/5314589?v=3","gravatar_id":"","url":"https://api.github.com/users/strukturag","html_url":"https://github.com/strukturag","followers_url":"https://api.github.com/users/strukturag/followers","following_url":"https://api.github.com/users/strukturag/following{/other_user}","gists_url":"https://api.github.com/users/strukturag/gists{/gist_id}","starred_url":"https://api.github.com/users/strukturag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strukturag/subscriptions","organizations_url":"https://api.github.com/users/strukturag/orgs","repos_url":"https://api.github.com/users/strukturag/repos","events_url":"https://api.github.com/users/strukturag/events{/privacy}","received_events_url":"https://api.github.com/users/strukturag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strukturag/spreed-webrtc","description":"WebRTC audio/video call and conferencing server.","fork":false,"url":"https://api.github.com/repos/strukturag/spreed-webrtc","forks_url":"https://api.github.com/repos/strukturag/spreed-webrtc/forks","keys_url":"https://api.github.com/repos/strukturag/spreed-webrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strukturag/spreed-webrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strukturag/spreed-webrtc/teams","hooks_url":"https://api.github.com/repos/strukturag/spreed-webrtc/hooks","issue_events_url":"https://api.github.com/repos/strukturag/spreed-webrtc/issues/events{/number}","events_url":"https://api.github.com/repos/strukturag/spreed-webrtc/events","assignees_url":"https://api.github.com/repos/strukturag/spreed-webrtc/assignees{/user}","branches_url":"https://api.github.com/repos/strukturag/spreed-webrtc/branches{/branch}","tags_url":"https://api.github.com/repos/strukturag/spreed-webrtc/tags","blobs_url":"https://api.github.com/repos/strukturag/spreed-webrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strukturag/spreed-webrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strukturag/spreed-webrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/strukturag/spreed-webrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strukturag/spreed-webrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/strukturag/spreed-webrtc/languages","stargazers_url":"https://api.github.com/repos/strukturag/spreed-webrtc/stargazers","contributors_url":"https://api.github.com/repos/strukturag/spreed-webrtc/contributors","subscribers_url":"https://api.github.com/repos/strukturag/spreed-webrtc/subscribers","subscription_url":"https://api.github.com/repos/strukturag/spreed-webrtc/subscription","commits_url":"https://api.github.com/repos/strukturag/spreed-webrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/strukturag/spreed-webrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/strukturag/spreed-webrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/strukturag/spreed-webrtc/issues/comments/{number}","contents_url":"https://api.github.com/repos/strukturag/spreed-webrtc/contents/{+path}","compare_url":"https://api.github.com/repos/strukturag/spreed-webrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strukturag/spreed-webrtc/merges","archive_url":"https://api.github.com/repos/strukturag/spreed-webrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strukturag/spreed-webrtc/downloads","issues_url":"https://api.github.com/repos/strukturag/spreed-webrtc/issues{/number}","pulls_url":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/strukturag/spreed-webrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/strukturag/spreed-webrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strukturag/spreed-webrtc/labels{/name}","releases_url":"https://api.github.com/repos/strukturag/spreed-webrtc/releases{/id}","created_at":"2014-02-13T16:38:34Z","updated_at":"2014-11-07T23:42:29Z","pushed_at":"2014-11-12T12:58:25Z","git_url":"git://github.com/strukturag/spreed-webrtc.git","ssh_url":"git@github.com:strukturag/spreed-webrtc.git","clone_url":"https://github.com/strukturag/spreed-webrtc.git","svn_url":"https://github.com/strukturag/spreed-webrtc","homepage":"","size":15625,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":21,"forks":7,"open_issues":21,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls/138"},"html":{"href":"https://github.com/strukturag/spreed-webrtc/pull/138"},"issue":{"href":"https://api.github.com/repos/strukturag/spreed-webrtc/issues/138"},"comments":{"href":"https://api.github.com/repos/strukturag/spreed-webrtc/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/strukturag/spreed-webrtc/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/strukturag/spreed-webrtc/statuses/fd8634a770602603f70e69b7b870530a9b9e7f9f"}}}}