GitHub PullRequestReviewCommentEvent at 2014-07-26 00:18:46
Repository: chef-dk
Actor: sethvargo
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/opscode/chef-dk/pulls/comments/15430364","id":15430364,"diff_hunk":"@@ -0,0 +1,99 @@\n+#\n+# Copyright:: Copyright (c) 2014 Chef Software Inc.\n+# License:: Apache License, Version 2.0\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+#\n+\n+require 'chef-dk/command/generator_commands/base'","path":"lib/chef-dk/command/generator_commands/app.rb","position":18,"original_position":18,"commit_id":"d3c7525cae165c26186358cdb8e44fa578aa2dec","original_commit_id":"d3c7525cae165c26186358cdb8e44fa578aa2dec","user":{"login":"sethvargo","id":408570,"avatar_url":"https://avatars.githubusercontent.com/u/408570?","gravatar_id":"87f282c6c2cdad13100dffe8c1daf77d","url":"https://api.github.com/users/sethvargo","html_url":"https://github.com/sethvargo","followers_url":"https://api.github.com/users/sethvargo/followers","following_url":"https://api.github.com/users/sethvargo/following{/other_user}","gists_url":"https://api.github.com/users/sethvargo/gists{/gist_id}","starred_url":"https://api.github.com/users/sethvargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethvargo/subscriptions","organizations_url":"https://api.github.com/users/sethvargo/orgs","repos_url":"https://api.github.com/users/sethvargo/repos","events_url":"https://api.github.com/users/sethvargo/events{/privacy}","received_events_url":"https://api.github.com/users/sethvargo/received_events","type":"User","site_admin":false},"body":"No - you only need one autoload statement. [Checkout omnibus.rb](https://github.com/opscode/omnibus/blob/b71fcd1498e7157e18a0b9f8b88490673c067498/lib/omnibus.rb#L33-L81)","created_at":"2014-07-26T00:18:46Z","updated_at":"2014-07-26T00:18:46Z","html_url":"https://github.com/opscode/chef-dk/pull/114#discussion_r15430364","pull_request_url":"https://api.github.com/repos/opscode/chef-dk/pulls/114","_links":{"self":{"href":"https://api.github.com/repos/opscode/chef-dk/pulls/comments/15430364"},"html":{"href":"https://github.com/opscode/chef-dk/pull/114#discussion_r15430364"},"pull_request":{"href":"https://api.github.com/repos/opscode/chef-dk/pulls/114"}}},"pull_request":{"url":"https://api.github.com/repos/opscode/chef-dk/pulls/114","id":18878895,"html_url":"https://github.com/opscode/chef-dk/pull/114","diff_url":"https://github.com/opscode/chef-dk/pull/114.diff","patch_url":"https://github.com/opscode/chef-dk/pull/114.patch","issue_url":"https://api.github.com/repos/opscode/chef-dk/issues/114","number":114,"state":"open","title":"Break generator commands into seperate files","user":{"login":"adamhjk","id":4304,"avatar_url":"https://avatars.githubusercontent.com/u/4304?","gravatar_id":"512bac0de59a64c53fbc7fd08f2e5534","url":"https://api.github.com/users/adamhjk","html_url":"https://github.com/adamhjk","followers_url":"https://api.github.com/users/adamhjk/followers","following_url":"https://api.github.com/users/adamhjk/following{/other_user}","gists_url":"https://api.github.com/users/adamhjk/gists{/gist_id}","starred_url":"https://api.github.com/users/adamhjk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamhjk/subscriptions","organizations_url":"https://api.github.com/users/adamhjk/orgs","repos_url":"https://api.github.com/users/adamhjk/repos","events_url":"https://api.github.com/users/adamhjk/events{/privacy}","received_events_url":"https://api.github.com/users/adamhjk/received_events","type":"User","site_admin":false},"body":"This commit breaks the generator commands from one big file into several smaller ones, and requires them. As we expand the number of generators, we're naturally going to wind up having more than\r\na handful - which makes the giant file, and its equally large rspec test, unwieldly.\r\n\r\nIn addition, it adds Guard support (for faster test results) and fixes a bug where the error handling in CookbookCodeFile descendents triggered hard failure in getopt due to lack of passing the params\r\nin. This caused tests that were run with an rspec option to fail, as the repeat call to parse_options would pick up the default argv, rather than the mocked argv supplied in the specs.\r\n\r\nNo changes to the code happen at all, other than location and the small bug fix.","created_at":"2014-07-25T05:33:57Z","updated_at":"2014-07-26T00:18:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dc390c23d3566e1a217601efc4c63032689a7df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opscode/chef-dk/pulls/114/commits","review_comments_url":"https://api.github.com/repos/opscode/chef-dk/pulls/114/comments","review_comment_url":"https://api.github.com/repos/opscode/chef-dk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opscode/chef-dk/issues/114/comments","statuses_url":"https://api.github.com/repos/opscode/chef-dk/statuses/d3c7525cae165c26186358cdb8e44fa578aa2dec","head":{"label":"adamhjk:split_generators","ref":"split_generators","sha":"d3c7525cae165c26186358cdb8e44fa578aa2dec","user":{"login":"adamhjk","id":4304,"avatar_url":"https://avatars.githubusercontent.com/u/4304?","gravatar_id":"512bac0de59a64c53fbc7fd08f2e5534","url":"https://api.github.com/users/adamhjk","html_url":"https://github.com/adamhjk","followers_url":"https://api.github.com/users/adamhjk/followers","following_url":"https://api.github.com/users/adamhjk/following{/other_user}","gists_url":"https://api.github.com/users/adamhjk/gists{/gist_id}","starred_url":"https://api.github.com/users/adamhjk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamhjk/subscriptions","organizations_url":"https://api.github.com/users/adamhjk/orgs","repos_url":"https://api.github.com/users/adamhjk/repos","events_url":"https://api.github.com/users/adamhjk/events{/privacy}","received_events_url":"https://api.github.com/users/adamhjk/received_events","type":"User","site_admin":false},"repo":{"id":22129224,"name":"chef-dk","full_name":"adamhjk/chef-dk","owner":{"login":"adamhjk","id":4304,"avatar_url":"https://avatars.githubusercontent.com/u/4304?","gravatar_id":"512bac0de59a64c53fbc7fd08f2e5534","url":"https://api.github.com/users/adamhjk","html_url":"https://github.com/adamhjk","followers_url":"https://api.github.com/users/adamhjk/followers","following_url":"https://api.github.com/users/adamhjk/following{/other_user}","gists_url":"https://api.github.com/users/adamhjk/gists{/gist_id}","starred_url":"https://api.github.com/users/adamhjk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamhjk/subscriptions","organizations_url":"https://api.github.com/users/adamhjk/orgs","repos_url":"https://api.github.com/users/adamhjk/repos","events_url":"https://api.github.com/users/adamhjk/events{/privacy}","received_events_url":"https://api.github.com/users/adamhjk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamhjk/chef-dk","description":"A streamlined development and deployment workflow for Chef platform.","fork":true,"url":"https://api.github.com/repos/adamhjk/chef-dk","forks_url":"https://api.github.com/repos/adamhjk/chef-dk/forks","keys_url":"https://api.github.com/repos/adamhjk/chef-dk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamhjk/chef-dk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamhjk/chef-dk/teams","hooks_url":"https://api.github.com/repos/adamhjk/chef-dk/hooks","issue_events_url":"https://api.github.com/repos/adamhjk/chef-dk/issues/events{/number}","events_url":"https://api.github.com/repos/adamhjk/chef-dk/events","assignees_url":"https://api.github.com/repos/adamhjk/chef-dk/assignees{/user}","branches_url":"https://api.github.com/repos/adamhjk/chef-dk/branches{/branch}","tags_url":"https://api.github.com/repos/adamhjk/chef-dk/tags","blobs_url":"https://api.github.com/repos/adamhjk/chef-dk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamhjk/chef-dk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamhjk/chef-dk/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamhjk/chef-dk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamhjk/chef-dk/statuses/{sha}","languages_url":"https://api.github.com/repos/adamhjk/chef-dk/languages","stargazers_url":"https://api.github.com/repos/adamhjk/chef-dk/stargazers","contributors_url":"https://api.github.com/repos/adamhjk/chef-dk/contributors","subscribers_url":"https://api.github.com/repos/adamhjk/chef-dk/subscribers","subscription_url":"https://api.github.com/repos/adamhjk/chef-dk/subscription","commits_url":"https://api.github.com/repos/adamhjk/chef-dk/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamhjk/chef-dk/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamhjk/chef-dk/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamhjk/chef-dk/issues/comments/{number}","contents_url":"https://api.github.com/repos/adamhjk/chef-dk/contents/{+path}","compare_url":"https://api.github.com/repos/adamhjk/chef-dk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamhjk/chef-dk/merges","archive_url":"https://api.github.com/repos/adamhjk/chef-dk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamhjk/chef-dk/downloads","issues_url":"https://api.github.com/repos/adamhjk/chef-dk/issues{/number}","pulls_url":"https://api.github.com/repos/adamhjk/chef-dk/pulls{/number}","milestones_url":"https://api.github.com/repos/adamhjk/chef-dk/milestones{/number}","notifications_url":"https://api.github.com/repos/adamhjk/chef-dk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamhjk/chef-dk/labels{/name}","releases_url":"https://api.github.com/repos/adamhjk/chef-dk/releases{/id}","created_at":"2014-07-23T02:44:00Z","updated_at":"2014-07-21T15:19:17Z","pushed_at":"2014-07-25T05:32:54Z","git_url":"git://github.com/adamhjk/chef-dk.git","ssh_url":"git@github.com:adamhjk/chef-dk.git","clone_url":"https://github.com/adamhjk/chef-dk.git","svn_url":"https://github.com/adamhjk/chef-dk","homepage":null,"size":3063,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opscode:master","ref":"master","sha":"a815c307bf8a6deb0685216cbad987b828c7a945","user":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"repo":{"id":17303641,"name":"chef-dk","full_name":"opscode/chef-dk","owner":{"login":"opscode","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?","gravatar_id":"890bf76f4dc18c12a19c55e988a1bd5e","url":"https://api.github.com/users/opscode","html_url":"https://github.com/opscode","followers_url":"https://api.github.com/users/opscode/followers","following_url":"https://api.github.com/users/opscode/following{/other_user}","gists_url":"https://api.github.com/users/opscode/gists{/gist_id}","starred_url":"https://api.github.com/users/opscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opscode/subscriptions","organizations_url":"https://api.github.com/users/opscode/orgs","repos_url":"https://api.github.com/users/opscode/repos","events_url":"https://api.github.com/users/opscode/events{/privacy}","received_events_url":"https://api.github.com/users/opscode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opscode/chef-dk","description":"A streamlined development and deployment workflow for Chef platform.","fork":false,"url":"https://api.github.com/repos/opscode/chef-dk","forks_url":"https://api.github.com/repos/opscode/chef-dk/forks","keys_url":"https://api.github.com/repos/opscode/chef-dk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opscode/chef-dk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opscode/chef-dk/teams","hooks_url":"https://api.github.com/repos/opscode/chef-dk/hooks","issue_events_url":"https://api.github.com/repos/opscode/chef-dk/issues/events{/number}","events_url":"https://api.github.com/repos/opscode/chef-dk/events","assignees_url":"https://api.github.com/repos/opscode/chef-dk/assignees{/user}","branches_url":"https://api.github.com/repos/opscode/chef-dk/branches{/branch}","tags_url":"https://api.github.com/repos/opscode/chef-dk/tags","blobs_url":"https://api.github.com/repos/opscode/chef-dk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opscode/chef-dk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opscode/chef-dk/git/refs{/sha}","trees_url":"https://api.github.com/repos/opscode/chef-dk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opscode/chef-dk/statuses/{sha}","languages_url":"https://api.github.com/repos/opscode/chef-dk/languages","stargazers_url":"https://api.github.com/repos/opscode/chef-dk/stargazers","contributors_url":"https://api.github.com/repos/opscode/chef-dk/contributors","subscribers_url":"https://api.github.com/repos/opscode/chef-dk/subscribers","subscription_url":"https://api.github.com/repos/opscode/chef-dk/subscription","commits_url":"https://api.github.com/repos/opscode/chef-dk/commits{/sha}","git_commits_url":"https://api.github.com/repos/opscode/chef-dk/git/commits{/sha}","comments_url":"https://api.github.com/repos/opscode/chef-dk/comments{/number}","issue_comment_url":"https://api.github.com/repos/opscode/chef-dk/issues/comments/{number}","contents_url":"https://api.github.com/repos/opscode/chef-dk/contents/{+path}","compare_url":"https://api.github.com/repos/opscode/chef-dk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opscode/chef-dk/merges","archive_url":"https://api.github.com/repos/opscode/chef-dk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opscode/chef-dk/downloads","issues_url":"https://api.github.com/repos/opscode/chef-dk/issues{/number}","pulls_url":"https://api.github.com/repos/opscode/chef-dk/pulls{/number}","milestones_url":"https://api.github.com/repos/opscode/chef-dk/milestones{/number}","notifications_url":"https://api.github.com/repos/opscode/chef-dk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opscode/chef-dk/labels{/name}","releases_url":"https://api.github.com/repos/opscode/chef-dk/releases{/id}","created_at":"2014-02-28T23:59:39Z","updated_at":"2014-07-24T12:02:40Z","pushed_at":"2014-07-24T08:34:37Z","git_url":"git://github.com/opscode/chef-dk.git","ssh_url":"git@github.com:opscode/chef-dk.git","clone_url":"https://github.com/opscode/chef-dk.git","svn_url":"https://github.com/opscode/chef-dk","homepage":null,"size":3063,"stargazers_count":96,"watchers_count":96,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":23,"mirror_url":null,"open_issues_count":21,"forks":23,"open_issues":21,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opscode/chef-dk/pulls/114"},"html":{"href":"https://github.com/opscode/chef-dk/pull/114"},"issue":{"href":"https://api.github.com/repos/opscode/chef-dk/issues/114"},"comments":{"href":"https://api.github.com/repos/opscode/chef-dk/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/opscode/chef-dk/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/opscode/chef-dk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opscode/chef-dk/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/opscode/chef-dk/statuses/d3c7525cae165c26186358cdb8e44fa578aa2dec"}}}}