GitHub PullRequestReviewCommentEvent at 2014-12-06 07:19:26
Repository: vgstation13
Actor: wild-billy
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/21415183","id":21415183,"diff_hunk":"@@ -1079,22 +1082,22 @@\n \t\t\tspawn(5) src.reagents.clear_reagents()  //maybe this could be improved?\r\n \t\tinvisibility = INVISIBILITY_MAXIMUM  //so it stays a while to ignite any fuel\r\n \r\n-\t\tif(molotov == 1) //for molotovs\r\n+\t\tif(molrag) //for molotovs\r\n \t\t\tif(lit)\r\n \t\t\t\tnew /obj/effect/decal/cleanable/ash(get_turf(src))\r\n-\t\t\t\tvar/turf/loca = get_turf(src)\r\n-\t\t\t\tif(loca)\r\n+\t\t\t\tvar/turf/T = get_turf(src)\r\n+\t\t\t\tif(T)\r\n \t\t\t\t\t//world << \"<span  class='warning'>Burning...</span>\"\r\n-\t\t\t\t\tloca.hotspot_expose(700, 1000,surfaces=istype(loc,/turf))\r\n+\t\t\t\t\tT.hotspot_expose(700, 1000,surfaces=istype(loc,/turf))\r\n \t\t\telse\r\n-\t\t\t\tnew /obj/item/weapon/reagent_containers/glass/rag(get_turf(src))\r\n-\r\n+\t\t\t\tmolrag.loc = get_turf(src)\r\n+\t\t\t\tmolrag = null\r\n \r\n \t\t//create new broken bottle\r\n \t\tvar/obj/item/weapon/broken_bottle/B = new /obj/item/weapon/broken_bottle(loc)\r\n-\t\tB.force = src.force\r\n-\t\tB.name = src.smashname\r\n-\t\tB.icon_state = src.icon_state\r\n+\t\tB.force = force\r\n+\t\tB.name = smashname\r\n+\t\tB.icon_state = icon_state\r","path":"code/modules/reagents/reagent_containers/food/drinks.dm","position":52,"original_position":52,"commit_id":"51cbb000ea420e7d393b134a0f260470241cd811","original_commit_id":"51cbb000ea420e7d393b134a0f260470241cd811","user":{"login":"wild-billy","id":6355724,"avatar_url":"https://avatars.githubusercontent.com/u/6355724?v=3","gravatar_id":"","url":"https://api.github.com/users/wild-billy","html_url":"https://github.com/wild-billy","followers_url":"https://api.github.com/users/wild-billy/followers","following_url":"https://api.github.com/users/wild-billy/following{/other_user}","gists_url":"https://api.github.com/users/wild-billy/gists{/gist_id}","starred_url":"https://api.github.com/users/wild-billy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wild-billy/subscriptions","organizations_url":"https://api.github.com/users/wild-billy/orgs","repos_url":"https://api.github.com/users/wild-billy/repos","events_url":"https://api.github.com/users/wild-billy/events{/privacy}","received_events_url":"https://api.github.com/users/wild-billy/received_events","type":"User","site_admin":false},"body":"Don't remove ```src```. It defines scope explicitly, and imho should be mandatory.","created_at":"2014-12-06T07:19:26Z","updated_at":"2014-12-06T07:19:26Z","html_url":"https://github.com/d3athrow/vgstation13/pull/2081#discussion_r21415183","pull_request_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2081","_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/21415183"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/2081#discussion_r21415183"},"pull_request":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2081"}}},"pull_request":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2081","id":25610920,"html_url":"https://github.com/d3athrow/vgstation13/pull/2081","diff_url":"https://github.com/d3athrow/vgstation13/pull/2081.diff","patch_url":"https://github.com/d3athrow/vgstation13/pull/2081.patch","issue_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/2081","number":2081,"state":"open","locked":false,"title":"Molotov, mops, and rags, oh my","user":{"login":"VelardAmakar","id":3201659,"avatar_url":"https://avatars.githubusercontent.com/u/3201659?v=3","gravatar_id":"","url":"https://api.github.com/users/VelardAmakar","html_url":"https://github.com/VelardAmakar","followers_url":"https://api.github.com/users/VelardAmakar/followers","following_url":"https://api.github.com/users/VelardAmakar/following{/other_user}","gists_url":"https://api.github.com/users/VelardAmakar/gists{/gist_id}","starred_url":"https://api.github.com/users/VelardAmakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VelardAmakar/subscriptions","organizations_url":"https://api.github.com/users/VelardAmakar/orgs","repos_url":"https://api.github.com/users/VelardAmakar/repos","events_url":"https://api.github.com/users/VelardAmakar/events{/privacy}","received_events_url":"https://api.github.com/users/VelardAmakar/received_events","type":"User","site_admin":false},"body":"Standardizes mops and rags, and adds a makeshift mop that is as effective as a rag\r\nReplaces footprints_and_rag.dm with footprints.dm, separating footprint code from rag code, putting rag code into mop.dm\r\nReplaces all instances of obj/item/weapon/reagent_containers/glass/rag with /obj/item/weapon/mop/rag, including the one reference on boxstation\r\nMakes molotovs properly use rags and makes the code that makes them work slightly less shitty\r\nMakes janitors now work pro bono, as they should.(adds a box of donkpockets to the janitor's closet)\r\n\r\n![](http://puu.sh/dhpVX.png)","created_at":"2014-12-06T00:42:48Z","updated_at":"2014-12-06T07:19:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"333d13d7d0488404920a000f634d6a8df99e3229","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2081/commits","review_comments_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2081/comments","review_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/{number}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/2081/comments","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/51cbb000ea420e7d393b134a0f260470241cd811","head":{"label":"VelardAmakar:molotovfix","ref":"molotovfix","sha":"51cbb000ea420e7d393b134a0f260470241cd811","user":{"login":"VelardAmakar","id":3201659,"avatar_url":"https://avatars.githubusercontent.com/u/3201659?v=3","gravatar_id":"","url":"https://api.github.com/users/VelardAmakar","html_url":"https://github.com/VelardAmakar","followers_url":"https://api.github.com/users/VelardAmakar/followers","following_url":"https://api.github.com/users/VelardAmakar/following{/other_user}","gists_url":"https://api.github.com/users/VelardAmakar/gists{/gist_id}","starred_url":"https://api.github.com/users/VelardAmakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VelardAmakar/subscriptions","organizations_url":"https://api.github.com/users/VelardAmakar/orgs","repos_url":"https://api.github.com/users/VelardAmakar/repos","events_url":"https://api.github.com/users/VelardAmakar/events{/privacy}","received_events_url":"https://api.github.com/users/VelardAmakar/received_events","type":"User","site_admin":false},"repo":{"id":17959814,"name":"vgstation13","full_name":"VelardAmakar/vgstation13","owner":{"login":"VelardAmakar","id":3201659,"avatar_url":"https://avatars.githubusercontent.com/u/3201659?v=3","gravatar_id":"","url":"https://api.github.com/users/VelardAmakar","html_url":"https://github.com/VelardAmakar","followers_url":"https://api.github.com/users/VelardAmakar/followers","following_url":"https://api.github.com/users/VelardAmakar/following{/other_user}","gists_url":"https://api.github.com/users/VelardAmakar/gists{/gist_id}","starred_url":"https://api.github.com/users/VelardAmakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VelardAmakar/subscriptions","organizations_url":"https://api.github.com/users/VelardAmakar/orgs","repos_url":"https://api.github.com/users/VelardAmakar/repos","events_url":"https://api.github.com/users/VelardAmakar/events{/privacy}","received_events_url":"https://api.github.com/users/VelardAmakar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VelardAmakar/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/VelardAmakar/vgstation13","forks_url":"https://api.github.com/repos/VelardAmakar/vgstation13/forks","keys_url":"https://api.github.com/repos/VelardAmakar/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VelardAmakar/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VelardAmakar/vgstation13/teams","hooks_url":"https://api.github.com/repos/VelardAmakar/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/VelardAmakar/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/VelardAmakar/vgstation13/events","assignees_url":"https://api.github.com/repos/VelardAmakar/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/VelardAmakar/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/VelardAmakar/vgstation13/tags","blobs_url":"https://api.github.com/repos/VelardAmakar/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VelardAmakar/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VelardAmakar/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/VelardAmakar/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VelardAmakar/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/VelardAmakar/vgstation13/languages","stargazers_url":"https://api.github.com/repos/VelardAmakar/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/VelardAmakar/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/VelardAmakar/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/VelardAmakar/vgstation13/subscription","commits_url":"https://api.github.com/repos/VelardAmakar/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/VelardAmakar/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/VelardAmakar/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/VelardAmakar/vgstation13/issues/comments/{number}","contents_url":"https://api.github.com/repos/VelardAmakar/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/VelardAmakar/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VelardAmakar/vgstation13/merges","archive_url":"https://api.github.com/repos/VelardAmakar/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VelardAmakar/vgstation13/downloads","issues_url":"https://api.github.com/repos/VelardAmakar/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/VelardAmakar/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/VelardAmakar/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/VelardAmakar/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VelardAmakar/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/VelardAmakar/vgstation13/releases{/id}","created_at":"2014-03-20T21:53:51Z","updated_at":"2014-06-03T14:09:13Z","pushed_at":"2014-12-06T00:36:50Z","git_url":"git://github.com/VelardAmakar/vgstation13.git","ssh_url":"git@github.com:VelardAmakar/vgstation13.git","clone_url":"https://github.com/VelardAmakar/vgstation13.git","svn_url":"https://github.com/VelardAmakar/vgstation13","homepage":"","size":693239,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"d3athrow:Bleeding-Edge","ref":"Bleeding-Edge","sha":"44a83ab0989ec2e403bb53e9d4ad31cc86b2d7d0","user":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"repo":{"id":10441188,"name":"vgstation13","full_name":"d3athrow/vgstation13","owner":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d3athrow/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/d3athrow/vgstation13","forks_url":"https://api.github.com/repos/d3athrow/vgstation13/forks","keys_url":"https://api.github.com/repos/d3athrow/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3athrow/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3athrow/vgstation13/teams","hooks_url":"https://api.github.com/repos/d3athrow/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/d3athrow/vgstation13/events","assignees_url":"https://api.github.com/repos/d3athrow/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/d3athrow/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/d3athrow/vgstation13/tags","blobs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3athrow/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3athrow/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/d3athrow/vgstation13/languages","stargazers_url":"https://api.github.com/repos/d3athrow/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/d3athrow/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/d3athrow/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/d3athrow/vgstation13/subscription","commits_url":"https://api.github.com/repos/d3athrow/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3athrow/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/comments/{number}","contents_url":"https://api.github.com/repos/d3athrow/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/d3athrow/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3athrow/vgstation13/merges","archive_url":"https://api.github.com/repos/d3athrow/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3athrow/vgstation13/downloads","issues_url":"https://api.github.com/repos/d3athrow/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/d3athrow/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/d3athrow/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/d3athrow/vgstation13/releases{/id}","created_at":"2013-06-02T19:39:54Z","updated_at":"2014-11-19T18:13:17Z","pushed_at":"2014-12-06T02:52:39Z","git_url":"git://github.com/d3athrow/vgstation13.git","ssh_url":"git@github.com:d3athrow/vgstation13.git","clone_url":"https://github.com/d3athrow/vgstation13.git","svn_url":"https://github.com/d3athrow/vgstation13","homepage":"","size":905824,"stargazers_count":37,"watchers_count":37,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":159,"forks":127,"open_issues":159,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2081"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/2081"},"issue":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/2081"},"comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/2081/comments"},"review_comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2081/comments"},"review_comment":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/2081/commits"},"statuses":{"href":"https://api.github.com/repos/d3athrow/vgstation13/statuses/51cbb000ea420e7d393b134a0f260470241cd811"}}}}