GitHub PullRequestReviewCommentEvent at 2014-09-17 20:35:09
Repository: jpm
Actor: erikvold
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/jpm/pulls/comments/17692053","id":17692053,"diff_hunk":"@@ -129,6 +129,52 @@ describe(\"lib/xpi\", function () {\n       });\n     }).then(null, done);\n   });\n+\n+  it(\"Only uses existing install.rdf\", function (done) {\n+    process.chdir(aomUnsupportedPath);\n+    var manifest = require(path.join(aomUnsupportedPath, \"package.json\"));\n+    var filePath = path.join(aomUnsupportedPath, \"install.rdf\");\n+    fs.writeFile(filePath, \"TEST\").then(function () {\n+      return xpi(manifest);\n+    }).then(function (xpiPath) {\n+      utils.unzipTo(xpiPath, tmpOutputDir, function () {\n+        expect(utils.isFile(path.join(tmpOutputDir, \"bootstrap.js\"))).to.be.equal(true);\n+        expect(utils.isFile(path.join(aomUnsupportedPath, \"bootstrap.js\"))).to.be.equal(false);\n+        when.all([ aomUnsupportedPath, tmpOutputDir ]\n+          .map(function (p) { return path.join(p, \"install.rdf\"); })\n+          .map(function (p) { return fs.readFile(p, \"utf-8\"); }))\n+          .then(function(results) {\n+            results.forEach(function(content) {\n+              expect(content).to.be.equal(\"TEST\");\n+            });\n+            done();\n+          });\n+      });\n+    }).then(null, done);","path":"test/unit/test.xpi.js","position":25,"original_position":25,"commit_id":"117e99eacc48a6b7f0d19adc534205d52745b9cb","original_commit_id":"117e99eacc48a6b7f0d19adc534205d52745b9cb","user":{"login":"erikvold","id":27379,"avatar_url":"https://avatars.githubusercontent.com/u/27379?v=2","gravatar_id":null,"url":"https://api.github.com/users/erikvold","html_url":"https://github.com/erikvold","followers_url":"https://api.github.com/users/erikvold/followers","following_url":"https://api.github.com/users/erikvold/following{/other_user}","gists_url":"https://api.github.com/users/erikvold/gists{/gist_id}","starred_url":"https://api.github.com/users/erikvold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikvold/subscriptions","organizations_url":"https://api.github.com/users/erikvold/orgs","repos_url":"https://api.github.com/users/erikvold/repos","events_url":"https://api.github.com/users/erikvold/events{/privacy}","received_events_url":"https://api.github.com/users/erikvold/received_events","type":"User","site_admin":false},"body":"ah nvm this is the rejection handler I see now.","created_at":"2014-09-17T20:35:09Z","updated_at":"2014-09-17T20:35:09Z","html_url":"https://github.com/mozilla/jpm/pull/142#discussion_r17692053","pull_request_url":"https://api.github.com/repos/mozilla/jpm/pulls/142","_links":{"self":{"href":"https://api.github.com/repos/mozilla/jpm/pulls/comments/17692053"},"html":{"href":"https://github.com/mozilla/jpm/pull/142#discussion_r17692053"},"pull_request":{"href":"https://api.github.com/repos/mozilla/jpm/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/jpm/pulls/142","id":19697527,"html_url":"https://github.com/mozilla/jpm/pull/142","diff_url":"https://github.com/mozilla/jpm/pull/142.diff","patch_url":"https://github.com/mozilla/jpm/pull/142.patch","issue_url":"https://api.github.com/repos/mozilla/jpm/issues/142","number":142,"state":"open","locked":false,"title":"Don't overwrite existing bootstrap.js and install.rdf, instead use them in the xpi","user":{"login":"kewisch","id":607198,"avatar_url":"https://avatars.githubusercontent.com/u/607198?v=2","gravatar_id":"8eaaff834d8a1d1464cda23376f50d2e","url":"https://api.github.com/users/kewisch","html_url":"https://github.com/kewisch","followers_url":"https://api.github.com/users/kewisch/followers","following_url":"https://api.github.com/users/kewisch/following{/other_user}","gists_url":"https://api.github.com/users/kewisch/gists{/gist_id}","starred_url":"https://api.github.com/users/kewisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kewisch/subscriptions","organizations_url":"https://api.github.com/users/kewisch/orgs","repos_url":"https://api.github.com/users/kewisch/repos","events_url":"https://api.github.com/users/kewisch/events{/privacy}","received_events_url":"https://api.github.com/users/kewisch/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-12T23:45:43Z","updated_at":"2014-09-17T20:35:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21e300a943467c36b2bee3e681172da1dae9c3ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/jpm/pulls/142/commits","review_comments_url":"https://api.github.com/repos/mozilla/jpm/pulls/142/comments","review_comment_url":"https://api.github.com/repos/mozilla/jpm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/jpm/issues/142/comments","statuses_url":"https://api.github.com/repos/mozilla/jpm/statuses/117e99eacc48a6b7f0d19adc534205d52745b9cb","head":{"label":"kewisch:use-existing-bootstrap","ref":"use-existing-bootstrap","sha":"117e99eacc48a6b7f0d19adc534205d52745b9cb","user":{"login":"kewisch","id":607198,"avatar_url":"https://avatars.githubusercontent.com/u/607198?v=2","gravatar_id":"8eaaff834d8a1d1464cda23376f50d2e","url":"https://api.github.com/users/kewisch","html_url":"https://github.com/kewisch","followers_url":"https://api.github.com/users/kewisch/followers","following_url":"https://api.github.com/users/kewisch/following{/other_user}","gists_url":"https://api.github.com/users/kewisch/gists{/gist_id}","starred_url":"https://api.github.com/users/kewisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kewisch/subscriptions","organizations_url":"https://api.github.com/users/kewisch/orgs","repos_url":"https://api.github.com/users/kewisch/repos","events_url":"https://api.github.com/users/kewisch/events{/privacy}","received_events_url":"https://api.github.com/users/kewisch/received_events","type":"User","site_admin":false},"repo":{"id":22896113,"name":"jpm","full_name":"kewisch/jpm","owner":{"login":"kewisch","id":607198,"avatar_url":"https://avatars.githubusercontent.com/u/607198?v=2","gravatar_id":"8eaaff834d8a1d1464cda23376f50d2e","url":"https://api.github.com/users/kewisch","html_url":"https://github.com/kewisch","followers_url":"https://api.github.com/users/kewisch/followers","following_url":"https://api.github.com/users/kewisch/following{/other_user}","gists_url":"https://api.github.com/users/kewisch/gists{/gist_id}","starred_url":"https://api.github.com/users/kewisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kewisch/subscriptions","organizations_url":"https://api.github.com/users/kewisch/orgs","repos_url":"https://api.github.com/users/kewisch/repos","events_url":"https://api.github.com/users/kewisch/events{/privacy}","received_events_url":"https://api.github.com/users/kewisch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kewisch/jpm","description":"Jetpack Manager for Node.js","fork":true,"url":"https://api.github.com/repos/kewisch/jpm","forks_url":"https://api.github.com/repos/kewisch/jpm/forks","keys_url":"https://api.github.com/repos/kewisch/jpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kewisch/jpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kewisch/jpm/teams","hooks_url":"https://api.github.com/repos/kewisch/jpm/hooks","issue_events_url":"https://api.github.com/repos/kewisch/jpm/issues/events{/number}","events_url":"https://api.github.com/repos/kewisch/jpm/events","assignees_url":"https://api.github.com/repos/kewisch/jpm/assignees{/user}","branches_url":"https://api.github.com/repos/kewisch/jpm/branches{/branch}","tags_url":"https://api.github.com/repos/kewisch/jpm/tags","blobs_url":"https://api.github.com/repos/kewisch/jpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kewisch/jpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kewisch/jpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kewisch/jpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kewisch/jpm/statuses/{sha}","languages_url":"https://api.github.com/repos/kewisch/jpm/languages","stargazers_url":"https://api.github.com/repos/kewisch/jpm/stargazers","contributors_url":"https://api.github.com/repos/kewisch/jpm/contributors","subscribers_url":"https://api.github.com/repos/kewisch/jpm/subscribers","subscription_url":"https://api.github.com/repos/kewisch/jpm/subscription","commits_url":"https://api.github.com/repos/kewisch/jpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kewisch/jpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kewisch/jpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kewisch/jpm/issues/comments/{number}","contents_url":"https://api.github.com/repos/kewisch/jpm/contents/{+path}","compare_url":"https://api.github.com/repos/kewisch/jpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kewisch/jpm/merges","archive_url":"https://api.github.com/repos/kewisch/jpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kewisch/jpm/downloads","issues_url":"https://api.github.com/repos/kewisch/jpm/issues{/number}","pulls_url":"https://api.github.com/repos/kewisch/jpm/pulls{/number}","milestones_url":"https://api.github.com/repos/kewisch/jpm/milestones{/number}","notifications_url":"https://api.github.com/repos/kewisch/jpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kewisch/jpm/labels{/name}","releases_url":"https://api.github.com/repos/kewisch/jpm/releases{/id}","created_at":"2014-08-12T23:42:23Z","updated_at":"2014-08-08T21:56:36Z","pushed_at":"2014-08-29T11:26:32Z","git_url":"git://github.com/kewisch/jpm.git","ssh_url":"git@github.com:kewisch/jpm.git","clone_url":"https://github.com/kewisch/jpm.git","svn_url":"https://github.com/kewisch/jpm","homepage":null,"size":374,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"ed278ae01f10b7ded6ae775a34497396531eeef0","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":14935921,"name":"jpm","full_name":"mozilla/jpm","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=2","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/jpm","description":"Jetpack Manager for Node.js","fork":false,"url":"https://api.github.com/repos/mozilla/jpm","forks_url":"https://api.github.com/repos/mozilla/jpm/forks","keys_url":"https://api.github.com/repos/mozilla/jpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/jpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/jpm/teams","hooks_url":"https://api.github.com/repos/mozilla/jpm/hooks","issue_events_url":"https://api.github.com/repos/mozilla/jpm/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/jpm/events","assignees_url":"https://api.github.com/repos/mozilla/jpm/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/jpm/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/jpm/tags","blobs_url":"https://api.github.com/repos/mozilla/jpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/jpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/jpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/jpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/jpm/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/jpm/languages","stargazers_url":"https://api.github.com/repos/mozilla/jpm/stargazers","contributors_url":"https://api.github.com/repos/mozilla/jpm/contributors","subscribers_url":"https://api.github.com/repos/mozilla/jpm/subscribers","subscription_url":"https://api.github.com/repos/mozilla/jpm/subscription","commits_url":"https://api.github.com/repos/mozilla/jpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/jpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/jpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/jpm/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/jpm/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/jpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/jpm/merges","archive_url":"https://api.github.com/repos/mozilla/jpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/jpm/downloads","issues_url":"https://api.github.com/repos/mozilla/jpm/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/jpm/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/jpm/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/jpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/jpm/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/jpm/releases{/id}","created_at":"2013-12-04T21:09:56Z","updated_at":"2014-09-10T18:24:28Z","pushed_at":"2014-09-17T19:54:59Z","git_url":"git://github.com/mozilla/jpm.git","ssh_url":"git@github.com:mozilla/jpm.git","clone_url":"https://github.com/mozilla/jpm.git","svn_url":"https://github.com/mozilla/jpm","homepage":null,"size":2148,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":37,"forks":8,"open_issues":37,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/jpm/pulls/142"},"html":{"href":"https://github.com/mozilla/jpm/pull/142"},"issue":{"href":"https://api.github.com/repos/mozilla/jpm/issues/142"},"comments":{"href":"https://api.github.com/repos/mozilla/jpm/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/jpm/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/jpm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/jpm/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/jpm/statuses/117e99eacc48a6b7f0d19adc534205d52745b9cb"}}}}