GitHub PullRequestReviewCommentEvent at 2014-08-27 20:27:04
Repository: Mudlet
Actor: ahmedcharles
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/16802105","id":16802105,"diff_hunk":"@@ -19,71 +19,155 @@\n # For more information on clang-format:\n # http://clang.llvm.org/docs/ClangFormat.html\n \n+# All the current options are explicitly specified below other than\n+# undocumented/experimental options, so this is only useful for new options\n+# where we get a reasonable default before we explicitly decide here.\n BasedOnStyle: LLVM\n \n # language\n+\n+# The language we are formatting.\n Language: Cpp\n+# The standard version, we aren't using C++11 yet.\n Standard: Cpp03\n+# We want to turn on formatting.\n DisableFormat: false\n \n # line length\n+\n+# Ignore this, we'll need to fine tune it once the other options are settled.\n ColumnLimit: 200\n \n # indentation\n+\n+# This is consistent currently except for ctelnet, which I'm updating.\n IndentWidth: 4\n+# Use spaces instead of tabs.\n UseTab: Never\n+# If tabs exist, which they won't, they'll be counted as being 8 spaces wide.\n TabWidth: 8\n+# public/private/protected are generally 'outdented' in the code base currently.\n AccessModifierOffset: -4\n+# This isn't currently consistently applied or really done, but I'd prefer to\n+# do it, since I think it ends up nicer.\n ConstructorInitializerIndentWidth: 4\n+# This is if a line is broken into two lines, how much to indent the second\n+# line. This is usually the same as the indent width.\n ContinuationIndentWidth: 4\n+# Not doing this tends to reduce large amounts of unnecessary indentation.\n IndentCaseLabels: false\n+# The code base doesn't have many, if any instances where this matters, but I\n+# prefer not indenting.\n IndentWrappedFunctionNames: false\n+# The code base doesn't have any namespaces currently, but I'd like to add some\n+# and would rather not have them indented.\n NamespaceIndentation: None\n \n # line breaks\n+\n+# The code base never does this.\n AlwaysBreakAfterDefinitionReturnType: false\n+# It would make sense for this to be true, but the default for LLVM is false,\n+# hence it being false here.\n AlwaysBreakBeforeMultilineStrings: false\n+# We consistently do this, so it seems reasonable to have it here.\n AlwaysBreakTemplateDeclarations: true\n+# This means that when line breaks do happen, they place the binary operator\n+# at the beginning of the second line rather than the end of the first.\n+# I'm told that this is beneficial because humans mostly read from left to right\n+# and that makes important information being on the left easier to read.\n BreakBeforeBinaryOperators: true\n+# ** Where do braces go?\n+# I'm personally going to vote for Attach, with Linux coming in second.\n BreakBeforeBraces: Linux\n+# I haven't seen a case where this matters for us, but I like this behavior.\n BreakBeforeTernaryOperators: true\n+# This is the way the code base currently does this.\n BreakConstructorInitializersBeforeComma: true\n+# This is mostly the way the code base currently does this.\n ConstructorInitializerAllOnOneLineOrOnePerLine: true\n+# I'd prefer this be false, personally, but it's not a big deal and forcing\n+# it for every block seems excessive.\n KeepEmptyLinesAtTheStartOfBlocks: true\n+# This will delete consecutive empty lines until there are two left. I like\n+# the option of using two empty lines to have a more pronounced distinction\n+# between two parts of the code, but three seems excessive.\n MaxEmptyLinesToKeep: 2\n \n # spaces\n+\n+# We don't do this consistently, but I'm not sure if that's by accident or not.\n+# I prefer this.\n SpaceBeforeAssignmentOperators: true\n+# ** It seems lots of our code looks like if( instead of if ( and I'm not sure\n+# if it's intentional or not. I prefer if ( because it's not a function call\n+# and if( makes it look like a function call.\n SpaceBeforeParens: ControlStatements\n+# We don't do this, so I doubt this matters.\n SpaceInEmptyParentheses: false\n+# We do this in most places where the comment isn't code, and I'd like to\n+# remove commented out code.\n SpacesBeforeTrailingComments: 1\n+# ** This may be contentious. We aren't consistent here, but I prefer not having\n+# spaces, especially in C++11 where they aren't required for parsing >>.\n SpacesInAngles: false\n+# C++ doesn't have container literals.\n SpacesInContainerLiterals: true\n+# ** We aren't consistent here, but I'd prefer not having C-style casts and\n+# until they are all removed, I might as well have them without spaces.\n SpacesInCStyleCastParentheses: false\n+# ** This is seemingly the most inconsistent formatting thing we do. I prefer\n+# no spaces.\n SpacesInParentheses: false\n \n # parameters\n+\n+# This happens with really long type names and function names and parameter\n+# names, which aren't very common in our codebase.\n AllowAllParametersOfDeclarationOnNextLine: true\n+# Bin packing parameters seems more cluttered than just having one per line,\n+# unless they fit on one line.\n BinPackParameters: false\n \n # pointers\n+\n+# This allows clang-format to guess the value to use for the option after this.\n+# Not useful in our case.\n DerivePointerAlignment: false\n+# ** The options are T* t, T * t and T *t. Note, * and & are treated the same\n+# way, so you get the same behavior for both.\n PointerAlignment: Left\n \n # braces\n+\n+# This should be changed when we move to C++11.\n Cpp11BracedListStyle: false\n \n # single line statements\n+\n+# I tend to prefer not doing this, since it makes blocks harder to notice.\n+# I also prefer to have {} around every block, to avoid goto fail bugs, but\n+# clang-format doesn't add {}'s.\n AllowShortBlocksOnASingleLine: false","path":".clang-format","position":133,"original_position":133,"commit_id":"1298d609af9f6c6759442213911ea8da5fa32aee","original_commit_id":"1298d609af9f6c6759442213911ea8da5fa32aee","user":{"login":"ahmedcharles","id":3112514,"avatar_url":"https://avatars.githubusercontent.com/u/3112514?v=2","gravatar_id":"e487eb194f38fa558ee955b5603d798d","url":"https://api.github.com/users/ahmedcharles","html_url":"https://github.com/ahmedcharles","followers_url":"https://api.github.com/users/ahmedcharles/followers","following_url":"https://api.github.com/users/ahmedcharles/following{/other_user}","gists_url":"https://api.github.com/users/ahmedcharles/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmedcharles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmedcharles/subscriptions","organizations_url":"https://api.github.com/users/ahmedcharles/orgs","repos_url":"https://api.github.com/users/ahmedcharles/repos","events_url":"https://api.github.com/users/ahmedcharles/events{/privacy}","received_events_url":"https://api.github.com/users/ahmedcharles/received_events","type":"User","site_admin":false},"body":"I'm leaving this to be revisited, since I don't know which blocks exactly this impacts.","created_at":"2014-08-27T20:27:04Z","updated_at":"2014-08-27T20:27:04Z","html_url":"https://github.com/Mudlet/Mudlet/pull/81#discussion_r16802105","pull_request_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/81","_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/16802105"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/81#discussion_r16802105"},"pull_request":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/81","id":20219621,"html_url":"https://github.com/Mudlet/Mudlet/pull/81","diff_url":"https://github.com/Mudlet/Mudlet/pull/81.diff","patch_url":"https://github.com/Mudlet/Mudlet/pull/81.patch","issue_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/81","number":81,"state":"open","locked":false,"title":"Discuss clang-format options.","user":{"login":"ahmedcharles","id":3112514,"avatar_url":"https://avatars.githubusercontent.com/u/3112514?v=2","gravatar_id":"e487eb194f38fa558ee955b5603d798d","url":"https://api.github.com/users/ahmedcharles","html_url":"https://github.com/ahmedcharles","followers_url":"https://api.github.com/users/ahmedcharles/followers","following_url":"https://api.github.com/users/ahmedcharles/following{/other_user}","gists_url":"https://api.github.com/users/ahmedcharles/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmedcharles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmedcharles/subscriptions","organizations_url":"https://api.github.com/users/ahmedcharles/orgs","repos_url":"https://api.github.com/users/ahmedcharles/repos","events_url":"https://api.github.com/users/ahmedcharles/events{/privacy}","received_events_url":"https://api.github.com/users/ahmedcharles/received_events","type":"User","site_admin":false},"body":"This isn't meant to be merged, but rather, be a discussion about which\r\noptions people want to use. I've added comments next to each formatting\r\noption that clang-format supports and that we specify. Many of them are\r\nfairly obvious choices and some of the settings I'm ignoring for now,\r\neither for future discussion or because they are for fine tuning later and\r\nnot important at the moment.\r\n\r\nFor things I want to call out as potentially contentious, I'll have the\r\ncomments start with **'s.","created_at":"2014-08-24T13:01:12Z","updated_at":"2014-08-27T20:27:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8e31132325495a9806f427be3cdfe32fdfe6584","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/81/commits","review_comments_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/81/comments","review_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/81/comments","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/1298d609af9f6c6759442213911ea8da5fa32aee","head":{"label":"ahmedcharles:options","ref":"options","sha":"1298d609af9f6c6759442213911ea8da5fa32aee","user":{"login":"ahmedcharles","id":3112514,"avatar_url":"https://avatars.githubusercontent.com/u/3112514?v=2","gravatar_id":"e487eb194f38fa558ee955b5603d798d","url":"https://api.github.com/users/ahmedcharles","html_url":"https://github.com/ahmedcharles","followers_url":"https://api.github.com/users/ahmedcharles/followers","following_url":"https://api.github.com/users/ahmedcharles/following{/other_user}","gists_url":"https://api.github.com/users/ahmedcharles/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmedcharles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmedcharles/subscriptions","organizations_url":"https://api.github.com/users/ahmedcharles/orgs","repos_url":"https://api.github.com/users/ahmedcharles/repos","events_url":"https://api.github.com/users/ahmedcharles/events{/privacy}","received_events_url":"https://api.github.com/users/ahmedcharles/received_events","type":"User","site_admin":false},"repo":{"id":18983099,"name":"Mudlet","full_name":"ahmedcharles/Mudlet","owner":{"login":"ahmedcharles","id":3112514,"avatar_url":"https://avatars.githubusercontent.com/u/3112514?v=2","gravatar_id":"e487eb194f38fa558ee955b5603d798d","url":"https://api.github.com/users/ahmedcharles","html_url":"https://github.com/ahmedcharles","followers_url":"https://api.github.com/users/ahmedcharles/followers","following_url":"https://api.github.com/users/ahmedcharles/following{/other_user}","gists_url":"https://api.github.com/users/ahmedcharles/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmedcharles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmedcharles/subscriptions","organizations_url":"https://api.github.com/users/ahmedcharles/orgs","repos_url":"https://api.github.com/users/ahmedcharles/repos","events_url":"https://api.github.com/users/ahmedcharles/events{/privacy}","received_events_url":"https://api.github.com/users/ahmedcharles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmedcharles/Mudlet","description":"A modern open source MUD client with a graphical user inteface and full built in Lua scripting support for all major platforms.","fork":true,"url":"https://api.github.com/repos/ahmedcharles/Mudlet","forks_url":"https://api.github.com/repos/ahmedcharles/Mudlet/forks","keys_url":"https://api.github.com/repos/ahmedcharles/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmedcharles/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmedcharles/Mudlet/teams","hooks_url":"https://api.github.com/repos/ahmedcharles/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/ahmedcharles/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/ahmedcharles/Mudlet/events","assignees_url":"https://api.github.com/repos/ahmedcharles/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/ahmedcharles/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/ahmedcharles/Mudlet/tags","blobs_url":"https://api.github.com/repos/ahmedcharles/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmedcharles/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmedcharles/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmedcharles/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmedcharles/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmedcharles/Mudlet/languages","stargazers_url":"https://api.github.com/repos/ahmedcharles/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/ahmedcharles/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/ahmedcharles/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/ahmedcharles/Mudlet/subscription","commits_url":"https://api.github.com/repos/ahmedcharles/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmedcharles/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmedcharles/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmedcharles/Mudlet/issues/comments/{number}","contents_url":"https://api.github.com/repos/ahmedcharles/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/ahmedcharles/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmedcharles/Mudlet/merges","archive_url":"https://api.github.com/repos/ahmedcharles/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmedcharles/Mudlet/downloads","issues_url":"https://api.github.com/repos/ahmedcharles/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/ahmedcharles/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmedcharles/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmedcharles/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmedcharles/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/ahmedcharles/Mudlet/releases{/id}","created_at":"2014-04-21T05:21:49Z","updated_at":"2014-07-27T13:59:37Z","pushed_at":"2014-08-27T20:22:31Z","git_url":"git://github.com/ahmedcharles/Mudlet.git","ssh_url":"git@github.com:ahmedcharles/Mudlet.git","clone_url":"https://github.com/ahmedcharles/Mudlet.git","svn_url":"https://github.com/ahmedcharles/Mudlet","homepage":null,"size":20840,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"Mudlet:development","ref":"development","sha":"63d64f326afc82fdce18bdda7c54f34dd5cb8574","user":{"login":"Mudlet","id":6158612,"avatar_url":"https://avatars.githubusercontent.com/u/6158612?v=2","gravatar_id":"9b2ac5cb5062908338d7093c0f670efa","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"repo":{"id":15108812,"name":"Mudlet","full_name":"Mudlet/Mudlet","owner":{"login":"Mudlet","id":6158612,"avatar_url":"https://avatars.githubusercontent.com/u/6158612?v=2","gravatar_id":"9b2ac5cb5062908338d7093c0f670efa","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mudlet/Mudlet","description":"A modern open source MUD client with a graphical user inteface and full built in Lua scripting support for all major platforms.","fork":false,"url":"https://api.github.com/repos/Mudlet/Mudlet","forks_url":"https://api.github.com/repos/Mudlet/Mudlet/forks","keys_url":"https://api.github.com/repos/Mudlet/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mudlet/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mudlet/Mudlet/teams","hooks_url":"https://api.github.com/repos/Mudlet/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/Mudlet/Mudlet/events","assignees_url":"https://api.github.com/repos/Mudlet/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/Mudlet/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/Mudlet/Mudlet/tags","blobs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mudlet/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mudlet/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/Mudlet/Mudlet/languages","stargazers_url":"https://api.github.com/repos/Mudlet/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/Mudlet/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/Mudlet/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/Mudlet/Mudlet/subscription","commits_url":"https://api.github.com/repos/Mudlet/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mudlet/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/comments/{number}","contents_url":"https://api.github.com/repos/Mudlet/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/Mudlet/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mudlet/Mudlet/merges","archive_url":"https://api.github.com/repos/Mudlet/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mudlet/Mudlet/downloads","issues_url":"https://api.github.com/repos/Mudlet/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/Mudlet/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/Mudlet/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mudlet/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/Mudlet/Mudlet/releases{/id}","created_at":"2013-12-11T14:04:21Z","updated_at":"2014-08-26T02:39:00Z","pushed_at":"2014-08-27T14:46:51Z","git_url":"git://github.com/Mudlet/Mudlet.git","ssh_url":"git@github.com:Mudlet/Mudlet.git","clone_url":"https://github.com/Mudlet/Mudlet.git","svn_url":"https://github.com/Mudlet/Mudlet","homepage":null,"size":19735,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":4,"mirror_url":null,"open_issues_count":7,"forks":4,"open_issues":7,"watchers":7,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/81"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/81"},"issue":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/81"},"comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/Mudlet/Mudlet/statuses/1298d609af9f6c6759442213911ea8da5fa32aee"}}}}