GitHub PullRequestReviewCommentEvent at 2014-06-25 04:51:22
Repository: netty
Actor: normanmaurer
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/14169012","id":14169012,"diff_hunk":"@@ -0,0 +1,67 @@\n+/*\n+ * Copyright 2014 The Netty Project\n+ *\n+ * The Netty Project licenses this file to you under the Apache License,\n+ * version 2.0 (the \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at:\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations\n+ * under the License.\n+ */\n+// (BSD License: http://www.opensource.org/licenses/bsd-license)\n+//\n+// Copyright (c) 2011, Joe Walnes and contributors\n+// All rights reserved.\n+//\n+// Redistribution and use in source and binary forms, with or\n+// without modification, are permitted provided that the\n+// following conditions are met:\n+//\n+// * Redistributions of source code must retain the above\n+// copyright notice, this list of conditions and the\n+// following disclaimer.\n+//\n+// * Redistributions in binary form must reproduce the above\n+// copyright notice, this list of conditions and the\n+// following disclaimer in the documentation and/or other\n+// materials provided with the distribution.\n+//\n+// * Neither the name of the Webbit nor the names of\n+// its contributors may be used to endorse or promote products\n+// derived from this software without specific prior written\n+// permission.\n+//\n+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND\n+// CONTRIBUTORS \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES,\n+// INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF\n+// MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE\n+// DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR\n+// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,\n+// INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES\n+// (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE\n+// GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR\n+// BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF\n+// LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT\n+// OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+// POSSIBILITY OF SUCH DAMAGE.","path":"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketClientExtensionHandshaker.java","position":52,"original_position":52,"commit_id":"53238f485e316a93536d336bd7c49c0bbd62a66c","original_commit_id":"53238f485e316a93536d336bd7c49c0bbd62a66c","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?","gravatar_id":"e521627c18ed3feaf9db41e754a79483","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"Again do we need the webbit license header ?","created_at":"2014-06-25T04:51:22Z","updated_at":"2014-06-25T04:51:22Z","html_url":"https://github.com/netty/netty/pull/2574#discussion_r14169012","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/2574","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/14169012"},"html":{"href":"https://github.com/netty/netty/pull/2574#discussion_r14169012"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/2574"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/2574","id":17174493,"html_url":"https://github.com/netty/netty/pull/2574","diff_url":"https://github.com/netty/netty/pull/2574.diff","patch_url":"https://github.com/netty/netty/pull/2574.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/2574","number":2574,"state":"open","title":"Add premessage-deflate extension handler for HTTP WebSocket","user":{"login":"fboucher38","id":4612515,"avatar_url":"https://avatars.githubusercontent.com/u/4612515?","gravatar_id":"4c63c6fb6d3b7465d2df0ad847924dd4","url":"https://api.github.com/users/fboucher38","html_url":"https://github.com/fboucher38","followers_url":"https://api.github.com/users/fboucher38/followers","following_url":"https://api.github.com/users/fboucher38/following{/other_user}","gists_url":"https://api.github.com/users/fboucher38/gists{/gist_id}","starred_url":"https://api.github.com/users/fboucher38/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fboucher38/subscriptions","organizations_url":"https://api.github.com/users/fboucher38/orgs","repos_url":"https://api.github.com/users/fboucher38/repos","events_url":"https://api.github.com/users/fboucher38/events{/privacy}","received_events_url":"https://api.github.com/users/fboucher38/received_events","type":"User","site_admin":false},"body":"Add premessage-deflate extension handler for HTTP WebSocket.\r\n\r\nMotivation:\r\n- Need to compress HTTP WebSocket frames payload.\r\n\r\nModifications:\r\n- Remove UTF8 checking of WebSocketFrames from frame decoder in order to\r\nallow compressed frames to go to the next handler.\r\n- Add a WebsocketPremessageDeflateHandler to initialize the frame deflater/inflater if client is compatible with deflate extension.\r\n\r\nResult:\r\nFirst version of the implementation for feedback.","created_at":"2014-06-16T12:14:02Z","updated_at":"2014-06-25T04:51:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c20c2f5a293dfca7e76a9ae4c40475b32b1b9a27","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/2574/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/2574/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments/{number}","comments_url":"https://api.github.com/repos/netty/netty/issues/2574/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/53238f485e316a93536d336bd7c49c0bbd62a66c","head":{"label":"fboucher38:master","ref":"master","sha":"53238f485e316a93536d336bd7c49c0bbd62a66c","user":{"login":"fboucher38","id":4612515,"avatar_url":"https://avatars.githubusercontent.com/u/4612515?","gravatar_id":"4c63c6fb6d3b7465d2df0ad847924dd4","url":"https://api.github.com/users/fboucher38","html_url":"https://github.com/fboucher38","followers_url":"https://api.github.com/users/fboucher38/followers","following_url":"https://api.github.com/users/fboucher38/following{/other_user}","gists_url":"https://api.github.com/users/fboucher38/gists{/gist_id}","starred_url":"https://api.github.com/users/fboucher38/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fboucher38/subscriptions","organizations_url":"https://api.github.com/users/fboucher38/orgs","repos_url":"https://api.github.com/users/fboucher38/repos","events_url":"https://api.github.com/users/fboucher38/events{/privacy}","received_events_url":"https://api.github.com/users/fboucher38/received_events","type":"User","site_admin":false},"repo":{"id":11527789,"name":"netty","full_name":"fboucher38/netty","owner":{"login":"fboucher38","id":4612515,"avatar_url":"https://avatars.githubusercontent.com/u/4612515?","gravatar_id":"4c63c6fb6d3b7465d2df0ad847924dd4","url":"https://api.github.com/users/fboucher38","html_url":"https://github.com/fboucher38","followers_url":"https://api.github.com/users/fboucher38/followers","following_url":"https://api.github.com/users/fboucher38/following{/other_user}","gists_url":"https://api.github.com/users/fboucher38/gists{/gist_id}","starred_url":"https://api.github.com/users/fboucher38/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fboucher38/subscriptions","organizations_url":"https://api.github.com/users/fboucher38/orgs","repos_url":"https://api.github.com/users/fboucher38/repos","events_url":"https://api.github.com/users/fboucher38/events{/privacy}","received_events_url":"https://api.github.com/users/fboucher38/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fboucher38/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/fboucher38/netty","forks_url":"https://api.github.com/repos/fboucher38/netty/forks","keys_url":"https://api.github.com/repos/fboucher38/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fboucher38/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fboucher38/netty/teams","hooks_url":"https://api.github.com/repos/fboucher38/netty/hooks","issue_events_url":"https://api.github.com/repos/fboucher38/netty/issues/events{/number}","events_url":"https://api.github.com/repos/fboucher38/netty/events","assignees_url":"https://api.github.com/repos/fboucher38/netty/assignees{/user}","branches_url":"https://api.github.com/repos/fboucher38/netty/branches{/branch}","tags_url":"https://api.github.com/repos/fboucher38/netty/tags","blobs_url":"https://api.github.com/repos/fboucher38/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fboucher38/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fboucher38/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/fboucher38/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fboucher38/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/fboucher38/netty/languages","stargazers_url":"https://api.github.com/repos/fboucher38/netty/stargazers","contributors_url":"https://api.github.com/repos/fboucher38/netty/contributors","subscribers_url":"https://api.github.com/repos/fboucher38/netty/subscribers","subscription_url":"https://api.github.com/repos/fboucher38/netty/subscription","commits_url":"https://api.github.com/repos/fboucher38/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/fboucher38/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/fboucher38/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/fboucher38/netty/issues/comments/{number}","contents_url":"https://api.github.com/repos/fboucher38/netty/contents/{+path}","compare_url":"https://api.github.com/repos/fboucher38/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fboucher38/netty/merges","archive_url":"https://api.github.com/repos/fboucher38/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fboucher38/netty/downloads","issues_url":"https://api.github.com/repos/fboucher38/netty/issues{/number}","pulls_url":"https://api.github.com/repos/fboucher38/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/fboucher38/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/fboucher38/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fboucher38/netty/labels{/name}","releases_url":"https://api.github.com/repos/fboucher38/netty/releases{/id}","created_at":"2013-07-19T12:58:42Z","updated_at":"2014-06-24T16:06:00Z","pushed_at":"2014-06-24T16:05:58Z","git_url":"git://github.com/fboucher38/netty.git","ssh_url":"git@github.com:fboucher38/netty.git","clone_url":"https://github.com/fboucher38/netty.git","svn_url":"https://github.com/fboucher38/netty","homepage":"http://netty.io/","size":29157,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:master","ref":"master","sha":"760bbc7ea63fb09cbe25b9359e72f7a5faab4523","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?","gravatar_id":"6347d1c8085203b5bb67d3fe265917b5","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?","gravatar_id":"6347d1c8085203b5bb67d3fe265917b5","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments/{number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2014-06-25T03:56:28Z","pushed_at":"2014-06-24T12:31:33Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":96768,"stargazers_count":3139,"watchers_count":3139,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":1416,"mirror_url":null,"open_issues_count":142,"forks":1416,"open_issues":142,"watchers":3139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/2574"},"html":{"href":"https://github.com/netty/netty/pull/2574"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/2574"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/2574/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/2574/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/2574/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/53238f485e316a93536d336bd7c49c0bbd62a66c"}}}}