GitHub PullRequestReviewCommentEvent at 2014-08-01 13:06:59
Repository: app
Actor: lagodiuk
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/15694517","id":15694517,"diff_hunk":"@@ -0,0 +1,265 @@\n+<?php\n+/**\n+ * Created by PhpStorm.\n+ * User: yurii\n+ * Date: 8/1/14\n+ * Time: 11:04 AM\n+ */\n+\n+class QuestDetailsSolrHelper {\n+\n+\tconst DEFAULT_ABSTRACT_LENGTH = 200;\n+\tconst DEFAULT_THUMBNAIL_WIDTH = 200;\n+\tconst DEFAULT_THUMBNAIL_HEIGHT = 200;\n+\n+\tpublic function getRequiredSolrFields() {\n+\t\treturn [ 'pageid', 'title_*', 'url', 'ns', 'article_type_s', 'categories_*', 'html_*', 'metadata_*' ];\n+\t}\n+\n+\tpublic function consumeResponse( $response ) {\n+\t\t$result = [ ];\n+\t\tforeach ( $response as $item ) {\n+\n+\t\t\t$result[ ] = [\n+\t\t\t\t'id' => $item[ 'pageid' ],\n+\t\t\t\t'title' => $this->findFirstValueByKeyPrefix( $item, 'title_', '' ),\n+\t\t\t\t'url' => $item[ 'url' ],\n+\t\t\t\t'ns' => $item[ 'ns' ],\n+\t\t\t\t'revision' => $this->getRevision( $item ),\n+\t\t\t\t'comments' => $this->getCommentsNumber( $item ),\n+\t\t\t\t'type' => $item[ 'article_type_s' ],\n+\t\t\t\t'categories' => $this->findFirstValueByKeyPrefix( $item, 'categories_', [] ),\n+\t\t\t\t'abstract' => $this->getAbstract( $item ),\n+\t\t\t\t'metadata' => $this->getMetadata( $item ),\n+\t\t\t];\n+\t\t}\n+\n+\t\t$this->addThumbnailsInfo( $result );\n+\n+\t\treturn $result;\n+\t}\n+\n+\t/**\n+\t * Searching for field with prefix 'html_' (e.g. 'html_en' or 'html_fr')\n+\t * After finding corresponding field - shortening its value.\n+\t * If there are few fields with such prefix - working with first one value.\n+\t * If there are no fields with such prefix - returns empty string.\n+\t */\n+\tprotected function getAbstract( &$item ) {","path":"extensions/wikia/POI/QuestDetailsSolrHelper.class.php","position":48,"original_position":48,"commit_id":"3a1b4c069c0a61222e03e1a9cdccf4bb1d60281d","original_commit_id":"3a1b4c069c0a61222e03e1a9cdccf4bb1d60281d","user":{"login":"lagodiuk","id":2650178,"avatar_url":"https://avatars.githubusercontent.com/u/2650178?v=1","gravatar_id":"c5d7a9efe56702063502867d864fe31a","url":"https://api.github.com/users/lagodiuk","html_url":"https://github.com/lagodiuk","followers_url":"https://api.github.com/users/lagodiuk/followers","following_url":"https://api.github.com/users/lagodiuk/following{/other_user}","gists_url":"https://api.github.com/users/lagodiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/lagodiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagodiuk/subscriptions","organizations_url":"https://api.github.com/users/lagodiuk/orgs","repos_url":"https://api.github.com/users/lagodiuk/repos","events_url":"https://api.github.com/users/lagodiuk/events{/privacy}","received_events_url":"https://api.github.com/users/lagodiuk/received_events","type":"User","site_admin":false},"body":"Solr documents from response - not so large, though not a small :) (probably, there can be an issue with size of huge articles)\r\nBut if you consider that this is a premature optimisation, I will just pass arguments by value.","created_at":"2014-08-01T13:06:59Z","updated_at":"2014-08-01T13:06:59Z","html_url":"https://github.com/Wikia/app/pull/4348#discussion_r15694517","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/4348","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/15694517"},"html":{"href":"https://github.com/Wikia/app/pull/4348#discussion_r15694517"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/4348"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/4348","id":19202883,"html_url":"https://github.com/Wikia/app/pull/4348","diff_url":"https://github.com/Wikia/app/pull/4348.diff","patch_url":"https://github.com/Wikia/app/pull/4348.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/4348","number":4348,"state":"open","title":"Point Of Interest (Quest Details etc.)","user":{"login":"lagodiuk","id":2650178,"avatar_url":"https://avatars.githubusercontent.com/u/2650178?v=1","gravatar_id":"c5d7a9efe56702063502867d864fe31a","url":"https://api.github.com/users/lagodiuk","html_url":"https://github.com/lagodiuk","followers_url":"https://api.github.com/users/lagodiuk/followers","following_url":"https://api.github.com/users/lagodiuk/following{/other_user}","gists_url":"https://api.github.com/users/lagodiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/lagodiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagodiuk/subscriptions","organizations_url":"https://api.github.com/users/lagodiuk/orgs","repos_url":"https://api.github.com/users/lagodiuk/repos","events_url":"https://api.github.com/users/lagodiuk/events{/privacy}","received_events_url":"https://api.github.com/users/lagodiuk/received_events","type":"User","site_admin":false},"body":"@wsuchy , @jacekjursza and me - decided to implement QuestDetails API and NearbyQuests API (+ all related stuff) in single brunch (because these tasks are strongly coupled).\r\n\r\nAt the moment - this pull request must be only reviewed and not merged!","created_at":"2014-08-01T10:20:18Z","updated_at":"2014-08-01T13:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d51604d52c6440e83fbfa3b76a1c83a4f83d14c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/4348/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/4348/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/4348/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/3a1b4c069c0a61222e03e1a9cdccf4bb1d60281d","head":{"label":"Wikia:poi","ref":"poi","sha":"3a1b4c069c0a61222e03e1a9cdccf4bb1d60281d","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=1","gravatar_id":"7d465709e42f40da92f14aae7e005558","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=1","gravatar_id":"7d465709e42f40da92f14aae7e005558","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments/{number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2014-07-19T07:47:56Z","pushed_at":"2014-08-01T12:40:10Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":729179,"stargazers_count":60,"watchers_count":60,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":41,"mirror_url":null,"open_issues_count":58,"forks":41,"open_issues":58,"watchers":60,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"d9cdfd21d470f37b04ff48343b338e41780404d5","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=1","gravatar_id":"7d465709e42f40da92f14aae7e005558","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=1","gravatar_id":"7d465709e42f40da92f14aae7e005558","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments/{number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2014-07-19T07:47:56Z","pushed_at":"2014-08-01T12:40:10Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":729179,"stargazers_count":60,"watchers_count":60,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":41,"mirror_url":null,"open_issues_count":58,"forks":41,"open_issues":58,"watchers":60,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/4348"},"html":{"href":"https://github.com/Wikia/app/pull/4348"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/4348"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/4348/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/4348/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/4348/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/3a1b4c069c0a61222e03e1a9cdccf4bb1d60281d"}}}}