GitHub PullRequestReviewCommentEvent at 2014-10-28 16:22:45
Repository: picasso
Actor: dnkoutso
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/square/picasso/pulls/comments/19482639","id":19482639,"diff_hunk":"@@ -47,6 +47,12 @@\n    * This is mutually exclusive with {@link #uri}.\n    */\n   public final int resourceId;\n+  /**\n+   * The optional steady Key for this request to be used instead of a generated cache key.","path":"picasso/src/main/java/com/squareup/picasso/Request.java","position":5,"original_position":5,"commit_id":"48d86c47207be4601207ea928baec441f3909013","original_commit_id":"48d86c47207be4601207ea928baec441f3909013","user":{"login":"dnkoutso","id":310370,"avatar_url":"https://avatars.githubusercontent.com/u/310370?v=2","gravatar_id":"","url":"https://api.github.com/users/dnkoutso","html_url":"https://github.com/dnkoutso","followers_url":"https://api.github.com/users/dnkoutso/followers","following_url":"https://api.github.com/users/dnkoutso/following{/other_user}","gists_url":"https://api.github.com/users/dnkoutso/gists{/gist_id}","starred_url":"https://api.github.com/users/dnkoutso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnkoutso/subscriptions","organizations_url":"https://api.github.com/users/dnkoutso/orgs","repos_url":"https://api.github.com/users/dnkoutso/repos","events_url":"https://api.github.com/users/dnkoutso/events{/privacy}","received_events_url":"https://api.github.com/users/dnkoutso/received_events","type":"User","site_admin":false},"body":"key not capitalized","created_at":"2014-10-28T16:22:45Z","updated_at":"2014-10-28T16:22:45Z","html_url":"https://github.com/square/picasso/pull/724#discussion_r19482639","pull_request_url":"https://api.github.com/repos/square/picasso/pulls/724","_links":{"self":{"href":"https://api.github.com/repos/square/picasso/pulls/comments/19482639"},"html":{"href":"https://github.com/square/picasso/pull/724#discussion_r19482639"},"pull_request":{"href":"https://api.github.com/repos/square/picasso/pulls/724"}}},"pull_request":{"url":"https://api.github.com/repos/square/picasso/pulls/724","id":23469084,"html_url":"https://github.com/square/picasso/pull/724","diff_url":"https://github.com/square/picasso/pull/724.diff","patch_url":"https://github.com/square/picasso/pull/724.patch","issue_url":"https://api.github.com/repos/square/picasso/issues/724","number":724,"state":"open","locked":false,"title":"Add custom cache key functionality","user":{"login":"meisterfuu","id":1564453,"avatar_url":"https://avatars.githubusercontent.com/u/1564453?v=2","gravatar_id":"","url":"https://api.github.com/users/meisterfuu","html_url":"https://github.com/meisterfuu","followers_url":"https://api.github.com/users/meisterfuu/followers","following_url":"https://api.github.com/users/meisterfuu/following{/other_user}","gists_url":"https://api.github.com/users/meisterfuu/gists{/gist_id}","starred_url":"https://api.github.com/users/meisterfuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meisterfuu/subscriptions","organizations_url":"https://api.github.com/users/meisterfuu/orgs","repos_url":"https://api.github.com/users/meisterfuu/repos","events_url":"https://api.github.com/users/meisterfuu/events{/privacy}","received_events_url":"https://api.github.com/users/meisterfuu/received_events","type":"User","site_admin":false},"body":"Had to create a new PR because my old repo had old merge commits. So made a new repo and PR to clean the commits up as asked in the old PR.\r\n\r\nAdds the option to set a custom cache key to be used instead of the uri based one.\r\nI hope this is alright. Should be similar to the last PR that was made for this. I am new to writing tests and feedback is very welcome. If something should be changed comment please.\r\n\r\nThanks","created_at":"2014-10-28T16:21:20Z","updated_at":"2014-10-28T16:22:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8fbbbd54b9d480576986c567579aa8fcb9faa49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/square/picasso/pulls/724/commits","review_comments_url":"https://api.github.com/repos/square/picasso/pulls/724/comments","review_comment_url":"https://api.github.com/repos/square/picasso/pulls/comments/{number}","comments_url":"https://api.github.com/repos/square/picasso/issues/724/comments","statuses_url":"https://api.github.com/repos/square/picasso/statuses/48d86c47207be4601207ea928baec441f3909013","head":{"label":"meisterfuu:master","ref":"master","sha":"48d86c47207be4601207ea928baec441f3909013","user":{"login":"meisterfuu","id":1564453,"avatar_url":"https://avatars.githubusercontent.com/u/1564453?v=2","gravatar_id":"","url":"https://api.github.com/users/meisterfuu","html_url":"https://github.com/meisterfuu","followers_url":"https://api.github.com/users/meisterfuu/followers","following_url":"https://api.github.com/users/meisterfuu/following{/other_user}","gists_url":"https://api.github.com/users/meisterfuu/gists{/gist_id}","starred_url":"https://api.github.com/users/meisterfuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meisterfuu/subscriptions","organizations_url":"https://api.github.com/users/meisterfuu/orgs","repos_url":"https://api.github.com/users/meisterfuu/repos","events_url":"https://api.github.com/users/meisterfuu/events{/privacy}","received_events_url":"https://api.github.com/users/meisterfuu/received_events","type":"User","site_admin":false},"repo":{"id":25878257,"name":"picasso","full_name":"meisterfuu/picasso","owner":{"login":"meisterfuu","id":1564453,"avatar_url":"https://avatars.githubusercontent.com/u/1564453?v=2","gravatar_id":"","url":"https://api.github.com/users/meisterfuu","html_url":"https://github.com/meisterfuu","followers_url":"https://api.github.com/users/meisterfuu/followers","following_url":"https://api.github.com/users/meisterfuu/following{/other_user}","gists_url":"https://api.github.com/users/meisterfuu/gists{/gist_id}","starred_url":"https://api.github.com/users/meisterfuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meisterfuu/subscriptions","organizations_url":"https://api.github.com/users/meisterfuu/orgs","repos_url":"https://api.github.com/users/meisterfuu/repos","events_url":"https://api.github.com/users/meisterfuu/events{/privacy}","received_events_url":"https://api.github.com/users/meisterfuu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meisterfuu/picasso","description":"A powerful image downloading and caching library for Android","fork":true,"url":"https://api.github.com/repos/meisterfuu/picasso","forks_url":"https://api.github.com/repos/meisterfuu/picasso/forks","keys_url":"https://api.github.com/repos/meisterfuu/picasso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meisterfuu/picasso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meisterfuu/picasso/teams","hooks_url":"https://api.github.com/repos/meisterfuu/picasso/hooks","issue_events_url":"https://api.github.com/repos/meisterfuu/picasso/issues/events{/number}","events_url":"https://api.github.com/repos/meisterfuu/picasso/events","assignees_url":"https://api.github.com/repos/meisterfuu/picasso/assignees{/user}","branches_url":"https://api.github.com/repos/meisterfuu/picasso/branches{/branch}","tags_url":"https://api.github.com/repos/meisterfuu/picasso/tags","blobs_url":"https://api.github.com/repos/meisterfuu/picasso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meisterfuu/picasso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meisterfuu/picasso/git/refs{/sha}","trees_url":"https://api.github.com/repos/meisterfuu/picasso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meisterfuu/picasso/statuses/{sha}","languages_url":"https://api.github.com/repos/meisterfuu/picasso/languages","stargazers_url":"https://api.github.com/repos/meisterfuu/picasso/stargazers","contributors_url":"https://api.github.com/repos/meisterfuu/picasso/contributors","subscribers_url":"https://api.github.com/repos/meisterfuu/picasso/subscribers","subscription_url":"https://api.github.com/repos/meisterfuu/picasso/subscription","commits_url":"https://api.github.com/repos/meisterfuu/picasso/commits{/sha}","git_commits_url":"https://api.github.com/repos/meisterfuu/picasso/git/commits{/sha}","comments_url":"https://api.github.com/repos/meisterfuu/picasso/comments{/number}","issue_comment_url":"https://api.github.com/repos/meisterfuu/picasso/issues/comments/{number}","contents_url":"https://api.github.com/repos/meisterfuu/picasso/contents/{+path}","compare_url":"https://api.github.com/repos/meisterfuu/picasso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meisterfuu/picasso/merges","archive_url":"https://api.github.com/repos/meisterfuu/picasso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meisterfuu/picasso/downloads","issues_url":"https://api.github.com/repos/meisterfuu/picasso/issues{/number}","pulls_url":"https://api.github.com/repos/meisterfuu/picasso/pulls{/number}","milestones_url":"https://api.github.com/repos/meisterfuu/picasso/milestones{/number}","notifications_url":"https://api.github.com/repos/meisterfuu/picasso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meisterfuu/picasso/labels{/name}","releases_url":"https://api.github.com/repos/meisterfuu/picasso/releases{/id}","created_at":"2014-10-28T16:13:39Z","updated_at":"2014-10-28T16:18:53Z","pushed_at":"2014-10-28T16:18:53Z","git_url":"git://github.com/meisterfuu/picasso.git","ssh_url":"git@github.com:meisterfuu/picasso.git","clone_url":"https://github.com/meisterfuu/picasso.git","svn_url":"https://github.com/meisterfuu/picasso","homepage":"http://square.github.io/picasso/","size":13179,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"2ce8847cfe05553d7f44baafa9a90db73caf4cc7","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=2","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":10057936,"name":"picasso","full_name":"square/picasso","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=2","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/picasso","description":"A powerful image downloading and caching library for Android","fork":false,"url":"https://api.github.com/repos/square/picasso","forks_url":"https://api.github.com/repos/square/picasso/forks","keys_url":"https://api.github.com/repos/square/picasso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/picasso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/picasso/teams","hooks_url":"https://api.github.com/repos/square/picasso/hooks","issue_events_url":"https://api.github.com/repos/square/picasso/issues/events{/number}","events_url":"https://api.github.com/repos/square/picasso/events","assignees_url":"https://api.github.com/repos/square/picasso/assignees{/user}","branches_url":"https://api.github.com/repos/square/picasso/branches{/branch}","tags_url":"https://api.github.com/repos/square/picasso/tags","blobs_url":"https://api.github.com/repos/square/picasso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/picasso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/picasso/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/picasso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/picasso/statuses/{sha}","languages_url":"https://api.github.com/repos/square/picasso/languages","stargazers_url":"https://api.github.com/repos/square/picasso/stargazers","contributors_url":"https://api.github.com/repos/square/picasso/contributors","subscribers_url":"https://api.github.com/repos/square/picasso/subscribers","subscription_url":"https://api.github.com/repos/square/picasso/subscription","commits_url":"https://api.github.com/repos/square/picasso/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/picasso/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/picasso/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/picasso/issues/comments/{number}","contents_url":"https://api.github.com/repos/square/picasso/contents/{+path}","compare_url":"https://api.github.com/repos/square/picasso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/picasso/merges","archive_url":"https://api.github.com/repos/square/picasso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/picasso/downloads","issues_url":"https://api.github.com/repos/square/picasso/issues{/number}","pulls_url":"https://api.github.com/repos/square/picasso/pulls{/number}","milestones_url":"https://api.github.com/repos/square/picasso/milestones{/number}","notifications_url":"https://api.github.com/repos/square/picasso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/picasso/labels{/name}","releases_url":"https://api.github.com/repos/square/picasso/releases{/id}","created_at":"2013-05-14T15:07:47Z","updated_at":"2014-10-28T15:34:08Z","pushed_at":"2014-10-24T20:17:45Z","git_url":"git://github.com/square/picasso.git","ssh_url":"git@github.com:square/picasso.git","clone_url":"https://github.com/square/picasso.git","svn_url":"https://github.com/square/picasso","homepage":"http://square.github.io/picasso/","size":13179,"stargazers_count":3894,"watchers_count":3894,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1150,"mirror_url":null,"open_issues_count":85,"forks":1150,"open_issues":85,"watchers":3894,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/picasso/pulls/724"},"html":{"href":"https://github.com/square/picasso/pull/724"},"issue":{"href":"https://api.github.com/repos/square/picasso/issues/724"},"comments":{"href":"https://api.github.com/repos/square/picasso/issues/724/comments"},"review_comments":{"href":"https://api.github.com/repos/square/picasso/pulls/724/comments"},"review_comment":{"href":"https://api.github.com/repos/square/picasso/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/square/picasso/pulls/724/commits"},"statuses":{"href":"https://api.github.com/repos/square/picasso/statuses/48d86c47207be4601207ea928baec441f3909013"}}}}