GitHub PullRequestReviewCommentEvent at 2014-12-15 20:43:54
Repository: gaia
Actor: gabrielesvelto
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/21855011","id":21855011,"diff_hunk":"@@ -241,7 +240,13 @@\n       }\n \n       DUMP('The message was successfully saved to the DB');\n-      wpm_sendNotification(message);\n+\n+      if (message.action === 'signal-high') {\n+        wpm_displayWapPushMessage(message.timestamp);\n+      } else {\n+        wpm_sendNotification(message);\n+      }\n+\n       wpm_finish();","path":"apps/wappush/js/wappush.js","position":20,"original_position":20,"commit_id":"3322ef49ae2add517d4c3199314608c2be0e94f1","original_commit_id":"3322ef49ae2add517d4c3199314608c2be0e94f1","user":{"login":"gabrielesvelto","id":1159312,"avatar_url":"https://avatars.githubusercontent.com/u/1159312?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielesvelto","html_url":"https://github.com/gabrielesvelto","followers_url":"https://api.github.com/users/gabrielesvelto/followers","following_url":"https://api.github.com/users/gabrielesvelto/following{/other_user}","gists_url":"https://api.github.com/users/gabrielesvelto/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielesvelto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielesvelto/subscriptions","organizations_url":"https://api.github.com/users/gabrielesvelto/orgs","repos_url":"https://api.github.com/users/gabrielesvelto/repos","events_url":"https://api.github.com/users/gabrielesvelto/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielesvelto/received_events","type":"User","site_admin":false},"body":"Right, that'll definitely close the app, let me fix it (I'll also extend the unit-test to cover this case so that I can't break it in the future).","created_at":"2014-12-15T20:43:54Z","updated_at":"2014-12-15T20:43:54Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/26788#discussion_r21855011","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26788","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/21855011"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/26788#discussion_r21855011"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26788"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26788","id":26075351,"html_url":"https://github.com/mozilla-b2g/gaia/pull/26788","diff_url":"https://github.com/mozilla-b2g/gaia/pull/26788.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/26788.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26788","number":26788,"state":"open","locked":false,"title":"Bug 1067731 - Display immediately WAP Push signal indication messages with the signal-high action set","user":{"login":"gabrielesvelto","id":1159312,"avatar_url":"https://avatars.githubusercontent.com/u/1159312?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielesvelto","html_url":"https://github.com/gabrielesvelto","followers_url":"https://api.github.com/users/gabrielesvelto/followers","following_url":"https://api.github.com/users/gabrielesvelto/following{/other_user}","gists_url":"https://api.github.com/users/gabrielesvelto/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielesvelto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielesvelto/subscriptions","organizations_url":"https://api.github.com/users/gabrielesvelto/orgs","repos_url":"https://api.github.com/users/gabrielesvelto/repos","events_url":"https://api.github.com/users/gabrielesvelto/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielesvelto/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-15T15:10:24Z","updated_at":"2014-12-15T20:43:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bc215ff1ed358f743267d640a02926e1072a824","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26788/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26788/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26788/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/3322ef49ae2add517d4c3199314608c2be0e94f1","head":{"label":"gabrielesvelto:bug-1067731-wap-push-signal-high","ref":"bug-1067731-wap-push-signal-high","sha":"3322ef49ae2add517d4c3199314608c2be0e94f1","user":{"login":"gabrielesvelto","id":1159312,"avatar_url":"https://avatars.githubusercontent.com/u/1159312?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielesvelto","html_url":"https://github.com/gabrielesvelto","followers_url":"https://api.github.com/users/gabrielesvelto/followers","following_url":"https://api.github.com/users/gabrielesvelto/following{/other_user}","gists_url":"https://api.github.com/users/gabrielesvelto/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielesvelto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielesvelto/subscriptions","organizations_url":"https://api.github.com/users/gabrielesvelto/orgs","repos_url":"https://api.github.com/users/gabrielesvelto/repos","events_url":"https://api.github.com/users/gabrielesvelto/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielesvelto/received_events","type":"User","site_admin":false},"repo":{"id":6279318,"name":"gaia","full_name":"gabrielesvelto/gaia","owner":{"login":"gabrielesvelto","id":1159312,"avatar_url":"https://avatars.githubusercontent.com/u/1159312?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielesvelto","html_url":"https://github.com/gabrielesvelto","followers_url":"https://api.github.com/users/gabrielesvelto/followers","following_url":"https://api.github.com/users/gabrielesvelto/following{/other_user}","gists_url":"https://api.github.com/users/gabrielesvelto/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielesvelto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielesvelto/subscriptions","organizations_url":"https://api.github.com/users/gabrielesvelto/orgs","repos_url":"https://api.github.com/users/gabrielesvelto/repos","events_url":"https://api.github.com/users/gabrielesvelto/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielesvelto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabrielesvelto/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/gabrielesvelto/gaia","forks_url":"https://api.github.com/repos/gabrielesvelto/gaia/forks","keys_url":"https://api.github.com/repos/gabrielesvelto/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabrielesvelto/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabrielesvelto/gaia/teams","hooks_url":"https://api.github.com/repos/gabrielesvelto/gaia/hooks","issue_events_url":"https://api.github.com/repos/gabrielesvelto/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/gabrielesvelto/gaia/events","assignees_url":"https://api.github.com/repos/gabrielesvelto/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/gabrielesvelto/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/gabrielesvelto/gaia/tags","blobs_url":"https://api.github.com/repos/gabrielesvelto/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabrielesvelto/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabrielesvelto/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabrielesvelto/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabrielesvelto/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/gabrielesvelto/gaia/languages","stargazers_url":"https://api.github.com/repos/gabrielesvelto/gaia/stargazers","contributors_url":"https://api.github.com/repos/gabrielesvelto/gaia/contributors","subscribers_url":"https://api.github.com/repos/gabrielesvelto/gaia/subscribers","subscription_url":"https://api.github.com/repos/gabrielesvelto/gaia/subscription","commits_url":"https://api.github.com/repos/gabrielesvelto/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabrielesvelto/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabrielesvelto/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabrielesvelto/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/gabrielesvelto/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/gabrielesvelto/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabrielesvelto/gaia/merges","archive_url":"https://api.github.com/repos/gabrielesvelto/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabrielesvelto/gaia/downloads","issues_url":"https://api.github.com/repos/gabrielesvelto/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/gabrielesvelto/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/gabrielesvelto/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/gabrielesvelto/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabrielesvelto/gaia/labels{/name}","releases_url":"https://api.github.com/repos/gabrielesvelto/gaia/releases{/id}","created_at":"2012-10-18T13:53:19Z","updated_at":"2014-12-15T11:33:33Z","pushed_at":"2014-12-15T14:48:47Z","git_url":"git://github.com/gabrielesvelto/gaia.git","ssh_url":"git@github.com:gabrielesvelto/gaia.git","clone_url":"https://github.com/gabrielesvelto/gaia.git","svn_url":"https://github.com/gabrielesvelto/gaia","homepage":"https://wiki.mozilla.org/B2G","size":881288,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"f33c1bc253bfc44df32827e9f90afee1dabf1179","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2014-12-15T20:32:27Z","pushed_at":"2014-12-15T20:32:27Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1345808,"stargazers_count":1824,"watchers_count":1824,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2108,"mirror_url":null,"open_issues_count":743,"forks":2108,"open_issues":743,"watchers":1824,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26788"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/26788"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26788"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/26788/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26788/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/26788/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/3322ef49ae2add517d4c3199314608c2be0e94f1"}}}}