GitHub PullRequestEvent at 2014-05-12 10:48:25
Repository: bedrock
Actor: alexgibson
Payload: {"action":"opened","number":1995,"pull_request":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/1995","id":15760657,"html_url":"https://github.com/mozilla/bedrock/pull/1995","diff_url":"https://github.com/mozilla/bedrock/pull/1995.diff","patch_url":"https://github.com/mozilla/bedrock/pull/1995.patch","issue_url":"https://api.github.com/repos/mozilla/bedrock/issues/1995","number":1995,"state":"open","title":"[fix bug 1004204] Mobile navigation menu highlighting issue","user":{"login":"alexgibson","id":400117,"avatar_url":"https://avatars.githubusercontent.com/u/400117?","gravatar_id":"36de55354bf2cfda4c8eafda6a33e0c4","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"body":"This PR adds a focus-able heading when opening the mobile navigation menu, instead of focusing on the first menu item.\r\n\r\nFocusing the first item in the navigation list is still causing confusion for some folks, as they associate it with highlighting the current page and not the focused state. This PR should hopefully address the main issue, while still making things accessible for screen readers. It also means we can leave our menu link focus states intact this way.\r\n\r\nI've also taken the opportunity to remove of some linear gradient vendor prefix cruft from the mobile nav.","created_at":"2014-05-12T10:48:25Z","updated_at":"2014-05-12T10:48:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/bedrock/pulls/1995/commits","review_comments_url":"https://api.github.com/repos/mozilla/bedrock/pulls/1995/comments","review_comment_url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/bedrock/issues/1995/comments","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/7a9e6614ab7562208462e0563dc728584b0d6ad0","head":{"label":"alexgibson:bug-1004204-mobile-nav-menu-highlighting-issue","ref":"bug-1004204-mobile-nav-menu-highlighting-issue","sha":"7a9e6614ab7562208462e0563dc728584b0d6ad0","user":{"login":"alexgibson","id":400117,"avatar_url":"https://avatars.githubusercontent.com/u/400117?","gravatar_id":"36de55354bf2cfda4c8eafda6a33e0c4","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"repo":{"id":9545146,"name":"bedrock","full_name":"alexgibson/bedrock","owner":{"login":"alexgibson","id":400117,"avatar_url":"https://avatars.githubusercontent.com/u/400117?","gravatar_id":"36de55354bf2cfda4c8eafda6a33e0c4","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexgibson/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":true,"url":"https://api.github.com/repos/alexgibson/bedrock","forks_url":"https://api.github.com/repos/alexgibson/bedrock/forks","keys_url":"https://api.github.com/repos/alexgibson/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexgibson/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexgibson/bedrock/teams","hooks_url":"https://api.github.com/repos/alexgibson/bedrock/hooks","issue_events_url":"https://api.github.com/repos/alexgibson/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/alexgibson/bedrock/events","assignees_url":"https://api.github.com/repos/alexgibson/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/alexgibson/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/alexgibson/bedrock/tags","blobs_url":"https://api.github.com/repos/alexgibson/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexgibson/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexgibson/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexgibson/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexgibson/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/alexgibson/bedrock/languages","stargazers_url":"https://api.github.com/repos/alexgibson/bedrock/stargazers","contributors_url":"https://api.github.com/repos/alexgibson/bedrock/contributors","subscribers_url":"https://api.github.com/repos/alexgibson/bedrock/subscribers","subscription_url":"https://api.github.com/repos/alexgibson/bedrock/subscription","commits_url":"https://api.github.com/repos/alexgibson/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexgibson/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexgibson/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexgibson/bedrock/issues/comments/{number}","contents_url":"https://api.github.com/repos/alexgibson/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/alexgibson/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexgibson/bedrock/merges","archive_url":"https://api.github.com/repos/alexgibson/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexgibson/bedrock/downloads","issues_url":"https://api.github.com/repos/alexgibson/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/alexgibson/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/alexgibson/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/alexgibson/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexgibson/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/alexgibson/bedrock/releases{/id}","created_at":"2013-04-19T12:36:05Z","updated_at":"2014-05-12T10:48:25Z","pushed_at":"2014-05-12T10:38:07Z","git_url":"git://github.com/alexgibson/bedrock.git","ssh_url":"git@github.com:alexgibson/bedrock.git","clone_url":"https://github.com/alexgibson/bedrock.git","svn_url":"https://github.com/alexgibson/bedrock","homepage":"http://mozilla.org","size":275567,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"830dade3a9884a6fa770542b3be9e255a59ff445","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1616665,"name":"bedrock","full_name":"mozilla/bedrock","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?","gravatar_id":"9ba739c8f3288e256b13553e4d257b5e","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":false,"url":"https://api.github.com/repos/mozilla/bedrock","forks_url":"https://api.github.com/repos/mozilla/bedrock/forks","keys_url":"https://api.github.com/repos/mozilla/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/bedrock/teams","hooks_url":"https://api.github.com/repos/mozilla/bedrock/hooks","issue_events_url":"https://api.github.com/repos/mozilla/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/bedrock/events","assignees_url":"https://api.github.com/repos/mozilla/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/bedrock/tags","blobs_url":"https://api.github.com/repos/mozilla/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/bedrock/languages","stargazers_url":"https://api.github.com/repos/mozilla/bedrock/stargazers","contributors_url":"https://api.github.com/repos/mozilla/bedrock/contributors","subscribers_url":"https://api.github.com/repos/mozilla/bedrock/subscribers","subscription_url":"https://api.github.com/repos/mozilla/bedrock/subscription","commits_url":"https://api.github.com/repos/mozilla/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/bedrock/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/bedrock/merges","archive_url":"https://api.github.com/repos/mozilla/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/bedrock/downloads","issues_url":"https://api.github.com/repos/mozilla/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/bedrock/releases{/id}","created_at":"2011-04-14T22:57:57Z","updated_at":"2014-05-12T08:43:21Z","pushed_at":"2014-05-12T08:43:21Z","git_url":"git://github.com/mozilla/bedrock.git","ssh_url":"git@github.com:mozilla/bedrock.git","clone_url":"https://github.com/mozilla/bedrock.git","svn_url":"https://github.com/mozilla/bedrock","homepage":"http://mozilla.org","size":297811,"stargazers_count":164,"watchers_count":164,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":237,"mirror_url":null,"open_issues_count":21,"forks":237,"open_issues":21,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/1995"},"html":{"href":"https://github.com/mozilla/bedrock/pull/1995"},"issue":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/1995"},"comments":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/1995/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/1995/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/1995/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/bedrock/statuses/7a9e6614ab7562208462e0563dc728584b0d6ad0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":43,"changed_files":3}}