GitHub PullRequestEvent at 2014-09-30 18:46:24
Repository: daily_affirmation
Actor: glanotte
Payload: {"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/teamsnap/daily_affirmation/pulls/6","id":22025168,"html_url":"https://github.com/teamsnap/daily_affirmation/pull/6","diff_url":"https://github.com/teamsnap/daily_affirmation/pull/6.diff","patch_url":"https://github.com/teamsnap/daily_affirmation/pull/6.patch","issue_url":"https://api.github.com/repos/teamsnap/daily_affirmation/issues/6","number":6,"state":"closed","locked":false,"title":"add before and after options to date validator","user":{"login":"glanotte","id":118086,"avatar_url":"https://avatars.githubusercontent.com/u/118086?v=2","gravatar_id":"","url":"https://api.github.com/users/glanotte","html_url":"https://github.com/glanotte","followers_url":"https://api.github.com/users/glanotte/followers","following_url":"https://api.github.com/users/glanotte/following{/other_user}","gists_url":"https://api.github.com/users/glanotte/gists{/gist_id}","starred_url":"https://api.github.com/users/glanotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glanotte/subscriptions","organizations_url":"https://api.github.com/users/glanotte/orgs","repos_url":"https://api.github.com/users/glanotte/repos","events_url":"https://api.github.com/users/glanotte/events{/privacy}","received_events_url":"https://api.github.com/users/glanotte/received_events","type":"User","site_admin":false},"body":"I noticed that the numericality validator had `:greater_than` and `:less_than`. I went with `:before` and `:after` as I felt it was more accurate in relation to a date.","created_at":"2014-09-30T18:35:22Z","updated_at":"2014-09-30T18:46:24Z","closed_at":"2014-09-30T18:46:24Z","merged_at":"2014-09-30T18:46:24Z","merge_commit_sha":"dfda9e67386cb13ab07c8656bdb74b19a0b1bfe0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/teamsnap/daily_affirmation/pulls/6/commits","review_comments_url":"https://api.github.com/repos/teamsnap/daily_affirmation/pulls/6/comments","review_comment_url":"https://api.github.com/repos/teamsnap/daily_affirmation/pulls/comments/{number}","comments_url":"https://api.github.com/repos/teamsnap/daily_affirmation/issues/6/comments","statuses_url":"https://api.github.com/repos/teamsnap/daily_affirmation/statuses/119fa386ae4f1d27f38064ab8ffff20f4e3d91ea","head":{"label":"teamsnap:add-before-to-date","ref":"add-before-to-date","sha":"119fa386ae4f1d27f38064ab8ffff20f4e3d91ea","user":{"login":"teamsnap","id":69031,"avatar_url":"https://avatars.githubusercontent.com/u/69031?v=2","gravatar_id":"","url":"https://api.github.com/users/teamsnap","html_url":"https://github.com/teamsnap","followers_url":"https://api.github.com/users/teamsnap/followers","following_url":"https://api.github.com/users/teamsnap/following{/other_user}","gists_url":"https://api.github.com/users/teamsnap/gists{/gist_id}","starred_url":"https://api.github.com/users/teamsnap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamsnap/subscriptions","organizations_url":"https://api.github.com/users/teamsnap/orgs","repos_url":"https://api.github.com/users/teamsnap/repos","events_url":"https://api.github.com/users/teamsnap/events{/privacy}","received_events_url":"https://api.github.com/users/teamsnap/received_events","type":"Organization","site_admin":false},"repo":{"id":15284923,"name":"daily_affirmation","full_name":"teamsnap/daily_affirmation","owner":{"login":"teamsnap","id":69031,"avatar_url":"https://avatars.githubusercontent.com/u/69031?v=2","gravatar_id":"","url":"https://api.github.com/users/teamsnap","html_url":"https://github.com/teamsnap","followers_url":"https://api.github.com/users/teamsnap/followers","following_url":"https://api.github.com/users/teamsnap/following{/other_user}","gists_url":"https://api.github.com/users/teamsnap/gists{/gist_id}","starred_url":"https://api.github.com/users/teamsnap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamsnap/subscriptions","organizations_url":"https://api.github.com/users/teamsnap/orgs","repos_url":"https://api.github.com/users/teamsnap/repos","events_url":"https://api.github.com/users/teamsnap/events{/privacy}","received_events_url":"https://api.github.com/users/teamsnap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamsnap/daily_affirmation","description":"A simple library for external validations of POROs","fork":false,"url":"https://api.github.com/repos/teamsnap/daily_affirmation","forks_url":"https://api.github.com/repos/teamsnap/daily_affirmation/forks","keys_url":"https://api.github.com/repos/teamsnap/daily_affirmation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamsnap/daily_affirmation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamsnap/daily_affirmation/teams","hooks_url":"https://api.github.com/repos/teamsnap/daily_affirmation/hooks","issue_events_url":"https://api.github.com/repos/teamsnap/daily_affirmation/issues/events{/number}","events_url":"https://api.github.com/repos/teamsnap/daily_affirmation/events","assignees_url":"https://api.github.com/repos/teamsnap/daily_affirmation/assignees{/user}","branches_url":"https://api.github.com/repos/teamsnap/daily_affirmation/branches{/branch}","tags_url":"https://api.github.com/repos/teamsnap/daily_affirmation/tags","blobs_url":"https://api.github.com/repos/teamsnap/daily_affirmation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamsnap/daily_affirmation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamsnap/daily_affirmation/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamsnap/daily_affirmation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamsnap/daily_affirmation/statuses/{sha}","languages_url":"https://api.github.com/repos/teamsnap/daily_affirmation/languages","stargazers_url":"https://api.github.com/repos/teamsnap/daily_affirmation/stargazers","contributors_url":"https://api.github.com/repos/teamsnap/daily_affirmation/contributors","subscribers_url":"https://api.github.com/repos/teamsnap/daily_affirmation/subscribers","subscription_url":"https://api.github.com/repos/teamsnap/daily_affirmation/subscription","commits_url":"https://api.github.com/repos/teamsnap/daily_affirmation/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamsnap/daily_affirmation/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamsnap/daily_affirmation/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamsnap/daily_affirmation/issues/comments/{number}","contents_url":"https://api.github.com/repos/teamsnap/daily_affirmation/contents/{+path}","compare_url":"https://api.github.com/repos/teamsnap/daily_affirmation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamsnap/daily_affirmation/merges","archive_url":"https://api.github.com/repos/teamsnap/daily_affirmation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamsnap/daily_affirmation/downloads","issues_url":"https://api.github.com/repos/teamsnap/daily_affirmation/issues{/number}","pulls_url":"https://api.github.com/repos/teamsnap/daily_affirmation/pulls{/number}","milestones_url":"https://api.github.com/repos/teamsnap/daily_affirmation/milestones{/number}","notifications_url":"https://api.github.com/repos/teamsnap/daily_affirmation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamsnap/daily_affirmation/labels{/name}","releases_url":"https://api.github.com/repos/teamsnap/daily_affirmation/releases{/id}","created_at":"2013-12-18T14:12:36Z","updated_at":"2014-09-23T01:25:10Z","pushed_at":"2014-09-30T18:46:24Z","git_url":"git://github.com/teamsnap/daily_affirmation.git","ssh_url":"git@github.com:teamsnap/daily_affirmation.git","clone_url":"https://github.com/teamsnap/daily_affirmation.git","svn_url":"https://github.com/teamsnap/daily_affirmation","homepage":"","size":534,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"teamsnap:master","ref":"master","sha":"5c765faa1027c18dcca563fb6ebeabd0b1ab5d17","user":{"login":"teamsnap","id":69031,"avatar_url":"https://avatars.githubusercontent.com/u/69031?v=2","gravatar_id":"","url":"https://api.github.com/users/teamsnap","html_url":"https://github.com/teamsnap","followers_url":"https://api.github.com/users/teamsnap/followers","following_url":"https://api.github.com/users/teamsnap/following{/other_user}","gists_url":"https://api.github.com/users/teamsnap/gists{/gist_id}","starred_url":"https://api.github.com/users/teamsnap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamsnap/subscriptions","organizations_url":"https://api.github.com/users/teamsnap/orgs","repos_url":"https://api.github.com/users/teamsnap/repos","events_url":"https://api.github.com/users/teamsnap/events{/privacy}","received_events_url":"https://api.github.com/users/teamsnap/received_events","type":"Organization","site_admin":false},"repo":{"id":15284923,"name":"daily_affirmation","full_name":"teamsnap/daily_affirmation","owner":{"login":"teamsnap","id":69031,"avatar_url":"https://avatars.githubusercontent.com/u/69031?v=2","gravatar_id":"","url":"https://api.github.com/users/teamsnap","html_url":"https://github.com/teamsnap","followers_url":"https://api.github.com/users/teamsnap/followers","following_url":"https://api.github.com/users/teamsnap/following{/other_user}","gists_url":"https://api.github.com/users/teamsnap/gists{/gist_id}","starred_url":"https://api.github.com/users/teamsnap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamsnap/subscriptions","organizations_url":"https://api.github.com/users/teamsnap/orgs","repos_url":"https://api.github.com/users/teamsnap/repos","events_url":"https://api.github.com/users/teamsnap/events{/privacy}","received_events_url":"https://api.github.com/users/teamsnap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamsnap/daily_affirmation","description":"A simple library for external validations of POROs","fork":false,"url":"https://api.github.com/repos/teamsnap/daily_affirmation","forks_url":"https://api.github.com/repos/teamsnap/daily_affirmation/forks","keys_url":"https://api.github.com/repos/teamsnap/daily_affirmation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamsnap/daily_affirmation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamsnap/daily_affirmation/teams","hooks_url":"https://api.github.com/repos/teamsnap/daily_affirmation/hooks","issue_events_url":"https://api.github.com/repos/teamsnap/daily_affirmation/issues/events{/number}","events_url":"https://api.github.com/repos/teamsnap/daily_affirmation/events","assignees_url":"https://api.github.com/repos/teamsnap/daily_affirmation/assignees{/user}","branches_url":"https://api.github.com/repos/teamsnap/daily_affirmation/branches{/branch}","tags_url":"https://api.github.com/repos/teamsnap/daily_affirmation/tags","blobs_url":"https://api.github.com/repos/teamsnap/daily_affirmation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamsnap/daily_affirmation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamsnap/daily_affirmation/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamsnap/daily_affirmation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamsnap/daily_affirmation/statuses/{sha}","languages_url":"https://api.github.com/repos/teamsnap/daily_affirmation/languages","stargazers_url":"https://api.github.com/repos/teamsnap/daily_affirmation/stargazers","contributors_url":"https://api.github.com/repos/teamsnap/daily_affirmation/contributors","subscribers_url":"https://api.github.com/repos/teamsnap/daily_affirmation/subscribers","subscription_url":"https://api.github.com/repos/teamsnap/daily_affirmation/subscription","commits_url":"https://api.github.com/repos/teamsnap/daily_affirmation/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamsnap/daily_affirmation/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamsnap/daily_affirmation/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamsnap/daily_affirmation/issues/comments/{number}","contents_url":"https://api.github.com/repos/teamsnap/daily_affirmation/contents/{+path}","compare_url":"https://api.github.com/repos/teamsnap/daily_affirmation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamsnap/daily_affirmation/merges","archive_url":"https://api.github.com/repos/teamsnap/daily_affirmation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamsnap/daily_affirmation/downloads","issues_url":"https://api.github.com/repos/teamsnap/daily_affirmation/issues{/number}","pulls_url":"https://api.github.com/repos/teamsnap/daily_affirmation/pulls{/number}","milestones_url":"https://api.github.com/repos/teamsnap/daily_affirmation/milestones{/number}","notifications_url":"https://api.github.com/repos/teamsnap/daily_affirmation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamsnap/daily_affirmation/labels{/name}","releases_url":"https://api.github.com/repos/teamsnap/daily_affirmation/releases{/id}","created_at":"2013-12-18T14:12:36Z","updated_at":"2014-09-23T01:25:10Z","pushed_at":"2014-09-30T18:46:24Z","git_url":"git://github.com/teamsnap/daily_affirmation.git","ssh_url":"git@github.com:teamsnap/daily_affirmation.git","clone_url":"https://github.com/teamsnap/daily_affirmation.git","svn_url":"https://github.com/teamsnap/daily_affirmation","homepage":"","size":534,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teamsnap/daily_affirmation/pulls/6"},"html":{"href":"https://github.com/teamsnap/daily_affirmation/pull/6"},"issue":{"href":"https://api.github.com/repos/teamsnap/daily_affirmation/issues/6"},"comments":{"href":"https://api.github.com/repos/teamsnap/daily_affirmation/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/teamsnap/daily_affirmation/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/teamsnap/daily_affirmation/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/teamsnap/daily_affirmation/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/teamsnap/daily_affirmation/statuses/119fa386ae4f1d27f38064ab8ffff20f4e3d91ea"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"glanotte","id":118086,"avatar_url":"https://avatars.githubusercontent.com/u/118086?v=2","gravatar_id":"","url":"https://api.github.com/users/glanotte","html_url":"https://github.com/glanotte","followers_url":"https://api.github.com/users/glanotte/followers","following_url":"https://api.github.com/users/glanotte/following{/other_user}","gists_url":"https://api.github.com/users/glanotte/gists{/gist_id}","starred_url":"https://api.github.com/users/glanotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glanotte/subscriptions","organizations_url":"https://api.github.com/users/glanotte/orgs","repos_url":"https://api.github.com/users/glanotte/repos","events_url":"https://api.github.com/users/glanotte/events{/privacy}","received_events_url":"https://api.github.com/users/glanotte/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":45,"deletions":1,"changed_files":2}}