GitHub PullRequestReviewCommentEvent at 2014-07-29 13:52:39
Repository: model
Actor: jodosha
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/lotus/model/pulls/comments/15523609","id":15523609,"diff_hunk":"@@ -111,7 +111,15 @@ def all\n           #        .where(framework: 'lotus')\n           #\n           #   # => SELECT * FROM `projects` WHERE (`language` = 'ruby') AND (`framework` = 'lotus')\n-          def where(condition)\n+          #\n+          # @example Expressions\n+          #\n+          #   query.where{ publish_at > function(:DATE, Date.today) }","path":"lib/lotus/model/adapters/sql/query.rb","position":8,"original_position":8,"commit_id":"3fe74fcf50ab181611c29389f5009919c5aadcaa","original_commit_id":"3fe74fcf50ab181611c29389f5009919c5aadcaa","user":{"login":"jodosha","id":5089,"avatar_url":"https://avatars.githubusercontent.com/u/5089?","gravatar_id":"76aa5b311fb40fdc2bb70c0282d66af3","url":"https://api.github.com/users/jodosha","html_url":"https://github.com/jodosha","followers_url":"https://api.github.com/users/jodosha/followers","following_url":"https://api.github.com/users/jodosha/following{/other_user}","gists_url":"https://api.github.com/users/jodosha/gists{/gist_id}","starred_url":"https://api.github.com/users/jodosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodosha/subscriptions","organizations_url":"https://api.github.com/users/jodosha/orgs","repos_url":"https://api.github.com/users/jodosha/repos","events_url":"https://api.github.com/users/jodosha/events{/privacy}","received_events_url":"https://api.github.com/users/jodosha/received_events","type":"User","site_admin":false},"body":"I'd keep this example out for now, let's document it with the same example that you used in test.","created_at":"2014-07-29T13:52:39Z","updated_at":"2014-07-29T13:52:39Z","html_url":"https://github.com/lotus/model/pull/46#discussion_r15523609","pull_request_url":"https://api.github.com/repos/lotus/model/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/lotus/model/pulls/comments/15523609"},"html":{"href":"https://github.com/lotus/model/pull/46#discussion_r15523609"},"pull_request":{"href":"https://api.github.com/repos/lotus/model/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/lotus/model/pulls/46","id":19024845,"html_url":"https://github.com/lotus/model/pull/46","diff_url":"https://github.com/lotus/model/pull/46.diff","patch_url":"https://github.com/lotus/model/pull/46.patch","issue_url":"https://api.github.com/repos/lotus/model/issues/46","number":46,"state":"open","title":"added expressions to where condition","user":{"login":"coenert","id":2033982,"avatar_url":"https://avatars.githubusercontent.com/u/2033982?","gravatar_id":"9a32f348d340d422a8dd13776beb21bd","url":"https://api.github.com/users/coenert","html_url":"https://github.com/coenert","followers_url":"https://api.github.com/users/coenert/followers","following_url":"https://api.github.com/users/coenert/following{/other_user}","gists_url":"https://api.github.com/users/coenert/gists{/gist_id}","starred_url":"https://api.github.com/users/coenert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coenert/subscriptions","organizations_url":"https://api.github.com/users/coenert/orgs","repos_url":"https://api.github.com/users/coenert/repos","events_url":"https://api.github.com/users/coenert/events{/privacy}","received_events_url":"https://api.github.com/users/coenert/received_events","type":"User","site_admin":false},"body":"fix for #42 ","created_at":"2014-07-29T13:03:48Z","updated_at":"2014-07-29T13:52:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"215391800f3be44ee15b22815248e681603d48a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lotus/model/pulls/46/commits","review_comments_url":"https://api.github.com/repos/lotus/model/pulls/46/comments","review_comment_url":"https://api.github.com/repos/lotus/model/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lotus/model/issues/46/comments","statuses_url":"https://api.github.com/repos/lotus/model/statuses/3fe74fcf50ab181611c29389f5009919c5aadcaa","head":{"label":"coenert:master","ref":"master","sha":"3fe74fcf50ab181611c29389f5009919c5aadcaa","user":{"login":"coenert","id":2033982,"avatar_url":"https://avatars.githubusercontent.com/u/2033982?","gravatar_id":"9a32f348d340d422a8dd13776beb21bd","url":"https://api.github.com/users/coenert","html_url":"https://github.com/coenert","followers_url":"https://api.github.com/users/coenert/followers","following_url":"https://api.github.com/users/coenert/following{/other_user}","gists_url":"https://api.github.com/users/coenert/gists{/gist_id}","starred_url":"https://api.github.com/users/coenert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coenert/subscriptions","organizations_url":"https://api.github.com/users/coenert/orgs","repos_url":"https://api.github.com/users/coenert/repos","events_url":"https://api.github.com/users/coenert/events{/privacy}","received_events_url":"https://api.github.com/users/coenert/received_events","type":"User","site_admin":false},"repo":{"id":22343245,"name":"model","full_name":"coenert/model","owner":{"login":"coenert","id":2033982,"avatar_url":"https://avatars.githubusercontent.com/u/2033982?","gravatar_id":"9a32f348d340d422a8dd13776beb21bd","url":"https://api.github.com/users/coenert","html_url":"https://github.com/coenert","followers_url":"https://api.github.com/users/coenert/followers","following_url":"https://api.github.com/users/coenert/following{/other_user}","gists_url":"https://api.github.com/users/coenert/gists{/gist_id}","starred_url":"https://api.github.com/users/coenert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coenert/subscriptions","organizations_url":"https://api.github.com/users/coenert/orgs","repos_url":"https://api.github.com/users/coenert/repos","events_url":"https://api.github.com/users/coenert/events{/privacy}","received_events_url":"https://api.github.com/users/coenert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coenert/model","description":"Model layer for Lotus","fork":true,"url":"https://api.github.com/repos/coenert/model","forks_url":"https://api.github.com/repos/coenert/model/forks","keys_url":"https://api.github.com/repos/coenert/model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coenert/model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coenert/model/teams","hooks_url":"https://api.github.com/repos/coenert/model/hooks","issue_events_url":"https://api.github.com/repos/coenert/model/issues/events{/number}","events_url":"https://api.github.com/repos/coenert/model/events","assignees_url":"https://api.github.com/repos/coenert/model/assignees{/user}","branches_url":"https://api.github.com/repos/coenert/model/branches{/branch}","tags_url":"https://api.github.com/repos/coenert/model/tags","blobs_url":"https://api.github.com/repos/coenert/model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coenert/model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coenert/model/git/refs{/sha}","trees_url":"https://api.github.com/repos/coenert/model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coenert/model/statuses/{sha}","languages_url":"https://api.github.com/repos/coenert/model/languages","stargazers_url":"https://api.github.com/repos/coenert/model/stargazers","contributors_url":"https://api.github.com/repos/coenert/model/contributors","subscribers_url":"https://api.github.com/repos/coenert/model/subscribers","subscription_url":"https://api.github.com/repos/coenert/model/subscription","commits_url":"https://api.github.com/repos/coenert/model/commits{/sha}","git_commits_url":"https://api.github.com/repos/coenert/model/git/commits{/sha}","comments_url":"https://api.github.com/repos/coenert/model/comments{/number}","issue_comment_url":"https://api.github.com/repos/coenert/model/issues/comments/{number}","contents_url":"https://api.github.com/repos/coenert/model/contents/{+path}","compare_url":"https://api.github.com/repos/coenert/model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coenert/model/merges","archive_url":"https://api.github.com/repos/coenert/model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coenert/model/downloads","issues_url":"https://api.github.com/repos/coenert/model/issues{/number}","pulls_url":"https://api.github.com/repos/coenert/model/pulls{/number}","milestones_url":"https://api.github.com/repos/coenert/model/milestones{/number}","notifications_url":"https://api.github.com/repos/coenert/model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coenert/model/labels{/name}","releases_url":"https://api.github.com/repos/coenert/model/releases{/id}","created_at":"2014-07-28T13:24:02Z","updated_at":"2014-07-28T20:20:41Z","pushed_at":"2014-07-29T13:01:50Z","git_url":"git://github.com/coenert/model.git","ssh_url":"git@github.com:coenert/model.git","clone_url":"https://github.com/coenert/model.git","svn_url":"https://github.com/coenert/model","homepage":null,"size":1345,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lotus:master","ref":"master","sha":"1b0ee81e99cc944e56b782d0340eaaa93023be86","user":{"login":"lotus","id":3210273,"avatar_url":"https://avatars.githubusercontent.com/u/3210273?","gravatar_id":null,"url":"https://api.github.com/users/lotus","html_url":"https://github.com/lotus","followers_url":"https://api.github.com/users/lotus/followers","following_url":"https://api.github.com/users/lotus/following{/other_user}","gists_url":"https://api.github.com/users/lotus/gists{/gist_id}","starred_url":"https://api.github.com/users/lotus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lotus/subscriptions","organizations_url":"https://api.github.com/users/lotus/orgs","repos_url":"https://api.github.com/users/lotus/repos","events_url":"https://api.github.com/users/lotus/events{/privacy}","received_events_url":"https://api.github.com/users/lotus/received_events","type":"Organization","site_admin":false},"repo":{"id":16760719,"name":"model","full_name":"lotus/model","owner":{"login":"lotus","id":3210273,"avatar_url":"https://avatars.githubusercontent.com/u/3210273?","gravatar_id":null,"url":"https://api.github.com/users/lotus","html_url":"https://github.com/lotus","followers_url":"https://api.github.com/users/lotus/followers","following_url":"https://api.github.com/users/lotus/following{/other_user}","gists_url":"https://api.github.com/users/lotus/gists{/gist_id}","starred_url":"https://api.github.com/users/lotus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lotus/subscriptions","organizations_url":"https://api.github.com/users/lotus/orgs","repos_url":"https://api.github.com/users/lotus/repos","events_url":"https://api.github.com/users/lotus/events{/privacy}","received_events_url":"https://api.github.com/users/lotus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lotus/model","description":"Model layer for Lotus","fork":false,"url":"https://api.github.com/repos/lotus/model","forks_url":"https://api.github.com/repos/lotus/model/forks","keys_url":"https://api.github.com/repos/lotus/model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lotus/model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lotus/model/teams","hooks_url":"https://api.github.com/repos/lotus/model/hooks","issue_events_url":"https://api.github.com/repos/lotus/model/issues/events{/number}","events_url":"https://api.github.com/repos/lotus/model/events","assignees_url":"https://api.github.com/repos/lotus/model/assignees{/user}","branches_url":"https://api.github.com/repos/lotus/model/branches{/branch}","tags_url":"https://api.github.com/repos/lotus/model/tags","blobs_url":"https://api.github.com/repos/lotus/model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lotus/model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lotus/model/git/refs{/sha}","trees_url":"https://api.github.com/repos/lotus/model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lotus/model/statuses/{sha}","languages_url":"https://api.github.com/repos/lotus/model/languages","stargazers_url":"https://api.github.com/repos/lotus/model/stargazers","contributors_url":"https://api.github.com/repos/lotus/model/contributors","subscribers_url":"https://api.github.com/repos/lotus/model/subscribers","subscription_url":"https://api.github.com/repos/lotus/model/subscription","commits_url":"https://api.github.com/repos/lotus/model/commits{/sha}","git_commits_url":"https://api.github.com/repos/lotus/model/git/commits{/sha}","comments_url":"https://api.github.com/repos/lotus/model/comments{/number}","issue_comment_url":"https://api.github.com/repos/lotus/model/issues/comments/{number}","contents_url":"https://api.github.com/repos/lotus/model/contents/{+path}","compare_url":"https://api.github.com/repos/lotus/model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lotus/model/merges","archive_url":"https://api.github.com/repos/lotus/model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lotus/model/downloads","issues_url":"https://api.github.com/repos/lotus/model/issues{/number}","pulls_url":"https://api.github.com/repos/lotus/model/pulls{/number}","milestones_url":"https://api.github.com/repos/lotus/model/milestones{/number}","notifications_url":"https://api.github.com/repos/lotus/model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lotus/model/labels{/name}","releases_url":"https://api.github.com/repos/lotus/model/releases{/id}","created_at":"2014-02-12T08:25:42Z","updated_at":"2014-07-29T13:37:44Z","pushed_at":"2014-07-29T13:28:02Z","git_url":"git://github.com/lotus/model.git","ssh_url":"git@github.com:lotus/model.git","clone_url":"https://github.com/lotus/model.git","svn_url":"https://github.com/lotus/model","homepage":null,"size":1345,"stargazers_count":135,"watchers_count":135,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":35,"mirror_url":null,"open_issues_count":8,"forks":35,"open_issues":8,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lotus/model/pulls/46"},"html":{"href":"https://github.com/lotus/model/pull/46"},"issue":{"href":"https://api.github.com/repos/lotus/model/issues/46"},"comments":{"href":"https://api.github.com/repos/lotus/model/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/lotus/model/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/lotus/model/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lotus/model/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/lotus/model/statuses/3fe74fcf50ab181611c29389f5009919c5aadcaa"}}}}