GitHub PullRequestReviewCommentEvent at 2014-04-07 15:17:50
Repository: gaia
Actor: julienw
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/11348233","id":11348233,"diff_hunk":"@@ -227,15 +228,26 @@\n       }\n \n       type = (found.type && found.type[0]) || '';\n+      if (type !== '' && _(type) !== '') {\n+        // Non localized label is better than a blank string\n+        type = _(type);\n+      }\n       carrier = (hasUniqueCarriers || hasUniqueTypes) ? found.carrier : '';\n       value = carrier || found.value;\n-      ending = ' | ' + (carrier || value);","path":"apps/sms/js/utils.js","position":18,"original_position":18,"commit_id":"0fa989ddd5eadeffdf9568abd37917e68b64c28e","original_commit_id":"0fa989ddd5eadeffdf9568abd37917e68b64c28e","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?","gravatar_id":"a2b625f331361a7110da59a907d79e95","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"I think this is fixing a bug where we could have sometimes a '|' starting the string :)","created_at":"2014-04-07T15:17:50Z","updated_at":"2014-04-07T15:17:50Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/16983#discussion_r11348233","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/16983","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/11348233"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/16983#discussion_r11348233"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/16983"}}}}