GitHub PullRequestReviewCommentEvent at 2014-09-17 17:10:38
Repository: juju-gui
Actor: jaycee
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/17678066","id":17678066,"diff_hunk":"@@ -1322,7 +1322,14 @@ YUI.add('juju-models', function(Y) {\n           break;\n         case 'name':\n           sortMethod = function(model) {\n-            return model.displayName;\n+            var name = model.displayName;\n+            var nameAsNumber = parseInt(name, 10);\n+            // Check that the name is a number by checking that the\n+            // parsed value matches the name.\n+            var isNumber = nameAsNumber.toString() === name;","path":"app/models/models.js","position":9,"original_position":9,"commit_id":"2965a81886ed6ed9cf93c10e483be562a924f4fc","original_commit_id":"2965a81886ed6ed9cf93c10e483be562a924f4fc","user":{"login":"jaycee","id":26728,"avatar_url":"https://avatars.githubusercontent.com/u/26728?v=2","gravatar_id":"556f338e5fb1bbf6a502cce979609942","url":"https://api.github.com/users/jaycee","html_url":"https://github.com/jaycee","followers_url":"https://api.github.com/users/jaycee/followers","following_url":"https://api.github.com/users/jaycee/following{/other_user}","gists_url":"https://api.github.com/users/jaycee/gists{/gist_id}","starred_url":"https://api.github.com/users/jaycee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaycee/subscriptions","organizations_url":"https://api.github.com/users/jaycee/orgs","repos_url":"https://api.github.com/users/jaycee/repos","events_url":"https://api.github.com/users/jaycee/events{/privacy}","received_events_url":"https://api.github.com/users/jaycee/received_events","type":"User","site_admin":false},"body":"+1 for this refactor.","created_at":"2014-09-17T17:10:38Z","updated_at":"2014-09-17T17:10:38Z","html_url":"https://github.com/juju/juju-gui/pull/562#discussion_r17678066","pull_request_url":"https://api.github.com/repos/juju/juju-gui/pulls/562","_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/17678066"},"html":{"href":"https://github.com/juju/juju-gui/pull/562#discussion_r17678066"},"pull_request":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/562"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/562","id":21348312,"html_url":"https://github.com/juju/juju-gui/pull/562","diff_url":"https://github.com/juju/juju-gui/pull/562.diff","patch_url":"https://github.com/juju/juju-gui/pull/562.patch","issue_url":"https://api.github.com/repos/juju/juju-gui/issues/562","number":562,"state":"open","locked":false,"title":"Sort names by number","user":{"login":"huwshimi","id":361637,"avatar_url":"https://avatars.githubusercontent.com/u/361637?v=2","gravatar_id":"998b7ee9b24b868cab42c48163f133e9","url":"https://api.github.com/users/huwshimi","html_url":"https://github.com/huwshimi","followers_url":"https://api.github.com/users/huwshimi/followers","following_url":"https://api.github.com/users/huwshimi/following{/other_user}","gists_url":"https://api.github.com/users/huwshimi/gists{/gist_id}","starred_url":"https://api.github.com/users/huwshimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwshimi/subscriptions","organizations_url":"https://api.github.com/users/huwshimi/orgs","repos_url":"https://api.github.com/users/huwshimi/repos","events_url":"https://api.github.com/users/huwshimi/events{/privacy}","received_events_url":"https://api.github.com/users/huwshimi/received_events","type":"User","site_admin":false},"body":"Fixes bug #1369794: if machine names are numbers then sort them as numbers.","created_at":"2014-09-17T07:05:40Z","updated_at":"2014-09-17T17:10:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5267f95fb89db65b0f898f0118832eb1226a9a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju-gui/pulls/562/commits","review_comments_url":"https://api.github.com/repos/juju/juju-gui/pulls/562/comments","review_comment_url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju-gui/issues/562/comments","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/2965a81886ed6ed9cf93c10e483be562a924f4fc","head":{"label":"huwshimi:sort-numbers","ref":"sort-numbers","sha":"2965a81886ed6ed9cf93c10e483be562a924f4fc","user":{"login":"huwshimi","id":361637,"avatar_url":"https://avatars.githubusercontent.com/u/361637?v=2","gravatar_id":"998b7ee9b24b868cab42c48163f133e9","url":"https://api.github.com/users/huwshimi","html_url":"https://github.com/huwshimi","followers_url":"https://api.github.com/users/huwshimi/followers","following_url":"https://api.github.com/users/huwshimi/following{/other_user}","gists_url":"https://api.github.com/users/huwshimi/gists{/gist_id}","starred_url":"https://api.github.com/users/huwshimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwshimi/subscriptions","organizations_url":"https://api.github.com/users/huwshimi/orgs","repos_url":"https://api.github.com/users/huwshimi/repos","events_url":"https://api.github.com/users/huwshimi/events{/privacy}","received_events_url":"https://api.github.com/users/huwshimi/received_events","type":"User","site_admin":false},"repo":{"id":15032585,"name":"juju-gui","full_name":"huwshimi/juju-gui","owner":{"login":"huwshimi","id":361637,"avatar_url":"https://avatars.githubusercontent.com/u/361637?v=2","gravatar_id":"998b7ee9b24b868cab42c48163f133e9","url":"https://api.github.com/users/huwshimi","html_url":"https://github.com/huwshimi","followers_url":"https://api.github.com/users/huwshimi/followers","following_url":"https://api.github.com/users/huwshimi/following{/other_user}","gists_url":"https://api.github.com/users/huwshimi/gists{/gist_id}","starred_url":"https://api.github.com/users/huwshimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwshimi/subscriptions","organizations_url":"https://api.github.com/users/huwshimi/orgs","repos_url":"https://api.github.com/users/huwshimi/repos","events_url":"https://api.github.com/users/huwshimi/events{/privacy}","received_events_url":"https://api.github.com/users/huwshimi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huwshimi/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":true,"url":"https://api.github.com/repos/huwshimi/juju-gui","forks_url":"https://api.github.com/repos/huwshimi/juju-gui/forks","keys_url":"https://api.github.com/repos/huwshimi/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huwshimi/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huwshimi/juju-gui/teams","hooks_url":"https://api.github.com/repos/huwshimi/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/huwshimi/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/huwshimi/juju-gui/events","assignees_url":"https://api.github.com/repos/huwshimi/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/huwshimi/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/huwshimi/juju-gui/tags","blobs_url":"https://api.github.com/repos/huwshimi/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huwshimi/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huwshimi/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/huwshimi/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huwshimi/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/huwshimi/juju-gui/languages","stargazers_url":"https://api.github.com/repos/huwshimi/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/huwshimi/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/huwshimi/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/huwshimi/juju-gui/subscription","commits_url":"https://api.github.com/repos/huwshimi/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/huwshimi/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/huwshimi/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/huwshimi/juju-gui/issues/comments/{number}","contents_url":"https://api.github.com/repos/huwshimi/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/huwshimi/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huwshimi/juju-gui/merges","archive_url":"https://api.github.com/repos/huwshimi/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huwshimi/juju-gui/downloads","issues_url":"https://api.github.com/repos/huwshimi/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/huwshimi/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/huwshimi/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/huwshimi/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huwshimi/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/huwshimi/juju-gui/releases{/id}","created_at":"2013-12-08T22:20:08Z","updated_at":"2014-06-25T06:57:23Z","pushed_at":"2014-09-17T07:03:59Z","git_url":"git://github.com/huwshimi/juju-gui.git","ssh_url":"git@github.com:huwshimi/juju-gui.git","clone_url":"https://github.com/huwshimi/juju-gui.git","svn_url":"https://github.com/huwshimi/juju-gui","homepage":null,"size":103083,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:develop","ref":"develop","sha":"00c59e7520427176f342e0e0f9150742323eadee","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":14960387,"name":"juju-gui","full_name":"juju/juju-gui","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":false,"url":"https://api.github.com/repos/juju/juju-gui","forks_url":"https://api.github.com/repos/juju/juju-gui/forks","keys_url":"https://api.github.com/repos/juju/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju-gui/teams","hooks_url":"https://api.github.com/repos/juju/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/juju/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju-gui/events","assignees_url":"https://api.github.com/repos/juju/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju-gui/tags","blobs_url":"https://api.github.com/repos/juju/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju-gui/languages","stargazers_url":"https://api.github.com/repos/juju/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/juju/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/juju/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/juju/juju-gui/subscription","commits_url":"https://api.github.com/repos/juju/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju-gui/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju-gui/merges","archive_url":"https://api.github.com/repos/juju/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju-gui/downloads","issues_url":"https://api.github.com/repos/juju/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju-gui/releases{/id}","created_at":"2013-12-05T17:15:48Z","updated_at":"2014-09-09T21:34:14Z","pushed_at":"2014-09-17T17:00:26Z","git_url":"git://github.com/juju/juju-gui.git","ssh_url":"git@github.com:juju/juju-gui.git","clone_url":"https://github.com/juju/juju-gui.git","svn_url":"https://github.com/juju/juju-gui","homepage":null,"size":111302,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":3,"forks":32,"open_issues":3,"watchers":33,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/562"},"html":{"href":"https://github.com/juju/juju-gui/pull/562"},"issue":{"href":"https://api.github.com/repos/juju/juju-gui/issues/562"},"comments":{"href":"https://api.github.com/repos/juju/juju-gui/issues/562/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/562/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/562/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju-gui/statuses/2965a81886ed6ed9cf93c10e483be562a924f4fc"}}}}