GitHub PullRequestEvent at 2014-05-31 16:19:09
Repository: qtile
Actor: tych0
Payload: {"action":"closed","number":423,"pull_request":{"url":"https://api.github.com/repos/qtile/qtile/pulls/423","id":16067642,"html_url":"https://github.com/qtile/qtile/pull/423","diff_url":"https://github.com/qtile/qtile/pull/423.diff","patch_url":"https://github.com/qtile/qtile/pull/423.patch","issue_url":"https://api.github.com/repos/qtile/qtile/issues/423","number":423,"state":"closed","title":"Fix #421","user":{"login":"ramnes","id":835072,"avatar_url":"https://avatars.githubusercontent.com/u/835072?","gravatar_id":"5c5270be33ce1dc04ec2047f972b2ea7","url":"https://api.github.com/users/ramnes","html_url":"https://github.com/ramnes","followers_url":"https://api.github.com/users/ramnes/followers","following_url":"https://api.github.com/users/ramnes/following{/other_user}","gists_url":"https://api.github.com/users/ramnes/gists{/gist_id}","starred_url":"https://api.github.com/users/ramnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramnes/subscriptions","organizations_url":"https://api.github.com/users/ramnes/orgs","repos_url":"https://api.github.com/users/ramnes/repos","events_url":"https://api.github.com/users/ramnes/events{/privacy}","received_events_url":"https://api.github.com/users/ramnes/received_events","type":"User","site_admin":false},"body":"Fix #421 by always putting floating windows above the Max layout (that already put windows above).\r\n\r\nThe problem with this is that it does not respect floating windows z-order if modified (the order will always stay the same, by order of floating window appearance). I think it does not matter that much since I don't see any other usage of floating windows in Max mode other than for dialogs.\r\n\r\nA better way would be to make the `above` parameter for `window.place()` acting only for current layout, or having a way to handle z-index between layouts (i.e. floating layout have is own z-index but each one of its windows will always be above the current layout), but it seems to me that it would require a lot of work on top of XCB.\r\n","created_at":"2014-05-19T18:04:44Z","updated_at":"2014-05-31T16:19:09Z","closed_at":"2014-05-31T16:19:09Z","merged_at":null,"merge_commit_sha":"e9ee49b3b00b96bd45ac34f69b9c1f9a65368254","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qtile/qtile/pulls/423/commits","review_comments_url":"https://api.github.com/repos/qtile/qtile/pulls/423/comments","review_comment_url":"https://api.github.com/repos/qtile/qtile/pulls/comments/{number}","comments_url":"https://api.github.com/repos/qtile/qtile/issues/423/comments","statuses_url":"https://api.github.com/repos/qtile/qtile/statuses/18066fb2ff8ab226978c74f97d260881d030760e","head":{"label":"ramnes:fix-421","ref":"fix-421","sha":"18066fb2ff8ab226978c74f97d260881d030760e","user":{"login":"ramnes","id":835072,"avatar_url":"https://avatars.githubusercontent.com/u/835072?","gravatar_id":"5c5270be33ce1dc04ec2047f972b2ea7","url":"https://api.github.com/users/ramnes","html_url":"https://github.com/ramnes","followers_url":"https://api.github.com/users/ramnes/followers","following_url":"https://api.github.com/users/ramnes/following{/other_user}","gists_url":"https://api.github.com/users/ramnes/gists{/gist_id}","starred_url":"https://api.github.com/users/ramnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramnes/subscriptions","organizations_url":"https://api.github.com/users/ramnes/orgs","repos_url":"https://api.github.com/users/ramnes/repos","events_url":"https://api.github.com/users/ramnes/events{/privacy}","received_events_url":"https://api.github.com/users/ramnes/received_events","type":"User","site_admin":false},"repo":{"id":17609312,"name":"qtile","full_name":"ramnes/qtile","owner":{"login":"ramnes","id":835072,"avatar_url":"https://avatars.githubusercontent.com/u/835072?","gravatar_id":"5c5270be33ce1dc04ec2047f972b2ea7","url":"https://api.github.com/users/ramnes","html_url":"https://github.com/ramnes","followers_url":"https://api.github.com/users/ramnes/followers","following_url":"https://api.github.com/users/ramnes/following{/other_user}","gists_url":"https://api.github.com/users/ramnes/gists{/gist_id}","starred_url":"https://api.github.com/users/ramnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramnes/subscriptions","organizations_url":"https://api.github.com/users/ramnes/orgs","repos_url":"https://api.github.com/users/ramnes/repos","events_url":"https://api.github.com/users/ramnes/events{/privacy}","received_events_url":"https://api.github.com/users/ramnes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramnes/qtile","description":"A small, flexible, scriptable tiling window manager written in Python","fork":true,"url":"https://api.github.com/repos/ramnes/qtile","forks_url":"https://api.github.com/repos/ramnes/qtile/forks","keys_url":"https://api.github.com/repos/ramnes/qtile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramnes/qtile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramnes/qtile/teams","hooks_url":"https://api.github.com/repos/ramnes/qtile/hooks","issue_events_url":"https://api.github.com/repos/ramnes/qtile/issues/events{/number}","events_url":"https://api.github.com/repos/ramnes/qtile/events","assignees_url":"https://api.github.com/repos/ramnes/qtile/assignees{/user}","branches_url":"https://api.github.com/repos/ramnes/qtile/branches{/branch}","tags_url":"https://api.github.com/repos/ramnes/qtile/tags","blobs_url":"https://api.github.com/repos/ramnes/qtile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramnes/qtile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramnes/qtile/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramnes/qtile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramnes/qtile/statuses/{sha}","languages_url":"https://api.github.com/repos/ramnes/qtile/languages","stargazers_url":"https://api.github.com/repos/ramnes/qtile/stargazers","contributors_url":"https://api.github.com/repos/ramnes/qtile/contributors","subscribers_url":"https://api.github.com/repos/ramnes/qtile/subscribers","subscription_url":"https://api.github.com/repos/ramnes/qtile/subscription","commits_url":"https://api.github.com/repos/ramnes/qtile/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramnes/qtile/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramnes/qtile/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramnes/qtile/issues/comments/{number}","contents_url":"https://api.github.com/repos/ramnes/qtile/contents/{+path}","compare_url":"https://api.github.com/repos/ramnes/qtile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramnes/qtile/merges","archive_url":"https://api.github.com/repos/ramnes/qtile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramnes/qtile/downloads","issues_url":"https://api.github.com/repos/ramnes/qtile/issues{/number}","pulls_url":"https://api.github.com/repos/ramnes/qtile/pulls{/number}","milestones_url":"https://api.github.com/repos/ramnes/qtile/milestones{/number}","notifications_url":"https://api.github.com/repos/ramnes/qtile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramnes/qtile/labels{/name}","releases_url":"https://api.github.com/repos/ramnes/qtile/releases{/id}","created_at":"2014-03-10T21:32:13Z","updated_at":"2014-05-31T16:19:09Z","pushed_at":"2014-05-19T17:48:20Z","git_url":"git://github.com/ramnes/qtile.git","ssh_url":"git@github.com:ramnes/qtile.git","clone_url":"https://github.com/ramnes/qtile.git","svn_url":"https://github.com/ramnes/qtile","homepage":"http://qtile.org","size":4923,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"qtile:develop","ref":"develop","sha":"0fc5ee9d1934e822a0be2acd8b0fb5e16923c441","user":{"login":"qtile","id":1424964,"avatar_url":"https://avatars.githubusercontent.com/u/1424964?","gravatar_id":"1d04f588beef8890097527e2ba1311d3","url":"https://api.github.com/users/qtile","html_url":"https://github.com/qtile","followers_url":"https://api.github.com/users/qtile/followers","following_url":"https://api.github.com/users/qtile/following{/other_user}","gists_url":"https://api.github.com/users/qtile/gists{/gist_id}","starred_url":"https://api.github.com/users/qtile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qtile/subscriptions","organizations_url":"https://api.github.com/users/qtile/orgs","repos_url":"https://api.github.com/users/qtile/repos","events_url":"https://api.github.com/users/qtile/events{/privacy}","received_events_url":"https://api.github.com/users/qtile/received_events","type":"Organization","site_admin":false},"repo":{"id":47476,"name":"qtile","full_name":"qtile/qtile","owner":{"login":"qtile","id":1424964,"avatar_url":"https://avatars.githubusercontent.com/u/1424964?","gravatar_id":"1d04f588beef8890097527e2ba1311d3","url":"https://api.github.com/users/qtile","html_url":"https://github.com/qtile","followers_url":"https://api.github.com/users/qtile/followers","following_url":"https://api.github.com/users/qtile/following{/other_user}","gists_url":"https://api.github.com/users/qtile/gists{/gist_id}","starred_url":"https://api.github.com/users/qtile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qtile/subscriptions","organizations_url":"https://api.github.com/users/qtile/orgs","repos_url":"https://api.github.com/users/qtile/repos","events_url":"https://api.github.com/users/qtile/events{/privacy}","received_events_url":"https://api.github.com/users/qtile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qtile/qtile","description":"A small, flexible, scriptable tiling window manager written in Python","fork":false,"url":"https://api.github.com/repos/qtile/qtile","forks_url":"https://api.github.com/repos/qtile/qtile/forks","keys_url":"https://api.github.com/repos/qtile/qtile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qtile/qtile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qtile/qtile/teams","hooks_url":"https://api.github.com/repos/qtile/qtile/hooks","issue_events_url":"https://api.github.com/repos/qtile/qtile/issues/events{/number}","events_url":"https://api.github.com/repos/qtile/qtile/events","assignees_url":"https://api.github.com/repos/qtile/qtile/assignees{/user}","branches_url":"https://api.github.com/repos/qtile/qtile/branches{/branch}","tags_url":"https://api.github.com/repos/qtile/qtile/tags","blobs_url":"https://api.github.com/repos/qtile/qtile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qtile/qtile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qtile/qtile/git/refs{/sha}","trees_url":"https://api.github.com/repos/qtile/qtile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qtile/qtile/statuses/{sha}","languages_url":"https://api.github.com/repos/qtile/qtile/languages","stargazers_url":"https://api.github.com/repos/qtile/qtile/stargazers","contributors_url":"https://api.github.com/repos/qtile/qtile/contributors","subscribers_url":"https://api.github.com/repos/qtile/qtile/subscribers","subscription_url":"https://api.github.com/repos/qtile/qtile/subscription","commits_url":"https://api.github.com/repos/qtile/qtile/commits{/sha}","git_commits_url":"https://api.github.com/repos/qtile/qtile/git/commits{/sha}","comments_url":"https://api.github.com/repos/qtile/qtile/comments{/number}","issue_comment_url":"https://api.github.com/repos/qtile/qtile/issues/comments/{number}","contents_url":"https://api.github.com/repos/qtile/qtile/contents/{+path}","compare_url":"https://api.github.com/repos/qtile/qtile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qtile/qtile/merges","archive_url":"https://api.github.com/repos/qtile/qtile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qtile/qtile/downloads","issues_url":"https://api.github.com/repos/qtile/qtile/issues{/number}","pulls_url":"https://api.github.com/repos/qtile/qtile/pulls{/number}","milestones_url":"https://api.github.com/repos/qtile/qtile/milestones{/number}","notifications_url":"https://api.github.com/repos/qtile/qtile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qtile/qtile/labels{/name}","releases_url":"https://api.github.com/repos/qtile/qtile/releases{/id}","created_at":"2008-08-30T00:16:40Z","updated_at":"2014-05-31T16:19:06Z","pushed_at":"2014-05-31T16:19:09Z","git_url":"git://github.com/qtile/qtile.git","ssh_url":"git@github.com:qtile/qtile.git","clone_url":"https://github.com/qtile/qtile.git","svn_url":"https://github.com/qtile/qtile","homepage":"http://qtile.org","size":8394,"stargazers_count":536,"watchers_count":536,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":152,"mirror_url":null,"open_issues_count":44,"forks":152,"open_issues":44,"watchers":536,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/qtile/qtile/pulls/423"},"html":{"href":"https://github.com/qtile/qtile/pull/423"},"issue":{"href":"https://api.github.com/repos/qtile/qtile/issues/423"},"comments":{"href":"https://api.github.com/repos/qtile/qtile/issues/423/comments"},"review_comments":{"href":"https://api.github.com/repos/qtile/qtile/pulls/423/comments"},"review_comment":{"href":"https://api.github.com/repos/qtile/qtile/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/qtile/qtile/pulls/423/commits"},"statuses":{"href":"https://api.github.com/repos/qtile/qtile/statuses/18066fb2ff8ab226978c74f97d260881d030760e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":2,"deletions":2,"changed_files":2}}