GitHub PullRequestReviewCommentEvent at 2014-11-01 15:42:37
Repository: mpc-hc
Actor: XhmikosR
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls/comments/19704941","id":19704941,"diff_hunk":"@@ -0,0 +1,175 @@\n+/*\r\n+* (C) 2009-2014 see Authors.txt\r\n+*\r\n+* This file is part of MPC-HC.\r\n+*\r\n+* MPC-HC is free software; you can redistribute it and/or modify\r\n+* it under the terms of the GNU General Public License as published by\r\n+* the Free Software Foundation; either version 3 of the License, or\r\n+* (at your option) any later version.\r\n+*\r\n+* MPC-HC is distributed in the hope that it will be useful,\r\n+* but WITHOUT ANY WARRANTY; without even the implied warranty of\r\n+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\r\n+* GNU General Public License for more details.\r\n+*\r\n+* You should have received a copy of the GNU General Public License\r\n+* along with this program.  If not, see <http://www.gnu.org/licenses/>.\r\n+*\r\n+*/\r\n+\r\n+// ScanDlg.cpp : implementation file\r\n+//\r\n+\r\n+#include \"stdafx.h\"\r\n+#include \"TVToolsDlg.h\"\r\n+#include \"mplayerc.h\"\r\n+#include \"MainFrm.h\"\r\n+\r\n+// CTVToolsDlg dialog\r\n+\r\n+IMPLEMENT_DYNAMIC(CTVToolsDlg, CDialog)\r\n+\r\n+CTVToolsDlg::CTVToolsDlg(CWnd* pParent /*=nullptr*/)\r\n+    : CDialog(CTVToolsDlg::IDD, pParent)\r\n+    , m_TunerScanDlg(this)\r\n+    , m_IPTVScanDlg(this)\r\n+{\r\n+\r\n+}\r\n+\r\n+CTVToolsDlg::~CTVToolsDlg()\r\n+{\r\n+\r","path":"src/mpc-hc/TVToolsDlg.cpp","position":43,"original_position":43,"commit_id":"97d8f4207e93fa388168e4b8af3d8c8a56c0d1c4","original_commit_id":"97d8f4207e93fa388168e4b8af3d8c8a56c0d1c4","user":{"login":"XhmikosR","id":349621,"avatar_url":"https://avatars.githubusercontent.com/u/349621?v=2","gravatar_id":"","url":"https://api.github.com/users/XhmikosR","html_url":"https://github.com/XhmikosR","followers_url":"https://api.github.com/users/XhmikosR/followers","following_url":"https://api.github.com/users/XhmikosR/following{/other_user}","gists_url":"https://api.github.com/users/XhmikosR/gists{/gist_id}","starred_url":"https://api.github.com/users/XhmikosR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XhmikosR/subscriptions","organizations_url":"https://api.github.com/users/XhmikosR/orgs","repos_url":"https://api.github.com/users/XhmikosR/repos","events_url":"https://api.github.com/users/XhmikosR/events{/privacy}","received_events_url":"https://api.github.com/users/XhmikosR/received_events","type":"User","site_admin":false},"body":"I'd remove this empty line(s) in the ctor/dtor case.","created_at":"2014-11-01T15:42:37Z","updated_at":"2014-11-01T15:42:37Z","html_url":"https://github.com/mpc-hc/mpc-hc/pull/145#discussion_r19704941","pull_request_url":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls/145","_links":{"self":{"href":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls/comments/19704941"},"html":{"href":"https://github.com/mpc-hc/mpc-hc/pull/145#discussion_r19704941"},"pull_request":{"href":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls/145","id":23720558,"html_url":"https://github.com/mpc-hc/mpc-hc/pull/145","diff_url":"https://github.com/mpc-hc/mpc-hc/pull/145.diff","patch_url":"https://github.com/mpc-hc/mpc-hc/pull/145.patch","issue_url":"https://api.github.com/repos/mpc-hc/mpc-hc/issues/145","number":145,"state":"open","locked":false,"title":"Add IPTV capabilities to the existing Digital TV UI","user":{"login":"xpc1000","id":2630585,"avatar_url":"https://avatars.githubusercontent.com/u/2630585?v=2","gravatar_id":"","url":"https://api.github.com/users/xpc1000","html_url":"https://github.com/xpc1000","followers_url":"https://api.github.com/users/xpc1000/followers","following_url":"https://api.github.com/users/xpc1000/following{/other_user}","gists_url":"https://api.github.com/users/xpc1000/gists{/gist_id}","starred_url":"https://api.github.com/users/xpc1000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpc1000/subscriptions","organizations_url":"https://api.github.com/users/xpc1000/orgs","repos_url":"https://api.github.com/users/xpc1000/repos","events_url":"https://api.github.com/users/xpc1000/events{/privacy}","received_events_url":"https://api.github.com/users/xpc1000/received_events","type":"User","site_admin":false},"body":"Extending the current interface for using it not only for DVB but also for IPTV.\r\n\r\nCommits:\r\n1- Add IPTV capabilities to the existing DVB UI\r\n- Basic IPTV capabilities\r\n- Navigation TV panel: tabbed filters for DVB-T, IPTV and Radio\r\n\r\n2- Digital TV: adapting the channel management UI for IPTV:\r\n- Channel Scan is now called Digital TV tools\r\n- UI: new tab for managing IPTV channels\r\n- IPTV: option for adding individual channels\r\n- IPTV: option for importing a m3u list of channels\r\n- New checkbox for removing existing channels when saving. Removes only the channels of the same type (DVB or IPTV)\r\n- Adding channels: new counter for preventing having duplicate prefNumber channels\r\n\r\n3- Digital TV: split options from analog capture and new Digital TV options\r\n\r\n3.1. General\r\n- Split menu entry into: Open Digital TV / Open Analog Capture. File->Open Device now only refers to analog device\r\n- Split class OpenDeviceData into OpenDeviceAnalogData and OpenDeviceDigitalData\r\n- Channel navigation panel: only enabled tabs visible (depending on Digital TV options). Set initial active tab depending on current channel type.\r\n- Add IGMP membership management: manage IGMP group join/leave for multicast IPTV streaming sources. Supports only IPv4 and IGMPv2. IPv6 and IGMPv3 could be added in the future if needed.\r\n- Add shortcut for Digital TV\r\n\r\n3.2. Exception handling:\r\n- error controls (checking devices, etc.) moved from the general entry point to each channel switch operation\r\n- Change current behavior: when error switching to a channel -> show error message in info bar and then stay ready for switching to another channel\r\n- If the IPTV switching channel operation fails, we don't change the window size\r\n\r\n3.3. Options & preferences:\r\n- Split Digital TV options from analog capture\r\n- New Digital TV options: DVB (BDA) and IPTV (include option: enable/disable IGMP multicast membership management)\r\n\r\n\r\nPending issues and known limitations:\r\n- ONLY English version: to be updated once it is ready for merge\r\n- IPTV Channel management: additional options (scan range of IP's and service discovery for multicast) are in progress and will be included in a different PR. \r\n- Access to channel management from options menu: will be also included in a future PR.","created_at":"2014-11-01T15:38:32Z","updated_at":"2014-11-01T15:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5333b970046f56d54bf5c570d5241f0c49cea14","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls/145/commits","review_comments_url":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls/145/comments","review_comment_url":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mpc-hc/mpc-hc/issues/145/comments","statuses_url":"https://api.github.com/repos/mpc-hc/mpc-hc/statuses/97d8f4207e93fa388168e4b8af3d8c8a56c0d1c4","head":{"label":"xpc1000:develop","ref":"develop","sha":"97d8f4207e93fa388168e4b8af3d8c8a56c0d1c4","user":{"login":"xpc1000","id":2630585,"avatar_url":"https://avatars.githubusercontent.com/u/2630585?v=2","gravatar_id":"","url":"https://api.github.com/users/xpc1000","html_url":"https://github.com/xpc1000","followers_url":"https://api.github.com/users/xpc1000/followers","following_url":"https://api.github.com/users/xpc1000/following{/other_user}","gists_url":"https://api.github.com/users/xpc1000/gists{/gist_id}","starred_url":"https://api.github.com/users/xpc1000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpc1000/subscriptions","organizations_url":"https://api.github.com/users/xpc1000/orgs","repos_url":"https://api.github.com/users/xpc1000/repos","events_url":"https://api.github.com/users/xpc1000/events{/privacy}","received_events_url":"https://api.github.com/users/xpc1000/received_events","type":"User","site_admin":false},"repo":{"id":25993010,"name":"mpc-hc","full_name":"xpc1000/mpc-hc","owner":{"login":"xpc1000","id":2630585,"avatar_url":"https://avatars.githubusercontent.com/u/2630585?v=2","gravatar_id":"","url":"https://api.github.com/users/xpc1000","html_url":"https://github.com/xpc1000","followers_url":"https://api.github.com/users/xpc1000/followers","following_url":"https://api.github.com/users/xpc1000/following{/other_user}","gists_url":"https://api.github.com/users/xpc1000/gists{/gist_id}","starred_url":"https://api.github.com/users/xpc1000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpc1000/subscriptions","organizations_url":"https://api.github.com/users/xpc1000/orgs","repos_url":"https://api.github.com/users/xpc1000/repos","events_url":"https://api.github.com/users/xpc1000/events{/privacy}","received_events_url":"https://api.github.com/users/xpc1000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xpc1000/mpc-hc","description":"MPC-HC's main repository.  For support use our Trac: https://trac.mpc-hc.org/","fork":true,"url":"https://api.github.com/repos/xpc1000/mpc-hc","forks_url":"https://api.github.com/repos/xpc1000/mpc-hc/forks","keys_url":"https://api.github.com/repos/xpc1000/mpc-hc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xpc1000/mpc-hc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xpc1000/mpc-hc/teams","hooks_url":"https://api.github.com/repos/xpc1000/mpc-hc/hooks","issue_events_url":"https://api.github.com/repos/xpc1000/mpc-hc/issues/events{/number}","events_url":"https://api.github.com/repos/xpc1000/mpc-hc/events","assignees_url":"https://api.github.com/repos/xpc1000/mpc-hc/assignees{/user}","branches_url":"https://api.github.com/repos/xpc1000/mpc-hc/branches{/branch}","tags_url":"https://api.github.com/repos/xpc1000/mpc-hc/tags","blobs_url":"https://api.github.com/repos/xpc1000/mpc-hc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xpc1000/mpc-hc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xpc1000/mpc-hc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xpc1000/mpc-hc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xpc1000/mpc-hc/statuses/{sha}","languages_url":"https://api.github.com/repos/xpc1000/mpc-hc/languages","stargazers_url":"https://api.github.com/repos/xpc1000/mpc-hc/stargazers","contributors_url":"https://api.github.com/repos/xpc1000/mpc-hc/contributors","subscribers_url":"https://api.github.com/repos/xpc1000/mpc-hc/subscribers","subscription_url":"https://api.github.com/repos/xpc1000/mpc-hc/subscription","commits_url":"https://api.github.com/repos/xpc1000/mpc-hc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xpc1000/mpc-hc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xpc1000/mpc-hc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xpc1000/mpc-hc/issues/comments/{number}","contents_url":"https://api.github.com/repos/xpc1000/mpc-hc/contents/{+path}","compare_url":"https://api.github.com/repos/xpc1000/mpc-hc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xpc1000/mpc-hc/merges","archive_url":"https://api.github.com/repos/xpc1000/mpc-hc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xpc1000/mpc-hc/downloads","issues_url":"https://api.github.com/repos/xpc1000/mpc-hc/issues{/number}","pulls_url":"https://api.github.com/repos/xpc1000/mpc-hc/pulls{/number}","milestones_url":"https://api.github.com/repos/xpc1000/mpc-hc/milestones{/number}","notifications_url":"https://api.github.com/repos/xpc1000/mpc-hc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xpc1000/mpc-hc/labels{/name}","releases_url":"https://api.github.com/repos/xpc1000/mpc-hc/releases{/id}","created_at":"2014-10-30T22:50:44Z","updated_at":"2014-10-30T23:00:36Z","pushed_at":"2014-10-30T23:08:35Z","git_url":"git://github.com/xpc1000/mpc-hc.git","ssh_url":"git@github.com:xpc1000/mpc-hc.git","clone_url":"https://github.com/xpc1000/mpc-hc.git","svn_url":"https://github.com/xpc1000/mpc-hc","homepage":"http://mpc-hc.org/","size":187512,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mpc-hc:develop","ref":"develop","sha":"e941b1c783fecd800a05871594cc99e23d5d420f","user":{"login":"mpc-hc","id":1625629,"avatar_url":"https://avatars.githubusercontent.com/u/1625629?v=2","gravatar_id":"","url":"https://api.github.com/users/mpc-hc","html_url":"https://github.com/mpc-hc","followers_url":"https://api.github.com/users/mpc-hc/followers","following_url":"https://api.github.com/users/mpc-hc/following{/other_user}","gists_url":"https://api.github.com/users/mpc-hc/gists{/gist_id}","starred_url":"https://api.github.com/users/mpc-hc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpc-hc/subscriptions","organizations_url":"https://api.github.com/users/mpc-hc/orgs","repos_url":"https://api.github.com/users/mpc-hc/repos","events_url":"https://api.github.com/users/mpc-hc/events{/privacy}","received_events_url":"https://api.github.com/users/mpc-hc/received_events","type":"Organization","site_admin":false},"repo":{"id":5180577,"name":"mpc-hc","full_name":"mpc-hc/mpc-hc","owner":{"login":"mpc-hc","id":1625629,"avatar_url":"https://avatars.githubusercontent.com/u/1625629?v=2","gravatar_id":"","url":"https://api.github.com/users/mpc-hc","html_url":"https://github.com/mpc-hc","followers_url":"https://api.github.com/users/mpc-hc/followers","following_url":"https://api.github.com/users/mpc-hc/following{/other_user}","gists_url":"https://api.github.com/users/mpc-hc/gists{/gist_id}","starred_url":"https://api.github.com/users/mpc-hc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpc-hc/subscriptions","organizations_url":"https://api.github.com/users/mpc-hc/orgs","repos_url":"https://api.github.com/users/mpc-hc/repos","events_url":"https://api.github.com/users/mpc-hc/events{/privacy}","received_events_url":"https://api.github.com/users/mpc-hc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mpc-hc/mpc-hc","description":"MPC-HC's main repository.  For support use our Trac: https://trac.mpc-hc.org/","fork":false,"url":"https://api.github.com/repos/mpc-hc/mpc-hc","forks_url":"https://api.github.com/repos/mpc-hc/mpc-hc/forks","keys_url":"https://api.github.com/repos/mpc-hc/mpc-hc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpc-hc/mpc-hc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpc-hc/mpc-hc/teams","hooks_url":"https://api.github.com/repos/mpc-hc/mpc-hc/hooks","issue_events_url":"https://api.github.com/repos/mpc-hc/mpc-hc/issues/events{/number}","events_url":"https://api.github.com/repos/mpc-hc/mpc-hc/events","assignees_url":"https://api.github.com/repos/mpc-hc/mpc-hc/assignees{/user}","branches_url":"https://api.github.com/repos/mpc-hc/mpc-hc/branches{/branch}","tags_url":"https://api.github.com/repos/mpc-hc/mpc-hc/tags","blobs_url":"https://api.github.com/repos/mpc-hc/mpc-hc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpc-hc/mpc-hc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpc-hc/mpc-hc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpc-hc/mpc-hc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpc-hc/mpc-hc/statuses/{sha}","languages_url":"https://api.github.com/repos/mpc-hc/mpc-hc/languages","stargazers_url":"https://api.github.com/repos/mpc-hc/mpc-hc/stargazers","contributors_url":"https://api.github.com/repos/mpc-hc/mpc-hc/contributors","subscribers_url":"https://api.github.com/repos/mpc-hc/mpc-hc/subscribers","subscription_url":"https://api.github.com/repos/mpc-hc/mpc-hc/subscription","commits_url":"https://api.github.com/repos/mpc-hc/mpc-hc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpc-hc/mpc-hc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpc-hc/mpc-hc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpc-hc/mpc-hc/issues/comments/{number}","contents_url":"https://api.github.com/repos/mpc-hc/mpc-hc/contents/{+path}","compare_url":"https://api.github.com/repos/mpc-hc/mpc-hc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpc-hc/mpc-hc/merges","archive_url":"https://api.github.com/repos/mpc-hc/mpc-hc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpc-hc/mpc-hc/downloads","issues_url":"https://api.github.com/repos/mpc-hc/mpc-hc/issues{/number}","pulls_url":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls{/number}","milestones_url":"https://api.github.com/repos/mpc-hc/mpc-hc/milestones{/number}","notifications_url":"https://api.github.com/repos/mpc-hc/mpc-hc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpc-hc/mpc-hc/labels{/name}","releases_url":"https://api.github.com/repos/mpc-hc/mpc-hc/releases{/id}","created_at":"2012-07-25T15:04:04Z","updated_at":"2014-10-27T11:40:06Z","pushed_at":"2014-10-30T22:18:20Z","git_url":"git://github.com/mpc-hc/mpc-hc.git","ssh_url":"git@github.com:mpc-hc/mpc-hc.git","clone_url":"https://github.com/mpc-hc/mpc-hc.git","svn_url":"https://github.com/mpc-hc/mpc-hc","homepage":"http://mpc-hc.org/","size":210421,"stargazers_count":475,"watchers_count":475,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":223,"mirror_url":null,"open_issues_count":10,"forks":223,"open_issues":10,"watchers":475,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls/145"},"html":{"href":"https://github.com/mpc-hc/mpc-hc/pull/145"},"issue":{"href":"https://api.github.com/repos/mpc-hc/mpc-hc/issues/145"},"comments":{"href":"https://api.github.com/repos/mpc-hc/mpc-hc/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mpc-hc/mpc-hc/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/mpc-hc/mpc-hc/statuses/97d8f4207e93fa388168e4b8af3d8c8a56c0d1c4"}}}}