GitHub PullRequestReviewCommentEvent at 2014-11-24 13:37:43
Repository: erlang-mas
Actor: elvisci
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls/comments/20789521","id":20789521,"diff_hunk":"@@ -44,47 +43,50 @@ send_result(Agents) ->\n %% ====================================================================\n %% Callbacks\n %% ====================================================================\n--spec init(term()) -> {ok,state()} |\n-                      {ok,state(),non_neg_integer()}.\n+-spec init(term()) -> {ok, state()} |\n+                      {ok, state(), non_neg_integer()}.\n init([Time, SP, Cf = #config{islands = Islands}]) ->\n-    timer:send_after(Time,theEnd),\n-    Pids = [spawn_link(mas_hybrid_island, start, [SP, Cf]) || _ <- lists:seq(1, Islands)],\n+    timer:send_after(Time, theEnd),\n+    Pids = [spawn_link(mas_hybrid_island, start, [SP, Cf])\n+            || _ <- lists:seq(1, Islands)],\n     mas_topology:start_link(self(), Islands, Cf#config.topology),\n-    mas_logger:start_link(Pids, Cf),\n+    mas_misc_util:initialize_subscriptions(Pids, Cf),\n     {ok,Pids}.\n \n--spec handle_call(term(),{pid(),term()},state()) -> {reply,term(),state()} |\n-                                                    {reply,term(),state(),hibernate | infinity | non_neg_integer()} |\n-                                                    {noreply,state()} |\n-                                                    {noreply,state(),hibernate | infinity | non_neg_integer()} |\n-                                                    {stop,term(),term(),state()} |\n-                                                    {stop,term(),state()}.\n-handle_call(_,_,State) ->\n-    {noreply,State}.\n+-spec handle_call(term(),{pid(),term()},state()) ->\n+                         {reply,term(),state()} |\n+                         {reply,term(),state(),hibernate | infinity | non_neg_integer()} |\n+                         {noreply,state()} |\n+                         {noreply,state(),hibernate | infinity | non_neg_integer()} |","path":"src/hybrid/mas_hybrid.erl","position":39,"original_position":39,"commit_id":"adfdc8a6186320689c8ddba29c998a1cce6e3cf3","original_commit_id":"adfdc8a6186320689c8ddba29c998a1cce6e3cf3","user":{"login":"elvisci","id":8136322,"avatar_url":"https://avatars.githubusercontent.com/u/8136322?v=3","gravatar_id":"","url":"https://api.github.com/users/elvisci","html_url":"https://github.com/elvisci","followers_url":"https://api.github.com/users/elvisci/followers","following_url":"https://api.github.com/users/elvisci/following{/other_user}","gists_url":"https://api.github.com/users/elvisci/gists{/gist_id}","starred_url":"https://api.github.com/users/elvisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elvisci/subscriptions","organizations_url":"https://api.github.com/users/elvisci/orgs","repos_url":"https://api.github.com/users/elvisci/repos","events_url":"https://api.github.com/users/elvisci/events{/privacy}","received_events_url":"https://api.github.com/users/elvisci/received_events","type":"User","site_admin":false},"body":"Line 60 is too long: \"                         {noreply,state(),hibernate | infinity | non_neg_integer()} |\".","created_at":"2014-11-24T13:37:43Z","updated_at":"2014-11-24T13:37:43Z","html_url":"https://github.com/ParaPhraseAGH/erlang-mas/pull/6#discussion_r20789521","pull_request_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls/comments/20789521"},"html":{"href":"https://github.com/ParaPhraseAGH/erlang-mas/pull/6#discussion_r20789521"},"pull_request":{"href":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls/6","id":24758950,"html_url":"https://github.com/ParaPhraseAGH/erlang-mas/pull/6","diff_url":"https://github.com/ParaPhraseAGH/erlang-mas/pull/6.diff","patch_url":"https://github.com/ParaPhraseAGH/erlang-mas/pull/6.patch","issue_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/issues/6","number":6,"state":"open","locked":false,"title":"Introducing Exometer","user":{"login":"jstypka","id":4479536,"avatar_url":"https://avatars.githubusercontent.com/u/4479536?v=3","gravatar_id":"","url":"https://api.github.com/users/jstypka","html_url":"https://github.com/jstypka","followers_url":"https://api.github.com/users/jstypka/followers","following_url":"https://api.github.com/users/jstypka/following{/other_user}","gists_url":"https://api.github.com/users/jstypka/gists{/gist_id}","starred_url":"https://api.github.com/users/jstypka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstypka/subscriptions","organizations_url":"https://api.github.com/users/jstypka/orgs","repos_url":"https://api.github.com/users/jstypka/repos","events_url":"https://api.github.com/users/jstypka/events{/privacy}","received_events_url":"https://api.github.com/users/jstypka/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-20T11:37:26Z","updated_at":"2014-11-24T13:37:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c88553089adb786f090d8c4ed75df3e5bf63ef7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls/6/commits","review_comments_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls/6/comments","review_comment_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/issues/6/comments","statuses_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/statuses/adfdc8a6186320689c8ddba29c998a1cce6e3cf3","head":{"label":"ParaPhraseAGH:exometer","ref":"exometer","sha":"adfdc8a6186320689c8ddba29c998a1cce6e3cf3","user":{"login":"ParaPhraseAGH","id":6986868,"avatar_url":"https://avatars.githubusercontent.com/u/6986868?v=3","gravatar_id":"","url":"https://api.github.com/users/ParaPhraseAGH","html_url":"https://github.com/ParaPhraseAGH","followers_url":"https://api.github.com/users/ParaPhraseAGH/followers","following_url":"https://api.github.com/users/ParaPhraseAGH/following{/other_user}","gists_url":"https://api.github.com/users/ParaPhraseAGH/gists{/gist_id}","starred_url":"https://api.github.com/users/ParaPhraseAGH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParaPhraseAGH/subscriptions","organizations_url":"https://api.github.com/users/ParaPhraseAGH/orgs","repos_url":"https://api.github.com/users/ParaPhraseAGH/repos","events_url":"https://api.github.com/users/ParaPhraseAGH/events{/privacy}","received_events_url":"https://api.github.com/users/ParaPhraseAGH/received_events","type":"Organization","site_admin":false},"repo":{"id":25352851,"name":"erlang-mas","full_name":"ParaPhraseAGH/erlang-mas","owner":{"login":"ParaPhraseAGH","id":6986868,"avatar_url":"https://avatars.githubusercontent.com/u/6986868?v=3","gravatar_id":"","url":"https://api.github.com/users/ParaPhraseAGH","html_url":"https://github.com/ParaPhraseAGH","followers_url":"https://api.github.com/users/ParaPhraseAGH/followers","following_url":"https://api.github.com/users/ParaPhraseAGH/following{/other_user}","gists_url":"https://api.github.com/users/ParaPhraseAGH/gists{/gist_id}","starred_url":"https://api.github.com/users/ParaPhraseAGH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParaPhraseAGH/subscriptions","organizations_url":"https://api.github.com/users/ParaPhraseAGH/orgs","repos_url":"https://api.github.com/users/ParaPhraseAGH/repos","events_url":"https://api.github.com/users/ParaPhraseAGH/events{/privacy}","received_events_url":"https://api.github.com/users/ParaPhraseAGH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParaPhraseAGH/erlang-mas","description":"Multi agent system","fork":false,"url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas","forks_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/forks","keys_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/teams","hooks_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/hooks","issue_events_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/issues/events{/number}","events_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/events","assignees_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/assignees{/user}","branches_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/branches{/branch}","tags_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/tags","blobs_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/statuses/{sha}","languages_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/languages","stargazers_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/stargazers","contributors_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/contributors","subscribers_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/subscribers","subscription_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/subscription","commits_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/issues/comments/{number}","contents_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/contents/{+path}","compare_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/merges","archive_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/downloads","issues_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/issues{/number}","pulls_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls{/number}","milestones_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/milestones{/number}","notifications_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/labels{/name}","releases_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/releases{/id}","created_at":"2014-10-17T10:33:43Z","updated_at":"2014-11-18T12:27:29Z","pushed_at":"2014-11-24T13:37:41Z","git_url":"git://github.com/ParaPhraseAGH/erlang-mas.git","ssh_url":"git@github.com:ParaPhraseAGH/erlang-mas.git","clone_url":"https://github.com/ParaPhraseAGH/erlang-mas.git","svn_url":"https://github.com/ParaPhraseAGH/erlang-mas","homepage":"http://paraphraseagh.github.io/","size":7468,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ParaPhraseAGH:master","ref":"master","sha":"af6ef4c2b72d8352cc1ea122e7fa15ead629f325","user":{"login":"ParaPhraseAGH","id":6986868,"avatar_url":"https://avatars.githubusercontent.com/u/6986868?v=3","gravatar_id":"","url":"https://api.github.com/users/ParaPhraseAGH","html_url":"https://github.com/ParaPhraseAGH","followers_url":"https://api.github.com/users/ParaPhraseAGH/followers","following_url":"https://api.github.com/users/ParaPhraseAGH/following{/other_user}","gists_url":"https://api.github.com/users/ParaPhraseAGH/gists{/gist_id}","starred_url":"https://api.github.com/users/ParaPhraseAGH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParaPhraseAGH/subscriptions","organizations_url":"https://api.github.com/users/ParaPhraseAGH/orgs","repos_url":"https://api.github.com/users/ParaPhraseAGH/repos","events_url":"https://api.github.com/users/ParaPhraseAGH/events{/privacy}","received_events_url":"https://api.github.com/users/ParaPhraseAGH/received_events","type":"Organization","site_admin":false},"repo":{"id":25352851,"name":"erlang-mas","full_name":"ParaPhraseAGH/erlang-mas","owner":{"login":"ParaPhraseAGH","id":6986868,"avatar_url":"https://avatars.githubusercontent.com/u/6986868?v=3","gravatar_id":"","url":"https://api.github.com/users/ParaPhraseAGH","html_url":"https://github.com/ParaPhraseAGH","followers_url":"https://api.github.com/users/ParaPhraseAGH/followers","following_url":"https://api.github.com/users/ParaPhraseAGH/following{/other_user}","gists_url":"https://api.github.com/users/ParaPhraseAGH/gists{/gist_id}","starred_url":"https://api.github.com/users/ParaPhraseAGH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParaPhraseAGH/subscriptions","organizations_url":"https://api.github.com/users/ParaPhraseAGH/orgs","repos_url":"https://api.github.com/users/ParaPhraseAGH/repos","events_url":"https://api.github.com/users/ParaPhraseAGH/events{/privacy}","received_events_url":"https://api.github.com/users/ParaPhraseAGH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParaPhraseAGH/erlang-mas","description":"Multi agent system","fork":false,"url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas","forks_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/forks","keys_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/teams","hooks_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/hooks","issue_events_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/issues/events{/number}","events_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/events","assignees_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/assignees{/user}","branches_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/branches{/branch}","tags_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/tags","blobs_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/statuses/{sha}","languages_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/languages","stargazers_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/stargazers","contributors_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/contributors","subscribers_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/subscribers","subscription_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/subscription","commits_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/issues/comments/{number}","contents_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/contents/{+path}","compare_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/merges","archive_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/downloads","issues_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/issues{/number}","pulls_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls{/number}","milestones_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/milestones{/number}","notifications_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/labels{/name}","releases_url":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/releases{/id}","created_at":"2014-10-17T10:33:43Z","updated_at":"2014-11-18T12:27:29Z","pushed_at":"2014-11-24T13:37:41Z","git_url":"git://github.com/ParaPhraseAGH/erlang-mas.git","ssh_url":"git@github.com:ParaPhraseAGH/erlang-mas.git","clone_url":"https://github.com/ParaPhraseAGH/erlang-mas.git","svn_url":"https://github.com/ParaPhraseAGH/erlang-mas","homepage":"http://paraphraseagh.github.io/","size":7468,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls/6"},"html":{"href":"https://github.com/ParaPhraseAGH/erlang-mas/pull/6"},"issue":{"href":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/issues/6"},"comments":{"href":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/ParaPhraseAGH/erlang-mas/statuses/adfdc8a6186320689c8ddba29c998a1cce6e3cf3"}}}}