GitHub PushEvent at 2014-05-25 03:26:19
Repository: rust
Actor: bors
Payload: {"shas":[["9698221f919a80f2a0810e17c8ee8e80da8cefeb","19e794c1bad8f0914a9eb04e9876660727aa8f3b@gmail.com","Paper over privacy issues with Deref by changing field names.\n\nTypes that implement Deref can cause weird error messages due to their\nprivate fields conflicting with a field of the type they deref to, e.g.,\npreviously\n\n    struct Foo { x: int }\n\n    let a: Arc<Foo> = ...;\n    println!(\"{}\", a.x);\n\nwould complain the the `x` field of `Arc` was private (since Arc has a\nprivate field called `x`) rather than just ignoring it.\n\nThis patch doesn't fix that issue, but does mean one would have to write\n`a._ptr` to hit the same error message, which seems far less\ncommon. (This patch `_`-prefixes all private fields of\n`Deref`-implementing types.)\n\ncc #12808","Huon Wilson",false],["bbb70cdd9cd982922cf7390459d53bde409699ae","3a2c29237f73c7cf88424b80e427b1884f346b35@rust-lang.org","auto merge of #14402 : huonw/rust/arc-field-rename, r=alexcrichton\n\nPaper over privacy issues with Deref by changing field names.\r\n\r\nTypes that implement Deref can cause weird error messages due to their\r\nprivate fields conflicting with a field of the type they deref to, e.g.,\r\npreviously\r\n\r\n    struct Foo { x: int }\r\n\r\n    let a: Arc<Foo> = ...;\r\n    println!(\"{}\", a.x);\r\n\r\nwould complain the the `x` field of `Arc` was private (since Arc has a\r\nprivate field called `x`) rather than just ignoring it.\r\n\r\nThis patch doesn't fix that issue, but does mean one would have to write\r\n`a._ptr` to hit the same error message, which seems far less\r\ncommon. (This patch `_`-prefixes all private fields of\r\n`Deref`-implementing types.)\r\n\r\ncc #12808","bors",false]],"size":2,"ref":"refs/heads/master","head":"bbb70cdd9cd982922cf7390459d53bde409699ae"}