GitHub PullRequestReviewCommentEvent at 2014-07-28 17:46:33
Repository: OpenWireless
Actor: sarciszewski
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/EFForg/OpenWireless/pulls/comments/15477852","id":15477852,"diff_hunk":"@@ -6,23 +6,35 @@ var ssidModule = (function() {\n   var ssidPassphraseError;\n   var genericError;\n   var submit;\n+  var dw;\n \n   var init = function() {\n     initializeFields();\n     initializeForm();\n   };\n \n+  var genPassword = function(){\n+    if (Diceware.wordlist.length < 1) {\n+      return setTimeout(function() { genPassword(); }, 100);","path":"app/js/ssid.js","position":13,"original_position":13,"commit_id":"bc1525e7c5252ec7ba756a47191f8ff83905a8ca","original_commit_id":"bf3f999a30d474431144d935f80b936e7d2641c1","user":{"login":"sarciszewski","id":3710836,"avatar_url":"https://avatars.githubusercontent.com/u/3710836?","gravatar_id":"13da8f0c8208dee1b1229df276f8781d","url":"https://api.github.com/users/sarciszewski","html_url":"https://github.com/sarciszewski","followers_url":"https://api.github.com/users/sarciszewski/followers","following_url":"https://api.github.com/users/sarciszewski/following{/other_user}","gists_url":"https://api.github.com/users/sarciszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/sarciszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarciszewski/subscriptions","organizations_url":"https://api.github.com/users/sarciszewski/orgs","repos_url":"https://api.github.com/users/sarciszewski/repos","events_url":"https://api.github.com/users/sarciszewski/events{/privacy}","received_events_url":"https://api.github.com/users/sarciszewski/received_events","type":"User","site_admin":false},"body":"Unfortunately, I have _never_ done event-driven programming in JS before. I'm probably going to screw it up if I try.","created_at":"2014-07-28T17:46:33Z","updated_at":"2014-07-28T17:46:33Z","html_url":"https://github.com/EFForg/OpenWireless/pull/195#discussion_r15477852","pull_request_url":"https://api.github.com/repos/EFForg/OpenWireless/pulls/195","_links":{"self":{"href":"https://api.github.com/repos/EFForg/OpenWireless/pulls/comments/15477852"},"html":{"href":"https://github.com/EFForg/OpenWireless/pull/195#discussion_r15477852"},"pull_request":{"href":"https://api.github.com/repos/EFForg/OpenWireless/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/EFForg/OpenWireless/pulls/195","id":18973654,"html_url":"https://github.com/EFForg/OpenWireless/pull/195","diff_url":"https://github.com/EFForg/OpenWireless/pull/195.diff","patch_url":"https://github.com/EFForg/OpenWireless/pull/195.patch","issue_url":"https://api.github.com/repos/EFForg/OpenWireless/issues/195","number":195,"state":"open","title":"Implement Diceware Passphrase Generator","user":{"login":"sarciszewski","id":3710836,"avatar_url":"https://avatars.githubusercontent.com/u/3710836?","gravatar_id":"13da8f0c8208dee1b1229df276f8781d","url":"https://api.github.com/users/sarciszewski","html_url":"https://github.com/sarciszewski","followers_url":"https://api.github.com/users/sarciszewski/followers","following_url":"https://api.github.com/users/sarciszewski/following{/other_user}","gists_url":"https://api.github.com/users/sarciszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/sarciszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarciszewski/subscriptions","organizations_url":"https://api.github.com/users/sarciszewski/orgs","repos_url":"https://api.github.com/users/sarciszewski/repos","events_url":"https://api.github.com/users/sarciszewski/events{/privacy}","received_events_url":"https://api.github.com/users/sarciszewski/received_events","type":"User","site_admin":false},"body":"Note: This is a first swing. I do not have the hardware necessary to test it properly at the moment.\r\n\r\nFixes #163 ","created_at":"2014-07-28T15:23:00Z","updated_at":"2014-07-28T17:46:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b8e83da9aa20f2c46a9d1f8bc1b9606f1448418","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EFForg/OpenWireless/pulls/195/commits","review_comments_url":"https://api.github.com/repos/EFForg/OpenWireless/pulls/195/comments","review_comment_url":"https://api.github.com/repos/EFForg/OpenWireless/pulls/comments/{number}","comments_url":"https://api.github.com/repos/EFForg/OpenWireless/issues/195/comments","statuses_url":"https://api.github.com/repos/EFForg/OpenWireless/statuses/bc1525e7c5252ec7ba756a47191f8ff83905a8ca","head":{"label":"sarciszewski:pwgen","ref":"pwgen","sha":"bc1525e7c5252ec7ba756a47191f8ff83905a8ca","user":{"login":"sarciszewski","id":3710836,"avatar_url":"https://avatars.githubusercontent.com/u/3710836?","gravatar_id":"13da8f0c8208dee1b1229df276f8781d","url":"https://api.github.com/users/sarciszewski","html_url":"https://github.com/sarciszewski","followers_url":"https://api.github.com/users/sarciszewski/followers","following_url":"https://api.github.com/users/sarciszewski/following{/other_user}","gists_url":"https://api.github.com/users/sarciszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/sarciszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarciszewski/subscriptions","organizations_url":"https://api.github.com/users/sarciszewski/orgs","repos_url":"https://api.github.com/users/sarciszewski/repos","events_url":"https://api.github.com/users/sarciszewski/events{/privacy}","received_events_url":"https://api.github.com/users/sarciszewski/received_events","type":"User","site_admin":false},"repo":{"id":22066077,"name":"OpenWireless","full_name":"sarciszewski/OpenWireless","owner":{"login":"sarciszewski","id":3710836,"avatar_url":"https://avatars.githubusercontent.com/u/3710836?","gravatar_id":"13da8f0c8208dee1b1229df276f8781d","url":"https://api.github.com/users/sarciszewski","html_url":"https://github.com/sarciszewski","followers_url":"https://api.github.com/users/sarciszewski/followers","following_url":"https://api.github.com/users/sarciszewski/following{/other_user}","gists_url":"https://api.github.com/users/sarciszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/sarciszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarciszewski/subscriptions","organizations_url":"https://api.github.com/users/sarciszewski/orgs","repos_url":"https://api.github.com/users/sarciszewski/repos","events_url":"https://api.github.com/users/sarciszewski/events{/privacy}","received_events_url":"https://api.github.com/users/sarciszewski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarciszewski/OpenWireless","description":"The official home of the EFF OpenWireless Project","fork":true,"url":"https://api.github.com/repos/sarciszewski/OpenWireless","forks_url":"https://api.github.com/repos/sarciszewski/OpenWireless/forks","keys_url":"https://api.github.com/repos/sarciszewski/OpenWireless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarciszewski/OpenWireless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarciszewski/OpenWireless/teams","hooks_url":"https://api.github.com/repos/sarciszewski/OpenWireless/hooks","issue_events_url":"https://api.github.com/repos/sarciszewski/OpenWireless/issues/events{/number}","events_url":"https://api.github.com/repos/sarciszewski/OpenWireless/events","assignees_url":"https://api.github.com/repos/sarciszewski/OpenWireless/assignees{/user}","branches_url":"https://api.github.com/repos/sarciszewski/OpenWireless/branches{/branch}","tags_url":"https://api.github.com/repos/sarciszewski/OpenWireless/tags","blobs_url":"https://api.github.com/repos/sarciszewski/OpenWireless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarciszewski/OpenWireless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarciszewski/OpenWireless/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarciszewski/OpenWireless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarciszewski/OpenWireless/statuses/{sha}","languages_url":"https://api.github.com/repos/sarciszewski/OpenWireless/languages","stargazers_url":"https://api.github.com/repos/sarciszewski/OpenWireless/stargazers","contributors_url":"https://api.github.com/repos/sarciszewski/OpenWireless/contributors","subscribers_url":"https://api.github.com/repos/sarciszewski/OpenWireless/subscribers","subscription_url":"https://api.github.com/repos/sarciszewski/OpenWireless/subscription","commits_url":"https://api.github.com/repos/sarciszewski/OpenWireless/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarciszewski/OpenWireless/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarciszewski/OpenWireless/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarciszewski/OpenWireless/issues/comments/{number}","contents_url":"https://api.github.com/repos/sarciszewski/OpenWireless/contents/{+path}","compare_url":"https://api.github.com/repos/sarciszewski/OpenWireless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarciszewski/OpenWireless/merges","archive_url":"https://api.github.com/repos/sarciszewski/OpenWireless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarciszewski/OpenWireless/downloads","issues_url":"https://api.github.com/repos/sarciszewski/OpenWireless/issues{/number}","pulls_url":"https://api.github.com/repos/sarciszewski/OpenWireless/pulls{/number}","milestones_url":"https://api.github.com/repos/sarciszewski/OpenWireless/milestones{/number}","notifications_url":"https://api.github.com/repos/sarciszewski/OpenWireless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarciszewski/OpenWireless/labels{/name}","releases_url":"https://api.github.com/repos/sarciszewski/OpenWireless/releases{/id}","created_at":"2014-07-21T13:48:29Z","updated_at":"2014-07-28T14:50:33Z","pushed_at":"2014-07-28T17:42:26Z","git_url":"git://github.com/sarciszewski/OpenWireless.git","ssh_url":"git@github.com:sarciszewski/OpenWireless.git","clone_url":"https://github.com/sarciszewski/OpenWireless.git","svn_url":"https://github.com/sarciszewski/OpenWireless","homepage":"","size":28846,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EFForg:master","ref":"master","sha":"02f902fc74fa47f70666adc7d548243942f3fac1","user":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars.githubusercontent.com/u/2120271?","gravatar_id":"05e1354e5bfc5fa09c0e32a2f38f22d1","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"repo":{"id":17996819,"name":"OpenWireless","full_name":"EFForg/OpenWireless","owner":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars.githubusercontent.com/u/2120271?","gravatar_id":"05e1354e5bfc5fa09c0e32a2f38f22d1","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EFForg/OpenWireless","description":"The official home of the EFF OpenWireless Project","fork":false,"url":"https://api.github.com/repos/EFForg/OpenWireless","forks_url":"https://api.github.com/repos/EFForg/OpenWireless/forks","keys_url":"https://api.github.com/repos/EFForg/OpenWireless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EFForg/OpenWireless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EFForg/OpenWireless/teams","hooks_url":"https://api.github.com/repos/EFForg/OpenWireless/hooks","issue_events_url":"https://api.github.com/repos/EFForg/OpenWireless/issues/events{/number}","events_url":"https://api.github.com/repos/EFForg/OpenWireless/events","assignees_url":"https://api.github.com/repos/EFForg/OpenWireless/assignees{/user}","branches_url":"https://api.github.com/repos/EFForg/OpenWireless/branches{/branch}","tags_url":"https://api.github.com/repos/EFForg/OpenWireless/tags","blobs_url":"https://api.github.com/repos/EFForg/OpenWireless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EFForg/OpenWireless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EFForg/OpenWireless/git/refs{/sha}","trees_url":"https://api.github.com/repos/EFForg/OpenWireless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EFForg/OpenWireless/statuses/{sha}","languages_url":"https://api.github.com/repos/EFForg/OpenWireless/languages","stargazers_url":"https://api.github.com/repos/EFForg/OpenWireless/stargazers","contributors_url":"https://api.github.com/repos/EFForg/OpenWireless/contributors","subscribers_url":"https://api.github.com/repos/EFForg/OpenWireless/subscribers","subscription_url":"https://api.github.com/repos/EFForg/OpenWireless/subscription","commits_url":"https://api.github.com/repos/EFForg/OpenWireless/commits{/sha}","git_commits_url":"https://api.github.com/repos/EFForg/OpenWireless/git/commits{/sha}","comments_url":"https://api.github.com/repos/EFForg/OpenWireless/comments{/number}","issue_comment_url":"https://api.github.com/repos/EFForg/OpenWireless/issues/comments/{number}","contents_url":"https://api.github.com/repos/EFForg/OpenWireless/contents/{+path}","compare_url":"https://api.github.com/repos/EFForg/OpenWireless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EFForg/OpenWireless/merges","archive_url":"https://api.github.com/repos/EFForg/OpenWireless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EFForg/OpenWireless/downloads","issues_url":"https://api.github.com/repos/EFForg/OpenWireless/issues{/number}","pulls_url":"https://api.github.com/repos/EFForg/OpenWireless/pulls{/number}","milestones_url":"https://api.github.com/repos/EFForg/OpenWireless/milestones{/number}","notifications_url":"https://api.github.com/repos/EFForg/OpenWireless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EFForg/OpenWireless/labels{/name}","releases_url":"https://api.github.com/repos/EFForg/OpenWireless/releases{/id}","created_at":"2014-03-21T22:52:39Z","updated_at":"2014-07-28T15:54:56Z","pushed_at":"2014-07-28T15:23:43Z","git_url":"git://github.com/EFForg/OpenWireless.git","ssh_url":"git@github.com:EFForg/OpenWireless.git","clone_url":"https://github.com/EFForg/OpenWireless.git","svn_url":"https://github.com/EFForg/OpenWireless","homepage":"","size":34662,"stargazers_count":508,"watchers_count":508,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":45,"mirror_url":null,"open_issues_count":73,"forks":45,"open_issues":73,"watchers":508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EFForg/OpenWireless/pulls/195"},"html":{"href":"https://github.com/EFForg/OpenWireless/pull/195"},"issue":{"href":"https://api.github.com/repos/EFForg/OpenWireless/issues/195"},"comments":{"href":"https://api.github.com/repos/EFForg/OpenWireless/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/EFForg/OpenWireless/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/EFForg/OpenWireless/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/EFForg/OpenWireless/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/EFForg/OpenWireless/statuses/bc1525e7c5252ec7ba756a47191f8ff83905a8ca"}}}}