GitHub PullRequestReviewCommentEvent at 2014-06-10 11:21:42
Repository: entity_validator
Actor: RoySegall
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Gizra/entity_validator/pulls/comments/13588007","id":13588007,"diff_hunk":"@@ -334,73 +235,30 @@ public function isUnixTimeStamp($value, $field) {\n    * value and field. This validate method check the value of the field using\n    * the entity API module.\n    *\n-   * @param $value\n-   *  The value of the field.\n    * @param $field\n    *  The field name.\n+   * @param $value\n+   *  The value of the field.\n    * @param $type\n    *  The type of the field.\n    *\n    * @return boolean\n    */\n-  public function isValidValue($value, $field, $type) {\n+  public function isValidValue($field, $value, $type) {\n     if (!entity_property_verify_data_type($value, $type)) {\n       $params = array(\n-        '%value' => (String) $value,\n-        '%field-label' => $field,\n+        '@value' => (String) $value,\n+        '@field' => $field,\n+      );\n+\n+      $error = array(","path":"includes/EntityValidateBase.php","position":275,"original_position":275,"commit_id":"7e0ad4ec09a9f84151304f73d401618e1599a444","original_commit_id":"7e0ad4ec09a9f84151304f73d401618e1599a444","user":{"login":"RoySegall","id":1222368,"avatar_url":"https://avatars.githubusercontent.com/u/1222368?","gravatar_id":"4f56597a143842c66a426f5da1e3d751","url":"https://api.github.com/users/RoySegall","html_url":"https://github.com/RoySegall","followers_url":"https://api.github.com/users/RoySegall/followers","following_url":"https://api.github.com/users/RoySegall/following{/other_user}","gists_url":"https://api.github.com/users/RoySegall/gists{/gist_id}","starred_url":"https://api.github.com/users/RoySegall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoySegall/subscriptions","organizations_url":"https://api.github.com/users/RoySegall/orgs","repos_url":"https://api.github.com/users/RoySegall/repos","events_url":"https://api.github.com/users/RoySegall/events{/privacy}","received_events_url":"https://api.github.com/users/RoySegall/received_events","type":"User","site_admin":false},"body":"also left as reference.","created_at":"2014-06-10T11:21:42Z","updated_at":"2014-06-10T11:21:42Z","html_url":"https://github.com/Gizra/entity_validator/pull/3#discussion_r13588007","pull_request_url":"https://api.github.com/repos/Gizra/entity_validator/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/Gizra/entity_validator/pulls/comments/13588007"},"html":{"href":"https://github.com/Gizra/entity_validator/pull/3#discussion_r13588007"},"pull_request":{"href":"https://api.github.com/repos/Gizra/entity_validator/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/Gizra/entity_validator/pulls/3","id":16933987,"html_url":"https://github.com/Gizra/entity_validator/pull/3","diff_url":"https://github.com/Gizra/entity_validator/pull/3.diff","patch_url":"https://github.com/Gizra/entity_validator/pull/3.patch","issue_url":"https://api.github.com/repos/Gizra/entity_validator/issues/3","number":3,"state":"open","title":"Validate improve","user":{"login":"RoySegall","id":1222368,"avatar_url":"https://avatars.githubusercontent.com/u/1222368?","gravatar_id":"4f56597a143842c66a426f5da1e3d751","url":"https://api.github.com/users/RoySegall","html_url":"https://github.com/RoySegall","followers_url":"https://api.github.com/users/RoySegall/followers","following_url":"https://api.github.com/users/RoySegall/following{/other_user}","gists_url":"https://api.github.com/users/RoySegall/gists{/gist_id}","starred_url":"https://api.github.com/users/RoySegall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoySegall/subscriptions","organizations_url":"https://api.github.com/users/RoySegall/orgs","repos_url":"https://api.github.com/users/RoySegall/repos","events_url":"https://api.github.com/users/RoySegall/events{/privacy}","received_events_url":"https://api.github.com/users/RoySegall/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-10T11:12:08Z","updated_at":"2014-06-10T11:21:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"602c80b24ae4b73a9af14b42818e58c38e6b4687","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Gizra/entity_validator/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Gizra/entity_validator/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Gizra/entity_validator/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Gizra/entity_validator/issues/3/comments","statuses_url":"https://api.github.com/repos/Gizra/entity_validator/statuses/7e0ad4ec09a9f84151304f73d401618e1599a444","head":{"label":"Gizra:validate-improve","ref":"validate-improve","sha":"7e0ad4ec09a9f84151304f73d401618e1599a444","user":{"login":"Gizra","id":2484795,"avatar_url":"https://avatars.githubusercontent.com/u/2484795?","gravatar_id":null,"url":"https://api.github.com/users/Gizra","html_url":"https://github.com/Gizra","followers_url":"https://api.github.com/users/Gizra/followers","following_url":"https://api.github.com/users/Gizra/following{/other_user}","gists_url":"https://api.github.com/users/Gizra/gists{/gist_id}","starred_url":"https://api.github.com/users/Gizra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gizra/subscriptions","organizations_url":"https://api.github.com/users/Gizra/orgs","repos_url":"https://api.github.com/users/Gizra/repos","events_url":"https://api.github.com/users/Gizra/events{/privacy}","received_events_url":"https://api.github.com/users/Gizra/received_events","type":"Organization","site_admin":false},"repo":{"id":20645559,"name":"entity_validator","full_name":"Gizra/entity_validator","owner":{"login":"Gizra","id":2484795,"avatar_url":"https://avatars.githubusercontent.com/u/2484795?","gravatar_id":null,"url":"https://api.github.com/users/Gizra","html_url":"https://github.com/Gizra","followers_url":"https://api.github.com/users/Gizra/followers","following_url":"https://api.github.com/users/Gizra/following{/other_user}","gists_url":"https://api.github.com/users/Gizra/gists{/gist_id}","starred_url":"https://api.github.com/users/Gizra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gizra/subscriptions","organizations_url":"https://api.github.com/users/Gizra/orgs","repos_url":"https://api.github.com/users/Gizra/repos","events_url":"https://api.github.com/users/Gizra/events{/privacy}","received_events_url":"https://api.github.com/users/Gizra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Gizra/entity_validator","description":"","fork":false,"url":"https://api.github.com/repos/Gizra/entity_validator","forks_url":"https://api.github.com/repos/Gizra/entity_validator/forks","keys_url":"https://api.github.com/repos/Gizra/entity_validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gizra/entity_validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gizra/entity_validator/teams","hooks_url":"https://api.github.com/repos/Gizra/entity_validator/hooks","issue_events_url":"https://api.github.com/repos/Gizra/entity_validator/issues/events{/number}","events_url":"https://api.github.com/repos/Gizra/entity_validator/events","assignees_url":"https://api.github.com/repos/Gizra/entity_validator/assignees{/user}","branches_url":"https://api.github.com/repos/Gizra/entity_validator/branches{/branch}","tags_url":"https://api.github.com/repos/Gizra/entity_validator/tags","blobs_url":"https://api.github.com/repos/Gizra/entity_validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gizra/entity_validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gizra/entity_validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gizra/entity_validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gizra/entity_validator/statuses/{sha}","languages_url":"https://api.github.com/repos/Gizra/entity_validator/languages","stargazers_url":"https://api.github.com/repos/Gizra/entity_validator/stargazers","contributors_url":"https://api.github.com/repos/Gizra/entity_validator/contributors","subscribers_url":"https://api.github.com/repos/Gizra/entity_validator/subscribers","subscription_url":"https://api.github.com/repos/Gizra/entity_validator/subscription","commits_url":"https://api.github.com/repos/Gizra/entity_validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gizra/entity_validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gizra/entity_validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gizra/entity_validator/issues/comments/{number}","contents_url":"https://api.github.com/repos/Gizra/entity_validator/contents/{+path}","compare_url":"https://api.github.com/repos/Gizra/entity_validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gizra/entity_validator/merges","archive_url":"https://api.github.com/repos/Gizra/entity_validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gizra/entity_validator/downloads","issues_url":"https://api.github.com/repos/Gizra/entity_validator/issues{/number}","pulls_url":"https://api.github.com/repos/Gizra/entity_validator/pulls{/number}","milestones_url":"https://api.github.com/repos/Gizra/entity_validator/milestones{/number}","notifications_url":"https://api.github.com/repos/Gizra/entity_validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gizra/entity_validator/labels{/name}","releases_url":"https://api.github.com/repos/Gizra/entity_validator/releases{/id}","created_at":"2014-06-09T12:22:05Z","updated_at":"2014-06-10T11:12:08Z","pushed_at":"2014-06-10T11:10:43Z","git_url":"git://github.com/Gizra/entity_validator.git","ssh_url":"git@github.com:Gizra/entity_validator.git","clone_url":"https://github.com/Gizra/entity_validator.git","svn_url":"https://github.com/Gizra/entity_validator","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"7.x-1.x"}},"base":{"label":"Gizra:7.x-1.x","ref":"7.x-1.x","sha":"702273a17a1dde1e972897793df620e7d9ea7390","user":{"login":"Gizra","id":2484795,"avatar_url":"https://avatars.githubusercontent.com/u/2484795?","gravatar_id":null,"url":"https://api.github.com/users/Gizra","html_url":"https://github.com/Gizra","followers_url":"https://api.github.com/users/Gizra/followers","following_url":"https://api.github.com/users/Gizra/following{/other_user}","gists_url":"https://api.github.com/users/Gizra/gists{/gist_id}","starred_url":"https://api.github.com/users/Gizra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gizra/subscriptions","organizations_url":"https://api.github.com/users/Gizra/orgs","repos_url":"https://api.github.com/users/Gizra/repos","events_url":"https://api.github.com/users/Gizra/events{/privacy}","received_events_url":"https://api.github.com/users/Gizra/received_events","type":"Organization","site_admin":false},"repo":{"id":20645559,"name":"entity_validator","full_name":"Gizra/entity_validator","owner":{"login":"Gizra","id":2484795,"avatar_url":"https://avatars.githubusercontent.com/u/2484795?","gravatar_id":null,"url":"https://api.github.com/users/Gizra","html_url":"https://github.com/Gizra","followers_url":"https://api.github.com/users/Gizra/followers","following_url":"https://api.github.com/users/Gizra/following{/other_user}","gists_url":"https://api.github.com/users/Gizra/gists{/gist_id}","starred_url":"https://api.github.com/users/Gizra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gizra/subscriptions","organizations_url":"https://api.github.com/users/Gizra/orgs","repos_url":"https://api.github.com/users/Gizra/repos","events_url":"https://api.github.com/users/Gizra/events{/privacy}","received_events_url":"https://api.github.com/users/Gizra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Gizra/entity_validator","description":"","fork":false,"url":"https://api.github.com/repos/Gizra/entity_validator","forks_url":"https://api.github.com/repos/Gizra/entity_validator/forks","keys_url":"https://api.github.com/repos/Gizra/entity_validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gizra/entity_validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gizra/entity_validator/teams","hooks_url":"https://api.github.com/repos/Gizra/entity_validator/hooks","issue_events_url":"https://api.github.com/repos/Gizra/entity_validator/issues/events{/number}","events_url":"https://api.github.com/repos/Gizra/entity_validator/events","assignees_url":"https://api.github.com/repos/Gizra/entity_validator/assignees{/user}","branches_url":"https://api.github.com/repos/Gizra/entity_validator/branches{/branch}","tags_url":"https://api.github.com/repos/Gizra/entity_validator/tags","blobs_url":"https://api.github.com/repos/Gizra/entity_validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gizra/entity_validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gizra/entity_validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gizra/entity_validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gizra/entity_validator/statuses/{sha}","languages_url":"https://api.github.com/repos/Gizra/entity_validator/languages","stargazers_url":"https://api.github.com/repos/Gizra/entity_validator/stargazers","contributors_url":"https://api.github.com/repos/Gizra/entity_validator/contributors","subscribers_url":"https://api.github.com/repos/Gizra/entity_validator/subscribers","subscription_url":"https://api.github.com/repos/Gizra/entity_validator/subscription","commits_url":"https://api.github.com/repos/Gizra/entity_validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gizra/entity_validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gizra/entity_validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gizra/entity_validator/issues/comments/{number}","contents_url":"https://api.github.com/repos/Gizra/entity_validator/contents/{+path}","compare_url":"https://api.github.com/repos/Gizra/entity_validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gizra/entity_validator/merges","archive_url":"https://api.github.com/repos/Gizra/entity_validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gizra/entity_validator/downloads","issues_url":"https://api.github.com/repos/Gizra/entity_validator/issues{/number}","pulls_url":"https://api.github.com/repos/Gizra/entity_validator/pulls{/number}","milestones_url":"https://api.github.com/repos/Gizra/entity_validator/milestones{/number}","notifications_url":"https://api.github.com/repos/Gizra/entity_validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gizra/entity_validator/labels{/name}","releases_url":"https://api.github.com/repos/Gizra/entity_validator/releases{/id}","created_at":"2014-06-09T12:22:05Z","updated_at":"2014-06-10T11:12:08Z","pushed_at":"2014-06-10T11:10:43Z","git_url":"git://github.com/Gizra/entity_validator.git","ssh_url":"git@github.com:Gizra/entity_validator.git","clone_url":"https://github.com/Gizra/entity_validator.git","svn_url":"https://github.com/Gizra/entity_validator","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"7.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Gizra/entity_validator/pulls/3"},"html":{"href":"https://github.com/Gizra/entity_validator/pull/3"},"issue":{"href":"https://api.github.com/repos/Gizra/entity_validator/issues/3"},"comments":{"href":"https://api.github.com/repos/Gizra/entity_validator/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Gizra/entity_validator/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Gizra/entity_validator/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Gizra/entity_validator/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Gizra/entity_validator/statuses/7e0ad4ec09a9f84151304f73d401618e1599a444"}}}}