GitHub PullRequestReviewCommentEvent at 2014-06-30 19:30:07
Repository: puppet
Actor: ferventcoder
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/14370168","id":14370168,"diff_hunk":"@@ -77,9 +77,12 @@ end\n require 'yaml'\n data = YAML.load_file(File.join(File.dirname(__FILE__), 'ext', 'project_data.yaml'))\n bundle_platforms = data['bundle_platforms']\n+x64_platform = Bundler::Dsl::VALID_PLATFORMS.include?(:x64_mingw)\n data['gem_platform_dependencies'].each_pair do |gem_platform, info|\n+  next if gem_platform == 'x86-mingw32' && x64_platform\n+  next if gem_platform == 'x64-mingw32' && !x64_platform","path":"Gemfile","position":7,"original_position":7,"commit_id":"a71057439a73bf4a4c8d8c8a8094997e4c825796","original_commit_id":"a71057439a73bf4a4c8d8c8a8094997e4c825796","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?","gravatar_id":"33a97150e4280a56c137fbfd763eb03d","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"body":"Well that's an interesting way of limiting it...","created_at":"2014-06-30T19:30:07Z","updated_at":"2014-06-30T19:30:07Z","html_url":"https://github.com/puppetlabs/puppet/pull/2822#discussion_r14370168","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2822","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/14370168"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2822#discussion_r14370168"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2822"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2822","id":17792785,"html_url":"https://github.com/puppetlabs/puppet/pull/2822","diff_url":"https://github.com/puppetlabs/puppet/pull/2822.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/2822.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2822","number":2822,"state":"open","title":"(PUP-2777) Bundler Windows x64 workflow","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars.githubusercontent.com/u/394081?","gravatar_id":"c807a386363efa2147c76f4769cb24ee","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"body":" - Ensure that Bundler loads proper gemset whether on x86 or x64, based\r\n   on what is defined in project_data.yaml\r\n - Note that latest FFI compatible gems have been added to x64 out of\r\n   necessity, but the code fails tests, and is not yet compatible with\r\n   Ruby 2 changes / gem updates.\r\n - Gem versions for Ruby 1.9.x were kept the same, and will be upgraded\r\n   as part of verifying gem compatibility when updating 1.9.x branch\r\n   to use latest FFI compatible gems.","created_at":"2014-06-30T19:29:19Z","updated_at":"2014-06-30T19:30:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9baf734ff72ebe557cc5c0f5b841c2d6a8945f4d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2822/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2822/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/2822/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/a71057439a73bf4a4c8d8c8a8094997e4c825796","head":{"label":"Iristyle:ticket/master/PUP-2777-Puppet-Bundler-Workflow-x64","ref":"ticket/master/PUP-2777-Puppet-Bundler-Workflow-x64","sha":"a71057439a73bf4a4c8d8c8a8094997e4c825796","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars.githubusercontent.com/u/394081?","gravatar_id":"c807a386363efa2147c76f4769cb24ee","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"repo":{"id":12253882,"name":"puppet","full_name":"Iristyle/puppet","owner":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars.githubusercontent.com/u/394081?","gravatar_id":"c807a386363efa2147c76f4769cb24ee","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Iristyle/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/Iristyle/puppet","forks_url":"https://api.github.com/repos/Iristyle/puppet/forks","keys_url":"https://api.github.com/repos/Iristyle/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Iristyle/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Iristyle/puppet/teams","hooks_url":"https://api.github.com/repos/Iristyle/puppet/hooks","issue_events_url":"https://api.github.com/repos/Iristyle/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/Iristyle/puppet/events","assignees_url":"https://api.github.com/repos/Iristyle/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/Iristyle/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/Iristyle/puppet/tags","blobs_url":"https://api.github.com/repos/Iristyle/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Iristyle/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Iristyle/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Iristyle/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Iristyle/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/Iristyle/puppet/languages","stargazers_url":"https://api.github.com/repos/Iristyle/puppet/stargazers","contributors_url":"https://api.github.com/repos/Iristyle/puppet/contributors","subscribers_url":"https://api.github.com/repos/Iristyle/puppet/subscribers","subscription_url":"https://api.github.com/repos/Iristyle/puppet/subscription","commits_url":"https://api.github.com/repos/Iristyle/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Iristyle/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Iristyle/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Iristyle/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/Iristyle/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/Iristyle/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Iristyle/puppet/merges","archive_url":"https://api.github.com/repos/Iristyle/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Iristyle/puppet/downloads","issues_url":"https://api.github.com/repos/Iristyle/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/Iristyle/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/Iristyle/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/Iristyle/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Iristyle/puppet/labels{/name}","releases_url":"https://api.github.com/repos/Iristyle/puppet/releases{/id}","created_at":"2013-08-20T20:49:43Z","updated_at":"2014-06-25T03:59:18Z","pushed_at":"2014-06-30T19:29:13Z","git_url":"git://github.com/Iristyle/puppet.git","ssh_url":"git@github.com:Iristyle/puppet.git","clone_url":"https://github.com/Iristyle/puppet.git","svn_url":"https://github.com/Iristyle/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":41313,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"aa60e3bc7a2689b6fcdc5047fd318dafccc1c484","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?","gravatar_id":"eb454c2139c156db7c8266a875519a1f","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2014-06-30T18:22:52Z","pushed_at":"2014-06-30T19:07:46Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":100985,"stargazers_count":2310,"watchers_count":2310,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":1036,"mirror_url":null,"open_issues_count":39,"forks":1036,"open_issues":39,"watchers":2310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2822"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2822"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2822"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/2822/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2822/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2822/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/a71057439a73bf4a4c8d8c8a8094997e4c825796"}}}}