GitHub PullRequestReviewCommentEvent at 2014-12-04 11:27:16
Repository: io.js
Actor: bnoordhuis
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/iojs/io.js/pulls/comments/21298855","id":21298855,"diff_hunk":"@@ -203,7 +203,7 @@ Client.prototype._addScript = function(desc) {\n   this.scripts[desc.id] = desc;\n   if (desc.name) {\n     desc.isNative = (desc.name.replace('.js', '') in natives) ||\n-                    desc.name == 'node.js';\n+                    desc.name == 'io.js';","path":"lib/_debugger.js","position":5,"original_position":5,"commit_id":"673a9b1dc16fe687d2903f9b64cf1017d44d0856","original_commit_id":"673a9b1dc16fe687d2903f9b64cf1017d44d0856","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"This should be reverted, it checks if the debugged file is src/node.js.","created_at":"2014-12-04T11:27:16Z","updated_at":"2014-12-04T11:27:16Z","html_url":"https://github.com/iojs/io.js/pull/32#discussion_r21298855","pull_request_url":"https://api.github.com/repos/iojs/io.js/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/21298855"},"html":{"href":"https://github.com/iojs/io.js/pull/32#discussion_r21298855"},"pull_request":{"href":"https://api.github.com/repos/iojs/io.js/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/iojs/io.js/pulls/32","id":25389071,"html_url":"https://github.com/iojs/io.js/pull/32","diff_url":"https://github.com/iojs/io.js/pull/32.diff","patch_url":"https://github.com/iojs/io.js/pull/32.patch","issue_url":"https://api.github.com/repos/iojs/io.js/issues/32","number":32,"state":"open","locked":false,"title":"docs: replace all instances of node.js with io.js because trademark.","user":{"login":"mikeal","id":579,"avatar_url":"https://avatars.githubusercontent.com/u/579?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeal","html_url":"https://github.com/mikeal","followers_url":"https://api.github.com/users/mikeal/followers","following_url":"https://api.github.com/users/mikeal/following{/other_user}","gists_url":"https://api.github.com/users/mikeal/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeal/subscriptions","organizations_url":"https://api.github.com/users/mikeal/orgs","repos_url":"https://api.github.com/users/mikeal/repos","events_url":"https://api.github.com/users/mikeal/events{/privacy}","received_events_url":"https://api.github.com/users/mikeal/received_events","type":"User","site_admin":false},"body":"I doubt this is acceptable \"as is\" but it's a good starting point to talk about all the places the trademarked term \"node.js\" appears in the repo and what, in all, might need to be changed in order to remove it.","created_at":"2014-12-03T01:14:40Z","updated_at":"2014-12-04T11:27:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iojs/io.js/pulls/32/commits","review_comments_url":"https://api.github.com/repos/iojs/io.js/pulls/32/comments","review_comment_url":"https://api.github.com/repos/iojs/io.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/32/comments","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/673a9b1dc16fe687d2903f9b64cf1017d44d0856","head":{"label":"mikeal:remove-nodejs","ref":"remove-nodejs","sha":"673a9b1dc16fe687d2903f9b64cf1017d44d0856","user":{"login":"mikeal","id":579,"avatar_url":"https://avatars.githubusercontent.com/u/579?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeal","html_url":"https://github.com/mikeal","followers_url":"https://api.github.com/users/mikeal/followers","following_url":"https://api.github.com/users/mikeal/following{/other_user}","gists_url":"https://api.github.com/users/mikeal/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeal/subscriptions","organizations_url":"https://api.github.com/users/mikeal/orgs","repos_url":"https://api.github.com/users/mikeal/repos","events_url":"https://api.github.com/users/mikeal/events{/privacy}","received_events_url":"https://api.github.com/users/mikeal/received_events","type":"User","site_admin":false},"repo":{"id":27409306,"name":"io.js","full_name":"mikeal/io.js","owner":{"login":"mikeal","id":579,"avatar_url":"https://avatars.githubusercontent.com/u/579?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeal","html_url":"https://github.com/mikeal","followers_url":"https://api.github.com/users/mikeal/followers","following_url":"https://api.github.com/users/mikeal/following{/other_user}","gists_url":"https://api.github.com/users/mikeal/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeal/subscriptions","organizations_url":"https://api.github.com/users/mikeal/orgs","repos_url":"https://api.github.com/users/mikeal/repos","events_url":"https://api.github.com/users/mikeal/events{/privacy}","received_events_url":"https://api.github.com/users/mikeal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikeal/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/mikeal/io.js","forks_url":"https://api.github.com/repos/mikeal/io.js/forks","keys_url":"https://api.github.com/repos/mikeal/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikeal/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikeal/io.js/teams","hooks_url":"https://api.github.com/repos/mikeal/io.js/hooks","issue_events_url":"https://api.github.com/repos/mikeal/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/mikeal/io.js/events","assignees_url":"https://api.github.com/repos/mikeal/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/mikeal/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/mikeal/io.js/tags","blobs_url":"https://api.github.com/repos/mikeal/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikeal/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikeal/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikeal/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikeal/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mikeal/io.js/languages","stargazers_url":"https://api.github.com/repos/mikeal/io.js/stargazers","contributors_url":"https://api.github.com/repos/mikeal/io.js/contributors","subscribers_url":"https://api.github.com/repos/mikeal/io.js/subscribers","subscription_url":"https://api.github.com/repos/mikeal/io.js/subscription","commits_url":"https://api.github.com/repos/mikeal/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikeal/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikeal/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikeal/io.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/mikeal/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/mikeal/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikeal/io.js/merges","archive_url":"https://api.github.com/repos/mikeal/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikeal/io.js/downloads","issues_url":"https://api.github.com/repos/mikeal/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/mikeal/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mikeal/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mikeal/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikeal/io.js/labels{/name}","releases_url":"https://api.github.com/repos/mikeal/io.js/releases{/id}","created_at":"2014-12-02T01:35:51Z","updated_at":"2014-12-03T03:57:39Z","pushed_at":"2014-12-03T23:09:53Z","git_url":"git://github.com/mikeal/io.js.git","ssh_url":"git@github.com:mikeal/io.js.git","clone_url":"https://github.com/mikeal/io.js.git","svn_url":"https://github.com/mikeal/io.js","homepage":null,"size":113570,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"v0.12"}},"base":{"label":"iojs:v0.12","ref":"v0.12","sha":"185d11c791c208fdc819d2890a897e7aefe353e8","user":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"iojs/io.js","owner":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iojs/io.js","description":"Evented IO for V8 JavaScript","fork":false,"url":"https://api.github.com/repos/iojs/io.js","forks_url":"https://api.github.com/repos/iojs/io.js/forks","keys_url":"https://api.github.com/repos/iojs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iojs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iojs/io.js/teams","hooks_url":"https://api.github.com/repos/iojs/io.js/hooks","issue_events_url":"https://api.github.com/repos/iojs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/iojs/io.js/events","assignees_url":"https://api.github.com/repos/iojs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/iojs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/iojs/io.js/tags","blobs_url":"https://api.github.com/repos/iojs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iojs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iojs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/iojs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/iojs/io.js/languages","stargazers_url":"https://api.github.com/repos/iojs/io.js/stargazers","contributors_url":"https://api.github.com/repos/iojs/io.js/contributors","subscribers_url":"https://api.github.com/repos/iojs/io.js/subscribers","subscription_url":"https://api.github.com/repos/iojs/io.js/subscription","commits_url":"https://api.github.com/repos/iojs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/iojs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/iojs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/iojs/io.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/iojs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/iojs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iojs/io.js/merges","archive_url":"https://api.github.com/repos/iojs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iojs/io.js/downloads","issues_url":"https://api.github.com/repos/iojs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/iojs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/iojs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/iojs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iojs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/iojs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2014-12-04T11:22:43Z","pushed_at":"2014-12-04T10:33:08Z","git_url":"git://github.com/iojs/io.js.git","ssh_url":"git@github.com:iojs/io.js.git","clone_url":"https://github.com/iojs/io.js.git","svn_url":"https://github.com/iojs/io.js","homepage":null,"size":113906,"stargazers_count":1499,"watchers_count":1499,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":43,"forks":57,"open_issues":43,"watchers":1499,"default_branch":"v0.12"}},"_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/32"},"html":{"href":"https://github.com/iojs/io.js/pull/32"},"issue":{"href":"https://api.github.com/repos/iojs/io.js/issues/32"},"comments":{"href":"https://api.github.com/repos/iojs/io.js/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/iojs/io.js/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/iojs/io.js/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/iojs/io.js/statuses/673a9b1dc16fe687d2903f9b64cf1017d44d0856"}}}}