GitHub PullRequestReviewCommentEvent at 2014-07-11 01:27:03
Repository: consul-conf
Actor: charliek
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls/comments/14802971","id":14802971,"diff_hunk":"@@ -1,4 +1,13 @@\n-cleanrebase\n-===========\n \n-clean rebase\n+# Config Options\n+\n+<dl>\n+<h4>Required</h4>\n+<dt>template</dt> <dd>the ERB template to use to generate new configurations</dd>\n+<dt>outfile</dt> <dd>the destination - the config file to rewrite</dd>\n+<dt></dt> <dd></dd>\n+<h4>Optional</h4>\n+<dt>comment_regex</dt> <dd>A regular expression ( passed to `Regexp.new`) to pull comments out of the template ( so that comments are not included in the diff when checking for updates).  You might consider using `\"^\\\\s*#\"` for files with hashed comment lines.  <br/><em>Note:</em> be sure to escape backslashes!</em></dd>\n+<dt>postupdate</dt> <dd>A command to run after updating the config file ( eg restarting a service )</dd>\n+<dt>postupdate_status</dt> <dd>An 8-bit integer status code to expect from the postupdate command, only considered if the `postupdate` option is specified.  </dd>","path":"README.md","position":15,"original_position":15,"commit_id":"2f7bbc7f085663d5d8ed776f4d697cee1da159db","original_commit_id":"2f7bbc7f085663d5d8ed776f4d697cee1da159db","user":{"login":"charliek","id":24948,"avatar_url":"https://avatars.githubusercontent.com/u/24948?","gravatar_id":"2dd00391dd42cc3abba77111fc3bc3ec","url":"https://api.github.com/users/charliek","html_url":"https://github.com/charliek","followers_url":"https://api.github.com/users/charliek/followers","following_url":"https://api.github.com/users/charliek/following{/other_user}","gists_url":"https://api.github.com/users/charliek/gists{/gist_id}","starred_url":"https://api.github.com/users/charliek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliek/subscriptions","organizations_url":"https://api.github.com/users/charliek/orgs","repos_url":"https://api.github.com/users/charliek/repos","events_url":"https://api.github.com/users/charliek/events{/privacy}","received_events_url":"https://api.github.com/users/charliek/received_events","type":"User","site_admin":false},"body":"Would this ever be something other than zero? If we don't know of a case maybe we could just force the zero convention. ","created_at":"2014-07-11T01:27:03Z","updated_at":"2014-07-11T01:27:03Z","html_url":"https://github.com/dfarrell-bloom/consul-conf/pull/5#discussion_r14802971","pull_request_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls/comments/14802971"},"html":{"href":"https://github.com/dfarrell-bloom/consul-conf/pull/5#discussion_r14802971"},"pull_request":{"href":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls/5","id":18217718,"html_url":"https://github.com/dfarrell-bloom/consul-conf/pull/5","diff_url":"https://github.com/dfarrell-bloom/consul-conf/pull/5.diff","patch_url":"https://github.com/dfarrell-bloom/consul-conf/pull/5.patch","issue_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/issues/5","number":5,"state":"open","title":"Consul-Conf: config templates from consul data","user":{"login":"dfarrell-bloom","id":3210060,"avatar_url":"https://avatars.githubusercontent.com/u/3210060?","gravatar_id":"457584f383b695623ee29886edd1553e","url":"https://api.github.com/users/dfarrell-bloom","html_url":"https://github.com/dfarrell-bloom","followers_url":"https://api.github.com/users/dfarrell-bloom/followers","following_url":"https://api.github.com/users/dfarrell-bloom/following{/other_user}","gists_url":"https://api.github.com/users/dfarrell-bloom/gists{/gist_id}","starred_url":"https://api.github.com/users/dfarrell-bloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfarrell-bloom/subscriptions","organizations_url":"https://api.github.com/users/dfarrell-bloom/orgs","repos_url":"https://api.github.com/users/dfarrell-bloom/repos","events_url":"https://api.github.com/users/dfarrell-bloom/events{/privacy}","received_events_url":"https://api.github.com/users/dfarrell-bloom/received_events","type":"User","site_admin":false},"body":"Object oriented mechanism to rewrite config files from template filled in by consul data.  The primary functionality here is to go through the consul services and nodes, using their health checks to come up with an idea of what nodes offer what servies  and their health status.  This data can then be plugged into  template to write out a configuration file. The code includes a diffing mechanism to verify that the file has changed, with comment exclusion, and hooks eg to restart services.","created_at":"2014-07-10T13:03:43Z","updated_at":"2014-07-11T01:27:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c115f03139684610abc7a1e1ba025a2fa6d2a0e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls/5/commits","review_comments_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls/5/comments","review_comment_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/issues/5/comments","statuses_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/statuses/2f7bbc7f085663d5d8ed776f4d697cee1da159db","head":{"label":"dfarrell-bloom:initial","ref":"initial","sha":"2f7bbc7f085663d5d8ed776f4d697cee1da159db","user":{"login":"dfarrell-bloom","id":3210060,"avatar_url":"https://avatars.githubusercontent.com/u/3210060?","gravatar_id":"457584f383b695623ee29886edd1553e","url":"https://api.github.com/users/dfarrell-bloom","html_url":"https://github.com/dfarrell-bloom","followers_url":"https://api.github.com/users/dfarrell-bloom/followers","following_url":"https://api.github.com/users/dfarrell-bloom/following{/other_user}","gists_url":"https://api.github.com/users/dfarrell-bloom/gists{/gist_id}","starred_url":"https://api.github.com/users/dfarrell-bloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfarrell-bloom/subscriptions","organizations_url":"https://api.github.com/users/dfarrell-bloom/orgs","repos_url":"https://api.github.com/users/dfarrell-bloom/repos","events_url":"https://api.github.com/users/dfarrell-bloom/events{/privacy}","received_events_url":"https://api.github.com/users/dfarrell-bloom/received_events","type":"User","site_admin":false},"repo":{"id":21288365,"name":"consul-conf","full_name":"dfarrell-bloom/consul-conf","owner":{"login":"dfarrell-bloom","id":3210060,"avatar_url":"https://avatars.githubusercontent.com/u/3210060?","gravatar_id":"457584f383b695623ee29886edd1553e","url":"https://api.github.com/users/dfarrell-bloom","html_url":"https://github.com/dfarrell-bloom","followers_url":"https://api.github.com/users/dfarrell-bloom/followers","following_url":"https://api.github.com/users/dfarrell-bloom/following{/other_user}","gists_url":"https://api.github.com/users/dfarrell-bloom/gists{/gist_id}","starred_url":"https://api.github.com/users/dfarrell-bloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfarrell-bloom/subscriptions","organizations_url":"https://api.github.com/users/dfarrell-bloom/orgs","repos_url":"https://api.github.com/users/dfarrell-bloom/repos","events_url":"https://api.github.com/users/dfarrell-bloom/events{/privacy}","received_events_url":"https://api.github.com/users/dfarrell-bloom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dfarrell-bloom/consul-conf","description":"Regenerate configuration files based on node and service status from the Consul API.","fork":false,"url":"https://api.github.com/repos/dfarrell-bloom/consul-conf","forks_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/forks","keys_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/teams","hooks_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/hooks","issue_events_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/issues/events{/number}","events_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/events","assignees_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/assignees{/user}","branches_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/branches{/branch}","tags_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/tags","blobs_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/git/refs{/sha}","trees_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/statuses/{sha}","languages_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/languages","stargazers_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/stargazers","contributors_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/contributors","subscribers_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/subscribers","subscription_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/subscription","commits_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/commits{/sha}","git_commits_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/git/commits{/sha}","comments_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/comments{/number}","issue_comment_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/issues/comments/{number}","contents_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/contents/{+path}","compare_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/merges","archive_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/downloads","issues_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/issues{/number}","pulls_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls{/number}","milestones_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/milestones{/number}","notifications_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/labels{/name}","releases_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/releases{/id}","created_at":"2014-06-27T20:29:18Z","updated_at":"2014-06-27T20:31:20Z","pushed_at":"2014-07-10T13:03:19Z","git_url":"git://github.com/dfarrell-bloom/consul-conf.git","ssh_url":"git@github.com:dfarrell-bloom/consul-conf.git","clone_url":"https://github.com/dfarrell-bloom/consul-conf.git","svn_url":"https://github.com/dfarrell-bloom/consul-conf","homepage":null,"size":136,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"initial"}},"base":{"label":"dfarrell-bloom:master","ref":"master","sha":"8ee6b57d09a30284839fa66a754f3c8f4844420f","user":{"login":"dfarrell-bloom","id":3210060,"avatar_url":"https://avatars.githubusercontent.com/u/3210060?","gravatar_id":"457584f383b695623ee29886edd1553e","url":"https://api.github.com/users/dfarrell-bloom","html_url":"https://github.com/dfarrell-bloom","followers_url":"https://api.github.com/users/dfarrell-bloom/followers","following_url":"https://api.github.com/users/dfarrell-bloom/following{/other_user}","gists_url":"https://api.github.com/users/dfarrell-bloom/gists{/gist_id}","starred_url":"https://api.github.com/users/dfarrell-bloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfarrell-bloom/subscriptions","organizations_url":"https://api.github.com/users/dfarrell-bloom/orgs","repos_url":"https://api.github.com/users/dfarrell-bloom/repos","events_url":"https://api.github.com/users/dfarrell-bloom/events{/privacy}","received_events_url":"https://api.github.com/users/dfarrell-bloom/received_events","type":"User","site_admin":false},"repo":{"id":21288365,"name":"consul-conf","full_name":"dfarrell-bloom/consul-conf","owner":{"login":"dfarrell-bloom","id":3210060,"avatar_url":"https://avatars.githubusercontent.com/u/3210060?","gravatar_id":"457584f383b695623ee29886edd1553e","url":"https://api.github.com/users/dfarrell-bloom","html_url":"https://github.com/dfarrell-bloom","followers_url":"https://api.github.com/users/dfarrell-bloom/followers","following_url":"https://api.github.com/users/dfarrell-bloom/following{/other_user}","gists_url":"https://api.github.com/users/dfarrell-bloom/gists{/gist_id}","starred_url":"https://api.github.com/users/dfarrell-bloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfarrell-bloom/subscriptions","organizations_url":"https://api.github.com/users/dfarrell-bloom/orgs","repos_url":"https://api.github.com/users/dfarrell-bloom/repos","events_url":"https://api.github.com/users/dfarrell-bloom/events{/privacy}","received_events_url":"https://api.github.com/users/dfarrell-bloom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dfarrell-bloom/consul-conf","description":"Regenerate configuration files based on node and service status from the Consul API.","fork":false,"url":"https://api.github.com/repos/dfarrell-bloom/consul-conf","forks_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/forks","keys_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/teams","hooks_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/hooks","issue_events_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/issues/events{/number}","events_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/events","assignees_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/assignees{/user}","branches_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/branches{/branch}","tags_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/tags","blobs_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/git/refs{/sha}","trees_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/statuses/{sha}","languages_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/languages","stargazers_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/stargazers","contributors_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/contributors","subscribers_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/subscribers","subscription_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/subscription","commits_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/commits{/sha}","git_commits_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/git/commits{/sha}","comments_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/comments{/number}","issue_comment_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/issues/comments/{number}","contents_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/contents/{+path}","compare_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/merges","archive_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/downloads","issues_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/issues{/number}","pulls_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls{/number}","milestones_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/milestones{/number}","notifications_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/labels{/name}","releases_url":"https://api.github.com/repos/dfarrell-bloom/consul-conf/releases{/id}","created_at":"2014-06-27T20:29:18Z","updated_at":"2014-06-27T20:31:20Z","pushed_at":"2014-07-10T13:03:19Z","git_url":"git://github.com/dfarrell-bloom/consul-conf.git","ssh_url":"git@github.com:dfarrell-bloom/consul-conf.git","clone_url":"https://github.com/dfarrell-bloom/consul-conf.git","svn_url":"https://github.com/dfarrell-bloom/consul-conf","homepage":null,"size":136,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"initial"}},"_links":{"self":{"href":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls/5"},"html":{"href":"https://github.com/dfarrell-bloom/consul-conf/pull/5"},"issue":{"href":"https://api.github.com/repos/dfarrell-bloom/consul-conf/issues/5"},"comments":{"href":"https://api.github.com/repos/dfarrell-bloom/consul-conf/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dfarrell-bloom/consul-conf/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/dfarrell-bloom/consul-conf/statuses/2f7bbc7f085663d5d8ed776f4d697cee1da159db"}}}}