GitHub PushEvent at 2014-07-21 05:57:41
Repository: sapphire
Actor: stojg
Payload: {"shas":[["06886d337379a74c4bab4226131e88773aabc094","ca56267d7e6bab1192d8b1766a424368fa1212f0@gmail.com","BUG: CMS tree filters doesn't count the correct number of children for deleted pages\n\nThis is a bug that combines Hierarchy, Versioned and LeftAndMain admins and CMSSiteTreeFilters.\n\nThis bug can be reproduced by having a large site tree with enough deleted pages in it so it doesn't\npre load all the children pages when initially opening an admin. Filter by either 'All pages including deleted'\nor 'Deleted pages'. For CMS users it will look like deleted pages are gone.\n\nThe solution involves a couple of smaller fixes in both CMS and framework modules.\n\n1) Ensure that 'numHistoricalChildren' are used instead of 'numChildren' when dealing with deleted pages\n2) LeftAndMain::currentPage() deletes all the 'marking' cache previously built up by Hierarchy::markPartialTree()\n3) Use Versioned::get_included_deleted() instead of raw DB queries against the DataObject tables when calculating parents in CMSSiteTreeFilter","Stig Lindqvist",true]],"size":1,"ref":"refs/heads/issue/cms-1049","head":"06886d337379a74c4bab4226131e88773aabc094"}