GitHub PullRequestEvent at 2014-08-08 20:57:00
Repository: moment
Actor: yanickrochon
Payload: {"action":"opened","number":1844,"pull_request":{"url":"https://api.github.com/repos/moment/moment/pulls/1844","id":19551270,"html_url":"https://github.com/moment/moment/pull/1844","diff_url":"https://github.com/moment/moment/pull/1844.diff","patch_url":"https://github.com/moment/moment/pull/1844.patch","issue_url":"https://api.github.com/repos/moment/moment/issues/1844","number":1844,"state":"open","title":"Properly declare moment with require.js","user":{"login":"yanickrochon","id":78461,"avatar_url":"https://avatars.githubusercontent.com/u/78461?v=2","gravatar_id":"8c777e5759d803864d1be827dfdde2db","url":"https://api.github.com/users/yanickrochon","html_url":"https://github.com/yanickrochon","followers_url":"https://api.github.com/users/yanickrochon/followers","following_url":"https://api.github.com/users/yanickrochon/following{/other_user}","gists_url":"https://api.github.com/users/yanickrochon/gists{/gist_id}","starred_url":"https://api.github.com/users/yanickrochon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanickrochon/subscriptions","organizations_url":"https://api.github.com/users/yanickrochon/orgs","repos_url":"https://api.github.com/users/yanickrochon/repos","events_url":"https://api.github.com/users/yanickrochon/events{/privacy}","received_events_url":"https://api.github.com/users/yanickrochon/received_events","type":"User","site_admin":false},"body":"There is a problem with moment, in which it does not define itself properly with RequireJS. This issue was discussed [here](Eonasdan/bootstrap-datetimepicker#459), and was concluded that this was how moment.js declares itself. This PR solves this issue. All tests pass.","created_at":"2014-08-08T20:56:59Z","updated_at":"2014-08-08T20:56:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moment/moment/pulls/1844/commits","review_comments_url":"https://api.github.com/repos/moment/moment/pulls/1844/comments","review_comment_url":"https://api.github.com/repos/moment/moment/pulls/comments/{number}","comments_url":"https://api.github.com/repos/moment/moment/issues/1844/comments","statuses_url":"https://api.github.com/repos/moment/moment/statuses/1de6f233da4697cd4ff87bb1d675ad53a5fe9636","head":{"label":"yanickrochon:develop","ref":"develop","sha":"1de6f233da4697cd4ff87bb1d675ad53a5fe9636","user":{"login":"yanickrochon","id":78461,"avatar_url":"https://avatars.githubusercontent.com/u/78461?v=2","gravatar_id":"8c777e5759d803864d1be827dfdde2db","url":"https://api.github.com/users/yanickrochon","html_url":"https://github.com/yanickrochon","followers_url":"https://api.github.com/users/yanickrochon/followers","following_url":"https://api.github.com/users/yanickrochon/following{/other_user}","gists_url":"https://api.github.com/users/yanickrochon/gists{/gist_id}","starred_url":"https://api.github.com/users/yanickrochon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanickrochon/subscriptions","organizations_url":"https://api.github.com/users/yanickrochon/orgs","repos_url":"https://api.github.com/users/yanickrochon/repos","events_url":"https://api.github.com/users/yanickrochon/events{/privacy}","received_events_url":"https://api.github.com/users/yanickrochon/received_events","type":"User","site_admin":false},"repo":{"id":22771070,"name":"moment","full_name":"yanickrochon/moment","owner":{"login":"yanickrochon","id":78461,"avatar_url":"https://avatars.githubusercontent.com/u/78461?v=2","gravatar_id":"8c777e5759d803864d1be827dfdde2db","url":"https://api.github.com/users/yanickrochon","html_url":"https://github.com/yanickrochon","followers_url":"https://api.github.com/users/yanickrochon/followers","following_url":"https://api.github.com/users/yanickrochon/following{/other_user}","gists_url":"https://api.github.com/users/yanickrochon/gists{/gist_id}","starred_url":"https://api.github.com/users/yanickrochon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanickrochon/subscriptions","organizations_url":"https://api.github.com/users/yanickrochon/orgs","repos_url":"https://api.github.com/users/yanickrochon/repos","events_url":"https://api.github.com/users/yanickrochon/events{/privacy}","received_events_url":"https://api.github.com/users/yanickrochon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yanickrochon/moment","description":"Parse, validate, manipulate, and display dates in javascript.","fork":true,"url":"https://api.github.com/repos/yanickrochon/moment","forks_url":"https://api.github.com/repos/yanickrochon/moment/forks","keys_url":"https://api.github.com/repos/yanickrochon/moment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yanickrochon/moment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yanickrochon/moment/teams","hooks_url":"https://api.github.com/repos/yanickrochon/moment/hooks","issue_events_url":"https://api.github.com/repos/yanickrochon/moment/issues/events{/number}","events_url":"https://api.github.com/repos/yanickrochon/moment/events","assignees_url":"https://api.github.com/repos/yanickrochon/moment/assignees{/user}","branches_url":"https://api.github.com/repos/yanickrochon/moment/branches{/branch}","tags_url":"https://api.github.com/repos/yanickrochon/moment/tags","blobs_url":"https://api.github.com/repos/yanickrochon/moment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yanickrochon/moment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yanickrochon/moment/git/refs{/sha}","trees_url":"https://api.github.com/repos/yanickrochon/moment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yanickrochon/moment/statuses/{sha}","languages_url":"https://api.github.com/repos/yanickrochon/moment/languages","stargazers_url":"https://api.github.com/repos/yanickrochon/moment/stargazers","contributors_url":"https://api.github.com/repos/yanickrochon/moment/contributors","subscribers_url":"https://api.github.com/repos/yanickrochon/moment/subscribers","subscription_url":"https://api.github.com/repos/yanickrochon/moment/subscription","commits_url":"https://api.github.com/repos/yanickrochon/moment/commits{/sha}","git_commits_url":"https://api.github.com/repos/yanickrochon/moment/git/commits{/sha}","comments_url":"https://api.github.com/repos/yanickrochon/moment/comments{/number}","issue_comment_url":"https://api.github.com/repos/yanickrochon/moment/issues/comments/{number}","contents_url":"https://api.github.com/repos/yanickrochon/moment/contents/{+path}","compare_url":"https://api.github.com/repos/yanickrochon/moment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yanickrochon/moment/merges","archive_url":"https://api.github.com/repos/yanickrochon/moment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yanickrochon/moment/downloads","issues_url":"https://api.github.com/repos/yanickrochon/moment/issues{/number}","pulls_url":"https://api.github.com/repos/yanickrochon/moment/pulls{/number}","milestones_url":"https://api.github.com/repos/yanickrochon/moment/milestones{/number}","notifications_url":"https://api.github.com/repos/yanickrochon/moment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yanickrochon/moment/labels{/name}","releases_url":"https://api.github.com/repos/yanickrochon/moment/releases{/id}","created_at":"2014-08-08T20:45:36Z","updated_at":"2014-08-08T20:53:24Z","pushed_at":"2014-08-08T20:53:24Z","git_url":"git://github.com/yanickrochon/moment.git","ssh_url":"git@github.com:yanickrochon/moment.git","clone_url":"https://github.com/yanickrochon/moment.git","svn_url":"https://github.com/yanickrochon/moment","homepage":"momentjs.com","size":14746,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"moment:develop","ref":"develop","sha":"6307ac453a8ea440b2ee811337ea761dbd40dca2","user":{"login":"moment","id":4129662,"avatar_url":"https://avatars.githubusercontent.com/u/4129662?v=2","gravatar_id":"dd6873e576c9b5afa3000fe812648d0a","url":"https://api.github.com/users/moment","html_url":"https://github.com/moment","followers_url":"https://api.github.com/users/moment/followers","following_url":"https://api.github.com/users/moment/following{/other_user}","gists_url":"https://api.github.com/users/moment/gists{/gist_id}","starred_url":"https://api.github.com/users/moment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moment/subscriptions","organizations_url":"https://api.github.com/users/moment/orgs","repos_url":"https://api.github.com/users/moment/repos","events_url":"https://api.github.com/users/moment/events{/privacy}","received_events_url":"https://api.github.com/users/moment/received_events","type":"Organization","site_admin":false},"repo":{"id":1424470,"name":"moment","full_name":"moment/moment","owner":{"login":"moment","id":4129662,"avatar_url":"https://avatars.githubusercontent.com/u/4129662?v=2","gravatar_id":"dd6873e576c9b5afa3000fe812648d0a","url":"https://api.github.com/users/moment","html_url":"https://github.com/moment","followers_url":"https://api.github.com/users/moment/followers","following_url":"https://api.github.com/users/moment/following{/other_user}","gists_url":"https://api.github.com/users/moment/gists{/gist_id}","starred_url":"https://api.github.com/users/moment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moment/subscriptions","organizations_url":"https://api.github.com/users/moment/orgs","repos_url":"https://api.github.com/users/moment/repos","events_url":"https://api.github.com/users/moment/events{/privacy}","received_events_url":"https://api.github.com/users/moment/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moment/moment","description":"Parse, validate, manipulate, and display dates in javascript.","fork":false,"url":"https://api.github.com/repos/moment/moment","forks_url":"https://api.github.com/repos/moment/moment/forks","keys_url":"https://api.github.com/repos/moment/moment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moment/moment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moment/moment/teams","hooks_url":"https://api.github.com/repos/moment/moment/hooks","issue_events_url":"https://api.github.com/repos/moment/moment/issues/events{/number}","events_url":"https://api.github.com/repos/moment/moment/events","assignees_url":"https://api.github.com/repos/moment/moment/assignees{/user}","branches_url":"https://api.github.com/repos/moment/moment/branches{/branch}","tags_url":"https://api.github.com/repos/moment/moment/tags","blobs_url":"https://api.github.com/repos/moment/moment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moment/moment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moment/moment/git/refs{/sha}","trees_url":"https://api.github.com/repos/moment/moment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moment/moment/statuses/{sha}","languages_url":"https://api.github.com/repos/moment/moment/languages","stargazers_url":"https://api.github.com/repos/moment/moment/stargazers","contributors_url":"https://api.github.com/repos/moment/moment/contributors","subscribers_url":"https://api.github.com/repos/moment/moment/subscribers","subscription_url":"https://api.github.com/repos/moment/moment/subscription","commits_url":"https://api.github.com/repos/moment/moment/commits{/sha}","git_commits_url":"https://api.github.com/repos/moment/moment/git/commits{/sha}","comments_url":"https://api.github.com/repos/moment/moment/comments{/number}","issue_comment_url":"https://api.github.com/repos/moment/moment/issues/comments/{number}","contents_url":"https://api.github.com/repos/moment/moment/contents/{+path}","compare_url":"https://api.github.com/repos/moment/moment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moment/moment/merges","archive_url":"https://api.github.com/repos/moment/moment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moment/moment/downloads","issues_url":"https://api.github.com/repos/moment/moment/issues{/number}","pulls_url":"https://api.github.com/repos/moment/moment/pulls{/number}","milestones_url":"https://api.github.com/repos/moment/moment/milestones{/number}","notifications_url":"https://api.github.com/repos/moment/moment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moment/moment/labels{/name}","releases_url":"https://api.github.com/repos/moment/moment/releases{/id}","created_at":"2011-03-01T02:46:06Z","updated_at":"2014-08-08T20:42:08Z","pushed_at":"2014-08-03T00:35:55Z","git_url":"git://github.com/moment/moment.git","ssh_url":"git@github.com:moment/moment.git","clone_url":"https://github.com/moment/moment.git","svn_url":"https://github.com/moment/moment","homepage":"momentjs.com","size":14746,"stargazers_count":17573,"watchers_count":17573,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":1649,"mirror_url":null,"open_issues_count":87,"forks":1649,"open_issues":87,"watchers":17573,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/moment/moment/pulls/1844"},"html":{"href":"https://github.com/moment/moment/pull/1844"},"issue":{"href":"https://api.github.com/repos/moment/moment/issues/1844"},"comments":{"href":"https://api.github.com/repos/moment/moment/issues/1844/comments"},"review_comments":{"href":"https://api.github.com/repos/moment/moment/pulls/1844/comments"},"review_comment":{"href":"https://api.github.com/repos/moment/moment/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/moment/moment/pulls/1844/commits"},"statuses":{"href":"https://api.github.com/repos/moment/moment/statuses/1de6f233da4697cd4ff87bb1d675ad53a5fe9636"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":23,"deletions":37,"changed_files":2}}