GitHub PullRequestReviewCommentEvent at 2014-10-25 22:24:28
Repository: main
Actor: lowjoel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/comments/19377892","id":19377892,"diff_hunk":"@@ -27,28 +27,28 @@ std::unique_ptr<Query> UpdateTask::getReverse() {\n \treturn std::unique_ptr<Query>(new UpdateTask(\n \t\tprevious.getID(), previous.getDescription(),\n \t\tprevious.getDeadline(), previous.getPriority(),\n-\t\tprevious.getDependencies()));\n+\t\tprevious.getDependencies(), previous.isCompleted()));\n }\n \n Task UpdateTask::buildUpdatedTask(const State& state) const {\n \tauto current = state.get().graph().getTask(this->id);\n \tauto builder = Controller::Builder::fromTask(current);\n-\tif (this->description == Task::DEFAULT_DESCRIPTION) {\n-\t\tbuilder.description(current.getDescription());\n-\t} else {\n-\t\tbuilder.description(this->description);\n+\tif (boost::optional<Task::Description> _ = this->description) {\n+\t\tbuilder.description(this->description.get());\n \t}\n-\tif (this->deadline != Task::DEFAULT_DEADLINE) {\n-\t\tbuilder.deadline(this->deadline);\n+\tif (boost::optional<Task::Time> _ = this->deadline) {","path":"You-QueryEngine/internal/action/update_task.cpp","position":20,"original_position":20,"commit_id":"43cd8e19d70cafa58c3c82cddfa85ce90a4de47d","original_commit_id":"43cd8e19d70cafa58c3c82cddfa85ce90a4de47d","user":{"login":"lowjoel","id":2505070,"avatar_url":"https://avatars.githubusercontent.com/u/2505070?v=2","gravatar_id":"","url":"https://api.github.com/users/lowjoel","html_url":"https://github.com/lowjoel","followers_url":"https://api.github.com/users/lowjoel/followers","following_url":"https://api.github.com/users/lowjoel/following{/other_user}","gists_url":"https://api.github.com/users/lowjoel/gists{/gist_id}","starred_url":"https://api.github.com/users/lowjoel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lowjoel/subscriptions","organizations_url":"https://api.github.com/users/lowjoel/orgs","repos_url":"https://api.github.com/users/lowjoel/repos","events_url":"https://api.github.com/users/lowjoel/events{/privacy}","received_events_url":"https://api.github.com/users/lowjoel/received_events","type":"User","site_admin":false},"body":"`if (static_cast<bool>(this->deadline))` ?","created_at":"2014-10-25T22:24:28Z","updated_at":"2014-10-25T22:24:28Z","html_url":"https://github.com/cs2103aug2014-w10-1c/main/pull/234#discussion_r19377892","pull_request_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/234","_links":{"self":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/comments/19377892"},"html":{"href":"https://github.com/cs2103aug2014-w10-1c/main/pull/234#discussion_r19377892"},"pull_request":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/234","id":23342641,"html_url":"https://github.com/cs2103aug2014-w10-1c/main/pull/234","diff_url":"https://github.com/cs2103aug2014-w10-1c/main/pull/234.diff","patch_url":"https://github.com/cs2103aug2014-w10-1c/main/pull/234.patch","issue_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues/234","number":234,"state":"open","locked":false,"title":"Miscellaneous fixes","user":{"login":"evansb","id":5389670,"avatar_url":"https://avatars.githubusercontent.com/u/5389670?v=2","gravatar_id":"","url":"https://api.github.com/users/evansb","html_url":"https://github.com/evansb","followers_url":"https://api.github.com/users/evansb/followers","following_url":"https://api.github.com/users/evansb/following{/other_user}","gists_url":"https://api.github.com/users/evansb/gists{/gist_id}","starred_url":"https://api.github.com/users/evansb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evansb/subscriptions","organizations_url":"https://api.github.com/users/evansb/orgs","repos_url":"https://api.github.com/users/evansb/repos","events_url":"https://api.github.com/users/evansb/events{/privacy}","received_events_url":"https://api.github.com/users/evansb/received_events","type":"User","site_admin":false},"body":"#150 - boost::optional in UpdateTask API call. \r\n#154 - to implement marking task done API call.\r\n #226 - for each and std::begin\r\n\r\n@lowjoel  Please remove You::NLP::TaskPriority since our enum name is now the same.\r\n","created_at":"2014-10-25T19:28:23Z","updated_at":"2014-10-25T22:24:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10588634614d5e41874bd54b5fe2a60804061d87","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/234/commits","review_comments_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/234/comments","review_comment_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues/234/comments","statuses_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/statuses/43cd8e19d70cafa58c3c82cddfa85ce90a4de47d","head":{"label":"evansb:implement-id-alg","ref":"implement-id-alg","sha":"43cd8e19d70cafa58c3c82cddfa85ce90a4de47d","user":{"login":"evansb","id":5389670,"avatar_url":"https://avatars.githubusercontent.com/u/5389670?v=2","gravatar_id":"","url":"https://api.github.com/users/evansb","html_url":"https://github.com/evansb","followers_url":"https://api.github.com/users/evansb/followers","following_url":"https://api.github.com/users/evansb/following{/other_user}","gists_url":"https://api.github.com/users/evansb/gists{/gist_id}","starred_url":"https://api.github.com/users/evansb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evansb/subscriptions","organizations_url":"https://api.github.com/users/evansb/orgs","repos_url":"https://api.github.com/users/evansb/repos","events_url":"https://api.github.com/users/evansb/events{/privacy}","received_events_url":"https://api.github.com/users/evansb/received_events","type":"User","site_admin":false},"repo":{"id":23569672,"name":"main","full_name":"evansb/main","owner":{"login":"evansb","id":5389670,"avatar_url":"https://avatars.githubusercontent.com/u/5389670?v=2","gravatar_id":"","url":"https://api.github.com/users/evansb","html_url":"https://github.com/evansb","followers_url":"https://api.github.com/users/evansb/followers","following_url":"https://api.github.com/users/evansb/following{/other_user}","gists_url":"https://api.github.com/users/evansb/gists{/gist_id}","starred_url":"https://api.github.com/users/evansb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evansb/subscriptions","organizations_url":"https://api.github.com/users/evansb/orgs","repos_url":"https://api.github.com/users/evansb/repos","events_url":"https://api.github.com/users/evansb/events{/privacy}","received_events_url":"https://api.github.com/users/evansb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evansb/main","description":"The You Task Management App","fork":true,"url":"https://api.github.com/repos/evansb/main","forks_url":"https://api.github.com/repos/evansb/main/forks","keys_url":"https://api.github.com/repos/evansb/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evansb/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evansb/main/teams","hooks_url":"https://api.github.com/repos/evansb/main/hooks","issue_events_url":"https://api.github.com/repos/evansb/main/issues/events{/number}","events_url":"https://api.github.com/repos/evansb/main/events","assignees_url":"https://api.github.com/repos/evansb/main/assignees{/user}","branches_url":"https://api.github.com/repos/evansb/main/branches{/branch}","tags_url":"https://api.github.com/repos/evansb/main/tags","blobs_url":"https://api.github.com/repos/evansb/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evansb/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evansb/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/evansb/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evansb/main/statuses/{sha}","languages_url":"https://api.github.com/repos/evansb/main/languages","stargazers_url":"https://api.github.com/repos/evansb/main/stargazers","contributors_url":"https://api.github.com/repos/evansb/main/contributors","subscribers_url":"https://api.github.com/repos/evansb/main/subscribers","subscription_url":"https://api.github.com/repos/evansb/main/subscription","commits_url":"https://api.github.com/repos/evansb/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/evansb/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/evansb/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/evansb/main/issues/comments/{number}","contents_url":"https://api.github.com/repos/evansb/main/contents/{+path}","compare_url":"https://api.github.com/repos/evansb/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evansb/main/merges","archive_url":"https://api.github.com/repos/evansb/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evansb/main/downloads","issues_url":"https://api.github.com/repos/evansb/main/issues{/number}","pulls_url":"https://api.github.com/repos/evansb/main/pulls{/number}","milestones_url":"https://api.github.com/repos/evansb/main/milestones{/number}","notifications_url":"https://api.github.com/repos/evansb/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evansb/main/labels{/name}","releases_url":"https://api.github.com/repos/evansb/main/releases{/id}","created_at":"2014-09-02T07:43:17Z","updated_at":"2014-09-16T14:57:34Z","pushed_at":"2014-10-25T19:26:10Z","git_url":"git://github.com/evansb/main.git","ssh_url":"git@github.com:evansb/main.git","clone_url":"https://github.com/evansb/main.git","svn_url":"https://github.com/evansb/main","homepage":null,"size":2122,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cs2103aug2014-w10-1c:master","ref":"master","sha":"0594458823c83ee57474f0a2eeeede102168606b","user":{"login":"cs2103aug2014-w10-1c","id":8623584,"avatar_url":"https://avatars.githubusercontent.com/u/8623584?v=2","gravatar_id":"","url":"https://api.github.com/users/cs2103aug2014-w10-1c","html_url":"https://github.com/cs2103aug2014-w10-1c","followers_url":"https://api.github.com/users/cs2103aug2014-w10-1c/followers","following_url":"https://api.github.com/users/cs2103aug2014-w10-1c/following{/other_user}","gists_url":"https://api.github.com/users/cs2103aug2014-w10-1c/gists{/gist_id}","starred_url":"https://api.github.com/users/cs2103aug2014-w10-1c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs2103aug2014-w10-1c/subscriptions","organizations_url":"https://api.github.com/users/cs2103aug2014-w10-1c/orgs","repos_url":"https://api.github.com/users/cs2103aug2014-w10-1c/repos","events_url":"https://api.github.com/users/cs2103aug2014-w10-1c/events{/privacy}","received_events_url":"https://api.github.com/users/cs2103aug2014-w10-1c/received_events","type":"Organization","site_admin":false},"repo":{"id":23566519,"name":"main","full_name":"cs2103aug2014-w10-1c/main","owner":{"login":"cs2103aug2014-w10-1c","id":8623584,"avatar_url":"https://avatars.githubusercontent.com/u/8623584?v=2","gravatar_id":"","url":"https://api.github.com/users/cs2103aug2014-w10-1c","html_url":"https://github.com/cs2103aug2014-w10-1c","followers_url":"https://api.github.com/users/cs2103aug2014-w10-1c/followers","following_url":"https://api.github.com/users/cs2103aug2014-w10-1c/following{/other_user}","gists_url":"https://api.github.com/users/cs2103aug2014-w10-1c/gists{/gist_id}","starred_url":"https://api.github.com/users/cs2103aug2014-w10-1c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs2103aug2014-w10-1c/subscriptions","organizations_url":"https://api.github.com/users/cs2103aug2014-w10-1c/orgs","repos_url":"https://api.github.com/users/cs2103aug2014-w10-1c/repos","events_url":"https://api.github.com/users/cs2103aug2014-w10-1c/events{/privacy}","received_events_url":"https://api.github.com/users/cs2103aug2014-w10-1c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cs2103aug2014-w10-1c/main","description":"The You Task Management App","fork":false,"url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main","forks_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/forks","keys_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/teams","hooks_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/hooks","issue_events_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues/events{/number}","events_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/events","assignees_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/assignees{/user}","branches_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/branches{/branch}","tags_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/tags","blobs_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/statuses/{sha}","languages_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/languages","stargazers_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/stargazers","contributors_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/contributors","subscribers_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/subscribers","subscription_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/subscription","commits_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues/comments/{number}","contents_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/contents/{+path}","compare_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/merges","archive_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/downloads","issues_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues{/number}","pulls_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls{/number}","milestones_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/milestones{/number}","notifications_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/labels{/name}","releases_url":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/releases{/id}","created_at":"2014-09-02T05:42:41Z","updated_at":"2014-10-11T09:10:11Z","pushed_at":"2014-10-25T02:42:14Z","git_url":"git://github.com/cs2103aug2014-w10-1c/main.git","ssh_url":"git@github.com:cs2103aug2014-w10-1c/main.git","clone_url":"https://github.com/cs2103aug2014-w10-1c/main.git","svn_url":"https://github.com/cs2103aug2014-w10-1c/main","homepage":null,"size":3577,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":32,"forks":4,"open_issues":32,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/234"},"html":{"href":"https://github.com/cs2103aug2014-w10-1c/main/pull/234"},"issue":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues/234"},"comments":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/cs2103aug2014-w10-1c/main/statuses/43cd8e19d70cafa58c3c82cddfa85ce90a4de47d"}}}}