GitHub PullRequestEvent at 2014-11-16 18:48:37
Repository: Spirit
Actor: nitely
Payload: {"action":"closed","number":26,"pull_request":{"url":"https://api.github.com/repos/nitely/Spirit/pulls/26","id":24105679,"html_url":"https://github.com/nitely/Spirit/pull/26","diff_url":"https://github.com/nitely/Spirit/pull/26.diff","patch_url":"https://github.com/nitely/Spirit/pull/26.patch","issue_url":"https://api.github.com/repos/nitely/Spirit/issues/26","number":26,"state":"closed","locked":false,"title":"Python3 support","user":{"login":"benjaminabel","id":1004282,"avatar_url":"https://avatars.githubusercontent.com/u/1004282?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminabel","html_url":"https://github.com/benjaminabel","followers_url":"https://api.github.com/users/benjaminabel/followers","following_url":"https://api.github.com/users/benjaminabel/following{/other_user}","gists_url":"https://api.github.com/users/benjaminabel/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminabel/subscriptions","organizations_url":"https://api.github.com/users/benjaminabel/orgs","repos_url":"https://api.github.com/users/benjaminabel/repos","events_url":"https://api.github.com/users/benjaminabel/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminabel/received_events","type":"User","site_admin":false},"body":"All tests works now in python 2.7 and 3.4. No test has been removed.\r\n\r\nThe method follows django project recommendations([Porting to python 3](https://docs.djangoproject.com/en/dev/topics/python3/))\r\n\r\n- `unicode_literals` evreywhere\r\n- changed the string representation of objects with the the `@python_2_unicode_compatible` decorator\r\n- relative imports changed\r\n- usage of `django.utils.six` methods when provided, or if if `six.PY2:` statement if not.\r\n- some assert methods changed\r\n- some string/bytes changes in json.loads(maybe we can use the django method provided in django 1.7), and in hashlib.\r\n\r\nI'm gonna try tun the app manually now to see if everything works, and maybe add some more tests to the app if not.\r\n","created_at":"2014-11-08T20:19:26Z","updated_at":"2014-11-16T18:48:37Z","closed_at":"2014-11-16T18:48:37Z","merged_at":"2014-11-16T18:48:37Z","merge_commit_sha":"eb29994fc85cd17fc9ab9d3dd89c57731cd58b21","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nitely/Spirit/pulls/26/commits","review_comments_url":"https://api.github.com/repos/nitely/Spirit/pulls/26/comments","review_comment_url":"https://api.github.com/repos/nitely/Spirit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nitely/Spirit/issues/26/comments","statuses_url":"https://api.github.com/repos/nitely/Spirit/statuses/9573fe67c1b6ad19f078ed39c8c85c30a6a9ce63","head":{"label":"benjaminabel:python3-support","ref":"python3-support","sha":"9573fe67c1b6ad19f078ed39c8c85c30a6a9ce63","user":{"login":"benjaminabel","id":1004282,"avatar_url":"https://avatars.githubusercontent.com/u/1004282?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminabel","html_url":"https://github.com/benjaminabel","followers_url":"https://api.github.com/users/benjaminabel/followers","following_url":"https://api.github.com/users/benjaminabel/following{/other_user}","gists_url":"https://api.github.com/users/benjaminabel/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminabel/subscriptions","organizations_url":"https://api.github.com/users/benjaminabel/orgs","repos_url":"https://api.github.com/users/benjaminabel/repos","events_url":"https://api.github.com/users/benjaminabel/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminabel/received_events","type":"User","site_admin":false},"repo":{"id":26121220,"name":"Spirit","full_name":"benjaminabel/Spirit","owner":{"login":"benjaminabel","id":1004282,"avatar_url":"https://avatars.githubusercontent.com/u/1004282?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminabel","html_url":"https://github.com/benjaminabel","followers_url":"https://api.github.com/users/benjaminabel/followers","following_url":"https://api.github.com/users/benjaminabel/following{/other_user}","gists_url":"https://api.github.com/users/benjaminabel/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminabel/subscriptions","organizations_url":"https://api.github.com/users/benjaminabel/orgs","repos_url":"https://api.github.com/users/benjaminabel/repos","events_url":"https://api.github.com/users/benjaminabel/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminabel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminabel/Spirit","description":"Spirit is a modern Python based forum built using the Django framework","fork":true,"url":"https://api.github.com/repos/benjaminabel/Spirit","forks_url":"https://api.github.com/repos/benjaminabel/Spirit/forks","keys_url":"https://api.github.com/repos/benjaminabel/Spirit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminabel/Spirit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminabel/Spirit/teams","hooks_url":"https://api.github.com/repos/benjaminabel/Spirit/hooks","issue_events_url":"https://api.github.com/repos/benjaminabel/Spirit/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminabel/Spirit/events","assignees_url":"https://api.github.com/repos/benjaminabel/Spirit/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminabel/Spirit/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminabel/Spirit/tags","blobs_url":"https://api.github.com/repos/benjaminabel/Spirit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminabel/Spirit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminabel/Spirit/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminabel/Spirit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminabel/Spirit/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminabel/Spirit/languages","stargazers_url":"https://api.github.com/repos/benjaminabel/Spirit/stargazers","contributors_url":"https://api.github.com/repos/benjaminabel/Spirit/contributors","subscribers_url":"https://api.github.com/repos/benjaminabel/Spirit/subscribers","subscription_url":"https://api.github.com/repos/benjaminabel/Spirit/subscription","commits_url":"https://api.github.com/repos/benjaminabel/Spirit/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminabel/Spirit/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminabel/Spirit/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminabel/Spirit/issues/comments/{number}","contents_url":"https://api.github.com/repos/benjaminabel/Spirit/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminabel/Spirit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminabel/Spirit/merges","archive_url":"https://api.github.com/repos/benjaminabel/Spirit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminabel/Spirit/downloads","issues_url":"https://api.github.com/repos/benjaminabel/Spirit/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminabel/Spirit/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminabel/Spirit/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminabel/Spirit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminabel/Spirit/labels{/name}","releases_url":"https://api.github.com/repos/benjaminabel/Spirit/releases{/id}","created_at":"2014-11-03T14:08:46Z","updated_at":"2014-11-03T14:08:45Z","pushed_at":"2014-11-15T18:05:11Z","git_url":"git://github.com/benjaminabel/Spirit.git","ssh_url":"git@github.com:benjaminabel/Spirit.git","clone_url":"https://github.com/benjaminabel/Spirit.git","svn_url":"https://github.com/benjaminabel/Spirit","homepage":"http://spirit-project.com/","size":2378,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nitely:master","ref":"master","sha":"3410c495b546cc83358d8b8858b0f2ff50b1bb9e","user":{"login":"nitely","id":1697267,"avatar_url":"https://avatars.githubusercontent.com/u/1697267?v=3","gravatar_id":"","url":"https://api.github.com/users/nitely","html_url":"https://github.com/nitely","followers_url":"https://api.github.com/users/nitely/followers","following_url":"https://api.github.com/users/nitely/following{/other_user}","gists_url":"https://api.github.com/users/nitely/gists{/gist_id}","starred_url":"https://api.github.com/users/nitely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitely/subscriptions","organizations_url":"https://api.github.com/users/nitely/orgs","repos_url":"https://api.github.com/users/nitely/repos","events_url":"https://api.github.com/users/nitely/events{/privacy}","received_events_url":"https://api.github.com/users/nitely/received_events","type":"User","site_admin":false},"repo":{"id":19626318,"name":"Spirit","full_name":"nitely/Spirit","owner":{"login":"nitely","id":1697267,"avatar_url":"https://avatars.githubusercontent.com/u/1697267?v=3","gravatar_id":"","url":"https://api.github.com/users/nitely","html_url":"https://github.com/nitely","followers_url":"https://api.github.com/users/nitely/followers","following_url":"https://api.github.com/users/nitely/following{/other_user}","gists_url":"https://api.github.com/users/nitely/gists{/gist_id}","starred_url":"https://api.github.com/users/nitely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitely/subscriptions","organizations_url":"https://api.github.com/users/nitely/orgs","repos_url":"https://api.github.com/users/nitely/repos","events_url":"https://api.github.com/users/nitely/events{/privacy}","received_events_url":"https://api.github.com/users/nitely/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nitely/Spirit","description":"Spirit is a modern Python based forum built using the Django framework","fork":false,"url":"https://api.github.com/repos/nitely/Spirit","forks_url":"https://api.github.com/repos/nitely/Spirit/forks","keys_url":"https://api.github.com/repos/nitely/Spirit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nitely/Spirit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nitely/Spirit/teams","hooks_url":"https://api.github.com/repos/nitely/Spirit/hooks","issue_events_url":"https://api.github.com/repos/nitely/Spirit/issues/events{/number}","events_url":"https://api.github.com/repos/nitely/Spirit/events","assignees_url":"https://api.github.com/repos/nitely/Spirit/assignees{/user}","branches_url":"https://api.github.com/repos/nitely/Spirit/branches{/branch}","tags_url":"https://api.github.com/repos/nitely/Spirit/tags","blobs_url":"https://api.github.com/repos/nitely/Spirit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nitely/Spirit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nitely/Spirit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nitely/Spirit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nitely/Spirit/statuses/{sha}","languages_url":"https://api.github.com/repos/nitely/Spirit/languages","stargazers_url":"https://api.github.com/repos/nitely/Spirit/stargazers","contributors_url":"https://api.github.com/repos/nitely/Spirit/contributors","subscribers_url":"https://api.github.com/repos/nitely/Spirit/subscribers","subscription_url":"https://api.github.com/repos/nitely/Spirit/subscription","commits_url":"https://api.github.com/repos/nitely/Spirit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nitely/Spirit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nitely/Spirit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nitely/Spirit/issues/comments/{number}","contents_url":"https://api.github.com/repos/nitely/Spirit/contents/{+path}","compare_url":"https://api.github.com/repos/nitely/Spirit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nitely/Spirit/merges","archive_url":"https://api.github.com/repos/nitely/Spirit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nitely/Spirit/downloads","issues_url":"https://api.github.com/repos/nitely/Spirit/issues{/number}","pulls_url":"https://api.github.com/repos/nitely/Spirit/pulls{/number}","milestones_url":"https://api.github.com/repos/nitely/Spirit/milestones{/number}","notifications_url":"https://api.github.com/repos/nitely/Spirit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nitely/Spirit/labels{/name}","releases_url":"https://api.github.com/repos/nitely/Spirit/releases{/id}","created_at":"2014-05-09T21:31:33Z","updated_at":"2014-11-14T08:55:41Z","pushed_at":"2014-11-16T18:48:37Z","git_url":"git://github.com/nitely/Spirit.git","ssh_url":"git@github.com:nitely/Spirit.git","clone_url":"https://github.com/nitely/Spirit.git","svn_url":"https://github.com/nitely/Spirit","homepage":"http://spirit-project.com/","size":3294,"stargazers_count":289,"watchers_count":289,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":5,"forks":57,"open_issues":5,"watchers":289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nitely/Spirit/pulls/26"},"html":{"href":"https://github.com/nitely/Spirit/pull/26"},"issue":{"href":"https://api.github.com/repos/nitely/Spirit/issues/26"},"comments":{"href":"https://api.github.com/repos/nitely/Spirit/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/nitely/Spirit/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/nitely/Spirit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nitely/Spirit/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/nitely/Spirit/statuses/9573fe67c1b6ad19f078ed39c8c85c30a6a9ce63"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nitely","id":1697267,"avatar_url":"https://avatars.githubusercontent.com/u/1697267?v=3","gravatar_id":"","url":"https://api.github.com/users/nitely","html_url":"https://github.com/nitely","followers_url":"https://api.github.com/users/nitely/followers","following_url":"https://api.github.com/users/nitely/following{/other_user}","gists_url":"https://api.github.com/users/nitely/gists{/gist_id}","starred_url":"https://api.github.com/users/nitely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitely/subscriptions","organizations_url":"https://api.github.com/users/nitely/orgs","repos_url":"https://api.github.com/users/nitely/repos","events_url":"https://api.github.com/users/nitely/events{/privacy}","received_events_url":"https://api.github.com/users/nitely/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"commits":17,"additions":666,"deletions":458,"changed_files":159}}