GitHub PullRequestReviewCommentEvent at 2014-10-01 15:47:29
Repository: UIZE-JavaScript-Framework
Actor: UIZE
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls/comments/18287339","id":18287339,"diff_hunk":"@@ -81,23 +81,26 @@ Uize.module ({\n \t\t\t\t\t\t\t\t\t\t: null\n \t\t\t\t\t\t\t\t;\n \t\t\t\t\t\t\t\t_xmlHttpRequest.abort();\n-\t\t\t\t\t\t\t\tm.fire({ name: 'XHR Load', responseText: _responseText });\n+\t\t\t\t\t\t\t\t// no args means no error\n \t\t\t\t\t\t\t\t_callback ();\n \t\t\t\t\t\t\t}\n \t\t\t\t\t\t\telse {\n-\t\t\t\t\t\t\t\t//alert ('There was a problem retrieving the data:\\n' + m._xmlHttpRequest.statusText);\n-\t\t\t\t\t\t\t  _xmlHttpRequest.abort();\n-\t\t\t\t\t\t\t  m.fire({ name: 'XHR Error', statusText: m._xmlHttpRequest.statusText });\n+\t\t\t\t\t\t\t\t_xmlHttpRequest.abort();\n+\n+\t\t\t\t\t\t\t\t// callback with error object\n+\t\t\t\t\t\t\t\t_callback ({\n+\t\t\t\t\t\t\t\t\tstatus: _xmlHttpRequest.status,\n+\t\t\t\t\t\t\t\t\tstatusText: _xmlHttpRequest.statusText\n+\t\t\t\t\t\t\t\t});\n \t\t\t\t\t\t\t}\n \t\t\t\t\t\t}\n \t\t\t\t\t};\n \n-\t\t\t\t\tif (_xmlHttpRequest.upload) { // test if XHR2\n-\t\t\t\t\t  _xmlHttpRequest.onprogress = function (_event) {\n-\t\t\t\t\t    // Pass on the event obj with our event name\n-\t\t\t\t\t    _event.name = 'XHR Progress';\n-\t\t\t\t\t    m.fire(_event);\n-\t\t\t\t\t  }\n+\t\t\t\t\tif (_xmlHttpRequest.upload) { // test if XHR2 upload support\n+\t\t\t\t\t\t_xmlHttpRequest.upload.onprogress = function (_event) {\n+\t\t\t\t\t\t\tm.fire({name: 'Progress', xhrEvent: _event});\n+\t\t\t\t\t\t\tm.fire ({ name: 'Progress', xhrEvent: _event });","path":"site-source/js/Uize/Comm/Ajax.js","position":43,"original_position":43,"commit_id":"0e310e5832aeb7fe91ee2ff27a6b9b5ecd47665a","original_commit_id":"0e310e5832aeb7fe91ee2ff27a6b9b5ecd47665a","user":{"login":"UIZE","id":656409,"avatar_url":"https://avatars.githubusercontent.com/u/656409?v=2","gravatar_id":"","url":"https://api.github.com/users/UIZE","html_url":"https://github.com/UIZE","followers_url":"https://api.github.com/users/UIZE/followers","following_url":"https://api.github.com/users/UIZE/following{/other_user}","gists_url":"https://api.github.com/users/UIZE/gists{/gist_id}","starred_url":"https://api.github.com/users/UIZE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UIZE/subscriptions","organizations_url":"https://api.github.com/users/UIZE/orgs","repos_url":"https://api.github.com/users/UIZE/repos","events_url":"https://api.github.com/users/UIZE/events{/privacy}","received_events_url":"https://api.github.com/users/UIZE/received_events","type":"User","site_admin":false},"body":"I guess we REALLY want to make sure that this event gets fired???","created_at":"2014-10-01T15:47:29Z","updated_at":"2014-10-01T15:47:29Z","html_url":"https://github.com/UIZE/UIZE-JavaScript-Framework/pull/49#discussion_r18287339","pull_request_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls/comments/18287339"},"html":{"href":"https://github.com/UIZE/UIZE-JavaScript-Framework/pull/49#discussion_r18287339"},"pull_request":{"href":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls/49","id":19745185,"html_url":"https://github.com/UIZE/UIZE-JavaScript-Framework/pull/49","diff_url":"https://github.com/UIZE/UIZE-JavaScript-Framework/pull/49.diff","patch_url":"https://github.com/UIZE/UIZE-JavaScript-Framework/pull/49.patch","issue_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/issues/49","number":49,"state":"open","locked":false,"title":"New Uize.Test subclasses + Uize.Comm updates + other goodies","user":{"login":"BenAtZazzle","id":726051,"avatar_url":"https://avatars.githubusercontent.com/u/726051?v=2","gravatar_id":"","url":"https://api.github.com/users/BenAtZazzle","html_url":"https://github.com/BenAtZazzle","followers_url":"https://api.github.com/users/BenAtZazzle/followers","following_url":"https://api.github.com/users/BenAtZazzle/following{/other_user}","gists_url":"https://api.github.com/users/BenAtZazzle/gists{/gist_id}","starred_url":"https://api.github.com/users/BenAtZazzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenAtZazzle/subscriptions","organizations_url":"https://api.github.com/users/BenAtZazzle/orgs","repos_url":"https://api.github.com/users/BenAtZazzle/repos","events_url":"https://api.github.com/users/BenAtZazzle/events{/privacy}","received_events_url":"https://api.github.com/users/BenAtZazzle/received_events","type":"User","site_admin":false},"body":"This pull request is highlighted by new `Uize.Test` subclasses aimed at providing helper methods for testing `Uize.Class` subclasses, `Uize.Widget` subclasses, and widget bindings.\r\n\r\nThere are also improvements to `Uize.Comm` and `Uize.Comm.Ajax` for error handling. The AJAX object would die before if an error occurred.\r\n\r\nThere are other miscellaneous fixes outlined in the commit logs.","created_at":"2014-08-13T19:00:46Z","updated_at":"2014-10-01T15:47:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3e0bcb42d42db0b24ee2ea532b1843ee21e6e1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls/49/commits","review_comments_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls/49/comments","review_comment_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/issues/49/comments","statuses_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/statuses/0e310e5832aeb7fe91ee2ff27a6b9b5ecd47665a","head":{"label":"zazzle:master","ref":"master","sha":"0e310e5832aeb7fe91ee2ff27a6b9b5ecd47665a","user":{"login":"zazzle","id":725103,"avatar_url":"https://avatars.githubusercontent.com/u/725103?v=2","gravatar_id":"","url":"https://api.github.com/users/zazzle","html_url":"https://github.com/zazzle","followers_url":"https://api.github.com/users/zazzle/followers","following_url":"https://api.github.com/users/zazzle/following{/other_user}","gists_url":"https://api.github.com/users/zazzle/gists{/gist_id}","starred_url":"https://api.github.com/users/zazzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zazzle/subscriptions","organizations_url":"https://api.github.com/users/zazzle/orgs","repos_url":"https://api.github.com/users/zazzle/repos","events_url":"https://api.github.com/users/zazzle/events{/privacy}","received_events_url":"https://api.github.com/users/zazzle/received_events","type":"Organization","site_admin":false},"repo":{"id":13051626,"name":"UIZE-JavaScript-Framework","full_name":"zazzle/UIZE-JavaScript-Framework","owner":{"login":"zazzle","id":725103,"avatar_url":"https://avatars.githubusercontent.com/u/725103?v=2","gravatar_id":"","url":"https://api.github.com/users/zazzle","html_url":"https://github.com/zazzle","followers_url":"https://api.github.com/users/zazzle/followers","following_url":"https://api.github.com/users/zazzle/following{/other_user}","gists_url":"https://api.github.com/users/zazzle/gists{/gist_id}","starred_url":"https://api.github.com/users/zazzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zazzle/subscriptions","organizations_url":"https://api.github.com/users/zazzle/orgs","repos_url":"https://api.github.com/users/zazzle/repos","events_url":"https://api.github.com/users/zazzle/events{/privacy}","received_events_url":"https://api.github.com/users/zazzle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zazzle/UIZE-JavaScript-Framework","description":"UIZE (pronounced \"you eyes\") is a powerful, open source, object oriented JavaScript framework - supporting widgets, AJAX, DOM, templates, and more.","fork":true,"url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework","forks_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/forks","keys_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/teams","hooks_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/hooks","issue_events_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/issues/events{/number}","events_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/events","assignees_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/assignees{/user}","branches_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/branches{/branch}","tags_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/tags","blobs_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/statuses/{sha}","languages_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/languages","stargazers_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/stargazers","contributors_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/contributors","subscribers_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/subscribers","subscription_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/subscription","commits_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/contents/{+path}","compare_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/merges","archive_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/downloads","issues_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/issues{/number}","pulls_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/pulls{/number}","milestones_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/milestones{/number}","notifications_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/labels{/name}","releases_url":"https://api.github.com/repos/zazzle/UIZE-JavaScript-Framework/releases{/id}","created_at":"2013-09-24T01:25:55Z","updated_at":"2014-08-13T02:42:48Z","pushed_at":"2014-09-17T18:21:51Z","git_url":"git://github.com/zazzle/UIZE-JavaScript-Framework.git","ssh_url":"git@github.com:zazzle/UIZE-JavaScript-Framework.git","clone_url":"https://github.com/zazzle/UIZE-JavaScript-Framework.git","svn_url":"https://github.com/zazzle/UIZE-JavaScript-Framework","homepage":"http://www.uize.com","size":25819,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"UIZE:master","ref":"master","sha":"296c26cd4ee5bd27f973eb50a99fa202657f74d7","user":{"login":"UIZE","id":656409,"avatar_url":"https://avatars.githubusercontent.com/u/656409?v=2","gravatar_id":"","url":"https://api.github.com/users/UIZE","html_url":"https://github.com/UIZE","followers_url":"https://api.github.com/users/UIZE/followers","following_url":"https://api.github.com/users/UIZE/following{/other_user}","gists_url":"https://api.github.com/users/UIZE/gists{/gist_id}","starred_url":"https://api.github.com/users/UIZE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UIZE/subscriptions","organizations_url":"https://api.github.com/users/UIZE/orgs","repos_url":"https://api.github.com/users/UIZE/repos","events_url":"https://api.github.com/users/UIZE/events{/privacy}","received_events_url":"https://api.github.com/users/UIZE/received_events","type":"User","site_admin":false},"repo":{"id":1523260,"name":"UIZE-JavaScript-Framework","full_name":"UIZE/UIZE-JavaScript-Framework","owner":{"login":"UIZE","id":656409,"avatar_url":"https://avatars.githubusercontent.com/u/656409?v=2","gravatar_id":"","url":"https://api.github.com/users/UIZE","html_url":"https://github.com/UIZE","followers_url":"https://api.github.com/users/UIZE/followers","following_url":"https://api.github.com/users/UIZE/following{/other_user}","gists_url":"https://api.github.com/users/UIZE/gists{/gist_id}","starred_url":"https://api.github.com/users/UIZE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UIZE/subscriptions","organizations_url":"https://api.github.com/users/UIZE/orgs","repos_url":"https://api.github.com/users/UIZE/repos","events_url":"https://api.github.com/users/UIZE/events{/privacy}","received_events_url":"https://api.github.com/users/UIZE/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/UIZE/UIZE-JavaScript-Framework","description":"UIZE (pronounced \"you eyes\") is a powerful, open source, object oriented JavaScript framework - supporting widgets, AJAX, DOM, templates, and more.","fork":false,"url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework","forks_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/forks","keys_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/teams","hooks_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/hooks","issue_events_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/issues/events{/number}","events_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/events","assignees_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/assignees{/user}","branches_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/branches{/branch}","tags_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/tags","blobs_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/statuses/{sha}","languages_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/languages","stargazers_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/stargazers","contributors_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/contributors","subscribers_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/subscribers","subscription_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/subscription","commits_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/contents/{+path}","compare_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/merges","archive_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/downloads","issues_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/issues{/number}","pulls_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls{/number}","milestones_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/milestones{/number}","notifications_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/labels{/name}","releases_url":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/releases{/id}","created_at":"2011-03-24T22:41:02Z","updated_at":"2014-09-23T05:21:38Z","pushed_at":"2014-09-30T22:59:24Z","git_url":"git://github.com/UIZE/UIZE-JavaScript-Framework.git","ssh_url":"git@github.com:UIZE/UIZE-JavaScript-Framework.git","clone_url":"https://github.com/UIZE/UIZE-JavaScript-Framework.git","svn_url":"https://github.com/UIZE/UIZE-JavaScript-Framework","homepage":"http://www.uize.com","size":30754,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":17,"forks":11,"open_issues":17,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls/49"},"html":{"href":"https://github.com/UIZE/UIZE-JavaScript-Framework/pull/49"},"issue":{"href":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/issues/49"},"comments":{"href":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/UIZE/UIZE-JavaScript-Framework/statuses/0e310e5832aeb7fe91ee2ff27a6b9b5ecd47665a"}}}}