GitHub PullRequestReviewCommentEvent at 2014-03-05 15:00:50
Repository: parameter-framework
Actor: krocard
Payload: {"comment":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/comments/10302113","id":10302113,"diff_hunk":"@@ -0,0 +1,58 @@\n+/*\n+ * Copyright (c) 2011-2014, Intel Corporation\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without modification,\n+ * are permitted provided that the following conditions are met:\n+ *\n+ * 1. Redistributions of source code must retain the above copyright notice, this\n+ * list of conditions and the following disclaimer.\n+ *\n+ * 2. Redistributions in binary form must reproduce the above copyright notice,\n+ * this list of conditions and the following disclaimer in the documentation and/or\n+ * other materials provided with the distribution.\n+ *\n+ * 3. Neither the name of the copyright holder nor the names of its contributors\n+ * may be used to endorse or promote products derived from this software without\n+ * specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\" AND\n+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED\n+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE\n+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR\n+ * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES\n+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;\n+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON\n+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS\n+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ */\n+#pragma once\n+\n+#include \"FormattedSubsystemObject.h\"\n+\n+class CMappingContext;\n+\n+class CSkeletonSubsystemObject : public CFormattedSubsystemObject\n+{\n+public:\n+    CSkeletonSubsystemObject(const string& strMappingValue, CInstanceConfigurableElement* pInstanceConfigurableElement, const CMappingContext& context);\n+\n+protected:\n+    // from CSubsystemObject\n+    // Sync to/from HW\n+    virtual bool sendToHW(string& strError);\n+    virtual bool receiveFromHW(string& strError);\n+\n+private:\n+    // Sync to/from HW\n+    virtual bool accessHW(bool bReceive, string& strError);\n+\n+protected:\n+    // Scalar parameter size for elementary access\n+    uint32_t _uiScalarSize;\n+    uint32_t _uiArraySize;","path":"skeleton-subsystem/SkeletonSubsystemObject.h","position":54,"original_position":54,"commit_id":"ad12cb6f1d4ac9f2c24171567f935693db211bd6","original_commit_id":"ad12cb6f1d4ac9f2c24171567f935693db211bd6","user":{"login":"krocard","id":6862950,"avatar_url":"https://gravatar.com/avatar/5a93d690c3691190ec55f2ab523873f6?d=https%3A%2F%2Fidenticons.github.com%2Feee43bb394f173621e5438f03db8740f.png&r=x","gravatar_id":"5a93d690c3691190ec55f2ab523873f6","url":"https://api.github.com/users/krocard","html_url":"https://github.com/krocard","followers_url":"https://api.github.com/users/krocard/followers","following_url":"https://api.github.com/users/krocard/following{/other_user}","gists_url":"https://api.github.com/users/krocard/gists{/gist_id}","starred_url":"https://api.github.com/users/krocard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krocard/subscriptions","organizations_url":"https://api.github.com/users/krocard/orgs","repos_url":"https://api.github.com/users/krocard/repos","events_url":"https://api.github.com/users/krocard/events{/privacy}","received_events_url":"https://api.github.com/users/krocard/received_events","type":"User","site_admin":false},"body":"I think that this mechanism (array and scalar) has been moved up to the base class.","created_at":"2014-03-05T15:00:50Z","updated_at":"2014-03-05T15:00:50Z","html_url":"https://github.com/01org/parameter-framework/pull/3#discussion_r10302113","pull_request_url":"https://api.github.com/repos/01org/parameter-framework/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/comments/10302113"},"html":{"href":"https://github.com/01org/parameter-framework/pull/3#discussion_r10302113"},"pull_request":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/3"}}}}