GitHub PullRequestReviewCommentEvent at 2014-07-09 23:36:20
Repository: sea-c16-javascript
Actor: hankyates
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls/comments/14742914","id":14742914,"diff_hunk":"@@ -0,0 +1,10 @@\n+// this function implements XOR\n+function preferredName(firstName, lastName){\n+\t\n+\tif ( !!firstName != !!lastName){\n+\t\t// notice, both: T,T  neither: F,F  just1st: T,F  just2nd: F,T\n+\t\t// SO, we have one or the other, but not both or neither :)\n+\t\treturn firstName + lastName","path":"students/ChristianTownsdin/Assign02 - XOR - preferredName()/preferredName.js","position":7,"original_position":7,"commit_id":"3e9542c64ecddad7eb9281330b3cf6313679ab6b","original_commit_id":"3e9542c64ecddad7eb9281330b3cf6313679ab6b","user":{"login":"hankyates","id":492010,"avatar_url":"https://avatars.githubusercontent.com/u/492010?","gravatar_id":"2b25725ad1d27ab6d0b467cc841581e0","url":"https://api.github.com/users/hankyates","html_url":"https://github.com/hankyates","followers_url":"https://api.github.com/users/hankyates/followers","following_url":"https://api.github.com/users/hankyates/following{/other_user}","gists_url":"https://api.github.com/users/hankyates/gists{/gist_id}","starred_url":"https://api.github.com/users/hankyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hankyates/subscriptions","organizations_url":"https://api.github.com/users/hankyates/orgs","repos_url":"https://api.github.com/users/hankyates/repos","events_url":"https://api.github.com/users/hankyates/events{/privacy}","received_events_url":"https://api.github.com/users/hankyates/received_events","type":"User","site_admin":false},"body":"we don't want to concat the two strings together. we want to return one or the other. ","created_at":"2014-07-09T23:36:20Z","updated_at":"2014-07-09T23:36:20Z","html_url":"https://github.com/codefellows/sea-c16-javascript/pull/65#discussion_r14742914","pull_request_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls/comments/14742914"},"html":{"href":"https://github.com/codefellows/sea-c16-javascript/pull/65#discussion_r14742914"},"pull_request":{"href":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls/65","id":18183913,"html_url":"https://github.com/codefellows/sea-c16-javascript/pull/65","diff_url":"https://github.com/codefellows/sea-c16-javascript/pull/65.diff","patch_url":"https://github.com/codefellows/sea-c16-javascript/pull/65.patch","issue_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/issues/65","number":65,"state":"open","title":"Readme.md and XOR assignment - preferredName()","user":{"login":"CTownsdin","id":5800039,"avatar_url":"https://avatars.githubusercontent.com/u/5800039?","gravatar_id":"6edba53178dc58413d02d16df3907039","url":"https://api.github.com/users/CTownsdin","html_url":"https://github.com/CTownsdin","followers_url":"https://api.github.com/users/CTownsdin/followers","following_url":"https://api.github.com/users/CTownsdin/following{/other_user}","gists_url":"https://api.github.com/users/CTownsdin/gists{/gist_id}","starred_url":"https://api.github.com/users/CTownsdin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CTownsdin/subscriptions","organizations_url":"https://api.github.com/users/CTownsdin/orgs","repos_url":"https://api.github.com/users/CTownsdin/repos","events_url":"https://api.github.com/users/CTownsdin/events{/privacy}","received_events_url":"https://api.github.com/users/CTownsdin/received_events","type":"User","site_admin":false},"body":"My first pull request.  Everything look good?","created_at":"2014-07-09T20:17:00Z","updated_at":"2014-07-09T23:36:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7755b22da0ab052f7ade1ee4e00a607a394781a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls/65/commits","review_comments_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls/65/comments","review_comment_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls/comments/{number}","comments_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/issues/65/comments","statuses_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/statuses/3e9542c64ecddad7eb9281330b3cf6313679ab6b","head":{"label":"CTownsdin:master","ref":"master","sha":"3e9542c64ecddad7eb9281330b3cf6313679ab6b","user":{"login":"CTownsdin","id":5800039,"avatar_url":"https://avatars.githubusercontent.com/u/5800039?","gravatar_id":"6edba53178dc58413d02d16df3907039","url":"https://api.github.com/users/CTownsdin","html_url":"https://github.com/CTownsdin","followers_url":"https://api.github.com/users/CTownsdin/followers","following_url":"https://api.github.com/users/CTownsdin/following{/other_user}","gists_url":"https://api.github.com/users/CTownsdin/gists{/gist_id}","starred_url":"https://api.github.com/users/CTownsdin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CTownsdin/subscriptions","organizations_url":"https://api.github.com/users/CTownsdin/orgs","repos_url":"https://api.github.com/users/CTownsdin/repos","events_url":"https://api.github.com/users/CTownsdin/events{/privacy}","received_events_url":"https://api.github.com/users/CTownsdin/received_events","type":"User","site_admin":false},"repo":{"id":21635817,"name":"sea-c16-javascript","full_name":"CTownsdin/sea-c16-javascript","owner":{"login":"CTownsdin","id":5800039,"avatar_url":"https://avatars.githubusercontent.com/u/5800039?","gravatar_id":"6edba53178dc58413d02d16df3907039","url":"https://api.github.com/users/CTownsdin","html_url":"https://github.com/CTownsdin","followers_url":"https://api.github.com/users/CTownsdin/followers","following_url":"https://api.github.com/users/CTownsdin/following{/other_user}","gists_url":"https://api.github.com/users/CTownsdin/gists{/gist_id}","starred_url":"https://api.github.com/users/CTownsdin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CTownsdin/subscriptions","organizations_url":"https://api.github.com/users/CTownsdin/orgs","repos_url":"https://api.github.com/users/CTownsdin/repos","events_url":"https://api.github.com/users/CTownsdin/events{/privacy}","received_events_url":"https://api.github.com/users/CTownsdin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CTownsdin/sea-c16-javascript","description":"Code repository for the Foundation 2 Night Course","fork":true,"url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript","forks_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/forks","keys_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/teams","hooks_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/hooks","issue_events_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/events","assignees_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/tags","blobs_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/languages","stargazers_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/stargazers","contributors_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/contributors","subscribers_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/subscribers","subscription_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/subscription","commits_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/issues/comments/{number}","contents_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/merges","archive_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/downloads","issues_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/labels{/name}","releases_url":"https://api.github.com/repos/CTownsdin/sea-c16-javascript/releases{/id}","created_at":"2014-07-09T02:07:22Z","updated_at":"2014-07-09T04:45:30Z","pushed_at":"2014-07-09T20:08:04Z","git_url":"git://github.com/CTownsdin/sea-c16-javascript.git","ssh_url":"git@github.com:CTownsdin/sea-c16-javascript.git","clone_url":"https://github.com/CTownsdin/sea-c16-javascript.git","svn_url":"https://github.com/CTownsdin/sea-c16-javascript","homepage":"","size":185,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codefellows:master","ref":"master","sha":"207b3a499cbd33e5e29d6313184f2cbc4ec3617f","user":{"login":"codefellows","id":3904529,"avatar_url":"https://avatars.githubusercontent.com/u/3904529?","gravatar_id":"b2ed2a844e2a8cc31c8f4313fbaff424","url":"https://api.github.com/users/codefellows","html_url":"https://github.com/codefellows","followers_url":"https://api.github.com/users/codefellows/followers","following_url":"https://api.github.com/users/codefellows/following{/other_user}","gists_url":"https://api.github.com/users/codefellows/gists{/gist_id}","starred_url":"https://api.github.com/users/codefellows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codefellows/subscriptions","organizations_url":"https://api.github.com/users/codefellows/orgs","repos_url":"https://api.github.com/users/codefellows/repos","events_url":"https://api.github.com/users/codefellows/events{/privacy}","received_events_url":"https://api.github.com/users/codefellows/received_events","type":"Organization","site_admin":false},"repo":{"id":21432988,"name":"sea-c16-javascript","full_name":"codefellows/sea-c16-javascript","owner":{"login":"codefellows","id":3904529,"avatar_url":"https://avatars.githubusercontent.com/u/3904529?","gravatar_id":"b2ed2a844e2a8cc31c8f4313fbaff424","url":"https://api.github.com/users/codefellows","html_url":"https://github.com/codefellows","followers_url":"https://api.github.com/users/codefellows/followers","following_url":"https://api.github.com/users/codefellows/following{/other_user}","gists_url":"https://api.github.com/users/codefellows/gists{/gist_id}","starred_url":"https://api.github.com/users/codefellows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codefellows/subscriptions","organizations_url":"https://api.github.com/users/codefellows/orgs","repos_url":"https://api.github.com/users/codefellows/repos","events_url":"https://api.github.com/users/codefellows/events{/privacy}","received_events_url":"https://api.github.com/users/codefellows/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codefellows/sea-c16-javascript","description":"Code repository for the Foundation 2 Night Course","fork":false,"url":"https://api.github.com/repos/codefellows/sea-c16-javascript","forks_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/forks","keys_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/teams","hooks_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/hooks","issue_events_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/events","assignees_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/tags","blobs_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/languages","stargazers_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/stargazers","contributors_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/contributors","subscribers_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/subscribers","subscription_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/subscription","commits_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/issues/comments/{number}","contents_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/merges","archive_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/downloads","issues_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/labels{/name}","releases_url":"https://api.github.com/repos/codefellows/sea-c16-javascript/releases{/id}","created_at":"2014-07-02T17:17:36Z","updated_at":"2014-07-08T19:28:08Z","pushed_at":"2014-07-09T22:43:39Z","git_url":"git://github.com/codefellows/sea-c16-javascript.git","ssh_url":"git@github.com:codefellows/sea-c16-javascript.git","clone_url":"https://github.com/codefellows/sea-c16-javascript.git","svn_url":"https://github.com/codefellows/sea-c16-javascript","homepage":"","size":1137,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":46,"mirror_url":null,"open_issues_count":19,"forks":46,"open_issues":19,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls/65"},"html":{"href":"https://github.com/codefellows/sea-c16-javascript/pull/65"},"issue":{"href":"https://api.github.com/repos/codefellows/sea-c16-javascript/issues/65"},"comments":{"href":"https://api.github.com/repos/codefellows/sea-c16-javascript/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/codefellows/sea-c16-javascript/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/codefellows/sea-c16-javascript/statuses/3e9542c64ecddad7eb9281330b3cf6313679ab6b"}}}}