GitHub PullRequestReviewCommentEvent at 2014-11-05 22:35:19
Repository: pkp-lib
Actor: MichaelThessel
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pkp/pkp-lib/pulls/comments/19912342","id":19912342,"diff_hunk":"@@ -86,6 +86,28 @@ static function setConfigFileName($configFile) {\n \tstatic function getConfigFileName() {\n \t\treturn Registry::get('configFile', true, CONFIG_FILE);\n \t}\n-}\n \n+\t/**\n+\t * Get context base urls from config file.\n+\t * @return array Empty array if none is set.\n+\t */\n+\tfunction &getContextBaseUrls() {\n+\t\t$contextBaseUrls =& Registry::get('contextBaseUrls'); // Reference required.\n+\n+\t\tif (is_null($contextBaseUrls)) {\n+\t\t\t$contextBaseUrls = array();\n+\t\t\t$configData = Config::getData();\n+\t\t\t// Filter the settings.\n+\t\t\tforeach ($configData['general'] as $settingName => $settingValue) {\n+\t\t\t\t$matches = null;","path":"classes/config/Config.inc.php","position":18,"original_position":18,"commit_id":"5d4fbe641ec23f2c10f0dbd0f031af82aa306902","original_commit_id":"5d4fbe641ec23f2c10f0dbd0f031af82aa306902","user":{"login":"MichaelThessel","id":2926266,"avatar_url":"https://avatars.githubusercontent.com/u/2926266?v=2","gravatar_id":"","url":"https://api.github.com/users/MichaelThessel","html_url":"https://github.com/MichaelThessel","followers_url":"https://api.github.com/users/MichaelThessel/followers","following_url":"https://api.github.com/users/MichaelThessel/following{/other_user}","gists_url":"https://api.github.com/users/MichaelThessel/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelThessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelThessel/subscriptions","organizations_url":"https://api.github.com/users/MichaelThessel/orgs","repos_url":"https://api.github.com/users/MichaelThessel/repos","events_url":"https://api.github.com/users/MichaelThessel/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelThessel/received_events","type":"User","site_admin":false},"body":"That could be before the foreach, as preg_match() will do the reset anyway.","created_at":"2014-11-05T22:35:19Z","updated_at":"2014-11-05T22:35:19Z","html_url":"https://github.com/pkp/pkp-lib/pull/212#discussion_r19912342","pull_request_url":"https://api.github.com/repos/pkp/pkp-lib/pulls/212","_links":{"self":{"href":"https://api.github.com/repos/pkp/pkp-lib/pulls/comments/19912342"},"html":{"href":"https://github.com/pkp/pkp-lib/pull/212#discussion_r19912342"},"pull_request":{"href":"https://api.github.com/repos/pkp/pkp-lib/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/pkp/pkp-lib/pulls/212","id":23836674,"html_url":"https://github.com/pkp/pkp-lib/pull/212","diff_url":"https://github.com/pkp/pkp-lib/pull/212.diff","patch_url":"https://github.com/pkp/pkp-lib/pull/212.patch","issue_url":"https://api.github.com/repos/pkp/pkp-lib/issues/212","number":212,"state":"open","locked":false,"title":"*8996* Porting stats fixes","user":{"login":"beghelli","id":593977,"avatar_url":"https://avatars.githubusercontent.com/u/593977?v=2","gravatar_id":"","url":"https://api.github.com/users/beghelli","html_url":"https://github.com/beghelli","followers_url":"https://api.github.com/users/beghelli/followers","following_url":"https://api.github.com/users/beghelli/following{/other_user}","gists_url":"https://api.github.com/users/beghelli/gists{/gist_id}","starred_url":"https://api.github.com/users/beghelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beghelli/subscriptions","organizations_url":"https://api.github.com/users/beghelli/orgs","repos_url":"https://api.github.com/users/beghelli/repos","events_url":"https://api.github.com/users/beghelli/events{/privacy}","received_events_url":"https://api.github.com/users/beghelli/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-04T14:55:48Z","updated_at":"2014-11-05T22:35:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e158c1c4318d13e5028e756d096a516cfb007d43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pkp/pkp-lib/pulls/212/commits","review_comments_url":"https://api.github.com/repos/pkp/pkp-lib/pulls/212/comments","review_comment_url":"https://api.github.com/repos/pkp/pkp-lib/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pkp/pkp-lib/issues/212/comments","statuses_url":"https://api.github.com/repos/pkp/pkp-lib/statuses/5d4fbe641ec23f2c10f0dbd0f031af82aa306902","head":{"label":"beghelli:8996-fix","ref":"8996-fix","sha":"5d4fbe641ec23f2c10f0dbd0f031af82aa306902","user":{"login":"beghelli","id":593977,"avatar_url":"https://avatars.githubusercontent.com/u/593977?v=2","gravatar_id":"","url":"https://api.github.com/users/beghelli","html_url":"https://github.com/beghelli","followers_url":"https://api.github.com/users/beghelli/followers","following_url":"https://api.github.com/users/beghelli/following{/other_user}","gists_url":"https://api.github.com/users/beghelli/gists{/gist_id}","starred_url":"https://api.github.com/users/beghelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beghelli/subscriptions","organizations_url":"https://api.github.com/users/beghelli/orgs","repos_url":"https://api.github.com/users/beghelli/repos","events_url":"https://api.github.com/users/beghelli/events{/privacy}","received_events_url":"https://api.github.com/users/beghelli/received_events","type":"User","site_admin":false},"repo":{"id":1314760,"name":"pkp-lib","full_name":"beghelli/pkp-lib","owner":{"login":"beghelli","id":593977,"avatar_url":"https://avatars.githubusercontent.com/u/593977?v=2","gravatar_id":"","url":"https://api.github.com/users/beghelli","html_url":"https://github.com/beghelli","followers_url":"https://api.github.com/users/beghelli/followers","following_url":"https://api.github.com/users/beghelli/following{/other_user}","gists_url":"https://api.github.com/users/beghelli/gists{/gist_id}","starred_url":"https://api.github.com/users/beghelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beghelli/subscriptions","organizations_url":"https://api.github.com/users/beghelli/orgs","repos_url":"https://api.github.com/users/beghelli/repos","events_url":"https://api.github.com/users/beghelli/events{/privacy}","received_events_url":"https://api.github.com/users/beghelli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beghelli/pkp-lib","description":"PKP Web Application Library","fork":true,"url":"https://api.github.com/repos/beghelli/pkp-lib","forks_url":"https://api.github.com/repos/beghelli/pkp-lib/forks","keys_url":"https://api.github.com/repos/beghelli/pkp-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beghelli/pkp-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beghelli/pkp-lib/teams","hooks_url":"https://api.github.com/repos/beghelli/pkp-lib/hooks","issue_events_url":"https://api.github.com/repos/beghelli/pkp-lib/issues/events{/number}","events_url":"https://api.github.com/repos/beghelli/pkp-lib/events","assignees_url":"https://api.github.com/repos/beghelli/pkp-lib/assignees{/user}","branches_url":"https://api.github.com/repos/beghelli/pkp-lib/branches{/branch}","tags_url":"https://api.github.com/repos/beghelli/pkp-lib/tags","blobs_url":"https://api.github.com/repos/beghelli/pkp-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beghelli/pkp-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beghelli/pkp-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/beghelli/pkp-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beghelli/pkp-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/beghelli/pkp-lib/languages","stargazers_url":"https://api.github.com/repos/beghelli/pkp-lib/stargazers","contributors_url":"https://api.github.com/repos/beghelli/pkp-lib/contributors","subscribers_url":"https://api.github.com/repos/beghelli/pkp-lib/subscribers","subscription_url":"https://api.github.com/repos/beghelli/pkp-lib/subscription","commits_url":"https://api.github.com/repos/beghelli/pkp-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/beghelli/pkp-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/beghelli/pkp-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/beghelli/pkp-lib/issues/comments/{number}","contents_url":"https://api.github.com/repos/beghelli/pkp-lib/contents/{+path}","compare_url":"https://api.github.com/repos/beghelli/pkp-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beghelli/pkp-lib/merges","archive_url":"https://api.github.com/repos/beghelli/pkp-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beghelli/pkp-lib/downloads","issues_url":"https://api.github.com/repos/beghelli/pkp-lib/issues{/number}","pulls_url":"https://api.github.com/repos/beghelli/pkp-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/beghelli/pkp-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/beghelli/pkp-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beghelli/pkp-lib/labels{/name}","releases_url":"https://api.github.com/repos/beghelli/pkp-lib/releases{/id}","created_at":"2011-02-01T02:38:54Z","updated_at":"2014-06-24T08:29:49Z","pushed_at":"2014-11-04T14:52:35Z","git_url":"git://github.com/beghelli/pkp-lib.git","ssh_url":"git@github.com:beghelli/pkp-lib.git","clone_url":"https://github.com/beghelli/pkp-lib.git","svn_url":"https://github.com/beghelli/pkp-lib","homepage":"http://pkp.sfu.ca","size":31875,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"dev"}},"base":{"label":"pkp:omp-stable-1_1","ref":"omp-stable-1_1","sha":"f0bb5a6924a9ef228f1198f6113787d12d46d0b3","user":{"login":"pkp","id":130896,"avatar_url":"https://avatars.githubusercontent.com/u/130896?v=2","gravatar_id":"","url":"https://api.github.com/users/pkp","html_url":"https://github.com/pkp","followers_url":"https://api.github.com/users/pkp/followers","following_url":"https://api.github.com/users/pkp/following{/other_user}","gists_url":"https://api.github.com/users/pkp/gists{/gist_id}","starred_url":"https://api.github.com/users/pkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkp/subscriptions","organizations_url":"https://api.github.com/users/pkp/orgs","repos_url":"https://api.github.com/users/pkp/repos","events_url":"https://api.github.com/users/pkp/events{/privacy}","received_events_url":"https://api.github.com/users/pkp/received_events","type":"Organization","site_admin":false},"repo":{"id":316712,"name":"pkp-lib","full_name":"pkp/pkp-lib","owner":{"login":"pkp","id":130896,"avatar_url":"https://avatars.githubusercontent.com/u/130896?v=2","gravatar_id":"","url":"https://api.github.com/users/pkp","html_url":"https://github.com/pkp","followers_url":"https://api.github.com/users/pkp/followers","following_url":"https://api.github.com/users/pkp/following{/other_user}","gists_url":"https://api.github.com/users/pkp/gists{/gist_id}","starred_url":"https://api.github.com/users/pkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkp/subscriptions","organizations_url":"https://api.github.com/users/pkp/orgs","repos_url":"https://api.github.com/users/pkp/repos","events_url":"https://api.github.com/users/pkp/events{/privacy}","received_events_url":"https://api.github.com/users/pkp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pkp/pkp-lib","description":"PKP Web Application Library","fork":false,"url":"https://api.github.com/repos/pkp/pkp-lib","forks_url":"https://api.github.com/repos/pkp/pkp-lib/forks","keys_url":"https://api.github.com/repos/pkp/pkp-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkp/pkp-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkp/pkp-lib/teams","hooks_url":"https://api.github.com/repos/pkp/pkp-lib/hooks","issue_events_url":"https://api.github.com/repos/pkp/pkp-lib/issues/events{/number}","events_url":"https://api.github.com/repos/pkp/pkp-lib/events","assignees_url":"https://api.github.com/repos/pkp/pkp-lib/assignees{/user}","branches_url":"https://api.github.com/repos/pkp/pkp-lib/branches{/branch}","tags_url":"https://api.github.com/repos/pkp/pkp-lib/tags","blobs_url":"https://api.github.com/repos/pkp/pkp-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkp/pkp-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkp/pkp-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkp/pkp-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkp/pkp-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/pkp/pkp-lib/languages","stargazers_url":"https://api.github.com/repos/pkp/pkp-lib/stargazers","contributors_url":"https://api.github.com/repos/pkp/pkp-lib/contributors","subscribers_url":"https://api.github.com/repos/pkp/pkp-lib/subscribers","subscription_url":"https://api.github.com/repos/pkp/pkp-lib/subscription","commits_url":"https://api.github.com/repos/pkp/pkp-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkp/pkp-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkp/pkp-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkp/pkp-lib/issues/comments/{number}","contents_url":"https://api.github.com/repos/pkp/pkp-lib/contents/{+path}","compare_url":"https://api.github.com/repos/pkp/pkp-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkp/pkp-lib/merges","archive_url":"https://api.github.com/repos/pkp/pkp-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkp/pkp-lib/downloads","issues_url":"https://api.github.com/repos/pkp/pkp-lib/issues{/number}","pulls_url":"https://api.github.com/repos/pkp/pkp-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/pkp/pkp-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/pkp/pkp-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkp/pkp-lib/labels{/name}","releases_url":"https://api.github.com/repos/pkp/pkp-lib/releases{/id}","created_at":"2009-09-24T19:30:31Z","updated_at":"2014-11-04T17:39:46Z","pushed_at":"2014-11-05T22:31:36Z","git_url":"git://github.com/pkp/pkp-lib.git","ssh_url":"git@github.com:pkp/pkp-lib.git","clone_url":"https://github.com/pkp/pkp-lib.git","svn_url":"https://github.com/pkp/pkp-lib","homepage":"http://pkp.sfu.ca","size":49830,"stargazers_count":44,"watchers_count":44,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":14,"forks":103,"open_issues":14,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pkp/pkp-lib/pulls/212"},"html":{"href":"https://github.com/pkp/pkp-lib/pull/212"},"issue":{"href":"https://api.github.com/repos/pkp/pkp-lib/issues/212"},"comments":{"href":"https://api.github.com/repos/pkp/pkp-lib/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/pkp/pkp-lib/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/pkp/pkp-lib/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pkp/pkp-lib/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/pkp/pkp-lib/statuses/5d4fbe641ec23f2c10f0dbd0f031af82aa306902"}}}}