GitHub PullRequestReviewCommentEvent at 2014-03-09 21:56:36
Repository: intern
Actor: csnover
Payload: {"comment":{"url":"https://api.github.com/repos/theintern/intern/pulls/comments/10416018","id":10416018,"diff_hunk":"@@ -4,15 +4,23 @@ define([\n \t'dojo/node!wd/lib/webdriver',\n \t'dojo/node!wd/lib/element',\n \t'dojo/node!wd/lib/utils',\n+\t'dojo/node!chai',\n+\t'dojo/node!chai-as-promised',\n \t'dojo/promise/when',\n \t'dojo/Deferred',\n \t'dojo/topic',\n \t'./util'\n-], function (wd, WebDriver, Element, wdUtils, when, Deferred, topic, util) {\n+], function (wd, WebDriver, Element, wdUtils, chai, chaiAsPromised, when, Deferred, topic, util) {\n \tif (!wd) {\n \t\tthrow new Error('wd cannot be loaded in a browser environment');\n \t}\n \n+\tchai.use(chaiAsPromised);\n+\tchai.should();\n+\n+\t// Figure out how to do this with the intern wrapper promises instead.\n+\t// chaiAsPromised.transferPromiseness = wd.transferPromiseness;","path":"lib/wd.js","position":20,"original_position":20,"commit_id":"100595a315d150766d444a9d6559c01ca48bcf83","original_commit_id":"100595a315d150766d444a9d6559c01ca48bcf83","user":{"login":"csnover","id":229244,"avatar_url":"https://gravatar.com/avatar/ffe1561ee79aea59ef8a68a56c365883?d=https%3A%2F%2Fidenticons.github.com%2Fba723902f43ea7c03137cb226ed205a0.png&r=x","gravatar_id":"ffe1561ee79aea59ef8a68a56c365883","url":"https://api.github.com/users/csnover","html_url":"https://github.com/csnover","followers_url":"https://api.github.com/users/csnover/followers","following_url":"https://api.github.com/users/csnover/following{/other_user}","gists_url":"https://api.github.com/users/csnover/gists{/gist_id}","starred_url":"https://api.github.com/users/csnover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csnover/subscriptions","organizations_url":"https://api.github.com/users/csnover/orgs","repos_url":"https://api.github.com/users/csnover/repos","events_url":"https://api.github.com/users/csnover/events{/privacy}","received_events_url":"https://api.github.com/users/csnover/received_events","type":"User","site_admin":false},"body":"Since the `chai` object is exposed directly now (so you can call `chai.use` yourself), is this the primary change that needs to happen for this to work?","created_at":"2014-03-09T21:56:36Z","updated_at":"2014-03-09T21:56:36Z","html_url":"https://github.com/theintern/intern/pull/140#discussion_r10416018","pull_request_url":"https://api.github.com/repos/theintern/intern/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/theintern/intern/pulls/comments/10416018"},"html":{"href":"https://github.com/theintern/intern/pull/140#discussion_r10416018"},"pull_request":{"href":"https://api.github.com/repos/theintern/intern/pulls/140"}}}}