GitHub PullRequestEvent at 2014-02-21 09:37:37
Repository: image-diff
Actor: twolfson
Payload: {"action":"opened","number":11,"pull_request":{"url":"https://api.github.com/repos/uber/image-diff/pulls/11","id":12785167,"html_url":"https://github.com/uber/image-diff/pull/11","diff_url":"https://github.com/uber/image-diff/pull/11.diff","patch_url":"https://github.com/uber/image-diff/pull/11.patch","issue_url":"https://api.github.com/repos/uber/image-diff/issues/11","number":11,"state":"open","title":"Moved to consistently use ImageMagick and fixed image scaling regression","user":{"login":"twolfson","id":902488,"avatar_url":"https://gravatar.com/avatar/15927fc52919e9223adc7ed99e125d4d?d=https%3A%2F%2Fidenticons.github.com%2Fef02d6735f7e5b86afa52578dd6f9002.png&r=x","gravatar_id":"15927fc52919e9223adc7ed99e125d4d","url":"https://api.github.com/users/twolfson","html_url":"https://github.com/twolfson","followers_url":"https://api.github.com/users/twolfson/followers","following_url":"https://api.github.com/users/twolfson/following{/other_user}","gists_url":"https://api.github.com/users/twolfson/gists{/gist_id}","starred_url":"https://api.github.com/users/twolfson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twolfson/subscriptions","organizations_url":"https://api.github.com/users/twolfson/orgs","repos_url":"https://api.github.com/users/twolfson/repos","events_url":"https://api.github.com/users/twolfson/events{/privacy}","received_events_url":"https://api.github.com/users/twolfson/received_events","type":"User","site_admin":false},"body":"This PR is a mixed bag of many things that impact one another. It could have come in a different series but the process of development (beginning with fixing #9) lead to this united changeset. In this PR:\r\n\r\n- Thin test suite by moving to utility functions\r\n- Move to use ImageMagick for all external commands (previously mixed with GraphicsMagick)\r\n    - Fixes #4 \r\n- Updated README with ImageMagick change\r\n- Added regression tests for #9 and fixed issue\r\n    - Previously, we were scaling images instead of cropping and adding transparent padding\r\n\r\n/cc @mlmorg @Raynos ","created_at":"2014-02-21T09:37:37Z","updated_at":"2014-02-21T09:37:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/image-diff/pulls/11/commits","review_comments_url":"https://api.github.com/repos/uber/image-diff/pulls/11/comments","review_comment_url":"https://api.github.com/repos/uber/image-diff/pulls/comments/{number}","comments_url":"https://api.github.com/repos/uber/image-diff/issues/11/comments","statuses_url":"https://api.github.com/repos/uber/image-diff/statuses/ae87bde0485db754397ee4eab981575cf5cba4de","head":{"label":"uber:dev/compare.different.sizes.sqwished","ref":"dev/compare.different.sizes.sqwished","sha":"ae87bde0485db754397ee4eab981575cf5cba4de","user":{"login":"uber","id":538264,"avatar_url":"https://gravatar.com/avatar/e1aec73712d4c21ab7c7c1561133f65c?d=https%3A%2F%2Fidenticons.github.com%2Fefefd996f0306f9590c7e8646e9af92c.png&r=x","gravatar_id":"e1aec73712d4c21ab7c7c1561133f65c","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":14439422,"name":"image-diff","full_name":"uber/image-diff","owner":{"login":"uber","id":538264,"avatar_url":"https://gravatar.com/avatar/e1aec73712d4c21ab7c7c1561133f65c?d=https%3A%2F%2Fidenticons.github.com%2Fefefd996f0306f9590c7e8646e9af92c.png&r=x","gravatar_id":"e1aec73712d4c21ab7c7c1561133f65c","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/image-diff","description":"Create image differential between two images","fork":false,"url":"https://api.github.com/repos/uber/image-diff","forks_url":"https://api.github.com/repos/uber/image-diff/forks","keys_url":"https://api.github.com/repos/uber/image-diff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/image-diff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/image-diff/teams","hooks_url":"https://api.github.com/repos/uber/image-diff/hooks","issue_events_url":"https://api.github.com/repos/uber/image-diff/issues/events{/number}","events_url":"https://api.github.com/repos/uber/image-diff/events","assignees_url":"https://api.github.com/repos/uber/image-diff/assignees{/user}","branches_url":"https://api.github.com/repos/uber/image-diff/branches{/branch}","tags_url":"https://api.github.com/repos/uber/image-diff/tags","blobs_url":"https://api.github.com/repos/uber/image-diff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/image-diff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/image-diff/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/image-diff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/image-diff/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/image-diff/languages","stargazers_url":"https://api.github.com/repos/uber/image-diff/stargazers","contributors_url":"https://api.github.com/repos/uber/image-diff/contributors","subscribers_url":"https://api.github.com/repos/uber/image-diff/subscribers","subscription_url":"https://api.github.com/repos/uber/image-diff/subscription","commits_url":"https://api.github.com/repos/uber/image-diff/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/image-diff/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/image-diff/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/image-diff/issues/comments/{number}","contents_url":"https://api.github.com/repos/uber/image-diff/contents/{+path}","compare_url":"https://api.github.com/repos/uber/image-diff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/image-diff/merges","archive_url":"https://api.github.com/repos/uber/image-diff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/image-diff/downloads","issues_url":"https://api.github.com/repos/uber/image-diff/issues{/number}","pulls_url":"https://api.github.com/repos/uber/image-diff/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/image-diff/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/image-diff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/image-diff/labels{/name}","releases_url":"https://api.github.com/repos/uber/image-diff/releases{/id}","created_at":"2013-11-16T01:25:13Z","updated_at":"2014-02-21T09:37:37Z","pushed_at":"2014-02-21T09:32:52Z","git_url":"git://github.com/uber/image-diff.git","ssh_url":"git@github.com:uber/image-diff.git","clone_url":"https://github.com/uber/image-diff.git","svn_url":"https://github.com/uber/image-diff","homepage":null,"size":363,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":1,"default_branch":"master","master_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"e4ccd6628d1d073279e3fc54e5921177dc7336a0","user":{"login":"uber","id":538264,"avatar_url":"https://gravatar.com/avatar/e1aec73712d4c21ab7c7c1561133f65c?d=https%3A%2F%2Fidenticons.github.com%2Fefefd996f0306f9590c7e8646e9af92c.png&r=x","gravatar_id":"e1aec73712d4c21ab7c7c1561133f65c","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":14439422,"name":"image-diff","full_name":"uber/image-diff","owner":{"login":"uber","id":538264,"avatar_url":"https://gravatar.com/avatar/e1aec73712d4c21ab7c7c1561133f65c?d=https%3A%2F%2Fidenticons.github.com%2Fefefd996f0306f9590c7e8646e9af92c.png&r=x","gravatar_id":"e1aec73712d4c21ab7c7c1561133f65c","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/image-diff","description":"Create image differential between two images","fork":false,"url":"https://api.github.com/repos/uber/image-diff","forks_url":"https://api.github.com/repos/uber/image-diff/forks","keys_url":"https://api.github.com/repos/uber/image-diff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/image-diff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/image-diff/teams","hooks_url":"https://api.github.com/repos/uber/image-diff/hooks","issue_events_url":"https://api.github.com/repos/uber/image-diff/issues/events{/number}","events_url":"https://api.github.com/repos/uber/image-diff/events","assignees_url":"https://api.github.com/repos/uber/image-diff/assignees{/user}","branches_url":"https://api.github.com/repos/uber/image-diff/branches{/branch}","tags_url":"https://api.github.com/repos/uber/image-diff/tags","blobs_url":"https://api.github.com/repos/uber/image-diff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/image-diff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/image-diff/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/image-diff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/image-diff/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/image-diff/languages","stargazers_url":"https://api.github.com/repos/uber/image-diff/stargazers","contributors_url":"https://api.github.com/repos/uber/image-diff/contributors","subscribers_url":"https://api.github.com/repos/uber/image-diff/subscribers","subscription_url":"https://api.github.com/repos/uber/image-diff/subscription","commits_url":"https://api.github.com/repos/uber/image-diff/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/image-diff/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/image-diff/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/image-diff/issues/comments/{number}","contents_url":"https://api.github.com/repos/uber/image-diff/contents/{+path}","compare_url":"https://api.github.com/repos/uber/image-diff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/image-diff/merges","archive_url":"https://api.github.com/repos/uber/image-diff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/image-diff/downloads","issues_url":"https://api.github.com/repos/uber/image-diff/issues{/number}","pulls_url":"https://api.github.com/repos/uber/image-diff/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/image-diff/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/image-diff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/image-diff/labels{/name}","releases_url":"https://api.github.com/repos/uber/image-diff/releases{/id}","created_at":"2013-11-16T01:25:13Z","updated_at":"2014-02-21T09:37:37Z","pushed_at":"2014-02-21T09:32:52Z","git_url":"git://github.com/uber/image-diff.git","ssh_url":"git@github.com:uber/image-diff.git","clone_url":"https://github.com/uber/image-diff.git","svn_url":"https://github.com/uber/image-diff","homepage":null,"size":363,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":1,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/image-diff/pulls/11"},"html":{"href":"https://github.com/uber/image-diff/pull/11"},"issue":{"href":"https://api.github.com/repos/uber/image-diff/issues/11"},"comments":{"href":"https://api.github.com/repos/uber/image-diff/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/image-diff/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/image-diff/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/uber/image-diff/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/uber/image-diff/statuses/ae87bde0485db754397ee4eab981575cf5cba4de"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":139,"deletions":50,"changed_files":12}}