GitHub PullRequestReviewCommentEvent at 2014-03-24 20:22:05
Repository: uPortal
Actor: jameswennmacher
Payload: {"comment":{"url":"https://api.github.com/repos/Jasig/uPortal/pulls/comments/10904020","id":10904020,"diff_hunk":"@@ -124,6 +125,12 @@ public Object apply(Resource input) {\n         \n         final IPortalDataType portalDataType = this.dataKeyTypes.get(portalDataKey);\n         if (portalDataType == null) {\n+            Iterator<PortalDataKey> iter = dataKeyTypes.keySet().iterator();\n+            logger.warn(\"---------------- Keys:-------------------\");\n+            while(iter.hasNext()) {\n+                PortalDataKey key = iter.next();\n+                logger.warn(\"{}\",key);\n+            }","path":"uportal-war/src/main/java/org/jasig/portal/io/xml/PortalDataKeyFileProcessor.java","position":17,"original_position":17,"commit_id":"ff74054d92227f53c68bcd422b26bdb9a575a379","original_commit_id":"ff74054d92227f53c68bcd422b26bdb9a575a379","user":{"login":"jameswennmacher","id":1479823,"avatar_url":"https://avatars.githubusercontent.com/u/1479823?","gravatar_id":"2243e3ddb1dd4071024838394861db97","url":"https://api.github.com/users/jameswennmacher","html_url":"https://github.com/jameswennmacher","followers_url":"https://api.github.com/users/jameswennmacher/followers","following_url":"https://api.github.com/users/jameswennmacher/following{/other_user}","gists_url":"https://api.github.com/users/jameswennmacher/gists{/gist_id}","starred_url":"https://api.github.com/users/jameswennmacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameswennmacher/subscriptions","organizations_url":"https://api.github.com/users/jameswennmacher/orgs","repos_url":"https://api.github.com/users/jameswennmacher/repos","events_url":"https://api.github.com/users/jameswennmacher/events{/privacy}","received_events_url":"https://api.github.com/users/jameswennmacher/received_events","type":"User","site_admin":false},"body":"Minor, but this would generate a number of log messages, all but the last would be confusing since the last provides the context.  Suggest creating a string with all the data and adding it to the log message below so there is only one WARN message.","created_at":"2014-03-24T20:22:05Z","updated_at":"2014-03-24T20:22:05Z","html_url":"https://github.com/Jasig/uPortal/pull/273#discussion_r10904020","pull_request_url":"https://api.github.com/repos/Jasig/uPortal/pulls/273","_links":{"self":{"href":"https://api.github.com/repos/Jasig/uPortal/pulls/comments/10904020"},"html":{"href":"https://github.com/Jasig/uPortal/pull/273#discussion_r10904020"},"pull_request":{"href":"https://api.github.com/repos/Jasig/uPortal/pulls/273"}}}}