GitHub PullRequestEvent at 2014-10-06 00:32:03
Repository: ruby-net-ldap
Actor: jch
Payload: {"action":"opened","number":115,"pull_request":{"url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/pulls/115","id":22261193,"html_url":"https://github.com/ruby-ldap/ruby-net-ldap/pull/115","diff_url":"https://github.com/ruby-ldap/ruby-net-ldap/pull/115.diff","patch_url":"https://github.com/ruby-ldap/ruby-net-ldap/pull/115.patch","issue_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/issues/115","number":115,"state":"open","locked":false,"title":"Implement search timeout parameter","user":{"login":"jch","id":19874,"avatar_url":"https://avatars.githubusercontent.com/u/19874?v=2","gravatar_id":"","url":"https://api.github.com/users/jch","html_url":"https://github.com/jch","followers_url":"https://api.github.com/users/jch/followers","following_url":"https://api.github.com/users/jch/following{/other_user}","gists_url":"https://api.github.com/users/jch/gists{/gist_id}","starred_url":"https://api.github.com/users/jch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jch/subscriptions","organizations_url":"https://api.github.com/users/jch/orgs","repos_url":"https://api.github.com/users/jch/repos","events_url":"https://api.github.com/users/jch/events{/privacy}","received_events_url":"https://api.github.com/users/jch/received_events","type":"User","site_admin":true},"body":"This is a proposal to implement timeouts for search requests ([RFC 4511 4.5.1.5](http://tools.ietf.org/html/rfc4511#section-4.5.1.5)). I decided to name the parameter `timelimit` to be consistent with the existing `sizelimit` parameter. I still need to figure out a good approach for testing this, but wanted to open this PR for comments.\r\n\r\nFixes https://github.com/ruby-ldap/ruby-net-ldap/issues/10. Note that this is the protocol timeout, and not a hard socket timeout. That can come in a separate PR.","created_at":"2014-10-06T00:32:02Z","updated_at":"2014-10-06T00:32:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/pulls/115/commits","review_comments_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/pulls/115/comments","review_comment_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/issues/115/comments","statuses_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/statuses/8048c5d25d23030ae3825f68bf28d10a41e41d9f","head":{"label":"jch:search-timeout","ref":"search-timeout","sha":"8048c5d25d23030ae3825f68bf28d10a41e41d9f","user":{"login":"jch","id":19874,"avatar_url":"https://avatars.githubusercontent.com/u/19874?v=2","gravatar_id":"","url":"https://api.github.com/users/jch","html_url":"https://github.com/jch","followers_url":"https://api.github.com/users/jch/followers","following_url":"https://api.github.com/users/jch/following{/other_user}","gists_url":"https://api.github.com/users/jch/gists{/gist_id}","starred_url":"https://api.github.com/users/jch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jch/subscriptions","organizations_url":"https://api.github.com/users/jch/orgs","repos_url":"https://api.github.com/users/jch/repos","events_url":"https://api.github.com/users/jch/events{/privacy}","received_events_url":"https://api.github.com/users/jch/received_events","type":"User","site_admin":true},"repo":{"id":24280132,"name":"ruby-net-ldap","full_name":"jch/ruby-net-ldap","owner":{"login":"jch","id":19874,"avatar_url":"https://avatars.githubusercontent.com/u/19874?v=2","gravatar_id":"","url":"https://api.github.com/users/jch","html_url":"https://github.com/jch","followers_url":"https://api.github.com/users/jch/followers","following_url":"https://api.github.com/users/jch/following{/other_user}","gists_url":"https://api.github.com/users/jch/gists{/gist_id}","starred_url":"https://api.github.com/users/jch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jch/subscriptions","organizations_url":"https://api.github.com/users/jch/orgs","repos_url":"https://api.github.com/users/jch/repos","events_url":"https://api.github.com/users/jch/events{/privacy}","received_events_url":"https://api.github.com/users/jch/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/jch/ruby-net-ldap","description":"Pure Ruby LDAP library ","fork":true,"url":"https://api.github.com/repos/jch/ruby-net-ldap","forks_url":"https://api.github.com/repos/jch/ruby-net-ldap/forks","keys_url":"https://api.github.com/repos/jch/ruby-net-ldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jch/ruby-net-ldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jch/ruby-net-ldap/teams","hooks_url":"https://api.github.com/repos/jch/ruby-net-ldap/hooks","issue_events_url":"https://api.github.com/repos/jch/ruby-net-ldap/issues/events{/number}","events_url":"https://api.github.com/repos/jch/ruby-net-ldap/events","assignees_url":"https://api.github.com/repos/jch/ruby-net-ldap/assignees{/user}","branches_url":"https://api.github.com/repos/jch/ruby-net-ldap/branches{/branch}","tags_url":"https://api.github.com/repos/jch/ruby-net-ldap/tags","blobs_url":"https://api.github.com/repos/jch/ruby-net-ldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jch/ruby-net-ldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jch/ruby-net-ldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/jch/ruby-net-ldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jch/ruby-net-ldap/statuses/{sha}","languages_url":"https://api.github.com/repos/jch/ruby-net-ldap/languages","stargazers_url":"https://api.github.com/repos/jch/ruby-net-ldap/stargazers","contributors_url":"https://api.github.com/repos/jch/ruby-net-ldap/contributors","subscribers_url":"https://api.github.com/repos/jch/ruby-net-ldap/subscribers","subscription_url":"https://api.github.com/repos/jch/ruby-net-ldap/subscription","commits_url":"https://api.github.com/repos/jch/ruby-net-ldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/jch/ruby-net-ldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/jch/ruby-net-ldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/jch/ruby-net-ldap/issues/comments/{number}","contents_url":"https://api.github.com/repos/jch/ruby-net-ldap/contents/{+path}","compare_url":"https://api.github.com/repos/jch/ruby-net-ldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jch/ruby-net-ldap/merges","archive_url":"https://api.github.com/repos/jch/ruby-net-ldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jch/ruby-net-ldap/downloads","issues_url":"https://api.github.com/repos/jch/ruby-net-ldap/issues{/number}","pulls_url":"https://api.github.com/repos/jch/ruby-net-ldap/pulls{/number}","milestones_url":"https://api.github.com/repos/jch/ruby-net-ldap/milestones{/number}","notifications_url":"https://api.github.com/repos/jch/ruby-net-ldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jch/ruby-net-ldap/labels{/name}","releases_url":"https://api.github.com/repos/jch/ruby-net-ldap/releases{/id}","created_at":"2014-09-21T02:41:58Z","updated_at":"2014-09-17T22:08:25Z","pushed_at":"2014-10-06T00:27:18Z","git_url":"git://github.com/jch/ruby-net-ldap.git","ssh_url":"git@github.com:jch/ruby-net-ldap.git","clone_url":"https://github.com/jch/ruby-net-ldap.git","svn_url":"https://github.com/jch/ruby-net-ldap","homepage":"https://github.com/ruby-ldap/ruby-net-ldap","size":966,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ruby-ldap:master","ref":"master","sha":"3ebb322dd5bb07d8e23fa1114a9fcdb38aec57d8","user":{"login":"ruby-ldap","id":676122,"avatar_url":"https://avatars.githubusercontent.com/u/676122?v=2","gravatar_id":"","url":"https://api.github.com/users/ruby-ldap","html_url":"https://github.com/ruby-ldap","followers_url":"https://api.github.com/users/ruby-ldap/followers","following_url":"https://api.github.com/users/ruby-ldap/following{/other_user}","gists_url":"https://api.github.com/users/ruby-ldap/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby-ldap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby-ldap/subscriptions","organizations_url":"https://api.github.com/users/ruby-ldap/orgs","repos_url":"https://api.github.com/users/ruby-ldap/repos","events_url":"https://api.github.com/users/ruby-ldap/events{/privacy}","received_events_url":"https://api.github.com/users/ruby-ldap/received_events","type":"Organization","site_admin":false},"repo":{"id":1509861,"name":"ruby-net-ldap","full_name":"ruby-ldap/ruby-net-ldap","owner":{"login":"ruby-ldap","id":676122,"avatar_url":"https://avatars.githubusercontent.com/u/676122?v=2","gravatar_id":"","url":"https://api.github.com/users/ruby-ldap","html_url":"https://github.com/ruby-ldap","followers_url":"https://api.github.com/users/ruby-ldap/followers","following_url":"https://api.github.com/users/ruby-ldap/following{/other_user}","gists_url":"https://api.github.com/users/ruby-ldap/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby-ldap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby-ldap/subscriptions","organizations_url":"https://api.github.com/users/ruby-ldap/orgs","repos_url":"https://api.github.com/users/ruby-ldap/repos","events_url":"https://api.github.com/users/ruby-ldap/events{/privacy}","received_events_url":"https://api.github.com/users/ruby-ldap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ruby-ldap/ruby-net-ldap","description":"Pure Ruby LDAP library ","fork":false,"url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap","forks_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/forks","keys_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/teams","hooks_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/hooks","issue_events_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/issues/events{/number}","events_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/events","assignees_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/assignees{/user}","branches_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/branches{/branch}","tags_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/tags","blobs_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/statuses/{sha}","languages_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/languages","stargazers_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/stargazers","contributors_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/contributors","subscribers_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/subscribers","subscription_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/subscription","commits_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/issues/comments/{number}","contents_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/contents/{+path}","compare_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/merges","archive_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/downloads","issues_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/issues{/number}","pulls_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/pulls{/number}","milestones_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/milestones{/number}","notifications_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/labels{/name}","releases_url":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/releases{/id}","created_at":"2011-03-22T03:52:14Z","updated_at":"2014-09-25T10:26:53Z","pushed_at":"2014-10-05T23:43:03Z","git_url":"git://github.com/ruby-ldap/ruby-net-ldap.git","ssh_url":"git@github.com:ruby-ldap/ruby-net-ldap.git","clone_url":"https://github.com/ruby-ldap/ruby-net-ldap.git","svn_url":"https://github.com/ruby-ldap/ruby-net-ldap","homepage":"https://github.com/ruby-ldap/ruby-net-ldap","size":1585,"stargazers_count":159,"watchers_count":159,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"open_issues_count":42,"forks":130,"open_issues":42,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/pulls/115"},"html":{"href":"https://github.com/ruby-ldap/ruby-net-ldap/pull/115"},"issue":{"href":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/issues/115"},"comments":{"href":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/ruby-ldap/ruby-net-ldap/statuses/8048c5d25d23030ae3825f68bf28d10a41e41d9f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":4,"deletions":1,"changed_files":1}}