GitHub PullRequestReviewCommentEvent at 2014-07-07 22:26:08
Repository: core-icon
Actor: sjmiles
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/core-icon/pulls/comments/14626690","id":14626690,"diff_hunk":"@@ -102,9 +102,11 @@\n     },\n \n     updateIcon: function() {\n-      if (this.size) {\n-        this.style.width = this.style.height = this.size + 'px';\n+      if (!this.size) {\n+        var style = window.getComputedStyle(this, null).getPropertyValue('font-size');","path":"core-icon.html","position":16,"original_position":16,"commit_id":"d82603ada974bec67ecdfc7365e818186d792aa9","original_commit_id":"d82603ada974bec67ecdfc7365e818186d792aa9","user":{"login":"sjmiles","id":98045,"avatar_url":"https://avatars.githubusercontent.com/u/98045?","gravatar_id":"73441c3e7032ac7ecd4f95876bdc3541","url":"https://api.github.com/users/sjmiles","html_url":"https://github.com/sjmiles","followers_url":"https://api.github.com/users/sjmiles/followers","following_url":"https://api.github.com/users/sjmiles/following{/other_user}","gists_url":"https://api.github.com/users/sjmiles/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmiles/subscriptions","organizations_url":"https://api.github.com/users/sjmiles/orgs","repos_url":"https://api.github.com/users/sjmiles/repos","events_url":"https://api.github.com/users/sjmiles/events{/privacy}","received_events_url":"https://api.github.com/users/sjmiles/received_events","type":"User","site_admin":false},"body":"It used to be the case that on IE in particular, `getPropertyValue` would not return _px_ values necessarily, and might return '1.2em' or '50%'. Have you tested this across browsers?","created_at":"2014-07-07T22:26:08Z","updated_at":"2014-07-07T22:26:08Z","html_url":"https://github.com/Polymer/core-icon/pull/6#discussion_r14626690","pull_request_url":"https://api.github.com/repos/Polymer/core-icon/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/Polymer/core-icon/pulls/comments/14626690"},"html":{"href":"https://github.com/Polymer/core-icon/pull/6#discussion_r14626690"},"pull_request":{"href":"https://api.github.com/repos/Polymer/core-icon/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/core-icon/pulls/6","id":18072956,"html_url":"https://github.com/Polymer/core-icon/pull/6","diff_url":"https://github.com/Polymer/core-icon/pull/6.diff","patch_url":"https://github.com/Polymer/core-icon/pull/6.patch","issue_url":"https://api.github.com/repos/Polymer/core-icon/issues/6","number":6,"state":"open","title":"Have the icon.size default to computed font size.","user":{"login":"arodic","id":708984,"avatar_url":"https://avatars.githubusercontent.com/u/708984?","gravatar_id":"8555b5cb21e8fe7ad656830932647d58","url":"https://api.github.com/users/arodic","html_url":"https://github.com/arodic","followers_url":"https://api.github.com/users/arodic/followers","following_url":"https://api.github.com/users/arodic/following{/other_user}","gists_url":"https://api.github.com/users/arodic/gists{/gist_id}","starred_url":"https://api.github.com/users/arodic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arodic/subscriptions","organizations_url":"https://api.github.com/users/arodic/orgs","repos_url":"https://api.github.com/users/arodic/repos","events_url":"https://api.github.com/users/arodic/events{/privacy}","received_events_url":"https://api.github.com/users/arodic/received_events","type":"User","site_admin":false},"body":"This is a proposal to have the icon size default to computed font size. Very often, icons are presented next to text of matching size. This would make it possible to set the font size with CSS and have the icon automatically resize. Does this sound useful?","created_at":"2014-07-07T22:22:12Z","updated_at":"2014-07-07T22:26:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f97fa36bd1914e84df4f4c4b35696d65ea151858","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/core-icon/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Polymer/core-icon/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Polymer/core-icon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Polymer/core-icon/issues/6/comments","statuses_url":"https://api.github.com/repos/Polymer/core-icon/statuses/d82603ada974bec67ecdfc7365e818186d792aa9","head":{"label":"arodic:patch-1","ref":"patch-1","sha":"d82603ada974bec67ecdfc7365e818186d792aa9","user":{"login":"arodic","id":708984,"avatar_url":"https://avatars.githubusercontent.com/u/708984?","gravatar_id":"8555b5cb21e8fe7ad656830932647d58","url":"https://api.github.com/users/arodic","html_url":"https://github.com/arodic","followers_url":"https://api.github.com/users/arodic/followers","following_url":"https://api.github.com/users/arodic/following{/other_user}","gists_url":"https://api.github.com/users/arodic/gists{/gist_id}","starred_url":"https://api.github.com/users/arodic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arodic/subscriptions","organizations_url":"https://api.github.com/users/arodic/orgs","repos_url":"https://api.github.com/users/arodic/repos","events_url":"https://api.github.com/users/arodic/events{/privacy}","received_events_url":"https://api.github.com/users/arodic/received_events","type":"User","site_admin":false},"repo":{"id":21588752,"name":"core-icon","full_name":"arodic/core-icon","owner":{"login":"arodic","id":708984,"avatar_url":"https://avatars.githubusercontent.com/u/708984?","gravatar_id":"8555b5cb21e8fe7ad656830932647d58","url":"https://api.github.com/users/arodic","html_url":"https://github.com/arodic","followers_url":"https://api.github.com/users/arodic/followers","following_url":"https://api.github.com/users/arodic/following{/other_user}","gists_url":"https://api.github.com/users/arodic/gists{/gist_id}","starred_url":"https://api.github.com/users/arodic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arodic/subscriptions","organizations_url":"https://api.github.com/users/arodic/orgs","repos_url":"https://api.github.com/users/arodic/repos","events_url":"https://api.github.com/users/arodic/events{/privacy}","received_events_url":"https://api.github.com/users/arodic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arodic/core-icon","description":"","fork":true,"url":"https://api.github.com/repos/arodic/core-icon","forks_url":"https://api.github.com/repos/arodic/core-icon/forks","keys_url":"https://api.github.com/repos/arodic/core-icon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arodic/core-icon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arodic/core-icon/teams","hooks_url":"https://api.github.com/repos/arodic/core-icon/hooks","issue_events_url":"https://api.github.com/repos/arodic/core-icon/issues/events{/number}","events_url":"https://api.github.com/repos/arodic/core-icon/events","assignees_url":"https://api.github.com/repos/arodic/core-icon/assignees{/user}","branches_url":"https://api.github.com/repos/arodic/core-icon/branches{/branch}","tags_url":"https://api.github.com/repos/arodic/core-icon/tags","blobs_url":"https://api.github.com/repos/arodic/core-icon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arodic/core-icon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arodic/core-icon/git/refs{/sha}","trees_url":"https://api.github.com/repos/arodic/core-icon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arodic/core-icon/statuses/{sha}","languages_url":"https://api.github.com/repos/arodic/core-icon/languages","stargazers_url":"https://api.github.com/repos/arodic/core-icon/stargazers","contributors_url":"https://api.github.com/repos/arodic/core-icon/contributors","subscribers_url":"https://api.github.com/repos/arodic/core-icon/subscribers","subscription_url":"https://api.github.com/repos/arodic/core-icon/subscription","commits_url":"https://api.github.com/repos/arodic/core-icon/commits{/sha}","git_commits_url":"https://api.github.com/repos/arodic/core-icon/git/commits{/sha}","comments_url":"https://api.github.com/repos/arodic/core-icon/comments{/number}","issue_comment_url":"https://api.github.com/repos/arodic/core-icon/issues/comments/{number}","contents_url":"https://api.github.com/repos/arodic/core-icon/contents/{+path}","compare_url":"https://api.github.com/repos/arodic/core-icon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arodic/core-icon/merges","archive_url":"https://api.github.com/repos/arodic/core-icon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arodic/core-icon/downloads","issues_url":"https://api.github.com/repos/arodic/core-icon/issues{/number}","pulls_url":"https://api.github.com/repos/arodic/core-icon/pulls{/number}","milestones_url":"https://api.github.com/repos/arodic/core-icon/milestones{/number}","notifications_url":"https://api.github.com/repos/arodic/core-icon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arodic/core-icon/labels{/name}","releases_url":"https://api.github.com/repos/arodic/core-icon/releases{/id}","created_at":"2014-07-07T22:16:48Z","updated_at":"2014-07-07T22:21:49Z","pushed_at":"2014-07-07T22:21:50Z","git_url":"git://github.com/arodic/core-icon.git","ssh_url":"git@github.com:arodic/core-icon.git","clone_url":"https://github.com/arodic/core-icon.git","svn_url":"https://github.com/arodic/core-icon","homepage":null,"size":1407,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"5ff97caddd523038c294c560e1c312eece314295","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?","gravatar_id":"a08da340b07b06a9cc2c107a98c8623f","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":17424011,"name":"core-icon","full_name":"Polymer/core-icon","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?","gravatar_id":"a08da340b07b06a9cc2c107a98c8623f","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/core-icon","description":"","fork":false,"url":"https://api.github.com/repos/Polymer/core-icon","forks_url":"https://api.github.com/repos/Polymer/core-icon/forks","keys_url":"https://api.github.com/repos/Polymer/core-icon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/core-icon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/core-icon/teams","hooks_url":"https://api.github.com/repos/Polymer/core-icon/hooks","issue_events_url":"https://api.github.com/repos/Polymer/core-icon/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/core-icon/events","assignees_url":"https://api.github.com/repos/Polymer/core-icon/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/core-icon/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/core-icon/tags","blobs_url":"https://api.github.com/repos/Polymer/core-icon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/core-icon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/core-icon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/core-icon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/core-icon/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/core-icon/languages","stargazers_url":"https://api.github.com/repos/Polymer/core-icon/stargazers","contributors_url":"https://api.github.com/repos/Polymer/core-icon/contributors","subscribers_url":"https://api.github.com/repos/Polymer/core-icon/subscribers","subscription_url":"https://api.github.com/repos/Polymer/core-icon/subscription","commits_url":"https://api.github.com/repos/Polymer/core-icon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/core-icon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/core-icon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/core-icon/issues/comments/{number}","contents_url":"https://api.github.com/repos/Polymer/core-icon/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/core-icon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/core-icon/merges","archive_url":"https://api.github.com/repos/Polymer/core-icon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/core-icon/downloads","issues_url":"https://api.github.com/repos/Polymer/core-icon/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/core-icon/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/core-icon/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/core-icon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/core-icon/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/core-icon/releases{/id}","created_at":"2014-03-05T01:34:27Z","updated_at":"2014-07-07T19:37:14Z","pushed_at":"2014-07-07T19:37:14Z","git_url":"git://github.com/Polymer/core-icon.git","ssh_url":"git@github.com:Polymer/core-icon.git","clone_url":"https://github.com/Polymer/core-icon.git","svn_url":"https://github.com/Polymer/core-icon","homepage":null,"size":1407,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/core-icon/pulls/6"},"html":{"href":"https://github.com/Polymer/core-icon/pull/6"},"issue":{"href":"https://api.github.com/repos/Polymer/core-icon/issues/6"},"comments":{"href":"https://api.github.com/repos/Polymer/core-icon/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/core-icon/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/core-icon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Polymer/core-icon/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/core-icon/statuses/d82603ada974bec67ecdfc7365e818186d792aa9"}}}}