GitHub PullRequestReviewCommentEvent at 2014-12-09 20:44:19
Repository: harpoon
Actor: peterbourgon
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/soundcloud/harpoon/pulls/comments/21560655","id":21560655,"diff_hunk":"@@ -151,14 +151,15 @@ func (s *supervisor) Run(metricsTick <-chan time.Time, restartTimer func() <-cha\n \t\t\t\tdefault:\n \t\t\t\t\tpanic(\"invalid restart policy\")\n \t\t\t\t}\n-\t\t\t}\n-\n-\t\t\tif !state.Restarting {\n-\t\t\t\tmetricsTick = nil\n+\t\t\tcase agent.TermSignal:\n+\t\t\tdefault:\n+\t\t\t\tpanic(fmt.Sprintf(\"unknown termination state: '%s'\", exitStatus.Cause))","path":"harpoon-supervisor/supervisor.go","position":33,"original_position":33,"commit_id":"196768216a42c8ccbfc8f74a30e86d1de14ea62d","original_commit_id":"196768216a42c8ccbfc8f74a30e86d1de14ea62d","user":{"login":"peterbourgon","id":114509,"avatar_url":"https://avatars.githubusercontent.com/u/114509?v=3","gravatar_id":"","url":"https://api.github.com/users/peterbourgon","html_url":"https://github.com/peterbourgon","followers_url":"https://api.github.com/users/peterbourgon/followers","following_url":"https://api.github.com/users/peterbourgon/following{/other_user}","gists_url":"https://api.github.com/users/peterbourgon/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbourgon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbourgon/subscriptions","organizations_url":"https://api.github.com/users/peterbourgon/orgs","repos_url":"https://api.github.com/users/peterbourgon/repos","events_url":"https://api.github.com/users/peterbourgon/events{/privacy}","received_events_url":"https://api.github.com/users/peterbourgon/received_events","type":"User","site_admin":false},"body":"`'%s'` => `%q`","created_at":"2014-12-09T20:44:19Z","updated_at":"2014-12-09T20:44:19Z","html_url":"https://github.com/soundcloud/harpoon/pull/144#discussion_r21560655","pull_request_url":"https://api.github.com/repos/soundcloud/harpoon/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/soundcloud/harpoon/pulls/comments/21560655"},"html":{"href":"https://github.com/soundcloud/harpoon/pull/144#discussion_r21560655"},"pull_request":{"href":"https://api.github.com/repos/soundcloud/harpoon/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/soundcloud/harpoon/pulls/144","id":25663873,"html_url":"https://github.com/soundcloud/harpoon/pull/144","diff_url":"https://github.com/soundcloud/harpoon/pull/144.diff","patch_url":"https://github.com/soundcloud/harpoon/pull/144.patch","issue_url":"https://api.github.com/repos/soundcloud/harpoon/issues/144","number":144,"state":"open","locked":false,"title":"Clarify container exit logic","user":{"login":"jmyounker","id":882634,"avatar_url":"https://avatars.githubusercontent.com/u/882634?v=3","gravatar_id":"","url":"https://api.github.com/users/jmyounker","html_url":"https://github.com/jmyounker","followers_url":"https://api.github.com/users/jmyounker/followers","following_url":"https://api.github.com/users/jmyounker/following{/other_user}","gists_url":"https://api.github.com/users/jmyounker/gists{/gist_id}","starred_url":"https://api.github.com/users/jmyounker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmyounker/subscriptions","organizations_url":"https://api.github.com/users/jmyounker/orgs","repos_url":"https://api.github.com/users/jmyounker/repos","events_url":"https://api.github.com/users/jmyounker/events{/privacy}","received_events_url":"https://api.github.com/users/jmyounker/received_events","type":"User","site_admin":false},"body":"Condensed three variables into one variable with three states.  Clarified logic handling these states.","created_at":"2014-12-08T12:53:17Z","updated_at":"2014-12-09T20:44:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56bf28c3dce27c51fd15abefb485d23d283d537f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/soundcloud/harpoon/pulls/144/commits","review_comments_url":"https://api.github.com/repos/soundcloud/harpoon/pulls/144/comments","review_comment_url":"https://api.github.com/repos/soundcloud/harpoon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/soundcloud/harpoon/issues/144/comments","statuses_url":"https://api.github.com/repos/soundcloud/harpoon/statuses/196768216a42c8ccbfc8f74a30e86d1de14ea62d","head":{"label":"soundcloud:simplify-supervisor-exit","ref":"simplify-supervisor-exit","sha":"196768216a42c8ccbfc8f74a30e86d1de14ea62d","user":{"login":"soundcloud","id":21021,"avatar_url":"https://avatars.githubusercontent.com/u/21021?v=3","gravatar_id":"","url":"https://api.github.com/users/soundcloud","html_url":"https://github.com/soundcloud","followers_url":"https://api.github.com/users/soundcloud/followers","following_url":"https://api.github.com/users/soundcloud/following{/other_user}","gists_url":"https://api.github.com/users/soundcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/soundcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundcloud/subscriptions","organizations_url":"https://api.github.com/users/soundcloud/orgs","repos_url":"https://api.github.com/users/soundcloud/repos","events_url":"https://api.github.com/users/soundcloud/events{/privacy}","received_events_url":"https://api.github.com/users/soundcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":21981956,"name":"harpoon","full_name":"soundcloud/harpoon","owner":{"login":"soundcloud","id":21021,"avatar_url":"https://avatars.githubusercontent.com/u/21021?v=3","gravatar_id":"","url":"https://api.github.com/users/soundcloud","html_url":"https://github.com/soundcloud","followers_url":"https://api.github.com/users/soundcloud/followers","following_url":"https://api.github.com/users/soundcloud/following{/other_user}","gists_url":"https://api.github.com/users/soundcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/soundcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundcloud/subscriptions","organizations_url":"https://api.github.com/users/soundcloud/orgs","repos_url":"https://api.github.com/users/soundcloud/repos","events_url":"https://api.github.com/users/soundcloud/events{/privacy}","received_events_url":"https://api.github.com/users/soundcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/soundcloud/harpoon","description":"A comprehensive application platform.","fork":false,"url":"https://api.github.com/repos/soundcloud/harpoon","forks_url":"https://api.github.com/repos/soundcloud/harpoon/forks","keys_url":"https://api.github.com/repos/soundcloud/harpoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soundcloud/harpoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soundcloud/harpoon/teams","hooks_url":"https://api.github.com/repos/soundcloud/harpoon/hooks","issue_events_url":"https://api.github.com/repos/soundcloud/harpoon/issues/events{/number}","events_url":"https://api.github.com/repos/soundcloud/harpoon/events","assignees_url":"https://api.github.com/repos/soundcloud/harpoon/assignees{/user}","branches_url":"https://api.github.com/repos/soundcloud/harpoon/branches{/branch}","tags_url":"https://api.github.com/repos/soundcloud/harpoon/tags","blobs_url":"https://api.github.com/repos/soundcloud/harpoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soundcloud/harpoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soundcloud/harpoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/soundcloud/harpoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soundcloud/harpoon/statuses/{sha}","languages_url":"https://api.github.com/repos/soundcloud/harpoon/languages","stargazers_url":"https://api.github.com/repos/soundcloud/harpoon/stargazers","contributors_url":"https://api.github.com/repos/soundcloud/harpoon/contributors","subscribers_url":"https://api.github.com/repos/soundcloud/harpoon/subscribers","subscription_url":"https://api.github.com/repos/soundcloud/harpoon/subscription","commits_url":"https://api.github.com/repos/soundcloud/harpoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/soundcloud/harpoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/soundcloud/harpoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/soundcloud/harpoon/issues/comments/{number}","contents_url":"https://api.github.com/repos/soundcloud/harpoon/contents/{+path}","compare_url":"https://api.github.com/repos/soundcloud/harpoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soundcloud/harpoon/merges","archive_url":"https://api.github.com/repos/soundcloud/harpoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soundcloud/harpoon/downloads","issues_url":"https://api.github.com/repos/soundcloud/harpoon/issues{/number}","pulls_url":"https://api.github.com/repos/soundcloud/harpoon/pulls{/number}","milestones_url":"https://api.github.com/repos/soundcloud/harpoon/milestones{/number}","notifications_url":"https://api.github.com/repos/soundcloud/harpoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soundcloud/harpoon/labels{/name}","releases_url":"https://api.github.com/repos/soundcloud/harpoon/releases{/id}","created_at":"2014-07-18T13:54:47Z","updated_at":"2014-12-08T13:33:27Z","pushed_at":"2014-12-09T20:41:58Z","git_url":"git://github.com/soundcloud/harpoon.git","ssh_url":"git@github.com:soundcloud/harpoon.git","clone_url":"https://github.com/soundcloud/harpoon.git","svn_url":"https://github.com/soundcloud/harpoon","homepage":null,"size":3398,"stargazers_count":55,"watchers_count":55,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":19,"forks":2,"open_issues":19,"watchers":55,"default_branch":"master"}},"base":{"label":"soundcloud:master","ref":"master","sha":"ba126a1aad8a66ca4c9d2cf0932d7acc61dc1790","user":{"login":"soundcloud","id":21021,"avatar_url":"https://avatars.githubusercontent.com/u/21021?v=3","gravatar_id":"","url":"https://api.github.com/users/soundcloud","html_url":"https://github.com/soundcloud","followers_url":"https://api.github.com/users/soundcloud/followers","following_url":"https://api.github.com/users/soundcloud/following{/other_user}","gists_url":"https://api.github.com/users/soundcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/soundcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundcloud/subscriptions","organizations_url":"https://api.github.com/users/soundcloud/orgs","repos_url":"https://api.github.com/users/soundcloud/repos","events_url":"https://api.github.com/users/soundcloud/events{/privacy}","received_events_url":"https://api.github.com/users/soundcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":21981956,"name":"harpoon","full_name":"soundcloud/harpoon","owner":{"login":"soundcloud","id":21021,"avatar_url":"https://avatars.githubusercontent.com/u/21021?v=3","gravatar_id":"","url":"https://api.github.com/users/soundcloud","html_url":"https://github.com/soundcloud","followers_url":"https://api.github.com/users/soundcloud/followers","following_url":"https://api.github.com/users/soundcloud/following{/other_user}","gists_url":"https://api.github.com/users/soundcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/soundcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundcloud/subscriptions","organizations_url":"https://api.github.com/users/soundcloud/orgs","repos_url":"https://api.github.com/users/soundcloud/repos","events_url":"https://api.github.com/users/soundcloud/events{/privacy}","received_events_url":"https://api.github.com/users/soundcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/soundcloud/harpoon","description":"A comprehensive application platform.","fork":false,"url":"https://api.github.com/repos/soundcloud/harpoon","forks_url":"https://api.github.com/repos/soundcloud/harpoon/forks","keys_url":"https://api.github.com/repos/soundcloud/harpoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soundcloud/harpoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soundcloud/harpoon/teams","hooks_url":"https://api.github.com/repos/soundcloud/harpoon/hooks","issue_events_url":"https://api.github.com/repos/soundcloud/harpoon/issues/events{/number}","events_url":"https://api.github.com/repos/soundcloud/harpoon/events","assignees_url":"https://api.github.com/repos/soundcloud/harpoon/assignees{/user}","branches_url":"https://api.github.com/repos/soundcloud/harpoon/branches{/branch}","tags_url":"https://api.github.com/repos/soundcloud/harpoon/tags","blobs_url":"https://api.github.com/repos/soundcloud/harpoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soundcloud/harpoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soundcloud/harpoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/soundcloud/harpoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soundcloud/harpoon/statuses/{sha}","languages_url":"https://api.github.com/repos/soundcloud/harpoon/languages","stargazers_url":"https://api.github.com/repos/soundcloud/harpoon/stargazers","contributors_url":"https://api.github.com/repos/soundcloud/harpoon/contributors","subscribers_url":"https://api.github.com/repos/soundcloud/harpoon/subscribers","subscription_url":"https://api.github.com/repos/soundcloud/harpoon/subscription","commits_url":"https://api.github.com/repos/soundcloud/harpoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/soundcloud/harpoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/soundcloud/harpoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/soundcloud/harpoon/issues/comments/{number}","contents_url":"https://api.github.com/repos/soundcloud/harpoon/contents/{+path}","compare_url":"https://api.github.com/repos/soundcloud/harpoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soundcloud/harpoon/merges","archive_url":"https://api.github.com/repos/soundcloud/harpoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soundcloud/harpoon/downloads","issues_url":"https://api.github.com/repos/soundcloud/harpoon/issues{/number}","pulls_url":"https://api.github.com/repos/soundcloud/harpoon/pulls{/number}","milestones_url":"https://api.github.com/repos/soundcloud/harpoon/milestones{/number}","notifications_url":"https://api.github.com/repos/soundcloud/harpoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soundcloud/harpoon/labels{/name}","releases_url":"https://api.github.com/repos/soundcloud/harpoon/releases{/id}","created_at":"2014-07-18T13:54:47Z","updated_at":"2014-12-08T13:33:27Z","pushed_at":"2014-12-09T20:41:58Z","git_url":"git://github.com/soundcloud/harpoon.git","ssh_url":"git@github.com:soundcloud/harpoon.git","clone_url":"https://github.com/soundcloud/harpoon.git","svn_url":"https://github.com/soundcloud/harpoon","homepage":null,"size":3398,"stargazers_count":55,"watchers_count":55,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":19,"forks":2,"open_issues":19,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/soundcloud/harpoon/pulls/144"},"html":{"href":"https://github.com/soundcloud/harpoon/pull/144"},"issue":{"href":"https://api.github.com/repos/soundcloud/harpoon/issues/144"},"comments":{"href":"https://api.github.com/repos/soundcloud/harpoon/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/soundcloud/harpoon/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/soundcloud/harpoon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/soundcloud/harpoon/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/soundcloud/harpoon/statuses/196768216a42c8ccbfc8f74a30e86d1de14ea62d"}}}}