GitHub PullRequestReviewCommentEvent at 2014-07-15 23:40:28
Repository: bootstrap
Actor: hnrch02
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/twbs/bootstrap/pulls/comments/14974598","id":14974598,"diff_hunk":"@@ -671,8 +673,9 @@ if (typeof jQuery === 'undefined') { throw new Error('Bootstrap\\'s JavaScript re\n     var $parent = parent && $(parent)\n \n     if (!data || !data.transitioning) {\n-      if ($parent) $parent.find('[data-toggle=\"collapse\"][data-parent=\"' + parent + '\"]').not($this).addClass('collapsed')\n-      $this.toggleClass('collapsed', $target.hasClass('in'))\n+      if ($parent) $parent.find('[data-toggle=\"collapse\"][data-parent=\"' + parent + '\"]').not($this).addClass('collapsed').attr('aria-selected', false).attr('aria-expanded', false)\n+      var isin = $target.hasClass('in');\n+      $this.toggleClass('collapsed', isin).attr('aria-selected', !isin).attr('aria-expanded', !isin)","path":"dist/js/bootstrap.js","position":24,"original_position":24,"commit_id":"553f914e11a12a6d24faf51b82fa2bc6a0b8b53b","original_commit_id":"553f914e11a12a6d24faf51b82fa2bc6a0b8b53b","user":{"login":"hnrch02","id":1068978,"avatar_url":"https://avatars.githubusercontent.com/u/1068978?","gravatar_id":"0d53f5d3d3d28bd470f394d98f7ef48f","url":"https://api.github.com/users/hnrch02","html_url":"https://github.com/hnrch02","followers_url":"https://api.github.com/users/hnrch02/followers","following_url":"https://api.github.com/users/hnrch02/following{/other_user}","gists_url":"https://api.github.com/users/hnrch02/gists{/gist_id}","starred_url":"https://api.github.com/users/hnrch02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnrch02/subscriptions","organizations_url":"https://api.github.com/users/hnrch02/orgs","repos_url":"https://api.github.com/users/hnrch02/repos","events_url":"https://api.github.com/users/hnrch02/events{/privacy}","received_events_url":"https://api.github.com/users/hnrch02/received_events","type":"User","site_admin":false},"body":"Same as above and please also change the name of `isin` to something more descriptive.","created_at":"2014-07-15T23:40:28Z","updated_at":"2014-07-15T23:40:28Z","html_url":"https://github.com/twbs/bootstrap/pull/14153#discussion_r14974598","pull_request_url":"https://api.github.com/repos/twbs/bootstrap/pulls/14153","_links":{"self":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/comments/14974598"},"html":{"href":"https://github.com/twbs/bootstrap/pull/14153#discussion_r14974598"},"pull_request":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/14153"}}},"pull_request":{"url":"https://api.github.com/repos/twbs/bootstrap/pulls/14153","id":18433969,"html_url":"https://github.com/twbs/bootstrap/pull/14153","diff_url":"https://github.com/twbs/bootstrap/pull/14153.diff","patch_url":"https://github.com/twbs/bootstrap/pull/14153.patch","issue_url":"https://api.github.com/repos/twbs/bootstrap/issues/14153","number":14153,"state":"open","title":"Collapse accessability","user":{"login":"apexskier","id":329222,"avatar_url":"https://avatars.githubusercontent.com/u/329222?","gravatar_id":"248a99f9bda7156fee6c18b3f6346583","url":"https://api.github.com/users/apexskier","html_url":"https://github.com/apexskier","followers_url":"https://api.github.com/users/apexskier/followers","following_url":"https://api.github.com/users/apexskier/following{/other_user}","gists_url":"https://api.github.com/users/apexskier/gists{/gist_id}","starred_url":"https://api.github.com/users/apexskier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apexskier/subscriptions","organizations_url":"https://api.github.com/users/apexskier/orgs","repos_url":"https://api.github.com/users/apexskier/repos","events_url":"https://api.github.com/users/apexskier/events{/privacy}","received_events_url":"https://api.github.com/users/apexskier/received_events","type":"User","site_admin":false},"body":"This addresses a decent amount of issue #13555.\r\n\r\n- Added tabIndex aria attribute to collapse plugin\r\n- Added tab-role, aria-selected, and aria-controls into the collapse html docs.\r\n- Added support for toggling aria-expanded, aria-selected, and aria-hidden via the javascript collapse events.\r\n\r\nA decent amount of the changes were inspired by the example at http://accessibility.athena-ict.com/aria/examples/tabpanel2.shtml","created_at":"2014-07-15T20:51:28Z","updated_at":"2014-07-15T23:40:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f11bd2f81883f0067a982f1ad5dc45acda3a1e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twbs/bootstrap/pulls/14153/commits","review_comments_url":"https://api.github.com/repos/twbs/bootstrap/pulls/14153/comments","review_comment_url":"https://api.github.com/repos/twbs/bootstrap/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twbs/bootstrap/issues/14153/comments","statuses_url":"https://api.github.com/repos/twbs/bootstrap/statuses/553f914e11a12a6d24faf51b82fa2bc6a0b8b53b","head":{"label":"apexskier:collapse-accessibility","ref":"collapse-accessibility","sha":"553f914e11a12a6d24faf51b82fa2bc6a0b8b53b","user":{"login":"apexskier","id":329222,"avatar_url":"https://avatars.githubusercontent.com/u/329222?","gravatar_id":"248a99f9bda7156fee6c18b3f6346583","url":"https://api.github.com/users/apexskier","html_url":"https://github.com/apexskier","followers_url":"https://api.github.com/users/apexskier/followers","following_url":"https://api.github.com/users/apexskier/following{/other_user}","gists_url":"https://api.github.com/users/apexskier/gists{/gist_id}","starred_url":"https://api.github.com/users/apexskier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apexskier/subscriptions","organizations_url":"https://api.github.com/users/apexskier/orgs","repos_url":"https://api.github.com/users/apexskier/repos","events_url":"https://api.github.com/users/apexskier/events{/privacy}","received_events_url":"https://api.github.com/users/apexskier/received_events","type":"User","site_admin":false},"repo":{"id":12325833,"name":"bootstrap","full_name":"apexskier/bootstrap","owner":{"login":"apexskier","id":329222,"avatar_url":"https://avatars.githubusercontent.com/u/329222?","gravatar_id":"248a99f9bda7156fee6c18b3f6346583","url":"https://api.github.com/users/apexskier","html_url":"https://github.com/apexskier","followers_url":"https://api.github.com/users/apexskier/followers","following_url":"https://api.github.com/users/apexskier/following{/other_user}","gists_url":"https://api.github.com/users/apexskier/gists{/gist_id}","starred_url":"https://api.github.com/users/apexskier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apexskier/subscriptions","organizations_url":"https://api.github.com/users/apexskier/orgs","repos_url":"https://api.github.com/users/apexskier/repos","events_url":"https://api.github.com/users/apexskier/events{/privacy}","received_events_url":"https://api.github.com/users/apexskier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apexskier/bootstrap","description":"Sleek, intuitive, and powerful front-end framework for faster and easier web development.","fork":true,"url":"https://api.github.com/repos/apexskier/bootstrap","forks_url":"https://api.github.com/repos/apexskier/bootstrap/forks","keys_url":"https://api.github.com/repos/apexskier/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apexskier/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apexskier/bootstrap/teams","hooks_url":"https://api.github.com/repos/apexskier/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/apexskier/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/apexskier/bootstrap/events","assignees_url":"https://api.github.com/repos/apexskier/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/apexskier/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/apexskier/bootstrap/tags","blobs_url":"https://api.github.com/repos/apexskier/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apexskier/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apexskier/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/apexskier/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apexskier/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/apexskier/bootstrap/languages","stargazers_url":"https://api.github.com/repos/apexskier/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/apexskier/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/apexskier/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/apexskier/bootstrap/subscription","commits_url":"https://api.github.com/repos/apexskier/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/apexskier/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/apexskier/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/apexskier/bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/apexskier/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/apexskier/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apexskier/bootstrap/merges","archive_url":"https://api.github.com/repos/apexskier/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apexskier/bootstrap/downloads","issues_url":"https://api.github.com/repos/apexskier/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/apexskier/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/apexskier/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/apexskier/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apexskier/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/apexskier/bootstrap/releases{/id}","created_at":"2013-08-23T15:06:33Z","updated_at":"2014-07-15T17:19:18Z","pushed_at":"2014-07-15T22:40:25Z","git_url":"git://github.com/apexskier/bootstrap.git","ssh_url":"git@github.com:apexskier/bootstrap.git","clone_url":"https://github.com/apexskier/bootstrap.git","svn_url":"https://github.com/apexskier/bootstrap","homepage":"http://twbs.github.io/bootstrap/","size":41561,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twbs:master","ref":"master","sha":"dd22f599998cc07c18b6643a856d5acda6c5c122","user":{"login":"twbs","id":2918581,"avatar_url":"https://avatars.githubusercontent.com/u/2918581?","gravatar_id":"025073862721c9b5af4a0269eabecb8e","url":"https://api.github.com/users/twbs","html_url":"https://github.com/twbs","followers_url":"https://api.github.com/users/twbs/followers","following_url":"https://api.github.com/users/twbs/following{/other_user}","gists_url":"https://api.github.com/users/twbs/gists{/gist_id}","starred_url":"https://api.github.com/users/twbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twbs/subscriptions","organizations_url":"https://api.github.com/users/twbs/orgs","repos_url":"https://api.github.com/users/twbs/repos","events_url":"https://api.github.com/users/twbs/events{/privacy}","received_events_url":"https://api.github.com/users/twbs/received_events","type":"Organization","site_admin":false},"repo":{"id":2126244,"name":"bootstrap","full_name":"twbs/bootstrap","owner":{"login":"twbs","id":2918581,"avatar_url":"https://avatars.githubusercontent.com/u/2918581?","gravatar_id":"025073862721c9b5af4a0269eabecb8e","url":"https://api.github.com/users/twbs","html_url":"https://github.com/twbs","followers_url":"https://api.github.com/users/twbs/followers","following_url":"https://api.github.com/users/twbs/following{/other_user}","gists_url":"https://api.github.com/users/twbs/gists{/gist_id}","starred_url":"https://api.github.com/users/twbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twbs/subscriptions","organizations_url":"https://api.github.com/users/twbs/orgs","repos_url":"https://api.github.com/users/twbs/repos","events_url":"https://api.github.com/users/twbs/events{/privacy}","received_events_url":"https://api.github.com/users/twbs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twbs/bootstrap","description":"The most popular front-end framework for developing responsive, mobile first projects on the web.","fork":false,"url":"https://api.github.com/repos/twbs/bootstrap","forks_url":"https://api.github.com/repos/twbs/bootstrap/forks","keys_url":"https://api.github.com/repos/twbs/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twbs/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twbs/bootstrap/teams","hooks_url":"https://api.github.com/repos/twbs/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/twbs/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/twbs/bootstrap/events","assignees_url":"https://api.github.com/repos/twbs/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/twbs/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/twbs/bootstrap/tags","blobs_url":"https://api.github.com/repos/twbs/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twbs/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twbs/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/twbs/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twbs/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/twbs/bootstrap/languages","stargazers_url":"https://api.github.com/repos/twbs/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/twbs/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/twbs/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/twbs/bootstrap/subscription","commits_url":"https://api.github.com/repos/twbs/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/twbs/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/twbs/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/twbs/bootstrap/issues/comments/{number}","contents_url":"https://api.github.com/repos/twbs/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/twbs/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twbs/bootstrap/merges","archive_url":"https://api.github.com/repos/twbs/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twbs/bootstrap/downloads","issues_url":"https://api.github.com/repos/twbs/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/twbs/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/twbs/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/twbs/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twbs/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/twbs/bootstrap/releases{/id}","created_at":"2011-07-29T21:19:00Z","updated_at":"2014-07-15T23:36:11Z","pushed_at":"2014-07-15T18:09:52Z","git_url":"git://github.com/twbs/bootstrap.git","ssh_url":"git@github.com:twbs/bootstrap.git","clone_url":"https://github.com/twbs/bootstrap.git","svn_url":"https://github.com/twbs/bootstrap","homepage":"http://getbootstrap.com","size":149724,"stargazers_count":69782,"watchers_count":69782,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":25830,"mirror_url":null,"open_issues_count":94,"forks":25830,"open_issues":94,"watchers":69782,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/14153"},"html":{"href":"https://github.com/twbs/bootstrap/pull/14153"},"issue":{"href":"https://api.github.com/repos/twbs/bootstrap/issues/14153"},"comments":{"href":"https://api.github.com/repos/twbs/bootstrap/issues/14153/comments"},"review_comments":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/14153/comments"},"review_comment":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/14153/commits"},"statuses":{"href":"https://api.github.com/repos/twbs/bootstrap/statuses/553f914e11a12a6d24faf51b82fa2bc6a0b8b53b"}}}}