GitHub PushEvent at 2014-05-14 04:32:47
Repository: subsurface
Actor: acrlakshman
Payload: {"shas":[["81ec6f3176e3985a5f60d4ca34ed8de23e17786a","0c597d45353d741b4835ff5e56c2bc263abede5d@gmail.com","CodingStyle \"to\" \"too\" typo\n\nSmall typo in CodingStyle.\n\".. in this file to.\" should be \"... in this file too.\"\n\nSigned-off-by: Jeremiah Mahler <jmmahler@gmail.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Jeremiah Mahler",true],["e1e0ac9ae9443966a096e9c2402674e4be28aa25","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","Move unit related code to units.h\n\nThe units are used everywhere in the application, we don't really\nneed to include \"dive.h\" to be able to use unit conversion, so I\nchanged them to a new file. There is still a lot of non-dive stuff\nin dive.h / c, I'll try to move more later.\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true],["3b7624ff464b323fc3c271787a36faa1e97a7b27","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","Remove old defines.\n\nThose were from the ancient Gtk times where we hardcoded the white stars\nand black stars as font glyphs instead of drawing them. get rid of it.\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true],["cf848e52330fa0bca2ccc0fb5de5f2a4033fbafa","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","Correct the usage of std::string and QString\n\nQStrings shouldn't be == \"\" to check for empty string, use .isEmpty()\nQStrings shouldn't be != \"\" to check for non empty, use .size()\nstd::string shouldn't be cleared with = \"\", use .clear()\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true],["2dd96b4f393ef83d680c7964d6c2f906c99c01f5","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","Simplify code.\n\nthis is not necessary when you don't have a variable\nthat has the exact same name as the 'this->variable' name,\n\nalso, there's no need to check if a QString is empty\nbefore trying to use the == on them.\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true],["4eaceb98614e28ab8c20baa1513733e0e662c7df","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","'Class' string is unecessary when using a Container.\n\npretty self explanatory, the 'class' keyword is unecessary\nwhen defining things inside a Container, be it a QList,\nQVector, QMap, QHahs or anything else.\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true],["4b8a66f4899cb337899ec1d35058ab7fc1b1bc86","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","When creating methods that pass QString, use const QString&\n\nThis removes unecessary creation and destruction of the object\nmaking the code shine a bit more and be more fluffy. :)\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true],["25e0fdcb162d9ede9a4a49b36d05f0b77ece1056","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","use for_each_dive instead of hand-written loop.\n\nIt's easyer to make a mistake in the loop insteaf of\nusing the currently correct one that's already written\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true],["9e8c0c936645e9cd5b9f0a34f305cdcf81f2ed2c","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","Prefix a method with 'dive_' because it should work only with dives\n\nI'll probably add prefixes to functions to make it easier to find method\nvia autocomplete from the grep or interface helpers, do you wanna know all\nthe functions that works with a dive?  ask for the completion for dive_,\ndo you wanna know all the functions that works with a divelist? ask for\nthe completions on divelist_ or run grep -rIs divelist_ on the header\nfiles.\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true],["5702a520784f83ad9cb84d1f2115ac174de1fa26","0c597d45353d741b4835ff5e56c2bc263abede5d@gmail.com","Documentation spelling errors\n\nA general review of the documentation has found more spelling errors.\n\nSigned-off-by: Jeremiah Mahler <jmmahler@gmail.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Jeremiah Mahler",true],["f692c39ac793ed999d47d29fd2306910403ad06a","a00b27378a09822d5638cdfb8c2e7ccc36d74c56@hohndel.org","Uemis downloader: fix corner case\n\nWhen we first get an invalid dive info and then, once we decremented the\noffset, get a valid one but for the wrong dive and then try to calculate\nthe correct offset, we need to keep the existing offset in mind.\n\nWhat a horrid design. Thanks, UEMIS.\n\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Dirk Hohndel",true],["d1839769ee37c779632f1581724864e957381c04","69652caca27c8b940640ad396ab71f93cacec34f@linux-foundation.org","Fix git loading of odd locales\n\nThis should make git loading be able to load git saves with arbitrary\nweekday names. Even strange German ones.\n\nSigned-off-by: Linus Torvalds <torvalds@linux-foundation.org>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Linus Torvalds",true],["05e00866312b177ff64fa6e5bcd565871a66d172","69652caca27c8b940640ad396ab71f93cacec34f@linux-foundation.org","Don't use locale for git save format\n\nI stupidly used \"weekday()\" without realizing we localize it. And we\nreally don't want to make save formats be localized (we don't localize\ndecimal numbers etc either).\n\nThis fixes the git save format to just use a hardcoded weekday list.\n\nSigned-off-by: Linus Torvalds <torvalds@linux-foundation.org>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Linus Torvalds",true],["2b06e4be671930bc22feb830f328871a31315d9f","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","Move printGpsCoords from MainTab to QtHelper\n\nLast time I touched this I got a scream from dirk, but then I\nlooked at the code again and the problem that I faced was that\nI broke translations in a sad way, well, now I broke it again.\n\nHowever, this method shouldn't belong to MainTab ( because of\nthat thingy that I said before and also many others: Separate\nthe logic of your application from the UI specific code )\n\nThis generates a string that's going to be used on the Interface,\nit doesn't display it on the interface. Move it down below makes\nit easier to test ( I don't need to create an Widget and worry\nabout the parent-relationship with the mainwindow just to test\nthis function, for instance. )\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true],["6ab05563b3c6564d0a5e88edd8b23cb149a1eb6f","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","Move DiveList related methods/classes to own file.\n\nThe DiveList classes were a partial mess (and some of it is still in a\nmessy state). The classes that deal with it where done in 'qtHelpers.h',\nthe extern global variable in dive.h, a few methods here and there. This\nconcentrates most - but not all - functions in their own file. The reason\nfor that is to make the new developer faster when looking for things: if\nit's a divecomputer related method, it should be in a single file, not\nscattered around.\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true],["e1971e9425dfc5266fa1e15579ff36d2b17658da","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","rename 'get_dive_by_diveid' to 'get_dive_by_uemis_diveid'\n\nA bit longer, but we had a function named get_dive_by_diveid\nand another one named getDiveByDiveid that did completely\ndifferent things, it was too easy to hit the wrong one..\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true],["e0c0ac5d5c7c218011278fbe57da291a7e10c8eb","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","Rename getDiveById to get_dive_by_id to keep current c code organized.\n\nThis commit renames getDiveById to get_dive_by_id, and it also removes the\nQ_ASSERTS and if(!dive) return that the callers of this function were\ncalling. If it has a Q_ASSERT this means that the dive must exist,\nso checking for nullness was bogus too. I've changed the assert (done\nin a silly C-Way.\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true],["c86d055db77cdeef6049449ac79fe404c40d28cc","ccb3839ae5be3c29427fdefd1acdf43769f66bb0@intel.com","Do not check for null before free.\n\nC specs says that we can safelly free a NULL pointer, so there's no reason\nto check if it's null before freeing it.\n\nSigned-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>\nSigned-off-by: Dirk Hohndel <dirk@hohndel.org>","Tomaz Canabrava",true]],"size":18,"ref":"refs/heads/master","head":"c86d055db77cdeef6049449ac79fe404c40d28cc"}