GitHub PullRequestEvent at 2014-11-13 19:00:04
Repository: docker
Actor: unclejack
Payload: {"action":"closed","number":8589,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/8589","id":22803256,"html_url":"https://github.com/docker/docker/pull/8589","diff_url":"https://github.com/docker/docker/pull/8589.diff","patch_url":"https://github.com/docker/docker/pull/8589.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/8589","number":8589,"state":"closed","locked":false,"title":"Initial work to allow typed errors from Jobs","user":{"login":"hickeng","id":3923729,"avatar_url":"https://avatars.githubusercontent.com/u/3923729?v=3","gravatar_id":"","url":"https://api.github.com/users/hickeng","html_url":"https://github.com/hickeng","followers_url":"https://api.github.com/users/hickeng/followers","following_url":"https://api.github.com/users/hickeng/following{/other_user}","gists_url":"https://api.github.com/users/hickeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hickeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hickeng/subscriptions","organizations_url":"https://api.github.com/users/hickeng/orgs","repos_url":"https://api.github.com/users/hickeng/repos","events_url":"https://api.github.com/users/hickeng/events{/privacy}","received_events_url":"https://api.github.com/users/hickeng/received_events","type":"User","site_admin":false},"body":"This change allows for typed error returns from engine Jobs.\r\nThere are types defined for the basic errors in httpError and some additional types mirroring http response codes.\r\nModification of the wider codebase to use those typed errors has been done to the extent necessary to pass the test suite. There is work to be done verifying the completeness of that coverage, converting remaining untyped errors and adding additional per error fields as needed.","created_at":"2014-10-15T18:14:32Z","updated_at":"2014-11-13T19:00:03Z","closed_at":"2014-11-13T19:00:03Z","merged_at":null,"merge_commit_sha":"835f48d878368be0172104e27caefbf0cfc83bbe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/8589/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/8589/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/docker/issues/8589/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/4516265892f899f279018c92ed2104d574eb4199","head":{"label":"vmware:typed_errors","ref":"typed_errors","sha":"4516265892f899f279018c92ed2104d574eb4199","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":24651435,"name":"docker","full_name":"vmware/docker","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/vmware/docker","forks_url":"https://api.github.com/repos/vmware/docker/forks","keys_url":"https://api.github.com/repos/vmware/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/docker/teams","hooks_url":"https://api.github.com/repos/vmware/docker/hooks","issue_events_url":"https://api.github.com/repos/vmware/docker/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/docker/events","assignees_url":"https://api.github.com/repos/vmware/docker/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/docker/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/docker/tags","blobs_url":"https://api.github.com/repos/vmware/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/docker/languages","stargazers_url":"https://api.github.com/repos/vmware/docker/stargazers","contributors_url":"https://api.github.com/repos/vmware/docker/contributors","subscribers_url":"https://api.github.com/repos/vmware/docker/subscribers","subscription_url":"https://api.github.com/repos/vmware/docker/subscription","commits_url":"https://api.github.com/repos/vmware/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/vmware/docker/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/docker/merges","archive_url":"https://api.github.com/repos/vmware/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/docker/downloads","issues_url":"https://api.github.com/repos/vmware/docker/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/docker/labels{/name}","releases_url":"https://api.github.com/repos/vmware/docker/releases{/id}","created_at":"2014-09-30T19:00:03Z","updated_at":"2014-10-10T00:17:20Z","pushed_at":"2014-11-11T06:37:14Z","git_url":"git://github.com/vmware/docker.git","ssh_url":"git@github.com:vmware/docker.git","clone_url":"https://github.com/vmware/docker.git","svn_url":"https://github.com/vmware/docker","homepage":"http://www.docker.com","size":35904,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"9c6346e9b2be615ef93ef50cf24550c8afbe4e39","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2014-11-13T18:37:46Z","pushed_at":"2014-11-13T18:07:14Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":158411,"stargazers_count":16573,"watchers_count":16573,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3278,"mirror_url":null,"open_issues_count":924,"forks":3278,"open_issues":924,"watchers":16573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/8589"},"html":{"href":"https://github.com/docker/docker/pull/8589"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/8589"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/8589/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/8589/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/8589/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/4516265892f899f279018c92ed2104d574eb4199"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":0,"commits":1,"additions":167,"deletions":77,"changed_files":30}}