GitHub PullRequestEvent at 2014-04-13 21:24:40
Repository: vrapper
Actor: keforbes
Payload: {"action":"closed","number":414,"pull_request":{"url":"https://api.github.com/repos/vrapper/vrapper/pulls/414","id":14687197,"html_url":"https://github.com/vrapper/vrapper/pull/414","diff_url":"https://github.com/vrapper/vrapper/pull/414.diff","patch_url":"https://github.com/vrapper/vrapper/pull/414.patch","issue_url":"https://api.github.com/repos/vrapper/vrapper/issues/414","number":414,"state":"closed","title":"'modifiable' boolean option","user":{"login":"albertdev","id":1451362,"avatar_url":"https://avatars.githubusercontent.com/u/1451362?","gravatar_id":"42854d4c0b1d16c5a19d6134a62325e8","url":"https://api.github.com/users/albertdev","html_url":"https://github.com/albertdev","followers_url":"https://api.github.com/users/albertdev/followers","following_url":"https://api.github.com/users/albertdev/following{/other_user}","gists_url":"https://api.github.com/users/albertdev/gists{/gist_id}","starred_url":"https://api.github.com/users/albertdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertdev/subscriptions","organizations_url":"https://api.github.com/users/albertdev/orgs","repos_url":"https://api.github.com/users/albertdev/repos","events_url":"https://api.github.com/users/albertdev/events{/privacy}","received_events_url":"https://api.github.com/users/albertdev/received_events","type":"User","site_admin":false},"body":"The main purpose of this pull request is to add a local 'modifiable' option to every editor to make it (un)modifiable. If this options is unset (false), Vrapper will make no changes to the document and print an error to the status line.\r\n\r\nIf an Eclipse editor reports that it is not editable, another error message will be printed and the 'modifiable' flag will be treated as unset in any case.\r\n\r\nIf 'syncmodifiable' is set (the default), the editor will automatically set the 'modifiable' option when the Eclipse editor is marked as read-only. This setting is a workaround for the fact that Vim has no real autocommands and functions, as Vim users could use the function in http://vim.wikia.com/wiki/Make_buffer_modifiable_state_match_file_readonly_state to do this.\r\n\r\nEDIT: And just to clarify, this fixes #339, at least when the editor reports that the input is read only. The issue talks about a CDT System Header editor which doesn't report this flag, thus a bug report should be filed over at the CDT project.","created_at":"2014-04-12T17:32:27Z","updated_at":"2014-04-13T21:24:39Z","closed_at":"2014-04-13T21:24:39Z","merged_at":"2014-04-13T21:24:39Z","merge_commit_sha":"6f27537685bb7ec9e02a67c6d7c9d192aed7de73","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vrapper/vrapper/pulls/414/commits","review_comments_url":"https://api.github.com/repos/vrapper/vrapper/pulls/414/comments","review_comment_url":"https://api.github.com/repos/vrapper/vrapper/pulls/comments/{number}","comments_url":"https://api.github.com/repos/vrapper/vrapper/issues/414/comments","statuses_url":"https://api.github.com/repos/vrapper/vrapper/statuses/bc0566d9019ac3922bd66070bc0aa6d48c069e3e","head":{"label":"albertdev:modifiable-boolean-option","ref":"modifiable-boolean-option","sha":"bc0566d9019ac3922bd66070bc0aa6d48c069e3e","user":{"login":"albertdev","id":1451362,"avatar_url":"https://avatars.githubusercontent.com/u/1451362?","gravatar_id":"42854d4c0b1d16c5a19d6134a62325e8","url":"https://api.github.com/users/albertdev","html_url":"https://github.com/albertdev","followers_url":"https://api.github.com/users/albertdev/followers","following_url":"https://api.github.com/users/albertdev/following{/other_user}","gists_url":"https://api.github.com/users/albertdev/gists{/gist_id}","starred_url":"https://api.github.com/users/albertdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertdev/subscriptions","organizations_url":"https://api.github.com/users/albertdev/orgs","repos_url":"https://api.github.com/users/albertdev/repos","events_url":"https://api.github.com/users/albertdev/events{/privacy}","received_events_url":"https://api.github.com/users/albertdev/received_events","type":"User","site_admin":false},"repo":{"id":3486154,"name":"vrapper","full_name":"albertdev/vrapper","owner":{"login":"albertdev","id":1451362,"avatar_url":"https://avatars.githubusercontent.com/u/1451362?","gravatar_id":"42854d4c0b1d16c5a19d6134a62325e8","url":"https://api.github.com/users/albertdev","html_url":"https://github.com/albertdev","followers_url":"https://api.github.com/users/albertdev/followers","following_url":"https://api.github.com/users/albertdev/following{/other_user}","gists_url":"https://api.github.com/users/albertdev/gists{/gist_id}","starred_url":"https://api.github.com/users/albertdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertdev/subscriptions","organizations_url":"https://api.github.com/users/albertdev/orgs","repos_url":"https://api.github.com/users/albertdev/repos","events_url":"https://api.github.com/users/albertdev/events{/privacy}","received_events_url":"https://api.github.com/users/albertdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/albertdev/vrapper","description":"Vim-like editing in Eclipse","fork":true,"url":"https://api.github.com/repos/albertdev/vrapper","forks_url":"https://api.github.com/repos/albertdev/vrapper/forks","keys_url":"https://api.github.com/repos/albertdev/vrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/albertdev/vrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/albertdev/vrapper/teams","hooks_url":"https://api.github.com/repos/albertdev/vrapper/hooks","issue_events_url":"https://api.github.com/repos/albertdev/vrapper/issues/events{/number}","events_url":"https://api.github.com/repos/albertdev/vrapper/events","assignees_url":"https://api.github.com/repos/albertdev/vrapper/assignees{/user}","branches_url":"https://api.github.com/repos/albertdev/vrapper/branches{/branch}","tags_url":"https://api.github.com/repos/albertdev/vrapper/tags","blobs_url":"https://api.github.com/repos/albertdev/vrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/albertdev/vrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/albertdev/vrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/albertdev/vrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/albertdev/vrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/albertdev/vrapper/languages","stargazers_url":"https://api.github.com/repos/albertdev/vrapper/stargazers","contributors_url":"https://api.github.com/repos/albertdev/vrapper/contributors","subscribers_url":"https://api.github.com/repos/albertdev/vrapper/subscribers","subscription_url":"https://api.github.com/repos/albertdev/vrapper/subscription","commits_url":"https://api.github.com/repos/albertdev/vrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/albertdev/vrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/albertdev/vrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/albertdev/vrapper/issues/comments/{number}","contents_url":"https://api.github.com/repos/albertdev/vrapper/contents/{+path}","compare_url":"https://api.github.com/repos/albertdev/vrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/albertdev/vrapper/merges","archive_url":"https://api.github.com/repos/albertdev/vrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/albertdev/vrapper/downloads","issues_url":"https://api.github.com/repos/albertdev/vrapper/issues{/number}","pulls_url":"https://api.github.com/repos/albertdev/vrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/albertdev/vrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/albertdev/vrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/albertdev/vrapper/labels{/name}","releases_url":"https://api.github.com/repos/albertdev/vrapper/releases{/id}","created_at":"2012-02-19T15:23:32Z","updated_at":"2014-04-13T21:24:39Z","pushed_at":"2014-04-13T15:11:09Z","git_url":"git://github.com/albertdev/vrapper.git","ssh_url":"git@github.com:albertdev/vrapper.git","clone_url":"https://github.com/albertdev/vrapper.git","svn_url":"https://github.com/albertdev/vrapper","homepage":"http://vrapper.sourceforge.net/","size":6473,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"vrapper:master","ref":"master","sha":"97870cd25c1d841d0a3f2abb7890384cd0e1eaed","user":{"login":"vrapper","id":331180,"avatar_url":"https://avatars.githubusercontent.com/u/331180?","gravatar_id":null,"url":"https://api.github.com/users/vrapper","html_url":"https://github.com/vrapper","followers_url":"https://api.github.com/users/vrapper/followers","following_url":"https://api.github.com/users/vrapper/following{/other_user}","gists_url":"https://api.github.com/users/vrapper/gists{/gist_id}","starred_url":"https://api.github.com/users/vrapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrapper/subscriptions","organizations_url":"https://api.github.com/users/vrapper/orgs","repos_url":"https://api.github.com/users/vrapper/repos","events_url":"https://api.github.com/users/vrapper/events{/privacy}","received_events_url":"https://api.github.com/users/vrapper/received_events","type":"Organization","site_admin":false},"repo":{"id":773194,"name":"vrapper","full_name":"vrapper/vrapper","owner":{"login":"vrapper","id":331180,"avatar_url":"https://avatars.githubusercontent.com/u/331180?","gravatar_id":null,"url":"https://api.github.com/users/vrapper","html_url":"https://github.com/vrapper","followers_url":"https://api.github.com/users/vrapper/followers","following_url":"https://api.github.com/users/vrapper/following{/other_user}","gists_url":"https://api.github.com/users/vrapper/gists{/gist_id}","starred_url":"https://api.github.com/users/vrapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrapper/subscriptions","organizations_url":"https://api.github.com/users/vrapper/orgs","repos_url":"https://api.github.com/users/vrapper/repos","events_url":"https://api.github.com/users/vrapper/events{/privacy}","received_events_url":"https://api.github.com/users/vrapper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vrapper/vrapper","description":"Vim-like editing in Eclipse","fork":false,"url":"https://api.github.com/repos/vrapper/vrapper","forks_url":"https://api.github.com/repos/vrapper/vrapper/forks","keys_url":"https://api.github.com/repos/vrapper/vrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrapper/vrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrapper/vrapper/teams","hooks_url":"https://api.github.com/repos/vrapper/vrapper/hooks","issue_events_url":"https://api.github.com/repos/vrapper/vrapper/issues/events{/number}","events_url":"https://api.github.com/repos/vrapper/vrapper/events","assignees_url":"https://api.github.com/repos/vrapper/vrapper/assignees{/user}","branches_url":"https://api.github.com/repos/vrapper/vrapper/branches{/branch}","tags_url":"https://api.github.com/repos/vrapper/vrapper/tags","blobs_url":"https://api.github.com/repos/vrapper/vrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrapper/vrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrapper/vrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrapper/vrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrapper/vrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/vrapper/vrapper/languages","stargazers_url":"https://api.github.com/repos/vrapper/vrapper/stargazers","contributors_url":"https://api.github.com/repos/vrapper/vrapper/contributors","subscribers_url":"https://api.github.com/repos/vrapper/vrapper/subscribers","subscription_url":"https://api.github.com/repos/vrapper/vrapper/subscription","commits_url":"https://api.github.com/repos/vrapper/vrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrapper/vrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrapper/vrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrapper/vrapper/issues/comments/{number}","contents_url":"https://api.github.com/repos/vrapper/vrapper/contents/{+path}","compare_url":"https://api.github.com/repos/vrapper/vrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrapper/vrapper/merges","archive_url":"https://api.github.com/repos/vrapper/vrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrapper/vrapper/downloads","issues_url":"https://api.github.com/repos/vrapper/vrapper/issues{/number}","pulls_url":"https://api.github.com/repos/vrapper/vrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/vrapper/vrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/vrapper/vrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrapper/vrapper/labels{/name}","releases_url":"https://api.github.com/repos/vrapper/vrapper/releases{/id}","created_at":"2010-07-13T20:15:53Z","updated_at":"2014-04-13T21:24:39Z","pushed_at":"2014-04-13T21:24:39Z","git_url":"git://github.com/vrapper/vrapper.git","ssh_url":"git@github.com:vrapper/vrapper.git","clone_url":"https://github.com/vrapper/vrapper.git","svn_url":"https://github.com/vrapper/vrapper","homepage":"http://vrapper.sourceforge.net/","size":10790,"stargazers_count":479,"watchers_count":479,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":68,"mirror_url":null,"open_issues_count":29,"forks":68,"open_issues":29,"watchers":479,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vrapper/vrapper/pulls/414"},"html":{"href":"https://github.com/vrapper/vrapper/pull/414"},"issue":{"href":"https://api.github.com/repos/vrapper/vrapper/issues/414"},"comments":{"href":"https://api.github.com/repos/vrapper/vrapper/issues/414/comments"},"review_comments":{"href":"https://api.github.com/repos/vrapper/vrapper/pulls/414/comments"},"review_comment":{"href":"https://api.github.com/repos/vrapper/vrapper/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/vrapper/vrapper/pulls/414/commits"},"statuses":{"href":"https://api.github.com/repos/vrapper/vrapper/statuses/bc0566d9019ac3922bd66070bc0aa6d48c069e3e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"keforbes","id":817509,"avatar_url":"https://avatars.githubusercontent.com/u/817509?","gravatar_id":"1484fa593ef0c9002b09e9d141e86cc1","url":"https://api.github.com/users/keforbes","html_url":"https://github.com/keforbes","followers_url":"https://api.github.com/users/keforbes/followers","following_url":"https://api.github.com/users/keforbes/following{/other_user}","gists_url":"https://api.github.com/users/keforbes/gists{/gist_id}","starred_url":"https://api.github.com/users/keforbes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keforbes/subscriptions","organizations_url":"https://api.github.com/users/keforbes/orgs","repos_url":"https://api.github.com/users/keforbes/repos","events_url":"https://api.github.com/users/keforbes/events{/privacy}","received_events_url":"https://api.github.com/users/keforbes/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":7,"additions":263,"deletions":36,"changed_files":14}}