GitHub PullRequestReviewCommentEvent at 2014-10-01 00:31:57
Repository: presto-odbc
Actor: markisaa
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto-odbc/pulls/comments/18256358","id":18256358,"diff_hunk":"@@ -434,13 +434,20 @@ void SQLExecuteImpl(OdbcStatement statementHandle) {\n         logMessage(\"SQLExecuteImpl\", query);\n \n         if (query.empty) {\n-            logMessage(\"Warning: Execiting an empty query!\");\n+            logMessage(\"Warning: Executing an empty query!\");\n             latestOdbcResult = makeWithoutGC!EmptyOdbcResult();\n             executedQuery = true;\n             return;\n         }\n \n-        auto client = runQuery(text(query));\n+        import std.string;\n+        auto queryText = text(query);\n+        if(queryText.indexOf(';') != -1) {\n+            logMessage(\"; found in queryText\");","path":"driver/driver.d","position":15,"original_position":15,"commit_id":"2df8f4288456d8391d8ee344aa77e167cb288550","original_commit_id":"2df8f4288456d8391d8ee344aa77e167cb288550","user":{"login":"markisaa","id":2280568,"avatar_url":"https://avatars.githubusercontent.com/u/2280568?v=2","gravatar_id":"","url":"https://api.github.com/users/markisaa","html_url":"https://github.com/markisaa","followers_url":"https://api.github.com/users/markisaa/followers","following_url":"https://api.github.com/users/markisaa/following{/other_user}","gists_url":"https://api.github.com/users/markisaa/gists{/gist_id}","starred_url":"https://api.github.com/users/markisaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markisaa/subscriptions","organizations_url":"https://api.github.com/users/markisaa/orgs","repos_url":"https://api.github.com/users/markisaa/repos","events_url":"https://api.github.com/users/markisaa/events{/privacy}","received_events_url":"https://api.github.com/users/markisaa/received_events","type":"User","site_admin":false},"body":"This is redundant. dllEnforce logs the message too. Also, prefer throwing an OdbcException to this.","created_at":"2014-10-01T00:31:57Z","updated_at":"2014-10-01T00:31:57Z","html_url":"https://github.com/prestodb/presto-odbc/pull/46#discussion_r18256358","pull_request_url":"https://api.github.com/repos/prestodb/presto-odbc/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto-odbc/pulls/comments/18256358"},"html":{"href":"https://github.com/prestodb/presto-odbc/pull/46#discussion_r18256358"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto-odbc/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto-odbc/pulls/46","id":21686641,"html_url":"https://github.com/prestodb/presto-odbc/pull/46","diff_url":"https://github.com/prestodb/presto-odbc/pull/46.diff","patch_url":"https://github.com/prestodb/presto-odbc/pull/46.patch","issue_url":"https://api.github.com/repos/prestodb/presto-odbc/issues/46","number":46,"state":"open","locked":false,"title":"Queries with a semicolon at the end fail silently","user":{"login":"nezihyigitbasi","id":1223839,"avatar_url":"https://avatars.githubusercontent.com/u/1223839?v=2","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false},"body":"This is confusing for the user as the error message from Tableau is not meaningful. This PR fails queries with ; in them.","created_at":"2014-09-24T01:02:13Z","updated_at":"2014-10-01T00:31:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97deed6173ab46913947b70777fd35e445e5b71b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto-odbc/pulls/46/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto-odbc/pulls/46/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto-odbc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/prestodb/presto-odbc/issues/46/comments","statuses_url":"https://api.github.com/repos/prestodb/presto-odbc/statuses/2df8f4288456d8391d8ee344aa77e167cb288550","head":{"label":"nezihyigitbasi:semicolon_fix","ref":"semicolon_fix","sha":"2df8f4288456d8391d8ee344aa77e167cb288550","user":{"login":"nezihyigitbasi","id":1223839,"avatar_url":"https://avatars.githubusercontent.com/u/1223839?v=2","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false},"repo":{"id":22350194,"name":"presto-odbc","full_name":"nezihyigitbasi/presto-odbc","owner":{"login":"nezihyigitbasi","id":1223839,"avatar_url":"https://avatars.githubusercontent.com/u/1223839?v=2","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nezihyigitbasi/presto-odbc","description":"Presto ODBC Driver","fork":true,"url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc","forks_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/forks","keys_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/teams","hooks_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/hooks","issue_events_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/issues/events{/number}","events_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/events","assignees_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/assignees{/user}","branches_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/branches{/branch}","tags_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/tags","blobs_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/statuses/{sha}","languages_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/languages","stargazers_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/stargazers","contributors_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/contributors","subscribers_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/subscribers","subscription_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/subscription","commits_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/issues/comments/{number}","contents_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/contents/{+path}","compare_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/merges","archive_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/downloads","issues_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/issues{/number}","pulls_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/pulls{/number}","milestones_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/milestones{/number}","notifications_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/labels{/name}","releases_url":"https://api.github.com/repos/nezihyigitbasi/presto-odbc/releases{/id}","created_at":"2014-07-28T16:46:17Z","updated_at":"2014-08-24T09:59:04Z","pushed_at":"2014-09-24T16:42:20Z","git_url":"git://github.com/nezihyigitbasi/presto-odbc.git","ssh_url":"git@github.com:nezihyigitbasi/presto-odbc.git","clone_url":"https://github.com/nezihyigitbasi/presto-odbc.git","svn_url":"https://github.com/nezihyigitbasi/presto-odbc","homepage":null,"size":5084,"stargazers_count":1,"watchers_count":1,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"aa3c7c9e4a6b1cb3495d506188312df71f89bfae","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=2","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":22262721,"name":"presto-odbc","full_name":"prestodb/presto-odbc","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=2","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto-odbc","description":"Presto ODBC Driver","fork":false,"url":"https://api.github.com/repos/prestodb/presto-odbc","forks_url":"https://api.github.com/repos/prestodb/presto-odbc/forks","keys_url":"https://api.github.com/repos/prestodb/presto-odbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto-odbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto-odbc/teams","hooks_url":"https://api.github.com/repos/prestodb/presto-odbc/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto-odbc/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto-odbc/events","assignees_url":"https://api.github.com/repos/prestodb/presto-odbc/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto-odbc/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto-odbc/tags","blobs_url":"https://api.github.com/repos/prestodb/presto-odbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto-odbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto-odbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto-odbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto-odbc/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto-odbc/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto-odbc/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto-odbc/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto-odbc/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto-odbc/subscription","commits_url":"https://api.github.com/repos/prestodb/presto-odbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto-odbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto-odbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto-odbc/issues/comments/{number}","contents_url":"https://api.github.com/repos/prestodb/presto-odbc/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto-odbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto-odbc/merges","archive_url":"https://api.github.com/repos/prestodb/presto-odbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto-odbc/downloads","issues_url":"https://api.github.com/repos/prestodb/presto-odbc/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto-odbc/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto-odbc/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto-odbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto-odbc/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto-odbc/releases{/id}","created_at":"2014-07-25T16:06:27Z","updated_at":"2014-10-01T00:18:12Z","pushed_at":"2014-10-01T00:18:12Z","git_url":"git://github.com/prestodb/presto-odbc.git","ssh_url":"git@github.com:prestodb/presto-odbc.git","clone_url":"https://github.com/prestodb/presto-odbc.git","svn_url":"https://github.com/prestodb/presto-odbc","homepage":null,"size":1051,"stargazers_count":8,"watchers_count":8,"language":"D","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":20,"forks":3,"open_issues":20,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto-odbc/pulls/46"},"html":{"href":"https://github.com/prestodb/presto-odbc/pull/46"},"issue":{"href":"https://api.github.com/repos/prestodb/presto-odbc/issues/46"},"comments":{"href":"https://api.github.com/repos/prestodb/presto-odbc/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto-odbc/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto-odbc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto-odbc/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto-odbc/statuses/2df8f4288456d8391d8ee344aa77e167cb288550"}}}}