GitHub PullRequestReviewCommentEvent at 2014-04-02 19:13:54
Repository: simple_form
Actor: laurocaetano
Payload: {"comment":{"url":"https://api.github.com/repos/plataformatec/simple_form/pulls/comments/11222260","id":11222260,"diff_hunk":"@@ -25,7 +25,7 @@ def with_association_for(object, *args)\n   test 'builder association forwards collection to simple_fields_for' do\n     calls = 0\n     simple_form_for @user do |f|\n-      f.association :company, collection: Company.all do |c|\n+      f.association :company, collection: Company.all.to_a do |c|","path":"test/form_builder/association_test.rb","position":5,"original_position":5,"commit_id":"ab0750628b472009893c0eab19ad08590e7a79c1","original_commit_id":"0bd6a050b85291f11126b2c7c4644501f87d31f4","user":{"login":"laurocaetano","id":611891,"avatar_url":"https://avatars.githubusercontent.com/u/611891?","gravatar_id":"ac590f036f709b213aa8a3e446e7b7ae","url":"https://api.github.com/users/laurocaetano","html_url":"https://github.com/laurocaetano","followers_url":"https://api.github.com/users/laurocaetano/followers","following_url":"https://api.github.com/users/laurocaetano/following{/other_user}","gists_url":"https://api.github.com/users/laurocaetano/gists{/gist_id}","starred_url":"https://api.github.com/users/laurocaetano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurocaetano/subscriptions","organizations_url":"https://api.github.com/users/laurocaetano/orgs","repos_url":"https://api.github.com/users/laurocaetano/repos","events_url":"https://api.github.com/users/laurocaetano/events{/privacy}","received_events_url":"https://api.github.com/users/laurocaetano/received_events","type":"User","site_admin":false},"body":"Not sure if it will call `each`. \r\n\r\nI just followed the execution and it will hit [this line] [1] and then it will call `fields_for_with_nested_attributes` that will do the [convert model] [2].\r\n\r\n[1]: https://github.com/rails/rails/blob/master/actionview/lib/action_view/helpers/form_helper.rb#L1517\r\n[2]: https://github.com/rails/rails/blob/master/actionview/lib/action_view/helpers/form_helper.rb#L1832","created_at":"2014-04-02T19:13:54Z","updated_at":"2014-04-02T19:13:54Z","html_url":"https://github.com/plataformatec/simple_form/pull/1015#discussion_r11222260","pull_request_url":"https://api.github.com/repos/plataformatec/simple_form/pulls/1015","_links":{"self":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/comments/11222260"},"html":{"href":"https://github.com/plataformatec/simple_form/pull/1015#discussion_r11222260"},"pull_request":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/1015"}}}}