GitHub PullRequestEvent at 2014-06-06 16:20:22
Repository: php.mo
Actor: niaccurshi
Payload: {"action":"opened","number":11,"pull_request":{"url":"https://api.github.com/repos/josscrowcroft/php.mo/pulls/11","id":16829151,"html_url":"https://github.com/josscrowcroft/php.mo/pull/11","diff_url":"https://github.com/josscrowcroft/php.mo/pull/11.diff","patch_url":"https://github.com/josscrowcroft/php.mo/pull/11.patch","issue_url":"https://api.github.com/repos/josscrowcroft/php.mo/issues/11","number":11,"state":"open","title":"Fix use of Header Data and empty msgid string","user":{"login":"niaccurshi","id":1426885,"avatar_url":"https://avatars.githubusercontent.com/u/1426885?","gravatar_id":"76f881f8cd63e66837aeb26023e9dd69","url":"https://api.github.com/users/niaccurshi","html_url":"https://github.com/niaccurshi","followers_url":"https://api.github.com/users/niaccurshi/followers","following_url":"https://api.github.com/users/niaccurshi/following{/other_user}","gists_url":"https://api.github.com/users/niaccurshi/gists{/gist_id}","starred_url":"https://api.github.com/users/niaccurshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niaccurshi/subscriptions","organizations_url":"https://api.github.com/users/niaccurshi/orgs","repos_url":"https://api.github.com/users/niaccurshi/repos","events_url":"https://api.github.com/users/niaccurshi/events{/privacy}","received_events_url":"https://api.github.com/users/niaccurshi/received_events","type":"User","site_admin":false},"body":"There is, in spec, an option for header data, however using it properly should be as such:\r\n```\r\n# Translation file for en_US\r\nmsgid \"\"\r\nmsgstr \"\"\r\n\"Content-Type: text/plain; charset=UTF-8\\n\"\r\n\"Content-Transfer-Encoding: 8bit\\n\"\r\n```\r\nBut the empty msgid previously messed up the .mo conversion somehow. by assigning the Header to a space character we hopefully avoid any collision with real translation needs, and allow for the Header to exist.\r\n\r\nAlso implemented David's (http://www.josscrowcroft.com/2011/code/php-mo-convert-gettext-po-file-to-binary-mo-file-php/#comment-150555) amend to allow for empty msgstr data as per spec (empty msgstr should return the original msgid)","created_at":"2014-06-06T16:20:22Z","updated_at":"2014-06-06T16:20:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/josscrowcroft/php.mo/pulls/11/commits","review_comments_url":"https://api.github.com/repos/josscrowcroft/php.mo/pulls/11/comments","review_comment_url":"https://api.github.com/repos/josscrowcroft/php.mo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/josscrowcroft/php.mo/issues/11/comments","statuses_url":"https://api.github.com/repos/josscrowcroft/php.mo/statuses/c2ab4388cad04cf4b814efbf6e3119440527dcd7","head":{"label":"niaccurshi:master","ref":"master","sha":"c2ab4388cad04cf4b814efbf6e3119440527dcd7","user":{"login":"niaccurshi","id":1426885,"avatar_url":"https://avatars.githubusercontent.com/u/1426885?","gravatar_id":"76f881f8cd63e66837aeb26023e9dd69","url":"https://api.github.com/users/niaccurshi","html_url":"https://github.com/niaccurshi","followers_url":"https://api.github.com/users/niaccurshi/followers","following_url":"https://api.github.com/users/niaccurshi/following{/other_user}","gists_url":"https://api.github.com/users/niaccurshi/gists{/gist_id}","starred_url":"https://api.github.com/users/niaccurshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niaccurshi/subscriptions","organizations_url":"https://api.github.com/users/niaccurshi/orgs","repos_url":"https://api.github.com/users/niaccurshi/repos","events_url":"https://api.github.com/users/niaccurshi/events{/privacy}","received_events_url":"https://api.github.com/users/niaccurshi/received_events","type":"User","site_admin":false},"repo":{"id":20569964,"name":"php.mo","full_name":"niaccurshi/php.mo","owner":{"login":"niaccurshi","id":1426885,"avatar_url":"https://avatars.githubusercontent.com/u/1426885?","gravatar_id":"76f881f8cd63e66837aeb26023e9dd69","url":"https://api.github.com/users/niaccurshi","html_url":"https://github.com/niaccurshi","followers_url":"https://api.github.com/users/niaccurshi/followers","following_url":"https://api.github.com/users/niaccurshi/following{/other_user}","gists_url":"https://api.github.com/users/niaccurshi/gists{/gist_id}","starred_url":"https://api.github.com/users/niaccurshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niaccurshi/subscriptions","organizations_url":"https://api.github.com/users/niaccurshi/orgs","repos_url":"https://api.github.com/users/niaccurshi/repos","events_url":"https://api.github.com/users/niaccurshi/events{/privacy}","received_events_url":"https://api.github.com/users/niaccurshi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niaccurshi/php.mo","description":"Converts gettext translation '.po' files to binary '.mo' files in PHP","fork":true,"url":"https://api.github.com/repos/niaccurshi/php.mo","forks_url":"https://api.github.com/repos/niaccurshi/php.mo/forks","keys_url":"https://api.github.com/repos/niaccurshi/php.mo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niaccurshi/php.mo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niaccurshi/php.mo/teams","hooks_url":"https://api.github.com/repos/niaccurshi/php.mo/hooks","issue_events_url":"https://api.github.com/repos/niaccurshi/php.mo/issues/events{/number}","events_url":"https://api.github.com/repos/niaccurshi/php.mo/events","assignees_url":"https://api.github.com/repos/niaccurshi/php.mo/assignees{/user}","branches_url":"https://api.github.com/repos/niaccurshi/php.mo/branches{/branch}","tags_url":"https://api.github.com/repos/niaccurshi/php.mo/tags","blobs_url":"https://api.github.com/repos/niaccurshi/php.mo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niaccurshi/php.mo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niaccurshi/php.mo/git/refs{/sha}","trees_url":"https://api.github.com/repos/niaccurshi/php.mo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niaccurshi/php.mo/statuses/{sha}","languages_url":"https://api.github.com/repos/niaccurshi/php.mo/languages","stargazers_url":"https://api.github.com/repos/niaccurshi/php.mo/stargazers","contributors_url":"https://api.github.com/repos/niaccurshi/php.mo/contributors","subscribers_url":"https://api.github.com/repos/niaccurshi/php.mo/subscribers","subscription_url":"https://api.github.com/repos/niaccurshi/php.mo/subscription","commits_url":"https://api.github.com/repos/niaccurshi/php.mo/commits{/sha}","git_commits_url":"https://api.github.com/repos/niaccurshi/php.mo/git/commits{/sha}","comments_url":"https://api.github.com/repos/niaccurshi/php.mo/comments{/number}","issue_comment_url":"https://api.github.com/repos/niaccurshi/php.mo/issues/comments/{number}","contents_url":"https://api.github.com/repos/niaccurshi/php.mo/contents/{+path}","compare_url":"https://api.github.com/repos/niaccurshi/php.mo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niaccurshi/php.mo/merges","archive_url":"https://api.github.com/repos/niaccurshi/php.mo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niaccurshi/php.mo/downloads","issues_url":"https://api.github.com/repos/niaccurshi/php.mo/issues{/number}","pulls_url":"https://api.github.com/repos/niaccurshi/php.mo/pulls{/number}","milestones_url":"https://api.github.com/repos/niaccurshi/php.mo/milestones{/number}","notifications_url":"https://api.github.com/repos/niaccurshi/php.mo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niaccurshi/php.mo/labels{/name}","releases_url":"https://api.github.com/repos/niaccurshi/php.mo/releases{/id}","created_at":"2014-06-06T16:12:09Z","updated_at":"2014-06-06T16:20:22Z","pushed_at":"2014-06-06T16:16:51Z","git_url":"git://github.com/niaccurshi/php.mo.git","ssh_url":"git@github.com:niaccurshi/php.mo.git","clone_url":"https://github.com/niaccurshi/php.mo.git","svn_url":"https://github.com/niaccurshi/php.mo","homepage":"","size":107,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"josscrowcroft:master","ref":"master","sha":"a92b571f1ef90d0a21f7ffad949ba288c0d60cfb","user":{"login":"josscrowcroft","id":355489,"avatar_url":"https://avatars.githubusercontent.com/u/355489?","gravatar_id":"ca2ed6af8dcfee6c284f5574d1a1ea1f","url":"https://api.github.com/users/josscrowcroft","html_url":"https://github.com/josscrowcroft","followers_url":"https://api.github.com/users/josscrowcroft/followers","following_url":"https://api.github.com/users/josscrowcroft/following{/other_user}","gists_url":"https://api.github.com/users/josscrowcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/josscrowcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josscrowcroft/subscriptions","organizations_url":"https://api.github.com/users/josscrowcroft/orgs","repos_url":"https://api.github.com/users/josscrowcroft/repos","events_url":"https://api.github.com/users/josscrowcroft/events{/privacy}","received_events_url":"https://api.github.com/users/josscrowcroft/received_events","type":"User","site_admin":false},"repo":{"id":1675346,"name":"php.mo","full_name":"josscrowcroft/php.mo","owner":{"login":"josscrowcroft","id":355489,"avatar_url":"https://avatars.githubusercontent.com/u/355489?","gravatar_id":"ca2ed6af8dcfee6c284f5574d1a1ea1f","url":"https://api.github.com/users/josscrowcroft","html_url":"https://github.com/josscrowcroft","followers_url":"https://api.github.com/users/josscrowcroft/followers","following_url":"https://api.github.com/users/josscrowcroft/following{/other_user}","gists_url":"https://api.github.com/users/josscrowcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/josscrowcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josscrowcroft/subscriptions","organizations_url":"https://api.github.com/users/josscrowcroft/orgs","repos_url":"https://api.github.com/users/josscrowcroft/repos","events_url":"https://api.github.com/users/josscrowcroft/events{/privacy}","received_events_url":"https://api.github.com/users/josscrowcroft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josscrowcroft/php.mo","description":"Converts gettext translation '.po' files to binary '.mo' files in PHP","fork":false,"url":"https://api.github.com/repos/josscrowcroft/php.mo","forks_url":"https://api.github.com/repos/josscrowcroft/php.mo/forks","keys_url":"https://api.github.com/repos/josscrowcroft/php.mo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josscrowcroft/php.mo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josscrowcroft/php.mo/teams","hooks_url":"https://api.github.com/repos/josscrowcroft/php.mo/hooks","issue_events_url":"https://api.github.com/repos/josscrowcroft/php.mo/issues/events{/number}","events_url":"https://api.github.com/repos/josscrowcroft/php.mo/events","assignees_url":"https://api.github.com/repos/josscrowcroft/php.mo/assignees{/user}","branches_url":"https://api.github.com/repos/josscrowcroft/php.mo/branches{/branch}","tags_url":"https://api.github.com/repos/josscrowcroft/php.mo/tags","blobs_url":"https://api.github.com/repos/josscrowcroft/php.mo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josscrowcroft/php.mo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josscrowcroft/php.mo/git/refs{/sha}","trees_url":"https://api.github.com/repos/josscrowcroft/php.mo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josscrowcroft/php.mo/statuses/{sha}","languages_url":"https://api.github.com/repos/josscrowcroft/php.mo/languages","stargazers_url":"https://api.github.com/repos/josscrowcroft/php.mo/stargazers","contributors_url":"https://api.github.com/repos/josscrowcroft/php.mo/contributors","subscribers_url":"https://api.github.com/repos/josscrowcroft/php.mo/subscribers","subscription_url":"https://api.github.com/repos/josscrowcroft/php.mo/subscription","commits_url":"https://api.github.com/repos/josscrowcroft/php.mo/commits{/sha}","git_commits_url":"https://api.github.com/repos/josscrowcroft/php.mo/git/commits{/sha}","comments_url":"https://api.github.com/repos/josscrowcroft/php.mo/comments{/number}","issue_comment_url":"https://api.github.com/repos/josscrowcroft/php.mo/issues/comments/{number}","contents_url":"https://api.github.com/repos/josscrowcroft/php.mo/contents/{+path}","compare_url":"https://api.github.com/repos/josscrowcroft/php.mo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josscrowcroft/php.mo/merges","archive_url":"https://api.github.com/repos/josscrowcroft/php.mo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josscrowcroft/php.mo/downloads","issues_url":"https://api.github.com/repos/josscrowcroft/php.mo/issues{/number}","pulls_url":"https://api.github.com/repos/josscrowcroft/php.mo/pulls{/number}","milestones_url":"https://api.github.com/repos/josscrowcroft/php.mo/milestones{/number}","notifications_url":"https://api.github.com/repos/josscrowcroft/php.mo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josscrowcroft/php.mo/labels{/name}","releases_url":"https://api.github.com/repos/josscrowcroft/php.mo/releases{/id}","created_at":"2011-04-28T11:25:03Z","updated_at":"2014-06-06T11:23:50Z","pushed_at":"2012-05-31T10:10:55Z","git_url":"git://github.com/josscrowcroft/php.mo.git","ssh_url":"git@github.com:josscrowcroft/php.mo.git","clone_url":"https://github.com/josscrowcroft/php.mo.git","svn_url":"https://github.com/josscrowcroft/php.mo","homepage":"","size":107,"stargazers_count":127,"watchers_count":127,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":29,"mirror_url":null,"open_issues_count":10,"forks":29,"open_issues":10,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/josscrowcroft/php.mo/pulls/11"},"html":{"href":"https://github.com/josscrowcroft/php.mo/pull/11"},"issue":{"href":"https://api.github.com/repos/josscrowcroft/php.mo/issues/11"},"comments":{"href":"https://api.github.com/repos/josscrowcroft/php.mo/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/josscrowcroft/php.mo/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/josscrowcroft/php.mo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/josscrowcroft/php.mo/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/josscrowcroft/php.mo/statuses/c2ab4388cad04cf4b814efbf6e3119440527dcd7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":3,"changed_files":1}}