GitHub PushEvent at 2014-09-13 20:40:28
Repository: boto
Actor: EaterOA
Payload: {"shas":[["ab464f99456d12a9dcc18a216849a89ffd7ede5e","3de00e782854288e6d276b3a8ea3beb8ea5764ac@ucla.edu","Added method TaggedEC2Object.remove_tags()\n\nPull Request #2259 already created an add_tags method to supplement the add_tag\ncall. Not sure why there isn't an analogous remove_tags method, since the\nDeleteTags API also supports removng multiple tags at once. An immediate use\ncase is to be able to delete all the tags of an instance; with only remove_tag,\nthis will unnecessarily involve many round trips to AWS.","Vincent Wong",true],["74b37400324ad31039f38618d05b9fdaf05815d4","3de00e782854288e6d276b3a8ea3beb8ea5764ac@ucla.edu","Removed duplicate code in add_tag and remove_tag\n\nSince add_tags is a more general version of add_tag that uses the same API\ncall, add_tag can simply call add_tags with the correct parameters. Likewise\nfor remove_tag and remove_tags.\n\nFor remove_tag in particular, these lines were redundant:\n\n    if value is not None:\n        tags = {key : value}\n    else:\n        tags = [key]\n\nSince EC2Connection.delete_tags just converts the list back to a dict of {key:\nNone} anyway, these extra checks serve no purpose.","Vincent Wong",true],["c269cbe996d28fef383ab7a5dbb0b1ae6b0015af","3de00e782854288e6d276b3a8ea3beb8ea5764ac@ucla.edu","Fixed remove_tags not checking values, fixed test\n\nFixed Issue #2414. remove_tags now locally verifies that the value given for a\nkey matches the one in self.tags before deleting it.\n\nFixed TestRemoveTags.test_remove_tag_empty_value in ec2/test_ec2object. An\nempty string is _not_ supposed to act like None to unconditionally delete the\ntag. The original test acted like it does.","Vincent Wong",true],["2a8c5729e917d4161ea90cab950408131b851b36","3de00e782854288e6d276b3a8ea3beb8ea5764ac@ucla.edu","Added tests for TaggedEC2Object.remove_tags\n\nThere are 3 tests: test_remove_tags simply makes sure multiple tags are deleted\nin one request. test_remove_tags_wrong_values makes sure tags that are provided\nwrong values are not deleted. test_remove_tags_none_values make sure that tags\nprovided with None values are unconditionally deleted.","Vincent Wong",true]],"size":4,"ref":"refs/heads/develop","head":"2a8c5729e917d4161ea90cab950408131b851b36"}