GitHub PullRequestEvent at 2014-06-25 17:43:46
Repository: actionhero
Actor: panva
Payload: {"action":"opened","number":410,"pull_request":{"url":"https://api.github.com/repos/evantahler/actionhero/pulls/410","id":17605170,"html_url":"https://github.com/evantahler/actionhero/pull/410","diff_url":"https://github.com/evantahler/actionhero/pull/410.diff","patch_url":"https://github.com/evantahler/actionhero/pull/410.patch","issue_url":"https://api.github.com/repos/evantahler/actionhero/issues/410","number":410,"state":"open","title":"errors while trying out redis-sentinel package","user":{"login":"panva","id":241506,"avatar_url":"https://avatars.githubusercontent.com/u/241506?","gravatar_id":"7592599cb0a171b5319cd352c5a35090","url":"https://api.github.com/users/panva","html_url":"https://github.com/panva","followers_url":"https://api.github.com/users/panva/followers","following_url":"https://api.github.com/users/panva/following{/other_user}","gists_url":"https://api.github.com/users/panva/gists{/gist_id}","starred_url":"https://api.github.com/users/panva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panva/subscriptions","organizations_url":"https://api.github.com/users/panva/orgs","repos_url":"https://api.github.com/users/panva/repos","events_url":"https://api.github.com/users/panva/events{/privacy}","received_events_url":"https://api.github.com/users/panva/received_events","type":"User","site_admin":false},"body":"Hi, while trying to use redis-sentinel package i've run into issues that actionhero is trying to issue calls before the driver actually emits connect. This PR makes sure both have emitted connect before passing on to the stack. Same issue is happening inside node-resque and i'll try to create PR there aswell.","created_at":"2014-06-25T17:43:46Z","updated_at":"2014-06-25T17:43:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/evantahler/actionhero/pulls/410/commits","review_comments_url":"https://api.github.com/repos/evantahler/actionhero/pulls/410/comments","review_comment_url":"https://api.github.com/repos/evantahler/actionhero/pulls/comments/{number}","comments_url":"https://api.github.com/repos/evantahler/actionhero/issues/410/comments","statuses_url":"https://api.github.com/repos/evantahler/actionhero/statuses/dd507c9e0edbd5d336753e20e27f0e2fbf71bd1d","head":{"label":"panva:redis-sentinel-adjustments","ref":"redis-sentinel-adjustments","sha":"dd507c9e0edbd5d336753e20e27f0e2fbf71bd1d","user":{"login":"panva","id":241506,"avatar_url":"https://avatars.githubusercontent.com/u/241506?","gravatar_id":"7592599cb0a171b5319cd352c5a35090","url":"https://api.github.com/users/panva","html_url":"https://github.com/panva","followers_url":"https://api.github.com/users/panva/followers","following_url":"https://api.github.com/users/panva/following{/other_user}","gists_url":"https://api.github.com/users/panva/gists{/gist_id}","starred_url":"https://api.github.com/users/panva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panva/subscriptions","organizations_url":"https://api.github.com/users/panva/orgs","repos_url":"https://api.github.com/users/panva/repos","events_url":"https://api.github.com/users/panva/events{/privacy}","received_events_url":"https://api.github.com/users/panva/received_events","type":"User","site_admin":false},"repo":{"id":21210161,"name":"actionhero","full_name":"panva/actionhero","owner":{"login":"panva","id":241506,"avatar_url":"https://avatars.githubusercontent.com/u/241506?","gravatar_id":"7592599cb0a171b5319cd352c5a35090","url":"https://api.github.com/users/panva","html_url":"https://github.com/panva","followers_url":"https://api.github.com/users/panva/followers","following_url":"https://api.github.com/users/panva/following{/other_user}","gists_url":"https://api.github.com/users/panva/gists{/gist_id}","starred_url":"https://api.github.com/users/panva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panva/subscriptions","organizations_url":"https://api.github.com/users/panva/orgs","repos_url":"https://api.github.com/users/panva/repos","events_url":"https://api.github.com/users/panva/events{/privacy}","received_events_url":"https://api.github.com/users/panva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/panva/actionhero","description":"actionhero.js is a multi-transport API Server with integrated cluster capabilites and delayed tasks","fork":true,"url":"https://api.github.com/repos/panva/actionhero","forks_url":"https://api.github.com/repos/panva/actionhero/forks","keys_url":"https://api.github.com/repos/panva/actionhero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/panva/actionhero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/panva/actionhero/teams","hooks_url":"https://api.github.com/repos/panva/actionhero/hooks","issue_events_url":"https://api.github.com/repos/panva/actionhero/issues/events{/number}","events_url":"https://api.github.com/repos/panva/actionhero/events","assignees_url":"https://api.github.com/repos/panva/actionhero/assignees{/user}","branches_url":"https://api.github.com/repos/panva/actionhero/branches{/branch}","tags_url":"https://api.github.com/repos/panva/actionhero/tags","blobs_url":"https://api.github.com/repos/panva/actionhero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/panva/actionhero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/panva/actionhero/git/refs{/sha}","trees_url":"https://api.github.com/repos/panva/actionhero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/panva/actionhero/statuses/{sha}","languages_url":"https://api.github.com/repos/panva/actionhero/languages","stargazers_url":"https://api.github.com/repos/panva/actionhero/stargazers","contributors_url":"https://api.github.com/repos/panva/actionhero/contributors","subscribers_url":"https://api.github.com/repos/panva/actionhero/subscribers","subscription_url":"https://api.github.com/repos/panva/actionhero/subscription","commits_url":"https://api.github.com/repos/panva/actionhero/commits{/sha}","git_commits_url":"https://api.github.com/repos/panva/actionhero/git/commits{/sha}","comments_url":"https://api.github.com/repos/panva/actionhero/comments{/number}","issue_comment_url":"https://api.github.com/repos/panva/actionhero/issues/comments/{number}","contents_url":"https://api.github.com/repos/panva/actionhero/contents/{+path}","compare_url":"https://api.github.com/repos/panva/actionhero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/panva/actionhero/merges","archive_url":"https://api.github.com/repos/panva/actionhero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/panva/actionhero/downloads","issues_url":"https://api.github.com/repos/panva/actionhero/issues{/number}","pulls_url":"https://api.github.com/repos/panva/actionhero/pulls{/number}","milestones_url":"https://api.github.com/repos/panva/actionhero/milestones{/number}","notifications_url":"https://api.github.com/repos/panva/actionhero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/panva/actionhero/labels{/name}","releases_url":"https://api.github.com/repos/panva/actionhero/releases{/id}","created_at":"2014-06-25T16:23:19Z","updated_at":"2014-06-25T12:56:29Z","pushed_at":"2014-06-25T17:41:37Z","git_url":"git://github.com/panva/actionhero.git","ssh_url":"git@github.com:panva/actionhero.git","clone_url":"https://github.com/panva/actionhero.git","svn_url":"https://github.com/panva/actionhero","homepage":"www.actionherojs.com","size":25641,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"evantahler:master","ref":"master","sha":"4b2709a27cadc1296232a5bb611046388cc4b715","user":{"login":"evantahler","id":303226,"avatar_url":"https://avatars.githubusercontent.com/u/303226?","gravatar_id":"173e23850a81c3f494ae957e1417c02d","url":"https://api.github.com/users/evantahler","html_url":"https://github.com/evantahler","followers_url":"https://api.github.com/users/evantahler/followers","following_url":"https://api.github.com/users/evantahler/following{/other_user}","gists_url":"https://api.github.com/users/evantahler/gists{/gist_id}","starred_url":"https://api.github.com/users/evantahler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evantahler/subscriptions","organizations_url":"https://api.github.com/users/evantahler/orgs","repos_url":"https://api.github.com/users/evantahler/repos","events_url":"https://api.github.com/users/evantahler/events{/privacy}","received_events_url":"https://api.github.com/users/evantahler/received_events","type":"User","site_admin":false},"repo":{"id":2491877,"name":"actionhero","full_name":"evantahler/actionhero","owner":{"login":"evantahler","id":303226,"avatar_url":"https://avatars.githubusercontent.com/u/303226?","gravatar_id":"173e23850a81c3f494ae957e1417c02d","url":"https://api.github.com/users/evantahler","html_url":"https://github.com/evantahler","followers_url":"https://api.github.com/users/evantahler/followers","following_url":"https://api.github.com/users/evantahler/following{/other_user}","gists_url":"https://api.github.com/users/evantahler/gists{/gist_id}","starred_url":"https://api.github.com/users/evantahler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evantahler/subscriptions","organizations_url":"https://api.github.com/users/evantahler/orgs","repos_url":"https://api.github.com/users/evantahler/repos","events_url":"https://api.github.com/users/evantahler/events{/privacy}","received_events_url":"https://api.github.com/users/evantahler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evantahler/actionhero","description":"actionhero.js is a multi-transport API Server with integrated cluster capabilites and delayed tasks","fork":false,"url":"https://api.github.com/repos/evantahler/actionhero","forks_url":"https://api.github.com/repos/evantahler/actionhero/forks","keys_url":"https://api.github.com/repos/evantahler/actionhero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evantahler/actionhero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evantahler/actionhero/teams","hooks_url":"https://api.github.com/repos/evantahler/actionhero/hooks","issue_events_url":"https://api.github.com/repos/evantahler/actionhero/issues/events{/number}","events_url":"https://api.github.com/repos/evantahler/actionhero/events","assignees_url":"https://api.github.com/repos/evantahler/actionhero/assignees{/user}","branches_url":"https://api.github.com/repos/evantahler/actionhero/branches{/branch}","tags_url":"https://api.github.com/repos/evantahler/actionhero/tags","blobs_url":"https://api.github.com/repos/evantahler/actionhero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evantahler/actionhero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evantahler/actionhero/git/refs{/sha}","trees_url":"https://api.github.com/repos/evantahler/actionhero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evantahler/actionhero/statuses/{sha}","languages_url":"https://api.github.com/repos/evantahler/actionhero/languages","stargazers_url":"https://api.github.com/repos/evantahler/actionhero/stargazers","contributors_url":"https://api.github.com/repos/evantahler/actionhero/contributors","subscribers_url":"https://api.github.com/repos/evantahler/actionhero/subscribers","subscription_url":"https://api.github.com/repos/evantahler/actionhero/subscription","commits_url":"https://api.github.com/repos/evantahler/actionhero/commits{/sha}","git_commits_url":"https://api.github.com/repos/evantahler/actionhero/git/commits{/sha}","comments_url":"https://api.github.com/repos/evantahler/actionhero/comments{/number}","issue_comment_url":"https://api.github.com/repos/evantahler/actionhero/issues/comments/{number}","contents_url":"https://api.github.com/repos/evantahler/actionhero/contents/{+path}","compare_url":"https://api.github.com/repos/evantahler/actionhero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evantahler/actionhero/merges","archive_url":"https://api.github.com/repos/evantahler/actionhero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evantahler/actionhero/downloads","issues_url":"https://api.github.com/repos/evantahler/actionhero/issues{/number}","pulls_url":"https://api.github.com/repos/evantahler/actionhero/pulls{/number}","milestones_url":"https://api.github.com/repos/evantahler/actionhero/milestones{/number}","notifications_url":"https://api.github.com/repos/evantahler/actionhero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evantahler/actionhero/labels{/name}","releases_url":"https://api.github.com/repos/evantahler/actionhero/releases{/id}","created_at":"2011-09-30T20:20:43Z","updated_at":"2014-06-25T12:56:29Z","pushed_at":"2014-06-25T05:48:53Z","git_url":"git://github.com/evantahler/actionhero.git","ssh_url":"git@github.com:evantahler/actionhero.git","clone_url":"https://github.com/evantahler/actionhero.git","svn_url":"https://github.com/evantahler/actionhero","homepage":"www.actionherojs.com","size":25641,"stargazers_count":597,"watchers_count":597,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":86,"mirror_url":null,"open_issues_count":4,"forks":86,"open_issues":4,"watchers":597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/evantahler/actionhero/pulls/410"},"html":{"href":"https://github.com/evantahler/actionhero/pull/410"},"issue":{"href":"https://api.github.com/repos/evantahler/actionhero/issues/410"},"comments":{"href":"https://api.github.com/repos/evantahler/actionhero/issues/410/comments"},"review_comments":{"href":"https://api.github.com/repos/evantahler/actionhero/pulls/410/comments"},"review_comment":{"href":"https://api.github.com/repos/evantahler/actionhero/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/evantahler/actionhero/pulls/410/commits"},"statuses":{"href":"https://api.github.com/repos/evantahler/actionhero/statuses/dd507c9e0edbd5d336753e20e27f0e2fbf71bd1d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":28,"deletions":9,"changed_files":1}}