GitHub PullRequestReviewCommentEvent at 2014-08-15 11:52:55
Repository: moose
Actor: friedmud
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/16289225","id":16289225,"diff_hunk":"@@ -0,0 +1,62 @@\n+#ifndef TERMINATOR_H\n+#define TERMINATOR_H\n+\n+#include \"GeneralUserObject.h\"\n+#include \"libmesh/fparser.hh\"\n+\n+//Forward Declarations\n+class Terminator;\n+\n+template<>\n+InputParameters validParams<Terminator>();","path":"modules/phase_field/include/userobjects/Terminator.h","position":11,"original_position":11,"commit_id":"d0e9d9ab1ad613455746eaeb9df899be0b21b6d5","original_commit_id":"d0e9d9ab1ad613455746eaeb9df899be0b21b6d5","user":{"login":"friedmud","id":870705,"avatar_url":"https://avatars.githubusercontent.com/u/870705?v=2","gravatar_id":"d27c9dff3bef01416eea632acc4b03f8","url":"https://api.github.com/users/friedmud","html_url":"https://github.com/friedmud","followers_url":"https://api.github.com/users/friedmud/followers","following_url":"https://api.github.com/users/friedmud/following{/other_user}","gists_url":"https://api.github.com/users/friedmud/gists{/gist_id}","starred_url":"https://api.github.com/users/friedmud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedmud/subscriptions","organizations_url":"https://api.github.com/users/friedmud/orgs","repos_url":"https://api.github.com/users/friedmud/repos","events_url":"https://api.github.com/users/friedmud/events{/privacy}","received_events_url":"https://api.github.com/users/friedmud/received_events","type":"User","site_admin":false},"body":"The joke is good - but I wonder if the name is too vague for going into the PhaseField module","created_at":"2014-08-15T11:52:55Z","updated_at":"2014-08-15T11:52:55Z","html_url":"https://github.com/idaholab/moose/pull/3739#discussion_r16289225","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/3739","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/16289225"},"html":{"href":"https://github.com/idaholab/moose/pull/3739#discussion_r16289225"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/3739"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/3739","id":19820593,"html_url":"https://github.com/idaholab/moose/pull/3739","diff_url":"https://github.com/idaholab/moose/pull/3739.diff","patch_url":"https://github.com/idaholab/moose/pull/3739.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/3739","number":3739,"state":"open","locked":false,"title":"Terminate solves cleanly based on Postprocessor values","user":{"login":"dschwen","id":202302,"avatar_url":"https://avatars.githubusercontent.com/u/202302?v=2","gravatar_id":"2fcfb828da9e132919a2bbbd4b3b6260","url":"https://api.github.com/users/dschwen","html_url":"https://github.com/dschwen","followers_url":"https://api.github.com/users/dschwen/followers","following_url":"https://api.github.com/users/dschwen/following{/other_user}","gists_url":"https://api.github.com/users/dschwen/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwen/subscriptions","organizations_url":"https://api.github.com/users/dschwen/orgs","repos_url":"https://api.github.com/users/dschwen/repos","events_url":"https://api.github.com/users/dschwen/events{/privacy}","received_events_url":"https://api.github.com/users/dschwen/received_events","type":"User","site_admin":false},"body":"This implements the change proposed in #3735. The ```UserObject``` to trigger the termination based on ```Postprocessor``` values is part of the phase_field module. ","created_at":"2014-08-14T22:52:01Z","updated_at":"2014-08-15T11:52:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"818f9f8ccd11d79780fc010e19c584a4698f942d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/3739/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/3739/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments/{number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/3739/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/d0e9d9ab1ad613455746eaeb9df899be0b21b6d5","head":{"label":"dschwen:terminate_3735","ref":"terminate_3735","sha":"d0e9d9ab1ad613455746eaeb9df899be0b21b6d5","user":{"login":"dschwen","id":202302,"avatar_url":"https://avatars.githubusercontent.com/u/202302?v=2","gravatar_id":"2fcfb828da9e132919a2bbbd4b3b6260","url":"https://api.github.com/users/dschwen","html_url":"https://github.com/dschwen","followers_url":"https://api.github.com/users/dschwen/followers","following_url":"https://api.github.com/users/dschwen/following{/other_user}","gists_url":"https://api.github.com/users/dschwen/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwen/subscriptions","organizations_url":"https://api.github.com/users/dschwen/orgs","repos_url":"https://api.github.com/users/dschwen/repos","events_url":"https://api.github.com/users/dschwen/events{/privacy}","received_events_url":"https://api.github.com/users/dschwen/received_events","type":"User","site_admin":false},"repo":{"id":17870930,"name":"moose","full_name":"dschwen/moose","owner":{"login":"dschwen","id":202302,"avatar_url":"https://avatars.githubusercontent.com/u/202302?v=2","gravatar_id":"2fcfb828da9e132919a2bbbd4b3b6260","url":"https://api.github.com/users/dschwen","html_url":"https://github.com/dschwen","followers_url":"https://api.github.com/users/dschwen/followers","following_url":"https://api.github.com/users/dschwen/following{/other_user}","gists_url":"https://api.github.com/users/dschwen/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwen/subscriptions","organizations_url":"https://api.github.com/users/dschwen/orgs","repos_url":"https://api.github.com/users/dschwen/repos","events_url":"https://api.github.com/users/dschwen/events{/privacy}","received_events_url":"https://api.github.com/users/dschwen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dschwen/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/dschwen/moose","forks_url":"https://api.github.com/repos/dschwen/moose/forks","keys_url":"https://api.github.com/repos/dschwen/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dschwen/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dschwen/moose/teams","hooks_url":"https://api.github.com/repos/dschwen/moose/hooks","issue_events_url":"https://api.github.com/repos/dschwen/moose/issues/events{/number}","events_url":"https://api.github.com/repos/dschwen/moose/events","assignees_url":"https://api.github.com/repos/dschwen/moose/assignees{/user}","branches_url":"https://api.github.com/repos/dschwen/moose/branches{/branch}","tags_url":"https://api.github.com/repos/dschwen/moose/tags","blobs_url":"https://api.github.com/repos/dschwen/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dschwen/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dschwen/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/dschwen/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dschwen/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/dschwen/moose/languages","stargazers_url":"https://api.github.com/repos/dschwen/moose/stargazers","contributors_url":"https://api.github.com/repos/dschwen/moose/contributors","subscribers_url":"https://api.github.com/repos/dschwen/moose/subscribers","subscription_url":"https://api.github.com/repos/dschwen/moose/subscription","commits_url":"https://api.github.com/repos/dschwen/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/dschwen/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/dschwen/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/dschwen/moose/issues/comments/{number}","contents_url":"https://api.github.com/repos/dschwen/moose/contents/{+path}","compare_url":"https://api.github.com/repos/dschwen/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dschwen/moose/merges","archive_url":"https://api.github.com/repos/dschwen/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dschwen/moose/downloads","issues_url":"https://api.github.com/repos/dschwen/moose/issues{/number}","pulls_url":"https://api.github.com/repos/dschwen/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/dschwen/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/dschwen/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dschwen/moose/labels{/name}","releases_url":"https://api.github.com/repos/dschwen/moose/releases{/id}","created_at":"2014-03-18T15:25:39Z","updated_at":"2014-06-26T22:17:27Z","pushed_at":"2014-08-15T05:27:26Z","git_url":"git://github.com/dschwen/moose.git","ssh_url":"git@github.com:dschwen/moose.git","clone_url":"https://github.com/dschwen/moose.git","svn_url":"https://github.com/dschwen/moose","homepage":null,"size":72502,"stargazers_count":0,"watchers_count":0,"language":"Eiffel","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"f97105a605a158e0411e312513fcee8f929bd091","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=2","gravatar_id":"6100659079626499e46326c5df9810cd","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=2","gravatar_id":"6100659079626499e46326c5df9810cd","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments/{number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","created_at":"2014-02-14T22:26:15Z","updated_at":"2014-08-05T13:36:48Z","pushed_at":"2014-08-14T21:02:44Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":null,"size":92573,"stargazers_count":44,"watchers_count":44,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":74,"mirror_url":null,"open_issues_count":363,"forks":74,"open_issues":363,"watchers":44,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/3739"},"html":{"href":"https://github.com/idaholab/moose/pull/3739"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/3739"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/3739/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/3739/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/3739/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/d0e9d9ab1ad613455746eaeb9df899be0b21b6d5"}}}}