GitHub PullRequestEvent at 2014-09-17 13:21:32
Repository: bluebottle
Actor: aethemba
Payload: {"action":"opened","number":983,"pull_request":{"url":"https://api.github.com/repos/onepercentclub/bluebottle/pulls/983","id":21365420,"html_url":"https://github.com/onepercentclub/bluebottle/pull/983","diff_url":"https://github.com/onepercentclub/bluebottle/pull/983.diff","patch_url":"https://github.com/onepercentclub/bluebottle/pull/983.patch","issue_url":"https://api.github.com/repos/onepercentclub/bluebottle/issues/983","number":983,"state":"open","locked":false,"title":"Feature/copy tickets","user":{"login":"aethemba","id":859730,"avatar_url":"https://avatars.githubusercontent.com/u/859730?v=2","gravatar_id":"d96514056a8c5fa7749c0ee56c7ee4f5","url":"https://api.github.com/users/aethemba","html_url":"https://github.com/aethemba","followers_url":"https://api.github.com/users/aethemba/followers","following_url":"https://api.github.com/users/aethemba/following{/other_user}","gists_url":"https://api.github.com/users/aethemba/gists{/gist_id}","starred_url":"https://api.github.com/users/aethemba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aethemba/subscriptions","organizations_url":"https://api.github.com/users/aethemba/orgs","repos_url":"https://api.github.com/users/aethemba/repos","events_url":"https://api.github.com/users/aethemba/events{/privacy}","received_events_url":"https://api.github.com/users/aethemba/received_events","type":"User","site_admin":false},"body":"This PR updates the way we save the time_available property on the base user model. In addition, there are some other translation fixes. \r\n\r\nThe time_available property was unnecessarily complex with its own model. However, we needed that property translated and that was not possible with our current api. Instead, a key is now saved via a CharField and Javascript translates the key.\r\n\r\nIn doing so, I changed the property from time_available to available_time to prevent issues with migrations (same name issues). \r\n\r\nThere is a corresponding PR in the 1% repository with 2 schemamigrations and a data migration. At some point we'll need to apply similar migrations for Booking.","created_at":"2014-09-17T13:21:32Z","updated_at":"2014-09-17T13:21:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onepercentclub/bluebottle/pulls/983/commits","review_comments_url":"https://api.github.com/repos/onepercentclub/bluebottle/pulls/983/comments","review_comment_url":"https://api.github.com/repos/onepercentclub/bluebottle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/onepercentclub/bluebottle/issues/983/comments","statuses_url":"https://api.github.com/repos/onepercentclub/bluebottle/statuses/8ce5f59ef3de6182e74995ed45d65b9dcebcee30","head":{"label":"onepercentclub:feature/copy-tickets","ref":"feature/copy-tickets","sha":"8ce5f59ef3de6182e74995ed45d65b9dcebcee30","user":{"login":"onepercentclub","id":1748818,"avatar_url":"https://avatars.githubusercontent.com/u/1748818?v=2","gravatar_id":"c4e57022fa0285fb70d96c3ab2634d64","url":"https://api.github.com/users/onepercentclub","html_url":"https://github.com/onepercentclub","followers_url":"https://api.github.com/users/onepercentclub/followers","following_url":"https://api.github.com/users/onepercentclub/following{/other_user}","gists_url":"https://api.github.com/users/onepercentclub/gists{/gist_id}","starred_url":"https://api.github.com/users/onepercentclub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onepercentclub/subscriptions","organizations_url":"https://api.github.com/users/onepercentclub/orgs","repos_url":"https://api.github.com/users/onepercentclub/repos","events_url":"https://api.github.com/users/onepercentclub/events{/privacy}","received_events_url":"https://api.github.com/users/onepercentclub/received_events","type":"Organization","site_admin":false},"repo":{"id":13149527,"name":"bluebottle","full_name":"onepercentclub/bluebottle","owner":{"login":"onepercentclub","id":1748818,"avatar_url":"https://avatars.githubusercontent.com/u/1748818?v=2","gravatar_id":"c4e57022fa0285fb70d96c3ab2634d64","url":"https://api.github.com/users/onepercentclub","html_url":"https://github.com/onepercentclub","followers_url":"https://api.github.com/users/onepercentclub/followers","following_url":"https://api.github.com/users/onepercentclub/following{/other_user}","gists_url":"https://api.github.com/users/onepercentclub/gists{/gist_id}","starred_url":"https://api.github.com/users/onepercentclub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onepercentclub/subscriptions","organizations_url":"https://api.github.com/users/onepercentclub/orgs","repos_url":"https://api.github.com/users/onepercentclub/repos","events_url":"https://api.github.com/users/onepercentclub/events{/privacy}","received_events_url":"https://api.github.com/users/onepercentclub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onepercentclub/bluebottle","description":"Bluebottle","fork":false,"url":"https://api.github.com/repos/onepercentclub/bluebottle","forks_url":"https://api.github.com/repos/onepercentclub/bluebottle/forks","keys_url":"https://api.github.com/repos/onepercentclub/bluebottle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onepercentclub/bluebottle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onepercentclub/bluebottle/teams","hooks_url":"https://api.github.com/repos/onepercentclub/bluebottle/hooks","issue_events_url":"https://api.github.com/repos/onepercentclub/bluebottle/issues/events{/number}","events_url":"https://api.github.com/repos/onepercentclub/bluebottle/events","assignees_url":"https://api.github.com/repos/onepercentclub/bluebottle/assignees{/user}","branches_url":"https://api.github.com/repos/onepercentclub/bluebottle/branches{/branch}","tags_url":"https://api.github.com/repos/onepercentclub/bluebottle/tags","blobs_url":"https://api.github.com/repos/onepercentclub/bluebottle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onepercentclub/bluebottle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onepercentclub/bluebottle/git/refs{/sha}","trees_url":"https://api.github.com/repos/onepercentclub/bluebottle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onepercentclub/bluebottle/statuses/{sha}","languages_url":"https://api.github.com/repos/onepercentclub/bluebottle/languages","stargazers_url":"https://api.github.com/repos/onepercentclub/bluebottle/stargazers","contributors_url":"https://api.github.com/repos/onepercentclub/bluebottle/contributors","subscribers_url":"https://api.github.com/repos/onepercentclub/bluebottle/subscribers","subscription_url":"https://api.github.com/repos/onepercentclub/bluebottle/subscription","commits_url":"https://api.github.com/repos/onepercentclub/bluebottle/commits{/sha}","git_commits_url":"https://api.github.com/repos/onepercentclub/bluebottle/git/commits{/sha}","comments_url":"https://api.github.com/repos/onepercentclub/bluebottle/comments{/number}","issue_comment_url":"https://api.github.com/repos/onepercentclub/bluebottle/issues/comments/{number}","contents_url":"https://api.github.com/repos/onepercentclub/bluebottle/contents/{+path}","compare_url":"https://api.github.com/repos/onepercentclub/bluebottle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onepercentclub/bluebottle/merges","archive_url":"https://api.github.com/repos/onepercentclub/bluebottle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onepercentclub/bluebottle/downloads","issues_url":"https://api.github.com/repos/onepercentclub/bluebottle/issues{/number}","pulls_url":"https://api.github.com/repos/onepercentclub/bluebottle/pulls{/number}","milestones_url":"https://api.github.com/repos/onepercentclub/bluebottle/milestones{/number}","notifications_url":"https://api.github.com/repos/onepercentclub/bluebottle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onepercentclub/bluebottle/labels{/name}","releases_url":"https://api.github.com/repos/onepercentclub/bluebottle/releases{/id}","created_at":"2013-09-27T12:09:13Z","updated_at":"2014-09-10T12:45:41Z","pushed_at":"2014-09-17T13:18:38Z","git_url":"git://github.com/onepercentclub/bluebottle.git","ssh_url":"git@github.com:onepercentclub/bluebottle.git","clone_url":"https://github.com/onepercentclub/bluebottle.git","svn_url":"https://github.com/onepercentclub/bluebottle","homepage":null,"size":44710,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"onepercentclub:master","ref":"master","sha":"b5cd611e5b04fe2afd1c5b561a5f4b4e683cc4b0","user":{"login":"onepercentclub","id":1748818,"avatar_url":"https://avatars.githubusercontent.com/u/1748818?v=2","gravatar_id":"c4e57022fa0285fb70d96c3ab2634d64","url":"https://api.github.com/users/onepercentclub","html_url":"https://github.com/onepercentclub","followers_url":"https://api.github.com/users/onepercentclub/followers","following_url":"https://api.github.com/users/onepercentclub/following{/other_user}","gists_url":"https://api.github.com/users/onepercentclub/gists{/gist_id}","starred_url":"https://api.github.com/users/onepercentclub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onepercentclub/subscriptions","organizations_url":"https://api.github.com/users/onepercentclub/orgs","repos_url":"https://api.github.com/users/onepercentclub/repos","events_url":"https://api.github.com/users/onepercentclub/events{/privacy}","received_events_url":"https://api.github.com/users/onepercentclub/received_events","type":"Organization","site_admin":false},"repo":{"id":13149527,"name":"bluebottle","full_name":"onepercentclub/bluebottle","owner":{"login":"onepercentclub","id":1748818,"avatar_url":"https://avatars.githubusercontent.com/u/1748818?v=2","gravatar_id":"c4e57022fa0285fb70d96c3ab2634d64","url":"https://api.github.com/users/onepercentclub","html_url":"https://github.com/onepercentclub","followers_url":"https://api.github.com/users/onepercentclub/followers","following_url":"https://api.github.com/users/onepercentclub/following{/other_user}","gists_url":"https://api.github.com/users/onepercentclub/gists{/gist_id}","starred_url":"https://api.github.com/users/onepercentclub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onepercentclub/subscriptions","organizations_url":"https://api.github.com/users/onepercentclub/orgs","repos_url":"https://api.github.com/users/onepercentclub/repos","events_url":"https://api.github.com/users/onepercentclub/events{/privacy}","received_events_url":"https://api.github.com/users/onepercentclub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onepercentclub/bluebottle","description":"Bluebottle","fork":false,"url":"https://api.github.com/repos/onepercentclub/bluebottle","forks_url":"https://api.github.com/repos/onepercentclub/bluebottle/forks","keys_url":"https://api.github.com/repos/onepercentclub/bluebottle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onepercentclub/bluebottle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onepercentclub/bluebottle/teams","hooks_url":"https://api.github.com/repos/onepercentclub/bluebottle/hooks","issue_events_url":"https://api.github.com/repos/onepercentclub/bluebottle/issues/events{/number}","events_url":"https://api.github.com/repos/onepercentclub/bluebottle/events","assignees_url":"https://api.github.com/repos/onepercentclub/bluebottle/assignees{/user}","branches_url":"https://api.github.com/repos/onepercentclub/bluebottle/branches{/branch}","tags_url":"https://api.github.com/repos/onepercentclub/bluebottle/tags","blobs_url":"https://api.github.com/repos/onepercentclub/bluebottle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onepercentclub/bluebottle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onepercentclub/bluebottle/git/refs{/sha}","trees_url":"https://api.github.com/repos/onepercentclub/bluebottle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onepercentclub/bluebottle/statuses/{sha}","languages_url":"https://api.github.com/repos/onepercentclub/bluebottle/languages","stargazers_url":"https://api.github.com/repos/onepercentclub/bluebottle/stargazers","contributors_url":"https://api.github.com/repos/onepercentclub/bluebottle/contributors","subscribers_url":"https://api.github.com/repos/onepercentclub/bluebottle/subscribers","subscription_url":"https://api.github.com/repos/onepercentclub/bluebottle/subscription","commits_url":"https://api.github.com/repos/onepercentclub/bluebottle/commits{/sha}","git_commits_url":"https://api.github.com/repos/onepercentclub/bluebottle/git/commits{/sha}","comments_url":"https://api.github.com/repos/onepercentclub/bluebottle/comments{/number}","issue_comment_url":"https://api.github.com/repos/onepercentclub/bluebottle/issues/comments/{number}","contents_url":"https://api.github.com/repos/onepercentclub/bluebottle/contents/{+path}","compare_url":"https://api.github.com/repos/onepercentclub/bluebottle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onepercentclub/bluebottle/merges","archive_url":"https://api.github.com/repos/onepercentclub/bluebottle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onepercentclub/bluebottle/downloads","issues_url":"https://api.github.com/repos/onepercentclub/bluebottle/issues{/number}","pulls_url":"https://api.github.com/repos/onepercentclub/bluebottle/pulls{/number}","milestones_url":"https://api.github.com/repos/onepercentclub/bluebottle/milestones{/number}","notifications_url":"https://api.github.com/repos/onepercentclub/bluebottle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onepercentclub/bluebottle/labels{/name}","releases_url":"https://api.github.com/repos/onepercentclub/bluebottle/releases{/id}","created_at":"2013-09-27T12:09:13Z","updated_at":"2014-09-10T12:45:41Z","pushed_at":"2014-09-17T13:18:38Z","git_url":"git://github.com/onepercentclub/bluebottle.git","ssh_url":"git@github.com:onepercentclub/bluebottle.git","clone_url":"https://github.com/onepercentclub/bluebottle.git","svn_url":"https://github.com/onepercentclub/bluebottle","homepage":null,"size":44710,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onepercentclub/bluebottle/pulls/983"},"html":{"href":"https://github.com/onepercentclub/bluebottle/pull/983"},"issue":{"href":"https://api.github.com/repos/onepercentclub/bluebottle/issues/983"},"comments":{"href":"https://api.github.com/repos/onepercentclub/bluebottle/issues/983/comments"},"review_comments":{"href":"https://api.github.com/repos/onepercentclub/bluebottle/pulls/983/comments"},"review_comment":{"href":"https://api.github.com/repos/onepercentclub/bluebottle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/onepercentclub/bluebottle/pulls/983/commits"},"statuses":{"href":"https://api.github.com/repos/onepercentclub/bluebottle/statuses/8ce5f59ef3de6182e74995ed45d65b9dcebcee30"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":11,"additions":29,"deletions":35,"changed_files":6}}