GitHub PullRequestReviewCommentEvent at 2014-10-10 16:22:52
Repository: quark
Actor: asadoughi
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/quark/pulls/comments/18715438","id":18715438,"diff_hunk":"@@ -32,7 +33,19 @@\n                help=_(\"The server to write security group rules to\")),\n     cfg.IntOpt('redis_security_groups_port',\n                default=6379,\n-               help=_(\"The port for the redis server\"))]\n+               help=_(\"The port for the redis server\")),\n+    cfg.BoolOpt(\"redis_use_sentinels\",\n+                default=False,\n+                help=_(\"Tell the redis client to use sentinels rather than a \"\n+                       \"direction connection\")),\n+    cfg.StrOpt(\"redis_sentinel_servers\",\n+               default='',\n+               help=_(\"A JSON serialized list of (host, port) tuples to use \"\n+                      \"as redis sentinels. Note that the JSON version be list \"\n+                      \"pairs, which is acceptable \")),\n+    cfg.StrOpt(\"redis_master_label\",\n+               default='',\n+               help=_(\"The name label of the master redis sentinel\"))]","path":"quark/security_groups/redis_client.py","position":25,"original_position":25,"commit_id":"12ab4b3b8ff0a5fc0e560d3cb6b15650d426f564","original_commit_id":"12ab4b3b8ff0a5fc0e560d3cb6b15650d426f564","user":{"login":"asadoughi","id":775631,"avatar_url":"https://avatars.githubusercontent.com/u/775631?v=2","gravatar_id":"","url":"https://api.github.com/users/asadoughi","html_url":"https://github.com/asadoughi","followers_url":"https://api.github.com/users/asadoughi/followers","following_url":"https://api.github.com/users/asadoughi/following{/other_user}","gists_url":"https://api.github.com/users/asadoughi/gists{/gist_id}","starred_url":"https://api.github.com/users/asadoughi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asadoughi/subscriptions","organizations_url":"https://api.github.com/users/asadoughi/orgs","repos_url":"https://api.github.com/users/asadoughi/repos","events_url":"https://api.github.com/users/asadoughi/events{/privacy}","received_events_url":"https://api.github.com/users/asadoughi/received_events","type":"User","site_admin":false},"body":"In quark/agent/redis_client.py I have this as, \r\n```\r\n    cfg.ListOpt(\"redis_sentinel_hosts\",\r\n                default=[\"localhost:26379\"],\r\n                help=_(\"Comma-separated list of host:port pairs for Redis \"\r\n                       \"sentinel hosts.\")),\r\n    cfg.StrOpt(\"redis_sentinel_master\",\r\n               default=\"mymaster\",\r\n               help=_(\"Service name for Redis master.\")),\r\n```\r\nWould be nice to have this consistent to keep config easy. IMHO, comma separated host:port is friendlier than JSON blob. ","created_at":"2014-10-10T16:22:52Z","updated_at":"2014-10-10T16:22:52Z","html_url":"https://github.com/rackerlabs/quark/pull/241#discussion_r18715438","pull_request_url":"https://api.github.com/repos/rackerlabs/quark/pulls/241","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/quark/pulls/comments/18715438"},"html":{"href":"https://github.com/rackerlabs/quark/pull/241#discussion_r18715438"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/quark/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/quark/pulls/241","id":22571280,"html_url":"https://github.com/rackerlabs/quark/pull/241","diff_url":"https://github.com/rackerlabs/quark/pull/241.diff","patch_url":"https://github.com/rackerlabs/quark/pull/241.patch","issue_url":"https://api.github.com/repos/rackerlabs/quark/issues/241","number":241,"state":"open","locked":false,"title":"RM9837","user":{"login":"Cerberus98","id":86828,"avatar_url":"https://avatars.githubusercontent.com/u/86828?v=2","gravatar_id":"","url":"https://api.github.com/users/Cerberus98","html_url":"https://github.com/Cerberus98","followers_url":"https://api.github.com/users/Cerberus98/followers","following_url":"https://api.github.com/users/Cerberus98/following{/other_user}","gists_url":"https://api.github.com/users/Cerberus98/gists{/gist_id}","starred_url":"https://api.github.com/users/Cerberus98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cerberus98/subscriptions","organizations_url":"https://api.github.com/users/Cerberus98/orgs","repos_url":"https://api.github.com/users/Cerberus98/repos","events_url":"https://api.github.com/users/Cerberus98/events{/privacy}","received_events_url":"https://api.github.com/users/Cerberus98/received_events","type":"User","site_admin":false},"body":"Adds support for Redis sentinels","created_at":"2014-10-10T16:15:12Z","updated_at":"2014-10-10T16:22:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04117698c642f9172aad71a13806f40f4cda9455","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/quark/pulls/241/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/quark/pulls/241/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/quark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rackerlabs/quark/issues/241/comments","statuses_url":"https://api.github.com/repos/rackerlabs/quark/statuses/12ab4b3b8ff0a5fc0e560d3cb6b15650d426f564","head":{"label":"Cerberus98:rm9837_work","ref":"rm9837_work","sha":"12ab4b3b8ff0a5fc0e560d3cb6b15650d426f564","user":{"login":"Cerberus98","id":86828,"avatar_url":"https://avatars.githubusercontent.com/u/86828?v=2","gravatar_id":"","url":"https://api.github.com/users/Cerberus98","html_url":"https://github.com/Cerberus98","followers_url":"https://api.github.com/users/Cerberus98/followers","following_url":"https://api.github.com/users/Cerberus98/following{/other_user}","gists_url":"https://api.github.com/users/Cerberus98/gists{/gist_id}","starred_url":"https://api.github.com/users/Cerberus98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cerberus98/subscriptions","organizations_url":"https://api.github.com/users/Cerberus98/orgs","repos_url":"https://api.github.com/users/Cerberus98/repos","events_url":"https://api.github.com/users/Cerberus98/events{/privacy}","received_events_url":"https://api.github.com/users/Cerberus98/received_events","type":"User","site_admin":false},"repo":{"id":13509887,"name":"quark","full_name":"Cerberus98/quark","owner":{"login":"Cerberus98","id":86828,"avatar_url":"https://avatars.githubusercontent.com/u/86828?v=2","gravatar_id":"","url":"https://api.github.com/users/Cerberus98","html_url":"https://github.com/Cerberus98","followers_url":"https://api.github.com/users/Cerberus98/followers","following_url":"https://api.github.com/users/Cerberus98/following{/other_user}","gists_url":"https://api.github.com/users/Cerberus98/gists{/gist_id}","starred_url":"https://api.github.com/users/Cerberus98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cerberus98/subscriptions","organizations_url":"https://api.github.com/users/Cerberus98/orgs","repos_url":"https://api.github.com/users/Cerberus98/repos","events_url":"https://api.github.com/users/Cerberus98/events{/privacy}","received_events_url":"https://api.github.com/users/Cerberus98/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Cerberus98/quark","description":"","fork":true,"url":"https://api.github.com/repos/Cerberus98/quark","forks_url":"https://api.github.com/repos/Cerberus98/quark/forks","keys_url":"https://api.github.com/repos/Cerberus98/quark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cerberus98/quark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cerberus98/quark/teams","hooks_url":"https://api.github.com/repos/Cerberus98/quark/hooks","issue_events_url":"https://api.github.com/repos/Cerberus98/quark/issues/events{/number}","events_url":"https://api.github.com/repos/Cerberus98/quark/events","assignees_url":"https://api.github.com/repos/Cerberus98/quark/assignees{/user}","branches_url":"https://api.github.com/repos/Cerberus98/quark/branches{/branch}","tags_url":"https://api.github.com/repos/Cerberus98/quark/tags","blobs_url":"https://api.github.com/repos/Cerberus98/quark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cerberus98/quark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cerberus98/quark/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cerberus98/quark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cerberus98/quark/statuses/{sha}","languages_url":"https://api.github.com/repos/Cerberus98/quark/languages","stargazers_url":"https://api.github.com/repos/Cerberus98/quark/stargazers","contributors_url":"https://api.github.com/repos/Cerberus98/quark/contributors","subscribers_url":"https://api.github.com/repos/Cerberus98/quark/subscribers","subscription_url":"https://api.github.com/repos/Cerberus98/quark/subscription","commits_url":"https://api.github.com/repos/Cerberus98/quark/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cerberus98/quark/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cerberus98/quark/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cerberus98/quark/issues/comments/{number}","contents_url":"https://api.github.com/repos/Cerberus98/quark/contents/{+path}","compare_url":"https://api.github.com/repos/Cerberus98/quark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cerberus98/quark/merges","archive_url":"https://api.github.com/repos/Cerberus98/quark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cerberus98/quark/downloads","issues_url":"https://api.github.com/repos/Cerberus98/quark/issues{/number}","pulls_url":"https://api.github.com/repos/Cerberus98/quark/pulls{/number}","milestones_url":"https://api.github.com/repos/Cerberus98/quark/milestones{/number}","notifications_url":"https://api.github.com/repos/Cerberus98/quark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cerberus98/quark/labels{/name}","releases_url":"https://api.github.com/repos/Cerberus98/quark/releases{/id}","created_at":"2013-10-11T21:16:05Z","updated_at":"2014-07-25T20:20:31Z","pushed_at":"2014-10-10T16:14:25Z","git_url":"git://github.com/Cerberus98/quark.git","ssh_url":"git@github.com:Cerberus98/quark.git","clone_url":"https://github.com/Cerberus98/quark.git","svn_url":"https://github.com/Cerberus98/quark","homepage":null,"size":3302,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"2f39a844212a2ebde1247149625c4c69f9f6c737","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=2","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":13504140,"name":"quark","full_name":"rackerlabs/quark","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=2","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/quark","description":"","fork":false,"url":"https://api.github.com/repos/rackerlabs/quark","forks_url":"https://api.github.com/repos/rackerlabs/quark/forks","keys_url":"https://api.github.com/repos/rackerlabs/quark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/quark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/quark/teams","hooks_url":"https://api.github.com/repos/rackerlabs/quark/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/quark/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/quark/events","assignees_url":"https://api.github.com/repos/rackerlabs/quark/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/quark/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/quark/tags","blobs_url":"https://api.github.com/repos/rackerlabs/quark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/quark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/quark/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/quark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/quark/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/quark/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/quark/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/quark/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/quark/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/quark/subscription","commits_url":"https://api.github.com/repos/rackerlabs/quark/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/quark/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/quark/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/quark/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackerlabs/quark/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/quark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/quark/merges","archive_url":"https://api.github.com/repos/rackerlabs/quark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/quark/downloads","issues_url":"https://api.github.com/repos/rackerlabs/quark/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/quark/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/quark/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/quark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/quark/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/quark/releases{/id}","created_at":"2013-10-11T16:45:26Z","updated_at":"2014-09-03T21:44:22Z","pushed_at":"2014-10-10T16:11:57Z","git_url":"git://github.com/rackerlabs/quark.git","ssh_url":"git@github.com:rackerlabs/quark.git","clone_url":"https://github.com/rackerlabs/quark.git","svn_url":"https://github.com/rackerlabs/quark","homepage":null,"size":6735,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":14,"forks":13,"open_issues":14,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/quark/pulls/241"},"html":{"href":"https://github.com/rackerlabs/quark/pull/241"},"issue":{"href":"https://api.github.com/repos/rackerlabs/quark/issues/241"},"comments":{"href":"https://api.github.com/repos/rackerlabs/quark/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/quark/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/quark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/quark/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/quark/statuses/12ab4b3b8ff0a5fc0e560d3cb6b15650d426f564"}}}}