GitHub PullRequestReviewCommentEvent at 2014-02-28 22:01:43
Repository: mongo-php-driver
Actor: bjori
Payload: {"comment":{"url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/10183275","id":10183275,"diff_hunk":"@@ -93,11 +93,11 @@ static int php_mongo_command_supports_rp(zval *cmd)\n \t\t\treturn 1;\n \t\t}\n \n-\t\tif (strcmp(str, \"mapreduce\") == 0) {\n+\t\tif (strcmp(str, \"mapreduce\") == 0 || strcmp(str, \"mapReduce\") == 0) {\n \t\t\tzval **value = NULL;\n \t\t\tif (zend_hash_find(Z_ARRVAL_P(cmd), \"out\", 4, (void **)&value) == SUCCESS) {\n-\t\t\t\tif (Z_TYPE_PP(value) == IS_STRING) {\n-\t\t\t\t\tif (strcmp(Z_STRVAL_PP(value), \"inline\") == 0) {\n+\t\t\t\tif (Z_TYPE_PP(value) == IS_ARRAY) {\n+\t\t\t\t\tif (zend_hash_exists(Z_ARRVAL_PP(value), \"inline\", 7)) {","path":"db.c","position":11,"original_position":11,"commit_id":"8b66d0ca815934b2a086d505c1ce077bf2c37927","original_commit_id":"8b66d0ca815934b2a086d505c1ce077bf2c37927","user":{"login":"bjori","id":72407,"avatar_url":"https://avatars.githubusercontent.com/u/72407","gravatar_id":"189511e30874ec6a3b583055f46fef78","url":"https://api.github.com/users/bjori","html_url":"https://github.com/bjori","followers_url":"https://api.github.com/users/bjori/followers","following_url":"https://api.github.com/users/bjori/following{/other_user}","gists_url":"https://api.github.com/users/bjori/gists{/gist_id}","starred_url":"https://api.github.com/users/bjori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjori/subscriptions","organizations_url":"https://api.github.com/users/bjori/orgs","repos_url":"https://api.github.com/users/bjori/repos","events_url":"https://api.github.com/users/bjori/events{/privacy}","received_events_url":"https://api.github.com/users/bjori/received_events","type":"User","site_admin":false},"body":"Hmh. So the value of inline doesn't matter at all? I'd assume you had to atleast see if its positive value?","created_at":"2014-02-28T22:01:43Z","updated_at":"2014-02-28T22:01:43Z","html_url":"https://github.com/mongodb/mongo-php-driver/pull/598#discussion_r10183275","pull_request_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/598","_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/10183275"},"html":{"href":"https://github.com/mongodb/mongo-php-driver/pull/598#discussion_r10183275"},"pull_request":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/598"}}}}