GitHub PullRequestEvent at 2014-12-07 13:40:20
Repository: hyperspy
Actor: magnunor
Payload: {"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/magnunor/hyperspy/pulls/4","id":25546430,"html_url":"https://github.com/magnunor/hyperspy/pull/4","diff_url":"https://github.com/magnunor/hyperspy/pull/4.diff","patch_url":"https://github.com/magnunor/hyperspy/pull/4.patch","issue_url":"https://api.github.com/repos/magnunor/hyperspy/issues/4","number":4,"state":"closed","locked":false,"title":"Merge vidartf:ROIs","user":{"login":"vidartf","id":510760,"avatar_url":"https://avatars.githubusercontent.com/u/510760?v=3","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"body":"I tried to finish up an implementation, both of the GUI bit, and the application. To extend it, I guess the Signal class could have a property called 'slice_combination_function', or something similar, which could then be applied instead of np.mean. The mean function would then be the default one.\r\n\r\nAlso, I noticed Model.multifit will act strange if a size larger than 1x1 is used, should maybe look into how to avoid that (but at least nothing breaks when running it).","created_at":"2014-12-05T02:50:27Z","updated_at":"2014-12-07T13:40:20Z","closed_at":"2014-12-07T13:40:20Z","merged_at":"2014-12-07T13:40:20Z","merge_commit_sha":"a48bf5da1bcfca84e758f7faeb6125c8f0260821","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/magnunor/hyperspy/pulls/4/commits","review_comments_url":"https://api.github.com/repos/magnunor/hyperspy/pulls/4/comments","review_comment_url":"https://api.github.com/repos/magnunor/hyperspy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/magnunor/hyperspy/issues/4/comments","statuses_url":"https://api.github.com/repos/magnunor/hyperspy/statuses/59fc0e5e88b14f0fa38ef7d2414ed0edb4fbcd0f","head":{"label":"vidartf:ROIs","ref":"ROIs","sha":"59fc0e5e88b14f0fa38ef7d2414ed0edb4fbcd0f","user":{"login":"vidartf","id":510760,"avatar_url":"https://avatars.githubusercontent.com/u/510760?v=3","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"repo":{"id":17872313,"name":"hyperspy","full_name":"vidartf/hyperspy","owner":{"login":"vidartf","id":510760,"avatar_url":"https://avatars.githubusercontent.com/u/510760?v=3","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vidartf/hyperspy","description":"Multidimensional data analysis","fork":true,"url":"https://api.github.com/repos/vidartf/hyperspy","forks_url":"https://api.github.com/repos/vidartf/hyperspy/forks","keys_url":"https://api.github.com/repos/vidartf/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vidartf/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vidartf/hyperspy/teams","hooks_url":"https://api.github.com/repos/vidartf/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/vidartf/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/vidartf/hyperspy/events","assignees_url":"https://api.github.com/repos/vidartf/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/vidartf/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/vidartf/hyperspy/tags","blobs_url":"https://api.github.com/repos/vidartf/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vidartf/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vidartf/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/vidartf/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vidartf/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/vidartf/hyperspy/languages","stargazers_url":"https://api.github.com/repos/vidartf/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/vidartf/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/vidartf/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/vidartf/hyperspy/subscription","commits_url":"https://api.github.com/repos/vidartf/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/vidartf/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/vidartf/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/vidartf/hyperspy/issues/comments/{number}","contents_url":"https://api.github.com/repos/vidartf/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/vidartf/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vidartf/hyperspy/merges","archive_url":"https://api.github.com/repos/vidartf/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vidartf/hyperspy/downloads","issues_url":"https://api.github.com/repos/vidartf/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/vidartf/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/vidartf/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/vidartf/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vidartf/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/vidartf/hyperspy/releases{/id}","created_at":"2014-03-18T16:04:56Z","updated_at":"2014-11-24T02:25:51Z","pushed_at":"2014-12-07T13:22:30Z","git_url":"git://github.com/vidartf/hyperspy.git","ssh_url":"git@github.com:vidartf/hyperspy.git","clone_url":"https://github.com/vidartf/hyperspy.git","svn_url":"https://github.com/vidartf/hyperspy","homepage":"http://www.hyperspy.org","size":18662,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"magnunor:NEW_roi_plotting","ref":"NEW_roi_plotting","sha":"2fdc9a08350ebc03ac122723617d496cbd026b62","user":{"login":"magnunor","id":1690979,"avatar_url":"https://avatars.githubusercontent.com/u/1690979?v=3","gravatar_id":"","url":"https://api.github.com/users/magnunor","html_url":"https://github.com/magnunor","followers_url":"https://api.github.com/users/magnunor/followers","following_url":"https://api.github.com/users/magnunor/following{/other_user}","gists_url":"https://api.github.com/users/magnunor/gists{/gist_id}","starred_url":"https://api.github.com/users/magnunor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnunor/subscriptions","organizations_url":"https://api.github.com/users/magnunor/orgs","repos_url":"https://api.github.com/users/magnunor/repos","events_url":"https://api.github.com/users/magnunor/events{/privacy}","received_events_url":"https://api.github.com/users/magnunor/received_events","type":"User","site_admin":false},"repo":{"id":6036258,"name":"hyperspy","full_name":"magnunor/hyperspy","owner":{"login":"magnunor","id":1690979,"avatar_url":"https://avatars.githubusercontent.com/u/1690979?v=3","gravatar_id":"","url":"https://api.github.com/users/magnunor","html_url":"https://github.com/magnunor","followers_url":"https://api.github.com/users/magnunor/followers","following_url":"https://api.github.com/users/magnunor/following{/other_user}","gists_url":"https://api.github.com/users/magnunor/gists{/gist_id}","starred_url":"https://api.github.com/users/magnunor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnunor/subscriptions","organizations_url":"https://api.github.com/users/magnunor/orgs","repos_url":"https://api.github.com/users/magnunor/repos","events_url":"https://api.github.com/users/magnunor/events{/privacy}","received_events_url":"https://api.github.com/users/magnunor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magnunor/hyperspy","description":"A toolbox for hyperspectra data analysis","fork":true,"url":"https://api.github.com/repos/magnunor/hyperspy","forks_url":"https://api.github.com/repos/magnunor/hyperspy/forks","keys_url":"https://api.github.com/repos/magnunor/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magnunor/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magnunor/hyperspy/teams","hooks_url":"https://api.github.com/repos/magnunor/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/magnunor/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/magnunor/hyperspy/events","assignees_url":"https://api.github.com/repos/magnunor/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/magnunor/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/magnunor/hyperspy/tags","blobs_url":"https://api.github.com/repos/magnunor/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magnunor/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magnunor/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/magnunor/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magnunor/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/magnunor/hyperspy/languages","stargazers_url":"https://api.github.com/repos/magnunor/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/magnunor/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/magnunor/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/magnunor/hyperspy/subscription","commits_url":"https://api.github.com/repos/magnunor/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/magnunor/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/magnunor/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/magnunor/hyperspy/issues/comments/{number}","contents_url":"https://api.github.com/repos/magnunor/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/magnunor/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magnunor/hyperspy/merges","archive_url":"https://api.github.com/repos/magnunor/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magnunor/hyperspy/downloads","issues_url":"https://api.github.com/repos/magnunor/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/magnunor/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/magnunor/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/magnunor/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magnunor/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/magnunor/hyperspy/releases{/id}","created_at":"2012-10-01T21:01:13Z","updated_at":"2014-07-03T18:22:24Z","pushed_at":"2014-12-07T13:40:20Z","git_url":"git://github.com/magnunor/hyperspy.git","ssh_url":"git@github.com:magnunor/hyperspy.git","clone_url":"https://github.com/magnunor/hyperspy.git","svn_url":"https://github.com/magnunor/hyperspy","homepage":"http://www.hyperspy.org","size":22488,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magnunor/hyperspy/pulls/4"},"html":{"href":"https://github.com/magnunor/hyperspy/pull/4"},"issue":{"href":"https://api.github.com/repos/magnunor/hyperspy/issues/4"},"comments":{"href":"https://api.github.com/repos/magnunor/hyperspy/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/magnunor/hyperspy/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/magnunor/hyperspy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/magnunor/hyperspy/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/magnunor/hyperspy/statuses/59fc0e5e88b14f0fa38ef7d2414ed0edb4fbcd0f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"magnunor","id":1690979,"avatar_url":"https://avatars.githubusercontent.com/u/1690979?v=3","gravatar_id":"","url":"https://api.github.com/users/magnunor","html_url":"https://github.com/magnunor","followers_url":"https://api.github.com/users/magnunor/followers","following_url":"https://api.github.com/users/magnunor/following{/other_user}","gists_url":"https://api.github.com/users/magnunor/gists{/gist_id}","starred_url":"https://api.github.com/users/magnunor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnunor/subscriptions","organizations_url":"https://api.github.com/users/magnunor/orgs","repos_url":"https://api.github.com/users/magnunor/repos","events_url":"https://api.github.com/users/magnunor/events{/privacy}","received_events_url":"https://api.github.com/users/magnunor/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":5,"additions":268,"deletions":63,"changed_files":4}}