GitHub PullRequestReviewCommentEvent at 2014-08-18 16:59:25
Repository: dealii
Actor: guidokanschat
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/16366358","id":16366358,"diff_hunk":"@@ -875,8 +880,8 @@ namespace FETools\n    * function, use the add_fe_name() function.  This function does not work if\n    * one wants to get a codimension 1 finite element.\n    */\n-  template <int dim>\n-  FiniteElement<dim, dim> *\n+  template <int dim, int spacedim=dim>\n+  FiniteElement<dim, spacedim> *\n   get_fe_from_name (const std::string &name);","path":"include/deal.II/fe/fe_tools.h","position":65,"original_position":65,"commit_id":"8fd30bc7e0370336113f744d2034f8d1cd84b923","original_commit_id":"1e5f58ef9930b04b400233f99892e3abe27705ed","user":{"login":"guidokanschat","id":7237526,"avatar_url":"https://avatars.githubusercontent.com/u/7237526?v=2","gravatar_id":"94372392fb1a391a6530a3f3980acdcd","url":"https://api.github.com/users/guidokanschat","html_url":"https://github.com/guidokanschat","followers_url":"https://api.github.com/users/guidokanschat/followers","following_url":"https://api.github.com/users/guidokanschat/following{/other_user}","gists_url":"https://api.github.com/users/guidokanschat/gists{/gist_id}","starred_url":"https://api.github.com/users/guidokanschat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidokanschat/subscriptions","organizations_url":"https://api.github.com/users/guidokanschat/orgs","repos_url":"https://api.github.com/users/guidokanschat/repos","events_url":"https://api.github.com/users/guidokanschat/events{/privacy}","received_events_url":"https://api.github.com/users/guidokanschat/received_events","type":"User","site_admin":false},"body":"Were partial specializations allowed in C++03? That would be a way out.","created_at":"2014-08-18T16:59:25Z","updated_at":"2014-08-18T16:59:25Z","html_url":"https://github.com/dealii/dealii/pull/88#discussion_r16366358","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/16366358"},"html":{"href":"https://github.com/dealii/dealii/pull/88#discussion_r16366358"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/88","id":19889032,"html_url":"https://github.com/dealii/dealii/pull/88","diff_url":"https://github.com/dealii/dealii/pull/88.diff","patch_url":"https://github.com/dealii/dealii/pull/88.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/88","number":88,"state":"open","locked":false,"title":"FETools::get_fe_from_name() implemented for nonzero codimension","user":{"login":"guidokanschat","id":7237526,"avatar_url":"https://avatars.githubusercontent.com/u/7237526?v=2","gravatar_id":"94372392fb1a391a6530a3f3980acdcd","url":"https://api.github.com/users/guidokanschat","html_url":"https://github.com/guidokanschat","followers_url":"https://api.github.com/users/guidokanschat/followers","following_url":"https://api.github.com/users/guidokanschat/following{/other_user}","gists_url":"https://api.github.com/users/guidokanschat/gists{/gist_id}","starred_url":"https://api.github.com/users/guidokanschat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidokanschat/subscriptions","organizations_url":"https://api.github.com/users/guidokanschat/orgs","repos_url":"https://api.github.com/users/guidokanschat/repos","events_url":"https://api.github.com/users/guidokanschat/events{/privacy}","received_events_url":"https://api.github.com/users/guidokanschat/received_events","type":"User","site_admin":false},"body":"In addition to the new functionality, the internal structures mapping names to finite element factories have been improved, thus avoiding several specializations of functions.\r\n\r\nThis pull request fixes #86 (issue)","created_at":"2014-08-17T12:31:21Z","updated_at":"2014-08-18T16:59:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5df909de63099803c6ea88074445376e5aa23af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/88/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/88/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/88/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/8fd30bc7e0370336113f744d2034f8d1cd84b923","head":{"label":"guidokanschat:fe_from_name_codim_ready","ref":"fe_from_name_codim_ready","sha":"8fd30bc7e0370336113f744d2034f8d1cd84b923","user":{"login":"guidokanschat","id":7237526,"avatar_url":"https://avatars.githubusercontent.com/u/7237526?v=2","gravatar_id":"94372392fb1a391a6530a3f3980acdcd","url":"https://api.github.com/users/guidokanschat","html_url":"https://github.com/guidokanschat","followers_url":"https://api.github.com/users/guidokanschat/followers","following_url":"https://api.github.com/users/guidokanschat/following{/other_user}","gists_url":"https://api.github.com/users/guidokanschat/gists{/gist_id}","starred_url":"https://api.github.com/users/guidokanschat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidokanschat/subscriptions","organizations_url":"https://api.github.com/users/guidokanschat/orgs","repos_url":"https://api.github.com/users/guidokanschat/repos","events_url":"https://api.github.com/users/guidokanschat/events{/privacy}","received_events_url":"https://api.github.com/users/guidokanschat/received_events","type":"User","site_admin":false},"repo":{"id":22141778,"name":"dealii","full_name":"guidokanschat/dealii","owner":{"login":"guidokanschat","id":7237526,"avatar_url":"https://avatars.githubusercontent.com/u/7237526?v=2","gravatar_id":"94372392fb1a391a6530a3f3980acdcd","url":"https://api.github.com/users/guidokanschat","html_url":"https://github.com/guidokanschat","followers_url":"https://api.github.com/users/guidokanschat/followers","following_url":"https://api.github.com/users/guidokanschat/following{/other_user}","gists_url":"https://api.github.com/users/guidokanschat/gists{/gist_id}","starred_url":"https://api.github.com/users/guidokanschat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guidokanschat/subscriptions","organizations_url":"https://api.github.com/users/guidokanschat/orgs","repos_url":"https://api.github.com/users/guidokanschat/repos","events_url":"https://api.github.com/users/guidokanschat/events{/privacy}","received_events_url":"https://api.github.com/users/guidokanschat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guidokanschat/dealii","description":"The development repository for the deal.II finite element library.","fork":true,"url":"https://api.github.com/repos/guidokanschat/dealii","forks_url":"https://api.github.com/repos/guidokanschat/dealii/forks","keys_url":"https://api.github.com/repos/guidokanschat/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guidokanschat/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guidokanschat/dealii/teams","hooks_url":"https://api.github.com/repos/guidokanschat/dealii/hooks","issue_events_url":"https://api.github.com/repos/guidokanschat/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/guidokanschat/dealii/events","assignees_url":"https://api.github.com/repos/guidokanschat/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/guidokanschat/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/guidokanschat/dealii/tags","blobs_url":"https://api.github.com/repos/guidokanschat/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guidokanschat/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guidokanschat/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/guidokanschat/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guidokanschat/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/guidokanschat/dealii/languages","stargazers_url":"https://api.github.com/repos/guidokanschat/dealii/stargazers","contributors_url":"https://api.github.com/repos/guidokanschat/dealii/contributors","subscribers_url":"https://api.github.com/repos/guidokanschat/dealii/subscribers","subscription_url":"https://api.github.com/repos/guidokanschat/dealii/subscription","commits_url":"https://api.github.com/repos/guidokanschat/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/guidokanschat/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/guidokanschat/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/guidokanschat/dealii/issues/comments/{number}","contents_url":"https://api.github.com/repos/guidokanschat/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/guidokanschat/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guidokanschat/dealii/merges","archive_url":"https://api.github.com/repos/guidokanschat/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guidokanschat/dealii/downloads","issues_url":"https://api.github.com/repos/guidokanschat/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/guidokanschat/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/guidokanschat/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/guidokanschat/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guidokanschat/dealii/labels{/name}","releases_url":"https://api.github.com/repos/guidokanschat/dealii/releases{/id}","created_at":"2014-07-23T10:30:42Z","updated_at":"2014-07-27T08:42:51Z","pushed_at":"2014-08-18T12:18:40Z","git_url":"git://github.com/guidokanschat/dealii.git","ssh_url":"git@github.com:guidokanschat/dealii.git","clone_url":"https://github.com/guidokanschat/dealii.git","svn_url":"https://github.com/guidokanschat/dealii","homepage":"http://www.dealii.org/","size":93176,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"cab54c26a74a0cbc4c6244ca7b553c6b435e8da5","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=2","gravatar_id":null,"url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=2","gravatar_id":null,"url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments/{number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","created_at":"2014-07-17T14:00:26Z","updated_at":"2014-08-18T14:52:45Z","pushed_at":"2014-08-18T11:48:52Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":94586,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":18,"mirror_url":null,"open_issues_count":9,"forks":18,"open_issues":9,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/88"},"html":{"href":"https://github.com/dealii/dealii/pull/88"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/88"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/8fd30bc7e0370336113f744d2034f8d1cd84b923"}}}}