GitHub PullRequestReviewCommentEvent at 2014-09-25 17:11:39
Repository: REEF
Actor: jwang98052
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls/comments/18045284","id":18045284,"diff_hunk":"@@ -74,6 +74,7 @@ public void onNext(final StartTime startTime) {\n       HelloDriver.this.requestor.submit(EvaluatorRequest.newBuilder()\n           .setNumber(nCLRTasks + nJVMTasks)\n           .setMemory(128)\n+          .setCore(2)","path":"reef-examples-clr/src/main/java/com/microsoft/reef/examples/helloCLR/HelloDriver.java","position":4,"original_position":4,"commit_id":"dbae22e495287050c0a97f817ac04c6603bf0fea","original_commit_id":"dbae22e495287050c0a97f817ac04c6603bf0fea","user":{"login":"jwang98052","id":5666504,"avatar_url":"https://avatars.githubusercontent.com/u/5666504?v=2","gravatar_id":"","url":"https://api.github.com/users/jwang98052","html_url":"https://github.com/jwang98052","followers_url":"https://api.github.com/users/jwang98052/followers","following_url":"https://api.github.com/users/jwang98052/following{/other_user}","gists_url":"https://api.github.com/users/jwang98052/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang98052/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang98052/subscriptions","organizations_url":"https://api.github.com/users/jwang98052/orgs","repos_url":"https://api.github.com/users/jwang98052/repos","events_url":"https://api.github.com/users/jwang98052/events{/privacy}","received_events_url":"https://api.github.com/users/jwang98052/received_events","type":"User","site_admin":false},"body":"I just assign a number for showing how to set it. As a Hello sample, it can be set to 1.\r\n\r\nFrom: Markus Weimer [mailto:notifications@github.com]\r\nSent: Thursday, September 25, 2014 8:12 AM\r\nTo: Microsoft-CISL/REEF\r\nCc: Julia Wang (QIUHE)\r\nSubject: Re: [REEF] juwang-enable virtual core in Java Reef and clr bridge (#1002)\r\n\r\n\r\nIn reef-examples-clr/src/main/java/com/microsoft/reef/examples/helloCLR/HelloDriver.java:\r\n\r\n> @@ -74,6 +74,7 @@ public void onNext(final StartTime startTime) {\r\n\r\n>        HelloDriver.this.requestor.submit(EvaluatorRequest.newBuilder()\r\n\r\n>            .setNumber(nCLRTasks + nJVMTasks)\r\n\r\n>            .setMemory(128)\r\n\r\n> +          .setCore(2)\r\n\r\nWhy do we need 2 cores for this?\r\n\r\n—\r\nReply to this email directly or view it on GitHub<https://github.com/Microsoft-CISL/REEF/pull/1002/files#r18037588>.\r\n","created_at":"2014-09-25T17:11:39Z","updated_at":"2014-09-25T17:11:39Z","html_url":"https://github.com/Microsoft-CISL/REEF/pull/1002#discussion_r18045284","pull_request_url":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls/1002","_links":{"self":{"href":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls/comments/18045284"},"html":{"href":"https://github.com/Microsoft-CISL/REEF/pull/1002#discussion_r18045284"},"pull_request":{"href":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls/1002"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls/1002","id":21762235,"html_url":"https://github.com/Microsoft-CISL/REEF/pull/1002","diff_url":"https://github.com/Microsoft-CISL/REEF/pull/1002.diff","patch_url":"https://github.com/Microsoft-CISL/REEF/pull/1002.patch","issue_url":"https://api.github.com/repos/Microsoft-CISL/REEF/issues/1002","number":1002,"state":"open","locked":false,"title":"juwang-enable virtual core in Java Reef and clr bridge","user":{"login":"jwang98052","id":5666504,"avatar_url":"https://avatars.githubusercontent.com/u/5666504?v=2","gravatar_id":"","url":"https://api.github.com/users/jwang98052","html_url":"https://github.com/jwang98052","followers_url":"https://api.github.com/users/jwang98052/followers","following_url":"https://api.github.com/users/jwang98052/following{/other_user}","gists_url":"https://api.github.com/users/jwang98052/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang98052/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang98052/subscriptions","organizations_url":"https://api.github.com/users/jwang98052/orgs","repos_url":"https://api.github.com/users/jwang98052/repos","events_url":"https://api.github.com/users/jwang98052/events{/privacy}","received_events_url":"https://api.github.com/users/jwang98052/received_events","type":"User","site_admin":false},"body":"Currently Reef clients cannot set virtual core when they request evaluators. This PR is to enable the virtual core in EvaluatorRequest so that the clients can set core count when an EvaluatorRequest is created.  \r\nThe request is submitted through EvaluatorRequstor and eventually reaches to ResourceRequestHanlder and set to Resource object. ResourceRequestProto schema is updated for this.\r\nAfter a Container is allocated, the core data is passed back from YARN. ResourceAllocationProto and EvaluatorDescriptor are also modified to hold the data. \r\nSubmit() in EvaluatorRequestorBridge is updated to add this parameter. All clr bridge related methods are also modified accordingly. \r\n\r\nThis is for #995\r\n","created_at":"2014-09-25T05:43:35Z","updated_at":"2014-09-25T17:11:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"269688326d52e1dbc3188ad2b48765132e237608","assignee":{"login":"markusweimer","id":502371,"avatar_url":"https://avatars.githubusercontent.com/u/502371?v=2","gravatar_id":"","url":"https://api.github.com/users/markusweimer","html_url":"https://github.com/markusweimer","followers_url":"https://api.github.com/users/markusweimer/followers","following_url":"https://api.github.com/users/markusweimer/following{/other_user}","gists_url":"https://api.github.com/users/markusweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/markusweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusweimer/subscriptions","organizations_url":"https://api.github.com/users/markusweimer/orgs","repos_url":"https://api.github.com/users/markusweimer/repos","events_url":"https://api.github.com/users/markusweimer/events{/privacy}","received_events_url":"https://api.github.com/users/markusweimer/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls/1002/commits","review_comments_url":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls/1002/comments","review_comment_url":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Microsoft-CISL/REEF/issues/1002/comments","statuses_url":"https://api.github.com/repos/Microsoft-CISL/REEF/statuses/dbae22e495287050c0a97f817ac04c6603bf0fea","head":{"label":"Microsoft-CISL:juwang-virtualcore","ref":"juwang-virtualcore","sha":"dbae22e495287050c0a97f817ac04c6603bf0fea","user":{"login":"Microsoft-CISL","id":2067733,"avatar_url":"https://avatars.githubusercontent.com/u/2067733?v=2","gravatar_id":"","url":"https://api.github.com/users/Microsoft-CISL","html_url":"https://github.com/Microsoft-CISL","followers_url":"https://api.github.com/users/Microsoft-CISL/followers","following_url":"https://api.github.com/users/Microsoft-CISL/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft-CISL/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft-CISL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft-CISL/subscriptions","organizations_url":"https://api.github.com/users/Microsoft-CISL/orgs","repos_url":"https://api.github.com/users/Microsoft-CISL/repos","events_url":"https://api.github.com/users/Microsoft-CISL/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft-CISL/received_events","type":"Organization","site_admin":false},"repo":{"id":14316281,"name":"REEF","full_name":"Microsoft-CISL/REEF","owner":{"login":"Microsoft-CISL","id":2067733,"avatar_url":"https://avatars.githubusercontent.com/u/2067733?v=2","gravatar_id":"","url":"https://api.github.com/users/Microsoft-CISL","html_url":"https://github.com/Microsoft-CISL","followers_url":"https://api.github.com/users/Microsoft-CISL/followers","following_url":"https://api.github.com/users/Microsoft-CISL/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft-CISL/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft-CISL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft-CISL/subscriptions","organizations_url":"https://api.github.com/users/Microsoft-CISL/orgs","repos_url":"https://api.github.com/users/Microsoft-CISL/repos","events_url":"https://api.github.com/users/Microsoft-CISL/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft-CISL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft-CISL/REEF","description":"The Retainable Evaluator Execution Framework","fork":false,"url":"https://api.github.com/repos/Microsoft-CISL/REEF","forks_url":"https://api.github.com/repos/Microsoft-CISL/REEF/forks","keys_url":"https://api.github.com/repos/Microsoft-CISL/REEF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft-CISL/REEF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft-CISL/REEF/teams","hooks_url":"https://api.github.com/repos/Microsoft-CISL/REEF/hooks","issue_events_url":"https://api.github.com/repos/Microsoft-CISL/REEF/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft-CISL/REEF/events","assignees_url":"https://api.github.com/repos/Microsoft-CISL/REEF/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft-CISL/REEF/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft-CISL/REEF/tags","blobs_url":"https://api.github.com/repos/Microsoft-CISL/REEF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft-CISL/REEF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft-CISL/REEF/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft-CISL/REEF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft-CISL/REEF/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft-CISL/REEF/languages","stargazers_url":"https://api.github.com/repos/Microsoft-CISL/REEF/stargazers","contributors_url":"https://api.github.com/repos/Microsoft-CISL/REEF/contributors","subscribers_url":"https://api.github.com/repos/Microsoft-CISL/REEF/subscribers","subscription_url":"https://api.github.com/repos/Microsoft-CISL/REEF/subscription","commits_url":"https://api.github.com/repos/Microsoft-CISL/REEF/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft-CISL/REEF/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft-CISL/REEF/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft-CISL/REEF/issues/comments/{number}","contents_url":"https://api.github.com/repos/Microsoft-CISL/REEF/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft-CISL/REEF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft-CISL/REEF/merges","archive_url":"https://api.github.com/repos/Microsoft-CISL/REEF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft-CISL/REEF/downloads","issues_url":"https://api.github.com/repos/Microsoft-CISL/REEF/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft-CISL/REEF/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft-CISL/REEF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft-CISL/REEF/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft-CISL/REEF/releases{/id}","created_at":"2013-11-11T23:09:16Z","updated_at":"2014-09-09T15:30:58Z","pushed_at":"2014-09-25T06:18:51Z","git_url":"git://github.com/Microsoft-CISL/REEF.git","ssh_url":"git@github.com:Microsoft-CISL/REEF.git","clone_url":"https://github.com/Microsoft-CISL/REEF.git","svn_url":"https://github.com/Microsoft-CISL/REEF","homepage":"http://www.reef-project.org","size":21304,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":39,"forks":8,"open_issues":39,"watchers":49,"default_branch":"master"}},"base":{"label":"Microsoft-CISL:master","ref":"master","sha":"dc224636e9ba1429e01c63cca6fa4d8c321fbd48","user":{"login":"Microsoft-CISL","id":2067733,"avatar_url":"https://avatars.githubusercontent.com/u/2067733?v=2","gravatar_id":"","url":"https://api.github.com/users/Microsoft-CISL","html_url":"https://github.com/Microsoft-CISL","followers_url":"https://api.github.com/users/Microsoft-CISL/followers","following_url":"https://api.github.com/users/Microsoft-CISL/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft-CISL/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft-CISL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft-CISL/subscriptions","organizations_url":"https://api.github.com/users/Microsoft-CISL/orgs","repos_url":"https://api.github.com/users/Microsoft-CISL/repos","events_url":"https://api.github.com/users/Microsoft-CISL/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft-CISL/received_events","type":"Organization","site_admin":false},"repo":{"id":14316281,"name":"REEF","full_name":"Microsoft-CISL/REEF","owner":{"login":"Microsoft-CISL","id":2067733,"avatar_url":"https://avatars.githubusercontent.com/u/2067733?v=2","gravatar_id":"","url":"https://api.github.com/users/Microsoft-CISL","html_url":"https://github.com/Microsoft-CISL","followers_url":"https://api.github.com/users/Microsoft-CISL/followers","following_url":"https://api.github.com/users/Microsoft-CISL/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft-CISL/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft-CISL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft-CISL/subscriptions","organizations_url":"https://api.github.com/users/Microsoft-CISL/orgs","repos_url":"https://api.github.com/users/Microsoft-CISL/repos","events_url":"https://api.github.com/users/Microsoft-CISL/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft-CISL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft-CISL/REEF","description":"The Retainable Evaluator Execution Framework","fork":false,"url":"https://api.github.com/repos/Microsoft-CISL/REEF","forks_url":"https://api.github.com/repos/Microsoft-CISL/REEF/forks","keys_url":"https://api.github.com/repos/Microsoft-CISL/REEF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft-CISL/REEF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft-CISL/REEF/teams","hooks_url":"https://api.github.com/repos/Microsoft-CISL/REEF/hooks","issue_events_url":"https://api.github.com/repos/Microsoft-CISL/REEF/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft-CISL/REEF/events","assignees_url":"https://api.github.com/repos/Microsoft-CISL/REEF/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft-CISL/REEF/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft-CISL/REEF/tags","blobs_url":"https://api.github.com/repos/Microsoft-CISL/REEF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft-CISL/REEF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft-CISL/REEF/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft-CISL/REEF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft-CISL/REEF/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft-CISL/REEF/languages","stargazers_url":"https://api.github.com/repos/Microsoft-CISL/REEF/stargazers","contributors_url":"https://api.github.com/repos/Microsoft-CISL/REEF/contributors","subscribers_url":"https://api.github.com/repos/Microsoft-CISL/REEF/subscribers","subscription_url":"https://api.github.com/repos/Microsoft-CISL/REEF/subscription","commits_url":"https://api.github.com/repos/Microsoft-CISL/REEF/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft-CISL/REEF/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft-CISL/REEF/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft-CISL/REEF/issues/comments/{number}","contents_url":"https://api.github.com/repos/Microsoft-CISL/REEF/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft-CISL/REEF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft-CISL/REEF/merges","archive_url":"https://api.github.com/repos/Microsoft-CISL/REEF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft-CISL/REEF/downloads","issues_url":"https://api.github.com/repos/Microsoft-CISL/REEF/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft-CISL/REEF/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft-CISL/REEF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft-CISL/REEF/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft-CISL/REEF/releases{/id}","created_at":"2013-11-11T23:09:16Z","updated_at":"2014-09-09T15:30:58Z","pushed_at":"2014-09-25T06:18:51Z","git_url":"git://github.com/Microsoft-CISL/REEF.git","ssh_url":"git@github.com:Microsoft-CISL/REEF.git","clone_url":"https://github.com/Microsoft-CISL/REEF.git","svn_url":"https://github.com/Microsoft-CISL/REEF","homepage":"http://www.reef-project.org","size":21304,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":39,"forks":8,"open_issues":39,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls/1002"},"html":{"href":"https://github.com/Microsoft-CISL/REEF/pull/1002"},"issue":{"href":"https://api.github.com/repos/Microsoft-CISL/REEF/issues/1002"},"comments":{"href":"https://api.github.com/repos/Microsoft-CISL/REEF/issues/1002/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls/1002/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Microsoft-CISL/REEF/pulls/1002/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft-CISL/REEF/statuses/dbae22e495287050c0a97f817ac04c6603bf0fea"}}}}