GitHub PullRequestEvent at 2014-07-17 23:07:13
Repository: hackage-server
Actor: gintas
Payload: {"action":"opened","number":243,"pull_request":{"url":"https://api.github.com/repos/haskell/hackage-server/pulls/243","id":18560134,"html_url":"https://github.com/haskell/hackage-server/pull/243","diff_url":"https://github.com/haskell/hackage-server/pull/243.diff","patch_url":"https://github.com/haskell/hackage-server/pull/243.patch","issue_url":"https://api.github.com/repos/haskell/hackage-server/issues/243","number":243,"state":"open","title":"Removed support for ETags from serveTarball.","user":{"login":"gintas","id":62007,"avatar_url":"https://avatars.githubusercontent.com/u/62007?","gravatar_id":"38baaa17b9c289a3be9d861ec83c9186","url":"https://api.github.com/users/gintas","html_url":"https://github.com/gintas","followers_url":"https://api.github.com/users/gintas/followers","following_url":"https://api.github.com/users/gintas/following{/other_user}","gists_url":"https://api.github.com/users/gintas/gists{/gist_id}","starred_url":"https://api.github.com/users/gintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gintas/subscriptions","organizations_url":"https://api.github.com/users/gintas/orgs","repos_url":"https://api.github.com/users/gintas/repos","events_url":"https://api.github.com/users/gintas/events{/privacy}","received_events_url":"https://api.github.com/users/gintas/received_events","type":"User","site_admin":false},"body":"I spent some time converting some legacy etag code, until I realized that the code was actually bogus. It uses the tarball's ETag for individual files from inside the tarball. This can't be right (and a plain conversion to useETag would have resulted in a bug from overeager cache hits).\r\n\r\nAccording to grep these are the last instances of manual handling of ETags in hackage.","created_at":"2014-07-17T23:07:11Z","updated_at":"2014-07-17T23:07:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/haskell/hackage-server/pulls/243/commits","review_comments_url":"https://api.github.com/repos/haskell/hackage-server/pulls/243/comments","review_comment_url":"https://api.github.com/repos/haskell/hackage-server/pulls/comments/{number}","comments_url":"https://api.github.com/repos/haskell/hackage-server/issues/243/comments","statuses_url":"https://api.github.com/repos/haskell/hackage-server/statuses/f7137c368b870c0a5081724bf078f51ed568e789","head":{"label":"gintas:removetags","ref":"removetags","sha":"f7137c368b870c0a5081724bf078f51ed568e789","user":{"login":"gintas","id":62007,"avatar_url":"https://avatars.githubusercontent.com/u/62007?","gravatar_id":"38baaa17b9c289a3be9d861ec83c9186","url":"https://api.github.com/users/gintas","html_url":"https://github.com/gintas","followers_url":"https://api.github.com/users/gintas/followers","following_url":"https://api.github.com/users/gintas/following{/other_user}","gists_url":"https://api.github.com/users/gintas/gists{/gist_id}","starred_url":"https://api.github.com/users/gintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gintas/subscriptions","organizations_url":"https://api.github.com/users/gintas/orgs","repos_url":"https://api.github.com/users/gintas/repos","events_url":"https://api.github.com/users/gintas/events{/privacy}","received_events_url":"https://api.github.com/users/gintas/received_events","type":"User","site_admin":false},"repo":{"id":20700804,"name":"hackage-server","full_name":"gintas/hackage-server","owner":{"login":"gintas","id":62007,"avatar_url":"https://avatars.githubusercontent.com/u/62007?","gravatar_id":"38baaa17b9c289a3be9d861ec83c9186","url":"https://api.github.com/users/gintas","html_url":"https://github.com/gintas","followers_url":"https://api.github.com/users/gintas/followers","following_url":"https://api.github.com/users/gintas/following{/other_user}","gists_url":"https://api.github.com/users/gintas/gists{/gist_id}","starred_url":"https://api.github.com/users/gintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gintas/subscriptions","organizations_url":"https://api.github.com/users/gintas/orgs","repos_url":"https://api.github.com/users/gintas/repos","events_url":"https://api.github.com/users/gintas/events{/privacy}","received_events_url":"https://api.github.com/users/gintas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gintas/hackage-server","description":"The new Hackage server aka \"Hackage 2\"","fork":true,"url":"https://api.github.com/repos/gintas/hackage-server","forks_url":"https://api.github.com/repos/gintas/hackage-server/forks","keys_url":"https://api.github.com/repos/gintas/hackage-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gintas/hackage-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gintas/hackage-server/teams","hooks_url":"https://api.github.com/repos/gintas/hackage-server/hooks","issue_events_url":"https://api.github.com/repos/gintas/hackage-server/issues/events{/number}","events_url":"https://api.github.com/repos/gintas/hackage-server/events","assignees_url":"https://api.github.com/repos/gintas/hackage-server/assignees{/user}","branches_url":"https://api.github.com/repos/gintas/hackage-server/branches{/branch}","tags_url":"https://api.github.com/repos/gintas/hackage-server/tags","blobs_url":"https://api.github.com/repos/gintas/hackage-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gintas/hackage-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gintas/hackage-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/gintas/hackage-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gintas/hackage-server/statuses/{sha}","languages_url":"https://api.github.com/repos/gintas/hackage-server/languages","stargazers_url":"https://api.github.com/repos/gintas/hackage-server/stargazers","contributors_url":"https://api.github.com/repos/gintas/hackage-server/contributors","subscribers_url":"https://api.github.com/repos/gintas/hackage-server/subscribers","subscription_url":"https://api.github.com/repos/gintas/hackage-server/subscription","commits_url":"https://api.github.com/repos/gintas/hackage-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/gintas/hackage-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/gintas/hackage-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/gintas/hackage-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/gintas/hackage-server/contents/{+path}","compare_url":"https://api.github.com/repos/gintas/hackage-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gintas/hackage-server/merges","archive_url":"https://api.github.com/repos/gintas/hackage-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gintas/hackage-server/downloads","issues_url":"https://api.github.com/repos/gintas/hackage-server/issues{/number}","pulls_url":"https://api.github.com/repos/gintas/hackage-server/pulls{/number}","milestones_url":"https://api.github.com/repos/gintas/hackage-server/milestones{/number}","notifications_url":"https://api.github.com/repos/gintas/hackage-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gintas/hackage-server/labels{/name}","releases_url":"https://api.github.com/repos/gintas/hackage-server/releases{/id}","created_at":"2014-06-10T20:37:03Z","updated_at":"2014-07-17T21:22:05Z","pushed_at":"2014-07-17T23:05:05Z","git_url":"git://github.com/gintas/hackage-server.git","ssh_url":"git@github.com:gintas/hackage-server.git","clone_url":"https://github.com/gintas/hackage-server.git","svn_url":"https://github.com/gintas/hackage-server","homepage":"hackage.haskell.org","size":5047,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"c95de2cdc85df134c70ea3da68bb1f521d8727d3","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?","gravatar_id":"f92c0b083ed9db8211f9e58d7facbcc0","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":12241186,"name":"hackage-server","full_name":"haskell/hackage-server","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?","gravatar_id":"f92c0b083ed9db8211f9e58d7facbcc0","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/hackage-server","description":"The new Hackage server aka \"Hackage 2\"","fork":false,"url":"https://api.github.com/repos/haskell/hackage-server","forks_url":"https://api.github.com/repos/haskell/hackage-server/forks","keys_url":"https://api.github.com/repos/haskell/hackage-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/hackage-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/hackage-server/teams","hooks_url":"https://api.github.com/repos/haskell/hackage-server/hooks","issue_events_url":"https://api.github.com/repos/haskell/hackage-server/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/hackage-server/events","assignees_url":"https://api.github.com/repos/haskell/hackage-server/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/hackage-server/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/hackage-server/tags","blobs_url":"https://api.github.com/repos/haskell/hackage-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/hackage-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/hackage-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/hackage-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/hackage-server/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/hackage-server/languages","stargazers_url":"https://api.github.com/repos/haskell/hackage-server/stargazers","contributors_url":"https://api.github.com/repos/haskell/hackage-server/contributors","subscribers_url":"https://api.github.com/repos/haskell/hackage-server/subscribers","subscription_url":"https://api.github.com/repos/haskell/hackage-server/subscription","commits_url":"https://api.github.com/repos/haskell/hackage-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/hackage-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/hackage-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/hackage-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/haskell/hackage-server/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/hackage-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/hackage-server/merges","archive_url":"https://api.github.com/repos/haskell/hackage-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/hackage-server/downloads","issues_url":"https://api.github.com/repos/haskell/hackage-server/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/hackage-server/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/hackage-server/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/hackage-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/hackage-server/labels{/name}","releases_url":"https://api.github.com/repos/haskell/hackage-server/releases{/id}","created_at":"2013-08-20T11:08:21Z","updated_at":"2014-07-13T01:49:15Z","pushed_at":"2014-07-11T10:38:33Z","git_url":"git://github.com/haskell/hackage-server.git","ssh_url":"git@github.com:haskell/hackage-server.git","clone_url":"https://github.com/haskell/hackage-server.git","svn_url":"https://github.com/haskell/hackage-server","homepage":"hackage.haskell.org","size":8294,"stargazers_count":89,"watchers_count":89,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":45,"mirror_url":null,"open_issues_count":101,"forks":45,"open_issues":101,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/hackage-server/pulls/243"},"html":{"href":"https://github.com/haskell/hackage-server/pull/243"},"issue":{"href":"https://api.github.com/repos/haskell/hackage-server/issues/243"},"comments":{"href":"https://api.github.com/repos/haskell/hackage-server/issues/243/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/hackage-server/pulls/243/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/hackage-server/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/haskell/hackage-server/pulls/243/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/hackage-server/statuses/f7137c368b870c0a5081724bf078f51ed568e789"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":29,"deletions":34,"changed_files":4}}