GitHub PullRequestReviewCommentEvent at 2014-02-24 21:57:15
Repository: ka-lite
Actor: aronasorman
Payload: {"comment":{"url":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments/10012812","id":10012812,"diff_hunk":"@@ -160,6 +160,9 @@ def stamp_availability_on_topic(topic, videos_path=settings.CONTENT_ROOT, force=\n     Input Parameters:\n     * videos_path: the path to video files\n     \"\"\"\n+    if counts_need_update is None:\n+        counts_need_update = video_counts_need_update()","path":"kalite/updates/videos.py","position":14,"original_position":14,"commit_id":"92b055773312ef632629ad6df27e7176df266088","original_commit_id":"92b055773312ef632629ad6df27e7176df266088","user":{"login":"aronasorman","id":191955,"avatar_url":"https://gravatar.com/avatar/1ba9fd7d7196f6f42610ebc9abc56c1b?d=https%3A%2F%2Fidenticons.github.com%2Fb52ba35087dd94fc5252cfa27fb42c96.png&r=x","gravatar_id":"1ba9fd7d7196f6f42610ebc9abc56c1b","url":"https://api.github.com/users/aronasorman","html_url":"https://github.com/aronasorman","followers_url":"https://api.github.com/users/aronasorman/followers","following_url":"https://api.github.com/users/aronasorman/following{/other_user}","gists_url":"https://api.github.com/users/aronasorman/gists{/gist_id}","starred_url":"https://api.github.com/users/aronasorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aronasorman/subscriptions","organizations_url":"https://api.github.com/users/aronasorman/orgs","repos_url":"https://api.github.com/users/aronasorman/repos","events_url":"https://api.github.com/users/aronasorman/events{/privacy}","received_events_url":"https://api.github.com/users/aronasorman/received_events","type":"User","site_admin":false},"body":"This seems counterintuitive. We tell python that `video_counts_need_update` if we leave `counts_need_update` as `None`? I think `counts_need_update` isn't the right name for this variable. ","created_at":"2014-02-24T21:57:15Z","updated_at":"2014-02-24T21:57:15Z","html_url":"https://github.com/learningequality/ka-lite/pull/1609#discussion_r10012812","pull_request_url":"https://api.github.com/repos/learningequality/ka-lite/pulls/1609","_links":{"self":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments/10012812"},"html":{"href":"https://github.com/learningequality/ka-lite/pull/1609#discussion_r10012812"},"pull_request":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/1609"}}}}