GitHub PushEvent at 2014-07-19 09:58:31
Repository: libphutil
Actor: schlaile
Payload: {"shas":[["90aaeb01bb9291459fa6b6d8fedbaacab1f70cb3","428b6da53085b8fd7b37e9fb259c0c609bd09984@automattic.com","Add WordPress.com OAuth2 plugin\n\nSummary:\nThis plugin provides an OAuth authentication provider to authenticate users using WordPress.com Connect.\n\nThis diff corresponds to the github pull request: https://github.com/facebook/libphutil/pull/36\n\nTest Plan: No test plan, at the moment.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: Korvin, epriestley\n\nDifferential Revision: https://secure.phabricator.com/D9004","Ashish SHUKLA",true],["094582983b54e3092122bbffaf600b183c6d0f1a","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Minor, update map.","epriestley",true],["2f3b5a1cf6ea464a0250d4b1c653a795a90d2716","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","Use the `ArcanistConfigurationDrivenLintEngine` as a linting engine.\n\nSummary: Ref T2039. This diff is the equivalent to D9057, but for rPHU.\n\nTest Plan: Ran `arc lint` and ensure it doesn't complain about the `.arclint` file.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: epriestley, Korvin\n\nManiphest Tasks: T2039\n\nDifferential Revision: https://secure.phabricator.com/D9063","Joshua Spence",true],["8ac1de09df406498cd4acf012409d513ccf4ad31","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Add phutil-library linter to libphutil\n\nSummary: Ref T2039. See D9070. D9072 is similar.\n\nTest Plan: Ran `arc lint`.\n\nReviewers: btrahan, joshuaspence\n\nReviewed By: joshuaspence\n\nSubscribers: epriestley\n\nManiphest Tasks: T2039\n\nDifferential Revision: https://secure.phabricator.com/D9074","epriestley",true],["4b85681758d7c4589a922b508802c0f02f3a2442","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","Attempt to automatically build XHPAST.\n\nSummary: Fixes T4951. Whilst `xhpast` was originally intended to be an internal development tool, it is not unreasonable for `ArcanistXHPASTLinter` to be used externally. Currently, however, if the compiled version of `xhpast` is not up-to-date, we simply exit and ask the user to build XHPAST themselves. Instead, let's try to build XHPAST automatically.\n\nTest Plan: Removed `./src/parser/xhpast/bin/xhpast` and ran `arc lint` over a PHP file. Verified that the `xhpast` binary was created during this process.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: epriestley, Korvin\n\nManiphest Tasks: T4951\n\nDifferential Revision: https://secure.phabricator.com/D9076","Joshua Spence",true],["5c98194c64c53140e70e9e2adc1d0ce8756973b4","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Change xdebug.max_nesting_level config after XDebug changes\n\nSummary: Fixes T5027. XDebug has changed how it interprets `0`. See the task or inline for more discussion.\n\nTest Plan:\n  - @martin.lindhe confirmed this resolve issues locally.\n  - Dug through XDebug to find a root cause for this behavior.\n\nReviewers: btrahan\n\nReviewed By: btrahan\n\nSubscribers: martin.lindhe, epriestley\n\nManiphest Tasks: T5027\n\nDifferential Revision: https://secure.phabricator.com/D9075","epriestley",true],["f253b0245454a12ddf91d1bb88f0c75c0de113ad","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Allow the InRequest key-value cache to have a simple key limit\n\nSummary: Performance of the new graph cache is okay, but pulling data from APC is more expensive than I expected. I'm going to try to tune that by doing some in-request caching, since all requests normally examine the same bucket at first.\n\nTest Plan: Added and executed unit tests.\n\nReviewers: btrahan\n\nReviewed By: btrahan\n\nSubscribers: epriestley\n\nDifferential Revision: https://secure.phabricator.com/D9079","epriestley",true],["9399881fd82a432446adffa83dac0324ecf1036f","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","Add an `selectDescendantsOfTypes` to the `AASTNode`.\n\nSummary: This method generally seems to make sense (there already exists such a method in the `AASTNodeList` class). Additionally, such a method simplifies D9117 slightly.\n\nTest Plan: Ran the unit tests in rARC, which generally rely on this class.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: epriestley, Korvin\n\nDifferential Revision: https://secure.phabricator.com/D9134","Joshua Spence",true],["32f1dad1f4e5b41671ab0e5ec2ca51544b0546b9","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","Change double quotes to single quotes.\n\nSummary: Ran `arc lint --apply-patches --everything` over rPHU, mainly to change double quotes to single quotes where appropriate. These changes also validate that the `ArcanistXHPASTLinter::LINT_DOUBLE_QUOTE` rule is working as expected.\n\nTest Plan: `arc unit --everything` and eyeballed the diff.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: epriestley, Korvin\n\nDifferential Revision: https://secure.phabricator.com/D9184","Joshua Spence",true],["1add454ccdb7a23bd8d1823452c570bf2ae445e0","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","Use the `ArcanistChmodLinter`.\n\nSummary: Apply the `ArcanistChmodLinter` from D9187.\n\nTest Plan: Removed all other linters from the `.arclint` file and executed `arc lint --everything`. Confirmed that there were no issues raised.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: epriestley, Korvin\n\nDifferential Revision: https://secure.phabricator.com/D9189","Joshua Spence",true],["a80783bec2c461f8e3e249ef26460d262a6dce06","c34c009102e60d77975598e1f414f8a701c22d0b@chadsdomain.com","Rebuild map\n\nSummary: arc liberate src\n\nTest Plan: n/a\n\nReviewers: btrahan, epriestley\n\nReviewed By: epriestley\n\nSubscribers: epriestley, Korvin\n\nDifferential Revision: https://secure.phabricator.com/D9218","Chad Little",true],["195a5f93c04308e10eb70756b0ef455b999fb52b","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Throw when passing array_mergev() non-array items\n\nSummary: See rP481a2954545e for an example of the kind of error this can catch.\n\nTest Plan: Ran unit tests.\n\nReviewers: btrahan\n\nReviewed By: btrahan\n\nSubscribers: epriestley\n\nDifferential Revision: https://secure.phabricator.com/D9213","epriestley",true],["f808f251f1ce10378782b8115083a1c3f4030560","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","Store daemon arguments in reference file.\n\nSummary: Ref T4735. Store the arguments that were used to launch a daemon in the reference file. This will allow the daemon arguments to be echoed to the console for `./bin/phd status`.\n\nTest Plan: See D9208.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: epriestley, Korvin\n\nManiphest Tasks: T4735\n\nDifferential Revision: https://secure.phabricator.com/D9207","Joshua Spence",true],["1ba1de50e9ee1ca63e472f625282346693eb0a18","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","Add `%LR` support to `csprintf`.\n\nSummary: Allow `csprintf` to format an array of readable strings.\n\nTest Plan:\nI didn't create any test cases because there aren't any existing test cases for `csprintf`. Instead, I used the following script:\n\n```lang=php\n<?php\n\nrequire_once __DIR__.'/scripts/__init_script__.php';\n\necho csprintf('%LR', array('foo', '--not', 'bar')).\"\\n\";\necho csprintf('%LR', array('foo', '--not bar')).\"\\n\";\n```\n\nThe output was as follows:\n\n```\nfoo --not bar\nfoo '--not bar'\n```\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: epriestley, Korvin\n\nDifferential Revision: https://secure.phabricator.com/D9229","Joshua Spence",true],["efa928f703074a699a8fe7a2e113a9249883002c","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","Allow `FileFinder` to find paths which match a given path exactly.\n\nSummary: Ref T5105. This functionality is required in order to discover all `.editorconfig` files.\n\nTest Plan: Wrote and executed unit tests.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: epriestley, Korvin\n\nManiphest Tasks: T5105\n\nDifferential Revision: https://secure.phabricator.com/D9295","Joshua Spence",true],["c4cb6d99c4a5903079350f85fcc71895c0a0ea14","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","Add `pygmentize` support for Puppet files.\n\nSummary: A Puppet lexer was added to `pygmentize` in v1.6rc1. Apply the Puppet lexer to `*.pp` files.\n\nTest Plan: N/A\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: epriestley, Korvin\n\nDifferential Revision: https://secure.phabricator.com/D9318","Joshua Spence",true],["1e025a87a4cbd987ecabf9924d20412e24e6cf87","46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","Don't redraw the console progress bar every time\n\nSummary: lulululuul see D9361\n\nTest Plan: derp derp derp\n\nReviewers: joshuaspence\n\nReviewed By: joshuaspence\n\nSubscribers: epriestley\n\nDifferential Revision: https://secure.phabricator.com/D9363","epriestley",true],["3fe4daa19d2c13486d476dc8b6350549e6834b64","275001983491152f0bbc71db1b7e68f0ee0f2ba8@gmail.com","Fix lint when working on windows\n\nSummary:\nFixes T4395.\n\nAdd quotes to ExecFuture strings on Windows to prevent `cmd.exe` from mucking up the command string.\n\nTest Plan: Run `arc lint` on projects using `phpcs`. See everything working like it should.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: epriestley, Korvin\n\nManiphest Tasks: T4592, T4395\n\nDifferential Revision: https://secure.phabricator.com/D9348","Richard van Velzen",true],["120a050b9251f11bc88779ba32cde96ebc254fca","c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","Allow triple backticks to be preceded by whitespace.\n\nSummary: Fixes T5264. Allows triple backticks to be preceded by whitespace in a code block. This fixes the display of quoted code blocks, which are regular code blocks prefied with `> `.\n\nTest Plan: Wrote and executed unit tests.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: epriestley, Korvin\n\nManiphest Tasks: T5264\n\nDifferential Revision: https://secure.phabricator.com/D9388","Joshua Spence",true],["9b2f35480dc0cc93d0b202501ea827476f825f88","6190d6ce5d3c08d4cc8f74a18d3b5cbb0c4353a8@gmail.com","Implementation of PhutilLexer for Python\n\nSummary: This appears to be ~1.5-2.0x faster than pygments on my machine, which isn't as good as I was hoping for but will help. (This is ~330 ms for a 4400-line file I chose at random.)\n\nTest Plan: Loaded a Python paste and saw highlights that approximately (or maybe exactly) match the pygments version.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: epriestley, Korvin\n\nDifferential Revision: https://secure.phabricator.com/D9370","Ben Alpert",true]],"size":116,"ref":"refs/heads/master","head":"d0a04643ac23e58fb5b68c4f457ed73aea7d41a9"}