GitHub PullRequestReviewCommentEvent at 2014-04-14 16:20:55
Repository: mongo-php-driver
Actor: jmikola
Payload: {"comment":{"url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/11592993","id":11592993,"diff_hunk":"@@ -159,8 +159,9 @@ void mongo_write_property(zval *object, zval *member, zval *value TSRMLS_DC)\n \t\tphp_error_docref(NULL TSRMLS_CC, MONGO_E_DEPRECATED, \"The '%s' property is deprecated\", Z_STRVAL_P(member));\n \t}\n \tif (property_info && property_info->flags & MONGO_ACC_READ_ONLY) {\n-\t\t/* If its the object itself that is updating the property, then its OK */\n-\t\tif (EG(scope) != Z_OBJCE_P(object)) {\n+\t\t/* If its the object itself that is updating the property, or an\n+\t\t * inherited class, then its OK */\n+\t\tif (!instanceof_function(Z_OBJCE_P(object), EG(scope) TSRMLS_CC)) {","path":"mongoclient.c","position":8,"original_position":8,"commit_id":"4495acc52a89b5420d38964360007cd768069780","original_commit_id":"4495acc52a89b5420d38964360007cd768069780","user":{"login":"jmikola","id":244663,"avatar_url":"https://avatars.githubusercontent.com/u/244663?","gravatar_id":"f23700b51dc0c196c1dc02f84aeeecdf","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User","site_admin":false},"body":"Based on this logic, I think we should have additional tests for setting the property from within a custom method of the child class (no warning) and then attempting to set it from the global scope (trigger a warning).","created_at":"2014-04-14T16:20:55Z","updated_at":"2014-04-14T16:20:55Z","html_url":"https://github.com/mongodb/mongo-php-driver/pull/667#discussion_r11592993","pull_request_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/667","_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/11592993"},"html":{"href":"https://github.com/mongodb/mongo-php-driver/pull/667#discussion_r11592993"},"pull_request":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/667"}}}}