GitHub PullRequestEvent at 2014-11-26 05:54:50
Repository: cocos2d-x
Actor: minggo
Payload: {"action":"closed","number":8979,"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/8979","id":23598124,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/8979","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/8979.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/8979.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/8979","number":8979,"state":"closed","locked":false,"title":"eaglview release leak in CCEAGLViewImpl-ios","user":{"login":"uorbe001","id":610728,"avatar_url":"https://avatars.githubusercontent.com/u/610728?v=3","gravatar_id":"","url":"https://api.github.com/users/uorbe001","html_url":"https://github.com/uorbe001","followers_url":"https://api.github.com/users/uorbe001/followers","following_url":"https://api.github.com/users/uorbe001/following{/other_user}","gists_url":"https://api.github.com/users/uorbe001/gists{/gist_id}","starred_url":"https://api.github.com/users/uorbe001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uorbe001/subscriptions","organizations_url":"https://api.github.com/users/uorbe001/orgs","repos_url":"https://api.github.com/users/uorbe001/repos","events_url":"https://api.github.com/users/uorbe001/events{/privacy}","received_events_url":"https://api.github.com/users/uorbe001/received_events","type":"User","site_admin":false},"body":"This is leaking the eaglview when the Director is purged.\r\n\r\nIn our case, we are leaving the cocos environment on some views which\r\nare implemented with cocoa, and because this eaglview is not being\r\nreleased, it is getting notifications for keyboard events, and trying to\r\naccess stuff on the NULL eaglview, crashing our app.\r\n","created_at":"2014-10-30T11:33:45Z","updated_at":"2014-11-26T05:54:49Z","closed_at":"2014-11-26T05:54:49Z","merged_at":"2014-11-26T05:54:49Z","merge_commit_sha":"7564d2e73586ab9a9d436b858755928097d54636","assignee":{"login":"huangshiwu","id":8086269,"avatar_url":"https://avatars.githubusercontent.com/u/8086269?v=3","gravatar_id":"","url":"https://api.github.com/users/huangshiwu","html_url":"https://github.com/huangshiwu","followers_url":"https://api.github.com/users/huangshiwu/followers","following_url":"https://api.github.com/users/huangshiwu/following{/other_user}","gists_url":"https://api.github.com/users/huangshiwu/gists{/gist_id}","starred_url":"https://api.github.com/users/huangshiwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangshiwu/subscriptions","organizations_url":"https://api.github.com/users/huangshiwu/orgs","repos_url":"https://api.github.com/users/huangshiwu/repos","events_url":"https://api.github.com/users/huangshiwu/events{/privacy}","received_events_url":"https://api.github.com/users/huangshiwu/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/8979/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/8979/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/8979/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/cc2653d657352395dc8d59526c6437092c5ff6ef","head":{"label":"Gamevy:bugfix/release-eaglview-on-ios","ref":"bugfix/release-eaglview-on-ios","sha":"cc2653d657352395dc8d59526c6437092c5ff6ef","user":{"login":"Gamevy","id":4048001,"avatar_url":"https://avatars.githubusercontent.com/u/4048001?v=3","gravatar_id":"","url":"https://api.github.com/users/Gamevy","html_url":"https://github.com/Gamevy","followers_url":"https://api.github.com/users/Gamevy/followers","following_url":"https://api.github.com/users/Gamevy/following{/other_user}","gists_url":"https://api.github.com/users/Gamevy/gists{/gist_id}","starred_url":"https://api.github.com/users/Gamevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gamevy/subscriptions","organizations_url":"https://api.github.com/users/Gamevy/orgs","repos_url":"https://api.github.com/users/Gamevy/repos","events_url":"https://api.github.com/users/Gamevy/events{/privacy}","received_events_url":"https://api.github.com/users/Gamevy/received_events","type":"Organization","site_admin":false},"repo":{"id":22209327,"name":"cocos2d-x","full_name":"Gamevy/cocos2d-x","owner":{"login":"Gamevy","id":4048001,"avatar_url":"https://avatars.githubusercontent.com/u/4048001?v=3","gravatar_id":"","url":"https://api.github.com/users/Gamevy","html_url":"https://github.com/Gamevy","followers_url":"https://api.github.com/users/Gamevy/followers","following_url":"https://api.github.com/users/Gamevy/following{/other_user}","gists_url":"https://api.github.com/users/Gamevy/gists{/gist_id}","starred_url":"https://api.github.com/users/Gamevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gamevy/subscriptions","organizations_url":"https://api.github.com/users/Gamevy/orgs","repos_url":"https://api.github.com/users/Gamevy/repos","events_url":"https://api.github.com/users/Gamevy/events{/privacy}","received_events_url":"https://api.github.com/users/Gamevy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Gamevy/cocos2d-x","description":"cocos2d-x for C++","fork":true,"url":"https://api.github.com/repos/Gamevy/cocos2d-x","forks_url":"https://api.github.com/repos/Gamevy/cocos2d-x/forks","keys_url":"https://api.github.com/repos/Gamevy/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gamevy/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gamevy/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/Gamevy/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/Gamevy/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/Gamevy/cocos2d-x/events","assignees_url":"https://api.github.com/repos/Gamevy/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/Gamevy/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/Gamevy/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/Gamevy/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gamevy/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gamevy/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gamevy/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gamevy/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/Gamevy/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/Gamevy/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/Gamevy/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/Gamevy/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/Gamevy/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/Gamevy/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gamevy/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gamevy/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gamevy/cocos2d-x/issues/comments/{number}","contents_url":"https://api.github.com/repos/Gamevy/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/Gamevy/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gamevy/cocos2d-x/merges","archive_url":"https://api.github.com/repos/Gamevy/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gamevy/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/Gamevy/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/Gamevy/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/Gamevy/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/Gamevy/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gamevy/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/Gamevy/cocos2d-x/releases{/id}","created_at":"2014-07-24T10:42:15Z","updated_at":"2014-07-24T10:16:04Z","pushed_at":"2014-10-30T14:51:15Z","git_url":"git://github.com/Gamevy/cocos2d-x.git","ssh_url":"git@github.com:Gamevy/cocos2d-x.git","clone_url":"https://github.com/Gamevy/cocos2d-x.git","svn_url":"https://github.com/Gamevy/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":140731,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"v3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"e99ea7a9fedf1969bd0081d416e404f56819f84e","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments/{number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","created_at":"2010-11-18T23:17:00Z","updated_at":"2014-11-26T05:51:15Z","pushed_at":"2014-11-26T05:54:49Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1285433,"stargazers_count":4692,"watchers_count":4692,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3521,"mirror_url":null,"open_issues_count":481,"forks":3521,"open_issues":481,"watchers":4692,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/8979"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/8979"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/8979"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/8979/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/8979/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/8979/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/cc2653d657352395dc8d59526c6437092c5ff6ef"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"minggo","id":488203,"avatar_url":"https://avatars.githubusercontent.com/u/488203?v=3","gravatar_id":"","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"comments":2,"review_comments":5,"commits":2,"additions":3,"deletions":2,"changed_files":1}}