GitHub PullRequestReviewCommentEvent at 2014-06-06 12:10:16
Repository: django
Actor: coder9042
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/13486381","id":13486381,"diff_hunk":"@@ -1432,6 +1433,37 @@ def _check_ordering(cls):\n                 )\n         return errors\n \n+    @classmethod\n+    def _check_long_column_name(cls):\n+        errors = []\n+        allowed_len = None\n+\n+        db_alias = router.db_for_write(cls)\n+        connection = connections[db_alias]\n+        allowed_len = connection.ops.max_name_length()\n+\n+        if not connection.features.supports_long_model_names:","path":"django/db/models/base.py","position":30,"original_position":30,"commit_id":"cb802833dd670f18fec3ef844a1f48577f8df91e","original_commit_id":"cb802833dd670f18fec3ef844a1f48577f8df91e","user":{"login":"coder9042","id":5247374,"avatar_url":"https://avatars.githubusercontent.com/u/5247374?","gravatar_id":"a7b7e3784e7f6299def696779aba819f","url":"https://api.github.com/users/coder9042","html_url":"https://github.com/coder9042","followers_url":"https://api.github.com/users/coder9042/followers","following_url":"https://api.github.com/users/coder9042/following{/other_user}","gists_url":"https://api.github.com/users/coder9042/gists{/gist_id}","starred_url":"https://api.github.com/users/coder9042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coder9042/subscriptions","organizations_url":"https://api.github.com/users/coder9042/orgs","repos_url":"https://api.github.com/users/coder9042/repos","events_url":"https://api.github.com/users/coder9042/events{/privacy}","received_events_url":"https://api.github.com/users/coder9042/received_events","type":"User","site_admin":false},"body":"Well its the name of the variable. Its used for the purpose of field names only.\r\nBecause model_db_names are always passed to `truncate_name`.\r\nSee: https://github.com/django/django/blob/master/django/db/models/options.py#L164\r\nThis is also the topic of the other PR.","created_at":"2014-06-06T12:10:16Z","updated_at":"2014-06-06T12:10:16Z","html_url":"https://github.com/django/django/pull/2738#discussion_r13486381","pull_request_url":"https://api.github.com/repos/django/django/pulls/2738","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/13486381"},"html":{"href":"https://github.com/django/django/pull/2738#discussion_r13486381"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/2738"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/2738","id":16488179,"html_url":"https://github.com/django/django/pull/2738","diff_url":"https://github.com/django/django/pull/2738.diff","patch_url":"https://github.com/django/django/pull/2738.patch","issue_url":"https://api.github.com/repos/django/django/issues/2738","number":2738,"state":"open","title":"Fixed #13711 -- Model check added to ensure that auto-generated field name is within limits of the database.","user":{"login":"coder9042","id":5247374,"avatar_url":"https://avatars.githubusercontent.com/u/5247374?","gravatar_id":"a7b7e3784e7f6299def696779aba819f","url":"https://api.github.com/users/coder9042","html_url":"https://github.com/coder9042","followers_url":"https://api.github.com/users/coder9042/followers","following_url":"https://api.github.com/users/coder9042/following{/other_user}","gists_url":"https://api.github.com/users/coder9042/gists{/gist_id}","starred_url":"https://api.github.com/users/coder9042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coder9042/subscriptions","organizations_url":"https://api.github.com/users/coder9042/orgs","repos_url":"https://api.github.com/users/coder9042/repos","events_url":"https://api.github.com/users/coder9042/events{/privacy}","received_events_url":"https://api.github.com/users/coder9042/received_events","type":"User","site_admin":false},"body":"...ion.","created_at":"2014-05-29T16:04:05Z","updated_at":"2014-06-06T12:10:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b74e0de113dcb3b998f44166e094167a1d2f18b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/2738/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/2738/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments/{number}","comments_url":"https://api.github.com/repos/django/django/issues/2738/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/cb802833dd670f18fec3ef844a1f48577f8df91e","head":{"label":"coder9042:gsoc_13711","ref":"gsoc_13711","sha":"cb802833dd670f18fec3ef844a1f48577f8df91e","user":{"login":"coder9042","id":5247374,"avatar_url":"https://avatars.githubusercontent.com/u/5247374?","gravatar_id":"a7b7e3784e7f6299def696779aba819f","url":"https://api.github.com/users/coder9042","html_url":"https://github.com/coder9042","followers_url":"https://api.github.com/users/coder9042/followers","following_url":"https://api.github.com/users/coder9042/following{/other_user}","gists_url":"https://api.github.com/users/coder9042/gists{/gist_id}","starred_url":"https://api.github.com/users/coder9042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coder9042/subscriptions","organizations_url":"https://api.github.com/users/coder9042/orgs","repos_url":"https://api.github.com/users/coder9042/repos","events_url":"https://api.github.com/users/coder9042/events{/privacy}","received_events_url":"https://api.github.com/users/coder9042/received_events","type":"User","site_admin":false},"repo":{"id":15231768,"name":"django","full_name":"coder9042/django","owner":{"login":"coder9042","id":5247374,"avatar_url":"https://avatars.githubusercontent.com/u/5247374?","gravatar_id":"a7b7e3784e7f6299def696779aba819f","url":"https://api.github.com/users/coder9042","html_url":"https://github.com/coder9042","followers_url":"https://api.github.com/users/coder9042/followers","following_url":"https://api.github.com/users/coder9042/following{/other_user}","gists_url":"https://api.github.com/users/coder9042/gists{/gist_id}","starred_url":"https://api.github.com/users/coder9042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coder9042/subscriptions","organizations_url":"https://api.github.com/users/coder9042/orgs","repos_url":"https://api.github.com/users/coder9042/repos","events_url":"https://api.github.com/users/coder9042/events{/privacy}","received_events_url":"https://api.github.com/users/coder9042/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coder9042/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/coder9042/django","forks_url":"https://api.github.com/repos/coder9042/django/forks","keys_url":"https://api.github.com/repos/coder9042/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coder9042/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coder9042/django/teams","hooks_url":"https://api.github.com/repos/coder9042/django/hooks","issue_events_url":"https://api.github.com/repos/coder9042/django/issues/events{/number}","events_url":"https://api.github.com/repos/coder9042/django/events","assignees_url":"https://api.github.com/repos/coder9042/django/assignees{/user}","branches_url":"https://api.github.com/repos/coder9042/django/branches{/branch}","tags_url":"https://api.github.com/repos/coder9042/django/tags","blobs_url":"https://api.github.com/repos/coder9042/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coder9042/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coder9042/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/coder9042/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coder9042/django/statuses/{sha}","languages_url":"https://api.github.com/repos/coder9042/django/languages","stargazers_url":"https://api.github.com/repos/coder9042/django/stargazers","contributors_url":"https://api.github.com/repos/coder9042/django/contributors","subscribers_url":"https://api.github.com/repos/coder9042/django/subscribers","subscription_url":"https://api.github.com/repos/coder9042/django/subscription","commits_url":"https://api.github.com/repos/coder9042/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/coder9042/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/coder9042/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/coder9042/django/issues/comments/{number}","contents_url":"https://api.github.com/repos/coder9042/django/contents/{+path}","compare_url":"https://api.github.com/repos/coder9042/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coder9042/django/merges","archive_url":"https://api.github.com/repos/coder9042/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coder9042/django/downloads","issues_url":"https://api.github.com/repos/coder9042/django/issues{/number}","pulls_url":"https://api.github.com/repos/coder9042/django/pulls{/number}","milestones_url":"https://api.github.com/repos/coder9042/django/milestones{/number}","notifications_url":"https://api.github.com/repos/coder9042/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coder9042/django/labels{/name}","releases_url":"https://api.github.com/repos/coder9042/django/releases{/id}","created_at":"2013-12-16T17:05:03Z","updated_at":"2014-06-06T11:15:10Z","pushed_at":"2014-06-06T11:15:09Z","git_url":"git://github.com/coder9042/django.git","ssh_url":"git@github.com:coder9042/django.git","clone_url":"https://github.com/coder9042/django.git","svn_url":"https://github.com/coder9042/django","homepage":"http://www.djangoproject.com/","size":101715,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"daaeb8415823444a9020460cf825efc3fae866a2","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?","gravatar_id":"fd542381031aa84dca86628ece84fc07","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?","gravatar_id":"fd542381031aa84dca86628ece84fc07","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments/{number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","created_at":"2012-04-28T02:47:18Z","updated_at":"2014-06-06T12:05:40Z","pushed_at":"2014-06-06T12:05:42Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"http://www.djangoproject.com/","size":200743,"stargazers_count":10039,"watchers_count":10039,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":3829,"mirror_url":null,"open_issues_count":122,"forks":3829,"open_issues":122,"watchers":10039,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/2738"},"html":{"href":"https://github.com/django/django/pull/2738"},"issue":{"href":"https://api.github.com/repos/django/django/issues/2738"},"comments":{"href":"https://api.github.com/repos/django/django/issues/2738/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/2738/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/2738/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/cb802833dd670f18fec3ef844a1f48577f8df91e"}}}}