GitHub PullRequestReviewCommentEvent at 2014-08-28 09:04:13
Repository: scilifelab
Actor: Galithil
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls/comments/16828229","id":16828229,"diff_hunk":"@@ -378,28 +385,34 @@ def _get_preps_and_libval(self):\n         for AgrLibQC_id in top_level_agrlibval_steps.keys():\n             AgrLibQC_info = self.AgrLibQCs[AgrLibQC_id]\n             if AgrLibQC_info['samples'].has_key(self.name):\n-                for inart in AgrLibQC_info['samples'][self.name].items():\n-                    #Sometimes, we have two library steps with only one AgrLibQC step.\n-                    inart, outart = inart[1]\n-                    \n-                    history = gent.SampleHistory(sample_name=self.name, output_artifact=outart.id,\n-                                            input_artifact=inart.id, lims=self.lims, pro_per_art=self.processes_per_artifact )   \n-                    steps = ProcessSpec(history.history, history.history_list, self.application)\n-                    prep = Prep(self.name)\n-                    prep.set_prep_info(steps, self.application)\n-                    if not preps.has_key(prep.id2AB) and prep.id2AB:\n-                        preps[prep.id2AB] = prep.prep_info\n-                    if prep.pre_prep_library_validations and prep.id2AB:\n-                        preps[prep.id2AB]['pre_prep_library_validation'].update(prep.pre_prep_library_validations)\n-                    if prep.library_validations and prep.id2AB:\n-                        preps[prep.id2AB]['library_validation'].update(prep.library_validations)\n-                        last_libval_key = max(prep.library_validations.keys())\n-                        last_libval = prep.library_validations[last_libval_key]\n-                        if not very_last_libval_key.has_key(prep.id2AB) or (last_libval_key > very_last_libval_key[prep.id2AB]):\n-                            very_last_libval_key[prep.id2AB] = last_libval_key\n-                            if last_libval.has_key('prep_status'):\n-                                preps[prep.id2AB]['prep_status'] = last_libval['prep_status']\n-                            preps[prep.id2AB]['reagent_label'] = self._pars_reagent_labels(steps, last_libval)\n+                inart, outart = AgrLibQC_info['samples'][self.name].items()[0][1]","path":"scilifelab/lims_utils/objectsDB.py","position":463,"original_position":463,"commit_id":"0af08ece606ca2e479f9433baef276ccd3fbb063","original_commit_id":"0af08ece606ca2e479f9433baef276ccd3fbb063","user":{"login":"Galithil","id":7523280,"avatar_url":"https://avatars.githubusercontent.com/u/7523280?v=2","gravatar_id":"e8edc140c34e277cb41e840828a2e06e","url":"https://api.github.com/users/Galithil","html_url":"https://github.com/Galithil","followers_url":"https://api.github.com/users/Galithil/followers","following_url":"https://api.github.com/users/Galithil/following{/other_user}","gists_url":"https://api.github.com/users/Galithil/gists{/gist_id}","starred_url":"https://api.github.com/users/Galithil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Galithil/subscriptions","organizations_url":"https://api.github.com/users/Galithil/orgs","repos_url":"https://api.github.com/users/Galithil/repos","events_url":"https://api.github.com/users/Galithil/events{/privacy}","received_events_url":"https://api.github.com/users/Galithil/received_events","type":"User","site_admin":false},"body":"This removes the for we added to fix senthil's problem. Did you find a workaround ?","created_at":"2014-08-28T09:04:13Z","updated_at":"2014-08-28T09:04:13Z","html_url":"https://github.com/SciLifeLab/scilifelab/pull/410#discussion_r16828229","pull_request_url":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls/410","_links":{"self":{"href":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls/comments/16828229"},"html":{"href":"https://github.com/SciLifeLab/scilifelab/pull/410#discussion_r16828229"},"pull_request":{"href":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls/410"}}},"pull_request":{"url":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls/410","id":20304490,"html_url":"https://github.com/SciLifeLab/scilifelab/pull/410","diff_url":"https://github.com/SciLifeLab/scilifelab/pull/410.diff","patch_url":"https://github.com/SciLifeLab/scilifelab/pull/410.patch","issue_url":"https://api.github.com/repos/SciLifeLab/scilifelab/issues/410","number":410,"state":"open","locked":false,"title":"Adding demultiplex info to ProcessSpec and remooving google docs dependensies from objectsDB","user":{"login":"mayabrandi","id":1306333,"avatar_url":"https://avatars.githubusercontent.com/u/1306333?v=2","gravatar_id":"5689ef73f3147678b14b6697941c85ac","url":"https://api.github.com/users/mayabrandi","html_url":"https://github.com/mayabrandi","followers_url":"https://api.github.com/users/mayabrandi/followers","following_url":"https://api.github.com/users/mayabrandi/following{/other_user}","gists_url":"https://api.github.com/users/mayabrandi/gists{/gist_id}","starred_url":"https://api.github.com/users/mayabrandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayabrandi/subscriptions","organizations_url":"https://api.github.com/users/mayabrandi/orgs","repos_url":"https://api.github.com/users/mayabrandi/repos","events_url":"https://api.github.com/users/mayabrandi/events{/privacy}","received_events_url":"https://api.github.com/users/mayabrandi/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-08-26T12:16:13Z","updated_at":"2014-08-28T09:04:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab803e39042097b990d8df118ad78fcb6a025fcc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls/410/commits","review_comments_url":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls/410/comments","review_comment_url":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SciLifeLab/scilifelab/issues/410/comments","statuses_url":"https://api.github.com/repos/SciLifeLab/scilifelab/statuses/0af08ece606ca2e479f9433baef276ccd3fbb063","head":{"label":"mayabrandi:master","ref":"master","sha":"0af08ece606ca2e479f9433baef276ccd3fbb063","user":{"login":"mayabrandi","id":1306333,"avatar_url":"https://avatars.githubusercontent.com/u/1306333?v=2","gravatar_id":"5689ef73f3147678b14b6697941c85ac","url":"https://api.github.com/users/mayabrandi","html_url":"https://github.com/mayabrandi","followers_url":"https://api.github.com/users/mayabrandi/followers","following_url":"https://api.github.com/users/mayabrandi/following{/other_user}","gists_url":"https://api.github.com/users/mayabrandi/gists{/gist_id}","starred_url":"https://api.github.com/users/mayabrandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayabrandi/subscriptions","organizations_url":"https://api.github.com/users/mayabrandi/orgs","repos_url":"https://api.github.com/users/mayabrandi/repos","events_url":"https://api.github.com/users/mayabrandi/events{/privacy}","received_events_url":"https://api.github.com/users/mayabrandi/received_events","type":"User","site_admin":false},"repo":{"id":6047301,"name":"scilifelab","full_name":"mayabrandi/scilifelab","owner":{"login":"mayabrandi","id":1306333,"avatar_url":"https://avatars.githubusercontent.com/u/1306333?v=2","gravatar_id":"5689ef73f3147678b14b6697941c85ac","url":"https://api.github.com/users/mayabrandi","html_url":"https://github.com/mayabrandi","followers_url":"https://api.github.com/users/mayabrandi/followers","following_url":"https://api.github.com/users/mayabrandi/following{/other_user}","gists_url":"https://api.github.com/users/mayabrandi/gists{/gist_id}","starred_url":"https://api.github.com/users/mayabrandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayabrandi/subscriptions","organizations_url":"https://api.github.com/users/mayabrandi/orgs","repos_url":"https://api.github.com/users/mayabrandi/repos","events_url":"https://api.github.com/users/mayabrandi/events{/privacy}","received_events_url":"https://api.github.com/users/mayabrandi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mayabrandi/scilifelab","description":"Misc code snippets for Science For Life Laboratory","fork":true,"url":"https://api.github.com/repos/mayabrandi/scilifelab","forks_url":"https://api.github.com/repos/mayabrandi/scilifelab/forks","keys_url":"https://api.github.com/repos/mayabrandi/scilifelab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mayabrandi/scilifelab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mayabrandi/scilifelab/teams","hooks_url":"https://api.github.com/repos/mayabrandi/scilifelab/hooks","issue_events_url":"https://api.github.com/repos/mayabrandi/scilifelab/issues/events{/number}","events_url":"https://api.github.com/repos/mayabrandi/scilifelab/events","assignees_url":"https://api.github.com/repos/mayabrandi/scilifelab/assignees{/user}","branches_url":"https://api.github.com/repos/mayabrandi/scilifelab/branches{/branch}","tags_url":"https://api.github.com/repos/mayabrandi/scilifelab/tags","blobs_url":"https://api.github.com/repos/mayabrandi/scilifelab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mayabrandi/scilifelab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mayabrandi/scilifelab/git/refs{/sha}","trees_url":"https://api.github.com/repos/mayabrandi/scilifelab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mayabrandi/scilifelab/statuses/{sha}","languages_url":"https://api.github.com/repos/mayabrandi/scilifelab/languages","stargazers_url":"https://api.github.com/repos/mayabrandi/scilifelab/stargazers","contributors_url":"https://api.github.com/repos/mayabrandi/scilifelab/contributors","subscribers_url":"https://api.github.com/repos/mayabrandi/scilifelab/subscribers","subscription_url":"https://api.github.com/repos/mayabrandi/scilifelab/subscription","commits_url":"https://api.github.com/repos/mayabrandi/scilifelab/commits{/sha}","git_commits_url":"https://api.github.com/repos/mayabrandi/scilifelab/git/commits{/sha}","comments_url":"https://api.github.com/repos/mayabrandi/scilifelab/comments{/number}","issue_comment_url":"https://api.github.com/repos/mayabrandi/scilifelab/issues/comments/{number}","contents_url":"https://api.github.com/repos/mayabrandi/scilifelab/contents/{+path}","compare_url":"https://api.github.com/repos/mayabrandi/scilifelab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mayabrandi/scilifelab/merges","archive_url":"https://api.github.com/repos/mayabrandi/scilifelab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mayabrandi/scilifelab/downloads","issues_url":"https://api.github.com/repos/mayabrandi/scilifelab/issues{/number}","pulls_url":"https://api.github.com/repos/mayabrandi/scilifelab/pulls{/number}","milestones_url":"https://api.github.com/repos/mayabrandi/scilifelab/milestones{/number}","notifications_url":"https://api.github.com/repos/mayabrandi/scilifelab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mayabrandi/scilifelab/labels{/name}","releases_url":"https://api.github.com/repos/mayabrandi/scilifelab/releases{/id}","created_at":"2012-10-02T15:50:52Z","updated_at":"2014-08-22T08:59:15Z","pushed_at":"2014-08-28T08:54:34Z","git_url":"git://github.com/mayabrandi/scilifelab.git","ssh_url":"git@github.com:mayabrandi/scilifelab.git","clone_url":"https://github.com/mayabrandi/scilifelab.git","svn_url":"https://github.com/mayabrandi/scilifelab","homepage":"http://www.scilifelab.se","size":10622,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"SciLifeLab:master","ref":"master","sha":"802af3fe3f6e15b86515ff8bb95f66be4f1019f3","user":{"login":"SciLifeLab","id":713611,"avatar_url":"https://avatars.githubusercontent.com/u/713611?v=2","gravatar_id":"0ea188b063e94686a1dbb485e590e9f3","url":"https://api.github.com/users/SciLifeLab","html_url":"https://github.com/SciLifeLab","followers_url":"https://api.github.com/users/SciLifeLab/followers","following_url":"https://api.github.com/users/SciLifeLab/following{/other_user}","gists_url":"https://api.github.com/users/SciLifeLab/gists{/gist_id}","starred_url":"https://api.github.com/users/SciLifeLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciLifeLab/subscriptions","organizations_url":"https://api.github.com/users/SciLifeLab/orgs","repos_url":"https://api.github.com/users/SciLifeLab/repos","events_url":"https://api.github.com/users/SciLifeLab/events{/privacy}","received_events_url":"https://api.github.com/users/SciLifeLab/received_events","type":"Organization","site_admin":false},"repo":{"id":4002536,"name":"scilifelab","full_name":"SciLifeLab/scilifelab","owner":{"login":"SciLifeLab","id":713611,"avatar_url":"https://avatars.githubusercontent.com/u/713611?v=2","gravatar_id":"0ea188b063e94686a1dbb485e590e9f3","url":"https://api.github.com/users/SciLifeLab","html_url":"https://github.com/SciLifeLab","followers_url":"https://api.github.com/users/SciLifeLab/followers","following_url":"https://api.github.com/users/SciLifeLab/following{/other_user}","gists_url":"https://api.github.com/users/SciLifeLab/gists{/gist_id}","starred_url":"https://api.github.com/users/SciLifeLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciLifeLab/subscriptions","organizations_url":"https://api.github.com/users/SciLifeLab/orgs","repos_url":"https://api.github.com/users/SciLifeLab/repos","events_url":"https://api.github.com/users/SciLifeLab/events{/privacy}","received_events_url":"https://api.github.com/users/SciLifeLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciLifeLab/scilifelab","description":"Misc code snippets for Science For Life Laboratory","fork":true,"url":"https://api.github.com/repos/SciLifeLab/scilifelab","forks_url":"https://api.github.com/repos/SciLifeLab/scilifelab/forks","keys_url":"https://api.github.com/repos/SciLifeLab/scilifelab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciLifeLab/scilifelab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciLifeLab/scilifelab/teams","hooks_url":"https://api.github.com/repos/SciLifeLab/scilifelab/hooks","issue_events_url":"https://api.github.com/repos/SciLifeLab/scilifelab/issues/events{/number}","events_url":"https://api.github.com/repos/SciLifeLab/scilifelab/events","assignees_url":"https://api.github.com/repos/SciLifeLab/scilifelab/assignees{/user}","branches_url":"https://api.github.com/repos/SciLifeLab/scilifelab/branches{/branch}","tags_url":"https://api.github.com/repos/SciLifeLab/scilifelab/tags","blobs_url":"https://api.github.com/repos/SciLifeLab/scilifelab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciLifeLab/scilifelab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciLifeLab/scilifelab/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciLifeLab/scilifelab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciLifeLab/scilifelab/statuses/{sha}","languages_url":"https://api.github.com/repos/SciLifeLab/scilifelab/languages","stargazers_url":"https://api.github.com/repos/SciLifeLab/scilifelab/stargazers","contributors_url":"https://api.github.com/repos/SciLifeLab/scilifelab/contributors","subscribers_url":"https://api.github.com/repos/SciLifeLab/scilifelab/subscribers","subscription_url":"https://api.github.com/repos/SciLifeLab/scilifelab/subscription","commits_url":"https://api.github.com/repos/SciLifeLab/scilifelab/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciLifeLab/scilifelab/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciLifeLab/scilifelab/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciLifeLab/scilifelab/issues/comments/{number}","contents_url":"https://api.github.com/repos/SciLifeLab/scilifelab/contents/{+path}","compare_url":"https://api.github.com/repos/SciLifeLab/scilifelab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciLifeLab/scilifelab/merges","archive_url":"https://api.github.com/repos/SciLifeLab/scilifelab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciLifeLab/scilifelab/downloads","issues_url":"https://api.github.com/repos/SciLifeLab/scilifelab/issues{/number}","pulls_url":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls{/number}","milestones_url":"https://api.github.com/repos/SciLifeLab/scilifelab/milestones{/number}","notifications_url":"https://api.github.com/repos/SciLifeLab/scilifelab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciLifeLab/scilifelab/labels{/name}","releases_url":"https://api.github.com/repos/SciLifeLab/scilifelab/releases{/id}","created_at":"2012-04-12T07:58:18Z","updated_at":"2014-07-29T00:28:03Z","pushed_at":"2014-08-25T08:23:28Z","git_url":"git://github.com/SciLifeLab/scilifelab.git","ssh_url":"git@github.com:SciLifeLab/scilifelab.git","clone_url":"https://github.com/SciLifeLab/scilifelab.git","svn_url":"https://github.com/SciLifeLab/scilifelab","homepage":"http://www.scilifelab.se","size":11817,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":15,"mirror_url":null,"open_issues_count":18,"forks":15,"open_issues":18,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls/410"},"html":{"href":"https://github.com/SciLifeLab/scilifelab/pull/410"},"issue":{"href":"https://api.github.com/repos/SciLifeLab/scilifelab/issues/410"},"comments":{"href":"https://api.github.com/repos/SciLifeLab/scilifelab/issues/410/comments"},"review_comments":{"href":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls/410/comments"},"review_comment":{"href":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SciLifeLab/scilifelab/pulls/410/commits"},"statuses":{"href":"https://api.github.com/repos/SciLifeLab/scilifelab/statuses/0af08ece606ca2e479f9433baef276ccd3fbb063"}}}}