GitHub PullRequestReviewCommentEvent at 2014-06-30 13:22:06
Repository: helios
Actor: drewcsillag
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/spotify/helios/pulls/comments/14349188","id":14349188,"diff_hunk":"@@ -89,6 +92,7 @@ private Job(final JobId id, final Builder.Parameters p) {\n     this.ports = ImmutableMap.copyOf(checkNotNull(p.ports, \"ports\"));\n     this.registration = ImmutableMap.copyOf(checkNotNull(p.registration, \"registration\"));\n     this.volumes = ImmutableMap.copyOf(checkNotNull(p.volumes, \"volumes\"));\n+    this.registrationDomain = checkNotNull(p.registrationDomain);","path":"helios-client/src/main/java/com/spotify/helios/common/descriptors/Job.java","position":30,"original_position":30,"commit_id":"e6fe0a2578c7fbb3d0432457e80365d46bd48f91","original_commit_id":"e6fe0a2578c7fbb3d0432457e80365d46bd48f91","user":{"login":"drewcsillag","id":5121910,"avatar_url":"https://avatars.githubusercontent.com/u/5121910?","gravatar_id":"5fe2bae2bf319b2e9508a3505ce815bb","url":"https://api.github.com/users/drewcsillag","html_url":"https://github.com/drewcsillag","followers_url":"https://api.github.com/users/drewcsillag/followers","following_url":"https://api.github.com/users/drewcsillag/following{/other_user}","gists_url":"https://api.github.com/users/drewcsillag/gists{/gist_id}","starred_url":"https://api.github.com/users/drewcsillag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewcsillag/subscriptions","organizations_url":"https://api.github.com/users/drewcsillag/orgs","repos_url":"https://api.github.com/users/drewcsillag/repos","events_url":"https://api.github.com/users/drewcsillag/events{/privacy}","received_events_url":"https://api.github.com/users/drewcsillag/received_events","type":"User","site_admin":false},"body":"Really not a fan of using nulls when String already has a good value meaning empty.","created_at":"2014-06-30T13:22:06Z","updated_at":"2014-06-30T13:22:06Z","html_url":"https://github.com/spotify/helios/pull/49#discussion_r14349188","pull_request_url":"https://api.github.com/repos/spotify/helios/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/spotify/helios/pulls/comments/14349188"},"html":{"href":"https://github.com/spotify/helios/pull/49#discussion_r14349188"},"pull_request":{"href":"https://api.github.com/repos/spotify/helios/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/spotify/helios/pulls/49","id":17722686,"html_url":"https://github.com/spotify/helios/pull/49","diff_url":"https://github.com/spotify/helios/pull/49.diff","patch_url":"https://github.com/spotify/helios/pull/49.patch","issue_url":"https://api.github.com/repos/spotify/helios/issues/49","number":49,"state":"open","title":"Provide more data in endpoint so registrars will have all they need.","user":{"login":"drewcsillag","id":5121910,"avatar_url":"https://avatars.githubusercontent.com/u/5121910?","gravatar_id":"5fe2bae2bf319b2e9508a3505ce815bb","url":"https://api.github.com/users/drewcsillag","html_url":"https://github.com/drewcsillag","followers_url":"https://api.github.com/users/drewcsillag/followers","following_url":"https://api.github.com/users/drewcsillag/following{/other_user}","gists_url":"https://api.github.com/users/drewcsillag/gists{/gist_id}","starred_url":"https://api.github.com/users/drewcsillag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewcsillag/subscriptions","organizations_url":"https://api.github.com/users/drewcsillag/orgs","repos_url":"https://api.github.com/users/drewcsillag/repos","events_url":"https://api.github.com/users/drewcsillag/events{/privacy}","received_events_url":"https://api.github.com/users/drewcsillag/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-27T19:56:38Z","updated_at":"2014-06-30T13:22:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfc26e08047a2b0b4c1e747a74f1b7a46fed5310","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spotify/helios/pulls/49/commits","review_comments_url":"https://api.github.com/repos/spotify/helios/pulls/49/comments","review_comment_url":"https://api.github.com/repos/spotify/helios/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spotify/helios/issues/49/comments","statuses_url":"https://api.github.com/repos/spotify/helios/statuses/e6fe0a2578c7fbb3d0432457e80365d46bd48f91","head":{"label":"spotify:drewc/provide-more-endpoint-info","ref":"drewc/provide-more-endpoint-info","sha":"e6fe0a2578c7fbb3d0432457e80365d46bd48f91","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?","gravatar_id":"5cf163ec5f3a5fb1b825272957081c31","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":20171642,"name":"helios","full_name":"spotify/helios","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?","gravatar_id":"5cf163ec5f3a5fb1b825272957081c31","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/helios","description":"Docker container orchestration platform","fork":false,"url":"https://api.github.com/repos/spotify/helios","forks_url":"https://api.github.com/repos/spotify/helios/forks","keys_url":"https://api.github.com/repos/spotify/helios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/helios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/helios/teams","hooks_url":"https://api.github.com/repos/spotify/helios/hooks","issue_events_url":"https://api.github.com/repos/spotify/helios/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/helios/events","assignees_url":"https://api.github.com/repos/spotify/helios/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/helios/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/helios/tags","blobs_url":"https://api.github.com/repos/spotify/helios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/helios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/helios/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/helios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/helios/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/helios/languages","stargazers_url":"https://api.github.com/repos/spotify/helios/stargazers","contributors_url":"https://api.github.com/repos/spotify/helios/contributors","subscribers_url":"https://api.github.com/repos/spotify/helios/subscribers","subscription_url":"https://api.github.com/repos/spotify/helios/subscription","commits_url":"https://api.github.com/repos/spotify/helios/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/helios/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/helios/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/helios/issues/comments/{number}","contents_url":"https://api.github.com/repos/spotify/helios/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/helios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/helios/merges","archive_url":"https://api.github.com/repos/spotify/helios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/helios/downloads","issues_url":"https://api.github.com/repos/spotify/helios/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/helios/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/helios/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/helios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/helios/labels{/name}","releases_url":"https://api.github.com/repos/spotify/helios/releases{/id}","created_at":"2014-05-26T02:29:06Z","updated_at":"2014-06-30T03:26:41Z","pushed_at":"2014-06-28T02:37:09Z","git_url":"git://github.com/spotify/helios.git","ssh_url":"git@github.com:spotify/helios.git","clone_url":"https://github.com/spotify/helios.git","svn_url":"https://github.com/spotify/helios","homepage":null,"size":5041,"stargazers_count":168,"watchers_count":168,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":9,"forks":8,"open_issues":9,"watchers":168,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"2b1578164a3be56a629b964dfb4948ef8fa1dcf1","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?","gravatar_id":"5cf163ec5f3a5fb1b825272957081c31","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":20171642,"name":"helios","full_name":"spotify/helios","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?","gravatar_id":"5cf163ec5f3a5fb1b825272957081c31","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/helios","description":"Docker container orchestration platform","fork":false,"url":"https://api.github.com/repos/spotify/helios","forks_url":"https://api.github.com/repos/spotify/helios/forks","keys_url":"https://api.github.com/repos/spotify/helios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/helios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/helios/teams","hooks_url":"https://api.github.com/repos/spotify/helios/hooks","issue_events_url":"https://api.github.com/repos/spotify/helios/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/helios/events","assignees_url":"https://api.github.com/repos/spotify/helios/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/helios/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/helios/tags","blobs_url":"https://api.github.com/repos/spotify/helios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/helios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/helios/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/helios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/helios/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/helios/languages","stargazers_url":"https://api.github.com/repos/spotify/helios/stargazers","contributors_url":"https://api.github.com/repos/spotify/helios/contributors","subscribers_url":"https://api.github.com/repos/spotify/helios/subscribers","subscription_url":"https://api.github.com/repos/spotify/helios/subscription","commits_url":"https://api.github.com/repos/spotify/helios/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/helios/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/helios/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/helios/issues/comments/{number}","contents_url":"https://api.github.com/repos/spotify/helios/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/helios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/helios/merges","archive_url":"https://api.github.com/repos/spotify/helios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/helios/downloads","issues_url":"https://api.github.com/repos/spotify/helios/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/helios/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/helios/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/helios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/helios/labels{/name}","releases_url":"https://api.github.com/repos/spotify/helios/releases{/id}","created_at":"2014-05-26T02:29:06Z","updated_at":"2014-06-30T03:26:41Z","pushed_at":"2014-06-28T02:37:09Z","git_url":"git://github.com/spotify/helios.git","ssh_url":"git@github.com:spotify/helios.git","clone_url":"https://github.com/spotify/helios.git","svn_url":"https://github.com/spotify/helios","homepage":null,"size":5041,"stargazers_count":168,"watchers_count":168,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":9,"forks":8,"open_issues":9,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/helios/pulls/49"},"html":{"href":"https://github.com/spotify/helios/pull/49"},"issue":{"href":"https://api.github.com/repos/spotify/helios/issues/49"},"comments":{"href":"https://api.github.com/repos/spotify/helios/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/helios/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/helios/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spotify/helios/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/helios/statuses/e6fe0a2578c7fbb3d0432457e80365d46bd48f91"}}}}