GitHub PullRequestReviewCommentEvent at 2014-12-16 18:51:45
Repository: rocket
Actor: jonboulle
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rocket/pulls/comments/21921553","id":21921553,"diff_hunk":"@@ -59,6 +61,31 @@ func (ds Store) tmpFile() (*os.File, error) {\n \treturn ioutil.TempFile(dir, \"\")\n }\n \n+// ResolveKey resolves a key of prefixed format sha512-0c45e8c0ab2 to a full key\n+// by using the cas store for resolution.\n+//\n+// If the key is already of proper length, just returns the key.\n+func (ds Store) ResolveKey(keyPrefix string) (string, error) {\n+\tif strings.HasPrefix(keyPrefix, \"sha512-\") && len(keyPrefix) == 128+7 {","path":"cas/cas.go","position":25,"original_position":25,"commit_id":"5f0ae8d8b780ed323fd4347903793f0815972888","original_commit_id":"5f0ae8d8b780ed323fd4347903793f0815972888","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":"Would you mind pulling out `sha512-` and 128 as consts?","created_at":"2014-12-16T18:51:45Z","updated_at":"2014-12-16T18:51:45Z","html_url":"https://github.com/coreos/rocket/pull/209#discussion_r21921553","pull_request_url":"https://api.github.com/repos/coreos/rocket/pulls/209","_links":{"self":{"href":"https://api.github.com/repos/coreos/rocket/pulls/comments/21921553"},"html":{"href":"https://github.com/coreos/rocket/pull/209#discussion_r21921553"},"pull_request":{"href":"https://api.github.com/repos/coreos/rocket/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rocket/pulls/209","id":25511085,"html_url":"https://github.com/coreos/rocket/pull/209","diff_url":"https://github.com/coreos/rocket/pull/209.diff","patch_url":"https://github.com/coreos/rocket/pull/209.patch","issue_url":"https://api.github.com/repos/coreos/rocket/issues/209","number":209,"state":"open","locked":false,"title":"*: Using sha512 instead of sha256","user":{"login":"rckclmbr","id":95075,"avatar_url":"https://avatars.githubusercontent.com/u/95075?v=3","gravatar_id":"","url":"https://api.github.com/users/rckclmbr","html_url":"https://github.com/rckclmbr","followers_url":"https://api.github.com/users/rckclmbr/followers","following_url":"https://api.github.com/users/rckclmbr/following{/other_user}","gists_url":"https://api.github.com/users/rckclmbr/gists{/gist_id}","starred_url":"https://api.github.com/users/rckclmbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rckclmbr/subscriptions","organizations_url":"https://api.github.com/users/rckclmbr/orgs","repos_url":"https://api.github.com/users/rckclmbr/repos","events_url":"https://api.github.com/users/rckclmbr/events{/privacy}","received_events_url":"https://api.github.com/users/rckclmbr/received_events","type":"User","site_admin":false},"body":"sha512 is faster on 64bit systems than sha256, so prefer it over sha256\r\n\r\nfixes #187 ","created_at":"2014-12-04T16:59:58Z","updated_at":"2014-12-16T18:51:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"947e02b58eddbb14511819fd0122e13517dbe68d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/rocket/pulls/209/commits","review_comments_url":"https://api.github.com/repos/coreos/rocket/pulls/209/comments","review_comment_url":"https://api.github.com/repos/coreos/rocket/pulls/comments/{number}","comments_url":"https://api.github.com/repos/coreos/rocket/issues/209/comments","statuses_url":"https://api.github.com/repos/coreos/rocket/statuses/5f0ae8d8b780ed323fd4347903793f0815972888","head":{"label":"rckclmbr:sha512","ref":"sha512","sha":"5f0ae8d8b780ed323fd4347903793f0815972888","user":{"login":"rckclmbr","id":95075,"avatar_url":"https://avatars.githubusercontent.com/u/95075?v=3","gravatar_id":"","url":"https://api.github.com/users/rckclmbr","html_url":"https://github.com/rckclmbr","followers_url":"https://api.github.com/users/rckclmbr/followers","following_url":"https://api.github.com/users/rckclmbr/following{/other_user}","gists_url":"https://api.github.com/users/rckclmbr/gists{/gist_id}","starred_url":"https://api.github.com/users/rckclmbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rckclmbr/subscriptions","organizations_url":"https://api.github.com/users/rckclmbr/orgs","repos_url":"https://api.github.com/users/rckclmbr/repos","events_url":"https://api.github.com/users/rckclmbr/events{/privacy}","received_events_url":"https://api.github.com/users/rckclmbr/received_events","type":"User","site_admin":false},"repo":{"id":27550445,"name":"rocket","full_name":"rckclmbr/rocket","owner":{"login":"rckclmbr","id":95075,"avatar_url":"https://avatars.githubusercontent.com/u/95075?v=3","gravatar_id":"","url":"https://api.github.com/users/rckclmbr","html_url":"https://github.com/rckclmbr","followers_url":"https://api.github.com/users/rckclmbr/followers","following_url":"https://api.github.com/users/rckclmbr/following{/other_user}","gists_url":"https://api.github.com/users/rckclmbr/gists{/gist_id}","starred_url":"https://api.github.com/users/rckclmbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rckclmbr/subscriptions","organizations_url":"https://api.github.com/users/rckclmbr/orgs","repos_url":"https://api.github.com/users/rckclmbr/repos","events_url":"https://api.github.com/users/rckclmbr/events{/privacy}","received_events_url":"https://api.github.com/users/rckclmbr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rckclmbr/rocket","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/rckclmbr/rocket","forks_url":"https://api.github.com/repos/rckclmbr/rocket/forks","keys_url":"https://api.github.com/repos/rckclmbr/rocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rckclmbr/rocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rckclmbr/rocket/teams","hooks_url":"https://api.github.com/repos/rckclmbr/rocket/hooks","issue_events_url":"https://api.github.com/repos/rckclmbr/rocket/issues/events{/number}","events_url":"https://api.github.com/repos/rckclmbr/rocket/events","assignees_url":"https://api.github.com/repos/rckclmbr/rocket/assignees{/user}","branches_url":"https://api.github.com/repos/rckclmbr/rocket/branches{/branch}","tags_url":"https://api.github.com/repos/rckclmbr/rocket/tags","blobs_url":"https://api.github.com/repos/rckclmbr/rocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rckclmbr/rocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rckclmbr/rocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/rckclmbr/rocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rckclmbr/rocket/statuses/{sha}","languages_url":"https://api.github.com/repos/rckclmbr/rocket/languages","stargazers_url":"https://api.github.com/repos/rckclmbr/rocket/stargazers","contributors_url":"https://api.github.com/repos/rckclmbr/rocket/contributors","subscribers_url":"https://api.github.com/repos/rckclmbr/rocket/subscribers","subscription_url":"https://api.github.com/repos/rckclmbr/rocket/subscription","commits_url":"https://api.github.com/repos/rckclmbr/rocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/rckclmbr/rocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/rckclmbr/rocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/rckclmbr/rocket/issues/comments/{number}","contents_url":"https://api.github.com/repos/rckclmbr/rocket/contents/{+path}","compare_url":"https://api.github.com/repos/rckclmbr/rocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rckclmbr/rocket/merges","archive_url":"https://api.github.com/repos/rckclmbr/rocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rckclmbr/rocket/downloads","issues_url":"https://api.github.com/repos/rckclmbr/rocket/issues{/number}","pulls_url":"https://api.github.com/repos/rckclmbr/rocket/pulls{/number}","milestones_url":"https://api.github.com/repos/rckclmbr/rocket/milestones{/number}","notifications_url":"https://api.github.com/repos/rckclmbr/rocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rckclmbr/rocket/labels{/name}","releases_url":"https://api.github.com/repos/rckclmbr/rocket/releases{/id}","created_at":"2014-12-04T16:57:38Z","updated_at":"2014-12-08T16:43:29Z","pushed_at":"2014-12-15T22:28:37Z","git_url":"git://github.com/rckclmbr/rocket.git","ssh_url":"git@github.com:rckclmbr/rocket.git","clone_url":"https://github.com/rckclmbr/rocket.git","svn_url":"https://github.com/rckclmbr/rocket","homepage":"","size":938,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"51ee32725adc093493e818b3c8ee697db3f22f62","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rocket","full_name":"coreos/rocket","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rocket","description":"App Container runtime","fork":false,"url":"https://api.github.com/repos/coreos/rocket","forks_url":"https://api.github.com/repos/coreos/rocket/forks","keys_url":"https://api.github.com/repos/coreos/rocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rocket/teams","hooks_url":"https://api.github.com/repos/coreos/rocket/hooks","issue_events_url":"https://api.github.com/repos/coreos/rocket/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rocket/events","assignees_url":"https://api.github.com/repos/coreos/rocket/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rocket/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rocket/tags","blobs_url":"https://api.github.com/repos/coreos/rocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rocket/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rocket/languages","stargazers_url":"https://api.github.com/repos/coreos/rocket/stargazers","contributors_url":"https://api.github.com/repos/coreos/rocket/contributors","subscribers_url":"https://api.github.com/repos/coreos/rocket/subscribers","subscription_url":"https://api.github.com/repos/coreos/rocket/subscription","commits_url":"https://api.github.com/repos/coreos/rocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rocket/issues/comments/{number}","contents_url":"https://api.github.com/repos/coreos/rocket/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rocket/merges","archive_url":"https://api.github.com/repos/coreos/rocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rocket/downloads","issues_url":"https://api.github.com/repos/coreos/rocket/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rocket/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rocket/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rocket/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rocket/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2014-12-16T12:35:06Z","pushed_at":"2014-12-15T21:11:18Z","git_url":"git://github.com/coreos/rocket.git","ssh_url":"git@github.com:coreos/rocket.git","clone_url":"https://github.com/coreos/rocket.git","svn_url":"https://github.com/coreos/rocket","homepage":"","size":3090,"stargazers_count":2868,"watchers_count":2868,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":184,"mirror_url":null,"open_issues_count":43,"forks":184,"open_issues":43,"watchers":2868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rocket/pulls/209"},"html":{"href":"https://github.com/coreos/rocket/pull/209"},"issue":{"href":"https://api.github.com/repos/coreos/rocket/issues/209"},"comments":{"href":"https://api.github.com/repos/coreos/rocket/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rocket/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rocket/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/coreos/rocket/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rocket/statuses/5f0ae8d8b780ed323fd4347903793f0815972888"}}}}