GitHub PullRequestReviewCommentEvent at 2014-11-28 12:36:47
Repository: firefoxos-loop-client
Actor: borjasalguero
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/21029279","id":21029279,"diff_hunk":"@@ -43,17 +48,35 @@\n       if (window.RoomCreate) {\n         return Promise.resolve(RoomCreate);\n       }\n-\n       return new Promise((resolve, reject) => {\n-        LazyLoader.load(\n-          [\n-            'style/create_room.css',\n-            'js/screens/create_room.js'\n-          ],\n-          () => {\n-            resolve(RoomCreate);\n-          }\n-        );\n+       // Shield against multiple requests\n+        if (document.querySelector('#' + PANELS_ID.feedback)) {\n+          return;","path":"app/js/helpers/loader.js","position":35,"original_position":35,"commit_id":"595c64619d39dadbc8e9443a605ac1eadafcc0ed","original_commit_id":"595c64619d39dadbc8e9443a605ac1eadafcc0ed","user":{"login":"borjasalguero","id":1785537,"avatar_url":"https://avatars.githubusercontent.com/u/1785537?v=3","gravatar_id":"","url":"https://api.github.com/users/borjasalguero","html_url":"https://github.com/borjasalguero","followers_url":"https://api.github.com/users/borjasalguero/followers","following_url":"https://api.github.com/users/borjasalguero/following{/other_user}","gists_url":"https://api.github.com/users/borjasalguero/gists{/gist_id}","starred_url":"https://api.github.com/users/borjasalguero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borjasalguero/subscriptions","organizations_url":"https://api.github.com/users/borjasalguero/orgs","repos_url":"https://api.github.com/users/borjasalguero/repos","events_url":"https://api.github.com/users/borjasalguero/events{/privacy}","received_events_url":"https://api.github.com/users/borjasalguero/received_events","type":"User","site_admin":false},"body":"Fixing!","created_at":"2014-11-28T12:36:47Z","updated_at":"2014-11-28T12:36:47Z","html_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/338#discussion_r21029279","pull_request_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/338","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/21029279"},"html":{"href":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/338#discussion_r21029279"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/338"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/338","id":25170204,"html_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/338","diff_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/338.diff","patch_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/338.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/338","number":338,"state":"open","locked":false,"title":"Bug 1104731 - [Rooms] Move 'feedback' screen code to a reusable componen...","user":{"login":"borjasalguero","id":1785537,"avatar_url":"https://avatars.githubusercontent.com/u/1785537?v=3","gravatar_id":"","url":"https://api.github.com/users/borjasalguero","html_url":"https://github.com/borjasalguero","followers_url":"https://api.github.com/users/borjasalguero/followers","following_url":"https://api.github.com/users/borjasalguero/following{/other_user}","gists_url":"https://api.github.com/users/borjasalguero/gists{/gist_id}","starred_url":"https://api.github.com/users/borjasalguero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borjasalguero/subscriptions","organizations_url":"https://api.github.com/users/borjasalguero/orgs","repos_url":"https://api.github.com/users/borjasalguero/repos","events_url":"https://api.github.com/users/borjasalguero/events{/privacy}","received_events_url":"https://api.github.com/users/borjasalguero/received_events","type":"User","site_admin":false},"body":"...t r=crdlc","created_at":"2014-11-27T21:34:50Z","updated_at":"2014-11-28T12:36:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a00d95855c22b473c6b2d6d32b3c3cf4bd2a476","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/338/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/338/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/338/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/statuses/595c64619d39dadbc8e9443a605ac1eadafcc0ed","head":{"label":"borjasalguero:separate_feedback","ref":"separate_feedback","sha":"595c64619d39dadbc8e9443a605ac1eadafcc0ed","user":{"login":"borjasalguero","id":1785537,"avatar_url":"https://avatars.githubusercontent.com/u/1785537?v=3","gravatar_id":"","url":"https://api.github.com/users/borjasalguero","html_url":"https://github.com/borjasalguero","followers_url":"https://api.github.com/users/borjasalguero/followers","following_url":"https://api.github.com/users/borjasalguero/following{/other_user}","gists_url":"https://api.github.com/users/borjasalguero/gists{/gist_id}","starred_url":"https://api.github.com/users/borjasalguero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borjasalguero/subscriptions","organizations_url":"https://api.github.com/users/borjasalguero/orgs","repos_url":"https://api.github.com/users/borjasalguero/repos","events_url":"https://api.github.com/users/borjasalguero/events{/privacy}","received_events_url":"https://api.github.com/users/borjasalguero/received_events","type":"User","site_admin":false},"repo":{"id":18328104,"name":"firefoxos-loop-client","full_name":"borjasalguero/firefoxos-loop-client","owner":{"login":"borjasalguero","id":1785537,"avatar_url":"https://avatars.githubusercontent.com/u/1785537?v=3","gravatar_id":"","url":"https://api.github.com/users/borjasalguero","html_url":"https://github.com/borjasalguero","followers_url":"https://api.github.com/users/borjasalguero/followers","following_url":"https://api.github.com/users/borjasalguero/following{/other_user}","gists_url":"https://api.github.com/users/borjasalguero/gists{/gist_id}","starred_url":"https://api.github.com/users/borjasalguero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borjasalguero/subscriptions","organizations_url":"https://api.github.com/users/borjasalguero/orgs","repos_url":"https://api.github.com/users/borjasalguero/repos","events_url":"https://api.github.com/users/borjasalguero/events{/privacy}","received_events_url":"https://api.github.com/users/borjasalguero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/borjasalguero/firefoxos-loop-client","description":"Firefox OS client for the Loop service","fork":true,"url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client","forks_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/forks","keys_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/teams","hooks_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/hooks","issue_events_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/issues/events{/number}","events_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/events","assignees_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/assignees{/user}","branches_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/branches{/branch}","tags_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/tags","blobs_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/statuses/{sha}","languages_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/languages","stargazers_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/stargazers","contributors_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/contributors","subscribers_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/subscribers","subscription_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/subscription","commits_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/contents/{+path}","compare_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/merges","archive_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/downloads","issues_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/issues{/number}","pulls_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/pulls{/number}","milestones_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/milestones{/number}","notifications_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/labels{/name}","releases_url":"https://api.github.com/repos/borjasalguero/firefoxos-loop-client/releases{/id}","created_at":"2014-04-01T12:06:56Z","updated_at":"2014-06-20T08:48:04Z","pushed_at":"2014-11-28T11:39:02Z","git_url":"git://github.com/borjasalguero/firefoxos-loop-client.git","ssh_url":"git@github.com:borjasalguero/firefoxos-loop-client.git","clone_url":"https://github.com/borjasalguero/firefoxos-loop-client.git","svn_url":"https://github.com/borjasalguero/firefoxos-loop-client","homepage":null,"size":11631,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"fe0b50f39e6d0680ec7a705c5a93bebc1e0ba8ff","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":18225071,"name":"firefoxos-loop-client","full_name":"mozilla-b2g/firefoxos-loop-client","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/firefoxos-loop-client","description":"Firefox OS client for the Loop service","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client","forks_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/releases{/id}","created_at":"2014-03-28T20:10:24Z","updated_at":"2014-11-27T15:05:56Z","pushed_at":"2014-11-27T15:05:56Z","git_url":"git://github.com/mozilla-b2g/firefoxos-loop-client.git","ssh_url":"git@github.com:mozilla-b2g/firefoxos-loop-client.git","clone_url":"https://github.com/mozilla-b2g/firefoxos-loop-client.git","svn_url":"https://github.com/mozilla-b2g/firefoxos-loop-client","homepage":null,"size":15540,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":28,"forks":36,"open_issues":28,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/338"},"html":{"href":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/338"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/338"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/statuses/595c64619d39dadbc8e9443a605ac1eadafcc0ed"}}}}