GitHub PullRequestEvent at 2014-01-03 00:56:35
Repository: idiorm
Actor: lrlopez
Payload: {"action":"opened","number":171,"pull_request":{"url":"https://api.github.com/repos/j4mie/idiorm/pulls/171","id":11197636,"html_url":"https://github.com/j4mie/idiorm/pull/171","diff_url":"https://github.com/j4mie/idiorm/pull/171.diff","patch_url":"https://github.com/j4mie/idiorm/pull/171.patch","issue_url":"https://github.com/j4mie/idiorm/pull/171","number":171,"state":"open","title":"Compound primary keys support (revisited!) ","user":{"login":"lrlopez","id":547387,"avatar_url":"https://gravatar.com/avatar/fdfb163830daf75a4c6de2af2cb5acc8?d=https%3A%2F%2Fidenticons.github.com%2Fdc7d351ee9fd104076265448a63d1765.png&r=x","gravatar_id":"fdfb163830daf75a4c6de2af2cb5acc8","url":"https://api.github.com/users/lrlopez","html_url":"https://github.com/lrlopez","followers_url":"https://api.github.com/users/lrlopez/followers","following_url":"https://api.github.com/users/lrlopez/following{/other_user}","gists_url":"https://api.github.com/users/lrlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/lrlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrlopez/subscriptions","organizations_url":"https://api.github.com/users/lrlopez/orgs","repos_url":"https://api.github.com/users/lrlopez/repos","events_url":"https://api.github.com/users/lrlopez/events{/privacy}","received_events_url":"https://api.github.com/users/lrlopez/received_events","type":"User","site_admin":false},"body":"This PR adds support for compound primary keys. It is fully backward compatible with one column primary keys tables and also works with Paris (although I recommend a deeper compatibility test).\r\n\r\nAs a side-effect, I've enhanced `where_*()` and `having_*()` methods to allow stating multiple column-names/values at once (is needed for the compound keys support).\r\n\r\nAll the changes are documented and I've also thrown in some tests (beware: I only test that SQL queries are built the right way).\r\n\r\nI've splitted the PR into several commits, but I could squash them into one big commit if this gets merged in order to not pollute the history.\r\n\r\nCloses https://github.com/j4mie/idiorm/pull/161","created_at":"2014-01-03T00:56:34Z","updated_at":"2014-01-03T00:56:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://github.com/j4mie/idiorm/pull/171/commits","review_comments_url":"https://github.com/j4mie/idiorm/pull/171/comments","review_comment_url":"/repos/j4mie/idiorm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/j4mie/idiorm/issues/171/comments","statuses_url":"https://api.github.com/repos/j4mie/idiorm/statuses/430b0b1e5eda948ad436a7bf307b7ebd99c425b1","head":{"label":"lrlopez:compound-keys","ref":"compound-keys","sha":"430b0b1e5eda948ad436a7bf307b7ebd99c425b1","user":{"login":"lrlopez","id":547387,"avatar_url":"https://gravatar.com/avatar/fdfb163830daf75a4c6de2af2cb5acc8?d=https%3A%2F%2Fidenticons.github.com%2Fdc7d351ee9fd104076265448a63d1765.png&r=x","gravatar_id":"fdfb163830daf75a4c6de2af2cb5acc8","url":"https://api.github.com/users/lrlopez","html_url":"https://github.com/lrlopez","followers_url":"https://api.github.com/users/lrlopez/followers","following_url":"https://api.github.com/users/lrlopez/following{/other_user}","gists_url":"https://api.github.com/users/lrlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/lrlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrlopez/subscriptions","organizations_url":"https://api.github.com/users/lrlopez/orgs","repos_url":"https://api.github.com/users/lrlopez/repos","events_url":"https://api.github.com/users/lrlopez/events{/privacy}","received_events_url":"https://api.github.com/users/lrlopez/received_events","type":"User","site_admin":false},"repo":{"id":13366732,"name":"idiorm","full_name":"lrlopez/idiorm","owner":{"login":"lrlopez","id":547387,"avatar_url":"https://gravatar.com/avatar/fdfb163830daf75a4c6de2af2cb5acc8?d=https%3A%2F%2Fidenticons.github.com%2Fdc7d351ee9fd104076265448a63d1765.png&r=x","gravatar_id":"fdfb163830daf75a4c6de2af2cb5acc8","url":"https://api.github.com/users/lrlopez","html_url":"https://github.com/lrlopez","followers_url":"https://api.github.com/users/lrlopez/followers","following_url":"https://api.github.com/users/lrlopez/following{/other_user}","gists_url":"https://api.github.com/users/lrlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/lrlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrlopez/subscriptions","organizations_url":"https://api.github.com/users/lrlopez/orgs","repos_url":"https://api.github.com/users/lrlopez/repos","events_url":"https://api.github.com/users/lrlopez/events{/privacy}","received_events_url":"https://api.github.com/users/lrlopez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lrlopez/idiorm","description":"A lightweight nearly-zero-configuration object-relational mapper and fluent query builder for PHP5.","fork":true,"url":"https://api.github.com/repos/lrlopez/idiorm","forks_url":"https://api.github.com/repos/lrlopez/idiorm/forks","keys_url":"https://api.github.com/repos/lrlopez/idiorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lrlopez/idiorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lrlopez/idiorm/teams","hooks_url":"https://api.github.com/repos/lrlopez/idiorm/hooks","issue_events_url":"https://api.github.com/repos/lrlopez/idiorm/issues/events{/number}","events_url":"https://api.github.com/repos/lrlopez/idiorm/events","assignees_url":"https://api.github.com/repos/lrlopez/idiorm/assignees{/user}","branches_url":"https://api.github.com/repos/lrlopez/idiorm/branches{/branch}","tags_url":"https://api.github.com/repos/lrlopez/idiorm/tags","blobs_url":"https://api.github.com/repos/lrlopez/idiorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lrlopez/idiorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lrlopez/idiorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/lrlopez/idiorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lrlopez/idiorm/statuses/{sha}","languages_url":"https://api.github.com/repos/lrlopez/idiorm/languages","stargazers_url":"https://api.github.com/repos/lrlopez/idiorm/stargazers","contributors_url":"https://api.github.com/repos/lrlopez/idiorm/contributors","subscribers_url":"https://api.github.com/repos/lrlopez/idiorm/subscribers","subscription_url":"https://api.github.com/repos/lrlopez/idiorm/subscription","commits_url":"https://api.github.com/repos/lrlopez/idiorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/lrlopez/idiorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/lrlopez/idiorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/lrlopez/idiorm/issues/comments/{number}","contents_url":"https://api.github.com/repos/lrlopez/idiorm/contents/{+path}","compare_url":"https://api.github.com/repos/lrlopez/idiorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lrlopez/idiorm/merges","archive_url":"https://api.github.com/repos/lrlopez/idiorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lrlopez/idiorm/downloads","issues_url":"https://api.github.com/repos/lrlopez/idiorm/issues{/number}","pulls_url":"https://api.github.com/repos/lrlopez/idiorm/pulls{/number}","milestones_url":"https://api.github.com/repos/lrlopez/idiorm/milestones{/number}","notifications_url":"https://api.github.com/repos/lrlopez/idiorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lrlopez/idiorm/labels{/name}","releases_url":"https://api.github.com/repos/lrlopez/idiorm/releases{/id}","created_at":"2013-10-06T18:19:39Z","updated_at":"2014-01-03T00:56:34Z","pushed_at":"2014-01-03T00:51:48Z","git_url":"git://github.com/lrlopez/idiorm.git","ssh_url":"git@github.com:lrlopez/idiorm.git","clone_url":"https://github.com/lrlopez/idiorm.git","svn_url":"https://github.com/lrlopez/idiorm","homepage":"http://j4mie.github.com/idiormandparis/","size":749,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"j4mie:develop","ref":"develop","sha":"0545618c84c2eec2ee49db92cfd9864933cb6711","user":{"login":"j4mie","id":6988,"avatar_url":"https://gravatar.com/avatar/d3377baa721f0f539ddf518c8cef9983?d=https%3A%2F%2Fidenticons.github.com%2F251bd0442dfcc53b5a761e050f8022b8.png&r=x","gravatar_id":"d3377baa721f0f539ddf518c8cef9983","url":"https://api.github.com/users/j4mie","html_url":"https://github.com/j4mie","followers_url":"https://api.github.com/users/j4mie/followers","following_url":"https://api.github.com/users/j4mie/following{/other_user}","gists_url":"https://api.github.com/users/j4mie/gists{/gist_id}","starred_url":"https://api.github.com/users/j4mie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j4mie/subscriptions","organizations_url":"https://api.github.com/users/j4mie/orgs","repos_url":"https://api.github.com/users/j4mie/repos","events_url":"https://api.github.com/users/j4mie/events{/privacy}","received_events_url":"https://api.github.com/users/j4mie/received_events","type":"User","site_admin":false},"repo":{"id":512431,"name":"idiorm","full_name":"j4mie/idiorm","owner":{"login":"j4mie","id":6988,"avatar_url":"https://gravatar.com/avatar/d3377baa721f0f539ddf518c8cef9983?d=https%3A%2F%2Fidenticons.github.com%2F251bd0442dfcc53b5a761e050f8022b8.png&r=x","gravatar_id":"d3377baa721f0f539ddf518c8cef9983","url":"https://api.github.com/users/j4mie","html_url":"https://github.com/j4mie","followers_url":"https://api.github.com/users/j4mie/followers","following_url":"https://api.github.com/users/j4mie/following{/other_user}","gists_url":"https://api.github.com/users/j4mie/gists{/gist_id}","starred_url":"https://api.github.com/users/j4mie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j4mie/subscriptions","organizations_url":"https://api.github.com/users/j4mie/orgs","repos_url":"https://api.github.com/users/j4mie/repos","events_url":"https://api.github.com/users/j4mie/events{/privacy}","received_events_url":"https://api.github.com/users/j4mie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j4mie/idiorm","description":"A lightweight nearly-zero-configuration object-relational mapper and fluent query builder for PHP5.","fork":false,"url":"https://api.github.com/repos/j4mie/idiorm","forks_url":"https://api.github.com/repos/j4mie/idiorm/forks","keys_url":"https://api.github.com/repos/j4mie/idiorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j4mie/idiorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j4mie/idiorm/teams","hooks_url":"https://api.github.com/repos/j4mie/idiorm/hooks","issue_events_url":"https://api.github.com/repos/j4mie/idiorm/issues/events{/number}","events_url":"https://api.github.com/repos/j4mie/idiorm/events","assignees_url":"https://api.github.com/repos/j4mie/idiorm/assignees{/user}","branches_url":"https://api.github.com/repos/j4mie/idiorm/branches{/branch}","tags_url":"https://api.github.com/repos/j4mie/idiorm/tags","blobs_url":"https://api.github.com/repos/j4mie/idiorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j4mie/idiorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j4mie/idiorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/j4mie/idiorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j4mie/idiorm/statuses/{sha}","languages_url":"https://api.github.com/repos/j4mie/idiorm/languages","stargazers_url":"https://api.github.com/repos/j4mie/idiorm/stargazers","contributors_url":"https://api.github.com/repos/j4mie/idiorm/contributors","subscribers_url":"https://api.github.com/repos/j4mie/idiorm/subscribers","subscription_url":"https://api.github.com/repos/j4mie/idiorm/subscription","commits_url":"https://api.github.com/repos/j4mie/idiorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/j4mie/idiorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/j4mie/idiorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/j4mie/idiorm/issues/comments/{number}","contents_url":"https://api.github.com/repos/j4mie/idiorm/contents/{+path}","compare_url":"https://api.github.com/repos/j4mie/idiorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j4mie/idiorm/merges","archive_url":"https://api.github.com/repos/j4mie/idiorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j4mie/idiorm/downloads","issues_url":"https://api.github.com/repos/j4mie/idiorm/issues{/number}","pulls_url":"https://api.github.com/repos/j4mie/idiorm/pulls{/number}","milestones_url":"https://api.github.com/repos/j4mie/idiorm/milestones{/number}","notifications_url":"https://api.github.com/repos/j4mie/idiorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j4mie/idiorm/labels{/name}","releases_url":"https://api.github.com/repos/j4mie/idiorm/releases{/id}","created_at":"2010-02-11T01:34:57Z","updated_at":"2014-01-02T14:42:02Z","pushed_at":"2013-12-26T17:04:24Z","git_url":"git://github.com/j4mie/idiorm.git","ssh_url":"git@github.com:j4mie/idiorm.git","clone_url":"https://github.com/j4mie/idiorm.git","svn_url":"https://github.com/j4mie/idiorm","homepage":"http://j4mie.github.com/idiormandparis/","size":1484,"stargazers_count":1073,"watchers_count":1073,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":213,"mirror_url":null,"open_issues_count":3,"forks":213,"open_issues":3,"watchers":1073,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/j4mie/idiorm/pulls/171"},"html":{"href":"https://github.com/j4mie/idiorm/pull/171"},"issue":{"href":"https://api.github.com/repos/j4mie/idiorm/issues/171"},"comments":{"href":"https://api.github.com/repos/j4mie/idiorm/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/j4mie/idiorm/pulls/171/comments"},"statuses":{"href":"https://api.github.com/repos/j4mie/idiorm/statuses/430b0b1e5eda948ad436a7bf307b7ebd99c425b1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":10,"additions":331,"deletions":71,"changed_files":4}}