GitHub PullRequestReviewCommentEvent at 2014-10-01 16:50:18
Repository: Diagnostics
Actor: davidfowl
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Diagnostics/pulls/comments/18291239","id":18291239,"diff_hunk":"@@ -0,0 +1,15 @@\n+﻿using System;\n+using Microsoft.AspNet.Builder;\n+using Microsoft.AspNet.Diagnostics;\n+using Microsoft.AspNet.Http;\n+\n+namespace RuntimeInfoPageSample\n+{\n+    public class Startup\n+    {\n+        public void Configure(IApplicationBuilder app)\n+        {\n+            app.UseRuntimeInfoPage(new RuntimeInfoPageOptions() { Path = new PathString(null) });","path":"samples/RuntimeInfoPageSample/Startup.cs","position":12,"original_position":12,"commit_id":"0494475424ea60961f3563ce393f3fd491f95c3a","original_commit_id":"0494475424ea60961f3563ce393f3fd491f95c3a","user":{"login":"davidfowl","id":95136,"avatar_url":"https://avatars.githubusercontent.com/u/95136?v=2","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},"body":"Why ```Path = new PathString(null)```? What's the default?","created_at":"2014-10-01T16:50:18Z","updated_at":"2014-10-01T16:50:18Z","html_url":"https://github.com/aspnet/Diagnostics/pull/37#discussion_r18291239","pull_request_url":"https://api.github.com/repos/aspnet/Diagnostics/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Diagnostics/pulls/comments/18291239"},"html":{"href":"https://github.com/aspnet/Diagnostics/pull/37#discussion_r18291239"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Diagnostics/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Diagnostics/pulls/37","id":21957151,"html_url":"https://github.com/aspnet/Diagnostics/pull/37","diff_url":"https://github.com/aspnet/Diagnostics/pull/37.diff","patch_url":"https://github.com/aspnet/Diagnostics/pull/37.patch","issue_url":"https://api.github.com/repos/aspnet/Diagnostics/issues/37","number":37,"state":"open","locked":false,"title":"KRE info page","user":{"login":"victorhurdugaci","id":5921642,"avatar_url":"https://avatars.githubusercontent.com/u/5921642?v=2","gravatar_id":"","url":"https://api.github.com/users/victorhurdugaci","html_url":"https://github.com/victorhurdugaci","followers_url":"https://api.github.com/users/victorhurdugaci/followers","following_url":"https://api.github.com/users/victorhurdugaci/following{/other_user}","gists_url":"https://api.github.com/users/victorhurdugaci/gists{/gist_id}","starred_url":"https://api.github.com/users/victorhurdugaci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorhurdugaci/subscriptions","organizations_url":"https://api.github.com/users/victorhurdugaci/orgs","repos_url":"https://api.github.com/users/victorhurdugaci/repos","events_url":"https://api.github.com/users/victorhurdugaci/events{/privacy}","received_events_url":"https://api.github.com/users/victorhurdugaci/received_events","type":"User","site_admin":false},"body":"- The KRE Info page (see screenshot below)\r\n- The resource generator places the generated file in a different folder now. That's why you'll see a big change there.\r\n\r\n![kreinfo](https://cloud.githubusercontent.com/assets/5921642/4447634/5115e218-480c-11e4-8ee9-4602b0d67c2f.png)\r\n\r\n@davidfowl, @Eilon please review","created_at":"2014-09-29T19:12:41Z","updated_at":"2014-10-01T16:50:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8142ef6cf8cd92277912546a2ff6a3af83afdec8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Diagnostics/pulls/37/commits","review_comments_url":"https://api.github.com/repos/aspnet/Diagnostics/pulls/37/comments","review_comment_url":"https://api.github.com/repos/aspnet/Diagnostics/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/Diagnostics/issues/37/comments","statuses_url":"https://api.github.com/repos/aspnet/Diagnostics/statuses/0494475424ea60961f3563ce393f3fd491f95c3a","head":{"label":"aspnet:kreinfo","ref":"kreinfo","sha":"0494475424ea60961f3563ce393f3fd491f95c3a","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=2","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17548048,"name":"Diagnostics","full_name":"aspnet/Diagnostics","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=2","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Diagnostics","description":"","fork":false,"url":"https://api.github.com/repos/aspnet/Diagnostics","forks_url":"https://api.github.com/repos/aspnet/Diagnostics/forks","keys_url":"https://api.github.com/repos/aspnet/Diagnostics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Diagnostics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Diagnostics/teams","hooks_url":"https://api.github.com/repos/aspnet/Diagnostics/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Diagnostics/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Diagnostics/events","assignees_url":"https://api.github.com/repos/aspnet/Diagnostics/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Diagnostics/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Diagnostics/tags","blobs_url":"https://api.github.com/repos/aspnet/Diagnostics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Diagnostics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Diagnostics/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Diagnostics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Diagnostics/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Diagnostics/languages","stargazers_url":"https://api.github.com/repos/aspnet/Diagnostics/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Diagnostics/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Diagnostics/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Diagnostics/subscription","commits_url":"https://api.github.com/repos/aspnet/Diagnostics/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Diagnostics/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Diagnostics/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Diagnostics/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Diagnostics/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Diagnostics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Diagnostics/merges","archive_url":"https://api.github.com/repos/aspnet/Diagnostics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Diagnostics/downloads","issues_url":"https://api.github.com/repos/aspnet/Diagnostics/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Diagnostics/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Diagnostics/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Diagnostics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Diagnostics/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Diagnostics/releases{/id}","created_at":"2014-03-08T18:25:57Z","updated_at":"2014-09-29T19:28:06Z","pushed_at":"2014-10-01T15:53:26Z","git_url":"git://github.com/aspnet/Diagnostics.git","ssh_url":"git@github.com:aspnet/Diagnostics.git","clone_url":"https://github.com/aspnet/Diagnostics.git","svn_url":"https://github.com/aspnet/Diagnostics","homepage":"","size":1077,"stargazers_count":15,"watchers_count":15,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":15,"forks":8,"open_issues":15,"watchers":15,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"14bca1d49b45feb43ef791727f8ca4c52bc281dc","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=2","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17548048,"name":"Diagnostics","full_name":"aspnet/Diagnostics","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=2","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Diagnostics","description":"","fork":false,"url":"https://api.github.com/repos/aspnet/Diagnostics","forks_url":"https://api.github.com/repos/aspnet/Diagnostics/forks","keys_url":"https://api.github.com/repos/aspnet/Diagnostics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Diagnostics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Diagnostics/teams","hooks_url":"https://api.github.com/repos/aspnet/Diagnostics/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Diagnostics/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Diagnostics/events","assignees_url":"https://api.github.com/repos/aspnet/Diagnostics/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Diagnostics/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Diagnostics/tags","blobs_url":"https://api.github.com/repos/aspnet/Diagnostics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Diagnostics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Diagnostics/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Diagnostics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Diagnostics/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Diagnostics/languages","stargazers_url":"https://api.github.com/repos/aspnet/Diagnostics/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Diagnostics/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Diagnostics/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Diagnostics/subscription","commits_url":"https://api.github.com/repos/aspnet/Diagnostics/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Diagnostics/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Diagnostics/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Diagnostics/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Diagnostics/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Diagnostics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Diagnostics/merges","archive_url":"https://api.github.com/repos/aspnet/Diagnostics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Diagnostics/downloads","issues_url":"https://api.github.com/repos/aspnet/Diagnostics/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Diagnostics/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Diagnostics/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Diagnostics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Diagnostics/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Diagnostics/releases{/id}","created_at":"2014-03-08T18:25:57Z","updated_at":"2014-09-29T19:28:06Z","pushed_at":"2014-10-01T15:53:26Z","git_url":"git://github.com/aspnet/Diagnostics.git","ssh_url":"git@github.com:aspnet/Diagnostics.git","clone_url":"https://github.com/aspnet/Diagnostics.git","svn_url":"https://github.com/aspnet/Diagnostics","homepage":"","size":1077,"stargazers_count":15,"watchers_count":15,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":15,"forks":8,"open_issues":15,"watchers":15,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Diagnostics/pulls/37"},"html":{"href":"https://github.com/aspnet/Diagnostics/pull/37"},"issue":{"href":"https://api.github.com/repos/aspnet/Diagnostics/issues/37"},"comments":{"href":"https://api.github.com/repos/aspnet/Diagnostics/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Diagnostics/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Diagnostics/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Diagnostics/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Diagnostics/statuses/0494475424ea60961f3563ce393f3fd491f95c3a"}}}}