GitHub PullRequestReviewCommentEvent at 2014-10-10 22:58:38
Repository: docker
Actor: laktek
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/18735277","id":18735277,"diff_hunk":"@@ -97,3 +97,25 @@ func TestReadSymlinkedDirectoryToFile(t *testing.T) {\n \t\tt.Errorf(\"failed to remove symlink: %s\", err)\n \t}\n }\n+\n+func TestHasValidGITPrefix(t *testing.T) {\n+\tfor _, url := range []string{\n+\t\t\"git://github.com/docker/docker\",\n+\t\t\"git@github.com:docker/docker.git\",\n+\t\t\"https://github.com/docker/docker.git\",\n+\t\t\"http://github.com/docker/docker.git\",\n+\t} {\n+\t\tif HasValidGITPrefix(url) == false {\n+\t\t\tt.Fatalf(\"'%s' should be detected as valid Git prefix\", url)","path":"utils/utils_test.go","position":null,"original_position":13,"commit_id":"34e8a12f0534f27d0d7e7f53869f583cae6e0453","original_commit_id":"1e798578b2fe9e9e152ca1561efcdff619ef6a29","user":{"login":"laktek","id":5358,"avatar_url":"https://avatars.githubusercontent.com/u/5358?v=2","gravatar_id":"","url":"https://api.github.com/users/laktek","html_url":"https://github.com/laktek","followers_url":"https://api.github.com/users/laktek/followers","following_url":"https://api.github.com/users/laktek/following{/other_user}","gists_url":"https://api.github.com/users/laktek/gists{/gist_id}","starred_url":"https://api.github.com/users/laktek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laktek/subscriptions","organizations_url":"https://api.github.com/users/laktek/orgs","repos_url":"https://api.github.com/users/laktek/repos","events_url":"https://api.github.com/users/laktek/events{/privacy}","received_events_url":"https://api.github.com/users/laktek/received_events","type":"User","site_admin":false},"body":"@jfrazelle Thanks! Fixed and squashed both instances.","created_at":"2014-10-10T22:58:38Z","updated_at":"2014-10-10T22:58:38Z","html_url":"https://github.com/docker/docker/pull/8468#discussion_r18735277","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/8468","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/18735277"},"html":{"href":"https://github.com/docker/docker/pull/8468#discussion_r18735277"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/8468"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/8468","id":22401096,"html_url":"https://github.com/docker/docker/pull/8468","diff_url":"https://github.com/docker/docker/pull/8468.diff","patch_url":"https://github.com/docker/docker/pull/8468.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/8468","number":8468,"state":"open","locked":false,"title":"Fix URL check in build from Git.","user":{"login":"laktek","id":5358,"avatar_url":"https://avatars.githubusercontent.com/u/5358?v=2","gravatar_id":"","url":"https://api.github.com/users/laktek","html_url":"https://github.com/laktek","followers_url":"https://api.github.com/users/laktek/followers","following_url":"https://api.github.com/users/laktek/following{/other_user}","gists_url":"https://api.github.com/users/laktek/gists{/gist_id}","starred_url":"https://api.github.com/users/laktek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laktek/subscriptions","organizations_url":"https://api.github.com/users/laktek/orgs","repos_url":"https://api.github.com/users/laktek/repos","events_url":"https://api.github.com/users/laktek/events{/privacy}","received_events_url":"https://api.github.com/users/laktek/received_events","type":"User","site_admin":false},"body":"Existing check ignores valid git URLs with prefix, \"git@\", \"http://\" or \"https://\". This leads to erroneously prepending \"https://\" to valid URLs.","created_at":"2014-10-08T05:10:00Z","updated_at":"2014-10-10T22:58:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e552a014f36e5bce338c33cdee3fe40f9c5a350","assignee":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?v=2","gravatar_id":"","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/30","labels_url":"https://api.github.com/repos/docker/docker/milestones/30/labels","id":802943,"number":30,"title":"1.4","description":"","creator":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=2","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":1,"state":"open","created_at":"2014-09-25T17:35:20Z","updated_at":"2014-10-10T05:13:55Z","due_on":"2014-12-09T08:00:00Z"},"commits_url":"https://api.github.com/repos/docker/docker/pulls/8468/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/8468/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/docker/issues/8468/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/34e8a12f0534f27d0d7e7f53869f583cae6e0453","head":{"label":"laktek:master","ref":"master","sha":"34e8a12f0534f27d0d7e7f53869f583cae6e0453","user":{"login":"laktek","id":5358,"avatar_url":"https://avatars.githubusercontent.com/u/5358?v=2","gravatar_id":"","url":"https://api.github.com/users/laktek","html_url":"https://github.com/laktek","followers_url":"https://api.github.com/users/laktek/followers","following_url":"https://api.github.com/users/laktek/following{/other_user}","gists_url":"https://api.github.com/users/laktek/gists{/gist_id}","starred_url":"https://api.github.com/users/laktek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laktek/subscriptions","organizations_url":"https://api.github.com/users/laktek/orgs","repos_url":"https://api.github.com/users/laktek/repos","events_url":"https://api.github.com/users/laktek/events{/privacy}","received_events_url":"https://api.github.com/users/laktek/received_events","type":"User","site_admin":false},"repo":{"id":23911082,"name":"docker","full_name":"laktek/docker","owner":{"login":"laktek","id":5358,"avatar_url":"https://avatars.githubusercontent.com/u/5358?v=2","gravatar_id":"","url":"https://api.github.com/users/laktek","html_url":"https://github.com/laktek","followers_url":"https://api.github.com/users/laktek/followers","following_url":"https://api.github.com/users/laktek/following{/other_user}","gists_url":"https://api.github.com/users/laktek/gists{/gist_id}","starred_url":"https://api.github.com/users/laktek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laktek/subscriptions","organizations_url":"https://api.github.com/users/laktek/orgs","repos_url":"https://api.github.com/users/laktek/repos","events_url":"https://api.github.com/users/laktek/events{/privacy}","received_events_url":"https://api.github.com/users/laktek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laktek/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/laktek/docker","forks_url":"https://api.github.com/repos/laktek/docker/forks","keys_url":"https://api.github.com/repos/laktek/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laktek/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laktek/docker/teams","hooks_url":"https://api.github.com/repos/laktek/docker/hooks","issue_events_url":"https://api.github.com/repos/laktek/docker/issues/events{/number}","events_url":"https://api.github.com/repos/laktek/docker/events","assignees_url":"https://api.github.com/repos/laktek/docker/assignees{/user}","branches_url":"https://api.github.com/repos/laktek/docker/branches{/branch}","tags_url":"https://api.github.com/repos/laktek/docker/tags","blobs_url":"https://api.github.com/repos/laktek/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laktek/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laktek/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/laktek/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laktek/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/laktek/docker/languages","stargazers_url":"https://api.github.com/repos/laktek/docker/stargazers","contributors_url":"https://api.github.com/repos/laktek/docker/contributors","subscribers_url":"https://api.github.com/repos/laktek/docker/subscribers","subscription_url":"https://api.github.com/repos/laktek/docker/subscription","commits_url":"https://api.github.com/repos/laktek/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/laktek/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/laktek/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/laktek/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/laktek/docker/contents/{+path}","compare_url":"https://api.github.com/repos/laktek/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laktek/docker/merges","archive_url":"https://api.github.com/repos/laktek/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laktek/docker/downloads","issues_url":"https://api.github.com/repos/laktek/docker/issues{/number}","pulls_url":"https://api.github.com/repos/laktek/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/laktek/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/laktek/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laktek/docker/labels{/name}","releases_url":"https://api.github.com/repos/laktek/docker/releases{/id}","created_at":"2014-09-11T08:53:33Z","updated_at":"2014-09-11T09:10:35Z","pushed_at":"2014-10-10T22:58:00Z","git_url":"git://github.com/laktek/docker.git","ssh_url":"git@github.com:laktek/docker.git","clone_url":"https://github.com/laktek/docker.git","svn_url":"https://github.com/laktek/docker","homepage":"http://www.docker.com","size":34584,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"248ec5d74e4f33bbcf946609fc5f9081a267fb8b","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=2","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=2","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2014-10-10T21:21:03Z","pushed_at":"2014-10-10T00:52:18Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":150411,"stargazers_count":15650,"watchers_count":15650,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3005,"mirror_url":null,"open_issues_count":803,"forks":3005,"open_issues":803,"watchers":15650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/8468"},"html":{"href":"https://github.com/docker/docker/pull/8468"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/8468"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/8468/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/8468/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/8468/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/34e8a12f0534f27d0d7e7f53869f583cae6e0453"}}}}