GitHub PullRequestReviewCommentEvent at 2014-10-10 00:00:29
Repository: etcd
Actor: unihorn
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/18682606","id":18682606,"diff_hunk":"@@ -444,11 +443,12 @@ func (s *EtcdServer) sync(timeout time.Duration) {\n // static clientURLs of the server.\n // The function keeps attempting to register until it succeeds,\n // or its server is stopped.\n-// TODO: take care of info fetched from cluster store after having reconfig.\n func (s *EtcdServer) publish(retryInterval time.Duration) {\n-\tm := *s.ClusterStore.Get().FindName(s.name)\n-\tm.ClientURLs = s.clientURLs.StringSlice()\n-\tb, err := json.Marshal(m)\n+\tm := Member{","path":"etcdserver/server.go","position":48,"original_position":48,"commit_id":"e4b06bc3fda4d96e901d580fc8ea825d4d060539","original_commit_id":"a1dc1c3cb06255958df3c16177f7accbd0422b2d","user":{"login":"unihorn","id":2976232,"avatar_url":"https://avatars.githubusercontent.com/u/2976232?v=2","gravatar_id":"","url":"https://api.github.com/users/unihorn","html_url":"https://github.com/unihorn","followers_url":"https://api.github.com/users/unihorn/followers","following_url":"https://api.github.com/users/unihorn/following{/other_user}","gists_url":"https://api.github.com/users/unihorn/gists{/gist_id}","starred_url":"https://api.github.com/users/unihorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unihorn/subscriptions","organizations_url":"https://api.github.com/users/unihorn/orgs","repos_url":"https://api.github.com/users/unihorn/repos","events_url":"https://api.github.com/users/unihorn/events{/privacy}","received_events_url":"https://api.github.com/users/unihorn/received_events","type":"User","site_admin":false},"body":"i don't want to change api boundary of member in this PR.\r\nit is good to just create a member for storekey, and i think i could delete multiple lines.","created_at":"2014-10-10T00:00:29Z","updated_at":"2014-10-10T00:00:29Z","html_url":"https://github.com/coreos/etcd/pull/1234#discussion_r18682606","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/1234","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/18682606"},"html":{"href":"https://github.com/coreos/etcd/pull/1234#discussion_r18682606"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1234"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/1234","id":22176157,"html_url":"https://github.com/coreos/etcd/pull/1234","diff_url":"https://github.com/coreos/etcd/pull/1234.diff","patch_url":"https://github.com/coreos/etcd/pull/1234.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/1234","number":1234,"state":"open","locked":false,"title":"etcdserver: save PeerURLs and Others into two different keys","user":{"login":"unihorn","id":2976232,"avatar_url":"https://avatars.githubusercontent.com/u/2976232?v=2","gravatar_id":"","url":"https://api.github.com/users/unihorn","html_url":"https://github.com/unihorn","followers_url":"https://api.github.com/users/unihorn/followers","following_url":"https://api.github.com/users/unihorn/following{/other_user}","gists_url":"https://api.github.com/users/unihorn/gists{/gist_id}","starred_url":"https://api.github.com/users/unihorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unihorn/subscriptions","organizations_url":"https://api.github.com/users/unihorn/orgs","repos_url":"https://api.github.com/users/unihorn/repos","events_url":"https://api.github.com/users/unihorn/events{/privacy}","received_events_url":"https://api.github.com/users/unihorn/received_events","type":"User","site_admin":false},"body":"for #1233 \r\n\r\ni haven't cleaned up the code and tests. i wanna some feedback on this approach.","created_at":"2014-10-02T22:50:53Z","updated_at":"2014-10-10T00:00:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"454ed3831e13f473054a81bcd4c8dd0ca33bbb96","assignee":null,"milestone":{"url":"https://api.github.com/repos/coreos/etcd/milestones/5","labels_url":"https://api.github.com/repos/coreos/etcd/milestones/5/labels","id":782754,"number":5,"title":"v0.5.0-alpha","description":"v0.5 alpha release","creator":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=2","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":66,"state":"open","created_at":"2014-09-08T21:14:05Z","updated_at":"2014-10-09T17:53:24Z","due_on":"2014-09-26T07:00:00Z"},"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/1234/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/1234/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/1234/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/e4b06bc3fda4d96e901d580fc8ea825d4d060539","head":{"label":"unihorn:152","ref":"152","sha":"e4b06bc3fda4d96e901d580fc8ea825d4d060539","user":{"login":"unihorn","id":2976232,"avatar_url":"https://avatars.githubusercontent.com/u/2976232?v=2","gravatar_id":"","url":"https://api.github.com/users/unihorn","html_url":"https://github.com/unihorn","followers_url":"https://api.github.com/users/unihorn/followers","following_url":"https://api.github.com/users/unihorn/following{/other_user}","gists_url":"https://api.github.com/users/unihorn/gists{/gist_id}","starred_url":"https://api.github.com/users/unihorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unihorn/subscriptions","organizations_url":"https://api.github.com/users/unihorn/orgs","repos_url":"https://api.github.com/users/unihorn/repos","events_url":"https://api.github.com/users/unihorn/events{/privacy}","received_events_url":"https://api.github.com/users/unihorn/received_events","type":"User","site_admin":false},"repo":{"id":16744058,"name":"etcd","full_name":"unihorn/etcd","owner":{"login":"unihorn","id":2976232,"avatar_url":"https://avatars.githubusercontent.com/u/2976232?v=2","gravatar_id":"","url":"https://api.github.com/users/unihorn","html_url":"https://github.com/unihorn","followers_url":"https://api.github.com/users/unihorn/followers","following_url":"https://api.github.com/users/unihorn/following{/other_user}","gists_url":"https://api.github.com/users/unihorn/gists{/gist_id}","starred_url":"https://api.github.com/users/unihorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unihorn/subscriptions","organizations_url":"https://api.github.com/users/unihorn/orgs","repos_url":"https://api.github.com/users/unihorn/repos","events_url":"https://api.github.com/users/unihorn/events{/privacy}","received_events_url":"https://api.github.com/users/unihorn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unihorn/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":true,"url":"https://api.github.com/repos/unihorn/etcd","forks_url":"https://api.github.com/repos/unihorn/etcd/forks","keys_url":"https://api.github.com/repos/unihorn/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unihorn/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unihorn/etcd/teams","hooks_url":"https://api.github.com/repos/unihorn/etcd/hooks","issue_events_url":"https://api.github.com/repos/unihorn/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/unihorn/etcd/events","assignees_url":"https://api.github.com/repos/unihorn/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/unihorn/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/unihorn/etcd/tags","blobs_url":"https://api.github.com/repos/unihorn/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unihorn/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unihorn/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/unihorn/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unihorn/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/unihorn/etcd/languages","stargazers_url":"https://api.github.com/repos/unihorn/etcd/stargazers","contributors_url":"https://api.github.com/repos/unihorn/etcd/contributors","subscribers_url":"https://api.github.com/repos/unihorn/etcd/subscribers","subscription_url":"https://api.github.com/repos/unihorn/etcd/subscription","commits_url":"https://api.github.com/repos/unihorn/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/unihorn/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/unihorn/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/unihorn/etcd/issues/comments/{number}","contents_url":"https://api.github.com/repos/unihorn/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/unihorn/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unihorn/etcd/merges","archive_url":"https://api.github.com/repos/unihorn/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unihorn/etcd/downloads","issues_url":"https://api.github.com/repos/unihorn/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/unihorn/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/unihorn/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/unihorn/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unihorn/etcd/labels{/name}","releases_url":"https://api.github.com/repos/unihorn/etcd/releases{/id}","created_at":"2014-02-11T20:18:23Z","updated_at":"2014-09-12T22:41:09Z","pushed_at":"2014-10-09T23:51:18Z","git_url":"git://github.com/unihorn/etcd.git","ssh_url":"git@github.com:unihorn/etcd.git","clone_url":"https://github.com/unihorn/etcd.git","svn_url":"https://github.com/unihorn/etcd","homepage":"","size":15508,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"74ab003e1f046655650820f0302e3c96da2e8ca1","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=2","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=2","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments/{number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","created_at":"2013-07-06T21:57:21Z","updated_at":"2014-10-09T23:03:56Z","pushed_at":"2014-10-09T17:24:14Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"","size":25237,"stargazers_count":4352,"watchers_count":4352,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":439,"mirror_url":null,"open_issues_count":151,"forks":439,"open_issues":151,"watchers":4352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1234"},"html":{"href":"https://github.com/coreos/etcd/pull/1234"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/1234"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/1234/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1234/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/1234/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/e4b06bc3fda4d96e901d580fc8ea825d4d060539"}}}}