GitHub PullRequestEvent at 2014-12-08 19:13:44
Repository: packer
Actor: armon
Payload: {"action":"closed","number":1700,"pull_request":{"url":"https://api.github.com/repos/mitchellh/packer/pulls/1700","id":25155687,"html_url":"https://github.com/mitchellh/packer/pull/1700","diff_url":"https://github.com/mitchellh/packer/pull/1700.diff","patch_url":"https://github.com/mitchellh/packer/pull/1700.patch","issue_url":"https://api.github.com/repos/mitchellh/packer/issues/1700","number":1700,"state":"closed","locked":false,"title":"Parallels: Fixed issue #1667","user":{"login":"legal90","id":4846154,"avatar_url":"https://avatars.githubusercontent.com/u/4846154?v=3","gravatar_id":"","url":"https://api.github.com/users/legal90","html_url":"https://github.com/legal90","followers_url":"https://api.github.com/users/legal90/followers","following_url":"https://api.github.com/users/legal90/following{/other_user}","gists_url":"https://api.github.com/users/legal90/gists{/gist_id}","starred_url":"https://api.github.com/users/legal90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legal90/subscriptions","organizations_url":"https://api.github.com/users/legal90/orgs","repos_url":"https://api.github.com/users/legal90/repos","events_url":"https://api.github.com/users/legal90/events{/privacy}","received_events_url":"https://api.github.com/users/legal90/received_events","type":"User","site_admin":false},"body":"1) Fixed issue #1667 by partially reverting the previous changes.\r\n\r\nWhile attaching the bootable ISO to the DVD/CD-ROM device we will attach it exactly to the first one, `cdrom0`. \r\nIt is caused by Parallels Desktop 9 bug - virtual machine is failed to boot from any cdrom device except the first one (regardless of its enabled/disabled state). \r\n\r\nSo, on the cleanup stage we will detach the ISO with a little trick, by setting the image path as an empty string.\r\nIt is working fine on both of supported versions: Parallels Desktop 9 and 10 as well.\r\n\r\n2) Setting the boot order moved to the separated step, `stepSetBootOrder `.  It makes the build process more clear.\r\nP.s. This setting is still required because HDD is added (by `stepCreateDisk `) to the end of boot order.\r\n","created_at":"2014-11-27T14:52:28Z","updated_at":"2014-12-08T19:13:44Z","closed_at":"2014-12-08T19:13:44Z","merged_at":"2014-12-08T19:13:44Z","merge_commit_sha":"3c0e293f1bb855542b55c0e43f303dd0fc7eaaa7","assignee":{"login":"rickard-von-essen","id":557699,"avatar_url":"https://avatars.githubusercontent.com/u/557699?v=3","gravatar_id":"","url":"https://api.github.com/users/rickard-von-essen","html_url":"https://github.com/rickard-von-essen","followers_url":"https://api.github.com/users/rickard-von-essen/followers","following_url":"https://api.github.com/users/rickard-von-essen/following{/other_user}","gists_url":"https://api.github.com/users/rickard-von-essen/gists{/gist_id}","starred_url":"https://api.github.com/users/rickard-von-essen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickard-von-essen/subscriptions","organizations_url":"https://api.github.com/users/rickard-von-essen/orgs","repos_url":"https://api.github.com/users/rickard-von-essen/repos","events_url":"https://api.github.com/users/rickard-von-essen/events{/privacy}","received_events_url":"https://api.github.com/users/rickard-von-essen/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mitchellh/packer/pulls/1700/commits","review_comments_url":"https://api.github.com/repos/mitchellh/packer/pulls/1700/comments","review_comment_url":"https://api.github.com/repos/mitchellh/packer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mitchellh/packer/issues/1700/comments","statuses_url":"https://api.github.com/repos/mitchellh/packer/statuses/a5b21c59ba3012cc10bbffc6940916ba5e0de4b2","head":{"label":"legal90:iss-1667","ref":"iss-1667","sha":"a5b21c59ba3012cc10bbffc6940916ba5e0de4b2","user":{"login":"legal90","id":4846154,"avatar_url":"https://avatars.githubusercontent.com/u/4846154?v=3","gravatar_id":"","url":"https://api.github.com/users/legal90","html_url":"https://github.com/legal90","followers_url":"https://api.github.com/users/legal90/followers","following_url":"https://api.github.com/users/legal90/following{/other_user}","gists_url":"https://api.github.com/users/legal90/gists{/gist_id}","starred_url":"https://api.github.com/users/legal90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legal90/subscriptions","organizations_url":"https://api.github.com/users/legal90/orgs","repos_url":"https://api.github.com/users/legal90/repos","events_url":"https://api.github.com/users/legal90/events{/privacy}","received_events_url":"https://api.github.com/users/legal90/received_events","type":"User","site_admin":false},"repo":{"id":19356260,"name":"packer","full_name":"legal90/packer","owner":{"login":"legal90","id":4846154,"avatar_url":"https://avatars.githubusercontent.com/u/4846154?v=3","gravatar_id":"","url":"https://api.github.com/users/legal90","html_url":"https://github.com/legal90","followers_url":"https://api.github.com/users/legal90/followers","following_url":"https://api.github.com/users/legal90/following{/other_user}","gists_url":"https://api.github.com/users/legal90/gists{/gist_id}","starred_url":"https://api.github.com/users/legal90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legal90/subscriptions","organizations_url":"https://api.github.com/users/legal90/orgs","repos_url":"https://api.github.com/users/legal90/repos","events_url":"https://api.github.com/users/legal90/events{/privacy}","received_events_url":"https://api.github.com/users/legal90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/legal90/packer","description":"Packer is a tool for creating identical machine images for multiple platforms from a single source configuration.","fork":true,"url":"https://api.github.com/repos/legal90/packer","forks_url":"https://api.github.com/repos/legal90/packer/forks","keys_url":"https://api.github.com/repos/legal90/packer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legal90/packer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legal90/packer/teams","hooks_url":"https://api.github.com/repos/legal90/packer/hooks","issue_events_url":"https://api.github.com/repos/legal90/packer/issues/events{/number}","events_url":"https://api.github.com/repos/legal90/packer/events","assignees_url":"https://api.github.com/repos/legal90/packer/assignees{/user}","branches_url":"https://api.github.com/repos/legal90/packer/branches{/branch}","tags_url":"https://api.github.com/repos/legal90/packer/tags","blobs_url":"https://api.github.com/repos/legal90/packer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legal90/packer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legal90/packer/git/refs{/sha}","trees_url":"https://api.github.com/repos/legal90/packer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legal90/packer/statuses/{sha}","languages_url":"https://api.github.com/repos/legal90/packer/languages","stargazers_url":"https://api.github.com/repos/legal90/packer/stargazers","contributors_url":"https://api.github.com/repos/legal90/packer/contributors","subscribers_url":"https://api.github.com/repos/legal90/packer/subscribers","subscription_url":"https://api.github.com/repos/legal90/packer/subscription","commits_url":"https://api.github.com/repos/legal90/packer/commits{/sha}","git_commits_url":"https://api.github.com/repos/legal90/packer/git/commits{/sha}","comments_url":"https://api.github.com/repos/legal90/packer/comments{/number}","issue_comment_url":"https://api.github.com/repos/legal90/packer/issues/comments/{number}","contents_url":"https://api.github.com/repos/legal90/packer/contents/{+path}","compare_url":"https://api.github.com/repos/legal90/packer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legal90/packer/merges","archive_url":"https://api.github.com/repos/legal90/packer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legal90/packer/downloads","issues_url":"https://api.github.com/repos/legal90/packer/issues{/number}","pulls_url":"https://api.github.com/repos/legal90/packer/pulls{/number}","milestones_url":"https://api.github.com/repos/legal90/packer/milestones{/number}","notifications_url":"https://api.github.com/repos/legal90/packer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legal90/packer/labels{/name}","releases_url":"https://api.github.com/repos/legal90/packer/releases{/id}","created_at":"2014-05-01T20:06:11Z","updated_at":"2014-11-27T14:15:03Z","pushed_at":"2014-11-27T14:15:02Z","git_url":"git://github.com/legal90/packer.git","ssh_url":"git@github.com:legal90/packer.git","clone_url":"https://github.com/legal90/packer.git","svn_url":"https://github.com/legal90/packer","homepage":"http://www.packer.io","size":7859,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mitchellh:master","ref":"master","sha":"347f02a7f2fa3a9775676a39175429959bba3893","user":{"login":"mitchellh","id":1299,"avatar_url":"https://avatars.githubusercontent.com/u/1299?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},"repo":{"id":8966356,"name":"packer","full_name":"mitchellh/packer","owner":{"login":"mitchellh","id":1299,"avatar_url":"https://avatars.githubusercontent.com/u/1299?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchellh/packer","description":"Packer is a tool for creating identical machine images for multiple platforms from a single source configuration.","fork":false,"url":"https://api.github.com/repos/mitchellh/packer","forks_url":"https://api.github.com/repos/mitchellh/packer/forks","keys_url":"https://api.github.com/repos/mitchellh/packer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchellh/packer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchellh/packer/teams","hooks_url":"https://api.github.com/repos/mitchellh/packer/hooks","issue_events_url":"https://api.github.com/repos/mitchellh/packer/issues/events{/number}","events_url":"https://api.github.com/repos/mitchellh/packer/events","assignees_url":"https://api.github.com/repos/mitchellh/packer/assignees{/user}","branches_url":"https://api.github.com/repos/mitchellh/packer/branches{/branch}","tags_url":"https://api.github.com/repos/mitchellh/packer/tags","blobs_url":"https://api.github.com/repos/mitchellh/packer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchellh/packer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchellh/packer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchellh/packer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchellh/packer/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchellh/packer/languages","stargazers_url":"https://api.github.com/repos/mitchellh/packer/stargazers","contributors_url":"https://api.github.com/repos/mitchellh/packer/contributors","subscribers_url":"https://api.github.com/repos/mitchellh/packer/subscribers","subscription_url":"https://api.github.com/repos/mitchellh/packer/subscription","commits_url":"https://api.github.com/repos/mitchellh/packer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchellh/packer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchellh/packer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchellh/packer/issues/comments/{number}","contents_url":"https://api.github.com/repos/mitchellh/packer/contents/{+path}","compare_url":"https://api.github.com/repos/mitchellh/packer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchellh/packer/merges","archive_url":"https://api.github.com/repos/mitchellh/packer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchellh/packer/downloads","issues_url":"https://api.github.com/repos/mitchellh/packer/issues{/number}","pulls_url":"https://api.github.com/repos/mitchellh/packer/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchellh/packer/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchellh/packer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchellh/packer/labels{/name}","releases_url":"https://api.github.com/repos/mitchellh/packer/releases{/id}","created_at":"2013-03-23T05:43:03Z","updated_at":"2014-12-08T19:12:23Z","pushed_at":"2014-12-08T19:13:44Z","git_url":"git://github.com/mitchellh/packer.git","ssh_url":"git@github.com:mitchellh/packer.git","clone_url":"https://github.com/mitchellh/packer.git","svn_url":"https://github.com/mitchellh/packer","homepage":"http://www.packer.io","size":18411,"stargazers_count":3373,"watchers_count":3373,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":608,"mirror_url":null,"open_issues_count":180,"forks":608,"open_issues":180,"watchers":3373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/1700"},"html":{"href":"https://github.com/mitchellh/packer/pull/1700"},"issue":{"href":"https://api.github.com/repos/mitchellh/packer/issues/1700"},"comments":{"href":"https://api.github.com/repos/mitchellh/packer/issues/1700/comments"},"review_comments":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/1700/comments"},"review_comment":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/1700/commits"},"statuses":{"href":"https://api.github.com/repos/mitchellh/packer/statuses/a5b21c59ba3012cc10bbffc6940916ba5e0de4b2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"armon","id":592032,"avatar_url":"https://avatars.githubusercontent.com/u/592032?v=3","gravatar_id":"","url":"https://api.github.com/users/armon","html_url":"https://github.com/armon","followers_url":"https://api.github.com/users/armon/followers","following_url":"https://api.github.com/users/armon/following{/other_user}","gists_url":"https://api.github.com/users/armon/gists{/gist_id}","starred_url":"https://api.github.com/users/armon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armon/subscriptions","organizations_url":"https://api.github.com/users/armon/orgs","repos_url":"https://api.github.com/users/armon/repos","events_url":"https://api.github.com/users/armon/events{/privacy}","received_events_url":"https://api.github.com/users/armon/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":61,"deletions":53,"changed_files":3}}