GitHub PullRequestReviewCommentEvent at 2014-10-17 20:36:42
Repository: pulp_ostree
Actor: barnabycourt
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/pulp/pulp_ostree/pulls/comments/19041898","id":19041898,"diff_hunk":"@@ -0,0 +1,45 @@\n+from pulp.client.commands.unit import UnitCopyCommand, UnitRemoveCommand\n+\n+\n+def format_unit(unit_key):\n+    \"\"\"\n+    Get a short string representation of an ostree unit key.\n+    :param unit_key: An ostree unit key.\n+    :type unit_key: dict\n+    :return: A string representation.\n+    :rtype: str\n+    :see: pulp_ostree.common.model.Repository\n+    \"\"\"\n+    return 'remote_id: %(remote_id)s digest: %(digest)s' % unit_key\n+\n+\n+class CopyCommand(UnitCopyCommand):\n+    \"\"\"\n+    Copy unit command.\n+    \"\"\"\n+\n+    def get_formatter_for_type(self, type_id):\n+        \"\"\"\n+        Get a formatter for the specified type ID.\n+        :param type_id: A unit type ID.\n+        :type type_id: str\n+        :return: The requested formatter.\n+        :rtype: callable\n+        \"\"\"\n+        return format_unit\n+\n+\n+class RemoveCommand(UnitRemoveCommand):\n+    \"\"\"\n+    Remove unit command.\n+    \"\"\"\n+\n+    def get_formatter_for_type(self, type_id):\n+        \"\"\"\n+        Get a formatter for the specified type ID.\n+        :param type_id: A unit type ID.\n+        :type type_id: str\n+        :return: The requested formatter.\n+        :rtype: callable\n+        \"\"\"\n+        return format_unit","path":"extensions_admin/pulp_ostree/extensions/admin/unit.py","position":45,"original_position":45,"commit_id":"b338cffd4efec3800dad1e95fcecba81b8800b75","original_commit_id":"b338cffd4efec3800dad1e95fcecba81b8800b75","user":{"login":"barnabycourt","id":5054204,"avatar_url":"https://avatars.githubusercontent.com/u/5054204?v=2","gravatar_id":"","url":"https://api.github.com/users/barnabycourt","html_url":"https://github.com/barnabycourt","followers_url":"https://api.github.com/users/barnabycourt/followers","following_url":"https://api.github.com/users/barnabycourt/following{/other_user}","gists_url":"https://api.github.com/users/barnabycourt/gists{/gist_id}","starred_url":"https://api.github.com/users/barnabycourt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barnabycourt/subscriptions","organizations_url":"https://api.github.com/users/barnabycourt/orgs","repos_url":"https://api.github.com/users/barnabycourt/repos","events_url":"https://api.github.com/users/barnabycourt/events{/privacy}","received_events_url":"https://api.github.com/users/barnabycourt/received_events","type":"User","site_admin":false},"body":"missing test coverage","created_at":"2014-10-17T20:36:42Z","updated_at":"2014-10-17T20:36:42Z","html_url":"https://github.com/pulp/pulp_ostree/pull/12#discussion_r19041898","pull_request_url":"https://api.github.com/repos/pulp/pulp_ostree/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp_ostree/pulls/comments/19041898"},"html":{"href":"https://github.com/pulp/pulp_ostree/pull/12#discussion_r19041898"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp_ostree/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/pulp/pulp_ostree/pulls/12","id":22820047,"html_url":"https://github.com/pulp/pulp_ostree/pull/12","diff_url":"https://github.com/pulp/pulp_ostree/pull/12.diff","patch_url":"https://github.com/pulp/pulp_ostree/pull/12.patch","issue_url":"https://api.github.com/repos/pulp/pulp_ostree/issues/12","number":12,"state":"open","locked":false,"title":"Add support for unit copy/remove.","user":{"login":"jortel","id":1126767,"avatar_url":"https://avatars.githubusercontent.com/u/1126767?v=2","gravatar_id":"","url":"https://api.github.com/users/jortel","html_url":"https://github.com/jortel","followers_url":"https://api.github.com/users/jortel/followers","following_url":"https://api.github.com/users/jortel/following{/other_user}","gists_url":"https://api.github.com/users/jortel/gists{/gist_id}","starred_url":"https://api.github.com/users/jortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jortel/subscriptions","organizations_url":"https://api.github.com/users/jortel/orgs","repos_url":"https://api.github.com/users/jortel/repos","events_url":"https://api.github.com/users/jortel/events{/privacy}","received_events_url":"https://api.github.com/users/jortel/received_events","type":"User","site_admin":false},"body":"Includes:\r\n- Fixed broken repository synchronization.\r\n- Added support in the importer for unit copy.\r\n- Added commands to copy and remove content units.\r\n\r\nLooks like the user guide needs a *recipes* section for all commands.  Will add a separate story that will cover these copy and remove commands as well.","created_at":"2014-10-15T22:21:30Z","updated_at":"2014-10-17T20:36:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdac67186c9aab3dd6e3b011b47c7c486cf32ec7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp_ostree/pulls/12/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp_ostree/pulls/12/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp_ostree/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pulp/pulp_ostree/issues/12/comments","statuses_url":"https://api.github.com/repos/pulp/pulp_ostree/statuses/b338cffd4efec3800dad1e95fcecba81b8800b75","head":{"label":"pulp:jortel-US2986","ref":"jortel-US2986","sha":"b338cffd4efec3800dad1e95fcecba81b8800b75","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=2","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":23476305,"name":"pulp_ostree","full_name":"pulp/pulp_ostree","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=2","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp_ostree","description":"OSTree support for the Pulp Platform","fork":false,"url":"https://api.github.com/repos/pulp/pulp_ostree","forks_url":"https://api.github.com/repos/pulp/pulp_ostree/forks","keys_url":"https://api.github.com/repos/pulp/pulp_ostree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp_ostree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp_ostree/teams","hooks_url":"https://api.github.com/repos/pulp/pulp_ostree/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp_ostree/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp_ostree/events","assignees_url":"https://api.github.com/repos/pulp/pulp_ostree/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp_ostree/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp_ostree/tags","blobs_url":"https://api.github.com/repos/pulp/pulp_ostree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp_ostree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp_ostree/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp_ostree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp_ostree/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp_ostree/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp_ostree/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp_ostree/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp_ostree/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp_ostree/subscription","commits_url":"https://api.github.com/repos/pulp/pulp_ostree/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp_ostree/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp_ostree/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp_ostree/issues/comments/{number}","contents_url":"https://api.github.com/repos/pulp/pulp_ostree/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp_ostree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp_ostree/merges","archive_url":"https://api.github.com/repos/pulp/pulp_ostree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp_ostree/downloads","issues_url":"https://api.github.com/repos/pulp/pulp_ostree/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp_ostree/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp_ostree/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp_ostree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp_ostree/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp_ostree/releases{/id}","created_at":"2014-08-29T20:05:41Z","updated_at":"2014-09-08T19:23:27Z","pushed_at":"2014-10-17T19:41:03Z","git_url":"git://github.com/pulp/pulp_ostree.git","ssh_url":"git@github.com:pulp/pulp_ostree.git","clone_url":"https://github.com/pulp/pulp_ostree.git","svn_url":"https://github.com/pulp/pulp_ostree","homepage":null,"size":516,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:master","ref":"master","sha":"db65a766f83b62e751be5b6f3de8abaa7b736b7c","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=2","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":23476305,"name":"pulp_ostree","full_name":"pulp/pulp_ostree","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=2","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp_ostree","description":"OSTree support for the Pulp Platform","fork":false,"url":"https://api.github.com/repos/pulp/pulp_ostree","forks_url":"https://api.github.com/repos/pulp/pulp_ostree/forks","keys_url":"https://api.github.com/repos/pulp/pulp_ostree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp_ostree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp_ostree/teams","hooks_url":"https://api.github.com/repos/pulp/pulp_ostree/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp_ostree/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp_ostree/events","assignees_url":"https://api.github.com/repos/pulp/pulp_ostree/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp_ostree/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp_ostree/tags","blobs_url":"https://api.github.com/repos/pulp/pulp_ostree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp_ostree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp_ostree/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp_ostree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp_ostree/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp_ostree/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp_ostree/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp_ostree/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp_ostree/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp_ostree/subscription","commits_url":"https://api.github.com/repos/pulp/pulp_ostree/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp_ostree/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp_ostree/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp_ostree/issues/comments/{number}","contents_url":"https://api.github.com/repos/pulp/pulp_ostree/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp_ostree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp_ostree/merges","archive_url":"https://api.github.com/repos/pulp/pulp_ostree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp_ostree/downloads","issues_url":"https://api.github.com/repos/pulp/pulp_ostree/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp_ostree/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp_ostree/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp_ostree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp_ostree/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp_ostree/releases{/id}","created_at":"2014-08-29T20:05:41Z","updated_at":"2014-09-08T19:23:27Z","pushed_at":"2014-10-17T19:41:03Z","git_url":"git://github.com/pulp/pulp_ostree.git","ssh_url":"git@github.com:pulp/pulp_ostree.git","clone_url":"https://github.com/pulp/pulp_ostree.git","svn_url":"https://github.com/pulp/pulp_ostree","homepage":null,"size":516,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp_ostree/pulls/12"},"html":{"href":"https://github.com/pulp/pulp_ostree/pull/12"},"issue":{"href":"https://api.github.com/repos/pulp/pulp_ostree/issues/12"},"comments":{"href":"https://api.github.com/repos/pulp/pulp_ostree/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp_ostree/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp_ostree/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp_ostree/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp_ostree/statuses/b338cffd4efec3800dad1e95fcecba81b8800b75"}}}}