GitHub PullRequestReviewCommentEvent at 2014-03-10 10:42:56
Repository: gaia
Actor: jmcanterafonseca
Payload: {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/10424582","id":10424582,"diff_hunk":"@@ -38,37 +38,38 @@ function roundData(value, positions) {\n   return [(value / 1000000000).toFixed(positions), _('GB')];\n }\n \n-function getPositions(value) {\n+function getPositions(value, adjustPositions) {","path":"apps/costcontrol/js/utils/formatting.js","position":5,"original_position":5,"commit_id":"b071170056850f27df8a8b78e6f4f165f19cccff","original_commit_id":"b071170056850f27df8a8b78e6f4f165f19cccff","user":{"login":"jmcanterafonseca","id":694782,"avatar_url":"https://gravatar.com/avatar/fd0e9eda3bafe4df58adf9fe0f218e04?d=https%3A%2F%2Fidenticons.github.com%2Fb0573b29b31ba48a21d12befa3f76a5e.png&r=x","gravatar_id":"fd0e9eda3bafe4df58adf9fe0f218e04","url":"https://api.github.com/users/jmcanterafonseca","html_url":"https://github.com/jmcanterafonseca","followers_url":"https://api.github.com/users/jmcanterafonseca/followers","following_url":"https://api.github.com/users/jmcanterafonseca/following{/other_user}","gists_url":"https://api.github.com/users/jmcanterafonseca/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcanterafonseca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcanterafonseca/subscriptions","organizations_url":"https://api.github.com/users/jmcanterafonseca/orgs","repos_url":"https://api.github.com/users/jmcanterafonseca/repos","events_url":"https://api.github.com/users/jmcanterafonseca/events{/privacy}","received_events_url":"https://api.github.com/users/jmcanterafonseca/received_events","type":"User","site_admin":false},"body":"We need here two things:\r\n\r\nOne to put a comment indicating what the function does and what means each parameter. Probably we should find a better name for adjustPositions, may 'delta' or something similar, but in any case a name and not a verb","created_at":"2014-03-10T10:42:56Z","updated_at":"2014-03-10T10:42:56Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/16797#discussion_r10424582","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/16797","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/10424582"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/16797#discussion_r10424582"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/16797"}}}}