GitHub PullRequestEvent at 2014-12-05 00:22:13
Repository: excon
Actor: mathias
Payload: {"action":"opened","number":448,"pull_request":{"url":"https://api.github.com/repos/excon/excon/pulls/448","id":25540611,"html_url":"https://github.com/excon/excon/pull/448","diff_url":"https://github.com/excon/excon/pull/448.diff","patch_url":"https://github.com/excon/excon/pull/448.patch","issue_url":"https://api.github.com/repos/excon/excon/issues/448","number":448,"state":"open","locked":false,"title":"Deprecate omit_default_port option, add include_default_port option","user":{"login":"mathias","id":3340,"avatar_url":"https://avatars.githubusercontent.com/u/3340?v=3","gravatar_id":"","url":"https://api.github.com/users/mathias","html_url":"https://github.com/mathias","followers_url":"https://api.github.com/users/mathias/followers","following_url":"https://api.github.com/users/mathias/following{/other_user}","gists_url":"https://api.github.com/users/mathias/gists{/gist_id}","starred_url":"https://api.github.com/users/mathias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathias/subscriptions","organizations_url":"https://api.github.com/users/mathias/orgs","repos_url":"https://api.github.com/users/mathias/repos","events_url":"https://api.github.com/users/mathias/events{/privacy}","received_events_url":"https://api.github.com/users/mathias/received_events","type":"User","site_admin":false},"body":"- Port being added to URL can be forced by using include_default_port option\r\n- Simplifies some of the port addition code\r\n- Break out logic to determine if a default port is logic into its own method\r\n- Tests basic cases of scheme+port combinations\r\n\r\nThis is a **big change** in terms of default functionality, and I suspect it will affect the gem users enough that it is worth considering what kind of version bump it'd require.\r\n\r\nAdditionally, I'd like to have deprecation warnings when the `omit_default_port` option is used with Excon, but I am not sure which method to add the detection and warning output to. Thoughts?\r\n\r\nFixes #357. Per discussion in #357, this should only add the port to the URL when `include_default_port` is specified or the port was included in the original URL.","created_at":"2014-12-05T00:22:12Z","updated_at":"2014-12-05T00:22:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/excon/excon/pulls/448/commits","review_comments_url":"https://api.github.com/repos/excon/excon/pulls/448/comments","review_comment_url":"https://api.github.com/repos/excon/excon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/excon/excon/issues/448/comments","statuses_url":"https://api.github.com/repos/excon/excon/statuses/9d6e061ca401bd42425af0b931fa5e9d775a9529","head":{"label":"mathias:mg-omit-default-ports","ref":"mg-omit-default-ports","sha":"9d6e061ca401bd42425af0b931fa5e9d775a9529","user":{"login":"mathias","id":3340,"avatar_url":"https://avatars.githubusercontent.com/u/3340?v=3","gravatar_id":"","url":"https://api.github.com/users/mathias","html_url":"https://github.com/mathias","followers_url":"https://api.github.com/users/mathias/followers","following_url":"https://api.github.com/users/mathias/following{/other_user}","gists_url":"https://api.github.com/users/mathias/gists{/gist_id}","starred_url":"https://api.github.com/users/mathias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathias/subscriptions","organizations_url":"https://api.github.com/users/mathias/orgs","repos_url":"https://api.github.com/users/mathias/repos","events_url":"https://api.github.com/users/mathias/events{/privacy}","received_events_url":"https://api.github.com/users/mathias/received_events","type":"User","site_admin":false},"repo":{"id":27444485,"name":"excon","full_name":"mathias/excon","owner":{"login":"mathias","id":3340,"avatar_url":"https://avatars.githubusercontent.com/u/3340?v=3","gravatar_id":"","url":"https://api.github.com/users/mathias","html_url":"https://github.com/mathias","followers_url":"https://api.github.com/users/mathias/followers","following_url":"https://api.github.com/users/mathias/following{/other_user}","gists_url":"https://api.github.com/users/mathias/gists{/gist_id}","starred_url":"https://api.github.com/users/mathias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathias/subscriptions","organizations_url":"https://api.github.com/users/mathias/orgs","repos_url":"https://api.github.com/users/mathias/repos","events_url":"https://api.github.com/users/mathias/events{/privacy}","received_events_url":"https://api.github.com/users/mathias/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mathias/excon","description":"Usable, fast, simple HTTP 1.1 for Ruby","fork":true,"url":"https://api.github.com/repos/mathias/excon","forks_url":"https://api.github.com/repos/mathias/excon/forks","keys_url":"https://api.github.com/repos/mathias/excon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathias/excon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathias/excon/teams","hooks_url":"https://api.github.com/repos/mathias/excon/hooks","issue_events_url":"https://api.github.com/repos/mathias/excon/issues/events{/number}","events_url":"https://api.github.com/repos/mathias/excon/events","assignees_url":"https://api.github.com/repos/mathias/excon/assignees{/user}","branches_url":"https://api.github.com/repos/mathias/excon/branches{/branch}","tags_url":"https://api.github.com/repos/mathias/excon/tags","blobs_url":"https://api.github.com/repos/mathias/excon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathias/excon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathias/excon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathias/excon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathias/excon/statuses/{sha}","languages_url":"https://api.github.com/repos/mathias/excon/languages","stargazers_url":"https://api.github.com/repos/mathias/excon/stargazers","contributors_url":"https://api.github.com/repos/mathias/excon/contributors","subscribers_url":"https://api.github.com/repos/mathias/excon/subscribers","subscription_url":"https://api.github.com/repos/mathias/excon/subscription","commits_url":"https://api.github.com/repos/mathias/excon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathias/excon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathias/excon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathias/excon/issues/comments/{number}","contents_url":"https://api.github.com/repos/mathias/excon/contents/{+path}","compare_url":"https://api.github.com/repos/mathias/excon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathias/excon/merges","archive_url":"https://api.github.com/repos/mathias/excon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathias/excon/downloads","issues_url":"https://api.github.com/repos/mathias/excon/issues{/number}","pulls_url":"https://api.github.com/repos/mathias/excon/pulls{/number}","milestones_url":"https://api.github.com/repos/mathias/excon/milestones{/number}","notifications_url":"https://api.github.com/repos/mathias/excon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathias/excon/labels{/name}","releases_url":"https://api.github.com/repos/mathias/excon/releases{/id}","created_at":"2014-12-02T17:32:28Z","updated_at":"2014-12-04T23:39:25Z","pushed_at":"2014-12-05T00:09:47Z","git_url":"git://github.com/mathias/excon.git","ssh_url":"git@github.com:mathias/excon.git","clone_url":"https://github.com/mathias/excon.git","svn_url":"https://github.com/mathias/excon","homepage":"http://excon.io","size":1696,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"excon:master","ref":"master","sha":"0a0239452eb1e633d3b6785716f3810c5347429e","user":{"login":"excon","id":6210164,"avatar_url":"https://avatars.githubusercontent.com/u/6210164?v=3","gravatar_id":"","url":"https://api.github.com/users/excon","html_url":"https://github.com/excon","followers_url":"https://api.github.com/users/excon/followers","following_url":"https://api.github.com/users/excon/following{/other_user}","gists_url":"https://api.github.com/users/excon/gists{/gist_id}","starred_url":"https://api.github.com/users/excon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excon/subscriptions","organizations_url":"https://api.github.com/users/excon/orgs","repos_url":"https://api.github.com/users/excon/repos","events_url":"https://api.github.com/users/excon/events{/privacy}","received_events_url":"https://api.github.com/users/excon/received_events","type":"Organization","site_admin":false},"repo":{"id":349203,"name":"excon","full_name":"excon/excon","owner":{"login":"excon","id":6210164,"avatar_url":"https://avatars.githubusercontent.com/u/6210164?v=3","gravatar_id":"","url":"https://api.github.com/users/excon","html_url":"https://github.com/excon","followers_url":"https://api.github.com/users/excon/followers","following_url":"https://api.github.com/users/excon/following{/other_user}","gists_url":"https://api.github.com/users/excon/gists{/gist_id}","starred_url":"https://api.github.com/users/excon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excon/subscriptions","organizations_url":"https://api.github.com/users/excon/orgs","repos_url":"https://api.github.com/users/excon/repos","events_url":"https://api.github.com/users/excon/events{/privacy}","received_events_url":"https://api.github.com/users/excon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/excon/excon","description":"Usable, fast, simple HTTP 1.1 for Ruby","fork":false,"url":"https://api.github.com/repos/excon/excon","forks_url":"https://api.github.com/repos/excon/excon/forks","keys_url":"https://api.github.com/repos/excon/excon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/excon/excon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/excon/excon/teams","hooks_url":"https://api.github.com/repos/excon/excon/hooks","issue_events_url":"https://api.github.com/repos/excon/excon/issues/events{/number}","events_url":"https://api.github.com/repos/excon/excon/events","assignees_url":"https://api.github.com/repos/excon/excon/assignees{/user}","branches_url":"https://api.github.com/repos/excon/excon/branches{/branch}","tags_url":"https://api.github.com/repos/excon/excon/tags","blobs_url":"https://api.github.com/repos/excon/excon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/excon/excon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/excon/excon/git/refs{/sha}","trees_url":"https://api.github.com/repos/excon/excon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/excon/excon/statuses/{sha}","languages_url":"https://api.github.com/repos/excon/excon/languages","stargazers_url":"https://api.github.com/repos/excon/excon/stargazers","contributors_url":"https://api.github.com/repos/excon/excon/contributors","subscribers_url":"https://api.github.com/repos/excon/excon/subscribers","subscription_url":"https://api.github.com/repos/excon/excon/subscription","commits_url":"https://api.github.com/repos/excon/excon/commits{/sha}","git_commits_url":"https://api.github.com/repos/excon/excon/git/commits{/sha}","comments_url":"https://api.github.com/repos/excon/excon/comments{/number}","issue_comment_url":"https://api.github.com/repos/excon/excon/issues/comments/{number}","contents_url":"https://api.github.com/repos/excon/excon/contents/{+path}","compare_url":"https://api.github.com/repos/excon/excon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/excon/excon/merges","archive_url":"https://api.github.com/repos/excon/excon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/excon/excon/downloads","issues_url":"https://api.github.com/repos/excon/excon/issues{/number}","pulls_url":"https://api.github.com/repos/excon/excon/pulls{/number}","milestones_url":"https://api.github.com/repos/excon/excon/milestones{/number}","notifications_url":"https://api.github.com/repos/excon/excon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/excon/excon/labels{/name}","releases_url":"https://api.github.com/repos/excon/excon/releases{/id}","created_at":"2009-10-25T17:50:46Z","updated_at":"2014-12-04T15:39:32Z","pushed_at":"2014-12-04T15:39:33Z","git_url":"git://github.com/excon/excon.git","ssh_url":"git@github.com:excon/excon.git","clone_url":"https://github.com/excon/excon.git","svn_url":"https://github.com/excon/excon","homepage":"http://excon.io","size":3196,"stargazers_count":549,"watchers_count":549,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"open_issues_count":48,"forks":130,"open_issues":48,"watchers":549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/excon/excon/pulls/448"},"html":{"href":"https://github.com/excon/excon/pull/448"},"issue":{"href":"https://api.github.com/repos/excon/excon/issues/448"},"comments":{"href":"https://api.github.com/repos/excon/excon/issues/448/comments"},"review_comments":{"href":"https://api.github.com/repos/excon/excon/pulls/448/comments"},"review_comment":{"href":"https://api.github.com/repos/excon/excon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/excon/excon/pulls/448/commits"},"statuses":{"href":"https://api.github.com/repos/excon/excon/statuses/9d6e061ca401bd42425af0b931fa5e9d775a9529"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":64,"deletions":15,"changed_files":5}}