GitHub PullRequestReviewCommentEvent at 2014-07-20 23:30:35
Repository: fleet
Actor: jonboulle
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/fleet/pulls/comments/15152759","id":15152759,"diff_hunk":"@@ -171,10 +171,11 @@ func (r *dumbReconciler) Reconcile() {\n \t\t\tcontinue\n \t\t}\n \n-\t\tlog.Infof(\"Attempting to schedule Job(%s) since target state %s and Job not scheduled\", j.Name, j.TargetState)\n+\t\tlog.V(1).Infof(\"Attempting to schedule Job(%s) since target state %s and Job not scheduled\", j.Name, j.TargetState)\n \n-\t\terr := maybeScheduleJob(j.Name)\n-\t\tif err != nil {\n+\t\tscheduled := scheduleJob(j.Name)","path":"engine/dumb-reconciler.go","position":48,"original_position":48,"commit_id":"a5a94f7a9de9239350a4626d5b6560d7600144e8","original_commit_id":"a5a94f7a9de9239350a4626d5b6560d7600144e8","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?","gravatar_id":"0f0b8b324fd58974000aacebb9b66c65","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":"I would just collapse the if here, no need for a new variable","created_at":"2014-07-20T23:30:35Z","updated_at":"2014-07-20T23:30:35Z","html_url":"https://github.com/coreos/fleet/pull/690#discussion_r15152759","pull_request_url":"https://api.github.com/repos/coreos/fleet/pulls/690","_links":{"self":{"href":"https://api.github.com/repos/coreos/fleet/pulls/comments/15152759"},"html":{"href":"https://github.com/coreos/fleet/pull/690#discussion_r15152759"},"pull_request":{"href":"https://api.github.com/repos/coreos/fleet/pulls/690"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/fleet/pulls/690","id":18633806,"html_url":"https://github.com/coreos/fleet/pull/690","diff_url":"https://github.com/coreos/fleet/pull/690.diff","patch_url":"https://github.com/coreos/fleet/pull/690.patch","issue_url":"https://api.github.com/repos/coreos/fleet/issues/690","number":690,"state":"open","title":"engine: do not resolve offer due to zero bids","user":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?","gravatar_id":"3fa4bd3403b1a81ac43f4769c8f74b66","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"body":"There's no need to attempt to resolve a bid just because it has zero bids. This causes a lot of churn in the creation and deletion of offers. Make log levels more meaningful, too.","created_at":"2014-07-20T21:29:38Z","updated_at":"2014-07-20T23:30:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e832bdfb28d85ae634dbc00fe5bb27bea596440","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/fleet/pulls/690/commits","review_comments_url":"https://api.github.com/repos/coreos/fleet/pulls/690/comments","review_comment_url":"https://api.github.com/repos/coreos/fleet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/coreos/fleet/issues/690/comments","statuses_url":"https://api.github.com/repos/coreos/fleet/statuses/a5a94f7a9de9239350a4626d5b6560d7600144e8","head":{"label":"bcwaldon:no-resolve-zero-bids","ref":"no-resolve-zero-bids","sha":"a5a94f7a9de9239350a4626d5b6560d7600144e8","user":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?","gravatar_id":"3fa4bd3403b1a81ac43f4769c8f74b66","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"repo":{"id":14316614,"name":"fleet","full_name":"bcwaldon/fleet","owner":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?","gravatar_id":"3fa4bd3403b1a81ac43f4769c8f74b66","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcwaldon/fleet","description":"","fork":true,"url":"https://api.github.com/repos/bcwaldon/fleet","forks_url":"https://api.github.com/repos/bcwaldon/fleet/forks","keys_url":"https://api.github.com/repos/bcwaldon/fleet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcwaldon/fleet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcwaldon/fleet/teams","hooks_url":"https://api.github.com/repos/bcwaldon/fleet/hooks","issue_events_url":"https://api.github.com/repos/bcwaldon/fleet/issues/events{/number}","events_url":"https://api.github.com/repos/bcwaldon/fleet/events","assignees_url":"https://api.github.com/repos/bcwaldon/fleet/assignees{/user}","branches_url":"https://api.github.com/repos/bcwaldon/fleet/branches{/branch}","tags_url":"https://api.github.com/repos/bcwaldon/fleet/tags","blobs_url":"https://api.github.com/repos/bcwaldon/fleet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcwaldon/fleet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcwaldon/fleet/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcwaldon/fleet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcwaldon/fleet/statuses/{sha}","languages_url":"https://api.github.com/repos/bcwaldon/fleet/languages","stargazers_url":"https://api.github.com/repos/bcwaldon/fleet/stargazers","contributors_url":"https://api.github.com/repos/bcwaldon/fleet/contributors","subscribers_url":"https://api.github.com/repos/bcwaldon/fleet/subscribers","subscription_url":"https://api.github.com/repos/bcwaldon/fleet/subscription","commits_url":"https://api.github.com/repos/bcwaldon/fleet/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcwaldon/fleet/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcwaldon/fleet/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcwaldon/fleet/issues/comments/{number}","contents_url":"https://api.github.com/repos/bcwaldon/fleet/contents/{+path}","compare_url":"https://api.github.com/repos/bcwaldon/fleet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcwaldon/fleet/merges","archive_url":"https://api.github.com/repos/bcwaldon/fleet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcwaldon/fleet/downloads","issues_url":"https://api.github.com/repos/bcwaldon/fleet/issues{/number}","pulls_url":"https://api.github.com/repos/bcwaldon/fleet/pulls{/number}","milestones_url":"https://api.github.com/repos/bcwaldon/fleet/milestones{/number}","notifications_url":"https://api.github.com/repos/bcwaldon/fleet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcwaldon/fleet/labels{/name}","releases_url":"https://api.github.com/repos/bcwaldon/fleet/releases{/id}","created_at":"2013-11-11T23:26:02Z","updated_at":"2014-06-25T00:17:24Z","pushed_at":"2014-07-20T23:26:01Z","git_url":"git://github.com/bcwaldon/fleet.git","ssh_url":"git@github.com:bcwaldon/fleet.git","clone_url":"https://github.com/bcwaldon/fleet.git","svn_url":"https://github.com/bcwaldon/fleet","homepage":null,"size":11189,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"8fba5b8850c58454d302c097325bc68b3a372cac","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?","gravatar_id":"f477564b23efc2dd243407e926976125","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":13512328,"name":"fleet","full_name":"coreos/fleet","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?","gravatar_id":"f477564b23efc2dd243407e926976125","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/fleet","description":"A Distributed init System","fork":false,"url":"https://api.github.com/repos/coreos/fleet","forks_url":"https://api.github.com/repos/coreos/fleet/forks","keys_url":"https://api.github.com/repos/coreos/fleet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/fleet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/fleet/teams","hooks_url":"https://api.github.com/repos/coreos/fleet/hooks","issue_events_url":"https://api.github.com/repos/coreos/fleet/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/fleet/events","assignees_url":"https://api.github.com/repos/coreos/fleet/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/fleet/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/fleet/tags","blobs_url":"https://api.github.com/repos/coreos/fleet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/fleet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/fleet/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/fleet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/fleet/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/fleet/languages","stargazers_url":"https://api.github.com/repos/coreos/fleet/stargazers","contributors_url":"https://api.github.com/repos/coreos/fleet/contributors","subscribers_url":"https://api.github.com/repos/coreos/fleet/subscribers","subscription_url":"https://api.github.com/repos/coreos/fleet/subscription","commits_url":"https://api.github.com/repos/coreos/fleet/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/fleet/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/fleet/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/fleet/issues/comments/{number}","contents_url":"https://api.github.com/repos/coreos/fleet/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/fleet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/fleet/merges","archive_url":"https://api.github.com/repos/coreos/fleet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/fleet/downloads","issues_url":"https://api.github.com/repos/coreos/fleet/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/fleet/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/fleet/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/fleet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/fleet/labels{/name}","releases_url":"https://api.github.com/repos/coreos/fleet/releases{/id}","created_at":"2013-10-11T23:56:38Z","updated_at":"2014-07-20T21:59:34Z","pushed_at":"2014-07-20T23:21:23Z","git_url":"git://github.com/coreos/fleet.git","ssh_url":"git@github.com:coreos/fleet.git","clone_url":"https://github.com/coreos/fleet.git","svn_url":"https://github.com/coreos/fleet","homepage":"","size":15875,"stargazers_count":845,"watchers_count":845,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":77,"mirror_url":null,"open_issues_count":56,"forks":77,"open_issues":56,"watchers":845,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/fleet/pulls/690"},"html":{"href":"https://github.com/coreos/fleet/pull/690"},"issue":{"href":"https://api.github.com/repos/coreos/fleet/issues/690"},"comments":{"href":"https://api.github.com/repos/coreos/fleet/issues/690/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/fleet/pulls/690/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/fleet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/coreos/fleet/pulls/690/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/fleet/statuses/a5a94f7a9de9239350a4626d5b6560d7600144e8"}}}}