GitHub PullRequestReviewCommentEvent at 2014-08-06 15:08:26
Repository: edx-platform
Actor: gwprice
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/15879958","id":15879958,"diff_hunk":"@@ -565,119 +205,33 @@ body.discussion {\n     .discussion-response {\n       @include box-sizing(border-box);\n       border-radius: 3px 3px 0 0;\n-      padding: $baseline $baseline 0;\n+      padding: $baseline $baseline ($baseline/2);\n       background-color: $white;\n     }\n+\n     .posted-by {\n       font-weight: 700;\n     }\n   }\n \n-  .add-response {\n+  .add-response-btn {\n+    display: inline-block;","path":"lms/static/sass/discussion/_discussion.scss","position":502,"original_position":502,"commit_id":"58eadcb1d111ffadd53af2f0597d130229739e7b","original_commit_id":"58eadcb1d111ffadd53af2f0597d130229739e7b","user":{"login":"gwprice","id":4027165,"avatar_url":"https://avatars.githubusercontent.com/u/4027165?v=2","gravatar_id":"12245ad9b7a2b9c562375f6a790fe784","url":"https://api.github.com/users/gwprice","html_url":"https://github.com/gwprice","followers_url":"https://api.github.com/users/gwprice/followers","following_url":"https://api.github.com/users/gwprice/following{/other_user}","gists_url":"https://api.github.com/users/gwprice/gists{/gist_id}","starred_url":"https://api.github.com/users/gwprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwprice/subscriptions","organizations_url":"https://api.github.com/users/gwprice/orgs","repos_url":"https://api.github.com/users/gwprice/repos","events_url":"https://api.github.com/users/gwprice/events{/privacy}","received_events_url":"https://api.github.com/users/gwprice/received_events","type":"User","site_admin":false},"body":"I understand what it's doing, but it's out of scope for this story.","created_at":"2014-08-06T15:08:26Z","updated_at":"2014-08-06T15:08:26Z","html_url":"https://github.com/edx/edx-platform/pull/4509#discussion_r15879958","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/4509","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/15879958"},"html":{"href":"https://github.com/edx/edx-platform/pull/4509#discussion_r15879958"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4509"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/4509","id":18678676,"html_url":"https://github.com/edx/edx-platform/pull/4509","diff_url":"https://github.com/edx/edx-platform/pull/4509.diff","patch_url":"https://github.com/edx/edx-platform/pull/4509.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/4509","number":4509,"state":"open","title":"sass cleanup for action elements, home and profile views.","user":{"login":"marcotuts","id":2023680,"avatar_url":"https://avatars.githubusercontent.com/u/2023680?v=2","gravatar_id":"9fcf487dfe65dabe4d29f1ac7865e82e","url":"https://api.github.com/users/marcotuts","html_url":"https://github.com/marcotuts","followers_url":"https://api.github.com/users/marcotuts/followers","following_url":"https://api.github.com/users/marcotuts/following{/other_user}","gists_url":"https://api.github.com/users/marcotuts/gists{/gist_id}","starred_url":"https://api.github.com/users/marcotuts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcotuts/subscriptions","organizations_url":"https://api.github.com/users/marcotuts/orgs","repos_url":"https://api.github.com/users/marcotuts/repos","events_url":"https://api.github.com/users/marcotuts/events{/privacy}","received_events_url":"https://api.github.com/users/marcotuts/received_events","type":"User","site_admin":false},"body":"This styling cleanup separates out the actions from the larger discussion scss file in preparation for general action cleanup to be completed on this branch off of master. \r\n\r\nThere are no styling changes here, just changes to where the styles are being imported from. \r\n\r\n@gwprice  - We can discuss this tomorrow during standup. The goal with this PR would be to help us think about how we would like to organize our sass files prior to making any styling changes for the post actions. ","created_at":"2014-07-21T20:43:32Z","updated_at":"2014-08-06T15:08:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8678251b415b5ca6a8490c42ed9de68c2ee82935","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/4509/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/4509/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/4509/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/58eadcb1d111ffadd53af2f0597d130229739e7b","head":{"label":"edx:marco/forums/styling-cleanup","ref":"marco/forums/styling-cleanup","sha":"58eadcb1d111ffadd53af2f0597d130229739e7b","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-08-06T07:46:04Z","pushed_at":"2014-08-06T15:05:46Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1533099,"stargazers_count":1349,"watchers_count":1349,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":754,"mirror_url":null,"open_issues_count":175,"forks":754,"open_issues":175,"watchers":1349,"default_branch":"master"}},"base":{"label":"edx:forums/new-post-type","ref":"forums/new-post-type","sha":"6faf472caea7837ed5bb4244190f01541d774a17","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=2","gravatar_id":"e1f6c6dc8772c47c0261cd5df2ed2814","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2014-08-06T07:46:04Z","pushed_at":"2014-08-06T15:05:46Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1533099,"stargazers_count":1349,"watchers_count":1349,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":754,"mirror_url":null,"open_issues_count":175,"forks":754,"open_issues":175,"watchers":1349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4509"},"html":{"href":"https://github.com/edx/edx-platform/pull/4509"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/4509"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/4509/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4509/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/4509/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/58eadcb1d111ffadd53af2f0597d130229739e7b"}}}}