GitHub PullRequestReviewCommentEvent at 2014-06-17 07:44:05
Repository: fiware-orion
Actor: LeandroGuillen
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments/13846415","id":13846415,"diff_hunk":"@@ -45,7 +45,12 @@ HttpStatusCode mongoNotifyContext(NotifyContextRequest* requestP, NotifyContextR\n     for (unsigned int ix = 0; ix < requestP->contextElementResponseVector.size(); ++ix) {\n         /* We use 'ucr' to conform processContextElement signature but we are not doing anything with that */\n         UpdateContextResponse ucr;\n-        processContextElement(&requestP->contextElementResponseVector.get(ix)->contextElement, &ucr, \"append\", tenant, \"\");\n+\n+        // FIXME P10: we need to pass an empty service path vector in order to fullfill the processContextElement signature(). To review,","path":"src/lib/mongoBackend/mongoNotifyContext.cpp","position":6,"original_position":6,"commit_id":"39140ad879f603df01cf2c5388da5a11bc849e2d","original_commit_id":"39140ad879f603df01cf2c5388da5a11bc849e2d","user":{"login":"LeandroGuillen","id":347884,"avatar_url":"https://avatars.githubusercontent.com/u/347884?","gravatar_id":"23243570146fc7042272d8650747eb0c","url":"https://api.github.com/users/LeandroGuillen","html_url":"https://github.com/LeandroGuillen","followers_url":"https://api.github.com/users/LeandroGuillen/followers","following_url":"https://api.github.com/users/LeandroGuillen/following{/other_user}","gists_url":"https://api.github.com/users/LeandroGuillen/gists{/gist_id}","starred_url":"https://api.github.com/users/LeandroGuillen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeandroGuillen/subscriptions","organizations_url":"https://api.github.com/users/LeandroGuillen/orgs","repos_url":"https://api.github.com/users/LeandroGuillen/repos","events_url":"https://api.github.com/users/LeandroGuillen/events{/privacy}","received_events_url":"https://api.github.com/users/LeandroGuillen/received_events","type":"User","site_admin":false},"body":"typo: \"fullfill\" -> \"fulfill\"","created_at":"2014-06-17T07:44:05Z","updated_at":"2014-06-17T07:44:05Z","html_url":"https://github.com/telefonicaid/fiware-orion/pull/418#discussion_r13846415","pull_request_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/418","_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments/13846415"},"html":{"href":"https://github.com/telefonicaid/fiware-orion/pull/418#discussion_r13846415"},"pull_request":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/418"}}},"pull_request":{"url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/418","id":17187606,"html_url":"https://github.com/telefonicaid/fiware-orion/pull/418","diff_url":"https://github.com/telefonicaid/fiware-orion/pull/418.diff","patch_url":"https://github.com/telefonicaid/fiware-orion/pull/418.patch","issue_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/418","number":418,"state":"open","title":"Multi servicePath implemented","user":{"login":"fgalan","id":1534240,"avatar_url":"https://avatars.githubusercontent.com/u/1534240?","gravatar_id":"1936b0d16210811a2aa8de96295f0693","url":"https://api.github.com/users/fgalan","html_url":"https://github.com/fgalan","followers_url":"https://api.github.com/users/fgalan/followers","following_url":"https://api.github.com/users/fgalan/following{/other_user}","gists_url":"https://api.github.com/users/fgalan/gists{/gist_id}","starred_url":"https://api.github.com/users/fgalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgalan/subscriptions","organizations_url":"https://api.github.com/users/fgalan/orgs","repos_url":"https://api.github.com/users/fgalan/repos","events_url":"https://api.github.com/users/fgalan/events{/privacy}","received_events_url":"https://api.github.com/users/fgalan/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-06-16T16:22:15Z","updated_at":"2014-06-17T07:44:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cd2b30b124152b44cb1fe14b768605690fda0a4","assignee":{"login":"LeandroGuillen","id":347884,"avatar_url":"https://avatars.githubusercontent.com/u/347884?","gravatar_id":"23243570146fc7042272d8650747eb0c","url":"https://api.github.com/users/LeandroGuillen","html_url":"https://github.com/LeandroGuillen","followers_url":"https://api.github.com/users/LeandroGuillen/followers","following_url":"https://api.github.com/users/LeandroGuillen/following{/other_user}","gists_url":"https://api.github.com/users/LeandroGuillen/gists{/gist_id}","starred_url":"https://api.github.com/users/LeandroGuillen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeandroGuillen/subscriptions","organizations_url":"https://api.github.com/users/LeandroGuillen/orgs","repos_url":"https://api.github.com/users/LeandroGuillen/repos","events_url":"https://api.github.com/users/LeandroGuillen/events{/privacy}","received_events_url":"https://api.github.com/users/LeandroGuillen/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/418/commits","review_comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/418/comments","review_comment_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments/{number}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/418/comments","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/39140ad879f603df01cf2c5388da5a11bc849e2d","head":{"label":"telefonicaid:task/392_vector_mongoBackend","ref":"task/392_vector_mongoBackend","sha":"39140ad879f603df01cf2c5388da5a11bc849e2d","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?","gravatar_id":"05c84be2ce3d0a014ac4253156a1eaff","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":12808420,"name":"fiware-orion","full_name":"telefonicaid/fiware-orion","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?","gravatar_id":"05c84be2ce3d0a014ac4253156a1eaff","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-orion","description":"FI-WARE Orion Context Broker","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-orion","forks_url":"https://api.github.com/repos/telefonicaid/fiware-orion/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-orion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-orion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-orion/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-orion/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-orion/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-orion/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-orion/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-orion/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-orion/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-orion/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-orion/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-orion/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/comments/{number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-orion/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-orion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-orion/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-orion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-orion/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-orion/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-orion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-orion/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-orion/releases{/id}","created_at":"2013-09-13T11:55:25Z","updated_at":"2014-06-16T16:26:20Z","pushed_at":"2014-06-16T16:26:20Z","git_url":"git://github.com/telefonicaid/fiware-orion.git","ssh_url":"git@github.com:telefonicaid/fiware-orion.git","clone_url":"https://github.com/telefonicaid/fiware-orion.git","svn_url":"https://github.com/telefonicaid/fiware-orion","homepage":"http://catalogue.fi-ware.eu/enablers/publishsubscribe-context-broker-orion-context-broker","size":11105,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":97,"forks":8,"open_issues":97,"watchers":6,"default_branch":"develop"}},"base":{"label":"telefonicaid:feature/392_servicePath_in_query_update_context","ref":"feature/392_servicePath_in_query_update_context","sha":"f5b6c3df00ea9db35b30fa06c0cdeecb651f888c","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?","gravatar_id":"05c84be2ce3d0a014ac4253156a1eaff","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":12808420,"name":"fiware-orion","full_name":"telefonicaid/fiware-orion","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?","gravatar_id":"05c84be2ce3d0a014ac4253156a1eaff","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-orion","description":"FI-WARE Orion Context Broker","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-orion","forks_url":"https://api.github.com/repos/telefonicaid/fiware-orion/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-orion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-orion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-orion/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-orion/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-orion/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-orion/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-orion/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-orion/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-orion/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-orion/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-orion/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-orion/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/comments/{number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-orion/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-orion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-orion/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-orion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-orion/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-orion/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-orion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-orion/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-orion/releases{/id}","created_at":"2013-09-13T11:55:25Z","updated_at":"2014-06-16T16:26:20Z","pushed_at":"2014-06-16T16:26:20Z","git_url":"git://github.com/telefonicaid/fiware-orion.git","ssh_url":"git@github.com:telefonicaid/fiware-orion.git","clone_url":"https://github.com/telefonicaid/fiware-orion.git","svn_url":"https://github.com/telefonicaid/fiware-orion","homepage":"http://catalogue.fi-ware.eu/enablers/publishsubscribe-context-broker-orion-context-broker","size":11105,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":8,"mirror_url":null,"open_issues_count":97,"forks":8,"open_issues":97,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/418"},"html":{"href":"https://github.com/telefonicaid/fiware-orion/pull/418"},"issue":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/418"},"comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/39140ad879f603df01cf2c5388da5a11bc849e2d"}}}}