GitHub PullRequestReviewCommentEvent at 2014-03-28 05:31:48
Repository: zol
Actor: NintenJoe
Payload: {"comment":{"url":"https://api.github.com/repos/NintenJoe/zol/pulls/comments/11055650","id":11055650,"diff_hunk":"@@ -38,17 +38,17 @@ def __init__( self, identifier, (vx, vy) ):\n     def _calc_step_changes( self, time_delta ):\n         deltax = self._vx * time_delta;\n         deltay = self._vy * time_delta;\n-        return PhysicalState(PG.Rect(0, 0, deltax, deltay), (0, 0), 0.0)\n+        return PhysicalState(PG.Rect(deltax, deltay, 0, 0), (0, 0), 0.0)\n \n     ##  Returns an empty set of physical changes.\n     #\n     #   @override\n     def _calc_arrival_changes( self ):\n-        return PhysicalState()\n+        return PhysicalState(PG.Rect(0, 0, 0, 0), (self._vx, self._vy), 0.0)","path":"src/MoveState.py","position":12,"original_position":12,"commit_id":"022287c2221fb3889b933f12d09faa6384edb085","original_commit_id":"022287c2221fb3889b933f12d09faa6384edb085","user":{"login":"NintenJoe","id":1787437,"avatar_url":"https://avatars.githubusercontent.com/u/1787437?","gravatar_id":"b92ee84b0adc7a37dae53b9fbf46dbbd","url":"https://api.github.com/users/NintenJoe","html_url":"https://github.com/NintenJoe","followers_url":"https://api.github.com/users/NintenJoe/followers","following_url":"https://api.github.com/users/NintenJoe/following{/other_user}","gists_url":"https://api.github.com/users/NintenJoe/gists{/gist_id}","starred_url":"https://api.github.com/users/NintenJoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NintenJoe/subscriptions","organizations_url":"https://api.github.com/users/NintenJoe/orgs","repos_url":"https://api.github.com/users/NintenJoe/repos","events_url":"https://api.github.com/users/NintenJoe/events{/privacy}","received_events_url":"https://api.github.com/users/NintenJoe/received_events","type":"User","site_admin":false},"body":"Definitely agree with this change.  I think that the behavior of causing a change on arrival and reverting that change on departure will be common, so it may be worthwhile to extend the 'State' class to support this kind of behavior (or to implement a secondary class and utilize multiple inheritance).","created_at":"2014-03-28T05:31:48Z","updated_at":"2014-03-28T05:31:48Z","html_url":"https://github.com/NintenJoe/zol/pull/16#discussion_r11055650","pull_request_url":"https://api.github.com/repos/NintenJoe/zol/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/NintenJoe/zol/pulls/comments/11055650"},"html":{"href":"https://github.com/NintenJoe/zol/pull/16#discussion_r11055650"},"pull_request":{"href":"https://api.github.com/repos/NintenJoe/zol/pulls/16"}}}}