GitHub PullRequestReviewCommentEvent at 2014-11-26 08:23:19
Repository: obexd
Actor: saukko
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/nemomobile-packages/obexd/pulls/comments/20921429","id":20921429,"diff_hunk":"@@ -433,16 +504,31 @@ static void fetch_many_cb(DBusPendingCall *pend,\n \t\tDBG(\"id: %s, name: %s, tel:%s, vcard: %s\",\n \t\t\tid, name, tel, vcard);\n \t\t(data->process)(data, id, name, tel, vcard);\n+\t\tresults++;\n \n \t\tdbus_message_iter_next(&array_iter);\n \t}\n \n done:\n+\tDBG(\"%u results received, now at offset %u (ending at %u)\",\n+\t\tresults, data->chunk_offset, data->chunk_end);\n+\n \tdbus_message_unref(reply);\n \tdbus_pending_call_unref(data->pend);\n \tdata->pend = NULL;\n \n-\t(data->process_end)(data);\n+\tdata->chunk_offset += results;\n+\n+\tif (results == data->chunk_length &&\n+\t\t\tdata->chunk_offset < data->chunk_end) {\n+\t\t/* Full chunk read but not at the end -> read more later */\n+\t\t(data->process_end)(data, FALSE);\n+\n+\t} else {\n+\t\t/* Everything read or error */\n+\t\t(data->process_end)(data, TRUE);\n+","path":"obexd/plugins/phonebook-sailfish.c","position":194,"original_position":194,"commit_id":"158e15e47b85c5a097bbd9fd81b5c2c382bde86a","original_commit_id":"158e15e47b85c5a097bbd9fd81b5c2c382bde86a","user":{"login":"saukko","id":990755,"avatar_url":"https://avatars.githubusercontent.com/u/990755?v=3","gravatar_id":"","url":"https://api.github.com/users/saukko","html_url":"https://github.com/saukko","followers_url":"https://api.github.com/users/saukko/followers","following_url":"https://api.github.com/users/saukko/following{/other_user}","gists_url":"https://api.github.com/users/saukko/gists{/gist_id}","starred_url":"https://api.github.com/users/saukko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saukko/subscriptions","organizations_url":"https://api.github.com/users/saukko/orgs","repos_url":"https://api.github.com/users/saukko/repos","events_url":"https://api.github.com/users/saukko/events{/privacy}","received_events_url":"https://api.github.com/users/saukko/received_events","type":"User","site_admin":false},"body":"empty lines here and above.","created_at":"2014-11-26T08:23:19Z","updated_at":"2014-11-26T08:23:19Z","html_url":"https://github.com/nemomobile-packages/obexd/pull/22#discussion_r20921429","pull_request_url":"https://api.github.com/repos/nemomobile-packages/obexd/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/nemomobile-packages/obexd/pulls/comments/20921429"},"html":{"href":"https://github.com/nemomobile-packages/obexd/pull/22#discussion_r20921429"},"pull_request":{"href":"https://api.github.com/repos/nemomobile-packages/obexd/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/nemomobile-packages/obexd/pulls/22","id":25066027,"html_url":"https://github.com/nemomobile-packages/obexd/pull/22","diff_url":"https://github.com/nemomobile-packages/obexd/pull/22.diff","patch_url":"https://github.com/nemomobile-packages/obexd/pull/22.patch","issue_url":"https://api.github.com/repos/nemomobile-packages/obexd/issues/22","number":22,"state":"open","locked":false,"title":"Pbap request optimization","user":{"login":"hmallat","id":1729813,"avatar_url":"https://avatars.githubusercontent.com/u/1729813?v=3","gravatar_id":"","url":"https://api.github.com/users/hmallat","html_url":"https://github.com/hmallat","followers_url":"https://api.github.com/users/hmallat/followers","following_url":"https://api.github.com/users/hmallat/following{/other_user}","gists_url":"https://api.github.com/users/hmallat/gists{/gist_id}","starred_url":"https://api.github.com/users/hmallat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmallat/subscriptions","organizations_url":"https://api.github.com/users/hmallat/orgs","repos_url":"https://api.github.com/users/hmallat/repos","events_url":"https://api.github.com/users/hmallat/events{/privacy}","received_events_url":"https://api.github.com/users/hmallat/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-11-26T07:42:20Z","updated_at":"2014-11-26T08:23:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"566cf818f0c62ccd62179bb57b55783421572a15","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nemomobile-packages/obexd/pulls/22/commits","review_comments_url":"https://api.github.com/repos/nemomobile-packages/obexd/pulls/22/comments","review_comment_url":"https://api.github.com/repos/nemomobile-packages/obexd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nemomobile-packages/obexd/issues/22/comments","statuses_url":"https://api.github.com/repos/nemomobile-packages/obexd/statuses/158e15e47b85c5a097bbd9fd81b5c2c382bde86a","head":{"label":"hmallat:PBAP-request-optimization","ref":"PBAP-request-optimization","sha":"158e15e47b85c5a097bbd9fd81b5c2c382bde86a","user":{"login":"hmallat","id":1729813,"avatar_url":"https://avatars.githubusercontent.com/u/1729813?v=3","gravatar_id":"","url":"https://api.github.com/users/hmallat","html_url":"https://github.com/hmallat","followers_url":"https://api.github.com/users/hmallat/followers","following_url":"https://api.github.com/users/hmallat/following{/other_user}","gists_url":"https://api.github.com/users/hmallat/gists{/gist_id}","starred_url":"https://api.github.com/users/hmallat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmallat/subscriptions","organizations_url":"https://api.github.com/users/hmallat/orgs","repos_url":"https://api.github.com/users/hmallat/repos","events_url":"https://api.github.com/users/hmallat/events{/privacy}","received_events_url":"https://api.github.com/users/hmallat/received_events","type":"User","site_admin":false},"repo":{"id":13171419,"name":"obexd","full_name":"hmallat/obexd","owner":{"login":"hmallat","id":1729813,"avatar_url":"https://avatars.githubusercontent.com/u/1729813?v=3","gravatar_id":"","url":"https://api.github.com/users/hmallat","html_url":"https://github.com/hmallat","followers_url":"https://api.github.com/users/hmallat/followers","following_url":"https://api.github.com/users/hmallat/following{/other_user}","gists_url":"https://api.github.com/users/hmallat/gists{/gist_id}","starred_url":"https://api.github.com/users/hmallat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmallat/subscriptions","organizations_url":"https://api.github.com/users/hmallat/orgs","repos_url":"https://api.github.com/users/hmallat/repos","events_url":"https://api.github.com/users/hmallat/events{/privacy}","received_events_url":"https://api.github.com/users/hmallat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hmallat/obexd","description":null,"fork":true,"url":"https://api.github.com/repos/hmallat/obexd","forks_url":"https://api.github.com/repos/hmallat/obexd/forks","keys_url":"https://api.github.com/repos/hmallat/obexd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmallat/obexd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmallat/obexd/teams","hooks_url":"https://api.github.com/repos/hmallat/obexd/hooks","issue_events_url":"https://api.github.com/repos/hmallat/obexd/issues/events{/number}","events_url":"https://api.github.com/repos/hmallat/obexd/events","assignees_url":"https://api.github.com/repos/hmallat/obexd/assignees{/user}","branches_url":"https://api.github.com/repos/hmallat/obexd/branches{/branch}","tags_url":"https://api.github.com/repos/hmallat/obexd/tags","blobs_url":"https://api.github.com/repos/hmallat/obexd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmallat/obexd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmallat/obexd/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmallat/obexd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmallat/obexd/statuses/{sha}","languages_url":"https://api.github.com/repos/hmallat/obexd/languages","stargazers_url":"https://api.github.com/repos/hmallat/obexd/stargazers","contributors_url":"https://api.github.com/repos/hmallat/obexd/contributors","subscribers_url":"https://api.github.com/repos/hmallat/obexd/subscribers","subscription_url":"https://api.github.com/repos/hmallat/obexd/subscription","commits_url":"https://api.github.com/repos/hmallat/obexd/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmallat/obexd/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmallat/obexd/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmallat/obexd/issues/comments/{number}","contents_url":"https://api.github.com/repos/hmallat/obexd/contents/{+path}","compare_url":"https://api.github.com/repos/hmallat/obexd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmallat/obexd/merges","archive_url":"https://api.github.com/repos/hmallat/obexd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmallat/obexd/downloads","issues_url":"https://api.github.com/repos/hmallat/obexd/issues{/number}","pulls_url":"https://api.github.com/repos/hmallat/obexd/pulls{/number}","milestones_url":"https://api.github.com/repos/hmallat/obexd/milestones{/number}","notifications_url":"https://api.github.com/repos/hmallat/obexd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmallat/obexd/labels{/name}","releases_url":"https://api.github.com/repos/hmallat/obexd/releases{/id}","created_at":"2013-09-28T10:59:23Z","updated_at":"2014-11-25T09:35:46Z","pushed_at":"2014-11-26T08:17:00Z","git_url":"git://github.com/hmallat/obexd.git","ssh_url":"git@github.com:hmallat/obexd.git","clone_url":"https://github.com/hmallat/obexd.git","svn_url":"https://github.com/hmallat/obexd","homepage":null,"size":489,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nemomobile-packages:master","ref":"master","sha":"783963eea5c95df2008be805a2ff82ba42b30a83","user":{"login":"nemomobile-packages","id":4255887,"avatar_url":"https://avatars.githubusercontent.com/u/4255887?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile-packages","html_url":"https://github.com/nemomobile-packages","followers_url":"https://api.github.com/users/nemomobile-packages/followers","following_url":"https://api.github.com/users/nemomobile-packages/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile-packages/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile-packages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile-packages/subscriptions","organizations_url":"https://api.github.com/users/nemomobile-packages/orgs","repos_url":"https://api.github.com/users/nemomobile-packages/repos","events_url":"https://api.github.com/users/nemomobile-packages/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile-packages/received_events","type":"Organization","site_admin":false},"repo":{"id":10208000,"name":"obexd","full_name":"nemomobile-packages/obexd","owner":{"login":"nemomobile-packages","id":4255887,"avatar_url":"https://avatars.githubusercontent.com/u/4255887?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile-packages","html_url":"https://github.com/nemomobile-packages","followers_url":"https://api.github.com/users/nemomobile-packages/followers","following_url":"https://api.github.com/users/nemomobile-packages/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile-packages/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile-packages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile-packages/subscriptions","organizations_url":"https://api.github.com/users/nemomobile-packages/orgs","repos_url":"https://api.github.com/users/nemomobile-packages/repos","events_url":"https://api.github.com/users/nemomobile-packages/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile-packages/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nemomobile-packages/obexd","description":null,"fork":false,"url":"https://api.github.com/repos/nemomobile-packages/obexd","forks_url":"https://api.github.com/repos/nemomobile-packages/obexd/forks","keys_url":"https://api.github.com/repos/nemomobile-packages/obexd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nemomobile-packages/obexd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nemomobile-packages/obexd/teams","hooks_url":"https://api.github.com/repos/nemomobile-packages/obexd/hooks","issue_events_url":"https://api.github.com/repos/nemomobile-packages/obexd/issues/events{/number}","events_url":"https://api.github.com/repos/nemomobile-packages/obexd/events","assignees_url":"https://api.github.com/repos/nemomobile-packages/obexd/assignees{/user}","branches_url":"https://api.github.com/repos/nemomobile-packages/obexd/branches{/branch}","tags_url":"https://api.github.com/repos/nemomobile-packages/obexd/tags","blobs_url":"https://api.github.com/repos/nemomobile-packages/obexd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nemomobile-packages/obexd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nemomobile-packages/obexd/git/refs{/sha}","trees_url":"https://api.github.com/repos/nemomobile-packages/obexd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nemomobile-packages/obexd/statuses/{sha}","languages_url":"https://api.github.com/repos/nemomobile-packages/obexd/languages","stargazers_url":"https://api.github.com/repos/nemomobile-packages/obexd/stargazers","contributors_url":"https://api.github.com/repos/nemomobile-packages/obexd/contributors","subscribers_url":"https://api.github.com/repos/nemomobile-packages/obexd/subscribers","subscription_url":"https://api.github.com/repos/nemomobile-packages/obexd/subscription","commits_url":"https://api.github.com/repos/nemomobile-packages/obexd/commits{/sha}","git_commits_url":"https://api.github.com/repos/nemomobile-packages/obexd/git/commits{/sha}","comments_url":"https://api.github.com/repos/nemomobile-packages/obexd/comments{/number}","issue_comment_url":"https://api.github.com/repos/nemomobile-packages/obexd/issues/comments/{number}","contents_url":"https://api.github.com/repos/nemomobile-packages/obexd/contents/{+path}","compare_url":"https://api.github.com/repos/nemomobile-packages/obexd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nemomobile-packages/obexd/merges","archive_url":"https://api.github.com/repos/nemomobile-packages/obexd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nemomobile-packages/obexd/downloads","issues_url":"https://api.github.com/repos/nemomobile-packages/obexd/issues{/number}","pulls_url":"https://api.github.com/repos/nemomobile-packages/obexd/pulls{/number}","milestones_url":"https://api.github.com/repos/nemomobile-packages/obexd/milestones{/number}","notifications_url":"https://api.github.com/repos/nemomobile-packages/obexd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nemomobile-packages/obexd/labels{/name}","releases_url":"https://api.github.com/repos/nemomobile-packages/obexd/releases{/id}","created_at":"2013-05-22T00:02:40Z","updated_at":"2014-11-25T09:34:09Z","pushed_at":"2014-11-25T09:37:53Z","git_url":"git://github.com/nemomobile-packages/obexd.git","ssh_url":"git@github.com:nemomobile-packages/obexd.git","clone_url":"https://github.com/nemomobile-packages/obexd.git","svn_url":"https://github.com/nemomobile-packages/obexd","homepage":null,"size":426,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nemomobile-packages/obexd/pulls/22"},"html":{"href":"https://github.com/nemomobile-packages/obexd/pull/22"},"issue":{"href":"https://api.github.com/repos/nemomobile-packages/obexd/issues/22"},"comments":{"href":"https://api.github.com/repos/nemomobile-packages/obexd/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/nemomobile-packages/obexd/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/nemomobile-packages/obexd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nemomobile-packages/obexd/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/nemomobile-packages/obexd/statuses/158e15e47b85c5a097bbd9fd81b5c2c382bde86a"}}}}