GitHub PullRequestReviewCommentEvent at 2014-06-09 12:47:59
Repository: snowcrash
Actor: zdne
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/comments/13538591","id":13538591,"diff_hunk":"@@ -78,32 +78,37 @@ namespace snowcrash {\n                                                          SectionParserData& pd,\n                                                          Report& report,\n                                                          T& out) {\n-            return node;\n+            return ++MarkdownNodeIterator(node);","path":"src/SectionProcessor.h","position":5,"original_position":5,"commit_id":"541398a71362cfcb074598a813d488adca05adbc","original_commit_id":"541398a71362cfcb074598a813d488adca05adbc","user":{"login":"zdne","id":613617,"avatar_url":"https://avatars.githubusercontent.com/u/613617?","gravatar_id":"cb2527e0c321fc1eb6753c06f45da93c","url":"https://api.github.com/users/zdne","html_url":"https://github.com/zdne","followers_url":"https://api.github.com/users/zdne/followers","following_url":"https://api.github.com/users/zdne/following{/other_user}","gists_url":"https://api.github.com/users/zdne/gists{/gist_id}","starred_url":"https://api.github.com/users/zdne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdne/subscriptions","organizations_url":"https://api.github.com/users/zdne/orgs","repos_url":"https://api.github.com/users/zdne/repos","events_url":"https://api.github.com/users/zdne/events{/privacy}","received_events_url":"https://api.github.com/users/zdne/received_events","type":"User","site_admin":false},"body":"Again, I do no think that we should increment the cursor here. Doing so means the node was processed. Which was not. This should not happen with the default `nestedSectionType`. So either you override `nestedSectionType` in a parser and you should then override `processNestedSection` as well or you stick with defaults and thus this is never called (and if so it stops the parser).","created_at":"2014-06-09T12:47:59Z","updated_at":"2014-06-09T12:47:59Z","html_url":"https://github.com/apiaryio/snowcrash/pull/117#discussion_r13538591","pull_request_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/comments/13538591"},"html":{"href":"https://github.com/apiaryio/snowcrash/pull/117#discussion_r13538591"},"pull_request":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/117","id":16832254,"html_url":"https://github.com/apiaryio/snowcrash/pull/117","diff_url":"https://github.com/apiaryio/snowcrash/pull/117.diff","patch_url":"https://github.com/apiaryio/snowcrash/pull/117.patch","issue_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/117","number":117,"state":"open","title":"PayloadParser refactor","user":{"login":"pksunkara","id":174703,"avatar_url":"https://avatars.githubusercontent.com/u/174703?","gravatar_id":"39863b6141d1be3ec211dca4b061cd5e","url":"https://api.github.com/users/pksunkara","html_url":"https://github.com/pksunkara","followers_url":"https://api.github.com/users/pksunkara/followers","following_url":"https://api.github.com/users/pksunkara/following{/other_user}","gists_url":"https://api.github.com/users/pksunkara/gists{/gist_id}","starred_url":"https://api.github.com/users/pksunkara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pksunkara/subscriptions","organizations_url":"https://api.github.com/users/pksunkara/orgs","repos_url":"https://api.github.com/users/pksunkara/repos","events_url":"https://api.github.com/users/pksunkara/events{/privacy}","received_events_url":"https://api.github.com/users/pksunkara/received_events","type":"User","site_admin":false},"body":"Need to refactor a few more tests. Otherwise, this is done.","created_at":"2014-06-06T17:26:15Z","updated_at":"2014-06-09T12:47:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80e00d1085f1d6c32e0f60c56e1966723f5c42bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/117/commits","review_comments_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/117/comments","review_comment_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/117/comments","statuses_url":"https://api.github.com/repos/apiaryio/snowcrash/statuses/541398a71362cfcb074598a813d488adca05adbc","head":{"label":"pksunkara:pksunkara/refactor","ref":"pksunkara/refactor","sha":"541398a71362cfcb074598a813d488adca05adbc","user":{"login":"pksunkara","id":174703,"avatar_url":"https://avatars.githubusercontent.com/u/174703?","gravatar_id":"39863b6141d1be3ec211dca4b061cd5e","url":"https://api.github.com/users/pksunkara","html_url":"https://github.com/pksunkara","followers_url":"https://api.github.com/users/pksunkara/followers","following_url":"https://api.github.com/users/pksunkara/following{/other_user}","gists_url":"https://api.github.com/users/pksunkara/gists{/gist_id}","starred_url":"https://api.github.com/users/pksunkara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pksunkara/subscriptions","organizations_url":"https://api.github.com/users/pksunkara/orgs","repos_url":"https://api.github.com/users/pksunkara/repos","events_url":"https://api.github.com/users/pksunkara/events{/privacy}","received_events_url":"https://api.github.com/users/pksunkara/received_events","type":"User","site_admin":false},"repo":{"id":20438584,"name":"snowcrash","full_name":"pksunkara/snowcrash","owner":{"login":"pksunkara","id":174703,"avatar_url":"https://avatars.githubusercontent.com/u/174703?","gravatar_id":"39863b6141d1be3ec211dca4b061cd5e","url":"https://api.github.com/users/pksunkara","html_url":"https://github.com/pksunkara","followers_url":"https://api.github.com/users/pksunkara/followers","following_url":"https://api.github.com/users/pksunkara/following{/other_user}","gists_url":"https://api.github.com/users/pksunkara/gists{/gist_id}","starred_url":"https://api.github.com/users/pksunkara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pksunkara/subscriptions","organizations_url":"https://api.github.com/users/pksunkara/orgs","repos_url":"https://api.github.com/users/pksunkara/repos","events_url":"https://api.github.com/users/pksunkara/events{/privacy}","received_events_url":"https://api.github.com/users/pksunkara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pksunkara/snowcrash","description":"API Blueprint Parser","fork":true,"url":"https://api.github.com/repos/pksunkara/snowcrash","forks_url":"https://api.github.com/repos/pksunkara/snowcrash/forks","keys_url":"https://api.github.com/repos/pksunkara/snowcrash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pksunkara/snowcrash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pksunkara/snowcrash/teams","hooks_url":"https://api.github.com/repos/pksunkara/snowcrash/hooks","issue_events_url":"https://api.github.com/repos/pksunkara/snowcrash/issues/events{/number}","events_url":"https://api.github.com/repos/pksunkara/snowcrash/events","assignees_url":"https://api.github.com/repos/pksunkara/snowcrash/assignees{/user}","branches_url":"https://api.github.com/repos/pksunkara/snowcrash/branches{/branch}","tags_url":"https://api.github.com/repos/pksunkara/snowcrash/tags","blobs_url":"https://api.github.com/repos/pksunkara/snowcrash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pksunkara/snowcrash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pksunkara/snowcrash/git/refs{/sha}","trees_url":"https://api.github.com/repos/pksunkara/snowcrash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pksunkara/snowcrash/statuses/{sha}","languages_url":"https://api.github.com/repos/pksunkara/snowcrash/languages","stargazers_url":"https://api.github.com/repos/pksunkara/snowcrash/stargazers","contributors_url":"https://api.github.com/repos/pksunkara/snowcrash/contributors","subscribers_url":"https://api.github.com/repos/pksunkara/snowcrash/subscribers","subscription_url":"https://api.github.com/repos/pksunkara/snowcrash/subscription","commits_url":"https://api.github.com/repos/pksunkara/snowcrash/commits{/sha}","git_commits_url":"https://api.github.com/repos/pksunkara/snowcrash/git/commits{/sha}","comments_url":"https://api.github.com/repos/pksunkara/snowcrash/comments{/number}","issue_comment_url":"https://api.github.com/repos/pksunkara/snowcrash/issues/comments/{number}","contents_url":"https://api.github.com/repos/pksunkara/snowcrash/contents/{+path}","compare_url":"https://api.github.com/repos/pksunkara/snowcrash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pksunkara/snowcrash/merges","archive_url":"https://api.github.com/repos/pksunkara/snowcrash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pksunkara/snowcrash/downloads","issues_url":"https://api.github.com/repos/pksunkara/snowcrash/issues{/number}","pulls_url":"https://api.github.com/repos/pksunkara/snowcrash/pulls{/number}","milestones_url":"https://api.github.com/repos/pksunkara/snowcrash/milestones{/number}","notifications_url":"https://api.github.com/repos/pksunkara/snowcrash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pksunkara/snowcrash/labels{/name}","releases_url":"https://api.github.com/repos/pksunkara/snowcrash/releases{/id}","created_at":"2014-06-03T10:25:57Z","updated_at":"2014-06-06T17:45:41Z","pushed_at":"2014-06-06T17:45:40Z","git_url":"git://github.com/pksunkara/snowcrash.git","ssh_url":"git@github.com:pksunkara/snowcrash.git","clone_url":"https://github.com/pksunkara/snowcrash.git","svn_url":"https://github.com/pksunkara/snowcrash","homepage":null,"size":1650,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apiaryio:shared/refactor-integration","ref":"shared/refactor-integration","sha":"7192783a2912610ac0291462f6d01c363673a103","user":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?","gravatar_id":"c64b5c51ede2fbd878595bf27bc4d630","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"repo":{"id":9173280,"name":"snowcrash","full_name":"apiaryio/snowcrash","owner":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?","gravatar_id":"c64b5c51ede2fbd878595bf27bc4d630","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apiaryio/snowcrash","description":"API Blueprint Parser","fork":false,"url":"https://api.github.com/repos/apiaryio/snowcrash","forks_url":"https://api.github.com/repos/apiaryio/snowcrash/forks","keys_url":"https://api.github.com/repos/apiaryio/snowcrash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apiaryio/snowcrash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apiaryio/snowcrash/teams","hooks_url":"https://api.github.com/repos/apiaryio/snowcrash/hooks","issue_events_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/events{/number}","events_url":"https://api.github.com/repos/apiaryio/snowcrash/events","assignees_url":"https://api.github.com/repos/apiaryio/snowcrash/assignees{/user}","branches_url":"https://api.github.com/repos/apiaryio/snowcrash/branches{/branch}","tags_url":"https://api.github.com/repos/apiaryio/snowcrash/tags","blobs_url":"https://api.github.com/repos/apiaryio/snowcrash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apiaryio/snowcrash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apiaryio/snowcrash/git/refs{/sha}","trees_url":"https://api.github.com/repos/apiaryio/snowcrash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apiaryio/snowcrash/statuses/{sha}","languages_url":"https://api.github.com/repos/apiaryio/snowcrash/languages","stargazers_url":"https://api.github.com/repos/apiaryio/snowcrash/stargazers","contributors_url":"https://api.github.com/repos/apiaryio/snowcrash/contributors","subscribers_url":"https://api.github.com/repos/apiaryio/snowcrash/subscribers","subscription_url":"https://api.github.com/repos/apiaryio/snowcrash/subscription","commits_url":"https://api.github.com/repos/apiaryio/snowcrash/commits{/sha}","git_commits_url":"https://api.github.com/repos/apiaryio/snowcrash/git/commits{/sha}","comments_url":"https://api.github.com/repos/apiaryio/snowcrash/comments{/number}","issue_comment_url":"https://api.github.com/repos/apiaryio/snowcrash/issues/comments/{number}","contents_url":"https://api.github.com/repos/apiaryio/snowcrash/contents/{+path}","compare_url":"https://api.github.com/repos/apiaryio/snowcrash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apiaryio/snowcrash/merges","archive_url":"https://api.github.com/repos/apiaryio/snowcrash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apiaryio/snowcrash/downloads","issues_url":"https://api.github.com/repos/apiaryio/snowcrash/issues{/number}","pulls_url":"https://api.github.com/repos/apiaryio/snowcrash/pulls{/number}","milestones_url":"https://api.github.com/repos/apiaryio/snowcrash/milestones{/number}","notifications_url":"https://api.github.com/repos/apiaryio/snowcrash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apiaryio/snowcrash/labels{/name}","releases_url":"https://api.github.com/repos/apiaryio/snowcrash/releases{/id}","created_at":"2013-04-02T15:23:04Z","updated_at":"2014-06-09T10:55:21Z","pushed_at":"2014-06-04T14:01:34Z","git_url":"git://github.com/apiaryio/snowcrash.git","ssh_url":"git@github.com:apiaryio/snowcrash.git","clone_url":"https://github.com/apiaryio/snowcrash.git","svn_url":"https://github.com/apiaryio/snowcrash","homepage":null,"size":4866,"stargazers_count":120,"watchers_count":120,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":18,"mirror_url":null,"open_issues_count":30,"forks":18,"open_issues":30,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/117"},"html":{"href":"https://github.com/apiaryio/snowcrash/pull/117"},"issue":{"href":"https://api.github.com/repos/apiaryio/snowcrash/issues/117"},"comments":{"href":"https://api.github.com/repos/apiaryio/snowcrash/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apiaryio/snowcrash/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/apiaryio/snowcrash/statuses/541398a71362cfcb074598a813d488adca05adbc"}}}}