GitHub PullRequestEvent at 2014-02-24 16:39:19
Repository: fixmystreet
Actor: osfameron
Payload: {"action":"closed","number":667,"pull_request":{"url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/667","id":12758283,"html_url":"https://github.com/mysociety/fixmystreet/pull/667","diff_url":"https://github.com/mysociety/fixmystreet/pull/667.diff","patch_url":"https://github.com/mysociety/fixmystreet/pull/667.patch","issue_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/667","number":667,"state":"closed","title":"Issues/484 open311 errors on comment processing","user":{"login":"osfameron","id":28139,"avatar_url":"https://gravatar.com/avatar/442e3b1ef0376899077b2ce1be47e234?d=https%3A%2F%2Fidenticons.github.com%2Fb589775cf387584a460c9a316b24ad74.png&r=x","gravatar_id":"442e3b1ef0376899077b2ce1be47e234","url":"https://api.github.com/users/osfameron","html_url":"https://github.com/osfameron","followers_url":"https://api.github.com/users/osfameron/followers","following_url":"https://api.github.com/users/osfameron/following{/other_user}","gists_url":"https://api.github.com/users/osfameron/gists{/gist_id}","starred_url":"https://api.github.com/users/osfameron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osfameron/subscriptions","organizations_url":"https://api.github.com/users/osfameron/orgs","repos_url":"https://api.github.com/users/osfameron/repos","events_url":"https://api.github.com/users/osfameron/events{/privacy}","received_events_url":"https://api.github.com/users/osfameron/received_events","type":"User","site_admin":false},"body":"Turn ->find into a ->search to avoid an error or a deprecation warning, as the assumed invariant (that there will be exactly 1x DB::Alert for the problem spec) seems not to hold.\r\n\r\nAsking @struan / @davewhiteland to view, as it might be that this actually *should* have been a single row, and means there's a deeper problem to fix.\r\n\r\nAlso, I'm getting rather confused by the fact that passing 'suppress_alerts' seems to create sent alerts -- the wording of the test also has this confusion, e.g. should be be renaming to `$alerts_suppressed->count` rather than `$alerts_sent` ?","created_at":"2014-02-20T18:15:27Z","updated_at":"2014-02-24T16:39:19Z","closed_at":"2014-02-24T16:39:19Z","merged_at":null,"merge_commit_sha":"49302bf07daf3ce1c474338b3df633c8b8a37a2c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/667/commits","review_comments_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/667/comments","review_comment_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/667/comments","statuses_url":"https://api.github.com/repos/mysociety/fixmystreet/statuses/69d80a7c17eb524aad45811bde101e8b3f76d646","head":{"label":"mysociety:issues/484-open311-errors-on-comment-processing","ref":"issues/484-open311-errors-on-comment-processing","sha":"69d80a7c17eb524aad45811bde101e8b3f76d646","user":{"login":"mysociety","id":141338,"avatar_url":"https://gravatar.com/avatar/cb4e9c9ec6d33ee844baa03bd8f58cd3?d=https%3A%2F%2Fidenticons.github.com%2Fbcf404e9d19a117c90cfa7d4ae152dea.png&r=x","gravatar_id":"cb4e9c9ec6d33ee844baa03bd8f58cd3","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":487492,"name":"fixmystreet","full_name":"mysociety/fixmystreet","owner":{"login":"mysociety","id":141338,"avatar_url":"https://gravatar.com/avatar/cb4e9c9ec6d33ee844baa03bd8f58cd3?d=https%3A%2F%2Fidenticons.github.com%2Fbcf404e9d19a117c90cfa7d4ae152dea.png&r=x","gravatar_id":"cb4e9c9ec6d33ee844baa03bd8f58cd3","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mysociety/fixmystreet","description":"This is mySociety's popular street problem reporting platform, now at version 1.2: it's easier than ever before to install in new countries.","fork":false,"url":"https://api.github.com/repos/mysociety/fixmystreet","forks_url":"https://api.github.com/repos/mysociety/fixmystreet/forks","keys_url":"https://api.github.com/repos/mysociety/fixmystreet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/fixmystreet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/fixmystreet/teams","hooks_url":"https://api.github.com/repos/mysociety/fixmystreet/hooks","issue_events_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/fixmystreet/events","assignees_url":"https://api.github.com/repos/mysociety/fixmystreet/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/fixmystreet/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/fixmystreet/tags","blobs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/fixmystreet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/fixmystreet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/fixmystreet/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/fixmystreet/languages","stargazers_url":"https://api.github.com/repos/mysociety/fixmystreet/stargazers","contributors_url":"https://api.github.com/repos/mysociety/fixmystreet/contributors","subscribers_url":"https://api.github.com/repos/mysociety/fixmystreet/subscribers","subscription_url":"https://api.github.com/repos/mysociety/fixmystreet/subscription","commits_url":"https://api.github.com/repos/mysociety/fixmystreet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/fixmystreet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/comments/{number}","contents_url":"https://api.github.com/repos/mysociety/fixmystreet/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/fixmystreet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/fixmystreet/merges","archive_url":"https://api.github.com/repos/mysociety/fixmystreet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/fixmystreet/downloads","issues_url":"https://api.github.com/repos/mysociety/fixmystreet/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/fixmystreet/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/fixmystreet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/fixmystreet/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/fixmystreet/releases{/id}","created_at":"2010-01-25T11:54:20Z","updated_at":"2014-02-24T16:37:07Z","pushed_at":"2014-02-24T16:37:07Z","git_url":"git://github.com/mysociety/fixmystreet.git","ssh_url":"git@github.com:mysociety/fixmystreet.git","clone_url":"https://github.com/mysociety/fixmystreet.git","svn_url":"https://github.com/mysociety/fixmystreet","homepage":"http://code.fixmystreet.com","size":57782,"stargazers_count":154,"watchers_count":154,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":79,"mirror_url":null,"open_issues_count":206,"forks":79,"open_issues":206,"watchers":154,"default_branch":"master","master_branch":"master"}},"base":{"label":"mysociety:master","ref":"master","sha":"131d182ad218ba9cf733277b0ff2c5efb6a48dc5","user":{"login":"mysociety","id":141338,"avatar_url":"https://gravatar.com/avatar/cb4e9c9ec6d33ee844baa03bd8f58cd3?d=https%3A%2F%2Fidenticons.github.com%2Fbcf404e9d19a117c90cfa7d4ae152dea.png&r=x","gravatar_id":"cb4e9c9ec6d33ee844baa03bd8f58cd3","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":487492,"name":"fixmystreet","full_name":"mysociety/fixmystreet","owner":{"login":"mysociety","id":141338,"avatar_url":"https://gravatar.com/avatar/cb4e9c9ec6d33ee844baa03bd8f58cd3?d=https%3A%2F%2Fidenticons.github.com%2Fbcf404e9d19a117c90cfa7d4ae152dea.png&r=x","gravatar_id":"cb4e9c9ec6d33ee844baa03bd8f58cd3","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mysociety/fixmystreet","description":"This is mySociety's popular street problem reporting platform, now at version 1.2: it's easier than ever before to install in new countries.","fork":false,"url":"https://api.github.com/repos/mysociety/fixmystreet","forks_url":"https://api.github.com/repos/mysociety/fixmystreet/forks","keys_url":"https://api.github.com/repos/mysociety/fixmystreet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/fixmystreet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/fixmystreet/teams","hooks_url":"https://api.github.com/repos/mysociety/fixmystreet/hooks","issue_events_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/fixmystreet/events","assignees_url":"https://api.github.com/repos/mysociety/fixmystreet/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/fixmystreet/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/fixmystreet/tags","blobs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/fixmystreet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/fixmystreet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/fixmystreet/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/fixmystreet/languages","stargazers_url":"https://api.github.com/repos/mysociety/fixmystreet/stargazers","contributors_url":"https://api.github.com/repos/mysociety/fixmystreet/contributors","subscribers_url":"https://api.github.com/repos/mysociety/fixmystreet/subscribers","subscription_url":"https://api.github.com/repos/mysociety/fixmystreet/subscription","commits_url":"https://api.github.com/repos/mysociety/fixmystreet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/fixmystreet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/comments/{number}","contents_url":"https://api.github.com/repos/mysociety/fixmystreet/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/fixmystreet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/fixmystreet/merges","archive_url":"https://api.github.com/repos/mysociety/fixmystreet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/fixmystreet/downloads","issues_url":"https://api.github.com/repos/mysociety/fixmystreet/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/fixmystreet/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/fixmystreet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/fixmystreet/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/fixmystreet/releases{/id}","created_at":"2010-01-25T11:54:20Z","updated_at":"2014-02-24T16:37:07Z","pushed_at":"2014-02-24T16:37:07Z","git_url":"git://github.com/mysociety/fixmystreet.git","ssh_url":"git@github.com:mysociety/fixmystreet.git","clone_url":"https://github.com/mysociety/fixmystreet.git","svn_url":"https://github.com/mysociety/fixmystreet","homepage":"http://code.fixmystreet.com","size":57782,"stargazers_count":154,"watchers_count":154,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":79,"mirror_url":null,"open_issues_count":206,"forks":79,"open_issues":206,"watchers":154,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/667"},"html":{"href":"https://github.com/mysociety/fixmystreet/pull/667"},"issue":{"href":"https://api.github.com/repos/mysociety/fixmystreet/issues/667"},"comments":{"href":"https://api.github.com/repos/mysociety/fixmystreet/issues/667/comments"},"review_comments":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/667/comments"},"review_comment":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/667/commits"},"statuses":{"href":"https://api.github.com/repos/mysociety/fixmystreet/statuses/69d80a7c17eb524aad45811bde101e8b3f76d646"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":3,"additions":42,"deletions":15,"changed_files":3}}