GitHub PullRequestReviewCommentEvent at 2014-11-26 01:19:03
Repository: rich_citations_processor
Actor: marcrohloff
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls/comments/20910508","id":20910508,"diff_hunk":"@@ -117,7 +117,7 @@ module RichCitationsProcessor\n \n         it \"should raise an exception\" do\n           stub_request(http_method, 'http://www.example.com/path').to_return(status:404).times(1)\n-          expect { action('http://www.example.com/path', 'application/custom') }.to raise_exception(Net::HTTPServerException)\n+          expect(action('http://www.example.com/path', 'application/custom')).to be_nil","path":"spec/http_utilities_spec.rb","position":5,"original_position":5,"commit_id":"a5afa4157f4bde5e93af92933e9f669c4773c90f","original_commit_id":"a5afa4157f4bde5e93af92933e9f669c4773c90f","user":{"login":"marcrohloff","id":737058,"avatar_url":"https://avatars.githubusercontent.com/u/737058?v=3","gravatar_id":"","url":"https://api.github.com/users/marcrohloff","html_url":"https://github.com/marcrohloff","followers_url":"https://api.github.com/users/marcrohloff/followers","following_url":"https://api.github.com/users/marcrohloff/following{/other_user}","gists_url":"https://api.github.com/users/marcrohloff/gists{/gist_id}","starred_url":"https://api.github.com/users/marcrohloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcrohloff/subscriptions","organizations_url":"https://api.github.com/users/marcrohloff/orgs","repos_url":"https://api.github.com/users/marcrohloff/repos","events_url":"https://api.github.com/users/marcrohloff/events{/privacy}","received_events_url":"https://api.github.com/users/marcrohloff/received_events","type":"User","site_admin":false},"body":"The test no longer describes what is being tested","created_at":"2014-11-26T01:19:03Z","updated_at":"2014-11-26T01:19:03Z","html_url":"https://github.com/ploslabs/rich_citations_processor/pull/9#discussion_r20910508","pull_request_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls/comments/20910508"},"html":{"href":"https://github.com/ploslabs/rich_citations_processor/pull/9#discussion_r20910508"},"pull_request":{"href":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls/9","id":25053393,"html_url":"https://github.com/ploslabs/rich_citations_processor/pull/9","diff_url":"https://github.com/ploslabs/rich_citations_processor/pull/9.diff","patch_url":"https://github.com/ploslabs/rich_citations_processor/pull/9.patch","issue_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/issues/9","number":9,"state":"open","locked":false,"title":"use httpclient to power HTTPUtilities class","user":{"login":"egh","id":22718,"avatar_url":"https://avatars.githubusercontent.com/u/22718?v=3","gravatar_id":"","url":"https://api.github.com/users/egh","html_url":"https://github.com/egh","followers_url":"https://api.github.com/users/egh/followers","following_url":"https://api.github.com/users/egh/following{/other_user}","gists_url":"https://api.github.com/users/egh/gists{/gist_id}","starred_url":"https://api.github.com/users/egh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egh/subscriptions","organizations_url":"https://api.github.com/users/egh/orgs","repos_url":"https://api.github.com/users/egh/repos","events_url":"https://api.github.com/users/egh/events{/privacy}","received_events_url":"https://api.github.com/users/egh/received_events","type":"User","site_admin":false},"body":"Second try at this. Changes the exceptions raised slightly but should be basically the same.","created_at":"2014-11-26T00:51:35Z","updated_at":"2014-11-26T01:19:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3b94f02151826bd21506cc7276b25bf823f10a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls/9/commits","review_comments_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls/9/comments","review_comment_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/issues/9/comments","statuses_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/statuses/a5afa4157f4bde5e93af92933e9f669c4773c90f","head":{"label":"ploslabs:feature/use_httpclient2","ref":"feature/use_httpclient2","sha":"a5afa4157f4bde5e93af92933e9f669c4773c90f","user":{"login":"ploslabs","id":6035133,"avatar_url":"https://avatars.githubusercontent.com/u/6035133?v=3","gravatar_id":"","url":"https://api.github.com/users/ploslabs","html_url":"https://github.com/ploslabs","followers_url":"https://api.github.com/users/ploslabs/followers","following_url":"https://api.github.com/users/ploslabs/following{/other_user}","gists_url":"https://api.github.com/users/ploslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ploslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ploslabs/subscriptions","organizations_url":"https://api.github.com/users/ploslabs/orgs","repos_url":"https://api.github.com/users/ploslabs/repos","events_url":"https://api.github.com/users/ploslabs/events{/privacy}","received_events_url":"https://api.github.com/users/ploslabs/received_events","type":"User","site_admin":false},"repo":{"id":23977970,"name":"rich_citations_processor","full_name":"ploslabs/rich_citations_processor","owner":{"login":"ploslabs","id":6035133,"avatar_url":"https://avatars.githubusercontent.com/u/6035133?v=3","gravatar_id":"","url":"https://api.github.com/users/ploslabs","html_url":"https://github.com/ploslabs","followers_url":"https://api.github.com/users/ploslabs/followers","following_url":"https://api.github.com/users/ploslabs/following{/other_user}","gists_url":"https://api.github.com/users/ploslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ploslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ploslabs/subscriptions","organizations_url":"https://api.github.com/users/ploslabs/orgs","repos_url":"https://api.github.com/users/ploslabs/repos","events_url":"https://api.github.com/users/ploslabs/events{/privacy}","received_events_url":"https://api.github.com/users/ploslabs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ploslabs/rich_citations_processor","description":"","fork":false,"url":"https://api.github.com/repos/ploslabs/rich_citations_processor","forks_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/forks","keys_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/teams","hooks_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/hooks","issue_events_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/issues/events{/number}","events_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/events","assignees_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/assignees{/user}","branches_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/branches{/branch}","tags_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/tags","blobs_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/statuses/{sha}","languages_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/languages","stargazers_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/stargazers","contributors_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/contributors","subscribers_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/subscribers","subscription_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/subscription","commits_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/issues/comments/{number}","contents_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/contents/{+path}","compare_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/merges","archive_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/downloads","issues_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/issues{/number}","pulls_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls{/number}","milestones_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/milestones{/number}","notifications_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/labels{/name}","releases_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/releases{/id}","created_at":"2014-09-12T21:43:35Z","updated_at":"2014-11-18T23:52:57Z","pushed_at":"2014-11-26T00:46:24Z","git_url":"git://github.com/ploslabs/rich_citations_processor.git","ssh_url":"git@github.com:ploslabs/rich_citations_processor.git","clone_url":"https://github.com/ploslabs/rich_citations_processor.git","svn_url":"https://github.com/ploslabs/rich_citations_processor","homepage":null,"size":524,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"ploslabs:master","ref":"master","sha":"094795b282e6d8b5908d5e85ea7790914c2b1064","user":{"login":"ploslabs","id":6035133,"avatar_url":"https://avatars.githubusercontent.com/u/6035133?v=3","gravatar_id":"","url":"https://api.github.com/users/ploslabs","html_url":"https://github.com/ploslabs","followers_url":"https://api.github.com/users/ploslabs/followers","following_url":"https://api.github.com/users/ploslabs/following{/other_user}","gists_url":"https://api.github.com/users/ploslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ploslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ploslabs/subscriptions","organizations_url":"https://api.github.com/users/ploslabs/orgs","repos_url":"https://api.github.com/users/ploslabs/repos","events_url":"https://api.github.com/users/ploslabs/events{/privacy}","received_events_url":"https://api.github.com/users/ploslabs/received_events","type":"User","site_admin":false},"repo":{"id":23977970,"name":"rich_citations_processor","full_name":"ploslabs/rich_citations_processor","owner":{"login":"ploslabs","id":6035133,"avatar_url":"https://avatars.githubusercontent.com/u/6035133?v=3","gravatar_id":"","url":"https://api.github.com/users/ploslabs","html_url":"https://github.com/ploslabs","followers_url":"https://api.github.com/users/ploslabs/followers","following_url":"https://api.github.com/users/ploslabs/following{/other_user}","gists_url":"https://api.github.com/users/ploslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ploslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ploslabs/subscriptions","organizations_url":"https://api.github.com/users/ploslabs/orgs","repos_url":"https://api.github.com/users/ploslabs/repos","events_url":"https://api.github.com/users/ploslabs/events{/privacy}","received_events_url":"https://api.github.com/users/ploslabs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ploslabs/rich_citations_processor","description":"","fork":false,"url":"https://api.github.com/repos/ploslabs/rich_citations_processor","forks_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/forks","keys_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/teams","hooks_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/hooks","issue_events_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/issues/events{/number}","events_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/events","assignees_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/assignees{/user}","branches_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/branches{/branch}","tags_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/tags","blobs_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/statuses/{sha}","languages_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/languages","stargazers_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/stargazers","contributors_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/contributors","subscribers_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/subscribers","subscription_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/subscription","commits_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/issues/comments/{number}","contents_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/contents/{+path}","compare_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/merges","archive_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/downloads","issues_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/issues{/number}","pulls_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls{/number}","milestones_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/milestones{/number}","notifications_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/labels{/name}","releases_url":"https://api.github.com/repos/ploslabs/rich_citations_processor/releases{/id}","created_at":"2014-09-12T21:43:35Z","updated_at":"2014-11-18T23:52:57Z","pushed_at":"2014-11-26T00:46:24Z","git_url":"git://github.com/ploslabs/rich_citations_processor.git","ssh_url":"git@github.com:ploslabs/rich_citations_processor.git","clone_url":"https://github.com/ploslabs/rich_citations_processor.git","svn_url":"https://github.com/ploslabs/rich_citations_processor","homepage":null,"size":524,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls/9"},"html":{"href":"https://github.com/ploslabs/rich_citations_processor/pull/9"},"issue":{"href":"https://api.github.com/repos/ploslabs/rich_citations_processor/issues/9"},"comments":{"href":"https://api.github.com/repos/ploslabs/rich_citations_processor/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ploslabs/rich_citations_processor/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/ploslabs/rich_citations_processor/statuses/a5afa4157f4bde5e93af92933e9f669c4773c90f"}}}}