GitHub PullRequestEvent at 2014-03-08 22:26:40
Repository: rails
Actor: pch
Payload: {"action":"opened","number":14329,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/14329","id":13346054,"html_url":"https://github.com/rails/rails/pull/14329","diff_url":"https://github.com/rails/rails/pull/14329.diff","patch_url":"https://github.com/rails/rails/pull/14329.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/14329","number":14329,"state":"open","title":"Ensure LookupContext in Digestor selects correct variant","user":{"login":"pch","id":9818,"avatar_url":"https://gravatar.com/avatar/2fa5aa0e677160dae1184894bbe34b98?d=https%3A%2F%2Fidenticons.github.com%2F7c7077ca5231fd6ad758b9d49a2a1eeb.png&r=x","gravatar_id":"2fa5aa0e677160dae1184894bbe34b98","url":"https://api.github.com/users/pch","html_url":"https://github.com/pch","followers_url":"https://api.github.com/users/pch/followers","following_url":"https://api.github.com/users/pch/following{/other_user}","gists_url":"https://api.github.com/users/pch/gists{/gist_id}","starred_url":"https://api.github.com/users/pch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pch/subscriptions","organizations_url":"https://api.github.com/users/pch/orgs","repos_url":"https://api.github.com/users/pch/repos","events_url":"https://api.github.com/users/pch/events{/privacy}","received_events_url":"https://api.github.com/users/pch/received_events","type":"User","site_admin":false},"body":"Related to: #14242, #14243 & #14293\r\n\r\nVariants passed to LookupContext#find() seem to be ignored, so I used a setter instead: `finder.variants = [ variant ]` which seems to fix the problem.\r\n\r\nI've also added some more test cases for variants. Hopefully this time passing tests will mean it actually works.\r\n\r\n/cc @strzalek @dhh @jeremy","created_at":"2014-03-08T22:26:38Z","updated_at":"2014-03-08T22:26:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/14329/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/14329/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rails/rails/issues/14329/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/61f8cd8803bdd9a15e8bfbf3f2b00a68915a53ed","head":{"label":"pch:digestor-lookup-fix","ref":"digestor-lookup-fix","sha":"61f8cd8803bdd9a15e8bfbf3f2b00a68915a53ed","user":{"login":"pch","id":9818,"avatar_url":"https://gravatar.com/avatar/2fa5aa0e677160dae1184894bbe34b98?d=https%3A%2F%2Fidenticons.github.com%2F7c7077ca5231fd6ad758b9d49a2a1eeb.png&r=x","gravatar_id":"2fa5aa0e677160dae1184894bbe34b98","url":"https://api.github.com/users/pch","html_url":"https://github.com/pch","followers_url":"https://api.github.com/users/pch/followers","following_url":"https://api.github.com/users/pch/following{/other_user}","gists_url":"https://api.github.com/users/pch/gists{/gist_id}","starred_url":"https://api.github.com/users/pch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pch/subscriptions","organizations_url":"https://api.github.com/users/pch/orgs","repos_url":"https://api.github.com/users/pch/repos","events_url":"https://api.github.com/users/pch/events{/privacy}","received_events_url":"https://api.github.com/users/pch/received_events","type":"User","site_admin":false},"repo":{"id":17320012,"name":"rails","full_name":"pch/rails","owner":{"login":"pch","id":9818,"avatar_url":"https://gravatar.com/avatar/2fa5aa0e677160dae1184894bbe34b98?d=https%3A%2F%2Fidenticons.github.com%2F7c7077ca5231fd6ad758b9d49a2a1eeb.png&r=x","gravatar_id":"2fa5aa0e677160dae1184894bbe34b98","url":"https://api.github.com/users/pch","html_url":"https://github.com/pch","followers_url":"https://api.github.com/users/pch/followers","following_url":"https://api.github.com/users/pch/following{/other_user}","gists_url":"https://api.github.com/users/pch/gists{/gist_id}","starred_url":"https://api.github.com/users/pch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pch/subscriptions","organizations_url":"https://api.github.com/users/pch/orgs","repos_url":"https://api.github.com/users/pch/repos","events_url":"https://api.github.com/users/pch/events{/privacy}","received_events_url":"https://api.github.com/users/pch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pch/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/pch/rails","forks_url":"https://api.github.com/repos/pch/rails/forks","keys_url":"https://api.github.com/repos/pch/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pch/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pch/rails/teams","hooks_url":"https://api.github.com/repos/pch/rails/hooks","issue_events_url":"https://api.github.com/repos/pch/rails/issues/events{/number}","events_url":"https://api.github.com/repos/pch/rails/events","assignees_url":"https://api.github.com/repos/pch/rails/assignees{/user}","branches_url":"https://api.github.com/repos/pch/rails/branches{/branch}","tags_url":"https://api.github.com/repos/pch/rails/tags","blobs_url":"https://api.github.com/repos/pch/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pch/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pch/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/pch/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pch/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/pch/rails/languages","stargazers_url":"https://api.github.com/repos/pch/rails/stargazers","contributors_url":"https://api.github.com/repos/pch/rails/contributors","subscribers_url":"https://api.github.com/repos/pch/rails/subscribers","subscription_url":"https://api.github.com/repos/pch/rails/subscription","commits_url":"https://api.github.com/repos/pch/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/pch/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/pch/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/pch/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/pch/rails/contents/{+path}","compare_url":"https://api.github.com/repos/pch/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pch/rails/merges","archive_url":"https://api.github.com/repos/pch/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pch/rails/downloads","issues_url":"https://api.github.com/repos/pch/rails/issues{/number}","pulls_url":"https://api.github.com/repos/pch/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/pch/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/pch/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pch/rails/labels{/name}","releases_url":"https://api.github.com/repos/pch/rails/releases{/id}","created_at":"2014-03-01T17:25:31Z","updated_at":"2014-03-08T22:26:38Z","pushed_at":"2014-03-08T22:22:19Z","git_url":"git://github.com/pch/rails.git","ssh_url":"git@github.com:pch/rails.git","clone_url":"https://github.com/pch/rails.git","svn_url":"https://github.com/pch/rails","homepage":"http://rubyonrails.org","size":108834,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"45efd0ebf77811e43cebc68400c24652133a0f99","user":{"login":"rails","id":4223,"avatar_url":"https://gravatar.com/avatar/30f39a09e233e8369dddf6feb4be0308?d=https%3A%2F%2Fidenticons.github.com%2Ff42a37d114a480b6b57b60ea9a14a9d2.png&r=x","gravatar_id":"30f39a09e233e8369dddf6feb4be0308","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://gravatar.com/avatar/30f39a09e233e8369dddf6feb4be0308?d=https%3A%2F%2Fidenticons.github.com%2Ff42a37d114a480b6b57b60ea9a14a9d2.png&r=x","gravatar_id":"30f39a09e233e8369dddf6feb4be0308","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2014-03-08T21:21:06Z","pushed_at":"2014-03-08T21:21:05Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":264112,"stargazers_count":21014,"watchers_count":21014,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":7514,"mirror_url":null,"open_issues_count":744,"forks":7514,"open_issues":744,"watchers":21014,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/14329"},"html":{"href":"https://github.com/rails/rails/pull/14329"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/14329"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/14329/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/14329/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/14329/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/61f8cd8803bdd9a15e8bfbf3f2b00a68915a53ed"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":52,"deletions":5,"changed_files":8}}