GitHub PullRequestReviewCommentEvent at 2014-09-01 22:49:19
Repository: juju
Actor: howbazaar
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/16965639","id":16965639,"diff_hunk":"@@ -776,6 +776,34 @@ func (c *Client) EnvironmentInfo() (api.EnvironmentInfo, error) {\n \treturn info, nil\n }\n \n+// ShareEnvironment adds a user to the environment.\n+func (c *Client) ShareEnvironment(args params.ModifyEnvironUsers) (result params.ErrorResults, err error) {\n+\tvar createdBy names.UserTag\n+\tvar ok bool\n+\tif createdBy, ok = c.api.auth.GetAuthTag().(names.UserTag); !ok {\n+\t\treturn result, errors.Errorf(\"api connection is not through a user\")\n+\t}\n+\n+\tresult = params.ErrorResults{\n+\t\tResults: make([]params.ErrorResult, len(args.Changes)),\n+\t}\n+\tif len(args.Changes) == 0 {\n+\t\treturn result, nil\n+\t}\n+\n+\tfor i, arg := range args.Changes {\n+\t\tusername := arg.Username\n+\t\tuser := names.NewUserTag(username)","path":"state/apiserver/client/client.go","position":27,"original_position":27,"commit_id":"e48b49792910cf93455dcab85d30617226b62634","original_commit_id":"e48b49792910cf93455dcab85d30617226b62634","user":{"login":"howbazaar","id":1744247,"avatar_url":"https://avatars.githubusercontent.com/u/1744247?v=2","gravatar_id":"ec6cce6fd3bee2a0fa99be8e1960bb44","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"body":"You need to validate the username before calling `names.NewUserTag` as that can panic.","created_at":"2014-09-01T22:49:19Z","updated_at":"2014-09-01T22:49:19Z","html_url":"https://github.com/juju/juju/pull/645#discussion_r16965639","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/645","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/16965639"},"html":{"href":"https://github.com/juju/juju/pull/645#discussion_r16965639"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/645"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/645","id":20554765,"html_url":"https://github.com/juju/juju/pull/645","diff_url":"https://github.com/juju/juju/pull/645.diff","patch_url":"https://github.com/juju/juju/pull/645.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/645","number":645,"state":"open","locked":false,"title":"New client & server API func ShareEnvironment","user":{"login":"waigani","id":33275,"avatar_url":"https://avatars.githubusercontent.com/u/33275?v=2","gravatar_id":"40eb9f01a3481f86a4b479ed873a7cd0","url":"https://api.github.com/users/waigani","html_url":"https://github.com/waigani","followers_url":"https://api.github.com/users/waigani/followers","following_url":"https://api.github.com/users/waigani/following{/other_user}","gists_url":"https://api.github.com/users/waigani/gists{/gist_id}","starred_url":"https://api.github.com/users/waigani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waigani/subscriptions","organizations_url":"https://api.github.com/users/waigani/orgs","repos_url":"https://api.github.com/users/waigani/repos","events_url":"https://api.github.com/users/waigani/events{/privacy}","received_events_url":"https://api.github.com/users/waigani/received_events","type":"User","site_admin":false},"body":"ShareEnvironment shares the current environment with the given user.\r\nUnder the hood, it adds an environment user to state.","created_at":"2014-09-01T04:51:10Z","updated_at":"2014-09-01T22:49:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"549bb6e14034a783f843e04a14962a31deb13fa9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/645/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/645/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments/{number}","comments_url":"https://api.github.com/repos/juju/juju/issues/645/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/e48b49792910cf93455dcab85d30617226b62634","head":{"label":"waigani:share-env-take2","ref":"share-env-take2","sha":"e48b49792910cf93455dcab85d30617226b62634","user":{"login":"waigani","id":33275,"avatar_url":"https://avatars.githubusercontent.com/u/33275?v=2","gravatar_id":"40eb9f01a3481f86a4b479ed873a7cd0","url":"https://api.github.com/users/waigani","html_url":"https://github.com/waigani","followers_url":"https://api.github.com/users/waigani/followers","following_url":"https://api.github.com/users/waigani/following{/other_user}","gists_url":"https://api.github.com/users/waigani/gists{/gist_id}","starred_url":"https://api.github.com/users/waigani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waigani/subscriptions","organizations_url":"https://api.github.com/users/waigani/orgs","repos_url":"https://api.github.com/users/waigani/repos","events_url":"https://api.github.com/users/waigani/events{/privacy}","received_events_url":"https://api.github.com/users/waigani/received_events","type":"User","site_admin":false},"repo":{"id":20465970,"name":"juju","full_name":"waigani/juju","owner":{"login":"waigani","id":33275,"avatar_url":"https://avatars.githubusercontent.com/u/33275?v=2","gravatar_id":"40eb9f01a3481f86a4b479ed873a7cd0","url":"https://api.github.com/users/waigani","html_url":"https://github.com/waigani","followers_url":"https://api.github.com/users/waigani/followers","following_url":"https://api.github.com/users/waigani/following{/other_user}","gists_url":"https://api.github.com/users/waigani/gists{/gist_id}","starred_url":"https://api.github.com/users/waigani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waigani/subscriptions","organizations_url":"https://api.github.com/users/waigani/orgs","repos_url":"https://api.github.com/users/waigani/repos","events_url":"https://api.github.com/users/waigani/events{/privacy}","received_events_url":"https://api.github.com/users/waigani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/waigani/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/waigani/juju","forks_url":"https://api.github.com/repos/waigani/juju/forks","keys_url":"https://api.github.com/repos/waigani/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waigani/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waigani/juju/teams","hooks_url":"https://api.github.com/repos/waigani/juju/hooks","issue_events_url":"https://api.github.com/repos/waigani/juju/issues/events{/number}","events_url":"https://api.github.com/repos/waigani/juju/events","assignees_url":"https://api.github.com/repos/waigani/juju/assignees{/user}","branches_url":"https://api.github.com/repos/waigani/juju/branches{/branch}","tags_url":"https://api.github.com/repos/waigani/juju/tags","blobs_url":"https://api.github.com/repos/waigani/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waigani/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waigani/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/waigani/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waigani/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/waigani/juju/languages","stargazers_url":"https://api.github.com/repos/waigani/juju/stargazers","contributors_url":"https://api.github.com/repos/waigani/juju/contributors","subscribers_url":"https://api.github.com/repos/waigani/juju/subscribers","subscription_url":"https://api.github.com/repos/waigani/juju/subscription","commits_url":"https://api.github.com/repos/waigani/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/waigani/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/waigani/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/waigani/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/waigani/juju/contents/{+path}","compare_url":"https://api.github.com/repos/waigani/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waigani/juju/merges","archive_url":"https://api.github.com/repos/waigani/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waigani/juju/downloads","issues_url":"https://api.github.com/repos/waigani/juju/issues{/number}","pulls_url":"https://api.github.com/repos/waigani/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/waigani/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/waigani/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waigani/juju/labels{/name}","releases_url":"https://api.github.com/repos/waigani/juju/releases{/id}","created_at":"2014-06-04T01:27:31Z","updated_at":"2014-06-26T02:26:11Z","pushed_at":"2014-09-01T21:37:53Z","git_url":"git://github.com/waigani/juju.git","ssh_url":"git@github.com:waigani/juju.git","clone_url":"https://github.com/waigani/juju.git","svn_url":"https://github.com/waigani/juju","homepage":null,"size":28859,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"ea0eaa79e6f094735abaec6dd208bf9d7063c72a","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=2","gravatar_id":"b095d1e26e5705abe0ad2de7d87aac2e","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments/{number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2014-09-01T14:24:22Z","pushed_at":"2014-09-01T21:33:36Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":42200,"stargazers_count":203,"watchers_count":203,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":53,"mirror_url":null,"open_issues_count":48,"forks":53,"open_issues":48,"watchers":203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/645"},"html":{"href":"https://github.com/juju/juju/pull/645"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/645"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/645/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/645/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/645/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/e48b49792910cf93455dcab85d30617226b62634"}}}}