GitHub PullRequestReviewCommentEvent at 2014-09-08 17:01:08
Repository: level_up_exercises
Actor: johnmcconnell
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/17251138","id":17251138,"diff_hunk":"@@ -0,0 +1,75 @@\n+require \"./dinodex\"\n+require \"./dinoparsers.rb\"\n+\n+describe DinoDex, \"#query\" do\n+  it \"should match dinos by the block statement\" do\n+\n+    dino_file = \"dinodex.csv\"\n+    dino_parser = DinoParser.new\n+    dinos = dino_parser.parse(dino_file)\n+\n+    dinodex = DinoDex.new(dinos)\n+\n+    result = dinodex.query(:name, :==, \"Albertosaurus\").result\n+\n+    expect(result.size).to eq(1)\n+    expect(result[0].name).to eq(\"Albertosaurus\")\n+    expect(result[0].period).to eq(\"Late Cretaceous\")\n+    expect(result[0].continent).to eq(\"North America\")\n+    expect(result[0].diet).to eq(\"Carnivore\")\n+    expect(result[0].weight).to eq(2000)\n+    expect(result[0].walk).to eq(\"Biped\")\n+    expect(result[0].desc).to eq(\"Like a T-Rex but smaller.\")\n+\n+    result = dinodex.query(\"name\", \">\", \"M\").result\n+    expect(result.size).to eq(3)\n+\n+    result = dinodex.query(\"name\", \">\", \"M\").and(\"weight\", \">\", 4000).result\n+\n+    expect(result.size).to eq(1)\n+    expect(result[0].name).to eq(\"Yangchuanosaurus\")\n+\n+  end\n+\n+  it \"should run a fully chained query\" do\n+\n+    dino_file = \"dinodex.csv\"\n+    dino_parser = DinoParser.new\n+    dinos = dino_parser.parse(dino_file)\n+\n+    dinodex = DinoDex.new(dinos)\n+\n+    result = dinodex.new_query\n+      .and(\"name\", \">=\", \"D\")\n+      .and(\"name\", \"<=\", \"N\")","path":"dino_catalog/spec/dinodex_spec.rb","position":44,"original_position":44,"commit_id":"183ef23d8e121a8f419db5ee6cec871d9c2daf63","original_commit_id":"ce8609e7892676c446b63510aad25f2cdade2317","user":{"login":"johnmcconnell","id":1870400,"avatar_url":"https://avatars.githubusercontent.com/u/1870400?v=2","gravatar_id":"39388bd8c64bbfe0a70756a6de9d94a8","url":"https://api.github.com/users/johnmcconnell","html_url":"https://github.com/johnmcconnell","followers_url":"https://api.github.com/users/johnmcconnell/followers","following_url":"https://api.github.com/users/johnmcconnell/following{/other_user}","gists_url":"https://api.github.com/users/johnmcconnell/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmcconnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmcconnell/subscriptions","organizations_url":"https://api.github.com/users/johnmcconnell/orgs","repos_url":"https://api.github.com/users/johnmcconnell/repos","events_url":"https://api.github.com/users/johnmcconnell/events{/privacy}","received_events_url":"https://api.github.com/users/johnmcconnell/received_events","type":"User","site_admin":false},"body":"Will you never stop!","created_at":"2014-09-08T17:01:08Z","updated_at":"2014-09-08T17:01:08Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/21#discussion_r17251138","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/17251138"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/21#discussion_r17251138"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/21","id":20754966,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/21","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/21.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/21.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/21","number":21,"state":"open","locked":false,"title":"John McConnell Dinodex","user":{"login":"johnmcconnell","id":1870400,"avatar_url":"https://avatars.githubusercontent.com/u/1870400?v=2","gravatar_id":"39388bd8c64bbfe0a70756a6de9d94a8","url":"https://api.github.com/users/johnmcconnell","html_url":"https://github.com/johnmcconnell","followers_url":"https://api.github.com/users/johnmcconnell/followers","following_url":"https://api.github.com/users/johnmcconnell/following{/other_user}","gists_url":"https://api.github.com/users/johnmcconnell/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmcconnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmcconnell/subscriptions","organizations_url":"https://api.github.com/users/johnmcconnell/orgs","repos_url":"https://api.github.com/users/johnmcconnell/repos","events_url":"https://api.github.com/users/johnmcconnell/events{/privacy}","received_events_url":"https://api.github.com/users/johnmcconnell/received_events","type":"User","site_admin":false},"body":"first pull request. I should really change the README.md","created_at":"2014-09-04T16:17:30Z","updated_at":"2014-09-08T17:01:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f767f6364db2a95062b005dc6594bd5a83d52ce5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/21/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/21/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/21/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/183ef23d8e121a8f419db5ee6cec871d9c2daf63","head":{"label":"johnmcconnell:master","ref":"master","sha":"183ef23d8e121a8f419db5ee6cec871d9c2daf63","user":{"login":"johnmcconnell","id":1870400,"avatar_url":"https://avatars.githubusercontent.com/u/1870400?v=2","gravatar_id":"39388bd8c64bbfe0a70756a6de9d94a8","url":"https://api.github.com/users/johnmcconnell","html_url":"https://github.com/johnmcconnell","followers_url":"https://api.github.com/users/johnmcconnell/followers","following_url":"https://api.github.com/users/johnmcconnell/following{/other_user}","gists_url":"https://api.github.com/users/johnmcconnell/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmcconnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmcconnell/subscriptions","organizations_url":"https://api.github.com/users/johnmcconnell/orgs","repos_url":"https://api.github.com/users/johnmcconnell/repos","events_url":"https://api.github.com/users/johnmcconnell/events{/privacy}","received_events_url":"https://api.github.com/users/johnmcconnell/received_events","type":"User","site_admin":false},"repo":{"id":23395006,"name":"level_up_exercises","full_name":"johnmcconnell/level_up_exercises","owner":{"login":"johnmcconnell","id":1870400,"avatar_url":"https://avatars.githubusercontent.com/u/1870400?v=2","gravatar_id":"39388bd8c64bbfe0a70756a6de9d94a8","url":"https://api.github.com/users/johnmcconnell","html_url":"https://github.com/johnmcconnell","followers_url":"https://api.github.com/users/johnmcconnell/followers","following_url":"https://api.github.com/users/johnmcconnell/following{/other_user}","gists_url":"https://api.github.com/users/johnmcconnell/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmcconnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmcconnell/subscriptions","organizations_url":"https://api.github.com/users/johnmcconnell/orgs","repos_url":"https://api.github.com/users/johnmcconnell/repos","events_url":"https://api.github.com/users/johnmcconnell/events{/privacy}","received_events_url":"https://api.github.com/users/johnmcconnell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnmcconnell/level_up_exercises","description":"A long series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/johnmcconnell/level_up_exercises","forks_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/forks","keys_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/events","assignees_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/merges","archive_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/johnmcconnell/level_up_exercises/releases{/id}","created_at":"2014-08-27T15:30:43Z","updated_at":"2014-08-28T20:13:13Z","pushed_at":"2014-09-08T16:32:27Z","git_url":"git://github.com/johnmcconnell/level_up_exercises.git","ssh_url":"git@github.com:johnmcconnell/level_up_exercises.git","clone_url":"https://github.com/johnmcconnell/level_up_exercises.git","svn_url":"https://github.com/johnmcconnell/level_up_exercises","homepage":null,"size":280,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"414233c337d5efe3e0f685c1c5bd79b5a9654920","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=2","gravatar_id":"a9704266587836f7e784235e5073b93e","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=2","gravatar_id":"a9704266587836f7e784235e5073b93e","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A long series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2014-09-02T21:41:48Z","pushed_at":"2014-09-05T16:24:32Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":null,"size":3721,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":21,"mirror_url":null,"open_issues_count":7,"forks":21,"open_issues":7,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/21"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/21"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/21"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/183ef23d8e121a8f419db5ee6cec871d9c2daf63"}}}}