GitHub PullRequestReviewCommentEvent at 2014-12-10 16:48:35
Repository: kubernetes
Actor: zmerlynn
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/21616432","id":21616432,"diff_hunk":"@@ -203,23 +211,83 @@ func Test() (failed, passed []string) {\n \t\t*orderseed = time.Now().UnixNano() & (1<<32 - 1)\n \t}\n \tsort.Strings(toRun)\n+\tif *times != 1 {\n+\t\tif *times < 0 {\n+\t\t\tlog.Fatal(\"Invalid --times!\")\n+\t\t}\n+\t\tnewToRun := make([]string, 0, *times*len(toRun))\n+\t\tfor i := 0; i < *times; i++ {\n+\t\t\tnewToRun = append(newToRun, toRun...)\n+\t\t}\n+\t\ttoRun = newToRun\n+\t}\n \tshuffleStrings(toRun, rand.New(rand.NewSource(*orderseed)))\n \tlog.Printf(\"Running tests matching %v shuffled with seed %#x: %v\", *tests, *orderseed, toRun)\n-\tfor _, name := range toRun {\n+\tresult.ByTest = make(map[string]TestResult)\n+\tfor i, name := range toRun {\n \t\tabsName := filepath.Join(*root, \"hack\", \"e2e-suite\", name)\n-\t\tlog.Printf(\"Starting test %v.\", name)\n-\t\tif runBash(name, absName) {\n+\t\tlog.Printf(\"Starting test [%v/%v]: %v\", i+1, len(toRun), name)\n+\t\ttestResult := result.ByTest[name]\n+\t\tif runTest(name, absName) {\n \t\t\tlog.Printf(\"%v passed\", name)\n-\t\t\tpassed = append(passed, name)\n+\t\t\ttestResult.Pass++\n \t\t} else {\n \t\t\tlog.Printf(\"%v failed\", name)\n-\t\t\tfailed = append(failed, name)\n+\t\t\ttestResult.Fail++\n \t\t}\n+\t\tresult.ByTest[name] = testResult\n \t}\n \n+\treturn\n+}\n+\n+func PrintResults(results TestResults) bool {","path":"hack/e2e.go","position":84,"original_position":88,"commit_id":"7964b0c4fb8bbde5f0e21a76eb3007d52910409c","original_commit_id":"274fc49b40b6ccd0e0268034a024967195d7f031","user":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"body":"(FWIW, I am working on the TAP output.. not trying to punt that completely.)\r\n\r\nOn Tue, Dec 9, 2014, 16:31 Daniel Smith <notifications@github.com> wrote:\r\n\r\n> In hack/e2e.go\r\n> <https://github.com/GoogleCloudPlatform/kubernetes/pull/2800#discussion-diff-21575772>\r\n> :\r\n>\r\n> >  \t}\r\n> >\r\n> > +\treturn\r\n> > +}\r\n> > +\r\n> > +func PrintResults(results TestResults) bool {\r\n>\r\n> http://testanything.org/tap-specification.html\r\n>\r\n> I read it as just a number that counts up with every test emitted. What am\r\n> I missing?\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/GoogleCloudPlatform/kubernetes/pull/2800/files#r21575772>\r\n> .\r\n>","created_at":"2014-12-10T16:48:35Z","updated_at":"2014-12-10T16:48:35Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2800#discussion_r21616432","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2800","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/21616432"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2800#discussion_r21616432"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2800"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2800","id":25709496,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2800","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2800.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2800.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2800","number":2800,"state":"open","locked":false,"title":"Add --times to e2e.go","user":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"body":"Make each test available for execution --times times. Acts like a\r\nmulti-deck shoe. (Otherwise this is easily scriptable outside the\r\ne2e.go command).\r\n\r\nUseful for \"I want to walk away for a few hours leaving some end-to-ends\r\nrunning\", until we have more stress tests. Also useful for detecting\r\nflakes.\r\n\r\nNote that I didn't tackle reporting, which is still pretty rudimentary\r\nfor e2e.go. Now it looks like:\r\n\r\n2014/12/08 15:32:58 Passed tests: [basic.sh basic.sh basic.sh certs.sh certs.sh certs.sh goe2e.sh goe2e.sh goe2e.sh guestbook.sh guestbook.sh guestbook.sh monitoring.sh monitoring.sh monitoring.sh pd.sh pd.sh pd.sh private.sh private.sh private.sh services.sh services.sh services.sh update.sh update.sh update.sh]\r\n2014/12/08 15:32:58 Failed tests: []\r\n\r\nEasy enough to post-process.","created_at":"2014-12-09T00:16:17Z","updated_at":"2014-12-10T16:48:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e49175eec9e78710b0315d8391cb63816c72e83c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2800/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2800/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2800/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/7964b0c4fb8bbde5f0e21a76eb3007d52910409c","head":{"label":"zmerlynn:e2e.times","ref":"e2e.times","sha":"7964b0c4fb8bbde5f0e21a76eb3007d52910409c","user":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"repo":{"id":27641977,"name":"kubernetes","full_name":"zmerlynn/kubernetes","owner":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zmerlynn/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/zmerlynn/kubernetes","forks_url":"https://api.github.com/repos/zmerlynn/kubernetes/forks","keys_url":"https://api.github.com/repos/zmerlynn/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmerlynn/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmerlynn/kubernetes/teams","hooks_url":"https://api.github.com/repos/zmerlynn/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/zmerlynn/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/zmerlynn/kubernetes/events","assignees_url":"https://api.github.com/repos/zmerlynn/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/zmerlynn/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/zmerlynn/kubernetes/tags","blobs_url":"https://api.github.com/repos/zmerlynn/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmerlynn/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmerlynn/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmerlynn/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmerlynn/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/zmerlynn/kubernetes/languages","stargazers_url":"https://api.github.com/repos/zmerlynn/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/zmerlynn/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/zmerlynn/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/zmerlynn/kubernetes/subscription","commits_url":"https://api.github.com/repos/zmerlynn/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmerlynn/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmerlynn/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmerlynn/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/zmerlynn/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/zmerlynn/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmerlynn/kubernetes/merges","archive_url":"https://api.github.com/repos/zmerlynn/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmerlynn/kubernetes/downloads","issues_url":"https://api.github.com/repos/zmerlynn/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/zmerlynn/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/zmerlynn/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/zmerlynn/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmerlynn/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/zmerlynn/kubernetes/releases{/id}","created_at":"2014-12-06T17:10:41Z","updated_at":"2014-12-06T19:12:25Z","pushed_at":"2014-12-10T00:31:45Z","git_url":"git://github.com/zmerlynn/kubernetes.git","ssh_url":"git@github.com:zmerlynn/kubernetes.git","clone_url":"https://github.com/zmerlynn/kubernetes.git","svn_url":"https://github.com/zmerlynn/kubernetes","homepage":null,"size":20495,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"3a201e5eafe6dff43007977c27127c3b8fbf5242","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2014-12-10T16:30:46Z","pushed_at":"2014-12-10T15:13:40Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":null,"size":42924,"stargazers_count":5321,"watchers_count":5321,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":824,"mirror_url":null,"open_issues_count":476,"forks":824,"open_issues":476,"watchers":5321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2800"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/2800"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2800"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/2800/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2800/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/2800/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/7964b0c4fb8bbde5f0e21a76eb3007d52910409c"}}}}