GitHub PullRequestReviewCommentEvent at 2014-09-08 20:47:00
Repository: yajsync
Actor: perlundq
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/perlundq/yajsync/pulls/comments/17265803","id":17265803,"diff_hunk":"@@ -38,9 +40,16 @@ boolean matches(String s)\n         return s.startsWith(_repr);\n     }\n \n+    public void setParameter(String parameter) {\n+    \tthis.parameter = parameter;\n+    }\n+","path":"src/main/com/github/perlundq/yajsync/session/SessionStatus.java","position":20,"original_position":20,"commit_id":"a496907b6292454180725ada6d81ff2f2d625836","original_commit_id":"a496907b6292454180725ada6d81ff2f2d625836","user":{"login":"perlundq","id":3360136,"avatar_url":"https://avatars.githubusercontent.com/u/3360136?v=2","gravatar_id":"9bccd2da604a931c2657d0c092d884d6","url":"https://api.github.com/users/perlundq","html_url":"https://github.com/perlundq","followers_url":"https://api.github.com/users/perlundq/followers","following_url":"https://api.github.com/users/perlundq/following{/other_user}","gists_url":"https://api.github.com/users/perlundq/gists{/gist_id}","starred_url":"https://api.github.com/users/perlundq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perlundq/subscriptions","organizations_url":"https://api.github.com/users/perlundq/orgs","repos_url":"https://api.github.com/users/perlundq/repos","events_url":"https://api.github.com/users/perlundq/events{/privacy}","received_events_url":"https://api.github.com/users/perlundq/received_events","type":"User","site_admin":false},"body":"See above. Please don't do this.","created_at":"2014-09-08T20:47:00Z","updated_at":"2014-09-08T20:47:00Z","html_url":"https://github.com/perlundq/yajsync/pull/6#discussion_r17265803","pull_request_url":"https://api.github.com/repos/perlundq/yajsync/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/perlundq/yajsync/pulls/comments/17265803"},"html":{"href":"https://github.com/perlundq/yajsync/pull/6#discussion_r17265803"},"pull_request":{"href":"https://api.github.com/repos/perlundq/yajsync/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/perlundq/yajsync/pulls/6","id":12593191,"html_url":"https://github.com/perlundq/yajsync/pull/6","diff_url":"https://github.com/perlundq/yajsync/pull/6.diff","patch_url":"https://github.com/perlundq/yajsync/pull/6.patch","issue_url":"https://api.github.com/repos/perlundq/yajsync/issues/6","number":6,"state":"open","locked":false,"title":"Flexible configuration and user authentication","user":{"login":"usrflo","id":1812146,"avatar_url":"https://avatars.githubusercontent.com/u/1812146?v=2","gravatar_id":"07cc0d3e390c24f756490440fb5f45e6","url":"https://api.github.com/users/usrflo","html_url":"https://github.com/usrflo","followers_url":"https://api.github.com/users/usrflo/followers","following_url":"https://api.github.com/users/usrflo/following{/other_user}","gists_url":"https://api.github.com/users/usrflo/gists{/gist_id}","starred_url":"https://api.github.com/users/usrflo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usrflo/subscriptions","organizations_url":"https://api.github.com/users/usrflo/orgs","repos_url":"https://api.github.com/users/usrflo/repos","events_url":"https://api.github.com/users/usrflo/events{/privacy}","received_events_url":"https://api.github.com/users/usrflo/received_events","type":"User","site_admin":false},"body":"- added flexible configuration by 'dictionaries' with sample implementation for file lookups and sql database lookups\r\n- added user authentication based on extended configuration attributes \"auth users\" and \"secrets\"\r\nHint: SessionStatus.AUTHREQ reads username + password. There should be another SessionStatus to request the username without the password for non-auth'ed transmissions","created_at":"2014-02-16T17:20:28Z","updated_at":"2014-09-08T20:47:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/perlundq/yajsync/pulls/6/commits","review_comments_url":"https://api.github.com/repos/perlundq/yajsync/pulls/6/comments","review_comment_url":"https://api.github.com/repos/perlundq/yajsync/pulls/comments/{number}","comments_url":"https://api.github.com/repos/perlundq/yajsync/issues/6/comments","statuses_url":"https://api.github.com/repos/perlundq/yajsync/statuses/a496907b6292454180725ada6d81ff2f2d625836","head":{"label":"usrflo:master","ref":"master","sha":"a496907b6292454180725ada6d81ff2f2d625836","user":{"login":"usrflo","id":1812146,"avatar_url":"https://avatars.githubusercontent.com/u/1812146?v=2","gravatar_id":"07cc0d3e390c24f756490440fb5f45e6","url":"https://api.github.com/users/usrflo","html_url":"https://github.com/usrflo","followers_url":"https://api.github.com/users/usrflo/followers","following_url":"https://api.github.com/users/usrflo/following{/other_user}","gists_url":"https://api.github.com/users/usrflo/gists{/gist_id}","starred_url":"https://api.github.com/users/usrflo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usrflo/subscriptions","organizations_url":"https://api.github.com/users/usrflo/orgs","repos_url":"https://api.github.com/users/usrflo/repos","events_url":"https://api.github.com/users/usrflo/events{/privacy}","received_events_url":"https://api.github.com/users/usrflo/received_events","type":"User","site_admin":false},"repo":{"id":16641427,"name":"yajsync","full_name":"usrflo/yajsync","owner":{"login":"usrflo","id":1812146,"avatar_url":"https://avatars.githubusercontent.com/u/1812146?v=2","gravatar_id":"07cc0d3e390c24f756490440fb5f45e6","url":"https://api.github.com/users/usrflo","html_url":"https://github.com/usrflo","followers_url":"https://api.github.com/users/usrflo/followers","following_url":"https://api.github.com/users/usrflo/following{/other_user}","gists_url":"https://api.github.com/users/usrflo/gists{/gist_id}","starred_url":"https://api.github.com/users/usrflo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usrflo/subscriptions","organizations_url":"https://api.github.com/users/usrflo/orgs","repos_url":"https://api.github.com/users/usrflo/repos","events_url":"https://api.github.com/users/usrflo/events{/privacy}","received_events_url":"https://api.github.com/users/usrflo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/usrflo/yajsync","description":"A minimal implementation of rsync written in Java","fork":true,"url":"https://api.github.com/repos/usrflo/yajsync","forks_url":"https://api.github.com/repos/usrflo/yajsync/forks","keys_url":"https://api.github.com/repos/usrflo/yajsync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usrflo/yajsync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usrflo/yajsync/teams","hooks_url":"https://api.github.com/repos/usrflo/yajsync/hooks","issue_events_url":"https://api.github.com/repos/usrflo/yajsync/issues/events{/number}","events_url":"https://api.github.com/repos/usrflo/yajsync/events","assignees_url":"https://api.github.com/repos/usrflo/yajsync/assignees{/user}","branches_url":"https://api.github.com/repos/usrflo/yajsync/branches{/branch}","tags_url":"https://api.github.com/repos/usrflo/yajsync/tags","blobs_url":"https://api.github.com/repos/usrflo/yajsync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usrflo/yajsync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usrflo/yajsync/git/refs{/sha}","trees_url":"https://api.github.com/repos/usrflo/yajsync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usrflo/yajsync/statuses/{sha}","languages_url":"https://api.github.com/repos/usrflo/yajsync/languages","stargazers_url":"https://api.github.com/repos/usrflo/yajsync/stargazers","contributors_url":"https://api.github.com/repos/usrflo/yajsync/contributors","subscribers_url":"https://api.github.com/repos/usrflo/yajsync/subscribers","subscription_url":"https://api.github.com/repos/usrflo/yajsync/subscription","commits_url":"https://api.github.com/repos/usrflo/yajsync/commits{/sha}","git_commits_url":"https://api.github.com/repos/usrflo/yajsync/git/commits{/sha}","comments_url":"https://api.github.com/repos/usrflo/yajsync/comments{/number}","issue_comment_url":"https://api.github.com/repos/usrflo/yajsync/issues/comments/{number}","contents_url":"https://api.github.com/repos/usrflo/yajsync/contents/{+path}","compare_url":"https://api.github.com/repos/usrflo/yajsync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usrflo/yajsync/merges","archive_url":"https://api.github.com/repos/usrflo/yajsync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usrflo/yajsync/downloads","issues_url":"https://api.github.com/repos/usrflo/yajsync/issues{/number}","pulls_url":"https://api.github.com/repos/usrflo/yajsync/pulls{/number}","milestones_url":"https://api.github.com/repos/usrflo/yajsync/milestones{/number}","notifications_url":"https://api.github.com/repos/usrflo/yajsync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usrflo/yajsync/labels{/name}","releases_url":"https://api.github.com/repos/usrflo/yajsync/releases{/id}","created_at":"2014-02-08T11:09:52Z","updated_at":"2014-03-17T11:13:40Z","pushed_at":"2014-03-17T11:13:39Z","git_url":"git://github.com/usrflo/yajsync.git","ssh_url":"git@github.com:usrflo/yajsync.git","clone_url":"https://github.com/usrflo/yajsync.git","svn_url":"https://github.com/usrflo/yajsync","homepage":null,"size":536,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"perlundq:master","ref":"master","sha":"7fe4da9247b44bd121c7a3a47373f8371d368da3","user":{"login":"perlundq","id":3360136,"avatar_url":"https://avatars.githubusercontent.com/u/3360136?v=2","gravatar_id":"9bccd2da604a931c2657d0c092d884d6","url":"https://api.github.com/users/perlundq","html_url":"https://github.com/perlundq","followers_url":"https://api.github.com/users/perlundq/followers","following_url":"https://api.github.com/users/perlundq/following{/other_user}","gists_url":"https://api.github.com/users/perlundq/gists{/gist_id}","starred_url":"https://api.github.com/users/perlundq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perlundq/subscriptions","organizations_url":"https://api.github.com/users/perlundq/orgs","repos_url":"https://api.github.com/users/perlundq/repos","events_url":"https://api.github.com/users/perlundq/events{/privacy}","received_events_url":"https://api.github.com/users/perlundq/received_events","type":"User","site_admin":false},"repo":{"id":15758326,"name":"yajsync","full_name":"perlundq/yajsync","owner":{"login":"perlundq","id":3360136,"avatar_url":"https://avatars.githubusercontent.com/u/3360136?v=2","gravatar_id":"9bccd2da604a931c2657d0c092d884d6","url":"https://api.github.com/users/perlundq","html_url":"https://github.com/perlundq","followers_url":"https://api.github.com/users/perlundq/followers","following_url":"https://api.github.com/users/perlundq/following{/other_user}","gists_url":"https://api.github.com/users/perlundq/gists{/gist_id}","starred_url":"https://api.github.com/users/perlundq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perlundq/subscriptions","organizations_url":"https://api.github.com/users/perlundq/orgs","repos_url":"https://api.github.com/users/perlundq/repos","events_url":"https://api.github.com/users/perlundq/events{/privacy}","received_events_url":"https://api.github.com/users/perlundq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/perlundq/yajsync","description":"A native implementation of the rsync protocol written in Java","fork":false,"url":"https://api.github.com/repos/perlundq/yajsync","forks_url":"https://api.github.com/repos/perlundq/yajsync/forks","keys_url":"https://api.github.com/repos/perlundq/yajsync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/perlundq/yajsync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/perlundq/yajsync/teams","hooks_url":"https://api.github.com/repos/perlundq/yajsync/hooks","issue_events_url":"https://api.github.com/repos/perlundq/yajsync/issues/events{/number}","events_url":"https://api.github.com/repos/perlundq/yajsync/events","assignees_url":"https://api.github.com/repos/perlundq/yajsync/assignees{/user}","branches_url":"https://api.github.com/repos/perlundq/yajsync/branches{/branch}","tags_url":"https://api.github.com/repos/perlundq/yajsync/tags","blobs_url":"https://api.github.com/repos/perlundq/yajsync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/perlundq/yajsync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/perlundq/yajsync/git/refs{/sha}","trees_url":"https://api.github.com/repos/perlundq/yajsync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/perlundq/yajsync/statuses/{sha}","languages_url":"https://api.github.com/repos/perlundq/yajsync/languages","stargazers_url":"https://api.github.com/repos/perlundq/yajsync/stargazers","contributors_url":"https://api.github.com/repos/perlundq/yajsync/contributors","subscribers_url":"https://api.github.com/repos/perlundq/yajsync/subscribers","subscription_url":"https://api.github.com/repos/perlundq/yajsync/subscription","commits_url":"https://api.github.com/repos/perlundq/yajsync/commits{/sha}","git_commits_url":"https://api.github.com/repos/perlundq/yajsync/git/commits{/sha}","comments_url":"https://api.github.com/repos/perlundq/yajsync/comments{/number}","issue_comment_url":"https://api.github.com/repos/perlundq/yajsync/issues/comments/{number}","contents_url":"https://api.github.com/repos/perlundq/yajsync/contents/{+path}","compare_url":"https://api.github.com/repos/perlundq/yajsync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/perlundq/yajsync/merges","archive_url":"https://api.github.com/repos/perlundq/yajsync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/perlundq/yajsync/downloads","issues_url":"https://api.github.com/repos/perlundq/yajsync/issues{/number}","pulls_url":"https://api.github.com/repos/perlundq/yajsync/pulls{/number}","milestones_url":"https://api.github.com/repos/perlundq/yajsync/milestones{/number}","notifications_url":"https://api.github.com/repos/perlundq/yajsync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/perlundq/yajsync/labels{/name}","releases_url":"https://api.github.com/repos/perlundq/yajsync/releases{/id}","created_at":"2014-01-09T06:16:40Z","updated_at":"2014-08-12T13:18:54Z","pushed_at":"2014-02-16T13:42:27Z","git_url":"git://github.com/perlundq/yajsync.git","ssh_url":"git@github.com:perlundq/yajsync.git","clone_url":"https://github.com/perlundq/yajsync.git","svn_url":"https://github.com/perlundq/yajsync","homepage":"","size":520,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/perlundq/yajsync/pulls/6"},"html":{"href":"https://github.com/perlundq/yajsync/pull/6"},"issue":{"href":"https://api.github.com/repos/perlundq/yajsync/issues/6"},"comments":{"href":"https://api.github.com/repos/perlundq/yajsync/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/perlundq/yajsync/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/perlundq/yajsync/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/perlundq/yajsync/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/perlundq/yajsync/statuses/a496907b6292454180725ada6d81ff2f2d625836"}}}}