GitHub PullRequestEvent at 2014-01-08 22:35:08
Repository: kazoo
Actor: bbangert
Payload: {"action":"closed","number":152,"pull_request":{"url":"https://api.github.com/repos/python-zk/kazoo/pulls/152","id":11122668,"html_url":"https://github.com/python-zk/kazoo/pull/152","diff_url":"https://github.com/python-zk/kazoo/pull/152.diff","patch_url":"https://github.com/python-zk/kazoo/pull/152.patch","issue_url":"https://github.com/python-zk/kazoo/pull/152","number":152,"state":"closed","title":"Make add_auth and add_auth_async consistent with the rest of the API","user":{"login":"rgs1","id":1349891,"avatar_url":"https://gravatar.com/avatar/f78c6190bfff644bd7beb7cbc1d25671?d=https%3A%2F%2Fidenticons.github.com%2Fa22062761465b280b2fa9aadf54d29e2.png&r=x","gravatar_id":"f78c6190bfff644bd7beb7cbc1d25671","url":"https://api.github.com/users/rgs1","html_url":"https://github.com/rgs1","followers_url":"https://api.github.com/users/rgs1/followers","following_url":"https://api.github.com/users/rgs1/following{/other_user}","gists_url":"https://api.github.com/users/rgs1/gists{/gist_id}","starred_url":"https://api.github.com/users/rgs1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgs1/subscriptions","organizations_url":"https://api.github.com/users/rgs1/orgs","repos_url":"https://api.github.com/users/rgs1/repos","events_url":"https://api.github.com/users/rgs1/events{/privacy}","received_events_url":"https://api.github.com/users/rgs1/received_events","type":"User","site_admin":false},"body":"Even though ZK closes the connection when auth fails (though the session is\r\nstill valid!) it is nicer to have add_auth be consistent with the rest\r\nof the API by setting an exception on the AsyncResult object. It is\r\nalso more consisent if the sync version has a return value as well (i.e.: True)\r\nor an exception raised when it fails.\r\n\r\nWe still switch the state to KeeperState.AUTH_FAILED after failing (since the conexion\r\nis closed by the server).\r\n\r\nThis change doesn't break the current behavior (except for adding the return\r\nvalues which shouldn't break anything). It also makes the API docs correct :-)","created_at":"2013-12-28T02:20:01Z","updated_at":"2014-01-08T22:35:08Z","closed_at":"2014-01-08T22:35:08Z","merged_at":"2014-01-08T22:35:08Z","merge_commit_sha":"154f0a3733c14636ae0ffe61736dfe03328fa9f5","assignee":null,"milestone":null,"commits_url":"https://github.com/python-zk/kazoo/pull/152/commits","review_comments_url":"https://github.com/python-zk/kazoo/pull/152/comments","review_comment_url":"/repos/python-zk/kazoo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/python-zk/kazoo/issues/152/comments","statuses_url":"https://api.github.com/repos/python-zk/kazoo/statuses/15b7632fba6cbb2f31bda95eb4ca4ad327c04919","head":{"label":"rgs1:add-auth-async-consistency","ref":"add-auth-async-consistency","sha":"15b7632fba6cbb2f31bda95eb4ca4ad327c04919","user":{"login":"rgs1","id":1349891,"avatar_url":"https://gravatar.com/avatar/f78c6190bfff644bd7beb7cbc1d25671?d=https%3A%2F%2Fidenticons.github.com%2Fa22062761465b280b2fa9aadf54d29e2.png&r=x","gravatar_id":"f78c6190bfff644bd7beb7cbc1d25671","url":"https://api.github.com/users/rgs1","html_url":"https://github.com/rgs1","followers_url":"https://api.github.com/users/rgs1/followers","following_url":"https://api.github.com/users/rgs1/following{/other_user}","gists_url":"https://api.github.com/users/rgs1/gists{/gist_id}","starred_url":"https://api.github.com/users/rgs1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgs1/subscriptions","organizations_url":"https://api.github.com/users/rgs1/orgs","repos_url":"https://api.github.com/users/rgs1/repos","events_url":"https://api.github.com/users/rgs1/events{/privacy}","received_events_url":"https://api.github.com/users/rgs1/received_events","type":"User","site_admin":false},"repo":{"id":12116916,"name":"kazoo","full_name":"rgs1/kazoo","owner":{"login":"rgs1","id":1349891,"avatar_url":"https://gravatar.com/avatar/f78c6190bfff644bd7beb7cbc1d25671?d=https%3A%2F%2Fidenticons.github.com%2Fa22062761465b280b2fa9aadf54d29e2.png&r=x","gravatar_id":"f78c6190bfff644bd7beb7cbc1d25671","url":"https://api.github.com/users/rgs1","html_url":"https://github.com/rgs1","followers_url":"https://api.github.com/users/rgs1/followers","following_url":"https://api.github.com/users/rgs1/following{/other_user}","gists_url":"https://api.github.com/users/rgs1/gists{/gist_id}","starred_url":"https://api.github.com/users/rgs1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgs1/subscriptions","organizations_url":"https://api.github.com/users/rgs1/orgs","repos_url":"https://api.github.com/users/rgs1/repos","events_url":"https://api.github.com/users/rgs1/events{/privacy}","received_events_url":"https://api.github.com/users/rgs1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgs1/kazoo","description":"Kazoo is a higher level Python library that makes it easier to use Zookeeper.","fork":true,"url":"https://api.github.com/repos/rgs1/kazoo","forks_url":"https://api.github.com/repos/rgs1/kazoo/forks","keys_url":"https://api.github.com/repos/rgs1/kazoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgs1/kazoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgs1/kazoo/teams","hooks_url":"https://api.github.com/repos/rgs1/kazoo/hooks","issue_events_url":"https://api.github.com/repos/rgs1/kazoo/issues/events{/number}","events_url":"https://api.github.com/repos/rgs1/kazoo/events","assignees_url":"https://api.github.com/repos/rgs1/kazoo/assignees{/user}","branches_url":"https://api.github.com/repos/rgs1/kazoo/branches{/branch}","tags_url":"https://api.github.com/repos/rgs1/kazoo/tags","blobs_url":"https://api.github.com/repos/rgs1/kazoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgs1/kazoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgs1/kazoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgs1/kazoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgs1/kazoo/statuses/{sha}","languages_url":"https://api.github.com/repos/rgs1/kazoo/languages","stargazers_url":"https://api.github.com/repos/rgs1/kazoo/stargazers","contributors_url":"https://api.github.com/repos/rgs1/kazoo/contributors","subscribers_url":"https://api.github.com/repos/rgs1/kazoo/subscribers","subscription_url":"https://api.github.com/repos/rgs1/kazoo/subscription","commits_url":"https://api.github.com/repos/rgs1/kazoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgs1/kazoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgs1/kazoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgs1/kazoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/rgs1/kazoo/contents/{+path}","compare_url":"https://api.github.com/repos/rgs1/kazoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgs1/kazoo/merges","archive_url":"https://api.github.com/repos/rgs1/kazoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgs1/kazoo/downloads","issues_url":"https://api.github.com/repos/rgs1/kazoo/issues{/number}","pulls_url":"https://api.github.com/repos/rgs1/kazoo/pulls{/number}","milestones_url":"https://api.github.com/repos/rgs1/kazoo/milestones{/number}","notifications_url":"https://api.github.com/repos/rgs1/kazoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgs1/kazoo/labels{/name}","releases_url":"https://api.github.com/repos/rgs1/kazoo/releases{/id}","created_at":"2013-08-14T18:58:45Z","updated_at":"2014-01-08T22:35:08Z","pushed_at":"2014-01-04T01:55:54Z","git_url":"git://github.com/rgs1/kazoo.git","ssh_url":"git@github.com:rgs1/kazoo.git","clone_url":"https://github.com/rgs1/kazoo.git","svn_url":"https://github.com/rgs1/kazoo","homepage":null,"size":1811,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"python-zk:master","ref":"master","sha":"37b14fd5931bc880cebda37e2ffd3dced0eb11db","user":{"login":"python-zk","id":1731709,"avatar_url":"https://gravatar.com/avatar/d65bfb534e674d4d950c48181cd19a16?d=https%3A%2F%2Fidenticons.github.com%2Fb72319e708e52c87ee689d594c042d56.png&r=x","gravatar_id":"d65bfb534e674d4d950c48181cd19a16","url":"https://api.github.com/users/python-zk","html_url":"https://github.com/python-zk","followers_url":"https://api.github.com/users/python-zk/followers","following_url":"https://api.github.com/users/python-zk/following{/other_user}","gists_url":"https://api.github.com/users/python-zk/gists{/gist_id}","starred_url":"https://api.github.com/users/python-zk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-zk/subscriptions","organizations_url":"https://api.github.com/users/python-zk/orgs","repos_url":"https://api.github.com/users/python-zk/repos","events_url":"https://api.github.com/users/python-zk/events{/privacy}","received_events_url":"https://api.github.com/users/python-zk/received_events","type":"Organization","site_admin":false},"repo":{"id":4426689,"name":"kazoo","full_name":"python-zk/kazoo","owner":{"login":"python-zk","id":1731709,"avatar_url":"https://gravatar.com/avatar/d65bfb534e674d4d950c48181cd19a16?d=https%3A%2F%2Fidenticons.github.com%2Fb72319e708e52c87ee689d594c042d56.png&r=x","gravatar_id":"d65bfb534e674d4d950c48181cd19a16","url":"https://api.github.com/users/python-zk","html_url":"https://github.com/python-zk","followers_url":"https://api.github.com/users/python-zk/followers","following_url":"https://api.github.com/users/python-zk/following{/other_user}","gists_url":"https://api.github.com/users/python-zk/gists{/gist_id}","starred_url":"https://api.github.com/users/python-zk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-zk/subscriptions","organizations_url":"https://api.github.com/users/python-zk/orgs","repos_url":"https://api.github.com/users/python-zk/repos","events_url":"https://api.github.com/users/python-zk/events{/privacy}","received_events_url":"https://api.github.com/users/python-zk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-zk/kazoo","description":"Kazoo is a high-level Python library that makes it easier to use Apache Zookeeper.","fork":false,"url":"https://api.github.com/repos/python-zk/kazoo","forks_url":"https://api.github.com/repos/python-zk/kazoo/forks","keys_url":"https://api.github.com/repos/python-zk/kazoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-zk/kazoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-zk/kazoo/teams","hooks_url":"https://api.github.com/repos/python-zk/kazoo/hooks","issue_events_url":"https://api.github.com/repos/python-zk/kazoo/issues/events{/number}","events_url":"https://api.github.com/repos/python-zk/kazoo/events","assignees_url":"https://api.github.com/repos/python-zk/kazoo/assignees{/user}","branches_url":"https://api.github.com/repos/python-zk/kazoo/branches{/branch}","tags_url":"https://api.github.com/repos/python-zk/kazoo/tags","blobs_url":"https://api.github.com/repos/python-zk/kazoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-zk/kazoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-zk/kazoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-zk/kazoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-zk/kazoo/statuses/{sha}","languages_url":"https://api.github.com/repos/python-zk/kazoo/languages","stargazers_url":"https://api.github.com/repos/python-zk/kazoo/stargazers","contributors_url":"https://api.github.com/repos/python-zk/kazoo/contributors","subscribers_url":"https://api.github.com/repos/python-zk/kazoo/subscribers","subscription_url":"https://api.github.com/repos/python-zk/kazoo/subscription","commits_url":"https://api.github.com/repos/python-zk/kazoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-zk/kazoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-zk/kazoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-zk/kazoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/python-zk/kazoo/contents/{+path}","compare_url":"https://api.github.com/repos/python-zk/kazoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-zk/kazoo/merges","archive_url":"https://api.github.com/repos/python-zk/kazoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-zk/kazoo/downloads","issues_url":"https://api.github.com/repos/python-zk/kazoo/issues{/number}","pulls_url":"https://api.github.com/repos/python-zk/kazoo/pulls{/number}","milestones_url":"https://api.github.com/repos/python-zk/kazoo/milestones{/number}","notifications_url":"https://api.github.com/repos/python-zk/kazoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-zk/kazoo/labels{/name}","releases_url":"https://api.github.com/repos/python-zk/kazoo/releases{/id}","created_at":"2012-05-23T23:46:42Z","updated_at":"2014-01-08T22:35:08Z","pushed_at":"2014-01-08T22:35:08Z","git_url":"git://github.com/python-zk/kazoo.git","ssh_url":"git@github.com:python-zk/kazoo.git","clone_url":"https://github.com/python-zk/kazoo.git","svn_url":"https://github.com/python-zk/kazoo","homepage":"https://kazoo.readthedocs.org","size":3081,"stargazers_count":176,"watchers_count":176,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":74,"mirror_url":null,"open_issues_count":21,"forks":74,"open_issues":21,"watchers":176,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-zk/kazoo/pulls/152"},"html":{"href":"https://github.com/python-zk/kazoo/pull/152"},"issue":{"href":"https://api.github.com/repos/python-zk/kazoo/issues/152"},"comments":{"href":"https://api.github.com/repos/python-zk/kazoo/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/python-zk/kazoo/pulls/152/comments"},"statuses":{"href":"https://api.github.com/repos/python-zk/kazoo/statuses/15b7632fba6cbb2f31bda95eb4ca4ad327c04919"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bbangert","id":100193,"avatar_url":"https://gravatar.com/avatar/1e59eddcbc19e7d424686e0644db65de?d=https%3A%2F%2Fidenticons.github.com%2F22ebf51b933712766b8809c933c177b7.png&r=x","gravatar_id":"1e59eddcbc19e7d424686e0644db65de","url":"https://api.github.com/users/bbangert","html_url":"https://github.com/bbangert","followers_url":"https://api.github.com/users/bbangert/followers","following_url":"https://api.github.com/users/bbangert/following{/other_user}","gists_url":"https://api.github.com/users/bbangert/gists{/gist_id}","starred_url":"https://api.github.com/users/bbangert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbangert/subscriptions","organizations_url":"https://api.github.com/users/bbangert/orgs","repos_url":"https://api.github.com/users/bbangert/repos","events_url":"https://api.github.com/users/bbangert/events{/privacy}","received_events_url":"https://api.github.com/users/bbangert/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":39,"deletions":16,"changed_files":3}}