GitHub PullRequestReviewCommentEvent at 2014-12-19 21:13:07
Repository: walker
Actor: dankinder
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/iParadigms/walker/pulls/comments/22129197","id":22129197,"diff_hunk":"@@ -95,6 +95,15 @@ fetcher:\n     # The keep-alive period is active_fetchers_ttl * active_fetchers_keepratio.\n     active_fetchers_keepratio: 0.75\n \n+    # Controls the http Keep-Alive setting when fetching pages. Can be \"always\" (to always\n+    # keep a connection alive), \"never\" (to never keep connection alive), and threshold (keep\n+    # connection alive if the target sites robots.Crawl-Delay is less than http_keep_alive_threshold)\n+    http_keep_alive: \"always\"\n+\n+    # If http_keep_alive is set to \"threashold\", sets the Keep-Alive policy (see above). Otherwise,\n+    # this variable is unused.\n+    http_keep_alive_threashold: 15s","path":"walker.yaml","position":11,"original_position":11,"commit_id":"6a1eb9cb063f44aca68289783cb47dd6617e5af3","original_commit_id":"6a1eb9cb063f44aca68289783cb47dd6617e5af3","user":{"login":"dankinder","id":5198575,"avatar_url":"https://avatars.githubusercontent.com/u/5198575?v=3","gravatar_id":"","url":"https://api.github.com/users/dankinder","html_url":"https://github.com/dankinder","followers_url":"https://api.github.com/users/dankinder/followers","following_url":"https://api.github.com/users/dankinder/following{/other_user}","gists_url":"https://api.github.com/users/dankinder/gists{/gist_id}","starred_url":"https://api.github.com/users/dankinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankinder/subscriptions","organizations_url":"https://api.github.com/users/dankinder/orgs","repos_url":"https://api.github.com/users/dankinder/repos","events_url":"https://api.github.com/users/dankinder/events{/privacy}","received_events_url":"https://api.github.com/users/dankinder/received_events","type":"User","site_admin":false},"body":"Matching misspelling here","created_at":"2014-12-19T21:13:07Z","updated_at":"2014-12-19T21:13:07Z","html_url":"https://github.com/iParadigms/walker/pull/118#discussion_r22129197","pull_request_url":"https://api.github.com/repos/iParadigms/walker/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/iParadigms/walker/pulls/comments/22129197"},"html":{"href":"https://github.com/iParadigms/walker/pull/118#discussion_r22129197"},"pull_request":{"href":"https://api.github.com/repos/iParadigms/walker/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/iParadigms/walker/pulls/118","id":26390980,"html_url":"https://github.com/iParadigms/walker/pull/118","diff_url":"https://github.com/iParadigms/walker/pull/118.diff","patch_url":"https://github.com/iParadigms/walker/pull/118.patch","issue_url":"https://api.github.com/repos/iParadigms/walker/issues/118","number":118,"state":"open","locked":false,"title":"Trn 125","user":{"login":"pchristopher1275","id":8377190,"avatar_url":"https://avatars.githubusercontent.com/u/8377190?v=3","gravatar_id":"","url":"https://api.github.com/users/pchristopher1275","html_url":"https://github.com/pchristopher1275","followers_url":"https://api.github.com/users/pchristopher1275/followers","following_url":"https://api.github.com/users/pchristopher1275/following{/other_user}","gists_url":"https://api.github.com/users/pchristopher1275/gists{/gist_id}","starred_url":"https://api.github.com/users/pchristopher1275/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchristopher1275/subscriptions","organizations_url":"https://api.github.com/users/pchristopher1275/orgs","repos_url":"https://api.github.com/users/pchristopher1275/repos","events_url":"https://api.github.com/users/pchristopher1275/events{/privacy}","received_events_url":"https://api.github.com/users/pchristopher1275/received_events","type":"User","site_admin":false},"body":"--> Original ticket (https://jira2.iparadigms.com/browse/TRN-125)\r\nBy default the go http client will allow keep-alive connections (http://golang.org/pkg/net/http/). We will need some control over this, because when we start crawling too many sites from one host we cannot keep too many connections alive and we'll just be wasting resources.\r\nAt minimum we need a configuration flag for whether to use keep-alive at all.\r\nIdeally this would be handled intelligently where Walker will use keep-alive when the crawl-delay is low enough. Part of this ticket should be figuring out how we can do this and possibly implementing a basic flag.\r\n\r\n--> repost\r\n\r\nAdding more detail here as I've thought it through. The following suggested specifics are up for discussion:\r\nAdd a config key http_keep_alive with 3 possible values:\r\nalways: as indicated, always uses keep-alive when it is able\r\nthreshold: use keep-alive when crawl delay is less than or equal to a given threshold (a separate config key http_keep_alive_threshold)\r\nnever; do not use keep-alive\r\n\r\n--> end","created_at":"2014-12-19T18:51:04Z","updated_at":"2014-12-19T21:13:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cd42c8780cb0146ae0666a900e0969ea35d81ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iParadigms/walker/pulls/118/commits","review_comments_url":"https://api.github.com/repos/iParadigms/walker/pulls/118/comments","review_comment_url":"https://api.github.com/repos/iParadigms/walker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/iParadigms/walker/issues/118/comments","statuses_url":"https://api.github.com/repos/iParadigms/walker/statuses/6a1eb9cb063f44aca68289783cb47dd6617e5af3","head":{"label":"iParadigms:TRN-125","ref":"TRN-125","sha":"6a1eb9cb063f44aca68289783cb47dd6617e5af3","user":{"login":"iParadigms","id":5193049,"avatar_url":"https://avatars.githubusercontent.com/u/5193049?v=3","gravatar_id":"","url":"https://api.github.com/users/iParadigms","html_url":"https://github.com/iParadigms","followers_url":"https://api.github.com/users/iParadigms/followers","following_url":"https://api.github.com/users/iParadigms/following{/other_user}","gists_url":"https://api.github.com/users/iParadigms/gists{/gist_id}","starred_url":"https://api.github.com/users/iParadigms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iParadigms/subscriptions","organizations_url":"https://api.github.com/users/iParadigms/orgs","repos_url":"https://api.github.com/users/iParadigms/repos","events_url":"https://api.github.com/users/iParadigms/events{/privacy}","received_events_url":"https://api.github.com/users/iParadigms/received_events","type":"Organization","site_admin":false},"repo":{"id":22963084,"name":"walker","full_name":"iParadigms/walker","owner":{"login":"iParadigms","id":5193049,"avatar_url":"https://avatars.githubusercontent.com/u/5193049?v=3","gravatar_id":"","url":"https://api.github.com/users/iParadigms","html_url":"https://github.com/iParadigms","followers_url":"https://api.github.com/users/iParadigms/followers","following_url":"https://api.github.com/users/iParadigms/following{/other_user}","gists_url":"https://api.github.com/users/iParadigms/gists{/gist_id}","starred_url":"https://api.github.com/users/iParadigms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iParadigms/subscriptions","organizations_url":"https://api.github.com/users/iParadigms/orgs","repos_url":"https://api.github.com/users/iParadigms/repos","events_url":"https://api.github.com/users/iParadigms/events{/privacy}","received_events_url":"https://api.github.com/users/iParadigms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iParadigms/walker","description":"An efficient, scalable, open source crawler leveraging Go and Cassandra","fork":false,"url":"https://api.github.com/repos/iParadigms/walker","forks_url":"https://api.github.com/repos/iParadigms/walker/forks","keys_url":"https://api.github.com/repos/iParadigms/walker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iParadigms/walker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iParadigms/walker/teams","hooks_url":"https://api.github.com/repos/iParadigms/walker/hooks","issue_events_url":"https://api.github.com/repos/iParadigms/walker/issues/events{/number}","events_url":"https://api.github.com/repos/iParadigms/walker/events","assignees_url":"https://api.github.com/repos/iParadigms/walker/assignees{/user}","branches_url":"https://api.github.com/repos/iParadigms/walker/branches{/branch}","tags_url":"https://api.github.com/repos/iParadigms/walker/tags","blobs_url":"https://api.github.com/repos/iParadigms/walker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iParadigms/walker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iParadigms/walker/git/refs{/sha}","trees_url":"https://api.github.com/repos/iParadigms/walker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iParadigms/walker/statuses/{sha}","languages_url":"https://api.github.com/repos/iParadigms/walker/languages","stargazers_url":"https://api.github.com/repos/iParadigms/walker/stargazers","contributors_url":"https://api.github.com/repos/iParadigms/walker/contributors","subscribers_url":"https://api.github.com/repos/iParadigms/walker/subscribers","subscription_url":"https://api.github.com/repos/iParadigms/walker/subscription","commits_url":"https://api.github.com/repos/iParadigms/walker/commits{/sha}","git_commits_url":"https://api.github.com/repos/iParadigms/walker/git/commits{/sha}","comments_url":"https://api.github.com/repos/iParadigms/walker/comments{/number}","issue_comment_url":"https://api.github.com/repos/iParadigms/walker/issues/comments/{number}","contents_url":"https://api.github.com/repos/iParadigms/walker/contents/{+path}","compare_url":"https://api.github.com/repos/iParadigms/walker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iParadigms/walker/merges","archive_url":"https://api.github.com/repos/iParadigms/walker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iParadigms/walker/downloads","issues_url":"https://api.github.com/repos/iParadigms/walker/issues{/number}","pulls_url":"https://api.github.com/repos/iParadigms/walker/pulls{/number}","milestones_url":"https://api.github.com/repos/iParadigms/walker/milestones{/number}","notifications_url":"https://api.github.com/repos/iParadigms/walker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iParadigms/walker/labels{/name}","releases_url":"https://api.github.com/repos/iParadigms/walker/releases{/id}","created_at":"2014-08-14T17:49:18Z","updated_at":"2014-12-17T18:07:21Z","pushed_at":"2014-12-19T20:48:22Z","git_url":"git://github.com/iParadigms/walker.git","ssh_url":"git@github.com:iParadigms/walker.git","clone_url":"https://github.com/iParadigms/walker.git","svn_url":"https://github.com/iParadigms/walker","homepage":"","size":3661,"stargazers_count":9,"watchers_count":9,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":9,"default_branch":"master"}},"base":{"label":"iParadigms:master","ref":"master","sha":"3cae646886f5775da3f84bdeef5dfdb8e08ad022","user":{"login":"iParadigms","id":5193049,"avatar_url":"https://avatars.githubusercontent.com/u/5193049?v=3","gravatar_id":"","url":"https://api.github.com/users/iParadigms","html_url":"https://github.com/iParadigms","followers_url":"https://api.github.com/users/iParadigms/followers","following_url":"https://api.github.com/users/iParadigms/following{/other_user}","gists_url":"https://api.github.com/users/iParadigms/gists{/gist_id}","starred_url":"https://api.github.com/users/iParadigms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iParadigms/subscriptions","organizations_url":"https://api.github.com/users/iParadigms/orgs","repos_url":"https://api.github.com/users/iParadigms/repos","events_url":"https://api.github.com/users/iParadigms/events{/privacy}","received_events_url":"https://api.github.com/users/iParadigms/received_events","type":"Organization","site_admin":false},"repo":{"id":22963084,"name":"walker","full_name":"iParadigms/walker","owner":{"login":"iParadigms","id":5193049,"avatar_url":"https://avatars.githubusercontent.com/u/5193049?v=3","gravatar_id":"","url":"https://api.github.com/users/iParadigms","html_url":"https://github.com/iParadigms","followers_url":"https://api.github.com/users/iParadigms/followers","following_url":"https://api.github.com/users/iParadigms/following{/other_user}","gists_url":"https://api.github.com/users/iParadigms/gists{/gist_id}","starred_url":"https://api.github.com/users/iParadigms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iParadigms/subscriptions","organizations_url":"https://api.github.com/users/iParadigms/orgs","repos_url":"https://api.github.com/users/iParadigms/repos","events_url":"https://api.github.com/users/iParadigms/events{/privacy}","received_events_url":"https://api.github.com/users/iParadigms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iParadigms/walker","description":"An efficient, scalable, open source crawler leveraging Go and Cassandra","fork":false,"url":"https://api.github.com/repos/iParadigms/walker","forks_url":"https://api.github.com/repos/iParadigms/walker/forks","keys_url":"https://api.github.com/repos/iParadigms/walker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iParadigms/walker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iParadigms/walker/teams","hooks_url":"https://api.github.com/repos/iParadigms/walker/hooks","issue_events_url":"https://api.github.com/repos/iParadigms/walker/issues/events{/number}","events_url":"https://api.github.com/repos/iParadigms/walker/events","assignees_url":"https://api.github.com/repos/iParadigms/walker/assignees{/user}","branches_url":"https://api.github.com/repos/iParadigms/walker/branches{/branch}","tags_url":"https://api.github.com/repos/iParadigms/walker/tags","blobs_url":"https://api.github.com/repos/iParadigms/walker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iParadigms/walker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iParadigms/walker/git/refs{/sha}","trees_url":"https://api.github.com/repos/iParadigms/walker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iParadigms/walker/statuses/{sha}","languages_url":"https://api.github.com/repos/iParadigms/walker/languages","stargazers_url":"https://api.github.com/repos/iParadigms/walker/stargazers","contributors_url":"https://api.github.com/repos/iParadigms/walker/contributors","subscribers_url":"https://api.github.com/repos/iParadigms/walker/subscribers","subscription_url":"https://api.github.com/repos/iParadigms/walker/subscription","commits_url":"https://api.github.com/repos/iParadigms/walker/commits{/sha}","git_commits_url":"https://api.github.com/repos/iParadigms/walker/git/commits{/sha}","comments_url":"https://api.github.com/repos/iParadigms/walker/comments{/number}","issue_comment_url":"https://api.github.com/repos/iParadigms/walker/issues/comments/{number}","contents_url":"https://api.github.com/repos/iParadigms/walker/contents/{+path}","compare_url":"https://api.github.com/repos/iParadigms/walker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iParadigms/walker/merges","archive_url":"https://api.github.com/repos/iParadigms/walker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iParadigms/walker/downloads","issues_url":"https://api.github.com/repos/iParadigms/walker/issues{/number}","pulls_url":"https://api.github.com/repos/iParadigms/walker/pulls{/number}","milestones_url":"https://api.github.com/repos/iParadigms/walker/milestones{/number}","notifications_url":"https://api.github.com/repos/iParadigms/walker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iParadigms/walker/labels{/name}","releases_url":"https://api.github.com/repos/iParadigms/walker/releases{/id}","created_at":"2014-08-14T17:49:18Z","updated_at":"2014-12-17T18:07:21Z","pushed_at":"2014-12-19T20:48:22Z","git_url":"git://github.com/iParadigms/walker.git","ssh_url":"git@github.com:iParadigms/walker.git","clone_url":"https://github.com/iParadigms/walker.git","svn_url":"https://github.com/iParadigms/walker","homepage":"","size":3661,"stargazers_count":9,"watchers_count":9,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iParadigms/walker/pulls/118"},"html":{"href":"https://github.com/iParadigms/walker/pull/118"},"issue":{"href":"https://api.github.com/repos/iParadigms/walker/issues/118"},"comments":{"href":"https://api.github.com/repos/iParadigms/walker/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/iParadigms/walker/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/iParadigms/walker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/iParadigms/walker/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/iParadigms/walker/statuses/6a1eb9cb063f44aca68289783cb47dd6617e5af3"}}}}