GitHub PullRequestReviewCommentEvent at 2014-10-09 13:06:59
Repository: status
Actor: ewels
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/SciLifeLab/status/pulls/comments/18643135","id":18643135,"diff_hunk":"@@ -1,5 +1,12 @@\n {% extends \"base_new.html\" %}\n \n+<!-- \n+Template file: cronjobs.html\n+URL: /production/cronjobs\n+Title: Production cronjobs\n+Description: Diagnostic page showing active cron jobs on all servers","path":"run_dir/design/cronjobs.html","position":7,"original_position":7,"commit_id":"7da6914f9c5a42594fe43f9b04538d8b5fe1d74c","original_commit_id":"7da6914f9c5a42594fe43f9b04538d8b5fe1d74c","user":{"login":"ewels","id":465550,"avatar_url":"https://avatars.githubusercontent.com/u/465550?v=2","gravatar_id":"","url":"https://api.github.com/users/ewels","html_url":"https://github.com/ewels","followers_url":"https://api.github.com/users/ewels/followers","following_url":"https://api.github.com/users/ewels/following{/other_user}","gists_url":"https://api.github.com/users/ewels/gists{/gist_id}","starred_url":"https://api.github.com/users/ewels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewels/subscriptions","organizations_url":"https://api.github.com/users/ewels/orgs","repos_url":"https://api.github.com/users/ewels/repos","events_url":"https://api.github.com/users/ewels/events{/privacy}","received_events_url":"https://api.github.com/users/ewels/received_events","type":"User","site_admin":false},"body":"Ahh, so _that's_ why you nested a `<code>` inside a `<pre>` block before.. I couldn't figure it out - looking at it now it's so that it word wraps. Clever stuff! I'll put it back to wrapping again.","created_at":"2014-10-09T13:06:59Z","updated_at":"2014-10-09T13:06:59Z","html_url":"https://github.com/SciLifeLab/status/pull/130#discussion_r18643135","pull_request_url":"https://api.github.com/repos/SciLifeLab/status/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/SciLifeLab/status/pulls/comments/18643135"},"html":{"href":"https://github.com/SciLifeLab/status/pull/130#discussion_r18643135"},"pull_request":{"href":"https://api.github.com/repos/SciLifeLab/status/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/SciLifeLab/status/pulls/130","id":22483757,"html_url":"https://github.com/SciLifeLab/status/pull/130","diff_url":"https://github.com/SciLifeLab/status/pull/130.diff","patch_url":"https://github.com/SciLifeLab/status/pull/130.patch","issue_url":"https://api.github.com/repos/SciLifeLab/status/issues/130","number":130,"state":"open","locked":false,"title":"GenStat BS3 / cleanup","user":{"login":"ewels","id":465550,"avatar_url":"https://avatars.githubusercontent.com/u/465550?v=2","gravatar_id":"","url":"https://api.github.com/users/ewels","html_url":"https://github.com/ewels","followers_url":"https://api.github.com/users/ewels/followers","following_url":"https://api.github.com/users/ewels/following{/other_user}","gists_url":"https://api.github.com/users/ewels/gists{/gist_id}","starred_url":"https://api.github.com/users/ewels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewels/subscriptions","organizations_url":"https://api.github.com/users/ewels/orgs","repos_url":"https://api.github.com/users/ewels/repos","events_url":"https://api.github.com/users/ewels/events{/privacy}","received_events_url":"https://api.github.com/users/ewels/received_events","type":"User","site_admin":false},"body":"A few more pages cleaned up - notable the depreciated `barcode_vs_expected.html` page, which now produces plots which can be read. Also several template pages which weren't being used for anything have been deleted.\r\n\r\nAlso a big cleanup in the `flowcell_samples.html` template - no manger change in functionality here, lots of reformatting the code so that I could read what was actually happening in the HTML (messy to review, sorry). Also changing some markup to use BS3 classes. **Change in functionality:** instead of showing \"not found in DB\" I've just hidden missing fields. Makes the page far smaller and easier to use I think. @Galithil - I'm pretty sure this will be going against what someone has asked you to do, sorry! Feel free to argue the point, or get me to pass it by any other interested people.\r\n\r\nPhil","created_at":"2014-10-09T10:27:03Z","updated_at":"2014-10-09T13:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a02d193b8cbd95aa92541d73b259a24c0520c1ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SciLifeLab/status/pulls/130/commits","review_comments_url":"https://api.github.com/repos/SciLifeLab/status/pulls/130/comments","review_comment_url":"https://api.github.com/repos/SciLifeLab/status/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SciLifeLab/status/issues/130/comments","statuses_url":"https://api.github.com/repos/SciLifeLab/status/statuses/7da6914f9c5a42594fe43f9b04538d8b5fe1d74c","head":{"label":"ewels:master","ref":"master","sha":"7da6914f9c5a42594fe43f9b04538d8b5fe1d74c","user":{"login":"ewels","id":465550,"avatar_url":"https://avatars.githubusercontent.com/u/465550?v=2","gravatar_id":"","url":"https://api.github.com/users/ewels","html_url":"https://github.com/ewels","followers_url":"https://api.github.com/users/ewels/followers","following_url":"https://api.github.com/users/ewels/following{/other_user}","gists_url":"https://api.github.com/users/ewels/gists{/gist_id}","starred_url":"https://api.github.com/users/ewels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewels/subscriptions","organizations_url":"https://api.github.com/users/ewels/orgs","repos_url":"https://api.github.com/users/ewels/repos","events_url":"https://api.github.com/users/ewels/events{/privacy}","received_events_url":"https://api.github.com/users/ewels/received_events","type":"User","site_admin":false},"repo":{"id":23840943,"name":"status","full_name":"ewels/status","owner":{"login":"ewels","id":465550,"avatar_url":"https://avatars.githubusercontent.com/u/465550?v=2","gravatar_id":"","url":"https://api.github.com/users/ewels","html_url":"https://github.com/ewels","followers_url":"https://api.github.com/users/ewels/followers","following_url":"https://api.github.com/users/ewels/following{/other_user}","gists_url":"https://api.github.com/users/ewels/gists{/gist_id}","starred_url":"https://api.github.com/users/ewels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewels/subscriptions","organizations_url":"https://api.github.com/users/ewels/orgs","repos_url":"https://api.github.com/users/ewels/repos","events_url":"https://api.github.com/users/ewels/events{/privacy}","received_events_url":"https://api.github.com/users/ewels/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ewels/status","description":"Files used to run the genomics status website at SciLifeLab","fork":true,"url":"https://api.github.com/repos/ewels/status","forks_url":"https://api.github.com/repos/ewels/status/forks","keys_url":"https://api.github.com/repos/ewels/status/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewels/status/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewels/status/teams","hooks_url":"https://api.github.com/repos/ewels/status/hooks","issue_events_url":"https://api.github.com/repos/ewels/status/issues/events{/number}","events_url":"https://api.github.com/repos/ewels/status/events","assignees_url":"https://api.github.com/repos/ewels/status/assignees{/user}","branches_url":"https://api.github.com/repos/ewels/status/branches{/branch}","tags_url":"https://api.github.com/repos/ewels/status/tags","blobs_url":"https://api.github.com/repos/ewels/status/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewels/status/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewels/status/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewels/status/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewels/status/statuses/{sha}","languages_url":"https://api.github.com/repos/ewels/status/languages","stargazers_url":"https://api.github.com/repos/ewels/status/stargazers","contributors_url":"https://api.github.com/repos/ewels/status/contributors","subscribers_url":"https://api.github.com/repos/ewels/status/subscribers","subscription_url":"https://api.github.com/repos/ewels/status/subscription","commits_url":"https://api.github.com/repos/ewels/status/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewels/status/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewels/status/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewels/status/issues/comments/{number}","contents_url":"https://api.github.com/repos/ewels/status/contents/{+path}","compare_url":"https://api.github.com/repos/ewels/status/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewels/status/merges","archive_url":"https://api.github.com/repos/ewels/status/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewels/status/downloads","issues_url":"https://api.github.com/repos/ewels/status/issues{/number}","pulls_url":"https://api.github.com/repos/ewels/status/pulls{/number}","milestones_url":"https://api.github.com/repos/ewels/status/milestones{/number}","notifications_url":"https://api.github.com/repos/ewels/status/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewels/status/labels{/name}","releases_url":"https://api.github.com/repos/ewels/status/releases{/id}","created_at":"2014-09-09T16:14:45Z","updated_at":"2014-09-09T16:18:52Z","pushed_at":"2014-10-09T10:22:41Z","git_url":"git://github.com/ewels/status.git","ssh_url":"git@github.com:ewels/status.git","clone_url":"https://github.com/ewels/status.git","svn_url":"https://github.com/ewels/status","homepage":"https://genomics-status.scilifelab.se","size":2557,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SciLifeLab:master","ref":"master","sha":"21d7275b8795297976999c7a967c1d0af4b26e4b","user":{"login":"SciLifeLab","id":713611,"avatar_url":"https://avatars.githubusercontent.com/u/713611?v=2","gravatar_id":"","url":"https://api.github.com/users/SciLifeLab","html_url":"https://github.com/SciLifeLab","followers_url":"https://api.github.com/users/SciLifeLab/followers","following_url":"https://api.github.com/users/SciLifeLab/following{/other_user}","gists_url":"https://api.github.com/users/SciLifeLab/gists{/gist_id}","starred_url":"https://api.github.com/users/SciLifeLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciLifeLab/subscriptions","organizations_url":"https://api.github.com/users/SciLifeLab/orgs","repos_url":"https://api.github.com/users/SciLifeLab/repos","events_url":"https://api.github.com/users/SciLifeLab/events{/privacy}","received_events_url":"https://api.github.com/users/SciLifeLab/received_events","type":"Organization","site_admin":false},"repo":{"id":4652091,"name":"status","full_name":"SciLifeLab/status","owner":{"login":"SciLifeLab","id":713611,"avatar_url":"https://avatars.githubusercontent.com/u/713611?v=2","gravatar_id":"","url":"https://api.github.com/users/SciLifeLab","html_url":"https://github.com/SciLifeLab","followers_url":"https://api.github.com/users/SciLifeLab/followers","following_url":"https://api.github.com/users/SciLifeLab/following{/other_user}","gists_url":"https://api.github.com/users/SciLifeLab/gists{/gist_id}","starred_url":"https://api.github.com/users/SciLifeLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciLifeLab/subscriptions","organizations_url":"https://api.github.com/users/SciLifeLab/orgs","repos_url":"https://api.github.com/users/SciLifeLab/repos","events_url":"https://api.github.com/users/SciLifeLab/events{/privacy}","received_events_url":"https://api.github.com/users/SciLifeLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciLifeLab/status","description":"","fork":true,"url":"https://api.github.com/repos/SciLifeLab/status","forks_url":"https://api.github.com/repos/SciLifeLab/status/forks","keys_url":"https://api.github.com/repos/SciLifeLab/status/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciLifeLab/status/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciLifeLab/status/teams","hooks_url":"https://api.github.com/repos/SciLifeLab/status/hooks","issue_events_url":"https://api.github.com/repos/SciLifeLab/status/issues/events{/number}","events_url":"https://api.github.com/repos/SciLifeLab/status/events","assignees_url":"https://api.github.com/repos/SciLifeLab/status/assignees{/user}","branches_url":"https://api.github.com/repos/SciLifeLab/status/branches{/branch}","tags_url":"https://api.github.com/repos/SciLifeLab/status/tags","blobs_url":"https://api.github.com/repos/SciLifeLab/status/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciLifeLab/status/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciLifeLab/status/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciLifeLab/status/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciLifeLab/status/statuses/{sha}","languages_url":"https://api.github.com/repos/SciLifeLab/status/languages","stargazers_url":"https://api.github.com/repos/SciLifeLab/status/stargazers","contributors_url":"https://api.github.com/repos/SciLifeLab/status/contributors","subscribers_url":"https://api.github.com/repos/SciLifeLab/status/subscribers","subscription_url":"https://api.github.com/repos/SciLifeLab/status/subscription","commits_url":"https://api.github.com/repos/SciLifeLab/status/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciLifeLab/status/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciLifeLab/status/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciLifeLab/status/issues/comments/{number}","contents_url":"https://api.github.com/repos/SciLifeLab/status/contents/{+path}","compare_url":"https://api.github.com/repos/SciLifeLab/status/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciLifeLab/status/merges","archive_url":"https://api.github.com/repos/SciLifeLab/status/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciLifeLab/status/downloads","issues_url":"https://api.github.com/repos/SciLifeLab/status/issues{/number}","pulls_url":"https://api.github.com/repos/SciLifeLab/status/pulls{/number}","milestones_url":"https://api.github.com/repos/SciLifeLab/status/milestones{/number}","notifications_url":"https://api.github.com/repos/SciLifeLab/status/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciLifeLab/status/labels{/name}","releases_url":"https://api.github.com/repos/SciLifeLab/status/releases{/id}","created_at":"2012-06-13T14:39:29Z","updated_at":"2014-09-26T13:59:20Z","pushed_at":"2014-10-06T12:42:41Z","git_url":"git://github.com/SciLifeLab/status.git","ssh_url":"git@github.com:SciLifeLab/status.git","clone_url":"https://github.com/SciLifeLab/status.git","svn_url":"https://github.com/SciLifeLab/status","homepage":"","size":3985,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":11,"forks":7,"open_issues":11,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciLifeLab/status/pulls/130"},"html":{"href":"https://github.com/SciLifeLab/status/pull/130"},"issue":{"href":"https://api.github.com/repos/SciLifeLab/status/issues/130"},"comments":{"href":"https://api.github.com/repos/SciLifeLab/status/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/SciLifeLab/status/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/SciLifeLab/status/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SciLifeLab/status/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/SciLifeLab/status/statuses/7da6914f9c5a42594fe43f9b04538d8b5fe1d74c"}}}}