GitHub PullRequestEvent at 2014-03-16 09:04:34
Repository: ios-snapshot-test-case
Actor: FGoessler
Payload: {"action":"opened","number":23,"pull_request":{"url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/23","id":13610895,"html_url":"https://github.com/facebook/ios-snapshot-test-case/pull/23","diff_url":"https://github.com/facebook/ios-snapshot-test-case/pull/23.diff","patch_url":"https://github.com/facebook/ios-snapshot-test-case/pull/23.patch","issue_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues/23","number":23,"state":"open","title":"Added assertion failure for tests that run in record mode","user":{"login":"FGoessler","id":2462969,"avatar_url":"https://gravatar.com/avatar/e47eb73cd4df554d20024989164a9fdb?d=https%3A%2F%2Fidenticons.github.com%2F8734ecb22f67f9a0b2c0a5017af0eb50.png&r=x","gravatar_id":"e47eb73cd4df554d20024989164a9fdb","url":"https://api.github.com/users/FGoessler","html_url":"https://github.com/FGoessler","followers_url":"https://api.github.com/users/FGoessler/followers","following_url":"https://api.github.com/users/FGoessler/following{/other_user}","gists_url":"https://api.github.com/users/FGoessler/gists{/gist_id}","starred_url":"https://api.github.com/users/FGoessler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FGoessler/subscriptions","organizations_url":"https://api.github.com/users/FGoessler/orgs","repos_url":"https://api.github.com/users/FGoessler/repos","events_url":"https://api.github.com/users/FGoessler/events{/privacy}","received_events_url":"https://api.github.com/users/FGoessler/received_events","type":"User","site_admin":false},"body":"Tests running in recordMode should not count as successful tests, cause then you can't see that they are not comparing the snapshots by just running the tests.\r\nEspecially after an \"accidental\" commit even the build server won't notice.\r\n\r\nCause of that I added a little assert that recordMode ist disabled.","created_at":"2014-03-16T09:04:34Z","updated_at":"2014-03-16T09:04:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/23/commits","review_comments_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/23/comments","review_comment_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/comments/{number}","comments_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues/23/comments","statuses_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/statuses/ef3d79d78948d5f53e957999f593b02f836fbf66","head":{"label":"FGoessler:master","ref":"master","sha":"ef3d79d78948d5f53e957999f593b02f836fbf66","user":{"login":"FGoessler","id":2462969,"avatar_url":"https://gravatar.com/avatar/e47eb73cd4df554d20024989164a9fdb?d=https%3A%2F%2Fidenticons.github.com%2F8734ecb22f67f9a0b2c0a5017af0eb50.png&r=x","gravatar_id":"e47eb73cd4df554d20024989164a9fdb","url":"https://api.github.com/users/FGoessler","html_url":"https://github.com/FGoessler","followers_url":"https://api.github.com/users/FGoessler/followers","following_url":"https://api.github.com/users/FGoessler/following{/other_user}","gists_url":"https://api.github.com/users/FGoessler/gists{/gist_id}","starred_url":"https://api.github.com/users/FGoessler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FGoessler/subscriptions","organizations_url":"https://api.github.com/users/FGoessler/orgs","repos_url":"https://api.github.com/users/FGoessler/repos","events_url":"https://api.github.com/users/FGoessler/events{/privacy}","received_events_url":"https://api.github.com/users/FGoessler/received_events","type":"User","site_admin":false},"repo":{"id":17795540,"name":"ios-snapshot-test-case","full_name":"FGoessler/ios-snapshot-test-case","owner":{"login":"FGoessler","id":2462969,"avatar_url":"https://gravatar.com/avatar/e47eb73cd4df554d20024989164a9fdb?d=https%3A%2F%2Fidenticons.github.com%2F8734ecb22f67f9a0b2c0a5017af0eb50.png&r=x","gravatar_id":"e47eb73cd4df554d20024989164a9fdb","url":"https://api.github.com/users/FGoessler","html_url":"https://github.com/FGoessler","followers_url":"https://api.github.com/users/FGoessler/followers","following_url":"https://api.github.com/users/FGoessler/following{/other_user}","gists_url":"https://api.github.com/users/FGoessler/gists{/gist_id}","starred_url":"https://api.github.com/users/FGoessler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FGoessler/subscriptions","organizations_url":"https://api.github.com/users/FGoessler/orgs","repos_url":"https://api.github.com/users/FGoessler/repos","events_url":"https://api.github.com/users/FGoessler/events{/privacy}","received_events_url":"https://api.github.com/users/FGoessler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FGoessler/ios-snapshot-test-case","description":"Snapshot view unit tests for iOS","fork":true,"url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case","forks_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/forks","keys_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/teams","hooks_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/hooks","issue_events_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/issues/events{/number}","events_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/events","assignees_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/assignees{/user}","branches_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/branches{/branch}","tags_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/tags","blobs_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/git/refs{/sha}","trees_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/statuses/{sha}","languages_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/languages","stargazers_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/stargazers","contributors_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/contributors","subscribers_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/subscribers","subscription_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/subscription","commits_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/commits{/sha}","git_commits_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/git/commits{/sha}","comments_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/comments{/number}","issue_comment_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/issues/comments/{number}","contents_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/contents/{+path}","compare_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/merges","archive_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/downloads","issues_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/issues{/number}","pulls_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/pulls{/number}","milestones_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/milestones{/number}","notifications_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/labels{/name}","releases_url":"https://api.github.com/repos/FGoessler/ios-snapshot-test-case/releases{/id}","created_at":"2014-03-16T08:53:52Z","updated_at":"2014-03-16T09:04:34Z","pushed_at":"2014-03-16T08:56:16Z","git_url":"git://github.com/FGoessler/ios-snapshot-test-case.git","ssh_url":"git@github.com:FGoessler/ios-snapshot-test-case.git","clone_url":"https://github.com/FGoessler/ios-snapshot-test-case.git","svn_url":"https://github.com/FGoessler/ios-snapshot-test-case","homepage":null,"size":791,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master","master_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"28f24a122b333954efb56d1441f9b2cb9da99675","user":{"login":"facebook","id":69631,"avatar_url":"https://gravatar.com/avatar/18a83f753fa76b3ea0d594247f4c93b1?d=https%3A%2F%2Fidenticons.github.com%2Faff495be3551563209790714027a7d38.png&r=x","gravatar_id":"18a83f753fa76b3ea0d594247f4c93b1","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":13236289,"name":"ios-snapshot-test-case","full_name":"facebook/ios-snapshot-test-case","owner":{"login":"facebook","id":69631,"avatar_url":"https://gravatar.com/avatar/18a83f753fa76b3ea0d594247f4c93b1?d=https%3A%2F%2Fidenticons.github.com%2Faff495be3551563209790714027a7d38.png&r=x","gravatar_id":"18a83f753fa76b3ea0d594247f4c93b1","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/ios-snapshot-test-case","description":"Snapshot view unit tests for iOS","fork":false,"url":"https://api.github.com/repos/facebook/ios-snapshot-test-case","forks_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/forks","keys_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/teams","hooks_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/hooks","issue_events_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/events","assignees_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/tags","blobs_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/languages","stargazers_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/stargazers","contributors_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/contributors","subscribers_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/subscribers","subscription_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/subscription","commits_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/merges","archive_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/downloads","issues_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/labels{/name}","releases_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/releases{/id}","created_at":"2013-10-01T06:15:56Z","updated_at":"2014-03-07T15:56:17Z","pushed_at":"2014-03-07T15:56:17Z","git_url":"git://github.com/facebook/ios-snapshot-test-case.git","ssh_url":"git@github.com:facebook/ios-snapshot-test-case.git","clone_url":"https://github.com/facebook/ios-snapshot-test-case.git","svn_url":"https://github.com/facebook/ios-snapshot-test-case","homepage":null,"size":791,"stargazers_count":395,"watchers_count":395,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":20,"mirror_url":null,"open_issues_count":7,"forks":20,"open_issues":7,"watchers":395,"default_branch":"master","master_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/23"},"html":{"href":"https://github.com/facebook/ios-snapshot-test-case/pull/23"},"issue":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues/23"},"comments":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/statuses/ef3d79d78948d5f53e957999f593b02f836fbf66"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":0,"changed_files":1}}