GitHub PullRequestReviewCommentEvent at 2014-12-16 03:39:17
Repository: titanium_mobile
Actor: ashcoding
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/comments/21876248","id":21876248,"diff_hunk":"@@ -145,6 +145,14 @@\n \t@Kroll.constant public static final int URL_ERROR_TIMEOUT = WebViewClient.ERROR_TIMEOUT;\n \t@Kroll.constant public static final int URL_ERROR_UNKNOWN = WebViewClient.ERROR_UNKNOWN;\n \t@Kroll.constant public static final int URL_ERROR_UNSUPPORTED_SCHEME = WebViewClient.ERROR_UNSUPPORTED_SCHEME;\n+\t\n+\t@Kroll.constant public static final int ATTRIBUTE_FONT = 0;\n+\t@Kroll.constant public static final int ATTRIBUTE_FOREGROUND_COLOR = 1;\n+\t@Kroll.constant public static final int ATTRIBUTE_BACKGROUND_COLOR = 2;\n+\t@Kroll.constant public static final int ATTRIBUTE_STRIKETHROUGH_STYLE = 3;\n+\t@Kroll.constant public static final int ATTRIBUTE_UNDERLINES_STYLE = 4;\n+\t@Kroll.constant public static final int ATTRIBUTE_LINK = 5;\n+\t@Kroll.constant public static final int ATTRIBUTE_UNDERLINE_COLOR = 6;","path":"android/modules/ui/src/java/ti/modules/titanium/ui/UIModule.java","position":11,"original_position":11,"commit_id":"425fc56948ec47b6583791db7b460e319fbb1360","original_commit_id":"425fc56948ec47b6583791db7b460e319fbb1360","user":{"login":"ashcoding","id":9311952,"avatar_url":"https://avatars.githubusercontent.com/u/9311952?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcoding","html_url":"https://github.com/ashcoding","followers_url":"https://api.github.com/users/ashcoding/followers","following_url":"https://api.github.com/users/ashcoding/following{/other_user}","gists_url":"https://api.github.com/users/ashcoding/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcoding/subscriptions","organizations_url":"https://api.github.com/users/ashcoding/orgs","repos_url":"https://api.github.com/users/ashcoding/repos","events_url":"https://api.github.com/users/ashcoding/events{/privacy}","received_events_url":"https://api.github.com/users/ashcoding/received_events","type":"User","site_admin":false},"body":"Foreground color is text color.","created_at":"2014-12-16T03:39:17Z","updated_at":"2014-12-16T03:39:17Z","html_url":"https://github.com/appcelerator/titanium_mobile/pull/6463#discussion_r21876248","pull_request_url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/6463","_links":{"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/comments/21876248"},"html":{"href":"https://github.com/appcelerator/titanium_mobile/pull/6463#discussion_r21876248"},"pull_request":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/6463"}}},"pull_request":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/6463","id":25806419,"html_url":"https://github.com/appcelerator/titanium_mobile/pull/6463","diff_url":"https://github.com/appcelerator/titanium_mobile/pull/6463.diff","patch_url":"https://github.com/appcelerator/titanium_mobile/pull/6463.patch","issue_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/6463","number":6463,"state":"open","locked":false,"title":"[TIMOB-18062] iOS: AttributedString Parity with Android","user":{"login":"ashcoding","id":9311952,"avatar_url":"https://avatars.githubusercontent.com/u/9311952?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcoding","html_url":"https://github.com/ashcoding","followers_url":"https://api.github.com/users/ashcoding/followers","following_url":"https://api.github.com/users/ashcoding/following{/other_user}","gists_url":"https://api.github.com/users/ashcoding/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcoding/subscriptions","organizations_url":"https://api.github.com/users/ashcoding/orgs","repos_url":"https://api.github.com/users/ashcoding/repos","events_url":"https://api.github.com/users/ashcoding/events{/privacy}","received_events_url":"https://api.github.com/users/ashcoding/received_events","type":"User","site_admin":false},"body":"Jira: https://jira.appcelerator.org/browse/TIMOB-18062\r\n\r\nThis PR is a continuation of https://github.com/appcelerator/titanium_mobile/pull/6409/ which came from #6358.\r\n\r\nIt addresses the comments by @pingwang2011 for the Android portion of the code. The doc is still not completed yet as Titanium.UI.iOS.Attribute and Titanium.UI.iOS.AttributedString yml files are missing the \"deprecated\".\r\n\r\nThe propertyAccessors is now used in AttributedStringProxy.java, AttributeProxy.java and LabelProxy.java.","created_at":"2014-12-10T08:49:32Z","updated_at":"2014-12-16T03:39:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fe0ba6b63a856b53694212ca2e78044e0d0adb3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/6463/commits","review_comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/6463/comments","review_comment_url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/comments/{number}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/6463/comments","statuses_url":"https://api.github.com/repos/appcelerator/titanium_mobile/statuses/425fc56948ec47b6583791db7b460e319fbb1360","head":{"label":"ashcoding:TIMOB-18062","ref":"TIMOB-18062","sha":"425fc56948ec47b6583791db7b460e319fbb1360","user":{"login":"ashcoding","id":9311952,"avatar_url":"https://avatars.githubusercontent.com/u/9311952?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcoding","html_url":"https://github.com/ashcoding","followers_url":"https://api.github.com/users/ashcoding/followers","following_url":"https://api.github.com/users/ashcoding/following{/other_user}","gists_url":"https://api.github.com/users/ashcoding/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcoding/subscriptions","organizations_url":"https://api.github.com/users/ashcoding/orgs","repos_url":"https://api.github.com/users/ashcoding/repos","events_url":"https://api.github.com/users/ashcoding/events{/privacy}","received_events_url":"https://api.github.com/users/ashcoding/received_events","type":"User","site_admin":false},"repo":{"id":25957404,"name":"titanium_mobile","full_name":"ashcoding/titanium_mobile","owner":{"login":"ashcoding","id":9311952,"avatar_url":"https://avatars.githubusercontent.com/u/9311952?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcoding","html_url":"https://github.com/ashcoding","followers_url":"https://api.github.com/users/ashcoding/followers","following_url":"https://api.github.com/users/ashcoding/following{/other_user}","gists_url":"https://api.github.com/users/ashcoding/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcoding/subscriptions","organizations_url":"https://api.github.com/users/ashcoding/orgs","repos_url":"https://api.github.com/users/ashcoding/repos","events_url":"https://api.github.com/users/ashcoding/events{/privacy}","received_events_url":"https://api.github.com/users/ashcoding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashcoding/titanium_mobile","description":"Appcelerator Titanium Mobile","fork":true,"url":"https://api.github.com/repos/ashcoding/titanium_mobile","forks_url":"https://api.github.com/repos/ashcoding/titanium_mobile/forks","keys_url":"https://api.github.com/repos/ashcoding/titanium_mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashcoding/titanium_mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashcoding/titanium_mobile/teams","hooks_url":"https://api.github.com/repos/ashcoding/titanium_mobile/hooks","issue_events_url":"https://api.github.com/repos/ashcoding/titanium_mobile/issues/events{/number}","events_url":"https://api.github.com/repos/ashcoding/titanium_mobile/events","assignees_url":"https://api.github.com/repos/ashcoding/titanium_mobile/assignees{/user}","branches_url":"https://api.github.com/repos/ashcoding/titanium_mobile/branches{/branch}","tags_url":"https://api.github.com/repos/ashcoding/titanium_mobile/tags","blobs_url":"https://api.github.com/repos/ashcoding/titanium_mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashcoding/titanium_mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashcoding/titanium_mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashcoding/titanium_mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashcoding/titanium_mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/ashcoding/titanium_mobile/languages","stargazers_url":"https://api.github.com/repos/ashcoding/titanium_mobile/stargazers","contributors_url":"https://api.github.com/repos/ashcoding/titanium_mobile/contributors","subscribers_url":"https://api.github.com/repos/ashcoding/titanium_mobile/subscribers","subscription_url":"https://api.github.com/repos/ashcoding/titanium_mobile/subscription","commits_url":"https://api.github.com/repos/ashcoding/titanium_mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashcoding/titanium_mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashcoding/titanium_mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashcoding/titanium_mobile/issues/comments/{number}","contents_url":"https://api.github.com/repos/ashcoding/titanium_mobile/contents/{+path}","compare_url":"https://api.github.com/repos/ashcoding/titanium_mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashcoding/titanium_mobile/merges","archive_url":"https://api.github.com/repos/ashcoding/titanium_mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashcoding/titanium_mobile/downloads","issues_url":"https://api.github.com/repos/ashcoding/titanium_mobile/issues{/number}","pulls_url":"https://api.github.com/repos/ashcoding/titanium_mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/ashcoding/titanium_mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/ashcoding/titanium_mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashcoding/titanium_mobile/labels{/name}","releases_url":"https://api.github.com/repos/ashcoding/titanium_mobile/releases{/id}","created_at":"2014-10-30T06:12:25Z","updated_at":"2014-12-09T03:43:54Z","pushed_at":"2014-12-15T02:48:28Z","git_url":"git://github.com/ashcoding/titanium_mobile.git","ssh_url":"git@github.com:ashcoding/titanium_mobile.git","clone_url":"https://github.com/ashcoding/titanium_mobile.git","svn_url":"https://github.com/ashcoding/titanium_mobile","homepage":"http://www.appcelerator.com","size":625018,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appcelerator:master","ref":"master","sha":"eafcfe8fc1526eed68ef1299f2a500d1196735a6","user":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"repo":{"id":228094,"name":"titanium_mobile","full_name":"appcelerator/titanium_mobile","owner":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator/titanium_mobile","description":"Appcelerator Titanium Mobile","fork":false,"url":"https://api.github.com/repos/appcelerator/titanium_mobile","forks_url":"https://api.github.com/repos/appcelerator/titanium_mobile/forks","keys_url":"https://api.github.com/repos/appcelerator/titanium_mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator/titanium_mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator/titanium_mobile/teams","hooks_url":"https://api.github.com/repos/appcelerator/titanium_mobile/hooks","issue_events_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator/titanium_mobile/events","assignees_url":"https://api.github.com/repos/appcelerator/titanium_mobile/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator/titanium_mobile/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator/titanium_mobile/tags","blobs_url":"https://api.github.com/repos/appcelerator/titanium_mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator/titanium_mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator/titanium_mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator/titanium_mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator/titanium_mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator/titanium_mobile/languages","stargazers_url":"https://api.github.com/repos/appcelerator/titanium_mobile/stargazers","contributors_url":"https://api.github.com/repos/appcelerator/titanium_mobile/contributors","subscribers_url":"https://api.github.com/repos/appcelerator/titanium_mobile/subscribers","subscription_url":"https://api.github.com/repos/appcelerator/titanium_mobile/subscription","commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/comments/{number}","contents_url":"https://api.github.com/repos/appcelerator/titanium_mobile/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator/titanium_mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator/titanium_mobile/merges","archive_url":"https://api.github.com/repos/appcelerator/titanium_mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator/titanium_mobile/downloads","issues_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator/titanium_mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator/titanium_mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator/titanium_mobile/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator/titanium_mobile/releases{/id}","created_at":"2009-06-15T22:54:37Z","updated_at":"2014-12-15T18:59:56Z","pushed_at":"2014-12-15T19:29:29Z","git_url":"git://github.com/appcelerator/titanium_mobile.git","ssh_url":"git@github.com:appcelerator/titanium_mobile.git","clone_url":"https://github.com/appcelerator/titanium_mobile.git","svn_url":"https://github.com/appcelerator/titanium_mobile","homepage":"http://www.appcelerator.com","size":787647,"stargazers_count":1747,"watchers_count":1747,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":921,"mirror_url":null,"open_issues_count":72,"forks":921,"open_issues":72,"watchers":1747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/6463"},"html":{"href":"https://github.com/appcelerator/titanium_mobile/pull/6463"},"issue":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/6463"},"comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/6463/comments"},"review_comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/6463/comments"},"review_comment":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/6463/commits"},"statuses":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/statuses/425fc56948ec47b6583791db7b460e319fbb1360"}}}}