GitHub PullRequestEvent at 2014-04-29 22:16:34
Repository: click
Actor: pallas
Payload: {"action":"opened","number":122,"pull_request":{"url":"https://api.github.com/repos/kohler/click/pulls/122","id":15316135,"html_url":"https://github.com/kohler/click/pull/122","diff_url":"https://github.com/kohler/click/pull/122.diff","patch_url":"https://github.com/kohler/click/pull/122.patch","issue_url":"https://api.github.com/repos/kohler/click/issues/122","number":122,"state":"open","title":"ToUserDevice nits","user":{"login":"pallas","id":848304,"avatar_url":"https://avatars.githubusercontent.com/u/848304?","gravatar_id":"0a4d47ee41d52878600685b4d295a047","url":"https://api.github.com/users/pallas","html_url":"https://github.com/pallas","followers_url":"https://api.github.com/users/pallas/followers","following_url":"https://api.github.com/users/pallas/following{/other_user}","gists_url":"https://api.github.com/users/pallas/gists{/gist_id}","starred_url":"https://api.github.com/users/pallas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallas/subscriptions","organizations_url":"https://api.github.com/users/pallas/orgs","repos_url":"https://api.github.com/users/pallas/repos","events_url":"https://api.github.com/users/pallas/events{/privacy}","received_events_url":"https://api.github.com/users/pallas/received_events","type":"User","site_admin":false},"body":"These are some small nits in ToUserDevice.\r\n\r\nThere is a larger problem, that the config might change during a ToUserDevice::dev_read or FromUserDevice::dev_write and cause elem to become invalid. I believe that this code might need to hook lock_config + unlock_config from clickfs but I'm not sure if that's the best solution. I'm open to suggestions.\r\n\r\nI am not sure whether we should add a router block + unblock during a read or a write, but that's a different issue.\r\n","created_at":"2014-04-29T22:16:34Z","updated_at":"2014-04-29T22:16:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kohler/click/pulls/122/commits","review_comments_url":"https://api.github.com/repos/kohler/click/pulls/122/comments","review_comment_url":"https://api.github.com/repos/kohler/click/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kohler/click/issues/122/comments","statuses_url":"https://api.github.com/repos/kohler/click/statuses/d079c22d4b93f030194f658ed3c6953984f49917","head":{"label":"pallas:touserdevice-nits","ref":"touserdevice-nits","sha":"d079c22d4b93f030194f658ed3c6953984f49917","user":{"login":"pallas","id":848304,"avatar_url":"https://avatars.githubusercontent.com/u/848304?","gravatar_id":"0a4d47ee41d52878600685b4d295a047","url":"https://api.github.com/users/pallas","html_url":"https://github.com/pallas","followers_url":"https://api.github.com/users/pallas/followers","following_url":"https://api.github.com/users/pallas/following{/other_user}","gists_url":"https://api.github.com/users/pallas/gists{/gist_id}","starred_url":"https://api.github.com/users/pallas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallas/subscriptions","organizations_url":"https://api.github.com/users/pallas/orgs","repos_url":"https://api.github.com/users/pallas/repos","events_url":"https://api.github.com/users/pallas/events{/privacy}","received_events_url":"https://api.github.com/users/pallas/received_events","type":"User","site_admin":false},"repo":{"id":1891985,"name":"click","full_name":"pallas/click","owner":{"login":"pallas","id":848304,"avatar_url":"https://avatars.githubusercontent.com/u/848304?","gravatar_id":"0a4d47ee41d52878600685b4d295a047","url":"https://api.github.com/users/pallas","html_url":"https://github.com/pallas","followers_url":"https://api.github.com/users/pallas/followers","following_url":"https://api.github.com/users/pallas/following{/other_user}","gists_url":"https://api.github.com/users/pallas/gists{/gist_id}","starred_url":"https://api.github.com/users/pallas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallas/subscriptions","organizations_url":"https://api.github.com/users/pallas/orgs","repos_url":"https://api.github.com/users/pallas/repos","events_url":"https://api.github.com/users/pallas/events{/privacy}","received_events_url":"https://api.github.com/users/pallas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pallas/click","description":"The Click modular router: fast modular packet processing and analysis","fork":true,"url":"https://api.github.com/repos/pallas/click","forks_url":"https://api.github.com/repos/pallas/click/forks","keys_url":"https://api.github.com/repos/pallas/click/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pallas/click/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pallas/click/teams","hooks_url":"https://api.github.com/repos/pallas/click/hooks","issue_events_url":"https://api.github.com/repos/pallas/click/issues/events{/number}","events_url":"https://api.github.com/repos/pallas/click/events","assignees_url":"https://api.github.com/repos/pallas/click/assignees{/user}","branches_url":"https://api.github.com/repos/pallas/click/branches{/branch}","tags_url":"https://api.github.com/repos/pallas/click/tags","blobs_url":"https://api.github.com/repos/pallas/click/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pallas/click/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pallas/click/git/refs{/sha}","trees_url":"https://api.github.com/repos/pallas/click/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pallas/click/statuses/{sha}","languages_url":"https://api.github.com/repos/pallas/click/languages","stargazers_url":"https://api.github.com/repos/pallas/click/stargazers","contributors_url":"https://api.github.com/repos/pallas/click/contributors","subscribers_url":"https://api.github.com/repos/pallas/click/subscribers","subscription_url":"https://api.github.com/repos/pallas/click/subscription","commits_url":"https://api.github.com/repos/pallas/click/commits{/sha}","git_commits_url":"https://api.github.com/repos/pallas/click/git/commits{/sha}","comments_url":"https://api.github.com/repos/pallas/click/comments{/number}","issue_comment_url":"https://api.github.com/repos/pallas/click/issues/comments/{number}","contents_url":"https://api.github.com/repos/pallas/click/contents/{+path}","compare_url":"https://api.github.com/repos/pallas/click/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pallas/click/merges","archive_url":"https://api.github.com/repos/pallas/click/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pallas/click/downloads","issues_url":"https://api.github.com/repos/pallas/click/issues{/number}","pulls_url":"https://api.github.com/repos/pallas/click/pulls{/number}","milestones_url":"https://api.github.com/repos/pallas/click/milestones{/number}","notifications_url":"https://api.github.com/repos/pallas/click/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pallas/click/labels{/name}","releases_url":"https://api.github.com/repos/pallas/click/releases{/id}","created_at":"2011-06-14T00:44:52Z","updated_at":"2014-04-29T22:16:34Z","pushed_at":"2014-04-29T22:15:55Z","git_url":"git://github.com/pallas/click.git","ssh_url":"git@github.com:pallas/click.git","clone_url":"https://github.com/pallas/click.git","svn_url":"https://github.com/pallas/click","homepage":"http://www.read.cs.ucla.edu/click/","size":21105,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kohler:master","ref":"master","sha":"5f537fd958d82ae9e1d63842f7d6e9faf56818c9","user":{"login":"kohler","id":410647,"avatar_url":"https://avatars.githubusercontent.com/u/410647?","gravatar_id":"44620575967509a468aeef67206d4c65","url":"https://api.github.com/users/kohler","html_url":"https://github.com/kohler","followers_url":"https://api.github.com/users/kohler/followers","following_url":"https://api.github.com/users/kohler/following{/other_user}","gists_url":"https://api.github.com/users/kohler/gists{/gist_id}","starred_url":"https://api.github.com/users/kohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohler/subscriptions","organizations_url":"https://api.github.com/users/kohler/orgs","repos_url":"https://api.github.com/users/kohler/repos","events_url":"https://api.github.com/users/kohler/events{/privacy}","received_events_url":"https://api.github.com/users/kohler/received_events","type":"User","site_admin":false},"repo":{"id":929129,"name":"click","full_name":"kohler/click","owner":{"login":"kohler","id":410647,"avatar_url":"https://avatars.githubusercontent.com/u/410647?","gravatar_id":"44620575967509a468aeef67206d4c65","url":"https://api.github.com/users/kohler","html_url":"https://github.com/kohler","followers_url":"https://api.github.com/users/kohler/followers","following_url":"https://api.github.com/users/kohler/following{/other_user}","gists_url":"https://api.github.com/users/kohler/gists{/gist_id}","starred_url":"https://api.github.com/users/kohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohler/subscriptions","organizations_url":"https://api.github.com/users/kohler/orgs","repos_url":"https://api.github.com/users/kohler/repos","events_url":"https://api.github.com/users/kohler/events{/privacy}","received_events_url":"https://api.github.com/users/kohler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kohler/click","description":"The Click modular router: fast modular packet processing and analysis","fork":false,"url":"https://api.github.com/repos/kohler/click","forks_url":"https://api.github.com/repos/kohler/click/forks","keys_url":"https://api.github.com/repos/kohler/click/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kohler/click/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kohler/click/teams","hooks_url":"https://api.github.com/repos/kohler/click/hooks","issue_events_url":"https://api.github.com/repos/kohler/click/issues/events{/number}","events_url":"https://api.github.com/repos/kohler/click/events","assignees_url":"https://api.github.com/repos/kohler/click/assignees{/user}","branches_url":"https://api.github.com/repos/kohler/click/branches{/branch}","tags_url":"https://api.github.com/repos/kohler/click/tags","blobs_url":"https://api.github.com/repos/kohler/click/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kohler/click/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kohler/click/git/refs{/sha}","trees_url":"https://api.github.com/repos/kohler/click/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kohler/click/statuses/{sha}","languages_url":"https://api.github.com/repos/kohler/click/languages","stargazers_url":"https://api.github.com/repos/kohler/click/stargazers","contributors_url":"https://api.github.com/repos/kohler/click/contributors","subscribers_url":"https://api.github.com/repos/kohler/click/subscribers","subscription_url":"https://api.github.com/repos/kohler/click/subscription","commits_url":"https://api.github.com/repos/kohler/click/commits{/sha}","git_commits_url":"https://api.github.com/repos/kohler/click/git/commits{/sha}","comments_url":"https://api.github.com/repos/kohler/click/comments{/number}","issue_comment_url":"https://api.github.com/repos/kohler/click/issues/comments/{number}","contents_url":"https://api.github.com/repos/kohler/click/contents/{+path}","compare_url":"https://api.github.com/repos/kohler/click/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kohler/click/merges","archive_url":"https://api.github.com/repos/kohler/click/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kohler/click/downloads","issues_url":"https://api.github.com/repos/kohler/click/issues{/number}","pulls_url":"https://api.github.com/repos/kohler/click/pulls{/number}","milestones_url":"https://api.github.com/repos/kohler/click/milestones{/number}","notifications_url":"https://api.github.com/repos/kohler/click/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kohler/click/labels{/name}","releases_url":"https://api.github.com/repos/kohler/click/releases{/id}","created_at":"2010-09-21T22:45:25Z","updated_at":"2014-04-28T14:05:41Z","pushed_at":"2014-04-28T14:05:45Z","git_url":"git://github.com/kohler/click.git","ssh_url":"git@github.com:kohler/click.git","clone_url":"https://github.com/kohler/click.git","svn_url":"https://github.com/kohler/click","homepage":"http://www.read.cs.ucla.edu/click/","size":25077,"stargazers_count":92,"watchers_count":92,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"forks_count":55,"mirror_url":null,"open_issues_count":6,"forks":55,"open_issues":6,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kohler/click/pulls/122"},"html":{"href":"https://github.com/kohler/click/pull/122"},"issue":{"href":"https://api.github.com/repos/kohler/click/issues/122"},"comments":{"href":"https://api.github.com/repos/kohler/click/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/kohler/click/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/kohler/click/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kohler/click/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/kohler/click/statuses/d079c22d4b93f030194f658ed3c6953984f49917"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":27,"deletions":8,"changed_files":2}}