GitHub PullRequestEvent at 2014-07-14 23:04:19
Repository: flixel
Actor: mrcdk
Payload: {"action":"closed","number":1224,"pull_request":{"url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1224","id":18370903,"html_url":"https://github.com/HaxeFlixel/flixel/pull/1224","diff_url":"https://github.com/HaxeFlixel/flixel/pull/1224.diff","patch_url":"https://github.com/HaxeFlixel/flixel/pull/1224.patch","issue_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1224","number":1224,"state":"closed","title":"Fix equality and operations (*, +, -) for FlxColor:","user":{"login":"mrcdk","id":483531,"avatar_url":"https://avatars.githubusercontent.com/u/483531?","gravatar_id":"780c8bde68a83bdae75112fc046290ae","url":"https://api.github.com/users/mrcdk","html_url":"https://github.com/mrcdk","followers_url":"https://api.github.com/users/mrcdk/followers","following_url":"https://api.github.com/users/mrcdk/following{/other_user}","gists_url":"https://api.github.com/users/mrcdk/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcdk/subscriptions","organizations_url":"https://api.github.com/users/mrcdk/orgs","repos_url":"https://api.github.com/users/mrcdk/repos","events_url":"https://api.github.com/users/mrcdk/events{/privacy}","received_events_url":"https://api.github.com/users/mrcdk/received_events","type":"User","site_admin":false},"body":"- Equality: In cpp a null FlxColor can't exist because there is no null\r\nint, they will be initialized to 0 so if you compare FlxColor == null it\r\nwill always be false because 0 == null is false.\r\n- Operations: Because it's possible to make an operation in null members,\r\nfallbacks are needed so it won't happen.\r\nIf both members are null the returned color is Black, if only a member\r\nis null the non-null member will be returned, if both are not null the\r\noperation proceeds as expected.","created_at":"2014-07-14T20:11:05Z","updated_at":"2014-07-14T23:04:17Z","closed_at":"2014-07-14T23:04:17Z","merged_at":null,"merge_commit_sha":"9fa0ab3a8d92943363122adab8134b71413dd74b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1224/commits","review_comments_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1224/comments","review_comment_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/comments/{number}","comments_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1224/comments","statuses_url":"https://api.github.com/repos/HaxeFlixel/flixel/statuses/6deb32a64da2f6554af1abe43862a19898b3dc5b","head":{"label":"mrcdk:flxcolor_equality_fix","ref":"flxcolor_equality_fix","sha":"6deb32a64da2f6554af1abe43862a19898b3dc5b","user":{"login":"mrcdk","id":483531,"avatar_url":"https://avatars.githubusercontent.com/u/483531?","gravatar_id":"780c8bde68a83bdae75112fc046290ae","url":"https://api.github.com/users/mrcdk","html_url":"https://github.com/mrcdk","followers_url":"https://api.github.com/users/mrcdk/followers","following_url":"https://api.github.com/users/mrcdk/following{/other_user}","gists_url":"https://api.github.com/users/mrcdk/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcdk/subscriptions","organizations_url":"https://api.github.com/users/mrcdk/orgs","repos_url":"https://api.github.com/users/mrcdk/repos","events_url":"https://api.github.com/users/mrcdk/events{/privacy}","received_events_url":"https://api.github.com/users/mrcdk/received_events","type":"User","site_admin":false},"repo":{"id":12708705,"name":"flixel","full_name":"mrcdk/flixel","owner":{"login":"mrcdk","id":483531,"avatar_url":"https://avatars.githubusercontent.com/u/483531?","gravatar_id":"780c8bde68a83bdae75112fc046290ae","url":"https://api.github.com/users/mrcdk","html_url":"https://github.com/mrcdk","followers_url":"https://api.github.com/users/mrcdk/followers","following_url":"https://api.github.com/users/mrcdk/following{/other_user}","gists_url":"https://api.github.com/users/mrcdk/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcdk/subscriptions","organizations_url":"https://api.github.com/users/mrcdk/orgs","repos_url":"https://api.github.com/users/mrcdk/repos","events_url":"https://api.github.com/users/mrcdk/events{/privacy}","received_events_url":"https://api.github.com/users/mrcdk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrcdk/flixel","description":"HaxeFlixel is a 2D game framework built with OpenFL and Haxe that delivers cross platform games, completely free for personal or commercial use. It is an evolution and extension of the opensource work shared by Adam Atomic's AS3 Flixel and Richard Davey's Power Tools.","fork":true,"url":"https://api.github.com/repos/mrcdk/flixel","forks_url":"https://api.github.com/repos/mrcdk/flixel/forks","keys_url":"https://api.github.com/repos/mrcdk/flixel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrcdk/flixel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrcdk/flixel/teams","hooks_url":"https://api.github.com/repos/mrcdk/flixel/hooks","issue_events_url":"https://api.github.com/repos/mrcdk/flixel/issues/events{/number}","events_url":"https://api.github.com/repos/mrcdk/flixel/events","assignees_url":"https://api.github.com/repos/mrcdk/flixel/assignees{/user}","branches_url":"https://api.github.com/repos/mrcdk/flixel/branches{/branch}","tags_url":"https://api.github.com/repos/mrcdk/flixel/tags","blobs_url":"https://api.github.com/repos/mrcdk/flixel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrcdk/flixel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrcdk/flixel/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrcdk/flixel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrcdk/flixel/statuses/{sha}","languages_url":"https://api.github.com/repos/mrcdk/flixel/languages","stargazers_url":"https://api.github.com/repos/mrcdk/flixel/stargazers","contributors_url":"https://api.github.com/repos/mrcdk/flixel/contributors","subscribers_url":"https://api.github.com/repos/mrcdk/flixel/subscribers","subscription_url":"https://api.github.com/repos/mrcdk/flixel/subscription","commits_url":"https://api.github.com/repos/mrcdk/flixel/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrcdk/flixel/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrcdk/flixel/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrcdk/flixel/issues/comments/{number}","contents_url":"https://api.github.com/repos/mrcdk/flixel/contents/{+path}","compare_url":"https://api.github.com/repos/mrcdk/flixel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrcdk/flixel/merges","archive_url":"https://api.github.com/repos/mrcdk/flixel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrcdk/flixel/downloads","issues_url":"https://api.github.com/repos/mrcdk/flixel/issues{/number}","pulls_url":"https://api.github.com/repos/mrcdk/flixel/pulls{/number}","milestones_url":"https://api.github.com/repos/mrcdk/flixel/milestones{/number}","notifications_url":"https://api.github.com/repos/mrcdk/flixel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrcdk/flixel/labels{/name}","releases_url":"https://api.github.com/repos/mrcdk/flixel/releases{/id}","created_at":"2013-09-09T18:07:53Z","updated_at":"2014-07-02T04:42:56Z","pushed_at":"2014-07-14T21:49:18Z","git_url":"git://github.com/mrcdk/flixel.git","ssh_url":"git@github.com:mrcdk/flixel.git","clone_url":"https://github.com/mrcdk/flixel.git","svn_url":"https://github.com/mrcdk/flixel","homepage":"http://www.haxeflixel.com/","size":16390,"stargazers_count":0,"watchers_count":0,"language":"Haxe","has_issues":false,"has_downloads":true,"has_wiki":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"HaxeFlixel:dev","ref":"dev","sha":"685c3eef13e89df533ef94719bdffa700275f0b8","user":{"login":"HaxeFlixel","id":4309553,"avatar_url":"https://avatars.githubusercontent.com/u/4309553?","gravatar_id":"96155ad8e262fda9d8eea953c629535c","url":"https://api.github.com/users/HaxeFlixel","html_url":"https://github.com/HaxeFlixel","followers_url":"https://api.github.com/users/HaxeFlixel/followers","following_url":"https://api.github.com/users/HaxeFlixel/following{/other_user}","gists_url":"https://api.github.com/users/HaxeFlixel/gists{/gist_id}","starred_url":"https://api.github.com/users/HaxeFlixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaxeFlixel/subscriptions","organizations_url":"https://api.github.com/users/HaxeFlixel/orgs","repos_url":"https://api.github.com/users/HaxeFlixel/repos","events_url":"https://api.github.com/users/HaxeFlixel/events{/privacy}","received_events_url":"https://api.github.com/users/HaxeFlixel/received_events","type":"Organization","site_admin":false},"repo":{"id":2101031,"name":"flixel","full_name":"HaxeFlixel/flixel","owner":{"login":"HaxeFlixel","id":4309553,"avatar_url":"https://avatars.githubusercontent.com/u/4309553?","gravatar_id":"96155ad8e262fda9d8eea953c629535c","url":"https://api.github.com/users/HaxeFlixel","html_url":"https://github.com/HaxeFlixel","followers_url":"https://api.github.com/users/HaxeFlixel/followers","following_url":"https://api.github.com/users/HaxeFlixel/following{/other_user}","gists_url":"https://api.github.com/users/HaxeFlixel/gists{/gist_id}","starred_url":"https://api.github.com/users/HaxeFlixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaxeFlixel/subscriptions","organizations_url":"https://api.github.com/users/HaxeFlixel/orgs","repos_url":"https://api.github.com/users/HaxeFlixel/repos","events_url":"https://api.github.com/users/HaxeFlixel/events{/privacy}","received_events_url":"https://api.github.com/users/HaxeFlixel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HaxeFlixel/flixel","description":"Free, cross-platform 2D game engine powered by Haxe and OpenFL","fork":false,"url":"https://api.github.com/repos/HaxeFlixel/flixel","forks_url":"https://api.github.com/repos/HaxeFlixel/flixel/forks","keys_url":"https://api.github.com/repos/HaxeFlixel/flixel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HaxeFlixel/flixel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HaxeFlixel/flixel/teams","hooks_url":"https://api.github.com/repos/HaxeFlixel/flixel/hooks","issue_events_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/events{/number}","events_url":"https://api.github.com/repos/HaxeFlixel/flixel/events","assignees_url":"https://api.github.com/repos/HaxeFlixel/flixel/assignees{/user}","branches_url":"https://api.github.com/repos/HaxeFlixel/flixel/branches{/branch}","tags_url":"https://api.github.com/repos/HaxeFlixel/flixel/tags","blobs_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/refs{/sha}","trees_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HaxeFlixel/flixel/statuses/{sha}","languages_url":"https://api.github.com/repos/HaxeFlixel/flixel/languages","stargazers_url":"https://api.github.com/repos/HaxeFlixel/flixel/stargazers","contributors_url":"https://api.github.com/repos/HaxeFlixel/flixel/contributors","subscribers_url":"https://api.github.com/repos/HaxeFlixel/flixel/subscribers","subscription_url":"https://api.github.com/repos/HaxeFlixel/flixel/subscription","commits_url":"https://api.github.com/repos/HaxeFlixel/flixel/commits{/sha}","git_commits_url":"https://api.github.com/repos/HaxeFlixel/flixel/git/commits{/sha}","comments_url":"https://api.github.com/repos/HaxeFlixel/flixel/comments{/number}","issue_comment_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/comments/{number}","contents_url":"https://api.github.com/repos/HaxeFlixel/flixel/contents/{+path}","compare_url":"https://api.github.com/repos/HaxeFlixel/flixel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HaxeFlixel/flixel/merges","archive_url":"https://api.github.com/repos/HaxeFlixel/flixel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HaxeFlixel/flixel/downloads","issues_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues{/number}","pulls_url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls{/number}","milestones_url":"https://api.github.com/repos/HaxeFlixel/flixel/milestones{/number}","notifications_url":"https://api.github.com/repos/HaxeFlixel/flixel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HaxeFlixel/flixel/labels{/name}","releases_url":"https://api.github.com/repos/HaxeFlixel/flixel/releases{/id}","created_at":"2011-07-25T13:12:48Z","updated_at":"2014-07-14T16:35:15Z","pushed_at":"2014-07-14T15:10:25Z","git_url":"git://github.com/HaxeFlixel/flixel.git","ssh_url":"git@github.com:HaxeFlixel/flixel.git","clone_url":"https://github.com/HaxeFlixel/flixel.git","svn_url":"https://github.com/HaxeFlixel/flixel","homepage":"http://www.haxeflixel.com/","size":37548,"stargazers_count":541,"watchers_count":541,"language":"Haxe","has_issues":true,"has_downloads":true,"has_wiki":false,"forks_count":134,"mirror_url":null,"open_issues_count":95,"forks":134,"open_issues":95,"watchers":541,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1224"},"html":{"href":"https://github.com/HaxeFlixel/flixel/pull/1224"},"issue":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1224"},"comments":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1224/comments"},"review_comments":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1224/comments"},"review_comment":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1224/commits"},"statuses":{"href":"https://api.github.com/repos/HaxeFlixel/flixel/statuses/6deb32a64da2f6554af1abe43862a19898b3dc5b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":4,"additions":175,"deletions":32,"changed_files":2}}