GitHub PullRequestReviewCommentEvent at 2014-10-14 15:31:35
Repository: dosomething
Actor: aaronschachter
Payload: {"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/dosomething/pulls/comments/18836419","id":18836419,"diff_hunk":"@@ -19,6 +19,78 @@ function dosomething_user_update_7002() {\n }\n \n /**\n+ * Cancels temporary users accounts at the affiliate sites.\n+ */\n+function dosomething_user_update_7011(&$sandbox) {","path":"lib/modules/dosomething/dosomething_user/dosomething_user.install","position":6,"original_position":6,"commit_id":"f16515edf5016d7c244a6c429428e2e98597fce8","original_commit_id":"f16515edf5016d7c244a6c429428e2e98597fce8","user":{"login":"aaronschachter","id":1236811,"avatar_url":"https://avatars.githubusercontent.com/u/1236811?v=2","gravatar_id":"","url":"https://api.github.com/users/aaronschachter","html_url":"https://github.com/aaronschachter","followers_url":"https://api.github.com/users/aaronschachter/followers","following_url":"https://api.github.com/users/aaronschachter/following{/other_user}","gists_url":"https://api.github.com/users/aaronschachter/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronschachter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronschachter/subscriptions","organizations_url":"https://api.github.com/users/aaronschachter/orgs","repos_url":"https://api.github.com/users/aaronschachter/repos","events_url":"https://api.github.com/users/aaronschachter/events{/privacy}","received_events_url":"https://api.github.com/users/aaronschachter/received_events","type":"User","site_admin":false},"body":"Yeah we haven't used the module version numbers consistently with our update hooks... we had to add them to prevent Features overrides.  https://github.com/DoSomething/dosomething/pull/1522/files\r\n\r\n@sergii-tkachenko Any thoughts on what would make the most sense?  Jumping up to version 1001?  Or keeping consistent, 7011... I don't mind keeping consistent since the same situation happens in a lot of other modules... ","created_at":"2014-10-14T15:31:35Z","updated_at":"2014-10-14T15:31:35Z","html_url":"https://github.com/DoSomething/dosomething/pull/3095#discussion_r18836419","pull_request_url":"https://api.github.com/repos/DoSomething/dosomething/pulls/3095","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/dosomething/pulls/comments/18836419"},"html":{"href":"https://github.com/DoSomething/dosomething/pull/3095#discussion_r18836419"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/dosomething/pulls/3095"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/dosomething/pulls/3095","id":21537588,"html_url":"https://github.com/DoSomething/dosomething/pull/3095","diff_url":"https://github.com/DoSomething/dosomething/pull/3095.diff","patch_url":"https://github.com/DoSomething/dosomething/pull/3095.patch","issue_url":"https://api.github.com/repos/DoSomething/dosomething/issues/3095","number":3095,"state":"open","locked":false,"title":"Cancel temporary user accounts at the affiliate sites.","user":{"login":"sergii-tkachenko","id":672669,"avatar_url":"https://avatars.githubusercontent.com/u/672669?v=2","gravatar_id":"","url":"https://api.github.com/users/sergii-tkachenko","html_url":"https://github.com/sergii-tkachenko","followers_url":"https://api.github.com/users/sergii-tkachenko/followers","following_url":"https://api.github.com/users/sergii-tkachenko/following{/other_user}","gists_url":"https://api.github.com/users/sergii-tkachenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergii-tkachenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergii-tkachenko/subscriptions","organizations_url":"https://api.github.com/users/sergii-tkachenko/orgs","repos_url":"https://api.github.com/users/sergii-tkachenko/repos","events_url":"https://api.github.com/users/sergii-tkachenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergii-tkachenko/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\n- Cancels temporary users accounts on DoSomething UK\r\n\r\n#### Any background context you want to provide?\r\n- There are more than on and a half million users unrelated to DoSomething UK\r\n- To handle this I provided a module update that removes these users in batches of 50\r\n- Criterias I used to determin wheter a user is to delete:\r\n  - User registration source is not `dosomething_uk`\r\n  - User is not an `editor` or `administrator`\r\n- I tested this on my local setup — works perfect\r\n\r\n#### How should this be manually tested?\r\n- Enable `dosomething_uk` module\r\n- Patch your source of this PR\r\n- Run Drupal update\r\n\r\n#### What are the relevant tickets?\r\nCloses [#DS-411](https://jira.dosomething.org/browse/DS-411).\r\n","created_at":"2014-09-20T13:56:07Z","updated_at":"2014-10-14T15:31:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a166301bc0b30148de0e6db4537687233abf974f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/dosomething/pulls/3095/commits","review_comments_url":"https://api.github.com/repos/DoSomething/dosomething/pulls/3095/comments","review_comment_url":"https://api.github.com/repos/DoSomething/dosomething/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DoSomething/dosomething/issues/3095/comments","statuses_url":"https://api.github.com/repos/DoSomething/dosomething/statuses/f16515edf5016d7c244a6c429428e2e98597fce8","head":{"label":"sergii-tkachenko:DS-256_uk-cancell-temporary-users","ref":"DS-256_uk-cancell-temporary-users","sha":"f16515edf5016d7c244a6c429428e2e98597fce8","user":{"login":"sergii-tkachenko","id":672669,"avatar_url":"https://avatars.githubusercontent.com/u/672669?v=2","gravatar_id":"","url":"https://api.github.com/users/sergii-tkachenko","html_url":"https://github.com/sergii-tkachenko","followers_url":"https://api.github.com/users/sergii-tkachenko/followers","following_url":"https://api.github.com/users/sergii-tkachenko/following{/other_user}","gists_url":"https://api.github.com/users/sergii-tkachenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergii-tkachenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergii-tkachenko/subscriptions","organizations_url":"https://api.github.com/users/sergii-tkachenko/orgs","repos_url":"https://api.github.com/users/sergii-tkachenko/repos","events_url":"https://api.github.com/users/sergii-tkachenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergii-tkachenko/received_events","type":"User","site_admin":false},"repo":{"id":23975176,"name":"dosomething","full_name":"sergii-tkachenko/dosomething","owner":{"login":"sergii-tkachenko","id":672669,"avatar_url":"https://avatars.githubusercontent.com/u/672669?v=2","gravatar_id":"","url":"https://api.github.com/users/sergii-tkachenko","html_url":"https://github.com/sergii-tkachenko","followers_url":"https://api.github.com/users/sergii-tkachenko/followers","following_url":"https://api.github.com/users/sergii-tkachenko/following{/other_user}","gists_url":"https://api.github.com/users/sergii-tkachenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergii-tkachenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergii-tkachenko/subscriptions","organizations_url":"https://api.github.com/users/sergii-tkachenko/orgs","repos_url":"https://api.github.com/users/sergii-tkachenko/repos","events_url":"https://api.github.com/users/sergii-tkachenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergii-tkachenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergii-tkachenko/dosomething","description":"A Drupal 7 distribution that powers the DoSomething.org web platform.","fork":true,"url":"https://api.github.com/repos/sergii-tkachenko/dosomething","forks_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/forks","keys_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/teams","hooks_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/hooks","issue_events_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/issues/events{/number}","events_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/events","assignees_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/assignees{/user}","branches_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/branches{/branch}","tags_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/tags","blobs_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/statuses/{sha}","languages_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/languages","stargazers_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/stargazers","contributors_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/contributors","subscribers_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/subscribers","subscription_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/subscription","commits_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/issues/comments/{number}","contents_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/contents/{+path}","compare_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/merges","archive_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/downloads","issues_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/issues{/number}","pulls_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/pulls{/number}","milestones_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/milestones{/number}","notifications_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/labels{/name}","releases_url":"https://api.github.com/repos/sergii-tkachenko/dosomething/releases{/id}","created_at":"2014-09-12T20:09:49Z","updated_at":"2014-09-15T16:33:39Z","pushed_at":"2014-10-13T13:19:52Z","git_url":"git://github.com/sergii-tkachenko/dosomething.git","ssh_url":"git@github.com:sergii-tkachenko/dosomething.git","clone_url":"https://github.com/sergii-tkachenko/dosomething.git","svn_url":"https://github.com/sergii-tkachenko/dosomething","homepage":"http://www.dosomething.org/","size":9838,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"DoSomething:dev","ref":"dev","sha":"26f0859667eafd29da1cedd17682bb6be32d457c","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=2","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":13592927,"name":"dosomething","full_name":"DoSomething/dosomething","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=2","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/dosomething","description":"A Drupal 7 distribution that powers the DoSomething.org web platform.","fork":false,"url":"https://api.github.com/repos/DoSomething/dosomething","forks_url":"https://api.github.com/repos/DoSomething/dosomething/forks","keys_url":"https://api.github.com/repos/DoSomething/dosomething/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/dosomething/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/dosomething/teams","hooks_url":"https://api.github.com/repos/DoSomething/dosomething/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/dosomething/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/dosomething/events","assignees_url":"https://api.github.com/repos/DoSomething/dosomething/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/dosomething/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/dosomething/tags","blobs_url":"https://api.github.com/repos/DoSomething/dosomething/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/dosomething/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/dosomething/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/dosomething/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/dosomething/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/dosomething/languages","stargazers_url":"https://api.github.com/repos/DoSomething/dosomething/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/dosomething/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/dosomething/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/dosomething/subscription","commits_url":"https://api.github.com/repos/DoSomething/dosomething/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/dosomething/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/dosomething/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/dosomething/issues/comments/{number}","contents_url":"https://api.github.com/repos/DoSomething/dosomething/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/dosomething/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/dosomething/merges","archive_url":"https://api.github.com/repos/DoSomething/dosomething/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/dosomething/downloads","issues_url":"https://api.github.com/repos/DoSomething/dosomething/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/dosomething/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/dosomething/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/dosomething/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/dosomething/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/dosomething/releases{/id}","created_at":"2013-10-15T14:50:48Z","updated_at":"2014-10-09T15:46:26Z","pushed_at":"2014-10-10T20:27:00Z","git_url":"git://github.com/DoSomething/dosomething.git","ssh_url":"git@github.com:DoSomething/dosomething.git","clone_url":"https://github.com/DoSomething/dosomething.git","svn_url":"https://github.com/DoSomething/dosomething","homepage":"http://www.dosomething.org/","size":40320,"stargazers_count":16,"watchers_count":16,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":148,"forks":8,"open_issues":148,"watchers":16,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/dosomething/pulls/3095"},"html":{"href":"https://github.com/DoSomething/dosomething/pull/3095"},"issue":{"href":"https://api.github.com/repos/DoSomething/dosomething/issues/3095"},"comments":{"href":"https://api.github.com/repos/DoSomething/dosomething/issues/3095/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/dosomething/pulls/3095/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/dosomething/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/dosomething/pulls/3095/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/dosomething/statuses/f16515edf5016d7c244a6c429428e2e98597fce8"}}}}