GitHub PushEvent at 2014-12-15 15:56:27
Repository: carrierwave
Actor: machisuji
Payload: {"shas":[["f6d5f68d48f617bc1f479a97b006629288b8ac5f","44bd5c3030107091eca8b4e8cdef0e8b12d1f90e@googlemail.com","Fixed filename which was returning random strings\n\ncf.\r\n\r\n```\r\n[103] pry(main)> URI.decode('https://wulst.s3-eu-west-1.amazonaws.com/uploads/attachment/file/140/guy.rb?AWSAccessKeyId=24g24t82g4248g&Signature=Efq9pbU/sOtpm6SdDquaVzuY9/Q%3D&Expires=1418659279').gsub(/.*\\/(.*?$)/, '\\1').split('?').first\r\n=> \"Q=&Expires=1418659279\"\r\n```\r\n\r\nThe regex fails if the signature contains slashes. I might add a test. Just noting that not to forget about it.","Markus Kahl",true]],"size":1,"ref":"refs/heads/patch-1","head":"f6d5f68d48f617bc1f479a97b006629288b8ac5f"}