Updated openstack/openstack
Project: openstack/nova  c032ab8696aa4b2cb0cebd5f711e123b1e3b0ed7
null
Refactors unit tests of image service detail()

We do not need to have "unit" tests that test the things like
pagination work with the glanceclient.images.detail() call. glanceclient
and glance have unit tests for that. What the unit tests for the glance
image service detail() method in Nova need is to test only the code
boundary that exists within the detail() method -- i.e. verify that the
calls to the glanceclient and other helper methods are made with the
right parameters.

This patch pulls the various unit tests out of the
TestGlanceImageService test class and into their own test class that
uses mocks and verifies each code path within the detail() method.

Next up is the create, update and delete methods of the
GlanceImageService class. The final piece is to rework the download unit
tests (which aren't unit tests but more functional tests that take
around a second each to run :(

Change-Id: I94897ff54a36a1af4258ba4a3c88b45c079f4bb5
Related-bug: #1293938
Updated openstack/openstack
Project: openstack/keystone  7882359da114079e8411bd3f97c5628f2cd1c098
null
Safer noqa handling

"# flake8: noqa" was used in several files. This causes the
entire file to not be checked by flake8. This is unsafe, and
"# noqa" should be used only on those lines that require it.

E712 doesn't honor #noqa, so work around it by assigning True to a
variable.

Change-Id: I1ddd1c4f4230793f0560241e4559095cb4183d71